gdb/ChangeLog

   1 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
   2
   3         * coffread.c (record_minimal_symbol): Update.
   4         (process_coff_symbol): Update.
   5         * dbxread.c (read_dbx_symtab): Update.
   6         * dwarf2read.c (add_partial_symbol): Update.
   7         (fixup_go_packaging): Update.
   8         (load_partial_dies): Update.
   9         (new_symbol): Update.
  10         * elfread.c (record_minimal_symbol): Change signature to use
  11         gdb::string_view instead of name+len.
  12         (elf_symtab_read): Update.
  13         (elf_rel_plt_read): Update.
  14         * mdebugread.c (parse_partial_symbols): Update.
  15         (handle_psymbol_enumerators): Update.
  16         (new_symbol): Update.
  17         * minsyms.c (minimal_symbol_reader::record_full): Change signature
  18         to use gdb::string_view instead of name+len.
  19         * minsyms.h (class minimal_symbol_reader) <record_full>: Likewise.
  20         * psympriv.h (add_psymbol_to_list): Likewise.
  21         * psymtab.c (add_psymbol_to_bcache): Likewise.
  22         (add_psymbol_to_list): Likewise.
  23         * stabsread.c (define_symbol): Update.
  24         * symtab.c (symbol_set_names): Change signature to use gdb::string_view.
  25         * symtab.h (SYMBOL_SET_NAMES): Likewise.
  26         (symbol_set_names): Likewise.
  27         * xcoffread.c (scan_xcoff_symtab): Update.
  28
  29 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
  30
  31         * symtab.h (symbol_set_names): Document that copy_name must be
  32         set to true for non-nullterminated strings.
  33         * symtab.c (symbol_set_names): Only make a nullterminated copy of
  34         linkage_name if the entry was not found and we need to demangle.
  35
  36 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
  37
  38         * Makefile.in (HFILES_NO_SRCDIR): Add gdb_binary_search.h.
  39         * dwarf2-frame.c (bsearch_fde_cmp): Update.
  40         (dwarf2_frame_find_fde): Replace bsearch with gdb::binary_search.
  41         * gdbsupport/gdb_binary_search.h: New file.
  42
  43 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
  44
  45         * NEWS: Mention new --with-system-gdbinit-dir option.
  46         * config.in: Regenerate.
  47         * configure: Regenerate.
  48         * configure.ac: Add new option --with-system-gdbinit-dir.
  49         * extension.c (get_ext_lang_of_file): Return extension_language_gdb
  50         for a ".gdb" suffix.
  51         * main.c (get_init_files): Change system_gdbinit argument to
  52         a vector and return the files in SYSTEM_GDBINIT_DIR in
  53         addition to SYSTEM_GDBINIT.
  54         (captured_main_1): Update.
  55         (print_gdb_help): Update.
  56         * top.c (print_gdb_configuration): Also print the value of
  57         SYSTEM_GDBINIT_DIR.
  58
  59 2019-10-28  Christian Biesinger  <cbiesinger@google.com>
  60
  61         * gdbsupport/common-utils.h (startswith): Add an overloaded version
  62         that takes gdb::string_view arguments.
  63
  64 2019-10-26  Tom de Vries  <tdevries@suse.de>
  65
  66         * aarch64-linux-tdep.c: Fix typos in comments.
  67         * aarch64-tdep.c: Same.
  68         * ada-lang.c: Same.
  69         * amd64-nat.c: Same.
  70         * arc-tdep.c: Same.
  71         * arch/aarch64-insn.c: Same.
  72         * block.c: Same.
  73         * breakpoint.h: Same.
  74         * btrace.h: Same.
  75         * c-varobj.c: Same.
  76         * cli/cli-decode.c: Same.
  77         * cli/cli-script.c: Same.
  78         * cli/cli-utils.h: Same.
  79         * coff-pe-read.c: Same.
  80         * coffread.c: Same.
  81         * compile/compile-cplus-symbols.c: Same.
  82         * compile/compile-object-run.c: Same.
  83         * completer.c: Same.
  84         * corelow.c: Same.
  85         * cp-support.c: Same.
  86         * demangle.c: Same.
  87         * dwarf-index-write.c: Same.
  88         * dwarf2-frame.c: Same.
  89         * dwarf2-frame.h: Same.
  90         * eval.c: Same.
  91         * frame-base.h: Same.
  92         * frame.h: Same.
  93         * gdbcmd.h: Same.
  94         * gdbtypes.h: Same.
  95         * gnu-nat.c: Same.
  96         * guile/scm-objfile.c: Same.
  97         * i386-tdep.c: Same.
  98         * i386-tdep.h: Same.
  99         * infcall.c: Same.
 100         * infcall.h: Same.
 101         * linux-nat.c: Same.
 102         * m68k-tdep.c: Same.
 103         * macroexp.c: Same.
 104         * memattr.c: Same.
 105         * mi/mi-cmd-disas.c: Same.
 106         * mi/mi-getopt.h: Same.
 107         * mi/mi-main.c: Same.
 108         * minsyms.c: Same.
 109         * nat/aarch64-sve-linux-sigcontext.h: Same.
 110         * objfiles.h: Same.
 111         * ppc-linux-nat.c: Same.
 112         * ppc-linux-tdep.c: Same.
 113         * ppc-tdep.h: Same.
 114         * progspace.h: Same.
 115         * prologue-value.h: Same.
 116         * python/py-evtregistry.c: Same.
 117         * python/py-instruction.h: Same.
 118         * record-btrace.c: Same.
 119         * record-full.c: Same.
 120         * remote.c: Same.
 121         * rs6000-tdep.c: Same.
 122         * ser-tcp.c: Same.
 123         * sol-thread.c: Same.
 124         * sparc-sol2-tdep.c: Same.
 125         * sparc64-tdep.c: Same.
 126         * stabsread.c: Same.
 127         * symfile.c: Same.
 128         * symtab.h: Same.
 129         * target.c: Same.
 130         * tracepoint.c: Same.
 131         * tui/tui-data.h: Same.
 132         * tui/tui-io.c: Same.
 133         * tui/tui-win.c: Same.
 134         * tui/tui.c: Same.
 135         * unittests/rsp-low-selftests.c: Same.
 136         * user-regs.h: Same.
 137         * utils.c: Same.
 138         * utils.h: Same.
 139         * valarith.c: Same.
 140         * valops.c: Same.
 141         * valprint.c: Same.
 142         * valprint.h: Same.
 143         * value.c: Same.
 144         * value.h: Same.
 145         * varobj.c: Same.
 146         * x86-nat.h: Same.
 147         * xtensa-tdep.c: Same.
 148
 149 2019-10-25  Ali Tamur <tamur@google.com>
 150
 151         * charset.c (find_charset_names): Reflect API change.
 152
 153 2019-10-25  Christian Biesinger  <cbiesinger@google.com>
 154
 155         * symtab.c (struct demangled_name_entry): Change demangled name
 156         to a unique_xmalloc_ptr<char>, now that we don't allocate it as
 157         part of the struct anymore.
 158         (symbol_set_names): No longer obstack allocate + copy the demangled
 159         name, just store the allocated name from bfd.
 160
 161 2019-10-25  Tom Tromey  <tromey@adacore.com>
 162
 163         * dwarf2-frame.c (dwarf2_cie_table): Now a typedef.
 164         (bsearch_cie_cmp, add_cie): Remove.
 165         (find_cie): Reimplement.
 166         (decode_frame_entry_1, decode_frame_entry): Change type.  Update.
 167         (dwarf2_build_frame_info): Update.
 168
 169 2019-10-24  H.J. Lu  <hongjiu.lu@intel.com>
 170
 171         PR gdb/25126
 172         * symfile.c (reread_symbols): Call forget_cached_source_info to
 173         clear the stale source cache.
 174
 175 2019-10-24  Christian Biesinger  <cbiesinger@google.com>
 176
 177         * configure: Regenerate.
 178         * configure.ac: Remove code that sets python_has_threads.
 179
 180 2019-10-24  Christian Biesinger  <cbiesinger@google.com>
 181
 182         * config.in: Regenerate.
 183         * configure: Regenerate.
 184         * configure.ac: Remove the code that uses sed to get the python
 185         version and defines HAVE_LIBPYTHON2_6 / HAVE_LIBPYTHON2_7.
 186
 187 2019-10-24  Andrew Burgess  <andrew.burgess@embecosm.com>
 188
 189         * python/py-progspace.c (pspy_block_for_pc): Return None for all
 190         error paths.
 191
 192 2019-10-23  Tom Tromey  <tom@tromey.com>
 193
 194         * arc-tdep.c: Remove ".." from include.
 195         * frv-tdep.c: Remove ".." from include.
 196         * lm32-tdep.c: Remove ".." from include.
 197         * microblaze-tdep.c: Remove ".." from include.
 198         * or1k-tdep.h: Remove ".." from include.
 199         * s12z-tdep.c: Remove ".." from include.
 200         * Makefile.in (OPCODES_CFLAGS): Add comment.
 201         (TOP_CFLAGS): New variable.
 202         (INTERNAL_CFLAGS_BASE): Add TOP_CFLAGS.
 203
 204 2019-10-23  Tom Tromey  <tom@tromey.com>
 205
 206         * Makefile.in (READLINE_DIR): Update.
 207
 208 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 209
 210         * infcall.c (call_function_by_hand_dummy): Fix the function
 211         comment.  And extract out a code section into...
 212         (reserve_stack_space): ...this new function.
 213
 214 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 215
 216         * infcall.c (value_arg_coerce): Remove an unused parameter.
 217         (call_function_by_hand_dummy): Update the call to
 218         'value_arg_coerce'.
 219
 220 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 221
 222         * infcall.c (call_function_by_hand_dummy): Refactor.
 223
 224 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 225
 226         * MAINTAINERS (Write After Approval): Add Tankut Baris Aktemur.
 227
 228 2019-10-23  Tom Tromey  <tom@tromey.com>
 229
 230         * configure: Rebuild.
 231         * configure.ac: Don't check for sigprocmask.
 232         * gdbsupport/common.m4 (GDB_AC_COMMON): Check for sigprocmask.
 233
 234 2019-10-23  Tom Tromey  <tom@tromey.com>
 235
 236         * configure: Rebuild.
 237         * acinclude.m4: Use m4_include, not sinclude.
 238
 239 2019-10-23  Tom de Vries  <tdevries@suse.de>
 240
 241         PR breakpoints/24687
 242         * symtab.c (iterate_over_some_symtabs): Apply gdb_realpath on fullname.
 243
 244 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
 245
 246         * symtab.c (struct demangled_name_entry) <language>: Change from
 247         bitfield to regular variable.
 248
 249 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
 250
 251         * symtab.c (struct demangled_name_entry): Add a constructor.
 252         (free_demangled_name_entry): New function to call the destructor
 253         for demangled_name_entry.
 254         (create_demangled_names_hash): Pass free_demangled_name_entry to
 255         htab_create_alloc.
 256         (symbol_set_names): Call placement new for demangled_name_entry.
 257         * utils.c: No longer include xxhash.h here, now that fast_hash
 258         is inlined in the header.
 259         * utils.h: Instead, include it here.
 260
 261 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
 262
 263         * Makefile.in: Link with libxxhash.
 264         * config.in: Regenerate.
 265         * configure: Regenerate.
 266         * configure.ac: Search for libxxhash.
 267         * utils.c (fast_hash): Use xxhash if present.
 268
 269 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
 270
 271         * utils.h (fast_hash): New function.
 272         * symtab.c (hash_demangled_name_entry): Call new function
 273         fast_hash.
 274
 275 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
 276
 277         * symtab.c (struct demangled_name_entry): Change type of mangled
 278         to gdb::string_view. Also adds a constructor that takes the
 279         mangled name.
 280         (hash_demangled_name_entry): Update.
 281         (eq_demangled_name_entry): Update.
 282         (free_demangled_name_entry): New function to call the destructor
 283         now that this is not a POD anymore.
 284         (create_demangled_names_hash): Pass free_demangled_name_entry to
 285         htab_create_alloc.
 286         (symbol_set_names): Update.
 287
 288 2019-10-21  Ali Tamur  <tamu@google.com>
 289
 290         * dwarf2read.c (dir_index): Change type.
 291         (file_name_index): Likewise.
 292         (line_header::include_dir_at): Change comment and implementation on
 293         whether it is DWARF 5.
 294         (line_header::is_valid_file_index): New function.
 295         (line_header::file_name_at): Change comment and implementation on
 296         whether it is DWARF 5.
 297         (line_header::file_names): Change to private field renamed as
 298         m_file_names and introduce a new accessor method.
 299         (line_header::file_names_size): New method.
 300         (line_header::include_dirs): Change to private field and rename as
 301         m_include_dirs.
 302         (dw2_get_file_names_reader): Define local var at a smaller scope and
 303         reflect API change.
 304         (dwarf2_cu::setup_type_unit_groups): Reflect API change.
 305         (process_structure_scope): Likewise.
 306         (line_header::add_include_dir): Change message and reflect renaming.
 307         (line_header::add_file_name): Likewise.
 308         (read_formatted_entries): Handle DW_FORM_data16.
 309         (dwarf_decode_line_header): Fix line header length calculation.
 310         (psymtab_include_file_name): Change comment and API.
 311         (lnp_state_machine::m_file): Update comment and reflect type change.
 312         (lnp_state_machine::record_line): Reflect type change.
 313         (dwarf_decode_lines): Reflect API change.
 314         (file_file_name): Likewise.
 315         (file_full_name): Likewise.
 316
 317 2019-10-21  Andrew Burgess  <andrew.burgess@embecosm.com>
 318
 319         * objfiles.c (sort_cmp): Ensure that !(a < a) holds true.
 320
 321 2019-10-21  Tom Tromey  <tom@tromey.com>
 322
 323         * tui/tui-winsource.h (tui_exec_info_content): Remove typedef.
 324
 325 2019-10-21  Tom Tromey  <tom@tromey.com>
 326
 327         * configure.ac (nm.h): Conditionally create nm.h link.  Subst
 328         NM_H.   Use AC_CONFIG_LINKS.
 329         * configure: Rebuild.
 330         * Makefile.in (NM_H): New variable.
 331         (generated_files): Add NM_H.  Remove gcore.
 332         (nm.h, stamp-nmh): New targets.
 333
 334 2019-10-20  Tom Tromey  <tom@tromey.com>
 335
 336         * objfiles.h (unlink_objfile, put_objfile_before): Don't declare.
 337         * objfiles.c (unlink_objfile): Move earlier.  Now static.  Remove
 338         obsolete comment.
 339         (put_objfile_before): Now static.
 340
 341 2019-10-19  Simon Marchi  <simon.marchi@polymtl.ca>
 342
 343         * gdbsupport/common-utils.h (startswith): Change return type to
 344         bool.
 345
 346 2019-10-19  Christian Biesinger  <cbiesinger@google.com>
 347
 348         * bcache.c (bcache::print_statistics): Use std::sort instead of qsort.
 349         * breakpoint.c (bp_locations_compare): Rename to...
 350         (bp_location_is_less_than): ...this, and change to std::sort semantics.
 351         (update_global_location_list): Use std::sort instead of qsort.
 352         * buildsym.c (compare_line_numbers): Rename to...
 353         (lte_is_less_than): ...this, and change to std::sort semantics.
 354         (buildsym_compunit::end_symtab_with_blockvector): Use std::sort
 355         instead of qsort.
 356         * disasm.c (compare_lines): Rename to...
 357         (line_is_less_than): ...this, and change to std::sort semantics.
 358         (do_mixed_source_and_assembly_deprecated): Call std::sort instead
 359         of qsort.
 360         * dwarf2-frame.c (qsort_fde_cmp): Rename to...
 361         (fde_is_less_than): ...this, and change to std::sort semantics.
 362         (dwarf2_build_frame_info): Call std::sort instead of qsort.
 363         * mdebugread.c (compare_blocks):
 364         (block_is_less_than): ...this, and change to std::sort semantics.
 365         (sort_blocks): Call std::sort instead of qsort.
 366         * objfiles.c (qsort_cmp): Rename to...
 367         (sort_cmp): ...this, and change to std::sort semantics.
 368         (update_section_map): Call std::sort instead of qsort.
 369         * remote.c (compare_pnums): Remove.
 370         (map_regcache_remote_table): Call std::sort instead of qsort.
 371         * utils.c (compare_positive_ints): Remove.
 372         * utils.h (compare_positive_ints): Remove.
 373         * xcoffread.c (compare_lte): Remove.
 374         (arrange_linetable): Call std::sort instead of qsort.
 375
 376 2019-10-19  Sergio Durigan Junior  <sergiodj@redhat.com>
 377
 378         * symfile.c (init_entry_point_info): Fix typo.
 379         * i386-darwin-tdep.c (darwin_dwarf_signal_frame_p): Fix typo.
 380
 381 2019-10-18  Tom de Vries  <tdevries@suse.de>
 382
 383         * aarch64-tdep.c: Fix typos in comments.
 384         * ada-lang.c: Same.
 385         * ada-tasks.c: Same.
 386         * alpha-tdep.c: Same.
 387         * alpha-tdep.h: Same.
 388         * amd64-nat.c: Same.
 389         * amd64-windows-tdep.c: Same.
 390         * arc-tdep.c: Same.
 391         * arc-tdep.h: Same.
 392         * arch-utils.c: Same.
 393         * arm-nbsd-tdep.c: Same.
 394         * arm-tdep.c: Same.
 395         * ax-gdb.c: Same.
 396         * blockframe.c: Same.
 397         * btrace.c: Same.
 398         * c-varobj.c: Same.
 399         * coff-pe-read.c: Same.
 400         * coffread.c: Same.
 401         * cris-tdep.c: Same.
 402         * darwin-nat.c: Same.
 403         * dbxread.c: Same.
 404         * dcache.c: Same.
 405         * disasm.c: Same.
 406         * dtrace-probe.c: Same.
 407         * dwarf-index-write.c: Same.
 408         * dwarf2-frame-tailcall.c: Same.
 409         * dwarf2-frame.c: Same.
 410         * dwarf2read.c: Same.
 411         * eval.c: Same.
 412         * exceptions.c: Same.
 413         * fbsd-tdep.c: Same.
 414         * findvar.c: Same.
 415         * frame.c: Same.
 416         * frv-tdep.c: Same.
 417         * gnu-v3-abi.c: Same.
 418         * go32-nat.c: Same.
 419         * h8300-tdep.c: Same.
 420         * hppa-tdep.c: Same.
 421         * i386-linux-tdep.c: Same.
 422         * i386-tdep.c: Same.
 423         * ia64-libunwind-tdep.c: Same.
 424         * ia64-tdep.c: Same.
 425         * infcmd.c: Same.
 426         * infrun.c: Same.
 427         * linespec.c: Same.
 428         * linux-nat.c: Same.
 429         * linux-thread-db.c: Same.
 430         * machoread.c: Same.
 431         * mdebugread.c: Same.
 432         * mep-tdep.c: Same.
 433         * mn10300-tdep.c: Same.
 434         * namespace.c: Same.
 435         * objfiles.c: Same.
 436         * opencl-lang.c: Same.
 437         * or1k-tdep.c: Same.
 438         * osabi.c: Same.
 439         * ppc-linux-nat.c: Same.
 440         * ppc-linux-tdep.c: Same.
 441         * ppc-sysv-tdep.c: Same.
 442         * printcmd.c: Same.
 443         * procfs.c: Same.
 444         * record-btrace.c: Same.
 445         * record-full.c: Same.
 446         * remote-fileio.c: Same.
 447         * remote.c: Same.
 448         * rs6000-tdep.c: Same.
 449         * s12z-tdep.c: Same.
 450         * score-tdep.c: Same.
 451         * ser-base.c: Same.
 452         * ser-go32.c: Same.
 453         * skip.c: Same.
 454         * sol-thread.c: Same.
 455         * solib-svr4.c: Same.
 456         * solib.c: Same.
 457         * source.c: Same.
 458         * sparc-nat.c: Same.
 459         * sparc-sol2-tdep.c: Same.
 460         * sparc-tdep.c: Same.
 461         * sparc64-tdep.c: Same.
 462         * stabsread.c: Same.
 463         * stack.c: Same.
 464         * symfile.c: Same.
 465         * symtab.c: Same.
 466         * target-descriptions.c: Same.
 467         * target-float.c: Same.
 468         * thread.c: Same.
 469         * utils.c: Same.
 470         * valops.c: Same.
 471         * valprint.c: Same.
 472         * value.c: Same.
 473         * varobj.c: Same.
 474         * windows-nat.c: Same.
 475         * xcoffread.c: Same.
 476         * xstormy16-tdep.c: Same.
 477         * xtensa-tdep.c: Same.
 478
 479 2019-10-17  Tom Tromey  <tromey@adacore.com>
 480
 481         * configure: Rebuild.
 482         * configure.ac: Use AC_CONFIG_HEADERS.  Create stamp-h there, not
 483         in AC_CONFIG_FILES invocation.
 484         * Makefile.in (Makefile, data-directory/Makefile, stamp-h): Use
 485         new-style config.status invocation.
 486
 487 2019-10-17  Tom de Vries  <tdevries@suse.de>
 488
 489         * arm-nbsd-nat.c: Fix typos in comments.
 490         * arm-tdep.c: Same.
 491         * darwin-nat-info.c: Same.
 492         * dwarf2read.c: Same.
 493         * elfread.c: Same.
 494         * event-top.c: Same.
 495         * findvar.c: Same.
 496         * gdbtypes.c: Same.
 497         * hppa-tdep.c: Same.
 498         * i386-tdep.c: Same.
 499         * jit.c: Same.
 500         * main.c: Same.
 501         * mdebugread.c: Same.
 502         * moxie-tdep.c: Same.
 503         * nto-procfs.c: Same.
 504         * osabi.c: Same.
 505         * ppc-linux-tdep.c: Same.
 506         * remote.c: Same.
 507         * riscv-tdep.c: Same.
 508         * s390-tdep.c: Same.
 509         * sh-tdep.c: Same.
 510         * sparc-linux-tdep.c: Same.
 511         * sparc-nat.c: Same.
 512         * stack.c: Same.
 513         * target-descriptions.c: Same.
 514         * top.c: Same.
 515         * varobj.c: Same.
 516
 517 2019-10-16  Tom Tromey  <tom@tromey.com>
 518
 519         * objfiles.h (struct objfile) <original_name>: Now const.
 520
 521 2019-10-16  Christian Biesinger  <cbiesinger@google.com>
 522
 523         * gdbsupport/gdb_setjmp.h (SIGSETJMP): Allow passing in the value to
 524         pass on to sigsetjmp's second argument.
 525         * cp-support.c (gdb_demangle): Unblock SIGSEGV if we caught a crash.
 526
 527 2019-10-16  Keith Seitz  <keiths@redhat.com>
 528
 529         PR gdb/23567
 530         * dwarf2read.c (dwarf2_per_objfile::locate_sections): Discard
 531         sections whose size is greater than the file size.
 532
 533 2019-10-16  Jim Wilson  <jimw@sifive.com>
 534
 535         * riscv-tdep.c (riscv_gcc_target_options): New.
 536         (riscv_gnu_triplet_regexp): New.
 537         (riscv_gdbarch_init): Call set_gdbarch_gcc_triplet_options and
 538         set_gdbarch_gnu_triplet_regexp.
 539
 540 2019-10-16  Christian Biesinger  <cbiesinger@google.com>
 541
 542         * Makefile.in: Add xml-builtin.h.
 543         * features/feature_to_c.sh: Add an include for xml-builtin.h
 544         to ensure that the compiler checks that the types match.
 545         * xml-builtin.h: New file.
 546         * xml-support.c (fetch_xml_builtin): Add missing const.
 547         * xml-support.h: Remove declaration of xml_builtins.
 548
 549 2019-10-16  Tom de Vries  <tdevries@suse.de>
 550
 551         PR tdep/25096
 552         * amd64-tdep.c (amd64_classify_aggregate_field): Factor out of ...
 553         (amd64_classify_aggregate): ... here.
 554         (amd64_classify_aggregate_field): Handled fiels of nested structs
 555         recursively.
 556
 557 2019-10-16  Tom de Vries  <tdevries@suse.de>
 558
 559         PR tdep/24104
 560         * amd64-tdep.c (amd64_push_arguments): Handle AMD64_NO_CLASS in loop
 561         that handles 'theclass'.
 562
 563 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 564
 565         * linespec.c (decode_digits_ordinary): Update comment.
 566         * make-target-delegates: No longer need to handle VEC case.
 567         * memrange.c (normalize_mem_ranges): Update comment.
 568         * namespace.c (add_using_directive): Update comment.
 569         * objc-lang.c (uniquify_strings): Update comment.
 570         * ppc-linux-nat.c (struct thread_points): Update comment.
 571         * probe.h (find_probes_in_objfile): Update comment.
 572         * target.h (enum flash_preserve_mode): Update comment.
 573         * varobj.c (varobj_restrict_range): Update comment.
 574         * varobj.h (varobj_list_children): Update comment.
 575
 576 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 577
 578         * Makefile.in: Remove references to vec.h and vec.c.
 579         * aarch64-tdep.c: No longer include vec.h.
 580         * ada-lang.c: Likewise.
 581         * ada-lang.h: Likewise.
 582         * arm-tdep.c: Likewise.
 583         * ax.h: Likewise.
 584         * breakpoint.h: Likewise.
 585         * charset.c: Likewise.
 586         * cp-support.h: Likewise.
 587         * dtrace-probe.c: Likewise.
 588         * dwarf2read.c: Likewise.
 589         * extension.h: Likewise.
 590         * gdb_bfd.c: Likewise.
 591         * gdbsupport/gdb_vecs.h: Likewise.
 592         * gdbsupport/vec.c: Remove.
 593         * gdbsupport/vec.h: Remove.
 594         * gdbthread.h: Likewise.
 595         * guile/scm-type.c: Likewise.
 596         * inline-frame.c: Likewise.
 597         * machoread.c: Likewise.
 598         * memattr.c: Likewise.
 599         * memrange.h: Likewise.
 600         * namespace.h: Likewise.
 601         * nat/linux-btrace.h: Likewise.
 602         * osdata.c: Likewise.
 603         * parser-defs.h: Likewise.
 604         * progspace.h: Likewise.
 605         * python/py-type.c: Likewise.
 606         * record-btrace.c: Likewise.
 607         * rust-exp.y: Likewise.
 608         * solib-target.c: Likewise.
 609         * stap-probe.c: Likewise.
 610         * target-descriptions.c: Likewise.
 611         * target-memory.c: Likewise.
 612         * target.h: Likewise.
 613         * varobj.c: Likewise.
 614         * varobj.h: Likewise.
 615         * xml-support.h: Likewise.
 616
 617 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 618
 619         * gdb/dwarf2read.c (dwarf2_per_objfile::~dwarf2_per_objfile):
 620         Update for new std::vector based implementation.
 621         (process_psymtab_comp_unit_reader): Likewise.
 622         (scan_partial_symbols): Likewise.
 623         (recursively_compute_inclusions): Likewise.
 624         (compute_compunit_symtab_includes): Likewise.
 625         (process_imported_unit_die): Likewise.
 626         (queue_and_load_dwo_tu): Likewise.
 627         (follow_die_sig_1): Likewise.
 628         * gdb/dwarf2read.h: Remove DEF_VEC_P.
 629         (typedef dwarf2_per_cu_ptr): Remove.
 630         (struct dwarf2_per_cu_data) <imported_symtabs_empty>: New
 631         function.
 632         (struct dwarf2_per_cu_data) <imported_symtabs_push>: New function.
 633         (struct dwarf2_per_cu_data) <imported_symtabs_size>: New function.
 634         (struct dwarf2_per_cu_data) <imported_symtabs_free>: New function.
 635         (struct dwarf2_per_cu_data) <imported_symtabs>: Change to
 636         std::vector.
 637
 638 2019-10-15  Tom Tromey  <tromey@adacore.com>
 639
 640         * windows-nat.c (windows_nat_target::resume): Use %x when logging
 641         TID.
 642
 643 2019-10-15  Tom Tromey  <tromey@adacore.com>
 644
 645         * windows-nat.c (windows_nat_target::fetch_registers)
 646         (windows_nat_target::store_registers): Rename "pid" to "tid".
 647
 648 2019-10-15  Tom Tromey  <tromey@adacore.com>
 649
 650         * gdbarch.h, gdbarch.c: Rebuild.
 651         * gdbarch.sh (gcc_target_options): Change return type to
 652         std::string.
 653         * compile/compile.c (get_args): Update.
 654         * nios2-tdep.c (nios2_gcc_target_options): Return std::string.
 655         * arm-linux-tdep.c (arm_linux_gcc_target_options): Return
 656         std::string.
 657         * aarch64-linux-tdep.c (aarch64_linux_gcc_target_options): Return
 658         std::string.
 659         * arch-utils.c (default_gcc_target_options): Return std::string.
 660         * arch-utils.h (default_gcc_target_options): Return std::string.
 661         * s390-tdep.c (s390_gcc_target_options): Return std::string.
 662
 663 2019-10-15  Christian Biesinger  <cbiesinger@google.com>
 664
 665         * breakpoint.c (breakpoint_chain): Make static.
 666         * tui/tui-winsource.c: Call iterate_over_breakpoints instead
 667         of accessing breakpoint_chain.
 668
 669 2019-10-15  Christian Biesinger  <cbiesinger@google.com>
 670
 671         * breakpoint.c (iterate_over_breakpoints): Change function pointer
 672         to a gdb::function_view and return value to bool.
 673         * breakpoint.h (iterate_over_breakpoints): Likewise.
 674         * dummy-frame.c (pop_dummy_frame_bpt): Update.
 675         (pop_dummy_frame): Update.
 676         * guile/scm-breakpoint.c (bpscm_build_bp_list): Update.
 677         (gdbscm_breakpoints): Update.
 678         * python/py-breakpoint.c (build_bp_list): Update.
 679         (gdbpy_breakpoints): Update.
 680         * python/py-finishbreakpoint.c (bpfinishpy_detect_out_scope_cb):
 681         Update.
 682         (bpfinishpy_handle_stop): Update.
 683         (bpfinishpy_handle_exit): Update.
 684         * solib-svr4.c (svr4_update_solib_event_breakpoint): Update.
 685         (svr4_update_solib_event_breakpoints): Update.
 686
 687 2019-10-15  Andreas Arnez  <arnez@linux.ibm.com>
 688
 689         * s390-tdep.c (s390_effective_inner_type): Ignore static fields
 690         when unwrapping single-field structs.
 691
 692 2019-10-14  Simon Marchi  <simon.marchi@polymtl.ca>
 693
 694         * dwarf2read.c: Remove includes.
 695
 696 2019-10-13  Simon Marchi  <simon.marchi@polymtl.ca>
 697
 698         * ui-out.c (ui_out::call_do_message): Silence
 699         -Wformat-nonliteral warning.
 700
 701 2019-10-12  Simon Marchi  <simon.marchi@polymtl.ca>
 702
 703         * breakpoint.c: Remove some includes: continuations.h, skip.h,
 704         mi/mi-main.h, readline/readline.h, readline/history.h.  Add
 705         include: readline/tilde.h.
 706
 707 2019-10-12  Christian Biesinger  <cbiesinger@google.com>
 708
 709         * remote.c (remote_target::get_trace_status): Remove declaration of
 710         trace_regblock_size.
 711
 712 2019-10-12  Christian Biesinger  <cbiesinger@google.com>
 713
 714         * cli/cli-cmds.c (max_user_call_depth): Move comment to header.
 715         (show_user): Remove declaration of cmdlist.
 716         * cli/cli-cmds.h (max_user_call_depth): Declare.
 717         * cli/cli-script.c (execute_user_command): Remove declaration
 718         of max_user_call_depth.
 719
 720 2019-10-11  Jim Wilson  <jimw@sifive.com>
 721
 722         * gdbsupport/print-utils.h (pulongest): Fix comment.
 723         (plongest): Likewise.
 724         (phex): Add missing comment, mention leading zeros.
 725         (phex_nz): Add mention of no leading zeros to comment.
 726
 727         * riscv-tdep.c (riscv_push_dummy_code): Change %lld to %s and use
 728         plongest instead of unsigned long long cast.
 729
 730 2019-10-10  Christian Biesinger  <cbiesinger@google.com>
 731
 732         * main.c (captured_main_1): Include gdbtk.h and remove declarations
 733         for external_editor_command and gdbtk_test.
 734
 735 2019-10-10  Christian Biesinger  <cbiesinger@google.com>
 736
 737         * mi/mi-cmd-var.c (varobjdebug): Remove declaration.
 738         * varobj.c (varobjdebug): Move comment to...
 739         * varobj.h (varobjdebug): ...here, and declare.
 740
 741 2019-10-09  Tom Tromey  <tom@tromey.com>
 742
 743         * tui/tui-regs.c (tui_data_window::show_registers): Don't call
 744         erase_data_content.
 745
 746 2019-10-09  Tom Tromey  <tom@tromey.com>
 747
 748         * tui/tui-wingeneral.h (tui_delete_win): Don't declare.
 749         * tui/tui-stack.c (tui_locator_window::rerender): Update.
 750         * tui/tui-command.c (tui_cmd_window::resize)
 751         (tui_refresh_cmd_win): Update.
 752         * tui/tui-win.c (tui_resize_all, tui_set_focus_command): Update.
 753         * tui/tui.c (tui_rl_other_window, tui_enable): Update.
 754         * tui/tui-data.c (~tui_gen_win_info): Remove.
 755         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
 756         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
 757         (tui_redisplay_readline, tui_mld_flush)
 758         (tui_mld_erase_entire_line, tui_mld_getc, tui_getc): Update.
 759         * tui/tui-regs.c (tui_data_window::delete_data_content_windows)
 760         (tui_data_window::erase_data_content)
 761         (tui_data_item_window::rerender)
 762         (tui_data_item_window::refresh_window): Update.
 763         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window)
 764         (box_win, tui_gen_win_info::make_window)
 765         (tui_gen_win_info::make_visible): Update.
 766         (tui_delete_win): Remove.
 767         * tui/tui-winsource.c
 768         (tui_source_window_base::do_erase_source_content): Update.
 769         (tui_show_source_line, tui_source_window_base::update_tab_width)
 770         (tui_source_window_base::update_exec_info): Update.
 771         * tui/tui-data.h (struct curses_deleter): New.
 772         (struct tui_gen_win_info) <handle>: Now a unique_ptr.
 773         (struct tui_gen_win_info) <~tui_gen_win_info>: Define.
 774
 775 2019-10-09  Tom Tromey  <tom@tromey.com>
 776
 777         * tui/tui-wingeneral.h (struct tui_gen_win_info): Don't declare.
 778
 779 2019-10-09  Tom Tromey  <tom@tromey.com>
 780
 781         * tui/tui-data.c (tui_win_is_auxiliary): Remove.
 782         * tui/tui-data.h (tui_win_is_auxiliary): Don't declare.
 783
 784 2019-10-09  Tom Tromey  <tom@tromey.com>
 785
 786         * tui/tui-disasm.c (tui_get_low_disassembly_address): Compute
 787         window height directly.
 788         * tui/tui-layout.h (tui_default_win_viewport_height): Don't
 789         declare.
 790         * tui/tui-layout.c (tui_default_win_height): Remove.
 791         (tui_default_win_viewport_height): Remove.
 792
 793 2019-10-09  Tom Tromey  <tom@tromey.com>
 794
 795         * tui/tui.h: Remove comments.
 796
 797 2019-10-09  Tom de Vries  <tdevries@suse.de>
 798
 799         * python/lib/gdb/printer/bound_registers.py: Use
 800         '^builtin_type_bound128' as regexp argument for
 801         add_builtin_pretty_printer.
 802
 803 2019-10-09  Christian Biesinger  <cbiesinger@google.com>
 804
 805         * guile/guile.c (guile_extension_script_ops): Remove forward
 806         declaration and mark as static.
 807         (guile_script_ops): Likewise.
 808         (extension_language_guile): Move further down in the file so
 809         it can reference the definitions for guile_{extension_,}script_ops.
 810
 811 2019-10-09  Andreas Arnez  <arnez@linux.ibm.com>
 812
 813         * s390-tdep.c (390_process_record): Handle new arch13 instructions
 814         except SORTL, DFLTCC, and KDSA.
 815
 816 2019-10-08  Tom Tromey  <tromey@adacore.com>
 817
 818         * windows-nat.c (struct windows_thread_info_struct) <sf>: Remove.
 819         (struct safe_symbol_file_add_args): Remove.
 820
 821 2019-10-08  Tom Tromey  <tromey@adacore.com>
 822
 823         * windows-nat.c: Don't include buildsym-legacy.h.
 824
 825 2019-10-08  Tom Tromey  <tromey@adacore.com>
 826
 827         * contrib/ari/gdb_ari.sh (%p): Allow gdb-specific %p extensions.
 828
 829 2019-10-08  Christian Biesinger  <cbiesinger@google.com>
 830
 831         * gdbtypes.c (overload_debug): Move comment to header.
 832         * gdbtypes.h (overload_debug): Declare.
 833         * valops.c: Remove declaration of overload_debug, instead
 834         include gdbtypes.h.
 835
 836 2019-10-08  Christian Biesinger  <cbiesinger@google.com>
 837
 838         * language.c (show_language_command): Pass lang_frame_mismatch_warn
 839         through _().
 840         (lang_frame_mismatch_warn): Make const, mark with N_(), and
 841         move comment...
 842         * language.h (lang_frame_mismatch_warn): ... here. Also add
 843         declaration.
 844         * top.c (lang_frame_mismatch_warn): Remove declaration.
 845         (check_frame_language_change): Pass lang_frame_mismatch_warn
 846         through _().
 847
 848 2019-10-07  Christian Biesinger  <cbiesinger@google.com>
 849
 850         * c-lang.h (vtbl_ptr_name): Declare.
 851         * cp-valprint.c (vtbl_ptr_name): Remove "extern" now that we get
 852         it from the header.
 853         * stabsread.c (define_symbol): Remove declaration of vtbl_ptr_name.
 854
 855 2019-10-07  Christian Biesinger  <cbiesinger@google.com>
 856
 857         * charset.c (your_gdb_wchar_t_is_bogus): Replace with a
 858         gdb_static_assert.
 859
 860 2019-10-07  Weimin Pan  <weimin.pan@oracle.com>
 861
 862         * ../Makefile.def (dependencies): Add all-libctf to all-gdb
 863         * ../Makefile.in: Add "all-gdb: maybe-all-libctf"
 864         * ctfread.c: New file.
 865         * ctfread.h: New file.
 866         * elfread.c: Include ctfread.h.
 867         (struct elfinfo text_p): New member ctfsect.
 868         (elf_locate_sections): Mark CTF section.
 869         (elf_symfile_read): Call elfctf_build_psymtabs.
 870         * Makefile.in (LIBCTF): Add.
 871         (CLIBS): Use it.
 872         (CDEPS): Likewise.
 873         (DIST): Add ctfread.c.
 874
 875 2019-10-07  Andrew Burgess  <andrew.burgess@embecosm.com>
 876
 877         * ctfread.c (struct nextfield): Renamed to ...
 878         (struct ctf_nextfield): ... this.
 879         (struct field_info): Renamed to ...
 880         (strut ctf_field_info): ... this.
 881         (attach_fields_to_type): Update for renamed structures.
 882         (ctf_add_member_cb): Likewise.
 883         (ctf_add_enum_member_cb): Likewise.
 884         (process_struct_members): Likewise.
 885         (process_enum_type): Likewise.
 886
 887 2019-10-07  Weimin Pan  <weimin.pan@oracle.com>
 888
 889         * tracectf.h: Rename, was ctf.h.
 890         * tracectf.c: Rename, was ctf.c, replace ctf.h with tracectf.h.
 891         * tracefile.c: Likewise.
 892         * tracepoint.c: Remove unused include ctf.h.
 893         * mi/mi-main.c: Likewise.
 894         * Makefile.in Replace ctf.c with tracectf.c.
 895
 896 2019-10-06  Joel Brobecker  <brobecker@adacore.com>
 897
 898         * version.in: Change version number to "9.0.50.DATE-git".
 899
 900 2019-10-03  Tom Tromey  <tom@tromey.com>
 901
 902         PR rust/24976:
 903         * dwarf2read.c (quirk_rust_enum): Handle single-element unions.
 904
 905 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
 906
 907         * f-lang.c (f_language_defn): Use cp_get_symbol_name_matcher and
 908         cp_search_name_hash.
 909         * NEWS: Add entry about nested function support.
 910
 911 2019-10-03  Bernhard Heckel  <bernhard.heckel@intel.com>
 912             Andrew Burgess  <andrew.burgess@embecosm.com>
 913
 914         * cp-namespace.c (cp_search_static_and_baseclasses): Only search
 915         for nested static variables when searchin VAR_DOMAIN.
 916         * dwarf2read.c (add_partial_symbol): Add nested subroutines to the
 917         global scope, update comment.
 918         (add_partial_subprogram): Call add_partial_subprogram recursively
 919         for nested subroutines when processinng Fortran.
 920         (load_partial_dies): Process the child entities of a subprogram
 921         when processing Fortran.
 922         (partial_die_parent_scope): Handle building scope
 923         for Fortran nested functions.
 924         (process_die): Record that nested functions have a scope.
 925         (new_symbol): Always record Fortran subprograms on the global
 926         symbol list.
 927         (determine_prefix): How to build the prefix for Fortran
 928         subprograms.
 929
 930 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
 931
 932         * linux-nat.c (linux_nat_filter_event): Don't ignore SIGSTOP if we
 933         have just sent the thread a SIGSTOP and are waiting for it to
 934         arrive.
 935
 936 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
 937
 938         * btrace.c (btrace_add_pc): Remove whitespace before the template
 939         parameter in 'std::vector <...>'.
 940         (parse_xml_btrace_block): Likewise.
 941         (btrace_maint_decode_pt): Likewise.
 942         (btrace_maint_update_packets): Likewise.
 943         (btrace_maint_print_packets): Likewise.
 944         * btrace.h (struct btrace_maint_info): Likewise.
 945         * dwarf2read.c (struct type_unit_group): Likewise.
 946         (build_type_psymtabs_reader): Likewise.
 947         * gdbsupport/btrace-common.c (btrace_data_append): Likewise.
 948         * gdbsupport/btrace-common.h (struct btrace_data_bts): Likewise.
 949         * nat/linux-btrace.c (perf_event_read_bts): Likewise.
 950
 951 2019-10-03  Tom de Vries  <tdevries@suse.de>
 952
 953         * cli/cli-style.c (_initialize_cli_style): Adding a '.' at the end of
 954         the first line of the help text for set/show style metadata.
 955
 956 2019-10-02  Tom Tromey  <tromey@adacore.com>
 957
 958         * Makefile.in (COMMON_SFILES): Add common-inferior.c.
 959         * gdbsupport/common-inferior.c: New file.
 960         * infcmd.c (startup_with_shell): Don't define.
 961         * nat/fork-inferior.h (startup_with_shell): Don't declare.
 962         * gdbsupport/common-inferior.h (startup_with_shell): Declare.
 963         * inferior.h (startup_with_shell): Don't declare.
 964
 965 2019-10-02  Christian Biesinger  <cbiesinger@google.com>
 966
 967         * gdbsupport/gdb_assert.h: Include errors.h.
 968         * gdbsupport/gdb_string_view.h: Include gdb_assert.h.
 969
 970 2019-10-02  Tom Tromey  <tromey@adacore.com>
 971
 972         * NEWS: Add $_ada_exception entry.
 973         * ada-lang.c (struct ada_catchpoint): Add constructor.
 974         <m_kind>: New member.
 975         (allocate_location_exception, re_set_exception): Remove
 976         "ex" parameter.
 977         (should_stop_exception): Compute $_ada_exception.
 978         (check_status_exception, print_it_exception)
 979         (print_one_exception, print_mention_exception): Remove
 980         "ex" parameter.
 981         (allocate_location_catch_exception, re_set_catch_exception)
 982         (check_status_exception, print_it_catch_exception)
 983         (print_one_catch_exception, print_mention_catch_exception)
 984         (print_recreate_catch_exception)
 985         (allocate_location_catch_exception_unhandled)
 986         (re_set_catch_exception_unhandled)
 987         (check_status_exception, print_it_catch_exception_unhandled)
 988         (print_one_catch_exception_unhandled)
 989         (print_mention_catch_exception_unhandled)
 990         (print_recreate_catch_exception_unhandled)
 991         (allocate_location_catch_assert, re_set_catch_assert)
 992         (check_status_assert, print_it_catch_assert)
 993         (print_one_catch_assert, print_mention_catch_assert)
 994         (print_recreate_catch_assert)
 995         (allocate_location_catch_handlers, re_set_catch_handlers)
 996         (check_status_handlers, print_it_catch_handlers)
 997         (print_one_catch_handlers, print_mention_catch_handlers)
 998         (print_recreate_catch_handlers): Remove.
 999         (create_ada_exception_catchpoint): Update.
1000         (initialize_ada_catchpoint_ops): Update.
1001
1002 2019-10-02  Tom Tromey  <tromey@adacore.com>
1003
1004         * ada-lang.c (ada_lookup_simple_minsyms): Remove.
1005         (create_excep_cond_exprs): Simplify exception string computation.
1006         (ada_exception_catchpoint_cond_string): Likewise.
1007
1008 2019-10-02  Tom Tromey  <tromey@adacore.com>
1009
1010         * symmisc.c (dump_msymbols): Don't use MSYMBOL_VALUE_ADDRESS.
1011         * ada-lang.c (lesseq_defined_than): Handle
1012         LOC_STATIC.
1013         * dwarf2read.c (dwarf2_per_objfile): Add can_copy
1014         parameter.
1015         (dwarf2_has_info): Likewise.
1016         (new_symbol): Set maybe_copied on symbol when
1017         appropriate.
1018         * dwarf2read.h (dwarf2_per_objfile): Add can_copy
1019         parameter.
1020         <can_copy>: New member.
1021         * elfread.c (record_minimal_symbol): Set maybe_copied
1022         on symbol when appropriate.
1023         (elf_symfile_read): Update call to dwarf2_has_info.
1024         * minsyms.c (lookup_minimal_symbol_linkage): New
1025         function.
1026         * minsyms.h (lookup_minimal_symbol_linkage): Declare.
1027         * symtab.c (get_symbol_address, get_msymbol_address):
1028         New functions.
1029         * symtab.h (get_symbol_address, get_msymbol_address):
1030         Declare.
1031         (SYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_ADDRESS): Handle
1032         maybe_copied.
1033         (struct symbol, struct minimal_symbol) <maybe_copied>:
1034         New member.
1035
1036 2019-10-02  Tom Tromey  <tromey@adacore.com>
1037
1038         * source.c (struct current_source_location): New.
1039         (current_source_key): New global.
1040         (current_source_symtab, current_source_line)
1041         (current_source_pspace): Remove.
1042         (get_source_location): New function.
1043         (get_current_source_symtab_and_line)
1044         (set_default_source_symtab_and_line)
1045         (set_current_source_symtab_and_line)
1046         (clear_current_source_symtab_and_line, select_source_symtab)
1047         (info_source_command, print_source_lines_base)
1048         (info_line_command, search_command_helper, _initialize_source):
1049         Update.
1050
1051 2019-10-02  Tom Tromey  <tromey@adacore.com>
1052
1053         * source.c (select_source_symtab): Don't call
1054         decode_line_with_current_source.
1055
1056 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1057
1058         * symtab.c (lookup_global_symbol): Search global block.
1059
1060 2019-10-02  Tom Tromey  <tromey@adacore.com>
1061
1062         * coffread.c (process_coff_symbol): Update.
1063         * dwarf2read.c (var_decode_location, new_symbol): Update.
1064         * mdebugread.c (parse_symbol): Update.
1065         * objfiles.c (relocate_one_symbol): Update.
1066         * stabsread.c (define_symbol, fix_common_block)
1067         (scan_file_globals): Update.
1068         * symtab.h (SYMBOL_VALUE_ADDRESS): Expand to an rvalue.
1069         (SET_SYMBOL_VALUE_ADDRESS): New macro.
1070         * xcoffread.c (process_xcoff_symbol): Update.
1071
1072 2019-10-02  Andreas Arnez  <arnez@linux.ibm.com>
1073
1074         * MAINTAINERS: Update my email address.
1075
1076 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1077
1078         * dwarf2read.c (struct type_unit_group) <tus>: Convert to
1079         std::vector.
1080         (build_type_psymtabs_reader): Update for std::vector.
1081         (build_type_psymtab_dependencies): Likewise.
1082         * dwarf2read.h: Remove use of DEF_VEC_P.
1083         (typedef sig_type_ptr): Delete.
1084
1085 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1086
1087         * btrace.c (btrace_maint_clear): Update to handle change from VEC
1088         to std::vector.
1089         (btrace_maint_decode_pt): Likewise, and move allocation of the
1090         vector outside of the loop.
1091         (btrace_maint_update_packets): Update to handle change from VEC to
1092         std::vector.
1093         (btrace_maint_print_packets): Likewise.
1094         (maint_info_btrace_cmd): Likewise.
1095         * btrace.h: Remove use of DEF_VEC_O.
1096         (typedef btrace_pt_packet_s): Delete.
1097         (struct btrace_maint_info) <packets>: Change fromm VEC to
1098         std::vector.
1099         * gdbsupport/btrace-common.h: Remove 'vec.h' include.
1100
1101 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1102
1103         * btrace.c (btrace_compute_ftrace_bts): Update for std::vector,
1104         make accesses into the vector constant references.
1105         (btrace_add_pc): Update for std::vector.
1106         (btrace_stitch_bts): Likewise.
1107         (parse_xml_btrace_block): Likewise.
1108         (btrace_maint_update_packets): Likewise.
1109         (btrace_maint_print_packets): Likewise.
1110         (maint_info_btrace_cmd): Likewise.
1111         * gdbsupport/btrace-common.c (btrace_data::fini): Update for
1112         std::vector.
1113         (btrace_data::empty): Likewise.
1114         (btrace_data_append): Likewise.
1115         * gdbsupport/btrace-common.h: Remove use of DEF_VEC_O.
1116         (typedef btrace_block_s): Delete.
1117         (struct btrace_block): Add constructor.
1118         (struct btrace_data_bts) <blocks>: Change to std::vector.
1119         * nat/linux-btrace.c (perf_event_read_bts): Update for
1120         std::vector.
1121         (linux_read_bts): Likewise.
1122
1123 2019-10-01  Tom Tromey  <tom@tromey.com>
1124
1125         * cli/cli-logging.c (show_logging_filename): Use styled_string.
1126
1127 2019-10-01  Tom Tromey  <tom@tromey.com>
1128
1129         * stack.c (print_frame, info_frame_command_core): Use
1130         styled_string.
1131         * linux-thread-db.c (try_thread_db_load_1)
1132         (try_thread_db_load_from_pdir_1): Use styled_string.
1133         * auto-load.c (file_is_auto_load_safe, execute_script_contents)
1134         (auto_load_section_scripts, info_auto_load_local_gdbinit)
1135         (maybe_print_unsupported_script_warning)
1136         (maybe_print_script_not_found_warning): Use styled_string.
1137         * ada-lang.c (user_select_syms): Use styled_string.
1138
1139 2019-10-01  Tom Tromey  <tom@tromey.com>
1140
1141         * p-lang.c (pascal_printstr): Use metadata style.
1142         * value.c (show_convenience): Use metadata style.
1143         * valprint.c (valprint_check_validity, val_print_optimized_out)
1144         (val_print_not_saved, val_print_unavailable)
1145         (val_print_invalid_address, generic_val_print, val_print)
1146         (value_check_printable, val_print_array_elements): Use metadata
1147         style.
1148         * ui-out.h (class ui_out) <field_fmt>: New overload.
1149         <do_field_fmt>: Add style parameter.
1150         * ui-out.c (ui_out::field_fmt): New overload.
1151         * typeprint.c (type_print_unknown_return_type)
1152         (val_print_not_allocated, val_print_not_associated): Use metadata
1153         style.
1154         * tui/tui-out.h (class tui_ui_out) <do_field_fmt>: Add style
1155         parameter.
1156         * tui/tui-out.c (tui_ui_out::do_field_fmt): Update.
1157         * tracepoint.c (tvariables_info_1): Use metadata style.
1158         * stack.c (print_frame_arg, print_frame_info, print_frame)
1159         (info_frame_command_core): Use metadata style.
1160         * skip.c (info_skip_command): Use metadata style.
1161         * rust-lang.c (rust_print_enum): Use metadata style.
1162         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
1163         metadata style.
1164         * python/py-framefilter.c (py_print_single_arg): Use metadata
1165         style.
1166         * printcmd.c (do_one_display, print_variable_and_value): Use
1167         metadata style.
1168         * p-valprint.c (pascal_val_print)
1169         (pascal_object_print_value_fields): Use metadata style.
1170         * p-typeprint.c (pascal_type_print_base): Use metadata style.
1171         * mi/mi-out.h (class mi_ui_out) <do_field_fmt>: Add style
1172         parameter.
1173         * mi/mi-out.c (mi_ui_out::do_field_fmt): Update.
1174         * m2-valprint.c (m2_print_long_set): Use metadata style.
1175         * m2-typeprint.c (m2_print_type): Use metadata style.
1176         * infcmd.c (print_return_value_1): Use metadata style.
1177         * gnu-v3-abi.c (print_one_vtable): Use metadata style.
1178         * f-valprint.c (info_common_command_for_block): Use metadata
1179         style.
1180         * f-typeprint.c (f_type_print_base): Use metadata style.
1181         * expprint.c (print_subexp_standard): Use metadata style.
1182         * cp-valprint.c (cp_print_value_fields): Use metadata style.
1183         * cli/cli-style.h (class cli_style_option): Add constructor.
1184         (metadata_style): Declare.
1185         * cli/cli-style.c (metadata_style): New global.
1186         (_initialize_cli_style): Register metadata style.
1187         * cli-out.h (class cli_ui_out) <do_field_fmt>: Add style
1188         parameter.
1189         * cli-out.c (cli_ui_out::do_field_fmt): Update.
1190         * c-typeprint.c (c_type_print_base_struct_union)
1191         (c_type_print_base_1): Use metadata style.
1192         * breakpoint.c (watchpoint_value_print)
1193         (print_one_breakpoint_location): Use metadata style.
1194         * break-catch-syscall.c (print_one_catch_syscall): Use metadata
1195         style.
1196         * break-catch-sig.c (signal_catchpoint_print_one): Use metadata
1197         style.
1198         * ada-valprint.c (val_print_packed_array_elements, printstr)
1199         (print_field_values, ada_val_print_ref, ada_val_print): Use
1200         metadata style.
1201         * ada-typeprint.c (print_array_type, ada_print_type): Use metadata
1202         style.
1203         * ada-tasks.c (print_ada_task_info, info_task): Use metadata
1204         style.
1205         * ada-lang.c (user_select_syms): Use metadata style.
1206
1207 2019-10-01  Tom Tromey  <tom@tromey.com>
1208
1209         * cli/cli-cmds.c (pwd_command): Style output.
1210
1211 2019-10-01  Pedro Alves  <palves@redhat.com>
1212             Tom Tromey  <tom@tromey.com>
1213
1214         * symtab.c (print_symbol_info): Use %ps.
1215         (print_msymbol_info): Use %ps.
1216         * symfile.c (symbol_file_add_with_addrs): Use %ps.
1217         * printcmd.c (print_variable_and_value): Use %ps.
1218         * macrocmd.c (show_pp_source_pos): Use %ps.
1219         * infrun.c (print_exited_reason): Use ui_out::message.
1220         * breakpoint.c (watchpoint_check, print_one_breakpoint_location)
1221         (describe_other_breakpoints): Use ui_out::message and new
1222         formats.
1223         (say_where): Use new formats.
1224         (bkpt_print_it, tracepoint_print_one_detail): Use ui_out::message
1225         and new formats.
1226
1227 2019-10-01  Pedro Alves  <palves@redhat.com>
1228             Tom Tromey  <tom@tromey.com>
1229
1230         * unittests/format_pieces-selftests.c: Add gdb_format parameter.
1231         (test_gdb_formats): New function.
1232         (run_tests): Call it.
1233         (test_format_specifier): Update.
1234         * utils.h (fputs_filtered): Update comment.
1235         (vfprintf_styled, vfprintf_styled_no_gdbfmt)
1236         (fputs_styled_unfiltered): Declare.
1237         * utils.c (fputs_styled_unfiltered): New function.
1238         (vfprintf_maybe_filtered): Add gdbfmt parameter.
1239         (vfprintf_filtered): Update.
1240         (vfprintf_unfiltered, vprintf_filtered): Update.
1241         (vfprintf_styled, vfprintf_styled_no_gdbfmt): New functions.
1242         * ui-out.h (enum ui_out_flag) <unfiltered_output,
1243         disallow_ui_out_field>: New constants.
1244         (enum class field_kind): New.
1245         (struct base_field_s, struct signed_field_s): New.
1246         (signed_field): New function.
1247         (struct string_field_s): New.
1248         (string_field): New function.
1249         (struct styled_string_s): New.
1250         (styled_string): New function.
1251         (class ui_out) <message>: Add comment.
1252         <vmessage, call_do_message>: New methods.
1253         <do_message>: Add style parameter.
1254         * ui-out.c (ui_out::call_do_message, ui_out::vmessage): New
1255         methods.
1256         (ui_out::message): Rewrite.
1257         * mi/mi-out.h (class mi_ui_out) <do_message>: Add style
1258         parameter.
1259         * mi/mi-out.c (mi_ui_out::do_message): Add style parameter.
1260         * gdbsupport/format.h (class format_pieces) <format_pieces>: Add
1261         gdb_extensions parameter.
1262         (class format_piece): Add parameter to constructor.
1263         (n_int_args): New field.
1264         * gdbsupport/format.c (format_pieces::format_pieces): Add
1265         gdb_extensions parameter.  Handle '*'.
1266         * cli-out.h (class cli_ui_out) <do_message>: Add style parameter.
1267         * cli-out.c (cli_ui_out::do_message): Add style parameter.  Call
1268         vfprintf_styled_no_gdbfmt.
1269         (cli_ui_out::do_field_string, cli_ui_out::do_spaces)
1270         (cli_ui_out::do_text, cli_ui_out::field_separator): Allow
1271         unfiltered output.
1272         * ui-style.h (struct ui_file_style) <ptr>: New method.
1273
1274 2019-10-01  Tom Tromey  <tom@tromey.com>
1275
1276         * unittests/format_pieces-selftests.c: Update.  Add final format.
1277         * gdbsupport/format.c (format_pieces::format_pieces): Don't add
1278         empty literal pieces.
1279
1280 2019-10-01  Tom Tromey  <tom@tromey.com>
1281
1282         * ui-out.h (enum class ui_out_style_kind): Remove.
1283         (class ui_out) <field_string, field_stsream, do_field_string>:
1284         Change type of "style".
1285         * ui-out.c (ui_out::field_core_addr, ui_out::field_stream)
1286         (ui_out::field_string): Update.
1287         * tui/tui-out.h (class tui_ui_out) <do_field_string>: Change type
1288         of "style".
1289         * tui/tui-out.c (tui_ui_out::do_field_string): Update.
1290         * tracepoint.c (print_one_static_tracepoint_marker): Update.
1291         * stack.c (print_frame_arg, print_frame_info, print_frame):
1292         Update.
1293         * source.c (print_source_lines_base): Update.
1294         * solib.c (info_sharedlibrary_command): Update.
1295         * skip.c (info_skip_command): Update.
1296         * record-btrace.c (btrace_call_history_src_line)
1297         (btrace_call_history): Update.
1298         * python/py-framefilter.c (py_print_frame): Update.
1299         * mi/mi-out.h (class mi_ui_out) <do_field_string>: Change type of
1300         "style".
1301         * mi/mi-out.c (mi_ui_out::do_table_header)
1302         (mi_ui_out::do_field_signed, mi_ui_out::do_field_unsigned)
1303         (mi_ui_out::do_field_string): Update.
1304         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
1305         Update.
1306         * cli-out.h (class cli_ui_out) <do_field_string>: Change type of
1307         "style".
1308         * cli-out.c (cli_ui_out::do_table_header)
1309         (cli_ui_out::do_field_signed, cli_ui_out::do_field_unsigned)
1310         (cli_ui_out::do_field_skip, cli_ui_out::do_field_string)
1311         (cli_ui_out::do_field_fmt): Update.
1312         * breakpoint.c (print_breakpoint_location): Update.
1313         (update_static_tracepoint): Update.
1314
1315 2019-10-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1316
1317         * main.c (relocate_gdbinit_path_maybe_in_datadir): Remove std::string
1318         conversion of gdb_datadir.
1319         (captured_main_1): Remove xstrdup when assigning to gdb_datadir,
1320         remove not needed c_str ().
1321
1322 2019-09-30  Ali Tamur <tamur@google.com>
1323
1324         * dwarf2read.c (skip_one_die): Handle DW_FORM_strx forms.
1325         (dwarf2_string_attr): Likewise.
1326
1327 2019-09-30  Ali Tamur <tamur@google.com>
1328
1329         * dwarf2read.c (process_full_comp_unit): Remove whitespace at the EOL.
1330         (process_full_type_unit): Likewise.
1331         (dump_die_shallow): Likewise.
1332         (cu_debug_loc_section): Likewise.
1333
1334 2019-09-28  Christian Biesinger  <cbiesinger@google.com>
1335
1336         * minsyms.c (compare_minimal_symbols): Rename to...
1337         (minimal_symbol_is_less_than): ...this, and adjust to STL
1338         conventions (return bool, take arguments as references)
1339         (minimal_symbol_reader::install): Call std::sort instead
1340         of qsort.
1341
1342 2019-09-29  Christian Biesinger  <cbiesinger@google.com>
1343
1344         * minsyms.h (msymbol_hash): Document that this is a case-insensitive
1345         hash and why.
1346         * objfiles.h (struct objfile_per_bfd_storage) <demangled_names_hash,
1347         msymbol_hash, msymbol_demangled_hash>: Improve comments.
1348
1349 2019-09-30  Simon Marchi  <simon.marchi@polymtl.ca>
1350
1351         * psymtab.c (add_psymbol_to_list): Move comment to psympriv.h.
1352         * psympriv.h (add_psymbol_to_list): Move comment here and update
1353         it.
1354
1355 2019-09-29  Tom de Vries  <tdevries@suse.de>
1356
1357         * contrib/cc-with-tweaks.sh (get_tmpdir): New function.
1358         Use $tmpdir/$(basename "$output_file").dwz instead of
1359         "${output_file}.dwz".
1360
1361 2019-09-28  Simon Marchi  <simon.marchi@polymtl.ca>
1362
1363         PR gdb/25045
1364         * hppa-linux-nat.c: Include gdbarch.h.
1365
1366 2019-09-26  Christian Biesinger  <cbiesinger@google.com>
1367
1368         * blockframe.c (find_pc_partial_function): Change return type to bool.
1369         * elfread.c (elf_gnu_ifunc_resolve_name): Likewise.
1370         * minsyms.c (in_gnu_ifunc_stub): Likewise.
1371         (stub_gnu_ifunc_resolve_name): Likewise.
1372         * symtab.c (compare_filenames_for_search): Likewise.
1373         (compare_glob_filenames_for_search): Likewise.
1374         (matching_obj_sections): Likewise.
1375         (symbol_matches_domain): Likewise.
1376         (find_line_symtab): Change out param EXACT_MATCH to bool *.
1377         (find_line_pc): Change return type to bool.
1378         (find_line_pc_range): Likewise.
1379         (producer_is_realview): Likewise.
1380         * symtab.h (symbol_matches_domain): Likewise.
1381         (find_pc_partial_function): Likewise.
1382         (find_pc_line_pc_range): Likewise.
1383         (in_gnu_ifunc_stub): Likewise.
1384         (struct gnu_ifunc_fns) <gnu_ifunc_resolve_name>: Likewise.
1385         (find_line_pc): Likewise.
1386         (find_line_pc_range): Likewise.
1387         (matching_obj_sections): Likewise.
1388         (find_line_symtab): Change out parameter to bool.
1389         (producer_is_realview): Change return type to bool.
1390         (compare_filenames_for_search): Likewise.
1391         (compare_glob_filenames_for_search): Likewise.
1392
1393 2019-09-26  Tom Tromey  <tom@tromey.com>
1394
1395         * Makefile.in (COMMON_SFILES): Remove gdb_usleep.c.
1396         (HFILES_NO_SRCDIR): Remove gdb_usleep.h.
1397         * gdb_usleep.h: Remove.
1398         * gdb_usleep.c: Remove.
1399         * utils.c: Don't include gdb_usleep.h.
1400
1401 2019-09-26  Tom Tromey  <tromey@adacore.com>
1402
1403         * python/py-type.c (type_to_type_object): Call check_typedef
1404         for stub types.
1405
1406 2019-09-26  Tom Tromey  <tom@tromey.com>
1407
1408         * utils.h (initialize_utils): Don't declare.
1409         * top.c (gdb_init): Don't call initialize_utils.
1410         * utils.c (initialize_utils): Remove.  Move contents...
1411         (_initialize_utils): ... here.
1412
1413 2019-09-25  Tom Tromey  <tom@tromey.com>
1414
1415         * python/py-objfile.c (objfpy_get_build_id): Use bin2hex.
1416         * utils.h (make_hex_string): Don't declare.
1417         * utils.c (make_hex_string): Remove.
1418
1419 2019-09-24  Tom de Vries  <tdevries@suse.de>
1420
1421         PR gdb/23815
1422         * amd64-linux-nat.c (amd64_linux_nat_target::fetch_registers):
1423         Initialize xstateregs before ptrace PTRACE_GETREGSET call.
1424
1425 2019-09-23  Dimitar Dimitrov  <dimitar@dinux.eu>
1426
1427         * NEWS: Mention new simulator port for PRU.
1428
1429 2019-09-23  Christian Biesinger  <cbiesinger@google.com>
1430
1431         * ada-exp.y (write_object_remaining): Update.
1432         * ada-lang.c (ada_decode): Return a std::string instead of a char*
1433         and eliminate the static buffer.
1434         (ada_decode_symbol): Update.
1435         (ada_la_decode): Update.
1436         (ada_sniff_from_mangled_name): Update.
1437         (is_valid_name_for_wild_match): Update.
1438         (ada_lookup_name_info::matches): Update and simplify.
1439         (name_matches_regex): Update.
1440         (ada_add_global_exceptions): Update.
1441         * ada-lang.h (ada_decode): Update signature.
1442         * ada-varobj.c (ada_varobj_describe_simple_array_child): Update.
1443         * dwarf-index-write.c (debug_names::insert): Update.
1444
1445 2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>
1446
1447         * solib-svr4.c (svr4_iterate_over_objfiles_in_search_order): Fix
1448         formatting.
1449
1450 2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>
1451
1452         * breakpoint.h (bp_location) <inserted, permanent, duplicate>:
1453         Change "nonzero" to "true" in documentation.
1454
1455 2019-09-20  Christian Biesinger  <cbiesinger@google.com>
1456
1457         * solib-darwin.c (darwin_lookup_lib_symbol): Remove.
1458         (_initialize_darwin_solib): Don't set
1459         darwin_so_ops.lookup_lib_global_symbol.
1460         * solib-svr4.c (set_solib_svr4_fetch_link_map_offsets): Call
1461         set_gdbarch_iterate_over_objfiles_in_search_order.
1462         (elf_lookup_lib_symbol): Rename to...
1463         (svr4_iterate_over_objfiles_in_search_order): this, and update
1464         to iterate semantics.
1465         (_initialize_svr4_solib): Don't set lookup_lib_global_symbol.
1466         * solib.c (solib_global_lookup): Remove.
1467         * solist.h (struct target_so_ops): Remove lookup_lib_global_symbol.
1468         (solib_global_lookup): Remove.
1469         * symtab.c (lookup_global_or_static_symbol): Remove call to
1470         solib_global_lookup.
1471
1472 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
1473
1474         * NEWS: Move entries about default MI version now being
1475         version 3, and about the GDB/MI fix for multi-location
1476         breakpoints to the "since GDB 8.3" section.
1477
1478 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
1479
1480         GDB 8.3.1 released.
1481
1482 2019-09-20  Ulrich Weigand  <uweigand@de.ibm.com>
1483
1484         * NEWS: Mention that Cell/B.E. debugging support was removed.
1485         * MAINTAINERS: Remove spu target.
1486
1487         * config/djgpp/fnchange.lst: Remove entries for removed files.
1488
1489         * Makefile.in (ALL_TARGET_OBS): Remove solib-spu.o,
1490         spu-multiarch.o, and spu-tdep.o.
1491         (HFILES_NO_SRCDIR): Remove solib-spu.h and spu-tdep.h.
1492         (ALLDEPFILES): Remove solib-spu.c, spu-linux-nat.c,
1493         spu-multiarch.c, and spu-tdep.c.
1494         * spu-linux-nat.c: Remove file.
1495         * spu-multiarch.c: Remove file.
1496         * spu-tdep.c: Remove file.
1497         * spu-tdep.h: Remove file.
1498         * solib-spu.c: Remove file.
1499         * solib-spu.h: Remove file.
1500
1501         * configure.host (powerpc64*-*-linux*): Remove Cell/B.E. support.
1502         * configure.nat (spu-linux): Remove.
1503         * configure.tgt (powerpc*-*-linux*): Remove solib-spu.o and
1504         solib-multiarch.o from gdb_target_obs.
1505         (spu*-*-*): Remove.
1506
1507         * arch/ppc-linux-common.h (struct ppc_linux_features): Remove "cell"
1508         feature flag.
1509         (ppc_linux_no_features): Update.
1510         * arch/ppc-linux-common.c (ppc_linux_match_description): Remove
1511         Cell/B.E. support.
1512         * arch/ppc-linux-tdesc.h (tdesc_powerpc_cell32l): Remove declaration.
1513         (tdesc_powerpc_cell64l): Likewise.
1514         * nat/ppc-linux.h (PPC_FEATURE_CELL): Remove.
1515         * ppc-linux-nat.c (ppc_linux_nat_target::read_description): Remove
1516         Cell/B.E. support.
1517         * ppc-linux-tdep.h: Do not include "solib-spu.h" or "spu-tdep.h".
1518         Do not include "features/rs6000/powerpc-cell32l.c" or
1519         "features/rs6000/powerpc-cell64l.c".
1520         (ppc_linux_spu_section): Remove.
1521         (ppc_linux_core_read_description): Remove Cell/B.E. support.
1522         (spe_context_objfile, spe_context_lm_addr, spe_context_offset,
1523         spe_context_cache_ptid, spe_context_cache_ptid): Remove.
1524         (ppc_linux_spe_context_lookup): Remove.
1525         (ppc_linux_spe_context_inferior_created): Remove.
1526         (ppc_linux_spe_context_solib_loaded): Remove.
1527         (ppc_linux_spe_context_solib_unloaded): Remove.
1528         (ppc_linux_spe_context): Remove.
1529         (struct ppu2spu_cache): Remove.
1530         (ppu2spu_prev_arch, ppu2spu_this_id, ppu2spu_prev_register): Remove.
1531         (struct ppu2spu_data): Remove.
1532         (ppu2spu_unwind_register, ppu2spu_sniffer, ppu2spu_dealloc_cache,
1533         ppu2spu_unwind): Remove.
1534         (ppc_linux_init_abi): Remove Cell/B.E. support.
1535         * rs6000-tdep.h (rs6000_gdbarch_init): Remove Cell/B.E. support.
1536
1537         * features/Makefile (rs6000/powerpc-cell32l-expedite): Remove.
1538         (rs6000/powerpc-cell64l-expedite): Likewise
1539         (WHICH): Remove rs6000/powerpc-cell32l and rs6000/powerpc-cell64l.
1540         (XMLTOC): Remove rs6000/powerpc-cell32l.xml and
1541         rs6000/powerpc-cell64l.xml.
1542         * features/rs6000/powerpc-cell32l.xml: Remove.
1543         * features/rs6000/powerpc-cell64l.xml: Likewise.
1544         * features/rs6000/powerpc-cell32l.c: Remove generated file.
1545         * features/rs6000/powerpc-cell64l.c: Likewise.
1546         * regformats/rs6000/powerpc-cell32l.dat: Remove generated file.
1547         * regformats/rs6000/powerpc-cell64l.dat: Likewise.
1548         * regformats/reg-spu.dat: Remove.
1549
1550         * target.h (enum target_object): Remove TARGET_OBJECT_SPU.
1551         * corelow.c (struct spuid_list): Remove.
1552         (add_to_spuid_list): Remove.
1553         (core_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
1554         * remote.c (PACKET_qXfer_spu_read, PACKET_qXfer_spu_write): Remove.
1555         (remote_protocol_features): Remove associated entries.
1556         (_initialize_remote): No longer initialize them.
1557         (remote_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
1558         * linux-nat.c (SPUFS_MAGIC): Remove.
1559         (linux_proc_xfer_spu): Remove.
1560         (spu_enumerate_spu_ids): Remove.
1561         (linux_nat_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
1562         * linux-tdep.c (-linux_spu_make_corefile_notes): Remove.
1563         (linux_make_corefile_notes): No longer call it.
1564
1565         * regcache.c (cooked_read_test): Remove bfd_arch_spu special case.
1566         (cooked_write_test): Likewise.
1567
1568 2019-09-20  Tom Tromey  <tom@tromey.com>
1569
1570         * NEWS: Mention case-sensitivity of TUI commands.
1571         * tui/tui-win.c (tui_set_focus_command): Now case-sensitive.
1572         (tui_set_win_height_command, parse_scrolling_args): Likewise.
1573         * tui/tui-layout.c (tui_layout_command): Now case-sensitive.
1574
1575 2019-09-20  Tom Tromey  <tom@tromey.com>
1576
1577         * tui/tui-source.c (tui_source_window::set_contents): Use
1578         make_unique_xstrdup.
1579         * tui/tui-disasm.c (tui_disasm_window::set_contents): Use
1580         make_unique_xstrdup.
1581
1582 2019-09-20  Tom Tromey  <tom@tromey.com>
1583
1584         * tui/tui-data.c: Remove separator comments.
1585         * tui/tui-layout.c: Remove separator comments.
1586         * tui/tui-win.c: Remove separator comments.
1587         * tui/tui-wingeneral.c: Remove separator comments.
1588
1589 2019-09-20  Tom Tromey  <tom@tromey.com>
1590
1591         * tui/tui.h (strcat_to_buf): Don't declare.
1592         * tui/tui.c (strcat_to_buf): Remove.
1593
1594 2019-09-20  Tom Tromey  <tom@tromey.com>
1595
1596         * tui/tui-source.h (struct tui_source_window) <m_fullname>: Rename
1597         from "fullname".
1598         * tui/tui-source.c (tui_source_window::set_contents)
1599         (tui_source_window::location_matches_p)
1600         (tui_source_window::maybe_update): Update.
1601
1602 2019-09-20  Tom Tromey  <tom@tromey.com>
1603
1604         * tui/tui-regs.h (struct tui_data_window) <get_current_group>:
1605         Update.
1606         <m_regs_content, m_regs_column_count, m_current_group>: Add "m_"
1607         prefix.
1608         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
1609         (tui_data_window::line_from_reg_element_no)
1610         (tui_data_window::first_reg_element_no_inline)
1611         (tui_data_window::show_registers)
1612         (tui_data_window::show_register_group)
1613         (tui_data_window::display_registers_from)
1614         (tui_data_window::display_registers_from_line)
1615         (tui_data_window::first_data_item_displayed)
1616         (tui_data_window::delete_data_content_windows)
1617         (tui_data_window::erase_data_content)
1618         (tui_data_window::do_scroll_vertical)
1619         (tui_data_window::refresh_window)
1620         (tui_data_window::check_register_values): Update.
1621
1622 2019-09-20  Tom Tromey  <tom@tromey.com>
1623
1624         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN): Remove define.
1625         (struct tui_locator_window) <full_name, proc_name>: Now
1626         std::string.
1627         * tui/tui-stack.c (tui_locator_window::make_status_line)
1628         (tui_locator_window::set_locator_fullname)
1629         (tui_locator_window::set_locator_info): Update.
1630         * tui/tui-source.c (tui_source_window::set_contents)
1631         (tui_source_window::showing_source_p): Update.
1632
1633 2019-09-20  Tom Tromey  <tom@tromey.com>
1634
1635         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
1636         Don't call tui_locator_win_info_ptr.
1637
1638 2019-09-20  Tom Tromey  <tom@tromey.com>
1639
1640         * tui/tui-win.c (tui_resize_all): Don't call refresh.
1641
1642 2019-09-20  Tom Tromey  <tom@tromey.com>
1643
1644         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use 1 as
1645         height for locator.
1646         * tui/tui-stack.c (tui_locator_window::rerender): Call scrollok.
1647         * tui/tui-layout.c (show_source_disasm_command, show_data)
1648         (show_source_or_disasm_and_command): Use 1 as height for locator.
1649
1650 2019-09-20  Tom Tromey  <tom@tromey.com>
1651
1652         * tui/tui.c (tui_enable): Update.
1653         * tui/tui-win.c (tui_sigwinch_handler, tui_async_resize_screen):
1654         Update.
1655         * tui/tui-data.h (tui_win_resized, tui_set_win_resized_to):
1656         Update.
1657         * tui/tui-data.c (win_resized): Now bool.
1658         (tui_win_resized): Return bool.
1659         (tui_set_win_resized_to): Accept a bool.
1660
1661 2019-09-20  Tom Tromey  <tom@tromey.com>
1662
1663         * tui/tui-regs.h (struct tui_data_window) <show_register_group>:
1664         Change type of "refresh_values_only".
1665         * tui/tui-regs.c (tui_data_window::show_register_group): Change
1666         type of "refresh_values_only".
1667
1668 2019-09-20  Tom Tromey  <tom@tromey.com>
1669
1670         * tui/tui-disasm.c (struct tui_asm_line) <addr_string, insn>: Now
1671         std::string.
1672         (tui_disassemble): Add "pos" parameter.
1673         (tui_disasm_window::set_contents): Simplify.
1674
1675 2019-09-20  Tom Tromey  <tom@tromey.com>
1676
1677         * tui/tui-winsource.h (struct tui_source_window_base)
1678         <show_source_content>: Now private.
1679         * tui/tui-winsource.c
1680         (tui_source_window_base::show_source_content): Don't handle empty
1681         content case.
1682
1683 2019-09-20  Tom Tromey  <tom@tromey.com>
1684
1685         * tui/tui-layout.c (show_source_disasm_command)
1686         (show_source_or_disasm_and_command): Don't call
1687         show_source_content.
1688
1689 2019-09-20  Tom Tromey  <tom@tromey.com>
1690
1691         * tui/tui-stack.h (struct tui_locator_window) <make_status_line>:
1692         Declare.
1693         * tui/tui-stack.c (tui_locator_window::make_status_line): Rename
1694         from tui_make_status_line.
1695         (tui_locator_window::rerender): Update.
1696
1697 2019-09-20  Tom Tromey  <tom@tromey.com>
1698
1699         * tui/tui-stack.c (tui_make_status_line): Return std::string.
1700         (tui_locator_window::rerender): Update.
1701
1702 2019-09-20  Tom Tromey  <tom@tromey.com>
1703
1704         * tui/tui-winsource.h (struct tui_source_window_base)
1705         <~tui_source_window_base>: Don't declare.
1706         <fullname>: Remove.
1707         * tui/tui-winsource.c (~tui_source_window_base): Remove.
1708         * tui/tui-source.h (struct tui_source_window) <fullname>: New
1709         member.
1710         * tui/tui-source.c (tui_source_window::set_contents): Update.
1711         (tui_source_window::location_matches_p)
1712         (tui_source_window::maybe_update): Update.
1713
1714 2019-09-20  Tom Tromey  <tom@tromey.com>
1715
1716         * tui/tui-winsource.h (~tui_source_element): Remove.
1717         (tui_source_element): Update.
1718         (struct tui_source_element) <line>: Now a unique_xmalloc_ptr.
1719         * tui/tui-winsource.c (tui_show_source_line): Update.
1720         * tui/tui-source.c (tui_source_window::set_contents): Update.
1721         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
1722
1723 2019-09-20  Tom Tromey  <tom@tromey.com>
1724
1725         * tui/tui-data.h (tui_clear_source_windows_detail): Don't
1726         declare.
1727         * tui/tui-layout.c (tui_add_win_to_layout): Don't call
1728         tui_clear_source_windows_detail.
1729         * tui/tui-winsource.h (struct tui_source_window_base)
1730         <clear_detail>: Don't declare.
1731         * tui/tui-winsource.c (tui_source_window_base::clear_detail):
1732         Remove.
1733         * tui/tui-data.c (tui_clear_source_windows_detail): Remove.
1734
1735 2019-09-20  Tom Tromey  <tromey@adacore.com>
1736
1737         PR ada/24919:
1738         * block.c (contained_in): Fix final return value.
1739
1740 2019-09-20  Alan Modra  <amodra@gmail.com>
1741
1742         * gdb_bfd.c (gdb_bfd_ref, gdb_bfd_unref): Use bfd_set_usrdata.
1743         * dwarf2read.c (dwarf2_read_gdb_index, dwarf2_read_debug_names),
1744         (read_indirect_string_from_dwz): Use bfd accessor.
1745         * dwarf2read.h (struct dwz_file <filename>): Likewise.
1746         * machoread.c (macho_symfile_read_all_oso): Likewise.
1747         * solib.c (solib_bfd_open): Likewise.
1748
1749 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
1750
1751         * eval.c: Move declaration of overload_resolution to...
1752         * value.h: ...here.
1753
1754 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
1755
1756         * arm-linux-nat.c: Remove extern declaration for arm_apcs_32.
1757         * arm-linux-tdep.c: Likewise.
1758         * arm-nbsd-nat.c: Likewise.
1759         * arm-tdep.h: Declare arm_apcs_32.
1760         * arm-tdep.c: Move documentation for arm_apcs_32 to arm-tdep.h.
1761
1762 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
1763
1764         * dwarf2loc.c: Remove extern declaration of dwarf_always_disassemble.
1765         * dwarf2read.h: Declare dwarf_always_disassemble.
1766
1767 2019-09-19  Tom de Vries  <tdevries@suse.de>
1768
1769         PR gdb/25009
1770         * source-cache.c (source_cache::ensure): Catch exception thrown during
1771         construction of the highlighter.
1772
1773 2019-09-18  Alan Modra  <amodra@gmail.com>
1774
1775         * aarch64-linux-tdep.c, * arm-tdep.c, * auto-load.c,
1776         * coff-pe-read.c, * coffread.c, * corelow.c, * dbxread.c,
1777         * dicos-tdep.c, * dwarf2-frame.c, * dwarf2read.c, * elfread.c,
1778         * exec.c, * fbsd-tdep.c, * gcore.c, * gdb_bfd.c, * gdb_bfd.h,
1779         * hppa-tdep.c, * i386-cygwin-tdep.c, * i386-fbsd-tdep.c,
1780         * i386-linux-tdep.c, * jit.c, * linux-tdep.c, * machoread.c,
1781         * maint.c, * mdebugread.c, * minidebug.c, * mips-linux-tdep.c,
1782         * mips-sde-tdep.c, * mips-tdep.c, * mipsread.c, * nto-tdep.c,
1783         * objfiles.c, * objfiles.h, * osabi.c, * ppc-linux-tdep.c,
1784         * ppc64-tdep.c, * record-btrace.c, * record-full.c, * remote.c,
1785         * rs6000-aix-tdep.c, * rs6000-tdep.c, * s390-linux-tdep.c,
1786         * s390-tdep.c, * solib-aix.c, * solib-dsbt.c, * solib-frv.c,
1787         * solib-spu.c, * solib-svr4.c, * solib-target.c,
1788         * spu-linux-nat.c, * spu-tdep.c, * symfile-mem.c, * symfile.c,
1789         * symmisc.c, * symtab.c, * target.c, * windows-nat.c,
1790         * xcoffread.c, * cli/cli-dump.c, * compile/compile-object-load.c,
1791         * mi/mi-interp.c: Update throughout for bfd section macro and
1792         function changes.
1793         * gcore (gcore_create_callback): Use bfd_set_section_lma.
1794         * spu-tdep.c (spu_overlay_new_objfile): Likewise.
1795
1796 2019-09-18  Tom Tromey  <tom@tromey.com>
1797
1798         * NEWS: Add entry.
1799         * tui/tui.c (tui_initialize_readline): Set name of keymap.  Do not
1800         call rl_initialize.
1801         (tui_enable): Do not call rl_initialize.
1802
1803 2019-09-18  Christian Groessler  <chris@groessler.org>
1804
1805         * alpha-linux-nat.c: Include gdbarch.h.
1806
1807 2019-09-18  Simon Marchi  <simon.marchi@polymtl.ca>
1808
1809         * ui-file.c: Include cli/cli-style.h.
1810         (term_cli_styling): Remove cli_styling declaration.
1811
1812 2019-09-18  Alan Modra  <amodra@gmail.com>
1813
1814         * arm-tdep.c (arm_record_special_symbol): Update bfd_get_section
1815         to bfd_asymbol_section.
1816
1817 2019-09-18  Alan Modra  <amodra@gmail.com>
1818
1819         * amd64-dicos-tdep.c (amd64_dicos_osabi_sniffer): Constify target.
1820         * i386-cygwin-tdep.c (i386_cygwin_init_abi): Likewise.
1821         * i386-dicos-tdep.c (i386_dicos_osabi_sniffer): Likewise.
1822
1823 2019-09-18  Alan Modra  <amodra@gmail.com>
1824
1825         * solib-spu.c (spu_bfd_open): Use bfd_set_filename.
1826         * spu-linux-nat.c (spu_bfd_open): Likewise.
1827
1828 2019-09-18  Christian Biesinger  <cbiesinger@google.com>
1829
1830         * dwarf2loc.c: Change extern declaration of dwarf_always_disassemble
1831         to bool to match definition in dwarf2read.c.
1832
1833 2019-09-17  Christian Biesinger  <cbiesinger@google.com>
1834
1835         * ada-lang.c (ada_ignore_descriptive_types_p): Change to bool.
1836         (print_signatures): Likewise.
1837         (trust_pad_over_xvs): Likewise.
1838         * arch/aarch64-insn.c (aarch64_debug): Likewise.
1839         * arch/aarch64-insn.h (aarch64_debug): Likewise.
1840         * arm-linux-nat.c (arm_apcs_32): Likewise.
1841         * arm-linux-tdep.c (arm_apcs_32): Likewise.
1842         * arm-nbsd-nat.c (arm_apcs_32): Likewise.
1843         * arm-tdep.c (arm_debug): Likewise.
1844         (arm_apcs_32): Likewise.
1845         * auto-load.c (debug_auto_load): Likewise.
1846         (auto_load_gdb_scripts): Likewise.
1847         (global_auto_load): Likewise.
1848         (auto_load_local_gdbinit): Likewise.
1849         (auto_load_local_gdbinit_loaded): Likewise.
1850         * auto-load.h (global_auto_load): Likewise.
1851         (auto_load_local_gdbinit): Likewise.
1852         (auto_load_local_gdbinit_loaded): Likewise.
1853         * breakpoint.c (disconnected_dprintf): Likewise.
1854         (breakpoint_proceeded): Likewise.
1855         (automatic_hardware_breakpoints): Likewise.
1856         (always_inserted_mode): Likewise.
1857         (target_exact_watchpoints): Likewise.
1858         (_initialize_breakpoint): Update.
1859         * breakpoint.h (target_exact_watchpoints): Change to bool.
1860         * btrace.c (maint_btrace_pt_skip_pad): Likewise.
1861         * cli/cli-cmds.c (trace_commands): Likewise.
1862         * cli/cli-cmds.h (trace_commands): Likewise.
1863         * cli/cli-decode.c (add_setshow_boolean_cmd): Change int* argument
1864         to bool*.
1865         * cli/cli-logging.c (logging_overwrite): Change to bool.
1866         (logging_redirect): Likewise.
1867         (debug_redirect): Likewise.
1868         * cli/cli-option.h (option_def) <boolean>: Change return type to bool*.
1869         (struct boolean_option_def) <get_var_address_cb_>: Change return type
1870         to bool.
1871         <boolean_option_def>: Update.
1872         (struct flag_option_def): Change default type of Context to bool
1873         from int.
1874         <flag_option_def>: Change return type of var_address_cb_ to bool*.
1875         * cli/cli-setshow.c (do_set_command): Cast to bool* instead of int*.
1876         (get_setshow_command_value_string): Likewise.
1877         * cli/cli-style.c (cli_styling): Change to bool.
1878         (source_styling): Likewise.
1879         * cli/cli-style.h (source_styling): Likewise.
1880         (cli_styling): Likewise.
1881         * cli/cli-utils.h (struct qcs_flags) <quiet, cont, silent>: Change
1882         to bool.
1883         * command.h (var_types): Update comment.
1884         (add_setshow_boolean_cmd): Change int* var argument to bool*.
1885         * compile/compile-cplus-types.c (debug_compile_cplus_types): Change to
1886         bool.
1887         (debug_compile_cplus_scopes): Likewise.
1888         * compile/compile-internal.h (compile_debug): Likewise.
1889         * compile/compile.c (compile_debug): Likewise.
1890         (struct compile_options) <raw>: Likewise.
1891         * cp-support.c (catch_demangler_crashes): Likewise.
1892         * cris-tdep.c (usr_cmd_cris_version_valid): Likewise.
1893         (usr_cmd_cris_dwarf2_cfi): Likewise.
1894         * csky-tdep.c (csky_debug): Likewise.
1895         * darwin-nat.c (enable_mach_exceptions): Likewise.
1896         * dcache.c (dcache_enabled_p): Likewise.
1897         * defs.h (info_verbose): Likewise.
1898         * demangle.c (demangle): Likewise.
1899         (asm_demangle): Likewise.
1900         * dwarf-index-cache.c (debug_index_cache): Likewise.
1901         * dwarf2-frame.c (dwarf2_frame_unwinders_enabled_p): Likewise.
1902         * dwarf2-frame.h (dwarf2_frame_unwinders_enabled_p): Likewise.
1903         * dwarf2read.c (check_physname): Likewise.
1904         (use_deprecated_index_sections): Likewise.
1905         (dwarf_always_disassemble): Likewise.
1906         * eval.c (overload_resolution): Likewise.
1907         * event-top.c (set_editing_cmd_var): Likewise.
1908         (exec_done_display_p): Likewise.
1909         * event-top.h (set_editing_cmd_var): Likewise.
1910         (exec_done_display_p): Likewise.
1911         * exec.c (write_files): Likewise.
1912         * fbsd-nat.c (debug_fbsd_lwp): Likewise
1913         (debug_fbsd_nat): Likewise.
1914         * frame.h (struct frame_print_options) <print_raw_frame_arguments>:
1915         Likewise.
1916         (struct set_backtrace_options) <backtrace_past_main>: Likewise.
1917         <backtrace_past_entry> Likewise.
1918         * gdb-demangle.h (demangle): Likewise.
1919         (asm_demangle): Likewise.
1920         * gdb_bfd.c (bfd_sharing): Likewise.
1921         * gdbcore.h (write_files): Likewise.
1922         * gdbsupport/common-debug.c (show_debug_regs): Likewise.
1923         * gdbsupport/common-debug.h (show_debug_regs): Likewise.
1924         * gdbthread.h (print_thread_events): Likewise.
1925         * gdbtypes.c (opaque_type_resolution): Likewise.
1926         (strict_type_checking): Likewise.
1927         * gnu-nat.c (gnu_debug_flag): Likewise.
1928         * guile/scm-auto-load.c (auto_load_guile_scripts): Likewise.
1929         * guile/scm-param.c (pascm_variable): Add boolval.
1930         (add_setshow_generic): Update.
1931         (pascm_param_value): Update.
1932         (pascm_set_param_value_x): Update.
1933         * hppa-tdep.c (hppa_debug): Change to bool..
1934         * infcall.c (may_call_functions_p): Likewise.
1935         (coerce_float_to_double_p): Likewise.
1936         (unwind_on_signal_p): Likewise.
1937         (unwind_on_terminating_exception_p): Likewise.
1938         * infcmd.c (startup_with_shell): Likewise.
1939         * inferior.c (print_inferior_events): Likewise.
1940         * inferior.h (startup_with_shell): Likewise.
1941         (print_inferior_events): Likewise.
1942         * infrun.c (step_stop_if_no_debug): Likewise.
1943         (detach_fork): Likewise.
1944         (debug_displaced): Likewise.
1945         (disable_randomization): Likewise.
1946         (non_stop): Likewise.
1947         (non_stop_1): Likewise.
1948         (observer_mode): Likewise.
1949         (observer_mode_1): Likewise.
1950         (set_observer_mode): Update.
1951         (sched_multi): Change to bool.
1952         * infrun.h (debug_displaced): Likewise.
1953         (sched_multi): Likewise.
1954         (step_stop_if_no_debug): Likewise.
1955         (non_stop): Likewise.
1956         (disable_randomization): Likewise.
1957         * linux-tdep.c (use_coredump_filter): Likewise.
1958         (dump_excluded_mappings): Likewise.
1959         * linux-thread-db.c (auto_load_thread_db): Likewise.
1960         (check_thread_db_on_load): Likewise.
1961         * main.c (captured_main_1): Update.
1962         * maint-test-options.c (struct test_options_opts) <flag_opt, xx1_opt,
1963         xx2_opt, boolean_opt>: Change to bool.
1964         * maint-test-settings.c (maintenance_test_settings_boolean): Likewise.
1965         * maint.c (maintenance_profile_p): Likewise.
1966         (per_command_time): Likewise.
1967         (per_command_space): Likewise.
1968         (per_command_symtab): Likewise.
1969         * memattr.c (inaccessible_by_default): Likewise.
1970         * mi/mi-main.c (mi_async): Likewise.
1971         (mi_async_1): Likewise.
1972         * mips-tdep.c (mips64_transfers_32bit_regs_p): Likewise.
1973         * nat/fork-inferior.h (startup_with_shell): Likewise.
1974         * nat/linux-namespaces.c (debug_linux_namespaces): Likewise.
1975         * nat/linux-namespaces.h (debug_linux_namespaces): Likewise.
1976         * nios2-tdep.c (nios2_debug): Likewise.
1977         * or1k-tdep.c (or1k_debug): Likewise.
1978         * parse.c (parser_debug): Likewise.
1979         * parser-defs.h (parser_debug): Likewise.
1980         * printcmd.c (print_symbol_filename): Likewise.
1981         * proc-api.c (procfs_trace): Likewise.
1982         * python/py-auto-load.c (auto_load_python_scripts): Likewise.
1983         * python/py-param.c (union parmpy_variable): Add "bool boolval" field.
1984         (set_parameter_value): Update.
1985         (add_setshow_generic): Update.
1986         * python/py-value.c (copy_py_bool_obj): Change argument from int*
1987         to bool*.
1988         * python/python.c (gdbpy_parameter_value): Cast to bool* instead of
1989         int*.
1990         * ravenscar-thread.c (ravenscar_task_support): Change to bool.
1991         * record-btrace.c (record_btrace_target::store_registers): Update.
1992         * record-full.c (record_full_memory_query): Change to bool.
1993         (record_full_stop_at_limit): Likewise.
1994         * record-full.h (record_full_memory_query): Likewise.
1995         * remote-notif.c (notif_debug): Likewise.
1996         * remote-notif.h (notif_debug): Likewise.
1997         * remote.c (use_range_stepping): Likewise.
1998         (interrupt_on_connect): Likewise.
1999         (remote_break): Likewise.
2000         * ser-tcp.c (tcp_auto_retry): Likewise.
2001         * ser-unix.c (serial_hwflow): Likewise.
2002         * skip.c (debug_skip): Likewise.
2003         * solib-aix.c (solib_aix_debug): Likewise.
2004         * spu-tdep.c (spu_stop_on_load_p): Likewise.
2005         (spu_auto_flush_cache_p): Likewise.
2006         * stack.c (struct backtrace_cmd_options) <full, no_filters, hide>:
2007         Likewise.
2008         (struct info_print_options) <quiet>: Likewise.
2009         * symfile-debug.c (debug_symfile): Likewise.
2010         * symfile.c (auto_solib_add): Likewise.
2011         (separate_debug_file_debug): Likewise.
2012         * symfile.h (auto_solib_add): Likewise.
2013         (separate_debug_file_debug): Likewise.
2014         * symtab.c (basenames_may_differ): Likewise.
2015         (struct filename_partial_match_opts) <dirname, basename>: Likewise.
2016         (struct info_print_options) <quiet, exclude_minsyms>: Likewise.
2017         (struct info_types_options) <quiet>: Likewise.
2018         * symtab.h (demangle): Likewise.
2019         (basenames_may_differ): Likewise.
2020         * target-dcache.c (stack_cache_enabled_1): Likewise.
2021         (code_cache_enabled_1): Likewise.
2022         * target.c (trust_readonly): Likewise.
2023         (may_write_registers): Likewise.
2024         (may_write_memory): Likewise.
2025         (may_insert_breakpoints): Likewise.
2026         (may_insert_tracepoints): Likewise.
2027         (may_insert_fast_tracepoints): Likewise.
2028         (may_stop): Likewise.
2029         (auto_connect_native_target): Likewise.
2030         (target_stop_and_wait): Update.
2031         (target_async_permitted): Change to bool.
2032         (target_async_permitted_1): Likewise.
2033         (may_write_registers_1): Likewise.
2034         (may_write_memory_1): Likewise.
2035         (may_insert_breakpoints_1): Likewise.
2036         (may_insert_tracepoints_1): Likewise.
2037         (may_insert_fast_tracepoints_1): Likewise.
2038         (may_stop_1): Likewise.
2039         * target.h (target_async_permitted): Likewise.
2040         (may_write_registers): Likewise.
2041         (may_write_memory): Likewise.
2042         (may_insert_breakpoints): Likewise.
2043         (may_insert_tracepoints): Likewise.
2044         (may_insert_fast_tracepoints): Likewise.
2045         (may_stop): Likewise.
2046         * thread.c (struct info_threads_opts) <show_global_ids>: Likewise.
2047         (make_thread_apply_all_options_def_group): Change argument from int*
2048         to bool*.
2049         (thread_apply_all_command): Update.
2050         (print_thread_events): Change to bool.
2051         * top.c (confirm): Likewise.
2052         (command_editing_p): Likewise.
2053         (history_expansion_p): Likewise.
2054         (write_history_p): Likewise.
2055         (info_verbose): Likewise.
2056         * top.h (confirm): Likewise.
2057         (history_expansion_p): Likewise.
2058         * tracepoint.c (disconnected_tracing): Likewise.
2059         (circular_trace_buffer): Likewise.
2060         * typeprint.c (print_methods): Likewise.
2061         (print_typedefs): Likewise.
2062         * utils.c (debug_timestamp): Likewise.
2063         (sevenbit_strings): Likewise.
2064         (pagination_enabled): Likewise.
2065         * utils.h (sevenbit_strings): Likewise.
2066         (pagination_enabled): Likewise.
2067         * valops.c (overload_resolution): Likewise.
2068         * valprint.h (struct value_print_options) <prettyformat_arrays,
2069         prettyformat_structs, vtblprint, unionprint, addressprint, objectprint,
2070         stop_print_at_null, print_array_indexes, deref_ref, static_field_print,
2071         pascal_static_field_print, raw, summary, symbol_print, finish_print>:
2072         Likewise.
2073         * windows-nat.c (new_console): Likewise.
2074         (cygwin_exceptions): Likewise.
2075         (new_group): Likewise.
2076         (debug_exec): Likewise.
2077         (debug_events): Likewise.
2078         (debug_memory): Likewise.
2079         (debug_exceptions): Likewise.
2080         (useshell): Likewise.
2081         * windows-tdep.c (maint_display_all_tib): Likewise.
2082         * xml-support.c (debug_xml): Likewise.
2083
2084 2019-09-17  Mike Gulick  <mgulick@mathworks.com>
2085
2086         * source.c (prepare_path_for_appending): New function.
2087         (openp): Make use of new function.
2088         (find_and_open_source): Search for the compilation directory and
2089         source file as a relative path beneath the directory search path.
2090
2091 2019-09-17  Andrew Burgess  <andrew.burgess@embecosm.com>
2092
2093         * source-cache.c (source_cache::get_line_charpos): Catch
2094         exceptions and return false, this matches the behaviour documented
2095         in the header file.
2096
2097 2019-09-17  Joel Brobecker  <brobecker@adacore.com>
2098
2099         * ada-tasks.c (info_task): Remove quoting of the task's name.
2100
2101 2019-09-16  Christian Biesinger  <cbiesinger@google.com>
2102
2103         * symfile.c (auto_solib_add): Replace comment with a reference
2104         to the header file.
2105
2106 2019-09-14  Christian Biesinger  <cbiesinger@google.com>
2107
2108         * NEWS: Mention that gdb can now be compiled with Python 3
2109         on Windows.
2110
2111 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2112
2113         * maint.c (maint_print_section_data::maint_print_section_data):
2114         Force use of 'float log10 (float)' by casting the argument to
2115         float.
2116
2117 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2118
2119         * maint.c: Add 'cmath' include.
2120         (struct maint_print_section_data): New structure.
2121         (print_section_index): New function.
2122         (print_bfd_section_info): Add header comment, small whitespace
2123         cleanup, and update to call new print_section_index function.
2124         (print_objfile_section_info): Likewise.
2125         (maint_obj_section_from_bfd_section): New function.
2126         (print_bfd_section_info_maybe_relocated): New function.
2127         (maintenance_info_sections): Add header comment, always use
2128         bfd_map_over_sections instead of ALL_OBJFILE_OSECTIONS.
2129
2130 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2131
2132         * psymtab.c (find_pc_sect_psymtab): Move baseaddr local into more
2133         inner scope, add check that the objfile has psymtabs before
2134         checking psymtabs_addrmap.
2135         * psymtab.h (psymtab_storage) <psymtabs_addrmap>: Extend comment.
2136
2137 2019-09-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2138
2139         * NEWS: Announce that Ada task names are now shown at more places,
2140         and between quotes (except in info task output).
2141         * gdb/ada-tasks.c (task_to_str): New function.
2142         (display_current_task_id): Call task_to_str.
2143         (task_command_1): Likewise.
2144         (print_ada_task_info): In non-mi mode, Properly align headers and data
2145         when task-id length is > 9 (9 is the default for a 32 bits CORE_ADDR).
2146
2147 2019-09-12  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
2148
2149         * procfs.c (procfs_target::wait) <PR_FAULTED>: Get signal from
2150         prstatus.pr_lwp.pr_info instead of making it up.
2151
2152 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
2153
2154         * auto-load.c (auto_load_expand_dir_vars): Update.
2155         * defs.h (gdb_datadir): Change to std::string.
2156         (python_libdir): Likewise.
2157         (relocate_gdb_directory): Change return type to std::string.
2158         * guile/guile.c (gdbscm_data_directory): Update.
2159         (initialize_scheme_side): Update.
2160         * jit.c (jit_reader_dir): Change to std::string.
2161         (jit_reader_load_command): Update.
2162         * main.c (gdb_datadir): Change to std::string.
2163         (python_libdir): Likewise.
2164         (set_gdb_data_directory): Update.
2165         (relocate_path): Change to return std::string.
2166         (relocate_gdb_directory): Change to return std::string.
2167         (relocate_gdbinit_path_maybe_in_datadir): Update.
2168         (captured_main_1): Update.
2169         * python/python.c (do_start_initialization): Update.
2170         * top.c (show_gdb_datadir): Update.
2171         * xml-syscall.c (xml_init_syscalls_info): Update.
2172         (init_syscalls_info): Update.
2173
2174 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
2175
2176         * main.c (relocate_gdbinit_path_maybe_in_datadir): Factor this code
2177         out of get_init_files.
2178         (get_init_files): Update.
2179
2180 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
2181
2182         * main.c (get_init_files): Change to use std::string.
2183         (captured_main_1): Update.
2184         (print_gdb_help): Update.
2185
2186 2019-09-11  Ali Tamur  <tamur@google.com>
2187
2188         *gdb/target-float.c (host_float_ops<T>::to_longest): Update
2189         implementation.
2190
2191 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
2192
2193         * dbxread.c (read_dbx_symtab): Update.
2194         * dwarf2read.c (load_partial_dies): Update.
2195         * mdebugread.c (parse_partial_symbols): Update.
2196         (handle_psymbol_enumerators): Update.
2197         * psympriv.h (add_psymbol_to_list): Change type of copy_names to bool.
2198         * psymtab.c (add_psymbol_to_bcache): Likewise.
2199         (add_psymbol_to_list): Likewise.
2200         * symtab.c (symbol_set_names): Likewise.
2201         * symtab.h (symbol_set_names): Likewise.
2202         * xcoffread.c (scan_xcoff_symtab): Update.
2203
2204 2019-09-11  Tom Tromey  <tom@tromey.com>
2205
2206         * symfile-mem.c (symbol_file_add_from_memory): Use
2207         bfd_set_filename.
2208         * solib-darwin.c (darwin_bfd_open): Use bfd_set_filename.
2209         * solib-aix.c (solib_aix_bfd_open): Use bfd_set_filename.
2210
2211 2019-09-10  Tom Tromey  <tromey@adacore.com>
2212
2213         * dwarf-index-write.c (write_psymbols): Extend error message.
2214         (debug_names::insert): Add Ada code.
2215         (debug_names::write_psymbols): Remove Ada check.
2216         (debug_names) <m_string_obstack>: New member.
2217         * dwarf2read.c (gdb_index_symbol_name_matcher): Remove.
2218         (gdb_index_symbol_name_matcher::matches): Remove.
2219         (mapped_index_base::find_name_components_bounds): Add "lang"
2220         parameter.
2221         (mapped_index_base::build_name_components): Also split names
2222         according to Ada syntax.
2223         (dw2_expand_symtabs_matching_symbol): Loop over languages.  Change
2224         type of "match_callback".
2225         (check_match, check_find_bounds_finds)
2226         (dw2_expand_symtabs_matching): Update.
2227         (dw2_debug_names_iterator): Add new constructor.
2228         (dw2_debug_names_map_matching_symbols): New function.
2229         (dw2_debug_names_expand_symtabs_matching): Update.
2230         (dwarf2_debug_names_functions): Use
2231         dw2_debug_names_map_matching_symbols.
2232
2233 2019-09-10  Tom Tromey  <tromey@adacore.com>
2234
2235         * dwarf2read.c (dw2_get_file_names_reader): Add the
2236         CU's file name to the results.
2237
2238 2019-09-10  Tom Tromey  <tromey@adacore.com>
2239
2240         * ada-lang.c (add_nonlocal_symbols): Combine calls to
2241         map_matching_symbols.  Update.
2242         * dwarf2read.c (dw2_map_matching_symbols): Update.
2243         * psymtab.c (match_partial_symbol): Change type; update.
2244         (psym_map_matching_symbols): Likewise.
2245         * symfile-debug.c (debug_qf_map_matching_symbols): Change
2246         type; update.
2247         * symfile.h (struct quick_symbol_functions)
2248         <map_matching_symbols>: Change "name" to be a lookup_name_info.
2249         Remove "match".
2250
2251 2019-09-10  Tom Tromey  <tromey@adacore.com>
2252
2253         * psymtab.c (map_block): Remove.
2254         (psym_map_matching_symbols): Use iterate_over_symbols_terminated.
2255         * symtab.c (iterate_over_symbols_terminated): New function.
2256         * symtab.c (iterate_over_symbols_terminated): Declare.
2257
2258 2019-09-10  Tom Tromey  <tromey@adacore.com>
2259
2260         * ada-lang.c (ada_iterate_over_symbols): Return bool.
2261         * language.h (struct language_defn) <la_iterate_over_symbols>:
2262         Return bool.
2263         * symtab.c (iterate_over_symbols): Return bool.
2264         * symtab.h (iterate_over_symbols): Return bool.
2265
2266 2019-09-10  Tom Tromey  <tromey@adacore.com>
2267
2268         * ada-lang.c (aux_add_nonlocal_symbols): Change type.
2269         (add_nonlocal_symbols): Update.
2270         * dwarf2read.c (dw2_map_matching_symbols): Change type.
2271         * psymtab.c (map_block, psym_map_matching_symbols): Change type.
2272         * symfile-debug.c (debug_qf_map_matching_symbols): Change type.
2273         * symfile.h (struct quick_symbol_functions) <map_matching_symbols>:
2274         Change type of "callback".  Remove "data".
2275
2276
2277 2019-09-09  Ali Tamur  <tamur@google.com>
2278
2279         * dwarf2read.c (comp_unit_head): Update comment.
2280         (dwarf2_dwo_name): New function declaration.
2281         (dwarf_unit_type_name): New function declaration.
2282         (read_comp_unit_head): Add support for new compilation units,
2283         DW_UT_partial, DW_UT_skeleton, DW_UT_split_compile, DW_UT_split_type.
2284         Particularly, DW_UT_skeleton and DW_UT_split_compile have dwo_id
2285         (currently named as "signature") in their header. Also clarify error
2286         messages.
2287         (lookup_dwo_id): New function. Returns the dwo id of the given
2288         compile unit.
2289         (lookup_dwo_unit): Use the new lookup_dwo_id function.
2290         (init_cutu_and_read_dies): Use the new dwarf2_dwo_name and lookup_dwo_id
2291         functions.
2292         (create_dwo_cu_reader): Use the added lookup_dwo_id function.
2293         (dwarf2_dwo_name): Get the dwo name if present.
2294         (dwarf_unit_type_name): Convert DW_UT_* types to string for diagnostic
2295         purposes.
2296
2297 2019-09-09  Tom Tromey  <tom@tromey.com>
2298
2299         * tui/tui-win.c (tui_all_windows_info): Use ui_out.
2300
2301 2019-09-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2302
2303         * python/python.c (do_start_initialization): Make progname_copy static,
2304         to avoid a leak report.
2305
2306 2019-09-08  Tom Tromey  <tom@tromey.com>
2307
2308         * tui/tui-wingeneral.c (box_win): Truncate long window titles.
2309
2310 2019-09-07  Simon Marchi  <simon.marchi@efficios.com>
2311
2312         * dwarf2read.c (struct dw2_symtab_iterator) <block_index>:
2313         Change type to gdb::optional<block_enum>.
2314         (dw2_symtab_iter_init): Change block_index parameter type
2315         to gdb::optional<block_enum>.
2316         (dw2_lookup_symbol): Change block_index parameter
2317         type to block_enum.c
2318         (dw2_debug_names_lookup_symbol): Likewise.
2319         * psymtab.c (psym_lookup_symbol): Likewise.
2320         * symfile-debug.c (debug_qf_lookup_symbol): Likewise.
2321         * symfile.h (struct quick_symbol_functions) <lookup_symbol>:
2322         Likewise.
2323
2324 2019-09-06  Christian Biesinger  <cbiesinger@google.com>
2325
2326         * defs.h (relocate_gdb_directory): Change int to bool in
2327         signature and rename flag to relocatable.
2328         * main.c (relocate_path): Likewise.
2329         (relocate_gdb_directory): Likewise.
2330
2331 2019-09-06  Alan Modra  <amodra@gmail.com>
2332
2333         * coffread.c (coff_symfile_read): Constify filename variable.
2334         * dbxread.c (dbx_symfile_init, coffstab_build_psymtabs),
2335         (elfstab_build_psymtabs, stabsect_build_psymtabs): Likewise.
2336         * gdb_bfd.c (gdb_bfd_close_or_warn): Likewise.
2337         * solib.c (reload_shared_libraries_1): Likewise.
2338         * symfile.c (reread_symbols): Likewise.
2339         * solib-aix.c (solib_aix_bfd_open): Add cast for xfree of filename.
2340         * solib-darwin.c (darwin_bfd_open): Likewise.
2341         * symfile-mem.c (symbol_file_add_from_memory): Likewise.
2342
2343 2019-09-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2344
2345         * psymtab.c (print_partial_symbols): Handle missing domain_enum
2346         values MODULE_DOMAIN and COMMON_BLOCK_DOMAIN.
2347
2348 2019-09-03  Tom Tromey  <tromey@adacore.com>
2349
2350         * ada-valprint.c (ada_val_print_num): Don't recurse for range
2351         types.
2352         (has_negatives): Unbias a range type bound.
2353         * dwarf2read.c (read_subrange_type): Handle DW_AT_GNU_bias.
2354         * gdbtypes.c (operator==): Handle new field.
2355         (create_range_type): Add "bias" parameter.
2356         (create_static_range_type, resolve_dynamic_range): Update.
2357         * gdbtypes.h (struct range_bounds) <bias>: New member.
2358         (create_range_type): Add bias parameter.
2359         * printcmd.c (print_scalar_formatted): Unbias range types.
2360         * value.c (unpack_long): Unbias range types.
2361         (pack_long): Bias range types.
2362
2363 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
2364
2365         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Check all
2366         probe arguments.
2367
2368 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
2369
2370         * break-catch-throw.c (fetch_probe_arguments): Use gdbarch.
2371         * dtrace-probe.c (dtrace_probe::get_argument_count): Likewise.
2372         * probe.c (probe_safe_evaluate_at_pc) (compute_probe_arg)
2373         (compile_probe_arg): Likewise.
2374         * probe.h (get_argument_count): Likewise.
2375         * solib-svr4.c (solib_event_probe_action): Likewise.
2376         * stap-probe.c (stap_probe::get_argument_count): Likewise.
2377
2378 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
2379
2380         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Move
2381         code to here...
2382         (svr4_create_solib_event_breakpoints): ...from here.
2383
2384 2019-08-30  Sergio Durigan Junior  <sergiodj@redhat.com>
2385
2386         * nat/fork-inferior.c (trace_start_error): Remove "\nError: "
2387         suffix from warning message.
2388
2389 2019-08-30  Tom Tromey  <tom@tromey.com>
2390
2391         * tui/tui-winsource.h (struct tui_source_window_base)
2392         <refresh_all>: Don't declare.
2393         * tui/tui-winsource.c (tui_source_window_base::refresh_all):
2394         Remove.
2395         * tui/tui-win.c (tui_refresh_all_win): Don't call refresh_all or
2396         tui_show_locator_content.
2397         * tui/tui-regs.h (struct tui_data_window) <refresh_all>: Don't
2398         declare.
2399         * tui/tui-regs.c (tui_data_window::refresh_all): Remove.
2400         * tui/tui-data.h (struct tui_win_info) <refresh_all>: Don't
2401         declare.
2402
2403 2019-08-30  Tom Tromey  <tom@tromey.com>
2404
2405         * tui/tui-io.c (tui_cont_sig): Don't call wrefresh.
2406
2407 2019-08-30  Tom Tromey  <tom@tromey.com>
2408
2409         * tui/tui-stack.c (_initialize_tui_stack): Move later.
2410         Remove unnecessary forward declarations.
2411
2412 2019-08-30  Tom Tromey  <tom@tromey.com>
2413
2414         * tui/tui-stack.c (tui_locator_window::set_locator_fullname): Call
2415         rerender.
2416         (tui_update_locator_fullname, tui_show_frame_info): Don't call
2417         tui_show_locator_content.
2418
2419 2019-08-30  Tom Tromey  <tom@tromey.com>
2420
2421         * tui/tui-stack.c (tui_show_locator_content): Move lower.  Rewrite.
2422         (tui_locator_window::rerender): Rewrite using body of previous
2423         tui_show_locator_content.
2424
2425 2019-08-30  Tom Tromey  <tom@tromey.com>
2426
2427         * tui/tui-stack.h (struct tui_locator_window) <set_locator_info,
2428         set_locator_fullname>: New methods.
2429         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
2430         Rename from tui_set_locator_fullname.
2431         (tui_locator_window::set_locator_info): Rename from
2432         tui_set_locator_info.  Return bool.
2433         (tui_update_locator_fullname, tui_show_frame_info): Update.
2434
2435 2019-08-30  Tom Tromey  <tom@tromey.com>
2436
2437         * tui/tui-layout.c (show_layout): Don't call tui_refresh_all.
2438
2439 2019-08-30  Tom Tromey  <tom@tromey.com>
2440
2441         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Don't
2442         call touchwin.
2443
2444 2019-08-30  Tom Tromey  <tom@tromey.com>
2445
2446         * tui/tui-wingeneral.c (box_win): Assume win_info and
2447         win_info->handle cannot be NULL.
2448
2449 2019-08-30  Tom Tromey  <tom@tromey.com>
2450
2451         * tui/tui-regs.h (struct tui_data_item_window) <rerender,
2452         refresh_window>: Declare.
2453         * tui/tui-regs.c (tui_data_window::display_registers_from): Call
2454         resize.
2455         (tui_data_item_window::rerender): Rename from
2456         tui_display_register.
2457         (tui_data_item_window::refresh_window): New method.
2458         * tui/tui-layout.c (tui_gen_win_info::resize): Do nothing on
2459         no-op.
2460
2461 2019-08-30  Tom Tromey  <tom@tromey.com>
2462
2463         * tui/tui-regs.h (struct tui_data_window) <regs_content,
2464         regs_column_count, current_group>: Move later.  Now private.
2465         <get_current_group>: New method.
2466         * tui/tui-regs.c (tui_reg_command): Update.
2467         * tui/tui-layout.c (tui_set_layout): Update.
2468
2469 2019-08-30  Tom Tromey  <tom@tromey.com>
2470
2471         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
2472         (tui_data_window::rerender): Don't call
2473         check_and_display_highlight_if_needed.
2474         (tui_data_window::refresh_all): Remove call to
2475         erase_data_content.
2476
2477 2019-08-30  Tom Tromey  <tom@tromey.com>
2478
2479         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
2480         (tui_data_window::display_registers_from)
2481         (tui_data_window::display_reg_element_at_line)
2482         (tui_data_window::display_registers_from_line): Remove checks of
2483         "empty".
2484
2485 2019-08-30  Tom Tromey  <tom@tromey.com>
2486
2487         * tui/tui-regs.h (struct tui_data_window) <display_all_data>:
2488         Don't declare.
2489         * tui/tui-regs.c (tui_data_window::show_registers): Call
2490         rerender.
2491         (tui_data_window::rerender): Rename from display_all_data.
2492         (tui_data_window::rerender): Remove old implementation.
2493
2494 2019-08-30  Tom Tromey  <tom@tromey.com>
2495
2496         * tui/tui-regs.c (tui_data_window::display_all_data): Change
2497         text.
2498         * tui/tui-data.h (NO_DATA_STRING): Remove define.
2499
2500 2019-08-29  Bernhard Wodok  <barto@gmx.net>
2501             Sergio Durigan Junior  <sergiodj@redhat.com>
2502
2503         PR win32/24284
2504         * mingw-hdep.c (gdb_select): Handle case when 'n' is zero.
2505
2506 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
2507
2508         * symtab.c (search_symbols): Don't include MODULE_DOMAIN symbols
2509         when searching for types.
2510
2511 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
2512
2513         * f-lang.c (f_language_defn): Use f_print_typedef.
2514         * f-lang.h (f_print_typedef): Declare.
2515         * f-typeprint.c (f_print_typedef): Define.
2516
2517 2019-08-27  Christian Biesinger  <cbiesinger@google.com>
2518
2519         * nat/linux-namespaces.c (mnsh_main): Initialize fd (to -1).
2520
2521 2019-08-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2522
2523         * cli/cli-utils.c (info_print_options_defs): Delete.
2524         (make_info_print_options_def_group): Delete.
2525         (extract_info_print_options): Delete.
2526         (info_print_command_completer): Delete.
2527         (info_print_args_help): Add extra parameter, and optionally
2528         include text about -n flag.
2529         * cli/cli-utils.h (struct info_print_options): Delete.
2530         (extract_info_print_options): Delete declaration.
2531         (info_print_command_completer): Delete declaration.
2532         (info_print_args_help): Add extra parameter, extend header
2533         comment.
2534         * python/python.c (gdbpy_rbreak): Pass additional parameter to
2535         search_symbols.
2536         * stack.c (struct info_print_options): New type.
2537         (info_print_options_defs): New file scoped variable.
2538         (make_info_print_options_def_group): New static function.
2539         (info_print_command_completer): New static function.
2540         (info_locals_command): Update to use new local functions.
2541         (info_args_command): Likewise.
2542         (_initialize_stack): Add extra parameter to calls to
2543         info_print_args_help.
2544         * symtab.c (search_symbols): Add extra parameter, use this to
2545         possibly excluse non-debug symbols.
2546         (symtab_symbol_info): Add extra parameter, which is passed on to
2547         search_symbols.
2548         (struct info_print_options): New type.
2549         (info_print_options_defs): New file scoped variable.
2550         (make_info_print_options_def_group): New static function.
2551         (info_print_command_completer): New static function.
2552         (info_variables_command): Update to use local functions, and pass
2553         extra parameter through to symtab_symbol_info.
2554         (info_functions_command): Likewise.
2555         (info_types_command): Pass additional argument through to
2556         symtab_symbol_info.
2557         (rbreak_command): Pass extra argument to search_symbols.
2558         (_initialize_symtab): Add extra arguments for calls to
2559         info_print_args_help, and update help text for 'info variables',
2560         'whereis', and 'info functions' commands.
2561         * symtab.h (search_symbols): Add extra argument to declaration.
2562         * NEWS: Mention new flags.
2563
2564 2019-08-26  Christian Biesinger  <cbiesinger@google.com>
2565
2566         * symtab.c (lookup_static_symbol): Call the new function (and move
2567         it down to be next to lookup_global_symbol).
2568         (struct global_sym_lookup_data): Add block_enum member and rename to...
2569         (struct global_or_static_sym_lookup_data): ...this.
2570         (lookup_symbol_global_iterator_cb): Pass block_index instead of
2571         GLOBAL_BLOCK to lookup_symbol_in_objfile and rename to...
2572         (lookup_symbol_global_or_static_iterator_cb): ...this.
2573         (lookup_global_or_static_symbol): New function.
2574         (lookup_global_symbol): Call new function.
2575
2576 2019-08-26  Tom de Vries  <tdevries@suse.de>
2577
2578         PR c++/24852
2579         * break-catch-throw.c (fetch_probe_arguments): Improve error mesage
2580         when pc_probe.prob == NULL.
2581
2582 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
2583
2584         * dwarf2read.c (dw2_debug_names_iterator::next): Rename local
2585         variable symbol_linkage to symbol_linkage_.
2586
2587 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
2588
2589         * dwarf2read.c (dw2_debug_names_iterator::next): Use enum to
2590         represent whether the symbol is static, dynamic, or we don't
2591         know.
2592
2593 2019-08-25  Yoshinori Sato <ysato@users.sourceforge.jp>
2594
2595         * gdb/rx-tdep.c (rx_register_names): New.
2596         (rx_register_name): Delete.
2597         (rx_psw_type): Delete.
2598         (rx_fpsw_type): Delete.
2599         (rx_register_type): Delete.
2600         (rx_gdbarch_init): Convert target-descriptions.
2601         (_initialize_rx_tdep): Add initialize_tdesc_rx.
2602         * gdb/features/Makefile: Add rx.xml.
2603         * gdb/features/rx.xml: New.
2604         * gdb/features/rx.c: Generated.
2605         * gdb/NEWS: Mention target description support.
2606
2607 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
2608
2609         * symtab.c (symbol_cache_lookup): Always initialize *bsc_ptr and
2610         *slot_ptr.
2611
2612 2019-08-23  Sergio Durigan Junior  <sergiodj@redhat.com>
2613
2614         * configure.ac: Don't check for 'dlfcn.h' (moved to
2615         gdbsupport/common.m4).
2616         * Makefile.in (COMMON_SFILES): Move 'gdb-dlfcn.c' to
2617         'gdbsupport/'.
2618         (HFILES_NO_SRCDIR): Likewise, for 'gdb-dlfcn.h'.
2619         * compile/compile-c-support.c: Include
2620         'gdbsupport/gdb-dlfcn.h'.
2621         * gdbsupport/common.m4: Check for 'dlfcn.h'.
2622         * gdb-dlfcn.c: Move to...
2623         * gdbsupport/gdb-dlfcn.c: ... here.
2624         * gdb-dlfcn.h: Move to...
2625         * gdbsupport/gdb-dlfcn.h: ... here.
2626
2627 2019-08-23  Sandra Loosemore  <sandra@codesourcery.com>
2628
2629         * nios2-tdep.c (struct reg_value): Improve comments.  Make
2630         the offset field signed.
2631
2632 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
2633
2634         * python/lib/gdb/__init__.py (_execute_file): New function.
2635         * python/python.c (python_run_simple_file): Call gdb._execute_file
2636         on Windows.
2637
2638 2019-08-22  Andrew Burgess  <andrew.burgess@embecosm.com>
2639
2640         * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
2641         all uses as this was never set to anything but a zero value.
2642
2643 2019-08-21  Bogdan Harjoc  <harjoc@gmail.com>
2644
2645         * cli/cli-cmds.c (with_command_1): Error out if no arguments.
2646
2647 2019-08-21  Christian Biesinger  <cbiesinger@google.com>
2648
2649         * tui/tui-data.h (tui_gen_win_info): Add an =default
2650         move constructor, required by some GCC versions.
2651
2652 2019-08-21  Jinke Fan  <fanjinke51@yeah.net>
2653
2654         * go32-nat.c (go32_sysinfo): Add hygon_p.
2655
2656 2019-08-20  Tom Tromey  <tom@tromey.com>
2657
2658         * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
2659         line_from_reg_element_no, first_reg_element_no_inline,
2660         display_all_data, delete_data_content_windows,
2661         erase_data_content>: Now private.
2662
2663 2019-08-20  Tom Tromey  <tom@tromey.com>
2664
2665         * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
2666         (tui_unhighlight_win, tui_highlight_win)
2667         (tui_win_info::make_window): Update.
2668         * tui/tui-data.h (HILITE, NO_HILITE): Remove.
2669
2670 2019-08-20  Tom Tromey  <tom@tromey.com>
2671
2672         * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
2673         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
2674         (MAX_PID_WIDTH): Move to tui-stack.c.
2675         * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
2676         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
2677         (MAX_PID_WIDTH): Move from tui-data.h.
2678
2679 2019-08-20  Tom Tromey  <tom@tromey.com>
2680
2681         * tui/tui-wingeneral.h (tui_make_window): Don't declare.
2682         * tui/tui-wingeneral.c (box_win): Change type of win_info.
2683         (box_win): Update.
2684         (tui_gen_win_info::make_window): Rename from tui_make_window.
2685         (tui_win_info::make_window): New method.
2686         (tui_gen_win_info::make_visible): Update.
2687         * tui/tui-source.c (tui_source_window::set_contents): Update.
2688         * tui/tui-regs.c (tui_data_window::show_register_group): Update.
2689         (tui_data_window::display_registers_from): Update.
2690         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
2691         * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
2692         Declare.
2693         <can_box>: Remove.
2694         <title>: Remove.
2695         (struct tui_win_info) <make_window>: Declare.
2696         <can_box>: Now virtual.
2697         <title>: New member.
2698         * tui/tui-data.c (~tui_gen_win_info): Don't free title.
2699         * tui/tui-command.c (tui_cmd_window::resize): Update.
2700
2701 2019-08-20  Tom Tromey  <tom@tromey.com>
2702
2703         * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
2704         * tui/tui-regs.c (tui_data_window::show_registers): Update.
2705         (tui_data_window::check_register_values): Update.
2706
2707 2019-08-20  Tom Tromey  <tom@tromey.com>
2708
2709         * tui/tui-regs.h (struct tui_data_window): Use
2710         DISABLE_COPY_AND_ASSIGN.
2711         <regs_content>: Change type, removing unique_ptr.
2712         <tui_data_window>: Add move constructor.
2713         * tui/tui-regs.c (tui_data_window::show_registers)
2714         (tui_data_window::show_register_group)
2715         (tui_data_window::display_registers_from)
2716         (tui_data_window::display_registers_from)
2717         (tui_data_window::first_data_item_displayed)
2718         (tui_data_window::delete_data_content_windows)
2719         (tui_data_window::rerender, tui_data_window::refresh_window)
2720         (tui_data_window::check_register_values): Update.
2721
2722 2019-08-20  Tom Tromey  <tom@tromey.com>
2723
2724         * tui/tui-regs.h (struct tui_data_window) <show_registers,
2725         show_register_group>: Declare.
2726         (tui_show_register_group): Don't declare.
2727         * tui/tui-regs.c (tui_data_window::show_registers): Rename from
2728         tui_show_registers.
2729         (tui_data_window::show_register_group): Rename from
2730         tui_show_register_group.
2731         (tui_data_window::check_register_values, tui_reg_command):
2732         Update.
2733         * tui/tui-layout.c (tui_set_layout): Update.
2734
2735 2019-08-20  Tom Tromey  <tom@tromey.com>
2736
2737         * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
2738         Declare.
2739         (tui_check_register_values): Don't declare.
2740         * tui/tui-regs.c (tui_data_window::check_register_values): Rename
2741         from tui_check_register_values.
2742         * tui/tui-hooks.c (tui_register_changed): Update.
2743
2744 2019-08-20  Tom Tromey  <tom@tromey.com>
2745
2746         * tui/tui-regs.c (tui_reg_layout): Move later.
2747         (tui_show_registers): Don't enable TUI mode or change layout.
2748
2749 2019-08-20  Tom Tromey  <tom@tromey.com>
2750
2751         * tui/tui-regs.h (struct tui_data_item_window)
2752         <~tui_data_item_window>: Remove.
2753         <content>: Now a unique_xmalloc_ptr.
2754         * tui/tui-regs.c (tui_register_format): Return a
2755         unique_xmalloc_ptr.
2756         (tui_get_register): Update.
2757         (~tui_data_item_window): Remove.
2758         (tui_data_window::display_registers_from, tui_display_register):
2759         Update.
2760         * tui/tui-io.h (tui_expand_tabs): Update.
2761         * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
2762         Remove "col" parameter.
2763
2764 2019-08-20  Tom Tromey  <tom@tromey.com>
2765
2766         * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
2767         field.
2768         * tui/tui-regs.c (~tui_data_item_window): Update.
2769
2770 2019-08-20  Tom Tromey  <tom@tromey.com>
2771
2772         * tui/tui-regs.c (tui_register_format, tui_get_register): Move
2773         earlier.
2774
2775 2019-08-20  Tom Tromey  <tom@tromey.com>
2776
2777         * tui/tui-regs.c (tui_reg_command): Remove NULL check.
2778
2779 2019-08-20  Tom Tromey  <tom@tromey.com>
2780
2781         * tui/tui-source.h (struct tui_source_window): Update.
2782         * tui/tui-regs.c (tui_show_registers): Update.
2783         * tui/tui-disasm.h (struct tui_disasm_window): Update.
2784         * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
2785         (NO_REGS_STRING): Remove defines.
2786
2787 2019-08-20  Conrad Meyer  <cem@FreeBSD.org>
2788
2789         * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
2790         unnecessary thread walk if remote doesn't support the packet.
2791
2792 2019-08-19  Tom Tromey  <tromey@adacore.com>
2793
2794         * python/py-value.c (value_has_field): Fix indentation.
2795
2796 2019-08-19  Tom Tromey  <tromey@adacore.com>
2797
2798         * printcmd.c (do_one_display, info_display_command): Update.
2799         * block.h (contained_in): Return bool.  Add allow_nested
2800         parameter.
2801         * block.c (contained_in): Return bool.  Add allow_nested
2802         parameter.
2803
2804 2019-08-19  Tom Tromey  <tom@tromey.com>
2805
2806         * configure: Rebuild.
2807         * configure.ac: Disallow the combination of -static-libstdc++ and
2808         source highlight.
2809         * source-cache.c (get_language_name): Handle rust.
2810         (source_cache::get_source_lines): Ignore highlighting exceptions.
2811
2812 2019-08-16  Tom Tromey  <tom@tromey.com>
2813
2814         * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
2815         * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
2816         (struct tui_source_window_base) <make_visible, refresh_window,
2817         resize>: Remove methods.
2818         <execution_info>: Remove field.
2819         * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
2820         (tui_show_source_line, tui_source_window_base)
2821         (~tui_source_window_base): Update.
2822         (tui_source_window_base::resize)
2823         (tui_source_window_base::make_visible)
2824         (tui_source_window_base::refresh_window): Remove.
2825         (tui_source_window_base::update_exec_info): Update.
2826         * tui/tui-source.c (tui_source_window::set_contents): Update.
2827         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
2828
2829 2019-08-16  Tom Tromey  <tom@tromey.com>
2830
2831         * tui/tui-hooks.c (tui_remove_hooks): Don't set
2832         deprecated_query_hook.
2833
2834 2019-08-16  Tom Tromey  <tom@tromey.com>
2835
2836         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
2837         (tui_update_source_windows_with_line): Update.
2838         * tui/tui-source.h (struct tui_source_window)
2839         <show_symtab_source>: Declare.
2840         (tui_show_symtab_source): Don't declare.
2841         * tui/tui-source.c (tui_show_symtab_source): Rename from
2842         tui_show_symtab_source.
2843
2844 2019-08-16  Tom Tromey  <tom@tromey.com>
2845
2846         * tui/tui-winsource.h (struct tui_source_window_base)
2847         <set_contents>: Declare.
2848         * tui/tui-winsource.c
2849         (tui_source_window_base::update_source_window_as_is): Update.
2850         * tui/tui-source.h (struct tui_source_window) <set_contents>:
2851         Declare.
2852         (tui_set_source_content): Don't declare.
2853         * tui/tui-source.c (tui_source_window::set_contents): Rename from
2854         tui_set_source_content.
2855         * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
2856         Declare.
2857         (tui_set_disassem_content): Don't declare.
2858         * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
2859         tui_set_disassem_content.
2860
2861 2019-08-16  Tom Tromey  <tom@tromey.com>
2862
2863         * tui/tui-winsource.h (struct tui_source_window_base)
2864         <update_breakpoint_info>: Declare.
2865         (tui_update_breakpoint_info): Don't declare.
2866         * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
2867         (tui_update_all_breakpoint_info): Update.
2868         (tui_source_window_base::update_breakpoint_info): Rename from
2869         tui_update_breakpoint_info.
2870         (tui_source_window_base::update_exec_info): Update.
2871
2872 2019-08-16  Tom Tromey  <tom@tromey.com>
2873
2874         * tui/tui-winsource.h (struct tui_source_window_base)
2875         <update_source_window>: Declare.
2876         (tui_update_source_window): Don't declare.
2877         * tui/tui-winsource.c
2878         (tui_source_window_base::update_source_window): Rename from
2879         tui_update_source_window.
2880         (tui_source_window_base::rerender): Update.
2881         * tui/tui-source.c (tui_source_window::maybe_update): Update.
2882         * tui/tui-disasm.c (tui_show_disassem)
2883         (tui_show_disassem_and_update_source)
2884         (tui_disasm_window::maybe_update): Update.
2885
2886 2019-08-16  Tom Tromey  <tom@tromey.com>
2887
2888         * tui/tui-winsource.h (struct tui_source_window_base)
2889         <update_source_window_as_is>: Declare.
2890         (tui_update_source_window_as_is): Don't declare.
2891         * tui/tui-winsource.c (tui_update_source_window): Update
2892         (tui_source_window_base::update_source_window_as_is): Rename from
2893         tui_update_source_window_as_is.
2894         (tui_source_window_base::refill): Update.
2895         * tui/tui-source.c (tui_show_symtab_source): Update.
2896         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
2897         Update.
2898
2899 2019-08-16  Tom Tromey  <tom@tromey.com>
2900
2901         * tui/tui-winsource.h (tui_update_source_window)
2902         (tui_update_source_window_as_is): Remove "noerror" parameter.
2903         * tui/tui-winsource.c (tui_update_source_window)
2904         (tui_update_source_window_as_is): Remove "noerror" parameter.
2905         (tui_update_source_windows_with_addr)
2906         (tui_update_source_windows_with_line)
2907         (tui_source_window_base::rerender)
2908         (tui_source_window_base::refill): Update.
2909         * tui/tui-source.h (tui_set_source_content)
2910         (tui_show_symtab_source): Remove "noerror" parameter.
2911         * tui/tui-source.c (tui_set_source_content): Remove "noerror"
2912         parameter.
2913         (tui_show_symtab_source): Likewise.
2914         (tui_source_window::maybe_update): Update.
2915         * tui/tui-disasm.c (tui_show_disassem)
2916         (tui_show_disassem_and_update_source)
2917         (tui_disasm_window::do_scroll_vertical)
2918         (tui_disasm_window::maybe_update): Update.
2919
2920 2019-08-16  Tom Tromey  <tom@tromey.com>
2921
2922         * tui/tui.c (tui_is_window_visible): Update.
2923         * tui/tui-wingeneral.c (tui_make_window)
2924         (tui_gen_win_info::make_visible, tui_refresh_all): Update.
2925         * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
2926         (tui_set_focus_command, tui_all_windows_info, update_tab_width)
2927         (tui_set_win_height_command, parse_scrolling_args): Update.
2928         * tui/tui-source.c (tui_source_window::style_changed): Update.
2929         * tui/tui-regs.c (tui_show_registers)
2930         (tui_data_window::first_data_item_displayed)
2931         (tui_data_window::delete_data_content_windows)
2932         (tui_check_register_values, tui_reg_command): Update.
2933         * tui/tui-disasm.c (tui_show_disassem): Update.
2934         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
2935         method.
2936         <is_visible>: Remove field.
2937         * tui/tui-data.c (tui_next_win, tui_prev_win)
2938         (tui_delete_invisible_windows): Update.
2939
2940 2019-08-16  Tom Tromey  <tom@tromey.com>
2941
2942         * tui/tui-winsource.h (struct tui_source_window_base)
2943         <m_has_locator>: Remove.
2944         * tui/tui-layout.c (show_source_disasm_command, show_data)
2945         (show_source_or_disasm_and_command): Update.
2946
2947 2019-08-16  Alan Hayward  <alan.hayward@arm.com>
2948
2949         * NEWS (Other MI changes): New subsection.
2950         * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
2951         (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
2952         * arch-utils.c (default_get_pc_address_flags): New function.
2953         * arch-utils.h (default_get_pc_address_flags): New declaration.
2954         * gdbarch.sh: Add get_pc_address_flags.
2955         * gdbarch.c: Regenerate.
2956         * gdbarch.h: Likewise.
2957         * stack.c (print_pc): New function.
2958         (print_frame_info) (print_frame): Call print_pc.
2959
2960 2019-08-16  Tom de Vries  <tdevries@suse.de>
2961
2962         * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
2963         print_objfile_section_info.
2964
2965 2019-08-15  Tom Tromey  <tom@tromey.com>
2966
2967         * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
2968         calling update_cmdwin_start_line.
2969         * tui/tui-winsource.h (struct tui_source_window_base)
2970         <do_make_visible_with_new_height, set_new_height>: Don't declare.
2971         <rerender>: Declare.
2972         * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
2973         Call rerender.
2974         (tui_source_window_base::set_new_height): Remove.
2975         (tui_source_window_base::rerender): Rename from
2976         do_make_visible_with_new_height.
2977         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
2978         resize method.
2979         (tui_win_info::make_invisible_and_set_new_height)
2980         (tui_win_info::make_visible_with_new_height): Remove.
2981         * tui/tui-stack.h (struct tui_locator_window) <rerender>:
2982         Declare.
2983         * tui/tui-stack.c (tui_locator_window::rerender): New method.
2984         * tui/tui-regs.h (struct tui_data_window) <set_new_height,
2985         do_make_visible_with_new_height>: Don't declare.
2986         <rerender>: Declare.
2987         * tui/tui-regs.c (tui_data_window::rerender): Rename from
2988         set_new_height.
2989         (tui_data_window::do_make_visible_with_new_height): Remove.
2990         * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
2991         call tui_show_locator_content.
2992         (tui_gen_win_info::resize): Call rerender.
2993         (show_source_or_disasm_and_command): Don't call
2994         tui_show_locator_content.
2995         * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
2996         method.
2997         (struct tui_win_info) <rerender>: Declare.
2998         <set_new_height, make_invisible_and_set_new_height,
2999         make_visible_with_new_height>: Don't declare.
3000         * tui/tui-data.c (tui_win_list::rerender): New method.
3001         * tui/tui-command.h (struct tui_cmd_window)
3002         <do_make_visible_with_new_height>: Don't declare.
3003         * tui/tui-command.c
3004         (tui_cmd_window::do_make_visible_with_new_height): Remove.
3005
3006 2019-08-15  Tom Tromey  <tromey@adacore.com>
3007
3008         * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
3009         * ada-lang.c (ada_enum_name): Likewise.
3010
3011 2019-08-15  Christian Biesinger  <cbiesinger@google.com>
3012
3013         * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
3014         leading underscore.
3015         (GdbOutputErrorFile): Likewise.
3016         (global scope): Adjust constructor calls to GdbOutput{,Error}File
3017         accordingly.
3018         (execute_unwinders): Rename to have a leading underscore.
3019         (auto_load_packages): Likewise.
3020         (global scope): Adjust call to auto_load_packages accordingly.
3021         (GdbSetPythonDirectory): Likewise.
3022         * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
3023         instead of execute_unwinders.
3024
3025 2019-08-15  Tom Tromey  <tom@tromey.com>
3026
3027         * tui/tui-layout.c (show_layout, show_source_disasm_command)
3028         (show_data): Don't change window visibility.
3029         (tui_gen_win_info::resize): Remove special case for command
3030         window.  Use wresize, when available.
3031         (show_source_or_disasm_and_command): Don't change window
3032         visibility.
3033         * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
3034         <make_visible>: New method.
3035         * tui/tui-command.c (tui_cmd_window::resize): New method.
3036
3037 2019-08-15  Tom Tromey  <tom@tromey.com>
3038
3039         * tui/tui-winsource.h (struct tui_source_window_iterator): New.
3040         (struct tui_source_windows): New.
3041         * tui/tui-winsource.c (tui_display_main): Update.
3042         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
3043         (new_height_ok, parse_scrolling_args): Update.
3044         * tui/tui-layout.c (show_layout, show_data): Update.
3045         * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
3046         (tui_add_to_source_windows): Don't declare.
3047         * tui/tui-data.c (source_windows, tui_source_windows)
3048         (tui_clear_source_windows, tui_add_to_source_windows): Remove.
3049
3050 2019-08-15  Tom Tromey  <tom@tromey.com>
3051
3052         * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
3053         Rename from reset.
3054         * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
3055         * tui/tui-layout.c (show_source_disasm_command, show_data):
3056         Update.
3057         (tui_gen_win_info::resize): Rename.
3058         (show_source_or_disasm_and_command): Update.
3059         * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
3060         reset.
3061
3062 2019-08-15  Tom Tromey  <tom@tromey.com>
3063
3064         * tui/tui-stack.c (tui_initialize_static_data): Remove.
3065         * tui/tui-interp.c (tui_interp::init): Don't call
3066         tui_initialize_static_data.
3067         * tui/tui-data.h (tui_initialize_static_data): Don't declare.
3068
3069 2019-08-15  Tom Tromey  <tom@tromey.com>
3070
3071         * tui/tui-layout.c (tui_default_win_viewport_height): Don't
3072         examine tui_win_list.
3073
3074 2019-08-15  Tom Tromey  <tom@tromey.com>
3075
3076         * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
3077         * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
3078         tui_clear_source_content.
3079         (tui_clear_source_content): Remove.
3080         (tui_source_window_base::do_erase_source_content): Hoist call to
3081         content.clear().
3082         * tui/tui-stack.c (tui_show_frame_info): Don't call
3083         tui_clear_source_content.
3084
3085 2019-08-15  Tom Tromey  <tom@tromey.com>
3086
3087         * tui/tui-winsource.h (struct tui_source_window_base)
3088         <do_erase_source_content>: New method.
3089         <erase_source_content>: New method.
3090         (tui_erase_source_content): Don't declare.
3091         * tui/tui-winsource.c (tui_clear_source_content): Update.
3092         (tui_source_window_base::do_erase_source_content): Rename from
3093         tui_erase_source_content.
3094         (tui_source_window_base::show_source_content): Update.
3095         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
3096         * tui/tui-source.h (struct tui_source_window)
3097         <erase_source_content>: New method.
3098         * tui/tui-disasm.h (struct tui_disasm_window)
3099         <erase_source_content>: New method.
3100
3101 2019-08-15  Tom Tromey  <tom@tromey.com>
3102
3103         * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
3104         (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
3105         constructor.
3106         * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
3107         * tui/tui-source.c (tui_set_source_content): Update.
3108         * tui/tui-disasm.c (tui_set_disassem_content): Update.
3109
3110 2019-08-15  Tom Tromey  <tom@tromey.com>
3111
3112         * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
3113         * tui/tui-winsource.c (tui_line_is_displayed): Move to
3114         tui-source.c.
3115         * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
3116         Declare.
3117         * tui/tui-source.c (tui_source_window::line_is_displayed): New
3118         method.
3119         (tui_source_window::maybe_update): Update.
3120
3121 2019-08-15  Tom Tromey  <tom@tromey.com>
3122
3123         * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
3124         * tui/tui-winsource.c (tui_addr_is_displayed): Move to
3125         tui-disasm.c.
3126         * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
3127         Declare.
3128         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
3129         method.
3130         (tui_disasm_window::maybe_update): Update.
3131
3132 2019-08-15  Tom Tromey  <tom@tromey.com>
3133
3134         * tui/tui-winsource.h (struct tui_source_window_base)
3135         <maybe_update>: Declare.
3136         * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
3137         method.
3138         * tui/tui-source.h (struct tui_source_window) <maybe_update>:
3139         Declare.
3140         * tui/tui-source.c (tui_source_window::maybe_update): New method.
3141         * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
3142         Declare.
3143         * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
3144
3145 2019-08-15  Tom Tromey  <tom@tromey.com>
3146
3147         * tui/tui-stack.c (tui_make_status_line): Use string constructor.
3148
3149 2019-08-15  Tom Tromey  <tom@tromey.com>
3150
3151         * tui/tui-wingeneral.c: Include tui-stack.h.
3152         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
3153         (struct tui_locator_window): Move from tui-data.h.
3154         * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
3155         (tui_initialize_static_data): Move from tui-data.c.
3156         * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
3157         (struct tui_locator_window): Move to tui-stack.c.
3158         * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
3159         (tui_initialize_static_data): Move to tui-stack.c.
3160
3161 2019-08-15  Tom Tromey  <tom@tromey.com>
3162
3163         * tui/tui-layout.c (show_source_disasm_command)
3164         (show_source_or_disasm_and_command): Use make_visible method, not
3165         tui_make_window.
3166         * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
3167         Remove.
3168
3169 2019-08-15  Tom Tromey  <tom@tromey.com>
3170
3171         * tui/tui-wingeneral.h (tui_make_window): Update.
3172         * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
3173         parameter.
3174         (tui_gen_win_info::make_visible): Update.
3175         * tui/tui-regs.c (tui_data_window::display_registers_from):
3176         Update.
3177         * tui/tui-layout.c (show_source_disasm_command)
3178         (show_source_or_disasm_and_command): Update.
3179         * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
3180         (enum tui_box): Remove.
3181         (struct tui_win_info) <can_box>: New method.
3182         * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
3183         method.
3184
3185 2019-08-15  Tom de Vries  <tdevries@suse.de>
3186
3187         * linux-nat-trad.c: Include gdbarch.h.
3188
3189 2019-08-14  Alan Hayward  <alan.hayward@arm.com>
3190
3191         * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
3192         register sizes.
3193
3194 2019-08-14  Tom Tromey  <tromey@adacore.com>
3195
3196         * darwin-nat.c: Include gdbarch.h.
3197         * darwin-nat-info.c: Include gdbarch.h.
3198
3199 2019-08-13  Tom Tromey  <tom@tromey.com>
3200
3201         * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
3202         Remove.
3203         * tui/tui-data.c (tui_initialize_static_data): Update.
3204
3205 2019-08-13  Tom Tromey  <tom@tromey.com>
3206
3207         * tui/tui-winsource.h (struct tui_exec_info_window)
3208         <~tui_exec_info_window, maybe_allocate_content, get_content,
3209         m_content>: Remove.
3210         (struct tui_source_window_base) <set_exec_info_content,
3211         show_exec_info_content>: Don't declare.
3212         * tui/tui-winsource.c
3213         (tui_exec_info_window::maybe_allocate_content): Remove.
3214         (tui_source_window_base::update_exec_info): Rename from
3215         set_exec_info_content.
3216         (tui_source_window_base::show_exec_info_content)
3217         (tui_source_window_base::update_exec_info): Remove.
3218
3219 2019-08-13  Tom Tromey  <tom@tromey.com>
3220
3221         * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
3222         declare.
3223         * tui/tui-winsource.c (tui_update_source_window_as_is)
3224         (tui_update_source_windows_with_addr, tui_erase_source_content):
3225         Update.
3226         (tui_clear_exec_info_content): Remove.
3227
3228 2019-08-13  Tom Tromey  <tom@tromey.com>
3229
3230         * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
3231         declare.
3232         * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
3233         call tui_erase_exec_info_content.
3234         (tui_clear_exec_info_content): Rename from
3235         tui_erase_exec_info_content.
3236         (tui_clear_exec_info_content): Delete.
3237
3238 2019-08-13  Tom Tromey  <tom@tromey.com>
3239
3240         * tui/tui-winsource.h (struct tui_source_window_base)
3241         <show_exec_info_content>: Declare.
3242         (tui_show_exec_info_content): Don't declare.
3243         * tui/tui-winsource.c
3244         (tui_source_window_base::show_exec_info_content): Rename from
3245         tui_show_exec_info_content.
3246         (tui_source_window_base::update_exec_info): Update.
3247
3248 2019-08-13  Tom Tromey  <tom@tromey.com>
3249
3250         * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
3251         (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
3252         (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
3253         * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
3254         tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
3255         (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
3256         ... here.
3257
3258 2019-08-13  Tom Tromey  <tom@tromey.com>
3259
3260         * tui/tui-winsource.h (struct tui_source_window_base)
3261         <update_exec_info>: Declare.
3262         (tui_update_exec_info): Don't declare.
3263         * tui/tui-winsource.c (tui_update_source_window_as_is)
3264         (tui_source_window_base::refresh_all)
3265         (tui_update_all_breakpoint_info): Update.
3266         (tui_source_window_base::update_exec_info): Rename from
3267         tui_update_exec_info.
3268         * tui/tui-stack.c (tui_show_frame_info): Update.
3269
3270 2019-08-13  Tom Tromey  <tom@tromey.com>
3271
3272         * tui/tui-winsource.h (struct tui_source_window_base)
3273         <set_exec_info_content>: Declare.
3274         (tui_set_exec_info_content): Don't declare.
3275         * tui/tui-winsource.c
3276         (tui_source_window_base::set_exec_info_content): Rename from
3277         tui_set_exec_info_content.
3278         (tui_update_exec_info): Update.
3279
3280 2019-08-13  Tom Tromey  <tom@tromey.com>
3281
3282         * tui/tui-winsource.h (struct tui_source_window_base)
3283         <show_source_content>: Declare.
3284         (tui_show_source_content): Don't declare.
3285         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
3286         (tui_source_window_base::show_source_content): Rename from
3287         tui_show_source_content.
3288         (tui_source_window_base::refresh_all): Update.
3289         * tui/tui-layout.c (show_source_disasm_command)
3290         (show_source_or_disasm_and_command): Update.
3291
3292 2019-08-13  Tom Tromey  <tom@tromey.com>
3293
3294         * tui/tui-winsource.c (tui_erase_source_content)
3295         (tui_show_source_content, tui_source_window_base::refresh_all):
3296         Update.
3297         * tui/tui-wingeneral.h
3298         (tui_check_and_display_highlight_if_needed): Don't declare.
3299         * tui/tui-wingeneral.c
3300         (tui_win_info::check_and_display_highlight_if_needed): Rename from
3301         check_and_display_highlight_if_needed.
3302         * tui/tui-win.c (tui_rehighlight_all)
3303         (tui_win_info::make_visible_with_new_height): Update.
3304         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
3305         (tui_data_window::erase_data_content)
3306         (tui_data_window::display_all_data): Update.
3307         * tui/tui-data.h (struct tui_win_info)
3308         <check_and_display_highlight_if_needed>: Declare.
3309
3310 2019-08-13  Tom Tromey  <tom@tromey.com>
3311
3312         * tui/tui-win.c (tui_resize_all): Call
3313         tui_delete_invisible_windows.
3314         * tui/tui-layout.c (show_layout): Call
3315         tui_delete_invisible_windows.
3316         * tui/tui-data.h (tui_delete_invisible_windows): Declare.
3317         * tui/tui-data.c (tui_delete_invisible_windows): New function.
3318
3319 2019-08-13  Tom Tromey  <tom@tromey.com>
3320
3321         * tui/tui-disasm.c (tui_show_disassem): Add assertion.  Don't call
3322         tui_add_win_to_layout.
3323
3324 2019-08-13  Tom Tromey  <tom@tromey.com>
3325
3326         * tui/tui-layout.h (tui_default_win_height): Don't declare.
3327         * tui/tui-layout.c (tui_default_win_height): Now static.
3328
3329 2019-08-13  Tom Tromey  <tom@tromey.com>
3330
3331         * tui/tui-layout.c (show_layout): Unify all layout cases into a
3332         single switch.
3333         (show_source_disasm_command, show_source_or_disasm_and_command):
3334         Don't check current layout.
3335
3336 2019-08-13  Tom Tromey  <tom@tromey.com>
3337
3338         * tui/tui-wingeneral.c (make_all_visible): Remove.
3339         (tui_make_all_invisible): Simplify.
3340         * tui/tui-layout.c (tui_make_all_invisible): Move from
3341         tui-wingeneral.c; simplify.
3342         (show_layout): Hoist call to tui_make_all_invisible.
3343         (show_data): Don't call tui_make_all_invisible.
3344
3345 2019-08-13  Tom Tromey  <tom@tromey.com>
3346
3347         * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
3348         * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
3349
3350 2019-08-13  Tom Tromey  <tom@tromey.com>
3351
3352         * tui/tui-layout.c (current_layout, tui_current_layout): Move from
3353         tui-data.c.
3354         (show_source_disasm_command, show_data)
3355         (show_source_or_disasm_and_command): Don't use
3356         tui_set_current_layout_to.
3357         * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
3358         * tui/tui-data.c (current_layout, tui_current_layout): Move to
3359         tui-layout.c.
3360         (tui_set_current_layout_to): Remove.
3361
3362 2019-08-13  Tom Tromey  <tom@tromey.com>
3363
3364         * tui/tui-layout.c (tui_set_layout): Update.
3365         * tui/tui-data.h (struct tui_layout_def): Remove.
3366         (tui_layout_def): Don't declare.
3367         * tui/tui-data.c (layout_def): Remove.
3368         (tui_layout_def): Remove.
3369
3370 2019-08-13  Tom Tromey  <tom@tromey.com>
3371
3372         * tui/tui-winsource.h (struct tui_source_window_base)
3373         <clear_detail>: No longer "override".
3374         * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
3375         * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
3376         * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
3377         * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
3378         Remove.
3379         * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
3380
3381 2019-08-13  Tom Tromey  <tromey@adacore.com>
3382
3383         * tracepoint.c: Don't include readline.h or history.h.
3384
3385 2019-08-12  Tom Tromey  <tom@tromey.com>
3386
3387         * configure: Rebuild.
3388         * configure.ac: Check for readline 7.
3389         * NEWS: Mention readline 7 requirement.
3390         * README: Update.
3391
3392 2019-08-12  Tom Tromey  <tom@tromey.com>
3393
3394         * mingw-hdep.c (gdb_select): Remove readline hack.
3395
3396 2019-08-09  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
3397
3398         * blockframe.c (find_pc_partial_function): Set *block to nullptr
3399         when the function fails.
3400
3401 2019-08-09  Andreas Arnez  <arnez@linux.ibm.com>
3402
3403         * s390-tdep.c (s390_type_align): New function.
3404         (s390_gdbarch_init): Set it as type_align gdbarch method.
3405
3406 2019-08-09  Tom de Vries  <tdevries@suse.de>
3407
3408         PR gdb/24591
3409         * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
3410         pc_low with relocation offset.
3411
3412 2019-08-07  Tom Tromey  <tromey@adacore.com>
3413
3414         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
3415         (print_frame_args): Update.
3416         * python/py-framefilter.c (py_print_single_arg, enumerate_args):
3417         Update.
3418         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
3419         * frame.h (struct frame_arg): Add initializers.
3420         <error>: Now a unique_xmalloc_ptr.
3421
3422 2019-08-07  Alan Hayward  <alan.hayward@arm.com>
3423
3424         * NEWS: Expand the Pointer Authentication entry.
3425         * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
3426         (aarch64_frame_unmask_lr): ... to this.
3427         (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
3428         Call aarch64_frame_unmask_lr.
3429         * frame.c (struct frame_info): Add "masked" variable.
3430         (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
3431         (fprint_frame): Check for masked pc.
3432         * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
3433         declarations.
3434         * python/py-framefilter.c (py_print_frame): Check for masked pc.
3435         * stack.c (print_frame): Check for masked pc.
3436
3437 2019-08-06  Tom Tromey  <tom@tromey.com>
3438
3439         * stabsread.c (patch_block_stabs, read_one_struct_field)
3440         (read_enum_type): Use obstack_strndup.
3441         * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
3442         * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
3443         * dwarf2read.c (guess_full_die_structure_name)
3444         (anonymous_struct_prefix): Use obstack_strndup.
3445         * dbxread.c (cp_set_block_scope): Use obstack_strndup.
3446         * c-exp.y (yylex): Use obstack_strndup.
3447         * ada-exp.y (write_object_renaming, write_ambiguous_var)
3448         (write_var_or_type): Use obstack_strndup.
3449
3450 2019-08-06  Tom Tromey  <tom@tromey.com>
3451
3452         * symfile.c (reread_symbols): Use obstack_strdup.
3453         * stabsread.c (read_type): Use obstack_strdup.
3454         * gdb_obstack.h (obstack_strdup): New overload.
3455         * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
3456         (create_dwo_unit_in_dwp_v2, build_error_marker_type)
3457         (dwarf2_canonicalize_name): Use obstack_strdup.
3458         * dbxread.c (read_dbx_symtab): Use obstack_strdup.
3459         * cp-support.c (inspect_type, replace_typedefs_qualified_name):
3460         Use obstack_strdup.
3461
3462 2019-08-06  Tom Tromey  <tom@tromey.com>
3463
3464         * gdb_obstack.h (obstack_strdup): Define.
3465         * gdb_obstack.c (obstack_strdup): Don't define.
3466
3467 2019-08-06  Tom Tromey  <tom@tromey.com>
3468
3469         * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
3470         obstack_strdup.
3471         * typeprint.c (typedef_hash_table::find_global_typedef): Use
3472         obstack_strdup.
3473         * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
3474         * stabsread.c (common_block_start): Use obstack_strdup.
3475         * objfiles.c (set_objfile_main_name, objfile): Use
3476         obstack_strdup.
3477         * namespace.c (add_using_directive): Use obstack_strdup.
3478         * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
3479         * jit.c (finalize_symtab): Use obstack_strdup.
3480         * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
3481         (guess_partial_die_structure_name, partial_die_info::fixup)
3482         (dwarf2_name): Use obstack_strdup.
3483         * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
3484         obstack_strdup.
3485         * c-exp.y (scan_macro_expansion): Use obstack_strdup.
3486         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
3487         obstack_strdup.
3488         * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
3489
3490 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3491
3492         * unittests/help-doc-selftests.c: New file.
3493         * Makefile.in: Add the new file.
3494
3495 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3496
3497         * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
3498         * cli/cli-decode.c (print_doc_line): Likewise.  It now prints
3499         the full first line, except when FOR_VALUE_PREFIX.  In this case,
3500         the trailing '.' is not output, and the first character is uppercased.
3501         (print_help_for_command): Update call to print_doc_line.
3502         (print_doc_of_command): Likewise.
3503         * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
3504         * cli/cli-option.c (append_indented_doc): Do not append newline.
3505         (build_help_option): Append newline after first appended_indented_doc
3506         only if a second call is done.
3507         (build_help): Append 2 new lines before each option, except the first
3508         one.
3509         * compile/compile.c (_initialize_compile): Add new lines after
3510         %OPTIONS%, when not at the end of the help.
3511         Change help doc or code
3512         producing the help doc to respect the invariants.
3513         * maint-test-options.c (_initialize_maint_test_options): Likewise.
3514         Also removed the new line after 'Options:', as all other commands
3515         do not put an empty line between 'Options:' and the first option.
3516         * printcmd.c (_initialize_printcmd): Likewise.
3517         * stack.c (_initialize_stack): Likewise.
3518         * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
3519         incorrectly telling COMMAND is optional.
3520         * ada-lang.c (_initialize_ada_language): Change help doc or code
3521         producing the help doc to respect the invariants.
3522         * ada-tasks.c (_initialize_ada_tasks): Likewise.
3523         * breakpoint.c (_initialize_breakpoint): Likewise.
3524         * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
3525         * cli/cli-logging.c (_initialize_cli_logging): Likewise.
3526         * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
3527         * cli/cli-style.c (cli_style_option::add_setshow_commands,
3528         _initialize_cli_style): Likewise.
3529         * corelow.c (core_target_info): Likewise.
3530         * dwarf-index-cache.c (_initialize_index_cache): Likewise.
3531         * dwarf2read.c (_initialize_dwarf2_read): Likewise.
3532         * filesystem.c (_initialize_filesystem): Likewise.
3533         * frame.c (_initialize_frame): Likewise.
3534         * gnu-nat.c (add_task_commands): Likewise.
3535         * infcall.c (_initialize_infcall): Likewise.
3536         * infcmd.c (_initialize_infcmd): Likewise.
3537         * interps.c (_initialize_interpreter): Likewise.
3538         * language.c (_initialize_language): Likewise.
3539         * linux-fork.c (_initialize_linux_fork): Likewise.
3540         * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
3541         * maint.c (_initialize_maint_cmds): Likewise.
3542         * memattr.c (_initialize_mem): Likewise.
3543         * printcmd.c (_initialize_printcmd): Likewise.
3544         * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
3545         _RegEx): Likewise.
3546         * ravenscar-thread.c (_initialize_ravenscar): Likewise.
3547         * record-btrace.c (_initialize_record_btrace): Likewise.
3548         * record-full.c (_initialize_record_full): Likewise.
3549         * record.c (_initialize_record): Likewise.
3550         * regcache-dump.c (_initialize_regcache_dump): Likewise.
3551         * regcache.c (_initialize_regcache): Likewise.
3552         * remote.c (add_packet_config_cmd, init_remote_threadtests,
3553         _initialize_remote): Likewise.
3554         * ser-tcp.c (_initialize_ser_tcp): Likewise.
3555         * serial.c (_initialize_serial): Likewise.
3556         * skip.c (_initialize_step_skip): Likewise.
3557         * source.c (_initialize_source): Likewise.
3558         * stack.c (_initialize_stack): Likewise.
3559         * symfile.c (_initialize_symfile): Likewise.
3560         * symtab.c (_initialize_symtab): Likewise.
3561         * target-descriptions.c (_initialize_target_descriptions): Likewise.
3562         * top.c (init_main): Likewise.
3563         * tracefile-tfile.c (tfile_target_info): Likewise.
3564         * tracepoint.c (_initialize_tracepoint): Likewise.
3565         * tui/tui-win.c (_initialize_tui_win): Likewise.
3566         * utils.c (add_internal_problem_command): Likewise.
3567         * valprint.c (value_print_option_defs): Likewise.
3568
3569 2019-08-06  Frank Ch. Eigler  <fche@redhat.com>
3570
3571         PR build/24886
3572         * configure.ac: Drop enable-libmcheck support.
3573         * configure, config.in: Rebuild.
3574         * libmcheck.m4: Remove.
3575         * acinclude.m4: Don't include it.
3576         * Makefile.in: Don't distribute it.
3577         * top.c (print_gdb_configuration): Don't mention it.
3578
3579 2019-08-06  Tom Tromey  <tom@tromey.com>
3580
3581         * utils.c (set_output_style): Sometimes pass stream to
3582         emit_style_escape.
3583         * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
3584         * record-btrace.c (btrace_insn_history): Update.
3585         * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
3586         method.
3587         * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
3588         Update initializers.
3589         <m_uiout>: New field.
3590         <m_di>: Move lower.
3591         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
3592         Remove "uiout" parameter.
3593         (dump_insns): Update.
3594         * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
3595         * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
3596
3597 2019-08-06  Christian Biesinger  <cbiesinger@google.com>
3598
3599         * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
3600         (error_in_psymtab_expansion): Likewise.
3601         (lookup_symbol_via_quick_fns): Likewise.
3602         (basic_lookup_transparent_type_quick): Likewise.
3603         (basic_lookup_transparent_type_1): Likewise.
3604
3605 2019-08-06  Tom Tromey  <tromey@adacore.com>
3606
3607         * source.c (last_source_error): Now bool.
3608         (print_source_lines_base): Make "noprint" bool.  Only open
3609         source file when last_source_visited changes.
3610
3611 2019-08-06  Tom Tromey  <tromey@adacore.com>
3612
3613         * annotate.c (annotate_source_line): Use g_source_cache.
3614         * source-cache.c (source_cache::get_plain_source_lines): Change
3615         parameters.  Populate m_offset_cache.
3616         (source_cache::ensure): New method.
3617         (source_cache::get_line_charpos): New method.
3618         (extract_lines): Move lower.  Change parameters.
3619         (source_cache::get_source_lines): Move lower.
3620         * source-cache.h (class source_cache): Update comment.
3621         <get_line_charpos>: New method.
3622         <get_source_lines>: Update comment.
3623         <clear>: Clear m_offset_cache.
3624         <get_plain_source_lines>: Change parameters.
3625         <ensure>: New method
3626         <m_offset_cache>: New member.
3627         * source.c (forget_cached_source_info_for_objfile): Update.
3628         (info_source_command): Use g_source_cache.
3629         (find_source_lines, open_source_file_with_line_charpos): Remove.
3630         (print_source_lines_base, search_command_helper): Use g_source_cache.
3631         * source.h (open_source_file_with_line_charpos): Don't declare.
3632         * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
3633         * tui/tui-source.c (tui_source_window::do_scroll_vertical):
3634         Use g_source_cache.
3635
3636 2019-08-06  Tom Tromey  <tromey@adacore.com>
3637
3638         * source-cache.c (source_cache::get_plain_source_lines):
3639         Remove "first_line" and "last_line" parameters.
3640         (source_cache::get_source_lines): Cache plain text.
3641         * source-cache.h (class source_cache)
3642         <get_plain_source_lines>: Update.
3643
3644 2019-08-06  Tom Tromey  <tromey@adacore.com>
3645
3646         * source-cache.c (extract_lines): No longer a method.
3647         Changed type of parameter.  Include final newline.
3648         (selftests::extract_lines_test): New function.
3649         (_initialize_source_cache): Likewise.
3650         * source-cache.h (class source_cache)
3651         <extract_lines>: Don't declare.
3652
3653 2019-08-06  Tom Tromey  <tromey@adacore.com>
3654
3655         * breakpoint.c (init_breakpoint_sal): Update.
3656         (breakpoint): Update.
3657         * breakpoint.h (struct breakpoint) <filter>: Now a
3658         unique_xmalloc_ptr.
3659
3660 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
3661
3662         * NEWS: Mention dictionary access on blocks.
3663         * python/py-block.c (blpy_getitem): New function.
3664         (block_object_as_mapping): New struct.
3665         (block_object_type): Use new struct for tp_as_mapping field.
3666
3667 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
3668
3669         * objfiles.h (objfile): Add a comment describing partial symbols.
3670
3671 2019-08-05  Tom Tromey  <tromey@adacore.com>
3672
3673         * compile/compile.c (_initialize_compile): Use _(), not N_().
3674         * thread.c (_initialize_thread): Use _(), not N_().
3675         * stack.c (_initialize_stack): Use _(), not N_().
3676         * printcmd.c (_initialize_printcmd): Use _(), not N_().
3677
3678 2019-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
3679
3680         * dwarf2read.c (struct dw2_symtab_iterator):
3681         <want_specific_block>: Remove.
3682         <block_index>: Change type to gdb::optional.
3683         (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
3684         change type of BLOCK_INDEX parameter to gdb::optional.
3685         (dw2_symtab_iter_next): Re-write in function of gdb::optional.
3686         (dw2_lookup_symbol): Don't pass argument for
3687         WANT_SPECIFIC_BLOCK.
3688         (dw2_expand_symtabs_for_function): Don't pass argument for
3689         WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
3690         (class dw2_debug_names_iterator)
3691         <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
3692         parameter, change BLOCK_INDEX type to gdb::optional.
3693         <m_want_specific_block>: Remove.
3694         <m_block_index>: Change type to gdb::optional.
3695         (dw2_debug_names_iterator::next): Change type of IS_STATIC to
3696         gdb::optional.  Re-write in function of gdb::optional.
3697         (dw2_debug_names_lookup_symbol): Don't pass argument for
3698         WANT_SPECIFIC_BLOCK.
3699         (dw2_debug_names_expand_symtabs_for_function): Don't pass
3700         argument for WANT_SPECIFIC_BLOCK, pass empty optional for
3701         BLOCK_INDEX.
3702
3703 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3704
3705         * NEWS: Mention changes to "info sources" command.
3706
3707 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3708
3709         * symtab.c (filename_partial_match_opts): New struct type.
3710         (struct output_source_filename_data): New members
3711         regexp, c_regexp, partial_match.
3712         (output_source_filename): Use new members to decide to print file.
3713         (info_sources_option_defs): New variable.
3714         (make_info_sources_options_def_group, print_info_sources_header,
3715         info_sources_command_completer):
3716         New functions.
3717         (info_sources_command): Read new optional arguments.
3718         (_initialize_symtab): Update info sources help.
3719
3720 2019-08-02  Alexandre Oliva <oliva@adacore.com>
3721
3722         * ada-lang.c (exception_support_info_v0): Renamed from...
3723         (default_exception_support_info): ... this.  Create new
3724         definition for v1.
3725         (ada_has_this_exception_support): Look up catch_handlers_sym.
3726         (ada_exception_support_info_sniffer): Try v0 after default.
3727
3728 2019-08-01  Tom Tromey  <tromey@adacore.com>
3729
3730         * ia64-libunwind-tdep.h (struct libunwind_descr): Include
3731         gdbarch.h.
3732
3733 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
3734
3735         * s12z-tdep.c: Fix include path for s12z-opc.h.
3736
3737 2019-08-01  Alan Hayward  <alan.hayward@arm.com>
3738
3739         * NEWS: Require GNU make 3.82.
3740
3741 2019-07-16  Tom Tromey  <tom@tromey.com>
3742
3743         * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
3744         declare.
3745
3746 2019-07-30  Tom Tromey  <tromey@adacore.com>
3747
3748         * block.c (contained_in): Remove BLOCK_FUNCTION check.
3749
3750 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
3751
3752         * printcmd.c (print_address_symbolic): Print negative offsets.
3753         (build_address_symbolic): Force signed arithmetic when computing
3754         offset.
3755
3756 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
3757
3758         PR/24474: Add a function to lookup static variables.
3759         * NEWS: Mention this new function.
3760         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
3761         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
3762         * python/python.c (python_GdbMethods): Add new function.
3763
3764 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
3765
3766         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
3767         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
3768         (objfpy_lookup_static_symbol): New function.
3769         (objfile_object_methods): Add new functions.
3770
3771 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3772
3773         * NEWS: Mention 'set|show print frame-info'.  Mention new
3774         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
3775         backtrace argument.  Mention that python frame filtering code
3776         is now consistent with what 'backtrace' command prints.
3777
3778 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3779
3780         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
3781         comments.
3782         (print_frame_info_auto, print_frame_info_source_line,
3783         print_frame_info_location, print_frame_info_source_and_location,
3784         print_frame_info_location_and_address, print_frame_info_short_location):
3785         New declarations.
3786         (struct frame_print_options): New member print_frame_info.
3787         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
3788         * stack.h (get_user_print_what_frame_info): New declaration.
3789         (frame_show_address): New declaration.
3790         * stack.c (print_frame_arguments_choices): New value 'presence'.
3791         (print_frame_info_auto, print_frame_info_source_line,
3792         print_frame_info_location, print_frame_info_source_and_location,
3793         print_frame_info_location_and_address, print_frame_info_short_location,
3794         print_frame_info_choices, print_frame_info_print_what): New definitions.
3795         (print_frame_args): Only print dots for args if print frame-arguments
3796         is 'presence'.
3797         (frame_print_option_defs): New element for "frame-info".
3798         (get_user_print_what_frame_info): New function.
3799         (frame_show_address): Make non static.  Move comment to stack.h.
3800         (print_frame_info_to_print_what): New function.
3801         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
3802         to decide what to print.
3803         (backtrace_command_1): Handle the new print_frame_arguments_presence
3804         value.
3805         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
3806         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
3807         (py_print_frame): In non-mi mode, use LOCATION as default for
3808         print_what, similarly to frame information printed directly by
3809         backtrace command. Handle frame-info user option in non MI mode.
3810
3811 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
3812
3813         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
3814         Add case for debugging 32-bit target on 64-bit host.  Revise
3815         comment.
3816
3817 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
3818
3819         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
3820         instead of find_function_entry_range_from_pc.
3821
3822 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
3823
3824         * stack.c (find_frame_funname): Remove code which preferred
3825         minsym over symtab sym in "certain pathological cases".
3826
3827         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
3828         parameter.  Change type of "do_demangle" to bool.
3829         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
3830         Pass suitable "prefer_sym_over_minsym" flag to
3831         build_address_symbolic().  Don't output "+" for negative offsets.
3832         * printcmd.c (print_address_symbolic): Update invocation of
3833         build_address_symbolic to include a "prefer_sym_over_minsym"
3834         flag.
3835         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
3836         Restrict cases in which use of minimal symbol is preferred to that
3837         of a found symbol.  Update comments.
3838
3839         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
3840         for entry pc when entry pc is out of range for that FDE.
3841
3842 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
3843
3844         PR gdb/24839:
3845         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
3846         type.
3847
3848 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
3849
3850         * python/py-objfile.c (add_separate_debug_file): Fix comment about
3851         this function's Python signature.
3852
3853
3854 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
3855
3856         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
3857         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
3858         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
3859         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
3860         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
3861
3862
3863 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
3864
3865         * h8300-tdep.c (h8300_register_name_common): New.
3866         h8300_register_name): Use h8300_register_name_common.
3867         (h8300s_register_name): Likewise.
3868         (h8300sx_register_name): Likewise.
3869         (h8300h_register_nam): New.
3870         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
3871
3872
3873 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
3874
3875         * arm-tdep.c (arm_skip_cmse_entry): New function.
3876         (arm_is_sgstubs_section): New function.
3877         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
3878
3879 2019-07-22  Tom Tromey  <tom@tromey.com>
3880
3881         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
3882         Don't self-assign.
3883
3884 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
3885
3886         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
3887         type_print.
3888
3889 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
3890
3891         * symtab.c (search_symbols): Adjust msymbol matching type arrays
3892         so that GDB doesn't match any msymbols when searching in the
3893         TYPES_DOMAIN.
3894         (print_symbol_info): Print using typedef_print or type_print based
3895         on the type of the symbol.  Add updated FIXME comment moved from...
3896         (_initialize_symtab): ... move and update FIXME comment to above.
3897
3898 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
3899
3900         * NEWS: Mention adding -q option to "info types".
3901         * symtab.c (struct info_types_options): New struct.
3902         (info_types_options_defs): New variable.
3903         (make_info_types_options_def_group): New function.
3904         (info_types_command): Use gdb::option framework to parse options.
3905         (info_types_command_completer): New function.
3906         (_initialize_symtab): Extend the help text on "info types" and
3907         register command completer.
3908
3909 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
3910
3911         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
3912         (lookup_symbol_in_objfile): Change int to block_enum and add a
3913         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
3914
3915 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
3916
3917         * MAINTAINERS (Write After Approval): Add self.
3918
3919 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
3920
3921         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
3922         instruction to the dummy code region.
3923
3924 2019-07-19  Tom Tromey  <tromey@adacore.com>
3925
3926         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
3927         (ARGSUSED, PARAMS, __func__): Remove rules.
3928
3929 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
3930
3931         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
3932         * features/arm/arm-with-iwmmxt.c: Remove.
3933         * features/arm/arm-with-iwmmxt.xml: Remove.
3934         * features/arm/arm-with-m-fpa-layout.c: Remove.
3935         * features/arm/arm-with-m-fpa-layout.xml: Remove.
3936         * features/arm/arm-with-m-vfp-d16.c: Remove.
3937         * features/arm/arm-with-m-vfp-d16.xml: Remove.
3938         * features/arm/arm-with-m.c: Remove.
3939         * features/arm/arm-with-m.xml: Remove.
3940         * features/arm/arm-with-neon.c: Remove.
3941         * features/arm/arm-with-neon.xml: Remove.
3942         * features/arm/arm-with-vfpv2.c: Remove.
3943         * features/arm/arm-with-vfpv2.xml: Remove.
3944         * features/arm/arm-with-vfpv3.c: Remove.
3945         * features/arm/arm-with-vfpv3.xml: Remove.
3946
3947 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
3948
3949         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
3950
3951 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
3952
3953         * arch/aarch32.c (aarch32_create_target_description): Create
3954         target descriptions using features.
3955         * arch/arm.c (arm_create_target_description)
3956         (arm_create_mprofile_target_description): Likewise.
3957         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
3958
3959 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
3960
3961         * Makefile.in: Add new files.
3962         * aarch32-tdep.c: New file.
3963         * aarch32-tdep.h: New file.
3964         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
3965         Call aarch32_read_description.
3966         * arch/aarch32.c: New file.
3967         * arch/aarch32.h: New file.
3968         * arch/arm.c (arm_create_target_description)
3969         (arm_create_mprofile_target_description): New function.
3970         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
3971         (arm_create_target_description)
3972         (arm_create_mprofile_target_description): New declaration.
3973         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
3974         read_description functions.
3975         * arm-linux-nat.c (arm_linux_nat_target::read_description):
3976         Likewise.
3977         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
3978         * arm-tdep.c (tdesc_arm_list): New variable.
3979         (arm_register_g_packet_guesses): Call create description functions.
3980         (arm_read_description) (arm_read_mprofile_description): New
3981         function.
3982         * arm-tdep.h (arm_read_description)
3983         (arm_read_mprofile_description): Add declaration.
3984         * configure.tgt: Add new files.
3985
3986 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
3987
3988         * top.c (new_ui_command): Open specified terminal just once.
3989
3990 2019-07-18  Tom Tromey  <tromey@adacore.com>
3991
3992         * symtab.c (main_name): Constify return type.
3993         * symfile.c (set_initial_language): Update.
3994         * symtab.h (main_name): Constify return type.
3995
3996 2019-07-17  Tom Tromey  <tom@tromey.com>
3997
3998         * tui/tui-winsource.c (tui_update_source_window)
3999         (tui_update_source_window_as_is)
4000         (tui_update_source_windows_with_line): Remove return.
4001         * tui/tui-disasm.c (tui_show_disassem)
4002         (tui_show_disassem_and_update_source): Remove return.
4003         * tui/tui.c (tui_reset): Remove return.
4004         * tui/tui-wingeneral.c
4005         (tui_check_and_display_highlight_if_needed): Remove return.
4006
4007 2019-07-17  Tom Tromey  <tom@tromey.com>
4008
4009         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
4010
4011 2019-07-17  Tom Tromey  <tom@tromey.com>
4012
4013         * tui/tui-winsource.h (struct tui_exec_info_window)
4014         (struct tui_source_window_base): Move from tui-data.h.
4015         * tui/tui-winsource.c: Move many method definitions from
4016         elsewhere.  Remove "structuring" comments.
4017         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
4018         (tui_source_window_base::refresh_window): Move to
4019         tui-winsource.c.
4020         * tui/tui-win.c (tui_source_window_base::refresh_all)
4021         (tui_source_window_base::update_tab_width)
4022         (tui_source_window_base::set_new_height)
4023         (tui_source_window_base::do_make_visible_with_new_height): Move to
4024         tui-winsource.c.
4025         * tui/tui-source.h: Update.
4026         * tui/tui-source.c (tui_source_window_base::reset): Move to
4027         tui-winsource.c.
4028         * tui/tui-disasm.h: Update.
4029         * tui/tui-data.h (struct tui_exec_info_window): Move to
4030         tui-winsource.h.
4031         (struct tui_source_window_base): Likewise.
4032         * tui/tui-data.c (tui_source_window_base::clear_detail)
4033         (tui_source_window_base, ~tui_source_window_base): Move to
4034         tui-winsource.c.
4035
4036 2019-07-17  Tom Tromey  <tom@tromey.com>
4037
4038         * tui/tui-win.c (tui_resize_all)
4039         (tui_source_window_base::update_tab_width)
4040         (tui_adjust_win_heights): Update.
4041         (tui_win_info::make_invisible_and_set_new_height): Rename from
4042         make_invisible_and_set_new_height.
4043         * tui/tui-data.h (struct tui_win_info)
4044         <make_invisible_and_set_new_height>: New method.
4045
4046 2019-07-17  Tom Tromey  <tom@tromey.com>
4047
4048         * tui/tui.c: Update.
4049         * tui/tui-source.h (struct tui_source_window): Move from
4050         tui-data.h.
4051         * tui/tui-layout.c: Update.
4052         * tui/tui-disasm.c: Update.
4053         * tui/tui-data.h (struct tui_source_window): Move to
4054         tui-source.h.
4055
4056 2019-07-17  Tom Tromey  <tom@tromey.com>
4057
4058         * tui/tui-disasm.h (struct tui_disasm_window): Move from
4059         tui-data.h.
4060         * tui/tui-data.h (struct tui_disasm_window): Move to
4061         tui-disasm.h.
4062
4063 2019-07-17  Tom Tromey  <tom@tromey.com>
4064
4065         * tui/tui-regs.h (struct tui_data_item_window): Move from
4066         tui-data.h.
4067         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
4068         * tui/tui-data.h (struct tui_data_item_window): Move to
4069         tui-regs.h.
4070         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
4071
4072 2019-07-17  Tom Tromey  <tom@tromey.com>
4073
4074         * tui/tui.c: Update.
4075         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
4076         (tui_cmd_window::max_height): Move to tui-command.c.
4077         * tui/tui-layout.c: Update.
4078         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
4079         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
4080         tui-command.c.
4081         * tui/tui-command.h (struct tui_cmd_window): Move from
4082         tui-data.h.
4083         * tui/tui-command.c: Remove "structuring" comments.
4084         (tui_cmd_window::clear_detail)
4085         (tui_cmd_window::do_make_visible_with_new_height)
4086         (tui_cmd_window::max_height): Move from elsewhere.
4087
4088 2019-07-17  Tom Tromey  <tom@tromey.com>
4089
4090         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
4091         Now static.
4092         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
4093         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
4094
4095 2019-07-17  Tom Tromey  <tom@tromey.com>
4096
4097         * tui/tui.c: Update.
4098         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
4099         tui-regs.c.
4100         * tui/tui-windata.h: Remove file.
4101         * tui/tui-windata.c: Remove file.
4102         * tui/tui-win.c (tui_data_window::set_new_height)
4103         (tui_data_window::do_make_visible_with_new_height): Move to
4104         tui-regs.c.
4105         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
4106         * tui/tui-regs.c: Remove "structuring" comments.
4107         (tui_data_window::first_data_item_displayed)
4108         (tui_data_window::delete_data_content_windows)
4109         (tui_data_window::erase_data_content)
4110         (tui_data_window::display_all_data)
4111         (tui_data_window::refresh_all)
4112         (tui_data_window::do_scroll_vertical)
4113         (tui_data_window::clear_detail, tui_data_window::set_new_height)
4114         (tui_data_window::do_make_visible_with_new_height)
4115         (tui_data_window::refresh_window): Move from elsewhere.
4116         (_initialize_tui_regs): Move to end of file.
4117         * tui/tui-layout.c: Update.
4118         * tui/tui-hooks.c: Update.
4119         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
4120         * tui/tui-data.c (tui_data_window::clear_detail): Move to
4121         tui-regs.c.
4122         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
4123
4124 2019-07-17  Tom Tromey  <tom@tromey.com>
4125
4126         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
4127         seen.
4128
4129 2019-07-17  Tom Tromey  <tom@tromey.com>
4130
4131         * tui/tui-win.c (tui_source_window_base::set_new_height)
4132         (tui_source_window_base::do_make_visible_with_new_height): Use
4133         m_has_locator field directly.
4134         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
4135         method.
4136         (struct tui_source_window_base) <has_locator>: Likewise.
4137
4138 2019-07-17  Tom Tromey  <tom@tromey.com>
4139
4140         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
4141         Don't declare.
4142         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
4143         Remove.
4144         * tui/tui-win.c (tui_source_window_base::set_new_height)
4145         (tui_source_window_base::set_new_height)
4146         (make_invisible_and_set_new_height)
4147         (tui_source_window_base::do_make_visible_with_new_height)
4148         (tui_source_window_base::do_make_visible_with_new_height):
4149         Update.
4150         * tui/tui-layout.c (show_source_disasm_command, show_data)
4151         (show_source_or_disasm_and_command): Update.
4152         * tui/tui-layout.c (show_layout): Update.
4153
4154 2019-07-17  Tom Tromey  <tom@tromey.com>
4155
4156         * tui/tui-layout.c (make_data_window): Remove.
4157         (show_data): Unify creation and re-initialization cases.
4158
4159 2019-07-17  Tom Tromey  <tom@tromey.com>
4160
4161         * tui/tui-layout.c (make_source_window, make_disasm_window):
4162         Remove.
4163         (show_data): Unify creation and re-initialization cases.
4164
4165 2019-07-17  Tom Tromey  <tom@tromey.com>
4166
4167         * tui/tui-layout.c (make_command_window): Remove.
4168         (show_source_disasm_command, show_source_or_disasm_and_command):
4169         Unify creation and re-initialization cases.
4170
4171 2019-07-17  Tom Tromey  <tom@tromey.com>
4172
4173         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
4174         creation and re-initialization cases.
4175
4176 2019-07-17  Tom Tromey  <tom@tromey.com>
4177
4178         * tui/tui-regs.c (tui_get_register): Return void.
4179
4180 2019-07-17  Tom Tromey  <tom@tromey.com>
4181
4182         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
4183         Simplify.
4184
4185 2019-07-17  Tom Tromey  <tom@tromey.com>
4186
4187         * tui/tui-layout.c (show_source_disasm_command): Simplify window
4188         resetting.
4189
4190 2019-07-17  Tom Tromey  <tom@tromey.com>
4191
4192         * tui/tui.h (tui_set_layout_by_name): Don't declare.
4193         * tui/tui-regs.c (tui_reg_layout): New function.
4194         (tui_show_registers, tui_reg_command): Use it.
4195         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
4196         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
4197         parameters.
4198         (tui_layout_command): Remove.
4199
4200 2019-07-17  Tom Tromey  <tom@tromey.com>
4201
4202         * tui/tui-layout.h (tui/tui-layout): Return void.
4203         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
4204
4205 2019-07-17  Tom Tromey  <tom@tromey.com>
4206
4207         * tui/tui-layout.c (show_source_disasm_command, show_data):
4208         Update.
4209         (reset_locator): Remove.
4210         (show_source_or_disasm_and_command): Update.
4211
4212 2019-07-17  Tom Tromey  <tom@tromey.com>
4213
4214         * tui/tui-source.c (tui_source_window_base::reset): Remove
4215         win_type parameter.
4216         * tui/tui-layout.c (make_command_window, make_source_window)
4217         (make_disasm_window, make_data_window)
4218         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
4219         (reset_locator, show_source_or_disasm_and_command): Update.
4220         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
4221         win_type parameter.
4222         (struct tui_source_window_base) <reset>: Likewise.
4223
4224 2019-07-17  Tom Tromey  <tom@tromey.com>
4225
4226         * tui/tui-layout.c (show_source_disasm_command): Use
4227         reset_locator.
4228         (reset_locator): New function.
4229         (init_and_make_win): Remove.
4230         (show_source_or_disasm_and_command): Use reset_locator.
4231
4232 2019-07-17  Tom Tromey  <tom@tromey.com>
4233
4234         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
4235         condition.
4236         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
4237         Remove condition.
4238         * tui/tui-source.c (tui_source_window_base::reset): New method.
4239         * tui/tui-layout.c (make_command_window): Don't call
4240         init_and_make_win.
4241         (make_source_window, make_disasm_window): Don't call
4242         make_source_or_disasm_window.
4243         (make_data_window): Don't call init_and_make_win.  Change calling
4244         convention.
4245         (show_source_disasm_command, show_data): Simplify.
4246         (make_source_or_disasm_window): Remove.
4247         (show_source_or_disasm_and_command): Simplify.
4248         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
4249         (struct tui_source_window_base) <reset>: Likewise.
4250         <execution_info>: Remove initializer.
4251         * tui/tui-data.c (tui_source_window_base): Initialize
4252         execution_info.
4253
4254 2019-07-17  Tom Tromey  <tom@tromey.com>
4255
4256         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
4257         variable.
4258
4259 2019-07-17  Tom Tromey  <tom@tromey.com>
4260
4261         * tui/tui.c (tui_rl_other_window): Update.
4262         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
4263         superclass method first.  Always iterate over regs_content.
4264         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
4265         method.
4266         * tui/tui-win.c (tui_set_focus_command): Update.
4267
4268 2019-07-17  Tom Tromey  <tom@tromey.com>
4269
4270         * tui/tui-win.c (tui_set_focus_command): Rename from
4271         tui_set_focus.  Call tui_enable.
4272         (tui_set_focus_command): Remove.
4273
4274 2019-07-17  Tom Tromey  <tom@tromey.com>
4275
4276         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
4277         refresh_window.
4278         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
4279         touchwin.
4280         (tui_data_window::refresh_window): Call refresh_window on data
4281         items.  Always call superclass refresh_window.
4282         (tui_win_info::refresh): Remove.
4283         (tui_source_window_base::refresh_window): Update.
4284         (tui_refresh_all): Update.
4285         * tui/tui-layout.c (show_source_disasm_command): Remove call to
4286         refresh_window.
4287         (show_source_or_disasm_and_command): Likewise.
4288         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
4289         (struct tui_source_window_base) <refresh>: Likewise.
4290
4291 2019-07-17  Tom Tromey  <tom@tromey.com>
4292
4293         * tui/tui-winsource.c (tui_clear_source_content)
4294         (tui_show_source_content): Update.
4295         * tui/tui-source.c (tui_source_window::showing_source_p): Check
4296         whether content is empty.
4297         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
4298         Remove.
4299
4300 2019-07-17  Tom Tromey  <tom@tromey.com>
4301
4302         * tui/tui-winsource.c (tui_erase_source_content): Clear the
4303         window's contents.
4304         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
4305         * tui/tui-source.c (tui_set_source_content_nil): Remove.
4306
4307 2019-07-17  Tom Tromey  <tom@tromey.com>
4308
4309         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
4310         (struct tui_data_item_window): Update.
4311
4312 2019-07-17  Tom Tromey  <tom@tromey.com>
4313
4314         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
4315         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
4316         defines.
4317
4318 2019-07-17  Tom Tromey  <tom@tromey.com>
4319
4320         * tui/tui-winsource.h (tui_erase_source_content)
4321         (tui_clear_source_content): Remove "display_prompt" parameter.
4322         * tui/tui-winsource.c (tui_update_source_window_as_is)
4323         (tui_update_source_windows_with_addr): Update.
4324         (tui_clear_source_content): Remove "display_prompt" parameter.
4325         (tui_erase_source_content): Likewise.  Simplify.
4326         (tui_show_source_content): Update.
4327         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
4328         * tui/tui-stack.c (tui_show_frame_info): Update.
4329         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
4330         Remove defines.
4331
4332 2019-07-17  Tom Tromey  <tom@tromey.com>
4333
4334         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
4335         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
4336         parameter.
4337         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
4338         parameter.
4339
4340 2019-07-17  Tom Tromey  <tom@tromey.com>
4341
4342         * tui/tui-winsource.c (tui_clear_source_content)
4343         (tui_show_source_content, tui_show_exec_info_content)
4344         (tui_clear_exec_info_content): Update.
4345         * tui/tui-stack.c (tui_show_locator_content): Update.
4346         (tui_show_frame_info): Update.
4347         * tui/tui-source.h (tui_source_window): Don't declare.
4348         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
4349         from tui_source_is_displayed.
4350         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
4351         Remove field.
4352         (struct tui_source_window_base) <content_in_use>: New field.  Now
4353         bool.
4354         (struct tui_source_window) <showing_source_p>: New method.
4355         (TUI_SRC_WIN): Change cast.
4356         * tui/tui-data.c (tui_initialize_static_data): Update.
4357
4358 2019-07-17  Tom Tromey  <tom@tromey.com>
4359
4360         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
4361         location_matches_p.
4362         * tui/tui-source.c (tui_source_window::location_matches_p): New
4363         method.
4364         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
4365         method.
4366         * tui/tui-data.h (struct tui_source_window_base)
4367         <location_matches_p>: New method.
4368         (struct tui_source_window, struct tui_disasm_window)
4369         <location_matches_p>: Likewise.
4370
4371 2019-07-17  Tom Tromey  <tom@tromey.com>
4372
4373         * tui/tui-win.c (tui_set_win_height_command): Rename from
4374         tui_set_win_height.
4375         (tui_set_win_height_command): Remove.
4376
4377 2019-07-17  Tom Tromey  <tom@tromey.com>
4378
4379         * tui/tui-source.c (tui_source_window): New constructor.  Add
4380         observer.
4381         (~tui_source_window): New destructor.
4382         (tui_source_window::style_changed): New method.
4383         * tui/tui-hooks.c (tui_redisplay_source): Remove.
4384         (tui_attach_detach_observers): Update.
4385         * tui/tui-data.h (struct tui_source_window): Make constructor not
4386         inline.  Add destructor.
4387         (struct tui_source_window) <style_changed>: New method.
4388         <m_observable>: New member.
4389
4390 2019-07-17  Tom Tromey  <tom@tromey.com>
4391
4392         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
4393         * tui/tui-win.c (tui_resize_all): Fix typo.
4394
4395 2019-07-17  Tom Tromey  <tom@tromey.com>
4396
4397         * tui/tui-wingeneral.h (tui_refresh_all): Update.
4398         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
4399         (tui_refresh_all): Remove "list" parameter.  Use foreach.
4400         * tui/tui-win.c (window_name_completer): Use foreach.
4401         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
4402         (update_tab_width): Likewise.
4403         * tui/tui-layout.c (show_layout): Update.
4404         * tui/tui-data.h (class tui_window_iterator): New.
4405         (struct all_tui_windows): New.
4406         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
4407
4408 2019-07-17  Tom Tromey  <tom@tromey.com>
4409
4410         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
4411         parameter.  Don't reference globals.
4412         (tui_reg_command): Update.
4413
4414 2019-07-17  Tom Tromey  <tom@tromey.com>
4415
4416         * tui/tui-regs.c (tui_show_registers): Simplify.
4417
4418 2019-07-17  Tom Tromey  <tom@tromey.com>
4419
4420         * tui/tui-regs.c (tui_show_registers): Update.
4421         (tui_show_register_group): Add win_info parameter.
4422
4423 2019-07-17  Tom Tromey  <tom@tromey.com>
4424
4425         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
4426         Rename from tui_display_reg_element_at_line.
4427         (tui_data_window::display_registers_from_line): Update.
4428         * tui/tui-data.h (struct tui_data_window)
4429         <display_reg_element_at_line>: New method.
4430
4431 2019-07-17  Tom Tromey  <tom@tromey.com>
4432
4433         * tui/tui-regs.h (tui_display_registers_from)
4434         (tui_display_registers_from_line): Don't declare.
4435         * tui/tui-windata.c (tui_data_window::display_all_data)
4436         (tui_data_window::refresh_all)
4437         (tui_data_window::do_scroll_vertical): Update.
4438         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
4439         from tui_display_registers_from.
4440         (tui_display_reg_element_at_line): Update.
4441         (tui_data_window::display_registers_from_line): Rename from
4442         tui_display_registers_from_line.
4443         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
4444         display_registers_from_line>: New methods.
4445
4446 2019-07-17  Tom Tromey  <tom@tromey.com>
4447
4448         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
4449         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
4450         from tui_erase_data_content.
4451         (tui_data_window::display_all_data)
4452         (tui_data_window::refresh_all)
4453         (tui_data_window::do_scroll_vertical): Update.
4454         * tui/tui-regs.c (tui_show_registers): Update.
4455         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
4456         New method.
4457
4458 2019-07-17  Tom Tromey  <tom@tromey.com>
4459
4460         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
4461         declare.
4462         * tui/tui-windata.c
4463         (tui_data_window::delete_data_content_windows): Rename from
4464         tui_delete_data_content_windows.
4465         (tui_data_window::display_all_data)
4466         (tui_data_window::do_scroll_vertical): Update.
4467         * tui/tui-data.h (struct tui_data_window)
4468         <delete_data_content_windows>: New method.
4469
4470 2019-07-17  Tom Tromey  <tom@tromey.com>
4471
4472         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
4473         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
4474
4475 2019-07-17  Tom Tromey  <tom@tromey.com>
4476
4477         * tui/tui-windata.h (tui_display_all_data): Don't declare.
4478         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
4479         from tui_display_all_data.
4480         * tui/tui-win.c
4481         (tui_data_window::do_make_visible_with_new_height): Update.
4482         * tui/tui-regs.c (tui_show_registers): Update.
4483         * tui/tui-layout.c (tui_set_layout): Update.
4484         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
4485         method.
4486
4487 2019-07-17  Tom Tromey  <tom@tromey.com>
4488
4489         * tui/tui-windata.h (tui_display_data_from): Don't declare.
4490         * tui/tui-windata.c (tui_display_data_from): Remove.
4491         (tui_data_window::refresh_all): Update.
4492
4493 2019-07-17  Tom Tromey  <tom@tromey.com>
4494
4495         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
4496         * tui/tui-windata.c (tui_display_data_from_line): Remove.
4497         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
4498         tui_display_registers_from_line.
4499         * tui/tui-regs.h (tui_display_registers_from_line): Update.
4500         * tui/tui-regs.c (tui_display_registers_from_line): Remove
4501         "force_display" parameter.
4502
4503 2019-07-17  Tom Tromey  <tom@tromey.com>
4504
4505         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
4506         declare.
4507         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
4508         Rename from tui_first_reg_element_no_inline.
4509         (tui_display_reg_element_at_line)
4510         (tui_display_registers_from_line): Update.
4511         * tui/tui-data.h (struct tui_data_window)
4512         <first_reg_element_no_inline>: New method.
4513
4514 2019-07-17  Tom Tromey  <tom@tromey.com>
4515
4516         * tui/tui-windata.c (tui_display_data_from)
4517         (tui_data_window::do_scroll_vertical): Update.
4518         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
4519         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
4520         Rename from tui_line_from_reg_element_no.
4521         (tui_display_registers_from_line): Update.
4522         * tui/tui-data.h (struct tui_data_window)
4523         <line_from_reg_element_no>: New method.
4524
4525 2019-07-17  Tom Tromey  <tom@tromey.com>
4526
4527         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
4528         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
4529         tui_last_regs_line_no.
4530         (tui_display_reg_element_at_line)
4531         (tui_display_registers_from_line): Update.
4532         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
4533         method.
4534
4535 2019-07-17  Tom Tromey  <tom@tromey.com>
4536
4537         PR tui/24722:
4538         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
4539         (tui_update_breakpoint_info): Add "being_deleted" parameter.
4540         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
4541         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
4542         (tui_update_breakpoint_info): Likewise.
4543         * tui/tui-hooks.c (tui_event_create_breakpoint)
4544         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
4545         Update.
4546
4547 2019-07-17  Tom Tromey  <tom@tromey.com>
4548
4549         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
4550
4551 2019-07-17  Tom Tromey  <tom@tromey.com>
4552
4553         * tui/tui-winsource.c (tui_update_source_window_as_is)
4554         (tui_update_source_windows_with_addr): Update.
4555         * tui/tui-source.h (tui_set_source_content)
4556         (tui_show_symtab_source): Add "win_info" parameter.
4557         * tui/tui-source.c (tui_set_source_content): Add "win_info"
4558         parameter.
4559         (tui_show_symtab_source): Likewise.
4560
4561 2019-07-17  Tom Tromey  <tom@tromey.com>
4562
4563         * tui/tui-wingeneral.c
4564         (tui_check_and_display_highlight_if_needed): Check can_highlight.
4565
4566 2019-07-17  Tom Tromey  <tom@tromey.com>
4567
4568         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
4569         (struct tui_cmd_window) <can_scroll>: New method.
4570         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
4571         method.
4572
4573 2019-07-17  Tom Tromey  <tromey@adacore.com>
4574
4575         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
4576         do_field_signed>: Rename.  Change type of "value".
4577         * ui-out.c (ui_out::field_signed): Rename from field_int.
4578         Change type of "value".
4579         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
4580         type of "value".
4581         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
4582         do_field_int.  Change type of "value".
4583         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
4584         do_field_int.  Change type of "value".
4585         * tracepoint.c (trace_status_mi, tfind_1)
4586         (print_one_static_tracepoint_marker): Update.
4587         * thread.c (print_thread_info_1, print_selected_thread_frame):
4588         Update.
4589         * stack.c (print_frame, print_frame_info): Update.
4590         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
4591         Update.
4592         * source.c (print_source_lines_base): Update.
4593         * skip.c (info_skip_command): Update.
4594         * record-btrace.c (btrace_ui_out_decode_error)
4595         (btrace_call_history_src_line): Update.
4596         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
4597         Update.
4598         * progspace.c (print_program_space): Update.
4599         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
4600         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
4601         do_field_int.  Change type of "value".
4602         * mi/mi-out.c (mi_ui_out::do_table_begin)
4603         (mi_ui_out::do_table_header): Update.
4604         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
4605         type of "value".
4606         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
4607         (mi_cmd_data_list_changed_registers, output_register)
4608         (mi_cmd_data_read_memory, mi_load_progress)
4609         (mi_cmd_trace_frame_collected): Update.
4610         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
4611         Update.
4612         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
4613         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
4614         (mi_cmd_var_list_children, varobj_update_one): Update.
4615         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
4616         (mi_cmd_stack_list_args, list_arg_or_local): Update.
4617         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
4618         * inferior.c (print_inferior): Update.
4619         * gdb_bfd.c (print_one_bfd): Update.
4620         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
4621         Update.
4622         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
4623         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
4624         do_field_int.  Change type of "value".
4625         * cli-out.c (cli_ui_out::do_field_signed): Rename from
4626         do_field_int.  Change type of "value".
4627         * breakpoint.c (watchpoint_check, print_breakpoint_location)
4628         (print_one_breakpoint_location, print_it_catch_fork)
4629         (print_one_catch_fork, print_it_catch_vfork)
4630         (print_one_catch_vfork, print_it_catch_solib)
4631         (print_it_catch_exec, print_it_ranged_breakpoint)
4632         (print_mention_watchpoint, print_mention_masked_watchpoint)
4633         (bkpt_print_it, update_static_tracepoint): Update.
4634         * break-catch-throw.c (print_it_exception_catchpoint): Update.
4635         * break-catch-syscall.c (print_it_catch_syscall): Update.
4636         * ada-tasks.c (print_ada_task_info): Update.
4637         * ada-lang.c (print_it_exception, print_mention_exception):
4638         Update.
4639
4640 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
4641
4642         PR breakpoints/24541
4643         * gdbarch.c: Regenerate.
4644         * gdbarch.h: Regenerate.
4645         * gdbarch.sh: Adjust return type and parameter types for
4646         'stap_adjust_register'.
4647         (i386_stap_adjust_register): Adjust signature and return new
4648         register name.
4649         * stap-probe.c (stap_parse_register_operand): Adjust use of
4650         'gdbarch_stap_adjust_register'.
4651
4652 2019-07-17  Tom Tromey  <tromey@adacore.com>
4653
4654         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
4655         declare VEC.
4656         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
4657         std::vector.
4658         (struct s390_process_info): Add initializers.
4659         (s390_add_process): Use new.
4660         (s390_linux_nat_target::low_forget_process): Use delete.
4661         (s390_linux_nat_target::low_new_fork)
4662         (s390_linux_nat_target::stopped_by_watchpoint)
4663         (s390_linux_nat_target::low_prepare_to_resume)
4664         (s390_linux_nat_target::insert_watchpoint)
4665         (s390_linux_nat_target::insert_hw_breakpoint)
4666         (s390_linux_nat_target::remove_watchpoint)
4667         (s390_linux_nat_target::remove_hw_breakpoint): Update.
4668
4669 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
4670
4671         * aarch64-fbsd-nat.c: Include regcache.h.
4672         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
4673         argument.
4674         (aarch64_fbsd_nat_target::fetch_registers)
4675         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
4676         variable.
4677         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
4678
4679 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
4680
4681         * fbsd-nat.c: Include gdbarch.h.
4682
4683 2019-07-15  Tom Tromey  <tromey@adacore.com>
4684
4685         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
4686
4687 2019-07-15  Tom Tromey  <tromey@adacore.com>
4688
4689         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
4690         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
4691         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
4692         * cli-out.c (cli_ui_out::do_field_int): New method.
4693         * ui-out.c (ui_out::field_unsigned): New method.
4694         * symfile.c (generic_load): Use field_unsigned.
4695         (print_transfer_performance): Likewise.
4696         * record-btrace.c (ui_out_field_uint): Remove.
4697         (btrace_call_history_insn_range, btrace_call_history): Use
4698         field_unsigned.
4699         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
4700         field_unsigned.
4701         * ui-out.h (class ui_out) <field_unsigned>: New method.
4702         <do_field_unsigned>: Likewise.
4703
4704 2019-07-15  Tom Tromey  <tromey@adacore.com>
4705
4706         * mi/mi-main.c (list_available_thread_groups): Use field_string.
4707         * mi/mi-interp.c (mi_memory_changed): Use field_string.
4708         * target.c (flash_erase_command): Use field_string.
4709         * infrun.c (print_signal_received_reason): Use field_string.
4710         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
4711         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
4712         field_string.
4713         * ada-tasks.c (print_ada_task_info): Use field_string.
4714
4715 2019-07-15  Tom Tromey  <tromey@adacore.com>
4716
4717         * target.c (flash_erase_command): Use field_core_addr.
4718         * symfile.c (generic_load): Use field_core_addr.
4719         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
4720         Use field_core_addr.
4721         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
4722         field_core_addr.
4723
4724 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4725
4726         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
4727         value if its desired type is smaller than a CORE_ADDR and signed.
4728
4729 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4730
4731         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
4732         of changes to field names, and use new is_reference field to
4733         decide if a property is a reference or not.
4734         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
4735         field.
4736         (struct dwarf2_property_baton): Update header comment, rename
4737         'referenced_type' to 'property_type' and update comments.
4738         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
4739         default property type, store in property baton, update to take
4740         accound of renamed field.
4741         (read_func_scope): Update call to attr_to_dynamic_prop.
4742         (read_array_type): Likewise.
4743         (dwarf2_per_cu_addr_sized_int_type): New function.
4744         (read_subrange_index_type): Move type finding code to
4745         dwarf2_per_cu_addr_sized_int_type.
4746         (read_subrange_type): Update calls to attr_to_dynamic_prop.
4747         (dwarf2_per_cu_addr_type): New function.
4748         (set_die_type): Update calls to attr_to_dynamic_prop.
4749
4750 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4751
4752         * dwarf2read.c (read_subrange_index_type): New function.
4753         (read_subrange_type): Move code into new function and call it.
4754         * gdbtypes.c (create_range_type): Add some asserts.
4755
4756 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4757
4758         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
4759         update return statements.
4760         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
4761         declaration, and update comment to match.
4762         * gdbtypes.c (resolve_dynamic_array): Update call to
4763         dwarf2_evaluate_property to match new return type.
4764
4765 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4766
4767         * valarith.c (value_subscripted_rvalue): Change lowerbound
4768         parameter type from int to LONGEST.
4769         * value.h (value_subscripted_rvalue): Likewise in declaration.
4770
4771 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4772
4773         * cli/cli-utils.c (info_print_command_completer): New function.
4774         * cli/cli-utils.h: Add 'completer.h' include, and forward
4775         declaration for 'struct cmd_list_element'.
4776         (info_print_command_completer): Declare.
4777         * stack.c (_initialize_stack): Add completer for 'info locals' and
4778         'info args'.
4779         * symtab.c (_initialize_symtab): Add completer for 'info
4780         variables' and 'info functions'.
4781         * NEWS: Mention completion for additional info commands.
4782
4783 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4784
4785         * cli/cli-utils.c (extract_info_print_args): Delete.
4786         (extract_arg_maybe_quoted): Delete.
4787         (info_print_options_defs): New variable.
4788         (make_info_print_options_def_group): New function.
4789         (extract_info_print_options): Define new function.
4790         * cli/cli-utils.h (extract_info_print_args): Delete.
4791         (struct info_print_options): New structure.
4792         (extract_info_print_options): Declare new function.
4793         * stack.c (info_locals_command): Update to use new
4794         extract_info_print_options, also add a header comment.
4795         (info_args_command): Likewise.
4796         * symtab.c (info_variables_command): Likewise.
4797         (info_functions_command): Likewise.
4798
4799 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4800
4801         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
4802         to extract string arguments.
4803         * common/common-utils.c (extract_string_maybe_quoted): New function.
4804         * common/common-utils.h (extract_string_maybe_quoted): Declare.
4805
4806 2019-07-11  Tom Tromey  <tromey@adacore.com>
4807
4808         * main.c (get_init_files): Use GDBINIT, not gdbinit.
4809         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
4810         * top.h (gdbinit): Don't declare.
4811         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
4812         into...
4813         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
4814         * top.c (gdb_init): Don't call init_cli_cmds.
4815         (gdbinit): Remove.
4816         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
4817
4818 2019-07-11  Tom Tromey  <tromey@adacore.com>
4819
4820         * python/py-inferior.c (add_thread_object): Don't use thread_obj
4821         after it has been moved.
4822
4823 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
4824
4825         * valops.c (value_must_coerce_to_target): Change return type to
4826         bool.
4827         * value.h (value_must_coerce_to_target): Likewise.
4828
4829 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
4830
4831         * breakpoint.c (is_hardware_watchpoint): Remove
4832         forward-declaration.
4833         (is_masked_watchpoint): Change return type to bool.
4834         (is_tracepoint): Likewise.
4835         (is_breakpoint): Likewise.
4836         (is_hardware_watchpoint): Likewise.
4837         (is_watchpoint): Likewise.
4838         (is_no_memory_software_watchpoint): Likewise.
4839         (is_catchpoint): Likewise.
4840         (breakpoint_1): Make FILTER parameter's return type bool.
4841         is_masked_watchpoint): Change return type to bool.
4842         (save_breakpoints): Make FILTER parameter's return type bool.
4843         * breakpoint.h (is_breakpoint): Change return type to bool.
4844         (is_watchpoint): Likewise.
4845         (is_catchpoint): Likewise.
4846         (is_tracepoint): Likewise.
4847
4848 2019-07-10  Tom Tromey  <tom@tromey.com>
4849
4850         * defs.h: Don't include gdbarch.h.
4851         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
4852         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
4853         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
4854         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
4855         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
4856         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
4857         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
4858         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
4859         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
4860         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
4861         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
4862         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
4863         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
4864         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
4865         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
4866         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
4867         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
4868         record-btrace.c, record.h, regcache-dump.c, regcache.h,
4869         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
4870         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
4871         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
4872         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
4873         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
4874         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
4875         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
4876         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
4877         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
4878
4879 2019-07-10  Tom Tromey  <tromey@adacore.com>
4880
4881         * ada-lang.h (is_ada_exception_catchpoint): Declare.
4882         * breakpoint.c (init_ada_exception_breakpoint): Register as
4883         bp_catchpoint.
4884         (print_one_breakpoint_location, print_one_breakpoint): Use
4885         is_ada_exception_catchpoint.
4886         * ada-lang.c (class ada_catchpoint_location): Pass
4887         bp_loc_software_breakpoint to bp_location constructor.
4888         (is_ada_exception_catchpoint): New function.
4889
4890 2019-07-10  Tom Tromey  <tromey@adacore.com>
4891
4892         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
4893         VEC.
4894         (struct arm_exidx_entry): New method operator<.
4895         (struct arm_exidx_data) <section_maps>: Change type.
4896         (arm_exidx_data_free): Remove.
4897         (arm_exidx_data_key): Change type.  Move lower.
4898         (arm_exidx_new_objfile): Update.
4899         (arm_compare_exidx_entries): Remove.
4900         (arm_find_exidx_entry, _initialize_arm_tdep)
4901
4902 2019-07-10  Tom Tromey  <tromey@adacore.com>
4903
4904         * solib-spu.c (ocl_program_data_key): Change type.
4905         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
4906         Update.
4907
4908 2019-07-10  Tom Tromey  <tromey@adacore.com>
4909
4910         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
4911         (struct solib_aix_inferior_data) <library_list>: Change type.
4912         (solib_aix_inferior_data_handle): Change type.
4913         (get_solib_aix_inferior_data): Update.
4914         (solib_aix_free_library_list): Remove.
4915         (library_list_start_library): Update.
4916         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
4917         return type.
4918         (solib_aix_get_library_list)
4919         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
4920         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
4921
4922 2019-07-10  Tom Tromey  <tromey@adacore.com>
4923
4924         * solib-dsbt.c (struct dsbt_info): Add initializers.
4925         (solib_dsbt_pspace_data): Change type.
4926         (dsbt_pspace_data_cleanup): Remove.
4927         (get_dsbt_info, _initialize_dsbt_solib): Update.
4928
4929 2019-07-10  Tom Tromey  <tromey@adacore.com>
4930
4931         * spu-tdep.c (spu_overlay_data): Change type.
4932         (spu_get_overlay_table, spu_overlay_new_objfile)
4933         (_initialize_spu_tdep): Update.
4934
4935 2019-07-10  Tom Tromey  <tromey@adacore.com>
4936
4937         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
4938         destructor.
4939         (dbx_objfile_data_key): Change type and declare later.
4940         (DBX_SYMFILE_INFO): Rewrite.
4941         * dbxread.c (dbx_objfile_data_key): Change type.
4942         (dbx_symfile_init): Update.
4943         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
4944         (coffstab_build_psymtabs, elfstab_build_psymtabs)
4945         (stabsect_build_psymtabs, _initialize_dbxread): Update.
4946
4947 2019-07-10  Tom Tromey  <tromey@adacore.com>
4948
4949         * jit.c (jit_program_space_key): Change type.  Move lower.
4950         (get_jit_program_space_data): Update.
4951         (jit_program_space_data_cleanup): Remove.
4952         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
4953         Update.
4954         (struct jit_program_space_data): Add initializers.
4955
4956 2019-07-10  Tom Tromey  <tromey@adacore.com>
4957
4958         * solib-darwin.c (struct darwin_info): Add initializers.
4959         (solib_darwin_pspace_data): Change type.
4960         (darwin_pspace_data_cleanup): Remove.
4961         (get_darwin_info, _initialize_darwin_solib): Update.
4962
4963 2019-07-10  Tom Tromey  <tromey@adacore.com>
4964
4965         * remote-sim.c (struct sim_inferior_data): Add initializers,
4966         constructor, and destructor.
4967         (sim_inferior_data_key): Change type.  Move lower.
4968         (check_for_duplicate_sim_descriptor): Update.
4969         (get_sim_inferior_data): Use new.  Update.
4970         (~sim_inferior_data_cleanup): Rename from
4971         sim_inferior_data_cleanup.  Simplify.
4972         (gdbsim_close_inferior, simulator_command)
4973         (sim_command_completer, _initialize_remote_sim): Update.
4974         (next_pid, INITIAL_PID): Move earlier.
4975
4976 2019-07-10  Tom Tromey  <tromey@adacore.com>
4977
4978         * python/python-internal.h (create_thread_object): Return
4979         gdbpy_ref.
4980         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
4981         * python/py-inferior.c (struct threadlist_entry): Add
4982         constructor.
4983         <thread_obj>: Now a gdbpy_ref.
4984         (thread_to_thread_object): Update.
4985         (add_thread_object): Use new.
4986         (delete_thread_object): Use delete.
4987         (infpy_threads): Update.
4988         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
4989         GIL.
4990
4991 2019-07-10  Tom Tromey  <tromey@adacore.com>
4992
4993         * valops.c (value_cast): Specialize error message for Ada.
4994
4995 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
4996
4997         * breakpoint.c (breakpoint_1): Update doc and parameter names.
4998
4999 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
5000
5001         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
5002         bpstat_should_step): Return bool, adjust comments.
5003         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
5004         bpstat_should_step): Likewise.
5005
5006 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
5007
5008         * features/Makefile: Use feature target descriptions for Arm.
5009         * features/arm/arm-core.c: Generate new file.
5010         * features/arm/arm-fpa.c: Likewise.
5011         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
5012         * features/arm/arm-m-profile.c: Likewise.
5013         * features/arm/arm-vfpv2.c: Likewise.
5014         * features/arm/arm-vfpv3.c: Likewise.
5015         * features/arm/xscale-iwmmxt.c: Likewise.
5016         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
5017
5018 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
5019
5020         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
5021         ptrace earlier.
5022
5023 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
5024
5025         * features/aarch64-pauth.c: Regenerate.
5026
5027 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
5028
5029         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
5030         bool.
5031         (bpstat_what): Use false instead of 0.
5032
5033 2019-07-09  Pedro Alves  <palves@redhat.com>
5034
5035         * break-catch-throw.c (is_exception_catchpoint): New.
5036         * breakpoint.c (print_one_breakpoint_location): New parameter
5037         'raw_loc'.  Handle it.  Use
5038         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
5039         looking at the breakpoint's type.
5040         (print_one_breakpoint): If handling "maint info breakpoints", also
5041         print locations of exception catchpoints.
5042         * breakpoint.h (is_exception_catchpoint): Declare.
5043
5044 2019-07-09  Pedro Alves  <palves@redhat.com>
5045
5046         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
5047         "addr" field.
5048         (allocate_location_exception_catchpoint): New.
5049         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
5050         (initialize_throw_catchpoint_ops): Install
5051         allocate_location_exception_catchpoint as allocate_location
5052         method.
5053         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
5054         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
5055         bp_loc_other.
5056         (breakpoint_address_is_meaningful): Delete.
5057         (bl_address_is_meaningful): New.
5058         (breakpoint_locations_match): Adjust comment.
5059         (bp_location_from_bp_type): New, factored out of...
5060         (bp_location::bp_location(breakpoint *)): ... this.
5061         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
5062         factored out of...
5063         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
5064         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
5065         breakpoint_address_is_meaningful.
5066         (bp_locations_compare): Adjust comment.
5067         (update_global_location_list): Use bl_address_is_meaningful
5068         instead of breakpoint_address_is_meaningful.
5069         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
5070         explicit.
5071         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
5072         * python/py-breakpoint.c (bppy_get_location): No longer check
5073         whether location is null.
5074
5075 2019-07-09  Pedro Alves  <palves@redhat.com>
5076
5077         PR c++/15468
5078         * breakpoint.c (print_one_breakpoint_location): Remove
5079         single-location assert.
5080
5081 2019-07-09  Tom Tromey  <tom@tromey.com>
5082
5083         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
5084         * configure: Rebuild.
5085         * configure.ac: Change common to gdbsupport.
5086         * gdbsupport: Rename from common.
5087         * acinclude.m4: Change common to gdbsupport.
5088         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
5089         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
5090         gdbsupport.
5091         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
5092         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
5093         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
5094         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
5095         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
5096         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
5097         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
5098         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
5099         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
5100         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
5101         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
5102         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
5103         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
5104         coff-pe-read.c, command.h, compile/compile-c-support.c,
5105         compile/compile-c.h, compile/compile-cplus-symbols.c,
5106         compile/compile-cplus-types.c, compile/compile-cplus.h,
5107         compile/compile-loc2c.c, compile/compile.c, completer.c,
5108         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
5109         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
5110         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
5111         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
5112         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
5113         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
5114         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
5115         features/aarch64-core.c, features/aarch64-fpu.c,
5116         features/aarch64-pauth.c, features/aarch64-sve.c,
5117         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
5118         features/i386/32bit-core.c, features/i386/32bit-linux.c,
5119         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
5120         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
5121         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
5122         features/i386/64bit-core.c, features/i386/64bit-linux.c,
5123         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
5124         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
5125         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
5126         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
5127         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
5128         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
5129         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
5130         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
5131         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
5132         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
5133         go32-nat.c, guile/guile.c, guile/scm-ports.c,
5134         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
5135         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
5136         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
5137         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
5138         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
5139         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
5140         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
5141         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
5142         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
5143         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
5144         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
5145         minsyms.c, mips-linux-tdep.c, namespace.h,
5146         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
5147         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
5148         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
5149         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
5150         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
5151         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
5152         nat/linux-waitpid.c, nat/mips-linux-watch.c,
5153         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
5154         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
5155         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
5156         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
5157         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
5158         procfs.c, producer.c, progspace.h, psymtab.h,
5159         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
5160         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
5161         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
5162         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
5163         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
5164         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
5165         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
5166         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
5167         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
5168         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
5169         target-memory.c, target.c, target.h, target/waitstatus.c,
5170         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
5171         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
5172         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
5173         unittests/array-view-selftests.c,
5174         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
5175         unittests/common-utils-selftests.c,
5176         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
5177         unittests/format_pieces-selftests.c,
5178         unittests/function-view-selftests.c,
5179         unittests/lookup_name_info-selftests.c,
5180         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
5181         unittests/mkdir-recursive-selftests.c,
5182         unittests/observable-selftests.c,
5183         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
5184         unittests/parse-connection-spec-selftests.c,
5185         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
5186         unittests/scoped_fd-selftests.c,
5187         unittests/scoped_mmap-selftests.c,
5188         unittests/scoped_restore-selftests.c,
5189         unittests/string_view-selftests.c, unittests/style-selftests.c,
5190         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
5191         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
5192         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
5193         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
5194         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
5195         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
5196
5197 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
5198
5199         * linespec.c (decode_digits_list_mode): Set explicit_line to a
5200         bool value.
5201         (decode_digits_ordinary): Set explicit_line field in sal.
5202         * symtab.c (skip_prologue_sal): Don't skip prologue for a
5203         symtab_and_line that was set on an explicit line number in
5204         assembler code.  Do always update the recorded symtab and line if
5205         we do skip the prologue.
5206
5207 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
5208
5209         * breakpoint.c (set_breakpoint_location_function): Remove
5210         explicit_loc parameter.
5211         (momentary_breakpoint_from_master): Update call to
5212         set_breakpoint_location_function.
5213         (add_location_to_breakpoint): Likewise.
5214
5215 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
5216
5217         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
5218         required features based on default bfd type when no specific bfd
5219         is present.
5220
5221 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5222
5223         * NEWS: Mention that GDB printf and eval commands can now print
5224         C-style and Ada-style convenience var strings without
5225         calling the inferior.
5226         * printcmd.c (printf_c_string): Locally print GDB internal var
5227         instead of transiting via the inferior.
5228         (printf_wide_c_string): Likewise.
5229
5230 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5231
5232         PR breakpoints/25011
5233         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
5234
5235 2019-07-04  Tom Tromey  <tom@tromey.com>
5236
5237         PR tui/24724:
5238         * tui/tui-winsource.c (tui_clear_source_content): Update.
5239         (tui_source_window_base::set_is_exec_point_at): Fix comment.
5240         (tui_update_breakpoint_info): Update.
5241         (tui_set_exec_info_content): Update.
5242         * tui/tui-source.c (tui_set_source_content_nil): Update.
5243         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
5244         has_break.
5245         * tui/tui-data.h (enum tui_bp_flag): New.
5246         (tui_bp_flags): New enum flags type.
5247         (struct tui_source_element) <break_mode>: Change type.  Rename
5248         from has_break.
5249         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
5250         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
5251         constants.
5252         * tui/tui-winsource.h: Fix comment.
5253
5254 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5255
5256         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
5257         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
5258         (store_fpregs_to_thread)
5259         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
5260         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
5261         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
5262         (IWMMXT_REGS_SIZE): Add define.
5263         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
5264         (fetch_vfp_regs, store_vfp_regs)
5265         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
5266         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
5267
5268 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5269
5270         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
5271         defines.
5272         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
5273         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
5274         (ARM_INT_REGISTER_SIZE): ...to this.
5275         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
5276         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
5277         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
5278         (arm_linux_collect_gregset, supply_nwfpe_register)
5279         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
5280         defines.
5281         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
5282         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
5283         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
5284         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
5285         (arm_return_in_memory, arm_store_return_value)
5286         (arm_get_longjmp_target, arm_register_g_packet_guesses)
5287         (arm_record_ld_st_multiple): Likewise.
5288         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
5289         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
5290
5291 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5292
5293         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
5294         AARCH64_DISPLACED_MODIFIED_INSNS.
5295         * aarch64-tdep.c (struct aarch64_displaced_step_data)
5296         (aarch64_displaced_step_copy_insn): Likewise.
5297         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
5298         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
5299         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
5300         ARM_DISPLACED_MODIFIED_INSNS.
5301         * arm-tdep.c (arm_gdbarch_init): Likewise.
5302         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
5303         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
5304         (struct arm_displaced_step_closure): Use
5305         ARM_DISPLACED_MODIFIED_INSNS.
5306
5307 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5308
5309         * features/Makefile: Remove unused xml files.
5310         * features/aarch64.xml: Remove.
5311         * features/i386/amd64-avx-avx512-linux.xml: Remove.
5312         * features/i386/amd64-avx-avx512.xml: Remove.
5313         * features/i386/amd64-avx-linux.xml: Remove.
5314         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
5315         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
5316         * features/i386/amd64-avx-mpx-linux.xml: Remove.
5317         * features/i386/amd64-avx-mpx.xml: Remove.
5318         * features/i386/amd64-avx.xml: Remove.
5319         * features/i386/amd64-linux.xml: Remove.
5320         * features/i386/amd64-mpx-linux.xml: Remove.
5321         * features/i386/amd64-mpx.xml: Remove.
5322         * features/i386/amd64.xml: Remove.
5323         * features/i386/i386-avx-avx512-linux.xml: Remove.
5324         * features/i386/i386-avx-avx512.xml: Remove.
5325         * features/i386/i386-avx-linux.xml: Remove.
5326         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
5327         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
5328         * features/i386/i386-avx-mpx-linux.xml: Remove.
5329         * features/i386/i386-avx-mpx.xml: Remove.
5330         * features/i386/i386-avx.xml: Remove.
5331         * features/i386/i386-linux.xml: Remove.
5332         * features/i386/i386-mmx-linux.xml: Remove.
5333         * features/i386/i386-mmx.xml: Remove.
5334         * features/i386/i386-mpx-linux.xml: Remove.
5335         * features/i386/i386-mpx.xml: Remove.
5336         * features/i386/i386.xml: Remove.
5337         * features/i386/x32-avx-avx512-linux.xml: Remove.
5338         * features/i386/x32-avx-linux.xml: Remove.
5339         * features/i386/x32-linux.xml: Remove.
5340
5341 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5342
5343         * regformats/aarch64.dat: Remove.
5344         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
5345         * regformats/i386/amd64-avx-linux.dat: Remove.
5346         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
5347         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
5348         * regformats/i386/amd64-linux.dat: Remove.
5349         * regformats/i386/amd64-mpx-linux.dat: Remove.
5350         * regformats/i386/amd64.dat: Remove.
5351         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
5352         * regformats/i386/i386-avx-linux.dat: Remove.
5353         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
5354         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
5355         * regformats/i386/i386-linux.dat: Remove.
5356         * regformats/i386/i386-mmx-linux.dat: Remove.
5357         * regformats/i386/i386-mpx-linux.dat: Remove.
5358         * regformats/i386/i386.dat: Remove.
5359         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
5360         * regformats/i386/x32-avx-linux.dat: Remove.
5361         * regformats/i386/x32-linux.dat: Remove.
5362
5363 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5364
5365         * aarch64-tdep.c: Remove xml self tests.
5366         * amd64-linux-tdep.c: Likewise.
5367         * amd64-tdep.c: Likewise.
5368         * i386-linux-tdep.c: Likewise.
5369         * i386-tdep.c: Likewise.
5370
5371 2019-07-03  Pedro Alves  <palves@redhat.com>
5372
5373         PR cli/24732
5374         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
5375         (pipe_cmd_option_defs): New.
5376         (make_pipe_cmd_options_def_group): New.
5377         (pipe_command): Use gdb::option::process_options.
5378         (pipe_command_completer): New function.
5379         (_initialize_cli_cmds): Install completer for "pipe" command.
5380
5381 2019-07-03  Pedro Alves  <palves@redhat.com>
5382
5383         * cli/cli-option.c (union option_value) <string>: New field.
5384         (struct option_def_and_value): Add ctor, move ctor, dtor and
5385         use DISABLE_COPY_AND_ASSIGN.
5386         (option_def_and_value::clear_value): New.
5387         (parse_option, save_option_value_in_ctx, get_val_type_str)
5388         (add_setshow_cmds_for_options): Handle var_string.
5389         * cli-option.h (union option_def::var_address) <string>: New
5390         field.
5391         (struct string_option_def): New.
5392         * maint-test-options.c (struct test_options_opts): Add default
5393         ctor and use DISABLE_COPY_AND_ASSIGN.
5394         <string_opt>: New field.
5395         (test_options_opts::~test_options_opts): New.
5396         (test_options_opts::dump): Also dump "-string".
5397         (test_options_option_defs): Install "string.
5398
5399 2019-07-03  Pedro Alves  <palves@redhat.com>
5400
5401         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
5402         option_value with a null enumeration.
5403         (complete_options): Save the option values in the context.
5404         (save_option_value_in_ctx): New, factored out from ...
5405         (process_options): ... here.
5406         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
5407         of the function.
5408         * maint-test-options.c (test_options_opts::dump): New, factored
5409         out from ...
5410         (maintenance_test_options_command_mode): ... here.
5411         (maintenance_test_options_command_completion_result): Delete.
5412         (maintenance_test_options_command_completion_text): Update
5413         comment.
5414         (maintenance_show_test_options_completion_result): Change
5415         prototype.  Just print
5416         maintenance_test_options_command_completion_text.
5417         (save_completion_result): New.
5418         (maintenance_test_options_completer_mode): Pass options context to
5419         complete_options, and then save a dump.
5420         (_initialize_maint_test_options): Use add_cmd to install "maint
5421         show test-options-completion-result".
5422
5423 2019-07-03  Pedro Alves  <palves@redhat.com>
5424
5425         * NEWS (New commands): Mention "with" and "maint with".
5426         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
5427         (with_command, with_command_completer): New.
5428         (pipe_command): Adjust to new repeat_previous
5429         interface.
5430         (_initialize_cli_cmds): Install the "with" command and its "w"
5431         alias.
5432         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
5433         declarations.
5434         * cli/cli-setshow.c (parse_cli_var_uinteger)
5435         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
5436         argument strings for all var_types.
5437         (get_setshow_command_value_string): New, factored out from ...
5438         (do_show_command): ... this.
5439         * cli/cli-setshow.h: Include <string>.
5440         (get_setshow_command_value_string): Declare.
5441         * command.h (repeat_previous): Now returns const char *.  Adjust
5442         comment.
5443         * maint.c: Include "cli/cli-cmds.h".
5444         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
5445         (_initialize_maint_cmds): Register the "maintenance with" command.
5446         * top.c (repeat_previous): Move bits from pipe_command here:
5447         Return the saved command line, if any; error out if there's no
5448         command to relaunch.
5449
5450 2019-07-03  Pedro Alves  <palves@redhat.com>
5451
5452         * NEWS (New commands): Mention "maint set/show test-settings"
5453         instead of "maint test-settings".
5454         * maint-test-settings.c (maintenance_test_settings_list): Delete.
5455         (maintenance_test_settings_set_list): Rename to ...
5456         (maintenance_set_test_settings_list): ... this.
5457         (maintenance_test_settings_show_list): Rename to  ...
5458         (maintenance_show_test_settings_list): ... this.
5459         (maintenance_test_settings_cmd): Delete.
5460         (maintenance_test_settings_set_cmd): ...
5461         (maintenance_set_test_settings_cmd): ... this.
5462         (maintenance_test_settings_show_cmd): ...
5463         (maintenance_show_test_settings_cmd): ... this.
5464         (maintenance_test_settings_show_value_cmd):
5465         (maintenance_show_test_settings_value_cmd): ... this.
5466         (_initialize_maint_test_settings): No longer install the "maint
5467         test-settings" prefix command.  Rename "maint test-settings set"
5468         to "maint set test-settings", and "maint test-settings show" to
5469         "maint show test-settings".  Adjust all subcommands.
5470
5471 2019-07-03  Pedro Alves  <palves@redhat.com>
5472
5473         * maint-test-settings.c: Fix file's intro comment.  Replace all
5474         references to "test-options" with references to "test-settings",
5475         in comments.
5476
5477 2019-07-03  Pedro Alves  <palves@redhat.com>
5478
5479         * maint-test-settings.c (maintenance_test_settings_xxx)
5480         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
5481         New.
5482         (maintenance_test_settings_enums): Use them.
5483         (maintenance_test_settings_enum): Default to
5484         maintenance_test_settings_xxx.
5485         (_initialize_maint_test_settings): Initialize
5486         MAINTENANCE_TEST_SETTINGS_FILENAME.
5487
5488 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
5489
5490         * breakpoint.h (remove_breakpoints_inf): Change return type to
5491         void, move function documentation here.
5492         * breakpoint.c (remove_breakpoints_inf): Change return type to
5493         void, move function documentation to header.
5494
5495 2019-07-02  Pedro Alves  <palves@redhat.com>
5496
5497         * NEWS (Completion improvements): Mention "info threads".
5498         * thread.c (struct info_threads_opts, info_threads_option_defs)
5499         (make_info_threads_options_def_group): New.
5500         (info_threads_command): Use gdb::option::process_options.
5501         (info_threads_command_completer): New.
5502         (_initialize_thread): Use gdb::option::build_help to build the
5503         help text for "info threads".
5504
5505 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
5506
5507         * defs.h (generic_load): Move from here...
5508         * symfile.h (generic_load): ... to here.  Rename name parameter
5509         to args.
5510         * symfile.c (generic_load): Add comment.
5511
5512 2019-07-01  Tom Tromey  <tromey@adacore.com>
5513
5514         * dwarf2read.c
5515         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
5516         declaration of without_params.  Fix formatting.
5517
5518 2019-07-01  Tom Tromey  <tromey@adacore.com>
5519
5520         * ada-exp.y (find_primitive_type): Update.
5521         * ada-lang.h (ada_lookup_symbol): Update.
5522         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
5523         parameter.
5524         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
5525
5526 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
5527
5528         PR breakpoints/24541
5529         * gdbarch.c: Regenerate.
5530         * gdbarch.h: Regenerate.
5531         * gdbarch.sh: Add 'stap_adjust_register'.
5532         * i386-tdep.c: Include '<unordered_set>'.
5533         (i386_stap_adjust_register): New function.
5534         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
5535         * stap-probe.c (stap_parse_register_operand): Call
5536         'gdbarch_stap_adjust_register'.
5537
5538 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
5539
5540         PR python/24742
5541         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
5542         * python/python.c (do_start_initialization): Use 'xmalloc'
5543         instead of 'PyMem_Malloc'.
5544
5545 2019-06-28  Tom Tromey  <tromey@adacore.com>
5546
5547         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
5548         for Ada.
5549
5550 2019-06-27  Tom Tromey  <tromey@adacore.com>
5551
5552         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
5553         objfile_key.
5554         (arm_find_mapping_symbol, arm_record_special_symbol)
5555         (_initialize_arm_tdep): Update.
5556         (arm_objfile_data_free): Remove.
5557
5558 2019-06-27  Tom Tromey  <tromey@adacore.com>
5559
5560         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
5561         to cp_print_static_field.
5562
5563 2019-06-26  Tom Tromey  <tromey@adacore.com>
5564
5565         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
5566         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
5567         declare.
5568
5569 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
5570
5571         * features/aarch64-core.c (create_feature_aarch64_core):
5572         Regenerate.
5573         * features/aarch64-core.xml: Add cpsr flags.
5574
5575 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
5576
5577         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
5578         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
5579
5580 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
5581
5582         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
5583         field.
5584         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
5585         use.
5586         (arm_record_special_symbol): Don't insert new symbol in sorted
5587         position, push it at the end.
5588
5589 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
5590
5591         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
5592         (arm_mapping_symbol_s): Remove.
5593         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
5594         (arm_mapping_symbol_vec): New typedef.
5595         (struct arm_per_objfile): Add constructor.
5596         <section_maps>: Change type to
5597         std::unique_ptr<arm_mapping_symbol_vec[]>.
5598         (arm_compare_mapping_symbols): Remove.
5599         (arm_find_mapping_symbol): Adjust to section_maps type change.
5600         (arm_objfile_data_free): Call delete on arm_per_objfile.
5601         (arm_record_special_symbol): Adjust to section_maps type change.
5602         Allocate arm_per_objfile with new.
5603
5604 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5605
5606         * cli/cli-cmds.c (alias_command): Compare the alias prefix
5607         with the command prefix.
5608
5609 2019-06-25  Tom Tromey  <tom@tromey.com>
5610
5611         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
5612         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
5613
5614 2019-06-25  Tom Tromey  <tom@tromey.com>
5615
5616         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
5617         type.
5618         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
5619         protected.
5620
5621 2019-06-25  Tom Tromey  <tom@tromey.com>
5622
5623         * tui/tui-winsource.c
5624         (tui_source_window_base::set_is_exec_point_at): Add check against
5625         LOA_ADDRESS.
5626
5627 2019-06-25  Tom Tromey  <tom@tromey.com>
5628
5629         * tui/tui-source.c (tui_set_source_content): Don't check before
5630         xfree.
5631         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
5632
5633 2019-06-25  Tom Tromey  <tom@tromey.com>
5634
5635         * tui/tui-winsource.h (tui_update_source_window_as_is)
5636         (tui_alloc_source_buffer, tui_line_is_displayed)
5637         (tui_addr_is_displayed): Change type of win_info.
5638         * tui/tui-winsource.c (tui_update_source_window_as_is)
5639         (tui_clear_source_content, tui_show_source_line)
5640         (tui_show_source_content, tui_source_window_base::refill)
5641         (tui_source_window_base::set_is_exec_point_at)
5642         (tui_source_window_base::set_is_exec_point_at)
5643         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
5644         (tui_alloc_source_buffer, tui_line_is_displayed)
5645         (tui_addr_is_displayed): Change type of win_info.  Update.
5646         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
5647         (tui_source_window_base::do_make_visible_with_new_height):
5648         Update.
5649         * tui/tui-source.c (tui_set_source_content)
5650         (tui_set_source_content_nil)
5651         (tui_source_window::do_scroll_vertical): Update.
5652         * tui/tui-layout.c (show_layout): Update.
5653         * tui/tui-disasm.c (tui_set_disassem_content)
5654         (tui_disasm_window::do_scroll_vertical): Update.
5655         * tui/tui-data.h (tui_win_content): Remove.
5656         (struct tui_gen_win_info) <content, content_size>: Remove.
5657         (struct tui_source_element): Add initializers and destructor.
5658         (union tui_which_element, struct tui_win_element): Remove.
5659         (struct tui_source_window_base) <content>: New field.
5660         (struct tui_data_window): Remove destructor.
5661         (tui_alloc_content, tui_free_win_content)
5662         (tui_free_all_source_wins_content): Don't declare.
5663         * tui/tui-data.c (tui_initialize_static_data): Update.
5664         (init_content_element, tui_alloc_content): Remove.
5665         (~tui_gen_win_info): Update.
5666         (~tui_data_window, tui_free_all_source_wins_content)
5667         (tui_free_win_content, free_content, free_content_elements):
5668         Remove.
5669
5670 2019-06-25  Tom Tromey  <tom@tromey.com>
5671
5672         * tui/tui-winsource.h (tui_clear_source_content)
5673         (tui_erase_source_content, tui_show_source_content): Change type
5674         of win_info.
5675         * tui/tui-winsource.c (tui_clear_source_content)
5676         (tui_erase_source_content, tui_show_source_content): Change type
5677         of win_info.
5678         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
5679         * tui/tui-source.h (tui_set_source_content_nil): Change type of
5680         win_info.
5681         * tui/tui-source.c (tui_set_source_content_nil): Change type of
5682         win_info.
5683         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
5684
5685 2019-06-25  Tom Tromey  <tom@tromey.com>
5686
5687         * tui/tui-winsource.c (tui_clear_source_content)
5688         (tui_source_window_base::set_is_exec_point_at): Update.
5689         * tui/tui-source.c (tui_set_source_content_nil): Update.
5690         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
5691         a bool.
5692         * tui/tui-data.c (init_content_element): Update.
5693
5694 2019-06-25  Tom Tromey  <tom@tromey.com>
5695
5696         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
5697         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
5698         * tui/tui-layout.c (init_and_make_win): Update.
5699         * tui/tui.h (enum tui_win_type): Update.
5700         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
5701         tui_win_is_auxillary.
5702         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
5703         tui_win_is_auxillary.
5704
5705 2019-06-25  Tom Tromey  <tom@tromey.com>
5706
5707         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
5708         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
5709         (tui_delete_data_content_windows, tui_display_all_data)
5710         (tui_data_window::do_scroll_vertical, tui_display_data_from):
5711         Update.
5712         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
5713         * tui/tui-regs.c (tui_last_regs_line_no)
5714         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
5715         (tui_show_registers): Update.
5716         (tui_show_register_group): Return void.  Update.
5717         (tui_display_registers_from, tui_display_reg_element_at_line)
5718         (tui_display_registers_from_line, tui_check_register_values):
5719         Update.
5720         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
5721         member.
5722         (struct tui_data_window) <regs_content>: Now a std::vector.
5723         <regs_content_count>: Remove.
5724         (tui_add_content_elements, tui_free_data_content): Don't declare.
5725         * tui/tui-data.c (tui_data_window::clear_detail): Update.
5726         (init_content_element): Remove DATA_WIN case.  Add assert.
5727         (tui_add_content_elements): Remove.
5728         (tui_data_window): Update.
5729         (tui_free_data_content): Remove.
5730         (free_content_elements): Remove DATA_WIN case.
5731
5732 2019-06-25  Tom Tromey  <tom@tromey.com>
5733
5734         * tui/tui-data.c (tui_data_item_window): Update.
5735         * tui/tui-windata.h (tui_check_data_values): Don't declare.
5736         * tui/tui-windata.c (tui_display_all_data)
5737         (tui_display_data_from_line): Update.
5738         (tui_check_data_values): Remove.
5739         * tui/tui-regs.c (tui_show_register_group)
5740         (tui_display_reg_element_at_line): Update.
5741         * tui/tui-hooks.c (tui_register_changed)
5742         (tui_refresh_frame_and_register_information): Call
5743         tui_check_register_values.
5744         * tui/tui-data.h (struct tui_data_window) <data_content,
5745         data_content_count, data_type>: Remove.
5746         (enum tui_data_type): Remove.
5747
5748         * tui/tui-data.c (tui_data_window::clear_detail)
5749         (~tui_data_window): Update.
5750
5751 2019-06-25  Tom Tromey  <tom@tromey.com>
5752
5753         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
5754         declare.
5755         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
5756         Rename from tui_first_data_item_displayed.  Update.
5757         (tui_data_window::refresh_all)
5758         (tui_data_window::do_scroll_vertical): Update.
5759         * tui/tui-data.h (struct tui_data_window)
5760         <first_data_item_displayed>: Declare new method.
5761
5762 2019-06-25  Tom Tromey  <tom@tromey.com>
5763
5764         * tui/tui-data.h (tui_init_generic_part): Don't declare.
5765         * tui/tui-data.c (tui_init_generic_part): Remove, moving
5766         contents...
5767         (tui_initialize_static_data): ...here.
5768
5769 2019-06-25  Tom Tromey  <tom@tromey.com>
5770
5771         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
5772         (tui_display_registers_from, tui_check_register_values): Update.
5773         (tui_display_register): Remove win_info parameter; update.
5774         (tui_get_register): Change type of parameters.
5775         * tui/tui-data.h (struct tui_data_element): Remove.
5776         (union tui_which_element) <data>: Remove.
5777         <data_window>: Change type.
5778         (struct tui_data_item_window): New.
5779         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
5780         case.  Add assert.
5781         (~tui_data_item_window): New destructor.
5782         (free_content_elements): Remove DATA_ITEM_WIN case.
5783
5784 2019-06-25  Tom Tromey  <tom@tromey.com>
5785
5786         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
5787         Remove.
5788
5789 2019-06-25  Tom Tromey  <tom@tromey.com>
5790
5791         * tui/tui-data.h (struct tui_command_element): Remove.
5792         (union tui_which_element) <command>: Remove.
5793         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
5794         assert.
5795         (free_content_elements): Remove CMD_WIN case.
5796
5797 2019-06-25  Tom Tromey  <tom@tromey.com>
5798
5799         * tui/tui-layout.c (tui_set_layout): Update.
5800         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
5801         * tui/tui-data.c (layout_def): Update.
5802
5803 2019-06-25  Tom Tromey  <tom@tromey.com>
5804
5805         * tui/tui-wingeneral.c (tui_refresh_all): Update.
5806         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
5807         (tui_source_window_base::set_new_height): Update.
5808         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
5809         Update.
5810         (tui_set_locator_fullname, tui_set_locator_info)
5811         (tui_show_frame_info): Update.
5812         * tui/tui-source.c (tui_set_source_content)
5813         (tui_source_is_displayed): Update.
5814         * tui/tui-layout.c (show_source_disasm_command, show_data)
5815         (show_source_or_disasm_and_command): Update.
5816         * tui/tui-disasm.c (tui_set_disassem_content)
5817         (tui_get_begin_asm_address): Update.
5818         * tui/tui-data.h (struct tui_locator_element): Remove.
5819         (union tui_which_element) <locator>: Remove.
5820         (struct tui_locator_window): New.
5821         (tui_locator_win_info_ptr): Change return type.
5822         * tui/tui-data.c (_locator): Change type.
5823         (tui_locator_win_info_ptr): Change return type.
5824         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
5825         (tui_alloc_content): Add assert.
5826
5827 2019-06-25  Tom Tromey  <tom@tromey.com>
5828
5829         * tui/tui-winsource.c
5830         (tui_exec_info_window::maybe_allocate_content): New method.
5831         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
5832         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
5833         (make_source_or_disasm_window): Add cast.
5834         * tui/tui-data.h (union tui_which_element) <simple_string>:
5835         Remove.
5836         (struct tui_source_info): New.
5837         (struct tui_source_window_base) <execution_info>: Change type.
5838         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
5839         case, and add assert.
5840         (tui_alloc_content): Add assert.
5841
5842 2019-06-25  Tom Tromey  <tom@tromey.com>
5843
5844         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
5845         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
5846         * tui/tui-data.c (tui_alloc_win_info): Remove.
5847
5848 2019-06-25  Tom Tromey  <tom@tromey.com>
5849
5850         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
5851         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
5852         can_highlight.
5853
5854 2019-06-25  Tom Tromey  <tom@tromey.com>
5855
5856         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
5857         make_visible_with_new_height method.
5858         (tui_win_info::make_visible_with_new_height): New method.
5859         (tui_source_window_base::do_make_visible_with_new_height)
5860         (tui_data_window::do_make_visible_with_new_height)
5861         (tui_cmd_window::do_make_visible_with_new_height): New methods.
5862         (make_visible_with_new_height): Remove.
5863         (tui_resize_all, tui_adjust_win_heights): Use
5864         make_visible_with_new_height method.
5865         * tui/tui-data.h (struct tui_win_info)
5866         <do_make_visible_with_new_height, make_visible_with_new_height>:
5867         New methods.
5868         (struct tui_source_window_base, struct tui_data_window)
5869         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
5870         methods.
5871
5872 2019-06-25  Tom Tromey  <tom@tromey.com>
5873
5874         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
5875         method.
5876         (update_tab_width): Call update_tab_width method.
5877         * tui/tui-data.h (struct tui_win_info)
5878         (struct tui_source_window_base) <update_tab_width>: New methods.
5879
5880 2019-06-25  Tom Tromey  <tom@tromey.com>
5881
5882         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
5883         parameter.
5884         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
5885         parameter.
5886         (tui_gen_win_info::make_visible): Update.
5887         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
5888         parameter.
5889         * tui/tui-data.h (enum tui_box): New enum.
5890         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
5891
5892 2019-06-25  Tom Tromey  <tom@tromey.com>
5893
5894         * tui/tui-layout.c (make_source_or_disasm_window): Always use
5895         init_and_make_win for EXEC_INFO_WIN.
5896         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
5897         longer inline.
5898         (struct tui_win_info) <~tui_win_info>: Inline.
5899         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
5900         Don't declare.
5901         * tui/tui-data.c (source_win, disasm_win): Remove globals.
5902         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
5903         Remove.
5904         (tui_initialize_static_data): Update.
5905         (~tui_gen_win_info): Handle more cleanup here.
5906         (~tui_source_window_base): Delete "execution_info".
5907         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
5908
5909 2019-06-25  Tom Tromey  <tom@tromey.com>
5910
5911         * tui/tui-layout.c (make_command_window): Don't set
5912         can_highlight.
5913         (show_source_disasm_command): Call the reset method.
5914         (show_data): Don't set can_highlight.  Call the reset method.
5915         (tui_gen_win_info::reset): Rename from init_gen_win_info
5916         (init_and_make_win): Simplify.  Return tui_gen_win_info.
5917         (show_source_or_disasm_and_command): Call the reset method.
5918         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
5919         (struct tui_cmd_window): Set can_highlight.
5920
5921 2019-06-25  Tom Tromey  <tom@tromey.com>
5922
5923         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
5924         from make_visible.
5925         (tui_make_visible, tui_make_invisible): Rewrite.
5926         (tui_win_info::make_visible): Remove.
5927         (tui_source_window_base::make_visible): Update.
5928         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
5929         method.  Moved from...
5930         (struct tui_win_info) <make_visible>: ...here.
5931
5932 2019-06-25  Tom Tromey  <tom@tromey.com>
5933
5934         * tui/tui-winsource.c
5935         (tui_source_window_base::do_scroll_horizontal): Remove direction
5936         parameter.
5937         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
5938         direction parameter.
5939         * tui/tui-win.c (tui_win_info::forward_scroll)
5940         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
5941         (tui_win_info::right_scroll): Update.
5942         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
5943         direction parameter.
5944         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
5945         direction parameter.
5946         * tui/tui-data.h (enum tui_scroll_direction): Remove.
5947         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
5948         Remove direction parameter.
5949         (struct tui_source_window_base, struct tui_source_window)
5950         (struct tui_disasm_window, struct tui_data_window)
5951         (struct tui_cmd_window): Update.
5952
5953 2019-06-25  Tom Tromey  <tom@tromey.com>
5954
5955         * tui/tui-winsource.h (tui_set_exec_info_content)
5956         (tui_show_exec_info_content, tui_erase_exec_info_content)
5957         (tui_clear_exec_info_content, tui_update_exec_info): Change
5958         argument to tui_source_window_base.
5959         * tui/tui-winsource.c (tui_set_exec_info_content)
5960         (tui_show_exec_info_content, tui_erase_exec_info_content)
5961         (tui_clear_exec_info_content, tui_update_exec_info): Change
5962         argument to tui_source_window_base.
5963
5964 2019-06-25  Tom Tromey  <tom@tromey.com>
5965
5966         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
5967         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
5968
5969 2019-06-25  Tom Tromey  <tom@tromey.com>
5970
5971         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
5972         check.
5973
5974 2019-06-25  Tom Tromey  <tom@tromey.com>
5975
5976         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
5977         type to void.
5978         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
5979         type to void.
5980         * tui/tui-source.c (tui_set_source_content): Update.
5981         * tui/tui-disasm.c (tui_set_disassem_content): Update.
5982
5983 2019-06-25  Tom Tromey  <tom@tromey.com>
5984
5985         * tui/tui-win.c (window_name_completer, tui_set_focus)
5986         (tui_all_windows_info): Use name method.
5987         * tui/tui-data.h (struct tui_gen_win_info)
5988         (struct tui_source_window, struct tui_disasm_window)
5989         (struct tui_data_window, struct tui_cmd_window) <name>: New
5990         method.
5991         (tui_win_name): Don't declare.
5992         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
5993         (tui_win_name): Remove.
5994
5995 2019-06-25  Tom Tromey  <tom@tromey.com>
5996
5997         * tui/tui-winsource.h (tui_update_source_window)
5998         (tui_update_source_window_as_is): Change parameter type.
5999         * tui/tui-winsource.c (tui_update_source_window): Change win_info
6000         to be a tui_source_window_base.
6001         (tui_update_source_window_as_is): Likewise.
6002         * tui/tui-win.c (make_visible_with_new_height): Update.
6003
6004 2019-06-25  Tom Tromey  <tom@tromey.com>
6005
6006         * tui/tui-winsource.c (tui_erase_source_content)
6007         (tui_show_source_content, tui_show_exec_info_content)
6008         (tui_erase_exec_info_content): Use refresh_window method.
6009         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
6010         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
6011         from tui_refresh_win.
6012         (tui_data_window::refresh_window): New method.
6013         (tui_win_info::refresh, tui_source_window_base::refresh)
6014         (tui_refresh_all): Use refresh_window method.
6015         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
6016         method.
6017         * tui/tui-regs.c (tui_display_register): Call refresh_window
6018         method.
6019         * tui/tui-layout.c (show_source_disasm_command)
6020         (show_source_or_disasm_and_command): Call refresh_window method.
6021         * tui/tui-data.h (struct tui_gen_win_info)
6022         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
6023         New method.
6024
6025 2019-06-25  Tom Tromey  <tom@tromey.com>
6026
6027         * tui/tui.c (tui_rl_other_window, tui_enable)
6028         (tui_is_window_visible, tui_get_command_dimension): Update.
6029         * tui/tui-winsource.c (tui_update_source_window_as_is)
6030         (tui_clear_source_content, tui_erase_source_content)
6031         (tui_show_source_line, tui_source_window_base::refill)
6032         (tui_source_window_base::do_scroll_horizontal)
6033         (tui_source_window_base::set_is_exec_point_at)
6034         (tui_update_breakpoint_info, tui_set_exec_info_content)
6035         (tui_alloc_source_buffer, tui_line_is_displayed)
6036         (tui_addr_is_displayed): Update.
6037         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
6038         (tui_check_and_display_highlight_if_needed)
6039         (tui_win_info::make_visible, tui_win_info::refresh)
6040         (tui_refresh_all): Update.
6041         * tui/tui-windata.c (tui_first_data_item_displayed)
6042         (tui_delete_data_content_windows, tui_erase_data_content)
6043         (tui_display_all_data, tui_data_window::refresh_all)
6044         (tui_check_data_values): Update.
6045         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
6046         (tui_set_win_focus_to, tui_win_info::forward_scroll)
6047         (tui_win_info::backward_scroll, tui_refresh_all_win)
6048         (tui_resize_all, tui_set_focus, tui_all_windows_info)
6049         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
6050         (tui_source_window_base::set_new_height)
6051         (tui_data_window::set_new_height)
6052         (make_invisible_and_set_new_height)
6053         (make_visible_with_new_height, new_height_ok)
6054         (parse_scrolling_args): Update.
6055         * tui/tui-stack.c (tui_show_frame_info): Update.
6056         * tui/tui-source.c (tui_set_source_content)
6057         (tui_set_source_content_nil, tui_source_is_displayed)
6058         (tui_source_window::do_scroll_vertical): Update.
6059         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
6060         (tui_display_registers_from, tui_display_reg_element_at_line)
6061         (tui_check_register_values, tui_reg_command): Update.
6062         * tui/tui-layout.c (tui_default_win_height)
6063         (show_source_disasm_command, show_data, init_and_make_win)
6064         (show_source_or_disasm_and_command): Update.
6065         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
6066         (tui_redisplay_readline, tui_mld_flush)
6067         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
6068         (tui_getc): Update.
6069         * tui/tui-disasm.c (tui_set_disassem_content)
6070         (tui_disasm_window::do_scroll_vertical): Update.
6071         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
6072         Now virtual.
6073         (struct tui_win_info): Derive from tui_gen_win_info.
6074         <~tui_win_info>: Mark as override.
6075         <generic>: Remove member.
6076         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
6077         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
6078         (~tui_data_window, ~tui_win_info)
6079         (tui_free_all_source_wins_content): Update.
6080         * tui/tui-command.c (tui_refresh_cmd_win): Update.
6081
6082 2019-06-25  Tom Tromey  <tom@tromey.com>
6083
6084         * tui/tui-layout.c (init_and_make_win): Use new.
6085         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
6086         destructor, initializers.
6087         (tui_alloc_generic_win_info): Don't declare.
6088         * tui/tui-data.c (_locator): Add argument to constructor.
6089         (source_win, disasm_win): New globals.
6090         (exec_info): Remove.
6091         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
6092         Update.
6093         (tui_alloc_generic_win_info): Remove.
6094         (init_content_element): Use new.
6095         (tui_win_info::tui_win_info): Update.
6096         (free_content_elements) <case DATA_WIN>: Use delete.
6097
6098 2019-06-25  Tom Tromey  <tom@tromey.com>
6099
6100         * tui/tui-wingeneral.c (tui_refresh_win): Update.
6101         * tui/tui-windata.c (tui_first_data_item_displayed)
6102         (tui_delete_data_content_windows): Update.
6103         * tui/tui-win.c (tui_data_window::set_new_height): Update.
6104         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
6105         (tui_display_registers_from, tui_check_register_values): Update.
6106         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
6107         pointer.
6108         * tui/tui-data.c (init_content_element): Update.  Allocate the new
6109         window.
6110         (tui_free_data_content): Update.
6111         (free_content_elements) <case DATA_WIN>: Free the window.
6112
6113 2019-06-25  Tom Tromey  <tom@tromey.com>
6114
6115         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
6116         Update.
6117         * tui/tui-layout.c (make_command_window)
6118         (show_source_disasm_command, show_data, init_and_make_win)
6119         (show_source_or_disasm_and_command): Update.
6120         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
6121         method.
6122         <can_highight, is_highlighted>: Now bool.
6123         (tui_set_win_highlight): Don't declare.
6124         * tui/tui-data.c (tui_set_win_highlight): Remove.
6125
6126 2019-06-25  Tom Tromey  <tom@tromey.com>
6127
6128         * tui/tui-wingeneral.c (make_visible): Remove check of window
6129         type.
6130
6131 2019-06-25  Tom Tromey  <tom@tromey.com>
6132
6133         * tui/tui-win.c (tui_win_info::max_height)
6134         (tui_cmd_window::max_height): New methods.
6135         (new_height_ok): Call max_height.
6136         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
6137         <max_height>: New method.
6138
6139 2019-06-25  Tom Tromey  <tom@tromey.com>
6140
6141         * tui/tui-win.c (tui_source_window_base::set_new_height)
6142         (tui_data_window::set_new_height): New methods.
6143         (make_invisible_and_set_new_height): Call set_new_height method.
6144         * tui/tui-data.h (struct tui_win_info)
6145         (struct tui_source_window_base, struct tui_data_window)
6146         <set_new_height>: New method.
6147
6148 2019-06-25  Tom Tromey  <tom@tromey.com>
6149
6150         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
6151         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
6152         tui_refresh_data_win.
6153         * tui/tui-win.c (tui_source_window_base::refresh_all): New
6154         method.
6155         (tui_refresh_all_win): Call the refresh_all method.
6156         (tui_set_focus): Likewise.
6157         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
6158         (struct tui_source_window_base, struct tui_data_window) <refresh>:
6159         Likewise.
6160
6161 2019-06-25  Tom Tromey  <tom@tromey.com>
6162
6163         * tui/tui-winsource.h (tui_refill_source_window)
6164         (tui_set_is_exec_point_at): Don't declare.
6165         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
6166         (tui_source_window_base::refill): Rename from
6167         tui_refill_source_window.
6168         (tui_source_window_base::do_scroll_horizontal): Update.
6169         (tui_source_window_base::set_is_exec_point_at): Rename from
6170         tui_set_is_exec_point_at.
6171         (tui_update_all_breakpoint_info): Update.
6172         * tui/tui-stack.c (tui_show_frame_info): Update.
6173         * tui/tui-layout.c (show_data): Add cast.
6174         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
6175         * tui/tui-data.h (struct tui_source_window_base) <refill,
6176         set_is_exec_point_at>: New methods.
6177         (tui_source_windows, tui_add_to_source_windows): Update types.
6178         (tui_add_to_source_windows): Remove redundant declaration.
6179         * tui/tui-data.c (source_windows): Store tui_source_window_base.
6180         (tui_source_windows): Change return type.
6181         (tui_clear_source_windows_detail): Update.
6182         (tui_add_to_source_windows): Change type of parameter.
6183         (tui_free_all_source_wins_content): Update.
6184
6185 2019-06-25  Tom Tromey  <tom@tromey.com>
6186
6187         * tui/tui-wingeneral.c (tui_win_info::refresh)
6188         (tui_source_window_base::refresh): New methods.
6189         (tui_refresh_all): Call the refresh method.
6190         * tui/tui-data.h (struct tui_win_info)
6191         (struct tui_source_window_base) <refresh>: New method.
6192
6193 2019-06-25  Tom Tromey  <tom@tromey.com>
6194
6195         * tui/tui.h (tui_is_window_visible): Return bool.
6196         * tui/tui.c (tui_is_window_visible): Return bool.
6197         * tui/tui-wingeneral.c (tui_make_window, make_visible)
6198         (tui_make_visible, tui_make_invisible)
6199         (tui_win_info::make_visible)
6200         (tui_source_window_base::make_visible, make_all_visible)
6201         (tui_make_all_visible, tui_make_all_invisible): Update.
6202         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
6203         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
6204         bool.
6205         (struct tui_win_info, struct tui_source_window_base)
6206         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
6207         * tui/tui-data.c (tui_init_generic_part): Update.
6208
6209 2019-06-25  Tom Tromey  <tom@tromey.com>
6210
6211         * tui/tui-wingeneral.c (tui_win_info::make_visible)
6212         (tui_source_window_base::make_visible): New methods.
6213         (make_all_visible): Make method call.
6214         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
6215         (struct tui_source_window_base, struct tui_cmd_window): Override
6216         make_visible.
6217         (tui_win_is_source_type): Don't declare.
6218         * tui/tui-data.c (tui_win_is_source_type): Remove.
6219
6220 2019-06-25  Tom Tromey  <tom@tromey.com>
6221
6222         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
6223         NULL check.
6224
6225 2019-06-25  Tom Tromey  <tom@tromey.com>
6226
6227         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
6228         Inline constructor.  Add initializers for members.
6229         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
6230         constructors; now inline in class.
6231
6232 2019-06-25  Tom Tromey  <tom@tromey.com>
6233
6234         * tui/tui-regs.c (tui_show_registers): Update.
6235         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
6236         bool.
6237         * tui/tui-data.c (tui_data_window::clear_detail)
6238         (tui_data_window): Update.
6239
6240 2019-06-25  Tom Tromey  <tom@tromey.com>
6241
6242         * tui/tui-windata.c (tui_display_all_data)
6243         (tui_display_data_from_line, tui_display_data_from)
6244         (tui_check_data_values, tui_data_window::do_scroll_vertical):
6245         Update.
6246         * tui/tui-regs.c (tui_last_regs_line_no)
6247         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
6248         (tui_show_registers, tui_show_register_group)
6249         (tui_display_registers_from, tui_display_reg_element_at_line)
6250         (tui_display_registers_from_line, tui_check_register_values)
6251         (tui_reg_next, tui_reg_prev): Update.
6252         * tui/tui-layout.c (tui_set_layout, show_data): Update.
6253         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
6254         tui_data_window.
6255         (struct tui_win_info) <detail>: Remove.  Add new fields from
6256         tui_data_info.
6257         (TUI_DATA_WIN): Add cast.
6258         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
6259         (~tui_data_window): Simplify.
6260
6261 2019-06-25  Tom Tromey  <tom@tromey.com>
6262
6263         * tui/tui-layout.c (show_source_disasm_command)
6264         (show_source_or_disasm_and_command): Update.
6265         * tui/tui-io.c (update_cmdwin_start_line)
6266         (tui_redisplay_readline): Update.
6267         * tui/tui-data.h (struct tui_command_info): Remove.
6268         (struct tui_win_info) <detail>: Remove command_info member.
6269         (struct tui_data_window) <start_line>: New member, from
6270         tui_command_info.
6271         (TUI_CMD_WIN): Add casts.
6272
6273 2019-06-25  Tom Tromey  <tom@tromey.com>
6274
6275         * tui/tui-winsource.c (tui_update_source_window)
6276         (tui_refill_source_window)
6277         (tui_source_window_base::do_scroll_horizontal)
6278         (tui_update_breakpoint_info, tui_set_exec_info_content)
6279         (tui_show_exec_info_content, tui_erase_exec_info_content)
6280         (tui_clear_exec_info_content): Update.
6281         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
6282         Update.
6283         * tui/tui-win.c (make_invisible_and_set_new_height)
6284         (make_visible_with_new_height): Update.
6285         * tui/tui-source.c (tui_set_source_content)
6286         (tui_show_symtab_source): Update.
6287         * tui/tui-layout.c (extract_display_start_addr)
6288         (show_source_disasm_command, show_data)
6289         (make_source_or_disasm_window)
6290         (show_source_or_disasm_and_command): Update.
6291         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
6292         (tui_disasm_window::do_scroll_vertical): Remove shadowing
6293         "gdbarch".
6294         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
6295         to tui_source_window_base.
6296         (struct tui_win_info) <detail>: Remove source_info member.
6297         (struct tui_source_window_base) <has_locator>: Inline.
6298         Move contents from tui_source_info; rename has_locator member to
6299         m_has_locator.
6300         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
6301         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
6302         header file.
6303         (tui_source_window_base::clear_detail, ~tui_source_window_base):
6304         Simplify.
6305         (tui_free_all_source_wins_content): Cast to
6306         tui_source_window_base.
6307
6308 2019-06-25  Tom Tromey  <tom@tromey.com>
6309
6310         * tui/tui-win.c (make_invisible_and_set_new_height)
6311         (make_visible_with_new_height): Call has_locator method.
6312         * tui/tui-layout.c (show_source_disasm_command, show_data)
6313         (show_source_or_disasm_and_command): Update for bool change.
6314         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
6315         (tui_win_info) <has_locator>: New method.
6316         (struct tui_source_window_base) <has_locator>: New method.
6317         (tui_win_has_locator): Don't declare.
6318         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
6319         from tui_win_has_locator.
6320         (tui_source_window_base): Use false, not FALSE.
6321
6322 2019-06-25  Tom Tromey  <tom@tromey.com>
6323
6324         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
6325         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
6326         clear_detail method directly.
6327         (tui_clear_win_detail): Remove.
6328
6329 2019-06-25  Tom Tromey  <tom@tromey.com>
6330
6331         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
6332         "this", not TUI_DISASM_WIN.
6333
6334 2019-06-25  Tom Tromey  <tom@tromey.com>
6335
6336         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
6337         declare.
6338         * tui/tui-winsource.c
6339         (tui_source_window_base::do_scroll_horizontal): Rename from
6340         tui_horizontal_source_scroll.
6341         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
6342         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
6343         from tui_vertical_data_scroll.
6344         * tui/tui-win.h (tui_scroll): Don't declare.
6345         * tui/tui-win.c (tui_win_info::forward_scroll)
6346         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
6347         (tui_win_info::right_scroll): Rename and update.
6348         (tui_scroll_forward_command, tui_scroll_backward_command)
6349         (tui_scroll_left_command, tui_scroll_right_command): Update.
6350         (tui_scroll): Remove.
6351         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
6352         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
6353         from tui_vertical_source_scroll.
6354         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
6355         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
6356         from tui_vertical_disassem_scroll.
6357         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
6358         do_scroll_horizontal>: New methods.
6359         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
6360         Likewise.
6361         (struct tui_source_window_base): Add do_scroll_horizontal.
6362         (struct tui_source_window, struct tui_disasm_window): Add
6363         do_scroll_vertical.
6364         (struct tui_data_window, struct tui_cmd_window): Add
6365         do_scroll_horizontal and do_scroll_vertical.
6366         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
6367
6368 2019-06-25  Tom Tromey  <tom@tromey.com>
6369
6370         * tui/tui-data.h (struct tui_source_window_base): New struct.
6371         (struct tui_source_window): Derive from tui_source_window_base.
6372         (struct tui_disasm_window): New struct.
6373         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
6374         from tui_source_window::clear_detail.
6375         (tui_source_window_base): Rename from tui_source_window.
6376         (~tui_source_window_base): Rename from ~tui_source_window.
6377         (tui_alloc_win_info): Create a tui_disasm_window.
6378
6379 2019-06-25  Tom Tromey  <tom@tromey.com>
6380
6381         * tui/tui-data.h (struct tui_source_window)
6382         (struct tui_data_window): Declare destructors.
6383         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
6384         destructors.
6385         (tui_win_info): Simplify.
6386
6387 2019-06-25  Tom Tromey  <tom@tromey.com>
6388
6389         * tui/tui-winsource.c (tui_display_main)
6390         (tui_update_source_windows_with_addr)
6391         (tui_update_all_breakpoint_info): Update.
6392         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
6393         (new_height_ok, parse_scrolling_args): Update.
6394         * tui/tui-stack.c (tui_show_frame_info): Update.
6395         * tui/tui-data.h (struct tui_list): Remove.
6396         (tui_source_windows): Return a reference to a std::vector.
6397         * tui/tui-data.c (source_windows): Now a std::vector.
6398         (tui_source_windows): Change return type.
6399         (tui_clear_source_windows): Rewrite.
6400         (tui_clear_source_windows_detail, tui_add_to_source_windows)
6401         (tui_free_all_source_wins_content): Rewrite.
6402
6403 2019-06-25  Tom Tromey  <tom@tromey.com>
6404
6405         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
6406         (struct tui_data_window, struct tui_cmd_window): Declare
6407         clear_detail method.
6408         * tui/tui-data.c (tui_source_window::clear_detail)
6409         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
6410         methods.
6411         (tui_clear_win_detail): Simplify.
6412
6413 2019-06-25  Tom Tromey  <tom@tromey.com>
6414
6415         * tui/tui-layout.c (make_source_window, make_disasm_window)
6416         (make_source_or_disasm_window): Remove win_info_ptr parameter.
6417         Return the new window.
6418         (show_source_disasm_command, show_data)
6419         (show_source_or_disasm_and_command): Update.
6420
6421 2019-06-25  Tom Tromey  <tom@tromey.com>
6422
6423         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
6424         parameter.  Return the new window.
6425         (show_source_disasm_command): Update and remove NULL check.
6426         (show_source_or_disasm_and_command): Update.
6427
6428 2019-06-25  Tom Tromey  <tom@tromey.com>
6429
6430         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
6431
6432 2019-06-25  Tom Tromey  <tom@tromey.com>
6433
6434         * tui/tui-data.h (struct tui_win_info): Make constructor
6435         protected.  Make destructor virtual.  Add initializers.
6436         (tui_source_window, tui_data_window, tui_cmd_window): New
6437         classes.
6438         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
6439         constructor.  Add "type" parameter.
6440         (tui_source_window, tui_data_window, tui_cmd_window): New
6441         constructors.
6442         (tui_alloc_win_info): Instantiate the appropriate subclass.
6443
6444 2019-06-25  Tom Tromey  <tom@tromey.com>
6445
6446         * tui/tui-win.c (tui_resize_all): Use delete.
6447         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
6448         destructor.
6449         (tui_free_window): Don't declare.
6450         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
6451         Update.
6452
6453 2019-06-25  Tom Tromey  <tom@tromey.com>
6454
6455         * tui/tui-data.h (struct tui_win_info): Add constructor.
6456         * tui/tui-data.c (tui_alloc_win_info): Use new.
6457         (tui_free_window): Use delete.
6458
6459 2019-06-22  Tom Tromey  <tom@tromey.com>
6460
6461         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
6462         declare.
6463         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
6464
6465 2019-06-22  Tom Tromey  <tom@tromey.com>
6466
6467         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
6468         declare.
6469         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
6470
6471 2019-06-22  Tom de Vries  <tdevries@suse.de>
6472
6473         * dwarf2read.c (create_addrmap_from_aranges)
6474         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
6475         instead of '%zu'.
6476
6477 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
6478
6479         * dwarf2read.h (dwarf2_section_info_def): Remove.
6480         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
6481         * dwarf2read.c (struct dwo_sections) <types>: Change type to
6482         std::vector<dwarf2_section_info>.
6483         (struct dwo_file) <~dwo_file>: Remove.
6484         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
6485         types field.
6486         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
6487         (dwarf2_read_debug_names): Likewise.
6488         (create_debug_types_hash_table): Change parameter type to
6489         array_view, adjust code accordingly.
6490         (dwarf2_locate_dwo_sections): Adjust to std::vector.
6491         (partial_die_info::fixup): Likewise.
6492         (determine_prefix): Likewise.
6493         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
6494
6495 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
6496
6497         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
6498         gdb_bfd_ref_ptr.
6499         <~dwo_file>: Remove call to gdb_bfd_unref.
6500         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
6501         gdb_bfd_ref_ptr::get.
6502
6503 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
6504
6505         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
6506         type to htab_up.
6507         * dwarf2read.c (struct dwo_file): Initialize fields.
6508         <~dwo_file>: New.
6509         (free_dwo_file): Remove, move content to ~dwo_file.
6510         (struct dwo_file_deleter): Remove.
6511         (dwo_file_up>: Remove custom deleter.
6512         (free_dwo_files): Remove.
6513         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
6514         dwo_files.
6515         (process_skeletonless_type_units): Call unique_ptr::get.
6516         (allocate_dwo_file_hash_table): Add deleter to created hash
6517         table.  Change return type to htab_up.
6518         (lookup_dwo_file_slot): Don't memset dwo_file, call
6519         unique_ptr::get.
6520         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
6521         (create_dwo_unit_in_dwp_v2): Likewise.
6522         (open_and_init_dwo_file): Likewise.
6523         (free_dwo_file_from_slot): Remove.
6524
6525 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
6526
6527         * dwarf2read.h (struct dwarf2_section_info) <readin,
6528         is_virtual>: Change type to bool.
6529         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
6530         true instead of 1.
6531
6532 2019-06-19  Tom Tromey  <tom@tromey.com>
6533
6534         * tui/tui-data.h (tui_init_content_element): Don't declare.
6535
6536 2019-06-19  Tom Tromey  <tom@tromey.com>
6537
6538         * tui/tui-data.h (tui_init_win_info): Don't declare.
6539
6540 2019-06-19  Tom de Vries  <tdevries@suse.de>
6541
6542         * dwarf2read.h (abstract_to_concrete): Change type to
6543         std::unordered_map<sect_offset, std::vector<sect_offset>,
6544         gdb::hash_enum<sect_offset>>.
6545
6546 2019-06-19  Tom Tromey  <tromey@adacore.com>
6547
6548         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
6549         EVAL_AVOID_SIDE_EFFECTS specially.
6550
6551 2019-06-19  Tom Tromey  <tromey@adacore.com>
6552
6553         * source-cache.c (highlighter): New global.
6554         (source_cache::get_source_lines): Create a highlighter on demand.
6555
6556 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
6557
6558         * defs.h (deprecated_interactive_hook): Delete declaration.
6559         * interps.c (clear_interpreter_hooks): Remove use of
6560         deprecated_interactive_hook.
6561         * top.c (deprecated_interactive_hook): Delete definition.
6562         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
6563
6564 2019-06-18  Tom de Vries  <tdevries@suse.de>
6565
6566         PR gdb/24515
6567         * dwarf2read.h (abstract_to_concrete): Change type from
6568         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
6569         std::unordered_map<sect_offset, std::vector<sect_offset>>.
6570         * dwarf2read.c (read_variable): Update.
6571         (dwarf2_fetch_die_loc_sect_off): Update.
6572
6573 2019-06-17  Tom de Vries  <tdevries@suse.de>
6574
6575         PR gdb/24617
6576         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
6577         accessing parent[parent_len - 1].
6578
6579 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
6580
6581         PR gdb/24364
6582         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
6583         call dtrace_process_dof with NULL dof.
6584
6585 2019-06-16  Tom de Vries  <tdevries@suse.de>
6586
6587         PR gdb/24445
6588         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
6589
6590 2019-06-16  Tom Tromey  <tom@tromey.com>
6591
6592         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
6593         (make_all_visible): Use address of member.
6594
6595 2019-06-16  Tom Tromey  <tom@tromey.com>
6596
6597         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
6598         (tui_free_window, free_content, free_content_elements): Remove
6599         unnecessary cast.
6600         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
6601         cast.
6602         * tui/tui-regs.c (tui_show_register_group)
6603         (tui_display_registers_from, tui_display_reg_element_at_line):
6604         Remove unnecessary cast.
6605
6606 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
6607
6608         * linux-nat.c (normal_mask): Delete.
6609         (_initialize_linux_nat): Don't initialise normal_mask.
6610
6611 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
6612
6613         PR gdb/24445
6614         * dwarf-index-write.h (write_psymtabs_to_index): Add
6615         dwz_basename parameter.
6616         * dwarf-index-write.c (write_gdbindex): Move file writing to
6617         write_gdbindex_1.  Change return type void.
6618         (assert_file_size): Move up, remove filename parameter.
6619         (write_gdbindex_1): New function.
6620         (write_debug_names): Change return type to void, call
6621         assert_file_size.
6622         (struct index_wip_file): New struct.
6623         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
6624         file logic to index_wip_file.  Write index for dwz file if
6625         needed.
6626         (save_gdb_index_command): Pass basename of dwz file, if present.
6627         * dwarf-index-cache.c (index_cache::store): Obtain and pass
6628         build-id of dwz file, if present.
6629         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
6630         (dwarf2_get_dwz_file): Likewise.
6631         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
6632         (dwarf2_get_dwz_file): Likewise.
6633
6634 2019-06-16  Tom Tromey  <tom@tromey.com>
6635
6636         * coffread.c (process_coff_symbol): Use xstrdup.
6637         * value.c (create_internalvar): Use xstrdup.
6638
6639 2019-06-16  Tom Tromey  <tom@tromey.com>
6640
6641         * valops.c (value_cast, value_slice): Remove unnecessary cast.
6642         * breakpoint.c (stopin_command, stopat_command)
6643         (until_break_command, decode_location_default): Remove unnecessary
6644         cast.
6645         * utils.c (subset_compare): Remove unnecessary cast.
6646         * ada-lang.c (ada_update_initial_language): Remove unnecessary
6647         cast.
6648         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
6649         cast.
6650         * infcmd.c (path_command): Remove unnecessary cast.
6651         * coffread.c (decode_type): Remove unnecessary cast.
6652         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
6653         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
6654         * tui/tui-stack.c (tui_show_locator_content)
6655         (tui_show_frame_info): Remove unnecessary cast.
6656         * tui/tui-win.c (tui_scroll_forward_command)
6657         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
6658         (parse_scrolling_args): Remove unnecessary cast.
6659         * tui/tui-data.c (init_win_info, tui_del_window)
6660         (tui_free_window, tui_del_data_windows, tui_free_data_content)
6661         (free_content_elements): Remove unnecessary cast.
6662         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
6663         unnecessary cast.
6664         * tui/tui-source.c (tui_set_source_content)
6665         (tui_vertical_source_scroll): Remove unnecessary cast.
6666         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
6667         cast.
6668         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
6669         * tui/tui-regs.c (tui_display_registers_from)
6670         (tui_display_register): Remove unnecessary cast.
6671         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
6672         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
6673         (make_visible): Remove unnecessary cast.
6674         * tui/tui-winsource.c (tui_erase_source_content)
6675         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
6676         unnecessary cast.
6677         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
6678         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
6679         * stabsread.c (read_type, read_array_type, read_range_type):
6680         Remove unnecessary cast.
6681         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
6682         (parse_symbol, parse_type, upgrade_type, parse_external)
6683         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
6684         unnecessary cast.
6685         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
6686
6687 2019-06-16  Tom Tromey  <tom@tromey.com>
6688
6689         * tui/tui-data.c (tui_alloc_generic_win_info)
6690         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
6691         checks.
6692
6693 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
6694             Andrew Burgess  <andrew.burgess@embecosm.com>
6695
6696         * f-typeprint.c (f_print_type): Don't return early for not
6697         associated or not allocated types.
6698         (f_type_print_varspec_suffix): Add print_rank parameter and print
6699         ranks of array types in case they dangling.
6700         (f_type_print_base): Add print_rank parameter.
6701
6702 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
6703
6704         * NEWS: Mention new MI commands.
6705         * break-catch-throw.c (enum exception_event_kind): Move to
6706         breakpoint.h.
6707         (print_mention_exception_catchpoint): Output text as a single
6708         message.
6709         (catch_exception_command_1): Rename to...
6710         (catch_exception_event): ...this, make non-static, update header
6711         command, and change some parameter types.
6712         (catch_catch_command): Update for changes to
6713         catch_exception_command_1.
6714         (catch_throw_command): Likewise.
6715         (catch_rethrow_command): Likewise.
6716         * breakpoint.c (enum exception_event_kind): Delete.
6717         * breakpoint.h (enum exception_event_kind): Moved here from
6718         break-catch-throw.c.
6719         (catch_exception_event): Declare.
6720         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
6721         (mi_cmd_catch_throw): New function.
6722         (mi_cmd_catch_rethrow): New function.
6723         (mi_cmd_catch_catch): New function.
6724         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
6725         'catch-catch' entries.
6726         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
6727         (mi_cmd_catch_rethrow): Declare.
6728         (mi_cmd_catch_catch): Declare.
6729
6730 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
6731
6732         * annotate.c (annotate_source_line): Change return type to void,
6733         update implementation to match.
6734         * annotate.h (annotate_source_line): Change return type to void,
6735         update header comment.
6736         * stack.c (print_frame_info): Don't change what frame information
6737         is printed based on whether annotations are on or not.
6738
6739 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
6740
6741         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
6742         (annotate_source): Make static.
6743         (annotate_source_line): Moved from source.c and renamed from
6744         identify_source_line.  Update the return type.
6745         * annotate.h (annotate_source): Delete declaration.
6746         (annotate_source_line): Declaration moved from source.h, and
6747         renamed from identify_source_line.  Return type updated.
6748         * source.c (identify_source_line): Moved to annotate.c and renamed
6749         to annotate_source_line.
6750         (info_line_command): Remove check of annotation_level.
6751         * source.h (identify_source_line): Move declaration to annotate.h
6752         and rename to annotate_source_line.
6753         * stack.c: Add 'annotate.h' include.
6754         (print_frame_info): Remove check of annotation_level before
6755         calling annotate_source_line.
6756
6757 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
6758
6759         * source-cache.c (source_cache::get_plain_source_lines): Use
6760         open_source_file_with_line_charpos instead of just
6761         open_source_file, remove call to find_source_lines.
6762         (source_cache::get_source_lines): Likewise.
6763         * source.c (find_source_lines): Make static.
6764         (get_filename_and_charpos): Renamed into...
6765         (open_source_file_with_line_charpos): ..this along with changes to
6766         return a scoped_fd, and some other minor clean ups.
6767         (identify_source_line): Use open_source_file_with_line_charpos.
6768         (search_command_helper): Use open_source_file_with_line_charpos
6769         instead of just open_source_file, remove call to
6770         find_source_lines.
6771         * source.h (open_source_file_with_line_charpos): Declare new
6772         function.
6773         (find_source_lines): Delete declaration.
6774
6775 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
6776
6777         * source.c (get_filename_and_charpos): Remove fullname
6778         parameter.
6779         (identify_source_line): Update call to get_filename_and_charpos.
6780
6781 2019-06-14  Tom Tromey  <tromey@adacore.com>
6782
6783         PR gdb/24502:
6784         * ui-style.h (skip_ansi_escape): Update comment.
6785         * ui-file.h (class no_terminal_escape_file): New class.
6786         * ui-file.c (no_terminal_escape_file::write)
6787         (no_terminal_escape_file::puts): New methods.
6788         * cli/cli-logging.c (handle_redirections): Use
6789         no_terminal_escape_file.
6790
6791 2019-06-14  Tom Tromey  <tromey@adacore.com>
6792
6793         * NEWS: Move convenience variable news above Python news.
6794
6795 2019-06-14  Tom Tromey  <tom@tromey.com>
6796
6797         * gnulib: Move directory to top-level.
6798         * configure.ac: Don't configure gnulib.
6799         * configure: Rebuild.
6800         * common/common-defs.h: Use new path to gnulib.
6801         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
6802         (GNULIB_H): Remove.
6803         (INCGNU): Look in new gnulib location.
6804         (HFILES_NO_SRCDIR): Remove gnulib files.
6805         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
6806         (generated_files): Remove GNULIB_H.
6807         ($(LIBGNU), all-lib): Remove targets.
6808         (distclean): Don't mention GNULIB_BUILDDIR.
6809         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
6810
6811 2019-06-14  Tom Tromey  <tromey@adacore.com>
6812
6813         * symfile.c (add_symbol_file_command): Remove obsolete comment.
6814         Warn if symbol file does not provide any symbols.
6815
6816 2019-06-14  Tom Tromey  <tromey@adacore.com>
6817
6818         * source.c (find_and_open_source): Respect basenames_may_differ.
6819
6820 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
6821
6822         * annotate.c (annotate_breakpoints_invalid): Make use of
6823         scoped_restore_terminal_state.
6824         (annotate_frames_invalid): Likewise.
6825
6826 2019-06-14  Tom Tromey  <tromey@adacore.com>
6827
6828         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
6829         allow assignment to an internalvar.
6830
6831 2019-06-14  Tom Tromey  <tromey@adacore.com>
6832
6833         * ada-lex.l: Allow "_" in attribute names.
6834
6835 2019-06-14  Tom Tromey  <tromey@adacore.com>
6836
6837         PR gdb/24653:
6838         * regcache.c (registers_changed): Don't call alloca.
6839         * top.c (execute_command): Don't call alloca.
6840
6841 2019-06-13  Pedro Alves  <palves@redhat.com>
6842
6843         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
6844         'expression'.  When parsing an expression, error out if there's
6845         junk after "unlimited".
6846         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
6847         (do_set_command): Adjust calls to is_unlimited_literal.
6848
6849 2019-06-13  Pedro Alves  <palves@redhat.com>
6850
6851         * compile/compile.c (make_compile_options_def_group): Add braces
6852         around array_view initializer.
6853         * thread.c (make_thread_apply_all_options_def_group)
6854         (make_thread_apply_all_options_def_group): Likewise.
6855
6856 2019-06-13  Pedro Alves  <palves@redhat.com>
6857
6858         * NEWS (New commands): Mention "maint test-options
6859         require-delimiter", "maint test-options unknown-is-error", "maint
6860         test-options unknown-is-operand" and "maint show
6861         test-options-completion-result".
6862         (New command options, command completion): New section.
6863         (Completion improvements): New section.
6864         Mention that you can abbreviate "unlimited".
6865
6866 2019-06-13  Pedro Alves  <palves@redhat.com>
6867
6868         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
6869         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
6870         * unittests/cli-utils-selftests.c (test_parse_flags)
6871         (test_parse_flags_qcs): Delete.
6872         (test_cli_utils): Don't call deleted functions.
6873
6874 2019-06-13  Pedro Alves  <palves@redhat.com>
6875
6876         * thread.c: Include "cli/cli-option.h".
6877         (tp_array_compar_ascending): Global.
6878         (tp_array_compar): Delete function.
6879         (tp_array_compar_ascending, tp_array_compar_descending): New
6880         functions.
6881         (ascending_option_def, qcs_flag_option_def)
6882         (thr_qcs_flags_option_defs)
6883         (make_thread_apply_all_options_def_group)
6884         (make_thread_apply_options_def_group): New.
6885         (thread_apply_all_command): Use gdb::option::process_options.
6886         (thread_apply_command_completer)
6887         (thread_apply_all_command_completer): New.
6888         (thread_apply_command): Use gdb::option::process_options.
6889         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
6890         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
6891         to generate help text of "thread apply".  Adjust "taas"'s help.
6892         * tid-parse.c (tid_range_parser::in_thread_range): New method.
6893         * tid-parse.h (tid_range_parser::in_thread_range): New method.
6894
6895 2019-06-13  Pedro Alves  <palves@redhat.com>
6896
6897         * thread.c (thread_apply_command): Check for invalid TID with
6898         isdigit instead of !isalpha.
6899
6900 2019-06-13  Pedro Alves  <palves@redhat.com>
6901
6902         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
6903         (validate_flags_qcs): New.
6904         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
6905         (validate_flags_qcs): Declare.
6906         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
6907         (make_frame_apply_options_def_group): New.
6908         (frame_apply_command_count): Process options with
6909         gdb::option::process_options.
6910         (frame_apply_completer): New.
6911         (frame_apply_level_completer, frame_apply_all_completer)
6912         (frame_apply_completer): New.
6913         (_initialize_stack): Update help of "frame apply", "frame apply
6914         level", "frame apply all" and "faas" to mention supported options
6915         and install command completers.
6916         * stack.h (frame_apply_all_completer): Declare.
6917         * thread.c: Include "stack.h".
6918         (tfaas_command): Add "--".
6919         (_initialize_thread): Update help "tfaas" to mention supported
6920         options and install command completer.
6921
6922 2019-06-13  Pedro Alves  <palves@redhat.com>
6923
6924         * completer.c (complete_nested_command_line): New.
6925         (gdb_completion_word_break_characters_throw): Add assertion.
6926         * completer.h (complete_nested_command_line): Declare.
6927
6928 2019-06-13  Pedro Alves  <palves@redhat.com>
6929
6930         * stack.c (parse_backtrace_qualifiers): New.
6931         (backtrace_command): Use it.
6932         (backtrace_command_completer): Complete on qualifiers.
6933
6934 2019-06-13  Pedro Alves  <palves@redhat.com>
6935
6936         * frame.c: Include "cli/cli-option.h.
6937         (user_set_backtrace_options): New.
6938         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
6939         Delete.
6940         (get_prev_frame): Adjust.
6941         (boolean_option_def, uinteger_option_def)
6942         (set_backtrace_option_defs): New.
6943         (_initialize_frame): Adjust and use
6944         gdb::option::add_setshow_cmds_for_options to install "set
6945         backtrace past-main" and "set backtrace past-entry".
6946         * frame.h: Include "cli/cli-option.h".
6947         (struct frame_print_options): Forward declare.
6948         (print_frame_arguments_all, print_frame_arguments_scalars)
6949         (print_frame_arguments_none): Declare.
6950         (print_entry_values): Delete declaration.
6951         (struct frame_print_options, user_frame_print_options): New.
6952         (struct set_backtrace_options): New.
6953         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
6954         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
6955         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
6956         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
6957         (list_args_or_locals): Add frame_print_options parameter.
6958         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
6959         * python/py-framefilter.c (enumerate_args): Pass down
6960         USER_FRAME_PRINT_OPTIONS.
6961         * stack.c: Include "cli/cli-option.h".
6962         (print_frame_arguments_all, print_frame_arguments_scalars)
6963         (print_frame_arguments_none): Declare.
6964         (print_raw_frame_arguments, print_entry_values): Delete.
6965         (user_frame_print_options): New.
6966         (boolean_option_def, enum_option_def, frame_print_option_defs):
6967         New.
6968         (struct backtrace_cmd_options): New.
6969         (bt_flag_option_def): New.
6970         (backtrace_command_option_defs): New.
6971         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
6972         (print_frame_arg, read_frame_arg, print_frame_args)
6973         (print_frame_info, print_frame): Add frame_print_options parameter
6974         and use it.
6975         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
6976         (backtrace_command_1): Add frame_print_options and
6977         backtrace_cmd_options parameters and use them.
6978         (make_backtrace_options_def_group): New.
6979         (backtrace_command): Process command options with
6980         gdb::option::process_options.
6981         (backtrace_command_completer): New.
6982         (_initialize_stack): Extend "backtrace"'s help to mention
6983         supported options.  Install completer for "backtrace".
6984         Install some settings commands with add_setshow_cmds_for_options.
6985
6986 2019-06-13  Pedro Alves  <palves@redhat.com>
6987
6988         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
6989         and that "set/show print raw frame-arguments" are now deprecated.
6990
6991         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
6992         command.
6993         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
6994         * stack.c (_initialize_stack): Install "set/show print
6995         raw-frame-arguments", and deprecate "set/show print raw
6996         frame-arguments".
6997         * valprint.c (_initialize_valprint): Deprecate "set/show print
6998         raw".
6999
7000 2019-06-13  Pedro Alves  <palves@redhat.com>
7001
7002         * compile/compile.c (struct compile_options): New.
7003         (compile_flag_option_def, compile_command_option_defs)
7004         (make_compile_options_def_group): New.
7005         (compile_file_command): Handle options with
7006         gdb::option::process_options.
7007         (compile_file_command_completer): New function.
7008         (compile_code_command): Handle options with
7009         gdb::option::process_options.
7010         (compile_code_command_completer): New function.
7011         (_initialize_compiler): Install completers for "compile code" and
7012         "compile file".  Mention available options in "compile code" and
7013         "compile code"'s help.
7014         * completer.c (advance_to_completion_word): New, factored out from
7015         ...
7016         (advance_to_expression_complete_word_point): ... this.
7017         (advance_to_filename_complete_word_point): New.
7018         * completer.h (advance_to_filename_complete_word_point): New
7019         declaration.
7020
7021 2019-06-13  Pedro Alves  <palves@redhat.com>
7022
7023         * compile/compile.c: Include "cli/cli-option.h".
7024         (compile_print_value): Scope data pointer is now a
7025         value_print_options pointer; adjust.
7026         (compile_print_command): Process options.  Scope data pointer is
7027         now a value_print_options pointer; adjust.
7028         (_initialize_compile): Update "compile print"'s help to include
7029         supported options.  Install a completer for "compile print".
7030         * cp-valprint.c (show_vtblprint, show_objectprint)
7031         (show_static_field_print): Delete.
7032         (_initialize_cp_valprint): Don't install "set print
7033         static-members", "set print vtbl", "set print object" here.
7034         * printcmd.c: Include "cli/cli-option.h" and
7035         "common/gdb_optional.h".
7036         (print_command_parse_format): Rework to fill in a
7037         value_print_options instead of a format_data.
7038         (print_value): Change parameter type from format_data pointer to
7039         value_print_options reference.  Adjust.
7040         (print_command_1): Process options.  Adjust to pass down a
7041         value_print_options.
7042         (print_command_completer): New.
7043         (_initialize_printcmd): Install print_command_completer as
7044         handle_brkchars completer for the "print" command.  Update
7045         "print"'s help to include supported options.
7046         * valprint.c: Include "cli/cli-option.h".
7047         (show_vtblprint, show_objectprint, show_static_field_print): Moved
7048         here from cp-valprint.c.
7049         (boolean_option_def, uinteger_option_def)
7050         (value_print_option_defs, make_value_print_options_def_group):
7051         New.  Use gdb::option::add_setshow_cmds_for_options to install
7052         "set print elements", "set print null-stop", "set print repeats",
7053         "set print pretty", "set print union", "set print array", "set
7054         print address", "set print symbol", "set print array-indexes".
7055         * valprint.h: Include <string> and "cli/cli-option.h".
7056         (make_value_print_options_def_group): Declare.
7057         (print_value): Change parameter type from format_data pointer to
7058         value_print_options reference.
7059         (print_command_completer): Declare.
7060
7061 2019-06-13  Pedro Alves  <palves@redhat.com>
7062
7063         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
7064         (COMMON_SFILES): Add maint-test-settings.c.
7065         * cli/cli-decode.c (boolean_enums): New global, factored out from
7066         ...
7067         (add_setshow_boolean_cmd): ... here.
7068         * cli/cli-decode.h (boolean_enums): Declare.
7069         * cli/cli-option.c: New file.
7070         * cli/cli-option.h: New file.
7071         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
7072         factored out from ...
7073         (parse_cli_boolean_value(const char *)): ... this.
7074         (is_unlimited_literal): Change parameter type to pointer to
7075         pointer.  Adjust and advance ARG pointer.
7076         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
7077         (parse_cli_var_enum): New, factored out from ...
7078         (do_set_command): ... this.  Adjust.
7079         * cli/cli-setshow.h (parse_cli_boolean_value)
7080         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
7081         (parse_cli_var_enum): Declare.
7082         * cli/cli-utils.c: Include "cli/cli-option.h".
7083         (get_ulongest): New.
7084         * cli/cli-utils.h (get_ulongest): Declare.
7085         (check_for_argument): New overloads.
7086         * maint-test-options.c: New file.
7087
7088 2019-06-13  Pedro Alves  <palves@redhat.com>
7089
7090         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
7091         parse a range if "-" is at the end of the string.
7092
7093 2019-06-13  Pedro Alves  <palves@redhat.com>
7094
7095         * cli/cli-setshow.c (parse_auto_binary_operation)
7096         (parse_cli_boolean_value): Don't allow "o".
7097
7098 2019-06-13  Pedro Alves  <palves@redhat.com>
7099
7100         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
7101         * NEWS: Mention maint test-settings KIND.
7102         * maint-test-settings.c: New file.
7103
7104 2019-06-13  Pedro Alves  <palves@redhat.com>
7105
7106         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
7107         completer.
7108         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
7109         "set" completers.
7110
7111 2019-06-13  Pedro Alves  <palves@redhat.com>
7112
7113         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
7114         after item.
7115
7116 2019-06-13  Pedro Alves  <palves@redhat.com>
7117
7118         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
7119
7120 2019-06-13  Pedro Alves <palves@redhat.com>
7121
7122         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
7123         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
7124         call.
7125         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
7126         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
7127         calls.
7128         (check_for_argument): Skip spaces after argument.
7129
7130 2019-06-13  Pedro Alves  <palves@redhat.com>
7131
7132         * thread.c (thread_apply_command): Adjust TID parsing.
7133         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
7134         detected before end of string.
7135         (tid_is_in_list): Error out if LIST is invalid.
7136
7137 2019-06-13  Pedro Alves  <palves@redhat.com>
7138
7139         * completer.c (complete_line_internal_1): Rewind completion word
7140         point.
7141         (completion_tracker::advance_custom_word_point_by): Change
7142         parameter type to int.
7143         * completer.h (completion_tracker::advance_custom_word_point_by):
7144         Likewise.
7145
7146 2019-06-13  Pedro Alves  <palves@redhat.com>
7147
7148         * completer.c (advance_to_completion_word): Handle delimiters.
7149
7150 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
7151
7152         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
7153
7154 2019-06-11  Tom Tromey  <tom@tromey.com>
7155
7156         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
7157         (xmalloc_failed): Move to alloc.c.
7158         * alloc.c: New file.
7159         * Makefile.in (COMMON_SFILES): Add alloc.c.
7160
7161 2019-06-11  Tom Tromey  <tom@tromey.com>
7162
7163         * nat/linux-waitpid.c: Don't include server.h.
7164         (linux_debug): Remove.
7165         (my_waitpid): Update.
7166
7167 2019-06-11  Tom Tromey  <tromey@adacore.com>
7168
7169         * infcall.c (_initialize_infcall): Remove trailing newline from
7170         help.
7171         * user-regs.c (_initialize_user_regs): Remove trailing newline
7172         from help.
7173         * typeprint.c (_initialize_typeprint): Remove trailing newline
7174         from help.
7175         * reverse.c (_initialize_reverse): Remove trailing newlines from
7176         help.
7177         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
7178         from help.
7179         * language.c (add_set_language_command): Remove trailing newline
7180         from help.
7181         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
7182         help.
7183         * disasm.c (_initialize_disasm): Remove trailing newline from
7184         help.
7185         * top.c (init_main): Remove trailing newline from help.
7186         * interps.c (_initialize_interpreter): Remove trailing newline
7187         from help.
7188         * btrace.c (_initialize_btrace): Remove trailing newlines from
7189         help.
7190         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
7191         from help.
7192         * python/python.c (_initialize_python): Remove trailing newline
7193         from help.
7194         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
7195         help.
7196         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
7197         from help.  Reformat some text.
7198         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
7199         from help.
7200         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
7201         newline from help.
7202
7203 2019-06-11  Tom Tromey  <tromey@adacore.com>
7204
7205         * darwin-nat.c (darwin_decode_exception_message)
7206         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
7207
7208 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
7209
7210         * valops.c (value_slice): Check for not allocated or not
7211         associated values.
7212
7213 2019-06-10  Tom de Vries  <tdevries@suse.de>
7214
7215         PR gdb/24618
7216         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
7217         sure an empty slot (defined by a 32-bit zero pair) is recognized as
7218         invalid.
7219
7220 2019-06-10  Tom de Vries  <tdevries@suse.de>
7221
7222         PR gdb/24611
7223         * linespec.c (linespec_lexer_lex_string): Remove incorrect
7224         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
7225
7226 2019-06-10  Tom de Vries  <tdevries@suse.de>
7227
7228         PR symtab/24545
7229         * symtab.c (struct demangled_name_entry): Add language field.
7230         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
7231         static minimal symbol".  Set and use language field.
7232
7233 2019-06-10  Tom Tromey  <tromey@adacore.com>
7234
7235         * ada-lang.c (_initialize_ada_language): Update help text.
7236
7237 2019-06-10  Tom Tromey  <tromey@adacore.com>
7238
7239         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
7240         with a newline.
7241         * guile/guile.c (handle_boot_error): Don't end warning with a
7242         newline.
7243         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
7244         warning with a newline.
7245         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
7246         newline.
7247         (s12z_frame_cache): Likewise.
7248         * dwarf-index-cache.c (index_cache::store): Don't end warning with
7249         a newline.
7250         * solib-svr4.c (disable_probes_interface): Don't end warning with
7251         a newline.
7252         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
7253         newline.
7254         * python/python.c (do_finish_initialization): Don't end warning
7255         with a newline.
7256
7257 2019-06-10  Tom Tromey  <tom@tromey.com>
7258
7259         * python/py-breakpoint.c (gdbpy_breakpoint_created)
7260         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
7261         gdbpy_enter.
7262
7263 2019-06-10  Tom Tromey  <tromey@adacore.com>
7264
7265         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
7266         data.
7267         (elf_new_init): Don't call stabsread_new_init.
7268         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
7269         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
7270         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
7271
7272 2019-06-10  Tom de Vries  <tdevries@suse.de>
7273
7274         PR symtab/16264
7275         PR symtab/24517
7276         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
7277
7278 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
7279
7280         * source.c (find_and_open_source): Also rewrite relative file
7281         names.
7282
7283 2019-04-26  Amos Bird  <amosbird@gmail.com>
7284
7285         * annotate.c (annotate_thread_exited): Add "thread-exited"
7286         annotation.
7287
7288 2019-06-06  Tom Tromey  <tromey@adacore.com>
7289
7290         * maint.h (class scoped_command_stats): Use
7291         DISABLE_COPY_AND_ASSIGN.
7292         <print_time>: New method.
7293         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
7294         print_time.
7295         (scoped_command_stats::print_time): New method.
7296
7297 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
7298
7299         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
7300         instructions of lengths 6 or 8 bytes.
7301
7302 2019-06-04  Pedro Alves  <palves@redhat.com>
7303
7304         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
7305
7306         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
7307         * breakpoint.c (condition_completer): Likewise.
7308         * cli/cli-dump.c (scan_expression): Likewise.
7309         * common/filestuff.c (mkdir_recursive): Likewise.
7310         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
7311         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
7312         (gdb_abspath): Likewise.
7313         * compile/compile-cplus-types.c
7314         (compile_cplus_instance::decl_name): Likewise.
7315         * completer.c (complete_explicit_location):
7316         (signal_completer, reg_or_group_completer_1): Likewise.
7317         * cp-support.c (cp_remove_params_if_any): Likewise.
7318         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
7319         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
7320         * infcmd.c (strip_bg_char): Likewise.
7321         * linespec.c (copy_token_string): Likewise.
7322         * mi/mi-main.c (output_cores): Likewise.
7323         * psymtab.c (psymtab_search_name):
7324         * symfile.c (test_set_ext_lang_command): Likewise.
7325         * target.c (target_fileio_read_stralloc): Likewise.
7326         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
7327         * value.c (complete_internalvar): Likewise.
7328
7329 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
7330
7331         Add objfile property to gdb.Type.
7332         * NEWS: Mention Python API addition.
7333         * python/py-type.c (typy_get_objfile): New method.
7334
7335 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7336
7337         * NEWS: Mention the new set|show style [title|highlight].
7338         Mention changes to "show style", "help" and "apropos".
7339
7340 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7341
7342         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
7343         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
7344         instead of print_help_for_command.
7345         (print_doc_of_command): New function.
7346         (help_list): Add 'apropos -v word' suggestion.
7347         (print_help_for_command): Style the command name using title style.
7348         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
7349         (_initialize_cli_cmds): Describe -v in apropos_command help.
7350
7351 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7352
7353         * cli/cli-style.h (cli_style_option): Add name in constructor,
7354         add m_name class member, add constructor with intensity,
7355         add name class function.
7356         (cli_style_option::add_setshow_commands): Remove name argument.
7357         (highlight_style, title_style): New styles.
7358         * cli/cli-style.c (do_show): New function that shows a style
7359         characteristic styling the style name with itself.
7360         (set_style_name): New function.
7361         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
7362         Update all callers according to the changes in cli/cli-style.h.
7363         * utils.h (fputs_highlighted): New function.
7364         * utils.c (fputs_highlighted): Likewise.
7365
7366 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7367
7368         * NEWS: Mention new pipe command and new convenience variables.
7369
7370 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7371
7372         * cli/cli-cmds.c (pipe_command): New function.
7373         (_initialize_cli_cmds): Call add_com for pipe_command.
7374         Define | as an alias for pipe.
7375         (exit_status_set_internal_vars): New function.
7376         (shell_escape): Call exit_status_set_internal_vars.
7377         cli/cli-decode.c (find_command_name_length): Recognize | as
7378         a single character command.
7379
7380 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7381
7382         * gdbcmd.h (execute_command_to_ui_file): New declaration.
7383         top.c (execute_command_to_ui_file): New function, mostly a copy
7384         of execute_command_to_string.
7385         (execute_command_to_string): Implement by calling
7386         execute_command_to_ui_file.
7387
7388 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7389
7390         * top.h (saved_command_line): Remove declaration.
7391         * top.c (previous_saved_command_line, previous_repeat_arguments):
7392         New variables.
7393         (saved_command_line): Make static, define together with other
7394         'repeat variables'.
7395         (dont_repeat): Clear repeat_arguments.
7396         (repeat_previous, get_saved_command_line, save_command_line):
7397         New functions.
7398         (gdb_init): Initialize saved_command_line
7399         and previous_saved_command_line.
7400         * main.c (captured_main_1): Remove saved_command_line initialization.
7401         * event-top.c (handle_line_of_input): Update to use
7402         the new 'repeat' related functions instead of direct access to
7403         saved_command_line.
7404         * command.h (repeat_previous, get_saved_command_line,
7405         save_command_line): New declarations.
7406         (dont_repeat): Add comment.
7407
7408 2019-05-30  Tom Tromey  <tromey@adacore.com>
7409
7410         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
7411         Fix comment.
7412         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
7413
7414 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
7415
7416         PR cli/24587
7417         * completer.c (complete): Initialize variable word.
7418
7419 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
7420
7421         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
7422         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
7423         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
7424         'body' is NULL to the outter 'if', protecting the '!is_define'
7425         situation as well.
7426
7427 2019-05-29  Tom Tromey  <tromey@adacore.com>
7428
7429         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
7430         (dwarf_unknown): New function.
7431         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
7432         (dwarf_type_encoding_name): Use dwarf_unknown.
7433
7434 2019-05-29  Tom Tromey  <tromey@adacore.com>
7435
7436         PR c++/20020:
7437         * cp-valprint.c (cp_print_value_fields): Call
7438         cp_print_static_field inside "try".
7439
7440 2019-05-29  Tom Tromey  <tromey@adacore.com>
7441
7442         * inflow.c (struct terminal_info): Add default operator=.
7443         * configure: Rebuild.
7444         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
7445         -Wdeprecated-copy-dtor, -Wredundant-move.
7446
7447 2019-05-29  Tom Tromey  <tromey@adacore.com>
7448
7449         * NEWS: Add entry.
7450         * infcmd.c (print_return_value_1): Handle finish_print
7451         option.
7452         (show_print_finish): New function.
7453         (_initialize_infcmd): Add "set/show print finish" commands.
7454         * valprint.c (user_print_options): Initialize new member.
7455         * valprint.h (struct value_print_options) <finish_print>: New
7456         member.
7457
7458 2019-05-28  Tom Tromey  <tromey@adacore.com>
7459
7460         * ada-lang.c (ada_remove_Xbn_suffix)
7461         (find_old_style_renaming_symbol)
7462         (parse_old_style_renaming): Remove.
7463         (ada_find_renaming_symbol): Don't call
7464         find_old_style_renaming_symbol.
7465         (ada_is_renaming_symbol): Rename from
7466         ada_find_renaming_symbol.  Remove "block" parameter.  Return
7467         bool.  Now static.
7468         (ada_read_var_value): Update and simplify.
7469         * ada-exp.y (write_var_or_type): Remove old code.
7470
7471 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
7472
7473         PR gdb/25010
7474         * event-top.c: Remove include comment.
7475         * inflow.c (class scoped_ignore_sigttou): Move from here...
7476         * inflow.h (class scoped_ignore_sigttou): ...to here.
7477         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
7478         * top.c:  Remove include comment.
7479
7480 2019-05-27  Tom Tromey  <tom@tromey.com>
7481
7482         * NEWS: Fix typo.
7483
7484 2019-05-22  Tom Tromey  <tromey@adacore.com>
7485
7486         * target.c (target_follow_exec): Constify parameter.
7487         * target-delegates.c: Rebuild.
7488         * remote.c (remote_target::follow_exec): Constify parameter.
7489         * infrun.c (follow_exec): Constify parameter.
7490         * target.h (struct target_ops) <follow_exec>: Constify parameter.
7491         (target_follow_exec): Likewise.
7492
7493 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
7494
7495         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
7496         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
7497
7498 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
7499
7500         * NEWS: Add debugredirect and testsuite sections.
7501
7502 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
7503
7504         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
7505         target descriptions using exclusively floating point register name
7506         aliases.
7507
7508 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
7509
7510         PR gdb/18644:
7511         * f-lang.c (build_fortran_types): Handle the case where
7512         gdbarch_floatformat_for_type returns a nullptr.
7513
7514 2019-05-21  Tom de Vries  <tdevries@suse.de>
7515
7516         PR cli/24587
7517         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
7518
7519 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
7520
7521         PR gdb/18644:
7522         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
7523         16-byte floats.
7524         * i386-tdep.c (i386_floatformat_for_type): Use
7525         floatformats_ia64_quad for the 16-byte floating point component
7526         within a fortran 32-byte complex number.
7527
7528 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
7529
7530         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
7531         delete default constructor.
7532         (find_partial_die): Update to return const struct.
7533         (partial_die_parent_scope): Move variable declaration into scope
7534         of its use and change its type to auto.
7535         (guess_partial_die_structure_name): Likewise.
7536         (partial_die_info::fixup): Likewise.
7537
7538 2019-05-17  Tom Tromey  <tromey@adacore.com>
7539
7540         * source.c (find_and_open_source): Remove cast.
7541
7542 2019-05-17  Tom Tromey  <tromey@adacore.com>
7543
7544         * annotate.c (annotate_source): Make "filename" const.
7545         * annotate.h (annotate_source): Use const.
7546
7547 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
7548
7549         * disasm.c (set_disassembler_options): Send errors to stderr.
7550
7551 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
7552
7553         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
7554         (cli_interp_base::set_logging): Check debug_redirect.
7555         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
7556         * cli/cli-logging.c (debug_redirect): Add static variable.
7557         (pop_output_files): Add default param.
7558         (handle_redirections): Print debug setting.
7559         (show_logging_command): Likewise.
7560         (_initialize_cli_logging): Add debugredirect command.
7561         * interps.c (current_interp_set_logging): Add debug_redirect
7562         parameter.
7563         * interps.h (set_logging): Add debug_redirect parameter.
7564         (current_interp_set_logging): Likewise.
7565         * mi/mi-common.h: Likewise.
7566         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
7567
7568 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
7569             Tom Tromey  <tromey@adacore.com>
7570
7571         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
7572         directly.
7573         * cli/cli-interp.h (make_logging_output): Remove declaration.
7574         * cli/cli-logging.c (make_logging_output): Remove function.
7575         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
7576         directly.
7577         * ui-file.c (tee_file::tee_file): Remove bools.
7578         (tee_file::~tee_file): Remove deletes.
7579         * ui-file.h (tee_file): Remove bools.
7580
7581 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
7582
7583         * mi/mi-cmds.h (mi_cmd_complete): New function.
7584         * mi/mi-main.c (mi_cmd_complete): Likewise.
7585         * mi/mi-cmds.c: Define new MI command -complete.
7586         * NEWS: Mention new -complete command.
7587
7588 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
7589
7590         * completer.h (complete): New function.
7591         * completer.c (complete): Likewise.
7592         * cli/cli-cmds.c: (complete_command): Update to use new complete()
7593         function defined in completer.h.
7594
7595 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
7596
7597         * MAINTAINERS (Write After Approval): Add myself.
7598
7599 2019-05-17  Tom de Vries  <tdevries@suse.de>
7600
7601         PR gdb/24094
7602         * dwarf2read.c (struct cu_partial_die_info): New struct.
7603         (find_partial_die): Return cu_partial_die_info.
7604         (partial_die_parent_scope, guess_partial_die_structure_name)
7605         (partial_die_info::fixup): Handle new return type of find_partial_die.
7606
7607 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
7608
7609         PR breakpoints/24541
7610         * stap-probe.c (stap_parse_register_operand): Make "regname" an
7611         "std::string", simplifying the algorithm.
7612
7613 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
7614
7615         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
7616         (stap_static_probe_ops::get_probes): Likewise.
7617
7618 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
7619
7620         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
7621         '-')" and "else if".
7622         (stap_parse_single_operand): Join checks for
7623         "gdbarch_stap_parse_special_token_p" and
7624         "gdbarch_stap_parse_special_token" in the same "if" statement.
7625         Invert check when verifying for operation on register
7626         displacement.
7627
7628 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
7629
7630         * stap-probe.c (stap_get_opcode): Update comment.
7631         (stap_get_expected_argument_type): Likewise.
7632         (handle_stap_probe): Likewise.
7633
7634 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
7635
7636         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
7637         return type to 'bool'.  Adjust comment.  Use 'bool' when
7638         appropriate.
7639         (i386_stap_parse_special_token_three_arg_disp): Likewise.
7640         * stap-probe.c (stap_parse_argument_1): Likewise.
7641         (stap_is_operator): Likewise.
7642         (stap_is_generic_prefix): Likewise.
7643         (stap_is_register_prefix): Likewise.
7644         (stap_is_register_indirection_prefix): Likewise.
7645         (stap_is_integer_prefix): Likewise.
7646         (stap_generic_check_suffix): Likewise.
7647         (stap_check_integer_suffix): Likewise.
7648         (stap_check_register_suffix): Likewise.
7649         (stap_check_register_indirection_suffix): Likewise.
7650         (stap_parse_register_operand): Likewise.
7651         (stap_parse_single_operand): Likewise.
7652         (stap_parse_argument_1): Likewise.
7653         (stap_probe::get_argument_count): Likewise.
7654         (stap_is_operator): Likewise.
7655
7656 2019-05-16  Tom Tromey  <tromey@adacore.com>
7657
7658         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
7659         keyword to foreach.
7660
7661 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
7662
7663         * linux-thread-db.c (try_thread_db_load_1): Change return type
7664         to bool.
7665         (try_thread_db_load): Likewise.
7666         (try_thread_db_load_from_pdir_1): Likewise.
7667         (try_thread_db_load_from_pdir): Likewise.
7668         (try_thread_db_load_from_sdir): Likewise.
7669         (try_thread_db_load_from_dir): Likewise.
7670         (thread_db_load_search): Likewise.
7671         (has_libpthread): Likewise.
7672         (thread_db_load): Likewise.
7673
7674 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
7675
7676         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
7677         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
7678         NULL, and complain/return if that's the case.
7679
7680 2019-05-15  John Darrington <john@darrington.wattle.id.au>
7681
7682         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
7683         (advance, posn, abstract_read_memory): New functions.
7684         [struct mem_read_abstraction]: New struct.
7685         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
7686
7687 2019-05-14  Tom Tromey  <tromey@adacore.com>
7688
7689         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
7690         value is not lval_memory.
7691
7692 2019-05-14  Tom Tromey  <tromey@adacore.com>
7693
7694         * solib.c (info_sharedlibrary_command): Style the file name.
7695
7696 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
7697
7698         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
7699         (aarch64_vnv_type): Likewise.
7700         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
7701         * common/tdesc.c: Likewise.
7702         * common/tdesc.h (enum tdesc_type_kind): Likewise.
7703         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
7704         * features/aarch64-fpu.xml: Add ieee half view.
7705         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
7706         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
7707         * gdbtypes.h (struct builtin_type): Likewise.
7708         (struct objfile_type): Likewise.
7709
7710 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
7711
7712         * language.c (language_sniff_from_mangled_name): Fix "langauge"
7713         typo.
7714         * location.h (string_to_event_location): Likewise.
7715
7716 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
7717
7718         GDB 8.3 released.
7719
7720 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
7721
7722         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
7723         New variable declaration.
7724         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
7725         New variable.
7726         (print_one_breakpoint): Use ui_out::test_flags and new global
7727         variable to compute use_fixed_output.
7728         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
7729         Remove.
7730         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
7731         (mi_multi_location_breakpoint_output_fixed): Remove.
7732         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
7733         new variable.
7734         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
7735         fix_multi_location_breakpoint_output flag if version >= 3.
7736         * ui-out.h (enum ui_out_flag)
7737         <fix_multi_location_breakpoint_output>: New enumerator.
7738
7739 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
7740
7741         * contrib/cc-with-tweaks.sh: Validate dwz's work.
7742
7743 2019-05-10  Tom Tromey  <tromey@adacore.com>
7744
7745         * ada-lang.c (catch_ada_completer): New function.
7746         (_initialize_ada_language): Use it.
7747
7748 2019-05-10  Tom Tromey  <tromey@adacore.com>
7749
7750         * thread.c (print_thread_info): Make "requested_threads" const.
7751         * gdbthread.h (print_thread_info): Make "requested_threads"
7752         const.
7753         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
7754         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
7755
7756 2019-05-08  Tom Tromey  <tom@tromey.com>
7757
7758         * gdbtypes.c (objfile_type_data): Change type.
7759         (objfile_type, _initialize_gdbtypes): Update.
7760
7761 2019-05-08  Tom Tromey  <tom@tromey.com>
7762
7763         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
7764         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
7765         (_initialize_dwarf2_frame): Update.
7766
7767 2019-05-08  Tom Tromey  <tom@tromey.com>
7768
7769         * objc-lang.c (objc_objfile_data): Change type.
7770         (find_methods): Update.
7771         (_initialize_objc_lang): Remove.
7772
7773 2019-05-08  Tom Tromey  <tom@tromey.com>
7774
7775         * stabsread.c (rs6000_builtin_type_data): Change type.
7776         (rs6000_builtin_type, _initialize_stabsread): Update.
7777
7778 2019-05-08  Tom Tromey  <tom@tromey.com>
7779
7780         * mips-tdep.c (mips_pdr_data): Remove.
7781         (_initialize_mips_tdep): Update.
7782
7783 2019-05-08  Tom Tromey  <tom@tromey.com>
7784
7785         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
7786         (hppa_init_objfile_priv_data, read_unwind_info)
7787         (find_unwind_entry, _initialize_hppa_tdep): Update.
7788
7789 2019-05-08  Tom Tromey  <tom@tromey.com>
7790
7791         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
7792         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
7793         on obstack.
7794         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
7795
7796 2019-05-08  Tom Tromey  <tom@tromey.com>
7797
7798         * mdebugread.c (basic_type_data): Change type.
7799         (basic_type, _initialize_mdebugread): Update.
7800
7801 2019-05-08  Tom Tromey  <tom@tromey.com>
7802
7803         * common/gdb_unique_ptr.h (struct noop_deleter): New.
7804
7805 2019-05-08  Tom Tromey  <tom@tromey.com>
7806
7807         * nto-tdep.c (nto_inferior_data_reg): Change type.
7808         (nto_inferior_data): Update.
7809         (nto_inferior_data_cleanup, nto_new_inferior_data)
7810         (_initialize_nto_tdep): Remove.
7811         * nto-tdep.h (struct nto_inferior_data): Add initializers.
7812
7813 2019-05-08  Tom Tromey  <tom@tromey.com>
7814
7815         * ada-lang.c (struct ada_inferior_data): Add initializers.
7816         (ada_inferior_data): Change type.
7817         (ada_inferior_data_cleanup): Remove.
7818         (get_ada_inferior_data, ada_inferior_exit)
7819         (struct ada_pspace_data): Add initializers, destructor.
7820         (ada_pspace_data_handle): Change type.
7821         (get_ada_pspace_data): Update.
7822         (ada_pspace_data_cleanup): Remove.
7823
7824 2019-05-08  Tom Tromey  <tom@tromey.com>
7825
7826         * coffread.c (struct coff_symfile_info): Add initializers.
7827         (coff_objfile_data_key): Move lower.  Change type.
7828         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
7829         Update.
7830         (coff_free_info): Remove.
7831
7832 2019-05-08  Tom Tromey  <tom@tromey.com>
7833
7834         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
7835         (fbsd_pspace_data_handle): Move lower.  Change type.
7836         (get_fbsd_pspace_data): Update.
7837         (fbsd_pspace_data_cleanup): Remove.
7838         (_initialize_fbsd_tdep): Update.
7839
7840 2019-05-08  Tom Tromey  <tom@tromey.com>
7841
7842         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
7843         (get_ada_tasks_pspace_data): Update.
7844         (ada_tasks_pspace_data_cleanup): Remove.
7845         (_initialize_tasks): Update.
7846         (ada_tasks_inferior_data_handle): Change type.
7847         (get_ada_tasks_inferior_data): Update.
7848         (ada_tasks_inferior_data_cleanup): Remove.
7849         (struct ada_tasks_pspace_data): Add initializers.
7850
7851 2019-05-08  Tom Tromey  <tom@tromey.com>
7852
7853         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
7854         * symfile-debug.c (debug_sym_get_probes): Change type.
7855         * stap-probe.c (handle_stap_probe):
7856         (stap_static_probe_ops::get_probes): Change type.
7857         * probe.h (class static_probe_ops) <get_probes>: Change type.
7858         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
7859         (parse_probes_in_pspace): Update.
7860         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
7861         Update.
7862         (any_static_probe_ops::get_probes): Change type.
7863         * elfread.c (elfread_data): New typedef.
7864         (probe_key): Change type.
7865         (elf_get_probes): Likewise.  Update.
7866         (probe_key_free): Remove.
7867         (_initialize_elfread): Update.
7868         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
7869         Change type.
7870         (dtrace_process_dof_probe, dtrace_process_dof)
7871         (dtrace_static_probe_ops::get_probe): Change type.
7872
7873 2019-05-08  Tom Tromey  <tom@tromey.com>
7874
7875         * xcoffread.c (struct xcoff_symfile_info): Rename from
7876         coff_symfile_info.  Add initializers.
7877         (xcoff_objfile_data_key): Move lower.  Change type.
7878         (XCOFF_DATA): Rewrite.
7879         (xcoff_free_info): Remove.
7880         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
7881         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
7882         (xcoff_initial_scan): Update.
7883
7884 2019-05-08  Tom Tromey  <tom@tromey.com>
7885
7886         * solib-svr4.c (struct svr4_info): Add initializers and
7887         destructor.
7888         <probes_table>: Now an htab_up.
7889         (solib_svr4_pspace_data): Change type.
7890         (free_probes_table): Simplify.
7891         (~svr4_info): Rename from svr4_pspace_data_cleanup.
7892         (get_svr4_info, probes_table_htab_remove_objfile_probes)
7893         (probes_table_remove_objfile_probes, register_solib_event_probe)
7894         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
7895         (_initialize_svr4_solib): Update.
7896
7897 2019-05-08  Tom Tromey  <tom@tromey.com>
7898
7899         * remote.c (remote_pspace_data): Change type.
7900         (remote_pspace_data_cleanup): Remove.
7901         (get_remote_exec_file, set_pspace_remote_exec_file)
7902         (_initialize_remote): Update.
7903
7904 2019-05-08  Tom Tromey  <tom@tromey.com>
7905
7906         * breakpoint.c (breakpoint_objfile_key): Change type.
7907         (get_breakpoint_objfile_data): Update.
7908         (free_breakpoint_objfile_data): Remove.
7909         (_initialize_breakpoint): Update.
7910
7911 2019-05-08  Tom Tromey  <tom@tromey.com>
7912
7913         * linux-tdep.c (struct linux_info): Add initializers.
7914         (linux_inferior_data): Move.  Change type.
7915         (invalidate_linux_cache_inf): Update.
7916         (linux_inferior_data_cleanup): Remove.
7917         (get_linux_inferior_data, _initialize_linux_tdep): Update.
7918
7919 2019-05-08  Tom Tromey  <tom@tromey.com>
7920
7921         * auxv.c (auxv_inferior_data): Move.  Change type.
7922         (auxv_inferior_data_cleanup): Remove.
7923         (invalidate_auxv_cache_inf): Rewrite.
7924         (get_auxv_inferior_data, _initialize_auxv): Update.
7925
7926 2019-05-08  Tom Tromey  <tom@tromey.com>
7927
7928         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
7929         (symfile_debug_objfile_data_key): Change type.
7930         (symfile_debug_installed, debug_qf_has_symbols)
7931         (debug_qf_find_last_source_symtab)
7932         (debug_qf_forget_cached_source_info)
7933         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
7934         (debug_qf_print_stats, debug_qf_dump)
7935         (debug_qf_expand_symtabs_for_function)
7936         (debug_qf_expand_all_symtabs)
7937         (debug_qf_expand_symtabs_with_fullname)
7938         (debug_qf_map_matching_symbols)
7939         (debug_qf_expand_symtabs_matching)
7940         (debug_qf_find_pc_sect_compunit_symtab)
7941         (debug_qf_map_symbol_filenames)
7942         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
7943         (debug_sym_new_init, debug_sym_init, debug_sym_read)
7944         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
7945         (debug_sym_read_linetable, debug_sym_relocate): Update.
7946         (symfile_debug_free_objfile): Remove.
7947         (install_symfile_debug_logging, _initialize_symfile_debug):
7948         Update.
7949
7950 2019-05-08  Tom Tromey  <tom@tromey.com>
7951
7952         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
7953         allocate_on_obstack.
7954         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
7955         (get_dwarf2_per_objfile): Update.
7956         (set_dwarf2_per_objfile): Remove.
7957         (dwarf2_has_info, dwarf2_get_section_info): Update.
7958         (dwarf2_free_objfile): Remove.
7959         (_initialize_dwarf2_read): Update.
7960
7961 2019-05-08  Tom Tromey  <tom@tromey.com>
7962
7963         * auto-load.c (struct auto_load_pspace_info): Add destructor and
7964         initializers.
7965         <unsupported_script_warning_printed,
7966         script_not_found_warning_printed>: Now bool.
7967         (auto_load_pspace_data): Change type.
7968         (~auto_load_pspace_info): Rename from
7969         auto_load_pspace_data_cleanup.
7970         (get_auto_load_pspace_data, init_loaded_scripts_info)
7971         (clear_section_scripts, maybe_print_unsupported_script_warning)
7972         (maybe_print_script_not_found_warning, _initialize_auto_load):
7973         Update.
7974
7975 2019-05-08  Tom Tromey  <tom@tromey.com>
7976
7977         * objfiles.c (objfile_pspace_info): Add destructor and
7978         initializers.
7979         (objfiles_pspace_data): Change type.
7980         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
7981         (get_objfile_pspace_data): Update.
7982         (objfiles_bfd_data): Change type.
7983         (get_objfile_bfd_data): Update.
7984         (objfile_bfd_data_free, _initialize_objfiles): Remove.
7985
7986 2019-05-08  Tom Tromey  <tom@tromey.com>
7987
7988         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
7989         Change type.
7990         (get_catch_syscall_inferior_data): Update.
7991         (catch_syscall_inferior_data_cleanup): Remove.
7992         (_initialize_break_catch_syscall): Update.
7993
7994 2019-05-08  Tom Tromey  <tom@tromey.com>
7995
7996         * inflow.c (struct terminal_info): Add destructor and
7997         initializers.
7998         (inflow_inferior_data): Change type.
7999         (~terminal_info): Rename from inflow_inferior_data_cleanup.
8000         (get_inflow_inferior_data, inflow_inferior_exit)
8001         (swap_terminal_info, _initialize_inflow): Update.
8002
8003 2019-05-08  Tom Tromey  <tom@tromey.com>
8004
8005         * target-dcache.c (target_dcache_cleanup): Remove.
8006         (target_dcache_aspace_key): Change type.
8007         (target_dcache_init_p, target_dcache_invalidate)
8008         (target_dcache_get, target_dcache_get_or_init)
8009         (_initialize_target_dcache): Update.
8010         * dcache.h (struct dcache_deleter): New.
8011
8012 2019-05-08  Tom Tromey  <tom@tromey.com>
8013
8014         * symtab.c (struct symbol_cache): Add destructor and
8015         initializers.
8016         (symbol_cache_key): Move.  Change type.
8017         (make_symbol_cache, free_symbol_cache): Remove.
8018         (get_symbol_cache): Update.
8019         (symbol_cache_cleanup): Remove.
8020         (ALL_PSPACES, symbol_cache_flush)
8021         (maintenance_print_symbol_cache)
8022         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
8023         Update.
8024
8025 2019-05-08  Tom Tromey  <tom@tromey.com>
8026
8027         * symtab.c (struct main_info): Add destructor and initializers.
8028         (main_progspace_key): Move.  Change type.
8029         (get_main_info): Update.
8030         (main_info_cleanup): Remove.
8031         (_initialize_symtab): Update.
8032
8033 2019-05-08  Tom Tromey  <tom@tromey.com>
8034
8035         * registry.h (DECLARE_REGISTRY): Define the _key class.
8036
8037 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
8038
8039         * NEWS: Merge two 'New commands' sections.
8040
8041 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
8042
8043         * ada-valprint.c (ada_val_print_gnat_array): Remove language
8044         parameter and use Ada language definition instead.
8045         (ada_val_print_ptr): Remove unused language parameter.
8046         (ada_val_print_num): Remove language parameter and use Ada language
8047         definition instead.
8048         (ada_val_print_enum, ada_val_print_flt): Remove unused language
8049         parameter.
8050         (ada_val_print_struct_union, ada_val_print_ref): Remove language
8051         parameter and use Ada language definition instead.
8052         (ada_val_print_1): Update all ada_val_print_xxx calls.
8053         Remove language parameter.
8054         (ada_val_print): Update ada_val_print_1 call.
8055
8056 2019-05-08  Tom Tromey  <tromey@adacore.com>
8057
8058         * remote.c (remote_hw_watchpoint_limit)
8059         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
8060         Now static.
8061
8062 2019-05-08  Tom Tromey  <tromey@adacore.com>
8063
8064         * maint.c (_initialize_maint_cmds): Move initialization code to
8065         remote.c.
8066         (watchdog, show_watchdog): Move to remote.c.
8067         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
8068         "watchdog" static.
8069         (_initialize_remote): Move initialization code from maint.c.
8070         * defs.h (watchdog): Don't declare.
8071
8072 2019-05-08  Tom Tromey  <tromey@adacore.com>
8073
8074         * tui/tui-interp.c: Include main.h.
8075         * interps.c: Include main.h.
8076         * main.h (interpreter_p): Declare.
8077         * defs.h (interpreter_p): Don't declare.
8078
8079 2019-05-08  Tom Tromey  <tromey@adacore.com>
8080
8081         * dwarf2loc.c: Include dwarf2read.h.
8082         * defs.h (read_unsigned_leb128): Don't declare.
8083         * dwarf2read.h (read_unsigned_leb128): Declare.
8084
8085 2019-05-08  Tom Tromey  <tromey@adacore.com>
8086
8087         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
8088         method.
8089
8090 2019-05-08  Tom Tromey  <tromey@adacore.com>
8091
8092         * utils.c (fputs_maybe_filtered): Reset style after paging, even
8093         when no wrap column is set.
8094
8095 2019-05-08  Tom Tromey  <tromey@adacore.com>
8096
8097         * c-lang.c (c_get_string): Handle non-C-style arrays.
8098
8099 2019-05-08  Tom Tromey  <tromey@adacore.com>
8100
8101         * typeprint.c (print_offset_data::update): Print the bit offset,
8102         not the number of bits remaining.
8103
8104 2019-05-08  Tom Tromey  <tromey@adacore.com>
8105
8106         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
8107         padding at end of comment.
8108
8109 2019-05-08  Tom Tromey  <tromey@adacore.com>
8110
8111         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
8112         Compare main types.
8113
8114 2019-05-06  Tom Tromey  <tom@tromey.com>
8115
8116         * common/scoped_mmap.c: Include common-defs.h.
8117         * common/scoped_mmap.h: Don't include config.h.
8118
8119 2019-05-04  Tom Tromey  <tom@tromey.com>
8120
8121         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
8122         (struct aarch64_call_info): Add initializers.
8123         <si>: Now a std::vector.
8124         (pass_on_stack, aarch64_push_dummy_call): Update.
8125
8126 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
8127             Tom Tromey  <tom@tromey.com>
8128
8129         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
8130         (ppc_threads): Now a std::vector.  Now static.
8131         (hwdebug_find_thread_points_by_tid)
8132         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
8133         Update.
8134
8135 2019-05-04  Tom Tromey  <tom@tromey.com>
8136
8137         * arc-tdep.c (arc_tdesc_init): Return bool.
8138
8139 2019-05-04  Tom Tromey  <tom@tromey.com>
8140
8141         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
8142         Use gdb_assert_not_reached.
8143
8144 2019-05-04  Tom Tromey  <tom@tromey.com>
8145
8146         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
8147         "false".
8148
8149 2019-05-04  Tom Tromey  <tom@tromey.com>
8150
8151         * arc-tdep.c (arc_tdesc_init): Use bool.
8152
8153 2019-05-04  Tom Tromey  <tom@tromey.com>
8154
8155         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
8156
8157 2019-05-04  Tom Tromey  <tom@tromey.com>
8158
8159         * cli/cli-cmds.c (valid_command_p): Return bool.
8160
8161 2019-05-04  Tom Tromey  <tom@tromey.com>
8162
8163         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
8164         * command.h (valid_user_defined_cmd_name_p): Channge return type.
8165
8166 2019-05-04  Raul Tambre  <raul@tambre.ee>
8167
8168         * python/lib/gdb/prompt.py (_ExtendedPrompt)
8169         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
8170         operator for comparison.
8171
8172 2019-05-04  Tom Tromey  <tom@tromey.com>
8173
8174         * psymtab.c (psymbol_name_matches, match_partial_symbol)
8175         (lookup_partial_symbol, print_partial_symbols)
8176         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
8177         (psymbol_compare): Update.
8178         (add_psymbol_to_bcache): Clear the entire psymbol.
8179         (maintenance_check_psymtabs): Update.
8180         * psympriv.h (struct partial_symbol): Don't derive from
8181         general_symbol_info.
8182         <obj_section, unrelocated_address, address,
8183         set_unrelocated_address>: Update.
8184         <ginfo>: New member.
8185         * dwarf-index-write.c (write_psymbols, debug_names::insert)
8186         (debug_names::write_psymbols): Update.
8187
8188 2019-05-04  Tom de Vries  <tdevries@suse.de>
8189
8190         * contrib/cc-with-tweaks.sh: Support -n arg.
8191
8192 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8193
8194         * corelow.c (core_target::detach): Ensure frame cache and
8195         register caches are cleared.
8196         inferior.c (exit_inferior_1): Likewise.
8197
8198 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
8199             Tom Tromey  <tom@tromey.com>
8200
8201         * dictionary.c (collate_pending_symbols_by_language): Remove
8202         "struct" from foreach.
8203         * symtab.c (lookup_global_symbol_from_objfile)
8204         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
8205         foreach.
8206         * ser-tcp.c (net_open): Remove "struct" from foreach.
8207         * objfiles.c (objfile_relocate, objfile_rebase)
8208         (objfile_has_symbols): Remove "struct" from foreach.
8209         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
8210         from foreach.
8211         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
8212         foreach.
8213         * darwin-nat.c (thread_info_from_private_thread_info): Remove
8214         "struct" from foreach.
8215         * ada-lang.c (create_excep_cond_exprs)
8216         (ada_exception_catchpoint_cond_string): Remove "struct" from
8217         foreach.
8218
8219 2019-05-03  Tom Tromey  <tromey@adacore.com>
8220
8221         * ada-exp.y (convert_char_literal): Check suffix of each
8222         enumerator.
8223
8224 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
8225
8226         PR ada/21406:
8227         * ada-exp.y (yywrap): Don't define.
8228         * ada-lex.l (%option): Add noyywrap
8229         (yywrap): Remove.
8230
8231 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
8232
8233         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
8234         _WIN32_WINNT to the XP level, unless already defined to a higher
8235         level.
8236
8237         * unittests/parse-connection-spec-selftests.c:
8238         * ser-tcp.c:
8239         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
8240         override.
8241
8242         * symfile.c (find_separate_debug_file): Remove colon from the
8243         drive spec of DOS/Windows file names of the target, so that the
8244         file name produced from DEBUGDIR and the target's directory will
8245         be valid on DOS/Windows systems.
8246
8247 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
8248
8249         * rust-lang.c (val_print_struct): Handle printing structures
8250         containing strings.
8251
8252 2019-05-02  Tom Tromey  <tromey@adacore.com>
8253
8254         * valarith.c (_initialize_valarith): Remove.
8255
8256 2019-05-01  Tom Tromey  <tromey@adacore.com>
8257
8258         * ada-lang.c (ada_value_primitive_field): Treat more fields as
8259         bitfields.
8260
8261 2019-05-01  Tom Tromey  <tromey@adacore.com>
8262
8263         * ada-lang.c (ada_value_assign): Correctly compute starting offset
8264         for big-endian copies.
8265
8266 2019-04-30  Ali Tamur  <tamur@google.com>
8267         * gdb/dwarf2read.c (read_3_bytes): New declaration.
8268         (read_attribute_value): Added DW_FORM_strx1-4 cases.
8269         (read_3_bytes): New function.
8270
8271 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
8272
8273         * windows-nat.c (main_thread_id): Delete.
8274         (handle_output_debug_string): Replace main_thread_id by
8275         current_event.dwThreadId.
8276         (fake_create_process): Likewise.
8277         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
8278         Do not set main_thread_id.
8279         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
8280         current_event.dwThreadId.
8281         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
8282
8283 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
8284
8285         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
8286         Use current_event.dwThreadId instead of main_thread_id.
8287
8288 2019-04-30  Tom Tromey  <tromey@adacore.com>
8289
8290         * ada-lang.c (ada_lookup_simple_minsyms): New function.
8291         (create_excep_cond_exprs): Iterate over program spaces.
8292         (ada_exception_catchpoint_cond_string): Examine all minimal
8293         symbols for exception types.
8294
8295 2019-04-30  Tom Tromey  <tromey@adacore.com>
8296
8297         PR c++/24470:
8298         * dwarf2read.c (process_structure_scope): Handle case where type
8299         has template parameters but no symbol was created.
8300
8301 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8302             Chris January  <chris.january@arm.com>
8303
8304         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
8305         qualifier.
8306         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
8307
8308 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8309
8310         * f-typeprint.c (f_print_type): Update rules for printing
8311         whitespace.
8312         (f_type_print_varspec_suffix): Likewise.
8313
8314 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8315             Chris January  <chris.january@arm.com>
8316
8317         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
8318         function arguments.
8319
8320 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8321
8322         * f-lang.c (build_fortran_types): Change name of void type to
8323         lower case.
8324         * f-typeprint.c (f_type_print_base): Print the name of the void
8325         type, rather than a fixed string.
8326         * f-valprint.c (f_decorations): Use lower case void string.
8327
8328 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8329             Chris January  <chris.january@arm.com>
8330
8331         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
8332         types for Fortran.
8333
8334 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8335             Chris January  <chris.january@arm.com>
8336             David Lecomber  <david.lecomber@arm.com>
8337
8338         * f-exp.y (BINOP_INTRINSIC): New token.
8339         (exp): New parser rule handling BINOP_INTRINSIC.
8340         (f77_keywords): Add new builtin procedures.
8341         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
8342         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
8343         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
8344         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
8345         (print_unop_subexp_f): New function.
8346         (print_binop_subexp_f): New function.
8347         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
8348         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
8349         (dump_subexp_body_f): Likewise.
8350         (operator_check_f): Likewise.
8351         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
8352         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
8353
8354 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8355
8356         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
8357         UNOP_KIND.
8358         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
8359         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
8360         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
8361         (operator_length_f): New fuction.
8362         (print_subexp_f): New function.
8363         (op_name_f): New function.
8364         (dump_subexp_body_f): New function.
8365         (operator_check_f): New function.
8366         (exp_descriptor_f): Replace standard expression handling functions
8367         with new functions.
8368         * gdb/fortran-operator.def: New file.
8369         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
8370         * gdb/std-operator.def: Remove UNOP_KIND.
8371
8372 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8373
8374         * std-operator.def: Remove unbalanced, stray double quote
8375         character.
8376
8377 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
8378             Chris January  <chris.january@arm.com>
8379             Daniel Everett  <daniel.everett@arm.com>
8380             Nick Forrington  <nick.forrington@arm.com>
8381             Richard Bunt  <richard.bunt@arm.com>
8382
8383         * cp-valprint.c (cp_print_value_fields): Allow an additional level
8384         of depth when printing anonymous structs or unions.
8385         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
8386         Don't print either the top-level value, or the children if the
8387         max-depth is exceeded.
8388         (ppscm_print_children): When printing the key of a map, allow one
8389         extra level of depth.
8390         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
8391         print either the top-level value, or the children if the max-depth
8392         is exceeded.
8393         (print_children): When printing the key of a map, allow one extra
8394         level of depth.
8395         * python/py-value.c (valpy_format_string): Add max_depth keyword.
8396         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
8397         (user_print_options): Initialise max_depth field.
8398         (val_print_scalar_or_string_type_p): New function.
8399         (val_print): Check to see if the max depth has been reached.
8400         (val_print_check_max_depth): Define new function.
8401         (show_print_max_depth): New function.
8402         (_initialize_valprint): Add 'print max-depth' option.
8403         * valprint.h (struct value_print_options) <max_depth>: New field.
8404         (val_print_check_max_depth): Declare new function.
8405         * NEWS: Document new feature.
8406
8407 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
8408
8409         * ada-lang.c (ada_language_defn): Initialise new field.
8410         * c-lang.c (c_is_string_type_p): New function.
8411         (c_language_defn): Initialise new field.
8412         (cplus_language_defn): Initialise new field.
8413         (asm_language_defn): Initialise new field.
8414         (minimal_language_defn): Initialise new field.
8415         * c-lang.h (c_is_string_type_p): Declare new function.
8416         * d-lang.c (d_language_defn): Initialise new field.
8417         * f-lang.c (f_is_string_type_p): New function.
8418         (f_language_defn): Initialise new field.
8419         * go-lang.c (go_is_string_type_p): New function.
8420         (go_language_defn): Initialise new field.
8421         * language.c (default_is_string_type_p): New function.
8422         (unknown_language_defn): Initialise new field.
8423         (auto_language_defn): Initialise new field.
8424         * language.h (struct language_defn) <la_is_string_type_p>: New
8425         member variable.
8426         (default_is_string_type_p): Declare new function.
8427         * m2-lang.c (m2_language_defn): Initialise new field.
8428         * objc-lang.c (objc_language_defn): Initialise new field.
8429         * opencl-lang.c (opencl_language_defn): Initialise new field.
8430         * p-lang.c (pascal_is_string_type_p): New function.
8431         (pascal_language_defn): Initialise new field.
8432         * rust-lang.c (rust_is_string_type_p): New function.
8433         (rust_language_defn): Initialise new field.
8434
8435 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
8436
8437         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
8438         New field.
8439         * ada-lang.c (ada_language_defn): Initialise new field.
8440         * c-lang.c (c_language_defn): Likewise.
8441         (cplus_language_defn): Likewise.
8442         (asm_language_defn): Likewise.
8443         (minimal_language_defn): Likewise.
8444         * d-lang.c (d_language_defn): Likewise.
8445         * f-lang.c (f_language_defn): Likewise.
8446         * go-lang.c (go_language_defn): Likewise.
8447         * language.c (unknown_language_defn): Likewise.
8448         (auto_language_defn): Likewise.
8449         * m2-lang.c (m2_language_defn): Likewise.
8450         * objc-lang.c (objc_language_defn): Likewise.
8451         * opencl-lang.c (opencl_language_defn): Likewise.
8452         * p-lang.c (pascal_language_defn): Likewise.
8453         * rust-lang.c (rust_language_defn): Likewise.
8454
8455 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
8456
8457         * ada-lang.c (ada_is_character_type): Change return type to bool.
8458         (ada_is_string_type): Likewise.
8459         * ada-lang.h (ada_is_character_type): Update declaration
8460         (ada_is_string_type): Likewise.
8461
8462 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8463
8464         Support style in 'frame|thread apply'
8465
8466         * gdbcmd.h (execute_command_to_string): New term_out parameter.
8467         * record.c (record_start, record_stop): Update callers of
8468         execute_command_to_string with false.
8469         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
8470         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
8471         methods.
8472         (class string_file): New constructor with term_out parameter.
8473         Override methods term_out and can_emit_style_escape.  New member
8474         term_out.
8475         (class stdio_file): Override can_emit_style_escape.
8476         (class tee_file): Override term_out and can_emit_style_escape.
8477         * utils.h (can_emit_style_escape): Remove.
8478         * utils.c (can_emit_style_escape): Likewise.
8479         Update all callers of can_emit_style_escape (SOMESTREAM) to
8480         SOMESTREAM->can_emit_style_escape.
8481         * source-cache.c (source_cache::get_source_lines): Likewise.
8482         * stack.c (frame_apply_command_count): Call execute_command_to_string
8483         passing the term_out characteristic of the current gdb_stdout.
8484         * thread.c (thr_try_catch_cmd): Likewise.
8485         * top.c (execute_command_to_string): pass term_out parameter
8486         to construct the string_file for the command output.
8487         * ui-file.c (term_cli_styling): New function (most code moved
8488         from utils.c can_emit_style_escape).
8489         (string_file::string_file, string_file::can_emit_style_escape,
8490         stdio_file::can_emit_style_escape, tee_file::term_out,
8491         tee_file::can_emit_style_escape): New functions.
8492
8493 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8494
8495         * NEWS: Mention the new set|show may-call-functions.
8496         * infcall.c (may_call_functions_p): New variable.
8497         (show_may_call_functions_p): New function.
8498         (call_function_by_hand_dummy): Throws an error if not
8499         may-call-functions.
8500         (_initialize_infcall): Call add_setshow_boolean_cmd for
8501         may-call-functions.
8502
8503 2019-04-25  Keith Seitz  <keiths@redhat.com>
8504
8505         PR c++/24367
8506         * cp-support.c (inspect_type): Don't attempt substitutions
8507         of symbol with the same name.
8508
8509 2019-04-25  Tom Tromey  <tromey@adacore.com>
8510
8511         PR gdb/24475:
8512         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
8513         static.
8514
8515 2019-04-25  Tom Tromey  <tromey@adacore.com>
8516
8517         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
8518         rvalue reference.
8519         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
8520         (gdb_xml_parser::parse): Use std::move.
8521         * python/python-internal.h (gdbpy_convert_exception): Take a const
8522         reference.
8523         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
8524         std::move.
8525         * python/py-utils.c (gdbpy_convert_exception): Take a const
8526         reference.
8527         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
8528         Use std::move.
8529         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
8530         Use std::move.
8531         * mi/mi-main.c (mi_print_exception): Take a const reference.
8532         * main.c (handle_command_errors): Take a const reference.
8533         * linespec.c (parse_linespec): Use std::move.
8534         * infcall.c (run_inferior_call): Use std::move.
8535         (call_function_by_hand_dummy): Use std::move.
8536         * exec.c (try_open_exec_file): Use std::move.
8537         * exceptions.h (exception_print, exception_fprintf)
8538         (exception_print_same): Update.
8539         * exceptions.c (print_exception, exception_print)
8540         (exception_fprintf, exception_print_same): Change parameters to
8541         const reference.
8542         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
8543         * common/new-op.c: Use std::move.
8544         * common/common-exceptions.h (struct gdb_exception): Add move
8545         constructor.
8546         (struct gdb_exception_error, struct gdb_exception_quit, struct
8547         gdb_quit_bad_alloc): Change constructor to move constructor.
8548         (throw_exception): Change parameter to rvalue reference.
8549         * common/common-exceptions.c (throw_exception): Take rvalue
8550         reference.
8551         * cli/cli-interp.c (safe_execute_command): Use std::move.
8552         * breakpoint.c (insert_bp_location, location_to_sals): Use
8553         std::move.
8554
8555 2019-04-25  Tom Tromey  <tromey@adacore.com>
8556
8557         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
8558         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
8559         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
8560         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
8561         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
8562         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
8563         guile/scm-value.c: Use unpack.
8564         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
8565         gdbscm_gdb_exception.
8566         (gdbscm_throw_gdb_exception): Likewise.
8567         (struct gdbscm_gdb_exception): New.
8568         (unpack): New function.
8569         (gdbscm_wrap): Use unpack.
8570
8571 2019-04-25  Tom Tromey  <tromey@adacore.com>
8572
8573         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
8574         (gdb_rl_callback_handler): Use std::move.
8575         * common/common-exceptions.h (struct gdb_exception): Add move
8576         assignment operator.
8577         (throw_exception_sjlj): Change "exception" to const reference.
8578         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
8579         (throw_exception_sjlj): Change "exception" to const reference.
8580
8581 2019-04-25  Tom Tromey  <tromey@adacore.com>
8582
8583         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
8584         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
8585         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
8586         Update.
8587         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
8588         Update.
8589         * mi/mi-interp.c (mi_interp::exec): Update.
8590         * linespec.c (parse_linespec): Update.
8591         * infcall.c (run_inferior_call): Update.
8592         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
8593         * guile/scm-symbol.c (gdbscm_lookup_symbol)
8594         (gdbscm_lookup_global_symbol): Update.
8595         * guile/scm-param.c (gdbscm_parameter_value): Update.
8596         * guile/scm-frame.c (gdbscm_frame_read_register)
8597         (gdbscm_frame_read_var): Update.
8598         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
8599         * exec.c (try_open_exec_file): Update.
8600         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
8601         (gdb_rl_callback_handler): Update.
8602         * common/common-exceptions.h (exception_none): Don't declare.
8603         * common/common-exceptions.c (exception_none): Don't define.
8604         (struct catcher) <exception>: Update.
8605         * cli/cli-interp.c (safe_execute_command): Update.
8606         * breakpoint.c (insert_bp_location, location_to_sals): Update.
8607
8608 2019-04-25  Ali Tamur  <tamur@google.com>
8609
8610         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
8611         (read_attribute_value): Likewise.
8612         (dwarf2_read_addr_index): Update comment.
8613         (read_str_index): Add DW_FORM_strx.
8614         (dwarf2_string_attr): Likewise.
8615         (dwarf2_const_value_attr): Likewise.
8616         (dump_die_shallow): Likewise.
8617         (dwarf2_fetch_constant_bytes): Likewise.
8618         (skip_form_bytes): Likewise.
8619         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
8620
8621 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
8622
8623         PR corefiles/11608
8624         PR corefiles/18187
8625         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
8626         OFFSET.  Verify if current mapping contains an ELF header.
8627         (linux_find_memory_regions_full): Adjust call to
8628         dump_mapping_p.
8629
8630 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
8631             Kang Li <kanglictf@gmail.com>
8632
8633         PR gdb/21600
8634
8635         * dwarf2-frame.c (read_initial_length): Be consistent about using
8636         unsigned representation of length.
8637         (decode_frame_entry_1): Likewise.  Check for wraparound of
8638         end pointer as well as buffer overflow.
8639
8640 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
8641
8642         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
8643         "vq".
8644
8645 2019-04-24  Tom Tromey  <tromey@adacore.com>
8646
8647         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
8648
8649 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8650
8651         * s12z-tdep.c (s12z_unwind_pc): Delete.
8652         (s12z_unwind_sp): Delete.
8653         (s12z_gdbarch_init): Don't register deleted functions with
8654         gdbarch.
8655
8656 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8657
8658         * rl78-tdep.c (rl78_unwind_sp): Delete.
8659         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
8660
8661 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8662
8663         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
8664         (xstormy16_unwind_pc): Delete.
8665         (xstormy16_dummy_id): Delete.
8666         (xstormy16_gdbarch_init): Don't register deleted functions with
8667         gdbarch.
8668
8669 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8670
8671         * vax-tdep.c (vax_unwind_pc): Delete.
8672         (vax_gdbarch_init): Don't register deleted function with gdbarch.
8673
8674 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8675
8676         * v850-tdep.c (v850_unwind_sp): Delete.
8677         (v850_unwind_pc): Delete.
8678         (v850_dummy_id): Delete.
8679         (v850_gdbarch_init): Don't register deleted functions with
8680         gdbarch.
8681
8682 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8683
8684         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
8685         (tilegx_unwind_pc): Delete.
8686         (tilegx_unwind_dummy_id): Delete.
8687         (tilegx_gdbarch_init): Don't register deleted functions with
8688         gdbarch.
8689
8690 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8691
8692         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
8693         (tic6x_dummy_id): Delete.
8694         (tic6x_gdbarch_init): Don't register deleted functions with
8695         gdbarch.
8696
8697 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8698
8699         * sparc-tdep.c (sparc_unwind_pc): Delete.
8700         (sparc32_gdbarch_init): Don't register deleted function with
8701         gdbarch.
8702
8703 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8704
8705         * sh-tdep.c (sh_unwind_sp): Delete.
8706         (sh_unwind_pc): Delete.
8707         (sh_dummy_id): Delete.
8708         (sh_gdbarch_init): Don't register deleted functions with
8709         gdbarch.
8710
8711 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8712
8713         * score-tdep.c (score_unwind_sp): Delete.
8714         (score_unwind_pc): Delete.
8715         (score_dummy_id): Delete.
8716         (score_gdbarch_init): Don't register deleted functions with
8717         gdbarch.
8718
8719 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8720
8721         * rx-tdep.c (rx_unwind_pc): Delete.
8722         (rx_unwind_sp): Delete.
8723         (rx_dummy_id): Delete.
8724         (rx_gdbarch_init): Don't register deleted functions with
8725         gdbarch.  Update comment.
8726
8727 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8728
8729         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
8730         (rs6000_dummy_id): Delete.
8731         (rs6000_gdbarch_init): Don't register deleted functions with
8732         gdbarch.
8733
8734 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8735
8736         * or1k-tdep.c (or1k_dummy_id): Delete.
8737         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
8738
8739 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8740
8741         * nios2-tdep.c (nios2_dummy_id): Delete.
8742         (nios2_unwind_sp): Delete.
8743         (nios2_gdbarch_init): Don't register deleted functions with
8744         gdbarch.
8745
8746 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8747
8748         * nds32-tdep.c (nds32_dummy_id): Delete.
8749         (nds32_unwind_pc): Delete.
8750         (nds32_unwind_sp): Delete.
8751         (nds32_gdbarch_init): Don't register deleted functions with
8752         gdbarch.
8753
8754 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8755
8756         * msp430-tdep.c (msp430_unwind_pc): Delete.
8757         (msp430_unwind_sp): Delete.
8758         (msp430_dummy_id): Delete.
8759         (msp430_gdbarch_init): Don't register deleted functions with
8760         gdbarch.
8761
8762 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8763
8764         * moxie-tdep.c (moxie_unwind_sp): Delete.
8765         (moxie_unwind_pc): Delete.
8766         (moxie_dummy_id): Delete.
8767         (moxie_gdbarch_init): Don't register deleted functions with
8768         gdbarch.
8769
8770 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8771
8772         * mn10300-tdep.c (mn10300_dummy_id): Delete.
8773         (mn10300_unwind_pc): Delete.
8774         (mn10300_unwind_sp): Delete.
8775         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
8776         mn10300_unwind_sp.
8777         (mn10300_frame_unwind_init): Don't register deleted functions with
8778         gdbarch.
8779
8780 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8781
8782         * mep-tdep.c (mep_unwind_pc): Delete.
8783         (mep_unwind_sp): Delete.
8784         (mep_dummy_id): Delete.
8785         (mep_gdbarch_init): Don't register deleted functions with
8786         gdbarch.
8787
8788 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8789
8790         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
8791         (m68hc11_unwind_sp): Delete.
8792         (m68hc11_gdbarch_init): Don't register deleted functions with
8793         gdbarch.
8794
8795 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8796
8797         * m32r-tdep.c (m32r_unwind_sp): Delete.
8798         (m32r_unwind_pc): Delete.
8799         (m32r_dummy_id): Delete.
8800         (m32r_gdbarch_init): Don't register deleted functions with
8801         gdbarch.
8802
8803 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8804
8805         * m32c-tdep.c (m32c_unwind_pc): Delete.
8806         (m32c_unwind_sp): Delete.
8807         (m32c_dummy_id): Delete.
8808         (m32c_gdbarch_init): Don't register deleted functions with
8809         gdbarch.
8810
8811 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8812
8813         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
8814         (lm32_unwind_pc): Delete.
8815         (lm32_dummy_id): Delete.
8816         (lm32_gdbarch_init): Don't register deleted functions with
8817         gdbarch.
8818
8819 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8820
8821         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
8822         (iq2000_unwind_pc): Delete.
8823         (iq2000_dummy_id): Delete.
8824         (iq2000_gdbarch_init): Don't register deleted functions with
8825         gdbarch.
8826
8827 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8828
8829         * nds32-tdep.c (nds32_type_align): Delete.
8830         (nds32_push_dummy_call): Use type_align instead.
8831
8832 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8833
8834         * arm-tdep.c (arm_type_align): Only handle vector override case.
8835         (arm_push_dummy_call): Use type_align.
8836         (arm_gdbarch_init): Register arm_type_align gdbarch function.
8837
8838 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8839
8840         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
8841         case.
8842         (pass_on_stack): Use type_align.
8843         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
8844         function.
8845
8846 2019-04-23  Tom Tromey  <tromey@adacore.com>
8847
8848         * dwarf2read.c (line_header::file_name_at): Remove unused
8849         overload.
8850
8851 2019-04-23  Tom de Vries  <tdevries@suse.de>
8852
8853         PR gdb/24438
8854         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
8855         invocation.
8856
8857
8858 2019-03-27  Ali Tamur  <tamur@google.com>
8859
8860         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
8861         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
8862         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
8863         (dwarf_expr_context::get_addr_index): Likewise
8864         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
8865         (symbol_needs_eval_context::get_addr_index): Likewise
8866         (disassemble_dwarf_expression): Add DW_OP_addrx
8867         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
8868         (read_cutu_die_from_dwo): Update comment
8869         (skip_one_die): Add DW_FORM_addrx
8870         (read_attribute_value): Likewise
8871         (var_decode_location): Add DW_OP_addrx
8872         (dwarf2_const_value_attr): Add DW_FORM_addrx
8873         (dump_die_shallow): Likewise
8874         (dwarf2_fetch_constant_bytes): Likewise
8875         (decode_locdesc): Add DW_OP_addrx
8876         (skip_form_bytes): Add DW_FORM_addrx
8877
8878 2019-04-22  Ali Tamur  <tamur@google.com>
8879
8880         * MAINTAINERS (Write After Approval): Add self.
8881
8882 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
8883
8884         * solib-svr4.c (get_svr4_info): Add pspace parameter.
8885         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
8886         (open_symbol_file_object): Likewise.
8887         (svr4_default_sos): Add info parameter.
8888         (svr4_read_so_list): Likewise.
8889         (svr4_current_sos_direct): Adjust functions calls to pass down
8890         info.
8891         (svr4_current_sos_1): Add info parameter.
8892         (svr4_current_sos): Call get_svr4_info, pass info down to
8893         svr4_current_sos_1.
8894         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
8895         get_svr4_info.
8896         (svr4_in_dynsym_resolve_code): Pass current_program_space to
8897         get_svr4_info.
8898         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
8899         to get_svr4_info.
8900         (probes_table_remove_objfile_probes): Likewise.
8901         (register_solib_event_probe): Add info parameter.
8902         (solist_update_incremental): Pass info parameter down to
8903         svr4_read_so_list.
8904         (disable_probes_interface): Add info parameter.
8905         (svr4_handle_solib_event): Pass current_program_space to
8906         get_svr4_info.  Adjust disable_probes_interface cleanup.
8907         (svr4_create_probe_breakpoints): Add info parameter, pass it
8908         down to register_solib_event_probe.
8909         (svr4_create_solib_event_breakpoints): Add info parameter,
8910         pass it down to svr4_create_probe_breakpoints.
8911         (enable_break): Pass info down to
8912         svr4_create_solib_event_breakpoints.
8913         (svr4_solib_create_inferior_hook): Pass current_program_space to
8914         get_svr4_info.
8915         (svr4_clear_solib): Likewise.
8916
8917 2019-04-22  Pedro Alves  <palves@redhat.com>
8918
8919         * solib-svr4.c (svr4_free_objfile_observer): New.
8920         (probe_and_action::objfile): New field.
8921         (probes_table_htab_remove_objfile_probes)
8922         (probes_table_remove_objfile_probes): New functions.
8923         (register_solib_event_probe): Add 'objfile' parameter.  Store it
8924         in the new probe_and_action.  Don't store the probe in 'lookup'.
8925         (svr4_create_probe_breakpoints): Pass objfile to
8926         register_solib_event_probe.
8927         (_initialize_svr4_solib): Register a free_objfile observer.
8928
8929 2019-04-19  Tom Tromey  <tom@tromey.com>
8930
8931         * common/queue.h: Remove.
8932
8933 2019-04-19  Tom Tromey  <tom@tromey.com>
8934
8935         * event-loop.c: Don't include "common/queue.h".
8936
8937 2019-04-19  Tom Tromey  <tom@tromey.com>
8938
8939         * remote.c (remote_target): Use delete.
8940         * remote-notif.h: Include <list>, not "common/queue.h".
8941         (notif_client_p): Remove typedef.
8942         (remote_notif_state): Add constructor, destructor, initializer.
8943         <notif_queue>: Now a std::list.
8944         (remote_notif_state_xfree): Don't declare.
8945         * remote-notif.c (remote_notif_process, handle_notification)
8946         (remote_notif_state_allocate): Update.
8947         (~remote_notif_state): Rename from remote_notif_state_xfree.
8948
8949 2019-04-19  Tom Tromey  <tom@tromey.com>
8950
8951         * symfile.c (reread_symbols): Update.
8952         * objfiles.c (objfile_register_static_link)
8953         (objfile_lookup_static_link): Update
8954         (~objfile) Don't delete static_links.
8955         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
8956
8957 2019-04-19  Tom Tromey  <tom@tromey.com>
8958
8959         * type-stack.h (struct type_stack) <insert>: Constify string.
8960         * type-stack.c (type_stack::insert): Constify string.
8961         * gdbtypes.h (lookup_template_type): Update.
8962         (address_space_name_to_int): Update.
8963         * gdbtypes.c (address_space_name_to_int): Make space_identifier
8964         const.
8965         (lookup_template_type): Make name const.
8966         * c-exp.y: Update rules.
8967         (lex_one_token, classify_name, classify_inner_name)
8968         (c_print_token): Update.
8969         * p-exp.y: Update rules.
8970         (yylex): Update.
8971         * f-exp.y: Update rules.
8972         (yylex): Update.
8973         * d-exp.y: Update rules.
8974         (lex_one_token, classify_name, classify_inner_name): Update.
8975         * parse.c (write_dollar_variable, copy_name): Return std::string.
8976         * parser-defs.h (copy_name): Change return type.
8977         * m2-exp.y: Update rules.
8978         (yylex): Update.
8979         * go-exp.y (lex_one_token): Update.
8980         Update rules.
8981         (classify_unsafe_function, classify_packaged_name)
8982         (classify_name, yylex): Update.
8983
8984 2019-04-19  Sergei Trofimovich <siarheit@google.com>
8985
8986         * configure.ac: add --enable-source-highlight switch.
8987         * configure: Regenerate.
8988         * top.c (print_gdb_version): plumb --enable-source-highlight
8989         status to "show configuration".
8990
8991 2019-04-19  Tom Tromey  <tromey@adacore.com>
8992
8993         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
8994         Check ADA_TYPE_P.
8995         (empty_record, ada_template_to_fixed_record_type_1)
8996         (template_to_static_fixed_type)
8997         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
8998         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
8999         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
9000         macros.
9001
9002 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
9003
9004         PR symtab/24423:
9005         * source.c (print_source_lines_base): Advance "iter" when a
9006         control character is seen.
9007
9008 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9009
9010         * inferior.h (struct infcall_suspend_state_deleter):
9011         Catch exception in destructor to avoid crash.
9012
9013 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9014
9015         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
9016         close to the add_com "shell".
9017
9018 2019-04-18  Tom Tromey  <tromey@adacore.com>
9019
9020         * process-stratum-target.h (class process_stratum_target)
9021         <stratum>: Add "final".
9022
9023 2019-04-17  Tom Tromey  <tromey@adacore.com>
9024
9025         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
9026         against nullptr before use.
9027
9028 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
9029
9030         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
9031
9032 2019-04-17  Jim Wilson  <jimw@sifive.com>
9033             Andrew Burgess  <andrew.burgess@embecosm.com>
9034
9035         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
9036         code read might fail, assume 4-byte breakpoint in that case.
9037
9038 2019-04-15  Leszek Swirski  <leszeks@google.com>
9039
9040         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
9041         rather than a hand-rolled POD check when checking for forced MEMORY
9042         classification.
9043
9044 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
9045
9046         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
9047         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
9048         function.
9049         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
9050         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
9051         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
9052         declaration.
9053
9054 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
9055
9056         * aarch64-linux-nat.c
9057         (aarch64_linux_nat_target::thread_architecture): Add override.
9058         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
9059         each VQ.
9060
9061 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
9062
9063         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
9064
9065 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
9066
9067         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
9068         target types of size 96-bits, add some additional comments, and
9069         check that the builtin type we found was the correct size.
9070
9071 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
9072
9073         * utils.c (prompt_for_continue): Don't restore the styling at the
9074         end, as applied_style has the wrong value.  This fixes styling in
9075         long lists of file names that are interrupted by the "Continue?"
9076         prompt.
9077
9078 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
9079
9080         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
9081         * c-lang.c (c_language_defn): Likewise.
9082         (cplus_language_defn): Likewise.
9083         (asm_language_defn): Likewise.
9084         (minimal_language_defn): Likewise.
9085         * d-lang.c (d_language_defn): Likewise.
9086         * f-lang.c (f_language_defn): Likewise.
9087         * go-lang.c (go_language_defn): Likewise.
9088         * language.c (unknown_language_defn): Likewise.
9089         (auto_language_defn): Likewise.
9090         * language.h (struct language_defn): Remove la_magic field.
9091         (LANG_MAGIC): Delete.
9092         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
9093         * objc-lang.c (objc_language_defn): Likewise.
9094         * opencl-lang.c (opencl_language_defn): Likewise.
9095         * p-lang.c (pascal_language_defn): Likewise.
9096         * rust-lang.c (rust_language_defn): Likewise.
9097
9098 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
9099
9100         * riscv-tdep.c (riscv_type_align): New function.
9101         (riscv_type_alignment): Delete.
9102         (riscv_arg_location): Use 'type_align'.
9103         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
9104
9105 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
9106
9107         * gdbtypes.c (type_align): A struct with no non-static fields also
9108         has alignment of 1.
9109
9110 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
9111
9112         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
9113         component to 0.
9114         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
9115         member.
9116         (riscv_struct_info::analyse): New implementation using new
9117         analyse_inner member function.
9118         (riscv_struct_info::field_offset): New member function.
9119         (riscv_struct_info::m_offsets): New member variable.
9120         (riscv_struct_info::analyse_inner): New private member function,
9121         takes the old implementation of riscv_struct_info::analyse but
9122         extended to track field offsets.
9123         (riscv_call_arg_struct): Update the struct folding special cases
9124         to handle cases where empty C++ structs, which are non-zero
9125         length, are found.
9126         (riscv_arg_location): Initialise the length of each location, a
9127         non-zero length now indicates the location is in use.
9128         (riscv_push_dummy_call): Allow for the first location having a
9129         non-zero offset when setting up arguments.
9130         (riscv_return_value): Likewise, but for return values.
9131
9132 2019-04-11  Tom Tromey  <tromey@adacore.com>
9133
9134         * utils.c (internal_vproblem): Make "msg" const.
9135
9136 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
9137
9138         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
9139         * trad-frame.c (trad_frame_reset_saved_regs): New function.
9140         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
9141         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
9142
9143 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
9144
9145         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
9146         function.
9147         (fill_gregset): Call amd64_linux_collect_native_gregset instead
9148         of amd64_collect_native_gregset.
9149         (amd64_linux_nat_target::store_registers): Likewise.
9150
9151 2019-04-10  Tom Tromey  <tom@tromey.com>
9152
9153         * symtab.c (lookup_global_symbol_from_objfile)
9154         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
9155         * objfiles.h (class separate_debug_iterator): New.
9156         (class separate_debug_range): New.
9157         (struct objfile) <separate_debug_objfiles>: New method.
9158         (objfile_separate_debug_iterate): Don't declare.
9159         * objfiles.c (separate_debug_iterator::operator++): Rename from
9160         objfile_separate_debug_iterate.
9161         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
9162         iterator.
9163         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
9164         iterator.
9165
9166 2019-04-10  Tom Tromey  <tom@tromey.com>
9167
9168         * symfile.c (reread_symbols): Remove old comment.
9169         * objfiles.c (free_all_objfiles): Fix a typo.
9170
9171 2019-04-10  Tom Tromey  <tom@tromey.com>
9172
9173         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
9174         * minsyms.c (lookup_minimal_symbol): Use foreach.
9175         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
9176         (lookup_minimal_symbol_solib_trampoline): Likewise.
9177         * symfile.c (reread_symbols): Use foreach.
9178
9179 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
9180             Tom Tromey  <tromey@adacore.com>
9181
9182         PR rust/24414:
9183         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
9184         (rust_lex_int_test): Change "value" to be LONGEST.
9185         (rust_lex_tests): Add test for long integer literal.
9186
9187 2019-04-09  Tom Tromey  <tromey@adacore.com>
9188
9189         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
9190         to bool.
9191         (extended_remote_target::attach): Update.
9192         (remote_target::remote_notice_new_inferior): Update.
9193         (remote_target::add_current_inferior_and_thread): Update.
9194         * inferior.c (exit_inferior_1): Use "false".
9195         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
9196
9197 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
9198
9199         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
9200         the "start" command.
9201
9202 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
9203
9204         * python/py-inferior.c (infpy_thread_from_thread_handle):
9205         Adjust comments to reflect renaming of thread_from_thread_handle
9206         to thread_from_handle.  Adjust keywords.  Fix type error message.
9207         (inferior_object_methods): Add thread_from_handle.  Retain
9208         thread_from_thread_handle, but mark it as deprecated.
9209
9210 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
9211
9212         * gdbthread.h (find_thread_by_handle): Revise declaration.
9213         * thread.c (find_thread_by_handle): Likewise.  Adjust
9214         implementation too.
9215         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
9216         support for buffer objects as handles.
9217
9218 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
9219
9220         * python/py-infthread.c (thpy_thread_handle): New function.
9221         (thread_object_methods): Register thpy_thread_handle.
9222
9223 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
9224
9225         * gdbthread.h (thread_to_thread_handle): Declare.
9226         * thread.c (gdbtypes.h): Include.
9227         (thread_to_thread_handle): New function.
9228
9229         * target.h (struct target_ops): Add thread_info_to_thread_handle.
9230         (target_thread_info_to_thread_handle): Declare.
9231         * target.c (target_thread_info_to_thread_handle): New function.
9232         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
9233         * target-delegates.c: Regenerate.
9234
9235         * linux-thread-db.c (class thread_db_target): Add method
9236         thread_info_to_thread_handle.
9237         (thread_db_target::thread_info_to_thread_handle): Define.
9238         * remote.c (class remote_target): Add new method
9239         thread_info_to_thread_handle.
9240         (remote_target::thread_info_to_thread_handle): Define.
9241
9242 2019-04-08  Pedro Alves  <palves@redhat.com>
9243
9244         * common/common-exceptions.c (throw_exception): Don't create
9245         named object to throw; throw directly.
9246         (throw_it): Likewise.  Don't initialize gdb_exception::message
9247         here, with new; pass FMT and AP to the ctor instead.
9248         * common/common-exceptions.h: Include <string>.
9249         (gdb_exception::gdb_exception(enum return_reason, enum errors,
9250         const char *, va_list)): New ctor.  Use std::make_shared.
9251         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
9252         errors)): Delete.
9253         (gdb_exception_error::gdb_exception_error(enum errors, const char
9254         *, va_list)): New.
9255         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
9256         Add assertion.
9257         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
9258         errors)): Delete.
9259         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
9260         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
9261         Add assertion.
9262
9263 2019-04-08  Tom Tromey  <tom@tromey.com>
9264
9265         * valops.c (value_rtti_indirect_type): Replace throw_exception
9266         with throw.
9267         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
9268         with throw.
9269         * thread.c (thr_try_catch_cmd): Replace throw_exception with
9270         throw.
9271         * target.c (target_translate_tls_address): Replace throw_exception
9272         with throw.
9273         * stack.c (frame_apply_command_count): Replace throw_exception
9274         with throw.
9275         * solib-spu.c (append_ocl_sos): Replace throw_exception with
9276         throw.
9277         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
9278         with throw.
9279         * rs6000-tdep.c (rs6000_frame_cache)
9280         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
9281         * remote.c: Replace throw_exception with throw.
9282         * record-full.c (record_full_message, record_full_wait_1)
9283         (record_full_restore): Replace throw_exception with throw.
9284         * record-btrace.c:
9285         (get_thread_current_frame_id, record_btrace_start_replaying)
9286         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
9287         (cmd_record_btrace_start): Replace throw_exception with throw.
9288         * parse.c (parse_exp_in_context_1): Replace throw_exception with
9289         throw.
9290         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
9291         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
9292         * linespec.c:
9293         (find_linespec_symbols): Replace throw_exception with throw.
9294         * infrun.c (displaced_step_prepare, resume): Replace
9295         throw_exception with throw.
9296         * infcmd.c (post_create_inferior): Replace throw_exception with
9297         throw.
9298         * inf-loop.c (inferior_event_handler): Replace throw_exception
9299         with throw.
9300         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
9301         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
9302         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
9303         (get_prev_frame_always, get_frame_pc_if_available)
9304         (get_frame_address_in_block_if_available, get_frame_language):
9305         Replace throw_exception with throw.
9306         * frame-unwind.c (frame_unwind_try_unwinder): Replace
9307         throw_exception with throw.
9308         * eval.c (fetch_subexp_value, evaluate_var_value)
9309         (evaluate_funcall, evaluate_subexp_standard): Replace
9310         throw_exception with throw.
9311         * dwarf2loc.c (call_site_find_chain)
9312         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
9313         Replace throw_exception with throw.
9314         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
9315         with throw.
9316         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
9317         throw.
9318         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
9319         * completer.c (complete_line_internal): Replace throw_exception
9320         with throw.
9321         * compile/compile-object-run.c (compile_object_run): Replace
9322         throw_exception with throw.
9323         * cli/cli-script.c (process_next_line): Replace throw_exception
9324         with throw.
9325         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
9326         (btrace_enable, btrace_maint_update_pt_packets): Replace
9327         throw_exception with throw.
9328         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
9329         throw_exception with throw.
9330         * break-catch-throw.c (re_set_exception_catchpoint): Replace
9331         throw_exception with throw.
9332         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
9333         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
9334         * aarch64-tdep.c (aarch64_make_prologue_cache)
9335         (aarch64_make_stub_cache): Replace throw_exception with throw.
9336
9337 2019-04-08  Tom Tromey  <tom@tromey.com>
9338
9339         * common/common-exceptions.c (throw_exception): Rename from
9340         throw_exception_cxx.  Remove old copy.  Make argument const.
9341         (throw_it): Create and throw exception objects directly.
9342         * common/common-exceptions.h (throw_exception): Make argument
9343         const.
9344         (struct gdb_exception_error): Add constructor.
9345         (struct gdb_exception_quit): Add constructor.
9346
9347 2019-04-08  Tom Tromey  <tom@tromey.com>
9348
9349         * common/common-exceptions.h (exception_rethrow): Don't declare.
9350         (TRY_SJLJ): Update comment.
9351         (TRY, CATCH, END_CATCH): Remove.
9352         * common/common-exceptions.c (exception_rethrow): Remove.
9353
9354 2019-04-08  Tom Tromey  <tom@tromey.com>
9355
9356         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
9357         Remove.
9358         (gdb_exception_error): Rename from
9359         gdb_exception_RETURN_MASK_ERROR.
9360         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
9361         (gdb_quit_bad_alloc): Update.
9362         * aarch64-tdep.c: Update.
9363         * ada-lang.c: Update.
9364         * ada-typeprint.c: Update.
9365         * ada-valprint.c: Update.
9366         * amd64-tdep.c: Update.
9367         * arch-utils.c: Update.
9368         * break-catch-throw.c: Update.
9369         * breakpoint.c: Update.
9370         * btrace.c: Update.
9371         * c-varobj.c: Update.
9372         * cli/cli-cmds.c: Update.
9373         * cli/cli-interp.c: Update.
9374         * cli/cli-script.c: Update.
9375         * common/common-exceptions.c: Update.
9376         * common/new-op.c: Update.
9377         * common/selftest.c: Update.
9378         * compile/compile-c-symbols.c: Update.
9379         * compile/compile-cplus-symbols.c: Update.
9380         * compile/compile-object-load.c: Update.
9381         * compile/compile-object-run.c: Update.
9382         * completer.c: Update.
9383         * corelow.c: Update.
9384         * cp-abi.c: Update.
9385         * cp-support.c: Update.
9386         * cp-valprint.c: Update.
9387         * darwin-nat.c: Update.
9388         * disasm-selftests.c: Update.
9389         * dtrace-probe.c: Update.
9390         * dwarf-index-cache.c: Update.
9391         * dwarf-index-write.c: Update.
9392         * dwarf2-frame-tailcall.c: Update.
9393         * dwarf2-frame.c: Update.
9394         * dwarf2loc.c: Update.
9395         * dwarf2read.c: Update.
9396         * eval.c: Update.
9397         * event-loop.c: Update.
9398         * event-top.c: Update.
9399         * exec.c: Update.
9400         * f-valprint.c: Update.
9401         * fbsd-tdep.c: Update.
9402         * frame-unwind.c: Update.
9403         * frame.c: Update.
9404         * gdbtypes.c: Update.
9405         * gnu-v3-abi.c: Update.
9406         * guile/guile-internal.h: Update.
9407         * guile/scm-block.c: Update.
9408         * guile/scm-breakpoint.c: Update.
9409         * guile/scm-cmd.c: Update.
9410         * guile/scm-disasm.c: Update.
9411         * guile/scm-frame.c: Update.
9412         * guile/scm-lazy-string.c: Update.
9413         * guile/scm-math.c: Update.
9414         * guile/scm-param.c: Update.
9415         * guile/scm-ports.c: Update.
9416         * guile/scm-pretty-print.c: Update.
9417         * guile/scm-symbol.c: Update.
9418         * guile/scm-symtab.c: Update.
9419         * guile/scm-type.c: Update.
9420         * guile/scm-value.c: Update.
9421         * i386-linux-tdep.c: Update.
9422         * i386-tdep.c: Update.
9423         * inf-loop.c: Update.
9424         * infcall.c: Update.
9425         * infcmd.c: Update.
9426         * infrun.c: Update.
9427         * jit.c: Update.
9428         * language.c: Update.
9429         * linespec.c: Update.
9430         * linux-fork.c: Update.
9431         * linux-nat.c: Update.
9432         * linux-tdep.c: Update.
9433         * linux-thread-db.c: Update.
9434         * main.c: Update.
9435         * mi/mi-cmd-break.c: Update.
9436         * mi/mi-cmd-stack.c: Update.
9437         * mi/mi-interp.c: Update.
9438         * mi/mi-main.c: Update.
9439         * objc-lang.c: Update.
9440         * p-valprint.c: Update.
9441         * parse.c: Update.
9442         * ppc-linux-tdep.c: Update.
9443         * printcmd.c: Update.
9444         * python/py-arch.c: Update.
9445         * python/py-breakpoint.c: Update.
9446         * python/py-cmd.c: Update.
9447         * python/py-finishbreakpoint.c: Update.
9448         * python/py-frame.c: Update.
9449         * python/py-framefilter.c: Update.
9450         * python/py-gdb-readline.c: Update.
9451         * python/py-inferior.c: Update.
9452         * python/py-infthread.c: Update.
9453         * python/py-lazy-string.c: Update.
9454         * python/py-linetable.c: Update.
9455         * python/py-objfile.c: Update.
9456         * python/py-param.c: Update.
9457         * python/py-prettyprint.c: Update.
9458         * python/py-progspace.c: Update.
9459         * python/py-record-btrace.c: Update.
9460         * python/py-record.c: Update.
9461         * python/py-symbol.c: Update.
9462         * python/py-type.c: Update.
9463         * python/py-unwind.c: Update.
9464         * python/py-utils.c: Update.
9465         * python/py-value.c: Update.
9466         * python/python.c: Update.
9467         * record-btrace.c: Update.
9468         * record-full.c: Update.
9469         * remote-fileio.c: Update.
9470         * remote.c: Update.
9471         * riscv-tdep.c: Update.
9472         * rs6000-aix-tdep.c: Update.
9473         * rs6000-tdep.c: Update.
9474         * rust-exp.y: Update.
9475         * rust-lang.c: Update.
9476         * s390-tdep.c: Update.
9477         * selftest-arch.c: Update.
9478         * solib-dsbt.c: Update.
9479         * solib-frv.c: Update.
9480         * solib-spu.c: Update.
9481         * solib-svr4.c: Update.
9482         * solib.c: Update.
9483         * sparc64-linux-tdep.c: Update.
9484         * stack.c: Update.
9485         * symfile-mem.c: Update.
9486         * symmisc.c: Update.
9487         * target.c: Update.
9488         * thread.c: Update.
9489         * top.c: Update.
9490         * tracefile-tfile.c: Update.
9491         * tui/tui.c: Update.
9492         * typeprint.c: Update.
9493         * unittests/cli-utils-selftests.c: Update.
9494         * unittests/parse-connection-spec-selftests.c: Update.
9495         * valops.c: Update.
9496         * valprint.c: Update.
9497         * value.c: Update.
9498         * varobj.c: Update.
9499         * windows-nat.c: Update.
9500         * x86-linux-nat.c: Update.
9501         * xml-support.c: Update.
9502
9503 2019-04-08  Tom Tromey  <tom@tromey.com>
9504
9505         * xml-support.c: Use C++ exception handling.
9506         * x86-linux-nat.c: Use C++ exception handling.
9507         * windows-nat.c: Use C++ exception handling.
9508         * varobj.c: Use C++ exception handling.
9509         * value.c: Use C++ exception handling.
9510         * valprint.c: Use C++ exception handling.
9511         * valops.c: Use C++ exception handling.
9512         * unittests/parse-connection-spec-selftests.c: Use C++ exception
9513         handling.
9514         * unittests/cli-utils-selftests.c: Use C++ exception handling.
9515         * typeprint.c: Use C++ exception handling.
9516         * tui/tui.c: Use C++ exception handling.
9517         * tracefile-tfile.c: Use C++ exception handling.
9518         * top.c: Use C++ exception handling.
9519         * thread.c: Use C++ exception handling.
9520         * target.c: Use C++ exception handling.
9521         * symmisc.c: Use C++ exception handling.
9522         * symfile-mem.c: Use C++ exception handling.
9523         * stack.c: Use C++ exception handling.
9524         * sparc64-linux-tdep.c: Use C++ exception handling.
9525         * solib.c: Use C++ exception handling.
9526         * solib-svr4.c: Use C++ exception handling.
9527         * solib-spu.c: Use C++ exception handling.
9528         * solib-frv.c: Use C++ exception handling.
9529         * solib-dsbt.c: Use C++ exception handling.
9530         * selftest-arch.c: Use C++ exception handling.
9531         * s390-tdep.c: Use C++ exception handling.
9532         * rust-lang.c: Use C++ exception handling.
9533         * rust-exp.y: Use C++ exception handling.
9534         * rs6000-tdep.c: Use C++ exception handling.
9535         * rs6000-aix-tdep.c: Use C++ exception handling.
9536         * riscv-tdep.c: Use C++ exception handling.
9537         * remote.c: Use C++ exception handling.
9538         * remote-fileio.c: Use C++ exception handling.
9539         * record-full.c: Use C++ exception handling.
9540         * record-btrace.c: Use C++ exception handling.
9541         * python/python.c: Use C++ exception handling.
9542         * python/py-value.c: Use C++ exception handling.
9543         * python/py-utils.c: Use C++ exception handling.
9544         * python/py-unwind.c: Use C++ exception handling.
9545         * python/py-type.c: Use C++ exception handling.
9546         * python/py-symbol.c: Use C++ exception handling.
9547         * python/py-record.c: Use C++ exception handling.
9548         * python/py-record-btrace.c: Use C++ exception handling.
9549         * python/py-progspace.c: Use C++ exception handling.
9550         * python/py-prettyprint.c: Use C++ exception handling.
9551         * python/py-param.c: Use C++ exception handling.
9552         * python/py-objfile.c: Use C++ exception handling.
9553         * python/py-linetable.c: Use C++ exception handling.
9554         * python/py-lazy-string.c: Use C++ exception handling.
9555         * python/py-infthread.c: Use C++ exception handling.
9556         * python/py-inferior.c: Use C++ exception handling.
9557         * python/py-gdb-readline.c: Use C++ exception handling.
9558         * python/py-framefilter.c: Use C++ exception handling.
9559         * python/py-frame.c: Use C++ exception handling.
9560         * python/py-finishbreakpoint.c: Use C++ exception handling.
9561         * python/py-cmd.c: Use C++ exception handling.
9562         * python/py-breakpoint.c: Use C++ exception handling.
9563         * python/py-arch.c: Use C++ exception handling.
9564         * printcmd.c: Use C++ exception handling.
9565         * ppc-linux-tdep.c: Use C++ exception handling.
9566         * parse.c: Use C++ exception handling.
9567         * p-valprint.c: Use C++ exception handling.
9568         * objc-lang.c: Use C++ exception handling.
9569         * mi/mi-main.c: Use C++ exception handling.
9570         * mi/mi-interp.c: Use C++ exception handling.
9571         * mi/mi-cmd-stack.c: Use C++ exception handling.
9572         * mi/mi-cmd-break.c: Use C++ exception handling.
9573         * main.c: Use C++ exception handling.
9574         * linux-thread-db.c: Use C++ exception handling.
9575         * linux-tdep.c: Use C++ exception handling.
9576         * linux-nat.c: Use C++ exception handling.
9577         * linux-fork.c: Use C++ exception handling.
9578         * linespec.c: Use C++ exception handling.
9579         * language.c: Use C++ exception handling.
9580         * jit.c: Use C++ exception handling.
9581         * infrun.c: Use C++ exception handling.
9582         * infcmd.c: Use C++ exception handling.
9583         * infcall.c: Use C++ exception handling.
9584         * inf-loop.c: Use C++ exception handling.
9585         * i386-tdep.c: Use C++ exception handling.
9586         * i386-linux-tdep.c: Use C++ exception handling.
9587         * guile/scm-value.c: Use C++ exception handling.
9588         * guile/scm-type.c: Use C++ exception handling.
9589         * guile/scm-symtab.c: Use C++ exception handling.
9590         * guile/scm-symbol.c: Use C++ exception handling.
9591         * guile/scm-pretty-print.c: Use C++ exception handling.
9592         * guile/scm-ports.c: Use C++ exception handling.
9593         * guile/scm-param.c: Use C++ exception handling.
9594         * guile/scm-math.c: Use C++ exception handling.
9595         * guile/scm-lazy-string.c: Use C++ exception handling.
9596         * guile/scm-frame.c: Use C++ exception handling.
9597         * guile/scm-disasm.c: Use C++ exception handling.
9598         * guile/scm-cmd.c: Use C++ exception handling.
9599         * guile/scm-breakpoint.c: Use C++ exception handling.
9600         * guile/scm-block.c: Use C++ exception handling.
9601         * guile/guile-internal.h: Use C++ exception handling.
9602         * gnu-v3-abi.c: Use C++ exception handling.
9603         * gdbtypes.c: Use C++ exception handling.
9604         * frame.c: Use C++ exception handling.
9605         * frame-unwind.c: Use C++ exception handling.
9606         * fbsd-tdep.c: Use C++ exception handling.
9607         * f-valprint.c: Use C++ exception handling.
9608         * exec.c: Use C++ exception handling.
9609         * event-top.c: Use C++ exception handling.
9610         * event-loop.c: Use C++ exception handling.
9611         * eval.c: Use C++ exception handling.
9612         * dwarf2read.c: Use C++ exception handling.
9613         * dwarf2loc.c: Use C++ exception handling.
9614         * dwarf2-frame.c: Use C++ exception handling.
9615         * dwarf2-frame-tailcall.c: Use C++ exception handling.
9616         * dwarf-index-write.c: Use C++ exception handling.
9617         * dwarf-index-cache.c: Use C++ exception handling.
9618         * dtrace-probe.c: Use C++ exception handling.
9619         * disasm-selftests.c: Use C++ exception handling.
9620         * darwin-nat.c: Use C++ exception handling.
9621         * cp-valprint.c: Use C++ exception handling.
9622         * cp-support.c: Use C++ exception handling.
9623         * cp-abi.c: Use C++ exception handling.
9624         * corelow.c: Use C++ exception handling.
9625         * completer.c: Use C++ exception handling.
9626         * compile/compile-object-run.c: Use C++ exception handling.
9627         * compile/compile-object-load.c: Use C++ exception handling.
9628         * compile/compile-cplus-symbols.c: Use C++ exception handling.
9629         * compile/compile-c-symbols.c: Use C++ exception handling.
9630         * common/selftest.c: Use C++ exception handling.
9631         * common/new-op.c: Use C++ exception handling.
9632         * cli/cli-script.c: Use C++ exception handling.
9633         * cli/cli-interp.c: Use C++ exception handling.
9634         * cli/cli-cmds.c: Use C++ exception handling.
9635         * c-varobj.c: Use C++ exception handling.
9636         * btrace.c: Use C++ exception handling.
9637         * breakpoint.c: Use C++ exception handling.
9638         * break-catch-throw.c: Use C++ exception handling.
9639         * arch-utils.c: Use C++ exception handling.
9640         * amd64-tdep.c: Use C++ exception handling.
9641         * ada-valprint.c: Use C++ exception handling.
9642         * ada-typeprint.c: Use C++ exception handling.
9643         * ada-lang.c: Use C++ exception handling.
9644         * aarch64-tdep.c: Use C++ exception handling.
9645
9646 2019-04-08  Tom Tromey  <tom@tromey.com>
9647
9648         * xml-support.c (gdb_xml_parser::parse): Update.
9649         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
9650         * value.c (show_convenience): Update.
9651         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
9652         (test_parse_flags_qcs): Update.
9653         * thread.c (thr_try_catch_cmd): Update.
9654         * target.c (target_translate_tls_address): Update.
9655         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
9656         (info_frame_command_core, frame_apply_command_count): Update.
9657         * rust-exp.y (rust_lex_exception_test): Update.
9658         * riscv-tdep.c (riscv_print_one_register_info): Update.
9659         * remote.c (remote_target::enable_btrace): Update.
9660         * record-btrace.c (record_btrace_enable_warn): Update.
9661         * python/py-utils.c (gdbpy_convert_exception): Update.
9662         * printcmd.c (do_one_display, print_variable_and_value): Update.
9663         * mi/mi-main.c (mi_print_exception): Update.
9664         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
9665         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
9666         * linux-nat.c (linux_nat_target::attach): Update.
9667         * linux-fork.c (class scoped_switch_fork_info): Update.
9668         * infrun.c (displaced_step_prepare): Update.
9669         * infcall.c (call_function_by_hand_dummy): Update.
9670         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
9671         * gnu-v3-abi.c (print_one_vtable): Update.
9672         * frame.c (get_prev_frame_always): Update.
9673         * f-valprint.c (info_common_command_for_block): Update.
9674         * exec.c (try_open_exec_file): Update.
9675         * exceptions.c (print_exception, exception_print)
9676         (exception_fprintf, exception_print_same): Update.
9677         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
9678         * dwarf-index-cache.c (index_cache::store)
9679         (index_cache::lookup_gdb_index): Update.
9680         * darwin-nat.c (maybe_cache_shell): Update.
9681         * cp-valprint.c (cp_print_value_fields): Update.
9682         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
9683         (gcc_cplus_symbol_address): Update.
9684         * compile/compile-c-symbols.c (gcc_convert_symbol)
9685         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
9686         * common/selftest.c: Update.
9687         * common/common-exceptions.h (struct gdb_exception) <message>: Now
9688         a std::string.
9689         (exception_try_scope_entry, exception_try_scope_exit): Don't
9690         declare.
9691         (struct exception_try_scope): Remove.
9692         (TRY): Don't use exception_try_scope.
9693         (struct gdb_exception): Add constructor, operator=.
9694         <what>: New method.
9695         (struct gdb_exception_RETURN_MASK_ALL)
9696         (struct gdb_exception_RETURN_MASK_ERROR)
9697         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
9698         (struct gdb_quit_bad_alloc): Update.
9699         * common/common-exceptions.c (exception_none): Change
9700         initializer.
9701         (struct catcher) <state, exception>: Initialize inline.
9702         <prev>: Remove member.
9703         (current_catcher): Remove.
9704         (catchers): New global.
9705         (exceptions_state_mc_init): Simplify.
9706         (catcher_pop): Remove.
9707         (exceptions_state_mc, exceptions_state_mc_catch): Update.
9708         (try_scope_depth, exception_try_scope_entry)
9709         (exception_try_scope_exit): Remove.
9710         (throw_exception_sjlj): Update.
9711         (exception_messages, exception_messages_size): Remove.
9712         (throw_it): Simplify.
9713         (gdb_exception_sliced_copy): Remove.
9714         (throw_exception_cxx): Update.
9715         * cli/cli-script.c (script_from_file): Update.
9716         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
9717         Update.
9718         * ada-valprint.c (ada_val_print): Update.
9719         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
9720         (create_excep_cond_exprs): Update.
9721
9722 2019-04-08  Tom Tromey  <tom@tromey.com>
9723
9724         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
9725         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
9726         (TRY, CATCH, END_CATCH): Remove some definitions.
9727         * common/common-exceptions.c: Don't use GDB_XCPT.
9728         (catcher_list_size): Remove.
9729         (throw_exception, throw_it): Simplify.
9730
9731 2019-04-05  Tom Tromey  <tom@tromey.com>
9732
9733         Revert the header-sorting patch.
9734         * ft32-tdep.c: Revert.
9735         * frv-tdep.c: Revert.
9736         * frv-linux-tdep.c: Revert.
9737         * frame.c: Revert.
9738         * frame-unwind.c: Revert.
9739         * frame-base.c: Revert.
9740         * fork-child.c: Revert.
9741         * findvar.c: Revert.
9742         * findcmd.c: Revert.
9743         * filesystem.c: Revert.
9744         * filename-seen-cache.h: Revert.
9745         * filename-seen-cache.c: Revert.
9746         * fbsd-tdep.c: Revert.
9747         * fbsd-nat.h: Revert.
9748         * fbsd-nat.c: Revert.
9749         * f-valprint.c: Revert.
9750         * f-typeprint.c: Revert.
9751         * f-lang.c: Revert.
9752         * extension.h: Revert.
9753         * extension.c: Revert.
9754         * extension-priv.h: Revert.
9755         * expprint.c: Revert.
9756         * exec.h: Revert.
9757         * exec.c: Revert.
9758         * exceptions.c: Revert.
9759         * event-top.c: Revert.
9760         * event-loop.c: Revert.
9761         * eval.c: Revert.
9762         * elfread.c: Revert.
9763         * dwarf2read.h: Revert.
9764         * dwarf2read.c: Revert.
9765         * dwarf2loc.c: Revert.
9766         * dwarf2expr.h: Revert.
9767         * dwarf2expr.c: Revert.
9768         * dwarf2-frame.c: Revert.
9769         * dwarf2-frame-tailcall.c: Revert.
9770         * dwarf-index-write.h: Revert.
9771         * dwarf-index-write.c: Revert.
9772         * dwarf-index-common.c: Revert.
9773         * dwarf-index-cache.h: Revert.
9774         * dwarf-index-cache.c: Revert.
9775         * dummy-frame.c: Revert.
9776         * dtrace-probe.c: Revert.
9777         * disasm.h: Revert.
9778         * disasm.c: Revert.
9779         * disasm-selftests.c: Revert.
9780         * dictionary.c: Revert.
9781         * dicos-tdep.c: Revert.
9782         * demangle.c: Revert.
9783         * dcache.h: Revert.
9784         * dcache.c: Revert.
9785         * darwin-nat.h: Revert.
9786         * darwin-nat.c: Revert.
9787         * darwin-nat-info.c: Revert.
9788         * d-valprint.c: Revert.
9789         * d-namespace.c: Revert.
9790         * d-lang.c: Revert.
9791         * ctf.c: Revert.
9792         * csky-tdep.c: Revert.
9793         * csky-linux-tdep.c: Revert.
9794         * cris-tdep.c: Revert.
9795         * cris-linux-tdep.c: Revert.
9796         * cp-valprint.c: Revert.
9797         * cp-support.c: Revert.
9798         * cp-namespace.c: Revert.
9799         * cp-abi.c: Revert.
9800         * corelow.c: Revert.
9801         * corefile.c: Revert.
9802         * continuations.c: Revert.
9803         * completer.h: Revert.
9804         * completer.c: Revert.
9805         * complaints.c: Revert.
9806         * coffread.c: Revert.
9807         * coff-pe-read.c: Revert.
9808         * cli-out.h: Revert.
9809         * cli-out.c: Revert.
9810         * charset.c: Revert.
9811         * c-varobj.c: Revert.
9812         * c-valprint.c: Revert.
9813         * c-typeprint.c: Revert.
9814         * c-lang.c: Revert.
9815         * buildsym.c: Revert.
9816         * buildsym-legacy.c: Revert.
9817         * build-id.h: Revert.
9818         * build-id.c: Revert.
9819         * btrace.c: Revert.
9820         * bsd-uthread.c: Revert.
9821         * breakpoint.h: Revert.
9822         * breakpoint.c: Revert.
9823         * break-catch-throw.c: Revert.
9824         * break-catch-syscall.c: Revert.
9825         * break-catch-sig.c: Revert.
9826         * blockframe.c: Revert.
9827         * block.c: Revert.
9828         * bfin-tdep.c: Revert.
9829         * bfin-linux-tdep.c: Revert.
9830         * bfd-target.c: Revert.
9831         * bcache.c: Revert.
9832         * ax-general.c: Revert.
9833         * ax-gdb.h: Revert.
9834         * ax-gdb.c: Revert.
9835         * avr-tdep.c: Revert.
9836         * auxv.c: Revert.
9837         * auto-load.c: Revert.
9838         * arm-wince-tdep.c: Revert.
9839         * arm-tdep.c: Revert.
9840         * arm-symbian-tdep.c: Revert.
9841         * arm-pikeos-tdep.c: Revert.
9842         * arm-obsd-tdep.c: Revert.
9843         * arm-nbsd-tdep.c: Revert.
9844         * arm-nbsd-nat.c: Revert.
9845         * arm-linux-tdep.c: Revert.
9846         * arm-linux-nat.c: Revert.
9847         * arm-fbsd-tdep.c: Revert.
9848         * arm-fbsd-nat.c: Revert.
9849         * arm-bsd-tdep.c: Revert.
9850         * arch-utils.c: Revert.
9851         * arc-tdep.c: Revert.
9852         * arc-newlib-tdep.c: Revert.
9853         * annotate.h: Revert.
9854         * annotate.c: Revert.
9855         * amd64-windows-tdep.c: Revert.
9856         * amd64-windows-nat.c: Revert.
9857         * amd64-tdep.c: Revert.
9858         * amd64-sol2-tdep.c: Revert.
9859         * amd64-obsd-tdep.c: Revert.
9860         * amd64-obsd-nat.c: Revert.
9861         * amd64-nbsd-tdep.c: Revert.
9862         * amd64-nbsd-nat.c: Revert.
9863         * amd64-nat.c: Revert.
9864         * amd64-linux-tdep.c: Revert.
9865         * amd64-linux-nat.c: Revert.
9866         * amd64-fbsd-tdep.c: Revert.
9867         * amd64-fbsd-nat.c: Revert.
9868         * amd64-dicos-tdep.c: Revert.
9869         * amd64-darwin-tdep.c: Revert.
9870         * amd64-bsd-nat.c: Revert.
9871         * alpha-tdep.c: Revert.
9872         * alpha-obsd-tdep.c: Revert.
9873         * alpha-nbsd-tdep.c: Revert.
9874         * alpha-mdebug-tdep.c: Revert.
9875         * alpha-linux-tdep.c: Revert.
9876         * alpha-linux-nat.c: Revert.
9877         * alpha-bsd-tdep.c: Revert.
9878         * alpha-bsd-nat.c: Revert.
9879         * aix-thread.c: Revert.
9880         * agent.c: Revert.
9881         * addrmap.c: Revert.
9882         * ada-varobj.c: Revert.
9883         * ada-valprint.c: Revert.
9884         * ada-typeprint.c: Revert.
9885         * ada-tasks.c: Revert.
9886         * ada-lang.c: Revert.
9887         * aarch64-tdep.c: Revert.
9888         * aarch64-ravenscar-thread.c: Revert.
9889         * aarch64-newlib-tdep.c: Revert.
9890         * aarch64-linux-tdep.c: Revert.
9891         * aarch64-linux-nat.c: Revert.
9892         * aarch64-fbsd-tdep.c: Revert.
9893         * aarch64-fbsd-nat.c: Revert.
9894         * aarch32-linux-nat.c: Revert.
9895
9896 2019-04-05  Tom Tromey  <tom@tromey.com>
9897
9898         * ft32-tdep.c: Sort headers.
9899         * frv-tdep.c: Sort headers.
9900         * frv-linux-tdep.c: Sort headers.
9901         * frame.c: Sort headers.
9902         * frame-unwind.c: Sort headers.
9903         * frame-base.c: Sort headers.
9904         * fork-child.c: Sort headers.
9905         * findvar.c: Sort headers.
9906         * findcmd.c: Sort headers.
9907         * filesystem.c: Sort headers.
9908         * filename-seen-cache.h: Sort headers.
9909         * filename-seen-cache.c: Sort headers.
9910         * fbsd-tdep.c: Sort headers.
9911         * fbsd-nat.h: Sort headers.
9912         * fbsd-nat.c: Sort headers.
9913         * f-valprint.c: Sort headers.
9914         * f-typeprint.c: Sort headers.
9915         * f-lang.c: Sort headers.
9916         * extension.h: Sort headers.
9917         * extension.c: Sort headers.
9918         * extension-priv.h: Sort headers.
9919         * expprint.c: Sort headers.
9920         * exec.h: Sort headers.
9921         * exec.c: Sort headers.
9922         * exceptions.c: Sort headers.
9923         * event-top.c: Sort headers.
9924         * event-loop.c: Sort headers.
9925         * eval.c: Sort headers.
9926         * elfread.c: Sort headers.
9927         * dwarf2read.h: Sort headers.
9928         * dwarf2read.c: Sort headers.
9929         * dwarf2loc.c: Sort headers.
9930         * dwarf2expr.h: Sort headers.
9931         * dwarf2expr.c: Sort headers.
9932         * dwarf2-frame.c: Sort headers.
9933         * dwarf2-frame-tailcall.c: Sort headers.
9934         * dwarf-index-write.h: Sort headers.
9935         * dwarf-index-write.c: Sort headers.
9936         * dwarf-index-common.c: Sort headers.
9937         * dwarf-index-cache.h: Sort headers.
9938         * dwarf-index-cache.c: Sort headers.
9939         * dummy-frame.c: Sort headers.
9940         * dtrace-probe.c: Sort headers.
9941         * disasm.h: Sort headers.
9942         * disasm.c: Sort headers.
9943         * disasm-selftests.c: Sort headers.
9944         * dictionary.c: Sort headers.
9945         * dicos-tdep.c: Sort headers.
9946         * demangle.c: Sort headers.
9947         * dcache.h: Sort headers.
9948         * dcache.c: Sort headers.
9949         * darwin-nat.h: Sort headers.
9950         * darwin-nat.c: Sort headers.
9951         * darwin-nat-info.c: Sort headers.
9952         * d-valprint.c: Sort headers.
9953         * d-namespace.c: Sort headers.
9954         * d-lang.c: Sort headers.
9955         * ctf.c: Sort headers.
9956         * csky-tdep.c: Sort headers.
9957         * csky-linux-tdep.c: Sort headers.
9958         * cris-tdep.c: Sort headers.
9959         * cris-linux-tdep.c: Sort headers.
9960         * cp-valprint.c: Sort headers.
9961         * cp-support.c: Sort headers.
9962         * cp-namespace.c: Sort headers.
9963         * cp-abi.c: Sort headers.
9964         * corelow.c: Sort headers.
9965         * corefile.c: Sort headers.
9966         * continuations.c: Sort headers.
9967         * completer.h: Sort headers.
9968         * completer.c: Sort headers.
9969         * complaints.c: Sort headers.
9970         * coffread.c: Sort headers.
9971         * coff-pe-read.c: Sort headers.
9972         * cli-out.h: Sort headers.
9973         * cli-out.c: Sort headers.
9974         * charset.c: Sort headers.
9975         * c-varobj.c: Sort headers.
9976         * c-valprint.c: Sort headers.
9977         * c-typeprint.c: Sort headers.
9978         * c-lang.c: Sort headers.
9979         * buildsym.c: Sort headers.
9980         * buildsym-legacy.c: Sort headers.
9981         * build-id.h: Sort headers.
9982         * build-id.c: Sort headers.
9983         * btrace.c: Sort headers.
9984         * bsd-uthread.c: Sort headers.
9985         * breakpoint.h: Sort headers.
9986         * breakpoint.c: Sort headers.
9987         * break-catch-throw.c: Sort headers.
9988         * break-catch-syscall.c: Sort headers.
9989         * break-catch-sig.c: Sort headers.
9990         * blockframe.c: Sort headers.
9991         * block.c: Sort headers.
9992         * bfin-tdep.c: Sort headers.
9993         * bfin-linux-tdep.c: Sort headers.
9994         * bfd-target.c: Sort headers.
9995         * bcache.c: Sort headers.
9996         * ax-general.c: Sort headers.
9997         * ax-gdb.h: Sort headers.
9998         * ax-gdb.c: Sort headers.
9999         * avr-tdep.c: Sort headers.
10000         * auxv.c: Sort headers.
10001         * auto-load.c: Sort headers.
10002         * arm-wince-tdep.c: Sort headers.
10003         * arm-tdep.c: Sort headers.
10004         * arm-symbian-tdep.c: Sort headers.
10005         * arm-pikeos-tdep.c: Sort headers.
10006         * arm-obsd-tdep.c: Sort headers.
10007         * arm-nbsd-tdep.c: Sort headers.
10008         * arm-nbsd-nat.c: Sort headers.
10009         * arm-linux-tdep.c: Sort headers.
10010         * arm-linux-nat.c: Sort headers.
10011         * arm-fbsd-tdep.c: Sort headers.
10012         * arm-fbsd-nat.c: Sort headers.
10013         * arm-bsd-tdep.c: Sort headers.
10014         * arch-utils.c: Sort headers.
10015         * arc-tdep.c: Sort headers.
10016         * arc-newlib-tdep.c: Sort headers.
10017         * annotate.h: Sort headers.
10018         * annotate.c: Sort headers.
10019         * amd64-windows-tdep.c: Sort headers.
10020         * amd64-windows-nat.c: Sort headers.
10021         * amd64-tdep.c: Sort headers.
10022         * amd64-sol2-tdep.c: Sort headers.
10023         * amd64-obsd-tdep.c: Sort headers.
10024         * amd64-obsd-nat.c: Sort headers.
10025         * amd64-nbsd-tdep.c: Sort headers.
10026         * amd64-nbsd-nat.c: Sort headers.
10027         * amd64-nat.c: Sort headers.
10028         * amd64-linux-tdep.c: Sort headers.
10029         * amd64-linux-nat.c: Sort headers.
10030         * amd64-fbsd-tdep.c: Sort headers.
10031         * amd64-fbsd-nat.c: Sort headers.
10032         * amd64-dicos-tdep.c: Sort headers.
10033         * amd64-darwin-tdep.c: Sort headers.
10034         * amd64-bsd-nat.c: Sort headers.
10035         * alpha-tdep.c: Sort headers.
10036         * alpha-obsd-tdep.c: Sort headers.
10037         * alpha-nbsd-tdep.c: Sort headers.
10038         * alpha-mdebug-tdep.c: Sort headers.
10039         * alpha-linux-tdep.c: Sort headers.
10040         * alpha-linux-nat.c: Sort headers.
10041         * alpha-bsd-tdep.c: Sort headers.
10042         * alpha-bsd-nat.c: Sort headers.
10043         * aix-thread.c: Sort headers.
10044         * agent.c: Sort headers.
10045         * addrmap.c: Sort headers.
10046         * ada-varobj.c: Sort headers.
10047         * ada-valprint.c: Sort headers.
10048         * ada-typeprint.c: Sort headers.
10049         * ada-tasks.c: Sort headers.
10050         * ada-lang.c: Sort headers.
10051         * aarch64-tdep.c: Sort headers.
10052         * aarch64-ravenscar-thread.c: Sort headers.
10053         * aarch64-newlib-tdep.c: Sort headers.
10054         * aarch64-linux-tdep.c: Sort headers.
10055         * aarch64-linux-nat.c: Sort headers.
10056         * aarch64-fbsd-tdep.c: Sort headers.
10057         * aarch64-fbsd-nat.c: Sort headers.
10058         * aarch32-linux-nat.c: Sort headers.
10059
10060 2019-04-04  Tom Tromey  <tom@tromey.com>
10061
10062         * varobj.c (varobj_create): Update.
10063         * rust-exp.y (struct rust_parser) <update_innermost_block,
10064         lookup_symbol>: New methods.
10065         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
10066         Rename.
10067         (rust_parser::rust_lookup_type)
10068         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
10069         * printcmd.c (display_command, do_one_display): Update.
10070         * parser-defs.h (struct parser_state) <parser_state>: Add
10071         "tracker" parameter.
10072         (block_tracker): New member.
10073         (class innermost_block_tracker) <innermost_block_tracker>: Add
10074         "types" parameter.
10075         <reset>: Remove method.
10076         (innermost_block): Don't declare.
10077         (null_post_parser): Update.
10078         * parse.c (innermost_block): Remove global.
10079         (write_dollar_variable): Update.
10080         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
10081         Remove "tracker_types" parameter.
10082         (parse_expression): Add "tracker" parameter.
10083         (parse_expression_for_completion): Update.
10084         (null_post_parser): Add "tracker" parameter.
10085         * p-exp.y: Update rules.
10086         * m2-exp.y: Update rules.
10087         * language.h (struct language_defn) <la_post_parser>: Add
10088         "tracker" parameter.
10089         * go-exp.y: Update rules.
10090         * f-exp.y: Update rules.
10091         * expression.h (parse_expression, parse_exp_1): Add "tracker"
10092         parameter.
10093         * d-exp.y: Update rules.
10094         * c-exp.y: Update rules.
10095         * breakpoint.c (set_breakpoint_condition): Create an
10096         innermost_block_tracker.
10097         (watch_command_1): Likewise.
10098         * ada-lang.c (resolve): Add "tracker" parameter.
10099         (resolve_subexp): Likewise.
10100         * ada-exp.y (write_var_from_sym): Update.
10101
10102 2019-04-04  Tom Tromey  <tom@tromey.com>
10103
10104         * type-stack.h: New file.
10105         * type-stack.c: New file.
10106         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
10107         type-stack.h.
10108         (insert_into_type_stack, insert_type, push_type, push_type_int)
10109         (insert_type_address_space, pop_type, pop_type_int)
10110         (pop_typelist, pop_type_stack, append_type_stack)
10111         (push_type_stack, get_type_stack, push_typelist)
10112         (follow_type_instance_flags, follow_types): Don't declare.
10113         * parse.c (type_stack): Remove global.
10114         (parse_exp_in_context): Update.
10115         (insert_into_type_stack, insert_type, push_type, push_type_int)
10116         (insert_type_address_space, pop_type, pop_type_int)
10117         (pop_typelist, pop_type_stack, append_type_stack)
10118         (push_type_stack, get_type_stack, push_typelist)
10119         (follow_type_instance_flags, follow_types): Remove (moved to
10120         type-stack.c).
10121         * f-exp.y (type_stack): New global.
10122         Update rules.
10123         (push_kind_type, f_parse): Update.
10124         * d-exp.y (type_stack): New global.
10125         Update rules.
10126         (d_parse): Update.
10127         * c-exp.y (struct c_parse_state) <type_stack>: New member.
10128         Update rules.
10129         * Makefile.in (COMMON_SFILES): Add type-stack.c.
10130         (HFILES_NO_SRCDIR): Add type-stack.h.
10131
10132 2019-04-04  Tom Tromey  <tom@tromey.com>
10133
10134         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
10135         (rust_parser::convert_ast_to_expression, rust_parse)
10136         (rust_lex_test_completion, rust_lex_tests): Update.
10137         * parser-defs.h (struct expr_completion_state): New.
10138         (struct parser_state) <parser_state>: Add completion parameter.
10139         <mark_struct_expression, mark_completion_tag>: New methods.
10140         <parse_completion, m_completion_state>: New members.
10141         (prefixify_expression, null_post_parser): Update.
10142         (mark_struct_expression, mark_completion_tag): Don't declare.
10143         * parse.c (parse_completion, expout_last_struct)
10144         (expout_tag_completion_type, expout_completion_name): Remove
10145         globals.
10146         (parser_state::mark_struct_expression)
10147         (parser_state::mark_completion_tag): Now methods.
10148         (prefixify_expression): Add last_struct parameter.
10149         (prefixify_subexp): Likewise.
10150         (parse_exp_1): Update.
10151         (parse_exp_in_context): Add cstate parameter.  Update.
10152         (parse_expression_for_completion): Create an
10153         expr_completion_state.
10154         (null_post_parser): Add "completion" parameter.
10155         * p-exp.y: Update rules.
10156         (yylex): Update.
10157         * language.h (struct language_defn) <la_post_parser>: Add
10158         "completing" parameter.
10159         * go-exp.y: Update rules.
10160         (lex_one_token): Update.
10161         * expression.h (parse_completion): Don't declare.
10162         * d-exp.y: Update rules.
10163         (lex_one_token): Update rules.
10164         * c-exp.y: Update rules.
10165         (lex_one_token): Update.
10166         * ada-lang.c (resolve): Add "parse_completion" parameter.
10167         (resolve_subexp): Likewise.
10168         (ada_resolve_function): Likewise.
10169
10170 2019-04-04  Tom Tromey  <tom@tromey.com>
10171
10172         * parser-defs.h (struct parser_state) <start_arglist,
10173         end_arglist>: New methods.
10174         <arglist_len, m_funcall_chain>: New members.
10175         (arglist_len, start_arglist, end_arglist): Don't declare.
10176         * parse.c (arglist_len, funcall_chain): Remove global.
10177         (start_arglist, end_arglist): Remove functions.
10178         (parse_exp_in_context): Update.
10179         * p-exp.y: Update rules.
10180         * m2-exp.y: Update rules.
10181         * go-exp.y: Update rules.
10182         * f-exp.y: Update rules.
10183         * d-exp.y: Update rules.
10184         * c-exp.y: Update rules.
10185
10186 2019-04-04  Tom Tromey  <tom@tromey.com>
10187
10188         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
10189         lex_operator, push_back>: New methods.
10190         Update all rules.
10191         (rust_parser::lex_hex, lex_escape): Rename and update.
10192         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
10193         (rust_parser::lex_operator): Rename and update.
10194         (rust_parser::lex_number, rustyylex, rustyyerror)
10195         (rust_lex_test_init, rust_lex_test_sequence)
10196         (rust_lex_test_push_back, rust_lex_tests): Update.
10197         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
10198         parameter.
10199         <lexptr, prev_lexptr>: New members.
10200         (lexptr, prev_lexptr): Don't declare.
10201         * parse.c (lexptr, prev_lexptr): Remove globals.
10202         (parse_exp_in_context): Update.
10203         * p-exp.y (yylex, yyerror): Update.
10204         * m2-exp.y (parse_number, yylex, yyerror): Update.
10205         * go-exp.y (lex_one_token, yyerror): Update.
10206         * f-exp.y (match_string_literal, yylex, yyerror): Update.
10207         * d-exp.y (lex_one_token, yyerror): Update.
10208         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
10209         (lex_one_token, yyerror): Update.
10210         * ada-lex.l (YY_INPUT): Update.
10211         (rewind_to_char): Update.
10212         * ada-exp.y (yyerror): Update.
10213
10214 2019-04-04  Tom Tromey  <tom@tromey.com>
10215
10216         * rust-exp.y (rustyylex, rust_lex_tests): Update.
10217         * parser-defs.h (struct parser_state) <parser_state>: Add new
10218         parameter.
10219         <comma_terminates>: New member.
10220         (comma_terminates): Don't declare global.
10221         * parse.c (comma_terminates): Remove global.
10222         (parse_exp_in_context): Update.
10223         * p-exp.y (yylex): Update.
10224         * m2-exp.y (yylex): Update.
10225         * go-exp.y (lex_one_token): Update.
10226         * f-exp.y (yylex): Update.
10227         * d-exp.y (lex_one_token): Update.
10228         * c-exp.y (lex_one_token): Update.
10229         * ada-lex.l: Update.
10230
10231 2019-04-04  Tom Tromey  <tom@tromey.com>
10232
10233         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
10234         (rustyylex, rust_lex_test_init, rust_lex_test_one)
10235         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
10236         * parser-defs.h (paren_depth): Don't declare.
10237         * parse.c (paren_depth): Remove global.
10238         (parse_exp_in_context): Update.
10239         * p-exp.y (paren_depth): New global.
10240         (pascal_parse): Initialize it.
10241         * m2-exp.y (paren_depth): New global.
10242         (m2_parse): Initialize it.
10243         * go-exp.y (paren_depth): New global.
10244         (go_parse): Initialize it.
10245         * f-exp.y (paren_depth): New global.
10246         (f_parse): Initialize it.
10247         * d-exp.y (paren_depth): New global.
10248         (d_parse): Initialize it.
10249         * c-exp.y (paren_depth): New global.
10250         (c_parse): Initialize it.
10251         * ada-lex.l (paren_depth): New global.
10252         (lexer_init): Initialize it.
10253
10254 2019-04-04  Tom Tromey  <tom@tromey.com>
10255
10256         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
10257         (rust_parser::convert_ast_to_type)
10258         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
10259         * parser-defs.h (struct parser_state) <parser_state>: Add
10260         parameters.  Initialize new members.
10261         <expression_context_block, expression_context_pc>: New members.
10262         * parse.c (expression_context_block, expression_context_pc):
10263         Remove globals.
10264         (parse_exp_in_context): Update.
10265         * p-exp.y: Update all rules.
10266         (yylex): Update.
10267         * m2-exp.y: Update all rules.
10268         (yylex): Update.
10269         * go-exp.y (yylex): Update.
10270         * f-exp.y (yylex): Update.
10271         * d-exp.y: Update all rules.
10272         (yylex): Update.
10273         * c-exp.y: Update all rules.
10274         (lex_one_token, classify_name, yylex, c_parse): Update.
10275         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
10276
10277 2019-04-04  Tom Tromey  <tom@tromey.com>
10278
10279         * gdbarch.h, gdbarch.c: Rebuild.
10280         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
10281         * stap-probe.h:
10282         (struct stap_parse_info): Replace "parser_state" with
10283         "expr_builder".
10284         * parser-defs.h (struct expr_builder): Rename from "parser_state".
10285         (parser_state): New class.
10286         * parse.c (expr_builder): Rename.
10287         (expr_builder::release): Rename.
10288         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
10289         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
10290         (write_exp_elt_longcst, write_exp_elt_floatcst)
10291         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
10292         (write_exp_string_vector, write_exp_bitstring)
10293         (write_exp_msymbol, mark_struct_expression)
10294         (write_dollar_variable)
10295         (insert_type_address_space, increase_expout_size): Replace
10296         "parser_state" with "expr_builder".
10297         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
10298         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
10299         "parser_state" with "expr_builder".
10300
10301 2019-04-04  Tom Tromey  <tom@tromey.com>
10302
10303         * rust-exp.y: Replace "parse_language" with method call.
10304         * p-exp.y:
10305         (yylex): Replace "parse_language" with method call.
10306         * m2-exp.y:
10307         (yylex): Replace "parse_language" with method call.
10308         * go-exp.y (classify_name): Replace "parse_language" with method
10309         call.
10310         * f-exp.y (yylex): Replace "parse_language" with method call.
10311         * d-exp.y (lex_one_token): Replace "parse_language" with method
10312         call.
10313         * c-exp.y:
10314         (lex_one_token, classify_name, yylex): Replace "parse_language"
10315         with method call.
10316         * ada-exp.y (find_primitive_type, type_char)
10317         (type_system_address): Replace "parse_language" with method call.
10318
10319 2019-04-04  Tom Tromey  <tom@tromey.com>
10320
10321         * rust-exp.y: Replace "parse_gdbarch" with method call.
10322         * parse.c (write_dollar_variable, insert_type_address_space):
10323         Replace "parse_gdbarch" with method call.
10324         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
10325         call.
10326         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
10327         call.
10328         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
10329         "parse_gdbarch" with method call.
10330         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
10331         with method call.
10332         * f-exp.y (parse_type, parse_f_type, yylex): Replace
10333         "parse_gdbarch" with method call.
10334         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
10335         "parse_gdbarch" with method call.
10336         * c-exp.y (parse_type, parse_number, classify_name): Replace
10337         "parse_gdbarch" with method call.
10338         * ada-lex.l: Replace "parse_gdbarch" with method call.
10339         * ada-exp.y (parse_type, find_primitive_type, type_char)
10340         (type_system_address): Replace "parse_gdbarch" with method call.
10341
10342 2019-04-04  Tom Tromey  <tom@tromey.com>
10343
10344         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
10345         * stap-probe.c (stap_parse_argument): Update.
10346         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
10347         initial_size parameter.
10348         * rust-exp.y (rust_lex_tests): Update.
10349         * parse.c (parser_state): Update.
10350         (parse_exp_in_context): Update.
10351         * parser-defs.h (struct parser_state) <parser_state>: Remove
10352         "initial_size" parameter.
10353
10354 2019-04-04  Tom Tromey  <tom@tromey.com>
10355
10356         * parser-defs.h (increase_expout_size): Don't declare.
10357         * parse.c (increase_expout_size): Now static.
10358
10359 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
10360
10361         * gnu-nat.c (gnu_nat_target::wait): Fix
10362         target_waitstatus_to_string call.
10363
10364 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
10365
10366         * eval.c (evaluate_subexp_standard): Handle internal functions
10367         during Fortran function call handling.
10368
10369 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
10370
10371         * NEWS: Mention new internal functions.
10372         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
10373         (read_base_type): Use dwarf2_init_complex_target_type.
10374         * value.c (creal_internal_fn): New function.
10375         (cimag_internal_fn): New function.
10376         (_initialize_values): Register new internal functions.
10377
10378 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10379
10380         * infrun.c (stop_all_threads): If debug_infrun, always
10381         trace the wait status after wait_one, using
10382         target_waitstatus_to_string and target_pid_to_str.
10383         (handle_inferior_event): Replace various trace of
10384         wait status kind by a single trace.
10385         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
10386         wait status kind image by target_waitstatus_to_string.
10387         * target/waitstatus.c (target_waitstatus_to_string): Fix
10388         obsolete comment.
10389
10390 2019-04-01  Tom Tromey  <tromey@adacore.com>
10391
10392         PR symtab/23331:
10393         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
10394
10395 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
10396             Pedro Alves  <palves@redhat.com>
10397
10398         * top.c (quit_force): Call 'finalize_values'.
10399         * value.c (finalize_values): New function.
10400         * value.h (finalize_values): Declare.
10401
10402 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
10403
10404         * NEWS: Announce $_gdb_major and $_gdb_minor.
10405
10406         * top.c (init_gdb_version_vars): New function.
10407         (gdb_init): Call init_gdb_version_vars.
10408
10409 2019-03-29  Tom Tromey  <tromey@adacore.com>
10410
10411         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
10412         help text.  Remove dead code.
10413
10414 2019-03-29  Keith Seitz  <keiths@redhat.com>
10415
10416         From Siddhesh Poyarekar:
10417         * f-lang.h (f77_get_upperbound): Return LONGEST.
10418         (f77_get_lowerbound): Likewise.
10419         * f-typeprint.c (f_type_print_varspec_suffix): Expand
10420         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
10421         print them.
10422         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
10423         plongest to format print it.
10424         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
10425         (f77_get_upperbound): Likewise.
10426         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
10427         LOWER_BOUND to LONGEST.
10428         (f77_create_arrayprint_offset_tbl): Likewise.
10429
10430 2019-03-29  Keith Seitz  <keiths@redhat.com>
10431
10432         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
10433         %s/pulongest for TYPE_LENGTH instead of %d in format
10434         strings.
10435         * ada-typerint.c (ada_print_type): Likewise.
10436         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
10437         * compile/compile-c-support.c (generate_register_struct): Likewise.
10438         * gdbtypes.c (recursive_dump_type): Likewise.
10439         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
10440         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
10441         instead of %d in format strings.
10442         * riscv-tdep.c (riscv_type_alignment): Cast second argument
10443         to std::min to ULONGEST.
10444         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
10445         instead of %d in format strings.
10446         * tracepoint.c (info_scope_command): Likewise.
10447         * typeprint.c (print_offset_data::update)
10448         (print_offset_data::finish): Likewise.
10449         * xtensa-tdep.c (xtensa_store_return_value)
10450         (xtensa_push_dummy_call): Likewise.
10451
10452 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
10453
10454         * windows-nat.c (display_selector): Fixed format specifications
10455         for 64-bit Cygwin.
10456
10457 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10458
10459         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
10460
10461 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
10462
10463         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
10464         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
10465         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
10466         (nios2_linux_init_abi): Install it.
10467
10468 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
10469
10470         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
10471
10472 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
10473
10474         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
10475
10476 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10477             Tom Tromey  <tromey@adacore.com>
10478
10479         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
10480
10481 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
10482
10483         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
10484         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
10485         method to compute the bounds of range types. Also print "[evaluated]"
10486         if the bounds' values come from a dynamic evaluation.
10487
10488 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
10489
10490         * cp-valprint.c (cp_print_value_fields): Don't print trailing
10491         whitespace when pretty printing is on.
10492
10493 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
10494
10495         * ppc-linux-nat.c: Add include.
10496
10497 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
10498
10499         * NEWS: Mention AArch64 Pointer Authentication.
10500
10501 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
10502
10503         * arm-linux-nat.c: Add include.
10504
10505 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
10506
10507         * source-cache.c (source_cache::get_source_lines): Re-read
10508         fullname after calling open_source_file.
10509
10510 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
10511
10512         * NEWS: Mention TLS support for FreeBSD.
10513
10514 2019-03-25  Tom Tromey  <tromey@adacore.com>
10515
10516         * minsyms.c (BUNCH_SIZE): Update comment.
10517         (~minimal_symbol_reader): Remove old comment.
10518         (compact_minimal_symbols): Update comment.
10519         (minimal_symbol_reader::install): Remove old comment.  Update
10520         other comments.
10521
10522 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
10523
10524         * s390-linux-nat.c: Add include.
10525
10526 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
10527
10528         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
10529         Call linux_get_hwcap.
10530         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
10531         Likewise.
10532         (aarch64_linux_get_hwcap): Remove function.
10533         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
10534         declaration.
10535         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
10536         linux_get_hwcap.
10537         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
10538         * linux-tdep.c (linux_get_hwcap): Add function.
10539         (linux_get_hwcap2): Likewise.
10540         * linux-tdep.h (linux_get_hwcap): Add declaration.
10541         (linux_get_hwcap2): Likewise.
10542         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
10543         (ppc_linux_get_hwcap2): Likewise.
10544         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
10545         linux_get_hwcap.
10546         (ppc_linux_nat_target::insert_watchpoint): Likewise.
10547         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
10548         (ppc_linux_nat_target::read_description): Likewise.
10549         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
10550         * s390-linux-nat.c: Likewise.
10551         * s390-linux-tdep.c (s390_core_read_description): Likewise.
10552
10553 2019-03-24  Tom Tromey  <tom@tromey.com>
10554
10555         * ada-lang.c (standard_lookup): Simplify initialization.
10556         (ada_lookup_symbol_nonlocal): Simplify return.
10557         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
10558         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
10559         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
10560         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
10561         initialization.
10562         * solib.c (solib_global_lookup): Simplify.
10563         * symtab.c (null_block_symbol): Remove.
10564         (symbol_cache_lookup): Simplify returns.
10565         (lookup_language_this): Simplify returns.
10566         (lookup_symbol_aux): Simplify return.
10567         (lookup_local_symbol): Simplify returns.
10568         (lookup_global_symbol_from_objfile): Simplify return.
10569         (lookup_symbol_in_objfile_symtabs)
10570         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
10571         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
10572         (lookup_static_symbol, lookup_global_symbol): Simplify return.
10573         * cp-namespace.c (cp_lookup_bare_symbol)
10574         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
10575         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
10576         (cp_lookup_nested_symbol): Don't use null_block_symbol.
10577         (cp_lookup_symbol_via_imports): Simplify initialization.
10578         (find_symbol_in_baseclass): Likewise.
10579         * symtab.h (null_block_symbol): Remove.
10580         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
10581         (d_lookup_nested_symbol, d_lookup_symbol_imports)
10582         (d_lookup_symbol_module): Likewise.
10583         (find_symbol_in_baseclass): Simplify initialization.
10584
10585 2019-03-24  Tom Tromey  <tom@tromey.com>
10586
10587         * expression.h: Don't include symtab.h.
10588         (struct block): Forward declare.
10589
10590 2019-03-24  Tom Tromey  <tom@tromey.com>
10591
10592         * c-exp.y (typebase): Remove casts.
10593         * gdbtypes.c (lookup_unsigned_typename, )
10594         (lookup_signed_typename): Remove cast.
10595         * eval.c (parse_to_comma_and_eval): Remove cast.
10596         * parse.c (write_dollar_variable): Remove cast.
10597         * block.h (struct block) <superblock>: Now const.
10598         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
10599         * psymtab.c (psym_map_matching_symbols): Make "block" const.
10600         (map_block): Make "block" const.
10601         * symfile.h (struct quick_symbol_functions)
10602         <map_matching_symbols>: Constify block argument to "callback".
10603         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
10604         const.
10605         (find_pc_sect_compunit_symtab): Make "b" const.
10606         (find_symbol_at_address): Likewise.
10607         (search_symbols): Likewise.
10608         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
10609         (dw2_debug_names_lookup_symbol): Likewise.
10610         (dw2_map_matching_symbols): Update.
10611         * p-valprint.c (pascal_val_print): Remove "block".
10612         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
10613         (aux_add_nonlocal_symbols): Make "block" const.
10614         (resolve_subexp): Remove cast.
10615         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
10616         const.
10617         (iterate_over_file_blocks): Likewise.
10618         * f-exp.y (%union) <bval>: Remove.
10619         * coffread.c (patch_opaque_types): Make "b" const.
10620         * spu-tdep.c (spu_catch_start): Make "block" const.
10621         * c-valprint.c (print_unpacked_pointer): Remove "block".
10622         * symmisc.c (dump_symtab_1): Make "b" const.
10623         (block_depth): Make "block" const.
10624         * d-exp.y (%union) <bval>: Remove.
10625         * cp-support.h (cp_lookup_rtti_type): Update.
10626         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
10627         * psymtab.c (psym_lookup_symbol): Make "block" const.
10628         (maintenance_check_psymtabs): Make "b" const.
10629         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
10630         (enumerate_locals, enumerate_args): Update.
10631         * python/py-symtab.c (stpy_global_block): Make "block" const.
10632         (stpy_static_block): Likewise.
10633         * inline-frame.c (block_starting_point_at): Make "new_block"
10634         const.
10635         * block.c (find_block_in_blockvector): Make return type const.
10636         (blockvector_for_pc_sect): Make "b" const.
10637         (find_block_in_blockvector): Make "b" const.
10638
10639 2019-03-23  Tom Tromey  <tom@tromey.com>
10640
10641         * varobj.c (varobj_create): Update.
10642         * symfile.c (clear_symtab_users): Don't reset innermost_block.
10643         * printcmd.c (display_command, do_one_display): Don't reset
10644         innermost_block.
10645         * parser-defs.h (enum innermost_block_tracker_type): Move to
10646         expression.h.
10647         (innermost_block): Update comment.
10648         * parse.c (parse_exp_1): Add tracker_types parameter.
10649         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
10650         tracker_types parameter.  Reset innermost_block.
10651         (parse_exp_in_context): Remove.
10652         (parse_expression_for_completion): Update.
10653         * objfiles.c (~objfile): Don't reset expression_context_block or
10654         innermost_block.
10655         * expression.h (enum innermost_block_tracker_type): Move from
10656         parser-defs.h.
10657         (parse_exp_1): Add tracker_types parameter.
10658         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
10659         reset innermost_block.
10660
10661 2019-03-23  Tom Tromey  <tom@tromey.com>
10662
10663         * objfiles.h: Include bcache.h.
10664
10665 2019-03-23  Tom Tromey  <tom@tromey.com>
10666
10667         * linespec.c (get_current_search_block): Use
10668         scoped_restore_current_language.
10669         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
10670
10671 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10672             Jiong Wang  <jiong.wang@arm.com>
10673
10674         * aarch64-linux-tdep.c
10675         (aarch64_linux_iterate_over_regset_sections): Check for pauth
10676         section.
10677         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
10678
10679 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10680             Jiong Wang  <jiong.wang@arm.com>
10681
10682         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
10683         instructions.
10684         (aarch64_analyze_prologue_test): Add PACIASP test.
10685         (aarch64_prologue_prev_register): Unmask PC value.
10686
10687 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10688             Jiong Wang  <jiong.wang@arm.com>
10689
10690         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
10691         (aarch64_dwarf2_prev_register): Unmask PC value.
10692         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
10693         (aarch64_execute_dwarf_cfa_vendor_op): Check for
10694         DW_CFA_AARCH64_negate_ra_state.
10695         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
10696
10697 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10698             Jiong Wang  <jiong.wang@arm.com>
10699
10700         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
10701         registers.
10702         (aarch64_pseudo_register_name): Likewise.
10703         (aarch64_pseudo_register_type): Likewise.
10704         (aarch64_pseudo_register_reggroup_p): Likewise.
10705         (aarch64_gdbarch_init): Add pauth registers.
10706         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
10707         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
10708         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
10709         (struct gdbarch_tdep): Add regnum for ra_state.
10710
10711 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10712             Jiong Wang  <jiong.wang@arm.com>
10713
10714         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
10715
10716 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10717             Jiong Wang  <jiong.wang@arm.com>
10718
10719         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
10720         function.
10721         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
10722         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
10723         (aarch64_gdbarch_init): Add puth registers.
10724         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
10725         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
10726         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
10727
10728 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10729             Jiong Wang  <jiong.wang@arm.com>
10730
10731         * aarch64-linux-nat.c
10732         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
10733         * aarch64-linux-tdep.c
10734         (aarch64_linux_core_read_description): Likewise.
10735         (aarch64_linux_get_hwcap): New function.
10736         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
10737         (aarch64_linux_get_hwcap): New declaration.
10738
10739 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10740             Jiong Wang  <jiong.wang@arm.com>
10741
10742         * aarch64-linux-nat.c
10743         (aarch64_linux_nat_target::read_description): Add pauth param.
10744         * aarch64-linux-tdep.c
10745         (aarch64_linux_core_read_description): Likewise.
10746         * aarch64-tdep.c (struct target_desc): Add in pauth.
10747         (aarch64_read_description): Add pauth param.
10748         (aarch64_gdbarch_init): Likewise.
10749         * aarch64-tdep.h (aarch64_read_description): Likewise.
10750         * arch/aarch64.c (aarch64_create_target_description): Likewise.
10751         * arch/aarch64.h (aarch64_create_target_description): Likewise.
10752         * features/Makefile: Add new files.
10753         * features/aarch64-pauth.c: New file.
10754         * features/aarch64-pauth.xml: New file.
10755
10756 2019-03-20  Tom Tromey  <tromey@adacore.com>
10757
10758         * infrun.c (handle_inferior_event): Rename from
10759         handle_inferior_event_1.  Create a scoped_value_mark.
10760         (handle_inferior_event): Remove.
10761
10762 2019-03-19  Tom Tromey  <tromey@adacore.com>
10763
10764         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
10765         * infrun.h (print_stop_event): Add "displays" parameter.
10766         * infrun.c (print_stop_event): Add "displays" parameter.
10767
10768 2019-03-19  Pedro Alves  <palves@redhat.com>
10769
10770         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
10771         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
10772         to -1.  Fix TABs vs spaces.
10773         (tui_ui_out::tui_ui_out): Don't initialize fields here.
10774         * tui/tui-out.h (tui_ui_out) Add intro comments.
10775         <m_line, m_start_of_line>: In-class initialize, and add describing
10776         comment.
10777
10778 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
10779
10780         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
10781         variable names.
10782         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
10783
10784 2019-03-18  Pedro Alves  <palves@redhat.com>
10785             Eli Zaretskii <eliz@gnu.org>
10786
10787         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
10788         m_line and m_start_of_line.
10789
10790 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
10791
10792         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
10793         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
10794         it returns a newline.  This fixes a regression in TU mode, whereby
10795         the next line is output on the same screen line as the user input.
10796
10797 2019-03-18  Tom Tromey  <tromey@adacore.com>
10798
10799         * minsyms.c (minimal_symbol_reader::install): Remove call to
10800         obstack_blank.
10801
10802 2019-03-18  Pedro Alves  <palves@redhat.com>
10803
10804         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
10805         New globals.
10806         (apply_style): New, factored out from ...
10807         (apply_ansi_escape): ... this.  Handle reverse video mode.
10808         (tui_set_reverse_mode): New function.
10809         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
10810         * tui/tui-winsource.c (tui_show_source_line): Use
10811         tui_set_reverse_mode instead of setting A_STANDOUT.
10812         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
10813         New setter methods.
10814
10815 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
10816
10817         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
10818         Handle tabs.
10819
10820 2019-03-18  Tom Tromey  <tromey@adacore.com>
10821
10822         * ada-lang.c (empty_array): Add "high" parameter.
10823         (ada_evaluate_subexp): Update.
10824
10825 2019-03-17  Sergei Trofimovich <siarheit@google.com>
10826
10827         * unittests/string_view-selftests.c: Define
10828         _initialize_string_view_selftests unconditionally.
10829
10830 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
10831
10832         PR gdb/24350
10833         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
10834
10835 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
10836
10837         PR gdb/24351
10838         * windows-nat.c (display_selector): Fix format specifiers.
10839
10840 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
10841
10842         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
10843         tui_refill_source_window instead of tui_refresh_win, to update the
10844         current execution line.  This fixes redisplay of the current line
10845         when stepping through the code with "next" or "step".
10846
10847 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
10848
10849         * source-cache.c (source_cache::get_source_lines): Call
10850         find_source_lines to initialize s->nlines.  This fixes vertical
10851         scrolling of TUI source window when the DOWN arrow is pressed.
10852
10853 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10854
10855         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
10856         linux-thread-db.c (_initialize_thread_db): Likewise.
10857
10858 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
10859
10860         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
10861         wclrtoeol in tui_show_source_line".  This reverts changes made in
10862         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
10863
10864 2019-03-15  Tom Tromey  <tom@tromey.com>
10865
10866         * symtab.h (struct minimal_symbol): Derive from
10867         general_symbol_info.
10868         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
10869         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
10870         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
10871         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
10872         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
10873         (MSYMBOL_SEARCH_NAME): Update.
10874         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
10875         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
10876         * minsyms.c (minimal_symbol_reader::record_full): Update.
10877
10878 2019-03-15  Tom Tromey  <tom@tromey.com>
10879
10880         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
10881
10882 2019-03-15  Tom Tromey  <tom@tromey.com>
10883
10884         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
10885         unique_xmalloc_ptr.
10886         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
10887         Update.
10888         * minsyms.c (lookup_minimal_symbol_by_pc_section)
10889         (build_minimal_symbol_hash_tables)
10890         (minimal_symbol_reader::install): Update.
10891
10892 2019-03-15  Tom Tromey  <tom@tromey.com>
10893
10894         * symtab.c (create_demangled_names_hash): Update.
10895         (symbol_set_names): Update.
10896         * objfiles.h (struct objfile_per_bfd_storage)
10897         <demangled_names_hash>: Now an htab_up.
10898         * objfiles.c (objfile_per_bfd_storage): Simplify.
10899
10900 2019-03-15  Tom Tromey  <tom@tromey.com>
10901
10902         * objfiles.h (struct objfile_per_bfd_storage): Declare
10903         destructor.
10904         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
10905         New.
10906         (get_objfile_bfd_data): Use new.  Don't initialize
10907         language_of_main.
10908         (free_objfile_per_bfd_storage): Remove.
10909         (objfile_bfd_data_free, objfile::~objfile): Use delete.
10910
10911 2019-03-15  Tom Tromey  <tom@tromey.com>
10912
10913         * symfile.c (reread_symbols): Update.
10914         * objfiles.c (objfile::objfile): Update.
10915         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
10916         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
10917         comment.
10918         (minimal_symbol_reader::install): Update.
10919         (terminate_minimal_symbol_table): Remove.
10920         * jit.c (jit_object_close_impl): Update.
10921
10922 2019-03-15  Tom Tromey  <tom@tromey.com>
10923
10924         * minsyms.c (minimal_symbol_reader::record_full): Remove some
10925         initializations.
10926
10927 2019-03-15  Tom Tromey  <tom@tromey.com>
10928
10929         * objfiles.h (struct objfile_per_bfd_storage)
10930         <demangled_hash_languages>: Now a bitset.
10931         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
10932         (lookup_minimal_symbol): Update.
10933
10934 2019-03-15  Tom Tromey  <tom@tromey.com>
10935
10936         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
10937         Don't return the symbol.
10938         * coffread.c (record_minimal_symbol): Use record_full.
10939
10940 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
10941
10942         The MS-Windows port of ncurses fails to switch to a color pair if
10943         one or both of the colors are the implicit default colors.  This
10944         change records the default colors when TUI is initialized, and
10945         then specifies them explicitly when a color pair uses the default
10946         colors.  This allows color styling in TUI mode on MS-Windows.
10947
10948         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
10949         ncurses_norm_attr.
10950         (tui_initialize_io) [__MINGW32__]: Record the default terminal
10951         colors in ncurses_norm_attr.
10952         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
10953         "none", replace it with the default color recorded in
10954         ncurses_norm_attr.
10955
10956 2019-03-14  Tom Tromey  <tromey@adacore.com>
10957
10958         * source-cache.h (class source_cache) <get_source_lines>: Return
10959         std::string.
10960         * source-cache.c (source_cache::extract_lines): Handle case where
10961         first_pos==npos.  Return std::string.
10962         (source_cache::get_source_lines): Update.
10963
10964 2019-03-14  Tom Tromey  <tromey@adacore.com>
10965
10966         * NEWS: Add item for "style sources" commands.
10967         * source-cache.c (source_cache::get_source_lines): Check
10968         source_styling.
10969         * cli/cli-style.c (source_styling): New global.
10970         (_initialize_cli_style): Add "style sources" commands.
10971         (show_style_sources): New function.
10972         * cli/cli-style.h (source_styling): Declare.
10973
10974 2019-03-14  Pedro Alves  <palves@redhat.com>
10975             Tom Tromey  <tromey@adacore.com>
10976
10977         * tui/tui-winsource.h (tui_refill_source_window): Declare.
10978         * tui/tui-winsource.c (tui_refill_source_window): New function,
10979         from...
10980         (tui_horizontal_source_scroll): ... here.  Move some logic.
10981         * cli/cli-style.c (set_style_enabled): Notify new observable.
10982         * tui/tui-hooks.c (tui_redisplay_source): New function.
10983         (tui_attach_detach_observers): Attach or detach
10984         tui_redisplay_source.
10985         * observable.h (source_styling_changed): New observable.
10986         * observable.c: Define source_styling_changed observable.
10987
10988 2019-03-13  Tom Tromey  <tromey@adacore.com>
10989
10990         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
10991         (i386_gnu_nat_target::store_registers): Update.
10992         * target-debug.h (target_debug_print_std_string): New macro.
10993         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
10994         * windows-tdep.c (display_one_tib): Update.
10995         * tui/tui-stack.c (tui_make_status_line): Update.
10996         * top.c (print_inferior_quit_action): Update.
10997         * thread.c (thr_try_catch_cmd): Update.
10998         (add_thread_with_info): Update.
10999         (thread_target_id_str): Update.
11000         (thr_try_catch_cmd): Update.
11001         (thread_command): Update.
11002         (thread_find_command): Update.
11003         * record-btrace.c (record_btrace_target::info_record)
11004         (record_btrace_resume_thread, record_btrace_target::resume)
11005         (record_btrace_cancel_resume, record_btrace_step_thread)
11006         (record_btrace_target::wait, record_btrace_target::wait)
11007         (record_btrace_target::wait, record_btrace_target::stop): Update.
11008         * progspace.c (print_program_space): Update.
11009         * process-stratum-target.c
11010         (process_stratum_target::thread_address_space): Update.
11011         * linux-fork.c (linux_fork_mourn_inferior)
11012         (detach_checkpoint_command, info_checkpoints_command)
11013         (linux_fork_context): Update.
11014         (linux_fork_detach): Update.
11015         (class scoped_switch_fork_info): Update.
11016         (delete_checkpoint_command): Update.
11017         * infrun.c (follow_fork_inferior): Update.
11018         (follow_fork_inferior): Update.
11019         (proceed_after_vfork_done): Update.
11020         (handle_vfork_child_exec_or_exit): Update.
11021         (follow_exec): Update.
11022         (displaced_step_prepare_throw): Update.
11023         (displaced_step_restore): Update.
11024         (start_step_over): Update.
11025         (resume_1): Update.
11026         (clear_proceed_status_thread): Update.
11027         (proceed): Update.
11028         (print_target_wait_results): Update.
11029         (do_target_wait): Update.
11030         (context_switch): Update.
11031         (stop_all_threads): Update.
11032         (restart_threads): Update.
11033         (finish_step_over): Update.
11034         (handle_signal_stop): Update.
11035         (switch_back_to_stepped_thread): Update.
11036         (keep_going_pass_signal): Update.
11037         (print_exited_reason): Update.
11038         (normal_stop): Update.
11039         * inferior.c (inferior_pid_to_str): Change return type.
11040         (print_selected_inferior): Update.
11041         (add_inferior): Update.
11042         (detach_inferior): Update.
11043         * dummy-frame.c (fprint_dummy_frames): Update.
11044         * dcache.c (dcache_info_1): Update.
11045         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
11046         (btrace_fetch, btrace_clear): Update.
11047         * linux-tdep.c (linux_core_pid_to_str): Change return type.
11048         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
11049         type.
11050         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
11051         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
11052         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
11053         * gdbarch.c, gdbarch.h: Rebuild.
11054         * gdbarch.sh (core_pid_to_str): Change return type.
11055         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
11056         return type.
11057         (windows_nat_target::pid_to_str): Change return type.
11058         (windows_delete_thread): Update.
11059         (windows_nat_target::attach): Update.
11060         (windows_nat_target::files_info): Update.
11061         * target-delegates.c: Rebuild.
11062         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
11063         return type.
11064         (sol_thread_target::pid_to_str): Change return type.
11065         * remote.c (class remote_target) <pid_to_str>: Change return
11066         type.
11067         (remote_target::pid_to_str): Change return type.
11068         (extended_remote_target::attach, remote_target::remote_stop_ns)
11069         (remote_target::remote_notif_remove_queued_reply)
11070         (remote_target::push_stop_reply, remote_target::disable_btrace):
11071         Update.
11072         (extended_remote_target::attach): Update.
11073         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
11074         type.
11075         (gdbsim_target::pid_to_str): Change return type.
11076         * ravenscar-thread.c (struct ravenscar_thread_target)
11077         <pid_to_str>: Change return type.
11078         (ravenscar_thread_target::pid_to_str): Change return type.
11079         * procfs.c (class procfs_target) <pid_to_str>: Change return
11080         type.
11081         (procfs_target::pid_to_str): Change return type.
11082         (procfs_target::attach): Update.
11083         (procfs_target::detach): Update.
11084         (procfs_target::fetch_registers): Update.
11085         (procfs_target::store_registers): Update.
11086         (procfs_target::wait): Update.
11087         (procfs_target::files_info): Update.
11088         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
11089         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
11090         return type.
11091         (nto_procfs_target::pid_to_str): Change return type.
11092         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
11093         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
11094         return type.
11095         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
11096         (exit_lwp): Update.
11097         (attach_proc_task_lwp_callback, get_detach_signal)
11098         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
11099         (linux_nat_target::resume, wait_lwp, stop_callback)
11100         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
11101         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
11102         (linux_nat_wait_1, resume_stopped_resumed_lwps)
11103         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
11104         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
11105         type.
11106         (inf_ptrace_target::attach): Update.
11107         (inf_ptrace_target::files_info): Update.
11108         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
11109         type.
11110         (go32_nat_target::pid_to_str): Change return type.
11111         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
11112         (gnu_nat_target::wait): Update.
11113         (gnu_nat_target::wait): Update.
11114         (gnu_nat_target::resume): Update.
11115         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
11116         (fbsd_nat_target::wait): Update.
11117         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
11118         type.
11119         (darwin_nat_target::attach): Update.
11120         * corelow.c (class core_target) <pid_to_str>: Change return type.
11121         (core_target::pid_to_str): Change return type.
11122         * target.c (normal_pid_to_str): Change return type.
11123         (default_pid_to_str): Likewise.
11124         (target_pid_to_str): Change return type.
11125         (target_translate_tls_address): Update.
11126         (target_announce_detach): Update.
11127         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
11128         return type.
11129         (bsd_uthread_target::pid_to_str): Change return type.
11130         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
11131         type.
11132         (bsd_kvm_target::pid_to_str): Change return type.
11133         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
11134         return type.
11135         (aix_thread_target::pid_to_str): Change return type.
11136         * target.h (struct target_ops) <pid_to_str>: Change return type.
11137         (target_pid_to_str, normal_pid_to_str): Likewise.
11138         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
11139         type.
11140         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
11141         type.
11142         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
11143         return type.
11144         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
11145         type.
11146         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
11147         type.
11148         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
11149         return type.
11150
11151 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
11152
11153         * NEWS: Mention that the new default MI version is 3.  Mention
11154         changes to the output of commands and events that deal with
11155         multi-location breakpoints.
11156         * breakpoint.c: Include "mi/mi-out.h".
11157         (print_one_breakpoint): Change output syntax if using MI version
11158         >= 3.
11159         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
11160         New.
11161         (mi_multi_location_breakpoint_output_fixed): New.
11162         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
11163         (mi_cmd_fix_multi_location_breakpoint_output): New.
11164         (mi_multi_location_breakpoint_output_fixed): New.
11165         * mi/mi-cmds.c (mi_cmds): Register command
11166         -fix-multi-location-breakpoint-output.
11167         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
11168         interpreter "mi".
11169
11170 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
11171
11172         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
11173         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
11174         instantiate mi_ui_out based on interpreter name.
11175         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
11176         * mi/mi-main.c (mi_load_progress): Likewise.
11177
11178 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11179
11180         * NEWS: Combine separate "New targets" sections for 8.3.
11181
11182 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11183
11184         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
11185         (ppcfbsd_init_abi): Install gdbarch
11186         "fetch_tls_load_module_address" and "get_thread_local_address"
11187         methods.
11188
11189 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11190
11191         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
11192         (riscv_fbsd_init_abi): Install gdbarch
11193         "fetch_tls_load_module_address" and "get_thread_local_address"
11194         methods.
11195
11196 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11197
11198         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
11199         (i386fbsd_init_abi): Install gdbarch
11200         "fetch_tls_load_module_address" and "get_thread_local_address"
11201         methods.
11202
11203 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11204
11205         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
11206         (amd64fbsd_init_abi): Install gdbarch
11207         "fetch_tls_load_module_address" and "get_thread_local_address"
11208         methods.
11209
11210 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11211
11212         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
11213         (struct fbsd_pspace_data): New type.
11214         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
11215         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
11216         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
11217         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
11218         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
11219
11220 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11221
11222         * gdbtypes.c (lookup_struct_elt): New function.
11223         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
11224         * gdbtypes.h (struct struct_elt): New type.
11225         (lookup_struct_elt): New prototype.
11226
11227 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11228
11229         * gdbtypes.c (lookup_struct_elt_type): Update comment and
11230         remove disabled code block.
11231
11232 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11233
11234         * gdbarch.sh (get_thread_local_address): New method.
11235         * gdbarch.h, gdbarch.c: Regenerate.
11236         * target.c (target_translate_tls_address): Use
11237         gdbarch_get_thread_local_address if present instead of
11238         target::get_thread_local_address.
11239
11240 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11241
11242         * target.h (target::get_thread_local_address): Update comment.
11243
11244 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11245
11246         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
11247         objfile->separate_debug_objfile_backlink if not NULL.
11248
11249 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11250
11251         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
11252         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
11253         (amd64bsd_store_inferior_registers): Likewise.
11254         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
11255         Enable segment base registers.
11256         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
11257         PT_GETFSBASE and PT_GETGSBASE.
11258         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
11259         PT_SETGSBASE.
11260         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
11261         segment base registers.
11262         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
11263
11264 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11265
11266         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
11267         Update calls to i386_target_description to add 'segments'
11268         parameter.
11269         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
11270         add segment base registers.
11271         * arch/i386.c (i386_create_target_description): Add 'segments'
11272         parameter to enable segment base registers.
11273         * arch/i386.h (i386_create_target_description): Likewise.
11274         * features/i386/32bit-segments.xml: New file.
11275         * features/i386/32bit-segments.c: Generate.
11276         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
11277         call to i386_target_description to add 'segments' parameter.
11278         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
11279         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
11280         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
11281         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
11282         if feature is present.
11283         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
11284         Add 'segments' parameter to call to i386_target_description.
11285         (i386_target_description): Add 'segments' parameter to enable
11286         segment base registers.
11287         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
11288         to call to i386_target_description.
11289         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
11290         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
11291         Define I386_NUM_REGS.
11292         (i386_target_description): Add 'segments' parameter to enable
11293         segment base registers.
11294
11295 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
11296
11297         PR/24325
11298         * source-cache.c: #undef open and close, to avoid unresolved
11299         externals during linking.
11300
11301 2019-03-12  Tom Tromey  <tromey@adacore.com>
11302
11303         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
11304         const.  Add initializers.
11305         (_initialize_remote): Don't initialize ptid globals.
11306
11307 2019-03-12  Pedro Alves  <palves@redhat.com>
11308
11309         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
11310
11311 2019-03-12  Pedro Alves  <palves@redhat.com>
11312
11313         * cp-name-parser.y (main): Remove unused 'len' variable.
11314
11315 2019-03-12  Tom Tromey  <tromey@adacore.com>
11316
11317         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
11318         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
11319
11320 2019-03-12  Tom Tromey  <tromey@adacore.com>
11321
11322         * linux-nat.c (iterate_over_lwps): Update.
11323         (stop_callback): Remove parameter.
11324         (stop_wait_callback, detach_callback, resume_set_callback)
11325         (select_singlestep_lwp_callback, set_ignore_sigint)
11326         (status_callback, resumed_callback, resume_clear_callback)
11327         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
11328         data parameter.
11329         (linux_nat_target::detach, linux_nat_target::resume)
11330         (linux_stop_and_wait_all_lwps, select_event_lwp)
11331         (linux_nat_filter_event, linux_nat_wait_1)
11332         (linux_nat_target::kill, linux_nat_target::stop)
11333         (linux_nat_target::stop): Update.
11334         (linux_nat_resume_callback): Change type.
11335         (resume_stopped_resumed_lwps, count_events_callback)
11336         (select_event_lwp_callback): Likewise.
11337         (linux_stop_lwp, linux_nat_stop_lwp): Update.
11338         * arm-linux-nat.c (struct update_registers_data): Remove.
11339         (update_registers_callback): Change type.
11340         (arm_linux_insert_hw_breakpoint1): Update.
11341         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
11342         parameter.
11343         (x86_linux_dr_set_addr): Update.
11344         (x86_linux_dr_set_control): Update.
11345         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
11346         (iterate_over_lwps): Use gdb::function_view.
11347         * nat/aarch64-linux-hw-point.c (struct
11348         aarch64_dr_update_callback_param): Remove.
11349         (debug_reg_change_callback): Change type.
11350         (aarch64_notify_debug_reg_change): Update.
11351         * s390-linux-nat.c (s390_refresh_per_info): Update.
11352
11353 2019-03-11  Tom Tromey  <tromey@adacore.com>
11354
11355         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
11356         redundant assignment to "this_cu".
11357
11358 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11359
11360         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
11361
11362 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11363
11364         * gdbtypes.c (rank_one_type_parm_set): New function extracted
11365         from...
11366         (rank_one_type): ... this.
11367
11368 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11369
11370         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
11371         from...
11372         (rank_one_type): ... this.
11373
11374 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11375
11376         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
11377         from...
11378         (rank_one_type): ... this.
11379
11380 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11381
11382         * gdbtypes.c (rank_one_type_parm_float): New function extracted
11383         from...
11384         (rank_one_type): ... this.
11385
11386 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11387
11388         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
11389         from...
11390         (rank_one_type): ... this.
11391
11392 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11393
11394         * gdbtypes.c (rank_one_type_parm_range): New function extracted
11395         from...
11396         (rank_one_type): ... this.
11397
11398 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11399
11400         * gdbtypes.c (rank_one_type_parm_char): New function extracted
11401         from...
11402         (rank_one_type): ... this.
11403
11404 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11405
11406         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
11407         from...
11408         (rank_one_type): ... this.
11409
11410 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11411
11412         * gdbtypes.c (rank_one_type_parm_int): New function extracted
11413         from...
11414         (rank_one_type): ... this.
11415
11416 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11417
11418         * gdbtypes.c (rank_one_type_parm_func): New function extracted
11419         from...
11420         (rank_one_type): ... this.
11421
11422 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11423
11424         * gdbtypes.c (rank_one_type_parm_array): New function extracted
11425         from...
11426         (rank_one_type): ... this.
11427
11428 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11429
11430         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
11431         from...
11432         (rank_one_type): ... this.
11433
11434 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11435
11436         * inferior.c (initialize_inferiors): Ensure 'help set/show print
11437         inferior-events' shows the example events.
11438
11439 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
11440
11441         Support styling on native MS-Windows console
11442
11443         PR/24315
11444         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
11445         on MS-Windows if $TERM is not defined.
11446
11447         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
11448
11449         * posix-hdep.c (gdb_console_fputs):
11450         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
11451         functions.
11452         * ui-file.h (gdb_console_fputs): Add prototype.
11453
11454         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
11455         back to fputs only if the former returns zero.
11456
11457 2019-03-07  Tom Tromey  <tom@tromey.com>
11458
11459         * symmisc.c (print_symbol_bcache_statistics): Update.
11460         (print_objfile_statistics): Update.
11461         * symfile.c (allocate_symtab): Update.
11462         * stabsread.c: Don't include bcache.h.
11463         * psymtab.h (struct psymbol_bcache): Don't declare.
11464         (class psymtab_storage) <psymbol_cache>: Now a bcache.
11465         (psymbol_bcache_init, psymbol_bcache_free)
11466         (psymbol_bcache_get_bcache): Don't declare.
11467         * psymtab.c (struct psymbol_bcache): Remove.
11468         (psymtab_storage::psymtab_storage): Update.
11469         (psymtab_storage::~psymtab_storage): Update.
11470         (psymbol_bcache_init, psymbol_bcache_free)
11471         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
11472         (add_psymbol_to_bcache): Update.
11473         (allocate_psymtab): Update.
11474         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
11475         macro_cache>: No longer pointers.
11476         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
11477         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
11478         * macrotab.c (macro_bcache): Update.
11479         * macroexp.c: Don't include bcache.h.
11480         * gdbtypes.c (check_types_worklist): Update.
11481         (types_deeply_equal): Remove TRY/CATCH.  Update.
11482         * elfread.c (elf_symtab_read): Update.
11483         * dwarf2read.c: Don't include bcache.h.
11484         * buildsym.c (buildsym_compunit::get_macro_table): Update.
11485         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
11486         (print_bcache_statistics, bcache_memory_used): Don't declare.
11487         (struct bcache): Move from bcache.c.  Add constructor, destructor,
11488         methods.  Rename all data members.
11489         * bcache.c (struct bcache): Move to bcache.h.
11490         (bcache::expand_hash_table): Rename from expand_hash_table.
11491         (bcache): Remove.
11492         (bcache::insert): Rename from bcache_full.
11493         (bcache::compare): Rename from bcache_compare.
11494         (bcache_xmalloc): Remove.
11495         (bcache::~bcache): Rename from bcache_xfree.
11496         (bcache::print_statistics): Rename from print_bcache_statistics.
11497         (bcache::memory_used): Rename from bcache_memory_used.
11498
11499 2019-03-07  Pedro Alves  <palves@redhat.com>
11500
11501         * infrun.c (normal_stop): Also check for
11502         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
11503
11504 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
11505
11506         * f-lang.c (value_from_host_double): Moved to...
11507         * value.c (value_from_host_double): ...here.
11508         * value.h (value_from_host_double): Declare.
11509         * guile/scm-math.c (vlscm_convert_typed_number): Use
11510         value_from_host_double.
11511         (vlscm_convert_number): Likewise.
11512         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
11513         * python/py-value.c (convert_value_from_python): Likewise.
11514
11515 2019-03-06  Tom Tromey  <tom@tromey.com>
11516
11517         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
11518
11519 2019-03-06  Tom Tromey  <tom@tromey.com>
11520
11521         * utils.h (free_current_contents): Don't declare.
11522         * utils.c (free_current_contents): Remove.
11523
11524 2019-03-06  Tom Tromey  <tom@tromey.com>
11525
11526         * top.c (quit_force): Update.
11527         * main.c (captured_command_loop): Update.
11528         * common/new-op.c (operator new): Update.
11529         * common/common-exceptions.c (struct catcher)
11530         <save_cleanup_chain>: Remove member.
11531         (exceptions_state_mc_init): Update.
11532         (exception_try_scope_entry): Return nullptr.
11533         (exception_try_scope_exit, exception_rethrow)
11534         (throw_exception_sjlj, throw_exception_cxx): Update.
11535         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
11536         (all_cleanups, do_cleanups, discard_cleanups)
11537         (discard_final_cleanups, save_cleanups, save_final_cleanups)
11538         (restore_cleanups, restore_final_cleanups): Don't declare.
11539         (do_final_cleanups): Remove parameter.
11540         * common/cleanups.c (cleanup_chain, make_cleanup)
11541         (make_cleanup_dtor, all_cleanups, do_cleanups)
11542         (discard_my_cleanups, discard_cleanups)
11543         (discard_final_cleanups, save_my_cleanups, save_cleanups)
11544         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
11545         (null_cleanup): Remove.
11546         (do_final_cleanups): Remove parameter.
11547
11548 2019-03-06  Tom Tromey  <tom@tromey.com>
11549
11550         * remote.c (remote_target::remote_parse_stop_reply): Use
11551         unique_xmalloc_ptr.
11552
11553 2019-03-06  Tom Tromey  <tom@tromey.com>
11554
11555         * stabsread.c (struct stabs_field_info): Rename from field_info.
11556         <list, fnlist>: Add initializers.
11557         <obstack>: New member.
11558         (read_member_functions, read_struct_fields, read_baseclasses):
11559         Allocate on obstack.  Don't use cleanups.
11560         (read_one_struct_field, read_member_functions, read_struct_fields)
11561         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
11562         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
11563         (read_struct_type): Update.
11564
11565 2019-03-06  Tom Tromey  <tom@tromey.com>
11566
11567         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
11568         * common/filestuff.h (make_cleanup_close): Don't declare.
11569         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
11570         Remove.
11571
11572 2019-03-06  Tom Tromey  <tom@tromey.com>
11573
11574         * solib-aix.c: Use make_scope_exit.
11575
11576 2019-03-06  Tom Tromey  <tom@tromey.com>
11577
11578         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
11579         Use make_scope_exit.
11580
11581 2019-03-06  Tom Tromey  <tom@tromey.com>
11582
11583         * solib-svr4.c (disable_probes_interface): Remove parameter.
11584         (svr4_handle_solib_event): Use make_scope_exit.
11585
11586 2019-03-06  Tom Tromey  <tom@tromey.com>
11587
11588         * remote.c (struct stop_reply_deleter): Remove.
11589         (stop_reply_up): Update.
11590         (struct stop_reply): Derive from notif_event.  Don't typedef.
11591         <regcache>: Now a std::vector.
11592         (stop_reply_xfree): Remove.
11593         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
11594         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
11595         (remote_target::discard_pending_stop_replies): Use delete.
11596         (remote_target::remote_parse_stop_reply): Update.
11597         (remote_target::process_stop_reply): Update.
11598         * remote-notif.h (struct notif_event): Add virtual destructor.
11599         Remove "dtr" member.
11600         (struct notif_client) <alloc_event>: Return a unique_ptr.
11601         (notif_event_xfree): Don't declare.
11602         (notif_event_up): New typedef.
11603         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
11604         (notif_event_xfree, do_notif_event_xfree): Remove.
11605         (remote_notif_state_xfree): Update.
11606
11607 2019-03-06  Tom Tromey  <tom@tromey.com>
11608
11609         * infrun.c (displaced_step_clear_cleanup): Now a
11610         forward_scope_exit type.
11611         (displaced_step_prepare_throw): Update.
11612         (displaced_step_fixup): Update.
11613
11614 2019-03-06  Tom Tromey  <tom@tromey.com>
11615
11616         * inferior.h (class inferior): Update comment.
11617         * gdbthread.h (class thread_info): Update comment.
11618
11619 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
11620             Tom Tromey  <tom@tromey.com>
11621
11622         * stabsread.h (struct stab_section_list): Remove.
11623         (coffstab_build_psymtabs): Update.
11624         * dbxread.c (symbuf_sections): Now a std::vector.
11625         (sect_idx): New global.
11626         (fill_symbuf): Update.
11627         (coffstab_build_psymtabs): Change type of stabsects parameter.
11628         Update.
11629         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
11630         std::vector.
11631         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
11632         (coff_locate_sections): Update.
11633         (coff_symfile_read): Remove cleanups.  Update.
11634         (init_stringtab): Add storage parameter.
11635         (free_stringtab, free_stringtab_cleanup): Remove.
11636         (init_lineno): Add storage parameter.
11637         (free_linetab, free_linetab_cleanup): Remove.
11638
11639 2019-03-06  Pedro Alves  <palves@redhat.com>
11640
11641         * linux-fork.c (fork_info::clobber_regs): Delete.
11642         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
11643         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
11644         comment.  Adjust.
11645         (scoped_switch_fork_info::scoped_switch_fork_info)
11646         (checkpoint_command, linux_fork_context): Adjust
11647         fork_save_infrun_state calls.
11648
11649 2019-03-06  Pedro Alves  <palves@redhat.com>
11650
11651         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
11652         (inf_has_multiple_threads): Return 'bool' and rewrite using
11653         inferior_info::threads().
11654
11655 2019-03-06  Pedro Alves  <palves@redhat.com>
11656
11657         * linux-fork.c: Include <list>.
11658         (fork_list): Now a std::list instance.
11659         (fork_info): Add ctor, dtor, and in-class initialize all fields.
11660         (forks_exist_p, find_last_fork): Adjust.
11661         (new_fork): Delete.
11662         (one_fork_p): New.
11663         (add_fork): Adjust.
11664         (free_fork): Delete, folded into fork_info::~fork_info().
11665         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
11666         Adjust.
11667         (init_fork_list): Delete.
11668         (linux_fork_killall, linux_fork_mourn_inferior)
11669         (linux_fork_detach, info_checkpoints_command): Adjust.
11670         (_initialize_linux_fork): No longer call init_fork_list.
11671
11672 2019-03-06  Pedro Alves  <palves@redhat.com>
11673
11674         * linux-fork.c (new_fork): New, split out of ...
11675         (add_fork): ... this.  Return void.  Move "first fork" special
11676         case from here, to ...
11677         (checkpoint_command): ... here.
11678         * linux-linux.h (add_fork): Return void.
11679
11680 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11681
11682         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
11683
11684 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11685             Chris January  <chris.january@arm.com>
11686             David Lecomber  <david.lecomber@arm.com>
11687
11688         * f-exp.y: New token, UNOP_INTRINSIC.
11689         (exp): New pattern using UNOP_INTRINSIC token.
11690         (f77_keywords): Add 'abs' keyword.
11691         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
11692         (value_from_host_double): New function.
11693         (evaluate_subexp_f): Support UNOP_ABS.
11694
11695 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11696
11697         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
11698         types.
11699
11700 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11701
11702         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
11703         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
11704         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
11705
11706 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11707
11708         * f-exp.y (convert_to_kind_type): Handle more type kinds.
11709
11710 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11711             Chris January  <chris.january@arm.com>
11712
11713         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
11714         * f-exp.y: Define 'KIND' token.
11715         (exp): New pattern for KIND expressions.
11716         (ptype): Handle types with a kind extension.
11717         (direct_abs_decl): Extend to spot kind extensions.
11718         (f77_keywords): Add 'kind' to the list.
11719         (push_kind_type): New function.
11720         (convert_to_kind_type): New function.
11721         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
11722         * parse.c (operator_length_standard): Likewise.
11723         * parser-defs.h (enum type_pieces): Add tp_kind.
11724         * std-operator.def: Add UNOP_KIND.
11725
11726 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11727
11728         * f-exp.y (f_parse): Set yydebug.
11729
11730 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11731
11732         * f-lang.c (evaluate_subexp_f): New function.
11733         (exp_descriptor_f): New global.
11734         (f_language_defn): Use exp_descriptor_f instead of
11735         exp_descriptor_standard.
11736
11737 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11738
11739         * f-exp.y (struct token): Add comments.
11740         (dot_ops): Remove uppercase versions and the end marker.
11741         (f77_keywords): Likewise.
11742         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
11743         entries in the dot_ops array are case insensitive, and use
11744         strncasecmp to compare strings.  Also some whitespace cleanup in
11745         this area.  Similar for the f77_keywords array, except entries in
11746         this list might be case sensitive.
11747
11748 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11749
11750         * f-exp.y (struct f77_boolean_val): Add comments.
11751         (boolean_values): Remove uppercase versions, and end marker.
11752         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
11753         and use strncasecmp to achieve case insensitivity.  Additionally,
11754         perform whitespace cleanup around this code.
11755
11756 2019-03-06  Tom Tromey  <tromey@adacore.com>
11757
11758         * remote-sim.c (gdbsim_target_open): Use result of
11759         gdb_argv::release.
11760
11761 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
11762         Dirk Schubert  <dirk.schubert@arm.com>
11763         Chris January  <chris.january@arm.com>
11764
11765         * eval.c (evaluate_subexp_standard): Call Fortran argument
11766         wrapping logic.
11767         * f-lang.c (struct value): A value which can be passed into a
11768         Fortran function call.
11769         (fortran_argument_convert): Wrap Fortran arguments in a pointer
11770         where appropriate.
11771         (struct type): Value ready for a Fortran function call.
11772         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
11773         is needed.
11774         * f-lang.h (fortran_argument_convert): Declaration.
11775         (fortran_preserve_arg_pointer): Declaration.
11776         * infcall.c (value_arg_coerce): Call Fortran argument logic.
11777
11778 2019-03-05  Tom Tromey  <tromey@adacore.com>
11779
11780         * python/py-prettyprint.c (print_string_repr): Remove #if.
11781         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
11782
11783 2019-03-05  Tom Tromey  <tromey@adacore.com>
11784
11785         * target.c (the_dummy_target): Move later.  Change type to
11786         "dummy_target".
11787         (initialize_targets): Don't initialize the_dummy_target.
11788
11789 2019-03-05  Tom Tromey  <tromey@adacore.com>
11790
11791         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
11792         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
11793
11794 2019-03-05  Tom Tromey  <tromey@adacore.com>
11795
11796         * windows-nat.c (windows_nat_target::attach)
11797         (windows_nat_target::detach): Don't call gdb_flush.
11798         * valprint.c (generic_val_print, val_print, val_print_string):
11799         Don't call gdb_flush.
11800         * utils.c (defaulted_query): Don't call gdb_flush.
11801         * typeprint.c (print_type_scalar): Don't call gdb_flush.
11802         * target.c (target_announce_detach): Don't call gdb_flush.
11803         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
11804         * remote.c (extended_remote_target::attach): Don't call
11805         gdb_flush.
11806         * procfs.c (procfs_target::detach): Don't call gdb_flush.
11807         * printcmd.c (do_examine): Don't call gdb_flush.
11808         (info_display_command): Don't call gdb_flush.
11809         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
11810         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
11811         * memattr.c (info_mem_command): Don't call gdb_flush.
11812         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
11813         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
11814         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
11815         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
11816         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
11817         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
11818         (gnu_nat_target::detach): Don't call gdb_flush.
11819         * f-valprint.c (f_val_print): Don't call gdb_flush.
11820         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
11821         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
11822         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
11823         gdb_flush.
11824         * c-valprint.c (c_val_print): Don't call gdb_flush.
11825         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
11826
11827 2019-03-05  Tom Tromey  <tromey@adacore.com>
11828
11829         * varobj.c (update_dynamic_varobj_children): Update.
11830         (install_default_visualizer): Use reset, not release.
11831         * value.c (set_internalvar): Update.
11832         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
11833         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
11834         ATTRIBUTE_UNUSED_RESULT.
11835
11836 2019-03-05  Tom Tromey  <tromey@adacore.com>
11837
11838         * remote.c (class scoped_remote_fd) <release>: Add
11839         ATTRIBUTE_UNUSED_RESULT.
11840
11841 2019-03-05  Tom Tromey  <tromey@adacore.com>
11842
11843         * macroexp.c (struct macro_buffer) <release>: Add
11844         ATTRIBUTE_UNUSED_RESULT.
11845
11846 2019-03-05  Tom Tromey  <tromey@adacore.com>
11847
11848         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
11849         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
11850         ATTRIBUTE_UNUSED_RESULT.
11851
11852 2019-03-05  Tom Tromey  <tromey@adacore.com>
11853
11854         * common/scoped_fd.h (class scoped_fd) <release>: Add
11855         ATTRIBUTE_UNUSED_RESULT.
11856
11857 2019-03-05  Tom Tromey  <tromey@adacore.com>
11858
11859         * parser-defs.h (struct parser_state) <release>: Add
11860         ATTRIBUTE_UNUSED_RESULT.
11861
11862 2019-03-05  Tom Tromey  <tromey@adacore.com>
11863
11864         * utils.h (class gdb_argv) <release>: Add
11865         ATTRIBUTE_UNUSED_RESULT.
11866         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
11867
11868 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
11869
11870         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
11871         for-loop range, to avoid compiler warnings.
11872
11873         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
11874         avoid compiler warnings about unused variables.
11875
11876         * NEWS: Mention end of support for native debugging on MS-Windows
11877         before XP.
11878
11879         PR gdb/24292
11880         * common/netstuff.c:
11881         * gdbserver/gdbreplay.c
11882         * gdbserver/remote-utils.c:
11883         * ser-tcp.c:
11884         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
11885         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
11886         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
11887         'getaddrinfo' and 'freeaddrinfo' were not available before
11888         Windows XP, and mingw.org's MinGW headers by default define
11889         _WIN32_WINNT to 0x500.
11890
11891 2019-03-01  Gary Benson <gbenson@redhat.com>
11892
11893         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
11894
11895 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
11896             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
11897
11898         PR gdb/8527
11899         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
11900         set_sigint_trap, clear_sigint_trap.
11901
11902 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11903
11904         * target.c (target_detach): Clear the regcache and the
11905         frame cache.
11906
11907 2019-02-27  Pedro Alves  <palves@redhat.com>
11908
11909         * utils.c (set_screen_size): When we cap the height/width sizes,
11910         tweak the corresponding command variable to show "unlimited":
11911
11912 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
11913             Pedro Alves  <palves@redhat.com>
11914
11915         * utils.c (set_screen_size): Reduce "infinite" rows and columns
11916         before calling rl_set_screen_size.
11917
11918 2019-02-27  Tom Tromey  <tromey@adacore.com>
11919
11920         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
11921         define.
11922         * python/py-value.c: Remove Python 2.4 workaround.
11923         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
11924         workaround.
11925         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
11926         Python 2.4 workaround.
11927         * python/python-internal.h: Remove Python 2.4 comment.
11928         (Py_ssize_t): Don't define.
11929         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
11930         (gdb_Py_DECREF): Remove Python 2.4 workaround.
11931         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
11932         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
11933         * python/python.c (do_start_initialization): Remove Python 2.4
11934         workaround.
11935         * python/py-prettyprint.c (class dummy_python_frame): Remove.
11936         (print_children): Remove Python 2.4 workaround.
11937         * python/py-inferior.c (buffer_procs): Remove Python 2.4
11938         workaround.
11939         (CHARBUFFERPROC_NAME): Remove.
11940         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
11941         Python 2.4 workaround.
11942
11943 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
11944
11945         * NEWS: Note minimum Python version.
11946
11947 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
11948
11949         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
11950         code from these functions.  Remove corresponding ifdefs.  Use
11951         Py_buffer_up instead of explicit calls to PyBuffer_Release.
11952         Remove gotos and target of gotos.
11953         (infpy_search_memory): Likewise.
11954
11955 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11956
11957         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
11958         (hppa_gdbarch_init): Don't register deleted functions with
11959         gdbarch.
11960
11961 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11962
11963         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
11964         (h8300_unwind_sp): Delete.
11965         (h8300_dummy_id): Delete.
11966         (h8300_gdbarch_init): Don't register deleted functions with
11967         gdbarch.
11968
11969 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11970
11971         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
11972         (ft32_unwind_pc): Delete.
11973         (ft32_unwind_sp): Delete.
11974         (ft32_gdbarch_init): Don't register deleted functions with
11975         gdbarch.
11976
11977 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11978
11979         * gdb/frv-tdep.c (frv_dummy_id): Delete.
11980         (frv_unwind_pc): Delete.
11981         (frv_unwind_sp): Delete.
11982         (frv_gdbarch_init): Don't register deleted functions with
11983         gdbarch.
11984
11985 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11986
11987         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
11988         (riscv_unwind_pc): Delete.
11989         (riscv_unwind_sp): Delete.
11990         (riscv_gdbarch_init): Don't register deleted functions with
11991         gdbarch.
11992
11993 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11994
11995         * gdb/csky-tdep.c (csky_dummy_id): Delete.
11996         (csky_unwind_pc): Delete.
11997         (csky_unwind_sp): Delete.
11998         (csky_gdbarch_init): Don't register deleted functions with
11999         gdbarch.
12000
12001 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12002
12003         * gdb/cris-tdep.c (cris_dummy_id): Delete.
12004         (cris_unwind_pc): Delete.
12005         (cris_unwind_sp): Delete.
12006         (cris_gdbarch_init): Don't register deleted functions with
12007         gdbarch.
12008
12009 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12010
12011         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
12012         (bfin_unwind_pc): Delete.
12013         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
12014
12015 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12016
12017         * gdb/arm-tdep.c (arm_dummy_id): Delete.
12018         (arm_unwind_pc): Delete.
12019         (arm_unwind_sp): Delete.
12020         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
12021
12022 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12023
12024         * gdb/arc-tdep.c (arc_dummy_id): Delete.
12025         (arc_unwind_pc): Delete.
12026         (arc_unwind_sp): Delete.
12027         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
12028
12029 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12030
12031         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
12032         (alpha_unwind_pc): Delete.
12033         (alpha_gdbarch_init): Don't register deleted functions with
12034         gdbarch.
12035
12036 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12037
12038         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
12039         (aarch64_unwind_pc): Delete.
12040         (aarch64_unwind_sp): Delete.
12041         (aarch64_gdbarch_init): Don't register deleted functions with
12042         gdbarch.
12043
12044 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12045
12046         * gdbtypes.c (type_align): Don't consider static members when
12047         computing structure alignment.
12048
12049 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12050
12051         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
12052         return 0 for other types.
12053         * arch-utils.c (default_type_align): Always return 0.
12054         * gdbarch.h: Regenerate.
12055         * gdbarch.sh (type_align): Extend comment.
12056         * gdbtypes.c (type_align): Add additional comments, always call
12057         gdbarch_type_align before applying the default rules.
12058         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
12059         generic code will then apply a suitable default.
12060         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
12061         types, return 0 for other types.
12062
12063 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
12064
12065         * NEWS: Create a new section for the next release branch.
12066         Rename the section of the current branch, now that it has
12067         been cut.
12068
12069 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
12070
12071         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
12072         * version.in: Bump version to 8.3.50.DATE-git.
12073
12074 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
12075
12076         * aix-thread.c (ptid_cmp): Remove unused variable.
12077         (get_signaled_thread): Likewise.
12078         (store_regs_user_thread): Likewise.
12079         (store_regs_kernel_thread): Likewise.
12080         (fetch_regs_kernel_thread): Remove shadowed variable.
12081
12082 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
12083
12084         * features/riscv/32bit-cpu.xml: Add register numbers.
12085         * features/riscv/32bit-fpu.c: Regenerate.
12086         * features/riscv/32bit-fpu.xml: Add register numbers.
12087         * features/riscv/64bit-cpu.xml: Add register numbers.
12088         * features/riscv/64bit-fpu.c: Regenerate.
12089         * features/riscv/64bit-fpu.xml: Add register numbers.
12090
12091 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
12092
12093         * NEWS: Mention two argument form of gdb.Value constructor.
12094         * python/py-value.c (convert_buffer_and_type_to_value): New
12095         function.
12096         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
12097         Add support for handling an optional second argument.  Call
12098         convert_buffer_and_type_to_value as appropriate.
12099         * python/python-internal.h (Py_buffer_deleter): New struct.
12100         (Py_buffer_up): New typedef.
12101
12102 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
12103
12104         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
12105         instead of releasing ownership.
12106
12107 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
12108
12109         * dwarf2read.c (open_and_init_dwp_file): Call
12110         elf_numsections instead of bfd_count_sections to initialize
12111         dwp_file->num_sections.
12112
12113 2019-02-25  Tom Tromey  <tromey@adacore.com>
12114
12115         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
12116
12117 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
12118
12119         * gcore.in: Add '--readnever' option when invoking GDB.
12120
12121 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
12122
12123         * MAINTAINERS: Update my email address.
12124
12125 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
12126
12127         * build-id.c (build_id_to_debug_bfd_1): New function.
12128         (build_id_to_debug_bfd): Look for separate debug file in
12129         sysroot.
12130
12131 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
12132
12133         * gdbarch.sh: Update the copyright year range that is placed into
12134         generated files.
12135
12136 2019-02-22  Keith Seitz  <keiths@redhat.com>
12137
12138         PR symtab/23853
12139         * linespec.c (create_sals_line_offset): Search for the default
12140         symtab's filename instead of its fullname.
12141
12142 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
12143
12144         * NEWS: Update style defaults.
12145
12146 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
12147
12148         * main.c (captured_main_1): Disable styling in batch mode.
12149
12150 2019-02-20  Tom Tromey  <tom@tromey.com>
12151
12152         * symtab.c (symtab_symbol_info): Fix typos.
12153
12154 2019-02-20  Tom Tromey  <tromey@adacore.com>
12155
12156         * findcmd.c (_initialize_mem_search): Use upper case for
12157         metasyntactic variables.
12158
12159 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
12160
12161         * aarch64-tdep.c (aarch64_add_reggroups): New function.
12162         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
12163
12164 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
12165
12166         * top.h (source_file_name): Change to std::string.
12167         * top.c (source_file_name): Likewise.
12168         (command_line_input): Adjust.
12169         * cli/cli-script.c (script_from_file): Adjust.
12170
12171 2019-02-19  Tom Tromey  <tromey@adacore.com>
12172
12173         * ravenscar-thread.c
12174         (ravenscar_thread_target::update_thread_list): Don't call
12175         ada_build_task_list.
12176         * ada-lang.h (ada_build_task_list): Don't declare.
12177         * ada-tasks.c (struct ada_tasks_inferior_data)
12178         <task_list_valid_p>: Now bool.
12179         (read_known_tasks, ada_task_list_changed)
12180         (ada_tasks_invalidate_inferior_data): Update.
12181         (read_known_tasks_array): Return bool.
12182         (read_known_tasks_list): Likewise.
12183         (read_known_tasks): Return void.
12184         (ada_build_task_list): Now static.
12185
12186 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
12187
12188         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
12189         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
12190
12191 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12192
12193         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
12194         variant for ada_tasks_pspace_data_handle and
12195         ada_tasks_inferior_data_handle.
12196         (ada_tasks_pspace_data_cleanup): New function.
12197         (ada_tasks_inferior_data_cleanup): New function.
12198
12199 2019-02-17  Tom Tromey  <tom@tromey.com>
12200
12201         * macrotab.h (macro_source_fullname): Return a std::string.
12202         * macrotab.c (macro_include, check_for_redefinition)
12203         (macro_undef, macro_lookup_definition, foreach_macro)
12204         (foreach_macro_in_scope): Update.
12205         (macro_source_fullname): Return a std::string.
12206         * macrocmd.c (show_pp_source_pos): Update.
12207
12208 2019-02-17  Tom Tromey  <tom@tromey.com>
12209
12210         * macrocmd.c (show_pp_source_pos): Style the file names.
12211
12212 2019-02-17  Tom Tromey  <tom@tromey.com>
12213
12214         PR tui/24197:
12215         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
12216
12217 2019-02-17  Tom Tromey  <tom@tromey.com>
12218
12219         * ada-lang.c (user_select_syms): Use filtered printing.
12220         * utils.c (wrap_style): New global.
12221         (desired_style): Remove.
12222         (emit_style_escape): Add stream parameter.
12223         (set_output_style, reset_terminal_style, prompt_for_continue):
12224         Update.
12225         (flush_wrap_buffer): Only flush gdb_stdout.
12226         (wrap_here): Set wrap_style.
12227         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
12228         treat escape sequences as a character.  Change when wrap buffer is
12229         flushed.
12230         (fputs_styled): Do not set the output style when the default is
12231         requested.
12232         * ui-style.h (struct ui_file_style) <is_default>: New method.
12233         * source.c (print_source_lines_base): Emit escape sequences in one
12234         piece.
12235
12236 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
12237
12238         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
12239         integers and enumeration types.
12240
12241 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
12242
12243         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
12244         instead of lookup_symbol_in_language
12245         (do_exact_match): New function.
12246         (ada_get_symbol_name_matcher): Return do_exact_match when
12247         doing a verbatim match.
12248
12249 2019-02-15  Tom Tromey  <tromey@adacore.com>
12250
12251         * ravenscar-thread.c (ravenscar_thread_target::resume)
12252         (ravenscar_thread_target::wait): Special case wildcard requests.
12253
12254 2019-02-15  Tom Tromey  <tromey@adacore.com>
12255
12256         * ravenscar-thread.c (base_ptid): Remove.
12257         (struct ravenscar_thread_target) <close>: New method.
12258         <m_base_ptid>: New member.
12259         <update_inferior_ptid, active_task, task_is_currently_active,
12260         runtime_initialized>: Declare methods.
12261         <ravenscar_thread_target>: Add constructor.
12262         (ravenscar_thread_target::task_is_currently_active)
12263         (ravenscar_thread_target::update_inferior_ptid)
12264         (ravenscar_runtime_initialized): Rename.  Now methods.
12265         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
12266         (ravenscar_thread_target::update_thread_list): Update.
12267         (ravenscar_thread_target::active_task): Now method.
12268         (ravenscar_thread_target::store_registers)
12269         (ravenscar_thread_target::prepare_to_store)
12270         (ravenscar_thread_target::prepare_to_store)
12271         (ravenscar_thread_target::mourn_inferior): Update.
12272         (ravenscar_inferior_created): Use "new" to create target.
12273         (ravenscar_thread_target::get_ada_task_ptid): Update.
12274         (_initialize_ravenscar): Don't initialize base_ptid.
12275         (ravenscar_ops): Remove global.
12276
12277 2019-02-15  Tom Tromey  <tromey@adacore.com>
12278
12279         * target.h (push_target): Declare new overload.
12280         * target.c (push_target): New overload, taking an rvalue reference.
12281         * remote.c (remote_target::open_1): Use push_target overload.
12282         * corelow.c (core_target_open): Use push_target overload.
12283
12284 2019-02-15  Tom Tromey  <tromey@adacore.com>
12285
12286         * ravenscar-thread.c (is_ravenscar_task)
12287         (ravenscar_task_is_currently_active): Return bool.
12288         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
12289         (_initialize_ravenscar): Remove "(void)".
12290         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
12291         Return bool.
12292
12293 2019-02-15  Tom Tromey  <tromey@adacore.com>
12294
12295         * ravenscar-thread.c (ravenscar_runtime_initializer)
12296         (has_ravenscar_runtime, get_running_thread_id)
12297         (ravenscar_thread_target::resume): Fix indentation.
12298
12299 2019-02-15  Tom Tromey  <tromey@adacore.com>
12300
12301         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
12302         from ravenscar_arch_ops.
12303         (sparc_ravenscar_ops::fetch_registers)
12304         (sparc_ravenscar_ops::store_registers): Now methods.
12305         (sparc_ravenscar_prepare_to_store): Remove.
12306         (sparc_ravenscar_ops): Redefine.
12307         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
12308         methods and destructor.  Remove members.
12309         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
12310         (ravenscar_thread_target::store_registers)
12311         (ravenscar_thread_target::prepare_to_store): Update.
12312         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
12313         Remove.
12314         (struct ppc_ravenscar_powerpc_ops): Derive from
12315         ravenscar_arch_ops.
12316         (ppc_ravenscar_powerpc_ops::fetch_registers)
12317         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
12318         (ppc_ravenscar_powerpc_ops): Redefine.
12319         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
12320         (ppc_ravenscar_e500_ops::fetch_registers)
12321         (ppc_ravenscar_e500_ops::store_registers): Now methods.
12322         (ppc_ravenscar_e500_ops): Redefine.
12323         * aarch64-ravenscar-thread.c
12324         (aarch64_ravenscar_generic_prepare_to_store): Remove.
12325         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
12326         (aarch64_ravenscar_fetch_registers)
12327         (aarch64_ravenscar_store_registers): Now methods.
12328         (aarch64_ravenscar_ops): Redefine.
12329
12330 2019-02-15  Tom Tromey  <tromey@adacore.com>
12331
12332         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
12333         (ravenscar_thread_target::stopped_by_hw_breakpoint)
12334         (ravenscar_thread_target::stopped_by_watchpoint)
12335         (ravenscar_thread_target::stopped_data_address)
12336         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
12337
12338 2019-02-15  Tom Tromey  <tromey@adacore.com>
12339
12340         * ravenscar-thread.c: Fix some typos.
12341
12342 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12343             Tom Tromey  <tromey@adacore.com>
12344
12345         * ada-lang.c (ada_exception_sal): Change addr_string to a
12346         std::string.
12347         (create_ada_exception_catchpoint): Update.
12348
12349 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12350             Tom Tromey  <tromey@adacore.com>
12351
12352         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
12353         (bp_location_ops): Remove.
12354         (base_breakpoint_allocate_location): Update.
12355         (free_bp_location): Update.
12356         * ada-lang.c (class ada_catchpoint_location)
12357         <ada_catchpoint_location>: Remove ops parameter.
12358         (ada_catchpoint_location_dtor): Remove.
12359         (ada_catchpoint_location_ops): Remove.
12360         (allocate_location_exception): Update.
12361         * breakpoint.h (struct bp_location_ops): Remove.
12362         (class bp_location) <bp_location>: Remove bp_location_ops
12363         parameter.
12364         <~bp_location>: Add destructor.
12365         <ops>: Remove.
12366
12367 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
12368             Pedro Alves  <palves@redhat.com>
12369
12370         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
12371         'PATH_MAX'.
12372
12373 2019-02-14  David Michael  <fedora.dm0@gmail.com>
12374             Samuel Thibault  <samuel.thibault@gnu.org>
12375             Thomas Schwinge  <thomas@codesourcery.com>
12376
12377         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
12378         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
12379
12380 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
12381
12382         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
12383         (check_empty): Use "const char *".
12384
12385         * gnu-nat.c (gnu_nat_target::detach): Instead of
12386         'detach_inferior (pid)' call
12387         'detach_inferior (find_inferior_pid (pid))'.
12388
12389         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
12390         'nat/fork-inferior.o'.
12391         * gnu-nat.c: #include "nat/fork-inferior.h".
12392
12393         * gnu-nat.c (gnu_nat_target::detach): Instead of
12394         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
12395         * gnu-nat.h: #include "inf-child.h".
12396         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
12397         'i386_gnu_nat_target::fetch_registers'.
12398         (gnu_store_registers): Rename/move to
12399         'i386_gnu_nat_target::store_registers'.
12400
12401         * config/i386/nm-i386gnu.h: Don't "#include" any files.
12402         * gnu-nat.h (mach_thread_info): New function.
12403         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
12404
12405         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
12406
12407 2019-02-14  Frederic Konrad  <konrad@adacore.com>
12408
12409         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
12410
12411 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
12412
12413         * windows-nat.c (windows_add_thread): Add new parameter
12414         "main_thread_p" with default value set to false.  Update
12415         function documentation as well as all callers.
12416         (windows_delete_thread): Likewise.
12417         (fake_create_process): Update call to windows_add_thread.
12418         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
12419         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
12420         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
12421         call to windows_delete_thread.
12422
12423 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
12424
12425         * MAINTAINERS: Add Andrew Burgess as global maintainer.
12426
12427 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
12428
12429         * symfile.c (find_separate_debug_file): Use canonical path of
12430         sysroot with child_path instead of gdb_sysroot if it is valid.
12431
12432 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
12433
12434         * symfile.c (find_separate_debug_file): Use child_path to
12435         determine if an object file is under a sysroot.
12436
12437 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
12438
12439         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
12440         unittests/child-path-selftests.c.
12441         * common/pathstuff.c (child_path): New function.
12442         * common/pathstuff.h (child_path): New prototype.
12443         * unittests/child-path-selftests.c: New file.
12444
12445 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
12446
12447         * symfile.c (find_separate_debug_file): Look for separate debug
12448         files in debug directories under the sysroot.
12449
12450 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12451
12452         * symtab.h (struct minimal_symbol data_p): New const method.
12453         (struct minimal_symbol text_p): Likewise.
12454         * symtab.c (output_source_filename): Use file name style
12455         to print file name.
12456         (print_symbol_info): Likewise.
12457         (print_msymbol_info): Use address style to print addresses.
12458         Use function name style to print executable text symbols.
12459         (expand_symtab_containing_pc): Use data_p.
12460         (find_pc_sect_compunit_symtab): Likewise.
12461
12462 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12463
12464         * breakpoint.c (describe_other_breakpoints): Use address style
12465         to print addresses.
12466         (say_where): Likewise.
12467
12468 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12469
12470         * ada-typeprint.c (print_func_type): Print function name
12471         style to print function name.
12472         * c-typeprint.c (c_print_type_1): Likewise.
12473
12474 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
12475
12476         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
12477         for execve.
12478
12479 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12480
12481         * c-exp.y (direct_abs_decl): Use emplace_back to record the
12482         type_stack.
12483
12484 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
12485
12486         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
12487         TYPE_CODE_REF types.
12488
12489 2019-02-08  Jim Wilson  <jimw@sifive.com>
12490
12491         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
12492         (riscv_linux_fregset): New.
12493         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
12494
12495 2019-02-07  Tom Tromey  <tom@tromey.com>
12496
12497         * thread.c (thread_cancel_execution_command): Update.
12498         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
12499         methods.
12500         (struct thread_fsm_ops): Remove.
12501         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
12502         (thread_fsm_should_stop, thread_fsm_return_value)
12503         (thread_fsm_set_finished, thread_fsm_finished_p)
12504         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
12505         Don't declare.
12506         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
12507         * infrun.c (clear_proceed_status_thread)
12508         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
12509         (print_stop_event): Update.
12510         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
12511         Add constructor.
12512         (step_command_fsm_ops): Remove.
12513         (new_step_command_fsm): Remove.
12514         (step_1): Update.
12515         (step_command_fsm::should_stop): Rename from
12516         step_command_fsm_should_stop.
12517         (step_command_fsm::clean_up): Rename from
12518         step_command_fsm_clean_up.
12519         (step_command_fsm::do_async_reply_reason): Rename from
12520         step_command_fsm_async_reply_reason.
12521         (struct until_next_fsm): Inherit from thread_fsm.  Add
12522         constructor.
12523         (until_next_fsm_ops): Remove.
12524         (new_until_next_fsm): Remove.
12525         (until_next_fsm::should_stop): Rename from
12526         until_next_fsm_should_stop.
12527         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
12528         (until_next_fsm::do_async_reply_reason): Rename from
12529         until_next_fsm_async_reply_reason.
12530         (struct finish_command_fsm): Inherit from thread_fsm.  Add
12531         constructor.  Change type of breakpoint.
12532         (finish_command_fsm_ops): Remove.
12533         (new_finish_command_fsm): Remove.
12534         (finish_command_fsm::should_stop): Rename from
12535         finish_command_fsm_should_stop.
12536         (finish_command_fsm::clean_up): Rename from
12537         finish_command_fsm_clean_up.
12538         (finish_command_fsm::return_value): Rename from
12539         finish_command_fsm_return_value.
12540         (finish_command_fsm::do_async_reply_reason): Rename from
12541         finish_command_fsm_async_reply_reason.
12542         (finish_command): Update.
12543         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
12544         Add constructor.
12545         (call_thread_fsm_ops): Remove.
12546         (call_thread_fsm::call_thread_fsm): Rename from
12547         new_call_thread_fsm.
12548         (call_thread_fsm::should_stop): Rename from
12549         call_thread_fsm_should_stop.
12550         (call_thread_fsm::should_notify_stop): Rename from
12551         call_thread_fsm_should_notify_stop.
12552         (run_inferior_call, call_function_by_hand_dummy): Update.
12553         * cli/cli-interp.c (should_print_stop_to_console): Update.
12554         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
12555         Add constructor.  Change type of location_breakpoint,
12556         caller_breakpoint.
12557         (until_break_fsm_ops): Remove.
12558         (new_until_break_fsm): Remove.
12559         (until_break_fsm::should_stop): Rename from
12560         until_break_fsm_should_stop.
12561         (until_break_fsm::clean_up): Rename from
12562         until_break_fsm_clean_up.
12563         (until_break_fsm::do_async_reply_reason): Rename from
12564         until_break_fsm_async_reply_reason.
12565         (until_break_command): Update.
12566         * thread-fsm.c: Remove.
12567         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
12568
12569 2019-02-07  Tom Tromey  <tom@tromey.com>
12570
12571         * yy-remap.h: Add include guard.
12572         * xtensa-tdep.h: Add include guard.
12573         * xcoffread.h: Rename include guard.
12574         * varobj-iter.h: Add include guard.
12575         * tui/tui.h: Rename include guard.
12576         * tui/tui-winsource.h: Rename include guard.
12577         * tui/tui-wingeneral.h: Rename include guard.
12578         * tui/tui-windata.h: Rename include guard.
12579         * tui/tui-win.h: Rename include guard.
12580         * tui/tui-stack.h: Rename include guard.
12581         * tui/tui-source.h: Rename include guard.
12582         * tui/tui-regs.h: Rename include guard.
12583         * tui/tui-out.h: Rename include guard.
12584         * tui/tui-layout.h: Rename include guard.
12585         * tui/tui-io.h: Rename include guard.
12586         * tui/tui-hooks.h: Rename include guard.
12587         * tui/tui-file.h: Rename include guard.
12588         * tui/tui-disasm.h: Rename include guard.
12589         * tui/tui-data.h: Rename include guard.
12590         * tui/tui-command.h: Rename include guard.
12591         * tic6x-tdep.h: Add include guard.
12592         * target/waitstatus.h: Rename include guard.
12593         * target/wait.h: Rename include guard.
12594         * target/target.h: Rename include guard.
12595         * target/resume.h: Rename include guard.
12596         * target-float.h: Rename include guard.
12597         * stabsread.h: Add include guard.
12598         * rs6000-tdep.h: Add include guard.
12599         * riscv-fbsd-tdep.h: Add include guard.
12600         * regformats/regdef.h: Rename include guard.
12601         * record.h: Rename include guard.
12602         * python/python.h: Rename include guard.
12603         * python/python-internal.h: Rename include guard.
12604         * python/py-stopevent.h: Rename include guard.
12605         * python/py-ref.h: Rename include guard.
12606         * python/py-record.h: Rename include guard.
12607         * python/py-record-full.h: Rename include guard.
12608         * python/py-record-btrace.h: Rename include guard.
12609         * python/py-instruction.h: Rename include guard.
12610         * python/py-events.h: Rename include guard.
12611         * python/py-event.h: Rename include guard.
12612         * procfs.h: Add include guard.
12613         * proc-utils.h: Add include guard.
12614         * p-lang.h: Add include guard.
12615         * or1k-tdep.h: Rename include guard.
12616         * observable.h: Rename include guard.
12617         * nto-tdep.h: Rename include guard.
12618         * nat/x86-linux.h: Rename include guard.
12619         * nat/x86-linux-dregs.h: Rename include guard.
12620         * nat/x86-gcc-cpuid.h: Add include guard.
12621         * nat/x86-dregs.h: Rename include guard.
12622         * nat/x86-cpuid.h: Rename include guard.
12623         * nat/ppc-linux.h: Rename include guard.
12624         * nat/mips-linux-watch.h: Rename include guard.
12625         * nat/linux-waitpid.h: Rename include guard.
12626         * nat/linux-ptrace.h: Rename include guard.
12627         * nat/linux-procfs.h: Rename include guard.
12628         * nat/linux-osdata.h: Rename include guard.
12629         * nat/linux-nat.h: Rename include guard.
12630         * nat/linux-namespaces.h: Rename include guard.
12631         * nat/linux-btrace.h: Rename include guard.
12632         * nat/glibc_thread_db.h: Rename include guard.
12633         * nat/gdb_thread_db.h: Rename include guard.
12634         * nat/gdb_ptrace.h: Rename include guard.
12635         * nat/fork-inferior.h: Rename include guard.
12636         * nat/amd64-linux-siginfo.h: Rename include guard.
12637         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
12638         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
12639         * nat/aarch64-linux.h: Rename include guard.
12640         * nat/aarch64-linux-hw-point.h: Rename include guard.
12641         * mn10300-tdep.h: Add include guard.
12642         * mips-linux-tdep.h: Add include guard.
12643         * mi/mi-parse.h: Rename include guard.
12644         * mi/mi-out.h: Rename include guard.
12645         * mi/mi-main.h: Rename include guard.
12646         * mi/mi-interp.h: Rename include guard.
12647         * mi/mi-getopt.h: Rename include guard.
12648         * mi/mi-console.h: Rename include guard.
12649         * mi/mi-common.h: Rename include guard.
12650         * mi/mi-cmds.h: Rename include guard.
12651         * mi/mi-cmd-break.h: Rename include guard.
12652         * m2-lang.h: Add include guard.
12653         * location.h: Rename include guard.
12654         * linux-record.h: Rename include guard.
12655         * linux-nat.h: Add include guard.
12656         * linux-fork.h: Add include guard.
12657         * i386-darwin-tdep.h: Rename include guard.
12658         * hppa-linux-offsets.h: Add include guard.
12659         * guile/guile.h: Rename include guard.
12660         * guile/guile-internal.h: Rename include guard.
12661         * gnu-nat.h: Rename include guard.
12662         * gdb-stabs.h: Rename include guard.
12663         * frv-tdep.h: Add include guard.
12664         * f-lang.h: Add include guard.
12665         * event-loop.h: Add include guard.
12666         * darwin-nat.h: Rename include guard.
12667         * cp-abi.h: Rename include guard.
12668         * config/sparc/nm-sol2.h: Rename include guard.
12669         * config/nm-nto.h: Rename include guard.
12670         * config/nm-linux.h: Add include guard.
12671         * config/i386/nm-i386gnu.h: Rename include guard.
12672         * config/djgpp/nl_types.h: Rename include guard.
12673         * config/djgpp/langinfo.h: Rename include guard.
12674         * compile/gcc-cp-plugin.h: Add include guard.
12675         * compile/gcc-c-plugin.h: Add include guard.
12676         * compile/compile.h: Rename include guard.
12677         * compile/compile-object-run.h: Rename include guard.
12678         * compile/compile-object-load.h: Rename include guard.
12679         * compile/compile-internal.h: Rename include guard.
12680         * compile/compile-cplus.h: Rename include guard.
12681         * compile/compile-c.h: Rename include guard.
12682         * common/xml-utils.h: Rename include guard.
12683         * common/x86-xstate.h: Rename include guard.
12684         * common/version.h: Rename include guard.
12685         * common/vec.h: Rename include guard.
12686         * common/tdesc.h: Rename include guard.
12687         * common/selftest.h: Rename include guard.
12688         * common/scoped_restore.h: Rename include guard.
12689         * common/scoped_mmap.h: Rename include guard.
12690         * common/scoped_fd.h: Rename include guard.
12691         * common/safe-iterator.h: Rename include guard.
12692         * common/run-time-clock.h: Rename include guard.
12693         * common/refcounted-object.h: Rename include guard.
12694         * common/queue.h: Rename include guard.
12695         * common/ptid.h: Rename include guard.
12696         * common/print-utils.h: Rename include guard.
12697         * common/preprocessor.h: Rename include guard.
12698         * common/pathstuff.h: Rename include guard.
12699         * common/observable.h: Rename include guard.
12700         * common/netstuff.h: Rename include guard.
12701         * common/job-control.h: Rename include guard.
12702         * common/host-defs.h: Rename include guard.
12703         * common/gdb_wait.h: Rename include guard.
12704         * common/gdb_vecs.h: Rename include guard.
12705         * common/gdb_unlinker.h: Rename include guard.
12706         * common/gdb_unique_ptr.h: Rename include guard.
12707         * common/gdb_tilde_expand.h: Rename include guard.
12708         * common/gdb_sys_time.h: Rename include guard.
12709         * common/gdb_string_view.h: Rename include guard.
12710         * common/gdb_splay_tree.h: Rename include guard.
12711         * common/gdb_setjmp.h: Rename include guard.
12712         * common/gdb_ref_ptr.h: Rename include guard.
12713         * common/gdb_optional.h: Rename include guard.
12714         * common/gdb_locale.h: Rename include guard.
12715         * common/gdb_assert.h: Rename include guard.
12716         * common/filtered-iterator.h: Rename include guard.
12717         * common/filestuff.h: Rename include guard.
12718         * common/fileio.h: Rename include guard.
12719         * common/environ.h: Rename include guard.
12720         * common/common-utils.h: Rename include guard.
12721         * common/common-types.h: Rename include guard.
12722         * common/common-regcache.h: Rename include guard.
12723         * common/common-inferior.h: Rename include guard.
12724         * common/common-gdbthread.h: Rename include guard.
12725         * common/common-exceptions.h: Rename include guard.
12726         * common/common-defs.h: Rename include guard.
12727         * common/common-debug.h: Rename include guard.
12728         * common/cleanups.h: Rename include guard.
12729         * common/buffer.h: Rename include guard.
12730         * common/btrace-common.h: Rename include guard.
12731         * common/break-common.h: Rename include guard.
12732         * cli/cli-utils.h: Rename include guard.
12733         * cli/cli-style.h: Rename include guard.
12734         * cli/cli-setshow.h: Rename include guard.
12735         * cli/cli-script.h: Rename include guard.
12736         * cli/cli-interp.h: Rename include guard.
12737         * cli/cli-decode.h: Rename include guard.
12738         * cli/cli-cmds.h: Rename include guard.
12739         * charset-list.h: Add include guard.
12740         * buildsym-legacy.h: Rename include guard.
12741         * bfin-tdep.h: Add include guard.
12742         * ax.h: Rename include guard.
12743         * arm-linux-tdep.h: Add include guard.
12744         * arm-fbsd-tdep.h: Add include guard.
12745         * arch/xtensa.h: Rename include guard.
12746         * arch/tic6x.h: Add include guard.
12747         * arch/i386.h: Add include guard.
12748         * arch/arm.h: Rename include guard.
12749         * arch/arm-linux.h: Rename include guard.
12750         * arch/arm-get-next-pcs.h: Rename include guard.
12751         * arch/amd64.h: Add include guard.
12752         * arch/aarch64-insn.h: Rename include guard.
12753         * arch-utils.h: Rename include guard.
12754         * annotate.h: Add include guard.
12755         * amd64-darwin-tdep.h: Rename include guard.
12756         * aarch64-linux-tdep.h: Add include guard.
12757         * aarch64-fbsd-tdep.h: Add include guard.
12758         * aarch32-linux-nat.h: Add include guard.
12759
12760 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12761
12762         * macrotab.c (macro_define_internal): New function that
12763         factorizes macro_define_object_internal and macro_define_function
12764         code.
12765         (macro_define_object_internal): Use macro_define_internal.
12766         (macro_define_function): Likewise.
12767
12768 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12769
12770         * macrocmd.c (extract_identifier): Return
12771         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
12772         callers.
12773
12774 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
12775
12776         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
12777
12778 2019-02-05  Tom Tromey  <tom@tromey.com>
12779
12780         * target.c (target_stack::unpush): Move assertion earlier.
12781
12782 2019-01-30  Tom Tromey  <tom@tromey.com>
12783
12784         PR python/23615:
12785         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
12786         (gdbpy_parse_and_eval): Likewise.
12787         * python/python-internal.h (gdbpy_allow_threads): New class.
12788
12789 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
12790
12791         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
12792         (aarch64_fbsd_fpregmap): Move earlier.
12793         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
12794         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
12795         instead of individual calls to trad_frame_set_reg_addr.
12796         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
12797         earlier.
12798         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
12799         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
12800         instead of individual calls to trad_frame_set_reg_addr.
12801
12802 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
12803
12804         * CONTRIBUTE: Replace contribution list with wiki link.
12805
12806 2019-01-25  Tom Tromey  <tom@tromey.com>
12807
12808         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
12809
12810 2019-01-25  Tom Tromey  <tom@tromey.com>
12811
12812         * xtensa-linux-nat.c: Fix common/ includes.
12813         * xml-support.h: Fix common/ includes.
12814         * xml-support.c: Fix common/ includes.
12815         * x86-linux-nat.c: Fix common/ includes.
12816         * windows-nat.c: Fix common/ includes.
12817         * varobj.h: Fix common/ includes.
12818         * varobj.c: Fix common/ includes.
12819         * value.c: Fix common/ includes.
12820         * valops.c: Fix common/ includes.
12821         * utils.c: Fix common/ includes.
12822         * unittests/xml-utils-selftests.c: Fix common/ includes.
12823         * unittests/utils-selftests.c: Fix common/ includes.
12824         * unittests/unpack-selftests.c: Fix common/ includes.
12825         * unittests/tracepoint-selftests.c: Fix common/ includes.
12826         * unittests/style-selftests.c: Fix common/ includes.
12827         * unittests/string_view-selftests.c: Fix common/ includes.
12828         * unittests/scoped_restore-selftests.c: Fix common/ includes.
12829         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
12830         * unittests/scoped_fd-selftests.c: Fix common/ includes.
12831         * unittests/rsp-low-selftests.c: Fix common/ includes.
12832         * unittests/parse-connection-spec-selftests.c: Fix common/
12833         includes.
12834         * unittests/optional-selftests.c: Fix common/ includes.
12835         * unittests/offset-type-selftests.c: Fix common/ includes.
12836         * unittests/observable-selftests.c: Fix common/ includes.
12837         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
12838         * unittests/memrange-selftests.c: Fix common/ includes.
12839         * unittests/memory-map-selftests.c: Fix common/ includes.
12840         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
12841         * unittests/function-view-selftests.c: Fix common/ includes.
12842         * unittests/environ-selftests.c: Fix common/ includes.
12843         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
12844         * unittests/common-utils-selftests.c: Fix common/ includes.
12845         * unittests/cli-utils-selftests.c: Fix common/ includes.
12846         * unittests/array-view-selftests.c: Fix common/ includes.
12847         * ui-file.c: Fix common/ includes.
12848         * tui/tui-io.c: Fix common/ includes.
12849         * tracepoint.h: Fix common/ includes.
12850         * tracepoint.c: Fix common/ includes.
12851         * tracefile-tfile.c: Fix common/ includes.
12852         * top.h: Fix common/ includes.
12853         * top.c: Fix common/ includes.
12854         * thread.c: Fix common/ includes.
12855         * target/waitstatus.h: Fix common/ includes.
12856         * target/waitstatus.c: Fix common/ includes.
12857         * target.h: Fix common/ includes.
12858         * target.c: Fix common/ includes.
12859         * target-memory.c: Fix common/ includes.
12860         * target-descriptions.c: Fix common/ includes.
12861         * symtab.h: Fix common/ includes.
12862         * symfile.c: Fix common/ includes.
12863         * stap-probe.c: Fix common/ includes.
12864         * spu-linux-nat.c: Fix common/ includes.
12865         * sparc-nat.c: Fix common/ includes.
12866         * source.c: Fix common/ includes.
12867         * solib.c: Fix common/ includes.
12868         * solib-target.c: Fix common/ includes.
12869         * ser-unix.c: Fix common/ includes.
12870         * ser-tcp.c: Fix common/ includes.
12871         * ser-pipe.c: Fix common/ includes.
12872         * ser-base.c: Fix common/ includes.
12873         * selftest-arch.c: Fix common/ includes.
12874         * s12z-tdep.c: Fix common/ includes.
12875         * rust-exp.y: Fix common/ includes.
12876         * rs6000-aix-tdep.c: Fix common/ includes.
12877         * riscv-tdep.c: Fix common/ includes.
12878         * remote.c: Fix common/ includes.
12879         * remote-notif.h: Fix common/ includes.
12880         * remote-fileio.h: Fix common/ includes.
12881         * remote-fileio.c: Fix common/ includes.
12882         * regcache.h: Fix common/ includes.
12883         * regcache.c: Fix common/ includes.
12884         * record-btrace.c: Fix common/ includes.
12885         * python/python.c: Fix common/ includes.
12886         * python/py-type.c: Fix common/ includes.
12887         * python/py-inferior.c: Fix common/ includes.
12888         * progspace.h: Fix common/ includes.
12889         * producer.c: Fix common/ includes.
12890         * procfs.c: Fix common/ includes.
12891         * proc-api.c: Fix common/ includes.
12892         * printcmd.c: Fix common/ includes.
12893         * ppc-linux-nat.c: Fix common/ includes.
12894         * parser-defs.h: Fix common/ includes.
12895         * osdata.c: Fix common/ includes.
12896         * obsd-nat.c: Fix common/ includes.
12897         * nat/x86-linux.c: Fix common/ includes.
12898         * nat/x86-linux-dregs.c: Fix common/ includes.
12899         * nat/x86-dregs.h: Fix common/ includes.
12900         * nat/x86-dregs.c: Fix common/ includes.
12901         * nat/ppc-linux.c: Fix common/ includes.
12902         * nat/mips-linux-watch.h: Fix common/ includes.
12903         * nat/mips-linux-watch.c: Fix common/ includes.
12904         * nat/linux-waitpid.c: Fix common/ includes.
12905         * nat/linux-ptrace.h: Fix common/ includes.
12906         * nat/linux-ptrace.c: Fix common/ includes.
12907         * nat/linux-procfs.c: Fix common/ includes.
12908         * nat/linux-personality.c: Fix common/ includes.
12909         * nat/linux-osdata.c: Fix common/ includes.
12910         * nat/linux-namespaces.c: Fix common/ includes.
12911         * nat/linux-btrace.h: Fix common/ includes.
12912         * nat/linux-btrace.c: Fix common/ includes.
12913         * nat/fork-inferior.c: Fix common/ includes.
12914         * nat/amd64-linux-siginfo.c: Fix common/ includes.
12915         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
12916         * nat/aarch64-linux.c: Fix common/ includes.
12917         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
12918         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
12919         * namespace.h: Fix common/ includes.
12920         * mips-linux-tdep.c: Fix common/ includes.
12921         * minsyms.c: Fix common/ includes.
12922         * mi/mi-parse.h: Fix common/ includes.
12923         * mi/mi-main.c: Fix common/ includes.
12924         * mi/mi-cmd-env.c: Fix common/ includes.
12925         * memrange.h: Fix common/ includes.
12926         * memattr.c: Fix common/ includes.
12927         * maint.h: Fix common/ includes.
12928         * maint.c: Fix common/ includes.
12929         * main.c: Fix common/ includes.
12930         * machoread.c: Fix common/ includes.
12931         * location.c: Fix common/ includes.
12932         * linux-thread-db.c: Fix common/ includes.
12933         * linux-nat.c: Fix common/ includes.
12934         * linux-fork.c: Fix common/ includes.
12935         * inline-frame.c: Fix common/ includes.
12936         * infrun.c: Fix common/ includes.
12937         * inflow.c: Fix common/ includes.
12938         * inferior.h: Fix common/ includes.
12939         * inferior.c: Fix common/ includes.
12940         * infcmd.c: Fix common/ includes.
12941         * inf-ptrace.c: Fix common/ includes.
12942         * inf-child.c: Fix common/ includes.
12943         * ia64-linux-nat.c: Fix common/ includes.
12944         * i387-tdep.c: Fix common/ includes.
12945         * i386-tdep.c: Fix common/ includes.
12946         * i386-linux-tdep.c: Fix common/ includes.
12947         * i386-linux-nat.c: Fix common/ includes.
12948         * i386-go32-tdep.c: Fix common/ includes.
12949         * i386-fbsd-tdep.c: Fix common/ includes.
12950         * i386-fbsd-nat.c: Fix common/ includes.
12951         * guile/scm-type.c: Fix common/ includes.
12952         * guile/guile.c: Fix common/ includes.
12953         * go32-nat.c: Fix common/ includes.
12954         * gnu-nat.c: Fix common/ includes.
12955         * gdbthread.h: Fix common/ includes.
12956         * gdbarch-selftests.c: Fix common/ includes.
12957         * gdb_usleep.c: Fix common/ includes.
12958         * gdb_select.h: Fix common/ includes.
12959         * gdb_bfd.c: Fix common/ includes.
12960         * gcore.c: Fix common/ includes.
12961         * fork-child.c: Fix common/ includes.
12962         * findvar.c: Fix common/ includes.
12963         * fbsd-nat.c: Fix common/ includes.
12964         * event-top.c: Fix common/ includes.
12965         * event-loop.c: Fix common/ includes.
12966         * dwarf2read.c: Fix common/ includes.
12967         * dwarf2loc.c: Fix common/ includes.
12968         * dwarf2-frame.c: Fix common/ includes.
12969         * dwarf-index-cache.c: Fix common/ includes.
12970         * dtrace-probe.c: Fix common/ includes.
12971         * disasm-selftests.c: Fix common/ includes.
12972         * defs.h: Fix common/ includes.
12973         * csky-tdep.c: Fix common/ includes.
12974         * cp-valprint.c: Fix common/ includes.
12975         * cp-support.h: Fix common/ includes.
12976         * cp-support.c: Fix common/ includes.
12977         * corelow.c: Fix common/ includes.
12978         * completer.h: Fix common/ includes.
12979         * completer.c: Fix common/ includes.
12980         * compile/compile.c: Fix common/ includes.
12981         * compile/compile-loc2c.c: Fix common/ includes.
12982         * compile/compile-cplus-types.c: Fix common/ includes.
12983         * compile/compile-cplus-symbols.c: Fix common/ includes.
12984         * command.h: Fix common/ includes.
12985         * cli/cli-dump.c: Fix common/ includes.
12986         * cli/cli-cmds.c: Fix common/ includes.
12987         * charset.c: Fix common/ includes.
12988         * build-id.c: Fix common/ includes.
12989         * btrace.h: Fix common/ includes.
12990         * btrace.c: Fix common/ includes.
12991         * breakpoint.h: Fix common/ includes.
12992         * breakpoint.c: Fix common/ includes.
12993         * ax.h:
12994         (enum agent_op): Fix common/ includes.
12995         * ax-general.c (struct aop_map): Fix common/ includes.
12996         * ax-gdb.c: Fix common/ includes.
12997         * auxv.c: Fix common/ includes.
12998         * auto-load.c: Fix common/ includes.
12999         * arm-tdep.c: Fix common/ includes.
13000         * arch/riscv.c: Fix common/ includes.
13001         * arch/ppc-linux-common.c: Fix common/ includes.
13002         * arch/i386.c: Fix common/ includes.
13003         * arch/arm.c: Fix common/ includes.
13004         * arch/arm-linux.c: Fix common/ includes.
13005         * arch/arm-get-next-pcs.c: Fix common/ includes.
13006         * arch/amd64.c: Fix common/ includes.
13007         * arch/aarch64.c: Fix common/ includes.
13008         * arch/aarch64-insn.c: Fix common/ includes.
13009         * arch-utils.c: Fix common/ includes.
13010         * amd64-windows-tdep.c: Fix common/ includes.
13011         * amd64-tdep.c: Fix common/ includes.
13012         * amd64-sol2-tdep.c: Fix common/ includes.
13013         * amd64-obsd-tdep.c: Fix common/ includes.
13014         * amd64-nbsd-tdep.c: Fix common/ includes.
13015         * amd64-linux-tdep.c: Fix common/ includes.
13016         * amd64-linux-nat.c: Fix common/ includes.
13017         * amd64-fbsd-tdep.c: Fix common/ includes.
13018         * amd64-fbsd-nat.c: Fix common/ includes.
13019         * amd64-dicos-tdep.c: Fix common/ includes.
13020         * amd64-darwin-tdep.c: Fix common/ includes.
13021         * agent.c: Fix common/ includes.
13022         * ada-lang.h: Fix common/ includes.
13023         * ada-lang.c: Fix common/ includes.
13024         * aarch64-tdep.c: Fix common/ includes.
13025
13026 2019-01-25  Tom Tromey  <tom@tromey.com>
13027
13028         * common/create-version.sh: Use common/version.h.
13029
13030 2019-01-24  Pedro Alves  <palves@redhat.com>
13031
13032         * infrun.c (signal_stop, signal_print, signal_program)
13033         (signal_catch, signal_pass): Now arrays instead of pointers.
13034         (update_signals_program_target, do_target_resume)
13035         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
13036         * linux-nat.c (linux_nat_target::pass_signals)
13037         (linux_nat_target::create_inferior, linux_nat_target::attach):
13038         Adjust.
13039         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
13040         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
13041         * procfs.c (procfs_target::pass_signals): Adjust.
13042         * record-full.c (record_full_target::resume): Adjust.
13043         * remote.c (remote_target::pass_signals)
13044         (remote_target::program_signals): Adjust.
13045         * target-debug.h (target_debug_print_signals): Now takes a
13046         gdb::array_view as parameter.  Adjust.
13047         * target.h (target_ops) <pass_signals, program_signals>: Replace
13048         pointer and length parameters with gdb::array_view.
13049         (target_pass_signals, target_program_signals): Likewise.
13050         * target-delegates.c: Regenerate.
13051
13052 2019-01-24  Pedro Alves  <palves@redhat.com>
13053
13054         * common/forward-scope-exit.h
13055         (forward_scope_exit::forward_scope_exit): Pass arguments to
13056         m_bind_function directly, instead of creating a std::bind and
13057         copying that.
13058
13059 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
13060
13061         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
13062         for static members.
13063         (pass_in_v_vfp_candidate): Likewise.
13064
13065 2019-01-23  Tom Tromey  <tom@tromey.com>
13066             Pedro Alves  <palves@redhat.com>
13067
13068         * regcache.c (class regcache_invalidator): Remove.
13069         (regcache::raw_write): Use make_scope_exit.
13070
13071 2019-01-23  Tom Tromey  <tom@tromey.com>
13072
13073         * ui-out.h (class ui_out_emit_type): Update comment.
13074
13075 2019-01-23  Tom Tromey  <tom@tromey.com>
13076
13077         * infrun.c (fetch_inferior_event): Update comment.
13078
13079 2019-01-23  Tom Tromey  <tom@tromey.com>
13080             Pedro Alves  <palves@redhat.com>
13081
13082         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
13083         parameter.
13084         (fetch_inferior_event): Use SCOPE_EXIT.
13085
13086
13087 2019-01-23  Tom Tromey  <tom@tromey.com>
13088             Pedro Alves  <palves@redhat.com>
13089
13090         * infrun.c (disable_thread_events): Delete.
13091         (stop_all_threads): Use SCOPE_EXIT.
13092
13093 2019-01-23  Tom Tromey  <tom@tromey.com>
13094             Pedro Alves  <palves@redhat.com>
13095
13096         * symfile.c: Include forward-scope-exit.h.
13097         (clear_symtab_users_cleanup): Replace forward declaration with
13098         a FORWARD_SCOPE_EXIT.
13099         (syms_from_objfile_1): Use the forward_scope_exit and
13100         gdb::optional instead of cleanup_function.
13101         (reread_symbols): Use the forward_scope_exit instead of
13102         cleanup_function.
13103         (clear_symtab_users_cleanup): Remove function.
13104
13105 2019-01-23  Tom Tromey  <tom@tromey.com>
13106             Pedro Alves  <palves@redhat.com>
13107
13108         * linux-nat.c: Include scope-exit.h.
13109         (cleanup_target_stop): Remove.
13110         (linux_nat_target::static_tracepoint_markers_by_strid): Use
13111         SCOPE_EXIT.
13112
13113 2019-01-23  Tom Tromey  <tom@tromey.com>
13114             Pedro Alves  <palves@redhat.com>
13115
13116         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
13117         (call_function_by_hand_dummy): Use SCOPE_EXIT.
13118
13119 2019-01-23  Tom Tromey  <tom@tromey.com>
13120             Andrew Burgess  <andrew.burgess@embecosm.com>
13121             Pedro Alves  <palves@redhat.com>
13122
13123         * infrun.c (fetch_inferior_event): Use scope_exit.
13124         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
13125         * top.c (execute_command): Use scope_exit.
13126         * breakpoint.c (bpstat_do_actions): Use scope_exit.
13127         * utils.c (do_bpstat_clear_actions_cleanup)
13128         (make_bpstat_clear_actions_cleanup): Remove.
13129
13130 2019-01-23  Tom Tromey  <tom@tromey.com>
13131             Pedro Alves  <palves@redhat.com>
13132
13133         * infrun.c: Include "common/scope-exit.h"
13134         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
13135         (wait_for_inferior): Use SCOPE_EXIT.
13136         (fetch_inferior_event): Use scope_exit.
13137
13138 2019-01-23  Tom Tromey  <tom@tromey.com>
13139             Pedro Alves  <palves@redhat.com>
13140
13141         * breakpoint.c (create_breakpoint): Remove cleanup.
13142
13143 2019-01-23  Tom Tromey  <tom@tromey.com>
13144             Andrew Burgess  <andrew.burgess@embecosm.com>
13145             Pedro Alves  <palves@redhat.com>
13146
13147 2019-01-23  Pedro Alves  <palves@redhat.com>
13148
13149         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
13150
13151 2019-01-23  Pedro Alves  <palves@redhat.com>
13152             Andrew Burgess  <andrew.burgess@embecosm.com>
13153
13154         * gdbthread.h: Include "common/forward-scope-exit.h".
13155         (scoped_finish_thread_state): Redefine custom class in terms of
13156         forward_scope_exit.
13157
13158 2019-01-23  Pedro Alves  <palves@redhat.com>
13159             Andrew Burgess  <andrew.burgess@embecosm.com>
13160
13161         * common/forward-scope-exit.h: New file.
13162
13163 2019-01-23  Pedro Alves  <palves@redhat.com>
13164             Andrew Burgess  <andrew.burgess@embecosm.com>
13165             Tom Tromey  <tom@tromey.com>
13166
13167         * common/scope-exit.h: New file.
13168
13169 2019-01-23  Pedro Alves  <palves@redhat.com>
13170
13171         * common/preprocessor.h (ESC): Rename to ...
13172         (ESC_PARENS): ... this.
13173         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
13174         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
13175
13176 2019-01-23  Tom Tromey  <tom@tromey.com>
13177
13178         * language.h (class scoped_switch_to_sym_language_if_auto):
13179         Initialize m_lang in both cases.
13180
13181 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
13182
13183         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
13184         with XCNEW.
13185
13186 2019-01-22  Tom Tromey  <tom@tromey.com>
13187
13188         * corelow.c: Do not include sys/file.h.
13189
13190 2019-01-22  Tom Tromey  <tom@tromey.com>
13191
13192         * tui/tui-wingeneral.h: Include gdb_curses.h.
13193
13194 2019-01-22  Tom Tromey  <tom@tromey.com>
13195
13196         * source-cache.h (class source_cache) <get_source_lines,
13197         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
13198
13199 2019-01-22  Tom Tromey  <tom@tromey.com>
13200
13201         * remote-fileio.h (struct remote_target): Declare.
13202
13203 2019-01-22  Tom Tromey  <tom@tromey.com>
13204
13205         * python/py-arch.c: Do not include py-ref.h.
13206         * python/py-bpevent.c: Do not include py-ref.h.
13207         * python/py-cmd.c: Do not include py-ref.h.
13208         * python/py-continueevent.c: Do not include py-ref.h.
13209         * python/py-event.h: Do not include py-ref.h.
13210         * python/py-evtregistry.c: Do not include py-ref.h.
13211         * python/py-finishbreakpoint.c: Do not include py-ref.h.
13212         * python/py-frame.c: Do not include py-ref.h.
13213         * python/py-framefilter.c: Do not include py-ref.h.
13214         * python/py-function.c: Do not include py-ref.h.
13215         * python/py-infevents.c: Do not include py-ref.h.
13216         * python/py-linetable.c: Do not include py-ref.h.
13217         * python/py-objfile.c: Do not include py-ref.h.
13218         * python/py-param.c: Do not include py-ref.h.
13219         * python/py-prettyprint.c: Do not include py-ref.h.
13220         * python/py-progspace.c: Do not include py-ref.h.
13221         * python/py-symbol.c: Do not include py-ref.h.
13222         * python/py-symtab.c: Do not include py-ref.h.
13223         * python/py-type.c: Do not include py-ref.h.
13224         * python/py-unwind.c: Do not include py-ref.h.
13225         * python/py-utils.c: Do not include py-ref.h.
13226         * python/py-value.c: Do not include py-ref.h.
13227         * python/py-varobj.c: Do not include py-ref.h.
13228         * python/py-xmethods.c: Do not include py-ref.h.
13229         * python/python.c: Do not include py-ref.h.
13230         * varobj.c: Do not include py-ref.h.
13231
13232 2019-01-22  Tom Tromey  <tom@tromey.com>
13233
13234         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
13235         keyword for bcache.
13236
13237 2019-01-22  Tom Tromey  <tom@tromey.com>
13238
13239         * compile/compile-cplus-types.c: Remove a comment by #include.
13240
13241 2019-01-22  Tom Tromey  <tom@tromey.com>
13242
13243         * compile/gcc-c-plugin.h: Include compile-internal.h.
13244
13245 2019-01-22  Tom Tromey  <tom@tromey.com>
13246
13247         * stabsread.c (EXTERN): Do not define.
13248         (symnum, next_symbol_text_func, processing_gcc_compilation)
13249         (within_function, global_sym_chain, global_stabs)
13250         (previous_stab_code, this_object_header_files)
13251         (n_this_object_header_files)
13252         (n_allocated_this_object_header_files): Define.
13253         * stabsread.h (EXTERN): Never define.  Use "extern".
13254
13255 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13256
13257         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
13258         history_value.
13259
13260 2019-01-21  Tom Tromey  <tom@tromey.com>
13261
13262         * ui-out.c: Fix includes.
13263         * tui/tui-source.c: Fix includes.
13264         * target.c: Fix includes.
13265         * remote.c: Fix includes.
13266         * regcache.c: Fix includes.
13267         * python/py-block.c: Fix includes.
13268         * printcmd.c: Fix includes.
13269         * or1k-tdep.c: Fix includes.
13270         * mi/mi-main.c: Fix includes.
13271         * m32r-tdep.c: Fix includes.
13272         * csky-tdep.c: Fix includes.
13273         * compile/compile-cplus-types.c: Fix includes.
13274         * cli/cli-interp.c: Fix includes.
13275
13276 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
13277
13278         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
13279         for padding.
13280
13281 2019-01-16  Tom Tromey  <tom@tromey.com>
13282
13283         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
13284         earlier.
13285         (struct objfile) <msymbols_range>: Move from top level.
13286         <msymbols>: New method.
13287         (class objfile_msymbols): Remove.
13288         * symtab.c (default_collect_symbol_completion_matches_break_on):
13289         Update.
13290         * symmisc.c (dump_msymbols): Update.
13291         * stabsread.c (scan_file_globals): Update.
13292         * objc-lang.c (info_selectors_command, info_classes_command)
13293         (find_methods): Update.
13294         * minsyms.c (find_solib_trampoline_target): Update.
13295         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
13296         * coffread.c (coff_symfile_read): Update.
13297         * ada-lang.c (ada_lookup_simple_minsym)
13298         (ada_collect_symbol_completion_matches): Update.
13299
13300 2019-01-16  Tom Tromey  <tom@tromey.com>
13301
13302         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
13303         type.  Remove no-argument constructor.
13304         <iterator::operator++>: Simplify.
13305         <begin>: Update.
13306         <end>: Use minimal_symbol_count.
13307
13308 2019-01-16  Tom Tromey  <tom@tromey.com>
13309
13310         * objfiles.h (struct objfile) <psymtabs>: New method.
13311         (class objfile_psymtabs): Remove.
13312         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
13313         typedef.
13314         <range>: New method.
13315         (require_partial_symbols): Change return type.
13316         * psymtab.c (require_partial_symbols)
13317         (psym_expand_symtabs_matching): Update.
13318         * mdebugread.c (parse_partial_symbols): Update.
13319         * dbxread.c (dbx_end_psymtab): Update.
13320
13321 2019-01-15  Tom Tromey  <tom@tromey.com>
13322
13323         * symtab.c (lookup_objfile_from_block)
13324         (lookup_symbol_in_objfile_symtabs)
13325         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
13326         (find_line_symtab, info_sources_command)
13327         (default_collect_symbol_completion_matches_break_on)
13328         (make_source_files_completion_list): Update.
13329         * symmisc.c (print_objfile_statistics, dump_objfile)
13330         (maintenance_print_symbols, maintenance_info_symtabs)
13331         (maintenance_check_symtabs, maintenance_info_line_tables):
13332         Update.
13333         * source.c (select_source_symtab)
13334         (forget_cached_source_info_for_objfile): Update.
13335         * objfiles.h (class objfile_compunits): Remove.
13336         (struct objfile) <compunits_range>: New typedef.
13337         (compunits): New method.
13338         * objfiles.c (objfile_relocate1): Update.
13339         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
13340         * maint.c (count_symtabs_and_blocks): Update.
13341         * linespec.c (iterate_over_all_matching_symtabs): Update.
13342         * cp-support.c (add_symbol_overload_list_qualified): Update.
13343         * coffread.c (coff_symtab_read): Update.
13344         * ada-lang.c (add_nonlocal_symbols)
13345         (ada_collect_symbol_completion_matches)
13346         (ada_add_global_exceptions): Update.
13347
13348 2019-01-15  Tom Tromey  <tom@tromey.com>
13349
13350         * progspace.h (program_space) <objfiles_safe_range>: New
13351         typedef.
13352         <objfiles_safe>: New method.
13353         * objfiles.h (class all_objfiles_safe): Remove.
13354         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
13355         * jit.c (jit_inferior_exit_hook): Update.
13356
13357 2019-01-17  Tom Tromey  <tom@tromey.com>
13358
13359         * progspace.h (program_space) <objfiles_range>: New typedef.
13360         <objfiles>: New method.
13361         <objfiles_head>: Rename from objfiles.
13362         (object_files): Update.
13363         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
13364         * guile/scm-pretty-print.c
13365         (ppscm_find_pretty_printer_from_objfiles): Update.
13366         * guile/scm-objfile.c (gdbscm_objfiles): Update.
13367         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
13368         Update.
13369         * python/py-progspace.c (pspy_get_objfiles): Update.
13370         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
13371         Update.
13372         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
13373         (objfpy_lookup_objfile_by_build_id): Update.
13374         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
13375         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
13376         Update.
13377         * symtab.c (iterate_over_symtabs, matching_obj_sections)
13378         (expand_symtab_containing_pc, lookup_objfile_from_block)
13379         (lookup_static_symbol, basic_lookup_transparent_type)
13380         (find_pc_sect_compunit_symtab, find_symbol_at_address)
13381         (find_line_symtab, info_sources_command)
13382         (default_collect_symbol_completion_matches_break_on)
13383         (make_source_files_completion_list, find_main_name): Update.
13384         * symmisc.c (print_symbol_bcache_statistics)
13385         (print_objfile_statistics, maintenance_print_symbols)
13386         (maintenance_print_msymbols, maintenance_print_objfiles)
13387         (maintenance_info_symtabs, maintenance_check_symtabs)
13388         (maintenance_expand_symtabs, maintenance_info_line_tables):
13389         Update.
13390         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
13391         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
13392         (map_overlay_command, unmap_overlay_command)
13393         (simple_overlay_update, expand_symtabs_matching)
13394         (map_symbol_filenames): Update.
13395         * symfile-debug.c (set_debug_symfile): Update.
13396         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
13397         Update.
13398         * source.c (select_source_symtab, forget_cached_source_info):
13399         Update.
13400         * solib.c (solib_read_symbols): Update.
13401         * solib-spu.c (append_ocl_sos): Update.
13402         * psymtab.c (maintenance_print_psymbols)
13403         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
13404         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
13405         * printcmd.c (info_symbol_command): Update.
13406         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
13407         Update.
13408         * objfiles.h (class all_objfiles): Remove.
13409         * objfiles.c (have_partial_symbols, have_full_symbols)
13410         (have_minimal_symbols, qsort_cmp, update_section_map)
13411         (shared_objfile_contains_address_p)
13412         (default_iterate_over_objfiles_in_search_order): Update.
13413         * objc-lang.c (info_selectors_command, info_classes_command)
13414         (find_methods): Update.
13415         * minsyms.c (find_solib_trampoline_target): Update.
13416         * maint.c (maintenance_info_sections)
13417         (maintenance_translate_address, count_symtabs_and_blocks):
13418         Update.
13419         * main.c (captured_main_1): Update.
13420         * linux-thread-db.c (try_thread_db_load_from_pdir)
13421         (has_libpthread): Update.
13422         * linespec.c (iterate_over_all_matching_symtabs)
13423         (search_minsyms_for_name): Update.
13424         * jit.c (jit_find_objf_with_entry_addr): Update.
13425         * hppa-tdep.c (find_unwind_entry)
13426         (hppa_lookup_stub_minimal_symbol): Update.
13427         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
13428         Update.
13429         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
13430         (elf_gnu_ifunc_resolve_by_got): Update.
13431         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
13432         * dwarf-index-write.c (save_gdb_index_command): Update.
13433         * cp-support.c (add_symbol_overload_list_qualified): Update.
13434         * breakpoint.c (create_overlay_event_breakpoint)
13435         (create_longjmp_master_breakpoint)
13436         (create_std_terminate_master_breakpoint)
13437         (create_exception_master_breakpoint): Update.
13438         * blockframe.c (find_pc_partial_function): Update.
13439         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
13440         (ada_collect_symbol_completion_matches)
13441         (ada_add_global_exceptions): Update.
13442
13443 2019-01-17  Tom Tromey  <tom@tromey.com>
13444
13445         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
13446         declare VEC.
13447         (solib_target_parse_libraries): Change return type.
13448         (library_list_start_segment, library_list_start_section)
13449         (library_list_end_library, library_list_start_library); Update.
13450         (solib_target_free_library_list): Remove.
13451         (solib_target_parse_libraries): Remove cleanup.  Change return
13452         type.
13453         (solib_target_current_sos): Update.
13454
13455 2019-01-17  Tom Tromey  <tromey@bapiya>
13456
13457         * valprint.c: Replace "the the" with "the".
13458         * symtab.c: Replace "the the" with "the".
13459         * solib.c: Replace "the the" with "the".
13460         * solib-dsbt.c: Replace "the the" with "the".
13461         * linespec.c: Replace "the the" with "the".
13462         * dwarf2loc.h: Replace "the the" with "the".
13463         * amd64-windows-tdep.c: Replace "the the" with "the".
13464         * aarch64-tdep.c: Replace "the the" with "the".
13465
13466 2019-01-16  Keith Seitz  <keiths@redhat.com>
13467
13468         PR gdb/23773
13469         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
13470         <builder>: Rename to ..
13471         <m_builder>: ... this and make private.
13472         (dwarf2_cu::get_builder): New method.  Change all users of
13473         `builder' to use this method.
13474         (dwarf2_start_symtab): Move to ...
13475         (dwarf2_cu::start_symtab): ... here.  Update all callers
13476         (setup_type_unit_groups): Move to ...
13477         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
13478         callers.
13479         (dwarf2_cu::reset_builder): New method.
13480         (process_full_compunit, process_full_type_unit): Use
13481         dwarf2_cu::reset_builder.
13482         (follow_die_offset): Record the ancestor CU if it is different
13483         from the followed DIE's CU.
13484         (follow_die_sig_1): Likewise.
13485
13486 2019-01-15  Tom Tromey  <tom@tromey.com>
13487
13488         * remote.c (class remote_state) <buf>: Now a char_vector.
13489         <buf_size>: Remove.
13490         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
13491         parameter.
13492         (remote_target::getpkt_or_notif_sane_1)
13493         (remote_target::getpkt_sane)
13494         (remote_target::getpkt_or_notif_sane): Likewise.
13495         (class remote_target) <putpkt>: New overload.
13496         (remote_target::read_frame): Change type of "buf_p".  Remove
13497         sizeof_p parameter.
13498         (packet_ok): New overload.
13499         (packet_check_result): New overload.
13500         Update all uses.
13501
13502 2019-01-14  Tom Tromey  <tom@tromey.com>
13503
13504         * remote-notif.c (handle_notification, remote_notif_ack)
13505         (remote_notif_parse): Make "buf" const.
13506         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
13507         const.
13508         (remote_notif_parse, remote_notif_ack, handle_notification):
13509         Likewise.
13510         * remote.c (remote_notif_stop_parse): Make "buf" const.
13511         (remote_target::remote_parse_stop_reply): Make "buf" const.
13512         (remote_notif_stop_ack): Make "buf" const.
13513
13514 2019-01-14  Tom Tromey  <tom@tromey.com>
13515
13516         * remote.c (remote_console_output): Make parameter const.
13517
13518 2019-01-14  Tom Tromey  <tom@tromey.com>
13519
13520         * target-debug.h (target_debug_print_signals): Constify.
13521         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
13522         * procfs.c (procfs_target::pass_signals): Update.
13523         * linux-nat.c (linux_nat_target::pass_signals): Update.
13524         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
13525         * target-delegates.c: Rebuild.
13526         * remote.c (remote_target::program_signals): Update.
13527         (remote_target::pass_signals): Update.
13528         * target.c (target_pass_signals): Constify argument.
13529         (target_program_signals): Likewise.
13530         * target.h (struct target_ops) <pass_signals, program_signals>:
13531         Constify argument.
13532         (target_pass_signals, target_program_signals): Constify argument.
13533
13534 2019-01-14  Tom Tromey  <tom@tromey.com>
13535
13536         PR tui/28819:
13537         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
13538
13539 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
13540
13541         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
13542         field.
13543         * rs6000-tdep.c: Include reggroups.h.
13544         (IS_V_ALIAS_PSEUDOREG): Define.
13545         (rs6000_register_name): Return names for the "vX" aliases.
13546         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
13547         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
13548         aliases.  Call default_register_reggroup_p for all other
13549         pseudo-registers.
13550         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
13551         New functions.
13552         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
13553         Handle "vX" aliases.
13554         (v_alias_pseudo_register_collect): New function.
13555         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
13556         (rs6000_gdbarch_init): Initialize "vX" aliases as
13557         pseudo-registers.  Restore registration of
13558         rs6000_pseudo_register_reggroup_p with
13559         set_tdesc_pseudo_register_reggroup_p.
13560
13561 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
13562
13563         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
13564         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
13565         set_gdbarch_num_pseudo_regs.
13566
13567 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13568
13569         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
13570         Remove arg prefixname, add do_set and do_show.
13571         Add member functions set_list and show_list.
13572         * cli/cli-style.c (class cli_style_option): Update accordingly.
13573         (style_set_list): Move to file scope.
13574         (style_show_list): Likewise.
13575         (set_style): Call help_list.
13576         (show_style): Call cmd_show_list.
13577         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
13578         Update to use the new macro.
13579
13580 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
13581
13582         * ada-lang.c (_initialize_ada_language): Expand the help text
13583         for the "catch exception" command.
13584
13585 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13586
13587         * symtab.c (matching_obj_sections): Initialize obj,
13588         declare it closer to its usage.
13589
13590 2019-01-10  Tom Tromey  <tom@tromey.com>
13591
13592         * thread-iter.h (inf_threads_iterator): Use next_iterator.
13593         (basic_inf_threads_range): Remove.
13594         (inf_threads_range, inf_non_exited_threads_range)
13595         (safe_inf_threads_range): Use next_adapter.
13596
13597 2019-01-10  Keith Seitz  <keiths@redhat.com>
13598
13599         PR gdb/23712
13600         PR symtab/23010
13601         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
13602         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
13603
13604 2019-01-10  Keith Seitz  <keiths@redhat.com>
13605
13606         PR gdb/23712
13607         PR symtab/23010
13608         * dictionary.c (pending_to_vector): Remove.
13609         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
13610         Remove _1 suffix, replacing functions of the same name.  Update
13611         all callers.
13612         (dict_create_hashed, dict_create_hashed_expandable)
13613         (dict_create_linear, dict_create_linear_expandable, dict_free)
13614         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
13615         Make functions static.
13616
13617 2019-01-10  Keith Seitz  <keiths@redhat.com>
13618
13619         PR gdb/23712
13620         PR symtab/23010
13621         * dictionary.h (struct dictionary): Replace declaration with
13622         multidictionary.
13623         (dict_create_hashed, dict_create_hashed_expandable)
13624         (dict_create_linear, dict_create_linear_expandable)
13625         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
13626         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
13627         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
13628         taking multidictionary argument.
13629         [ALL_DICT_SYMBOLS]: Update for multidictionary.
13630         * block.h (struct block) <dict>: Change to multidictionary
13631         and rename `multidict'.
13632         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
13633         symmisc.c: Update all dictionary references to multidictionary.
13634
13635 2019-01-10  Keith Seitz  <keiths@redhat.com>
13636
13637         PR gdb/23712
13638         PR symtab/23010
13639         * dictionary.c: Include unordered_map.
13640         (pending_to_vector): New function.
13641         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
13642         Rewrite the non-"_1" functions to take vector instead
13643         of linked list.
13644         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
13645         "new" _1 versions of the same name.
13646         (multidictionary): Define.
13647         (std::hash<enum language): New definition.
13648         (collate_pending_symbols_by_language, mdict_create_hashed)
13649         (mdict_create_hashed_expandable, mdict_create_linear)
13650         (mdict_create_linear_expandable, mdict_free)
13651         (find_language_dictionary, create_new_language_dictionary)
13652         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
13653         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
13654         (mdict_size, mdict_empty): New functions.
13655         * dictionary.h (mdict_iterator): Define.
13656
13657 2019-01-10  Pedro Alves  <palves@redhat.com>
13658
13659         * breakpoint.c (read_uploaded_action)
13660         (create_tracepoint_from_upload): Adjust to use
13661         gdb::unique_xmalloc_ptr.
13662         * ctf.c (ctf_write_uploaded_tp):
13663         (SET_ARRAY_FIELD): Use emplace_back.
13664         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
13665         * tracefile-tfile.c (tfile_write_uploaded_tp):
13666         * tracepoint.c (parse_tracepoint_definition): Adjust to use
13667         gdb::unique_xmalloc_ptr.
13668         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
13669         at_string, cond_string, cmd_strings>: Replace char pointers
13670         with gdb::unique_xmalloc_ptr.
13671
13672 2019-01-10  Pedro Alves  <palves@redhat.com>
13673
13674         * solib-target.c (library_list_start_library): Don't xstrdup name.
13675
13676 2019-01-10  Pedro Alves  <palves@redhat.com>
13677
13678         * mdebugread.c (parse_partial_symbols): Use
13679         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
13680
13681 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
13682
13683         * linux-fork.c (scoped_switch_fork_info)
13684         <~scoped_switch_fork_info>: Fix incorrect variable name.
13685
13686 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
13687
13688         * linux-fork.c (scoped_switch_fork_info)
13689         <scoped_switch_fork_info>: Make explicit.
13690         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
13691
13692 2019-01-10  Tom Tromey  <tom@tromey.com>
13693
13694         * objfiles.h (objfile::reset_psymtabs): Update.
13695         * objfiles.c (objfile::objfile): Update.
13696         * psymtab.h (psymtab_storage::obstack): Update.
13697         (psymtab_storage::m_obstack): Use gdb::optional.
13698         (class psymtab_storage): Update comment.  Remove objfile
13699         parameter.
13700         * psymtab.c (psymtab_storage::psymtab_storage): Update.
13701
13702 2019-01-10  Tom Tromey  <tom@tromey.com>
13703
13704         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
13705         <free_psymtabs>: Now private.
13706         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
13707         (allocate_psymtab): Use new method.
13708
13709 2019-01-10  Tom Tromey  <tom@tromey.com>
13710
13711         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
13712         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
13713         * mdebugread.c (parse_partial_symbols): Use
13714         allocate_dependencies.
13715         * dwarf2read.c (dwarf2_create_include_psymtab): Use
13716         allocate_dependencies.
13717         (process_psymtab_comp_unit_reader)
13718         (build_type_psymtab_dependencies): Likewise.
13719         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
13720
13721 2019-01-10  Tom Tromey  <tom@tromey.com>
13722
13723         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
13724         PSYMBOL_SET_LANGUAGE.
13725         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
13726
13727 2019-01-10  Tom Tromey  <tom@tromey.com>
13728
13729         * psymtab.h (psymtab_storage::obstack): New method.
13730         <m_obstack>: Rename from obstack; now private.
13731         * psymtab.c (psymtab_storage): Update.
13732         * dwarf2read.c (create_addrmap_from_index)
13733         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
13734         Update.
13735
13736 2019-01-10  Tom Tromey  <tom@tromey.com>
13737
13738         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
13739         * objfiles.h (objfile::reset_psymtabs): New method.
13740
13741 2019-01-10  Tom Tromey  <tom@tromey.com>
13742
13743         * symmisc.c (print_symbol_bcache_statistics): Update.
13744         (print_objfile_statistics): Update.
13745         * symfile.c (reread_symbols): Update.
13746         * psymtab.h (class psymtab_storage): New.
13747         * psymtab.c (psymtab_storage): New constructor.
13748         (~psymtab_storage): New destructor.
13749         (require_partial_symbols): Update.
13750         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
13751         (find_pc_sect_psymtab, find_pc_sect_psymbol)
13752         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
13753         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
13754         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
13755         (start_psymtab_common, end_psymtab_common)
13756         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
13757         (allocate_psymtab): Update.
13758         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
13759         Update.
13760         (dump_psymtab_addrmap, maintenance_print_psymbols)
13761         (maintenance_check_psymtabs): Update.
13762         (class objfile_psymtabs): Move to objfiles.h.
13763         * psympriv.h (discard_psymtab): Now inline.
13764         (psymtab_discarder::psymtab_discarder): Update.
13765         (psymtab_discarder::~psymtab_discarder): Update.
13766         (ALL_OBJFILE_PSYMTABS): Rewrite.
13767         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
13768         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
13769         Remove fields.
13770         <partial_symtabs>: New field.
13771         (class objfile_psymtabs): Move from psymtab.h.  Update.
13772         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
13773         psymbol_cache.
13774         (objfile::~objfile): Don't destroy psymbol_cache.
13775         * mdebugread.c (parse_partial_symbols): Update.
13776         * dwarf2read.c (create_addrmap_from_index)
13777         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
13778         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
13779         (add_partial_subprogram, dwarf2_ranges_read): Update.
13780         * dwarf-index-write.c (write_address_map)
13781         (write_one_signatured_type, recursively_write_psymbols)
13782         (class debug_names, class debug_names, write_psymtabs_to_index):
13783         Update.
13784
13785 2019-01-10  Tom Tromey  <tom@tromey.com>
13786
13787         * symtab.h (SYMBOL_SET_NAMES): Update.
13788         (symbol_set_names): Update.
13789         (MSYMBOL_SET_NAMES): Update.
13790         * symtab.c (symbol_set_names): Change argument to be an
13791         objfile_per_bfd_storage.
13792         * psymtab.c (add_psymbol_to_bcache): Update.
13793         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
13794
13795 2019-01-10  Tom Tromey  <tom@tromey.com>
13796
13797         * symtab.c (create_demangled_names_hash): Change argument to be an
13798         objfile_per_bfd_storage.
13799         (symbol_set_names): Update.
13800
13801 2019-01-10  Tom Tromey  <tom@tromey.com>
13802
13803         * xcoffread.c (xcoff_initial_scan): Unconditionally call
13804         init_psymbol_list.
13805         * psymtab.c (init_psymbol_list): Do nothing if already called.
13806         * psympriv.h (init_psymbol_list): Add comment.
13807         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
13808         init_psymbol_list.
13809         * dbxread.c (dbx_symfile_read): Unconditionally call
13810         init_psymbol_list.
13811
13812 2019-01-10  Tom Tromey  <tom@tromey.com>
13813
13814         * xcoffread.c (scan_xcoff_symtab): Update.
13815         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
13816         "where".
13817         * mdebugread.c (parse_partial_symbols)
13818         (handle_psymbol_enumerators): Update.
13819         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
13820         * dbxread.c (read_dbx_symtab): Update.
13821         * psympriv.h (psymbol_placement): New enum.
13822         (add_psymbol_to_list): Update.
13823
13824 2019-01-10  Tom Tromey  <tom@tromey.com>
13825
13826         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
13827         static_psymbols parameters.
13828         (scan_xcoff_symtab): Update.
13829         * psymtab.c (start_psymtab_common): Remove global_psymbols and
13830         static_psymbols parameters.
13831         * psympriv.h (start_psymtab_common): Update.
13832         * mdebugread.c (parse_partial_symbols): Update.
13833         * dwarf2read.c (create_partial_symtab): Update.
13834         * dbxread.c (read_dbx_symtab): Update.
13835         (start_psymtab): Remove global_psymbols and static_psymbols
13836         parameters.
13837
13838 2019-01-10  Tom Tromey  <tom@tromey.com>
13839
13840         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
13841         * psymtab.c (allocate_psymtab): Add comment.
13842         * psympriv.h (allocate_psymtab): Add comment.
13843         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
13844         initializations.
13845         * dbxread.c (dbx_end_psymtab): Remove some initializations.
13846
13847 2019-01-10  Tom Tromey  <tom@tromey.com>
13848
13849         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
13850         Don't declare.
13851         * mipsread.c: Include mdebugread.h.
13852         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
13853         Declare.
13854         * elfread.c: Include mdebugread.h.
13855
13856 2019-01-09  Tom Tromey  <tom@tromey.com>
13857
13858         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
13859         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
13860         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
13861         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
13862         (psym_lookup_symbol, psym_find_last_source_symtab)
13863         (psym_forget_cached_source_info, psym_print_stats)
13864         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
13865         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
13866         (psym_map_matching_symbols, psym_expand_symtabs_matching)
13867         (psym_find_compunit_symtab_by_address)
13868         (maintenance_print_psymbols, maintenance_info_psymtabs)
13869         (maintenance_check_psymtabs): Use ranged for.
13870         * psymtab.h (class objfile_psymtabs): New.
13871         (require_partial_symbols): Return objfile_psymtabs.
13872         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
13873
13874 2019-01-09  Tom Tromey  <tom@tromey.com>
13875
13876         * symfile.c (overlay_invalidate_all, find_pc_overlay)
13877         (find_pc_mapped_section, list_overlays_command)
13878         (map_overlay_command, unmap_overlay_command)
13879         (simple_overlay_update): Use all_objfiles.
13880         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
13881         * printcmd.c (info_symbol_command): Use all_objfiles.
13882         * objfiles.h (ALL_OBJSECTIONS): Remove.
13883         * maint.c (maintenance_translate_address): Use all_objfiles.
13884         * gcore.c (gcore_create_callback): Use all_objfiles.
13885         (objfile_find_memory_regions): Likewise.
13886
13887 2019-01-09  Tom Tromey  <tom@tromey.com>
13888
13889         * symtab.c (find_line_symtab, info_sources_command)
13890         (make_source_files_completion_list): Use objfile_compunits.
13891         * source.c (select_source_symtab): Use objfile_compunits.
13892         * objfiles.h (struct objfile): Update comment.
13893         (ALL_OBJFILES): Remove.
13894         (ALL_FILETABS): Remove.
13895         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
13896         objfile_compunits.
13897
13898 2019-01-09  Tom Tromey  <tom@tromey.com>
13899
13900         * symmisc.c (print_objfile_statistics, dump_objfile)
13901         (maintenance_print_symbols): Use compunit_filetabs.
13902         * source.c (forget_cached_source_info_for_objfile): Use
13903         compunit_filetabs.
13904         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
13905         (ALL_FILETABS): Use compunit_filetabs.
13906         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
13907         * coffread.c (coff_symtab_read): Use compunit_filetabs.
13908
13909 2019-01-09  Tom Tromey  <tom@tromey.com>
13910
13911         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
13912         (compunit_filetabs): New.
13913         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
13914         compunit_filetabs.
13915         (info_sources_command, make_source_files_completion_list): Remove
13916         declaration.
13917         * symmisc.c (print_objfile_statistics, dump_objfile)
13918         (maintenance_print_symbols): Remove declaration.
13919         (maintenance_info_symtabs): Use compunit_filetabs.
13920         (maintenance_info_line_tables): Likewise.
13921         * source.c (select_source_symtab): Change local variable name.
13922         (forget_cached_source_info_for_objfile): Remove declaration.
13923         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
13924         * objfiles.c (objfile_relocate1): Remove declaration.
13925         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
13926         declaration.
13927         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
13928         * coffread.c (coff_symtab_read): Remove declaration.
13929         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
13930         compunit_filetabs.
13931
13932 2019-01-09  Tom Tromey  <tom@tromey.com>
13933
13934         * symtab.c (lookup_objfile_from_block)
13935         (find_pc_sect_compunit_symtab, search_symbols)
13936         (default_collect_symbol_completion_matches_break_on): Use
13937         objfile_compunits.
13938         * objfiles.h (ALL_COMPUNITS): Remove.
13939         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
13940         * cp-support.c (add_symbol_overload_list_qualified): Use
13941         objfile_compunits.
13942         * ada-lang.c (ada_collect_symbol_completion_matches)
13943         (ada_add_global_exceptions): Use objfile_compunits.
13944
13945 2019-01-09  Tom Tromey  <tom@tromey.com>
13946
13947         * source.c (select_source_symtab)
13948         (forget_cached_source_info_for_objfile): Remove declaration.
13949         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
13950         declaration.
13951         * maint.c (count_symtabs_and_blocks): Remove declaration.
13952         * cp-support.c (add_symbol_overload_list_qualified): Remove
13953         declaration.
13954         * coffread.c (coff_symtab_read): Remove declaration.
13955         * symtab.c (lookup_symbol_in_objfile_symtabs)
13956         (basic_lookup_transparent_type_1): Use objfile_compunits.
13957         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
13958         (info_sources_command, search_symbols)
13959         (default_collect_symbol_completion_matches_break_on)
13960         (make_source_files_completion_list): Remove declaration.
13961         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
13962         (ada_collect_symbol_completion_matches)
13963         (ada_add_global_exceptions): Remove declaration.
13964         * linespec.c (iterate_over_all_matching_symtabs): Use
13965         objfile_compunits.
13966         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
13967         (class objfile_compunits): New.
13968         (ALL_COMPUNITS): Use objfile_compunits.
13969         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
13970         (maintenance_check_symtabs, maintenance_info_line_tables): Use
13971         objfile_compunits.
13972         * objfiles.c (objfile_relocate1): Use objfile_compunits.
13973
13974 2019-01-09  Tom Tromey  <tom@tromey.com>
13975
13976         * symtab.c (search_symbols)
13977         (default_collect_symbol_completion_matches_break_on): Use
13978         objfile_msymbols.
13979         * ada-lang.c (ada_lookup_simple_minsym)
13980         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
13981         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
13982         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
13983         objfile_msymbols.
13984         * coffread.c (coff_symfile_read): Use objfile_msymbols.
13985         * symmisc.c (dump_msymbols): Use objfile_msymbols.
13986         * objc-lang.c (find_methods): Use objfile_msymbols.
13987         (info_selectors_command, info_classes_command): Likewise.
13988         * stabsread.c (scan_file_globals): Use objfile_msymbols.
13989         * objfiles.h (class objfile_msymbols): New.
13990         (ALL_OBJFILE_MSYMBOLS): Remove.
13991         (ALL_MSYMBOLS): Remove.
13992
13993 2019-01-09  Tom Tromey  <tom@tromey.com>
13994
13995         * common/next-iterator.h (next_adapter): Add Iterator template
13996         parameter.
13997         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
13998         (class all_objfiles_safe): New.
13999         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
14000         * objfiles.c (put_objfile_before): Update comment.
14001         (add_separate_debug_objfile): Likewise.
14002         (free_all_objfiles): Use all_objfiles_safe.
14003         (objfile_purge_solibs): Likewise.
14004
14005 2019-01-09  Tom Tromey  <tom@tromey.com>
14006
14007         * symtab.c (iterate_over_symtabs, matching_obj_sections)
14008         (expand_symtab_containing_pc, lookup_static_symbol)
14009         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
14010         (find_symbol_at_address, find_line_symtab, find_main_name): Use
14011         all_objfiles.
14012         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
14013         * breakpoint.c (create_overlay_event_breakpoint)
14014         (create_longjmp_master_breakpoint)
14015         (create_std_terminate_master_breakpoint)
14016         (create_exception_master_breakpoint): Use all_objfiles.
14017         * linux-thread-db.c (try_thread_db_load_from_pdir)
14018         (has_libpthread): Use all_objfiles.
14019         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
14020         * linespec.c (iterate_over_all_matching_symtabs)
14021         (search_minsyms_for_name): Use all_objfiles.
14022         * maint.c (maintenance_info_sections): Use all_objfiles.
14023         * main.c (captured_main_1): Use all_objfiles.
14024         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
14025         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
14026         * guile/scm-pretty-print.c
14027         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
14028         * solib-spu.c (append_ocl_sos): Use all_objfiles.
14029         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
14030         (maintenance_print_msymbols): Use all_objfiles.
14031         * source.c (select_source_symtab): Use all_objfiles.
14032         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
14033         * symfile.c (remove_symbol_file_command)
14034         (expand_symtabs_matching, map_symbol_filenames): Use
14035         all_objfiles.
14036         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
14037         all_objfiles.
14038         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
14039         * objc-lang.c (find_methods): Use all_objfiles.
14040         * objfiles.c (have_partial_symbols, have_full_symbols)
14041         (have_minimal_symbols, qsort_cmp)
14042         (default_iterate_over_objfiles_in_search_order): Use
14043         all_objfiles.
14044         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
14045         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
14046         (maintenance_check_psymtabs): Use all_objfiles.
14047         (ALL_PSYMTABS): Remove.
14048         * compile/compile-object-run.c (do_module_cleanup): Use
14049         all_objfiles.
14050         * blockframe.c (find_pc_partial_function): Use all_objfiles.
14051         * cp-support.c (add_symbol_overload_list_qualified): Use
14052         all_objfiles.
14053         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
14054         Use all_objfiles.
14055         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
14056         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
14057         all_objfiles.
14058         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
14059         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
14060         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
14061         Uses all_objfiles.
14062         * solib.c (solib_read_symbols): Use all_objfiles
14063
14064 2019-01-09  Tom Tromey  <tom@tromey.com>
14065
14066         * probe.c (parse_probes_in_pspace): Use all_objfiles.
14067         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
14068         all_objfiles.
14069         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
14070         * symmisc.c (print_symbol_bcache_statistics)
14071         (print_objfile_statistics, maintenance_print_objfiles)
14072         (maintenance_info_symtabs, maintenance_check_symtabs)
14073         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
14074         all_objfiles.
14075         * source.c (forget_cached_source_info): Use all_objfiles.
14076         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
14077         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
14078         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
14079         * objfiles.c (update_section_map): Use all_objfiles.
14080         (shared_objfile_contains_address_p): Likewise.
14081         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
14082         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
14083
14084 2019-01-09  Tom Tromey  <tom@tromey.com>
14085
14086         * common/next-iterator.h: New file.
14087         * objfiles.h (class all_objfiles): New.
14088         (struct objfile_iterator): New.
14089
14090 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14091
14092         * NEWS: Move the description of the changed "frame", "select-frame",
14093          and "info frame" commands to the Changed commands section.
14094
14095 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
14096
14097         * gdbtypes.c (check_stub_method_group): Remove handling of old
14098         mangling schemes.
14099         * linespec.c (find_methods): Likewise.
14100         * stabsread.c (read_member_functions): Likewise.
14101         * valops.c (search_struct_method): Likewise.
14102         (value_struct_elt_for_reference): Likewise.
14103         * NEWS: Mention this change.
14104
14105 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
14106
14107         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
14108         print_source_lines.
14109         * source.c (print_source_lines_base): Update line number check.
14110         (print_source_lines): New function.
14111         (source_lines_range::source_lines_range): New function.
14112         * source.h (class source_lines_range): New class.
14113         (print_source_lines): New declaration.
14114
14115 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14116
14117         * linespec.c (linespec_state_destructor): Free self->canonical_names.
14118
14119 2019-01-08  Tom Tromey  <tom@tromey.com>
14120             Simon Marchi  <simon.marchi@ericsson.com>
14121
14122         PR gdb/24060
14123         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
14124         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
14125         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
14126         * f-exp.y (DOLLAR_VARIABLE): Likewise.
14127         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
14128         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
14129
14130 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
14131
14132         * source.c (select_source_symtab): Move header comment to
14133         declaration in source.h.
14134         (forget_cached_source_info_for_objfile): Likewise.
14135         (forget_cached_source_info): Likewise.
14136         (identify_source_line): Likewise.
14137         * source.h (identify_source_line): Move declaration from symtab.h
14138         and add comment from source.c
14139         (print_source_lines): Likewise.
14140         (forget_cached_source_info_for_objfile): Likewise.
14141         (forget_cached_source_info): Likewise.
14142         (select_source_symtab): Likewise.
14143         (enum print_source_lines_flag): Move definition from symtab.h.
14144         * symtab.h (identify_source_line): Move declaration to source.h.
14145         (print_source_lines): Likewise.
14146         (forget_cached_source_info_for_objfile): Likewise.
14147         (forget_cached_source_info): Likewise.
14148         (select_source_symtab): Likewise.
14149         (enum print_source_lines_flag): Move definition to source.h.
14150         * tui/tui-hooks.c: Add 'source.h' include.
14151
14152 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
14153
14154         * source.c (print_source_lines_base): Handle requests to print
14155         reverse line number sequences, and guard against empty lines
14156         string.
14157
14158 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
14159
14160         * source.c (print_source_lines_base): Fix skip of '\r' if next
14161         character is '\n'.
14162
14163 2019-01-06  Tom Tromey  <tom@tromey.com>
14164
14165         * c-exp.y (struct c_parse_state) <macro_original_text,
14166         expansion_obstack>: New member.
14167         (macro_original_text, expansion_obstack): Remove globals.
14168         (scan_macro_expansion, scanning_macro_expansion)
14169         (finished_macro_expansion): Update.
14170         (scan_macro_cleanup): Remove.
14171         (yylex, c_parse): Update.
14172
14173 2019-01-06  Tom Tromey  <tom@tromey.com>
14174
14175         * c-exp.y (struct c_parse_state) <strings>: New member.
14176         (operator_stoken): Update.
14177
14178 2019-01-06  Tom Tromey  <tom@tromey.com>
14179
14180         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
14181         (union type_stack_elt) <typelist_val>: Now a pointer to
14182         std::vector.
14183         (type_stack_cleanup): Don't declare.
14184         (push_typelist): Update.
14185         * parse.c (pop_typelist): Return a std::vector.
14186         (push_typelist): Take a std::vector.
14187         (follow_types): Update.  Do not free args.
14188         (type_stack_cleanup): Remove.
14189         * c-exp.y (struct c_parse_state): New.
14190         (cpstate): New global.
14191         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
14192         (nonempty_typelist): Update.
14193         (func_mod): Create a new vector.
14194         (c_parse): Create a c_parse_state.
14195         (check_parameter_typelist): Do not delete params.
14196         (function_method): Update.  Do not delete type_list.
14197
14198 2019-01-06  Tom Tromey  <tom@tromey.com>
14199
14200         PR gdb/28155:
14201         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
14202         check_typedef.
14203         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
14204         (print_return_value): Likewise.
14205
14206 2019-01-05  Tom Tromey  <tom@tromey.com>
14207
14208         * contrib/cleanup_check.py: Remove.
14209         * contrib/gcc-with-excheck: Remove.
14210         * contrib/exsummary.py: Remove.
14211         * contrib/excheck.py: Remove.
14212
14213 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
14214
14215         * thread.c (delete_thread_1): Add gdb_assert that THR is not
14216         NULL. Initialize tpprev to NULL instead of assigning it
14217         to NULL on the next statement.
14218         * windows-nat.c (windows_delete_thread): Remove check for
14219         main_thread_id before printing thread exit notifications.
14220         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
14221         Remove thread ID check against main_thread_id.
14222         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
14223         windows_delete_thread.
14224         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
14225
14226 2019-01-04  Tom Tromey  <tom@tromey.com>
14227
14228         * compile/compile.c (_initialize_compile): Use upper case for
14229         metasyntactic variables.
14230         * symmisc.c (_initialize_symmisc): Use upper case for
14231         metasyntactic variables.
14232         * psymtab.c (_initialize_psymtab): Use upper case for
14233         metasyntactic variables.
14234         * demangle.c (demangle_command): Use upper case for metasyntactic
14235         variables.
14236         (_initialize_demangler): Likewise.
14237         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
14238         variables.
14239
14240 2019-01-03  Tom Tromey  <tom@tromey.com>
14241
14242         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
14243
14244 2019-01-03  Tom Tromey  <tom@tromey.com>
14245
14246         * python/py-symtab.c (salpy_str): Update.
14247         (struct salpy_sal_object) <symtab>: Now a PyObject.
14248         (salpy_dealloc): Update.
14249         (del_objfile_sal): Use gdbpy_ref.
14250
14251 2019-01-03  Tom Tromey  <tom@tromey.com>
14252
14253         * python/py-type.c (convert_field): Use new_reference.  Return
14254         gdbpy_ref.
14255         (make_fielditem): Return gdbpy_ref.
14256         (typy_fields): Update.
14257         (typy_getitem): Update.
14258         (field_name): Return gdbpy_ref.  Use new_reference.
14259         (typy_iterator_iternext): Update.
14260
14261 2019-01-03  Tom Tromey  <tom@tromey.com>
14262
14263         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
14264
14265 2019-01-03  Tom Tromey  <tom@tromey.com>
14266
14267         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
14268         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
14269         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
14270         (pspy_set_frame_filters, pspy_set_frame_unwinders)
14271         (pspy_set_type_printers): Likewise.
14272         * python/py-function.c (fnpy_init): Use gdbpy_ref.
14273         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
14274         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
14275         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
14276         (objfpy_set_type_printers): Likewise.
14277
14278 2019-01-03  Tom Tromey  <tom@tromey.com>
14279
14280         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
14281         (gdbpy_print_stack): Use gdbpy_err_fetch.
14282         * python/python-internal.h (class gdbpy_err_fetch): New class.
14283         (class gdbpy_enter) <m_error_type, m_error_value,
14284         m_error_traceback>: Remove.
14285         <m_error>: New member.
14286         (gdbpy_exception_to_string): Don't declare.
14287         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
14288         * python/py-value.c (convert_value_from_python): Use
14289         gdbpy_err_fetch.
14290         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
14291         gdbpy_exception_to_string.
14292         (gdbpy_handle_exception): Use gdbpy_err_fetch.
14293         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
14294         gdbpy_err_fetch.
14295
14296 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
14297
14298         * linux-nat.c (delete_lwp_cleanup): Delete.
14299         (struct lwp_deleter): New struct.
14300         (lwp_info_up): New typedef.
14301         (linux_nat_target::follow_fork): Delete cleanup, and make use of
14302         lwp_info_up.
14303
14304 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
14305
14306         * linux-fork.c (class scoped_switch_fork_info): New class.
14307         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
14308
14309 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
14310
14311         * valops.c (find_overload_match): Remove use of null_cleanup, and
14312         calls to do_cleanups.
14313
14314 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
14315
14316         * compile/compile-cplus-types.c
14317         (compile_cplus_instance::decl_name): Handle changes to
14318         cp_func_name.
14319         * cp-support.c (cp_func_name): Update header comment, update
14320         return type.
14321         * cp-support.h (cp_func_name): Update return type in declaration.
14322         * valops.c (find_overload_match): Move temp_func local to top
14323         level of function and change its type.  Use temp_func to hold and
14324         delete temporary string obtained from cp_func_name.
14325
14326 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
14327
14328         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
14329         gdb::char_vector, remove cleanup, and update uses of `msg`.
14330
14331 2019-01-03  Jim Wilson  <jimw@sifive.com>
14332
14333         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
14334
14335 2019-01-02  Tom Tromey  <tom@tromey.com>
14336
14337         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
14338         (tdesc_parse_xml): Remove cleanups.
14339         * target-descriptions.h (make_cleanup_free_target_description):
14340         Don't declare.
14341         (target_desc_deleter): New struct.
14342         (target_desc_up): New typedef.
14343         * target-descriptions.c (target_desc_deleter::operator()): Rename
14344         from free_target_description.
14345         (make_cleanup_free_target_description): Remove.
14346
14347 2019-01-02  Tom Tromey  <tom@tromey.com>
14348
14349         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
14350         constructor, destructor.
14351         (linespec_parser): Remove typedef.
14352         (~linespec_parser): Rename from linespec_parser_delete.
14353         (linespec_lex_to_end, linespec_complete_label)
14354         (linespec_complete): Update.
14355         (decode_line_full): Remove cleanups.
14356         (decode_line_1): Update.
14357
14358 2019-01-02  Tom Tromey  <tom@tromey.com>
14359
14360         * python/python-internal.h (inferior_to_inferior_object): Change
14361         return type.
14362         * python/py-exitedevent.c (create_exited_event_object): Update.
14363         * python/py-inferior.c (inferior_to_inferior_object): Return
14364         gdbpy_ref.
14365         (python_new_inferior, python_inferior_deleted)
14366         (thread_to_thread_object, delete_thread_object)
14367         (build_inferior_list, gdbpy_selected_inferior): Update.
14368         * python/py-infthread.c (create_thread_object): Update.  Also fail
14369         if inferior_to_inferior_object fails.
14370
14371 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
14372
14373         * inferior.h (class inferior) <displaced_step_state>: New field.
14374         * infrun.h (struct displaced_step_state): Move here from
14375         infrun.c.  Initialize fields, add constructor.
14376         <inf>: Remove field.
14377         <reset>: New method.
14378         * infrun.c (struct displaced_step_inferior_state): Move to
14379         infrun.h.
14380         (displaced_step_inferior_states): Remove.
14381         (get_displaced_stepping_state): Adust.
14382         (displaced_step_in_progress_any_inferior): Adjust.
14383         (displaced_step_in_progress_thread): Adjust.
14384         (displaced_step_in_progress): Adjust.
14385         (add_displaced_stepping_state): Remove.
14386         (get_displaced_step_closure_by_addr): Adjust.
14387         (remove_displaced_stepping_state): Remove.
14388         (infrun_inferior_exit): Call displaced_step_state.reset.
14389         (use_displaced_stepping): Don't check for NULL.
14390         (displaced_step_prepare_throw): Call
14391         get_displaced_stepping_state.
14392         (displaced_step_fixup): Don't check for NULL.
14393         (prepare_for_detach): Don't check for NULL.
14394
14395 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14396
14397         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
14398          in case of call that did not complete.
14399
14400 2019-01-02  Andrey Utkin  <autkin@undo.io>
14401
14402         * symfile.c (find_separate_debug_file): Fix search of debug files for
14403         remote debuggee.
14404
14405 2019-01-02  Tom Tromey  <tom@tromey.com>
14406
14407         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
14408         indentation.
14409         * python/py-frame.c (frapy_older): Remove cast.
14410         (frapy_newer): Likewise.
14411         * python/py-breakpoint.c (local_setattro): Remove cast.
14412         * python/py-arch.c (archpy_name): Remove local variable.
14413         * python/py-type.c (gdbpy_lookup_type): Remove cast.
14414
14415 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
14416
14417         * unittests/basic_string_view/element_access/char/empty.cc:
14418         Fix year range in copyright header.
14419
14420 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
14421
14422         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
14423         Delete.
14424         <operator==>: Update with for removed field.
14425         <hash>: Likewise.
14426         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
14427         <isa_features>: ...this.
14428         <abi_features>: New field.
14429         (riscv_isa_flen): Update comment.
14430         (riscv_abi_xlen): New declaration.
14431         (riscv_abi_flen): New declaration.
14432         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
14433         isa_features.
14434         (riscv_abi_xlen): New function.
14435         (riscv_isa_flen): Update to get answer from isa_features.
14436         (riscv_abi_flen): New function.
14437         (riscv_has_fp_abi): Update to get answer from abi_features.
14438         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
14439         xlen and flen.
14440         (riscv_call_info) <xlen, flen>: Update comment.
14441         (riscv_call_arg_struct): Remove invalid assertions
14442         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
14443         is removed.
14444         (riscv_gdbarch_init): Gather isa features and abi features
14445         separately, ensure both match on the gdbarch when reusing an old
14446         gdbarch.  Relax an error check to allow 32-bit abi float to run on
14447         a target with 64-bit float hardware.
14448
14449 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14450
14451         * source.c (search_command_helper): Stop reverse search
14452         when line 1 has been searched.
14453
14454 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14455
14456         * record-full.c (record_full_base_target::close): Rewrite
14457         record_full_core_buf_list free logic.
14458
14459 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14460
14461         * break-catch-syscall.c (print_one_catch_syscall): xfree
14462         the last text.
14463
14464 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
14465
14466         * top.c (print_gdb_version): Update Copyright year in version
14467         message.
14468
14469 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
14470
14471         Update copyright year range in all GDB files.
14472
14473 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
14474
14475         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
14476
14477 For older changes see ChangeLog-2018.
14478 \f
14479 Local Variables:
14480 mode: change-log
14481 left-margin: 8
14482 fill-column: 74
14483 version-control: never
14484 coding: utf-8
14485 End:
14486