gdb/ChangeLog

   1 2019-12-20  Tom Tromey  <tom@tromey.com>
   2
   3         * tui/tui-winsource.c (tui_source_window_base::refill): Use
   4         start_line_or_addr.
   5         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Use
   6         start_line_or_addr.
   7         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
   8         start_line_or_addr.
   9
  10 2019-12-20  Tom Tromey  <tom@tromey.com>
  11
  12         * tui/tui-winsource.h (struct tui_source_window_base)
  13         <set_contents>: Return bool.
  14         * tui/tui-winsource.c
  15         (tui_source_window_base::update_source_window_as_is): Update.
  16         * tui/tui-source.h (struct tui_source_window) <set_contents>:
  17         Return bool.
  18         * tui/tui-source.c (tui_source_window::set_contents): Return
  19         bool.  Simplify.
  20         * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
  21         Return bool.
  22         * tui/tui-disasm.c (tui_disasm_window::set_contents): Return
  23         bool.
  24
  25 2019-12-20  Tom Tromey  <tom@tromey.com>
  26
  27         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
  28         (tui_update_source_windows_with_line): Call update_source_window.
  29         * tui/tui-source.h (struct tui_source_window)
  30         <show_symtab_source>: Don't declare.
  31         * tui/tui-source.c (tui_source_window::show_symtab_source):
  32         Remove.
  33
  34 2019-12-20  Tom Tromey  <tom@tromey.com>
  35
  36         * tui/tui-winsource.c (tui_update_source_windows_with_addr): Call
  37         update_source_window directly.
  38         * tui/tui-disasm.h (tui_show_disassem): Don't declare.
  39         * tui/tui-disasm.c (tui_show_disassem): Remove.
  40
  41 2019-12-20  Tom Tromey  <tom@tromey.com>
  42
  43         * tui/tui-winsource.c
  44         (tui_source_window_base::update_source_window_as_is): Don't switch focus.
  45         * tui/tui-disasm.c (tui_show_disassem): Don't switch focus.
  46
  47 2019-12-20  Tom Tromey  <tom@tromey.com>
  48
  49         * tui/tui-winsource.h (struct tui_source_window_base)
  50         <maybe_update>: Remove line_no and addr parameters.
  51         * tui/tui-stack.c (tui_show_frame_info): Set PC on sal.  Update.
  52         * tui/tui-source.h (struct tui_source_window) <maybe_update>:
  53         Update.
  54         * tui/tui-source.c (tui_source_window::maybe_update): Remove
  55         line_no and addr parameters.
  56         * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
  57         Update.
  58         * tui/tui-disasm.c (tui_disasm_window::maybe_update): Remove
  59         line_no and addr parameters.
  60
  61 2019-12-20  Tom Tromey  <tom@tromey.com>
  62
  63         * tui/tui-winsource.c (tui_source_window_base::set_is_exec_point_at)
  64         (tui_source_window_base::update_breakpoint_info): Remove asserts.
  65
  66 2019-12-20  Tom Tromey  <tom@tromey.com>
  67
  68         * tui/tui-winsource.c (tui_update_source_windows_with_addr): Call
  69         tui_show_disassem.
  70         * tui/tui-disasm.h (tui_show_disassem_and_update_source): Don't
  71         declare.
  72         * tui/tui-disasm.c (tui_show_disassem_and_update_source): Remove.
  73
  74 2019-12-20  Tom Tromey  <tom@tromey.com>
  75
  76         * tui/tui.h (tui_show_source): Remove parameters.
  77         * tui/tui.c (tui_show_source): Remove parameters.
  78         * tui/tui-out.c (tui_ui_out::do_field_string): Update.
  79
  80 2019-12-20  Tom Tromey  <tom@tromey.com>
  81
  82         * tui/tui.c (tui_show_source): Update.
  83         * tui/tui-winsource.c (tui_display_main): Update.
  84         * tui/tui-stack.h (tui_update_locator_fullname): Change parameter
  85         to symtab.
  86         * tui/tui-stack.c (tui_update_locator_fullname): Change parameter
  87         to symtab.
  88         * tui/tui-disasm.c (tui_show_disassem_and_update_source): Update.
  89
  90 2019-12-20  Tom Tromey  <tom@tromey.com>
  91
  92         PR tui/23619:
  93         * tui/tui-io.c (tui_rl_saved_prompt): Remove.
  94         (tui_redisplay_readline): Use rl_display_prompt.
  95         (tui_prep_terminal): Update.
  96
  97 2019-12-19  Christian Biesinger  <cbiesinger@google.com>
  98
  99         * configure: Regenerate.
 100         * configure.ac: Quote variable arguments of test.
 101         * gdbsupport/common.m4: Likewise.
 102
 103 2019-12-19  Christian Biesinger  <cbiesinger@google.com>
 104
 105         * score-tdep.c (score7_analyze_prologue): Pass 2.0 instead of
 106         2 to pow ().
 107
 108 2019-12-19  Christian Biesinger  <cbiesinger@google.com>
 109
 110         * tui/tui-source.c (tui_source_window::set_contents): Cast argument of
 111         log10 to double to fix Solaris 11 with gcc 5.5.
 112
 113 2019-12-19  Christian Biesinger  <cbiesinger@google.com>
 114
 115         * fbsd-tdep.c (fbsd_info_proc_files_entry): Rename local var
 116         "sun" to "saddr_un".
 117
 118 2019-12-19  Tom Tromey  <tromey@adacore.com>
 119
 120         * ui-out.h (enum class field_kind): Fix comment.
 121
 122 2019-12-11  Tom Tromey  <tromey@adacore.com>
 123
 124         * xml-support.c (xml_fetch_content_from_file): Use FOPEN_RB.
 125
 126 2019-12-18  Tom Tromey  <tromey@adacore.com>
 127
 128         PR build/25268:
 129         * gdbsupport/thread-pool.c (set_thread_name): Expect "int" return
 130         type on macOS.  Add comment.
 131
 132 2019-12-18  Simon Marchi  <simon.marchi@efficios.com>
 133
 134         * c-lang.c (c_get_string, asm_language_defn): Remove space
 135         before tab.
 136
 137 2019-12-18  Tom Tromey  <tromey@adacore.com>
 138
 139         PR build/25250:
 140         * ui-out.c (ui_out::vmessage): Update.
 141         * ui-out.h (enum class field_kind) <FIELD_STRING, FIELD_SIGNED>:
 142         Rename.
 143         (string_field): Update.
 144         (signed_field): Update.
 145
 146 2019-12-18  Simon Marchi  <simon.marchi@efficios.com>
 147
 148         * top.c (print_gdb_configuration): Adjust indentation.
 149
 150 2019-12-17  Christian Biesinger  <cbiesinger@google.com>
 151
 152         * bsd-kvm.c: Include gdbsupport/pathstuff.h.
 153
 154 2019-12-17  Simon Marchi  <simon.marchi@polymtl.ca>
 155
 156         * tui/tui-layout.h (class tui_layout_base): Add virtual
 157         destructor.
 158
 159 2019-12-16  Bernd Edlinger  <bernd.edlinger@hotmail.de>
 160
 161         * infcmd.c (prepare_one_step): Step over skipped inline functions.
 162         * infrun.c (inline_frame_is_marked_for_skip): New helper function.
 163         (process_event_stop_test): Keep stepping over skipped inline functions.
 164
 165 2019-12-16  Simon Marchi  <simon.marchi@polymtl.ca>
 166
 167         * jit.c (struct gdb_block) <next>: Remove field.
 168         (struct gdb_symtab) <~gdb_symtab>: Remove.
 169         <blocks>: Change type to std::forward_list<gdb_block>.
 170         (compare_block): Remove.
 171         (jit_block_open_impl): Adjust to std::forward_list.  Place the new
 172         block at the beginning, don't mind about sorting.
 173         (finalize_symtab): Adjust to std::forward_list, sort the blocks list
 174         before using it.
 175
 176 2019-12-16  Simon Marchi  <simon.marchi@polymtl.ca>
 177
 178         * jit.c (struct gdb_block): Add constructor, initialize
 179         real_block and next fields.
 180         <name>: Change type to gdb::unique_xmalloc_ptr.
 181         (struct gdb_symtab) <~gdb_symtab>: Free blocks with delete.
 182         (jit_block_open_impl): Allocate gdb_block with new.
 183         (finalize_symtab): Adjust to gdb::unique_xmalloc_ptr.
 184
 185 2019-12-16  Simon Marchi  <simon.marchi@polymtl.ca>
 186
 187         * jit.c: Include forward_list.
 188         (struct gdb_symtab) <next>: Remove field.
 189         (struct gdb_object) <symtabs>: Change type to
 190         std::forward_list<gdb_symtab>.
 191         (jit_object_open_impl): Allocate gdb_object with new.
 192         (jit_symtab_open_impl): Adjust to std::forward_list.
 193         (finalize_symtab): Don't delete symtab.
 194         (jit_object_close_impl):  Adjust to std::forward_list.  Free
 195         gdb_object with delete.
 196
 197 2019-12-16  Simon Marchi  <simon.marchi@polymtl.ca>
 198
 199         * jit.c (struct gdb_symtab): Add constructor, destructor,
 200         initialize fields.
 201         <linetable>: Change type to unique_xmalloc_ptr.
 202         <file_name>: Change type to std::string.
 203         (jit_symtab_open_impl): Allocate gdb_symtab with new.
 204         (jit_symtab_line_mapping_add_impl): Adjust.
 205         (finalize_symtab): Adjust, call delete on stab.
 206
 207 2019-12-16  Simon Marchi  <simon.marchi@polymtl.ca>
 208
 209         * jit.c (finalize_symtab): Set gdb_block_iter_tmp in loop.
 210
 211 2019-12-16  Tom Tromey  <tromey@adacore.com>
 212
 213         * windows-nat.c (windows_nat_target::attach): Update.
 214         * remote.c (extended_remote_target::attach): Update.
 215         * procfs.c (procfs_target::attach): Update.
 216         * nto-procfs.c (nto_procfs_target::attach): Update.
 217         (nto_procfs_target::create_inferior): Update.
 218         * inf-ptrace.c (inf_ptrace_target::attach): Update.
 219         * gnu-nat.c (gnu_nat_target::attach): Update.
 220         (gnu_nat_target::detach): Update.
 221         * darwin-nat.c (darwin_nat_target::attach): Update.
 222         * corefile.c (get_exec_file): Constify result.  Remove extraneous
 223         return.
 224         * bsd-kvm.c (bsd_kvm_target_open): Update.
 225         * gdbsupport/common-inferior.h (get_exec_file): Constify result.
 226
 227 2019-12-16  Christian Biesinger  <cbiesinger@google.com>
 228
 229         * gdbsupport/common-defs.h: Remove workaround for a gnulib bug
 230         (we no longer need to include time.h before pathmax.h)
 231
 232 2019-12-15  Christian Biesinger  <cbiesinger@google.com>
 233
 234         * ada-exp.y (write_ambiguous_var): Update.
 235         * coffread.c (process_coff_symbol): Update.
 236         * ctfread.c (ctf_add_enum_member_cb): Update.
 237         (new_symbol): Update.
 238         * dwarf2read.c (fixup_go_packaging): Update.
 239         (new_symbol): Update.
 240         * language.c (language_alloc_type_symbol): Update.
 241         * mdebugread.c (new_symbol): Update.
 242         * minsyms.c (minimal_symbol_reader::record_full): Update.
 243         * psymtab.c (add_psymbol_to_bcache): Update.
 244         * stabsread.c (define_symbol): Update.
 245         (read_enum_type): Update.
 246         * symtab.c (symbol_set_language): Make this a member function...
 247         (general_symbol_info::set_language): ... here.
 248         * symtab.h (struct general_symbol_info) <set_language>: New function.
 249         (SYMBOL_SET_LANGUAGE): Remove.
 250         (symbol_set_language): Remove.
 251
 252 2019-12-15  Christian Biesinger  <cbiesinger@google.com>
 253
 254         * ada-lang.c (ada_add_block_symbols): Update.
 255         (ada_collect_symbol_completion_matches): Update.
 256         * ax-gdb.c (gen_expr): Update.
 257         * block.c (block_lookup_symbol): Update.
 258         (block_lookup_symbol_primary): Update.
 259         (block_find_symbol): Update.
 260         * cp-namespace.c (cp_lookup_symbol_imports_or_template): Update.
 261         * dbxread.c (process_one_symbol): Update.
 262         * dictionary.c (insert_symbol_hashed): Update.
 263         (collate_pending_symbols_by_language): Update.
 264         (mdict_add_symbol): Update.
 265         * dwarf-index-write.c (write_psymbols): Update.
 266         * dwarf2read.c (fixup_go_packaging): Update.
 267         * findvar.c (read_var_value): Update.
 268         * ft32-tdep.c (ft32_skip_prologue): Update.
 269         * go-lang.c (go_symbol_package_name): Update.
 270         * language.h (scoped_switch_to_sym_language_if_auto::
 271         scoped_switch_to_sym_language_if_auto): Update.
 272         * linespec.c (find_method): Update.
 273         (find_label_symbols_in_block): Update.
 274         * mdebugread.c (parse_symbol): Update.
 275         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
 276         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
 277         (minimal_symbol_reader::install): Update.
 278         * moxie-tdep.c (moxie_skip_prologue): Update.
 279         * parse.c (parse_exp_in_context): Update.
 280         * psymtab.c (psymbol_name_matches): Update.
 281         (match_partial_symbol): Update.
 282         (lookup_partial_symbol): Update.
 283         (psymbol_hash): Update.
 284         (psymbol_compare): Update.
 285         * python/py-framefilter.c (extract_sym): Update.
 286         (py_print_single_arg): Update.
 287         * stabsread.c (define_symbol): Update.
 288         * stack.c (print_frame_arg): Update.
 289         (find_frame_funname): Update.
 290         (info_frame_command_core): Update.
 291         * symfile.c (set_initial_language): Update.
 292         * symtab.c (symbol_set_demangled_name): Update.
 293         (symbol_get_demangled_name): Update.
 294         (symbol_set_language): Update.
 295         (symbol_find_demangled_name): Update.
 296         (symbol_set_names): Update.
 297         (general_symbol_info::natural_name): Update.
 298         (general_symbol_info::demangled_name): Update.
 299         (general_symbol_info::search_name): Update.
 300         (symbol_matches_search_name): Update.
 301         (eq_symbol_entry): Update.
 302         (iterate_over_symbols): Update.
 303         (completion_list_add_symbol): Update.
 304         (completion_list_add_msymbol): Update.
 305         (completion_list_add_fields): Update.
 306         * symtab.h (struct general_symbol_info) <language>: New function.
 307         <language>: Rename to...
 308         <m_language>: ...this.
 309         (SYMBOL_LANGUAGE): Remove.
 310         (MSYMBOL_LANGUAGE): Remove.
 311         (struct symbol) <ctor>: Update.
 312         * xstormy16-tdep.c (xstormy16_skip_prologue): Update.
 313
 314 2019-12-15  Christian Biesinger  <cbiesinger@google.com>
 315
 316         * ada-exp.y (write_ambiguous_var): Call symbol_set_language to
 317         set the language of sym.
 318         * language.c (language_alloc_type_symbol): Likewise.
 319
 320 2019-12-14  Sergio Durigan Junior  <sergiodj@redhat.com>
 321
 322         https://bugzilla.redhat.com/show_bug.cgi?id=1728147
 323         PR gdb/23613
 324         * bsd-kvm.c (bsd_kvm_target_open): Use 'gdb_abspath'.
 325         * corelow.c: Include 'gdbsupport/pathstuff.h'.
 326         (core_target_open): Use 'gdb_abspath'.
 327         * gdbsupport/pathstuff.c (gdb_abspath): Guard against
 328         'current_directory == NULL' case.
 329         * gdbsupport/pathstuff.h (gdb_abspath): Expand comment and
 330         explain what happens when 'current_directory' is NULL.
 331         * go32-nat.c (go32_nat_target::wait): Check if
 332         'current_directory' is NULL before call to 'chdir'.
 333         * source.c (add_path): Use 'gdb_abspath'.
 334         * top.c: Include 'gdbsupport/pathstuff.h'.
 335         (init_history): Use 'gdb_abspath'.
 336         (set_history_filename): Likewise.
 337         * tracefile-tfile.c: Include 'gdbsupport/pathstuff.h'.
 338         (tfile_target_open): Use 'gdb_abspath'.
 339
 340 2019-12-13  Tom Tromey  <tromey@adacore.com>
 341
 342         * contrib/ari/gdb_ari.sh: Remove check for multiple calls to
 343         warning or error.
 344
 345 2019-12-13  Tom Tromey  <tromey@adacore.com>
 346
 347         * contrib/ari/gdb_ari.sh: Remove call to "fix" for "long long".
 348
 349 2019-12-13  Tom Tromey  <tromey@adacore.com>
 350
 351         * contrib/ari/gdb_ari.sh: Handle -Wno- prefix.
 352
 353 2019-12-13  Tom Tromey  <tromey@adacore.com>
 354
 355         * contrib/ari/gdb_ari.sh (usage): Use GNU style.
 356
 357 2019-12-13  Tom Tromey  <tromey@adacore.com>
 358
 359         * gdbsupport/common-utils.c (string_printf, string_vprintf)
 360         (string_vappendf): Add ARI comment.
 361
 362 2019-12-13  Tom Tromey  <tromey@adacore.com>
 363
 364         * contrib/ari/gdb_ari.sh: Remove "fix" call for
 365         floatformat_to_double.
 366         * target-float.c (host_float_ops<T>::from_target): Add ARI
 367         comment.
 368
 369 2019-12-13  Tom Tromey  <tromey@adacore.com>
 370
 371         * contrib/ari/gdb_ari.sh: Remove "fix" call for abort.
 372         * utils.c (abort_with_message, dump_core, internal_vproblem): Add
 373         ARI marker to abort.
 374         * event-top.c (handle_sigsegv): Add ARI marker to abort.
 375
 376 2019-12-13  Tom Tromey  <tromey@adacore.com>
 377
 378         * contrib/ari/gdb_ari.sh: Fix floatformat_from_double text.
 379
 380 2019-12-13  Tom Tromey  <tromey@adacore.com>
 381
 382         * contrib/ari/gdb_ari.sh: Remove ATTRIBUTE_UNUSED check.
 383
 384 2019-12-13  Tom Tromey  <tromey@adacore.com>
 385
 386         * contrib/ari/gdb_ari.sh: Remove "boolean" and "var_boolean"
 387         checks.
 388
 389 2019-12-13  Tom Tromey  <tromey@adacore.com>
 390
 391         * gdbsupport/safe-iterator.h (class basic_safe_range) <begin,
 392         end>: No longer "const".
 393
 394 2019-12-13  Simon Marchi  <simon.marchi@polymtl.ca>
 395
 396         * jit.c: Fix indentation, replace spaces with tabs where
 397         applicable.
 398
 399 2019-12-13  Jozef Lawrynowicz  <jozef.l@mittosystems.com>
 400
 401         * configure.tgt: Match msp430-*-elf* targets when configuring GDB.
 402
 403 2019-12-12  Tom Tromey  <tom@tromey.com>
 404
 405         * objfiles.h (struct objfile) <partial_symtabs>: Now a
 406         unique_ptr.
 407
 408 2019-12-12  Tom Tromey  <tom@tromey.com>
 409
 410         * progspace.h (objfile_list): New typedef.
 411         (class unwrapping_objfile_iterator)
 412         (struct unwrapping_objfile_range): Newl
 413         (struct program_space) <objfiles_range>: Change type.
 414         <objfiles>: Change return type.
 415         <add_objfile>: Change type of "objfile" parameter.
 416         <objfiles_list>: Now a list of shared_ptr.
 417         * progspace.c (program_space::add_objfile): Change type of
 418         "objfile".  Update.
 419         (program_space::remove_objfile): Update.
 420         * objfiles.h (struct objfile) <~objfile>: Make public.
 421         * objfiles.c (objfile::make): Update.
 422         (objfile::unlink): Don't call delete.
 423
 424 2019-12-12  Tom Tromey  <tom@tromey.com>
 425
 426         * symfile.c (symbol_file_clear): Update.
 427         * progspace.h (struct program_space) <free_all_objfiles>: Declare
 428         method.
 429         * progspace.c (program_space::free_all_objfiles): New method.
 430         * objfiles.h (free_all_objfiles): Don't declare.
 431         * objfiles.c (free_all_objfiles): Move to program_space.
 432
 433 2019-12-12  Tom Tromey  <tom@tromey.com>
 434
 435         * progspace.c (program_space::add_objfile)
 436         (program_space::remove_objfile): Update.
 437         (program_space::multi_objfile_p): Remove.
 438         * objfiles.h (struct objfile) <next>: Remove.
 439         * objfiles.c (objfile::objfile): Update.
 440         (put_objfile_before): Update.
 441         (unlink_objfile): Update.
 442         * progspace.h (object_files): Remove.
 443         (struct program_space) <objfiles_head>: Remove.
 444         <objfiles_list>: New member.
 445         <objfiles_range, objfiles_safe_range>: Change type.
 446         (objfiles): Change return type.
 447         (objfiles_safe): Update.
 448         (multi_objfile_p): Rewrite and inline.
 449         (object_files): Remove macro.
 450
 451 2019-12-12  Tom Tromey  <tom@tromey.com>
 452
 453         * gdbsupport/safe-iterator.h (basic_safe_iterator): Simplify.  Add
 454         second constructor.
 455         (basic_safe_range): New class.
 456
 457 2019-12-12  Tom Tromey  <tom@tromey.com>
 458
 459         * progspace.c (program_space::multi_objfile_p): New method.
 460         * printcmd.c (info_symbol_command): Update.
 461         * maint.c (maintenance_translate_address): Update.
 462         * objfiles.h (MULTI_OBJFILE_P): Remove.
 463         * progspace.h (struct program_space) <multi_objfile_p>: New
 464         method.
 465
 466 2019-12-12  Tom Tromey  <tom@tromey.com>
 467
 468         * progspace.h (struct program_space) <remove_objfile>: Declare.
 469         * progspace.c (program_space::remove_objfile): New method.
 470         * objfiles.c (unlink_objfile): Remove.
 471         (objfile::unlink): Call remove_objfile.
 472         (objfile): Don't call unlink_objfile.
 473
 474 2019-12-12  Tom Tromey  <tom@tromey.com>
 475
 476         * progspace.h (struct program_space) <add_objfile>: Declare
 477         method.
 478         * progspace.c (program_space::add_objfile): New method.
 479         * objfiles.c (~objfile): Don't unlink objfile.
 480         (put_objfile_before): Remove.
 481         (add_separate_debug_objfile): Don't call put_objfile_before.
 482         (objfile::make): Call add_objfile.  Set new_objfiles_available on
 483         the per-program-space data.
 484
 485 2019-12-12  Tom Tromey  <tom@tromey.com>
 486
 487         * symfile.c (syms_from_objfile_1): Use objfile_up.
 488         (syms_from_objfile_1, remove_symbol_file_command): Call unlink
 489         method.
 490         (reread_symbols): Use objfile_up.
 491         * solib.c (update_solib_list, reload_shared_libraries_1): Call
 492         unlink method.
 493         * objfiles.h (struct objfile) <~objfile>: Now private.
 494         <unlink>: New method.
 495         (struct objfile_deleter): New.
 496         (objfile_up): New typedef.
 497         * objfiles.c (objfile::unlink): New method.
 498         (free_objfile_separate_debug, free_all_objfiles)
 499         (objfile_purge_solibs): Use it.
 500         * jit.c (jit_unregister_code): Remove.
 501         (jit_inferior_exit_hook, jit_event_handler): Call unlink on
 502         objfile.
 503         * compile/compile-object-run.c (do_module_cleanup): Call unlink on
 504         objfile.
 505         * compile/compile-object-load.c (compile_object_load): Use
 506         objfile_up.
 507
 508 2019-12-12  Tom Tromey  <tom@tromey.com>
 509
 510         * symfile.c (symbol_file_add_with_addrs): Pass "parent" to
 511         objfile::make.
 512         * objfiles.h (struct objjfile) <make>: No longer inline.
 513         (add_separate_debug_objfile): Don't declare.
 514         * objfiles.c (add_separate_debug_objfile): Now static.
 515         (objfile::make): Move from objfiles.h.  Call
 516         add_separate_debug_objfile.  Add "parent" parameter.
 517
 518 2019-12-12  Tom Tromey  <tom@tromey.com>
 519
 520         * symfile.c (symbol_file_add_with_addrs): Use objfile::make.
 521         * objfiles.h (struct objfile): Make constructor private.
 522         <make>: New static method.
 523         * jit.c (jit_object_close_impl): Update.
 524
 525 2019-12-12  Simon Marchi  <simon.marchi@polymtl.ca>
 526
 527         * jit.c (jit_reader_try_read_symtab): Replace xmalloc/xfree with
 528         gdb::byte_vector.
 529
 530 2019-12-12  Tom Tromey  <tromey@adacore.com>
 531
 532         * xml-support.c (xml_fetch_content_from_file): Don't call
 533         malloc_failure.
 534         * utils.h (class gdb_argv): Remove malloc_failure comment.
 535         * utils.c (gdb_argv::reset): Don't call malloc_failure.
 536
 537 2019-12-12  Tom Tromey  <tromey@adacore.com>
 538
 539         * Makefile.in (ALL_TARGET_OBS): Add riscv-ravenscar-thread.o.
 540         (HFILES_NO_SRCDIR): Add riscv-ravenscar-thread.h.
 541         (ALLDEPFILES): Add riscv-ravenscar-thread.c.
 542         * configure.tgt (riscv-*-*): Add riscv-ravenscar-thread.o.
 543         * riscv-ravenscar-thread.c: New file.
 544         * riscv-ravenscar-thread.h: New file.
 545         * riscv-tdep.c (riscv_gdbarch_init): Call
 546         register_riscv_ravenscar_ops.
 547
 548 2019-12-12  Tom Tromey  <tromey@adacore.com>
 549
 550         * gdbsupport/thread-pool.c (set_thread_name): Use
 551         ATTRIBUTE_UNUSED.
 552
 553 2019-12-12  Luis Machado  <luis.machado@linaro.org>
 554
 555         * gdbsupport/safe-strerror.c: Don't include diagnostics.h.
 556         (select_strerror_r): Use ATTRIBUTE_UNUSED instead of the diagnostics
 557         macros.
 558
 559 2019-12-11  Tom Tromey  <tom@tromey.com>
 560
 561         * tui/tui-win.c (tui_set_win_height_command): Call
 562         tui_adjust_window_height.
 563         (tui_adjust_win_heights, new_height_ok): Remove.
 564         * tui/tui-layout.h (tui_adjust_window_height): Declare.
 565         * tui/tui-layout.c (tui_adjust_window_height): New function.
 566
 567 2019-12-11  Tom Tromey  <tom@tromey.com>
 568
 569         * tui/tui-win.c (tui_resize_all): Remove code, call
 570         tui_apply_current_layout.
 571
 572 2019-12-11  Tom Tromey  <tom@tromey.com>
 573
 574         * tui/tui-layout.h (tui_apply_current_layout): Declare.
 575         * tui/tui-layout.c (standard_layouts, applied_layout): New
 576         globals.
 577         (tui_apply_current_layout): New function.
 578         (show_layout): Set applied_layout.  Call
 579         tui_apply_current_layout.
 580         (show_source_command, show_disasm_command)
 581         (show_source_disasm_command, show_data)
 582         (show_source_or_disasm_and_command): Remove.
 583         (initialize_layouts): New function.
 584         (_initialize_tui_layout): Call initialize_layouts.
 585
 586 2019-12-11  Tom Tromey  <tom@tromey.com>
 587
 588         * tui/tui-layout.h (class tui_layout_base)
 589         (class tui_layout_window, class tui_layout_split): New.
 590         * tui/tui-layout.c (tui_get_window_by_name)
 591         (tui_layout_window::clone, tui_layout_window::apply)
 592         (tui_layout_window::get_sizes, tui_layout_window::add_split)
 593         (tui_layout_split::add_window, tui_layout_split::clone)
 594         (tui_layout_split::get_sizes)
 595         (tui_layout_split::set_weights_from_heights)
 596         (tui_layout_split::adjust_size, tui_layout_split::apply): New
 597         functions.
 598         (tui_layout_split::add_split, tui_layout_split::add_split)
 599         (tui_layout_split::set_weights_from_heights)
 600         (tui_layout_split::set_weights_from_heights): New functions.
 601
 602 2019-12-11  Tom Tromey  <tom@tromey.com>
 603
 604         * tui/tui-wingeneral.c (tui_gen_win_info::make_window): Update.
 605         * tui/tui-win.c (tui_adjust_win_heights, tui_resize_all): Update.
 606         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
 607         * tui/tui-data.h (struct tui_point): Remove.
 608         (struct tui_gen_win_info) <origin>: Remove.
 609         <x, y>: New fields.
 610         * tui/tui-command.c (tui_cmd_window::resize): Update.
 611
 612 2019-12-11  Tom Tromey  <tom@tromey.com>
 613
 614         * tui/tui-stack.h (struct tui_locator_window) <min_height>:
 615         Implement.
 616         * tui/tui-regs.h (struct tui_data_item_window) <min_height>:
 617         Implement.
 618         * tui/tui-data.h (struct tui_gen_win_info) <min_height>: New
 619         method.
 620         (struct tui_win_info) <min_height>: Implement.
 621
 622 2019-12-11  Tom Tromey  <tom@tromey.com>
 623
 624         * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
 625         (struct tui_win_info) <can_box>: Update.
 626
 627 2019-12-11  Tom Tromey  <tom@tromey.com>
 628
 629         * tui/tui-stack.h (struct tui_locator_window) <max_height>: New
 630         method.
 631         * tui/tui-regs.h (struct tui_data_item_window) <max_height>: New
 632         method.
 633         * tui/tui-data.h (struct tui_gen_win_info) <max_height>: New
 634         method.
 635         (struct tui_win_info) <max_height>: Now override.
 636
 637 2019-12-11  Joel Brobecker  <brobecker@adacore.com>
 638
 639         * NEWS: Create a new section for the next release branch.
 640         Rename the section of the current branch, now that it has
 641         been cut.
 642
 643 2019-12-11  Joel Brobecker  <brobecker@adacore.com>
 644
 645         GDB 9 branch created (27f7b2f64062ac9e52afc60509263c2702a9ebd0):
 646         * version.in: Bump version to 10.0.50.DATE-git.
 647
 648 2019-12-11  Tom Tromey  <tromey@adacore.com>
 649
 650         PR build/25268:
 651         * gdbsupport/thread-pool.c (set_thread_name): New function.
 652         (thread_pool::set_thread_count): Don't call pthread_setname_np.
 653         (thread_pool::thread_function): Call set_thread_name.
 654
 655 2019-12-11  Tom Tromey  <tromey@adacore.com>
 656
 657         * fbsd-tdep.c (fbsd_core_info_proc_status): Cast result of
 658         bfd_get_signed_8.
 659
 660 2019-12-11  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 661
 662         * NEWS: Document -raw-values option and the related setting commands.
 663         * printcmd.c (print_command_parse_format): Do not set opts->raw off,
 664         only set it on when /r is given.
 665         * valprint.c (value_print_option_defs): New element raw-values.
 666         * Makefile.in: Add the new file.
 667
 668 2019-12-10  Christian Biesinger  <cbiesinger@google.com>
 669
 670         * gdbsupport/safe-strerror.c: Supress the unused function warning
 671         for select_strerror_r.
 672
 673 2019-12-10  Christian Biesinger  <cbiesinger@google.com>
 674
 675         * config.in: Regenerate.
 676         * configure: Regenerate.
 677         * gdbsupport/agent.c (gdb_connect_sync_socket): Call
 678         safe_strerror instead of strerror.
 679         * gdbsupport/common.m4: Don't check for strerror.
 680         * gdbsupport/safe-strerror.c: Support both the glibc version
 681         of strerror_r and the XSI version.
 682
 683 2019-12-10  Tom Tromey  <tromey@adacore.com>
 684
 685         * ada-typeprint.c (print_choices): Use a single "?".
 686         (print_variant_part): Print "?" if the discriminant name
 687         is not known.
 688
 689 2019-12-10  George Barrett  <bob@bob131.so>
 690
 691         Fix scripted probe breakpoints.
 692         * breakpoint.c (tracepoint_probe_breakpoint_ops): Move
 693         declaration forward.
 694         (breakpoint_ops_for_event_location_type)
 695         (breakpoint_ops_for_event_location): Add function definitions.
 696         (break_command_1, trace_command): Use
 697         breakpoint_ops_for_event_location.
 698         * breakpoint.h (breakpoint_ops_for_event_location): Add function
 699         declarations.
 700         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Use
 701         breakpoint_ops_for_event_location.
 702         * python/py-breakpoint.c (bppy_init): Use
 703         breakpoint_ops_for_event_location.
 704
 705 2019-12-09  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 706
 707         * gdbtypes.c (rank_one_type): Return INCOMPATIBLE_TYPE_BADNESS
 708         when ranking an lvalue argument for an rvalue parameter.
 709
 710 2019-12-08  Wataru Ashihara  <wataash@wataash.com>
 711
 712         * darwin-nat.c (darwin_nat_target::create_inferior): Fix
 713         template argument for scoped_restore_tmpl from bool to int.
 714
 715 2019-12-07  Keith Seitz  <keiths@redhat.com>
 716
 717         * build-id.c (build_id_bfd_get): Permit bfd_core, too.
 718         (build_id_to_debug_bfd): Make static, rewriting to use
 719         build_id_to_bfd_suffix.
 720         (build_id_to_bfd_suffix): Copy of build_id_to_debug_bfd,
 721         adding `suffix' parameter. Append SUFFIX to file names
 722         when searching for matching files.
 723         (build_id_to_debug_bfd): Use build_id_to_bfd_suffix.
 724         (build_id_to_exec_bfd): Likewise.
 725         * build-id.h (build_id_to_debug_bfd): Clarify that function
 726         searches for BFD of debug info file.
 727         (build_id_to_exec_bfd): Declare.
 728         * corelow.c: Include build-id.h.
 729         (locate_exec_from_corefile_build_id): New function.
 730         (core_target_open): If no executable BFD is found,
 731         search for a core file BFD using build-id.
 732
 733 2019-12-06  Christian Biesinger  <cbiesinger@google.com>
 734
 735         * bcache.c: Put in namespace gdb.
 736         * bcache.h: Likewise.
 737         * gdbtypes.c (check_types_worklist): Update.
 738         (types_deeply_equal): Update.
 739         * macrotab.c (struct macro_table) <bcache>: Update.
 740         (new_macro_table): Update.
 741         * macrotab.h (struct bcache): Put this forward declaration
 742         inside namespace gdb.
 743         (new_macro_table): Update.
 744         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache>:
 745         Update.
 746         <macro_cache>: Update.
 747         * psymtab.h: (psymtab_storage) <psymbol_cache>: Update.
 748
 749 2019-12-06  Tom de Vries  <tdevries@suse.de>
 750
 751         PR symtab/24971
 752         * block.c (best_symbol, better_symbol): New function.
 753         (block_lookup_symbol_primary, block_lookup_symbol): Prefer def over
 754         decl.
 755
 756 2019-12-06  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 757
 758         * gdbtypes.h: Define the REFERENCE_SEE_THROUGH_BADNESS value.
 759         * gdbtypes.c (rank_one_type): Use REFERENCE_SEE_THROUGH_BADNESS
 760         for ranking see-through reference cases.
 761
 762 2019-12-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 763         * stack.c (faas_command): Check a command is provided.
 764         * thread.c (taas_command, tfaas_command): Likewise.
 765
 766 2019-12-05  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 767         * inferior.c (prune_inferiors):  Only call delete_inferior,
 768         Do not modify the inferior list.
 769
 770 2019-12-05  Simon Marchi  <simon.marchi@polymtl.ca>
 771
 772         * c-exp.y: Update calls to lookup_typename,
 773         lookup_signed_typename and lookup_unsigned_typename.
 774         * c-lang.c (evaluate_subexp_c): Likewise.
 775         * cp-namespace.c (cp_lookup_symbol_imports_or_template):
 776         Likewise.
 777         * eval.c (binop_promote): Likewise.
 778         * gdbtypes.c (lookup_typename): Remove gdbarch parameter.
 779         (lookup_unsigned_typename): Likewise.
 780         (lookup_signed_typename): Likewise.
 781         * gdbtypes.h (lookup_unsigned_typename): Likewise.
 782         (lookup_signed_typename): Likewise.
 783         (lookup_typename): Likewise.
 784         * guile/scm-type.c (tyscm_lookup_typename): Update calls to
 785         lookup_typename, lookup_signed_typename,
 786         lookup_unsigned_typename.
 787         * m2-exp.y: Likewise.
 788         * printcmd.c (printf_wide_c_string): Likewise.
 789         (ui_printf): Likewise.
 790         * python/py-type.c (typy_lookup_typename): Likewise.
 791         * python/py-xmethods.c (python_xmethod_worker::invoke):
 792         Likewise.
 793         * rust-exp.y: Likewise.
 794
 795 2019-12-04  Christian Biesinger  <cbiesinger@google.com>
 796
 797         * configure.nat (obsd64): Add missing files x86-nat.o and
 798         nat/x86-dregs.o.
 799
 800 2019-12-04  Tom Tromey  <tom@tromey.com>
 801
 802         * valprint.c (val_print_string): Use metadata_style.
 803         * go-valprint.c (print_go_string): Use metadata style.
 804         * p-valprint.c (pascal_object_print_static_field): Use metadata
 805         style.
 806         * cp-valprint.c (cp_print_static_field): Use metadata style.
 807
 808 2019-12-04  Andrew Burgess  <andrew.burgess@embecosm.com>
 809             Chris January  <chris.january@arm.com>
 810
 811         * f-exp.y (COMPLEX_KEYWORD, SINGLE, DOUBLE, PRECISION): New
 812         tokens.
 813         (typebase): New patterns for complex, single/double precision, and
 814         single/double complex.
 815         (f77_keywords): Change token for complex keyword, and add single,
 816         double, and precision keywords.
 817
 818 2019-12-04  Simon Marchi  <simon.marchi@polymtl.ca>
 819
 820         * avr-tdep.c (_initialize_avr_tdep): Improve help of command
 821         "info io_registers".
 822
 823 2019-12-04  Simon Marchi  <simon.marchi@polymtl.ca>
 824
 825         * regcache.c (cooked_read_test): Initialize thread list of
 826         mock_inferior.
 827
 828 2019-12-04  Simon Marchi  <simon.marchi@polymtl.ca>
 829
 830         * aarch64-linux-tdep.c: Remove includes.
 831
 832 2019-12-04  Simon Marchi  <simon.marchi@polymtl.ca>
 833
 834         * aarch64-tdep.c: Remove includes.
 835
 836 2019-12-04  Simon Marchi  <simon.marchi@efficios.com>
 837
 838         * filtered-iterator.h (filtered_iterator) <operator==,
 839         operator!=>: Compare wrapped iterators, not wrapped pointers.
 840         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
 841         unittests/filtered_iterator-selftests.c.
 842         * unittests/filtered_iterator-selftests.c: New file.
 843
 844 2019-12-04  Tom Tromey  <tromey@adacore.com>
 845
 846         * gdbtypes.c (create_range_type): Inherit endianity
 847         from base type.
 848
 849 2019-12-04  Tom Tromey  <tromey@adacore.com>
 850
 851         * ada-lang.c (decode_constrained_packed_array)
 852         (ada_value_assign, value_assign_to_component): Update.
 853         * dwarf2loc.c (rw_pieced_value, access_memory)
 854         (dwarf2_compile_expr_to_ax): Update.
 855         * dwarf2read.c (dwarf2_add_field): Update.
 856         * eval.c (evaluate_subexp_standard): Update.
 857         * gdbarch.c, gdbarch.h: Rebuild.
 858         * gdbarch.sh (bits_big_endian): Remove.
 859         * gdbtypes.h (union field_location): Update comment.
 860         * target-descriptions.c (make_gdb_type): Update.
 861         * valarith.c (value_bit_index): Update.
 862         * value.c (struct value) <bitpos>: Update comment.
 863         (unpack_bits_as_long, modify_field): Update.
 864         * value.h (value_bitpos): Update comment.
 865
 866 2019-12-04  Tom Tromey  <tromey@adacore.com>
 867
 868         * gdbtypes.c (type_byte_order): Move earlier.  Assert for unknown
 869         endian-ness.
 870
 871 2019-12-04  Tom Tromey  <tromey@adacore.com>
 872
 873         * dwarf2read.c (dwarf2_init_float_type)
 874         (dwarf2_init_complex_target_type): Add byte_order parameter.
 875         (read_base_type): Compute byte order earlier.
 876         * gdbtypes.c (init_float_type): Add byte_order parameter.
 877         * gdbtypes.h (init_float_type): Add byte_order parameter.
 878
 879 2019-12-04  Tom Tromey  <tromey@adacore.com>
 880
 881         * unittests/tui-selftests.c: Conditionally include tui-winsource.h.
 882
 883 2019-12-04  Tom Tromey  <tromey@adacore.com>
 884
 885         * dwarf2read.c (process_structure_scope): Initialize
 886         "discr_offset".
 887
 888 2019-12-04  Andrew Burgess  <andrew.burgess@embecosm.com>
 889
 890         * mi/mi-symbol-cmds.c (mi_symbol_info): Take extra parameter, and
 891         add it into the search spec.
 892         (parse_max_results_option): New function.
 893         (mi_info_functions_or_variables): Parse -max-results flag and pass
 894         it to mi_symbol_info.
 895         (mi_cmd_symbol_info_modules): Likewise.
 896         (mi_cmd_symbol_info_types): Likewise.
 897         * symtab.c (global_symbol_searcher::add_matching_symbols): Change
 898         return type to bool, change result container into a set, and don't
 899         add new results if we have enough already.
 900         (global_symbol_searcher::add_matching_msymbols): Change return
 901         type to bool, and don't add new results if we have enough already.
 902         (sort_search_symbols_remove_dups): Delete.
 903         (global_symbol_searcher::search): Early exit from search loop when
 904         we have enough results.  Use a std::set to collect the results
 905         from calling add_matching_symbols.
 906         * symtab.h (global_symbol_searcher) <set_max_seach_results>: New
 907         member function.
 908         (global_symbol_searcher) <m_max_search_results>: New member
 909         variable.
 910         (global_symbol_searcher) <add_matching_symbols>: Update header
 911         comment and change return type to bool.
 912         (global_symbol_searcher) <add_matching_msymbols>: Update header
 913         comment and change return type to bool.
 914
 915 2019-12-04  Andrew Burgess  <andrew.burgess@embecosm.com>
 916
 917         * symtab.c (symbol_search::compare_search_syms): Update header
 918         comment.
 919         (global_symbol_searcher::is_suitable_msymbol): New function.
 920         (global_symbol_searcher::expand_symtabs): New function.
 921         (global_symbol_searcher::add_matching_symbols): New function.
 922         (global_symbol_searcher::add_matching_msymbols): New function.
 923         (global_symbol_searcher::search): Move most of the content
 924         into the new functions above, and call them as needed.
 925         * symtab.h (global_symbol_searcher) <expand_symtabs>: New member
 926         function.
 927         (global_symbol_searcher) <add_matching_symbols>: New member
 928         function.
 929         (global_symbol_searcher) <add_matching_msymbols>: New member
 930         function.
 931         (global_symbol_searcher) <is_suitable_msymbol>: New member
 932         function.
 933
 934 2019-12-04  Andrew Burgess  <andrew.burgess@embecosm.com>
 935
 936         * mi/mi-cmds.c (mi_cmds): Add -symbol-info-module-functions and
 937         -symbol-info-module-variables entries.
 938         * mi/mi-cmds.h (mi_cmd_symbol_info_module_functions): Declare.
 939         (mi_cmd_symbol_info_module_variables): Declare.
 940         * mi/mi-symbol-cmds.c
 941         (module_symbol_search_iterator): New typedef.
 942         (output_module_symbols_in_single_module_and_file): New function.
 943         (output_module_symbols_in_single_module): New function.
 944         (mi_info_module_functions_or_variables): New function.
 945         (mi_cmd_symbol_info_module_functions): New function.
 946         (mi_cmd_symbol_info_module_variables): New function.
 947         * NEWS: Mention new MI command.
 948
 949 2019-12-03  Christian Biesinger  <cbiesinger@google.com>
 950
 951         * bcache.c (hash): Remove.
 952         (hash_continue): Remove.
 953         * bcache.h (hash): Remove.
 954         (hash_continue): Remove.
 955         (struct bcache) <ctor>: Update.
 956         * psymtab.c (psymbol_hash): Update.
 957         * stabsread.c (hashname): Update.
 958         * utils.h (fast_hash): Add an argument for a start value,
 959         defaulting to zero.
 960
 961 2019-12-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 962         * symtab.c (symbol_cache_clear_slot):  Move close to cleared type.
 963         (destroy_block_symbol_cache): New function.
 964         (symbol_cache:~symbol_cache) Call destroy_block_symbol_cache.
 965         (resize_symbol_cache): Likewise.
 966
 967 2019-12-02  Tom Tromey  <tom@tromey.com>
 968
 969         * unittests/tui-selftests.c (run_tests): Make conditional.
 970         (_initialize_tui_selftest): Make conditional.
 971
 972 2019-12-02  Christian Biesinger  <cbiesinger@google.com>
 973
 974         * aix-thread.c (debug_aix_thread): Change type to bool.
 975
 976 2019-12-02  Luis Machado  <luis.machado@linaro.org>
 977
 978         * infrun.c (follow_fork_inferior): Remove outdated FIXME comment.
 979
 980 2019-12-01  Andrew Burgess  <andrew.burgess@embecosm.com>
 981
 982         * dwarf2read.c (read_tag_string_type): Read the fields required to
 983         make a dynamic string, and possibly create a dynamic range for the
 984         string.
 985         (attr_to_dynamic_prop): Setup is_reference based on the type of
 986         attribute being processed.
 987         * gdbtypes.c (is_dynamic_type_internal): Handle TYPE_CODE_STRING.
 988         (resolve_dynamic_array): Rename to...
 989         (resolve_dynamic_array_or_string): ...this, update header comment,
 990         and accept TYPE_CODE_STRING.
 991         (resolve_dynamic_type_internal): Handle TYPE_CODE_STRING.
 992
 993 2019-12-01  Andrew Burgess  <andrew.burgess@embecosm.com>
 994
 995         * dwarf2read.c (dwarf2_per_cu_int_type): New function, takes most
 996         of its implementation from...
 997         (dwarf2_per_cu_addr_sized_int_type): ...here, which now just calls
 998         the new function.
 999
1000 2019-12-01  Andrew Burgess  <andrew.burgess@embecosm.com>
1001
1002         * dwarf2read.c (read_subrange_type): Read bit and byte stride and
1003         create a range with stride where appropriate.
1004         * f-valprint.c: Include 'gdbarch.h'.
1005         (f77_print_array_1): Take the stride into account when walking the
1006         array.  Also convert the stride into addressable units.
1007         * gdbtypes.c (create_range_type): Initialise the stride to
1008         constant zero.
1009         (create_range_type_with_stride): New function, initialise the
1010         range as normal, and then setup the stride.
1011         (has_static_range): Include the stride here.  Also change the
1012         return type to bool.
1013         (create_array_type_with_stride): Consider the range stride if the
1014         array isn't given its own stride.
1015         (resolve_dynamic_range): Resolve the stride if needed.
1016         * gdbtypes.h (struct range_bounds) <stride>: New member variable.
1017         (struct range_bounds) <flag_is_byte_stride>: New member variable.
1018         (TYPE_BIT_STRIDE): Define.
1019         (TYPE_ARRAY_BIT_STRIDE): Define.
1020         (create_range_type_with_stride): Declare.
1021         * valarith.c (value_subscripted_rvalue): Take range stride into
1022         account when walking the array.
1023
1024 2019-12-01  Tom Tromey  <tom@tromey.com>
1025
1026         * tui/tui-win.c (tui_all_windows_info): Treat inactive TUI
1027         specially.
1028
1029 2019-12-01  Tom Tromey  <tom@tromey.com>
1030
1031         * tui/tui-winsource.c (tui_copy_source_line): Don't advance past
1032         \0.
1033         * unittests/tui-selftests.c: New file.
1034         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add tui-selftests.c.
1035
1036 2019-12-01  Tom Tromey  <tom@tromey.com>
1037
1038         * tui/tui.c (tui_enable): Call tui_update_variables earlier.
1039
1040 2019-12-01  Tom Tromey  <tom@tromey.com>
1041
1042         * NEWS: Document new settings.
1043         * tui/tui-wingeneral.c (box_win): Apply appropriate border style.
1044         * tui/tui-win.c (_initialize_tui_win): Add border style
1045         observers.
1046         * tui/tui-io.h (tui_apply_style): Declare.
1047         * tui/tui-io.c (tui_apply_style): Rename from apply_style.  No
1048         longer static.
1049         (apply_ansi_escape, tui_set_reverse_mode): Update.
1050         * cli/cli-style.h (class cli_style_option) <add_setshow_commands>:
1051         Add "skip_intensity" parameter.
1052         <changed>: New member.
1053         <do_set_value>: Declare.
1054         (tui_border_style, tui_active_border_style): Declare.
1055         * cli/cli-style.c (tui_border_style, tui_active_border_style): New
1056         globals.
1057         (cli_style_option): Initialize "changed".
1058         (cli_style_option::do_set_value): New function.
1059         (cli_style_option::add_setshow_commands): Add "skip_intensity"
1060         parameter.  Update.
1061         (STYLE_ADD_SETSHOW_COMMANDS): Add "SKIP" parameter.
1062         (_initialize_cli_style): Update.  Create TUI border style
1063         commands.
1064
1065 2019-12-01  Tom Tromey  <tom@tromey.com>
1066
1067         * tui/tui-winsource.h (tui_copy_source_line): Add "ndigits"
1068         parameter.
1069         * tui/tui-winsource.c (tui_copy_source_line): Add "ndigits"
1070         parameter.
1071         * tui/tui-win.h (compact_source): Declare.
1072         * tui/tui-win.c (compact_source): New global.
1073         (tui_set_compact_source, tui_show_compact_source): New functions.
1074         (_initialize_tui_win): Add "compact-source" setting.
1075         * tui/tui-source.c (tui_source_window::set_contents): Handle
1076         compact_source setting.
1077         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
1078         * NEWS: Document new setting.
1079
1080 2019-11-30  Tom Tromey  <tom@tromey.com>
1081
1082         * dwarf2read.c (dwarf2_add_field): Include field offset when
1083         computing variant part length.
1084
1085 2019-11-30  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1086         * NEWS:  Mention define-prefix.  Tell that command names can now
1087         contain a . character.
1088
1089 2019-11-30  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1090
1091         * command.h (valid_cmd_char_p): Declare.
1092         * cli/cli-decode.c (valid_cmd_char_p): New function factorizing
1093         the check of valid command char.
1094         (find_command_name_length, valid_user_defined_cmd_name_p): Use
1095         valid_cmd_char_p.
1096         * cli/cli-script.c (validate_comname): Likewise.
1097         * completer.c (gdb_completer_command_word_break_characters):
1098         Do not remove . from the word break char, update comments.
1099         (complete_line_internal_1): Use valid_cmd_char_p.
1100         * guile/scm-cmd.c (gdbscm_parse_command_name): Likewise.
1101         * python/py-cmd.c (gdbpy_parse_command_name): Likewise.
1102
1103 2019-11-30  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1104
1105         * cli/cli-script.c (do_define_command): Ensure a redefined
1106         prefix command is kept as a prefix command.
1107         (define_prefix_command): New function.
1108         (show_user_1): Report user defined prefixes.
1109         (_initialize_cli_script):  Create the new 'define-prefix' command.
1110         Add completers for 'define' and 'document'.
1111         * top.c (execute_command):  If command is a user-defined prefix only
1112         command, report the list of commands for this prefix command.
1113
1114 2019-11-29  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
1115
1116         * valops.c (find_oload_champ): Improve debug output.
1117
1118 2019-11-29  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
1119
1120         * valops.c (find_oload_champ): Print part of debug messages
1121         before the badness vector is std::move'd.
1122
1123 2019-11-28  Tom Tromey  <tom@tromey.com>
1124
1125         * value.c (creal_internal_fn): Fix comment.
1126
1127 2019-11-28  Tom Tromey  <tom@tromey.com>
1128
1129         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count,
1130         flag_bound_evaluated>: Now unsigned.
1131
1132 2019-11-28  Tom Tromey  <tom@tromey.com>
1133
1134         * guile/guile-internal.h (vlscm_scm_from_value_unsafe): Don't
1135         declare.
1136
1137 2019-11-28  Mihails Strasuns  <mihails.strasuns@intel.com>
1138
1139         * jit.c (jit_bfd_try_read_symtab): Fix printed function name in the
1140         debug output.
1141         * jit.c (jit_unregister_code): Add debug print to match
1142         `jit_register_code`.
1143
1144 2019-11-27  Christian Biesinger  <cbiesinger@google.com>
1145
1146         * NEWS: Mention the new multithreaded symbol loading.
1147
1148 2019-11-27  Christian Biesinger  <cbiesinger@google.com>
1149
1150         * maint.c (n_worker_threads): Default to 0.
1151         (worker_threads_disabled): New function.
1152         * maint.h (worker_threads_disabled): New function.
1153         * minsyms.c (minimal_symbol_reader::record_full): Call symbol_set_names
1154         here if worker_threads_disabled () is true.
1155         (minimal_symbol_reader::install): Skip all threading if
1156         worker_threads_disabled () is true.
1157
1158 2019-11-27  Christian Biesinger  <cbiesinger@google.com>
1159
1160         * minsyms.c (add_minsym_to_hash_table): Use a previously computed
1161         hash code if possible.
1162         (add_minsym_to_demangled_hash_table): Likewise.
1163         (minimal_symbol_reader::install): Compute the hash codes for msymbol
1164         on the background thread.
1165         * symtab.h (struct minimal_symbol) <hash_value, demangled_hash_value>:
1166         Add these fields.
1167
1168 2019-11-27  Christian Biesinger  <cbiesinger@google.com>
1169
1170         * minsyms.c (minimal_symbol_reader::install): Also compute the hash
1171         of the mangled name on the background thread.
1172         * symtab.c (symbol_set_names): Allow passing in the hash of the
1173         linkage_name.
1174         * symtab.h (symbol_set_names): Likewise.
1175
1176 2019-11-27  Kevin Buettner  <kevinb@redhat.com>
1177
1178         * dwarf2read.c (inherit_abstract_dies): Ensure that delayed
1179         physnames are computed for inherited DIEs.
1180
1181 2019-11-27  Tom Tromey  <tromey@adacore.com>
1182
1183         * dwarf2read.h (struct dwarf2_per_objfile): Remove unnecessary
1184         backslashes.
1185         * cp-support.c: Remove unnecessary backslashes.
1186
1187 2019-11-27  Christian Biesinger  <cbiesinger@google.com>
1188
1189         * ada-exp.y (write_ambiguous_var): Replace SYMBOL_SET_LINKAGE_NAME
1190         with sym->set_linkage_name.
1191         * coffread.c (coff_read_enum_type): Likewise.
1192         * mdebugread.c (parse_symbol): Likewise.
1193         * stabsread.c (patch_block_stabs): Likewise.
1194         (define_symbol): Likewise.
1195         (read_enum_type): Likewise.
1196         (common_block_end): Likewise.
1197         * symtab.h (struct general_symbol_info) <set_linkage_name>: New
1198         function.
1199         (SYMBOL_SET_LINKAGE_NAME): Remove.
1200         * xcoffread.c (process_xcoff_symbol): Replace SYMBOL_SET_LINKAGE_NAME
1201         with sym->set_linkage_name.
1202
1203 2019-11-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1204
1205         * mi/mi-cmds.c (mi_cmds): Add 'symbol-info-modules' entry.
1206         * mi/mi-cmds.h (mi_cmd_symbol_info_modules): Declare.
1207         * mi/mi-symbol-cmds.c (mi_cmd_symbol_info_modules): New function.
1208         * NEWS: Mention new MI command.
1209
1210 2019-11-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1211
1212         * mi/mi-cmds.c (mi_cmds): Add '-symbol-info-functions',
1213         '-symbol-info-types', and '-symbol-info-variables'.
1214         * mi/mi-cmds.h (mi_cmd_symbol_info_functions): Declare.
1215         (mi_cmd_symbol_info_types): Declare.
1216         (mi_cmd_symbol_info_variables): Declare.
1217         * mi/mi-symbol-cmds.c: Add 'source.h' and 'mi-getopt.h' includes.
1218         (output_debug_symbol): New function.
1219         (output_nondebug_symbol): New function.
1220         (mi_symbol_info): New function.
1221         (mi_info_functions_or_variables): New function.
1222         (mi_cmd_symbol_info_functions): New function.
1223         (mi_cmd_symbol_info_types): New function.
1224         (mi_cmd_symbol_info_variables): New function.
1225         * NEWS: Mention new commands.
1226
1227 2019-11-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1228
1229         * symtab.c (symbol_to_info_string): New function, most content
1230         moved from print_symbol_info, but updated to return a std::string.
1231         (print_symbol_info): Update to use symbol_to_info_string and print
1232         returned string.
1233         * symtab.h (symbol_to_info_string): Declare new function.
1234
1235 2019-11-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1236
1237         * python/python.c (gdbpy_rbreak): Convert to using
1238         global_symbol_searcher.
1239         * symtab.c (file_matches): Convert return type to bool, change
1240         file list to std::vector, update header comment.
1241         (search_symbols): Rename to...
1242         (global_symbol_searcher::search): ...this and update now its
1243         a member function of global_symbol_searcher.  Take account of the
1244         changes to file_matches.
1245         (symtab_symbol_info): Convert to using global_symbol_searcher.
1246         (rbreak_command): Likewise.
1247         (search_module_symbols): Likewise.
1248         * symtab.h (enum symbol_search): Update comment.
1249         (search_symbols): Remove declaration.
1250         (class global_symbol_searcher): New class.
1251
1252 2019-11-26  Tom Tromey  <tromey@adacore.com>
1253
1254         * cp-support.c (_initialize_cp_support): Conditionally initialize
1255         gdb_demangle_attempt_core_dump.
1256
1257 2019-11-26  Tom Tromey  <tom@tromey.com>
1258
1259         * python/py-function.c (fnpy_init): Update.
1260         * value.h (add_internal_function): Adjust declaration.
1261         * value.c (function_destroyer): Remove.
1262         (do_add_internal_function): Don't set destroyer or copy name.
1263         (add_internal_function): Take unique_xmalloc_ptr<char> for name.
1264         Set name_allocated.
1265         * python/py-cmd.c (cmdpy_destroyer): Don't free "name".
1266         (cmdpy_init): Set name_allocated.
1267         * cli/cli-decode.h (struct cmd_list_element) <name_allocated>: New
1268         member.
1269         (~cmd_list_element): Free "name" if needed.
1270
1271 2019-11-26  Tom Tromey  <tom@tromey.com>
1272
1273         * value.h (add_internal_function): Add new overload.  Move
1274         documentation from value.h.
1275         * value.c (do_add_internal_function): New function.
1276         (add_internal_function): Use it.  Add new overload.
1277         (function_destroyer): Don't free doc.
1278         * python/py-function.c (fnpy_init): Update.
1279
1280 2019-11-26  Tom Tromey  <tom@tromey.com>
1281
1282         * python/py-cmd.c (cmdpy_destroyer): Don't free "doc".
1283         (cmdpy_init): Set "doc_allocated".
1284
1285 2019-11-26  Tom Tromey  <tom@tromey.com>
1286
1287         * gdbsupport/thread-pool.c (thread_pool::set_thread_count): Set
1288         name of worker thread.
1289         * gdbsupport/common.m4 (GDB_AC_COMMON): Check for
1290         pthread_setname_np.
1291         * configure, config.in: Rebuild.
1292
1293 2019-11-26  Tom Tromey  <tom@tromey.com>
1294
1295         * python/python.c (class gdbpy_gil): New.
1296         (struct gdbpy_event): Add constructor, destructor, operator().
1297         (gdbpy_post_event): Use run_on_main_thread.
1298         (gdbpy_initialize_events): Remove.
1299         (do_start_initialization): Update.
1300
1301 2019-11-26  Tom Tromey  <tom@tromey.com>
1302
1303         * NEWS: Add entry.
1304         * maint.c (_initialize_maint_cmds): Add "worker-threads" maint
1305         commands.  Call update_thread_pool_size.
1306         (update_thread_pool_size, maintenance_set_worker_threads): New
1307         functions.
1308         (n_worker_threads): New global.
1309
1310 2019-11-26  Christian Biesinger  <cbiesinger@google.com>
1311             Tom Tromey  <tom@tromey.com>
1312
1313         * minsyms.c (minimal_symbol_reader::install): Use
1314         parallel_for_each.
1315         * gdbsupport/parallel-for.h: New file.
1316         * Makefile.in (HFILES_NO_SRCDIR): Add gdbsupport/parallel-for.h.
1317
1318 2019-11-26  Christian Biesinger  <cbiesinger@google.com>
1319             Tom Tromey  <tom@tromey.com>
1320
1321         * gdbsupport/thread-pool.h: New file.
1322         * gdbsupport/thread-pool.c: New file.
1323         * Makefile.in (COMMON_SFILES): Add thread-pool.c.
1324         (HFILES_NO_SRCDIR): Add thread-pool.h.
1325
1326 2019-11-26  Tom Tromey  <tom@tromey.com>
1327
1328         * event-top.h (thread_local_segv_handler): Declare.
1329         * event-top.c (thread_local_segv_handler): New global.
1330         (install_handle_sigsegv, handle_sigsegv): New functions.
1331         (async_init_signals): Install SIGSEGV handler.
1332         * cp-support.c (gdb_demangle_jmp_buf): Change type.  Now
1333         thread-local.
1334         (report_failed_demangle): New function.
1335         (gdb_demangle): Make core_dump_allowed atomic.  Remove signal
1336         handler-setting code, instead use segv_handler.  Run warning code
1337         on main thread.
1338
1339 2019-11-26  Tom Tromey  <tom@tromey.com>
1340
1341         * run-on-main-thread.c: New file.
1342         * run-on-main-thread.h: New file.
1343         * unittests/main-thread-selftests.c: New file.
1344         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
1345         main-thread-selftests.c.
1346         (HFILES_NO_SRCDIR): Add run-on-main-thread.h.
1347         (COMMON_SFILES): Add run-on-main-thread.c.
1348
1349 2019-11-26  Tom Tromey  <tom@tromey.com>
1350
1351         * main.c (setup_alternate_signal_stack): Remove.
1352         (captured_main_1): Use gdb::alternate_signal_stack.
1353         * gdbsupport/alt-stack.h: New file.
1354
1355 2019-11-26  Tom Tromey  <tom@tromey.com>
1356
1357         * gdbsupport/signals-state-save-restore.c (original_signal_mask):
1358         Remove comment.
1359         (save_original_signals_state, restore_original_signals_state): Use
1360         gdb_sigmask.
1361         * linux-nat.c (block_child_signals, restore_child_signals_mask)
1362         (_initialize_linux_nat): Use gdb_sigmask.
1363         * guile/guile.c (_initialize_guile): Use block_signals.
1364         * Makefile.in (HFILES_NO_SRCDIR): Add gdb-sigmask.h.
1365         * gdbsupport/gdb-sigmask.h: New file.
1366         * event-top.c (async_sigtstp_handler): Use gdb_sigmask.
1367         * cp-support.c (gdb_demangle): Use gdb_sigmask.
1368         * gdbsupport/common.m4 (GDB_AC_COMMON): Check for
1369         pthread_sigmask.
1370         * configure, config.in: Rebuild.
1371         * gdbsupport/block-signals.h: New file.
1372
1373 2019-11-26  Tom Tromey  <tom@tromey.com>
1374
1375         * acinclude.m4: Include ax_pthread.m4.
1376         * Makefile.in (PTHREAD_CFLAGS, PTHREAD_LIBS): New variables.
1377         (INTERNAL_CFLAGS_BASE): Use PTHREAD_CFLAGS.
1378         (CLIBS): Use PTHREAD_LIBS.
1379         (aclocal_m4_deps): Add ax_pthread.m4.
1380         * config.in, configure: Rebuild.
1381         * gdbsupport/common.m4 (GDB_AC_COMMON): Check for std::thread.
1382
1383 2019-11-26  Tom Tromey  <tom@tromey.com>
1384
1385         * symtab.h (struct minimal_symbol) <name_set>: New member.
1386         * minsyms.c (minimal_symbol_reader::record_full): Copy name.
1387         Don't call symbol_set_names.
1388         (minimal_symbol_reader::install): Call symbol_set_names.
1389
1390 2019-11-26  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1391
1392         * python/python.c (gdbpy_enter::~gdbpy_enter): Release GIL after
1393         restore_active_ext_lang, as GIL is needed for (indirectly)
1394         called PyOS_InterruptOccurred.
1395
1396 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1397
1398         * sparc-nat.c (sparc_xfer_wcookie): Sync declaration with
1399         definition.
1400
1401 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1402
1403         * remote-sim.c (simulator_command): Make static, remove
1404         declaration.
1405
1406 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1407
1408         * unittests/array-view-selftests.c (check_ptr_size_ctor2): Make
1409         static.
1410         * unittests/basic_string_view/capacity/1.cc (test01): Likewise.
1411         * unittests/basic_string_view/cons/char/1.cc (test01): Likewise.
1412         (main): Likewise.
1413         * unittests/basic_string_view/cons/char/2.cc (test03): Likewise.
1414         (main): Likewise.
1415         * unittests/basic_string_view/cons/char/3.cc (test05): Likewise.
1416         (main): Likewise.
1417         * unittests/basic_string_view/element_access/char/1.cc (test01):
1418         Likewise.
1419         (main): Likewise.
1420         * unittests/basic_string_view/element_access/char/empty.cc (main):
1421         Likewise.
1422         * unittests/basic_string_view/element_access/char/front_back.cc
1423         (test01): Likewise.
1424         (main): Likewise.
1425         * unittests/basic_string_view/inserters/char/2.cc (test05):
1426         Likewise.
1427         (main): Likewise.
1428         * unittests/basic_string_view/modifiers/remove_prefix/char/1.cc
1429         (test01): Likewise.
1430         (main): Likewise.
1431         * unittests/basic_string_view/modifiers/remove_suffix/char/1.cc
1432         (test01): Likewise.
1433         (main): Likewise.
1434         * unittests/basic_string_view/modifiers/swap/char/1.cc (test01):
1435         Likewise.
1436         * unittests/basic_string_view/operations/compare/char/1.cc
1437         (test01): Likewise.
1438         (main): Likewise.
1439         * unittests/basic_string_view/operations/compare/char/13650.cc
1440         (test01): Likewise.
1441         * unittests/basic_string_view/operations/copy/char/1.cc (test01):
1442         Likewise.
1443         (main): Likewise.
1444         * unittests/basic_string_view/operations/data/char/1.cc (test01):
1445         Likewise.
1446         (main): Likewise.
1447         * unittests/basic_string_view/operations/find/char/1.cc (test01):
1448         Likewise.
1449         (main): Likewise.
1450         * unittests/basic_string_view/operations/find/char/2.cc (test02):
1451         Likewise.
1452         (main): Likewise.
1453         * unittests/basic_string_view/operations/find/char/3.cc (test03):
1454         Likewise.
1455         (main): Likewise.
1456         * unittests/basic_string_view/operations/find/char/4.cc (main):
1457         Likewise.
1458         * unittests/basic_string_view/operations/rfind/char/1.cc (test01):
1459         Likewise.
1460         (main): Likewise.
1461         * unittests/basic_string_view/operations/rfind/char/2.cc (test02):
1462         Likewise.
1463         (main): Likewise.
1464         * unittests/basic_string_view/operations/rfind/char/3.cc (test03):
1465         Likewise.
1466         (main): Likewise.
1467         * unittests/basic_string_view/operations/substr/char/1.cc
1468         (test01): Likewise.
1469         (main): Likewise.
1470         * unittests/basic_string_view/operators/char/2.cc (main):
1471         Likewise.
1472         * unittests/optional/assignment/1.cc (test): Likewise.
1473         * unittests/optional/assignment/2.cc (test): Likewise.
1474         * unittests/optional/assignment/3.cc (test): Likewise.
1475         * unittests/optional/assignment/4.cc (test): Likewise.
1476         * unittests/optional/assignment/5.cc (test): Likewise.
1477         * unittests/optional/assignment/6.cc (test): Likewise.
1478         * unittests/optional/assignment/7.cc (test): Likewise.
1479         * unittests/optional/cons/copy.cc (test): Likewise.
1480         * unittests/optional/cons/default.cc (test): Likewise.
1481         * unittests/optional/cons/move.cc (test): Likewise.
1482         * unittests/optional/cons/value.cc (test): Likewise.
1483         * unittests/optional/in_place.cc (test): Likewise.
1484         * unittests/optional/observers/1.cc (test): Likewise.
1485         * unittests/optional/observers/2.cc (test): Likewise.
1486
1487 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1488
1489         * tui-win.h (tui_set_var_cmd): Remove.
1490         * tui-win.c (tui_set_var_cmd): Make static.
1491
1492 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1493
1494         * breakpoint.h (hbreak_command_wrapper, thbreak_command_wrapper,
1495         rbreak_command_wrapper): Remove.
1496         * symtab.c (rbreak_command_wrapper): Remove.
1497
1498 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1499
1500         * inferior.h (info_terminal_command): Remove declaration.
1501         * inflow.c (info_terminal_command): Make static.
1502
1503 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1504
1505         * inferior.c (exit_inferior_silent): Remove.
1506
1507 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1508
1509         * dictionary.c (dict_empty, mdict_empty): Remove.
1510         * dictionary.c (mdict_empty): Remove.
1511
1512 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1513
1514          * arc-tdep.c (arc_insn_get_memory_base_reg): Make static.
1515          (arc_insn_get_memory_offset): Likewise.
1516          (arc_insn_dump): Likewise.
1517          * cp-support.c (test_cp_symbol_name_matches): Likewise.
1518          * csky-linux-tdep.c (csky_supply_fregset): Likewise.
1519          * dictionary.c (dict_iterator_next): Likewise.
1520          (dict_iter_match_first): Likewise.
1521          (dict_iter_match_next): Likewise.
1522          * f-lang.c (evaluate_subexp_f): Likewise.
1523          * hppa-tdep.c (hppa_read_pc): Likewise.
1524          * i386-tdep.c (i386_floatformat_for_type): Likewise.
1525          * parse.c (write_exp_elt_msym): Likewise.
1526          * ppc-linux-tdep.c (ppc_floatformat_for_type): Likewise.
1527          * remote.c (remote_packet_size): Likewise.
1528          (remote_notif_stop_parse): Likewise.
1529          * rs6000-aix-tdep.c (aix_sighandle_frame_sniffer): Likewise.
1530          * s12z-tdep.c (s12z_disassemble_info): Likewise.
1531          * source.c (prepare_path_for_appending): Likewise.
1532          * sparc64-linux-tdep.c
1533          (sparc64_linux_handle_segmentation_fault); Likewise.
1534          * stack.c (frame_selection_by_function_completer): Likewise.
1535
1536 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1537
1538         * completer.c (set_gdb_completion_word_break_characters):
1539         Remove.
1540
1541 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1542
1543         * dwarf-index-write.c: Include dwarf-index-write.h.
1544         * mi/mi-interp.c: Include mi/mi-interp.h.
1545
1546 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1547
1548         * aarch32-tdep.c: Include aarch32-tdep.h.
1549         * aarch32-tdep.h: Forward-declare struct target_desc.
1550
1551 2019-11-26  Christian Biesinger  <cbiesinger@google.com>
1552
1553         * linux-nat.c (detach_one_lwp): Call safe_strerror instead of
1554         strerror.
1555         * nto-procfs.c (nto_procfs_target::create_inferior): Likewise.
1556         * windows-nat.c (windows_nat_target::create_inferior): Likewise.
1557
1558 2019-11-25  Tom de Vries  <tdevries@suse.de>
1559
1560         * contrib/words.sh: Add -c option.
1561
1562 2019-11-25  Christian Biesinger  <cbiesinger@google.com>
1563
1564         * solib.c (solib_find_1): Change int to bool.
1565         (exec_file_find): Change int to bool.
1566         (solib_find): Change int to bool.
1567         (solib_read_symbols): Change int to bool.
1568         (solib_used): Change int to bool.
1569         (solib_add): Change int to bool.
1570         (info_sharedlibrary_command): Change int to bool.
1571         (solib_contains_address_p): Change int to bool.
1572         (solib_keep_data_in_core): Change int to bool.
1573         (in_solib_dynsym_resolve_code): Change int to bool.
1574         (reload_shared_libraries_1): Change int to bool.
1575         (gdb_sysroot_changed): Change int to bool.
1576         * solib.h (solib_read_symbols): Change int to bool.
1577         (solib_contains_address_p): Change int to bool.
1578         (solib_keep_data_in_core): Change int to bool.
1579         (in_solib_dynsym_resolve_code): Change int to bool.
1580         (libpthread_name_p): Change int to bool.
1581
1582 2019-11-25  Luis Machado  <luis.machado@linaro.org>
1583
1584         * NEWS (New Commands): Mention "set debug remote-packet-max-chars".
1585         * remote.c (REMOTE_DEBUG_MAX_CHAR): Remove.
1586         (remote_packet_max_chars): New static global.
1587         (show_remote_packet_max_chars): New function.
1588         (remote_target::putpkt_binary): Adjust to use new
1589         remote_packet_max_chars option.
1590         (remote_target::getpkt_or_notif_sane_1): Likewise.
1591         (_initialize_remote): Register new remote-packet-max-chars option.
1592
1593 2019-11-24  Simon Marchi  <simon.marchi@efficios.com>
1594
1595         * m68k-linux-nat.c: Include gdbarch.h.
1596
1597 2019-11-24  Tom Tromey  <tom@tromey.com>
1598
1599         * symfile.c (read_symbols): Update.
1600         * psymtab.c (require_partial_symbols): Change type of "verbose" to
1601         bool.
1602         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
1603         (psym_lookup_symbol, psym_find_last_source_symtab)
1604         (psym_forget_cached_source_info, psym_print_stats)
1605         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
1606         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
1607         (psym_map_matching_symbols, psym_expand_symtabs_matching)
1608         (psym_find_compunit_symtab_by_address)
1609         (maintenance_print_psymbols, maintenance_info_psymtabs)
1610         (maintenance_check_psymtabs): Update.
1611         * psymtab.h (require_partial_symbols): Change type of "verbose" to
1612         bool.
1613
1614 2019-11-22  Tom Tromey  <tom@tromey.com>
1615
1616         * observable.h: Update comments.
1617
1618 2019-11-22  Tom Tromey  <tromey@adacore.com>
1619
1620         * ada-tasks.c (ada_task_is_alive): Make parameter const.
1621         (print_ada_task_info): Don't try to fetch thread id if task is not
1622         alive.
1623
1624 2019-11-22  Christian Biesinger  <cbiesinger@google.com>
1625
1626         * ada-exp.y: Update.
1627         * ada-lang.c (sort_choices): Update.
1628         (ada_print_symbol_signature): Update.
1629         (resolve_subexp): Update.
1630         (ada_parse_renaming): Update.
1631         (ada_read_renaming_var_value): Update.
1632         (lesseq_defined_than): Update.
1633         (remove_extra_symbols): Update.
1634         (remove_irrelevant_renamings): Update.
1635         (ada_add_block_symbols): Update.
1636         (ada_collect_symbol_completion_matches): Update.
1637         (ada_is_renaming_symbol): Update.
1638         (aggregate_assign_from_choices): Update.
1639         (ada_evaluate_subexp): Update.
1640         (ada_has_this_exception_support): Update.
1641         (ada_is_non_standard_exception_sym): Update.
1642         (ada_add_exceptions_from_frame): Update.
1643         (ada_add_global_exceptions): Update.
1644         (ada_print_subexp): Update.
1645         * ax-gdb.c (gen_var_ref): Update.
1646         (gen_maybe_namespace_elt): Update.
1647         (gen_expr_for_cast): Update.
1648         (gen_expr): Update.
1649         * block.h: Update.
1650         * blockframe.c (find_pc_partial_function): Update.
1651         * breakpoint.c (print_breakpoint_location): Update.
1652         (update_static_tracepoint): Update.
1653         * btrace.c (ftrace_print_function_name): Update.
1654         (ftrace_function_switched): Update.
1655         * buildsym.c (find_symbol_in_list): Update.
1656         * c-exp.y: Update.
1657         * c-typeprint.c (c_print_typedef): Update.
1658         (c_type_print_template_args): Update.
1659         * cli/cli-cmds.c (edit_command): Update.
1660         (list_command): Update.
1661         (print_sal_location): Update.
1662         * coffread.c (patch_opaque_types): Update.
1663         (process_coff_symbol): Update.
1664         (coff_read_enum_type): Update.
1665         * compile/compile-c-symbols.c (c_symbol_substitution_name): Update.
1666         (convert_one_symbol): Update.
1667         (hash_symname): Update.
1668         (eq_symname): Update.
1669         * compile/compile-cplus-symbols.c (convert_one_symbol): Update.
1670         * compile/compile-cplus-types.c (debug_print_scope): Update.
1671         * compile/compile-loc2c.c (do_compile_dwarf_expr_to_c): Update.
1672         * compile/compile-object-load.c (get_out_value_type): Update.
1673         * cp-namespace.c (cp_scan_for_anonymous_namespaces): Update.
1674         (search_symbol_list): Update.
1675         (cp_lookup_symbol_imports_or_template): Update.
1676         * cp-support.c (overload_list_add_symbol): Update.
1677         * ctfread.c (psymtab_to_symtab): Update.
1678         * dbxread.c (cp_set_block_scope): Update.
1679         * dictionary.c (iter_match_first_hashed): Update.
1680         (iter_match_next_hashed): Update.
1681         (insert_symbol_hashed): Update.
1682         (iter_match_next_linear): Update.
1683         * dictionary.h: Update.
1684         * dwarf2loc.c (func_get_frame_base_dwarf_block): Update.
1685         (locexpr_describe_location_piece): Update.
1686         (locexpr_describe_location_1): Update.
1687         (locexpr_generate_c_location): Update.
1688         (loclist_describe_location): Update.
1689         (loclist_generate_c_location): Update.
1690         * dwarf2read.c (dw2_debug_names_lookup_symbol): Update.
1691         (read_func_scope): Update.
1692         (process_enumeration_scope): Update.
1693         (new_symbol): Update.
1694         (dwarf2_const_value): Update.
1695         (dwarf2_symbol_mark_computed): Update.
1696         * eval.c (evaluate_funcall): Update.
1697         (evaluate_subexp_standard): Update.
1698         * expprint.c (print_subexp_standard): Update.
1699         (dump_subexp_body_standard): Update.
1700         * f-valprint.c (info_common_command_for_block): Update.
1701         * findvar.c (get_hosting_frame): Update.
1702         (default_read_var_value): Update.
1703         * go-lang.c (go_symbol_package_name): Update.
1704         * guile/scm-block.c (bkscm_print_block_smob): Update.
1705         * guile/scm-symbol.c (syscm_print_symbol_smob): Update.
1706         (gdbscm_symbol_name): Update.
1707         (gdbscm_symbol_linkage_name): Update.
1708         (gdbscm_symbol_print_name): Update.
1709         * infcall.c (get_function_name): Update.
1710         * infcmd.c (jump_command): Update.
1711         (finish_command): Update.
1712         * infrun.c (insert_exception_resume_breakpoint): Update.
1713         * linespec.c (canonicalize_linespec): Update.
1714         (create_sals_line_offset): Update.
1715         (convert_linespec_to_sals): Update.
1716         (complete_label): Update.
1717         (find_label_symbols_in_block): Update.
1718         * m2-typeprint.c (m2_print_typedef): Update.
1719         * mdebugread.c (mdebug_reg_to_regnum): Update.
1720         (parse_symbol): Update.
1721         (mylookup_symbol): Update.
1722         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
1723         (list_args_or_locals): Update.
1724         * objc-lang.c (compare_selectors): Update.
1725         (info_selectors_command): Update.
1726         (compare_classes): Update.
1727         (info_classes_command): Update.
1728         (find_imps): Update.
1729         * p-typeprint.c (pascal_print_typedef): Update.
1730         * printcmd.c (build_address_symbolic): Update.
1731         (info_address_command): Update.
1732         (print_variable_and_value): Update.
1733         * python/py-framefilter.c (extract_sym): Update.
1734         (py_print_single_arg): Update.
1735         * python/py-symbol.c (sympy_str): Update.
1736         (sympy_get_name): Update.
1737         (sympy_get_linkage_name): Update.
1738         * python/python.c (gdbpy_rbreak): Update.
1739         * record-btrace.c (btrace_get_bfun_name): Update.
1740         (btrace_call_history): Update.
1741         * rust-lang.c (rust_print_typedef): Update.
1742         * solib-frv.c (frv_fdpic_find_canonical_descriptor): Update.
1743         * stabsread.c (stab_reg_to_regnum): Update.
1744         (define_symbol): Update.
1745         (read_enum_type): Update.
1746         (common_block_end): Update.
1747         (cleanup_undefined_types_1): Update.
1748         (scan_file_globals): Update.
1749         * stack.c (print_frame_arg): Update.
1750         (print_frame_args): Update.
1751         (find_frame_funname): Update.
1752         (info_frame_command_core): Update.
1753         (iterate_over_block_locals): Update.
1754         (print_block_frame_labels): Update.
1755         (do_print_variable_and_value): Update.
1756         (iterate_over_block_arg_vars): Update.
1757         (return_command): Update.
1758         * symmisc.c (dump_symtab_1): Update.
1759         (print_symbol): Update.
1760         * symtab.c (eq_symbol_entry): Update.
1761         (symbol_cache_dump): Update.
1762         (lookup_language_this): Update.
1763         (find_pc_sect_line): Update.
1764         (skip_prologue_sal): Update.
1765         (symbol_search::compare_search_syms): Update.
1766         (treg_matches_sym_type_name): Update.
1767         (search_symbols): Update.
1768         (print_symbol_info): Update.
1769         (rbreak_command): Update.
1770         (completion_list_add_symbol): Update.
1771         (find_gnu_ifunc): Update.
1772         (get_symbol_address): Update.
1773         (search_module_symbols): Update.
1774         (info_module_subcommand): Update.
1775         * symtab.h (SYMBOL_NATURAL_NAME): Remove.
1776         (SYMBOL_LINKAGE_NAME): Remove.
1777         (SYMBOL_DEMANGLED_NAME): Remove.
1778         (SYMBOL_PRINT_NAME): Remove.
1779         (SYMBOL_SEARCH_NAME): Remove.
1780         * tracepoint.c (set_traceframe_context): Update.
1781         (validate_actionline): Update.
1782         (collection_list::collect_symbol): Update.
1783         (encode_actions_1): Update.
1784         (info_scope_command): Update.
1785         (print_one_static_tracepoint_marker): Update.
1786         * typeprint.c (typedef_hash_table::add_template_parameters): Update.
1787         * valops.c (address_of_variable): Update.
1788         (find_overload_match): Update.
1789         (find_oload_champ): Update.
1790
1791 2019-11-22  Christian Biesinger  <cbiesinger@google.com>
1792
1793         * ada-lang.c (ada_lookup_simple_minsym): Update.
1794         (ada_collect_symbol_completion_matches): Update.
1795         * ada-tasks.c (read_atcb): Update.
1796         * amd64-windows-tdep.c (amd64_skip_main_prologue): Update.
1797         (amd64_windows_skip_trampoline_code): Update.
1798         * arm-tdep.c (skip_prologue_function): Update.
1799         (arm_skip_stack_protector): Update.
1800         * arm-wince-tdep.c (arm_pe_skip_trampoline_code): Update.
1801         (arm_wince_skip_main_prologue): Update.
1802         * ax-gdb.c (gen_expr): Update.
1803         * block.c (call_site_for_pc): Update.
1804         * blockframe.c (find_pc_partial_function): Update.
1805         * breakpoint.c (set_breakpoint_location_function): Update.
1806         * btrace.c (ftrace_print_function_name): Update.
1807         (ftrace_function_switched): Update.
1808         * c-valprint.c (print_unpacked_pointer): Update.
1809         * coffread.c (coff_symfile_read): Update.
1810         * compile/compile-c-symbols.c (convert_symbol_bmsym): Update.
1811         * compile/compile-cplus-symbols.c (convert_symbol_bmsym): Update.
1812         * dwarf-index-write.c (write_psymbols): Update.
1813         * dwarf2loc.c (call_site_to_target_addr): Update.
1814         (func_verify_no_selftailcall): Update.
1815         (tailcall_dump): Update.
1816         (call_site_find_chain_1): Update.
1817         (dwarf_expr_reg_to_entry_parameter): Update.
1818         * elfread.c (elf_gnu_ifunc_record_cache): Update.
1819         * eval.c (evaluate_funcall): Update.
1820         (evaluate_subexp_standard): Update.
1821         (evaluate_subexp_for_sizeof): Update.
1822         * expprint.c (print_subexp_standard): Update.
1823         (dump_subexp_body_standard): Update.
1824         * frame.c (get_prev_frame_always_1): Update.
1825         * frv-tdep.c (frv_skip_main_prologue): Update.
1826         * gnu-v2-abi.c (gnuv2_value_rtti_type): Update.
1827         * gnu-v3-abi.c (gnuv3_rtti_type): Update.
1828         (gnuv3_get_typename_from_type_info): Update.
1829         (gnuv3_skip_trampoline): Update.
1830         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
1831         * i386-tdep.c (i386_skip_main_prologue): Update.
1832         (i386_pe_skip_trampoline_code): Update.
1833         * ia64-tdep.c (ia64_convert_from_func_ptr_addr): Update.
1834         * infcall.c (get_function_name): Update.
1835         * linespec.c (minsym_found): Update.
1836         * linux-fork.c (info_checkpoints_command): Update.
1837         * m32c-tdep.c (m32c_m16c_address_to_pointer): Update.
1838         (m32c_m16c_pointer_to_address): Update.
1839         * maint.c (maintenance_translate_address): Update.
1840         * minsyms.c (add_minsym_to_hash_table): Update.
1841         (add_minsym_to_demangled_hash_table): Update.
1842         (lookup_minimal_symbol_mangled): Update.
1843         (lookup_minimal_symbol_demangled): Update.
1844         (lookup_minimal_symbol_linkage): Update.
1845         (lookup_minimal_symbol_text): Update.
1846         (lookup_minimal_symbol_by_pc_name): Update.
1847         (minimal_symbol_is_less_than): Update.
1848         (compact_minimal_symbols): Update.
1849         (build_minimal_symbol_hash_tables): Update.
1850         (find_solib_trampoline_target): Update.
1851         * mips-tdep.c (mips_stub_frame_sniffer): Update.
1852         (mips_skip_pic_trampoline_code): Update.
1853         * msp430-tdep.c (msp430_skip_trampoline_code): Update.
1854         * objc-lang.c (info_selectors_command): Update.
1855         (info_classes_command): Update.
1856         (find_methods): Update.
1857         (find_imps): Update.
1858         * p-valprint.c (pascal_val_print): Update.
1859         * ppc-linux-tdep.c (powerpc_linux_in_dynsym_resolve_code): Update.
1860         * ppc-sysv-tdep.c (convert_code_addr_to_desc_addr): Update.
1861         * printcmd.c (build_address_symbolic): Update.
1862         (info_symbol_command): Update.
1863         * psymtab.c (psymbol_name_matches): Update.
1864         (match_partial_symbol): Update.
1865         (lookup_partial_symbol): Update.
1866         (print_partial_symbols): Update.
1867         (sort_pst_symbols): Update.
1868         (maintenance_check_psymtabs): Update.
1869         * python/py-framefilter.c (py_print_frame): Update.
1870         * python/python.c (gdbpy_rbreak): Update.
1871         * record-btrace.c (btrace_get_bfun_name): Update.
1872         (btrace_call_history): Update.
1873         * rs6000-tdep.c (rs6000_skip_main_prologue): Update.
1874         (rs6000_skip_trampoline_code): Update.
1875         * sol-thread.c (info_cb): Update.
1876         * stabsread.c (scan_file_globals): Update.
1877         * stack.c (find_frame_funname): Update.
1878         (info_frame_command_core): Update.
1879         * symmisc.c (dump_msymbols): Update.
1880         * symtab.c (symbol_natural_name): Rename to..,
1881         (general_symbol_info::natural_name): ...this.
1882         (symbol_demangled_name): Rename to...
1883         (general_symbol_info::demangled_name): ...this.
1884         (symbol_search_name): Rename to...
1885         (general_symbol_info::search_name): ...this.
1886         (symbol_matches_search_name): Update.
1887         (find_pc_sect_line): Update.
1888         (skip_prologue_sal): Update.
1889         (search_symbols): Update.
1890         (print_msymbol_info): Update.
1891         (rbreak_command): Update.
1892         (completion_list_add_msymbol): Update.
1893         (completion_list_objc_symbol): Update.
1894         (get_msymbol_address): Update.
1895         * symtab.h (struct general_symbol_info): Add member functions
1896         natural_name (), linkage_name (), print_name (), demangled_name (),
1897         and search_name ().
1898         (SYMBOL_NATURAL_NAME): Update.
1899         (symbol_natural_name): Move to a member function on general_symbol_info.
1900         (SYMBOL_DEMANGLED_NAME): Update.
1901         (symbol_demangled_name): Move to a member function on
1902         general_symbol_info.
1903         (SYMBOL_SEARCH_NAME): Update.
1904         (symbol_search_name): Move to a member function on general_symbol_info.
1905         (MSYMBOL_NATURAL_NAME): Remove.
1906         (MSYMBOL_LINKAGE_NAME): Remove.
1907         (MSYMBOL_PRINT_NAME): Remove.
1908         (MSYMBOL_DEMANGLED_NAME): Remove.
1909         (MSYMBOL_SEARCH_NAME): Remove.
1910         * x86-tdep.c (x86_in_indirect_branch_thunk): Update.
1911
1912 2019-11-22  Christian Biesinger  <cbiesinger@google.com>
1913
1914         * symtab.c (create_demangled_names_hash): Use per_bfd->
1915         minimal_symbol_count for computing the initial size, if greater
1916         than our default size.
1917
1918 2019-11-22  Tom de Vries  <tdevries@suse.de>
1919
1920         * contrib/words.sh: Improve words extraction.
1921
1922 2019-11-22  Tom de Vries  <tdevries@suse.de>
1923
1924         * contrib/words.sh: Combine sed invocations.
1925
1926 2019-11-21  Christian Biesinger  <cbiesinger@google.com>
1927
1928         * Makefile.in: Update.
1929         * demangle.c: Rename to...
1930         * gdb-demangle.c: ..this.
1931         (is_cplus_marker): Change return type to bool.
1932         (_initialize_demangler): Rename to...
1933         (_initialize_gdb_demangle): ...this.
1934         * gdb-demangle.h (is_cplus_marker): Change return type to bool.
1935         * symtab.h (demangle): Remove declaration; instead include
1936         gdb-demangle.h.
1937
1938 2019-11-21  Tom Tromey  <tromey@adacore.com>
1939
1940         * gdbsupport/format.c (format_pieces): Parse %I64d.
1941         * unittests/format_pieces-selftests.c (test_windows_formats): New
1942         function.
1943         (run_tests): Call it.
1944
1945 2019-11-21  Peeter Joot  <peeter.joot@lzlabs.com>
1946
1947         Byte reverse display of variables with DW_END_big, DW_END_little
1948         (DW_AT_endianity) dwarf attributes if different than the native
1949         byte order.
1950         * ada-lang.c (ada_value_binop):
1951         Use type_byte_order instead of gdbarch_byte_order.
1952         * ada-valprint.c (printstr):
1953         (ada_val_print_string):
1954         * ada-lang.c (value_pointer):
1955         (ada_value_binop):
1956         Use type_byte_order instead of gdbarch_byte_order.
1957         * c-lang.c (c_get_string):
1958         Use type_byte_order instead of gdbarch_byte_order.
1959         * c-valprint.c (c_val_print_array):
1960         Use type_byte_order instead of gdbarch_byte_order.
1961         * cp-valprint.c (cp_print_class_member):
1962         Use type_byte_order instead of gdbarch_byte_order.
1963         * dwarf2loc.c (rw_pieced_value):
1964         Use type_byte_order instead of gdbarch_byte_order.
1965         * dwarf2read.c (read_base_type): Handle DW_END_big,
1966         DW_END_little
1967         * f-lang.c (f_get_encoding):
1968         Use type_byte_order instead of gdbarch_byte_order.
1969         * findvar.c (default_read_var_value):
1970         Use type_byte_order instead of gdbarch_byte_order.
1971         * gdbtypes.c (check_types_equal):
1972         Require matching TYPE_ENDIANITY_NOT_DEFAULT if set.
1973         (recursive_dump_type): Print TYPE_ENDIANITY_BIG,
1974         and TYPE_ENDIANITY_LITTLE if set.
1975         (type_byte_order): new function.
1976         * gdbtypes.h (TYPE_ENDIANITY_NOT_DEFAULT): New macro.
1977         (struct main_type) <flag_endianity_not_default>:
1978         New field.
1979         (type_byte_order): New function.
1980         * infcmd.c (default_print_one_register_info):
1981         Use type_byte_order instead of gdbarch_byte_order.
1982         * p-lang.c (pascal_printstr):
1983         Use type_byte_order instead of gdbarch_byte_order.
1984         * p-valprint.c (pascal_val_print):
1985         Use type_byte_order instead of gdbarch_byte_order.
1986         * printcmd.c (print_scalar_formatted):
1987         Use type_byte_order instead of gdbarch_byte_order.
1988         * solib-darwin.c (darwin_current_sos):
1989         Use type_byte_order instead of gdbarch_byte_order.
1990         * solib-svr4.c (solib_svr4_r_ldsomap):
1991         Use type_byte_order instead of gdbarch_byte_order.
1992         * stap-probe.c (stap_modify_semaphore):
1993         Use type_byte_order instead of gdbarch_byte_order.
1994         * target-float.c (target_float_same_format_p):
1995         Use type_byte_order instead of gdbarch_byte_order.
1996         * valarith.c (scalar_binop):
1997         (value_bit_index):
1998         Use type_byte_order instead of gdbarch_byte_order.
1999         * valops.c (value_cast):
2000         Use type_byte_order instead of gdbarch_byte_order.
2001         * valprint.c (generic_emit_char):
2002         (generic_printstr):
2003         (val_print_string):
2004         Use type_byte_order instead of gdbarch_byte_order.
2005         * value.c (unpack_long):
2006         (unpack_bits_as_long):
2007         (unpack_value_bitfield):
2008         (modify_field):
2009         (pack_long):
2010         (pack_unsigned_long):
2011         Use type_byte_order instead of gdbarch_byte_order.
2012         * findvar.c (unsigned_pointer_to_address):
2013         (signed_pointer_to_address):
2014         (unsigned_address_to_pointer):
2015         (address_to_signed_pointer):
2016         (default_read_var_value):
2017         (default_value_from_register):
2018         Use type_byte_order instead of gdbarch_byte_order.
2019         * gnu-v3-abi.c (gnuv3_make_method_ptr):
2020         Use type_byte_order instead of gdbarch_byte_order.
2021         * riscv-tdep.c (riscv_print_one_register_info):
2022         Use type_byte_order instead of gdbarch_byte_order.
2023
2024 2019-11-21  Simon Marchi  <simon.marchi@polymtl.ca>
2025
2026         * top.c (current_ui_gdb_stdout_ptr): Spell out by hand.
2027         (current_ui_gdb_stdin_ptr): Likewise.
2028         (current_ui_gdb_stderr_ptr): Likewise.
2029         (current_ui_gdb_stdlog_ptr): Likewise.
2030         (current_ui_current_uiout_ptr): Likewise.
2031         (gen_ret_current_ui_field_ptr): Remove.
2032
2033 2019-11-21  Tom de Vries  <tdevries@suse.de>
2034
2035         PR gdb/24956
2036         * cli/cli-script.c (execute_control_command): Only switch to
2037         INTERP_CONSOLE's ui_out when INTERP_MI is active.
2038
2039 2019-11-19  Tom Tromey  <tom@tromey.com>
2040
2041         * tui/tui-win.c (tui_partial_win_by_name): Move from tui-data.c.
2042         Now static.  Change type of "name".
2043         (tui_set_win_height_command): Don't copy "arg".
2044         * tui/tui-data.h (tui_partial_win_by_name): Don't declare.
2045         * tui/tui-data.c (tui_partial_win_by_name): Move to tui-win.c.
2046
2047 2019-11-19  Ali Tamur <tamur@google.com>
2048
2049         * dwarf2read.c (dw2_get_file_names_reader): Replace "if (attr)" with
2050         "if (attr != nullptr)".
2051         (dwarf2_find_base_address): Likewise.
2052         (dwarf2_build_include_psymtabs): Likewise.
2053         (read_cutu_die_from_dwo): Likewise.
2054         (read_func_scope): Likewise.
2055         (read_call_site_scope): Likewise.
2056         (dwarf2_get_pc_bounds): Likewise.
2057         (dwarf2_record_block_ranges): Likewise.
2058         (dwarf2_add_field): Likewise.
2059         (dwarf2_add_member_fn): Likewise.
2060         (read_structure_type): Likewise.
2061         (read_enumeration_type): Likewise.
2062         (read_array_type): Likewise.
2063         (read_array_order): Likewise.
2064         (read_set_type): Likewise.
2065         (read_common_block): Likewise.
2066         (read_tag_reference_type): Likewise.
2067         (read_tag_string_type): Likewise.
2068         (read_subroutine_type): Likewise.
2069         (read_base_type): Likewise.
2070         (read_subrange_type): Likewise.
2071         (new_symbol): Likewise.
2072         (prepare_one_comp_unit): Likewise.
2073
2074 2019-11-19  Tom Tromey  <tromey@adacore.com>
2075
2076         * windows-nat.c (windows_nat_target::attach): Include GetLastError
2077         result in error when DebugActiveProcess fails.
2078
2079 2019-11-18  Sergio Durigan Junior  <sergiodj@redhat.com>
2080             Pedro Alves  <palves@redhat.com>
2081
2082         https://bugzilla.redhat.com/show_bug.cgi?id=1765117
2083         * target.c (target_stack::push): Call 'unpush' if there's a
2084         target on top of the stack.
2085
2086 2019-11-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2087
2088         * python/py-block.c (blpy_dealloc): Call tp_free.
2089         (blpy_block_syms_dealloc): Likewise.
2090         * python/py-finishbreakpoint.c (bpfinishpy_dealloc): Likewise.
2091         * python/py-inferior.c (infpy_dealloc): Likewise.
2092         * python/py-lazy-string.c (stpy_dealloc): Likewise.
2093         * python/py-linetable.c (ltpy_iterator_dealloc): Likewise.
2094         * python/py-symbol.c (sympy_dealloc): Likewise.
2095         * python/py-symtab.c (stpy_dealloc): Likewise.
2096         * python/py-type.c (typy_iterator_dealloc): Likewise.
2097
2098 2019-11-18  Christian Biesinger  <cbiesinger@google.com>
2099
2100         * symtab.h (struct symbol) <owner>: Initialize explicitly in the
2101         constructor instead of using a class initializer.
2102
2103 2019-11-15  Christian Biesinger  <cbiesinger@google.com>
2104
2105         * Makefile.in: Replace {posix,mingw}-strerror.c with safe-strerror.c.
2106         * configure: Regenerate.
2107         * configure.ac: Don't source common.host.
2108         * gdbsupport/common.host: Remove.
2109         * gdbsupport/mingw-strerror.c: Remove.
2110         * gdbsupport/posix-strerror.c: Rename to...
2111         * gdbsupport/safe-strerror.c: ...this.
2112
2113 2019-11-15  Christian Biesinger  <cbiesinger@google.com>
2114
2115         * maint.c (scoped_command_stats::print_time): Use localtime_r
2116         instead of localtime (provided through gnulib if necessary).
2117         * nat/linux-osdata.c (time_from_time_t): Use ctime_r instead
2118         of ctime.
2119
2120 2019-11-15  Christian Biesinger  <cbiesinger@google.com>
2121
2122         * gdbsupport/common-defs.h: Include time.h before pathmax.h to
2123         avoid compile errors.
2124
2125 2019-11-15  Christian Biesinger  <cbiesinger@google.com>
2126
2127         * config.in: Regenerate.
2128         * configure: Regenerate.
2129         * gdbsupport/common.m4: No longer check for strerror_r.
2130         * gdbsupport/posix-strerror.c (safe_strerror): Always call the
2131         POSIX version of strerror_r, now that gnulib provides it if
2132         necessary.
2133
2134 2019-11-14  Christian Biesinger  <cbiesinger@google.com>
2135
2136         * README (`configure' options): Update.
2137
2138 2019-11-14  Tom Tromey  <tromey@adacore.com>
2139
2140         * eval.c (evaluate_subexp_standard) <BINOP_ASSIGN>: Do not pass an
2141         expected type for the RHS if the LHS is a convenience variable.
2142
2143 2019-11-14  Simon Marchi  <simon.marchi@polymtl.ca>
2144
2145         * unittests/vec-utils-selftests.c (unordered_remove_tests::obj):
2146         Provide explicit default and copy constructor.
2147
2148 2019-11-14  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2149
2150         * python/py-finishbreakpoint.c (gdbpy_breakpoint_created):
2151         only call Py_INCREF (newbp) in the bppy_pending_object case.
2152
2153 2019-11-13  Tom Tromey  <tromey@adacore.com>
2154
2155         PR build/25182:
2156         * psympriv.h (partial_symbol): Remove static assert.
2157         * symtab.h (general_symbol_info, symbol): Remove static assert.
2158
2159 2019-11-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2160
2161         * gdbsupport/format.c (format_pieces::format_pieces): Support
2162         printf 'z' size modifier.
2163         * gdbsupport/format.h (enum argclass): Add size_t_arg.
2164         * printcmd.c (ui_printf):  Handle size_t_arg.
2165         * ui-out.c (ui_out::vmessage): Likewise.
2166         * unittests/format_pieces-selftests.c (test_format_int_sizes): New
2167         function.
2168         (run_tests): Call test_format_int_sizes.
2169
2170 2019-11-12  Christian Biesinger  <cbiesinger@google.com>
2171
2172         * ada-exp.y (write_ambiguous_var): Update.
2173         * buildsym.c (add_symbol_to_list): Update.
2174         * dwarf2read.c (read_variable): Update.
2175         (new_symbol): Update.
2176         * jit.c (finalize_symtab): Update.
2177         * language.c (language_alloc_type_symbol): Update.
2178         * symtab.c (fixup_symbol_section): Update.
2179         (initialize_objfile_symbol_1): Move code to...
2180         (initialize_objfile_symbol): ...here. Remove now-unnecessary memset.
2181         (allocate_symbol): Update.
2182         (allocate_template_symbol): Update.
2183         (get_symbol_address): Update.
2184         * symtab.h (struct symbol): Inherit from general_symbol_info instead
2185         of having as a field, and add a constructor.
2186         (SYMBOL_VALUE): Update.
2187         (SYMBOL_VALUE_ADDRESS): Update.
2188         (SET_SYMBOL_VALUE_ADDRESS): Update.
2189         (SYMBOL_VALUE_BYTES): Update.
2190         (SYMBOL_VALUE_COMMON_BLOCK): Update.
2191         (SYMBOL_BLOCK_VALUE): Update.
2192         (SYMBOL_VALUE_CHAIN): Update.
2193         (SYMBOL_LANGUAGE): Update.
2194         (SYMBOL_SECTION): Update.
2195         (SYMBOL_OBJ_SECTION): Update.
2196         (SYMBOL_SET_LANGUAGE): Update.
2197         (SYMBOL_SET_LINKAGE_NAME): Update.
2198         (SYMBOL_SET_NAMES): Update.
2199         (SYMBOL_NATURAL_NAME): Update.
2200         (SYMBOL_LINKAGE_NAME): Update.
2201         (SYMBOL_DEMANGLED_NAME): Update.
2202         (SYMBOL_SEARCH_NAME): Update.
2203         (SYMBOL_MATCHES_SEARCH_NAME): Update.
2204         (struct symbol): Update.
2205         (struct template_symbol): Update.
2206         (struct rust_vtable_symbol): Update.
2207         * xcoffread.c (SYMBOL_DUP): Update.
2208
2209 2019-11-12  Tom Tromey  <tom@tromey.com>
2210
2211         * tui/tui-layout.c (show_layout): Set current_layout.
2212         (show_source_disasm_command, show_data)
2213         (show_source_or_disasm_and_command): Don't set current_layout.
2214
2215 2019-11-12  Tom Tromey  <tom@tromey.com>
2216
2217         * tui/tui-layout.c (_initialize_tui_layout): Move to end.
2218
2219 2019-11-12  Tom Tromey  <tom@tromey.com>
2220
2221         * tui/tui-win.c (resize_message): New global.
2222         (show_tui_resize_message): New function.
2223         (tui_async_resize_screen): Print message if requested.
2224         (_initialize_tui_win): Add tui-resize-message setting.
2225         * NEWS: Add entry for new commands.
2226
2227 2019-11-11  Tom Tromey  <tom@tromey.com>
2228
2229         * tui/tui.c (tui_initialize_readline): Add new bindable readline
2230         functions.
2231
2232 2019-11-11  Christian Biesinger  <cbiesinger@google.com>
2233
2234         * nat/linux-osdata.c (user_from_uid): Use getpwuid_r.
2235
2236 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2237
2238         * python/py-symbol.c (gdbpy_lookup_static_symbols): New
2239         function.
2240         * python/python-internal.h (gdbpy_lookup_static_symbols):
2241         Declare new function.
2242         * python/python.c (python_GdbMethods): Add
2243         gdb.lookup_static_symbols method.
2244         * NEWS: Mention gdb.lookup_static_symbols.
2245
2246 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2247
2248         * python/py-symbol.c (gdbpy_lookup_static_symbol): Lookup in
2249         static block of current object file first.  Also fix typo in
2250         header comment.
2251
2252 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2253
2254         * stack.c (set_last_displayed_sal): Delete.
2255         (last_displayed_sal_valid): Delete.
2256         (last_displayed_pspace): Delete.
2257         (last_displayed_addr): Delete.
2258         (last_displayed_symtab): Delete.
2259         (last_displayed_line): Delete.
2260         (class last_displayed_symtab_info_type): New.
2261         (last_displayed_symtab_info): New static global variable.
2262         (print_frame_info): Call methods on last_displayed_symtab_info.
2263         (clear_last_displayed_sal): Update header comment, and make use of
2264         last_displayed_symtab_info.
2265         (last_displayed_sal_is_valid): Likewise.
2266         (get_last_displayed_pspace): Likewise.
2267         (get_last_displayed_addr): Likewise.
2268         (get_last_displayed_symtab): Likewise.
2269         (get_last_displayed_line): Likewise.
2270         (get_last_displayed_sal): Likewise.
2271         * stack.h (clear_last_displayed_sal): Update header comment.
2272         (last_displayed_sal_is_valid): Likewise.
2273         (get_last_displayed_pspace): Likewise.
2274         (get_last_displayed_addr): Likewise.
2275         (get_last_displayed_symtab): Likewise.
2276         (get_last_displayed_line): Likewise.
2277         (get_last_displayed_sal): Likewise.
2278
2279 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2280
2281         * stack.c (frame_show_address): Convert return type to bool.
2282         * stack.h (frame_show_address): Likewise, and update header
2283         comment.
2284
2285 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2286
2287         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add new file to the list.
2288         * unittests/vec-utils-selftests.c: New file.
2289         * gdbsupport/gdb_vecs.h (unordered_remove): Avoid self move assign.
2290
2291 2019-11-10  Tom Tromey  <tom@tromey.com>
2292
2293         * tui/tui-wingeneral.c (tui_unhighlight_win): Use can_box.
2294         (tui_highlight_win): Likewise.
2295         (tui_win_info::check_and_display_highlight_if_needed): Likewise.
2296         * tui/tui-data.h (struct tui_win_info) <can_highlight>: Remove.
2297         * tui/tui-command.h (struct tui_cmd_window) <tui_cmd_window>:
2298         Don't set can_highlight.
2299
2300 2019-11-10  Tom Tromey  <tom@tromey.com>
2301
2302         * cli/cli-style.h (class cli_style_option) <cli_style_option>:
2303         Remove unused declaration.
2304
2305 2019-11-08  Tom Tromey  <tromey@adacore.com>
2306
2307         * top.c (read_command_file): Update.
2308         (command_line_input): Make return type const.
2309         * python/py-gdb-readline.c: Update.
2310         * linespec.c (decode_line_2): Update.
2311         * defs.h (command_line_input): Make return type const.
2312         * cli/cli-script.c (read_next_line): Make return type const.
2313         * ada-lang.c (get_selections): Update.
2314
2315 2019-11-06  Christian Biesinger  <cbiesinger@google.com>
2316
2317         * linux-tdep.c (linux_info_proc): Use strtok_r instead of strtok.
2318         * mi/mi-main.c (output_cores): Likewise.
2319         * nat/linux-osdata.c (linux_xfer_osdata_cpus): Likewise.
2320         (linux_xfer_osdata_modules): Likewise.
2321         * remote.c (register_remote_support_xml): Likewise.
2322         * sparc64-tdep.c (adi_is_addr_mapped): Likewise.
2323         * xml-syscall.c (syscall_create_syscall_desc): Likewise.
2324
2325 2019-11-06  Tom Tromey  <tom@tromey.com>
2326
2327         * tui/tui-interp.c: Don't include readline.h.
2328         * tui/tui-hooks.c: Don't include readline.h.
2329         * symmisc.c: Include tilde.h, not readline.h.
2330         * symfile.c: Include tilde.h, not readline.h.
2331         * source.c: Include tilde.h, not readline.h.
2332         * solib.c: Include tilde.h, not readline.h.
2333         * psymtab.c: Include tilde.h, not readline.h.
2334         * exec.c: Include tilde.h, not readline.h.
2335         * corelow.c: Include tilde.h, not readline.h.
2336         * cli/cli-dump.c: Include tilde.h, not readline.h.
2337         * cli/cli-cmds.c: Don't include readline.h.
2338
2339 2019-11-05  Tom Tromey  <tom@tromey.com>
2340
2341         * tui/tui-disasm.c (struct tui_asm_line) <addr_size>: New member.
2342         (tui_disassemble): Set addr_size.
2343         (tui_disasm_window::set_contents): Use addr_size.
2344
2345 2019-11-05  Tom Tromey  <tom@tromey.com>
2346
2347         * rust-lang.c (rust_language_defn): Update.
2348         * python/py-value.c (valpy_string): Call c_get_string.
2349         * p-lang.c (pascal_language_defn): Update.
2350         * opencl-lang.c (opencl_language_defn): Update.
2351         * objc-lang.c (objc_language_defn): Update.
2352         * m2-lang.c (m2_language_defn): Update.
2353         * language.c (unknown_language_defn, auto_language_defn): Update.
2354         (default_get_string): Remove.
2355         * guile/scm-value.c (gdbscm_value_to_string): Use c_get_string.
2356         * go-lang.c (go_language_defn): Update.
2357         * f-lang.c (f_language_defn): Update.
2358         * d-lang.c (d_language_defn): Update.
2359         * c-lang.c (c_language_defn, cplus_language_defn)
2360         (asm_language_defn, minimal_language_defn): Update.
2361         * ada-lang.c (ada_language_defn): Update.
2362         * language.h (struct language_defn) <la_get_string>: Remove.
2363         (LA_GET_STRING): Remove.
2364         (default_get_string): Don't declare.
2365
2366 2019-11-05  Tom Tromey  <tom@tromey.com>
2367
2368         * tui/tui-source.h (struct tui_source_window): Inline
2369         constructor.  Remove destructor.
2370         <style_changed, m_observable>: Move to superclass.
2371         * tui/tui-winsource.h (tui_copy_source_line): Declare.
2372         (struct tui_source_window_base): Move private members to end.
2373         <style_changed, m_observable>: Move from tui_source_window.
2374         * tui/tui-winsource.c (tui_copy_source_line): Move from
2375         tui-source.c.  Rename from copy_source_line.  Add special handling
2376         for negative line number.
2377         (tui_source_window_base::style_changed): Move from
2378         tui_source_window.
2379         (tui_source_window_base): Register observer.
2380         (~tui_source_window_base): New.
2381         * tui/tui-source.c (copy_source_line): Move to tui-winsource.c;
2382         rename.
2383         (tui_source_window::set_contents): Use tui_copy_source_line.
2384         (tui_source_window::tui_source_window): Move to tui-source.h.
2385         (tui_source_window::~tui_source_window): Remove.
2386         (tui_source_window::style_changed): Move to superclass.
2387         * tui/tui-disasm.c (tui_disassemble): Create string file with
2388         styling, when possible.  Add "addr_size" parameter.
2389         (tui_disasm_window::set_contents): Use tui_copy_source_line.
2390         Don't compute maximum size.
2391         (len_without_escapes): New function
2392
2393 2019-11-05  Tom Tromey  <tom@tromey.com>
2394
2395         * tui/tui-winsource.h (struct tui_source_element) <line>: Now a
2396         std::string.
2397         * tui/tui-winsource.c (tui_show_source_line): Update.
2398         * tui/tui-source.c (tui_source_window::set_contents): Update.
2399         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
2400
2401 2019-11-05  Christian Biesinger  <cbiesinger@google.com>
2402
2403         * symtab.h (gdb_static_assert): Put && operator at the beginning
2404         of the line instead of the end.
2405
2406 2019-11-04  Christian Biesinger  <cbiesinger@google.com>
2407
2408         * psympriv.h: Add static_asserts for sizeof (general_symbol_info)
2409         and sizeof (symbol).
2410         * symtab.h: Add a static_assert for sizeof (partial_symbol).
2411
2412 2019-11-04  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
2413
2414         * NEWS (Changes since GDB 8.3): Document Solaris 10 removal.
2415         * configure.host: Mark *-*-solaris2.10* obsolete.
2416         * configure.tgt: Mark Solaris < 11 obsolete.
2417         * MAINTAINERS (Target Instruction Set Architectures) <sparc>:
2418         Update target triplet.
2419
2420 2019-11-01  Tom Tromey  <tromey@adacore.com>
2421
2422         * utils.c (print_sys_errmsg): Simplify.
2423
2424 2019-11-01  Tom Tromey  <tromey@adacore.com>
2425
2426         * gdbsupport/mingw-strerror.c (safe_strerror): Constify result.
2427
2428 2019-11-01  Christian Biesinger  <cbiesinger@google.com>
2429
2430         * configure: Regenerate.
2431         * configure.ac: Remove check for strerror_r.
2432         * gdbsupport/common.m4: Check for strerror_r.
2433
2434 2019-11-01  Luis Machado  <luis.machado@linaro.org>
2435
2436         PR gdb/25124
2437
2438         * arm-tdep.c (arm_per_objfile): Rename to ...
2439         (arm_per_bfd): ... this.
2440         (arm_objfile_data_key): Rename to ...
2441         (arm_bfd_data_key): ... this.
2442         (arm_find_mapping_symbol): Adjust access to new bfd_key-based
2443         data.
2444         (arm_record_special_symbol): Likewise.
2445
2446 2019-10-31  Andrew Burgess  <andrew.burgess@embecosm.com>
2447
2448         * ada-typeprint.c (ada_print_typedef): Don't print newline at the
2449         end.
2450         * c-typeprint.c (c_print_typedef): Likewise.
2451         * f-typeprint.c (f_print_typedef): Likewise.
2452         * m2-typeprint.c (m2_print_typedef): Likewise.
2453         * p-typeprint.c (pascal_print_typedef): Likewise.
2454         * rust-lang.c (rust_print_typedef): Likewise.
2455         * symtab.c (print_symbol_info): Print a newline after calling
2456         typedef_print.
2457
2458 2019-10-31  Andrew Burgess  <andrew.burgess@embecosm.com>
2459
2460         * symtab.c (info_module_cmdlist): New variable.
2461         (info_module_command): New function.
2462         (search_module_symbols): New function.
2463         (info_module_subcommand): New function.
2464         (struct info_modules_var_func_options): New struct.
2465         (info_modules_var_func_options_defs): New variable.
2466         (make_info_modules_var_func_options_def_group): New function.
2467         (info_module_functions_command): New function.
2468         (info_module_variables_command): New function.
2469         (info_module_var_func_command_completer): New function.
2470         (_initialize_symtab): Register new 'info module functions' and
2471         'info module variables' commands.
2472         * symtab.h (typedef symbol_search_in_module): New typedef.
2473         (search_module_symbols): Declare new function.
2474         * NEWS: Mention new commands.
2475
2476 2019-10-31  Andrew Burgess  <andrew.burgess@embecosm.com>
2477
2478         * dwarf2read.c (dw2_symtab_iter_next): Handle MODULE_DOMAIN.
2479         (dw2_expand_marked_cus): Handle MODULES_DOMAIN.
2480         (dw2_debug_names_iterator::next): Handle MODULE_DOMAIN and
2481         MODULES_DOMAIN.
2482         (scan_partial_symbols): Only create partial module symbols for non
2483         declarations.
2484         * psymtab.c (recursively_search_psymtabs): Handle MODULE_DOMAIN
2485         and MODULES_DOMAIN.
2486         * symtab.c (search_domain_name): Likewise.
2487         (search_symbols): Likewise.
2488         (print_symbol_info): Likewise.
2489         (symtab_symbol_info): Likewise.
2490         (info_modules_command): New function.
2491         (_initialize_symtab): Register 'info modules' command.
2492         * symtab.h (enum search_domain): Add MODULES_DOMAIN.
2493         * NEWS: Mention new 'info modules' command.
2494
2495 2019-10-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2496
2497         * NEWS: Mention $_gdb_setting, $_gdb_setting_str, $_gdb_maint_setting
2498         and $_gdb_maint_setting_str.
2499
2500 2019-10-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2501
2502         * cli/cli-cmds.c (setting_cmd, value_from_setting)
2503         (gdb_setting_internal_fn, gdb_maint_setting_internal_fn)
2504         (str_value_from_setting, gdb_setting_str_internal_fn)
2505         (gdb_maint_setting_str_internal_fn): New functions.
2506         (_initialize_cli_cmds): Define the new convenience functions.
2507         * gdb/cli/cli-setshow.h (get_setshow_command_value_string): Constify.
2508         * gdb/cli/cli-setshow.c (get_setshow_command_value_string): Constify.
2509
2510 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
2511
2512         * agent.c (set_can_use_agent): When the setting is turned on,
2513         look up agent symbols if we don't have them yet.
2514         (agent_new_objfile): Don't look up agent symbols when the agent
2515         setting is off.
2516
2517 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
2518
2519         * config.in: Regenerate.
2520
2521 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
2522
2523         * configure: Regenerate.
2524         * configure.ac: Check for strerror_r.
2525         * gdbsupport/common-utils.h (safe_strerror): Change return value
2526         to const char * and document that this function is now threadsafe.
2527         * gdbsupport/posix-strerror.c (safe_strerror): Make buf
2528         thread_local and call strerror_r, if available.
2529         * utils.c (perror_string): Update.
2530         (print_sys_errmsg): Update.
2531
2532 2019-10-31  Luis Machado  <luis.machado@linaro.org>
2533
2534         * arm-tdep.c (arm_exidx_data_key): Use bfd_key instead of
2535         objfile_key.
2536         (arm_exidx_new_objfile): Adjust to use objfile->obfd instead of
2537         objfile to fetch per-bfd data.
2538         (arm_find_exidx_entry): Likewise.
2539
2540 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
2541
2542         * gdbsupport/agent.c (debug_agent): Change type to bool.
2543         (use_agent): Likewise.
2544         (all_agent_symbols_look_up): Likewise.
2545         (agent_loaded_p): Change return value to bool.
2546         (agent_look_up_symbols): Update.
2547         (agent_capability_check): Change return value to bool.
2548         * gdbsupport/agent.h (agent_loaded_p): Likewise.
2549         (debug_agent): Change type to bool.
2550         (use_agent): Likewise.
2551         (agent_capability_check): Change return value to bool.
2552
2553 2019-10-30  Christian Biesinger  <cbiesinger@google.com>
2554
2555         * minsyms.c (clear_minimal_symbol_hash_tables): New function.
2556         (build_minimal_symbol_hash_tables): Code to clear the table moved
2557         to clear_minimal_symbol_hash_tables.
2558         (minimal_symbol_reader::install): Call clear_minimal_symbol_hash_tables
2559         when needed.
2560
2561 2019-10-29  Simon Marchi  <simon.marchi@polymtl.ca>
2562
2563         * infcmd.c: Remove includes.
2564         * infrun.c: Remove includes.
2565
2566 2019-10-29  Simon Marchi  <simon.marchi@polymtl.ca>
2567
2568         * ada-lang.h (GROW_VECT): Move to ada-lang.c.
2569         (grow_vect): Remove declaration.
2570         (ada_type_of_array): Remove declaration.
2571         (ada_update_initial_language): Remove declaration.
2572         (ada_fold_name): Remove declaration.
2573         (ada_fill_in_ada_prototype): Remove declaration.
2574         (user_select_syms): Remove declaration.
2575         (get_selections): Remove declaration.
2576         (ada_tag_type): Remove declaration.
2577         (ada_value_tag): Remove declaration.
2578         (ada_is_others_clause): Remove declaration.
2579         (ada_in_variant): Remove declaration.
2580         (ada_value_struct_elt): Remove declaration.
2581         (ada_attribute_name): Remove declaration.
2582         (ada_system_address_type): Remove declaration.
2583         * ada-lang.c (ada_watch_location_expression): Make static.
2584         (GROW_VECT): Move here from ada-lang.h.
2585         (grow_vect): Make static.
2586         (ada_update_initial_language): Make static.
2587         (ada_fold_name): Make static.
2588         (ada_type_of_array): Make static.
2589         (encoded_ordered_before): Move up.
2590         (sort_choices): Move up.
2591         (print_signatures): Move up.
2592         (ada_print_symbol_signature): Move up.
2593         (get_selections): Move up and make static.
2594         (user_select_syms): Move up and make static.
2595         (ada_value_struct_elt): Move up and make static.
2596         (ada_tag_type): Make static.
2597         (ada_value_tag): Make static.
2598         (ada_is_others_clause): Make static.
2599         (ada_in_variant): Make static.
2600         (ada_attribute_name): Make static.
2601
2602 2019-10-29  Simon Marchi  <simon.marchi@polymtl.ca>
2603
2604         * ada-lang.c: Remove includes.
2605         * ada-typeprint.c: Remove includes.
2606         * ada-valprint.c: Remove includes.
2607
2608 2019-10-29  Simon Marchi  <simon.marchi@efficios.com>
2609
2610         * addrmap.c: Add static assertions of type size, moved from
2611         _initialize_addrmap.
2612         (_initialize_addrmap): Remove.
2613
2614 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
2615
2616         * coffread.c (record_minimal_symbol): Update.
2617         (process_coff_symbol): Update.
2618         * dbxread.c (read_dbx_symtab): Update.
2619         * dwarf2read.c (add_partial_symbol): Update.
2620         (fixup_go_packaging): Update.
2621         (load_partial_dies): Update.
2622         (new_symbol): Update.
2623         * elfread.c (record_minimal_symbol): Change signature to use
2624         gdb::string_view instead of name+len.
2625         (elf_symtab_read): Update.
2626         (elf_rel_plt_read): Update.
2627         * mdebugread.c (parse_partial_symbols): Update.
2628         (handle_psymbol_enumerators): Update.
2629         (new_symbol): Update.
2630         * minsyms.c (minimal_symbol_reader::record_full): Change signature
2631         to use gdb::string_view instead of name+len.
2632         * minsyms.h (class minimal_symbol_reader) <record_full>: Likewise.
2633         * psympriv.h (add_psymbol_to_list): Likewise.
2634         * psymtab.c (add_psymbol_to_bcache): Likewise.
2635         (add_psymbol_to_list): Likewise.
2636         * stabsread.c (define_symbol): Update.
2637         * symtab.c (symbol_set_names): Change signature to use gdb::string_view.
2638         * symtab.h (SYMBOL_SET_NAMES): Likewise.
2639         (symbol_set_names): Likewise.
2640         * xcoffread.c (scan_xcoff_symtab): Update.
2641
2642 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
2643
2644         * symtab.h (symbol_set_names): Document that copy_name must be
2645         set to true for non-nullterminated strings.
2646         * symtab.c (symbol_set_names): Only make a nullterminated copy of
2647         linkage_name if the entry was not found and we need to demangle.
2648
2649 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
2650
2651         * Makefile.in (HFILES_NO_SRCDIR): Add gdb_binary_search.h.
2652         * dwarf2-frame.c (bsearch_fde_cmp): Update.
2653         (dwarf2_frame_find_fde): Replace bsearch with gdb::binary_search.
2654         * gdbsupport/gdb_binary_search.h: New file.
2655
2656 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
2657
2658         * NEWS: Mention new --with-system-gdbinit-dir option.
2659         * config.in: Regenerate.
2660         * configure: Regenerate.
2661         * configure.ac: Add new option --with-system-gdbinit-dir.
2662         * extension.c (get_ext_lang_of_file): Return extension_language_gdb
2663         for a ".gdb" suffix.
2664         * main.c (get_init_files): Change system_gdbinit argument to
2665         a vector and return the files in SYSTEM_GDBINIT_DIR in
2666         addition to SYSTEM_GDBINIT.
2667         (captured_main_1): Update.
2668         (print_gdb_help): Update.
2669         * top.c (print_gdb_configuration): Also print the value of
2670         SYSTEM_GDBINIT_DIR.
2671
2672 2019-10-28  Christian Biesinger  <cbiesinger@google.com>
2673
2674         * gdbsupport/common-utils.h (startswith): Add an overloaded version
2675         that takes gdb::string_view arguments.
2676
2677 2019-10-26  Tom de Vries  <tdevries@suse.de>
2678
2679         * aarch64-linux-tdep.c: Fix typos in comments.
2680         * aarch64-tdep.c: Same.
2681         * ada-lang.c: Same.
2682         * amd64-nat.c: Same.
2683         * arc-tdep.c: Same.
2684         * arch/aarch64-insn.c: Same.
2685         * block.c: Same.
2686         * breakpoint.h: Same.
2687         * btrace.h: Same.
2688         * c-varobj.c: Same.
2689         * cli/cli-decode.c: Same.
2690         * cli/cli-script.c: Same.
2691         * cli/cli-utils.h: Same.
2692         * coff-pe-read.c: Same.
2693         * coffread.c: Same.
2694         * compile/compile-cplus-symbols.c: Same.
2695         * compile/compile-object-run.c: Same.
2696         * completer.c: Same.
2697         * corelow.c: Same.
2698         * cp-support.c: Same.
2699         * demangle.c: Same.
2700         * dwarf-index-write.c: Same.
2701         * dwarf2-frame.c: Same.
2702         * dwarf2-frame.h: Same.
2703         * eval.c: Same.
2704         * frame-base.h: Same.
2705         * frame.h: Same.
2706         * gdbcmd.h: Same.
2707         * gdbtypes.h: Same.
2708         * gnu-nat.c: Same.
2709         * guile/scm-objfile.c: Same.
2710         * i386-tdep.c: Same.
2711         * i386-tdep.h: Same.
2712         * infcall.c: Same.
2713         * infcall.h: Same.
2714         * linux-nat.c: Same.
2715         * m68k-tdep.c: Same.
2716         * macroexp.c: Same.
2717         * memattr.c: Same.
2718         * mi/mi-cmd-disas.c: Same.
2719         * mi/mi-getopt.h: Same.
2720         * mi/mi-main.c: Same.
2721         * minsyms.c: Same.
2722         * nat/aarch64-sve-linux-sigcontext.h: Same.
2723         * objfiles.h: Same.
2724         * ppc-linux-nat.c: Same.
2725         * ppc-linux-tdep.c: Same.
2726         * ppc-tdep.h: Same.
2727         * progspace.h: Same.
2728         * prologue-value.h: Same.
2729         * python/py-evtregistry.c: Same.
2730         * python/py-instruction.h: Same.
2731         * record-btrace.c: Same.
2732         * record-full.c: Same.
2733         * remote.c: Same.
2734         * rs6000-tdep.c: Same.
2735         * ser-tcp.c: Same.
2736         * sol-thread.c: Same.
2737         * sparc-sol2-tdep.c: Same.
2738         * sparc64-tdep.c: Same.
2739         * stabsread.c: Same.
2740         * symfile.c: Same.
2741         * symtab.h: Same.
2742         * target.c: Same.
2743         * tracepoint.c: Same.
2744         * tui/tui-data.h: Same.
2745         * tui/tui-io.c: Same.
2746         * tui/tui-win.c: Same.
2747         * tui/tui.c: Same.
2748         * unittests/rsp-low-selftests.c: Same.
2749         * user-regs.h: Same.
2750         * utils.c: Same.
2751         * utils.h: Same.
2752         * valarith.c: Same.
2753         * valops.c: Same.
2754         * valprint.c: Same.
2755         * valprint.h: Same.
2756         * value.c: Same.
2757         * value.h: Same.
2758         * varobj.c: Same.
2759         * x86-nat.h: Same.
2760         * xtensa-tdep.c: Same.
2761
2762 2019-10-25  Ali Tamur <tamur@google.com>
2763
2764         * charset.c (find_charset_names): Reflect API change.
2765
2766 2019-10-25  Christian Biesinger  <cbiesinger@google.com>
2767
2768         * symtab.c (struct demangled_name_entry): Change demangled name
2769         to a unique_xmalloc_ptr<char>, now that we don't allocate it as
2770         part of the struct anymore.
2771         (symbol_set_names): No longer obstack allocate + copy the demangled
2772         name, just store the allocated name from bfd.
2773
2774 2019-10-25  Tom Tromey  <tromey@adacore.com>
2775
2776         * dwarf2-frame.c (dwarf2_cie_table): Now a typedef.
2777         (bsearch_cie_cmp, add_cie): Remove.
2778         (find_cie): Reimplement.
2779         (decode_frame_entry_1, decode_frame_entry): Change type.  Update.
2780         (dwarf2_build_frame_info): Update.
2781
2782 2019-10-24  H.J. Lu  <hongjiu.lu@intel.com>
2783
2784         PR gdb/25126
2785         * symfile.c (reread_symbols): Call forget_cached_source_info to
2786         clear the stale source cache.
2787
2788 2019-10-24  Christian Biesinger  <cbiesinger@google.com>
2789
2790         * configure: Regenerate.
2791         * configure.ac: Remove code that sets python_has_threads.
2792
2793 2019-10-24  Christian Biesinger  <cbiesinger@google.com>
2794
2795         * config.in: Regenerate.
2796         * configure: Regenerate.
2797         * configure.ac: Remove the code that uses sed to get the python
2798         version and defines HAVE_LIBPYTHON2_6 / HAVE_LIBPYTHON2_7.
2799
2800 2019-10-24  Andrew Burgess  <andrew.burgess@embecosm.com>
2801
2802         * python/py-progspace.c (pspy_block_for_pc): Return None for all
2803         error paths.
2804
2805 2019-10-23  Tom Tromey  <tom@tromey.com>
2806
2807         * arc-tdep.c: Remove ".." from include.
2808         * frv-tdep.c: Remove ".." from include.
2809         * lm32-tdep.c: Remove ".." from include.
2810         * microblaze-tdep.c: Remove ".." from include.
2811         * or1k-tdep.h: Remove ".." from include.
2812         * s12z-tdep.c: Remove ".." from include.
2813         * Makefile.in (OPCODES_CFLAGS): Add comment.
2814         (TOP_CFLAGS): New variable.
2815         (INTERNAL_CFLAGS_BASE): Add TOP_CFLAGS.
2816
2817 2019-10-23  Tom Tromey  <tom@tromey.com>
2818
2819         * Makefile.in (READLINE_DIR): Update.
2820
2821 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
2822
2823         * infcall.c (call_function_by_hand_dummy): Fix the function
2824         comment.  And extract out a code section into...
2825         (reserve_stack_space): ...this new function.
2826
2827 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
2828
2829         * infcall.c (value_arg_coerce): Remove an unused parameter.
2830         (call_function_by_hand_dummy): Update the call to
2831         'value_arg_coerce'.
2832
2833 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
2834
2835         * infcall.c (call_function_by_hand_dummy): Refactor.
2836
2837 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
2838
2839         * MAINTAINERS (Write After Approval): Add Tankut Baris Aktemur.
2840
2841 2019-10-23  Tom Tromey  <tom@tromey.com>
2842
2843         * configure: Rebuild.
2844         * configure.ac: Don't check for sigprocmask.
2845         * gdbsupport/common.m4 (GDB_AC_COMMON): Check for sigprocmask.
2846
2847 2019-10-23  Tom Tromey  <tom@tromey.com>
2848
2849         * configure: Rebuild.
2850         * acinclude.m4: Use m4_include, not sinclude.
2851
2852 2019-10-23  Tom de Vries  <tdevries@suse.de>
2853
2854         PR breakpoints/24687
2855         * symtab.c (iterate_over_some_symtabs): Apply gdb_realpath on fullname.
2856
2857 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
2858
2859         * symtab.c (struct demangled_name_entry) <language>: Change from
2860         bitfield to regular variable.
2861
2862 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
2863
2864         * symtab.c (struct demangled_name_entry): Add a constructor.
2865         (free_demangled_name_entry): New function to call the destructor
2866         for demangled_name_entry.
2867         (create_demangled_names_hash): Pass free_demangled_name_entry to
2868         htab_create_alloc.
2869         (symbol_set_names): Call placement new for demangled_name_entry.
2870         * utils.c: No longer include xxhash.h here, now that fast_hash
2871         is inlined in the header.
2872         * utils.h: Instead, include it here.
2873
2874 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
2875
2876         * Makefile.in: Link with libxxhash.
2877         * config.in: Regenerate.
2878         * configure: Regenerate.
2879         * configure.ac: Search for libxxhash.
2880         * utils.c (fast_hash): Use xxhash if present.
2881
2882 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
2883
2884         * utils.h (fast_hash): New function.
2885         * symtab.c (hash_demangled_name_entry): Call new function
2886         fast_hash.
2887
2888 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
2889
2890         * symtab.c (struct demangled_name_entry): Change type of mangled
2891         to gdb::string_view. Also adds a constructor that takes the
2892         mangled name.
2893         (hash_demangled_name_entry): Update.
2894         (eq_demangled_name_entry): Update.
2895         (free_demangled_name_entry): New function to call the destructor
2896         now that this is not a POD anymore.
2897         (create_demangled_names_hash): Pass free_demangled_name_entry to
2898         htab_create_alloc.
2899         (symbol_set_names): Update.
2900
2901 2019-10-21  Ali Tamur  <tamu@google.com>
2902
2903         * dwarf2read.c (dir_index): Change type.
2904         (file_name_index): Likewise.
2905         (line_header::include_dir_at): Change comment and implementation on
2906         whether it is DWARF 5.
2907         (line_header::is_valid_file_index): New function.
2908         (line_header::file_name_at): Change comment and implementation on
2909         whether it is DWARF 5.
2910         (line_header::file_names): Change to private field renamed as
2911         m_file_names and introduce a new accessor method.
2912         (line_header::file_names_size): New method.
2913         (line_header::include_dirs): Change to private field and rename as
2914         m_include_dirs.
2915         (dw2_get_file_names_reader): Define local var at a smaller scope and
2916         reflect API change.
2917         (dwarf2_cu::setup_type_unit_groups): Reflect API change.
2918         (process_structure_scope): Likewise.
2919         (line_header::add_include_dir): Change message and reflect renaming.
2920         (line_header::add_file_name): Likewise.
2921         (read_formatted_entries): Handle DW_FORM_data16.
2922         (dwarf_decode_line_header): Fix line header length calculation.
2923         (psymtab_include_file_name): Change comment and API.
2924         (lnp_state_machine::m_file): Update comment and reflect type change.
2925         (lnp_state_machine::record_line): Reflect type change.
2926         (dwarf_decode_lines): Reflect API change.
2927         (file_file_name): Likewise.
2928         (file_full_name): Likewise.
2929
2930 2019-10-21  Andrew Burgess  <andrew.burgess@embecosm.com>
2931
2932         * objfiles.c (sort_cmp): Ensure that !(a < a) holds true.
2933
2934 2019-10-21  Tom Tromey  <tom@tromey.com>
2935
2936         * tui/tui-winsource.h (tui_exec_info_content): Remove typedef.
2937
2938 2019-10-21  Tom Tromey  <tom@tromey.com>
2939
2940         * configure.ac (nm.h): Conditionally create nm.h link.  Subst
2941         NM_H.   Use AC_CONFIG_LINKS.
2942         * configure: Rebuild.
2943         * Makefile.in (NM_H): New variable.
2944         (generated_files): Add NM_H.  Remove gcore.
2945         (nm.h, stamp-nmh): New targets.
2946
2947 2019-10-20  Tom Tromey  <tom@tromey.com>
2948
2949         * objfiles.h (unlink_objfile, put_objfile_before): Don't declare.
2950         * objfiles.c (unlink_objfile): Move earlier.  Now static.  Remove
2951         obsolete comment.
2952         (put_objfile_before): Now static.
2953
2954 2019-10-19  Simon Marchi  <simon.marchi@polymtl.ca>
2955
2956         * gdbsupport/common-utils.h (startswith): Change return type to
2957         bool.
2958
2959 2019-10-19  Christian Biesinger  <cbiesinger@google.com>
2960
2961         * bcache.c (bcache::print_statistics): Use std::sort instead of qsort.
2962         * breakpoint.c (bp_locations_compare): Rename to...
2963         (bp_location_is_less_than): ...this, and change to std::sort semantics.
2964         (update_global_location_list): Use std::sort instead of qsort.
2965         * buildsym.c (compare_line_numbers): Rename to...
2966         (lte_is_less_than): ...this, and change to std::sort semantics.
2967         (buildsym_compunit::end_symtab_with_blockvector): Use std::sort
2968         instead of qsort.
2969         * disasm.c (compare_lines): Rename to...
2970         (line_is_less_than): ...this, and change to std::sort semantics.
2971         (do_mixed_source_and_assembly_deprecated): Call std::sort instead
2972         of qsort.
2973         * dwarf2-frame.c (qsort_fde_cmp): Rename to...
2974         (fde_is_less_than): ...this, and change to std::sort semantics.
2975         (dwarf2_build_frame_info): Call std::sort instead of qsort.
2976         * mdebugread.c (compare_blocks):
2977         (block_is_less_than): ...this, and change to std::sort semantics.
2978         (sort_blocks): Call std::sort instead of qsort.
2979         * objfiles.c (qsort_cmp): Rename to...
2980         (sort_cmp): ...this, and change to std::sort semantics.
2981         (update_section_map): Call std::sort instead of qsort.
2982         * remote.c (compare_pnums): Remove.
2983         (map_regcache_remote_table): Call std::sort instead of qsort.
2984         * utils.c (compare_positive_ints): Remove.
2985         * utils.h (compare_positive_ints): Remove.
2986         * xcoffread.c (compare_lte): Remove.
2987         (arrange_linetable): Call std::sort instead of qsort.
2988
2989 2019-10-19  Sergio Durigan Junior  <sergiodj@redhat.com>
2990
2991         * symfile.c (init_entry_point_info): Fix typo.
2992         * i386-darwin-tdep.c (darwin_dwarf_signal_frame_p): Fix typo.
2993
2994 2019-10-18  Tom de Vries  <tdevries@suse.de>
2995
2996         * aarch64-tdep.c: Fix typos in comments.
2997         * ada-lang.c: Same.
2998         * ada-tasks.c: Same.
2999         * alpha-tdep.c: Same.
3000         * alpha-tdep.h: Same.
3001         * amd64-nat.c: Same.
3002         * amd64-windows-tdep.c: Same.
3003         * arc-tdep.c: Same.
3004         * arc-tdep.h: Same.
3005         * arch-utils.c: Same.
3006         * arm-nbsd-tdep.c: Same.
3007         * arm-tdep.c: Same.
3008         * ax-gdb.c: Same.
3009         * blockframe.c: Same.
3010         * btrace.c: Same.
3011         * c-varobj.c: Same.
3012         * coff-pe-read.c: Same.
3013         * coffread.c: Same.
3014         * cris-tdep.c: Same.
3015         * darwin-nat.c: Same.
3016         * dbxread.c: Same.
3017         * dcache.c: Same.
3018         * disasm.c: Same.
3019         * dtrace-probe.c: Same.
3020         * dwarf-index-write.c: Same.
3021         * dwarf2-frame-tailcall.c: Same.
3022         * dwarf2-frame.c: Same.
3023         * dwarf2read.c: Same.
3024         * eval.c: Same.
3025         * exceptions.c: Same.
3026         * fbsd-tdep.c: Same.
3027         * findvar.c: Same.
3028         * frame.c: Same.
3029         * frv-tdep.c: Same.
3030         * gnu-v3-abi.c: Same.
3031         * go32-nat.c: Same.
3032         * h8300-tdep.c: Same.
3033         * hppa-tdep.c: Same.
3034         * i386-linux-tdep.c: Same.
3035         * i386-tdep.c: Same.
3036         * ia64-libunwind-tdep.c: Same.
3037         * ia64-tdep.c: Same.
3038         * infcmd.c: Same.
3039         * infrun.c: Same.
3040         * linespec.c: Same.
3041         * linux-nat.c: Same.
3042         * linux-thread-db.c: Same.
3043         * machoread.c: Same.
3044         * mdebugread.c: Same.
3045         * mep-tdep.c: Same.
3046         * mn10300-tdep.c: Same.
3047         * namespace.c: Same.
3048         * objfiles.c: Same.
3049         * opencl-lang.c: Same.
3050         * or1k-tdep.c: Same.
3051         * osabi.c: Same.
3052         * ppc-linux-nat.c: Same.
3053         * ppc-linux-tdep.c: Same.
3054         * ppc-sysv-tdep.c: Same.
3055         * printcmd.c: Same.
3056         * procfs.c: Same.
3057         * record-btrace.c: Same.
3058         * record-full.c: Same.
3059         * remote-fileio.c: Same.
3060         * remote.c: Same.
3061         * rs6000-tdep.c: Same.
3062         * s12z-tdep.c: Same.
3063         * score-tdep.c: Same.
3064         * ser-base.c: Same.
3065         * ser-go32.c: Same.
3066         * skip.c: Same.
3067         * sol-thread.c: Same.
3068         * solib-svr4.c: Same.
3069         * solib.c: Same.
3070         * source.c: Same.
3071         * sparc-nat.c: Same.
3072         * sparc-sol2-tdep.c: Same.
3073         * sparc-tdep.c: Same.
3074         * sparc64-tdep.c: Same.
3075         * stabsread.c: Same.
3076         * stack.c: Same.
3077         * symfile.c: Same.
3078         * symtab.c: Same.
3079         * target-descriptions.c: Same.
3080         * target-float.c: Same.
3081         * thread.c: Same.
3082         * utils.c: Same.
3083         * valops.c: Same.
3084         * valprint.c: Same.
3085         * value.c: Same.
3086         * varobj.c: Same.
3087         * windows-nat.c: Same.
3088         * xcoffread.c: Same.
3089         * xstormy16-tdep.c: Same.
3090         * xtensa-tdep.c: Same.
3091
3092 2019-10-17  Tom Tromey  <tromey@adacore.com>
3093
3094         * configure: Rebuild.
3095         * configure.ac: Use AC_CONFIG_HEADERS.  Create stamp-h there, not
3096         in AC_CONFIG_FILES invocation.
3097         * Makefile.in (Makefile, data-directory/Makefile, stamp-h): Use
3098         new-style config.status invocation.
3099
3100 2019-10-17  Tom de Vries  <tdevries@suse.de>
3101
3102         * arm-nbsd-nat.c: Fix typos in comments.
3103         * arm-tdep.c: Same.
3104         * darwin-nat-info.c: Same.
3105         * dwarf2read.c: Same.
3106         * elfread.c: Same.
3107         * event-top.c: Same.
3108         * findvar.c: Same.
3109         * gdbtypes.c: Same.
3110         * hppa-tdep.c: Same.
3111         * i386-tdep.c: Same.
3112         * jit.c: Same.
3113         * main.c: Same.
3114         * mdebugread.c: Same.
3115         * moxie-tdep.c: Same.
3116         * nto-procfs.c: Same.
3117         * osabi.c: Same.
3118         * ppc-linux-tdep.c: Same.
3119         * remote.c: Same.
3120         * riscv-tdep.c: Same.
3121         * s390-tdep.c: Same.
3122         * sh-tdep.c: Same.
3123         * sparc-linux-tdep.c: Same.
3124         * sparc-nat.c: Same.
3125         * stack.c: Same.
3126         * target-descriptions.c: Same.
3127         * top.c: Same.
3128         * varobj.c: Same.
3129
3130 2019-10-16  Tom Tromey  <tom@tromey.com>
3131
3132         * objfiles.h (struct objfile) <original_name>: Now const.
3133
3134 2019-10-16  Christian Biesinger  <cbiesinger@google.com>
3135
3136         * gdbsupport/gdb_setjmp.h (SIGSETJMP): Allow passing in the value to
3137         pass on to sigsetjmp's second argument.
3138         * cp-support.c (gdb_demangle): Unblock SIGSEGV if we caught a crash.
3139
3140 2019-10-16  Keith Seitz  <keiths@redhat.com>
3141
3142         PR gdb/23567
3143         * dwarf2read.c (dwarf2_per_objfile::locate_sections): Discard
3144         sections whose size is greater than the file size.
3145
3146 2019-10-16  Jim Wilson  <jimw@sifive.com>
3147
3148         * riscv-tdep.c (riscv_gcc_target_options): New.
3149         (riscv_gnu_triplet_regexp): New.
3150         (riscv_gdbarch_init): Call set_gdbarch_gcc_triplet_options and
3151         set_gdbarch_gnu_triplet_regexp.
3152
3153 2019-10-16  Christian Biesinger  <cbiesinger@google.com>
3154
3155         * Makefile.in: Add xml-builtin.h.
3156         * features/feature_to_c.sh: Add an include for xml-builtin.h
3157         to ensure that the compiler checks that the types match.
3158         * xml-builtin.h: New file.
3159         * xml-support.c (fetch_xml_builtin): Add missing const.
3160         * xml-support.h: Remove declaration of xml_builtins.
3161
3162 2019-10-16  Tom de Vries  <tdevries@suse.de>
3163
3164         PR tdep/25096
3165         * amd64-tdep.c (amd64_classify_aggregate_field): Factor out of ...
3166         (amd64_classify_aggregate): ... here.
3167         (amd64_classify_aggregate_field): Handled fiels of nested structs
3168         recursively.
3169
3170 2019-10-16  Tom de Vries  <tdevries@suse.de>
3171
3172         PR tdep/24104
3173         * amd64-tdep.c (amd64_push_arguments): Handle AMD64_NO_CLASS in loop
3174         that handles 'theclass'.
3175
3176 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3177
3178         * linespec.c (decode_digits_ordinary): Update comment.
3179         * make-target-delegates: No longer need to handle VEC case.
3180         * memrange.c (normalize_mem_ranges): Update comment.
3181         * namespace.c (add_using_directive): Update comment.
3182         * objc-lang.c (uniquify_strings): Update comment.
3183         * ppc-linux-nat.c (struct thread_points): Update comment.
3184         * probe.h (find_probes_in_objfile): Update comment.
3185         * target.h (enum flash_preserve_mode): Update comment.
3186         * varobj.c (varobj_restrict_range): Update comment.
3187         * varobj.h (varobj_list_children): Update comment.
3188
3189 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3190
3191         * Makefile.in: Remove references to vec.h and vec.c.
3192         * aarch64-tdep.c: No longer include vec.h.
3193         * ada-lang.c: Likewise.
3194         * ada-lang.h: Likewise.
3195         * arm-tdep.c: Likewise.
3196         * ax.h: Likewise.
3197         * breakpoint.h: Likewise.
3198         * charset.c: Likewise.
3199         * cp-support.h: Likewise.
3200         * dtrace-probe.c: Likewise.
3201         * dwarf2read.c: Likewise.
3202         * extension.h: Likewise.
3203         * gdb_bfd.c: Likewise.
3204         * gdbsupport/gdb_vecs.h: Likewise.
3205         * gdbsupport/vec.c: Remove.
3206         * gdbsupport/vec.h: Remove.
3207         * gdbthread.h: Likewise.
3208         * guile/scm-type.c: Likewise.
3209         * inline-frame.c: Likewise.
3210         * machoread.c: Likewise.
3211         * memattr.c: Likewise.
3212         * memrange.h: Likewise.
3213         * namespace.h: Likewise.
3214         * nat/linux-btrace.h: Likewise.
3215         * osdata.c: Likewise.
3216         * parser-defs.h: Likewise.
3217         * progspace.h: Likewise.
3218         * python/py-type.c: Likewise.
3219         * record-btrace.c: Likewise.
3220         * rust-exp.y: Likewise.
3221         * solib-target.c: Likewise.
3222         * stap-probe.c: Likewise.
3223         * target-descriptions.c: Likewise.
3224         * target-memory.c: Likewise.
3225         * target.h: Likewise.
3226         * varobj.c: Likewise.
3227         * varobj.h: Likewise.
3228         * xml-support.h: Likewise.
3229
3230 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3231
3232         * gdb/dwarf2read.c (dwarf2_per_objfile::~dwarf2_per_objfile):
3233         Update for new std::vector based implementation.
3234         (process_psymtab_comp_unit_reader): Likewise.
3235         (scan_partial_symbols): Likewise.
3236         (recursively_compute_inclusions): Likewise.
3237         (compute_compunit_symtab_includes): Likewise.
3238         (process_imported_unit_die): Likewise.
3239         (queue_and_load_dwo_tu): Likewise.
3240         (follow_die_sig_1): Likewise.
3241         * gdb/dwarf2read.h: Remove DEF_VEC_P.
3242         (typedef dwarf2_per_cu_ptr): Remove.
3243         (struct dwarf2_per_cu_data) <imported_symtabs_empty>: New
3244         function.
3245         (struct dwarf2_per_cu_data) <imported_symtabs_push>: New function.
3246         (struct dwarf2_per_cu_data) <imported_symtabs_size>: New function.
3247         (struct dwarf2_per_cu_data) <imported_symtabs_free>: New function.
3248         (struct dwarf2_per_cu_data) <imported_symtabs>: Change to
3249         std::vector.
3250
3251 2019-10-15  Tom Tromey  <tromey@adacore.com>
3252
3253         * windows-nat.c (windows_nat_target::resume): Use %x when logging
3254         TID.
3255
3256 2019-10-15  Tom Tromey  <tromey@adacore.com>
3257
3258         * windows-nat.c (windows_nat_target::fetch_registers)
3259         (windows_nat_target::store_registers): Rename "pid" to "tid".
3260
3261 2019-10-15  Tom Tromey  <tromey@adacore.com>
3262
3263         * gdbarch.h, gdbarch.c: Rebuild.
3264         * gdbarch.sh (gcc_target_options): Change return type to
3265         std::string.
3266         * compile/compile.c (get_args): Update.
3267         * nios2-tdep.c (nios2_gcc_target_options): Return std::string.
3268         * arm-linux-tdep.c (arm_linux_gcc_target_options): Return
3269         std::string.
3270         * aarch64-linux-tdep.c (aarch64_linux_gcc_target_options): Return
3271         std::string.
3272         * arch-utils.c (default_gcc_target_options): Return std::string.
3273         * arch-utils.h (default_gcc_target_options): Return std::string.
3274         * s390-tdep.c (s390_gcc_target_options): Return std::string.
3275
3276 2019-10-15  Christian Biesinger  <cbiesinger@google.com>
3277
3278         * breakpoint.c (breakpoint_chain): Make static.
3279         * tui/tui-winsource.c: Call iterate_over_breakpoints instead
3280         of accessing breakpoint_chain.
3281
3282 2019-10-15  Christian Biesinger  <cbiesinger@google.com>
3283
3284         * breakpoint.c (iterate_over_breakpoints): Change function pointer
3285         to a gdb::function_view and return value to bool.
3286         * breakpoint.h (iterate_over_breakpoints): Likewise.
3287         * dummy-frame.c (pop_dummy_frame_bpt): Update.
3288         (pop_dummy_frame): Update.
3289         * guile/scm-breakpoint.c (bpscm_build_bp_list): Update.
3290         (gdbscm_breakpoints): Update.
3291         * python/py-breakpoint.c (build_bp_list): Update.
3292         (gdbpy_breakpoints): Update.
3293         * python/py-finishbreakpoint.c (bpfinishpy_detect_out_scope_cb):
3294         Update.
3295         (bpfinishpy_handle_stop): Update.
3296         (bpfinishpy_handle_exit): Update.
3297         * solib-svr4.c (svr4_update_solib_event_breakpoint): Update.
3298         (svr4_update_solib_event_breakpoints): Update.
3299
3300 2019-10-15  Andreas Arnez  <arnez@linux.ibm.com>
3301
3302         * s390-tdep.c (s390_effective_inner_type): Ignore static fields
3303         when unwrapping single-field structs.
3304
3305 2019-10-14  Simon Marchi  <simon.marchi@polymtl.ca>
3306
3307         * dwarf2read.c: Remove includes.
3308
3309 2019-10-13  Simon Marchi  <simon.marchi@polymtl.ca>
3310
3311         * ui-out.c (ui_out::call_do_message): Silence
3312         -Wformat-nonliteral warning.
3313
3314 2019-10-12  Simon Marchi  <simon.marchi@polymtl.ca>
3315
3316         * breakpoint.c: Remove some includes: continuations.h, skip.h,
3317         mi/mi-main.h, readline/readline.h, readline/history.h.  Add
3318         include: readline/tilde.h.
3319
3320 2019-10-12  Christian Biesinger  <cbiesinger@google.com>
3321
3322         * remote.c (remote_target::get_trace_status): Remove declaration of
3323         trace_regblock_size.
3324
3325 2019-10-12  Christian Biesinger  <cbiesinger@google.com>
3326
3327         * cli/cli-cmds.c (max_user_call_depth): Move comment to header.
3328         (show_user): Remove declaration of cmdlist.
3329         * cli/cli-cmds.h (max_user_call_depth): Declare.
3330         * cli/cli-script.c (execute_user_command): Remove declaration
3331         of max_user_call_depth.
3332
3333 2019-10-11  Jim Wilson  <jimw@sifive.com>
3334
3335         * gdbsupport/print-utils.h (pulongest): Fix comment.
3336         (plongest): Likewise.
3337         (phex): Add missing comment, mention leading zeros.
3338         (phex_nz): Add mention of no leading zeros to comment.
3339
3340         * riscv-tdep.c (riscv_push_dummy_code): Change %lld to %s and use
3341         plongest instead of unsigned long long cast.
3342
3343 2019-10-10  Christian Biesinger  <cbiesinger@google.com>
3344
3345         * main.c (captured_main_1): Include gdbtk.h and remove declarations
3346         for external_editor_command and gdbtk_test.
3347
3348 2019-10-10  Christian Biesinger  <cbiesinger@google.com>
3349
3350         * mi/mi-cmd-var.c (varobjdebug): Remove declaration.
3351         * varobj.c (varobjdebug): Move comment to...
3352         * varobj.h (varobjdebug): ...here, and declare.
3353
3354 2019-10-09  Tom Tromey  <tom@tromey.com>
3355
3356         * tui/tui-regs.c (tui_data_window::show_registers): Don't call
3357         erase_data_content.
3358
3359 2019-10-09  Tom Tromey  <tom@tromey.com>
3360
3361         * tui/tui-wingeneral.h (tui_delete_win): Don't declare.
3362         * tui/tui-stack.c (tui_locator_window::rerender): Update.
3363         * tui/tui-command.c (tui_cmd_window::resize)
3364         (tui_refresh_cmd_win): Update.
3365         * tui/tui-win.c (tui_resize_all, tui_set_focus_command): Update.
3366         * tui/tui.c (tui_rl_other_window, tui_enable): Update.
3367         * tui/tui-data.c (~tui_gen_win_info): Remove.
3368         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
3369         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
3370         (tui_redisplay_readline, tui_mld_flush)
3371         (tui_mld_erase_entire_line, tui_mld_getc, tui_getc): Update.
3372         * tui/tui-regs.c (tui_data_window::delete_data_content_windows)
3373         (tui_data_window::erase_data_content)
3374         (tui_data_item_window::rerender)
3375         (tui_data_item_window::refresh_window): Update.
3376         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window)
3377         (box_win, tui_gen_win_info::make_window)
3378         (tui_gen_win_info::make_visible): Update.
3379         (tui_delete_win): Remove.
3380         * tui/tui-winsource.c
3381         (tui_source_window_base::do_erase_source_content): Update.
3382         (tui_show_source_line, tui_source_window_base::update_tab_width)
3383         (tui_source_window_base::update_exec_info): Update.
3384         * tui/tui-data.h (struct curses_deleter): New.
3385         (struct tui_gen_win_info) <handle>: Now a unique_ptr.
3386         (struct tui_gen_win_info) <~tui_gen_win_info>: Define.
3387
3388 2019-10-09  Tom Tromey  <tom@tromey.com>
3389
3390         * tui/tui-wingeneral.h (struct tui_gen_win_info): Don't declare.
3391
3392 2019-10-09  Tom Tromey  <tom@tromey.com>
3393
3394         * tui/tui-data.c (tui_win_is_auxiliary): Remove.
3395         * tui/tui-data.h (tui_win_is_auxiliary): Don't declare.
3396
3397 2019-10-09  Tom Tromey  <tom@tromey.com>
3398
3399         * tui/tui-disasm.c (tui_get_low_disassembly_address): Compute
3400         window height directly.
3401         * tui/tui-layout.h (tui_default_win_viewport_height): Don't
3402         declare.
3403         * tui/tui-layout.c (tui_default_win_height): Remove.
3404         (tui_default_win_viewport_height): Remove.
3405
3406 2019-10-09  Tom Tromey  <tom@tromey.com>
3407
3408         * tui/tui.h: Remove comments.
3409
3410 2019-10-09  Tom de Vries  <tdevries@suse.de>
3411
3412         * python/lib/gdb/printer/bound_registers.py: Use
3413         '^builtin_type_bound128' as regexp argument for
3414         add_builtin_pretty_printer.
3415
3416 2019-10-09  Christian Biesinger  <cbiesinger@google.com>
3417
3418         * guile/guile.c (guile_extension_script_ops): Remove forward
3419         declaration and mark as static.
3420         (guile_script_ops): Likewise.
3421         (extension_language_guile): Move further down in the file so
3422         it can reference the definitions for guile_{extension_,}script_ops.
3423
3424 2019-10-09  Andreas Arnez  <arnez@linux.ibm.com>
3425
3426         * s390-tdep.c (390_process_record): Handle new arch13 instructions
3427         except SORTL, DFLTCC, and KDSA.
3428
3429 2019-10-08  Tom Tromey  <tromey@adacore.com>
3430
3431         * windows-nat.c (struct windows_thread_info_struct) <sf>: Remove.
3432         (struct safe_symbol_file_add_args): Remove.
3433
3434 2019-10-08  Tom Tromey  <tromey@adacore.com>
3435
3436         * windows-nat.c: Don't include buildsym-legacy.h.
3437
3438 2019-10-08  Tom Tromey  <tromey@adacore.com>
3439
3440         * contrib/ari/gdb_ari.sh (%p): Allow gdb-specific %p extensions.
3441
3442 2019-10-08  Christian Biesinger  <cbiesinger@google.com>
3443
3444         * gdbtypes.c (overload_debug): Move comment to header.
3445         * gdbtypes.h (overload_debug): Declare.
3446         * valops.c: Remove declaration of overload_debug, instead
3447         include gdbtypes.h.
3448
3449 2019-10-08  Christian Biesinger  <cbiesinger@google.com>
3450
3451         * language.c (show_language_command): Pass lang_frame_mismatch_warn
3452         through _().
3453         (lang_frame_mismatch_warn): Make const, mark with N_(), and
3454         move comment...
3455         * language.h (lang_frame_mismatch_warn): ... here. Also add
3456         declaration.
3457         * top.c (lang_frame_mismatch_warn): Remove declaration.
3458         (check_frame_language_change): Pass lang_frame_mismatch_warn
3459         through _().
3460
3461 2019-10-07  Christian Biesinger  <cbiesinger@google.com>
3462
3463         * c-lang.h (vtbl_ptr_name): Declare.
3464         * cp-valprint.c (vtbl_ptr_name): Remove "extern" now that we get
3465         it from the header.
3466         * stabsread.c (define_symbol): Remove declaration of vtbl_ptr_name.
3467
3468 2019-10-07  Christian Biesinger  <cbiesinger@google.com>
3469
3470         * charset.c (your_gdb_wchar_t_is_bogus): Replace with a
3471         gdb_static_assert.
3472
3473 2019-10-07  Weimin Pan  <weimin.pan@oracle.com>
3474
3475         * ../Makefile.def (dependencies): Add all-libctf to all-gdb
3476         * ../Makefile.in: Add "all-gdb: maybe-all-libctf"
3477         * ctfread.c: New file.
3478         * ctfread.h: New file.
3479         * elfread.c: Include ctfread.h.
3480         (struct elfinfo text_p): New member ctfsect.
3481         (elf_locate_sections): Mark CTF section.
3482         (elf_symfile_read): Call elfctf_build_psymtabs.
3483         * Makefile.in (LIBCTF): Add.
3484         (CLIBS): Use it.
3485         (CDEPS): Likewise.
3486         (DIST): Add ctfread.c.
3487
3488 2019-10-07  Andrew Burgess  <andrew.burgess@embecosm.com>
3489
3490         * ctfread.c (struct nextfield): Renamed to ...
3491         (struct ctf_nextfield): ... this.
3492         (struct field_info): Renamed to ...
3493         (strut ctf_field_info): ... this.
3494         (attach_fields_to_type): Update for renamed structures.
3495         (ctf_add_member_cb): Likewise.
3496         (ctf_add_enum_member_cb): Likewise.
3497         (process_struct_members): Likewise.
3498         (process_enum_type): Likewise.
3499
3500 2019-10-07  Weimin Pan  <weimin.pan@oracle.com>
3501
3502         * tracectf.h: Rename, was ctf.h.
3503         * tracectf.c: Rename, was ctf.c, replace ctf.h with tracectf.h.
3504         * tracefile.c: Likewise.
3505         * tracepoint.c: Remove unused include ctf.h.
3506         * mi/mi-main.c: Likewise.
3507         * Makefile.in Replace ctf.c with tracectf.c.
3508
3509 2019-10-06  Joel Brobecker  <brobecker@adacore.com>
3510
3511         * version.in: Change version number to "9.0.50.DATE-git".
3512
3513 2019-10-03  Tom Tromey  <tom@tromey.com>
3514
3515         PR rust/24976:
3516         * dwarf2read.c (quirk_rust_enum): Handle single-element unions.
3517
3518 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3519
3520         * f-lang.c (f_language_defn): Use cp_get_symbol_name_matcher and
3521         cp_search_name_hash.
3522         * NEWS: Add entry about nested function support.
3523
3524 2019-10-03  Bernhard Heckel  <bernhard.heckel@intel.com>
3525             Andrew Burgess  <andrew.burgess@embecosm.com>
3526
3527         * cp-namespace.c (cp_search_static_and_baseclasses): Only search
3528         for nested static variables when searchin VAR_DOMAIN.
3529         * dwarf2read.c (add_partial_symbol): Add nested subroutines to the
3530         global scope, update comment.
3531         (add_partial_subprogram): Call add_partial_subprogram recursively
3532         for nested subroutines when processinng Fortran.
3533         (load_partial_dies): Process the child entities of a subprogram
3534         when processing Fortran.
3535         (partial_die_parent_scope): Handle building scope
3536         for Fortran nested functions.
3537         (process_die): Record that nested functions have a scope.
3538         (new_symbol): Always record Fortran subprograms on the global
3539         symbol list.
3540         (determine_prefix): How to build the prefix for Fortran
3541         subprograms.
3542
3543 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3544
3545         * linux-nat.c (linux_nat_filter_event): Don't ignore SIGSTOP if we
3546         have just sent the thread a SIGSTOP and are waiting for it to
3547         arrive.
3548
3549 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3550
3551         * btrace.c (btrace_add_pc): Remove whitespace before the template
3552         parameter in 'std::vector <...>'.
3553         (parse_xml_btrace_block): Likewise.
3554         (btrace_maint_decode_pt): Likewise.
3555         (btrace_maint_update_packets): Likewise.
3556         (btrace_maint_print_packets): Likewise.
3557         * btrace.h (struct btrace_maint_info): Likewise.
3558         * dwarf2read.c (struct type_unit_group): Likewise.
3559         (build_type_psymtabs_reader): Likewise.
3560         * gdbsupport/btrace-common.c (btrace_data_append): Likewise.
3561         * gdbsupport/btrace-common.h (struct btrace_data_bts): Likewise.
3562         * nat/linux-btrace.c (perf_event_read_bts): Likewise.
3563
3564 2019-10-03  Tom de Vries  <tdevries@suse.de>
3565
3566         * cli/cli-style.c (_initialize_cli_style): Adding a '.' at the end of
3567         the first line of the help text for set/show style metadata.
3568
3569 2019-10-02  Tom Tromey  <tromey@adacore.com>
3570
3571         * Makefile.in (COMMON_SFILES): Add common-inferior.c.
3572         * gdbsupport/common-inferior.c: New file.
3573         * infcmd.c (startup_with_shell): Don't define.
3574         * nat/fork-inferior.h (startup_with_shell): Don't declare.
3575         * gdbsupport/common-inferior.h (startup_with_shell): Declare.
3576         * inferior.h (startup_with_shell): Don't declare.
3577
3578 2019-10-02  Christian Biesinger  <cbiesinger@google.com>
3579
3580         * gdbsupport/gdb_assert.h: Include errors.h.
3581         * gdbsupport/gdb_string_view.h: Include gdb_assert.h.
3582
3583 2019-10-02  Tom Tromey  <tromey@adacore.com>
3584
3585         * NEWS: Add $_ada_exception entry.
3586         * ada-lang.c (struct ada_catchpoint): Add constructor.
3587         <m_kind>: New member.
3588         (allocate_location_exception, re_set_exception): Remove
3589         "ex" parameter.
3590         (should_stop_exception): Compute $_ada_exception.
3591         (check_status_exception, print_it_exception)
3592         (print_one_exception, print_mention_exception): Remove
3593         "ex" parameter.
3594         (allocate_location_catch_exception, re_set_catch_exception)
3595         (check_status_exception, print_it_catch_exception)
3596         (print_one_catch_exception, print_mention_catch_exception)
3597         (print_recreate_catch_exception)
3598         (allocate_location_catch_exception_unhandled)
3599         (re_set_catch_exception_unhandled)
3600         (check_status_exception, print_it_catch_exception_unhandled)
3601         (print_one_catch_exception_unhandled)
3602         (print_mention_catch_exception_unhandled)
3603         (print_recreate_catch_exception_unhandled)
3604         (allocate_location_catch_assert, re_set_catch_assert)
3605         (check_status_assert, print_it_catch_assert)
3606         (print_one_catch_assert, print_mention_catch_assert)
3607         (print_recreate_catch_assert)
3608         (allocate_location_catch_handlers, re_set_catch_handlers)
3609         (check_status_handlers, print_it_catch_handlers)
3610         (print_one_catch_handlers, print_mention_catch_handlers)
3611         (print_recreate_catch_handlers): Remove.
3612         (create_ada_exception_catchpoint): Update.
3613         (initialize_ada_catchpoint_ops): Update.
3614
3615 2019-10-02  Tom Tromey  <tromey@adacore.com>
3616
3617         * ada-lang.c (ada_lookup_simple_minsyms): Remove.
3618         (create_excep_cond_exprs): Simplify exception string computation.
3619         (ada_exception_catchpoint_cond_string): Likewise.
3620
3621 2019-10-02  Tom Tromey  <tromey@adacore.com>
3622
3623         * symmisc.c (dump_msymbols): Don't use MSYMBOL_VALUE_ADDRESS.
3624         * ada-lang.c (lesseq_defined_than): Handle
3625         LOC_STATIC.
3626         * dwarf2read.c (dwarf2_per_objfile): Add can_copy
3627         parameter.
3628         (dwarf2_has_info): Likewise.
3629         (new_symbol): Set maybe_copied on symbol when
3630         appropriate.
3631         * dwarf2read.h (dwarf2_per_objfile): Add can_copy
3632         parameter.
3633         <can_copy>: New member.
3634         * elfread.c (record_minimal_symbol): Set maybe_copied
3635         on symbol when appropriate.
3636         (elf_symfile_read): Update call to dwarf2_has_info.
3637         * minsyms.c (lookup_minimal_symbol_linkage): New
3638         function.
3639         * minsyms.h (lookup_minimal_symbol_linkage): Declare.
3640         * symtab.c (get_symbol_address, get_msymbol_address):
3641         New functions.
3642         * symtab.h (get_symbol_address, get_msymbol_address):
3643         Declare.
3644         (SYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_ADDRESS): Handle
3645         maybe_copied.
3646         (struct symbol, struct minimal_symbol) <maybe_copied>:
3647         New member.
3648
3649 2019-10-02  Tom Tromey  <tromey@adacore.com>
3650
3651         * source.c (struct current_source_location): New.
3652         (current_source_key): New global.
3653         (current_source_symtab, current_source_line)
3654         (current_source_pspace): Remove.
3655         (get_source_location): New function.
3656         (get_current_source_symtab_and_line)
3657         (set_default_source_symtab_and_line)
3658         (set_current_source_symtab_and_line)
3659         (clear_current_source_symtab_and_line, select_source_symtab)
3660         (info_source_command, print_source_lines_base)
3661         (info_line_command, search_command_helper, _initialize_source):
3662         Update.
3663
3664 2019-10-02  Tom Tromey  <tromey@adacore.com>
3665
3666         * source.c (select_source_symtab): Don't call
3667         decode_line_with_current_source.
3668
3669 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3670
3671         * symtab.c (lookup_global_symbol): Search global block.
3672
3673 2019-10-02  Tom Tromey  <tromey@adacore.com>
3674
3675         * coffread.c (process_coff_symbol): Update.
3676         * dwarf2read.c (var_decode_location, new_symbol): Update.
3677         * mdebugread.c (parse_symbol): Update.
3678         * objfiles.c (relocate_one_symbol): Update.
3679         * stabsread.c (define_symbol, fix_common_block)
3680         (scan_file_globals): Update.
3681         * symtab.h (SYMBOL_VALUE_ADDRESS): Expand to an rvalue.
3682         (SET_SYMBOL_VALUE_ADDRESS): New macro.
3683         * xcoffread.c (process_xcoff_symbol): Update.
3684
3685 2019-10-02  Andreas Arnez  <arnez@linux.ibm.com>
3686
3687         * MAINTAINERS: Update my email address.
3688
3689 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3690
3691         * dwarf2read.c (struct type_unit_group) <tus>: Convert to
3692         std::vector.
3693         (build_type_psymtabs_reader): Update for std::vector.
3694         (build_type_psymtab_dependencies): Likewise.
3695         * dwarf2read.h: Remove use of DEF_VEC_P.
3696         (typedef sig_type_ptr): Delete.
3697
3698 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3699
3700         * btrace.c (btrace_maint_clear): Update to handle change from VEC
3701         to std::vector.
3702         (btrace_maint_decode_pt): Likewise, and move allocation of the
3703         vector outside of the loop.
3704         (btrace_maint_update_packets): Update to handle change from VEC to
3705         std::vector.
3706         (btrace_maint_print_packets): Likewise.
3707         (maint_info_btrace_cmd): Likewise.
3708         * btrace.h: Remove use of DEF_VEC_O.
3709         (typedef btrace_pt_packet_s): Delete.
3710         (struct btrace_maint_info) <packets>: Change fromm VEC to
3711         std::vector.
3712         * gdbsupport/btrace-common.h: Remove 'vec.h' include.
3713
3714 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3715
3716         * btrace.c (btrace_compute_ftrace_bts): Update for std::vector,
3717         make accesses into the vector constant references.
3718         (btrace_add_pc): Update for std::vector.
3719         (btrace_stitch_bts): Likewise.
3720         (parse_xml_btrace_block): Likewise.
3721         (btrace_maint_update_packets): Likewise.
3722         (btrace_maint_print_packets): Likewise.
3723         (maint_info_btrace_cmd): Likewise.
3724         * gdbsupport/btrace-common.c (btrace_data::fini): Update for
3725         std::vector.
3726         (btrace_data::empty): Likewise.
3727         (btrace_data_append): Likewise.
3728         * gdbsupport/btrace-common.h: Remove use of DEF_VEC_O.
3729         (typedef btrace_block_s): Delete.
3730         (struct btrace_block): Add constructor.
3731         (struct btrace_data_bts) <blocks>: Change to std::vector.
3732         * nat/linux-btrace.c (perf_event_read_bts): Update for
3733         std::vector.
3734         (linux_read_bts): Likewise.
3735
3736 2019-10-01  Tom Tromey  <tom@tromey.com>
3737
3738         * cli/cli-logging.c (show_logging_filename): Use styled_string.
3739
3740 2019-10-01  Tom Tromey  <tom@tromey.com>
3741
3742         * stack.c (print_frame, info_frame_command_core): Use
3743         styled_string.
3744         * linux-thread-db.c (try_thread_db_load_1)
3745         (try_thread_db_load_from_pdir_1): Use styled_string.
3746         * auto-load.c (file_is_auto_load_safe, execute_script_contents)
3747         (auto_load_section_scripts, info_auto_load_local_gdbinit)
3748         (maybe_print_unsupported_script_warning)
3749         (maybe_print_script_not_found_warning): Use styled_string.
3750         * ada-lang.c (user_select_syms): Use styled_string.
3751
3752 2019-10-01  Tom Tromey  <tom@tromey.com>
3753
3754         * p-lang.c (pascal_printstr): Use metadata style.
3755         * value.c (show_convenience): Use metadata style.
3756         * valprint.c (valprint_check_validity, val_print_optimized_out)
3757         (val_print_not_saved, val_print_unavailable)
3758         (val_print_invalid_address, generic_val_print, val_print)
3759         (value_check_printable, val_print_array_elements): Use metadata
3760         style.
3761         * ui-out.h (class ui_out) <field_fmt>: New overload.
3762         <do_field_fmt>: Add style parameter.
3763         * ui-out.c (ui_out::field_fmt): New overload.
3764         * typeprint.c (type_print_unknown_return_type)
3765         (val_print_not_allocated, val_print_not_associated): Use metadata
3766         style.
3767         * tui/tui-out.h (class tui_ui_out) <do_field_fmt>: Add style
3768         parameter.
3769         * tui/tui-out.c (tui_ui_out::do_field_fmt): Update.
3770         * tracepoint.c (tvariables_info_1): Use metadata style.
3771         * stack.c (print_frame_arg, print_frame_info, print_frame)
3772         (info_frame_command_core): Use metadata style.
3773         * skip.c (info_skip_command): Use metadata style.
3774         * rust-lang.c (rust_print_enum): Use metadata style.
3775         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
3776         metadata style.
3777         * python/py-framefilter.c (py_print_single_arg): Use metadata
3778         style.
3779         * printcmd.c (do_one_display, print_variable_and_value): Use
3780         metadata style.
3781         * p-valprint.c (pascal_val_print)
3782         (pascal_object_print_value_fields): Use metadata style.
3783         * p-typeprint.c (pascal_type_print_base): Use metadata style.
3784         * mi/mi-out.h (class mi_ui_out) <do_field_fmt>: Add style
3785         parameter.
3786         * mi/mi-out.c (mi_ui_out::do_field_fmt): Update.
3787         * m2-valprint.c (m2_print_long_set): Use metadata style.
3788         * m2-typeprint.c (m2_print_type): Use metadata style.
3789         * infcmd.c (print_return_value_1): Use metadata style.
3790         * gnu-v3-abi.c (print_one_vtable): Use metadata style.
3791         * f-valprint.c (info_common_command_for_block): Use metadata
3792         style.
3793         * f-typeprint.c (f_type_print_base): Use metadata style.
3794         * expprint.c (print_subexp_standard): Use metadata style.
3795         * cp-valprint.c (cp_print_value_fields): Use metadata style.
3796         * cli/cli-style.h (class cli_style_option): Add constructor.
3797         (metadata_style): Declare.
3798         * cli/cli-style.c (metadata_style): New global.
3799         (_initialize_cli_style): Register metadata style.
3800         * cli-out.h (class cli_ui_out) <do_field_fmt>: Add style
3801         parameter.
3802         * cli-out.c (cli_ui_out::do_field_fmt): Update.
3803         * c-typeprint.c (c_type_print_base_struct_union)
3804         (c_type_print_base_1): Use metadata style.
3805         * breakpoint.c (watchpoint_value_print)
3806         (print_one_breakpoint_location): Use metadata style.
3807         * break-catch-syscall.c (print_one_catch_syscall): Use metadata
3808         style.
3809         * break-catch-sig.c (signal_catchpoint_print_one): Use metadata
3810         style.
3811         * ada-valprint.c (val_print_packed_array_elements, printstr)
3812         (print_field_values, ada_val_print_ref, ada_val_print): Use
3813         metadata style.
3814         * ada-typeprint.c (print_array_type, ada_print_type): Use metadata
3815         style.
3816         * ada-tasks.c (print_ada_task_info, info_task): Use metadata
3817         style.
3818         * ada-lang.c (user_select_syms): Use metadata style.
3819
3820 2019-10-01  Tom Tromey  <tom@tromey.com>
3821
3822         * cli/cli-cmds.c (pwd_command): Style output.
3823
3824 2019-10-01  Pedro Alves  <palves@redhat.com>
3825             Tom Tromey  <tom@tromey.com>
3826
3827         * symtab.c (print_symbol_info): Use %ps.
3828         (print_msymbol_info): Use %ps.
3829         * symfile.c (symbol_file_add_with_addrs): Use %ps.
3830         * printcmd.c (print_variable_and_value): Use %ps.
3831         * macrocmd.c (show_pp_source_pos): Use %ps.
3832         * infrun.c (print_exited_reason): Use ui_out::message.
3833         * breakpoint.c (watchpoint_check, print_one_breakpoint_location)
3834         (describe_other_breakpoints): Use ui_out::message and new
3835         formats.
3836         (say_where): Use new formats.
3837         (bkpt_print_it, tracepoint_print_one_detail): Use ui_out::message
3838         and new formats.
3839
3840 2019-10-01  Pedro Alves  <palves@redhat.com>
3841             Tom Tromey  <tom@tromey.com>
3842
3843         * unittests/format_pieces-selftests.c: Add gdb_format parameter.
3844         (test_gdb_formats): New function.
3845         (run_tests): Call it.
3846         (test_format_specifier): Update.
3847         * utils.h (fputs_filtered): Update comment.
3848         (vfprintf_styled, vfprintf_styled_no_gdbfmt)
3849         (fputs_styled_unfiltered): Declare.
3850         * utils.c (fputs_styled_unfiltered): New function.
3851         (vfprintf_maybe_filtered): Add gdbfmt parameter.
3852         (vfprintf_filtered): Update.
3853         (vfprintf_unfiltered, vprintf_filtered): Update.
3854         (vfprintf_styled, vfprintf_styled_no_gdbfmt): New functions.
3855         * ui-out.h (enum ui_out_flag) <unfiltered_output,
3856         disallow_ui_out_field>: New constants.
3857         (enum class field_kind): New.
3858         (struct base_field_s, struct signed_field_s): New.
3859         (signed_field): New function.
3860         (struct string_field_s): New.
3861         (string_field): New function.
3862         (struct styled_string_s): New.
3863         (styled_string): New function.
3864         (class ui_out) <message>: Add comment.
3865         <vmessage, call_do_message>: New methods.
3866         <do_message>: Add style parameter.
3867         * ui-out.c (ui_out::call_do_message, ui_out::vmessage): New
3868         methods.
3869         (ui_out::message): Rewrite.
3870         * mi/mi-out.h (class mi_ui_out) <do_message>: Add style
3871         parameter.
3872         * mi/mi-out.c (mi_ui_out::do_message): Add style parameter.
3873         * gdbsupport/format.h (class format_pieces) <format_pieces>: Add
3874         gdb_extensions parameter.
3875         (class format_piece): Add parameter to constructor.
3876         (n_int_args): New field.
3877         * gdbsupport/format.c (format_pieces::format_pieces): Add
3878         gdb_extensions parameter.  Handle '*'.
3879         * cli-out.h (class cli_ui_out) <do_message>: Add style parameter.
3880         * cli-out.c (cli_ui_out::do_message): Add style parameter.  Call
3881         vfprintf_styled_no_gdbfmt.
3882         (cli_ui_out::do_field_string, cli_ui_out::do_spaces)
3883         (cli_ui_out::do_text, cli_ui_out::field_separator): Allow
3884         unfiltered output.
3885         * ui-style.h (struct ui_file_style) <ptr>: New method.
3886
3887 2019-10-01  Tom Tromey  <tom@tromey.com>
3888
3889         * unittests/format_pieces-selftests.c: Update.  Add final format.
3890         * gdbsupport/format.c (format_pieces::format_pieces): Don't add
3891         empty literal pieces.
3892
3893 2019-10-01  Tom Tromey  <tom@tromey.com>
3894
3895         * ui-out.h (enum class ui_out_style_kind): Remove.
3896         (class ui_out) <field_string, field_stsream, do_field_string>:
3897         Change type of "style".
3898         * ui-out.c (ui_out::field_core_addr, ui_out::field_stream)
3899         (ui_out::field_string): Update.
3900         * tui/tui-out.h (class tui_ui_out) <do_field_string>: Change type
3901         of "style".
3902         * tui/tui-out.c (tui_ui_out::do_field_string): Update.
3903         * tracepoint.c (print_one_static_tracepoint_marker): Update.
3904         * stack.c (print_frame_arg, print_frame_info, print_frame):
3905         Update.
3906         * source.c (print_source_lines_base): Update.
3907         * solib.c (info_sharedlibrary_command): Update.
3908         * skip.c (info_skip_command): Update.
3909         * record-btrace.c (btrace_call_history_src_line)
3910         (btrace_call_history): Update.
3911         * python/py-framefilter.c (py_print_frame): Update.
3912         * mi/mi-out.h (class mi_ui_out) <do_field_string>: Change type of
3913         "style".
3914         * mi/mi-out.c (mi_ui_out::do_table_header)
3915         (mi_ui_out::do_field_signed, mi_ui_out::do_field_unsigned)
3916         (mi_ui_out::do_field_string): Update.
3917         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
3918         Update.
3919         * cli-out.h (class cli_ui_out) <do_field_string>: Change type of
3920         "style".
3921         * cli-out.c (cli_ui_out::do_table_header)
3922         (cli_ui_out::do_field_signed, cli_ui_out::do_field_unsigned)
3923         (cli_ui_out::do_field_skip, cli_ui_out::do_field_string)
3924         (cli_ui_out::do_field_fmt): Update.
3925         * breakpoint.c (print_breakpoint_location): Update.
3926         (update_static_tracepoint): Update.
3927
3928 2019-10-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3929
3930         * main.c (relocate_gdbinit_path_maybe_in_datadir): Remove std::string
3931         conversion of gdb_datadir.
3932         (captured_main_1): Remove xstrdup when assigning to gdb_datadir,
3933         remove not needed c_str ().
3934
3935 2019-09-30  Ali Tamur <tamur@google.com>
3936
3937         * dwarf2read.c (skip_one_die): Handle DW_FORM_strx forms.
3938         (dwarf2_string_attr): Likewise.
3939
3940 2019-09-30  Ali Tamur <tamur@google.com>
3941
3942         * dwarf2read.c (process_full_comp_unit): Remove whitespace at the EOL.
3943         (process_full_type_unit): Likewise.
3944         (dump_die_shallow): Likewise.
3945         (cu_debug_loc_section): Likewise.
3946
3947 2019-09-28  Christian Biesinger  <cbiesinger@google.com>
3948
3949         * minsyms.c (compare_minimal_symbols): Rename to...
3950         (minimal_symbol_is_less_than): ...this, and adjust to STL
3951         conventions (return bool, take arguments as references)
3952         (minimal_symbol_reader::install): Call std::sort instead
3953         of qsort.
3954
3955 2019-09-29  Christian Biesinger  <cbiesinger@google.com>
3956
3957         * minsyms.h (msymbol_hash): Document that this is a case-insensitive
3958         hash and why.
3959         * objfiles.h (struct objfile_per_bfd_storage) <demangled_names_hash,
3960         msymbol_hash, msymbol_demangled_hash>: Improve comments.
3961
3962 2019-09-30  Simon Marchi  <simon.marchi@polymtl.ca>
3963
3964         * psymtab.c (add_psymbol_to_list): Move comment to psympriv.h.
3965         * psympriv.h (add_psymbol_to_list): Move comment here and update
3966         it.
3967
3968 2019-09-29  Tom de Vries  <tdevries@suse.de>
3969
3970         * contrib/cc-with-tweaks.sh (get_tmpdir): New function.
3971         Use $tmpdir/$(basename "$output_file").dwz instead of
3972         "${output_file}.dwz".
3973
3974 2019-09-28  Simon Marchi  <simon.marchi@polymtl.ca>
3975
3976         PR gdb/25045
3977         * hppa-linux-nat.c: Include gdbarch.h.
3978
3979 2019-09-26  Christian Biesinger  <cbiesinger@google.com>
3980
3981         * blockframe.c (find_pc_partial_function): Change return type to bool.
3982         * elfread.c (elf_gnu_ifunc_resolve_name): Likewise.
3983         * minsyms.c (in_gnu_ifunc_stub): Likewise.
3984         (stub_gnu_ifunc_resolve_name): Likewise.
3985         * symtab.c (compare_filenames_for_search): Likewise.
3986         (compare_glob_filenames_for_search): Likewise.
3987         (matching_obj_sections): Likewise.
3988         (symbol_matches_domain): Likewise.
3989         (find_line_symtab): Change out param EXACT_MATCH to bool *.
3990         (find_line_pc): Change return type to bool.
3991         (find_line_pc_range): Likewise.
3992         (producer_is_realview): Likewise.
3993         * symtab.h (symbol_matches_domain): Likewise.
3994         (find_pc_partial_function): Likewise.
3995         (find_pc_line_pc_range): Likewise.
3996         (in_gnu_ifunc_stub): Likewise.
3997         (struct gnu_ifunc_fns) <gnu_ifunc_resolve_name>: Likewise.
3998         (find_line_pc): Likewise.
3999         (find_line_pc_range): Likewise.
4000         (matching_obj_sections): Likewise.
4001         (find_line_symtab): Change out parameter to bool.
4002         (producer_is_realview): Change return type to bool.
4003         (compare_filenames_for_search): Likewise.
4004         (compare_glob_filenames_for_search): Likewise.
4005
4006 2019-09-26  Tom Tromey  <tom@tromey.com>
4007
4008         * Makefile.in (COMMON_SFILES): Remove gdb_usleep.c.
4009         (HFILES_NO_SRCDIR): Remove gdb_usleep.h.
4010         * gdb_usleep.h: Remove.
4011         * gdb_usleep.c: Remove.
4012         * utils.c: Don't include gdb_usleep.h.
4013
4014 2019-09-26  Tom Tromey  <tromey@adacore.com>
4015
4016         * python/py-type.c (type_to_type_object): Call check_typedef
4017         for stub types.
4018
4019 2019-09-26  Tom Tromey  <tom@tromey.com>
4020
4021         * utils.h (initialize_utils): Don't declare.
4022         * top.c (gdb_init): Don't call initialize_utils.
4023         * utils.c (initialize_utils): Remove.  Move contents...
4024         (_initialize_utils): ... here.
4025
4026 2019-09-25  Tom Tromey  <tom@tromey.com>
4027
4028         * python/py-objfile.c (objfpy_get_build_id): Use bin2hex.
4029         * utils.h (make_hex_string): Don't declare.
4030         * utils.c (make_hex_string): Remove.
4031
4032 2019-09-24  Tom de Vries  <tdevries@suse.de>
4033
4034         PR gdb/23815
4035         * amd64-linux-nat.c (amd64_linux_nat_target::fetch_registers):
4036         Initialize xstateregs before ptrace PTRACE_GETREGSET call.
4037
4038 2019-09-23  Dimitar Dimitrov  <dimitar@dinux.eu>
4039
4040         * NEWS: Mention new simulator port for PRU.
4041
4042 2019-09-23  Christian Biesinger  <cbiesinger@google.com>
4043
4044         * ada-exp.y (write_object_remaining): Update.
4045         * ada-lang.c (ada_decode): Return a std::string instead of a char*
4046         and eliminate the static buffer.
4047         (ada_decode_symbol): Update.
4048         (ada_la_decode): Update.
4049         (ada_sniff_from_mangled_name): Update.
4050         (is_valid_name_for_wild_match): Update.
4051         (ada_lookup_name_info::matches): Update and simplify.
4052         (name_matches_regex): Update.
4053         (ada_add_global_exceptions): Update.
4054         * ada-lang.h (ada_decode): Update signature.
4055         * ada-varobj.c (ada_varobj_describe_simple_array_child): Update.
4056         * dwarf-index-write.c (debug_names::insert): Update.
4057
4058 2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>
4059
4060         * solib-svr4.c (svr4_iterate_over_objfiles_in_search_order): Fix
4061         formatting.
4062
4063 2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>
4064
4065         * breakpoint.h (bp_location) <inserted, permanent, duplicate>:
4066         Change "nonzero" to "true" in documentation.
4067
4068 2019-09-20  Christian Biesinger  <cbiesinger@google.com>
4069
4070         * solib-darwin.c (darwin_lookup_lib_symbol): Remove.
4071         (_initialize_darwin_solib): Don't set
4072         darwin_so_ops.lookup_lib_global_symbol.
4073         * solib-svr4.c (set_solib_svr4_fetch_link_map_offsets): Call
4074         set_gdbarch_iterate_over_objfiles_in_search_order.
4075         (elf_lookup_lib_symbol): Rename to...
4076         (svr4_iterate_over_objfiles_in_search_order): this, and update
4077         to iterate semantics.
4078         (_initialize_svr4_solib): Don't set lookup_lib_global_symbol.
4079         * solib.c (solib_global_lookup): Remove.
4080         * solist.h (struct target_so_ops): Remove lookup_lib_global_symbol.
4081         (solib_global_lookup): Remove.
4082         * symtab.c (lookup_global_or_static_symbol): Remove call to
4083         solib_global_lookup.
4084
4085 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
4086
4087         * NEWS: Move entries about default MI version now being
4088         version 3, and about the GDB/MI fix for multi-location
4089         breakpoints to the "since GDB 8.3" section.
4090
4091 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
4092
4093         GDB 8.3.1 released.
4094
4095 2019-09-20  Ulrich Weigand  <uweigand@de.ibm.com>
4096
4097         * NEWS: Mention that Cell/B.E. debugging support was removed.
4098         * MAINTAINERS: Remove spu target.
4099
4100         * config/djgpp/fnchange.lst: Remove entries for removed files.
4101
4102         * Makefile.in (ALL_TARGET_OBS): Remove solib-spu.o,
4103         spu-multiarch.o, and spu-tdep.o.
4104         (HFILES_NO_SRCDIR): Remove solib-spu.h and spu-tdep.h.
4105         (ALLDEPFILES): Remove solib-spu.c, spu-linux-nat.c,
4106         spu-multiarch.c, and spu-tdep.c.
4107         * spu-linux-nat.c: Remove file.
4108         * spu-multiarch.c: Remove file.
4109         * spu-tdep.c: Remove file.
4110         * spu-tdep.h: Remove file.
4111         * solib-spu.c: Remove file.
4112         * solib-spu.h: Remove file.
4113
4114         * configure.host (powerpc64*-*-linux*): Remove Cell/B.E. support.
4115         * configure.nat (spu-linux): Remove.
4116         * configure.tgt (powerpc*-*-linux*): Remove solib-spu.o and
4117         solib-multiarch.o from gdb_target_obs.
4118         (spu*-*-*): Remove.
4119
4120         * arch/ppc-linux-common.h (struct ppc_linux_features): Remove "cell"
4121         feature flag.
4122         (ppc_linux_no_features): Update.
4123         * arch/ppc-linux-common.c (ppc_linux_match_description): Remove
4124         Cell/B.E. support.
4125         * arch/ppc-linux-tdesc.h (tdesc_powerpc_cell32l): Remove declaration.
4126         (tdesc_powerpc_cell64l): Likewise.
4127         * nat/ppc-linux.h (PPC_FEATURE_CELL): Remove.
4128         * ppc-linux-nat.c (ppc_linux_nat_target::read_description): Remove
4129         Cell/B.E. support.
4130         * ppc-linux-tdep.h: Do not include "solib-spu.h" or "spu-tdep.h".
4131         Do not include "features/rs6000/powerpc-cell32l.c" or
4132         "features/rs6000/powerpc-cell64l.c".
4133         (ppc_linux_spu_section): Remove.
4134         (ppc_linux_core_read_description): Remove Cell/B.E. support.
4135         (spe_context_objfile, spe_context_lm_addr, spe_context_offset,
4136         spe_context_cache_ptid, spe_context_cache_ptid): Remove.
4137         (ppc_linux_spe_context_lookup): Remove.
4138         (ppc_linux_spe_context_inferior_created): Remove.
4139         (ppc_linux_spe_context_solib_loaded): Remove.
4140         (ppc_linux_spe_context_solib_unloaded): Remove.
4141         (ppc_linux_spe_context): Remove.
4142         (struct ppu2spu_cache): Remove.
4143         (ppu2spu_prev_arch, ppu2spu_this_id, ppu2spu_prev_register): Remove.
4144         (struct ppu2spu_data): Remove.
4145         (ppu2spu_unwind_register, ppu2spu_sniffer, ppu2spu_dealloc_cache,
4146         ppu2spu_unwind): Remove.
4147         (ppc_linux_init_abi): Remove Cell/B.E. support.
4148         * rs6000-tdep.h (rs6000_gdbarch_init): Remove Cell/B.E. support.
4149
4150         * features/Makefile (rs6000/powerpc-cell32l-expedite): Remove.
4151         (rs6000/powerpc-cell64l-expedite): Likewise
4152         (WHICH): Remove rs6000/powerpc-cell32l and rs6000/powerpc-cell64l.
4153         (XMLTOC): Remove rs6000/powerpc-cell32l.xml and
4154         rs6000/powerpc-cell64l.xml.
4155         * features/rs6000/powerpc-cell32l.xml: Remove.
4156         * features/rs6000/powerpc-cell64l.xml: Likewise.
4157         * features/rs6000/powerpc-cell32l.c: Remove generated file.
4158         * features/rs6000/powerpc-cell64l.c: Likewise.
4159         * regformats/rs6000/powerpc-cell32l.dat: Remove generated file.
4160         * regformats/rs6000/powerpc-cell64l.dat: Likewise.
4161         * regformats/reg-spu.dat: Remove.
4162
4163         * target.h (enum target_object): Remove TARGET_OBJECT_SPU.
4164         * corelow.c (struct spuid_list): Remove.
4165         (add_to_spuid_list): Remove.
4166         (core_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
4167         * remote.c (PACKET_qXfer_spu_read, PACKET_qXfer_spu_write): Remove.
4168         (remote_protocol_features): Remove associated entries.
4169         (_initialize_remote): No longer initialize them.
4170         (remote_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
4171         * linux-nat.c (SPUFS_MAGIC): Remove.
4172         (linux_proc_xfer_spu): Remove.
4173         (spu_enumerate_spu_ids): Remove.
4174         (linux_nat_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
4175         * linux-tdep.c (-linux_spu_make_corefile_notes): Remove.
4176         (linux_make_corefile_notes): No longer call it.
4177
4178         * regcache.c (cooked_read_test): Remove bfd_arch_spu special case.
4179         (cooked_write_test): Likewise.
4180
4181 2019-09-20  Tom Tromey  <tom@tromey.com>
4182
4183         * NEWS: Mention case-sensitivity of TUI commands.
4184         * tui/tui-win.c (tui_set_focus_command): Now case-sensitive.
4185         (tui_set_win_height_command, parse_scrolling_args): Likewise.
4186         * tui/tui-layout.c (tui_layout_command): Now case-sensitive.
4187
4188 2019-09-20  Tom Tromey  <tom@tromey.com>
4189
4190         * tui/tui-source.c (tui_source_window::set_contents): Use
4191         make_unique_xstrdup.
4192         * tui/tui-disasm.c (tui_disasm_window::set_contents): Use
4193         make_unique_xstrdup.
4194
4195 2019-09-20  Tom Tromey  <tom@tromey.com>
4196
4197         * tui/tui-data.c: Remove separator comments.
4198         * tui/tui-layout.c: Remove separator comments.
4199         * tui/tui-win.c: Remove separator comments.
4200         * tui/tui-wingeneral.c: Remove separator comments.
4201
4202 2019-09-20  Tom Tromey  <tom@tromey.com>
4203
4204         * tui/tui.h (strcat_to_buf): Don't declare.
4205         * tui/tui.c (strcat_to_buf): Remove.
4206
4207 2019-09-20  Tom Tromey  <tom@tromey.com>
4208
4209         * tui/tui-source.h (struct tui_source_window) <m_fullname>: Rename
4210         from "fullname".
4211         * tui/tui-source.c (tui_source_window::set_contents)
4212         (tui_source_window::location_matches_p)
4213         (tui_source_window::maybe_update): Update.
4214
4215 2019-09-20  Tom Tromey  <tom@tromey.com>
4216
4217         * tui/tui-regs.h (struct tui_data_window) <get_current_group>:
4218         Update.
4219         <m_regs_content, m_regs_column_count, m_current_group>: Add "m_"
4220         prefix.
4221         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
4222         (tui_data_window::line_from_reg_element_no)
4223         (tui_data_window::first_reg_element_no_inline)
4224         (tui_data_window::show_registers)
4225         (tui_data_window::show_register_group)
4226         (tui_data_window::display_registers_from)
4227         (tui_data_window::display_registers_from_line)
4228         (tui_data_window::first_data_item_displayed)
4229         (tui_data_window::delete_data_content_windows)
4230         (tui_data_window::erase_data_content)
4231         (tui_data_window::do_scroll_vertical)
4232         (tui_data_window::refresh_window)
4233         (tui_data_window::check_register_values): Update.
4234
4235 2019-09-20  Tom Tromey  <tom@tromey.com>
4236
4237         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN): Remove define.
4238         (struct tui_locator_window) <full_name, proc_name>: Now
4239         std::string.
4240         * tui/tui-stack.c (tui_locator_window::make_status_line)
4241         (tui_locator_window::set_locator_fullname)
4242         (tui_locator_window::set_locator_info): Update.
4243         * tui/tui-source.c (tui_source_window::set_contents)
4244         (tui_source_window::showing_source_p): Update.
4245
4246 2019-09-20  Tom Tromey  <tom@tromey.com>
4247
4248         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
4249         Don't call tui_locator_win_info_ptr.
4250
4251 2019-09-20  Tom Tromey  <tom@tromey.com>
4252
4253         * tui/tui-win.c (tui_resize_all): Don't call refresh.
4254
4255 2019-09-20  Tom Tromey  <tom@tromey.com>
4256
4257         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use 1 as
4258         height for locator.
4259         * tui/tui-stack.c (tui_locator_window::rerender): Call scrollok.
4260         * tui/tui-layout.c (show_source_disasm_command, show_data)
4261         (show_source_or_disasm_and_command): Use 1 as height for locator.
4262
4263 2019-09-20  Tom Tromey  <tom@tromey.com>
4264
4265         * tui/tui.c (tui_enable): Update.
4266         * tui/tui-win.c (tui_sigwinch_handler, tui_async_resize_screen):
4267         Update.
4268         * tui/tui-data.h (tui_win_resized, tui_set_win_resized_to):
4269         Update.
4270         * tui/tui-data.c (win_resized): Now bool.
4271         (tui_win_resized): Return bool.
4272         (tui_set_win_resized_to): Accept a bool.
4273
4274 2019-09-20  Tom Tromey  <tom@tromey.com>
4275
4276         * tui/tui-regs.h (struct tui_data_window) <show_register_group>:
4277         Change type of "refresh_values_only".
4278         * tui/tui-regs.c (tui_data_window::show_register_group): Change
4279         type of "refresh_values_only".
4280
4281 2019-09-20  Tom Tromey  <tom@tromey.com>
4282
4283         * tui/tui-disasm.c (struct tui_asm_line) <addr_string, insn>: Now
4284         std::string.
4285         (tui_disassemble): Add "pos" parameter.
4286         (tui_disasm_window::set_contents): Simplify.
4287
4288 2019-09-20  Tom Tromey  <tom@tromey.com>
4289
4290         * tui/tui-winsource.h (struct tui_source_window_base)
4291         <show_source_content>: Now private.
4292         * tui/tui-winsource.c
4293         (tui_source_window_base::show_source_content): Don't handle empty
4294         content case.
4295
4296 2019-09-20  Tom Tromey  <tom@tromey.com>
4297
4298         * tui/tui-layout.c (show_source_disasm_command)
4299         (show_source_or_disasm_and_command): Don't call
4300         show_source_content.
4301
4302 2019-09-20  Tom Tromey  <tom@tromey.com>
4303
4304         * tui/tui-stack.h (struct tui_locator_window) <make_status_line>:
4305         Declare.
4306         * tui/tui-stack.c (tui_locator_window::make_status_line): Rename
4307         from tui_make_status_line.
4308         (tui_locator_window::rerender): Update.
4309
4310 2019-09-20  Tom Tromey  <tom@tromey.com>
4311
4312         * tui/tui-stack.c (tui_make_status_line): Return std::string.
4313         (tui_locator_window::rerender): Update.
4314
4315 2019-09-20  Tom Tromey  <tom@tromey.com>
4316
4317         * tui/tui-winsource.h (struct tui_source_window_base)
4318         <~tui_source_window_base>: Don't declare.
4319         <fullname>: Remove.
4320         * tui/tui-winsource.c (~tui_source_window_base): Remove.
4321         * tui/tui-source.h (struct tui_source_window) <fullname>: New
4322         member.
4323         * tui/tui-source.c (tui_source_window::set_contents): Update.
4324         (tui_source_window::location_matches_p)
4325         (tui_source_window::maybe_update): Update.
4326
4327 2019-09-20  Tom Tromey  <tom@tromey.com>
4328
4329         * tui/tui-winsource.h (~tui_source_element): Remove.
4330         (tui_source_element): Update.
4331         (struct tui_source_element) <line>: Now a unique_xmalloc_ptr.
4332         * tui/tui-winsource.c (tui_show_source_line): Update.
4333         * tui/tui-source.c (tui_source_window::set_contents): Update.
4334         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
4335
4336 2019-09-20  Tom Tromey  <tom@tromey.com>
4337
4338         * tui/tui-data.h (tui_clear_source_windows_detail): Don't
4339         declare.
4340         * tui/tui-layout.c (tui_add_win_to_layout): Don't call
4341         tui_clear_source_windows_detail.
4342         * tui/tui-winsource.h (struct tui_source_window_base)
4343         <clear_detail>: Don't declare.
4344         * tui/tui-winsource.c (tui_source_window_base::clear_detail):
4345         Remove.
4346         * tui/tui-data.c (tui_clear_source_windows_detail): Remove.
4347
4348 2019-09-20  Tom Tromey  <tromey@adacore.com>
4349
4350         PR ada/24919:
4351         * block.c (contained_in): Fix final return value.
4352
4353 2019-09-20  Alan Modra  <amodra@gmail.com>
4354
4355         * gdb_bfd.c (gdb_bfd_ref, gdb_bfd_unref): Use bfd_set_usrdata.
4356         * dwarf2read.c (dwarf2_read_gdb_index, dwarf2_read_debug_names),
4357         (read_indirect_string_from_dwz): Use bfd accessor.
4358         * dwarf2read.h (struct dwz_file <filename>): Likewise.
4359         * machoread.c (macho_symfile_read_all_oso): Likewise.
4360         * solib.c (solib_bfd_open): Likewise.
4361
4362 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
4363
4364         * eval.c: Move declaration of overload_resolution to...
4365         * value.h: ...here.
4366
4367 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
4368
4369         * arm-linux-nat.c: Remove extern declaration for arm_apcs_32.
4370         * arm-linux-tdep.c: Likewise.
4371         * arm-nbsd-nat.c: Likewise.
4372         * arm-tdep.h: Declare arm_apcs_32.
4373         * arm-tdep.c: Move documentation for arm_apcs_32 to arm-tdep.h.
4374
4375 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
4376
4377         * dwarf2loc.c: Remove extern declaration of dwarf_always_disassemble.
4378         * dwarf2read.h: Declare dwarf_always_disassemble.
4379
4380 2019-09-19  Tom de Vries  <tdevries@suse.de>
4381
4382         PR gdb/25009
4383         * source-cache.c (source_cache::ensure): Catch exception thrown during
4384         construction of the highlighter.
4385
4386 2019-09-18  Alan Modra  <amodra@gmail.com>
4387
4388         * aarch64-linux-tdep.c, * arm-tdep.c, * auto-load.c,
4389         * coff-pe-read.c, * coffread.c, * corelow.c, * dbxread.c,
4390         * dicos-tdep.c, * dwarf2-frame.c, * dwarf2read.c, * elfread.c,
4391         * exec.c, * fbsd-tdep.c, * gcore.c, * gdb_bfd.c, * gdb_bfd.h,
4392         * hppa-tdep.c, * i386-cygwin-tdep.c, * i386-fbsd-tdep.c,
4393         * i386-linux-tdep.c, * jit.c, * linux-tdep.c, * machoread.c,
4394         * maint.c, * mdebugread.c, * minidebug.c, * mips-linux-tdep.c,
4395         * mips-sde-tdep.c, * mips-tdep.c, * mipsread.c, * nto-tdep.c,
4396         * objfiles.c, * objfiles.h, * osabi.c, * ppc-linux-tdep.c,
4397         * ppc64-tdep.c, * record-btrace.c, * record-full.c, * remote.c,
4398         * rs6000-aix-tdep.c, * rs6000-tdep.c, * s390-linux-tdep.c,
4399         * s390-tdep.c, * solib-aix.c, * solib-dsbt.c, * solib-frv.c,
4400         * solib-spu.c, * solib-svr4.c, * solib-target.c,
4401         * spu-linux-nat.c, * spu-tdep.c, * symfile-mem.c, * symfile.c,
4402         * symmisc.c, * symtab.c, * target.c, * windows-nat.c,
4403         * xcoffread.c, * cli/cli-dump.c, * compile/compile-object-load.c,
4404         * mi/mi-interp.c: Update throughout for bfd section macro and
4405         function changes.
4406         * gcore (gcore_create_callback): Use bfd_set_section_lma.
4407         * spu-tdep.c (spu_overlay_new_objfile): Likewise.
4408
4409 2019-09-18  Tom Tromey  <tom@tromey.com>
4410
4411         * NEWS: Add entry.
4412         * tui/tui.c (tui_initialize_readline): Set name of keymap.  Do not
4413         call rl_initialize.
4414         (tui_enable): Do not call rl_initialize.
4415
4416 2019-09-18  Christian Groessler  <chris@groessler.org>
4417
4418         * alpha-linux-nat.c: Include gdbarch.h.
4419
4420 2019-09-18  Simon Marchi  <simon.marchi@polymtl.ca>
4421
4422         * ui-file.c: Include cli/cli-style.h.
4423         (term_cli_styling): Remove cli_styling declaration.
4424
4425 2019-09-18  Alan Modra  <amodra@gmail.com>
4426
4427         * arm-tdep.c (arm_record_special_symbol): Update bfd_get_section
4428         to bfd_asymbol_section.
4429
4430 2019-09-18  Alan Modra  <amodra@gmail.com>
4431
4432         * amd64-dicos-tdep.c (amd64_dicos_osabi_sniffer): Constify target.
4433         * i386-cygwin-tdep.c (i386_cygwin_init_abi): Likewise.
4434         * i386-dicos-tdep.c (i386_dicos_osabi_sniffer): Likewise.
4435
4436 2019-09-18  Alan Modra  <amodra@gmail.com>
4437
4438         * solib-spu.c (spu_bfd_open): Use bfd_set_filename.
4439         * spu-linux-nat.c (spu_bfd_open): Likewise.
4440
4441 2019-09-18  Christian Biesinger  <cbiesinger@google.com>
4442
4443         * dwarf2loc.c: Change extern declaration of dwarf_always_disassemble
4444         to bool to match definition in dwarf2read.c.
4445
4446 2019-09-17  Christian Biesinger  <cbiesinger@google.com>
4447
4448         * ada-lang.c (ada_ignore_descriptive_types_p): Change to bool.
4449         (print_signatures): Likewise.
4450         (trust_pad_over_xvs): Likewise.
4451         * arch/aarch64-insn.c (aarch64_debug): Likewise.
4452         * arch/aarch64-insn.h (aarch64_debug): Likewise.
4453         * arm-linux-nat.c (arm_apcs_32): Likewise.
4454         * arm-linux-tdep.c (arm_apcs_32): Likewise.
4455         * arm-nbsd-nat.c (arm_apcs_32): Likewise.
4456         * arm-tdep.c (arm_debug): Likewise.
4457         (arm_apcs_32): Likewise.
4458         * auto-load.c (debug_auto_load): Likewise.
4459         (auto_load_gdb_scripts): Likewise.
4460         (global_auto_load): Likewise.
4461         (auto_load_local_gdbinit): Likewise.
4462         (auto_load_local_gdbinit_loaded): Likewise.
4463         * auto-load.h (global_auto_load): Likewise.
4464         (auto_load_local_gdbinit): Likewise.
4465         (auto_load_local_gdbinit_loaded): Likewise.
4466         * breakpoint.c (disconnected_dprintf): Likewise.
4467         (breakpoint_proceeded): Likewise.
4468         (automatic_hardware_breakpoints): Likewise.
4469         (always_inserted_mode): Likewise.
4470         (target_exact_watchpoints): Likewise.
4471         (_initialize_breakpoint): Update.
4472         * breakpoint.h (target_exact_watchpoints): Change to bool.
4473         * btrace.c (maint_btrace_pt_skip_pad): Likewise.
4474         * cli/cli-cmds.c (trace_commands): Likewise.
4475         * cli/cli-cmds.h (trace_commands): Likewise.
4476         * cli/cli-decode.c (add_setshow_boolean_cmd): Change int* argument
4477         to bool*.
4478         * cli/cli-logging.c (logging_overwrite): Change to bool.
4479         (logging_redirect): Likewise.
4480         (debug_redirect): Likewise.
4481         * cli/cli-option.h (option_def) <boolean>: Change return type to bool*.
4482         (struct boolean_option_def) <get_var_address_cb_>: Change return type
4483         to bool.
4484         <boolean_option_def>: Update.
4485         (struct flag_option_def): Change default type of Context to bool
4486         from int.
4487         <flag_option_def>: Change return type of var_address_cb_ to bool*.
4488         * cli/cli-setshow.c (do_set_command): Cast to bool* instead of int*.
4489         (get_setshow_command_value_string): Likewise.
4490         * cli/cli-style.c (cli_styling): Change to bool.
4491         (source_styling): Likewise.
4492         * cli/cli-style.h (source_styling): Likewise.
4493         (cli_styling): Likewise.
4494         * cli/cli-utils.h (struct qcs_flags) <quiet, cont, silent>: Change
4495         to bool.
4496         * command.h (var_types): Update comment.
4497         (add_setshow_boolean_cmd): Change int* var argument to bool*.
4498         * compile/compile-cplus-types.c (debug_compile_cplus_types): Change to
4499         bool.
4500         (debug_compile_cplus_scopes): Likewise.
4501         * compile/compile-internal.h (compile_debug): Likewise.
4502         * compile/compile.c (compile_debug): Likewise.
4503         (struct compile_options) <raw>: Likewise.
4504         * cp-support.c (catch_demangler_crashes): Likewise.
4505         * cris-tdep.c (usr_cmd_cris_version_valid): Likewise.
4506         (usr_cmd_cris_dwarf2_cfi): Likewise.
4507         * csky-tdep.c (csky_debug): Likewise.
4508         * darwin-nat.c (enable_mach_exceptions): Likewise.
4509         * dcache.c (dcache_enabled_p): Likewise.
4510         * defs.h (info_verbose): Likewise.
4511         * demangle.c (demangle): Likewise.
4512         (asm_demangle): Likewise.
4513         * dwarf-index-cache.c (debug_index_cache): Likewise.
4514         * dwarf2-frame.c (dwarf2_frame_unwinders_enabled_p): Likewise.
4515         * dwarf2-frame.h (dwarf2_frame_unwinders_enabled_p): Likewise.
4516         * dwarf2read.c (check_physname): Likewise.
4517         (use_deprecated_index_sections): Likewise.
4518         (dwarf_always_disassemble): Likewise.
4519         * eval.c (overload_resolution): Likewise.
4520         * event-top.c (set_editing_cmd_var): Likewise.
4521         (exec_done_display_p): Likewise.
4522         * event-top.h (set_editing_cmd_var): Likewise.
4523         (exec_done_display_p): Likewise.
4524         * exec.c (write_files): Likewise.
4525         * fbsd-nat.c (debug_fbsd_lwp): Likewise
4526         (debug_fbsd_nat): Likewise.
4527         * frame.h (struct frame_print_options) <print_raw_frame_arguments>:
4528         Likewise.
4529         (struct set_backtrace_options) <backtrace_past_main>: Likewise.
4530         <backtrace_past_entry> Likewise.
4531         * gdb-demangle.h (demangle): Likewise.
4532         (asm_demangle): Likewise.
4533         * gdb_bfd.c (bfd_sharing): Likewise.
4534         * gdbcore.h (write_files): Likewise.
4535         * gdbsupport/common-debug.c (show_debug_regs): Likewise.
4536         * gdbsupport/common-debug.h (show_debug_regs): Likewise.
4537         * gdbthread.h (print_thread_events): Likewise.
4538         * gdbtypes.c (opaque_type_resolution): Likewise.
4539         (strict_type_checking): Likewise.
4540         * gnu-nat.c (gnu_debug_flag): Likewise.
4541         * guile/scm-auto-load.c (auto_load_guile_scripts): Likewise.
4542         * guile/scm-param.c (pascm_variable): Add boolval.
4543         (add_setshow_generic): Update.
4544         (pascm_param_value): Update.
4545         (pascm_set_param_value_x): Update.
4546         * hppa-tdep.c (hppa_debug): Change to bool..
4547         * infcall.c (may_call_functions_p): Likewise.
4548         (coerce_float_to_double_p): Likewise.
4549         (unwind_on_signal_p): Likewise.
4550         (unwind_on_terminating_exception_p): Likewise.
4551         * infcmd.c (startup_with_shell): Likewise.
4552         * inferior.c (print_inferior_events): Likewise.
4553         * inferior.h (startup_with_shell): Likewise.
4554         (print_inferior_events): Likewise.
4555         * infrun.c (step_stop_if_no_debug): Likewise.
4556         (detach_fork): Likewise.
4557         (debug_displaced): Likewise.
4558         (disable_randomization): Likewise.
4559         (non_stop): Likewise.
4560         (non_stop_1): Likewise.
4561         (observer_mode): Likewise.
4562         (observer_mode_1): Likewise.
4563         (set_observer_mode): Update.
4564         (sched_multi): Change to bool.
4565         * infrun.h (debug_displaced): Likewise.
4566         (sched_multi): Likewise.
4567         (step_stop_if_no_debug): Likewise.
4568         (non_stop): Likewise.
4569         (disable_randomization): Likewise.
4570         * linux-tdep.c (use_coredump_filter): Likewise.
4571         (dump_excluded_mappings): Likewise.
4572         * linux-thread-db.c (auto_load_thread_db): Likewise.
4573         (check_thread_db_on_load): Likewise.
4574         * main.c (captured_main_1): Update.
4575         * maint-test-options.c (struct test_options_opts) <flag_opt, xx1_opt,
4576         xx2_opt, boolean_opt>: Change to bool.
4577         * maint-test-settings.c (maintenance_test_settings_boolean): Likewise.
4578         * maint.c (maintenance_profile_p): Likewise.
4579         (per_command_time): Likewise.
4580         (per_command_space): Likewise.
4581         (per_command_symtab): Likewise.
4582         * memattr.c (inaccessible_by_default): Likewise.
4583         * mi/mi-main.c (mi_async): Likewise.
4584         (mi_async_1): Likewise.
4585         * mips-tdep.c (mips64_transfers_32bit_regs_p): Likewise.
4586         * nat/fork-inferior.h (startup_with_shell): Likewise.
4587         * nat/linux-namespaces.c (debug_linux_namespaces): Likewise.
4588         * nat/linux-namespaces.h (debug_linux_namespaces): Likewise.
4589         * nios2-tdep.c (nios2_debug): Likewise.
4590         * or1k-tdep.c (or1k_debug): Likewise.
4591         * parse.c (parser_debug): Likewise.
4592         * parser-defs.h (parser_debug): Likewise.
4593         * printcmd.c (print_symbol_filename): Likewise.
4594         * proc-api.c (procfs_trace): Likewise.
4595         * python/py-auto-load.c (auto_load_python_scripts): Likewise.
4596         * python/py-param.c (union parmpy_variable): Add "bool boolval" field.
4597         (set_parameter_value): Update.
4598         (add_setshow_generic): Update.
4599         * python/py-value.c (copy_py_bool_obj): Change argument from int*
4600         to bool*.
4601         * python/python.c (gdbpy_parameter_value): Cast to bool* instead of
4602         int*.
4603         * ravenscar-thread.c (ravenscar_task_support): Change to bool.
4604         * record-btrace.c (record_btrace_target::store_registers): Update.
4605         * record-full.c (record_full_memory_query): Change to bool.
4606         (record_full_stop_at_limit): Likewise.
4607         * record-full.h (record_full_memory_query): Likewise.
4608         * remote-notif.c (notif_debug): Likewise.
4609         * remote-notif.h (notif_debug): Likewise.
4610         * remote.c (use_range_stepping): Likewise.
4611         (interrupt_on_connect): Likewise.
4612         (remote_break): Likewise.
4613         * ser-tcp.c (tcp_auto_retry): Likewise.
4614         * ser-unix.c (serial_hwflow): Likewise.
4615         * skip.c (debug_skip): Likewise.
4616         * solib-aix.c (solib_aix_debug): Likewise.
4617         * spu-tdep.c (spu_stop_on_load_p): Likewise.
4618         (spu_auto_flush_cache_p): Likewise.
4619         * stack.c (struct backtrace_cmd_options) <full, no_filters, hide>:
4620         Likewise.
4621         (struct info_print_options) <quiet>: Likewise.
4622         * symfile-debug.c (debug_symfile): Likewise.
4623         * symfile.c (auto_solib_add): Likewise.
4624         (separate_debug_file_debug): Likewise.
4625         * symfile.h (auto_solib_add): Likewise.
4626         (separate_debug_file_debug): Likewise.
4627         * symtab.c (basenames_may_differ): Likewise.
4628         (struct filename_partial_match_opts) <dirname, basename>: Likewise.
4629         (struct info_print_options) <quiet, exclude_minsyms>: Likewise.
4630         (struct info_types_options) <quiet>: Likewise.
4631         * symtab.h (demangle): Likewise.
4632         (basenames_may_differ): Likewise.
4633         * target-dcache.c (stack_cache_enabled_1): Likewise.
4634         (code_cache_enabled_1): Likewise.
4635         * target.c (trust_readonly): Likewise.
4636         (may_write_registers): Likewise.
4637         (may_write_memory): Likewise.
4638         (may_insert_breakpoints): Likewise.
4639         (may_insert_tracepoints): Likewise.
4640         (may_insert_fast_tracepoints): Likewise.
4641         (may_stop): Likewise.
4642         (auto_connect_native_target): Likewise.
4643         (target_stop_and_wait): Update.
4644         (target_async_permitted): Change to bool.
4645         (target_async_permitted_1): Likewise.
4646         (may_write_registers_1): Likewise.
4647         (may_write_memory_1): Likewise.
4648         (may_insert_breakpoints_1): Likewise.
4649         (may_insert_tracepoints_1): Likewise.
4650         (may_insert_fast_tracepoints_1): Likewise.
4651         (may_stop_1): Likewise.
4652         * target.h (target_async_permitted): Likewise.
4653         (may_write_registers): Likewise.
4654         (may_write_memory): Likewise.
4655         (may_insert_breakpoints): Likewise.
4656         (may_insert_tracepoints): Likewise.
4657         (may_insert_fast_tracepoints): Likewise.
4658         (may_stop): Likewise.
4659         * thread.c (struct info_threads_opts) <show_global_ids>: Likewise.
4660         (make_thread_apply_all_options_def_group): Change argument from int*
4661         to bool*.
4662         (thread_apply_all_command): Update.
4663         (print_thread_events): Change to bool.
4664         * top.c (confirm): Likewise.
4665         (command_editing_p): Likewise.
4666         (history_expansion_p): Likewise.
4667         (write_history_p): Likewise.
4668         (info_verbose): Likewise.
4669         * top.h (confirm): Likewise.
4670         (history_expansion_p): Likewise.
4671         * tracepoint.c (disconnected_tracing): Likewise.
4672         (circular_trace_buffer): Likewise.
4673         * typeprint.c (print_methods): Likewise.
4674         (print_typedefs): Likewise.
4675         * utils.c (debug_timestamp): Likewise.
4676         (sevenbit_strings): Likewise.
4677         (pagination_enabled): Likewise.
4678         * utils.h (sevenbit_strings): Likewise.
4679         (pagination_enabled): Likewise.
4680         * valops.c (overload_resolution): Likewise.
4681         * valprint.h (struct value_print_options) <prettyformat_arrays,
4682         prettyformat_structs, vtblprint, unionprint, addressprint, objectprint,
4683         stop_print_at_null, print_array_indexes, deref_ref, static_field_print,
4684         pascal_static_field_print, raw, summary, symbol_print, finish_print>:
4685         Likewise.
4686         * windows-nat.c (new_console): Likewise.
4687         (cygwin_exceptions): Likewise.
4688         (new_group): Likewise.
4689         (debug_exec): Likewise.
4690         (debug_events): Likewise.
4691         (debug_memory): Likewise.
4692         (debug_exceptions): Likewise.
4693         (useshell): Likewise.
4694         * windows-tdep.c (maint_display_all_tib): Likewise.
4695         * xml-support.c (debug_xml): Likewise.
4696
4697 2019-09-17  Mike Gulick  <mgulick@mathworks.com>
4698
4699         * source.c (prepare_path_for_appending): New function.
4700         (openp): Make use of new function.
4701         (find_and_open_source): Search for the compilation directory and
4702         source file as a relative path beneath the directory search path.
4703
4704 2019-09-17  Andrew Burgess  <andrew.burgess@embecosm.com>
4705
4706         * source-cache.c (source_cache::get_line_charpos): Catch
4707         exceptions and return false, this matches the behaviour documented
4708         in the header file.
4709
4710 2019-09-17  Joel Brobecker  <brobecker@adacore.com>
4711
4712         * ada-tasks.c (info_task): Remove quoting of the task's name.
4713
4714 2019-09-16  Christian Biesinger  <cbiesinger@google.com>
4715
4716         * symfile.c (auto_solib_add): Replace comment with a reference
4717         to the header file.
4718
4719 2019-09-14  Christian Biesinger  <cbiesinger@google.com>
4720
4721         * NEWS: Mention that gdb can now be compiled with Python 3
4722         on Windows.
4723
4724 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4725
4726         * maint.c (maint_print_section_data::maint_print_section_data):
4727         Force use of 'float log10 (float)' by casting the argument to
4728         float.
4729
4730 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4731
4732         * maint.c: Add 'cmath' include.
4733         (struct maint_print_section_data): New structure.
4734         (print_section_index): New function.
4735         (print_bfd_section_info): Add header comment, small whitespace
4736         cleanup, and update to call new print_section_index function.
4737         (print_objfile_section_info): Likewise.
4738         (maint_obj_section_from_bfd_section): New function.
4739         (print_bfd_section_info_maybe_relocated): New function.
4740         (maintenance_info_sections): Add header comment, always use
4741         bfd_map_over_sections instead of ALL_OBJFILE_OSECTIONS.
4742
4743 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4744
4745         * psymtab.c (find_pc_sect_psymtab): Move baseaddr local into more
4746         inner scope, add check that the objfile has psymtabs before
4747         checking psymtabs_addrmap.
4748         * psymtab.h (psymtab_storage) <psymtabs_addrmap>: Extend comment.
4749
4750 2019-09-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4751
4752         * NEWS: Announce that Ada task names are now shown at more places,
4753         and between quotes (except in info task output).
4754         * gdb/ada-tasks.c (task_to_str): New function.
4755         (display_current_task_id): Call task_to_str.
4756         (task_command_1): Likewise.
4757         (print_ada_task_info): In non-mi mode, Properly align headers and data
4758         when task-id length is > 9 (9 is the default for a 32 bits CORE_ADDR).
4759
4760 2019-09-12  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
4761
4762         * procfs.c (procfs_target::wait) <PR_FAULTED>: Get signal from
4763         prstatus.pr_lwp.pr_info instead of making it up.
4764
4765 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
4766
4767         * auto-load.c (auto_load_expand_dir_vars): Update.
4768         * defs.h (gdb_datadir): Change to std::string.
4769         (python_libdir): Likewise.
4770         (relocate_gdb_directory): Change return type to std::string.
4771         * guile/guile.c (gdbscm_data_directory): Update.
4772         (initialize_scheme_side): Update.
4773         * jit.c (jit_reader_dir): Change to std::string.
4774         (jit_reader_load_command): Update.
4775         * main.c (gdb_datadir): Change to std::string.
4776         (python_libdir): Likewise.
4777         (set_gdb_data_directory): Update.
4778         (relocate_path): Change to return std::string.
4779         (relocate_gdb_directory): Change to return std::string.
4780         (relocate_gdbinit_path_maybe_in_datadir): Update.
4781         (captured_main_1): Update.
4782         * python/python.c (do_start_initialization): Update.
4783         * top.c (show_gdb_datadir): Update.
4784         * xml-syscall.c (xml_init_syscalls_info): Update.
4785         (init_syscalls_info): Update.
4786
4787 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
4788
4789         * main.c (relocate_gdbinit_path_maybe_in_datadir): Factor this code
4790         out of get_init_files.
4791         (get_init_files): Update.
4792
4793 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
4794
4795         * main.c (get_init_files): Change to use std::string.
4796         (captured_main_1): Update.
4797         (print_gdb_help): Update.
4798
4799 2019-09-11  Ali Tamur  <tamur@google.com>
4800
4801         *gdb/target-float.c (host_float_ops<T>::to_longest): Update
4802         implementation.
4803
4804 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
4805
4806         * dbxread.c (read_dbx_symtab): Update.
4807         * dwarf2read.c (load_partial_dies): Update.
4808         * mdebugread.c (parse_partial_symbols): Update.
4809         (handle_psymbol_enumerators): Update.
4810         * psympriv.h (add_psymbol_to_list): Change type of copy_names to bool.
4811         * psymtab.c (add_psymbol_to_bcache): Likewise.
4812         (add_psymbol_to_list): Likewise.
4813         * symtab.c (symbol_set_names): Likewise.
4814         * symtab.h (symbol_set_names): Likewise.
4815         * xcoffread.c (scan_xcoff_symtab): Update.
4816
4817 2019-09-11  Tom Tromey  <tom@tromey.com>
4818
4819         * symfile-mem.c (symbol_file_add_from_memory): Use
4820         bfd_set_filename.
4821         * solib-darwin.c (darwin_bfd_open): Use bfd_set_filename.
4822         * solib-aix.c (solib_aix_bfd_open): Use bfd_set_filename.
4823
4824 2019-09-10  Tom Tromey  <tromey@adacore.com>
4825
4826         * dwarf-index-write.c (write_psymbols): Extend error message.
4827         (debug_names::insert): Add Ada code.
4828         (debug_names::write_psymbols): Remove Ada check.
4829         (debug_names) <m_string_obstack>: New member.
4830         * dwarf2read.c (gdb_index_symbol_name_matcher): Remove.
4831         (gdb_index_symbol_name_matcher::matches): Remove.
4832         (mapped_index_base::find_name_components_bounds): Add "lang"
4833         parameter.
4834         (mapped_index_base::build_name_components): Also split names
4835         according to Ada syntax.
4836         (dw2_expand_symtabs_matching_symbol): Loop over languages.  Change
4837         type of "match_callback".
4838         (check_match, check_find_bounds_finds)
4839         (dw2_expand_symtabs_matching): Update.
4840         (dw2_debug_names_iterator): Add new constructor.
4841         (dw2_debug_names_map_matching_symbols): New function.
4842         (dw2_debug_names_expand_symtabs_matching): Update.
4843         (dwarf2_debug_names_functions): Use
4844         dw2_debug_names_map_matching_symbols.
4845
4846 2019-09-10  Tom Tromey  <tromey@adacore.com>
4847
4848         * dwarf2read.c (dw2_get_file_names_reader): Add the
4849         CU's file name to the results.
4850
4851 2019-09-10  Tom Tromey  <tromey@adacore.com>
4852
4853         * ada-lang.c (add_nonlocal_symbols): Combine calls to
4854         map_matching_symbols.  Update.
4855         * dwarf2read.c (dw2_map_matching_symbols): Update.
4856         * psymtab.c (match_partial_symbol): Change type; update.
4857         (psym_map_matching_symbols): Likewise.
4858         * symfile-debug.c (debug_qf_map_matching_symbols): Change
4859         type; update.
4860         * symfile.h (struct quick_symbol_functions)
4861         <map_matching_symbols>: Change "name" to be a lookup_name_info.
4862         Remove "match".
4863
4864 2019-09-10  Tom Tromey  <tromey@adacore.com>
4865
4866         * psymtab.c (map_block): Remove.
4867         (psym_map_matching_symbols): Use iterate_over_symbols_terminated.
4868         * symtab.c (iterate_over_symbols_terminated): New function.
4869         * symtab.c (iterate_over_symbols_terminated): Declare.
4870
4871 2019-09-10  Tom Tromey  <tromey@adacore.com>
4872
4873         * ada-lang.c (ada_iterate_over_symbols): Return bool.
4874         * language.h (struct language_defn) <la_iterate_over_symbols>:
4875         Return bool.
4876         * symtab.c (iterate_over_symbols): Return bool.
4877         * symtab.h (iterate_over_symbols): Return bool.
4878
4879 2019-09-10  Tom Tromey  <tromey@adacore.com>
4880
4881         * ada-lang.c (aux_add_nonlocal_symbols): Change type.
4882         (add_nonlocal_symbols): Update.
4883         * dwarf2read.c (dw2_map_matching_symbols): Change type.
4884         * psymtab.c (map_block, psym_map_matching_symbols): Change type.
4885         * symfile-debug.c (debug_qf_map_matching_symbols): Change type.
4886         * symfile.h (struct quick_symbol_functions) <map_matching_symbols>:
4887         Change type of "callback".  Remove "data".
4888
4889
4890 2019-09-09  Ali Tamur  <tamur@google.com>
4891
4892         * dwarf2read.c (comp_unit_head): Update comment.
4893         (dwarf2_dwo_name): New function declaration.
4894         (dwarf_unit_type_name): New function declaration.
4895         (read_comp_unit_head): Add support for new compilation units,
4896         DW_UT_partial, DW_UT_skeleton, DW_UT_split_compile, DW_UT_split_type.
4897         Particularly, DW_UT_skeleton and DW_UT_split_compile have dwo_id
4898         (currently named as "signature") in their header. Also clarify error
4899         messages.
4900         (lookup_dwo_id): New function. Returns the dwo id of the given
4901         compile unit.
4902         (lookup_dwo_unit): Use the new lookup_dwo_id function.
4903         (init_cutu_and_read_dies): Use the new dwarf2_dwo_name and lookup_dwo_id
4904         functions.
4905         (create_dwo_cu_reader): Use the added lookup_dwo_id function.
4906         (dwarf2_dwo_name): Get the dwo name if present.
4907         (dwarf_unit_type_name): Convert DW_UT_* types to string for diagnostic
4908         purposes.
4909
4910 2019-09-09  Tom Tromey  <tom@tromey.com>
4911
4912         * tui/tui-win.c (tui_all_windows_info): Use ui_out.
4913
4914 2019-09-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4915
4916         * python/python.c (do_start_initialization): Make progname_copy static,
4917         to avoid a leak report.
4918
4919 2019-09-08  Tom Tromey  <tom@tromey.com>
4920
4921         * tui/tui-wingeneral.c (box_win): Truncate long window titles.
4922
4923 2019-09-07  Simon Marchi  <simon.marchi@efficios.com>
4924
4925         * dwarf2read.c (struct dw2_symtab_iterator) <block_index>:
4926         Change type to gdb::optional<block_enum>.
4927         (dw2_symtab_iter_init): Change block_index parameter type
4928         to gdb::optional<block_enum>.
4929         (dw2_lookup_symbol): Change block_index parameter
4930         type to block_enum.c
4931         (dw2_debug_names_lookup_symbol): Likewise.
4932         * psymtab.c (psym_lookup_symbol): Likewise.
4933         * symfile-debug.c (debug_qf_lookup_symbol): Likewise.
4934         * symfile.h (struct quick_symbol_functions) <lookup_symbol>:
4935         Likewise.
4936
4937 2019-09-06  Christian Biesinger  <cbiesinger@google.com>
4938
4939         * defs.h (relocate_gdb_directory): Change int to bool in
4940         signature and rename flag to relocatable.
4941         * main.c (relocate_path): Likewise.
4942         (relocate_gdb_directory): Likewise.
4943
4944 2019-09-06  Alan Modra  <amodra@gmail.com>
4945
4946         * coffread.c (coff_symfile_read): Constify filename variable.
4947         * dbxread.c (dbx_symfile_init, coffstab_build_psymtabs),
4948         (elfstab_build_psymtabs, stabsect_build_psymtabs): Likewise.
4949         * gdb_bfd.c (gdb_bfd_close_or_warn): Likewise.
4950         * solib.c (reload_shared_libraries_1): Likewise.
4951         * symfile.c (reread_symbols): Likewise.
4952         * solib-aix.c (solib_aix_bfd_open): Add cast for xfree of filename.
4953         * solib-darwin.c (darwin_bfd_open): Likewise.
4954         * symfile-mem.c (symbol_file_add_from_memory): Likewise.
4955
4956 2019-09-03  Andrew Burgess  <andrew.burgess@embecosm.com>
4957
4958         * psymtab.c (print_partial_symbols): Handle missing domain_enum
4959         values MODULE_DOMAIN and COMMON_BLOCK_DOMAIN.
4960
4961 2019-09-03  Tom Tromey  <tromey@adacore.com>
4962
4963         * ada-valprint.c (ada_val_print_num): Don't recurse for range
4964         types.
4965         (has_negatives): Unbias a range type bound.
4966         * dwarf2read.c (read_subrange_type): Handle DW_AT_GNU_bias.
4967         * gdbtypes.c (operator==): Handle new field.
4968         (create_range_type): Add "bias" parameter.
4969         (create_static_range_type, resolve_dynamic_range): Update.
4970         * gdbtypes.h (struct range_bounds) <bias>: New member.
4971         (create_range_type): Add bias parameter.
4972         * printcmd.c (print_scalar_formatted): Unbias range types.
4973         * value.c (unpack_long): Unbias range types.
4974         (pack_long): Bias range types.
4975
4976 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
4977
4978         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Check all
4979         probe arguments.
4980
4981 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
4982
4983         * break-catch-throw.c (fetch_probe_arguments): Use gdbarch.
4984         * dtrace-probe.c (dtrace_probe::get_argument_count): Likewise.
4985         * probe.c (probe_safe_evaluate_at_pc) (compute_probe_arg)
4986         (compile_probe_arg): Likewise.
4987         * probe.h (get_argument_count): Likewise.
4988         * solib-svr4.c (solib_event_probe_action): Likewise.
4989         * stap-probe.c (stap_probe::get_argument_count): Likewise.
4990
4991 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
4992
4993         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Move
4994         code to here...
4995         (svr4_create_solib_event_breakpoints): ...from here.
4996
4997 2019-08-30  Sergio Durigan Junior  <sergiodj@redhat.com>
4998
4999         * nat/fork-inferior.c (trace_start_error): Remove "\nError: "
5000         suffix from warning message.
5001
5002 2019-08-30  Tom Tromey  <tom@tromey.com>
5003
5004         * tui/tui-winsource.h (struct tui_source_window_base)
5005         <refresh_all>: Don't declare.
5006         * tui/tui-winsource.c (tui_source_window_base::refresh_all):
5007         Remove.
5008         * tui/tui-win.c (tui_refresh_all_win): Don't call refresh_all or
5009         tui_show_locator_content.
5010         * tui/tui-regs.h (struct tui_data_window) <refresh_all>: Don't
5011         declare.
5012         * tui/tui-regs.c (tui_data_window::refresh_all): Remove.
5013         * tui/tui-data.h (struct tui_win_info) <refresh_all>: Don't
5014         declare.
5015
5016 2019-08-30  Tom Tromey  <tom@tromey.com>
5017
5018         * tui/tui-io.c (tui_cont_sig): Don't call wrefresh.
5019
5020 2019-08-30  Tom Tromey  <tom@tromey.com>
5021
5022         * tui/tui-stack.c (_initialize_tui_stack): Move later.
5023         Remove unnecessary forward declarations.
5024
5025 2019-08-30  Tom Tromey  <tom@tromey.com>
5026
5027         * tui/tui-stack.c (tui_locator_window::set_locator_fullname): Call
5028         rerender.
5029         (tui_update_locator_fullname, tui_show_frame_info): Don't call
5030         tui_show_locator_content.
5031
5032 2019-08-30  Tom Tromey  <tom@tromey.com>
5033
5034         * tui/tui-stack.c (tui_show_locator_content): Move lower.  Rewrite.
5035         (tui_locator_window::rerender): Rewrite using body of previous
5036         tui_show_locator_content.
5037
5038 2019-08-30  Tom Tromey  <tom@tromey.com>
5039
5040         * tui/tui-stack.h (struct tui_locator_window) <set_locator_info,
5041         set_locator_fullname>: New methods.
5042         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
5043         Rename from tui_set_locator_fullname.
5044         (tui_locator_window::set_locator_info): Rename from
5045         tui_set_locator_info.  Return bool.
5046         (tui_update_locator_fullname, tui_show_frame_info): Update.
5047
5048 2019-08-30  Tom Tromey  <tom@tromey.com>
5049
5050         * tui/tui-layout.c (show_layout): Don't call tui_refresh_all.
5051
5052 2019-08-30  Tom Tromey  <tom@tromey.com>
5053
5054         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Don't
5055         call touchwin.
5056
5057 2019-08-30  Tom Tromey  <tom@tromey.com>
5058
5059         * tui/tui-wingeneral.c (box_win): Assume win_info and
5060         win_info->handle cannot be NULL.
5061
5062 2019-08-30  Tom Tromey  <tom@tromey.com>
5063
5064         * tui/tui-regs.h (struct tui_data_item_window) <rerender,
5065         refresh_window>: Declare.
5066         * tui/tui-regs.c (tui_data_window::display_registers_from): Call
5067         resize.
5068         (tui_data_item_window::rerender): Rename from
5069         tui_display_register.
5070         (tui_data_item_window::refresh_window): New method.
5071         * tui/tui-layout.c (tui_gen_win_info::resize): Do nothing on
5072         no-op.
5073
5074 2019-08-30  Tom Tromey  <tom@tromey.com>
5075
5076         * tui/tui-regs.h (struct tui_data_window) <regs_content,
5077         regs_column_count, current_group>: Move later.  Now private.
5078         <get_current_group>: New method.
5079         * tui/tui-regs.c (tui_reg_command): Update.
5080         * tui/tui-layout.c (tui_set_layout): Update.
5081
5082 2019-08-30  Tom Tromey  <tom@tromey.com>
5083
5084         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
5085         (tui_data_window::rerender): Don't call
5086         check_and_display_highlight_if_needed.
5087         (tui_data_window::refresh_all): Remove call to
5088         erase_data_content.
5089
5090 2019-08-30  Tom Tromey  <tom@tromey.com>
5091
5092         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
5093         (tui_data_window::display_registers_from)
5094         (tui_data_window::display_reg_element_at_line)
5095         (tui_data_window::display_registers_from_line): Remove checks of
5096         "empty".
5097
5098 2019-08-30  Tom Tromey  <tom@tromey.com>
5099
5100         * tui/tui-regs.h (struct tui_data_window) <display_all_data>:
5101         Don't declare.
5102         * tui/tui-regs.c (tui_data_window::show_registers): Call
5103         rerender.
5104         (tui_data_window::rerender): Rename from display_all_data.
5105         (tui_data_window::rerender): Remove old implementation.
5106
5107 2019-08-30  Tom Tromey  <tom@tromey.com>
5108
5109         * tui/tui-regs.c (tui_data_window::display_all_data): Change
5110         text.
5111         * tui/tui-data.h (NO_DATA_STRING): Remove define.
5112
5113 2019-08-29  Bernhard Wodok  <barto@gmx.net>
5114             Sergio Durigan Junior  <sergiodj@redhat.com>
5115
5116         PR win32/24284
5117         * mingw-hdep.c (gdb_select): Handle case when 'n' is zero.
5118
5119 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
5120
5121         * symtab.c (search_symbols): Don't include MODULE_DOMAIN symbols
5122         when searching for types.
5123
5124 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
5125
5126         * f-lang.c (f_language_defn): Use f_print_typedef.
5127         * f-lang.h (f_print_typedef): Declare.
5128         * f-typeprint.c (f_print_typedef): Define.
5129
5130 2019-08-27  Christian Biesinger  <cbiesinger@google.com>
5131
5132         * nat/linux-namespaces.c (mnsh_main): Initialize fd (to -1).
5133
5134 2019-08-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5135
5136         * cli/cli-utils.c (info_print_options_defs): Delete.
5137         (make_info_print_options_def_group): Delete.
5138         (extract_info_print_options): Delete.
5139         (info_print_command_completer): Delete.
5140         (info_print_args_help): Add extra parameter, and optionally
5141         include text about -n flag.
5142         * cli/cli-utils.h (struct info_print_options): Delete.
5143         (extract_info_print_options): Delete declaration.
5144         (info_print_command_completer): Delete declaration.
5145         (info_print_args_help): Add extra parameter, extend header
5146         comment.
5147         * python/python.c (gdbpy_rbreak): Pass additional parameter to
5148         search_symbols.
5149         * stack.c (struct info_print_options): New type.
5150         (info_print_options_defs): New file scoped variable.
5151         (make_info_print_options_def_group): New static function.
5152         (info_print_command_completer): New static function.
5153         (info_locals_command): Update to use new local functions.
5154         (info_args_command): Likewise.
5155         (_initialize_stack): Add extra parameter to calls to
5156         info_print_args_help.
5157         * symtab.c (search_symbols): Add extra parameter, use this to
5158         possibly excluse non-debug symbols.
5159         (symtab_symbol_info): Add extra parameter, which is passed on to
5160         search_symbols.
5161         (struct info_print_options): New type.
5162         (info_print_options_defs): New file scoped variable.
5163         (make_info_print_options_def_group): New static function.
5164         (info_print_command_completer): New static function.
5165         (info_variables_command): Update to use local functions, and pass
5166         extra parameter through to symtab_symbol_info.
5167         (info_functions_command): Likewise.
5168         (info_types_command): Pass additional argument through to
5169         symtab_symbol_info.
5170         (rbreak_command): Pass extra argument to search_symbols.
5171         (_initialize_symtab): Add extra arguments for calls to
5172         info_print_args_help, and update help text for 'info variables',
5173         'whereis', and 'info functions' commands.
5174         * symtab.h (search_symbols): Add extra argument to declaration.
5175         * NEWS: Mention new flags.
5176
5177 2019-08-26  Christian Biesinger  <cbiesinger@google.com>
5178
5179         * symtab.c (lookup_static_symbol): Call the new function (and move
5180         it down to be next to lookup_global_symbol).
5181         (struct global_sym_lookup_data): Add block_enum member and rename to...
5182         (struct global_or_static_sym_lookup_data): ...this.
5183         (lookup_symbol_global_iterator_cb): Pass block_index instead of
5184         GLOBAL_BLOCK to lookup_symbol_in_objfile and rename to...
5185         (lookup_symbol_global_or_static_iterator_cb): ...this.
5186         (lookup_global_or_static_symbol): New function.
5187         (lookup_global_symbol): Call new function.
5188
5189 2019-08-26  Tom de Vries  <tdevries@suse.de>
5190
5191         PR c++/24852
5192         * break-catch-throw.c (fetch_probe_arguments): Improve error mesage
5193         when pc_probe.prob == NULL.
5194
5195 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
5196
5197         * dwarf2read.c (dw2_debug_names_iterator::next): Rename local
5198         variable symbol_linkage to symbol_linkage_.
5199
5200 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
5201
5202         * dwarf2read.c (dw2_debug_names_iterator::next): Use enum to
5203         represent whether the symbol is static, dynamic, or we don't
5204         know.
5205
5206 2019-08-25  Yoshinori Sato <ysato@users.sourceforge.jp>
5207
5208         * gdb/rx-tdep.c (rx_register_names): New.
5209         (rx_register_name): Delete.
5210         (rx_psw_type): Delete.
5211         (rx_fpsw_type): Delete.
5212         (rx_register_type): Delete.
5213         (rx_gdbarch_init): Convert target-descriptions.
5214         (_initialize_rx_tdep): Add initialize_tdesc_rx.
5215         * gdb/features/Makefile: Add rx.xml.
5216         * gdb/features/rx.xml: New.
5217         * gdb/features/rx.c: Generated.
5218         * gdb/NEWS: Mention target description support.
5219
5220 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
5221
5222         * symtab.c (symbol_cache_lookup): Always initialize *bsc_ptr and
5223         *slot_ptr.
5224
5225 2019-08-23  Sergio Durigan Junior  <sergiodj@redhat.com>
5226
5227         * configure.ac: Don't check for 'dlfcn.h' (moved to
5228         gdbsupport/common.m4).
5229         * Makefile.in (COMMON_SFILES): Move 'gdb-dlfcn.c' to
5230         'gdbsupport/'.
5231         (HFILES_NO_SRCDIR): Likewise, for 'gdb-dlfcn.h'.
5232         * compile/compile-c-support.c: Include
5233         'gdbsupport/gdb-dlfcn.h'.
5234         * gdbsupport/common.m4: Check for 'dlfcn.h'.
5235         * gdb-dlfcn.c: Move to...
5236         * gdbsupport/gdb-dlfcn.c: ... here.
5237         * gdb-dlfcn.h: Move to...
5238         * gdbsupport/gdb-dlfcn.h: ... here.
5239
5240 2019-08-23  Sandra Loosemore  <sandra@codesourcery.com>
5241
5242         * nios2-tdep.c (struct reg_value): Improve comments.  Make
5243         the offset field signed.
5244
5245 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
5246
5247         * python/lib/gdb/__init__.py (_execute_file): New function.
5248         * python/python.c (python_run_simple_file): Call gdb._execute_file
5249         on Windows.
5250
5251 2019-08-22  Andrew Burgess  <andrew.burgess@embecosm.com>
5252
5253         * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
5254         all uses as this was never set to anything but a zero value.
5255
5256 2019-08-21  Bogdan Harjoc  <harjoc@gmail.com>
5257
5258         * cli/cli-cmds.c (with_command_1): Error out if no arguments.
5259
5260 2019-08-21  Christian Biesinger  <cbiesinger@google.com>
5261
5262         * tui/tui-data.h (tui_gen_win_info): Add an =default
5263         move constructor, required by some GCC versions.
5264
5265 2019-08-21  Jinke Fan  <fanjinke51@yeah.net>
5266
5267         * go32-nat.c (go32_sysinfo): Add hygon_p.
5268
5269 2019-08-20  Tom Tromey  <tom@tromey.com>
5270
5271         * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
5272         line_from_reg_element_no, first_reg_element_no_inline,
5273         display_all_data, delete_data_content_windows,
5274         erase_data_content>: Now private.
5275
5276 2019-08-20  Tom Tromey  <tom@tromey.com>
5277
5278         * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
5279         (tui_unhighlight_win, tui_highlight_win)
5280         (tui_win_info::make_window): Update.
5281         * tui/tui-data.h (HILITE, NO_HILITE): Remove.
5282
5283 2019-08-20  Tom Tromey  <tom@tromey.com>
5284
5285         * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
5286         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
5287         (MAX_PID_WIDTH): Move to tui-stack.c.
5288         * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
5289         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
5290         (MAX_PID_WIDTH): Move from tui-data.h.
5291
5292 2019-08-20  Tom Tromey  <tom@tromey.com>
5293
5294         * tui/tui-wingeneral.h (tui_make_window): Don't declare.
5295         * tui/tui-wingeneral.c (box_win): Change type of win_info.
5296         (box_win): Update.
5297         (tui_gen_win_info::make_window): Rename from tui_make_window.
5298         (tui_win_info::make_window): New method.
5299         (tui_gen_win_info::make_visible): Update.
5300         * tui/tui-source.c (tui_source_window::set_contents): Update.
5301         * tui/tui-regs.c (tui_data_window::show_register_group): Update.
5302         (tui_data_window::display_registers_from): Update.
5303         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
5304         * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
5305         Declare.
5306         <can_box>: Remove.
5307         <title>: Remove.
5308         (struct tui_win_info) <make_window>: Declare.
5309         <can_box>: Now virtual.
5310         <title>: New member.
5311         * tui/tui-data.c (~tui_gen_win_info): Don't free title.
5312         * tui/tui-command.c (tui_cmd_window::resize): Update.
5313
5314 2019-08-20  Tom Tromey  <tom@tromey.com>
5315
5316         * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
5317         * tui/tui-regs.c (tui_data_window::show_registers): Update.
5318         (tui_data_window::check_register_values): Update.
5319
5320 2019-08-20  Tom Tromey  <tom@tromey.com>
5321
5322         * tui/tui-regs.h (struct tui_data_window): Use
5323         DISABLE_COPY_AND_ASSIGN.
5324         <regs_content>: Change type, removing unique_ptr.
5325         <tui_data_window>: Add move constructor.
5326         * tui/tui-regs.c (tui_data_window::show_registers)
5327         (tui_data_window::show_register_group)
5328         (tui_data_window::display_registers_from)
5329         (tui_data_window::display_registers_from)
5330         (tui_data_window::first_data_item_displayed)
5331         (tui_data_window::delete_data_content_windows)
5332         (tui_data_window::rerender, tui_data_window::refresh_window)
5333         (tui_data_window::check_register_values): Update.
5334
5335 2019-08-20  Tom Tromey  <tom@tromey.com>
5336
5337         * tui/tui-regs.h (struct tui_data_window) <show_registers,
5338         show_register_group>: Declare.
5339         (tui_show_register_group): Don't declare.
5340         * tui/tui-regs.c (tui_data_window::show_registers): Rename from
5341         tui_show_registers.
5342         (tui_data_window::show_register_group): Rename from
5343         tui_show_register_group.
5344         (tui_data_window::check_register_values, tui_reg_command):
5345         Update.
5346         * tui/tui-layout.c (tui_set_layout): Update.
5347
5348 2019-08-20  Tom Tromey  <tom@tromey.com>
5349
5350         * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
5351         Declare.
5352         (tui_check_register_values): Don't declare.
5353         * tui/tui-regs.c (tui_data_window::check_register_values): Rename
5354         from tui_check_register_values.
5355         * tui/tui-hooks.c (tui_register_changed): Update.
5356
5357 2019-08-20  Tom Tromey  <tom@tromey.com>
5358
5359         * tui/tui-regs.c (tui_reg_layout): Move later.
5360         (tui_show_registers): Don't enable TUI mode or change layout.
5361
5362 2019-08-20  Tom Tromey  <tom@tromey.com>
5363
5364         * tui/tui-regs.h (struct tui_data_item_window)
5365         <~tui_data_item_window>: Remove.
5366         <content>: Now a unique_xmalloc_ptr.
5367         * tui/tui-regs.c (tui_register_format): Return a
5368         unique_xmalloc_ptr.
5369         (tui_get_register): Update.
5370         (~tui_data_item_window): Remove.
5371         (tui_data_window::display_registers_from, tui_display_register):
5372         Update.
5373         * tui/tui-io.h (tui_expand_tabs): Update.
5374         * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
5375         Remove "col" parameter.
5376
5377 2019-08-20  Tom Tromey  <tom@tromey.com>
5378
5379         * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
5380         field.
5381         * tui/tui-regs.c (~tui_data_item_window): Update.
5382
5383 2019-08-20  Tom Tromey  <tom@tromey.com>
5384
5385         * tui/tui-regs.c (tui_register_format, tui_get_register): Move
5386         earlier.
5387
5388 2019-08-20  Tom Tromey  <tom@tromey.com>
5389
5390         * tui/tui-regs.c (tui_reg_command): Remove NULL check.
5391
5392 2019-08-20  Tom Tromey  <tom@tromey.com>
5393
5394         * tui/tui-source.h (struct tui_source_window): Update.
5395         * tui/tui-regs.c (tui_show_registers): Update.
5396         * tui/tui-disasm.h (struct tui_disasm_window): Update.
5397         * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
5398         (NO_REGS_STRING): Remove defines.
5399
5400 2019-08-20  Conrad Meyer  <cem@FreeBSD.org>
5401
5402         * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
5403         unnecessary thread walk if remote doesn't support the packet.
5404
5405 2019-08-19  Tom Tromey  <tromey@adacore.com>
5406
5407         * python/py-value.c (value_has_field): Fix indentation.
5408
5409 2019-08-19  Tom Tromey  <tromey@adacore.com>
5410
5411         * printcmd.c (do_one_display, info_display_command): Update.
5412         * block.h (contained_in): Return bool.  Add allow_nested
5413         parameter.
5414         * block.c (contained_in): Return bool.  Add allow_nested
5415         parameter.
5416
5417 2019-08-19  Tom Tromey  <tom@tromey.com>
5418
5419         * configure: Rebuild.
5420         * configure.ac: Disallow the combination of -static-libstdc++ and
5421         source highlight.
5422         * source-cache.c (get_language_name): Handle rust.
5423         (source_cache::get_source_lines): Ignore highlighting exceptions.
5424
5425 2019-08-16  Tom Tromey  <tom@tromey.com>
5426
5427         * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
5428         * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
5429         (struct tui_source_window_base) <make_visible, refresh_window,
5430         resize>: Remove methods.
5431         <execution_info>: Remove field.
5432         * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
5433         (tui_show_source_line, tui_source_window_base)
5434         (~tui_source_window_base): Update.
5435         (tui_source_window_base::resize)
5436         (tui_source_window_base::make_visible)
5437         (tui_source_window_base::refresh_window): Remove.
5438         (tui_source_window_base::update_exec_info): Update.
5439         * tui/tui-source.c (tui_source_window::set_contents): Update.
5440         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
5441
5442 2019-08-16  Tom Tromey  <tom@tromey.com>
5443
5444         * tui/tui-hooks.c (tui_remove_hooks): Don't set
5445         deprecated_query_hook.
5446
5447 2019-08-16  Tom Tromey  <tom@tromey.com>
5448
5449         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
5450         (tui_update_source_windows_with_line): Update.
5451         * tui/tui-source.h (struct tui_source_window)
5452         <show_symtab_source>: Declare.
5453         (tui_show_symtab_source): Don't declare.
5454         * tui/tui-source.c (tui_show_symtab_source): Rename from
5455         tui_show_symtab_source.
5456
5457 2019-08-16  Tom Tromey  <tom@tromey.com>
5458
5459         * tui/tui-winsource.h (struct tui_source_window_base)
5460         <set_contents>: Declare.
5461         * tui/tui-winsource.c
5462         (tui_source_window_base::update_source_window_as_is): Update.
5463         * tui/tui-source.h (struct tui_source_window) <set_contents>:
5464         Declare.
5465         (tui_set_source_content): Don't declare.
5466         * tui/tui-source.c (tui_source_window::set_contents): Rename from
5467         tui_set_source_content.
5468         * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
5469         Declare.
5470         (tui_set_disassem_content): Don't declare.
5471         * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
5472         tui_set_disassem_content.
5473
5474 2019-08-16  Tom Tromey  <tom@tromey.com>
5475
5476         * tui/tui-winsource.h (struct tui_source_window_base)
5477         <update_breakpoint_info>: Declare.
5478         (tui_update_breakpoint_info): Don't declare.
5479         * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
5480         (tui_update_all_breakpoint_info): Update.
5481         (tui_source_window_base::update_breakpoint_info): Rename from
5482         tui_update_breakpoint_info.
5483         (tui_source_window_base::update_exec_info): Update.
5484
5485 2019-08-16  Tom Tromey  <tom@tromey.com>
5486
5487         * tui/tui-winsource.h (struct tui_source_window_base)
5488         <update_source_window>: Declare.
5489         (tui_update_source_window): Don't declare.
5490         * tui/tui-winsource.c
5491         (tui_source_window_base::update_source_window): Rename from
5492         tui_update_source_window.
5493         (tui_source_window_base::rerender): Update.
5494         * tui/tui-source.c (tui_source_window::maybe_update): Update.
5495         * tui/tui-disasm.c (tui_show_disassem)
5496         (tui_show_disassem_and_update_source)
5497         (tui_disasm_window::maybe_update): Update.
5498
5499 2019-08-16  Tom Tromey  <tom@tromey.com>
5500
5501         * tui/tui-winsource.h (struct tui_source_window_base)
5502         <update_source_window_as_is>: Declare.
5503         (tui_update_source_window_as_is): Don't declare.
5504         * tui/tui-winsource.c (tui_update_source_window): Update
5505         (tui_source_window_base::update_source_window_as_is): Rename from
5506         tui_update_source_window_as_is.
5507         (tui_source_window_base::refill): Update.
5508         * tui/tui-source.c (tui_show_symtab_source): Update.
5509         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
5510         Update.
5511
5512 2019-08-16  Tom Tromey  <tom@tromey.com>
5513
5514         * tui/tui-winsource.h (tui_update_source_window)
5515         (tui_update_source_window_as_is): Remove "noerror" parameter.
5516         * tui/tui-winsource.c (tui_update_source_window)
5517         (tui_update_source_window_as_is): Remove "noerror" parameter.
5518         (tui_update_source_windows_with_addr)
5519         (tui_update_source_windows_with_line)
5520         (tui_source_window_base::rerender)
5521         (tui_source_window_base::refill): Update.
5522         * tui/tui-source.h (tui_set_source_content)
5523         (tui_show_symtab_source): Remove "noerror" parameter.
5524         * tui/tui-source.c (tui_set_source_content): Remove "noerror"
5525         parameter.
5526         (tui_show_symtab_source): Likewise.
5527         (tui_source_window::maybe_update): Update.
5528         * tui/tui-disasm.c (tui_show_disassem)
5529         (tui_show_disassem_and_update_source)
5530         (tui_disasm_window::do_scroll_vertical)
5531         (tui_disasm_window::maybe_update): Update.
5532
5533 2019-08-16  Tom Tromey  <tom@tromey.com>
5534
5535         * tui/tui.c (tui_is_window_visible): Update.
5536         * tui/tui-wingeneral.c (tui_make_window)
5537         (tui_gen_win_info::make_visible, tui_refresh_all): Update.
5538         * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
5539         (tui_set_focus_command, tui_all_windows_info, update_tab_width)
5540         (tui_set_win_height_command, parse_scrolling_args): Update.
5541         * tui/tui-source.c (tui_source_window::style_changed): Update.
5542         * tui/tui-regs.c (tui_show_registers)
5543         (tui_data_window::first_data_item_displayed)
5544         (tui_data_window::delete_data_content_windows)
5545         (tui_check_register_values, tui_reg_command): Update.
5546         * tui/tui-disasm.c (tui_show_disassem): Update.
5547         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
5548         method.
5549         <is_visible>: Remove field.
5550         * tui/tui-data.c (tui_next_win, tui_prev_win)
5551         (tui_delete_invisible_windows): Update.
5552
5553 2019-08-16  Tom Tromey  <tom@tromey.com>
5554
5555         * tui/tui-winsource.h (struct tui_source_window_base)
5556         <m_has_locator>: Remove.
5557         * tui/tui-layout.c (show_source_disasm_command, show_data)
5558         (show_source_or_disasm_and_command): Update.
5559
5560 2019-08-16  Alan Hayward  <alan.hayward@arm.com>
5561
5562         * NEWS (Other MI changes): New subsection.
5563         * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
5564         (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
5565         * arch-utils.c (default_get_pc_address_flags): New function.
5566         * arch-utils.h (default_get_pc_address_flags): New declaration.
5567         * gdbarch.sh: Add get_pc_address_flags.
5568         * gdbarch.c: Regenerate.
5569         * gdbarch.h: Likewise.
5570         * stack.c (print_pc): New function.
5571         (print_frame_info) (print_frame): Call print_pc.
5572
5573 2019-08-16  Tom de Vries  <tdevries@suse.de>
5574
5575         * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
5576         print_objfile_section_info.
5577
5578 2019-08-15  Tom Tromey  <tom@tromey.com>
5579
5580         * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
5581         calling update_cmdwin_start_line.
5582         * tui/tui-winsource.h (struct tui_source_window_base)
5583         <do_make_visible_with_new_height, set_new_height>: Don't declare.
5584         <rerender>: Declare.
5585         * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
5586         Call rerender.
5587         (tui_source_window_base::set_new_height): Remove.
5588         (tui_source_window_base::rerender): Rename from
5589         do_make_visible_with_new_height.
5590         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
5591         resize method.
5592         (tui_win_info::make_invisible_and_set_new_height)
5593         (tui_win_info::make_visible_with_new_height): Remove.
5594         * tui/tui-stack.h (struct tui_locator_window) <rerender>:
5595         Declare.
5596         * tui/tui-stack.c (tui_locator_window::rerender): New method.
5597         * tui/tui-regs.h (struct tui_data_window) <set_new_height,
5598         do_make_visible_with_new_height>: Don't declare.
5599         <rerender>: Declare.
5600         * tui/tui-regs.c (tui_data_window::rerender): Rename from
5601         set_new_height.
5602         (tui_data_window::do_make_visible_with_new_height): Remove.
5603         * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
5604         call tui_show_locator_content.
5605         (tui_gen_win_info::resize): Call rerender.
5606         (show_source_or_disasm_and_command): Don't call
5607         tui_show_locator_content.
5608         * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
5609         method.
5610         (struct tui_win_info) <rerender>: Declare.
5611         <set_new_height, make_invisible_and_set_new_height,
5612         make_visible_with_new_height>: Don't declare.
5613         * tui/tui-data.c (tui_win_list::rerender): New method.
5614         * tui/tui-command.h (struct tui_cmd_window)
5615         <do_make_visible_with_new_height>: Don't declare.
5616         * tui/tui-command.c
5617         (tui_cmd_window::do_make_visible_with_new_height): Remove.
5618
5619 2019-08-15  Tom Tromey  <tromey@adacore.com>
5620
5621         * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
5622         * ada-lang.c (ada_enum_name): Likewise.
5623
5624 2019-08-15  Christian Biesinger  <cbiesinger@google.com>
5625
5626         * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
5627         leading underscore.
5628         (GdbOutputErrorFile): Likewise.
5629         (global scope): Adjust constructor calls to GdbOutput{,Error}File
5630         accordingly.
5631         (execute_unwinders): Rename to have a leading underscore.
5632         (auto_load_packages): Likewise.
5633         (global scope): Adjust call to auto_load_packages accordingly.
5634         (GdbSetPythonDirectory): Likewise.
5635         * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
5636         instead of execute_unwinders.
5637
5638 2019-08-15  Tom Tromey  <tom@tromey.com>
5639
5640         * tui/tui-layout.c (show_layout, show_source_disasm_command)
5641         (show_data): Don't change window visibility.
5642         (tui_gen_win_info::resize): Remove special case for command
5643         window.  Use wresize, when available.
5644         (show_source_or_disasm_and_command): Don't change window
5645         visibility.
5646         * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
5647         <make_visible>: New method.
5648         * tui/tui-command.c (tui_cmd_window::resize): New method.
5649
5650 2019-08-15  Tom Tromey  <tom@tromey.com>
5651
5652         * tui/tui-winsource.h (struct tui_source_window_iterator): New.
5653         (struct tui_source_windows): New.
5654         * tui/tui-winsource.c (tui_display_main): Update.
5655         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
5656         (new_height_ok, parse_scrolling_args): Update.
5657         * tui/tui-layout.c (show_layout, show_data): Update.
5658         * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
5659         (tui_add_to_source_windows): Don't declare.
5660         * tui/tui-data.c (source_windows, tui_source_windows)
5661         (tui_clear_source_windows, tui_add_to_source_windows): Remove.
5662
5663 2019-08-15  Tom Tromey  <tom@tromey.com>
5664
5665         * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
5666         Rename from reset.
5667         * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
5668         * tui/tui-layout.c (show_source_disasm_command, show_data):
5669         Update.
5670         (tui_gen_win_info::resize): Rename.
5671         (show_source_or_disasm_and_command): Update.
5672         * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
5673         reset.
5674
5675 2019-08-15  Tom Tromey  <tom@tromey.com>
5676
5677         * tui/tui-stack.c (tui_initialize_static_data): Remove.
5678         * tui/tui-interp.c (tui_interp::init): Don't call
5679         tui_initialize_static_data.
5680         * tui/tui-data.h (tui_initialize_static_data): Don't declare.
5681
5682 2019-08-15  Tom Tromey  <tom@tromey.com>
5683
5684         * tui/tui-layout.c (tui_default_win_viewport_height): Don't
5685         examine tui_win_list.
5686
5687 2019-08-15  Tom Tromey  <tom@tromey.com>
5688
5689         * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
5690         * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
5691         tui_clear_source_content.
5692         (tui_clear_source_content): Remove.
5693         (tui_source_window_base::do_erase_source_content): Hoist call to
5694         content.clear().
5695         * tui/tui-stack.c (tui_show_frame_info): Don't call
5696         tui_clear_source_content.
5697
5698 2019-08-15  Tom Tromey  <tom@tromey.com>
5699
5700         * tui/tui-winsource.h (struct tui_source_window_base)
5701         <do_erase_source_content>: New method.
5702         <erase_source_content>: New method.
5703         (tui_erase_source_content): Don't declare.
5704         * tui/tui-winsource.c (tui_clear_source_content): Update.
5705         (tui_source_window_base::do_erase_source_content): Rename from
5706         tui_erase_source_content.
5707         (tui_source_window_base::show_source_content): Update.
5708         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
5709         * tui/tui-source.h (struct tui_source_window)
5710         <erase_source_content>: New method.
5711         * tui/tui-disasm.h (struct tui_disasm_window)
5712         <erase_source_content>: New method.
5713
5714 2019-08-15  Tom Tromey  <tom@tromey.com>
5715
5716         * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
5717         (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
5718         constructor.
5719         * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
5720         * tui/tui-source.c (tui_set_source_content): Update.
5721         * tui/tui-disasm.c (tui_set_disassem_content): Update.
5722
5723 2019-08-15  Tom Tromey  <tom@tromey.com>
5724
5725         * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
5726         * tui/tui-winsource.c (tui_line_is_displayed): Move to
5727         tui-source.c.
5728         * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
5729         Declare.
5730         * tui/tui-source.c (tui_source_window::line_is_displayed): New
5731         method.
5732         (tui_source_window::maybe_update): Update.
5733
5734 2019-08-15  Tom Tromey  <tom@tromey.com>
5735
5736         * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
5737         * tui/tui-winsource.c (tui_addr_is_displayed): Move to
5738         tui-disasm.c.
5739         * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
5740         Declare.
5741         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
5742         method.
5743         (tui_disasm_window::maybe_update): Update.
5744
5745 2019-08-15  Tom Tromey  <tom@tromey.com>
5746
5747         * tui/tui-winsource.h (struct tui_source_window_base)
5748         <maybe_update>: Declare.
5749         * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
5750         method.
5751         * tui/tui-source.h (struct tui_source_window) <maybe_update>:
5752         Declare.
5753         * tui/tui-source.c (tui_source_window::maybe_update): New method.
5754         * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
5755         Declare.
5756         * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
5757
5758 2019-08-15  Tom Tromey  <tom@tromey.com>
5759
5760         * tui/tui-stack.c (tui_make_status_line): Use string constructor.
5761
5762 2019-08-15  Tom Tromey  <tom@tromey.com>
5763
5764         * tui/tui-wingeneral.c: Include tui-stack.h.
5765         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
5766         (struct tui_locator_window): Move from tui-data.h.
5767         * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
5768         (tui_initialize_static_data): Move from tui-data.c.
5769         * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
5770         (struct tui_locator_window): Move to tui-stack.c.
5771         * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
5772         (tui_initialize_static_data): Move to tui-stack.c.
5773
5774 2019-08-15  Tom Tromey  <tom@tromey.com>
5775
5776         * tui/tui-layout.c (show_source_disasm_command)
5777         (show_source_or_disasm_and_command): Use make_visible method, not
5778         tui_make_window.
5779         * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
5780         Remove.
5781
5782 2019-08-15  Tom Tromey  <tom@tromey.com>
5783
5784         * tui/tui-wingeneral.h (tui_make_window): Update.
5785         * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
5786         parameter.
5787         (tui_gen_win_info::make_visible): Update.
5788         * tui/tui-regs.c (tui_data_window::display_registers_from):
5789         Update.
5790         * tui/tui-layout.c (show_source_disasm_command)
5791         (show_source_or_disasm_and_command): Update.
5792         * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
5793         (enum tui_box): Remove.
5794         (struct tui_win_info) <can_box>: New method.
5795         * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
5796         method.
5797
5798 2019-08-15  Tom de Vries  <tdevries@suse.de>
5799
5800         * linux-nat-trad.c: Include gdbarch.h.
5801
5802 2019-08-14  Alan Hayward  <alan.hayward@arm.com>
5803
5804         * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
5805         register sizes.
5806
5807 2019-08-14  Tom Tromey  <tromey@adacore.com>
5808
5809         * darwin-nat.c: Include gdbarch.h.
5810         * darwin-nat-info.c: Include gdbarch.h.
5811
5812 2019-08-13  Tom Tromey  <tom@tromey.com>
5813
5814         * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
5815         Remove.
5816         * tui/tui-data.c (tui_initialize_static_data): Update.
5817
5818 2019-08-13  Tom Tromey  <tom@tromey.com>
5819
5820         * tui/tui-winsource.h (struct tui_exec_info_window)
5821         <~tui_exec_info_window, maybe_allocate_content, get_content,
5822         m_content>: Remove.
5823         (struct tui_source_window_base) <set_exec_info_content,
5824         show_exec_info_content>: Don't declare.
5825         * tui/tui-winsource.c
5826         (tui_exec_info_window::maybe_allocate_content): Remove.
5827         (tui_source_window_base::update_exec_info): Rename from
5828         set_exec_info_content.
5829         (tui_source_window_base::show_exec_info_content)
5830         (tui_source_window_base::update_exec_info): Remove.
5831
5832 2019-08-13  Tom Tromey  <tom@tromey.com>
5833
5834         * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
5835         declare.
5836         * tui/tui-winsource.c (tui_update_source_window_as_is)
5837         (tui_update_source_windows_with_addr, tui_erase_source_content):
5838         Update.
5839         (tui_clear_exec_info_content): Remove.
5840
5841 2019-08-13  Tom Tromey  <tom@tromey.com>
5842
5843         * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
5844         declare.
5845         * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
5846         call tui_erase_exec_info_content.
5847         (tui_clear_exec_info_content): Rename from
5848         tui_erase_exec_info_content.
5849         (tui_clear_exec_info_content): Delete.
5850
5851 2019-08-13  Tom Tromey  <tom@tromey.com>
5852
5853         * tui/tui-winsource.h (struct tui_source_window_base)
5854         <show_exec_info_content>: Declare.
5855         (tui_show_exec_info_content): Don't declare.
5856         * tui/tui-winsource.c
5857         (tui_source_window_base::show_exec_info_content): Rename from
5858         tui_show_exec_info_content.
5859         (tui_source_window_base::update_exec_info): Update.
5860
5861 2019-08-13  Tom Tromey  <tom@tromey.com>
5862
5863         * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
5864         (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
5865         (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
5866         * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
5867         tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
5868         (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
5869         ... here.
5870
5871 2019-08-13  Tom Tromey  <tom@tromey.com>
5872
5873         * tui/tui-winsource.h (struct tui_source_window_base)
5874         <update_exec_info>: Declare.
5875         (tui_update_exec_info): Don't declare.
5876         * tui/tui-winsource.c (tui_update_source_window_as_is)
5877         (tui_source_window_base::refresh_all)
5878         (tui_update_all_breakpoint_info): Update.
5879         (tui_source_window_base::update_exec_info): Rename from
5880         tui_update_exec_info.
5881         * tui/tui-stack.c (tui_show_frame_info): Update.
5882
5883 2019-08-13  Tom Tromey  <tom@tromey.com>
5884
5885         * tui/tui-winsource.h (struct tui_source_window_base)
5886         <set_exec_info_content>: Declare.
5887         (tui_set_exec_info_content): Don't declare.
5888         * tui/tui-winsource.c
5889         (tui_source_window_base::set_exec_info_content): Rename from
5890         tui_set_exec_info_content.
5891         (tui_update_exec_info): Update.
5892
5893 2019-08-13  Tom Tromey  <tom@tromey.com>
5894
5895         * tui/tui-winsource.h (struct tui_source_window_base)
5896         <show_source_content>: Declare.
5897         (tui_show_source_content): Don't declare.
5898         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
5899         (tui_source_window_base::show_source_content): Rename from
5900         tui_show_source_content.
5901         (tui_source_window_base::refresh_all): Update.
5902         * tui/tui-layout.c (show_source_disasm_command)
5903         (show_source_or_disasm_and_command): Update.
5904
5905 2019-08-13  Tom Tromey  <tom@tromey.com>
5906
5907         * tui/tui-winsource.c (tui_erase_source_content)
5908         (tui_show_source_content, tui_source_window_base::refresh_all):
5909         Update.
5910         * tui/tui-wingeneral.h
5911         (tui_check_and_display_highlight_if_needed): Don't declare.
5912         * tui/tui-wingeneral.c
5913         (tui_win_info::check_and_display_highlight_if_needed): Rename from
5914         check_and_display_highlight_if_needed.
5915         * tui/tui-win.c (tui_rehighlight_all)
5916         (tui_win_info::make_visible_with_new_height): Update.
5917         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
5918         (tui_data_window::erase_data_content)
5919         (tui_data_window::display_all_data): Update.
5920         * tui/tui-data.h (struct tui_win_info)
5921         <check_and_display_highlight_if_needed>: Declare.
5922
5923 2019-08-13  Tom Tromey  <tom@tromey.com>
5924
5925         * tui/tui-win.c (tui_resize_all): Call
5926         tui_delete_invisible_windows.
5927         * tui/tui-layout.c (show_layout): Call
5928         tui_delete_invisible_windows.
5929         * tui/tui-data.h (tui_delete_invisible_windows): Declare.
5930         * tui/tui-data.c (tui_delete_invisible_windows): New function.
5931
5932 2019-08-13  Tom Tromey  <tom@tromey.com>
5933
5934         * tui/tui-disasm.c (tui_show_disassem): Add assertion.  Don't call
5935         tui_add_win_to_layout.
5936
5937 2019-08-13  Tom Tromey  <tom@tromey.com>
5938
5939         * tui/tui-layout.h (tui_default_win_height): Don't declare.
5940         * tui/tui-layout.c (tui_default_win_height): Now static.
5941
5942 2019-08-13  Tom Tromey  <tom@tromey.com>
5943
5944         * tui/tui-layout.c (show_layout): Unify all layout cases into a
5945         single switch.
5946         (show_source_disasm_command, show_source_or_disasm_and_command):
5947         Don't check current layout.
5948
5949 2019-08-13  Tom Tromey  <tom@tromey.com>
5950
5951         * tui/tui-wingeneral.c (make_all_visible): Remove.
5952         (tui_make_all_invisible): Simplify.
5953         * tui/tui-layout.c (tui_make_all_invisible): Move from
5954         tui-wingeneral.c; simplify.
5955         (show_layout): Hoist call to tui_make_all_invisible.
5956         (show_data): Don't call tui_make_all_invisible.
5957
5958 2019-08-13  Tom Tromey  <tom@tromey.com>
5959
5960         * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
5961         * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
5962
5963 2019-08-13  Tom Tromey  <tom@tromey.com>
5964
5965         * tui/tui-layout.c (current_layout, tui_current_layout): Move from
5966         tui-data.c.
5967         (show_source_disasm_command, show_data)
5968         (show_source_or_disasm_and_command): Don't use
5969         tui_set_current_layout_to.
5970         * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
5971         * tui/tui-data.c (current_layout, tui_current_layout): Move to
5972         tui-layout.c.
5973         (tui_set_current_layout_to): Remove.
5974
5975 2019-08-13  Tom Tromey  <tom@tromey.com>
5976
5977         * tui/tui-layout.c (tui_set_layout): Update.
5978         * tui/tui-data.h (struct tui_layout_def): Remove.
5979         (tui_layout_def): Don't declare.
5980         * tui/tui-data.c (layout_def): Remove.
5981         (tui_layout_def): Remove.
5982
5983 2019-08-13  Tom Tromey  <tom@tromey.com>
5984
5985         * tui/tui-winsource.h (struct tui_source_window_base)
5986         <clear_detail>: No longer "override".
5987         * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
5988         * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
5989         * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
5990         * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
5991         Remove.
5992         * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
5993
5994 2019-08-13  Tom Tromey  <tromey@adacore.com>
5995
5996         * tracepoint.c: Don't include readline.h or history.h.
5997
5998 2019-08-12  Tom Tromey  <tom@tromey.com>
5999
6000         * configure: Rebuild.
6001         * configure.ac: Check for readline 7.
6002         * NEWS: Mention readline 7 requirement.
6003         * README: Update.
6004
6005 2019-08-12  Tom Tromey  <tom@tromey.com>
6006
6007         * mingw-hdep.c (gdb_select): Remove readline hack.
6008
6009 2019-08-09  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
6010
6011         * blockframe.c (find_pc_partial_function): Set *block to nullptr
6012         when the function fails.
6013
6014 2019-08-09  Andreas Arnez  <arnez@linux.ibm.com>
6015
6016         * s390-tdep.c (s390_type_align): New function.
6017         (s390_gdbarch_init): Set it as type_align gdbarch method.
6018
6019 2019-08-09  Tom de Vries  <tdevries@suse.de>
6020
6021         PR gdb/24591
6022         * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
6023         pc_low with relocation offset.
6024
6025 2019-08-07  Tom Tromey  <tromey@adacore.com>
6026
6027         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
6028         (print_frame_args): Update.
6029         * python/py-framefilter.c (py_print_single_arg, enumerate_args):
6030         Update.
6031         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
6032         * frame.h (struct frame_arg): Add initializers.
6033         <error>: Now a unique_xmalloc_ptr.
6034
6035 2019-08-07  Alan Hayward  <alan.hayward@arm.com>
6036
6037         * NEWS: Expand the Pointer Authentication entry.
6038         * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
6039         (aarch64_frame_unmask_lr): ... to this.
6040         (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
6041         Call aarch64_frame_unmask_lr.
6042         * frame.c (struct frame_info): Add "masked" variable.
6043         (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
6044         (fprint_frame): Check for masked pc.
6045         * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
6046         declarations.
6047         * python/py-framefilter.c (py_print_frame): Check for masked pc.
6048         * stack.c (print_frame): Check for masked pc.
6049
6050 2019-08-06  Tom Tromey  <tom@tromey.com>
6051
6052         * stabsread.c (patch_block_stabs, read_one_struct_field)
6053         (read_enum_type): Use obstack_strndup.
6054         * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
6055         * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
6056         * dwarf2read.c (guess_full_die_structure_name)
6057         (anonymous_struct_prefix): Use obstack_strndup.
6058         * dbxread.c (cp_set_block_scope): Use obstack_strndup.
6059         * c-exp.y (yylex): Use obstack_strndup.
6060         * ada-exp.y (write_object_renaming, write_ambiguous_var)
6061         (write_var_or_type): Use obstack_strndup.
6062
6063 2019-08-06  Tom Tromey  <tom@tromey.com>
6064
6065         * symfile.c (reread_symbols): Use obstack_strdup.
6066         * stabsread.c (read_type): Use obstack_strdup.
6067         * gdb_obstack.h (obstack_strdup): New overload.
6068         * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
6069         (create_dwo_unit_in_dwp_v2, build_error_marker_type)
6070         (dwarf2_canonicalize_name): Use obstack_strdup.
6071         * dbxread.c (read_dbx_symtab): Use obstack_strdup.
6072         * cp-support.c (inspect_type, replace_typedefs_qualified_name):
6073         Use obstack_strdup.
6074
6075 2019-08-06  Tom Tromey  <tom@tromey.com>
6076
6077         * gdb_obstack.h (obstack_strdup): Define.
6078         * gdb_obstack.c (obstack_strdup): Don't define.
6079
6080 2019-08-06  Tom Tromey  <tom@tromey.com>
6081
6082         * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
6083         obstack_strdup.
6084         * typeprint.c (typedef_hash_table::find_global_typedef): Use
6085         obstack_strdup.
6086         * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
6087         * stabsread.c (common_block_start): Use obstack_strdup.
6088         * objfiles.c (set_objfile_main_name, objfile): Use
6089         obstack_strdup.
6090         * namespace.c (add_using_directive): Use obstack_strdup.
6091         * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
6092         * jit.c (finalize_symtab): Use obstack_strdup.
6093         * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
6094         (guess_partial_die_structure_name, partial_die_info::fixup)
6095         (dwarf2_name): Use obstack_strdup.
6096         * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
6097         obstack_strdup.
6098         * c-exp.y (scan_macro_expansion): Use obstack_strdup.
6099         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
6100         obstack_strdup.
6101         * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
6102
6103 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6104
6105         * unittests/help-doc-selftests.c: New file.
6106         * Makefile.in: Add the new file.
6107
6108 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6109
6110         * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
6111         * cli/cli-decode.c (print_doc_line): Likewise.  It now prints
6112         the full first line, except when FOR_VALUE_PREFIX.  In this case,
6113         the trailing '.' is not output, and the first character is uppercased.
6114         (print_help_for_command): Update call to print_doc_line.
6115         (print_doc_of_command): Likewise.
6116         * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
6117         * cli/cli-option.c (append_indented_doc): Do not append newline.
6118         (build_help_option): Append newline after first appended_indented_doc
6119         only if a second call is done.
6120         (build_help): Append 2 new lines before each option, except the first
6121         one.
6122         * compile/compile.c (_initialize_compile): Add new lines after
6123         %OPTIONS%, when not at the end of the help.
6124         Change help doc or code
6125         producing the help doc to respect the invariants.
6126         * maint-test-options.c (_initialize_maint_test_options): Likewise.
6127         Also removed the new line after 'Options:', as all other commands
6128         do not put an empty line between 'Options:' and the first option.
6129         * printcmd.c (_initialize_printcmd): Likewise.
6130         * stack.c (_initialize_stack): Likewise.
6131         * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
6132         incorrectly telling COMMAND is optional.
6133         * ada-lang.c (_initialize_ada_language): Change help doc or code
6134         producing the help doc to respect the invariants.
6135         * ada-tasks.c (_initialize_ada_tasks): Likewise.
6136         * breakpoint.c (_initialize_breakpoint): Likewise.
6137         * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
6138         * cli/cli-logging.c (_initialize_cli_logging): Likewise.
6139         * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
6140         * cli/cli-style.c (cli_style_option::add_setshow_commands,
6141         _initialize_cli_style): Likewise.
6142         * corelow.c (core_target_info): Likewise.
6143         * dwarf-index-cache.c (_initialize_index_cache): Likewise.
6144         * dwarf2read.c (_initialize_dwarf2_read): Likewise.
6145         * filesystem.c (_initialize_filesystem): Likewise.
6146         * frame.c (_initialize_frame): Likewise.
6147         * gnu-nat.c (add_task_commands): Likewise.
6148         * infcall.c (_initialize_infcall): Likewise.
6149         * infcmd.c (_initialize_infcmd): Likewise.
6150         * interps.c (_initialize_interpreter): Likewise.
6151         * language.c (_initialize_language): Likewise.
6152         * linux-fork.c (_initialize_linux_fork): Likewise.
6153         * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
6154         * maint.c (_initialize_maint_cmds): Likewise.
6155         * memattr.c (_initialize_mem): Likewise.
6156         * printcmd.c (_initialize_printcmd): Likewise.
6157         * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
6158         _RegEx): Likewise.
6159         * ravenscar-thread.c (_initialize_ravenscar): Likewise.
6160         * record-btrace.c (_initialize_record_btrace): Likewise.
6161         * record-full.c (_initialize_record_full): Likewise.
6162         * record.c (_initialize_record): Likewise.
6163         * regcache-dump.c (_initialize_regcache_dump): Likewise.
6164         * regcache.c (_initialize_regcache): Likewise.
6165         * remote.c (add_packet_config_cmd, init_remote_threadtests,
6166         _initialize_remote): Likewise.
6167         * ser-tcp.c (_initialize_ser_tcp): Likewise.
6168         * serial.c (_initialize_serial): Likewise.
6169         * skip.c (_initialize_step_skip): Likewise.
6170         * source.c (_initialize_source): Likewise.
6171         * stack.c (_initialize_stack): Likewise.
6172         * symfile.c (_initialize_symfile): Likewise.
6173         * symtab.c (_initialize_symtab): Likewise.
6174         * target-descriptions.c (_initialize_target_descriptions): Likewise.
6175         * top.c (init_main): Likewise.
6176         * tracefile-tfile.c (tfile_target_info): Likewise.
6177         * tracepoint.c (_initialize_tracepoint): Likewise.
6178         * tui/tui-win.c (_initialize_tui_win): Likewise.
6179         * utils.c (add_internal_problem_command): Likewise.
6180         * valprint.c (value_print_option_defs): Likewise.
6181
6182 2019-08-06  Frank Ch. Eigler  <fche@redhat.com>
6183
6184         PR build/24886
6185         * configure.ac: Drop enable-libmcheck support.
6186         * configure, config.in: Rebuild.
6187         * libmcheck.m4: Remove.
6188         * acinclude.m4: Don't include it.
6189         * Makefile.in: Don't distribute it.
6190         * top.c (print_gdb_configuration): Don't mention it.
6191
6192 2019-08-06  Tom Tromey  <tom@tromey.com>
6193
6194         * utils.c (set_output_style): Sometimes pass stream to
6195         emit_style_escape.
6196         * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
6197         * record-btrace.c (btrace_insn_history): Update.
6198         * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
6199         method.
6200         * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
6201         Update initializers.
6202         <m_uiout>: New field.
6203         <m_di>: Move lower.
6204         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
6205         Remove "uiout" parameter.
6206         (dump_insns): Update.
6207         * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
6208         * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
6209
6210 2019-08-06  Christian Biesinger  <cbiesinger@google.com>
6211
6212         * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
6213         (error_in_psymtab_expansion): Likewise.
6214         (lookup_symbol_via_quick_fns): Likewise.
6215         (basic_lookup_transparent_type_quick): Likewise.
6216         (basic_lookup_transparent_type_1): Likewise.
6217
6218 2019-08-06  Tom Tromey  <tromey@adacore.com>
6219
6220         * source.c (last_source_error): Now bool.
6221         (print_source_lines_base): Make "noprint" bool.  Only open
6222         source file when last_source_visited changes.
6223
6224 2019-08-06  Tom Tromey  <tromey@adacore.com>
6225
6226         * annotate.c (annotate_source_line): Use g_source_cache.
6227         * source-cache.c (source_cache::get_plain_source_lines): Change
6228         parameters.  Populate m_offset_cache.
6229         (source_cache::ensure): New method.
6230         (source_cache::get_line_charpos): New method.
6231         (extract_lines): Move lower.  Change parameters.
6232         (source_cache::get_source_lines): Move lower.
6233         * source-cache.h (class source_cache): Update comment.
6234         <get_line_charpos>: New method.
6235         <get_source_lines>: Update comment.
6236         <clear>: Clear m_offset_cache.
6237         <get_plain_source_lines>: Change parameters.
6238         <ensure>: New method
6239         <m_offset_cache>: New member.
6240         * source.c (forget_cached_source_info_for_objfile): Update.
6241         (info_source_command): Use g_source_cache.
6242         (find_source_lines, open_source_file_with_line_charpos): Remove.
6243         (print_source_lines_base, search_command_helper): Use g_source_cache.
6244         * source.h (open_source_file_with_line_charpos): Don't declare.
6245         * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
6246         * tui/tui-source.c (tui_source_window::do_scroll_vertical):
6247         Use g_source_cache.
6248
6249 2019-08-06  Tom Tromey  <tromey@adacore.com>
6250
6251         * source-cache.c (source_cache::get_plain_source_lines):
6252         Remove "first_line" and "last_line" parameters.
6253         (source_cache::get_source_lines): Cache plain text.
6254         * source-cache.h (class source_cache)
6255         <get_plain_source_lines>: Update.
6256
6257 2019-08-06  Tom Tromey  <tromey@adacore.com>
6258
6259         * source-cache.c (extract_lines): No longer a method.
6260         Changed type of parameter.  Include final newline.
6261         (selftests::extract_lines_test): New function.
6262         (_initialize_source_cache): Likewise.
6263         * source-cache.h (class source_cache)
6264         <extract_lines>: Don't declare.
6265
6266 2019-08-06  Tom Tromey  <tromey@adacore.com>
6267
6268         * breakpoint.c (init_breakpoint_sal): Update.
6269         (breakpoint): Update.
6270         * breakpoint.h (struct breakpoint) <filter>: Now a
6271         unique_xmalloc_ptr.
6272
6273 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
6274
6275         * NEWS: Mention dictionary access on blocks.
6276         * python/py-block.c (blpy_getitem): New function.
6277         (block_object_as_mapping): New struct.
6278         (block_object_type): Use new struct for tp_as_mapping field.
6279
6280 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
6281
6282         * objfiles.h (objfile): Add a comment describing partial symbols.
6283
6284 2019-08-05  Tom Tromey  <tromey@adacore.com>
6285
6286         * compile/compile.c (_initialize_compile): Use _(), not N_().
6287         * thread.c (_initialize_thread): Use _(), not N_().
6288         * stack.c (_initialize_stack): Use _(), not N_().
6289         * printcmd.c (_initialize_printcmd): Use _(), not N_().
6290
6291 2019-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
6292
6293         * dwarf2read.c (struct dw2_symtab_iterator):
6294         <want_specific_block>: Remove.
6295         <block_index>: Change type to gdb::optional.
6296         (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
6297         change type of BLOCK_INDEX parameter to gdb::optional.
6298         (dw2_symtab_iter_next): Re-write in function of gdb::optional.
6299         (dw2_lookup_symbol): Don't pass argument for
6300         WANT_SPECIFIC_BLOCK.
6301         (dw2_expand_symtabs_for_function): Don't pass argument for
6302         WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
6303         (class dw2_debug_names_iterator)
6304         <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
6305         parameter, change BLOCK_INDEX type to gdb::optional.
6306         <m_want_specific_block>: Remove.
6307         <m_block_index>: Change type to gdb::optional.
6308         (dw2_debug_names_iterator::next): Change type of IS_STATIC to
6309         gdb::optional.  Re-write in function of gdb::optional.
6310         (dw2_debug_names_lookup_symbol): Don't pass argument for
6311         WANT_SPECIFIC_BLOCK.
6312         (dw2_debug_names_expand_symtabs_for_function): Don't pass
6313         argument for WANT_SPECIFIC_BLOCK, pass empty optional for
6314         BLOCK_INDEX.
6315
6316 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6317
6318         * NEWS: Mention changes to "info sources" command.
6319
6320 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6321
6322         * symtab.c (filename_partial_match_opts): New struct type.
6323         (struct output_source_filename_data): New members
6324         regexp, c_regexp, partial_match.
6325         (output_source_filename): Use new members to decide to print file.
6326         (info_sources_option_defs): New variable.
6327         (make_info_sources_options_def_group, print_info_sources_header,
6328         info_sources_command_completer):
6329         New functions.
6330         (info_sources_command): Read new optional arguments.
6331         (_initialize_symtab): Update info sources help.
6332
6333 2019-08-02  Alexandre Oliva <oliva@adacore.com>
6334
6335         * ada-lang.c (exception_support_info_v0): Renamed from...
6336         (default_exception_support_info): ... this.  Create new
6337         definition for v1.
6338         (ada_has_this_exception_support): Look up catch_handlers_sym.
6339         (ada_exception_support_info_sniffer): Try v0 after default.
6340
6341 2019-08-01  Tom Tromey  <tromey@adacore.com>
6342
6343         * ia64-libunwind-tdep.h (struct libunwind_descr): Include
6344         gdbarch.h.
6345
6346 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
6347
6348         * s12z-tdep.c: Fix include path for s12z-opc.h.
6349
6350 2019-08-01  Alan Hayward  <alan.hayward@arm.com>
6351
6352         * NEWS: Require GNU make 3.82.
6353
6354 2019-07-16  Tom Tromey  <tom@tromey.com>
6355
6356         * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
6357         declare.
6358
6359 2019-07-30  Tom Tromey  <tromey@adacore.com>
6360
6361         * block.c (contained_in): Remove BLOCK_FUNCTION check.
6362
6363 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
6364
6365         * printcmd.c (print_address_symbolic): Print negative offsets.
6366         (build_address_symbolic): Force signed arithmetic when computing
6367         offset.
6368
6369 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
6370
6371         PR/24474: Add a function to lookup static variables.
6372         * NEWS: Mention this new function.
6373         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
6374         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
6375         * python/python.c (python_GdbMethods): Add new function.
6376
6377 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
6378
6379         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
6380         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
6381         (objfpy_lookup_static_symbol): New function.
6382         (objfile_object_methods): Add new functions.
6383
6384 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6385
6386         * NEWS: Mention 'set|show print frame-info'.  Mention new
6387         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
6388         backtrace argument.  Mention that python frame filtering code
6389         is now consistent with what 'backtrace' command prints.
6390
6391 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6392
6393         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
6394         comments.
6395         (print_frame_info_auto, print_frame_info_source_line,
6396         print_frame_info_location, print_frame_info_source_and_location,
6397         print_frame_info_location_and_address, print_frame_info_short_location):
6398         New declarations.
6399         (struct frame_print_options): New member print_frame_info.
6400         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
6401         * stack.h (get_user_print_what_frame_info): New declaration.
6402         (frame_show_address): New declaration.
6403         * stack.c (print_frame_arguments_choices): New value 'presence'.
6404         (print_frame_info_auto, print_frame_info_source_line,
6405         print_frame_info_location, print_frame_info_source_and_location,
6406         print_frame_info_location_and_address, print_frame_info_short_location,
6407         print_frame_info_choices, print_frame_info_print_what): New definitions.
6408         (print_frame_args): Only print dots for args if print frame-arguments
6409         is 'presence'.
6410         (frame_print_option_defs): New element for "frame-info".
6411         (get_user_print_what_frame_info): New function.
6412         (frame_show_address): Make non static.  Move comment to stack.h.
6413         (print_frame_info_to_print_what): New function.
6414         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
6415         to decide what to print.
6416         (backtrace_command_1): Handle the new print_frame_arguments_presence
6417         value.
6418         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
6419         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
6420         (py_print_frame): In non-mi mode, use LOCATION as default for
6421         print_what, similarly to frame information printed directly by
6422         backtrace command. Handle frame-info user option in non MI mode.
6423
6424 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
6425
6426         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
6427         Add case for debugging 32-bit target on 64-bit host.  Revise
6428         comment.
6429
6430 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
6431
6432         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
6433         instead of find_function_entry_range_from_pc.
6434
6435 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
6436
6437         * stack.c (find_frame_funname): Remove code which preferred
6438         minsym over symtab sym in "certain pathological cases".
6439
6440         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
6441         parameter.  Change type of "do_demangle" to bool.
6442         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
6443         Pass suitable "prefer_sym_over_minsym" flag to
6444         build_address_symbolic().  Don't output "+" for negative offsets.
6445         * printcmd.c (print_address_symbolic): Update invocation of
6446         build_address_symbolic to include a "prefer_sym_over_minsym"
6447         flag.
6448         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
6449         Restrict cases in which use of minimal symbol is preferred to that
6450         of a found symbol.  Update comments.
6451
6452         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
6453         for entry pc when entry pc is out of range for that FDE.
6454
6455 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
6456
6457         PR gdb/24839:
6458         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
6459         type.
6460
6461 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
6462
6463         * python/py-objfile.c (add_separate_debug_file): Fix comment about
6464         this function's Python signature.
6465
6466
6467 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
6468
6469         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
6470         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
6471         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
6472         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
6473         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
6474
6475
6476 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
6477
6478         * h8300-tdep.c (h8300_register_name_common): New.
6479         h8300_register_name): Use h8300_register_name_common.
6480         (h8300s_register_name): Likewise.
6481         (h8300sx_register_name): Likewise.
6482         (h8300h_register_nam): New.
6483         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
6484
6485
6486 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
6487
6488         * arm-tdep.c (arm_skip_cmse_entry): New function.
6489         (arm_is_sgstubs_section): New function.
6490         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
6491
6492 2019-07-22  Tom Tromey  <tom@tromey.com>
6493
6494         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
6495         Don't self-assign.
6496
6497 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
6498
6499         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
6500         type_print.
6501
6502 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
6503
6504         * symtab.c (search_symbols): Adjust msymbol matching type arrays
6505         so that GDB doesn't match any msymbols when searching in the
6506         TYPES_DOMAIN.
6507         (print_symbol_info): Print using typedef_print or type_print based
6508         on the type of the symbol.  Add updated FIXME comment moved from...
6509         (_initialize_symtab): ... move and update FIXME comment to above.
6510
6511 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
6512
6513         * NEWS: Mention adding -q option to "info types".
6514         * symtab.c (struct info_types_options): New struct.
6515         (info_types_options_defs): New variable.
6516         (make_info_types_options_def_group): New function.
6517         (info_types_command): Use gdb::option framework to parse options.
6518         (info_types_command_completer): New function.
6519         (_initialize_symtab): Extend the help text on "info types" and
6520         register command completer.
6521
6522 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
6523
6524         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
6525         (lookup_symbol_in_objfile): Change int to block_enum and add a
6526         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
6527
6528 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
6529
6530         * MAINTAINERS (Write After Approval): Add self.
6531
6532 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
6533
6534         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
6535         instruction to the dummy code region.
6536
6537 2019-07-19  Tom Tromey  <tromey@adacore.com>
6538
6539         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
6540         (ARGSUSED, PARAMS, __func__): Remove rules.
6541
6542 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
6543
6544         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
6545         * features/arm/arm-with-iwmmxt.c: Remove.
6546         * features/arm/arm-with-iwmmxt.xml: Remove.
6547         * features/arm/arm-with-m-fpa-layout.c: Remove.
6548         * features/arm/arm-with-m-fpa-layout.xml: Remove.
6549         * features/arm/arm-with-m-vfp-d16.c: Remove.
6550         * features/arm/arm-with-m-vfp-d16.xml: Remove.
6551         * features/arm/arm-with-m.c: Remove.
6552         * features/arm/arm-with-m.xml: Remove.
6553         * features/arm/arm-with-neon.c: Remove.
6554         * features/arm/arm-with-neon.xml: Remove.
6555         * features/arm/arm-with-vfpv2.c: Remove.
6556         * features/arm/arm-with-vfpv2.xml: Remove.
6557         * features/arm/arm-with-vfpv3.c: Remove.
6558         * features/arm/arm-with-vfpv3.xml: Remove.
6559
6560 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
6561
6562         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
6563
6564 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
6565
6566         * arch/aarch32.c (aarch32_create_target_description): Create
6567         target descriptions using features.
6568         * arch/arm.c (arm_create_target_description)
6569         (arm_create_mprofile_target_description): Likewise.
6570         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
6571
6572 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
6573
6574         * Makefile.in: Add new files.
6575         * aarch32-tdep.c: New file.
6576         * aarch32-tdep.h: New file.
6577         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
6578         Call aarch32_read_description.
6579         * arch/aarch32.c: New file.
6580         * arch/aarch32.h: New file.
6581         * arch/arm.c (arm_create_target_description)
6582         (arm_create_mprofile_target_description): New function.
6583         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
6584         (arm_create_target_description)
6585         (arm_create_mprofile_target_description): New declaration.
6586         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
6587         read_description functions.
6588         * arm-linux-nat.c (arm_linux_nat_target::read_description):
6589         Likewise.
6590         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
6591         * arm-tdep.c (tdesc_arm_list): New variable.
6592         (arm_register_g_packet_guesses): Call create description functions.
6593         (arm_read_description) (arm_read_mprofile_description): New
6594         function.
6595         * arm-tdep.h (arm_read_description)
6596         (arm_read_mprofile_description): Add declaration.
6597         * configure.tgt: Add new files.
6598
6599 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
6600
6601         * top.c (new_ui_command): Open specified terminal just once.
6602
6603 2019-07-18  Tom Tromey  <tromey@adacore.com>
6604
6605         * symtab.c (main_name): Constify return type.
6606         * symfile.c (set_initial_language): Update.
6607         * symtab.h (main_name): Constify return type.
6608
6609 2019-07-17  Tom Tromey  <tom@tromey.com>
6610
6611         * tui/tui-winsource.c (tui_update_source_window)
6612         (tui_update_source_window_as_is)
6613         (tui_update_source_windows_with_line): Remove return.
6614         * tui/tui-disasm.c (tui_show_disassem)
6615         (tui_show_disassem_and_update_source): Remove return.
6616         * tui/tui.c (tui_reset): Remove return.
6617         * tui/tui-wingeneral.c
6618         (tui_check_and_display_highlight_if_needed): Remove return.
6619
6620 2019-07-17  Tom Tromey  <tom@tromey.com>
6621
6622         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
6623
6624 2019-07-17  Tom Tromey  <tom@tromey.com>
6625
6626         * tui/tui-winsource.h (struct tui_exec_info_window)
6627         (struct tui_source_window_base): Move from tui-data.h.
6628         * tui/tui-winsource.c: Move many method definitions from
6629         elsewhere.  Remove "structuring" comments.
6630         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
6631         (tui_source_window_base::refresh_window): Move to
6632         tui-winsource.c.
6633         * tui/tui-win.c (tui_source_window_base::refresh_all)
6634         (tui_source_window_base::update_tab_width)
6635         (tui_source_window_base::set_new_height)
6636         (tui_source_window_base::do_make_visible_with_new_height): Move to
6637         tui-winsource.c.
6638         * tui/tui-source.h: Update.
6639         * tui/tui-source.c (tui_source_window_base::reset): Move to
6640         tui-winsource.c.
6641         * tui/tui-disasm.h: Update.
6642         * tui/tui-data.h (struct tui_exec_info_window): Move to
6643         tui-winsource.h.
6644         (struct tui_source_window_base): Likewise.
6645         * tui/tui-data.c (tui_source_window_base::clear_detail)
6646         (tui_source_window_base, ~tui_source_window_base): Move to
6647         tui-winsource.c.
6648
6649 2019-07-17  Tom Tromey  <tom@tromey.com>
6650
6651         * tui/tui-win.c (tui_resize_all)
6652         (tui_source_window_base::update_tab_width)
6653         (tui_adjust_win_heights): Update.
6654         (tui_win_info::make_invisible_and_set_new_height): Rename from
6655         make_invisible_and_set_new_height.
6656         * tui/tui-data.h (struct tui_win_info)
6657         <make_invisible_and_set_new_height>: New method.
6658
6659 2019-07-17  Tom Tromey  <tom@tromey.com>
6660
6661         * tui/tui.c: Update.
6662         * tui/tui-source.h (struct tui_source_window): Move from
6663         tui-data.h.
6664         * tui/tui-layout.c: Update.
6665         * tui/tui-disasm.c: Update.
6666         * tui/tui-data.h (struct tui_source_window): Move to
6667         tui-source.h.
6668
6669 2019-07-17  Tom Tromey  <tom@tromey.com>
6670
6671         * tui/tui-disasm.h (struct tui_disasm_window): Move from
6672         tui-data.h.
6673         * tui/tui-data.h (struct tui_disasm_window): Move to
6674         tui-disasm.h.
6675
6676 2019-07-17  Tom Tromey  <tom@tromey.com>
6677
6678         * tui/tui-regs.h (struct tui_data_item_window): Move from
6679         tui-data.h.
6680         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
6681         * tui/tui-data.h (struct tui_data_item_window): Move to
6682         tui-regs.h.
6683         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
6684
6685 2019-07-17  Tom Tromey  <tom@tromey.com>
6686
6687         * tui/tui.c: Update.
6688         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
6689         (tui_cmd_window::max_height): Move to tui-command.c.
6690         * tui/tui-layout.c: Update.
6691         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
6692         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
6693         tui-command.c.
6694         * tui/tui-command.h (struct tui_cmd_window): Move from
6695         tui-data.h.
6696         * tui/tui-command.c: Remove "structuring" comments.
6697         (tui_cmd_window::clear_detail)
6698         (tui_cmd_window::do_make_visible_with_new_height)
6699         (tui_cmd_window::max_height): Move from elsewhere.
6700
6701 2019-07-17  Tom Tromey  <tom@tromey.com>
6702
6703         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
6704         Now static.
6705         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
6706         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
6707
6708 2019-07-17  Tom Tromey  <tom@tromey.com>
6709
6710         * tui/tui.c: Update.
6711         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
6712         tui-regs.c.
6713         * tui/tui-windata.h: Remove file.
6714         * tui/tui-windata.c: Remove file.
6715         * tui/tui-win.c (tui_data_window::set_new_height)
6716         (tui_data_window::do_make_visible_with_new_height): Move to
6717         tui-regs.c.
6718         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
6719         * tui/tui-regs.c: Remove "structuring" comments.
6720         (tui_data_window::first_data_item_displayed)
6721         (tui_data_window::delete_data_content_windows)
6722         (tui_data_window::erase_data_content)
6723         (tui_data_window::display_all_data)
6724         (tui_data_window::refresh_all)
6725         (tui_data_window::do_scroll_vertical)
6726         (tui_data_window::clear_detail, tui_data_window::set_new_height)
6727         (tui_data_window::do_make_visible_with_new_height)
6728         (tui_data_window::refresh_window): Move from elsewhere.
6729         (_initialize_tui_regs): Move to end of file.
6730         * tui/tui-layout.c: Update.
6731         * tui/tui-hooks.c: Update.
6732         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
6733         * tui/tui-data.c (tui_data_window::clear_detail): Move to
6734         tui-regs.c.
6735         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
6736
6737 2019-07-17  Tom Tromey  <tom@tromey.com>
6738
6739         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
6740         seen.
6741
6742 2019-07-17  Tom Tromey  <tom@tromey.com>
6743
6744         * tui/tui-win.c (tui_source_window_base::set_new_height)
6745         (tui_source_window_base::do_make_visible_with_new_height): Use
6746         m_has_locator field directly.
6747         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
6748         method.
6749         (struct tui_source_window_base) <has_locator>: Likewise.
6750
6751 2019-07-17  Tom Tromey  <tom@tromey.com>
6752
6753         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
6754         Don't declare.
6755         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
6756         Remove.
6757         * tui/tui-win.c (tui_source_window_base::set_new_height)
6758         (tui_source_window_base::set_new_height)
6759         (make_invisible_and_set_new_height)
6760         (tui_source_window_base::do_make_visible_with_new_height)
6761         (tui_source_window_base::do_make_visible_with_new_height):
6762         Update.
6763         * tui/tui-layout.c (show_source_disasm_command, show_data)
6764         (show_source_or_disasm_and_command): Update.
6765         * tui/tui-layout.c (show_layout): Update.
6766
6767 2019-07-17  Tom Tromey  <tom@tromey.com>
6768
6769         * tui/tui-layout.c (make_data_window): Remove.
6770         (show_data): Unify creation and re-initialization cases.
6771
6772 2019-07-17  Tom Tromey  <tom@tromey.com>
6773
6774         * tui/tui-layout.c (make_source_window, make_disasm_window):
6775         Remove.
6776         (show_data): Unify creation and re-initialization cases.
6777
6778 2019-07-17  Tom Tromey  <tom@tromey.com>
6779
6780         * tui/tui-layout.c (make_command_window): Remove.
6781         (show_source_disasm_command, show_source_or_disasm_and_command):
6782         Unify creation and re-initialization cases.
6783
6784 2019-07-17  Tom Tromey  <tom@tromey.com>
6785
6786         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
6787         creation and re-initialization cases.
6788
6789 2019-07-17  Tom Tromey  <tom@tromey.com>
6790
6791         * tui/tui-regs.c (tui_get_register): Return void.
6792
6793 2019-07-17  Tom Tromey  <tom@tromey.com>
6794
6795         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
6796         Simplify.
6797
6798 2019-07-17  Tom Tromey  <tom@tromey.com>
6799
6800         * tui/tui-layout.c (show_source_disasm_command): Simplify window
6801         resetting.
6802
6803 2019-07-17  Tom Tromey  <tom@tromey.com>
6804
6805         * tui/tui.h (tui_set_layout_by_name): Don't declare.
6806         * tui/tui-regs.c (tui_reg_layout): New function.
6807         (tui_show_registers, tui_reg_command): Use it.
6808         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
6809         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
6810         parameters.
6811         (tui_layout_command): Remove.
6812
6813 2019-07-17  Tom Tromey  <tom@tromey.com>
6814
6815         * tui/tui-layout.h (tui/tui-layout): Return void.
6816         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
6817
6818 2019-07-17  Tom Tromey  <tom@tromey.com>
6819
6820         * tui/tui-layout.c (show_source_disasm_command, show_data):
6821         Update.
6822         (reset_locator): Remove.
6823         (show_source_or_disasm_and_command): Update.
6824
6825 2019-07-17  Tom Tromey  <tom@tromey.com>
6826
6827         * tui/tui-source.c (tui_source_window_base::reset): Remove
6828         win_type parameter.
6829         * tui/tui-layout.c (make_command_window, make_source_window)
6830         (make_disasm_window, make_data_window)
6831         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
6832         (reset_locator, show_source_or_disasm_and_command): Update.
6833         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
6834         win_type parameter.
6835         (struct tui_source_window_base) <reset>: Likewise.
6836
6837 2019-07-17  Tom Tromey  <tom@tromey.com>
6838
6839         * tui/tui-layout.c (show_source_disasm_command): Use
6840         reset_locator.
6841         (reset_locator): New function.
6842         (init_and_make_win): Remove.
6843         (show_source_or_disasm_and_command): Use reset_locator.
6844
6845 2019-07-17  Tom Tromey  <tom@tromey.com>
6846
6847         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
6848         condition.
6849         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
6850         Remove condition.
6851         * tui/tui-source.c (tui_source_window_base::reset): New method.
6852         * tui/tui-layout.c (make_command_window): Don't call
6853         init_and_make_win.
6854         (make_source_window, make_disasm_window): Don't call
6855         make_source_or_disasm_window.
6856         (make_data_window): Don't call init_and_make_win.  Change calling
6857         convention.
6858         (show_source_disasm_command, show_data): Simplify.
6859         (make_source_or_disasm_window): Remove.
6860         (show_source_or_disasm_and_command): Simplify.
6861         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
6862         (struct tui_source_window_base) <reset>: Likewise.
6863         <execution_info>: Remove initializer.
6864         * tui/tui-data.c (tui_source_window_base): Initialize
6865         execution_info.
6866
6867 2019-07-17  Tom Tromey  <tom@tromey.com>
6868
6869         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
6870         variable.
6871
6872 2019-07-17  Tom Tromey  <tom@tromey.com>
6873
6874         * tui/tui.c (tui_rl_other_window): Update.
6875         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
6876         superclass method first.  Always iterate over regs_content.
6877         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
6878         method.
6879         * tui/tui-win.c (tui_set_focus_command): Update.
6880
6881 2019-07-17  Tom Tromey  <tom@tromey.com>
6882
6883         * tui/tui-win.c (tui_set_focus_command): Rename from
6884         tui_set_focus.  Call tui_enable.
6885         (tui_set_focus_command): Remove.
6886
6887 2019-07-17  Tom Tromey  <tom@tromey.com>
6888
6889         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
6890         refresh_window.
6891         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
6892         touchwin.
6893         (tui_data_window::refresh_window): Call refresh_window on data
6894         items.  Always call superclass refresh_window.
6895         (tui_win_info::refresh): Remove.
6896         (tui_source_window_base::refresh_window): Update.
6897         (tui_refresh_all): Update.
6898         * tui/tui-layout.c (show_source_disasm_command): Remove call to
6899         refresh_window.
6900         (show_source_or_disasm_and_command): Likewise.
6901         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
6902         (struct tui_source_window_base) <refresh>: Likewise.
6903
6904 2019-07-17  Tom Tromey  <tom@tromey.com>
6905
6906         * tui/tui-winsource.c (tui_clear_source_content)
6907         (tui_show_source_content): Update.
6908         * tui/tui-source.c (tui_source_window::showing_source_p): Check
6909         whether content is empty.
6910         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
6911         Remove.
6912
6913 2019-07-17  Tom Tromey  <tom@tromey.com>
6914
6915         * tui/tui-winsource.c (tui_erase_source_content): Clear the
6916         window's contents.
6917         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
6918         * tui/tui-source.c (tui_set_source_content_nil): Remove.
6919
6920 2019-07-17  Tom Tromey  <tom@tromey.com>
6921
6922         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
6923         (struct tui_data_item_window): Update.
6924
6925 2019-07-17  Tom Tromey  <tom@tromey.com>
6926
6927         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
6928         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
6929         defines.
6930
6931 2019-07-17  Tom Tromey  <tom@tromey.com>
6932
6933         * tui/tui-winsource.h (tui_erase_source_content)
6934         (tui_clear_source_content): Remove "display_prompt" parameter.
6935         * tui/tui-winsource.c (tui_update_source_window_as_is)
6936         (tui_update_source_windows_with_addr): Update.
6937         (tui_clear_source_content): Remove "display_prompt" parameter.
6938         (tui_erase_source_content): Likewise.  Simplify.
6939         (tui_show_source_content): Update.
6940         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
6941         * tui/tui-stack.c (tui_show_frame_info): Update.
6942         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
6943         Remove defines.
6944
6945 2019-07-17  Tom Tromey  <tom@tromey.com>
6946
6947         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
6948         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
6949         parameter.
6950         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
6951         parameter.
6952
6953 2019-07-17  Tom Tromey  <tom@tromey.com>
6954
6955         * tui/tui-winsource.c (tui_clear_source_content)
6956         (tui_show_source_content, tui_show_exec_info_content)
6957         (tui_clear_exec_info_content): Update.
6958         * tui/tui-stack.c (tui_show_locator_content): Update.
6959         (tui_show_frame_info): Update.
6960         * tui/tui-source.h (tui_source_window): Don't declare.
6961         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
6962         from tui_source_is_displayed.
6963         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
6964         Remove field.
6965         (struct tui_source_window_base) <content_in_use>: New field.  Now
6966         bool.
6967         (struct tui_source_window) <showing_source_p>: New method.
6968         (TUI_SRC_WIN): Change cast.
6969         * tui/tui-data.c (tui_initialize_static_data): Update.
6970
6971 2019-07-17  Tom Tromey  <tom@tromey.com>
6972
6973         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
6974         location_matches_p.
6975         * tui/tui-source.c (tui_source_window::location_matches_p): New
6976         method.
6977         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
6978         method.
6979         * tui/tui-data.h (struct tui_source_window_base)
6980         <location_matches_p>: New method.
6981         (struct tui_source_window, struct tui_disasm_window)
6982         <location_matches_p>: Likewise.
6983
6984 2019-07-17  Tom Tromey  <tom@tromey.com>
6985
6986         * tui/tui-win.c (tui_set_win_height_command): Rename from
6987         tui_set_win_height.
6988         (tui_set_win_height_command): Remove.
6989
6990 2019-07-17  Tom Tromey  <tom@tromey.com>
6991
6992         * tui/tui-source.c (tui_source_window): New constructor.  Add
6993         observer.
6994         (~tui_source_window): New destructor.
6995         (tui_source_window::style_changed): New method.
6996         * tui/tui-hooks.c (tui_redisplay_source): Remove.
6997         (tui_attach_detach_observers): Update.
6998         * tui/tui-data.h (struct tui_source_window): Make constructor not
6999         inline.  Add destructor.
7000         (struct tui_source_window) <style_changed>: New method.
7001         <m_observable>: New member.
7002
7003 2019-07-17  Tom Tromey  <tom@tromey.com>
7004
7005         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
7006         * tui/tui-win.c (tui_resize_all): Fix typo.
7007
7008 2019-07-17  Tom Tromey  <tom@tromey.com>
7009
7010         * tui/tui-wingeneral.h (tui_refresh_all): Update.
7011         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
7012         (tui_refresh_all): Remove "list" parameter.  Use foreach.
7013         * tui/tui-win.c (window_name_completer): Use foreach.
7014         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
7015         (update_tab_width): Likewise.
7016         * tui/tui-layout.c (show_layout): Update.
7017         * tui/tui-data.h (class tui_window_iterator): New.
7018         (struct all_tui_windows): New.
7019         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
7020
7021 2019-07-17  Tom Tromey  <tom@tromey.com>
7022
7023         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
7024         parameter.  Don't reference globals.
7025         (tui_reg_command): Update.
7026
7027 2019-07-17  Tom Tromey  <tom@tromey.com>
7028
7029         * tui/tui-regs.c (tui_show_registers): Simplify.
7030
7031 2019-07-17  Tom Tromey  <tom@tromey.com>
7032
7033         * tui/tui-regs.c (tui_show_registers): Update.
7034         (tui_show_register_group): Add win_info parameter.
7035
7036 2019-07-17  Tom Tromey  <tom@tromey.com>
7037
7038         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
7039         Rename from tui_display_reg_element_at_line.
7040         (tui_data_window::display_registers_from_line): Update.
7041         * tui/tui-data.h (struct tui_data_window)
7042         <display_reg_element_at_line>: New method.
7043
7044 2019-07-17  Tom Tromey  <tom@tromey.com>
7045
7046         * tui/tui-regs.h (tui_display_registers_from)
7047         (tui_display_registers_from_line): Don't declare.
7048         * tui/tui-windata.c (tui_data_window::display_all_data)
7049         (tui_data_window::refresh_all)
7050         (tui_data_window::do_scroll_vertical): Update.
7051         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
7052         from tui_display_registers_from.
7053         (tui_display_reg_element_at_line): Update.
7054         (tui_data_window::display_registers_from_line): Rename from
7055         tui_display_registers_from_line.
7056         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
7057         display_registers_from_line>: New methods.
7058
7059 2019-07-17  Tom Tromey  <tom@tromey.com>
7060
7061         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
7062         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
7063         from tui_erase_data_content.
7064         (tui_data_window::display_all_data)
7065         (tui_data_window::refresh_all)
7066         (tui_data_window::do_scroll_vertical): Update.
7067         * tui/tui-regs.c (tui_show_registers): Update.
7068         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
7069         New method.
7070
7071 2019-07-17  Tom Tromey  <tom@tromey.com>
7072
7073         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
7074         declare.
7075         * tui/tui-windata.c
7076         (tui_data_window::delete_data_content_windows): Rename from
7077         tui_delete_data_content_windows.
7078         (tui_data_window::display_all_data)
7079         (tui_data_window::do_scroll_vertical): Update.
7080         * tui/tui-data.h (struct tui_data_window)
7081         <delete_data_content_windows>: New method.
7082
7083 2019-07-17  Tom Tromey  <tom@tromey.com>
7084
7085         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
7086         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
7087
7088 2019-07-17  Tom Tromey  <tom@tromey.com>
7089
7090         * tui/tui-windata.h (tui_display_all_data): Don't declare.
7091         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
7092         from tui_display_all_data.
7093         * tui/tui-win.c
7094         (tui_data_window::do_make_visible_with_new_height): Update.
7095         * tui/tui-regs.c (tui_show_registers): Update.
7096         * tui/tui-layout.c (tui_set_layout): Update.
7097         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
7098         method.
7099
7100 2019-07-17  Tom Tromey  <tom@tromey.com>
7101
7102         * tui/tui-windata.h (tui_display_data_from): Don't declare.
7103         * tui/tui-windata.c (tui_display_data_from): Remove.
7104         (tui_data_window::refresh_all): Update.
7105
7106 2019-07-17  Tom Tromey  <tom@tromey.com>
7107
7108         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
7109         * tui/tui-windata.c (tui_display_data_from_line): Remove.
7110         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
7111         tui_display_registers_from_line.
7112         * tui/tui-regs.h (tui_display_registers_from_line): Update.
7113         * tui/tui-regs.c (tui_display_registers_from_line): Remove
7114         "force_display" parameter.
7115
7116 2019-07-17  Tom Tromey  <tom@tromey.com>
7117
7118         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
7119         declare.
7120         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
7121         Rename from tui_first_reg_element_no_inline.
7122         (tui_display_reg_element_at_line)
7123         (tui_display_registers_from_line): Update.
7124         * tui/tui-data.h (struct tui_data_window)
7125         <first_reg_element_no_inline>: New method.
7126
7127 2019-07-17  Tom Tromey  <tom@tromey.com>
7128
7129         * tui/tui-windata.c (tui_display_data_from)
7130         (tui_data_window::do_scroll_vertical): Update.
7131         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
7132         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
7133         Rename from tui_line_from_reg_element_no.
7134         (tui_display_registers_from_line): Update.
7135         * tui/tui-data.h (struct tui_data_window)
7136         <line_from_reg_element_no>: New method.
7137
7138 2019-07-17  Tom Tromey  <tom@tromey.com>
7139
7140         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
7141         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
7142         tui_last_regs_line_no.
7143         (tui_display_reg_element_at_line)
7144         (tui_display_registers_from_line): Update.
7145         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
7146         method.
7147
7148 2019-07-17  Tom Tromey  <tom@tromey.com>
7149
7150         PR tui/24722:
7151         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
7152         (tui_update_breakpoint_info): Add "being_deleted" parameter.
7153         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
7154         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
7155         (tui_update_breakpoint_info): Likewise.
7156         * tui/tui-hooks.c (tui_event_create_breakpoint)
7157         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
7158         Update.
7159
7160 2019-07-17  Tom Tromey  <tom@tromey.com>
7161
7162         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
7163
7164 2019-07-17  Tom Tromey  <tom@tromey.com>
7165
7166         * tui/tui-winsource.c (tui_update_source_window_as_is)
7167         (tui_update_source_windows_with_addr): Update.
7168         * tui/tui-source.h (tui_set_source_content)
7169         (tui_show_symtab_source): Add "win_info" parameter.
7170         * tui/tui-source.c (tui_set_source_content): Add "win_info"
7171         parameter.
7172         (tui_show_symtab_source): Likewise.
7173
7174 2019-07-17  Tom Tromey  <tom@tromey.com>
7175
7176         * tui/tui-wingeneral.c
7177         (tui_check_and_display_highlight_if_needed): Check can_highlight.
7178
7179 2019-07-17  Tom Tromey  <tom@tromey.com>
7180
7181         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
7182         (struct tui_cmd_window) <can_scroll>: New method.
7183         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
7184         method.
7185
7186 2019-07-17  Tom Tromey  <tromey@adacore.com>
7187
7188         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
7189         do_field_signed>: Rename.  Change type of "value".
7190         * ui-out.c (ui_out::field_signed): Rename from field_int.
7191         Change type of "value".
7192         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
7193         type of "value".
7194         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
7195         do_field_int.  Change type of "value".
7196         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
7197         do_field_int.  Change type of "value".
7198         * tracepoint.c (trace_status_mi, tfind_1)
7199         (print_one_static_tracepoint_marker): Update.
7200         * thread.c (print_thread_info_1, print_selected_thread_frame):
7201         Update.
7202         * stack.c (print_frame, print_frame_info): Update.
7203         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
7204         Update.
7205         * source.c (print_source_lines_base): Update.
7206         * skip.c (info_skip_command): Update.
7207         * record-btrace.c (btrace_ui_out_decode_error)
7208         (btrace_call_history_src_line): Update.
7209         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
7210         Update.
7211         * progspace.c (print_program_space): Update.
7212         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
7213         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
7214         do_field_int.  Change type of "value".
7215         * mi/mi-out.c (mi_ui_out::do_table_begin)
7216         (mi_ui_out::do_table_header): Update.
7217         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
7218         type of "value".
7219         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
7220         (mi_cmd_data_list_changed_registers, output_register)
7221         (mi_cmd_data_read_memory, mi_load_progress)
7222         (mi_cmd_trace_frame_collected): Update.
7223         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
7224         Update.
7225         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
7226         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
7227         (mi_cmd_var_list_children, varobj_update_one): Update.
7228         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
7229         (mi_cmd_stack_list_args, list_arg_or_local): Update.
7230         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
7231         * inferior.c (print_inferior): Update.
7232         * gdb_bfd.c (print_one_bfd): Update.
7233         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
7234         Update.
7235         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
7236         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
7237         do_field_int.  Change type of "value".
7238         * cli-out.c (cli_ui_out::do_field_signed): Rename from
7239         do_field_int.  Change type of "value".
7240         * breakpoint.c (watchpoint_check, print_breakpoint_location)
7241         (print_one_breakpoint_location, print_it_catch_fork)
7242         (print_one_catch_fork, print_it_catch_vfork)
7243         (print_one_catch_vfork, print_it_catch_solib)
7244         (print_it_catch_exec, print_it_ranged_breakpoint)
7245         (print_mention_watchpoint, print_mention_masked_watchpoint)
7246         (bkpt_print_it, update_static_tracepoint): Update.
7247         * break-catch-throw.c (print_it_exception_catchpoint): Update.
7248         * break-catch-syscall.c (print_it_catch_syscall): Update.
7249         * ada-tasks.c (print_ada_task_info): Update.
7250         * ada-lang.c (print_it_exception, print_mention_exception):
7251         Update.
7252
7253 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
7254
7255         PR breakpoints/24541
7256         * gdbarch.c: Regenerate.
7257         * gdbarch.h: Regenerate.
7258         * gdbarch.sh: Adjust return type and parameter types for
7259         'stap_adjust_register'.
7260         (i386_stap_adjust_register): Adjust signature and return new
7261         register name.
7262         * stap-probe.c (stap_parse_register_operand): Adjust use of
7263         'gdbarch_stap_adjust_register'.
7264
7265 2019-07-17  Tom Tromey  <tromey@adacore.com>
7266
7267         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
7268         declare VEC.
7269         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
7270         std::vector.
7271         (struct s390_process_info): Add initializers.
7272         (s390_add_process): Use new.
7273         (s390_linux_nat_target::low_forget_process): Use delete.
7274         (s390_linux_nat_target::low_new_fork)
7275         (s390_linux_nat_target::stopped_by_watchpoint)
7276         (s390_linux_nat_target::low_prepare_to_resume)
7277         (s390_linux_nat_target::insert_watchpoint)
7278         (s390_linux_nat_target::insert_hw_breakpoint)
7279         (s390_linux_nat_target::remove_watchpoint)
7280         (s390_linux_nat_target::remove_hw_breakpoint): Update.
7281
7282 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
7283
7284         * aarch64-fbsd-nat.c: Include regcache.h.
7285         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
7286         argument.
7287         (aarch64_fbsd_nat_target::fetch_registers)
7288         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
7289         variable.
7290         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
7291
7292 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
7293
7294         * fbsd-nat.c: Include gdbarch.h.
7295
7296 2019-07-15  Tom Tromey  <tromey@adacore.com>
7297
7298         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
7299
7300 2019-07-15  Tom Tromey  <tromey@adacore.com>
7301
7302         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
7303         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
7304         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
7305         * cli-out.c (cli_ui_out::do_field_int): New method.
7306         * ui-out.c (ui_out::field_unsigned): New method.
7307         * symfile.c (generic_load): Use field_unsigned.
7308         (print_transfer_performance): Likewise.
7309         * record-btrace.c (ui_out_field_uint): Remove.
7310         (btrace_call_history_insn_range, btrace_call_history): Use
7311         field_unsigned.
7312         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
7313         field_unsigned.
7314         * ui-out.h (class ui_out) <field_unsigned>: New method.
7315         <do_field_unsigned>: Likewise.
7316
7317 2019-07-15  Tom Tromey  <tromey@adacore.com>
7318
7319         * mi/mi-main.c (list_available_thread_groups): Use field_string.
7320         * mi/mi-interp.c (mi_memory_changed): Use field_string.
7321         * target.c (flash_erase_command): Use field_string.
7322         * infrun.c (print_signal_received_reason): Use field_string.
7323         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
7324         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
7325         field_string.
7326         * ada-tasks.c (print_ada_task_info): Use field_string.
7327
7328 2019-07-15  Tom Tromey  <tromey@adacore.com>
7329
7330         * target.c (flash_erase_command): Use field_core_addr.
7331         * symfile.c (generic_load): Use field_core_addr.
7332         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
7333         Use field_core_addr.
7334         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
7335         field_core_addr.
7336
7337 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
7338
7339         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
7340         value if its desired type is smaller than a CORE_ADDR and signed.
7341
7342 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
7343
7344         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
7345         of changes to field names, and use new is_reference field to
7346         decide if a property is a reference or not.
7347         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
7348         field.
7349         (struct dwarf2_property_baton): Update header comment, rename
7350         'referenced_type' to 'property_type' and update comments.
7351         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
7352         default property type, store in property baton, update to take
7353         accound of renamed field.
7354         (read_func_scope): Update call to attr_to_dynamic_prop.
7355         (read_array_type): Likewise.
7356         (dwarf2_per_cu_addr_sized_int_type): New function.
7357         (read_subrange_index_type): Move type finding code to
7358         dwarf2_per_cu_addr_sized_int_type.
7359         (read_subrange_type): Update calls to attr_to_dynamic_prop.
7360         (dwarf2_per_cu_addr_type): New function.
7361         (set_die_type): Update calls to attr_to_dynamic_prop.
7362
7363 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
7364
7365         * dwarf2read.c (read_subrange_index_type): New function.
7366         (read_subrange_type): Move code into new function and call it.
7367         * gdbtypes.c (create_range_type): Add some asserts.
7368
7369 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
7370
7371         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
7372         update return statements.
7373         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
7374         declaration, and update comment to match.
7375         * gdbtypes.c (resolve_dynamic_array): Update call to
7376         dwarf2_evaluate_property to match new return type.
7377
7378 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
7379
7380         * valarith.c (value_subscripted_rvalue): Change lowerbound
7381         parameter type from int to LONGEST.
7382         * value.h (value_subscripted_rvalue): Likewise in declaration.
7383
7384 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
7385
7386         * cli/cli-utils.c (info_print_command_completer): New function.
7387         * cli/cli-utils.h: Add 'completer.h' include, and forward
7388         declaration for 'struct cmd_list_element'.
7389         (info_print_command_completer): Declare.
7390         * stack.c (_initialize_stack): Add completer for 'info locals' and
7391         'info args'.
7392         * symtab.c (_initialize_symtab): Add completer for 'info
7393         variables' and 'info functions'.
7394         * NEWS: Mention completion for additional info commands.
7395
7396 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
7397
7398         * cli/cli-utils.c (extract_info_print_args): Delete.
7399         (extract_arg_maybe_quoted): Delete.
7400         (info_print_options_defs): New variable.
7401         (make_info_print_options_def_group): New function.
7402         (extract_info_print_options): Define new function.
7403         * cli/cli-utils.h (extract_info_print_args): Delete.
7404         (struct info_print_options): New structure.
7405         (extract_info_print_options): Declare new function.
7406         * stack.c (info_locals_command): Update to use new
7407         extract_info_print_options, also add a header comment.
7408         (info_args_command): Likewise.
7409         * symtab.c (info_variables_command): Likewise.
7410         (info_functions_command): Likewise.
7411
7412 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
7413
7414         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
7415         to extract string arguments.
7416         * common/common-utils.c (extract_string_maybe_quoted): New function.
7417         * common/common-utils.h (extract_string_maybe_quoted): Declare.
7418
7419 2019-07-11  Tom Tromey  <tromey@adacore.com>
7420
7421         * main.c (get_init_files): Use GDBINIT, not gdbinit.
7422         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
7423         * top.h (gdbinit): Don't declare.
7424         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
7425         into...
7426         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
7427         * top.c (gdb_init): Don't call init_cli_cmds.
7428         (gdbinit): Remove.
7429         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
7430
7431 2019-07-11  Tom Tromey  <tromey@adacore.com>
7432
7433         * python/py-inferior.c (add_thread_object): Don't use thread_obj
7434         after it has been moved.
7435
7436 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
7437
7438         * valops.c (value_must_coerce_to_target): Change return type to
7439         bool.
7440         * value.h (value_must_coerce_to_target): Likewise.
7441
7442 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
7443
7444         * breakpoint.c (is_hardware_watchpoint): Remove
7445         forward-declaration.
7446         (is_masked_watchpoint): Change return type to bool.
7447         (is_tracepoint): Likewise.
7448         (is_breakpoint): Likewise.
7449         (is_hardware_watchpoint): Likewise.
7450         (is_watchpoint): Likewise.
7451         (is_no_memory_software_watchpoint): Likewise.
7452         (is_catchpoint): Likewise.
7453         (breakpoint_1): Make FILTER parameter's return type bool.
7454         is_masked_watchpoint): Change return type to bool.
7455         (save_breakpoints): Make FILTER parameter's return type bool.
7456         * breakpoint.h (is_breakpoint): Change return type to bool.
7457         (is_watchpoint): Likewise.
7458         (is_catchpoint): Likewise.
7459         (is_tracepoint): Likewise.
7460
7461 2019-07-10  Tom Tromey  <tom@tromey.com>
7462
7463         * defs.h: Don't include gdbarch.h.
7464         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
7465         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
7466         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
7467         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
7468         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
7469         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
7470         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
7471         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
7472         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
7473         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
7474         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
7475         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
7476         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
7477         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
7478         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
7479         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
7480         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
7481         record-btrace.c, record.h, regcache-dump.c, regcache.h,
7482         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
7483         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
7484         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
7485         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
7486         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
7487         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
7488         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
7489         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
7490         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
7491
7492 2019-07-10  Tom Tromey  <tromey@adacore.com>
7493
7494         * ada-lang.h (is_ada_exception_catchpoint): Declare.
7495         * breakpoint.c (init_ada_exception_breakpoint): Register as
7496         bp_catchpoint.
7497         (print_one_breakpoint_location, print_one_breakpoint): Use
7498         is_ada_exception_catchpoint.
7499         * ada-lang.c (class ada_catchpoint_location): Pass
7500         bp_loc_software_breakpoint to bp_location constructor.
7501         (is_ada_exception_catchpoint): New function.
7502
7503 2019-07-10  Tom Tromey  <tromey@adacore.com>
7504
7505         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
7506         VEC.
7507         (struct arm_exidx_entry): New method operator<.
7508         (struct arm_exidx_data) <section_maps>: Change type.
7509         (arm_exidx_data_free): Remove.
7510         (arm_exidx_data_key): Change type.  Move lower.
7511         (arm_exidx_new_objfile): Update.
7512         (arm_compare_exidx_entries): Remove.
7513         (arm_find_exidx_entry, _initialize_arm_tdep)
7514
7515 2019-07-10  Tom Tromey  <tromey@adacore.com>
7516
7517         * solib-spu.c (ocl_program_data_key): Change type.
7518         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
7519         Update.
7520
7521 2019-07-10  Tom Tromey  <tromey@adacore.com>
7522
7523         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
7524         (struct solib_aix_inferior_data) <library_list>: Change type.
7525         (solib_aix_inferior_data_handle): Change type.
7526         (get_solib_aix_inferior_data): Update.
7527         (solib_aix_free_library_list): Remove.
7528         (library_list_start_library): Update.
7529         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
7530         return type.
7531         (solib_aix_get_library_list)
7532         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
7533         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
7534
7535 2019-07-10  Tom Tromey  <tromey@adacore.com>
7536
7537         * solib-dsbt.c (struct dsbt_info): Add initializers.
7538         (solib_dsbt_pspace_data): Change type.
7539         (dsbt_pspace_data_cleanup): Remove.
7540         (get_dsbt_info, _initialize_dsbt_solib): Update.
7541
7542 2019-07-10  Tom Tromey  <tromey@adacore.com>
7543
7544         * spu-tdep.c (spu_overlay_data): Change type.
7545         (spu_get_overlay_table, spu_overlay_new_objfile)
7546         (_initialize_spu_tdep): Update.
7547
7548 2019-07-10  Tom Tromey  <tromey@adacore.com>
7549
7550         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
7551         destructor.
7552         (dbx_objfile_data_key): Change type and declare later.
7553         (DBX_SYMFILE_INFO): Rewrite.
7554         * dbxread.c (dbx_objfile_data_key): Change type.
7555         (dbx_symfile_init): Update.
7556         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
7557         (coffstab_build_psymtabs, elfstab_build_psymtabs)
7558         (stabsect_build_psymtabs, _initialize_dbxread): Update.
7559
7560 2019-07-10  Tom Tromey  <tromey@adacore.com>
7561
7562         * jit.c (jit_program_space_key): Change type.  Move lower.
7563         (get_jit_program_space_data): Update.
7564         (jit_program_space_data_cleanup): Remove.
7565         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
7566         Update.
7567         (struct jit_program_space_data): Add initializers.
7568
7569 2019-07-10  Tom Tromey  <tromey@adacore.com>
7570
7571         * solib-darwin.c (struct darwin_info): Add initializers.
7572         (solib_darwin_pspace_data): Change type.
7573         (darwin_pspace_data_cleanup): Remove.
7574         (get_darwin_info, _initialize_darwin_solib): Update.
7575
7576 2019-07-10  Tom Tromey  <tromey@adacore.com>
7577
7578         * remote-sim.c (struct sim_inferior_data): Add initializers,
7579         constructor, and destructor.
7580         (sim_inferior_data_key): Change type.  Move lower.
7581         (check_for_duplicate_sim_descriptor): Update.
7582         (get_sim_inferior_data): Use new.  Update.
7583         (~sim_inferior_data_cleanup): Rename from
7584         sim_inferior_data_cleanup.  Simplify.
7585         (gdbsim_close_inferior, simulator_command)
7586         (sim_command_completer, _initialize_remote_sim): Update.
7587         (next_pid, INITIAL_PID): Move earlier.
7588
7589 2019-07-10  Tom Tromey  <tromey@adacore.com>
7590
7591         * python/python-internal.h (create_thread_object): Return
7592         gdbpy_ref.
7593         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
7594         * python/py-inferior.c (struct threadlist_entry): Add
7595         constructor.
7596         <thread_obj>: Now a gdbpy_ref.
7597         (thread_to_thread_object): Update.
7598         (add_thread_object): Use new.
7599         (delete_thread_object): Use delete.
7600         (infpy_threads): Update.
7601         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
7602         GIL.
7603
7604 2019-07-10  Tom Tromey  <tromey@adacore.com>
7605
7606         * valops.c (value_cast): Specialize error message for Ada.
7607
7608 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
7609
7610         * breakpoint.c (breakpoint_1): Update doc and parameter names.
7611
7612 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
7613
7614         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
7615         bpstat_should_step): Return bool, adjust comments.
7616         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
7617         bpstat_should_step): Likewise.
7618
7619 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
7620
7621         * features/Makefile: Use feature target descriptions for Arm.
7622         * features/arm/arm-core.c: Generate new file.
7623         * features/arm/arm-fpa.c: Likewise.
7624         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
7625         * features/arm/arm-m-profile.c: Likewise.
7626         * features/arm/arm-vfpv2.c: Likewise.
7627         * features/arm/arm-vfpv3.c: Likewise.
7628         * features/arm/xscale-iwmmxt.c: Likewise.
7629         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
7630
7631 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
7632
7633         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
7634         ptrace earlier.
7635
7636 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
7637
7638         * features/aarch64-pauth.c: Regenerate.
7639
7640 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
7641
7642         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
7643         bool.
7644         (bpstat_what): Use false instead of 0.
7645
7646 2019-07-09  Pedro Alves  <palves@redhat.com>
7647
7648         * break-catch-throw.c (is_exception_catchpoint): New.
7649         * breakpoint.c (print_one_breakpoint_location): New parameter
7650         'raw_loc'.  Handle it.  Use
7651         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
7652         looking at the breakpoint's type.
7653         (print_one_breakpoint): If handling "maint info breakpoints", also
7654         print locations of exception catchpoints.
7655         * breakpoint.h (is_exception_catchpoint): Declare.
7656
7657 2019-07-09  Pedro Alves  <palves@redhat.com>
7658
7659         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
7660         "addr" field.
7661         (allocate_location_exception_catchpoint): New.
7662         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
7663         (initialize_throw_catchpoint_ops): Install
7664         allocate_location_exception_catchpoint as allocate_location
7665         method.
7666         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
7667         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
7668         bp_loc_other.
7669         (breakpoint_address_is_meaningful): Delete.
7670         (bl_address_is_meaningful): New.
7671         (breakpoint_locations_match): Adjust comment.
7672         (bp_location_from_bp_type): New, factored out of...
7673         (bp_location::bp_location(breakpoint *)): ... this.
7674         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
7675         factored out of...
7676         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
7677         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
7678         breakpoint_address_is_meaningful.
7679         (bp_locations_compare): Adjust comment.
7680         (update_global_location_list): Use bl_address_is_meaningful
7681         instead of breakpoint_address_is_meaningful.
7682         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
7683         explicit.
7684         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
7685         * python/py-breakpoint.c (bppy_get_location): No longer check
7686         whether location is null.
7687
7688 2019-07-09  Pedro Alves  <palves@redhat.com>
7689
7690         PR c++/15468
7691         * breakpoint.c (print_one_breakpoint_location): Remove
7692         single-location assert.
7693
7694 2019-07-09  Tom Tromey  <tom@tromey.com>
7695
7696         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
7697         * configure: Rebuild.
7698         * configure.ac: Change common to gdbsupport.
7699         * gdbsupport: Rename from common.
7700         * acinclude.m4: Change common to gdbsupport.
7701         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
7702         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
7703         gdbsupport.
7704         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
7705         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
7706         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
7707         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
7708         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
7709         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
7710         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
7711         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
7712         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
7713         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
7714         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
7715         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
7716         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
7717         coff-pe-read.c, command.h, compile/compile-c-support.c,
7718         compile/compile-c.h, compile/compile-cplus-symbols.c,
7719         compile/compile-cplus-types.c, compile/compile-cplus.h,
7720         compile/compile-loc2c.c, compile/compile.c, completer.c,
7721         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
7722         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
7723         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
7724         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
7725         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
7726         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
7727         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
7728         features/aarch64-core.c, features/aarch64-fpu.c,
7729         features/aarch64-pauth.c, features/aarch64-sve.c,
7730         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
7731         features/i386/32bit-core.c, features/i386/32bit-linux.c,
7732         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
7733         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
7734         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
7735         features/i386/64bit-core.c, features/i386/64bit-linux.c,
7736         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
7737         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
7738         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
7739         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
7740         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
7741         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
7742         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
7743         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
7744         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
7745         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
7746         go32-nat.c, guile/guile.c, guile/scm-ports.c,
7747         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
7748         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
7749         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
7750         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
7751         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
7752         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
7753         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
7754         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
7755         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
7756         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
7757         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
7758         minsyms.c, mips-linux-tdep.c, namespace.h,
7759         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
7760         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
7761         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
7762         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
7763         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
7764         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
7765         nat/linux-waitpid.c, nat/mips-linux-watch.c,
7766         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
7767         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
7768         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
7769         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
7770         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
7771         procfs.c, producer.c, progspace.h, psymtab.h,
7772         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
7773         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
7774         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
7775         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
7776         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
7777         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
7778         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
7779         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
7780         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
7781         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
7782         target-memory.c, target.c, target.h, target/waitstatus.c,
7783         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
7784         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
7785         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
7786         unittests/array-view-selftests.c,
7787         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
7788         unittests/common-utils-selftests.c,
7789         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
7790         unittests/format_pieces-selftests.c,
7791         unittests/function-view-selftests.c,
7792         unittests/lookup_name_info-selftests.c,
7793         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
7794         unittests/mkdir-recursive-selftests.c,
7795         unittests/observable-selftests.c,
7796         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
7797         unittests/parse-connection-spec-selftests.c,
7798         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
7799         unittests/scoped_fd-selftests.c,
7800         unittests/scoped_mmap-selftests.c,
7801         unittests/scoped_restore-selftests.c,
7802         unittests/string_view-selftests.c, unittests/style-selftests.c,
7803         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
7804         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
7805         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
7806         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
7807         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
7808         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
7809
7810 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
7811
7812         * linespec.c (decode_digits_list_mode): Set explicit_line to a
7813         bool value.
7814         (decode_digits_ordinary): Set explicit_line field in sal.
7815         * symtab.c (skip_prologue_sal): Don't skip prologue for a
7816         symtab_and_line that was set on an explicit line number in
7817         assembler code.  Do always update the recorded symtab and line if
7818         we do skip the prologue.
7819
7820 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
7821
7822         * breakpoint.c (set_breakpoint_location_function): Remove
7823         explicit_loc parameter.
7824         (momentary_breakpoint_from_master): Update call to
7825         set_breakpoint_location_function.
7826         (add_location_to_breakpoint): Likewise.
7827
7828 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
7829
7830         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
7831         required features based on default bfd type when no specific bfd
7832         is present.
7833
7834 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7835
7836         * NEWS: Mention that GDB printf and eval commands can now print
7837         C-style and Ada-style convenience var strings without
7838         calling the inferior.
7839         * printcmd.c (printf_c_string): Locally print GDB internal var
7840         instead of transiting via the inferior.
7841         (printf_wide_c_string): Likewise.
7842
7843 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
7844
7845         PR breakpoints/25011
7846         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
7847
7848 2019-07-04  Tom Tromey  <tom@tromey.com>
7849
7850         PR tui/24724:
7851         * tui/tui-winsource.c (tui_clear_source_content): Update.
7852         (tui_source_window_base::set_is_exec_point_at): Fix comment.
7853         (tui_update_breakpoint_info): Update.
7854         (tui_set_exec_info_content): Update.
7855         * tui/tui-source.c (tui_set_source_content_nil): Update.
7856         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
7857         has_break.
7858         * tui/tui-data.h (enum tui_bp_flag): New.
7859         (tui_bp_flags): New enum flags type.
7860         (struct tui_source_element) <break_mode>: Change type.  Rename
7861         from has_break.
7862         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
7863         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
7864         constants.
7865         * tui/tui-winsource.h: Fix comment.
7866
7867 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
7868
7869         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
7870         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
7871         (store_fpregs_to_thread)
7872         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
7873         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
7874         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
7875         (IWMMXT_REGS_SIZE): Add define.
7876         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
7877         (fetch_vfp_regs, store_vfp_regs)
7878         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
7879         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
7880
7881 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
7882
7883         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
7884         defines.
7885         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
7886         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
7887         (ARM_INT_REGISTER_SIZE): ...to this.
7888         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
7889         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
7890         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
7891         (arm_linux_collect_gregset, supply_nwfpe_register)
7892         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
7893         defines.
7894         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
7895         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
7896         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
7897         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
7898         (arm_return_in_memory, arm_store_return_value)
7899         (arm_get_longjmp_target, arm_register_g_packet_guesses)
7900         (arm_record_ld_st_multiple): Likewise.
7901         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
7902         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
7903
7904 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
7905
7906         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
7907         AARCH64_DISPLACED_MODIFIED_INSNS.
7908         * aarch64-tdep.c (struct aarch64_displaced_step_data)
7909         (aarch64_displaced_step_copy_insn): Likewise.
7910         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
7911         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
7912         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
7913         ARM_DISPLACED_MODIFIED_INSNS.
7914         * arm-tdep.c (arm_gdbarch_init): Likewise.
7915         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
7916         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
7917         (struct arm_displaced_step_closure): Use
7918         ARM_DISPLACED_MODIFIED_INSNS.
7919
7920 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
7921
7922         * features/Makefile: Remove unused xml files.
7923         * features/aarch64.xml: Remove.
7924         * features/i386/amd64-avx-avx512-linux.xml: Remove.
7925         * features/i386/amd64-avx-avx512.xml: Remove.
7926         * features/i386/amd64-avx-linux.xml: Remove.
7927         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
7928         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
7929         * features/i386/amd64-avx-mpx-linux.xml: Remove.
7930         * features/i386/amd64-avx-mpx.xml: Remove.
7931         * features/i386/amd64-avx.xml: Remove.
7932         * features/i386/amd64-linux.xml: Remove.
7933         * features/i386/amd64-mpx-linux.xml: Remove.
7934         * features/i386/amd64-mpx.xml: Remove.
7935         * features/i386/amd64.xml: Remove.
7936         * features/i386/i386-avx-avx512-linux.xml: Remove.
7937         * features/i386/i386-avx-avx512.xml: Remove.
7938         * features/i386/i386-avx-linux.xml: Remove.
7939         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
7940         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
7941         * features/i386/i386-avx-mpx-linux.xml: Remove.
7942         * features/i386/i386-avx-mpx.xml: Remove.
7943         * features/i386/i386-avx.xml: Remove.
7944         * features/i386/i386-linux.xml: Remove.
7945         * features/i386/i386-mmx-linux.xml: Remove.
7946         * features/i386/i386-mmx.xml: Remove.
7947         * features/i386/i386-mpx-linux.xml: Remove.
7948         * features/i386/i386-mpx.xml: Remove.
7949         * features/i386/i386.xml: Remove.
7950         * features/i386/x32-avx-avx512-linux.xml: Remove.
7951         * features/i386/x32-avx-linux.xml: Remove.
7952         * features/i386/x32-linux.xml: Remove.
7953
7954 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
7955
7956         * regformats/aarch64.dat: Remove.
7957         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
7958         * regformats/i386/amd64-avx-linux.dat: Remove.
7959         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
7960         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
7961         * regformats/i386/amd64-linux.dat: Remove.
7962         * regformats/i386/amd64-mpx-linux.dat: Remove.
7963         * regformats/i386/amd64.dat: Remove.
7964         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
7965         * regformats/i386/i386-avx-linux.dat: Remove.
7966         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
7967         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
7968         * regformats/i386/i386-linux.dat: Remove.
7969         * regformats/i386/i386-mmx-linux.dat: Remove.
7970         * regformats/i386/i386-mpx-linux.dat: Remove.
7971         * regformats/i386/i386.dat: Remove.
7972         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
7973         * regformats/i386/x32-avx-linux.dat: Remove.
7974         * regformats/i386/x32-linux.dat: Remove.
7975
7976 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
7977
7978         * aarch64-tdep.c: Remove xml self tests.
7979         * amd64-linux-tdep.c: Likewise.
7980         * amd64-tdep.c: Likewise.
7981         * i386-linux-tdep.c: Likewise.
7982         * i386-tdep.c: Likewise.
7983
7984 2019-07-03  Pedro Alves  <palves@redhat.com>
7985
7986         PR cli/24732
7987         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
7988         (pipe_cmd_option_defs): New.
7989         (make_pipe_cmd_options_def_group): New.
7990         (pipe_command): Use gdb::option::process_options.
7991         (pipe_command_completer): New function.
7992         (_initialize_cli_cmds): Install completer for "pipe" command.
7993
7994 2019-07-03  Pedro Alves  <palves@redhat.com>
7995
7996         * cli/cli-option.c (union option_value) <string>: New field.
7997         (struct option_def_and_value): Add ctor, move ctor, dtor and
7998         use DISABLE_COPY_AND_ASSIGN.
7999         (option_def_and_value::clear_value): New.
8000         (parse_option, save_option_value_in_ctx, get_val_type_str)
8001         (add_setshow_cmds_for_options): Handle var_string.
8002         * cli-option.h (union option_def::var_address) <string>: New
8003         field.
8004         (struct string_option_def): New.
8005         * maint-test-options.c (struct test_options_opts): Add default
8006         ctor and use DISABLE_COPY_AND_ASSIGN.
8007         <string_opt>: New field.
8008         (test_options_opts::~test_options_opts): New.
8009         (test_options_opts::dump): Also dump "-string".
8010         (test_options_option_defs): Install "string.
8011
8012 2019-07-03  Pedro Alves  <palves@redhat.com>
8013
8014         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
8015         option_value with a null enumeration.
8016         (complete_options): Save the option values in the context.
8017         (save_option_value_in_ctx): New, factored out from ...
8018         (process_options): ... here.
8019         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
8020         of the function.
8021         * maint-test-options.c (test_options_opts::dump): New, factored
8022         out from ...
8023         (maintenance_test_options_command_mode): ... here.
8024         (maintenance_test_options_command_completion_result): Delete.
8025         (maintenance_test_options_command_completion_text): Update
8026         comment.
8027         (maintenance_show_test_options_completion_result): Change
8028         prototype.  Just print
8029         maintenance_test_options_command_completion_text.
8030         (save_completion_result): New.
8031         (maintenance_test_options_completer_mode): Pass options context to
8032         complete_options, and then save a dump.
8033         (_initialize_maint_test_options): Use add_cmd to install "maint
8034         show test-options-completion-result".
8035
8036 2019-07-03  Pedro Alves  <palves@redhat.com>
8037
8038         * NEWS (New commands): Mention "with" and "maint with".
8039         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
8040         (with_command, with_command_completer): New.
8041         (pipe_command): Adjust to new repeat_previous
8042         interface.
8043         (_initialize_cli_cmds): Install the "with" command and its "w"
8044         alias.
8045         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
8046         declarations.
8047         * cli/cli-setshow.c (parse_cli_var_uinteger)
8048         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
8049         argument strings for all var_types.
8050         (get_setshow_command_value_string): New, factored out from ...
8051         (do_show_command): ... this.
8052         * cli/cli-setshow.h: Include <string>.
8053         (get_setshow_command_value_string): Declare.
8054         * command.h (repeat_previous): Now returns const char *.  Adjust
8055         comment.
8056         * maint.c: Include "cli/cli-cmds.h".
8057         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
8058         (_initialize_maint_cmds): Register the "maintenance with" command.
8059         * top.c (repeat_previous): Move bits from pipe_command here:
8060         Return the saved command line, if any; error out if there's no
8061         command to relaunch.
8062
8063 2019-07-03  Pedro Alves  <palves@redhat.com>
8064
8065         * NEWS (New commands): Mention "maint set/show test-settings"
8066         instead of "maint test-settings".
8067         * maint-test-settings.c (maintenance_test_settings_list): Delete.
8068         (maintenance_test_settings_set_list): Rename to ...
8069         (maintenance_set_test_settings_list): ... this.
8070         (maintenance_test_settings_show_list): Rename to  ...
8071         (maintenance_show_test_settings_list): ... this.
8072         (maintenance_test_settings_cmd): Delete.
8073         (maintenance_test_settings_set_cmd): ...
8074         (maintenance_set_test_settings_cmd): ... this.
8075         (maintenance_test_settings_show_cmd): ...
8076         (maintenance_show_test_settings_cmd): ... this.
8077         (maintenance_test_settings_show_value_cmd):
8078         (maintenance_show_test_settings_value_cmd): ... this.
8079         (_initialize_maint_test_settings): No longer install the "maint
8080         test-settings" prefix command.  Rename "maint test-settings set"
8081         to "maint set test-settings", and "maint test-settings show" to
8082         "maint show test-settings".  Adjust all subcommands.
8083
8084 2019-07-03  Pedro Alves  <palves@redhat.com>
8085
8086         * maint-test-settings.c: Fix file's intro comment.  Replace all
8087         references to "test-options" with references to "test-settings",
8088         in comments.
8089
8090 2019-07-03  Pedro Alves  <palves@redhat.com>
8091
8092         * maint-test-settings.c (maintenance_test_settings_xxx)
8093         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
8094         New.
8095         (maintenance_test_settings_enums): Use them.
8096         (maintenance_test_settings_enum): Default to
8097         maintenance_test_settings_xxx.
8098         (_initialize_maint_test_settings): Initialize
8099         MAINTENANCE_TEST_SETTINGS_FILENAME.
8100
8101 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
8102
8103         * breakpoint.h (remove_breakpoints_inf): Change return type to
8104         void, move function documentation here.
8105         * breakpoint.c (remove_breakpoints_inf): Change return type to
8106         void, move function documentation to header.
8107
8108 2019-07-02  Pedro Alves  <palves@redhat.com>
8109
8110         * NEWS (Completion improvements): Mention "info threads".
8111         * thread.c (struct info_threads_opts, info_threads_option_defs)
8112         (make_info_threads_options_def_group): New.
8113         (info_threads_command): Use gdb::option::process_options.
8114         (info_threads_command_completer): New.
8115         (_initialize_thread): Use gdb::option::build_help to build the
8116         help text for "info threads".
8117
8118 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
8119
8120         * defs.h (generic_load): Move from here...
8121         * symfile.h (generic_load): ... to here.  Rename name parameter
8122         to args.
8123         * symfile.c (generic_load): Add comment.
8124
8125 2019-07-01  Tom Tromey  <tromey@adacore.com>
8126
8127         * dwarf2read.c
8128         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
8129         declaration of without_params.  Fix formatting.
8130
8131 2019-07-01  Tom Tromey  <tromey@adacore.com>
8132
8133         * ada-exp.y (find_primitive_type): Update.
8134         * ada-lang.h (ada_lookup_symbol): Update.
8135         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
8136         parameter.
8137         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
8138
8139 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
8140
8141         PR breakpoints/24541
8142         * gdbarch.c: Regenerate.
8143         * gdbarch.h: Regenerate.
8144         * gdbarch.sh: Add 'stap_adjust_register'.
8145         * i386-tdep.c: Include '<unordered_set>'.
8146         (i386_stap_adjust_register): New function.
8147         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
8148         * stap-probe.c (stap_parse_register_operand): Call
8149         'gdbarch_stap_adjust_register'.
8150
8151 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
8152
8153         PR python/24742
8154         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
8155         * python/python.c (do_start_initialization): Use 'xmalloc'
8156         instead of 'PyMem_Malloc'.
8157
8158 2019-06-28  Tom Tromey  <tromey@adacore.com>
8159
8160         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
8161         for Ada.
8162
8163 2019-06-27  Tom Tromey  <tromey@adacore.com>
8164
8165         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
8166         objfile_key.
8167         (arm_find_mapping_symbol, arm_record_special_symbol)
8168         (_initialize_arm_tdep): Update.
8169         (arm_objfile_data_free): Remove.
8170
8171 2019-06-27  Tom Tromey  <tromey@adacore.com>
8172
8173         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
8174         to cp_print_static_field.
8175
8176 2019-06-26  Tom Tromey  <tromey@adacore.com>
8177
8178         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
8179         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
8180         declare.
8181
8182 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
8183
8184         * features/aarch64-core.c (create_feature_aarch64_core):
8185         Regenerate.
8186         * features/aarch64-core.xml: Add cpsr flags.
8187
8188 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
8189
8190         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
8191         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
8192
8193 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
8194
8195         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
8196         field.
8197         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
8198         use.
8199         (arm_record_special_symbol): Don't insert new symbol in sorted
8200         position, push it at the end.
8201
8202 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
8203
8204         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
8205         (arm_mapping_symbol_s): Remove.
8206         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
8207         (arm_mapping_symbol_vec): New typedef.
8208         (struct arm_per_objfile): Add constructor.
8209         <section_maps>: Change type to
8210         std::unique_ptr<arm_mapping_symbol_vec[]>.
8211         (arm_compare_mapping_symbols): Remove.
8212         (arm_find_mapping_symbol): Adjust to section_maps type change.
8213         (arm_objfile_data_free): Call delete on arm_per_objfile.
8214         (arm_record_special_symbol): Adjust to section_maps type change.
8215         Allocate arm_per_objfile with new.
8216
8217 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8218
8219         * cli/cli-cmds.c (alias_command): Compare the alias prefix
8220         with the command prefix.
8221
8222 2019-06-25  Tom Tromey  <tom@tromey.com>
8223
8224         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
8225         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
8226
8227 2019-06-25  Tom Tromey  <tom@tromey.com>
8228
8229         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
8230         type.
8231         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
8232         protected.
8233
8234 2019-06-25  Tom Tromey  <tom@tromey.com>
8235
8236         * tui/tui-winsource.c
8237         (tui_source_window_base::set_is_exec_point_at): Add check against
8238         LOA_ADDRESS.
8239
8240 2019-06-25  Tom Tromey  <tom@tromey.com>
8241
8242         * tui/tui-source.c (tui_set_source_content): Don't check before
8243         xfree.
8244         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
8245
8246 2019-06-25  Tom Tromey  <tom@tromey.com>
8247
8248         * tui/tui-winsource.h (tui_update_source_window_as_is)
8249         (tui_alloc_source_buffer, tui_line_is_displayed)
8250         (tui_addr_is_displayed): Change type of win_info.
8251         * tui/tui-winsource.c (tui_update_source_window_as_is)
8252         (tui_clear_source_content, tui_show_source_line)
8253         (tui_show_source_content, tui_source_window_base::refill)
8254         (tui_source_window_base::set_is_exec_point_at)
8255         (tui_source_window_base::set_is_exec_point_at)
8256         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
8257         (tui_alloc_source_buffer, tui_line_is_displayed)
8258         (tui_addr_is_displayed): Change type of win_info.  Update.
8259         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
8260         (tui_source_window_base::do_make_visible_with_new_height):
8261         Update.
8262         * tui/tui-source.c (tui_set_source_content)
8263         (tui_set_source_content_nil)
8264         (tui_source_window::do_scroll_vertical): Update.
8265         * tui/tui-layout.c (show_layout): Update.
8266         * tui/tui-disasm.c (tui_set_disassem_content)
8267         (tui_disasm_window::do_scroll_vertical): Update.
8268         * tui/tui-data.h (tui_win_content): Remove.
8269         (struct tui_gen_win_info) <content, content_size>: Remove.
8270         (struct tui_source_element): Add initializers and destructor.
8271         (union tui_which_element, struct tui_win_element): Remove.
8272         (struct tui_source_window_base) <content>: New field.
8273         (struct tui_data_window): Remove destructor.
8274         (tui_alloc_content, tui_free_win_content)
8275         (tui_free_all_source_wins_content): Don't declare.
8276         * tui/tui-data.c (tui_initialize_static_data): Update.
8277         (init_content_element, tui_alloc_content): Remove.
8278         (~tui_gen_win_info): Update.
8279         (~tui_data_window, tui_free_all_source_wins_content)
8280         (tui_free_win_content, free_content, free_content_elements):
8281         Remove.
8282
8283 2019-06-25  Tom Tromey  <tom@tromey.com>
8284
8285         * tui/tui-winsource.h (tui_clear_source_content)
8286         (tui_erase_source_content, tui_show_source_content): Change type
8287         of win_info.
8288         * tui/tui-winsource.c (tui_clear_source_content)
8289         (tui_erase_source_content, tui_show_source_content): Change type
8290         of win_info.
8291         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
8292         * tui/tui-source.h (tui_set_source_content_nil): Change type of
8293         win_info.
8294         * tui/tui-source.c (tui_set_source_content_nil): Change type of
8295         win_info.
8296         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
8297
8298 2019-06-25  Tom Tromey  <tom@tromey.com>
8299
8300         * tui/tui-winsource.c (tui_clear_source_content)
8301         (tui_source_window_base::set_is_exec_point_at): Update.
8302         * tui/tui-source.c (tui_set_source_content_nil): Update.
8303         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
8304         a bool.
8305         * tui/tui-data.c (init_content_element): Update.
8306
8307 2019-06-25  Tom Tromey  <tom@tromey.com>
8308
8309         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
8310         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
8311         * tui/tui-layout.c (init_and_make_win): Update.
8312         * tui/tui.h (enum tui_win_type): Update.
8313         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
8314         tui_win_is_auxillary.
8315         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
8316         tui_win_is_auxillary.
8317
8318 2019-06-25  Tom Tromey  <tom@tromey.com>
8319
8320         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
8321         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
8322         (tui_delete_data_content_windows, tui_display_all_data)
8323         (tui_data_window::do_scroll_vertical, tui_display_data_from):
8324         Update.
8325         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
8326         * tui/tui-regs.c (tui_last_regs_line_no)
8327         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
8328         (tui_show_registers): Update.
8329         (tui_show_register_group): Return void.  Update.
8330         (tui_display_registers_from, tui_display_reg_element_at_line)
8331         (tui_display_registers_from_line, tui_check_register_values):
8332         Update.
8333         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
8334         member.
8335         (struct tui_data_window) <regs_content>: Now a std::vector.
8336         <regs_content_count>: Remove.
8337         (tui_add_content_elements, tui_free_data_content): Don't declare.
8338         * tui/tui-data.c (tui_data_window::clear_detail): Update.
8339         (init_content_element): Remove DATA_WIN case.  Add assert.
8340         (tui_add_content_elements): Remove.
8341         (tui_data_window): Update.
8342         (tui_free_data_content): Remove.
8343         (free_content_elements): Remove DATA_WIN case.
8344
8345 2019-06-25  Tom Tromey  <tom@tromey.com>
8346
8347         * tui/tui-data.c (tui_data_item_window): Update.
8348         * tui/tui-windata.h (tui_check_data_values): Don't declare.
8349         * tui/tui-windata.c (tui_display_all_data)
8350         (tui_display_data_from_line): Update.
8351         (tui_check_data_values): Remove.
8352         * tui/tui-regs.c (tui_show_register_group)
8353         (tui_display_reg_element_at_line): Update.
8354         * tui/tui-hooks.c (tui_register_changed)
8355         (tui_refresh_frame_and_register_information): Call
8356         tui_check_register_values.
8357         * tui/tui-data.h (struct tui_data_window) <data_content,
8358         data_content_count, data_type>: Remove.
8359         (enum tui_data_type): Remove.
8360
8361         * tui/tui-data.c (tui_data_window::clear_detail)
8362         (~tui_data_window): Update.
8363
8364 2019-06-25  Tom Tromey  <tom@tromey.com>
8365
8366         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
8367         declare.
8368         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
8369         Rename from tui_first_data_item_displayed.  Update.
8370         (tui_data_window::refresh_all)
8371         (tui_data_window::do_scroll_vertical): Update.
8372         * tui/tui-data.h (struct tui_data_window)
8373         <first_data_item_displayed>: Declare new method.
8374
8375 2019-06-25  Tom Tromey  <tom@tromey.com>
8376
8377         * tui/tui-data.h (tui_init_generic_part): Don't declare.
8378         * tui/tui-data.c (tui_init_generic_part): Remove, moving
8379         contents...
8380         (tui_initialize_static_data): ...here.
8381
8382 2019-06-25  Tom Tromey  <tom@tromey.com>
8383
8384         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
8385         (tui_display_registers_from, tui_check_register_values): Update.
8386         (tui_display_register): Remove win_info parameter; update.
8387         (tui_get_register): Change type of parameters.
8388         * tui/tui-data.h (struct tui_data_element): Remove.
8389         (union tui_which_element) <data>: Remove.
8390         <data_window>: Change type.
8391         (struct tui_data_item_window): New.
8392         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
8393         case.  Add assert.
8394         (~tui_data_item_window): New destructor.
8395         (free_content_elements): Remove DATA_ITEM_WIN case.
8396
8397 2019-06-25  Tom Tromey  <tom@tromey.com>
8398
8399         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
8400         Remove.
8401
8402 2019-06-25  Tom Tromey  <tom@tromey.com>
8403
8404         * tui/tui-data.h (struct tui_command_element): Remove.
8405         (union tui_which_element) <command>: Remove.
8406         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
8407         assert.
8408         (free_content_elements): Remove CMD_WIN case.
8409
8410 2019-06-25  Tom Tromey  <tom@tromey.com>
8411
8412         * tui/tui-layout.c (tui_set_layout): Update.
8413         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
8414         * tui/tui-data.c (layout_def): Update.
8415
8416 2019-06-25  Tom Tromey  <tom@tromey.com>
8417
8418         * tui/tui-wingeneral.c (tui_refresh_all): Update.
8419         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
8420         (tui_source_window_base::set_new_height): Update.
8421         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
8422         Update.
8423         (tui_set_locator_fullname, tui_set_locator_info)
8424         (tui_show_frame_info): Update.
8425         * tui/tui-source.c (tui_set_source_content)
8426         (tui_source_is_displayed): Update.
8427         * tui/tui-layout.c (show_source_disasm_command, show_data)
8428         (show_source_or_disasm_and_command): Update.
8429         * tui/tui-disasm.c (tui_set_disassem_content)
8430         (tui_get_begin_asm_address): Update.
8431         * tui/tui-data.h (struct tui_locator_element): Remove.
8432         (union tui_which_element) <locator>: Remove.
8433         (struct tui_locator_window): New.
8434         (tui_locator_win_info_ptr): Change return type.
8435         * tui/tui-data.c (_locator): Change type.
8436         (tui_locator_win_info_ptr): Change return type.
8437         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
8438         (tui_alloc_content): Add assert.
8439
8440 2019-06-25  Tom Tromey  <tom@tromey.com>
8441
8442         * tui/tui-winsource.c
8443         (tui_exec_info_window::maybe_allocate_content): New method.
8444         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
8445         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
8446         (make_source_or_disasm_window): Add cast.
8447         * tui/tui-data.h (union tui_which_element) <simple_string>:
8448         Remove.
8449         (struct tui_source_info): New.
8450         (struct tui_source_window_base) <execution_info>: Change type.
8451         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
8452         case, and add assert.
8453         (tui_alloc_content): Add assert.
8454
8455 2019-06-25  Tom Tromey  <tom@tromey.com>
8456
8457         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
8458         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
8459         * tui/tui-data.c (tui_alloc_win_info): Remove.
8460
8461 2019-06-25  Tom Tromey  <tom@tromey.com>
8462
8463         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
8464         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
8465         can_highlight.
8466
8467 2019-06-25  Tom Tromey  <tom@tromey.com>
8468
8469         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
8470         make_visible_with_new_height method.
8471         (tui_win_info::make_visible_with_new_height): New method.
8472         (tui_source_window_base::do_make_visible_with_new_height)
8473         (tui_data_window::do_make_visible_with_new_height)
8474         (tui_cmd_window::do_make_visible_with_new_height): New methods.
8475         (make_visible_with_new_height): Remove.
8476         (tui_resize_all, tui_adjust_win_heights): Use
8477         make_visible_with_new_height method.
8478         * tui/tui-data.h (struct tui_win_info)
8479         <do_make_visible_with_new_height, make_visible_with_new_height>:
8480         New methods.
8481         (struct tui_source_window_base, struct tui_data_window)
8482         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
8483         methods.
8484
8485 2019-06-25  Tom Tromey  <tom@tromey.com>
8486
8487         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
8488         method.
8489         (update_tab_width): Call update_tab_width method.
8490         * tui/tui-data.h (struct tui_win_info)
8491         (struct tui_source_window_base) <update_tab_width>: New methods.
8492
8493 2019-06-25  Tom Tromey  <tom@tromey.com>
8494
8495         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
8496         parameter.
8497         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
8498         parameter.
8499         (tui_gen_win_info::make_visible): Update.
8500         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
8501         parameter.
8502         * tui/tui-data.h (enum tui_box): New enum.
8503         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
8504
8505 2019-06-25  Tom Tromey  <tom@tromey.com>
8506
8507         * tui/tui-layout.c (make_source_or_disasm_window): Always use
8508         init_and_make_win for EXEC_INFO_WIN.
8509         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
8510         longer inline.
8511         (struct tui_win_info) <~tui_win_info>: Inline.
8512         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
8513         Don't declare.
8514         * tui/tui-data.c (source_win, disasm_win): Remove globals.
8515         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
8516         Remove.
8517         (tui_initialize_static_data): Update.
8518         (~tui_gen_win_info): Handle more cleanup here.
8519         (~tui_source_window_base): Delete "execution_info".
8520         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
8521
8522 2019-06-25  Tom Tromey  <tom@tromey.com>
8523
8524         * tui/tui-layout.c (make_command_window): Don't set
8525         can_highlight.
8526         (show_source_disasm_command): Call the reset method.
8527         (show_data): Don't set can_highlight.  Call the reset method.
8528         (tui_gen_win_info::reset): Rename from init_gen_win_info
8529         (init_and_make_win): Simplify.  Return tui_gen_win_info.
8530         (show_source_or_disasm_and_command): Call the reset method.
8531         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
8532         (struct tui_cmd_window): Set can_highlight.
8533
8534 2019-06-25  Tom Tromey  <tom@tromey.com>
8535
8536         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
8537         from make_visible.
8538         (tui_make_visible, tui_make_invisible): Rewrite.
8539         (tui_win_info::make_visible): Remove.
8540         (tui_source_window_base::make_visible): Update.
8541         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
8542         method.  Moved from...
8543         (struct tui_win_info) <make_visible>: ...here.
8544
8545 2019-06-25  Tom Tromey  <tom@tromey.com>
8546
8547         * tui/tui-winsource.c
8548         (tui_source_window_base::do_scroll_horizontal): Remove direction
8549         parameter.
8550         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
8551         direction parameter.
8552         * tui/tui-win.c (tui_win_info::forward_scroll)
8553         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
8554         (tui_win_info::right_scroll): Update.
8555         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
8556         direction parameter.
8557         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
8558         direction parameter.
8559         * tui/tui-data.h (enum tui_scroll_direction): Remove.
8560         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
8561         Remove direction parameter.
8562         (struct tui_source_window_base, struct tui_source_window)
8563         (struct tui_disasm_window, struct tui_data_window)
8564         (struct tui_cmd_window): Update.
8565
8566 2019-06-25  Tom Tromey  <tom@tromey.com>
8567
8568         * tui/tui-winsource.h (tui_set_exec_info_content)
8569         (tui_show_exec_info_content, tui_erase_exec_info_content)
8570         (tui_clear_exec_info_content, tui_update_exec_info): Change
8571         argument to tui_source_window_base.
8572         * tui/tui-winsource.c (tui_set_exec_info_content)
8573         (tui_show_exec_info_content, tui_erase_exec_info_content)
8574         (tui_clear_exec_info_content, tui_update_exec_info): Change
8575         argument to tui_source_window_base.
8576
8577 2019-06-25  Tom Tromey  <tom@tromey.com>
8578
8579         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
8580         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
8581
8582 2019-06-25  Tom Tromey  <tom@tromey.com>
8583
8584         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
8585         check.
8586
8587 2019-06-25  Tom Tromey  <tom@tromey.com>
8588
8589         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
8590         type to void.
8591         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
8592         type to void.
8593         * tui/tui-source.c (tui_set_source_content): Update.
8594         * tui/tui-disasm.c (tui_set_disassem_content): Update.
8595
8596 2019-06-25  Tom Tromey  <tom@tromey.com>
8597
8598         * tui/tui-win.c (window_name_completer, tui_set_focus)
8599         (tui_all_windows_info): Use name method.
8600         * tui/tui-data.h (struct tui_gen_win_info)
8601         (struct tui_source_window, struct tui_disasm_window)
8602         (struct tui_data_window, struct tui_cmd_window) <name>: New
8603         method.
8604         (tui_win_name): Don't declare.
8605         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
8606         (tui_win_name): Remove.
8607
8608 2019-06-25  Tom Tromey  <tom@tromey.com>
8609
8610         * tui/tui-winsource.h (tui_update_source_window)
8611         (tui_update_source_window_as_is): Change parameter type.
8612         * tui/tui-winsource.c (tui_update_source_window): Change win_info
8613         to be a tui_source_window_base.
8614         (tui_update_source_window_as_is): Likewise.
8615         * tui/tui-win.c (make_visible_with_new_height): Update.
8616
8617 2019-06-25  Tom Tromey  <tom@tromey.com>
8618
8619         * tui/tui-winsource.c (tui_erase_source_content)
8620         (tui_show_source_content, tui_show_exec_info_content)
8621         (tui_erase_exec_info_content): Use refresh_window method.
8622         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
8623         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
8624         from tui_refresh_win.
8625         (tui_data_window::refresh_window): New method.
8626         (tui_win_info::refresh, tui_source_window_base::refresh)
8627         (tui_refresh_all): Use refresh_window method.
8628         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
8629         method.
8630         * tui/tui-regs.c (tui_display_register): Call refresh_window
8631         method.
8632         * tui/tui-layout.c (show_source_disasm_command)
8633         (show_source_or_disasm_and_command): Call refresh_window method.
8634         * tui/tui-data.h (struct tui_gen_win_info)
8635         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
8636         New method.
8637
8638 2019-06-25  Tom Tromey  <tom@tromey.com>
8639
8640         * tui/tui.c (tui_rl_other_window, tui_enable)
8641         (tui_is_window_visible, tui_get_command_dimension): Update.
8642         * tui/tui-winsource.c (tui_update_source_window_as_is)
8643         (tui_clear_source_content, tui_erase_source_content)
8644         (tui_show_source_line, tui_source_window_base::refill)
8645         (tui_source_window_base::do_scroll_horizontal)
8646         (tui_source_window_base::set_is_exec_point_at)
8647         (tui_update_breakpoint_info, tui_set_exec_info_content)
8648         (tui_alloc_source_buffer, tui_line_is_displayed)
8649         (tui_addr_is_displayed): Update.
8650         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
8651         (tui_check_and_display_highlight_if_needed)
8652         (tui_win_info::make_visible, tui_win_info::refresh)
8653         (tui_refresh_all): Update.
8654         * tui/tui-windata.c (tui_first_data_item_displayed)
8655         (tui_delete_data_content_windows, tui_erase_data_content)
8656         (tui_display_all_data, tui_data_window::refresh_all)
8657         (tui_check_data_values): Update.
8658         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
8659         (tui_set_win_focus_to, tui_win_info::forward_scroll)
8660         (tui_win_info::backward_scroll, tui_refresh_all_win)
8661         (tui_resize_all, tui_set_focus, tui_all_windows_info)
8662         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
8663         (tui_source_window_base::set_new_height)
8664         (tui_data_window::set_new_height)
8665         (make_invisible_and_set_new_height)
8666         (make_visible_with_new_height, new_height_ok)
8667         (parse_scrolling_args): Update.
8668         * tui/tui-stack.c (tui_show_frame_info): Update.
8669         * tui/tui-source.c (tui_set_source_content)
8670         (tui_set_source_content_nil, tui_source_is_displayed)
8671         (tui_source_window::do_scroll_vertical): Update.
8672         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
8673         (tui_display_registers_from, tui_display_reg_element_at_line)
8674         (tui_check_register_values, tui_reg_command): Update.
8675         * tui/tui-layout.c (tui_default_win_height)
8676         (show_source_disasm_command, show_data, init_and_make_win)
8677         (show_source_or_disasm_and_command): Update.
8678         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
8679         (tui_redisplay_readline, tui_mld_flush)
8680         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
8681         (tui_getc): Update.
8682         * tui/tui-disasm.c (tui_set_disassem_content)
8683         (tui_disasm_window::do_scroll_vertical): Update.
8684         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
8685         Now virtual.
8686         (struct tui_win_info): Derive from tui_gen_win_info.
8687         <~tui_win_info>: Mark as override.
8688         <generic>: Remove member.
8689         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
8690         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
8691         (~tui_data_window, ~tui_win_info)
8692         (tui_free_all_source_wins_content): Update.
8693         * tui/tui-command.c (tui_refresh_cmd_win): Update.
8694
8695 2019-06-25  Tom Tromey  <tom@tromey.com>
8696
8697         * tui/tui-layout.c (init_and_make_win): Use new.
8698         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
8699         destructor, initializers.
8700         (tui_alloc_generic_win_info): Don't declare.
8701         * tui/tui-data.c (_locator): Add argument to constructor.
8702         (source_win, disasm_win): New globals.
8703         (exec_info): Remove.
8704         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
8705         Update.
8706         (tui_alloc_generic_win_info): Remove.
8707         (init_content_element): Use new.
8708         (tui_win_info::tui_win_info): Update.
8709         (free_content_elements) <case DATA_WIN>: Use delete.
8710
8711 2019-06-25  Tom Tromey  <tom@tromey.com>
8712
8713         * tui/tui-wingeneral.c (tui_refresh_win): Update.
8714         * tui/tui-windata.c (tui_first_data_item_displayed)
8715         (tui_delete_data_content_windows): Update.
8716         * tui/tui-win.c (tui_data_window::set_new_height): Update.
8717         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
8718         (tui_display_registers_from, tui_check_register_values): Update.
8719         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
8720         pointer.
8721         * tui/tui-data.c (init_content_element): Update.  Allocate the new
8722         window.
8723         (tui_free_data_content): Update.
8724         (free_content_elements) <case DATA_WIN>: Free the window.
8725
8726 2019-06-25  Tom Tromey  <tom@tromey.com>
8727
8728         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
8729         Update.
8730         * tui/tui-layout.c (make_command_window)
8731         (show_source_disasm_command, show_data, init_and_make_win)
8732         (show_source_or_disasm_and_command): Update.
8733         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
8734         method.
8735         <can_highight, is_highlighted>: Now bool.
8736         (tui_set_win_highlight): Don't declare.
8737         * tui/tui-data.c (tui_set_win_highlight): Remove.
8738
8739 2019-06-25  Tom Tromey  <tom@tromey.com>
8740
8741         * tui/tui-wingeneral.c (make_visible): Remove check of window
8742         type.
8743
8744 2019-06-25  Tom Tromey  <tom@tromey.com>
8745
8746         * tui/tui-win.c (tui_win_info::max_height)
8747         (tui_cmd_window::max_height): New methods.
8748         (new_height_ok): Call max_height.
8749         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
8750         <max_height>: New method.
8751
8752 2019-06-25  Tom Tromey  <tom@tromey.com>
8753
8754         * tui/tui-win.c (tui_source_window_base::set_new_height)
8755         (tui_data_window::set_new_height): New methods.
8756         (make_invisible_and_set_new_height): Call set_new_height method.
8757         * tui/tui-data.h (struct tui_win_info)
8758         (struct tui_source_window_base, struct tui_data_window)
8759         <set_new_height>: New method.
8760
8761 2019-06-25  Tom Tromey  <tom@tromey.com>
8762
8763         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
8764         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
8765         tui_refresh_data_win.
8766         * tui/tui-win.c (tui_source_window_base::refresh_all): New
8767         method.
8768         (tui_refresh_all_win): Call the refresh_all method.
8769         (tui_set_focus): Likewise.
8770         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
8771         (struct tui_source_window_base, struct tui_data_window) <refresh>:
8772         Likewise.
8773
8774 2019-06-25  Tom Tromey  <tom@tromey.com>
8775
8776         * tui/tui-winsource.h (tui_refill_source_window)
8777         (tui_set_is_exec_point_at): Don't declare.
8778         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
8779         (tui_source_window_base::refill): Rename from
8780         tui_refill_source_window.
8781         (tui_source_window_base::do_scroll_horizontal): Update.
8782         (tui_source_window_base::set_is_exec_point_at): Rename from
8783         tui_set_is_exec_point_at.
8784         (tui_update_all_breakpoint_info): Update.
8785         * tui/tui-stack.c (tui_show_frame_info): Update.
8786         * tui/tui-layout.c (show_data): Add cast.
8787         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
8788         * tui/tui-data.h (struct tui_source_window_base) <refill,
8789         set_is_exec_point_at>: New methods.
8790         (tui_source_windows, tui_add_to_source_windows): Update types.
8791         (tui_add_to_source_windows): Remove redundant declaration.
8792         * tui/tui-data.c (source_windows): Store tui_source_window_base.
8793         (tui_source_windows): Change return type.
8794         (tui_clear_source_windows_detail): Update.
8795         (tui_add_to_source_windows): Change type of parameter.
8796         (tui_free_all_source_wins_content): Update.
8797
8798 2019-06-25  Tom Tromey  <tom@tromey.com>
8799
8800         * tui/tui-wingeneral.c (tui_win_info::refresh)
8801         (tui_source_window_base::refresh): New methods.
8802         (tui_refresh_all): Call the refresh method.
8803         * tui/tui-data.h (struct tui_win_info)
8804         (struct tui_source_window_base) <refresh>: New method.
8805
8806 2019-06-25  Tom Tromey  <tom@tromey.com>
8807
8808         * tui/tui.h (tui_is_window_visible): Return bool.
8809         * tui/tui.c (tui_is_window_visible): Return bool.
8810         * tui/tui-wingeneral.c (tui_make_window, make_visible)
8811         (tui_make_visible, tui_make_invisible)
8812         (tui_win_info::make_visible)
8813         (tui_source_window_base::make_visible, make_all_visible)
8814         (tui_make_all_visible, tui_make_all_invisible): Update.
8815         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
8816         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
8817         bool.
8818         (struct tui_win_info, struct tui_source_window_base)
8819         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
8820         * tui/tui-data.c (tui_init_generic_part): Update.
8821
8822 2019-06-25  Tom Tromey  <tom@tromey.com>
8823
8824         * tui/tui-wingeneral.c (tui_win_info::make_visible)
8825         (tui_source_window_base::make_visible): New methods.
8826         (make_all_visible): Make method call.
8827         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
8828         (struct tui_source_window_base, struct tui_cmd_window): Override
8829         make_visible.
8830         (tui_win_is_source_type): Don't declare.
8831         * tui/tui-data.c (tui_win_is_source_type): Remove.
8832
8833 2019-06-25  Tom Tromey  <tom@tromey.com>
8834
8835         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
8836         NULL check.
8837
8838 2019-06-25  Tom Tromey  <tom@tromey.com>
8839
8840         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
8841         Inline constructor.  Add initializers for members.
8842         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
8843         constructors; now inline in class.
8844
8845 2019-06-25  Tom Tromey  <tom@tromey.com>
8846
8847         * tui/tui-regs.c (tui_show_registers): Update.
8848         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
8849         bool.
8850         * tui/tui-data.c (tui_data_window::clear_detail)
8851         (tui_data_window): Update.
8852
8853 2019-06-25  Tom Tromey  <tom@tromey.com>
8854
8855         * tui/tui-windata.c (tui_display_all_data)
8856         (tui_display_data_from_line, tui_display_data_from)
8857         (tui_check_data_values, tui_data_window::do_scroll_vertical):
8858         Update.
8859         * tui/tui-regs.c (tui_last_regs_line_no)
8860         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
8861         (tui_show_registers, tui_show_register_group)
8862         (tui_display_registers_from, tui_display_reg_element_at_line)
8863         (tui_display_registers_from_line, tui_check_register_values)
8864         (tui_reg_next, tui_reg_prev): Update.
8865         * tui/tui-layout.c (tui_set_layout, show_data): Update.
8866         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
8867         tui_data_window.
8868         (struct tui_win_info) <detail>: Remove.  Add new fields from
8869         tui_data_info.
8870         (TUI_DATA_WIN): Add cast.
8871         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
8872         (~tui_data_window): Simplify.
8873
8874 2019-06-25  Tom Tromey  <tom@tromey.com>
8875
8876         * tui/tui-layout.c (show_source_disasm_command)
8877         (show_source_or_disasm_and_command): Update.
8878         * tui/tui-io.c (update_cmdwin_start_line)
8879         (tui_redisplay_readline): Update.
8880         * tui/tui-data.h (struct tui_command_info): Remove.
8881         (struct tui_win_info) <detail>: Remove command_info member.
8882         (struct tui_data_window) <start_line>: New member, from
8883         tui_command_info.
8884         (TUI_CMD_WIN): Add casts.
8885
8886 2019-06-25  Tom Tromey  <tom@tromey.com>
8887
8888         * tui/tui-winsource.c (tui_update_source_window)
8889         (tui_refill_source_window)
8890         (tui_source_window_base::do_scroll_horizontal)
8891         (tui_update_breakpoint_info, tui_set_exec_info_content)
8892         (tui_show_exec_info_content, tui_erase_exec_info_content)
8893         (tui_clear_exec_info_content): Update.
8894         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
8895         Update.
8896         * tui/tui-win.c (make_invisible_and_set_new_height)
8897         (make_visible_with_new_height): Update.
8898         * tui/tui-source.c (tui_set_source_content)
8899         (tui_show_symtab_source): Update.
8900         * tui/tui-layout.c (extract_display_start_addr)
8901         (show_source_disasm_command, show_data)
8902         (make_source_or_disasm_window)
8903         (show_source_or_disasm_and_command): Update.
8904         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
8905         (tui_disasm_window::do_scroll_vertical): Remove shadowing
8906         "gdbarch".
8907         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
8908         to tui_source_window_base.
8909         (struct tui_win_info) <detail>: Remove source_info member.
8910         (struct tui_source_window_base) <has_locator>: Inline.
8911         Move contents from tui_source_info; rename has_locator member to
8912         m_has_locator.
8913         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
8914         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
8915         header file.
8916         (tui_source_window_base::clear_detail, ~tui_source_window_base):
8917         Simplify.
8918         (tui_free_all_source_wins_content): Cast to
8919         tui_source_window_base.
8920
8921 2019-06-25  Tom Tromey  <tom@tromey.com>
8922
8923         * tui/tui-win.c (make_invisible_and_set_new_height)
8924         (make_visible_with_new_height): Call has_locator method.
8925         * tui/tui-layout.c (show_source_disasm_command, show_data)
8926         (show_source_or_disasm_and_command): Update for bool change.
8927         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
8928         (tui_win_info) <has_locator>: New method.
8929         (struct tui_source_window_base) <has_locator>: New method.
8930         (tui_win_has_locator): Don't declare.
8931         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
8932         from tui_win_has_locator.
8933         (tui_source_window_base): Use false, not FALSE.
8934
8935 2019-06-25  Tom Tromey  <tom@tromey.com>
8936
8937         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
8938         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
8939         clear_detail method directly.
8940         (tui_clear_win_detail): Remove.
8941
8942 2019-06-25  Tom Tromey  <tom@tromey.com>
8943
8944         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
8945         "this", not TUI_DISASM_WIN.
8946
8947 2019-06-25  Tom Tromey  <tom@tromey.com>
8948
8949         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
8950         declare.
8951         * tui/tui-winsource.c
8952         (tui_source_window_base::do_scroll_horizontal): Rename from
8953         tui_horizontal_source_scroll.
8954         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
8955         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
8956         from tui_vertical_data_scroll.
8957         * tui/tui-win.h (tui_scroll): Don't declare.
8958         * tui/tui-win.c (tui_win_info::forward_scroll)
8959         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
8960         (tui_win_info::right_scroll): Rename and update.
8961         (tui_scroll_forward_command, tui_scroll_backward_command)
8962         (tui_scroll_left_command, tui_scroll_right_command): Update.
8963         (tui_scroll): Remove.
8964         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
8965         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
8966         from tui_vertical_source_scroll.
8967         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
8968         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
8969         from tui_vertical_disassem_scroll.
8970         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
8971         do_scroll_horizontal>: New methods.
8972         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
8973         Likewise.
8974         (struct tui_source_window_base): Add do_scroll_horizontal.
8975         (struct tui_source_window, struct tui_disasm_window): Add
8976         do_scroll_vertical.
8977         (struct tui_data_window, struct tui_cmd_window): Add
8978         do_scroll_horizontal and do_scroll_vertical.
8979         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
8980
8981 2019-06-25  Tom Tromey  <tom@tromey.com>
8982
8983         * tui/tui-data.h (struct tui_source_window_base): New struct.
8984         (struct tui_source_window): Derive from tui_source_window_base.
8985         (struct tui_disasm_window): New struct.
8986         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
8987         from tui_source_window::clear_detail.
8988         (tui_source_window_base): Rename from tui_source_window.
8989         (~tui_source_window_base): Rename from ~tui_source_window.
8990         (tui_alloc_win_info): Create a tui_disasm_window.
8991
8992 2019-06-25  Tom Tromey  <tom@tromey.com>
8993
8994         * tui/tui-data.h (struct tui_source_window)
8995         (struct tui_data_window): Declare destructors.
8996         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
8997         destructors.
8998         (tui_win_info): Simplify.
8999
9000 2019-06-25  Tom Tromey  <tom@tromey.com>
9001
9002         * tui/tui-winsource.c (tui_display_main)
9003         (tui_update_source_windows_with_addr)
9004         (tui_update_all_breakpoint_info): Update.
9005         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
9006         (new_height_ok, parse_scrolling_args): Update.
9007         * tui/tui-stack.c (tui_show_frame_info): Update.
9008         * tui/tui-data.h (struct tui_list): Remove.
9009         (tui_source_windows): Return a reference to a std::vector.
9010         * tui/tui-data.c (source_windows): Now a std::vector.
9011         (tui_source_windows): Change return type.
9012         (tui_clear_source_windows): Rewrite.
9013         (tui_clear_source_windows_detail, tui_add_to_source_windows)
9014         (tui_free_all_source_wins_content): Rewrite.
9015
9016 2019-06-25  Tom Tromey  <tom@tromey.com>
9017
9018         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
9019         (struct tui_data_window, struct tui_cmd_window): Declare
9020         clear_detail method.
9021         * tui/tui-data.c (tui_source_window::clear_detail)
9022         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
9023         methods.
9024         (tui_clear_win_detail): Simplify.
9025
9026 2019-06-25  Tom Tromey  <tom@tromey.com>
9027
9028         * tui/tui-layout.c (make_source_window, make_disasm_window)
9029         (make_source_or_disasm_window): Remove win_info_ptr parameter.
9030         Return the new window.
9031         (show_source_disasm_command, show_data)
9032         (show_source_or_disasm_and_command): Update.
9033
9034 2019-06-25  Tom Tromey  <tom@tromey.com>
9035
9036         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
9037         parameter.  Return the new window.
9038         (show_source_disasm_command): Update and remove NULL check.
9039         (show_source_or_disasm_and_command): Update.
9040
9041 2019-06-25  Tom Tromey  <tom@tromey.com>
9042
9043         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
9044
9045 2019-06-25  Tom Tromey  <tom@tromey.com>
9046
9047         * tui/tui-data.h (struct tui_win_info): Make constructor
9048         protected.  Make destructor virtual.  Add initializers.
9049         (tui_source_window, tui_data_window, tui_cmd_window): New
9050         classes.
9051         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
9052         constructor.  Add "type" parameter.
9053         (tui_source_window, tui_data_window, tui_cmd_window): New
9054         constructors.
9055         (tui_alloc_win_info): Instantiate the appropriate subclass.
9056
9057 2019-06-25  Tom Tromey  <tom@tromey.com>
9058
9059         * tui/tui-win.c (tui_resize_all): Use delete.
9060         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
9061         destructor.
9062         (tui_free_window): Don't declare.
9063         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
9064         Update.
9065
9066 2019-06-25  Tom Tromey  <tom@tromey.com>
9067
9068         * tui/tui-data.h (struct tui_win_info): Add constructor.
9069         * tui/tui-data.c (tui_alloc_win_info): Use new.
9070         (tui_free_window): Use delete.
9071
9072 2019-06-22  Tom Tromey  <tom@tromey.com>
9073
9074         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
9075         declare.
9076         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
9077
9078 2019-06-22  Tom Tromey  <tom@tromey.com>
9079
9080         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
9081         declare.
9082         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
9083
9084 2019-06-22  Tom de Vries  <tdevries@suse.de>
9085
9086         * dwarf2read.c (create_addrmap_from_aranges)
9087         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
9088         instead of '%zu'.
9089
9090 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
9091
9092         * dwarf2read.h (dwarf2_section_info_def): Remove.
9093         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
9094         * dwarf2read.c (struct dwo_sections) <types>: Change type to
9095         std::vector<dwarf2_section_info>.
9096         (struct dwo_file) <~dwo_file>: Remove.
9097         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
9098         types field.
9099         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
9100         (dwarf2_read_debug_names): Likewise.
9101         (create_debug_types_hash_table): Change parameter type to
9102         array_view, adjust code accordingly.
9103         (dwarf2_locate_dwo_sections): Adjust to std::vector.
9104         (partial_die_info::fixup): Likewise.
9105         (determine_prefix): Likewise.
9106         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
9107
9108 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
9109
9110         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
9111         gdb_bfd_ref_ptr.
9112         <~dwo_file>: Remove call to gdb_bfd_unref.
9113         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
9114         gdb_bfd_ref_ptr::get.
9115
9116 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
9117
9118         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
9119         type to htab_up.
9120         * dwarf2read.c (struct dwo_file): Initialize fields.
9121         <~dwo_file>: New.
9122         (free_dwo_file): Remove, move content to ~dwo_file.
9123         (struct dwo_file_deleter): Remove.
9124         (dwo_file_up>: Remove custom deleter.
9125         (free_dwo_files): Remove.
9126         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
9127         dwo_files.
9128         (process_skeletonless_type_units): Call unique_ptr::get.
9129         (allocate_dwo_file_hash_table): Add deleter to created hash
9130         table.  Change return type to htab_up.
9131         (lookup_dwo_file_slot): Don't memset dwo_file, call
9132         unique_ptr::get.
9133         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
9134         (create_dwo_unit_in_dwp_v2): Likewise.
9135         (open_and_init_dwo_file): Likewise.
9136         (free_dwo_file_from_slot): Remove.
9137
9138 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
9139
9140         * dwarf2read.h (struct dwarf2_section_info) <readin,
9141         is_virtual>: Change type to bool.
9142         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
9143         true instead of 1.
9144
9145 2019-06-19  Tom Tromey  <tom@tromey.com>
9146
9147         * tui/tui-data.h (tui_init_content_element): Don't declare.
9148
9149 2019-06-19  Tom Tromey  <tom@tromey.com>
9150
9151         * tui/tui-data.h (tui_init_win_info): Don't declare.
9152
9153 2019-06-19  Tom de Vries  <tdevries@suse.de>
9154
9155         * dwarf2read.h (abstract_to_concrete): Change type to
9156         std::unordered_map<sect_offset, std::vector<sect_offset>,
9157         gdb::hash_enum<sect_offset>>.
9158
9159 2019-06-19  Tom Tromey  <tromey@adacore.com>
9160
9161         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
9162         EVAL_AVOID_SIDE_EFFECTS specially.
9163
9164 2019-06-19  Tom Tromey  <tromey@adacore.com>
9165
9166         * source-cache.c (highlighter): New global.
9167         (source_cache::get_source_lines): Create a highlighter on demand.
9168
9169 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
9170
9171         * defs.h (deprecated_interactive_hook): Delete declaration.
9172         * interps.c (clear_interpreter_hooks): Remove use of
9173         deprecated_interactive_hook.
9174         * top.c (deprecated_interactive_hook): Delete definition.
9175         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
9176
9177 2019-06-18  Tom de Vries  <tdevries@suse.de>
9178
9179         PR gdb/24515
9180         * dwarf2read.h (abstract_to_concrete): Change type from
9181         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
9182         std::unordered_map<sect_offset, std::vector<sect_offset>>.
9183         * dwarf2read.c (read_variable): Update.
9184         (dwarf2_fetch_die_loc_sect_off): Update.
9185
9186 2019-06-17  Tom de Vries  <tdevries@suse.de>
9187
9188         PR gdb/24617
9189         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
9190         accessing parent[parent_len - 1].
9191
9192 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
9193
9194         PR gdb/24364
9195         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
9196         call dtrace_process_dof with NULL dof.
9197
9198 2019-06-16  Tom de Vries  <tdevries@suse.de>
9199
9200         PR gdb/24445
9201         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
9202
9203 2019-06-16  Tom Tromey  <tom@tromey.com>
9204
9205         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
9206         (make_all_visible): Use address of member.
9207
9208 2019-06-16  Tom Tromey  <tom@tromey.com>
9209
9210         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
9211         (tui_free_window, free_content, free_content_elements): Remove
9212         unnecessary cast.
9213         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
9214         cast.
9215         * tui/tui-regs.c (tui_show_register_group)
9216         (tui_display_registers_from, tui_display_reg_element_at_line):
9217         Remove unnecessary cast.
9218
9219 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
9220
9221         * linux-nat.c (normal_mask): Delete.
9222         (_initialize_linux_nat): Don't initialise normal_mask.
9223
9224 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
9225
9226         PR gdb/24445
9227         * dwarf-index-write.h (write_psymtabs_to_index): Add
9228         dwz_basename parameter.
9229         * dwarf-index-write.c (write_gdbindex): Move file writing to
9230         write_gdbindex_1.  Change return type void.
9231         (assert_file_size): Move up, remove filename parameter.
9232         (write_gdbindex_1): New function.
9233         (write_debug_names): Change return type to void, call
9234         assert_file_size.
9235         (struct index_wip_file): New struct.
9236         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
9237         file logic to index_wip_file.  Write index for dwz file if
9238         needed.
9239         (save_gdb_index_command): Pass basename of dwz file, if present.
9240         * dwarf-index-cache.c (index_cache::store): Obtain and pass
9241         build-id of dwz file, if present.
9242         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
9243         (dwarf2_get_dwz_file): Likewise.
9244         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
9245         (dwarf2_get_dwz_file): Likewise.
9246
9247 2019-06-16  Tom Tromey  <tom@tromey.com>
9248
9249         * coffread.c (process_coff_symbol): Use xstrdup.
9250         * value.c (create_internalvar): Use xstrdup.
9251
9252 2019-06-16  Tom Tromey  <tom@tromey.com>
9253
9254         * valops.c (value_cast, value_slice): Remove unnecessary cast.
9255         * breakpoint.c (stopin_command, stopat_command)
9256         (until_break_command, decode_location_default): Remove unnecessary
9257         cast.
9258         * utils.c (subset_compare): Remove unnecessary cast.
9259         * ada-lang.c (ada_update_initial_language): Remove unnecessary
9260         cast.
9261         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
9262         cast.
9263         * infcmd.c (path_command): Remove unnecessary cast.
9264         * coffread.c (decode_type): Remove unnecessary cast.
9265         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
9266         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
9267         * tui/tui-stack.c (tui_show_locator_content)
9268         (tui_show_frame_info): Remove unnecessary cast.
9269         * tui/tui-win.c (tui_scroll_forward_command)
9270         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
9271         (parse_scrolling_args): Remove unnecessary cast.
9272         * tui/tui-data.c (init_win_info, tui_del_window)
9273         (tui_free_window, tui_del_data_windows, tui_free_data_content)
9274         (free_content_elements): Remove unnecessary cast.
9275         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
9276         unnecessary cast.
9277         * tui/tui-source.c (tui_set_source_content)
9278         (tui_vertical_source_scroll): Remove unnecessary cast.
9279         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
9280         cast.
9281         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
9282         * tui/tui-regs.c (tui_display_registers_from)
9283         (tui_display_register): Remove unnecessary cast.
9284         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
9285         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
9286         (make_visible): Remove unnecessary cast.
9287         * tui/tui-winsource.c (tui_erase_source_content)
9288         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
9289         unnecessary cast.
9290         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
9291         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
9292         * stabsread.c (read_type, read_array_type, read_range_type):
9293         Remove unnecessary cast.
9294         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
9295         (parse_symbol, parse_type, upgrade_type, parse_external)
9296         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
9297         unnecessary cast.
9298         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
9299
9300 2019-06-16  Tom Tromey  <tom@tromey.com>
9301
9302         * tui/tui-data.c (tui_alloc_generic_win_info)
9303         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
9304         checks.
9305
9306 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
9307             Andrew Burgess  <andrew.burgess@embecosm.com>
9308
9309         * f-typeprint.c (f_print_type): Don't return early for not
9310         associated or not allocated types.
9311         (f_type_print_varspec_suffix): Add print_rank parameter and print
9312         ranks of array types in case they dangling.
9313         (f_type_print_base): Add print_rank parameter.
9314
9315 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
9316
9317         * NEWS: Mention new MI commands.
9318         * break-catch-throw.c (enum exception_event_kind): Move to
9319         breakpoint.h.
9320         (print_mention_exception_catchpoint): Output text as a single
9321         message.
9322         (catch_exception_command_1): Rename to...
9323         (catch_exception_event): ...this, make non-static, update header
9324         command, and change some parameter types.
9325         (catch_catch_command): Update for changes to
9326         catch_exception_command_1.
9327         (catch_throw_command): Likewise.
9328         (catch_rethrow_command): Likewise.
9329         * breakpoint.c (enum exception_event_kind): Delete.
9330         * breakpoint.h (enum exception_event_kind): Moved here from
9331         break-catch-throw.c.
9332         (catch_exception_event): Declare.
9333         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
9334         (mi_cmd_catch_throw): New function.
9335         (mi_cmd_catch_rethrow): New function.
9336         (mi_cmd_catch_catch): New function.
9337         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
9338         'catch-catch' entries.
9339         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
9340         (mi_cmd_catch_rethrow): Declare.
9341         (mi_cmd_catch_catch): Declare.
9342
9343 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
9344
9345         * annotate.c (annotate_source_line): Change return type to void,
9346         update implementation to match.
9347         * annotate.h (annotate_source_line): Change return type to void,
9348         update header comment.
9349         * stack.c (print_frame_info): Don't change what frame information
9350         is printed based on whether annotations are on or not.
9351
9352 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
9353
9354         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
9355         (annotate_source): Make static.
9356         (annotate_source_line): Moved from source.c and renamed from
9357         identify_source_line.  Update the return type.
9358         * annotate.h (annotate_source): Delete declaration.
9359         (annotate_source_line): Declaration moved from source.h, and
9360         renamed from identify_source_line.  Return type updated.
9361         * source.c (identify_source_line): Moved to annotate.c and renamed
9362         to annotate_source_line.
9363         (info_line_command): Remove check of annotation_level.
9364         * source.h (identify_source_line): Move declaration to annotate.h
9365         and rename to annotate_source_line.
9366         * stack.c: Add 'annotate.h' include.
9367         (print_frame_info): Remove check of annotation_level before
9368         calling annotate_source_line.
9369
9370 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
9371
9372         * source-cache.c (source_cache::get_plain_source_lines): Use
9373         open_source_file_with_line_charpos instead of just
9374         open_source_file, remove call to find_source_lines.
9375         (source_cache::get_source_lines): Likewise.
9376         * source.c (find_source_lines): Make static.
9377         (get_filename_and_charpos): Renamed into...
9378         (open_source_file_with_line_charpos): ..this along with changes to
9379         return a scoped_fd, and some other minor clean ups.
9380         (identify_source_line): Use open_source_file_with_line_charpos.
9381         (search_command_helper): Use open_source_file_with_line_charpos
9382         instead of just open_source_file, remove call to
9383         find_source_lines.
9384         * source.h (open_source_file_with_line_charpos): Declare new
9385         function.
9386         (find_source_lines): Delete declaration.
9387
9388 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
9389
9390         * source.c (get_filename_and_charpos): Remove fullname
9391         parameter.
9392         (identify_source_line): Update call to get_filename_and_charpos.
9393
9394 2019-06-14  Tom Tromey  <tromey@adacore.com>
9395
9396         PR gdb/24502:
9397         * ui-style.h (skip_ansi_escape): Update comment.
9398         * ui-file.h (class no_terminal_escape_file): New class.
9399         * ui-file.c (no_terminal_escape_file::write)
9400         (no_terminal_escape_file::puts): New methods.
9401         * cli/cli-logging.c (handle_redirections): Use
9402         no_terminal_escape_file.
9403
9404 2019-06-14  Tom Tromey  <tromey@adacore.com>
9405
9406         * NEWS: Move convenience variable news above Python news.
9407
9408 2019-06-14  Tom Tromey  <tom@tromey.com>
9409
9410         * gnulib: Move directory to top-level.
9411         * configure.ac: Don't configure gnulib.
9412         * configure: Rebuild.
9413         * common/common-defs.h: Use new path to gnulib.
9414         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
9415         (GNULIB_H): Remove.
9416         (INCGNU): Look in new gnulib location.
9417         (HFILES_NO_SRCDIR): Remove gnulib files.
9418         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
9419         (generated_files): Remove GNULIB_H.
9420         ($(LIBGNU), all-lib): Remove targets.
9421         (distclean): Don't mention GNULIB_BUILDDIR.
9422         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
9423
9424 2019-06-14  Tom Tromey  <tromey@adacore.com>
9425
9426         * symfile.c (add_symbol_file_command): Remove obsolete comment.
9427         Warn if symbol file does not provide any symbols.
9428
9429 2019-06-14  Tom Tromey  <tromey@adacore.com>
9430
9431         * source.c (find_and_open_source): Respect basenames_may_differ.
9432
9433 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
9434
9435         * annotate.c (annotate_breakpoints_invalid): Make use of
9436         scoped_restore_terminal_state.
9437         (annotate_frames_invalid): Likewise.
9438
9439 2019-06-14  Tom Tromey  <tromey@adacore.com>
9440
9441         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
9442         allow assignment to an internalvar.
9443
9444 2019-06-14  Tom Tromey  <tromey@adacore.com>
9445
9446         * ada-lex.l: Allow "_" in attribute names.
9447
9448 2019-06-14  Tom Tromey  <tromey@adacore.com>
9449
9450         PR gdb/24653:
9451         * regcache.c (registers_changed): Don't call alloca.
9452         * top.c (execute_command): Don't call alloca.
9453
9454 2019-06-13  Pedro Alves  <palves@redhat.com>
9455
9456         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
9457         'expression'.  When parsing an expression, error out if there's
9458         junk after "unlimited".
9459         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
9460         (do_set_command): Adjust calls to is_unlimited_literal.
9461
9462 2019-06-13  Pedro Alves  <palves@redhat.com>
9463
9464         * compile/compile.c (make_compile_options_def_group): Add braces
9465         around array_view initializer.
9466         * thread.c (make_thread_apply_all_options_def_group)
9467         (make_thread_apply_all_options_def_group): Likewise.
9468
9469 2019-06-13  Pedro Alves  <palves@redhat.com>
9470
9471         * NEWS (New commands): Mention "maint test-options
9472         require-delimiter", "maint test-options unknown-is-error", "maint
9473         test-options unknown-is-operand" and "maint show
9474         test-options-completion-result".
9475         (New command options, command completion): New section.
9476         (Completion improvements): New section.
9477         Mention that you can abbreviate "unlimited".
9478
9479 2019-06-13  Pedro Alves  <palves@redhat.com>
9480
9481         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
9482         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
9483         * unittests/cli-utils-selftests.c (test_parse_flags)
9484         (test_parse_flags_qcs): Delete.
9485         (test_cli_utils): Don't call deleted functions.
9486
9487 2019-06-13  Pedro Alves  <palves@redhat.com>
9488
9489         * thread.c: Include "cli/cli-option.h".
9490         (tp_array_compar_ascending): Global.
9491         (tp_array_compar): Delete function.
9492         (tp_array_compar_ascending, tp_array_compar_descending): New
9493         functions.
9494         (ascending_option_def, qcs_flag_option_def)
9495         (thr_qcs_flags_option_defs)
9496         (make_thread_apply_all_options_def_group)
9497         (make_thread_apply_options_def_group): New.
9498         (thread_apply_all_command): Use gdb::option::process_options.
9499         (thread_apply_command_completer)
9500         (thread_apply_all_command_completer): New.
9501         (thread_apply_command): Use gdb::option::process_options.
9502         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
9503         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
9504         to generate help text of "thread apply".  Adjust "taas"'s help.
9505         * tid-parse.c (tid_range_parser::in_thread_range): New method.
9506         * tid-parse.h (tid_range_parser::in_thread_range): New method.
9507
9508 2019-06-13  Pedro Alves  <palves@redhat.com>
9509
9510         * thread.c (thread_apply_command): Check for invalid TID with
9511         isdigit instead of !isalpha.
9512
9513 2019-06-13  Pedro Alves  <palves@redhat.com>
9514
9515         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
9516         (validate_flags_qcs): New.
9517         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
9518         (validate_flags_qcs): Declare.
9519         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
9520         (make_frame_apply_options_def_group): New.
9521         (frame_apply_command_count): Process options with
9522         gdb::option::process_options.
9523         (frame_apply_completer): New.
9524         (frame_apply_level_completer, frame_apply_all_completer)
9525         (frame_apply_completer): New.
9526         (_initialize_stack): Update help of "frame apply", "frame apply
9527         level", "frame apply all" and "faas" to mention supported options
9528         and install command completers.
9529         * stack.h (frame_apply_all_completer): Declare.
9530         * thread.c: Include "stack.h".
9531         (tfaas_command): Add "--".
9532         (_initialize_thread): Update help "tfaas" to mention supported
9533         options and install command completer.
9534
9535 2019-06-13  Pedro Alves  <palves@redhat.com>
9536
9537         * completer.c (complete_nested_command_line): New.
9538         (gdb_completion_word_break_characters_throw): Add assertion.
9539         * completer.h (complete_nested_command_line): Declare.
9540
9541 2019-06-13  Pedro Alves  <palves@redhat.com>
9542
9543         * stack.c (parse_backtrace_qualifiers): New.
9544         (backtrace_command): Use it.
9545         (backtrace_command_completer): Complete on qualifiers.
9546
9547 2019-06-13  Pedro Alves  <palves@redhat.com>
9548
9549         * frame.c: Include "cli/cli-option.h.
9550         (user_set_backtrace_options): New.
9551         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
9552         Delete.
9553         (get_prev_frame): Adjust.
9554         (boolean_option_def, uinteger_option_def)
9555         (set_backtrace_option_defs): New.
9556         (_initialize_frame): Adjust and use
9557         gdb::option::add_setshow_cmds_for_options to install "set
9558         backtrace past-main" and "set backtrace past-entry".
9559         * frame.h: Include "cli/cli-option.h".
9560         (struct frame_print_options): Forward declare.
9561         (print_frame_arguments_all, print_frame_arguments_scalars)
9562         (print_frame_arguments_none): Declare.
9563         (print_entry_values): Delete declaration.
9564         (struct frame_print_options, user_frame_print_options): New.
9565         (struct set_backtrace_options): New.
9566         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
9567         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
9568         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
9569         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
9570         (list_args_or_locals): Add frame_print_options parameter.
9571         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
9572         * python/py-framefilter.c (enumerate_args): Pass down
9573         USER_FRAME_PRINT_OPTIONS.
9574         * stack.c: Include "cli/cli-option.h".
9575         (print_frame_arguments_all, print_frame_arguments_scalars)
9576         (print_frame_arguments_none): Declare.
9577         (print_raw_frame_arguments, print_entry_values): Delete.
9578         (user_frame_print_options): New.
9579         (boolean_option_def, enum_option_def, frame_print_option_defs):
9580         New.
9581         (struct backtrace_cmd_options): New.
9582         (bt_flag_option_def): New.
9583         (backtrace_command_option_defs): New.
9584         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
9585         (print_frame_arg, read_frame_arg, print_frame_args)
9586         (print_frame_info, print_frame): Add frame_print_options parameter
9587         and use it.
9588         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
9589         (backtrace_command_1): Add frame_print_options and
9590         backtrace_cmd_options parameters and use them.
9591         (make_backtrace_options_def_group): New.
9592         (backtrace_command): Process command options with
9593         gdb::option::process_options.
9594         (backtrace_command_completer): New.
9595         (_initialize_stack): Extend "backtrace"'s help to mention
9596         supported options.  Install completer for "backtrace".
9597         Install some settings commands with add_setshow_cmds_for_options.
9598
9599 2019-06-13  Pedro Alves  <palves@redhat.com>
9600
9601         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
9602         and that "set/show print raw frame-arguments" are now deprecated.
9603
9604         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
9605         command.
9606         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
9607         * stack.c (_initialize_stack): Install "set/show print
9608         raw-frame-arguments", and deprecate "set/show print raw
9609         frame-arguments".
9610         * valprint.c (_initialize_valprint): Deprecate "set/show print
9611         raw".
9612
9613 2019-06-13  Pedro Alves  <palves@redhat.com>
9614
9615         * compile/compile.c (struct compile_options): New.
9616         (compile_flag_option_def, compile_command_option_defs)
9617         (make_compile_options_def_group): New.
9618         (compile_file_command): Handle options with
9619         gdb::option::process_options.
9620         (compile_file_command_completer): New function.
9621         (compile_code_command): Handle options with
9622         gdb::option::process_options.
9623         (compile_code_command_completer): New function.
9624         (_initialize_compiler): Install completers for "compile code" and
9625         "compile file".  Mention available options in "compile code" and
9626         "compile code"'s help.
9627         * completer.c (advance_to_completion_word): New, factored out from
9628         ...
9629         (advance_to_expression_complete_word_point): ... this.
9630         (advance_to_filename_complete_word_point): New.
9631         * completer.h (advance_to_filename_complete_word_point): New
9632         declaration.
9633
9634 2019-06-13  Pedro Alves  <palves@redhat.com>
9635
9636         * compile/compile.c: Include "cli/cli-option.h".
9637         (compile_print_value): Scope data pointer is now a
9638         value_print_options pointer; adjust.
9639         (compile_print_command): Process options.  Scope data pointer is
9640         now a value_print_options pointer; adjust.
9641         (_initialize_compile): Update "compile print"'s help to include
9642         supported options.  Install a completer for "compile print".
9643         * cp-valprint.c (show_vtblprint, show_objectprint)
9644         (show_static_field_print): Delete.
9645         (_initialize_cp_valprint): Don't install "set print
9646         static-members", "set print vtbl", "set print object" here.
9647         * printcmd.c: Include "cli/cli-option.h" and
9648         "common/gdb_optional.h".
9649         (print_command_parse_format): Rework to fill in a
9650         value_print_options instead of a format_data.
9651         (print_value): Change parameter type from format_data pointer to
9652         value_print_options reference.  Adjust.
9653         (print_command_1): Process options.  Adjust to pass down a
9654         value_print_options.
9655         (print_command_completer): New.
9656         (_initialize_printcmd): Install print_command_completer as
9657         handle_brkchars completer for the "print" command.  Update
9658         "print"'s help to include supported options.
9659         * valprint.c: Include "cli/cli-option.h".
9660         (show_vtblprint, show_objectprint, show_static_field_print): Moved
9661         here from cp-valprint.c.
9662         (boolean_option_def, uinteger_option_def)
9663         (value_print_option_defs, make_value_print_options_def_group):
9664         New.  Use gdb::option::add_setshow_cmds_for_options to install
9665         "set print elements", "set print null-stop", "set print repeats",
9666         "set print pretty", "set print union", "set print array", "set
9667         print address", "set print symbol", "set print array-indexes".
9668         * valprint.h: Include <string> and "cli/cli-option.h".
9669         (make_value_print_options_def_group): Declare.
9670         (print_value): Change parameter type from format_data pointer to
9671         value_print_options reference.
9672         (print_command_completer): Declare.
9673
9674 2019-06-13  Pedro Alves  <palves@redhat.com>
9675
9676         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
9677         (COMMON_SFILES): Add maint-test-settings.c.
9678         * cli/cli-decode.c (boolean_enums): New global, factored out from
9679         ...
9680         (add_setshow_boolean_cmd): ... here.
9681         * cli/cli-decode.h (boolean_enums): Declare.
9682         * cli/cli-option.c: New file.
9683         * cli/cli-option.h: New file.
9684         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
9685         factored out from ...
9686         (parse_cli_boolean_value(const char *)): ... this.
9687         (is_unlimited_literal): Change parameter type to pointer to
9688         pointer.  Adjust and advance ARG pointer.
9689         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
9690         (parse_cli_var_enum): New, factored out from ...
9691         (do_set_command): ... this.  Adjust.
9692         * cli/cli-setshow.h (parse_cli_boolean_value)
9693         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
9694         (parse_cli_var_enum): Declare.
9695         * cli/cli-utils.c: Include "cli/cli-option.h".
9696         (get_ulongest): New.
9697         * cli/cli-utils.h (get_ulongest): Declare.
9698         (check_for_argument): New overloads.
9699         * maint-test-options.c: New file.
9700
9701 2019-06-13  Pedro Alves  <palves@redhat.com>
9702
9703         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
9704         parse a range if "-" is at the end of the string.
9705
9706 2019-06-13  Pedro Alves  <palves@redhat.com>
9707
9708         * cli/cli-setshow.c (parse_auto_binary_operation)
9709         (parse_cli_boolean_value): Don't allow "o".
9710
9711 2019-06-13  Pedro Alves  <palves@redhat.com>
9712
9713         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
9714         * NEWS: Mention maint test-settings KIND.
9715         * maint-test-settings.c: New file.
9716
9717 2019-06-13  Pedro Alves  <palves@redhat.com>
9718
9719         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
9720         completer.
9721         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
9722         "set" completers.
9723
9724 2019-06-13  Pedro Alves  <palves@redhat.com>
9725
9726         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
9727         after item.
9728
9729 2019-06-13  Pedro Alves  <palves@redhat.com>
9730
9731         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
9732
9733 2019-06-13  Pedro Alves <palves@redhat.com>
9734
9735         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
9736         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
9737         call.
9738         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
9739         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
9740         calls.
9741         (check_for_argument): Skip spaces after argument.
9742
9743 2019-06-13  Pedro Alves  <palves@redhat.com>
9744
9745         * thread.c (thread_apply_command): Adjust TID parsing.
9746         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
9747         detected before end of string.
9748         (tid_is_in_list): Error out if LIST is invalid.
9749
9750 2019-06-13  Pedro Alves  <palves@redhat.com>
9751
9752         * completer.c (complete_line_internal_1): Rewind completion word
9753         point.
9754         (completion_tracker::advance_custom_word_point_by): Change
9755         parameter type to int.
9756         * completer.h (completion_tracker::advance_custom_word_point_by):
9757         Likewise.
9758
9759 2019-06-13  Pedro Alves  <palves@redhat.com>
9760
9761         * completer.c (advance_to_completion_word): Handle delimiters.
9762
9763 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
9764
9765         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
9766
9767 2019-06-11  Tom Tromey  <tom@tromey.com>
9768
9769         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
9770         (xmalloc_failed): Move to alloc.c.
9771         * alloc.c: New file.
9772         * Makefile.in (COMMON_SFILES): Add alloc.c.
9773
9774 2019-06-11  Tom Tromey  <tom@tromey.com>
9775
9776         * nat/linux-waitpid.c: Don't include server.h.
9777         (linux_debug): Remove.
9778         (my_waitpid): Update.
9779
9780 2019-06-11  Tom Tromey  <tromey@adacore.com>
9781
9782         * infcall.c (_initialize_infcall): Remove trailing newline from
9783         help.
9784         * user-regs.c (_initialize_user_regs): Remove trailing newline
9785         from help.
9786         * typeprint.c (_initialize_typeprint): Remove trailing newline
9787         from help.
9788         * reverse.c (_initialize_reverse): Remove trailing newlines from
9789         help.
9790         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
9791         from help.
9792         * language.c (add_set_language_command): Remove trailing newline
9793         from help.
9794         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
9795         help.
9796         * disasm.c (_initialize_disasm): Remove trailing newline from
9797         help.
9798         * top.c (init_main): Remove trailing newline from help.
9799         * interps.c (_initialize_interpreter): Remove trailing newline
9800         from help.
9801         * btrace.c (_initialize_btrace): Remove trailing newlines from
9802         help.
9803         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
9804         from help.
9805         * python/python.c (_initialize_python): Remove trailing newline
9806         from help.
9807         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
9808         help.
9809         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
9810         from help.  Reformat some text.
9811         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
9812         from help.
9813         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
9814         newline from help.
9815
9816 2019-06-11  Tom Tromey  <tromey@adacore.com>
9817
9818         * darwin-nat.c (darwin_decode_exception_message)
9819         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
9820
9821 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
9822
9823         * valops.c (value_slice): Check for not allocated or not
9824         associated values.
9825
9826 2019-06-10  Tom de Vries  <tdevries@suse.de>
9827
9828         PR gdb/24618
9829         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
9830         sure an empty slot (defined by a 32-bit zero pair) is recognized as
9831         invalid.
9832
9833 2019-06-10  Tom de Vries  <tdevries@suse.de>
9834
9835         PR gdb/24611
9836         * linespec.c (linespec_lexer_lex_string): Remove incorrect
9837         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
9838
9839 2019-06-10  Tom de Vries  <tdevries@suse.de>
9840
9841         PR symtab/24545
9842         * symtab.c (struct demangled_name_entry): Add language field.
9843         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
9844         static minimal symbol".  Set and use language field.
9845
9846 2019-06-10  Tom Tromey  <tromey@adacore.com>
9847
9848         * ada-lang.c (_initialize_ada_language): Update help text.
9849
9850 2019-06-10  Tom Tromey  <tromey@adacore.com>
9851
9852         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
9853         with a newline.
9854         * guile/guile.c (handle_boot_error): Don't end warning with a
9855         newline.
9856         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
9857         warning with a newline.
9858         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
9859         newline.
9860         (s12z_frame_cache): Likewise.
9861         * dwarf-index-cache.c (index_cache::store): Don't end warning with
9862         a newline.
9863         * solib-svr4.c (disable_probes_interface): Don't end warning with
9864         a newline.
9865         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
9866         newline.
9867         * python/python.c (do_finish_initialization): Don't end warning
9868         with a newline.
9869
9870 2019-06-10  Tom Tromey  <tom@tromey.com>
9871
9872         * python/py-breakpoint.c (gdbpy_breakpoint_created)
9873         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
9874         gdbpy_enter.
9875
9876 2019-06-10  Tom Tromey  <tromey@adacore.com>
9877
9878         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
9879         data.
9880         (elf_new_init): Don't call stabsread_new_init.
9881         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
9882         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
9883         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
9884
9885 2019-06-10  Tom de Vries  <tdevries@suse.de>
9886
9887         PR symtab/16264
9888         PR symtab/24517
9889         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
9890
9891 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
9892
9893         * source.c (find_and_open_source): Also rewrite relative file
9894         names.
9895
9896 2019-04-26  Amos Bird  <amosbird@gmail.com>
9897
9898         * annotate.c (annotate_thread_exited): Add "thread-exited"
9899         annotation.
9900
9901 2019-06-06  Tom Tromey  <tromey@adacore.com>
9902
9903         * maint.h (class scoped_command_stats): Use
9904         DISABLE_COPY_AND_ASSIGN.
9905         <print_time>: New method.
9906         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
9907         print_time.
9908         (scoped_command_stats::print_time): New method.
9909
9910 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
9911
9912         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
9913         instructions of lengths 6 or 8 bytes.
9914
9915 2019-06-04  Pedro Alves  <palves@redhat.com>
9916
9917         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
9918
9919         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
9920         * breakpoint.c (condition_completer): Likewise.
9921         * cli/cli-dump.c (scan_expression): Likewise.
9922         * common/filestuff.c (mkdir_recursive): Likewise.
9923         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
9924         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
9925         (gdb_abspath): Likewise.
9926         * compile/compile-cplus-types.c
9927         (compile_cplus_instance::decl_name): Likewise.
9928         * completer.c (complete_explicit_location):
9929         (signal_completer, reg_or_group_completer_1): Likewise.
9930         * cp-support.c (cp_remove_params_if_any): Likewise.
9931         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
9932         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
9933         * infcmd.c (strip_bg_char): Likewise.
9934         * linespec.c (copy_token_string): Likewise.
9935         * mi/mi-main.c (output_cores): Likewise.
9936         * psymtab.c (psymtab_search_name):
9937         * symfile.c (test_set_ext_lang_command): Likewise.
9938         * target.c (target_fileio_read_stralloc): Likewise.
9939         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
9940         * value.c (complete_internalvar): Likewise.
9941
9942 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
9943
9944         Add objfile property to gdb.Type.
9945         * NEWS: Mention Python API addition.
9946         * python/py-type.c (typy_get_objfile): New method.
9947
9948 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9949
9950         * NEWS: Mention the new set|show style [title|highlight].
9951         Mention changes to "show style", "help" and "apropos".
9952
9953 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9954
9955         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
9956         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
9957         instead of print_help_for_command.
9958         (print_doc_of_command): New function.
9959         (help_list): Add 'apropos -v word' suggestion.
9960         (print_help_for_command): Style the command name using title style.
9961         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
9962         (_initialize_cli_cmds): Describe -v in apropos_command help.
9963
9964 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9965
9966         * cli/cli-style.h (cli_style_option): Add name in constructor,
9967         add m_name class member, add constructor with intensity,
9968         add name class function.
9969         (cli_style_option::add_setshow_commands): Remove name argument.
9970         (highlight_style, title_style): New styles.
9971         * cli/cli-style.c (do_show): New function that shows a style
9972         characteristic styling the style name with itself.
9973         (set_style_name): New function.
9974         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
9975         Update all callers according to the changes in cli/cli-style.h.
9976         * utils.h (fputs_highlighted): New function.
9977         * utils.c (fputs_highlighted): Likewise.
9978
9979 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9980
9981         * NEWS: Mention new pipe command and new convenience variables.
9982
9983 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9984
9985         * cli/cli-cmds.c (pipe_command): New function.
9986         (_initialize_cli_cmds): Call add_com for pipe_command.
9987         Define | as an alias for pipe.
9988         (exit_status_set_internal_vars): New function.
9989         (shell_escape): Call exit_status_set_internal_vars.
9990         cli/cli-decode.c (find_command_name_length): Recognize | as
9991         a single character command.
9992
9993 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9994
9995         * gdbcmd.h (execute_command_to_ui_file): New declaration.
9996         top.c (execute_command_to_ui_file): New function, mostly a copy
9997         of execute_command_to_string.
9998         (execute_command_to_string): Implement by calling
9999         execute_command_to_ui_file.
10000
10001 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10002
10003         * top.h (saved_command_line): Remove declaration.
10004         * top.c (previous_saved_command_line, previous_repeat_arguments):
10005         New variables.
10006         (saved_command_line): Make static, define together with other
10007         'repeat variables'.
10008         (dont_repeat): Clear repeat_arguments.
10009         (repeat_previous, get_saved_command_line, save_command_line):
10010         New functions.
10011         (gdb_init): Initialize saved_command_line
10012         and previous_saved_command_line.
10013         * main.c (captured_main_1): Remove saved_command_line initialization.
10014         * event-top.c (handle_line_of_input): Update to use
10015         the new 'repeat' related functions instead of direct access to
10016         saved_command_line.
10017         * command.h (repeat_previous, get_saved_command_line,
10018         save_command_line): New declarations.
10019         (dont_repeat): Add comment.
10020
10021 2019-05-30  Tom Tromey  <tromey@adacore.com>
10022
10023         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
10024         Fix comment.
10025         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
10026
10027 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
10028
10029         PR cli/24587
10030         * completer.c (complete): Initialize variable word.
10031
10032 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
10033
10034         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
10035         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
10036         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
10037         'body' is NULL to the outter 'if', protecting the '!is_define'
10038         situation as well.
10039
10040 2019-05-29  Tom Tromey  <tromey@adacore.com>
10041
10042         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
10043         (dwarf_unknown): New function.
10044         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
10045         (dwarf_type_encoding_name): Use dwarf_unknown.
10046
10047 2019-05-29  Tom Tromey  <tromey@adacore.com>
10048
10049         PR c++/20020:
10050         * cp-valprint.c (cp_print_value_fields): Call
10051         cp_print_static_field inside "try".
10052
10053 2019-05-29  Tom Tromey  <tromey@adacore.com>
10054
10055         * inflow.c (struct terminal_info): Add default operator=.
10056         * configure: Rebuild.
10057         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
10058         -Wdeprecated-copy-dtor, -Wredundant-move.
10059
10060 2019-05-29  Tom Tromey  <tromey@adacore.com>
10061
10062         * NEWS: Add entry.
10063         * infcmd.c (print_return_value_1): Handle finish_print
10064         option.
10065         (show_print_finish): New function.
10066         (_initialize_infcmd): Add "set/show print finish" commands.
10067         * valprint.c (user_print_options): Initialize new member.
10068         * valprint.h (struct value_print_options) <finish_print>: New
10069         member.
10070
10071 2019-05-28  Tom Tromey  <tromey@adacore.com>
10072
10073         * ada-lang.c (ada_remove_Xbn_suffix)
10074         (find_old_style_renaming_symbol)
10075         (parse_old_style_renaming): Remove.
10076         (ada_find_renaming_symbol): Don't call
10077         find_old_style_renaming_symbol.
10078         (ada_is_renaming_symbol): Rename from
10079         ada_find_renaming_symbol.  Remove "block" parameter.  Return
10080         bool.  Now static.
10081         (ada_read_var_value): Update and simplify.
10082         * ada-exp.y (write_var_or_type): Remove old code.
10083
10084 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
10085
10086         PR gdb/25010
10087         * event-top.c: Remove include comment.
10088         * inflow.c (class scoped_ignore_sigttou): Move from here...
10089         * inflow.h (class scoped_ignore_sigttou): ...to here.
10090         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
10091         * top.c:  Remove include comment.
10092
10093 2019-05-27  Tom Tromey  <tom@tromey.com>
10094
10095         * NEWS: Fix typo.
10096
10097 2019-05-22  Tom Tromey  <tromey@adacore.com>
10098
10099         * target.c (target_follow_exec): Constify parameter.
10100         * target-delegates.c: Rebuild.
10101         * remote.c (remote_target::follow_exec): Constify parameter.
10102         * infrun.c (follow_exec): Constify parameter.
10103         * target.h (struct target_ops) <follow_exec>: Constify parameter.
10104         (target_follow_exec): Likewise.
10105
10106 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
10107
10108         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
10109         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
10110
10111 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
10112
10113         * NEWS: Add debugredirect and testsuite sections.
10114
10115 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
10116
10117         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
10118         target descriptions using exclusively floating point register name
10119         aliases.
10120
10121 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
10122
10123         PR gdb/18644:
10124         * f-lang.c (build_fortran_types): Handle the case where
10125         gdbarch_floatformat_for_type returns a nullptr.
10126
10127 2019-05-21  Tom de Vries  <tdevries@suse.de>
10128
10129         PR cli/24587
10130         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
10131
10132 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
10133
10134         PR gdb/18644:
10135         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
10136         16-byte floats.
10137         * i386-tdep.c (i386_floatformat_for_type): Use
10138         floatformats_ia64_quad for the 16-byte floating point component
10139         within a fortran 32-byte complex number.
10140
10141 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
10142
10143         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
10144         delete default constructor.
10145         (find_partial_die): Update to return const struct.
10146         (partial_die_parent_scope): Move variable declaration into scope
10147         of its use and change its type to auto.
10148         (guess_partial_die_structure_name): Likewise.
10149         (partial_die_info::fixup): Likewise.
10150
10151 2019-05-17  Tom Tromey  <tromey@adacore.com>
10152
10153         * source.c (find_and_open_source): Remove cast.
10154
10155 2019-05-17  Tom Tromey  <tromey@adacore.com>
10156
10157         * annotate.c (annotate_source): Make "filename" const.
10158         * annotate.h (annotate_source): Use const.
10159
10160 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
10161
10162         * disasm.c (set_disassembler_options): Send errors to stderr.
10163
10164 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
10165
10166         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
10167         (cli_interp_base::set_logging): Check debug_redirect.
10168         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
10169         * cli/cli-logging.c (debug_redirect): Add static variable.
10170         (pop_output_files): Add default param.
10171         (handle_redirections): Print debug setting.
10172         (show_logging_command): Likewise.
10173         (_initialize_cli_logging): Add debugredirect command.
10174         * interps.c (current_interp_set_logging): Add debug_redirect
10175         parameter.
10176         * interps.h (set_logging): Add debug_redirect parameter.
10177         (current_interp_set_logging): Likewise.
10178         * mi/mi-common.h: Likewise.
10179         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
10180
10181 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
10182             Tom Tromey  <tromey@adacore.com>
10183
10184         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
10185         directly.
10186         * cli/cli-interp.h (make_logging_output): Remove declaration.
10187         * cli/cli-logging.c (make_logging_output): Remove function.
10188         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
10189         directly.
10190         * ui-file.c (tee_file::tee_file): Remove bools.
10191         (tee_file::~tee_file): Remove deletes.
10192         * ui-file.h (tee_file): Remove bools.
10193
10194 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
10195
10196         * mi/mi-cmds.h (mi_cmd_complete): New function.
10197         * mi/mi-main.c (mi_cmd_complete): Likewise.
10198         * mi/mi-cmds.c: Define new MI command -complete.
10199         * NEWS: Mention new -complete command.
10200
10201 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
10202
10203         * completer.h (complete): New function.
10204         * completer.c (complete): Likewise.
10205         * cli/cli-cmds.c: (complete_command): Update to use new complete()
10206         function defined in completer.h.
10207
10208 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
10209
10210         * MAINTAINERS (Write After Approval): Add myself.
10211
10212 2019-05-17  Tom de Vries  <tdevries@suse.de>
10213
10214         PR gdb/24094
10215         * dwarf2read.c (struct cu_partial_die_info): New struct.
10216         (find_partial_die): Return cu_partial_die_info.
10217         (partial_die_parent_scope, guess_partial_die_structure_name)
10218         (partial_die_info::fixup): Handle new return type of find_partial_die.
10219
10220 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
10221
10222         PR breakpoints/24541
10223         * stap-probe.c (stap_parse_register_operand): Make "regname" an
10224         "std::string", simplifying the algorithm.
10225
10226 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
10227
10228         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
10229         (stap_static_probe_ops::get_probes): Likewise.
10230
10231 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
10232
10233         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
10234         '-')" and "else if".
10235         (stap_parse_single_operand): Join checks for
10236         "gdbarch_stap_parse_special_token_p" and
10237         "gdbarch_stap_parse_special_token" in the same "if" statement.
10238         Invert check when verifying for operation on register
10239         displacement.
10240
10241 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
10242
10243         * stap-probe.c (stap_get_opcode): Update comment.
10244         (stap_get_expected_argument_type): Likewise.
10245         (handle_stap_probe): Likewise.
10246
10247 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
10248
10249         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
10250         return type to 'bool'.  Adjust comment.  Use 'bool' when
10251         appropriate.
10252         (i386_stap_parse_special_token_three_arg_disp): Likewise.
10253         * stap-probe.c (stap_parse_argument_1): Likewise.
10254         (stap_is_operator): Likewise.
10255         (stap_is_generic_prefix): Likewise.
10256         (stap_is_register_prefix): Likewise.
10257         (stap_is_register_indirection_prefix): Likewise.
10258         (stap_is_integer_prefix): Likewise.
10259         (stap_generic_check_suffix): Likewise.
10260         (stap_check_integer_suffix): Likewise.
10261         (stap_check_register_suffix): Likewise.
10262         (stap_check_register_indirection_suffix): Likewise.
10263         (stap_parse_register_operand): Likewise.
10264         (stap_parse_single_operand): Likewise.
10265         (stap_parse_argument_1): Likewise.
10266         (stap_probe::get_argument_count): Likewise.
10267         (stap_is_operator): Likewise.
10268
10269 2019-05-16  Tom Tromey  <tromey@adacore.com>
10270
10271         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
10272         keyword to foreach.
10273
10274 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
10275
10276         * linux-thread-db.c (try_thread_db_load_1): Change return type
10277         to bool.
10278         (try_thread_db_load): Likewise.
10279         (try_thread_db_load_from_pdir_1): Likewise.
10280         (try_thread_db_load_from_pdir): Likewise.
10281         (try_thread_db_load_from_sdir): Likewise.
10282         (try_thread_db_load_from_dir): Likewise.
10283         (thread_db_load_search): Likewise.
10284         (has_libpthread): Likewise.
10285         (thread_db_load): Likewise.
10286
10287 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
10288
10289         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
10290         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
10291         NULL, and complain/return if that's the case.
10292
10293 2019-05-15  John Darrington <john@darrington.wattle.id.au>
10294
10295         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
10296         (advance, posn, abstract_read_memory): New functions.
10297         [struct mem_read_abstraction]: New struct.
10298         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
10299
10300 2019-05-14  Tom Tromey  <tromey@adacore.com>
10301
10302         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
10303         value is not lval_memory.
10304
10305 2019-05-14  Tom Tromey  <tromey@adacore.com>
10306
10307         * solib.c (info_sharedlibrary_command): Style the file name.
10308
10309 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
10310
10311         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
10312         (aarch64_vnv_type): Likewise.
10313         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
10314         * common/tdesc.c: Likewise.
10315         * common/tdesc.h (enum tdesc_type_kind): Likewise.
10316         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
10317         * features/aarch64-fpu.xml: Add ieee half view.
10318         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
10319         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
10320         * gdbtypes.h (struct builtin_type): Likewise.
10321         (struct objfile_type): Likewise.
10322
10323 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
10324
10325         * language.c (language_sniff_from_mangled_name): Fix "langauge"
10326         typo.
10327         * location.h (string_to_event_location): Likewise.
10328
10329 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
10330
10331         GDB 8.3 released.
10332
10333 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
10334
10335         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
10336         New variable declaration.
10337         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
10338         New variable.
10339         (print_one_breakpoint): Use ui_out::test_flags and new global
10340         variable to compute use_fixed_output.
10341         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
10342         Remove.
10343         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
10344         (mi_multi_location_breakpoint_output_fixed): Remove.
10345         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
10346         new variable.
10347         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
10348         fix_multi_location_breakpoint_output flag if version >= 3.
10349         * ui-out.h (enum ui_out_flag)
10350         <fix_multi_location_breakpoint_output>: New enumerator.
10351
10352 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
10353
10354         * contrib/cc-with-tweaks.sh: Validate dwz's work.
10355
10356 2019-05-10  Tom Tromey  <tromey@adacore.com>
10357
10358         * ada-lang.c (catch_ada_completer): New function.
10359         (_initialize_ada_language): Use it.
10360
10361 2019-05-10  Tom Tromey  <tromey@adacore.com>
10362
10363         * thread.c (print_thread_info): Make "requested_threads" const.
10364         * gdbthread.h (print_thread_info): Make "requested_threads"
10365         const.
10366         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
10367         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
10368
10369 2019-05-08  Tom Tromey  <tom@tromey.com>
10370
10371         * gdbtypes.c (objfile_type_data): Change type.
10372         (objfile_type, _initialize_gdbtypes): Update.
10373
10374 2019-05-08  Tom Tromey  <tom@tromey.com>
10375
10376         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
10377         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
10378         (_initialize_dwarf2_frame): Update.
10379
10380 2019-05-08  Tom Tromey  <tom@tromey.com>
10381
10382         * objc-lang.c (objc_objfile_data): Change type.
10383         (find_methods): Update.
10384         (_initialize_objc_lang): Remove.
10385
10386 2019-05-08  Tom Tromey  <tom@tromey.com>
10387
10388         * stabsread.c (rs6000_builtin_type_data): Change type.
10389         (rs6000_builtin_type, _initialize_stabsread): Update.
10390
10391 2019-05-08  Tom Tromey  <tom@tromey.com>
10392
10393         * mips-tdep.c (mips_pdr_data): Remove.
10394         (_initialize_mips_tdep): Update.
10395
10396 2019-05-08  Tom Tromey  <tom@tromey.com>
10397
10398         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
10399         (hppa_init_objfile_priv_data, read_unwind_info)
10400         (find_unwind_entry, _initialize_hppa_tdep): Update.
10401
10402 2019-05-08  Tom Tromey  <tom@tromey.com>
10403
10404         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
10405         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
10406         on obstack.
10407         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
10408
10409 2019-05-08  Tom Tromey  <tom@tromey.com>
10410
10411         * mdebugread.c (basic_type_data): Change type.
10412         (basic_type, _initialize_mdebugread): Update.
10413
10414 2019-05-08  Tom Tromey  <tom@tromey.com>
10415
10416         * common/gdb_unique_ptr.h (struct noop_deleter): New.
10417
10418 2019-05-08  Tom Tromey  <tom@tromey.com>
10419
10420         * nto-tdep.c (nto_inferior_data_reg): Change type.
10421         (nto_inferior_data): Update.
10422         (nto_inferior_data_cleanup, nto_new_inferior_data)
10423         (_initialize_nto_tdep): Remove.
10424         * nto-tdep.h (struct nto_inferior_data): Add initializers.
10425
10426 2019-05-08  Tom Tromey  <tom@tromey.com>
10427
10428         * ada-lang.c (struct ada_inferior_data): Add initializers.
10429         (ada_inferior_data): Change type.
10430         (ada_inferior_data_cleanup): Remove.
10431         (get_ada_inferior_data, ada_inferior_exit)
10432         (struct ada_pspace_data): Add initializers, destructor.
10433         (ada_pspace_data_handle): Change type.
10434         (get_ada_pspace_data): Update.
10435         (ada_pspace_data_cleanup): Remove.
10436
10437 2019-05-08  Tom Tromey  <tom@tromey.com>
10438
10439         * coffread.c (struct coff_symfile_info): Add initializers.
10440         (coff_objfile_data_key): Move lower.  Change type.
10441         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
10442         Update.
10443         (coff_free_info): Remove.
10444
10445 2019-05-08  Tom Tromey  <tom@tromey.com>
10446
10447         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
10448         (fbsd_pspace_data_handle): Move lower.  Change type.
10449         (get_fbsd_pspace_data): Update.
10450         (fbsd_pspace_data_cleanup): Remove.
10451         (_initialize_fbsd_tdep): Update.
10452
10453 2019-05-08  Tom Tromey  <tom@tromey.com>
10454
10455         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
10456         (get_ada_tasks_pspace_data): Update.
10457         (ada_tasks_pspace_data_cleanup): Remove.
10458         (_initialize_tasks): Update.
10459         (ada_tasks_inferior_data_handle): Change type.
10460         (get_ada_tasks_inferior_data): Update.
10461         (ada_tasks_inferior_data_cleanup): Remove.
10462         (struct ada_tasks_pspace_data): Add initializers.
10463
10464 2019-05-08  Tom Tromey  <tom@tromey.com>
10465
10466         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
10467         * symfile-debug.c (debug_sym_get_probes): Change type.
10468         * stap-probe.c (handle_stap_probe):
10469         (stap_static_probe_ops::get_probes): Change type.
10470         * probe.h (class static_probe_ops) <get_probes>: Change type.
10471         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
10472         (parse_probes_in_pspace): Update.
10473         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
10474         Update.
10475         (any_static_probe_ops::get_probes): Change type.
10476         * elfread.c (elfread_data): New typedef.
10477         (probe_key): Change type.
10478         (elf_get_probes): Likewise.  Update.
10479         (probe_key_free): Remove.
10480         (_initialize_elfread): Update.
10481         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
10482         Change type.
10483         (dtrace_process_dof_probe, dtrace_process_dof)
10484         (dtrace_static_probe_ops::get_probe): Change type.
10485
10486 2019-05-08  Tom Tromey  <tom@tromey.com>
10487
10488         * xcoffread.c (struct xcoff_symfile_info): Rename from
10489         coff_symfile_info.  Add initializers.
10490         (xcoff_objfile_data_key): Move lower.  Change type.
10491         (XCOFF_DATA): Rewrite.
10492         (xcoff_free_info): Remove.
10493         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
10494         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
10495         (xcoff_initial_scan): Update.
10496
10497 2019-05-08  Tom Tromey  <tom@tromey.com>
10498
10499         * solib-svr4.c (struct svr4_info): Add initializers and
10500         destructor.
10501         <probes_table>: Now an htab_up.
10502         (solib_svr4_pspace_data): Change type.
10503         (free_probes_table): Simplify.
10504         (~svr4_info): Rename from svr4_pspace_data_cleanup.
10505         (get_svr4_info, probes_table_htab_remove_objfile_probes)
10506         (probes_table_remove_objfile_probes, register_solib_event_probe)
10507         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
10508         (_initialize_svr4_solib): Update.
10509
10510 2019-05-08  Tom Tromey  <tom@tromey.com>
10511
10512         * remote.c (remote_pspace_data): Change type.
10513         (remote_pspace_data_cleanup): Remove.
10514         (get_remote_exec_file, set_pspace_remote_exec_file)
10515         (_initialize_remote): Update.
10516
10517 2019-05-08  Tom Tromey  <tom@tromey.com>
10518
10519         * breakpoint.c (breakpoint_objfile_key): Change type.
10520         (get_breakpoint_objfile_data): Update.
10521         (free_breakpoint_objfile_data): Remove.
10522         (_initialize_breakpoint): Update.
10523
10524 2019-05-08  Tom Tromey  <tom@tromey.com>
10525
10526         * linux-tdep.c (struct linux_info): Add initializers.
10527         (linux_inferior_data): Move.  Change type.
10528         (invalidate_linux_cache_inf): Update.
10529         (linux_inferior_data_cleanup): Remove.
10530         (get_linux_inferior_data, _initialize_linux_tdep): Update.
10531
10532 2019-05-08  Tom Tromey  <tom@tromey.com>
10533
10534         * auxv.c (auxv_inferior_data): Move.  Change type.
10535         (auxv_inferior_data_cleanup): Remove.
10536         (invalidate_auxv_cache_inf): Rewrite.
10537         (get_auxv_inferior_data, _initialize_auxv): Update.
10538
10539 2019-05-08  Tom Tromey  <tom@tromey.com>
10540
10541         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
10542         (symfile_debug_objfile_data_key): Change type.
10543         (symfile_debug_installed, debug_qf_has_symbols)
10544         (debug_qf_find_last_source_symtab)
10545         (debug_qf_forget_cached_source_info)
10546         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
10547         (debug_qf_print_stats, debug_qf_dump)
10548         (debug_qf_expand_symtabs_for_function)
10549         (debug_qf_expand_all_symtabs)
10550         (debug_qf_expand_symtabs_with_fullname)
10551         (debug_qf_map_matching_symbols)
10552         (debug_qf_expand_symtabs_matching)
10553         (debug_qf_find_pc_sect_compunit_symtab)
10554         (debug_qf_map_symbol_filenames)
10555         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
10556         (debug_sym_new_init, debug_sym_init, debug_sym_read)
10557         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
10558         (debug_sym_read_linetable, debug_sym_relocate): Update.
10559         (symfile_debug_free_objfile): Remove.
10560         (install_symfile_debug_logging, _initialize_symfile_debug):
10561         Update.
10562
10563 2019-05-08  Tom Tromey  <tom@tromey.com>
10564
10565         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
10566         allocate_on_obstack.
10567         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
10568         (get_dwarf2_per_objfile): Update.
10569         (set_dwarf2_per_objfile): Remove.
10570         (dwarf2_has_info, dwarf2_get_section_info): Update.
10571         (dwarf2_free_objfile): Remove.
10572         (_initialize_dwarf2_read): Update.
10573
10574 2019-05-08  Tom Tromey  <tom@tromey.com>
10575
10576         * auto-load.c (struct auto_load_pspace_info): Add destructor and
10577         initializers.
10578         <unsupported_script_warning_printed,
10579         script_not_found_warning_printed>: Now bool.
10580         (auto_load_pspace_data): Change type.
10581         (~auto_load_pspace_info): Rename from
10582         auto_load_pspace_data_cleanup.
10583         (get_auto_load_pspace_data, init_loaded_scripts_info)
10584         (clear_section_scripts, maybe_print_unsupported_script_warning)
10585         (maybe_print_script_not_found_warning, _initialize_auto_load):
10586         Update.
10587
10588 2019-05-08  Tom Tromey  <tom@tromey.com>
10589
10590         * objfiles.c (objfile_pspace_info): Add destructor and
10591         initializers.
10592         (objfiles_pspace_data): Change type.
10593         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
10594         (get_objfile_pspace_data): Update.
10595         (objfiles_bfd_data): Change type.
10596         (get_objfile_bfd_data): Update.
10597         (objfile_bfd_data_free, _initialize_objfiles): Remove.
10598
10599 2019-05-08  Tom Tromey  <tom@tromey.com>
10600
10601         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
10602         Change type.
10603         (get_catch_syscall_inferior_data): Update.
10604         (catch_syscall_inferior_data_cleanup): Remove.
10605         (_initialize_break_catch_syscall): Update.
10606
10607 2019-05-08  Tom Tromey  <tom@tromey.com>
10608
10609         * inflow.c (struct terminal_info): Add destructor and
10610         initializers.
10611         (inflow_inferior_data): Change type.
10612         (~terminal_info): Rename from inflow_inferior_data_cleanup.
10613         (get_inflow_inferior_data, inflow_inferior_exit)
10614         (swap_terminal_info, _initialize_inflow): Update.
10615
10616 2019-05-08  Tom Tromey  <tom@tromey.com>
10617
10618         * target-dcache.c (target_dcache_cleanup): Remove.
10619         (target_dcache_aspace_key): Change type.
10620         (target_dcache_init_p, target_dcache_invalidate)
10621         (target_dcache_get, target_dcache_get_or_init)
10622         (_initialize_target_dcache): Update.
10623         * dcache.h (struct dcache_deleter): New.
10624
10625 2019-05-08  Tom Tromey  <tom@tromey.com>
10626
10627         * symtab.c (struct symbol_cache): Add destructor and
10628         initializers.
10629         (symbol_cache_key): Move.  Change type.
10630         (make_symbol_cache, free_symbol_cache): Remove.
10631         (get_symbol_cache): Update.
10632         (symbol_cache_cleanup): Remove.
10633         (ALL_PSPACES, symbol_cache_flush)
10634         (maintenance_print_symbol_cache)
10635         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
10636         Update.
10637
10638 2019-05-08  Tom Tromey  <tom@tromey.com>
10639
10640         * symtab.c (struct main_info): Add destructor and initializers.
10641         (main_progspace_key): Move.  Change type.
10642         (get_main_info): Update.
10643         (main_info_cleanup): Remove.
10644         (_initialize_symtab): Update.
10645
10646 2019-05-08  Tom Tromey  <tom@tromey.com>
10647
10648         * registry.h (DECLARE_REGISTRY): Define the _key class.
10649
10650 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10651
10652         * NEWS: Merge two 'New commands' sections.
10653
10654 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
10655
10656         * ada-valprint.c (ada_val_print_gnat_array): Remove language
10657         parameter and use Ada language definition instead.
10658         (ada_val_print_ptr): Remove unused language parameter.
10659         (ada_val_print_num): Remove language parameter and use Ada language
10660         definition instead.
10661         (ada_val_print_enum, ada_val_print_flt): Remove unused language
10662         parameter.
10663         (ada_val_print_struct_union, ada_val_print_ref): Remove language
10664         parameter and use Ada language definition instead.
10665         (ada_val_print_1): Update all ada_val_print_xxx calls.
10666         Remove language parameter.
10667         (ada_val_print): Update ada_val_print_1 call.
10668
10669 2019-05-08  Tom Tromey  <tromey@adacore.com>
10670
10671         * remote.c (remote_hw_watchpoint_limit)
10672         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
10673         Now static.
10674
10675 2019-05-08  Tom Tromey  <tromey@adacore.com>
10676
10677         * maint.c (_initialize_maint_cmds): Move initialization code to
10678         remote.c.
10679         (watchdog, show_watchdog): Move to remote.c.
10680         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
10681         "watchdog" static.
10682         (_initialize_remote): Move initialization code from maint.c.
10683         * defs.h (watchdog): Don't declare.
10684
10685 2019-05-08  Tom Tromey  <tromey@adacore.com>
10686
10687         * tui/tui-interp.c: Include main.h.
10688         * interps.c: Include main.h.
10689         * main.h (interpreter_p): Declare.
10690         * defs.h (interpreter_p): Don't declare.
10691
10692 2019-05-08  Tom Tromey  <tromey@adacore.com>
10693
10694         * dwarf2loc.c: Include dwarf2read.h.
10695         * defs.h (read_unsigned_leb128): Don't declare.
10696         * dwarf2read.h (read_unsigned_leb128): Declare.
10697
10698 2019-05-08  Tom Tromey  <tromey@adacore.com>
10699
10700         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
10701         method.
10702
10703 2019-05-08  Tom Tromey  <tromey@adacore.com>
10704
10705         * utils.c (fputs_maybe_filtered): Reset style after paging, even
10706         when no wrap column is set.
10707
10708 2019-05-08  Tom Tromey  <tromey@adacore.com>
10709
10710         * c-lang.c (c_get_string): Handle non-C-style arrays.
10711
10712 2019-05-08  Tom Tromey  <tromey@adacore.com>
10713
10714         * typeprint.c (print_offset_data::update): Print the bit offset,
10715         not the number of bits remaining.
10716
10717 2019-05-08  Tom Tromey  <tromey@adacore.com>
10718
10719         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
10720         padding at end of comment.
10721
10722 2019-05-08  Tom Tromey  <tromey@adacore.com>
10723
10724         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
10725         Compare main types.
10726
10727 2019-05-06  Tom Tromey  <tom@tromey.com>
10728
10729         * common/scoped_mmap.c: Include common-defs.h.
10730         * common/scoped_mmap.h: Don't include config.h.
10731
10732 2019-05-04  Tom Tromey  <tom@tromey.com>
10733
10734         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
10735         (struct aarch64_call_info): Add initializers.
10736         <si>: Now a std::vector.
10737         (pass_on_stack, aarch64_push_dummy_call): Update.
10738
10739 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
10740             Tom Tromey  <tom@tromey.com>
10741
10742         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
10743         (ppc_threads): Now a std::vector.  Now static.
10744         (hwdebug_find_thread_points_by_tid)
10745         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
10746         Update.
10747
10748 2019-05-04  Tom Tromey  <tom@tromey.com>
10749
10750         * arc-tdep.c (arc_tdesc_init): Return bool.
10751
10752 2019-05-04  Tom Tromey  <tom@tromey.com>
10753
10754         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
10755         Use gdb_assert_not_reached.
10756
10757 2019-05-04  Tom Tromey  <tom@tromey.com>
10758
10759         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
10760         "false".
10761
10762 2019-05-04  Tom Tromey  <tom@tromey.com>
10763
10764         * arc-tdep.c (arc_tdesc_init): Use bool.
10765
10766 2019-05-04  Tom Tromey  <tom@tromey.com>
10767
10768         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
10769
10770 2019-05-04  Tom Tromey  <tom@tromey.com>
10771
10772         * cli/cli-cmds.c (valid_command_p): Return bool.
10773
10774 2019-05-04  Tom Tromey  <tom@tromey.com>
10775
10776         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
10777         * command.h (valid_user_defined_cmd_name_p): Channge return type.
10778
10779 2019-05-04  Raul Tambre  <raul@tambre.ee>
10780
10781         * python/lib/gdb/prompt.py (_ExtendedPrompt)
10782         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
10783         operator for comparison.
10784
10785 2019-05-04  Tom Tromey  <tom@tromey.com>
10786
10787         * psymtab.c (psymbol_name_matches, match_partial_symbol)
10788         (lookup_partial_symbol, print_partial_symbols)
10789         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
10790         (psymbol_compare): Update.
10791         (add_psymbol_to_bcache): Clear the entire psymbol.
10792         (maintenance_check_psymtabs): Update.
10793         * psympriv.h (struct partial_symbol): Don't derive from
10794         general_symbol_info.
10795         <obj_section, unrelocated_address, address,
10796         set_unrelocated_address>: Update.
10797         <ginfo>: New member.
10798         * dwarf-index-write.c (write_psymbols, debug_names::insert)
10799         (debug_names::write_psymbols): Update.
10800
10801 2019-05-04  Tom de Vries  <tdevries@suse.de>
10802
10803         * contrib/cc-with-tweaks.sh: Support -n arg.
10804
10805 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10806
10807         * corelow.c (core_target::detach): Ensure frame cache and
10808         register caches are cleared.
10809         inferior.c (exit_inferior_1): Likewise.
10810
10811 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
10812             Tom Tromey  <tom@tromey.com>
10813
10814         * dictionary.c (collate_pending_symbols_by_language): Remove
10815         "struct" from foreach.
10816         * symtab.c (lookup_global_symbol_from_objfile)
10817         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
10818         foreach.
10819         * ser-tcp.c (net_open): Remove "struct" from foreach.
10820         * objfiles.c (objfile_relocate, objfile_rebase)
10821         (objfile_has_symbols): Remove "struct" from foreach.
10822         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
10823         from foreach.
10824         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
10825         foreach.
10826         * darwin-nat.c (thread_info_from_private_thread_info): Remove
10827         "struct" from foreach.
10828         * ada-lang.c (create_excep_cond_exprs)
10829         (ada_exception_catchpoint_cond_string): Remove "struct" from
10830         foreach.
10831
10832 2019-05-03  Tom Tromey  <tromey@adacore.com>
10833
10834         * ada-exp.y (convert_char_literal): Check suffix of each
10835         enumerator.
10836
10837 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
10838
10839         PR ada/21406:
10840         * ada-exp.y (yywrap): Don't define.
10841         * ada-lex.l (%option): Add noyywrap
10842         (yywrap): Remove.
10843
10844 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
10845
10846         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
10847         _WIN32_WINNT to the XP level, unless already defined to a higher
10848         level.
10849
10850         * unittests/parse-connection-spec-selftests.c:
10851         * ser-tcp.c:
10852         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
10853         override.
10854
10855         * symfile.c (find_separate_debug_file): Remove colon from the
10856         drive spec of DOS/Windows file names of the target, so that the
10857         file name produced from DEBUGDIR and the target's directory will
10858         be valid on DOS/Windows systems.
10859
10860 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
10861
10862         * rust-lang.c (val_print_struct): Handle printing structures
10863         containing strings.
10864
10865 2019-05-02  Tom Tromey  <tromey@adacore.com>
10866
10867         * valarith.c (_initialize_valarith): Remove.
10868
10869 2019-05-01  Tom Tromey  <tromey@adacore.com>
10870
10871         * ada-lang.c (ada_value_primitive_field): Treat more fields as
10872         bitfields.
10873
10874 2019-05-01  Tom Tromey  <tromey@adacore.com>
10875
10876         * ada-lang.c (ada_value_assign): Correctly compute starting offset
10877         for big-endian copies.
10878
10879 2019-04-30  Ali Tamur  <tamur@google.com>
10880         * gdb/dwarf2read.c (read_3_bytes): New declaration.
10881         (read_attribute_value): Added DW_FORM_strx1-4 cases.
10882         (read_3_bytes): New function.
10883
10884 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
10885
10886         * windows-nat.c (main_thread_id): Delete.
10887         (handle_output_debug_string): Replace main_thread_id by
10888         current_event.dwThreadId.
10889         (fake_create_process): Likewise.
10890         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
10891         Do not set main_thread_id.
10892         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
10893         current_event.dwThreadId.
10894         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
10895
10896 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
10897
10898         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
10899         Use current_event.dwThreadId instead of main_thread_id.
10900
10901 2019-04-30  Tom Tromey  <tromey@adacore.com>
10902
10903         * ada-lang.c (ada_lookup_simple_minsyms): New function.
10904         (create_excep_cond_exprs): Iterate over program spaces.
10905         (ada_exception_catchpoint_cond_string): Examine all minimal
10906         symbols for exception types.
10907
10908 2019-04-30  Tom Tromey  <tromey@adacore.com>
10909
10910         PR c++/24470:
10911         * dwarf2read.c (process_structure_scope): Handle case where type
10912         has template parameters but no symbol was created.
10913
10914 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
10915             Chris January  <chris.january@arm.com>
10916
10917         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
10918         qualifier.
10919         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
10920
10921 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
10922
10923         * f-typeprint.c (f_print_type): Update rules for printing
10924         whitespace.
10925         (f_type_print_varspec_suffix): Likewise.
10926
10927 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
10928             Chris January  <chris.january@arm.com>
10929
10930         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
10931         function arguments.
10932
10933 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
10934
10935         * f-lang.c (build_fortran_types): Change name of void type to
10936         lower case.
10937         * f-typeprint.c (f_type_print_base): Print the name of the void
10938         type, rather than a fixed string.
10939         * f-valprint.c (f_decorations): Use lower case void string.
10940
10941 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
10942             Chris January  <chris.january@arm.com>
10943
10944         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
10945         types for Fortran.
10946
10947 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
10948             Chris January  <chris.january@arm.com>
10949             David Lecomber  <david.lecomber@arm.com>
10950
10951         * f-exp.y (BINOP_INTRINSIC): New token.
10952         (exp): New parser rule handling BINOP_INTRINSIC.
10953         (f77_keywords): Add new builtin procedures.
10954         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
10955         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
10956         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
10957         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
10958         (print_unop_subexp_f): New function.
10959         (print_binop_subexp_f): New function.
10960         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
10961         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
10962         (dump_subexp_body_f): Likewise.
10963         (operator_check_f): Likewise.
10964         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
10965         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
10966
10967 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
10968
10969         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
10970         UNOP_KIND.
10971         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
10972         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
10973         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
10974         (operator_length_f): New fuction.
10975         (print_subexp_f): New function.
10976         (op_name_f): New function.
10977         (dump_subexp_body_f): New function.
10978         (operator_check_f): New function.
10979         (exp_descriptor_f): Replace standard expression handling functions
10980         with new functions.
10981         * gdb/fortran-operator.def: New file.
10982         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
10983         * gdb/std-operator.def: Remove UNOP_KIND.
10984
10985 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
10986
10987         * std-operator.def: Remove unbalanced, stray double quote
10988         character.
10989
10990 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
10991             Chris January  <chris.january@arm.com>
10992             Daniel Everett  <daniel.everett@arm.com>
10993             Nick Forrington  <nick.forrington@arm.com>
10994             Richard Bunt  <richard.bunt@arm.com>
10995
10996         * cp-valprint.c (cp_print_value_fields): Allow an additional level
10997         of depth when printing anonymous structs or unions.
10998         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
10999         Don't print either the top-level value, or the children if the
11000         max-depth is exceeded.
11001         (ppscm_print_children): When printing the key of a map, allow one
11002         extra level of depth.
11003         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
11004         print either the top-level value, or the children if the max-depth
11005         is exceeded.
11006         (print_children): When printing the key of a map, allow one extra
11007         level of depth.
11008         * python/py-value.c (valpy_format_string): Add max_depth keyword.
11009         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
11010         (user_print_options): Initialise max_depth field.
11011         (val_print_scalar_or_string_type_p): New function.
11012         (val_print): Check to see if the max depth has been reached.
11013         (val_print_check_max_depth): Define new function.
11014         (show_print_max_depth): New function.
11015         (_initialize_valprint): Add 'print max-depth' option.
11016         * valprint.h (struct value_print_options) <max_depth>: New field.
11017         (val_print_check_max_depth): Declare new function.
11018         * NEWS: Document new feature.
11019
11020 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
11021
11022         * ada-lang.c (ada_language_defn): Initialise new field.
11023         * c-lang.c (c_is_string_type_p): New function.
11024         (c_language_defn): Initialise new field.
11025         (cplus_language_defn): Initialise new field.
11026         (asm_language_defn): Initialise new field.
11027         (minimal_language_defn): Initialise new field.
11028         * c-lang.h (c_is_string_type_p): Declare new function.
11029         * d-lang.c (d_language_defn): Initialise new field.
11030         * f-lang.c (f_is_string_type_p): New function.
11031         (f_language_defn): Initialise new field.
11032         * go-lang.c (go_is_string_type_p): New function.
11033         (go_language_defn): Initialise new field.
11034         * language.c (default_is_string_type_p): New function.
11035         (unknown_language_defn): Initialise new field.
11036         (auto_language_defn): Initialise new field.
11037         * language.h (struct language_defn) <la_is_string_type_p>: New
11038         member variable.
11039         (default_is_string_type_p): Declare new function.
11040         * m2-lang.c (m2_language_defn): Initialise new field.
11041         * objc-lang.c (objc_language_defn): Initialise new field.
11042         * opencl-lang.c (opencl_language_defn): Initialise new field.
11043         * p-lang.c (pascal_is_string_type_p): New function.
11044         (pascal_language_defn): Initialise new field.
11045         * rust-lang.c (rust_is_string_type_p): New function.
11046         (rust_language_defn): Initialise new field.
11047
11048 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
11049
11050         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
11051         New field.
11052         * ada-lang.c (ada_language_defn): Initialise new field.
11053         * c-lang.c (c_language_defn): Likewise.
11054         (cplus_language_defn): Likewise.
11055         (asm_language_defn): Likewise.
11056         (minimal_language_defn): Likewise.
11057         * d-lang.c (d_language_defn): Likewise.
11058         * f-lang.c (f_language_defn): Likewise.
11059         * go-lang.c (go_language_defn): Likewise.
11060         * language.c (unknown_language_defn): Likewise.
11061         (auto_language_defn): Likewise.
11062         * m2-lang.c (m2_language_defn): Likewise.
11063         * objc-lang.c (objc_language_defn): Likewise.
11064         * opencl-lang.c (opencl_language_defn): Likewise.
11065         * p-lang.c (pascal_language_defn): Likewise.
11066         * rust-lang.c (rust_language_defn): Likewise.
11067
11068 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
11069
11070         * ada-lang.c (ada_is_character_type): Change return type to bool.
11071         (ada_is_string_type): Likewise.
11072         * ada-lang.h (ada_is_character_type): Update declaration
11073         (ada_is_string_type): Likewise.
11074
11075 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11076
11077         Support style in 'frame|thread apply'
11078
11079         * gdbcmd.h (execute_command_to_string): New term_out parameter.
11080         * record.c (record_start, record_stop): Update callers of
11081         execute_command_to_string with false.
11082         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
11083         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
11084         methods.
11085         (class string_file): New constructor with term_out parameter.
11086         Override methods term_out and can_emit_style_escape.  New member
11087         term_out.
11088         (class stdio_file): Override can_emit_style_escape.
11089         (class tee_file): Override term_out and can_emit_style_escape.
11090         * utils.h (can_emit_style_escape): Remove.
11091         * utils.c (can_emit_style_escape): Likewise.
11092         Update all callers of can_emit_style_escape (SOMESTREAM) to
11093         SOMESTREAM->can_emit_style_escape.
11094         * source-cache.c (source_cache::get_source_lines): Likewise.
11095         * stack.c (frame_apply_command_count): Call execute_command_to_string
11096         passing the term_out characteristic of the current gdb_stdout.
11097         * thread.c (thr_try_catch_cmd): Likewise.
11098         * top.c (execute_command_to_string): pass term_out parameter
11099         to construct the string_file for the command output.
11100         * ui-file.c (term_cli_styling): New function (most code moved
11101         from utils.c can_emit_style_escape).
11102         (string_file::string_file, string_file::can_emit_style_escape,
11103         stdio_file::can_emit_style_escape, tee_file::term_out,
11104         tee_file::can_emit_style_escape): New functions.
11105
11106 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11107
11108         * NEWS: Mention the new set|show may-call-functions.
11109         * infcall.c (may_call_functions_p): New variable.
11110         (show_may_call_functions_p): New function.
11111         (call_function_by_hand_dummy): Throws an error if not
11112         may-call-functions.
11113         (_initialize_infcall): Call add_setshow_boolean_cmd for
11114         may-call-functions.
11115
11116 2019-04-25  Keith Seitz  <keiths@redhat.com>
11117
11118         PR c++/24367
11119         * cp-support.c (inspect_type): Don't attempt substitutions
11120         of symbol with the same name.
11121
11122 2019-04-25  Tom Tromey  <tromey@adacore.com>
11123
11124         PR gdb/24475:
11125         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
11126         static.
11127
11128 2019-04-25  Tom Tromey  <tromey@adacore.com>
11129
11130         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
11131         rvalue reference.
11132         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
11133         (gdb_xml_parser::parse): Use std::move.
11134         * python/python-internal.h (gdbpy_convert_exception): Take a const
11135         reference.
11136         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
11137         std::move.
11138         * python/py-utils.c (gdbpy_convert_exception): Take a const
11139         reference.
11140         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
11141         Use std::move.
11142         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
11143         Use std::move.
11144         * mi/mi-main.c (mi_print_exception): Take a const reference.
11145         * main.c (handle_command_errors): Take a const reference.
11146         * linespec.c (parse_linespec): Use std::move.
11147         * infcall.c (run_inferior_call): Use std::move.
11148         (call_function_by_hand_dummy): Use std::move.
11149         * exec.c (try_open_exec_file): Use std::move.
11150         * exceptions.h (exception_print, exception_fprintf)
11151         (exception_print_same): Update.
11152         * exceptions.c (print_exception, exception_print)
11153         (exception_fprintf, exception_print_same): Change parameters to
11154         const reference.
11155         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
11156         * common/new-op.c: Use std::move.
11157         * common/common-exceptions.h (struct gdb_exception): Add move
11158         constructor.
11159         (struct gdb_exception_error, struct gdb_exception_quit, struct
11160         gdb_quit_bad_alloc): Change constructor to move constructor.
11161         (throw_exception): Change parameter to rvalue reference.
11162         * common/common-exceptions.c (throw_exception): Take rvalue
11163         reference.
11164         * cli/cli-interp.c (safe_execute_command): Use std::move.
11165         * breakpoint.c (insert_bp_location, location_to_sals): Use
11166         std::move.
11167
11168 2019-04-25  Tom Tromey  <tromey@adacore.com>
11169
11170         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
11171         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
11172         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
11173         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
11174         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
11175         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
11176         guile/scm-value.c: Use unpack.
11177         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
11178         gdbscm_gdb_exception.
11179         (gdbscm_throw_gdb_exception): Likewise.
11180         (struct gdbscm_gdb_exception): New.
11181         (unpack): New function.
11182         (gdbscm_wrap): Use unpack.
11183
11184 2019-04-25  Tom Tromey  <tromey@adacore.com>
11185
11186         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
11187         (gdb_rl_callback_handler): Use std::move.
11188         * common/common-exceptions.h (struct gdb_exception): Add move
11189         assignment operator.
11190         (throw_exception_sjlj): Change "exception" to const reference.
11191         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
11192         (throw_exception_sjlj): Change "exception" to const reference.
11193
11194 2019-04-25  Tom Tromey  <tromey@adacore.com>
11195
11196         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
11197         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
11198         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
11199         Update.
11200         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
11201         Update.
11202         * mi/mi-interp.c (mi_interp::exec): Update.
11203         * linespec.c (parse_linespec): Update.
11204         * infcall.c (run_inferior_call): Update.
11205         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
11206         * guile/scm-symbol.c (gdbscm_lookup_symbol)
11207         (gdbscm_lookup_global_symbol): Update.
11208         * guile/scm-param.c (gdbscm_parameter_value): Update.
11209         * guile/scm-frame.c (gdbscm_frame_read_register)
11210         (gdbscm_frame_read_var): Update.
11211         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
11212         * exec.c (try_open_exec_file): Update.
11213         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
11214         (gdb_rl_callback_handler): Update.
11215         * common/common-exceptions.h (exception_none): Don't declare.
11216         * common/common-exceptions.c (exception_none): Don't define.
11217         (struct catcher) <exception>: Update.
11218         * cli/cli-interp.c (safe_execute_command): Update.
11219         * breakpoint.c (insert_bp_location, location_to_sals): Update.
11220
11221 2019-04-25  Ali Tamur  <tamur@google.com>
11222
11223         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
11224         (read_attribute_value): Likewise.
11225         (dwarf2_read_addr_index): Update comment.
11226         (read_str_index): Add DW_FORM_strx.
11227         (dwarf2_string_attr): Likewise.
11228         (dwarf2_const_value_attr): Likewise.
11229         (dump_die_shallow): Likewise.
11230         (dwarf2_fetch_constant_bytes): Likewise.
11231         (skip_form_bytes): Likewise.
11232         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
11233
11234 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
11235
11236         PR corefiles/11608
11237         PR corefiles/18187
11238         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
11239         OFFSET.  Verify if current mapping contains an ELF header.
11240         (linux_find_memory_regions_full): Adjust call to
11241         dump_mapping_p.
11242
11243 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
11244             Kang Li <kanglictf@gmail.com>
11245
11246         PR gdb/21600
11247
11248         * dwarf2-frame.c (read_initial_length): Be consistent about using
11249         unsigned representation of length.
11250         (decode_frame_entry_1): Likewise.  Check for wraparound of
11251         end pointer as well as buffer overflow.
11252
11253 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
11254
11255         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
11256         "vq".
11257
11258 2019-04-24  Tom Tromey  <tromey@adacore.com>
11259
11260         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
11261
11262 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11263
11264         * s12z-tdep.c (s12z_unwind_pc): Delete.
11265         (s12z_unwind_sp): Delete.
11266         (s12z_gdbarch_init): Don't register deleted functions with
11267         gdbarch.
11268
11269 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11270
11271         * rl78-tdep.c (rl78_unwind_sp): Delete.
11272         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
11273
11274 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11275
11276         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
11277         (xstormy16_unwind_pc): Delete.
11278         (xstormy16_dummy_id): Delete.
11279         (xstormy16_gdbarch_init): Don't register deleted functions with
11280         gdbarch.
11281
11282 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11283
11284         * vax-tdep.c (vax_unwind_pc): Delete.
11285         (vax_gdbarch_init): Don't register deleted function with gdbarch.
11286
11287 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11288
11289         * v850-tdep.c (v850_unwind_sp): Delete.
11290         (v850_unwind_pc): Delete.
11291         (v850_dummy_id): Delete.
11292         (v850_gdbarch_init): Don't register deleted functions with
11293         gdbarch.
11294
11295 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11296
11297         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
11298         (tilegx_unwind_pc): Delete.
11299         (tilegx_unwind_dummy_id): Delete.
11300         (tilegx_gdbarch_init): Don't register deleted functions with
11301         gdbarch.
11302
11303 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11304
11305         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
11306         (tic6x_dummy_id): Delete.
11307         (tic6x_gdbarch_init): Don't register deleted functions with
11308         gdbarch.
11309
11310 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11311
11312         * sparc-tdep.c (sparc_unwind_pc): Delete.
11313         (sparc32_gdbarch_init): Don't register deleted function with
11314         gdbarch.
11315
11316 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11317
11318         * sh-tdep.c (sh_unwind_sp): Delete.
11319         (sh_unwind_pc): Delete.
11320         (sh_dummy_id): Delete.
11321         (sh_gdbarch_init): Don't register deleted functions with
11322         gdbarch.
11323
11324 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11325
11326         * score-tdep.c (score_unwind_sp): Delete.
11327         (score_unwind_pc): Delete.
11328         (score_dummy_id): Delete.
11329         (score_gdbarch_init): Don't register deleted functions with
11330         gdbarch.
11331
11332 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11333
11334         * rx-tdep.c (rx_unwind_pc): Delete.
11335         (rx_unwind_sp): Delete.
11336         (rx_dummy_id): Delete.
11337         (rx_gdbarch_init): Don't register deleted functions with
11338         gdbarch.  Update comment.
11339
11340 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11341
11342         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
11343         (rs6000_dummy_id): Delete.
11344         (rs6000_gdbarch_init): Don't register deleted functions with
11345         gdbarch.
11346
11347 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11348
11349         * or1k-tdep.c (or1k_dummy_id): Delete.
11350         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
11351
11352 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11353
11354         * nios2-tdep.c (nios2_dummy_id): Delete.
11355         (nios2_unwind_sp): Delete.
11356         (nios2_gdbarch_init): Don't register deleted functions with
11357         gdbarch.
11358
11359 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11360
11361         * nds32-tdep.c (nds32_dummy_id): Delete.
11362         (nds32_unwind_pc): Delete.
11363         (nds32_unwind_sp): Delete.
11364         (nds32_gdbarch_init): Don't register deleted functions with
11365         gdbarch.
11366
11367 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11368
11369         * msp430-tdep.c (msp430_unwind_pc): Delete.
11370         (msp430_unwind_sp): Delete.
11371         (msp430_dummy_id): Delete.
11372         (msp430_gdbarch_init): Don't register deleted functions with
11373         gdbarch.
11374
11375 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11376
11377         * moxie-tdep.c (moxie_unwind_sp): Delete.
11378         (moxie_unwind_pc): Delete.
11379         (moxie_dummy_id): Delete.
11380         (moxie_gdbarch_init): Don't register deleted functions with
11381         gdbarch.
11382
11383 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11384
11385         * mn10300-tdep.c (mn10300_dummy_id): Delete.
11386         (mn10300_unwind_pc): Delete.
11387         (mn10300_unwind_sp): Delete.
11388         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
11389         mn10300_unwind_sp.
11390         (mn10300_frame_unwind_init): Don't register deleted functions with
11391         gdbarch.
11392
11393 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11394
11395         * mep-tdep.c (mep_unwind_pc): Delete.
11396         (mep_unwind_sp): Delete.
11397         (mep_dummy_id): Delete.
11398         (mep_gdbarch_init): Don't register deleted functions with
11399         gdbarch.
11400
11401 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11402
11403         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
11404         (m68hc11_unwind_sp): Delete.
11405         (m68hc11_gdbarch_init): Don't register deleted functions with
11406         gdbarch.
11407
11408 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11409
11410         * m32r-tdep.c (m32r_unwind_sp): Delete.
11411         (m32r_unwind_pc): Delete.
11412         (m32r_dummy_id): Delete.
11413         (m32r_gdbarch_init): Don't register deleted functions with
11414         gdbarch.
11415
11416 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11417
11418         * m32c-tdep.c (m32c_unwind_pc): Delete.
11419         (m32c_unwind_sp): Delete.
11420         (m32c_dummy_id): Delete.
11421         (m32c_gdbarch_init): Don't register deleted functions with
11422         gdbarch.
11423
11424 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11425
11426         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
11427         (lm32_unwind_pc): Delete.
11428         (lm32_dummy_id): Delete.
11429         (lm32_gdbarch_init): Don't register deleted functions with
11430         gdbarch.
11431
11432 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11433
11434         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
11435         (iq2000_unwind_pc): Delete.
11436         (iq2000_dummy_id): Delete.
11437         (iq2000_gdbarch_init): Don't register deleted functions with
11438         gdbarch.
11439
11440 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11441
11442         * nds32-tdep.c (nds32_type_align): Delete.
11443         (nds32_push_dummy_call): Use type_align instead.
11444
11445 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11446
11447         * arm-tdep.c (arm_type_align): Only handle vector override case.
11448         (arm_push_dummy_call): Use type_align.
11449         (arm_gdbarch_init): Register arm_type_align gdbarch function.
11450
11451 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11452
11453         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
11454         case.
11455         (pass_on_stack): Use type_align.
11456         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
11457         function.
11458
11459 2019-04-23  Tom Tromey  <tromey@adacore.com>
11460
11461         * dwarf2read.c (line_header::file_name_at): Remove unused
11462         overload.
11463
11464 2019-04-23  Tom de Vries  <tdevries@suse.de>
11465
11466         PR gdb/24438
11467         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
11468         invocation.
11469
11470
11471 2019-03-27  Ali Tamur  <tamur@google.com>
11472
11473         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
11474         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
11475         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
11476         (dwarf_expr_context::get_addr_index): Likewise
11477         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
11478         (symbol_needs_eval_context::get_addr_index): Likewise
11479         (disassemble_dwarf_expression): Add DW_OP_addrx
11480         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
11481         (read_cutu_die_from_dwo): Update comment
11482         (skip_one_die): Add DW_FORM_addrx
11483         (read_attribute_value): Likewise
11484         (var_decode_location): Add DW_OP_addrx
11485         (dwarf2_const_value_attr): Add DW_FORM_addrx
11486         (dump_die_shallow): Likewise
11487         (dwarf2_fetch_constant_bytes): Likewise
11488         (decode_locdesc): Add DW_OP_addrx
11489         (skip_form_bytes): Add DW_FORM_addrx
11490
11491 2019-04-22  Ali Tamur  <tamur@google.com>
11492
11493         * MAINTAINERS (Write After Approval): Add self.
11494
11495 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
11496
11497         * solib-svr4.c (get_svr4_info): Add pspace parameter.
11498         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
11499         (open_symbol_file_object): Likewise.
11500         (svr4_default_sos): Add info parameter.
11501         (svr4_read_so_list): Likewise.
11502         (svr4_current_sos_direct): Adjust functions calls to pass down
11503         info.
11504         (svr4_current_sos_1): Add info parameter.
11505         (svr4_current_sos): Call get_svr4_info, pass info down to
11506         svr4_current_sos_1.
11507         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
11508         get_svr4_info.
11509         (svr4_in_dynsym_resolve_code): Pass current_program_space to
11510         get_svr4_info.
11511         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
11512         to get_svr4_info.
11513         (probes_table_remove_objfile_probes): Likewise.
11514         (register_solib_event_probe): Add info parameter.
11515         (solist_update_incremental): Pass info parameter down to
11516         svr4_read_so_list.
11517         (disable_probes_interface): Add info parameter.
11518         (svr4_handle_solib_event): Pass current_program_space to
11519         get_svr4_info.  Adjust disable_probes_interface cleanup.
11520         (svr4_create_probe_breakpoints): Add info parameter, pass it
11521         down to register_solib_event_probe.
11522         (svr4_create_solib_event_breakpoints): Add info parameter,
11523         pass it down to svr4_create_probe_breakpoints.
11524         (enable_break): Pass info down to
11525         svr4_create_solib_event_breakpoints.
11526         (svr4_solib_create_inferior_hook): Pass current_program_space to
11527         get_svr4_info.
11528         (svr4_clear_solib): Likewise.
11529
11530 2019-04-22  Pedro Alves  <palves@redhat.com>
11531
11532         * solib-svr4.c (svr4_free_objfile_observer): New.
11533         (probe_and_action::objfile): New field.
11534         (probes_table_htab_remove_objfile_probes)
11535         (probes_table_remove_objfile_probes): New functions.
11536         (register_solib_event_probe): Add 'objfile' parameter.  Store it
11537         in the new probe_and_action.  Don't store the probe in 'lookup'.
11538         (svr4_create_probe_breakpoints): Pass objfile to
11539         register_solib_event_probe.
11540         (_initialize_svr4_solib): Register a free_objfile observer.
11541
11542 2019-04-19  Tom Tromey  <tom@tromey.com>
11543
11544         * common/queue.h: Remove.
11545
11546 2019-04-19  Tom Tromey  <tom@tromey.com>
11547
11548         * event-loop.c: Don't include "common/queue.h".
11549
11550 2019-04-19  Tom Tromey  <tom@tromey.com>
11551
11552         * remote.c (remote_target): Use delete.
11553         * remote-notif.h: Include <list>, not "common/queue.h".
11554         (notif_client_p): Remove typedef.
11555         (remote_notif_state): Add constructor, destructor, initializer.
11556         <notif_queue>: Now a std::list.
11557         (remote_notif_state_xfree): Don't declare.
11558         * remote-notif.c (remote_notif_process, handle_notification)
11559         (remote_notif_state_allocate): Update.
11560         (~remote_notif_state): Rename from remote_notif_state_xfree.
11561
11562 2019-04-19  Tom Tromey  <tom@tromey.com>
11563
11564         * symfile.c (reread_symbols): Update.
11565         * objfiles.c (objfile_register_static_link)
11566         (objfile_lookup_static_link): Update
11567         (~objfile) Don't delete static_links.
11568         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
11569
11570 2019-04-19  Tom Tromey  <tom@tromey.com>
11571
11572         * type-stack.h (struct type_stack) <insert>: Constify string.
11573         * type-stack.c (type_stack::insert): Constify string.
11574         * gdbtypes.h (lookup_template_type): Update.
11575         (address_space_name_to_int): Update.
11576         * gdbtypes.c (address_space_name_to_int): Make space_identifier
11577         const.
11578         (lookup_template_type): Make name const.
11579         * c-exp.y: Update rules.
11580         (lex_one_token, classify_name, classify_inner_name)
11581         (c_print_token): Update.
11582         * p-exp.y: Update rules.
11583         (yylex): Update.
11584         * f-exp.y: Update rules.
11585         (yylex): Update.
11586         * d-exp.y: Update rules.
11587         (lex_one_token, classify_name, classify_inner_name): Update.
11588         * parse.c (write_dollar_variable, copy_name): Return std::string.
11589         * parser-defs.h (copy_name): Change return type.
11590         * m2-exp.y: Update rules.
11591         (yylex): Update.
11592         * go-exp.y (lex_one_token): Update.
11593         Update rules.
11594         (classify_unsafe_function, classify_packaged_name)
11595         (classify_name, yylex): Update.
11596
11597 2019-04-19  Sergei Trofimovich <siarheit@google.com>
11598
11599         * configure.ac: add --enable-source-highlight switch.
11600         * configure: Regenerate.
11601         * top.c (print_gdb_version): plumb --enable-source-highlight
11602         status to "show configuration".
11603
11604 2019-04-19  Tom Tromey  <tromey@adacore.com>
11605
11606         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
11607         Check ADA_TYPE_P.
11608         (empty_record, ada_template_to_fixed_record_type_1)
11609         (template_to_static_fixed_type)
11610         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
11611         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
11612         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
11613         macros.
11614
11615 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
11616
11617         PR symtab/24423:
11618         * source.c (print_source_lines_base): Advance "iter" when a
11619         control character is seen.
11620
11621 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11622
11623         * inferior.h (struct infcall_suspend_state_deleter):
11624         Catch exception in destructor to avoid crash.
11625
11626 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11627
11628         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
11629         close to the add_com "shell".
11630
11631 2019-04-18  Tom Tromey  <tromey@adacore.com>
11632
11633         * process-stratum-target.h (class process_stratum_target)
11634         <stratum>: Add "final".
11635
11636 2019-04-17  Tom Tromey  <tromey@adacore.com>
11637
11638         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
11639         against nullptr before use.
11640
11641 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
11642
11643         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
11644
11645 2019-04-17  Jim Wilson  <jimw@sifive.com>
11646             Andrew Burgess  <andrew.burgess@embecosm.com>
11647
11648         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
11649         code read might fail, assume 4-byte breakpoint in that case.
11650
11651 2019-04-15  Leszek Swirski  <leszeks@google.com>
11652
11653         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
11654         rather than a hand-rolled POD check when checking for forced MEMORY
11655         classification.
11656
11657 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
11658
11659         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
11660         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
11661         function.
11662         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
11663         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
11664         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
11665         declaration.
11666
11667 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
11668
11669         * aarch64-linux-nat.c
11670         (aarch64_linux_nat_target::thread_architecture): Add override.
11671         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
11672         each VQ.
11673
11674 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
11675
11676         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
11677
11678 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
11679
11680         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
11681         target types of size 96-bits, add some additional comments, and
11682         check that the builtin type we found was the correct size.
11683
11684 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
11685
11686         * utils.c (prompt_for_continue): Don't restore the styling at the
11687         end, as applied_style has the wrong value.  This fixes styling in
11688         long lists of file names that are interrupted by the "Continue?"
11689         prompt.
11690
11691 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
11692
11693         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
11694         * c-lang.c (c_language_defn): Likewise.
11695         (cplus_language_defn): Likewise.
11696         (asm_language_defn): Likewise.
11697         (minimal_language_defn): Likewise.
11698         * d-lang.c (d_language_defn): Likewise.
11699         * f-lang.c (f_language_defn): Likewise.
11700         * go-lang.c (go_language_defn): Likewise.
11701         * language.c (unknown_language_defn): Likewise.
11702         (auto_language_defn): Likewise.
11703         * language.h (struct language_defn): Remove la_magic field.
11704         (LANG_MAGIC): Delete.
11705         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
11706         * objc-lang.c (objc_language_defn): Likewise.
11707         * opencl-lang.c (opencl_language_defn): Likewise.
11708         * p-lang.c (pascal_language_defn): Likewise.
11709         * rust-lang.c (rust_language_defn): Likewise.
11710
11711 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
11712
11713         * riscv-tdep.c (riscv_type_align): New function.
11714         (riscv_type_alignment): Delete.
11715         (riscv_arg_location): Use 'type_align'.
11716         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
11717
11718 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
11719
11720         * gdbtypes.c (type_align): A struct with no non-static fields also
11721         has alignment of 1.
11722
11723 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
11724
11725         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
11726         component to 0.
11727         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
11728         member.
11729         (riscv_struct_info::analyse): New implementation using new
11730         analyse_inner member function.
11731         (riscv_struct_info::field_offset): New member function.
11732         (riscv_struct_info::m_offsets): New member variable.
11733         (riscv_struct_info::analyse_inner): New private member function,
11734         takes the old implementation of riscv_struct_info::analyse but
11735         extended to track field offsets.
11736         (riscv_call_arg_struct): Update the struct folding special cases
11737         to handle cases where empty C++ structs, which are non-zero
11738         length, are found.
11739         (riscv_arg_location): Initialise the length of each location, a
11740         non-zero length now indicates the location is in use.
11741         (riscv_push_dummy_call): Allow for the first location having a
11742         non-zero offset when setting up arguments.
11743         (riscv_return_value): Likewise, but for return values.
11744
11745 2019-04-11  Tom Tromey  <tromey@adacore.com>
11746
11747         * utils.c (internal_vproblem): Make "msg" const.
11748
11749 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
11750
11751         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
11752         * trad-frame.c (trad_frame_reset_saved_regs): New function.
11753         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
11754         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
11755
11756 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
11757
11758         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
11759         function.
11760         (fill_gregset): Call amd64_linux_collect_native_gregset instead
11761         of amd64_collect_native_gregset.
11762         (amd64_linux_nat_target::store_registers): Likewise.
11763
11764 2019-04-10  Tom Tromey  <tom@tromey.com>
11765
11766         * symtab.c (lookup_global_symbol_from_objfile)
11767         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
11768         * objfiles.h (class separate_debug_iterator): New.
11769         (class separate_debug_range): New.
11770         (struct objfile) <separate_debug_objfiles>: New method.
11771         (objfile_separate_debug_iterate): Don't declare.
11772         * objfiles.c (separate_debug_iterator::operator++): Rename from
11773         objfile_separate_debug_iterate.
11774         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
11775         iterator.
11776         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
11777         iterator.
11778
11779 2019-04-10  Tom Tromey  <tom@tromey.com>
11780
11781         * symfile.c (reread_symbols): Remove old comment.
11782         * objfiles.c (free_all_objfiles): Fix a typo.
11783
11784 2019-04-10  Tom Tromey  <tom@tromey.com>
11785
11786         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
11787         * minsyms.c (lookup_minimal_symbol): Use foreach.
11788         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
11789         (lookup_minimal_symbol_solib_trampoline): Likewise.
11790         * symfile.c (reread_symbols): Use foreach.
11791
11792 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
11793             Tom Tromey  <tromey@adacore.com>
11794
11795         PR rust/24414:
11796         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
11797         (rust_lex_int_test): Change "value" to be LONGEST.
11798         (rust_lex_tests): Add test for long integer literal.
11799
11800 2019-04-09  Tom Tromey  <tromey@adacore.com>
11801
11802         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
11803         to bool.
11804         (extended_remote_target::attach): Update.
11805         (remote_target::remote_notice_new_inferior): Update.
11806         (remote_target::add_current_inferior_and_thread): Update.
11807         * inferior.c (exit_inferior_1): Use "false".
11808         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
11809
11810 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
11811
11812         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
11813         the "start" command.
11814
11815 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
11816
11817         * python/py-inferior.c (infpy_thread_from_thread_handle):
11818         Adjust comments to reflect renaming of thread_from_thread_handle
11819         to thread_from_handle.  Adjust keywords.  Fix type error message.
11820         (inferior_object_methods): Add thread_from_handle.  Retain
11821         thread_from_thread_handle, but mark it as deprecated.
11822
11823 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
11824
11825         * gdbthread.h (find_thread_by_handle): Revise declaration.
11826         * thread.c (find_thread_by_handle): Likewise.  Adjust
11827         implementation too.
11828         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
11829         support for buffer objects as handles.
11830
11831 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
11832
11833         * python/py-infthread.c (thpy_thread_handle): New function.
11834         (thread_object_methods): Register thpy_thread_handle.
11835
11836 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
11837
11838         * gdbthread.h (thread_to_thread_handle): Declare.
11839         * thread.c (gdbtypes.h): Include.
11840         (thread_to_thread_handle): New function.
11841
11842         * target.h (struct target_ops): Add thread_info_to_thread_handle.
11843         (target_thread_info_to_thread_handle): Declare.
11844         * target.c (target_thread_info_to_thread_handle): New function.
11845         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
11846         * target-delegates.c: Regenerate.
11847
11848         * linux-thread-db.c (class thread_db_target): Add method
11849         thread_info_to_thread_handle.
11850         (thread_db_target::thread_info_to_thread_handle): Define.
11851         * remote.c (class remote_target): Add new method
11852         thread_info_to_thread_handle.
11853         (remote_target::thread_info_to_thread_handle): Define.
11854
11855 2019-04-08  Pedro Alves  <palves@redhat.com>
11856
11857         * common/common-exceptions.c (throw_exception): Don't create
11858         named object to throw; throw directly.
11859         (throw_it): Likewise.  Don't initialize gdb_exception::message
11860         here, with new; pass FMT and AP to the ctor instead.
11861         * common/common-exceptions.h: Include <string>.
11862         (gdb_exception::gdb_exception(enum return_reason, enum errors,
11863         const char *, va_list)): New ctor.  Use std::make_shared.
11864         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
11865         errors)): Delete.
11866         (gdb_exception_error::gdb_exception_error(enum errors, const char
11867         *, va_list)): New.
11868         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
11869         Add assertion.
11870         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
11871         errors)): Delete.
11872         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
11873         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
11874         Add assertion.
11875
11876 2019-04-08  Tom Tromey  <tom@tromey.com>
11877
11878         * valops.c (value_rtti_indirect_type): Replace throw_exception
11879         with throw.
11880         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
11881         with throw.
11882         * thread.c (thr_try_catch_cmd): Replace throw_exception with
11883         throw.
11884         * target.c (target_translate_tls_address): Replace throw_exception
11885         with throw.
11886         * stack.c (frame_apply_command_count): Replace throw_exception
11887         with throw.
11888         * solib-spu.c (append_ocl_sos): Replace throw_exception with
11889         throw.
11890         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
11891         with throw.
11892         * rs6000-tdep.c (rs6000_frame_cache)
11893         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
11894         * remote.c: Replace throw_exception with throw.
11895         * record-full.c (record_full_message, record_full_wait_1)
11896         (record_full_restore): Replace throw_exception with throw.
11897         * record-btrace.c:
11898         (get_thread_current_frame_id, record_btrace_start_replaying)
11899         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
11900         (cmd_record_btrace_start): Replace throw_exception with throw.
11901         * parse.c (parse_exp_in_context_1): Replace throw_exception with
11902         throw.
11903         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
11904         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
11905         * linespec.c:
11906         (find_linespec_symbols): Replace throw_exception with throw.
11907         * infrun.c (displaced_step_prepare, resume): Replace
11908         throw_exception with throw.
11909         * infcmd.c (post_create_inferior): Replace throw_exception with
11910         throw.
11911         * inf-loop.c (inferior_event_handler): Replace throw_exception
11912         with throw.
11913         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
11914         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
11915         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
11916         (get_prev_frame_always, get_frame_pc_if_available)
11917         (get_frame_address_in_block_if_available, get_frame_language):
11918         Replace throw_exception with throw.
11919         * frame-unwind.c (frame_unwind_try_unwinder): Replace
11920         throw_exception with throw.
11921         * eval.c (fetch_subexp_value, evaluate_var_value)
11922         (evaluate_funcall, evaluate_subexp_standard): Replace
11923         throw_exception with throw.
11924         * dwarf2loc.c (call_site_find_chain)
11925         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
11926         Replace throw_exception with throw.
11927         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
11928         with throw.
11929         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
11930         throw.
11931         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
11932         * completer.c (complete_line_internal): Replace throw_exception
11933         with throw.
11934         * compile/compile-object-run.c (compile_object_run): Replace
11935         throw_exception with throw.
11936         * cli/cli-script.c (process_next_line): Replace throw_exception
11937         with throw.
11938         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
11939         (btrace_enable, btrace_maint_update_pt_packets): Replace
11940         throw_exception with throw.
11941         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
11942         throw_exception with throw.
11943         * break-catch-throw.c (re_set_exception_catchpoint): Replace
11944         throw_exception with throw.
11945         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
11946         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
11947         * aarch64-tdep.c (aarch64_make_prologue_cache)
11948         (aarch64_make_stub_cache): Replace throw_exception with throw.
11949
11950 2019-04-08  Tom Tromey  <tom@tromey.com>
11951
11952         * common/common-exceptions.c (throw_exception): Rename from
11953         throw_exception_cxx.  Remove old copy.  Make argument const.
11954         (throw_it): Create and throw exception objects directly.
11955         * common/common-exceptions.h (throw_exception): Make argument
11956         const.
11957         (struct gdb_exception_error): Add constructor.
11958         (struct gdb_exception_quit): Add constructor.
11959
11960 2019-04-08  Tom Tromey  <tom@tromey.com>
11961
11962         * common/common-exceptions.h (exception_rethrow): Don't declare.
11963         (TRY_SJLJ): Update comment.
11964         (TRY, CATCH, END_CATCH): Remove.
11965         * common/common-exceptions.c (exception_rethrow): Remove.
11966
11967 2019-04-08  Tom Tromey  <tom@tromey.com>
11968
11969         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
11970         Remove.
11971         (gdb_exception_error): Rename from
11972         gdb_exception_RETURN_MASK_ERROR.
11973         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
11974         (gdb_quit_bad_alloc): Update.
11975         * aarch64-tdep.c: Update.
11976         * ada-lang.c: Update.
11977         * ada-typeprint.c: Update.
11978         * ada-valprint.c: Update.
11979         * amd64-tdep.c: Update.
11980         * arch-utils.c: Update.
11981         * break-catch-throw.c: Update.
11982         * breakpoint.c: Update.
11983         * btrace.c: Update.
11984         * c-varobj.c: Update.
11985         * cli/cli-cmds.c: Update.
11986         * cli/cli-interp.c: Update.
11987         * cli/cli-script.c: Update.
11988         * common/common-exceptions.c: Update.
11989         * common/new-op.c: Update.
11990         * common/selftest.c: Update.
11991         * compile/compile-c-symbols.c: Update.
11992         * compile/compile-cplus-symbols.c: Update.
11993         * compile/compile-object-load.c: Update.
11994         * compile/compile-object-run.c: Update.
11995         * completer.c: Update.
11996         * corelow.c: Update.
11997         * cp-abi.c: Update.
11998         * cp-support.c: Update.
11999         * cp-valprint.c: Update.
12000         * darwin-nat.c: Update.
12001         * disasm-selftests.c: Update.
12002         * dtrace-probe.c: Update.
12003         * dwarf-index-cache.c: Update.
12004         * dwarf-index-write.c: Update.
12005         * dwarf2-frame-tailcall.c: Update.
12006         * dwarf2-frame.c: Update.
12007         * dwarf2loc.c: Update.
12008         * dwarf2read.c: Update.
12009         * eval.c: Update.
12010         * event-loop.c: Update.
12011         * event-top.c: Update.
12012         * exec.c: Update.
12013         * f-valprint.c: Update.
12014         * fbsd-tdep.c: Update.
12015         * frame-unwind.c: Update.
12016         * frame.c: Update.
12017         * gdbtypes.c: Update.
12018         * gnu-v3-abi.c: Update.
12019         * guile/guile-internal.h: Update.
12020         * guile/scm-block.c: Update.
12021         * guile/scm-breakpoint.c: Update.
12022         * guile/scm-cmd.c: Update.
12023         * guile/scm-disasm.c: Update.
12024         * guile/scm-frame.c: Update.
12025         * guile/scm-lazy-string.c: Update.
12026         * guile/scm-math.c: Update.
12027         * guile/scm-param.c: Update.
12028         * guile/scm-ports.c: Update.
12029         * guile/scm-pretty-print.c: Update.
12030         * guile/scm-symbol.c: Update.
12031         * guile/scm-symtab.c: Update.
12032         * guile/scm-type.c: Update.
12033         * guile/scm-value.c: Update.
12034         * i386-linux-tdep.c: Update.
12035         * i386-tdep.c: Update.
12036         * inf-loop.c: Update.
12037         * infcall.c: Update.
12038         * infcmd.c: Update.
12039         * infrun.c: Update.
12040         * jit.c: Update.
12041         * language.c: Update.
12042         * linespec.c: Update.
12043         * linux-fork.c: Update.
12044         * linux-nat.c: Update.
12045         * linux-tdep.c: Update.
12046         * linux-thread-db.c: Update.
12047         * main.c: Update.
12048         * mi/mi-cmd-break.c: Update.
12049         * mi/mi-cmd-stack.c: Update.
12050         * mi/mi-interp.c: Update.
12051         * mi/mi-main.c: Update.
12052         * objc-lang.c: Update.
12053         * p-valprint.c: Update.
12054         * parse.c: Update.
12055         * ppc-linux-tdep.c: Update.
12056         * printcmd.c: Update.
12057         * python/py-arch.c: Update.
12058         * python/py-breakpoint.c: Update.
12059         * python/py-cmd.c: Update.
12060         * python/py-finishbreakpoint.c: Update.
12061         * python/py-frame.c: Update.
12062         * python/py-framefilter.c: Update.
12063         * python/py-gdb-readline.c: Update.
12064         * python/py-inferior.c: Update.
12065         * python/py-infthread.c: Update.
12066         * python/py-lazy-string.c: Update.
12067         * python/py-linetable.c: Update.
12068         * python/py-objfile.c: Update.
12069         * python/py-param.c: Update.
12070         * python/py-prettyprint.c: Update.
12071         * python/py-progspace.c: Update.
12072         * python/py-record-btrace.c: Update.
12073         * python/py-record.c: Update.
12074         * python/py-symbol.c: Update.
12075         * python/py-type.c: Update.
12076         * python/py-unwind.c: Update.
12077         * python/py-utils.c: Update.
12078         * python/py-value.c: Update.
12079         * python/python.c: Update.
12080         * record-btrace.c: Update.
12081         * record-full.c: Update.
12082         * remote-fileio.c: Update.
12083         * remote.c: Update.
12084         * riscv-tdep.c: Update.
12085         * rs6000-aix-tdep.c: Update.
12086         * rs6000-tdep.c: Update.
12087         * rust-exp.y: Update.
12088         * rust-lang.c: Update.
12089         * s390-tdep.c: Update.
12090         * selftest-arch.c: Update.
12091         * solib-dsbt.c: Update.
12092         * solib-frv.c: Update.
12093         * solib-spu.c: Update.
12094         * solib-svr4.c: Update.
12095         * solib.c: Update.
12096         * sparc64-linux-tdep.c: Update.
12097         * stack.c: Update.
12098         * symfile-mem.c: Update.
12099         * symmisc.c: Update.
12100         * target.c: Update.
12101         * thread.c: Update.
12102         * top.c: Update.
12103         * tracefile-tfile.c: Update.
12104         * tui/tui.c: Update.
12105         * typeprint.c: Update.
12106         * unittests/cli-utils-selftests.c: Update.
12107         * unittests/parse-connection-spec-selftests.c: Update.
12108         * valops.c: Update.
12109         * valprint.c: Update.
12110         * value.c: Update.
12111         * varobj.c: Update.
12112         * windows-nat.c: Update.
12113         * x86-linux-nat.c: Update.
12114         * xml-support.c: Update.
12115
12116 2019-04-08  Tom Tromey  <tom@tromey.com>
12117
12118         * xml-support.c: Use C++ exception handling.
12119         * x86-linux-nat.c: Use C++ exception handling.
12120         * windows-nat.c: Use C++ exception handling.
12121         * varobj.c: Use C++ exception handling.
12122         * value.c: Use C++ exception handling.
12123         * valprint.c: Use C++ exception handling.
12124         * valops.c: Use C++ exception handling.
12125         * unittests/parse-connection-spec-selftests.c: Use C++ exception
12126         handling.
12127         * unittests/cli-utils-selftests.c: Use C++ exception handling.
12128         * typeprint.c: Use C++ exception handling.
12129         * tui/tui.c: Use C++ exception handling.
12130         * tracefile-tfile.c: Use C++ exception handling.
12131         * top.c: Use C++ exception handling.
12132         * thread.c: Use C++ exception handling.
12133         * target.c: Use C++ exception handling.
12134         * symmisc.c: Use C++ exception handling.
12135         * symfile-mem.c: Use C++ exception handling.
12136         * stack.c: Use C++ exception handling.
12137         * sparc64-linux-tdep.c: Use C++ exception handling.
12138         * solib.c: Use C++ exception handling.
12139         * solib-svr4.c: Use C++ exception handling.
12140         * solib-spu.c: Use C++ exception handling.
12141         * solib-frv.c: Use C++ exception handling.
12142         * solib-dsbt.c: Use C++ exception handling.
12143         * selftest-arch.c: Use C++ exception handling.
12144         * s390-tdep.c: Use C++ exception handling.
12145         * rust-lang.c: Use C++ exception handling.
12146         * rust-exp.y: Use C++ exception handling.
12147         * rs6000-tdep.c: Use C++ exception handling.
12148         * rs6000-aix-tdep.c: Use C++ exception handling.
12149         * riscv-tdep.c: Use C++ exception handling.
12150         * remote.c: Use C++ exception handling.
12151         * remote-fileio.c: Use C++ exception handling.
12152         * record-full.c: Use C++ exception handling.
12153         * record-btrace.c: Use C++ exception handling.
12154         * python/python.c: Use C++ exception handling.
12155         * python/py-value.c: Use C++ exception handling.
12156         * python/py-utils.c: Use C++ exception handling.
12157         * python/py-unwind.c: Use C++ exception handling.
12158         * python/py-type.c: Use C++ exception handling.
12159         * python/py-symbol.c: Use C++ exception handling.
12160         * python/py-record.c: Use C++ exception handling.
12161         * python/py-record-btrace.c: Use C++ exception handling.
12162         * python/py-progspace.c: Use C++ exception handling.
12163         * python/py-prettyprint.c: Use C++ exception handling.
12164         * python/py-param.c: Use C++ exception handling.
12165         * python/py-objfile.c: Use C++ exception handling.
12166         * python/py-linetable.c: Use C++ exception handling.
12167         * python/py-lazy-string.c: Use C++ exception handling.
12168         * python/py-infthread.c: Use C++ exception handling.
12169         * python/py-inferior.c: Use C++ exception handling.
12170         * python/py-gdb-readline.c: Use C++ exception handling.
12171         * python/py-framefilter.c: Use C++ exception handling.
12172         * python/py-frame.c: Use C++ exception handling.
12173         * python/py-finishbreakpoint.c: Use C++ exception handling.
12174         * python/py-cmd.c: Use C++ exception handling.
12175         * python/py-breakpoint.c: Use C++ exception handling.
12176         * python/py-arch.c: Use C++ exception handling.
12177         * printcmd.c: Use C++ exception handling.
12178         * ppc-linux-tdep.c: Use C++ exception handling.
12179         * parse.c: Use C++ exception handling.
12180         * p-valprint.c: Use C++ exception handling.
12181         * objc-lang.c: Use C++ exception handling.
12182         * mi/mi-main.c: Use C++ exception handling.
12183         * mi/mi-interp.c: Use C++ exception handling.
12184         * mi/mi-cmd-stack.c: Use C++ exception handling.
12185         * mi/mi-cmd-break.c: Use C++ exception handling.
12186         * main.c: Use C++ exception handling.
12187         * linux-thread-db.c: Use C++ exception handling.
12188         * linux-tdep.c: Use C++ exception handling.
12189         * linux-nat.c: Use C++ exception handling.
12190         * linux-fork.c: Use C++ exception handling.
12191         * linespec.c: Use C++ exception handling.
12192         * language.c: Use C++ exception handling.
12193         * jit.c: Use C++ exception handling.
12194         * infrun.c: Use C++ exception handling.
12195         * infcmd.c: Use C++ exception handling.
12196         * infcall.c: Use C++ exception handling.
12197         * inf-loop.c: Use C++ exception handling.
12198         * i386-tdep.c: Use C++ exception handling.
12199         * i386-linux-tdep.c: Use C++ exception handling.
12200         * guile/scm-value.c: Use C++ exception handling.
12201         * guile/scm-type.c: Use C++ exception handling.
12202         * guile/scm-symtab.c: Use C++ exception handling.
12203         * guile/scm-symbol.c: Use C++ exception handling.
12204         * guile/scm-pretty-print.c: Use C++ exception handling.
12205         * guile/scm-ports.c: Use C++ exception handling.
12206         * guile/scm-param.c: Use C++ exception handling.
12207         * guile/scm-math.c: Use C++ exception handling.
12208         * guile/scm-lazy-string.c: Use C++ exception handling.
12209         * guile/scm-frame.c: Use C++ exception handling.
12210         * guile/scm-disasm.c: Use C++ exception handling.
12211         * guile/scm-cmd.c: Use C++ exception handling.
12212         * guile/scm-breakpoint.c: Use C++ exception handling.
12213         * guile/scm-block.c: Use C++ exception handling.
12214         * guile/guile-internal.h: Use C++ exception handling.
12215         * gnu-v3-abi.c: Use C++ exception handling.
12216         * gdbtypes.c: Use C++ exception handling.
12217         * frame.c: Use C++ exception handling.
12218         * frame-unwind.c: Use C++ exception handling.
12219         * fbsd-tdep.c: Use C++ exception handling.
12220         * f-valprint.c: Use C++ exception handling.
12221         * exec.c: Use C++ exception handling.
12222         * event-top.c: Use C++ exception handling.
12223         * event-loop.c: Use C++ exception handling.
12224         * eval.c: Use C++ exception handling.
12225         * dwarf2read.c: Use C++ exception handling.
12226         * dwarf2loc.c: Use C++ exception handling.
12227         * dwarf2-frame.c: Use C++ exception handling.
12228         * dwarf2-frame-tailcall.c: Use C++ exception handling.
12229         * dwarf-index-write.c: Use C++ exception handling.
12230         * dwarf-index-cache.c: Use C++ exception handling.
12231         * dtrace-probe.c: Use C++ exception handling.
12232         * disasm-selftests.c: Use C++ exception handling.
12233         * darwin-nat.c: Use C++ exception handling.
12234         * cp-valprint.c: Use C++ exception handling.
12235         * cp-support.c: Use C++ exception handling.
12236         * cp-abi.c: Use C++ exception handling.
12237         * corelow.c: Use C++ exception handling.
12238         * completer.c: Use C++ exception handling.
12239         * compile/compile-object-run.c: Use C++ exception handling.
12240         * compile/compile-object-load.c: Use C++ exception handling.
12241         * compile/compile-cplus-symbols.c: Use C++ exception handling.
12242         * compile/compile-c-symbols.c: Use C++ exception handling.
12243         * common/selftest.c: Use C++ exception handling.
12244         * common/new-op.c: Use C++ exception handling.
12245         * cli/cli-script.c: Use C++ exception handling.
12246         * cli/cli-interp.c: Use C++ exception handling.
12247         * cli/cli-cmds.c: Use C++ exception handling.
12248         * c-varobj.c: Use C++ exception handling.
12249         * btrace.c: Use C++ exception handling.
12250         * breakpoint.c: Use C++ exception handling.
12251         * break-catch-throw.c: Use C++ exception handling.
12252         * arch-utils.c: Use C++ exception handling.
12253         * amd64-tdep.c: Use C++ exception handling.
12254         * ada-valprint.c: Use C++ exception handling.
12255         * ada-typeprint.c: Use C++ exception handling.
12256         * ada-lang.c: Use C++ exception handling.
12257         * aarch64-tdep.c: Use C++ exception handling.
12258
12259 2019-04-08  Tom Tromey  <tom@tromey.com>
12260
12261         * xml-support.c (gdb_xml_parser::parse): Update.
12262         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
12263         * value.c (show_convenience): Update.
12264         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
12265         (test_parse_flags_qcs): Update.
12266         * thread.c (thr_try_catch_cmd): Update.
12267         * target.c (target_translate_tls_address): Update.
12268         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
12269         (info_frame_command_core, frame_apply_command_count): Update.
12270         * rust-exp.y (rust_lex_exception_test): Update.
12271         * riscv-tdep.c (riscv_print_one_register_info): Update.
12272         * remote.c (remote_target::enable_btrace): Update.
12273         * record-btrace.c (record_btrace_enable_warn): Update.
12274         * python/py-utils.c (gdbpy_convert_exception): Update.
12275         * printcmd.c (do_one_display, print_variable_and_value): Update.
12276         * mi/mi-main.c (mi_print_exception): Update.
12277         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
12278         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
12279         * linux-nat.c (linux_nat_target::attach): Update.
12280         * linux-fork.c (class scoped_switch_fork_info): Update.
12281         * infrun.c (displaced_step_prepare): Update.
12282         * infcall.c (call_function_by_hand_dummy): Update.
12283         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
12284         * gnu-v3-abi.c (print_one_vtable): Update.
12285         * frame.c (get_prev_frame_always): Update.
12286         * f-valprint.c (info_common_command_for_block): Update.
12287         * exec.c (try_open_exec_file): Update.
12288         * exceptions.c (print_exception, exception_print)
12289         (exception_fprintf, exception_print_same): Update.
12290         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
12291         * dwarf-index-cache.c (index_cache::store)
12292         (index_cache::lookup_gdb_index): Update.
12293         * darwin-nat.c (maybe_cache_shell): Update.
12294         * cp-valprint.c (cp_print_value_fields): Update.
12295         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
12296         (gcc_cplus_symbol_address): Update.
12297         * compile/compile-c-symbols.c (gcc_convert_symbol)
12298         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
12299         * common/selftest.c: Update.
12300         * common/common-exceptions.h (struct gdb_exception) <message>: Now
12301         a std::string.
12302         (exception_try_scope_entry, exception_try_scope_exit): Don't
12303         declare.
12304         (struct exception_try_scope): Remove.
12305         (TRY): Don't use exception_try_scope.
12306         (struct gdb_exception): Add constructor, operator=.
12307         <what>: New method.
12308         (struct gdb_exception_RETURN_MASK_ALL)
12309         (struct gdb_exception_RETURN_MASK_ERROR)
12310         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
12311         (struct gdb_quit_bad_alloc): Update.
12312         * common/common-exceptions.c (exception_none): Change
12313         initializer.
12314         (struct catcher) <state, exception>: Initialize inline.
12315         <prev>: Remove member.
12316         (current_catcher): Remove.
12317         (catchers): New global.
12318         (exceptions_state_mc_init): Simplify.
12319         (catcher_pop): Remove.
12320         (exceptions_state_mc, exceptions_state_mc_catch): Update.
12321         (try_scope_depth, exception_try_scope_entry)
12322         (exception_try_scope_exit): Remove.
12323         (throw_exception_sjlj): Update.
12324         (exception_messages, exception_messages_size): Remove.
12325         (throw_it): Simplify.
12326         (gdb_exception_sliced_copy): Remove.
12327         (throw_exception_cxx): Update.
12328         * cli/cli-script.c (script_from_file): Update.
12329         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
12330         Update.
12331         * ada-valprint.c (ada_val_print): Update.
12332         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
12333         (create_excep_cond_exprs): Update.
12334
12335 2019-04-08  Tom Tromey  <tom@tromey.com>
12336
12337         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
12338         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
12339         (TRY, CATCH, END_CATCH): Remove some definitions.
12340         * common/common-exceptions.c: Don't use GDB_XCPT.
12341         (catcher_list_size): Remove.
12342         (throw_exception, throw_it): Simplify.
12343
12344 2019-04-05  Tom Tromey  <tom@tromey.com>
12345
12346         Revert the header-sorting patch.
12347         * ft32-tdep.c: Revert.
12348         * frv-tdep.c: Revert.
12349         * frv-linux-tdep.c: Revert.
12350         * frame.c: Revert.
12351         * frame-unwind.c: Revert.
12352         * frame-base.c: Revert.
12353         * fork-child.c: Revert.
12354         * findvar.c: Revert.
12355         * findcmd.c: Revert.
12356         * filesystem.c: Revert.
12357         * filename-seen-cache.h: Revert.
12358         * filename-seen-cache.c: Revert.
12359         * fbsd-tdep.c: Revert.
12360         * fbsd-nat.h: Revert.
12361         * fbsd-nat.c: Revert.
12362         * f-valprint.c: Revert.
12363         * f-typeprint.c: Revert.
12364         * f-lang.c: Revert.
12365         * extension.h: Revert.
12366         * extension.c: Revert.
12367         * extension-priv.h: Revert.
12368         * expprint.c: Revert.
12369         * exec.h: Revert.
12370         * exec.c: Revert.
12371         * exceptions.c: Revert.
12372         * event-top.c: Revert.
12373         * event-loop.c: Revert.
12374         * eval.c: Revert.
12375         * elfread.c: Revert.
12376         * dwarf2read.h: Revert.
12377         * dwarf2read.c: Revert.
12378         * dwarf2loc.c: Revert.
12379         * dwarf2expr.h: Revert.
12380         * dwarf2expr.c: Revert.
12381         * dwarf2-frame.c: Revert.
12382         * dwarf2-frame-tailcall.c: Revert.
12383         * dwarf-index-write.h: Revert.
12384         * dwarf-index-write.c: Revert.
12385         * dwarf-index-common.c: Revert.
12386         * dwarf-index-cache.h: Revert.
12387         * dwarf-index-cache.c: Revert.
12388         * dummy-frame.c: Revert.
12389         * dtrace-probe.c: Revert.
12390         * disasm.h: Revert.
12391         * disasm.c: Revert.
12392         * disasm-selftests.c: Revert.
12393         * dictionary.c: Revert.
12394         * dicos-tdep.c: Revert.
12395         * demangle.c: Revert.
12396         * dcache.h: Revert.
12397         * dcache.c: Revert.
12398         * darwin-nat.h: Revert.
12399         * darwin-nat.c: Revert.
12400         * darwin-nat-info.c: Revert.
12401         * d-valprint.c: Revert.
12402         * d-namespace.c: Revert.
12403         * d-lang.c: Revert.
12404         * ctf.c: Revert.
12405         * csky-tdep.c: Revert.
12406         * csky-linux-tdep.c: Revert.
12407         * cris-tdep.c: Revert.
12408         * cris-linux-tdep.c: Revert.
12409         * cp-valprint.c: Revert.
12410         * cp-support.c: Revert.
12411         * cp-namespace.c: Revert.
12412         * cp-abi.c: Revert.
12413         * corelow.c: Revert.
12414         * corefile.c: Revert.
12415         * continuations.c: Revert.
12416         * completer.h: Revert.
12417         * completer.c: Revert.
12418         * complaints.c: Revert.
12419         * coffread.c: Revert.
12420         * coff-pe-read.c: Revert.
12421         * cli-out.h: Revert.
12422         * cli-out.c: Revert.
12423         * charset.c: Revert.
12424         * c-varobj.c: Revert.
12425         * c-valprint.c: Revert.
12426         * c-typeprint.c: Revert.
12427         * c-lang.c: Revert.
12428         * buildsym.c: Revert.
12429         * buildsym-legacy.c: Revert.
12430         * build-id.h: Revert.
12431         * build-id.c: Revert.
12432         * btrace.c: Revert.
12433         * bsd-uthread.c: Revert.
12434         * breakpoint.h: Revert.
12435         * breakpoint.c: Revert.
12436         * break-catch-throw.c: Revert.
12437         * break-catch-syscall.c: Revert.
12438         * break-catch-sig.c: Revert.
12439         * blockframe.c: Revert.
12440         * block.c: Revert.
12441         * bfin-tdep.c: Revert.
12442         * bfin-linux-tdep.c: Revert.
12443         * bfd-target.c: Revert.
12444         * bcache.c: Revert.
12445         * ax-general.c: Revert.
12446         * ax-gdb.h: Revert.
12447         * ax-gdb.c: Revert.
12448         * avr-tdep.c: Revert.
12449         * auxv.c: Revert.
12450         * auto-load.c: Revert.
12451         * arm-wince-tdep.c: Revert.
12452         * arm-tdep.c: Revert.
12453         * arm-symbian-tdep.c: Revert.
12454         * arm-pikeos-tdep.c: Revert.
12455         * arm-obsd-tdep.c: Revert.
12456         * arm-nbsd-tdep.c: Revert.
12457         * arm-nbsd-nat.c: Revert.
12458         * arm-linux-tdep.c: Revert.
12459         * arm-linux-nat.c: Revert.
12460         * arm-fbsd-tdep.c: Revert.
12461         * arm-fbsd-nat.c: Revert.
12462         * arm-bsd-tdep.c: Revert.
12463         * arch-utils.c: Revert.
12464         * arc-tdep.c: Revert.
12465         * arc-newlib-tdep.c: Revert.
12466         * annotate.h: Revert.
12467         * annotate.c: Revert.
12468         * amd64-windows-tdep.c: Revert.
12469         * amd64-windows-nat.c: Revert.
12470         * amd64-tdep.c: Revert.
12471         * amd64-sol2-tdep.c: Revert.
12472         * amd64-obsd-tdep.c: Revert.
12473         * amd64-obsd-nat.c: Revert.
12474         * amd64-nbsd-tdep.c: Revert.
12475         * amd64-nbsd-nat.c: Revert.
12476         * amd64-nat.c: Revert.
12477         * amd64-linux-tdep.c: Revert.
12478         * amd64-linux-nat.c: Revert.
12479         * amd64-fbsd-tdep.c: Revert.
12480         * amd64-fbsd-nat.c: Revert.
12481         * amd64-dicos-tdep.c: Revert.
12482         * amd64-darwin-tdep.c: Revert.
12483         * amd64-bsd-nat.c: Revert.
12484         * alpha-tdep.c: Revert.
12485         * alpha-obsd-tdep.c: Revert.
12486         * alpha-nbsd-tdep.c: Revert.
12487         * alpha-mdebug-tdep.c: Revert.
12488         * alpha-linux-tdep.c: Revert.
12489         * alpha-linux-nat.c: Revert.
12490         * alpha-bsd-tdep.c: Revert.
12491         * alpha-bsd-nat.c: Revert.
12492         * aix-thread.c: Revert.
12493         * agent.c: Revert.
12494         * addrmap.c: Revert.
12495         * ada-varobj.c: Revert.
12496         * ada-valprint.c: Revert.
12497         * ada-typeprint.c: Revert.
12498         * ada-tasks.c: Revert.
12499         * ada-lang.c: Revert.
12500         * aarch64-tdep.c: Revert.
12501         * aarch64-ravenscar-thread.c: Revert.
12502         * aarch64-newlib-tdep.c: Revert.
12503         * aarch64-linux-tdep.c: Revert.
12504         * aarch64-linux-nat.c: Revert.
12505         * aarch64-fbsd-tdep.c: Revert.
12506         * aarch64-fbsd-nat.c: Revert.
12507         * aarch32-linux-nat.c: Revert.
12508
12509 2019-04-05  Tom Tromey  <tom@tromey.com>
12510
12511         * ft32-tdep.c: Sort headers.
12512         * frv-tdep.c: Sort headers.
12513         * frv-linux-tdep.c: Sort headers.
12514         * frame.c: Sort headers.
12515         * frame-unwind.c: Sort headers.
12516         * frame-base.c: Sort headers.
12517         * fork-child.c: Sort headers.
12518         * findvar.c: Sort headers.
12519         * findcmd.c: Sort headers.
12520         * filesystem.c: Sort headers.
12521         * filename-seen-cache.h: Sort headers.
12522         * filename-seen-cache.c: Sort headers.
12523         * fbsd-tdep.c: Sort headers.
12524         * fbsd-nat.h: Sort headers.
12525         * fbsd-nat.c: Sort headers.
12526         * f-valprint.c: Sort headers.
12527         * f-typeprint.c: Sort headers.
12528         * f-lang.c: Sort headers.
12529         * extension.h: Sort headers.
12530         * extension.c: Sort headers.
12531         * extension-priv.h: Sort headers.
12532         * expprint.c: Sort headers.
12533         * exec.h: Sort headers.
12534         * exec.c: Sort headers.
12535         * exceptions.c: Sort headers.
12536         * event-top.c: Sort headers.
12537         * event-loop.c: Sort headers.
12538         * eval.c: Sort headers.
12539         * elfread.c: Sort headers.
12540         * dwarf2read.h: Sort headers.
12541         * dwarf2read.c: Sort headers.
12542         * dwarf2loc.c: Sort headers.
12543         * dwarf2expr.h: Sort headers.
12544         * dwarf2expr.c: Sort headers.
12545         * dwarf2-frame.c: Sort headers.
12546         * dwarf2-frame-tailcall.c: Sort headers.
12547         * dwarf-index-write.h: Sort headers.
12548         * dwarf-index-write.c: Sort headers.
12549         * dwarf-index-common.c: Sort headers.
12550         * dwarf-index-cache.h: Sort headers.
12551         * dwarf-index-cache.c: Sort headers.
12552         * dummy-frame.c: Sort headers.
12553         * dtrace-probe.c: Sort headers.
12554         * disasm.h: Sort headers.
12555         * disasm.c: Sort headers.
12556         * disasm-selftests.c: Sort headers.
12557         * dictionary.c: Sort headers.
12558         * dicos-tdep.c: Sort headers.
12559         * demangle.c: Sort headers.
12560         * dcache.h: Sort headers.
12561         * dcache.c: Sort headers.
12562         * darwin-nat.h: Sort headers.
12563         * darwin-nat.c: Sort headers.
12564         * darwin-nat-info.c: Sort headers.
12565         * d-valprint.c: Sort headers.
12566         * d-namespace.c: Sort headers.
12567         * d-lang.c: Sort headers.
12568         * ctf.c: Sort headers.
12569         * csky-tdep.c: Sort headers.
12570         * csky-linux-tdep.c: Sort headers.
12571         * cris-tdep.c: Sort headers.
12572         * cris-linux-tdep.c: Sort headers.
12573         * cp-valprint.c: Sort headers.
12574         * cp-support.c: Sort headers.
12575         * cp-namespace.c: Sort headers.
12576         * cp-abi.c: Sort headers.
12577         * corelow.c: Sort headers.
12578         * corefile.c: Sort headers.
12579         * continuations.c: Sort headers.
12580         * completer.h: Sort headers.
12581         * completer.c: Sort headers.
12582         * complaints.c: Sort headers.
12583         * coffread.c: Sort headers.
12584         * coff-pe-read.c: Sort headers.
12585         * cli-out.h: Sort headers.
12586         * cli-out.c: Sort headers.
12587         * charset.c: Sort headers.
12588         * c-varobj.c: Sort headers.
12589         * c-valprint.c: Sort headers.
12590         * c-typeprint.c: Sort headers.
12591         * c-lang.c: Sort headers.
12592         * buildsym.c: Sort headers.
12593         * buildsym-legacy.c: Sort headers.
12594         * build-id.h: Sort headers.
12595         * build-id.c: Sort headers.
12596         * btrace.c: Sort headers.
12597         * bsd-uthread.c: Sort headers.
12598         * breakpoint.h: Sort headers.
12599         * breakpoint.c: Sort headers.
12600         * break-catch-throw.c: Sort headers.
12601         * break-catch-syscall.c: Sort headers.
12602         * break-catch-sig.c: Sort headers.
12603         * blockframe.c: Sort headers.
12604         * block.c: Sort headers.
12605         * bfin-tdep.c: Sort headers.
12606         * bfin-linux-tdep.c: Sort headers.
12607         * bfd-target.c: Sort headers.
12608         * bcache.c: Sort headers.
12609         * ax-general.c: Sort headers.
12610         * ax-gdb.h: Sort headers.
12611         * ax-gdb.c: Sort headers.
12612         * avr-tdep.c: Sort headers.
12613         * auxv.c: Sort headers.
12614         * auto-load.c: Sort headers.
12615         * arm-wince-tdep.c: Sort headers.
12616         * arm-tdep.c: Sort headers.
12617         * arm-symbian-tdep.c: Sort headers.
12618         * arm-pikeos-tdep.c: Sort headers.
12619         * arm-obsd-tdep.c: Sort headers.
12620         * arm-nbsd-tdep.c: Sort headers.
12621         * arm-nbsd-nat.c: Sort headers.
12622         * arm-linux-tdep.c: Sort headers.
12623         * arm-linux-nat.c: Sort headers.
12624         * arm-fbsd-tdep.c: Sort headers.
12625         * arm-fbsd-nat.c: Sort headers.
12626         * arm-bsd-tdep.c: Sort headers.
12627         * arch-utils.c: Sort headers.
12628         * arc-tdep.c: Sort headers.
12629         * arc-newlib-tdep.c: Sort headers.
12630         * annotate.h: Sort headers.
12631         * annotate.c: Sort headers.
12632         * amd64-windows-tdep.c: Sort headers.
12633         * amd64-windows-nat.c: Sort headers.
12634         * amd64-tdep.c: Sort headers.
12635         * amd64-sol2-tdep.c: Sort headers.
12636         * amd64-obsd-tdep.c: Sort headers.
12637         * amd64-obsd-nat.c: Sort headers.
12638         * amd64-nbsd-tdep.c: Sort headers.
12639         * amd64-nbsd-nat.c: Sort headers.
12640         * amd64-nat.c: Sort headers.
12641         * amd64-linux-tdep.c: Sort headers.
12642         * amd64-linux-nat.c: Sort headers.
12643         * amd64-fbsd-tdep.c: Sort headers.
12644         * amd64-fbsd-nat.c: Sort headers.
12645         * amd64-dicos-tdep.c: Sort headers.
12646         * amd64-darwin-tdep.c: Sort headers.
12647         * amd64-bsd-nat.c: Sort headers.
12648         * alpha-tdep.c: Sort headers.
12649         * alpha-obsd-tdep.c: Sort headers.
12650         * alpha-nbsd-tdep.c: Sort headers.
12651         * alpha-mdebug-tdep.c: Sort headers.
12652         * alpha-linux-tdep.c: Sort headers.
12653         * alpha-linux-nat.c: Sort headers.
12654         * alpha-bsd-tdep.c: Sort headers.
12655         * alpha-bsd-nat.c: Sort headers.
12656         * aix-thread.c: Sort headers.
12657         * agent.c: Sort headers.
12658         * addrmap.c: Sort headers.
12659         * ada-varobj.c: Sort headers.
12660         * ada-valprint.c: Sort headers.
12661         * ada-typeprint.c: Sort headers.
12662         * ada-tasks.c: Sort headers.
12663         * ada-lang.c: Sort headers.
12664         * aarch64-tdep.c: Sort headers.
12665         * aarch64-ravenscar-thread.c: Sort headers.
12666         * aarch64-newlib-tdep.c: Sort headers.
12667         * aarch64-linux-tdep.c: Sort headers.
12668         * aarch64-linux-nat.c: Sort headers.
12669         * aarch64-fbsd-tdep.c: Sort headers.
12670         * aarch64-fbsd-nat.c: Sort headers.
12671         * aarch32-linux-nat.c: Sort headers.
12672
12673 2019-04-04  Tom Tromey  <tom@tromey.com>
12674
12675         * varobj.c (varobj_create): Update.
12676         * rust-exp.y (struct rust_parser) <update_innermost_block,
12677         lookup_symbol>: New methods.
12678         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
12679         Rename.
12680         (rust_parser::rust_lookup_type)
12681         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
12682         * printcmd.c (display_command, do_one_display): Update.
12683         * parser-defs.h (struct parser_state) <parser_state>: Add
12684         "tracker" parameter.
12685         (block_tracker): New member.
12686         (class innermost_block_tracker) <innermost_block_tracker>: Add
12687         "types" parameter.
12688         <reset>: Remove method.
12689         (innermost_block): Don't declare.
12690         (null_post_parser): Update.
12691         * parse.c (innermost_block): Remove global.
12692         (write_dollar_variable): Update.
12693         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
12694         Remove "tracker_types" parameter.
12695         (parse_expression): Add "tracker" parameter.
12696         (parse_expression_for_completion): Update.
12697         (null_post_parser): Add "tracker" parameter.
12698         * p-exp.y: Update rules.
12699         * m2-exp.y: Update rules.
12700         * language.h (struct language_defn) <la_post_parser>: Add
12701         "tracker" parameter.
12702         * go-exp.y: Update rules.
12703         * f-exp.y: Update rules.
12704         * expression.h (parse_expression, parse_exp_1): Add "tracker"
12705         parameter.
12706         * d-exp.y: Update rules.
12707         * c-exp.y: Update rules.
12708         * breakpoint.c (set_breakpoint_condition): Create an
12709         innermost_block_tracker.
12710         (watch_command_1): Likewise.
12711         * ada-lang.c (resolve): Add "tracker" parameter.
12712         (resolve_subexp): Likewise.
12713         * ada-exp.y (write_var_from_sym): Update.
12714
12715 2019-04-04  Tom Tromey  <tom@tromey.com>
12716
12717         * type-stack.h: New file.
12718         * type-stack.c: New file.
12719         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
12720         type-stack.h.
12721         (insert_into_type_stack, insert_type, push_type, push_type_int)
12722         (insert_type_address_space, pop_type, pop_type_int)
12723         (pop_typelist, pop_type_stack, append_type_stack)
12724         (push_type_stack, get_type_stack, push_typelist)
12725         (follow_type_instance_flags, follow_types): Don't declare.
12726         * parse.c (type_stack): Remove global.
12727         (parse_exp_in_context): Update.
12728         (insert_into_type_stack, insert_type, push_type, push_type_int)
12729         (insert_type_address_space, pop_type, pop_type_int)
12730         (pop_typelist, pop_type_stack, append_type_stack)
12731         (push_type_stack, get_type_stack, push_typelist)
12732         (follow_type_instance_flags, follow_types): Remove (moved to
12733         type-stack.c).
12734         * f-exp.y (type_stack): New global.
12735         Update rules.
12736         (push_kind_type, f_parse): Update.
12737         * d-exp.y (type_stack): New global.
12738         Update rules.
12739         (d_parse): Update.
12740         * c-exp.y (struct c_parse_state) <type_stack>: New member.
12741         Update rules.
12742         * Makefile.in (COMMON_SFILES): Add type-stack.c.
12743         (HFILES_NO_SRCDIR): Add type-stack.h.
12744
12745 2019-04-04  Tom Tromey  <tom@tromey.com>
12746
12747         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
12748         (rust_parser::convert_ast_to_expression, rust_parse)
12749         (rust_lex_test_completion, rust_lex_tests): Update.
12750         * parser-defs.h (struct expr_completion_state): New.
12751         (struct parser_state) <parser_state>: Add completion parameter.
12752         <mark_struct_expression, mark_completion_tag>: New methods.
12753         <parse_completion, m_completion_state>: New members.
12754         (prefixify_expression, null_post_parser): Update.
12755         (mark_struct_expression, mark_completion_tag): Don't declare.
12756         * parse.c (parse_completion, expout_last_struct)
12757         (expout_tag_completion_type, expout_completion_name): Remove
12758         globals.
12759         (parser_state::mark_struct_expression)
12760         (parser_state::mark_completion_tag): Now methods.
12761         (prefixify_expression): Add last_struct parameter.
12762         (prefixify_subexp): Likewise.
12763         (parse_exp_1): Update.
12764         (parse_exp_in_context): Add cstate parameter.  Update.
12765         (parse_expression_for_completion): Create an
12766         expr_completion_state.
12767         (null_post_parser): Add "completion" parameter.
12768         * p-exp.y: Update rules.
12769         (yylex): Update.
12770         * language.h (struct language_defn) <la_post_parser>: Add
12771         "completing" parameter.
12772         * go-exp.y: Update rules.
12773         (lex_one_token): Update.
12774         * expression.h (parse_completion): Don't declare.
12775         * d-exp.y: Update rules.
12776         (lex_one_token): Update rules.
12777         * c-exp.y: Update rules.
12778         (lex_one_token): Update.
12779         * ada-lang.c (resolve): Add "parse_completion" parameter.
12780         (resolve_subexp): Likewise.
12781         (ada_resolve_function): Likewise.
12782
12783 2019-04-04  Tom Tromey  <tom@tromey.com>
12784
12785         * parser-defs.h (struct parser_state) <start_arglist,
12786         end_arglist>: New methods.
12787         <arglist_len, m_funcall_chain>: New members.
12788         (arglist_len, start_arglist, end_arglist): Don't declare.
12789         * parse.c (arglist_len, funcall_chain): Remove global.
12790         (start_arglist, end_arglist): Remove functions.
12791         (parse_exp_in_context): Update.
12792         * p-exp.y: Update rules.
12793         * m2-exp.y: Update rules.
12794         * go-exp.y: Update rules.
12795         * f-exp.y: Update rules.
12796         * d-exp.y: Update rules.
12797         * c-exp.y: Update rules.
12798
12799 2019-04-04  Tom Tromey  <tom@tromey.com>
12800
12801         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
12802         lex_operator, push_back>: New methods.
12803         Update all rules.
12804         (rust_parser::lex_hex, lex_escape): Rename and update.
12805         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
12806         (rust_parser::lex_operator): Rename and update.
12807         (rust_parser::lex_number, rustyylex, rustyyerror)
12808         (rust_lex_test_init, rust_lex_test_sequence)
12809         (rust_lex_test_push_back, rust_lex_tests): Update.
12810         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
12811         parameter.
12812         <lexptr, prev_lexptr>: New members.
12813         (lexptr, prev_lexptr): Don't declare.
12814         * parse.c (lexptr, prev_lexptr): Remove globals.
12815         (parse_exp_in_context): Update.
12816         * p-exp.y (yylex, yyerror): Update.
12817         * m2-exp.y (parse_number, yylex, yyerror): Update.
12818         * go-exp.y (lex_one_token, yyerror): Update.
12819         * f-exp.y (match_string_literal, yylex, yyerror): Update.
12820         * d-exp.y (lex_one_token, yyerror): Update.
12821         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
12822         (lex_one_token, yyerror): Update.
12823         * ada-lex.l (YY_INPUT): Update.
12824         (rewind_to_char): Update.
12825         * ada-exp.y (yyerror): Update.
12826
12827 2019-04-04  Tom Tromey  <tom@tromey.com>
12828
12829         * rust-exp.y (rustyylex, rust_lex_tests): Update.
12830         * parser-defs.h (struct parser_state) <parser_state>: Add new
12831         parameter.
12832         <comma_terminates>: New member.
12833         (comma_terminates): Don't declare global.
12834         * parse.c (comma_terminates): Remove global.
12835         (parse_exp_in_context): Update.
12836         * p-exp.y (yylex): Update.
12837         * m2-exp.y (yylex): Update.
12838         * go-exp.y (lex_one_token): Update.
12839         * f-exp.y (yylex): Update.
12840         * d-exp.y (lex_one_token): Update.
12841         * c-exp.y (lex_one_token): Update.
12842         * ada-lex.l: Update.
12843
12844 2019-04-04  Tom Tromey  <tom@tromey.com>
12845
12846         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
12847         (rustyylex, rust_lex_test_init, rust_lex_test_one)
12848         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
12849         * parser-defs.h (paren_depth): Don't declare.
12850         * parse.c (paren_depth): Remove global.
12851         (parse_exp_in_context): Update.
12852         * p-exp.y (paren_depth): New global.
12853         (pascal_parse): Initialize it.
12854         * m2-exp.y (paren_depth): New global.
12855         (m2_parse): Initialize it.
12856         * go-exp.y (paren_depth): New global.
12857         (go_parse): Initialize it.
12858         * f-exp.y (paren_depth): New global.
12859         (f_parse): Initialize it.
12860         * d-exp.y (paren_depth): New global.
12861         (d_parse): Initialize it.
12862         * c-exp.y (paren_depth): New global.
12863         (c_parse): Initialize it.
12864         * ada-lex.l (paren_depth): New global.
12865         (lexer_init): Initialize it.
12866
12867 2019-04-04  Tom Tromey  <tom@tromey.com>
12868
12869         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
12870         (rust_parser::convert_ast_to_type)
12871         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
12872         * parser-defs.h (struct parser_state) <parser_state>: Add
12873         parameters.  Initialize new members.
12874         <expression_context_block, expression_context_pc>: New members.
12875         * parse.c (expression_context_block, expression_context_pc):
12876         Remove globals.
12877         (parse_exp_in_context): Update.
12878         * p-exp.y: Update all rules.
12879         (yylex): Update.
12880         * m2-exp.y: Update all rules.
12881         (yylex): Update.
12882         * go-exp.y (yylex): Update.
12883         * f-exp.y (yylex): Update.
12884         * d-exp.y: Update all rules.
12885         (yylex): Update.
12886         * c-exp.y: Update all rules.
12887         (lex_one_token, classify_name, yylex, c_parse): Update.
12888         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
12889
12890 2019-04-04  Tom Tromey  <tom@tromey.com>
12891
12892         * gdbarch.h, gdbarch.c: Rebuild.
12893         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
12894         * stap-probe.h:
12895         (struct stap_parse_info): Replace "parser_state" with
12896         "expr_builder".
12897         * parser-defs.h (struct expr_builder): Rename from "parser_state".
12898         (parser_state): New class.
12899         * parse.c (expr_builder): Rename.
12900         (expr_builder::release): Rename.
12901         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
12902         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
12903         (write_exp_elt_longcst, write_exp_elt_floatcst)
12904         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
12905         (write_exp_string_vector, write_exp_bitstring)
12906         (write_exp_msymbol, mark_struct_expression)
12907         (write_dollar_variable)
12908         (insert_type_address_space, increase_expout_size): Replace
12909         "parser_state" with "expr_builder".
12910         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
12911         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
12912         "parser_state" with "expr_builder".
12913
12914 2019-04-04  Tom Tromey  <tom@tromey.com>
12915
12916         * rust-exp.y: Replace "parse_language" with method call.
12917         * p-exp.y:
12918         (yylex): Replace "parse_language" with method call.
12919         * m2-exp.y:
12920         (yylex): Replace "parse_language" with method call.
12921         * go-exp.y (classify_name): Replace "parse_language" with method
12922         call.
12923         * f-exp.y (yylex): Replace "parse_language" with method call.
12924         * d-exp.y (lex_one_token): Replace "parse_language" with method
12925         call.
12926         * c-exp.y:
12927         (lex_one_token, classify_name, yylex): Replace "parse_language"
12928         with method call.
12929         * ada-exp.y (find_primitive_type, type_char)
12930         (type_system_address): Replace "parse_language" with method call.
12931
12932 2019-04-04  Tom Tromey  <tom@tromey.com>
12933
12934         * rust-exp.y: Replace "parse_gdbarch" with method call.
12935         * parse.c (write_dollar_variable, insert_type_address_space):
12936         Replace "parse_gdbarch" with method call.
12937         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
12938         call.
12939         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
12940         call.
12941         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
12942         "parse_gdbarch" with method call.
12943         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
12944         with method call.
12945         * f-exp.y (parse_type, parse_f_type, yylex): Replace
12946         "parse_gdbarch" with method call.
12947         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
12948         "parse_gdbarch" with method call.
12949         * c-exp.y (parse_type, parse_number, classify_name): Replace
12950         "parse_gdbarch" with method call.
12951         * ada-lex.l: Replace "parse_gdbarch" with method call.
12952         * ada-exp.y (parse_type, find_primitive_type, type_char)
12953         (type_system_address): Replace "parse_gdbarch" with method call.
12954
12955 2019-04-04  Tom Tromey  <tom@tromey.com>
12956
12957         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
12958         * stap-probe.c (stap_parse_argument): Update.
12959         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
12960         initial_size parameter.
12961         * rust-exp.y (rust_lex_tests): Update.
12962         * parse.c (parser_state): Update.
12963         (parse_exp_in_context): Update.
12964         * parser-defs.h (struct parser_state) <parser_state>: Remove
12965         "initial_size" parameter.
12966
12967 2019-04-04  Tom Tromey  <tom@tromey.com>
12968
12969         * parser-defs.h (increase_expout_size): Don't declare.
12970         * parse.c (increase_expout_size): Now static.
12971
12972 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
12973
12974         * gnu-nat.c (gnu_nat_target::wait): Fix
12975         target_waitstatus_to_string call.
12976
12977 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
12978
12979         * eval.c (evaluate_subexp_standard): Handle internal functions
12980         during Fortran function call handling.
12981
12982 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
12983
12984         * NEWS: Mention new internal functions.
12985         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
12986         (read_base_type): Use dwarf2_init_complex_target_type.
12987         * value.c (creal_internal_fn): New function.
12988         (cimag_internal_fn): New function.
12989         (_initialize_values): Register new internal functions.
12990
12991 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12992
12993         * infrun.c (stop_all_threads): If debug_infrun, always
12994         trace the wait status after wait_one, using
12995         target_waitstatus_to_string and target_pid_to_str.
12996         (handle_inferior_event): Replace various trace of
12997         wait status kind by a single trace.
12998         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
12999         wait status kind image by target_waitstatus_to_string.
13000         * target/waitstatus.c (target_waitstatus_to_string): Fix
13001         obsolete comment.
13002
13003 2019-04-01  Tom Tromey  <tromey@adacore.com>
13004
13005         PR symtab/23331:
13006         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
13007
13008 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
13009             Pedro Alves  <palves@redhat.com>
13010
13011         * top.c (quit_force): Call 'finalize_values'.
13012         * value.c (finalize_values): New function.
13013         * value.h (finalize_values): Declare.
13014
13015 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
13016
13017         * NEWS: Announce $_gdb_major and $_gdb_minor.
13018
13019         * top.c (init_gdb_version_vars): New function.
13020         (gdb_init): Call init_gdb_version_vars.
13021
13022 2019-03-29  Tom Tromey  <tromey@adacore.com>
13023
13024         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
13025         help text.  Remove dead code.
13026
13027 2019-03-29  Keith Seitz  <keiths@redhat.com>
13028
13029         From Siddhesh Poyarekar:
13030         * f-lang.h (f77_get_upperbound): Return LONGEST.
13031         (f77_get_lowerbound): Likewise.
13032         * f-typeprint.c (f_type_print_varspec_suffix): Expand
13033         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
13034         print them.
13035         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
13036         plongest to format print it.
13037         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
13038         (f77_get_upperbound): Likewise.
13039         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
13040         LOWER_BOUND to LONGEST.
13041         (f77_create_arrayprint_offset_tbl): Likewise.
13042
13043 2019-03-29  Keith Seitz  <keiths@redhat.com>
13044
13045         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
13046         %s/pulongest for TYPE_LENGTH instead of %d in format
13047         strings.
13048         * ada-typerint.c (ada_print_type): Likewise.
13049         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
13050         * compile/compile-c-support.c (generate_register_struct): Likewise.
13051         * gdbtypes.c (recursive_dump_type): Likewise.
13052         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
13053         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
13054         instead of %d in format strings.
13055         * riscv-tdep.c (riscv_type_alignment): Cast second argument
13056         to std::min to ULONGEST.
13057         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
13058         instead of %d in format strings.
13059         * tracepoint.c (info_scope_command): Likewise.
13060         * typeprint.c (print_offset_data::update)
13061         (print_offset_data::finish): Likewise.
13062         * xtensa-tdep.c (xtensa_store_return_value)
13063         (xtensa_push_dummy_call): Likewise.
13064
13065 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
13066
13067         * windows-nat.c (display_selector): Fixed format specifications
13068         for 64-bit Cygwin.
13069
13070 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13071
13072         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
13073
13074 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
13075
13076         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
13077         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
13078         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
13079         (nios2_linux_init_abi): Install it.
13080
13081 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
13082
13083         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
13084
13085 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
13086
13087         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
13088
13089 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13090             Tom Tromey  <tromey@adacore.com>
13091
13092         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
13093
13094 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
13095
13096         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
13097         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
13098         method to compute the bounds of range types. Also print "[evaluated]"
13099         if the bounds' values come from a dynamic evaluation.
13100
13101 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
13102
13103         * cp-valprint.c (cp_print_value_fields): Don't print trailing
13104         whitespace when pretty printing is on.
13105
13106 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
13107
13108         * ppc-linux-nat.c: Add include.
13109
13110 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
13111
13112         * NEWS: Mention AArch64 Pointer Authentication.
13113
13114 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
13115
13116         * arm-linux-nat.c: Add include.
13117
13118 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
13119
13120         * source-cache.c (source_cache::get_source_lines): Re-read
13121         fullname after calling open_source_file.
13122
13123 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
13124
13125         * NEWS: Mention TLS support for FreeBSD.
13126
13127 2019-03-25  Tom Tromey  <tromey@adacore.com>
13128
13129         * minsyms.c (BUNCH_SIZE): Update comment.
13130         (~minimal_symbol_reader): Remove old comment.
13131         (compact_minimal_symbols): Update comment.
13132         (minimal_symbol_reader::install): Remove old comment.  Update
13133         other comments.
13134
13135 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
13136
13137         * s390-linux-nat.c: Add include.
13138
13139 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
13140
13141         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
13142         Call linux_get_hwcap.
13143         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
13144         Likewise.
13145         (aarch64_linux_get_hwcap): Remove function.
13146         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
13147         declaration.
13148         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
13149         linux_get_hwcap.
13150         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
13151         * linux-tdep.c (linux_get_hwcap): Add function.
13152         (linux_get_hwcap2): Likewise.
13153         * linux-tdep.h (linux_get_hwcap): Add declaration.
13154         (linux_get_hwcap2): Likewise.
13155         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
13156         (ppc_linux_get_hwcap2): Likewise.
13157         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
13158         linux_get_hwcap.
13159         (ppc_linux_nat_target::insert_watchpoint): Likewise.
13160         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
13161         (ppc_linux_nat_target::read_description): Likewise.
13162         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
13163         * s390-linux-nat.c: Likewise.
13164         * s390-linux-tdep.c (s390_core_read_description): Likewise.
13165
13166 2019-03-24  Tom Tromey  <tom@tromey.com>
13167
13168         * ada-lang.c (standard_lookup): Simplify initialization.
13169         (ada_lookup_symbol_nonlocal): Simplify return.
13170         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
13171         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
13172         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
13173         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
13174         initialization.
13175         * solib.c (solib_global_lookup): Simplify.
13176         * symtab.c (null_block_symbol): Remove.
13177         (symbol_cache_lookup): Simplify returns.
13178         (lookup_language_this): Simplify returns.
13179         (lookup_symbol_aux): Simplify return.
13180         (lookup_local_symbol): Simplify returns.
13181         (lookup_global_symbol_from_objfile): Simplify return.
13182         (lookup_symbol_in_objfile_symtabs)
13183         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
13184         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
13185         (lookup_static_symbol, lookup_global_symbol): Simplify return.
13186         * cp-namespace.c (cp_lookup_bare_symbol)
13187         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
13188         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
13189         (cp_lookup_nested_symbol): Don't use null_block_symbol.
13190         (cp_lookup_symbol_via_imports): Simplify initialization.
13191         (find_symbol_in_baseclass): Likewise.
13192         * symtab.h (null_block_symbol): Remove.
13193         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
13194         (d_lookup_nested_symbol, d_lookup_symbol_imports)
13195         (d_lookup_symbol_module): Likewise.
13196         (find_symbol_in_baseclass): Simplify initialization.
13197
13198 2019-03-24  Tom Tromey  <tom@tromey.com>
13199
13200         * expression.h: Don't include symtab.h.
13201         (struct block): Forward declare.
13202
13203 2019-03-24  Tom Tromey  <tom@tromey.com>
13204
13205         * c-exp.y (typebase): Remove casts.
13206         * gdbtypes.c (lookup_unsigned_typename, )
13207         (lookup_signed_typename): Remove cast.
13208         * eval.c (parse_to_comma_and_eval): Remove cast.
13209         * parse.c (write_dollar_variable): Remove cast.
13210         * block.h (struct block) <superblock>: Now const.
13211         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
13212         * psymtab.c (psym_map_matching_symbols): Make "block" const.
13213         (map_block): Make "block" const.
13214         * symfile.h (struct quick_symbol_functions)
13215         <map_matching_symbols>: Constify block argument to "callback".
13216         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
13217         const.
13218         (find_pc_sect_compunit_symtab): Make "b" const.
13219         (find_symbol_at_address): Likewise.
13220         (search_symbols): Likewise.
13221         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
13222         (dw2_debug_names_lookup_symbol): Likewise.
13223         (dw2_map_matching_symbols): Update.
13224         * p-valprint.c (pascal_val_print): Remove "block".
13225         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
13226         (aux_add_nonlocal_symbols): Make "block" const.
13227         (resolve_subexp): Remove cast.
13228         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
13229         const.
13230         (iterate_over_file_blocks): Likewise.
13231         * f-exp.y (%union) <bval>: Remove.
13232         * coffread.c (patch_opaque_types): Make "b" const.
13233         * spu-tdep.c (spu_catch_start): Make "block" const.
13234         * c-valprint.c (print_unpacked_pointer): Remove "block".
13235         * symmisc.c (dump_symtab_1): Make "b" const.
13236         (block_depth): Make "block" const.
13237         * d-exp.y (%union) <bval>: Remove.
13238         * cp-support.h (cp_lookup_rtti_type): Update.
13239         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
13240         * psymtab.c (psym_lookup_symbol): Make "block" const.
13241         (maintenance_check_psymtabs): Make "b" const.
13242         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
13243         (enumerate_locals, enumerate_args): Update.
13244         * python/py-symtab.c (stpy_global_block): Make "block" const.
13245         (stpy_static_block): Likewise.
13246         * inline-frame.c (block_starting_point_at): Make "new_block"
13247         const.
13248         * block.c (find_block_in_blockvector): Make return type const.
13249         (blockvector_for_pc_sect): Make "b" const.
13250         (find_block_in_blockvector): Make "b" const.
13251
13252 2019-03-23  Tom Tromey  <tom@tromey.com>
13253
13254         * varobj.c (varobj_create): Update.
13255         * symfile.c (clear_symtab_users): Don't reset innermost_block.
13256         * printcmd.c (display_command, do_one_display): Don't reset
13257         innermost_block.
13258         * parser-defs.h (enum innermost_block_tracker_type): Move to
13259         expression.h.
13260         (innermost_block): Update comment.
13261         * parse.c (parse_exp_1): Add tracker_types parameter.
13262         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
13263         tracker_types parameter.  Reset innermost_block.
13264         (parse_exp_in_context): Remove.
13265         (parse_expression_for_completion): Update.
13266         * objfiles.c (~objfile): Don't reset expression_context_block or
13267         innermost_block.
13268         * expression.h (enum innermost_block_tracker_type): Move from
13269         parser-defs.h.
13270         (parse_exp_1): Add tracker_types parameter.
13271         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
13272         reset innermost_block.
13273
13274 2019-03-23  Tom Tromey  <tom@tromey.com>
13275
13276         * objfiles.h: Include bcache.h.
13277
13278 2019-03-23  Tom Tromey  <tom@tromey.com>
13279
13280         * linespec.c (get_current_search_block): Use
13281         scoped_restore_current_language.
13282         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
13283
13284 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
13285             Jiong Wang  <jiong.wang@arm.com>
13286
13287         * aarch64-linux-tdep.c
13288         (aarch64_linux_iterate_over_regset_sections): Check for pauth
13289         section.
13290         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
13291
13292 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
13293             Jiong Wang  <jiong.wang@arm.com>
13294
13295         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
13296         instructions.
13297         (aarch64_analyze_prologue_test): Add PACIASP test.
13298         (aarch64_prologue_prev_register): Unmask PC value.
13299
13300 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
13301             Jiong Wang  <jiong.wang@arm.com>
13302
13303         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
13304         (aarch64_dwarf2_prev_register): Unmask PC value.
13305         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
13306         (aarch64_execute_dwarf_cfa_vendor_op): Check for
13307         DW_CFA_AARCH64_negate_ra_state.
13308         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
13309
13310 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
13311             Jiong Wang  <jiong.wang@arm.com>
13312
13313         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
13314         registers.
13315         (aarch64_pseudo_register_name): Likewise.
13316         (aarch64_pseudo_register_type): Likewise.
13317         (aarch64_pseudo_register_reggroup_p): Likewise.
13318         (aarch64_gdbarch_init): Add pauth registers.
13319         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
13320         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
13321         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
13322         (struct gdbarch_tdep): Add regnum for ra_state.
13323
13324 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
13325             Jiong Wang  <jiong.wang@arm.com>
13326
13327         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
13328
13329 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
13330             Jiong Wang  <jiong.wang@arm.com>
13331
13332         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
13333         function.
13334         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
13335         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
13336         (aarch64_gdbarch_init): Add puth registers.
13337         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
13338         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
13339         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
13340
13341 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
13342             Jiong Wang  <jiong.wang@arm.com>
13343
13344         * aarch64-linux-nat.c
13345         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
13346         * aarch64-linux-tdep.c
13347         (aarch64_linux_core_read_description): Likewise.
13348         (aarch64_linux_get_hwcap): New function.
13349         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
13350         (aarch64_linux_get_hwcap): New declaration.
13351
13352 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
13353             Jiong Wang  <jiong.wang@arm.com>
13354
13355         * aarch64-linux-nat.c
13356         (aarch64_linux_nat_target::read_description): Add pauth param.
13357         * aarch64-linux-tdep.c
13358         (aarch64_linux_core_read_description): Likewise.
13359         * aarch64-tdep.c (struct target_desc): Add in pauth.
13360         (aarch64_read_description): Add pauth param.
13361         (aarch64_gdbarch_init): Likewise.
13362         * aarch64-tdep.h (aarch64_read_description): Likewise.
13363         * arch/aarch64.c (aarch64_create_target_description): Likewise.
13364         * arch/aarch64.h (aarch64_create_target_description): Likewise.
13365         * features/Makefile: Add new files.
13366         * features/aarch64-pauth.c: New file.
13367         * features/aarch64-pauth.xml: New file.
13368
13369 2019-03-20  Tom Tromey  <tromey@adacore.com>
13370
13371         * infrun.c (handle_inferior_event): Rename from
13372         handle_inferior_event_1.  Create a scoped_value_mark.
13373         (handle_inferior_event): Remove.
13374
13375 2019-03-19  Tom Tromey  <tromey@adacore.com>
13376
13377         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
13378         * infrun.h (print_stop_event): Add "displays" parameter.
13379         * infrun.c (print_stop_event): Add "displays" parameter.
13380
13381 2019-03-19  Pedro Alves  <palves@redhat.com>
13382
13383         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
13384         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
13385         to -1.  Fix TABs vs spaces.
13386         (tui_ui_out::tui_ui_out): Don't initialize fields here.
13387         * tui/tui-out.h (tui_ui_out) Add intro comments.
13388         <m_line, m_start_of_line>: In-class initialize, and add describing
13389         comment.
13390
13391 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
13392
13393         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
13394         variable names.
13395         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
13396
13397 2019-03-18  Pedro Alves  <palves@redhat.com>
13398             Eli Zaretskii <eliz@gnu.org>
13399
13400         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
13401         m_line and m_start_of_line.
13402
13403 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
13404
13405         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
13406         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
13407         it returns a newline.  This fixes a regression in TU mode, whereby
13408         the next line is output on the same screen line as the user input.
13409
13410 2019-03-18  Tom Tromey  <tromey@adacore.com>
13411
13412         * minsyms.c (minimal_symbol_reader::install): Remove call to
13413         obstack_blank.
13414
13415 2019-03-18  Pedro Alves  <palves@redhat.com>
13416
13417         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
13418         New globals.
13419         (apply_style): New, factored out from ...
13420         (apply_ansi_escape): ... this.  Handle reverse video mode.
13421         (tui_set_reverse_mode): New function.
13422         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
13423         * tui/tui-winsource.c (tui_show_source_line): Use
13424         tui_set_reverse_mode instead of setting A_STANDOUT.
13425         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
13426         New setter methods.
13427
13428 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
13429
13430         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
13431         Handle tabs.
13432
13433 2019-03-18  Tom Tromey  <tromey@adacore.com>
13434
13435         * ada-lang.c (empty_array): Add "high" parameter.
13436         (ada_evaluate_subexp): Update.
13437
13438 2019-03-17  Sergei Trofimovich <siarheit@google.com>
13439
13440         * unittests/string_view-selftests.c: Define
13441         _initialize_string_view_selftests unconditionally.
13442
13443 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
13444
13445         PR gdb/24350
13446         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
13447
13448 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
13449
13450         PR gdb/24351
13451         * windows-nat.c (display_selector): Fix format specifiers.
13452
13453 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
13454
13455         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
13456         tui_refill_source_window instead of tui_refresh_win, to update the
13457         current execution line.  This fixes redisplay of the current line
13458         when stepping through the code with "next" or "step".
13459
13460 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
13461
13462         * source-cache.c (source_cache::get_source_lines): Call
13463         find_source_lines to initialize s->nlines.  This fixes vertical
13464         scrolling of TUI source window when the DOWN arrow is pressed.
13465
13466 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13467
13468         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
13469         linux-thread-db.c (_initialize_thread_db): Likewise.
13470
13471 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
13472
13473         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
13474         wclrtoeol in tui_show_source_line".  This reverts changes made in
13475         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
13476
13477 2019-03-15  Tom Tromey  <tom@tromey.com>
13478
13479         * symtab.h (struct minimal_symbol): Derive from
13480         general_symbol_info.
13481         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
13482         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
13483         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
13484         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
13485         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
13486         (MSYMBOL_SEARCH_NAME): Update.
13487         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
13488         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
13489         * minsyms.c (minimal_symbol_reader::record_full): Update.
13490
13491 2019-03-15  Tom Tromey  <tom@tromey.com>
13492
13493         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
13494
13495 2019-03-15  Tom Tromey  <tom@tromey.com>
13496
13497         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
13498         unique_xmalloc_ptr.
13499         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
13500         Update.
13501         * minsyms.c (lookup_minimal_symbol_by_pc_section)
13502         (build_minimal_symbol_hash_tables)
13503         (minimal_symbol_reader::install): Update.
13504
13505 2019-03-15  Tom Tromey  <tom@tromey.com>
13506
13507         * symtab.c (create_demangled_names_hash): Update.
13508         (symbol_set_names): Update.
13509         * objfiles.h (struct objfile_per_bfd_storage)
13510         <demangled_names_hash>: Now an htab_up.
13511         * objfiles.c (objfile_per_bfd_storage): Simplify.
13512
13513 2019-03-15  Tom Tromey  <tom@tromey.com>
13514
13515         * objfiles.h (struct objfile_per_bfd_storage): Declare
13516         destructor.
13517         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
13518         New.
13519         (get_objfile_bfd_data): Use new.  Don't initialize
13520         language_of_main.
13521         (free_objfile_per_bfd_storage): Remove.
13522         (objfile_bfd_data_free, objfile::~objfile): Use delete.
13523
13524 2019-03-15  Tom Tromey  <tom@tromey.com>
13525
13526         * symfile.c (reread_symbols): Update.
13527         * objfiles.c (objfile::objfile): Update.
13528         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
13529         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
13530         comment.
13531         (minimal_symbol_reader::install): Update.
13532         (terminate_minimal_symbol_table): Remove.
13533         * jit.c (jit_object_close_impl): Update.
13534
13535 2019-03-15  Tom Tromey  <tom@tromey.com>
13536
13537         * minsyms.c (minimal_symbol_reader::record_full): Remove some
13538         initializations.
13539
13540 2019-03-15  Tom Tromey  <tom@tromey.com>
13541
13542         * objfiles.h (struct objfile_per_bfd_storage)
13543         <demangled_hash_languages>: Now a bitset.
13544         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
13545         (lookup_minimal_symbol): Update.
13546
13547 2019-03-15  Tom Tromey  <tom@tromey.com>
13548
13549         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
13550         Don't return the symbol.
13551         * coffread.c (record_minimal_symbol): Use record_full.
13552
13553 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
13554
13555         The MS-Windows port of ncurses fails to switch to a color pair if
13556         one or both of the colors are the implicit default colors.  This
13557         change records the default colors when TUI is initialized, and
13558         then specifies them explicitly when a color pair uses the default
13559         colors.  This allows color styling in TUI mode on MS-Windows.
13560
13561         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
13562         ncurses_norm_attr.
13563         (tui_initialize_io) [__MINGW32__]: Record the default terminal
13564         colors in ncurses_norm_attr.
13565         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
13566         "none", replace it with the default color recorded in
13567         ncurses_norm_attr.
13568
13569 2019-03-14  Tom Tromey  <tromey@adacore.com>
13570
13571         * source-cache.h (class source_cache) <get_source_lines>: Return
13572         std::string.
13573         * source-cache.c (source_cache::extract_lines): Handle case where
13574         first_pos==npos.  Return std::string.
13575         (source_cache::get_source_lines): Update.
13576
13577 2019-03-14  Tom Tromey  <tromey@adacore.com>
13578
13579         * NEWS: Add item for "style sources" commands.
13580         * source-cache.c (source_cache::get_source_lines): Check
13581         source_styling.
13582         * cli/cli-style.c (source_styling): New global.
13583         (_initialize_cli_style): Add "style sources" commands.
13584         (show_style_sources): New function.
13585         * cli/cli-style.h (source_styling): Declare.
13586
13587 2019-03-14  Pedro Alves  <palves@redhat.com>
13588             Tom Tromey  <tromey@adacore.com>
13589
13590         * tui/tui-winsource.h (tui_refill_source_window): Declare.
13591         * tui/tui-winsource.c (tui_refill_source_window): New function,
13592         from...
13593         (tui_horizontal_source_scroll): ... here.  Move some logic.
13594         * cli/cli-style.c (set_style_enabled): Notify new observable.
13595         * tui/tui-hooks.c (tui_redisplay_source): New function.
13596         (tui_attach_detach_observers): Attach or detach
13597         tui_redisplay_source.
13598         * observable.h (source_styling_changed): New observable.
13599         * observable.c: Define source_styling_changed observable.
13600
13601 2019-03-13  Tom Tromey  <tromey@adacore.com>
13602
13603         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
13604         (i386_gnu_nat_target::store_registers): Update.
13605         * target-debug.h (target_debug_print_std_string): New macro.
13606         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
13607         * windows-tdep.c (display_one_tib): Update.
13608         * tui/tui-stack.c (tui_make_status_line): Update.
13609         * top.c (print_inferior_quit_action): Update.
13610         * thread.c (thr_try_catch_cmd): Update.
13611         (add_thread_with_info): Update.
13612         (thread_target_id_str): Update.
13613         (thr_try_catch_cmd): Update.
13614         (thread_command): Update.
13615         (thread_find_command): Update.
13616         * record-btrace.c (record_btrace_target::info_record)
13617         (record_btrace_resume_thread, record_btrace_target::resume)
13618         (record_btrace_cancel_resume, record_btrace_step_thread)
13619         (record_btrace_target::wait, record_btrace_target::wait)
13620         (record_btrace_target::wait, record_btrace_target::stop): Update.
13621         * progspace.c (print_program_space): Update.
13622         * process-stratum-target.c
13623         (process_stratum_target::thread_address_space): Update.
13624         * linux-fork.c (linux_fork_mourn_inferior)
13625         (detach_checkpoint_command, info_checkpoints_command)
13626         (linux_fork_context): Update.
13627         (linux_fork_detach): Update.
13628         (class scoped_switch_fork_info): Update.
13629         (delete_checkpoint_command): Update.
13630         * infrun.c (follow_fork_inferior): Update.
13631         (follow_fork_inferior): Update.
13632         (proceed_after_vfork_done): Update.
13633         (handle_vfork_child_exec_or_exit): Update.
13634         (follow_exec): Update.
13635         (displaced_step_prepare_throw): Update.
13636         (displaced_step_restore): Update.
13637         (start_step_over): Update.
13638         (resume_1): Update.
13639         (clear_proceed_status_thread): Update.
13640         (proceed): Update.
13641         (print_target_wait_results): Update.
13642         (do_target_wait): Update.
13643         (context_switch): Update.
13644         (stop_all_threads): Update.
13645         (restart_threads): Update.
13646         (finish_step_over): Update.
13647         (handle_signal_stop): Update.
13648         (switch_back_to_stepped_thread): Update.
13649         (keep_going_pass_signal): Update.
13650         (print_exited_reason): Update.
13651         (normal_stop): Update.
13652         * inferior.c (inferior_pid_to_str): Change return type.
13653         (print_selected_inferior): Update.
13654         (add_inferior): Update.
13655         (detach_inferior): Update.
13656         * dummy-frame.c (fprint_dummy_frames): Update.
13657         * dcache.c (dcache_info_1): Update.
13658         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
13659         (btrace_fetch, btrace_clear): Update.
13660         * linux-tdep.c (linux_core_pid_to_str): Change return type.
13661         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
13662         type.
13663         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
13664         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
13665         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
13666         * gdbarch.c, gdbarch.h: Rebuild.
13667         * gdbarch.sh (core_pid_to_str): Change return type.
13668         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
13669         return type.
13670         (windows_nat_target::pid_to_str): Change return type.
13671         (windows_delete_thread): Update.
13672         (windows_nat_target::attach): Update.
13673         (windows_nat_target::files_info): Update.
13674         * target-delegates.c: Rebuild.
13675         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
13676         return type.
13677         (sol_thread_target::pid_to_str): Change return type.
13678         * remote.c (class remote_target) <pid_to_str>: Change return
13679         type.
13680         (remote_target::pid_to_str): Change return type.
13681         (extended_remote_target::attach, remote_target::remote_stop_ns)
13682         (remote_target::remote_notif_remove_queued_reply)
13683         (remote_target::push_stop_reply, remote_target::disable_btrace):
13684         Update.
13685         (extended_remote_target::attach): Update.
13686         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
13687         type.
13688         (gdbsim_target::pid_to_str): Change return type.
13689         * ravenscar-thread.c (struct ravenscar_thread_target)
13690         <pid_to_str>: Change return type.
13691         (ravenscar_thread_target::pid_to_str): Change return type.
13692         * procfs.c (class procfs_target) <pid_to_str>: Change return
13693         type.
13694         (procfs_target::pid_to_str): Change return type.
13695         (procfs_target::attach): Update.
13696         (procfs_target::detach): Update.
13697         (procfs_target::fetch_registers): Update.
13698         (procfs_target::store_registers): Update.
13699         (procfs_target::wait): Update.
13700         (procfs_target::files_info): Update.
13701         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
13702         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
13703         return type.
13704         (nto_procfs_target::pid_to_str): Change return type.
13705         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
13706         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
13707         return type.
13708         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
13709         (exit_lwp): Update.
13710         (attach_proc_task_lwp_callback, get_detach_signal)
13711         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
13712         (linux_nat_target::resume, wait_lwp, stop_callback)
13713         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
13714         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
13715         (linux_nat_wait_1, resume_stopped_resumed_lwps)
13716         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
13717         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
13718         type.
13719         (inf_ptrace_target::attach): Update.
13720         (inf_ptrace_target::files_info): Update.
13721         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
13722         type.
13723         (go32_nat_target::pid_to_str): Change return type.
13724         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
13725         (gnu_nat_target::wait): Update.
13726         (gnu_nat_target::wait): Update.
13727         (gnu_nat_target::resume): Update.
13728         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
13729         (fbsd_nat_target::wait): Update.
13730         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
13731         type.
13732         (darwin_nat_target::attach): Update.
13733         * corelow.c (class core_target) <pid_to_str>: Change return type.
13734         (core_target::pid_to_str): Change return type.
13735         * target.c (normal_pid_to_str): Change return type.
13736         (default_pid_to_str): Likewise.
13737         (target_pid_to_str): Change return type.
13738         (target_translate_tls_address): Update.
13739         (target_announce_detach): Update.
13740         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
13741         return type.
13742         (bsd_uthread_target::pid_to_str): Change return type.
13743         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
13744         type.
13745         (bsd_kvm_target::pid_to_str): Change return type.
13746         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
13747         return type.
13748         (aix_thread_target::pid_to_str): Change return type.
13749         * target.h (struct target_ops) <pid_to_str>: Change return type.
13750         (target_pid_to_str, normal_pid_to_str): Likewise.
13751         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
13752         type.
13753         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
13754         type.
13755         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
13756         return type.
13757         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
13758         type.
13759         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
13760         type.
13761         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
13762         return type.
13763
13764 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
13765
13766         * NEWS: Mention that the new default MI version is 3.  Mention
13767         changes to the output of commands and events that deal with
13768         multi-location breakpoints.
13769         * breakpoint.c: Include "mi/mi-out.h".
13770         (print_one_breakpoint): Change output syntax if using MI version
13771         >= 3.
13772         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
13773         New.
13774         (mi_multi_location_breakpoint_output_fixed): New.
13775         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
13776         (mi_cmd_fix_multi_location_breakpoint_output): New.
13777         (mi_multi_location_breakpoint_output_fixed): New.
13778         * mi/mi-cmds.c (mi_cmds): Register command
13779         -fix-multi-location-breakpoint-output.
13780         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
13781         interpreter "mi".
13782
13783 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
13784
13785         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
13786         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
13787         instantiate mi_ui_out based on interpreter name.
13788         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
13789         * mi/mi-main.c (mi_load_progress): Likewise.
13790
13791 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13792
13793         * NEWS: Combine separate "New targets" sections for 8.3.
13794
13795 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13796
13797         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
13798         (ppcfbsd_init_abi): Install gdbarch
13799         "fetch_tls_load_module_address" and "get_thread_local_address"
13800         methods.
13801
13802 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13803
13804         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
13805         (riscv_fbsd_init_abi): Install gdbarch
13806         "fetch_tls_load_module_address" and "get_thread_local_address"
13807         methods.
13808
13809 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13810
13811         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
13812         (i386fbsd_init_abi): Install gdbarch
13813         "fetch_tls_load_module_address" and "get_thread_local_address"
13814         methods.
13815
13816 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13817
13818         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
13819         (amd64fbsd_init_abi): Install gdbarch
13820         "fetch_tls_load_module_address" and "get_thread_local_address"
13821         methods.
13822
13823 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13824
13825         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
13826         (struct fbsd_pspace_data): New type.
13827         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
13828         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
13829         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
13830         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
13831         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
13832
13833 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13834
13835         * gdbtypes.c (lookup_struct_elt): New function.
13836         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
13837         * gdbtypes.h (struct struct_elt): New type.
13838         (lookup_struct_elt): New prototype.
13839
13840 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13841
13842         * gdbtypes.c (lookup_struct_elt_type): Update comment and
13843         remove disabled code block.
13844
13845 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13846
13847         * gdbarch.sh (get_thread_local_address): New method.
13848         * gdbarch.h, gdbarch.c: Regenerate.
13849         * target.c (target_translate_tls_address): Use
13850         gdbarch_get_thread_local_address if present instead of
13851         target::get_thread_local_address.
13852
13853 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13854
13855         * target.h (target::get_thread_local_address): Update comment.
13856
13857 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13858
13859         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
13860         objfile->separate_debug_objfile_backlink if not NULL.
13861
13862 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13863
13864         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
13865         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
13866         (amd64bsd_store_inferior_registers): Likewise.
13867         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
13868         Enable segment base registers.
13869         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
13870         PT_GETFSBASE and PT_GETGSBASE.
13871         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
13872         PT_SETGSBASE.
13873         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
13874         segment base registers.
13875         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
13876
13877 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13878
13879         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
13880         Update calls to i386_target_description to add 'segments'
13881         parameter.
13882         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
13883         add segment base registers.
13884         * arch/i386.c (i386_create_target_description): Add 'segments'
13885         parameter to enable segment base registers.
13886         * arch/i386.h (i386_create_target_description): Likewise.
13887         * features/i386/32bit-segments.xml: New file.
13888         * features/i386/32bit-segments.c: Generate.
13889         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
13890         call to i386_target_description to add 'segments' parameter.
13891         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
13892         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
13893         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
13894         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
13895         if feature is present.
13896         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
13897         Add 'segments' parameter to call to i386_target_description.
13898         (i386_target_description): Add 'segments' parameter to enable
13899         segment base registers.
13900         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
13901         to call to i386_target_description.
13902         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
13903         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
13904         Define I386_NUM_REGS.
13905         (i386_target_description): Add 'segments' parameter to enable
13906         segment base registers.
13907
13908 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
13909
13910         PR/24325
13911         * source-cache.c: #undef open and close, to avoid unresolved
13912         externals during linking.
13913
13914 2019-03-12  Tom Tromey  <tromey@adacore.com>
13915
13916         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
13917         const.  Add initializers.
13918         (_initialize_remote): Don't initialize ptid globals.
13919
13920 2019-03-12  Pedro Alves  <palves@redhat.com>
13921
13922         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
13923
13924 2019-03-12  Pedro Alves  <palves@redhat.com>
13925
13926         * cp-name-parser.y (main): Remove unused 'len' variable.
13927
13928 2019-03-12  Tom Tromey  <tromey@adacore.com>
13929
13930         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
13931         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
13932
13933 2019-03-12  Tom Tromey  <tromey@adacore.com>
13934
13935         * linux-nat.c (iterate_over_lwps): Update.
13936         (stop_callback): Remove parameter.
13937         (stop_wait_callback, detach_callback, resume_set_callback)
13938         (select_singlestep_lwp_callback, set_ignore_sigint)
13939         (status_callback, resumed_callback, resume_clear_callback)
13940         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
13941         data parameter.
13942         (linux_nat_target::detach, linux_nat_target::resume)
13943         (linux_stop_and_wait_all_lwps, select_event_lwp)
13944         (linux_nat_filter_event, linux_nat_wait_1)
13945         (linux_nat_target::kill, linux_nat_target::stop)
13946         (linux_nat_target::stop): Update.
13947         (linux_nat_resume_callback): Change type.
13948         (resume_stopped_resumed_lwps, count_events_callback)
13949         (select_event_lwp_callback): Likewise.
13950         (linux_stop_lwp, linux_nat_stop_lwp): Update.
13951         * arm-linux-nat.c (struct update_registers_data): Remove.
13952         (update_registers_callback): Change type.
13953         (arm_linux_insert_hw_breakpoint1): Update.
13954         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
13955         parameter.
13956         (x86_linux_dr_set_addr): Update.
13957         (x86_linux_dr_set_control): Update.
13958         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
13959         (iterate_over_lwps): Use gdb::function_view.
13960         * nat/aarch64-linux-hw-point.c (struct
13961         aarch64_dr_update_callback_param): Remove.
13962         (debug_reg_change_callback): Change type.
13963         (aarch64_notify_debug_reg_change): Update.
13964         * s390-linux-nat.c (s390_refresh_per_info): Update.
13965
13966 2019-03-11  Tom Tromey  <tromey@adacore.com>
13967
13968         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
13969         redundant assignment to "this_cu".
13970
13971 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13972
13973         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
13974
13975 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13976
13977         * gdbtypes.c (rank_one_type_parm_set): New function extracted
13978         from...
13979         (rank_one_type): ... this.
13980
13981 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13982
13983         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
13984         from...
13985         (rank_one_type): ... this.
13986
13987 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13988
13989         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
13990         from...
13991         (rank_one_type): ... this.
13992
13993 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13994
13995         * gdbtypes.c (rank_one_type_parm_float): New function extracted
13996         from...
13997         (rank_one_type): ... this.
13998
13999 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
14000
14001         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
14002         from...
14003         (rank_one_type): ... this.
14004
14005 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
14006
14007         * gdbtypes.c (rank_one_type_parm_range): New function extracted
14008         from...
14009         (rank_one_type): ... this.
14010
14011 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
14012
14013         * gdbtypes.c (rank_one_type_parm_char): New function extracted
14014         from...
14015         (rank_one_type): ... this.
14016
14017 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
14018
14019         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
14020         from...
14021         (rank_one_type): ... this.
14022
14023 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
14024
14025         * gdbtypes.c (rank_one_type_parm_int): New function extracted
14026         from...
14027         (rank_one_type): ... this.
14028
14029 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
14030
14031         * gdbtypes.c (rank_one_type_parm_func): New function extracted
14032         from...
14033         (rank_one_type): ... this.
14034
14035 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
14036
14037         * gdbtypes.c (rank_one_type_parm_array): New function extracted
14038         from...
14039         (rank_one_type): ... this.
14040
14041 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
14042
14043         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
14044         from...
14045         (rank_one_type): ... this.
14046
14047 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14048
14049         * inferior.c (initialize_inferiors): Ensure 'help set/show print
14050         inferior-events' shows the example events.
14051
14052 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
14053
14054         Support styling on native MS-Windows console
14055
14056         PR/24315
14057         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
14058         on MS-Windows if $TERM is not defined.
14059
14060         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
14061
14062         * posix-hdep.c (gdb_console_fputs):
14063         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
14064         functions.
14065         * ui-file.h (gdb_console_fputs): Add prototype.
14066
14067         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
14068         back to fputs only if the former returns zero.
14069
14070 2019-03-07  Tom Tromey  <tom@tromey.com>
14071
14072         * symmisc.c (print_symbol_bcache_statistics): Update.
14073         (print_objfile_statistics): Update.
14074         * symfile.c (allocate_symtab): Update.
14075         * stabsread.c: Don't include bcache.h.
14076         * psymtab.h (struct psymbol_bcache): Don't declare.
14077         (class psymtab_storage) <psymbol_cache>: Now a bcache.
14078         (psymbol_bcache_init, psymbol_bcache_free)
14079         (psymbol_bcache_get_bcache): Don't declare.
14080         * psymtab.c (struct psymbol_bcache): Remove.
14081         (psymtab_storage::psymtab_storage): Update.
14082         (psymtab_storage::~psymtab_storage): Update.
14083         (psymbol_bcache_init, psymbol_bcache_free)
14084         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
14085         (add_psymbol_to_bcache): Update.
14086         (allocate_psymtab): Update.
14087         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
14088         macro_cache>: No longer pointers.
14089         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
14090         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
14091         * macrotab.c (macro_bcache): Update.
14092         * macroexp.c: Don't include bcache.h.
14093         * gdbtypes.c (check_types_worklist): Update.
14094         (types_deeply_equal): Remove TRY/CATCH.  Update.
14095         * elfread.c (elf_symtab_read): Update.
14096         * dwarf2read.c: Don't include bcache.h.
14097         * buildsym.c (buildsym_compunit::get_macro_table): Update.
14098         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
14099         (print_bcache_statistics, bcache_memory_used): Don't declare.
14100         (struct bcache): Move from bcache.c.  Add constructor, destructor,
14101         methods.  Rename all data members.
14102         * bcache.c (struct bcache): Move to bcache.h.
14103         (bcache::expand_hash_table): Rename from expand_hash_table.
14104         (bcache): Remove.
14105         (bcache::insert): Rename from bcache_full.
14106         (bcache::compare): Rename from bcache_compare.
14107         (bcache_xmalloc): Remove.
14108         (bcache::~bcache): Rename from bcache_xfree.
14109         (bcache::print_statistics): Rename from print_bcache_statistics.
14110         (bcache::memory_used): Rename from bcache_memory_used.
14111
14112 2019-03-07  Pedro Alves  <palves@redhat.com>
14113
14114         * infrun.c (normal_stop): Also check for
14115         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
14116
14117 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
14118
14119         * f-lang.c (value_from_host_double): Moved to...
14120         * value.c (value_from_host_double): ...here.
14121         * value.h (value_from_host_double): Declare.
14122         * guile/scm-math.c (vlscm_convert_typed_number): Use
14123         value_from_host_double.
14124         (vlscm_convert_number): Likewise.
14125         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
14126         * python/py-value.c (convert_value_from_python): Likewise.
14127
14128 2019-03-06  Tom Tromey  <tom@tromey.com>
14129
14130         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
14131
14132 2019-03-06  Tom Tromey  <tom@tromey.com>
14133
14134         * utils.h (free_current_contents): Don't declare.
14135         * utils.c (free_current_contents): Remove.
14136
14137 2019-03-06  Tom Tromey  <tom@tromey.com>
14138
14139         * top.c (quit_force): Update.
14140         * main.c (captured_command_loop): Update.
14141         * common/new-op.c (operator new): Update.
14142         * common/common-exceptions.c (struct catcher)
14143         <save_cleanup_chain>: Remove member.
14144         (exceptions_state_mc_init): Update.
14145         (exception_try_scope_entry): Return nullptr.
14146         (exception_try_scope_exit, exception_rethrow)
14147         (throw_exception_sjlj, throw_exception_cxx): Update.
14148         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
14149         (all_cleanups, do_cleanups, discard_cleanups)
14150         (discard_final_cleanups, save_cleanups, save_final_cleanups)
14151         (restore_cleanups, restore_final_cleanups): Don't declare.
14152         (do_final_cleanups): Remove parameter.
14153         * common/cleanups.c (cleanup_chain, make_cleanup)
14154         (make_cleanup_dtor, all_cleanups, do_cleanups)
14155         (discard_my_cleanups, discard_cleanups)
14156         (discard_final_cleanups, save_my_cleanups, save_cleanups)
14157         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
14158         (null_cleanup): Remove.
14159         (do_final_cleanups): Remove parameter.
14160
14161 2019-03-06  Tom Tromey  <tom@tromey.com>
14162
14163         * remote.c (remote_target::remote_parse_stop_reply): Use
14164         unique_xmalloc_ptr.
14165
14166 2019-03-06  Tom Tromey  <tom@tromey.com>
14167
14168         * stabsread.c (struct stabs_field_info): Rename from field_info.
14169         <list, fnlist>: Add initializers.
14170         <obstack>: New member.
14171         (read_member_functions, read_struct_fields, read_baseclasses):
14172         Allocate on obstack.  Don't use cleanups.
14173         (read_one_struct_field, read_member_functions, read_struct_fields)
14174         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
14175         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
14176         (read_struct_type): Update.
14177
14178 2019-03-06  Tom Tromey  <tom@tromey.com>
14179
14180         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
14181         * common/filestuff.h (make_cleanup_close): Don't declare.
14182         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
14183         Remove.
14184
14185 2019-03-06  Tom Tromey  <tom@tromey.com>
14186
14187         * solib-aix.c: Use make_scope_exit.
14188
14189 2019-03-06  Tom Tromey  <tom@tromey.com>
14190
14191         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
14192         Use make_scope_exit.
14193
14194 2019-03-06  Tom Tromey  <tom@tromey.com>
14195
14196         * solib-svr4.c (disable_probes_interface): Remove parameter.
14197         (svr4_handle_solib_event): Use make_scope_exit.
14198
14199 2019-03-06  Tom Tromey  <tom@tromey.com>
14200
14201         * remote.c (struct stop_reply_deleter): Remove.
14202         (stop_reply_up): Update.
14203         (struct stop_reply): Derive from notif_event.  Don't typedef.
14204         <regcache>: Now a std::vector.
14205         (stop_reply_xfree): Remove.
14206         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
14207         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
14208         (remote_target::discard_pending_stop_replies): Use delete.
14209         (remote_target::remote_parse_stop_reply): Update.
14210         (remote_target::process_stop_reply): Update.
14211         * remote-notif.h (struct notif_event): Add virtual destructor.
14212         Remove "dtr" member.
14213         (struct notif_client) <alloc_event>: Return a unique_ptr.
14214         (notif_event_xfree): Don't declare.
14215         (notif_event_up): New typedef.
14216         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
14217         (notif_event_xfree, do_notif_event_xfree): Remove.
14218         (remote_notif_state_xfree): Update.
14219
14220 2019-03-06  Tom Tromey  <tom@tromey.com>
14221
14222         * infrun.c (displaced_step_clear_cleanup): Now a
14223         forward_scope_exit type.
14224         (displaced_step_prepare_throw): Update.
14225         (displaced_step_fixup): Update.
14226
14227 2019-03-06  Tom Tromey  <tom@tromey.com>
14228
14229         * inferior.h (class inferior): Update comment.
14230         * gdbthread.h (class thread_info): Update comment.
14231
14232 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
14233             Tom Tromey  <tom@tromey.com>
14234
14235         * stabsread.h (struct stab_section_list): Remove.
14236         (coffstab_build_psymtabs): Update.
14237         * dbxread.c (symbuf_sections): Now a std::vector.
14238         (sect_idx): New global.
14239         (fill_symbuf): Update.
14240         (coffstab_build_psymtabs): Change type of stabsects parameter.
14241         Update.
14242         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
14243         std::vector.
14244         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
14245         (coff_locate_sections): Update.
14246         (coff_symfile_read): Remove cleanups.  Update.
14247         (init_stringtab): Add storage parameter.
14248         (free_stringtab, free_stringtab_cleanup): Remove.
14249         (init_lineno): Add storage parameter.
14250         (free_linetab, free_linetab_cleanup): Remove.
14251
14252 2019-03-06  Pedro Alves  <palves@redhat.com>
14253
14254         * linux-fork.c (fork_info::clobber_regs): Delete.
14255         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
14256         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
14257         comment.  Adjust.
14258         (scoped_switch_fork_info::scoped_switch_fork_info)
14259         (checkpoint_command, linux_fork_context): Adjust
14260         fork_save_infrun_state calls.
14261
14262 2019-03-06  Pedro Alves  <palves@redhat.com>
14263
14264         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
14265         (inf_has_multiple_threads): Return 'bool' and rewrite using
14266         inferior_info::threads().
14267
14268 2019-03-06  Pedro Alves  <palves@redhat.com>
14269
14270         * linux-fork.c: Include <list>.
14271         (fork_list): Now a std::list instance.
14272         (fork_info): Add ctor, dtor, and in-class initialize all fields.
14273         (forks_exist_p, find_last_fork): Adjust.
14274         (new_fork): Delete.
14275         (one_fork_p): New.
14276         (add_fork): Adjust.
14277         (free_fork): Delete, folded into fork_info::~fork_info().
14278         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
14279         Adjust.
14280         (init_fork_list): Delete.
14281         (linux_fork_killall, linux_fork_mourn_inferior)
14282         (linux_fork_detach, info_checkpoints_command): Adjust.
14283         (_initialize_linux_fork): No longer call init_fork_list.
14284
14285 2019-03-06  Pedro Alves  <palves@redhat.com>
14286
14287         * linux-fork.c (new_fork): New, split out of ...
14288         (add_fork): ... this.  Return void.  Move "first fork" special
14289         case from here, to ...
14290         (checkpoint_command): ... here.
14291         * linux-linux.h (add_fork): Return void.
14292
14293 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
14294
14295         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
14296
14297 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
14298             Chris January  <chris.january@arm.com>
14299             David Lecomber  <david.lecomber@arm.com>
14300
14301         * f-exp.y: New token, UNOP_INTRINSIC.
14302         (exp): New pattern using UNOP_INTRINSIC token.
14303         (f77_keywords): Add 'abs' keyword.
14304         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
14305         (value_from_host_double): New function.
14306         (evaluate_subexp_f): Support UNOP_ABS.
14307
14308 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
14309
14310         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
14311         types.
14312
14313 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
14314
14315         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
14316         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
14317         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
14318
14319 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
14320
14321         * f-exp.y (convert_to_kind_type): Handle more type kinds.
14322
14323 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
14324             Chris January  <chris.january@arm.com>
14325
14326         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
14327         * f-exp.y: Define 'KIND' token.
14328         (exp): New pattern for KIND expressions.
14329         (ptype): Handle types with a kind extension.
14330         (direct_abs_decl): Extend to spot kind extensions.
14331         (f77_keywords): Add 'kind' to the list.
14332         (push_kind_type): New function.
14333         (convert_to_kind_type): New function.
14334         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
14335         * parse.c (operator_length_standard): Likewise.
14336         * parser-defs.h (enum type_pieces): Add tp_kind.
14337         * std-operator.def: Add UNOP_KIND.
14338
14339 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
14340
14341         * f-exp.y (f_parse): Set yydebug.
14342
14343 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
14344
14345         * f-lang.c (evaluate_subexp_f): New function.
14346         (exp_descriptor_f): New global.
14347         (f_language_defn): Use exp_descriptor_f instead of
14348         exp_descriptor_standard.
14349
14350 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
14351
14352         * f-exp.y (struct token): Add comments.
14353         (dot_ops): Remove uppercase versions and the end marker.
14354         (f77_keywords): Likewise.
14355         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
14356         entries in the dot_ops array are case insensitive, and use
14357         strncasecmp to compare strings.  Also some whitespace cleanup in
14358         this area.  Similar for the f77_keywords array, except entries in
14359         this list might be case sensitive.
14360
14361 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
14362
14363         * f-exp.y (struct f77_boolean_val): Add comments.
14364         (boolean_values): Remove uppercase versions, and end marker.
14365         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
14366         and use strncasecmp to achieve case insensitivity.  Additionally,
14367         perform whitespace cleanup around this code.
14368
14369 2019-03-06  Tom Tromey  <tromey@adacore.com>
14370
14371         * remote-sim.c (gdbsim_target_open): Use result of
14372         gdb_argv::release.
14373
14374 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
14375         Dirk Schubert  <dirk.schubert@arm.com>
14376         Chris January  <chris.january@arm.com>
14377
14378         * eval.c (evaluate_subexp_standard): Call Fortran argument
14379         wrapping logic.
14380         * f-lang.c (struct value): A value which can be passed into a
14381         Fortran function call.
14382         (fortran_argument_convert): Wrap Fortran arguments in a pointer
14383         where appropriate.
14384         (struct type): Value ready for a Fortran function call.
14385         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
14386         is needed.
14387         * f-lang.h (fortran_argument_convert): Declaration.
14388         (fortran_preserve_arg_pointer): Declaration.
14389         * infcall.c (value_arg_coerce): Call Fortran argument logic.
14390
14391 2019-03-05  Tom Tromey  <tromey@adacore.com>
14392
14393         * python/py-prettyprint.c (print_string_repr): Remove #if.
14394         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
14395
14396 2019-03-05  Tom Tromey  <tromey@adacore.com>
14397
14398         * target.c (the_dummy_target): Move later.  Change type to
14399         "dummy_target".
14400         (initialize_targets): Don't initialize the_dummy_target.
14401
14402 2019-03-05  Tom Tromey  <tromey@adacore.com>
14403
14404         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
14405         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
14406
14407 2019-03-05  Tom Tromey  <tromey@adacore.com>
14408
14409         * windows-nat.c (windows_nat_target::attach)
14410         (windows_nat_target::detach): Don't call gdb_flush.
14411         * valprint.c (generic_val_print, val_print, val_print_string):
14412         Don't call gdb_flush.
14413         * utils.c (defaulted_query): Don't call gdb_flush.
14414         * typeprint.c (print_type_scalar): Don't call gdb_flush.
14415         * target.c (target_announce_detach): Don't call gdb_flush.
14416         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
14417         * remote.c (extended_remote_target::attach): Don't call
14418         gdb_flush.
14419         * procfs.c (procfs_target::detach): Don't call gdb_flush.
14420         * printcmd.c (do_examine): Don't call gdb_flush.
14421         (info_display_command): Don't call gdb_flush.
14422         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
14423         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
14424         * memattr.c (info_mem_command): Don't call gdb_flush.
14425         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
14426         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
14427         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
14428         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
14429         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
14430         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
14431         (gnu_nat_target::detach): Don't call gdb_flush.
14432         * f-valprint.c (f_val_print): Don't call gdb_flush.
14433         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
14434         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
14435         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
14436         gdb_flush.
14437         * c-valprint.c (c_val_print): Don't call gdb_flush.
14438         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
14439
14440 2019-03-05  Tom Tromey  <tromey@adacore.com>
14441
14442         * varobj.c (update_dynamic_varobj_children): Update.
14443         (install_default_visualizer): Use reset, not release.
14444         * value.c (set_internalvar): Update.
14445         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
14446         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
14447         ATTRIBUTE_UNUSED_RESULT.
14448
14449 2019-03-05  Tom Tromey  <tromey@adacore.com>
14450
14451         * remote.c (class scoped_remote_fd) <release>: Add
14452         ATTRIBUTE_UNUSED_RESULT.
14453
14454 2019-03-05  Tom Tromey  <tromey@adacore.com>
14455
14456         * macroexp.c (struct macro_buffer) <release>: Add
14457         ATTRIBUTE_UNUSED_RESULT.
14458
14459 2019-03-05  Tom Tromey  <tromey@adacore.com>
14460
14461         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
14462         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
14463         ATTRIBUTE_UNUSED_RESULT.
14464
14465 2019-03-05  Tom Tromey  <tromey@adacore.com>
14466
14467         * common/scoped_fd.h (class scoped_fd) <release>: Add
14468         ATTRIBUTE_UNUSED_RESULT.
14469
14470 2019-03-05  Tom Tromey  <tromey@adacore.com>
14471
14472         * parser-defs.h (struct parser_state) <release>: Add
14473         ATTRIBUTE_UNUSED_RESULT.
14474
14475 2019-03-05  Tom Tromey  <tromey@adacore.com>
14476
14477         * utils.h (class gdb_argv) <release>: Add
14478         ATTRIBUTE_UNUSED_RESULT.
14479         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
14480
14481 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
14482
14483         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
14484         for-loop range, to avoid compiler warnings.
14485
14486         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
14487         avoid compiler warnings about unused variables.
14488
14489         * NEWS: Mention end of support for native debugging on MS-Windows
14490         before XP.
14491
14492         PR gdb/24292
14493         * common/netstuff.c:
14494         * gdbserver/gdbreplay.c
14495         * gdbserver/remote-utils.c:
14496         * ser-tcp.c:
14497         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
14498         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
14499         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
14500         'getaddrinfo' and 'freeaddrinfo' were not available before
14501         Windows XP, and mingw.org's MinGW headers by default define
14502         _WIN32_WINNT to 0x500.
14503
14504 2019-03-01  Gary Benson <gbenson@redhat.com>
14505
14506         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
14507
14508 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
14509             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
14510
14511         PR gdb/8527
14512         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
14513         set_sigint_trap, clear_sigint_trap.
14514
14515 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14516
14517         * target.c (target_detach): Clear the regcache and the
14518         frame cache.
14519
14520 2019-02-27  Pedro Alves  <palves@redhat.com>
14521
14522         * utils.c (set_screen_size): When we cap the height/width sizes,
14523         tweak the corresponding command variable to show "unlimited":
14524
14525 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
14526             Pedro Alves  <palves@redhat.com>
14527
14528         * utils.c (set_screen_size): Reduce "infinite" rows and columns
14529         before calling rl_set_screen_size.
14530
14531 2019-02-27  Tom Tromey  <tromey@adacore.com>
14532
14533         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
14534         define.
14535         * python/py-value.c: Remove Python 2.4 workaround.
14536         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
14537         workaround.
14538         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
14539         Python 2.4 workaround.
14540         * python/python-internal.h: Remove Python 2.4 comment.
14541         (Py_ssize_t): Don't define.
14542         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
14543         (gdb_Py_DECREF): Remove Python 2.4 workaround.
14544         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
14545         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
14546         * python/python.c (do_start_initialization): Remove Python 2.4
14547         workaround.
14548         * python/py-prettyprint.c (class dummy_python_frame): Remove.
14549         (print_children): Remove Python 2.4 workaround.
14550         * python/py-inferior.c (buffer_procs): Remove Python 2.4
14551         workaround.
14552         (CHARBUFFERPROC_NAME): Remove.
14553         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
14554         Python 2.4 workaround.
14555
14556 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
14557
14558         * NEWS: Note minimum Python version.
14559
14560 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
14561
14562         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
14563         code from these functions.  Remove corresponding ifdefs.  Use
14564         Py_buffer_up instead of explicit calls to PyBuffer_Release.
14565         Remove gotos and target of gotos.
14566         (infpy_search_memory): Likewise.
14567
14568 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14569
14570         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
14571         (hppa_gdbarch_init): Don't register deleted functions with
14572         gdbarch.
14573
14574 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14575
14576         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
14577         (h8300_unwind_sp): Delete.
14578         (h8300_dummy_id): Delete.
14579         (h8300_gdbarch_init): Don't register deleted functions with
14580         gdbarch.
14581
14582 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14583
14584         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
14585         (ft32_unwind_pc): Delete.
14586         (ft32_unwind_sp): Delete.
14587         (ft32_gdbarch_init): Don't register deleted functions with
14588         gdbarch.
14589
14590 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14591
14592         * gdb/frv-tdep.c (frv_dummy_id): Delete.
14593         (frv_unwind_pc): Delete.
14594         (frv_unwind_sp): Delete.
14595         (frv_gdbarch_init): Don't register deleted functions with
14596         gdbarch.
14597
14598 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14599
14600         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
14601         (riscv_unwind_pc): Delete.
14602         (riscv_unwind_sp): Delete.
14603         (riscv_gdbarch_init): Don't register deleted functions with
14604         gdbarch.
14605
14606 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14607
14608         * gdb/csky-tdep.c (csky_dummy_id): Delete.
14609         (csky_unwind_pc): Delete.
14610         (csky_unwind_sp): Delete.
14611         (csky_gdbarch_init): Don't register deleted functions with
14612         gdbarch.
14613
14614 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14615
14616         * gdb/cris-tdep.c (cris_dummy_id): Delete.
14617         (cris_unwind_pc): Delete.
14618         (cris_unwind_sp): Delete.
14619         (cris_gdbarch_init): Don't register deleted functions with
14620         gdbarch.
14621
14622 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14623
14624         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
14625         (bfin_unwind_pc): Delete.
14626         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
14627
14628 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14629
14630         * gdb/arm-tdep.c (arm_dummy_id): Delete.
14631         (arm_unwind_pc): Delete.
14632         (arm_unwind_sp): Delete.
14633         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
14634
14635 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14636
14637         * gdb/arc-tdep.c (arc_dummy_id): Delete.
14638         (arc_unwind_pc): Delete.
14639         (arc_unwind_sp): Delete.
14640         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
14641
14642 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14643
14644         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
14645         (alpha_unwind_pc): Delete.
14646         (alpha_gdbarch_init): Don't register deleted functions with
14647         gdbarch.
14648
14649 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14650
14651         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
14652         (aarch64_unwind_pc): Delete.
14653         (aarch64_unwind_sp): Delete.
14654         (aarch64_gdbarch_init): Don't register deleted functions with
14655         gdbarch.
14656
14657 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14658
14659         * gdbtypes.c (type_align): Don't consider static members when
14660         computing structure alignment.
14661
14662 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14663
14664         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
14665         return 0 for other types.
14666         * arch-utils.c (default_type_align): Always return 0.
14667         * gdbarch.h: Regenerate.
14668         * gdbarch.sh (type_align): Extend comment.
14669         * gdbtypes.c (type_align): Add additional comments, always call
14670         gdbarch_type_align before applying the default rules.
14671         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
14672         generic code will then apply a suitable default.
14673         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
14674         types, return 0 for other types.
14675
14676 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
14677
14678         * NEWS: Create a new section for the next release branch.
14679         Rename the section of the current branch, now that it has
14680         been cut.
14681
14682 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
14683
14684         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
14685         * version.in: Bump version to 8.3.50.DATE-git.
14686
14687 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
14688
14689         * aix-thread.c (ptid_cmp): Remove unused variable.
14690         (get_signaled_thread): Likewise.
14691         (store_regs_user_thread): Likewise.
14692         (store_regs_kernel_thread): Likewise.
14693         (fetch_regs_kernel_thread): Remove shadowed variable.
14694
14695 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
14696
14697         * features/riscv/32bit-cpu.xml: Add register numbers.
14698         * features/riscv/32bit-fpu.c: Regenerate.
14699         * features/riscv/32bit-fpu.xml: Add register numbers.
14700         * features/riscv/64bit-cpu.xml: Add register numbers.
14701         * features/riscv/64bit-fpu.c: Regenerate.
14702         * features/riscv/64bit-fpu.xml: Add register numbers.
14703
14704 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
14705
14706         * NEWS: Mention two argument form of gdb.Value constructor.
14707         * python/py-value.c (convert_buffer_and_type_to_value): New
14708         function.
14709         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
14710         Add support for handling an optional second argument.  Call
14711         convert_buffer_and_type_to_value as appropriate.
14712         * python/python-internal.h (Py_buffer_deleter): New struct.
14713         (Py_buffer_up): New typedef.
14714
14715 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
14716
14717         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
14718         instead of releasing ownership.
14719
14720 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
14721
14722         * dwarf2read.c (open_and_init_dwp_file): Call
14723         elf_numsections instead of bfd_count_sections to initialize
14724         dwp_file->num_sections.
14725
14726 2019-02-25  Tom Tromey  <tromey@adacore.com>
14727
14728         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
14729
14730 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
14731
14732         * gcore.in: Add '--readnever' option when invoking GDB.
14733
14734 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
14735
14736         * MAINTAINERS: Update my email address.
14737
14738 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
14739
14740         * build-id.c (build_id_to_debug_bfd_1): New function.
14741         (build_id_to_debug_bfd): Look for separate debug file in
14742         sysroot.
14743
14744 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
14745
14746         * gdbarch.sh: Update the copyright year range that is placed into
14747         generated files.
14748
14749 2019-02-22  Keith Seitz  <keiths@redhat.com>
14750
14751         PR symtab/23853
14752         * linespec.c (create_sals_line_offset): Search for the default
14753         symtab's filename instead of its fullname.
14754
14755 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
14756
14757         * NEWS: Update style defaults.
14758
14759 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
14760
14761         * main.c (captured_main_1): Disable styling in batch mode.
14762
14763 2019-02-20  Tom Tromey  <tom@tromey.com>
14764
14765         * symtab.c (symtab_symbol_info): Fix typos.
14766
14767 2019-02-20  Tom Tromey  <tromey@adacore.com>
14768
14769         * findcmd.c (_initialize_mem_search): Use upper case for
14770         metasyntactic variables.
14771
14772 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
14773
14774         * aarch64-tdep.c (aarch64_add_reggroups): New function.
14775         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
14776
14777 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
14778
14779         * top.h (source_file_name): Change to std::string.
14780         * top.c (source_file_name): Likewise.
14781         (command_line_input): Adjust.
14782         * cli/cli-script.c (script_from_file): Adjust.
14783
14784 2019-02-19  Tom Tromey  <tromey@adacore.com>
14785
14786         * ravenscar-thread.c
14787         (ravenscar_thread_target::update_thread_list): Don't call
14788         ada_build_task_list.
14789         * ada-lang.h (ada_build_task_list): Don't declare.
14790         * ada-tasks.c (struct ada_tasks_inferior_data)
14791         <task_list_valid_p>: Now bool.
14792         (read_known_tasks, ada_task_list_changed)
14793         (ada_tasks_invalidate_inferior_data): Update.
14794         (read_known_tasks_array): Return bool.
14795         (read_known_tasks_list): Likewise.
14796         (read_known_tasks): Return void.
14797         (ada_build_task_list): Now static.
14798
14799 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
14800
14801         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
14802         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
14803
14804 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14805
14806         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
14807         variant for ada_tasks_pspace_data_handle and
14808         ada_tasks_inferior_data_handle.
14809         (ada_tasks_pspace_data_cleanup): New function.
14810         (ada_tasks_inferior_data_cleanup): New function.
14811
14812 2019-02-17  Tom Tromey  <tom@tromey.com>
14813
14814         * macrotab.h (macro_source_fullname): Return a std::string.
14815         * macrotab.c (macro_include, check_for_redefinition)
14816         (macro_undef, macro_lookup_definition, foreach_macro)
14817         (foreach_macro_in_scope): Update.
14818         (macro_source_fullname): Return a std::string.
14819         * macrocmd.c (show_pp_source_pos): Update.
14820
14821 2019-02-17  Tom Tromey  <tom@tromey.com>
14822
14823         * macrocmd.c (show_pp_source_pos): Style the file names.
14824
14825 2019-02-17  Tom Tromey  <tom@tromey.com>
14826
14827         PR tui/24197:
14828         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
14829
14830 2019-02-17  Tom Tromey  <tom@tromey.com>
14831
14832         * ada-lang.c (user_select_syms): Use filtered printing.
14833         * utils.c (wrap_style): New global.
14834         (desired_style): Remove.
14835         (emit_style_escape): Add stream parameter.
14836         (set_output_style, reset_terminal_style, prompt_for_continue):
14837         Update.
14838         (flush_wrap_buffer): Only flush gdb_stdout.
14839         (wrap_here): Set wrap_style.
14840         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
14841         treat escape sequences as a character.  Change when wrap buffer is
14842         flushed.
14843         (fputs_styled): Do not set the output style when the default is
14844         requested.
14845         * ui-style.h (struct ui_file_style) <is_default>: New method.
14846         * source.c (print_source_lines_base): Emit escape sequences in one
14847         piece.
14848
14849 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
14850
14851         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
14852         integers and enumeration types.
14853
14854 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
14855
14856         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
14857         instead of lookup_symbol_in_language
14858         (do_exact_match): New function.
14859         (ada_get_symbol_name_matcher): Return do_exact_match when
14860         doing a verbatim match.
14861
14862 2019-02-15  Tom Tromey  <tromey@adacore.com>
14863
14864         * ravenscar-thread.c (ravenscar_thread_target::resume)
14865         (ravenscar_thread_target::wait): Special case wildcard requests.
14866
14867 2019-02-15  Tom Tromey  <tromey@adacore.com>
14868
14869         * ravenscar-thread.c (base_ptid): Remove.
14870         (struct ravenscar_thread_target) <close>: New method.
14871         <m_base_ptid>: New member.
14872         <update_inferior_ptid, active_task, task_is_currently_active,
14873         runtime_initialized>: Declare methods.
14874         <ravenscar_thread_target>: Add constructor.
14875         (ravenscar_thread_target::task_is_currently_active)
14876         (ravenscar_thread_target::update_inferior_ptid)
14877         (ravenscar_runtime_initialized): Rename.  Now methods.
14878         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
14879         (ravenscar_thread_target::update_thread_list): Update.
14880         (ravenscar_thread_target::active_task): Now method.
14881         (ravenscar_thread_target::store_registers)
14882         (ravenscar_thread_target::prepare_to_store)
14883         (ravenscar_thread_target::prepare_to_store)
14884         (ravenscar_thread_target::mourn_inferior): Update.
14885         (ravenscar_inferior_created): Use "new" to create target.
14886         (ravenscar_thread_target::get_ada_task_ptid): Update.
14887         (_initialize_ravenscar): Don't initialize base_ptid.
14888         (ravenscar_ops): Remove global.
14889
14890 2019-02-15  Tom Tromey  <tromey@adacore.com>
14891
14892         * target.h (push_target): Declare new overload.
14893         * target.c (push_target): New overload, taking an rvalue reference.
14894         * remote.c (remote_target::open_1): Use push_target overload.
14895         * corelow.c (core_target_open): Use push_target overload.
14896
14897 2019-02-15  Tom Tromey  <tromey@adacore.com>
14898
14899         * ravenscar-thread.c (is_ravenscar_task)
14900         (ravenscar_task_is_currently_active): Return bool.
14901         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
14902         (_initialize_ravenscar): Remove "(void)".
14903         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
14904         Return bool.
14905
14906 2019-02-15  Tom Tromey  <tromey@adacore.com>
14907
14908         * ravenscar-thread.c (ravenscar_runtime_initializer)
14909         (has_ravenscar_runtime, get_running_thread_id)
14910         (ravenscar_thread_target::resume): Fix indentation.
14911
14912 2019-02-15  Tom Tromey  <tromey@adacore.com>
14913
14914         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
14915         from ravenscar_arch_ops.
14916         (sparc_ravenscar_ops::fetch_registers)
14917         (sparc_ravenscar_ops::store_registers): Now methods.
14918         (sparc_ravenscar_prepare_to_store): Remove.
14919         (sparc_ravenscar_ops): Redefine.
14920         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
14921         methods and destructor.  Remove members.
14922         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
14923         (ravenscar_thread_target::store_registers)
14924         (ravenscar_thread_target::prepare_to_store): Update.
14925         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
14926         Remove.
14927         (struct ppc_ravenscar_powerpc_ops): Derive from
14928         ravenscar_arch_ops.
14929         (ppc_ravenscar_powerpc_ops::fetch_registers)
14930         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
14931         (ppc_ravenscar_powerpc_ops): Redefine.
14932         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
14933         (ppc_ravenscar_e500_ops::fetch_registers)
14934         (ppc_ravenscar_e500_ops::store_registers): Now methods.
14935         (ppc_ravenscar_e500_ops): Redefine.
14936         * aarch64-ravenscar-thread.c
14937         (aarch64_ravenscar_generic_prepare_to_store): Remove.
14938         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
14939         (aarch64_ravenscar_fetch_registers)
14940         (aarch64_ravenscar_store_registers): Now methods.
14941         (aarch64_ravenscar_ops): Redefine.
14942
14943 2019-02-15  Tom Tromey  <tromey@adacore.com>
14944
14945         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
14946         (ravenscar_thread_target::stopped_by_hw_breakpoint)
14947         (ravenscar_thread_target::stopped_by_watchpoint)
14948         (ravenscar_thread_target::stopped_data_address)
14949         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
14950
14951 2019-02-15  Tom Tromey  <tromey@adacore.com>
14952
14953         * ravenscar-thread.c: Fix some typos.
14954
14955 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14956             Tom Tromey  <tromey@adacore.com>
14957
14958         * ada-lang.c (ada_exception_sal): Change addr_string to a
14959         std::string.
14960         (create_ada_exception_catchpoint): Update.
14961
14962 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14963             Tom Tromey  <tromey@adacore.com>
14964
14965         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
14966         (bp_location_ops): Remove.
14967         (base_breakpoint_allocate_location): Update.
14968         (free_bp_location): Update.
14969         * ada-lang.c (class ada_catchpoint_location)
14970         <ada_catchpoint_location>: Remove ops parameter.
14971         (ada_catchpoint_location_dtor): Remove.
14972         (ada_catchpoint_location_ops): Remove.
14973         (allocate_location_exception): Update.
14974         * breakpoint.h (struct bp_location_ops): Remove.
14975         (class bp_location) <bp_location>: Remove bp_location_ops
14976         parameter.
14977         <~bp_location>: Add destructor.
14978         <ops>: Remove.
14979
14980 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
14981             Pedro Alves  <palves@redhat.com>
14982
14983         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
14984         'PATH_MAX'.
14985
14986 2019-02-14  David Michael  <fedora.dm0@gmail.com>
14987             Samuel Thibault  <samuel.thibault@gnu.org>
14988             Thomas Schwinge  <thomas@codesourcery.com>
14989
14990         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
14991         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
14992
14993 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
14994
14995         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
14996         (check_empty): Use "const char *".
14997
14998         * gnu-nat.c (gnu_nat_target::detach): Instead of
14999         'detach_inferior (pid)' call
15000         'detach_inferior (find_inferior_pid (pid))'.
15001
15002         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
15003         'nat/fork-inferior.o'.
15004         * gnu-nat.c: #include "nat/fork-inferior.h".
15005
15006         * gnu-nat.c (gnu_nat_target::detach): Instead of
15007         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
15008         * gnu-nat.h: #include "inf-child.h".
15009         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
15010         'i386_gnu_nat_target::fetch_registers'.
15011         (gnu_store_registers): Rename/move to
15012         'i386_gnu_nat_target::store_registers'.
15013
15014         * config/i386/nm-i386gnu.h: Don't "#include" any files.
15015         * gnu-nat.h (mach_thread_info): New function.
15016         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
15017
15018         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
15019
15020 2019-02-14  Frederic Konrad  <konrad@adacore.com>
15021
15022         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
15023
15024 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
15025
15026         * windows-nat.c (windows_add_thread): Add new parameter
15027         "main_thread_p" with default value set to false.  Update
15028         function documentation as well as all callers.
15029         (windows_delete_thread): Likewise.
15030         (fake_create_process): Update call to windows_add_thread.
15031         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
15032         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
15033         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
15034         call to windows_delete_thread.
15035
15036 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
15037
15038         * MAINTAINERS: Add Andrew Burgess as global maintainer.
15039
15040 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
15041
15042         * symfile.c (find_separate_debug_file): Use canonical path of
15043         sysroot with child_path instead of gdb_sysroot if it is valid.
15044
15045 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
15046
15047         * symfile.c (find_separate_debug_file): Use child_path to
15048         determine if an object file is under a sysroot.
15049
15050 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
15051
15052         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
15053         unittests/child-path-selftests.c.
15054         * common/pathstuff.c (child_path): New function.
15055         * common/pathstuff.h (child_path): New prototype.
15056         * unittests/child-path-selftests.c: New file.
15057
15058 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
15059
15060         * symfile.c (find_separate_debug_file): Look for separate debug
15061         files in debug directories under the sysroot.
15062
15063 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
15064
15065         * symtab.h (struct minimal_symbol data_p): New const method.
15066         (struct minimal_symbol text_p): Likewise.
15067         * symtab.c (output_source_filename): Use file name style
15068         to print file name.
15069         (print_symbol_info): Likewise.
15070         (print_msymbol_info): Use address style to print addresses.
15071         Use function name style to print executable text symbols.
15072         (expand_symtab_containing_pc): Use data_p.
15073         (find_pc_sect_compunit_symtab): Likewise.
15074
15075 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
15076
15077         * breakpoint.c (describe_other_breakpoints): Use address style
15078         to print addresses.
15079         (say_where): Likewise.
15080
15081 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
15082
15083         * ada-typeprint.c (print_func_type): Print function name
15084         style to print function name.
15085         * c-typeprint.c (c_print_type_1): Likewise.
15086
15087 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
15088
15089         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
15090         for execve.
15091
15092 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
15093
15094         * c-exp.y (direct_abs_decl): Use emplace_back to record the
15095         type_stack.
15096
15097 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
15098
15099         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
15100         TYPE_CODE_REF types.
15101
15102 2019-02-08  Jim Wilson  <jimw@sifive.com>
15103
15104         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
15105         (riscv_linux_fregset): New.
15106         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
15107
15108 2019-02-07  Tom Tromey  <tom@tromey.com>
15109
15110         * thread.c (thread_cancel_execution_command): Update.
15111         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
15112         methods.
15113         (struct thread_fsm_ops): Remove.
15114         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
15115         (thread_fsm_should_stop, thread_fsm_return_value)
15116         (thread_fsm_set_finished, thread_fsm_finished_p)
15117         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
15118         Don't declare.
15119         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
15120         * infrun.c (clear_proceed_status_thread)
15121         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
15122         (print_stop_event): Update.
15123         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
15124         Add constructor.
15125         (step_command_fsm_ops): Remove.
15126         (new_step_command_fsm): Remove.
15127         (step_1): Update.
15128         (step_command_fsm::should_stop): Rename from
15129         step_command_fsm_should_stop.
15130         (step_command_fsm::clean_up): Rename from
15131         step_command_fsm_clean_up.
15132         (step_command_fsm::do_async_reply_reason): Rename from
15133         step_command_fsm_async_reply_reason.
15134         (struct until_next_fsm): Inherit from thread_fsm.  Add
15135         constructor.
15136         (until_next_fsm_ops): Remove.
15137         (new_until_next_fsm): Remove.
15138         (until_next_fsm::should_stop): Rename from
15139         until_next_fsm_should_stop.
15140         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
15141         (until_next_fsm::do_async_reply_reason): Rename from
15142         until_next_fsm_async_reply_reason.
15143         (struct finish_command_fsm): Inherit from thread_fsm.  Add
15144         constructor.  Change type of breakpoint.
15145         (finish_command_fsm_ops): Remove.
15146         (new_finish_command_fsm): Remove.
15147         (finish_command_fsm::should_stop): Rename from
15148         finish_command_fsm_should_stop.
15149         (finish_command_fsm::clean_up): Rename from
15150         finish_command_fsm_clean_up.
15151         (finish_command_fsm::return_value): Rename from
15152         finish_command_fsm_return_value.
15153         (finish_command_fsm::do_async_reply_reason): Rename from
15154         finish_command_fsm_async_reply_reason.
15155         (finish_command): Update.
15156         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
15157         Add constructor.
15158         (call_thread_fsm_ops): Remove.
15159         (call_thread_fsm::call_thread_fsm): Rename from
15160         new_call_thread_fsm.
15161         (call_thread_fsm::should_stop): Rename from
15162         call_thread_fsm_should_stop.
15163         (call_thread_fsm::should_notify_stop): Rename from
15164         call_thread_fsm_should_notify_stop.
15165         (run_inferior_call, call_function_by_hand_dummy): Update.
15166         * cli/cli-interp.c (should_print_stop_to_console): Update.
15167         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
15168         Add constructor.  Change type of location_breakpoint,
15169         caller_breakpoint.
15170         (until_break_fsm_ops): Remove.
15171         (new_until_break_fsm): Remove.
15172         (until_break_fsm::should_stop): Rename from
15173         until_break_fsm_should_stop.
15174         (until_break_fsm::clean_up): Rename from
15175         until_break_fsm_clean_up.
15176         (until_break_fsm::do_async_reply_reason): Rename from
15177         until_break_fsm_async_reply_reason.
15178         (until_break_command): Update.
15179         * thread-fsm.c: Remove.
15180         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
15181
15182 2019-02-07  Tom Tromey  <tom@tromey.com>
15183
15184         * yy-remap.h: Add include guard.
15185         * xtensa-tdep.h: Add include guard.
15186         * xcoffread.h: Rename include guard.
15187         * varobj-iter.h: Add include guard.
15188         * tui/tui.h: Rename include guard.
15189         * tui/tui-winsource.h: Rename include guard.
15190         * tui/tui-wingeneral.h: Rename include guard.
15191         * tui/tui-windata.h: Rename include guard.
15192         * tui/tui-win.h: Rename include guard.
15193         * tui/tui-stack.h: Rename include guard.
15194         * tui/tui-source.h: Rename include guard.
15195         * tui/tui-regs.h: Rename include guard.
15196         * tui/tui-out.h: Rename include guard.
15197         * tui/tui-layout.h: Rename include guard.
15198         * tui/tui-io.h: Rename include guard.
15199         * tui/tui-hooks.h: Rename include guard.
15200         * tui/tui-file.h: Rename include guard.
15201         * tui/tui-disasm.h: Rename include guard.
15202         * tui/tui-data.h: Rename include guard.
15203         * tui/tui-command.h: Rename include guard.
15204         * tic6x-tdep.h: Add include guard.
15205         * target/waitstatus.h: Rename include guard.
15206         * target/wait.h: Rename include guard.
15207         * target/target.h: Rename include guard.
15208         * target/resume.h: Rename include guard.
15209         * target-float.h: Rename include guard.
15210         * stabsread.h: Add include guard.
15211         * rs6000-tdep.h: Add include guard.
15212         * riscv-fbsd-tdep.h: Add include guard.
15213         * regformats/regdef.h: Rename include guard.
15214         * record.h: Rename include guard.
15215         * python/python.h: Rename include guard.
15216         * python/python-internal.h: Rename include guard.
15217         * python/py-stopevent.h: Rename include guard.
15218         * python/py-ref.h: Rename include guard.
15219         * python/py-record.h: Rename include guard.
15220         * python/py-record-full.h: Rename include guard.
15221         * python/py-record-btrace.h: Rename include guard.
15222         * python/py-instruction.h: Rename include guard.
15223         * python/py-events.h: Rename include guard.
15224         * python/py-event.h: Rename include guard.
15225         * procfs.h: Add include guard.
15226         * proc-utils.h: Add include guard.
15227         * p-lang.h: Add include guard.
15228         * or1k-tdep.h: Rename include guard.
15229         * observable.h: Rename include guard.
15230         * nto-tdep.h: Rename include guard.
15231         * nat/x86-linux.h: Rename include guard.
15232         * nat/x86-linux-dregs.h: Rename include guard.
15233         * nat/x86-gcc-cpuid.h: Add include guard.
15234         * nat/x86-dregs.h: Rename include guard.
15235         * nat/x86-cpuid.h: Rename include guard.
15236         * nat/ppc-linux.h: Rename include guard.
15237         * nat/mips-linux-watch.h: Rename include guard.
15238         * nat/linux-waitpid.h: Rename include guard.
15239         * nat/linux-ptrace.h: Rename include guard.
15240         * nat/linux-procfs.h: Rename include guard.
15241         * nat/linux-osdata.h: Rename include guard.
15242         * nat/linux-nat.h: Rename include guard.
15243         * nat/linux-namespaces.h: Rename include guard.
15244         * nat/linux-btrace.h: Rename include guard.
15245         * nat/glibc_thread_db.h: Rename include guard.
15246         * nat/gdb_thread_db.h: Rename include guard.
15247         * nat/gdb_ptrace.h: Rename include guard.
15248         * nat/fork-inferior.h: Rename include guard.
15249         * nat/amd64-linux-siginfo.h: Rename include guard.
15250         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
15251         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
15252         * nat/aarch64-linux.h: Rename include guard.
15253         * nat/aarch64-linux-hw-point.h: Rename include guard.
15254         * mn10300-tdep.h: Add include guard.
15255         * mips-linux-tdep.h: Add include guard.
15256         * mi/mi-parse.h: Rename include guard.
15257         * mi/mi-out.h: Rename include guard.
15258         * mi/mi-main.h: Rename include guard.
15259         * mi/mi-interp.h: Rename include guard.
15260         * mi/mi-getopt.h: Rename include guard.
15261         * mi/mi-console.h: Rename include guard.
15262         * mi/mi-common.h: Rename include guard.
15263         * mi/mi-cmds.h: Rename include guard.
15264         * mi/mi-cmd-break.h: Rename include guard.
15265         * m2-lang.h: Add include guard.
15266         * location.h: Rename include guard.
15267         * linux-record.h: Rename include guard.
15268         * linux-nat.h: Add include guard.
15269         * linux-fork.h: Add include guard.
15270         * i386-darwin-tdep.h: Rename include guard.
15271         * hppa-linux-offsets.h: Add include guard.
15272         * guile/guile.h: Rename include guard.
15273         * guile/guile-internal.h: Rename include guard.
15274         * gnu-nat.h: Rename include guard.
15275         * gdb-stabs.h: Rename include guard.
15276         * frv-tdep.h: Add include guard.
15277         * f-lang.h: Add include guard.
15278         * event-loop.h: Add include guard.
15279         * darwin-nat.h: Rename include guard.
15280         * cp-abi.h: Rename include guard.
15281         * config/sparc/nm-sol2.h: Rename include guard.
15282         * config/nm-nto.h: Rename include guard.
15283         * config/nm-linux.h: Add include guard.
15284         * config/i386/nm-i386gnu.h: Rename include guard.
15285         * config/djgpp/nl_types.h: Rename include guard.
15286         * config/djgpp/langinfo.h: Rename include guard.
15287         * compile/gcc-cp-plugin.h: Add include guard.
15288         * compile/gcc-c-plugin.h: Add include guard.
15289         * compile/compile.h: Rename include guard.
15290         * compile/compile-object-run.h: Rename include guard.
15291         * compile/compile-object-load.h: Rename include guard.
15292         * compile/compile-internal.h: Rename include guard.
15293         * compile/compile-cplus.h: Rename include guard.
15294         * compile/compile-c.h: Rename include guard.
15295         * common/xml-utils.h: Rename include guard.
15296         * common/x86-xstate.h: Rename include guard.
15297         * common/version.h: Rename include guard.
15298         * common/vec.h: Rename include guard.
15299         * common/tdesc.h: Rename include guard.
15300         * common/selftest.h: Rename include guard.
15301         * common/scoped_restore.h: Rename include guard.
15302         * common/scoped_mmap.h: Rename include guard.
15303         * common/scoped_fd.h: Rename include guard.
15304         * common/safe-iterator.h: Rename include guard.
15305         * common/run-time-clock.h: Rename include guard.
15306         * common/refcounted-object.h: Rename include guard.
15307         * common/queue.h: Rename include guard.
15308         * common/ptid.h: Rename include guard.
15309         * common/print-utils.h: Rename include guard.
15310         * common/preprocessor.h: Rename include guard.
15311         * common/pathstuff.h: Rename include guard.
15312         * common/observable.h: Rename include guard.
15313         * common/netstuff.h: Rename include guard.
15314         * common/job-control.h: Rename include guard.
15315         * common/host-defs.h: Rename include guard.
15316         * common/gdb_wait.h: Rename include guard.
15317         * common/gdb_vecs.h: Rename include guard.
15318         * common/gdb_unlinker.h: Rename include guard.
15319         * common/gdb_unique_ptr.h: Rename include guard.
15320         * common/gdb_tilde_expand.h: Rename include guard.
15321         * common/gdb_sys_time.h: Rename include guard.
15322         * common/gdb_string_view.h: Rename include guard.
15323         * common/gdb_splay_tree.h: Rename include guard.
15324         * common/gdb_setjmp.h: Rename include guard.
15325         * common/gdb_ref_ptr.h: Rename include guard.
15326         * common/gdb_optional.h: Rename include guard.
15327         * common/gdb_locale.h: Rename include guard.
15328         * common/gdb_assert.h: Rename include guard.
15329         * common/filtered-iterator.h: Rename include guard.
15330         * common/filestuff.h: Rename include guard.
15331         * common/fileio.h: Rename include guard.
15332         * common/environ.h: Rename include guard.
15333         * common/common-utils.h: Rename include guard.
15334         * common/common-types.h: Rename include guard.
15335         * common/common-regcache.h: Rename include guard.
15336         * common/common-inferior.h: Rename include guard.
15337         * common/common-gdbthread.h: Rename include guard.
15338         * common/common-exceptions.h: Rename include guard.
15339         * common/common-defs.h: Rename include guard.
15340         * common/common-debug.h: Rename include guard.
15341         * common/cleanups.h: Rename include guard.
15342         * common/buffer.h: Rename include guard.
15343         * common/btrace-common.h: Rename include guard.
15344         * common/break-common.h: Rename include guard.
15345         * cli/cli-utils.h: Rename include guard.
15346         * cli/cli-style.h: Rename include guard.
15347         * cli/cli-setshow.h: Rename include guard.
15348         * cli/cli-script.h: Rename include guard.
15349         * cli/cli-interp.h: Rename include guard.
15350         * cli/cli-decode.h: Rename include guard.
15351         * cli/cli-cmds.h: Rename include guard.
15352         * charset-list.h: Add include guard.
15353         * buildsym-legacy.h: Rename include guard.
15354         * bfin-tdep.h: Add include guard.
15355         * ax.h: Rename include guard.
15356         * arm-linux-tdep.h: Add include guard.
15357         * arm-fbsd-tdep.h: Add include guard.
15358         * arch/xtensa.h: Rename include guard.
15359         * arch/tic6x.h: Add include guard.
15360         * arch/i386.h: Add include guard.
15361         * arch/arm.h: Rename include guard.
15362         * arch/arm-linux.h: Rename include guard.
15363         * arch/arm-get-next-pcs.h: Rename include guard.
15364         * arch/amd64.h: Add include guard.
15365         * arch/aarch64-insn.h: Rename include guard.
15366         * arch-utils.h: Rename include guard.
15367         * annotate.h: Add include guard.
15368         * amd64-darwin-tdep.h: Rename include guard.
15369         * aarch64-linux-tdep.h: Add include guard.
15370         * aarch64-fbsd-tdep.h: Add include guard.
15371         * aarch32-linux-nat.h: Add include guard.
15372
15373 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
15374
15375         * macrotab.c (macro_define_internal): New function that
15376         factorizes macro_define_object_internal and macro_define_function
15377         code.
15378         (macro_define_object_internal): Use macro_define_internal.
15379         (macro_define_function): Likewise.
15380
15381 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
15382
15383         * macrocmd.c (extract_identifier): Return
15384         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
15385         callers.
15386
15387 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
15388
15389         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
15390
15391 2019-02-05  Tom Tromey  <tom@tromey.com>
15392
15393         * target.c (target_stack::unpush): Move assertion earlier.
15394
15395 2019-01-30  Tom Tromey  <tom@tromey.com>
15396
15397         PR python/23615:
15398         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
15399         (gdbpy_parse_and_eval): Likewise.
15400         * python/python-internal.h (gdbpy_allow_threads): New class.
15401
15402 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
15403
15404         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
15405         (aarch64_fbsd_fpregmap): Move earlier.
15406         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
15407         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
15408         instead of individual calls to trad_frame_set_reg_addr.
15409         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
15410         earlier.
15411         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
15412         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
15413         instead of individual calls to trad_frame_set_reg_addr.
15414
15415 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
15416
15417         * CONTRIBUTE: Replace contribution list with wiki link.
15418
15419 2019-01-25  Tom Tromey  <tom@tromey.com>
15420
15421         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
15422
15423 2019-01-25  Tom Tromey  <tom@tromey.com>
15424
15425         * xtensa-linux-nat.c: Fix common/ includes.
15426         * xml-support.h: Fix common/ includes.
15427         * xml-support.c: Fix common/ includes.
15428         * x86-linux-nat.c: Fix common/ includes.
15429         * windows-nat.c: Fix common/ includes.
15430         * varobj.h: Fix common/ includes.
15431         * varobj.c: Fix common/ includes.
15432         * value.c: Fix common/ includes.
15433         * valops.c: Fix common/ includes.
15434         * utils.c: Fix common/ includes.
15435         * unittests/xml-utils-selftests.c: Fix common/ includes.
15436         * unittests/utils-selftests.c: Fix common/ includes.
15437         * unittests/unpack-selftests.c: Fix common/ includes.
15438         * unittests/tracepoint-selftests.c: Fix common/ includes.
15439         * unittests/style-selftests.c: Fix common/ includes.
15440         * unittests/string_view-selftests.c: Fix common/ includes.
15441         * unittests/scoped_restore-selftests.c: Fix common/ includes.
15442         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
15443         * unittests/scoped_fd-selftests.c: Fix common/ includes.
15444         * unittests/rsp-low-selftests.c: Fix common/ includes.
15445         * unittests/parse-connection-spec-selftests.c: Fix common/
15446         includes.
15447         * unittests/optional-selftests.c: Fix common/ includes.
15448         * unittests/offset-type-selftests.c: Fix common/ includes.
15449         * unittests/observable-selftests.c: Fix common/ includes.
15450         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
15451         * unittests/memrange-selftests.c: Fix common/ includes.
15452         * unittests/memory-map-selftests.c: Fix common/ includes.
15453         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
15454         * unittests/function-view-selftests.c: Fix common/ includes.
15455         * unittests/environ-selftests.c: Fix common/ includes.
15456         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
15457         * unittests/common-utils-selftests.c: Fix common/ includes.
15458         * unittests/cli-utils-selftests.c: Fix common/ includes.
15459         * unittests/array-view-selftests.c: Fix common/ includes.
15460         * ui-file.c: Fix common/ includes.
15461         * tui/tui-io.c: Fix common/ includes.
15462         * tracepoint.h: Fix common/ includes.
15463         * tracepoint.c: Fix common/ includes.
15464         * tracefile-tfile.c: Fix common/ includes.
15465         * top.h: Fix common/ includes.
15466         * top.c: Fix common/ includes.
15467         * thread.c: Fix common/ includes.
15468         * target/waitstatus.h: Fix common/ includes.
15469         * target/waitstatus.c: Fix common/ includes.
15470         * target.h: Fix common/ includes.
15471         * target.c: Fix common/ includes.
15472         * target-memory.c: Fix common/ includes.
15473         * target-descriptions.c: Fix common/ includes.
15474         * symtab.h: Fix common/ includes.
15475         * symfile.c: Fix common/ includes.
15476         * stap-probe.c: Fix common/ includes.
15477         * spu-linux-nat.c: Fix common/ includes.
15478         * sparc-nat.c: Fix common/ includes.
15479         * source.c: Fix common/ includes.
15480         * solib.c: Fix common/ includes.
15481         * solib-target.c: Fix common/ includes.
15482         * ser-unix.c: Fix common/ includes.
15483         * ser-tcp.c: Fix common/ includes.
15484         * ser-pipe.c: Fix common/ includes.
15485         * ser-base.c: Fix common/ includes.
15486         * selftest-arch.c: Fix common/ includes.
15487         * s12z-tdep.c: Fix common/ includes.
15488         * rust-exp.y: Fix common/ includes.
15489         * rs6000-aix-tdep.c: Fix common/ includes.
15490         * riscv-tdep.c: Fix common/ includes.
15491         * remote.c: Fix common/ includes.
15492         * remote-notif.h: Fix common/ includes.
15493         * remote-fileio.h: Fix common/ includes.
15494         * remote-fileio.c: Fix common/ includes.
15495         * regcache.h: Fix common/ includes.
15496         * regcache.c: Fix common/ includes.
15497         * record-btrace.c: Fix common/ includes.
15498         * python/python.c: Fix common/ includes.
15499         * python/py-type.c: Fix common/ includes.
15500         * python/py-inferior.c: Fix common/ includes.
15501         * progspace.h: Fix common/ includes.
15502         * producer.c: Fix common/ includes.
15503         * procfs.c: Fix common/ includes.
15504         * proc-api.c: Fix common/ includes.
15505         * printcmd.c: Fix common/ includes.
15506         * ppc-linux-nat.c: Fix common/ includes.
15507         * parser-defs.h: Fix common/ includes.
15508         * osdata.c: Fix common/ includes.
15509         * obsd-nat.c: Fix common/ includes.
15510         * nat/x86-linux.c: Fix common/ includes.
15511         * nat/x86-linux-dregs.c: Fix common/ includes.
15512         * nat/x86-dregs.h: Fix common/ includes.
15513         * nat/x86-dregs.c: Fix common/ includes.
15514         * nat/ppc-linux.c: Fix common/ includes.
15515         * nat/mips-linux-watch.h: Fix common/ includes.
15516         * nat/mips-linux-watch.c: Fix common/ includes.
15517         * nat/linux-waitpid.c: Fix common/ includes.
15518         * nat/linux-ptrace.h: Fix common/ includes.
15519         * nat/linux-ptrace.c: Fix common/ includes.
15520         * nat/linux-procfs.c: Fix common/ includes.
15521         * nat/linux-personality.c: Fix common/ includes.
15522         * nat/linux-osdata.c: Fix common/ includes.
15523         * nat/linux-namespaces.c: Fix common/ includes.
15524         * nat/linux-btrace.h: Fix common/ includes.
15525         * nat/linux-btrace.c: Fix common/ includes.
15526         * nat/fork-inferior.c: Fix common/ includes.
15527         * nat/amd64-linux-siginfo.c: Fix common/ includes.
15528         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
15529         * nat/aarch64-linux.c: Fix common/ includes.
15530         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
15531         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
15532         * namespace.h: Fix common/ includes.
15533         * mips-linux-tdep.c: Fix common/ includes.
15534         * minsyms.c: Fix common/ includes.
15535         * mi/mi-parse.h: Fix common/ includes.
15536         * mi/mi-main.c: Fix common/ includes.
15537         * mi/mi-cmd-env.c: Fix common/ includes.
15538         * memrange.h: Fix common/ includes.
15539         * memattr.c: Fix common/ includes.
15540         * maint.h: Fix common/ includes.
15541         * maint.c: Fix common/ includes.
15542         * main.c: Fix common/ includes.
15543         * machoread.c: Fix common/ includes.
15544         * location.c: Fix common/ includes.
15545         * linux-thread-db.c: Fix common/ includes.
15546         * linux-nat.c: Fix common/ includes.
15547         * linux-fork.c: Fix common/ includes.
15548         * inline-frame.c: Fix common/ includes.
15549         * infrun.c: Fix common/ includes.
15550         * inflow.c: Fix common/ includes.
15551         * inferior.h: Fix common/ includes.
15552         * inferior.c: Fix common/ includes.
15553         * infcmd.c: Fix common/ includes.
15554         * inf-ptrace.c: Fix common/ includes.
15555         * inf-child.c: Fix common/ includes.
15556         * ia64-linux-nat.c: Fix common/ includes.
15557         * i387-tdep.c: Fix common/ includes.
15558         * i386-tdep.c: Fix common/ includes.
15559         * i386-linux-tdep.c: Fix common/ includes.
15560         * i386-linux-nat.c: Fix common/ includes.
15561         * i386-go32-tdep.c: Fix common/ includes.
15562         * i386-fbsd-tdep.c: Fix common/ includes.
15563         * i386-fbsd-nat.c: Fix common/ includes.
15564         * guile/scm-type.c: Fix common/ includes.
15565         * guile/guile.c: Fix common/ includes.
15566         * go32-nat.c: Fix common/ includes.
15567         * gnu-nat.c: Fix common/ includes.
15568         * gdbthread.h: Fix common/ includes.
15569         * gdbarch-selftests.c: Fix common/ includes.
15570         * gdb_usleep.c: Fix common/ includes.
15571         * gdb_select.h: Fix common/ includes.
15572         * gdb_bfd.c: Fix common/ includes.
15573         * gcore.c: Fix common/ includes.
15574         * fork-child.c: Fix common/ includes.
15575         * findvar.c: Fix common/ includes.
15576         * fbsd-nat.c: Fix common/ includes.
15577         * event-top.c: Fix common/ includes.
15578         * event-loop.c: Fix common/ includes.
15579         * dwarf2read.c: Fix common/ includes.
15580         * dwarf2loc.c: Fix common/ includes.
15581         * dwarf2-frame.c: Fix common/ includes.
15582         * dwarf-index-cache.c: Fix common/ includes.
15583         * dtrace-probe.c: Fix common/ includes.
15584         * disasm-selftests.c: Fix common/ includes.
15585         * defs.h: Fix common/ includes.
15586         * csky-tdep.c: Fix common/ includes.
15587         * cp-valprint.c: Fix common/ includes.
15588         * cp-support.h: Fix common/ includes.
15589         * cp-support.c: Fix common/ includes.
15590         * corelow.c: Fix common/ includes.
15591         * completer.h: Fix common/ includes.
15592         * completer.c: Fix common/ includes.
15593         * compile/compile.c: Fix common/ includes.
15594         * compile/compile-loc2c.c: Fix common/ includes.
15595         * compile/compile-cplus-types.c: Fix common/ includes.
15596         * compile/compile-cplus-symbols.c: Fix common/ includes.
15597         * command.h: Fix common/ includes.
15598         * cli/cli-dump.c: Fix common/ includes.
15599         * cli/cli-cmds.c: Fix common/ includes.
15600         * charset.c: Fix common/ includes.
15601         * build-id.c: Fix common/ includes.
15602         * btrace.h: Fix common/ includes.
15603         * btrace.c: Fix common/ includes.
15604         * breakpoint.h: Fix common/ includes.
15605         * breakpoint.c: Fix common/ includes.
15606         * ax.h:
15607         (enum agent_op): Fix common/ includes.
15608         * ax-general.c (struct aop_map): Fix common/ includes.
15609         * ax-gdb.c: Fix common/ includes.
15610         * auxv.c: Fix common/ includes.
15611         * auto-load.c: Fix common/ includes.
15612         * arm-tdep.c: Fix common/ includes.
15613         * arch/riscv.c: Fix common/ includes.
15614         * arch/ppc-linux-common.c: Fix common/ includes.
15615         * arch/i386.c: Fix common/ includes.
15616         * arch/arm.c: Fix common/ includes.
15617         * arch/arm-linux.c: Fix common/ includes.
15618         * arch/arm-get-next-pcs.c: Fix common/ includes.
15619         * arch/amd64.c: Fix common/ includes.
15620         * arch/aarch64.c: Fix common/ includes.
15621         * arch/aarch64-insn.c: Fix common/ includes.
15622         * arch-utils.c: Fix common/ includes.
15623         * amd64-windows-tdep.c: Fix common/ includes.
15624         * amd64-tdep.c: Fix common/ includes.
15625         * amd64-sol2-tdep.c: Fix common/ includes.
15626         * amd64-obsd-tdep.c: Fix common/ includes.
15627         * amd64-nbsd-tdep.c: Fix common/ includes.
15628         * amd64-linux-tdep.c: Fix common/ includes.
15629         * amd64-linux-nat.c: Fix common/ includes.
15630         * amd64-fbsd-tdep.c: Fix common/ includes.
15631         * amd64-fbsd-nat.c: Fix common/ includes.
15632         * amd64-dicos-tdep.c: Fix common/ includes.
15633         * amd64-darwin-tdep.c: Fix common/ includes.
15634         * agent.c: Fix common/ includes.
15635         * ada-lang.h: Fix common/ includes.
15636         * ada-lang.c: Fix common/ includes.
15637         * aarch64-tdep.c: Fix common/ includes.
15638
15639 2019-01-25  Tom Tromey  <tom@tromey.com>
15640
15641         * common/create-version.sh: Use common/version.h.
15642
15643 2019-01-24  Pedro Alves  <palves@redhat.com>
15644
15645         * infrun.c (signal_stop, signal_print, signal_program)
15646         (signal_catch, signal_pass): Now arrays instead of pointers.
15647         (update_signals_program_target, do_target_resume)
15648         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
15649         * linux-nat.c (linux_nat_target::pass_signals)
15650         (linux_nat_target::create_inferior, linux_nat_target::attach):
15651         Adjust.
15652         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
15653         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
15654         * procfs.c (procfs_target::pass_signals): Adjust.
15655         * record-full.c (record_full_target::resume): Adjust.
15656         * remote.c (remote_target::pass_signals)
15657         (remote_target::program_signals): Adjust.
15658         * target-debug.h (target_debug_print_signals): Now takes a
15659         gdb::array_view as parameter.  Adjust.
15660         * target.h (target_ops) <pass_signals, program_signals>: Replace
15661         pointer and length parameters with gdb::array_view.
15662         (target_pass_signals, target_program_signals): Likewise.
15663         * target-delegates.c: Regenerate.
15664
15665 2019-01-24  Pedro Alves  <palves@redhat.com>
15666
15667         * common/forward-scope-exit.h
15668         (forward_scope_exit::forward_scope_exit): Pass arguments to
15669         m_bind_function directly, instead of creating a std::bind and
15670         copying that.
15671
15672 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
15673
15674         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
15675         for static members.
15676         (pass_in_v_vfp_candidate): Likewise.
15677
15678 2019-01-23  Tom Tromey  <tom@tromey.com>
15679             Pedro Alves  <palves@redhat.com>
15680
15681         * regcache.c (class regcache_invalidator): Remove.
15682         (regcache::raw_write): Use make_scope_exit.
15683
15684 2019-01-23  Tom Tromey  <tom@tromey.com>
15685
15686         * ui-out.h (class ui_out_emit_type): Update comment.
15687
15688 2019-01-23  Tom Tromey  <tom@tromey.com>
15689
15690         * infrun.c (fetch_inferior_event): Update comment.
15691
15692 2019-01-23  Tom Tromey  <tom@tromey.com>
15693             Pedro Alves  <palves@redhat.com>
15694
15695         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
15696         parameter.
15697         (fetch_inferior_event): Use SCOPE_EXIT.
15698
15699
15700 2019-01-23  Tom Tromey  <tom@tromey.com>
15701             Pedro Alves  <palves@redhat.com>
15702
15703         * infrun.c (disable_thread_events): Delete.
15704         (stop_all_threads): Use SCOPE_EXIT.
15705
15706 2019-01-23  Tom Tromey  <tom@tromey.com>
15707             Pedro Alves  <palves@redhat.com>
15708
15709         * symfile.c: Include forward-scope-exit.h.
15710         (clear_symtab_users_cleanup): Replace forward declaration with
15711         a FORWARD_SCOPE_EXIT.
15712         (syms_from_objfile_1): Use the forward_scope_exit and
15713         gdb::optional instead of cleanup_function.
15714         (reread_symbols): Use the forward_scope_exit instead of
15715         cleanup_function.
15716         (clear_symtab_users_cleanup): Remove function.
15717
15718 2019-01-23  Tom Tromey  <tom@tromey.com>
15719             Pedro Alves  <palves@redhat.com>
15720
15721         * linux-nat.c: Include scope-exit.h.
15722         (cleanup_target_stop): Remove.
15723         (linux_nat_target::static_tracepoint_markers_by_strid): Use
15724         SCOPE_EXIT.
15725
15726 2019-01-23  Tom Tromey  <tom@tromey.com>
15727             Pedro Alves  <palves@redhat.com>
15728
15729         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
15730         (call_function_by_hand_dummy): Use SCOPE_EXIT.
15731
15732 2019-01-23  Tom Tromey  <tom@tromey.com>
15733             Andrew Burgess  <andrew.burgess@embecosm.com>
15734             Pedro Alves  <palves@redhat.com>
15735
15736         * infrun.c (fetch_inferior_event): Use scope_exit.
15737         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
15738         * top.c (execute_command): Use scope_exit.
15739         * breakpoint.c (bpstat_do_actions): Use scope_exit.
15740         * utils.c (do_bpstat_clear_actions_cleanup)
15741         (make_bpstat_clear_actions_cleanup): Remove.
15742
15743 2019-01-23  Tom Tromey  <tom@tromey.com>
15744             Pedro Alves  <palves@redhat.com>
15745
15746         * infrun.c: Include "common/scope-exit.h"
15747         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
15748         (wait_for_inferior): Use SCOPE_EXIT.
15749         (fetch_inferior_event): Use scope_exit.
15750
15751 2019-01-23  Tom Tromey  <tom@tromey.com>
15752             Pedro Alves  <palves@redhat.com>
15753
15754         * breakpoint.c (create_breakpoint): Remove cleanup.
15755
15756 2019-01-23  Tom Tromey  <tom@tromey.com>
15757             Andrew Burgess  <andrew.burgess@embecosm.com>
15758             Pedro Alves  <palves@redhat.com>
15759
15760 2019-01-23  Pedro Alves  <palves@redhat.com>
15761
15762         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
15763
15764 2019-01-23  Pedro Alves  <palves@redhat.com>
15765             Andrew Burgess  <andrew.burgess@embecosm.com>
15766
15767         * gdbthread.h: Include "common/forward-scope-exit.h".
15768         (scoped_finish_thread_state): Redefine custom class in terms of
15769         forward_scope_exit.
15770
15771 2019-01-23  Pedro Alves  <palves@redhat.com>
15772             Andrew Burgess  <andrew.burgess@embecosm.com>
15773
15774         * common/forward-scope-exit.h: New file.
15775
15776 2019-01-23  Pedro Alves  <palves@redhat.com>
15777             Andrew Burgess  <andrew.burgess@embecosm.com>
15778             Tom Tromey  <tom@tromey.com>
15779
15780         * common/scope-exit.h: New file.
15781
15782 2019-01-23  Pedro Alves  <palves@redhat.com>
15783
15784         * common/preprocessor.h (ESC): Rename to ...
15785         (ESC_PARENS): ... this.
15786         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
15787         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
15788
15789 2019-01-23  Tom Tromey  <tom@tromey.com>
15790
15791         * language.h (class scoped_switch_to_sym_language_if_auto):
15792         Initialize m_lang in both cases.
15793
15794 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
15795
15796         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
15797         with XCNEW.
15798
15799 2019-01-22  Tom Tromey  <tom@tromey.com>
15800
15801         * corelow.c: Do not include sys/file.h.
15802
15803 2019-01-22  Tom Tromey  <tom@tromey.com>
15804
15805         * tui/tui-wingeneral.h: Include gdb_curses.h.
15806
15807 2019-01-22  Tom Tromey  <tom@tromey.com>
15808
15809         * source-cache.h (class source_cache) <get_source_lines,
15810         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
15811
15812 2019-01-22  Tom Tromey  <tom@tromey.com>
15813
15814         * remote-fileio.h (struct remote_target): Declare.
15815
15816 2019-01-22  Tom Tromey  <tom@tromey.com>
15817
15818         * python/py-arch.c: Do not include py-ref.h.
15819         * python/py-bpevent.c: Do not include py-ref.h.
15820         * python/py-cmd.c: Do not include py-ref.h.
15821         * python/py-continueevent.c: Do not include py-ref.h.
15822         * python/py-event.h: Do not include py-ref.h.
15823         * python/py-evtregistry.c: Do not include py-ref.h.
15824         * python/py-finishbreakpoint.c: Do not include py-ref.h.
15825         * python/py-frame.c: Do not include py-ref.h.
15826         * python/py-framefilter.c: Do not include py-ref.h.
15827         * python/py-function.c: Do not include py-ref.h.
15828         * python/py-infevents.c: Do not include py-ref.h.
15829         * python/py-linetable.c: Do not include py-ref.h.
15830         * python/py-objfile.c: Do not include py-ref.h.
15831         * python/py-param.c: Do not include py-ref.h.
15832         * python/py-prettyprint.c: Do not include py-ref.h.
15833         * python/py-progspace.c: Do not include py-ref.h.
15834         * python/py-symbol.c: Do not include py-ref.h.
15835         * python/py-symtab.c: Do not include py-ref.h.
15836         * python/py-type.c: Do not include py-ref.h.
15837         * python/py-unwind.c: Do not include py-ref.h.
15838         * python/py-utils.c: Do not include py-ref.h.
15839         * python/py-value.c: Do not include py-ref.h.
15840         * python/py-varobj.c: Do not include py-ref.h.
15841         * python/py-xmethods.c: Do not include py-ref.h.
15842         * python/python.c: Do not include py-ref.h.
15843         * varobj.c: Do not include py-ref.h.
15844
15845 2019-01-22  Tom Tromey  <tom@tromey.com>
15846
15847         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
15848         keyword for bcache.
15849
15850 2019-01-22  Tom Tromey  <tom@tromey.com>
15851
15852         * compile/compile-cplus-types.c: Remove a comment by #include.
15853
15854 2019-01-22  Tom Tromey  <tom@tromey.com>
15855
15856         * compile/gcc-c-plugin.h: Include compile-internal.h.
15857
15858 2019-01-22  Tom Tromey  <tom@tromey.com>
15859
15860         * stabsread.c (EXTERN): Do not define.
15861         (symnum, next_symbol_text_func, processing_gcc_compilation)
15862         (within_function, global_sym_chain, global_stabs)
15863         (previous_stab_code, this_object_header_files)
15864         (n_this_object_header_files)
15865         (n_allocated_this_object_header_files): Define.
15866         * stabsread.h (EXTERN): Never define.  Use "extern".
15867
15868 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
15869
15870         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
15871         history_value.
15872
15873 2019-01-21  Tom Tromey  <tom@tromey.com>
15874
15875         * ui-out.c: Fix includes.
15876         * tui/tui-source.c: Fix includes.
15877         * target.c: Fix includes.
15878         * remote.c: Fix includes.
15879         * regcache.c: Fix includes.
15880         * python/py-block.c: Fix includes.
15881         * printcmd.c: Fix includes.
15882         * or1k-tdep.c: Fix includes.
15883         * mi/mi-main.c: Fix includes.
15884         * m32r-tdep.c: Fix includes.
15885         * csky-tdep.c: Fix includes.
15886         * compile/compile-cplus-types.c: Fix includes.
15887         * cli/cli-interp.c: Fix includes.
15888
15889 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
15890
15891         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
15892         for padding.
15893
15894 2019-01-16  Tom Tromey  <tom@tromey.com>
15895
15896         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
15897         earlier.
15898         (struct objfile) <msymbols_range>: Move from top level.
15899         <msymbols>: New method.
15900         (class objfile_msymbols): Remove.
15901         * symtab.c (default_collect_symbol_completion_matches_break_on):
15902         Update.
15903         * symmisc.c (dump_msymbols): Update.
15904         * stabsread.c (scan_file_globals): Update.
15905         * objc-lang.c (info_selectors_command, info_classes_command)
15906         (find_methods): Update.
15907         * minsyms.c (find_solib_trampoline_target): Update.
15908         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
15909         * coffread.c (coff_symfile_read): Update.
15910         * ada-lang.c (ada_lookup_simple_minsym)
15911         (ada_collect_symbol_completion_matches): Update.
15912
15913 2019-01-16  Tom Tromey  <tom@tromey.com>
15914
15915         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
15916         type.  Remove no-argument constructor.
15917         <iterator::operator++>: Simplify.
15918         <begin>: Update.
15919         <end>: Use minimal_symbol_count.
15920
15921 2019-01-16  Tom Tromey  <tom@tromey.com>
15922
15923         * objfiles.h (struct objfile) <psymtabs>: New method.
15924         (class objfile_psymtabs): Remove.
15925         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
15926         typedef.
15927         <range>: New method.
15928         (require_partial_symbols): Change return type.
15929         * psymtab.c (require_partial_symbols)
15930         (psym_expand_symtabs_matching): Update.
15931         * mdebugread.c (parse_partial_symbols): Update.
15932         * dbxread.c (dbx_end_psymtab): Update.
15933
15934 2019-01-15  Tom Tromey  <tom@tromey.com>
15935
15936         * symtab.c (lookup_objfile_from_block)
15937         (lookup_symbol_in_objfile_symtabs)
15938         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
15939         (find_line_symtab, info_sources_command)
15940         (default_collect_symbol_completion_matches_break_on)
15941         (make_source_files_completion_list): Update.
15942         * symmisc.c (print_objfile_statistics, dump_objfile)
15943         (maintenance_print_symbols, maintenance_info_symtabs)
15944         (maintenance_check_symtabs, maintenance_info_line_tables):
15945         Update.
15946         * source.c (select_source_symtab)
15947         (forget_cached_source_info_for_objfile): Update.
15948         * objfiles.h (class objfile_compunits): Remove.
15949         (struct objfile) <compunits_range>: New typedef.
15950         (compunits): New method.
15951         * objfiles.c (objfile_relocate1): Update.
15952         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
15953         * maint.c (count_symtabs_and_blocks): Update.
15954         * linespec.c (iterate_over_all_matching_symtabs): Update.
15955         * cp-support.c (add_symbol_overload_list_qualified): Update.
15956         * coffread.c (coff_symtab_read): Update.
15957         * ada-lang.c (add_nonlocal_symbols)
15958         (ada_collect_symbol_completion_matches)
15959         (ada_add_global_exceptions): Update.
15960
15961 2019-01-15  Tom Tromey  <tom@tromey.com>
15962
15963         * progspace.h (program_space) <objfiles_safe_range>: New
15964         typedef.
15965         <objfiles_safe>: New method.
15966         * objfiles.h (class all_objfiles_safe): Remove.
15967         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
15968         * jit.c (jit_inferior_exit_hook): Update.
15969
15970 2019-01-17  Tom Tromey  <tom@tromey.com>
15971
15972         * progspace.h (program_space) <objfiles_range>: New typedef.
15973         <objfiles>: New method.
15974         <objfiles_head>: Rename from objfiles.
15975         (object_files): Update.
15976         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
15977         * guile/scm-pretty-print.c
15978         (ppscm_find_pretty_printer_from_objfiles): Update.
15979         * guile/scm-objfile.c (gdbscm_objfiles): Update.
15980         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
15981         Update.
15982         * python/py-progspace.c (pspy_get_objfiles): Update.
15983         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
15984         Update.
15985         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
15986         (objfpy_lookup_objfile_by_build_id): Update.
15987         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
15988         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
15989         Update.
15990         * symtab.c (iterate_over_symtabs, matching_obj_sections)
15991         (expand_symtab_containing_pc, lookup_objfile_from_block)
15992         (lookup_static_symbol, basic_lookup_transparent_type)
15993         (find_pc_sect_compunit_symtab, find_symbol_at_address)
15994         (find_line_symtab, info_sources_command)
15995         (default_collect_symbol_completion_matches_break_on)
15996         (make_source_files_completion_list, find_main_name): Update.
15997         * symmisc.c (print_symbol_bcache_statistics)
15998         (print_objfile_statistics, maintenance_print_symbols)
15999         (maintenance_print_msymbols, maintenance_print_objfiles)
16000         (maintenance_info_symtabs, maintenance_check_symtabs)
16001         (maintenance_expand_symtabs, maintenance_info_line_tables):
16002         Update.
16003         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
16004         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
16005         (map_overlay_command, unmap_overlay_command)
16006         (simple_overlay_update, expand_symtabs_matching)
16007         (map_symbol_filenames): Update.
16008         * symfile-debug.c (set_debug_symfile): Update.
16009         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
16010         Update.
16011         * source.c (select_source_symtab, forget_cached_source_info):
16012         Update.
16013         * solib.c (solib_read_symbols): Update.
16014         * solib-spu.c (append_ocl_sos): Update.
16015         * psymtab.c (maintenance_print_psymbols)
16016         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
16017         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
16018         * printcmd.c (info_symbol_command): Update.
16019         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
16020         Update.
16021         * objfiles.h (class all_objfiles): Remove.
16022         * objfiles.c (have_partial_symbols, have_full_symbols)
16023         (have_minimal_symbols, qsort_cmp, update_section_map)
16024         (shared_objfile_contains_address_p)
16025         (default_iterate_over_objfiles_in_search_order): Update.
16026         * objc-lang.c (info_selectors_command, info_classes_command)
16027         (find_methods): Update.
16028         * minsyms.c (find_solib_trampoline_target): Update.
16029         * maint.c (maintenance_info_sections)
16030         (maintenance_translate_address, count_symtabs_and_blocks):
16031         Update.
16032         * main.c (captured_main_1): Update.
16033         * linux-thread-db.c (try_thread_db_load_from_pdir)
16034         (has_libpthread): Update.
16035         * linespec.c (iterate_over_all_matching_symtabs)
16036         (search_minsyms_for_name): Update.
16037         * jit.c (jit_find_objf_with_entry_addr): Update.
16038         * hppa-tdep.c (find_unwind_entry)
16039         (hppa_lookup_stub_minimal_symbol): Update.
16040         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
16041         Update.
16042         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
16043         (elf_gnu_ifunc_resolve_by_got): Update.
16044         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
16045         * dwarf-index-write.c (save_gdb_index_command): Update.
16046         * cp-support.c (add_symbol_overload_list_qualified): Update.
16047         * breakpoint.c (create_overlay_event_breakpoint)
16048         (create_longjmp_master_breakpoint)
16049         (create_std_terminate_master_breakpoint)
16050         (create_exception_master_breakpoint): Update.
16051         * blockframe.c (find_pc_partial_function): Update.
16052         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
16053         (ada_collect_symbol_completion_matches)
16054         (ada_add_global_exceptions): Update.
16055
16056 2019-01-17  Tom Tromey  <tom@tromey.com>
16057
16058         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
16059         declare VEC.
16060         (solib_target_parse_libraries): Change return type.
16061         (library_list_start_segment, library_list_start_section)
16062         (library_list_end_library, library_list_start_library); Update.
16063         (solib_target_free_library_list): Remove.
16064         (solib_target_parse_libraries): Remove cleanup.  Change return
16065         type.
16066         (solib_target_current_sos): Update.
16067
16068 2019-01-17  Tom Tromey  <tromey@bapiya>
16069
16070         * valprint.c: Replace "the the" with "the".
16071         * symtab.c: Replace "the the" with "the".
16072         * solib.c: Replace "the the" with "the".
16073         * solib-dsbt.c: Replace "the the" with "the".
16074         * linespec.c: Replace "the the" with "the".
16075         * dwarf2loc.h: Replace "the the" with "the".
16076         * amd64-windows-tdep.c: Replace "the the" with "the".
16077         * aarch64-tdep.c: Replace "the the" with "the".
16078
16079 2019-01-16  Keith Seitz  <keiths@redhat.com>
16080
16081         PR gdb/23773
16082         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
16083         <builder>: Rename to ..
16084         <m_builder>: ... this and make private.
16085         (dwarf2_cu::get_builder): New method.  Change all users of
16086         `builder' to use this method.
16087         (dwarf2_start_symtab): Move to ...
16088         (dwarf2_cu::start_symtab): ... here.  Update all callers
16089         (setup_type_unit_groups): Move to ...
16090         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
16091         callers.
16092         (dwarf2_cu::reset_builder): New method.
16093         (process_full_compunit, process_full_type_unit): Use
16094         dwarf2_cu::reset_builder.
16095         (follow_die_offset): Record the ancestor CU if it is different
16096         from the followed DIE's CU.
16097         (follow_die_sig_1): Likewise.
16098
16099 2019-01-15  Tom Tromey  <tom@tromey.com>
16100
16101         * remote.c (class remote_state) <buf>: Now a char_vector.
16102         <buf_size>: Remove.
16103         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
16104         parameter.
16105         (remote_target::getpkt_or_notif_sane_1)
16106         (remote_target::getpkt_sane)
16107         (remote_target::getpkt_or_notif_sane): Likewise.
16108         (class remote_target) <putpkt>: New overload.
16109         (remote_target::read_frame): Change type of "buf_p".  Remove
16110         sizeof_p parameter.
16111         (packet_ok): New overload.
16112         (packet_check_result): New overload.
16113         Update all uses.
16114
16115 2019-01-14  Tom Tromey  <tom@tromey.com>
16116
16117         * remote-notif.c (handle_notification, remote_notif_ack)
16118         (remote_notif_parse): Make "buf" const.
16119         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
16120         const.
16121         (remote_notif_parse, remote_notif_ack, handle_notification):
16122         Likewise.
16123         * remote.c (remote_notif_stop_parse): Make "buf" const.
16124         (remote_target::remote_parse_stop_reply): Make "buf" const.
16125         (remote_notif_stop_ack): Make "buf" const.
16126
16127 2019-01-14  Tom Tromey  <tom@tromey.com>
16128
16129         * remote.c (remote_console_output): Make parameter const.
16130
16131 2019-01-14  Tom Tromey  <tom@tromey.com>
16132
16133         * target-debug.h (target_debug_print_signals): Constify.
16134         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
16135         * procfs.c (procfs_target::pass_signals): Update.
16136         * linux-nat.c (linux_nat_target::pass_signals): Update.
16137         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
16138         * target-delegates.c: Rebuild.
16139         * remote.c (remote_target::program_signals): Update.
16140         (remote_target::pass_signals): Update.
16141         * target.c (target_pass_signals): Constify argument.
16142         (target_program_signals): Likewise.
16143         * target.h (struct target_ops) <pass_signals, program_signals>:
16144         Constify argument.
16145         (target_pass_signals, target_program_signals): Constify argument.
16146
16147 2019-01-14  Tom Tromey  <tom@tromey.com>
16148
16149         PR tui/28819:
16150         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
16151
16152 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
16153
16154         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
16155         field.
16156         * rs6000-tdep.c: Include reggroups.h.
16157         (IS_V_ALIAS_PSEUDOREG): Define.
16158         (rs6000_register_name): Return names for the "vX" aliases.
16159         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
16160         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
16161         aliases.  Call default_register_reggroup_p for all other
16162         pseudo-registers.
16163         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
16164         New functions.
16165         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
16166         Handle "vX" aliases.
16167         (v_alias_pseudo_register_collect): New function.
16168         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
16169         (rs6000_gdbarch_init): Initialize "vX" aliases as
16170         pseudo-registers.  Restore registration of
16171         rs6000_pseudo_register_reggroup_p with
16172         set_tdesc_pseudo_register_reggroup_p.
16173
16174 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
16175
16176         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
16177         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
16178         set_gdbarch_num_pseudo_regs.
16179
16180 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
16181
16182         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
16183         Remove arg prefixname, add do_set and do_show.
16184         Add member functions set_list and show_list.
16185         * cli/cli-style.c (class cli_style_option): Update accordingly.
16186         (style_set_list): Move to file scope.
16187         (style_show_list): Likewise.
16188         (set_style): Call help_list.
16189         (show_style): Call cmd_show_list.
16190         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
16191         Update to use the new macro.
16192
16193 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
16194
16195         * ada-lang.c (_initialize_ada_language): Expand the help text
16196         for the "catch exception" command.
16197
16198 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
16199
16200         * symtab.c (matching_obj_sections): Initialize obj,
16201         declare it closer to its usage.
16202
16203 2019-01-10  Tom Tromey  <tom@tromey.com>
16204
16205         * thread-iter.h (inf_threads_iterator): Use next_iterator.
16206         (basic_inf_threads_range): Remove.
16207         (inf_threads_range, inf_non_exited_threads_range)
16208         (safe_inf_threads_range): Use next_adapter.
16209
16210 2019-01-10  Keith Seitz  <keiths@redhat.com>
16211
16212         PR gdb/23712
16213         PR symtab/23010
16214         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
16215         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
16216
16217 2019-01-10  Keith Seitz  <keiths@redhat.com>
16218
16219         PR gdb/23712
16220         PR symtab/23010
16221         * dictionary.c (pending_to_vector): Remove.
16222         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
16223         Remove _1 suffix, replacing functions of the same name.  Update
16224         all callers.
16225         (dict_create_hashed, dict_create_hashed_expandable)
16226         (dict_create_linear, dict_create_linear_expandable, dict_free)
16227         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
16228         Make functions static.
16229
16230 2019-01-10  Keith Seitz  <keiths@redhat.com>
16231
16232         PR gdb/23712
16233         PR symtab/23010
16234         * dictionary.h (struct dictionary): Replace declaration with
16235         multidictionary.
16236         (dict_create_hashed, dict_create_hashed_expandable)
16237         (dict_create_linear, dict_create_linear_expandable)
16238         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
16239         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
16240         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
16241         taking multidictionary argument.
16242         [ALL_DICT_SYMBOLS]: Update for multidictionary.
16243         * block.h (struct block) <dict>: Change to multidictionary
16244         and rename `multidict'.
16245         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
16246         symmisc.c: Update all dictionary references to multidictionary.
16247
16248 2019-01-10  Keith Seitz  <keiths@redhat.com>
16249
16250         PR gdb/23712
16251         PR symtab/23010
16252         * dictionary.c: Include unordered_map.
16253         (pending_to_vector): New function.
16254         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
16255         Rewrite the non-"_1" functions to take vector instead
16256         of linked list.
16257         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
16258         "new" _1 versions of the same name.
16259         (multidictionary): Define.
16260         (std::hash<enum language): New definition.
16261         (collate_pending_symbols_by_language, mdict_create_hashed)
16262         (mdict_create_hashed_expandable, mdict_create_linear)
16263         (mdict_create_linear_expandable, mdict_free)
16264         (find_language_dictionary, create_new_language_dictionary)
16265         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
16266         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
16267         (mdict_size, mdict_empty): New functions.
16268         * dictionary.h (mdict_iterator): Define.
16269
16270 2019-01-10  Pedro Alves  <palves@redhat.com>
16271
16272         * breakpoint.c (read_uploaded_action)
16273         (create_tracepoint_from_upload): Adjust to use
16274         gdb::unique_xmalloc_ptr.
16275         * ctf.c (ctf_write_uploaded_tp):
16276         (SET_ARRAY_FIELD): Use emplace_back.
16277         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
16278         * tracefile-tfile.c (tfile_write_uploaded_tp):
16279         * tracepoint.c (parse_tracepoint_definition): Adjust to use
16280         gdb::unique_xmalloc_ptr.
16281         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
16282         at_string, cond_string, cmd_strings>: Replace char pointers
16283         with gdb::unique_xmalloc_ptr.
16284
16285 2019-01-10  Pedro Alves  <palves@redhat.com>
16286
16287         * solib-target.c (library_list_start_library): Don't xstrdup name.
16288
16289 2019-01-10  Pedro Alves  <palves@redhat.com>
16290
16291         * mdebugread.c (parse_partial_symbols): Use
16292         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
16293
16294 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
16295
16296         * linux-fork.c (scoped_switch_fork_info)
16297         <~scoped_switch_fork_info>: Fix incorrect variable name.
16298
16299 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
16300
16301         * linux-fork.c (scoped_switch_fork_info)
16302         <scoped_switch_fork_info>: Make explicit.
16303         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
16304
16305 2019-01-10  Tom Tromey  <tom@tromey.com>
16306
16307         * objfiles.h (objfile::reset_psymtabs): Update.
16308         * objfiles.c (objfile::objfile): Update.
16309         * psymtab.h (psymtab_storage::obstack): Update.
16310         (psymtab_storage::m_obstack): Use gdb::optional.
16311         (class psymtab_storage): Update comment.  Remove objfile
16312         parameter.
16313         * psymtab.c (psymtab_storage::psymtab_storage): Update.
16314
16315 2019-01-10  Tom Tromey  <tom@tromey.com>
16316
16317         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
16318         <free_psymtabs>: Now private.
16319         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
16320         (allocate_psymtab): Use new method.
16321
16322 2019-01-10  Tom Tromey  <tom@tromey.com>
16323
16324         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
16325         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
16326         * mdebugread.c (parse_partial_symbols): Use
16327         allocate_dependencies.
16328         * dwarf2read.c (dwarf2_create_include_psymtab): Use
16329         allocate_dependencies.
16330         (process_psymtab_comp_unit_reader)
16331         (build_type_psymtab_dependencies): Likewise.
16332         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
16333
16334 2019-01-10  Tom Tromey  <tom@tromey.com>
16335
16336         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
16337         PSYMBOL_SET_LANGUAGE.
16338         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
16339
16340 2019-01-10  Tom Tromey  <tom@tromey.com>
16341
16342         * psymtab.h (psymtab_storage::obstack): New method.
16343         <m_obstack>: Rename from obstack; now private.
16344         * psymtab.c (psymtab_storage): Update.
16345         * dwarf2read.c (create_addrmap_from_index)
16346         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
16347         Update.
16348
16349 2019-01-10  Tom Tromey  <tom@tromey.com>
16350
16351         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
16352         * objfiles.h (objfile::reset_psymtabs): New method.
16353
16354 2019-01-10  Tom Tromey  <tom@tromey.com>
16355
16356         * symmisc.c (print_symbol_bcache_statistics): Update.
16357         (print_objfile_statistics): Update.
16358         * symfile.c (reread_symbols): Update.
16359         * psymtab.h (class psymtab_storage): New.
16360         * psymtab.c (psymtab_storage): New constructor.
16361         (~psymtab_storage): New destructor.
16362         (require_partial_symbols): Update.
16363         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
16364         (find_pc_sect_psymtab, find_pc_sect_psymbol)
16365         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
16366         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
16367         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
16368         (start_psymtab_common, end_psymtab_common)
16369         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
16370         (allocate_psymtab): Update.
16371         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
16372         Update.
16373         (dump_psymtab_addrmap, maintenance_print_psymbols)
16374         (maintenance_check_psymtabs): Update.
16375         (class objfile_psymtabs): Move to objfiles.h.
16376         * psympriv.h (discard_psymtab): Now inline.
16377         (psymtab_discarder::psymtab_discarder): Update.
16378         (psymtab_discarder::~psymtab_discarder): Update.
16379         (ALL_OBJFILE_PSYMTABS): Rewrite.
16380         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
16381         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
16382         Remove fields.
16383         <partial_symtabs>: New field.
16384         (class objfile_psymtabs): Move from psymtab.h.  Update.
16385         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
16386         psymbol_cache.
16387         (objfile::~objfile): Don't destroy psymbol_cache.
16388         * mdebugread.c (parse_partial_symbols): Update.
16389         * dwarf2read.c (create_addrmap_from_index)
16390         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
16391         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
16392         (add_partial_subprogram, dwarf2_ranges_read): Update.
16393         * dwarf-index-write.c (write_address_map)
16394         (write_one_signatured_type, recursively_write_psymbols)
16395         (class debug_names, class debug_names, write_psymtabs_to_index):
16396         Update.
16397
16398 2019-01-10  Tom Tromey  <tom@tromey.com>
16399
16400         * symtab.h (SYMBOL_SET_NAMES): Update.
16401         (symbol_set_names): Update.
16402         (MSYMBOL_SET_NAMES): Update.
16403         * symtab.c (symbol_set_names): Change argument to be an
16404         objfile_per_bfd_storage.
16405         * psymtab.c (add_psymbol_to_bcache): Update.
16406         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
16407
16408 2019-01-10  Tom Tromey  <tom@tromey.com>
16409
16410         * symtab.c (create_demangled_names_hash): Change argument to be an
16411         objfile_per_bfd_storage.
16412         (symbol_set_names): Update.
16413
16414 2019-01-10  Tom Tromey  <tom@tromey.com>
16415
16416         * xcoffread.c (xcoff_initial_scan): Unconditionally call
16417         init_psymbol_list.
16418         * psymtab.c (init_psymbol_list): Do nothing if already called.
16419         * psympriv.h (init_psymbol_list): Add comment.
16420         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
16421         init_psymbol_list.
16422         * dbxread.c (dbx_symfile_read): Unconditionally call
16423         init_psymbol_list.
16424
16425 2019-01-10  Tom Tromey  <tom@tromey.com>
16426
16427         * xcoffread.c (scan_xcoff_symtab): Update.
16428         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
16429         "where".
16430         * mdebugread.c (parse_partial_symbols)
16431         (handle_psymbol_enumerators): Update.
16432         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
16433         * dbxread.c (read_dbx_symtab): Update.
16434         * psympriv.h (psymbol_placement): New enum.
16435         (add_psymbol_to_list): Update.
16436
16437 2019-01-10  Tom Tromey  <tom@tromey.com>
16438
16439         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
16440         static_psymbols parameters.
16441         (scan_xcoff_symtab): Update.
16442         * psymtab.c (start_psymtab_common): Remove global_psymbols and
16443         static_psymbols parameters.
16444         * psympriv.h (start_psymtab_common): Update.
16445         * mdebugread.c (parse_partial_symbols): Update.
16446         * dwarf2read.c (create_partial_symtab): Update.
16447         * dbxread.c (read_dbx_symtab): Update.
16448         (start_psymtab): Remove global_psymbols and static_psymbols
16449         parameters.
16450
16451 2019-01-10  Tom Tromey  <tom@tromey.com>
16452
16453         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
16454         * psymtab.c (allocate_psymtab): Add comment.
16455         * psympriv.h (allocate_psymtab): Add comment.
16456         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
16457         initializations.
16458         * dbxread.c (dbx_end_psymtab): Remove some initializations.
16459
16460 2019-01-10  Tom Tromey  <tom@tromey.com>
16461
16462         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
16463         Don't declare.
16464         * mipsread.c: Include mdebugread.h.
16465         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
16466         Declare.
16467         * elfread.c: Include mdebugread.h.
16468
16469 2019-01-09  Tom Tromey  <tom@tromey.com>
16470
16471         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
16472         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
16473         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
16474         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
16475         (psym_lookup_symbol, psym_find_last_source_symtab)
16476         (psym_forget_cached_source_info, psym_print_stats)
16477         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
16478         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
16479         (psym_map_matching_symbols, psym_expand_symtabs_matching)
16480         (psym_find_compunit_symtab_by_address)
16481         (maintenance_print_psymbols, maintenance_info_psymtabs)
16482         (maintenance_check_psymtabs): Use ranged for.
16483         * psymtab.h (class objfile_psymtabs): New.
16484         (require_partial_symbols): Return objfile_psymtabs.
16485         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
16486
16487 2019-01-09  Tom Tromey  <tom@tromey.com>
16488
16489         * symfile.c (overlay_invalidate_all, find_pc_overlay)
16490         (find_pc_mapped_section, list_overlays_command)
16491         (map_overlay_command, unmap_overlay_command)
16492         (simple_overlay_update): Use all_objfiles.
16493         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
16494         * printcmd.c (info_symbol_command): Use all_objfiles.
16495         * objfiles.h (ALL_OBJSECTIONS): Remove.
16496         * maint.c (maintenance_translate_address): Use all_objfiles.
16497         * gcore.c (gcore_create_callback): Use all_objfiles.
16498         (objfile_find_memory_regions): Likewise.
16499
16500 2019-01-09  Tom Tromey  <tom@tromey.com>
16501
16502         * symtab.c (find_line_symtab, info_sources_command)
16503         (make_source_files_completion_list): Use objfile_compunits.
16504         * source.c (select_source_symtab): Use objfile_compunits.
16505         * objfiles.h (struct objfile): Update comment.
16506         (ALL_OBJFILES): Remove.
16507         (ALL_FILETABS): Remove.
16508         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
16509         objfile_compunits.
16510
16511 2019-01-09  Tom Tromey  <tom@tromey.com>
16512
16513         * symmisc.c (print_objfile_statistics, dump_objfile)
16514         (maintenance_print_symbols): Use compunit_filetabs.
16515         * source.c (forget_cached_source_info_for_objfile): Use
16516         compunit_filetabs.
16517         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
16518         (ALL_FILETABS): Use compunit_filetabs.
16519         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
16520         * coffread.c (coff_symtab_read): Use compunit_filetabs.
16521
16522 2019-01-09  Tom Tromey  <tom@tromey.com>
16523
16524         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
16525         (compunit_filetabs): New.
16526         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
16527         compunit_filetabs.
16528         (info_sources_command, make_source_files_completion_list): Remove
16529         declaration.
16530         * symmisc.c (print_objfile_statistics, dump_objfile)
16531         (maintenance_print_symbols): Remove declaration.
16532         (maintenance_info_symtabs): Use compunit_filetabs.
16533         (maintenance_info_line_tables): Likewise.
16534         * source.c (select_source_symtab): Change local variable name.
16535         (forget_cached_source_info_for_objfile): Remove declaration.
16536         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
16537         * objfiles.c (objfile_relocate1): Remove declaration.
16538         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
16539         declaration.
16540         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
16541         * coffread.c (coff_symtab_read): Remove declaration.
16542         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
16543         compunit_filetabs.
16544
16545 2019-01-09  Tom Tromey  <tom@tromey.com>
16546
16547         * symtab.c (lookup_objfile_from_block)
16548         (find_pc_sect_compunit_symtab, search_symbols)
16549         (default_collect_symbol_completion_matches_break_on): Use
16550         objfile_compunits.
16551         * objfiles.h (ALL_COMPUNITS): Remove.
16552         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
16553         * cp-support.c (add_symbol_overload_list_qualified): Use
16554         objfile_compunits.
16555         * ada-lang.c (ada_collect_symbol_completion_matches)
16556         (ada_add_global_exceptions): Use objfile_compunits.
16557
16558 2019-01-09  Tom Tromey  <tom@tromey.com>
16559
16560         * source.c (select_source_symtab)
16561         (forget_cached_source_info_for_objfile): Remove declaration.
16562         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
16563         declaration.
16564         * maint.c (count_symtabs_and_blocks): Remove declaration.
16565         * cp-support.c (add_symbol_overload_list_qualified): Remove
16566         declaration.
16567         * coffread.c (coff_symtab_read): Remove declaration.
16568         * symtab.c (lookup_symbol_in_objfile_symtabs)
16569         (basic_lookup_transparent_type_1): Use objfile_compunits.
16570         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
16571         (info_sources_command, search_symbols)
16572         (default_collect_symbol_completion_matches_break_on)
16573         (make_source_files_completion_list): Remove declaration.
16574         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
16575         (ada_collect_symbol_completion_matches)
16576         (ada_add_global_exceptions): Remove declaration.
16577         * linespec.c (iterate_over_all_matching_symtabs): Use
16578         objfile_compunits.
16579         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
16580         (class objfile_compunits): New.
16581         (ALL_COMPUNITS): Use objfile_compunits.
16582         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
16583         (maintenance_check_symtabs, maintenance_info_line_tables): Use
16584         objfile_compunits.
16585         * objfiles.c (objfile_relocate1): Use objfile_compunits.
16586
16587 2019-01-09  Tom Tromey  <tom@tromey.com>
16588
16589         * symtab.c (search_symbols)
16590         (default_collect_symbol_completion_matches_break_on): Use
16591         objfile_msymbols.
16592         * ada-lang.c (ada_lookup_simple_minsym)
16593         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
16594         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
16595         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
16596         objfile_msymbols.
16597         * coffread.c (coff_symfile_read): Use objfile_msymbols.
16598         * symmisc.c (dump_msymbols): Use objfile_msymbols.
16599         * objc-lang.c (find_methods): Use objfile_msymbols.
16600         (info_selectors_command, info_classes_command): Likewise.
16601         * stabsread.c (scan_file_globals): Use objfile_msymbols.
16602         * objfiles.h (class objfile_msymbols): New.
16603         (ALL_OBJFILE_MSYMBOLS): Remove.
16604         (ALL_MSYMBOLS): Remove.
16605
16606 2019-01-09  Tom Tromey  <tom@tromey.com>
16607
16608         * common/next-iterator.h (next_adapter): Add Iterator template
16609         parameter.
16610         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
16611         (class all_objfiles_safe): New.
16612         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
16613         * objfiles.c (put_objfile_before): Update comment.
16614         (add_separate_debug_objfile): Likewise.
16615         (free_all_objfiles): Use all_objfiles_safe.
16616         (objfile_purge_solibs): Likewise.
16617
16618 2019-01-09  Tom Tromey  <tom@tromey.com>
16619
16620         * symtab.c (iterate_over_symtabs, matching_obj_sections)
16621         (expand_symtab_containing_pc, lookup_static_symbol)
16622         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
16623         (find_symbol_at_address, find_line_symtab, find_main_name): Use
16624         all_objfiles.
16625         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
16626         * breakpoint.c (create_overlay_event_breakpoint)
16627         (create_longjmp_master_breakpoint)
16628         (create_std_terminate_master_breakpoint)
16629         (create_exception_master_breakpoint): Use all_objfiles.
16630         * linux-thread-db.c (try_thread_db_load_from_pdir)
16631         (has_libpthread): Use all_objfiles.
16632         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
16633         * linespec.c (iterate_over_all_matching_symtabs)
16634         (search_minsyms_for_name): Use all_objfiles.
16635         * maint.c (maintenance_info_sections): Use all_objfiles.
16636         * main.c (captured_main_1): Use all_objfiles.
16637         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
16638         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
16639         * guile/scm-pretty-print.c
16640         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
16641         * solib-spu.c (append_ocl_sos): Use all_objfiles.
16642         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
16643         (maintenance_print_msymbols): Use all_objfiles.
16644         * source.c (select_source_symtab): Use all_objfiles.
16645         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
16646         * symfile.c (remove_symbol_file_command)
16647         (expand_symtabs_matching, map_symbol_filenames): Use
16648         all_objfiles.
16649         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
16650         all_objfiles.
16651         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
16652         * objc-lang.c (find_methods): Use all_objfiles.
16653         * objfiles.c (have_partial_symbols, have_full_symbols)
16654         (have_minimal_symbols, qsort_cmp)
16655         (default_iterate_over_objfiles_in_search_order): Use
16656         all_objfiles.
16657         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
16658         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
16659         (maintenance_check_psymtabs): Use all_objfiles.
16660         (ALL_PSYMTABS): Remove.
16661         * compile/compile-object-run.c (do_module_cleanup): Use
16662         all_objfiles.
16663         * blockframe.c (find_pc_partial_function): Use all_objfiles.
16664         * cp-support.c (add_symbol_overload_list_qualified): Use
16665         all_objfiles.
16666         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
16667         Use all_objfiles.
16668         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
16669         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
16670         all_objfiles.
16671         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
16672         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
16673         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
16674         Uses all_objfiles.
16675         * solib.c (solib_read_symbols): Use all_objfiles
16676
16677 2019-01-09  Tom Tromey  <tom@tromey.com>
16678
16679         * probe.c (parse_probes_in_pspace): Use all_objfiles.
16680         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
16681         all_objfiles.
16682         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
16683         * symmisc.c (print_symbol_bcache_statistics)
16684         (print_objfile_statistics, maintenance_print_objfiles)
16685         (maintenance_info_symtabs, maintenance_check_symtabs)
16686         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
16687         all_objfiles.
16688         * source.c (forget_cached_source_info): Use all_objfiles.
16689         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
16690         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
16691         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
16692         * objfiles.c (update_section_map): Use all_objfiles.
16693         (shared_objfile_contains_address_p): Likewise.
16694         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
16695         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
16696
16697 2019-01-09  Tom Tromey  <tom@tromey.com>
16698
16699         * common/next-iterator.h: New file.
16700         * objfiles.h (class all_objfiles): New.
16701         (struct objfile_iterator): New.
16702
16703 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
16704
16705         * NEWS: Move the description of the changed "frame", "select-frame",
16706          and "info frame" commands to the Changed commands section.
16707
16708 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
16709
16710         * gdbtypes.c (check_stub_method_group): Remove handling of old
16711         mangling schemes.
16712         * linespec.c (find_methods): Likewise.
16713         * stabsread.c (read_member_functions): Likewise.
16714         * valops.c (search_struct_method): Likewise.
16715         (value_struct_elt_for_reference): Likewise.
16716         * NEWS: Mention this change.
16717
16718 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
16719
16720         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
16721         print_source_lines.
16722         * source.c (print_source_lines_base): Update line number check.
16723         (print_source_lines): New function.
16724         (source_lines_range::source_lines_range): New function.
16725         * source.h (class source_lines_range): New class.
16726         (print_source_lines): New declaration.
16727
16728 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
16729
16730         * linespec.c (linespec_state_destructor): Free self->canonical_names.
16731
16732 2019-01-08  Tom Tromey  <tom@tromey.com>
16733             Simon Marchi  <simon.marchi@ericsson.com>
16734
16735         PR gdb/24060
16736         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
16737         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
16738         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
16739         * f-exp.y (DOLLAR_VARIABLE): Likewise.
16740         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
16741         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
16742
16743 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
16744
16745         * source.c (select_source_symtab): Move header comment to
16746         declaration in source.h.
16747         (forget_cached_source_info_for_objfile): Likewise.
16748         (forget_cached_source_info): Likewise.
16749         (identify_source_line): Likewise.
16750         * source.h (identify_source_line): Move declaration from symtab.h
16751         and add comment from source.c
16752         (print_source_lines): Likewise.
16753         (forget_cached_source_info_for_objfile): Likewise.
16754         (forget_cached_source_info): Likewise.
16755         (select_source_symtab): Likewise.
16756         (enum print_source_lines_flag): Move definition from symtab.h.
16757         * symtab.h (identify_source_line): Move declaration to source.h.
16758         (print_source_lines): Likewise.
16759         (forget_cached_source_info_for_objfile): Likewise.
16760         (forget_cached_source_info): Likewise.
16761         (select_source_symtab): Likewise.
16762         (enum print_source_lines_flag): Move definition to source.h.
16763         * tui/tui-hooks.c: Add 'source.h' include.
16764
16765 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
16766
16767         * source.c (print_source_lines_base): Handle requests to print
16768         reverse line number sequences, and guard against empty lines
16769         string.
16770
16771 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
16772
16773         * source.c (print_source_lines_base): Fix skip of '\r' if next
16774         character is '\n'.
16775
16776 2019-01-06  Tom Tromey  <tom@tromey.com>
16777
16778         * c-exp.y (struct c_parse_state) <macro_original_text,
16779         expansion_obstack>: New member.
16780         (macro_original_text, expansion_obstack): Remove globals.
16781         (scan_macro_expansion, scanning_macro_expansion)
16782         (finished_macro_expansion): Update.
16783         (scan_macro_cleanup): Remove.
16784         (yylex, c_parse): Update.
16785
16786 2019-01-06  Tom Tromey  <tom@tromey.com>
16787
16788         * c-exp.y (struct c_parse_state) <strings>: New member.
16789         (operator_stoken): Update.
16790
16791 2019-01-06  Tom Tromey  <tom@tromey.com>
16792
16793         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
16794         (union type_stack_elt) <typelist_val>: Now a pointer to
16795         std::vector.
16796         (type_stack_cleanup): Don't declare.
16797         (push_typelist): Update.
16798         * parse.c (pop_typelist): Return a std::vector.
16799         (push_typelist): Take a std::vector.
16800         (follow_types): Update.  Do not free args.
16801         (type_stack_cleanup): Remove.
16802         * c-exp.y (struct c_parse_state): New.
16803         (cpstate): New global.
16804         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
16805         (nonempty_typelist): Update.
16806         (func_mod): Create a new vector.
16807         (c_parse): Create a c_parse_state.
16808         (check_parameter_typelist): Do not delete params.
16809         (function_method): Update.  Do not delete type_list.
16810
16811 2019-01-06  Tom Tromey  <tom@tromey.com>
16812
16813         PR gdb/28155:
16814         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
16815         check_typedef.
16816         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
16817         (print_return_value): Likewise.
16818
16819 2019-01-05  Tom Tromey  <tom@tromey.com>
16820
16821         * contrib/cleanup_check.py: Remove.
16822         * contrib/gcc-with-excheck: Remove.
16823         * contrib/exsummary.py: Remove.
16824         * contrib/excheck.py: Remove.
16825
16826 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
16827
16828         * thread.c (delete_thread_1): Add gdb_assert that THR is not
16829         NULL. Initialize tpprev to NULL instead of assigning it
16830         to NULL on the next statement.
16831         * windows-nat.c (windows_delete_thread): Remove check for
16832         main_thread_id before printing thread exit notifications.
16833         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
16834         Remove thread ID check against main_thread_id.
16835         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
16836         windows_delete_thread.
16837         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
16838
16839 2019-01-04  Tom Tromey  <tom@tromey.com>
16840
16841         * compile/compile.c (_initialize_compile): Use upper case for
16842         metasyntactic variables.
16843         * symmisc.c (_initialize_symmisc): Use upper case for
16844         metasyntactic variables.
16845         * psymtab.c (_initialize_psymtab): Use upper case for
16846         metasyntactic variables.
16847         * demangle.c (demangle_command): Use upper case for metasyntactic
16848         variables.
16849         (_initialize_demangler): Likewise.
16850         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
16851         variables.
16852
16853 2019-01-03  Tom Tromey  <tom@tromey.com>
16854
16855         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
16856
16857 2019-01-03  Tom Tromey  <tom@tromey.com>
16858
16859         * python/py-symtab.c (salpy_str): Update.
16860         (struct salpy_sal_object) <symtab>: Now a PyObject.
16861         (salpy_dealloc): Update.
16862         (del_objfile_sal): Use gdbpy_ref.
16863
16864 2019-01-03  Tom Tromey  <tom@tromey.com>
16865
16866         * python/py-type.c (convert_field): Use new_reference.  Return
16867         gdbpy_ref.
16868         (make_fielditem): Return gdbpy_ref.
16869         (typy_fields): Update.
16870         (typy_getitem): Update.
16871         (field_name): Return gdbpy_ref.  Use new_reference.
16872         (typy_iterator_iternext): Update.
16873
16874 2019-01-03  Tom Tromey  <tom@tromey.com>
16875
16876         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
16877
16878 2019-01-03  Tom Tromey  <tom@tromey.com>
16879
16880         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
16881         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
16882         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
16883         (pspy_set_frame_filters, pspy_set_frame_unwinders)
16884         (pspy_set_type_printers): Likewise.
16885         * python/py-function.c (fnpy_init): Use gdbpy_ref.
16886         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
16887         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
16888         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
16889         (objfpy_set_type_printers): Likewise.
16890
16891 2019-01-03  Tom Tromey  <tom@tromey.com>
16892
16893         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
16894         (gdbpy_print_stack): Use gdbpy_err_fetch.
16895         * python/python-internal.h (class gdbpy_err_fetch): New class.
16896         (class gdbpy_enter) <m_error_type, m_error_value,
16897         m_error_traceback>: Remove.
16898         <m_error>: New member.
16899         (gdbpy_exception_to_string): Don't declare.
16900         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
16901         * python/py-value.c (convert_value_from_python): Use
16902         gdbpy_err_fetch.
16903         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
16904         gdbpy_exception_to_string.
16905         (gdbpy_handle_exception): Use gdbpy_err_fetch.
16906         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
16907         gdbpy_err_fetch.
16908
16909 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
16910
16911         * linux-nat.c (delete_lwp_cleanup): Delete.
16912         (struct lwp_deleter): New struct.
16913         (lwp_info_up): New typedef.
16914         (linux_nat_target::follow_fork): Delete cleanup, and make use of
16915         lwp_info_up.
16916
16917 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
16918
16919         * linux-fork.c (class scoped_switch_fork_info): New class.
16920         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
16921
16922 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
16923
16924         * valops.c (find_overload_match): Remove use of null_cleanup, and
16925         calls to do_cleanups.
16926
16927 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
16928
16929         * compile/compile-cplus-types.c
16930         (compile_cplus_instance::decl_name): Handle changes to
16931         cp_func_name.
16932         * cp-support.c (cp_func_name): Update header comment, update
16933         return type.
16934         * cp-support.h (cp_func_name): Update return type in declaration.
16935         * valops.c (find_overload_match): Move temp_func local to top
16936         level of function and change its type.  Use temp_func to hold and
16937         delete temporary string obtained from cp_func_name.
16938
16939 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
16940
16941         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
16942         gdb::char_vector, remove cleanup, and update uses of `msg`.
16943
16944 2019-01-03  Jim Wilson  <jimw@sifive.com>
16945
16946         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
16947
16948 2019-01-02  Tom Tromey  <tom@tromey.com>
16949
16950         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
16951         (tdesc_parse_xml): Remove cleanups.
16952         * target-descriptions.h (make_cleanup_free_target_description):
16953         Don't declare.
16954         (target_desc_deleter): New struct.
16955         (target_desc_up): New typedef.
16956         * target-descriptions.c (target_desc_deleter::operator()): Rename
16957         from free_target_description.
16958         (make_cleanup_free_target_description): Remove.
16959
16960 2019-01-02  Tom Tromey  <tom@tromey.com>
16961
16962         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
16963         constructor, destructor.
16964         (linespec_parser): Remove typedef.
16965         (~linespec_parser): Rename from linespec_parser_delete.
16966         (linespec_lex_to_end, linespec_complete_label)
16967         (linespec_complete): Update.
16968         (decode_line_full): Remove cleanups.
16969         (decode_line_1): Update.
16970
16971 2019-01-02  Tom Tromey  <tom@tromey.com>
16972
16973         * python/python-internal.h (inferior_to_inferior_object): Change
16974         return type.
16975         * python/py-exitedevent.c (create_exited_event_object): Update.
16976         * python/py-inferior.c (inferior_to_inferior_object): Return
16977         gdbpy_ref.
16978         (python_new_inferior, python_inferior_deleted)
16979         (thread_to_thread_object, delete_thread_object)
16980         (build_inferior_list, gdbpy_selected_inferior): Update.
16981         * python/py-infthread.c (create_thread_object): Update.  Also fail
16982         if inferior_to_inferior_object fails.
16983
16984 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
16985
16986         * inferior.h (class inferior) <displaced_step_state>: New field.
16987         * infrun.h (struct displaced_step_state): Move here from
16988         infrun.c.  Initialize fields, add constructor.
16989         <inf>: Remove field.
16990         <reset>: New method.
16991         * infrun.c (struct displaced_step_inferior_state): Move to
16992         infrun.h.
16993         (displaced_step_inferior_states): Remove.
16994         (get_displaced_stepping_state): Adust.
16995         (displaced_step_in_progress_any_inferior): Adjust.
16996         (displaced_step_in_progress_thread): Adjust.
16997         (displaced_step_in_progress): Adjust.
16998         (add_displaced_stepping_state): Remove.
16999         (get_displaced_step_closure_by_addr): Adjust.
17000         (remove_displaced_stepping_state): Remove.
17001         (infrun_inferior_exit): Call displaced_step_state.reset.
17002         (use_displaced_stepping): Don't check for NULL.
17003         (displaced_step_prepare_throw): Call
17004         get_displaced_stepping_state.
17005         (displaced_step_fixup): Don't check for NULL.
17006         (prepare_for_detach): Don't check for NULL.
17007
17008 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
17009
17010         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
17011          in case of call that did not complete.
17012
17013 2019-01-02  Andrey Utkin  <autkin@undo.io>
17014
17015         * symfile.c (find_separate_debug_file): Fix search of debug files for
17016         remote debuggee.
17017
17018 2019-01-02  Tom Tromey  <tom@tromey.com>
17019
17020         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
17021         indentation.
17022         * python/py-frame.c (frapy_older): Remove cast.
17023         (frapy_newer): Likewise.
17024         * python/py-breakpoint.c (local_setattro): Remove cast.
17025         * python/py-arch.c (archpy_name): Remove local variable.
17026         * python/py-type.c (gdbpy_lookup_type): Remove cast.
17027
17028 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
17029
17030         * unittests/basic_string_view/element_access/char/empty.cc:
17031         Fix year range in copyright header.
17032
17033 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
17034
17035         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
17036         Delete.
17037         <operator==>: Update with for removed field.
17038         <hash>: Likewise.
17039         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
17040         <isa_features>: ...this.
17041         <abi_features>: New field.
17042         (riscv_isa_flen): Update comment.
17043         (riscv_abi_xlen): New declaration.
17044         (riscv_abi_flen): New declaration.
17045         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
17046         isa_features.
17047         (riscv_abi_xlen): New function.
17048         (riscv_isa_flen): Update to get answer from isa_features.
17049         (riscv_abi_flen): New function.
17050         (riscv_has_fp_abi): Update to get answer from abi_features.
17051         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
17052         xlen and flen.
17053         (riscv_call_info) <xlen, flen>: Update comment.
17054         (riscv_call_arg_struct): Remove invalid assertions
17055         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
17056         is removed.
17057         (riscv_gdbarch_init): Gather isa features and abi features
17058         separately, ensure both match on the gdbarch when reusing an old
17059         gdbarch.  Relax an error check to allow 32-bit abi float to run on
17060         a target with 64-bit float hardware.
17061
17062 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
17063
17064         * source.c (search_command_helper): Stop reverse search
17065         when line 1 has been searched.
17066
17067 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
17068
17069         * record-full.c (record_full_base_target::close): Rewrite
17070         record_full_core_buf_list free logic.
17071
17072 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
17073
17074         * break-catch-syscall.c (print_one_catch_syscall): xfree
17075         the last text.
17076
17077 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
17078
17079         * top.c (print_gdb_version): Update Copyright year in version
17080         message.
17081
17082 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
17083
17084         Update copyright year range in all GDB files.
17085
17086 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
17087
17088         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
17089
17090 For older changes see ChangeLog-2018.
17091 \f
17092 Local Variables:
17093 mode: change-log
17094 left-margin: 8
17095 fill-column: 74
17096 version-control: never
17097 coding: utf-8
17098 End:
17099