gdb/ChangeLog

   1 2019-11-22  Tom Tromey  <tom@tromey.com>
   2
   3         * observable.h: Update comments.
   4
   5 2019-11-22  Tom Tromey  <tromey@adacore.com>
   6
   7         * ada-tasks.c (ada_task_is_alive): Make parameter const.
   8         (print_ada_task_info): Don't try to fetch thread id if task is not
   9         alive.
  10
  11 2019-11-22  Christian Biesinger  <cbiesinger@google.com>
  12
  13         * ada-exp.y: Update.
  14         * ada-lang.c (sort_choices): Update.
  15         (ada_print_symbol_signature): Update.
  16         (resolve_subexp): Update.
  17         (ada_parse_renaming): Update.
  18         (ada_read_renaming_var_value): Update.
  19         (lesseq_defined_than): Update.
  20         (remove_extra_symbols): Update.
  21         (remove_irrelevant_renamings): Update.
  22         (ada_add_block_symbols): Update.
  23         (ada_collect_symbol_completion_matches): Update.
  24         (ada_is_renaming_symbol): Update.
  25         (aggregate_assign_from_choices): Update.
  26         (ada_evaluate_subexp): Update.
  27         (ada_has_this_exception_support): Update.
  28         (ada_is_non_standard_exception_sym): Update.
  29         (ada_add_exceptions_from_frame): Update.
  30         (ada_add_global_exceptions): Update.
  31         (ada_print_subexp): Update.
  32         * ax-gdb.c (gen_var_ref): Update.
  33         (gen_maybe_namespace_elt): Update.
  34         (gen_expr_for_cast): Update.
  35         (gen_expr): Update.
  36         * block.h: Update.
  37         * blockframe.c (find_pc_partial_function): Update.
  38         * breakpoint.c (print_breakpoint_location): Update.
  39         (update_static_tracepoint): Update.
  40         * btrace.c (ftrace_print_function_name): Update.
  41         (ftrace_function_switched): Update.
  42         * buildsym.c (find_symbol_in_list): Update.
  43         * c-exp.y: Update.
  44         * c-typeprint.c (c_print_typedef): Update.
  45         (c_type_print_template_args): Update.
  46         * cli/cli-cmds.c (edit_command): Update.
  47         (list_command): Update.
  48         (print_sal_location): Update.
  49         * coffread.c (patch_opaque_types): Update.
  50         (process_coff_symbol): Update.
  51         (coff_read_enum_type): Update.
  52         * compile/compile-c-symbols.c (c_symbol_substitution_name): Update.
  53         (convert_one_symbol): Update.
  54         (hash_symname): Update.
  55         (eq_symname): Update.
  56         * compile/compile-cplus-symbols.c (convert_one_symbol): Update.
  57         * compile/compile-cplus-types.c (debug_print_scope): Update.
  58         * compile/compile-loc2c.c (do_compile_dwarf_expr_to_c): Update.
  59         * compile/compile-object-load.c (get_out_value_type): Update.
  60         * cp-namespace.c (cp_scan_for_anonymous_namespaces): Update.
  61         (search_symbol_list): Update.
  62         (cp_lookup_symbol_imports_or_template): Update.
  63         * cp-support.c (overload_list_add_symbol): Update.
  64         * ctfread.c (psymtab_to_symtab): Update.
  65         * dbxread.c (cp_set_block_scope): Update.
  66         * dictionary.c (iter_match_first_hashed): Update.
  67         (iter_match_next_hashed): Update.
  68         (insert_symbol_hashed): Update.
  69         (iter_match_next_linear): Update.
  70         * dictionary.h: Update.
  71         * dwarf2loc.c (func_get_frame_base_dwarf_block): Update.
  72         (locexpr_describe_location_piece): Update.
  73         (locexpr_describe_location_1): Update.
  74         (locexpr_generate_c_location): Update.
  75         (loclist_describe_location): Update.
  76         (loclist_generate_c_location): Update.
  77         * dwarf2read.c (dw2_debug_names_lookup_symbol): Update.
  78         (read_func_scope): Update.
  79         (process_enumeration_scope): Update.
  80         (new_symbol): Update.
  81         (dwarf2_const_value): Update.
  82         (dwarf2_symbol_mark_computed): Update.
  83         * eval.c (evaluate_funcall): Update.
  84         (evaluate_subexp_standard): Update.
  85         * expprint.c (print_subexp_standard): Update.
  86         (dump_subexp_body_standard): Update.
  87         * f-valprint.c (info_common_command_for_block): Update.
  88         * findvar.c (get_hosting_frame): Update.
  89         (default_read_var_value): Update.
  90         * go-lang.c (go_symbol_package_name): Update.
  91         * guile/scm-block.c (bkscm_print_block_smob): Update.
  92         * guile/scm-symbol.c (syscm_print_symbol_smob): Update.
  93         (gdbscm_symbol_name): Update.
  94         (gdbscm_symbol_linkage_name): Update.
  95         (gdbscm_symbol_print_name): Update.
  96         * infcall.c (get_function_name): Update.
  97         * infcmd.c (jump_command): Update.
  98         (finish_command): Update.
  99         * infrun.c (insert_exception_resume_breakpoint): Update.
 100         * linespec.c (canonicalize_linespec): Update.
 101         (create_sals_line_offset): Update.
 102         (convert_linespec_to_sals): Update.
 103         (complete_label): Update.
 104         (find_label_symbols_in_block): Update.
 105         * m2-typeprint.c (m2_print_typedef): Update.
 106         * mdebugread.c (mdebug_reg_to_regnum): Update.
 107         (parse_symbol): Update.
 108         (mylookup_symbol): Update.
 109         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
 110         (list_args_or_locals): Update.
 111         * objc-lang.c (compare_selectors): Update.
 112         (info_selectors_command): Update.
 113         (compare_classes): Update.
 114         (info_classes_command): Update.
 115         (find_imps): Update.
 116         * p-typeprint.c (pascal_print_typedef): Update.
 117         * printcmd.c (build_address_symbolic): Update.
 118         (info_address_command): Update.
 119         (print_variable_and_value): Update.
 120         * python/py-framefilter.c (extract_sym): Update.
 121         (py_print_single_arg): Update.
 122         * python/py-symbol.c (sympy_str): Update.
 123         (sympy_get_name): Update.
 124         (sympy_get_linkage_name): Update.
 125         * python/python.c (gdbpy_rbreak): Update.
 126         * record-btrace.c (btrace_get_bfun_name): Update.
 127         (btrace_call_history): Update.
 128         * rust-lang.c (rust_print_typedef): Update.
 129         * solib-frv.c (frv_fdpic_find_canonical_descriptor): Update.
 130         * stabsread.c (stab_reg_to_regnum): Update.
 131         (define_symbol): Update.
 132         (read_enum_type): Update.
 133         (common_block_end): Update.
 134         (cleanup_undefined_types_1): Update.
 135         (scan_file_globals): Update.
 136         * stack.c (print_frame_arg): Update.
 137         (print_frame_args): Update.
 138         (find_frame_funname): Update.
 139         (info_frame_command_core): Update.
 140         (iterate_over_block_locals): Update.
 141         (print_block_frame_labels): Update.
 142         (do_print_variable_and_value): Update.
 143         (iterate_over_block_arg_vars): Update.
 144         (return_command): Update.
 145         * symmisc.c (dump_symtab_1): Update.
 146         (print_symbol): Update.
 147         * symtab.c (eq_symbol_entry): Update.
 148         (symbol_cache_dump): Update.
 149         (lookup_language_this): Update.
 150         (find_pc_sect_line): Update.
 151         (skip_prologue_sal): Update.
 152         (symbol_search::compare_search_syms): Update.
 153         (treg_matches_sym_type_name): Update.
 154         (search_symbols): Update.
 155         (print_symbol_info): Update.
 156         (rbreak_command): Update.
 157         (completion_list_add_symbol): Update.
 158         (find_gnu_ifunc): Update.
 159         (get_symbol_address): Update.
 160         (search_module_symbols): Update.
 161         (info_module_subcommand): Update.
 162         * symtab.h (SYMBOL_NATURAL_NAME): Remove.
 163         (SYMBOL_LINKAGE_NAME): Remove.
 164         (SYMBOL_DEMANGLED_NAME): Remove.
 165         (SYMBOL_PRINT_NAME): Remove.
 166         (SYMBOL_SEARCH_NAME): Remove.
 167         * tracepoint.c (set_traceframe_context): Update.
 168         (validate_actionline): Update.
 169         (collection_list::collect_symbol): Update.
 170         (encode_actions_1): Update.
 171         (info_scope_command): Update.
 172         (print_one_static_tracepoint_marker): Update.
 173         * typeprint.c (typedef_hash_table::add_template_parameters): Update.
 174         * valops.c (address_of_variable): Update.
 175         (find_overload_match): Update.
 176         (find_oload_champ): Update.
 177
 178 2019-11-22  Christian Biesinger  <cbiesinger@google.com>
 179
 180         * ada-lang.c (ada_lookup_simple_minsym): Update.
 181         (ada_collect_symbol_completion_matches): Update.
 182         * ada-tasks.c (read_atcb): Update.
 183         * amd64-windows-tdep.c (amd64_skip_main_prologue): Update.
 184         (amd64_windows_skip_trampoline_code): Update.
 185         * arm-tdep.c (skip_prologue_function): Update.
 186         (arm_skip_stack_protector): Update.
 187         * arm-wince-tdep.c (arm_pe_skip_trampoline_code): Update.
 188         (arm_wince_skip_main_prologue): Update.
 189         * ax-gdb.c (gen_expr): Update.
 190         * block.c (call_site_for_pc): Update.
 191         * blockframe.c (find_pc_partial_function): Update.
 192         * breakpoint.c (set_breakpoint_location_function): Update.
 193         * btrace.c (ftrace_print_function_name): Update.
 194         (ftrace_function_switched): Update.
 195         * c-valprint.c (print_unpacked_pointer): Update.
 196         * coffread.c (coff_symfile_read): Update.
 197         * compile/compile-c-symbols.c (convert_symbol_bmsym): Update.
 198         * compile/compile-cplus-symbols.c (convert_symbol_bmsym): Update.
 199         * dwarf-index-write.c (write_psymbols): Update.
 200         * dwarf2loc.c (call_site_to_target_addr): Update.
 201         (func_verify_no_selftailcall): Update.
 202         (tailcall_dump): Update.
 203         (call_site_find_chain_1): Update.
 204         (dwarf_expr_reg_to_entry_parameter): Update.
 205         * elfread.c (elf_gnu_ifunc_record_cache): Update.
 206         * eval.c (evaluate_funcall): Update.
 207         (evaluate_subexp_standard): Update.
 208         (evaluate_subexp_for_sizeof): Update.
 209         * expprint.c (print_subexp_standard): Update.
 210         (dump_subexp_body_standard): Update.
 211         * frame.c (get_prev_frame_always_1): Update.
 212         * frv-tdep.c (frv_skip_main_prologue): Update.
 213         * gnu-v2-abi.c (gnuv2_value_rtti_type): Update.
 214         * gnu-v3-abi.c (gnuv3_rtti_type): Update.
 215         (gnuv3_get_typename_from_type_info): Update.
 216         (gnuv3_skip_trampoline): Update.
 217         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
 218         * i386-tdep.c (i386_skip_main_prologue): Update.
 219         (i386_pe_skip_trampoline_code): Update.
 220         * ia64-tdep.c (ia64_convert_from_func_ptr_addr): Update.
 221         * infcall.c (get_function_name): Update.
 222         * linespec.c (minsym_found): Update.
 223         * linux-fork.c (info_checkpoints_command): Update.
 224         * m32c-tdep.c (m32c_m16c_address_to_pointer): Update.
 225         (m32c_m16c_pointer_to_address): Update.
 226         * maint.c (maintenance_translate_address): Update.
 227         * minsyms.c (add_minsym_to_hash_table): Update.
 228         (add_minsym_to_demangled_hash_table): Update.
 229         (lookup_minimal_symbol_mangled): Update.
 230         (lookup_minimal_symbol_demangled): Update.
 231         (lookup_minimal_symbol_linkage): Update.
 232         (lookup_minimal_symbol_text): Update.
 233         (lookup_minimal_symbol_by_pc_name): Update.
 234         (minimal_symbol_is_less_than): Update.
 235         (compact_minimal_symbols): Update.
 236         (build_minimal_symbol_hash_tables): Update.
 237         (find_solib_trampoline_target): Update.
 238         * mips-tdep.c (mips_stub_frame_sniffer): Update.
 239         (mips_skip_pic_trampoline_code): Update.
 240         * msp430-tdep.c (msp430_skip_trampoline_code): Update.
 241         * objc-lang.c (info_selectors_command): Update.
 242         (info_classes_command): Update.
 243         (find_methods): Update.
 244         (find_imps): Update.
 245         * p-valprint.c (pascal_val_print): Update.
 246         * ppc-linux-tdep.c (powerpc_linux_in_dynsym_resolve_code): Update.
 247         * ppc-sysv-tdep.c (convert_code_addr_to_desc_addr): Update.
 248         * printcmd.c (build_address_symbolic): Update.
 249         (info_symbol_command): Update.
 250         * psymtab.c (psymbol_name_matches): Update.
 251         (match_partial_symbol): Update.
 252         (lookup_partial_symbol): Update.
 253         (print_partial_symbols): Update.
 254         (sort_pst_symbols): Update.
 255         (maintenance_check_psymtabs): Update.
 256         * python/py-framefilter.c (py_print_frame): Update.
 257         * python/python.c (gdbpy_rbreak): Update.
 258         * record-btrace.c (btrace_get_bfun_name): Update.
 259         (btrace_call_history): Update.
 260         * rs6000-tdep.c (rs6000_skip_main_prologue): Update.
 261         (rs6000_skip_trampoline_code): Update.
 262         * sol-thread.c (info_cb): Update.
 263         * stabsread.c (scan_file_globals): Update.
 264         * stack.c (find_frame_funname): Update.
 265         (info_frame_command_core): Update.
 266         * symmisc.c (dump_msymbols): Update.
 267         * symtab.c (symbol_natural_name): Rename to..,
 268         (general_symbol_info::natural_name): ...this.
 269         (symbol_demangled_name): Rename to...
 270         (general_symbol_info::demangled_name): ...this.
 271         (symbol_search_name): Rename to...
 272         (general_symbol_info::search_name): ...this.
 273         (symbol_matches_search_name): Update.
 274         (find_pc_sect_line): Update.
 275         (skip_prologue_sal): Update.
 276         (search_symbols): Update.
 277         (print_msymbol_info): Update.
 278         (rbreak_command): Update.
 279         (completion_list_add_msymbol): Update.
 280         (completion_list_objc_symbol): Update.
 281         (get_msymbol_address): Update.
 282         * symtab.h (struct general_symbol_info): Add member functions
 283         natural_name (), linkage_name (), print_name (), demangled_name (),
 284         and search_name ().
 285         (SYMBOL_NATURAL_NAME): Update.
 286         (symbol_natural_name): Move to a member function on general_symbol_info.
 287         (SYMBOL_DEMANGLED_NAME): Update.
 288         (symbol_demangled_name): Move to a member function on
 289         general_symbol_info.
 290         (SYMBOL_SEARCH_NAME): Update.
 291         (symbol_search_name): Move to a member function on general_symbol_info.
 292         (MSYMBOL_NATURAL_NAME): Remove.
 293         (MSYMBOL_LINKAGE_NAME): Remove.
 294         (MSYMBOL_PRINT_NAME): Remove.
 295         (MSYMBOL_DEMANGLED_NAME): Remove.
 296         (MSYMBOL_SEARCH_NAME): Remove.
 297         * x86-tdep.c (x86_in_indirect_branch_thunk): Update.
 298
 299 2019-11-22  Christian Biesinger  <cbiesinger@google.com>
 300
 301         * symtab.c (create_demangled_names_hash): Use per_bfd->
 302         minimal_symbol_count for computing the initial size, if greater
 303         than our default size.
 304
 305 2019-11-22  Tom de Vries  <tdevries@suse.de>
 306
 307         * contrib/words.sh: Improve words extraction.
 308
 309 2019-11-22  Tom de Vries  <tdevries@suse.de>
 310
 311         * contrib/words.sh: Combine sed invocations.
 312
 313 2019-11-21  Christian Biesinger  <cbiesinger@google.com>
 314
 315         * Makefile.in: Update.
 316         * demangle.c: Rename to...
 317         * gdb-demangle.c: ..this.
 318         (is_cplus_marker): Change return type to bool.
 319         (_initialize_demangler): Rename to...
 320         (_initialize_gdb_demangle): ...this.
 321         * gdb-demangle.h (is_cplus_marker): Change return type to bool.
 322         * symtab.h (demangle): Remove declaration; instead include
 323         gdb-demangle.h.
 324
 325 2019-11-21  Tom Tromey  <tromey@adacore.com>
 326
 327         * gdbsupport/format.c (format_pieces): Parse %I64d.
 328         * unittests/format_pieces-selftests.c (test_windows_formats): New
 329         function.
 330         (run_tests): Call it.
 331
 332 2019-11-21  Peeter Joot  <peeter.joot@lzlabs.com>
 333
 334         Byte reverse display of variables with DW_END_big, DW_END_little
 335         (DW_AT_endianity) dwarf attributes if different than the native
 336         byte order.
 337         * ada-lang.c (ada_value_binop):
 338         Use type_byte_order instead of gdbarch_byte_order.
 339         * ada-valprint.c (printstr):
 340         (ada_val_print_string):
 341         * ada-lang.c (value_pointer):
 342         (ada_value_binop):
 343         Use type_byte_order instead of gdbarch_byte_order.
 344         * c-lang.c (c_get_string):
 345         Use type_byte_order instead of gdbarch_byte_order.
 346         * c-valprint.c (c_val_print_array):
 347         Use type_byte_order instead of gdbarch_byte_order.
 348         * cp-valprint.c (cp_print_class_member):
 349         Use type_byte_order instead of gdbarch_byte_order.
 350         * dwarf2loc.c (rw_pieced_value):
 351         Use type_byte_order instead of gdbarch_byte_order.
 352         * dwarf2read.c (read_base_type): Handle DW_END_big,
 353         DW_END_little
 354         * f-lang.c (f_get_encoding):
 355         Use type_byte_order instead of gdbarch_byte_order.
 356         * findvar.c (default_read_var_value):
 357         Use type_byte_order instead of gdbarch_byte_order.
 358         * gdbtypes.c (check_types_equal):
 359         Require matching TYPE_ENDIANITY_NOT_DEFAULT if set.
 360         (recursive_dump_type): Print TYPE_ENDIANITY_BIG,
 361         and TYPE_ENDIANITY_LITTLE if set.
 362         (type_byte_order): new function.
 363         * gdbtypes.h (TYPE_ENDIANITY_NOT_DEFAULT): New macro.
 364         (struct main_type) <flag_endianity_not_default>:
 365         New field.
 366         (type_byte_order): New function.
 367         * infcmd.c (default_print_one_register_info):
 368         Use type_byte_order instead of gdbarch_byte_order.
 369         * p-lang.c (pascal_printstr):
 370         Use type_byte_order instead of gdbarch_byte_order.
 371         * p-valprint.c (pascal_val_print):
 372         Use type_byte_order instead of gdbarch_byte_order.
 373         * printcmd.c (print_scalar_formatted):
 374         Use type_byte_order instead of gdbarch_byte_order.
 375         * solib-darwin.c (darwin_current_sos):
 376         Use type_byte_order instead of gdbarch_byte_order.
 377         * solib-svr4.c (solib_svr4_r_ldsomap):
 378         Use type_byte_order instead of gdbarch_byte_order.
 379         * stap-probe.c (stap_modify_semaphore):
 380         Use type_byte_order instead of gdbarch_byte_order.
 381         * target-float.c (target_float_same_format_p):
 382         Use type_byte_order instead of gdbarch_byte_order.
 383         * valarith.c (scalar_binop):
 384         (value_bit_index):
 385         Use type_byte_order instead of gdbarch_byte_order.
 386         * valops.c (value_cast):
 387         Use type_byte_order instead of gdbarch_byte_order.
 388         * valprint.c (generic_emit_char):
 389         (generic_printstr):
 390         (val_print_string):
 391         Use type_byte_order instead of gdbarch_byte_order.
 392         * value.c (unpack_long):
 393         (unpack_bits_as_long):
 394         (unpack_value_bitfield):
 395         (modify_field):
 396         (pack_long):
 397         (pack_unsigned_long):
 398         Use type_byte_order instead of gdbarch_byte_order.
 399         * findvar.c (unsigned_pointer_to_address):
 400         (signed_pointer_to_address):
 401         (unsigned_address_to_pointer):
 402         (address_to_signed_pointer):
 403         (default_read_var_value):
 404         (default_value_from_register):
 405         Use type_byte_order instead of gdbarch_byte_order.
 406         * gnu-v3-abi.c (gnuv3_make_method_ptr):
 407         Use type_byte_order instead of gdbarch_byte_order.
 408         * riscv-tdep.c (riscv_print_one_register_info):
 409         Use type_byte_order instead of gdbarch_byte_order.
 410
 411 2019-11-21  Simon Marchi  <simon.marchi@polymtl.ca>
 412
 413         * top.c (current_ui_gdb_stdout_ptr): Spell out by hand.
 414         (current_ui_gdb_stdin_ptr): Likewise.
 415         (current_ui_gdb_stderr_ptr): Likewise.
 416         (current_ui_gdb_stdlog_ptr): Likewise.
 417         (current_ui_current_uiout_ptr): Likewise.
 418         (gen_ret_current_ui_field_ptr): Remove.
 419
 420 2019-11-21  Tom de Vries  <tdevries@suse.de>
 421
 422         PR gdb/24956
 423         * cli/cli-script.c (execute_control_command): Only switch to
 424         INTERP_CONSOLE's ui_out when INTERP_MI is active.
 425
 426 2019-11-19  Tom Tromey  <tom@tromey.com>
 427
 428         * tui/tui-win.c (tui_partial_win_by_name): Move from tui-data.c.
 429         Now static.  Change type of "name".
 430         (tui_set_win_height_command): Don't copy "arg".
 431         * tui/tui-data.h (tui_partial_win_by_name): Don't declare.
 432         * tui/tui-data.c (tui_partial_win_by_name): Move to tui-win.c.
 433
 434 2019-11-19  Ali Tamur <tamur@google.com>
 435
 436         * dwarf2read.c (dw2_get_file_names_reader): Replace "if (attr)" with
 437         "if (attr != nullptr)".
 438         (dwarf2_find_base_address): Likewise.
 439         (dwarf2_build_include_psymtabs): Likewise.
 440         (read_cutu_die_from_dwo): Likewise.
 441         (read_func_scope): Likewise.
 442         (read_call_site_scope): Likewise.
 443         (dwarf2_get_pc_bounds): Likewise.
 444         (dwarf2_record_block_ranges): Likewise.
 445         (dwarf2_add_field): Likewise.
 446         (dwarf2_add_member_fn): Likewise.
 447         (read_structure_type): Likewise.
 448         (read_enumeration_type): Likewise.
 449         (read_array_type): Likewise.
 450         (read_array_order): Likewise.
 451         (read_set_type): Likewise.
 452         (read_common_block): Likewise.
 453         (read_tag_reference_type): Likewise.
 454         (read_tag_string_type): Likewise.
 455         (read_subroutine_type): Likewise.
 456         (read_base_type): Likewise.
 457         (read_subrange_type): Likewise.
 458         (new_symbol): Likewise.
 459         (prepare_one_comp_unit): Likewise.
 460
 461 2019-11-19  Tom Tromey  <tromey@adacore.com>
 462
 463         * windows-nat.c (windows_nat_target::attach): Include GetLastError
 464         result in error when DebugActiveProcess fails.
 465
 466 2019-11-18  Sergio Durigan Junior  <sergiodj@redhat.com>
 467             Pedro Alves  <palves@redhat.com>
 468
 469         https://bugzilla.redhat.com/show_bug.cgi?id=1765117
 470         * target.c (target_stack::push): Call 'unpush' if there's a
 471         target on top of the stack.
 472
 473 2019-11-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 474
 475         * python/py-block.c (blpy_dealloc): Call tp_free.
 476         (blpy_block_syms_dealloc): Likewise.
 477         * python/py-finishbreakpoint.c (bpfinishpy_dealloc): Likewise.
 478         * python/py-inferior.c (infpy_dealloc): Likewise.
 479         * python/py-lazy-string.c (stpy_dealloc): Likewise.
 480         * python/py-linetable.c (ltpy_iterator_dealloc): Likewise.
 481         * python/py-symbol.c (sympy_dealloc): Likewise.
 482         * python/py-symtab.c (stpy_dealloc): Likewise.
 483         * python/py-type.c (typy_iterator_dealloc): Likewise.
 484
 485 2019-11-18  Christian Biesinger  <cbiesinger@google.com>
 486
 487         * symtab.h (struct symbol) <owner>: Initialize explicitly in the
 488         constructor instead of using a class initializer.
 489
 490 2019-11-15  Christian Biesinger  <cbiesinger@google.com>
 491
 492         * Makefile.in: Replace {posix,mingw}-strerror.c with safe-strerror.c.
 493         * configure: Regenerate.
 494         * configure.ac: Don't source common.host.
 495         * gdbsupport/common.host: Remove.
 496         * gdbsupport/mingw-strerror.c: Remove.
 497         * gdbsupport/posix-strerror.c: Rename to...
 498         * gdbsupport/safe-strerror.c: ...this.
 499
 500 2019-11-15  Christian Biesinger  <cbiesinger@google.com>
 501
 502         * maint.c (scoped_command_stats::print_time): Use localtime_r
 503         instead of localtime (provided through gnulib if necessary).
 504         * nat/linux-osdata.c (time_from_time_t): Use ctime_r instead
 505         of ctime.
 506
 507 2019-11-15  Christian Biesinger  <cbiesinger@google.com>
 508
 509         * gdbsupport/common-defs.h: Include time.h before pathmax.h to
 510         avoid compile errors.
 511
 512 2019-11-15  Christian Biesinger  <cbiesinger@google.com>
 513
 514         * config.in: Regenerate.
 515         * configure: Regenerate.
 516         * gdbsupport/common.m4: No longer check for strerror_r.
 517         * gdbsupport/posix-strerror.c (safe_strerror): Always call the
 518         POSIX version of strerror_r, now that gnulib provides it if
 519         necessary.
 520
 521 2019-11-14  Christian Biesinger  <cbiesinger@google.com>
 522
 523         * README (`configure' options): Update.
 524
 525 2019-11-14  Tom Tromey  <tromey@adacore.com>
 526
 527         * eval.c (evaluate_subexp_standard) <BINOP_ASSIGN>: Do not pass an
 528         expected type for the RHS if the LHS is a convenience variable.
 529
 530 2019-11-14  Simon Marchi  <simon.marchi@polymtl.ca>
 531
 532         * unittests/vec-utils-selftests.c (unordered_remove_tests::obj):
 533         Provide explicit default and copy constructor.
 534
 535 2019-11-14  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 536
 537         * python/py-finishbreakpoint.c (gdbpy_breakpoint_created):
 538         only call Py_INCREF (newbp) in the bppy_pending_object case.
 539
 540 2019-11-13  Tom Tromey  <tromey@adacore.com>
 541
 542         PR build/25182:
 543         * psympriv.h (partial_symbol): Remove static assert.
 544         * symtab.h (general_symbol_info, symbol): Remove static assert.
 545
 546 2019-11-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 547
 548         * gdbsupport/format.c (format_pieces::format_pieces): Support
 549         printf 'z' size modifier.
 550         * gdbsupport/format.h (enum argclass): Add size_t_arg.
 551         * printcmd.c (ui_printf):  Handle size_t_arg.
 552         * ui-out.c (ui_out::vmessage): Likewise.
 553         * unittests/format_pieces-selftests.c (test_format_int_sizes): New
 554         function.
 555         (run_tests): Call test_format_int_sizes.
 556
 557 2019-11-12  Christian Biesinger  <cbiesinger@google.com>
 558
 559         * ada-exp.y (write_ambiguous_var): Update.
 560         * buildsym.c (add_symbol_to_list): Update.
 561         * dwarf2read.c (read_variable): Update.
 562         (new_symbol): Update.
 563         * jit.c (finalize_symtab): Update.
 564         * language.c (language_alloc_type_symbol): Update.
 565         * symtab.c (fixup_symbol_section): Update.
 566         (initialize_objfile_symbol_1): Move code to...
 567         (initialize_objfile_symbol): ...here. Remove now-unnecessary memset.
 568         (allocate_symbol): Update.
 569         (allocate_template_symbol): Update.
 570         (get_symbol_address): Update.
 571         * symtab.h (struct symbol): Inherit from general_symbol_info instead
 572         of having as a field, and add a constructor.
 573         (SYMBOL_VALUE): Update.
 574         (SYMBOL_VALUE_ADDRESS): Update.
 575         (SET_SYMBOL_VALUE_ADDRESS): Update.
 576         (SYMBOL_VALUE_BYTES): Update.
 577         (SYMBOL_VALUE_COMMON_BLOCK): Update.
 578         (SYMBOL_BLOCK_VALUE): Update.
 579         (SYMBOL_VALUE_CHAIN): Update.
 580         (SYMBOL_LANGUAGE): Update.
 581         (SYMBOL_SECTION): Update.
 582         (SYMBOL_OBJ_SECTION): Update.
 583         (SYMBOL_SET_LANGUAGE): Update.
 584         (SYMBOL_SET_LINKAGE_NAME): Update.
 585         (SYMBOL_SET_NAMES): Update.
 586         (SYMBOL_NATURAL_NAME): Update.
 587         (SYMBOL_LINKAGE_NAME): Update.
 588         (SYMBOL_DEMANGLED_NAME): Update.
 589         (SYMBOL_SEARCH_NAME): Update.
 590         (SYMBOL_MATCHES_SEARCH_NAME): Update.
 591         (struct symbol): Update.
 592         (struct template_symbol): Update.
 593         (struct rust_vtable_symbol): Update.
 594         * xcoffread.c (SYMBOL_DUP): Update.
 595
 596 2019-11-12  Tom Tromey  <tom@tromey.com>
 597
 598         * tui/tui-layout.c (show_layout): Set current_layout.
 599         (show_source_disasm_command, show_data)
 600         (show_source_or_disasm_and_command): Don't set current_layout.
 601
 602 2019-11-12  Tom Tromey  <tom@tromey.com>
 603
 604         * tui/tui-layout.c (_initialize_tui_layout): Move to end.
 605
 606 2019-11-12  Tom Tromey  <tom@tromey.com>
 607
 608         * tui/tui-win.c (resize_message): New global.
 609         (show_tui_resize_message): New function.
 610         (tui_async_resize_screen): Print message if requested.
 611         (_initialize_tui_win): Add tui-resize-message setting.
 612         * NEWS: Add entry for new commands.
 613
 614 2019-11-11  Tom Tromey  <tom@tromey.com>
 615
 616         * tui/tui.c (tui_initialize_readline): Add new bindable readline
 617         functions.
 618
 619 2019-11-11  Christian Biesinger  <cbiesinger@google.com>
 620
 621         * nat/linux-osdata.c (user_from_uid): Use getpwuid_r.
 622
 623 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
 624
 625         * python/py-symbol.c (gdbpy_lookup_static_symbols): New
 626         function.
 627         * python/python-internal.h (gdbpy_lookup_static_symbols):
 628         Declare new function.
 629         * python/python.c (python_GdbMethods): Add
 630         gdb.lookup_static_symbols method.
 631         * NEWS: Mention gdb.lookup_static_symbols.
 632
 633 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
 634
 635         * python/py-symbol.c (gdbpy_lookup_static_symbol): Lookup in
 636         static block of current object file first.  Also fix typo in
 637         header comment.
 638
 639 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
 640
 641         * stack.c (set_last_displayed_sal): Delete.
 642         (last_displayed_sal_valid): Delete.
 643         (last_displayed_pspace): Delete.
 644         (last_displayed_addr): Delete.
 645         (last_displayed_symtab): Delete.
 646         (last_displayed_line): Delete.
 647         (class last_displayed_symtab_info_type): New.
 648         (last_displayed_symtab_info): New static global variable.
 649         (print_frame_info): Call methods on last_displayed_symtab_info.
 650         (clear_last_displayed_sal): Update header comment, and make use of
 651         last_displayed_symtab_info.
 652         (last_displayed_sal_is_valid): Likewise.
 653         (get_last_displayed_pspace): Likewise.
 654         (get_last_displayed_addr): Likewise.
 655         (get_last_displayed_symtab): Likewise.
 656         (get_last_displayed_line): Likewise.
 657         (get_last_displayed_sal): Likewise.
 658         * stack.h (clear_last_displayed_sal): Update header comment.
 659         (last_displayed_sal_is_valid): Likewise.
 660         (get_last_displayed_pspace): Likewise.
 661         (get_last_displayed_addr): Likewise.
 662         (get_last_displayed_symtab): Likewise.
 663         (get_last_displayed_line): Likewise.
 664         (get_last_displayed_sal): Likewise.
 665
 666 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
 667
 668         * stack.c (frame_show_address): Convert return type to bool.
 669         * stack.h (frame_show_address): Likewise, and update header
 670         comment.
 671
 672 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
 673
 674         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add new file to the list.
 675         * unittests/vec-utils-selftests.c: New file.
 676         * gdbsupport/gdb_vecs.h (unordered_remove): Avoid self move assign.
 677
 678 2019-11-10  Tom Tromey  <tom@tromey.com>
 679
 680         * tui/tui-wingeneral.c (tui_unhighlight_win): Use can_box.
 681         (tui_highlight_win): Likewise.
 682         (tui_win_info::check_and_display_highlight_if_needed): Likewise.
 683         * tui/tui-data.h (struct tui_win_info) <can_highlight>: Remove.
 684         * tui/tui-command.h (struct tui_cmd_window) <tui_cmd_window>:
 685         Don't set can_highlight.
 686
 687 2019-11-10  Tom Tromey  <tom@tromey.com>
 688
 689         * cli/cli-style.h (class cli_style_option) <cli_style_option>:
 690         Remove unused declaration.
 691
 692 2019-11-08  Tom Tromey  <tromey@adacore.com>
 693
 694         * top.c (read_command_file): Update.
 695         (command_line_input): Make return type const.
 696         * python/py-gdb-readline.c: Update.
 697         * linespec.c (decode_line_2): Update.
 698         * defs.h (command_line_input): Make return type const.
 699         * cli/cli-script.c (read_next_line): Make return type const.
 700         * ada-lang.c (get_selections): Update.
 701
 702 2019-11-06  Christian Biesinger  <cbiesinger@google.com>
 703
 704         * linux-tdep.c (linux_info_proc): Use strtok_r instead of strtok.
 705         * mi/mi-main.c (output_cores): Likewise.
 706         * nat/linux-osdata.c (linux_xfer_osdata_cpus): Likewise.
 707         (linux_xfer_osdata_modules): Likewise.
 708         * remote.c (register_remote_support_xml): Likewise.
 709         * sparc64-tdep.c (adi_is_addr_mapped): Likewise.
 710         * xml-syscall.c (syscall_create_syscall_desc): Likewise.
 711
 712 2019-11-06  Tom Tromey  <tom@tromey.com>
 713
 714         * tui/tui-interp.c: Don't include readline.h.
 715         * tui/tui-hooks.c: Don't include readline.h.
 716         * symmisc.c: Include tilde.h, not readline.h.
 717         * symfile.c: Include tilde.h, not readline.h.
 718         * source.c: Include tilde.h, not readline.h.
 719         * solib.c: Include tilde.h, not readline.h.
 720         * psymtab.c: Include tilde.h, not readline.h.
 721         * exec.c: Include tilde.h, not readline.h.
 722         * corelow.c: Include tilde.h, not readline.h.
 723         * cli/cli-dump.c: Include tilde.h, not readline.h.
 724         * cli/cli-cmds.c: Don't include readline.h.
 725
 726 2019-11-05  Tom Tromey  <tom@tromey.com>
 727
 728         * tui/tui-disasm.c (struct tui_asm_line) <addr_size>: New member.
 729         (tui_disassemble): Set addr_size.
 730         (tui_disasm_window::set_contents): Use addr_size.
 731
 732 2019-11-05  Tom Tromey  <tom@tromey.com>
 733
 734         * rust-lang.c (rust_language_defn): Update.
 735         * python/py-value.c (valpy_string): Call c_get_string.
 736         * p-lang.c (pascal_language_defn): Update.
 737         * opencl-lang.c (opencl_language_defn): Update.
 738         * objc-lang.c (objc_language_defn): Update.
 739         * m2-lang.c (m2_language_defn): Update.
 740         * language.c (unknown_language_defn, auto_language_defn): Update.
 741         (default_get_string): Remove.
 742         * guile/scm-value.c (gdbscm_value_to_string): Use c_get_string.
 743         * go-lang.c (go_language_defn): Update.
 744         * f-lang.c (f_language_defn): Update.
 745         * d-lang.c (d_language_defn): Update.
 746         * c-lang.c (c_language_defn, cplus_language_defn)
 747         (asm_language_defn, minimal_language_defn): Update.
 748         * ada-lang.c (ada_language_defn): Update.
 749         * language.h (struct language_defn) <la_get_string>: Remove.
 750         (LA_GET_STRING): Remove.
 751         (default_get_string): Don't declare.
 752
 753 2019-11-05  Tom Tromey  <tom@tromey.com>
 754
 755         * tui/tui-source.h (struct tui_source_window): Inline
 756         constructor.  Remove destructor.
 757         <style_changed, m_observable>: Move to superclass.
 758         * tui/tui-winsource.h (tui_copy_source_line): Declare.
 759         (struct tui_source_window_base): Move private members to end.
 760         <style_changed, m_observable>: Move from tui_source_window.
 761         * tui/tui-winsource.c (tui_copy_source_line): Move from
 762         tui-source.c.  Rename from copy_source_line.  Add special handling
 763         for negative line number.
 764         (tui_source_window_base::style_changed): Move from
 765         tui_source_window.
 766         (tui_source_window_base): Register observer.
 767         (~tui_source_window_base): New.
 768         * tui/tui-source.c (copy_source_line): Move to tui-winsource.c;
 769         rename.
 770         (tui_source_window::set_contents): Use tui_copy_source_line.
 771         (tui_source_window::tui_source_window): Move to tui-source.h.
 772         (tui_source_window::~tui_source_window): Remove.
 773         (tui_source_window::style_changed): Move to superclass.
 774         * tui/tui-disasm.c (tui_disassemble): Create string file with
 775         styling, when possible.  Add "addr_size" parameter.
 776         (tui_disasm_window::set_contents): Use tui_copy_source_line.
 777         Don't compute maximum size.
 778         (len_without_escapes): New function
 779
 780 2019-11-05  Tom Tromey  <tom@tromey.com>
 781
 782         * tui/tui-winsource.h (struct tui_source_element) <line>: Now a
 783         std::string.
 784         * tui/tui-winsource.c (tui_show_source_line): Update.
 785         * tui/tui-source.c (tui_source_window::set_contents): Update.
 786         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
 787
 788 2019-11-05  Christian Biesinger  <cbiesinger@google.com>
 789
 790         * symtab.h (gdb_static_assert): Put && operator at the beginning
 791         of the line instead of the end.
 792
 793 2019-11-04  Christian Biesinger  <cbiesinger@google.com>
 794
 795         * psympriv.h: Add static_asserts for sizeof (general_symbol_info)
 796         and sizeof (symbol).
 797         * symtab.h: Add a static_assert for sizeof (partial_symbol).
 798
 799 2019-11-04  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
 800
 801         * NEWS (Changes since GDB 8.3): Document Solaris 10 removal.
 802         * configure.host: Mark *-*-solaris2.10* obsolete.
 803         * configure.tgt: Mark Solaris < 11 obsolete.
 804         * MAINTAINERS (Target Instruction Set Architectures) <sparc>:
 805         Update target triplet.
 806
 807 2019-11-01  Tom Tromey  <tromey@adacore.com>
 808
 809         * utils.c (print_sys_errmsg): Simplify.
 810
 811 2019-11-01  Tom Tromey  <tromey@adacore.com>
 812
 813         * gdbsupport/mingw-strerror.c (safe_strerror): Constify result.
 814
 815 2019-11-01  Christian Biesinger  <cbiesinger@google.com>
 816
 817         * configure: Regenerate.
 818         * configure.ac: Remove check for strerror_r.
 819         * gdbsupport/common.m4: Check for strerror_r.
 820
 821 2019-11-01  Luis Machado  <luis.machado@linaro.org>
 822
 823         PR gdb/25124
 824
 825         * arm-tdep.c (arm_per_objfile): Rename to ...
 826         (arm_per_bfd): ... this.
 827         (arm_objfile_data_key): Rename to ...
 828         (arm_bfd_data_key): ... this.
 829         (arm_find_mapping_symbol): Adjust access to new bfd_key-based
 830         data.
 831         (arm_record_special_symbol): Likewise.
 832
 833 2019-10-31  Andrew Burgess  <andrew.burgess@embecosm.com>
 834
 835         * ada-typeprint.c (ada_print_typedef): Don't print newline at the
 836         end.
 837         * c-typeprint.c (c_print_typedef): Likewise.
 838         * f-typeprint.c (f_print_typedef): Likewise.
 839         * m2-typeprint.c (m2_print_typedef): Likewise.
 840         * p-typeprint.c (pascal_print_typedef): Likewise.
 841         * rust-lang.c (rust_print_typedef): Likewise.
 842         * symtab.c (print_symbol_info): Print a newline after calling
 843         typedef_print.
 844
 845 2019-10-31  Andrew Burgess  <andrew.burgess@embecosm.com>
 846
 847         * symtab.c (info_module_cmdlist): New variable.
 848         (info_module_command): New function.
 849         (search_module_symbols): New function.
 850         (info_module_subcommand): New function.
 851         (struct info_modules_var_func_options): New struct.
 852         (info_modules_var_func_options_defs): New variable.
 853         (make_info_modules_var_func_options_def_group): New function.
 854         (info_module_functions_command): New function.
 855         (info_module_variables_command): New function.
 856         (info_module_var_func_command_completer): New function.
 857         (_initialize_symtab): Register new 'info module functions' and
 858         'info module variables' commands.
 859         * symtab.h (typedef symbol_search_in_module): New typedef.
 860         (search_module_symbols): Declare new function.
 861         * NEWS: Mention new commands.
 862
 863 2019-10-31  Andrew Burgess  <andrew.burgess@embecosm.com>
 864
 865         * dwarf2read.c (dw2_symtab_iter_next): Handle MODULE_DOMAIN.
 866         (dw2_expand_marked_cus): Handle MODULES_DOMAIN.
 867         (dw2_debug_names_iterator::next): Handle MODULE_DOMAIN and
 868         MODULES_DOMAIN.
 869         (scan_partial_symbols): Only create partial module symbols for non
 870         declarations.
 871         * psymtab.c (recursively_search_psymtabs): Handle MODULE_DOMAIN
 872         and MODULES_DOMAIN.
 873         * symtab.c (search_domain_name): Likewise.
 874         (search_symbols): Likewise.
 875         (print_symbol_info): Likewise.
 876         (symtab_symbol_info): Likewise.
 877         (info_modules_command): New function.
 878         (_initialize_symtab): Register 'info modules' command.
 879         * symtab.h (enum search_domain): Add MODULES_DOMAIN.
 880         * NEWS: Mention new 'info modules' command.
 881
 882 2019-10-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 883
 884         * NEWS: Mention $_gdb_setting, $_gdb_setting_str, $_gdb_maint_setting
 885         and $_gdb_maint_setting_str.
 886
 887 2019-10-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 888
 889         * cli/cli-cmds.c (setting_cmd, value_from_setting)
 890         (gdb_setting_internal_fn, gdb_maint_setting_internal_fn)
 891         (str_value_from_setting, gdb_setting_str_internal_fn)
 892         (gdb_maint_setting_str_internal_fn): New functions.
 893         (_initialize_cli_cmds): Define the new convenience functions.
 894         * gdb/cli/cli-setshow.h (get_setshow_command_value_string): Constify.
 895         * gdb/cli/cli-setshow.c (get_setshow_command_value_string): Constify.
 896
 897 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
 898
 899         * agent.c (set_can_use_agent): When the setting is turned on,
 900         look up agent symbols if we don't have them yet.
 901         (agent_new_objfile): Don't look up agent symbols when the agent
 902         setting is off.
 903
 904 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
 905
 906         * config.in: Regenerate.
 907
 908 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
 909
 910         * configure: Regenerate.
 911         * configure.ac: Check for strerror_r.
 912         * gdbsupport/common-utils.h (safe_strerror): Change return value
 913         to const char * and document that this function is now threadsafe.
 914         * gdbsupport/posix-strerror.c (safe_strerror): Make buf
 915         thread_local and call strerror_r, if available.
 916         * utils.c (perror_string): Update.
 917         (print_sys_errmsg): Update.
 918
 919 2019-10-31  Luis Machado  <luis.machado@linaro.org>
 920
 921         * arm-tdep.c (arm_exidx_data_key): Use bfd_key instead of
 922         objfile_key.
 923         (arm_exidx_new_objfile): Adjust to use objfile->obfd instead of
 924         objfile to fetch per-bfd data.
 925         (arm_find_exidx_entry): Likewise.
 926
 927 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
 928
 929         * gdbsupport/agent.c (debug_agent): Change type to bool.
 930         (use_agent): Likewise.
 931         (all_agent_symbols_look_up): Likewise.
 932         (agent_loaded_p): Change return value to bool.
 933         (agent_look_up_symbols): Update.
 934         (agent_capability_check): Change return value to bool.
 935         * gdbsupport/agent.h (agent_loaded_p): Likewise.
 936         (debug_agent): Change type to bool.
 937         (use_agent): Likewise.
 938         (agent_capability_check): Change return value to bool.
 939
 940 2019-10-30  Christian Biesinger  <cbiesinger@google.com>
 941
 942         * minsyms.c (clear_minimal_symbol_hash_tables): New function.
 943         (build_minimal_symbol_hash_tables): Code to clear the table moved
 944         to clear_minimal_symbol_hash_tables.
 945         (minimal_symbol_reader::install): Call clear_minimal_symbol_hash_tables
 946         when needed.
 947
 948 2019-10-29  Simon Marchi  <simon.marchi@polymtl.ca>
 949
 950         * infcmd.c: Remove includes.
 951         * infrun.c: Remove includes.
 952
 953 2019-10-29  Simon Marchi  <simon.marchi@polymtl.ca>
 954
 955         * ada-lang.h (GROW_VECT): Move to ada-lang.c.
 956         (grow_vect): Remove declaration.
 957         (ada_type_of_array): Remove declaration.
 958         (ada_update_initial_language): Remove declaration.
 959         (ada_fold_name): Remove declaration.
 960         (ada_fill_in_ada_prototype): Remove declaration.
 961         (user_select_syms): Remove declaration.
 962         (get_selections): Remove declaration.
 963         (ada_tag_type): Remove declaration.
 964         (ada_value_tag): Remove declaration.
 965         (ada_is_others_clause): Remove declaration.
 966         (ada_in_variant): Remove declaration.
 967         (ada_value_struct_elt): Remove declaration.
 968         (ada_attribute_name): Remove declaration.
 969         (ada_system_address_type): Remove declaration.
 970         * ada-lang.c (ada_watch_location_expression): Make static.
 971         (GROW_VECT): Move here from ada-lang.h.
 972         (grow_vect): Make static.
 973         (ada_update_initial_language): Make static.
 974         (ada_fold_name): Make static.
 975         (ada_type_of_array): Make static.
 976         (encoded_ordered_before): Move up.
 977         (sort_choices): Move up.
 978         (print_signatures): Move up.
 979         (ada_print_symbol_signature): Move up.
 980         (get_selections): Move up and make static.
 981         (user_select_syms): Move up and make static.
 982         (ada_value_struct_elt): Move up and make static.
 983         (ada_tag_type): Make static.
 984         (ada_value_tag): Make static.
 985         (ada_is_others_clause): Make static.
 986         (ada_in_variant): Make static.
 987         (ada_attribute_name): Make static.
 988
 989 2019-10-29  Simon Marchi  <simon.marchi@polymtl.ca>
 990
 991         * ada-lang.c: Remove includes.
 992         * ada-typeprint.c: Remove includes.
 993         * ada-valprint.c: Remove includes.
 994
 995 2019-10-29  Simon Marchi  <simon.marchi@efficios.com>
 996
 997         * addrmap.c: Add static assertions of type size, moved from
 998         _initialize_addrmap.
 999         (_initialize_addrmap): Remove.
1000
1001 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
1002
1003         * coffread.c (record_minimal_symbol): Update.
1004         (process_coff_symbol): Update.
1005         * dbxread.c (read_dbx_symtab): Update.
1006         * dwarf2read.c (add_partial_symbol): Update.
1007         (fixup_go_packaging): Update.
1008         (load_partial_dies): Update.
1009         (new_symbol): Update.
1010         * elfread.c (record_minimal_symbol): Change signature to use
1011         gdb::string_view instead of name+len.
1012         (elf_symtab_read): Update.
1013         (elf_rel_plt_read): Update.
1014         * mdebugread.c (parse_partial_symbols): Update.
1015         (handle_psymbol_enumerators): Update.
1016         (new_symbol): Update.
1017         * minsyms.c (minimal_symbol_reader::record_full): Change signature
1018         to use gdb::string_view instead of name+len.
1019         * minsyms.h (class minimal_symbol_reader) <record_full>: Likewise.
1020         * psympriv.h (add_psymbol_to_list): Likewise.
1021         * psymtab.c (add_psymbol_to_bcache): Likewise.
1022         (add_psymbol_to_list): Likewise.
1023         * stabsread.c (define_symbol): Update.
1024         * symtab.c (symbol_set_names): Change signature to use gdb::string_view.
1025         * symtab.h (SYMBOL_SET_NAMES): Likewise.
1026         (symbol_set_names): Likewise.
1027         * xcoffread.c (scan_xcoff_symtab): Update.
1028
1029 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
1030
1031         * symtab.h (symbol_set_names): Document that copy_name must be
1032         set to true for non-nullterminated strings.
1033         * symtab.c (symbol_set_names): Only make a nullterminated copy of
1034         linkage_name if the entry was not found and we need to demangle.
1035
1036 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
1037
1038         * Makefile.in (HFILES_NO_SRCDIR): Add gdb_binary_search.h.
1039         * dwarf2-frame.c (bsearch_fde_cmp): Update.
1040         (dwarf2_frame_find_fde): Replace bsearch with gdb::binary_search.
1041         * gdbsupport/gdb_binary_search.h: New file.
1042
1043 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
1044
1045         * NEWS: Mention new --with-system-gdbinit-dir option.
1046         * config.in: Regenerate.
1047         * configure: Regenerate.
1048         * configure.ac: Add new option --with-system-gdbinit-dir.
1049         * extension.c (get_ext_lang_of_file): Return extension_language_gdb
1050         for a ".gdb" suffix.
1051         * main.c (get_init_files): Change system_gdbinit argument to
1052         a vector and return the files in SYSTEM_GDBINIT_DIR in
1053         addition to SYSTEM_GDBINIT.
1054         (captured_main_1): Update.
1055         (print_gdb_help): Update.
1056         * top.c (print_gdb_configuration): Also print the value of
1057         SYSTEM_GDBINIT_DIR.
1058
1059 2019-10-28  Christian Biesinger  <cbiesinger@google.com>
1060
1061         * gdbsupport/common-utils.h (startswith): Add an overloaded version
1062         that takes gdb::string_view arguments.
1063
1064 2019-10-26  Tom de Vries  <tdevries@suse.de>
1065
1066         * aarch64-linux-tdep.c: Fix typos in comments.
1067         * aarch64-tdep.c: Same.
1068         * ada-lang.c: Same.
1069         * amd64-nat.c: Same.
1070         * arc-tdep.c: Same.
1071         * arch/aarch64-insn.c: Same.
1072         * block.c: Same.
1073         * breakpoint.h: Same.
1074         * btrace.h: Same.
1075         * c-varobj.c: Same.
1076         * cli/cli-decode.c: Same.
1077         * cli/cli-script.c: Same.
1078         * cli/cli-utils.h: Same.
1079         * coff-pe-read.c: Same.
1080         * coffread.c: Same.
1081         * compile/compile-cplus-symbols.c: Same.
1082         * compile/compile-object-run.c: Same.
1083         * completer.c: Same.
1084         * corelow.c: Same.
1085         * cp-support.c: Same.
1086         * demangle.c: Same.
1087         * dwarf-index-write.c: Same.
1088         * dwarf2-frame.c: Same.
1089         * dwarf2-frame.h: Same.
1090         * eval.c: Same.
1091         * frame-base.h: Same.
1092         * frame.h: Same.
1093         * gdbcmd.h: Same.
1094         * gdbtypes.h: Same.
1095         * gnu-nat.c: Same.
1096         * guile/scm-objfile.c: Same.
1097         * i386-tdep.c: Same.
1098         * i386-tdep.h: Same.
1099         * infcall.c: Same.
1100         * infcall.h: Same.
1101         * linux-nat.c: Same.
1102         * m68k-tdep.c: Same.
1103         * macroexp.c: Same.
1104         * memattr.c: Same.
1105         * mi/mi-cmd-disas.c: Same.
1106         * mi/mi-getopt.h: Same.
1107         * mi/mi-main.c: Same.
1108         * minsyms.c: Same.
1109         * nat/aarch64-sve-linux-sigcontext.h: Same.
1110         * objfiles.h: Same.
1111         * ppc-linux-nat.c: Same.
1112         * ppc-linux-tdep.c: Same.
1113         * ppc-tdep.h: Same.
1114         * progspace.h: Same.
1115         * prologue-value.h: Same.
1116         * python/py-evtregistry.c: Same.
1117         * python/py-instruction.h: Same.
1118         * record-btrace.c: Same.
1119         * record-full.c: Same.
1120         * remote.c: Same.
1121         * rs6000-tdep.c: Same.
1122         * ser-tcp.c: Same.
1123         * sol-thread.c: Same.
1124         * sparc-sol2-tdep.c: Same.
1125         * sparc64-tdep.c: Same.
1126         * stabsread.c: Same.
1127         * symfile.c: Same.
1128         * symtab.h: Same.
1129         * target.c: Same.
1130         * tracepoint.c: Same.
1131         * tui/tui-data.h: Same.
1132         * tui/tui-io.c: Same.
1133         * tui/tui-win.c: Same.
1134         * tui/tui.c: Same.
1135         * unittests/rsp-low-selftests.c: Same.
1136         * user-regs.h: Same.
1137         * utils.c: Same.
1138         * utils.h: Same.
1139         * valarith.c: Same.
1140         * valops.c: Same.
1141         * valprint.c: Same.
1142         * valprint.h: Same.
1143         * value.c: Same.
1144         * value.h: Same.
1145         * varobj.c: Same.
1146         * x86-nat.h: Same.
1147         * xtensa-tdep.c: Same.
1148
1149 2019-10-25  Ali Tamur <tamur@google.com>
1150
1151         * charset.c (find_charset_names): Reflect API change.
1152
1153 2019-10-25  Christian Biesinger  <cbiesinger@google.com>
1154
1155         * symtab.c (struct demangled_name_entry): Change demangled name
1156         to a unique_xmalloc_ptr<char>, now that we don't allocate it as
1157         part of the struct anymore.
1158         (symbol_set_names): No longer obstack allocate + copy the demangled
1159         name, just store the allocated name from bfd.
1160
1161 2019-10-25  Tom Tromey  <tromey@adacore.com>
1162
1163         * dwarf2-frame.c (dwarf2_cie_table): Now a typedef.
1164         (bsearch_cie_cmp, add_cie): Remove.
1165         (find_cie): Reimplement.
1166         (decode_frame_entry_1, decode_frame_entry): Change type.  Update.
1167         (dwarf2_build_frame_info): Update.
1168
1169 2019-10-24  H.J. Lu  <hongjiu.lu@intel.com>
1170
1171         PR gdb/25126
1172         * symfile.c (reread_symbols): Call forget_cached_source_info to
1173         clear the stale source cache.
1174
1175 2019-10-24  Christian Biesinger  <cbiesinger@google.com>
1176
1177         * configure: Regenerate.
1178         * configure.ac: Remove code that sets python_has_threads.
1179
1180 2019-10-24  Christian Biesinger  <cbiesinger@google.com>
1181
1182         * config.in: Regenerate.
1183         * configure: Regenerate.
1184         * configure.ac: Remove the code that uses sed to get the python
1185         version and defines HAVE_LIBPYTHON2_6 / HAVE_LIBPYTHON2_7.
1186
1187 2019-10-24  Andrew Burgess  <andrew.burgess@embecosm.com>
1188
1189         * python/py-progspace.c (pspy_block_for_pc): Return None for all
1190         error paths.
1191
1192 2019-10-23  Tom Tromey  <tom@tromey.com>
1193
1194         * arc-tdep.c: Remove ".." from include.
1195         * frv-tdep.c: Remove ".." from include.
1196         * lm32-tdep.c: Remove ".." from include.
1197         * microblaze-tdep.c: Remove ".." from include.
1198         * or1k-tdep.h: Remove ".." from include.
1199         * s12z-tdep.c: Remove ".." from include.
1200         * Makefile.in (OPCODES_CFLAGS): Add comment.
1201         (TOP_CFLAGS): New variable.
1202         (INTERNAL_CFLAGS_BASE): Add TOP_CFLAGS.
1203
1204 2019-10-23  Tom Tromey  <tom@tromey.com>
1205
1206         * Makefile.in (READLINE_DIR): Update.
1207
1208 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
1209
1210         * infcall.c (call_function_by_hand_dummy): Fix the function
1211         comment.  And extract out a code section into...
1212         (reserve_stack_space): ...this new function.
1213
1214 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
1215
1216         * infcall.c (value_arg_coerce): Remove an unused parameter.
1217         (call_function_by_hand_dummy): Update the call to
1218         'value_arg_coerce'.
1219
1220 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
1221
1222         * infcall.c (call_function_by_hand_dummy): Refactor.
1223
1224 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
1225
1226         * MAINTAINERS (Write After Approval): Add Tankut Baris Aktemur.
1227
1228 2019-10-23  Tom Tromey  <tom@tromey.com>
1229
1230         * configure: Rebuild.
1231         * configure.ac: Don't check for sigprocmask.
1232         * gdbsupport/common.m4 (GDB_AC_COMMON): Check for sigprocmask.
1233
1234 2019-10-23  Tom Tromey  <tom@tromey.com>
1235
1236         * configure: Rebuild.
1237         * acinclude.m4: Use m4_include, not sinclude.
1238
1239 2019-10-23  Tom de Vries  <tdevries@suse.de>
1240
1241         PR breakpoints/24687
1242         * symtab.c (iterate_over_some_symtabs): Apply gdb_realpath on fullname.
1243
1244 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
1245
1246         * symtab.c (struct demangled_name_entry) <language>: Change from
1247         bitfield to regular variable.
1248
1249 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
1250
1251         * symtab.c (struct demangled_name_entry): Add a constructor.
1252         (free_demangled_name_entry): New function to call the destructor
1253         for demangled_name_entry.
1254         (create_demangled_names_hash): Pass free_demangled_name_entry to
1255         htab_create_alloc.
1256         (symbol_set_names): Call placement new for demangled_name_entry.
1257         * utils.c: No longer include xxhash.h here, now that fast_hash
1258         is inlined in the header.
1259         * utils.h: Instead, include it here.
1260
1261 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
1262
1263         * Makefile.in: Link with libxxhash.
1264         * config.in: Regenerate.
1265         * configure: Regenerate.
1266         * configure.ac: Search for libxxhash.
1267         * utils.c (fast_hash): Use xxhash if present.
1268
1269 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
1270
1271         * utils.h (fast_hash): New function.
1272         * symtab.c (hash_demangled_name_entry): Call new function
1273         fast_hash.
1274
1275 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
1276
1277         * symtab.c (struct demangled_name_entry): Change type of mangled
1278         to gdb::string_view. Also adds a constructor that takes the
1279         mangled name.
1280         (hash_demangled_name_entry): Update.
1281         (eq_demangled_name_entry): Update.
1282         (free_demangled_name_entry): New function to call the destructor
1283         now that this is not a POD anymore.
1284         (create_demangled_names_hash): Pass free_demangled_name_entry to
1285         htab_create_alloc.
1286         (symbol_set_names): Update.
1287
1288 2019-10-21  Ali Tamur  <tamu@google.com>
1289
1290         * dwarf2read.c (dir_index): Change type.
1291         (file_name_index): Likewise.
1292         (line_header::include_dir_at): Change comment and implementation on
1293         whether it is DWARF 5.
1294         (line_header::is_valid_file_index): New function.
1295         (line_header::file_name_at): Change comment and implementation on
1296         whether it is DWARF 5.
1297         (line_header::file_names): Change to private field renamed as
1298         m_file_names and introduce a new accessor method.
1299         (line_header::file_names_size): New method.
1300         (line_header::include_dirs): Change to private field and rename as
1301         m_include_dirs.
1302         (dw2_get_file_names_reader): Define local var at a smaller scope and
1303         reflect API change.
1304         (dwarf2_cu::setup_type_unit_groups): Reflect API change.
1305         (process_structure_scope): Likewise.
1306         (line_header::add_include_dir): Change message and reflect renaming.
1307         (line_header::add_file_name): Likewise.
1308         (read_formatted_entries): Handle DW_FORM_data16.
1309         (dwarf_decode_line_header): Fix line header length calculation.
1310         (psymtab_include_file_name): Change comment and API.
1311         (lnp_state_machine::m_file): Update comment and reflect type change.
1312         (lnp_state_machine::record_line): Reflect type change.
1313         (dwarf_decode_lines): Reflect API change.
1314         (file_file_name): Likewise.
1315         (file_full_name): Likewise.
1316
1317 2019-10-21  Andrew Burgess  <andrew.burgess@embecosm.com>
1318
1319         * objfiles.c (sort_cmp): Ensure that !(a < a) holds true.
1320
1321 2019-10-21  Tom Tromey  <tom@tromey.com>
1322
1323         * tui/tui-winsource.h (tui_exec_info_content): Remove typedef.
1324
1325 2019-10-21  Tom Tromey  <tom@tromey.com>
1326
1327         * configure.ac (nm.h): Conditionally create nm.h link.  Subst
1328         NM_H.   Use AC_CONFIG_LINKS.
1329         * configure: Rebuild.
1330         * Makefile.in (NM_H): New variable.
1331         (generated_files): Add NM_H.  Remove gcore.
1332         (nm.h, stamp-nmh): New targets.
1333
1334 2019-10-20  Tom Tromey  <tom@tromey.com>
1335
1336         * objfiles.h (unlink_objfile, put_objfile_before): Don't declare.
1337         * objfiles.c (unlink_objfile): Move earlier.  Now static.  Remove
1338         obsolete comment.
1339         (put_objfile_before): Now static.
1340
1341 2019-10-19  Simon Marchi  <simon.marchi@polymtl.ca>
1342
1343         * gdbsupport/common-utils.h (startswith): Change return type to
1344         bool.
1345
1346 2019-10-19  Christian Biesinger  <cbiesinger@google.com>
1347
1348         * bcache.c (bcache::print_statistics): Use std::sort instead of qsort.
1349         * breakpoint.c (bp_locations_compare): Rename to...
1350         (bp_location_is_less_than): ...this, and change to std::sort semantics.
1351         (update_global_location_list): Use std::sort instead of qsort.
1352         * buildsym.c (compare_line_numbers): Rename to...
1353         (lte_is_less_than): ...this, and change to std::sort semantics.
1354         (buildsym_compunit::end_symtab_with_blockvector): Use std::sort
1355         instead of qsort.
1356         * disasm.c (compare_lines): Rename to...
1357         (line_is_less_than): ...this, and change to std::sort semantics.
1358         (do_mixed_source_and_assembly_deprecated): Call std::sort instead
1359         of qsort.
1360         * dwarf2-frame.c (qsort_fde_cmp): Rename to...
1361         (fde_is_less_than): ...this, and change to std::sort semantics.
1362         (dwarf2_build_frame_info): Call std::sort instead of qsort.
1363         * mdebugread.c (compare_blocks):
1364         (block_is_less_than): ...this, and change to std::sort semantics.
1365         (sort_blocks): Call std::sort instead of qsort.
1366         * objfiles.c (qsort_cmp): Rename to...
1367         (sort_cmp): ...this, and change to std::sort semantics.
1368         (update_section_map): Call std::sort instead of qsort.
1369         * remote.c (compare_pnums): Remove.
1370         (map_regcache_remote_table): Call std::sort instead of qsort.
1371         * utils.c (compare_positive_ints): Remove.
1372         * utils.h (compare_positive_ints): Remove.
1373         * xcoffread.c (compare_lte): Remove.
1374         (arrange_linetable): Call std::sort instead of qsort.
1375
1376 2019-10-19  Sergio Durigan Junior  <sergiodj@redhat.com>
1377
1378         * symfile.c (init_entry_point_info): Fix typo.
1379         * i386-darwin-tdep.c (darwin_dwarf_signal_frame_p): Fix typo.
1380
1381 2019-10-18  Tom de Vries  <tdevries@suse.de>
1382
1383         * aarch64-tdep.c: Fix typos in comments.
1384         * ada-lang.c: Same.
1385         * ada-tasks.c: Same.
1386         * alpha-tdep.c: Same.
1387         * alpha-tdep.h: Same.
1388         * amd64-nat.c: Same.
1389         * amd64-windows-tdep.c: Same.
1390         * arc-tdep.c: Same.
1391         * arc-tdep.h: Same.
1392         * arch-utils.c: Same.
1393         * arm-nbsd-tdep.c: Same.
1394         * arm-tdep.c: Same.
1395         * ax-gdb.c: Same.
1396         * blockframe.c: Same.
1397         * btrace.c: Same.
1398         * c-varobj.c: Same.
1399         * coff-pe-read.c: Same.
1400         * coffread.c: Same.
1401         * cris-tdep.c: Same.
1402         * darwin-nat.c: Same.
1403         * dbxread.c: Same.
1404         * dcache.c: Same.
1405         * disasm.c: Same.
1406         * dtrace-probe.c: Same.
1407         * dwarf-index-write.c: Same.
1408         * dwarf2-frame-tailcall.c: Same.
1409         * dwarf2-frame.c: Same.
1410         * dwarf2read.c: Same.
1411         * eval.c: Same.
1412         * exceptions.c: Same.
1413         * fbsd-tdep.c: Same.
1414         * findvar.c: Same.
1415         * frame.c: Same.
1416         * frv-tdep.c: Same.
1417         * gnu-v3-abi.c: Same.
1418         * go32-nat.c: Same.
1419         * h8300-tdep.c: Same.
1420         * hppa-tdep.c: Same.
1421         * i386-linux-tdep.c: Same.
1422         * i386-tdep.c: Same.
1423         * ia64-libunwind-tdep.c: Same.
1424         * ia64-tdep.c: Same.
1425         * infcmd.c: Same.
1426         * infrun.c: Same.
1427         * linespec.c: Same.
1428         * linux-nat.c: Same.
1429         * linux-thread-db.c: Same.
1430         * machoread.c: Same.
1431         * mdebugread.c: Same.
1432         * mep-tdep.c: Same.
1433         * mn10300-tdep.c: Same.
1434         * namespace.c: Same.
1435         * objfiles.c: Same.
1436         * opencl-lang.c: Same.
1437         * or1k-tdep.c: Same.
1438         * osabi.c: Same.
1439         * ppc-linux-nat.c: Same.
1440         * ppc-linux-tdep.c: Same.
1441         * ppc-sysv-tdep.c: Same.
1442         * printcmd.c: Same.
1443         * procfs.c: Same.
1444         * record-btrace.c: Same.
1445         * record-full.c: Same.
1446         * remote-fileio.c: Same.
1447         * remote.c: Same.
1448         * rs6000-tdep.c: Same.
1449         * s12z-tdep.c: Same.
1450         * score-tdep.c: Same.
1451         * ser-base.c: Same.
1452         * ser-go32.c: Same.
1453         * skip.c: Same.
1454         * sol-thread.c: Same.
1455         * solib-svr4.c: Same.
1456         * solib.c: Same.
1457         * source.c: Same.
1458         * sparc-nat.c: Same.
1459         * sparc-sol2-tdep.c: Same.
1460         * sparc-tdep.c: Same.
1461         * sparc64-tdep.c: Same.
1462         * stabsread.c: Same.
1463         * stack.c: Same.
1464         * symfile.c: Same.
1465         * symtab.c: Same.
1466         * target-descriptions.c: Same.
1467         * target-float.c: Same.
1468         * thread.c: Same.
1469         * utils.c: Same.
1470         * valops.c: Same.
1471         * valprint.c: Same.
1472         * value.c: Same.
1473         * varobj.c: Same.
1474         * windows-nat.c: Same.
1475         * xcoffread.c: Same.
1476         * xstormy16-tdep.c: Same.
1477         * xtensa-tdep.c: Same.
1478
1479 2019-10-17  Tom Tromey  <tromey@adacore.com>
1480
1481         * configure: Rebuild.
1482         * configure.ac: Use AC_CONFIG_HEADERS.  Create stamp-h there, not
1483         in AC_CONFIG_FILES invocation.
1484         * Makefile.in (Makefile, data-directory/Makefile, stamp-h): Use
1485         new-style config.status invocation.
1486
1487 2019-10-17  Tom de Vries  <tdevries@suse.de>
1488
1489         * arm-nbsd-nat.c: Fix typos in comments.
1490         * arm-tdep.c: Same.
1491         * darwin-nat-info.c: Same.
1492         * dwarf2read.c: Same.
1493         * elfread.c: Same.
1494         * event-top.c: Same.
1495         * findvar.c: Same.
1496         * gdbtypes.c: Same.
1497         * hppa-tdep.c: Same.
1498         * i386-tdep.c: Same.
1499         * jit.c: Same.
1500         * main.c: Same.
1501         * mdebugread.c: Same.
1502         * moxie-tdep.c: Same.
1503         * nto-procfs.c: Same.
1504         * osabi.c: Same.
1505         * ppc-linux-tdep.c: Same.
1506         * remote.c: Same.
1507         * riscv-tdep.c: Same.
1508         * s390-tdep.c: Same.
1509         * sh-tdep.c: Same.
1510         * sparc-linux-tdep.c: Same.
1511         * sparc-nat.c: Same.
1512         * stack.c: Same.
1513         * target-descriptions.c: Same.
1514         * top.c: Same.
1515         * varobj.c: Same.
1516
1517 2019-10-16  Tom Tromey  <tom@tromey.com>
1518
1519         * objfiles.h (struct objfile) <original_name>: Now const.
1520
1521 2019-10-16  Christian Biesinger  <cbiesinger@google.com>
1522
1523         * gdbsupport/gdb_setjmp.h (SIGSETJMP): Allow passing in the value to
1524         pass on to sigsetjmp's second argument.
1525         * cp-support.c (gdb_demangle): Unblock SIGSEGV if we caught a crash.
1526
1527 2019-10-16  Keith Seitz  <keiths@redhat.com>
1528
1529         PR gdb/23567
1530         * dwarf2read.c (dwarf2_per_objfile::locate_sections): Discard
1531         sections whose size is greater than the file size.
1532
1533 2019-10-16  Jim Wilson  <jimw@sifive.com>
1534
1535         * riscv-tdep.c (riscv_gcc_target_options): New.
1536         (riscv_gnu_triplet_regexp): New.
1537         (riscv_gdbarch_init): Call set_gdbarch_gcc_triplet_options and
1538         set_gdbarch_gnu_triplet_regexp.
1539
1540 2019-10-16  Christian Biesinger  <cbiesinger@google.com>
1541
1542         * Makefile.in: Add xml-builtin.h.
1543         * features/feature_to_c.sh: Add an include for xml-builtin.h
1544         to ensure that the compiler checks that the types match.
1545         * xml-builtin.h: New file.
1546         * xml-support.c (fetch_xml_builtin): Add missing const.
1547         * xml-support.h: Remove declaration of xml_builtins.
1548
1549 2019-10-16  Tom de Vries  <tdevries@suse.de>
1550
1551         PR tdep/25096
1552         * amd64-tdep.c (amd64_classify_aggregate_field): Factor out of ...
1553         (amd64_classify_aggregate): ... here.
1554         (amd64_classify_aggregate_field): Handled fiels of nested structs
1555         recursively.
1556
1557 2019-10-16  Tom de Vries  <tdevries@suse.de>
1558
1559         PR tdep/24104
1560         * amd64-tdep.c (amd64_push_arguments): Handle AMD64_NO_CLASS in loop
1561         that handles 'theclass'.
1562
1563 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1564
1565         * linespec.c (decode_digits_ordinary): Update comment.
1566         * make-target-delegates: No longer need to handle VEC case.
1567         * memrange.c (normalize_mem_ranges): Update comment.
1568         * namespace.c (add_using_directive): Update comment.
1569         * objc-lang.c (uniquify_strings): Update comment.
1570         * ppc-linux-nat.c (struct thread_points): Update comment.
1571         * probe.h (find_probes_in_objfile): Update comment.
1572         * target.h (enum flash_preserve_mode): Update comment.
1573         * varobj.c (varobj_restrict_range): Update comment.
1574         * varobj.h (varobj_list_children): Update comment.
1575
1576 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1577
1578         * Makefile.in: Remove references to vec.h and vec.c.
1579         * aarch64-tdep.c: No longer include vec.h.
1580         * ada-lang.c: Likewise.
1581         * ada-lang.h: Likewise.
1582         * arm-tdep.c: Likewise.
1583         * ax.h: Likewise.
1584         * breakpoint.h: Likewise.
1585         * charset.c: Likewise.
1586         * cp-support.h: Likewise.
1587         * dtrace-probe.c: Likewise.
1588         * dwarf2read.c: Likewise.
1589         * extension.h: Likewise.
1590         * gdb_bfd.c: Likewise.
1591         * gdbsupport/gdb_vecs.h: Likewise.
1592         * gdbsupport/vec.c: Remove.
1593         * gdbsupport/vec.h: Remove.
1594         * gdbthread.h: Likewise.
1595         * guile/scm-type.c: Likewise.
1596         * inline-frame.c: Likewise.
1597         * machoread.c: Likewise.
1598         * memattr.c: Likewise.
1599         * memrange.h: Likewise.
1600         * namespace.h: Likewise.
1601         * nat/linux-btrace.h: Likewise.
1602         * osdata.c: Likewise.
1603         * parser-defs.h: Likewise.
1604         * progspace.h: Likewise.
1605         * python/py-type.c: Likewise.
1606         * record-btrace.c: Likewise.
1607         * rust-exp.y: Likewise.
1608         * solib-target.c: Likewise.
1609         * stap-probe.c: Likewise.
1610         * target-descriptions.c: Likewise.
1611         * target-memory.c: Likewise.
1612         * target.h: Likewise.
1613         * varobj.c: Likewise.
1614         * varobj.h: Likewise.
1615         * xml-support.h: Likewise.
1616
1617 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1618
1619         * gdb/dwarf2read.c (dwarf2_per_objfile::~dwarf2_per_objfile):
1620         Update for new std::vector based implementation.
1621         (process_psymtab_comp_unit_reader): Likewise.
1622         (scan_partial_symbols): Likewise.
1623         (recursively_compute_inclusions): Likewise.
1624         (compute_compunit_symtab_includes): Likewise.
1625         (process_imported_unit_die): Likewise.
1626         (queue_and_load_dwo_tu): Likewise.
1627         (follow_die_sig_1): Likewise.
1628         * gdb/dwarf2read.h: Remove DEF_VEC_P.
1629         (typedef dwarf2_per_cu_ptr): Remove.
1630         (struct dwarf2_per_cu_data) <imported_symtabs_empty>: New
1631         function.
1632         (struct dwarf2_per_cu_data) <imported_symtabs_push>: New function.
1633         (struct dwarf2_per_cu_data) <imported_symtabs_size>: New function.
1634         (struct dwarf2_per_cu_data) <imported_symtabs_free>: New function.
1635         (struct dwarf2_per_cu_data) <imported_symtabs>: Change to
1636         std::vector.
1637
1638 2019-10-15  Tom Tromey  <tromey@adacore.com>
1639
1640         * windows-nat.c (windows_nat_target::resume): Use %x when logging
1641         TID.
1642
1643 2019-10-15  Tom Tromey  <tromey@adacore.com>
1644
1645         * windows-nat.c (windows_nat_target::fetch_registers)
1646         (windows_nat_target::store_registers): Rename "pid" to "tid".
1647
1648 2019-10-15  Tom Tromey  <tromey@adacore.com>
1649
1650         * gdbarch.h, gdbarch.c: Rebuild.
1651         * gdbarch.sh (gcc_target_options): Change return type to
1652         std::string.
1653         * compile/compile.c (get_args): Update.
1654         * nios2-tdep.c (nios2_gcc_target_options): Return std::string.
1655         * arm-linux-tdep.c (arm_linux_gcc_target_options): Return
1656         std::string.
1657         * aarch64-linux-tdep.c (aarch64_linux_gcc_target_options): Return
1658         std::string.
1659         * arch-utils.c (default_gcc_target_options): Return std::string.
1660         * arch-utils.h (default_gcc_target_options): Return std::string.
1661         * s390-tdep.c (s390_gcc_target_options): Return std::string.
1662
1663 2019-10-15  Christian Biesinger  <cbiesinger@google.com>
1664
1665         * breakpoint.c (breakpoint_chain): Make static.
1666         * tui/tui-winsource.c: Call iterate_over_breakpoints instead
1667         of accessing breakpoint_chain.
1668
1669 2019-10-15  Christian Biesinger  <cbiesinger@google.com>
1670
1671         * breakpoint.c (iterate_over_breakpoints): Change function pointer
1672         to a gdb::function_view and return value to bool.
1673         * breakpoint.h (iterate_over_breakpoints): Likewise.
1674         * dummy-frame.c (pop_dummy_frame_bpt): Update.
1675         (pop_dummy_frame): Update.
1676         * guile/scm-breakpoint.c (bpscm_build_bp_list): Update.
1677         (gdbscm_breakpoints): Update.
1678         * python/py-breakpoint.c (build_bp_list): Update.
1679         (gdbpy_breakpoints): Update.
1680         * python/py-finishbreakpoint.c (bpfinishpy_detect_out_scope_cb):
1681         Update.
1682         (bpfinishpy_handle_stop): Update.
1683         (bpfinishpy_handle_exit): Update.
1684         * solib-svr4.c (svr4_update_solib_event_breakpoint): Update.
1685         (svr4_update_solib_event_breakpoints): Update.
1686
1687 2019-10-15  Andreas Arnez  <arnez@linux.ibm.com>
1688
1689         * s390-tdep.c (s390_effective_inner_type): Ignore static fields
1690         when unwrapping single-field structs.
1691
1692 2019-10-14  Simon Marchi  <simon.marchi@polymtl.ca>
1693
1694         * dwarf2read.c: Remove includes.
1695
1696 2019-10-13  Simon Marchi  <simon.marchi@polymtl.ca>
1697
1698         * ui-out.c (ui_out::call_do_message): Silence
1699         -Wformat-nonliteral warning.
1700
1701 2019-10-12  Simon Marchi  <simon.marchi@polymtl.ca>
1702
1703         * breakpoint.c: Remove some includes: continuations.h, skip.h,
1704         mi/mi-main.h, readline/readline.h, readline/history.h.  Add
1705         include: readline/tilde.h.
1706
1707 2019-10-12  Christian Biesinger  <cbiesinger@google.com>
1708
1709         * remote.c (remote_target::get_trace_status): Remove declaration of
1710         trace_regblock_size.
1711
1712 2019-10-12  Christian Biesinger  <cbiesinger@google.com>
1713
1714         * cli/cli-cmds.c (max_user_call_depth): Move comment to header.
1715         (show_user): Remove declaration of cmdlist.
1716         * cli/cli-cmds.h (max_user_call_depth): Declare.
1717         * cli/cli-script.c (execute_user_command): Remove declaration
1718         of max_user_call_depth.
1719
1720 2019-10-11  Jim Wilson  <jimw@sifive.com>
1721
1722         * gdbsupport/print-utils.h (pulongest): Fix comment.
1723         (plongest): Likewise.
1724         (phex): Add missing comment, mention leading zeros.
1725         (phex_nz): Add mention of no leading zeros to comment.
1726
1727         * riscv-tdep.c (riscv_push_dummy_code): Change %lld to %s and use
1728         plongest instead of unsigned long long cast.
1729
1730 2019-10-10  Christian Biesinger  <cbiesinger@google.com>
1731
1732         * main.c (captured_main_1): Include gdbtk.h and remove declarations
1733         for external_editor_command and gdbtk_test.
1734
1735 2019-10-10  Christian Biesinger  <cbiesinger@google.com>
1736
1737         * mi/mi-cmd-var.c (varobjdebug): Remove declaration.
1738         * varobj.c (varobjdebug): Move comment to...
1739         * varobj.h (varobjdebug): ...here, and declare.
1740
1741 2019-10-09  Tom Tromey  <tom@tromey.com>
1742
1743         * tui/tui-regs.c (tui_data_window::show_registers): Don't call
1744         erase_data_content.
1745
1746 2019-10-09  Tom Tromey  <tom@tromey.com>
1747
1748         * tui/tui-wingeneral.h (tui_delete_win): Don't declare.
1749         * tui/tui-stack.c (tui_locator_window::rerender): Update.
1750         * tui/tui-command.c (tui_cmd_window::resize)
1751         (tui_refresh_cmd_win): Update.
1752         * tui/tui-win.c (tui_resize_all, tui_set_focus_command): Update.
1753         * tui/tui.c (tui_rl_other_window, tui_enable): Update.
1754         * tui/tui-data.c (~tui_gen_win_info): Remove.
1755         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
1756         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
1757         (tui_redisplay_readline, tui_mld_flush)
1758         (tui_mld_erase_entire_line, tui_mld_getc, tui_getc): Update.
1759         * tui/tui-regs.c (tui_data_window::delete_data_content_windows)
1760         (tui_data_window::erase_data_content)
1761         (tui_data_item_window::rerender)
1762         (tui_data_item_window::refresh_window): Update.
1763         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window)
1764         (box_win, tui_gen_win_info::make_window)
1765         (tui_gen_win_info::make_visible): Update.
1766         (tui_delete_win): Remove.
1767         * tui/tui-winsource.c
1768         (tui_source_window_base::do_erase_source_content): Update.
1769         (tui_show_source_line, tui_source_window_base::update_tab_width)
1770         (tui_source_window_base::update_exec_info): Update.
1771         * tui/tui-data.h (struct curses_deleter): New.
1772         (struct tui_gen_win_info) <handle>: Now a unique_ptr.
1773         (struct tui_gen_win_info) <~tui_gen_win_info>: Define.
1774
1775 2019-10-09  Tom Tromey  <tom@tromey.com>
1776
1777         * tui/tui-wingeneral.h (struct tui_gen_win_info): Don't declare.
1778
1779 2019-10-09  Tom Tromey  <tom@tromey.com>
1780
1781         * tui/tui-data.c (tui_win_is_auxiliary): Remove.
1782         * tui/tui-data.h (tui_win_is_auxiliary): Don't declare.
1783
1784 2019-10-09  Tom Tromey  <tom@tromey.com>
1785
1786         * tui/tui-disasm.c (tui_get_low_disassembly_address): Compute
1787         window height directly.
1788         * tui/tui-layout.h (tui_default_win_viewport_height): Don't
1789         declare.
1790         * tui/tui-layout.c (tui_default_win_height): Remove.
1791         (tui_default_win_viewport_height): Remove.
1792
1793 2019-10-09  Tom Tromey  <tom@tromey.com>
1794
1795         * tui/tui.h: Remove comments.
1796
1797 2019-10-09  Tom de Vries  <tdevries@suse.de>
1798
1799         * python/lib/gdb/printer/bound_registers.py: Use
1800         '^builtin_type_bound128' as regexp argument for
1801         add_builtin_pretty_printer.
1802
1803 2019-10-09  Christian Biesinger  <cbiesinger@google.com>
1804
1805         * guile/guile.c (guile_extension_script_ops): Remove forward
1806         declaration and mark as static.
1807         (guile_script_ops): Likewise.
1808         (extension_language_guile): Move further down in the file so
1809         it can reference the definitions for guile_{extension_,}script_ops.
1810
1811 2019-10-09  Andreas Arnez  <arnez@linux.ibm.com>
1812
1813         * s390-tdep.c (390_process_record): Handle new arch13 instructions
1814         except SORTL, DFLTCC, and KDSA.
1815
1816 2019-10-08  Tom Tromey  <tromey@adacore.com>
1817
1818         * windows-nat.c (struct windows_thread_info_struct) <sf>: Remove.
1819         (struct safe_symbol_file_add_args): Remove.
1820
1821 2019-10-08  Tom Tromey  <tromey@adacore.com>
1822
1823         * windows-nat.c: Don't include buildsym-legacy.h.
1824
1825 2019-10-08  Tom Tromey  <tromey@adacore.com>
1826
1827         * contrib/ari/gdb_ari.sh (%p): Allow gdb-specific %p extensions.
1828
1829 2019-10-08  Christian Biesinger  <cbiesinger@google.com>
1830
1831         * gdbtypes.c (overload_debug): Move comment to header.
1832         * gdbtypes.h (overload_debug): Declare.
1833         * valops.c: Remove declaration of overload_debug, instead
1834         include gdbtypes.h.
1835
1836 2019-10-08  Christian Biesinger  <cbiesinger@google.com>
1837
1838         * language.c (show_language_command): Pass lang_frame_mismatch_warn
1839         through _().
1840         (lang_frame_mismatch_warn): Make const, mark with N_(), and
1841         move comment...
1842         * language.h (lang_frame_mismatch_warn): ... here. Also add
1843         declaration.
1844         * top.c (lang_frame_mismatch_warn): Remove declaration.
1845         (check_frame_language_change): Pass lang_frame_mismatch_warn
1846         through _().
1847
1848 2019-10-07  Christian Biesinger  <cbiesinger@google.com>
1849
1850         * c-lang.h (vtbl_ptr_name): Declare.
1851         * cp-valprint.c (vtbl_ptr_name): Remove "extern" now that we get
1852         it from the header.
1853         * stabsread.c (define_symbol): Remove declaration of vtbl_ptr_name.
1854
1855 2019-10-07  Christian Biesinger  <cbiesinger@google.com>
1856
1857         * charset.c (your_gdb_wchar_t_is_bogus): Replace with a
1858         gdb_static_assert.
1859
1860 2019-10-07  Weimin Pan  <weimin.pan@oracle.com>
1861
1862         * ../Makefile.def (dependencies): Add all-libctf to all-gdb
1863         * ../Makefile.in: Add "all-gdb: maybe-all-libctf"
1864         * ctfread.c: New file.
1865         * ctfread.h: New file.
1866         * elfread.c: Include ctfread.h.
1867         (struct elfinfo text_p): New member ctfsect.
1868         (elf_locate_sections): Mark CTF section.
1869         (elf_symfile_read): Call elfctf_build_psymtabs.
1870         * Makefile.in (LIBCTF): Add.
1871         (CLIBS): Use it.
1872         (CDEPS): Likewise.
1873         (DIST): Add ctfread.c.
1874
1875 2019-10-07  Andrew Burgess  <andrew.burgess@embecosm.com>
1876
1877         * ctfread.c (struct nextfield): Renamed to ...
1878         (struct ctf_nextfield): ... this.
1879         (struct field_info): Renamed to ...
1880         (strut ctf_field_info): ... this.
1881         (attach_fields_to_type): Update for renamed structures.
1882         (ctf_add_member_cb): Likewise.
1883         (ctf_add_enum_member_cb): Likewise.
1884         (process_struct_members): Likewise.
1885         (process_enum_type): Likewise.
1886
1887 2019-10-07  Weimin Pan  <weimin.pan@oracle.com>
1888
1889         * tracectf.h: Rename, was ctf.h.
1890         * tracectf.c: Rename, was ctf.c, replace ctf.h with tracectf.h.
1891         * tracefile.c: Likewise.
1892         * tracepoint.c: Remove unused include ctf.h.
1893         * mi/mi-main.c: Likewise.
1894         * Makefile.in Replace ctf.c with tracectf.c.
1895
1896 2019-10-06  Joel Brobecker  <brobecker@adacore.com>
1897
1898         * version.in: Change version number to "9.0.50.DATE-git".
1899
1900 2019-10-03  Tom Tromey  <tom@tromey.com>
1901
1902         PR rust/24976:
1903         * dwarf2read.c (quirk_rust_enum): Handle single-element unions.
1904
1905 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1906
1907         * f-lang.c (f_language_defn): Use cp_get_symbol_name_matcher and
1908         cp_search_name_hash.
1909         * NEWS: Add entry about nested function support.
1910
1911 2019-10-03  Bernhard Heckel  <bernhard.heckel@intel.com>
1912             Andrew Burgess  <andrew.burgess@embecosm.com>
1913
1914         * cp-namespace.c (cp_search_static_and_baseclasses): Only search
1915         for nested static variables when searchin VAR_DOMAIN.
1916         * dwarf2read.c (add_partial_symbol): Add nested subroutines to the
1917         global scope, update comment.
1918         (add_partial_subprogram): Call add_partial_subprogram recursively
1919         for nested subroutines when processinng Fortran.
1920         (load_partial_dies): Process the child entities of a subprogram
1921         when processing Fortran.
1922         (partial_die_parent_scope): Handle building scope
1923         for Fortran nested functions.
1924         (process_die): Record that nested functions have a scope.
1925         (new_symbol): Always record Fortran subprograms on the global
1926         symbol list.
1927         (determine_prefix): How to build the prefix for Fortran
1928         subprograms.
1929
1930 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1931
1932         * linux-nat.c (linux_nat_filter_event): Don't ignore SIGSTOP if we
1933         have just sent the thread a SIGSTOP and are waiting for it to
1934         arrive.
1935
1936 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1937
1938         * btrace.c (btrace_add_pc): Remove whitespace before the template
1939         parameter in 'std::vector <...>'.
1940         (parse_xml_btrace_block): Likewise.
1941         (btrace_maint_decode_pt): Likewise.
1942         (btrace_maint_update_packets): Likewise.
1943         (btrace_maint_print_packets): Likewise.
1944         * btrace.h (struct btrace_maint_info): Likewise.
1945         * dwarf2read.c (struct type_unit_group): Likewise.
1946         (build_type_psymtabs_reader): Likewise.
1947         * gdbsupport/btrace-common.c (btrace_data_append): Likewise.
1948         * gdbsupport/btrace-common.h (struct btrace_data_bts): Likewise.
1949         * nat/linux-btrace.c (perf_event_read_bts): Likewise.
1950
1951 2019-10-03  Tom de Vries  <tdevries@suse.de>
1952
1953         * cli/cli-style.c (_initialize_cli_style): Adding a '.' at the end of
1954         the first line of the help text for set/show style metadata.
1955
1956 2019-10-02  Tom Tromey  <tromey@adacore.com>
1957
1958         * Makefile.in (COMMON_SFILES): Add common-inferior.c.
1959         * gdbsupport/common-inferior.c: New file.
1960         * infcmd.c (startup_with_shell): Don't define.
1961         * nat/fork-inferior.h (startup_with_shell): Don't declare.
1962         * gdbsupport/common-inferior.h (startup_with_shell): Declare.
1963         * inferior.h (startup_with_shell): Don't declare.
1964
1965 2019-10-02  Christian Biesinger  <cbiesinger@google.com>
1966
1967         * gdbsupport/gdb_assert.h: Include errors.h.
1968         * gdbsupport/gdb_string_view.h: Include gdb_assert.h.
1969
1970 2019-10-02  Tom Tromey  <tromey@adacore.com>
1971
1972         * NEWS: Add $_ada_exception entry.
1973         * ada-lang.c (struct ada_catchpoint): Add constructor.
1974         <m_kind>: New member.
1975         (allocate_location_exception, re_set_exception): Remove
1976         "ex" parameter.
1977         (should_stop_exception): Compute $_ada_exception.
1978         (check_status_exception, print_it_exception)
1979         (print_one_exception, print_mention_exception): Remove
1980         "ex" parameter.
1981         (allocate_location_catch_exception, re_set_catch_exception)
1982         (check_status_exception, print_it_catch_exception)
1983         (print_one_catch_exception, print_mention_catch_exception)
1984         (print_recreate_catch_exception)
1985         (allocate_location_catch_exception_unhandled)
1986         (re_set_catch_exception_unhandled)
1987         (check_status_exception, print_it_catch_exception_unhandled)
1988         (print_one_catch_exception_unhandled)
1989         (print_mention_catch_exception_unhandled)
1990         (print_recreate_catch_exception_unhandled)
1991         (allocate_location_catch_assert, re_set_catch_assert)
1992         (check_status_assert, print_it_catch_assert)
1993         (print_one_catch_assert, print_mention_catch_assert)
1994         (print_recreate_catch_assert)
1995         (allocate_location_catch_handlers, re_set_catch_handlers)
1996         (check_status_handlers, print_it_catch_handlers)
1997         (print_one_catch_handlers, print_mention_catch_handlers)
1998         (print_recreate_catch_handlers): Remove.
1999         (create_ada_exception_catchpoint): Update.
2000         (initialize_ada_catchpoint_ops): Update.
2001
2002 2019-10-02  Tom Tromey  <tromey@adacore.com>
2003
2004         * ada-lang.c (ada_lookup_simple_minsyms): Remove.
2005         (create_excep_cond_exprs): Simplify exception string computation.
2006         (ada_exception_catchpoint_cond_string): Likewise.
2007
2008 2019-10-02  Tom Tromey  <tromey@adacore.com>
2009
2010         * symmisc.c (dump_msymbols): Don't use MSYMBOL_VALUE_ADDRESS.
2011         * ada-lang.c (lesseq_defined_than): Handle
2012         LOC_STATIC.
2013         * dwarf2read.c (dwarf2_per_objfile): Add can_copy
2014         parameter.
2015         (dwarf2_has_info): Likewise.
2016         (new_symbol): Set maybe_copied on symbol when
2017         appropriate.
2018         * dwarf2read.h (dwarf2_per_objfile): Add can_copy
2019         parameter.
2020         <can_copy>: New member.
2021         * elfread.c (record_minimal_symbol): Set maybe_copied
2022         on symbol when appropriate.
2023         (elf_symfile_read): Update call to dwarf2_has_info.
2024         * minsyms.c (lookup_minimal_symbol_linkage): New
2025         function.
2026         * minsyms.h (lookup_minimal_symbol_linkage): Declare.
2027         * symtab.c (get_symbol_address, get_msymbol_address):
2028         New functions.
2029         * symtab.h (get_symbol_address, get_msymbol_address):
2030         Declare.
2031         (SYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_ADDRESS): Handle
2032         maybe_copied.
2033         (struct symbol, struct minimal_symbol) <maybe_copied>:
2034         New member.
2035
2036 2019-10-02  Tom Tromey  <tromey@adacore.com>
2037
2038         * source.c (struct current_source_location): New.
2039         (current_source_key): New global.
2040         (current_source_symtab, current_source_line)
2041         (current_source_pspace): Remove.
2042         (get_source_location): New function.
2043         (get_current_source_symtab_and_line)
2044         (set_default_source_symtab_and_line)
2045         (set_current_source_symtab_and_line)
2046         (clear_current_source_symtab_and_line, select_source_symtab)
2047         (info_source_command, print_source_lines_base)
2048         (info_line_command, search_command_helper, _initialize_source):
2049         Update.
2050
2051 2019-10-02  Tom Tromey  <tromey@adacore.com>
2052
2053         * source.c (select_source_symtab): Don't call
2054         decode_line_with_current_source.
2055
2056 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
2057
2058         * symtab.c (lookup_global_symbol): Search global block.
2059
2060 2019-10-02  Tom Tromey  <tromey@adacore.com>
2061
2062         * coffread.c (process_coff_symbol): Update.
2063         * dwarf2read.c (var_decode_location, new_symbol): Update.
2064         * mdebugread.c (parse_symbol): Update.
2065         * objfiles.c (relocate_one_symbol): Update.
2066         * stabsread.c (define_symbol, fix_common_block)
2067         (scan_file_globals): Update.
2068         * symtab.h (SYMBOL_VALUE_ADDRESS): Expand to an rvalue.
2069         (SET_SYMBOL_VALUE_ADDRESS): New macro.
2070         * xcoffread.c (process_xcoff_symbol): Update.
2071
2072 2019-10-02  Andreas Arnez  <arnez@linux.ibm.com>
2073
2074         * MAINTAINERS: Update my email address.
2075
2076 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
2077
2078         * dwarf2read.c (struct type_unit_group) <tus>: Convert to
2079         std::vector.
2080         (build_type_psymtabs_reader): Update for std::vector.
2081         (build_type_psymtab_dependencies): Likewise.
2082         * dwarf2read.h: Remove use of DEF_VEC_P.
2083         (typedef sig_type_ptr): Delete.
2084
2085 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
2086
2087         * btrace.c (btrace_maint_clear): Update to handle change from VEC
2088         to std::vector.
2089         (btrace_maint_decode_pt): Likewise, and move allocation of the
2090         vector outside of the loop.
2091         (btrace_maint_update_packets): Update to handle change from VEC to
2092         std::vector.
2093         (btrace_maint_print_packets): Likewise.
2094         (maint_info_btrace_cmd): Likewise.
2095         * btrace.h: Remove use of DEF_VEC_O.
2096         (typedef btrace_pt_packet_s): Delete.
2097         (struct btrace_maint_info) <packets>: Change fromm VEC to
2098         std::vector.
2099         * gdbsupport/btrace-common.h: Remove 'vec.h' include.
2100
2101 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
2102
2103         * btrace.c (btrace_compute_ftrace_bts): Update for std::vector,
2104         make accesses into the vector constant references.
2105         (btrace_add_pc): Update for std::vector.
2106         (btrace_stitch_bts): Likewise.
2107         (parse_xml_btrace_block): Likewise.
2108         (btrace_maint_update_packets): Likewise.
2109         (btrace_maint_print_packets): Likewise.
2110         (maint_info_btrace_cmd): Likewise.
2111         * gdbsupport/btrace-common.c (btrace_data::fini): Update for
2112         std::vector.
2113         (btrace_data::empty): Likewise.
2114         (btrace_data_append): Likewise.
2115         * gdbsupport/btrace-common.h: Remove use of DEF_VEC_O.
2116         (typedef btrace_block_s): Delete.
2117         (struct btrace_block): Add constructor.
2118         (struct btrace_data_bts) <blocks>: Change to std::vector.
2119         * nat/linux-btrace.c (perf_event_read_bts): Update for
2120         std::vector.
2121         (linux_read_bts): Likewise.
2122
2123 2019-10-01  Tom Tromey  <tom@tromey.com>
2124
2125         * cli/cli-logging.c (show_logging_filename): Use styled_string.
2126
2127 2019-10-01  Tom Tromey  <tom@tromey.com>
2128
2129         * stack.c (print_frame, info_frame_command_core): Use
2130         styled_string.
2131         * linux-thread-db.c (try_thread_db_load_1)
2132         (try_thread_db_load_from_pdir_1): Use styled_string.
2133         * auto-load.c (file_is_auto_load_safe, execute_script_contents)
2134         (auto_load_section_scripts, info_auto_load_local_gdbinit)
2135         (maybe_print_unsupported_script_warning)
2136         (maybe_print_script_not_found_warning): Use styled_string.
2137         * ada-lang.c (user_select_syms): Use styled_string.
2138
2139 2019-10-01  Tom Tromey  <tom@tromey.com>
2140
2141         * p-lang.c (pascal_printstr): Use metadata style.
2142         * value.c (show_convenience): Use metadata style.
2143         * valprint.c (valprint_check_validity, val_print_optimized_out)
2144         (val_print_not_saved, val_print_unavailable)
2145         (val_print_invalid_address, generic_val_print, val_print)
2146         (value_check_printable, val_print_array_elements): Use metadata
2147         style.
2148         * ui-out.h (class ui_out) <field_fmt>: New overload.
2149         <do_field_fmt>: Add style parameter.
2150         * ui-out.c (ui_out::field_fmt): New overload.
2151         * typeprint.c (type_print_unknown_return_type)
2152         (val_print_not_allocated, val_print_not_associated): Use metadata
2153         style.
2154         * tui/tui-out.h (class tui_ui_out) <do_field_fmt>: Add style
2155         parameter.
2156         * tui/tui-out.c (tui_ui_out::do_field_fmt): Update.
2157         * tracepoint.c (tvariables_info_1): Use metadata style.
2158         * stack.c (print_frame_arg, print_frame_info, print_frame)
2159         (info_frame_command_core): Use metadata style.
2160         * skip.c (info_skip_command): Use metadata style.
2161         * rust-lang.c (rust_print_enum): Use metadata style.
2162         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
2163         metadata style.
2164         * python/py-framefilter.c (py_print_single_arg): Use metadata
2165         style.
2166         * printcmd.c (do_one_display, print_variable_and_value): Use
2167         metadata style.
2168         * p-valprint.c (pascal_val_print)
2169         (pascal_object_print_value_fields): Use metadata style.
2170         * p-typeprint.c (pascal_type_print_base): Use metadata style.
2171         * mi/mi-out.h (class mi_ui_out) <do_field_fmt>: Add style
2172         parameter.
2173         * mi/mi-out.c (mi_ui_out::do_field_fmt): Update.
2174         * m2-valprint.c (m2_print_long_set): Use metadata style.
2175         * m2-typeprint.c (m2_print_type): Use metadata style.
2176         * infcmd.c (print_return_value_1): Use metadata style.
2177         * gnu-v3-abi.c (print_one_vtable): Use metadata style.
2178         * f-valprint.c (info_common_command_for_block): Use metadata
2179         style.
2180         * f-typeprint.c (f_type_print_base): Use metadata style.
2181         * expprint.c (print_subexp_standard): Use metadata style.
2182         * cp-valprint.c (cp_print_value_fields): Use metadata style.
2183         * cli/cli-style.h (class cli_style_option): Add constructor.
2184         (metadata_style): Declare.
2185         * cli/cli-style.c (metadata_style): New global.
2186         (_initialize_cli_style): Register metadata style.
2187         * cli-out.h (class cli_ui_out) <do_field_fmt>: Add style
2188         parameter.
2189         * cli-out.c (cli_ui_out::do_field_fmt): Update.
2190         * c-typeprint.c (c_type_print_base_struct_union)
2191         (c_type_print_base_1): Use metadata style.
2192         * breakpoint.c (watchpoint_value_print)
2193         (print_one_breakpoint_location): Use metadata style.
2194         * break-catch-syscall.c (print_one_catch_syscall): Use metadata
2195         style.
2196         * break-catch-sig.c (signal_catchpoint_print_one): Use metadata
2197         style.
2198         * ada-valprint.c (val_print_packed_array_elements, printstr)
2199         (print_field_values, ada_val_print_ref, ada_val_print): Use
2200         metadata style.
2201         * ada-typeprint.c (print_array_type, ada_print_type): Use metadata
2202         style.
2203         * ada-tasks.c (print_ada_task_info, info_task): Use metadata
2204         style.
2205         * ada-lang.c (user_select_syms): Use metadata style.
2206
2207 2019-10-01  Tom Tromey  <tom@tromey.com>
2208
2209         * cli/cli-cmds.c (pwd_command): Style output.
2210
2211 2019-10-01  Pedro Alves  <palves@redhat.com>
2212             Tom Tromey  <tom@tromey.com>
2213
2214         * symtab.c (print_symbol_info): Use %ps.
2215         (print_msymbol_info): Use %ps.
2216         * symfile.c (symbol_file_add_with_addrs): Use %ps.
2217         * printcmd.c (print_variable_and_value): Use %ps.
2218         * macrocmd.c (show_pp_source_pos): Use %ps.
2219         * infrun.c (print_exited_reason): Use ui_out::message.
2220         * breakpoint.c (watchpoint_check, print_one_breakpoint_location)
2221         (describe_other_breakpoints): Use ui_out::message and new
2222         formats.
2223         (say_where): Use new formats.
2224         (bkpt_print_it, tracepoint_print_one_detail): Use ui_out::message
2225         and new formats.
2226
2227 2019-10-01  Pedro Alves  <palves@redhat.com>
2228             Tom Tromey  <tom@tromey.com>
2229
2230         * unittests/format_pieces-selftests.c: Add gdb_format parameter.
2231         (test_gdb_formats): New function.
2232         (run_tests): Call it.
2233         (test_format_specifier): Update.
2234         * utils.h (fputs_filtered): Update comment.
2235         (vfprintf_styled, vfprintf_styled_no_gdbfmt)
2236         (fputs_styled_unfiltered): Declare.
2237         * utils.c (fputs_styled_unfiltered): New function.
2238         (vfprintf_maybe_filtered): Add gdbfmt parameter.
2239         (vfprintf_filtered): Update.
2240         (vfprintf_unfiltered, vprintf_filtered): Update.
2241         (vfprintf_styled, vfprintf_styled_no_gdbfmt): New functions.
2242         * ui-out.h (enum ui_out_flag) <unfiltered_output,
2243         disallow_ui_out_field>: New constants.
2244         (enum class field_kind): New.
2245         (struct base_field_s, struct signed_field_s): New.
2246         (signed_field): New function.
2247         (struct string_field_s): New.
2248         (string_field): New function.
2249         (struct styled_string_s): New.
2250         (styled_string): New function.
2251         (class ui_out) <message>: Add comment.
2252         <vmessage, call_do_message>: New methods.
2253         <do_message>: Add style parameter.
2254         * ui-out.c (ui_out::call_do_message, ui_out::vmessage): New
2255         methods.
2256         (ui_out::message): Rewrite.
2257         * mi/mi-out.h (class mi_ui_out) <do_message>: Add style
2258         parameter.
2259         * mi/mi-out.c (mi_ui_out::do_message): Add style parameter.
2260         * gdbsupport/format.h (class format_pieces) <format_pieces>: Add
2261         gdb_extensions parameter.
2262         (class format_piece): Add parameter to constructor.
2263         (n_int_args): New field.
2264         * gdbsupport/format.c (format_pieces::format_pieces): Add
2265         gdb_extensions parameter.  Handle '*'.
2266         * cli-out.h (class cli_ui_out) <do_message>: Add style parameter.
2267         * cli-out.c (cli_ui_out::do_message): Add style parameter.  Call
2268         vfprintf_styled_no_gdbfmt.
2269         (cli_ui_out::do_field_string, cli_ui_out::do_spaces)
2270         (cli_ui_out::do_text, cli_ui_out::field_separator): Allow
2271         unfiltered output.
2272         * ui-style.h (struct ui_file_style) <ptr>: New method.
2273
2274 2019-10-01  Tom Tromey  <tom@tromey.com>
2275
2276         * unittests/format_pieces-selftests.c: Update.  Add final format.
2277         * gdbsupport/format.c (format_pieces::format_pieces): Don't add
2278         empty literal pieces.
2279
2280 2019-10-01  Tom Tromey  <tom@tromey.com>
2281
2282         * ui-out.h (enum class ui_out_style_kind): Remove.
2283         (class ui_out) <field_string, field_stsream, do_field_string>:
2284         Change type of "style".
2285         * ui-out.c (ui_out::field_core_addr, ui_out::field_stream)
2286         (ui_out::field_string): Update.
2287         * tui/tui-out.h (class tui_ui_out) <do_field_string>: Change type
2288         of "style".
2289         * tui/tui-out.c (tui_ui_out::do_field_string): Update.
2290         * tracepoint.c (print_one_static_tracepoint_marker): Update.
2291         * stack.c (print_frame_arg, print_frame_info, print_frame):
2292         Update.
2293         * source.c (print_source_lines_base): Update.
2294         * solib.c (info_sharedlibrary_command): Update.
2295         * skip.c (info_skip_command): Update.
2296         * record-btrace.c (btrace_call_history_src_line)
2297         (btrace_call_history): Update.
2298         * python/py-framefilter.c (py_print_frame): Update.
2299         * mi/mi-out.h (class mi_ui_out) <do_field_string>: Change type of
2300         "style".
2301         * mi/mi-out.c (mi_ui_out::do_table_header)
2302         (mi_ui_out::do_field_signed, mi_ui_out::do_field_unsigned)
2303         (mi_ui_out::do_field_string): Update.
2304         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
2305         Update.
2306         * cli-out.h (class cli_ui_out) <do_field_string>: Change type of
2307         "style".
2308         * cli-out.c (cli_ui_out::do_table_header)
2309         (cli_ui_out::do_field_signed, cli_ui_out::do_field_unsigned)
2310         (cli_ui_out::do_field_skip, cli_ui_out::do_field_string)
2311         (cli_ui_out::do_field_fmt): Update.
2312         * breakpoint.c (print_breakpoint_location): Update.
2313         (update_static_tracepoint): Update.
2314
2315 2019-10-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2316
2317         * main.c (relocate_gdbinit_path_maybe_in_datadir): Remove std::string
2318         conversion of gdb_datadir.
2319         (captured_main_1): Remove xstrdup when assigning to gdb_datadir,
2320         remove not needed c_str ().
2321
2322 2019-09-30  Ali Tamur <tamur@google.com>
2323
2324         * dwarf2read.c (skip_one_die): Handle DW_FORM_strx forms.
2325         (dwarf2_string_attr): Likewise.
2326
2327 2019-09-30  Ali Tamur <tamur@google.com>
2328
2329         * dwarf2read.c (process_full_comp_unit): Remove whitespace at the EOL.
2330         (process_full_type_unit): Likewise.
2331         (dump_die_shallow): Likewise.
2332         (cu_debug_loc_section): Likewise.
2333
2334 2019-09-28  Christian Biesinger  <cbiesinger@google.com>
2335
2336         * minsyms.c (compare_minimal_symbols): Rename to...
2337         (minimal_symbol_is_less_than): ...this, and adjust to STL
2338         conventions (return bool, take arguments as references)
2339         (minimal_symbol_reader::install): Call std::sort instead
2340         of qsort.
2341
2342 2019-09-29  Christian Biesinger  <cbiesinger@google.com>
2343
2344         * minsyms.h (msymbol_hash): Document that this is a case-insensitive
2345         hash and why.
2346         * objfiles.h (struct objfile_per_bfd_storage) <demangled_names_hash,
2347         msymbol_hash, msymbol_demangled_hash>: Improve comments.
2348
2349 2019-09-30  Simon Marchi  <simon.marchi@polymtl.ca>
2350
2351         * psymtab.c (add_psymbol_to_list): Move comment to psympriv.h.
2352         * psympriv.h (add_psymbol_to_list): Move comment here and update
2353         it.
2354
2355 2019-09-29  Tom de Vries  <tdevries@suse.de>
2356
2357         * contrib/cc-with-tweaks.sh (get_tmpdir): New function.
2358         Use $tmpdir/$(basename "$output_file").dwz instead of
2359         "${output_file}.dwz".
2360
2361 2019-09-28  Simon Marchi  <simon.marchi@polymtl.ca>
2362
2363         PR gdb/25045
2364         * hppa-linux-nat.c: Include gdbarch.h.
2365
2366 2019-09-26  Christian Biesinger  <cbiesinger@google.com>
2367
2368         * blockframe.c (find_pc_partial_function): Change return type to bool.
2369         * elfread.c (elf_gnu_ifunc_resolve_name): Likewise.
2370         * minsyms.c (in_gnu_ifunc_stub): Likewise.
2371         (stub_gnu_ifunc_resolve_name): Likewise.
2372         * symtab.c (compare_filenames_for_search): Likewise.
2373         (compare_glob_filenames_for_search): Likewise.
2374         (matching_obj_sections): Likewise.
2375         (symbol_matches_domain): Likewise.
2376         (find_line_symtab): Change out param EXACT_MATCH to bool *.
2377         (find_line_pc): Change return type to bool.
2378         (find_line_pc_range): Likewise.
2379         (producer_is_realview): Likewise.
2380         * symtab.h (symbol_matches_domain): Likewise.
2381         (find_pc_partial_function): Likewise.
2382         (find_pc_line_pc_range): Likewise.
2383         (in_gnu_ifunc_stub): Likewise.
2384         (struct gnu_ifunc_fns) <gnu_ifunc_resolve_name>: Likewise.
2385         (find_line_pc): Likewise.
2386         (find_line_pc_range): Likewise.
2387         (matching_obj_sections): Likewise.
2388         (find_line_symtab): Change out parameter to bool.
2389         (producer_is_realview): Change return type to bool.
2390         (compare_filenames_for_search): Likewise.
2391         (compare_glob_filenames_for_search): Likewise.
2392
2393 2019-09-26  Tom Tromey  <tom@tromey.com>
2394
2395         * Makefile.in (COMMON_SFILES): Remove gdb_usleep.c.
2396         (HFILES_NO_SRCDIR): Remove gdb_usleep.h.
2397         * gdb_usleep.h: Remove.
2398         * gdb_usleep.c: Remove.
2399         * utils.c: Don't include gdb_usleep.h.
2400
2401 2019-09-26  Tom Tromey  <tromey@adacore.com>
2402
2403         * python/py-type.c (type_to_type_object): Call check_typedef
2404         for stub types.
2405
2406 2019-09-26  Tom Tromey  <tom@tromey.com>
2407
2408         * utils.h (initialize_utils): Don't declare.
2409         * top.c (gdb_init): Don't call initialize_utils.
2410         * utils.c (initialize_utils): Remove.  Move contents...
2411         (_initialize_utils): ... here.
2412
2413 2019-09-25  Tom Tromey  <tom@tromey.com>
2414
2415         * python/py-objfile.c (objfpy_get_build_id): Use bin2hex.
2416         * utils.h (make_hex_string): Don't declare.
2417         * utils.c (make_hex_string): Remove.
2418
2419 2019-09-24  Tom de Vries  <tdevries@suse.de>
2420
2421         PR gdb/23815
2422         * amd64-linux-nat.c (amd64_linux_nat_target::fetch_registers):
2423         Initialize xstateregs before ptrace PTRACE_GETREGSET call.
2424
2425 2019-09-23  Dimitar Dimitrov  <dimitar@dinux.eu>
2426
2427         * NEWS: Mention new simulator port for PRU.
2428
2429 2019-09-23  Christian Biesinger  <cbiesinger@google.com>
2430
2431         * ada-exp.y (write_object_remaining): Update.
2432         * ada-lang.c (ada_decode): Return a std::string instead of a char*
2433         and eliminate the static buffer.
2434         (ada_decode_symbol): Update.
2435         (ada_la_decode): Update.
2436         (ada_sniff_from_mangled_name): Update.
2437         (is_valid_name_for_wild_match): Update.
2438         (ada_lookup_name_info::matches): Update and simplify.
2439         (name_matches_regex): Update.
2440         (ada_add_global_exceptions): Update.
2441         * ada-lang.h (ada_decode): Update signature.
2442         * ada-varobj.c (ada_varobj_describe_simple_array_child): Update.
2443         * dwarf-index-write.c (debug_names::insert): Update.
2444
2445 2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>
2446
2447         * solib-svr4.c (svr4_iterate_over_objfiles_in_search_order): Fix
2448         formatting.
2449
2450 2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>
2451
2452         * breakpoint.h (bp_location) <inserted, permanent, duplicate>:
2453         Change "nonzero" to "true" in documentation.
2454
2455 2019-09-20  Christian Biesinger  <cbiesinger@google.com>
2456
2457         * solib-darwin.c (darwin_lookup_lib_symbol): Remove.
2458         (_initialize_darwin_solib): Don't set
2459         darwin_so_ops.lookup_lib_global_symbol.
2460         * solib-svr4.c (set_solib_svr4_fetch_link_map_offsets): Call
2461         set_gdbarch_iterate_over_objfiles_in_search_order.
2462         (elf_lookup_lib_symbol): Rename to...
2463         (svr4_iterate_over_objfiles_in_search_order): this, and update
2464         to iterate semantics.
2465         (_initialize_svr4_solib): Don't set lookup_lib_global_symbol.
2466         * solib.c (solib_global_lookup): Remove.
2467         * solist.h (struct target_so_ops): Remove lookup_lib_global_symbol.
2468         (solib_global_lookup): Remove.
2469         * symtab.c (lookup_global_or_static_symbol): Remove call to
2470         solib_global_lookup.
2471
2472 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
2473
2474         * NEWS: Move entries about default MI version now being
2475         version 3, and about the GDB/MI fix for multi-location
2476         breakpoints to the "since GDB 8.3" section.
2477
2478 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
2479
2480         GDB 8.3.1 released.
2481
2482 2019-09-20  Ulrich Weigand  <uweigand@de.ibm.com>
2483
2484         * NEWS: Mention that Cell/B.E. debugging support was removed.
2485         * MAINTAINERS: Remove spu target.
2486
2487         * config/djgpp/fnchange.lst: Remove entries for removed files.
2488
2489         * Makefile.in (ALL_TARGET_OBS): Remove solib-spu.o,
2490         spu-multiarch.o, and spu-tdep.o.
2491         (HFILES_NO_SRCDIR): Remove solib-spu.h and spu-tdep.h.
2492         (ALLDEPFILES): Remove solib-spu.c, spu-linux-nat.c,
2493         spu-multiarch.c, and spu-tdep.c.
2494         * spu-linux-nat.c: Remove file.
2495         * spu-multiarch.c: Remove file.
2496         * spu-tdep.c: Remove file.
2497         * spu-tdep.h: Remove file.
2498         * solib-spu.c: Remove file.
2499         * solib-spu.h: Remove file.
2500
2501         * configure.host (powerpc64*-*-linux*): Remove Cell/B.E. support.
2502         * configure.nat (spu-linux): Remove.
2503         * configure.tgt (powerpc*-*-linux*): Remove solib-spu.o and
2504         solib-multiarch.o from gdb_target_obs.
2505         (spu*-*-*): Remove.
2506
2507         * arch/ppc-linux-common.h (struct ppc_linux_features): Remove "cell"
2508         feature flag.
2509         (ppc_linux_no_features): Update.
2510         * arch/ppc-linux-common.c (ppc_linux_match_description): Remove
2511         Cell/B.E. support.
2512         * arch/ppc-linux-tdesc.h (tdesc_powerpc_cell32l): Remove declaration.
2513         (tdesc_powerpc_cell64l): Likewise.
2514         * nat/ppc-linux.h (PPC_FEATURE_CELL): Remove.
2515         * ppc-linux-nat.c (ppc_linux_nat_target::read_description): Remove
2516         Cell/B.E. support.
2517         * ppc-linux-tdep.h: Do not include "solib-spu.h" or "spu-tdep.h".
2518         Do not include "features/rs6000/powerpc-cell32l.c" or
2519         "features/rs6000/powerpc-cell64l.c".
2520         (ppc_linux_spu_section): Remove.
2521         (ppc_linux_core_read_description): Remove Cell/B.E. support.
2522         (spe_context_objfile, spe_context_lm_addr, spe_context_offset,
2523         spe_context_cache_ptid, spe_context_cache_ptid): Remove.
2524         (ppc_linux_spe_context_lookup): Remove.
2525         (ppc_linux_spe_context_inferior_created): Remove.
2526         (ppc_linux_spe_context_solib_loaded): Remove.
2527         (ppc_linux_spe_context_solib_unloaded): Remove.
2528         (ppc_linux_spe_context): Remove.
2529         (struct ppu2spu_cache): Remove.
2530         (ppu2spu_prev_arch, ppu2spu_this_id, ppu2spu_prev_register): Remove.
2531         (struct ppu2spu_data): Remove.
2532         (ppu2spu_unwind_register, ppu2spu_sniffer, ppu2spu_dealloc_cache,
2533         ppu2spu_unwind): Remove.
2534         (ppc_linux_init_abi): Remove Cell/B.E. support.
2535         * rs6000-tdep.h (rs6000_gdbarch_init): Remove Cell/B.E. support.
2536
2537         * features/Makefile (rs6000/powerpc-cell32l-expedite): Remove.
2538         (rs6000/powerpc-cell64l-expedite): Likewise
2539         (WHICH): Remove rs6000/powerpc-cell32l and rs6000/powerpc-cell64l.
2540         (XMLTOC): Remove rs6000/powerpc-cell32l.xml and
2541         rs6000/powerpc-cell64l.xml.
2542         * features/rs6000/powerpc-cell32l.xml: Remove.
2543         * features/rs6000/powerpc-cell64l.xml: Likewise.
2544         * features/rs6000/powerpc-cell32l.c: Remove generated file.
2545         * features/rs6000/powerpc-cell64l.c: Likewise.
2546         * regformats/rs6000/powerpc-cell32l.dat: Remove generated file.
2547         * regformats/rs6000/powerpc-cell64l.dat: Likewise.
2548         * regformats/reg-spu.dat: Remove.
2549
2550         * target.h (enum target_object): Remove TARGET_OBJECT_SPU.
2551         * corelow.c (struct spuid_list): Remove.
2552         (add_to_spuid_list): Remove.
2553         (core_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
2554         * remote.c (PACKET_qXfer_spu_read, PACKET_qXfer_spu_write): Remove.
2555         (remote_protocol_features): Remove associated entries.
2556         (_initialize_remote): No longer initialize them.
2557         (remote_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
2558         * linux-nat.c (SPUFS_MAGIC): Remove.
2559         (linux_proc_xfer_spu): Remove.
2560         (spu_enumerate_spu_ids): Remove.
2561         (linux_nat_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
2562         * linux-tdep.c (-linux_spu_make_corefile_notes): Remove.
2563         (linux_make_corefile_notes): No longer call it.
2564
2565         * regcache.c (cooked_read_test): Remove bfd_arch_spu special case.
2566         (cooked_write_test): Likewise.
2567
2568 2019-09-20  Tom Tromey  <tom@tromey.com>
2569
2570         * NEWS: Mention case-sensitivity of TUI commands.
2571         * tui/tui-win.c (tui_set_focus_command): Now case-sensitive.
2572         (tui_set_win_height_command, parse_scrolling_args): Likewise.
2573         * tui/tui-layout.c (tui_layout_command): Now case-sensitive.
2574
2575 2019-09-20  Tom Tromey  <tom@tromey.com>
2576
2577         * tui/tui-source.c (tui_source_window::set_contents): Use
2578         make_unique_xstrdup.
2579         * tui/tui-disasm.c (tui_disasm_window::set_contents): Use
2580         make_unique_xstrdup.
2581
2582 2019-09-20  Tom Tromey  <tom@tromey.com>
2583
2584         * tui/tui-data.c: Remove separator comments.
2585         * tui/tui-layout.c: Remove separator comments.
2586         * tui/tui-win.c: Remove separator comments.
2587         * tui/tui-wingeneral.c: Remove separator comments.
2588
2589 2019-09-20  Tom Tromey  <tom@tromey.com>
2590
2591         * tui/tui.h (strcat_to_buf): Don't declare.
2592         * tui/tui.c (strcat_to_buf): Remove.
2593
2594 2019-09-20  Tom Tromey  <tom@tromey.com>
2595
2596         * tui/tui-source.h (struct tui_source_window) <m_fullname>: Rename
2597         from "fullname".
2598         * tui/tui-source.c (tui_source_window::set_contents)
2599         (tui_source_window::location_matches_p)
2600         (tui_source_window::maybe_update): Update.
2601
2602 2019-09-20  Tom Tromey  <tom@tromey.com>
2603
2604         * tui/tui-regs.h (struct tui_data_window) <get_current_group>:
2605         Update.
2606         <m_regs_content, m_regs_column_count, m_current_group>: Add "m_"
2607         prefix.
2608         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
2609         (tui_data_window::line_from_reg_element_no)
2610         (tui_data_window::first_reg_element_no_inline)
2611         (tui_data_window::show_registers)
2612         (tui_data_window::show_register_group)
2613         (tui_data_window::display_registers_from)
2614         (tui_data_window::display_registers_from_line)
2615         (tui_data_window::first_data_item_displayed)
2616         (tui_data_window::delete_data_content_windows)
2617         (tui_data_window::erase_data_content)
2618         (tui_data_window::do_scroll_vertical)
2619         (tui_data_window::refresh_window)
2620         (tui_data_window::check_register_values): Update.
2621
2622 2019-09-20  Tom Tromey  <tom@tromey.com>
2623
2624         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN): Remove define.
2625         (struct tui_locator_window) <full_name, proc_name>: Now
2626         std::string.
2627         * tui/tui-stack.c (tui_locator_window::make_status_line)
2628         (tui_locator_window::set_locator_fullname)
2629         (tui_locator_window::set_locator_info): Update.
2630         * tui/tui-source.c (tui_source_window::set_contents)
2631         (tui_source_window::showing_source_p): Update.
2632
2633 2019-09-20  Tom Tromey  <tom@tromey.com>
2634
2635         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
2636         Don't call tui_locator_win_info_ptr.
2637
2638 2019-09-20  Tom Tromey  <tom@tromey.com>
2639
2640         * tui/tui-win.c (tui_resize_all): Don't call refresh.
2641
2642 2019-09-20  Tom Tromey  <tom@tromey.com>
2643
2644         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use 1 as
2645         height for locator.
2646         * tui/tui-stack.c (tui_locator_window::rerender): Call scrollok.
2647         * tui/tui-layout.c (show_source_disasm_command, show_data)
2648         (show_source_or_disasm_and_command): Use 1 as height for locator.
2649
2650 2019-09-20  Tom Tromey  <tom@tromey.com>
2651
2652         * tui/tui.c (tui_enable): Update.
2653         * tui/tui-win.c (tui_sigwinch_handler, tui_async_resize_screen):
2654         Update.
2655         * tui/tui-data.h (tui_win_resized, tui_set_win_resized_to):
2656         Update.
2657         * tui/tui-data.c (win_resized): Now bool.
2658         (tui_win_resized): Return bool.
2659         (tui_set_win_resized_to): Accept a bool.
2660
2661 2019-09-20  Tom Tromey  <tom@tromey.com>
2662
2663         * tui/tui-regs.h (struct tui_data_window) <show_register_group>:
2664         Change type of "refresh_values_only".
2665         * tui/tui-regs.c (tui_data_window::show_register_group): Change
2666         type of "refresh_values_only".
2667
2668 2019-09-20  Tom Tromey  <tom@tromey.com>
2669
2670         * tui/tui-disasm.c (struct tui_asm_line) <addr_string, insn>: Now
2671         std::string.
2672         (tui_disassemble): Add "pos" parameter.
2673         (tui_disasm_window::set_contents): Simplify.
2674
2675 2019-09-20  Tom Tromey  <tom@tromey.com>
2676
2677         * tui/tui-winsource.h (struct tui_source_window_base)
2678         <show_source_content>: Now private.
2679         * tui/tui-winsource.c
2680         (tui_source_window_base::show_source_content): Don't handle empty
2681         content case.
2682
2683 2019-09-20  Tom Tromey  <tom@tromey.com>
2684
2685         * tui/tui-layout.c (show_source_disasm_command)
2686         (show_source_or_disasm_and_command): Don't call
2687         show_source_content.
2688
2689 2019-09-20  Tom Tromey  <tom@tromey.com>
2690
2691         * tui/tui-stack.h (struct tui_locator_window) <make_status_line>:
2692         Declare.
2693         * tui/tui-stack.c (tui_locator_window::make_status_line): Rename
2694         from tui_make_status_line.
2695         (tui_locator_window::rerender): Update.
2696
2697 2019-09-20  Tom Tromey  <tom@tromey.com>
2698
2699         * tui/tui-stack.c (tui_make_status_line): Return std::string.
2700         (tui_locator_window::rerender): Update.
2701
2702 2019-09-20  Tom Tromey  <tom@tromey.com>
2703
2704         * tui/tui-winsource.h (struct tui_source_window_base)
2705         <~tui_source_window_base>: Don't declare.
2706         <fullname>: Remove.
2707         * tui/tui-winsource.c (~tui_source_window_base): Remove.
2708         * tui/tui-source.h (struct tui_source_window) <fullname>: New
2709         member.
2710         * tui/tui-source.c (tui_source_window::set_contents): Update.
2711         (tui_source_window::location_matches_p)
2712         (tui_source_window::maybe_update): Update.
2713
2714 2019-09-20  Tom Tromey  <tom@tromey.com>
2715
2716         * tui/tui-winsource.h (~tui_source_element): Remove.
2717         (tui_source_element): Update.
2718         (struct tui_source_element) <line>: Now a unique_xmalloc_ptr.
2719         * tui/tui-winsource.c (tui_show_source_line): Update.
2720         * tui/tui-source.c (tui_source_window::set_contents): Update.
2721         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
2722
2723 2019-09-20  Tom Tromey  <tom@tromey.com>
2724
2725         * tui/tui-data.h (tui_clear_source_windows_detail): Don't
2726         declare.
2727         * tui/tui-layout.c (tui_add_win_to_layout): Don't call
2728         tui_clear_source_windows_detail.
2729         * tui/tui-winsource.h (struct tui_source_window_base)
2730         <clear_detail>: Don't declare.
2731         * tui/tui-winsource.c (tui_source_window_base::clear_detail):
2732         Remove.
2733         * tui/tui-data.c (tui_clear_source_windows_detail): Remove.
2734
2735 2019-09-20  Tom Tromey  <tromey@adacore.com>
2736
2737         PR ada/24919:
2738         * block.c (contained_in): Fix final return value.
2739
2740 2019-09-20  Alan Modra  <amodra@gmail.com>
2741
2742         * gdb_bfd.c (gdb_bfd_ref, gdb_bfd_unref): Use bfd_set_usrdata.
2743         * dwarf2read.c (dwarf2_read_gdb_index, dwarf2_read_debug_names),
2744         (read_indirect_string_from_dwz): Use bfd accessor.
2745         * dwarf2read.h (struct dwz_file <filename>): Likewise.
2746         * machoread.c (macho_symfile_read_all_oso): Likewise.
2747         * solib.c (solib_bfd_open): Likewise.
2748
2749 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
2750
2751         * eval.c: Move declaration of overload_resolution to...
2752         * value.h: ...here.
2753
2754 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
2755
2756         * arm-linux-nat.c: Remove extern declaration for arm_apcs_32.
2757         * arm-linux-tdep.c: Likewise.
2758         * arm-nbsd-nat.c: Likewise.
2759         * arm-tdep.h: Declare arm_apcs_32.
2760         * arm-tdep.c: Move documentation for arm_apcs_32 to arm-tdep.h.
2761
2762 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
2763
2764         * dwarf2loc.c: Remove extern declaration of dwarf_always_disassemble.
2765         * dwarf2read.h: Declare dwarf_always_disassemble.
2766
2767 2019-09-19  Tom de Vries  <tdevries@suse.de>
2768
2769         PR gdb/25009
2770         * source-cache.c (source_cache::ensure): Catch exception thrown during
2771         construction of the highlighter.
2772
2773 2019-09-18  Alan Modra  <amodra@gmail.com>
2774
2775         * aarch64-linux-tdep.c, * arm-tdep.c, * auto-load.c,
2776         * coff-pe-read.c, * coffread.c, * corelow.c, * dbxread.c,
2777         * dicos-tdep.c, * dwarf2-frame.c, * dwarf2read.c, * elfread.c,
2778         * exec.c, * fbsd-tdep.c, * gcore.c, * gdb_bfd.c, * gdb_bfd.h,
2779         * hppa-tdep.c, * i386-cygwin-tdep.c, * i386-fbsd-tdep.c,
2780         * i386-linux-tdep.c, * jit.c, * linux-tdep.c, * machoread.c,
2781         * maint.c, * mdebugread.c, * minidebug.c, * mips-linux-tdep.c,
2782         * mips-sde-tdep.c, * mips-tdep.c, * mipsread.c, * nto-tdep.c,
2783         * objfiles.c, * objfiles.h, * osabi.c, * ppc-linux-tdep.c,
2784         * ppc64-tdep.c, * record-btrace.c, * record-full.c, * remote.c,
2785         * rs6000-aix-tdep.c, * rs6000-tdep.c, * s390-linux-tdep.c,
2786         * s390-tdep.c, * solib-aix.c, * solib-dsbt.c, * solib-frv.c,
2787         * solib-spu.c, * solib-svr4.c, * solib-target.c,
2788         * spu-linux-nat.c, * spu-tdep.c, * symfile-mem.c, * symfile.c,
2789         * symmisc.c, * symtab.c, * target.c, * windows-nat.c,
2790         * xcoffread.c, * cli/cli-dump.c, * compile/compile-object-load.c,
2791         * mi/mi-interp.c: Update throughout for bfd section macro and
2792         function changes.
2793         * gcore (gcore_create_callback): Use bfd_set_section_lma.
2794         * spu-tdep.c (spu_overlay_new_objfile): Likewise.
2795
2796 2019-09-18  Tom Tromey  <tom@tromey.com>
2797
2798         * NEWS: Add entry.
2799         * tui/tui.c (tui_initialize_readline): Set name of keymap.  Do not
2800         call rl_initialize.
2801         (tui_enable): Do not call rl_initialize.
2802
2803 2019-09-18  Christian Groessler  <chris@groessler.org>
2804
2805         * alpha-linux-nat.c: Include gdbarch.h.
2806
2807 2019-09-18  Simon Marchi  <simon.marchi@polymtl.ca>
2808
2809         * ui-file.c: Include cli/cli-style.h.
2810         (term_cli_styling): Remove cli_styling declaration.
2811
2812 2019-09-18  Alan Modra  <amodra@gmail.com>
2813
2814         * arm-tdep.c (arm_record_special_symbol): Update bfd_get_section
2815         to bfd_asymbol_section.
2816
2817 2019-09-18  Alan Modra  <amodra@gmail.com>
2818
2819         * amd64-dicos-tdep.c (amd64_dicos_osabi_sniffer): Constify target.
2820         * i386-cygwin-tdep.c (i386_cygwin_init_abi): Likewise.
2821         * i386-dicos-tdep.c (i386_dicos_osabi_sniffer): Likewise.
2822
2823 2019-09-18  Alan Modra  <amodra@gmail.com>
2824
2825         * solib-spu.c (spu_bfd_open): Use bfd_set_filename.
2826         * spu-linux-nat.c (spu_bfd_open): Likewise.
2827
2828 2019-09-18  Christian Biesinger  <cbiesinger@google.com>
2829
2830         * dwarf2loc.c: Change extern declaration of dwarf_always_disassemble
2831         to bool to match definition in dwarf2read.c.
2832
2833 2019-09-17  Christian Biesinger  <cbiesinger@google.com>
2834
2835         * ada-lang.c (ada_ignore_descriptive_types_p): Change to bool.
2836         (print_signatures): Likewise.
2837         (trust_pad_over_xvs): Likewise.
2838         * arch/aarch64-insn.c (aarch64_debug): Likewise.
2839         * arch/aarch64-insn.h (aarch64_debug): Likewise.
2840         * arm-linux-nat.c (arm_apcs_32): Likewise.
2841         * arm-linux-tdep.c (arm_apcs_32): Likewise.
2842         * arm-nbsd-nat.c (arm_apcs_32): Likewise.
2843         * arm-tdep.c (arm_debug): Likewise.
2844         (arm_apcs_32): Likewise.
2845         * auto-load.c (debug_auto_load): Likewise.
2846         (auto_load_gdb_scripts): Likewise.
2847         (global_auto_load): Likewise.
2848         (auto_load_local_gdbinit): Likewise.
2849         (auto_load_local_gdbinit_loaded): Likewise.
2850         * auto-load.h (global_auto_load): Likewise.
2851         (auto_load_local_gdbinit): Likewise.
2852         (auto_load_local_gdbinit_loaded): Likewise.
2853         * breakpoint.c (disconnected_dprintf): Likewise.
2854         (breakpoint_proceeded): Likewise.
2855         (automatic_hardware_breakpoints): Likewise.
2856         (always_inserted_mode): Likewise.
2857         (target_exact_watchpoints): Likewise.
2858         (_initialize_breakpoint): Update.
2859         * breakpoint.h (target_exact_watchpoints): Change to bool.
2860         * btrace.c (maint_btrace_pt_skip_pad): Likewise.
2861         * cli/cli-cmds.c (trace_commands): Likewise.
2862         * cli/cli-cmds.h (trace_commands): Likewise.
2863         * cli/cli-decode.c (add_setshow_boolean_cmd): Change int* argument
2864         to bool*.
2865         * cli/cli-logging.c (logging_overwrite): Change to bool.
2866         (logging_redirect): Likewise.
2867         (debug_redirect): Likewise.
2868         * cli/cli-option.h (option_def) <boolean>: Change return type to bool*.
2869         (struct boolean_option_def) <get_var_address_cb_>: Change return type
2870         to bool.
2871         <boolean_option_def>: Update.
2872         (struct flag_option_def): Change default type of Context to bool
2873         from int.
2874         <flag_option_def>: Change return type of var_address_cb_ to bool*.
2875         * cli/cli-setshow.c (do_set_command): Cast to bool* instead of int*.
2876         (get_setshow_command_value_string): Likewise.
2877         * cli/cli-style.c (cli_styling): Change to bool.
2878         (source_styling): Likewise.
2879         * cli/cli-style.h (source_styling): Likewise.
2880         (cli_styling): Likewise.
2881         * cli/cli-utils.h (struct qcs_flags) <quiet, cont, silent>: Change
2882         to bool.
2883         * command.h (var_types): Update comment.
2884         (add_setshow_boolean_cmd): Change int* var argument to bool*.
2885         * compile/compile-cplus-types.c (debug_compile_cplus_types): Change to
2886         bool.
2887         (debug_compile_cplus_scopes): Likewise.
2888         * compile/compile-internal.h (compile_debug): Likewise.
2889         * compile/compile.c (compile_debug): Likewise.
2890         (struct compile_options) <raw>: Likewise.
2891         * cp-support.c (catch_demangler_crashes): Likewise.
2892         * cris-tdep.c (usr_cmd_cris_version_valid): Likewise.
2893         (usr_cmd_cris_dwarf2_cfi): Likewise.
2894         * csky-tdep.c (csky_debug): Likewise.
2895         * darwin-nat.c (enable_mach_exceptions): Likewise.
2896         * dcache.c (dcache_enabled_p): Likewise.
2897         * defs.h (info_verbose): Likewise.
2898         * demangle.c (demangle): Likewise.
2899         (asm_demangle): Likewise.
2900         * dwarf-index-cache.c (debug_index_cache): Likewise.
2901         * dwarf2-frame.c (dwarf2_frame_unwinders_enabled_p): Likewise.
2902         * dwarf2-frame.h (dwarf2_frame_unwinders_enabled_p): Likewise.
2903         * dwarf2read.c (check_physname): Likewise.
2904         (use_deprecated_index_sections): Likewise.
2905         (dwarf_always_disassemble): Likewise.
2906         * eval.c (overload_resolution): Likewise.
2907         * event-top.c (set_editing_cmd_var): Likewise.
2908         (exec_done_display_p): Likewise.
2909         * event-top.h (set_editing_cmd_var): Likewise.
2910         (exec_done_display_p): Likewise.
2911         * exec.c (write_files): Likewise.
2912         * fbsd-nat.c (debug_fbsd_lwp): Likewise
2913         (debug_fbsd_nat): Likewise.
2914         * frame.h (struct frame_print_options) <print_raw_frame_arguments>:
2915         Likewise.
2916         (struct set_backtrace_options) <backtrace_past_main>: Likewise.
2917         <backtrace_past_entry> Likewise.
2918         * gdb-demangle.h (demangle): Likewise.
2919         (asm_demangle): Likewise.
2920         * gdb_bfd.c (bfd_sharing): Likewise.
2921         * gdbcore.h (write_files): Likewise.
2922         * gdbsupport/common-debug.c (show_debug_regs): Likewise.
2923         * gdbsupport/common-debug.h (show_debug_regs): Likewise.
2924         * gdbthread.h (print_thread_events): Likewise.
2925         * gdbtypes.c (opaque_type_resolution): Likewise.
2926         (strict_type_checking): Likewise.
2927         * gnu-nat.c (gnu_debug_flag): Likewise.
2928         * guile/scm-auto-load.c (auto_load_guile_scripts): Likewise.
2929         * guile/scm-param.c (pascm_variable): Add boolval.
2930         (add_setshow_generic): Update.
2931         (pascm_param_value): Update.
2932         (pascm_set_param_value_x): Update.
2933         * hppa-tdep.c (hppa_debug): Change to bool..
2934         * infcall.c (may_call_functions_p): Likewise.
2935         (coerce_float_to_double_p): Likewise.
2936         (unwind_on_signal_p): Likewise.
2937         (unwind_on_terminating_exception_p): Likewise.
2938         * infcmd.c (startup_with_shell): Likewise.
2939         * inferior.c (print_inferior_events): Likewise.
2940         * inferior.h (startup_with_shell): Likewise.
2941         (print_inferior_events): Likewise.
2942         * infrun.c (step_stop_if_no_debug): Likewise.
2943         (detach_fork): Likewise.
2944         (debug_displaced): Likewise.
2945         (disable_randomization): Likewise.
2946         (non_stop): Likewise.
2947         (non_stop_1): Likewise.
2948         (observer_mode): Likewise.
2949         (observer_mode_1): Likewise.
2950         (set_observer_mode): Update.
2951         (sched_multi): Change to bool.
2952         * infrun.h (debug_displaced): Likewise.
2953         (sched_multi): Likewise.
2954         (step_stop_if_no_debug): Likewise.
2955         (non_stop): Likewise.
2956         (disable_randomization): Likewise.
2957         * linux-tdep.c (use_coredump_filter): Likewise.
2958         (dump_excluded_mappings): Likewise.
2959         * linux-thread-db.c (auto_load_thread_db): Likewise.
2960         (check_thread_db_on_load): Likewise.
2961         * main.c (captured_main_1): Update.
2962         * maint-test-options.c (struct test_options_opts) <flag_opt, xx1_opt,
2963         xx2_opt, boolean_opt>: Change to bool.
2964         * maint-test-settings.c (maintenance_test_settings_boolean): Likewise.
2965         * maint.c (maintenance_profile_p): Likewise.
2966         (per_command_time): Likewise.
2967         (per_command_space): Likewise.
2968         (per_command_symtab): Likewise.
2969         * memattr.c (inaccessible_by_default): Likewise.
2970         * mi/mi-main.c (mi_async): Likewise.
2971         (mi_async_1): Likewise.
2972         * mips-tdep.c (mips64_transfers_32bit_regs_p): Likewise.
2973         * nat/fork-inferior.h (startup_with_shell): Likewise.
2974         * nat/linux-namespaces.c (debug_linux_namespaces): Likewise.
2975         * nat/linux-namespaces.h (debug_linux_namespaces): Likewise.
2976         * nios2-tdep.c (nios2_debug): Likewise.
2977         * or1k-tdep.c (or1k_debug): Likewise.
2978         * parse.c (parser_debug): Likewise.
2979         * parser-defs.h (parser_debug): Likewise.
2980         * printcmd.c (print_symbol_filename): Likewise.
2981         * proc-api.c (procfs_trace): Likewise.
2982         * python/py-auto-load.c (auto_load_python_scripts): Likewise.
2983         * python/py-param.c (union parmpy_variable): Add "bool boolval" field.
2984         (set_parameter_value): Update.
2985         (add_setshow_generic): Update.
2986         * python/py-value.c (copy_py_bool_obj): Change argument from int*
2987         to bool*.
2988         * python/python.c (gdbpy_parameter_value): Cast to bool* instead of
2989         int*.
2990         * ravenscar-thread.c (ravenscar_task_support): Change to bool.
2991         * record-btrace.c (record_btrace_target::store_registers): Update.
2992         * record-full.c (record_full_memory_query): Change to bool.
2993         (record_full_stop_at_limit): Likewise.
2994         * record-full.h (record_full_memory_query): Likewise.
2995         * remote-notif.c (notif_debug): Likewise.
2996         * remote-notif.h (notif_debug): Likewise.
2997         * remote.c (use_range_stepping): Likewise.
2998         (interrupt_on_connect): Likewise.
2999         (remote_break): Likewise.
3000         * ser-tcp.c (tcp_auto_retry): Likewise.
3001         * ser-unix.c (serial_hwflow): Likewise.
3002         * skip.c (debug_skip): Likewise.
3003         * solib-aix.c (solib_aix_debug): Likewise.
3004         * spu-tdep.c (spu_stop_on_load_p): Likewise.
3005         (spu_auto_flush_cache_p): Likewise.
3006         * stack.c (struct backtrace_cmd_options) <full, no_filters, hide>:
3007         Likewise.
3008         (struct info_print_options) <quiet>: Likewise.
3009         * symfile-debug.c (debug_symfile): Likewise.
3010         * symfile.c (auto_solib_add): Likewise.
3011         (separate_debug_file_debug): Likewise.
3012         * symfile.h (auto_solib_add): Likewise.
3013         (separate_debug_file_debug): Likewise.
3014         * symtab.c (basenames_may_differ): Likewise.
3015         (struct filename_partial_match_opts) <dirname, basename>: Likewise.
3016         (struct info_print_options) <quiet, exclude_minsyms>: Likewise.
3017         (struct info_types_options) <quiet>: Likewise.
3018         * symtab.h (demangle): Likewise.
3019         (basenames_may_differ): Likewise.
3020         * target-dcache.c (stack_cache_enabled_1): Likewise.
3021         (code_cache_enabled_1): Likewise.
3022         * target.c (trust_readonly): Likewise.
3023         (may_write_registers): Likewise.
3024         (may_write_memory): Likewise.
3025         (may_insert_breakpoints): Likewise.
3026         (may_insert_tracepoints): Likewise.
3027         (may_insert_fast_tracepoints): Likewise.
3028         (may_stop): Likewise.
3029         (auto_connect_native_target): Likewise.
3030         (target_stop_and_wait): Update.
3031         (target_async_permitted): Change to bool.
3032         (target_async_permitted_1): Likewise.
3033         (may_write_registers_1): Likewise.
3034         (may_write_memory_1): Likewise.
3035         (may_insert_breakpoints_1): Likewise.
3036         (may_insert_tracepoints_1): Likewise.
3037         (may_insert_fast_tracepoints_1): Likewise.
3038         (may_stop_1): Likewise.
3039         * target.h (target_async_permitted): Likewise.
3040         (may_write_registers): Likewise.
3041         (may_write_memory): Likewise.
3042         (may_insert_breakpoints): Likewise.
3043         (may_insert_tracepoints): Likewise.
3044         (may_insert_fast_tracepoints): Likewise.
3045         (may_stop): Likewise.
3046         * thread.c (struct info_threads_opts) <show_global_ids>: Likewise.
3047         (make_thread_apply_all_options_def_group): Change argument from int*
3048         to bool*.
3049         (thread_apply_all_command): Update.
3050         (print_thread_events): Change to bool.
3051         * top.c (confirm): Likewise.
3052         (command_editing_p): Likewise.
3053         (history_expansion_p): Likewise.
3054         (write_history_p): Likewise.
3055         (info_verbose): Likewise.
3056         * top.h (confirm): Likewise.
3057         (history_expansion_p): Likewise.
3058         * tracepoint.c (disconnected_tracing): Likewise.
3059         (circular_trace_buffer): Likewise.
3060         * typeprint.c (print_methods): Likewise.
3061         (print_typedefs): Likewise.
3062         * utils.c (debug_timestamp): Likewise.
3063         (sevenbit_strings): Likewise.
3064         (pagination_enabled): Likewise.
3065         * utils.h (sevenbit_strings): Likewise.
3066         (pagination_enabled): Likewise.
3067         * valops.c (overload_resolution): Likewise.
3068         * valprint.h (struct value_print_options) <prettyformat_arrays,
3069         prettyformat_structs, vtblprint, unionprint, addressprint, objectprint,
3070         stop_print_at_null, print_array_indexes, deref_ref, static_field_print,
3071         pascal_static_field_print, raw, summary, symbol_print, finish_print>:
3072         Likewise.
3073         * windows-nat.c (new_console): Likewise.
3074         (cygwin_exceptions): Likewise.
3075         (new_group): Likewise.
3076         (debug_exec): Likewise.
3077         (debug_events): Likewise.
3078         (debug_memory): Likewise.
3079         (debug_exceptions): Likewise.
3080         (useshell): Likewise.
3081         * windows-tdep.c (maint_display_all_tib): Likewise.
3082         * xml-support.c (debug_xml): Likewise.
3083
3084 2019-09-17  Mike Gulick  <mgulick@mathworks.com>
3085
3086         * source.c (prepare_path_for_appending): New function.
3087         (openp): Make use of new function.
3088         (find_and_open_source): Search for the compilation directory and
3089         source file as a relative path beneath the directory search path.
3090
3091 2019-09-17  Andrew Burgess  <andrew.burgess@embecosm.com>
3092
3093         * source-cache.c (source_cache::get_line_charpos): Catch
3094         exceptions and return false, this matches the behaviour documented
3095         in the header file.
3096
3097 2019-09-17  Joel Brobecker  <brobecker@adacore.com>
3098
3099         * ada-tasks.c (info_task): Remove quoting of the task's name.
3100
3101 2019-09-16  Christian Biesinger  <cbiesinger@google.com>
3102
3103         * symfile.c (auto_solib_add): Replace comment with a reference
3104         to the header file.
3105
3106 2019-09-14  Christian Biesinger  <cbiesinger@google.com>
3107
3108         * NEWS: Mention that gdb can now be compiled with Python 3
3109         on Windows.
3110
3111 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3112
3113         * maint.c (maint_print_section_data::maint_print_section_data):
3114         Force use of 'float log10 (float)' by casting the argument to
3115         float.
3116
3117 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3118
3119         * maint.c: Add 'cmath' include.
3120         (struct maint_print_section_data): New structure.
3121         (print_section_index): New function.
3122         (print_bfd_section_info): Add header comment, small whitespace
3123         cleanup, and update to call new print_section_index function.
3124         (print_objfile_section_info): Likewise.
3125         (maint_obj_section_from_bfd_section): New function.
3126         (print_bfd_section_info_maybe_relocated): New function.
3127         (maintenance_info_sections): Add header comment, always use
3128         bfd_map_over_sections instead of ALL_OBJFILE_OSECTIONS.
3129
3130 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3131
3132         * psymtab.c (find_pc_sect_psymtab): Move baseaddr local into more
3133         inner scope, add check that the objfile has psymtabs before
3134         checking psymtabs_addrmap.
3135         * psymtab.h (psymtab_storage) <psymtabs_addrmap>: Extend comment.
3136
3137 2019-09-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3138
3139         * NEWS: Announce that Ada task names are now shown at more places,
3140         and between quotes (except in info task output).
3141         * gdb/ada-tasks.c (task_to_str): New function.
3142         (display_current_task_id): Call task_to_str.
3143         (task_command_1): Likewise.
3144         (print_ada_task_info): In non-mi mode, Properly align headers and data
3145         when task-id length is > 9 (9 is the default for a 32 bits CORE_ADDR).
3146
3147 2019-09-12  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
3148
3149         * procfs.c (procfs_target::wait) <PR_FAULTED>: Get signal from
3150         prstatus.pr_lwp.pr_info instead of making it up.
3151
3152 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
3153
3154         * auto-load.c (auto_load_expand_dir_vars): Update.
3155         * defs.h (gdb_datadir): Change to std::string.
3156         (python_libdir): Likewise.
3157         (relocate_gdb_directory): Change return type to std::string.
3158         * guile/guile.c (gdbscm_data_directory): Update.
3159         (initialize_scheme_side): Update.
3160         * jit.c (jit_reader_dir): Change to std::string.
3161         (jit_reader_load_command): Update.
3162         * main.c (gdb_datadir): Change to std::string.
3163         (python_libdir): Likewise.
3164         (set_gdb_data_directory): Update.
3165         (relocate_path): Change to return std::string.
3166         (relocate_gdb_directory): Change to return std::string.
3167         (relocate_gdbinit_path_maybe_in_datadir): Update.
3168         (captured_main_1): Update.
3169         * python/python.c (do_start_initialization): Update.
3170         * top.c (show_gdb_datadir): Update.
3171         * xml-syscall.c (xml_init_syscalls_info): Update.
3172         (init_syscalls_info): Update.
3173
3174 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
3175
3176         * main.c (relocate_gdbinit_path_maybe_in_datadir): Factor this code
3177         out of get_init_files.
3178         (get_init_files): Update.
3179
3180 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
3181
3182         * main.c (get_init_files): Change to use std::string.
3183         (captured_main_1): Update.
3184         (print_gdb_help): Update.
3185
3186 2019-09-11  Ali Tamur  <tamur@google.com>
3187
3188         *gdb/target-float.c (host_float_ops<T>::to_longest): Update
3189         implementation.
3190
3191 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
3192
3193         * dbxread.c (read_dbx_symtab): Update.
3194         * dwarf2read.c (load_partial_dies): Update.
3195         * mdebugread.c (parse_partial_symbols): Update.
3196         (handle_psymbol_enumerators): Update.
3197         * psympriv.h (add_psymbol_to_list): Change type of copy_names to bool.
3198         * psymtab.c (add_psymbol_to_bcache): Likewise.
3199         (add_psymbol_to_list): Likewise.
3200         * symtab.c (symbol_set_names): Likewise.
3201         * symtab.h (symbol_set_names): Likewise.
3202         * xcoffread.c (scan_xcoff_symtab): Update.
3203
3204 2019-09-11  Tom Tromey  <tom@tromey.com>
3205
3206         * symfile-mem.c (symbol_file_add_from_memory): Use
3207         bfd_set_filename.
3208         * solib-darwin.c (darwin_bfd_open): Use bfd_set_filename.
3209         * solib-aix.c (solib_aix_bfd_open): Use bfd_set_filename.
3210
3211 2019-09-10  Tom Tromey  <tromey@adacore.com>
3212
3213         * dwarf-index-write.c (write_psymbols): Extend error message.
3214         (debug_names::insert): Add Ada code.
3215         (debug_names::write_psymbols): Remove Ada check.
3216         (debug_names) <m_string_obstack>: New member.
3217         * dwarf2read.c (gdb_index_symbol_name_matcher): Remove.
3218         (gdb_index_symbol_name_matcher::matches): Remove.
3219         (mapped_index_base::find_name_components_bounds): Add "lang"
3220         parameter.
3221         (mapped_index_base::build_name_components): Also split names
3222         according to Ada syntax.
3223         (dw2_expand_symtabs_matching_symbol): Loop over languages.  Change
3224         type of "match_callback".
3225         (check_match, check_find_bounds_finds)
3226         (dw2_expand_symtabs_matching): Update.
3227         (dw2_debug_names_iterator): Add new constructor.
3228         (dw2_debug_names_map_matching_symbols): New function.
3229         (dw2_debug_names_expand_symtabs_matching): Update.
3230         (dwarf2_debug_names_functions): Use
3231         dw2_debug_names_map_matching_symbols.
3232
3233 2019-09-10  Tom Tromey  <tromey@adacore.com>
3234
3235         * dwarf2read.c (dw2_get_file_names_reader): Add the
3236         CU's file name to the results.
3237
3238 2019-09-10  Tom Tromey  <tromey@adacore.com>
3239
3240         * ada-lang.c (add_nonlocal_symbols): Combine calls to
3241         map_matching_symbols.  Update.
3242         * dwarf2read.c (dw2_map_matching_symbols): Update.
3243         * psymtab.c (match_partial_symbol): Change type; update.
3244         (psym_map_matching_symbols): Likewise.
3245         * symfile-debug.c (debug_qf_map_matching_symbols): Change
3246         type; update.
3247         * symfile.h (struct quick_symbol_functions)
3248         <map_matching_symbols>: Change "name" to be a lookup_name_info.
3249         Remove "match".
3250
3251 2019-09-10  Tom Tromey  <tromey@adacore.com>
3252
3253         * psymtab.c (map_block): Remove.
3254         (psym_map_matching_symbols): Use iterate_over_symbols_terminated.
3255         * symtab.c (iterate_over_symbols_terminated): New function.
3256         * symtab.c (iterate_over_symbols_terminated): Declare.
3257
3258 2019-09-10  Tom Tromey  <tromey@adacore.com>
3259
3260         * ada-lang.c (ada_iterate_over_symbols): Return bool.
3261         * language.h (struct language_defn) <la_iterate_over_symbols>:
3262         Return bool.
3263         * symtab.c (iterate_over_symbols): Return bool.
3264         * symtab.h (iterate_over_symbols): Return bool.
3265
3266 2019-09-10  Tom Tromey  <tromey@adacore.com>
3267
3268         * ada-lang.c (aux_add_nonlocal_symbols): Change type.
3269         (add_nonlocal_symbols): Update.
3270         * dwarf2read.c (dw2_map_matching_symbols): Change type.
3271         * psymtab.c (map_block, psym_map_matching_symbols): Change type.
3272         * symfile-debug.c (debug_qf_map_matching_symbols): Change type.
3273         * symfile.h (struct quick_symbol_functions) <map_matching_symbols>:
3274         Change type of "callback".  Remove "data".
3275
3276
3277 2019-09-09  Ali Tamur  <tamur@google.com>
3278
3279         * dwarf2read.c (comp_unit_head): Update comment.
3280         (dwarf2_dwo_name): New function declaration.
3281         (dwarf_unit_type_name): New function declaration.
3282         (read_comp_unit_head): Add support for new compilation units,
3283         DW_UT_partial, DW_UT_skeleton, DW_UT_split_compile, DW_UT_split_type.
3284         Particularly, DW_UT_skeleton and DW_UT_split_compile have dwo_id
3285         (currently named as "signature") in their header. Also clarify error
3286         messages.
3287         (lookup_dwo_id): New function. Returns the dwo id of the given
3288         compile unit.
3289         (lookup_dwo_unit): Use the new lookup_dwo_id function.
3290         (init_cutu_and_read_dies): Use the new dwarf2_dwo_name and lookup_dwo_id
3291         functions.
3292         (create_dwo_cu_reader): Use the added lookup_dwo_id function.
3293         (dwarf2_dwo_name): Get the dwo name if present.
3294         (dwarf_unit_type_name): Convert DW_UT_* types to string for diagnostic
3295         purposes.
3296
3297 2019-09-09  Tom Tromey  <tom@tromey.com>
3298
3299         * tui/tui-win.c (tui_all_windows_info): Use ui_out.
3300
3301 2019-09-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3302
3303         * python/python.c (do_start_initialization): Make progname_copy static,
3304         to avoid a leak report.
3305
3306 2019-09-08  Tom Tromey  <tom@tromey.com>
3307
3308         * tui/tui-wingeneral.c (box_win): Truncate long window titles.
3309
3310 2019-09-07  Simon Marchi  <simon.marchi@efficios.com>
3311
3312         * dwarf2read.c (struct dw2_symtab_iterator) <block_index>:
3313         Change type to gdb::optional<block_enum>.
3314         (dw2_symtab_iter_init): Change block_index parameter type
3315         to gdb::optional<block_enum>.
3316         (dw2_lookup_symbol): Change block_index parameter
3317         type to block_enum.c
3318         (dw2_debug_names_lookup_symbol): Likewise.
3319         * psymtab.c (psym_lookup_symbol): Likewise.
3320         * symfile-debug.c (debug_qf_lookup_symbol): Likewise.
3321         * symfile.h (struct quick_symbol_functions) <lookup_symbol>:
3322         Likewise.
3323
3324 2019-09-06  Christian Biesinger  <cbiesinger@google.com>
3325
3326         * defs.h (relocate_gdb_directory): Change int to bool in
3327         signature and rename flag to relocatable.
3328         * main.c (relocate_path): Likewise.
3329         (relocate_gdb_directory): Likewise.
3330
3331 2019-09-06  Alan Modra  <amodra@gmail.com>
3332
3333         * coffread.c (coff_symfile_read): Constify filename variable.
3334         * dbxread.c (dbx_symfile_init, coffstab_build_psymtabs),
3335         (elfstab_build_psymtabs, stabsect_build_psymtabs): Likewise.
3336         * gdb_bfd.c (gdb_bfd_close_or_warn): Likewise.
3337         * solib.c (reload_shared_libraries_1): Likewise.
3338         * symfile.c (reread_symbols): Likewise.
3339         * solib-aix.c (solib_aix_bfd_open): Add cast for xfree of filename.
3340         * solib-darwin.c (darwin_bfd_open): Likewise.
3341         * symfile-mem.c (symbol_file_add_from_memory): Likewise.
3342
3343 2019-09-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3344
3345         * psymtab.c (print_partial_symbols): Handle missing domain_enum
3346         values MODULE_DOMAIN and COMMON_BLOCK_DOMAIN.
3347
3348 2019-09-03  Tom Tromey  <tromey@adacore.com>
3349
3350         * ada-valprint.c (ada_val_print_num): Don't recurse for range
3351         types.
3352         (has_negatives): Unbias a range type bound.
3353         * dwarf2read.c (read_subrange_type): Handle DW_AT_GNU_bias.
3354         * gdbtypes.c (operator==): Handle new field.
3355         (create_range_type): Add "bias" parameter.
3356         (create_static_range_type, resolve_dynamic_range): Update.
3357         * gdbtypes.h (struct range_bounds) <bias>: New member.
3358         (create_range_type): Add bias parameter.
3359         * printcmd.c (print_scalar_formatted): Unbias range types.
3360         * value.c (unpack_long): Unbias range types.
3361         (pack_long): Bias range types.
3362
3363 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
3364
3365         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Check all
3366         probe arguments.
3367
3368 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
3369
3370         * break-catch-throw.c (fetch_probe_arguments): Use gdbarch.
3371         * dtrace-probe.c (dtrace_probe::get_argument_count): Likewise.
3372         * probe.c (probe_safe_evaluate_at_pc) (compute_probe_arg)
3373         (compile_probe_arg): Likewise.
3374         * probe.h (get_argument_count): Likewise.
3375         * solib-svr4.c (solib_event_probe_action): Likewise.
3376         * stap-probe.c (stap_probe::get_argument_count): Likewise.
3377
3378 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
3379
3380         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Move
3381         code to here...
3382         (svr4_create_solib_event_breakpoints): ...from here.
3383
3384 2019-08-30  Sergio Durigan Junior  <sergiodj@redhat.com>
3385
3386         * nat/fork-inferior.c (trace_start_error): Remove "\nError: "
3387         suffix from warning message.
3388
3389 2019-08-30  Tom Tromey  <tom@tromey.com>
3390
3391         * tui/tui-winsource.h (struct tui_source_window_base)
3392         <refresh_all>: Don't declare.
3393         * tui/tui-winsource.c (tui_source_window_base::refresh_all):
3394         Remove.
3395         * tui/tui-win.c (tui_refresh_all_win): Don't call refresh_all or
3396         tui_show_locator_content.
3397         * tui/tui-regs.h (struct tui_data_window) <refresh_all>: Don't
3398         declare.
3399         * tui/tui-regs.c (tui_data_window::refresh_all): Remove.
3400         * tui/tui-data.h (struct tui_win_info) <refresh_all>: Don't
3401         declare.
3402
3403 2019-08-30  Tom Tromey  <tom@tromey.com>
3404
3405         * tui/tui-io.c (tui_cont_sig): Don't call wrefresh.
3406
3407 2019-08-30  Tom Tromey  <tom@tromey.com>
3408
3409         * tui/tui-stack.c (_initialize_tui_stack): Move later.
3410         Remove unnecessary forward declarations.
3411
3412 2019-08-30  Tom Tromey  <tom@tromey.com>
3413
3414         * tui/tui-stack.c (tui_locator_window::set_locator_fullname): Call
3415         rerender.
3416         (tui_update_locator_fullname, tui_show_frame_info): Don't call
3417         tui_show_locator_content.
3418
3419 2019-08-30  Tom Tromey  <tom@tromey.com>
3420
3421         * tui/tui-stack.c (tui_show_locator_content): Move lower.  Rewrite.
3422         (tui_locator_window::rerender): Rewrite using body of previous
3423         tui_show_locator_content.
3424
3425 2019-08-30  Tom Tromey  <tom@tromey.com>
3426
3427         * tui/tui-stack.h (struct tui_locator_window) <set_locator_info,
3428         set_locator_fullname>: New methods.
3429         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
3430         Rename from tui_set_locator_fullname.
3431         (tui_locator_window::set_locator_info): Rename from
3432         tui_set_locator_info.  Return bool.
3433         (tui_update_locator_fullname, tui_show_frame_info): Update.
3434
3435 2019-08-30  Tom Tromey  <tom@tromey.com>
3436
3437         * tui/tui-layout.c (show_layout): Don't call tui_refresh_all.
3438
3439 2019-08-30  Tom Tromey  <tom@tromey.com>
3440
3441         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Don't
3442         call touchwin.
3443
3444 2019-08-30  Tom Tromey  <tom@tromey.com>
3445
3446         * tui/tui-wingeneral.c (box_win): Assume win_info and
3447         win_info->handle cannot be NULL.
3448
3449 2019-08-30  Tom Tromey  <tom@tromey.com>
3450
3451         * tui/tui-regs.h (struct tui_data_item_window) <rerender,
3452         refresh_window>: Declare.
3453         * tui/tui-regs.c (tui_data_window::display_registers_from): Call
3454         resize.
3455         (tui_data_item_window::rerender): Rename from
3456         tui_display_register.
3457         (tui_data_item_window::refresh_window): New method.
3458         * tui/tui-layout.c (tui_gen_win_info::resize): Do nothing on
3459         no-op.
3460
3461 2019-08-30  Tom Tromey  <tom@tromey.com>
3462
3463         * tui/tui-regs.h (struct tui_data_window) <regs_content,
3464         regs_column_count, current_group>: Move later.  Now private.
3465         <get_current_group>: New method.
3466         * tui/tui-regs.c (tui_reg_command): Update.
3467         * tui/tui-layout.c (tui_set_layout): Update.
3468
3469 2019-08-30  Tom Tromey  <tom@tromey.com>
3470
3471         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
3472         (tui_data_window::rerender): Don't call
3473         check_and_display_highlight_if_needed.
3474         (tui_data_window::refresh_all): Remove call to
3475         erase_data_content.
3476
3477 2019-08-30  Tom Tromey  <tom@tromey.com>
3478
3479         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
3480         (tui_data_window::display_registers_from)
3481         (tui_data_window::display_reg_element_at_line)
3482         (tui_data_window::display_registers_from_line): Remove checks of
3483         "empty".
3484
3485 2019-08-30  Tom Tromey  <tom@tromey.com>
3486
3487         * tui/tui-regs.h (struct tui_data_window) <display_all_data>:
3488         Don't declare.
3489         * tui/tui-regs.c (tui_data_window::show_registers): Call
3490         rerender.
3491         (tui_data_window::rerender): Rename from display_all_data.
3492         (tui_data_window::rerender): Remove old implementation.
3493
3494 2019-08-30  Tom Tromey  <tom@tromey.com>
3495
3496         * tui/tui-regs.c (tui_data_window::display_all_data): Change
3497         text.
3498         * tui/tui-data.h (NO_DATA_STRING): Remove define.
3499
3500 2019-08-29  Bernhard Wodok  <barto@gmx.net>
3501             Sergio Durigan Junior  <sergiodj@redhat.com>
3502
3503         PR win32/24284
3504         * mingw-hdep.c (gdb_select): Handle case when 'n' is zero.
3505
3506 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
3507
3508         * symtab.c (search_symbols): Don't include MODULE_DOMAIN symbols
3509         when searching for types.
3510
3511 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
3512
3513         * f-lang.c (f_language_defn): Use f_print_typedef.
3514         * f-lang.h (f_print_typedef): Declare.
3515         * f-typeprint.c (f_print_typedef): Define.
3516
3517 2019-08-27  Christian Biesinger  <cbiesinger@google.com>
3518
3519         * nat/linux-namespaces.c (mnsh_main): Initialize fd (to -1).
3520
3521 2019-08-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3522
3523         * cli/cli-utils.c (info_print_options_defs): Delete.
3524         (make_info_print_options_def_group): Delete.
3525         (extract_info_print_options): Delete.
3526         (info_print_command_completer): Delete.
3527         (info_print_args_help): Add extra parameter, and optionally
3528         include text about -n flag.
3529         * cli/cli-utils.h (struct info_print_options): Delete.
3530         (extract_info_print_options): Delete declaration.
3531         (info_print_command_completer): Delete declaration.
3532         (info_print_args_help): Add extra parameter, extend header
3533         comment.
3534         * python/python.c (gdbpy_rbreak): Pass additional parameter to
3535         search_symbols.
3536         * stack.c (struct info_print_options): New type.
3537         (info_print_options_defs): New file scoped variable.
3538         (make_info_print_options_def_group): New static function.
3539         (info_print_command_completer): New static function.
3540         (info_locals_command): Update to use new local functions.
3541         (info_args_command): Likewise.
3542         (_initialize_stack): Add extra parameter to calls to
3543         info_print_args_help.
3544         * symtab.c (search_symbols): Add extra parameter, use this to
3545         possibly excluse non-debug symbols.
3546         (symtab_symbol_info): Add extra parameter, which is passed on to
3547         search_symbols.
3548         (struct info_print_options): New type.
3549         (info_print_options_defs): New file scoped variable.
3550         (make_info_print_options_def_group): New static function.
3551         (info_print_command_completer): New static function.
3552         (info_variables_command): Update to use local functions, and pass
3553         extra parameter through to symtab_symbol_info.
3554         (info_functions_command): Likewise.
3555         (info_types_command): Pass additional argument through to
3556         symtab_symbol_info.
3557         (rbreak_command): Pass extra argument to search_symbols.
3558         (_initialize_symtab): Add extra arguments for calls to
3559         info_print_args_help, and update help text for 'info variables',
3560         'whereis', and 'info functions' commands.
3561         * symtab.h (search_symbols): Add extra argument to declaration.
3562         * NEWS: Mention new flags.
3563
3564 2019-08-26  Christian Biesinger  <cbiesinger@google.com>
3565
3566         * symtab.c (lookup_static_symbol): Call the new function (and move
3567         it down to be next to lookup_global_symbol).
3568         (struct global_sym_lookup_data): Add block_enum member and rename to...
3569         (struct global_or_static_sym_lookup_data): ...this.
3570         (lookup_symbol_global_iterator_cb): Pass block_index instead of
3571         GLOBAL_BLOCK to lookup_symbol_in_objfile and rename to...
3572         (lookup_symbol_global_or_static_iterator_cb): ...this.
3573         (lookup_global_or_static_symbol): New function.
3574         (lookup_global_symbol): Call new function.
3575
3576 2019-08-26  Tom de Vries  <tdevries@suse.de>
3577
3578         PR c++/24852
3579         * break-catch-throw.c (fetch_probe_arguments): Improve error mesage
3580         when pc_probe.prob == NULL.
3581
3582 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
3583
3584         * dwarf2read.c (dw2_debug_names_iterator::next): Rename local
3585         variable symbol_linkage to symbol_linkage_.
3586
3587 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
3588
3589         * dwarf2read.c (dw2_debug_names_iterator::next): Use enum to
3590         represent whether the symbol is static, dynamic, or we don't
3591         know.
3592
3593 2019-08-25  Yoshinori Sato <ysato@users.sourceforge.jp>
3594
3595         * gdb/rx-tdep.c (rx_register_names): New.
3596         (rx_register_name): Delete.
3597         (rx_psw_type): Delete.
3598         (rx_fpsw_type): Delete.
3599         (rx_register_type): Delete.
3600         (rx_gdbarch_init): Convert target-descriptions.
3601         (_initialize_rx_tdep): Add initialize_tdesc_rx.
3602         * gdb/features/Makefile: Add rx.xml.
3603         * gdb/features/rx.xml: New.
3604         * gdb/features/rx.c: Generated.
3605         * gdb/NEWS: Mention target description support.
3606
3607 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
3608
3609         * symtab.c (symbol_cache_lookup): Always initialize *bsc_ptr and
3610         *slot_ptr.
3611
3612 2019-08-23  Sergio Durigan Junior  <sergiodj@redhat.com>
3613
3614         * configure.ac: Don't check for 'dlfcn.h' (moved to
3615         gdbsupport/common.m4).
3616         * Makefile.in (COMMON_SFILES): Move 'gdb-dlfcn.c' to
3617         'gdbsupport/'.
3618         (HFILES_NO_SRCDIR): Likewise, for 'gdb-dlfcn.h'.
3619         * compile/compile-c-support.c: Include
3620         'gdbsupport/gdb-dlfcn.h'.
3621         * gdbsupport/common.m4: Check for 'dlfcn.h'.
3622         * gdb-dlfcn.c: Move to...
3623         * gdbsupport/gdb-dlfcn.c: ... here.
3624         * gdb-dlfcn.h: Move to...
3625         * gdbsupport/gdb-dlfcn.h: ... here.
3626
3627 2019-08-23  Sandra Loosemore  <sandra@codesourcery.com>
3628
3629         * nios2-tdep.c (struct reg_value): Improve comments.  Make
3630         the offset field signed.
3631
3632 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
3633
3634         * python/lib/gdb/__init__.py (_execute_file): New function.
3635         * python/python.c (python_run_simple_file): Call gdb._execute_file
3636         on Windows.
3637
3638 2019-08-22  Andrew Burgess  <andrew.burgess@embecosm.com>
3639
3640         * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
3641         all uses as this was never set to anything but a zero value.
3642
3643 2019-08-21  Bogdan Harjoc  <harjoc@gmail.com>
3644
3645         * cli/cli-cmds.c (with_command_1): Error out if no arguments.
3646
3647 2019-08-21  Christian Biesinger  <cbiesinger@google.com>
3648
3649         * tui/tui-data.h (tui_gen_win_info): Add an =default
3650         move constructor, required by some GCC versions.
3651
3652 2019-08-21  Jinke Fan  <fanjinke51@yeah.net>
3653
3654         * go32-nat.c (go32_sysinfo): Add hygon_p.
3655
3656 2019-08-20  Tom Tromey  <tom@tromey.com>
3657
3658         * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
3659         line_from_reg_element_no, first_reg_element_no_inline,
3660         display_all_data, delete_data_content_windows,
3661         erase_data_content>: Now private.
3662
3663 2019-08-20  Tom Tromey  <tom@tromey.com>
3664
3665         * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
3666         (tui_unhighlight_win, tui_highlight_win)
3667         (tui_win_info::make_window): Update.
3668         * tui/tui-data.h (HILITE, NO_HILITE): Remove.
3669
3670 2019-08-20  Tom Tromey  <tom@tromey.com>
3671
3672         * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
3673         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
3674         (MAX_PID_WIDTH): Move to tui-stack.c.
3675         * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
3676         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
3677         (MAX_PID_WIDTH): Move from tui-data.h.
3678
3679 2019-08-20  Tom Tromey  <tom@tromey.com>
3680
3681         * tui/tui-wingeneral.h (tui_make_window): Don't declare.
3682         * tui/tui-wingeneral.c (box_win): Change type of win_info.
3683         (box_win): Update.
3684         (tui_gen_win_info::make_window): Rename from tui_make_window.
3685         (tui_win_info::make_window): New method.
3686         (tui_gen_win_info::make_visible): Update.
3687         * tui/tui-source.c (tui_source_window::set_contents): Update.
3688         * tui/tui-regs.c (tui_data_window::show_register_group): Update.
3689         (tui_data_window::display_registers_from): Update.
3690         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
3691         * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
3692         Declare.
3693         <can_box>: Remove.
3694         <title>: Remove.
3695         (struct tui_win_info) <make_window>: Declare.
3696         <can_box>: Now virtual.
3697         <title>: New member.
3698         * tui/tui-data.c (~tui_gen_win_info): Don't free title.
3699         * tui/tui-command.c (tui_cmd_window::resize): Update.
3700
3701 2019-08-20  Tom Tromey  <tom@tromey.com>
3702
3703         * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
3704         * tui/tui-regs.c (tui_data_window::show_registers): Update.
3705         (tui_data_window::check_register_values): Update.
3706
3707 2019-08-20  Tom Tromey  <tom@tromey.com>
3708
3709         * tui/tui-regs.h (struct tui_data_window): Use
3710         DISABLE_COPY_AND_ASSIGN.
3711         <regs_content>: Change type, removing unique_ptr.
3712         <tui_data_window>: Add move constructor.
3713         * tui/tui-regs.c (tui_data_window::show_registers)
3714         (tui_data_window::show_register_group)
3715         (tui_data_window::display_registers_from)
3716         (tui_data_window::display_registers_from)
3717         (tui_data_window::first_data_item_displayed)
3718         (tui_data_window::delete_data_content_windows)
3719         (tui_data_window::rerender, tui_data_window::refresh_window)
3720         (tui_data_window::check_register_values): Update.
3721
3722 2019-08-20  Tom Tromey  <tom@tromey.com>
3723
3724         * tui/tui-regs.h (struct tui_data_window) <show_registers,
3725         show_register_group>: Declare.
3726         (tui_show_register_group): Don't declare.
3727         * tui/tui-regs.c (tui_data_window::show_registers): Rename from
3728         tui_show_registers.
3729         (tui_data_window::show_register_group): Rename from
3730         tui_show_register_group.
3731         (tui_data_window::check_register_values, tui_reg_command):
3732         Update.
3733         * tui/tui-layout.c (tui_set_layout): Update.
3734
3735 2019-08-20  Tom Tromey  <tom@tromey.com>
3736
3737         * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
3738         Declare.
3739         (tui_check_register_values): Don't declare.
3740         * tui/tui-regs.c (tui_data_window::check_register_values): Rename
3741         from tui_check_register_values.
3742         * tui/tui-hooks.c (tui_register_changed): Update.
3743
3744 2019-08-20  Tom Tromey  <tom@tromey.com>
3745
3746         * tui/tui-regs.c (tui_reg_layout): Move later.
3747         (tui_show_registers): Don't enable TUI mode or change layout.
3748
3749 2019-08-20  Tom Tromey  <tom@tromey.com>
3750
3751         * tui/tui-regs.h (struct tui_data_item_window)
3752         <~tui_data_item_window>: Remove.
3753         <content>: Now a unique_xmalloc_ptr.
3754         * tui/tui-regs.c (tui_register_format): Return a
3755         unique_xmalloc_ptr.
3756         (tui_get_register): Update.
3757         (~tui_data_item_window): Remove.
3758         (tui_data_window::display_registers_from, tui_display_register):
3759         Update.
3760         * tui/tui-io.h (tui_expand_tabs): Update.
3761         * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
3762         Remove "col" parameter.
3763
3764 2019-08-20  Tom Tromey  <tom@tromey.com>
3765
3766         * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
3767         field.
3768         * tui/tui-regs.c (~tui_data_item_window): Update.
3769
3770 2019-08-20  Tom Tromey  <tom@tromey.com>
3771
3772         * tui/tui-regs.c (tui_register_format, tui_get_register): Move
3773         earlier.
3774
3775 2019-08-20  Tom Tromey  <tom@tromey.com>
3776
3777         * tui/tui-regs.c (tui_reg_command): Remove NULL check.
3778
3779 2019-08-20  Tom Tromey  <tom@tromey.com>
3780
3781         * tui/tui-source.h (struct tui_source_window): Update.
3782         * tui/tui-regs.c (tui_show_registers): Update.
3783         * tui/tui-disasm.h (struct tui_disasm_window): Update.
3784         * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
3785         (NO_REGS_STRING): Remove defines.
3786
3787 2019-08-20  Conrad Meyer  <cem@FreeBSD.org>
3788
3789         * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
3790         unnecessary thread walk if remote doesn't support the packet.
3791
3792 2019-08-19  Tom Tromey  <tromey@adacore.com>
3793
3794         * python/py-value.c (value_has_field): Fix indentation.
3795
3796 2019-08-19  Tom Tromey  <tromey@adacore.com>
3797
3798         * printcmd.c (do_one_display, info_display_command): Update.
3799         * block.h (contained_in): Return bool.  Add allow_nested
3800         parameter.
3801         * block.c (contained_in): Return bool.  Add allow_nested
3802         parameter.
3803
3804 2019-08-19  Tom Tromey  <tom@tromey.com>
3805
3806         * configure: Rebuild.
3807         * configure.ac: Disallow the combination of -static-libstdc++ and
3808         source highlight.
3809         * source-cache.c (get_language_name): Handle rust.
3810         (source_cache::get_source_lines): Ignore highlighting exceptions.
3811
3812 2019-08-16  Tom Tromey  <tom@tromey.com>
3813
3814         * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
3815         * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
3816         (struct tui_source_window_base) <make_visible, refresh_window,
3817         resize>: Remove methods.
3818         <execution_info>: Remove field.
3819         * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
3820         (tui_show_source_line, tui_source_window_base)
3821         (~tui_source_window_base): Update.
3822         (tui_source_window_base::resize)
3823         (tui_source_window_base::make_visible)
3824         (tui_source_window_base::refresh_window): Remove.
3825         (tui_source_window_base::update_exec_info): Update.
3826         * tui/tui-source.c (tui_source_window::set_contents): Update.
3827         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
3828
3829 2019-08-16  Tom Tromey  <tom@tromey.com>
3830
3831         * tui/tui-hooks.c (tui_remove_hooks): Don't set
3832         deprecated_query_hook.
3833
3834 2019-08-16  Tom Tromey  <tom@tromey.com>
3835
3836         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
3837         (tui_update_source_windows_with_line): Update.
3838         * tui/tui-source.h (struct tui_source_window)
3839         <show_symtab_source>: Declare.
3840         (tui_show_symtab_source): Don't declare.
3841         * tui/tui-source.c (tui_show_symtab_source): Rename from
3842         tui_show_symtab_source.
3843
3844 2019-08-16  Tom Tromey  <tom@tromey.com>
3845
3846         * tui/tui-winsource.h (struct tui_source_window_base)
3847         <set_contents>: Declare.
3848         * tui/tui-winsource.c
3849         (tui_source_window_base::update_source_window_as_is): Update.
3850         * tui/tui-source.h (struct tui_source_window) <set_contents>:
3851         Declare.
3852         (tui_set_source_content): Don't declare.
3853         * tui/tui-source.c (tui_source_window::set_contents): Rename from
3854         tui_set_source_content.
3855         * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
3856         Declare.
3857         (tui_set_disassem_content): Don't declare.
3858         * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
3859         tui_set_disassem_content.
3860
3861 2019-08-16  Tom Tromey  <tom@tromey.com>
3862
3863         * tui/tui-winsource.h (struct tui_source_window_base)
3864         <update_breakpoint_info>: Declare.
3865         (tui_update_breakpoint_info): Don't declare.
3866         * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
3867         (tui_update_all_breakpoint_info): Update.
3868         (tui_source_window_base::update_breakpoint_info): Rename from
3869         tui_update_breakpoint_info.
3870         (tui_source_window_base::update_exec_info): Update.
3871
3872 2019-08-16  Tom Tromey  <tom@tromey.com>
3873
3874         * tui/tui-winsource.h (struct tui_source_window_base)
3875         <update_source_window>: Declare.
3876         (tui_update_source_window): Don't declare.
3877         * tui/tui-winsource.c
3878         (tui_source_window_base::update_source_window): Rename from
3879         tui_update_source_window.
3880         (tui_source_window_base::rerender): Update.
3881         * tui/tui-source.c (tui_source_window::maybe_update): Update.
3882         * tui/tui-disasm.c (tui_show_disassem)
3883         (tui_show_disassem_and_update_source)
3884         (tui_disasm_window::maybe_update): Update.
3885
3886 2019-08-16  Tom Tromey  <tom@tromey.com>
3887
3888         * tui/tui-winsource.h (struct tui_source_window_base)
3889         <update_source_window_as_is>: Declare.
3890         (tui_update_source_window_as_is): Don't declare.
3891         * tui/tui-winsource.c (tui_update_source_window): Update
3892         (tui_source_window_base::update_source_window_as_is): Rename from
3893         tui_update_source_window_as_is.
3894         (tui_source_window_base::refill): Update.
3895         * tui/tui-source.c (tui_show_symtab_source): Update.
3896         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
3897         Update.
3898
3899 2019-08-16  Tom Tromey  <tom@tromey.com>
3900
3901         * tui/tui-winsource.h (tui_update_source_window)
3902         (tui_update_source_window_as_is): Remove "noerror" parameter.
3903         * tui/tui-winsource.c (tui_update_source_window)
3904         (tui_update_source_window_as_is): Remove "noerror" parameter.
3905         (tui_update_source_windows_with_addr)
3906         (tui_update_source_windows_with_line)
3907         (tui_source_window_base::rerender)
3908         (tui_source_window_base::refill): Update.
3909         * tui/tui-source.h (tui_set_source_content)
3910         (tui_show_symtab_source): Remove "noerror" parameter.
3911         * tui/tui-source.c (tui_set_source_content): Remove "noerror"
3912         parameter.
3913         (tui_show_symtab_source): Likewise.
3914         (tui_source_window::maybe_update): Update.
3915         * tui/tui-disasm.c (tui_show_disassem)
3916         (tui_show_disassem_and_update_source)
3917         (tui_disasm_window::do_scroll_vertical)
3918         (tui_disasm_window::maybe_update): Update.
3919
3920 2019-08-16  Tom Tromey  <tom@tromey.com>
3921
3922         * tui/tui.c (tui_is_window_visible): Update.
3923         * tui/tui-wingeneral.c (tui_make_window)
3924         (tui_gen_win_info::make_visible, tui_refresh_all): Update.
3925         * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
3926         (tui_set_focus_command, tui_all_windows_info, update_tab_width)
3927         (tui_set_win_height_command, parse_scrolling_args): Update.
3928         * tui/tui-source.c (tui_source_window::style_changed): Update.
3929         * tui/tui-regs.c (tui_show_registers)
3930         (tui_data_window::first_data_item_displayed)
3931         (tui_data_window::delete_data_content_windows)
3932         (tui_check_register_values, tui_reg_command): Update.
3933         * tui/tui-disasm.c (tui_show_disassem): Update.
3934         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
3935         method.
3936         <is_visible>: Remove field.
3937         * tui/tui-data.c (tui_next_win, tui_prev_win)
3938         (tui_delete_invisible_windows): Update.
3939
3940 2019-08-16  Tom Tromey  <tom@tromey.com>
3941
3942         * tui/tui-winsource.h (struct tui_source_window_base)
3943         <m_has_locator>: Remove.
3944         * tui/tui-layout.c (show_source_disasm_command, show_data)
3945         (show_source_or_disasm_and_command): Update.
3946
3947 2019-08-16  Alan Hayward  <alan.hayward@arm.com>
3948
3949         * NEWS (Other MI changes): New subsection.
3950         * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
3951         (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
3952         * arch-utils.c (default_get_pc_address_flags): New function.
3953         * arch-utils.h (default_get_pc_address_flags): New declaration.
3954         * gdbarch.sh: Add get_pc_address_flags.
3955         * gdbarch.c: Regenerate.
3956         * gdbarch.h: Likewise.
3957         * stack.c (print_pc): New function.
3958         (print_frame_info) (print_frame): Call print_pc.
3959
3960 2019-08-16  Tom de Vries  <tdevries@suse.de>
3961
3962         * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
3963         print_objfile_section_info.
3964
3965 2019-08-15  Tom Tromey  <tom@tromey.com>
3966
3967         * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
3968         calling update_cmdwin_start_line.
3969         * tui/tui-winsource.h (struct tui_source_window_base)
3970         <do_make_visible_with_new_height, set_new_height>: Don't declare.
3971         <rerender>: Declare.
3972         * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
3973         Call rerender.
3974         (tui_source_window_base::set_new_height): Remove.
3975         (tui_source_window_base::rerender): Rename from
3976         do_make_visible_with_new_height.
3977         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
3978         resize method.
3979         (tui_win_info::make_invisible_and_set_new_height)
3980         (tui_win_info::make_visible_with_new_height): Remove.
3981         * tui/tui-stack.h (struct tui_locator_window) <rerender>:
3982         Declare.
3983         * tui/tui-stack.c (tui_locator_window::rerender): New method.
3984         * tui/tui-regs.h (struct tui_data_window) <set_new_height,
3985         do_make_visible_with_new_height>: Don't declare.
3986         <rerender>: Declare.
3987         * tui/tui-regs.c (tui_data_window::rerender): Rename from
3988         set_new_height.
3989         (tui_data_window::do_make_visible_with_new_height): Remove.
3990         * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
3991         call tui_show_locator_content.
3992         (tui_gen_win_info::resize): Call rerender.
3993         (show_source_or_disasm_and_command): Don't call
3994         tui_show_locator_content.
3995         * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
3996         method.
3997         (struct tui_win_info) <rerender>: Declare.
3998         <set_new_height, make_invisible_and_set_new_height,
3999         make_visible_with_new_height>: Don't declare.
4000         * tui/tui-data.c (tui_win_list::rerender): New method.
4001         * tui/tui-command.h (struct tui_cmd_window)
4002         <do_make_visible_with_new_height>: Don't declare.
4003         * tui/tui-command.c
4004         (tui_cmd_window::do_make_visible_with_new_height): Remove.
4005
4006 2019-08-15  Tom Tromey  <tromey@adacore.com>
4007
4008         * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
4009         * ada-lang.c (ada_enum_name): Likewise.
4010
4011 2019-08-15  Christian Biesinger  <cbiesinger@google.com>
4012
4013         * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
4014         leading underscore.
4015         (GdbOutputErrorFile): Likewise.
4016         (global scope): Adjust constructor calls to GdbOutput{,Error}File
4017         accordingly.
4018         (execute_unwinders): Rename to have a leading underscore.
4019         (auto_load_packages): Likewise.
4020         (global scope): Adjust call to auto_load_packages accordingly.
4021         (GdbSetPythonDirectory): Likewise.
4022         * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
4023         instead of execute_unwinders.
4024
4025 2019-08-15  Tom Tromey  <tom@tromey.com>
4026
4027         * tui/tui-layout.c (show_layout, show_source_disasm_command)
4028         (show_data): Don't change window visibility.
4029         (tui_gen_win_info::resize): Remove special case for command
4030         window.  Use wresize, when available.
4031         (show_source_or_disasm_and_command): Don't change window
4032         visibility.
4033         * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
4034         <make_visible>: New method.
4035         * tui/tui-command.c (tui_cmd_window::resize): New method.
4036
4037 2019-08-15  Tom Tromey  <tom@tromey.com>
4038
4039         * tui/tui-winsource.h (struct tui_source_window_iterator): New.
4040         (struct tui_source_windows): New.
4041         * tui/tui-winsource.c (tui_display_main): Update.
4042         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
4043         (new_height_ok, parse_scrolling_args): Update.
4044         * tui/tui-layout.c (show_layout, show_data): Update.
4045         * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
4046         (tui_add_to_source_windows): Don't declare.
4047         * tui/tui-data.c (source_windows, tui_source_windows)
4048         (tui_clear_source_windows, tui_add_to_source_windows): Remove.
4049
4050 2019-08-15  Tom Tromey  <tom@tromey.com>
4051
4052         * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
4053         Rename from reset.
4054         * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
4055         * tui/tui-layout.c (show_source_disasm_command, show_data):
4056         Update.
4057         (tui_gen_win_info::resize): Rename.
4058         (show_source_or_disasm_and_command): Update.
4059         * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
4060         reset.
4061
4062 2019-08-15  Tom Tromey  <tom@tromey.com>
4063
4064         * tui/tui-stack.c (tui_initialize_static_data): Remove.
4065         * tui/tui-interp.c (tui_interp::init): Don't call
4066         tui_initialize_static_data.
4067         * tui/tui-data.h (tui_initialize_static_data): Don't declare.
4068
4069 2019-08-15  Tom Tromey  <tom@tromey.com>
4070
4071         * tui/tui-layout.c (tui_default_win_viewport_height): Don't
4072         examine tui_win_list.
4073
4074 2019-08-15  Tom Tromey  <tom@tromey.com>
4075
4076         * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
4077         * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
4078         tui_clear_source_content.
4079         (tui_clear_source_content): Remove.
4080         (tui_source_window_base::do_erase_source_content): Hoist call to
4081         content.clear().
4082         * tui/tui-stack.c (tui_show_frame_info): Don't call
4083         tui_clear_source_content.
4084
4085 2019-08-15  Tom Tromey  <tom@tromey.com>
4086
4087         * tui/tui-winsource.h (struct tui_source_window_base)
4088         <do_erase_source_content>: New method.
4089         <erase_source_content>: New method.
4090         (tui_erase_source_content): Don't declare.
4091         * tui/tui-winsource.c (tui_clear_source_content): Update.
4092         (tui_source_window_base::do_erase_source_content): Rename from
4093         tui_erase_source_content.
4094         (tui_source_window_base::show_source_content): Update.
4095         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
4096         * tui/tui-source.h (struct tui_source_window)
4097         <erase_source_content>: New method.
4098         * tui/tui-disasm.h (struct tui_disasm_window)
4099         <erase_source_content>: New method.
4100
4101 2019-08-15  Tom Tromey  <tom@tromey.com>
4102
4103         * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
4104         (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
4105         constructor.
4106         * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
4107         * tui/tui-source.c (tui_set_source_content): Update.
4108         * tui/tui-disasm.c (tui_set_disassem_content): Update.
4109
4110 2019-08-15  Tom Tromey  <tom@tromey.com>
4111
4112         * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
4113         * tui/tui-winsource.c (tui_line_is_displayed): Move to
4114         tui-source.c.
4115         * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
4116         Declare.
4117         * tui/tui-source.c (tui_source_window::line_is_displayed): New
4118         method.
4119         (tui_source_window::maybe_update): Update.
4120
4121 2019-08-15  Tom Tromey  <tom@tromey.com>
4122
4123         * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
4124         * tui/tui-winsource.c (tui_addr_is_displayed): Move to
4125         tui-disasm.c.
4126         * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
4127         Declare.
4128         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
4129         method.
4130         (tui_disasm_window::maybe_update): Update.
4131
4132 2019-08-15  Tom Tromey  <tom@tromey.com>
4133
4134         * tui/tui-winsource.h (struct tui_source_window_base)
4135         <maybe_update>: Declare.
4136         * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
4137         method.
4138         * tui/tui-source.h (struct tui_source_window) <maybe_update>:
4139         Declare.
4140         * tui/tui-source.c (tui_source_window::maybe_update): New method.
4141         * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
4142         Declare.
4143         * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
4144
4145 2019-08-15  Tom Tromey  <tom@tromey.com>
4146
4147         * tui/tui-stack.c (tui_make_status_line): Use string constructor.
4148
4149 2019-08-15  Tom Tromey  <tom@tromey.com>
4150
4151         * tui/tui-wingeneral.c: Include tui-stack.h.
4152         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
4153         (struct tui_locator_window): Move from tui-data.h.
4154         * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
4155         (tui_initialize_static_data): Move from tui-data.c.
4156         * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
4157         (struct tui_locator_window): Move to tui-stack.c.
4158         * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
4159         (tui_initialize_static_data): Move to tui-stack.c.
4160
4161 2019-08-15  Tom Tromey  <tom@tromey.com>
4162
4163         * tui/tui-layout.c (show_source_disasm_command)
4164         (show_source_or_disasm_and_command): Use make_visible method, not
4165         tui_make_window.
4166         * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
4167         Remove.
4168
4169 2019-08-15  Tom Tromey  <tom@tromey.com>
4170
4171         * tui/tui-wingeneral.h (tui_make_window): Update.
4172         * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
4173         parameter.
4174         (tui_gen_win_info::make_visible): Update.
4175         * tui/tui-regs.c (tui_data_window::display_registers_from):
4176         Update.
4177         * tui/tui-layout.c (show_source_disasm_command)
4178         (show_source_or_disasm_and_command): Update.
4179         * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
4180         (enum tui_box): Remove.
4181         (struct tui_win_info) <can_box>: New method.
4182         * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
4183         method.
4184
4185 2019-08-15  Tom de Vries  <tdevries@suse.de>
4186
4187         * linux-nat-trad.c: Include gdbarch.h.
4188
4189 2019-08-14  Alan Hayward  <alan.hayward@arm.com>
4190
4191         * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
4192         register sizes.
4193
4194 2019-08-14  Tom Tromey  <tromey@adacore.com>
4195
4196         * darwin-nat.c: Include gdbarch.h.
4197         * darwin-nat-info.c: Include gdbarch.h.
4198
4199 2019-08-13  Tom Tromey  <tom@tromey.com>
4200
4201         * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
4202         Remove.
4203         * tui/tui-data.c (tui_initialize_static_data): Update.
4204
4205 2019-08-13  Tom Tromey  <tom@tromey.com>
4206
4207         * tui/tui-winsource.h (struct tui_exec_info_window)
4208         <~tui_exec_info_window, maybe_allocate_content, get_content,
4209         m_content>: Remove.
4210         (struct tui_source_window_base) <set_exec_info_content,
4211         show_exec_info_content>: Don't declare.
4212         * tui/tui-winsource.c
4213         (tui_exec_info_window::maybe_allocate_content): Remove.
4214         (tui_source_window_base::update_exec_info): Rename from
4215         set_exec_info_content.
4216         (tui_source_window_base::show_exec_info_content)
4217         (tui_source_window_base::update_exec_info): Remove.
4218
4219 2019-08-13  Tom Tromey  <tom@tromey.com>
4220
4221         * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
4222         declare.
4223         * tui/tui-winsource.c (tui_update_source_window_as_is)
4224         (tui_update_source_windows_with_addr, tui_erase_source_content):
4225         Update.
4226         (tui_clear_exec_info_content): Remove.
4227
4228 2019-08-13  Tom Tromey  <tom@tromey.com>
4229
4230         * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
4231         declare.
4232         * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
4233         call tui_erase_exec_info_content.
4234         (tui_clear_exec_info_content): Rename from
4235         tui_erase_exec_info_content.
4236         (tui_clear_exec_info_content): Delete.
4237
4238 2019-08-13  Tom Tromey  <tom@tromey.com>
4239
4240         * tui/tui-winsource.h (struct tui_source_window_base)
4241         <show_exec_info_content>: Declare.
4242         (tui_show_exec_info_content): Don't declare.
4243         * tui/tui-winsource.c
4244         (tui_source_window_base::show_exec_info_content): Rename from
4245         tui_show_exec_info_content.
4246         (tui_source_window_base::update_exec_info): Update.
4247
4248 2019-08-13  Tom Tromey  <tom@tromey.com>
4249
4250         * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
4251         (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
4252         (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
4253         * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
4254         tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
4255         (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
4256         ... here.
4257
4258 2019-08-13  Tom Tromey  <tom@tromey.com>
4259
4260         * tui/tui-winsource.h (struct tui_source_window_base)
4261         <update_exec_info>: Declare.
4262         (tui_update_exec_info): Don't declare.
4263         * tui/tui-winsource.c (tui_update_source_window_as_is)
4264         (tui_source_window_base::refresh_all)
4265         (tui_update_all_breakpoint_info): Update.
4266         (tui_source_window_base::update_exec_info): Rename from
4267         tui_update_exec_info.
4268         * tui/tui-stack.c (tui_show_frame_info): Update.
4269
4270 2019-08-13  Tom Tromey  <tom@tromey.com>
4271
4272         * tui/tui-winsource.h (struct tui_source_window_base)
4273         <set_exec_info_content>: Declare.
4274         (tui_set_exec_info_content): Don't declare.
4275         * tui/tui-winsource.c
4276         (tui_source_window_base::set_exec_info_content): Rename from
4277         tui_set_exec_info_content.
4278         (tui_update_exec_info): Update.
4279
4280 2019-08-13  Tom Tromey  <tom@tromey.com>
4281
4282         * tui/tui-winsource.h (struct tui_source_window_base)
4283         <show_source_content>: Declare.
4284         (tui_show_source_content): Don't declare.
4285         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
4286         (tui_source_window_base::show_source_content): Rename from
4287         tui_show_source_content.
4288         (tui_source_window_base::refresh_all): Update.
4289         * tui/tui-layout.c (show_source_disasm_command)
4290         (show_source_or_disasm_and_command): Update.
4291
4292 2019-08-13  Tom Tromey  <tom@tromey.com>
4293
4294         * tui/tui-winsource.c (tui_erase_source_content)
4295         (tui_show_source_content, tui_source_window_base::refresh_all):
4296         Update.
4297         * tui/tui-wingeneral.h
4298         (tui_check_and_display_highlight_if_needed): Don't declare.
4299         * tui/tui-wingeneral.c
4300         (tui_win_info::check_and_display_highlight_if_needed): Rename from
4301         check_and_display_highlight_if_needed.
4302         * tui/tui-win.c (tui_rehighlight_all)
4303         (tui_win_info::make_visible_with_new_height): Update.
4304         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
4305         (tui_data_window::erase_data_content)
4306         (tui_data_window::display_all_data): Update.
4307         * tui/tui-data.h (struct tui_win_info)
4308         <check_and_display_highlight_if_needed>: Declare.
4309
4310 2019-08-13  Tom Tromey  <tom@tromey.com>
4311
4312         * tui/tui-win.c (tui_resize_all): Call
4313         tui_delete_invisible_windows.
4314         * tui/tui-layout.c (show_layout): Call
4315         tui_delete_invisible_windows.
4316         * tui/tui-data.h (tui_delete_invisible_windows): Declare.
4317         * tui/tui-data.c (tui_delete_invisible_windows): New function.
4318
4319 2019-08-13  Tom Tromey  <tom@tromey.com>
4320
4321         * tui/tui-disasm.c (tui_show_disassem): Add assertion.  Don't call
4322         tui_add_win_to_layout.
4323
4324 2019-08-13  Tom Tromey  <tom@tromey.com>
4325
4326         * tui/tui-layout.h (tui_default_win_height): Don't declare.
4327         * tui/tui-layout.c (tui_default_win_height): Now static.
4328
4329 2019-08-13  Tom Tromey  <tom@tromey.com>
4330
4331         * tui/tui-layout.c (show_layout): Unify all layout cases into a
4332         single switch.
4333         (show_source_disasm_command, show_source_or_disasm_and_command):
4334         Don't check current layout.
4335
4336 2019-08-13  Tom Tromey  <tom@tromey.com>
4337
4338         * tui/tui-wingeneral.c (make_all_visible): Remove.
4339         (tui_make_all_invisible): Simplify.
4340         * tui/tui-layout.c (tui_make_all_invisible): Move from
4341         tui-wingeneral.c; simplify.
4342         (show_layout): Hoist call to tui_make_all_invisible.
4343         (show_data): Don't call tui_make_all_invisible.
4344
4345 2019-08-13  Tom Tromey  <tom@tromey.com>
4346
4347         * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
4348         * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
4349
4350 2019-08-13  Tom Tromey  <tom@tromey.com>
4351
4352         * tui/tui-layout.c (current_layout, tui_current_layout): Move from
4353         tui-data.c.
4354         (show_source_disasm_command, show_data)
4355         (show_source_or_disasm_and_command): Don't use
4356         tui_set_current_layout_to.
4357         * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
4358         * tui/tui-data.c (current_layout, tui_current_layout): Move to
4359         tui-layout.c.
4360         (tui_set_current_layout_to): Remove.
4361
4362 2019-08-13  Tom Tromey  <tom@tromey.com>
4363
4364         * tui/tui-layout.c (tui_set_layout): Update.
4365         * tui/tui-data.h (struct tui_layout_def): Remove.
4366         (tui_layout_def): Don't declare.
4367         * tui/tui-data.c (layout_def): Remove.
4368         (tui_layout_def): Remove.
4369
4370 2019-08-13  Tom Tromey  <tom@tromey.com>
4371
4372         * tui/tui-winsource.h (struct tui_source_window_base)
4373         <clear_detail>: No longer "override".
4374         * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
4375         * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
4376         * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
4377         * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
4378         Remove.
4379         * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
4380
4381 2019-08-13  Tom Tromey  <tromey@adacore.com>
4382
4383         * tracepoint.c: Don't include readline.h or history.h.
4384
4385 2019-08-12  Tom Tromey  <tom@tromey.com>
4386
4387         * configure: Rebuild.
4388         * configure.ac: Check for readline 7.
4389         * NEWS: Mention readline 7 requirement.
4390         * README: Update.
4391
4392 2019-08-12  Tom Tromey  <tom@tromey.com>
4393
4394         * mingw-hdep.c (gdb_select): Remove readline hack.
4395
4396 2019-08-09  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
4397
4398         * blockframe.c (find_pc_partial_function): Set *block to nullptr
4399         when the function fails.
4400
4401 2019-08-09  Andreas Arnez  <arnez@linux.ibm.com>
4402
4403         * s390-tdep.c (s390_type_align): New function.
4404         (s390_gdbarch_init): Set it as type_align gdbarch method.
4405
4406 2019-08-09  Tom de Vries  <tdevries@suse.de>
4407
4408         PR gdb/24591
4409         * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
4410         pc_low with relocation offset.
4411
4412 2019-08-07  Tom Tromey  <tromey@adacore.com>
4413
4414         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
4415         (print_frame_args): Update.
4416         * python/py-framefilter.c (py_print_single_arg, enumerate_args):
4417         Update.
4418         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
4419         * frame.h (struct frame_arg): Add initializers.
4420         <error>: Now a unique_xmalloc_ptr.
4421
4422 2019-08-07  Alan Hayward  <alan.hayward@arm.com>
4423
4424         * NEWS: Expand the Pointer Authentication entry.
4425         * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
4426         (aarch64_frame_unmask_lr): ... to this.
4427         (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
4428         Call aarch64_frame_unmask_lr.
4429         * frame.c (struct frame_info): Add "masked" variable.
4430         (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
4431         (fprint_frame): Check for masked pc.
4432         * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
4433         declarations.
4434         * python/py-framefilter.c (py_print_frame): Check for masked pc.
4435         * stack.c (print_frame): Check for masked pc.
4436
4437 2019-08-06  Tom Tromey  <tom@tromey.com>
4438
4439         * stabsread.c (patch_block_stabs, read_one_struct_field)
4440         (read_enum_type): Use obstack_strndup.
4441         * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
4442         * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
4443         * dwarf2read.c (guess_full_die_structure_name)
4444         (anonymous_struct_prefix): Use obstack_strndup.
4445         * dbxread.c (cp_set_block_scope): Use obstack_strndup.
4446         * c-exp.y (yylex): Use obstack_strndup.
4447         * ada-exp.y (write_object_renaming, write_ambiguous_var)
4448         (write_var_or_type): Use obstack_strndup.
4449
4450 2019-08-06  Tom Tromey  <tom@tromey.com>
4451
4452         * symfile.c (reread_symbols): Use obstack_strdup.
4453         * stabsread.c (read_type): Use obstack_strdup.
4454         * gdb_obstack.h (obstack_strdup): New overload.
4455         * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
4456         (create_dwo_unit_in_dwp_v2, build_error_marker_type)
4457         (dwarf2_canonicalize_name): Use obstack_strdup.
4458         * dbxread.c (read_dbx_symtab): Use obstack_strdup.
4459         * cp-support.c (inspect_type, replace_typedefs_qualified_name):
4460         Use obstack_strdup.
4461
4462 2019-08-06  Tom Tromey  <tom@tromey.com>
4463
4464         * gdb_obstack.h (obstack_strdup): Define.
4465         * gdb_obstack.c (obstack_strdup): Don't define.
4466
4467 2019-08-06  Tom Tromey  <tom@tromey.com>
4468
4469         * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
4470         obstack_strdup.
4471         * typeprint.c (typedef_hash_table::find_global_typedef): Use
4472         obstack_strdup.
4473         * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
4474         * stabsread.c (common_block_start): Use obstack_strdup.
4475         * objfiles.c (set_objfile_main_name, objfile): Use
4476         obstack_strdup.
4477         * namespace.c (add_using_directive): Use obstack_strdup.
4478         * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
4479         * jit.c (finalize_symtab): Use obstack_strdup.
4480         * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
4481         (guess_partial_die_structure_name, partial_die_info::fixup)
4482         (dwarf2_name): Use obstack_strdup.
4483         * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
4484         obstack_strdup.
4485         * c-exp.y (scan_macro_expansion): Use obstack_strdup.
4486         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
4487         obstack_strdup.
4488         * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
4489
4490 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4491
4492         * unittests/help-doc-selftests.c: New file.
4493         * Makefile.in: Add the new file.
4494
4495 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4496
4497         * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
4498         * cli/cli-decode.c (print_doc_line): Likewise.  It now prints
4499         the full first line, except when FOR_VALUE_PREFIX.  In this case,
4500         the trailing '.' is not output, and the first character is uppercased.
4501         (print_help_for_command): Update call to print_doc_line.
4502         (print_doc_of_command): Likewise.
4503         * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
4504         * cli/cli-option.c (append_indented_doc): Do not append newline.
4505         (build_help_option): Append newline after first appended_indented_doc
4506         only if a second call is done.
4507         (build_help): Append 2 new lines before each option, except the first
4508         one.
4509         * compile/compile.c (_initialize_compile): Add new lines after
4510         %OPTIONS%, when not at the end of the help.
4511         Change help doc or code
4512         producing the help doc to respect the invariants.
4513         * maint-test-options.c (_initialize_maint_test_options): Likewise.
4514         Also removed the new line after 'Options:', as all other commands
4515         do not put an empty line between 'Options:' and the first option.
4516         * printcmd.c (_initialize_printcmd): Likewise.
4517         * stack.c (_initialize_stack): Likewise.
4518         * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
4519         incorrectly telling COMMAND is optional.
4520         * ada-lang.c (_initialize_ada_language): Change help doc or code
4521         producing the help doc to respect the invariants.
4522         * ada-tasks.c (_initialize_ada_tasks): Likewise.
4523         * breakpoint.c (_initialize_breakpoint): Likewise.
4524         * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
4525         * cli/cli-logging.c (_initialize_cli_logging): Likewise.
4526         * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
4527         * cli/cli-style.c (cli_style_option::add_setshow_commands,
4528         _initialize_cli_style): Likewise.
4529         * corelow.c (core_target_info): Likewise.
4530         * dwarf-index-cache.c (_initialize_index_cache): Likewise.
4531         * dwarf2read.c (_initialize_dwarf2_read): Likewise.
4532         * filesystem.c (_initialize_filesystem): Likewise.
4533         * frame.c (_initialize_frame): Likewise.
4534         * gnu-nat.c (add_task_commands): Likewise.
4535         * infcall.c (_initialize_infcall): Likewise.
4536         * infcmd.c (_initialize_infcmd): Likewise.
4537         * interps.c (_initialize_interpreter): Likewise.
4538         * language.c (_initialize_language): Likewise.
4539         * linux-fork.c (_initialize_linux_fork): Likewise.
4540         * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
4541         * maint.c (_initialize_maint_cmds): Likewise.
4542         * memattr.c (_initialize_mem): Likewise.
4543         * printcmd.c (_initialize_printcmd): Likewise.
4544         * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
4545         _RegEx): Likewise.
4546         * ravenscar-thread.c (_initialize_ravenscar): Likewise.
4547         * record-btrace.c (_initialize_record_btrace): Likewise.
4548         * record-full.c (_initialize_record_full): Likewise.
4549         * record.c (_initialize_record): Likewise.
4550         * regcache-dump.c (_initialize_regcache_dump): Likewise.
4551         * regcache.c (_initialize_regcache): Likewise.
4552         * remote.c (add_packet_config_cmd, init_remote_threadtests,
4553         _initialize_remote): Likewise.
4554         * ser-tcp.c (_initialize_ser_tcp): Likewise.
4555         * serial.c (_initialize_serial): Likewise.
4556         * skip.c (_initialize_step_skip): Likewise.
4557         * source.c (_initialize_source): Likewise.
4558         * stack.c (_initialize_stack): Likewise.
4559         * symfile.c (_initialize_symfile): Likewise.
4560         * symtab.c (_initialize_symtab): Likewise.
4561         * target-descriptions.c (_initialize_target_descriptions): Likewise.
4562         * top.c (init_main): Likewise.
4563         * tracefile-tfile.c (tfile_target_info): Likewise.
4564         * tracepoint.c (_initialize_tracepoint): Likewise.
4565         * tui/tui-win.c (_initialize_tui_win): Likewise.
4566         * utils.c (add_internal_problem_command): Likewise.
4567         * valprint.c (value_print_option_defs): Likewise.
4568
4569 2019-08-06  Frank Ch. Eigler  <fche@redhat.com>
4570
4571         PR build/24886
4572         * configure.ac: Drop enable-libmcheck support.
4573         * configure, config.in: Rebuild.
4574         * libmcheck.m4: Remove.
4575         * acinclude.m4: Don't include it.
4576         * Makefile.in: Don't distribute it.
4577         * top.c (print_gdb_configuration): Don't mention it.
4578
4579 2019-08-06  Tom Tromey  <tom@tromey.com>
4580
4581         * utils.c (set_output_style): Sometimes pass stream to
4582         emit_style_escape.
4583         * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
4584         * record-btrace.c (btrace_insn_history): Update.
4585         * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
4586         method.
4587         * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
4588         Update initializers.
4589         <m_uiout>: New field.
4590         <m_di>: Move lower.
4591         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
4592         Remove "uiout" parameter.
4593         (dump_insns): Update.
4594         * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
4595         * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
4596
4597 2019-08-06  Christian Biesinger  <cbiesinger@google.com>
4598
4599         * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
4600         (error_in_psymtab_expansion): Likewise.
4601         (lookup_symbol_via_quick_fns): Likewise.
4602         (basic_lookup_transparent_type_quick): Likewise.
4603         (basic_lookup_transparent_type_1): Likewise.
4604
4605 2019-08-06  Tom Tromey  <tromey@adacore.com>
4606
4607         * source.c (last_source_error): Now bool.
4608         (print_source_lines_base): Make "noprint" bool.  Only open
4609         source file when last_source_visited changes.
4610
4611 2019-08-06  Tom Tromey  <tromey@adacore.com>
4612
4613         * annotate.c (annotate_source_line): Use g_source_cache.
4614         * source-cache.c (source_cache::get_plain_source_lines): Change
4615         parameters.  Populate m_offset_cache.
4616         (source_cache::ensure): New method.
4617         (source_cache::get_line_charpos): New method.
4618         (extract_lines): Move lower.  Change parameters.
4619         (source_cache::get_source_lines): Move lower.
4620         * source-cache.h (class source_cache): Update comment.
4621         <get_line_charpos>: New method.
4622         <get_source_lines>: Update comment.
4623         <clear>: Clear m_offset_cache.
4624         <get_plain_source_lines>: Change parameters.
4625         <ensure>: New method
4626         <m_offset_cache>: New member.
4627         * source.c (forget_cached_source_info_for_objfile): Update.
4628         (info_source_command): Use g_source_cache.
4629         (find_source_lines, open_source_file_with_line_charpos): Remove.
4630         (print_source_lines_base, search_command_helper): Use g_source_cache.
4631         * source.h (open_source_file_with_line_charpos): Don't declare.
4632         * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
4633         * tui/tui-source.c (tui_source_window::do_scroll_vertical):
4634         Use g_source_cache.
4635
4636 2019-08-06  Tom Tromey  <tromey@adacore.com>
4637
4638         * source-cache.c (source_cache::get_plain_source_lines):
4639         Remove "first_line" and "last_line" parameters.
4640         (source_cache::get_source_lines): Cache plain text.
4641         * source-cache.h (class source_cache)
4642         <get_plain_source_lines>: Update.
4643
4644 2019-08-06  Tom Tromey  <tromey@adacore.com>
4645
4646         * source-cache.c (extract_lines): No longer a method.
4647         Changed type of parameter.  Include final newline.
4648         (selftests::extract_lines_test): New function.
4649         (_initialize_source_cache): Likewise.
4650         * source-cache.h (class source_cache)
4651         <extract_lines>: Don't declare.
4652
4653 2019-08-06  Tom Tromey  <tromey@adacore.com>
4654
4655         * breakpoint.c (init_breakpoint_sal): Update.
4656         (breakpoint): Update.
4657         * breakpoint.h (struct breakpoint) <filter>: Now a
4658         unique_xmalloc_ptr.
4659
4660 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
4661
4662         * NEWS: Mention dictionary access on blocks.
4663         * python/py-block.c (blpy_getitem): New function.
4664         (block_object_as_mapping): New struct.
4665         (block_object_type): Use new struct for tp_as_mapping field.
4666
4667 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
4668
4669         * objfiles.h (objfile): Add a comment describing partial symbols.
4670
4671 2019-08-05  Tom Tromey  <tromey@adacore.com>
4672
4673         * compile/compile.c (_initialize_compile): Use _(), not N_().
4674         * thread.c (_initialize_thread): Use _(), not N_().
4675         * stack.c (_initialize_stack): Use _(), not N_().
4676         * printcmd.c (_initialize_printcmd): Use _(), not N_().
4677
4678 2019-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
4679
4680         * dwarf2read.c (struct dw2_symtab_iterator):
4681         <want_specific_block>: Remove.
4682         <block_index>: Change type to gdb::optional.
4683         (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
4684         change type of BLOCK_INDEX parameter to gdb::optional.
4685         (dw2_symtab_iter_next): Re-write in function of gdb::optional.
4686         (dw2_lookup_symbol): Don't pass argument for
4687         WANT_SPECIFIC_BLOCK.
4688         (dw2_expand_symtabs_for_function): Don't pass argument for
4689         WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
4690         (class dw2_debug_names_iterator)
4691         <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
4692         parameter, change BLOCK_INDEX type to gdb::optional.
4693         <m_want_specific_block>: Remove.
4694         <m_block_index>: Change type to gdb::optional.
4695         (dw2_debug_names_iterator::next): Change type of IS_STATIC to
4696         gdb::optional.  Re-write in function of gdb::optional.
4697         (dw2_debug_names_lookup_symbol): Don't pass argument for
4698         WANT_SPECIFIC_BLOCK.
4699         (dw2_debug_names_expand_symtabs_for_function): Don't pass
4700         argument for WANT_SPECIFIC_BLOCK, pass empty optional for
4701         BLOCK_INDEX.
4702
4703 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4704
4705         * NEWS: Mention changes to "info sources" command.
4706
4707 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4708
4709         * symtab.c (filename_partial_match_opts): New struct type.
4710         (struct output_source_filename_data): New members
4711         regexp, c_regexp, partial_match.
4712         (output_source_filename): Use new members to decide to print file.
4713         (info_sources_option_defs): New variable.
4714         (make_info_sources_options_def_group, print_info_sources_header,
4715         info_sources_command_completer):
4716         New functions.
4717         (info_sources_command): Read new optional arguments.
4718         (_initialize_symtab): Update info sources help.
4719
4720 2019-08-02  Alexandre Oliva <oliva@adacore.com>
4721
4722         * ada-lang.c (exception_support_info_v0): Renamed from...
4723         (default_exception_support_info): ... this.  Create new
4724         definition for v1.
4725         (ada_has_this_exception_support): Look up catch_handlers_sym.
4726         (ada_exception_support_info_sniffer): Try v0 after default.
4727
4728 2019-08-01  Tom Tromey  <tromey@adacore.com>
4729
4730         * ia64-libunwind-tdep.h (struct libunwind_descr): Include
4731         gdbarch.h.
4732
4733 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
4734
4735         * s12z-tdep.c: Fix include path for s12z-opc.h.
4736
4737 2019-08-01  Alan Hayward  <alan.hayward@arm.com>
4738
4739         * NEWS: Require GNU make 3.82.
4740
4741 2019-07-16  Tom Tromey  <tom@tromey.com>
4742
4743         * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
4744         declare.
4745
4746 2019-07-30  Tom Tromey  <tromey@adacore.com>
4747
4748         * block.c (contained_in): Remove BLOCK_FUNCTION check.
4749
4750 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
4751
4752         * printcmd.c (print_address_symbolic): Print negative offsets.
4753         (build_address_symbolic): Force signed arithmetic when computing
4754         offset.
4755
4756 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
4757
4758         PR/24474: Add a function to lookup static variables.
4759         * NEWS: Mention this new function.
4760         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
4761         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
4762         * python/python.c (python_GdbMethods): Add new function.
4763
4764 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
4765
4766         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
4767         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
4768         (objfpy_lookup_static_symbol): New function.
4769         (objfile_object_methods): Add new functions.
4770
4771 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4772
4773         * NEWS: Mention 'set|show print frame-info'.  Mention new
4774         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
4775         backtrace argument.  Mention that python frame filtering code
4776         is now consistent with what 'backtrace' command prints.
4777
4778 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4779
4780         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
4781         comments.
4782         (print_frame_info_auto, print_frame_info_source_line,
4783         print_frame_info_location, print_frame_info_source_and_location,
4784         print_frame_info_location_and_address, print_frame_info_short_location):
4785         New declarations.
4786         (struct frame_print_options): New member print_frame_info.
4787         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
4788         * stack.h (get_user_print_what_frame_info): New declaration.
4789         (frame_show_address): New declaration.
4790         * stack.c (print_frame_arguments_choices): New value 'presence'.
4791         (print_frame_info_auto, print_frame_info_source_line,
4792         print_frame_info_location, print_frame_info_source_and_location,
4793         print_frame_info_location_and_address, print_frame_info_short_location,
4794         print_frame_info_choices, print_frame_info_print_what): New definitions.
4795         (print_frame_args): Only print dots for args if print frame-arguments
4796         is 'presence'.
4797         (frame_print_option_defs): New element for "frame-info".
4798         (get_user_print_what_frame_info): New function.
4799         (frame_show_address): Make non static.  Move comment to stack.h.
4800         (print_frame_info_to_print_what): New function.
4801         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
4802         to decide what to print.
4803         (backtrace_command_1): Handle the new print_frame_arguments_presence
4804         value.
4805         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
4806         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
4807         (py_print_frame): In non-mi mode, use LOCATION as default for
4808         print_what, similarly to frame information printed directly by
4809         backtrace command. Handle frame-info user option in non MI mode.
4810
4811 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
4812
4813         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
4814         Add case for debugging 32-bit target on 64-bit host.  Revise
4815         comment.
4816
4817 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
4818
4819         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
4820         instead of find_function_entry_range_from_pc.
4821
4822 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
4823
4824         * stack.c (find_frame_funname): Remove code which preferred
4825         minsym over symtab sym in "certain pathological cases".
4826
4827         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
4828         parameter.  Change type of "do_demangle" to bool.
4829         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
4830         Pass suitable "prefer_sym_over_minsym" flag to
4831         build_address_symbolic().  Don't output "+" for negative offsets.
4832         * printcmd.c (print_address_symbolic): Update invocation of
4833         build_address_symbolic to include a "prefer_sym_over_minsym"
4834         flag.
4835         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
4836         Restrict cases in which use of minimal symbol is preferred to that
4837         of a found symbol.  Update comments.
4838
4839         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
4840         for entry pc when entry pc is out of range for that FDE.
4841
4842 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
4843
4844         PR gdb/24839:
4845         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
4846         type.
4847
4848 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
4849
4850         * python/py-objfile.c (add_separate_debug_file): Fix comment about
4851         this function's Python signature.
4852
4853
4854 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
4855
4856         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
4857         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
4858         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
4859         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
4860         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
4861
4862
4863 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
4864
4865         * h8300-tdep.c (h8300_register_name_common): New.
4866         h8300_register_name): Use h8300_register_name_common.
4867         (h8300s_register_name): Likewise.
4868         (h8300sx_register_name): Likewise.
4869         (h8300h_register_nam): New.
4870         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
4871
4872
4873 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
4874
4875         * arm-tdep.c (arm_skip_cmse_entry): New function.
4876         (arm_is_sgstubs_section): New function.
4877         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
4878
4879 2019-07-22  Tom Tromey  <tom@tromey.com>
4880
4881         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
4882         Don't self-assign.
4883
4884 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
4885
4886         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
4887         type_print.
4888
4889 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
4890
4891         * symtab.c (search_symbols): Adjust msymbol matching type arrays
4892         so that GDB doesn't match any msymbols when searching in the
4893         TYPES_DOMAIN.
4894         (print_symbol_info): Print using typedef_print or type_print based
4895         on the type of the symbol.  Add updated FIXME comment moved from...
4896         (_initialize_symtab): ... move and update FIXME comment to above.
4897
4898 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
4899
4900         * NEWS: Mention adding -q option to "info types".
4901         * symtab.c (struct info_types_options): New struct.
4902         (info_types_options_defs): New variable.
4903         (make_info_types_options_def_group): New function.
4904         (info_types_command): Use gdb::option framework to parse options.
4905         (info_types_command_completer): New function.
4906         (_initialize_symtab): Extend the help text on "info types" and
4907         register command completer.
4908
4909 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
4910
4911         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
4912         (lookup_symbol_in_objfile): Change int to block_enum and add a
4913         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
4914
4915 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
4916
4917         * MAINTAINERS (Write After Approval): Add self.
4918
4919 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
4920
4921         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
4922         instruction to the dummy code region.
4923
4924 2019-07-19  Tom Tromey  <tromey@adacore.com>
4925
4926         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
4927         (ARGSUSED, PARAMS, __func__): Remove rules.
4928
4929 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
4930
4931         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
4932         * features/arm/arm-with-iwmmxt.c: Remove.
4933         * features/arm/arm-with-iwmmxt.xml: Remove.
4934         * features/arm/arm-with-m-fpa-layout.c: Remove.
4935         * features/arm/arm-with-m-fpa-layout.xml: Remove.
4936         * features/arm/arm-with-m-vfp-d16.c: Remove.
4937         * features/arm/arm-with-m-vfp-d16.xml: Remove.
4938         * features/arm/arm-with-m.c: Remove.
4939         * features/arm/arm-with-m.xml: Remove.
4940         * features/arm/arm-with-neon.c: Remove.
4941         * features/arm/arm-with-neon.xml: Remove.
4942         * features/arm/arm-with-vfpv2.c: Remove.
4943         * features/arm/arm-with-vfpv2.xml: Remove.
4944         * features/arm/arm-with-vfpv3.c: Remove.
4945         * features/arm/arm-with-vfpv3.xml: Remove.
4946
4947 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
4948
4949         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
4950
4951 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
4952
4953         * arch/aarch32.c (aarch32_create_target_description): Create
4954         target descriptions using features.
4955         * arch/arm.c (arm_create_target_description)
4956         (arm_create_mprofile_target_description): Likewise.
4957         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
4958
4959 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
4960
4961         * Makefile.in: Add new files.
4962         * aarch32-tdep.c: New file.
4963         * aarch32-tdep.h: New file.
4964         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
4965         Call aarch32_read_description.
4966         * arch/aarch32.c: New file.
4967         * arch/aarch32.h: New file.
4968         * arch/arm.c (arm_create_target_description)
4969         (arm_create_mprofile_target_description): New function.
4970         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
4971         (arm_create_target_description)
4972         (arm_create_mprofile_target_description): New declaration.
4973         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
4974         read_description functions.
4975         * arm-linux-nat.c (arm_linux_nat_target::read_description):
4976         Likewise.
4977         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
4978         * arm-tdep.c (tdesc_arm_list): New variable.
4979         (arm_register_g_packet_guesses): Call create description functions.
4980         (arm_read_description) (arm_read_mprofile_description): New
4981         function.
4982         * arm-tdep.h (arm_read_description)
4983         (arm_read_mprofile_description): Add declaration.
4984         * configure.tgt: Add new files.
4985
4986 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
4987
4988         * top.c (new_ui_command): Open specified terminal just once.
4989
4990 2019-07-18  Tom Tromey  <tromey@adacore.com>
4991
4992         * symtab.c (main_name): Constify return type.
4993         * symfile.c (set_initial_language): Update.
4994         * symtab.h (main_name): Constify return type.
4995
4996 2019-07-17  Tom Tromey  <tom@tromey.com>
4997
4998         * tui/tui-winsource.c (tui_update_source_window)
4999         (tui_update_source_window_as_is)
5000         (tui_update_source_windows_with_line): Remove return.
5001         * tui/tui-disasm.c (tui_show_disassem)
5002         (tui_show_disassem_and_update_source): Remove return.
5003         * tui/tui.c (tui_reset): Remove return.
5004         * tui/tui-wingeneral.c
5005         (tui_check_and_display_highlight_if_needed): Remove return.
5006
5007 2019-07-17  Tom Tromey  <tom@tromey.com>
5008
5009         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
5010
5011 2019-07-17  Tom Tromey  <tom@tromey.com>
5012
5013         * tui/tui-winsource.h (struct tui_exec_info_window)
5014         (struct tui_source_window_base): Move from tui-data.h.
5015         * tui/tui-winsource.c: Move many method definitions from
5016         elsewhere.  Remove "structuring" comments.
5017         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
5018         (tui_source_window_base::refresh_window): Move to
5019         tui-winsource.c.
5020         * tui/tui-win.c (tui_source_window_base::refresh_all)
5021         (tui_source_window_base::update_tab_width)
5022         (tui_source_window_base::set_new_height)
5023         (tui_source_window_base::do_make_visible_with_new_height): Move to
5024         tui-winsource.c.
5025         * tui/tui-source.h: Update.
5026         * tui/tui-source.c (tui_source_window_base::reset): Move to
5027         tui-winsource.c.
5028         * tui/tui-disasm.h: Update.
5029         * tui/tui-data.h (struct tui_exec_info_window): Move to
5030         tui-winsource.h.
5031         (struct tui_source_window_base): Likewise.
5032         * tui/tui-data.c (tui_source_window_base::clear_detail)
5033         (tui_source_window_base, ~tui_source_window_base): Move to
5034         tui-winsource.c.
5035
5036 2019-07-17  Tom Tromey  <tom@tromey.com>
5037
5038         * tui/tui-win.c (tui_resize_all)
5039         (tui_source_window_base::update_tab_width)
5040         (tui_adjust_win_heights): Update.
5041         (tui_win_info::make_invisible_and_set_new_height): Rename from
5042         make_invisible_and_set_new_height.
5043         * tui/tui-data.h (struct tui_win_info)
5044         <make_invisible_and_set_new_height>: New method.
5045
5046 2019-07-17  Tom Tromey  <tom@tromey.com>
5047
5048         * tui/tui.c: Update.
5049         * tui/tui-source.h (struct tui_source_window): Move from
5050         tui-data.h.
5051         * tui/tui-layout.c: Update.
5052         * tui/tui-disasm.c: Update.
5053         * tui/tui-data.h (struct tui_source_window): Move to
5054         tui-source.h.
5055
5056 2019-07-17  Tom Tromey  <tom@tromey.com>
5057
5058         * tui/tui-disasm.h (struct tui_disasm_window): Move from
5059         tui-data.h.
5060         * tui/tui-data.h (struct tui_disasm_window): Move to
5061         tui-disasm.h.
5062
5063 2019-07-17  Tom Tromey  <tom@tromey.com>
5064
5065         * tui/tui-regs.h (struct tui_data_item_window): Move from
5066         tui-data.h.
5067         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
5068         * tui/tui-data.h (struct tui_data_item_window): Move to
5069         tui-regs.h.
5070         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
5071
5072 2019-07-17  Tom Tromey  <tom@tromey.com>
5073
5074         * tui/tui.c: Update.
5075         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
5076         (tui_cmd_window::max_height): Move to tui-command.c.
5077         * tui/tui-layout.c: Update.
5078         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
5079         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
5080         tui-command.c.
5081         * tui/tui-command.h (struct tui_cmd_window): Move from
5082         tui-data.h.
5083         * tui/tui-command.c: Remove "structuring" comments.
5084         (tui_cmd_window::clear_detail)
5085         (tui_cmd_window::do_make_visible_with_new_height)
5086         (tui_cmd_window::max_height): Move from elsewhere.
5087
5088 2019-07-17  Tom Tromey  <tom@tromey.com>
5089
5090         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
5091         Now static.
5092         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
5093         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
5094
5095 2019-07-17  Tom Tromey  <tom@tromey.com>
5096
5097         * tui/tui.c: Update.
5098         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
5099         tui-regs.c.
5100         * tui/tui-windata.h: Remove file.
5101         * tui/tui-windata.c: Remove file.
5102         * tui/tui-win.c (tui_data_window::set_new_height)
5103         (tui_data_window::do_make_visible_with_new_height): Move to
5104         tui-regs.c.
5105         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
5106         * tui/tui-regs.c: Remove "structuring" comments.
5107         (tui_data_window::first_data_item_displayed)
5108         (tui_data_window::delete_data_content_windows)
5109         (tui_data_window::erase_data_content)
5110         (tui_data_window::display_all_data)
5111         (tui_data_window::refresh_all)
5112         (tui_data_window::do_scroll_vertical)
5113         (tui_data_window::clear_detail, tui_data_window::set_new_height)
5114         (tui_data_window::do_make_visible_with_new_height)
5115         (tui_data_window::refresh_window): Move from elsewhere.
5116         (_initialize_tui_regs): Move to end of file.
5117         * tui/tui-layout.c: Update.
5118         * tui/tui-hooks.c: Update.
5119         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
5120         * tui/tui-data.c (tui_data_window::clear_detail): Move to
5121         tui-regs.c.
5122         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
5123
5124 2019-07-17  Tom Tromey  <tom@tromey.com>
5125
5126         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
5127         seen.
5128
5129 2019-07-17  Tom Tromey  <tom@tromey.com>
5130
5131         * tui/tui-win.c (tui_source_window_base::set_new_height)
5132         (tui_source_window_base::do_make_visible_with_new_height): Use
5133         m_has_locator field directly.
5134         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
5135         method.
5136         (struct tui_source_window_base) <has_locator>: Likewise.
5137
5138 2019-07-17  Tom Tromey  <tom@tromey.com>
5139
5140         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
5141         Don't declare.
5142         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
5143         Remove.
5144         * tui/tui-win.c (tui_source_window_base::set_new_height)
5145         (tui_source_window_base::set_new_height)
5146         (make_invisible_and_set_new_height)
5147         (tui_source_window_base::do_make_visible_with_new_height)
5148         (tui_source_window_base::do_make_visible_with_new_height):
5149         Update.
5150         * tui/tui-layout.c (show_source_disasm_command, show_data)
5151         (show_source_or_disasm_and_command): Update.
5152         * tui/tui-layout.c (show_layout): Update.
5153
5154 2019-07-17  Tom Tromey  <tom@tromey.com>
5155
5156         * tui/tui-layout.c (make_data_window): Remove.
5157         (show_data): Unify creation and re-initialization cases.
5158
5159 2019-07-17  Tom Tromey  <tom@tromey.com>
5160
5161         * tui/tui-layout.c (make_source_window, make_disasm_window):
5162         Remove.
5163         (show_data): Unify creation and re-initialization cases.
5164
5165 2019-07-17  Tom Tromey  <tom@tromey.com>
5166
5167         * tui/tui-layout.c (make_command_window): Remove.
5168         (show_source_disasm_command, show_source_or_disasm_and_command):
5169         Unify creation and re-initialization cases.
5170
5171 2019-07-17  Tom Tromey  <tom@tromey.com>
5172
5173         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
5174         creation and re-initialization cases.
5175
5176 2019-07-17  Tom Tromey  <tom@tromey.com>
5177
5178         * tui/tui-regs.c (tui_get_register): Return void.
5179
5180 2019-07-17  Tom Tromey  <tom@tromey.com>
5181
5182         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
5183         Simplify.
5184
5185 2019-07-17  Tom Tromey  <tom@tromey.com>
5186
5187         * tui/tui-layout.c (show_source_disasm_command): Simplify window
5188         resetting.
5189
5190 2019-07-17  Tom Tromey  <tom@tromey.com>
5191
5192         * tui/tui.h (tui_set_layout_by_name): Don't declare.
5193         * tui/tui-regs.c (tui_reg_layout): New function.
5194         (tui_show_registers, tui_reg_command): Use it.
5195         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
5196         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
5197         parameters.
5198         (tui_layout_command): Remove.
5199
5200 2019-07-17  Tom Tromey  <tom@tromey.com>
5201
5202         * tui/tui-layout.h (tui/tui-layout): Return void.
5203         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
5204
5205 2019-07-17  Tom Tromey  <tom@tromey.com>
5206
5207         * tui/tui-layout.c (show_source_disasm_command, show_data):
5208         Update.
5209         (reset_locator): Remove.
5210         (show_source_or_disasm_and_command): Update.
5211
5212 2019-07-17  Tom Tromey  <tom@tromey.com>
5213
5214         * tui/tui-source.c (tui_source_window_base::reset): Remove
5215         win_type parameter.
5216         * tui/tui-layout.c (make_command_window, make_source_window)
5217         (make_disasm_window, make_data_window)
5218         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
5219         (reset_locator, show_source_or_disasm_and_command): Update.
5220         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
5221         win_type parameter.
5222         (struct tui_source_window_base) <reset>: Likewise.
5223
5224 2019-07-17  Tom Tromey  <tom@tromey.com>
5225
5226         * tui/tui-layout.c (show_source_disasm_command): Use
5227         reset_locator.
5228         (reset_locator): New function.
5229         (init_and_make_win): Remove.
5230         (show_source_or_disasm_and_command): Use reset_locator.
5231
5232 2019-07-17  Tom Tromey  <tom@tromey.com>
5233
5234         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
5235         condition.
5236         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
5237         Remove condition.
5238         * tui/tui-source.c (tui_source_window_base::reset): New method.
5239         * tui/tui-layout.c (make_command_window): Don't call
5240         init_and_make_win.
5241         (make_source_window, make_disasm_window): Don't call
5242         make_source_or_disasm_window.
5243         (make_data_window): Don't call init_and_make_win.  Change calling
5244         convention.
5245         (show_source_disasm_command, show_data): Simplify.
5246         (make_source_or_disasm_window): Remove.
5247         (show_source_or_disasm_and_command): Simplify.
5248         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
5249         (struct tui_source_window_base) <reset>: Likewise.
5250         <execution_info>: Remove initializer.
5251         * tui/tui-data.c (tui_source_window_base): Initialize
5252         execution_info.
5253
5254 2019-07-17  Tom Tromey  <tom@tromey.com>
5255
5256         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
5257         variable.
5258
5259 2019-07-17  Tom Tromey  <tom@tromey.com>
5260
5261         * tui/tui.c (tui_rl_other_window): Update.
5262         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
5263         superclass method first.  Always iterate over regs_content.
5264         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
5265         method.
5266         * tui/tui-win.c (tui_set_focus_command): Update.
5267
5268 2019-07-17  Tom Tromey  <tom@tromey.com>
5269
5270         * tui/tui-win.c (tui_set_focus_command): Rename from
5271         tui_set_focus.  Call tui_enable.
5272         (tui_set_focus_command): Remove.
5273
5274 2019-07-17  Tom Tromey  <tom@tromey.com>
5275
5276         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
5277         refresh_window.
5278         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
5279         touchwin.
5280         (tui_data_window::refresh_window): Call refresh_window on data
5281         items.  Always call superclass refresh_window.
5282         (tui_win_info::refresh): Remove.
5283         (tui_source_window_base::refresh_window): Update.
5284         (tui_refresh_all): Update.
5285         * tui/tui-layout.c (show_source_disasm_command): Remove call to
5286         refresh_window.
5287         (show_source_or_disasm_and_command): Likewise.
5288         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
5289         (struct tui_source_window_base) <refresh>: Likewise.
5290
5291 2019-07-17  Tom Tromey  <tom@tromey.com>
5292
5293         * tui/tui-winsource.c (tui_clear_source_content)
5294         (tui_show_source_content): Update.
5295         * tui/tui-source.c (tui_source_window::showing_source_p): Check
5296         whether content is empty.
5297         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
5298         Remove.
5299
5300 2019-07-17  Tom Tromey  <tom@tromey.com>
5301
5302         * tui/tui-winsource.c (tui_erase_source_content): Clear the
5303         window's contents.
5304         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
5305         * tui/tui-source.c (tui_set_source_content_nil): Remove.
5306
5307 2019-07-17  Tom Tromey  <tom@tromey.com>
5308
5309         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
5310         (struct tui_data_item_window): Update.
5311
5312 2019-07-17  Tom Tromey  <tom@tromey.com>
5313
5314         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
5315         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
5316         defines.
5317
5318 2019-07-17  Tom Tromey  <tom@tromey.com>
5319
5320         * tui/tui-winsource.h (tui_erase_source_content)
5321         (tui_clear_source_content): Remove "display_prompt" parameter.
5322         * tui/tui-winsource.c (tui_update_source_window_as_is)
5323         (tui_update_source_windows_with_addr): Update.
5324         (tui_clear_source_content): Remove "display_prompt" parameter.
5325         (tui_erase_source_content): Likewise.  Simplify.
5326         (tui_show_source_content): Update.
5327         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
5328         * tui/tui-stack.c (tui_show_frame_info): Update.
5329         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
5330         Remove defines.
5331
5332 2019-07-17  Tom Tromey  <tom@tromey.com>
5333
5334         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
5335         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
5336         parameter.
5337         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
5338         parameter.
5339
5340 2019-07-17  Tom Tromey  <tom@tromey.com>
5341
5342         * tui/tui-winsource.c (tui_clear_source_content)
5343         (tui_show_source_content, tui_show_exec_info_content)
5344         (tui_clear_exec_info_content): Update.
5345         * tui/tui-stack.c (tui_show_locator_content): Update.
5346         (tui_show_frame_info): Update.
5347         * tui/tui-source.h (tui_source_window): Don't declare.
5348         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
5349         from tui_source_is_displayed.
5350         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
5351         Remove field.
5352         (struct tui_source_window_base) <content_in_use>: New field.  Now
5353         bool.
5354         (struct tui_source_window) <showing_source_p>: New method.
5355         (TUI_SRC_WIN): Change cast.
5356         * tui/tui-data.c (tui_initialize_static_data): Update.
5357
5358 2019-07-17  Tom Tromey  <tom@tromey.com>
5359
5360         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
5361         location_matches_p.
5362         * tui/tui-source.c (tui_source_window::location_matches_p): New
5363         method.
5364         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
5365         method.
5366         * tui/tui-data.h (struct tui_source_window_base)
5367         <location_matches_p>: New method.
5368         (struct tui_source_window, struct tui_disasm_window)
5369         <location_matches_p>: Likewise.
5370
5371 2019-07-17  Tom Tromey  <tom@tromey.com>
5372
5373         * tui/tui-win.c (tui_set_win_height_command): Rename from
5374         tui_set_win_height.
5375         (tui_set_win_height_command): Remove.
5376
5377 2019-07-17  Tom Tromey  <tom@tromey.com>
5378
5379         * tui/tui-source.c (tui_source_window): New constructor.  Add
5380         observer.
5381         (~tui_source_window): New destructor.
5382         (tui_source_window::style_changed): New method.
5383         * tui/tui-hooks.c (tui_redisplay_source): Remove.
5384         (tui_attach_detach_observers): Update.
5385         * tui/tui-data.h (struct tui_source_window): Make constructor not
5386         inline.  Add destructor.
5387         (struct tui_source_window) <style_changed>: New method.
5388         <m_observable>: New member.
5389
5390 2019-07-17  Tom Tromey  <tom@tromey.com>
5391
5392         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
5393         * tui/tui-win.c (tui_resize_all): Fix typo.
5394
5395 2019-07-17  Tom Tromey  <tom@tromey.com>
5396
5397         * tui/tui-wingeneral.h (tui_refresh_all): Update.
5398         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
5399         (tui_refresh_all): Remove "list" parameter.  Use foreach.
5400         * tui/tui-win.c (window_name_completer): Use foreach.
5401         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
5402         (update_tab_width): Likewise.
5403         * tui/tui-layout.c (show_layout): Update.
5404         * tui/tui-data.h (class tui_window_iterator): New.
5405         (struct all_tui_windows): New.
5406         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
5407
5408 2019-07-17  Tom Tromey  <tom@tromey.com>
5409
5410         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
5411         parameter.  Don't reference globals.
5412         (tui_reg_command): Update.
5413
5414 2019-07-17  Tom Tromey  <tom@tromey.com>
5415
5416         * tui/tui-regs.c (tui_show_registers): Simplify.
5417
5418 2019-07-17  Tom Tromey  <tom@tromey.com>
5419
5420         * tui/tui-regs.c (tui_show_registers): Update.
5421         (tui_show_register_group): Add win_info parameter.
5422
5423 2019-07-17  Tom Tromey  <tom@tromey.com>
5424
5425         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
5426         Rename from tui_display_reg_element_at_line.
5427         (tui_data_window::display_registers_from_line): Update.
5428         * tui/tui-data.h (struct tui_data_window)
5429         <display_reg_element_at_line>: New method.
5430
5431 2019-07-17  Tom Tromey  <tom@tromey.com>
5432
5433         * tui/tui-regs.h (tui_display_registers_from)
5434         (tui_display_registers_from_line): Don't declare.
5435         * tui/tui-windata.c (tui_data_window::display_all_data)
5436         (tui_data_window::refresh_all)
5437         (tui_data_window::do_scroll_vertical): Update.
5438         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
5439         from tui_display_registers_from.
5440         (tui_display_reg_element_at_line): Update.
5441         (tui_data_window::display_registers_from_line): Rename from
5442         tui_display_registers_from_line.
5443         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
5444         display_registers_from_line>: New methods.
5445
5446 2019-07-17  Tom Tromey  <tom@tromey.com>
5447
5448         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
5449         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
5450         from tui_erase_data_content.
5451         (tui_data_window::display_all_data)
5452         (tui_data_window::refresh_all)
5453         (tui_data_window::do_scroll_vertical): Update.
5454         * tui/tui-regs.c (tui_show_registers): Update.
5455         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
5456         New method.
5457
5458 2019-07-17  Tom Tromey  <tom@tromey.com>
5459
5460         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
5461         declare.
5462         * tui/tui-windata.c
5463         (tui_data_window::delete_data_content_windows): Rename from
5464         tui_delete_data_content_windows.
5465         (tui_data_window::display_all_data)
5466         (tui_data_window::do_scroll_vertical): Update.
5467         * tui/tui-data.h (struct tui_data_window)
5468         <delete_data_content_windows>: New method.
5469
5470 2019-07-17  Tom Tromey  <tom@tromey.com>
5471
5472         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
5473         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
5474
5475 2019-07-17  Tom Tromey  <tom@tromey.com>
5476
5477         * tui/tui-windata.h (tui_display_all_data): Don't declare.
5478         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
5479         from tui_display_all_data.
5480         * tui/tui-win.c
5481         (tui_data_window::do_make_visible_with_new_height): Update.
5482         * tui/tui-regs.c (tui_show_registers): Update.
5483         * tui/tui-layout.c (tui_set_layout): Update.
5484         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
5485         method.
5486
5487 2019-07-17  Tom Tromey  <tom@tromey.com>
5488
5489         * tui/tui-windata.h (tui_display_data_from): Don't declare.
5490         * tui/tui-windata.c (tui_display_data_from): Remove.
5491         (tui_data_window::refresh_all): Update.
5492
5493 2019-07-17  Tom Tromey  <tom@tromey.com>
5494
5495         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
5496         * tui/tui-windata.c (tui_display_data_from_line): Remove.
5497         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
5498         tui_display_registers_from_line.
5499         * tui/tui-regs.h (tui_display_registers_from_line): Update.
5500         * tui/tui-regs.c (tui_display_registers_from_line): Remove
5501         "force_display" parameter.
5502
5503 2019-07-17  Tom Tromey  <tom@tromey.com>
5504
5505         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
5506         declare.
5507         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
5508         Rename from tui_first_reg_element_no_inline.
5509         (tui_display_reg_element_at_line)
5510         (tui_display_registers_from_line): Update.
5511         * tui/tui-data.h (struct tui_data_window)
5512         <first_reg_element_no_inline>: New method.
5513
5514 2019-07-17  Tom Tromey  <tom@tromey.com>
5515
5516         * tui/tui-windata.c (tui_display_data_from)
5517         (tui_data_window::do_scroll_vertical): Update.
5518         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
5519         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
5520         Rename from tui_line_from_reg_element_no.
5521         (tui_display_registers_from_line): Update.
5522         * tui/tui-data.h (struct tui_data_window)
5523         <line_from_reg_element_no>: New method.
5524
5525 2019-07-17  Tom Tromey  <tom@tromey.com>
5526
5527         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
5528         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
5529         tui_last_regs_line_no.
5530         (tui_display_reg_element_at_line)
5531         (tui_display_registers_from_line): Update.
5532         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
5533         method.
5534
5535 2019-07-17  Tom Tromey  <tom@tromey.com>
5536
5537         PR tui/24722:
5538         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
5539         (tui_update_breakpoint_info): Add "being_deleted" parameter.
5540         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
5541         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
5542         (tui_update_breakpoint_info): Likewise.
5543         * tui/tui-hooks.c (tui_event_create_breakpoint)
5544         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
5545         Update.
5546
5547 2019-07-17  Tom Tromey  <tom@tromey.com>
5548
5549         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
5550
5551 2019-07-17  Tom Tromey  <tom@tromey.com>
5552
5553         * tui/tui-winsource.c (tui_update_source_window_as_is)
5554         (tui_update_source_windows_with_addr): Update.
5555         * tui/tui-source.h (tui_set_source_content)
5556         (tui_show_symtab_source): Add "win_info" parameter.
5557         * tui/tui-source.c (tui_set_source_content): Add "win_info"
5558         parameter.
5559         (tui_show_symtab_source): Likewise.
5560
5561 2019-07-17  Tom Tromey  <tom@tromey.com>
5562
5563         * tui/tui-wingeneral.c
5564         (tui_check_and_display_highlight_if_needed): Check can_highlight.
5565
5566 2019-07-17  Tom Tromey  <tom@tromey.com>
5567
5568         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
5569         (struct tui_cmd_window) <can_scroll>: New method.
5570         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
5571         method.
5572
5573 2019-07-17  Tom Tromey  <tromey@adacore.com>
5574
5575         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
5576         do_field_signed>: Rename.  Change type of "value".
5577         * ui-out.c (ui_out::field_signed): Rename from field_int.
5578         Change type of "value".
5579         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
5580         type of "value".
5581         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
5582         do_field_int.  Change type of "value".
5583         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
5584         do_field_int.  Change type of "value".
5585         * tracepoint.c (trace_status_mi, tfind_1)
5586         (print_one_static_tracepoint_marker): Update.
5587         * thread.c (print_thread_info_1, print_selected_thread_frame):
5588         Update.
5589         * stack.c (print_frame, print_frame_info): Update.
5590         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
5591         Update.
5592         * source.c (print_source_lines_base): Update.
5593         * skip.c (info_skip_command): Update.
5594         * record-btrace.c (btrace_ui_out_decode_error)
5595         (btrace_call_history_src_line): Update.
5596         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
5597         Update.
5598         * progspace.c (print_program_space): Update.
5599         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
5600         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
5601         do_field_int.  Change type of "value".
5602         * mi/mi-out.c (mi_ui_out::do_table_begin)
5603         (mi_ui_out::do_table_header): Update.
5604         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
5605         type of "value".
5606         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
5607         (mi_cmd_data_list_changed_registers, output_register)
5608         (mi_cmd_data_read_memory, mi_load_progress)
5609         (mi_cmd_trace_frame_collected): Update.
5610         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
5611         Update.
5612         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
5613         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
5614         (mi_cmd_var_list_children, varobj_update_one): Update.
5615         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
5616         (mi_cmd_stack_list_args, list_arg_or_local): Update.
5617         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
5618         * inferior.c (print_inferior): Update.
5619         * gdb_bfd.c (print_one_bfd): Update.
5620         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
5621         Update.
5622         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
5623         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
5624         do_field_int.  Change type of "value".
5625         * cli-out.c (cli_ui_out::do_field_signed): Rename from
5626         do_field_int.  Change type of "value".
5627         * breakpoint.c (watchpoint_check, print_breakpoint_location)
5628         (print_one_breakpoint_location, print_it_catch_fork)
5629         (print_one_catch_fork, print_it_catch_vfork)
5630         (print_one_catch_vfork, print_it_catch_solib)
5631         (print_it_catch_exec, print_it_ranged_breakpoint)
5632         (print_mention_watchpoint, print_mention_masked_watchpoint)
5633         (bkpt_print_it, update_static_tracepoint): Update.
5634         * break-catch-throw.c (print_it_exception_catchpoint): Update.
5635         * break-catch-syscall.c (print_it_catch_syscall): Update.
5636         * ada-tasks.c (print_ada_task_info): Update.
5637         * ada-lang.c (print_it_exception, print_mention_exception):
5638         Update.
5639
5640 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
5641
5642         PR breakpoints/24541
5643         * gdbarch.c: Regenerate.
5644         * gdbarch.h: Regenerate.
5645         * gdbarch.sh: Adjust return type and parameter types for
5646         'stap_adjust_register'.
5647         (i386_stap_adjust_register): Adjust signature and return new
5648         register name.
5649         * stap-probe.c (stap_parse_register_operand): Adjust use of
5650         'gdbarch_stap_adjust_register'.
5651
5652 2019-07-17  Tom Tromey  <tromey@adacore.com>
5653
5654         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
5655         declare VEC.
5656         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
5657         std::vector.
5658         (struct s390_process_info): Add initializers.
5659         (s390_add_process): Use new.
5660         (s390_linux_nat_target::low_forget_process): Use delete.
5661         (s390_linux_nat_target::low_new_fork)
5662         (s390_linux_nat_target::stopped_by_watchpoint)
5663         (s390_linux_nat_target::low_prepare_to_resume)
5664         (s390_linux_nat_target::insert_watchpoint)
5665         (s390_linux_nat_target::insert_hw_breakpoint)
5666         (s390_linux_nat_target::remove_watchpoint)
5667         (s390_linux_nat_target::remove_hw_breakpoint): Update.
5668
5669 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
5670
5671         * aarch64-fbsd-nat.c: Include regcache.h.
5672         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
5673         argument.
5674         (aarch64_fbsd_nat_target::fetch_registers)
5675         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
5676         variable.
5677         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
5678
5679 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
5680
5681         * fbsd-nat.c: Include gdbarch.h.
5682
5683 2019-07-15  Tom Tromey  <tromey@adacore.com>
5684
5685         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
5686
5687 2019-07-15  Tom Tromey  <tromey@adacore.com>
5688
5689         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
5690         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
5691         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
5692         * cli-out.c (cli_ui_out::do_field_int): New method.
5693         * ui-out.c (ui_out::field_unsigned): New method.
5694         * symfile.c (generic_load): Use field_unsigned.
5695         (print_transfer_performance): Likewise.
5696         * record-btrace.c (ui_out_field_uint): Remove.
5697         (btrace_call_history_insn_range, btrace_call_history): Use
5698         field_unsigned.
5699         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
5700         field_unsigned.
5701         * ui-out.h (class ui_out) <field_unsigned>: New method.
5702         <do_field_unsigned>: Likewise.
5703
5704 2019-07-15  Tom Tromey  <tromey@adacore.com>
5705
5706         * mi/mi-main.c (list_available_thread_groups): Use field_string.
5707         * mi/mi-interp.c (mi_memory_changed): Use field_string.
5708         * target.c (flash_erase_command): Use field_string.
5709         * infrun.c (print_signal_received_reason): Use field_string.
5710         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
5711         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
5712         field_string.
5713         * ada-tasks.c (print_ada_task_info): Use field_string.
5714
5715 2019-07-15  Tom Tromey  <tromey@adacore.com>
5716
5717         * target.c (flash_erase_command): Use field_core_addr.
5718         * symfile.c (generic_load): Use field_core_addr.
5719         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
5720         Use field_core_addr.
5721         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
5722         field_core_addr.
5723
5724 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
5725
5726         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
5727         value if its desired type is smaller than a CORE_ADDR and signed.
5728
5729 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
5730
5731         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
5732         of changes to field names, and use new is_reference field to
5733         decide if a property is a reference or not.
5734         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
5735         field.
5736         (struct dwarf2_property_baton): Update header comment, rename
5737         'referenced_type' to 'property_type' and update comments.
5738         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
5739         default property type, store in property baton, update to take
5740         accound of renamed field.
5741         (read_func_scope): Update call to attr_to_dynamic_prop.
5742         (read_array_type): Likewise.
5743         (dwarf2_per_cu_addr_sized_int_type): New function.
5744         (read_subrange_index_type): Move type finding code to
5745         dwarf2_per_cu_addr_sized_int_type.
5746         (read_subrange_type): Update calls to attr_to_dynamic_prop.
5747         (dwarf2_per_cu_addr_type): New function.
5748         (set_die_type): Update calls to attr_to_dynamic_prop.
5749
5750 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
5751
5752         * dwarf2read.c (read_subrange_index_type): New function.
5753         (read_subrange_type): Move code into new function and call it.
5754         * gdbtypes.c (create_range_type): Add some asserts.
5755
5756 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
5757
5758         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
5759         update return statements.
5760         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
5761         declaration, and update comment to match.
5762         * gdbtypes.c (resolve_dynamic_array): Update call to
5763         dwarf2_evaluate_property to match new return type.
5764
5765 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
5766
5767         * valarith.c (value_subscripted_rvalue): Change lowerbound
5768         parameter type from int to LONGEST.
5769         * value.h (value_subscripted_rvalue): Likewise in declaration.
5770
5771 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5772
5773         * cli/cli-utils.c (info_print_command_completer): New function.
5774         * cli/cli-utils.h: Add 'completer.h' include, and forward
5775         declaration for 'struct cmd_list_element'.
5776         (info_print_command_completer): Declare.
5777         * stack.c (_initialize_stack): Add completer for 'info locals' and
5778         'info args'.
5779         * symtab.c (_initialize_symtab): Add completer for 'info
5780         variables' and 'info functions'.
5781         * NEWS: Mention completion for additional info commands.
5782
5783 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5784
5785         * cli/cli-utils.c (extract_info_print_args): Delete.
5786         (extract_arg_maybe_quoted): Delete.
5787         (info_print_options_defs): New variable.
5788         (make_info_print_options_def_group): New function.
5789         (extract_info_print_options): Define new function.
5790         * cli/cli-utils.h (extract_info_print_args): Delete.
5791         (struct info_print_options): New structure.
5792         (extract_info_print_options): Declare new function.
5793         * stack.c (info_locals_command): Update to use new
5794         extract_info_print_options, also add a header comment.
5795         (info_args_command): Likewise.
5796         * symtab.c (info_variables_command): Likewise.
5797         (info_functions_command): Likewise.
5798
5799 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5800
5801         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
5802         to extract string arguments.
5803         * common/common-utils.c (extract_string_maybe_quoted): New function.
5804         * common/common-utils.h (extract_string_maybe_quoted): Declare.
5805
5806 2019-07-11  Tom Tromey  <tromey@adacore.com>
5807
5808         * main.c (get_init_files): Use GDBINIT, not gdbinit.
5809         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
5810         * top.h (gdbinit): Don't declare.
5811         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
5812         into...
5813         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
5814         * top.c (gdb_init): Don't call init_cli_cmds.
5815         (gdbinit): Remove.
5816         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
5817
5818 2019-07-11  Tom Tromey  <tromey@adacore.com>
5819
5820         * python/py-inferior.c (add_thread_object): Don't use thread_obj
5821         after it has been moved.
5822
5823 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
5824
5825         * valops.c (value_must_coerce_to_target): Change return type to
5826         bool.
5827         * value.h (value_must_coerce_to_target): Likewise.
5828
5829 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
5830
5831         * breakpoint.c (is_hardware_watchpoint): Remove
5832         forward-declaration.
5833         (is_masked_watchpoint): Change return type to bool.
5834         (is_tracepoint): Likewise.
5835         (is_breakpoint): Likewise.
5836         (is_hardware_watchpoint): Likewise.
5837         (is_watchpoint): Likewise.
5838         (is_no_memory_software_watchpoint): Likewise.
5839         (is_catchpoint): Likewise.
5840         (breakpoint_1): Make FILTER parameter's return type bool.
5841         is_masked_watchpoint): Change return type to bool.
5842         (save_breakpoints): Make FILTER parameter's return type bool.
5843         * breakpoint.h (is_breakpoint): Change return type to bool.
5844         (is_watchpoint): Likewise.
5845         (is_catchpoint): Likewise.
5846         (is_tracepoint): Likewise.
5847
5848 2019-07-10  Tom Tromey  <tom@tromey.com>
5849
5850         * defs.h: Don't include gdbarch.h.
5851         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
5852         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
5853         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
5854         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
5855         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
5856         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
5857         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
5858         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
5859         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
5860         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
5861         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
5862         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
5863         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
5864         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
5865         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
5866         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
5867         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
5868         record-btrace.c, record.h, regcache-dump.c, regcache.h,
5869         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
5870         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
5871         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
5872         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
5873         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
5874         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
5875         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
5876         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
5877         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
5878
5879 2019-07-10  Tom Tromey  <tromey@adacore.com>
5880
5881         * ada-lang.h (is_ada_exception_catchpoint): Declare.
5882         * breakpoint.c (init_ada_exception_breakpoint): Register as
5883         bp_catchpoint.
5884         (print_one_breakpoint_location, print_one_breakpoint): Use
5885         is_ada_exception_catchpoint.
5886         * ada-lang.c (class ada_catchpoint_location): Pass
5887         bp_loc_software_breakpoint to bp_location constructor.
5888         (is_ada_exception_catchpoint): New function.
5889
5890 2019-07-10  Tom Tromey  <tromey@adacore.com>
5891
5892         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
5893         VEC.
5894         (struct arm_exidx_entry): New method operator<.
5895         (struct arm_exidx_data) <section_maps>: Change type.
5896         (arm_exidx_data_free): Remove.
5897         (arm_exidx_data_key): Change type.  Move lower.
5898         (arm_exidx_new_objfile): Update.
5899         (arm_compare_exidx_entries): Remove.
5900         (arm_find_exidx_entry, _initialize_arm_tdep)
5901
5902 2019-07-10  Tom Tromey  <tromey@adacore.com>
5903
5904         * solib-spu.c (ocl_program_data_key): Change type.
5905         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
5906         Update.
5907
5908 2019-07-10  Tom Tromey  <tromey@adacore.com>
5909
5910         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
5911         (struct solib_aix_inferior_data) <library_list>: Change type.
5912         (solib_aix_inferior_data_handle): Change type.
5913         (get_solib_aix_inferior_data): Update.
5914         (solib_aix_free_library_list): Remove.
5915         (library_list_start_library): Update.
5916         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
5917         return type.
5918         (solib_aix_get_library_list)
5919         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
5920         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
5921
5922 2019-07-10  Tom Tromey  <tromey@adacore.com>
5923
5924         * solib-dsbt.c (struct dsbt_info): Add initializers.
5925         (solib_dsbt_pspace_data): Change type.
5926         (dsbt_pspace_data_cleanup): Remove.
5927         (get_dsbt_info, _initialize_dsbt_solib): Update.
5928
5929 2019-07-10  Tom Tromey  <tromey@adacore.com>
5930
5931         * spu-tdep.c (spu_overlay_data): Change type.
5932         (spu_get_overlay_table, spu_overlay_new_objfile)
5933         (_initialize_spu_tdep): Update.
5934
5935 2019-07-10  Tom Tromey  <tromey@adacore.com>
5936
5937         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
5938         destructor.
5939         (dbx_objfile_data_key): Change type and declare later.
5940         (DBX_SYMFILE_INFO): Rewrite.
5941         * dbxread.c (dbx_objfile_data_key): Change type.
5942         (dbx_symfile_init): Update.
5943         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
5944         (coffstab_build_psymtabs, elfstab_build_psymtabs)
5945         (stabsect_build_psymtabs, _initialize_dbxread): Update.
5946
5947 2019-07-10  Tom Tromey  <tromey@adacore.com>
5948
5949         * jit.c (jit_program_space_key): Change type.  Move lower.
5950         (get_jit_program_space_data): Update.
5951         (jit_program_space_data_cleanup): Remove.
5952         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
5953         Update.
5954         (struct jit_program_space_data): Add initializers.
5955
5956 2019-07-10  Tom Tromey  <tromey@adacore.com>
5957
5958         * solib-darwin.c (struct darwin_info): Add initializers.
5959         (solib_darwin_pspace_data): Change type.
5960         (darwin_pspace_data_cleanup): Remove.
5961         (get_darwin_info, _initialize_darwin_solib): Update.
5962
5963 2019-07-10  Tom Tromey  <tromey@adacore.com>
5964
5965         * remote-sim.c (struct sim_inferior_data): Add initializers,
5966         constructor, and destructor.
5967         (sim_inferior_data_key): Change type.  Move lower.
5968         (check_for_duplicate_sim_descriptor): Update.
5969         (get_sim_inferior_data): Use new.  Update.
5970         (~sim_inferior_data_cleanup): Rename from
5971         sim_inferior_data_cleanup.  Simplify.
5972         (gdbsim_close_inferior, simulator_command)
5973         (sim_command_completer, _initialize_remote_sim): Update.
5974         (next_pid, INITIAL_PID): Move earlier.
5975
5976 2019-07-10  Tom Tromey  <tromey@adacore.com>
5977
5978         * python/python-internal.h (create_thread_object): Return
5979         gdbpy_ref.
5980         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
5981         * python/py-inferior.c (struct threadlist_entry): Add
5982         constructor.
5983         <thread_obj>: Now a gdbpy_ref.
5984         (thread_to_thread_object): Update.
5985         (add_thread_object): Use new.
5986         (delete_thread_object): Use delete.
5987         (infpy_threads): Update.
5988         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
5989         GIL.
5990
5991 2019-07-10  Tom Tromey  <tromey@adacore.com>
5992
5993         * valops.c (value_cast): Specialize error message for Ada.
5994
5995 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
5996
5997         * breakpoint.c (breakpoint_1): Update doc and parameter names.
5998
5999 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
6000
6001         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
6002         bpstat_should_step): Return bool, adjust comments.
6003         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
6004         bpstat_should_step): Likewise.
6005
6006 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
6007
6008         * features/Makefile: Use feature target descriptions for Arm.
6009         * features/arm/arm-core.c: Generate new file.
6010         * features/arm/arm-fpa.c: Likewise.
6011         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
6012         * features/arm/arm-m-profile.c: Likewise.
6013         * features/arm/arm-vfpv2.c: Likewise.
6014         * features/arm/arm-vfpv3.c: Likewise.
6015         * features/arm/xscale-iwmmxt.c: Likewise.
6016         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
6017
6018 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
6019
6020         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
6021         ptrace earlier.
6022
6023 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
6024
6025         * features/aarch64-pauth.c: Regenerate.
6026
6027 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
6028
6029         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
6030         bool.
6031         (bpstat_what): Use false instead of 0.
6032
6033 2019-07-09  Pedro Alves  <palves@redhat.com>
6034
6035         * break-catch-throw.c (is_exception_catchpoint): New.
6036         * breakpoint.c (print_one_breakpoint_location): New parameter
6037         'raw_loc'.  Handle it.  Use
6038         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
6039         looking at the breakpoint's type.
6040         (print_one_breakpoint): If handling "maint info breakpoints", also
6041         print locations of exception catchpoints.
6042         * breakpoint.h (is_exception_catchpoint): Declare.
6043
6044 2019-07-09  Pedro Alves  <palves@redhat.com>
6045
6046         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
6047         "addr" field.
6048         (allocate_location_exception_catchpoint): New.
6049         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
6050         (initialize_throw_catchpoint_ops): Install
6051         allocate_location_exception_catchpoint as allocate_location
6052         method.
6053         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
6054         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
6055         bp_loc_other.
6056         (breakpoint_address_is_meaningful): Delete.
6057         (bl_address_is_meaningful): New.
6058         (breakpoint_locations_match): Adjust comment.
6059         (bp_location_from_bp_type): New, factored out of...
6060         (bp_location::bp_location(breakpoint *)): ... this.
6061         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
6062         factored out of...
6063         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
6064         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
6065         breakpoint_address_is_meaningful.
6066         (bp_locations_compare): Adjust comment.
6067         (update_global_location_list): Use bl_address_is_meaningful
6068         instead of breakpoint_address_is_meaningful.
6069         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
6070         explicit.
6071         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
6072         * python/py-breakpoint.c (bppy_get_location): No longer check
6073         whether location is null.
6074
6075 2019-07-09  Pedro Alves  <palves@redhat.com>
6076
6077         PR c++/15468
6078         * breakpoint.c (print_one_breakpoint_location): Remove
6079         single-location assert.
6080
6081 2019-07-09  Tom Tromey  <tom@tromey.com>
6082
6083         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
6084         * configure: Rebuild.
6085         * configure.ac: Change common to gdbsupport.
6086         * gdbsupport: Rename from common.
6087         * acinclude.m4: Change common to gdbsupport.
6088         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
6089         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
6090         gdbsupport.
6091         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
6092         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
6093         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
6094         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
6095         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
6096         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
6097         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
6098         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
6099         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
6100         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
6101         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
6102         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
6103         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
6104         coff-pe-read.c, command.h, compile/compile-c-support.c,
6105         compile/compile-c.h, compile/compile-cplus-symbols.c,
6106         compile/compile-cplus-types.c, compile/compile-cplus.h,
6107         compile/compile-loc2c.c, compile/compile.c, completer.c,
6108         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
6109         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
6110         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
6111         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
6112         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
6113         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
6114         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
6115         features/aarch64-core.c, features/aarch64-fpu.c,
6116         features/aarch64-pauth.c, features/aarch64-sve.c,
6117         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
6118         features/i386/32bit-core.c, features/i386/32bit-linux.c,
6119         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
6120         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
6121         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
6122         features/i386/64bit-core.c, features/i386/64bit-linux.c,
6123         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
6124         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
6125         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
6126         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
6127         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
6128         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
6129         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
6130         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
6131         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
6132         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
6133         go32-nat.c, guile/guile.c, guile/scm-ports.c,
6134         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
6135         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
6136         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
6137         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
6138         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
6139         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
6140         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
6141         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
6142         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
6143         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
6144         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
6145         minsyms.c, mips-linux-tdep.c, namespace.h,
6146         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
6147         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
6148         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
6149         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
6150         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
6151         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
6152         nat/linux-waitpid.c, nat/mips-linux-watch.c,
6153         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
6154         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
6155         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
6156         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
6157         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
6158         procfs.c, producer.c, progspace.h, psymtab.h,
6159         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
6160         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
6161         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
6162         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
6163         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
6164         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
6165         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
6166         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
6167         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
6168         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
6169         target-memory.c, target.c, target.h, target/waitstatus.c,
6170         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
6171         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
6172         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
6173         unittests/array-view-selftests.c,
6174         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
6175         unittests/common-utils-selftests.c,
6176         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
6177         unittests/format_pieces-selftests.c,
6178         unittests/function-view-selftests.c,
6179         unittests/lookup_name_info-selftests.c,
6180         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
6181         unittests/mkdir-recursive-selftests.c,
6182         unittests/observable-selftests.c,
6183         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
6184         unittests/parse-connection-spec-selftests.c,
6185         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
6186         unittests/scoped_fd-selftests.c,
6187         unittests/scoped_mmap-selftests.c,
6188         unittests/scoped_restore-selftests.c,
6189         unittests/string_view-selftests.c, unittests/style-selftests.c,
6190         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
6191         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
6192         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
6193         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
6194         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
6195         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
6196
6197 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
6198
6199         * linespec.c (decode_digits_list_mode): Set explicit_line to a
6200         bool value.
6201         (decode_digits_ordinary): Set explicit_line field in sal.
6202         * symtab.c (skip_prologue_sal): Don't skip prologue for a
6203         symtab_and_line that was set on an explicit line number in
6204         assembler code.  Do always update the recorded symtab and line if
6205         we do skip the prologue.
6206
6207 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
6208
6209         * breakpoint.c (set_breakpoint_location_function): Remove
6210         explicit_loc parameter.
6211         (momentary_breakpoint_from_master): Update call to
6212         set_breakpoint_location_function.
6213         (add_location_to_breakpoint): Likewise.
6214
6215 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
6216
6217         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
6218         required features based on default bfd type when no specific bfd
6219         is present.
6220
6221 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6222
6223         * NEWS: Mention that GDB printf and eval commands can now print
6224         C-style and Ada-style convenience var strings without
6225         calling the inferior.
6226         * printcmd.c (printf_c_string): Locally print GDB internal var
6227         instead of transiting via the inferior.
6228         (printf_wide_c_string): Likewise.
6229
6230 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
6231
6232         PR breakpoints/25011
6233         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
6234
6235 2019-07-04  Tom Tromey  <tom@tromey.com>
6236
6237         PR tui/24724:
6238         * tui/tui-winsource.c (tui_clear_source_content): Update.
6239         (tui_source_window_base::set_is_exec_point_at): Fix comment.
6240         (tui_update_breakpoint_info): Update.
6241         (tui_set_exec_info_content): Update.
6242         * tui/tui-source.c (tui_set_source_content_nil): Update.
6243         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
6244         has_break.
6245         * tui/tui-data.h (enum tui_bp_flag): New.
6246         (tui_bp_flags): New enum flags type.
6247         (struct tui_source_element) <break_mode>: Change type.  Rename
6248         from has_break.
6249         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
6250         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
6251         constants.
6252         * tui/tui-winsource.h: Fix comment.
6253
6254 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
6255
6256         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
6257         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
6258         (store_fpregs_to_thread)
6259         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
6260         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
6261         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
6262         (IWMMXT_REGS_SIZE): Add define.
6263         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
6264         (fetch_vfp_regs, store_vfp_regs)
6265         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
6266         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
6267
6268 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
6269
6270         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
6271         defines.
6272         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
6273         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
6274         (ARM_INT_REGISTER_SIZE): ...to this.
6275         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
6276         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
6277         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
6278         (arm_linux_collect_gregset, supply_nwfpe_register)
6279         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
6280         defines.
6281         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
6282         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
6283         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
6284         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
6285         (arm_return_in_memory, arm_store_return_value)
6286         (arm_get_longjmp_target, arm_register_g_packet_guesses)
6287         (arm_record_ld_st_multiple): Likewise.
6288         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
6289         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
6290
6291 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
6292
6293         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
6294         AARCH64_DISPLACED_MODIFIED_INSNS.
6295         * aarch64-tdep.c (struct aarch64_displaced_step_data)
6296         (aarch64_displaced_step_copy_insn): Likewise.
6297         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
6298         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
6299         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
6300         ARM_DISPLACED_MODIFIED_INSNS.
6301         * arm-tdep.c (arm_gdbarch_init): Likewise.
6302         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
6303         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
6304         (struct arm_displaced_step_closure): Use
6305         ARM_DISPLACED_MODIFIED_INSNS.
6306
6307 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
6308
6309         * features/Makefile: Remove unused xml files.
6310         * features/aarch64.xml: Remove.
6311         * features/i386/amd64-avx-avx512-linux.xml: Remove.
6312         * features/i386/amd64-avx-avx512.xml: Remove.
6313         * features/i386/amd64-avx-linux.xml: Remove.
6314         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
6315         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
6316         * features/i386/amd64-avx-mpx-linux.xml: Remove.
6317         * features/i386/amd64-avx-mpx.xml: Remove.
6318         * features/i386/amd64-avx.xml: Remove.
6319         * features/i386/amd64-linux.xml: Remove.
6320         * features/i386/amd64-mpx-linux.xml: Remove.
6321         * features/i386/amd64-mpx.xml: Remove.
6322         * features/i386/amd64.xml: Remove.
6323         * features/i386/i386-avx-avx512-linux.xml: Remove.
6324         * features/i386/i386-avx-avx512.xml: Remove.
6325         * features/i386/i386-avx-linux.xml: Remove.
6326         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
6327         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
6328         * features/i386/i386-avx-mpx-linux.xml: Remove.
6329         * features/i386/i386-avx-mpx.xml: Remove.
6330         * features/i386/i386-avx.xml: Remove.
6331         * features/i386/i386-linux.xml: Remove.
6332         * features/i386/i386-mmx-linux.xml: Remove.
6333         * features/i386/i386-mmx.xml: Remove.
6334         * features/i386/i386-mpx-linux.xml: Remove.
6335         * features/i386/i386-mpx.xml: Remove.
6336         * features/i386/i386.xml: Remove.
6337         * features/i386/x32-avx-avx512-linux.xml: Remove.
6338         * features/i386/x32-avx-linux.xml: Remove.
6339         * features/i386/x32-linux.xml: Remove.
6340
6341 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
6342
6343         * regformats/aarch64.dat: Remove.
6344         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
6345         * regformats/i386/amd64-avx-linux.dat: Remove.
6346         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
6347         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
6348         * regformats/i386/amd64-linux.dat: Remove.
6349         * regformats/i386/amd64-mpx-linux.dat: Remove.
6350         * regformats/i386/amd64.dat: Remove.
6351         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
6352         * regformats/i386/i386-avx-linux.dat: Remove.
6353         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
6354         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
6355         * regformats/i386/i386-linux.dat: Remove.
6356         * regformats/i386/i386-mmx-linux.dat: Remove.
6357         * regformats/i386/i386-mpx-linux.dat: Remove.
6358         * regformats/i386/i386.dat: Remove.
6359         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
6360         * regformats/i386/x32-avx-linux.dat: Remove.
6361         * regformats/i386/x32-linux.dat: Remove.
6362
6363 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
6364
6365         * aarch64-tdep.c: Remove xml self tests.
6366         * amd64-linux-tdep.c: Likewise.
6367         * amd64-tdep.c: Likewise.
6368         * i386-linux-tdep.c: Likewise.
6369         * i386-tdep.c: Likewise.
6370
6371 2019-07-03  Pedro Alves  <palves@redhat.com>
6372
6373         PR cli/24732
6374         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
6375         (pipe_cmd_option_defs): New.
6376         (make_pipe_cmd_options_def_group): New.
6377         (pipe_command): Use gdb::option::process_options.
6378         (pipe_command_completer): New function.
6379         (_initialize_cli_cmds): Install completer for "pipe" command.
6380
6381 2019-07-03  Pedro Alves  <palves@redhat.com>
6382
6383         * cli/cli-option.c (union option_value) <string>: New field.
6384         (struct option_def_and_value): Add ctor, move ctor, dtor and
6385         use DISABLE_COPY_AND_ASSIGN.
6386         (option_def_and_value::clear_value): New.
6387         (parse_option, save_option_value_in_ctx, get_val_type_str)
6388         (add_setshow_cmds_for_options): Handle var_string.
6389         * cli-option.h (union option_def::var_address) <string>: New
6390         field.
6391         (struct string_option_def): New.
6392         * maint-test-options.c (struct test_options_opts): Add default
6393         ctor and use DISABLE_COPY_AND_ASSIGN.
6394         <string_opt>: New field.
6395         (test_options_opts::~test_options_opts): New.
6396         (test_options_opts::dump): Also dump "-string".
6397         (test_options_option_defs): Install "string.
6398
6399 2019-07-03  Pedro Alves  <palves@redhat.com>
6400
6401         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
6402         option_value with a null enumeration.
6403         (complete_options): Save the option values in the context.
6404         (save_option_value_in_ctx): New, factored out from ...
6405         (process_options): ... here.
6406         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
6407         of the function.
6408         * maint-test-options.c (test_options_opts::dump): New, factored
6409         out from ...
6410         (maintenance_test_options_command_mode): ... here.
6411         (maintenance_test_options_command_completion_result): Delete.
6412         (maintenance_test_options_command_completion_text): Update
6413         comment.
6414         (maintenance_show_test_options_completion_result): Change
6415         prototype.  Just print
6416         maintenance_test_options_command_completion_text.
6417         (save_completion_result): New.
6418         (maintenance_test_options_completer_mode): Pass options context to
6419         complete_options, and then save a dump.
6420         (_initialize_maint_test_options): Use add_cmd to install "maint
6421         show test-options-completion-result".
6422
6423 2019-07-03  Pedro Alves  <palves@redhat.com>
6424
6425         * NEWS (New commands): Mention "with" and "maint with".
6426         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
6427         (with_command, with_command_completer): New.
6428         (pipe_command): Adjust to new repeat_previous
6429         interface.
6430         (_initialize_cli_cmds): Install the "with" command and its "w"
6431         alias.
6432         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
6433         declarations.
6434         * cli/cli-setshow.c (parse_cli_var_uinteger)
6435         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
6436         argument strings for all var_types.
6437         (get_setshow_command_value_string): New, factored out from ...
6438         (do_show_command): ... this.
6439         * cli/cli-setshow.h: Include <string>.
6440         (get_setshow_command_value_string): Declare.
6441         * command.h (repeat_previous): Now returns const char *.  Adjust
6442         comment.
6443         * maint.c: Include "cli/cli-cmds.h".
6444         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
6445         (_initialize_maint_cmds): Register the "maintenance with" command.
6446         * top.c (repeat_previous): Move bits from pipe_command here:
6447         Return the saved command line, if any; error out if there's no
6448         command to relaunch.
6449
6450 2019-07-03  Pedro Alves  <palves@redhat.com>
6451
6452         * NEWS (New commands): Mention "maint set/show test-settings"
6453         instead of "maint test-settings".
6454         * maint-test-settings.c (maintenance_test_settings_list): Delete.
6455         (maintenance_test_settings_set_list): Rename to ...
6456         (maintenance_set_test_settings_list): ... this.
6457         (maintenance_test_settings_show_list): Rename to  ...
6458         (maintenance_show_test_settings_list): ... this.
6459         (maintenance_test_settings_cmd): Delete.
6460         (maintenance_test_settings_set_cmd): ...
6461         (maintenance_set_test_settings_cmd): ... this.
6462         (maintenance_test_settings_show_cmd): ...
6463         (maintenance_show_test_settings_cmd): ... this.
6464         (maintenance_test_settings_show_value_cmd):
6465         (maintenance_show_test_settings_value_cmd): ... this.
6466         (_initialize_maint_test_settings): No longer install the "maint
6467         test-settings" prefix command.  Rename "maint test-settings set"
6468         to "maint set test-settings", and "maint test-settings show" to
6469         "maint show test-settings".  Adjust all subcommands.
6470
6471 2019-07-03  Pedro Alves  <palves@redhat.com>
6472
6473         * maint-test-settings.c: Fix file's intro comment.  Replace all
6474         references to "test-options" with references to "test-settings",
6475         in comments.
6476
6477 2019-07-03  Pedro Alves  <palves@redhat.com>
6478
6479         * maint-test-settings.c (maintenance_test_settings_xxx)
6480         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
6481         New.
6482         (maintenance_test_settings_enums): Use them.
6483         (maintenance_test_settings_enum): Default to
6484         maintenance_test_settings_xxx.
6485         (_initialize_maint_test_settings): Initialize
6486         MAINTENANCE_TEST_SETTINGS_FILENAME.
6487
6488 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
6489
6490         * breakpoint.h (remove_breakpoints_inf): Change return type to
6491         void, move function documentation here.
6492         * breakpoint.c (remove_breakpoints_inf): Change return type to
6493         void, move function documentation to header.
6494
6495 2019-07-02  Pedro Alves  <palves@redhat.com>
6496
6497         * NEWS (Completion improvements): Mention "info threads".
6498         * thread.c (struct info_threads_opts, info_threads_option_defs)
6499         (make_info_threads_options_def_group): New.
6500         (info_threads_command): Use gdb::option::process_options.
6501         (info_threads_command_completer): New.
6502         (_initialize_thread): Use gdb::option::build_help to build the
6503         help text for "info threads".
6504
6505 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
6506
6507         * defs.h (generic_load): Move from here...
6508         * symfile.h (generic_load): ... to here.  Rename name parameter
6509         to args.
6510         * symfile.c (generic_load): Add comment.
6511
6512 2019-07-01  Tom Tromey  <tromey@adacore.com>
6513
6514         * dwarf2read.c
6515         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
6516         declaration of without_params.  Fix formatting.
6517
6518 2019-07-01  Tom Tromey  <tromey@adacore.com>
6519
6520         * ada-exp.y (find_primitive_type): Update.
6521         * ada-lang.h (ada_lookup_symbol): Update.
6522         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
6523         parameter.
6524         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
6525
6526 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
6527
6528         PR breakpoints/24541
6529         * gdbarch.c: Regenerate.
6530         * gdbarch.h: Regenerate.
6531         * gdbarch.sh: Add 'stap_adjust_register'.
6532         * i386-tdep.c: Include '<unordered_set>'.
6533         (i386_stap_adjust_register): New function.
6534         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
6535         * stap-probe.c (stap_parse_register_operand): Call
6536         'gdbarch_stap_adjust_register'.
6537
6538 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
6539
6540         PR python/24742
6541         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
6542         * python/python.c (do_start_initialization): Use 'xmalloc'
6543         instead of 'PyMem_Malloc'.
6544
6545 2019-06-28  Tom Tromey  <tromey@adacore.com>
6546
6547         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
6548         for Ada.
6549
6550 2019-06-27  Tom Tromey  <tromey@adacore.com>
6551
6552         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
6553         objfile_key.
6554         (arm_find_mapping_symbol, arm_record_special_symbol)
6555         (_initialize_arm_tdep): Update.
6556         (arm_objfile_data_free): Remove.
6557
6558 2019-06-27  Tom Tromey  <tromey@adacore.com>
6559
6560         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
6561         to cp_print_static_field.
6562
6563 2019-06-26  Tom Tromey  <tromey@adacore.com>
6564
6565         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
6566         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
6567         declare.
6568
6569 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
6570
6571         * features/aarch64-core.c (create_feature_aarch64_core):
6572         Regenerate.
6573         * features/aarch64-core.xml: Add cpsr flags.
6574
6575 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
6576
6577         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
6578         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
6579
6580 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
6581
6582         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
6583         field.
6584         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
6585         use.
6586         (arm_record_special_symbol): Don't insert new symbol in sorted
6587         position, push it at the end.
6588
6589 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
6590
6591         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
6592         (arm_mapping_symbol_s): Remove.
6593         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
6594         (arm_mapping_symbol_vec): New typedef.
6595         (struct arm_per_objfile): Add constructor.
6596         <section_maps>: Change type to
6597         std::unique_ptr<arm_mapping_symbol_vec[]>.
6598         (arm_compare_mapping_symbols): Remove.
6599         (arm_find_mapping_symbol): Adjust to section_maps type change.
6600         (arm_objfile_data_free): Call delete on arm_per_objfile.
6601         (arm_record_special_symbol): Adjust to section_maps type change.
6602         Allocate arm_per_objfile with new.
6603
6604 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6605
6606         * cli/cli-cmds.c (alias_command): Compare the alias prefix
6607         with the command prefix.
6608
6609 2019-06-25  Tom Tromey  <tom@tromey.com>
6610
6611         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
6612         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
6613
6614 2019-06-25  Tom Tromey  <tom@tromey.com>
6615
6616         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
6617         type.
6618         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
6619         protected.
6620
6621 2019-06-25  Tom Tromey  <tom@tromey.com>
6622
6623         * tui/tui-winsource.c
6624         (tui_source_window_base::set_is_exec_point_at): Add check against
6625         LOA_ADDRESS.
6626
6627 2019-06-25  Tom Tromey  <tom@tromey.com>
6628
6629         * tui/tui-source.c (tui_set_source_content): Don't check before
6630         xfree.
6631         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
6632
6633 2019-06-25  Tom Tromey  <tom@tromey.com>
6634
6635         * tui/tui-winsource.h (tui_update_source_window_as_is)
6636         (tui_alloc_source_buffer, tui_line_is_displayed)
6637         (tui_addr_is_displayed): Change type of win_info.
6638         * tui/tui-winsource.c (tui_update_source_window_as_is)
6639         (tui_clear_source_content, tui_show_source_line)
6640         (tui_show_source_content, tui_source_window_base::refill)
6641         (tui_source_window_base::set_is_exec_point_at)
6642         (tui_source_window_base::set_is_exec_point_at)
6643         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
6644         (tui_alloc_source_buffer, tui_line_is_displayed)
6645         (tui_addr_is_displayed): Change type of win_info.  Update.
6646         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
6647         (tui_source_window_base::do_make_visible_with_new_height):
6648         Update.
6649         * tui/tui-source.c (tui_set_source_content)
6650         (tui_set_source_content_nil)
6651         (tui_source_window::do_scroll_vertical): Update.
6652         * tui/tui-layout.c (show_layout): Update.
6653         * tui/tui-disasm.c (tui_set_disassem_content)
6654         (tui_disasm_window::do_scroll_vertical): Update.
6655         * tui/tui-data.h (tui_win_content): Remove.
6656         (struct tui_gen_win_info) <content, content_size>: Remove.
6657         (struct tui_source_element): Add initializers and destructor.
6658         (union tui_which_element, struct tui_win_element): Remove.
6659         (struct tui_source_window_base) <content>: New field.
6660         (struct tui_data_window): Remove destructor.
6661         (tui_alloc_content, tui_free_win_content)
6662         (tui_free_all_source_wins_content): Don't declare.
6663         * tui/tui-data.c (tui_initialize_static_data): Update.
6664         (init_content_element, tui_alloc_content): Remove.
6665         (~tui_gen_win_info): Update.
6666         (~tui_data_window, tui_free_all_source_wins_content)
6667         (tui_free_win_content, free_content, free_content_elements):
6668         Remove.
6669
6670 2019-06-25  Tom Tromey  <tom@tromey.com>
6671
6672         * tui/tui-winsource.h (tui_clear_source_content)
6673         (tui_erase_source_content, tui_show_source_content): Change type
6674         of win_info.
6675         * tui/tui-winsource.c (tui_clear_source_content)
6676         (tui_erase_source_content, tui_show_source_content): Change type
6677         of win_info.
6678         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
6679         * tui/tui-source.h (tui_set_source_content_nil): Change type of
6680         win_info.
6681         * tui/tui-source.c (tui_set_source_content_nil): Change type of
6682         win_info.
6683         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
6684
6685 2019-06-25  Tom Tromey  <tom@tromey.com>
6686
6687         * tui/tui-winsource.c (tui_clear_source_content)
6688         (tui_source_window_base::set_is_exec_point_at): Update.
6689         * tui/tui-source.c (tui_set_source_content_nil): Update.
6690         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
6691         a bool.
6692         * tui/tui-data.c (init_content_element): Update.
6693
6694 2019-06-25  Tom Tromey  <tom@tromey.com>
6695
6696         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
6697         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
6698         * tui/tui-layout.c (init_and_make_win): Update.
6699         * tui/tui.h (enum tui_win_type): Update.
6700         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
6701         tui_win_is_auxillary.
6702         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
6703         tui_win_is_auxillary.
6704
6705 2019-06-25  Tom Tromey  <tom@tromey.com>
6706
6707         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
6708         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
6709         (tui_delete_data_content_windows, tui_display_all_data)
6710         (tui_data_window::do_scroll_vertical, tui_display_data_from):
6711         Update.
6712         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
6713         * tui/tui-regs.c (tui_last_regs_line_no)
6714         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
6715         (tui_show_registers): Update.
6716         (tui_show_register_group): Return void.  Update.
6717         (tui_display_registers_from, tui_display_reg_element_at_line)
6718         (tui_display_registers_from_line, tui_check_register_values):
6719         Update.
6720         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
6721         member.
6722         (struct tui_data_window) <regs_content>: Now a std::vector.
6723         <regs_content_count>: Remove.
6724         (tui_add_content_elements, tui_free_data_content): Don't declare.
6725         * tui/tui-data.c (tui_data_window::clear_detail): Update.
6726         (init_content_element): Remove DATA_WIN case.  Add assert.
6727         (tui_add_content_elements): Remove.
6728         (tui_data_window): Update.
6729         (tui_free_data_content): Remove.
6730         (free_content_elements): Remove DATA_WIN case.
6731
6732 2019-06-25  Tom Tromey  <tom@tromey.com>
6733
6734         * tui/tui-data.c (tui_data_item_window): Update.
6735         * tui/tui-windata.h (tui_check_data_values): Don't declare.
6736         * tui/tui-windata.c (tui_display_all_data)
6737         (tui_display_data_from_line): Update.
6738         (tui_check_data_values): Remove.
6739         * tui/tui-regs.c (tui_show_register_group)
6740         (tui_display_reg_element_at_line): Update.
6741         * tui/tui-hooks.c (tui_register_changed)
6742         (tui_refresh_frame_and_register_information): Call
6743         tui_check_register_values.
6744         * tui/tui-data.h (struct tui_data_window) <data_content,
6745         data_content_count, data_type>: Remove.
6746         (enum tui_data_type): Remove.
6747
6748         * tui/tui-data.c (tui_data_window::clear_detail)
6749         (~tui_data_window): Update.
6750
6751 2019-06-25  Tom Tromey  <tom@tromey.com>
6752
6753         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
6754         declare.
6755         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
6756         Rename from tui_first_data_item_displayed.  Update.
6757         (tui_data_window::refresh_all)
6758         (tui_data_window::do_scroll_vertical): Update.
6759         * tui/tui-data.h (struct tui_data_window)
6760         <first_data_item_displayed>: Declare new method.
6761
6762 2019-06-25  Tom Tromey  <tom@tromey.com>
6763
6764         * tui/tui-data.h (tui_init_generic_part): Don't declare.
6765         * tui/tui-data.c (tui_init_generic_part): Remove, moving
6766         contents...
6767         (tui_initialize_static_data): ...here.
6768
6769 2019-06-25  Tom Tromey  <tom@tromey.com>
6770
6771         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
6772         (tui_display_registers_from, tui_check_register_values): Update.
6773         (tui_display_register): Remove win_info parameter; update.
6774         (tui_get_register): Change type of parameters.
6775         * tui/tui-data.h (struct tui_data_element): Remove.
6776         (union tui_which_element) <data>: Remove.
6777         <data_window>: Change type.
6778         (struct tui_data_item_window): New.
6779         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
6780         case.  Add assert.
6781         (~tui_data_item_window): New destructor.
6782         (free_content_elements): Remove DATA_ITEM_WIN case.
6783
6784 2019-06-25  Tom Tromey  <tom@tromey.com>
6785
6786         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
6787         Remove.
6788
6789 2019-06-25  Tom Tromey  <tom@tromey.com>
6790
6791         * tui/tui-data.h (struct tui_command_element): Remove.
6792         (union tui_which_element) <command>: Remove.
6793         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
6794         assert.
6795         (free_content_elements): Remove CMD_WIN case.
6796
6797 2019-06-25  Tom Tromey  <tom@tromey.com>
6798
6799         * tui/tui-layout.c (tui_set_layout): Update.
6800         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
6801         * tui/tui-data.c (layout_def): Update.
6802
6803 2019-06-25  Tom Tromey  <tom@tromey.com>
6804
6805         * tui/tui-wingeneral.c (tui_refresh_all): Update.
6806         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
6807         (tui_source_window_base::set_new_height): Update.
6808         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
6809         Update.
6810         (tui_set_locator_fullname, tui_set_locator_info)
6811         (tui_show_frame_info): Update.
6812         * tui/tui-source.c (tui_set_source_content)
6813         (tui_source_is_displayed): Update.
6814         * tui/tui-layout.c (show_source_disasm_command, show_data)
6815         (show_source_or_disasm_and_command): Update.
6816         * tui/tui-disasm.c (tui_set_disassem_content)
6817         (tui_get_begin_asm_address): Update.
6818         * tui/tui-data.h (struct tui_locator_element): Remove.
6819         (union tui_which_element) <locator>: Remove.
6820         (struct tui_locator_window): New.
6821         (tui_locator_win_info_ptr): Change return type.
6822         * tui/tui-data.c (_locator): Change type.
6823         (tui_locator_win_info_ptr): Change return type.
6824         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
6825         (tui_alloc_content): Add assert.
6826
6827 2019-06-25  Tom Tromey  <tom@tromey.com>
6828
6829         * tui/tui-winsource.c
6830         (tui_exec_info_window::maybe_allocate_content): New method.
6831         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
6832         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
6833         (make_source_or_disasm_window): Add cast.
6834         * tui/tui-data.h (union tui_which_element) <simple_string>:
6835         Remove.
6836         (struct tui_source_info): New.
6837         (struct tui_source_window_base) <execution_info>: Change type.
6838         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
6839         case, and add assert.
6840         (tui_alloc_content): Add assert.
6841
6842 2019-06-25  Tom Tromey  <tom@tromey.com>
6843
6844         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
6845         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
6846         * tui/tui-data.c (tui_alloc_win_info): Remove.
6847
6848 2019-06-25  Tom Tromey  <tom@tromey.com>
6849
6850         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
6851         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
6852         can_highlight.
6853
6854 2019-06-25  Tom Tromey  <tom@tromey.com>
6855
6856         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
6857         make_visible_with_new_height method.
6858         (tui_win_info::make_visible_with_new_height): New method.
6859         (tui_source_window_base::do_make_visible_with_new_height)
6860         (tui_data_window::do_make_visible_with_new_height)
6861         (tui_cmd_window::do_make_visible_with_new_height): New methods.
6862         (make_visible_with_new_height): Remove.
6863         (tui_resize_all, tui_adjust_win_heights): Use
6864         make_visible_with_new_height method.
6865         * tui/tui-data.h (struct tui_win_info)
6866         <do_make_visible_with_new_height, make_visible_with_new_height>:
6867         New methods.
6868         (struct tui_source_window_base, struct tui_data_window)
6869         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
6870         methods.
6871
6872 2019-06-25  Tom Tromey  <tom@tromey.com>
6873
6874         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
6875         method.
6876         (update_tab_width): Call update_tab_width method.
6877         * tui/tui-data.h (struct tui_win_info)
6878         (struct tui_source_window_base) <update_tab_width>: New methods.
6879
6880 2019-06-25  Tom Tromey  <tom@tromey.com>
6881
6882         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
6883         parameter.
6884         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
6885         parameter.
6886         (tui_gen_win_info::make_visible): Update.
6887         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
6888         parameter.
6889         * tui/tui-data.h (enum tui_box): New enum.
6890         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
6891
6892 2019-06-25  Tom Tromey  <tom@tromey.com>
6893
6894         * tui/tui-layout.c (make_source_or_disasm_window): Always use
6895         init_and_make_win for EXEC_INFO_WIN.
6896         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
6897         longer inline.
6898         (struct tui_win_info) <~tui_win_info>: Inline.
6899         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
6900         Don't declare.
6901         * tui/tui-data.c (source_win, disasm_win): Remove globals.
6902         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
6903         Remove.
6904         (tui_initialize_static_data): Update.
6905         (~tui_gen_win_info): Handle more cleanup here.
6906         (~tui_source_window_base): Delete "execution_info".
6907         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
6908
6909 2019-06-25  Tom Tromey  <tom@tromey.com>
6910
6911         * tui/tui-layout.c (make_command_window): Don't set
6912         can_highlight.
6913         (show_source_disasm_command): Call the reset method.
6914         (show_data): Don't set can_highlight.  Call the reset method.
6915         (tui_gen_win_info::reset): Rename from init_gen_win_info
6916         (init_and_make_win): Simplify.  Return tui_gen_win_info.
6917         (show_source_or_disasm_and_command): Call the reset method.
6918         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
6919         (struct tui_cmd_window): Set can_highlight.
6920
6921 2019-06-25  Tom Tromey  <tom@tromey.com>
6922
6923         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
6924         from make_visible.
6925         (tui_make_visible, tui_make_invisible): Rewrite.
6926         (tui_win_info::make_visible): Remove.
6927         (tui_source_window_base::make_visible): Update.
6928         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
6929         method.  Moved from...
6930         (struct tui_win_info) <make_visible>: ...here.
6931
6932 2019-06-25  Tom Tromey  <tom@tromey.com>
6933
6934         * tui/tui-winsource.c
6935         (tui_source_window_base::do_scroll_horizontal): Remove direction
6936         parameter.
6937         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
6938         direction parameter.
6939         * tui/tui-win.c (tui_win_info::forward_scroll)
6940         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
6941         (tui_win_info::right_scroll): Update.
6942         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
6943         direction parameter.
6944         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
6945         direction parameter.
6946         * tui/tui-data.h (enum tui_scroll_direction): Remove.
6947         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
6948         Remove direction parameter.
6949         (struct tui_source_window_base, struct tui_source_window)
6950         (struct tui_disasm_window, struct tui_data_window)
6951         (struct tui_cmd_window): Update.
6952
6953 2019-06-25  Tom Tromey  <tom@tromey.com>
6954
6955         * tui/tui-winsource.h (tui_set_exec_info_content)
6956         (tui_show_exec_info_content, tui_erase_exec_info_content)
6957         (tui_clear_exec_info_content, tui_update_exec_info): Change
6958         argument to tui_source_window_base.
6959         * tui/tui-winsource.c (tui_set_exec_info_content)
6960         (tui_show_exec_info_content, tui_erase_exec_info_content)
6961         (tui_clear_exec_info_content, tui_update_exec_info): Change
6962         argument to tui_source_window_base.
6963
6964 2019-06-25  Tom Tromey  <tom@tromey.com>
6965
6966         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
6967         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
6968
6969 2019-06-25  Tom Tromey  <tom@tromey.com>
6970
6971         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
6972         check.
6973
6974 2019-06-25  Tom Tromey  <tom@tromey.com>
6975
6976         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
6977         type to void.
6978         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
6979         type to void.
6980         * tui/tui-source.c (tui_set_source_content): Update.
6981         * tui/tui-disasm.c (tui_set_disassem_content): Update.
6982
6983 2019-06-25  Tom Tromey  <tom@tromey.com>
6984
6985         * tui/tui-win.c (window_name_completer, tui_set_focus)
6986         (tui_all_windows_info): Use name method.
6987         * tui/tui-data.h (struct tui_gen_win_info)
6988         (struct tui_source_window, struct tui_disasm_window)
6989         (struct tui_data_window, struct tui_cmd_window) <name>: New
6990         method.
6991         (tui_win_name): Don't declare.
6992         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
6993         (tui_win_name): Remove.
6994
6995 2019-06-25  Tom Tromey  <tom@tromey.com>
6996
6997         * tui/tui-winsource.h (tui_update_source_window)
6998         (tui_update_source_window_as_is): Change parameter type.
6999         * tui/tui-winsource.c (tui_update_source_window): Change win_info
7000         to be a tui_source_window_base.
7001         (tui_update_source_window_as_is): Likewise.
7002         * tui/tui-win.c (make_visible_with_new_height): Update.
7003
7004 2019-06-25  Tom Tromey  <tom@tromey.com>
7005
7006         * tui/tui-winsource.c (tui_erase_source_content)
7007         (tui_show_source_content, tui_show_exec_info_content)
7008         (tui_erase_exec_info_content): Use refresh_window method.
7009         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
7010         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
7011         from tui_refresh_win.
7012         (tui_data_window::refresh_window): New method.
7013         (tui_win_info::refresh, tui_source_window_base::refresh)
7014         (tui_refresh_all): Use refresh_window method.
7015         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
7016         method.
7017         * tui/tui-regs.c (tui_display_register): Call refresh_window
7018         method.
7019         * tui/tui-layout.c (show_source_disasm_command)
7020         (show_source_or_disasm_and_command): Call refresh_window method.
7021         * tui/tui-data.h (struct tui_gen_win_info)
7022         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
7023         New method.
7024
7025 2019-06-25  Tom Tromey  <tom@tromey.com>
7026
7027         * tui/tui.c (tui_rl_other_window, tui_enable)
7028         (tui_is_window_visible, tui_get_command_dimension): Update.
7029         * tui/tui-winsource.c (tui_update_source_window_as_is)
7030         (tui_clear_source_content, tui_erase_source_content)
7031         (tui_show_source_line, tui_source_window_base::refill)
7032         (tui_source_window_base::do_scroll_horizontal)
7033         (tui_source_window_base::set_is_exec_point_at)
7034         (tui_update_breakpoint_info, tui_set_exec_info_content)
7035         (tui_alloc_source_buffer, tui_line_is_displayed)
7036         (tui_addr_is_displayed): Update.
7037         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
7038         (tui_check_and_display_highlight_if_needed)
7039         (tui_win_info::make_visible, tui_win_info::refresh)
7040         (tui_refresh_all): Update.
7041         * tui/tui-windata.c (tui_first_data_item_displayed)
7042         (tui_delete_data_content_windows, tui_erase_data_content)
7043         (tui_display_all_data, tui_data_window::refresh_all)
7044         (tui_check_data_values): Update.
7045         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
7046         (tui_set_win_focus_to, tui_win_info::forward_scroll)
7047         (tui_win_info::backward_scroll, tui_refresh_all_win)
7048         (tui_resize_all, tui_set_focus, tui_all_windows_info)
7049         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
7050         (tui_source_window_base::set_new_height)
7051         (tui_data_window::set_new_height)
7052         (make_invisible_and_set_new_height)
7053         (make_visible_with_new_height, new_height_ok)
7054         (parse_scrolling_args): Update.
7055         * tui/tui-stack.c (tui_show_frame_info): Update.
7056         * tui/tui-source.c (tui_set_source_content)
7057         (tui_set_source_content_nil, tui_source_is_displayed)
7058         (tui_source_window::do_scroll_vertical): Update.
7059         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
7060         (tui_display_registers_from, tui_display_reg_element_at_line)
7061         (tui_check_register_values, tui_reg_command): Update.
7062         * tui/tui-layout.c (tui_default_win_height)
7063         (show_source_disasm_command, show_data, init_and_make_win)
7064         (show_source_or_disasm_and_command): Update.
7065         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
7066         (tui_redisplay_readline, tui_mld_flush)
7067         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
7068         (tui_getc): Update.
7069         * tui/tui-disasm.c (tui_set_disassem_content)
7070         (tui_disasm_window::do_scroll_vertical): Update.
7071         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
7072         Now virtual.
7073         (struct tui_win_info): Derive from tui_gen_win_info.
7074         <~tui_win_info>: Mark as override.
7075         <generic>: Remove member.
7076         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
7077         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
7078         (~tui_data_window, ~tui_win_info)
7079         (tui_free_all_source_wins_content): Update.
7080         * tui/tui-command.c (tui_refresh_cmd_win): Update.
7081
7082 2019-06-25  Tom Tromey  <tom@tromey.com>
7083
7084         * tui/tui-layout.c (init_and_make_win): Use new.
7085         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
7086         destructor, initializers.
7087         (tui_alloc_generic_win_info): Don't declare.
7088         * tui/tui-data.c (_locator): Add argument to constructor.
7089         (source_win, disasm_win): New globals.
7090         (exec_info): Remove.
7091         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
7092         Update.
7093         (tui_alloc_generic_win_info): Remove.
7094         (init_content_element): Use new.
7095         (tui_win_info::tui_win_info): Update.
7096         (free_content_elements) <case DATA_WIN>: Use delete.
7097
7098 2019-06-25  Tom Tromey  <tom@tromey.com>
7099
7100         * tui/tui-wingeneral.c (tui_refresh_win): Update.
7101         * tui/tui-windata.c (tui_first_data_item_displayed)
7102         (tui_delete_data_content_windows): Update.
7103         * tui/tui-win.c (tui_data_window::set_new_height): Update.
7104         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
7105         (tui_display_registers_from, tui_check_register_values): Update.
7106         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
7107         pointer.
7108         * tui/tui-data.c (init_content_element): Update.  Allocate the new
7109         window.
7110         (tui_free_data_content): Update.
7111         (free_content_elements) <case DATA_WIN>: Free the window.
7112
7113 2019-06-25  Tom Tromey  <tom@tromey.com>
7114
7115         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
7116         Update.
7117         * tui/tui-layout.c (make_command_window)
7118         (show_source_disasm_command, show_data, init_and_make_win)
7119         (show_source_or_disasm_and_command): Update.
7120         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
7121         method.
7122         <can_highight, is_highlighted>: Now bool.
7123         (tui_set_win_highlight): Don't declare.
7124         * tui/tui-data.c (tui_set_win_highlight): Remove.
7125
7126 2019-06-25  Tom Tromey  <tom@tromey.com>
7127
7128         * tui/tui-wingeneral.c (make_visible): Remove check of window
7129         type.
7130
7131 2019-06-25  Tom Tromey  <tom@tromey.com>
7132
7133         * tui/tui-win.c (tui_win_info::max_height)
7134         (tui_cmd_window::max_height): New methods.
7135         (new_height_ok): Call max_height.
7136         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
7137         <max_height>: New method.
7138
7139 2019-06-25  Tom Tromey  <tom@tromey.com>
7140
7141         * tui/tui-win.c (tui_source_window_base::set_new_height)
7142         (tui_data_window::set_new_height): New methods.
7143         (make_invisible_and_set_new_height): Call set_new_height method.
7144         * tui/tui-data.h (struct tui_win_info)
7145         (struct tui_source_window_base, struct tui_data_window)
7146         <set_new_height>: New method.
7147
7148 2019-06-25  Tom Tromey  <tom@tromey.com>
7149
7150         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
7151         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
7152         tui_refresh_data_win.
7153         * tui/tui-win.c (tui_source_window_base::refresh_all): New
7154         method.
7155         (tui_refresh_all_win): Call the refresh_all method.
7156         (tui_set_focus): Likewise.
7157         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
7158         (struct tui_source_window_base, struct tui_data_window) <refresh>:
7159         Likewise.
7160
7161 2019-06-25  Tom Tromey  <tom@tromey.com>
7162
7163         * tui/tui-winsource.h (tui_refill_source_window)
7164         (tui_set_is_exec_point_at): Don't declare.
7165         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
7166         (tui_source_window_base::refill): Rename from
7167         tui_refill_source_window.
7168         (tui_source_window_base::do_scroll_horizontal): Update.
7169         (tui_source_window_base::set_is_exec_point_at): Rename from
7170         tui_set_is_exec_point_at.
7171         (tui_update_all_breakpoint_info): Update.
7172         * tui/tui-stack.c (tui_show_frame_info): Update.
7173         * tui/tui-layout.c (show_data): Add cast.
7174         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
7175         * tui/tui-data.h (struct tui_source_window_base) <refill,
7176         set_is_exec_point_at>: New methods.
7177         (tui_source_windows, tui_add_to_source_windows): Update types.
7178         (tui_add_to_source_windows): Remove redundant declaration.
7179         * tui/tui-data.c (source_windows): Store tui_source_window_base.
7180         (tui_source_windows): Change return type.
7181         (tui_clear_source_windows_detail): Update.
7182         (tui_add_to_source_windows): Change type of parameter.
7183         (tui_free_all_source_wins_content): Update.
7184
7185 2019-06-25  Tom Tromey  <tom@tromey.com>
7186
7187         * tui/tui-wingeneral.c (tui_win_info::refresh)
7188         (tui_source_window_base::refresh): New methods.
7189         (tui_refresh_all): Call the refresh method.
7190         * tui/tui-data.h (struct tui_win_info)
7191         (struct tui_source_window_base) <refresh>: New method.
7192
7193 2019-06-25  Tom Tromey  <tom@tromey.com>
7194
7195         * tui/tui.h (tui_is_window_visible): Return bool.
7196         * tui/tui.c (tui_is_window_visible): Return bool.
7197         * tui/tui-wingeneral.c (tui_make_window, make_visible)
7198         (tui_make_visible, tui_make_invisible)
7199         (tui_win_info::make_visible)
7200         (tui_source_window_base::make_visible, make_all_visible)
7201         (tui_make_all_visible, tui_make_all_invisible): Update.
7202         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
7203         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
7204         bool.
7205         (struct tui_win_info, struct tui_source_window_base)
7206         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
7207         * tui/tui-data.c (tui_init_generic_part): Update.
7208
7209 2019-06-25  Tom Tromey  <tom@tromey.com>
7210
7211         * tui/tui-wingeneral.c (tui_win_info::make_visible)
7212         (tui_source_window_base::make_visible): New methods.
7213         (make_all_visible): Make method call.
7214         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
7215         (struct tui_source_window_base, struct tui_cmd_window): Override
7216         make_visible.
7217         (tui_win_is_source_type): Don't declare.
7218         * tui/tui-data.c (tui_win_is_source_type): Remove.
7219
7220 2019-06-25  Tom Tromey  <tom@tromey.com>
7221
7222         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
7223         NULL check.
7224
7225 2019-06-25  Tom Tromey  <tom@tromey.com>
7226
7227         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
7228         Inline constructor.  Add initializers for members.
7229         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
7230         constructors; now inline in class.
7231
7232 2019-06-25  Tom Tromey  <tom@tromey.com>
7233
7234         * tui/tui-regs.c (tui_show_registers): Update.
7235         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
7236         bool.
7237         * tui/tui-data.c (tui_data_window::clear_detail)
7238         (tui_data_window): Update.
7239
7240 2019-06-25  Tom Tromey  <tom@tromey.com>
7241
7242         * tui/tui-windata.c (tui_display_all_data)
7243         (tui_display_data_from_line, tui_display_data_from)
7244         (tui_check_data_values, tui_data_window::do_scroll_vertical):
7245         Update.
7246         * tui/tui-regs.c (tui_last_regs_line_no)
7247         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
7248         (tui_show_registers, tui_show_register_group)
7249         (tui_display_registers_from, tui_display_reg_element_at_line)
7250         (tui_display_registers_from_line, tui_check_register_values)
7251         (tui_reg_next, tui_reg_prev): Update.
7252         * tui/tui-layout.c (tui_set_layout, show_data): Update.
7253         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
7254         tui_data_window.
7255         (struct tui_win_info) <detail>: Remove.  Add new fields from
7256         tui_data_info.
7257         (TUI_DATA_WIN): Add cast.
7258         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
7259         (~tui_data_window): Simplify.
7260
7261 2019-06-25  Tom Tromey  <tom@tromey.com>
7262
7263         * tui/tui-layout.c (show_source_disasm_command)
7264         (show_source_or_disasm_and_command): Update.
7265         * tui/tui-io.c (update_cmdwin_start_line)
7266         (tui_redisplay_readline): Update.
7267         * tui/tui-data.h (struct tui_command_info): Remove.
7268         (struct tui_win_info) <detail>: Remove command_info member.
7269         (struct tui_data_window) <start_line>: New member, from
7270         tui_command_info.
7271         (TUI_CMD_WIN): Add casts.
7272
7273 2019-06-25  Tom Tromey  <tom@tromey.com>
7274
7275         * tui/tui-winsource.c (tui_update_source_window)
7276         (tui_refill_source_window)
7277         (tui_source_window_base::do_scroll_horizontal)
7278         (tui_update_breakpoint_info, tui_set_exec_info_content)
7279         (tui_show_exec_info_content, tui_erase_exec_info_content)
7280         (tui_clear_exec_info_content): Update.
7281         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
7282         Update.
7283         * tui/tui-win.c (make_invisible_and_set_new_height)
7284         (make_visible_with_new_height): Update.
7285         * tui/tui-source.c (tui_set_source_content)
7286         (tui_show_symtab_source): Update.
7287         * tui/tui-layout.c (extract_display_start_addr)
7288         (show_source_disasm_command, show_data)
7289         (make_source_or_disasm_window)
7290         (show_source_or_disasm_and_command): Update.
7291         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
7292         (tui_disasm_window::do_scroll_vertical): Remove shadowing
7293         "gdbarch".
7294         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
7295         to tui_source_window_base.
7296         (struct tui_win_info) <detail>: Remove source_info member.
7297         (struct tui_source_window_base) <has_locator>: Inline.
7298         Move contents from tui_source_info; rename has_locator member to
7299         m_has_locator.
7300         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
7301         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
7302         header file.
7303         (tui_source_window_base::clear_detail, ~tui_source_window_base):
7304         Simplify.
7305         (tui_free_all_source_wins_content): Cast to
7306         tui_source_window_base.
7307
7308 2019-06-25  Tom Tromey  <tom@tromey.com>
7309
7310         * tui/tui-win.c (make_invisible_and_set_new_height)
7311         (make_visible_with_new_height): Call has_locator method.
7312         * tui/tui-layout.c (show_source_disasm_command, show_data)
7313         (show_source_or_disasm_and_command): Update for bool change.
7314         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
7315         (tui_win_info) <has_locator>: New method.
7316         (struct tui_source_window_base) <has_locator>: New method.
7317         (tui_win_has_locator): Don't declare.
7318         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
7319         from tui_win_has_locator.
7320         (tui_source_window_base): Use false, not FALSE.
7321
7322 2019-06-25  Tom Tromey  <tom@tromey.com>
7323
7324         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
7325         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
7326         clear_detail method directly.
7327         (tui_clear_win_detail): Remove.
7328
7329 2019-06-25  Tom Tromey  <tom@tromey.com>
7330
7331         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
7332         "this", not TUI_DISASM_WIN.
7333
7334 2019-06-25  Tom Tromey  <tom@tromey.com>
7335
7336         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
7337         declare.
7338         * tui/tui-winsource.c
7339         (tui_source_window_base::do_scroll_horizontal): Rename from
7340         tui_horizontal_source_scroll.
7341         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
7342         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
7343         from tui_vertical_data_scroll.
7344         * tui/tui-win.h (tui_scroll): Don't declare.
7345         * tui/tui-win.c (tui_win_info::forward_scroll)
7346         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
7347         (tui_win_info::right_scroll): Rename and update.
7348         (tui_scroll_forward_command, tui_scroll_backward_command)
7349         (tui_scroll_left_command, tui_scroll_right_command): Update.
7350         (tui_scroll): Remove.
7351         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
7352         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
7353         from tui_vertical_source_scroll.
7354         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
7355         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
7356         from tui_vertical_disassem_scroll.
7357         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
7358         do_scroll_horizontal>: New methods.
7359         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
7360         Likewise.
7361         (struct tui_source_window_base): Add do_scroll_horizontal.
7362         (struct tui_source_window, struct tui_disasm_window): Add
7363         do_scroll_vertical.
7364         (struct tui_data_window, struct tui_cmd_window): Add
7365         do_scroll_horizontal and do_scroll_vertical.
7366         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
7367
7368 2019-06-25  Tom Tromey  <tom@tromey.com>
7369
7370         * tui/tui-data.h (struct tui_source_window_base): New struct.
7371         (struct tui_source_window): Derive from tui_source_window_base.
7372         (struct tui_disasm_window): New struct.
7373         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
7374         from tui_source_window::clear_detail.
7375         (tui_source_window_base): Rename from tui_source_window.
7376         (~tui_source_window_base): Rename from ~tui_source_window.
7377         (tui_alloc_win_info): Create a tui_disasm_window.
7378
7379 2019-06-25  Tom Tromey  <tom@tromey.com>
7380
7381         * tui/tui-data.h (struct tui_source_window)
7382         (struct tui_data_window): Declare destructors.
7383         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
7384         destructors.
7385         (tui_win_info): Simplify.
7386
7387 2019-06-25  Tom Tromey  <tom@tromey.com>
7388
7389         * tui/tui-winsource.c (tui_display_main)
7390         (tui_update_source_windows_with_addr)
7391         (tui_update_all_breakpoint_info): Update.
7392         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
7393         (new_height_ok, parse_scrolling_args): Update.
7394         * tui/tui-stack.c (tui_show_frame_info): Update.
7395         * tui/tui-data.h (struct tui_list): Remove.
7396         (tui_source_windows): Return a reference to a std::vector.
7397         * tui/tui-data.c (source_windows): Now a std::vector.
7398         (tui_source_windows): Change return type.
7399         (tui_clear_source_windows): Rewrite.
7400         (tui_clear_source_windows_detail, tui_add_to_source_windows)
7401         (tui_free_all_source_wins_content): Rewrite.
7402
7403 2019-06-25  Tom Tromey  <tom@tromey.com>
7404
7405         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
7406         (struct tui_data_window, struct tui_cmd_window): Declare
7407         clear_detail method.
7408         * tui/tui-data.c (tui_source_window::clear_detail)
7409         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
7410         methods.
7411         (tui_clear_win_detail): Simplify.
7412
7413 2019-06-25  Tom Tromey  <tom@tromey.com>
7414
7415         * tui/tui-layout.c (make_source_window, make_disasm_window)
7416         (make_source_or_disasm_window): Remove win_info_ptr parameter.
7417         Return the new window.
7418         (show_source_disasm_command, show_data)
7419         (show_source_or_disasm_and_command): Update.
7420
7421 2019-06-25  Tom Tromey  <tom@tromey.com>
7422
7423         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
7424         parameter.  Return the new window.
7425         (show_source_disasm_command): Update and remove NULL check.
7426         (show_source_or_disasm_and_command): Update.
7427
7428 2019-06-25  Tom Tromey  <tom@tromey.com>
7429
7430         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
7431
7432 2019-06-25  Tom Tromey  <tom@tromey.com>
7433
7434         * tui/tui-data.h (struct tui_win_info): Make constructor
7435         protected.  Make destructor virtual.  Add initializers.
7436         (tui_source_window, tui_data_window, tui_cmd_window): New
7437         classes.
7438         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
7439         constructor.  Add "type" parameter.
7440         (tui_source_window, tui_data_window, tui_cmd_window): New
7441         constructors.
7442         (tui_alloc_win_info): Instantiate the appropriate subclass.
7443
7444 2019-06-25  Tom Tromey  <tom@tromey.com>
7445
7446         * tui/tui-win.c (tui_resize_all): Use delete.
7447         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
7448         destructor.
7449         (tui_free_window): Don't declare.
7450         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
7451         Update.
7452
7453 2019-06-25  Tom Tromey  <tom@tromey.com>
7454
7455         * tui/tui-data.h (struct tui_win_info): Add constructor.
7456         * tui/tui-data.c (tui_alloc_win_info): Use new.
7457         (tui_free_window): Use delete.
7458
7459 2019-06-22  Tom Tromey  <tom@tromey.com>
7460
7461         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
7462         declare.
7463         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
7464
7465 2019-06-22  Tom Tromey  <tom@tromey.com>
7466
7467         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
7468         declare.
7469         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
7470
7471 2019-06-22  Tom de Vries  <tdevries@suse.de>
7472
7473         * dwarf2read.c (create_addrmap_from_aranges)
7474         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
7475         instead of '%zu'.
7476
7477 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
7478
7479         * dwarf2read.h (dwarf2_section_info_def): Remove.
7480         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
7481         * dwarf2read.c (struct dwo_sections) <types>: Change type to
7482         std::vector<dwarf2_section_info>.
7483         (struct dwo_file) <~dwo_file>: Remove.
7484         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
7485         types field.
7486         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
7487         (dwarf2_read_debug_names): Likewise.
7488         (create_debug_types_hash_table): Change parameter type to
7489         array_view, adjust code accordingly.
7490         (dwarf2_locate_dwo_sections): Adjust to std::vector.
7491         (partial_die_info::fixup): Likewise.
7492         (determine_prefix): Likewise.
7493         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
7494
7495 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
7496
7497         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
7498         gdb_bfd_ref_ptr.
7499         <~dwo_file>: Remove call to gdb_bfd_unref.
7500         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
7501         gdb_bfd_ref_ptr::get.
7502
7503 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
7504
7505         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
7506         type to htab_up.
7507         * dwarf2read.c (struct dwo_file): Initialize fields.
7508         <~dwo_file>: New.
7509         (free_dwo_file): Remove, move content to ~dwo_file.
7510         (struct dwo_file_deleter): Remove.
7511         (dwo_file_up>: Remove custom deleter.
7512         (free_dwo_files): Remove.
7513         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
7514         dwo_files.
7515         (process_skeletonless_type_units): Call unique_ptr::get.
7516         (allocate_dwo_file_hash_table): Add deleter to created hash
7517         table.  Change return type to htab_up.
7518         (lookup_dwo_file_slot): Don't memset dwo_file, call
7519         unique_ptr::get.
7520         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
7521         (create_dwo_unit_in_dwp_v2): Likewise.
7522         (open_and_init_dwo_file): Likewise.
7523         (free_dwo_file_from_slot): Remove.
7524
7525 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
7526
7527         * dwarf2read.h (struct dwarf2_section_info) <readin,
7528         is_virtual>: Change type to bool.
7529         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
7530         true instead of 1.
7531
7532 2019-06-19  Tom Tromey  <tom@tromey.com>
7533
7534         * tui/tui-data.h (tui_init_content_element): Don't declare.
7535
7536 2019-06-19  Tom Tromey  <tom@tromey.com>
7537
7538         * tui/tui-data.h (tui_init_win_info): Don't declare.
7539
7540 2019-06-19  Tom de Vries  <tdevries@suse.de>
7541
7542         * dwarf2read.h (abstract_to_concrete): Change type to
7543         std::unordered_map<sect_offset, std::vector<sect_offset>,
7544         gdb::hash_enum<sect_offset>>.
7545
7546 2019-06-19  Tom Tromey  <tromey@adacore.com>
7547
7548         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
7549         EVAL_AVOID_SIDE_EFFECTS specially.
7550
7551 2019-06-19  Tom Tromey  <tromey@adacore.com>
7552
7553         * source-cache.c (highlighter): New global.
7554         (source_cache::get_source_lines): Create a highlighter on demand.
7555
7556 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
7557
7558         * defs.h (deprecated_interactive_hook): Delete declaration.
7559         * interps.c (clear_interpreter_hooks): Remove use of
7560         deprecated_interactive_hook.
7561         * top.c (deprecated_interactive_hook): Delete definition.
7562         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
7563
7564 2019-06-18  Tom de Vries  <tdevries@suse.de>
7565
7566         PR gdb/24515
7567         * dwarf2read.h (abstract_to_concrete): Change type from
7568         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
7569         std::unordered_map<sect_offset, std::vector<sect_offset>>.
7570         * dwarf2read.c (read_variable): Update.
7571         (dwarf2_fetch_die_loc_sect_off): Update.
7572
7573 2019-06-17  Tom de Vries  <tdevries@suse.de>
7574
7575         PR gdb/24617
7576         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
7577         accessing parent[parent_len - 1].
7578
7579 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
7580
7581         PR gdb/24364
7582         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
7583         call dtrace_process_dof with NULL dof.
7584
7585 2019-06-16  Tom de Vries  <tdevries@suse.de>
7586
7587         PR gdb/24445
7588         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
7589
7590 2019-06-16  Tom Tromey  <tom@tromey.com>
7591
7592         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
7593         (make_all_visible): Use address of member.
7594
7595 2019-06-16  Tom Tromey  <tom@tromey.com>
7596
7597         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
7598         (tui_free_window, free_content, free_content_elements): Remove
7599         unnecessary cast.
7600         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
7601         cast.
7602         * tui/tui-regs.c (tui_show_register_group)
7603         (tui_display_registers_from, tui_display_reg_element_at_line):
7604         Remove unnecessary cast.
7605
7606 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
7607
7608         * linux-nat.c (normal_mask): Delete.
7609         (_initialize_linux_nat): Don't initialise normal_mask.
7610
7611 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
7612
7613         PR gdb/24445
7614         * dwarf-index-write.h (write_psymtabs_to_index): Add
7615         dwz_basename parameter.
7616         * dwarf-index-write.c (write_gdbindex): Move file writing to
7617         write_gdbindex_1.  Change return type void.
7618         (assert_file_size): Move up, remove filename parameter.
7619         (write_gdbindex_1): New function.
7620         (write_debug_names): Change return type to void, call
7621         assert_file_size.
7622         (struct index_wip_file): New struct.
7623         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
7624         file logic to index_wip_file.  Write index for dwz file if
7625         needed.
7626         (save_gdb_index_command): Pass basename of dwz file, if present.
7627         * dwarf-index-cache.c (index_cache::store): Obtain and pass
7628         build-id of dwz file, if present.
7629         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
7630         (dwarf2_get_dwz_file): Likewise.
7631         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
7632         (dwarf2_get_dwz_file): Likewise.
7633
7634 2019-06-16  Tom Tromey  <tom@tromey.com>
7635
7636         * coffread.c (process_coff_symbol): Use xstrdup.
7637         * value.c (create_internalvar): Use xstrdup.
7638
7639 2019-06-16  Tom Tromey  <tom@tromey.com>
7640
7641         * valops.c (value_cast, value_slice): Remove unnecessary cast.
7642         * breakpoint.c (stopin_command, stopat_command)
7643         (until_break_command, decode_location_default): Remove unnecessary
7644         cast.
7645         * utils.c (subset_compare): Remove unnecessary cast.
7646         * ada-lang.c (ada_update_initial_language): Remove unnecessary
7647         cast.
7648         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
7649         cast.
7650         * infcmd.c (path_command): Remove unnecessary cast.
7651         * coffread.c (decode_type): Remove unnecessary cast.
7652         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
7653         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
7654         * tui/tui-stack.c (tui_show_locator_content)
7655         (tui_show_frame_info): Remove unnecessary cast.
7656         * tui/tui-win.c (tui_scroll_forward_command)
7657         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
7658         (parse_scrolling_args): Remove unnecessary cast.
7659         * tui/tui-data.c (init_win_info, tui_del_window)
7660         (tui_free_window, tui_del_data_windows, tui_free_data_content)
7661         (free_content_elements): Remove unnecessary cast.
7662         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
7663         unnecessary cast.
7664         * tui/tui-source.c (tui_set_source_content)
7665         (tui_vertical_source_scroll): Remove unnecessary cast.
7666         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
7667         cast.
7668         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
7669         * tui/tui-regs.c (tui_display_registers_from)
7670         (tui_display_register): Remove unnecessary cast.
7671         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
7672         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
7673         (make_visible): Remove unnecessary cast.
7674         * tui/tui-winsource.c (tui_erase_source_content)
7675         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
7676         unnecessary cast.
7677         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
7678         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
7679         * stabsread.c (read_type, read_array_type, read_range_type):
7680         Remove unnecessary cast.
7681         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
7682         (parse_symbol, parse_type, upgrade_type, parse_external)
7683         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
7684         unnecessary cast.
7685         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
7686
7687 2019-06-16  Tom Tromey  <tom@tromey.com>
7688
7689         * tui/tui-data.c (tui_alloc_generic_win_info)
7690         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
7691         checks.
7692
7693 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
7694             Andrew Burgess  <andrew.burgess@embecosm.com>
7695
7696         * f-typeprint.c (f_print_type): Don't return early for not
7697         associated or not allocated types.
7698         (f_type_print_varspec_suffix): Add print_rank parameter and print
7699         ranks of array types in case they dangling.
7700         (f_type_print_base): Add print_rank parameter.
7701
7702 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
7703
7704         * NEWS: Mention new MI commands.
7705         * break-catch-throw.c (enum exception_event_kind): Move to
7706         breakpoint.h.
7707         (print_mention_exception_catchpoint): Output text as a single
7708         message.
7709         (catch_exception_command_1): Rename to...
7710         (catch_exception_event): ...this, make non-static, update header
7711         command, and change some parameter types.
7712         (catch_catch_command): Update for changes to
7713         catch_exception_command_1.
7714         (catch_throw_command): Likewise.
7715         (catch_rethrow_command): Likewise.
7716         * breakpoint.c (enum exception_event_kind): Delete.
7717         * breakpoint.h (enum exception_event_kind): Moved here from
7718         break-catch-throw.c.
7719         (catch_exception_event): Declare.
7720         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
7721         (mi_cmd_catch_throw): New function.
7722         (mi_cmd_catch_rethrow): New function.
7723         (mi_cmd_catch_catch): New function.
7724         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
7725         'catch-catch' entries.
7726         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
7727         (mi_cmd_catch_rethrow): Declare.
7728         (mi_cmd_catch_catch): Declare.
7729
7730 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
7731
7732         * annotate.c (annotate_source_line): Change return type to void,
7733         update implementation to match.
7734         * annotate.h (annotate_source_line): Change return type to void,
7735         update header comment.
7736         * stack.c (print_frame_info): Don't change what frame information
7737         is printed based on whether annotations are on or not.
7738
7739 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
7740
7741         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
7742         (annotate_source): Make static.
7743         (annotate_source_line): Moved from source.c and renamed from
7744         identify_source_line.  Update the return type.
7745         * annotate.h (annotate_source): Delete declaration.
7746         (annotate_source_line): Declaration moved from source.h, and
7747         renamed from identify_source_line.  Return type updated.
7748         * source.c (identify_source_line): Moved to annotate.c and renamed
7749         to annotate_source_line.
7750         (info_line_command): Remove check of annotation_level.
7751         * source.h (identify_source_line): Move declaration to annotate.h
7752         and rename to annotate_source_line.
7753         * stack.c: Add 'annotate.h' include.
7754         (print_frame_info): Remove check of annotation_level before
7755         calling annotate_source_line.
7756
7757 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
7758
7759         * source-cache.c (source_cache::get_plain_source_lines): Use
7760         open_source_file_with_line_charpos instead of just
7761         open_source_file, remove call to find_source_lines.
7762         (source_cache::get_source_lines): Likewise.
7763         * source.c (find_source_lines): Make static.
7764         (get_filename_and_charpos): Renamed into...
7765         (open_source_file_with_line_charpos): ..this along with changes to
7766         return a scoped_fd, and some other minor clean ups.
7767         (identify_source_line): Use open_source_file_with_line_charpos.
7768         (search_command_helper): Use open_source_file_with_line_charpos
7769         instead of just open_source_file, remove call to
7770         find_source_lines.
7771         * source.h (open_source_file_with_line_charpos): Declare new
7772         function.
7773         (find_source_lines): Delete declaration.
7774
7775 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
7776
7777         * source.c (get_filename_and_charpos): Remove fullname
7778         parameter.
7779         (identify_source_line): Update call to get_filename_and_charpos.
7780
7781 2019-06-14  Tom Tromey  <tromey@adacore.com>
7782
7783         PR gdb/24502:
7784         * ui-style.h (skip_ansi_escape): Update comment.
7785         * ui-file.h (class no_terminal_escape_file): New class.
7786         * ui-file.c (no_terminal_escape_file::write)
7787         (no_terminal_escape_file::puts): New methods.
7788         * cli/cli-logging.c (handle_redirections): Use
7789         no_terminal_escape_file.
7790
7791 2019-06-14  Tom Tromey  <tromey@adacore.com>
7792
7793         * NEWS: Move convenience variable news above Python news.
7794
7795 2019-06-14  Tom Tromey  <tom@tromey.com>
7796
7797         * gnulib: Move directory to top-level.
7798         * configure.ac: Don't configure gnulib.
7799         * configure: Rebuild.
7800         * common/common-defs.h: Use new path to gnulib.
7801         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
7802         (GNULIB_H): Remove.
7803         (INCGNU): Look in new gnulib location.
7804         (HFILES_NO_SRCDIR): Remove gnulib files.
7805         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
7806         (generated_files): Remove GNULIB_H.
7807         ($(LIBGNU), all-lib): Remove targets.
7808         (distclean): Don't mention GNULIB_BUILDDIR.
7809         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
7810
7811 2019-06-14  Tom Tromey  <tromey@adacore.com>
7812
7813         * symfile.c (add_symbol_file_command): Remove obsolete comment.
7814         Warn if symbol file does not provide any symbols.
7815
7816 2019-06-14  Tom Tromey  <tromey@adacore.com>
7817
7818         * source.c (find_and_open_source): Respect basenames_may_differ.
7819
7820 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
7821
7822         * annotate.c (annotate_breakpoints_invalid): Make use of
7823         scoped_restore_terminal_state.
7824         (annotate_frames_invalid): Likewise.
7825
7826 2019-06-14  Tom Tromey  <tromey@adacore.com>
7827
7828         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
7829         allow assignment to an internalvar.
7830
7831 2019-06-14  Tom Tromey  <tromey@adacore.com>
7832
7833         * ada-lex.l: Allow "_" in attribute names.
7834
7835 2019-06-14  Tom Tromey  <tromey@adacore.com>
7836
7837         PR gdb/24653:
7838         * regcache.c (registers_changed): Don't call alloca.
7839         * top.c (execute_command): Don't call alloca.
7840
7841 2019-06-13  Pedro Alves  <palves@redhat.com>
7842
7843         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
7844         'expression'.  When parsing an expression, error out if there's
7845         junk after "unlimited".
7846         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
7847         (do_set_command): Adjust calls to is_unlimited_literal.
7848
7849 2019-06-13  Pedro Alves  <palves@redhat.com>
7850
7851         * compile/compile.c (make_compile_options_def_group): Add braces
7852         around array_view initializer.
7853         * thread.c (make_thread_apply_all_options_def_group)
7854         (make_thread_apply_all_options_def_group): Likewise.
7855
7856 2019-06-13  Pedro Alves  <palves@redhat.com>
7857
7858         * NEWS (New commands): Mention "maint test-options
7859         require-delimiter", "maint test-options unknown-is-error", "maint
7860         test-options unknown-is-operand" and "maint show
7861         test-options-completion-result".
7862         (New command options, command completion): New section.
7863         (Completion improvements): New section.
7864         Mention that you can abbreviate "unlimited".
7865
7866 2019-06-13  Pedro Alves  <palves@redhat.com>
7867
7868         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
7869         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
7870         * unittests/cli-utils-selftests.c (test_parse_flags)
7871         (test_parse_flags_qcs): Delete.
7872         (test_cli_utils): Don't call deleted functions.
7873
7874 2019-06-13  Pedro Alves  <palves@redhat.com>
7875
7876         * thread.c: Include "cli/cli-option.h".
7877         (tp_array_compar_ascending): Global.
7878         (tp_array_compar): Delete function.
7879         (tp_array_compar_ascending, tp_array_compar_descending): New
7880         functions.
7881         (ascending_option_def, qcs_flag_option_def)
7882         (thr_qcs_flags_option_defs)
7883         (make_thread_apply_all_options_def_group)
7884         (make_thread_apply_options_def_group): New.
7885         (thread_apply_all_command): Use gdb::option::process_options.
7886         (thread_apply_command_completer)
7887         (thread_apply_all_command_completer): New.
7888         (thread_apply_command): Use gdb::option::process_options.
7889         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
7890         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
7891         to generate help text of "thread apply".  Adjust "taas"'s help.
7892         * tid-parse.c (tid_range_parser::in_thread_range): New method.
7893         * tid-parse.h (tid_range_parser::in_thread_range): New method.
7894
7895 2019-06-13  Pedro Alves  <palves@redhat.com>
7896
7897         * thread.c (thread_apply_command): Check for invalid TID with
7898         isdigit instead of !isalpha.
7899
7900 2019-06-13  Pedro Alves  <palves@redhat.com>
7901
7902         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
7903         (validate_flags_qcs): New.
7904         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
7905         (validate_flags_qcs): Declare.
7906         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
7907         (make_frame_apply_options_def_group): New.
7908         (frame_apply_command_count): Process options with
7909         gdb::option::process_options.
7910         (frame_apply_completer): New.
7911         (frame_apply_level_completer, frame_apply_all_completer)
7912         (frame_apply_completer): New.
7913         (_initialize_stack): Update help of "frame apply", "frame apply
7914         level", "frame apply all" and "faas" to mention supported options
7915         and install command completers.
7916         * stack.h (frame_apply_all_completer): Declare.
7917         * thread.c: Include "stack.h".
7918         (tfaas_command): Add "--".
7919         (_initialize_thread): Update help "tfaas" to mention supported
7920         options and install command completer.
7921
7922 2019-06-13  Pedro Alves  <palves@redhat.com>
7923
7924         * completer.c (complete_nested_command_line): New.
7925         (gdb_completion_word_break_characters_throw): Add assertion.
7926         * completer.h (complete_nested_command_line): Declare.
7927
7928 2019-06-13  Pedro Alves  <palves@redhat.com>
7929
7930         * stack.c (parse_backtrace_qualifiers): New.
7931         (backtrace_command): Use it.
7932         (backtrace_command_completer): Complete on qualifiers.
7933
7934 2019-06-13  Pedro Alves  <palves@redhat.com>
7935
7936         * frame.c: Include "cli/cli-option.h.
7937         (user_set_backtrace_options): New.
7938         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
7939         Delete.
7940         (get_prev_frame): Adjust.
7941         (boolean_option_def, uinteger_option_def)
7942         (set_backtrace_option_defs): New.
7943         (_initialize_frame): Adjust and use
7944         gdb::option::add_setshow_cmds_for_options to install "set
7945         backtrace past-main" and "set backtrace past-entry".
7946         * frame.h: Include "cli/cli-option.h".
7947         (struct frame_print_options): Forward declare.
7948         (print_frame_arguments_all, print_frame_arguments_scalars)
7949         (print_frame_arguments_none): Declare.
7950         (print_entry_values): Delete declaration.
7951         (struct frame_print_options, user_frame_print_options): New.
7952         (struct set_backtrace_options): New.
7953         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
7954         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
7955         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
7956         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
7957         (list_args_or_locals): Add frame_print_options parameter.
7958         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
7959         * python/py-framefilter.c (enumerate_args): Pass down
7960         USER_FRAME_PRINT_OPTIONS.
7961         * stack.c: Include "cli/cli-option.h".
7962         (print_frame_arguments_all, print_frame_arguments_scalars)
7963         (print_frame_arguments_none): Declare.
7964         (print_raw_frame_arguments, print_entry_values): Delete.
7965         (user_frame_print_options): New.
7966         (boolean_option_def, enum_option_def, frame_print_option_defs):
7967         New.
7968         (struct backtrace_cmd_options): New.
7969         (bt_flag_option_def): New.
7970         (backtrace_command_option_defs): New.
7971         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
7972         (print_frame_arg, read_frame_arg, print_frame_args)
7973         (print_frame_info, print_frame): Add frame_print_options parameter
7974         and use it.
7975         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
7976         (backtrace_command_1): Add frame_print_options and
7977         backtrace_cmd_options parameters and use them.
7978         (make_backtrace_options_def_group): New.
7979         (backtrace_command): Process command options with
7980         gdb::option::process_options.
7981         (backtrace_command_completer): New.
7982         (_initialize_stack): Extend "backtrace"'s help to mention
7983         supported options.  Install completer for "backtrace".
7984         Install some settings commands with add_setshow_cmds_for_options.
7985
7986 2019-06-13  Pedro Alves  <palves@redhat.com>
7987
7988         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
7989         and that "set/show print raw frame-arguments" are now deprecated.
7990
7991         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
7992         command.
7993         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
7994         * stack.c (_initialize_stack): Install "set/show print
7995         raw-frame-arguments", and deprecate "set/show print raw
7996         frame-arguments".
7997         * valprint.c (_initialize_valprint): Deprecate "set/show print
7998         raw".
7999
8000 2019-06-13  Pedro Alves  <palves@redhat.com>
8001
8002         * compile/compile.c (struct compile_options): New.
8003         (compile_flag_option_def, compile_command_option_defs)
8004         (make_compile_options_def_group): New.
8005         (compile_file_command): Handle options with
8006         gdb::option::process_options.
8007         (compile_file_command_completer): New function.
8008         (compile_code_command): Handle options with
8009         gdb::option::process_options.
8010         (compile_code_command_completer): New function.
8011         (_initialize_compiler): Install completers for "compile code" and
8012         "compile file".  Mention available options in "compile code" and
8013         "compile code"'s help.
8014         * completer.c (advance_to_completion_word): New, factored out from
8015         ...
8016         (advance_to_expression_complete_word_point): ... this.
8017         (advance_to_filename_complete_word_point): New.
8018         * completer.h (advance_to_filename_complete_word_point): New
8019         declaration.
8020
8021 2019-06-13  Pedro Alves  <palves@redhat.com>
8022
8023         * compile/compile.c: Include "cli/cli-option.h".
8024         (compile_print_value): Scope data pointer is now a
8025         value_print_options pointer; adjust.
8026         (compile_print_command): Process options.  Scope data pointer is
8027         now a value_print_options pointer; adjust.
8028         (_initialize_compile): Update "compile print"'s help to include
8029         supported options.  Install a completer for "compile print".
8030         * cp-valprint.c (show_vtblprint, show_objectprint)
8031         (show_static_field_print): Delete.
8032         (_initialize_cp_valprint): Don't install "set print
8033         static-members", "set print vtbl", "set print object" here.
8034         * printcmd.c: Include "cli/cli-option.h" and
8035         "common/gdb_optional.h".
8036         (print_command_parse_format): Rework to fill in a
8037         value_print_options instead of a format_data.
8038         (print_value): Change parameter type from format_data pointer to
8039         value_print_options reference.  Adjust.
8040         (print_command_1): Process options.  Adjust to pass down a
8041         value_print_options.
8042         (print_command_completer): New.
8043         (_initialize_printcmd): Install print_command_completer as
8044         handle_brkchars completer for the "print" command.  Update
8045         "print"'s help to include supported options.
8046         * valprint.c: Include "cli/cli-option.h".
8047         (show_vtblprint, show_objectprint, show_static_field_print): Moved
8048         here from cp-valprint.c.
8049         (boolean_option_def, uinteger_option_def)
8050         (value_print_option_defs, make_value_print_options_def_group):
8051         New.  Use gdb::option::add_setshow_cmds_for_options to install
8052         "set print elements", "set print null-stop", "set print repeats",
8053         "set print pretty", "set print union", "set print array", "set
8054         print address", "set print symbol", "set print array-indexes".
8055         * valprint.h: Include <string> and "cli/cli-option.h".
8056         (make_value_print_options_def_group): Declare.
8057         (print_value): Change parameter type from format_data pointer to
8058         value_print_options reference.
8059         (print_command_completer): Declare.
8060
8061 2019-06-13  Pedro Alves  <palves@redhat.com>
8062
8063         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
8064         (COMMON_SFILES): Add maint-test-settings.c.
8065         * cli/cli-decode.c (boolean_enums): New global, factored out from
8066         ...
8067         (add_setshow_boolean_cmd): ... here.
8068         * cli/cli-decode.h (boolean_enums): Declare.
8069         * cli/cli-option.c: New file.
8070         * cli/cli-option.h: New file.
8071         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
8072         factored out from ...
8073         (parse_cli_boolean_value(const char *)): ... this.
8074         (is_unlimited_literal): Change parameter type to pointer to
8075         pointer.  Adjust and advance ARG pointer.
8076         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
8077         (parse_cli_var_enum): New, factored out from ...
8078         (do_set_command): ... this.  Adjust.
8079         * cli/cli-setshow.h (parse_cli_boolean_value)
8080         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
8081         (parse_cli_var_enum): Declare.
8082         * cli/cli-utils.c: Include "cli/cli-option.h".
8083         (get_ulongest): New.
8084         * cli/cli-utils.h (get_ulongest): Declare.
8085         (check_for_argument): New overloads.
8086         * maint-test-options.c: New file.
8087
8088 2019-06-13  Pedro Alves  <palves@redhat.com>
8089
8090         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
8091         parse a range if "-" is at the end of the string.
8092
8093 2019-06-13  Pedro Alves  <palves@redhat.com>
8094
8095         * cli/cli-setshow.c (parse_auto_binary_operation)
8096         (parse_cli_boolean_value): Don't allow "o".
8097
8098 2019-06-13  Pedro Alves  <palves@redhat.com>
8099
8100         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
8101         * NEWS: Mention maint test-settings KIND.
8102         * maint-test-settings.c: New file.
8103
8104 2019-06-13  Pedro Alves  <palves@redhat.com>
8105
8106         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
8107         completer.
8108         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
8109         "set" completers.
8110
8111 2019-06-13  Pedro Alves  <palves@redhat.com>
8112
8113         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
8114         after item.
8115
8116 2019-06-13  Pedro Alves  <palves@redhat.com>
8117
8118         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
8119
8120 2019-06-13  Pedro Alves <palves@redhat.com>
8121
8122         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
8123         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
8124         call.
8125         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
8126         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
8127         calls.
8128         (check_for_argument): Skip spaces after argument.
8129
8130 2019-06-13  Pedro Alves  <palves@redhat.com>
8131
8132         * thread.c (thread_apply_command): Adjust TID parsing.
8133         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
8134         detected before end of string.
8135         (tid_is_in_list): Error out if LIST is invalid.
8136
8137 2019-06-13  Pedro Alves  <palves@redhat.com>
8138
8139         * completer.c (complete_line_internal_1): Rewind completion word
8140         point.
8141         (completion_tracker::advance_custom_word_point_by): Change
8142         parameter type to int.
8143         * completer.h (completion_tracker::advance_custom_word_point_by):
8144         Likewise.
8145
8146 2019-06-13  Pedro Alves  <palves@redhat.com>
8147
8148         * completer.c (advance_to_completion_word): Handle delimiters.
8149
8150 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
8151
8152         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
8153
8154 2019-06-11  Tom Tromey  <tom@tromey.com>
8155
8156         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
8157         (xmalloc_failed): Move to alloc.c.
8158         * alloc.c: New file.
8159         * Makefile.in (COMMON_SFILES): Add alloc.c.
8160
8161 2019-06-11  Tom Tromey  <tom@tromey.com>
8162
8163         * nat/linux-waitpid.c: Don't include server.h.
8164         (linux_debug): Remove.
8165         (my_waitpid): Update.
8166
8167 2019-06-11  Tom Tromey  <tromey@adacore.com>
8168
8169         * infcall.c (_initialize_infcall): Remove trailing newline from
8170         help.
8171         * user-regs.c (_initialize_user_regs): Remove trailing newline
8172         from help.
8173         * typeprint.c (_initialize_typeprint): Remove trailing newline
8174         from help.
8175         * reverse.c (_initialize_reverse): Remove trailing newlines from
8176         help.
8177         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
8178         from help.
8179         * language.c (add_set_language_command): Remove trailing newline
8180         from help.
8181         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
8182         help.
8183         * disasm.c (_initialize_disasm): Remove trailing newline from
8184         help.
8185         * top.c (init_main): Remove trailing newline from help.
8186         * interps.c (_initialize_interpreter): Remove trailing newline
8187         from help.
8188         * btrace.c (_initialize_btrace): Remove trailing newlines from
8189         help.
8190         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
8191         from help.
8192         * python/python.c (_initialize_python): Remove trailing newline
8193         from help.
8194         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
8195         help.
8196         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
8197         from help.  Reformat some text.
8198         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
8199         from help.
8200         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
8201         newline from help.
8202
8203 2019-06-11  Tom Tromey  <tromey@adacore.com>
8204
8205         * darwin-nat.c (darwin_decode_exception_message)
8206         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
8207
8208 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
8209
8210         * valops.c (value_slice): Check for not allocated or not
8211         associated values.
8212
8213 2019-06-10  Tom de Vries  <tdevries@suse.de>
8214
8215         PR gdb/24618
8216         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
8217         sure an empty slot (defined by a 32-bit zero pair) is recognized as
8218         invalid.
8219
8220 2019-06-10  Tom de Vries  <tdevries@suse.de>
8221
8222         PR gdb/24611
8223         * linespec.c (linespec_lexer_lex_string): Remove incorrect
8224         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
8225
8226 2019-06-10  Tom de Vries  <tdevries@suse.de>
8227
8228         PR symtab/24545
8229         * symtab.c (struct demangled_name_entry): Add language field.
8230         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
8231         static minimal symbol".  Set and use language field.
8232
8233 2019-06-10  Tom Tromey  <tromey@adacore.com>
8234
8235         * ada-lang.c (_initialize_ada_language): Update help text.
8236
8237 2019-06-10  Tom Tromey  <tromey@adacore.com>
8238
8239         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
8240         with a newline.
8241         * guile/guile.c (handle_boot_error): Don't end warning with a
8242         newline.
8243         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
8244         warning with a newline.
8245         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
8246         newline.
8247         (s12z_frame_cache): Likewise.
8248         * dwarf-index-cache.c (index_cache::store): Don't end warning with
8249         a newline.
8250         * solib-svr4.c (disable_probes_interface): Don't end warning with
8251         a newline.
8252         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
8253         newline.
8254         * python/python.c (do_finish_initialization): Don't end warning
8255         with a newline.
8256
8257 2019-06-10  Tom Tromey  <tom@tromey.com>
8258
8259         * python/py-breakpoint.c (gdbpy_breakpoint_created)
8260         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
8261         gdbpy_enter.
8262
8263 2019-06-10  Tom Tromey  <tromey@adacore.com>
8264
8265         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
8266         data.
8267         (elf_new_init): Don't call stabsread_new_init.
8268         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
8269         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
8270         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
8271
8272 2019-06-10  Tom de Vries  <tdevries@suse.de>
8273
8274         PR symtab/16264
8275         PR symtab/24517
8276         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
8277
8278 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
8279
8280         * source.c (find_and_open_source): Also rewrite relative file
8281         names.
8282
8283 2019-04-26  Amos Bird  <amosbird@gmail.com>
8284
8285         * annotate.c (annotate_thread_exited): Add "thread-exited"
8286         annotation.
8287
8288 2019-06-06  Tom Tromey  <tromey@adacore.com>
8289
8290         * maint.h (class scoped_command_stats): Use
8291         DISABLE_COPY_AND_ASSIGN.
8292         <print_time>: New method.
8293         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
8294         print_time.
8295         (scoped_command_stats::print_time): New method.
8296
8297 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
8298
8299         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
8300         instructions of lengths 6 or 8 bytes.
8301
8302 2019-06-04  Pedro Alves  <palves@redhat.com>
8303
8304         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
8305
8306         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
8307         * breakpoint.c (condition_completer): Likewise.
8308         * cli/cli-dump.c (scan_expression): Likewise.
8309         * common/filestuff.c (mkdir_recursive): Likewise.
8310         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
8311         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
8312         (gdb_abspath): Likewise.
8313         * compile/compile-cplus-types.c
8314         (compile_cplus_instance::decl_name): Likewise.
8315         * completer.c (complete_explicit_location):
8316         (signal_completer, reg_or_group_completer_1): Likewise.
8317         * cp-support.c (cp_remove_params_if_any): Likewise.
8318         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
8319         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
8320         * infcmd.c (strip_bg_char): Likewise.
8321         * linespec.c (copy_token_string): Likewise.
8322         * mi/mi-main.c (output_cores): Likewise.
8323         * psymtab.c (psymtab_search_name):
8324         * symfile.c (test_set_ext_lang_command): Likewise.
8325         * target.c (target_fileio_read_stralloc): Likewise.
8326         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
8327         * value.c (complete_internalvar): Likewise.
8328
8329 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
8330
8331         Add objfile property to gdb.Type.
8332         * NEWS: Mention Python API addition.
8333         * python/py-type.c (typy_get_objfile): New method.
8334
8335 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8336
8337         * NEWS: Mention the new set|show style [title|highlight].
8338         Mention changes to "show style", "help" and "apropos".
8339
8340 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8341
8342         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
8343         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
8344         instead of print_help_for_command.
8345         (print_doc_of_command): New function.
8346         (help_list): Add 'apropos -v word' suggestion.
8347         (print_help_for_command): Style the command name using title style.
8348         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
8349         (_initialize_cli_cmds): Describe -v in apropos_command help.
8350
8351 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8352
8353         * cli/cli-style.h (cli_style_option): Add name in constructor,
8354         add m_name class member, add constructor with intensity,
8355         add name class function.
8356         (cli_style_option::add_setshow_commands): Remove name argument.
8357         (highlight_style, title_style): New styles.
8358         * cli/cli-style.c (do_show): New function that shows a style
8359         characteristic styling the style name with itself.
8360         (set_style_name): New function.
8361         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
8362         Update all callers according to the changes in cli/cli-style.h.
8363         * utils.h (fputs_highlighted): New function.
8364         * utils.c (fputs_highlighted): Likewise.
8365
8366 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8367
8368         * NEWS: Mention new pipe command and new convenience variables.
8369
8370 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8371
8372         * cli/cli-cmds.c (pipe_command): New function.
8373         (_initialize_cli_cmds): Call add_com for pipe_command.
8374         Define | as an alias for pipe.
8375         (exit_status_set_internal_vars): New function.
8376         (shell_escape): Call exit_status_set_internal_vars.
8377         cli/cli-decode.c (find_command_name_length): Recognize | as
8378         a single character command.
8379
8380 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8381
8382         * gdbcmd.h (execute_command_to_ui_file): New declaration.
8383         top.c (execute_command_to_ui_file): New function, mostly a copy
8384         of execute_command_to_string.
8385         (execute_command_to_string): Implement by calling
8386         execute_command_to_ui_file.
8387
8388 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8389
8390         * top.h (saved_command_line): Remove declaration.
8391         * top.c (previous_saved_command_line, previous_repeat_arguments):
8392         New variables.
8393         (saved_command_line): Make static, define together with other
8394         'repeat variables'.
8395         (dont_repeat): Clear repeat_arguments.
8396         (repeat_previous, get_saved_command_line, save_command_line):
8397         New functions.
8398         (gdb_init): Initialize saved_command_line
8399         and previous_saved_command_line.
8400         * main.c (captured_main_1): Remove saved_command_line initialization.
8401         * event-top.c (handle_line_of_input): Update to use
8402         the new 'repeat' related functions instead of direct access to
8403         saved_command_line.
8404         * command.h (repeat_previous, get_saved_command_line,
8405         save_command_line): New declarations.
8406         (dont_repeat): Add comment.
8407
8408 2019-05-30  Tom Tromey  <tromey@adacore.com>
8409
8410         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
8411         Fix comment.
8412         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
8413
8414 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
8415
8416         PR cli/24587
8417         * completer.c (complete): Initialize variable word.
8418
8419 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
8420
8421         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
8422         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
8423         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
8424         'body' is NULL to the outter 'if', protecting the '!is_define'
8425         situation as well.
8426
8427 2019-05-29  Tom Tromey  <tromey@adacore.com>
8428
8429         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
8430         (dwarf_unknown): New function.
8431         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
8432         (dwarf_type_encoding_name): Use dwarf_unknown.
8433
8434 2019-05-29  Tom Tromey  <tromey@adacore.com>
8435
8436         PR c++/20020:
8437         * cp-valprint.c (cp_print_value_fields): Call
8438         cp_print_static_field inside "try".
8439
8440 2019-05-29  Tom Tromey  <tromey@adacore.com>
8441
8442         * inflow.c (struct terminal_info): Add default operator=.
8443         * configure: Rebuild.
8444         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
8445         -Wdeprecated-copy-dtor, -Wredundant-move.
8446
8447 2019-05-29  Tom Tromey  <tromey@adacore.com>
8448
8449         * NEWS: Add entry.
8450         * infcmd.c (print_return_value_1): Handle finish_print
8451         option.
8452         (show_print_finish): New function.
8453         (_initialize_infcmd): Add "set/show print finish" commands.
8454         * valprint.c (user_print_options): Initialize new member.
8455         * valprint.h (struct value_print_options) <finish_print>: New
8456         member.
8457
8458 2019-05-28  Tom Tromey  <tromey@adacore.com>
8459
8460         * ada-lang.c (ada_remove_Xbn_suffix)
8461         (find_old_style_renaming_symbol)
8462         (parse_old_style_renaming): Remove.
8463         (ada_find_renaming_symbol): Don't call
8464         find_old_style_renaming_symbol.
8465         (ada_is_renaming_symbol): Rename from
8466         ada_find_renaming_symbol.  Remove "block" parameter.  Return
8467         bool.  Now static.
8468         (ada_read_var_value): Update and simplify.
8469         * ada-exp.y (write_var_or_type): Remove old code.
8470
8471 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
8472
8473         PR gdb/25010
8474         * event-top.c: Remove include comment.
8475         * inflow.c (class scoped_ignore_sigttou): Move from here...
8476         * inflow.h (class scoped_ignore_sigttou): ...to here.
8477         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
8478         * top.c:  Remove include comment.
8479
8480 2019-05-27  Tom Tromey  <tom@tromey.com>
8481
8482         * NEWS: Fix typo.
8483
8484 2019-05-22  Tom Tromey  <tromey@adacore.com>
8485
8486         * target.c (target_follow_exec): Constify parameter.
8487         * target-delegates.c: Rebuild.
8488         * remote.c (remote_target::follow_exec): Constify parameter.
8489         * infrun.c (follow_exec): Constify parameter.
8490         * target.h (struct target_ops) <follow_exec>: Constify parameter.
8491         (target_follow_exec): Likewise.
8492
8493 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
8494
8495         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
8496         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
8497
8498 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
8499
8500         * NEWS: Add debugredirect and testsuite sections.
8501
8502 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
8503
8504         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
8505         target descriptions using exclusively floating point register name
8506         aliases.
8507
8508 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
8509
8510         PR gdb/18644:
8511         * f-lang.c (build_fortran_types): Handle the case where
8512         gdbarch_floatformat_for_type returns a nullptr.
8513
8514 2019-05-21  Tom de Vries  <tdevries@suse.de>
8515
8516         PR cli/24587
8517         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
8518
8519 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
8520
8521         PR gdb/18644:
8522         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
8523         16-byte floats.
8524         * i386-tdep.c (i386_floatformat_for_type): Use
8525         floatformats_ia64_quad for the 16-byte floating point component
8526         within a fortran 32-byte complex number.
8527
8528 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
8529
8530         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
8531         delete default constructor.
8532         (find_partial_die): Update to return const struct.
8533         (partial_die_parent_scope): Move variable declaration into scope
8534         of its use and change its type to auto.
8535         (guess_partial_die_structure_name): Likewise.
8536         (partial_die_info::fixup): Likewise.
8537
8538 2019-05-17  Tom Tromey  <tromey@adacore.com>
8539
8540         * source.c (find_and_open_source): Remove cast.
8541
8542 2019-05-17  Tom Tromey  <tromey@adacore.com>
8543
8544         * annotate.c (annotate_source): Make "filename" const.
8545         * annotate.h (annotate_source): Use const.
8546
8547 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
8548
8549         * disasm.c (set_disassembler_options): Send errors to stderr.
8550
8551 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
8552
8553         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
8554         (cli_interp_base::set_logging): Check debug_redirect.
8555         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
8556         * cli/cli-logging.c (debug_redirect): Add static variable.
8557         (pop_output_files): Add default param.
8558         (handle_redirections): Print debug setting.
8559         (show_logging_command): Likewise.
8560         (_initialize_cli_logging): Add debugredirect command.
8561         * interps.c (current_interp_set_logging): Add debug_redirect
8562         parameter.
8563         * interps.h (set_logging): Add debug_redirect parameter.
8564         (current_interp_set_logging): Likewise.
8565         * mi/mi-common.h: Likewise.
8566         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
8567
8568 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
8569             Tom Tromey  <tromey@adacore.com>
8570
8571         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
8572         directly.
8573         * cli/cli-interp.h (make_logging_output): Remove declaration.
8574         * cli/cli-logging.c (make_logging_output): Remove function.
8575         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
8576         directly.
8577         * ui-file.c (tee_file::tee_file): Remove bools.
8578         (tee_file::~tee_file): Remove deletes.
8579         * ui-file.h (tee_file): Remove bools.
8580
8581 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
8582
8583         * mi/mi-cmds.h (mi_cmd_complete): New function.
8584         * mi/mi-main.c (mi_cmd_complete): Likewise.
8585         * mi/mi-cmds.c: Define new MI command -complete.
8586         * NEWS: Mention new -complete command.
8587
8588 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
8589
8590         * completer.h (complete): New function.
8591         * completer.c (complete): Likewise.
8592         * cli/cli-cmds.c: (complete_command): Update to use new complete()
8593         function defined in completer.h.
8594
8595 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
8596
8597         * MAINTAINERS (Write After Approval): Add myself.
8598
8599 2019-05-17  Tom de Vries  <tdevries@suse.de>
8600
8601         PR gdb/24094
8602         * dwarf2read.c (struct cu_partial_die_info): New struct.
8603         (find_partial_die): Return cu_partial_die_info.
8604         (partial_die_parent_scope, guess_partial_die_structure_name)
8605         (partial_die_info::fixup): Handle new return type of find_partial_die.
8606
8607 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
8608
8609         PR breakpoints/24541
8610         * stap-probe.c (stap_parse_register_operand): Make "regname" an
8611         "std::string", simplifying the algorithm.
8612
8613 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
8614
8615         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
8616         (stap_static_probe_ops::get_probes): Likewise.
8617
8618 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
8619
8620         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
8621         '-')" and "else if".
8622         (stap_parse_single_operand): Join checks for
8623         "gdbarch_stap_parse_special_token_p" and
8624         "gdbarch_stap_parse_special_token" in the same "if" statement.
8625         Invert check when verifying for operation on register
8626         displacement.
8627
8628 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
8629
8630         * stap-probe.c (stap_get_opcode): Update comment.
8631         (stap_get_expected_argument_type): Likewise.
8632         (handle_stap_probe): Likewise.
8633
8634 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
8635
8636         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
8637         return type to 'bool'.  Adjust comment.  Use 'bool' when
8638         appropriate.
8639         (i386_stap_parse_special_token_three_arg_disp): Likewise.
8640         * stap-probe.c (stap_parse_argument_1): Likewise.
8641         (stap_is_operator): Likewise.
8642         (stap_is_generic_prefix): Likewise.
8643         (stap_is_register_prefix): Likewise.
8644         (stap_is_register_indirection_prefix): Likewise.
8645         (stap_is_integer_prefix): Likewise.
8646         (stap_generic_check_suffix): Likewise.
8647         (stap_check_integer_suffix): Likewise.
8648         (stap_check_register_suffix): Likewise.
8649         (stap_check_register_indirection_suffix): Likewise.
8650         (stap_parse_register_operand): Likewise.
8651         (stap_parse_single_operand): Likewise.
8652         (stap_parse_argument_1): Likewise.
8653         (stap_probe::get_argument_count): Likewise.
8654         (stap_is_operator): Likewise.
8655
8656 2019-05-16  Tom Tromey  <tromey@adacore.com>
8657
8658         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
8659         keyword to foreach.
8660
8661 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
8662
8663         * linux-thread-db.c (try_thread_db_load_1): Change return type
8664         to bool.
8665         (try_thread_db_load): Likewise.
8666         (try_thread_db_load_from_pdir_1): Likewise.
8667         (try_thread_db_load_from_pdir): Likewise.
8668         (try_thread_db_load_from_sdir): Likewise.
8669         (try_thread_db_load_from_dir): Likewise.
8670         (thread_db_load_search): Likewise.
8671         (has_libpthread): Likewise.
8672         (thread_db_load): Likewise.
8673
8674 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
8675
8676         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
8677         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
8678         NULL, and complain/return if that's the case.
8679
8680 2019-05-15  John Darrington <john@darrington.wattle.id.au>
8681
8682         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
8683         (advance, posn, abstract_read_memory): New functions.
8684         [struct mem_read_abstraction]: New struct.
8685         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
8686
8687 2019-05-14  Tom Tromey  <tromey@adacore.com>
8688
8689         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
8690         value is not lval_memory.
8691
8692 2019-05-14  Tom Tromey  <tromey@adacore.com>
8693
8694         * solib.c (info_sharedlibrary_command): Style the file name.
8695
8696 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
8697
8698         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
8699         (aarch64_vnv_type): Likewise.
8700         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
8701         * common/tdesc.c: Likewise.
8702         * common/tdesc.h (enum tdesc_type_kind): Likewise.
8703         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
8704         * features/aarch64-fpu.xml: Add ieee half view.
8705         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
8706         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
8707         * gdbtypes.h (struct builtin_type): Likewise.
8708         (struct objfile_type): Likewise.
8709
8710 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
8711
8712         * language.c (language_sniff_from_mangled_name): Fix "langauge"
8713         typo.
8714         * location.h (string_to_event_location): Likewise.
8715
8716 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
8717
8718         GDB 8.3 released.
8719
8720 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
8721
8722         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
8723         New variable declaration.
8724         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
8725         New variable.
8726         (print_one_breakpoint): Use ui_out::test_flags and new global
8727         variable to compute use_fixed_output.
8728         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
8729         Remove.
8730         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
8731         (mi_multi_location_breakpoint_output_fixed): Remove.
8732         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
8733         new variable.
8734         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
8735         fix_multi_location_breakpoint_output flag if version >= 3.
8736         * ui-out.h (enum ui_out_flag)
8737         <fix_multi_location_breakpoint_output>: New enumerator.
8738
8739 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
8740
8741         * contrib/cc-with-tweaks.sh: Validate dwz's work.
8742
8743 2019-05-10  Tom Tromey  <tromey@adacore.com>
8744
8745         * ada-lang.c (catch_ada_completer): New function.
8746         (_initialize_ada_language): Use it.
8747
8748 2019-05-10  Tom Tromey  <tromey@adacore.com>
8749
8750         * thread.c (print_thread_info): Make "requested_threads" const.
8751         * gdbthread.h (print_thread_info): Make "requested_threads"
8752         const.
8753         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
8754         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
8755
8756 2019-05-08  Tom Tromey  <tom@tromey.com>
8757
8758         * gdbtypes.c (objfile_type_data): Change type.
8759         (objfile_type, _initialize_gdbtypes): Update.
8760
8761 2019-05-08  Tom Tromey  <tom@tromey.com>
8762
8763         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
8764         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
8765         (_initialize_dwarf2_frame): Update.
8766
8767 2019-05-08  Tom Tromey  <tom@tromey.com>
8768
8769         * objc-lang.c (objc_objfile_data): Change type.
8770         (find_methods): Update.
8771         (_initialize_objc_lang): Remove.
8772
8773 2019-05-08  Tom Tromey  <tom@tromey.com>
8774
8775         * stabsread.c (rs6000_builtin_type_data): Change type.
8776         (rs6000_builtin_type, _initialize_stabsread): Update.
8777
8778 2019-05-08  Tom Tromey  <tom@tromey.com>
8779
8780         * mips-tdep.c (mips_pdr_data): Remove.
8781         (_initialize_mips_tdep): Update.
8782
8783 2019-05-08  Tom Tromey  <tom@tromey.com>
8784
8785         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
8786         (hppa_init_objfile_priv_data, read_unwind_info)
8787         (find_unwind_entry, _initialize_hppa_tdep): Update.
8788
8789 2019-05-08  Tom Tromey  <tom@tromey.com>
8790
8791         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
8792         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
8793         on obstack.
8794         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
8795
8796 2019-05-08  Tom Tromey  <tom@tromey.com>
8797
8798         * mdebugread.c (basic_type_data): Change type.
8799         (basic_type, _initialize_mdebugread): Update.
8800
8801 2019-05-08  Tom Tromey  <tom@tromey.com>
8802
8803         * common/gdb_unique_ptr.h (struct noop_deleter): New.
8804
8805 2019-05-08  Tom Tromey  <tom@tromey.com>
8806
8807         * nto-tdep.c (nto_inferior_data_reg): Change type.
8808         (nto_inferior_data): Update.
8809         (nto_inferior_data_cleanup, nto_new_inferior_data)
8810         (_initialize_nto_tdep): Remove.
8811         * nto-tdep.h (struct nto_inferior_data): Add initializers.
8812
8813 2019-05-08  Tom Tromey  <tom@tromey.com>
8814
8815         * ada-lang.c (struct ada_inferior_data): Add initializers.
8816         (ada_inferior_data): Change type.
8817         (ada_inferior_data_cleanup): Remove.
8818         (get_ada_inferior_data, ada_inferior_exit)
8819         (struct ada_pspace_data): Add initializers, destructor.
8820         (ada_pspace_data_handle): Change type.
8821         (get_ada_pspace_data): Update.
8822         (ada_pspace_data_cleanup): Remove.
8823
8824 2019-05-08  Tom Tromey  <tom@tromey.com>
8825
8826         * coffread.c (struct coff_symfile_info): Add initializers.
8827         (coff_objfile_data_key): Move lower.  Change type.
8828         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
8829         Update.
8830         (coff_free_info): Remove.
8831
8832 2019-05-08  Tom Tromey  <tom@tromey.com>
8833
8834         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
8835         (fbsd_pspace_data_handle): Move lower.  Change type.
8836         (get_fbsd_pspace_data): Update.
8837         (fbsd_pspace_data_cleanup): Remove.
8838         (_initialize_fbsd_tdep): Update.
8839
8840 2019-05-08  Tom Tromey  <tom@tromey.com>
8841
8842         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
8843         (get_ada_tasks_pspace_data): Update.
8844         (ada_tasks_pspace_data_cleanup): Remove.
8845         (_initialize_tasks): Update.
8846         (ada_tasks_inferior_data_handle): Change type.
8847         (get_ada_tasks_inferior_data): Update.
8848         (ada_tasks_inferior_data_cleanup): Remove.
8849         (struct ada_tasks_pspace_data): Add initializers.
8850
8851 2019-05-08  Tom Tromey  <tom@tromey.com>
8852
8853         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
8854         * symfile-debug.c (debug_sym_get_probes): Change type.
8855         * stap-probe.c (handle_stap_probe):
8856         (stap_static_probe_ops::get_probes): Change type.
8857         * probe.h (class static_probe_ops) <get_probes>: Change type.
8858         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
8859         (parse_probes_in_pspace): Update.
8860         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
8861         Update.
8862         (any_static_probe_ops::get_probes): Change type.
8863         * elfread.c (elfread_data): New typedef.
8864         (probe_key): Change type.
8865         (elf_get_probes): Likewise.  Update.
8866         (probe_key_free): Remove.
8867         (_initialize_elfread): Update.
8868         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
8869         Change type.
8870         (dtrace_process_dof_probe, dtrace_process_dof)
8871         (dtrace_static_probe_ops::get_probe): Change type.
8872
8873 2019-05-08  Tom Tromey  <tom@tromey.com>
8874
8875         * xcoffread.c (struct xcoff_symfile_info): Rename from
8876         coff_symfile_info.  Add initializers.
8877         (xcoff_objfile_data_key): Move lower.  Change type.
8878         (XCOFF_DATA): Rewrite.
8879         (xcoff_free_info): Remove.
8880         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
8881         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
8882         (xcoff_initial_scan): Update.
8883
8884 2019-05-08  Tom Tromey  <tom@tromey.com>
8885
8886         * solib-svr4.c (struct svr4_info): Add initializers and
8887         destructor.
8888         <probes_table>: Now an htab_up.
8889         (solib_svr4_pspace_data): Change type.
8890         (free_probes_table): Simplify.
8891         (~svr4_info): Rename from svr4_pspace_data_cleanup.
8892         (get_svr4_info, probes_table_htab_remove_objfile_probes)
8893         (probes_table_remove_objfile_probes, register_solib_event_probe)
8894         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
8895         (_initialize_svr4_solib): Update.
8896
8897 2019-05-08  Tom Tromey  <tom@tromey.com>
8898
8899         * remote.c (remote_pspace_data): Change type.
8900         (remote_pspace_data_cleanup): Remove.
8901         (get_remote_exec_file, set_pspace_remote_exec_file)
8902         (_initialize_remote): Update.
8903
8904 2019-05-08  Tom Tromey  <tom@tromey.com>
8905
8906         * breakpoint.c (breakpoint_objfile_key): Change type.
8907         (get_breakpoint_objfile_data): Update.
8908         (free_breakpoint_objfile_data): Remove.
8909         (_initialize_breakpoint): Update.
8910
8911 2019-05-08  Tom Tromey  <tom@tromey.com>
8912
8913         * linux-tdep.c (struct linux_info): Add initializers.
8914         (linux_inferior_data): Move.  Change type.
8915         (invalidate_linux_cache_inf): Update.
8916         (linux_inferior_data_cleanup): Remove.
8917         (get_linux_inferior_data, _initialize_linux_tdep): Update.
8918
8919 2019-05-08  Tom Tromey  <tom@tromey.com>
8920
8921         * auxv.c (auxv_inferior_data): Move.  Change type.
8922         (auxv_inferior_data_cleanup): Remove.
8923         (invalidate_auxv_cache_inf): Rewrite.
8924         (get_auxv_inferior_data, _initialize_auxv): Update.
8925
8926 2019-05-08  Tom Tromey  <tom@tromey.com>
8927
8928         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
8929         (symfile_debug_objfile_data_key): Change type.
8930         (symfile_debug_installed, debug_qf_has_symbols)
8931         (debug_qf_find_last_source_symtab)
8932         (debug_qf_forget_cached_source_info)
8933         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
8934         (debug_qf_print_stats, debug_qf_dump)
8935         (debug_qf_expand_symtabs_for_function)
8936         (debug_qf_expand_all_symtabs)
8937         (debug_qf_expand_symtabs_with_fullname)
8938         (debug_qf_map_matching_symbols)
8939         (debug_qf_expand_symtabs_matching)
8940         (debug_qf_find_pc_sect_compunit_symtab)
8941         (debug_qf_map_symbol_filenames)
8942         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
8943         (debug_sym_new_init, debug_sym_init, debug_sym_read)
8944         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
8945         (debug_sym_read_linetable, debug_sym_relocate): Update.
8946         (symfile_debug_free_objfile): Remove.
8947         (install_symfile_debug_logging, _initialize_symfile_debug):
8948         Update.
8949
8950 2019-05-08  Tom Tromey  <tom@tromey.com>
8951
8952         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
8953         allocate_on_obstack.
8954         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
8955         (get_dwarf2_per_objfile): Update.
8956         (set_dwarf2_per_objfile): Remove.
8957         (dwarf2_has_info, dwarf2_get_section_info): Update.
8958         (dwarf2_free_objfile): Remove.
8959         (_initialize_dwarf2_read): Update.
8960
8961 2019-05-08  Tom Tromey  <tom@tromey.com>
8962
8963         * auto-load.c (struct auto_load_pspace_info): Add destructor and
8964         initializers.
8965         <unsupported_script_warning_printed,
8966         script_not_found_warning_printed>: Now bool.
8967         (auto_load_pspace_data): Change type.
8968         (~auto_load_pspace_info): Rename from
8969         auto_load_pspace_data_cleanup.
8970         (get_auto_load_pspace_data, init_loaded_scripts_info)
8971         (clear_section_scripts, maybe_print_unsupported_script_warning)
8972         (maybe_print_script_not_found_warning, _initialize_auto_load):
8973         Update.
8974
8975 2019-05-08  Tom Tromey  <tom@tromey.com>
8976
8977         * objfiles.c (objfile_pspace_info): Add destructor and
8978         initializers.
8979         (objfiles_pspace_data): Change type.
8980         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
8981         (get_objfile_pspace_data): Update.
8982         (objfiles_bfd_data): Change type.
8983         (get_objfile_bfd_data): Update.
8984         (objfile_bfd_data_free, _initialize_objfiles): Remove.
8985
8986 2019-05-08  Tom Tromey  <tom@tromey.com>
8987
8988         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
8989         Change type.
8990         (get_catch_syscall_inferior_data): Update.
8991         (catch_syscall_inferior_data_cleanup): Remove.
8992         (_initialize_break_catch_syscall): Update.
8993
8994 2019-05-08  Tom Tromey  <tom@tromey.com>
8995
8996         * inflow.c (struct terminal_info): Add destructor and
8997         initializers.
8998         (inflow_inferior_data): Change type.
8999         (~terminal_info): Rename from inflow_inferior_data_cleanup.
9000         (get_inflow_inferior_data, inflow_inferior_exit)
9001         (swap_terminal_info, _initialize_inflow): Update.
9002
9003 2019-05-08  Tom Tromey  <tom@tromey.com>
9004
9005         * target-dcache.c (target_dcache_cleanup): Remove.
9006         (target_dcache_aspace_key): Change type.
9007         (target_dcache_init_p, target_dcache_invalidate)
9008         (target_dcache_get, target_dcache_get_or_init)
9009         (_initialize_target_dcache): Update.
9010         * dcache.h (struct dcache_deleter): New.
9011
9012 2019-05-08  Tom Tromey  <tom@tromey.com>
9013
9014         * symtab.c (struct symbol_cache): Add destructor and
9015         initializers.
9016         (symbol_cache_key): Move.  Change type.
9017         (make_symbol_cache, free_symbol_cache): Remove.
9018         (get_symbol_cache): Update.
9019         (symbol_cache_cleanup): Remove.
9020         (ALL_PSPACES, symbol_cache_flush)
9021         (maintenance_print_symbol_cache)
9022         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
9023         Update.
9024
9025 2019-05-08  Tom Tromey  <tom@tromey.com>
9026
9027         * symtab.c (struct main_info): Add destructor and initializers.
9028         (main_progspace_key): Move.  Change type.
9029         (get_main_info): Update.
9030         (main_info_cleanup): Remove.
9031         (_initialize_symtab): Update.
9032
9033 2019-05-08  Tom Tromey  <tom@tromey.com>
9034
9035         * registry.h (DECLARE_REGISTRY): Define the _key class.
9036
9037 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
9038
9039         * NEWS: Merge two 'New commands' sections.
9040
9041 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
9042
9043         * ada-valprint.c (ada_val_print_gnat_array): Remove language
9044         parameter and use Ada language definition instead.
9045         (ada_val_print_ptr): Remove unused language parameter.
9046         (ada_val_print_num): Remove language parameter and use Ada language
9047         definition instead.
9048         (ada_val_print_enum, ada_val_print_flt): Remove unused language
9049         parameter.
9050         (ada_val_print_struct_union, ada_val_print_ref): Remove language
9051         parameter and use Ada language definition instead.
9052         (ada_val_print_1): Update all ada_val_print_xxx calls.
9053         Remove language parameter.
9054         (ada_val_print): Update ada_val_print_1 call.
9055
9056 2019-05-08  Tom Tromey  <tromey@adacore.com>
9057
9058         * remote.c (remote_hw_watchpoint_limit)
9059         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
9060         Now static.
9061
9062 2019-05-08  Tom Tromey  <tromey@adacore.com>
9063
9064         * maint.c (_initialize_maint_cmds): Move initialization code to
9065         remote.c.
9066         (watchdog, show_watchdog): Move to remote.c.
9067         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
9068         "watchdog" static.
9069         (_initialize_remote): Move initialization code from maint.c.
9070         * defs.h (watchdog): Don't declare.
9071
9072 2019-05-08  Tom Tromey  <tromey@adacore.com>
9073
9074         * tui/tui-interp.c: Include main.h.
9075         * interps.c: Include main.h.
9076         * main.h (interpreter_p): Declare.
9077         * defs.h (interpreter_p): Don't declare.
9078
9079 2019-05-08  Tom Tromey  <tromey@adacore.com>
9080
9081         * dwarf2loc.c: Include dwarf2read.h.
9082         * defs.h (read_unsigned_leb128): Don't declare.
9083         * dwarf2read.h (read_unsigned_leb128): Declare.
9084
9085 2019-05-08  Tom Tromey  <tromey@adacore.com>
9086
9087         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
9088         method.
9089
9090 2019-05-08  Tom Tromey  <tromey@adacore.com>
9091
9092         * utils.c (fputs_maybe_filtered): Reset style after paging, even
9093         when no wrap column is set.
9094
9095 2019-05-08  Tom Tromey  <tromey@adacore.com>
9096
9097         * c-lang.c (c_get_string): Handle non-C-style arrays.
9098
9099 2019-05-08  Tom Tromey  <tromey@adacore.com>
9100
9101         * typeprint.c (print_offset_data::update): Print the bit offset,
9102         not the number of bits remaining.
9103
9104 2019-05-08  Tom Tromey  <tromey@adacore.com>
9105
9106         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
9107         padding at end of comment.
9108
9109 2019-05-08  Tom Tromey  <tromey@adacore.com>
9110
9111         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
9112         Compare main types.
9113
9114 2019-05-06  Tom Tromey  <tom@tromey.com>
9115
9116         * common/scoped_mmap.c: Include common-defs.h.
9117         * common/scoped_mmap.h: Don't include config.h.
9118
9119 2019-05-04  Tom Tromey  <tom@tromey.com>
9120
9121         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
9122         (struct aarch64_call_info): Add initializers.
9123         <si>: Now a std::vector.
9124         (pass_on_stack, aarch64_push_dummy_call): Update.
9125
9126 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
9127             Tom Tromey  <tom@tromey.com>
9128
9129         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
9130         (ppc_threads): Now a std::vector.  Now static.
9131         (hwdebug_find_thread_points_by_tid)
9132         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
9133         Update.
9134
9135 2019-05-04  Tom Tromey  <tom@tromey.com>
9136
9137         * arc-tdep.c (arc_tdesc_init): Return bool.
9138
9139 2019-05-04  Tom Tromey  <tom@tromey.com>
9140
9141         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
9142         Use gdb_assert_not_reached.
9143
9144 2019-05-04  Tom Tromey  <tom@tromey.com>
9145
9146         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
9147         "false".
9148
9149 2019-05-04  Tom Tromey  <tom@tromey.com>
9150
9151         * arc-tdep.c (arc_tdesc_init): Use bool.
9152
9153 2019-05-04  Tom Tromey  <tom@tromey.com>
9154
9155         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
9156
9157 2019-05-04  Tom Tromey  <tom@tromey.com>
9158
9159         * cli/cli-cmds.c (valid_command_p): Return bool.
9160
9161 2019-05-04  Tom Tromey  <tom@tromey.com>
9162
9163         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
9164         * command.h (valid_user_defined_cmd_name_p): Channge return type.
9165
9166 2019-05-04  Raul Tambre  <raul@tambre.ee>
9167
9168         * python/lib/gdb/prompt.py (_ExtendedPrompt)
9169         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
9170         operator for comparison.
9171
9172 2019-05-04  Tom Tromey  <tom@tromey.com>
9173
9174         * psymtab.c (psymbol_name_matches, match_partial_symbol)
9175         (lookup_partial_symbol, print_partial_symbols)
9176         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
9177         (psymbol_compare): Update.
9178         (add_psymbol_to_bcache): Clear the entire psymbol.
9179         (maintenance_check_psymtabs): Update.
9180         * psympriv.h (struct partial_symbol): Don't derive from
9181         general_symbol_info.
9182         <obj_section, unrelocated_address, address,
9183         set_unrelocated_address>: Update.
9184         <ginfo>: New member.
9185         * dwarf-index-write.c (write_psymbols, debug_names::insert)
9186         (debug_names::write_psymbols): Update.
9187
9188 2019-05-04  Tom de Vries  <tdevries@suse.de>
9189
9190         * contrib/cc-with-tweaks.sh: Support -n arg.
9191
9192 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9193
9194         * corelow.c (core_target::detach): Ensure frame cache and
9195         register caches are cleared.
9196         inferior.c (exit_inferior_1): Likewise.
9197
9198 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
9199             Tom Tromey  <tom@tromey.com>
9200
9201         * dictionary.c (collate_pending_symbols_by_language): Remove
9202         "struct" from foreach.
9203         * symtab.c (lookup_global_symbol_from_objfile)
9204         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
9205         foreach.
9206         * ser-tcp.c (net_open): Remove "struct" from foreach.
9207         * objfiles.c (objfile_relocate, objfile_rebase)
9208         (objfile_has_symbols): Remove "struct" from foreach.
9209         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
9210         from foreach.
9211         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
9212         foreach.
9213         * darwin-nat.c (thread_info_from_private_thread_info): Remove
9214         "struct" from foreach.
9215         * ada-lang.c (create_excep_cond_exprs)
9216         (ada_exception_catchpoint_cond_string): Remove "struct" from
9217         foreach.
9218
9219 2019-05-03  Tom Tromey  <tromey@adacore.com>
9220
9221         * ada-exp.y (convert_char_literal): Check suffix of each
9222         enumerator.
9223
9224 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
9225
9226         PR ada/21406:
9227         * ada-exp.y (yywrap): Don't define.
9228         * ada-lex.l (%option): Add noyywrap
9229         (yywrap): Remove.
9230
9231 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
9232
9233         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
9234         _WIN32_WINNT to the XP level, unless already defined to a higher
9235         level.
9236
9237         * unittests/parse-connection-spec-selftests.c:
9238         * ser-tcp.c:
9239         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
9240         override.
9241
9242         * symfile.c (find_separate_debug_file): Remove colon from the
9243         drive spec of DOS/Windows file names of the target, so that the
9244         file name produced from DEBUGDIR and the target's directory will
9245         be valid on DOS/Windows systems.
9246
9247 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
9248
9249         * rust-lang.c (val_print_struct): Handle printing structures
9250         containing strings.
9251
9252 2019-05-02  Tom Tromey  <tromey@adacore.com>
9253
9254         * valarith.c (_initialize_valarith): Remove.
9255
9256 2019-05-01  Tom Tromey  <tromey@adacore.com>
9257
9258         * ada-lang.c (ada_value_primitive_field): Treat more fields as
9259         bitfields.
9260
9261 2019-05-01  Tom Tromey  <tromey@adacore.com>
9262
9263         * ada-lang.c (ada_value_assign): Correctly compute starting offset
9264         for big-endian copies.
9265
9266 2019-04-30  Ali Tamur  <tamur@google.com>
9267         * gdb/dwarf2read.c (read_3_bytes): New declaration.
9268         (read_attribute_value): Added DW_FORM_strx1-4 cases.
9269         (read_3_bytes): New function.
9270
9271 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
9272
9273         * windows-nat.c (main_thread_id): Delete.
9274         (handle_output_debug_string): Replace main_thread_id by
9275         current_event.dwThreadId.
9276         (fake_create_process): Likewise.
9277         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
9278         Do not set main_thread_id.
9279         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
9280         current_event.dwThreadId.
9281         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
9282
9283 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
9284
9285         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
9286         Use current_event.dwThreadId instead of main_thread_id.
9287
9288 2019-04-30  Tom Tromey  <tromey@adacore.com>
9289
9290         * ada-lang.c (ada_lookup_simple_minsyms): New function.
9291         (create_excep_cond_exprs): Iterate over program spaces.
9292         (ada_exception_catchpoint_cond_string): Examine all minimal
9293         symbols for exception types.
9294
9295 2019-04-30  Tom Tromey  <tromey@adacore.com>
9296
9297         PR c++/24470:
9298         * dwarf2read.c (process_structure_scope): Handle case where type
9299         has template parameters but no symbol was created.
9300
9301 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
9302             Chris January  <chris.january@arm.com>
9303
9304         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
9305         qualifier.
9306         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
9307
9308 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
9309
9310         * f-typeprint.c (f_print_type): Update rules for printing
9311         whitespace.
9312         (f_type_print_varspec_suffix): Likewise.
9313
9314 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
9315             Chris January  <chris.january@arm.com>
9316
9317         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
9318         function arguments.
9319
9320 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
9321
9322         * f-lang.c (build_fortran_types): Change name of void type to
9323         lower case.
9324         * f-typeprint.c (f_type_print_base): Print the name of the void
9325         type, rather than a fixed string.
9326         * f-valprint.c (f_decorations): Use lower case void string.
9327
9328 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
9329             Chris January  <chris.january@arm.com>
9330
9331         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
9332         types for Fortran.
9333
9334 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
9335             Chris January  <chris.january@arm.com>
9336             David Lecomber  <david.lecomber@arm.com>
9337
9338         * f-exp.y (BINOP_INTRINSIC): New token.
9339         (exp): New parser rule handling BINOP_INTRINSIC.
9340         (f77_keywords): Add new builtin procedures.
9341         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
9342         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
9343         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
9344         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
9345         (print_unop_subexp_f): New function.
9346         (print_binop_subexp_f): New function.
9347         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
9348         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
9349         (dump_subexp_body_f): Likewise.
9350         (operator_check_f): Likewise.
9351         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
9352         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
9353
9354 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
9355
9356         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
9357         UNOP_KIND.
9358         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
9359         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
9360         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
9361         (operator_length_f): New fuction.
9362         (print_subexp_f): New function.
9363         (op_name_f): New function.
9364         (dump_subexp_body_f): New function.
9365         (operator_check_f): New function.
9366         (exp_descriptor_f): Replace standard expression handling functions
9367         with new functions.
9368         * gdb/fortran-operator.def: New file.
9369         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
9370         * gdb/std-operator.def: Remove UNOP_KIND.
9371
9372 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
9373
9374         * std-operator.def: Remove unbalanced, stray double quote
9375         character.
9376
9377 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
9378             Chris January  <chris.january@arm.com>
9379             Daniel Everett  <daniel.everett@arm.com>
9380             Nick Forrington  <nick.forrington@arm.com>
9381             Richard Bunt  <richard.bunt@arm.com>
9382
9383         * cp-valprint.c (cp_print_value_fields): Allow an additional level
9384         of depth when printing anonymous structs or unions.
9385         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
9386         Don't print either the top-level value, or the children if the
9387         max-depth is exceeded.
9388         (ppscm_print_children): When printing the key of a map, allow one
9389         extra level of depth.
9390         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
9391         print either the top-level value, or the children if the max-depth
9392         is exceeded.
9393         (print_children): When printing the key of a map, allow one extra
9394         level of depth.
9395         * python/py-value.c (valpy_format_string): Add max_depth keyword.
9396         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
9397         (user_print_options): Initialise max_depth field.
9398         (val_print_scalar_or_string_type_p): New function.
9399         (val_print): Check to see if the max depth has been reached.
9400         (val_print_check_max_depth): Define new function.
9401         (show_print_max_depth): New function.
9402         (_initialize_valprint): Add 'print max-depth' option.
9403         * valprint.h (struct value_print_options) <max_depth>: New field.
9404         (val_print_check_max_depth): Declare new function.
9405         * NEWS: Document new feature.
9406
9407 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
9408
9409         * ada-lang.c (ada_language_defn): Initialise new field.
9410         * c-lang.c (c_is_string_type_p): New function.
9411         (c_language_defn): Initialise new field.
9412         (cplus_language_defn): Initialise new field.
9413         (asm_language_defn): Initialise new field.
9414         (minimal_language_defn): Initialise new field.
9415         * c-lang.h (c_is_string_type_p): Declare new function.
9416         * d-lang.c (d_language_defn): Initialise new field.
9417         * f-lang.c (f_is_string_type_p): New function.
9418         (f_language_defn): Initialise new field.
9419         * go-lang.c (go_is_string_type_p): New function.
9420         (go_language_defn): Initialise new field.
9421         * language.c (default_is_string_type_p): New function.
9422         (unknown_language_defn): Initialise new field.
9423         (auto_language_defn): Initialise new field.
9424         * language.h (struct language_defn) <la_is_string_type_p>: New
9425         member variable.
9426         (default_is_string_type_p): Declare new function.
9427         * m2-lang.c (m2_language_defn): Initialise new field.
9428         * objc-lang.c (objc_language_defn): Initialise new field.
9429         * opencl-lang.c (opencl_language_defn): Initialise new field.
9430         * p-lang.c (pascal_is_string_type_p): New function.
9431         (pascal_language_defn): Initialise new field.
9432         * rust-lang.c (rust_is_string_type_p): New function.
9433         (rust_language_defn): Initialise new field.
9434
9435 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
9436
9437         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
9438         New field.
9439         * ada-lang.c (ada_language_defn): Initialise new field.
9440         * c-lang.c (c_language_defn): Likewise.
9441         (cplus_language_defn): Likewise.
9442         (asm_language_defn): Likewise.
9443         (minimal_language_defn): Likewise.
9444         * d-lang.c (d_language_defn): Likewise.
9445         * f-lang.c (f_language_defn): Likewise.
9446         * go-lang.c (go_language_defn): Likewise.
9447         * language.c (unknown_language_defn): Likewise.
9448         (auto_language_defn): Likewise.
9449         * m2-lang.c (m2_language_defn): Likewise.
9450         * objc-lang.c (objc_language_defn): Likewise.
9451         * opencl-lang.c (opencl_language_defn): Likewise.
9452         * p-lang.c (pascal_language_defn): Likewise.
9453         * rust-lang.c (rust_language_defn): Likewise.
9454
9455 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
9456
9457         * ada-lang.c (ada_is_character_type): Change return type to bool.
9458         (ada_is_string_type): Likewise.
9459         * ada-lang.h (ada_is_character_type): Update declaration
9460         (ada_is_string_type): Likewise.
9461
9462 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9463
9464         Support style in 'frame|thread apply'
9465
9466         * gdbcmd.h (execute_command_to_string): New term_out parameter.
9467         * record.c (record_start, record_stop): Update callers of
9468         execute_command_to_string with false.
9469         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
9470         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
9471         methods.
9472         (class string_file): New constructor with term_out parameter.
9473         Override methods term_out and can_emit_style_escape.  New member
9474         term_out.
9475         (class stdio_file): Override can_emit_style_escape.
9476         (class tee_file): Override term_out and can_emit_style_escape.
9477         * utils.h (can_emit_style_escape): Remove.
9478         * utils.c (can_emit_style_escape): Likewise.
9479         Update all callers of can_emit_style_escape (SOMESTREAM) to
9480         SOMESTREAM->can_emit_style_escape.
9481         * source-cache.c (source_cache::get_source_lines): Likewise.
9482         * stack.c (frame_apply_command_count): Call execute_command_to_string
9483         passing the term_out characteristic of the current gdb_stdout.
9484         * thread.c (thr_try_catch_cmd): Likewise.
9485         * top.c (execute_command_to_string): pass term_out parameter
9486         to construct the string_file for the command output.
9487         * ui-file.c (term_cli_styling): New function (most code moved
9488         from utils.c can_emit_style_escape).
9489         (string_file::string_file, string_file::can_emit_style_escape,
9490         stdio_file::can_emit_style_escape, tee_file::term_out,
9491         tee_file::can_emit_style_escape): New functions.
9492
9493 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9494
9495         * NEWS: Mention the new set|show may-call-functions.
9496         * infcall.c (may_call_functions_p): New variable.
9497         (show_may_call_functions_p): New function.
9498         (call_function_by_hand_dummy): Throws an error if not
9499         may-call-functions.
9500         (_initialize_infcall): Call add_setshow_boolean_cmd for
9501         may-call-functions.
9502
9503 2019-04-25  Keith Seitz  <keiths@redhat.com>
9504
9505         PR c++/24367
9506         * cp-support.c (inspect_type): Don't attempt substitutions
9507         of symbol with the same name.
9508
9509 2019-04-25  Tom Tromey  <tromey@adacore.com>
9510
9511         PR gdb/24475:
9512         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
9513         static.
9514
9515 2019-04-25  Tom Tromey  <tromey@adacore.com>
9516
9517         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
9518         rvalue reference.
9519         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
9520         (gdb_xml_parser::parse): Use std::move.
9521         * python/python-internal.h (gdbpy_convert_exception): Take a const
9522         reference.
9523         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
9524         std::move.
9525         * python/py-utils.c (gdbpy_convert_exception): Take a const
9526         reference.
9527         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
9528         Use std::move.
9529         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
9530         Use std::move.
9531         * mi/mi-main.c (mi_print_exception): Take a const reference.
9532         * main.c (handle_command_errors): Take a const reference.
9533         * linespec.c (parse_linespec): Use std::move.
9534         * infcall.c (run_inferior_call): Use std::move.
9535         (call_function_by_hand_dummy): Use std::move.
9536         * exec.c (try_open_exec_file): Use std::move.
9537         * exceptions.h (exception_print, exception_fprintf)
9538         (exception_print_same): Update.
9539         * exceptions.c (print_exception, exception_print)
9540         (exception_fprintf, exception_print_same): Change parameters to
9541         const reference.
9542         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
9543         * common/new-op.c: Use std::move.
9544         * common/common-exceptions.h (struct gdb_exception): Add move
9545         constructor.
9546         (struct gdb_exception_error, struct gdb_exception_quit, struct
9547         gdb_quit_bad_alloc): Change constructor to move constructor.
9548         (throw_exception): Change parameter to rvalue reference.
9549         * common/common-exceptions.c (throw_exception): Take rvalue
9550         reference.
9551         * cli/cli-interp.c (safe_execute_command): Use std::move.
9552         * breakpoint.c (insert_bp_location, location_to_sals): Use
9553         std::move.
9554
9555 2019-04-25  Tom Tromey  <tromey@adacore.com>
9556
9557         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
9558         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
9559         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
9560         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
9561         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
9562         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
9563         guile/scm-value.c: Use unpack.
9564         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
9565         gdbscm_gdb_exception.
9566         (gdbscm_throw_gdb_exception): Likewise.
9567         (struct gdbscm_gdb_exception): New.
9568         (unpack): New function.
9569         (gdbscm_wrap): Use unpack.
9570
9571 2019-04-25  Tom Tromey  <tromey@adacore.com>
9572
9573         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
9574         (gdb_rl_callback_handler): Use std::move.
9575         * common/common-exceptions.h (struct gdb_exception): Add move
9576         assignment operator.
9577         (throw_exception_sjlj): Change "exception" to const reference.
9578         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
9579         (throw_exception_sjlj): Change "exception" to const reference.
9580
9581 2019-04-25  Tom Tromey  <tromey@adacore.com>
9582
9583         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
9584         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
9585         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
9586         Update.
9587         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
9588         Update.
9589         * mi/mi-interp.c (mi_interp::exec): Update.
9590         * linespec.c (parse_linespec): Update.
9591         * infcall.c (run_inferior_call): Update.
9592         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
9593         * guile/scm-symbol.c (gdbscm_lookup_symbol)
9594         (gdbscm_lookup_global_symbol): Update.
9595         * guile/scm-param.c (gdbscm_parameter_value): Update.
9596         * guile/scm-frame.c (gdbscm_frame_read_register)
9597         (gdbscm_frame_read_var): Update.
9598         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
9599         * exec.c (try_open_exec_file): Update.
9600         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
9601         (gdb_rl_callback_handler): Update.
9602         * common/common-exceptions.h (exception_none): Don't declare.
9603         * common/common-exceptions.c (exception_none): Don't define.
9604         (struct catcher) <exception>: Update.
9605         * cli/cli-interp.c (safe_execute_command): Update.
9606         * breakpoint.c (insert_bp_location, location_to_sals): Update.
9607
9608 2019-04-25  Ali Tamur  <tamur@google.com>
9609
9610         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
9611         (read_attribute_value): Likewise.
9612         (dwarf2_read_addr_index): Update comment.
9613         (read_str_index): Add DW_FORM_strx.
9614         (dwarf2_string_attr): Likewise.
9615         (dwarf2_const_value_attr): Likewise.
9616         (dump_die_shallow): Likewise.
9617         (dwarf2_fetch_constant_bytes): Likewise.
9618         (skip_form_bytes): Likewise.
9619         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
9620
9621 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
9622
9623         PR corefiles/11608
9624         PR corefiles/18187
9625         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
9626         OFFSET.  Verify if current mapping contains an ELF header.
9627         (linux_find_memory_regions_full): Adjust call to
9628         dump_mapping_p.
9629
9630 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
9631             Kang Li <kanglictf@gmail.com>
9632
9633         PR gdb/21600
9634
9635         * dwarf2-frame.c (read_initial_length): Be consistent about using
9636         unsigned representation of length.
9637         (decode_frame_entry_1): Likewise.  Check for wraparound of
9638         end pointer as well as buffer overflow.
9639
9640 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
9641
9642         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
9643         "vq".
9644
9645 2019-04-24  Tom Tromey  <tromey@adacore.com>
9646
9647         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
9648
9649 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9650
9651         * s12z-tdep.c (s12z_unwind_pc): Delete.
9652         (s12z_unwind_sp): Delete.
9653         (s12z_gdbarch_init): Don't register deleted functions with
9654         gdbarch.
9655
9656 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9657
9658         * rl78-tdep.c (rl78_unwind_sp): Delete.
9659         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
9660
9661 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9662
9663         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
9664         (xstormy16_unwind_pc): Delete.
9665         (xstormy16_dummy_id): Delete.
9666         (xstormy16_gdbarch_init): Don't register deleted functions with
9667         gdbarch.
9668
9669 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9670
9671         * vax-tdep.c (vax_unwind_pc): Delete.
9672         (vax_gdbarch_init): Don't register deleted function with gdbarch.
9673
9674 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9675
9676         * v850-tdep.c (v850_unwind_sp): Delete.
9677         (v850_unwind_pc): Delete.
9678         (v850_dummy_id): Delete.
9679         (v850_gdbarch_init): Don't register deleted functions with
9680         gdbarch.
9681
9682 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9683
9684         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
9685         (tilegx_unwind_pc): Delete.
9686         (tilegx_unwind_dummy_id): Delete.
9687         (tilegx_gdbarch_init): Don't register deleted functions with
9688         gdbarch.
9689
9690 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9691
9692         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
9693         (tic6x_dummy_id): Delete.
9694         (tic6x_gdbarch_init): Don't register deleted functions with
9695         gdbarch.
9696
9697 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9698
9699         * sparc-tdep.c (sparc_unwind_pc): Delete.
9700         (sparc32_gdbarch_init): Don't register deleted function with
9701         gdbarch.
9702
9703 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9704
9705         * sh-tdep.c (sh_unwind_sp): Delete.
9706         (sh_unwind_pc): Delete.
9707         (sh_dummy_id): Delete.
9708         (sh_gdbarch_init): Don't register deleted functions with
9709         gdbarch.
9710
9711 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9712
9713         * score-tdep.c (score_unwind_sp): Delete.
9714         (score_unwind_pc): Delete.
9715         (score_dummy_id): Delete.
9716         (score_gdbarch_init): Don't register deleted functions with
9717         gdbarch.
9718
9719 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9720
9721         * rx-tdep.c (rx_unwind_pc): Delete.
9722         (rx_unwind_sp): Delete.
9723         (rx_dummy_id): Delete.
9724         (rx_gdbarch_init): Don't register deleted functions with
9725         gdbarch.  Update comment.
9726
9727 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9728
9729         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
9730         (rs6000_dummy_id): Delete.
9731         (rs6000_gdbarch_init): Don't register deleted functions with
9732         gdbarch.
9733
9734 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9735
9736         * or1k-tdep.c (or1k_dummy_id): Delete.
9737         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
9738
9739 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9740
9741         * nios2-tdep.c (nios2_dummy_id): Delete.
9742         (nios2_unwind_sp): Delete.
9743         (nios2_gdbarch_init): Don't register deleted functions with
9744         gdbarch.
9745
9746 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9747
9748         * nds32-tdep.c (nds32_dummy_id): Delete.
9749         (nds32_unwind_pc): Delete.
9750         (nds32_unwind_sp): Delete.
9751         (nds32_gdbarch_init): Don't register deleted functions with
9752         gdbarch.
9753
9754 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9755
9756         * msp430-tdep.c (msp430_unwind_pc): Delete.
9757         (msp430_unwind_sp): Delete.
9758         (msp430_dummy_id): Delete.
9759         (msp430_gdbarch_init): Don't register deleted functions with
9760         gdbarch.
9761
9762 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9763
9764         * moxie-tdep.c (moxie_unwind_sp): Delete.
9765         (moxie_unwind_pc): Delete.
9766         (moxie_dummy_id): Delete.
9767         (moxie_gdbarch_init): Don't register deleted functions with
9768         gdbarch.
9769
9770 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9771
9772         * mn10300-tdep.c (mn10300_dummy_id): Delete.
9773         (mn10300_unwind_pc): Delete.
9774         (mn10300_unwind_sp): Delete.
9775         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
9776         mn10300_unwind_sp.
9777         (mn10300_frame_unwind_init): Don't register deleted functions with
9778         gdbarch.
9779
9780 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9781
9782         * mep-tdep.c (mep_unwind_pc): Delete.
9783         (mep_unwind_sp): Delete.
9784         (mep_dummy_id): Delete.
9785         (mep_gdbarch_init): Don't register deleted functions with
9786         gdbarch.
9787
9788 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9789
9790         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
9791         (m68hc11_unwind_sp): Delete.
9792         (m68hc11_gdbarch_init): Don't register deleted functions with
9793         gdbarch.
9794
9795 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9796
9797         * m32r-tdep.c (m32r_unwind_sp): Delete.
9798         (m32r_unwind_pc): Delete.
9799         (m32r_dummy_id): Delete.
9800         (m32r_gdbarch_init): Don't register deleted functions with
9801         gdbarch.
9802
9803 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9804
9805         * m32c-tdep.c (m32c_unwind_pc): Delete.
9806         (m32c_unwind_sp): Delete.
9807         (m32c_dummy_id): Delete.
9808         (m32c_gdbarch_init): Don't register deleted functions with
9809         gdbarch.
9810
9811 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9812
9813         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
9814         (lm32_unwind_pc): Delete.
9815         (lm32_dummy_id): Delete.
9816         (lm32_gdbarch_init): Don't register deleted functions with
9817         gdbarch.
9818
9819 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9820
9821         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
9822         (iq2000_unwind_pc): Delete.
9823         (iq2000_dummy_id): Delete.
9824         (iq2000_gdbarch_init): Don't register deleted functions with
9825         gdbarch.
9826
9827 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9828
9829         * nds32-tdep.c (nds32_type_align): Delete.
9830         (nds32_push_dummy_call): Use type_align instead.
9831
9832 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9833
9834         * arm-tdep.c (arm_type_align): Only handle vector override case.
9835         (arm_push_dummy_call): Use type_align.
9836         (arm_gdbarch_init): Register arm_type_align gdbarch function.
9837
9838 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9839
9840         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
9841         case.
9842         (pass_on_stack): Use type_align.
9843         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
9844         function.
9845
9846 2019-04-23  Tom Tromey  <tromey@adacore.com>
9847
9848         * dwarf2read.c (line_header::file_name_at): Remove unused
9849         overload.
9850
9851 2019-04-23  Tom de Vries  <tdevries@suse.de>
9852
9853         PR gdb/24438
9854         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
9855         invocation.
9856
9857
9858 2019-03-27  Ali Tamur  <tamur@google.com>
9859
9860         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
9861         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
9862         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
9863         (dwarf_expr_context::get_addr_index): Likewise
9864         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
9865         (symbol_needs_eval_context::get_addr_index): Likewise
9866         (disassemble_dwarf_expression): Add DW_OP_addrx
9867         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
9868         (read_cutu_die_from_dwo): Update comment
9869         (skip_one_die): Add DW_FORM_addrx
9870         (read_attribute_value): Likewise
9871         (var_decode_location): Add DW_OP_addrx
9872         (dwarf2_const_value_attr): Add DW_FORM_addrx
9873         (dump_die_shallow): Likewise
9874         (dwarf2_fetch_constant_bytes): Likewise
9875         (decode_locdesc): Add DW_OP_addrx
9876         (skip_form_bytes): Add DW_FORM_addrx
9877
9878 2019-04-22  Ali Tamur  <tamur@google.com>
9879
9880         * MAINTAINERS (Write After Approval): Add self.
9881
9882 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
9883
9884         * solib-svr4.c (get_svr4_info): Add pspace parameter.
9885         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
9886         (open_symbol_file_object): Likewise.
9887         (svr4_default_sos): Add info parameter.
9888         (svr4_read_so_list): Likewise.
9889         (svr4_current_sos_direct): Adjust functions calls to pass down
9890         info.
9891         (svr4_current_sos_1): Add info parameter.
9892         (svr4_current_sos): Call get_svr4_info, pass info down to
9893         svr4_current_sos_1.
9894         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
9895         get_svr4_info.
9896         (svr4_in_dynsym_resolve_code): Pass current_program_space to
9897         get_svr4_info.
9898         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
9899         to get_svr4_info.
9900         (probes_table_remove_objfile_probes): Likewise.
9901         (register_solib_event_probe): Add info parameter.
9902         (solist_update_incremental): Pass info parameter down to
9903         svr4_read_so_list.
9904         (disable_probes_interface): Add info parameter.
9905         (svr4_handle_solib_event): Pass current_program_space to
9906         get_svr4_info.  Adjust disable_probes_interface cleanup.
9907         (svr4_create_probe_breakpoints): Add info parameter, pass it
9908         down to register_solib_event_probe.
9909         (svr4_create_solib_event_breakpoints): Add info parameter,
9910         pass it down to svr4_create_probe_breakpoints.
9911         (enable_break): Pass info down to
9912         svr4_create_solib_event_breakpoints.
9913         (svr4_solib_create_inferior_hook): Pass current_program_space to
9914         get_svr4_info.
9915         (svr4_clear_solib): Likewise.
9916
9917 2019-04-22  Pedro Alves  <palves@redhat.com>
9918
9919         * solib-svr4.c (svr4_free_objfile_observer): New.
9920         (probe_and_action::objfile): New field.
9921         (probes_table_htab_remove_objfile_probes)
9922         (probes_table_remove_objfile_probes): New functions.
9923         (register_solib_event_probe): Add 'objfile' parameter.  Store it
9924         in the new probe_and_action.  Don't store the probe in 'lookup'.
9925         (svr4_create_probe_breakpoints): Pass objfile to
9926         register_solib_event_probe.
9927         (_initialize_svr4_solib): Register a free_objfile observer.
9928
9929 2019-04-19  Tom Tromey  <tom@tromey.com>
9930
9931         * common/queue.h: Remove.
9932
9933 2019-04-19  Tom Tromey  <tom@tromey.com>
9934
9935         * event-loop.c: Don't include "common/queue.h".
9936
9937 2019-04-19  Tom Tromey  <tom@tromey.com>
9938
9939         * remote.c (remote_target): Use delete.
9940         * remote-notif.h: Include <list>, not "common/queue.h".
9941         (notif_client_p): Remove typedef.
9942         (remote_notif_state): Add constructor, destructor, initializer.
9943         <notif_queue>: Now a std::list.
9944         (remote_notif_state_xfree): Don't declare.
9945         * remote-notif.c (remote_notif_process, handle_notification)
9946         (remote_notif_state_allocate): Update.
9947         (~remote_notif_state): Rename from remote_notif_state_xfree.
9948
9949 2019-04-19  Tom Tromey  <tom@tromey.com>
9950
9951         * symfile.c (reread_symbols): Update.
9952         * objfiles.c (objfile_register_static_link)
9953         (objfile_lookup_static_link): Update
9954         (~objfile) Don't delete static_links.
9955         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
9956
9957 2019-04-19  Tom Tromey  <tom@tromey.com>
9958
9959         * type-stack.h (struct type_stack) <insert>: Constify string.
9960         * type-stack.c (type_stack::insert): Constify string.
9961         * gdbtypes.h (lookup_template_type): Update.
9962         (address_space_name_to_int): Update.
9963         * gdbtypes.c (address_space_name_to_int): Make space_identifier
9964         const.
9965         (lookup_template_type): Make name const.
9966         * c-exp.y: Update rules.
9967         (lex_one_token, classify_name, classify_inner_name)
9968         (c_print_token): Update.
9969         * p-exp.y: Update rules.
9970         (yylex): Update.
9971         * f-exp.y: Update rules.
9972         (yylex): Update.
9973         * d-exp.y: Update rules.
9974         (lex_one_token, classify_name, classify_inner_name): Update.
9975         * parse.c (write_dollar_variable, copy_name): Return std::string.
9976         * parser-defs.h (copy_name): Change return type.
9977         * m2-exp.y: Update rules.
9978         (yylex): Update.
9979         * go-exp.y (lex_one_token): Update.
9980         Update rules.
9981         (classify_unsafe_function, classify_packaged_name)
9982         (classify_name, yylex): Update.
9983
9984 2019-04-19  Sergei Trofimovich <siarheit@google.com>
9985
9986         * configure.ac: add --enable-source-highlight switch.
9987         * configure: Regenerate.
9988         * top.c (print_gdb_version): plumb --enable-source-highlight
9989         status to "show configuration".
9990
9991 2019-04-19  Tom Tromey  <tromey@adacore.com>
9992
9993         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
9994         Check ADA_TYPE_P.
9995         (empty_record, ada_template_to_fixed_record_type_1)
9996         (template_to_static_fixed_type)
9997         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
9998         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
9999         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
10000         macros.
10001
10002 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
10003
10004         PR symtab/24423:
10005         * source.c (print_source_lines_base): Advance "iter" when a
10006         control character is seen.
10007
10008 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10009
10010         * inferior.h (struct infcall_suspend_state_deleter):
10011         Catch exception in destructor to avoid crash.
10012
10013 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10014
10015         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
10016         close to the add_com "shell".
10017
10018 2019-04-18  Tom Tromey  <tromey@adacore.com>
10019
10020         * process-stratum-target.h (class process_stratum_target)
10021         <stratum>: Add "final".
10022
10023 2019-04-17  Tom Tromey  <tromey@adacore.com>
10024
10025         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
10026         against nullptr before use.
10027
10028 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
10029
10030         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
10031
10032 2019-04-17  Jim Wilson  <jimw@sifive.com>
10033             Andrew Burgess  <andrew.burgess@embecosm.com>
10034
10035         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
10036         code read might fail, assume 4-byte breakpoint in that case.
10037
10038 2019-04-15  Leszek Swirski  <leszeks@google.com>
10039
10040         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
10041         rather than a hand-rolled POD check when checking for forced MEMORY
10042         classification.
10043
10044 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
10045
10046         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
10047         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
10048         function.
10049         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
10050         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
10051         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
10052         declaration.
10053
10054 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
10055
10056         * aarch64-linux-nat.c
10057         (aarch64_linux_nat_target::thread_architecture): Add override.
10058         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
10059         each VQ.
10060
10061 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
10062
10063         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
10064
10065 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
10066
10067         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
10068         target types of size 96-bits, add some additional comments, and
10069         check that the builtin type we found was the correct size.
10070
10071 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
10072
10073         * utils.c (prompt_for_continue): Don't restore the styling at the
10074         end, as applied_style has the wrong value.  This fixes styling in
10075         long lists of file names that are interrupted by the "Continue?"
10076         prompt.
10077
10078 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
10079
10080         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
10081         * c-lang.c (c_language_defn): Likewise.
10082         (cplus_language_defn): Likewise.
10083         (asm_language_defn): Likewise.
10084         (minimal_language_defn): Likewise.
10085         * d-lang.c (d_language_defn): Likewise.
10086         * f-lang.c (f_language_defn): Likewise.
10087         * go-lang.c (go_language_defn): Likewise.
10088         * language.c (unknown_language_defn): Likewise.
10089         (auto_language_defn): Likewise.
10090         * language.h (struct language_defn): Remove la_magic field.
10091         (LANG_MAGIC): Delete.
10092         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
10093         * objc-lang.c (objc_language_defn): Likewise.
10094         * opencl-lang.c (opencl_language_defn): Likewise.
10095         * p-lang.c (pascal_language_defn): Likewise.
10096         * rust-lang.c (rust_language_defn): Likewise.
10097
10098 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
10099
10100         * riscv-tdep.c (riscv_type_align): New function.
10101         (riscv_type_alignment): Delete.
10102         (riscv_arg_location): Use 'type_align'.
10103         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
10104
10105 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
10106
10107         * gdbtypes.c (type_align): A struct with no non-static fields also
10108         has alignment of 1.
10109
10110 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
10111
10112         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
10113         component to 0.
10114         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
10115         member.
10116         (riscv_struct_info::analyse): New implementation using new
10117         analyse_inner member function.
10118         (riscv_struct_info::field_offset): New member function.
10119         (riscv_struct_info::m_offsets): New member variable.
10120         (riscv_struct_info::analyse_inner): New private member function,
10121         takes the old implementation of riscv_struct_info::analyse but
10122         extended to track field offsets.
10123         (riscv_call_arg_struct): Update the struct folding special cases
10124         to handle cases where empty C++ structs, which are non-zero
10125         length, are found.
10126         (riscv_arg_location): Initialise the length of each location, a
10127         non-zero length now indicates the location is in use.
10128         (riscv_push_dummy_call): Allow for the first location having a
10129         non-zero offset when setting up arguments.
10130         (riscv_return_value): Likewise, but for return values.
10131
10132 2019-04-11  Tom Tromey  <tromey@adacore.com>
10133
10134         * utils.c (internal_vproblem): Make "msg" const.
10135
10136 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
10137
10138         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
10139         * trad-frame.c (trad_frame_reset_saved_regs): New function.
10140         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
10141         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
10142
10143 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
10144
10145         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
10146         function.
10147         (fill_gregset): Call amd64_linux_collect_native_gregset instead
10148         of amd64_collect_native_gregset.
10149         (amd64_linux_nat_target::store_registers): Likewise.
10150
10151 2019-04-10  Tom Tromey  <tom@tromey.com>
10152
10153         * symtab.c (lookup_global_symbol_from_objfile)
10154         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
10155         * objfiles.h (class separate_debug_iterator): New.
10156         (class separate_debug_range): New.
10157         (struct objfile) <separate_debug_objfiles>: New method.
10158         (objfile_separate_debug_iterate): Don't declare.
10159         * objfiles.c (separate_debug_iterator::operator++): Rename from
10160         objfile_separate_debug_iterate.
10161         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
10162         iterator.
10163         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
10164         iterator.
10165
10166 2019-04-10  Tom Tromey  <tom@tromey.com>
10167
10168         * symfile.c (reread_symbols): Remove old comment.
10169         * objfiles.c (free_all_objfiles): Fix a typo.
10170
10171 2019-04-10  Tom Tromey  <tom@tromey.com>
10172
10173         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
10174         * minsyms.c (lookup_minimal_symbol): Use foreach.
10175         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
10176         (lookup_minimal_symbol_solib_trampoline): Likewise.
10177         * symfile.c (reread_symbols): Use foreach.
10178
10179 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
10180             Tom Tromey  <tromey@adacore.com>
10181
10182         PR rust/24414:
10183         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
10184         (rust_lex_int_test): Change "value" to be LONGEST.
10185         (rust_lex_tests): Add test for long integer literal.
10186
10187 2019-04-09  Tom Tromey  <tromey@adacore.com>
10188
10189         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
10190         to bool.
10191         (extended_remote_target::attach): Update.
10192         (remote_target::remote_notice_new_inferior): Update.
10193         (remote_target::add_current_inferior_and_thread): Update.
10194         * inferior.c (exit_inferior_1): Use "false".
10195         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
10196
10197 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
10198
10199         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
10200         the "start" command.
10201
10202 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
10203
10204         * python/py-inferior.c (infpy_thread_from_thread_handle):
10205         Adjust comments to reflect renaming of thread_from_thread_handle
10206         to thread_from_handle.  Adjust keywords.  Fix type error message.
10207         (inferior_object_methods): Add thread_from_handle.  Retain
10208         thread_from_thread_handle, but mark it as deprecated.
10209
10210 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
10211
10212         * gdbthread.h (find_thread_by_handle): Revise declaration.
10213         * thread.c (find_thread_by_handle): Likewise.  Adjust
10214         implementation too.
10215         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
10216         support for buffer objects as handles.
10217
10218 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
10219
10220         * python/py-infthread.c (thpy_thread_handle): New function.
10221         (thread_object_methods): Register thpy_thread_handle.
10222
10223 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
10224
10225         * gdbthread.h (thread_to_thread_handle): Declare.
10226         * thread.c (gdbtypes.h): Include.
10227         (thread_to_thread_handle): New function.
10228
10229         * target.h (struct target_ops): Add thread_info_to_thread_handle.
10230         (target_thread_info_to_thread_handle): Declare.
10231         * target.c (target_thread_info_to_thread_handle): New function.
10232         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
10233         * target-delegates.c: Regenerate.
10234
10235         * linux-thread-db.c (class thread_db_target): Add method
10236         thread_info_to_thread_handle.
10237         (thread_db_target::thread_info_to_thread_handle): Define.
10238         * remote.c (class remote_target): Add new method
10239         thread_info_to_thread_handle.
10240         (remote_target::thread_info_to_thread_handle): Define.
10241
10242 2019-04-08  Pedro Alves  <palves@redhat.com>
10243
10244         * common/common-exceptions.c (throw_exception): Don't create
10245         named object to throw; throw directly.
10246         (throw_it): Likewise.  Don't initialize gdb_exception::message
10247         here, with new; pass FMT and AP to the ctor instead.
10248         * common/common-exceptions.h: Include <string>.
10249         (gdb_exception::gdb_exception(enum return_reason, enum errors,
10250         const char *, va_list)): New ctor.  Use std::make_shared.
10251         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
10252         errors)): Delete.
10253         (gdb_exception_error::gdb_exception_error(enum errors, const char
10254         *, va_list)): New.
10255         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
10256         Add assertion.
10257         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
10258         errors)): Delete.
10259         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
10260         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
10261         Add assertion.
10262
10263 2019-04-08  Tom Tromey  <tom@tromey.com>
10264
10265         * valops.c (value_rtti_indirect_type): Replace throw_exception
10266         with throw.
10267         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
10268         with throw.
10269         * thread.c (thr_try_catch_cmd): Replace throw_exception with
10270         throw.
10271         * target.c (target_translate_tls_address): Replace throw_exception
10272         with throw.
10273         * stack.c (frame_apply_command_count): Replace throw_exception
10274         with throw.
10275         * solib-spu.c (append_ocl_sos): Replace throw_exception with
10276         throw.
10277         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
10278         with throw.
10279         * rs6000-tdep.c (rs6000_frame_cache)
10280         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
10281         * remote.c: Replace throw_exception with throw.
10282         * record-full.c (record_full_message, record_full_wait_1)
10283         (record_full_restore): Replace throw_exception with throw.
10284         * record-btrace.c:
10285         (get_thread_current_frame_id, record_btrace_start_replaying)
10286         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
10287         (cmd_record_btrace_start): Replace throw_exception with throw.
10288         * parse.c (parse_exp_in_context_1): Replace throw_exception with
10289         throw.
10290         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
10291         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
10292         * linespec.c:
10293         (find_linespec_symbols): Replace throw_exception with throw.
10294         * infrun.c (displaced_step_prepare, resume): Replace
10295         throw_exception with throw.
10296         * infcmd.c (post_create_inferior): Replace throw_exception with
10297         throw.
10298         * inf-loop.c (inferior_event_handler): Replace throw_exception
10299         with throw.
10300         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
10301         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
10302         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
10303         (get_prev_frame_always, get_frame_pc_if_available)
10304         (get_frame_address_in_block_if_available, get_frame_language):
10305         Replace throw_exception with throw.
10306         * frame-unwind.c (frame_unwind_try_unwinder): Replace
10307         throw_exception with throw.
10308         * eval.c (fetch_subexp_value, evaluate_var_value)
10309         (evaluate_funcall, evaluate_subexp_standard): Replace
10310         throw_exception with throw.
10311         * dwarf2loc.c (call_site_find_chain)
10312         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
10313         Replace throw_exception with throw.
10314         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
10315         with throw.
10316         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
10317         throw.
10318         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
10319         * completer.c (complete_line_internal): Replace throw_exception
10320         with throw.
10321         * compile/compile-object-run.c (compile_object_run): Replace
10322         throw_exception with throw.
10323         * cli/cli-script.c (process_next_line): Replace throw_exception
10324         with throw.
10325         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
10326         (btrace_enable, btrace_maint_update_pt_packets): Replace
10327         throw_exception with throw.
10328         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
10329         throw_exception with throw.
10330         * break-catch-throw.c (re_set_exception_catchpoint): Replace
10331         throw_exception with throw.
10332         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
10333         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
10334         * aarch64-tdep.c (aarch64_make_prologue_cache)
10335         (aarch64_make_stub_cache): Replace throw_exception with throw.
10336
10337 2019-04-08  Tom Tromey  <tom@tromey.com>
10338
10339         * common/common-exceptions.c (throw_exception): Rename from
10340         throw_exception_cxx.  Remove old copy.  Make argument const.
10341         (throw_it): Create and throw exception objects directly.
10342         * common/common-exceptions.h (throw_exception): Make argument
10343         const.
10344         (struct gdb_exception_error): Add constructor.
10345         (struct gdb_exception_quit): Add constructor.
10346
10347 2019-04-08  Tom Tromey  <tom@tromey.com>
10348
10349         * common/common-exceptions.h (exception_rethrow): Don't declare.
10350         (TRY_SJLJ): Update comment.
10351         (TRY, CATCH, END_CATCH): Remove.
10352         * common/common-exceptions.c (exception_rethrow): Remove.
10353
10354 2019-04-08  Tom Tromey  <tom@tromey.com>
10355
10356         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
10357         Remove.
10358         (gdb_exception_error): Rename from
10359         gdb_exception_RETURN_MASK_ERROR.
10360         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
10361         (gdb_quit_bad_alloc): Update.
10362         * aarch64-tdep.c: Update.
10363         * ada-lang.c: Update.
10364         * ada-typeprint.c: Update.
10365         * ada-valprint.c: Update.
10366         * amd64-tdep.c: Update.
10367         * arch-utils.c: Update.
10368         * break-catch-throw.c: Update.
10369         * breakpoint.c: Update.
10370         * btrace.c: Update.
10371         * c-varobj.c: Update.
10372         * cli/cli-cmds.c: Update.
10373         * cli/cli-interp.c: Update.
10374         * cli/cli-script.c: Update.
10375         * common/common-exceptions.c: Update.
10376         * common/new-op.c: Update.
10377         * common/selftest.c: Update.
10378         * compile/compile-c-symbols.c: Update.
10379         * compile/compile-cplus-symbols.c: Update.
10380         * compile/compile-object-load.c: Update.
10381         * compile/compile-object-run.c: Update.
10382         * completer.c: Update.
10383         * corelow.c: Update.
10384         * cp-abi.c: Update.
10385         * cp-support.c: Update.
10386         * cp-valprint.c: Update.
10387         * darwin-nat.c: Update.
10388         * disasm-selftests.c: Update.
10389         * dtrace-probe.c: Update.
10390         * dwarf-index-cache.c: Update.
10391         * dwarf-index-write.c: Update.
10392         * dwarf2-frame-tailcall.c: Update.
10393         * dwarf2-frame.c: Update.
10394         * dwarf2loc.c: Update.
10395         * dwarf2read.c: Update.
10396         * eval.c: Update.
10397         * event-loop.c: Update.
10398         * event-top.c: Update.
10399         * exec.c: Update.
10400         * f-valprint.c: Update.
10401         * fbsd-tdep.c: Update.
10402         * frame-unwind.c: Update.
10403         * frame.c: Update.
10404         * gdbtypes.c: Update.
10405         * gnu-v3-abi.c: Update.
10406         * guile/guile-internal.h: Update.
10407         * guile/scm-block.c: Update.
10408         * guile/scm-breakpoint.c: Update.
10409         * guile/scm-cmd.c: Update.
10410         * guile/scm-disasm.c: Update.
10411         * guile/scm-frame.c: Update.
10412         * guile/scm-lazy-string.c: Update.
10413         * guile/scm-math.c: Update.
10414         * guile/scm-param.c: Update.
10415         * guile/scm-ports.c: Update.
10416         * guile/scm-pretty-print.c: Update.
10417         * guile/scm-symbol.c: Update.
10418         * guile/scm-symtab.c: Update.
10419         * guile/scm-type.c: Update.
10420         * guile/scm-value.c: Update.
10421         * i386-linux-tdep.c: Update.
10422         * i386-tdep.c: Update.
10423         * inf-loop.c: Update.
10424         * infcall.c: Update.
10425         * infcmd.c: Update.
10426         * infrun.c: Update.
10427         * jit.c: Update.
10428         * language.c: Update.
10429         * linespec.c: Update.
10430         * linux-fork.c: Update.
10431         * linux-nat.c: Update.
10432         * linux-tdep.c: Update.
10433         * linux-thread-db.c: Update.
10434         * main.c: Update.
10435         * mi/mi-cmd-break.c: Update.
10436         * mi/mi-cmd-stack.c: Update.
10437         * mi/mi-interp.c: Update.
10438         * mi/mi-main.c: Update.
10439         * objc-lang.c: Update.
10440         * p-valprint.c: Update.
10441         * parse.c: Update.
10442         * ppc-linux-tdep.c: Update.
10443         * printcmd.c: Update.
10444         * python/py-arch.c: Update.
10445         * python/py-breakpoint.c: Update.
10446         * python/py-cmd.c: Update.
10447         * python/py-finishbreakpoint.c: Update.
10448         * python/py-frame.c: Update.
10449         * python/py-framefilter.c: Update.
10450         * python/py-gdb-readline.c: Update.
10451         * python/py-inferior.c: Update.
10452         * python/py-infthread.c: Update.
10453         * python/py-lazy-string.c: Update.
10454         * python/py-linetable.c: Update.
10455         * python/py-objfile.c: Update.
10456         * python/py-param.c: Update.
10457         * python/py-prettyprint.c: Update.
10458         * python/py-progspace.c: Update.
10459         * python/py-record-btrace.c: Update.
10460         * python/py-record.c: Update.
10461         * python/py-symbol.c: Update.
10462         * python/py-type.c: Update.
10463         * python/py-unwind.c: Update.
10464         * python/py-utils.c: Update.
10465         * python/py-value.c: Update.
10466         * python/python.c: Update.
10467         * record-btrace.c: Update.
10468         * record-full.c: Update.
10469         * remote-fileio.c: Update.
10470         * remote.c: Update.
10471         * riscv-tdep.c: Update.
10472         * rs6000-aix-tdep.c: Update.
10473         * rs6000-tdep.c: Update.
10474         * rust-exp.y: Update.
10475         * rust-lang.c: Update.
10476         * s390-tdep.c: Update.
10477         * selftest-arch.c: Update.
10478         * solib-dsbt.c: Update.
10479         * solib-frv.c: Update.
10480         * solib-spu.c: Update.
10481         * solib-svr4.c: Update.
10482         * solib.c: Update.
10483         * sparc64-linux-tdep.c: Update.
10484         * stack.c: Update.
10485         * symfile-mem.c: Update.
10486         * symmisc.c: Update.
10487         * target.c: Update.
10488         * thread.c: Update.
10489         * top.c: Update.
10490         * tracefile-tfile.c: Update.
10491         * tui/tui.c: Update.
10492         * typeprint.c: Update.
10493         * unittests/cli-utils-selftests.c: Update.
10494         * unittests/parse-connection-spec-selftests.c: Update.
10495         * valops.c: Update.
10496         * valprint.c: Update.
10497         * value.c: Update.
10498         * varobj.c: Update.
10499         * windows-nat.c: Update.
10500         * x86-linux-nat.c: Update.
10501         * xml-support.c: Update.
10502
10503 2019-04-08  Tom Tromey  <tom@tromey.com>
10504
10505         * xml-support.c: Use C++ exception handling.
10506         * x86-linux-nat.c: Use C++ exception handling.
10507         * windows-nat.c: Use C++ exception handling.
10508         * varobj.c: Use C++ exception handling.
10509         * value.c: Use C++ exception handling.
10510         * valprint.c: Use C++ exception handling.
10511         * valops.c: Use C++ exception handling.
10512         * unittests/parse-connection-spec-selftests.c: Use C++ exception
10513         handling.
10514         * unittests/cli-utils-selftests.c: Use C++ exception handling.
10515         * typeprint.c: Use C++ exception handling.
10516         * tui/tui.c: Use C++ exception handling.
10517         * tracefile-tfile.c: Use C++ exception handling.
10518         * top.c: Use C++ exception handling.
10519         * thread.c: Use C++ exception handling.
10520         * target.c: Use C++ exception handling.
10521         * symmisc.c: Use C++ exception handling.
10522         * symfile-mem.c: Use C++ exception handling.
10523         * stack.c: Use C++ exception handling.
10524         * sparc64-linux-tdep.c: Use C++ exception handling.
10525         * solib.c: Use C++ exception handling.
10526         * solib-svr4.c: Use C++ exception handling.
10527         * solib-spu.c: Use C++ exception handling.
10528         * solib-frv.c: Use C++ exception handling.
10529         * solib-dsbt.c: Use C++ exception handling.
10530         * selftest-arch.c: Use C++ exception handling.
10531         * s390-tdep.c: Use C++ exception handling.
10532         * rust-lang.c: Use C++ exception handling.
10533         * rust-exp.y: Use C++ exception handling.
10534         * rs6000-tdep.c: Use C++ exception handling.
10535         * rs6000-aix-tdep.c: Use C++ exception handling.
10536         * riscv-tdep.c: Use C++ exception handling.
10537         * remote.c: Use C++ exception handling.
10538         * remote-fileio.c: Use C++ exception handling.
10539         * record-full.c: Use C++ exception handling.
10540         * record-btrace.c: Use C++ exception handling.
10541         * python/python.c: Use C++ exception handling.
10542         * python/py-value.c: Use C++ exception handling.
10543         * python/py-utils.c: Use C++ exception handling.
10544         * python/py-unwind.c: Use C++ exception handling.
10545         * python/py-type.c: Use C++ exception handling.
10546         * python/py-symbol.c: Use C++ exception handling.
10547         * python/py-record.c: Use C++ exception handling.
10548         * python/py-record-btrace.c: Use C++ exception handling.
10549         * python/py-progspace.c: Use C++ exception handling.
10550         * python/py-prettyprint.c: Use C++ exception handling.
10551         * python/py-param.c: Use C++ exception handling.
10552         * python/py-objfile.c: Use C++ exception handling.
10553         * python/py-linetable.c: Use C++ exception handling.
10554         * python/py-lazy-string.c: Use C++ exception handling.
10555         * python/py-infthread.c: Use C++ exception handling.
10556         * python/py-inferior.c: Use C++ exception handling.
10557         * python/py-gdb-readline.c: Use C++ exception handling.
10558         * python/py-framefilter.c: Use C++ exception handling.
10559         * python/py-frame.c: Use C++ exception handling.
10560         * python/py-finishbreakpoint.c: Use C++ exception handling.
10561         * python/py-cmd.c: Use C++ exception handling.
10562         * python/py-breakpoint.c: Use C++ exception handling.
10563         * python/py-arch.c: Use C++ exception handling.
10564         * printcmd.c: Use C++ exception handling.
10565         * ppc-linux-tdep.c: Use C++ exception handling.
10566         * parse.c: Use C++ exception handling.
10567         * p-valprint.c: Use C++ exception handling.
10568         * objc-lang.c: Use C++ exception handling.
10569         * mi/mi-main.c: Use C++ exception handling.
10570         * mi/mi-interp.c: Use C++ exception handling.
10571         * mi/mi-cmd-stack.c: Use C++ exception handling.
10572         * mi/mi-cmd-break.c: Use C++ exception handling.
10573         * main.c: Use C++ exception handling.
10574         * linux-thread-db.c: Use C++ exception handling.
10575         * linux-tdep.c: Use C++ exception handling.
10576         * linux-nat.c: Use C++ exception handling.
10577         * linux-fork.c: Use C++ exception handling.
10578         * linespec.c: Use C++ exception handling.
10579         * language.c: Use C++ exception handling.
10580         * jit.c: Use C++ exception handling.
10581         * infrun.c: Use C++ exception handling.
10582         * infcmd.c: Use C++ exception handling.
10583         * infcall.c: Use C++ exception handling.
10584         * inf-loop.c: Use C++ exception handling.
10585         * i386-tdep.c: Use C++ exception handling.
10586         * i386-linux-tdep.c: Use C++ exception handling.
10587         * guile/scm-value.c: Use C++ exception handling.
10588         * guile/scm-type.c: Use C++ exception handling.
10589         * guile/scm-symtab.c: Use C++ exception handling.
10590         * guile/scm-symbol.c: Use C++ exception handling.
10591         * guile/scm-pretty-print.c: Use C++ exception handling.
10592         * guile/scm-ports.c: Use C++ exception handling.
10593         * guile/scm-param.c: Use C++ exception handling.
10594         * guile/scm-math.c: Use C++ exception handling.
10595         * guile/scm-lazy-string.c: Use C++ exception handling.
10596         * guile/scm-frame.c: Use C++ exception handling.
10597         * guile/scm-disasm.c: Use C++ exception handling.
10598         * guile/scm-cmd.c: Use C++ exception handling.
10599         * guile/scm-breakpoint.c: Use C++ exception handling.
10600         * guile/scm-block.c: Use C++ exception handling.
10601         * guile/guile-internal.h: Use C++ exception handling.
10602         * gnu-v3-abi.c: Use C++ exception handling.
10603         * gdbtypes.c: Use C++ exception handling.
10604         * frame.c: Use C++ exception handling.
10605         * frame-unwind.c: Use C++ exception handling.
10606         * fbsd-tdep.c: Use C++ exception handling.
10607         * f-valprint.c: Use C++ exception handling.
10608         * exec.c: Use C++ exception handling.
10609         * event-top.c: Use C++ exception handling.
10610         * event-loop.c: Use C++ exception handling.
10611         * eval.c: Use C++ exception handling.
10612         * dwarf2read.c: Use C++ exception handling.
10613         * dwarf2loc.c: Use C++ exception handling.
10614         * dwarf2-frame.c: Use C++ exception handling.
10615         * dwarf2-frame-tailcall.c: Use C++ exception handling.
10616         * dwarf-index-write.c: Use C++ exception handling.
10617         * dwarf-index-cache.c: Use C++ exception handling.
10618         * dtrace-probe.c: Use C++ exception handling.
10619         * disasm-selftests.c: Use C++ exception handling.
10620         * darwin-nat.c: Use C++ exception handling.
10621         * cp-valprint.c: Use C++ exception handling.
10622         * cp-support.c: Use C++ exception handling.
10623         * cp-abi.c: Use C++ exception handling.
10624         * corelow.c: Use C++ exception handling.
10625         * completer.c: Use C++ exception handling.
10626         * compile/compile-object-run.c: Use C++ exception handling.
10627         * compile/compile-object-load.c: Use C++ exception handling.
10628         * compile/compile-cplus-symbols.c: Use C++ exception handling.
10629         * compile/compile-c-symbols.c: Use C++ exception handling.
10630         * common/selftest.c: Use C++ exception handling.
10631         * common/new-op.c: Use C++ exception handling.
10632         * cli/cli-script.c: Use C++ exception handling.
10633         * cli/cli-interp.c: Use C++ exception handling.
10634         * cli/cli-cmds.c: Use C++ exception handling.
10635         * c-varobj.c: Use C++ exception handling.
10636         * btrace.c: Use C++ exception handling.
10637         * breakpoint.c: Use C++ exception handling.
10638         * break-catch-throw.c: Use C++ exception handling.
10639         * arch-utils.c: Use C++ exception handling.
10640         * amd64-tdep.c: Use C++ exception handling.
10641         * ada-valprint.c: Use C++ exception handling.
10642         * ada-typeprint.c: Use C++ exception handling.
10643         * ada-lang.c: Use C++ exception handling.
10644         * aarch64-tdep.c: Use C++ exception handling.
10645
10646 2019-04-08  Tom Tromey  <tom@tromey.com>
10647
10648         * xml-support.c (gdb_xml_parser::parse): Update.
10649         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
10650         * value.c (show_convenience): Update.
10651         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
10652         (test_parse_flags_qcs): Update.
10653         * thread.c (thr_try_catch_cmd): Update.
10654         * target.c (target_translate_tls_address): Update.
10655         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
10656         (info_frame_command_core, frame_apply_command_count): Update.
10657         * rust-exp.y (rust_lex_exception_test): Update.
10658         * riscv-tdep.c (riscv_print_one_register_info): Update.
10659         * remote.c (remote_target::enable_btrace): Update.
10660         * record-btrace.c (record_btrace_enable_warn): Update.
10661         * python/py-utils.c (gdbpy_convert_exception): Update.
10662         * printcmd.c (do_one_display, print_variable_and_value): Update.
10663         * mi/mi-main.c (mi_print_exception): Update.
10664         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
10665         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
10666         * linux-nat.c (linux_nat_target::attach): Update.
10667         * linux-fork.c (class scoped_switch_fork_info): Update.
10668         * infrun.c (displaced_step_prepare): Update.
10669         * infcall.c (call_function_by_hand_dummy): Update.
10670         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
10671         * gnu-v3-abi.c (print_one_vtable): Update.
10672         * frame.c (get_prev_frame_always): Update.
10673         * f-valprint.c (info_common_command_for_block): Update.
10674         * exec.c (try_open_exec_file): Update.
10675         * exceptions.c (print_exception, exception_print)
10676         (exception_fprintf, exception_print_same): Update.
10677         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
10678         * dwarf-index-cache.c (index_cache::store)
10679         (index_cache::lookup_gdb_index): Update.
10680         * darwin-nat.c (maybe_cache_shell): Update.
10681         * cp-valprint.c (cp_print_value_fields): Update.
10682         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
10683         (gcc_cplus_symbol_address): Update.
10684         * compile/compile-c-symbols.c (gcc_convert_symbol)
10685         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
10686         * common/selftest.c: Update.
10687         * common/common-exceptions.h (struct gdb_exception) <message>: Now
10688         a std::string.
10689         (exception_try_scope_entry, exception_try_scope_exit): Don't
10690         declare.
10691         (struct exception_try_scope): Remove.
10692         (TRY): Don't use exception_try_scope.
10693         (struct gdb_exception): Add constructor, operator=.
10694         <what>: New method.
10695         (struct gdb_exception_RETURN_MASK_ALL)
10696         (struct gdb_exception_RETURN_MASK_ERROR)
10697         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
10698         (struct gdb_quit_bad_alloc): Update.
10699         * common/common-exceptions.c (exception_none): Change
10700         initializer.
10701         (struct catcher) <state, exception>: Initialize inline.
10702         <prev>: Remove member.
10703         (current_catcher): Remove.
10704         (catchers): New global.
10705         (exceptions_state_mc_init): Simplify.
10706         (catcher_pop): Remove.
10707         (exceptions_state_mc, exceptions_state_mc_catch): Update.
10708         (try_scope_depth, exception_try_scope_entry)
10709         (exception_try_scope_exit): Remove.
10710         (throw_exception_sjlj): Update.
10711         (exception_messages, exception_messages_size): Remove.
10712         (throw_it): Simplify.
10713         (gdb_exception_sliced_copy): Remove.
10714         (throw_exception_cxx): Update.
10715         * cli/cli-script.c (script_from_file): Update.
10716         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
10717         Update.
10718         * ada-valprint.c (ada_val_print): Update.
10719         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
10720         (create_excep_cond_exprs): Update.
10721
10722 2019-04-08  Tom Tromey  <tom@tromey.com>
10723
10724         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
10725         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
10726         (TRY, CATCH, END_CATCH): Remove some definitions.
10727         * common/common-exceptions.c: Don't use GDB_XCPT.
10728         (catcher_list_size): Remove.
10729         (throw_exception, throw_it): Simplify.
10730
10731 2019-04-05  Tom Tromey  <tom@tromey.com>
10732
10733         Revert the header-sorting patch.
10734         * ft32-tdep.c: Revert.
10735         * frv-tdep.c: Revert.
10736         * frv-linux-tdep.c: Revert.
10737         * frame.c: Revert.
10738         * frame-unwind.c: Revert.
10739         * frame-base.c: Revert.
10740         * fork-child.c: Revert.
10741         * findvar.c: Revert.
10742         * findcmd.c: Revert.
10743         * filesystem.c: Revert.
10744         * filename-seen-cache.h: Revert.
10745         * filename-seen-cache.c: Revert.
10746         * fbsd-tdep.c: Revert.
10747         * fbsd-nat.h: Revert.
10748         * fbsd-nat.c: Revert.
10749         * f-valprint.c: Revert.
10750         * f-typeprint.c: Revert.
10751         * f-lang.c: Revert.
10752         * extension.h: Revert.
10753         * extension.c: Revert.
10754         * extension-priv.h: Revert.
10755         * expprint.c: Revert.
10756         * exec.h: Revert.
10757         * exec.c: Revert.
10758         * exceptions.c: Revert.
10759         * event-top.c: Revert.
10760         * event-loop.c: Revert.
10761         * eval.c: Revert.
10762         * elfread.c: Revert.
10763         * dwarf2read.h: Revert.
10764         * dwarf2read.c: Revert.
10765         * dwarf2loc.c: Revert.
10766         * dwarf2expr.h: Revert.
10767         * dwarf2expr.c: Revert.
10768         * dwarf2-frame.c: Revert.
10769         * dwarf2-frame-tailcall.c: Revert.
10770         * dwarf-index-write.h: Revert.
10771         * dwarf-index-write.c: Revert.
10772         * dwarf-index-common.c: Revert.
10773         * dwarf-index-cache.h: Revert.
10774         * dwarf-index-cache.c: Revert.
10775         * dummy-frame.c: Revert.
10776         * dtrace-probe.c: Revert.
10777         * disasm.h: Revert.
10778         * disasm.c: Revert.
10779         * disasm-selftests.c: Revert.
10780         * dictionary.c: Revert.
10781         * dicos-tdep.c: Revert.
10782         * demangle.c: Revert.
10783         * dcache.h: Revert.
10784         * dcache.c: Revert.
10785         * darwin-nat.h: Revert.
10786         * darwin-nat.c: Revert.
10787         * darwin-nat-info.c: Revert.
10788         * d-valprint.c: Revert.
10789         * d-namespace.c: Revert.
10790         * d-lang.c: Revert.
10791         * ctf.c: Revert.
10792         * csky-tdep.c: Revert.
10793         * csky-linux-tdep.c: Revert.
10794         * cris-tdep.c: Revert.
10795         * cris-linux-tdep.c: Revert.
10796         * cp-valprint.c: Revert.
10797         * cp-support.c: Revert.
10798         * cp-namespace.c: Revert.
10799         * cp-abi.c: Revert.
10800         * corelow.c: Revert.
10801         * corefile.c: Revert.
10802         * continuations.c: Revert.
10803         * completer.h: Revert.
10804         * completer.c: Revert.
10805         * complaints.c: Revert.
10806         * coffread.c: Revert.
10807         * coff-pe-read.c: Revert.
10808         * cli-out.h: Revert.
10809         * cli-out.c: Revert.
10810         * charset.c: Revert.
10811         * c-varobj.c: Revert.
10812         * c-valprint.c: Revert.
10813         * c-typeprint.c: Revert.
10814         * c-lang.c: Revert.
10815         * buildsym.c: Revert.
10816         * buildsym-legacy.c: Revert.
10817         * build-id.h: Revert.
10818         * build-id.c: Revert.
10819         * btrace.c: Revert.
10820         * bsd-uthread.c: Revert.
10821         * breakpoint.h: Revert.
10822         * breakpoint.c: Revert.
10823         * break-catch-throw.c: Revert.
10824         * break-catch-syscall.c: Revert.
10825         * break-catch-sig.c: Revert.
10826         * blockframe.c: Revert.
10827         * block.c: Revert.
10828         * bfin-tdep.c: Revert.
10829         * bfin-linux-tdep.c: Revert.
10830         * bfd-target.c: Revert.
10831         * bcache.c: Revert.
10832         * ax-general.c: Revert.
10833         * ax-gdb.h: Revert.
10834         * ax-gdb.c: Revert.
10835         * avr-tdep.c: Revert.
10836         * auxv.c: Revert.
10837         * auto-load.c: Revert.
10838         * arm-wince-tdep.c: Revert.
10839         * arm-tdep.c: Revert.
10840         * arm-symbian-tdep.c: Revert.
10841         * arm-pikeos-tdep.c: Revert.
10842         * arm-obsd-tdep.c: Revert.
10843         * arm-nbsd-tdep.c: Revert.
10844         * arm-nbsd-nat.c: Revert.
10845         * arm-linux-tdep.c: Revert.
10846         * arm-linux-nat.c: Revert.
10847         * arm-fbsd-tdep.c: Revert.
10848         * arm-fbsd-nat.c: Revert.
10849         * arm-bsd-tdep.c: Revert.
10850         * arch-utils.c: Revert.
10851         * arc-tdep.c: Revert.
10852         * arc-newlib-tdep.c: Revert.
10853         * annotate.h: Revert.
10854         * annotate.c: Revert.
10855         * amd64-windows-tdep.c: Revert.
10856         * amd64-windows-nat.c: Revert.
10857         * amd64-tdep.c: Revert.
10858         * amd64-sol2-tdep.c: Revert.
10859         * amd64-obsd-tdep.c: Revert.
10860         * amd64-obsd-nat.c: Revert.
10861         * amd64-nbsd-tdep.c: Revert.
10862         * amd64-nbsd-nat.c: Revert.
10863         * amd64-nat.c: Revert.
10864         * amd64-linux-tdep.c: Revert.
10865         * amd64-linux-nat.c: Revert.
10866         * amd64-fbsd-tdep.c: Revert.
10867         * amd64-fbsd-nat.c: Revert.
10868         * amd64-dicos-tdep.c: Revert.
10869         * amd64-darwin-tdep.c: Revert.
10870         * amd64-bsd-nat.c: Revert.
10871         * alpha-tdep.c: Revert.
10872         * alpha-obsd-tdep.c: Revert.
10873         * alpha-nbsd-tdep.c: Revert.
10874         * alpha-mdebug-tdep.c: Revert.
10875         * alpha-linux-tdep.c: Revert.
10876         * alpha-linux-nat.c: Revert.
10877         * alpha-bsd-tdep.c: Revert.
10878         * alpha-bsd-nat.c: Revert.
10879         * aix-thread.c: Revert.
10880         * agent.c: Revert.
10881         * addrmap.c: Revert.
10882         * ada-varobj.c: Revert.
10883         * ada-valprint.c: Revert.
10884         * ada-typeprint.c: Revert.
10885         * ada-tasks.c: Revert.
10886         * ada-lang.c: Revert.
10887         * aarch64-tdep.c: Revert.
10888         * aarch64-ravenscar-thread.c: Revert.
10889         * aarch64-newlib-tdep.c: Revert.
10890         * aarch64-linux-tdep.c: Revert.
10891         * aarch64-linux-nat.c: Revert.
10892         * aarch64-fbsd-tdep.c: Revert.
10893         * aarch64-fbsd-nat.c: Revert.
10894         * aarch32-linux-nat.c: Revert.
10895
10896 2019-04-05  Tom Tromey  <tom@tromey.com>
10897
10898         * ft32-tdep.c: Sort headers.
10899         * frv-tdep.c: Sort headers.
10900         * frv-linux-tdep.c: Sort headers.
10901         * frame.c: Sort headers.
10902         * frame-unwind.c: Sort headers.
10903         * frame-base.c: Sort headers.
10904         * fork-child.c: Sort headers.
10905         * findvar.c: Sort headers.
10906         * findcmd.c: Sort headers.
10907         * filesystem.c: Sort headers.
10908         * filename-seen-cache.h: Sort headers.
10909         * filename-seen-cache.c: Sort headers.
10910         * fbsd-tdep.c: Sort headers.
10911         * fbsd-nat.h: Sort headers.
10912         * fbsd-nat.c: Sort headers.
10913         * f-valprint.c: Sort headers.
10914         * f-typeprint.c: Sort headers.
10915         * f-lang.c: Sort headers.
10916         * extension.h: Sort headers.
10917         * extension.c: Sort headers.
10918         * extension-priv.h: Sort headers.
10919         * expprint.c: Sort headers.
10920         * exec.h: Sort headers.
10921         * exec.c: Sort headers.
10922         * exceptions.c: Sort headers.
10923         * event-top.c: Sort headers.
10924         * event-loop.c: Sort headers.
10925         * eval.c: Sort headers.
10926         * elfread.c: Sort headers.
10927         * dwarf2read.h: Sort headers.
10928         * dwarf2read.c: Sort headers.
10929         * dwarf2loc.c: Sort headers.
10930         * dwarf2expr.h: Sort headers.
10931         * dwarf2expr.c: Sort headers.
10932         * dwarf2-frame.c: Sort headers.
10933         * dwarf2-frame-tailcall.c: Sort headers.
10934         * dwarf-index-write.h: Sort headers.
10935         * dwarf-index-write.c: Sort headers.
10936         * dwarf-index-common.c: Sort headers.
10937         * dwarf-index-cache.h: Sort headers.
10938         * dwarf-index-cache.c: Sort headers.
10939         * dummy-frame.c: Sort headers.
10940         * dtrace-probe.c: Sort headers.
10941         * disasm.h: Sort headers.
10942         * disasm.c: Sort headers.
10943         * disasm-selftests.c: Sort headers.
10944         * dictionary.c: Sort headers.
10945         * dicos-tdep.c: Sort headers.
10946         * demangle.c: Sort headers.
10947         * dcache.h: Sort headers.
10948         * dcache.c: Sort headers.
10949         * darwin-nat.h: Sort headers.
10950         * darwin-nat.c: Sort headers.
10951         * darwin-nat-info.c: Sort headers.
10952         * d-valprint.c: Sort headers.
10953         * d-namespace.c: Sort headers.
10954         * d-lang.c: Sort headers.
10955         * ctf.c: Sort headers.
10956         * csky-tdep.c: Sort headers.
10957         * csky-linux-tdep.c: Sort headers.
10958         * cris-tdep.c: Sort headers.
10959         * cris-linux-tdep.c: Sort headers.
10960         * cp-valprint.c: Sort headers.
10961         * cp-support.c: Sort headers.
10962         * cp-namespace.c: Sort headers.
10963         * cp-abi.c: Sort headers.
10964         * corelow.c: Sort headers.
10965         * corefile.c: Sort headers.
10966         * continuations.c: Sort headers.
10967         * completer.h: Sort headers.
10968         * completer.c: Sort headers.
10969         * complaints.c: Sort headers.
10970         * coffread.c: Sort headers.
10971         * coff-pe-read.c: Sort headers.
10972         * cli-out.h: Sort headers.
10973         * cli-out.c: Sort headers.
10974         * charset.c: Sort headers.
10975         * c-varobj.c: Sort headers.
10976         * c-valprint.c: Sort headers.
10977         * c-typeprint.c: Sort headers.
10978         * c-lang.c: Sort headers.
10979         * buildsym.c: Sort headers.
10980         * buildsym-legacy.c: Sort headers.
10981         * build-id.h: Sort headers.
10982         * build-id.c: Sort headers.
10983         * btrace.c: Sort headers.
10984         * bsd-uthread.c: Sort headers.
10985         * breakpoint.h: Sort headers.
10986         * breakpoint.c: Sort headers.
10987         * break-catch-throw.c: Sort headers.
10988         * break-catch-syscall.c: Sort headers.
10989         * break-catch-sig.c: Sort headers.
10990         * blockframe.c: Sort headers.
10991         * block.c: Sort headers.
10992         * bfin-tdep.c: Sort headers.
10993         * bfin-linux-tdep.c: Sort headers.
10994         * bfd-target.c: Sort headers.
10995         * bcache.c: Sort headers.
10996         * ax-general.c: Sort headers.
10997         * ax-gdb.h: Sort headers.
10998         * ax-gdb.c: Sort headers.
10999         * avr-tdep.c: Sort headers.
11000         * auxv.c: Sort headers.
11001         * auto-load.c: Sort headers.
11002         * arm-wince-tdep.c: Sort headers.
11003         * arm-tdep.c: Sort headers.
11004         * arm-symbian-tdep.c: Sort headers.
11005         * arm-pikeos-tdep.c: Sort headers.
11006         * arm-obsd-tdep.c: Sort headers.
11007         * arm-nbsd-tdep.c: Sort headers.
11008         * arm-nbsd-nat.c: Sort headers.
11009         * arm-linux-tdep.c: Sort headers.
11010         * arm-linux-nat.c: Sort headers.
11011         * arm-fbsd-tdep.c: Sort headers.
11012         * arm-fbsd-nat.c: Sort headers.
11013         * arm-bsd-tdep.c: Sort headers.
11014         * arch-utils.c: Sort headers.
11015         * arc-tdep.c: Sort headers.
11016         * arc-newlib-tdep.c: Sort headers.
11017         * annotate.h: Sort headers.
11018         * annotate.c: Sort headers.
11019         * amd64-windows-tdep.c: Sort headers.
11020         * amd64-windows-nat.c: Sort headers.
11021         * amd64-tdep.c: Sort headers.
11022         * amd64-sol2-tdep.c: Sort headers.
11023         * amd64-obsd-tdep.c: Sort headers.
11024         * amd64-obsd-nat.c: Sort headers.
11025         * amd64-nbsd-tdep.c: Sort headers.
11026         * amd64-nbsd-nat.c: Sort headers.
11027         * amd64-nat.c: Sort headers.
11028         * amd64-linux-tdep.c: Sort headers.
11029         * amd64-linux-nat.c: Sort headers.
11030         * amd64-fbsd-tdep.c: Sort headers.
11031         * amd64-fbsd-nat.c: Sort headers.
11032         * amd64-dicos-tdep.c: Sort headers.
11033         * amd64-darwin-tdep.c: Sort headers.
11034         * amd64-bsd-nat.c: Sort headers.
11035         * alpha-tdep.c: Sort headers.
11036         * alpha-obsd-tdep.c: Sort headers.
11037         * alpha-nbsd-tdep.c: Sort headers.
11038         * alpha-mdebug-tdep.c: Sort headers.
11039         * alpha-linux-tdep.c: Sort headers.
11040         * alpha-linux-nat.c: Sort headers.
11041         * alpha-bsd-tdep.c: Sort headers.
11042         * alpha-bsd-nat.c: Sort headers.
11043         * aix-thread.c: Sort headers.
11044         * agent.c: Sort headers.
11045         * addrmap.c: Sort headers.
11046         * ada-varobj.c: Sort headers.
11047         * ada-valprint.c: Sort headers.
11048         * ada-typeprint.c: Sort headers.
11049         * ada-tasks.c: Sort headers.
11050         * ada-lang.c: Sort headers.
11051         * aarch64-tdep.c: Sort headers.
11052         * aarch64-ravenscar-thread.c: Sort headers.
11053         * aarch64-newlib-tdep.c: Sort headers.
11054         * aarch64-linux-tdep.c: Sort headers.
11055         * aarch64-linux-nat.c: Sort headers.
11056         * aarch64-fbsd-tdep.c: Sort headers.
11057         * aarch64-fbsd-nat.c: Sort headers.
11058         * aarch32-linux-nat.c: Sort headers.
11059
11060 2019-04-04  Tom Tromey  <tom@tromey.com>
11061
11062         * varobj.c (varobj_create): Update.
11063         * rust-exp.y (struct rust_parser) <update_innermost_block,
11064         lookup_symbol>: New methods.
11065         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
11066         Rename.
11067         (rust_parser::rust_lookup_type)
11068         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
11069         * printcmd.c (display_command, do_one_display): Update.
11070         * parser-defs.h (struct parser_state) <parser_state>: Add
11071         "tracker" parameter.
11072         (block_tracker): New member.
11073         (class innermost_block_tracker) <innermost_block_tracker>: Add
11074         "types" parameter.
11075         <reset>: Remove method.
11076         (innermost_block): Don't declare.
11077         (null_post_parser): Update.
11078         * parse.c (innermost_block): Remove global.
11079         (write_dollar_variable): Update.
11080         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
11081         Remove "tracker_types" parameter.
11082         (parse_expression): Add "tracker" parameter.
11083         (parse_expression_for_completion): Update.
11084         (null_post_parser): Add "tracker" parameter.
11085         * p-exp.y: Update rules.
11086         * m2-exp.y: Update rules.
11087         * language.h (struct language_defn) <la_post_parser>: Add
11088         "tracker" parameter.
11089         * go-exp.y: Update rules.
11090         * f-exp.y: Update rules.
11091         * expression.h (parse_expression, parse_exp_1): Add "tracker"
11092         parameter.
11093         * d-exp.y: Update rules.
11094         * c-exp.y: Update rules.
11095         * breakpoint.c (set_breakpoint_condition): Create an
11096         innermost_block_tracker.
11097         (watch_command_1): Likewise.
11098         * ada-lang.c (resolve): Add "tracker" parameter.
11099         (resolve_subexp): Likewise.
11100         * ada-exp.y (write_var_from_sym): Update.
11101
11102 2019-04-04  Tom Tromey  <tom@tromey.com>
11103
11104         * type-stack.h: New file.
11105         * type-stack.c: New file.
11106         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
11107         type-stack.h.
11108         (insert_into_type_stack, insert_type, push_type, push_type_int)
11109         (insert_type_address_space, pop_type, pop_type_int)
11110         (pop_typelist, pop_type_stack, append_type_stack)
11111         (push_type_stack, get_type_stack, push_typelist)
11112         (follow_type_instance_flags, follow_types): Don't declare.
11113         * parse.c (type_stack): Remove global.
11114         (parse_exp_in_context): Update.
11115         (insert_into_type_stack, insert_type, push_type, push_type_int)
11116         (insert_type_address_space, pop_type, pop_type_int)
11117         (pop_typelist, pop_type_stack, append_type_stack)
11118         (push_type_stack, get_type_stack, push_typelist)
11119         (follow_type_instance_flags, follow_types): Remove (moved to
11120         type-stack.c).
11121         * f-exp.y (type_stack): New global.
11122         Update rules.
11123         (push_kind_type, f_parse): Update.
11124         * d-exp.y (type_stack): New global.
11125         Update rules.
11126         (d_parse): Update.
11127         * c-exp.y (struct c_parse_state) <type_stack>: New member.
11128         Update rules.
11129         * Makefile.in (COMMON_SFILES): Add type-stack.c.
11130         (HFILES_NO_SRCDIR): Add type-stack.h.
11131
11132 2019-04-04  Tom Tromey  <tom@tromey.com>
11133
11134         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
11135         (rust_parser::convert_ast_to_expression, rust_parse)
11136         (rust_lex_test_completion, rust_lex_tests): Update.
11137         * parser-defs.h (struct expr_completion_state): New.
11138         (struct parser_state) <parser_state>: Add completion parameter.
11139         <mark_struct_expression, mark_completion_tag>: New methods.
11140         <parse_completion, m_completion_state>: New members.
11141         (prefixify_expression, null_post_parser): Update.
11142         (mark_struct_expression, mark_completion_tag): Don't declare.
11143         * parse.c (parse_completion, expout_last_struct)
11144         (expout_tag_completion_type, expout_completion_name): Remove
11145         globals.
11146         (parser_state::mark_struct_expression)
11147         (parser_state::mark_completion_tag): Now methods.
11148         (prefixify_expression): Add last_struct parameter.
11149         (prefixify_subexp): Likewise.
11150         (parse_exp_1): Update.
11151         (parse_exp_in_context): Add cstate parameter.  Update.
11152         (parse_expression_for_completion): Create an
11153         expr_completion_state.
11154         (null_post_parser): Add "completion" parameter.
11155         * p-exp.y: Update rules.
11156         (yylex): Update.
11157         * language.h (struct language_defn) <la_post_parser>: Add
11158         "completing" parameter.
11159         * go-exp.y: Update rules.
11160         (lex_one_token): Update.
11161         * expression.h (parse_completion): Don't declare.
11162         * d-exp.y: Update rules.
11163         (lex_one_token): Update rules.
11164         * c-exp.y: Update rules.
11165         (lex_one_token): Update.
11166         * ada-lang.c (resolve): Add "parse_completion" parameter.
11167         (resolve_subexp): Likewise.
11168         (ada_resolve_function): Likewise.
11169
11170 2019-04-04  Tom Tromey  <tom@tromey.com>
11171
11172         * parser-defs.h (struct parser_state) <start_arglist,
11173         end_arglist>: New methods.
11174         <arglist_len, m_funcall_chain>: New members.
11175         (arglist_len, start_arglist, end_arglist): Don't declare.
11176         * parse.c (arglist_len, funcall_chain): Remove global.
11177         (start_arglist, end_arglist): Remove functions.
11178         (parse_exp_in_context): Update.
11179         * p-exp.y: Update rules.
11180         * m2-exp.y: Update rules.
11181         * go-exp.y: Update rules.
11182         * f-exp.y: Update rules.
11183         * d-exp.y: Update rules.
11184         * c-exp.y: Update rules.
11185
11186 2019-04-04  Tom Tromey  <tom@tromey.com>
11187
11188         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
11189         lex_operator, push_back>: New methods.
11190         Update all rules.
11191         (rust_parser::lex_hex, lex_escape): Rename and update.
11192         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
11193         (rust_parser::lex_operator): Rename and update.
11194         (rust_parser::lex_number, rustyylex, rustyyerror)
11195         (rust_lex_test_init, rust_lex_test_sequence)
11196         (rust_lex_test_push_back, rust_lex_tests): Update.
11197         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
11198         parameter.
11199         <lexptr, prev_lexptr>: New members.
11200         (lexptr, prev_lexptr): Don't declare.
11201         * parse.c (lexptr, prev_lexptr): Remove globals.
11202         (parse_exp_in_context): Update.
11203         * p-exp.y (yylex, yyerror): Update.
11204         * m2-exp.y (parse_number, yylex, yyerror): Update.
11205         * go-exp.y (lex_one_token, yyerror): Update.
11206         * f-exp.y (match_string_literal, yylex, yyerror): Update.
11207         * d-exp.y (lex_one_token, yyerror): Update.
11208         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
11209         (lex_one_token, yyerror): Update.
11210         * ada-lex.l (YY_INPUT): Update.
11211         (rewind_to_char): Update.
11212         * ada-exp.y (yyerror): Update.
11213
11214 2019-04-04  Tom Tromey  <tom@tromey.com>
11215
11216         * rust-exp.y (rustyylex, rust_lex_tests): Update.
11217         * parser-defs.h (struct parser_state) <parser_state>: Add new
11218         parameter.
11219         <comma_terminates>: New member.
11220         (comma_terminates): Don't declare global.
11221         * parse.c (comma_terminates): Remove global.
11222         (parse_exp_in_context): Update.
11223         * p-exp.y (yylex): Update.
11224         * m2-exp.y (yylex): Update.
11225         * go-exp.y (lex_one_token): Update.
11226         * f-exp.y (yylex): Update.
11227         * d-exp.y (lex_one_token): Update.
11228         * c-exp.y (lex_one_token): Update.
11229         * ada-lex.l: Update.
11230
11231 2019-04-04  Tom Tromey  <tom@tromey.com>
11232
11233         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
11234         (rustyylex, rust_lex_test_init, rust_lex_test_one)
11235         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
11236         * parser-defs.h (paren_depth): Don't declare.
11237         * parse.c (paren_depth): Remove global.
11238         (parse_exp_in_context): Update.
11239         * p-exp.y (paren_depth): New global.
11240         (pascal_parse): Initialize it.
11241         * m2-exp.y (paren_depth): New global.
11242         (m2_parse): Initialize it.
11243         * go-exp.y (paren_depth): New global.
11244         (go_parse): Initialize it.
11245         * f-exp.y (paren_depth): New global.
11246         (f_parse): Initialize it.
11247         * d-exp.y (paren_depth): New global.
11248         (d_parse): Initialize it.
11249         * c-exp.y (paren_depth): New global.
11250         (c_parse): Initialize it.
11251         * ada-lex.l (paren_depth): New global.
11252         (lexer_init): Initialize it.
11253
11254 2019-04-04  Tom Tromey  <tom@tromey.com>
11255
11256         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
11257         (rust_parser::convert_ast_to_type)
11258         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
11259         * parser-defs.h (struct parser_state) <parser_state>: Add
11260         parameters.  Initialize new members.
11261         <expression_context_block, expression_context_pc>: New members.
11262         * parse.c (expression_context_block, expression_context_pc):
11263         Remove globals.
11264         (parse_exp_in_context): Update.
11265         * p-exp.y: Update all rules.
11266         (yylex): Update.
11267         * m2-exp.y: Update all rules.
11268         (yylex): Update.
11269         * go-exp.y (yylex): Update.
11270         * f-exp.y (yylex): Update.
11271         * d-exp.y: Update all rules.
11272         (yylex): Update.
11273         * c-exp.y: Update all rules.
11274         (lex_one_token, classify_name, yylex, c_parse): Update.
11275         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
11276
11277 2019-04-04  Tom Tromey  <tom@tromey.com>
11278
11279         * gdbarch.h, gdbarch.c: Rebuild.
11280         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
11281         * stap-probe.h:
11282         (struct stap_parse_info): Replace "parser_state" with
11283         "expr_builder".
11284         * parser-defs.h (struct expr_builder): Rename from "parser_state".
11285         (parser_state): New class.
11286         * parse.c (expr_builder): Rename.
11287         (expr_builder::release): Rename.
11288         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
11289         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
11290         (write_exp_elt_longcst, write_exp_elt_floatcst)
11291         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
11292         (write_exp_string_vector, write_exp_bitstring)
11293         (write_exp_msymbol, mark_struct_expression)
11294         (write_dollar_variable)
11295         (insert_type_address_space, increase_expout_size): Replace
11296         "parser_state" with "expr_builder".
11297         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
11298         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
11299         "parser_state" with "expr_builder".
11300
11301 2019-04-04  Tom Tromey  <tom@tromey.com>
11302
11303         * rust-exp.y: Replace "parse_language" with method call.
11304         * p-exp.y:
11305         (yylex): Replace "parse_language" with method call.
11306         * m2-exp.y:
11307         (yylex): Replace "parse_language" with method call.
11308         * go-exp.y (classify_name): Replace "parse_language" with method
11309         call.
11310         * f-exp.y (yylex): Replace "parse_language" with method call.
11311         * d-exp.y (lex_one_token): Replace "parse_language" with method
11312         call.
11313         * c-exp.y:
11314         (lex_one_token, classify_name, yylex): Replace "parse_language"
11315         with method call.
11316         * ada-exp.y (find_primitive_type, type_char)
11317         (type_system_address): Replace "parse_language" with method call.
11318
11319 2019-04-04  Tom Tromey  <tom@tromey.com>
11320
11321         * rust-exp.y: Replace "parse_gdbarch" with method call.
11322         * parse.c (write_dollar_variable, insert_type_address_space):
11323         Replace "parse_gdbarch" with method call.
11324         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
11325         call.
11326         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
11327         call.
11328         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
11329         "parse_gdbarch" with method call.
11330         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
11331         with method call.
11332         * f-exp.y (parse_type, parse_f_type, yylex): Replace
11333         "parse_gdbarch" with method call.
11334         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
11335         "parse_gdbarch" with method call.
11336         * c-exp.y (parse_type, parse_number, classify_name): Replace
11337         "parse_gdbarch" with method call.
11338         * ada-lex.l: Replace "parse_gdbarch" with method call.
11339         * ada-exp.y (parse_type, find_primitive_type, type_char)
11340         (type_system_address): Replace "parse_gdbarch" with method call.
11341
11342 2019-04-04  Tom Tromey  <tom@tromey.com>
11343
11344         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
11345         * stap-probe.c (stap_parse_argument): Update.
11346         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
11347         initial_size parameter.
11348         * rust-exp.y (rust_lex_tests): Update.
11349         * parse.c (parser_state): Update.
11350         (parse_exp_in_context): Update.
11351         * parser-defs.h (struct parser_state) <parser_state>: Remove
11352         "initial_size" parameter.
11353
11354 2019-04-04  Tom Tromey  <tom@tromey.com>
11355
11356         * parser-defs.h (increase_expout_size): Don't declare.
11357         * parse.c (increase_expout_size): Now static.
11358
11359 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
11360
11361         * gnu-nat.c (gnu_nat_target::wait): Fix
11362         target_waitstatus_to_string call.
11363
11364 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
11365
11366         * eval.c (evaluate_subexp_standard): Handle internal functions
11367         during Fortran function call handling.
11368
11369 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
11370
11371         * NEWS: Mention new internal functions.
11372         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
11373         (read_base_type): Use dwarf2_init_complex_target_type.
11374         * value.c (creal_internal_fn): New function.
11375         (cimag_internal_fn): New function.
11376         (_initialize_values): Register new internal functions.
11377
11378 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11379
11380         * infrun.c (stop_all_threads): If debug_infrun, always
11381         trace the wait status after wait_one, using
11382         target_waitstatus_to_string and target_pid_to_str.
11383         (handle_inferior_event): Replace various trace of
11384         wait status kind by a single trace.
11385         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
11386         wait status kind image by target_waitstatus_to_string.
11387         * target/waitstatus.c (target_waitstatus_to_string): Fix
11388         obsolete comment.
11389
11390 2019-04-01  Tom Tromey  <tromey@adacore.com>
11391
11392         PR symtab/23331:
11393         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
11394
11395 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
11396             Pedro Alves  <palves@redhat.com>
11397
11398         * top.c (quit_force): Call 'finalize_values'.
11399         * value.c (finalize_values): New function.
11400         * value.h (finalize_values): Declare.
11401
11402 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
11403
11404         * NEWS: Announce $_gdb_major and $_gdb_minor.
11405
11406         * top.c (init_gdb_version_vars): New function.
11407         (gdb_init): Call init_gdb_version_vars.
11408
11409 2019-03-29  Tom Tromey  <tromey@adacore.com>
11410
11411         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
11412         help text.  Remove dead code.
11413
11414 2019-03-29  Keith Seitz  <keiths@redhat.com>
11415
11416         From Siddhesh Poyarekar:
11417         * f-lang.h (f77_get_upperbound): Return LONGEST.
11418         (f77_get_lowerbound): Likewise.
11419         * f-typeprint.c (f_type_print_varspec_suffix): Expand
11420         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
11421         print them.
11422         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
11423         plongest to format print it.
11424         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
11425         (f77_get_upperbound): Likewise.
11426         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
11427         LOWER_BOUND to LONGEST.
11428         (f77_create_arrayprint_offset_tbl): Likewise.
11429
11430 2019-03-29  Keith Seitz  <keiths@redhat.com>
11431
11432         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
11433         %s/pulongest for TYPE_LENGTH instead of %d in format
11434         strings.
11435         * ada-typerint.c (ada_print_type): Likewise.
11436         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
11437         * compile/compile-c-support.c (generate_register_struct): Likewise.
11438         * gdbtypes.c (recursive_dump_type): Likewise.
11439         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
11440         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
11441         instead of %d in format strings.
11442         * riscv-tdep.c (riscv_type_alignment): Cast second argument
11443         to std::min to ULONGEST.
11444         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
11445         instead of %d in format strings.
11446         * tracepoint.c (info_scope_command): Likewise.
11447         * typeprint.c (print_offset_data::update)
11448         (print_offset_data::finish): Likewise.
11449         * xtensa-tdep.c (xtensa_store_return_value)
11450         (xtensa_push_dummy_call): Likewise.
11451
11452 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
11453
11454         * windows-nat.c (display_selector): Fixed format specifications
11455         for 64-bit Cygwin.
11456
11457 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11458
11459         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
11460
11461 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
11462
11463         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
11464         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
11465         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
11466         (nios2_linux_init_abi): Install it.
11467
11468 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
11469
11470         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
11471
11472 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
11473
11474         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
11475
11476 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11477             Tom Tromey  <tromey@adacore.com>
11478
11479         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
11480
11481 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
11482
11483         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
11484         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
11485         method to compute the bounds of range types. Also print "[evaluated]"
11486         if the bounds' values come from a dynamic evaluation.
11487
11488 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
11489
11490         * cp-valprint.c (cp_print_value_fields): Don't print trailing
11491         whitespace when pretty printing is on.
11492
11493 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
11494
11495         * ppc-linux-nat.c: Add include.
11496
11497 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
11498
11499         * NEWS: Mention AArch64 Pointer Authentication.
11500
11501 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
11502
11503         * arm-linux-nat.c: Add include.
11504
11505 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
11506
11507         * source-cache.c (source_cache::get_source_lines): Re-read
11508         fullname after calling open_source_file.
11509
11510 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
11511
11512         * NEWS: Mention TLS support for FreeBSD.
11513
11514 2019-03-25  Tom Tromey  <tromey@adacore.com>
11515
11516         * minsyms.c (BUNCH_SIZE): Update comment.
11517         (~minimal_symbol_reader): Remove old comment.
11518         (compact_minimal_symbols): Update comment.
11519         (minimal_symbol_reader::install): Remove old comment.  Update
11520         other comments.
11521
11522 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
11523
11524         * s390-linux-nat.c: Add include.
11525
11526 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
11527
11528         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
11529         Call linux_get_hwcap.
11530         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
11531         Likewise.
11532         (aarch64_linux_get_hwcap): Remove function.
11533         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
11534         declaration.
11535         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
11536         linux_get_hwcap.
11537         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
11538         * linux-tdep.c (linux_get_hwcap): Add function.
11539         (linux_get_hwcap2): Likewise.
11540         * linux-tdep.h (linux_get_hwcap): Add declaration.
11541         (linux_get_hwcap2): Likewise.
11542         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
11543         (ppc_linux_get_hwcap2): Likewise.
11544         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
11545         linux_get_hwcap.
11546         (ppc_linux_nat_target::insert_watchpoint): Likewise.
11547         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
11548         (ppc_linux_nat_target::read_description): Likewise.
11549         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
11550         * s390-linux-nat.c: Likewise.
11551         * s390-linux-tdep.c (s390_core_read_description): Likewise.
11552
11553 2019-03-24  Tom Tromey  <tom@tromey.com>
11554
11555         * ada-lang.c (standard_lookup): Simplify initialization.
11556         (ada_lookup_symbol_nonlocal): Simplify return.
11557         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
11558         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
11559         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
11560         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
11561         initialization.
11562         * solib.c (solib_global_lookup): Simplify.
11563         * symtab.c (null_block_symbol): Remove.
11564         (symbol_cache_lookup): Simplify returns.
11565         (lookup_language_this): Simplify returns.
11566         (lookup_symbol_aux): Simplify return.
11567         (lookup_local_symbol): Simplify returns.
11568         (lookup_global_symbol_from_objfile): Simplify return.
11569         (lookup_symbol_in_objfile_symtabs)
11570         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
11571         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
11572         (lookup_static_symbol, lookup_global_symbol): Simplify return.
11573         * cp-namespace.c (cp_lookup_bare_symbol)
11574         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
11575         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
11576         (cp_lookup_nested_symbol): Don't use null_block_symbol.
11577         (cp_lookup_symbol_via_imports): Simplify initialization.
11578         (find_symbol_in_baseclass): Likewise.
11579         * symtab.h (null_block_symbol): Remove.
11580         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
11581         (d_lookup_nested_symbol, d_lookup_symbol_imports)
11582         (d_lookup_symbol_module): Likewise.
11583         (find_symbol_in_baseclass): Simplify initialization.
11584
11585 2019-03-24  Tom Tromey  <tom@tromey.com>
11586
11587         * expression.h: Don't include symtab.h.
11588         (struct block): Forward declare.
11589
11590 2019-03-24  Tom Tromey  <tom@tromey.com>
11591
11592         * c-exp.y (typebase): Remove casts.
11593         * gdbtypes.c (lookup_unsigned_typename, )
11594         (lookup_signed_typename): Remove cast.
11595         * eval.c (parse_to_comma_and_eval): Remove cast.
11596         * parse.c (write_dollar_variable): Remove cast.
11597         * block.h (struct block) <superblock>: Now const.
11598         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
11599         * psymtab.c (psym_map_matching_symbols): Make "block" const.
11600         (map_block): Make "block" const.
11601         * symfile.h (struct quick_symbol_functions)
11602         <map_matching_symbols>: Constify block argument to "callback".
11603         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
11604         const.
11605         (find_pc_sect_compunit_symtab): Make "b" const.
11606         (find_symbol_at_address): Likewise.
11607         (search_symbols): Likewise.
11608         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
11609         (dw2_debug_names_lookup_symbol): Likewise.
11610         (dw2_map_matching_symbols): Update.
11611         * p-valprint.c (pascal_val_print): Remove "block".
11612         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
11613         (aux_add_nonlocal_symbols): Make "block" const.
11614         (resolve_subexp): Remove cast.
11615         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
11616         const.
11617         (iterate_over_file_blocks): Likewise.
11618         * f-exp.y (%union) <bval>: Remove.
11619         * coffread.c (patch_opaque_types): Make "b" const.
11620         * spu-tdep.c (spu_catch_start): Make "block" const.
11621         * c-valprint.c (print_unpacked_pointer): Remove "block".
11622         * symmisc.c (dump_symtab_1): Make "b" const.
11623         (block_depth): Make "block" const.
11624         * d-exp.y (%union) <bval>: Remove.
11625         * cp-support.h (cp_lookup_rtti_type): Update.
11626         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
11627         * psymtab.c (psym_lookup_symbol): Make "block" const.
11628         (maintenance_check_psymtabs): Make "b" const.
11629         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
11630         (enumerate_locals, enumerate_args): Update.
11631         * python/py-symtab.c (stpy_global_block): Make "block" const.
11632         (stpy_static_block): Likewise.
11633         * inline-frame.c (block_starting_point_at): Make "new_block"
11634         const.
11635         * block.c (find_block_in_blockvector): Make return type const.
11636         (blockvector_for_pc_sect): Make "b" const.
11637         (find_block_in_blockvector): Make "b" const.
11638
11639 2019-03-23  Tom Tromey  <tom@tromey.com>
11640
11641         * varobj.c (varobj_create): Update.
11642         * symfile.c (clear_symtab_users): Don't reset innermost_block.
11643         * printcmd.c (display_command, do_one_display): Don't reset
11644         innermost_block.
11645         * parser-defs.h (enum innermost_block_tracker_type): Move to
11646         expression.h.
11647         (innermost_block): Update comment.
11648         * parse.c (parse_exp_1): Add tracker_types parameter.
11649         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
11650         tracker_types parameter.  Reset innermost_block.
11651         (parse_exp_in_context): Remove.
11652         (parse_expression_for_completion): Update.
11653         * objfiles.c (~objfile): Don't reset expression_context_block or
11654         innermost_block.
11655         * expression.h (enum innermost_block_tracker_type): Move from
11656         parser-defs.h.
11657         (parse_exp_1): Add tracker_types parameter.
11658         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
11659         reset innermost_block.
11660
11661 2019-03-23  Tom Tromey  <tom@tromey.com>
11662
11663         * objfiles.h: Include bcache.h.
11664
11665 2019-03-23  Tom Tromey  <tom@tromey.com>
11666
11667         * linespec.c (get_current_search_block): Use
11668         scoped_restore_current_language.
11669         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
11670
11671 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
11672             Jiong Wang  <jiong.wang@arm.com>
11673
11674         * aarch64-linux-tdep.c
11675         (aarch64_linux_iterate_over_regset_sections): Check for pauth
11676         section.
11677         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
11678
11679 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
11680             Jiong Wang  <jiong.wang@arm.com>
11681
11682         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
11683         instructions.
11684         (aarch64_analyze_prologue_test): Add PACIASP test.
11685         (aarch64_prologue_prev_register): Unmask PC value.
11686
11687 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
11688             Jiong Wang  <jiong.wang@arm.com>
11689
11690         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
11691         (aarch64_dwarf2_prev_register): Unmask PC value.
11692         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
11693         (aarch64_execute_dwarf_cfa_vendor_op): Check for
11694         DW_CFA_AARCH64_negate_ra_state.
11695         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
11696
11697 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
11698             Jiong Wang  <jiong.wang@arm.com>
11699
11700         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
11701         registers.
11702         (aarch64_pseudo_register_name): Likewise.
11703         (aarch64_pseudo_register_type): Likewise.
11704         (aarch64_pseudo_register_reggroup_p): Likewise.
11705         (aarch64_gdbarch_init): Add pauth registers.
11706         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
11707         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
11708         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
11709         (struct gdbarch_tdep): Add regnum for ra_state.
11710
11711 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
11712             Jiong Wang  <jiong.wang@arm.com>
11713
11714         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
11715
11716 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
11717             Jiong Wang  <jiong.wang@arm.com>
11718
11719         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
11720         function.
11721         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
11722         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
11723         (aarch64_gdbarch_init): Add puth registers.
11724         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
11725         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
11726         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
11727
11728 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
11729             Jiong Wang  <jiong.wang@arm.com>
11730
11731         * aarch64-linux-nat.c
11732         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
11733         * aarch64-linux-tdep.c
11734         (aarch64_linux_core_read_description): Likewise.
11735         (aarch64_linux_get_hwcap): New function.
11736         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
11737         (aarch64_linux_get_hwcap): New declaration.
11738
11739 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
11740             Jiong Wang  <jiong.wang@arm.com>
11741
11742         * aarch64-linux-nat.c
11743         (aarch64_linux_nat_target::read_description): Add pauth param.
11744         * aarch64-linux-tdep.c
11745         (aarch64_linux_core_read_description): Likewise.
11746         * aarch64-tdep.c (struct target_desc): Add in pauth.
11747         (aarch64_read_description): Add pauth param.
11748         (aarch64_gdbarch_init): Likewise.
11749         * aarch64-tdep.h (aarch64_read_description): Likewise.
11750         * arch/aarch64.c (aarch64_create_target_description): Likewise.
11751         * arch/aarch64.h (aarch64_create_target_description): Likewise.
11752         * features/Makefile: Add new files.
11753         * features/aarch64-pauth.c: New file.
11754         * features/aarch64-pauth.xml: New file.
11755
11756 2019-03-20  Tom Tromey  <tromey@adacore.com>
11757
11758         * infrun.c (handle_inferior_event): Rename from
11759         handle_inferior_event_1.  Create a scoped_value_mark.
11760         (handle_inferior_event): Remove.
11761
11762 2019-03-19  Tom Tromey  <tromey@adacore.com>
11763
11764         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
11765         * infrun.h (print_stop_event): Add "displays" parameter.
11766         * infrun.c (print_stop_event): Add "displays" parameter.
11767
11768 2019-03-19  Pedro Alves  <palves@redhat.com>
11769
11770         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
11771         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
11772         to -1.  Fix TABs vs spaces.
11773         (tui_ui_out::tui_ui_out): Don't initialize fields here.
11774         * tui/tui-out.h (tui_ui_out) Add intro comments.
11775         <m_line, m_start_of_line>: In-class initialize, and add describing
11776         comment.
11777
11778 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
11779
11780         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
11781         variable names.
11782         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
11783
11784 2019-03-18  Pedro Alves  <palves@redhat.com>
11785             Eli Zaretskii <eliz@gnu.org>
11786
11787         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
11788         m_line and m_start_of_line.
11789
11790 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
11791
11792         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
11793         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
11794         it returns a newline.  This fixes a regression in TU mode, whereby
11795         the next line is output on the same screen line as the user input.
11796
11797 2019-03-18  Tom Tromey  <tromey@adacore.com>
11798
11799         * minsyms.c (minimal_symbol_reader::install): Remove call to
11800         obstack_blank.
11801
11802 2019-03-18  Pedro Alves  <palves@redhat.com>
11803
11804         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
11805         New globals.
11806         (apply_style): New, factored out from ...
11807         (apply_ansi_escape): ... this.  Handle reverse video mode.
11808         (tui_set_reverse_mode): New function.
11809         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
11810         * tui/tui-winsource.c (tui_show_source_line): Use
11811         tui_set_reverse_mode instead of setting A_STANDOUT.
11812         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
11813         New setter methods.
11814
11815 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
11816
11817         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
11818         Handle tabs.
11819
11820 2019-03-18  Tom Tromey  <tromey@adacore.com>
11821
11822         * ada-lang.c (empty_array): Add "high" parameter.
11823         (ada_evaluate_subexp): Update.
11824
11825 2019-03-17  Sergei Trofimovich <siarheit@google.com>
11826
11827         * unittests/string_view-selftests.c: Define
11828         _initialize_string_view_selftests unconditionally.
11829
11830 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
11831
11832         PR gdb/24350
11833         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
11834
11835 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
11836
11837         PR gdb/24351
11838         * windows-nat.c (display_selector): Fix format specifiers.
11839
11840 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
11841
11842         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
11843         tui_refill_source_window instead of tui_refresh_win, to update the
11844         current execution line.  This fixes redisplay of the current line
11845         when stepping through the code with "next" or "step".
11846
11847 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
11848
11849         * source-cache.c (source_cache::get_source_lines): Call
11850         find_source_lines to initialize s->nlines.  This fixes vertical
11851         scrolling of TUI source window when the DOWN arrow is pressed.
11852
11853 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11854
11855         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
11856         linux-thread-db.c (_initialize_thread_db): Likewise.
11857
11858 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
11859
11860         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
11861         wclrtoeol in tui_show_source_line".  This reverts changes made in
11862         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
11863
11864 2019-03-15  Tom Tromey  <tom@tromey.com>
11865
11866         * symtab.h (struct minimal_symbol): Derive from
11867         general_symbol_info.
11868         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
11869         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
11870         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
11871         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
11872         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
11873         (MSYMBOL_SEARCH_NAME): Update.
11874         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
11875         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
11876         * minsyms.c (minimal_symbol_reader::record_full): Update.
11877
11878 2019-03-15  Tom Tromey  <tom@tromey.com>
11879
11880         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
11881
11882 2019-03-15  Tom Tromey  <tom@tromey.com>
11883
11884         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
11885         unique_xmalloc_ptr.
11886         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
11887         Update.
11888         * minsyms.c (lookup_minimal_symbol_by_pc_section)
11889         (build_minimal_symbol_hash_tables)
11890         (minimal_symbol_reader::install): Update.
11891
11892 2019-03-15  Tom Tromey  <tom@tromey.com>
11893
11894         * symtab.c (create_demangled_names_hash): Update.
11895         (symbol_set_names): Update.
11896         * objfiles.h (struct objfile_per_bfd_storage)
11897         <demangled_names_hash>: Now an htab_up.
11898         * objfiles.c (objfile_per_bfd_storage): Simplify.
11899
11900 2019-03-15  Tom Tromey  <tom@tromey.com>
11901
11902         * objfiles.h (struct objfile_per_bfd_storage): Declare
11903         destructor.
11904         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
11905         New.
11906         (get_objfile_bfd_data): Use new.  Don't initialize
11907         language_of_main.
11908         (free_objfile_per_bfd_storage): Remove.
11909         (objfile_bfd_data_free, objfile::~objfile): Use delete.
11910
11911 2019-03-15  Tom Tromey  <tom@tromey.com>
11912
11913         * symfile.c (reread_symbols): Update.
11914         * objfiles.c (objfile::objfile): Update.
11915         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
11916         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
11917         comment.
11918         (minimal_symbol_reader::install): Update.
11919         (terminate_minimal_symbol_table): Remove.
11920         * jit.c (jit_object_close_impl): Update.
11921
11922 2019-03-15  Tom Tromey  <tom@tromey.com>
11923
11924         * minsyms.c (minimal_symbol_reader::record_full): Remove some
11925         initializations.
11926
11927 2019-03-15  Tom Tromey  <tom@tromey.com>
11928
11929         * objfiles.h (struct objfile_per_bfd_storage)
11930         <demangled_hash_languages>: Now a bitset.
11931         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
11932         (lookup_minimal_symbol): Update.
11933
11934 2019-03-15  Tom Tromey  <tom@tromey.com>
11935
11936         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
11937         Don't return the symbol.
11938         * coffread.c (record_minimal_symbol): Use record_full.
11939
11940 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
11941
11942         The MS-Windows port of ncurses fails to switch to a color pair if
11943         one or both of the colors are the implicit default colors.  This
11944         change records the default colors when TUI is initialized, and
11945         then specifies them explicitly when a color pair uses the default
11946         colors.  This allows color styling in TUI mode on MS-Windows.
11947
11948         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
11949         ncurses_norm_attr.
11950         (tui_initialize_io) [__MINGW32__]: Record the default terminal
11951         colors in ncurses_norm_attr.
11952         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
11953         "none", replace it with the default color recorded in
11954         ncurses_norm_attr.
11955
11956 2019-03-14  Tom Tromey  <tromey@adacore.com>
11957
11958         * source-cache.h (class source_cache) <get_source_lines>: Return
11959         std::string.
11960         * source-cache.c (source_cache::extract_lines): Handle case where
11961         first_pos==npos.  Return std::string.
11962         (source_cache::get_source_lines): Update.
11963
11964 2019-03-14  Tom Tromey  <tromey@adacore.com>
11965
11966         * NEWS: Add item for "style sources" commands.
11967         * source-cache.c (source_cache::get_source_lines): Check
11968         source_styling.
11969         * cli/cli-style.c (source_styling): New global.
11970         (_initialize_cli_style): Add "style sources" commands.
11971         (show_style_sources): New function.
11972         * cli/cli-style.h (source_styling): Declare.
11973
11974 2019-03-14  Pedro Alves  <palves@redhat.com>
11975             Tom Tromey  <tromey@adacore.com>
11976
11977         * tui/tui-winsource.h (tui_refill_source_window): Declare.
11978         * tui/tui-winsource.c (tui_refill_source_window): New function,
11979         from...
11980         (tui_horizontal_source_scroll): ... here.  Move some logic.
11981         * cli/cli-style.c (set_style_enabled): Notify new observable.
11982         * tui/tui-hooks.c (tui_redisplay_source): New function.
11983         (tui_attach_detach_observers): Attach or detach
11984         tui_redisplay_source.
11985         * observable.h (source_styling_changed): New observable.
11986         * observable.c: Define source_styling_changed observable.
11987
11988 2019-03-13  Tom Tromey  <tromey@adacore.com>
11989
11990         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
11991         (i386_gnu_nat_target::store_registers): Update.
11992         * target-debug.h (target_debug_print_std_string): New macro.
11993         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
11994         * windows-tdep.c (display_one_tib): Update.
11995         * tui/tui-stack.c (tui_make_status_line): Update.
11996         * top.c (print_inferior_quit_action): Update.
11997         * thread.c (thr_try_catch_cmd): Update.
11998         (add_thread_with_info): Update.
11999         (thread_target_id_str): Update.
12000         (thr_try_catch_cmd): Update.
12001         (thread_command): Update.
12002         (thread_find_command): Update.
12003         * record-btrace.c (record_btrace_target::info_record)
12004         (record_btrace_resume_thread, record_btrace_target::resume)
12005         (record_btrace_cancel_resume, record_btrace_step_thread)
12006         (record_btrace_target::wait, record_btrace_target::wait)
12007         (record_btrace_target::wait, record_btrace_target::stop): Update.
12008         * progspace.c (print_program_space): Update.
12009         * process-stratum-target.c
12010         (process_stratum_target::thread_address_space): Update.
12011         * linux-fork.c (linux_fork_mourn_inferior)
12012         (detach_checkpoint_command, info_checkpoints_command)
12013         (linux_fork_context): Update.
12014         (linux_fork_detach): Update.
12015         (class scoped_switch_fork_info): Update.
12016         (delete_checkpoint_command): Update.
12017         * infrun.c (follow_fork_inferior): Update.
12018         (follow_fork_inferior): Update.
12019         (proceed_after_vfork_done): Update.
12020         (handle_vfork_child_exec_or_exit): Update.
12021         (follow_exec): Update.
12022         (displaced_step_prepare_throw): Update.
12023         (displaced_step_restore): Update.
12024         (start_step_over): Update.
12025         (resume_1): Update.
12026         (clear_proceed_status_thread): Update.
12027         (proceed): Update.
12028         (print_target_wait_results): Update.
12029         (do_target_wait): Update.
12030         (context_switch): Update.
12031         (stop_all_threads): Update.
12032         (restart_threads): Update.
12033         (finish_step_over): Update.
12034         (handle_signal_stop): Update.
12035         (switch_back_to_stepped_thread): Update.
12036         (keep_going_pass_signal): Update.
12037         (print_exited_reason): Update.
12038         (normal_stop): Update.
12039         * inferior.c (inferior_pid_to_str): Change return type.
12040         (print_selected_inferior): Update.
12041         (add_inferior): Update.
12042         (detach_inferior): Update.
12043         * dummy-frame.c (fprint_dummy_frames): Update.
12044         * dcache.c (dcache_info_1): Update.
12045         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
12046         (btrace_fetch, btrace_clear): Update.
12047         * linux-tdep.c (linux_core_pid_to_str): Change return type.
12048         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
12049         type.
12050         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
12051         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
12052         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
12053         * gdbarch.c, gdbarch.h: Rebuild.
12054         * gdbarch.sh (core_pid_to_str): Change return type.
12055         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
12056         return type.
12057         (windows_nat_target::pid_to_str): Change return type.
12058         (windows_delete_thread): Update.
12059         (windows_nat_target::attach): Update.
12060         (windows_nat_target::files_info): Update.
12061         * target-delegates.c: Rebuild.
12062         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
12063         return type.
12064         (sol_thread_target::pid_to_str): Change return type.
12065         * remote.c (class remote_target) <pid_to_str>: Change return
12066         type.
12067         (remote_target::pid_to_str): Change return type.
12068         (extended_remote_target::attach, remote_target::remote_stop_ns)
12069         (remote_target::remote_notif_remove_queued_reply)
12070         (remote_target::push_stop_reply, remote_target::disable_btrace):
12071         Update.
12072         (extended_remote_target::attach): Update.
12073         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
12074         type.
12075         (gdbsim_target::pid_to_str): Change return type.
12076         * ravenscar-thread.c (struct ravenscar_thread_target)
12077         <pid_to_str>: Change return type.
12078         (ravenscar_thread_target::pid_to_str): Change return type.
12079         * procfs.c (class procfs_target) <pid_to_str>: Change return
12080         type.
12081         (procfs_target::pid_to_str): Change return type.
12082         (procfs_target::attach): Update.
12083         (procfs_target::detach): Update.
12084         (procfs_target::fetch_registers): Update.
12085         (procfs_target::store_registers): Update.
12086         (procfs_target::wait): Update.
12087         (procfs_target::files_info): Update.
12088         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
12089         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
12090         return type.
12091         (nto_procfs_target::pid_to_str): Change return type.
12092         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
12093         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
12094         return type.
12095         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
12096         (exit_lwp): Update.
12097         (attach_proc_task_lwp_callback, get_detach_signal)
12098         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
12099         (linux_nat_target::resume, wait_lwp, stop_callback)
12100         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
12101         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
12102         (linux_nat_wait_1, resume_stopped_resumed_lwps)
12103         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
12104         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
12105         type.
12106         (inf_ptrace_target::attach): Update.
12107         (inf_ptrace_target::files_info): Update.
12108         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
12109         type.
12110         (go32_nat_target::pid_to_str): Change return type.
12111         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
12112         (gnu_nat_target::wait): Update.
12113         (gnu_nat_target::wait): Update.
12114         (gnu_nat_target::resume): Update.
12115         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
12116         (fbsd_nat_target::wait): Update.
12117         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
12118         type.
12119         (darwin_nat_target::attach): Update.
12120         * corelow.c (class core_target) <pid_to_str>: Change return type.
12121         (core_target::pid_to_str): Change return type.
12122         * target.c (normal_pid_to_str): Change return type.
12123         (default_pid_to_str): Likewise.
12124         (target_pid_to_str): Change return type.
12125         (target_translate_tls_address): Update.
12126         (target_announce_detach): Update.
12127         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
12128         return type.
12129         (bsd_uthread_target::pid_to_str): Change return type.
12130         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
12131         type.
12132         (bsd_kvm_target::pid_to_str): Change return type.
12133         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
12134         return type.
12135         (aix_thread_target::pid_to_str): Change return type.
12136         * target.h (struct target_ops) <pid_to_str>: Change return type.
12137         (target_pid_to_str, normal_pid_to_str): Likewise.
12138         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
12139         type.
12140         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
12141         type.
12142         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
12143         return type.
12144         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
12145         type.
12146         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
12147         type.
12148         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
12149         return type.
12150
12151 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
12152
12153         * NEWS: Mention that the new default MI version is 3.  Mention
12154         changes to the output of commands and events that deal with
12155         multi-location breakpoints.
12156         * breakpoint.c: Include "mi/mi-out.h".
12157         (print_one_breakpoint): Change output syntax if using MI version
12158         >= 3.
12159         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
12160         New.
12161         (mi_multi_location_breakpoint_output_fixed): New.
12162         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
12163         (mi_cmd_fix_multi_location_breakpoint_output): New.
12164         (mi_multi_location_breakpoint_output_fixed): New.
12165         * mi/mi-cmds.c (mi_cmds): Register command
12166         -fix-multi-location-breakpoint-output.
12167         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
12168         interpreter "mi".
12169
12170 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
12171
12172         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
12173         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
12174         instantiate mi_ui_out based on interpreter name.
12175         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
12176         * mi/mi-main.c (mi_load_progress): Likewise.
12177
12178 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
12179
12180         * NEWS: Combine separate "New targets" sections for 8.3.
12181
12182 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
12183
12184         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
12185         (ppcfbsd_init_abi): Install gdbarch
12186         "fetch_tls_load_module_address" and "get_thread_local_address"
12187         methods.
12188
12189 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
12190
12191         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
12192         (riscv_fbsd_init_abi): Install gdbarch
12193         "fetch_tls_load_module_address" and "get_thread_local_address"
12194         methods.
12195
12196 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
12197
12198         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
12199         (i386fbsd_init_abi): Install gdbarch
12200         "fetch_tls_load_module_address" and "get_thread_local_address"
12201         methods.
12202
12203 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
12204
12205         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
12206         (amd64fbsd_init_abi): Install gdbarch
12207         "fetch_tls_load_module_address" and "get_thread_local_address"
12208         methods.
12209
12210 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
12211
12212         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
12213         (struct fbsd_pspace_data): New type.
12214         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
12215         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
12216         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
12217         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
12218         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
12219
12220 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
12221
12222         * gdbtypes.c (lookup_struct_elt): New function.
12223         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
12224         * gdbtypes.h (struct struct_elt): New type.
12225         (lookup_struct_elt): New prototype.
12226
12227 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
12228
12229         * gdbtypes.c (lookup_struct_elt_type): Update comment and
12230         remove disabled code block.
12231
12232 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
12233
12234         * gdbarch.sh (get_thread_local_address): New method.
12235         * gdbarch.h, gdbarch.c: Regenerate.
12236         * target.c (target_translate_tls_address): Use
12237         gdbarch_get_thread_local_address if present instead of
12238         target::get_thread_local_address.
12239
12240 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
12241
12242         * target.h (target::get_thread_local_address): Update comment.
12243
12244 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
12245
12246         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
12247         objfile->separate_debug_objfile_backlink if not NULL.
12248
12249 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
12250
12251         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
12252         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
12253         (amd64bsd_store_inferior_registers): Likewise.
12254         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
12255         Enable segment base registers.
12256         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
12257         PT_GETFSBASE and PT_GETGSBASE.
12258         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
12259         PT_SETGSBASE.
12260         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
12261         segment base registers.
12262         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
12263
12264 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
12265
12266         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
12267         Update calls to i386_target_description to add 'segments'
12268         parameter.
12269         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
12270         add segment base registers.
12271         * arch/i386.c (i386_create_target_description): Add 'segments'
12272         parameter to enable segment base registers.
12273         * arch/i386.h (i386_create_target_description): Likewise.
12274         * features/i386/32bit-segments.xml: New file.
12275         * features/i386/32bit-segments.c: Generate.
12276         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
12277         call to i386_target_description to add 'segments' parameter.
12278         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
12279         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
12280         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
12281         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
12282         if feature is present.
12283         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
12284         Add 'segments' parameter to call to i386_target_description.
12285         (i386_target_description): Add 'segments' parameter to enable
12286         segment base registers.
12287         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
12288         to call to i386_target_description.
12289         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
12290         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
12291         Define I386_NUM_REGS.
12292         (i386_target_description): Add 'segments' parameter to enable
12293         segment base registers.
12294
12295 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
12296
12297         PR/24325
12298         * source-cache.c: #undef open and close, to avoid unresolved
12299         externals during linking.
12300
12301 2019-03-12  Tom Tromey  <tromey@adacore.com>
12302
12303         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
12304         const.  Add initializers.
12305         (_initialize_remote): Don't initialize ptid globals.
12306
12307 2019-03-12  Pedro Alves  <palves@redhat.com>
12308
12309         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
12310
12311 2019-03-12  Pedro Alves  <palves@redhat.com>
12312
12313         * cp-name-parser.y (main): Remove unused 'len' variable.
12314
12315 2019-03-12  Tom Tromey  <tromey@adacore.com>
12316
12317         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
12318         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
12319
12320 2019-03-12  Tom Tromey  <tromey@adacore.com>
12321
12322         * linux-nat.c (iterate_over_lwps): Update.
12323         (stop_callback): Remove parameter.
12324         (stop_wait_callback, detach_callback, resume_set_callback)
12325         (select_singlestep_lwp_callback, set_ignore_sigint)
12326         (status_callback, resumed_callback, resume_clear_callback)
12327         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
12328         data parameter.
12329         (linux_nat_target::detach, linux_nat_target::resume)
12330         (linux_stop_and_wait_all_lwps, select_event_lwp)
12331         (linux_nat_filter_event, linux_nat_wait_1)
12332         (linux_nat_target::kill, linux_nat_target::stop)
12333         (linux_nat_target::stop): Update.
12334         (linux_nat_resume_callback): Change type.
12335         (resume_stopped_resumed_lwps, count_events_callback)
12336         (select_event_lwp_callback): Likewise.
12337         (linux_stop_lwp, linux_nat_stop_lwp): Update.
12338         * arm-linux-nat.c (struct update_registers_data): Remove.
12339         (update_registers_callback): Change type.
12340         (arm_linux_insert_hw_breakpoint1): Update.
12341         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
12342         parameter.
12343         (x86_linux_dr_set_addr): Update.
12344         (x86_linux_dr_set_control): Update.
12345         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
12346         (iterate_over_lwps): Use gdb::function_view.
12347         * nat/aarch64-linux-hw-point.c (struct
12348         aarch64_dr_update_callback_param): Remove.
12349         (debug_reg_change_callback): Change type.
12350         (aarch64_notify_debug_reg_change): Update.
12351         * s390-linux-nat.c (s390_refresh_per_info): Update.
12352
12353 2019-03-11  Tom Tromey  <tromey@adacore.com>
12354
12355         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
12356         redundant assignment to "this_cu".
12357
12358 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
12359
12360         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
12361
12362 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
12363
12364         * gdbtypes.c (rank_one_type_parm_set): New function extracted
12365         from...
12366         (rank_one_type): ... this.
12367
12368 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
12369
12370         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
12371         from...
12372         (rank_one_type): ... this.
12373
12374 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
12375
12376         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
12377         from...
12378         (rank_one_type): ... this.
12379
12380 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
12381
12382         * gdbtypes.c (rank_one_type_parm_float): New function extracted
12383         from...
12384         (rank_one_type): ... this.
12385
12386 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
12387
12388         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
12389         from...
12390         (rank_one_type): ... this.
12391
12392 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
12393
12394         * gdbtypes.c (rank_one_type_parm_range): New function extracted
12395         from...
12396         (rank_one_type): ... this.
12397
12398 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
12399
12400         * gdbtypes.c (rank_one_type_parm_char): New function extracted
12401         from...
12402         (rank_one_type): ... this.
12403
12404 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
12405
12406         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
12407         from...
12408         (rank_one_type): ... this.
12409
12410 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
12411
12412         * gdbtypes.c (rank_one_type_parm_int): New function extracted
12413         from...
12414         (rank_one_type): ... this.
12415
12416 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
12417
12418         * gdbtypes.c (rank_one_type_parm_func): New function extracted
12419         from...
12420         (rank_one_type): ... this.
12421
12422 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
12423
12424         * gdbtypes.c (rank_one_type_parm_array): New function extracted
12425         from...
12426         (rank_one_type): ... this.
12427
12428 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
12429
12430         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
12431         from...
12432         (rank_one_type): ... this.
12433
12434 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12435
12436         * inferior.c (initialize_inferiors): Ensure 'help set/show print
12437         inferior-events' shows the example events.
12438
12439 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
12440
12441         Support styling on native MS-Windows console
12442
12443         PR/24315
12444         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
12445         on MS-Windows if $TERM is not defined.
12446
12447         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
12448
12449         * posix-hdep.c (gdb_console_fputs):
12450         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
12451         functions.
12452         * ui-file.h (gdb_console_fputs): Add prototype.
12453
12454         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
12455         back to fputs only if the former returns zero.
12456
12457 2019-03-07  Tom Tromey  <tom@tromey.com>
12458
12459         * symmisc.c (print_symbol_bcache_statistics): Update.
12460         (print_objfile_statistics): Update.
12461         * symfile.c (allocate_symtab): Update.
12462         * stabsread.c: Don't include bcache.h.
12463         * psymtab.h (struct psymbol_bcache): Don't declare.
12464         (class psymtab_storage) <psymbol_cache>: Now a bcache.
12465         (psymbol_bcache_init, psymbol_bcache_free)
12466         (psymbol_bcache_get_bcache): Don't declare.
12467         * psymtab.c (struct psymbol_bcache): Remove.
12468         (psymtab_storage::psymtab_storage): Update.
12469         (psymtab_storage::~psymtab_storage): Update.
12470         (psymbol_bcache_init, psymbol_bcache_free)
12471         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
12472         (add_psymbol_to_bcache): Update.
12473         (allocate_psymtab): Update.
12474         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
12475         macro_cache>: No longer pointers.
12476         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
12477         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
12478         * macrotab.c (macro_bcache): Update.
12479         * macroexp.c: Don't include bcache.h.
12480         * gdbtypes.c (check_types_worklist): Update.
12481         (types_deeply_equal): Remove TRY/CATCH.  Update.
12482         * elfread.c (elf_symtab_read): Update.
12483         * dwarf2read.c: Don't include bcache.h.
12484         * buildsym.c (buildsym_compunit::get_macro_table): Update.
12485         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
12486         (print_bcache_statistics, bcache_memory_used): Don't declare.
12487         (struct bcache): Move from bcache.c.  Add constructor, destructor,
12488         methods.  Rename all data members.
12489         * bcache.c (struct bcache): Move to bcache.h.
12490         (bcache::expand_hash_table): Rename from expand_hash_table.
12491         (bcache): Remove.
12492         (bcache::insert): Rename from bcache_full.
12493         (bcache::compare): Rename from bcache_compare.
12494         (bcache_xmalloc): Remove.
12495         (bcache::~bcache): Rename from bcache_xfree.
12496         (bcache::print_statistics): Rename from print_bcache_statistics.
12497         (bcache::memory_used): Rename from bcache_memory_used.
12498
12499 2019-03-07  Pedro Alves  <palves@redhat.com>
12500
12501         * infrun.c (normal_stop): Also check for
12502         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
12503
12504 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
12505
12506         * f-lang.c (value_from_host_double): Moved to...
12507         * value.c (value_from_host_double): ...here.
12508         * value.h (value_from_host_double): Declare.
12509         * guile/scm-math.c (vlscm_convert_typed_number): Use
12510         value_from_host_double.
12511         (vlscm_convert_number): Likewise.
12512         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
12513         * python/py-value.c (convert_value_from_python): Likewise.
12514
12515 2019-03-06  Tom Tromey  <tom@tromey.com>
12516
12517         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
12518
12519 2019-03-06  Tom Tromey  <tom@tromey.com>
12520
12521         * utils.h (free_current_contents): Don't declare.
12522         * utils.c (free_current_contents): Remove.
12523
12524 2019-03-06  Tom Tromey  <tom@tromey.com>
12525
12526         * top.c (quit_force): Update.
12527         * main.c (captured_command_loop): Update.
12528         * common/new-op.c (operator new): Update.
12529         * common/common-exceptions.c (struct catcher)
12530         <save_cleanup_chain>: Remove member.
12531         (exceptions_state_mc_init): Update.
12532         (exception_try_scope_entry): Return nullptr.
12533         (exception_try_scope_exit, exception_rethrow)
12534         (throw_exception_sjlj, throw_exception_cxx): Update.
12535         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
12536         (all_cleanups, do_cleanups, discard_cleanups)
12537         (discard_final_cleanups, save_cleanups, save_final_cleanups)
12538         (restore_cleanups, restore_final_cleanups): Don't declare.
12539         (do_final_cleanups): Remove parameter.
12540         * common/cleanups.c (cleanup_chain, make_cleanup)
12541         (make_cleanup_dtor, all_cleanups, do_cleanups)
12542         (discard_my_cleanups, discard_cleanups)
12543         (discard_final_cleanups, save_my_cleanups, save_cleanups)
12544         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
12545         (null_cleanup): Remove.
12546         (do_final_cleanups): Remove parameter.
12547
12548 2019-03-06  Tom Tromey  <tom@tromey.com>
12549
12550         * remote.c (remote_target::remote_parse_stop_reply): Use
12551         unique_xmalloc_ptr.
12552
12553 2019-03-06  Tom Tromey  <tom@tromey.com>
12554
12555         * stabsread.c (struct stabs_field_info): Rename from field_info.
12556         <list, fnlist>: Add initializers.
12557         <obstack>: New member.
12558         (read_member_functions, read_struct_fields, read_baseclasses):
12559         Allocate on obstack.  Don't use cleanups.
12560         (read_one_struct_field, read_member_functions, read_struct_fields)
12561         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
12562         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
12563         (read_struct_type): Update.
12564
12565 2019-03-06  Tom Tromey  <tom@tromey.com>
12566
12567         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
12568         * common/filestuff.h (make_cleanup_close): Don't declare.
12569         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
12570         Remove.
12571
12572 2019-03-06  Tom Tromey  <tom@tromey.com>
12573
12574         * solib-aix.c: Use make_scope_exit.
12575
12576 2019-03-06  Tom Tromey  <tom@tromey.com>
12577
12578         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
12579         Use make_scope_exit.
12580
12581 2019-03-06  Tom Tromey  <tom@tromey.com>
12582
12583         * solib-svr4.c (disable_probes_interface): Remove parameter.
12584         (svr4_handle_solib_event): Use make_scope_exit.
12585
12586 2019-03-06  Tom Tromey  <tom@tromey.com>
12587
12588         * remote.c (struct stop_reply_deleter): Remove.
12589         (stop_reply_up): Update.
12590         (struct stop_reply): Derive from notif_event.  Don't typedef.
12591         <regcache>: Now a std::vector.
12592         (stop_reply_xfree): Remove.
12593         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
12594         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
12595         (remote_target::discard_pending_stop_replies): Use delete.
12596         (remote_target::remote_parse_stop_reply): Update.
12597         (remote_target::process_stop_reply): Update.
12598         * remote-notif.h (struct notif_event): Add virtual destructor.
12599         Remove "dtr" member.
12600         (struct notif_client) <alloc_event>: Return a unique_ptr.
12601         (notif_event_xfree): Don't declare.
12602         (notif_event_up): New typedef.
12603         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
12604         (notif_event_xfree, do_notif_event_xfree): Remove.
12605         (remote_notif_state_xfree): Update.
12606
12607 2019-03-06  Tom Tromey  <tom@tromey.com>
12608
12609         * infrun.c (displaced_step_clear_cleanup): Now a
12610         forward_scope_exit type.
12611         (displaced_step_prepare_throw): Update.
12612         (displaced_step_fixup): Update.
12613
12614 2019-03-06  Tom Tromey  <tom@tromey.com>
12615
12616         * inferior.h (class inferior): Update comment.
12617         * gdbthread.h (class thread_info): Update comment.
12618
12619 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
12620             Tom Tromey  <tom@tromey.com>
12621
12622         * stabsread.h (struct stab_section_list): Remove.
12623         (coffstab_build_psymtabs): Update.
12624         * dbxread.c (symbuf_sections): Now a std::vector.
12625         (sect_idx): New global.
12626         (fill_symbuf): Update.
12627         (coffstab_build_psymtabs): Change type of stabsects parameter.
12628         Update.
12629         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
12630         std::vector.
12631         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
12632         (coff_locate_sections): Update.
12633         (coff_symfile_read): Remove cleanups.  Update.
12634         (init_stringtab): Add storage parameter.
12635         (free_stringtab, free_stringtab_cleanup): Remove.
12636         (init_lineno): Add storage parameter.
12637         (free_linetab, free_linetab_cleanup): Remove.
12638
12639 2019-03-06  Pedro Alves  <palves@redhat.com>
12640
12641         * linux-fork.c (fork_info::clobber_regs): Delete.
12642         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
12643         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
12644         comment.  Adjust.
12645         (scoped_switch_fork_info::scoped_switch_fork_info)
12646         (checkpoint_command, linux_fork_context): Adjust
12647         fork_save_infrun_state calls.
12648
12649 2019-03-06  Pedro Alves  <palves@redhat.com>
12650
12651         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
12652         (inf_has_multiple_threads): Return 'bool' and rewrite using
12653         inferior_info::threads().
12654
12655 2019-03-06  Pedro Alves  <palves@redhat.com>
12656
12657         * linux-fork.c: Include <list>.
12658         (fork_list): Now a std::list instance.
12659         (fork_info): Add ctor, dtor, and in-class initialize all fields.
12660         (forks_exist_p, find_last_fork): Adjust.
12661         (new_fork): Delete.
12662         (one_fork_p): New.
12663         (add_fork): Adjust.
12664         (free_fork): Delete, folded into fork_info::~fork_info().
12665         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
12666         Adjust.
12667         (init_fork_list): Delete.
12668         (linux_fork_killall, linux_fork_mourn_inferior)
12669         (linux_fork_detach, info_checkpoints_command): Adjust.
12670         (_initialize_linux_fork): No longer call init_fork_list.
12671
12672 2019-03-06  Pedro Alves  <palves@redhat.com>
12673
12674         * linux-fork.c (new_fork): New, split out of ...
12675         (add_fork): ... this.  Return void.  Move "first fork" special
12676         case from here, to ...
12677         (checkpoint_command): ... here.
12678         * linux-linux.h (add_fork): Return void.
12679
12680 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
12681
12682         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
12683
12684 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
12685             Chris January  <chris.january@arm.com>
12686             David Lecomber  <david.lecomber@arm.com>
12687
12688         * f-exp.y: New token, UNOP_INTRINSIC.
12689         (exp): New pattern using UNOP_INTRINSIC token.
12690         (f77_keywords): Add 'abs' keyword.
12691         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
12692         (value_from_host_double): New function.
12693         (evaluate_subexp_f): Support UNOP_ABS.
12694
12695 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
12696
12697         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
12698         types.
12699
12700 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
12701
12702         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
12703         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
12704         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
12705
12706 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
12707
12708         * f-exp.y (convert_to_kind_type): Handle more type kinds.
12709
12710 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
12711             Chris January  <chris.january@arm.com>
12712
12713         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
12714         * f-exp.y: Define 'KIND' token.
12715         (exp): New pattern for KIND expressions.
12716         (ptype): Handle types with a kind extension.
12717         (direct_abs_decl): Extend to spot kind extensions.
12718         (f77_keywords): Add 'kind' to the list.
12719         (push_kind_type): New function.
12720         (convert_to_kind_type): New function.
12721         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
12722         * parse.c (operator_length_standard): Likewise.
12723         * parser-defs.h (enum type_pieces): Add tp_kind.
12724         * std-operator.def: Add UNOP_KIND.
12725
12726 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
12727
12728         * f-exp.y (f_parse): Set yydebug.
12729
12730 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
12731
12732         * f-lang.c (evaluate_subexp_f): New function.
12733         (exp_descriptor_f): New global.
12734         (f_language_defn): Use exp_descriptor_f instead of
12735         exp_descriptor_standard.
12736
12737 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
12738
12739         * f-exp.y (struct token): Add comments.
12740         (dot_ops): Remove uppercase versions and the end marker.
12741         (f77_keywords): Likewise.
12742         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
12743         entries in the dot_ops array are case insensitive, and use
12744         strncasecmp to compare strings.  Also some whitespace cleanup in
12745         this area.  Similar for the f77_keywords array, except entries in
12746         this list might be case sensitive.
12747
12748 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
12749
12750         * f-exp.y (struct f77_boolean_val): Add comments.
12751         (boolean_values): Remove uppercase versions, and end marker.
12752         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
12753         and use strncasecmp to achieve case insensitivity.  Additionally,
12754         perform whitespace cleanup around this code.
12755
12756 2019-03-06  Tom Tromey  <tromey@adacore.com>
12757
12758         * remote-sim.c (gdbsim_target_open): Use result of
12759         gdb_argv::release.
12760
12761 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
12762         Dirk Schubert  <dirk.schubert@arm.com>
12763         Chris January  <chris.january@arm.com>
12764
12765         * eval.c (evaluate_subexp_standard): Call Fortran argument
12766         wrapping logic.
12767         * f-lang.c (struct value): A value which can be passed into a
12768         Fortran function call.
12769         (fortran_argument_convert): Wrap Fortran arguments in a pointer
12770         where appropriate.
12771         (struct type): Value ready for a Fortran function call.
12772         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
12773         is needed.
12774         * f-lang.h (fortran_argument_convert): Declaration.
12775         (fortran_preserve_arg_pointer): Declaration.
12776         * infcall.c (value_arg_coerce): Call Fortran argument logic.
12777
12778 2019-03-05  Tom Tromey  <tromey@adacore.com>
12779
12780         * python/py-prettyprint.c (print_string_repr): Remove #if.
12781         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
12782
12783 2019-03-05  Tom Tromey  <tromey@adacore.com>
12784
12785         * target.c (the_dummy_target): Move later.  Change type to
12786         "dummy_target".
12787         (initialize_targets): Don't initialize the_dummy_target.
12788
12789 2019-03-05  Tom Tromey  <tromey@adacore.com>
12790
12791         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
12792         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
12793
12794 2019-03-05  Tom Tromey  <tromey@adacore.com>
12795
12796         * windows-nat.c (windows_nat_target::attach)
12797         (windows_nat_target::detach): Don't call gdb_flush.
12798         * valprint.c (generic_val_print, val_print, val_print_string):
12799         Don't call gdb_flush.
12800         * utils.c (defaulted_query): Don't call gdb_flush.
12801         * typeprint.c (print_type_scalar): Don't call gdb_flush.
12802         * target.c (target_announce_detach): Don't call gdb_flush.
12803         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
12804         * remote.c (extended_remote_target::attach): Don't call
12805         gdb_flush.
12806         * procfs.c (procfs_target::detach): Don't call gdb_flush.
12807         * printcmd.c (do_examine): Don't call gdb_flush.
12808         (info_display_command): Don't call gdb_flush.
12809         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
12810         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
12811         * memattr.c (info_mem_command): Don't call gdb_flush.
12812         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
12813         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
12814         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
12815         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
12816         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
12817         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
12818         (gnu_nat_target::detach): Don't call gdb_flush.
12819         * f-valprint.c (f_val_print): Don't call gdb_flush.
12820         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
12821         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
12822         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
12823         gdb_flush.
12824         * c-valprint.c (c_val_print): Don't call gdb_flush.
12825         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
12826
12827 2019-03-05  Tom Tromey  <tromey@adacore.com>
12828
12829         * varobj.c (update_dynamic_varobj_children): Update.
12830         (install_default_visualizer): Use reset, not release.
12831         * value.c (set_internalvar): Update.
12832         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
12833         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
12834         ATTRIBUTE_UNUSED_RESULT.
12835
12836 2019-03-05  Tom Tromey  <tromey@adacore.com>
12837
12838         * remote.c (class scoped_remote_fd) <release>: Add
12839         ATTRIBUTE_UNUSED_RESULT.
12840
12841 2019-03-05  Tom Tromey  <tromey@adacore.com>
12842
12843         * macroexp.c (struct macro_buffer) <release>: Add
12844         ATTRIBUTE_UNUSED_RESULT.
12845
12846 2019-03-05  Tom Tromey  <tromey@adacore.com>
12847
12848         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
12849         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
12850         ATTRIBUTE_UNUSED_RESULT.
12851
12852 2019-03-05  Tom Tromey  <tromey@adacore.com>
12853
12854         * common/scoped_fd.h (class scoped_fd) <release>: Add
12855         ATTRIBUTE_UNUSED_RESULT.
12856
12857 2019-03-05  Tom Tromey  <tromey@adacore.com>
12858
12859         * parser-defs.h (struct parser_state) <release>: Add
12860         ATTRIBUTE_UNUSED_RESULT.
12861
12862 2019-03-05  Tom Tromey  <tromey@adacore.com>
12863
12864         * utils.h (class gdb_argv) <release>: Add
12865         ATTRIBUTE_UNUSED_RESULT.
12866         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
12867
12868 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
12869
12870         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
12871         for-loop range, to avoid compiler warnings.
12872
12873         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
12874         avoid compiler warnings about unused variables.
12875
12876         * NEWS: Mention end of support for native debugging on MS-Windows
12877         before XP.
12878
12879         PR gdb/24292
12880         * common/netstuff.c:
12881         * gdbserver/gdbreplay.c
12882         * gdbserver/remote-utils.c:
12883         * ser-tcp.c:
12884         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
12885         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
12886         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
12887         'getaddrinfo' and 'freeaddrinfo' were not available before
12888         Windows XP, and mingw.org's MinGW headers by default define
12889         _WIN32_WINNT to 0x500.
12890
12891 2019-03-01  Gary Benson <gbenson@redhat.com>
12892
12893         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
12894
12895 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
12896             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
12897
12898         PR gdb/8527
12899         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
12900         set_sigint_trap, clear_sigint_trap.
12901
12902 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12903
12904         * target.c (target_detach): Clear the regcache and the
12905         frame cache.
12906
12907 2019-02-27  Pedro Alves  <palves@redhat.com>
12908
12909         * utils.c (set_screen_size): When we cap the height/width sizes,
12910         tweak the corresponding command variable to show "unlimited":
12911
12912 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
12913             Pedro Alves  <palves@redhat.com>
12914
12915         * utils.c (set_screen_size): Reduce "infinite" rows and columns
12916         before calling rl_set_screen_size.
12917
12918 2019-02-27  Tom Tromey  <tromey@adacore.com>
12919
12920         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
12921         define.
12922         * python/py-value.c: Remove Python 2.4 workaround.
12923         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
12924         workaround.
12925         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
12926         Python 2.4 workaround.
12927         * python/python-internal.h: Remove Python 2.4 comment.
12928         (Py_ssize_t): Don't define.
12929         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
12930         (gdb_Py_DECREF): Remove Python 2.4 workaround.
12931         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
12932         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
12933         * python/python.c (do_start_initialization): Remove Python 2.4
12934         workaround.
12935         * python/py-prettyprint.c (class dummy_python_frame): Remove.
12936         (print_children): Remove Python 2.4 workaround.
12937         * python/py-inferior.c (buffer_procs): Remove Python 2.4
12938         workaround.
12939         (CHARBUFFERPROC_NAME): Remove.
12940         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
12941         Python 2.4 workaround.
12942
12943 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
12944
12945         * NEWS: Note minimum Python version.
12946
12947 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
12948
12949         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
12950         code from these functions.  Remove corresponding ifdefs.  Use
12951         Py_buffer_up instead of explicit calls to PyBuffer_Release.
12952         Remove gotos and target of gotos.
12953         (infpy_search_memory): Likewise.
12954
12955 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12956
12957         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
12958         (hppa_gdbarch_init): Don't register deleted functions with
12959         gdbarch.
12960
12961 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12962
12963         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
12964         (h8300_unwind_sp): Delete.
12965         (h8300_dummy_id): Delete.
12966         (h8300_gdbarch_init): Don't register deleted functions with
12967         gdbarch.
12968
12969 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12970
12971         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
12972         (ft32_unwind_pc): Delete.
12973         (ft32_unwind_sp): Delete.
12974         (ft32_gdbarch_init): Don't register deleted functions with
12975         gdbarch.
12976
12977 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12978
12979         * gdb/frv-tdep.c (frv_dummy_id): Delete.
12980         (frv_unwind_pc): Delete.
12981         (frv_unwind_sp): Delete.
12982         (frv_gdbarch_init): Don't register deleted functions with
12983         gdbarch.
12984
12985 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12986
12987         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
12988         (riscv_unwind_pc): Delete.
12989         (riscv_unwind_sp): Delete.
12990         (riscv_gdbarch_init): Don't register deleted functions with
12991         gdbarch.
12992
12993 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12994
12995         * gdb/csky-tdep.c (csky_dummy_id): Delete.
12996         (csky_unwind_pc): Delete.
12997         (csky_unwind_sp): Delete.
12998         (csky_gdbarch_init): Don't register deleted functions with
12999         gdbarch.
13000
13001 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
13002
13003         * gdb/cris-tdep.c (cris_dummy_id): Delete.
13004         (cris_unwind_pc): Delete.
13005         (cris_unwind_sp): Delete.
13006         (cris_gdbarch_init): Don't register deleted functions with
13007         gdbarch.
13008
13009 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
13010
13011         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
13012         (bfin_unwind_pc): Delete.
13013         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
13014
13015 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
13016
13017         * gdb/arm-tdep.c (arm_dummy_id): Delete.
13018         (arm_unwind_pc): Delete.
13019         (arm_unwind_sp): Delete.
13020         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
13021
13022 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
13023
13024         * gdb/arc-tdep.c (arc_dummy_id): Delete.
13025         (arc_unwind_pc): Delete.
13026         (arc_unwind_sp): Delete.
13027         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
13028
13029 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
13030
13031         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
13032         (alpha_unwind_pc): Delete.
13033         (alpha_gdbarch_init): Don't register deleted functions with
13034         gdbarch.
13035
13036 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
13037
13038         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
13039         (aarch64_unwind_pc): Delete.
13040         (aarch64_unwind_sp): Delete.
13041         (aarch64_gdbarch_init): Don't register deleted functions with
13042         gdbarch.
13043
13044 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
13045
13046         * gdbtypes.c (type_align): Don't consider static members when
13047         computing structure alignment.
13048
13049 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
13050
13051         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
13052         return 0 for other types.
13053         * arch-utils.c (default_type_align): Always return 0.
13054         * gdbarch.h: Regenerate.
13055         * gdbarch.sh (type_align): Extend comment.
13056         * gdbtypes.c (type_align): Add additional comments, always call
13057         gdbarch_type_align before applying the default rules.
13058         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
13059         generic code will then apply a suitable default.
13060         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
13061         types, return 0 for other types.
13062
13063 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
13064
13065         * NEWS: Create a new section for the next release branch.
13066         Rename the section of the current branch, now that it has
13067         been cut.
13068
13069 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
13070
13071         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
13072         * version.in: Bump version to 8.3.50.DATE-git.
13073
13074 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
13075
13076         * aix-thread.c (ptid_cmp): Remove unused variable.
13077         (get_signaled_thread): Likewise.
13078         (store_regs_user_thread): Likewise.
13079         (store_regs_kernel_thread): Likewise.
13080         (fetch_regs_kernel_thread): Remove shadowed variable.
13081
13082 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
13083
13084         * features/riscv/32bit-cpu.xml: Add register numbers.
13085         * features/riscv/32bit-fpu.c: Regenerate.
13086         * features/riscv/32bit-fpu.xml: Add register numbers.
13087         * features/riscv/64bit-cpu.xml: Add register numbers.
13088         * features/riscv/64bit-fpu.c: Regenerate.
13089         * features/riscv/64bit-fpu.xml: Add register numbers.
13090
13091 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
13092
13093         * NEWS: Mention two argument form of gdb.Value constructor.
13094         * python/py-value.c (convert_buffer_and_type_to_value): New
13095         function.
13096         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
13097         Add support for handling an optional second argument.  Call
13098         convert_buffer_and_type_to_value as appropriate.
13099         * python/python-internal.h (Py_buffer_deleter): New struct.
13100         (Py_buffer_up): New typedef.
13101
13102 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
13103
13104         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
13105         instead of releasing ownership.
13106
13107 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
13108
13109         * dwarf2read.c (open_and_init_dwp_file): Call
13110         elf_numsections instead of bfd_count_sections to initialize
13111         dwp_file->num_sections.
13112
13113 2019-02-25  Tom Tromey  <tromey@adacore.com>
13114
13115         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
13116
13117 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
13118
13119         * gcore.in: Add '--readnever' option when invoking GDB.
13120
13121 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
13122
13123         * MAINTAINERS: Update my email address.
13124
13125 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
13126
13127         * build-id.c (build_id_to_debug_bfd_1): New function.
13128         (build_id_to_debug_bfd): Look for separate debug file in
13129         sysroot.
13130
13131 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
13132
13133         * gdbarch.sh: Update the copyright year range that is placed into
13134         generated files.
13135
13136 2019-02-22  Keith Seitz  <keiths@redhat.com>
13137
13138         PR symtab/23853
13139         * linespec.c (create_sals_line_offset): Search for the default
13140         symtab's filename instead of its fullname.
13141
13142 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
13143
13144         * NEWS: Update style defaults.
13145
13146 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
13147
13148         * main.c (captured_main_1): Disable styling in batch mode.
13149
13150 2019-02-20  Tom Tromey  <tom@tromey.com>
13151
13152         * symtab.c (symtab_symbol_info): Fix typos.
13153
13154 2019-02-20  Tom Tromey  <tromey@adacore.com>
13155
13156         * findcmd.c (_initialize_mem_search): Use upper case for
13157         metasyntactic variables.
13158
13159 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
13160
13161         * aarch64-tdep.c (aarch64_add_reggroups): New function.
13162         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
13163
13164 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
13165
13166         * top.h (source_file_name): Change to std::string.
13167         * top.c (source_file_name): Likewise.
13168         (command_line_input): Adjust.
13169         * cli/cli-script.c (script_from_file): Adjust.
13170
13171 2019-02-19  Tom Tromey  <tromey@adacore.com>
13172
13173         * ravenscar-thread.c
13174         (ravenscar_thread_target::update_thread_list): Don't call
13175         ada_build_task_list.
13176         * ada-lang.h (ada_build_task_list): Don't declare.
13177         * ada-tasks.c (struct ada_tasks_inferior_data)
13178         <task_list_valid_p>: Now bool.
13179         (read_known_tasks, ada_task_list_changed)
13180         (ada_tasks_invalidate_inferior_data): Update.
13181         (read_known_tasks_array): Return bool.
13182         (read_known_tasks_list): Likewise.
13183         (read_known_tasks): Return void.
13184         (ada_build_task_list): Now static.
13185
13186 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
13187
13188         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
13189         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
13190
13191 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13192
13193         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
13194         variant for ada_tasks_pspace_data_handle and
13195         ada_tasks_inferior_data_handle.
13196         (ada_tasks_pspace_data_cleanup): New function.
13197         (ada_tasks_inferior_data_cleanup): New function.
13198
13199 2019-02-17  Tom Tromey  <tom@tromey.com>
13200
13201         * macrotab.h (macro_source_fullname): Return a std::string.
13202         * macrotab.c (macro_include, check_for_redefinition)
13203         (macro_undef, macro_lookup_definition, foreach_macro)
13204         (foreach_macro_in_scope): Update.
13205         (macro_source_fullname): Return a std::string.
13206         * macrocmd.c (show_pp_source_pos): Update.
13207
13208 2019-02-17  Tom Tromey  <tom@tromey.com>
13209
13210         * macrocmd.c (show_pp_source_pos): Style the file names.
13211
13212 2019-02-17  Tom Tromey  <tom@tromey.com>
13213
13214         PR tui/24197:
13215         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
13216
13217 2019-02-17  Tom Tromey  <tom@tromey.com>
13218
13219         * ada-lang.c (user_select_syms): Use filtered printing.
13220         * utils.c (wrap_style): New global.
13221         (desired_style): Remove.
13222         (emit_style_escape): Add stream parameter.
13223         (set_output_style, reset_terminal_style, prompt_for_continue):
13224         Update.
13225         (flush_wrap_buffer): Only flush gdb_stdout.
13226         (wrap_here): Set wrap_style.
13227         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
13228         treat escape sequences as a character.  Change when wrap buffer is
13229         flushed.
13230         (fputs_styled): Do not set the output style when the default is
13231         requested.
13232         * ui-style.h (struct ui_file_style) <is_default>: New method.
13233         * source.c (print_source_lines_base): Emit escape sequences in one
13234         piece.
13235
13236 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
13237
13238         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
13239         integers and enumeration types.
13240
13241 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
13242
13243         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
13244         instead of lookup_symbol_in_language
13245         (do_exact_match): New function.
13246         (ada_get_symbol_name_matcher): Return do_exact_match when
13247         doing a verbatim match.
13248
13249 2019-02-15  Tom Tromey  <tromey@adacore.com>
13250
13251         * ravenscar-thread.c (ravenscar_thread_target::resume)
13252         (ravenscar_thread_target::wait): Special case wildcard requests.
13253
13254 2019-02-15  Tom Tromey  <tromey@adacore.com>
13255
13256         * ravenscar-thread.c (base_ptid): Remove.
13257         (struct ravenscar_thread_target) <close>: New method.
13258         <m_base_ptid>: New member.
13259         <update_inferior_ptid, active_task, task_is_currently_active,
13260         runtime_initialized>: Declare methods.
13261         <ravenscar_thread_target>: Add constructor.
13262         (ravenscar_thread_target::task_is_currently_active)
13263         (ravenscar_thread_target::update_inferior_ptid)
13264         (ravenscar_runtime_initialized): Rename.  Now methods.
13265         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
13266         (ravenscar_thread_target::update_thread_list): Update.
13267         (ravenscar_thread_target::active_task): Now method.
13268         (ravenscar_thread_target::store_registers)
13269         (ravenscar_thread_target::prepare_to_store)
13270         (ravenscar_thread_target::prepare_to_store)
13271         (ravenscar_thread_target::mourn_inferior): Update.
13272         (ravenscar_inferior_created): Use "new" to create target.
13273         (ravenscar_thread_target::get_ada_task_ptid): Update.
13274         (_initialize_ravenscar): Don't initialize base_ptid.
13275         (ravenscar_ops): Remove global.
13276
13277 2019-02-15  Tom Tromey  <tromey@adacore.com>
13278
13279         * target.h (push_target): Declare new overload.
13280         * target.c (push_target): New overload, taking an rvalue reference.
13281         * remote.c (remote_target::open_1): Use push_target overload.
13282         * corelow.c (core_target_open): Use push_target overload.
13283
13284 2019-02-15  Tom Tromey  <tromey@adacore.com>
13285
13286         * ravenscar-thread.c (is_ravenscar_task)
13287         (ravenscar_task_is_currently_active): Return bool.
13288         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
13289         (_initialize_ravenscar): Remove "(void)".
13290         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
13291         Return bool.
13292
13293 2019-02-15  Tom Tromey  <tromey@adacore.com>
13294
13295         * ravenscar-thread.c (ravenscar_runtime_initializer)
13296         (has_ravenscar_runtime, get_running_thread_id)
13297         (ravenscar_thread_target::resume): Fix indentation.
13298
13299 2019-02-15  Tom Tromey  <tromey@adacore.com>
13300
13301         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
13302         from ravenscar_arch_ops.
13303         (sparc_ravenscar_ops::fetch_registers)
13304         (sparc_ravenscar_ops::store_registers): Now methods.
13305         (sparc_ravenscar_prepare_to_store): Remove.
13306         (sparc_ravenscar_ops): Redefine.
13307         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
13308         methods and destructor.  Remove members.
13309         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
13310         (ravenscar_thread_target::store_registers)
13311         (ravenscar_thread_target::prepare_to_store): Update.
13312         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
13313         Remove.
13314         (struct ppc_ravenscar_powerpc_ops): Derive from
13315         ravenscar_arch_ops.
13316         (ppc_ravenscar_powerpc_ops::fetch_registers)
13317         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
13318         (ppc_ravenscar_powerpc_ops): Redefine.
13319         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
13320         (ppc_ravenscar_e500_ops::fetch_registers)
13321         (ppc_ravenscar_e500_ops::store_registers): Now methods.
13322         (ppc_ravenscar_e500_ops): Redefine.
13323         * aarch64-ravenscar-thread.c
13324         (aarch64_ravenscar_generic_prepare_to_store): Remove.
13325         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
13326         (aarch64_ravenscar_fetch_registers)
13327         (aarch64_ravenscar_store_registers): Now methods.
13328         (aarch64_ravenscar_ops): Redefine.
13329
13330 2019-02-15  Tom Tromey  <tromey@adacore.com>
13331
13332         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
13333         (ravenscar_thread_target::stopped_by_hw_breakpoint)
13334         (ravenscar_thread_target::stopped_by_watchpoint)
13335         (ravenscar_thread_target::stopped_data_address)
13336         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
13337
13338 2019-02-15  Tom Tromey  <tromey@adacore.com>
13339
13340         * ravenscar-thread.c: Fix some typos.
13341
13342 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13343             Tom Tromey  <tromey@adacore.com>
13344
13345         * ada-lang.c (ada_exception_sal): Change addr_string to a
13346         std::string.
13347         (create_ada_exception_catchpoint): Update.
13348
13349 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13350             Tom Tromey  <tromey@adacore.com>
13351
13352         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
13353         (bp_location_ops): Remove.
13354         (base_breakpoint_allocate_location): Update.
13355         (free_bp_location): Update.
13356         * ada-lang.c (class ada_catchpoint_location)
13357         <ada_catchpoint_location>: Remove ops parameter.
13358         (ada_catchpoint_location_dtor): Remove.
13359         (ada_catchpoint_location_ops): Remove.
13360         (allocate_location_exception): Update.
13361         * breakpoint.h (struct bp_location_ops): Remove.
13362         (class bp_location) <bp_location>: Remove bp_location_ops
13363         parameter.
13364         <~bp_location>: Add destructor.
13365         <ops>: Remove.
13366
13367 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
13368             Pedro Alves  <palves@redhat.com>
13369
13370         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
13371         'PATH_MAX'.
13372
13373 2019-02-14  David Michael  <fedora.dm0@gmail.com>
13374             Samuel Thibault  <samuel.thibault@gnu.org>
13375             Thomas Schwinge  <thomas@codesourcery.com>
13376
13377         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
13378         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
13379
13380 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
13381
13382         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
13383         (check_empty): Use "const char *".
13384
13385         * gnu-nat.c (gnu_nat_target::detach): Instead of
13386         'detach_inferior (pid)' call
13387         'detach_inferior (find_inferior_pid (pid))'.
13388
13389         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
13390         'nat/fork-inferior.o'.
13391         * gnu-nat.c: #include "nat/fork-inferior.h".
13392
13393         * gnu-nat.c (gnu_nat_target::detach): Instead of
13394         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
13395         * gnu-nat.h: #include "inf-child.h".
13396         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
13397         'i386_gnu_nat_target::fetch_registers'.
13398         (gnu_store_registers): Rename/move to
13399         'i386_gnu_nat_target::store_registers'.
13400
13401         * config/i386/nm-i386gnu.h: Don't "#include" any files.
13402         * gnu-nat.h (mach_thread_info): New function.
13403         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
13404
13405         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
13406
13407 2019-02-14  Frederic Konrad  <konrad@adacore.com>
13408
13409         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
13410
13411 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
13412
13413         * windows-nat.c (windows_add_thread): Add new parameter
13414         "main_thread_p" with default value set to false.  Update
13415         function documentation as well as all callers.
13416         (windows_delete_thread): Likewise.
13417         (fake_create_process): Update call to windows_add_thread.
13418         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
13419         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
13420         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
13421         call to windows_delete_thread.
13422
13423 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
13424
13425         * MAINTAINERS: Add Andrew Burgess as global maintainer.
13426
13427 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
13428
13429         * symfile.c (find_separate_debug_file): Use canonical path of
13430         sysroot with child_path instead of gdb_sysroot if it is valid.
13431
13432 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
13433
13434         * symfile.c (find_separate_debug_file): Use child_path to
13435         determine if an object file is under a sysroot.
13436
13437 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
13438
13439         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
13440         unittests/child-path-selftests.c.
13441         * common/pathstuff.c (child_path): New function.
13442         * common/pathstuff.h (child_path): New prototype.
13443         * unittests/child-path-selftests.c: New file.
13444
13445 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
13446
13447         * symfile.c (find_separate_debug_file): Look for separate debug
13448         files in debug directories under the sysroot.
13449
13450 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13451
13452         * symtab.h (struct minimal_symbol data_p): New const method.
13453         (struct minimal_symbol text_p): Likewise.
13454         * symtab.c (output_source_filename): Use file name style
13455         to print file name.
13456         (print_symbol_info): Likewise.
13457         (print_msymbol_info): Use address style to print addresses.
13458         Use function name style to print executable text symbols.
13459         (expand_symtab_containing_pc): Use data_p.
13460         (find_pc_sect_compunit_symtab): Likewise.
13461
13462 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13463
13464         * breakpoint.c (describe_other_breakpoints): Use address style
13465         to print addresses.
13466         (say_where): Likewise.
13467
13468 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13469
13470         * ada-typeprint.c (print_func_type): Print function name
13471         style to print function name.
13472         * c-typeprint.c (c_print_type_1): Likewise.
13473
13474 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
13475
13476         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
13477         for execve.
13478
13479 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13480
13481         * c-exp.y (direct_abs_decl): Use emplace_back to record the
13482         type_stack.
13483
13484 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
13485
13486         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
13487         TYPE_CODE_REF types.
13488
13489 2019-02-08  Jim Wilson  <jimw@sifive.com>
13490
13491         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
13492         (riscv_linux_fregset): New.
13493         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
13494
13495 2019-02-07  Tom Tromey  <tom@tromey.com>
13496
13497         * thread.c (thread_cancel_execution_command): Update.
13498         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
13499         methods.
13500         (struct thread_fsm_ops): Remove.
13501         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
13502         (thread_fsm_should_stop, thread_fsm_return_value)
13503         (thread_fsm_set_finished, thread_fsm_finished_p)
13504         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
13505         Don't declare.
13506         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
13507         * infrun.c (clear_proceed_status_thread)
13508         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
13509         (print_stop_event): Update.
13510         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
13511         Add constructor.
13512         (step_command_fsm_ops): Remove.
13513         (new_step_command_fsm): Remove.
13514         (step_1): Update.
13515         (step_command_fsm::should_stop): Rename from
13516         step_command_fsm_should_stop.
13517         (step_command_fsm::clean_up): Rename from
13518         step_command_fsm_clean_up.
13519         (step_command_fsm::do_async_reply_reason): Rename from
13520         step_command_fsm_async_reply_reason.
13521         (struct until_next_fsm): Inherit from thread_fsm.  Add
13522         constructor.
13523         (until_next_fsm_ops): Remove.
13524         (new_until_next_fsm): Remove.
13525         (until_next_fsm::should_stop): Rename from
13526         until_next_fsm_should_stop.
13527         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
13528         (until_next_fsm::do_async_reply_reason): Rename from
13529         until_next_fsm_async_reply_reason.
13530         (struct finish_command_fsm): Inherit from thread_fsm.  Add
13531         constructor.  Change type of breakpoint.
13532         (finish_command_fsm_ops): Remove.
13533         (new_finish_command_fsm): Remove.
13534         (finish_command_fsm::should_stop): Rename from
13535         finish_command_fsm_should_stop.
13536         (finish_command_fsm::clean_up): Rename from
13537         finish_command_fsm_clean_up.
13538         (finish_command_fsm::return_value): Rename from
13539         finish_command_fsm_return_value.
13540         (finish_command_fsm::do_async_reply_reason): Rename from
13541         finish_command_fsm_async_reply_reason.
13542         (finish_command): Update.
13543         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
13544         Add constructor.
13545         (call_thread_fsm_ops): Remove.
13546         (call_thread_fsm::call_thread_fsm): Rename from
13547         new_call_thread_fsm.
13548         (call_thread_fsm::should_stop): Rename from
13549         call_thread_fsm_should_stop.
13550         (call_thread_fsm::should_notify_stop): Rename from
13551         call_thread_fsm_should_notify_stop.
13552         (run_inferior_call, call_function_by_hand_dummy): Update.
13553         * cli/cli-interp.c (should_print_stop_to_console): Update.
13554         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
13555         Add constructor.  Change type of location_breakpoint,
13556         caller_breakpoint.
13557         (until_break_fsm_ops): Remove.
13558         (new_until_break_fsm): Remove.
13559         (until_break_fsm::should_stop): Rename from
13560         until_break_fsm_should_stop.
13561         (until_break_fsm::clean_up): Rename from
13562         until_break_fsm_clean_up.
13563         (until_break_fsm::do_async_reply_reason): Rename from
13564         until_break_fsm_async_reply_reason.
13565         (until_break_command): Update.
13566         * thread-fsm.c: Remove.
13567         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
13568
13569 2019-02-07  Tom Tromey  <tom@tromey.com>
13570
13571         * yy-remap.h: Add include guard.
13572         * xtensa-tdep.h: Add include guard.
13573         * xcoffread.h: Rename include guard.
13574         * varobj-iter.h: Add include guard.
13575         * tui/tui.h: Rename include guard.
13576         * tui/tui-winsource.h: Rename include guard.
13577         * tui/tui-wingeneral.h: Rename include guard.
13578         * tui/tui-windata.h: Rename include guard.
13579         * tui/tui-win.h: Rename include guard.
13580         * tui/tui-stack.h: Rename include guard.
13581         * tui/tui-source.h: Rename include guard.
13582         * tui/tui-regs.h: Rename include guard.
13583         * tui/tui-out.h: Rename include guard.
13584         * tui/tui-layout.h: Rename include guard.
13585         * tui/tui-io.h: Rename include guard.
13586         * tui/tui-hooks.h: Rename include guard.
13587         * tui/tui-file.h: Rename include guard.
13588         * tui/tui-disasm.h: Rename include guard.
13589         * tui/tui-data.h: Rename include guard.
13590         * tui/tui-command.h: Rename include guard.
13591         * tic6x-tdep.h: Add include guard.
13592         * target/waitstatus.h: Rename include guard.
13593         * target/wait.h: Rename include guard.
13594         * target/target.h: Rename include guard.
13595         * target/resume.h: Rename include guard.
13596         * target-float.h: Rename include guard.
13597         * stabsread.h: Add include guard.
13598         * rs6000-tdep.h: Add include guard.
13599         * riscv-fbsd-tdep.h: Add include guard.
13600         * regformats/regdef.h: Rename include guard.
13601         * record.h: Rename include guard.
13602         * python/python.h: Rename include guard.
13603         * python/python-internal.h: Rename include guard.
13604         * python/py-stopevent.h: Rename include guard.
13605         * python/py-ref.h: Rename include guard.
13606         * python/py-record.h: Rename include guard.
13607         * python/py-record-full.h: Rename include guard.
13608         * python/py-record-btrace.h: Rename include guard.
13609         * python/py-instruction.h: Rename include guard.
13610         * python/py-events.h: Rename include guard.
13611         * python/py-event.h: Rename include guard.
13612         * procfs.h: Add include guard.
13613         * proc-utils.h: Add include guard.
13614         * p-lang.h: Add include guard.
13615         * or1k-tdep.h: Rename include guard.
13616         * observable.h: Rename include guard.
13617         * nto-tdep.h: Rename include guard.
13618         * nat/x86-linux.h: Rename include guard.
13619         * nat/x86-linux-dregs.h: Rename include guard.
13620         * nat/x86-gcc-cpuid.h: Add include guard.
13621         * nat/x86-dregs.h: Rename include guard.
13622         * nat/x86-cpuid.h: Rename include guard.
13623         * nat/ppc-linux.h: Rename include guard.
13624         * nat/mips-linux-watch.h: Rename include guard.
13625         * nat/linux-waitpid.h: Rename include guard.
13626         * nat/linux-ptrace.h: Rename include guard.
13627         * nat/linux-procfs.h: Rename include guard.
13628         * nat/linux-osdata.h: Rename include guard.
13629         * nat/linux-nat.h: Rename include guard.
13630         * nat/linux-namespaces.h: Rename include guard.
13631         * nat/linux-btrace.h: Rename include guard.
13632         * nat/glibc_thread_db.h: Rename include guard.
13633         * nat/gdb_thread_db.h: Rename include guard.
13634         * nat/gdb_ptrace.h: Rename include guard.
13635         * nat/fork-inferior.h: Rename include guard.
13636         * nat/amd64-linux-siginfo.h: Rename include guard.
13637         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
13638         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
13639         * nat/aarch64-linux.h: Rename include guard.
13640         * nat/aarch64-linux-hw-point.h: Rename include guard.
13641         * mn10300-tdep.h: Add include guard.
13642         * mips-linux-tdep.h: Add include guard.
13643         * mi/mi-parse.h: Rename include guard.
13644         * mi/mi-out.h: Rename include guard.
13645         * mi/mi-main.h: Rename include guard.
13646         * mi/mi-interp.h: Rename include guard.
13647         * mi/mi-getopt.h: Rename include guard.
13648         * mi/mi-console.h: Rename include guard.
13649         * mi/mi-common.h: Rename include guard.
13650         * mi/mi-cmds.h: Rename include guard.
13651         * mi/mi-cmd-break.h: Rename include guard.
13652         * m2-lang.h: Add include guard.
13653         * location.h: Rename include guard.
13654         * linux-record.h: Rename include guard.
13655         * linux-nat.h: Add include guard.
13656         * linux-fork.h: Add include guard.
13657         * i386-darwin-tdep.h: Rename include guard.
13658         * hppa-linux-offsets.h: Add include guard.
13659         * guile/guile.h: Rename include guard.
13660         * guile/guile-internal.h: Rename include guard.
13661         * gnu-nat.h: Rename include guard.
13662         * gdb-stabs.h: Rename include guard.
13663         * frv-tdep.h: Add include guard.
13664         * f-lang.h: Add include guard.
13665         * event-loop.h: Add include guard.
13666         * darwin-nat.h: Rename include guard.
13667         * cp-abi.h: Rename include guard.
13668         * config/sparc/nm-sol2.h: Rename include guard.
13669         * config/nm-nto.h: Rename include guard.
13670         * config/nm-linux.h: Add include guard.
13671         * config/i386/nm-i386gnu.h: Rename include guard.
13672         * config/djgpp/nl_types.h: Rename include guard.
13673         * config/djgpp/langinfo.h: Rename include guard.
13674         * compile/gcc-cp-plugin.h: Add include guard.
13675         * compile/gcc-c-plugin.h: Add include guard.
13676         * compile/compile.h: Rename include guard.
13677         * compile/compile-object-run.h: Rename include guard.
13678         * compile/compile-object-load.h: Rename include guard.
13679         * compile/compile-internal.h: Rename include guard.
13680         * compile/compile-cplus.h: Rename include guard.
13681         * compile/compile-c.h: Rename include guard.
13682         * common/xml-utils.h: Rename include guard.
13683         * common/x86-xstate.h: Rename include guard.
13684         * common/version.h: Rename include guard.
13685         * common/vec.h: Rename include guard.
13686         * common/tdesc.h: Rename include guard.
13687         * common/selftest.h: Rename include guard.
13688         * common/scoped_restore.h: Rename include guard.
13689         * common/scoped_mmap.h: Rename include guard.
13690         * common/scoped_fd.h: Rename include guard.
13691         * common/safe-iterator.h: Rename include guard.
13692         * common/run-time-clock.h: Rename include guard.
13693         * common/refcounted-object.h: Rename include guard.
13694         * common/queue.h: Rename include guard.
13695         * common/ptid.h: Rename include guard.
13696         * common/print-utils.h: Rename include guard.
13697         * common/preprocessor.h: Rename include guard.
13698         * common/pathstuff.h: Rename include guard.
13699         * common/observable.h: Rename include guard.
13700         * common/netstuff.h: Rename include guard.
13701         * common/job-control.h: Rename include guard.
13702         * common/host-defs.h: Rename include guard.
13703         * common/gdb_wait.h: Rename include guard.
13704         * common/gdb_vecs.h: Rename include guard.
13705         * common/gdb_unlinker.h: Rename include guard.
13706         * common/gdb_unique_ptr.h: Rename include guard.
13707         * common/gdb_tilde_expand.h: Rename include guard.
13708         * common/gdb_sys_time.h: Rename include guard.
13709         * common/gdb_string_view.h: Rename include guard.
13710         * common/gdb_splay_tree.h: Rename include guard.
13711         * common/gdb_setjmp.h: Rename include guard.
13712         * common/gdb_ref_ptr.h: Rename include guard.
13713         * common/gdb_optional.h: Rename include guard.
13714         * common/gdb_locale.h: Rename include guard.
13715         * common/gdb_assert.h: Rename include guard.
13716         * common/filtered-iterator.h: Rename include guard.
13717         * common/filestuff.h: Rename include guard.
13718         * common/fileio.h: Rename include guard.
13719         * common/environ.h: Rename include guard.
13720         * common/common-utils.h: Rename include guard.
13721         * common/common-types.h: Rename include guard.
13722         * common/common-regcache.h: Rename include guard.
13723         * common/common-inferior.h: Rename include guard.
13724         * common/common-gdbthread.h: Rename include guard.
13725         * common/common-exceptions.h: Rename include guard.
13726         * common/common-defs.h: Rename include guard.
13727         * common/common-debug.h: Rename include guard.
13728         * common/cleanups.h: Rename include guard.
13729         * common/buffer.h: Rename include guard.
13730         * common/btrace-common.h: Rename include guard.
13731         * common/break-common.h: Rename include guard.
13732         * cli/cli-utils.h: Rename include guard.
13733         * cli/cli-style.h: Rename include guard.
13734         * cli/cli-setshow.h: Rename include guard.
13735         * cli/cli-script.h: Rename include guard.
13736         * cli/cli-interp.h: Rename include guard.
13737         * cli/cli-decode.h: Rename include guard.
13738         * cli/cli-cmds.h: Rename include guard.
13739         * charset-list.h: Add include guard.
13740         * buildsym-legacy.h: Rename include guard.
13741         * bfin-tdep.h: Add include guard.
13742         * ax.h: Rename include guard.
13743         * arm-linux-tdep.h: Add include guard.
13744         * arm-fbsd-tdep.h: Add include guard.
13745         * arch/xtensa.h: Rename include guard.
13746         * arch/tic6x.h: Add include guard.
13747         * arch/i386.h: Add include guard.
13748         * arch/arm.h: Rename include guard.
13749         * arch/arm-linux.h: Rename include guard.
13750         * arch/arm-get-next-pcs.h: Rename include guard.
13751         * arch/amd64.h: Add include guard.
13752         * arch/aarch64-insn.h: Rename include guard.
13753         * arch-utils.h: Rename include guard.
13754         * annotate.h: Add include guard.
13755         * amd64-darwin-tdep.h: Rename include guard.
13756         * aarch64-linux-tdep.h: Add include guard.
13757         * aarch64-fbsd-tdep.h: Add include guard.
13758         * aarch32-linux-nat.h: Add include guard.
13759
13760 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13761
13762         * macrotab.c (macro_define_internal): New function that
13763         factorizes macro_define_object_internal and macro_define_function
13764         code.
13765         (macro_define_object_internal): Use macro_define_internal.
13766         (macro_define_function): Likewise.
13767
13768 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13769
13770         * macrocmd.c (extract_identifier): Return
13771         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
13772         callers.
13773
13774 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
13775
13776         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
13777
13778 2019-02-05  Tom Tromey  <tom@tromey.com>
13779
13780         * target.c (target_stack::unpush): Move assertion earlier.
13781
13782 2019-01-30  Tom Tromey  <tom@tromey.com>
13783
13784         PR python/23615:
13785         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
13786         (gdbpy_parse_and_eval): Likewise.
13787         * python/python-internal.h (gdbpy_allow_threads): New class.
13788
13789 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
13790
13791         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
13792         (aarch64_fbsd_fpregmap): Move earlier.
13793         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
13794         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
13795         instead of individual calls to trad_frame_set_reg_addr.
13796         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
13797         earlier.
13798         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
13799         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
13800         instead of individual calls to trad_frame_set_reg_addr.
13801
13802 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
13803
13804         * CONTRIBUTE: Replace contribution list with wiki link.
13805
13806 2019-01-25  Tom Tromey  <tom@tromey.com>
13807
13808         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
13809
13810 2019-01-25  Tom Tromey  <tom@tromey.com>
13811
13812         * xtensa-linux-nat.c: Fix common/ includes.
13813         * xml-support.h: Fix common/ includes.
13814         * xml-support.c: Fix common/ includes.
13815         * x86-linux-nat.c: Fix common/ includes.
13816         * windows-nat.c: Fix common/ includes.
13817         * varobj.h: Fix common/ includes.
13818         * varobj.c: Fix common/ includes.
13819         * value.c: Fix common/ includes.
13820         * valops.c: Fix common/ includes.
13821         * utils.c: Fix common/ includes.
13822         * unittests/xml-utils-selftests.c: Fix common/ includes.
13823         * unittests/utils-selftests.c: Fix common/ includes.
13824         * unittests/unpack-selftests.c: Fix common/ includes.
13825         * unittests/tracepoint-selftests.c: Fix common/ includes.
13826         * unittests/style-selftests.c: Fix common/ includes.
13827         * unittests/string_view-selftests.c: Fix common/ includes.
13828         * unittests/scoped_restore-selftests.c: Fix common/ includes.
13829         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
13830         * unittests/scoped_fd-selftests.c: Fix common/ includes.
13831         * unittests/rsp-low-selftests.c: Fix common/ includes.
13832         * unittests/parse-connection-spec-selftests.c: Fix common/
13833         includes.
13834         * unittests/optional-selftests.c: Fix common/ includes.
13835         * unittests/offset-type-selftests.c: Fix common/ includes.
13836         * unittests/observable-selftests.c: Fix common/ includes.
13837         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
13838         * unittests/memrange-selftests.c: Fix common/ includes.
13839         * unittests/memory-map-selftests.c: Fix common/ includes.
13840         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
13841         * unittests/function-view-selftests.c: Fix common/ includes.
13842         * unittests/environ-selftests.c: Fix common/ includes.
13843         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
13844         * unittests/common-utils-selftests.c: Fix common/ includes.
13845         * unittests/cli-utils-selftests.c: Fix common/ includes.
13846         * unittests/array-view-selftests.c: Fix common/ includes.
13847         * ui-file.c: Fix common/ includes.
13848         * tui/tui-io.c: Fix common/ includes.
13849         * tracepoint.h: Fix common/ includes.
13850         * tracepoint.c: Fix common/ includes.
13851         * tracefile-tfile.c: Fix common/ includes.
13852         * top.h: Fix common/ includes.
13853         * top.c: Fix common/ includes.
13854         * thread.c: Fix common/ includes.
13855         * target/waitstatus.h: Fix common/ includes.
13856         * target/waitstatus.c: Fix common/ includes.
13857         * target.h: Fix common/ includes.
13858         * target.c: Fix common/ includes.
13859         * target-memory.c: Fix common/ includes.
13860         * target-descriptions.c: Fix common/ includes.
13861         * symtab.h: Fix common/ includes.
13862         * symfile.c: Fix common/ includes.
13863         * stap-probe.c: Fix common/ includes.
13864         * spu-linux-nat.c: Fix common/ includes.
13865         * sparc-nat.c: Fix common/ includes.
13866         * source.c: Fix common/ includes.
13867         * solib.c: Fix common/ includes.
13868         * solib-target.c: Fix common/ includes.
13869         * ser-unix.c: Fix common/ includes.
13870         * ser-tcp.c: Fix common/ includes.
13871         * ser-pipe.c: Fix common/ includes.
13872         * ser-base.c: Fix common/ includes.
13873         * selftest-arch.c: Fix common/ includes.
13874         * s12z-tdep.c: Fix common/ includes.
13875         * rust-exp.y: Fix common/ includes.
13876         * rs6000-aix-tdep.c: Fix common/ includes.
13877         * riscv-tdep.c: Fix common/ includes.
13878         * remote.c: Fix common/ includes.
13879         * remote-notif.h: Fix common/ includes.
13880         * remote-fileio.h: Fix common/ includes.
13881         * remote-fileio.c: Fix common/ includes.
13882         * regcache.h: Fix common/ includes.
13883         * regcache.c: Fix common/ includes.
13884         * record-btrace.c: Fix common/ includes.
13885         * python/python.c: Fix common/ includes.
13886         * python/py-type.c: Fix common/ includes.
13887         * python/py-inferior.c: Fix common/ includes.
13888         * progspace.h: Fix common/ includes.
13889         * producer.c: Fix common/ includes.
13890         * procfs.c: Fix common/ includes.
13891         * proc-api.c: Fix common/ includes.
13892         * printcmd.c: Fix common/ includes.
13893         * ppc-linux-nat.c: Fix common/ includes.
13894         * parser-defs.h: Fix common/ includes.
13895         * osdata.c: Fix common/ includes.
13896         * obsd-nat.c: Fix common/ includes.
13897         * nat/x86-linux.c: Fix common/ includes.
13898         * nat/x86-linux-dregs.c: Fix common/ includes.
13899         * nat/x86-dregs.h: Fix common/ includes.
13900         * nat/x86-dregs.c: Fix common/ includes.
13901         * nat/ppc-linux.c: Fix common/ includes.
13902         * nat/mips-linux-watch.h: Fix common/ includes.
13903         * nat/mips-linux-watch.c: Fix common/ includes.
13904         * nat/linux-waitpid.c: Fix common/ includes.
13905         * nat/linux-ptrace.h: Fix common/ includes.
13906         * nat/linux-ptrace.c: Fix common/ includes.
13907         * nat/linux-procfs.c: Fix common/ includes.
13908         * nat/linux-personality.c: Fix common/ includes.
13909         * nat/linux-osdata.c: Fix common/ includes.
13910         * nat/linux-namespaces.c: Fix common/ includes.
13911         * nat/linux-btrace.h: Fix common/ includes.
13912         * nat/linux-btrace.c: Fix common/ includes.
13913         * nat/fork-inferior.c: Fix common/ includes.
13914         * nat/amd64-linux-siginfo.c: Fix common/ includes.
13915         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
13916         * nat/aarch64-linux.c: Fix common/ includes.
13917         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
13918         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
13919         * namespace.h: Fix common/ includes.
13920         * mips-linux-tdep.c: Fix common/ includes.
13921         * minsyms.c: Fix common/ includes.
13922         * mi/mi-parse.h: Fix common/ includes.
13923         * mi/mi-main.c: Fix common/ includes.
13924         * mi/mi-cmd-env.c: Fix common/ includes.
13925         * memrange.h: Fix common/ includes.
13926         * memattr.c: Fix common/ includes.
13927         * maint.h: Fix common/ includes.
13928         * maint.c: Fix common/ includes.
13929         * main.c: Fix common/ includes.
13930         * machoread.c: Fix common/ includes.
13931         * location.c: Fix common/ includes.
13932         * linux-thread-db.c: Fix common/ includes.
13933         * linux-nat.c: Fix common/ includes.
13934         * linux-fork.c: Fix common/ includes.
13935         * inline-frame.c: Fix common/ includes.
13936         * infrun.c: Fix common/ includes.
13937         * inflow.c: Fix common/ includes.
13938         * inferior.h: Fix common/ includes.
13939         * inferior.c: Fix common/ includes.
13940         * infcmd.c: Fix common/ includes.
13941         * inf-ptrace.c: Fix common/ includes.
13942         * inf-child.c: Fix common/ includes.
13943         * ia64-linux-nat.c: Fix common/ includes.
13944         * i387-tdep.c: Fix common/ includes.
13945         * i386-tdep.c: Fix common/ includes.
13946         * i386-linux-tdep.c: Fix common/ includes.
13947         * i386-linux-nat.c: Fix common/ includes.
13948         * i386-go32-tdep.c: Fix common/ includes.
13949         * i386-fbsd-tdep.c: Fix common/ includes.
13950         * i386-fbsd-nat.c: Fix common/ includes.
13951         * guile/scm-type.c: Fix common/ includes.
13952         * guile/guile.c: Fix common/ includes.
13953         * go32-nat.c: Fix common/ includes.
13954         * gnu-nat.c: Fix common/ includes.
13955         * gdbthread.h: Fix common/ includes.
13956         * gdbarch-selftests.c: Fix common/ includes.
13957         * gdb_usleep.c: Fix common/ includes.
13958         * gdb_select.h: Fix common/ includes.
13959         * gdb_bfd.c: Fix common/ includes.
13960         * gcore.c: Fix common/ includes.
13961         * fork-child.c: Fix common/ includes.
13962         * findvar.c: Fix common/ includes.
13963         * fbsd-nat.c: Fix common/ includes.
13964         * event-top.c: Fix common/ includes.
13965         * event-loop.c: Fix common/ includes.
13966         * dwarf2read.c: Fix common/ includes.
13967         * dwarf2loc.c: Fix common/ includes.
13968         * dwarf2-frame.c: Fix common/ includes.
13969         * dwarf-index-cache.c: Fix common/ includes.
13970         * dtrace-probe.c: Fix common/ includes.
13971         * disasm-selftests.c: Fix common/ includes.
13972         * defs.h: Fix common/ includes.
13973         * csky-tdep.c: Fix common/ includes.
13974         * cp-valprint.c: Fix common/ includes.
13975         * cp-support.h: Fix common/ includes.
13976         * cp-support.c: Fix common/ includes.
13977         * corelow.c: Fix common/ includes.
13978         * completer.h: Fix common/ includes.
13979         * completer.c: Fix common/ includes.
13980         * compile/compile.c: Fix common/ includes.
13981         * compile/compile-loc2c.c: Fix common/ includes.
13982         * compile/compile-cplus-types.c: Fix common/ includes.
13983         * compile/compile-cplus-symbols.c: Fix common/ includes.
13984         * command.h: Fix common/ includes.
13985         * cli/cli-dump.c: Fix common/ includes.
13986         * cli/cli-cmds.c: Fix common/ includes.
13987         * charset.c: Fix common/ includes.
13988         * build-id.c: Fix common/ includes.
13989         * btrace.h: Fix common/ includes.
13990         * btrace.c: Fix common/ includes.
13991         * breakpoint.h: Fix common/ includes.
13992         * breakpoint.c: Fix common/ includes.
13993         * ax.h:
13994         (enum agent_op): Fix common/ includes.
13995         * ax-general.c (struct aop_map): Fix common/ includes.
13996         * ax-gdb.c: Fix common/ includes.
13997         * auxv.c: Fix common/ includes.
13998         * auto-load.c: Fix common/ includes.
13999         * arm-tdep.c: Fix common/ includes.
14000         * arch/riscv.c: Fix common/ includes.
14001         * arch/ppc-linux-common.c: Fix common/ includes.
14002         * arch/i386.c: Fix common/ includes.
14003         * arch/arm.c: Fix common/ includes.
14004         * arch/arm-linux.c: Fix common/ includes.
14005         * arch/arm-get-next-pcs.c: Fix common/ includes.
14006         * arch/amd64.c: Fix common/ includes.
14007         * arch/aarch64.c: Fix common/ includes.
14008         * arch/aarch64-insn.c: Fix common/ includes.
14009         * arch-utils.c: Fix common/ includes.
14010         * amd64-windows-tdep.c: Fix common/ includes.
14011         * amd64-tdep.c: Fix common/ includes.
14012         * amd64-sol2-tdep.c: Fix common/ includes.
14013         * amd64-obsd-tdep.c: Fix common/ includes.
14014         * amd64-nbsd-tdep.c: Fix common/ includes.
14015         * amd64-linux-tdep.c: Fix common/ includes.
14016         * amd64-linux-nat.c: Fix common/ includes.
14017         * amd64-fbsd-tdep.c: Fix common/ includes.
14018         * amd64-fbsd-nat.c: Fix common/ includes.
14019         * amd64-dicos-tdep.c: Fix common/ includes.
14020         * amd64-darwin-tdep.c: Fix common/ includes.
14021         * agent.c: Fix common/ includes.
14022         * ada-lang.h: Fix common/ includes.
14023         * ada-lang.c: Fix common/ includes.
14024         * aarch64-tdep.c: Fix common/ includes.
14025
14026 2019-01-25  Tom Tromey  <tom@tromey.com>
14027
14028         * common/create-version.sh: Use common/version.h.
14029
14030 2019-01-24  Pedro Alves  <palves@redhat.com>
14031
14032         * infrun.c (signal_stop, signal_print, signal_program)
14033         (signal_catch, signal_pass): Now arrays instead of pointers.
14034         (update_signals_program_target, do_target_resume)
14035         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
14036         * linux-nat.c (linux_nat_target::pass_signals)
14037         (linux_nat_target::create_inferior, linux_nat_target::attach):
14038         Adjust.
14039         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
14040         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
14041         * procfs.c (procfs_target::pass_signals): Adjust.
14042         * record-full.c (record_full_target::resume): Adjust.
14043         * remote.c (remote_target::pass_signals)
14044         (remote_target::program_signals): Adjust.
14045         * target-debug.h (target_debug_print_signals): Now takes a
14046         gdb::array_view as parameter.  Adjust.
14047         * target.h (target_ops) <pass_signals, program_signals>: Replace
14048         pointer and length parameters with gdb::array_view.
14049         (target_pass_signals, target_program_signals): Likewise.
14050         * target-delegates.c: Regenerate.
14051
14052 2019-01-24  Pedro Alves  <palves@redhat.com>
14053
14054         * common/forward-scope-exit.h
14055         (forward_scope_exit::forward_scope_exit): Pass arguments to
14056         m_bind_function directly, instead of creating a std::bind and
14057         copying that.
14058
14059 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
14060
14061         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
14062         for static members.
14063         (pass_in_v_vfp_candidate): Likewise.
14064
14065 2019-01-23  Tom Tromey  <tom@tromey.com>
14066             Pedro Alves  <palves@redhat.com>
14067
14068         * regcache.c (class regcache_invalidator): Remove.
14069         (regcache::raw_write): Use make_scope_exit.
14070
14071 2019-01-23  Tom Tromey  <tom@tromey.com>
14072
14073         * ui-out.h (class ui_out_emit_type): Update comment.
14074
14075 2019-01-23  Tom Tromey  <tom@tromey.com>
14076
14077         * infrun.c (fetch_inferior_event): Update comment.
14078
14079 2019-01-23  Tom Tromey  <tom@tromey.com>
14080             Pedro Alves  <palves@redhat.com>
14081
14082         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
14083         parameter.
14084         (fetch_inferior_event): Use SCOPE_EXIT.
14085
14086
14087 2019-01-23  Tom Tromey  <tom@tromey.com>
14088             Pedro Alves  <palves@redhat.com>
14089
14090         * infrun.c (disable_thread_events): Delete.
14091         (stop_all_threads): Use SCOPE_EXIT.
14092
14093 2019-01-23  Tom Tromey  <tom@tromey.com>
14094             Pedro Alves  <palves@redhat.com>
14095
14096         * symfile.c: Include forward-scope-exit.h.
14097         (clear_symtab_users_cleanup): Replace forward declaration with
14098         a FORWARD_SCOPE_EXIT.
14099         (syms_from_objfile_1): Use the forward_scope_exit and
14100         gdb::optional instead of cleanup_function.
14101         (reread_symbols): Use the forward_scope_exit instead of
14102         cleanup_function.
14103         (clear_symtab_users_cleanup): Remove function.
14104
14105 2019-01-23  Tom Tromey  <tom@tromey.com>
14106             Pedro Alves  <palves@redhat.com>
14107
14108         * linux-nat.c: Include scope-exit.h.
14109         (cleanup_target_stop): Remove.
14110         (linux_nat_target::static_tracepoint_markers_by_strid): Use
14111         SCOPE_EXIT.
14112
14113 2019-01-23  Tom Tromey  <tom@tromey.com>
14114             Pedro Alves  <palves@redhat.com>
14115
14116         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
14117         (call_function_by_hand_dummy): Use SCOPE_EXIT.
14118
14119 2019-01-23  Tom Tromey  <tom@tromey.com>
14120             Andrew Burgess  <andrew.burgess@embecosm.com>
14121             Pedro Alves  <palves@redhat.com>
14122
14123         * infrun.c (fetch_inferior_event): Use scope_exit.
14124         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
14125         * top.c (execute_command): Use scope_exit.
14126         * breakpoint.c (bpstat_do_actions): Use scope_exit.
14127         * utils.c (do_bpstat_clear_actions_cleanup)
14128         (make_bpstat_clear_actions_cleanup): Remove.
14129
14130 2019-01-23  Tom Tromey  <tom@tromey.com>
14131             Pedro Alves  <palves@redhat.com>
14132
14133         * infrun.c: Include "common/scope-exit.h"
14134         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
14135         (wait_for_inferior): Use SCOPE_EXIT.
14136         (fetch_inferior_event): Use scope_exit.
14137
14138 2019-01-23  Tom Tromey  <tom@tromey.com>
14139             Pedro Alves  <palves@redhat.com>
14140
14141         * breakpoint.c (create_breakpoint): Remove cleanup.
14142
14143 2019-01-23  Tom Tromey  <tom@tromey.com>
14144             Andrew Burgess  <andrew.burgess@embecosm.com>
14145             Pedro Alves  <palves@redhat.com>
14146
14147 2019-01-23  Pedro Alves  <palves@redhat.com>
14148
14149         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
14150
14151 2019-01-23  Pedro Alves  <palves@redhat.com>
14152             Andrew Burgess  <andrew.burgess@embecosm.com>
14153
14154         * gdbthread.h: Include "common/forward-scope-exit.h".
14155         (scoped_finish_thread_state): Redefine custom class in terms of
14156         forward_scope_exit.
14157
14158 2019-01-23  Pedro Alves  <palves@redhat.com>
14159             Andrew Burgess  <andrew.burgess@embecosm.com>
14160
14161         * common/forward-scope-exit.h: New file.
14162
14163 2019-01-23  Pedro Alves  <palves@redhat.com>
14164             Andrew Burgess  <andrew.burgess@embecosm.com>
14165             Tom Tromey  <tom@tromey.com>
14166
14167         * common/scope-exit.h: New file.
14168
14169 2019-01-23  Pedro Alves  <palves@redhat.com>
14170
14171         * common/preprocessor.h (ESC): Rename to ...
14172         (ESC_PARENS): ... this.
14173         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
14174         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
14175
14176 2019-01-23  Tom Tromey  <tom@tromey.com>
14177
14178         * language.h (class scoped_switch_to_sym_language_if_auto):
14179         Initialize m_lang in both cases.
14180
14181 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
14182
14183         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
14184         with XCNEW.
14185
14186 2019-01-22  Tom Tromey  <tom@tromey.com>
14187
14188         * corelow.c: Do not include sys/file.h.
14189
14190 2019-01-22  Tom Tromey  <tom@tromey.com>
14191
14192         * tui/tui-wingeneral.h: Include gdb_curses.h.
14193
14194 2019-01-22  Tom Tromey  <tom@tromey.com>
14195
14196         * source-cache.h (class source_cache) <get_source_lines,
14197         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
14198
14199 2019-01-22  Tom Tromey  <tom@tromey.com>
14200
14201         * remote-fileio.h (struct remote_target): Declare.
14202
14203 2019-01-22  Tom Tromey  <tom@tromey.com>
14204
14205         * python/py-arch.c: Do not include py-ref.h.
14206         * python/py-bpevent.c: Do not include py-ref.h.
14207         * python/py-cmd.c: Do not include py-ref.h.
14208         * python/py-continueevent.c: Do not include py-ref.h.
14209         * python/py-event.h: Do not include py-ref.h.
14210         * python/py-evtregistry.c: Do not include py-ref.h.
14211         * python/py-finishbreakpoint.c: Do not include py-ref.h.
14212         * python/py-frame.c: Do not include py-ref.h.
14213         * python/py-framefilter.c: Do not include py-ref.h.
14214         * python/py-function.c: Do not include py-ref.h.
14215         * python/py-infevents.c: Do not include py-ref.h.
14216         * python/py-linetable.c: Do not include py-ref.h.
14217         * python/py-objfile.c: Do not include py-ref.h.
14218         * python/py-param.c: Do not include py-ref.h.
14219         * python/py-prettyprint.c: Do not include py-ref.h.
14220         * python/py-progspace.c: Do not include py-ref.h.
14221         * python/py-symbol.c: Do not include py-ref.h.
14222         * python/py-symtab.c: Do not include py-ref.h.
14223         * python/py-type.c: Do not include py-ref.h.
14224         * python/py-unwind.c: Do not include py-ref.h.
14225         * python/py-utils.c: Do not include py-ref.h.
14226         * python/py-value.c: Do not include py-ref.h.
14227         * python/py-varobj.c: Do not include py-ref.h.
14228         * python/py-xmethods.c: Do not include py-ref.h.
14229         * python/python.c: Do not include py-ref.h.
14230         * varobj.c: Do not include py-ref.h.
14231
14232 2019-01-22  Tom Tromey  <tom@tromey.com>
14233
14234         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
14235         keyword for bcache.
14236
14237 2019-01-22  Tom Tromey  <tom@tromey.com>
14238
14239         * compile/compile-cplus-types.c: Remove a comment by #include.
14240
14241 2019-01-22  Tom Tromey  <tom@tromey.com>
14242
14243         * compile/gcc-c-plugin.h: Include compile-internal.h.
14244
14245 2019-01-22  Tom Tromey  <tom@tromey.com>
14246
14247         * stabsread.c (EXTERN): Do not define.
14248         (symnum, next_symbol_text_func, processing_gcc_compilation)
14249         (within_function, global_sym_chain, global_stabs)
14250         (previous_stab_code, this_object_header_files)
14251         (n_this_object_header_files)
14252         (n_allocated_this_object_header_files): Define.
14253         * stabsread.h (EXTERN): Never define.  Use "extern".
14254
14255 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14256
14257         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
14258         history_value.
14259
14260 2019-01-21  Tom Tromey  <tom@tromey.com>
14261
14262         * ui-out.c: Fix includes.
14263         * tui/tui-source.c: Fix includes.
14264         * target.c: Fix includes.
14265         * remote.c: Fix includes.
14266         * regcache.c: Fix includes.
14267         * python/py-block.c: Fix includes.
14268         * printcmd.c: Fix includes.
14269         * or1k-tdep.c: Fix includes.
14270         * mi/mi-main.c: Fix includes.
14271         * m32r-tdep.c: Fix includes.
14272         * csky-tdep.c: Fix includes.
14273         * compile/compile-cplus-types.c: Fix includes.
14274         * cli/cli-interp.c: Fix includes.
14275
14276 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
14277
14278         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
14279         for padding.
14280
14281 2019-01-16  Tom Tromey  <tom@tromey.com>
14282
14283         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
14284         earlier.
14285         (struct objfile) <msymbols_range>: Move from top level.
14286         <msymbols>: New method.
14287         (class objfile_msymbols): Remove.
14288         * symtab.c (default_collect_symbol_completion_matches_break_on):
14289         Update.
14290         * symmisc.c (dump_msymbols): Update.
14291         * stabsread.c (scan_file_globals): Update.
14292         * objc-lang.c (info_selectors_command, info_classes_command)
14293         (find_methods): Update.
14294         * minsyms.c (find_solib_trampoline_target): Update.
14295         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
14296         * coffread.c (coff_symfile_read): Update.
14297         * ada-lang.c (ada_lookup_simple_minsym)
14298         (ada_collect_symbol_completion_matches): Update.
14299
14300 2019-01-16  Tom Tromey  <tom@tromey.com>
14301
14302         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
14303         type.  Remove no-argument constructor.
14304         <iterator::operator++>: Simplify.
14305         <begin>: Update.
14306         <end>: Use minimal_symbol_count.
14307
14308 2019-01-16  Tom Tromey  <tom@tromey.com>
14309
14310         * objfiles.h (struct objfile) <psymtabs>: New method.
14311         (class objfile_psymtabs): Remove.
14312         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
14313         typedef.
14314         <range>: New method.
14315         (require_partial_symbols): Change return type.
14316         * psymtab.c (require_partial_symbols)
14317         (psym_expand_symtabs_matching): Update.
14318         * mdebugread.c (parse_partial_symbols): Update.
14319         * dbxread.c (dbx_end_psymtab): Update.
14320
14321 2019-01-15  Tom Tromey  <tom@tromey.com>
14322
14323         * symtab.c (lookup_objfile_from_block)
14324         (lookup_symbol_in_objfile_symtabs)
14325         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
14326         (find_line_symtab, info_sources_command)
14327         (default_collect_symbol_completion_matches_break_on)
14328         (make_source_files_completion_list): Update.
14329         * symmisc.c (print_objfile_statistics, dump_objfile)
14330         (maintenance_print_symbols, maintenance_info_symtabs)
14331         (maintenance_check_symtabs, maintenance_info_line_tables):
14332         Update.
14333         * source.c (select_source_symtab)
14334         (forget_cached_source_info_for_objfile): Update.
14335         * objfiles.h (class objfile_compunits): Remove.
14336         (struct objfile) <compunits_range>: New typedef.
14337         (compunits): New method.
14338         * objfiles.c (objfile_relocate1): Update.
14339         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
14340         * maint.c (count_symtabs_and_blocks): Update.
14341         * linespec.c (iterate_over_all_matching_symtabs): Update.
14342         * cp-support.c (add_symbol_overload_list_qualified): Update.
14343         * coffread.c (coff_symtab_read): Update.
14344         * ada-lang.c (add_nonlocal_symbols)
14345         (ada_collect_symbol_completion_matches)
14346         (ada_add_global_exceptions): Update.
14347
14348 2019-01-15  Tom Tromey  <tom@tromey.com>
14349
14350         * progspace.h (program_space) <objfiles_safe_range>: New
14351         typedef.
14352         <objfiles_safe>: New method.
14353         * objfiles.h (class all_objfiles_safe): Remove.
14354         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
14355         * jit.c (jit_inferior_exit_hook): Update.
14356
14357 2019-01-17  Tom Tromey  <tom@tromey.com>
14358
14359         * progspace.h (program_space) <objfiles_range>: New typedef.
14360         <objfiles>: New method.
14361         <objfiles_head>: Rename from objfiles.
14362         (object_files): Update.
14363         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
14364         * guile/scm-pretty-print.c
14365         (ppscm_find_pretty_printer_from_objfiles): Update.
14366         * guile/scm-objfile.c (gdbscm_objfiles): Update.
14367         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
14368         Update.
14369         * python/py-progspace.c (pspy_get_objfiles): Update.
14370         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
14371         Update.
14372         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
14373         (objfpy_lookup_objfile_by_build_id): Update.
14374         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
14375         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
14376         Update.
14377         * symtab.c (iterate_over_symtabs, matching_obj_sections)
14378         (expand_symtab_containing_pc, lookup_objfile_from_block)
14379         (lookup_static_symbol, basic_lookup_transparent_type)
14380         (find_pc_sect_compunit_symtab, find_symbol_at_address)
14381         (find_line_symtab, info_sources_command)
14382         (default_collect_symbol_completion_matches_break_on)
14383         (make_source_files_completion_list, find_main_name): Update.
14384         * symmisc.c (print_symbol_bcache_statistics)
14385         (print_objfile_statistics, maintenance_print_symbols)
14386         (maintenance_print_msymbols, maintenance_print_objfiles)
14387         (maintenance_info_symtabs, maintenance_check_symtabs)
14388         (maintenance_expand_symtabs, maintenance_info_line_tables):
14389         Update.
14390         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
14391         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
14392         (map_overlay_command, unmap_overlay_command)
14393         (simple_overlay_update, expand_symtabs_matching)
14394         (map_symbol_filenames): Update.
14395         * symfile-debug.c (set_debug_symfile): Update.
14396         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
14397         Update.
14398         * source.c (select_source_symtab, forget_cached_source_info):
14399         Update.
14400         * solib.c (solib_read_symbols): Update.
14401         * solib-spu.c (append_ocl_sos): Update.
14402         * psymtab.c (maintenance_print_psymbols)
14403         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
14404         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
14405         * printcmd.c (info_symbol_command): Update.
14406         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
14407         Update.
14408         * objfiles.h (class all_objfiles): Remove.
14409         * objfiles.c (have_partial_symbols, have_full_symbols)
14410         (have_minimal_symbols, qsort_cmp, update_section_map)
14411         (shared_objfile_contains_address_p)
14412         (default_iterate_over_objfiles_in_search_order): Update.
14413         * objc-lang.c (info_selectors_command, info_classes_command)
14414         (find_methods): Update.
14415         * minsyms.c (find_solib_trampoline_target): Update.
14416         * maint.c (maintenance_info_sections)
14417         (maintenance_translate_address, count_symtabs_and_blocks):
14418         Update.
14419         * main.c (captured_main_1): Update.
14420         * linux-thread-db.c (try_thread_db_load_from_pdir)
14421         (has_libpthread): Update.
14422         * linespec.c (iterate_over_all_matching_symtabs)
14423         (search_minsyms_for_name): Update.
14424         * jit.c (jit_find_objf_with_entry_addr): Update.
14425         * hppa-tdep.c (find_unwind_entry)
14426         (hppa_lookup_stub_minimal_symbol): Update.
14427         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
14428         Update.
14429         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
14430         (elf_gnu_ifunc_resolve_by_got): Update.
14431         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
14432         * dwarf-index-write.c (save_gdb_index_command): Update.
14433         * cp-support.c (add_symbol_overload_list_qualified): Update.
14434         * breakpoint.c (create_overlay_event_breakpoint)
14435         (create_longjmp_master_breakpoint)
14436         (create_std_terminate_master_breakpoint)
14437         (create_exception_master_breakpoint): Update.
14438         * blockframe.c (find_pc_partial_function): Update.
14439         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
14440         (ada_collect_symbol_completion_matches)
14441         (ada_add_global_exceptions): Update.
14442
14443 2019-01-17  Tom Tromey  <tom@tromey.com>
14444
14445         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
14446         declare VEC.
14447         (solib_target_parse_libraries): Change return type.
14448         (library_list_start_segment, library_list_start_section)
14449         (library_list_end_library, library_list_start_library); Update.
14450         (solib_target_free_library_list): Remove.
14451         (solib_target_parse_libraries): Remove cleanup.  Change return
14452         type.
14453         (solib_target_current_sos): Update.
14454
14455 2019-01-17  Tom Tromey  <tromey@bapiya>
14456
14457         * valprint.c: Replace "the the" with "the".
14458         * symtab.c: Replace "the the" with "the".
14459         * solib.c: Replace "the the" with "the".
14460         * solib-dsbt.c: Replace "the the" with "the".
14461         * linespec.c: Replace "the the" with "the".
14462         * dwarf2loc.h: Replace "the the" with "the".
14463         * amd64-windows-tdep.c: Replace "the the" with "the".
14464         * aarch64-tdep.c: Replace "the the" with "the".
14465
14466 2019-01-16  Keith Seitz  <keiths@redhat.com>
14467
14468         PR gdb/23773
14469         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
14470         <builder>: Rename to ..
14471         <m_builder>: ... this and make private.
14472         (dwarf2_cu::get_builder): New method.  Change all users of
14473         `builder' to use this method.
14474         (dwarf2_start_symtab): Move to ...
14475         (dwarf2_cu::start_symtab): ... here.  Update all callers
14476         (setup_type_unit_groups): Move to ...
14477         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
14478         callers.
14479         (dwarf2_cu::reset_builder): New method.
14480         (process_full_compunit, process_full_type_unit): Use
14481         dwarf2_cu::reset_builder.
14482         (follow_die_offset): Record the ancestor CU if it is different
14483         from the followed DIE's CU.
14484         (follow_die_sig_1): Likewise.
14485
14486 2019-01-15  Tom Tromey  <tom@tromey.com>
14487
14488         * remote.c (class remote_state) <buf>: Now a char_vector.
14489         <buf_size>: Remove.
14490         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
14491         parameter.
14492         (remote_target::getpkt_or_notif_sane_1)
14493         (remote_target::getpkt_sane)
14494         (remote_target::getpkt_or_notif_sane): Likewise.
14495         (class remote_target) <putpkt>: New overload.
14496         (remote_target::read_frame): Change type of "buf_p".  Remove
14497         sizeof_p parameter.
14498         (packet_ok): New overload.
14499         (packet_check_result): New overload.
14500         Update all uses.
14501
14502 2019-01-14  Tom Tromey  <tom@tromey.com>
14503
14504         * remote-notif.c (handle_notification, remote_notif_ack)
14505         (remote_notif_parse): Make "buf" const.
14506         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
14507         const.
14508         (remote_notif_parse, remote_notif_ack, handle_notification):
14509         Likewise.
14510         * remote.c (remote_notif_stop_parse): Make "buf" const.
14511         (remote_target::remote_parse_stop_reply): Make "buf" const.
14512         (remote_notif_stop_ack): Make "buf" const.
14513
14514 2019-01-14  Tom Tromey  <tom@tromey.com>
14515
14516         * remote.c (remote_console_output): Make parameter const.
14517
14518 2019-01-14  Tom Tromey  <tom@tromey.com>
14519
14520         * target-debug.h (target_debug_print_signals): Constify.
14521         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
14522         * procfs.c (procfs_target::pass_signals): Update.
14523         * linux-nat.c (linux_nat_target::pass_signals): Update.
14524         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
14525         * target-delegates.c: Rebuild.
14526         * remote.c (remote_target::program_signals): Update.
14527         (remote_target::pass_signals): Update.
14528         * target.c (target_pass_signals): Constify argument.
14529         (target_program_signals): Likewise.
14530         * target.h (struct target_ops) <pass_signals, program_signals>:
14531         Constify argument.
14532         (target_pass_signals, target_program_signals): Constify argument.
14533
14534 2019-01-14  Tom Tromey  <tom@tromey.com>
14535
14536         PR tui/28819:
14537         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
14538
14539 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
14540
14541         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
14542         field.
14543         * rs6000-tdep.c: Include reggroups.h.
14544         (IS_V_ALIAS_PSEUDOREG): Define.
14545         (rs6000_register_name): Return names for the "vX" aliases.
14546         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
14547         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
14548         aliases.  Call default_register_reggroup_p for all other
14549         pseudo-registers.
14550         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
14551         New functions.
14552         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
14553         Handle "vX" aliases.
14554         (v_alias_pseudo_register_collect): New function.
14555         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
14556         (rs6000_gdbarch_init): Initialize "vX" aliases as
14557         pseudo-registers.  Restore registration of
14558         rs6000_pseudo_register_reggroup_p with
14559         set_tdesc_pseudo_register_reggroup_p.
14560
14561 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
14562
14563         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
14564         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
14565         set_gdbarch_num_pseudo_regs.
14566
14567 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14568
14569         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
14570         Remove arg prefixname, add do_set and do_show.
14571         Add member functions set_list and show_list.
14572         * cli/cli-style.c (class cli_style_option): Update accordingly.
14573         (style_set_list): Move to file scope.
14574         (style_show_list): Likewise.
14575         (set_style): Call help_list.
14576         (show_style): Call cmd_show_list.
14577         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
14578         Update to use the new macro.
14579
14580 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
14581
14582         * ada-lang.c (_initialize_ada_language): Expand the help text
14583         for the "catch exception" command.
14584
14585 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14586
14587         * symtab.c (matching_obj_sections): Initialize obj,
14588         declare it closer to its usage.
14589
14590 2019-01-10  Tom Tromey  <tom@tromey.com>
14591
14592         * thread-iter.h (inf_threads_iterator): Use next_iterator.
14593         (basic_inf_threads_range): Remove.
14594         (inf_threads_range, inf_non_exited_threads_range)
14595         (safe_inf_threads_range): Use next_adapter.
14596
14597 2019-01-10  Keith Seitz  <keiths@redhat.com>
14598
14599         PR gdb/23712
14600         PR symtab/23010
14601         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
14602         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
14603
14604 2019-01-10  Keith Seitz  <keiths@redhat.com>
14605
14606         PR gdb/23712
14607         PR symtab/23010
14608         * dictionary.c (pending_to_vector): Remove.
14609         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
14610         Remove _1 suffix, replacing functions of the same name.  Update
14611         all callers.
14612         (dict_create_hashed, dict_create_hashed_expandable)
14613         (dict_create_linear, dict_create_linear_expandable, dict_free)
14614         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
14615         Make functions static.
14616
14617 2019-01-10  Keith Seitz  <keiths@redhat.com>
14618
14619         PR gdb/23712
14620         PR symtab/23010
14621         * dictionary.h (struct dictionary): Replace declaration with
14622         multidictionary.
14623         (dict_create_hashed, dict_create_hashed_expandable)
14624         (dict_create_linear, dict_create_linear_expandable)
14625         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
14626         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
14627         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
14628         taking multidictionary argument.
14629         [ALL_DICT_SYMBOLS]: Update for multidictionary.
14630         * block.h (struct block) <dict>: Change to multidictionary
14631         and rename `multidict'.
14632         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
14633         symmisc.c: Update all dictionary references to multidictionary.
14634
14635 2019-01-10  Keith Seitz  <keiths@redhat.com>
14636
14637         PR gdb/23712
14638         PR symtab/23010
14639         * dictionary.c: Include unordered_map.
14640         (pending_to_vector): New function.
14641         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
14642         Rewrite the non-"_1" functions to take vector instead
14643         of linked list.
14644         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
14645         "new" _1 versions of the same name.
14646         (multidictionary): Define.
14647         (std::hash<enum language): New definition.
14648         (collate_pending_symbols_by_language, mdict_create_hashed)
14649         (mdict_create_hashed_expandable, mdict_create_linear)
14650         (mdict_create_linear_expandable, mdict_free)
14651         (find_language_dictionary, create_new_language_dictionary)
14652         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
14653         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
14654         (mdict_size, mdict_empty): New functions.
14655         * dictionary.h (mdict_iterator): Define.
14656
14657 2019-01-10  Pedro Alves  <palves@redhat.com>
14658
14659         * breakpoint.c (read_uploaded_action)
14660         (create_tracepoint_from_upload): Adjust to use
14661         gdb::unique_xmalloc_ptr.
14662         * ctf.c (ctf_write_uploaded_tp):
14663         (SET_ARRAY_FIELD): Use emplace_back.
14664         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
14665         * tracefile-tfile.c (tfile_write_uploaded_tp):
14666         * tracepoint.c (parse_tracepoint_definition): Adjust to use
14667         gdb::unique_xmalloc_ptr.
14668         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
14669         at_string, cond_string, cmd_strings>: Replace char pointers
14670         with gdb::unique_xmalloc_ptr.
14671
14672 2019-01-10  Pedro Alves  <palves@redhat.com>
14673
14674         * solib-target.c (library_list_start_library): Don't xstrdup name.
14675
14676 2019-01-10  Pedro Alves  <palves@redhat.com>
14677
14678         * mdebugread.c (parse_partial_symbols): Use
14679         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
14680
14681 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
14682
14683         * linux-fork.c (scoped_switch_fork_info)
14684         <~scoped_switch_fork_info>: Fix incorrect variable name.
14685
14686 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
14687
14688         * linux-fork.c (scoped_switch_fork_info)
14689         <scoped_switch_fork_info>: Make explicit.
14690         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
14691
14692 2019-01-10  Tom Tromey  <tom@tromey.com>
14693
14694         * objfiles.h (objfile::reset_psymtabs): Update.
14695         * objfiles.c (objfile::objfile): Update.
14696         * psymtab.h (psymtab_storage::obstack): Update.
14697         (psymtab_storage::m_obstack): Use gdb::optional.
14698         (class psymtab_storage): Update comment.  Remove objfile
14699         parameter.
14700         * psymtab.c (psymtab_storage::psymtab_storage): Update.
14701
14702 2019-01-10  Tom Tromey  <tom@tromey.com>
14703
14704         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
14705         <free_psymtabs>: Now private.
14706         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
14707         (allocate_psymtab): Use new method.
14708
14709 2019-01-10  Tom Tromey  <tom@tromey.com>
14710
14711         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
14712         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
14713         * mdebugread.c (parse_partial_symbols): Use
14714         allocate_dependencies.
14715         * dwarf2read.c (dwarf2_create_include_psymtab): Use
14716         allocate_dependencies.
14717         (process_psymtab_comp_unit_reader)
14718         (build_type_psymtab_dependencies): Likewise.
14719         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
14720
14721 2019-01-10  Tom Tromey  <tom@tromey.com>
14722
14723         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
14724         PSYMBOL_SET_LANGUAGE.
14725         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
14726
14727 2019-01-10  Tom Tromey  <tom@tromey.com>
14728
14729         * psymtab.h (psymtab_storage::obstack): New method.
14730         <m_obstack>: Rename from obstack; now private.
14731         * psymtab.c (psymtab_storage): Update.
14732         * dwarf2read.c (create_addrmap_from_index)
14733         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
14734         Update.
14735
14736 2019-01-10  Tom Tromey  <tom@tromey.com>
14737
14738         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
14739         * objfiles.h (objfile::reset_psymtabs): New method.
14740
14741 2019-01-10  Tom Tromey  <tom@tromey.com>
14742
14743         * symmisc.c (print_symbol_bcache_statistics): Update.
14744         (print_objfile_statistics): Update.
14745         * symfile.c (reread_symbols): Update.
14746         * psymtab.h (class psymtab_storage): New.
14747         * psymtab.c (psymtab_storage): New constructor.
14748         (~psymtab_storage): New destructor.
14749         (require_partial_symbols): Update.
14750         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
14751         (find_pc_sect_psymtab, find_pc_sect_psymbol)
14752         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
14753         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
14754         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
14755         (start_psymtab_common, end_psymtab_common)
14756         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
14757         (allocate_psymtab): Update.
14758         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
14759         Update.
14760         (dump_psymtab_addrmap, maintenance_print_psymbols)
14761         (maintenance_check_psymtabs): Update.
14762         (class objfile_psymtabs): Move to objfiles.h.
14763         * psympriv.h (discard_psymtab): Now inline.
14764         (psymtab_discarder::psymtab_discarder): Update.
14765         (psymtab_discarder::~psymtab_discarder): Update.
14766         (ALL_OBJFILE_PSYMTABS): Rewrite.
14767         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
14768         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
14769         Remove fields.
14770         <partial_symtabs>: New field.
14771         (class objfile_psymtabs): Move from psymtab.h.  Update.
14772         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
14773         psymbol_cache.
14774         (objfile::~objfile): Don't destroy psymbol_cache.
14775         * mdebugread.c (parse_partial_symbols): Update.
14776         * dwarf2read.c (create_addrmap_from_index)
14777         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
14778         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
14779         (add_partial_subprogram, dwarf2_ranges_read): Update.
14780         * dwarf-index-write.c (write_address_map)
14781         (write_one_signatured_type, recursively_write_psymbols)
14782         (class debug_names, class debug_names, write_psymtabs_to_index):
14783         Update.
14784
14785 2019-01-10  Tom Tromey  <tom@tromey.com>
14786
14787         * symtab.h (SYMBOL_SET_NAMES): Update.
14788         (symbol_set_names): Update.
14789         (MSYMBOL_SET_NAMES): Update.
14790         * symtab.c (symbol_set_names): Change argument to be an
14791         objfile_per_bfd_storage.
14792         * psymtab.c (add_psymbol_to_bcache): Update.
14793         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
14794
14795 2019-01-10  Tom Tromey  <tom@tromey.com>
14796
14797         * symtab.c (create_demangled_names_hash): Change argument to be an
14798         objfile_per_bfd_storage.
14799         (symbol_set_names): Update.
14800
14801 2019-01-10  Tom Tromey  <tom@tromey.com>
14802
14803         * xcoffread.c (xcoff_initial_scan): Unconditionally call
14804         init_psymbol_list.
14805         * psymtab.c (init_psymbol_list): Do nothing if already called.
14806         * psympriv.h (init_psymbol_list): Add comment.
14807         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
14808         init_psymbol_list.
14809         * dbxread.c (dbx_symfile_read): Unconditionally call
14810         init_psymbol_list.
14811
14812 2019-01-10  Tom Tromey  <tom@tromey.com>
14813
14814         * xcoffread.c (scan_xcoff_symtab): Update.
14815         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
14816         "where".
14817         * mdebugread.c (parse_partial_symbols)
14818         (handle_psymbol_enumerators): Update.
14819         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
14820         * dbxread.c (read_dbx_symtab): Update.
14821         * psympriv.h (psymbol_placement): New enum.
14822         (add_psymbol_to_list): Update.
14823
14824 2019-01-10  Tom Tromey  <tom@tromey.com>
14825
14826         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
14827         static_psymbols parameters.
14828         (scan_xcoff_symtab): Update.
14829         * psymtab.c (start_psymtab_common): Remove global_psymbols and
14830         static_psymbols parameters.
14831         * psympriv.h (start_psymtab_common): Update.
14832         * mdebugread.c (parse_partial_symbols): Update.
14833         * dwarf2read.c (create_partial_symtab): Update.
14834         * dbxread.c (read_dbx_symtab): Update.
14835         (start_psymtab): Remove global_psymbols and static_psymbols
14836         parameters.
14837
14838 2019-01-10  Tom Tromey  <tom@tromey.com>
14839
14840         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
14841         * psymtab.c (allocate_psymtab): Add comment.
14842         * psympriv.h (allocate_psymtab): Add comment.
14843         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
14844         initializations.
14845         * dbxread.c (dbx_end_psymtab): Remove some initializations.
14846
14847 2019-01-10  Tom Tromey  <tom@tromey.com>
14848
14849         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
14850         Don't declare.
14851         * mipsread.c: Include mdebugread.h.
14852         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
14853         Declare.
14854         * elfread.c: Include mdebugread.h.
14855
14856 2019-01-09  Tom Tromey  <tom@tromey.com>
14857
14858         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
14859         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
14860         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
14861         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
14862         (psym_lookup_symbol, psym_find_last_source_symtab)
14863         (psym_forget_cached_source_info, psym_print_stats)
14864         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
14865         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
14866         (psym_map_matching_symbols, psym_expand_symtabs_matching)
14867         (psym_find_compunit_symtab_by_address)
14868         (maintenance_print_psymbols, maintenance_info_psymtabs)
14869         (maintenance_check_psymtabs): Use ranged for.
14870         * psymtab.h (class objfile_psymtabs): New.
14871         (require_partial_symbols): Return objfile_psymtabs.
14872         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
14873
14874 2019-01-09  Tom Tromey  <tom@tromey.com>
14875
14876         * symfile.c (overlay_invalidate_all, find_pc_overlay)
14877         (find_pc_mapped_section, list_overlays_command)
14878         (map_overlay_command, unmap_overlay_command)
14879         (simple_overlay_update): Use all_objfiles.
14880         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
14881         * printcmd.c (info_symbol_command): Use all_objfiles.
14882         * objfiles.h (ALL_OBJSECTIONS): Remove.
14883         * maint.c (maintenance_translate_address): Use all_objfiles.
14884         * gcore.c (gcore_create_callback): Use all_objfiles.
14885         (objfile_find_memory_regions): Likewise.
14886
14887 2019-01-09  Tom Tromey  <tom@tromey.com>
14888
14889         * symtab.c (find_line_symtab, info_sources_command)
14890         (make_source_files_completion_list): Use objfile_compunits.
14891         * source.c (select_source_symtab): Use objfile_compunits.
14892         * objfiles.h (struct objfile): Update comment.
14893         (ALL_OBJFILES): Remove.
14894         (ALL_FILETABS): Remove.
14895         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
14896         objfile_compunits.
14897
14898 2019-01-09  Tom Tromey  <tom@tromey.com>
14899
14900         * symmisc.c (print_objfile_statistics, dump_objfile)
14901         (maintenance_print_symbols): Use compunit_filetabs.
14902         * source.c (forget_cached_source_info_for_objfile): Use
14903         compunit_filetabs.
14904         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
14905         (ALL_FILETABS): Use compunit_filetabs.
14906         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
14907         * coffread.c (coff_symtab_read): Use compunit_filetabs.
14908
14909 2019-01-09  Tom Tromey  <tom@tromey.com>
14910
14911         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
14912         (compunit_filetabs): New.
14913         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
14914         compunit_filetabs.
14915         (info_sources_command, make_source_files_completion_list): Remove
14916         declaration.
14917         * symmisc.c (print_objfile_statistics, dump_objfile)
14918         (maintenance_print_symbols): Remove declaration.
14919         (maintenance_info_symtabs): Use compunit_filetabs.
14920         (maintenance_info_line_tables): Likewise.
14921         * source.c (select_source_symtab): Change local variable name.
14922         (forget_cached_source_info_for_objfile): Remove declaration.
14923         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
14924         * objfiles.c (objfile_relocate1): Remove declaration.
14925         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
14926         declaration.
14927         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
14928         * coffread.c (coff_symtab_read): Remove declaration.
14929         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
14930         compunit_filetabs.
14931
14932 2019-01-09  Tom Tromey  <tom@tromey.com>
14933
14934         * symtab.c (lookup_objfile_from_block)
14935         (find_pc_sect_compunit_symtab, search_symbols)
14936         (default_collect_symbol_completion_matches_break_on): Use
14937         objfile_compunits.
14938         * objfiles.h (ALL_COMPUNITS): Remove.
14939         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
14940         * cp-support.c (add_symbol_overload_list_qualified): Use
14941         objfile_compunits.
14942         * ada-lang.c (ada_collect_symbol_completion_matches)
14943         (ada_add_global_exceptions): Use objfile_compunits.
14944
14945 2019-01-09  Tom Tromey  <tom@tromey.com>
14946
14947         * source.c (select_source_symtab)
14948         (forget_cached_source_info_for_objfile): Remove declaration.
14949         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
14950         declaration.
14951         * maint.c (count_symtabs_and_blocks): Remove declaration.
14952         * cp-support.c (add_symbol_overload_list_qualified): Remove
14953         declaration.
14954         * coffread.c (coff_symtab_read): Remove declaration.
14955         * symtab.c (lookup_symbol_in_objfile_symtabs)
14956         (basic_lookup_transparent_type_1): Use objfile_compunits.
14957         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
14958         (info_sources_command, search_symbols)
14959         (default_collect_symbol_completion_matches_break_on)
14960         (make_source_files_completion_list): Remove declaration.
14961         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
14962         (ada_collect_symbol_completion_matches)
14963         (ada_add_global_exceptions): Remove declaration.
14964         * linespec.c (iterate_over_all_matching_symtabs): Use
14965         objfile_compunits.
14966         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
14967         (class objfile_compunits): New.
14968         (ALL_COMPUNITS): Use objfile_compunits.
14969         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
14970         (maintenance_check_symtabs, maintenance_info_line_tables): Use
14971         objfile_compunits.
14972         * objfiles.c (objfile_relocate1): Use objfile_compunits.
14973
14974 2019-01-09  Tom Tromey  <tom@tromey.com>
14975
14976         * symtab.c (search_symbols)
14977         (default_collect_symbol_completion_matches_break_on): Use
14978         objfile_msymbols.
14979         * ada-lang.c (ada_lookup_simple_minsym)
14980         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
14981         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
14982         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
14983         objfile_msymbols.
14984         * coffread.c (coff_symfile_read): Use objfile_msymbols.
14985         * symmisc.c (dump_msymbols): Use objfile_msymbols.
14986         * objc-lang.c (find_methods): Use objfile_msymbols.
14987         (info_selectors_command, info_classes_command): Likewise.
14988         * stabsread.c (scan_file_globals): Use objfile_msymbols.
14989         * objfiles.h (class objfile_msymbols): New.
14990         (ALL_OBJFILE_MSYMBOLS): Remove.
14991         (ALL_MSYMBOLS): Remove.
14992
14993 2019-01-09  Tom Tromey  <tom@tromey.com>
14994
14995         * common/next-iterator.h (next_adapter): Add Iterator template
14996         parameter.
14997         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
14998         (class all_objfiles_safe): New.
14999         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
15000         * objfiles.c (put_objfile_before): Update comment.
15001         (add_separate_debug_objfile): Likewise.
15002         (free_all_objfiles): Use all_objfiles_safe.
15003         (objfile_purge_solibs): Likewise.
15004
15005 2019-01-09  Tom Tromey  <tom@tromey.com>
15006
15007         * symtab.c (iterate_over_symtabs, matching_obj_sections)
15008         (expand_symtab_containing_pc, lookup_static_symbol)
15009         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
15010         (find_symbol_at_address, find_line_symtab, find_main_name): Use
15011         all_objfiles.
15012         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
15013         * breakpoint.c (create_overlay_event_breakpoint)
15014         (create_longjmp_master_breakpoint)
15015         (create_std_terminate_master_breakpoint)
15016         (create_exception_master_breakpoint): Use all_objfiles.
15017         * linux-thread-db.c (try_thread_db_load_from_pdir)
15018         (has_libpthread): Use all_objfiles.
15019         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
15020         * linespec.c (iterate_over_all_matching_symtabs)
15021         (search_minsyms_for_name): Use all_objfiles.
15022         * maint.c (maintenance_info_sections): Use all_objfiles.
15023         * main.c (captured_main_1): Use all_objfiles.
15024         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
15025         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
15026         * guile/scm-pretty-print.c
15027         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
15028         * solib-spu.c (append_ocl_sos): Use all_objfiles.
15029         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
15030         (maintenance_print_msymbols): Use all_objfiles.
15031         * source.c (select_source_symtab): Use all_objfiles.
15032         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
15033         * symfile.c (remove_symbol_file_command)
15034         (expand_symtabs_matching, map_symbol_filenames): Use
15035         all_objfiles.
15036         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
15037         all_objfiles.
15038         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
15039         * objc-lang.c (find_methods): Use all_objfiles.
15040         * objfiles.c (have_partial_symbols, have_full_symbols)
15041         (have_minimal_symbols, qsort_cmp)
15042         (default_iterate_over_objfiles_in_search_order): Use
15043         all_objfiles.
15044         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
15045         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
15046         (maintenance_check_psymtabs): Use all_objfiles.
15047         (ALL_PSYMTABS): Remove.
15048         * compile/compile-object-run.c (do_module_cleanup): Use
15049         all_objfiles.
15050         * blockframe.c (find_pc_partial_function): Use all_objfiles.
15051         * cp-support.c (add_symbol_overload_list_qualified): Use
15052         all_objfiles.
15053         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
15054         Use all_objfiles.
15055         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
15056         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
15057         all_objfiles.
15058         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
15059         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
15060         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
15061         Uses all_objfiles.
15062         * solib.c (solib_read_symbols): Use all_objfiles
15063
15064 2019-01-09  Tom Tromey  <tom@tromey.com>
15065
15066         * probe.c (parse_probes_in_pspace): Use all_objfiles.
15067         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
15068         all_objfiles.
15069         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
15070         * symmisc.c (print_symbol_bcache_statistics)
15071         (print_objfile_statistics, maintenance_print_objfiles)
15072         (maintenance_info_symtabs, maintenance_check_symtabs)
15073         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
15074         all_objfiles.
15075         * source.c (forget_cached_source_info): Use all_objfiles.
15076         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
15077         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
15078         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
15079         * objfiles.c (update_section_map): Use all_objfiles.
15080         (shared_objfile_contains_address_p): Likewise.
15081         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
15082         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
15083
15084 2019-01-09  Tom Tromey  <tom@tromey.com>
15085
15086         * common/next-iterator.h: New file.
15087         * objfiles.h (class all_objfiles): New.
15088         (struct objfile_iterator): New.
15089
15090 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
15091
15092         * NEWS: Move the description of the changed "frame", "select-frame",
15093          and "info frame" commands to the Changed commands section.
15094
15095 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
15096
15097         * gdbtypes.c (check_stub_method_group): Remove handling of old
15098         mangling schemes.
15099         * linespec.c (find_methods): Likewise.
15100         * stabsread.c (read_member_functions): Likewise.
15101         * valops.c (search_struct_method): Likewise.
15102         (value_struct_elt_for_reference): Likewise.
15103         * NEWS: Mention this change.
15104
15105 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
15106
15107         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
15108         print_source_lines.
15109         * source.c (print_source_lines_base): Update line number check.
15110         (print_source_lines): New function.
15111         (source_lines_range::source_lines_range): New function.
15112         * source.h (class source_lines_range): New class.
15113         (print_source_lines): New declaration.
15114
15115 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
15116
15117         * linespec.c (linespec_state_destructor): Free self->canonical_names.
15118
15119 2019-01-08  Tom Tromey  <tom@tromey.com>
15120             Simon Marchi  <simon.marchi@ericsson.com>
15121
15122         PR gdb/24060
15123         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
15124         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
15125         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
15126         * f-exp.y (DOLLAR_VARIABLE): Likewise.
15127         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
15128         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
15129
15130 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
15131
15132         * source.c (select_source_symtab): Move header comment to
15133         declaration in source.h.
15134         (forget_cached_source_info_for_objfile): Likewise.
15135         (forget_cached_source_info): Likewise.
15136         (identify_source_line): Likewise.
15137         * source.h (identify_source_line): Move declaration from symtab.h
15138         and add comment from source.c
15139         (print_source_lines): Likewise.
15140         (forget_cached_source_info_for_objfile): Likewise.
15141         (forget_cached_source_info): Likewise.
15142         (select_source_symtab): Likewise.
15143         (enum print_source_lines_flag): Move definition from symtab.h.
15144         * symtab.h (identify_source_line): Move declaration to source.h.
15145         (print_source_lines): Likewise.
15146         (forget_cached_source_info_for_objfile): Likewise.
15147         (forget_cached_source_info): Likewise.
15148         (select_source_symtab): Likewise.
15149         (enum print_source_lines_flag): Move definition to source.h.
15150         * tui/tui-hooks.c: Add 'source.h' include.
15151
15152 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
15153
15154         * source.c (print_source_lines_base): Handle requests to print
15155         reverse line number sequences, and guard against empty lines
15156         string.
15157
15158 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
15159
15160         * source.c (print_source_lines_base): Fix skip of '\r' if next
15161         character is '\n'.
15162
15163 2019-01-06  Tom Tromey  <tom@tromey.com>
15164
15165         * c-exp.y (struct c_parse_state) <macro_original_text,
15166         expansion_obstack>: New member.
15167         (macro_original_text, expansion_obstack): Remove globals.
15168         (scan_macro_expansion, scanning_macro_expansion)
15169         (finished_macro_expansion): Update.
15170         (scan_macro_cleanup): Remove.
15171         (yylex, c_parse): Update.
15172
15173 2019-01-06  Tom Tromey  <tom@tromey.com>
15174
15175         * c-exp.y (struct c_parse_state) <strings>: New member.
15176         (operator_stoken): Update.
15177
15178 2019-01-06  Tom Tromey  <tom@tromey.com>
15179
15180         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
15181         (union type_stack_elt) <typelist_val>: Now a pointer to
15182         std::vector.
15183         (type_stack_cleanup): Don't declare.
15184         (push_typelist): Update.
15185         * parse.c (pop_typelist): Return a std::vector.
15186         (push_typelist): Take a std::vector.
15187         (follow_types): Update.  Do not free args.
15188         (type_stack_cleanup): Remove.
15189         * c-exp.y (struct c_parse_state): New.
15190         (cpstate): New global.
15191         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
15192         (nonempty_typelist): Update.
15193         (func_mod): Create a new vector.
15194         (c_parse): Create a c_parse_state.
15195         (check_parameter_typelist): Do not delete params.
15196         (function_method): Update.  Do not delete type_list.
15197
15198 2019-01-06  Tom Tromey  <tom@tromey.com>
15199
15200         PR gdb/28155:
15201         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
15202         check_typedef.
15203         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
15204         (print_return_value): Likewise.
15205
15206 2019-01-05  Tom Tromey  <tom@tromey.com>
15207
15208         * contrib/cleanup_check.py: Remove.
15209         * contrib/gcc-with-excheck: Remove.
15210         * contrib/exsummary.py: Remove.
15211         * contrib/excheck.py: Remove.
15212
15213 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
15214
15215         * thread.c (delete_thread_1): Add gdb_assert that THR is not
15216         NULL. Initialize tpprev to NULL instead of assigning it
15217         to NULL on the next statement.
15218         * windows-nat.c (windows_delete_thread): Remove check for
15219         main_thread_id before printing thread exit notifications.
15220         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
15221         Remove thread ID check against main_thread_id.
15222         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
15223         windows_delete_thread.
15224         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
15225
15226 2019-01-04  Tom Tromey  <tom@tromey.com>
15227
15228         * compile/compile.c (_initialize_compile): Use upper case for
15229         metasyntactic variables.
15230         * symmisc.c (_initialize_symmisc): Use upper case for
15231         metasyntactic variables.
15232         * psymtab.c (_initialize_psymtab): Use upper case for
15233         metasyntactic variables.
15234         * demangle.c (demangle_command): Use upper case for metasyntactic
15235         variables.
15236         (_initialize_demangler): Likewise.
15237         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
15238         variables.
15239
15240 2019-01-03  Tom Tromey  <tom@tromey.com>
15241
15242         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
15243
15244 2019-01-03  Tom Tromey  <tom@tromey.com>
15245
15246         * python/py-symtab.c (salpy_str): Update.
15247         (struct salpy_sal_object) <symtab>: Now a PyObject.
15248         (salpy_dealloc): Update.
15249         (del_objfile_sal): Use gdbpy_ref.
15250
15251 2019-01-03  Tom Tromey  <tom@tromey.com>
15252
15253         * python/py-type.c (convert_field): Use new_reference.  Return
15254         gdbpy_ref.
15255         (make_fielditem): Return gdbpy_ref.
15256         (typy_fields): Update.
15257         (typy_getitem): Update.
15258         (field_name): Return gdbpy_ref.  Use new_reference.
15259         (typy_iterator_iternext): Update.
15260
15261 2019-01-03  Tom Tromey  <tom@tromey.com>
15262
15263         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
15264
15265 2019-01-03  Tom Tromey  <tom@tromey.com>
15266
15267         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
15268         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
15269         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
15270         (pspy_set_frame_filters, pspy_set_frame_unwinders)
15271         (pspy_set_type_printers): Likewise.
15272         * python/py-function.c (fnpy_init): Use gdbpy_ref.
15273         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
15274         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
15275         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
15276         (objfpy_set_type_printers): Likewise.
15277
15278 2019-01-03  Tom Tromey  <tom@tromey.com>
15279
15280         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
15281         (gdbpy_print_stack): Use gdbpy_err_fetch.
15282         * python/python-internal.h (class gdbpy_err_fetch): New class.
15283         (class gdbpy_enter) <m_error_type, m_error_value,
15284         m_error_traceback>: Remove.
15285         <m_error>: New member.
15286         (gdbpy_exception_to_string): Don't declare.
15287         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
15288         * python/py-value.c (convert_value_from_python): Use
15289         gdbpy_err_fetch.
15290         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
15291         gdbpy_exception_to_string.
15292         (gdbpy_handle_exception): Use gdbpy_err_fetch.
15293         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
15294         gdbpy_err_fetch.
15295
15296 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
15297
15298         * linux-nat.c (delete_lwp_cleanup): Delete.
15299         (struct lwp_deleter): New struct.
15300         (lwp_info_up): New typedef.
15301         (linux_nat_target::follow_fork): Delete cleanup, and make use of
15302         lwp_info_up.
15303
15304 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
15305
15306         * linux-fork.c (class scoped_switch_fork_info): New class.
15307         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
15308
15309 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
15310
15311         * valops.c (find_overload_match): Remove use of null_cleanup, and
15312         calls to do_cleanups.
15313
15314 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
15315
15316         * compile/compile-cplus-types.c
15317         (compile_cplus_instance::decl_name): Handle changes to
15318         cp_func_name.
15319         * cp-support.c (cp_func_name): Update header comment, update
15320         return type.
15321         * cp-support.h (cp_func_name): Update return type in declaration.
15322         * valops.c (find_overload_match): Move temp_func local to top
15323         level of function and change its type.  Use temp_func to hold and
15324         delete temporary string obtained from cp_func_name.
15325
15326 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
15327
15328         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
15329         gdb::char_vector, remove cleanup, and update uses of `msg`.
15330
15331 2019-01-03  Jim Wilson  <jimw@sifive.com>
15332
15333         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
15334
15335 2019-01-02  Tom Tromey  <tom@tromey.com>
15336
15337         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
15338         (tdesc_parse_xml): Remove cleanups.
15339         * target-descriptions.h (make_cleanup_free_target_description):
15340         Don't declare.
15341         (target_desc_deleter): New struct.
15342         (target_desc_up): New typedef.
15343         * target-descriptions.c (target_desc_deleter::operator()): Rename
15344         from free_target_description.
15345         (make_cleanup_free_target_description): Remove.
15346
15347 2019-01-02  Tom Tromey  <tom@tromey.com>
15348
15349         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
15350         constructor, destructor.
15351         (linespec_parser): Remove typedef.
15352         (~linespec_parser): Rename from linespec_parser_delete.
15353         (linespec_lex_to_end, linespec_complete_label)
15354         (linespec_complete): Update.
15355         (decode_line_full): Remove cleanups.
15356         (decode_line_1): Update.
15357
15358 2019-01-02  Tom Tromey  <tom@tromey.com>
15359
15360         * python/python-internal.h (inferior_to_inferior_object): Change
15361         return type.
15362         * python/py-exitedevent.c (create_exited_event_object): Update.
15363         * python/py-inferior.c (inferior_to_inferior_object): Return
15364         gdbpy_ref.
15365         (python_new_inferior, python_inferior_deleted)
15366         (thread_to_thread_object, delete_thread_object)
15367         (build_inferior_list, gdbpy_selected_inferior): Update.
15368         * python/py-infthread.c (create_thread_object): Update.  Also fail
15369         if inferior_to_inferior_object fails.
15370
15371 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
15372
15373         * inferior.h (class inferior) <displaced_step_state>: New field.
15374         * infrun.h (struct displaced_step_state): Move here from
15375         infrun.c.  Initialize fields, add constructor.
15376         <inf>: Remove field.
15377         <reset>: New method.
15378         * infrun.c (struct displaced_step_inferior_state): Move to
15379         infrun.h.
15380         (displaced_step_inferior_states): Remove.
15381         (get_displaced_stepping_state): Adust.
15382         (displaced_step_in_progress_any_inferior): Adjust.
15383         (displaced_step_in_progress_thread): Adjust.
15384         (displaced_step_in_progress): Adjust.
15385         (add_displaced_stepping_state): Remove.
15386         (get_displaced_step_closure_by_addr): Adjust.
15387         (remove_displaced_stepping_state): Remove.
15388         (infrun_inferior_exit): Call displaced_step_state.reset.
15389         (use_displaced_stepping): Don't check for NULL.
15390         (displaced_step_prepare_throw): Call
15391         get_displaced_stepping_state.
15392         (displaced_step_fixup): Don't check for NULL.
15393         (prepare_for_detach): Don't check for NULL.
15394
15395 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
15396
15397         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
15398          in case of call that did not complete.
15399
15400 2019-01-02  Andrey Utkin  <autkin@undo.io>
15401
15402         * symfile.c (find_separate_debug_file): Fix search of debug files for
15403         remote debuggee.
15404
15405 2019-01-02  Tom Tromey  <tom@tromey.com>
15406
15407         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
15408         indentation.
15409         * python/py-frame.c (frapy_older): Remove cast.
15410         (frapy_newer): Likewise.
15411         * python/py-breakpoint.c (local_setattro): Remove cast.
15412         * python/py-arch.c (archpy_name): Remove local variable.
15413         * python/py-type.c (gdbpy_lookup_type): Remove cast.
15414
15415 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
15416
15417         * unittests/basic_string_view/element_access/char/empty.cc:
15418         Fix year range in copyright header.
15419
15420 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
15421
15422         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
15423         Delete.
15424         <operator==>: Update with for removed field.
15425         <hash>: Likewise.
15426         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
15427         <isa_features>: ...this.
15428         <abi_features>: New field.
15429         (riscv_isa_flen): Update comment.
15430         (riscv_abi_xlen): New declaration.
15431         (riscv_abi_flen): New declaration.
15432         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
15433         isa_features.
15434         (riscv_abi_xlen): New function.
15435         (riscv_isa_flen): Update to get answer from isa_features.
15436         (riscv_abi_flen): New function.
15437         (riscv_has_fp_abi): Update to get answer from abi_features.
15438         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
15439         xlen and flen.
15440         (riscv_call_info) <xlen, flen>: Update comment.
15441         (riscv_call_arg_struct): Remove invalid assertions
15442         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
15443         is removed.
15444         (riscv_gdbarch_init): Gather isa features and abi features
15445         separately, ensure both match on the gdbarch when reusing an old
15446         gdbarch.  Relax an error check to allow 32-bit abi float to run on
15447         a target with 64-bit float hardware.
15448
15449 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
15450
15451         * source.c (search_command_helper): Stop reverse search
15452         when line 1 has been searched.
15453
15454 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
15455
15456         * record-full.c (record_full_base_target::close): Rewrite
15457         record_full_core_buf_list free logic.
15458
15459 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
15460
15461         * break-catch-syscall.c (print_one_catch_syscall): xfree
15462         the last text.
15463
15464 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
15465
15466         * top.c (print_gdb_version): Update Copyright year in version
15467         message.
15468
15469 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
15470
15471         Update copyright year range in all GDB files.
15472
15473 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
15474
15475         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
15476
15477 For older changes see ChangeLog-2018.
15478 \f
15479 Local Variables:
15480 mode: change-log
15481 left-margin: 8
15482 fill-column: 74
15483 version-control: never
15484 coding: utf-8
15485 End:
15486