gdb/ChangeLog

   1 2019-12-19  Christian Biesinger  <cbiesinger@google.com>
   2
   3         * configure: Regenerate.
   4         * configure.ac: Quote variable arguments of test.
   5         * gdbsupport/common.m4: Likewise.
   6
   7 2019-12-19  Christian Biesinger  <cbiesinger@google.com>
   8
   9         * score-tdep.c (score7_analyze_prologue): Pass 2.0 instead of
  10         2 to pow ().
  11
  12 2019-12-19  Christian Biesinger  <cbiesinger@google.com>
  13
  14         * tui/tui-source.c (tui_source_window::set_contents): Cast argument of
  15         log10 to double to fix Solaris 11 with gcc 5.5.
  16
  17 2019-12-19  Christian Biesinger  <cbiesinger@google.com>
  18
  19         * fbsd-tdep.c (fbsd_info_proc_files_entry): Rename local var
  20         "sun" to "saddr_un".
  21
  22 2019-12-19  Tom Tromey  <tromey@adacore.com>
  23
  24         * ui-out.h (enum class field_kind): Fix comment.
  25
  26 2019-12-11  Tom Tromey  <tromey@adacore.com>
  27
  28         * xml-support.c (xml_fetch_content_from_file): Use FOPEN_RB.
  29
  30 2019-12-18  Tom Tromey  <tromey@adacore.com>
  31
  32         PR build/25268:
  33         * gdbsupport/thread-pool.c (set_thread_name): Expect "int" return
  34         type on macOS.  Add comment.
  35
  36 2019-12-18  Simon Marchi  <simon.marchi@efficios.com>
  37
  38         * c-lang.c (c_get_string, asm_language_defn): Remove space
  39         before tab.
  40
  41 2019-12-18  Tom Tromey  <tromey@adacore.com>
  42
  43         PR build/25250:
  44         * ui-out.c (ui_out::vmessage): Update.
  45         * ui-out.h (enum class field_kind) <FIELD_STRING, FIELD_SIGNED>:
  46         Rename.
  47         (string_field): Update.
  48         (signed_field): Update.
  49
  50 2019-12-18  Simon Marchi  <simon.marchi@efficios.com>
  51
  52         * top.c (print_gdb_configuration): Adjust indentation.
  53
  54 2019-12-17  Christian Biesinger  <cbiesinger@google.com>
  55
  56         * bsd-kvm.c: Include gdbsupport/pathstuff.h.
  57
  58 2019-12-17  Simon Marchi  <simon.marchi@polymtl.ca>
  59
  60         * tui/tui-layout.h (class tui_layout_base): Add virtual
  61         destructor.
  62
  63 2019-12-16  Bernd Edlinger  <bernd.edlinger@hotmail.de>
  64
  65         * infcmd.c (prepare_one_step): Step over skipped inline functions.
  66         * infrun.c (inline_frame_is_marked_for_skip): New helper function.
  67         (process_event_stop_test): Keep stepping over skipped inline functions.
  68
  69 2019-12-16  Simon Marchi  <simon.marchi@polymtl.ca>
  70
  71         * jit.c (struct gdb_block) <next>: Remove field.
  72         (struct gdb_symtab) <~gdb_symtab>: Remove.
  73         <blocks>: Change type to std::forward_list<gdb_block>.
  74         (compare_block): Remove.
  75         (jit_block_open_impl): Adjust to std::forward_list.  Place the new
  76         block at the beginning, don't mind about sorting.
  77         (finalize_symtab): Adjust to std::forward_list, sort the blocks list
  78         before using it.
  79
  80 2019-12-16  Simon Marchi  <simon.marchi@polymtl.ca>
  81
  82         * jit.c (struct gdb_block): Add constructor, initialize
  83         real_block and next fields.
  84         <name>: Change type to gdb::unique_xmalloc_ptr.
  85         (struct gdb_symtab) <~gdb_symtab>: Free blocks with delete.
  86         (jit_block_open_impl): Allocate gdb_block with new.
  87         (finalize_symtab): Adjust to gdb::unique_xmalloc_ptr.
  88
  89 2019-12-16  Simon Marchi  <simon.marchi@polymtl.ca>
  90
  91         * jit.c: Include forward_list.
  92         (struct gdb_symtab) <next>: Remove field.
  93         (struct gdb_object) <symtabs>: Change type to
  94         std::forward_list<gdb_symtab>.
  95         (jit_object_open_impl): Allocate gdb_object with new.
  96         (jit_symtab_open_impl): Adjust to std::forward_list.
  97         (finalize_symtab): Don't delete symtab.
  98         (jit_object_close_impl):  Adjust to std::forward_list.  Free
  99         gdb_object with delete.
 100
 101 2019-12-16  Simon Marchi  <simon.marchi@polymtl.ca>
 102
 103         * jit.c (struct gdb_symtab): Add constructor, destructor,
 104         initialize fields.
 105         <linetable>: Change type to unique_xmalloc_ptr.
 106         <file_name>: Change type to std::string.
 107         (jit_symtab_open_impl): Allocate gdb_symtab with new.
 108         (jit_symtab_line_mapping_add_impl): Adjust.
 109         (finalize_symtab): Adjust, call delete on stab.
 110
 111 2019-12-16  Simon Marchi  <simon.marchi@polymtl.ca>
 112
 113         * jit.c (finalize_symtab): Set gdb_block_iter_tmp in loop.
 114
 115 2019-12-16  Tom Tromey  <tromey@adacore.com>
 116
 117         * windows-nat.c (windows_nat_target::attach): Update.
 118         * remote.c (extended_remote_target::attach): Update.
 119         * procfs.c (procfs_target::attach): Update.
 120         * nto-procfs.c (nto_procfs_target::attach): Update.
 121         (nto_procfs_target::create_inferior): Update.
 122         * inf-ptrace.c (inf_ptrace_target::attach): Update.
 123         * gnu-nat.c (gnu_nat_target::attach): Update.
 124         (gnu_nat_target::detach): Update.
 125         * darwin-nat.c (darwin_nat_target::attach): Update.
 126         * corefile.c (get_exec_file): Constify result.  Remove extraneous
 127         return.
 128         * bsd-kvm.c (bsd_kvm_target_open): Update.
 129         * gdbsupport/common-inferior.h (get_exec_file): Constify result.
 130
 131 2019-12-16  Christian Biesinger  <cbiesinger@google.com>
 132
 133         * gdbsupport/common-defs.h: Remove workaround for a gnulib bug
 134         (we no longer need to include time.h before pathmax.h)
 135
 136 2019-12-15  Christian Biesinger  <cbiesinger@google.com>
 137
 138         * ada-exp.y (write_ambiguous_var): Update.
 139         * coffread.c (process_coff_symbol): Update.
 140         * ctfread.c (ctf_add_enum_member_cb): Update.
 141         (new_symbol): Update.
 142         * dwarf2read.c (fixup_go_packaging): Update.
 143         (new_symbol): Update.
 144         * language.c (language_alloc_type_symbol): Update.
 145         * mdebugread.c (new_symbol): Update.
 146         * minsyms.c (minimal_symbol_reader::record_full): Update.
 147         * psymtab.c (add_psymbol_to_bcache): Update.
 148         * stabsread.c (define_symbol): Update.
 149         (read_enum_type): Update.
 150         * symtab.c (symbol_set_language): Make this a member function...
 151         (general_symbol_info::set_language): ... here.
 152         * symtab.h (struct general_symbol_info) <set_language>: New function.
 153         (SYMBOL_SET_LANGUAGE): Remove.
 154         (symbol_set_language): Remove.
 155
 156 2019-12-15  Christian Biesinger  <cbiesinger@google.com>
 157
 158         * ada-lang.c (ada_add_block_symbols): Update.
 159         (ada_collect_symbol_completion_matches): Update.
 160         * ax-gdb.c (gen_expr): Update.
 161         * block.c (block_lookup_symbol): Update.
 162         (block_lookup_symbol_primary): Update.
 163         (block_find_symbol): Update.
 164         * cp-namespace.c (cp_lookup_symbol_imports_or_template): Update.
 165         * dbxread.c (process_one_symbol): Update.
 166         * dictionary.c (insert_symbol_hashed): Update.
 167         (collate_pending_symbols_by_language): Update.
 168         (mdict_add_symbol): Update.
 169         * dwarf-index-write.c (write_psymbols): Update.
 170         * dwarf2read.c (fixup_go_packaging): Update.
 171         * findvar.c (read_var_value): Update.
 172         * ft32-tdep.c (ft32_skip_prologue): Update.
 173         * go-lang.c (go_symbol_package_name): Update.
 174         * language.h (scoped_switch_to_sym_language_if_auto::
 175         scoped_switch_to_sym_language_if_auto): Update.
 176         * linespec.c (find_method): Update.
 177         (find_label_symbols_in_block): Update.
 178         * mdebugread.c (parse_symbol): Update.
 179         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
 180         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
 181         (minimal_symbol_reader::install): Update.
 182         * moxie-tdep.c (moxie_skip_prologue): Update.
 183         * parse.c (parse_exp_in_context): Update.
 184         * psymtab.c (psymbol_name_matches): Update.
 185         (match_partial_symbol): Update.
 186         (lookup_partial_symbol): Update.
 187         (psymbol_hash): Update.
 188         (psymbol_compare): Update.
 189         * python/py-framefilter.c (extract_sym): Update.
 190         (py_print_single_arg): Update.
 191         * stabsread.c (define_symbol): Update.
 192         * stack.c (print_frame_arg): Update.
 193         (find_frame_funname): Update.
 194         (info_frame_command_core): Update.
 195         * symfile.c (set_initial_language): Update.
 196         * symtab.c (symbol_set_demangled_name): Update.
 197         (symbol_get_demangled_name): Update.
 198         (symbol_set_language): Update.
 199         (symbol_find_demangled_name): Update.
 200         (symbol_set_names): Update.
 201         (general_symbol_info::natural_name): Update.
 202         (general_symbol_info::demangled_name): Update.
 203         (general_symbol_info::search_name): Update.
 204         (symbol_matches_search_name): Update.
 205         (eq_symbol_entry): Update.
 206         (iterate_over_symbols): Update.
 207         (completion_list_add_symbol): Update.
 208         (completion_list_add_msymbol): Update.
 209         (completion_list_add_fields): Update.
 210         * symtab.h (struct general_symbol_info) <language>: New function.
 211         <language>: Rename to...
 212         <m_language>: ...this.
 213         (SYMBOL_LANGUAGE): Remove.
 214         (MSYMBOL_LANGUAGE): Remove.
 215         (struct symbol) <ctor>: Update.
 216         * xstormy16-tdep.c (xstormy16_skip_prologue): Update.
 217
 218 2019-12-15  Christian Biesinger  <cbiesinger@google.com>
 219
 220         * ada-exp.y (write_ambiguous_var): Call symbol_set_language to
 221         set the language of sym.
 222         * language.c (language_alloc_type_symbol): Likewise.
 223
 224 2019-12-14  Sergio Durigan Junior  <sergiodj@redhat.com>
 225
 226         https://bugzilla.redhat.com/show_bug.cgi?id=1728147
 227         PR gdb/23613
 228         * bsd-kvm.c (bsd_kvm_target_open): Use 'gdb_abspath'.
 229         * corelow.c: Include 'gdbsupport/pathstuff.h'.
 230         (core_target_open): Use 'gdb_abspath'.
 231         * gdbsupport/pathstuff.c (gdb_abspath): Guard against
 232         'current_directory == NULL' case.
 233         * gdbsupport/pathstuff.h (gdb_abspath): Expand comment and
 234         explain what happens when 'current_directory' is NULL.
 235         * go32-nat.c (go32_nat_target::wait): Check if
 236         'current_directory' is NULL before call to 'chdir'.
 237         * source.c (add_path): Use 'gdb_abspath'.
 238         * top.c: Include 'gdbsupport/pathstuff.h'.
 239         (init_history): Use 'gdb_abspath'.
 240         (set_history_filename): Likewise.
 241         * tracefile-tfile.c: Include 'gdbsupport/pathstuff.h'.
 242         (tfile_target_open): Use 'gdb_abspath'.
 243
 244 2019-12-13  Tom Tromey  <tromey@adacore.com>
 245
 246         * contrib/ari/gdb_ari.sh: Remove check for multiple calls to
 247         warning or error.
 248
 249 2019-12-13  Tom Tromey  <tromey@adacore.com>
 250
 251         * contrib/ari/gdb_ari.sh: Remove call to "fix" for "long long".
 252
 253 2019-12-13  Tom Tromey  <tromey@adacore.com>
 254
 255         * contrib/ari/gdb_ari.sh: Handle -Wno- prefix.
 256
 257 2019-12-13  Tom Tromey  <tromey@adacore.com>
 258
 259         * contrib/ari/gdb_ari.sh (usage): Use GNU style.
 260
 261 2019-12-13  Tom Tromey  <tromey@adacore.com>
 262
 263         * gdbsupport/common-utils.c (string_printf, string_vprintf)
 264         (string_vappendf): Add ARI comment.
 265
 266 2019-12-13  Tom Tromey  <tromey@adacore.com>
 267
 268         * contrib/ari/gdb_ari.sh: Remove "fix" call for
 269         floatformat_to_double.
 270         * target-float.c (host_float_ops<T>::from_target): Add ARI
 271         comment.
 272
 273 2019-12-13  Tom Tromey  <tromey@adacore.com>
 274
 275         * contrib/ari/gdb_ari.sh: Remove "fix" call for abort.
 276         * utils.c (abort_with_message, dump_core, internal_vproblem): Add
 277         ARI marker to abort.
 278         * event-top.c (handle_sigsegv): Add ARI marker to abort.
 279
 280 2019-12-13  Tom Tromey  <tromey@adacore.com>
 281
 282         * contrib/ari/gdb_ari.sh: Fix floatformat_from_double text.
 283
 284 2019-12-13  Tom Tromey  <tromey@adacore.com>
 285
 286         * contrib/ari/gdb_ari.sh: Remove ATTRIBUTE_UNUSED check.
 287
 288 2019-12-13  Tom Tromey  <tromey@adacore.com>
 289
 290         * contrib/ari/gdb_ari.sh: Remove "boolean" and "var_boolean"
 291         checks.
 292
 293 2019-12-13  Tom Tromey  <tromey@adacore.com>
 294
 295         * gdbsupport/safe-iterator.h (class basic_safe_range) <begin,
 296         end>: No longer "const".
 297
 298 2019-12-13  Simon Marchi  <simon.marchi@polymtl.ca>
 299
 300         * jit.c: Fix indentation, replace spaces with tabs where
 301         applicable.
 302
 303 2019-12-13  Jozef Lawrynowicz  <jozef.l@mittosystems.com>
 304
 305         * configure.tgt: Match msp430-*-elf* targets when configuring GDB.
 306
 307 2019-12-12  Tom Tromey  <tom@tromey.com>
 308
 309         * objfiles.h (struct objfile) <partial_symtabs>: Now a
 310         unique_ptr.
 311
 312 2019-12-12  Tom Tromey  <tom@tromey.com>
 313
 314         * progspace.h (objfile_list): New typedef.
 315         (class unwrapping_objfile_iterator)
 316         (struct unwrapping_objfile_range): Newl
 317         (struct program_space) <objfiles_range>: Change type.
 318         <objfiles>: Change return type.
 319         <add_objfile>: Change type of "objfile" parameter.
 320         <objfiles_list>: Now a list of shared_ptr.
 321         * progspace.c (program_space::add_objfile): Change type of
 322         "objfile".  Update.
 323         (program_space::remove_objfile): Update.
 324         * objfiles.h (struct objfile) <~objfile>: Make public.
 325         * objfiles.c (objfile::make): Update.
 326         (objfile::unlink): Don't call delete.
 327
 328 2019-12-12  Tom Tromey  <tom@tromey.com>
 329
 330         * symfile.c (symbol_file_clear): Update.
 331         * progspace.h (struct program_space) <free_all_objfiles>: Declare
 332         method.
 333         * progspace.c (program_space::free_all_objfiles): New method.
 334         * objfiles.h (free_all_objfiles): Don't declare.
 335         * objfiles.c (free_all_objfiles): Move to program_space.
 336
 337 2019-12-12  Tom Tromey  <tom@tromey.com>
 338
 339         * progspace.c (program_space::add_objfile)
 340         (program_space::remove_objfile): Update.
 341         (program_space::multi_objfile_p): Remove.
 342         * objfiles.h (struct objfile) <next>: Remove.
 343         * objfiles.c (objfile::objfile): Update.
 344         (put_objfile_before): Update.
 345         (unlink_objfile): Update.
 346         * progspace.h (object_files): Remove.
 347         (struct program_space) <objfiles_head>: Remove.
 348         <objfiles_list>: New member.
 349         <objfiles_range, objfiles_safe_range>: Change type.
 350         (objfiles): Change return type.
 351         (objfiles_safe): Update.
 352         (multi_objfile_p): Rewrite and inline.
 353         (object_files): Remove macro.
 354
 355 2019-12-12  Tom Tromey  <tom@tromey.com>
 356
 357         * gdbsupport/safe-iterator.h (basic_safe_iterator): Simplify.  Add
 358         second constructor.
 359         (basic_safe_range): New class.
 360
 361 2019-12-12  Tom Tromey  <tom@tromey.com>
 362
 363         * progspace.c (program_space::multi_objfile_p): New method.
 364         * printcmd.c (info_symbol_command): Update.
 365         * maint.c (maintenance_translate_address): Update.
 366         * objfiles.h (MULTI_OBJFILE_P): Remove.
 367         * progspace.h (struct program_space) <multi_objfile_p>: New
 368         method.
 369
 370 2019-12-12  Tom Tromey  <tom@tromey.com>
 371
 372         * progspace.h (struct program_space) <remove_objfile>: Declare.
 373         * progspace.c (program_space::remove_objfile): New method.
 374         * objfiles.c (unlink_objfile): Remove.
 375         (objfile::unlink): Call remove_objfile.
 376         (objfile): Don't call unlink_objfile.
 377
 378 2019-12-12  Tom Tromey  <tom@tromey.com>
 379
 380         * progspace.h (struct program_space) <add_objfile>: Declare
 381         method.
 382         * progspace.c (program_space::add_objfile): New method.
 383         * objfiles.c (~objfile): Don't unlink objfile.
 384         (put_objfile_before): Remove.
 385         (add_separate_debug_objfile): Don't call put_objfile_before.
 386         (objfile::make): Call add_objfile.  Set new_objfiles_available on
 387         the per-program-space data.
 388
 389 2019-12-12  Tom Tromey  <tom@tromey.com>
 390
 391         * symfile.c (syms_from_objfile_1): Use objfile_up.
 392         (syms_from_objfile_1, remove_symbol_file_command): Call unlink
 393         method.
 394         (reread_symbols): Use objfile_up.
 395         * solib.c (update_solib_list, reload_shared_libraries_1): Call
 396         unlink method.
 397         * objfiles.h (struct objfile) <~objfile>: Now private.
 398         <unlink>: New method.
 399         (struct objfile_deleter): New.
 400         (objfile_up): New typedef.
 401         * objfiles.c (objfile::unlink): New method.
 402         (free_objfile_separate_debug, free_all_objfiles)
 403         (objfile_purge_solibs): Use it.
 404         * jit.c (jit_unregister_code): Remove.
 405         (jit_inferior_exit_hook, jit_event_handler): Call unlink on
 406         objfile.
 407         * compile/compile-object-run.c (do_module_cleanup): Call unlink on
 408         objfile.
 409         * compile/compile-object-load.c (compile_object_load): Use
 410         objfile_up.
 411
 412 2019-12-12  Tom Tromey  <tom@tromey.com>
 413
 414         * symfile.c (symbol_file_add_with_addrs): Pass "parent" to
 415         objfile::make.
 416         * objfiles.h (struct objjfile) <make>: No longer inline.
 417         (add_separate_debug_objfile): Don't declare.
 418         * objfiles.c (add_separate_debug_objfile): Now static.
 419         (objfile::make): Move from objfiles.h.  Call
 420         add_separate_debug_objfile.  Add "parent" parameter.
 421
 422 2019-12-12  Tom Tromey  <tom@tromey.com>
 423
 424         * symfile.c (symbol_file_add_with_addrs): Use objfile::make.
 425         * objfiles.h (struct objfile): Make constructor private.
 426         <make>: New static method.
 427         * jit.c (jit_object_close_impl): Update.
 428
 429 2019-12-12  Simon Marchi  <simon.marchi@polymtl.ca>
 430
 431         * jit.c (jit_reader_try_read_symtab): Replace xmalloc/xfree with
 432         gdb::byte_vector.
 433
 434 2019-12-12  Tom Tromey  <tromey@adacore.com>
 435
 436         * xml-support.c (xml_fetch_content_from_file): Don't call
 437         malloc_failure.
 438         * utils.h (class gdb_argv): Remove malloc_failure comment.
 439         * utils.c (gdb_argv::reset): Don't call malloc_failure.
 440
 441 2019-12-12  Tom Tromey  <tromey@adacore.com>
 442
 443         * Makefile.in (ALL_TARGET_OBS): Add riscv-ravenscar-thread.o.
 444         (HFILES_NO_SRCDIR): Add riscv-ravenscar-thread.h.
 445         (ALLDEPFILES): Add riscv-ravenscar-thread.c.
 446         * configure.tgt (riscv-*-*): Add riscv-ravenscar-thread.o.
 447         * riscv-ravenscar-thread.c: New file.
 448         * riscv-ravenscar-thread.h: New file.
 449         * riscv-tdep.c (riscv_gdbarch_init): Call
 450         register_riscv_ravenscar_ops.
 451
 452 2019-12-12  Tom Tromey  <tromey@adacore.com>
 453
 454         * gdbsupport/thread-pool.c (set_thread_name): Use
 455         ATTRIBUTE_UNUSED.
 456
 457 2019-12-12  Luis Machado  <luis.machado@linaro.org>
 458
 459         * gdbsupport/safe-strerror.c: Don't include diagnostics.h.
 460         (select_strerror_r): Use ATTRIBUTE_UNUSED instead of the diagnostics
 461         macros.
 462
 463 2019-12-11  Tom Tromey  <tom@tromey.com>
 464
 465         * tui/tui-win.c (tui_set_win_height_command): Call
 466         tui_adjust_window_height.
 467         (tui_adjust_win_heights, new_height_ok): Remove.
 468         * tui/tui-layout.h (tui_adjust_window_height): Declare.
 469         * tui/tui-layout.c (tui_adjust_window_height): New function.
 470
 471 2019-12-11  Tom Tromey  <tom@tromey.com>
 472
 473         * tui/tui-win.c (tui_resize_all): Remove code, call
 474         tui_apply_current_layout.
 475
 476 2019-12-11  Tom Tromey  <tom@tromey.com>
 477
 478         * tui/tui-layout.h (tui_apply_current_layout): Declare.
 479         * tui/tui-layout.c (standard_layouts, applied_layout): New
 480         globals.
 481         (tui_apply_current_layout): New function.
 482         (show_layout): Set applied_layout.  Call
 483         tui_apply_current_layout.
 484         (show_source_command, show_disasm_command)
 485         (show_source_disasm_command, show_data)
 486         (show_source_or_disasm_and_command): Remove.
 487         (initialize_layouts): New function.
 488         (_initialize_tui_layout): Call initialize_layouts.
 489
 490 2019-12-11  Tom Tromey  <tom@tromey.com>
 491
 492         * tui/tui-layout.h (class tui_layout_base)
 493         (class tui_layout_window, class tui_layout_split): New.
 494         * tui/tui-layout.c (tui_get_window_by_name)
 495         (tui_layout_window::clone, tui_layout_window::apply)
 496         (tui_layout_window::get_sizes, tui_layout_window::add_split)
 497         (tui_layout_split::add_window, tui_layout_split::clone)
 498         (tui_layout_split::get_sizes)
 499         (tui_layout_split::set_weights_from_heights)
 500         (tui_layout_split::adjust_size, tui_layout_split::apply): New
 501         functions.
 502         (tui_layout_split::add_split, tui_layout_split::add_split)
 503         (tui_layout_split::set_weights_from_heights)
 504         (tui_layout_split::set_weights_from_heights): New functions.
 505
 506 2019-12-11  Tom Tromey  <tom@tromey.com>
 507
 508         * tui/tui-wingeneral.c (tui_gen_win_info::make_window): Update.
 509         * tui/tui-win.c (tui_adjust_win_heights, tui_resize_all): Update.
 510         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
 511         * tui/tui-data.h (struct tui_point): Remove.
 512         (struct tui_gen_win_info) <origin>: Remove.
 513         <x, y>: New fields.
 514         * tui/tui-command.c (tui_cmd_window::resize): Update.
 515
 516 2019-12-11  Tom Tromey  <tom@tromey.com>
 517
 518         * tui/tui-stack.h (struct tui_locator_window) <min_height>:
 519         Implement.
 520         * tui/tui-regs.h (struct tui_data_item_window) <min_height>:
 521         Implement.
 522         * tui/tui-data.h (struct tui_gen_win_info) <min_height>: New
 523         method.
 524         (struct tui_win_info) <min_height>: Implement.
 525
 526 2019-12-11  Tom Tromey  <tom@tromey.com>
 527
 528         * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
 529         (struct tui_win_info) <can_box>: Update.
 530
 531 2019-12-11  Tom Tromey  <tom@tromey.com>
 532
 533         * tui/tui-stack.h (struct tui_locator_window) <max_height>: New
 534         method.
 535         * tui/tui-regs.h (struct tui_data_item_window) <max_height>: New
 536         method.
 537         * tui/tui-data.h (struct tui_gen_win_info) <max_height>: New
 538         method.
 539         (struct tui_win_info) <max_height>: Now override.
 540
 541 2019-12-11  Joel Brobecker  <brobecker@adacore.com>
 542
 543         * NEWS: Create a new section for the next release branch.
 544         Rename the section of the current branch, now that it has
 545         been cut.
 546
 547 2019-12-11  Joel Brobecker  <brobecker@adacore.com>
 548
 549         GDB 9 branch created (27f7b2f64062ac9e52afc60509263c2702a9ebd0):
 550         * version.in: Bump version to 10.0.50.DATE-git.
 551
 552 2019-12-11  Tom Tromey  <tromey@adacore.com>
 553
 554         PR build/25268:
 555         * gdbsupport/thread-pool.c (set_thread_name): New function.
 556         (thread_pool::set_thread_count): Don't call pthread_setname_np.
 557         (thread_pool::thread_function): Call set_thread_name.
 558
 559 2019-12-11  Tom Tromey  <tromey@adacore.com>
 560
 561         * fbsd-tdep.c (fbsd_core_info_proc_status): Cast result of
 562         bfd_get_signed_8.
 563
 564 2019-12-11  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 565
 566         * NEWS: Document -raw-values option and the related setting commands.
 567         * printcmd.c (print_command_parse_format): Do not set opts->raw off,
 568         only set it on when /r is given.
 569         * valprint.c (value_print_option_defs): New element raw-values.
 570         * Makefile.in: Add the new file.
 571
 572 2019-12-10  Christian Biesinger  <cbiesinger@google.com>
 573
 574         * gdbsupport/safe-strerror.c: Supress the unused function warning
 575         for select_strerror_r.
 576
 577 2019-12-10  Christian Biesinger  <cbiesinger@google.com>
 578
 579         * config.in: Regenerate.
 580         * configure: Regenerate.
 581         * gdbsupport/agent.c (gdb_connect_sync_socket): Call
 582         safe_strerror instead of strerror.
 583         * gdbsupport/common.m4: Don't check for strerror.
 584         * gdbsupport/safe-strerror.c: Support both the glibc version
 585         of strerror_r and the XSI version.
 586
 587 2019-12-10  Tom Tromey  <tromey@adacore.com>
 588
 589         * ada-typeprint.c (print_choices): Use a single "?".
 590         (print_variant_part): Print "?" if the discriminant name
 591         is not known.
 592
 593 2019-12-10  George Barrett  <bob@bob131.so>
 594
 595         Fix scripted probe breakpoints.
 596         * breakpoint.c (tracepoint_probe_breakpoint_ops): Move
 597         declaration forward.
 598         (breakpoint_ops_for_event_location_type)
 599         (breakpoint_ops_for_event_location): Add function definitions.
 600         (break_command_1, trace_command): Use
 601         breakpoint_ops_for_event_location.
 602         * breakpoint.h (breakpoint_ops_for_event_location): Add function
 603         declarations.
 604         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Use
 605         breakpoint_ops_for_event_location.
 606         * python/py-breakpoint.c (bppy_init): Use
 607         breakpoint_ops_for_event_location.
 608
 609 2019-12-09  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 610
 611         * gdbtypes.c (rank_one_type): Return INCOMPATIBLE_TYPE_BADNESS
 612         when ranking an lvalue argument for an rvalue parameter.
 613
 614 2019-12-08  Wataru Ashihara  <wataash@wataash.com>
 615
 616         * darwin-nat.c (darwin_nat_target::create_inferior): Fix
 617         template argument for scoped_restore_tmpl from bool to int.
 618
 619 2019-12-07  Keith Seitz  <keiths@redhat.com>
 620
 621         * build-id.c (build_id_bfd_get): Permit bfd_core, too.
 622         (build_id_to_debug_bfd): Make static, rewriting to use
 623         build_id_to_bfd_suffix.
 624         (build_id_to_bfd_suffix): Copy of build_id_to_debug_bfd,
 625         adding `suffix' parameter. Append SUFFIX to file names
 626         when searching for matching files.
 627         (build_id_to_debug_bfd): Use build_id_to_bfd_suffix.
 628         (build_id_to_exec_bfd): Likewise.
 629         * build-id.h (build_id_to_debug_bfd): Clarify that function
 630         searches for BFD of debug info file.
 631         (build_id_to_exec_bfd): Declare.
 632         * corelow.c: Include build-id.h.
 633         (locate_exec_from_corefile_build_id): New function.
 634         (core_target_open): If no executable BFD is found,
 635         search for a core file BFD using build-id.
 636
 637 2019-12-06  Christian Biesinger  <cbiesinger@google.com>
 638
 639         * bcache.c: Put in namespace gdb.
 640         * bcache.h: Likewise.
 641         * gdbtypes.c (check_types_worklist): Update.
 642         (types_deeply_equal): Update.
 643         * macrotab.c (struct macro_table) <bcache>: Update.
 644         (new_macro_table): Update.
 645         * macrotab.h (struct bcache): Put this forward declaration
 646         inside namespace gdb.
 647         (new_macro_table): Update.
 648         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache>:
 649         Update.
 650         <macro_cache>: Update.
 651         * psymtab.h: (psymtab_storage) <psymbol_cache>: Update.
 652
 653 2019-12-06  Tom de Vries  <tdevries@suse.de>
 654
 655         PR symtab/24971
 656         * block.c (best_symbol, better_symbol): New function.
 657         (block_lookup_symbol_primary, block_lookup_symbol): Prefer def over
 658         decl.
 659
 660 2019-12-06  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 661
 662         * gdbtypes.h: Define the REFERENCE_SEE_THROUGH_BADNESS value.
 663         * gdbtypes.c (rank_one_type): Use REFERENCE_SEE_THROUGH_BADNESS
 664         for ranking see-through reference cases.
 665
 666 2019-12-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 667         * stack.c (faas_command): Check a command is provided.
 668         * thread.c (taas_command, tfaas_command): Likewise.
 669
 670 2019-12-05  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 671         * inferior.c (prune_inferiors):  Only call delete_inferior,
 672         Do not modify the inferior list.
 673
 674 2019-12-05  Simon Marchi  <simon.marchi@polymtl.ca>
 675
 676         * c-exp.y: Update calls to lookup_typename,
 677         lookup_signed_typename and lookup_unsigned_typename.
 678         * c-lang.c (evaluate_subexp_c): Likewise.
 679         * cp-namespace.c (cp_lookup_symbol_imports_or_template):
 680         Likewise.
 681         * eval.c (binop_promote): Likewise.
 682         * gdbtypes.c (lookup_typename): Remove gdbarch parameter.
 683         (lookup_unsigned_typename): Likewise.
 684         (lookup_signed_typename): Likewise.
 685         * gdbtypes.h (lookup_unsigned_typename): Likewise.
 686         (lookup_signed_typename): Likewise.
 687         (lookup_typename): Likewise.
 688         * guile/scm-type.c (tyscm_lookup_typename): Update calls to
 689         lookup_typename, lookup_signed_typename,
 690         lookup_unsigned_typename.
 691         * m2-exp.y: Likewise.
 692         * printcmd.c (printf_wide_c_string): Likewise.
 693         (ui_printf): Likewise.
 694         * python/py-type.c (typy_lookup_typename): Likewise.
 695         * python/py-xmethods.c (python_xmethod_worker::invoke):
 696         Likewise.
 697         * rust-exp.y: Likewise.
 698
 699 2019-12-04  Christian Biesinger  <cbiesinger@google.com>
 700
 701         * configure.nat (obsd64): Add missing files x86-nat.o and
 702         nat/x86-dregs.o.
 703
 704 2019-12-04  Tom Tromey  <tom@tromey.com>
 705
 706         * valprint.c (val_print_string): Use metadata_style.
 707         * go-valprint.c (print_go_string): Use metadata style.
 708         * p-valprint.c (pascal_object_print_static_field): Use metadata
 709         style.
 710         * cp-valprint.c (cp_print_static_field): Use metadata style.
 711
 712 2019-12-04  Andrew Burgess  <andrew.burgess@embecosm.com>
 713             Chris January  <chris.january@arm.com>
 714
 715         * f-exp.y (COMPLEX_KEYWORD, SINGLE, DOUBLE, PRECISION): New
 716         tokens.
 717         (typebase): New patterns for complex, single/double precision, and
 718         single/double complex.
 719         (f77_keywords): Change token for complex keyword, and add single,
 720         double, and precision keywords.
 721
 722 2019-12-04  Simon Marchi  <simon.marchi@polymtl.ca>
 723
 724         * avr-tdep.c (_initialize_avr_tdep): Improve help of command
 725         "info io_registers".
 726
 727 2019-12-04  Simon Marchi  <simon.marchi@polymtl.ca>
 728
 729         * regcache.c (cooked_read_test): Initialize thread list of
 730         mock_inferior.
 731
 732 2019-12-04  Simon Marchi  <simon.marchi@polymtl.ca>
 733
 734         * aarch64-linux-tdep.c: Remove includes.
 735
 736 2019-12-04  Simon Marchi  <simon.marchi@polymtl.ca>
 737
 738         * aarch64-tdep.c: Remove includes.
 739
 740 2019-12-04  Simon Marchi  <simon.marchi@efficios.com>
 741
 742         * filtered-iterator.h (filtered_iterator) <operator==,
 743         operator!=>: Compare wrapped iterators, not wrapped pointers.
 744         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
 745         unittests/filtered_iterator-selftests.c.
 746         * unittests/filtered_iterator-selftests.c: New file.
 747
 748 2019-12-04  Tom Tromey  <tromey@adacore.com>
 749
 750         * gdbtypes.c (create_range_type): Inherit endianity
 751         from base type.
 752
 753 2019-12-04  Tom Tromey  <tromey@adacore.com>
 754
 755         * ada-lang.c (decode_constrained_packed_array)
 756         (ada_value_assign, value_assign_to_component): Update.
 757         * dwarf2loc.c (rw_pieced_value, access_memory)
 758         (dwarf2_compile_expr_to_ax): Update.
 759         * dwarf2read.c (dwarf2_add_field): Update.
 760         * eval.c (evaluate_subexp_standard): Update.
 761         * gdbarch.c, gdbarch.h: Rebuild.
 762         * gdbarch.sh (bits_big_endian): Remove.
 763         * gdbtypes.h (union field_location): Update comment.
 764         * target-descriptions.c (make_gdb_type): Update.
 765         * valarith.c (value_bit_index): Update.
 766         * value.c (struct value) <bitpos>: Update comment.
 767         (unpack_bits_as_long, modify_field): Update.
 768         * value.h (value_bitpos): Update comment.
 769
 770 2019-12-04  Tom Tromey  <tromey@adacore.com>
 771
 772         * gdbtypes.c (type_byte_order): Move earlier.  Assert for unknown
 773         endian-ness.
 774
 775 2019-12-04  Tom Tromey  <tromey@adacore.com>
 776
 777         * dwarf2read.c (dwarf2_init_float_type)
 778         (dwarf2_init_complex_target_type): Add byte_order parameter.
 779         (read_base_type): Compute byte order earlier.
 780         * gdbtypes.c (init_float_type): Add byte_order parameter.
 781         * gdbtypes.h (init_float_type): Add byte_order parameter.
 782
 783 2019-12-04  Tom Tromey  <tromey@adacore.com>
 784
 785         * unittests/tui-selftests.c: Conditionally include tui-winsource.h.
 786
 787 2019-12-04  Tom Tromey  <tromey@adacore.com>
 788
 789         * dwarf2read.c (process_structure_scope): Initialize
 790         "discr_offset".
 791
 792 2019-12-04  Andrew Burgess  <andrew.burgess@embecosm.com>
 793
 794         * mi/mi-symbol-cmds.c (mi_symbol_info): Take extra parameter, and
 795         add it into the search spec.
 796         (parse_max_results_option): New function.
 797         (mi_info_functions_or_variables): Parse -max-results flag and pass
 798         it to mi_symbol_info.
 799         (mi_cmd_symbol_info_modules): Likewise.
 800         (mi_cmd_symbol_info_types): Likewise.
 801         * symtab.c (global_symbol_searcher::add_matching_symbols): Change
 802         return type to bool, change result container into a set, and don't
 803         add new results if we have enough already.
 804         (global_symbol_searcher::add_matching_msymbols): Change return
 805         type to bool, and don't add new results if we have enough already.
 806         (sort_search_symbols_remove_dups): Delete.
 807         (global_symbol_searcher::search): Early exit from search loop when
 808         we have enough results.  Use a std::set to collect the results
 809         from calling add_matching_symbols.
 810         * symtab.h (global_symbol_searcher) <set_max_seach_results>: New
 811         member function.
 812         (global_symbol_searcher) <m_max_search_results>: New member
 813         variable.
 814         (global_symbol_searcher) <add_matching_symbols>: Update header
 815         comment and change return type to bool.
 816         (global_symbol_searcher) <add_matching_msymbols>: Update header
 817         comment and change return type to bool.
 818
 819 2019-12-04  Andrew Burgess  <andrew.burgess@embecosm.com>
 820
 821         * symtab.c (symbol_search::compare_search_syms): Update header
 822         comment.
 823         (global_symbol_searcher::is_suitable_msymbol): New function.
 824         (global_symbol_searcher::expand_symtabs): New function.
 825         (global_symbol_searcher::add_matching_symbols): New function.
 826         (global_symbol_searcher::add_matching_msymbols): New function.
 827         (global_symbol_searcher::search): Move most of the content
 828         into the new functions above, and call them as needed.
 829         * symtab.h (global_symbol_searcher) <expand_symtabs>: New member
 830         function.
 831         (global_symbol_searcher) <add_matching_symbols>: New member
 832         function.
 833         (global_symbol_searcher) <add_matching_msymbols>: New member
 834         function.
 835         (global_symbol_searcher) <is_suitable_msymbol>: New member
 836         function.
 837
 838 2019-12-04  Andrew Burgess  <andrew.burgess@embecosm.com>
 839
 840         * mi/mi-cmds.c (mi_cmds): Add -symbol-info-module-functions and
 841         -symbol-info-module-variables entries.
 842         * mi/mi-cmds.h (mi_cmd_symbol_info_module_functions): Declare.
 843         (mi_cmd_symbol_info_module_variables): Declare.
 844         * mi/mi-symbol-cmds.c
 845         (module_symbol_search_iterator): New typedef.
 846         (output_module_symbols_in_single_module_and_file): New function.
 847         (output_module_symbols_in_single_module): New function.
 848         (mi_info_module_functions_or_variables): New function.
 849         (mi_cmd_symbol_info_module_functions): New function.
 850         (mi_cmd_symbol_info_module_variables): New function.
 851         * NEWS: Mention new MI command.
 852
 853 2019-12-03  Christian Biesinger  <cbiesinger@google.com>
 854
 855         * bcache.c (hash): Remove.
 856         (hash_continue): Remove.
 857         * bcache.h (hash): Remove.
 858         (hash_continue): Remove.
 859         (struct bcache) <ctor>: Update.
 860         * psymtab.c (psymbol_hash): Update.
 861         * stabsread.c (hashname): Update.
 862         * utils.h (fast_hash): Add an argument for a start value,
 863         defaulting to zero.
 864
 865 2019-12-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 866         * symtab.c (symbol_cache_clear_slot):  Move close to cleared type.
 867         (destroy_block_symbol_cache): New function.
 868         (symbol_cache:~symbol_cache) Call destroy_block_symbol_cache.
 869         (resize_symbol_cache): Likewise.
 870
 871 2019-12-02  Tom Tromey  <tom@tromey.com>
 872
 873         * unittests/tui-selftests.c (run_tests): Make conditional.
 874         (_initialize_tui_selftest): Make conditional.
 875
 876 2019-12-02  Christian Biesinger  <cbiesinger@google.com>
 877
 878         * aix-thread.c (debug_aix_thread): Change type to bool.
 879
 880 2019-12-02  Luis Machado  <luis.machado@linaro.org>
 881
 882         * infrun.c (follow_fork_inferior): Remove outdated FIXME comment.
 883
 884 2019-12-01  Andrew Burgess  <andrew.burgess@embecosm.com>
 885
 886         * dwarf2read.c (read_tag_string_type): Read the fields required to
 887         make a dynamic string, and possibly create a dynamic range for the
 888         string.
 889         (attr_to_dynamic_prop): Setup is_reference based on the type of
 890         attribute being processed.
 891         * gdbtypes.c (is_dynamic_type_internal): Handle TYPE_CODE_STRING.
 892         (resolve_dynamic_array): Rename to...
 893         (resolve_dynamic_array_or_string): ...this, update header comment,
 894         and accept TYPE_CODE_STRING.
 895         (resolve_dynamic_type_internal): Handle TYPE_CODE_STRING.
 896
 897 2019-12-01  Andrew Burgess  <andrew.burgess@embecosm.com>
 898
 899         * dwarf2read.c (dwarf2_per_cu_int_type): New function, takes most
 900         of its implementation from...
 901         (dwarf2_per_cu_addr_sized_int_type): ...here, which now just calls
 902         the new function.
 903
 904 2019-12-01  Andrew Burgess  <andrew.burgess@embecosm.com>
 905
 906         * dwarf2read.c (read_subrange_type): Read bit and byte stride and
 907         create a range with stride where appropriate.
 908         * f-valprint.c: Include 'gdbarch.h'.
 909         (f77_print_array_1): Take the stride into account when walking the
 910         array.  Also convert the stride into addressable units.
 911         * gdbtypes.c (create_range_type): Initialise the stride to
 912         constant zero.
 913         (create_range_type_with_stride): New function, initialise the
 914         range as normal, and then setup the stride.
 915         (has_static_range): Include the stride here.  Also change the
 916         return type to bool.
 917         (create_array_type_with_stride): Consider the range stride if the
 918         array isn't given its own stride.
 919         (resolve_dynamic_range): Resolve the stride if needed.
 920         * gdbtypes.h (struct range_bounds) <stride>: New member variable.
 921         (struct range_bounds) <flag_is_byte_stride>: New member variable.
 922         (TYPE_BIT_STRIDE): Define.
 923         (TYPE_ARRAY_BIT_STRIDE): Define.
 924         (create_range_type_with_stride): Declare.
 925         * valarith.c (value_subscripted_rvalue): Take range stride into
 926         account when walking the array.
 927
 928 2019-12-01  Tom Tromey  <tom@tromey.com>
 929
 930         * tui/tui-win.c (tui_all_windows_info): Treat inactive TUI
 931         specially.
 932
 933 2019-12-01  Tom Tromey  <tom@tromey.com>
 934
 935         * tui/tui-winsource.c (tui_copy_source_line): Don't advance past
 936         \0.
 937         * unittests/tui-selftests.c: New file.
 938         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add tui-selftests.c.
 939
 940 2019-12-01  Tom Tromey  <tom@tromey.com>
 941
 942         * tui/tui.c (tui_enable): Call tui_update_variables earlier.
 943
 944 2019-12-01  Tom Tromey  <tom@tromey.com>
 945
 946         * NEWS: Document new settings.
 947         * tui/tui-wingeneral.c (box_win): Apply appropriate border style.
 948         * tui/tui-win.c (_initialize_tui_win): Add border style
 949         observers.
 950         * tui/tui-io.h (tui_apply_style): Declare.
 951         * tui/tui-io.c (tui_apply_style): Rename from apply_style.  No
 952         longer static.
 953         (apply_ansi_escape, tui_set_reverse_mode): Update.
 954         * cli/cli-style.h (class cli_style_option) <add_setshow_commands>:
 955         Add "skip_intensity" parameter.
 956         <changed>: New member.
 957         <do_set_value>: Declare.
 958         (tui_border_style, tui_active_border_style): Declare.
 959         * cli/cli-style.c (tui_border_style, tui_active_border_style): New
 960         globals.
 961         (cli_style_option): Initialize "changed".
 962         (cli_style_option::do_set_value): New function.
 963         (cli_style_option::add_setshow_commands): Add "skip_intensity"
 964         parameter.  Update.
 965         (STYLE_ADD_SETSHOW_COMMANDS): Add "SKIP" parameter.
 966         (_initialize_cli_style): Update.  Create TUI border style
 967         commands.
 968
 969 2019-12-01  Tom Tromey  <tom@tromey.com>
 970
 971         * tui/tui-winsource.h (tui_copy_source_line): Add "ndigits"
 972         parameter.
 973         * tui/tui-winsource.c (tui_copy_source_line): Add "ndigits"
 974         parameter.
 975         * tui/tui-win.h (compact_source): Declare.
 976         * tui/tui-win.c (compact_source): New global.
 977         (tui_set_compact_source, tui_show_compact_source): New functions.
 978         (_initialize_tui_win): Add "compact-source" setting.
 979         * tui/tui-source.c (tui_source_window::set_contents): Handle
 980         compact_source setting.
 981         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
 982         * NEWS: Document new setting.
 983
 984 2019-11-30  Tom Tromey  <tom@tromey.com>
 985
 986         * dwarf2read.c (dwarf2_add_field): Include field offset when
 987         computing variant part length.
 988
 989 2019-11-30  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 990         * NEWS:  Mention define-prefix.  Tell that command names can now
 991         contain a . character.
 992
 993 2019-11-30  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 994
 995         * command.h (valid_cmd_char_p): Declare.
 996         * cli/cli-decode.c (valid_cmd_char_p): New function factorizing
 997         the check of valid command char.
 998         (find_command_name_length, valid_user_defined_cmd_name_p): Use
 999         valid_cmd_char_p.
1000         * cli/cli-script.c (validate_comname): Likewise.
1001         * completer.c (gdb_completer_command_word_break_characters):
1002         Do not remove . from the word break char, update comments.
1003         (complete_line_internal_1): Use valid_cmd_char_p.
1004         * guile/scm-cmd.c (gdbscm_parse_command_name): Likewise.
1005         * python/py-cmd.c (gdbpy_parse_command_name): Likewise.
1006
1007 2019-11-30  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1008
1009         * cli/cli-script.c (do_define_command): Ensure a redefined
1010         prefix command is kept as a prefix command.
1011         (define_prefix_command): New function.
1012         (show_user_1): Report user defined prefixes.
1013         (_initialize_cli_script):  Create the new 'define-prefix' command.
1014         Add completers for 'define' and 'document'.
1015         * top.c (execute_command):  If command is a user-defined prefix only
1016         command, report the list of commands for this prefix command.
1017
1018 2019-11-29  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
1019
1020         * valops.c (find_oload_champ): Improve debug output.
1021
1022 2019-11-29  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
1023
1024         * valops.c (find_oload_champ): Print part of debug messages
1025         before the badness vector is std::move'd.
1026
1027 2019-11-28  Tom Tromey  <tom@tromey.com>
1028
1029         * value.c (creal_internal_fn): Fix comment.
1030
1031 2019-11-28  Tom Tromey  <tom@tromey.com>
1032
1033         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count,
1034         flag_bound_evaluated>: Now unsigned.
1035
1036 2019-11-28  Tom Tromey  <tom@tromey.com>
1037
1038         * guile/guile-internal.h (vlscm_scm_from_value_unsafe): Don't
1039         declare.
1040
1041 2019-11-28  Mihails Strasuns  <mihails.strasuns@intel.com>
1042
1043         * jit.c (jit_bfd_try_read_symtab): Fix printed function name in the
1044         debug output.
1045         * jit.c (jit_unregister_code): Add debug print to match
1046         `jit_register_code`.
1047
1048 2019-11-27  Christian Biesinger  <cbiesinger@google.com>
1049
1050         * NEWS: Mention the new multithreaded symbol loading.
1051
1052 2019-11-27  Christian Biesinger  <cbiesinger@google.com>
1053
1054         * maint.c (n_worker_threads): Default to 0.
1055         (worker_threads_disabled): New function.
1056         * maint.h (worker_threads_disabled): New function.
1057         * minsyms.c (minimal_symbol_reader::record_full): Call symbol_set_names
1058         here if worker_threads_disabled () is true.
1059         (minimal_symbol_reader::install): Skip all threading if
1060         worker_threads_disabled () is true.
1061
1062 2019-11-27  Christian Biesinger  <cbiesinger@google.com>
1063
1064         * minsyms.c (add_minsym_to_hash_table): Use a previously computed
1065         hash code if possible.
1066         (add_minsym_to_demangled_hash_table): Likewise.
1067         (minimal_symbol_reader::install): Compute the hash codes for msymbol
1068         on the background thread.
1069         * symtab.h (struct minimal_symbol) <hash_value, demangled_hash_value>:
1070         Add these fields.
1071
1072 2019-11-27  Christian Biesinger  <cbiesinger@google.com>
1073
1074         * minsyms.c (minimal_symbol_reader::install): Also compute the hash
1075         of the mangled name on the background thread.
1076         * symtab.c (symbol_set_names): Allow passing in the hash of the
1077         linkage_name.
1078         * symtab.h (symbol_set_names): Likewise.
1079
1080 2019-11-27  Kevin Buettner  <kevinb@redhat.com>
1081
1082         * dwarf2read.c (inherit_abstract_dies): Ensure that delayed
1083         physnames are computed for inherited DIEs.
1084
1085 2019-11-27  Tom Tromey  <tromey@adacore.com>
1086
1087         * dwarf2read.h (struct dwarf2_per_objfile): Remove unnecessary
1088         backslashes.
1089         * cp-support.c: Remove unnecessary backslashes.
1090
1091 2019-11-27  Christian Biesinger  <cbiesinger@google.com>
1092
1093         * ada-exp.y (write_ambiguous_var): Replace SYMBOL_SET_LINKAGE_NAME
1094         with sym->set_linkage_name.
1095         * coffread.c (coff_read_enum_type): Likewise.
1096         * mdebugread.c (parse_symbol): Likewise.
1097         * stabsread.c (patch_block_stabs): Likewise.
1098         (define_symbol): Likewise.
1099         (read_enum_type): Likewise.
1100         (common_block_end): Likewise.
1101         * symtab.h (struct general_symbol_info) <set_linkage_name>: New
1102         function.
1103         (SYMBOL_SET_LINKAGE_NAME): Remove.
1104         * xcoffread.c (process_xcoff_symbol): Replace SYMBOL_SET_LINKAGE_NAME
1105         with sym->set_linkage_name.
1106
1107 2019-11-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1108
1109         * mi/mi-cmds.c (mi_cmds): Add 'symbol-info-modules' entry.
1110         * mi/mi-cmds.h (mi_cmd_symbol_info_modules): Declare.
1111         * mi/mi-symbol-cmds.c (mi_cmd_symbol_info_modules): New function.
1112         * NEWS: Mention new MI command.
1113
1114 2019-11-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1115
1116         * mi/mi-cmds.c (mi_cmds): Add '-symbol-info-functions',
1117         '-symbol-info-types', and '-symbol-info-variables'.
1118         * mi/mi-cmds.h (mi_cmd_symbol_info_functions): Declare.
1119         (mi_cmd_symbol_info_types): Declare.
1120         (mi_cmd_symbol_info_variables): Declare.
1121         * mi/mi-symbol-cmds.c: Add 'source.h' and 'mi-getopt.h' includes.
1122         (output_debug_symbol): New function.
1123         (output_nondebug_symbol): New function.
1124         (mi_symbol_info): New function.
1125         (mi_info_functions_or_variables): New function.
1126         (mi_cmd_symbol_info_functions): New function.
1127         (mi_cmd_symbol_info_types): New function.
1128         (mi_cmd_symbol_info_variables): New function.
1129         * NEWS: Mention new commands.
1130
1131 2019-11-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1132
1133         * symtab.c (symbol_to_info_string): New function, most content
1134         moved from print_symbol_info, but updated to return a std::string.
1135         (print_symbol_info): Update to use symbol_to_info_string and print
1136         returned string.
1137         * symtab.h (symbol_to_info_string): Declare new function.
1138
1139 2019-11-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1140
1141         * python/python.c (gdbpy_rbreak): Convert to using
1142         global_symbol_searcher.
1143         * symtab.c (file_matches): Convert return type to bool, change
1144         file list to std::vector, update header comment.
1145         (search_symbols): Rename to...
1146         (global_symbol_searcher::search): ...this and update now its
1147         a member function of global_symbol_searcher.  Take account of the
1148         changes to file_matches.
1149         (symtab_symbol_info): Convert to using global_symbol_searcher.
1150         (rbreak_command): Likewise.
1151         (search_module_symbols): Likewise.
1152         * symtab.h (enum symbol_search): Update comment.
1153         (search_symbols): Remove declaration.
1154         (class global_symbol_searcher): New class.
1155
1156 2019-11-26  Tom Tromey  <tromey@adacore.com>
1157
1158         * cp-support.c (_initialize_cp_support): Conditionally initialize
1159         gdb_demangle_attempt_core_dump.
1160
1161 2019-11-26  Tom Tromey  <tom@tromey.com>
1162
1163         * python/py-function.c (fnpy_init): Update.
1164         * value.h (add_internal_function): Adjust declaration.
1165         * value.c (function_destroyer): Remove.
1166         (do_add_internal_function): Don't set destroyer or copy name.
1167         (add_internal_function): Take unique_xmalloc_ptr<char> for name.
1168         Set name_allocated.
1169         * python/py-cmd.c (cmdpy_destroyer): Don't free "name".
1170         (cmdpy_init): Set name_allocated.
1171         * cli/cli-decode.h (struct cmd_list_element) <name_allocated>: New
1172         member.
1173         (~cmd_list_element): Free "name" if needed.
1174
1175 2019-11-26  Tom Tromey  <tom@tromey.com>
1176
1177         * value.h (add_internal_function): Add new overload.  Move
1178         documentation from value.h.
1179         * value.c (do_add_internal_function): New function.
1180         (add_internal_function): Use it.  Add new overload.
1181         (function_destroyer): Don't free doc.
1182         * python/py-function.c (fnpy_init): Update.
1183
1184 2019-11-26  Tom Tromey  <tom@tromey.com>
1185
1186         * python/py-cmd.c (cmdpy_destroyer): Don't free "doc".
1187         (cmdpy_init): Set "doc_allocated".
1188
1189 2019-11-26  Tom Tromey  <tom@tromey.com>
1190
1191         * gdbsupport/thread-pool.c (thread_pool::set_thread_count): Set
1192         name of worker thread.
1193         * gdbsupport/common.m4 (GDB_AC_COMMON): Check for
1194         pthread_setname_np.
1195         * configure, config.in: Rebuild.
1196
1197 2019-11-26  Tom Tromey  <tom@tromey.com>
1198
1199         * python/python.c (class gdbpy_gil): New.
1200         (struct gdbpy_event): Add constructor, destructor, operator().
1201         (gdbpy_post_event): Use run_on_main_thread.
1202         (gdbpy_initialize_events): Remove.
1203         (do_start_initialization): Update.
1204
1205 2019-11-26  Tom Tromey  <tom@tromey.com>
1206
1207         * NEWS: Add entry.
1208         * maint.c (_initialize_maint_cmds): Add "worker-threads" maint
1209         commands.  Call update_thread_pool_size.
1210         (update_thread_pool_size, maintenance_set_worker_threads): New
1211         functions.
1212         (n_worker_threads): New global.
1213
1214 2019-11-26  Christian Biesinger  <cbiesinger@google.com>
1215             Tom Tromey  <tom@tromey.com>
1216
1217         * minsyms.c (minimal_symbol_reader::install): Use
1218         parallel_for_each.
1219         * gdbsupport/parallel-for.h: New file.
1220         * Makefile.in (HFILES_NO_SRCDIR): Add gdbsupport/parallel-for.h.
1221
1222 2019-11-26  Christian Biesinger  <cbiesinger@google.com>
1223             Tom Tromey  <tom@tromey.com>
1224
1225         * gdbsupport/thread-pool.h: New file.
1226         * gdbsupport/thread-pool.c: New file.
1227         * Makefile.in (COMMON_SFILES): Add thread-pool.c.
1228         (HFILES_NO_SRCDIR): Add thread-pool.h.
1229
1230 2019-11-26  Tom Tromey  <tom@tromey.com>
1231
1232         * event-top.h (thread_local_segv_handler): Declare.
1233         * event-top.c (thread_local_segv_handler): New global.
1234         (install_handle_sigsegv, handle_sigsegv): New functions.
1235         (async_init_signals): Install SIGSEGV handler.
1236         * cp-support.c (gdb_demangle_jmp_buf): Change type.  Now
1237         thread-local.
1238         (report_failed_demangle): New function.
1239         (gdb_demangle): Make core_dump_allowed atomic.  Remove signal
1240         handler-setting code, instead use segv_handler.  Run warning code
1241         on main thread.
1242
1243 2019-11-26  Tom Tromey  <tom@tromey.com>
1244
1245         * run-on-main-thread.c: New file.
1246         * run-on-main-thread.h: New file.
1247         * unittests/main-thread-selftests.c: New file.
1248         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
1249         main-thread-selftests.c.
1250         (HFILES_NO_SRCDIR): Add run-on-main-thread.h.
1251         (COMMON_SFILES): Add run-on-main-thread.c.
1252
1253 2019-11-26  Tom Tromey  <tom@tromey.com>
1254
1255         * main.c (setup_alternate_signal_stack): Remove.
1256         (captured_main_1): Use gdb::alternate_signal_stack.
1257         * gdbsupport/alt-stack.h: New file.
1258
1259 2019-11-26  Tom Tromey  <tom@tromey.com>
1260
1261         * gdbsupport/signals-state-save-restore.c (original_signal_mask):
1262         Remove comment.
1263         (save_original_signals_state, restore_original_signals_state): Use
1264         gdb_sigmask.
1265         * linux-nat.c (block_child_signals, restore_child_signals_mask)
1266         (_initialize_linux_nat): Use gdb_sigmask.
1267         * guile/guile.c (_initialize_guile): Use block_signals.
1268         * Makefile.in (HFILES_NO_SRCDIR): Add gdb-sigmask.h.
1269         * gdbsupport/gdb-sigmask.h: New file.
1270         * event-top.c (async_sigtstp_handler): Use gdb_sigmask.
1271         * cp-support.c (gdb_demangle): Use gdb_sigmask.
1272         * gdbsupport/common.m4 (GDB_AC_COMMON): Check for
1273         pthread_sigmask.
1274         * configure, config.in: Rebuild.
1275         * gdbsupport/block-signals.h: New file.
1276
1277 2019-11-26  Tom Tromey  <tom@tromey.com>
1278
1279         * acinclude.m4: Include ax_pthread.m4.
1280         * Makefile.in (PTHREAD_CFLAGS, PTHREAD_LIBS): New variables.
1281         (INTERNAL_CFLAGS_BASE): Use PTHREAD_CFLAGS.
1282         (CLIBS): Use PTHREAD_LIBS.
1283         (aclocal_m4_deps): Add ax_pthread.m4.
1284         * config.in, configure: Rebuild.
1285         * gdbsupport/common.m4 (GDB_AC_COMMON): Check for std::thread.
1286
1287 2019-11-26  Tom Tromey  <tom@tromey.com>
1288
1289         * symtab.h (struct minimal_symbol) <name_set>: New member.
1290         * minsyms.c (minimal_symbol_reader::record_full): Copy name.
1291         Don't call symbol_set_names.
1292         (minimal_symbol_reader::install): Call symbol_set_names.
1293
1294 2019-11-26  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1295
1296         * python/python.c (gdbpy_enter::~gdbpy_enter): Release GIL after
1297         restore_active_ext_lang, as GIL is needed for (indirectly)
1298         called PyOS_InterruptOccurred.
1299
1300 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1301
1302         * sparc-nat.c (sparc_xfer_wcookie): Sync declaration with
1303         definition.
1304
1305 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1306
1307         * remote-sim.c (simulator_command): Make static, remove
1308         declaration.
1309
1310 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1311
1312         * unittests/array-view-selftests.c (check_ptr_size_ctor2): Make
1313         static.
1314         * unittests/basic_string_view/capacity/1.cc (test01): Likewise.
1315         * unittests/basic_string_view/cons/char/1.cc (test01): Likewise.
1316         (main): Likewise.
1317         * unittests/basic_string_view/cons/char/2.cc (test03): Likewise.
1318         (main): Likewise.
1319         * unittests/basic_string_view/cons/char/3.cc (test05): Likewise.
1320         (main): Likewise.
1321         * unittests/basic_string_view/element_access/char/1.cc (test01):
1322         Likewise.
1323         (main): Likewise.
1324         * unittests/basic_string_view/element_access/char/empty.cc (main):
1325         Likewise.
1326         * unittests/basic_string_view/element_access/char/front_back.cc
1327         (test01): Likewise.
1328         (main): Likewise.
1329         * unittests/basic_string_view/inserters/char/2.cc (test05):
1330         Likewise.
1331         (main): Likewise.
1332         * unittests/basic_string_view/modifiers/remove_prefix/char/1.cc
1333         (test01): Likewise.
1334         (main): Likewise.
1335         * unittests/basic_string_view/modifiers/remove_suffix/char/1.cc
1336         (test01): Likewise.
1337         (main): Likewise.
1338         * unittests/basic_string_view/modifiers/swap/char/1.cc (test01):
1339         Likewise.
1340         * unittests/basic_string_view/operations/compare/char/1.cc
1341         (test01): Likewise.
1342         (main): Likewise.
1343         * unittests/basic_string_view/operations/compare/char/13650.cc
1344         (test01): Likewise.
1345         * unittests/basic_string_view/operations/copy/char/1.cc (test01):
1346         Likewise.
1347         (main): Likewise.
1348         * unittests/basic_string_view/operations/data/char/1.cc (test01):
1349         Likewise.
1350         (main): Likewise.
1351         * unittests/basic_string_view/operations/find/char/1.cc (test01):
1352         Likewise.
1353         (main): Likewise.
1354         * unittests/basic_string_view/operations/find/char/2.cc (test02):
1355         Likewise.
1356         (main): Likewise.
1357         * unittests/basic_string_view/operations/find/char/3.cc (test03):
1358         Likewise.
1359         (main): Likewise.
1360         * unittests/basic_string_view/operations/find/char/4.cc (main):
1361         Likewise.
1362         * unittests/basic_string_view/operations/rfind/char/1.cc (test01):
1363         Likewise.
1364         (main): Likewise.
1365         * unittests/basic_string_view/operations/rfind/char/2.cc (test02):
1366         Likewise.
1367         (main): Likewise.
1368         * unittests/basic_string_view/operations/rfind/char/3.cc (test03):
1369         Likewise.
1370         (main): Likewise.
1371         * unittests/basic_string_view/operations/substr/char/1.cc
1372         (test01): Likewise.
1373         (main): Likewise.
1374         * unittests/basic_string_view/operators/char/2.cc (main):
1375         Likewise.
1376         * unittests/optional/assignment/1.cc (test): Likewise.
1377         * unittests/optional/assignment/2.cc (test): Likewise.
1378         * unittests/optional/assignment/3.cc (test): Likewise.
1379         * unittests/optional/assignment/4.cc (test): Likewise.
1380         * unittests/optional/assignment/5.cc (test): Likewise.
1381         * unittests/optional/assignment/6.cc (test): Likewise.
1382         * unittests/optional/assignment/7.cc (test): Likewise.
1383         * unittests/optional/cons/copy.cc (test): Likewise.
1384         * unittests/optional/cons/default.cc (test): Likewise.
1385         * unittests/optional/cons/move.cc (test): Likewise.
1386         * unittests/optional/cons/value.cc (test): Likewise.
1387         * unittests/optional/in_place.cc (test): Likewise.
1388         * unittests/optional/observers/1.cc (test): Likewise.
1389         * unittests/optional/observers/2.cc (test): Likewise.
1390
1391 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1392
1393         * tui-win.h (tui_set_var_cmd): Remove.
1394         * tui-win.c (tui_set_var_cmd): Make static.
1395
1396 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1397
1398         * breakpoint.h (hbreak_command_wrapper, thbreak_command_wrapper,
1399         rbreak_command_wrapper): Remove.
1400         * symtab.c (rbreak_command_wrapper): Remove.
1401
1402 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1403
1404         * inferior.h (info_terminal_command): Remove declaration.
1405         * inflow.c (info_terminal_command): Make static.
1406
1407 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1408
1409         * inferior.c (exit_inferior_silent): Remove.
1410
1411 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1412
1413         * dictionary.c (dict_empty, mdict_empty): Remove.
1414         * dictionary.c (mdict_empty): Remove.
1415
1416 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1417
1418          * arc-tdep.c (arc_insn_get_memory_base_reg): Make static.
1419          (arc_insn_get_memory_offset): Likewise.
1420          (arc_insn_dump): Likewise.
1421          * cp-support.c (test_cp_symbol_name_matches): Likewise.
1422          * csky-linux-tdep.c (csky_supply_fregset): Likewise.
1423          * dictionary.c (dict_iterator_next): Likewise.
1424          (dict_iter_match_first): Likewise.
1425          (dict_iter_match_next): Likewise.
1426          * f-lang.c (evaluate_subexp_f): Likewise.
1427          * hppa-tdep.c (hppa_read_pc): Likewise.
1428          * i386-tdep.c (i386_floatformat_for_type): Likewise.
1429          * parse.c (write_exp_elt_msym): Likewise.
1430          * ppc-linux-tdep.c (ppc_floatformat_for_type): Likewise.
1431          * remote.c (remote_packet_size): Likewise.
1432          (remote_notif_stop_parse): Likewise.
1433          * rs6000-aix-tdep.c (aix_sighandle_frame_sniffer): Likewise.
1434          * s12z-tdep.c (s12z_disassemble_info): Likewise.
1435          * source.c (prepare_path_for_appending): Likewise.
1436          * sparc64-linux-tdep.c
1437          (sparc64_linux_handle_segmentation_fault); Likewise.
1438          * stack.c (frame_selection_by_function_completer): Likewise.
1439
1440 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1441
1442         * completer.c (set_gdb_completion_word_break_characters):
1443         Remove.
1444
1445 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1446
1447         * dwarf-index-write.c: Include dwarf-index-write.h.
1448         * mi/mi-interp.c: Include mi/mi-interp.h.
1449
1450 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1451
1452         * aarch32-tdep.c: Include aarch32-tdep.h.
1453         * aarch32-tdep.h: Forward-declare struct target_desc.
1454
1455 2019-11-26  Christian Biesinger  <cbiesinger@google.com>
1456
1457         * linux-nat.c (detach_one_lwp): Call safe_strerror instead of
1458         strerror.
1459         * nto-procfs.c (nto_procfs_target::create_inferior): Likewise.
1460         * windows-nat.c (windows_nat_target::create_inferior): Likewise.
1461
1462 2019-11-25  Tom de Vries  <tdevries@suse.de>
1463
1464         * contrib/words.sh: Add -c option.
1465
1466 2019-11-25  Christian Biesinger  <cbiesinger@google.com>
1467
1468         * solib.c (solib_find_1): Change int to bool.
1469         (exec_file_find): Change int to bool.
1470         (solib_find): Change int to bool.
1471         (solib_read_symbols): Change int to bool.
1472         (solib_used): Change int to bool.
1473         (solib_add): Change int to bool.
1474         (info_sharedlibrary_command): Change int to bool.
1475         (solib_contains_address_p): Change int to bool.
1476         (solib_keep_data_in_core): Change int to bool.
1477         (in_solib_dynsym_resolve_code): Change int to bool.
1478         (reload_shared_libraries_1): Change int to bool.
1479         (gdb_sysroot_changed): Change int to bool.
1480         * solib.h (solib_read_symbols): Change int to bool.
1481         (solib_contains_address_p): Change int to bool.
1482         (solib_keep_data_in_core): Change int to bool.
1483         (in_solib_dynsym_resolve_code): Change int to bool.
1484         (libpthread_name_p): Change int to bool.
1485
1486 2019-11-25  Luis Machado  <luis.machado@linaro.org>
1487
1488         * NEWS (New Commands): Mention "set debug remote-packet-max-chars".
1489         * remote.c (REMOTE_DEBUG_MAX_CHAR): Remove.
1490         (remote_packet_max_chars): New static global.
1491         (show_remote_packet_max_chars): New function.
1492         (remote_target::putpkt_binary): Adjust to use new
1493         remote_packet_max_chars option.
1494         (remote_target::getpkt_or_notif_sane_1): Likewise.
1495         (_initialize_remote): Register new remote-packet-max-chars option.
1496
1497 2019-11-24  Simon Marchi  <simon.marchi@efficios.com>
1498
1499         * m68k-linux-nat.c: Include gdbarch.h.
1500
1501 2019-11-24  Tom Tromey  <tom@tromey.com>
1502
1503         * symfile.c (read_symbols): Update.
1504         * psymtab.c (require_partial_symbols): Change type of "verbose" to
1505         bool.
1506         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
1507         (psym_lookup_symbol, psym_find_last_source_symtab)
1508         (psym_forget_cached_source_info, psym_print_stats)
1509         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
1510         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
1511         (psym_map_matching_symbols, psym_expand_symtabs_matching)
1512         (psym_find_compunit_symtab_by_address)
1513         (maintenance_print_psymbols, maintenance_info_psymtabs)
1514         (maintenance_check_psymtabs): Update.
1515         * psymtab.h (require_partial_symbols): Change type of "verbose" to
1516         bool.
1517
1518 2019-11-22  Tom Tromey  <tom@tromey.com>
1519
1520         * observable.h: Update comments.
1521
1522 2019-11-22  Tom Tromey  <tromey@adacore.com>
1523
1524         * ada-tasks.c (ada_task_is_alive): Make parameter const.
1525         (print_ada_task_info): Don't try to fetch thread id if task is not
1526         alive.
1527
1528 2019-11-22  Christian Biesinger  <cbiesinger@google.com>
1529
1530         * ada-exp.y: Update.
1531         * ada-lang.c (sort_choices): Update.
1532         (ada_print_symbol_signature): Update.
1533         (resolve_subexp): Update.
1534         (ada_parse_renaming): Update.
1535         (ada_read_renaming_var_value): Update.
1536         (lesseq_defined_than): Update.
1537         (remove_extra_symbols): Update.
1538         (remove_irrelevant_renamings): Update.
1539         (ada_add_block_symbols): Update.
1540         (ada_collect_symbol_completion_matches): Update.
1541         (ada_is_renaming_symbol): Update.
1542         (aggregate_assign_from_choices): Update.
1543         (ada_evaluate_subexp): Update.
1544         (ada_has_this_exception_support): Update.
1545         (ada_is_non_standard_exception_sym): Update.
1546         (ada_add_exceptions_from_frame): Update.
1547         (ada_add_global_exceptions): Update.
1548         (ada_print_subexp): Update.
1549         * ax-gdb.c (gen_var_ref): Update.
1550         (gen_maybe_namespace_elt): Update.
1551         (gen_expr_for_cast): Update.
1552         (gen_expr): Update.
1553         * block.h: Update.
1554         * blockframe.c (find_pc_partial_function): Update.
1555         * breakpoint.c (print_breakpoint_location): Update.
1556         (update_static_tracepoint): Update.
1557         * btrace.c (ftrace_print_function_name): Update.
1558         (ftrace_function_switched): Update.
1559         * buildsym.c (find_symbol_in_list): Update.
1560         * c-exp.y: Update.
1561         * c-typeprint.c (c_print_typedef): Update.
1562         (c_type_print_template_args): Update.
1563         * cli/cli-cmds.c (edit_command): Update.
1564         (list_command): Update.
1565         (print_sal_location): Update.
1566         * coffread.c (patch_opaque_types): Update.
1567         (process_coff_symbol): Update.
1568         (coff_read_enum_type): Update.
1569         * compile/compile-c-symbols.c (c_symbol_substitution_name): Update.
1570         (convert_one_symbol): Update.
1571         (hash_symname): Update.
1572         (eq_symname): Update.
1573         * compile/compile-cplus-symbols.c (convert_one_symbol): Update.
1574         * compile/compile-cplus-types.c (debug_print_scope): Update.
1575         * compile/compile-loc2c.c (do_compile_dwarf_expr_to_c): Update.
1576         * compile/compile-object-load.c (get_out_value_type): Update.
1577         * cp-namespace.c (cp_scan_for_anonymous_namespaces): Update.
1578         (search_symbol_list): Update.
1579         (cp_lookup_symbol_imports_or_template): Update.
1580         * cp-support.c (overload_list_add_symbol): Update.
1581         * ctfread.c (psymtab_to_symtab): Update.
1582         * dbxread.c (cp_set_block_scope): Update.
1583         * dictionary.c (iter_match_first_hashed): Update.
1584         (iter_match_next_hashed): Update.
1585         (insert_symbol_hashed): Update.
1586         (iter_match_next_linear): Update.
1587         * dictionary.h: Update.
1588         * dwarf2loc.c (func_get_frame_base_dwarf_block): Update.
1589         (locexpr_describe_location_piece): Update.
1590         (locexpr_describe_location_1): Update.
1591         (locexpr_generate_c_location): Update.
1592         (loclist_describe_location): Update.
1593         (loclist_generate_c_location): Update.
1594         * dwarf2read.c (dw2_debug_names_lookup_symbol): Update.
1595         (read_func_scope): Update.
1596         (process_enumeration_scope): Update.
1597         (new_symbol): Update.
1598         (dwarf2_const_value): Update.
1599         (dwarf2_symbol_mark_computed): Update.
1600         * eval.c (evaluate_funcall): Update.
1601         (evaluate_subexp_standard): Update.
1602         * expprint.c (print_subexp_standard): Update.
1603         (dump_subexp_body_standard): Update.
1604         * f-valprint.c (info_common_command_for_block): Update.
1605         * findvar.c (get_hosting_frame): Update.
1606         (default_read_var_value): Update.
1607         * go-lang.c (go_symbol_package_name): Update.
1608         * guile/scm-block.c (bkscm_print_block_smob): Update.
1609         * guile/scm-symbol.c (syscm_print_symbol_smob): Update.
1610         (gdbscm_symbol_name): Update.
1611         (gdbscm_symbol_linkage_name): Update.
1612         (gdbscm_symbol_print_name): Update.
1613         * infcall.c (get_function_name): Update.
1614         * infcmd.c (jump_command): Update.
1615         (finish_command): Update.
1616         * infrun.c (insert_exception_resume_breakpoint): Update.
1617         * linespec.c (canonicalize_linespec): Update.
1618         (create_sals_line_offset): Update.
1619         (convert_linespec_to_sals): Update.
1620         (complete_label): Update.
1621         (find_label_symbols_in_block): Update.
1622         * m2-typeprint.c (m2_print_typedef): Update.
1623         * mdebugread.c (mdebug_reg_to_regnum): Update.
1624         (parse_symbol): Update.
1625         (mylookup_symbol): Update.
1626         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
1627         (list_args_or_locals): Update.
1628         * objc-lang.c (compare_selectors): Update.
1629         (info_selectors_command): Update.
1630         (compare_classes): Update.
1631         (info_classes_command): Update.
1632         (find_imps): Update.
1633         * p-typeprint.c (pascal_print_typedef): Update.
1634         * printcmd.c (build_address_symbolic): Update.
1635         (info_address_command): Update.
1636         (print_variable_and_value): Update.
1637         * python/py-framefilter.c (extract_sym): Update.
1638         (py_print_single_arg): Update.
1639         * python/py-symbol.c (sympy_str): Update.
1640         (sympy_get_name): Update.
1641         (sympy_get_linkage_name): Update.
1642         * python/python.c (gdbpy_rbreak): Update.
1643         * record-btrace.c (btrace_get_bfun_name): Update.
1644         (btrace_call_history): Update.
1645         * rust-lang.c (rust_print_typedef): Update.
1646         * solib-frv.c (frv_fdpic_find_canonical_descriptor): Update.
1647         * stabsread.c (stab_reg_to_regnum): Update.
1648         (define_symbol): Update.
1649         (read_enum_type): Update.
1650         (common_block_end): Update.
1651         (cleanup_undefined_types_1): Update.
1652         (scan_file_globals): Update.
1653         * stack.c (print_frame_arg): Update.
1654         (print_frame_args): Update.
1655         (find_frame_funname): Update.
1656         (info_frame_command_core): Update.
1657         (iterate_over_block_locals): Update.
1658         (print_block_frame_labels): Update.
1659         (do_print_variable_and_value): Update.
1660         (iterate_over_block_arg_vars): Update.
1661         (return_command): Update.
1662         * symmisc.c (dump_symtab_1): Update.
1663         (print_symbol): Update.
1664         * symtab.c (eq_symbol_entry): Update.
1665         (symbol_cache_dump): Update.
1666         (lookup_language_this): Update.
1667         (find_pc_sect_line): Update.
1668         (skip_prologue_sal): Update.
1669         (symbol_search::compare_search_syms): Update.
1670         (treg_matches_sym_type_name): Update.
1671         (search_symbols): Update.
1672         (print_symbol_info): Update.
1673         (rbreak_command): Update.
1674         (completion_list_add_symbol): Update.
1675         (find_gnu_ifunc): Update.
1676         (get_symbol_address): Update.
1677         (search_module_symbols): Update.
1678         (info_module_subcommand): Update.
1679         * symtab.h (SYMBOL_NATURAL_NAME): Remove.
1680         (SYMBOL_LINKAGE_NAME): Remove.
1681         (SYMBOL_DEMANGLED_NAME): Remove.
1682         (SYMBOL_PRINT_NAME): Remove.
1683         (SYMBOL_SEARCH_NAME): Remove.
1684         * tracepoint.c (set_traceframe_context): Update.
1685         (validate_actionline): Update.
1686         (collection_list::collect_symbol): Update.
1687         (encode_actions_1): Update.
1688         (info_scope_command): Update.
1689         (print_one_static_tracepoint_marker): Update.
1690         * typeprint.c (typedef_hash_table::add_template_parameters): Update.
1691         * valops.c (address_of_variable): Update.
1692         (find_overload_match): Update.
1693         (find_oload_champ): Update.
1694
1695 2019-11-22  Christian Biesinger  <cbiesinger@google.com>
1696
1697         * ada-lang.c (ada_lookup_simple_minsym): Update.
1698         (ada_collect_symbol_completion_matches): Update.
1699         * ada-tasks.c (read_atcb): Update.
1700         * amd64-windows-tdep.c (amd64_skip_main_prologue): Update.
1701         (amd64_windows_skip_trampoline_code): Update.
1702         * arm-tdep.c (skip_prologue_function): Update.
1703         (arm_skip_stack_protector): Update.
1704         * arm-wince-tdep.c (arm_pe_skip_trampoline_code): Update.
1705         (arm_wince_skip_main_prologue): Update.
1706         * ax-gdb.c (gen_expr): Update.
1707         * block.c (call_site_for_pc): Update.
1708         * blockframe.c (find_pc_partial_function): Update.
1709         * breakpoint.c (set_breakpoint_location_function): Update.
1710         * btrace.c (ftrace_print_function_name): Update.
1711         (ftrace_function_switched): Update.
1712         * c-valprint.c (print_unpacked_pointer): Update.
1713         * coffread.c (coff_symfile_read): Update.
1714         * compile/compile-c-symbols.c (convert_symbol_bmsym): Update.
1715         * compile/compile-cplus-symbols.c (convert_symbol_bmsym): Update.
1716         * dwarf-index-write.c (write_psymbols): Update.
1717         * dwarf2loc.c (call_site_to_target_addr): Update.
1718         (func_verify_no_selftailcall): Update.
1719         (tailcall_dump): Update.
1720         (call_site_find_chain_1): Update.
1721         (dwarf_expr_reg_to_entry_parameter): Update.
1722         * elfread.c (elf_gnu_ifunc_record_cache): Update.
1723         * eval.c (evaluate_funcall): Update.
1724         (evaluate_subexp_standard): Update.
1725         (evaluate_subexp_for_sizeof): Update.
1726         * expprint.c (print_subexp_standard): Update.
1727         (dump_subexp_body_standard): Update.
1728         * frame.c (get_prev_frame_always_1): Update.
1729         * frv-tdep.c (frv_skip_main_prologue): Update.
1730         * gnu-v2-abi.c (gnuv2_value_rtti_type): Update.
1731         * gnu-v3-abi.c (gnuv3_rtti_type): Update.
1732         (gnuv3_get_typename_from_type_info): Update.
1733         (gnuv3_skip_trampoline): Update.
1734         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
1735         * i386-tdep.c (i386_skip_main_prologue): Update.
1736         (i386_pe_skip_trampoline_code): Update.
1737         * ia64-tdep.c (ia64_convert_from_func_ptr_addr): Update.
1738         * infcall.c (get_function_name): Update.
1739         * linespec.c (minsym_found): Update.
1740         * linux-fork.c (info_checkpoints_command): Update.
1741         * m32c-tdep.c (m32c_m16c_address_to_pointer): Update.
1742         (m32c_m16c_pointer_to_address): Update.
1743         * maint.c (maintenance_translate_address): Update.
1744         * minsyms.c (add_minsym_to_hash_table): Update.
1745         (add_minsym_to_demangled_hash_table): Update.
1746         (lookup_minimal_symbol_mangled): Update.
1747         (lookup_minimal_symbol_demangled): Update.
1748         (lookup_minimal_symbol_linkage): Update.
1749         (lookup_minimal_symbol_text): Update.
1750         (lookup_minimal_symbol_by_pc_name): Update.
1751         (minimal_symbol_is_less_than): Update.
1752         (compact_minimal_symbols): Update.
1753         (build_minimal_symbol_hash_tables): Update.
1754         (find_solib_trampoline_target): Update.
1755         * mips-tdep.c (mips_stub_frame_sniffer): Update.
1756         (mips_skip_pic_trampoline_code): Update.
1757         * msp430-tdep.c (msp430_skip_trampoline_code): Update.
1758         * objc-lang.c (info_selectors_command): Update.
1759         (info_classes_command): Update.
1760         (find_methods): Update.
1761         (find_imps): Update.
1762         * p-valprint.c (pascal_val_print): Update.
1763         * ppc-linux-tdep.c (powerpc_linux_in_dynsym_resolve_code): Update.
1764         * ppc-sysv-tdep.c (convert_code_addr_to_desc_addr): Update.
1765         * printcmd.c (build_address_symbolic): Update.
1766         (info_symbol_command): Update.
1767         * psymtab.c (psymbol_name_matches): Update.
1768         (match_partial_symbol): Update.
1769         (lookup_partial_symbol): Update.
1770         (print_partial_symbols): Update.
1771         (sort_pst_symbols): Update.
1772         (maintenance_check_psymtabs): Update.
1773         * python/py-framefilter.c (py_print_frame): Update.
1774         * python/python.c (gdbpy_rbreak): Update.
1775         * record-btrace.c (btrace_get_bfun_name): Update.
1776         (btrace_call_history): Update.
1777         * rs6000-tdep.c (rs6000_skip_main_prologue): Update.
1778         (rs6000_skip_trampoline_code): Update.
1779         * sol-thread.c (info_cb): Update.
1780         * stabsread.c (scan_file_globals): Update.
1781         * stack.c (find_frame_funname): Update.
1782         (info_frame_command_core): Update.
1783         * symmisc.c (dump_msymbols): Update.
1784         * symtab.c (symbol_natural_name): Rename to..,
1785         (general_symbol_info::natural_name): ...this.
1786         (symbol_demangled_name): Rename to...
1787         (general_symbol_info::demangled_name): ...this.
1788         (symbol_search_name): Rename to...
1789         (general_symbol_info::search_name): ...this.
1790         (symbol_matches_search_name): Update.
1791         (find_pc_sect_line): Update.
1792         (skip_prologue_sal): Update.
1793         (search_symbols): Update.
1794         (print_msymbol_info): Update.
1795         (rbreak_command): Update.
1796         (completion_list_add_msymbol): Update.
1797         (completion_list_objc_symbol): Update.
1798         (get_msymbol_address): Update.
1799         * symtab.h (struct general_symbol_info): Add member functions
1800         natural_name (), linkage_name (), print_name (), demangled_name (),
1801         and search_name ().
1802         (SYMBOL_NATURAL_NAME): Update.
1803         (symbol_natural_name): Move to a member function on general_symbol_info.
1804         (SYMBOL_DEMANGLED_NAME): Update.
1805         (symbol_demangled_name): Move to a member function on
1806         general_symbol_info.
1807         (SYMBOL_SEARCH_NAME): Update.
1808         (symbol_search_name): Move to a member function on general_symbol_info.
1809         (MSYMBOL_NATURAL_NAME): Remove.
1810         (MSYMBOL_LINKAGE_NAME): Remove.
1811         (MSYMBOL_PRINT_NAME): Remove.
1812         (MSYMBOL_DEMANGLED_NAME): Remove.
1813         (MSYMBOL_SEARCH_NAME): Remove.
1814         * x86-tdep.c (x86_in_indirect_branch_thunk): Update.
1815
1816 2019-11-22  Christian Biesinger  <cbiesinger@google.com>
1817
1818         * symtab.c (create_demangled_names_hash): Use per_bfd->
1819         minimal_symbol_count for computing the initial size, if greater
1820         than our default size.
1821
1822 2019-11-22  Tom de Vries  <tdevries@suse.de>
1823
1824         * contrib/words.sh: Improve words extraction.
1825
1826 2019-11-22  Tom de Vries  <tdevries@suse.de>
1827
1828         * contrib/words.sh: Combine sed invocations.
1829
1830 2019-11-21  Christian Biesinger  <cbiesinger@google.com>
1831
1832         * Makefile.in: Update.
1833         * demangle.c: Rename to...
1834         * gdb-demangle.c: ..this.
1835         (is_cplus_marker): Change return type to bool.
1836         (_initialize_demangler): Rename to...
1837         (_initialize_gdb_demangle): ...this.
1838         * gdb-demangle.h (is_cplus_marker): Change return type to bool.
1839         * symtab.h (demangle): Remove declaration; instead include
1840         gdb-demangle.h.
1841
1842 2019-11-21  Tom Tromey  <tromey@adacore.com>
1843
1844         * gdbsupport/format.c (format_pieces): Parse %I64d.
1845         * unittests/format_pieces-selftests.c (test_windows_formats): New
1846         function.
1847         (run_tests): Call it.
1848
1849 2019-11-21  Peeter Joot  <peeter.joot@lzlabs.com>
1850
1851         Byte reverse display of variables with DW_END_big, DW_END_little
1852         (DW_AT_endianity) dwarf attributes if different than the native
1853         byte order.
1854         * ada-lang.c (ada_value_binop):
1855         Use type_byte_order instead of gdbarch_byte_order.
1856         * ada-valprint.c (printstr):
1857         (ada_val_print_string):
1858         * ada-lang.c (value_pointer):
1859         (ada_value_binop):
1860         Use type_byte_order instead of gdbarch_byte_order.
1861         * c-lang.c (c_get_string):
1862         Use type_byte_order instead of gdbarch_byte_order.
1863         * c-valprint.c (c_val_print_array):
1864         Use type_byte_order instead of gdbarch_byte_order.
1865         * cp-valprint.c (cp_print_class_member):
1866         Use type_byte_order instead of gdbarch_byte_order.
1867         * dwarf2loc.c (rw_pieced_value):
1868         Use type_byte_order instead of gdbarch_byte_order.
1869         * dwarf2read.c (read_base_type): Handle DW_END_big,
1870         DW_END_little
1871         * f-lang.c (f_get_encoding):
1872         Use type_byte_order instead of gdbarch_byte_order.
1873         * findvar.c (default_read_var_value):
1874         Use type_byte_order instead of gdbarch_byte_order.
1875         * gdbtypes.c (check_types_equal):
1876         Require matching TYPE_ENDIANITY_NOT_DEFAULT if set.
1877         (recursive_dump_type): Print TYPE_ENDIANITY_BIG,
1878         and TYPE_ENDIANITY_LITTLE if set.
1879         (type_byte_order): new function.
1880         * gdbtypes.h (TYPE_ENDIANITY_NOT_DEFAULT): New macro.
1881         (struct main_type) <flag_endianity_not_default>:
1882         New field.
1883         (type_byte_order): New function.
1884         * infcmd.c (default_print_one_register_info):
1885         Use type_byte_order instead of gdbarch_byte_order.
1886         * p-lang.c (pascal_printstr):
1887         Use type_byte_order instead of gdbarch_byte_order.
1888         * p-valprint.c (pascal_val_print):
1889         Use type_byte_order instead of gdbarch_byte_order.
1890         * printcmd.c (print_scalar_formatted):
1891         Use type_byte_order instead of gdbarch_byte_order.
1892         * solib-darwin.c (darwin_current_sos):
1893         Use type_byte_order instead of gdbarch_byte_order.
1894         * solib-svr4.c (solib_svr4_r_ldsomap):
1895         Use type_byte_order instead of gdbarch_byte_order.
1896         * stap-probe.c (stap_modify_semaphore):
1897         Use type_byte_order instead of gdbarch_byte_order.
1898         * target-float.c (target_float_same_format_p):
1899         Use type_byte_order instead of gdbarch_byte_order.
1900         * valarith.c (scalar_binop):
1901         (value_bit_index):
1902         Use type_byte_order instead of gdbarch_byte_order.
1903         * valops.c (value_cast):
1904         Use type_byte_order instead of gdbarch_byte_order.
1905         * valprint.c (generic_emit_char):
1906         (generic_printstr):
1907         (val_print_string):
1908         Use type_byte_order instead of gdbarch_byte_order.
1909         * value.c (unpack_long):
1910         (unpack_bits_as_long):
1911         (unpack_value_bitfield):
1912         (modify_field):
1913         (pack_long):
1914         (pack_unsigned_long):
1915         Use type_byte_order instead of gdbarch_byte_order.
1916         * findvar.c (unsigned_pointer_to_address):
1917         (signed_pointer_to_address):
1918         (unsigned_address_to_pointer):
1919         (address_to_signed_pointer):
1920         (default_read_var_value):
1921         (default_value_from_register):
1922         Use type_byte_order instead of gdbarch_byte_order.
1923         * gnu-v3-abi.c (gnuv3_make_method_ptr):
1924         Use type_byte_order instead of gdbarch_byte_order.
1925         * riscv-tdep.c (riscv_print_one_register_info):
1926         Use type_byte_order instead of gdbarch_byte_order.
1927
1928 2019-11-21  Simon Marchi  <simon.marchi@polymtl.ca>
1929
1930         * top.c (current_ui_gdb_stdout_ptr): Spell out by hand.
1931         (current_ui_gdb_stdin_ptr): Likewise.
1932         (current_ui_gdb_stderr_ptr): Likewise.
1933         (current_ui_gdb_stdlog_ptr): Likewise.
1934         (current_ui_current_uiout_ptr): Likewise.
1935         (gen_ret_current_ui_field_ptr): Remove.
1936
1937 2019-11-21  Tom de Vries  <tdevries@suse.de>
1938
1939         PR gdb/24956
1940         * cli/cli-script.c (execute_control_command): Only switch to
1941         INTERP_CONSOLE's ui_out when INTERP_MI is active.
1942
1943 2019-11-19  Tom Tromey  <tom@tromey.com>
1944
1945         * tui/tui-win.c (tui_partial_win_by_name): Move from tui-data.c.
1946         Now static.  Change type of "name".
1947         (tui_set_win_height_command): Don't copy "arg".
1948         * tui/tui-data.h (tui_partial_win_by_name): Don't declare.
1949         * tui/tui-data.c (tui_partial_win_by_name): Move to tui-win.c.
1950
1951 2019-11-19  Ali Tamur <tamur@google.com>
1952
1953         * dwarf2read.c (dw2_get_file_names_reader): Replace "if (attr)" with
1954         "if (attr != nullptr)".
1955         (dwarf2_find_base_address): Likewise.
1956         (dwarf2_build_include_psymtabs): Likewise.
1957         (read_cutu_die_from_dwo): Likewise.
1958         (read_func_scope): Likewise.
1959         (read_call_site_scope): Likewise.
1960         (dwarf2_get_pc_bounds): Likewise.
1961         (dwarf2_record_block_ranges): Likewise.
1962         (dwarf2_add_field): Likewise.
1963         (dwarf2_add_member_fn): Likewise.
1964         (read_structure_type): Likewise.
1965         (read_enumeration_type): Likewise.
1966         (read_array_type): Likewise.
1967         (read_array_order): Likewise.
1968         (read_set_type): Likewise.
1969         (read_common_block): Likewise.
1970         (read_tag_reference_type): Likewise.
1971         (read_tag_string_type): Likewise.
1972         (read_subroutine_type): Likewise.
1973         (read_base_type): Likewise.
1974         (read_subrange_type): Likewise.
1975         (new_symbol): Likewise.
1976         (prepare_one_comp_unit): Likewise.
1977
1978 2019-11-19  Tom Tromey  <tromey@adacore.com>
1979
1980         * windows-nat.c (windows_nat_target::attach): Include GetLastError
1981         result in error when DebugActiveProcess fails.
1982
1983 2019-11-18  Sergio Durigan Junior  <sergiodj@redhat.com>
1984             Pedro Alves  <palves@redhat.com>
1985
1986         https://bugzilla.redhat.com/show_bug.cgi?id=1765117
1987         * target.c (target_stack::push): Call 'unpush' if there's a
1988         target on top of the stack.
1989
1990 2019-11-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1991
1992         * python/py-block.c (blpy_dealloc): Call tp_free.
1993         (blpy_block_syms_dealloc): Likewise.
1994         * python/py-finishbreakpoint.c (bpfinishpy_dealloc): Likewise.
1995         * python/py-inferior.c (infpy_dealloc): Likewise.
1996         * python/py-lazy-string.c (stpy_dealloc): Likewise.
1997         * python/py-linetable.c (ltpy_iterator_dealloc): Likewise.
1998         * python/py-symbol.c (sympy_dealloc): Likewise.
1999         * python/py-symtab.c (stpy_dealloc): Likewise.
2000         * python/py-type.c (typy_iterator_dealloc): Likewise.
2001
2002 2019-11-18  Christian Biesinger  <cbiesinger@google.com>
2003
2004         * symtab.h (struct symbol) <owner>: Initialize explicitly in the
2005         constructor instead of using a class initializer.
2006
2007 2019-11-15  Christian Biesinger  <cbiesinger@google.com>
2008
2009         * Makefile.in: Replace {posix,mingw}-strerror.c with safe-strerror.c.
2010         * configure: Regenerate.
2011         * configure.ac: Don't source common.host.
2012         * gdbsupport/common.host: Remove.
2013         * gdbsupport/mingw-strerror.c: Remove.
2014         * gdbsupport/posix-strerror.c: Rename to...
2015         * gdbsupport/safe-strerror.c: ...this.
2016
2017 2019-11-15  Christian Biesinger  <cbiesinger@google.com>
2018
2019         * maint.c (scoped_command_stats::print_time): Use localtime_r
2020         instead of localtime (provided through gnulib if necessary).
2021         * nat/linux-osdata.c (time_from_time_t): Use ctime_r instead
2022         of ctime.
2023
2024 2019-11-15  Christian Biesinger  <cbiesinger@google.com>
2025
2026         * gdbsupport/common-defs.h: Include time.h before pathmax.h to
2027         avoid compile errors.
2028
2029 2019-11-15  Christian Biesinger  <cbiesinger@google.com>
2030
2031         * config.in: Regenerate.
2032         * configure: Regenerate.
2033         * gdbsupport/common.m4: No longer check for strerror_r.
2034         * gdbsupport/posix-strerror.c (safe_strerror): Always call the
2035         POSIX version of strerror_r, now that gnulib provides it if
2036         necessary.
2037
2038 2019-11-14  Christian Biesinger  <cbiesinger@google.com>
2039
2040         * README (`configure' options): Update.
2041
2042 2019-11-14  Tom Tromey  <tromey@adacore.com>
2043
2044         * eval.c (evaluate_subexp_standard) <BINOP_ASSIGN>: Do not pass an
2045         expected type for the RHS if the LHS is a convenience variable.
2046
2047 2019-11-14  Simon Marchi  <simon.marchi@polymtl.ca>
2048
2049         * unittests/vec-utils-selftests.c (unordered_remove_tests::obj):
2050         Provide explicit default and copy constructor.
2051
2052 2019-11-14  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2053
2054         * python/py-finishbreakpoint.c (gdbpy_breakpoint_created):
2055         only call Py_INCREF (newbp) in the bppy_pending_object case.
2056
2057 2019-11-13  Tom Tromey  <tromey@adacore.com>
2058
2059         PR build/25182:
2060         * psympriv.h (partial_symbol): Remove static assert.
2061         * symtab.h (general_symbol_info, symbol): Remove static assert.
2062
2063 2019-11-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2064
2065         * gdbsupport/format.c (format_pieces::format_pieces): Support
2066         printf 'z' size modifier.
2067         * gdbsupport/format.h (enum argclass): Add size_t_arg.
2068         * printcmd.c (ui_printf):  Handle size_t_arg.
2069         * ui-out.c (ui_out::vmessage): Likewise.
2070         * unittests/format_pieces-selftests.c (test_format_int_sizes): New
2071         function.
2072         (run_tests): Call test_format_int_sizes.
2073
2074 2019-11-12  Christian Biesinger  <cbiesinger@google.com>
2075
2076         * ada-exp.y (write_ambiguous_var): Update.
2077         * buildsym.c (add_symbol_to_list): Update.
2078         * dwarf2read.c (read_variable): Update.
2079         (new_symbol): Update.
2080         * jit.c (finalize_symtab): Update.
2081         * language.c (language_alloc_type_symbol): Update.
2082         * symtab.c (fixup_symbol_section): Update.
2083         (initialize_objfile_symbol_1): Move code to...
2084         (initialize_objfile_symbol): ...here. Remove now-unnecessary memset.
2085         (allocate_symbol): Update.
2086         (allocate_template_symbol): Update.
2087         (get_symbol_address): Update.
2088         * symtab.h (struct symbol): Inherit from general_symbol_info instead
2089         of having as a field, and add a constructor.
2090         (SYMBOL_VALUE): Update.
2091         (SYMBOL_VALUE_ADDRESS): Update.
2092         (SET_SYMBOL_VALUE_ADDRESS): Update.
2093         (SYMBOL_VALUE_BYTES): Update.
2094         (SYMBOL_VALUE_COMMON_BLOCK): Update.
2095         (SYMBOL_BLOCK_VALUE): Update.
2096         (SYMBOL_VALUE_CHAIN): Update.
2097         (SYMBOL_LANGUAGE): Update.
2098         (SYMBOL_SECTION): Update.
2099         (SYMBOL_OBJ_SECTION): Update.
2100         (SYMBOL_SET_LANGUAGE): Update.
2101         (SYMBOL_SET_LINKAGE_NAME): Update.
2102         (SYMBOL_SET_NAMES): Update.
2103         (SYMBOL_NATURAL_NAME): Update.
2104         (SYMBOL_LINKAGE_NAME): Update.
2105         (SYMBOL_DEMANGLED_NAME): Update.
2106         (SYMBOL_SEARCH_NAME): Update.
2107         (SYMBOL_MATCHES_SEARCH_NAME): Update.
2108         (struct symbol): Update.
2109         (struct template_symbol): Update.
2110         (struct rust_vtable_symbol): Update.
2111         * xcoffread.c (SYMBOL_DUP): Update.
2112
2113 2019-11-12  Tom Tromey  <tom@tromey.com>
2114
2115         * tui/tui-layout.c (show_layout): Set current_layout.
2116         (show_source_disasm_command, show_data)
2117         (show_source_or_disasm_and_command): Don't set current_layout.
2118
2119 2019-11-12  Tom Tromey  <tom@tromey.com>
2120
2121         * tui/tui-layout.c (_initialize_tui_layout): Move to end.
2122
2123 2019-11-12  Tom Tromey  <tom@tromey.com>
2124
2125         * tui/tui-win.c (resize_message): New global.
2126         (show_tui_resize_message): New function.
2127         (tui_async_resize_screen): Print message if requested.
2128         (_initialize_tui_win): Add tui-resize-message setting.
2129         * NEWS: Add entry for new commands.
2130
2131 2019-11-11  Tom Tromey  <tom@tromey.com>
2132
2133         * tui/tui.c (tui_initialize_readline): Add new bindable readline
2134         functions.
2135
2136 2019-11-11  Christian Biesinger  <cbiesinger@google.com>
2137
2138         * nat/linux-osdata.c (user_from_uid): Use getpwuid_r.
2139
2140 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2141
2142         * python/py-symbol.c (gdbpy_lookup_static_symbols): New
2143         function.
2144         * python/python-internal.h (gdbpy_lookup_static_symbols):
2145         Declare new function.
2146         * python/python.c (python_GdbMethods): Add
2147         gdb.lookup_static_symbols method.
2148         * NEWS: Mention gdb.lookup_static_symbols.
2149
2150 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2151
2152         * python/py-symbol.c (gdbpy_lookup_static_symbol): Lookup in
2153         static block of current object file first.  Also fix typo in
2154         header comment.
2155
2156 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2157
2158         * stack.c (set_last_displayed_sal): Delete.
2159         (last_displayed_sal_valid): Delete.
2160         (last_displayed_pspace): Delete.
2161         (last_displayed_addr): Delete.
2162         (last_displayed_symtab): Delete.
2163         (last_displayed_line): Delete.
2164         (class last_displayed_symtab_info_type): New.
2165         (last_displayed_symtab_info): New static global variable.
2166         (print_frame_info): Call methods on last_displayed_symtab_info.
2167         (clear_last_displayed_sal): Update header comment, and make use of
2168         last_displayed_symtab_info.
2169         (last_displayed_sal_is_valid): Likewise.
2170         (get_last_displayed_pspace): Likewise.
2171         (get_last_displayed_addr): Likewise.
2172         (get_last_displayed_symtab): Likewise.
2173         (get_last_displayed_line): Likewise.
2174         (get_last_displayed_sal): Likewise.
2175         * stack.h (clear_last_displayed_sal): Update header comment.
2176         (last_displayed_sal_is_valid): Likewise.
2177         (get_last_displayed_pspace): Likewise.
2178         (get_last_displayed_addr): Likewise.
2179         (get_last_displayed_symtab): Likewise.
2180         (get_last_displayed_line): Likewise.
2181         (get_last_displayed_sal): Likewise.
2182
2183 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2184
2185         * stack.c (frame_show_address): Convert return type to bool.
2186         * stack.h (frame_show_address): Likewise, and update header
2187         comment.
2188
2189 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2190
2191         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add new file to the list.
2192         * unittests/vec-utils-selftests.c: New file.
2193         * gdbsupport/gdb_vecs.h (unordered_remove): Avoid self move assign.
2194
2195 2019-11-10  Tom Tromey  <tom@tromey.com>
2196
2197         * tui/tui-wingeneral.c (tui_unhighlight_win): Use can_box.
2198         (tui_highlight_win): Likewise.
2199         (tui_win_info::check_and_display_highlight_if_needed): Likewise.
2200         * tui/tui-data.h (struct tui_win_info) <can_highlight>: Remove.
2201         * tui/tui-command.h (struct tui_cmd_window) <tui_cmd_window>:
2202         Don't set can_highlight.
2203
2204 2019-11-10  Tom Tromey  <tom@tromey.com>
2205
2206         * cli/cli-style.h (class cli_style_option) <cli_style_option>:
2207         Remove unused declaration.
2208
2209 2019-11-08  Tom Tromey  <tromey@adacore.com>
2210
2211         * top.c (read_command_file): Update.
2212         (command_line_input): Make return type const.
2213         * python/py-gdb-readline.c: Update.
2214         * linespec.c (decode_line_2): Update.
2215         * defs.h (command_line_input): Make return type const.
2216         * cli/cli-script.c (read_next_line): Make return type const.
2217         * ada-lang.c (get_selections): Update.
2218
2219 2019-11-06  Christian Biesinger  <cbiesinger@google.com>
2220
2221         * linux-tdep.c (linux_info_proc): Use strtok_r instead of strtok.
2222         * mi/mi-main.c (output_cores): Likewise.
2223         * nat/linux-osdata.c (linux_xfer_osdata_cpus): Likewise.
2224         (linux_xfer_osdata_modules): Likewise.
2225         * remote.c (register_remote_support_xml): Likewise.
2226         * sparc64-tdep.c (adi_is_addr_mapped): Likewise.
2227         * xml-syscall.c (syscall_create_syscall_desc): Likewise.
2228
2229 2019-11-06  Tom Tromey  <tom@tromey.com>
2230
2231         * tui/tui-interp.c: Don't include readline.h.
2232         * tui/tui-hooks.c: Don't include readline.h.
2233         * symmisc.c: Include tilde.h, not readline.h.
2234         * symfile.c: Include tilde.h, not readline.h.
2235         * source.c: Include tilde.h, not readline.h.
2236         * solib.c: Include tilde.h, not readline.h.
2237         * psymtab.c: Include tilde.h, not readline.h.
2238         * exec.c: Include tilde.h, not readline.h.
2239         * corelow.c: Include tilde.h, not readline.h.
2240         * cli/cli-dump.c: Include tilde.h, not readline.h.
2241         * cli/cli-cmds.c: Don't include readline.h.
2242
2243 2019-11-05  Tom Tromey  <tom@tromey.com>
2244
2245         * tui/tui-disasm.c (struct tui_asm_line) <addr_size>: New member.
2246         (tui_disassemble): Set addr_size.
2247         (tui_disasm_window::set_contents): Use addr_size.
2248
2249 2019-11-05  Tom Tromey  <tom@tromey.com>
2250
2251         * rust-lang.c (rust_language_defn): Update.
2252         * python/py-value.c (valpy_string): Call c_get_string.
2253         * p-lang.c (pascal_language_defn): Update.
2254         * opencl-lang.c (opencl_language_defn): Update.
2255         * objc-lang.c (objc_language_defn): Update.
2256         * m2-lang.c (m2_language_defn): Update.
2257         * language.c (unknown_language_defn, auto_language_defn): Update.
2258         (default_get_string): Remove.
2259         * guile/scm-value.c (gdbscm_value_to_string): Use c_get_string.
2260         * go-lang.c (go_language_defn): Update.
2261         * f-lang.c (f_language_defn): Update.
2262         * d-lang.c (d_language_defn): Update.
2263         * c-lang.c (c_language_defn, cplus_language_defn)
2264         (asm_language_defn, minimal_language_defn): Update.
2265         * ada-lang.c (ada_language_defn): Update.
2266         * language.h (struct language_defn) <la_get_string>: Remove.
2267         (LA_GET_STRING): Remove.
2268         (default_get_string): Don't declare.
2269
2270 2019-11-05  Tom Tromey  <tom@tromey.com>
2271
2272         * tui/tui-source.h (struct tui_source_window): Inline
2273         constructor.  Remove destructor.
2274         <style_changed, m_observable>: Move to superclass.
2275         * tui/tui-winsource.h (tui_copy_source_line): Declare.
2276         (struct tui_source_window_base): Move private members to end.
2277         <style_changed, m_observable>: Move from tui_source_window.
2278         * tui/tui-winsource.c (tui_copy_source_line): Move from
2279         tui-source.c.  Rename from copy_source_line.  Add special handling
2280         for negative line number.
2281         (tui_source_window_base::style_changed): Move from
2282         tui_source_window.
2283         (tui_source_window_base): Register observer.
2284         (~tui_source_window_base): New.
2285         * tui/tui-source.c (copy_source_line): Move to tui-winsource.c;
2286         rename.
2287         (tui_source_window::set_contents): Use tui_copy_source_line.
2288         (tui_source_window::tui_source_window): Move to tui-source.h.
2289         (tui_source_window::~tui_source_window): Remove.
2290         (tui_source_window::style_changed): Move to superclass.
2291         * tui/tui-disasm.c (tui_disassemble): Create string file with
2292         styling, when possible.  Add "addr_size" parameter.
2293         (tui_disasm_window::set_contents): Use tui_copy_source_line.
2294         Don't compute maximum size.
2295         (len_without_escapes): New function
2296
2297 2019-11-05  Tom Tromey  <tom@tromey.com>
2298
2299         * tui/tui-winsource.h (struct tui_source_element) <line>: Now a
2300         std::string.
2301         * tui/tui-winsource.c (tui_show_source_line): Update.
2302         * tui/tui-source.c (tui_source_window::set_contents): Update.
2303         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
2304
2305 2019-11-05  Christian Biesinger  <cbiesinger@google.com>
2306
2307         * symtab.h (gdb_static_assert): Put && operator at the beginning
2308         of the line instead of the end.
2309
2310 2019-11-04  Christian Biesinger  <cbiesinger@google.com>
2311
2312         * psympriv.h: Add static_asserts for sizeof (general_symbol_info)
2313         and sizeof (symbol).
2314         * symtab.h: Add a static_assert for sizeof (partial_symbol).
2315
2316 2019-11-04  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
2317
2318         * NEWS (Changes since GDB 8.3): Document Solaris 10 removal.
2319         * configure.host: Mark *-*-solaris2.10* obsolete.
2320         * configure.tgt: Mark Solaris < 11 obsolete.
2321         * MAINTAINERS (Target Instruction Set Architectures) <sparc>:
2322         Update target triplet.
2323
2324 2019-11-01  Tom Tromey  <tromey@adacore.com>
2325
2326         * utils.c (print_sys_errmsg): Simplify.
2327
2328 2019-11-01  Tom Tromey  <tromey@adacore.com>
2329
2330         * gdbsupport/mingw-strerror.c (safe_strerror): Constify result.
2331
2332 2019-11-01  Christian Biesinger  <cbiesinger@google.com>
2333
2334         * configure: Regenerate.
2335         * configure.ac: Remove check for strerror_r.
2336         * gdbsupport/common.m4: Check for strerror_r.
2337
2338 2019-11-01  Luis Machado  <luis.machado@linaro.org>
2339
2340         PR gdb/25124
2341
2342         * arm-tdep.c (arm_per_objfile): Rename to ...
2343         (arm_per_bfd): ... this.
2344         (arm_objfile_data_key): Rename to ...
2345         (arm_bfd_data_key): ... this.
2346         (arm_find_mapping_symbol): Adjust access to new bfd_key-based
2347         data.
2348         (arm_record_special_symbol): Likewise.
2349
2350 2019-10-31  Andrew Burgess  <andrew.burgess@embecosm.com>
2351
2352         * ada-typeprint.c (ada_print_typedef): Don't print newline at the
2353         end.
2354         * c-typeprint.c (c_print_typedef): Likewise.
2355         * f-typeprint.c (f_print_typedef): Likewise.
2356         * m2-typeprint.c (m2_print_typedef): Likewise.
2357         * p-typeprint.c (pascal_print_typedef): Likewise.
2358         * rust-lang.c (rust_print_typedef): Likewise.
2359         * symtab.c (print_symbol_info): Print a newline after calling
2360         typedef_print.
2361
2362 2019-10-31  Andrew Burgess  <andrew.burgess@embecosm.com>
2363
2364         * symtab.c (info_module_cmdlist): New variable.
2365         (info_module_command): New function.
2366         (search_module_symbols): New function.
2367         (info_module_subcommand): New function.
2368         (struct info_modules_var_func_options): New struct.
2369         (info_modules_var_func_options_defs): New variable.
2370         (make_info_modules_var_func_options_def_group): New function.
2371         (info_module_functions_command): New function.
2372         (info_module_variables_command): New function.
2373         (info_module_var_func_command_completer): New function.
2374         (_initialize_symtab): Register new 'info module functions' and
2375         'info module variables' commands.
2376         * symtab.h (typedef symbol_search_in_module): New typedef.
2377         (search_module_symbols): Declare new function.
2378         * NEWS: Mention new commands.
2379
2380 2019-10-31  Andrew Burgess  <andrew.burgess@embecosm.com>
2381
2382         * dwarf2read.c (dw2_symtab_iter_next): Handle MODULE_DOMAIN.
2383         (dw2_expand_marked_cus): Handle MODULES_DOMAIN.
2384         (dw2_debug_names_iterator::next): Handle MODULE_DOMAIN and
2385         MODULES_DOMAIN.
2386         (scan_partial_symbols): Only create partial module symbols for non
2387         declarations.
2388         * psymtab.c (recursively_search_psymtabs): Handle MODULE_DOMAIN
2389         and MODULES_DOMAIN.
2390         * symtab.c (search_domain_name): Likewise.
2391         (search_symbols): Likewise.
2392         (print_symbol_info): Likewise.
2393         (symtab_symbol_info): Likewise.
2394         (info_modules_command): New function.
2395         (_initialize_symtab): Register 'info modules' command.
2396         * symtab.h (enum search_domain): Add MODULES_DOMAIN.
2397         * NEWS: Mention new 'info modules' command.
2398
2399 2019-10-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2400
2401         * NEWS: Mention $_gdb_setting, $_gdb_setting_str, $_gdb_maint_setting
2402         and $_gdb_maint_setting_str.
2403
2404 2019-10-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2405
2406         * cli/cli-cmds.c (setting_cmd, value_from_setting)
2407         (gdb_setting_internal_fn, gdb_maint_setting_internal_fn)
2408         (str_value_from_setting, gdb_setting_str_internal_fn)
2409         (gdb_maint_setting_str_internal_fn): New functions.
2410         (_initialize_cli_cmds): Define the new convenience functions.
2411         * gdb/cli/cli-setshow.h (get_setshow_command_value_string): Constify.
2412         * gdb/cli/cli-setshow.c (get_setshow_command_value_string): Constify.
2413
2414 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
2415
2416         * agent.c (set_can_use_agent): When the setting is turned on,
2417         look up agent symbols if we don't have them yet.
2418         (agent_new_objfile): Don't look up agent symbols when the agent
2419         setting is off.
2420
2421 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
2422
2423         * config.in: Regenerate.
2424
2425 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
2426
2427         * configure: Regenerate.
2428         * configure.ac: Check for strerror_r.
2429         * gdbsupport/common-utils.h (safe_strerror): Change return value
2430         to const char * and document that this function is now threadsafe.
2431         * gdbsupport/posix-strerror.c (safe_strerror): Make buf
2432         thread_local and call strerror_r, if available.
2433         * utils.c (perror_string): Update.
2434         (print_sys_errmsg): Update.
2435
2436 2019-10-31  Luis Machado  <luis.machado@linaro.org>
2437
2438         * arm-tdep.c (arm_exidx_data_key): Use bfd_key instead of
2439         objfile_key.
2440         (arm_exidx_new_objfile): Adjust to use objfile->obfd instead of
2441         objfile to fetch per-bfd data.
2442         (arm_find_exidx_entry): Likewise.
2443
2444 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
2445
2446         * gdbsupport/agent.c (debug_agent): Change type to bool.
2447         (use_agent): Likewise.
2448         (all_agent_symbols_look_up): Likewise.
2449         (agent_loaded_p): Change return value to bool.
2450         (agent_look_up_symbols): Update.
2451         (agent_capability_check): Change return value to bool.
2452         * gdbsupport/agent.h (agent_loaded_p): Likewise.
2453         (debug_agent): Change type to bool.
2454         (use_agent): Likewise.
2455         (agent_capability_check): Change return value to bool.
2456
2457 2019-10-30  Christian Biesinger  <cbiesinger@google.com>
2458
2459         * minsyms.c (clear_minimal_symbol_hash_tables): New function.
2460         (build_minimal_symbol_hash_tables): Code to clear the table moved
2461         to clear_minimal_symbol_hash_tables.
2462         (minimal_symbol_reader::install): Call clear_minimal_symbol_hash_tables
2463         when needed.
2464
2465 2019-10-29  Simon Marchi  <simon.marchi@polymtl.ca>
2466
2467         * infcmd.c: Remove includes.
2468         * infrun.c: Remove includes.
2469
2470 2019-10-29  Simon Marchi  <simon.marchi@polymtl.ca>
2471
2472         * ada-lang.h (GROW_VECT): Move to ada-lang.c.
2473         (grow_vect): Remove declaration.
2474         (ada_type_of_array): Remove declaration.
2475         (ada_update_initial_language): Remove declaration.
2476         (ada_fold_name): Remove declaration.
2477         (ada_fill_in_ada_prototype): Remove declaration.
2478         (user_select_syms): Remove declaration.
2479         (get_selections): Remove declaration.
2480         (ada_tag_type): Remove declaration.
2481         (ada_value_tag): Remove declaration.
2482         (ada_is_others_clause): Remove declaration.
2483         (ada_in_variant): Remove declaration.
2484         (ada_value_struct_elt): Remove declaration.
2485         (ada_attribute_name): Remove declaration.
2486         (ada_system_address_type): Remove declaration.
2487         * ada-lang.c (ada_watch_location_expression): Make static.
2488         (GROW_VECT): Move here from ada-lang.h.
2489         (grow_vect): Make static.
2490         (ada_update_initial_language): Make static.
2491         (ada_fold_name): Make static.
2492         (ada_type_of_array): Make static.
2493         (encoded_ordered_before): Move up.
2494         (sort_choices): Move up.
2495         (print_signatures): Move up.
2496         (ada_print_symbol_signature): Move up.
2497         (get_selections): Move up and make static.
2498         (user_select_syms): Move up and make static.
2499         (ada_value_struct_elt): Move up and make static.
2500         (ada_tag_type): Make static.
2501         (ada_value_tag): Make static.
2502         (ada_is_others_clause): Make static.
2503         (ada_in_variant): Make static.
2504         (ada_attribute_name): Make static.
2505
2506 2019-10-29  Simon Marchi  <simon.marchi@polymtl.ca>
2507
2508         * ada-lang.c: Remove includes.
2509         * ada-typeprint.c: Remove includes.
2510         * ada-valprint.c: Remove includes.
2511
2512 2019-10-29  Simon Marchi  <simon.marchi@efficios.com>
2513
2514         * addrmap.c: Add static assertions of type size, moved from
2515         _initialize_addrmap.
2516         (_initialize_addrmap): Remove.
2517
2518 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
2519
2520         * coffread.c (record_minimal_symbol): Update.
2521         (process_coff_symbol): Update.
2522         * dbxread.c (read_dbx_symtab): Update.
2523         * dwarf2read.c (add_partial_symbol): Update.
2524         (fixup_go_packaging): Update.
2525         (load_partial_dies): Update.
2526         (new_symbol): Update.
2527         * elfread.c (record_minimal_symbol): Change signature to use
2528         gdb::string_view instead of name+len.
2529         (elf_symtab_read): Update.
2530         (elf_rel_plt_read): Update.
2531         * mdebugread.c (parse_partial_symbols): Update.
2532         (handle_psymbol_enumerators): Update.
2533         (new_symbol): Update.
2534         * minsyms.c (minimal_symbol_reader::record_full): Change signature
2535         to use gdb::string_view instead of name+len.
2536         * minsyms.h (class minimal_symbol_reader) <record_full>: Likewise.
2537         * psympriv.h (add_psymbol_to_list): Likewise.
2538         * psymtab.c (add_psymbol_to_bcache): Likewise.
2539         (add_psymbol_to_list): Likewise.
2540         * stabsread.c (define_symbol): Update.
2541         * symtab.c (symbol_set_names): Change signature to use gdb::string_view.
2542         * symtab.h (SYMBOL_SET_NAMES): Likewise.
2543         (symbol_set_names): Likewise.
2544         * xcoffread.c (scan_xcoff_symtab): Update.
2545
2546 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
2547
2548         * symtab.h (symbol_set_names): Document that copy_name must be
2549         set to true for non-nullterminated strings.
2550         * symtab.c (symbol_set_names): Only make a nullterminated copy of
2551         linkage_name if the entry was not found and we need to demangle.
2552
2553 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
2554
2555         * Makefile.in (HFILES_NO_SRCDIR): Add gdb_binary_search.h.
2556         * dwarf2-frame.c (bsearch_fde_cmp): Update.
2557         (dwarf2_frame_find_fde): Replace bsearch with gdb::binary_search.
2558         * gdbsupport/gdb_binary_search.h: New file.
2559
2560 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
2561
2562         * NEWS: Mention new --with-system-gdbinit-dir option.
2563         * config.in: Regenerate.
2564         * configure: Regenerate.
2565         * configure.ac: Add new option --with-system-gdbinit-dir.
2566         * extension.c (get_ext_lang_of_file): Return extension_language_gdb
2567         for a ".gdb" suffix.
2568         * main.c (get_init_files): Change system_gdbinit argument to
2569         a vector and return the files in SYSTEM_GDBINIT_DIR in
2570         addition to SYSTEM_GDBINIT.
2571         (captured_main_1): Update.
2572         (print_gdb_help): Update.
2573         * top.c (print_gdb_configuration): Also print the value of
2574         SYSTEM_GDBINIT_DIR.
2575
2576 2019-10-28  Christian Biesinger  <cbiesinger@google.com>
2577
2578         * gdbsupport/common-utils.h (startswith): Add an overloaded version
2579         that takes gdb::string_view arguments.
2580
2581 2019-10-26  Tom de Vries  <tdevries@suse.de>
2582
2583         * aarch64-linux-tdep.c: Fix typos in comments.
2584         * aarch64-tdep.c: Same.
2585         * ada-lang.c: Same.
2586         * amd64-nat.c: Same.
2587         * arc-tdep.c: Same.
2588         * arch/aarch64-insn.c: Same.
2589         * block.c: Same.
2590         * breakpoint.h: Same.
2591         * btrace.h: Same.
2592         * c-varobj.c: Same.
2593         * cli/cli-decode.c: Same.
2594         * cli/cli-script.c: Same.
2595         * cli/cli-utils.h: Same.
2596         * coff-pe-read.c: Same.
2597         * coffread.c: Same.
2598         * compile/compile-cplus-symbols.c: Same.
2599         * compile/compile-object-run.c: Same.
2600         * completer.c: Same.
2601         * corelow.c: Same.
2602         * cp-support.c: Same.
2603         * demangle.c: Same.
2604         * dwarf-index-write.c: Same.
2605         * dwarf2-frame.c: Same.
2606         * dwarf2-frame.h: Same.
2607         * eval.c: Same.
2608         * frame-base.h: Same.
2609         * frame.h: Same.
2610         * gdbcmd.h: Same.
2611         * gdbtypes.h: Same.
2612         * gnu-nat.c: Same.
2613         * guile/scm-objfile.c: Same.
2614         * i386-tdep.c: Same.
2615         * i386-tdep.h: Same.
2616         * infcall.c: Same.
2617         * infcall.h: Same.
2618         * linux-nat.c: Same.
2619         * m68k-tdep.c: Same.
2620         * macroexp.c: Same.
2621         * memattr.c: Same.
2622         * mi/mi-cmd-disas.c: Same.
2623         * mi/mi-getopt.h: Same.
2624         * mi/mi-main.c: Same.
2625         * minsyms.c: Same.
2626         * nat/aarch64-sve-linux-sigcontext.h: Same.
2627         * objfiles.h: Same.
2628         * ppc-linux-nat.c: Same.
2629         * ppc-linux-tdep.c: Same.
2630         * ppc-tdep.h: Same.
2631         * progspace.h: Same.
2632         * prologue-value.h: Same.
2633         * python/py-evtregistry.c: Same.
2634         * python/py-instruction.h: Same.
2635         * record-btrace.c: Same.
2636         * record-full.c: Same.
2637         * remote.c: Same.
2638         * rs6000-tdep.c: Same.
2639         * ser-tcp.c: Same.
2640         * sol-thread.c: Same.
2641         * sparc-sol2-tdep.c: Same.
2642         * sparc64-tdep.c: Same.
2643         * stabsread.c: Same.
2644         * symfile.c: Same.
2645         * symtab.h: Same.
2646         * target.c: Same.
2647         * tracepoint.c: Same.
2648         * tui/tui-data.h: Same.
2649         * tui/tui-io.c: Same.
2650         * tui/tui-win.c: Same.
2651         * tui/tui.c: Same.
2652         * unittests/rsp-low-selftests.c: Same.
2653         * user-regs.h: Same.
2654         * utils.c: Same.
2655         * utils.h: Same.
2656         * valarith.c: Same.
2657         * valops.c: Same.
2658         * valprint.c: Same.
2659         * valprint.h: Same.
2660         * value.c: Same.
2661         * value.h: Same.
2662         * varobj.c: Same.
2663         * x86-nat.h: Same.
2664         * xtensa-tdep.c: Same.
2665
2666 2019-10-25  Ali Tamur <tamur@google.com>
2667
2668         * charset.c (find_charset_names): Reflect API change.
2669
2670 2019-10-25  Christian Biesinger  <cbiesinger@google.com>
2671
2672         * symtab.c (struct demangled_name_entry): Change demangled name
2673         to a unique_xmalloc_ptr<char>, now that we don't allocate it as
2674         part of the struct anymore.
2675         (symbol_set_names): No longer obstack allocate + copy the demangled
2676         name, just store the allocated name from bfd.
2677
2678 2019-10-25  Tom Tromey  <tromey@adacore.com>
2679
2680         * dwarf2-frame.c (dwarf2_cie_table): Now a typedef.
2681         (bsearch_cie_cmp, add_cie): Remove.
2682         (find_cie): Reimplement.
2683         (decode_frame_entry_1, decode_frame_entry): Change type.  Update.
2684         (dwarf2_build_frame_info): Update.
2685
2686 2019-10-24  H.J. Lu  <hongjiu.lu@intel.com>
2687
2688         PR gdb/25126
2689         * symfile.c (reread_symbols): Call forget_cached_source_info to
2690         clear the stale source cache.
2691
2692 2019-10-24  Christian Biesinger  <cbiesinger@google.com>
2693
2694         * configure: Regenerate.
2695         * configure.ac: Remove code that sets python_has_threads.
2696
2697 2019-10-24  Christian Biesinger  <cbiesinger@google.com>
2698
2699         * config.in: Regenerate.
2700         * configure: Regenerate.
2701         * configure.ac: Remove the code that uses sed to get the python
2702         version and defines HAVE_LIBPYTHON2_6 / HAVE_LIBPYTHON2_7.
2703
2704 2019-10-24  Andrew Burgess  <andrew.burgess@embecosm.com>
2705
2706         * python/py-progspace.c (pspy_block_for_pc): Return None for all
2707         error paths.
2708
2709 2019-10-23  Tom Tromey  <tom@tromey.com>
2710
2711         * arc-tdep.c: Remove ".." from include.
2712         * frv-tdep.c: Remove ".." from include.
2713         * lm32-tdep.c: Remove ".." from include.
2714         * microblaze-tdep.c: Remove ".." from include.
2715         * or1k-tdep.h: Remove ".." from include.
2716         * s12z-tdep.c: Remove ".." from include.
2717         * Makefile.in (OPCODES_CFLAGS): Add comment.
2718         (TOP_CFLAGS): New variable.
2719         (INTERNAL_CFLAGS_BASE): Add TOP_CFLAGS.
2720
2721 2019-10-23  Tom Tromey  <tom@tromey.com>
2722
2723         * Makefile.in (READLINE_DIR): Update.
2724
2725 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
2726
2727         * infcall.c (call_function_by_hand_dummy): Fix the function
2728         comment.  And extract out a code section into...
2729         (reserve_stack_space): ...this new function.
2730
2731 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
2732
2733         * infcall.c (value_arg_coerce): Remove an unused parameter.
2734         (call_function_by_hand_dummy): Update the call to
2735         'value_arg_coerce'.
2736
2737 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
2738
2739         * infcall.c (call_function_by_hand_dummy): Refactor.
2740
2741 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
2742
2743         * MAINTAINERS (Write After Approval): Add Tankut Baris Aktemur.
2744
2745 2019-10-23  Tom Tromey  <tom@tromey.com>
2746
2747         * configure: Rebuild.
2748         * configure.ac: Don't check for sigprocmask.
2749         * gdbsupport/common.m4 (GDB_AC_COMMON): Check for sigprocmask.
2750
2751 2019-10-23  Tom Tromey  <tom@tromey.com>
2752
2753         * configure: Rebuild.
2754         * acinclude.m4: Use m4_include, not sinclude.
2755
2756 2019-10-23  Tom de Vries  <tdevries@suse.de>
2757
2758         PR breakpoints/24687
2759         * symtab.c (iterate_over_some_symtabs): Apply gdb_realpath on fullname.
2760
2761 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
2762
2763         * symtab.c (struct demangled_name_entry) <language>: Change from
2764         bitfield to regular variable.
2765
2766 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
2767
2768         * symtab.c (struct demangled_name_entry): Add a constructor.
2769         (free_demangled_name_entry): New function to call the destructor
2770         for demangled_name_entry.
2771         (create_demangled_names_hash): Pass free_demangled_name_entry to
2772         htab_create_alloc.
2773         (symbol_set_names): Call placement new for demangled_name_entry.
2774         * utils.c: No longer include xxhash.h here, now that fast_hash
2775         is inlined in the header.
2776         * utils.h: Instead, include it here.
2777
2778 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
2779
2780         * Makefile.in: Link with libxxhash.
2781         * config.in: Regenerate.
2782         * configure: Regenerate.
2783         * configure.ac: Search for libxxhash.
2784         * utils.c (fast_hash): Use xxhash if present.
2785
2786 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
2787
2788         * utils.h (fast_hash): New function.
2789         * symtab.c (hash_demangled_name_entry): Call new function
2790         fast_hash.
2791
2792 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
2793
2794         * symtab.c (struct demangled_name_entry): Change type of mangled
2795         to gdb::string_view. Also adds a constructor that takes the
2796         mangled name.
2797         (hash_demangled_name_entry): Update.
2798         (eq_demangled_name_entry): Update.
2799         (free_demangled_name_entry): New function to call the destructor
2800         now that this is not a POD anymore.
2801         (create_demangled_names_hash): Pass free_demangled_name_entry to
2802         htab_create_alloc.
2803         (symbol_set_names): Update.
2804
2805 2019-10-21  Ali Tamur  <tamu@google.com>
2806
2807         * dwarf2read.c (dir_index): Change type.
2808         (file_name_index): Likewise.
2809         (line_header::include_dir_at): Change comment and implementation on
2810         whether it is DWARF 5.
2811         (line_header::is_valid_file_index): New function.
2812         (line_header::file_name_at): Change comment and implementation on
2813         whether it is DWARF 5.
2814         (line_header::file_names): Change to private field renamed as
2815         m_file_names and introduce a new accessor method.
2816         (line_header::file_names_size): New method.
2817         (line_header::include_dirs): Change to private field and rename as
2818         m_include_dirs.
2819         (dw2_get_file_names_reader): Define local var at a smaller scope and
2820         reflect API change.
2821         (dwarf2_cu::setup_type_unit_groups): Reflect API change.
2822         (process_structure_scope): Likewise.
2823         (line_header::add_include_dir): Change message and reflect renaming.
2824         (line_header::add_file_name): Likewise.
2825         (read_formatted_entries): Handle DW_FORM_data16.
2826         (dwarf_decode_line_header): Fix line header length calculation.
2827         (psymtab_include_file_name): Change comment and API.
2828         (lnp_state_machine::m_file): Update comment and reflect type change.
2829         (lnp_state_machine::record_line): Reflect type change.
2830         (dwarf_decode_lines): Reflect API change.
2831         (file_file_name): Likewise.
2832         (file_full_name): Likewise.
2833
2834 2019-10-21  Andrew Burgess  <andrew.burgess@embecosm.com>
2835
2836         * objfiles.c (sort_cmp): Ensure that !(a < a) holds true.
2837
2838 2019-10-21  Tom Tromey  <tom@tromey.com>
2839
2840         * tui/tui-winsource.h (tui_exec_info_content): Remove typedef.
2841
2842 2019-10-21  Tom Tromey  <tom@tromey.com>
2843
2844         * configure.ac (nm.h): Conditionally create nm.h link.  Subst
2845         NM_H.   Use AC_CONFIG_LINKS.
2846         * configure: Rebuild.
2847         * Makefile.in (NM_H): New variable.
2848         (generated_files): Add NM_H.  Remove gcore.
2849         (nm.h, stamp-nmh): New targets.
2850
2851 2019-10-20  Tom Tromey  <tom@tromey.com>
2852
2853         * objfiles.h (unlink_objfile, put_objfile_before): Don't declare.
2854         * objfiles.c (unlink_objfile): Move earlier.  Now static.  Remove
2855         obsolete comment.
2856         (put_objfile_before): Now static.
2857
2858 2019-10-19  Simon Marchi  <simon.marchi@polymtl.ca>
2859
2860         * gdbsupport/common-utils.h (startswith): Change return type to
2861         bool.
2862
2863 2019-10-19  Christian Biesinger  <cbiesinger@google.com>
2864
2865         * bcache.c (bcache::print_statistics): Use std::sort instead of qsort.
2866         * breakpoint.c (bp_locations_compare): Rename to...
2867         (bp_location_is_less_than): ...this, and change to std::sort semantics.
2868         (update_global_location_list): Use std::sort instead of qsort.
2869         * buildsym.c (compare_line_numbers): Rename to...
2870         (lte_is_less_than): ...this, and change to std::sort semantics.
2871         (buildsym_compunit::end_symtab_with_blockvector): Use std::sort
2872         instead of qsort.
2873         * disasm.c (compare_lines): Rename to...
2874         (line_is_less_than): ...this, and change to std::sort semantics.
2875         (do_mixed_source_and_assembly_deprecated): Call std::sort instead
2876         of qsort.
2877         * dwarf2-frame.c (qsort_fde_cmp): Rename to...
2878         (fde_is_less_than): ...this, and change to std::sort semantics.
2879         (dwarf2_build_frame_info): Call std::sort instead of qsort.
2880         * mdebugread.c (compare_blocks):
2881         (block_is_less_than): ...this, and change to std::sort semantics.
2882         (sort_blocks): Call std::sort instead of qsort.
2883         * objfiles.c (qsort_cmp): Rename to...
2884         (sort_cmp): ...this, and change to std::sort semantics.
2885         (update_section_map): Call std::sort instead of qsort.
2886         * remote.c (compare_pnums): Remove.
2887         (map_regcache_remote_table): Call std::sort instead of qsort.
2888         * utils.c (compare_positive_ints): Remove.
2889         * utils.h (compare_positive_ints): Remove.
2890         * xcoffread.c (compare_lte): Remove.
2891         (arrange_linetable): Call std::sort instead of qsort.
2892
2893 2019-10-19  Sergio Durigan Junior  <sergiodj@redhat.com>
2894
2895         * symfile.c (init_entry_point_info): Fix typo.
2896         * i386-darwin-tdep.c (darwin_dwarf_signal_frame_p): Fix typo.
2897
2898 2019-10-18  Tom de Vries  <tdevries@suse.de>
2899
2900         * aarch64-tdep.c: Fix typos in comments.
2901         * ada-lang.c: Same.
2902         * ada-tasks.c: Same.
2903         * alpha-tdep.c: Same.
2904         * alpha-tdep.h: Same.
2905         * amd64-nat.c: Same.
2906         * amd64-windows-tdep.c: Same.
2907         * arc-tdep.c: Same.
2908         * arc-tdep.h: Same.
2909         * arch-utils.c: Same.
2910         * arm-nbsd-tdep.c: Same.
2911         * arm-tdep.c: Same.
2912         * ax-gdb.c: Same.
2913         * blockframe.c: Same.
2914         * btrace.c: Same.
2915         * c-varobj.c: Same.
2916         * coff-pe-read.c: Same.
2917         * coffread.c: Same.
2918         * cris-tdep.c: Same.
2919         * darwin-nat.c: Same.
2920         * dbxread.c: Same.
2921         * dcache.c: Same.
2922         * disasm.c: Same.
2923         * dtrace-probe.c: Same.
2924         * dwarf-index-write.c: Same.
2925         * dwarf2-frame-tailcall.c: Same.
2926         * dwarf2-frame.c: Same.
2927         * dwarf2read.c: Same.
2928         * eval.c: Same.
2929         * exceptions.c: Same.
2930         * fbsd-tdep.c: Same.
2931         * findvar.c: Same.
2932         * frame.c: Same.
2933         * frv-tdep.c: Same.
2934         * gnu-v3-abi.c: Same.
2935         * go32-nat.c: Same.
2936         * h8300-tdep.c: Same.
2937         * hppa-tdep.c: Same.
2938         * i386-linux-tdep.c: Same.
2939         * i386-tdep.c: Same.
2940         * ia64-libunwind-tdep.c: Same.
2941         * ia64-tdep.c: Same.
2942         * infcmd.c: Same.
2943         * infrun.c: Same.
2944         * linespec.c: Same.
2945         * linux-nat.c: Same.
2946         * linux-thread-db.c: Same.
2947         * machoread.c: Same.
2948         * mdebugread.c: Same.
2949         * mep-tdep.c: Same.
2950         * mn10300-tdep.c: Same.
2951         * namespace.c: Same.
2952         * objfiles.c: Same.
2953         * opencl-lang.c: Same.
2954         * or1k-tdep.c: Same.
2955         * osabi.c: Same.
2956         * ppc-linux-nat.c: Same.
2957         * ppc-linux-tdep.c: Same.
2958         * ppc-sysv-tdep.c: Same.
2959         * printcmd.c: Same.
2960         * procfs.c: Same.
2961         * record-btrace.c: Same.
2962         * record-full.c: Same.
2963         * remote-fileio.c: Same.
2964         * remote.c: Same.
2965         * rs6000-tdep.c: Same.
2966         * s12z-tdep.c: Same.
2967         * score-tdep.c: Same.
2968         * ser-base.c: Same.
2969         * ser-go32.c: Same.
2970         * skip.c: Same.
2971         * sol-thread.c: Same.
2972         * solib-svr4.c: Same.
2973         * solib.c: Same.
2974         * source.c: Same.
2975         * sparc-nat.c: Same.
2976         * sparc-sol2-tdep.c: Same.
2977         * sparc-tdep.c: Same.
2978         * sparc64-tdep.c: Same.
2979         * stabsread.c: Same.
2980         * stack.c: Same.
2981         * symfile.c: Same.
2982         * symtab.c: Same.
2983         * target-descriptions.c: Same.
2984         * target-float.c: Same.
2985         * thread.c: Same.
2986         * utils.c: Same.
2987         * valops.c: Same.
2988         * valprint.c: Same.
2989         * value.c: Same.
2990         * varobj.c: Same.
2991         * windows-nat.c: Same.
2992         * xcoffread.c: Same.
2993         * xstormy16-tdep.c: Same.
2994         * xtensa-tdep.c: Same.
2995
2996 2019-10-17  Tom Tromey  <tromey@adacore.com>
2997
2998         * configure: Rebuild.
2999         * configure.ac: Use AC_CONFIG_HEADERS.  Create stamp-h there, not
3000         in AC_CONFIG_FILES invocation.
3001         * Makefile.in (Makefile, data-directory/Makefile, stamp-h): Use
3002         new-style config.status invocation.
3003
3004 2019-10-17  Tom de Vries  <tdevries@suse.de>
3005
3006         * arm-nbsd-nat.c: Fix typos in comments.
3007         * arm-tdep.c: Same.
3008         * darwin-nat-info.c: Same.
3009         * dwarf2read.c: Same.
3010         * elfread.c: Same.
3011         * event-top.c: Same.
3012         * findvar.c: Same.
3013         * gdbtypes.c: Same.
3014         * hppa-tdep.c: Same.
3015         * i386-tdep.c: Same.
3016         * jit.c: Same.
3017         * main.c: Same.
3018         * mdebugread.c: Same.
3019         * moxie-tdep.c: Same.
3020         * nto-procfs.c: Same.
3021         * osabi.c: Same.
3022         * ppc-linux-tdep.c: Same.
3023         * remote.c: Same.
3024         * riscv-tdep.c: Same.
3025         * s390-tdep.c: Same.
3026         * sh-tdep.c: Same.
3027         * sparc-linux-tdep.c: Same.
3028         * sparc-nat.c: Same.
3029         * stack.c: Same.
3030         * target-descriptions.c: Same.
3031         * top.c: Same.
3032         * varobj.c: Same.
3033
3034 2019-10-16  Tom Tromey  <tom@tromey.com>
3035
3036         * objfiles.h (struct objfile) <original_name>: Now const.
3037
3038 2019-10-16  Christian Biesinger  <cbiesinger@google.com>
3039
3040         * gdbsupport/gdb_setjmp.h (SIGSETJMP): Allow passing in the value to
3041         pass on to sigsetjmp's second argument.
3042         * cp-support.c (gdb_demangle): Unblock SIGSEGV if we caught a crash.
3043
3044 2019-10-16  Keith Seitz  <keiths@redhat.com>
3045
3046         PR gdb/23567
3047         * dwarf2read.c (dwarf2_per_objfile::locate_sections): Discard
3048         sections whose size is greater than the file size.
3049
3050 2019-10-16  Jim Wilson  <jimw@sifive.com>
3051
3052         * riscv-tdep.c (riscv_gcc_target_options): New.
3053         (riscv_gnu_triplet_regexp): New.
3054         (riscv_gdbarch_init): Call set_gdbarch_gcc_triplet_options and
3055         set_gdbarch_gnu_triplet_regexp.
3056
3057 2019-10-16  Christian Biesinger  <cbiesinger@google.com>
3058
3059         * Makefile.in: Add xml-builtin.h.
3060         * features/feature_to_c.sh: Add an include for xml-builtin.h
3061         to ensure that the compiler checks that the types match.
3062         * xml-builtin.h: New file.
3063         * xml-support.c (fetch_xml_builtin): Add missing const.
3064         * xml-support.h: Remove declaration of xml_builtins.
3065
3066 2019-10-16  Tom de Vries  <tdevries@suse.de>
3067
3068         PR tdep/25096
3069         * amd64-tdep.c (amd64_classify_aggregate_field): Factor out of ...
3070         (amd64_classify_aggregate): ... here.
3071         (amd64_classify_aggregate_field): Handled fiels of nested structs
3072         recursively.
3073
3074 2019-10-16  Tom de Vries  <tdevries@suse.de>
3075
3076         PR tdep/24104
3077         * amd64-tdep.c (amd64_push_arguments): Handle AMD64_NO_CLASS in loop
3078         that handles 'theclass'.
3079
3080 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3081
3082         * linespec.c (decode_digits_ordinary): Update comment.
3083         * make-target-delegates: No longer need to handle VEC case.
3084         * memrange.c (normalize_mem_ranges): Update comment.
3085         * namespace.c (add_using_directive): Update comment.
3086         * objc-lang.c (uniquify_strings): Update comment.
3087         * ppc-linux-nat.c (struct thread_points): Update comment.
3088         * probe.h (find_probes_in_objfile): Update comment.
3089         * target.h (enum flash_preserve_mode): Update comment.
3090         * varobj.c (varobj_restrict_range): Update comment.
3091         * varobj.h (varobj_list_children): Update comment.
3092
3093 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3094
3095         * Makefile.in: Remove references to vec.h and vec.c.
3096         * aarch64-tdep.c: No longer include vec.h.
3097         * ada-lang.c: Likewise.
3098         * ada-lang.h: Likewise.
3099         * arm-tdep.c: Likewise.
3100         * ax.h: Likewise.
3101         * breakpoint.h: Likewise.
3102         * charset.c: Likewise.
3103         * cp-support.h: Likewise.
3104         * dtrace-probe.c: Likewise.
3105         * dwarf2read.c: Likewise.
3106         * extension.h: Likewise.
3107         * gdb_bfd.c: Likewise.
3108         * gdbsupport/gdb_vecs.h: Likewise.
3109         * gdbsupport/vec.c: Remove.
3110         * gdbsupport/vec.h: Remove.
3111         * gdbthread.h: Likewise.
3112         * guile/scm-type.c: Likewise.
3113         * inline-frame.c: Likewise.
3114         * machoread.c: Likewise.
3115         * memattr.c: Likewise.
3116         * memrange.h: Likewise.
3117         * namespace.h: Likewise.
3118         * nat/linux-btrace.h: Likewise.
3119         * osdata.c: Likewise.
3120         * parser-defs.h: Likewise.
3121         * progspace.h: Likewise.
3122         * python/py-type.c: Likewise.
3123         * record-btrace.c: Likewise.
3124         * rust-exp.y: Likewise.
3125         * solib-target.c: Likewise.
3126         * stap-probe.c: Likewise.
3127         * target-descriptions.c: Likewise.
3128         * target-memory.c: Likewise.
3129         * target.h: Likewise.
3130         * varobj.c: Likewise.
3131         * varobj.h: Likewise.
3132         * xml-support.h: Likewise.
3133
3134 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3135
3136         * gdb/dwarf2read.c (dwarf2_per_objfile::~dwarf2_per_objfile):
3137         Update for new std::vector based implementation.
3138         (process_psymtab_comp_unit_reader): Likewise.
3139         (scan_partial_symbols): Likewise.
3140         (recursively_compute_inclusions): Likewise.
3141         (compute_compunit_symtab_includes): Likewise.
3142         (process_imported_unit_die): Likewise.
3143         (queue_and_load_dwo_tu): Likewise.
3144         (follow_die_sig_1): Likewise.
3145         * gdb/dwarf2read.h: Remove DEF_VEC_P.
3146         (typedef dwarf2_per_cu_ptr): Remove.
3147         (struct dwarf2_per_cu_data) <imported_symtabs_empty>: New
3148         function.
3149         (struct dwarf2_per_cu_data) <imported_symtabs_push>: New function.
3150         (struct dwarf2_per_cu_data) <imported_symtabs_size>: New function.
3151         (struct dwarf2_per_cu_data) <imported_symtabs_free>: New function.
3152         (struct dwarf2_per_cu_data) <imported_symtabs>: Change to
3153         std::vector.
3154
3155 2019-10-15  Tom Tromey  <tromey@adacore.com>
3156
3157         * windows-nat.c (windows_nat_target::resume): Use %x when logging
3158         TID.
3159
3160 2019-10-15  Tom Tromey  <tromey@adacore.com>
3161
3162         * windows-nat.c (windows_nat_target::fetch_registers)
3163         (windows_nat_target::store_registers): Rename "pid" to "tid".
3164
3165 2019-10-15  Tom Tromey  <tromey@adacore.com>
3166
3167         * gdbarch.h, gdbarch.c: Rebuild.
3168         * gdbarch.sh (gcc_target_options): Change return type to
3169         std::string.
3170         * compile/compile.c (get_args): Update.
3171         * nios2-tdep.c (nios2_gcc_target_options): Return std::string.
3172         * arm-linux-tdep.c (arm_linux_gcc_target_options): Return
3173         std::string.
3174         * aarch64-linux-tdep.c (aarch64_linux_gcc_target_options): Return
3175         std::string.
3176         * arch-utils.c (default_gcc_target_options): Return std::string.
3177         * arch-utils.h (default_gcc_target_options): Return std::string.
3178         * s390-tdep.c (s390_gcc_target_options): Return std::string.
3179
3180 2019-10-15  Christian Biesinger  <cbiesinger@google.com>
3181
3182         * breakpoint.c (breakpoint_chain): Make static.
3183         * tui/tui-winsource.c: Call iterate_over_breakpoints instead
3184         of accessing breakpoint_chain.
3185
3186 2019-10-15  Christian Biesinger  <cbiesinger@google.com>
3187
3188         * breakpoint.c (iterate_over_breakpoints): Change function pointer
3189         to a gdb::function_view and return value to bool.
3190         * breakpoint.h (iterate_over_breakpoints): Likewise.
3191         * dummy-frame.c (pop_dummy_frame_bpt): Update.
3192         (pop_dummy_frame): Update.
3193         * guile/scm-breakpoint.c (bpscm_build_bp_list): Update.
3194         (gdbscm_breakpoints): Update.
3195         * python/py-breakpoint.c (build_bp_list): Update.
3196         (gdbpy_breakpoints): Update.
3197         * python/py-finishbreakpoint.c (bpfinishpy_detect_out_scope_cb):
3198         Update.
3199         (bpfinishpy_handle_stop): Update.
3200         (bpfinishpy_handle_exit): Update.
3201         * solib-svr4.c (svr4_update_solib_event_breakpoint): Update.
3202         (svr4_update_solib_event_breakpoints): Update.
3203
3204 2019-10-15  Andreas Arnez  <arnez@linux.ibm.com>
3205
3206         * s390-tdep.c (s390_effective_inner_type): Ignore static fields
3207         when unwrapping single-field structs.
3208
3209 2019-10-14  Simon Marchi  <simon.marchi@polymtl.ca>
3210
3211         * dwarf2read.c: Remove includes.
3212
3213 2019-10-13  Simon Marchi  <simon.marchi@polymtl.ca>
3214
3215         * ui-out.c (ui_out::call_do_message): Silence
3216         -Wformat-nonliteral warning.
3217
3218 2019-10-12  Simon Marchi  <simon.marchi@polymtl.ca>
3219
3220         * breakpoint.c: Remove some includes: continuations.h, skip.h,
3221         mi/mi-main.h, readline/readline.h, readline/history.h.  Add
3222         include: readline/tilde.h.
3223
3224 2019-10-12  Christian Biesinger  <cbiesinger@google.com>
3225
3226         * remote.c (remote_target::get_trace_status): Remove declaration of
3227         trace_regblock_size.
3228
3229 2019-10-12  Christian Biesinger  <cbiesinger@google.com>
3230
3231         * cli/cli-cmds.c (max_user_call_depth): Move comment to header.
3232         (show_user): Remove declaration of cmdlist.
3233         * cli/cli-cmds.h (max_user_call_depth): Declare.
3234         * cli/cli-script.c (execute_user_command): Remove declaration
3235         of max_user_call_depth.
3236
3237 2019-10-11  Jim Wilson  <jimw@sifive.com>
3238
3239         * gdbsupport/print-utils.h (pulongest): Fix comment.
3240         (plongest): Likewise.
3241         (phex): Add missing comment, mention leading zeros.
3242         (phex_nz): Add mention of no leading zeros to comment.
3243
3244         * riscv-tdep.c (riscv_push_dummy_code): Change %lld to %s and use
3245         plongest instead of unsigned long long cast.
3246
3247 2019-10-10  Christian Biesinger  <cbiesinger@google.com>
3248
3249         * main.c (captured_main_1): Include gdbtk.h and remove declarations
3250         for external_editor_command and gdbtk_test.
3251
3252 2019-10-10  Christian Biesinger  <cbiesinger@google.com>
3253
3254         * mi/mi-cmd-var.c (varobjdebug): Remove declaration.
3255         * varobj.c (varobjdebug): Move comment to...
3256         * varobj.h (varobjdebug): ...here, and declare.
3257
3258 2019-10-09  Tom Tromey  <tom@tromey.com>
3259
3260         * tui/tui-regs.c (tui_data_window::show_registers): Don't call
3261         erase_data_content.
3262
3263 2019-10-09  Tom Tromey  <tom@tromey.com>
3264
3265         * tui/tui-wingeneral.h (tui_delete_win): Don't declare.
3266         * tui/tui-stack.c (tui_locator_window::rerender): Update.
3267         * tui/tui-command.c (tui_cmd_window::resize)
3268         (tui_refresh_cmd_win): Update.
3269         * tui/tui-win.c (tui_resize_all, tui_set_focus_command): Update.
3270         * tui/tui.c (tui_rl_other_window, tui_enable): Update.
3271         * tui/tui-data.c (~tui_gen_win_info): Remove.
3272         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
3273         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
3274         (tui_redisplay_readline, tui_mld_flush)
3275         (tui_mld_erase_entire_line, tui_mld_getc, tui_getc): Update.
3276         * tui/tui-regs.c (tui_data_window::delete_data_content_windows)
3277         (tui_data_window::erase_data_content)
3278         (tui_data_item_window::rerender)
3279         (tui_data_item_window::refresh_window): Update.
3280         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window)
3281         (box_win, tui_gen_win_info::make_window)
3282         (tui_gen_win_info::make_visible): Update.
3283         (tui_delete_win): Remove.
3284         * tui/tui-winsource.c
3285         (tui_source_window_base::do_erase_source_content): Update.
3286         (tui_show_source_line, tui_source_window_base::update_tab_width)
3287         (tui_source_window_base::update_exec_info): Update.
3288         * tui/tui-data.h (struct curses_deleter): New.
3289         (struct tui_gen_win_info) <handle>: Now a unique_ptr.
3290         (struct tui_gen_win_info) <~tui_gen_win_info>: Define.
3291
3292 2019-10-09  Tom Tromey  <tom@tromey.com>
3293
3294         * tui/tui-wingeneral.h (struct tui_gen_win_info): Don't declare.
3295
3296 2019-10-09  Tom Tromey  <tom@tromey.com>
3297
3298         * tui/tui-data.c (tui_win_is_auxiliary): Remove.
3299         * tui/tui-data.h (tui_win_is_auxiliary): Don't declare.
3300
3301 2019-10-09  Tom Tromey  <tom@tromey.com>
3302
3303         * tui/tui-disasm.c (tui_get_low_disassembly_address): Compute
3304         window height directly.
3305         * tui/tui-layout.h (tui_default_win_viewport_height): Don't
3306         declare.
3307         * tui/tui-layout.c (tui_default_win_height): Remove.
3308         (tui_default_win_viewport_height): Remove.
3309
3310 2019-10-09  Tom Tromey  <tom@tromey.com>
3311
3312         * tui/tui.h: Remove comments.
3313
3314 2019-10-09  Tom de Vries  <tdevries@suse.de>
3315
3316         * python/lib/gdb/printer/bound_registers.py: Use
3317         '^builtin_type_bound128' as regexp argument for
3318         add_builtin_pretty_printer.
3319
3320 2019-10-09  Christian Biesinger  <cbiesinger@google.com>
3321
3322         * guile/guile.c (guile_extension_script_ops): Remove forward
3323         declaration and mark as static.
3324         (guile_script_ops): Likewise.
3325         (extension_language_guile): Move further down in the file so
3326         it can reference the definitions for guile_{extension_,}script_ops.
3327
3328 2019-10-09  Andreas Arnez  <arnez@linux.ibm.com>
3329
3330         * s390-tdep.c (390_process_record): Handle new arch13 instructions
3331         except SORTL, DFLTCC, and KDSA.
3332
3333 2019-10-08  Tom Tromey  <tromey@adacore.com>
3334
3335         * windows-nat.c (struct windows_thread_info_struct) <sf>: Remove.
3336         (struct safe_symbol_file_add_args): Remove.
3337
3338 2019-10-08  Tom Tromey  <tromey@adacore.com>
3339
3340         * windows-nat.c: Don't include buildsym-legacy.h.
3341
3342 2019-10-08  Tom Tromey  <tromey@adacore.com>
3343
3344         * contrib/ari/gdb_ari.sh (%p): Allow gdb-specific %p extensions.
3345
3346 2019-10-08  Christian Biesinger  <cbiesinger@google.com>
3347
3348         * gdbtypes.c (overload_debug): Move comment to header.
3349         * gdbtypes.h (overload_debug): Declare.
3350         * valops.c: Remove declaration of overload_debug, instead
3351         include gdbtypes.h.
3352
3353 2019-10-08  Christian Biesinger  <cbiesinger@google.com>
3354
3355         * language.c (show_language_command): Pass lang_frame_mismatch_warn
3356         through _().
3357         (lang_frame_mismatch_warn): Make const, mark with N_(), and
3358         move comment...
3359         * language.h (lang_frame_mismatch_warn): ... here. Also add
3360         declaration.
3361         * top.c (lang_frame_mismatch_warn): Remove declaration.
3362         (check_frame_language_change): Pass lang_frame_mismatch_warn
3363         through _().
3364
3365 2019-10-07  Christian Biesinger  <cbiesinger@google.com>
3366
3367         * c-lang.h (vtbl_ptr_name): Declare.
3368         * cp-valprint.c (vtbl_ptr_name): Remove "extern" now that we get
3369         it from the header.
3370         * stabsread.c (define_symbol): Remove declaration of vtbl_ptr_name.
3371
3372 2019-10-07  Christian Biesinger  <cbiesinger@google.com>
3373
3374         * charset.c (your_gdb_wchar_t_is_bogus): Replace with a
3375         gdb_static_assert.
3376
3377 2019-10-07  Weimin Pan  <weimin.pan@oracle.com>
3378
3379         * ../Makefile.def (dependencies): Add all-libctf to all-gdb
3380         * ../Makefile.in: Add "all-gdb: maybe-all-libctf"
3381         * ctfread.c: New file.
3382         * ctfread.h: New file.
3383         * elfread.c: Include ctfread.h.
3384         (struct elfinfo text_p): New member ctfsect.
3385         (elf_locate_sections): Mark CTF section.
3386         (elf_symfile_read): Call elfctf_build_psymtabs.
3387         * Makefile.in (LIBCTF): Add.
3388         (CLIBS): Use it.
3389         (CDEPS): Likewise.
3390         (DIST): Add ctfread.c.
3391
3392 2019-10-07  Andrew Burgess  <andrew.burgess@embecosm.com>
3393
3394         * ctfread.c (struct nextfield): Renamed to ...
3395         (struct ctf_nextfield): ... this.
3396         (struct field_info): Renamed to ...
3397         (strut ctf_field_info): ... this.
3398         (attach_fields_to_type): Update for renamed structures.
3399         (ctf_add_member_cb): Likewise.
3400         (ctf_add_enum_member_cb): Likewise.
3401         (process_struct_members): Likewise.
3402         (process_enum_type): Likewise.
3403
3404 2019-10-07  Weimin Pan  <weimin.pan@oracle.com>
3405
3406         * tracectf.h: Rename, was ctf.h.
3407         * tracectf.c: Rename, was ctf.c, replace ctf.h with tracectf.h.
3408         * tracefile.c: Likewise.
3409         * tracepoint.c: Remove unused include ctf.h.
3410         * mi/mi-main.c: Likewise.
3411         * Makefile.in Replace ctf.c with tracectf.c.
3412
3413 2019-10-06  Joel Brobecker  <brobecker@adacore.com>
3414
3415         * version.in: Change version number to "9.0.50.DATE-git".
3416
3417 2019-10-03  Tom Tromey  <tom@tromey.com>
3418
3419         PR rust/24976:
3420         * dwarf2read.c (quirk_rust_enum): Handle single-element unions.
3421
3422 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3423
3424         * f-lang.c (f_language_defn): Use cp_get_symbol_name_matcher and
3425         cp_search_name_hash.
3426         * NEWS: Add entry about nested function support.
3427
3428 2019-10-03  Bernhard Heckel  <bernhard.heckel@intel.com>
3429             Andrew Burgess  <andrew.burgess@embecosm.com>
3430
3431         * cp-namespace.c (cp_search_static_and_baseclasses): Only search
3432         for nested static variables when searchin VAR_DOMAIN.
3433         * dwarf2read.c (add_partial_symbol): Add nested subroutines to the
3434         global scope, update comment.
3435         (add_partial_subprogram): Call add_partial_subprogram recursively
3436         for nested subroutines when processinng Fortran.
3437         (load_partial_dies): Process the child entities of a subprogram
3438         when processing Fortran.
3439         (partial_die_parent_scope): Handle building scope
3440         for Fortran nested functions.
3441         (process_die): Record that nested functions have a scope.
3442         (new_symbol): Always record Fortran subprograms on the global
3443         symbol list.
3444         (determine_prefix): How to build the prefix for Fortran
3445         subprograms.
3446
3447 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3448
3449         * linux-nat.c (linux_nat_filter_event): Don't ignore SIGSTOP if we
3450         have just sent the thread a SIGSTOP and are waiting for it to
3451         arrive.
3452
3453 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3454
3455         * btrace.c (btrace_add_pc): Remove whitespace before the template
3456         parameter in 'std::vector <...>'.
3457         (parse_xml_btrace_block): Likewise.
3458         (btrace_maint_decode_pt): Likewise.
3459         (btrace_maint_update_packets): Likewise.
3460         (btrace_maint_print_packets): Likewise.
3461         * btrace.h (struct btrace_maint_info): Likewise.
3462         * dwarf2read.c (struct type_unit_group): Likewise.
3463         (build_type_psymtabs_reader): Likewise.
3464         * gdbsupport/btrace-common.c (btrace_data_append): Likewise.
3465         * gdbsupport/btrace-common.h (struct btrace_data_bts): Likewise.
3466         * nat/linux-btrace.c (perf_event_read_bts): Likewise.
3467
3468 2019-10-03  Tom de Vries  <tdevries@suse.de>
3469
3470         * cli/cli-style.c (_initialize_cli_style): Adding a '.' at the end of
3471         the first line of the help text for set/show style metadata.
3472
3473 2019-10-02  Tom Tromey  <tromey@adacore.com>
3474
3475         * Makefile.in (COMMON_SFILES): Add common-inferior.c.
3476         * gdbsupport/common-inferior.c: New file.
3477         * infcmd.c (startup_with_shell): Don't define.
3478         * nat/fork-inferior.h (startup_with_shell): Don't declare.
3479         * gdbsupport/common-inferior.h (startup_with_shell): Declare.
3480         * inferior.h (startup_with_shell): Don't declare.
3481
3482 2019-10-02  Christian Biesinger  <cbiesinger@google.com>
3483
3484         * gdbsupport/gdb_assert.h: Include errors.h.
3485         * gdbsupport/gdb_string_view.h: Include gdb_assert.h.
3486
3487 2019-10-02  Tom Tromey  <tromey@adacore.com>
3488
3489         * NEWS: Add $_ada_exception entry.
3490         * ada-lang.c (struct ada_catchpoint): Add constructor.
3491         <m_kind>: New member.
3492         (allocate_location_exception, re_set_exception): Remove
3493         "ex" parameter.
3494         (should_stop_exception): Compute $_ada_exception.
3495         (check_status_exception, print_it_exception)
3496         (print_one_exception, print_mention_exception): Remove
3497         "ex" parameter.
3498         (allocate_location_catch_exception, re_set_catch_exception)
3499         (check_status_exception, print_it_catch_exception)
3500         (print_one_catch_exception, print_mention_catch_exception)
3501         (print_recreate_catch_exception)
3502         (allocate_location_catch_exception_unhandled)
3503         (re_set_catch_exception_unhandled)
3504         (check_status_exception, print_it_catch_exception_unhandled)
3505         (print_one_catch_exception_unhandled)
3506         (print_mention_catch_exception_unhandled)
3507         (print_recreate_catch_exception_unhandled)
3508         (allocate_location_catch_assert, re_set_catch_assert)
3509         (check_status_assert, print_it_catch_assert)
3510         (print_one_catch_assert, print_mention_catch_assert)
3511         (print_recreate_catch_assert)
3512         (allocate_location_catch_handlers, re_set_catch_handlers)
3513         (check_status_handlers, print_it_catch_handlers)
3514         (print_one_catch_handlers, print_mention_catch_handlers)
3515         (print_recreate_catch_handlers): Remove.
3516         (create_ada_exception_catchpoint): Update.
3517         (initialize_ada_catchpoint_ops): Update.
3518
3519 2019-10-02  Tom Tromey  <tromey@adacore.com>
3520
3521         * ada-lang.c (ada_lookup_simple_minsyms): Remove.
3522         (create_excep_cond_exprs): Simplify exception string computation.
3523         (ada_exception_catchpoint_cond_string): Likewise.
3524
3525 2019-10-02  Tom Tromey  <tromey@adacore.com>
3526
3527         * symmisc.c (dump_msymbols): Don't use MSYMBOL_VALUE_ADDRESS.
3528         * ada-lang.c (lesseq_defined_than): Handle
3529         LOC_STATIC.
3530         * dwarf2read.c (dwarf2_per_objfile): Add can_copy
3531         parameter.
3532         (dwarf2_has_info): Likewise.
3533         (new_symbol): Set maybe_copied on symbol when
3534         appropriate.
3535         * dwarf2read.h (dwarf2_per_objfile): Add can_copy
3536         parameter.
3537         <can_copy>: New member.
3538         * elfread.c (record_minimal_symbol): Set maybe_copied
3539         on symbol when appropriate.
3540         (elf_symfile_read): Update call to dwarf2_has_info.
3541         * minsyms.c (lookup_minimal_symbol_linkage): New
3542         function.
3543         * minsyms.h (lookup_minimal_symbol_linkage): Declare.
3544         * symtab.c (get_symbol_address, get_msymbol_address):
3545         New functions.
3546         * symtab.h (get_symbol_address, get_msymbol_address):
3547         Declare.
3548         (SYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_ADDRESS): Handle
3549         maybe_copied.
3550         (struct symbol, struct minimal_symbol) <maybe_copied>:
3551         New member.
3552
3553 2019-10-02  Tom Tromey  <tromey@adacore.com>
3554
3555         * source.c (struct current_source_location): New.
3556         (current_source_key): New global.
3557         (current_source_symtab, current_source_line)
3558         (current_source_pspace): Remove.
3559         (get_source_location): New function.
3560         (get_current_source_symtab_and_line)
3561         (set_default_source_symtab_and_line)
3562         (set_current_source_symtab_and_line)
3563         (clear_current_source_symtab_and_line, select_source_symtab)
3564         (info_source_command, print_source_lines_base)
3565         (info_line_command, search_command_helper, _initialize_source):
3566         Update.
3567
3568 2019-10-02  Tom Tromey  <tromey@adacore.com>
3569
3570         * source.c (select_source_symtab): Don't call
3571         decode_line_with_current_source.
3572
3573 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3574
3575         * symtab.c (lookup_global_symbol): Search global block.
3576
3577 2019-10-02  Tom Tromey  <tromey@adacore.com>
3578
3579         * coffread.c (process_coff_symbol): Update.
3580         * dwarf2read.c (var_decode_location, new_symbol): Update.
3581         * mdebugread.c (parse_symbol): Update.
3582         * objfiles.c (relocate_one_symbol): Update.
3583         * stabsread.c (define_symbol, fix_common_block)
3584         (scan_file_globals): Update.
3585         * symtab.h (SYMBOL_VALUE_ADDRESS): Expand to an rvalue.
3586         (SET_SYMBOL_VALUE_ADDRESS): New macro.
3587         * xcoffread.c (process_xcoff_symbol): Update.
3588
3589 2019-10-02  Andreas Arnez  <arnez@linux.ibm.com>
3590
3591         * MAINTAINERS: Update my email address.
3592
3593 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3594
3595         * dwarf2read.c (struct type_unit_group) <tus>: Convert to
3596         std::vector.
3597         (build_type_psymtabs_reader): Update for std::vector.
3598         (build_type_psymtab_dependencies): Likewise.
3599         * dwarf2read.h: Remove use of DEF_VEC_P.
3600         (typedef sig_type_ptr): Delete.
3601
3602 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3603
3604         * btrace.c (btrace_maint_clear): Update to handle change from VEC
3605         to std::vector.
3606         (btrace_maint_decode_pt): Likewise, and move allocation of the
3607         vector outside of the loop.
3608         (btrace_maint_update_packets): Update to handle change from VEC to
3609         std::vector.
3610         (btrace_maint_print_packets): Likewise.
3611         (maint_info_btrace_cmd): Likewise.
3612         * btrace.h: Remove use of DEF_VEC_O.
3613         (typedef btrace_pt_packet_s): Delete.
3614         (struct btrace_maint_info) <packets>: Change fromm VEC to
3615         std::vector.
3616         * gdbsupport/btrace-common.h: Remove 'vec.h' include.
3617
3618 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3619
3620         * btrace.c (btrace_compute_ftrace_bts): Update for std::vector,
3621         make accesses into the vector constant references.
3622         (btrace_add_pc): Update for std::vector.
3623         (btrace_stitch_bts): Likewise.
3624         (parse_xml_btrace_block): Likewise.
3625         (btrace_maint_update_packets): Likewise.
3626         (btrace_maint_print_packets): Likewise.
3627         (maint_info_btrace_cmd): Likewise.
3628         * gdbsupport/btrace-common.c (btrace_data::fini): Update for
3629         std::vector.
3630         (btrace_data::empty): Likewise.
3631         (btrace_data_append): Likewise.
3632         * gdbsupport/btrace-common.h: Remove use of DEF_VEC_O.
3633         (typedef btrace_block_s): Delete.
3634         (struct btrace_block): Add constructor.
3635         (struct btrace_data_bts) <blocks>: Change to std::vector.
3636         * nat/linux-btrace.c (perf_event_read_bts): Update for
3637         std::vector.
3638         (linux_read_bts): Likewise.
3639
3640 2019-10-01  Tom Tromey  <tom@tromey.com>
3641
3642         * cli/cli-logging.c (show_logging_filename): Use styled_string.
3643
3644 2019-10-01  Tom Tromey  <tom@tromey.com>
3645
3646         * stack.c (print_frame, info_frame_command_core): Use
3647         styled_string.
3648         * linux-thread-db.c (try_thread_db_load_1)
3649         (try_thread_db_load_from_pdir_1): Use styled_string.
3650         * auto-load.c (file_is_auto_load_safe, execute_script_contents)
3651         (auto_load_section_scripts, info_auto_load_local_gdbinit)
3652         (maybe_print_unsupported_script_warning)
3653         (maybe_print_script_not_found_warning): Use styled_string.
3654         * ada-lang.c (user_select_syms): Use styled_string.
3655
3656 2019-10-01  Tom Tromey  <tom@tromey.com>
3657
3658         * p-lang.c (pascal_printstr): Use metadata style.
3659         * value.c (show_convenience): Use metadata style.
3660         * valprint.c (valprint_check_validity, val_print_optimized_out)
3661         (val_print_not_saved, val_print_unavailable)
3662         (val_print_invalid_address, generic_val_print, val_print)
3663         (value_check_printable, val_print_array_elements): Use metadata
3664         style.
3665         * ui-out.h (class ui_out) <field_fmt>: New overload.
3666         <do_field_fmt>: Add style parameter.
3667         * ui-out.c (ui_out::field_fmt): New overload.
3668         * typeprint.c (type_print_unknown_return_type)
3669         (val_print_not_allocated, val_print_not_associated): Use metadata
3670         style.
3671         * tui/tui-out.h (class tui_ui_out) <do_field_fmt>: Add style
3672         parameter.
3673         * tui/tui-out.c (tui_ui_out::do_field_fmt): Update.
3674         * tracepoint.c (tvariables_info_1): Use metadata style.
3675         * stack.c (print_frame_arg, print_frame_info, print_frame)
3676         (info_frame_command_core): Use metadata style.
3677         * skip.c (info_skip_command): Use metadata style.
3678         * rust-lang.c (rust_print_enum): Use metadata style.
3679         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
3680         metadata style.
3681         * python/py-framefilter.c (py_print_single_arg): Use metadata
3682         style.
3683         * printcmd.c (do_one_display, print_variable_and_value): Use
3684         metadata style.
3685         * p-valprint.c (pascal_val_print)
3686         (pascal_object_print_value_fields): Use metadata style.
3687         * p-typeprint.c (pascal_type_print_base): Use metadata style.
3688         * mi/mi-out.h (class mi_ui_out) <do_field_fmt>: Add style
3689         parameter.
3690         * mi/mi-out.c (mi_ui_out::do_field_fmt): Update.
3691         * m2-valprint.c (m2_print_long_set): Use metadata style.
3692         * m2-typeprint.c (m2_print_type): Use metadata style.
3693         * infcmd.c (print_return_value_1): Use metadata style.
3694         * gnu-v3-abi.c (print_one_vtable): Use metadata style.
3695         * f-valprint.c (info_common_command_for_block): Use metadata
3696         style.
3697         * f-typeprint.c (f_type_print_base): Use metadata style.
3698         * expprint.c (print_subexp_standard): Use metadata style.
3699         * cp-valprint.c (cp_print_value_fields): Use metadata style.
3700         * cli/cli-style.h (class cli_style_option): Add constructor.
3701         (metadata_style): Declare.
3702         * cli/cli-style.c (metadata_style): New global.
3703         (_initialize_cli_style): Register metadata style.
3704         * cli-out.h (class cli_ui_out) <do_field_fmt>: Add style
3705         parameter.
3706         * cli-out.c (cli_ui_out::do_field_fmt): Update.
3707         * c-typeprint.c (c_type_print_base_struct_union)
3708         (c_type_print_base_1): Use metadata style.
3709         * breakpoint.c (watchpoint_value_print)
3710         (print_one_breakpoint_location): Use metadata style.
3711         * break-catch-syscall.c (print_one_catch_syscall): Use metadata
3712         style.
3713         * break-catch-sig.c (signal_catchpoint_print_one): Use metadata
3714         style.
3715         * ada-valprint.c (val_print_packed_array_elements, printstr)
3716         (print_field_values, ada_val_print_ref, ada_val_print): Use
3717         metadata style.
3718         * ada-typeprint.c (print_array_type, ada_print_type): Use metadata
3719         style.
3720         * ada-tasks.c (print_ada_task_info, info_task): Use metadata
3721         style.
3722         * ada-lang.c (user_select_syms): Use metadata style.
3723
3724 2019-10-01  Tom Tromey  <tom@tromey.com>
3725
3726         * cli/cli-cmds.c (pwd_command): Style output.
3727
3728 2019-10-01  Pedro Alves  <palves@redhat.com>
3729             Tom Tromey  <tom@tromey.com>
3730
3731         * symtab.c (print_symbol_info): Use %ps.
3732         (print_msymbol_info): Use %ps.
3733         * symfile.c (symbol_file_add_with_addrs): Use %ps.
3734         * printcmd.c (print_variable_and_value): Use %ps.
3735         * macrocmd.c (show_pp_source_pos): Use %ps.
3736         * infrun.c (print_exited_reason): Use ui_out::message.
3737         * breakpoint.c (watchpoint_check, print_one_breakpoint_location)
3738         (describe_other_breakpoints): Use ui_out::message and new
3739         formats.
3740         (say_where): Use new formats.
3741         (bkpt_print_it, tracepoint_print_one_detail): Use ui_out::message
3742         and new formats.
3743
3744 2019-10-01  Pedro Alves  <palves@redhat.com>
3745             Tom Tromey  <tom@tromey.com>
3746
3747         * unittests/format_pieces-selftests.c: Add gdb_format parameter.
3748         (test_gdb_formats): New function.
3749         (run_tests): Call it.
3750         (test_format_specifier): Update.
3751         * utils.h (fputs_filtered): Update comment.
3752         (vfprintf_styled, vfprintf_styled_no_gdbfmt)
3753         (fputs_styled_unfiltered): Declare.
3754         * utils.c (fputs_styled_unfiltered): New function.
3755         (vfprintf_maybe_filtered): Add gdbfmt parameter.
3756         (vfprintf_filtered): Update.
3757         (vfprintf_unfiltered, vprintf_filtered): Update.
3758         (vfprintf_styled, vfprintf_styled_no_gdbfmt): New functions.
3759         * ui-out.h (enum ui_out_flag) <unfiltered_output,
3760         disallow_ui_out_field>: New constants.
3761         (enum class field_kind): New.
3762         (struct base_field_s, struct signed_field_s): New.
3763         (signed_field): New function.
3764         (struct string_field_s): New.
3765         (string_field): New function.
3766         (struct styled_string_s): New.
3767         (styled_string): New function.
3768         (class ui_out) <message>: Add comment.
3769         <vmessage, call_do_message>: New methods.
3770         <do_message>: Add style parameter.
3771         * ui-out.c (ui_out::call_do_message, ui_out::vmessage): New
3772         methods.
3773         (ui_out::message): Rewrite.
3774         * mi/mi-out.h (class mi_ui_out) <do_message>: Add style
3775         parameter.
3776         * mi/mi-out.c (mi_ui_out::do_message): Add style parameter.
3777         * gdbsupport/format.h (class format_pieces) <format_pieces>: Add
3778         gdb_extensions parameter.
3779         (class format_piece): Add parameter to constructor.
3780         (n_int_args): New field.
3781         * gdbsupport/format.c (format_pieces::format_pieces): Add
3782         gdb_extensions parameter.  Handle '*'.
3783         * cli-out.h (class cli_ui_out) <do_message>: Add style parameter.
3784         * cli-out.c (cli_ui_out::do_message): Add style parameter.  Call
3785         vfprintf_styled_no_gdbfmt.
3786         (cli_ui_out::do_field_string, cli_ui_out::do_spaces)
3787         (cli_ui_out::do_text, cli_ui_out::field_separator): Allow
3788         unfiltered output.
3789         * ui-style.h (struct ui_file_style) <ptr>: New method.
3790
3791 2019-10-01  Tom Tromey  <tom@tromey.com>
3792
3793         * unittests/format_pieces-selftests.c: Update.  Add final format.
3794         * gdbsupport/format.c (format_pieces::format_pieces): Don't add
3795         empty literal pieces.
3796
3797 2019-10-01  Tom Tromey  <tom@tromey.com>
3798
3799         * ui-out.h (enum class ui_out_style_kind): Remove.
3800         (class ui_out) <field_string, field_stsream, do_field_string>:
3801         Change type of "style".
3802         * ui-out.c (ui_out::field_core_addr, ui_out::field_stream)
3803         (ui_out::field_string): Update.
3804         * tui/tui-out.h (class tui_ui_out) <do_field_string>: Change type
3805         of "style".
3806         * tui/tui-out.c (tui_ui_out::do_field_string): Update.
3807         * tracepoint.c (print_one_static_tracepoint_marker): Update.
3808         * stack.c (print_frame_arg, print_frame_info, print_frame):
3809         Update.
3810         * source.c (print_source_lines_base): Update.
3811         * solib.c (info_sharedlibrary_command): Update.
3812         * skip.c (info_skip_command): Update.
3813         * record-btrace.c (btrace_call_history_src_line)
3814         (btrace_call_history): Update.
3815         * python/py-framefilter.c (py_print_frame): Update.
3816         * mi/mi-out.h (class mi_ui_out) <do_field_string>: Change type of
3817         "style".
3818         * mi/mi-out.c (mi_ui_out::do_table_header)
3819         (mi_ui_out::do_field_signed, mi_ui_out::do_field_unsigned)
3820         (mi_ui_out::do_field_string): Update.
3821         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
3822         Update.
3823         * cli-out.h (class cli_ui_out) <do_field_string>: Change type of
3824         "style".
3825         * cli-out.c (cli_ui_out::do_table_header)
3826         (cli_ui_out::do_field_signed, cli_ui_out::do_field_unsigned)
3827         (cli_ui_out::do_field_skip, cli_ui_out::do_field_string)
3828         (cli_ui_out::do_field_fmt): Update.
3829         * breakpoint.c (print_breakpoint_location): Update.
3830         (update_static_tracepoint): Update.
3831
3832 2019-10-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3833
3834         * main.c (relocate_gdbinit_path_maybe_in_datadir): Remove std::string
3835         conversion of gdb_datadir.
3836         (captured_main_1): Remove xstrdup when assigning to gdb_datadir,
3837         remove not needed c_str ().
3838
3839 2019-09-30  Ali Tamur <tamur@google.com>
3840
3841         * dwarf2read.c (skip_one_die): Handle DW_FORM_strx forms.
3842         (dwarf2_string_attr): Likewise.
3843
3844 2019-09-30  Ali Tamur <tamur@google.com>
3845
3846         * dwarf2read.c (process_full_comp_unit): Remove whitespace at the EOL.
3847         (process_full_type_unit): Likewise.
3848         (dump_die_shallow): Likewise.
3849         (cu_debug_loc_section): Likewise.
3850
3851 2019-09-28  Christian Biesinger  <cbiesinger@google.com>
3852
3853         * minsyms.c (compare_minimal_symbols): Rename to...
3854         (minimal_symbol_is_less_than): ...this, and adjust to STL
3855         conventions (return bool, take arguments as references)
3856         (minimal_symbol_reader::install): Call std::sort instead
3857         of qsort.
3858
3859 2019-09-29  Christian Biesinger  <cbiesinger@google.com>
3860
3861         * minsyms.h (msymbol_hash): Document that this is a case-insensitive
3862         hash and why.
3863         * objfiles.h (struct objfile_per_bfd_storage) <demangled_names_hash,
3864         msymbol_hash, msymbol_demangled_hash>: Improve comments.
3865
3866 2019-09-30  Simon Marchi  <simon.marchi@polymtl.ca>
3867
3868         * psymtab.c (add_psymbol_to_list): Move comment to psympriv.h.
3869         * psympriv.h (add_psymbol_to_list): Move comment here and update
3870         it.
3871
3872 2019-09-29  Tom de Vries  <tdevries@suse.de>
3873
3874         * contrib/cc-with-tweaks.sh (get_tmpdir): New function.
3875         Use $tmpdir/$(basename "$output_file").dwz instead of
3876         "${output_file}.dwz".
3877
3878 2019-09-28  Simon Marchi  <simon.marchi@polymtl.ca>
3879
3880         PR gdb/25045
3881         * hppa-linux-nat.c: Include gdbarch.h.
3882
3883 2019-09-26  Christian Biesinger  <cbiesinger@google.com>
3884
3885         * blockframe.c (find_pc_partial_function): Change return type to bool.
3886         * elfread.c (elf_gnu_ifunc_resolve_name): Likewise.
3887         * minsyms.c (in_gnu_ifunc_stub): Likewise.
3888         (stub_gnu_ifunc_resolve_name): Likewise.
3889         * symtab.c (compare_filenames_for_search): Likewise.
3890         (compare_glob_filenames_for_search): Likewise.
3891         (matching_obj_sections): Likewise.
3892         (symbol_matches_domain): Likewise.
3893         (find_line_symtab): Change out param EXACT_MATCH to bool *.
3894         (find_line_pc): Change return type to bool.
3895         (find_line_pc_range): Likewise.
3896         (producer_is_realview): Likewise.
3897         * symtab.h (symbol_matches_domain): Likewise.
3898         (find_pc_partial_function): Likewise.
3899         (find_pc_line_pc_range): Likewise.
3900         (in_gnu_ifunc_stub): Likewise.
3901         (struct gnu_ifunc_fns) <gnu_ifunc_resolve_name>: Likewise.
3902         (find_line_pc): Likewise.
3903         (find_line_pc_range): Likewise.
3904         (matching_obj_sections): Likewise.
3905         (find_line_symtab): Change out parameter to bool.
3906         (producer_is_realview): Change return type to bool.
3907         (compare_filenames_for_search): Likewise.
3908         (compare_glob_filenames_for_search): Likewise.
3909
3910 2019-09-26  Tom Tromey  <tom@tromey.com>
3911
3912         * Makefile.in (COMMON_SFILES): Remove gdb_usleep.c.
3913         (HFILES_NO_SRCDIR): Remove gdb_usleep.h.
3914         * gdb_usleep.h: Remove.
3915         * gdb_usleep.c: Remove.
3916         * utils.c: Don't include gdb_usleep.h.
3917
3918 2019-09-26  Tom Tromey  <tromey@adacore.com>
3919
3920         * python/py-type.c (type_to_type_object): Call check_typedef
3921         for stub types.
3922
3923 2019-09-26  Tom Tromey  <tom@tromey.com>
3924
3925         * utils.h (initialize_utils): Don't declare.
3926         * top.c (gdb_init): Don't call initialize_utils.
3927         * utils.c (initialize_utils): Remove.  Move contents...
3928         (_initialize_utils): ... here.
3929
3930 2019-09-25  Tom Tromey  <tom@tromey.com>
3931
3932         * python/py-objfile.c (objfpy_get_build_id): Use bin2hex.
3933         * utils.h (make_hex_string): Don't declare.
3934         * utils.c (make_hex_string): Remove.
3935
3936 2019-09-24  Tom de Vries  <tdevries@suse.de>
3937
3938         PR gdb/23815
3939         * amd64-linux-nat.c (amd64_linux_nat_target::fetch_registers):
3940         Initialize xstateregs before ptrace PTRACE_GETREGSET call.
3941
3942 2019-09-23  Dimitar Dimitrov  <dimitar@dinux.eu>
3943
3944         * NEWS: Mention new simulator port for PRU.
3945
3946 2019-09-23  Christian Biesinger  <cbiesinger@google.com>
3947
3948         * ada-exp.y (write_object_remaining): Update.
3949         * ada-lang.c (ada_decode): Return a std::string instead of a char*
3950         and eliminate the static buffer.
3951         (ada_decode_symbol): Update.
3952         (ada_la_decode): Update.
3953         (ada_sniff_from_mangled_name): Update.
3954         (is_valid_name_for_wild_match): Update.
3955         (ada_lookup_name_info::matches): Update and simplify.
3956         (name_matches_regex): Update.
3957         (ada_add_global_exceptions): Update.
3958         * ada-lang.h (ada_decode): Update signature.
3959         * ada-varobj.c (ada_varobj_describe_simple_array_child): Update.
3960         * dwarf-index-write.c (debug_names::insert): Update.
3961
3962 2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>
3963
3964         * solib-svr4.c (svr4_iterate_over_objfiles_in_search_order): Fix
3965         formatting.
3966
3967 2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>
3968
3969         * breakpoint.h (bp_location) <inserted, permanent, duplicate>:
3970         Change "nonzero" to "true" in documentation.
3971
3972 2019-09-20  Christian Biesinger  <cbiesinger@google.com>
3973
3974         * solib-darwin.c (darwin_lookup_lib_symbol): Remove.
3975         (_initialize_darwin_solib): Don't set
3976         darwin_so_ops.lookup_lib_global_symbol.
3977         * solib-svr4.c (set_solib_svr4_fetch_link_map_offsets): Call
3978         set_gdbarch_iterate_over_objfiles_in_search_order.
3979         (elf_lookup_lib_symbol): Rename to...
3980         (svr4_iterate_over_objfiles_in_search_order): this, and update
3981         to iterate semantics.
3982         (_initialize_svr4_solib): Don't set lookup_lib_global_symbol.
3983         * solib.c (solib_global_lookup): Remove.
3984         * solist.h (struct target_so_ops): Remove lookup_lib_global_symbol.
3985         (solib_global_lookup): Remove.
3986         * symtab.c (lookup_global_or_static_symbol): Remove call to
3987         solib_global_lookup.
3988
3989 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
3990
3991         * NEWS: Move entries about default MI version now being
3992         version 3, and about the GDB/MI fix for multi-location
3993         breakpoints to the "since GDB 8.3" section.
3994
3995 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
3996
3997         GDB 8.3.1 released.
3998
3999 2019-09-20  Ulrich Weigand  <uweigand@de.ibm.com>
4000
4001         * NEWS: Mention that Cell/B.E. debugging support was removed.
4002         * MAINTAINERS: Remove spu target.
4003
4004         * config/djgpp/fnchange.lst: Remove entries for removed files.
4005
4006         * Makefile.in (ALL_TARGET_OBS): Remove solib-spu.o,
4007         spu-multiarch.o, and spu-tdep.o.
4008         (HFILES_NO_SRCDIR): Remove solib-spu.h and spu-tdep.h.
4009         (ALLDEPFILES): Remove solib-spu.c, spu-linux-nat.c,
4010         spu-multiarch.c, and spu-tdep.c.
4011         * spu-linux-nat.c: Remove file.
4012         * spu-multiarch.c: Remove file.
4013         * spu-tdep.c: Remove file.
4014         * spu-tdep.h: Remove file.
4015         * solib-spu.c: Remove file.
4016         * solib-spu.h: Remove file.
4017
4018         * configure.host (powerpc64*-*-linux*): Remove Cell/B.E. support.
4019         * configure.nat (spu-linux): Remove.
4020         * configure.tgt (powerpc*-*-linux*): Remove solib-spu.o and
4021         solib-multiarch.o from gdb_target_obs.
4022         (spu*-*-*): Remove.
4023
4024         * arch/ppc-linux-common.h (struct ppc_linux_features): Remove "cell"
4025         feature flag.
4026         (ppc_linux_no_features): Update.
4027         * arch/ppc-linux-common.c (ppc_linux_match_description): Remove
4028         Cell/B.E. support.
4029         * arch/ppc-linux-tdesc.h (tdesc_powerpc_cell32l): Remove declaration.
4030         (tdesc_powerpc_cell64l): Likewise.
4031         * nat/ppc-linux.h (PPC_FEATURE_CELL): Remove.
4032         * ppc-linux-nat.c (ppc_linux_nat_target::read_description): Remove
4033         Cell/B.E. support.
4034         * ppc-linux-tdep.h: Do not include "solib-spu.h" or "spu-tdep.h".
4035         Do not include "features/rs6000/powerpc-cell32l.c" or
4036         "features/rs6000/powerpc-cell64l.c".
4037         (ppc_linux_spu_section): Remove.
4038         (ppc_linux_core_read_description): Remove Cell/B.E. support.
4039         (spe_context_objfile, spe_context_lm_addr, spe_context_offset,
4040         spe_context_cache_ptid, spe_context_cache_ptid): Remove.
4041         (ppc_linux_spe_context_lookup): Remove.
4042         (ppc_linux_spe_context_inferior_created): Remove.
4043         (ppc_linux_spe_context_solib_loaded): Remove.
4044         (ppc_linux_spe_context_solib_unloaded): Remove.
4045         (ppc_linux_spe_context): Remove.
4046         (struct ppu2spu_cache): Remove.
4047         (ppu2spu_prev_arch, ppu2spu_this_id, ppu2spu_prev_register): Remove.
4048         (struct ppu2spu_data): Remove.
4049         (ppu2spu_unwind_register, ppu2spu_sniffer, ppu2spu_dealloc_cache,
4050         ppu2spu_unwind): Remove.
4051         (ppc_linux_init_abi): Remove Cell/B.E. support.
4052         * rs6000-tdep.h (rs6000_gdbarch_init): Remove Cell/B.E. support.
4053
4054         * features/Makefile (rs6000/powerpc-cell32l-expedite): Remove.
4055         (rs6000/powerpc-cell64l-expedite): Likewise
4056         (WHICH): Remove rs6000/powerpc-cell32l and rs6000/powerpc-cell64l.
4057         (XMLTOC): Remove rs6000/powerpc-cell32l.xml and
4058         rs6000/powerpc-cell64l.xml.
4059         * features/rs6000/powerpc-cell32l.xml: Remove.
4060         * features/rs6000/powerpc-cell64l.xml: Likewise.
4061         * features/rs6000/powerpc-cell32l.c: Remove generated file.
4062         * features/rs6000/powerpc-cell64l.c: Likewise.
4063         * regformats/rs6000/powerpc-cell32l.dat: Remove generated file.
4064         * regformats/rs6000/powerpc-cell64l.dat: Likewise.
4065         * regformats/reg-spu.dat: Remove.
4066
4067         * target.h (enum target_object): Remove TARGET_OBJECT_SPU.
4068         * corelow.c (struct spuid_list): Remove.
4069         (add_to_spuid_list): Remove.
4070         (core_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
4071         * remote.c (PACKET_qXfer_spu_read, PACKET_qXfer_spu_write): Remove.
4072         (remote_protocol_features): Remove associated entries.
4073         (_initialize_remote): No longer initialize them.
4074         (remote_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
4075         * linux-nat.c (SPUFS_MAGIC): Remove.
4076         (linux_proc_xfer_spu): Remove.
4077         (spu_enumerate_spu_ids): Remove.
4078         (linux_nat_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
4079         * linux-tdep.c (-linux_spu_make_corefile_notes): Remove.
4080         (linux_make_corefile_notes): No longer call it.
4081
4082         * regcache.c (cooked_read_test): Remove bfd_arch_spu special case.
4083         (cooked_write_test): Likewise.
4084
4085 2019-09-20  Tom Tromey  <tom@tromey.com>
4086
4087         * NEWS: Mention case-sensitivity of TUI commands.
4088         * tui/tui-win.c (tui_set_focus_command): Now case-sensitive.
4089         (tui_set_win_height_command, parse_scrolling_args): Likewise.
4090         * tui/tui-layout.c (tui_layout_command): Now case-sensitive.
4091
4092 2019-09-20  Tom Tromey  <tom@tromey.com>
4093
4094         * tui/tui-source.c (tui_source_window::set_contents): Use
4095         make_unique_xstrdup.
4096         * tui/tui-disasm.c (tui_disasm_window::set_contents): Use
4097         make_unique_xstrdup.
4098
4099 2019-09-20  Tom Tromey  <tom@tromey.com>
4100
4101         * tui/tui-data.c: Remove separator comments.
4102         * tui/tui-layout.c: Remove separator comments.
4103         * tui/tui-win.c: Remove separator comments.
4104         * tui/tui-wingeneral.c: Remove separator comments.
4105
4106 2019-09-20  Tom Tromey  <tom@tromey.com>
4107
4108         * tui/tui.h (strcat_to_buf): Don't declare.
4109         * tui/tui.c (strcat_to_buf): Remove.
4110
4111 2019-09-20  Tom Tromey  <tom@tromey.com>
4112
4113         * tui/tui-source.h (struct tui_source_window) <m_fullname>: Rename
4114         from "fullname".
4115         * tui/tui-source.c (tui_source_window::set_contents)
4116         (tui_source_window::location_matches_p)
4117         (tui_source_window::maybe_update): Update.
4118
4119 2019-09-20  Tom Tromey  <tom@tromey.com>
4120
4121         * tui/tui-regs.h (struct tui_data_window) <get_current_group>:
4122         Update.
4123         <m_regs_content, m_regs_column_count, m_current_group>: Add "m_"
4124         prefix.
4125         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
4126         (tui_data_window::line_from_reg_element_no)
4127         (tui_data_window::first_reg_element_no_inline)
4128         (tui_data_window::show_registers)
4129         (tui_data_window::show_register_group)
4130         (tui_data_window::display_registers_from)
4131         (tui_data_window::display_registers_from_line)
4132         (tui_data_window::first_data_item_displayed)
4133         (tui_data_window::delete_data_content_windows)
4134         (tui_data_window::erase_data_content)
4135         (tui_data_window::do_scroll_vertical)
4136         (tui_data_window::refresh_window)
4137         (tui_data_window::check_register_values): Update.
4138
4139 2019-09-20  Tom Tromey  <tom@tromey.com>
4140
4141         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN): Remove define.
4142         (struct tui_locator_window) <full_name, proc_name>: Now
4143         std::string.
4144         * tui/tui-stack.c (tui_locator_window::make_status_line)
4145         (tui_locator_window::set_locator_fullname)
4146         (tui_locator_window::set_locator_info): Update.
4147         * tui/tui-source.c (tui_source_window::set_contents)
4148         (tui_source_window::showing_source_p): Update.
4149
4150 2019-09-20  Tom Tromey  <tom@tromey.com>
4151
4152         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
4153         Don't call tui_locator_win_info_ptr.
4154
4155 2019-09-20  Tom Tromey  <tom@tromey.com>
4156
4157         * tui/tui-win.c (tui_resize_all): Don't call refresh.
4158
4159 2019-09-20  Tom Tromey  <tom@tromey.com>
4160
4161         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use 1 as
4162         height for locator.
4163         * tui/tui-stack.c (tui_locator_window::rerender): Call scrollok.
4164         * tui/tui-layout.c (show_source_disasm_command, show_data)
4165         (show_source_or_disasm_and_command): Use 1 as height for locator.
4166
4167 2019-09-20  Tom Tromey  <tom@tromey.com>
4168
4169         * tui/tui.c (tui_enable): Update.
4170         * tui/tui-win.c (tui_sigwinch_handler, tui_async_resize_screen):
4171         Update.
4172         * tui/tui-data.h (tui_win_resized, tui_set_win_resized_to):
4173         Update.
4174         * tui/tui-data.c (win_resized): Now bool.
4175         (tui_win_resized): Return bool.
4176         (tui_set_win_resized_to): Accept a bool.
4177
4178 2019-09-20  Tom Tromey  <tom@tromey.com>
4179
4180         * tui/tui-regs.h (struct tui_data_window) <show_register_group>:
4181         Change type of "refresh_values_only".
4182         * tui/tui-regs.c (tui_data_window::show_register_group): Change
4183         type of "refresh_values_only".
4184
4185 2019-09-20  Tom Tromey  <tom@tromey.com>
4186
4187         * tui/tui-disasm.c (struct tui_asm_line) <addr_string, insn>: Now
4188         std::string.
4189         (tui_disassemble): Add "pos" parameter.
4190         (tui_disasm_window::set_contents): Simplify.
4191
4192 2019-09-20  Tom Tromey  <tom@tromey.com>
4193
4194         * tui/tui-winsource.h (struct tui_source_window_base)
4195         <show_source_content>: Now private.
4196         * tui/tui-winsource.c
4197         (tui_source_window_base::show_source_content): Don't handle empty
4198         content case.
4199
4200 2019-09-20  Tom Tromey  <tom@tromey.com>
4201
4202         * tui/tui-layout.c (show_source_disasm_command)
4203         (show_source_or_disasm_and_command): Don't call
4204         show_source_content.
4205
4206 2019-09-20  Tom Tromey  <tom@tromey.com>
4207
4208         * tui/tui-stack.h (struct tui_locator_window) <make_status_line>:
4209         Declare.
4210         * tui/tui-stack.c (tui_locator_window::make_status_line): Rename
4211         from tui_make_status_line.
4212         (tui_locator_window::rerender): Update.
4213
4214 2019-09-20  Tom Tromey  <tom@tromey.com>
4215
4216         * tui/tui-stack.c (tui_make_status_line): Return std::string.
4217         (tui_locator_window::rerender): Update.
4218
4219 2019-09-20  Tom Tromey  <tom@tromey.com>
4220
4221         * tui/tui-winsource.h (struct tui_source_window_base)
4222         <~tui_source_window_base>: Don't declare.
4223         <fullname>: Remove.
4224         * tui/tui-winsource.c (~tui_source_window_base): Remove.
4225         * tui/tui-source.h (struct tui_source_window) <fullname>: New
4226         member.
4227         * tui/tui-source.c (tui_source_window::set_contents): Update.
4228         (tui_source_window::location_matches_p)
4229         (tui_source_window::maybe_update): Update.
4230
4231 2019-09-20  Tom Tromey  <tom@tromey.com>
4232
4233         * tui/tui-winsource.h (~tui_source_element): Remove.
4234         (tui_source_element): Update.
4235         (struct tui_source_element) <line>: Now a unique_xmalloc_ptr.
4236         * tui/tui-winsource.c (tui_show_source_line): Update.
4237         * tui/tui-source.c (tui_source_window::set_contents): Update.
4238         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
4239
4240 2019-09-20  Tom Tromey  <tom@tromey.com>
4241
4242         * tui/tui-data.h (tui_clear_source_windows_detail): Don't
4243         declare.
4244         * tui/tui-layout.c (tui_add_win_to_layout): Don't call
4245         tui_clear_source_windows_detail.
4246         * tui/tui-winsource.h (struct tui_source_window_base)
4247         <clear_detail>: Don't declare.
4248         * tui/tui-winsource.c (tui_source_window_base::clear_detail):
4249         Remove.
4250         * tui/tui-data.c (tui_clear_source_windows_detail): Remove.
4251
4252 2019-09-20  Tom Tromey  <tromey@adacore.com>
4253
4254         PR ada/24919:
4255         * block.c (contained_in): Fix final return value.
4256
4257 2019-09-20  Alan Modra  <amodra@gmail.com>
4258
4259         * gdb_bfd.c (gdb_bfd_ref, gdb_bfd_unref): Use bfd_set_usrdata.
4260         * dwarf2read.c (dwarf2_read_gdb_index, dwarf2_read_debug_names),
4261         (read_indirect_string_from_dwz): Use bfd accessor.
4262         * dwarf2read.h (struct dwz_file <filename>): Likewise.
4263         * machoread.c (macho_symfile_read_all_oso): Likewise.
4264         * solib.c (solib_bfd_open): Likewise.
4265
4266 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
4267
4268         * eval.c: Move declaration of overload_resolution to...
4269         * value.h: ...here.
4270
4271 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
4272
4273         * arm-linux-nat.c: Remove extern declaration for arm_apcs_32.
4274         * arm-linux-tdep.c: Likewise.
4275         * arm-nbsd-nat.c: Likewise.
4276         * arm-tdep.h: Declare arm_apcs_32.
4277         * arm-tdep.c: Move documentation for arm_apcs_32 to arm-tdep.h.
4278
4279 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
4280
4281         * dwarf2loc.c: Remove extern declaration of dwarf_always_disassemble.
4282         * dwarf2read.h: Declare dwarf_always_disassemble.
4283
4284 2019-09-19  Tom de Vries  <tdevries@suse.de>
4285
4286         PR gdb/25009
4287         * source-cache.c (source_cache::ensure): Catch exception thrown during
4288         construction of the highlighter.
4289
4290 2019-09-18  Alan Modra  <amodra@gmail.com>
4291
4292         * aarch64-linux-tdep.c, * arm-tdep.c, * auto-load.c,
4293         * coff-pe-read.c, * coffread.c, * corelow.c, * dbxread.c,
4294         * dicos-tdep.c, * dwarf2-frame.c, * dwarf2read.c, * elfread.c,
4295         * exec.c, * fbsd-tdep.c, * gcore.c, * gdb_bfd.c, * gdb_bfd.h,
4296         * hppa-tdep.c, * i386-cygwin-tdep.c, * i386-fbsd-tdep.c,
4297         * i386-linux-tdep.c, * jit.c, * linux-tdep.c, * machoread.c,
4298         * maint.c, * mdebugread.c, * minidebug.c, * mips-linux-tdep.c,
4299         * mips-sde-tdep.c, * mips-tdep.c, * mipsread.c, * nto-tdep.c,
4300         * objfiles.c, * objfiles.h, * osabi.c, * ppc-linux-tdep.c,
4301         * ppc64-tdep.c, * record-btrace.c, * record-full.c, * remote.c,
4302         * rs6000-aix-tdep.c, * rs6000-tdep.c, * s390-linux-tdep.c,
4303         * s390-tdep.c, * solib-aix.c, * solib-dsbt.c, * solib-frv.c,
4304         * solib-spu.c, * solib-svr4.c, * solib-target.c,
4305         * spu-linux-nat.c, * spu-tdep.c, * symfile-mem.c, * symfile.c,
4306         * symmisc.c, * symtab.c, * target.c, * windows-nat.c,
4307         * xcoffread.c, * cli/cli-dump.c, * compile/compile-object-load.c,
4308         * mi/mi-interp.c: Update throughout for bfd section macro and
4309         function changes.
4310         * gcore (gcore_create_callback): Use bfd_set_section_lma.
4311         * spu-tdep.c (spu_overlay_new_objfile): Likewise.
4312
4313 2019-09-18  Tom Tromey  <tom@tromey.com>
4314
4315         * NEWS: Add entry.
4316         * tui/tui.c (tui_initialize_readline): Set name of keymap.  Do not
4317         call rl_initialize.
4318         (tui_enable): Do not call rl_initialize.
4319
4320 2019-09-18  Christian Groessler  <chris@groessler.org>
4321
4322         * alpha-linux-nat.c: Include gdbarch.h.
4323
4324 2019-09-18  Simon Marchi  <simon.marchi@polymtl.ca>
4325
4326         * ui-file.c: Include cli/cli-style.h.
4327         (term_cli_styling): Remove cli_styling declaration.
4328
4329 2019-09-18  Alan Modra  <amodra@gmail.com>
4330
4331         * arm-tdep.c (arm_record_special_symbol): Update bfd_get_section
4332         to bfd_asymbol_section.
4333
4334 2019-09-18  Alan Modra  <amodra@gmail.com>
4335
4336         * amd64-dicos-tdep.c (amd64_dicos_osabi_sniffer): Constify target.
4337         * i386-cygwin-tdep.c (i386_cygwin_init_abi): Likewise.
4338         * i386-dicos-tdep.c (i386_dicos_osabi_sniffer): Likewise.
4339
4340 2019-09-18  Alan Modra  <amodra@gmail.com>
4341
4342         * solib-spu.c (spu_bfd_open): Use bfd_set_filename.
4343         * spu-linux-nat.c (spu_bfd_open): Likewise.
4344
4345 2019-09-18  Christian Biesinger  <cbiesinger@google.com>
4346
4347         * dwarf2loc.c: Change extern declaration of dwarf_always_disassemble
4348         to bool to match definition in dwarf2read.c.
4349
4350 2019-09-17  Christian Biesinger  <cbiesinger@google.com>
4351
4352         * ada-lang.c (ada_ignore_descriptive_types_p): Change to bool.
4353         (print_signatures): Likewise.
4354         (trust_pad_over_xvs): Likewise.
4355         * arch/aarch64-insn.c (aarch64_debug): Likewise.
4356         * arch/aarch64-insn.h (aarch64_debug): Likewise.
4357         * arm-linux-nat.c (arm_apcs_32): Likewise.
4358         * arm-linux-tdep.c (arm_apcs_32): Likewise.
4359         * arm-nbsd-nat.c (arm_apcs_32): Likewise.
4360         * arm-tdep.c (arm_debug): Likewise.
4361         (arm_apcs_32): Likewise.
4362         * auto-load.c (debug_auto_load): Likewise.
4363         (auto_load_gdb_scripts): Likewise.
4364         (global_auto_load): Likewise.
4365         (auto_load_local_gdbinit): Likewise.
4366         (auto_load_local_gdbinit_loaded): Likewise.
4367         * auto-load.h (global_auto_load): Likewise.
4368         (auto_load_local_gdbinit): Likewise.
4369         (auto_load_local_gdbinit_loaded): Likewise.
4370         * breakpoint.c (disconnected_dprintf): Likewise.
4371         (breakpoint_proceeded): Likewise.
4372         (automatic_hardware_breakpoints): Likewise.
4373         (always_inserted_mode): Likewise.
4374         (target_exact_watchpoints): Likewise.
4375         (_initialize_breakpoint): Update.
4376         * breakpoint.h (target_exact_watchpoints): Change to bool.
4377         * btrace.c (maint_btrace_pt_skip_pad): Likewise.
4378         * cli/cli-cmds.c (trace_commands): Likewise.
4379         * cli/cli-cmds.h (trace_commands): Likewise.
4380         * cli/cli-decode.c (add_setshow_boolean_cmd): Change int* argument
4381         to bool*.
4382         * cli/cli-logging.c (logging_overwrite): Change to bool.
4383         (logging_redirect): Likewise.
4384         (debug_redirect): Likewise.
4385         * cli/cli-option.h (option_def) <boolean>: Change return type to bool*.
4386         (struct boolean_option_def) <get_var_address_cb_>: Change return type
4387         to bool.
4388         <boolean_option_def>: Update.
4389         (struct flag_option_def): Change default type of Context to bool
4390         from int.
4391         <flag_option_def>: Change return type of var_address_cb_ to bool*.
4392         * cli/cli-setshow.c (do_set_command): Cast to bool* instead of int*.
4393         (get_setshow_command_value_string): Likewise.
4394         * cli/cli-style.c (cli_styling): Change to bool.
4395         (source_styling): Likewise.
4396         * cli/cli-style.h (source_styling): Likewise.
4397         (cli_styling): Likewise.
4398         * cli/cli-utils.h (struct qcs_flags) <quiet, cont, silent>: Change
4399         to bool.
4400         * command.h (var_types): Update comment.
4401         (add_setshow_boolean_cmd): Change int* var argument to bool*.
4402         * compile/compile-cplus-types.c (debug_compile_cplus_types): Change to
4403         bool.
4404         (debug_compile_cplus_scopes): Likewise.
4405         * compile/compile-internal.h (compile_debug): Likewise.
4406         * compile/compile.c (compile_debug): Likewise.
4407         (struct compile_options) <raw>: Likewise.
4408         * cp-support.c (catch_demangler_crashes): Likewise.
4409         * cris-tdep.c (usr_cmd_cris_version_valid): Likewise.
4410         (usr_cmd_cris_dwarf2_cfi): Likewise.
4411         * csky-tdep.c (csky_debug): Likewise.
4412         * darwin-nat.c (enable_mach_exceptions): Likewise.
4413         * dcache.c (dcache_enabled_p): Likewise.
4414         * defs.h (info_verbose): Likewise.
4415         * demangle.c (demangle): Likewise.
4416         (asm_demangle): Likewise.
4417         * dwarf-index-cache.c (debug_index_cache): Likewise.
4418         * dwarf2-frame.c (dwarf2_frame_unwinders_enabled_p): Likewise.
4419         * dwarf2-frame.h (dwarf2_frame_unwinders_enabled_p): Likewise.
4420         * dwarf2read.c (check_physname): Likewise.
4421         (use_deprecated_index_sections): Likewise.
4422         (dwarf_always_disassemble): Likewise.
4423         * eval.c (overload_resolution): Likewise.
4424         * event-top.c (set_editing_cmd_var): Likewise.
4425         (exec_done_display_p): Likewise.
4426         * event-top.h (set_editing_cmd_var): Likewise.
4427         (exec_done_display_p): Likewise.
4428         * exec.c (write_files): Likewise.
4429         * fbsd-nat.c (debug_fbsd_lwp): Likewise
4430         (debug_fbsd_nat): Likewise.
4431         * frame.h (struct frame_print_options) <print_raw_frame_arguments>:
4432         Likewise.
4433         (struct set_backtrace_options) <backtrace_past_main>: Likewise.
4434         <backtrace_past_entry> Likewise.
4435         * gdb-demangle.h (demangle): Likewise.
4436         (asm_demangle): Likewise.
4437         * gdb_bfd.c (bfd_sharing): Likewise.
4438         * gdbcore.h (write_files): Likewise.
4439         * gdbsupport/common-debug.c (show_debug_regs): Likewise.
4440         * gdbsupport/common-debug.h (show_debug_regs): Likewise.
4441         * gdbthread.h (print_thread_events): Likewise.
4442         * gdbtypes.c (opaque_type_resolution): Likewise.
4443         (strict_type_checking): Likewise.
4444         * gnu-nat.c (gnu_debug_flag): Likewise.
4445         * guile/scm-auto-load.c (auto_load_guile_scripts): Likewise.
4446         * guile/scm-param.c (pascm_variable): Add boolval.
4447         (add_setshow_generic): Update.
4448         (pascm_param_value): Update.
4449         (pascm_set_param_value_x): Update.
4450         * hppa-tdep.c (hppa_debug): Change to bool..
4451         * infcall.c (may_call_functions_p): Likewise.
4452         (coerce_float_to_double_p): Likewise.
4453         (unwind_on_signal_p): Likewise.
4454         (unwind_on_terminating_exception_p): Likewise.
4455         * infcmd.c (startup_with_shell): Likewise.
4456         * inferior.c (print_inferior_events): Likewise.
4457         * inferior.h (startup_with_shell): Likewise.
4458         (print_inferior_events): Likewise.
4459         * infrun.c (step_stop_if_no_debug): Likewise.
4460         (detach_fork): Likewise.
4461         (debug_displaced): Likewise.
4462         (disable_randomization): Likewise.
4463         (non_stop): Likewise.
4464         (non_stop_1): Likewise.
4465         (observer_mode): Likewise.
4466         (observer_mode_1): Likewise.
4467         (set_observer_mode): Update.
4468         (sched_multi): Change to bool.
4469         * infrun.h (debug_displaced): Likewise.
4470         (sched_multi): Likewise.
4471         (step_stop_if_no_debug): Likewise.
4472         (non_stop): Likewise.
4473         (disable_randomization): Likewise.
4474         * linux-tdep.c (use_coredump_filter): Likewise.
4475         (dump_excluded_mappings): Likewise.
4476         * linux-thread-db.c (auto_load_thread_db): Likewise.
4477         (check_thread_db_on_load): Likewise.
4478         * main.c (captured_main_1): Update.
4479         * maint-test-options.c (struct test_options_opts) <flag_opt, xx1_opt,
4480         xx2_opt, boolean_opt>: Change to bool.
4481         * maint-test-settings.c (maintenance_test_settings_boolean): Likewise.
4482         * maint.c (maintenance_profile_p): Likewise.
4483         (per_command_time): Likewise.
4484         (per_command_space): Likewise.
4485         (per_command_symtab): Likewise.
4486         * memattr.c (inaccessible_by_default): Likewise.
4487         * mi/mi-main.c (mi_async): Likewise.
4488         (mi_async_1): Likewise.
4489         * mips-tdep.c (mips64_transfers_32bit_regs_p): Likewise.
4490         * nat/fork-inferior.h (startup_with_shell): Likewise.
4491         * nat/linux-namespaces.c (debug_linux_namespaces): Likewise.
4492         * nat/linux-namespaces.h (debug_linux_namespaces): Likewise.
4493         * nios2-tdep.c (nios2_debug): Likewise.
4494         * or1k-tdep.c (or1k_debug): Likewise.
4495         * parse.c (parser_debug): Likewise.
4496         * parser-defs.h (parser_debug): Likewise.
4497         * printcmd.c (print_symbol_filename): Likewise.
4498         * proc-api.c (procfs_trace): Likewise.
4499         * python/py-auto-load.c (auto_load_python_scripts): Likewise.
4500         * python/py-param.c (union parmpy_variable): Add "bool boolval" field.
4501         (set_parameter_value): Update.
4502         (add_setshow_generic): Update.
4503         * python/py-value.c (copy_py_bool_obj): Change argument from int*
4504         to bool*.
4505         * python/python.c (gdbpy_parameter_value): Cast to bool* instead of
4506         int*.
4507         * ravenscar-thread.c (ravenscar_task_support): Change to bool.
4508         * record-btrace.c (record_btrace_target::store_registers): Update.
4509         * record-full.c (record_full_memory_query): Change to bool.
4510         (record_full_stop_at_limit): Likewise.
4511         * record-full.h (record_full_memory_query): Likewise.
4512         * remote-notif.c (notif_debug): Likewise.
4513         * remote-notif.h (notif_debug): Likewise.
4514         * remote.c (use_range_stepping): Likewise.
4515         (interrupt_on_connect): Likewise.
4516         (remote_break): Likewise.
4517         * ser-tcp.c (tcp_auto_retry): Likewise.
4518         * ser-unix.c (serial_hwflow): Likewise.
4519         * skip.c (debug_skip): Likewise.
4520         * solib-aix.c (solib_aix_debug): Likewise.
4521         * spu-tdep.c (spu_stop_on_load_p): Likewise.
4522         (spu_auto_flush_cache_p): Likewise.
4523         * stack.c (struct backtrace_cmd_options) <full, no_filters, hide>:
4524         Likewise.
4525         (struct info_print_options) <quiet>: Likewise.
4526         * symfile-debug.c (debug_symfile): Likewise.
4527         * symfile.c (auto_solib_add): Likewise.
4528         (separate_debug_file_debug): Likewise.
4529         * symfile.h (auto_solib_add): Likewise.
4530         (separate_debug_file_debug): Likewise.
4531         * symtab.c (basenames_may_differ): Likewise.
4532         (struct filename_partial_match_opts) <dirname, basename>: Likewise.
4533         (struct info_print_options) <quiet, exclude_minsyms>: Likewise.
4534         (struct info_types_options) <quiet>: Likewise.
4535         * symtab.h (demangle): Likewise.
4536         (basenames_may_differ): Likewise.
4537         * target-dcache.c (stack_cache_enabled_1): Likewise.
4538         (code_cache_enabled_1): Likewise.
4539         * target.c (trust_readonly): Likewise.
4540         (may_write_registers): Likewise.
4541         (may_write_memory): Likewise.
4542         (may_insert_breakpoints): Likewise.
4543         (may_insert_tracepoints): Likewise.
4544         (may_insert_fast_tracepoints): Likewise.
4545         (may_stop): Likewise.
4546         (auto_connect_native_target): Likewise.
4547         (target_stop_and_wait): Update.
4548         (target_async_permitted): Change to bool.
4549         (target_async_permitted_1): Likewise.
4550         (may_write_registers_1): Likewise.
4551         (may_write_memory_1): Likewise.
4552         (may_insert_breakpoints_1): Likewise.
4553         (may_insert_tracepoints_1): Likewise.
4554         (may_insert_fast_tracepoints_1): Likewise.
4555         (may_stop_1): Likewise.
4556         * target.h (target_async_permitted): Likewise.
4557         (may_write_registers): Likewise.
4558         (may_write_memory): Likewise.
4559         (may_insert_breakpoints): Likewise.
4560         (may_insert_tracepoints): Likewise.
4561         (may_insert_fast_tracepoints): Likewise.
4562         (may_stop): Likewise.
4563         * thread.c (struct info_threads_opts) <show_global_ids>: Likewise.
4564         (make_thread_apply_all_options_def_group): Change argument from int*
4565         to bool*.
4566         (thread_apply_all_command): Update.
4567         (print_thread_events): Change to bool.
4568         * top.c (confirm): Likewise.
4569         (command_editing_p): Likewise.
4570         (history_expansion_p): Likewise.
4571         (write_history_p): Likewise.
4572         (info_verbose): Likewise.
4573         * top.h (confirm): Likewise.
4574         (history_expansion_p): Likewise.
4575         * tracepoint.c (disconnected_tracing): Likewise.
4576         (circular_trace_buffer): Likewise.
4577         * typeprint.c (print_methods): Likewise.
4578         (print_typedefs): Likewise.
4579         * utils.c (debug_timestamp): Likewise.
4580         (sevenbit_strings): Likewise.
4581         (pagination_enabled): Likewise.
4582         * utils.h (sevenbit_strings): Likewise.
4583         (pagination_enabled): Likewise.
4584         * valops.c (overload_resolution): Likewise.
4585         * valprint.h (struct value_print_options) <prettyformat_arrays,
4586         prettyformat_structs, vtblprint, unionprint, addressprint, objectprint,
4587         stop_print_at_null, print_array_indexes, deref_ref, static_field_print,
4588         pascal_static_field_print, raw, summary, symbol_print, finish_print>:
4589         Likewise.
4590         * windows-nat.c (new_console): Likewise.
4591         (cygwin_exceptions): Likewise.
4592         (new_group): Likewise.
4593         (debug_exec): Likewise.
4594         (debug_events): Likewise.
4595         (debug_memory): Likewise.
4596         (debug_exceptions): Likewise.
4597         (useshell): Likewise.
4598         * windows-tdep.c (maint_display_all_tib): Likewise.
4599         * xml-support.c (debug_xml): Likewise.
4600
4601 2019-09-17  Mike Gulick  <mgulick@mathworks.com>
4602
4603         * source.c (prepare_path_for_appending): New function.
4604         (openp): Make use of new function.
4605         (find_and_open_source): Search for the compilation directory and
4606         source file as a relative path beneath the directory search path.
4607
4608 2019-09-17  Andrew Burgess  <andrew.burgess@embecosm.com>
4609
4610         * source-cache.c (source_cache::get_line_charpos): Catch
4611         exceptions and return false, this matches the behaviour documented
4612         in the header file.
4613
4614 2019-09-17  Joel Brobecker  <brobecker@adacore.com>
4615
4616         * ada-tasks.c (info_task): Remove quoting of the task's name.
4617
4618 2019-09-16  Christian Biesinger  <cbiesinger@google.com>
4619
4620         * symfile.c (auto_solib_add): Replace comment with a reference
4621         to the header file.
4622
4623 2019-09-14  Christian Biesinger  <cbiesinger@google.com>
4624
4625         * NEWS: Mention that gdb can now be compiled with Python 3
4626         on Windows.
4627
4628 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4629
4630         * maint.c (maint_print_section_data::maint_print_section_data):
4631         Force use of 'float log10 (float)' by casting the argument to
4632         float.
4633
4634 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4635
4636         * maint.c: Add 'cmath' include.
4637         (struct maint_print_section_data): New structure.
4638         (print_section_index): New function.
4639         (print_bfd_section_info): Add header comment, small whitespace
4640         cleanup, and update to call new print_section_index function.
4641         (print_objfile_section_info): Likewise.
4642         (maint_obj_section_from_bfd_section): New function.
4643         (print_bfd_section_info_maybe_relocated): New function.
4644         (maintenance_info_sections): Add header comment, always use
4645         bfd_map_over_sections instead of ALL_OBJFILE_OSECTIONS.
4646
4647 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4648
4649         * psymtab.c (find_pc_sect_psymtab): Move baseaddr local into more
4650         inner scope, add check that the objfile has psymtabs before
4651         checking psymtabs_addrmap.
4652         * psymtab.h (psymtab_storage) <psymtabs_addrmap>: Extend comment.
4653
4654 2019-09-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4655
4656         * NEWS: Announce that Ada task names are now shown at more places,
4657         and between quotes (except in info task output).
4658         * gdb/ada-tasks.c (task_to_str): New function.
4659         (display_current_task_id): Call task_to_str.
4660         (task_command_1): Likewise.
4661         (print_ada_task_info): In non-mi mode, Properly align headers and data
4662         when task-id length is > 9 (9 is the default for a 32 bits CORE_ADDR).
4663
4664 2019-09-12  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
4665
4666         * procfs.c (procfs_target::wait) <PR_FAULTED>: Get signal from
4667         prstatus.pr_lwp.pr_info instead of making it up.
4668
4669 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
4670
4671         * auto-load.c (auto_load_expand_dir_vars): Update.
4672         * defs.h (gdb_datadir): Change to std::string.
4673         (python_libdir): Likewise.
4674         (relocate_gdb_directory): Change return type to std::string.
4675         * guile/guile.c (gdbscm_data_directory): Update.
4676         (initialize_scheme_side): Update.
4677         * jit.c (jit_reader_dir): Change to std::string.
4678         (jit_reader_load_command): Update.
4679         * main.c (gdb_datadir): Change to std::string.
4680         (python_libdir): Likewise.
4681         (set_gdb_data_directory): Update.
4682         (relocate_path): Change to return std::string.
4683         (relocate_gdb_directory): Change to return std::string.
4684         (relocate_gdbinit_path_maybe_in_datadir): Update.
4685         (captured_main_1): Update.
4686         * python/python.c (do_start_initialization): Update.
4687         * top.c (show_gdb_datadir): Update.
4688         * xml-syscall.c (xml_init_syscalls_info): Update.
4689         (init_syscalls_info): Update.
4690
4691 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
4692
4693         * main.c (relocate_gdbinit_path_maybe_in_datadir): Factor this code
4694         out of get_init_files.
4695         (get_init_files): Update.
4696
4697 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
4698
4699         * main.c (get_init_files): Change to use std::string.
4700         (captured_main_1): Update.
4701         (print_gdb_help): Update.
4702
4703 2019-09-11  Ali Tamur  <tamur@google.com>
4704
4705         *gdb/target-float.c (host_float_ops<T>::to_longest): Update
4706         implementation.
4707
4708 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
4709
4710         * dbxread.c (read_dbx_symtab): Update.
4711         * dwarf2read.c (load_partial_dies): Update.
4712         * mdebugread.c (parse_partial_symbols): Update.
4713         (handle_psymbol_enumerators): Update.
4714         * psympriv.h (add_psymbol_to_list): Change type of copy_names to bool.
4715         * psymtab.c (add_psymbol_to_bcache): Likewise.
4716         (add_psymbol_to_list): Likewise.
4717         * symtab.c (symbol_set_names): Likewise.
4718         * symtab.h (symbol_set_names): Likewise.
4719         * xcoffread.c (scan_xcoff_symtab): Update.
4720
4721 2019-09-11  Tom Tromey  <tom@tromey.com>
4722
4723         * symfile-mem.c (symbol_file_add_from_memory): Use
4724         bfd_set_filename.
4725         * solib-darwin.c (darwin_bfd_open): Use bfd_set_filename.
4726         * solib-aix.c (solib_aix_bfd_open): Use bfd_set_filename.
4727
4728 2019-09-10  Tom Tromey  <tromey@adacore.com>
4729
4730         * dwarf-index-write.c (write_psymbols): Extend error message.
4731         (debug_names::insert): Add Ada code.
4732         (debug_names::write_psymbols): Remove Ada check.
4733         (debug_names) <m_string_obstack>: New member.
4734         * dwarf2read.c (gdb_index_symbol_name_matcher): Remove.
4735         (gdb_index_symbol_name_matcher::matches): Remove.
4736         (mapped_index_base::find_name_components_bounds): Add "lang"
4737         parameter.
4738         (mapped_index_base::build_name_components): Also split names
4739         according to Ada syntax.
4740         (dw2_expand_symtabs_matching_symbol): Loop over languages.  Change
4741         type of "match_callback".
4742         (check_match, check_find_bounds_finds)
4743         (dw2_expand_symtabs_matching): Update.
4744         (dw2_debug_names_iterator): Add new constructor.
4745         (dw2_debug_names_map_matching_symbols): New function.
4746         (dw2_debug_names_expand_symtabs_matching): Update.
4747         (dwarf2_debug_names_functions): Use
4748         dw2_debug_names_map_matching_symbols.
4749
4750 2019-09-10  Tom Tromey  <tromey@adacore.com>
4751
4752         * dwarf2read.c (dw2_get_file_names_reader): Add the
4753         CU's file name to the results.
4754
4755 2019-09-10  Tom Tromey  <tromey@adacore.com>
4756
4757         * ada-lang.c (add_nonlocal_symbols): Combine calls to
4758         map_matching_symbols.  Update.
4759         * dwarf2read.c (dw2_map_matching_symbols): Update.
4760         * psymtab.c (match_partial_symbol): Change type; update.
4761         (psym_map_matching_symbols): Likewise.
4762         * symfile-debug.c (debug_qf_map_matching_symbols): Change
4763         type; update.
4764         * symfile.h (struct quick_symbol_functions)
4765         <map_matching_symbols>: Change "name" to be a lookup_name_info.
4766         Remove "match".
4767
4768 2019-09-10  Tom Tromey  <tromey@adacore.com>
4769
4770         * psymtab.c (map_block): Remove.
4771         (psym_map_matching_symbols): Use iterate_over_symbols_terminated.
4772         * symtab.c (iterate_over_symbols_terminated): New function.
4773         * symtab.c (iterate_over_symbols_terminated): Declare.
4774
4775 2019-09-10  Tom Tromey  <tromey@adacore.com>
4776
4777         * ada-lang.c (ada_iterate_over_symbols): Return bool.
4778         * language.h (struct language_defn) <la_iterate_over_symbols>:
4779         Return bool.
4780         * symtab.c (iterate_over_symbols): Return bool.
4781         * symtab.h (iterate_over_symbols): Return bool.
4782
4783 2019-09-10  Tom Tromey  <tromey@adacore.com>
4784
4785         * ada-lang.c (aux_add_nonlocal_symbols): Change type.
4786         (add_nonlocal_symbols): Update.
4787         * dwarf2read.c (dw2_map_matching_symbols): Change type.
4788         * psymtab.c (map_block, psym_map_matching_symbols): Change type.
4789         * symfile-debug.c (debug_qf_map_matching_symbols): Change type.
4790         * symfile.h (struct quick_symbol_functions) <map_matching_symbols>:
4791         Change type of "callback".  Remove "data".
4792
4793
4794 2019-09-09  Ali Tamur  <tamur@google.com>
4795
4796         * dwarf2read.c (comp_unit_head): Update comment.
4797         (dwarf2_dwo_name): New function declaration.
4798         (dwarf_unit_type_name): New function declaration.
4799         (read_comp_unit_head): Add support for new compilation units,
4800         DW_UT_partial, DW_UT_skeleton, DW_UT_split_compile, DW_UT_split_type.
4801         Particularly, DW_UT_skeleton and DW_UT_split_compile have dwo_id
4802         (currently named as "signature") in their header. Also clarify error
4803         messages.
4804         (lookup_dwo_id): New function. Returns the dwo id of the given
4805         compile unit.
4806         (lookup_dwo_unit): Use the new lookup_dwo_id function.
4807         (init_cutu_and_read_dies): Use the new dwarf2_dwo_name and lookup_dwo_id
4808         functions.
4809         (create_dwo_cu_reader): Use the added lookup_dwo_id function.
4810         (dwarf2_dwo_name): Get the dwo name if present.
4811         (dwarf_unit_type_name): Convert DW_UT_* types to string for diagnostic
4812         purposes.
4813
4814 2019-09-09  Tom Tromey  <tom@tromey.com>
4815
4816         * tui/tui-win.c (tui_all_windows_info): Use ui_out.
4817
4818 2019-09-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4819
4820         * python/python.c (do_start_initialization): Make progname_copy static,
4821         to avoid a leak report.
4822
4823 2019-09-08  Tom Tromey  <tom@tromey.com>
4824
4825         * tui/tui-wingeneral.c (box_win): Truncate long window titles.
4826
4827 2019-09-07  Simon Marchi  <simon.marchi@efficios.com>
4828
4829         * dwarf2read.c (struct dw2_symtab_iterator) <block_index>:
4830         Change type to gdb::optional<block_enum>.
4831         (dw2_symtab_iter_init): Change block_index parameter type
4832         to gdb::optional<block_enum>.
4833         (dw2_lookup_symbol): Change block_index parameter
4834         type to block_enum.c
4835         (dw2_debug_names_lookup_symbol): Likewise.
4836         * psymtab.c (psym_lookup_symbol): Likewise.
4837         * symfile-debug.c (debug_qf_lookup_symbol): Likewise.
4838         * symfile.h (struct quick_symbol_functions) <lookup_symbol>:
4839         Likewise.
4840
4841 2019-09-06  Christian Biesinger  <cbiesinger@google.com>
4842
4843         * defs.h (relocate_gdb_directory): Change int to bool in
4844         signature and rename flag to relocatable.
4845         * main.c (relocate_path): Likewise.
4846         (relocate_gdb_directory): Likewise.
4847
4848 2019-09-06  Alan Modra  <amodra@gmail.com>
4849
4850         * coffread.c (coff_symfile_read): Constify filename variable.
4851         * dbxread.c (dbx_symfile_init, coffstab_build_psymtabs),
4852         (elfstab_build_psymtabs, stabsect_build_psymtabs): Likewise.
4853         * gdb_bfd.c (gdb_bfd_close_or_warn): Likewise.
4854         * solib.c (reload_shared_libraries_1): Likewise.
4855         * symfile.c (reread_symbols): Likewise.
4856         * solib-aix.c (solib_aix_bfd_open): Add cast for xfree of filename.
4857         * solib-darwin.c (darwin_bfd_open): Likewise.
4858         * symfile-mem.c (symbol_file_add_from_memory): Likewise.
4859
4860 2019-09-03  Andrew Burgess  <andrew.burgess@embecosm.com>
4861
4862         * psymtab.c (print_partial_symbols): Handle missing domain_enum
4863         values MODULE_DOMAIN and COMMON_BLOCK_DOMAIN.
4864
4865 2019-09-03  Tom Tromey  <tromey@adacore.com>
4866
4867         * ada-valprint.c (ada_val_print_num): Don't recurse for range
4868         types.
4869         (has_negatives): Unbias a range type bound.
4870         * dwarf2read.c (read_subrange_type): Handle DW_AT_GNU_bias.
4871         * gdbtypes.c (operator==): Handle new field.
4872         (create_range_type): Add "bias" parameter.
4873         (create_static_range_type, resolve_dynamic_range): Update.
4874         * gdbtypes.h (struct range_bounds) <bias>: New member.
4875         (create_range_type): Add bias parameter.
4876         * printcmd.c (print_scalar_formatted): Unbias range types.
4877         * value.c (unpack_long): Unbias range types.
4878         (pack_long): Bias range types.
4879
4880 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
4881
4882         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Check all
4883         probe arguments.
4884
4885 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
4886
4887         * break-catch-throw.c (fetch_probe_arguments): Use gdbarch.
4888         * dtrace-probe.c (dtrace_probe::get_argument_count): Likewise.
4889         * probe.c (probe_safe_evaluate_at_pc) (compute_probe_arg)
4890         (compile_probe_arg): Likewise.
4891         * probe.h (get_argument_count): Likewise.
4892         * solib-svr4.c (solib_event_probe_action): Likewise.
4893         * stap-probe.c (stap_probe::get_argument_count): Likewise.
4894
4895 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
4896
4897         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Move
4898         code to here...
4899         (svr4_create_solib_event_breakpoints): ...from here.
4900
4901 2019-08-30  Sergio Durigan Junior  <sergiodj@redhat.com>
4902
4903         * nat/fork-inferior.c (trace_start_error): Remove "\nError: "
4904         suffix from warning message.
4905
4906 2019-08-30  Tom Tromey  <tom@tromey.com>
4907
4908         * tui/tui-winsource.h (struct tui_source_window_base)
4909         <refresh_all>: Don't declare.
4910         * tui/tui-winsource.c (tui_source_window_base::refresh_all):
4911         Remove.
4912         * tui/tui-win.c (tui_refresh_all_win): Don't call refresh_all or
4913         tui_show_locator_content.
4914         * tui/tui-regs.h (struct tui_data_window) <refresh_all>: Don't
4915         declare.
4916         * tui/tui-regs.c (tui_data_window::refresh_all): Remove.
4917         * tui/tui-data.h (struct tui_win_info) <refresh_all>: Don't
4918         declare.
4919
4920 2019-08-30  Tom Tromey  <tom@tromey.com>
4921
4922         * tui/tui-io.c (tui_cont_sig): Don't call wrefresh.
4923
4924 2019-08-30  Tom Tromey  <tom@tromey.com>
4925
4926         * tui/tui-stack.c (_initialize_tui_stack): Move later.
4927         Remove unnecessary forward declarations.
4928
4929 2019-08-30  Tom Tromey  <tom@tromey.com>
4930
4931         * tui/tui-stack.c (tui_locator_window::set_locator_fullname): Call
4932         rerender.
4933         (tui_update_locator_fullname, tui_show_frame_info): Don't call
4934         tui_show_locator_content.
4935
4936 2019-08-30  Tom Tromey  <tom@tromey.com>
4937
4938         * tui/tui-stack.c (tui_show_locator_content): Move lower.  Rewrite.
4939         (tui_locator_window::rerender): Rewrite using body of previous
4940         tui_show_locator_content.
4941
4942 2019-08-30  Tom Tromey  <tom@tromey.com>
4943
4944         * tui/tui-stack.h (struct tui_locator_window) <set_locator_info,
4945         set_locator_fullname>: New methods.
4946         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
4947         Rename from tui_set_locator_fullname.
4948         (tui_locator_window::set_locator_info): Rename from
4949         tui_set_locator_info.  Return bool.
4950         (tui_update_locator_fullname, tui_show_frame_info): Update.
4951
4952 2019-08-30  Tom Tromey  <tom@tromey.com>
4953
4954         * tui/tui-layout.c (show_layout): Don't call tui_refresh_all.
4955
4956 2019-08-30  Tom Tromey  <tom@tromey.com>
4957
4958         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Don't
4959         call touchwin.
4960
4961 2019-08-30  Tom Tromey  <tom@tromey.com>
4962
4963         * tui/tui-wingeneral.c (box_win): Assume win_info and
4964         win_info->handle cannot be NULL.
4965
4966 2019-08-30  Tom Tromey  <tom@tromey.com>
4967
4968         * tui/tui-regs.h (struct tui_data_item_window) <rerender,
4969         refresh_window>: Declare.
4970         * tui/tui-regs.c (tui_data_window::display_registers_from): Call
4971         resize.
4972         (tui_data_item_window::rerender): Rename from
4973         tui_display_register.
4974         (tui_data_item_window::refresh_window): New method.
4975         * tui/tui-layout.c (tui_gen_win_info::resize): Do nothing on
4976         no-op.
4977
4978 2019-08-30  Tom Tromey  <tom@tromey.com>
4979
4980         * tui/tui-regs.h (struct tui_data_window) <regs_content,
4981         regs_column_count, current_group>: Move later.  Now private.
4982         <get_current_group>: New method.
4983         * tui/tui-regs.c (tui_reg_command): Update.
4984         * tui/tui-layout.c (tui_set_layout): Update.
4985
4986 2019-08-30  Tom Tromey  <tom@tromey.com>
4987
4988         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
4989         (tui_data_window::rerender): Don't call
4990         check_and_display_highlight_if_needed.
4991         (tui_data_window::refresh_all): Remove call to
4992         erase_data_content.
4993
4994 2019-08-30  Tom Tromey  <tom@tromey.com>
4995
4996         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
4997         (tui_data_window::display_registers_from)
4998         (tui_data_window::display_reg_element_at_line)
4999         (tui_data_window::display_registers_from_line): Remove checks of
5000         "empty".
5001
5002 2019-08-30  Tom Tromey  <tom@tromey.com>
5003
5004         * tui/tui-regs.h (struct tui_data_window) <display_all_data>:
5005         Don't declare.
5006         * tui/tui-regs.c (tui_data_window::show_registers): Call
5007         rerender.
5008         (tui_data_window::rerender): Rename from display_all_data.
5009         (tui_data_window::rerender): Remove old implementation.
5010
5011 2019-08-30  Tom Tromey  <tom@tromey.com>
5012
5013         * tui/tui-regs.c (tui_data_window::display_all_data): Change
5014         text.
5015         * tui/tui-data.h (NO_DATA_STRING): Remove define.
5016
5017 2019-08-29  Bernhard Wodok  <barto@gmx.net>
5018             Sergio Durigan Junior  <sergiodj@redhat.com>
5019
5020         PR win32/24284
5021         * mingw-hdep.c (gdb_select): Handle case when 'n' is zero.
5022
5023 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
5024
5025         * symtab.c (search_symbols): Don't include MODULE_DOMAIN symbols
5026         when searching for types.
5027
5028 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
5029
5030         * f-lang.c (f_language_defn): Use f_print_typedef.
5031         * f-lang.h (f_print_typedef): Declare.
5032         * f-typeprint.c (f_print_typedef): Define.
5033
5034 2019-08-27  Christian Biesinger  <cbiesinger@google.com>
5035
5036         * nat/linux-namespaces.c (mnsh_main): Initialize fd (to -1).
5037
5038 2019-08-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5039
5040         * cli/cli-utils.c (info_print_options_defs): Delete.
5041         (make_info_print_options_def_group): Delete.
5042         (extract_info_print_options): Delete.
5043         (info_print_command_completer): Delete.
5044         (info_print_args_help): Add extra parameter, and optionally
5045         include text about -n flag.
5046         * cli/cli-utils.h (struct info_print_options): Delete.
5047         (extract_info_print_options): Delete declaration.
5048         (info_print_command_completer): Delete declaration.
5049         (info_print_args_help): Add extra parameter, extend header
5050         comment.
5051         * python/python.c (gdbpy_rbreak): Pass additional parameter to
5052         search_symbols.
5053         * stack.c (struct info_print_options): New type.
5054         (info_print_options_defs): New file scoped variable.
5055         (make_info_print_options_def_group): New static function.
5056         (info_print_command_completer): New static function.
5057         (info_locals_command): Update to use new local functions.
5058         (info_args_command): Likewise.
5059         (_initialize_stack): Add extra parameter to calls to
5060         info_print_args_help.
5061         * symtab.c (search_symbols): Add extra parameter, use this to
5062         possibly excluse non-debug symbols.
5063         (symtab_symbol_info): Add extra parameter, which is passed on to
5064         search_symbols.
5065         (struct info_print_options): New type.
5066         (info_print_options_defs): New file scoped variable.
5067         (make_info_print_options_def_group): New static function.
5068         (info_print_command_completer): New static function.
5069         (info_variables_command): Update to use local functions, and pass
5070         extra parameter through to symtab_symbol_info.
5071         (info_functions_command): Likewise.
5072         (info_types_command): Pass additional argument through to
5073         symtab_symbol_info.
5074         (rbreak_command): Pass extra argument to search_symbols.
5075         (_initialize_symtab): Add extra arguments for calls to
5076         info_print_args_help, and update help text for 'info variables',
5077         'whereis', and 'info functions' commands.
5078         * symtab.h (search_symbols): Add extra argument to declaration.
5079         * NEWS: Mention new flags.
5080
5081 2019-08-26  Christian Biesinger  <cbiesinger@google.com>
5082
5083         * symtab.c (lookup_static_symbol): Call the new function (and move
5084         it down to be next to lookup_global_symbol).
5085         (struct global_sym_lookup_data): Add block_enum member and rename to...
5086         (struct global_or_static_sym_lookup_data): ...this.
5087         (lookup_symbol_global_iterator_cb): Pass block_index instead of
5088         GLOBAL_BLOCK to lookup_symbol_in_objfile and rename to...
5089         (lookup_symbol_global_or_static_iterator_cb): ...this.
5090         (lookup_global_or_static_symbol): New function.
5091         (lookup_global_symbol): Call new function.
5092
5093 2019-08-26  Tom de Vries  <tdevries@suse.de>
5094
5095         PR c++/24852
5096         * break-catch-throw.c (fetch_probe_arguments): Improve error mesage
5097         when pc_probe.prob == NULL.
5098
5099 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
5100
5101         * dwarf2read.c (dw2_debug_names_iterator::next): Rename local
5102         variable symbol_linkage to symbol_linkage_.
5103
5104 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
5105
5106         * dwarf2read.c (dw2_debug_names_iterator::next): Use enum to
5107         represent whether the symbol is static, dynamic, or we don't
5108         know.
5109
5110 2019-08-25  Yoshinori Sato <ysato@users.sourceforge.jp>
5111
5112         * gdb/rx-tdep.c (rx_register_names): New.
5113         (rx_register_name): Delete.
5114         (rx_psw_type): Delete.
5115         (rx_fpsw_type): Delete.
5116         (rx_register_type): Delete.
5117         (rx_gdbarch_init): Convert target-descriptions.
5118         (_initialize_rx_tdep): Add initialize_tdesc_rx.
5119         * gdb/features/Makefile: Add rx.xml.
5120         * gdb/features/rx.xml: New.
5121         * gdb/features/rx.c: Generated.
5122         * gdb/NEWS: Mention target description support.
5123
5124 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
5125
5126         * symtab.c (symbol_cache_lookup): Always initialize *bsc_ptr and
5127         *slot_ptr.
5128
5129 2019-08-23  Sergio Durigan Junior  <sergiodj@redhat.com>
5130
5131         * configure.ac: Don't check for 'dlfcn.h' (moved to
5132         gdbsupport/common.m4).
5133         * Makefile.in (COMMON_SFILES): Move 'gdb-dlfcn.c' to
5134         'gdbsupport/'.
5135         (HFILES_NO_SRCDIR): Likewise, for 'gdb-dlfcn.h'.
5136         * compile/compile-c-support.c: Include
5137         'gdbsupport/gdb-dlfcn.h'.
5138         * gdbsupport/common.m4: Check for 'dlfcn.h'.
5139         * gdb-dlfcn.c: Move to...
5140         * gdbsupport/gdb-dlfcn.c: ... here.
5141         * gdb-dlfcn.h: Move to...
5142         * gdbsupport/gdb-dlfcn.h: ... here.
5143
5144 2019-08-23  Sandra Loosemore  <sandra@codesourcery.com>
5145
5146         * nios2-tdep.c (struct reg_value): Improve comments.  Make
5147         the offset field signed.
5148
5149 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
5150
5151         * python/lib/gdb/__init__.py (_execute_file): New function.
5152         * python/python.c (python_run_simple_file): Call gdb._execute_file
5153         on Windows.
5154
5155 2019-08-22  Andrew Burgess  <andrew.burgess@embecosm.com>
5156
5157         * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
5158         all uses as this was never set to anything but a zero value.
5159
5160 2019-08-21  Bogdan Harjoc  <harjoc@gmail.com>
5161
5162         * cli/cli-cmds.c (with_command_1): Error out if no arguments.
5163
5164 2019-08-21  Christian Biesinger  <cbiesinger@google.com>
5165
5166         * tui/tui-data.h (tui_gen_win_info): Add an =default
5167         move constructor, required by some GCC versions.
5168
5169 2019-08-21  Jinke Fan  <fanjinke51@yeah.net>
5170
5171         * go32-nat.c (go32_sysinfo): Add hygon_p.
5172
5173 2019-08-20  Tom Tromey  <tom@tromey.com>
5174
5175         * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
5176         line_from_reg_element_no, first_reg_element_no_inline,
5177         display_all_data, delete_data_content_windows,
5178         erase_data_content>: Now private.
5179
5180 2019-08-20  Tom Tromey  <tom@tromey.com>
5181
5182         * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
5183         (tui_unhighlight_win, tui_highlight_win)
5184         (tui_win_info::make_window): Update.
5185         * tui/tui-data.h (HILITE, NO_HILITE): Remove.
5186
5187 2019-08-20  Tom Tromey  <tom@tromey.com>
5188
5189         * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
5190         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
5191         (MAX_PID_WIDTH): Move to tui-stack.c.
5192         * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
5193         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
5194         (MAX_PID_WIDTH): Move from tui-data.h.
5195
5196 2019-08-20  Tom Tromey  <tom@tromey.com>
5197
5198         * tui/tui-wingeneral.h (tui_make_window): Don't declare.
5199         * tui/tui-wingeneral.c (box_win): Change type of win_info.
5200         (box_win): Update.
5201         (tui_gen_win_info::make_window): Rename from tui_make_window.
5202         (tui_win_info::make_window): New method.
5203         (tui_gen_win_info::make_visible): Update.
5204         * tui/tui-source.c (tui_source_window::set_contents): Update.
5205         * tui/tui-regs.c (tui_data_window::show_register_group): Update.
5206         (tui_data_window::display_registers_from): Update.
5207         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
5208         * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
5209         Declare.
5210         <can_box>: Remove.
5211         <title>: Remove.
5212         (struct tui_win_info) <make_window>: Declare.
5213         <can_box>: Now virtual.
5214         <title>: New member.
5215         * tui/tui-data.c (~tui_gen_win_info): Don't free title.
5216         * tui/tui-command.c (tui_cmd_window::resize): Update.
5217
5218 2019-08-20  Tom Tromey  <tom@tromey.com>
5219
5220         * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
5221         * tui/tui-regs.c (tui_data_window::show_registers): Update.
5222         (tui_data_window::check_register_values): Update.
5223
5224 2019-08-20  Tom Tromey  <tom@tromey.com>
5225
5226         * tui/tui-regs.h (struct tui_data_window): Use
5227         DISABLE_COPY_AND_ASSIGN.
5228         <regs_content>: Change type, removing unique_ptr.
5229         <tui_data_window>: Add move constructor.
5230         * tui/tui-regs.c (tui_data_window::show_registers)
5231         (tui_data_window::show_register_group)
5232         (tui_data_window::display_registers_from)
5233         (tui_data_window::display_registers_from)
5234         (tui_data_window::first_data_item_displayed)
5235         (tui_data_window::delete_data_content_windows)
5236         (tui_data_window::rerender, tui_data_window::refresh_window)
5237         (tui_data_window::check_register_values): Update.
5238
5239 2019-08-20  Tom Tromey  <tom@tromey.com>
5240
5241         * tui/tui-regs.h (struct tui_data_window) <show_registers,
5242         show_register_group>: Declare.
5243         (tui_show_register_group): Don't declare.
5244         * tui/tui-regs.c (tui_data_window::show_registers): Rename from
5245         tui_show_registers.
5246         (tui_data_window::show_register_group): Rename from
5247         tui_show_register_group.
5248         (tui_data_window::check_register_values, tui_reg_command):
5249         Update.
5250         * tui/tui-layout.c (tui_set_layout): Update.
5251
5252 2019-08-20  Tom Tromey  <tom@tromey.com>
5253
5254         * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
5255         Declare.
5256         (tui_check_register_values): Don't declare.
5257         * tui/tui-regs.c (tui_data_window::check_register_values): Rename
5258         from tui_check_register_values.
5259         * tui/tui-hooks.c (tui_register_changed): Update.
5260
5261 2019-08-20  Tom Tromey  <tom@tromey.com>
5262
5263         * tui/tui-regs.c (tui_reg_layout): Move later.
5264         (tui_show_registers): Don't enable TUI mode or change layout.
5265
5266 2019-08-20  Tom Tromey  <tom@tromey.com>
5267
5268         * tui/tui-regs.h (struct tui_data_item_window)
5269         <~tui_data_item_window>: Remove.
5270         <content>: Now a unique_xmalloc_ptr.
5271         * tui/tui-regs.c (tui_register_format): Return a
5272         unique_xmalloc_ptr.
5273         (tui_get_register): Update.
5274         (~tui_data_item_window): Remove.
5275         (tui_data_window::display_registers_from, tui_display_register):
5276         Update.
5277         * tui/tui-io.h (tui_expand_tabs): Update.
5278         * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
5279         Remove "col" parameter.
5280
5281 2019-08-20  Tom Tromey  <tom@tromey.com>
5282
5283         * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
5284         field.
5285         * tui/tui-regs.c (~tui_data_item_window): Update.
5286
5287 2019-08-20  Tom Tromey  <tom@tromey.com>
5288
5289         * tui/tui-regs.c (tui_register_format, tui_get_register): Move
5290         earlier.
5291
5292 2019-08-20  Tom Tromey  <tom@tromey.com>
5293
5294         * tui/tui-regs.c (tui_reg_command): Remove NULL check.
5295
5296 2019-08-20  Tom Tromey  <tom@tromey.com>
5297
5298         * tui/tui-source.h (struct tui_source_window): Update.
5299         * tui/tui-regs.c (tui_show_registers): Update.
5300         * tui/tui-disasm.h (struct tui_disasm_window): Update.
5301         * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
5302         (NO_REGS_STRING): Remove defines.
5303
5304 2019-08-20  Conrad Meyer  <cem@FreeBSD.org>
5305
5306         * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
5307         unnecessary thread walk if remote doesn't support the packet.
5308
5309 2019-08-19  Tom Tromey  <tromey@adacore.com>
5310
5311         * python/py-value.c (value_has_field): Fix indentation.
5312
5313 2019-08-19  Tom Tromey  <tromey@adacore.com>
5314
5315         * printcmd.c (do_one_display, info_display_command): Update.
5316         * block.h (contained_in): Return bool.  Add allow_nested
5317         parameter.
5318         * block.c (contained_in): Return bool.  Add allow_nested
5319         parameter.
5320
5321 2019-08-19  Tom Tromey  <tom@tromey.com>
5322
5323         * configure: Rebuild.
5324         * configure.ac: Disallow the combination of -static-libstdc++ and
5325         source highlight.
5326         * source-cache.c (get_language_name): Handle rust.
5327         (source_cache::get_source_lines): Ignore highlighting exceptions.
5328
5329 2019-08-16  Tom Tromey  <tom@tromey.com>
5330
5331         * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
5332         * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
5333         (struct tui_source_window_base) <make_visible, refresh_window,
5334         resize>: Remove methods.
5335         <execution_info>: Remove field.
5336         * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
5337         (tui_show_source_line, tui_source_window_base)
5338         (~tui_source_window_base): Update.
5339         (tui_source_window_base::resize)
5340         (tui_source_window_base::make_visible)
5341         (tui_source_window_base::refresh_window): Remove.
5342         (tui_source_window_base::update_exec_info): Update.
5343         * tui/tui-source.c (tui_source_window::set_contents): Update.
5344         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
5345
5346 2019-08-16  Tom Tromey  <tom@tromey.com>
5347
5348         * tui/tui-hooks.c (tui_remove_hooks): Don't set
5349         deprecated_query_hook.
5350
5351 2019-08-16  Tom Tromey  <tom@tromey.com>
5352
5353         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
5354         (tui_update_source_windows_with_line): Update.
5355         * tui/tui-source.h (struct tui_source_window)
5356         <show_symtab_source>: Declare.
5357         (tui_show_symtab_source): Don't declare.
5358         * tui/tui-source.c (tui_show_symtab_source): Rename from
5359         tui_show_symtab_source.
5360
5361 2019-08-16  Tom Tromey  <tom@tromey.com>
5362
5363         * tui/tui-winsource.h (struct tui_source_window_base)
5364         <set_contents>: Declare.
5365         * tui/tui-winsource.c
5366         (tui_source_window_base::update_source_window_as_is): Update.
5367         * tui/tui-source.h (struct tui_source_window) <set_contents>:
5368         Declare.
5369         (tui_set_source_content): Don't declare.
5370         * tui/tui-source.c (tui_source_window::set_contents): Rename from
5371         tui_set_source_content.
5372         * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
5373         Declare.
5374         (tui_set_disassem_content): Don't declare.
5375         * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
5376         tui_set_disassem_content.
5377
5378 2019-08-16  Tom Tromey  <tom@tromey.com>
5379
5380         * tui/tui-winsource.h (struct tui_source_window_base)
5381         <update_breakpoint_info>: Declare.
5382         (tui_update_breakpoint_info): Don't declare.
5383         * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
5384         (tui_update_all_breakpoint_info): Update.
5385         (tui_source_window_base::update_breakpoint_info): Rename from
5386         tui_update_breakpoint_info.
5387         (tui_source_window_base::update_exec_info): Update.
5388
5389 2019-08-16  Tom Tromey  <tom@tromey.com>
5390
5391         * tui/tui-winsource.h (struct tui_source_window_base)
5392         <update_source_window>: Declare.
5393         (tui_update_source_window): Don't declare.
5394         * tui/tui-winsource.c
5395         (tui_source_window_base::update_source_window): Rename from
5396         tui_update_source_window.
5397         (tui_source_window_base::rerender): Update.
5398         * tui/tui-source.c (tui_source_window::maybe_update): Update.
5399         * tui/tui-disasm.c (tui_show_disassem)
5400         (tui_show_disassem_and_update_source)
5401         (tui_disasm_window::maybe_update): Update.
5402
5403 2019-08-16  Tom Tromey  <tom@tromey.com>
5404
5405         * tui/tui-winsource.h (struct tui_source_window_base)
5406         <update_source_window_as_is>: Declare.
5407         (tui_update_source_window_as_is): Don't declare.
5408         * tui/tui-winsource.c (tui_update_source_window): Update
5409         (tui_source_window_base::update_source_window_as_is): Rename from
5410         tui_update_source_window_as_is.
5411         (tui_source_window_base::refill): Update.
5412         * tui/tui-source.c (tui_show_symtab_source): Update.
5413         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
5414         Update.
5415
5416 2019-08-16  Tom Tromey  <tom@tromey.com>
5417
5418         * tui/tui-winsource.h (tui_update_source_window)
5419         (tui_update_source_window_as_is): Remove "noerror" parameter.
5420         * tui/tui-winsource.c (tui_update_source_window)
5421         (tui_update_source_window_as_is): Remove "noerror" parameter.
5422         (tui_update_source_windows_with_addr)
5423         (tui_update_source_windows_with_line)
5424         (tui_source_window_base::rerender)
5425         (tui_source_window_base::refill): Update.
5426         * tui/tui-source.h (tui_set_source_content)
5427         (tui_show_symtab_source): Remove "noerror" parameter.
5428         * tui/tui-source.c (tui_set_source_content): Remove "noerror"
5429         parameter.
5430         (tui_show_symtab_source): Likewise.
5431         (tui_source_window::maybe_update): Update.
5432         * tui/tui-disasm.c (tui_show_disassem)
5433         (tui_show_disassem_and_update_source)
5434         (tui_disasm_window::do_scroll_vertical)
5435         (tui_disasm_window::maybe_update): Update.
5436
5437 2019-08-16  Tom Tromey  <tom@tromey.com>
5438
5439         * tui/tui.c (tui_is_window_visible): Update.
5440         * tui/tui-wingeneral.c (tui_make_window)
5441         (tui_gen_win_info::make_visible, tui_refresh_all): Update.
5442         * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
5443         (tui_set_focus_command, tui_all_windows_info, update_tab_width)
5444         (tui_set_win_height_command, parse_scrolling_args): Update.
5445         * tui/tui-source.c (tui_source_window::style_changed): Update.
5446         * tui/tui-regs.c (tui_show_registers)
5447         (tui_data_window::first_data_item_displayed)
5448         (tui_data_window::delete_data_content_windows)
5449         (tui_check_register_values, tui_reg_command): Update.
5450         * tui/tui-disasm.c (tui_show_disassem): Update.
5451         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
5452         method.
5453         <is_visible>: Remove field.
5454         * tui/tui-data.c (tui_next_win, tui_prev_win)
5455         (tui_delete_invisible_windows): Update.
5456
5457 2019-08-16  Tom Tromey  <tom@tromey.com>
5458
5459         * tui/tui-winsource.h (struct tui_source_window_base)
5460         <m_has_locator>: Remove.
5461         * tui/tui-layout.c (show_source_disasm_command, show_data)
5462         (show_source_or_disasm_and_command): Update.
5463
5464 2019-08-16  Alan Hayward  <alan.hayward@arm.com>
5465
5466         * NEWS (Other MI changes): New subsection.
5467         * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
5468         (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
5469         * arch-utils.c (default_get_pc_address_flags): New function.
5470         * arch-utils.h (default_get_pc_address_flags): New declaration.
5471         * gdbarch.sh: Add get_pc_address_flags.
5472         * gdbarch.c: Regenerate.
5473         * gdbarch.h: Likewise.
5474         * stack.c (print_pc): New function.
5475         (print_frame_info) (print_frame): Call print_pc.
5476
5477 2019-08-16  Tom de Vries  <tdevries@suse.de>
5478
5479         * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
5480         print_objfile_section_info.
5481
5482 2019-08-15  Tom Tromey  <tom@tromey.com>
5483
5484         * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
5485         calling update_cmdwin_start_line.
5486         * tui/tui-winsource.h (struct tui_source_window_base)
5487         <do_make_visible_with_new_height, set_new_height>: Don't declare.
5488         <rerender>: Declare.
5489         * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
5490         Call rerender.
5491         (tui_source_window_base::set_new_height): Remove.
5492         (tui_source_window_base::rerender): Rename from
5493         do_make_visible_with_new_height.
5494         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
5495         resize method.
5496         (tui_win_info::make_invisible_and_set_new_height)
5497         (tui_win_info::make_visible_with_new_height): Remove.
5498         * tui/tui-stack.h (struct tui_locator_window) <rerender>:
5499         Declare.
5500         * tui/tui-stack.c (tui_locator_window::rerender): New method.
5501         * tui/tui-regs.h (struct tui_data_window) <set_new_height,
5502         do_make_visible_with_new_height>: Don't declare.
5503         <rerender>: Declare.
5504         * tui/tui-regs.c (tui_data_window::rerender): Rename from
5505         set_new_height.
5506         (tui_data_window::do_make_visible_with_new_height): Remove.
5507         * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
5508         call tui_show_locator_content.
5509         (tui_gen_win_info::resize): Call rerender.
5510         (show_source_or_disasm_and_command): Don't call
5511         tui_show_locator_content.
5512         * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
5513         method.
5514         (struct tui_win_info) <rerender>: Declare.
5515         <set_new_height, make_invisible_and_set_new_height,
5516         make_visible_with_new_height>: Don't declare.
5517         * tui/tui-data.c (tui_win_list::rerender): New method.
5518         * tui/tui-command.h (struct tui_cmd_window)
5519         <do_make_visible_with_new_height>: Don't declare.
5520         * tui/tui-command.c
5521         (tui_cmd_window::do_make_visible_with_new_height): Remove.
5522
5523 2019-08-15  Tom Tromey  <tromey@adacore.com>
5524
5525         * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
5526         * ada-lang.c (ada_enum_name): Likewise.
5527
5528 2019-08-15  Christian Biesinger  <cbiesinger@google.com>
5529
5530         * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
5531         leading underscore.
5532         (GdbOutputErrorFile): Likewise.
5533         (global scope): Adjust constructor calls to GdbOutput{,Error}File
5534         accordingly.
5535         (execute_unwinders): Rename to have a leading underscore.
5536         (auto_load_packages): Likewise.
5537         (global scope): Adjust call to auto_load_packages accordingly.
5538         (GdbSetPythonDirectory): Likewise.
5539         * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
5540         instead of execute_unwinders.
5541
5542 2019-08-15  Tom Tromey  <tom@tromey.com>
5543
5544         * tui/tui-layout.c (show_layout, show_source_disasm_command)
5545         (show_data): Don't change window visibility.
5546         (tui_gen_win_info::resize): Remove special case for command
5547         window.  Use wresize, when available.
5548         (show_source_or_disasm_and_command): Don't change window
5549         visibility.
5550         * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
5551         <make_visible>: New method.
5552         * tui/tui-command.c (tui_cmd_window::resize): New method.
5553
5554 2019-08-15  Tom Tromey  <tom@tromey.com>
5555
5556         * tui/tui-winsource.h (struct tui_source_window_iterator): New.
5557         (struct tui_source_windows): New.
5558         * tui/tui-winsource.c (tui_display_main): Update.
5559         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
5560         (new_height_ok, parse_scrolling_args): Update.
5561         * tui/tui-layout.c (show_layout, show_data): Update.
5562         * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
5563         (tui_add_to_source_windows): Don't declare.
5564         * tui/tui-data.c (source_windows, tui_source_windows)
5565         (tui_clear_source_windows, tui_add_to_source_windows): Remove.
5566
5567 2019-08-15  Tom Tromey  <tom@tromey.com>
5568
5569         * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
5570         Rename from reset.
5571         * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
5572         * tui/tui-layout.c (show_source_disasm_command, show_data):
5573         Update.
5574         (tui_gen_win_info::resize): Rename.
5575         (show_source_or_disasm_and_command): Update.
5576         * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
5577         reset.
5578
5579 2019-08-15  Tom Tromey  <tom@tromey.com>
5580
5581         * tui/tui-stack.c (tui_initialize_static_data): Remove.
5582         * tui/tui-interp.c (tui_interp::init): Don't call
5583         tui_initialize_static_data.
5584         * tui/tui-data.h (tui_initialize_static_data): Don't declare.
5585
5586 2019-08-15  Tom Tromey  <tom@tromey.com>
5587
5588         * tui/tui-layout.c (tui_default_win_viewport_height): Don't
5589         examine tui_win_list.
5590
5591 2019-08-15  Tom Tromey  <tom@tromey.com>
5592
5593         * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
5594         * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
5595         tui_clear_source_content.
5596         (tui_clear_source_content): Remove.
5597         (tui_source_window_base::do_erase_source_content): Hoist call to
5598         content.clear().
5599         * tui/tui-stack.c (tui_show_frame_info): Don't call
5600         tui_clear_source_content.
5601
5602 2019-08-15  Tom Tromey  <tom@tromey.com>
5603
5604         * tui/tui-winsource.h (struct tui_source_window_base)
5605         <do_erase_source_content>: New method.
5606         <erase_source_content>: New method.
5607         (tui_erase_source_content): Don't declare.
5608         * tui/tui-winsource.c (tui_clear_source_content): Update.
5609         (tui_source_window_base::do_erase_source_content): Rename from
5610         tui_erase_source_content.
5611         (tui_source_window_base::show_source_content): Update.
5612         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
5613         * tui/tui-source.h (struct tui_source_window)
5614         <erase_source_content>: New method.
5615         * tui/tui-disasm.h (struct tui_disasm_window)
5616         <erase_source_content>: New method.
5617
5618 2019-08-15  Tom Tromey  <tom@tromey.com>
5619
5620         * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
5621         (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
5622         constructor.
5623         * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
5624         * tui/tui-source.c (tui_set_source_content): Update.
5625         * tui/tui-disasm.c (tui_set_disassem_content): Update.
5626
5627 2019-08-15  Tom Tromey  <tom@tromey.com>
5628
5629         * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
5630         * tui/tui-winsource.c (tui_line_is_displayed): Move to
5631         tui-source.c.
5632         * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
5633         Declare.
5634         * tui/tui-source.c (tui_source_window::line_is_displayed): New
5635         method.
5636         (tui_source_window::maybe_update): Update.
5637
5638 2019-08-15  Tom Tromey  <tom@tromey.com>
5639
5640         * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
5641         * tui/tui-winsource.c (tui_addr_is_displayed): Move to
5642         tui-disasm.c.
5643         * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
5644         Declare.
5645         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
5646         method.
5647         (tui_disasm_window::maybe_update): Update.
5648
5649 2019-08-15  Tom Tromey  <tom@tromey.com>
5650
5651         * tui/tui-winsource.h (struct tui_source_window_base)
5652         <maybe_update>: Declare.
5653         * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
5654         method.
5655         * tui/tui-source.h (struct tui_source_window) <maybe_update>:
5656         Declare.
5657         * tui/tui-source.c (tui_source_window::maybe_update): New method.
5658         * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
5659         Declare.
5660         * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
5661
5662 2019-08-15  Tom Tromey  <tom@tromey.com>
5663
5664         * tui/tui-stack.c (tui_make_status_line): Use string constructor.
5665
5666 2019-08-15  Tom Tromey  <tom@tromey.com>
5667
5668         * tui/tui-wingeneral.c: Include tui-stack.h.
5669         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
5670         (struct tui_locator_window): Move from tui-data.h.
5671         * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
5672         (tui_initialize_static_data): Move from tui-data.c.
5673         * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
5674         (struct tui_locator_window): Move to tui-stack.c.
5675         * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
5676         (tui_initialize_static_data): Move to tui-stack.c.
5677
5678 2019-08-15  Tom Tromey  <tom@tromey.com>
5679
5680         * tui/tui-layout.c (show_source_disasm_command)
5681         (show_source_or_disasm_and_command): Use make_visible method, not
5682         tui_make_window.
5683         * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
5684         Remove.
5685
5686 2019-08-15  Tom Tromey  <tom@tromey.com>
5687
5688         * tui/tui-wingeneral.h (tui_make_window): Update.
5689         * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
5690         parameter.
5691         (tui_gen_win_info::make_visible): Update.
5692         * tui/tui-regs.c (tui_data_window::display_registers_from):
5693         Update.
5694         * tui/tui-layout.c (show_source_disasm_command)
5695         (show_source_or_disasm_and_command): Update.
5696         * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
5697         (enum tui_box): Remove.
5698         (struct tui_win_info) <can_box>: New method.
5699         * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
5700         method.
5701
5702 2019-08-15  Tom de Vries  <tdevries@suse.de>
5703
5704         * linux-nat-trad.c: Include gdbarch.h.
5705
5706 2019-08-14  Alan Hayward  <alan.hayward@arm.com>
5707
5708         * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
5709         register sizes.
5710
5711 2019-08-14  Tom Tromey  <tromey@adacore.com>
5712
5713         * darwin-nat.c: Include gdbarch.h.
5714         * darwin-nat-info.c: Include gdbarch.h.
5715
5716 2019-08-13  Tom Tromey  <tom@tromey.com>
5717
5718         * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
5719         Remove.
5720         * tui/tui-data.c (tui_initialize_static_data): Update.
5721
5722 2019-08-13  Tom Tromey  <tom@tromey.com>
5723
5724         * tui/tui-winsource.h (struct tui_exec_info_window)
5725         <~tui_exec_info_window, maybe_allocate_content, get_content,
5726         m_content>: Remove.
5727         (struct tui_source_window_base) <set_exec_info_content,
5728         show_exec_info_content>: Don't declare.
5729         * tui/tui-winsource.c
5730         (tui_exec_info_window::maybe_allocate_content): Remove.
5731         (tui_source_window_base::update_exec_info): Rename from
5732         set_exec_info_content.
5733         (tui_source_window_base::show_exec_info_content)
5734         (tui_source_window_base::update_exec_info): Remove.
5735
5736 2019-08-13  Tom Tromey  <tom@tromey.com>
5737
5738         * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
5739         declare.
5740         * tui/tui-winsource.c (tui_update_source_window_as_is)
5741         (tui_update_source_windows_with_addr, tui_erase_source_content):
5742         Update.
5743         (tui_clear_exec_info_content): Remove.
5744
5745 2019-08-13  Tom Tromey  <tom@tromey.com>
5746
5747         * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
5748         declare.
5749         * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
5750         call tui_erase_exec_info_content.
5751         (tui_clear_exec_info_content): Rename from
5752         tui_erase_exec_info_content.
5753         (tui_clear_exec_info_content): Delete.
5754
5755 2019-08-13  Tom Tromey  <tom@tromey.com>
5756
5757         * tui/tui-winsource.h (struct tui_source_window_base)
5758         <show_exec_info_content>: Declare.
5759         (tui_show_exec_info_content): Don't declare.
5760         * tui/tui-winsource.c
5761         (tui_source_window_base::show_exec_info_content): Rename from
5762         tui_show_exec_info_content.
5763         (tui_source_window_base::update_exec_info): Update.
5764
5765 2019-08-13  Tom Tromey  <tom@tromey.com>
5766
5767         * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
5768         (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
5769         (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
5770         * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
5771         tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
5772         (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
5773         ... here.
5774
5775 2019-08-13  Tom Tromey  <tom@tromey.com>
5776
5777         * tui/tui-winsource.h (struct tui_source_window_base)
5778         <update_exec_info>: Declare.
5779         (tui_update_exec_info): Don't declare.
5780         * tui/tui-winsource.c (tui_update_source_window_as_is)
5781         (tui_source_window_base::refresh_all)
5782         (tui_update_all_breakpoint_info): Update.
5783         (tui_source_window_base::update_exec_info): Rename from
5784         tui_update_exec_info.
5785         * tui/tui-stack.c (tui_show_frame_info): Update.
5786
5787 2019-08-13  Tom Tromey  <tom@tromey.com>
5788
5789         * tui/tui-winsource.h (struct tui_source_window_base)
5790         <set_exec_info_content>: Declare.
5791         (tui_set_exec_info_content): Don't declare.
5792         * tui/tui-winsource.c
5793         (tui_source_window_base::set_exec_info_content): Rename from
5794         tui_set_exec_info_content.
5795         (tui_update_exec_info): Update.
5796
5797 2019-08-13  Tom Tromey  <tom@tromey.com>
5798
5799         * tui/tui-winsource.h (struct tui_source_window_base)
5800         <show_source_content>: Declare.
5801         (tui_show_source_content): Don't declare.
5802         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
5803         (tui_source_window_base::show_source_content): Rename from
5804         tui_show_source_content.
5805         (tui_source_window_base::refresh_all): Update.
5806         * tui/tui-layout.c (show_source_disasm_command)
5807         (show_source_or_disasm_and_command): Update.
5808
5809 2019-08-13  Tom Tromey  <tom@tromey.com>
5810
5811         * tui/tui-winsource.c (tui_erase_source_content)
5812         (tui_show_source_content, tui_source_window_base::refresh_all):
5813         Update.
5814         * tui/tui-wingeneral.h
5815         (tui_check_and_display_highlight_if_needed): Don't declare.
5816         * tui/tui-wingeneral.c
5817         (tui_win_info::check_and_display_highlight_if_needed): Rename from
5818         check_and_display_highlight_if_needed.
5819         * tui/tui-win.c (tui_rehighlight_all)
5820         (tui_win_info::make_visible_with_new_height): Update.
5821         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
5822         (tui_data_window::erase_data_content)
5823         (tui_data_window::display_all_data): Update.
5824         * tui/tui-data.h (struct tui_win_info)
5825         <check_and_display_highlight_if_needed>: Declare.
5826
5827 2019-08-13  Tom Tromey  <tom@tromey.com>
5828
5829         * tui/tui-win.c (tui_resize_all): Call
5830         tui_delete_invisible_windows.
5831         * tui/tui-layout.c (show_layout): Call
5832         tui_delete_invisible_windows.
5833         * tui/tui-data.h (tui_delete_invisible_windows): Declare.
5834         * tui/tui-data.c (tui_delete_invisible_windows): New function.
5835
5836 2019-08-13  Tom Tromey  <tom@tromey.com>
5837
5838         * tui/tui-disasm.c (tui_show_disassem): Add assertion.  Don't call
5839         tui_add_win_to_layout.
5840
5841 2019-08-13  Tom Tromey  <tom@tromey.com>
5842
5843         * tui/tui-layout.h (tui_default_win_height): Don't declare.
5844         * tui/tui-layout.c (tui_default_win_height): Now static.
5845
5846 2019-08-13  Tom Tromey  <tom@tromey.com>
5847
5848         * tui/tui-layout.c (show_layout): Unify all layout cases into a
5849         single switch.
5850         (show_source_disasm_command, show_source_or_disasm_and_command):
5851         Don't check current layout.
5852
5853 2019-08-13  Tom Tromey  <tom@tromey.com>
5854
5855         * tui/tui-wingeneral.c (make_all_visible): Remove.
5856         (tui_make_all_invisible): Simplify.
5857         * tui/tui-layout.c (tui_make_all_invisible): Move from
5858         tui-wingeneral.c; simplify.
5859         (show_layout): Hoist call to tui_make_all_invisible.
5860         (show_data): Don't call tui_make_all_invisible.
5861
5862 2019-08-13  Tom Tromey  <tom@tromey.com>
5863
5864         * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
5865         * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
5866
5867 2019-08-13  Tom Tromey  <tom@tromey.com>
5868
5869         * tui/tui-layout.c (current_layout, tui_current_layout): Move from
5870         tui-data.c.
5871         (show_source_disasm_command, show_data)
5872         (show_source_or_disasm_and_command): Don't use
5873         tui_set_current_layout_to.
5874         * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
5875         * tui/tui-data.c (current_layout, tui_current_layout): Move to
5876         tui-layout.c.
5877         (tui_set_current_layout_to): Remove.
5878
5879 2019-08-13  Tom Tromey  <tom@tromey.com>
5880
5881         * tui/tui-layout.c (tui_set_layout): Update.
5882         * tui/tui-data.h (struct tui_layout_def): Remove.
5883         (tui_layout_def): Don't declare.
5884         * tui/tui-data.c (layout_def): Remove.
5885         (tui_layout_def): Remove.
5886
5887 2019-08-13  Tom Tromey  <tom@tromey.com>
5888
5889         * tui/tui-winsource.h (struct tui_source_window_base)
5890         <clear_detail>: No longer "override".
5891         * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
5892         * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
5893         * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
5894         * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
5895         Remove.
5896         * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
5897
5898 2019-08-13  Tom Tromey  <tromey@adacore.com>
5899
5900         * tracepoint.c: Don't include readline.h or history.h.
5901
5902 2019-08-12  Tom Tromey  <tom@tromey.com>
5903
5904         * configure: Rebuild.
5905         * configure.ac: Check for readline 7.
5906         * NEWS: Mention readline 7 requirement.
5907         * README: Update.
5908
5909 2019-08-12  Tom Tromey  <tom@tromey.com>
5910
5911         * mingw-hdep.c (gdb_select): Remove readline hack.
5912
5913 2019-08-09  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
5914
5915         * blockframe.c (find_pc_partial_function): Set *block to nullptr
5916         when the function fails.
5917
5918 2019-08-09  Andreas Arnez  <arnez@linux.ibm.com>
5919
5920         * s390-tdep.c (s390_type_align): New function.
5921         (s390_gdbarch_init): Set it as type_align gdbarch method.
5922
5923 2019-08-09  Tom de Vries  <tdevries@suse.de>
5924
5925         PR gdb/24591
5926         * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
5927         pc_low with relocation offset.
5928
5929 2019-08-07  Tom Tromey  <tromey@adacore.com>
5930
5931         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
5932         (print_frame_args): Update.
5933         * python/py-framefilter.c (py_print_single_arg, enumerate_args):
5934         Update.
5935         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
5936         * frame.h (struct frame_arg): Add initializers.
5937         <error>: Now a unique_xmalloc_ptr.
5938
5939 2019-08-07  Alan Hayward  <alan.hayward@arm.com>
5940
5941         * NEWS: Expand the Pointer Authentication entry.
5942         * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
5943         (aarch64_frame_unmask_lr): ... to this.
5944         (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
5945         Call aarch64_frame_unmask_lr.
5946         * frame.c (struct frame_info): Add "masked" variable.
5947         (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
5948         (fprint_frame): Check for masked pc.
5949         * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
5950         declarations.
5951         * python/py-framefilter.c (py_print_frame): Check for masked pc.
5952         * stack.c (print_frame): Check for masked pc.
5953
5954 2019-08-06  Tom Tromey  <tom@tromey.com>
5955
5956         * stabsread.c (patch_block_stabs, read_one_struct_field)
5957         (read_enum_type): Use obstack_strndup.
5958         * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
5959         * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
5960         * dwarf2read.c (guess_full_die_structure_name)
5961         (anonymous_struct_prefix): Use obstack_strndup.
5962         * dbxread.c (cp_set_block_scope): Use obstack_strndup.
5963         * c-exp.y (yylex): Use obstack_strndup.
5964         * ada-exp.y (write_object_renaming, write_ambiguous_var)
5965         (write_var_or_type): Use obstack_strndup.
5966
5967 2019-08-06  Tom Tromey  <tom@tromey.com>
5968
5969         * symfile.c (reread_symbols): Use obstack_strdup.
5970         * stabsread.c (read_type): Use obstack_strdup.
5971         * gdb_obstack.h (obstack_strdup): New overload.
5972         * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
5973         (create_dwo_unit_in_dwp_v2, build_error_marker_type)
5974         (dwarf2_canonicalize_name): Use obstack_strdup.
5975         * dbxread.c (read_dbx_symtab): Use obstack_strdup.
5976         * cp-support.c (inspect_type, replace_typedefs_qualified_name):
5977         Use obstack_strdup.
5978
5979 2019-08-06  Tom Tromey  <tom@tromey.com>
5980
5981         * gdb_obstack.h (obstack_strdup): Define.
5982         * gdb_obstack.c (obstack_strdup): Don't define.
5983
5984 2019-08-06  Tom Tromey  <tom@tromey.com>
5985
5986         * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
5987         obstack_strdup.
5988         * typeprint.c (typedef_hash_table::find_global_typedef): Use
5989         obstack_strdup.
5990         * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
5991         * stabsread.c (common_block_start): Use obstack_strdup.
5992         * objfiles.c (set_objfile_main_name, objfile): Use
5993         obstack_strdup.
5994         * namespace.c (add_using_directive): Use obstack_strdup.
5995         * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
5996         * jit.c (finalize_symtab): Use obstack_strdup.
5997         * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
5998         (guess_partial_die_structure_name, partial_die_info::fixup)
5999         (dwarf2_name): Use obstack_strdup.
6000         * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
6001         obstack_strdup.
6002         * c-exp.y (scan_macro_expansion): Use obstack_strdup.
6003         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
6004         obstack_strdup.
6005         * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
6006
6007 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6008
6009         * unittests/help-doc-selftests.c: New file.
6010         * Makefile.in: Add the new file.
6011
6012 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6013
6014         * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
6015         * cli/cli-decode.c (print_doc_line): Likewise.  It now prints
6016         the full first line, except when FOR_VALUE_PREFIX.  In this case,
6017         the trailing '.' is not output, and the first character is uppercased.
6018         (print_help_for_command): Update call to print_doc_line.
6019         (print_doc_of_command): Likewise.
6020         * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
6021         * cli/cli-option.c (append_indented_doc): Do not append newline.
6022         (build_help_option): Append newline after first appended_indented_doc
6023         only if a second call is done.
6024         (build_help): Append 2 new lines before each option, except the first
6025         one.
6026         * compile/compile.c (_initialize_compile): Add new lines after
6027         %OPTIONS%, when not at the end of the help.
6028         Change help doc or code
6029         producing the help doc to respect the invariants.
6030         * maint-test-options.c (_initialize_maint_test_options): Likewise.
6031         Also removed the new line after 'Options:', as all other commands
6032         do not put an empty line between 'Options:' and the first option.
6033         * printcmd.c (_initialize_printcmd): Likewise.
6034         * stack.c (_initialize_stack): Likewise.
6035         * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
6036         incorrectly telling COMMAND is optional.
6037         * ada-lang.c (_initialize_ada_language): Change help doc or code
6038         producing the help doc to respect the invariants.
6039         * ada-tasks.c (_initialize_ada_tasks): Likewise.
6040         * breakpoint.c (_initialize_breakpoint): Likewise.
6041         * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
6042         * cli/cli-logging.c (_initialize_cli_logging): Likewise.
6043         * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
6044         * cli/cli-style.c (cli_style_option::add_setshow_commands,
6045         _initialize_cli_style): Likewise.
6046         * corelow.c (core_target_info): Likewise.
6047         * dwarf-index-cache.c (_initialize_index_cache): Likewise.
6048         * dwarf2read.c (_initialize_dwarf2_read): Likewise.
6049         * filesystem.c (_initialize_filesystem): Likewise.
6050         * frame.c (_initialize_frame): Likewise.
6051         * gnu-nat.c (add_task_commands): Likewise.
6052         * infcall.c (_initialize_infcall): Likewise.
6053         * infcmd.c (_initialize_infcmd): Likewise.
6054         * interps.c (_initialize_interpreter): Likewise.
6055         * language.c (_initialize_language): Likewise.
6056         * linux-fork.c (_initialize_linux_fork): Likewise.
6057         * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
6058         * maint.c (_initialize_maint_cmds): Likewise.
6059         * memattr.c (_initialize_mem): Likewise.
6060         * printcmd.c (_initialize_printcmd): Likewise.
6061         * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
6062         _RegEx): Likewise.
6063         * ravenscar-thread.c (_initialize_ravenscar): Likewise.
6064         * record-btrace.c (_initialize_record_btrace): Likewise.
6065         * record-full.c (_initialize_record_full): Likewise.
6066         * record.c (_initialize_record): Likewise.
6067         * regcache-dump.c (_initialize_regcache_dump): Likewise.
6068         * regcache.c (_initialize_regcache): Likewise.
6069         * remote.c (add_packet_config_cmd, init_remote_threadtests,
6070         _initialize_remote): Likewise.
6071         * ser-tcp.c (_initialize_ser_tcp): Likewise.
6072         * serial.c (_initialize_serial): Likewise.
6073         * skip.c (_initialize_step_skip): Likewise.
6074         * source.c (_initialize_source): Likewise.
6075         * stack.c (_initialize_stack): Likewise.
6076         * symfile.c (_initialize_symfile): Likewise.
6077         * symtab.c (_initialize_symtab): Likewise.
6078         * target-descriptions.c (_initialize_target_descriptions): Likewise.
6079         * top.c (init_main): Likewise.
6080         * tracefile-tfile.c (tfile_target_info): Likewise.
6081         * tracepoint.c (_initialize_tracepoint): Likewise.
6082         * tui/tui-win.c (_initialize_tui_win): Likewise.
6083         * utils.c (add_internal_problem_command): Likewise.
6084         * valprint.c (value_print_option_defs): Likewise.
6085
6086 2019-08-06  Frank Ch. Eigler  <fche@redhat.com>
6087
6088         PR build/24886
6089         * configure.ac: Drop enable-libmcheck support.
6090         * configure, config.in: Rebuild.
6091         * libmcheck.m4: Remove.
6092         * acinclude.m4: Don't include it.
6093         * Makefile.in: Don't distribute it.
6094         * top.c (print_gdb_configuration): Don't mention it.
6095
6096 2019-08-06  Tom Tromey  <tom@tromey.com>
6097
6098         * utils.c (set_output_style): Sometimes pass stream to
6099         emit_style_escape.
6100         * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
6101         * record-btrace.c (btrace_insn_history): Update.
6102         * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
6103         method.
6104         * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
6105         Update initializers.
6106         <m_uiout>: New field.
6107         <m_di>: Move lower.
6108         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
6109         Remove "uiout" parameter.
6110         (dump_insns): Update.
6111         * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
6112         * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
6113
6114 2019-08-06  Christian Biesinger  <cbiesinger@google.com>
6115
6116         * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
6117         (error_in_psymtab_expansion): Likewise.
6118         (lookup_symbol_via_quick_fns): Likewise.
6119         (basic_lookup_transparent_type_quick): Likewise.
6120         (basic_lookup_transparent_type_1): Likewise.
6121
6122 2019-08-06  Tom Tromey  <tromey@adacore.com>
6123
6124         * source.c (last_source_error): Now bool.
6125         (print_source_lines_base): Make "noprint" bool.  Only open
6126         source file when last_source_visited changes.
6127
6128 2019-08-06  Tom Tromey  <tromey@adacore.com>
6129
6130         * annotate.c (annotate_source_line): Use g_source_cache.
6131         * source-cache.c (source_cache::get_plain_source_lines): Change
6132         parameters.  Populate m_offset_cache.
6133         (source_cache::ensure): New method.
6134         (source_cache::get_line_charpos): New method.
6135         (extract_lines): Move lower.  Change parameters.
6136         (source_cache::get_source_lines): Move lower.
6137         * source-cache.h (class source_cache): Update comment.
6138         <get_line_charpos>: New method.
6139         <get_source_lines>: Update comment.
6140         <clear>: Clear m_offset_cache.
6141         <get_plain_source_lines>: Change parameters.
6142         <ensure>: New method
6143         <m_offset_cache>: New member.
6144         * source.c (forget_cached_source_info_for_objfile): Update.
6145         (info_source_command): Use g_source_cache.
6146         (find_source_lines, open_source_file_with_line_charpos): Remove.
6147         (print_source_lines_base, search_command_helper): Use g_source_cache.
6148         * source.h (open_source_file_with_line_charpos): Don't declare.
6149         * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
6150         * tui/tui-source.c (tui_source_window::do_scroll_vertical):
6151         Use g_source_cache.
6152
6153 2019-08-06  Tom Tromey  <tromey@adacore.com>
6154
6155         * source-cache.c (source_cache::get_plain_source_lines):
6156         Remove "first_line" and "last_line" parameters.
6157         (source_cache::get_source_lines): Cache plain text.
6158         * source-cache.h (class source_cache)
6159         <get_plain_source_lines>: Update.
6160
6161 2019-08-06  Tom Tromey  <tromey@adacore.com>
6162
6163         * source-cache.c (extract_lines): No longer a method.
6164         Changed type of parameter.  Include final newline.
6165         (selftests::extract_lines_test): New function.
6166         (_initialize_source_cache): Likewise.
6167         * source-cache.h (class source_cache)
6168         <extract_lines>: Don't declare.
6169
6170 2019-08-06  Tom Tromey  <tromey@adacore.com>
6171
6172         * breakpoint.c (init_breakpoint_sal): Update.
6173         (breakpoint): Update.
6174         * breakpoint.h (struct breakpoint) <filter>: Now a
6175         unique_xmalloc_ptr.
6176
6177 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
6178
6179         * NEWS: Mention dictionary access on blocks.
6180         * python/py-block.c (blpy_getitem): New function.
6181         (block_object_as_mapping): New struct.
6182         (block_object_type): Use new struct for tp_as_mapping field.
6183
6184 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
6185
6186         * objfiles.h (objfile): Add a comment describing partial symbols.
6187
6188 2019-08-05  Tom Tromey  <tromey@adacore.com>
6189
6190         * compile/compile.c (_initialize_compile): Use _(), not N_().
6191         * thread.c (_initialize_thread): Use _(), not N_().
6192         * stack.c (_initialize_stack): Use _(), not N_().
6193         * printcmd.c (_initialize_printcmd): Use _(), not N_().
6194
6195 2019-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
6196
6197         * dwarf2read.c (struct dw2_symtab_iterator):
6198         <want_specific_block>: Remove.
6199         <block_index>: Change type to gdb::optional.
6200         (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
6201         change type of BLOCK_INDEX parameter to gdb::optional.
6202         (dw2_symtab_iter_next): Re-write in function of gdb::optional.
6203         (dw2_lookup_symbol): Don't pass argument for
6204         WANT_SPECIFIC_BLOCK.
6205         (dw2_expand_symtabs_for_function): Don't pass argument for
6206         WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
6207         (class dw2_debug_names_iterator)
6208         <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
6209         parameter, change BLOCK_INDEX type to gdb::optional.
6210         <m_want_specific_block>: Remove.
6211         <m_block_index>: Change type to gdb::optional.
6212         (dw2_debug_names_iterator::next): Change type of IS_STATIC to
6213         gdb::optional.  Re-write in function of gdb::optional.
6214         (dw2_debug_names_lookup_symbol): Don't pass argument for
6215         WANT_SPECIFIC_BLOCK.
6216         (dw2_debug_names_expand_symtabs_for_function): Don't pass
6217         argument for WANT_SPECIFIC_BLOCK, pass empty optional for
6218         BLOCK_INDEX.
6219
6220 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6221
6222         * NEWS: Mention changes to "info sources" command.
6223
6224 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6225
6226         * symtab.c (filename_partial_match_opts): New struct type.
6227         (struct output_source_filename_data): New members
6228         regexp, c_regexp, partial_match.
6229         (output_source_filename): Use new members to decide to print file.
6230         (info_sources_option_defs): New variable.
6231         (make_info_sources_options_def_group, print_info_sources_header,
6232         info_sources_command_completer):
6233         New functions.
6234         (info_sources_command): Read new optional arguments.
6235         (_initialize_symtab): Update info sources help.
6236
6237 2019-08-02  Alexandre Oliva <oliva@adacore.com>
6238
6239         * ada-lang.c (exception_support_info_v0): Renamed from...
6240         (default_exception_support_info): ... this.  Create new
6241         definition for v1.
6242         (ada_has_this_exception_support): Look up catch_handlers_sym.
6243         (ada_exception_support_info_sniffer): Try v0 after default.
6244
6245 2019-08-01  Tom Tromey  <tromey@adacore.com>
6246
6247         * ia64-libunwind-tdep.h (struct libunwind_descr): Include
6248         gdbarch.h.
6249
6250 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
6251
6252         * s12z-tdep.c: Fix include path for s12z-opc.h.
6253
6254 2019-08-01  Alan Hayward  <alan.hayward@arm.com>
6255
6256         * NEWS: Require GNU make 3.82.
6257
6258 2019-07-16  Tom Tromey  <tom@tromey.com>
6259
6260         * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
6261         declare.
6262
6263 2019-07-30  Tom Tromey  <tromey@adacore.com>
6264
6265         * block.c (contained_in): Remove BLOCK_FUNCTION check.
6266
6267 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
6268
6269         * printcmd.c (print_address_symbolic): Print negative offsets.
6270         (build_address_symbolic): Force signed arithmetic when computing
6271         offset.
6272
6273 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
6274
6275         PR/24474: Add a function to lookup static variables.
6276         * NEWS: Mention this new function.
6277         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
6278         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
6279         * python/python.c (python_GdbMethods): Add new function.
6280
6281 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
6282
6283         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
6284         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
6285         (objfpy_lookup_static_symbol): New function.
6286         (objfile_object_methods): Add new functions.
6287
6288 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6289
6290         * NEWS: Mention 'set|show print frame-info'.  Mention new
6291         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
6292         backtrace argument.  Mention that python frame filtering code
6293         is now consistent with what 'backtrace' command prints.
6294
6295 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6296
6297         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
6298         comments.
6299         (print_frame_info_auto, print_frame_info_source_line,
6300         print_frame_info_location, print_frame_info_source_and_location,
6301         print_frame_info_location_and_address, print_frame_info_short_location):
6302         New declarations.
6303         (struct frame_print_options): New member print_frame_info.
6304         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
6305         * stack.h (get_user_print_what_frame_info): New declaration.
6306         (frame_show_address): New declaration.
6307         * stack.c (print_frame_arguments_choices): New value 'presence'.
6308         (print_frame_info_auto, print_frame_info_source_line,
6309         print_frame_info_location, print_frame_info_source_and_location,
6310         print_frame_info_location_and_address, print_frame_info_short_location,
6311         print_frame_info_choices, print_frame_info_print_what): New definitions.
6312         (print_frame_args): Only print dots for args if print frame-arguments
6313         is 'presence'.
6314         (frame_print_option_defs): New element for "frame-info".
6315         (get_user_print_what_frame_info): New function.
6316         (frame_show_address): Make non static.  Move comment to stack.h.
6317         (print_frame_info_to_print_what): New function.
6318         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
6319         to decide what to print.
6320         (backtrace_command_1): Handle the new print_frame_arguments_presence
6321         value.
6322         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
6323         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
6324         (py_print_frame): In non-mi mode, use LOCATION as default for
6325         print_what, similarly to frame information printed directly by
6326         backtrace command. Handle frame-info user option in non MI mode.
6327
6328 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
6329
6330         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
6331         Add case for debugging 32-bit target on 64-bit host.  Revise
6332         comment.
6333
6334 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
6335
6336         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
6337         instead of find_function_entry_range_from_pc.
6338
6339 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
6340
6341         * stack.c (find_frame_funname): Remove code which preferred
6342         minsym over symtab sym in "certain pathological cases".
6343
6344         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
6345         parameter.  Change type of "do_demangle" to bool.
6346         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
6347         Pass suitable "prefer_sym_over_minsym" flag to
6348         build_address_symbolic().  Don't output "+" for negative offsets.
6349         * printcmd.c (print_address_symbolic): Update invocation of
6350         build_address_symbolic to include a "prefer_sym_over_minsym"
6351         flag.
6352         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
6353         Restrict cases in which use of minimal symbol is preferred to that
6354         of a found symbol.  Update comments.
6355
6356         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
6357         for entry pc when entry pc is out of range for that FDE.
6358
6359 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
6360
6361         PR gdb/24839:
6362         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
6363         type.
6364
6365 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
6366
6367         * python/py-objfile.c (add_separate_debug_file): Fix comment about
6368         this function's Python signature.
6369
6370
6371 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
6372
6373         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
6374         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
6375         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
6376         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
6377         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
6378
6379
6380 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
6381
6382         * h8300-tdep.c (h8300_register_name_common): New.
6383         h8300_register_name): Use h8300_register_name_common.
6384         (h8300s_register_name): Likewise.
6385         (h8300sx_register_name): Likewise.
6386         (h8300h_register_nam): New.
6387         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
6388
6389
6390 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
6391
6392         * arm-tdep.c (arm_skip_cmse_entry): New function.
6393         (arm_is_sgstubs_section): New function.
6394         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
6395
6396 2019-07-22  Tom Tromey  <tom@tromey.com>
6397
6398         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
6399         Don't self-assign.
6400
6401 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
6402
6403         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
6404         type_print.
6405
6406 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
6407
6408         * symtab.c (search_symbols): Adjust msymbol matching type arrays
6409         so that GDB doesn't match any msymbols when searching in the
6410         TYPES_DOMAIN.
6411         (print_symbol_info): Print using typedef_print or type_print based
6412         on the type of the symbol.  Add updated FIXME comment moved from...
6413         (_initialize_symtab): ... move and update FIXME comment to above.
6414
6415 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
6416
6417         * NEWS: Mention adding -q option to "info types".
6418         * symtab.c (struct info_types_options): New struct.
6419         (info_types_options_defs): New variable.
6420         (make_info_types_options_def_group): New function.
6421         (info_types_command): Use gdb::option framework to parse options.
6422         (info_types_command_completer): New function.
6423         (_initialize_symtab): Extend the help text on "info types" and
6424         register command completer.
6425
6426 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
6427
6428         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
6429         (lookup_symbol_in_objfile): Change int to block_enum and add a
6430         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
6431
6432 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
6433
6434         * MAINTAINERS (Write After Approval): Add self.
6435
6436 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
6437
6438         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
6439         instruction to the dummy code region.
6440
6441 2019-07-19  Tom Tromey  <tromey@adacore.com>
6442
6443         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
6444         (ARGSUSED, PARAMS, __func__): Remove rules.
6445
6446 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
6447
6448         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
6449         * features/arm/arm-with-iwmmxt.c: Remove.
6450         * features/arm/arm-with-iwmmxt.xml: Remove.
6451         * features/arm/arm-with-m-fpa-layout.c: Remove.
6452         * features/arm/arm-with-m-fpa-layout.xml: Remove.
6453         * features/arm/arm-with-m-vfp-d16.c: Remove.
6454         * features/arm/arm-with-m-vfp-d16.xml: Remove.
6455         * features/arm/arm-with-m.c: Remove.
6456         * features/arm/arm-with-m.xml: Remove.
6457         * features/arm/arm-with-neon.c: Remove.
6458         * features/arm/arm-with-neon.xml: Remove.
6459         * features/arm/arm-with-vfpv2.c: Remove.
6460         * features/arm/arm-with-vfpv2.xml: Remove.
6461         * features/arm/arm-with-vfpv3.c: Remove.
6462         * features/arm/arm-with-vfpv3.xml: Remove.
6463
6464 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
6465
6466         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
6467
6468 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
6469
6470         * arch/aarch32.c (aarch32_create_target_description): Create
6471         target descriptions using features.
6472         * arch/arm.c (arm_create_target_description)
6473         (arm_create_mprofile_target_description): Likewise.
6474         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
6475
6476 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
6477
6478         * Makefile.in: Add new files.
6479         * aarch32-tdep.c: New file.
6480         * aarch32-tdep.h: New file.
6481         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
6482         Call aarch32_read_description.
6483         * arch/aarch32.c: New file.
6484         * arch/aarch32.h: New file.
6485         * arch/arm.c (arm_create_target_description)
6486         (arm_create_mprofile_target_description): New function.
6487         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
6488         (arm_create_target_description)
6489         (arm_create_mprofile_target_description): New declaration.
6490         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
6491         read_description functions.
6492         * arm-linux-nat.c (arm_linux_nat_target::read_description):
6493         Likewise.
6494         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
6495         * arm-tdep.c (tdesc_arm_list): New variable.
6496         (arm_register_g_packet_guesses): Call create description functions.
6497         (arm_read_description) (arm_read_mprofile_description): New
6498         function.
6499         * arm-tdep.h (arm_read_description)
6500         (arm_read_mprofile_description): Add declaration.
6501         * configure.tgt: Add new files.
6502
6503 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
6504
6505         * top.c (new_ui_command): Open specified terminal just once.
6506
6507 2019-07-18  Tom Tromey  <tromey@adacore.com>
6508
6509         * symtab.c (main_name): Constify return type.
6510         * symfile.c (set_initial_language): Update.
6511         * symtab.h (main_name): Constify return type.
6512
6513 2019-07-17  Tom Tromey  <tom@tromey.com>
6514
6515         * tui/tui-winsource.c (tui_update_source_window)
6516         (tui_update_source_window_as_is)
6517         (tui_update_source_windows_with_line): Remove return.
6518         * tui/tui-disasm.c (tui_show_disassem)
6519         (tui_show_disassem_and_update_source): Remove return.
6520         * tui/tui.c (tui_reset): Remove return.
6521         * tui/tui-wingeneral.c
6522         (tui_check_and_display_highlight_if_needed): Remove return.
6523
6524 2019-07-17  Tom Tromey  <tom@tromey.com>
6525
6526         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
6527
6528 2019-07-17  Tom Tromey  <tom@tromey.com>
6529
6530         * tui/tui-winsource.h (struct tui_exec_info_window)
6531         (struct tui_source_window_base): Move from tui-data.h.
6532         * tui/tui-winsource.c: Move many method definitions from
6533         elsewhere.  Remove "structuring" comments.
6534         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
6535         (tui_source_window_base::refresh_window): Move to
6536         tui-winsource.c.
6537         * tui/tui-win.c (tui_source_window_base::refresh_all)
6538         (tui_source_window_base::update_tab_width)
6539         (tui_source_window_base::set_new_height)
6540         (tui_source_window_base::do_make_visible_with_new_height): Move to
6541         tui-winsource.c.
6542         * tui/tui-source.h: Update.
6543         * tui/tui-source.c (tui_source_window_base::reset): Move to
6544         tui-winsource.c.
6545         * tui/tui-disasm.h: Update.
6546         * tui/tui-data.h (struct tui_exec_info_window): Move to
6547         tui-winsource.h.
6548         (struct tui_source_window_base): Likewise.
6549         * tui/tui-data.c (tui_source_window_base::clear_detail)
6550         (tui_source_window_base, ~tui_source_window_base): Move to
6551         tui-winsource.c.
6552
6553 2019-07-17  Tom Tromey  <tom@tromey.com>
6554
6555         * tui/tui-win.c (tui_resize_all)
6556         (tui_source_window_base::update_tab_width)
6557         (tui_adjust_win_heights): Update.
6558         (tui_win_info::make_invisible_and_set_new_height): Rename from
6559         make_invisible_and_set_new_height.
6560         * tui/tui-data.h (struct tui_win_info)
6561         <make_invisible_and_set_new_height>: New method.
6562
6563 2019-07-17  Tom Tromey  <tom@tromey.com>
6564
6565         * tui/tui.c: Update.
6566         * tui/tui-source.h (struct tui_source_window): Move from
6567         tui-data.h.
6568         * tui/tui-layout.c: Update.
6569         * tui/tui-disasm.c: Update.
6570         * tui/tui-data.h (struct tui_source_window): Move to
6571         tui-source.h.
6572
6573 2019-07-17  Tom Tromey  <tom@tromey.com>
6574
6575         * tui/tui-disasm.h (struct tui_disasm_window): Move from
6576         tui-data.h.
6577         * tui/tui-data.h (struct tui_disasm_window): Move to
6578         tui-disasm.h.
6579
6580 2019-07-17  Tom Tromey  <tom@tromey.com>
6581
6582         * tui/tui-regs.h (struct tui_data_item_window): Move from
6583         tui-data.h.
6584         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
6585         * tui/tui-data.h (struct tui_data_item_window): Move to
6586         tui-regs.h.
6587         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
6588
6589 2019-07-17  Tom Tromey  <tom@tromey.com>
6590
6591         * tui/tui.c: Update.
6592         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
6593         (tui_cmd_window::max_height): Move to tui-command.c.
6594         * tui/tui-layout.c: Update.
6595         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
6596         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
6597         tui-command.c.
6598         * tui/tui-command.h (struct tui_cmd_window): Move from
6599         tui-data.h.
6600         * tui/tui-command.c: Remove "structuring" comments.
6601         (tui_cmd_window::clear_detail)
6602         (tui_cmd_window::do_make_visible_with_new_height)
6603         (tui_cmd_window::max_height): Move from elsewhere.
6604
6605 2019-07-17  Tom Tromey  <tom@tromey.com>
6606
6607         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
6608         Now static.
6609         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
6610         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
6611
6612 2019-07-17  Tom Tromey  <tom@tromey.com>
6613
6614         * tui/tui.c: Update.
6615         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
6616         tui-regs.c.
6617         * tui/tui-windata.h: Remove file.
6618         * tui/tui-windata.c: Remove file.
6619         * tui/tui-win.c (tui_data_window::set_new_height)
6620         (tui_data_window::do_make_visible_with_new_height): Move to
6621         tui-regs.c.
6622         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
6623         * tui/tui-regs.c: Remove "structuring" comments.
6624         (tui_data_window::first_data_item_displayed)
6625         (tui_data_window::delete_data_content_windows)
6626         (tui_data_window::erase_data_content)
6627         (tui_data_window::display_all_data)
6628         (tui_data_window::refresh_all)
6629         (tui_data_window::do_scroll_vertical)
6630         (tui_data_window::clear_detail, tui_data_window::set_new_height)
6631         (tui_data_window::do_make_visible_with_new_height)
6632         (tui_data_window::refresh_window): Move from elsewhere.
6633         (_initialize_tui_regs): Move to end of file.
6634         * tui/tui-layout.c: Update.
6635         * tui/tui-hooks.c: Update.
6636         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
6637         * tui/tui-data.c (tui_data_window::clear_detail): Move to
6638         tui-regs.c.
6639         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
6640
6641 2019-07-17  Tom Tromey  <tom@tromey.com>
6642
6643         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
6644         seen.
6645
6646 2019-07-17  Tom Tromey  <tom@tromey.com>
6647
6648         * tui/tui-win.c (tui_source_window_base::set_new_height)
6649         (tui_source_window_base::do_make_visible_with_new_height): Use
6650         m_has_locator field directly.
6651         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
6652         method.
6653         (struct tui_source_window_base) <has_locator>: Likewise.
6654
6655 2019-07-17  Tom Tromey  <tom@tromey.com>
6656
6657         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
6658         Don't declare.
6659         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
6660         Remove.
6661         * tui/tui-win.c (tui_source_window_base::set_new_height)
6662         (tui_source_window_base::set_new_height)
6663         (make_invisible_and_set_new_height)
6664         (tui_source_window_base::do_make_visible_with_new_height)
6665         (tui_source_window_base::do_make_visible_with_new_height):
6666         Update.
6667         * tui/tui-layout.c (show_source_disasm_command, show_data)
6668         (show_source_or_disasm_and_command): Update.
6669         * tui/tui-layout.c (show_layout): Update.
6670
6671 2019-07-17  Tom Tromey  <tom@tromey.com>
6672
6673         * tui/tui-layout.c (make_data_window): Remove.
6674         (show_data): Unify creation and re-initialization cases.
6675
6676 2019-07-17  Tom Tromey  <tom@tromey.com>
6677
6678         * tui/tui-layout.c (make_source_window, make_disasm_window):
6679         Remove.
6680         (show_data): Unify creation and re-initialization cases.
6681
6682 2019-07-17  Tom Tromey  <tom@tromey.com>
6683
6684         * tui/tui-layout.c (make_command_window): Remove.
6685         (show_source_disasm_command, show_source_or_disasm_and_command):
6686         Unify creation and re-initialization cases.
6687
6688 2019-07-17  Tom Tromey  <tom@tromey.com>
6689
6690         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
6691         creation and re-initialization cases.
6692
6693 2019-07-17  Tom Tromey  <tom@tromey.com>
6694
6695         * tui/tui-regs.c (tui_get_register): Return void.
6696
6697 2019-07-17  Tom Tromey  <tom@tromey.com>
6698
6699         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
6700         Simplify.
6701
6702 2019-07-17  Tom Tromey  <tom@tromey.com>
6703
6704         * tui/tui-layout.c (show_source_disasm_command): Simplify window
6705         resetting.
6706
6707 2019-07-17  Tom Tromey  <tom@tromey.com>
6708
6709         * tui/tui.h (tui_set_layout_by_name): Don't declare.
6710         * tui/tui-regs.c (tui_reg_layout): New function.
6711         (tui_show_registers, tui_reg_command): Use it.
6712         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
6713         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
6714         parameters.
6715         (tui_layout_command): Remove.
6716
6717 2019-07-17  Tom Tromey  <tom@tromey.com>
6718
6719         * tui/tui-layout.h (tui/tui-layout): Return void.
6720         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
6721
6722 2019-07-17  Tom Tromey  <tom@tromey.com>
6723
6724         * tui/tui-layout.c (show_source_disasm_command, show_data):
6725         Update.
6726         (reset_locator): Remove.
6727         (show_source_or_disasm_and_command): Update.
6728
6729 2019-07-17  Tom Tromey  <tom@tromey.com>
6730
6731         * tui/tui-source.c (tui_source_window_base::reset): Remove
6732         win_type parameter.
6733         * tui/tui-layout.c (make_command_window, make_source_window)
6734         (make_disasm_window, make_data_window)
6735         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
6736         (reset_locator, show_source_or_disasm_and_command): Update.
6737         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
6738         win_type parameter.
6739         (struct tui_source_window_base) <reset>: Likewise.
6740
6741 2019-07-17  Tom Tromey  <tom@tromey.com>
6742
6743         * tui/tui-layout.c (show_source_disasm_command): Use
6744         reset_locator.
6745         (reset_locator): New function.
6746         (init_and_make_win): Remove.
6747         (show_source_or_disasm_and_command): Use reset_locator.
6748
6749 2019-07-17  Tom Tromey  <tom@tromey.com>
6750
6751         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
6752         condition.
6753         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
6754         Remove condition.
6755         * tui/tui-source.c (tui_source_window_base::reset): New method.
6756         * tui/tui-layout.c (make_command_window): Don't call
6757         init_and_make_win.
6758         (make_source_window, make_disasm_window): Don't call
6759         make_source_or_disasm_window.
6760         (make_data_window): Don't call init_and_make_win.  Change calling
6761         convention.
6762         (show_source_disasm_command, show_data): Simplify.
6763         (make_source_or_disasm_window): Remove.
6764         (show_source_or_disasm_and_command): Simplify.
6765         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
6766         (struct tui_source_window_base) <reset>: Likewise.
6767         <execution_info>: Remove initializer.
6768         * tui/tui-data.c (tui_source_window_base): Initialize
6769         execution_info.
6770
6771 2019-07-17  Tom Tromey  <tom@tromey.com>
6772
6773         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
6774         variable.
6775
6776 2019-07-17  Tom Tromey  <tom@tromey.com>
6777
6778         * tui/tui.c (tui_rl_other_window): Update.
6779         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
6780         superclass method first.  Always iterate over regs_content.
6781         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
6782         method.
6783         * tui/tui-win.c (tui_set_focus_command): Update.
6784
6785 2019-07-17  Tom Tromey  <tom@tromey.com>
6786
6787         * tui/tui-win.c (tui_set_focus_command): Rename from
6788         tui_set_focus.  Call tui_enable.
6789         (tui_set_focus_command): Remove.
6790
6791 2019-07-17  Tom Tromey  <tom@tromey.com>
6792
6793         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
6794         refresh_window.
6795         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
6796         touchwin.
6797         (tui_data_window::refresh_window): Call refresh_window on data
6798         items.  Always call superclass refresh_window.
6799         (tui_win_info::refresh): Remove.
6800         (tui_source_window_base::refresh_window): Update.
6801         (tui_refresh_all): Update.
6802         * tui/tui-layout.c (show_source_disasm_command): Remove call to
6803         refresh_window.
6804         (show_source_or_disasm_and_command): Likewise.
6805         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
6806         (struct tui_source_window_base) <refresh>: Likewise.
6807
6808 2019-07-17  Tom Tromey  <tom@tromey.com>
6809
6810         * tui/tui-winsource.c (tui_clear_source_content)
6811         (tui_show_source_content): Update.
6812         * tui/tui-source.c (tui_source_window::showing_source_p): Check
6813         whether content is empty.
6814         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
6815         Remove.
6816
6817 2019-07-17  Tom Tromey  <tom@tromey.com>
6818
6819         * tui/tui-winsource.c (tui_erase_source_content): Clear the
6820         window's contents.
6821         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
6822         * tui/tui-source.c (tui_set_source_content_nil): Remove.
6823
6824 2019-07-17  Tom Tromey  <tom@tromey.com>
6825
6826         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
6827         (struct tui_data_item_window): Update.
6828
6829 2019-07-17  Tom Tromey  <tom@tromey.com>
6830
6831         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
6832         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
6833         defines.
6834
6835 2019-07-17  Tom Tromey  <tom@tromey.com>
6836
6837         * tui/tui-winsource.h (tui_erase_source_content)
6838         (tui_clear_source_content): Remove "display_prompt" parameter.
6839         * tui/tui-winsource.c (tui_update_source_window_as_is)
6840         (tui_update_source_windows_with_addr): Update.
6841         (tui_clear_source_content): Remove "display_prompt" parameter.
6842         (tui_erase_source_content): Likewise.  Simplify.
6843         (tui_show_source_content): Update.
6844         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
6845         * tui/tui-stack.c (tui_show_frame_info): Update.
6846         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
6847         Remove defines.
6848
6849 2019-07-17  Tom Tromey  <tom@tromey.com>
6850
6851         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
6852         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
6853         parameter.
6854         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
6855         parameter.
6856
6857 2019-07-17  Tom Tromey  <tom@tromey.com>
6858
6859         * tui/tui-winsource.c (tui_clear_source_content)
6860         (tui_show_source_content, tui_show_exec_info_content)
6861         (tui_clear_exec_info_content): Update.
6862         * tui/tui-stack.c (tui_show_locator_content): Update.
6863         (tui_show_frame_info): Update.
6864         * tui/tui-source.h (tui_source_window): Don't declare.
6865         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
6866         from tui_source_is_displayed.
6867         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
6868         Remove field.
6869         (struct tui_source_window_base) <content_in_use>: New field.  Now
6870         bool.
6871         (struct tui_source_window) <showing_source_p>: New method.
6872         (TUI_SRC_WIN): Change cast.
6873         * tui/tui-data.c (tui_initialize_static_data): Update.
6874
6875 2019-07-17  Tom Tromey  <tom@tromey.com>
6876
6877         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
6878         location_matches_p.
6879         * tui/tui-source.c (tui_source_window::location_matches_p): New
6880         method.
6881         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
6882         method.
6883         * tui/tui-data.h (struct tui_source_window_base)
6884         <location_matches_p>: New method.
6885         (struct tui_source_window, struct tui_disasm_window)
6886         <location_matches_p>: Likewise.
6887
6888 2019-07-17  Tom Tromey  <tom@tromey.com>
6889
6890         * tui/tui-win.c (tui_set_win_height_command): Rename from
6891         tui_set_win_height.
6892         (tui_set_win_height_command): Remove.
6893
6894 2019-07-17  Tom Tromey  <tom@tromey.com>
6895
6896         * tui/tui-source.c (tui_source_window): New constructor.  Add
6897         observer.
6898         (~tui_source_window): New destructor.
6899         (tui_source_window::style_changed): New method.
6900         * tui/tui-hooks.c (tui_redisplay_source): Remove.
6901         (tui_attach_detach_observers): Update.
6902         * tui/tui-data.h (struct tui_source_window): Make constructor not
6903         inline.  Add destructor.
6904         (struct tui_source_window) <style_changed>: New method.
6905         <m_observable>: New member.
6906
6907 2019-07-17  Tom Tromey  <tom@tromey.com>
6908
6909         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
6910         * tui/tui-win.c (tui_resize_all): Fix typo.
6911
6912 2019-07-17  Tom Tromey  <tom@tromey.com>
6913
6914         * tui/tui-wingeneral.h (tui_refresh_all): Update.
6915         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
6916         (tui_refresh_all): Remove "list" parameter.  Use foreach.
6917         * tui/tui-win.c (window_name_completer): Use foreach.
6918         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
6919         (update_tab_width): Likewise.
6920         * tui/tui-layout.c (show_layout): Update.
6921         * tui/tui-data.h (class tui_window_iterator): New.
6922         (struct all_tui_windows): New.
6923         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
6924
6925 2019-07-17  Tom Tromey  <tom@tromey.com>
6926
6927         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
6928         parameter.  Don't reference globals.
6929         (tui_reg_command): Update.
6930
6931 2019-07-17  Tom Tromey  <tom@tromey.com>
6932
6933         * tui/tui-regs.c (tui_show_registers): Simplify.
6934
6935 2019-07-17  Tom Tromey  <tom@tromey.com>
6936
6937         * tui/tui-regs.c (tui_show_registers): Update.
6938         (tui_show_register_group): Add win_info parameter.
6939
6940 2019-07-17  Tom Tromey  <tom@tromey.com>
6941
6942         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
6943         Rename from tui_display_reg_element_at_line.
6944         (tui_data_window::display_registers_from_line): Update.
6945         * tui/tui-data.h (struct tui_data_window)
6946         <display_reg_element_at_line>: New method.
6947
6948 2019-07-17  Tom Tromey  <tom@tromey.com>
6949
6950         * tui/tui-regs.h (tui_display_registers_from)
6951         (tui_display_registers_from_line): Don't declare.
6952         * tui/tui-windata.c (tui_data_window::display_all_data)
6953         (tui_data_window::refresh_all)
6954         (tui_data_window::do_scroll_vertical): Update.
6955         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
6956         from tui_display_registers_from.
6957         (tui_display_reg_element_at_line): Update.
6958         (tui_data_window::display_registers_from_line): Rename from
6959         tui_display_registers_from_line.
6960         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
6961         display_registers_from_line>: New methods.
6962
6963 2019-07-17  Tom Tromey  <tom@tromey.com>
6964
6965         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
6966         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
6967         from tui_erase_data_content.
6968         (tui_data_window::display_all_data)
6969         (tui_data_window::refresh_all)
6970         (tui_data_window::do_scroll_vertical): Update.
6971         * tui/tui-regs.c (tui_show_registers): Update.
6972         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
6973         New method.
6974
6975 2019-07-17  Tom Tromey  <tom@tromey.com>
6976
6977         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
6978         declare.
6979         * tui/tui-windata.c
6980         (tui_data_window::delete_data_content_windows): Rename from
6981         tui_delete_data_content_windows.
6982         (tui_data_window::display_all_data)
6983         (tui_data_window::do_scroll_vertical): Update.
6984         * tui/tui-data.h (struct tui_data_window)
6985         <delete_data_content_windows>: New method.
6986
6987 2019-07-17  Tom Tromey  <tom@tromey.com>
6988
6989         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
6990         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
6991
6992 2019-07-17  Tom Tromey  <tom@tromey.com>
6993
6994         * tui/tui-windata.h (tui_display_all_data): Don't declare.
6995         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
6996         from tui_display_all_data.
6997         * tui/tui-win.c
6998         (tui_data_window::do_make_visible_with_new_height): Update.
6999         * tui/tui-regs.c (tui_show_registers): Update.
7000         * tui/tui-layout.c (tui_set_layout): Update.
7001         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
7002         method.
7003
7004 2019-07-17  Tom Tromey  <tom@tromey.com>
7005
7006         * tui/tui-windata.h (tui_display_data_from): Don't declare.
7007         * tui/tui-windata.c (tui_display_data_from): Remove.
7008         (tui_data_window::refresh_all): Update.
7009
7010 2019-07-17  Tom Tromey  <tom@tromey.com>
7011
7012         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
7013         * tui/tui-windata.c (tui_display_data_from_line): Remove.
7014         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
7015         tui_display_registers_from_line.
7016         * tui/tui-regs.h (tui_display_registers_from_line): Update.
7017         * tui/tui-regs.c (tui_display_registers_from_line): Remove
7018         "force_display" parameter.
7019
7020 2019-07-17  Tom Tromey  <tom@tromey.com>
7021
7022         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
7023         declare.
7024         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
7025         Rename from tui_first_reg_element_no_inline.
7026         (tui_display_reg_element_at_line)
7027         (tui_display_registers_from_line): Update.
7028         * tui/tui-data.h (struct tui_data_window)
7029         <first_reg_element_no_inline>: New method.
7030
7031 2019-07-17  Tom Tromey  <tom@tromey.com>
7032
7033         * tui/tui-windata.c (tui_display_data_from)
7034         (tui_data_window::do_scroll_vertical): Update.
7035         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
7036         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
7037         Rename from tui_line_from_reg_element_no.
7038         (tui_display_registers_from_line): Update.
7039         * tui/tui-data.h (struct tui_data_window)
7040         <line_from_reg_element_no>: New method.
7041
7042 2019-07-17  Tom Tromey  <tom@tromey.com>
7043
7044         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
7045         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
7046         tui_last_regs_line_no.
7047         (tui_display_reg_element_at_line)
7048         (tui_display_registers_from_line): Update.
7049         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
7050         method.
7051
7052 2019-07-17  Tom Tromey  <tom@tromey.com>
7053
7054         PR tui/24722:
7055         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
7056         (tui_update_breakpoint_info): Add "being_deleted" parameter.
7057         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
7058         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
7059         (tui_update_breakpoint_info): Likewise.
7060         * tui/tui-hooks.c (tui_event_create_breakpoint)
7061         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
7062         Update.
7063
7064 2019-07-17  Tom Tromey  <tom@tromey.com>
7065
7066         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
7067
7068 2019-07-17  Tom Tromey  <tom@tromey.com>
7069
7070         * tui/tui-winsource.c (tui_update_source_window_as_is)
7071         (tui_update_source_windows_with_addr): Update.
7072         * tui/tui-source.h (tui_set_source_content)
7073         (tui_show_symtab_source): Add "win_info" parameter.
7074         * tui/tui-source.c (tui_set_source_content): Add "win_info"
7075         parameter.
7076         (tui_show_symtab_source): Likewise.
7077
7078 2019-07-17  Tom Tromey  <tom@tromey.com>
7079
7080         * tui/tui-wingeneral.c
7081         (tui_check_and_display_highlight_if_needed): Check can_highlight.
7082
7083 2019-07-17  Tom Tromey  <tom@tromey.com>
7084
7085         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
7086         (struct tui_cmd_window) <can_scroll>: New method.
7087         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
7088         method.
7089
7090 2019-07-17  Tom Tromey  <tromey@adacore.com>
7091
7092         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
7093         do_field_signed>: Rename.  Change type of "value".
7094         * ui-out.c (ui_out::field_signed): Rename from field_int.
7095         Change type of "value".
7096         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
7097         type of "value".
7098         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
7099         do_field_int.  Change type of "value".
7100         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
7101         do_field_int.  Change type of "value".
7102         * tracepoint.c (trace_status_mi, tfind_1)
7103         (print_one_static_tracepoint_marker): Update.
7104         * thread.c (print_thread_info_1, print_selected_thread_frame):
7105         Update.
7106         * stack.c (print_frame, print_frame_info): Update.
7107         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
7108         Update.
7109         * source.c (print_source_lines_base): Update.
7110         * skip.c (info_skip_command): Update.
7111         * record-btrace.c (btrace_ui_out_decode_error)
7112         (btrace_call_history_src_line): Update.
7113         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
7114         Update.
7115         * progspace.c (print_program_space): Update.
7116         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
7117         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
7118         do_field_int.  Change type of "value".
7119         * mi/mi-out.c (mi_ui_out::do_table_begin)
7120         (mi_ui_out::do_table_header): Update.
7121         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
7122         type of "value".
7123         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
7124         (mi_cmd_data_list_changed_registers, output_register)
7125         (mi_cmd_data_read_memory, mi_load_progress)
7126         (mi_cmd_trace_frame_collected): Update.
7127         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
7128         Update.
7129         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
7130         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
7131         (mi_cmd_var_list_children, varobj_update_one): Update.
7132         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
7133         (mi_cmd_stack_list_args, list_arg_or_local): Update.
7134         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
7135         * inferior.c (print_inferior): Update.
7136         * gdb_bfd.c (print_one_bfd): Update.
7137         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
7138         Update.
7139         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
7140         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
7141         do_field_int.  Change type of "value".
7142         * cli-out.c (cli_ui_out::do_field_signed): Rename from
7143         do_field_int.  Change type of "value".
7144         * breakpoint.c (watchpoint_check, print_breakpoint_location)
7145         (print_one_breakpoint_location, print_it_catch_fork)
7146         (print_one_catch_fork, print_it_catch_vfork)
7147         (print_one_catch_vfork, print_it_catch_solib)
7148         (print_it_catch_exec, print_it_ranged_breakpoint)
7149         (print_mention_watchpoint, print_mention_masked_watchpoint)
7150         (bkpt_print_it, update_static_tracepoint): Update.
7151         * break-catch-throw.c (print_it_exception_catchpoint): Update.
7152         * break-catch-syscall.c (print_it_catch_syscall): Update.
7153         * ada-tasks.c (print_ada_task_info): Update.
7154         * ada-lang.c (print_it_exception, print_mention_exception):
7155         Update.
7156
7157 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
7158
7159         PR breakpoints/24541
7160         * gdbarch.c: Regenerate.
7161         * gdbarch.h: Regenerate.
7162         * gdbarch.sh: Adjust return type and parameter types for
7163         'stap_adjust_register'.
7164         (i386_stap_adjust_register): Adjust signature and return new
7165         register name.
7166         * stap-probe.c (stap_parse_register_operand): Adjust use of
7167         'gdbarch_stap_adjust_register'.
7168
7169 2019-07-17  Tom Tromey  <tromey@adacore.com>
7170
7171         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
7172         declare VEC.
7173         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
7174         std::vector.
7175         (struct s390_process_info): Add initializers.
7176         (s390_add_process): Use new.
7177         (s390_linux_nat_target::low_forget_process): Use delete.
7178         (s390_linux_nat_target::low_new_fork)
7179         (s390_linux_nat_target::stopped_by_watchpoint)
7180         (s390_linux_nat_target::low_prepare_to_resume)
7181         (s390_linux_nat_target::insert_watchpoint)
7182         (s390_linux_nat_target::insert_hw_breakpoint)
7183         (s390_linux_nat_target::remove_watchpoint)
7184         (s390_linux_nat_target::remove_hw_breakpoint): Update.
7185
7186 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
7187
7188         * aarch64-fbsd-nat.c: Include regcache.h.
7189         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
7190         argument.
7191         (aarch64_fbsd_nat_target::fetch_registers)
7192         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
7193         variable.
7194         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
7195
7196 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
7197
7198         * fbsd-nat.c: Include gdbarch.h.
7199
7200 2019-07-15  Tom Tromey  <tromey@adacore.com>
7201
7202         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
7203
7204 2019-07-15  Tom Tromey  <tromey@adacore.com>
7205
7206         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
7207         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
7208         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
7209         * cli-out.c (cli_ui_out::do_field_int): New method.
7210         * ui-out.c (ui_out::field_unsigned): New method.
7211         * symfile.c (generic_load): Use field_unsigned.
7212         (print_transfer_performance): Likewise.
7213         * record-btrace.c (ui_out_field_uint): Remove.
7214         (btrace_call_history_insn_range, btrace_call_history): Use
7215         field_unsigned.
7216         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
7217         field_unsigned.
7218         * ui-out.h (class ui_out) <field_unsigned>: New method.
7219         <do_field_unsigned>: Likewise.
7220
7221 2019-07-15  Tom Tromey  <tromey@adacore.com>
7222
7223         * mi/mi-main.c (list_available_thread_groups): Use field_string.
7224         * mi/mi-interp.c (mi_memory_changed): Use field_string.
7225         * target.c (flash_erase_command): Use field_string.
7226         * infrun.c (print_signal_received_reason): Use field_string.
7227         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
7228         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
7229         field_string.
7230         * ada-tasks.c (print_ada_task_info): Use field_string.
7231
7232 2019-07-15  Tom Tromey  <tromey@adacore.com>
7233
7234         * target.c (flash_erase_command): Use field_core_addr.
7235         * symfile.c (generic_load): Use field_core_addr.
7236         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
7237         Use field_core_addr.
7238         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
7239         field_core_addr.
7240
7241 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
7242
7243         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
7244         value if its desired type is smaller than a CORE_ADDR and signed.
7245
7246 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
7247
7248         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
7249         of changes to field names, and use new is_reference field to
7250         decide if a property is a reference or not.
7251         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
7252         field.
7253         (struct dwarf2_property_baton): Update header comment, rename
7254         'referenced_type' to 'property_type' and update comments.
7255         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
7256         default property type, store in property baton, update to take
7257         accound of renamed field.
7258         (read_func_scope): Update call to attr_to_dynamic_prop.
7259         (read_array_type): Likewise.
7260         (dwarf2_per_cu_addr_sized_int_type): New function.
7261         (read_subrange_index_type): Move type finding code to
7262         dwarf2_per_cu_addr_sized_int_type.
7263         (read_subrange_type): Update calls to attr_to_dynamic_prop.
7264         (dwarf2_per_cu_addr_type): New function.
7265         (set_die_type): Update calls to attr_to_dynamic_prop.
7266
7267 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
7268
7269         * dwarf2read.c (read_subrange_index_type): New function.
7270         (read_subrange_type): Move code into new function and call it.
7271         * gdbtypes.c (create_range_type): Add some asserts.
7272
7273 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
7274
7275         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
7276         update return statements.
7277         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
7278         declaration, and update comment to match.
7279         * gdbtypes.c (resolve_dynamic_array): Update call to
7280         dwarf2_evaluate_property to match new return type.
7281
7282 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
7283
7284         * valarith.c (value_subscripted_rvalue): Change lowerbound
7285         parameter type from int to LONGEST.
7286         * value.h (value_subscripted_rvalue): Likewise in declaration.
7287
7288 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
7289
7290         * cli/cli-utils.c (info_print_command_completer): New function.
7291         * cli/cli-utils.h: Add 'completer.h' include, and forward
7292         declaration for 'struct cmd_list_element'.
7293         (info_print_command_completer): Declare.
7294         * stack.c (_initialize_stack): Add completer for 'info locals' and
7295         'info args'.
7296         * symtab.c (_initialize_symtab): Add completer for 'info
7297         variables' and 'info functions'.
7298         * NEWS: Mention completion for additional info commands.
7299
7300 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
7301
7302         * cli/cli-utils.c (extract_info_print_args): Delete.
7303         (extract_arg_maybe_quoted): Delete.
7304         (info_print_options_defs): New variable.
7305         (make_info_print_options_def_group): New function.
7306         (extract_info_print_options): Define new function.
7307         * cli/cli-utils.h (extract_info_print_args): Delete.
7308         (struct info_print_options): New structure.
7309         (extract_info_print_options): Declare new function.
7310         * stack.c (info_locals_command): Update to use new
7311         extract_info_print_options, also add a header comment.
7312         (info_args_command): Likewise.
7313         * symtab.c (info_variables_command): Likewise.
7314         (info_functions_command): Likewise.
7315
7316 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
7317
7318         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
7319         to extract string arguments.
7320         * common/common-utils.c (extract_string_maybe_quoted): New function.
7321         * common/common-utils.h (extract_string_maybe_quoted): Declare.
7322
7323 2019-07-11  Tom Tromey  <tromey@adacore.com>
7324
7325         * main.c (get_init_files): Use GDBINIT, not gdbinit.
7326         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
7327         * top.h (gdbinit): Don't declare.
7328         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
7329         into...
7330         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
7331         * top.c (gdb_init): Don't call init_cli_cmds.
7332         (gdbinit): Remove.
7333         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
7334
7335 2019-07-11  Tom Tromey  <tromey@adacore.com>
7336
7337         * python/py-inferior.c (add_thread_object): Don't use thread_obj
7338         after it has been moved.
7339
7340 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
7341
7342         * valops.c (value_must_coerce_to_target): Change return type to
7343         bool.
7344         * value.h (value_must_coerce_to_target): Likewise.
7345
7346 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
7347
7348         * breakpoint.c (is_hardware_watchpoint): Remove
7349         forward-declaration.
7350         (is_masked_watchpoint): Change return type to bool.
7351         (is_tracepoint): Likewise.
7352         (is_breakpoint): Likewise.
7353         (is_hardware_watchpoint): Likewise.
7354         (is_watchpoint): Likewise.
7355         (is_no_memory_software_watchpoint): Likewise.
7356         (is_catchpoint): Likewise.
7357         (breakpoint_1): Make FILTER parameter's return type bool.
7358         is_masked_watchpoint): Change return type to bool.
7359         (save_breakpoints): Make FILTER parameter's return type bool.
7360         * breakpoint.h (is_breakpoint): Change return type to bool.
7361         (is_watchpoint): Likewise.
7362         (is_catchpoint): Likewise.
7363         (is_tracepoint): Likewise.
7364
7365 2019-07-10  Tom Tromey  <tom@tromey.com>
7366
7367         * defs.h: Don't include gdbarch.h.
7368         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
7369         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
7370         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
7371         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
7372         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
7373         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
7374         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
7375         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
7376         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
7377         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
7378         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
7379         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
7380         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
7381         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
7382         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
7383         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
7384         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
7385         record-btrace.c, record.h, regcache-dump.c, regcache.h,
7386         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
7387         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
7388         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
7389         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
7390         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
7391         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
7392         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
7393         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
7394         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
7395
7396 2019-07-10  Tom Tromey  <tromey@adacore.com>
7397
7398         * ada-lang.h (is_ada_exception_catchpoint): Declare.
7399         * breakpoint.c (init_ada_exception_breakpoint): Register as
7400         bp_catchpoint.
7401         (print_one_breakpoint_location, print_one_breakpoint): Use
7402         is_ada_exception_catchpoint.
7403         * ada-lang.c (class ada_catchpoint_location): Pass
7404         bp_loc_software_breakpoint to bp_location constructor.
7405         (is_ada_exception_catchpoint): New function.
7406
7407 2019-07-10  Tom Tromey  <tromey@adacore.com>
7408
7409         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
7410         VEC.
7411         (struct arm_exidx_entry): New method operator<.
7412         (struct arm_exidx_data) <section_maps>: Change type.
7413         (arm_exidx_data_free): Remove.
7414         (arm_exidx_data_key): Change type.  Move lower.
7415         (arm_exidx_new_objfile): Update.
7416         (arm_compare_exidx_entries): Remove.
7417         (arm_find_exidx_entry, _initialize_arm_tdep)
7418
7419 2019-07-10  Tom Tromey  <tromey@adacore.com>
7420
7421         * solib-spu.c (ocl_program_data_key): Change type.
7422         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
7423         Update.
7424
7425 2019-07-10  Tom Tromey  <tromey@adacore.com>
7426
7427         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
7428         (struct solib_aix_inferior_data) <library_list>: Change type.
7429         (solib_aix_inferior_data_handle): Change type.
7430         (get_solib_aix_inferior_data): Update.
7431         (solib_aix_free_library_list): Remove.
7432         (library_list_start_library): Update.
7433         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
7434         return type.
7435         (solib_aix_get_library_list)
7436         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
7437         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
7438
7439 2019-07-10  Tom Tromey  <tromey@adacore.com>
7440
7441         * solib-dsbt.c (struct dsbt_info): Add initializers.
7442         (solib_dsbt_pspace_data): Change type.
7443         (dsbt_pspace_data_cleanup): Remove.
7444         (get_dsbt_info, _initialize_dsbt_solib): Update.
7445
7446 2019-07-10  Tom Tromey  <tromey@adacore.com>
7447
7448         * spu-tdep.c (spu_overlay_data): Change type.
7449         (spu_get_overlay_table, spu_overlay_new_objfile)
7450         (_initialize_spu_tdep): Update.
7451
7452 2019-07-10  Tom Tromey  <tromey@adacore.com>
7453
7454         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
7455         destructor.
7456         (dbx_objfile_data_key): Change type and declare later.
7457         (DBX_SYMFILE_INFO): Rewrite.
7458         * dbxread.c (dbx_objfile_data_key): Change type.
7459         (dbx_symfile_init): Update.
7460         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
7461         (coffstab_build_psymtabs, elfstab_build_psymtabs)
7462         (stabsect_build_psymtabs, _initialize_dbxread): Update.
7463
7464 2019-07-10  Tom Tromey  <tromey@adacore.com>
7465
7466         * jit.c (jit_program_space_key): Change type.  Move lower.
7467         (get_jit_program_space_data): Update.
7468         (jit_program_space_data_cleanup): Remove.
7469         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
7470         Update.
7471         (struct jit_program_space_data): Add initializers.
7472
7473 2019-07-10  Tom Tromey  <tromey@adacore.com>
7474
7475         * solib-darwin.c (struct darwin_info): Add initializers.
7476         (solib_darwin_pspace_data): Change type.
7477         (darwin_pspace_data_cleanup): Remove.
7478         (get_darwin_info, _initialize_darwin_solib): Update.
7479
7480 2019-07-10  Tom Tromey  <tromey@adacore.com>
7481
7482         * remote-sim.c (struct sim_inferior_data): Add initializers,
7483         constructor, and destructor.
7484         (sim_inferior_data_key): Change type.  Move lower.
7485         (check_for_duplicate_sim_descriptor): Update.
7486         (get_sim_inferior_data): Use new.  Update.
7487         (~sim_inferior_data_cleanup): Rename from
7488         sim_inferior_data_cleanup.  Simplify.
7489         (gdbsim_close_inferior, simulator_command)
7490         (sim_command_completer, _initialize_remote_sim): Update.
7491         (next_pid, INITIAL_PID): Move earlier.
7492
7493 2019-07-10  Tom Tromey  <tromey@adacore.com>
7494
7495         * python/python-internal.h (create_thread_object): Return
7496         gdbpy_ref.
7497         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
7498         * python/py-inferior.c (struct threadlist_entry): Add
7499         constructor.
7500         <thread_obj>: Now a gdbpy_ref.
7501         (thread_to_thread_object): Update.
7502         (add_thread_object): Use new.
7503         (delete_thread_object): Use delete.
7504         (infpy_threads): Update.
7505         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
7506         GIL.
7507
7508 2019-07-10  Tom Tromey  <tromey@adacore.com>
7509
7510         * valops.c (value_cast): Specialize error message for Ada.
7511
7512 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
7513
7514         * breakpoint.c (breakpoint_1): Update doc and parameter names.
7515
7516 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
7517
7518         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
7519         bpstat_should_step): Return bool, adjust comments.
7520         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
7521         bpstat_should_step): Likewise.
7522
7523 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
7524
7525         * features/Makefile: Use feature target descriptions for Arm.
7526         * features/arm/arm-core.c: Generate new file.
7527         * features/arm/arm-fpa.c: Likewise.
7528         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
7529         * features/arm/arm-m-profile.c: Likewise.
7530         * features/arm/arm-vfpv2.c: Likewise.
7531         * features/arm/arm-vfpv3.c: Likewise.
7532         * features/arm/xscale-iwmmxt.c: Likewise.
7533         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
7534
7535 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
7536
7537         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
7538         ptrace earlier.
7539
7540 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
7541
7542         * features/aarch64-pauth.c: Regenerate.
7543
7544 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
7545
7546         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
7547         bool.
7548         (bpstat_what): Use false instead of 0.
7549
7550 2019-07-09  Pedro Alves  <palves@redhat.com>
7551
7552         * break-catch-throw.c (is_exception_catchpoint): New.
7553         * breakpoint.c (print_one_breakpoint_location): New parameter
7554         'raw_loc'.  Handle it.  Use
7555         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
7556         looking at the breakpoint's type.
7557         (print_one_breakpoint): If handling "maint info breakpoints", also
7558         print locations of exception catchpoints.
7559         * breakpoint.h (is_exception_catchpoint): Declare.
7560
7561 2019-07-09  Pedro Alves  <palves@redhat.com>
7562
7563         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
7564         "addr" field.
7565         (allocate_location_exception_catchpoint): New.
7566         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
7567         (initialize_throw_catchpoint_ops): Install
7568         allocate_location_exception_catchpoint as allocate_location
7569         method.
7570         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
7571         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
7572         bp_loc_other.
7573         (breakpoint_address_is_meaningful): Delete.
7574         (bl_address_is_meaningful): New.
7575         (breakpoint_locations_match): Adjust comment.
7576         (bp_location_from_bp_type): New, factored out of...
7577         (bp_location::bp_location(breakpoint *)): ... this.
7578         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
7579         factored out of...
7580         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
7581         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
7582         breakpoint_address_is_meaningful.
7583         (bp_locations_compare): Adjust comment.
7584         (update_global_location_list): Use bl_address_is_meaningful
7585         instead of breakpoint_address_is_meaningful.
7586         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
7587         explicit.
7588         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
7589         * python/py-breakpoint.c (bppy_get_location): No longer check
7590         whether location is null.
7591
7592 2019-07-09  Pedro Alves  <palves@redhat.com>
7593
7594         PR c++/15468
7595         * breakpoint.c (print_one_breakpoint_location): Remove
7596         single-location assert.
7597
7598 2019-07-09  Tom Tromey  <tom@tromey.com>
7599
7600         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
7601         * configure: Rebuild.
7602         * configure.ac: Change common to gdbsupport.
7603         * gdbsupport: Rename from common.
7604         * acinclude.m4: Change common to gdbsupport.
7605         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
7606         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
7607         gdbsupport.
7608         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
7609         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
7610         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
7611         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
7612         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
7613         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
7614         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
7615         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
7616         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
7617         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
7618         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
7619         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
7620         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
7621         coff-pe-read.c, command.h, compile/compile-c-support.c,
7622         compile/compile-c.h, compile/compile-cplus-symbols.c,
7623         compile/compile-cplus-types.c, compile/compile-cplus.h,
7624         compile/compile-loc2c.c, compile/compile.c, completer.c,
7625         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
7626         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
7627         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
7628         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
7629         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
7630         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
7631         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
7632         features/aarch64-core.c, features/aarch64-fpu.c,
7633         features/aarch64-pauth.c, features/aarch64-sve.c,
7634         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
7635         features/i386/32bit-core.c, features/i386/32bit-linux.c,
7636         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
7637         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
7638         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
7639         features/i386/64bit-core.c, features/i386/64bit-linux.c,
7640         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
7641         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
7642         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
7643         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
7644         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
7645         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
7646         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
7647         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
7648         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
7649         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
7650         go32-nat.c, guile/guile.c, guile/scm-ports.c,
7651         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
7652         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
7653         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
7654         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
7655         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
7656         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
7657         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
7658         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
7659         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
7660         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
7661         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
7662         minsyms.c, mips-linux-tdep.c, namespace.h,
7663         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
7664         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
7665         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
7666         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
7667         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
7668         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
7669         nat/linux-waitpid.c, nat/mips-linux-watch.c,
7670         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
7671         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
7672         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
7673         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
7674         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
7675         procfs.c, producer.c, progspace.h, psymtab.h,
7676         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
7677         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
7678         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
7679         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
7680         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
7681         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
7682         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
7683         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
7684         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
7685         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
7686         target-memory.c, target.c, target.h, target/waitstatus.c,
7687         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
7688         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
7689         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
7690         unittests/array-view-selftests.c,
7691         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
7692         unittests/common-utils-selftests.c,
7693         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
7694         unittests/format_pieces-selftests.c,
7695         unittests/function-view-selftests.c,
7696         unittests/lookup_name_info-selftests.c,
7697         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
7698         unittests/mkdir-recursive-selftests.c,
7699         unittests/observable-selftests.c,
7700         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
7701         unittests/parse-connection-spec-selftests.c,
7702         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
7703         unittests/scoped_fd-selftests.c,
7704         unittests/scoped_mmap-selftests.c,
7705         unittests/scoped_restore-selftests.c,
7706         unittests/string_view-selftests.c, unittests/style-selftests.c,
7707         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
7708         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
7709         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
7710         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
7711         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
7712         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
7713
7714 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
7715
7716         * linespec.c (decode_digits_list_mode): Set explicit_line to a
7717         bool value.
7718         (decode_digits_ordinary): Set explicit_line field in sal.
7719         * symtab.c (skip_prologue_sal): Don't skip prologue for a
7720         symtab_and_line that was set on an explicit line number in
7721         assembler code.  Do always update the recorded symtab and line if
7722         we do skip the prologue.
7723
7724 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
7725
7726         * breakpoint.c (set_breakpoint_location_function): Remove
7727         explicit_loc parameter.
7728         (momentary_breakpoint_from_master): Update call to
7729         set_breakpoint_location_function.
7730         (add_location_to_breakpoint): Likewise.
7731
7732 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
7733
7734         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
7735         required features based on default bfd type when no specific bfd
7736         is present.
7737
7738 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7739
7740         * NEWS: Mention that GDB printf and eval commands can now print
7741         C-style and Ada-style convenience var strings without
7742         calling the inferior.
7743         * printcmd.c (printf_c_string): Locally print GDB internal var
7744         instead of transiting via the inferior.
7745         (printf_wide_c_string): Likewise.
7746
7747 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
7748
7749         PR breakpoints/25011
7750         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
7751
7752 2019-07-04  Tom Tromey  <tom@tromey.com>
7753
7754         PR tui/24724:
7755         * tui/tui-winsource.c (tui_clear_source_content): Update.
7756         (tui_source_window_base::set_is_exec_point_at): Fix comment.
7757         (tui_update_breakpoint_info): Update.
7758         (tui_set_exec_info_content): Update.
7759         * tui/tui-source.c (tui_set_source_content_nil): Update.
7760         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
7761         has_break.
7762         * tui/tui-data.h (enum tui_bp_flag): New.
7763         (tui_bp_flags): New enum flags type.
7764         (struct tui_source_element) <break_mode>: Change type.  Rename
7765         from has_break.
7766         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
7767         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
7768         constants.
7769         * tui/tui-winsource.h: Fix comment.
7770
7771 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
7772
7773         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
7774         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
7775         (store_fpregs_to_thread)
7776         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
7777         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
7778         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
7779         (IWMMXT_REGS_SIZE): Add define.
7780         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
7781         (fetch_vfp_regs, store_vfp_regs)
7782         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
7783         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
7784
7785 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
7786
7787         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
7788         defines.
7789         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
7790         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
7791         (ARM_INT_REGISTER_SIZE): ...to this.
7792         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
7793         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
7794         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
7795         (arm_linux_collect_gregset, supply_nwfpe_register)
7796         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
7797         defines.
7798         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
7799         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
7800         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
7801         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
7802         (arm_return_in_memory, arm_store_return_value)
7803         (arm_get_longjmp_target, arm_register_g_packet_guesses)
7804         (arm_record_ld_st_multiple): Likewise.
7805         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
7806         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
7807
7808 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
7809
7810         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
7811         AARCH64_DISPLACED_MODIFIED_INSNS.
7812         * aarch64-tdep.c (struct aarch64_displaced_step_data)
7813         (aarch64_displaced_step_copy_insn): Likewise.
7814         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
7815         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
7816         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
7817         ARM_DISPLACED_MODIFIED_INSNS.
7818         * arm-tdep.c (arm_gdbarch_init): Likewise.
7819         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
7820         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
7821         (struct arm_displaced_step_closure): Use
7822         ARM_DISPLACED_MODIFIED_INSNS.
7823
7824 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
7825
7826         * features/Makefile: Remove unused xml files.
7827         * features/aarch64.xml: Remove.
7828         * features/i386/amd64-avx-avx512-linux.xml: Remove.
7829         * features/i386/amd64-avx-avx512.xml: Remove.
7830         * features/i386/amd64-avx-linux.xml: Remove.
7831         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
7832         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
7833         * features/i386/amd64-avx-mpx-linux.xml: Remove.
7834         * features/i386/amd64-avx-mpx.xml: Remove.
7835         * features/i386/amd64-avx.xml: Remove.
7836         * features/i386/amd64-linux.xml: Remove.
7837         * features/i386/amd64-mpx-linux.xml: Remove.
7838         * features/i386/amd64-mpx.xml: Remove.
7839         * features/i386/amd64.xml: Remove.
7840         * features/i386/i386-avx-avx512-linux.xml: Remove.
7841         * features/i386/i386-avx-avx512.xml: Remove.
7842         * features/i386/i386-avx-linux.xml: Remove.
7843         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
7844         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
7845         * features/i386/i386-avx-mpx-linux.xml: Remove.
7846         * features/i386/i386-avx-mpx.xml: Remove.
7847         * features/i386/i386-avx.xml: Remove.
7848         * features/i386/i386-linux.xml: Remove.
7849         * features/i386/i386-mmx-linux.xml: Remove.
7850         * features/i386/i386-mmx.xml: Remove.
7851         * features/i386/i386-mpx-linux.xml: Remove.
7852         * features/i386/i386-mpx.xml: Remove.
7853         * features/i386/i386.xml: Remove.
7854         * features/i386/x32-avx-avx512-linux.xml: Remove.
7855         * features/i386/x32-avx-linux.xml: Remove.
7856         * features/i386/x32-linux.xml: Remove.
7857
7858 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
7859
7860         * regformats/aarch64.dat: Remove.
7861         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
7862         * regformats/i386/amd64-avx-linux.dat: Remove.
7863         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
7864         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
7865         * regformats/i386/amd64-linux.dat: Remove.
7866         * regformats/i386/amd64-mpx-linux.dat: Remove.
7867         * regformats/i386/amd64.dat: Remove.
7868         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
7869         * regformats/i386/i386-avx-linux.dat: Remove.
7870         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
7871         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
7872         * regformats/i386/i386-linux.dat: Remove.
7873         * regformats/i386/i386-mmx-linux.dat: Remove.
7874         * regformats/i386/i386-mpx-linux.dat: Remove.
7875         * regformats/i386/i386.dat: Remove.
7876         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
7877         * regformats/i386/x32-avx-linux.dat: Remove.
7878         * regformats/i386/x32-linux.dat: Remove.
7879
7880 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
7881
7882         * aarch64-tdep.c: Remove xml self tests.
7883         * amd64-linux-tdep.c: Likewise.
7884         * amd64-tdep.c: Likewise.
7885         * i386-linux-tdep.c: Likewise.
7886         * i386-tdep.c: Likewise.
7887
7888 2019-07-03  Pedro Alves  <palves@redhat.com>
7889
7890         PR cli/24732
7891         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
7892         (pipe_cmd_option_defs): New.
7893         (make_pipe_cmd_options_def_group): New.
7894         (pipe_command): Use gdb::option::process_options.
7895         (pipe_command_completer): New function.
7896         (_initialize_cli_cmds): Install completer for "pipe" command.
7897
7898 2019-07-03  Pedro Alves  <palves@redhat.com>
7899
7900         * cli/cli-option.c (union option_value) <string>: New field.
7901         (struct option_def_and_value): Add ctor, move ctor, dtor and
7902         use DISABLE_COPY_AND_ASSIGN.
7903         (option_def_and_value::clear_value): New.
7904         (parse_option, save_option_value_in_ctx, get_val_type_str)
7905         (add_setshow_cmds_for_options): Handle var_string.
7906         * cli-option.h (union option_def::var_address) <string>: New
7907         field.
7908         (struct string_option_def): New.
7909         * maint-test-options.c (struct test_options_opts): Add default
7910         ctor and use DISABLE_COPY_AND_ASSIGN.
7911         <string_opt>: New field.
7912         (test_options_opts::~test_options_opts): New.
7913         (test_options_opts::dump): Also dump "-string".
7914         (test_options_option_defs): Install "string.
7915
7916 2019-07-03  Pedro Alves  <palves@redhat.com>
7917
7918         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
7919         option_value with a null enumeration.
7920         (complete_options): Save the option values in the context.
7921         (save_option_value_in_ctx): New, factored out from ...
7922         (process_options): ... here.
7923         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
7924         of the function.
7925         * maint-test-options.c (test_options_opts::dump): New, factored
7926         out from ...
7927         (maintenance_test_options_command_mode): ... here.
7928         (maintenance_test_options_command_completion_result): Delete.
7929         (maintenance_test_options_command_completion_text): Update
7930         comment.
7931         (maintenance_show_test_options_completion_result): Change
7932         prototype.  Just print
7933         maintenance_test_options_command_completion_text.
7934         (save_completion_result): New.
7935         (maintenance_test_options_completer_mode): Pass options context to
7936         complete_options, and then save a dump.
7937         (_initialize_maint_test_options): Use add_cmd to install "maint
7938         show test-options-completion-result".
7939
7940 2019-07-03  Pedro Alves  <palves@redhat.com>
7941
7942         * NEWS (New commands): Mention "with" and "maint with".
7943         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
7944         (with_command, with_command_completer): New.
7945         (pipe_command): Adjust to new repeat_previous
7946         interface.
7947         (_initialize_cli_cmds): Install the "with" command and its "w"
7948         alias.
7949         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
7950         declarations.
7951         * cli/cli-setshow.c (parse_cli_var_uinteger)
7952         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
7953         argument strings for all var_types.
7954         (get_setshow_command_value_string): New, factored out from ...
7955         (do_show_command): ... this.
7956         * cli/cli-setshow.h: Include <string>.
7957         (get_setshow_command_value_string): Declare.
7958         * command.h (repeat_previous): Now returns const char *.  Adjust
7959         comment.
7960         * maint.c: Include "cli/cli-cmds.h".
7961         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
7962         (_initialize_maint_cmds): Register the "maintenance with" command.
7963         * top.c (repeat_previous): Move bits from pipe_command here:
7964         Return the saved command line, if any; error out if there's no
7965         command to relaunch.
7966
7967 2019-07-03  Pedro Alves  <palves@redhat.com>
7968
7969         * NEWS (New commands): Mention "maint set/show test-settings"
7970         instead of "maint test-settings".
7971         * maint-test-settings.c (maintenance_test_settings_list): Delete.
7972         (maintenance_test_settings_set_list): Rename to ...
7973         (maintenance_set_test_settings_list): ... this.
7974         (maintenance_test_settings_show_list): Rename to  ...
7975         (maintenance_show_test_settings_list): ... this.
7976         (maintenance_test_settings_cmd): Delete.
7977         (maintenance_test_settings_set_cmd): ...
7978         (maintenance_set_test_settings_cmd): ... this.
7979         (maintenance_test_settings_show_cmd): ...
7980         (maintenance_show_test_settings_cmd): ... this.
7981         (maintenance_test_settings_show_value_cmd):
7982         (maintenance_show_test_settings_value_cmd): ... this.
7983         (_initialize_maint_test_settings): No longer install the "maint
7984         test-settings" prefix command.  Rename "maint test-settings set"
7985         to "maint set test-settings", and "maint test-settings show" to
7986         "maint show test-settings".  Adjust all subcommands.
7987
7988 2019-07-03  Pedro Alves  <palves@redhat.com>
7989
7990         * maint-test-settings.c: Fix file's intro comment.  Replace all
7991         references to "test-options" with references to "test-settings",
7992         in comments.
7993
7994 2019-07-03  Pedro Alves  <palves@redhat.com>
7995
7996         * maint-test-settings.c (maintenance_test_settings_xxx)
7997         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
7998         New.
7999         (maintenance_test_settings_enums): Use them.
8000         (maintenance_test_settings_enum): Default to
8001         maintenance_test_settings_xxx.
8002         (_initialize_maint_test_settings): Initialize
8003         MAINTENANCE_TEST_SETTINGS_FILENAME.
8004
8005 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
8006
8007         * breakpoint.h (remove_breakpoints_inf): Change return type to
8008         void, move function documentation here.
8009         * breakpoint.c (remove_breakpoints_inf): Change return type to
8010         void, move function documentation to header.
8011
8012 2019-07-02  Pedro Alves  <palves@redhat.com>
8013
8014         * NEWS (Completion improvements): Mention "info threads".
8015         * thread.c (struct info_threads_opts, info_threads_option_defs)
8016         (make_info_threads_options_def_group): New.
8017         (info_threads_command): Use gdb::option::process_options.
8018         (info_threads_command_completer): New.
8019         (_initialize_thread): Use gdb::option::build_help to build the
8020         help text for "info threads".
8021
8022 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
8023
8024         * defs.h (generic_load): Move from here...
8025         * symfile.h (generic_load): ... to here.  Rename name parameter
8026         to args.
8027         * symfile.c (generic_load): Add comment.
8028
8029 2019-07-01  Tom Tromey  <tromey@adacore.com>
8030
8031         * dwarf2read.c
8032         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
8033         declaration of without_params.  Fix formatting.
8034
8035 2019-07-01  Tom Tromey  <tromey@adacore.com>
8036
8037         * ada-exp.y (find_primitive_type): Update.
8038         * ada-lang.h (ada_lookup_symbol): Update.
8039         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
8040         parameter.
8041         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
8042
8043 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
8044
8045         PR breakpoints/24541
8046         * gdbarch.c: Regenerate.
8047         * gdbarch.h: Regenerate.
8048         * gdbarch.sh: Add 'stap_adjust_register'.
8049         * i386-tdep.c: Include '<unordered_set>'.
8050         (i386_stap_adjust_register): New function.
8051         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
8052         * stap-probe.c (stap_parse_register_operand): Call
8053         'gdbarch_stap_adjust_register'.
8054
8055 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
8056
8057         PR python/24742
8058         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
8059         * python/python.c (do_start_initialization): Use 'xmalloc'
8060         instead of 'PyMem_Malloc'.
8061
8062 2019-06-28  Tom Tromey  <tromey@adacore.com>
8063
8064         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
8065         for Ada.
8066
8067 2019-06-27  Tom Tromey  <tromey@adacore.com>
8068
8069         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
8070         objfile_key.
8071         (arm_find_mapping_symbol, arm_record_special_symbol)
8072         (_initialize_arm_tdep): Update.
8073         (arm_objfile_data_free): Remove.
8074
8075 2019-06-27  Tom Tromey  <tromey@adacore.com>
8076
8077         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
8078         to cp_print_static_field.
8079
8080 2019-06-26  Tom Tromey  <tromey@adacore.com>
8081
8082         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
8083         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
8084         declare.
8085
8086 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
8087
8088         * features/aarch64-core.c (create_feature_aarch64_core):
8089         Regenerate.
8090         * features/aarch64-core.xml: Add cpsr flags.
8091
8092 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
8093
8094         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
8095         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
8096
8097 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
8098
8099         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
8100         field.
8101         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
8102         use.
8103         (arm_record_special_symbol): Don't insert new symbol in sorted
8104         position, push it at the end.
8105
8106 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
8107
8108         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
8109         (arm_mapping_symbol_s): Remove.
8110         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
8111         (arm_mapping_symbol_vec): New typedef.
8112         (struct arm_per_objfile): Add constructor.
8113         <section_maps>: Change type to
8114         std::unique_ptr<arm_mapping_symbol_vec[]>.
8115         (arm_compare_mapping_symbols): Remove.
8116         (arm_find_mapping_symbol): Adjust to section_maps type change.
8117         (arm_objfile_data_free): Call delete on arm_per_objfile.
8118         (arm_record_special_symbol): Adjust to section_maps type change.
8119         Allocate arm_per_objfile with new.
8120
8121 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8122
8123         * cli/cli-cmds.c (alias_command): Compare the alias prefix
8124         with the command prefix.
8125
8126 2019-06-25  Tom Tromey  <tom@tromey.com>
8127
8128         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
8129         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
8130
8131 2019-06-25  Tom Tromey  <tom@tromey.com>
8132
8133         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
8134         type.
8135         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
8136         protected.
8137
8138 2019-06-25  Tom Tromey  <tom@tromey.com>
8139
8140         * tui/tui-winsource.c
8141         (tui_source_window_base::set_is_exec_point_at): Add check against
8142         LOA_ADDRESS.
8143
8144 2019-06-25  Tom Tromey  <tom@tromey.com>
8145
8146         * tui/tui-source.c (tui_set_source_content): Don't check before
8147         xfree.
8148         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
8149
8150 2019-06-25  Tom Tromey  <tom@tromey.com>
8151
8152         * tui/tui-winsource.h (tui_update_source_window_as_is)
8153         (tui_alloc_source_buffer, tui_line_is_displayed)
8154         (tui_addr_is_displayed): Change type of win_info.
8155         * tui/tui-winsource.c (tui_update_source_window_as_is)
8156         (tui_clear_source_content, tui_show_source_line)
8157         (tui_show_source_content, tui_source_window_base::refill)
8158         (tui_source_window_base::set_is_exec_point_at)
8159         (tui_source_window_base::set_is_exec_point_at)
8160         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
8161         (tui_alloc_source_buffer, tui_line_is_displayed)
8162         (tui_addr_is_displayed): Change type of win_info.  Update.
8163         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
8164         (tui_source_window_base::do_make_visible_with_new_height):
8165         Update.
8166         * tui/tui-source.c (tui_set_source_content)
8167         (tui_set_source_content_nil)
8168         (tui_source_window::do_scroll_vertical): Update.
8169         * tui/tui-layout.c (show_layout): Update.
8170         * tui/tui-disasm.c (tui_set_disassem_content)
8171         (tui_disasm_window::do_scroll_vertical): Update.
8172         * tui/tui-data.h (tui_win_content): Remove.
8173         (struct tui_gen_win_info) <content, content_size>: Remove.
8174         (struct tui_source_element): Add initializers and destructor.
8175         (union tui_which_element, struct tui_win_element): Remove.
8176         (struct tui_source_window_base) <content>: New field.
8177         (struct tui_data_window): Remove destructor.
8178         (tui_alloc_content, tui_free_win_content)
8179         (tui_free_all_source_wins_content): Don't declare.
8180         * tui/tui-data.c (tui_initialize_static_data): Update.
8181         (init_content_element, tui_alloc_content): Remove.
8182         (~tui_gen_win_info): Update.
8183         (~tui_data_window, tui_free_all_source_wins_content)
8184         (tui_free_win_content, free_content, free_content_elements):
8185         Remove.
8186
8187 2019-06-25  Tom Tromey  <tom@tromey.com>
8188
8189         * tui/tui-winsource.h (tui_clear_source_content)
8190         (tui_erase_source_content, tui_show_source_content): Change type
8191         of win_info.
8192         * tui/tui-winsource.c (tui_clear_source_content)
8193         (tui_erase_source_content, tui_show_source_content): Change type
8194         of win_info.
8195         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
8196         * tui/tui-source.h (tui_set_source_content_nil): Change type of
8197         win_info.
8198         * tui/tui-source.c (tui_set_source_content_nil): Change type of
8199         win_info.
8200         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
8201
8202 2019-06-25  Tom Tromey  <tom@tromey.com>
8203
8204         * tui/tui-winsource.c (tui_clear_source_content)
8205         (tui_source_window_base::set_is_exec_point_at): Update.
8206         * tui/tui-source.c (tui_set_source_content_nil): Update.
8207         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
8208         a bool.
8209         * tui/tui-data.c (init_content_element): Update.
8210
8211 2019-06-25  Tom Tromey  <tom@tromey.com>
8212
8213         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
8214         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
8215         * tui/tui-layout.c (init_and_make_win): Update.
8216         * tui/tui.h (enum tui_win_type): Update.
8217         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
8218         tui_win_is_auxillary.
8219         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
8220         tui_win_is_auxillary.
8221
8222 2019-06-25  Tom Tromey  <tom@tromey.com>
8223
8224         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
8225         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
8226         (tui_delete_data_content_windows, tui_display_all_data)
8227         (tui_data_window::do_scroll_vertical, tui_display_data_from):
8228         Update.
8229         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
8230         * tui/tui-regs.c (tui_last_regs_line_no)
8231         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
8232         (tui_show_registers): Update.
8233         (tui_show_register_group): Return void.  Update.
8234         (tui_display_registers_from, tui_display_reg_element_at_line)
8235         (tui_display_registers_from_line, tui_check_register_values):
8236         Update.
8237         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
8238         member.
8239         (struct tui_data_window) <regs_content>: Now a std::vector.
8240         <regs_content_count>: Remove.
8241         (tui_add_content_elements, tui_free_data_content): Don't declare.
8242         * tui/tui-data.c (tui_data_window::clear_detail): Update.
8243         (init_content_element): Remove DATA_WIN case.  Add assert.
8244         (tui_add_content_elements): Remove.
8245         (tui_data_window): Update.
8246         (tui_free_data_content): Remove.
8247         (free_content_elements): Remove DATA_WIN case.
8248
8249 2019-06-25  Tom Tromey  <tom@tromey.com>
8250
8251         * tui/tui-data.c (tui_data_item_window): Update.
8252         * tui/tui-windata.h (tui_check_data_values): Don't declare.
8253         * tui/tui-windata.c (tui_display_all_data)
8254         (tui_display_data_from_line): Update.
8255         (tui_check_data_values): Remove.
8256         * tui/tui-regs.c (tui_show_register_group)
8257         (tui_display_reg_element_at_line): Update.
8258         * tui/tui-hooks.c (tui_register_changed)
8259         (tui_refresh_frame_and_register_information): Call
8260         tui_check_register_values.
8261         * tui/tui-data.h (struct tui_data_window) <data_content,
8262         data_content_count, data_type>: Remove.
8263         (enum tui_data_type): Remove.
8264
8265         * tui/tui-data.c (tui_data_window::clear_detail)
8266         (~tui_data_window): Update.
8267
8268 2019-06-25  Tom Tromey  <tom@tromey.com>
8269
8270         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
8271         declare.
8272         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
8273         Rename from tui_first_data_item_displayed.  Update.
8274         (tui_data_window::refresh_all)
8275         (tui_data_window::do_scroll_vertical): Update.
8276         * tui/tui-data.h (struct tui_data_window)
8277         <first_data_item_displayed>: Declare new method.
8278
8279 2019-06-25  Tom Tromey  <tom@tromey.com>
8280
8281         * tui/tui-data.h (tui_init_generic_part): Don't declare.
8282         * tui/tui-data.c (tui_init_generic_part): Remove, moving
8283         contents...
8284         (tui_initialize_static_data): ...here.
8285
8286 2019-06-25  Tom Tromey  <tom@tromey.com>
8287
8288         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
8289         (tui_display_registers_from, tui_check_register_values): Update.
8290         (tui_display_register): Remove win_info parameter; update.
8291         (tui_get_register): Change type of parameters.
8292         * tui/tui-data.h (struct tui_data_element): Remove.
8293         (union tui_which_element) <data>: Remove.
8294         <data_window>: Change type.
8295         (struct tui_data_item_window): New.
8296         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
8297         case.  Add assert.
8298         (~tui_data_item_window): New destructor.
8299         (free_content_elements): Remove DATA_ITEM_WIN case.
8300
8301 2019-06-25  Tom Tromey  <tom@tromey.com>
8302
8303         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
8304         Remove.
8305
8306 2019-06-25  Tom Tromey  <tom@tromey.com>
8307
8308         * tui/tui-data.h (struct tui_command_element): Remove.
8309         (union tui_which_element) <command>: Remove.
8310         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
8311         assert.
8312         (free_content_elements): Remove CMD_WIN case.
8313
8314 2019-06-25  Tom Tromey  <tom@tromey.com>
8315
8316         * tui/tui-layout.c (tui_set_layout): Update.
8317         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
8318         * tui/tui-data.c (layout_def): Update.
8319
8320 2019-06-25  Tom Tromey  <tom@tromey.com>
8321
8322         * tui/tui-wingeneral.c (tui_refresh_all): Update.
8323         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
8324         (tui_source_window_base::set_new_height): Update.
8325         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
8326         Update.
8327         (tui_set_locator_fullname, tui_set_locator_info)
8328         (tui_show_frame_info): Update.
8329         * tui/tui-source.c (tui_set_source_content)
8330         (tui_source_is_displayed): Update.
8331         * tui/tui-layout.c (show_source_disasm_command, show_data)
8332         (show_source_or_disasm_and_command): Update.
8333         * tui/tui-disasm.c (tui_set_disassem_content)
8334         (tui_get_begin_asm_address): Update.
8335         * tui/tui-data.h (struct tui_locator_element): Remove.
8336         (union tui_which_element) <locator>: Remove.
8337         (struct tui_locator_window): New.
8338         (tui_locator_win_info_ptr): Change return type.
8339         * tui/tui-data.c (_locator): Change type.
8340         (tui_locator_win_info_ptr): Change return type.
8341         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
8342         (tui_alloc_content): Add assert.
8343
8344 2019-06-25  Tom Tromey  <tom@tromey.com>
8345
8346         * tui/tui-winsource.c
8347         (tui_exec_info_window::maybe_allocate_content): New method.
8348         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
8349         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
8350         (make_source_or_disasm_window): Add cast.
8351         * tui/tui-data.h (union tui_which_element) <simple_string>:
8352         Remove.
8353         (struct tui_source_info): New.
8354         (struct tui_source_window_base) <execution_info>: Change type.
8355         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
8356         case, and add assert.
8357         (tui_alloc_content): Add assert.
8358
8359 2019-06-25  Tom Tromey  <tom@tromey.com>
8360
8361         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
8362         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
8363         * tui/tui-data.c (tui_alloc_win_info): Remove.
8364
8365 2019-06-25  Tom Tromey  <tom@tromey.com>
8366
8367         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
8368         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
8369         can_highlight.
8370
8371 2019-06-25  Tom Tromey  <tom@tromey.com>
8372
8373         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
8374         make_visible_with_new_height method.
8375         (tui_win_info::make_visible_with_new_height): New method.
8376         (tui_source_window_base::do_make_visible_with_new_height)
8377         (tui_data_window::do_make_visible_with_new_height)
8378         (tui_cmd_window::do_make_visible_with_new_height): New methods.
8379         (make_visible_with_new_height): Remove.
8380         (tui_resize_all, tui_adjust_win_heights): Use
8381         make_visible_with_new_height method.
8382         * tui/tui-data.h (struct tui_win_info)
8383         <do_make_visible_with_new_height, make_visible_with_new_height>:
8384         New methods.
8385         (struct tui_source_window_base, struct tui_data_window)
8386         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
8387         methods.
8388
8389 2019-06-25  Tom Tromey  <tom@tromey.com>
8390
8391         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
8392         method.
8393         (update_tab_width): Call update_tab_width method.
8394         * tui/tui-data.h (struct tui_win_info)
8395         (struct tui_source_window_base) <update_tab_width>: New methods.
8396
8397 2019-06-25  Tom Tromey  <tom@tromey.com>
8398
8399         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
8400         parameter.
8401         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
8402         parameter.
8403         (tui_gen_win_info::make_visible): Update.
8404         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
8405         parameter.
8406         * tui/tui-data.h (enum tui_box): New enum.
8407         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
8408
8409 2019-06-25  Tom Tromey  <tom@tromey.com>
8410
8411         * tui/tui-layout.c (make_source_or_disasm_window): Always use
8412         init_and_make_win for EXEC_INFO_WIN.
8413         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
8414         longer inline.
8415         (struct tui_win_info) <~tui_win_info>: Inline.
8416         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
8417         Don't declare.
8418         * tui/tui-data.c (source_win, disasm_win): Remove globals.
8419         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
8420         Remove.
8421         (tui_initialize_static_data): Update.
8422         (~tui_gen_win_info): Handle more cleanup here.
8423         (~tui_source_window_base): Delete "execution_info".
8424         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
8425
8426 2019-06-25  Tom Tromey  <tom@tromey.com>
8427
8428         * tui/tui-layout.c (make_command_window): Don't set
8429         can_highlight.
8430         (show_source_disasm_command): Call the reset method.
8431         (show_data): Don't set can_highlight.  Call the reset method.
8432         (tui_gen_win_info::reset): Rename from init_gen_win_info
8433         (init_and_make_win): Simplify.  Return tui_gen_win_info.
8434         (show_source_or_disasm_and_command): Call the reset method.
8435         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
8436         (struct tui_cmd_window): Set can_highlight.
8437
8438 2019-06-25  Tom Tromey  <tom@tromey.com>
8439
8440         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
8441         from make_visible.
8442         (tui_make_visible, tui_make_invisible): Rewrite.
8443         (tui_win_info::make_visible): Remove.
8444         (tui_source_window_base::make_visible): Update.
8445         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
8446         method.  Moved from...
8447         (struct tui_win_info) <make_visible>: ...here.
8448
8449 2019-06-25  Tom Tromey  <tom@tromey.com>
8450
8451         * tui/tui-winsource.c
8452         (tui_source_window_base::do_scroll_horizontal): Remove direction
8453         parameter.
8454         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
8455         direction parameter.
8456         * tui/tui-win.c (tui_win_info::forward_scroll)
8457         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
8458         (tui_win_info::right_scroll): Update.
8459         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
8460         direction parameter.
8461         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
8462         direction parameter.
8463         * tui/tui-data.h (enum tui_scroll_direction): Remove.
8464         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
8465         Remove direction parameter.
8466         (struct tui_source_window_base, struct tui_source_window)
8467         (struct tui_disasm_window, struct tui_data_window)
8468         (struct tui_cmd_window): Update.
8469
8470 2019-06-25  Tom Tromey  <tom@tromey.com>
8471
8472         * tui/tui-winsource.h (tui_set_exec_info_content)
8473         (tui_show_exec_info_content, tui_erase_exec_info_content)
8474         (tui_clear_exec_info_content, tui_update_exec_info): Change
8475         argument to tui_source_window_base.
8476         * tui/tui-winsource.c (tui_set_exec_info_content)
8477         (tui_show_exec_info_content, tui_erase_exec_info_content)
8478         (tui_clear_exec_info_content, tui_update_exec_info): Change
8479         argument to tui_source_window_base.
8480
8481 2019-06-25  Tom Tromey  <tom@tromey.com>
8482
8483         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
8484         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
8485
8486 2019-06-25  Tom Tromey  <tom@tromey.com>
8487
8488         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
8489         check.
8490
8491 2019-06-25  Tom Tromey  <tom@tromey.com>
8492
8493         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
8494         type to void.
8495         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
8496         type to void.
8497         * tui/tui-source.c (tui_set_source_content): Update.
8498         * tui/tui-disasm.c (tui_set_disassem_content): Update.
8499
8500 2019-06-25  Tom Tromey  <tom@tromey.com>
8501
8502         * tui/tui-win.c (window_name_completer, tui_set_focus)
8503         (tui_all_windows_info): Use name method.
8504         * tui/tui-data.h (struct tui_gen_win_info)
8505         (struct tui_source_window, struct tui_disasm_window)
8506         (struct tui_data_window, struct tui_cmd_window) <name>: New
8507         method.
8508         (tui_win_name): Don't declare.
8509         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
8510         (tui_win_name): Remove.
8511
8512 2019-06-25  Tom Tromey  <tom@tromey.com>
8513
8514         * tui/tui-winsource.h (tui_update_source_window)
8515         (tui_update_source_window_as_is): Change parameter type.
8516         * tui/tui-winsource.c (tui_update_source_window): Change win_info
8517         to be a tui_source_window_base.
8518         (tui_update_source_window_as_is): Likewise.
8519         * tui/tui-win.c (make_visible_with_new_height): Update.
8520
8521 2019-06-25  Tom Tromey  <tom@tromey.com>
8522
8523         * tui/tui-winsource.c (tui_erase_source_content)
8524         (tui_show_source_content, tui_show_exec_info_content)
8525         (tui_erase_exec_info_content): Use refresh_window method.
8526         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
8527         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
8528         from tui_refresh_win.
8529         (tui_data_window::refresh_window): New method.
8530         (tui_win_info::refresh, tui_source_window_base::refresh)
8531         (tui_refresh_all): Use refresh_window method.
8532         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
8533         method.
8534         * tui/tui-regs.c (tui_display_register): Call refresh_window
8535         method.
8536         * tui/tui-layout.c (show_source_disasm_command)
8537         (show_source_or_disasm_and_command): Call refresh_window method.
8538         * tui/tui-data.h (struct tui_gen_win_info)
8539         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
8540         New method.
8541
8542 2019-06-25  Tom Tromey  <tom@tromey.com>
8543
8544         * tui/tui.c (tui_rl_other_window, tui_enable)
8545         (tui_is_window_visible, tui_get_command_dimension): Update.
8546         * tui/tui-winsource.c (tui_update_source_window_as_is)
8547         (tui_clear_source_content, tui_erase_source_content)
8548         (tui_show_source_line, tui_source_window_base::refill)
8549         (tui_source_window_base::do_scroll_horizontal)
8550         (tui_source_window_base::set_is_exec_point_at)
8551         (tui_update_breakpoint_info, tui_set_exec_info_content)
8552         (tui_alloc_source_buffer, tui_line_is_displayed)
8553         (tui_addr_is_displayed): Update.
8554         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
8555         (tui_check_and_display_highlight_if_needed)
8556         (tui_win_info::make_visible, tui_win_info::refresh)
8557         (tui_refresh_all): Update.
8558         * tui/tui-windata.c (tui_first_data_item_displayed)
8559         (tui_delete_data_content_windows, tui_erase_data_content)
8560         (tui_display_all_data, tui_data_window::refresh_all)
8561         (tui_check_data_values): Update.
8562         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
8563         (tui_set_win_focus_to, tui_win_info::forward_scroll)
8564         (tui_win_info::backward_scroll, tui_refresh_all_win)
8565         (tui_resize_all, tui_set_focus, tui_all_windows_info)
8566         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
8567         (tui_source_window_base::set_new_height)
8568         (tui_data_window::set_new_height)
8569         (make_invisible_and_set_new_height)
8570         (make_visible_with_new_height, new_height_ok)
8571         (parse_scrolling_args): Update.
8572         * tui/tui-stack.c (tui_show_frame_info): Update.
8573         * tui/tui-source.c (tui_set_source_content)
8574         (tui_set_source_content_nil, tui_source_is_displayed)
8575         (tui_source_window::do_scroll_vertical): Update.
8576         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
8577         (tui_display_registers_from, tui_display_reg_element_at_line)
8578         (tui_check_register_values, tui_reg_command): Update.
8579         * tui/tui-layout.c (tui_default_win_height)
8580         (show_source_disasm_command, show_data, init_and_make_win)
8581         (show_source_or_disasm_and_command): Update.
8582         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
8583         (tui_redisplay_readline, tui_mld_flush)
8584         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
8585         (tui_getc): Update.
8586         * tui/tui-disasm.c (tui_set_disassem_content)
8587         (tui_disasm_window::do_scroll_vertical): Update.
8588         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
8589         Now virtual.
8590         (struct tui_win_info): Derive from tui_gen_win_info.
8591         <~tui_win_info>: Mark as override.
8592         <generic>: Remove member.
8593         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
8594         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
8595         (~tui_data_window, ~tui_win_info)
8596         (tui_free_all_source_wins_content): Update.
8597         * tui/tui-command.c (tui_refresh_cmd_win): Update.
8598
8599 2019-06-25  Tom Tromey  <tom@tromey.com>
8600
8601         * tui/tui-layout.c (init_and_make_win): Use new.
8602         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
8603         destructor, initializers.
8604         (tui_alloc_generic_win_info): Don't declare.
8605         * tui/tui-data.c (_locator): Add argument to constructor.
8606         (source_win, disasm_win): New globals.
8607         (exec_info): Remove.
8608         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
8609         Update.
8610         (tui_alloc_generic_win_info): Remove.
8611         (init_content_element): Use new.
8612         (tui_win_info::tui_win_info): Update.
8613         (free_content_elements) <case DATA_WIN>: Use delete.
8614
8615 2019-06-25  Tom Tromey  <tom@tromey.com>
8616
8617         * tui/tui-wingeneral.c (tui_refresh_win): Update.
8618         * tui/tui-windata.c (tui_first_data_item_displayed)
8619         (tui_delete_data_content_windows): Update.
8620         * tui/tui-win.c (tui_data_window::set_new_height): Update.
8621         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
8622         (tui_display_registers_from, tui_check_register_values): Update.
8623         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
8624         pointer.
8625         * tui/tui-data.c (init_content_element): Update.  Allocate the new
8626         window.
8627         (tui_free_data_content): Update.
8628         (free_content_elements) <case DATA_WIN>: Free the window.
8629
8630 2019-06-25  Tom Tromey  <tom@tromey.com>
8631
8632         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
8633         Update.
8634         * tui/tui-layout.c (make_command_window)
8635         (show_source_disasm_command, show_data, init_and_make_win)
8636         (show_source_or_disasm_and_command): Update.
8637         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
8638         method.
8639         <can_highight, is_highlighted>: Now bool.
8640         (tui_set_win_highlight): Don't declare.
8641         * tui/tui-data.c (tui_set_win_highlight): Remove.
8642
8643 2019-06-25  Tom Tromey  <tom@tromey.com>
8644
8645         * tui/tui-wingeneral.c (make_visible): Remove check of window
8646         type.
8647
8648 2019-06-25  Tom Tromey  <tom@tromey.com>
8649
8650         * tui/tui-win.c (tui_win_info::max_height)
8651         (tui_cmd_window::max_height): New methods.
8652         (new_height_ok): Call max_height.
8653         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
8654         <max_height>: New method.
8655
8656 2019-06-25  Tom Tromey  <tom@tromey.com>
8657
8658         * tui/tui-win.c (tui_source_window_base::set_new_height)
8659         (tui_data_window::set_new_height): New methods.
8660         (make_invisible_and_set_new_height): Call set_new_height method.
8661         * tui/tui-data.h (struct tui_win_info)
8662         (struct tui_source_window_base, struct tui_data_window)
8663         <set_new_height>: New method.
8664
8665 2019-06-25  Tom Tromey  <tom@tromey.com>
8666
8667         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
8668         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
8669         tui_refresh_data_win.
8670         * tui/tui-win.c (tui_source_window_base::refresh_all): New
8671         method.
8672         (tui_refresh_all_win): Call the refresh_all method.
8673         (tui_set_focus): Likewise.
8674         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
8675         (struct tui_source_window_base, struct tui_data_window) <refresh>:
8676         Likewise.
8677
8678 2019-06-25  Tom Tromey  <tom@tromey.com>
8679
8680         * tui/tui-winsource.h (tui_refill_source_window)
8681         (tui_set_is_exec_point_at): Don't declare.
8682         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
8683         (tui_source_window_base::refill): Rename from
8684         tui_refill_source_window.
8685         (tui_source_window_base::do_scroll_horizontal): Update.
8686         (tui_source_window_base::set_is_exec_point_at): Rename from
8687         tui_set_is_exec_point_at.
8688         (tui_update_all_breakpoint_info): Update.
8689         * tui/tui-stack.c (tui_show_frame_info): Update.
8690         * tui/tui-layout.c (show_data): Add cast.
8691         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
8692         * tui/tui-data.h (struct tui_source_window_base) <refill,
8693         set_is_exec_point_at>: New methods.
8694         (tui_source_windows, tui_add_to_source_windows): Update types.
8695         (tui_add_to_source_windows): Remove redundant declaration.
8696         * tui/tui-data.c (source_windows): Store tui_source_window_base.
8697         (tui_source_windows): Change return type.
8698         (tui_clear_source_windows_detail): Update.
8699         (tui_add_to_source_windows): Change type of parameter.
8700         (tui_free_all_source_wins_content): Update.
8701
8702 2019-06-25  Tom Tromey  <tom@tromey.com>
8703
8704         * tui/tui-wingeneral.c (tui_win_info::refresh)
8705         (tui_source_window_base::refresh): New methods.
8706         (tui_refresh_all): Call the refresh method.
8707         * tui/tui-data.h (struct tui_win_info)
8708         (struct tui_source_window_base) <refresh>: New method.
8709
8710 2019-06-25  Tom Tromey  <tom@tromey.com>
8711
8712         * tui/tui.h (tui_is_window_visible): Return bool.
8713         * tui/tui.c (tui_is_window_visible): Return bool.
8714         * tui/tui-wingeneral.c (tui_make_window, make_visible)
8715         (tui_make_visible, tui_make_invisible)
8716         (tui_win_info::make_visible)
8717         (tui_source_window_base::make_visible, make_all_visible)
8718         (tui_make_all_visible, tui_make_all_invisible): Update.
8719         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
8720         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
8721         bool.
8722         (struct tui_win_info, struct tui_source_window_base)
8723         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
8724         * tui/tui-data.c (tui_init_generic_part): Update.
8725
8726 2019-06-25  Tom Tromey  <tom@tromey.com>
8727
8728         * tui/tui-wingeneral.c (tui_win_info::make_visible)
8729         (tui_source_window_base::make_visible): New methods.
8730         (make_all_visible): Make method call.
8731         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
8732         (struct tui_source_window_base, struct tui_cmd_window): Override
8733         make_visible.
8734         (tui_win_is_source_type): Don't declare.
8735         * tui/tui-data.c (tui_win_is_source_type): Remove.
8736
8737 2019-06-25  Tom Tromey  <tom@tromey.com>
8738
8739         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
8740         NULL check.
8741
8742 2019-06-25  Tom Tromey  <tom@tromey.com>
8743
8744         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
8745         Inline constructor.  Add initializers for members.
8746         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
8747         constructors; now inline in class.
8748
8749 2019-06-25  Tom Tromey  <tom@tromey.com>
8750
8751         * tui/tui-regs.c (tui_show_registers): Update.
8752         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
8753         bool.
8754         * tui/tui-data.c (tui_data_window::clear_detail)
8755         (tui_data_window): Update.
8756
8757 2019-06-25  Tom Tromey  <tom@tromey.com>
8758
8759         * tui/tui-windata.c (tui_display_all_data)
8760         (tui_display_data_from_line, tui_display_data_from)
8761         (tui_check_data_values, tui_data_window::do_scroll_vertical):
8762         Update.
8763         * tui/tui-regs.c (tui_last_regs_line_no)
8764         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
8765         (tui_show_registers, tui_show_register_group)
8766         (tui_display_registers_from, tui_display_reg_element_at_line)
8767         (tui_display_registers_from_line, tui_check_register_values)
8768         (tui_reg_next, tui_reg_prev): Update.
8769         * tui/tui-layout.c (tui_set_layout, show_data): Update.
8770         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
8771         tui_data_window.
8772         (struct tui_win_info) <detail>: Remove.  Add new fields from
8773         tui_data_info.
8774         (TUI_DATA_WIN): Add cast.
8775         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
8776         (~tui_data_window): Simplify.
8777
8778 2019-06-25  Tom Tromey  <tom@tromey.com>
8779
8780         * tui/tui-layout.c (show_source_disasm_command)
8781         (show_source_or_disasm_and_command): Update.
8782         * tui/tui-io.c (update_cmdwin_start_line)
8783         (tui_redisplay_readline): Update.
8784         * tui/tui-data.h (struct tui_command_info): Remove.
8785         (struct tui_win_info) <detail>: Remove command_info member.
8786         (struct tui_data_window) <start_line>: New member, from
8787         tui_command_info.
8788         (TUI_CMD_WIN): Add casts.
8789
8790 2019-06-25  Tom Tromey  <tom@tromey.com>
8791
8792         * tui/tui-winsource.c (tui_update_source_window)
8793         (tui_refill_source_window)
8794         (tui_source_window_base::do_scroll_horizontal)
8795         (tui_update_breakpoint_info, tui_set_exec_info_content)
8796         (tui_show_exec_info_content, tui_erase_exec_info_content)
8797         (tui_clear_exec_info_content): Update.
8798         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
8799         Update.
8800         * tui/tui-win.c (make_invisible_and_set_new_height)
8801         (make_visible_with_new_height): Update.
8802         * tui/tui-source.c (tui_set_source_content)
8803         (tui_show_symtab_source): Update.
8804         * tui/tui-layout.c (extract_display_start_addr)
8805         (show_source_disasm_command, show_data)
8806         (make_source_or_disasm_window)
8807         (show_source_or_disasm_and_command): Update.
8808         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
8809         (tui_disasm_window::do_scroll_vertical): Remove shadowing
8810         "gdbarch".
8811         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
8812         to tui_source_window_base.
8813         (struct tui_win_info) <detail>: Remove source_info member.
8814         (struct tui_source_window_base) <has_locator>: Inline.
8815         Move contents from tui_source_info; rename has_locator member to
8816         m_has_locator.
8817         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
8818         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
8819         header file.
8820         (tui_source_window_base::clear_detail, ~tui_source_window_base):
8821         Simplify.
8822         (tui_free_all_source_wins_content): Cast to
8823         tui_source_window_base.
8824
8825 2019-06-25  Tom Tromey  <tom@tromey.com>
8826
8827         * tui/tui-win.c (make_invisible_and_set_new_height)
8828         (make_visible_with_new_height): Call has_locator method.
8829         * tui/tui-layout.c (show_source_disasm_command, show_data)
8830         (show_source_or_disasm_and_command): Update for bool change.
8831         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
8832         (tui_win_info) <has_locator>: New method.
8833         (struct tui_source_window_base) <has_locator>: New method.
8834         (tui_win_has_locator): Don't declare.
8835         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
8836         from tui_win_has_locator.
8837         (tui_source_window_base): Use false, not FALSE.
8838
8839 2019-06-25  Tom Tromey  <tom@tromey.com>
8840
8841         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
8842         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
8843         clear_detail method directly.
8844         (tui_clear_win_detail): Remove.
8845
8846 2019-06-25  Tom Tromey  <tom@tromey.com>
8847
8848         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
8849         "this", not TUI_DISASM_WIN.
8850
8851 2019-06-25  Tom Tromey  <tom@tromey.com>
8852
8853         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
8854         declare.
8855         * tui/tui-winsource.c
8856         (tui_source_window_base::do_scroll_horizontal): Rename from
8857         tui_horizontal_source_scroll.
8858         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
8859         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
8860         from tui_vertical_data_scroll.
8861         * tui/tui-win.h (tui_scroll): Don't declare.
8862         * tui/tui-win.c (tui_win_info::forward_scroll)
8863         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
8864         (tui_win_info::right_scroll): Rename and update.
8865         (tui_scroll_forward_command, tui_scroll_backward_command)
8866         (tui_scroll_left_command, tui_scroll_right_command): Update.
8867         (tui_scroll): Remove.
8868         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
8869         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
8870         from tui_vertical_source_scroll.
8871         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
8872         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
8873         from tui_vertical_disassem_scroll.
8874         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
8875         do_scroll_horizontal>: New methods.
8876         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
8877         Likewise.
8878         (struct tui_source_window_base): Add do_scroll_horizontal.
8879         (struct tui_source_window, struct tui_disasm_window): Add
8880         do_scroll_vertical.
8881         (struct tui_data_window, struct tui_cmd_window): Add
8882         do_scroll_horizontal and do_scroll_vertical.
8883         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
8884
8885 2019-06-25  Tom Tromey  <tom@tromey.com>
8886
8887         * tui/tui-data.h (struct tui_source_window_base): New struct.
8888         (struct tui_source_window): Derive from tui_source_window_base.
8889         (struct tui_disasm_window): New struct.
8890         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
8891         from tui_source_window::clear_detail.
8892         (tui_source_window_base): Rename from tui_source_window.
8893         (~tui_source_window_base): Rename from ~tui_source_window.
8894         (tui_alloc_win_info): Create a tui_disasm_window.
8895
8896 2019-06-25  Tom Tromey  <tom@tromey.com>
8897
8898         * tui/tui-data.h (struct tui_source_window)
8899         (struct tui_data_window): Declare destructors.
8900         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
8901         destructors.
8902         (tui_win_info): Simplify.
8903
8904 2019-06-25  Tom Tromey  <tom@tromey.com>
8905
8906         * tui/tui-winsource.c (tui_display_main)
8907         (tui_update_source_windows_with_addr)
8908         (tui_update_all_breakpoint_info): Update.
8909         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
8910         (new_height_ok, parse_scrolling_args): Update.
8911         * tui/tui-stack.c (tui_show_frame_info): Update.
8912         * tui/tui-data.h (struct tui_list): Remove.
8913         (tui_source_windows): Return a reference to a std::vector.
8914         * tui/tui-data.c (source_windows): Now a std::vector.
8915         (tui_source_windows): Change return type.
8916         (tui_clear_source_windows): Rewrite.
8917         (tui_clear_source_windows_detail, tui_add_to_source_windows)
8918         (tui_free_all_source_wins_content): Rewrite.
8919
8920 2019-06-25  Tom Tromey  <tom@tromey.com>
8921
8922         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
8923         (struct tui_data_window, struct tui_cmd_window): Declare
8924         clear_detail method.
8925         * tui/tui-data.c (tui_source_window::clear_detail)
8926         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
8927         methods.
8928         (tui_clear_win_detail): Simplify.
8929
8930 2019-06-25  Tom Tromey  <tom@tromey.com>
8931
8932         * tui/tui-layout.c (make_source_window, make_disasm_window)
8933         (make_source_or_disasm_window): Remove win_info_ptr parameter.
8934         Return the new window.
8935         (show_source_disasm_command, show_data)
8936         (show_source_or_disasm_and_command): Update.
8937
8938 2019-06-25  Tom Tromey  <tom@tromey.com>
8939
8940         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
8941         parameter.  Return the new window.
8942         (show_source_disasm_command): Update and remove NULL check.
8943         (show_source_or_disasm_and_command): Update.
8944
8945 2019-06-25  Tom Tromey  <tom@tromey.com>
8946
8947         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
8948
8949 2019-06-25  Tom Tromey  <tom@tromey.com>
8950
8951         * tui/tui-data.h (struct tui_win_info): Make constructor
8952         protected.  Make destructor virtual.  Add initializers.
8953         (tui_source_window, tui_data_window, tui_cmd_window): New
8954         classes.
8955         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
8956         constructor.  Add "type" parameter.
8957         (tui_source_window, tui_data_window, tui_cmd_window): New
8958         constructors.
8959         (tui_alloc_win_info): Instantiate the appropriate subclass.
8960
8961 2019-06-25  Tom Tromey  <tom@tromey.com>
8962
8963         * tui/tui-win.c (tui_resize_all): Use delete.
8964         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
8965         destructor.
8966         (tui_free_window): Don't declare.
8967         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
8968         Update.
8969
8970 2019-06-25  Tom Tromey  <tom@tromey.com>
8971
8972         * tui/tui-data.h (struct tui_win_info): Add constructor.
8973         * tui/tui-data.c (tui_alloc_win_info): Use new.
8974         (tui_free_window): Use delete.
8975
8976 2019-06-22  Tom Tromey  <tom@tromey.com>
8977
8978         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
8979         declare.
8980         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
8981
8982 2019-06-22  Tom Tromey  <tom@tromey.com>
8983
8984         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
8985         declare.
8986         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
8987
8988 2019-06-22  Tom de Vries  <tdevries@suse.de>
8989
8990         * dwarf2read.c (create_addrmap_from_aranges)
8991         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
8992         instead of '%zu'.
8993
8994 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
8995
8996         * dwarf2read.h (dwarf2_section_info_def): Remove.
8997         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
8998         * dwarf2read.c (struct dwo_sections) <types>: Change type to
8999         std::vector<dwarf2_section_info>.
9000         (struct dwo_file) <~dwo_file>: Remove.
9001         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
9002         types field.
9003         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
9004         (dwarf2_read_debug_names): Likewise.
9005         (create_debug_types_hash_table): Change parameter type to
9006         array_view, adjust code accordingly.
9007         (dwarf2_locate_dwo_sections): Adjust to std::vector.
9008         (partial_die_info::fixup): Likewise.
9009         (determine_prefix): Likewise.
9010         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
9011
9012 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
9013
9014         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
9015         gdb_bfd_ref_ptr.
9016         <~dwo_file>: Remove call to gdb_bfd_unref.
9017         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
9018         gdb_bfd_ref_ptr::get.
9019
9020 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
9021
9022         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
9023         type to htab_up.
9024         * dwarf2read.c (struct dwo_file): Initialize fields.
9025         <~dwo_file>: New.
9026         (free_dwo_file): Remove, move content to ~dwo_file.
9027         (struct dwo_file_deleter): Remove.
9028         (dwo_file_up>: Remove custom deleter.
9029         (free_dwo_files): Remove.
9030         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
9031         dwo_files.
9032         (process_skeletonless_type_units): Call unique_ptr::get.
9033         (allocate_dwo_file_hash_table): Add deleter to created hash
9034         table.  Change return type to htab_up.
9035         (lookup_dwo_file_slot): Don't memset dwo_file, call
9036         unique_ptr::get.
9037         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
9038         (create_dwo_unit_in_dwp_v2): Likewise.
9039         (open_and_init_dwo_file): Likewise.
9040         (free_dwo_file_from_slot): Remove.
9041
9042 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
9043
9044         * dwarf2read.h (struct dwarf2_section_info) <readin,
9045         is_virtual>: Change type to bool.
9046         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
9047         true instead of 1.
9048
9049 2019-06-19  Tom Tromey  <tom@tromey.com>
9050
9051         * tui/tui-data.h (tui_init_content_element): Don't declare.
9052
9053 2019-06-19  Tom Tromey  <tom@tromey.com>
9054
9055         * tui/tui-data.h (tui_init_win_info): Don't declare.
9056
9057 2019-06-19  Tom de Vries  <tdevries@suse.de>
9058
9059         * dwarf2read.h (abstract_to_concrete): Change type to
9060         std::unordered_map<sect_offset, std::vector<sect_offset>,
9061         gdb::hash_enum<sect_offset>>.
9062
9063 2019-06-19  Tom Tromey  <tromey@adacore.com>
9064
9065         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
9066         EVAL_AVOID_SIDE_EFFECTS specially.
9067
9068 2019-06-19  Tom Tromey  <tromey@adacore.com>
9069
9070         * source-cache.c (highlighter): New global.
9071         (source_cache::get_source_lines): Create a highlighter on demand.
9072
9073 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
9074
9075         * defs.h (deprecated_interactive_hook): Delete declaration.
9076         * interps.c (clear_interpreter_hooks): Remove use of
9077         deprecated_interactive_hook.
9078         * top.c (deprecated_interactive_hook): Delete definition.
9079         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
9080
9081 2019-06-18  Tom de Vries  <tdevries@suse.de>
9082
9083         PR gdb/24515
9084         * dwarf2read.h (abstract_to_concrete): Change type from
9085         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
9086         std::unordered_map<sect_offset, std::vector<sect_offset>>.
9087         * dwarf2read.c (read_variable): Update.
9088         (dwarf2_fetch_die_loc_sect_off): Update.
9089
9090 2019-06-17  Tom de Vries  <tdevries@suse.de>
9091
9092         PR gdb/24617
9093         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
9094         accessing parent[parent_len - 1].
9095
9096 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
9097
9098         PR gdb/24364
9099         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
9100         call dtrace_process_dof with NULL dof.
9101
9102 2019-06-16  Tom de Vries  <tdevries@suse.de>
9103
9104         PR gdb/24445
9105         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
9106
9107 2019-06-16  Tom Tromey  <tom@tromey.com>
9108
9109         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
9110         (make_all_visible): Use address of member.
9111
9112 2019-06-16  Tom Tromey  <tom@tromey.com>
9113
9114         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
9115         (tui_free_window, free_content, free_content_elements): Remove
9116         unnecessary cast.
9117         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
9118         cast.
9119         * tui/tui-regs.c (tui_show_register_group)
9120         (tui_display_registers_from, tui_display_reg_element_at_line):
9121         Remove unnecessary cast.
9122
9123 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
9124
9125         * linux-nat.c (normal_mask): Delete.
9126         (_initialize_linux_nat): Don't initialise normal_mask.
9127
9128 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
9129
9130         PR gdb/24445
9131         * dwarf-index-write.h (write_psymtabs_to_index): Add
9132         dwz_basename parameter.
9133         * dwarf-index-write.c (write_gdbindex): Move file writing to
9134         write_gdbindex_1.  Change return type void.
9135         (assert_file_size): Move up, remove filename parameter.
9136         (write_gdbindex_1): New function.
9137         (write_debug_names): Change return type to void, call
9138         assert_file_size.
9139         (struct index_wip_file): New struct.
9140         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
9141         file logic to index_wip_file.  Write index for dwz file if
9142         needed.
9143         (save_gdb_index_command): Pass basename of dwz file, if present.
9144         * dwarf-index-cache.c (index_cache::store): Obtain and pass
9145         build-id of dwz file, if present.
9146         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
9147         (dwarf2_get_dwz_file): Likewise.
9148         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
9149         (dwarf2_get_dwz_file): Likewise.
9150
9151 2019-06-16  Tom Tromey  <tom@tromey.com>
9152
9153         * coffread.c (process_coff_symbol): Use xstrdup.
9154         * value.c (create_internalvar): Use xstrdup.
9155
9156 2019-06-16  Tom Tromey  <tom@tromey.com>
9157
9158         * valops.c (value_cast, value_slice): Remove unnecessary cast.
9159         * breakpoint.c (stopin_command, stopat_command)
9160         (until_break_command, decode_location_default): Remove unnecessary
9161         cast.
9162         * utils.c (subset_compare): Remove unnecessary cast.
9163         * ada-lang.c (ada_update_initial_language): Remove unnecessary
9164         cast.
9165         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
9166         cast.
9167         * infcmd.c (path_command): Remove unnecessary cast.
9168         * coffread.c (decode_type): Remove unnecessary cast.
9169         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
9170         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
9171         * tui/tui-stack.c (tui_show_locator_content)
9172         (tui_show_frame_info): Remove unnecessary cast.
9173         * tui/tui-win.c (tui_scroll_forward_command)
9174         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
9175         (parse_scrolling_args): Remove unnecessary cast.
9176         * tui/tui-data.c (init_win_info, tui_del_window)
9177         (tui_free_window, tui_del_data_windows, tui_free_data_content)
9178         (free_content_elements): Remove unnecessary cast.
9179         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
9180         unnecessary cast.
9181         * tui/tui-source.c (tui_set_source_content)
9182         (tui_vertical_source_scroll): Remove unnecessary cast.
9183         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
9184         cast.
9185         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
9186         * tui/tui-regs.c (tui_display_registers_from)
9187         (tui_display_register): Remove unnecessary cast.
9188         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
9189         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
9190         (make_visible): Remove unnecessary cast.
9191         * tui/tui-winsource.c (tui_erase_source_content)
9192         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
9193         unnecessary cast.
9194         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
9195         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
9196         * stabsread.c (read_type, read_array_type, read_range_type):
9197         Remove unnecessary cast.
9198         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
9199         (parse_symbol, parse_type, upgrade_type, parse_external)
9200         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
9201         unnecessary cast.
9202         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
9203
9204 2019-06-16  Tom Tromey  <tom@tromey.com>
9205
9206         * tui/tui-data.c (tui_alloc_generic_win_info)
9207         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
9208         checks.
9209
9210 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
9211             Andrew Burgess  <andrew.burgess@embecosm.com>
9212
9213         * f-typeprint.c (f_print_type): Don't return early for not
9214         associated or not allocated types.
9215         (f_type_print_varspec_suffix): Add print_rank parameter and print
9216         ranks of array types in case they dangling.
9217         (f_type_print_base): Add print_rank parameter.
9218
9219 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
9220
9221         * NEWS: Mention new MI commands.
9222         * break-catch-throw.c (enum exception_event_kind): Move to
9223         breakpoint.h.
9224         (print_mention_exception_catchpoint): Output text as a single
9225         message.
9226         (catch_exception_command_1): Rename to...
9227         (catch_exception_event): ...this, make non-static, update header
9228         command, and change some parameter types.
9229         (catch_catch_command): Update for changes to
9230         catch_exception_command_1.
9231         (catch_throw_command): Likewise.
9232         (catch_rethrow_command): Likewise.
9233         * breakpoint.c (enum exception_event_kind): Delete.
9234         * breakpoint.h (enum exception_event_kind): Moved here from
9235         break-catch-throw.c.
9236         (catch_exception_event): Declare.
9237         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
9238         (mi_cmd_catch_throw): New function.
9239         (mi_cmd_catch_rethrow): New function.
9240         (mi_cmd_catch_catch): New function.
9241         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
9242         'catch-catch' entries.
9243         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
9244         (mi_cmd_catch_rethrow): Declare.
9245         (mi_cmd_catch_catch): Declare.
9246
9247 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
9248
9249         * annotate.c (annotate_source_line): Change return type to void,
9250         update implementation to match.
9251         * annotate.h (annotate_source_line): Change return type to void,
9252         update header comment.
9253         * stack.c (print_frame_info): Don't change what frame information
9254         is printed based on whether annotations are on or not.
9255
9256 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
9257
9258         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
9259         (annotate_source): Make static.
9260         (annotate_source_line): Moved from source.c and renamed from
9261         identify_source_line.  Update the return type.
9262         * annotate.h (annotate_source): Delete declaration.
9263         (annotate_source_line): Declaration moved from source.h, and
9264         renamed from identify_source_line.  Return type updated.
9265         * source.c (identify_source_line): Moved to annotate.c and renamed
9266         to annotate_source_line.
9267         (info_line_command): Remove check of annotation_level.
9268         * source.h (identify_source_line): Move declaration to annotate.h
9269         and rename to annotate_source_line.
9270         * stack.c: Add 'annotate.h' include.
9271         (print_frame_info): Remove check of annotation_level before
9272         calling annotate_source_line.
9273
9274 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
9275
9276         * source-cache.c (source_cache::get_plain_source_lines): Use
9277         open_source_file_with_line_charpos instead of just
9278         open_source_file, remove call to find_source_lines.
9279         (source_cache::get_source_lines): Likewise.
9280         * source.c (find_source_lines): Make static.
9281         (get_filename_and_charpos): Renamed into...
9282         (open_source_file_with_line_charpos): ..this along with changes to
9283         return a scoped_fd, and some other minor clean ups.
9284         (identify_source_line): Use open_source_file_with_line_charpos.
9285         (search_command_helper): Use open_source_file_with_line_charpos
9286         instead of just open_source_file, remove call to
9287         find_source_lines.
9288         * source.h (open_source_file_with_line_charpos): Declare new
9289         function.
9290         (find_source_lines): Delete declaration.
9291
9292 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
9293
9294         * source.c (get_filename_and_charpos): Remove fullname
9295         parameter.
9296         (identify_source_line): Update call to get_filename_and_charpos.
9297
9298 2019-06-14  Tom Tromey  <tromey@adacore.com>
9299
9300         PR gdb/24502:
9301         * ui-style.h (skip_ansi_escape): Update comment.
9302         * ui-file.h (class no_terminal_escape_file): New class.
9303         * ui-file.c (no_terminal_escape_file::write)
9304         (no_terminal_escape_file::puts): New methods.
9305         * cli/cli-logging.c (handle_redirections): Use
9306         no_terminal_escape_file.
9307
9308 2019-06-14  Tom Tromey  <tromey@adacore.com>
9309
9310         * NEWS: Move convenience variable news above Python news.
9311
9312 2019-06-14  Tom Tromey  <tom@tromey.com>
9313
9314         * gnulib: Move directory to top-level.
9315         * configure.ac: Don't configure gnulib.
9316         * configure: Rebuild.
9317         * common/common-defs.h: Use new path to gnulib.
9318         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
9319         (GNULIB_H): Remove.
9320         (INCGNU): Look in new gnulib location.
9321         (HFILES_NO_SRCDIR): Remove gnulib files.
9322         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
9323         (generated_files): Remove GNULIB_H.
9324         ($(LIBGNU), all-lib): Remove targets.
9325         (distclean): Don't mention GNULIB_BUILDDIR.
9326         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
9327
9328 2019-06-14  Tom Tromey  <tromey@adacore.com>
9329
9330         * symfile.c (add_symbol_file_command): Remove obsolete comment.
9331         Warn if symbol file does not provide any symbols.
9332
9333 2019-06-14  Tom Tromey  <tromey@adacore.com>
9334
9335         * source.c (find_and_open_source): Respect basenames_may_differ.
9336
9337 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
9338
9339         * annotate.c (annotate_breakpoints_invalid): Make use of
9340         scoped_restore_terminal_state.
9341         (annotate_frames_invalid): Likewise.
9342
9343 2019-06-14  Tom Tromey  <tromey@adacore.com>
9344
9345         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
9346         allow assignment to an internalvar.
9347
9348 2019-06-14  Tom Tromey  <tromey@adacore.com>
9349
9350         * ada-lex.l: Allow "_" in attribute names.
9351
9352 2019-06-14  Tom Tromey  <tromey@adacore.com>
9353
9354         PR gdb/24653:
9355         * regcache.c (registers_changed): Don't call alloca.
9356         * top.c (execute_command): Don't call alloca.
9357
9358 2019-06-13  Pedro Alves  <palves@redhat.com>
9359
9360         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
9361         'expression'.  When parsing an expression, error out if there's
9362         junk after "unlimited".
9363         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
9364         (do_set_command): Adjust calls to is_unlimited_literal.
9365
9366 2019-06-13  Pedro Alves  <palves@redhat.com>
9367
9368         * compile/compile.c (make_compile_options_def_group): Add braces
9369         around array_view initializer.
9370         * thread.c (make_thread_apply_all_options_def_group)
9371         (make_thread_apply_all_options_def_group): Likewise.
9372
9373 2019-06-13  Pedro Alves  <palves@redhat.com>
9374
9375         * NEWS (New commands): Mention "maint test-options
9376         require-delimiter", "maint test-options unknown-is-error", "maint
9377         test-options unknown-is-operand" and "maint show
9378         test-options-completion-result".
9379         (New command options, command completion): New section.
9380         (Completion improvements): New section.
9381         Mention that you can abbreviate "unlimited".
9382
9383 2019-06-13  Pedro Alves  <palves@redhat.com>
9384
9385         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
9386         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
9387         * unittests/cli-utils-selftests.c (test_parse_flags)
9388         (test_parse_flags_qcs): Delete.
9389         (test_cli_utils): Don't call deleted functions.
9390
9391 2019-06-13  Pedro Alves  <palves@redhat.com>
9392
9393         * thread.c: Include "cli/cli-option.h".
9394         (tp_array_compar_ascending): Global.
9395         (tp_array_compar): Delete function.
9396         (tp_array_compar_ascending, tp_array_compar_descending): New
9397         functions.
9398         (ascending_option_def, qcs_flag_option_def)
9399         (thr_qcs_flags_option_defs)
9400         (make_thread_apply_all_options_def_group)
9401         (make_thread_apply_options_def_group): New.
9402         (thread_apply_all_command): Use gdb::option::process_options.
9403         (thread_apply_command_completer)
9404         (thread_apply_all_command_completer): New.
9405         (thread_apply_command): Use gdb::option::process_options.
9406         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
9407         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
9408         to generate help text of "thread apply".  Adjust "taas"'s help.
9409         * tid-parse.c (tid_range_parser::in_thread_range): New method.
9410         * tid-parse.h (tid_range_parser::in_thread_range): New method.
9411
9412 2019-06-13  Pedro Alves  <palves@redhat.com>
9413
9414         * thread.c (thread_apply_command): Check for invalid TID with
9415         isdigit instead of !isalpha.
9416
9417 2019-06-13  Pedro Alves  <palves@redhat.com>
9418
9419         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
9420         (validate_flags_qcs): New.
9421         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
9422         (validate_flags_qcs): Declare.
9423         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
9424         (make_frame_apply_options_def_group): New.
9425         (frame_apply_command_count): Process options with
9426         gdb::option::process_options.
9427         (frame_apply_completer): New.
9428         (frame_apply_level_completer, frame_apply_all_completer)
9429         (frame_apply_completer): New.
9430         (_initialize_stack): Update help of "frame apply", "frame apply
9431         level", "frame apply all" and "faas" to mention supported options
9432         and install command completers.
9433         * stack.h (frame_apply_all_completer): Declare.
9434         * thread.c: Include "stack.h".
9435         (tfaas_command): Add "--".
9436         (_initialize_thread): Update help "tfaas" to mention supported
9437         options and install command completer.
9438
9439 2019-06-13  Pedro Alves  <palves@redhat.com>
9440
9441         * completer.c (complete_nested_command_line): New.
9442         (gdb_completion_word_break_characters_throw): Add assertion.
9443         * completer.h (complete_nested_command_line): Declare.
9444
9445 2019-06-13  Pedro Alves  <palves@redhat.com>
9446
9447         * stack.c (parse_backtrace_qualifiers): New.
9448         (backtrace_command): Use it.
9449         (backtrace_command_completer): Complete on qualifiers.
9450
9451 2019-06-13  Pedro Alves  <palves@redhat.com>
9452
9453         * frame.c: Include "cli/cli-option.h.
9454         (user_set_backtrace_options): New.
9455         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
9456         Delete.
9457         (get_prev_frame): Adjust.
9458         (boolean_option_def, uinteger_option_def)
9459         (set_backtrace_option_defs): New.
9460         (_initialize_frame): Adjust and use
9461         gdb::option::add_setshow_cmds_for_options to install "set
9462         backtrace past-main" and "set backtrace past-entry".
9463         * frame.h: Include "cli/cli-option.h".
9464         (struct frame_print_options): Forward declare.
9465         (print_frame_arguments_all, print_frame_arguments_scalars)
9466         (print_frame_arguments_none): Declare.
9467         (print_entry_values): Delete declaration.
9468         (struct frame_print_options, user_frame_print_options): New.
9469         (struct set_backtrace_options): New.
9470         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
9471         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
9472         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
9473         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
9474         (list_args_or_locals): Add frame_print_options parameter.
9475         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
9476         * python/py-framefilter.c (enumerate_args): Pass down
9477         USER_FRAME_PRINT_OPTIONS.
9478         * stack.c: Include "cli/cli-option.h".
9479         (print_frame_arguments_all, print_frame_arguments_scalars)
9480         (print_frame_arguments_none): Declare.
9481         (print_raw_frame_arguments, print_entry_values): Delete.
9482         (user_frame_print_options): New.
9483         (boolean_option_def, enum_option_def, frame_print_option_defs):
9484         New.
9485         (struct backtrace_cmd_options): New.
9486         (bt_flag_option_def): New.
9487         (backtrace_command_option_defs): New.
9488         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
9489         (print_frame_arg, read_frame_arg, print_frame_args)
9490         (print_frame_info, print_frame): Add frame_print_options parameter
9491         and use it.
9492         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
9493         (backtrace_command_1): Add frame_print_options and
9494         backtrace_cmd_options parameters and use them.
9495         (make_backtrace_options_def_group): New.
9496         (backtrace_command): Process command options with
9497         gdb::option::process_options.
9498         (backtrace_command_completer): New.
9499         (_initialize_stack): Extend "backtrace"'s help to mention
9500         supported options.  Install completer for "backtrace".
9501         Install some settings commands with add_setshow_cmds_for_options.
9502
9503 2019-06-13  Pedro Alves  <palves@redhat.com>
9504
9505         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
9506         and that "set/show print raw frame-arguments" are now deprecated.
9507
9508         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
9509         command.
9510         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
9511         * stack.c (_initialize_stack): Install "set/show print
9512         raw-frame-arguments", and deprecate "set/show print raw
9513         frame-arguments".
9514         * valprint.c (_initialize_valprint): Deprecate "set/show print
9515         raw".
9516
9517 2019-06-13  Pedro Alves  <palves@redhat.com>
9518
9519         * compile/compile.c (struct compile_options): New.
9520         (compile_flag_option_def, compile_command_option_defs)
9521         (make_compile_options_def_group): New.
9522         (compile_file_command): Handle options with
9523         gdb::option::process_options.
9524         (compile_file_command_completer): New function.
9525         (compile_code_command): Handle options with
9526         gdb::option::process_options.
9527         (compile_code_command_completer): New function.
9528         (_initialize_compiler): Install completers for "compile code" and
9529         "compile file".  Mention available options in "compile code" and
9530         "compile code"'s help.
9531         * completer.c (advance_to_completion_word): New, factored out from
9532         ...
9533         (advance_to_expression_complete_word_point): ... this.
9534         (advance_to_filename_complete_word_point): New.
9535         * completer.h (advance_to_filename_complete_word_point): New
9536         declaration.
9537
9538 2019-06-13  Pedro Alves  <palves@redhat.com>
9539
9540         * compile/compile.c: Include "cli/cli-option.h".
9541         (compile_print_value): Scope data pointer is now a
9542         value_print_options pointer; adjust.
9543         (compile_print_command): Process options.  Scope data pointer is
9544         now a value_print_options pointer; adjust.
9545         (_initialize_compile): Update "compile print"'s help to include
9546         supported options.  Install a completer for "compile print".
9547         * cp-valprint.c (show_vtblprint, show_objectprint)
9548         (show_static_field_print): Delete.
9549         (_initialize_cp_valprint): Don't install "set print
9550         static-members", "set print vtbl", "set print object" here.
9551         * printcmd.c: Include "cli/cli-option.h" and
9552         "common/gdb_optional.h".
9553         (print_command_parse_format): Rework to fill in a
9554         value_print_options instead of a format_data.
9555         (print_value): Change parameter type from format_data pointer to
9556         value_print_options reference.  Adjust.
9557         (print_command_1): Process options.  Adjust to pass down a
9558         value_print_options.
9559         (print_command_completer): New.
9560         (_initialize_printcmd): Install print_command_completer as
9561         handle_brkchars completer for the "print" command.  Update
9562         "print"'s help to include supported options.
9563         * valprint.c: Include "cli/cli-option.h".
9564         (show_vtblprint, show_objectprint, show_static_field_print): Moved
9565         here from cp-valprint.c.
9566         (boolean_option_def, uinteger_option_def)
9567         (value_print_option_defs, make_value_print_options_def_group):
9568         New.  Use gdb::option::add_setshow_cmds_for_options to install
9569         "set print elements", "set print null-stop", "set print repeats",
9570         "set print pretty", "set print union", "set print array", "set
9571         print address", "set print symbol", "set print array-indexes".
9572         * valprint.h: Include <string> and "cli/cli-option.h".
9573         (make_value_print_options_def_group): Declare.
9574         (print_value): Change parameter type from format_data pointer to
9575         value_print_options reference.
9576         (print_command_completer): Declare.
9577
9578 2019-06-13  Pedro Alves  <palves@redhat.com>
9579
9580         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
9581         (COMMON_SFILES): Add maint-test-settings.c.
9582         * cli/cli-decode.c (boolean_enums): New global, factored out from
9583         ...
9584         (add_setshow_boolean_cmd): ... here.
9585         * cli/cli-decode.h (boolean_enums): Declare.
9586         * cli/cli-option.c: New file.
9587         * cli/cli-option.h: New file.
9588         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
9589         factored out from ...
9590         (parse_cli_boolean_value(const char *)): ... this.
9591         (is_unlimited_literal): Change parameter type to pointer to
9592         pointer.  Adjust and advance ARG pointer.
9593         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
9594         (parse_cli_var_enum): New, factored out from ...
9595         (do_set_command): ... this.  Adjust.
9596         * cli/cli-setshow.h (parse_cli_boolean_value)
9597         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
9598         (parse_cli_var_enum): Declare.
9599         * cli/cli-utils.c: Include "cli/cli-option.h".
9600         (get_ulongest): New.
9601         * cli/cli-utils.h (get_ulongest): Declare.
9602         (check_for_argument): New overloads.
9603         * maint-test-options.c: New file.
9604
9605 2019-06-13  Pedro Alves  <palves@redhat.com>
9606
9607         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
9608         parse a range if "-" is at the end of the string.
9609
9610 2019-06-13  Pedro Alves  <palves@redhat.com>
9611
9612         * cli/cli-setshow.c (parse_auto_binary_operation)
9613         (parse_cli_boolean_value): Don't allow "o".
9614
9615 2019-06-13  Pedro Alves  <palves@redhat.com>
9616
9617         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
9618         * NEWS: Mention maint test-settings KIND.
9619         * maint-test-settings.c: New file.
9620
9621 2019-06-13  Pedro Alves  <palves@redhat.com>
9622
9623         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
9624         completer.
9625         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
9626         "set" completers.
9627
9628 2019-06-13  Pedro Alves  <palves@redhat.com>
9629
9630         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
9631         after item.
9632
9633 2019-06-13  Pedro Alves  <palves@redhat.com>
9634
9635         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
9636
9637 2019-06-13  Pedro Alves <palves@redhat.com>
9638
9639         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
9640         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
9641         call.
9642         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
9643         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
9644         calls.
9645         (check_for_argument): Skip spaces after argument.
9646
9647 2019-06-13  Pedro Alves  <palves@redhat.com>
9648
9649         * thread.c (thread_apply_command): Adjust TID parsing.
9650         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
9651         detected before end of string.
9652         (tid_is_in_list): Error out if LIST is invalid.
9653
9654 2019-06-13  Pedro Alves  <palves@redhat.com>
9655
9656         * completer.c (complete_line_internal_1): Rewind completion word
9657         point.
9658         (completion_tracker::advance_custom_word_point_by): Change
9659         parameter type to int.
9660         * completer.h (completion_tracker::advance_custom_word_point_by):
9661         Likewise.
9662
9663 2019-06-13  Pedro Alves  <palves@redhat.com>
9664
9665         * completer.c (advance_to_completion_word): Handle delimiters.
9666
9667 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
9668
9669         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
9670
9671 2019-06-11  Tom Tromey  <tom@tromey.com>
9672
9673         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
9674         (xmalloc_failed): Move to alloc.c.
9675         * alloc.c: New file.
9676         * Makefile.in (COMMON_SFILES): Add alloc.c.
9677
9678 2019-06-11  Tom Tromey  <tom@tromey.com>
9679
9680         * nat/linux-waitpid.c: Don't include server.h.
9681         (linux_debug): Remove.
9682         (my_waitpid): Update.
9683
9684 2019-06-11  Tom Tromey  <tromey@adacore.com>
9685
9686         * infcall.c (_initialize_infcall): Remove trailing newline from
9687         help.
9688         * user-regs.c (_initialize_user_regs): Remove trailing newline
9689         from help.
9690         * typeprint.c (_initialize_typeprint): Remove trailing newline
9691         from help.
9692         * reverse.c (_initialize_reverse): Remove trailing newlines from
9693         help.
9694         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
9695         from help.
9696         * language.c (add_set_language_command): Remove trailing newline
9697         from help.
9698         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
9699         help.
9700         * disasm.c (_initialize_disasm): Remove trailing newline from
9701         help.
9702         * top.c (init_main): Remove trailing newline from help.
9703         * interps.c (_initialize_interpreter): Remove trailing newline
9704         from help.
9705         * btrace.c (_initialize_btrace): Remove trailing newlines from
9706         help.
9707         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
9708         from help.
9709         * python/python.c (_initialize_python): Remove trailing newline
9710         from help.
9711         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
9712         help.
9713         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
9714         from help.  Reformat some text.
9715         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
9716         from help.
9717         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
9718         newline from help.
9719
9720 2019-06-11  Tom Tromey  <tromey@adacore.com>
9721
9722         * darwin-nat.c (darwin_decode_exception_message)
9723         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
9724
9725 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
9726
9727         * valops.c (value_slice): Check for not allocated or not
9728         associated values.
9729
9730 2019-06-10  Tom de Vries  <tdevries@suse.de>
9731
9732         PR gdb/24618
9733         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
9734         sure an empty slot (defined by a 32-bit zero pair) is recognized as
9735         invalid.
9736
9737 2019-06-10  Tom de Vries  <tdevries@suse.de>
9738
9739         PR gdb/24611
9740         * linespec.c (linespec_lexer_lex_string): Remove incorrect
9741         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
9742
9743 2019-06-10  Tom de Vries  <tdevries@suse.de>
9744
9745         PR symtab/24545
9746         * symtab.c (struct demangled_name_entry): Add language field.
9747         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
9748         static minimal symbol".  Set and use language field.
9749
9750 2019-06-10  Tom Tromey  <tromey@adacore.com>
9751
9752         * ada-lang.c (_initialize_ada_language): Update help text.
9753
9754 2019-06-10  Tom Tromey  <tromey@adacore.com>
9755
9756         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
9757         with a newline.
9758         * guile/guile.c (handle_boot_error): Don't end warning with a
9759         newline.
9760         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
9761         warning with a newline.
9762         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
9763         newline.
9764         (s12z_frame_cache): Likewise.
9765         * dwarf-index-cache.c (index_cache::store): Don't end warning with
9766         a newline.
9767         * solib-svr4.c (disable_probes_interface): Don't end warning with
9768         a newline.
9769         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
9770         newline.
9771         * python/python.c (do_finish_initialization): Don't end warning
9772         with a newline.
9773
9774 2019-06-10  Tom Tromey  <tom@tromey.com>
9775
9776         * python/py-breakpoint.c (gdbpy_breakpoint_created)
9777         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
9778         gdbpy_enter.
9779
9780 2019-06-10  Tom Tromey  <tromey@adacore.com>
9781
9782         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
9783         data.
9784         (elf_new_init): Don't call stabsread_new_init.
9785         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
9786         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
9787         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
9788
9789 2019-06-10  Tom de Vries  <tdevries@suse.de>
9790
9791         PR symtab/16264
9792         PR symtab/24517
9793         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
9794
9795 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
9796
9797         * source.c (find_and_open_source): Also rewrite relative file
9798         names.
9799
9800 2019-04-26  Amos Bird  <amosbird@gmail.com>
9801
9802         * annotate.c (annotate_thread_exited): Add "thread-exited"
9803         annotation.
9804
9805 2019-06-06  Tom Tromey  <tromey@adacore.com>
9806
9807         * maint.h (class scoped_command_stats): Use
9808         DISABLE_COPY_AND_ASSIGN.
9809         <print_time>: New method.
9810         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
9811         print_time.
9812         (scoped_command_stats::print_time): New method.
9813
9814 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
9815
9816         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
9817         instructions of lengths 6 or 8 bytes.
9818
9819 2019-06-04  Pedro Alves  <palves@redhat.com>
9820
9821         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
9822
9823         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
9824         * breakpoint.c (condition_completer): Likewise.
9825         * cli/cli-dump.c (scan_expression): Likewise.
9826         * common/filestuff.c (mkdir_recursive): Likewise.
9827         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
9828         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
9829         (gdb_abspath): Likewise.
9830         * compile/compile-cplus-types.c
9831         (compile_cplus_instance::decl_name): Likewise.
9832         * completer.c (complete_explicit_location):
9833         (signal_completer, reg_or_group_completer_1): Likewise.
9834         * cp-support.c (cp_remove_params_if_any): Likewise.
9835         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
9836         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
9837         * infcmd.c (strip_bg_char): Likewise.
9838         * linespec.c (copy_token_string): Likewise.
9839         * mi/mi-main.c (output_cores): Likewise.
9840         * psymtab.c (psymtab_search_name):
9841         * symfile.c (test_set_ext_lang_command): Likewise.
9842         * target.c (target_fileio_read_stralloc): Likewise.
9843         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
9844         * value.c (complete_internalvar): Likewise.
9845
9846 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
9847
9848         Add objfile property to gdb.Type.
9849         * NEWS: Mention Python API addition.
9850         * python/py-type.c (typy_get_objfile): New method.
9851
9852 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9853
9854         * NEWS: Mention the new set|show style [title|highlight].
9855         Mention changes to "show style", "help" and "apropos".
9856
9857 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9858
9859         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
9860         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
9861         instead of print_help_for_command.
9862         (print_doc_of_command): New function.
9863         (help_list): Add 'apropos -v word' suggestion.
9864         (print_help_for_command): Style the command name using title style.
9865         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
9866         (_initialize_cli_cmds): Describe -v in apropos_command help.
9867
9868 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9869
9870         * cli/cli-style.h (cli_style_option): Add name in constructor,
9871         add m_name class member, add constructor with intensity,
9872         add name class function.
9873         (cli_style_option::add_setshow_commands): Remove name argument.
9874         (highlight_style, title_style): New styles.
9875         * cli/cli-style.c (do_show): New function that shows a style
9876         characteristic styling the style name with itself.
9877         (set_style_name): New function.
9878         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
9879         Update all callers according to the changes in cli/cli-style.h.
9880         * utils.h (fputs_highlighted): New function.
9881         * utils.c (fputs_highlighted): Likewise.
9882
9883 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9884
9885         * NEWS: Mention new pipe command and new convenience variables.
9886
9887 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9888
9889         * cli/cli-cmds.c (pipe_command): New function.
9890         (_initialize_cli_cmds): Call add_com for pipe_command.
9891         Define | as an alias for pipe.
9892         (exit_status_set_internal_vars): New function.
9893         (shell_escape): Call exit_status_set_internal_vars.
9894         cli/cli-decode.c (find_command_name_length): Recognize | as
9895         a single character command.
9896
9897 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9898
9899         * gdbcmd.h (execute_command_to_ui_file): New declaration.
9900         top.c (execute_command_to_ui_file): New function, mostly a copy
9901         of execute_command_to_string.
9902         (execute_command_to_string): Implement by calling
9903         execute_command_to_ui_file.
9904
9905 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9906
9907         * top.h (saved_command_line): Remove declaration.
9908         * top.c (previous_saved_command_line, previous_repeat_arguments):
9909         New variables.
9910         (saved_command_line): Make static, define together with other
9911         'repeat variables'.
9912         (dont_repeat): Clear repeat_arguments.
9913         (repeat_previous, get_saved_command_line, save_command_line):
9914         New functions.
9915         (gdb_init): Initialize saved_command_line
9916         and previous_saved_command_line.
9917         * main.c (captured_main_1): Remove saved_command_line initialization.
9918         * event-top.c (handle_line_of_input): Update to use
9919         the new 'repeat' related functions instead of direct access to
9920         saved_command_line.
9921         * command.h (repeat_previous, get_saved_command_line,
9922         save_command_line): New declarations.
9923         (dont_repeat): Add comment.
9924
9925 2019-05-30  Tom Tromey  <tromey@adacore.com>
9926
9927         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
9928         Fix comment.
9929         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
9930
9931 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
9932
9933         PR cli/24587
9934         * completer.c (complete): Initialize variable word.
9935
9936 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
9937
9938         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
9939         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
9940         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
9941         'body' is NULL to the outter 'if', protecting the '!is_define'
9942         situation as well.
9943
9944 2019-05-29  Tom Tromey  <tromey@adacore.com>
9945
9946         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
9947         (dwarf_unknown): New function.
9948         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
9949         (dwarf_type_encoding_name): Use dwarf_unknown.
9950
9951 2019-05-29  Tom Tromey  <tromey@adacore.com>
9952
9953         PR c++/20020:
9954         * cp-valprint.c (cp_print_value_fields): Call
9955         cp_print_static_field inside "try".
9956
9957 2019-05-29  Tom Tromey  <tromey@adacore.com>
9958
9959         * inflow.c (struct terminal_info): Add default operator=.
9960         * configure: Rebuild.
9961         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
9962         -Wdeprecated-copy-dtor, -Wredundant-move.
9963
9964 2019-05-29  Tom Tromey  <tromey@adacore.com>
9965
9966         * NEWS: Add entry.
9967         * infcmd.c (print_return_value_1): Handle finish_print
9968         option.
9969         (show_print_finish): New function.
9970         (_initialize_infcmd): Add "set/show print finish" commands.
9971         * valprint.c (user_print_options): Initialize new member.
9972         * valprint.h (struct value_print_options) <finish_print>: New
9973         member.
9974
9975 2019-05-28  Tom Tromey  <tromey@adacore.com>
9976
9977         * ada-lang.c (ada_remove_Xbn_suffix)
9978         (find_old_style_renaming_symbol)
9979         (parse_old_style_renaming): Remove.
9980         (ada_find_renaming_symbol): Don't call
9981         find_old_style_renaming_symbol.
9982         (ada_is_renaming_symbol): Rename from
9983         ada_find_renaming_symbol.  Remove "block" parameter.  Return
9984         bool.  Now static.
9985         (ada_read_var_value): Update and simplify.
9986         * ada-exp.y (write_var_or_type): Remove old code.
9987
9988 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
9989
9990         PR gdb/25010
9991         * event-top.c: Remove include comment.
9992         * inflow.c (class scoped_ignore_sigttou): Move from here...
9993         * inflow.h (class scoped_ignore_sigttou): ...to here.
9994         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
9995         * top.c:  Remove include comment.
9996
9997 2019-05-27  Tom Tromey  <tom@tromey.com>
9998
9999         * NEWS: Fix typo.
10000
10001 2019-05-22  Tom Tromey  <tromey@adacore.com>
10002
10003         * target.c (target_follow_exec): Constify parameter.
10004         * target-delegates.c: Rebuild.
10005         * remote.c (remote_target::follow_exec): Constify parameter.
10006         * infrun.c (follow_exec): Constify parameter.
10007         * target.h (struct target_ops) <follow_exec>: Constify parameter.
10008         (target_follow_exec): Likewise.
10009
10010 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
10011
10012         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
10013         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
10014
10015 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
10016
10017         * NEWS: Add debugredirect and testsuite sections.
10018
10019 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
10020
10021         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
10022         target descriptions using exclusively floating point register name
10023         aliases.
10024
10025 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
10026
10027         PR gdb/18644:
10028         * f-lang.c (build_fortran_types): Handle the case where
10029         gdbarch_floatformat_for_type returns a nullptr.
10030
10031 2019-05-21  Tom de Vries  <tdevries@suse.de>
10032
10033         PR cli/24587
10034         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
10035
10036 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
10037
10038         PR gdb/18644:
10039         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
10040         16-byte floats.
10041         * i386-tdep.c (i386_floatformat_for_type): Use
10042         floatformats_ia64_quad for the 16-byte floating point component
10043         within a fortran 32-byte complex number.
10044
10045 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
10046
10047         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
10048         delete default constructor.
10049         (find_partial_die): Update to return const struct.
10050         (partial_die_parent_scope): Move variable declaration into scope
10051         of its use and change its type to auto.
10052         (guess_partial_die_structure_name): Likewise.
10053         (partial_die_info::fixup): Likewise.
10054
10055 2019-05-17  Tom Tromey  <tromey@adacore.com>
10056
10057         * source.c (find_and_open_source): Remove cast.
10058
10059 2019-05-17  Tom Tromey  <tromey@adacore.com>
10060
10061         * annotate.c (annotate_source): Make "filename" const.
10062         * annotate.h (annotate_source): Use const.
10063
10064 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
10065
10066         * disasm.c (set_disassembler_options): Send errors to stderr.
10067
10068 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
10069
10070         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
10071         (cli_interp_base::set_logging): Check debug_redirect.
10072         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
10073         * cli/cli-logging.c (debug_redirect): Add static variable.
10074         (pop_output_files): Add default param.
10075         (handle_redirections): Print debug setting.
10076         (show_logging_command): Likewise.
10077         (_initialize_cli_logging): Add debugredirect command.
10078         * interps.c (current_interp_set_logging): Add debug_redirect
10079         parameter.
10080         * interps.h (set_logging): Add debug_redirect parameter.
10081         (current_interp_set_logging): Likewise.
10082         * mi/mi-common.h: Likewise.
10083         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
10084
10085 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
10086             Tom Tromey  <tromey@adacore.com>
10087
10088         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
10089         directly.
10090         * cli/cli-interp.h (make_logging_output): Remove declaration.
10091         * cli/cli-logging.c (make_logging_output): Remove function.
10092         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
10093         directly.
10094         * ui-file.c (tee_file::tee_file): Remove bools.
10095         (tee_file::~tee_file): Remove deletes.
10096         * ui-file.h (tee_file): Remove bools.
10097
10098 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
10099
10100         * mi/mi-cmds.h (mi_cmd_complete): New function.
10101         * mi/mi-main.c (mi_cmd_complete): Likewise.
10102         * mi/mi-cmds.c: Define new MI command -complete.
10103         * NEWS: Mention new -complete command.
10104
10105 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
10106
10107         * completer.h (complete): New function.
10108         * completer.c (complete): Likewise.
10109         * cli/cli-cmds.c: (complete_command): Update to use new complete()
10110         function defined in completer.h.
10111
10112 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
10113
10114         * MAINTAINERS (Write After Approval): Add myself.
10115
10116 2019-05-17  Tom de Vries  <tdevries@suse.de>
10117
10118         PR gdb/24094
10119         * dwarf2read.c (struct cu_partial_die_info): New struct.
10120         (find_partial_die): Return cu_partial_die_info.
10121         (partial_die_parent_scope, guess_partial_die_structure_name)
10122         (partial_die_info::fixup): Handle new return type of find_partial_die.
10123
10124 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
10125
10126         PR breakpoints/24541
10127         * stap-probe.c (stap_parse_register_operand): Make "regname" an
10128         "std::string", simplifying the algorithm.
10129
10130 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
10131
10132         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
10133         (stap_static_probe_ops::get_probes): Likewise.
10134
10135 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
10136
10137         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
10138         '-')" and "else if".
10139         (stap_parse_single_operand): Join checks for
10140         "gdbarch_stap_parse_special_token_p" and
10141         "gdbarch_stap_parse_special_token" in the same "if" statement.
10142         Invert check when verifying for operation on register
10143         displacement.
10144
10145 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
10146
10147         * stap-probe.c (stap_get_opcode): Update comment.
10148         (stap_get_expected_argument_type): Likewise.
10149         (handle_stap_probe): Likewise.
10150
10151 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
10152
10153         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
10154         return type to 'bool'.  Adjust comment.  Use 'bool' when
10155         appropriate.
10156         (i386_stap_parse_special_token_three_arg_disp): Likewise.
10157         * stap-probe.c (stap_parse_argument_1): Likewise.
10158         (stap_is_operator): Likewise.
10159         (stap_is_generic_prefix): Likewise.
10160         (stap_is_register_prefix): Likewise.
10161         (stap_is_register_indirection_prefix): Likewise.
10162         (stap_is_integer_prefix): Likewise.
10163         (stap_generic_check_suffix): Likewise.
10164         (stap_check_integer_suffix): Likewise.
10165         (stap_check_register_suffix): Likewise.
10166         (stap_check_register_indirection_suffix): Likewise.
10167         (stap_parse_register_operand): Likewise.
10168         (stap_parse_single_operand): Likewise.
10169         (stap_parse_argument_1): Likewise.
10170         (stap_probe::get_argument_count): Likewise.
10171         (stap_is_operator): Likewise.
10172
10173 2019-05-16  Tom Tromey  <tromey@adacore.com>
10174
10175         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
10176         keyword to foreach.
10177
10178 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
10179
10180         * linux-thread-db.c (try_thread_db_load_1): Change return type
10181         to bool.
10182         (try_thread_db_load): Likewise.
10183         (try_thread_db_load_from_pdir_1): Likewise.
10184         (try_thread_db_load_from_pdir): Likewise.
10185         (try_thread_db_load_from_sdir): Likewise.
10186         (try_thread_db_load_from_dir): Likewise.
10187         (thread_db_load_search): Likewise.
10188         (has_libpthread): Likewise.
10189         (thread_db_load): Likewise.
10190
10191 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
10192
10193         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
10194         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
10195         NULL, and complain/return if that's the case.
10196
10197 2019-05-15  John Darrington <john@darrington.wattle.id.au>
10198
10199         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
10200         (advance, posn, abstract_read_memory): New functions.
10201         [struct mem_read_abstraction]: New struct.
10202         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
10203
10204 2019-05-14  Tom Tromey  <tromey@adacore.com>
10205
10206         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
10207         value is not lval_memory.
10208
10209 2019-05-14  Tom Tromey  <tromey@adacore.com>
10210
10211         * solib.c (info_sharedlibrary_command): Style the file name.
10212
10213 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
10214
10215         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
10216         (aarch64_vnv_type): Likewise.
10217         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
10218         * common/tdesc.c: Likewise.
10219         * common/tdesc.h (enum tdesc_type_kind): Likewise.
10220         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
10221         * features/aarch64-fpu.xml: Add ieee half view.
10222         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
10223         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
10224         * gdbtypes.h (struct builtin_type): Likewise.
10225         (struct objfile_type): Likewise.
10226
10227 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
10228
10229         * language.c (language_sniff_from_mangled_name): Fix "langauge"
10230         typo.
10231         * location.h (string_to_event_location): Likewise.
10232
10233 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
10234
10235         GDB 8.3 released.
10236
10237 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
10238
10239         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
10240         New variable declaration.
10241         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
10242         New variable.
10243         (print_one_breakpoint): Use ui_out::test_flags and new global
10244         variable to compute use_fixed_output.
10245         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
10246         Remove.
10247         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
10248         (mi_multi_location_breakpoint_output_fixed): Remove.
10249         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
10250         new variable.
10251         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
10252         fix_multi_location_breakpoint_output flag if version >= 3.
10253         * ui-out.h (enum ui_out_flag)
10254         <fix_multi_location_breakpoint_output>: New enumerator.
10255
10256 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
10257
10258         * contrib/cc-with-tweaks.sh: Validate dwz's work.
10259
10260 2019-05-10  Tom Tromey  <tromey@adacore.com>
10261
10262         * ada-lang.c (catch_ada_completer): New function.
10263         (_initialize_ada_language): Use it.
10264
10265 2019-05-10  Tom Tromey  <tromey@adacore.com>
10266
10267         * thread.c (print_thread_info): Make "requested_threads" const.
10268         * gdbthread.h (print_thread_info): Make "requested_threads"
10269         const.
10270         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
10271         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
10272
10273 2019-05-08  Tom Tromey  <tom@tromey.com>
10274
10275         * gdbtypes.c (objfile_type_data): Change type.
10276         (objfile_type, _initialize_gdbtypes): Update.
10277
10278 2019-05-08  Tom Tromey  <tom@tromey.com>
10279
10280         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
10281         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
10282         (_initialize_dwarf2_frame): Update.
10283
10284 2019-05-08  Tom Tromey  <tom@tromey.com>
10285
10286         * objc-lang.c (objc_objfile_data): Change type.
10287         (find_methods): Update.
10288         (_initialize_objc_lang): Remove.
10289
10290 2019-05-08  Tom Tromey  <tom@tromey.com>
10291
10292         * stabsread.c (rs6000_builtin_type_data): Change type.
10293         (rs6000_builtin_type, _initialize_stabsread): Update.
10294
10295 2019-05-08  Tom Tromey  <tom@tromey.com>
10296
10297         * mips-tdep.c (mips_pdr_data): Remove.
10298         (_initialize_mips_tdep): Update.
10299
10300 2019-05-08  Tom Tromey  <tom@tromey.com>
10301
10302         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
10303         (hppa_init_objfile_priv_data, read_unwind_info)
10304         (find_unwind_entry, _initialize_hppa_tdep): Update.
10305
10306 2019-05-08  Tom Tromey  <tom@tromey.com>
10307
10308         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
10309         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
10310         on obstack.
10311         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
10312
10313 2019-05-08  Tom Tromey  <tom@tromey.com>
10314
10315         * mdebugread.c (basic_type_data): Change type.
10316         (basic_type, _initialize_mdebugread): Update.
10317
10318 2019-05-08  Tom Tromey  <tom@tromey.com>
10319
10320         * common/gdb_unique_ptr.h (struct noop_deleter): New.
10321
10322 2019-05-08  Tom Tromey  <tom@tromey.com>
10323
10324         * nto-tdep.c (nto_inferior_data_reg): Change type.
10325         (nto_inferior_data): Update.
10326         (nto_inferior_data_cleanup, nto_new_inferior_data)
10327         (_initialize_nto_tdep): Remove.
10328         * nto-tdep.h (struct nto_inferior_data): Add initializers.
10329
10330 2019-05-08  Tom Tromey  <tom@tromey.com>
10331
10332         * ada-lang.c (struct ada_inferior_data): Add initializers.
10333         (ada_inferior_data): Change type.
10334         (ada_inferior_data_cleanup): Remove.
10335         (get_ada_inferior_data, ada_inferior_exit)
10336         (struct ada_pspace_data): Add initializers, destructor.
10337         (ada_pspace_data_handle): Change type.
10338         (get_ada_pspace_data): Update.
10339         (ada_pspace_data_cleanup): Remove.
10340
10341 2019-05-08  Tom Tromey  <tom@tromey.com>
10342
10343         * coffread.c (struct coff_symfile_info): Add initializers.
10344         (coff_objfile_data_key): Move lower.  Change type.
10345         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
10346         Update.
10347         (coff_free_info): Remove.
10348
10349 2019-05-08  Tom Tromey  <tom@tromey.com>
10350
10351         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
10352         (fbsd_pspace_data_handle): Move lower.  Change type.
10353         (get_fbsd_pspace_data): Update.
10354         (fbsd_pspace_data_cleanup): Remove.
10355         (_initialize_fbsd_tdep): Update.
10356
10357 2019-05-08  Tom Tromey  <tom@tromey.com>
10358
10359         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
10360         (get_ada_tasks_pspace_data): Update.
10361         (ada_tasks_pspace_data_cleanup): Remove.
10362         (_initialize_tasks): Update.
10363         (ada_tasks_inferior_data_handle): Change type.
10364         (get_ada_tasks_inferior_data): Update.
10365         (ada_tasks_inferior_data_cleanup): Remove.
10366         (struct ada_tasks_pspace_data): Add initializers.
10367
10368 2019-05-08  Tom Tromey  <tom@tromey.com>
10369
10370         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
10371         * symfile-debug.c (debug_sym_get_probes): Change type.
10372         * stap-probe.c (handle_stap_probe):
10373         (stap_static_probe_ops::get_probes): Change type.
10374         * probe.h (class static_probe_ops) <get_probes>: Change type.
10375         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
10376         (parse_probes_in_pspace): Update.
10377         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
10378         Update.
10379         (any_static_probe_ops::get_probes): Change type.
10380         * elfread.c (elfread_data): New typedef.
10381         (probe_key): Change type.
10382         (elf_get_probes): Likewise.  Update.
10383         (probe_key_free): Remove.
10384         (_initialize_elfread): Update.
10385         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
10386         Change type.
10387         (dtrace_process_dof_probe, dtrace_process_dof)
10388         (dtrace_static_probe_ops::get_probe): Change type.
10389
10390 2019-05-08  Tom Tromey  <tom@tromey.com>
10391
10392         * xcoffread.c (struct xcoff_symfile_info): Rename from
10393         coff_symfile_info.  Add initializers.
10394         (xcoff_objfile_data_key): Move lower.  Change type.
10395         (XCOFF_DATA): Rewrite.
10396         (xcoff_free_info): Remove.
10397         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
10398         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
10399         (xcoff_initial_scan): Update.
10400
10401 2019-05-08  Tom Tromey  <tom@tromey.com>
10402
10403         * solib-svr4.c (struct svr4_info): Add initializers and
10404         destructor.
10405         <probes_table>: Now an htab_up.
10406         (solib_svr4_pspace_data): Change type.
10407         (free_probes_table): Simplify.
10408         (~svr4_info): Rename from svr4_pspace_data_cleanup.
10409         (get_svr4_info, probes_table_htab_remove_objfile_probes)
10410         (probes_table_remove_objfile_probes, register_solib_event_probe)
10411         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
10412         (_initialize_svr4_solib): Update.
10413
10414 2019-05-08  Tom Tromey  <tom@tromey.com>
10415
10416         * remote.c (remote_pspace_data): Change type.
10417         (remote_pspace_data_cleanup): Remove.
10418         (get_remote_exec_file, set_pspace_remote_exec_file)
10419         (_initialize_remote): Update.
10420
10421 2019-05-08  Tom Tromey  <tom@tromey.com>
10422
10423         * breakpoint.c (breakpoint_objfile_key): Change type.
10424         (get_breakpoint_objfile_data): Update.
10425         (free_breakpoint_objfile_data): Remove.
10426         (_initialize_breakpoint): Update.
10427
10428 2019-05-08  Tom Tromey  <tom@tromey.com>
10429
10430         * linux-tdep.c (struct linux_info): Add initializers.
10431         (linux_inferior_data): Move.  Change type.
10432         (invalidate_linux_cache_inf): Update.
10433         (linux_inferior_data_cleanup): Remove.
10434         (get_linux_inferior_data, _initialize_linux_tdep): Update.
10435
10436 2019-05-08  Tom Tromey  <tom@tromey.com>
10437
10438         * auxv.c (auxv_inferior_data): Move.  Change type.
10439         (auxv_inferior_data_cleanup): Remove.
10440         (invalidate_auxv_cache_inf): Rewrite.
10441         (get_auxv_inferior_data, _initialize_auxv): Update.
10442
10443 2019-05-08  Tom Tromey  <tom@tromey.com>
10444
10445         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
10446         (symfile_debug_objfile_data_key): Change type.
10447         (symfile_debug_installed, debug_qf_has_symbols)
10448         (debug_qf_find_last_source_symtab)
10449         (debug_qf_forget_cached_source_info)
10450         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
10451         (debug_qf_print_stats, debug_qf_dump)
10452         (debug_qf_expand_symtabs_for_function)
10453         (debug_qf_expand_all_symtabs)
10454         (debug_qf_expand_symtabs_with_fullname)
10455         (debug_qf_map_matching_symbols)
10456         (debug_qf_expand_symtabs_matching)
10457         (debug_qf_find_pc_sect_compunit_symtab)
10458         (debug_qf_map_symbol_filenames)
10459         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
10460         (debug_sym_new_init, debug_sym_init, debug_sym_read)
10461         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
10462         (debug_sym_read_linetable, debug_sym_relocate): Update.
10463         (symfile_debug_free_objfile): Remove.
10464         (install_symfile_debug_logging, _initialize_symfile_debug):
10465         Update.
10466
10467 2019-05-08  Tom Tromey  <tom@tromey.com>
10468
10469         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
10470         allocate_on_obstack.
10471         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
10472         (get_dwarf2_per_objfile): Update.
10473         (set_dwarf2_per_objfile): Remove.
10474         (dwarf2_has_info, dwarf2_get_section_info): Update.
10475         (dwarf2_free_objfile): Remove.
10476         (_initialize_dwarf2_read): Update.
10477
10478 2019-05-08  Tom Tromey  <tom@tromey.com>
10479
10480         * auto-load.c (struct auto_load_pspace_info): Add destructor and
10481         initializers.
10482         <unsupported_script_warning_printed,
10483         script_not_found_warning_printed>: Now bool.
10484         (auto_load_pspace_data): Change type.
10485         (~auto_load_pspace_info): Rename from
10486         auto_load_pspace_data_cleanup.
10487         (get_auto_load_pspace_data, init_loaded_scripts_info)
10488         (clear_section_scripts, maybe_print_unsupported_script_warning)
10489         (maybe_print_script_not_found_warning, _initialize_auto_load):
10490         Update.
10491
10492 2019-05-08  Tom Tromey  <tom@tromey.com>
10493
10494         * objfiles.c (objfile_pspace_info): Add destructor and
10495         initializers.
10496         (objfiles_pspace_data): Change type.
10497         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
10498         (get_objfile_pspace_data): Update.
10499         (objfiles_bfd_data): Change type.
10500         (get_objfile_bfd_data): Update.
10501         (objfile_bfd_data_free, _initialize_objfiles): Remove.
10502
10503 2019-05-08  Tom Tromey  <tom@tromey.com>
10504
10505         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
10506         Change type.
10507         (get_catch_syscall_inferior_data): Update.
10508         (catch_syscall_inferior_data_cleanup): Remove.
10509         (_initialize_break_catch_syscall): Update.
10510
10511 2019-05-08  Tom Tromey  <tom@tromey.com>
10512
10513         * inflow.c (struct terminal_info): Add destructor and
10514         initializers.
10515         (inflow_inferior_data): Change type.
10516         (~terminal_info): Rename from inflow_inferior_data_cleanup.
10517         (get_inflow_inferior_data, inflow_inferior_exit)
10518         (swap_terminal_info, _initialize_inflow): Update.
10519
10520 2019-05-08  Tom Tromey  <tom@tromey.com>
10521
10522         * target-dcache.c (target_dcache_cleanup): Remove.
10523         (target_dcache_aspace_key): Change type.
10524         (target_dcache_init_p, target_dcache_invalidate)
10525         (target_dcache_get, target_dcache_get_or_init)
10526         (_initialize_target_dcache): Update.
10527         * dcache.h (struct dcache_deleter): New.
10528
10529 2019-05-08  Tom Tromey  <tom@tromey.com>
10530
10531         * symtab.c (struct symbol_cache): Add destructor and
10532         initializers.
10533         (symbol_cache_key): Move.  Change type.
10534         (make_symbol_cache, free_symbol_cache): Remove.
10535         (get_symbol_cache): Update.
10536         (symbol_cache_cleanup): Remove.
10537         (ALL_PSPACES, symbol_cache_flush)
10538         (maintenance_print_symbol_cache)
10539         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
10540         Update.
10541
10542 2019-05-08  Tom Tromey  <tom@tromey.com>
10543
10544         * symtab.c (struct main_info): Add destructor and initializers.
10545         (main_progspace_key): Move.  Change type.
10546         (get_main_info): Update.
10547         (main_info_cleanup): Remove.
10548         (_initialize_symtab): Update.
10549
10550 2019-05-08  Tom Tromey  <tom@tromey.com>
10551
10552         * registry.h (DECLARE_REGISTRY): Define the _key class.
10553
10554 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10555
10556         * NEWS: Merge two 'New commands' sections.
10557
10558 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
10559
10560         * ada-valprint.c (ada_val_print_gnat_array): Remove language
10561         parameter and use Ada language definition instead.
10562         (ada_val_print_ptr): Remove unused language parameter.
10563         (ada_val_print_num): Remove language parameter and use Ada language
10564         definition instead.
10565         (ada_val_print_enum, ada_val_print_flt): Remove unused language
10566         parameter.
10567         (ada_val_print_struct_union, ada_val_print_ref): Remove language
10568         parameter and use Ada language definition instead.
10569         (ada_val_print_1): Update all ada_val_print_xxx calls.
10570         Remove language parameter.
10571         (ada_val_print): Update ada_val_print_1 call.
10572
10573 2019-05-08  Tom Tromey  <tromey@adacore.com>
10574
10575         * remote.c (remote_hw_watchpoint_limit)
10576         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
10577         Now static.
10578
10579 2019-05-08  Tom Tromey  <tromey@adacore.com>
10580
10581         * maint.c (_initialize_maint_cmds): Move initialization code to
10582         remote.c.
10583         (watchdog, show_watchdog): Move to remote.c.
10584         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
10585         "watchdog" static.
10586         (_initialize_remote): Move initialization code from maint.c.
10587         * defs.h (watchdog): Don't declare.
10588
10589 2019-05-08  Tom Tromey  <tromey@adacore.com>
10590
10591         * tui/tui-interp.c: Include main.h.
10592         * interps.c: Include main.h.
10593         * main.h (interpreter_p): Declare.
10594         * defs.h (interpreter_p): Don't declare.
10595
10596 2019-05-08  Tom Tromey  <tromey@adacore.com>
10597
10598         * dwarf2loc.c: Include dwarf2read.h.
10599         * defs.h (read_unsigned_leb128): Don't declare.
10600         * dwarf2read.h (read_unsigned_leb128): Declare.
10601
10602 2019-05-08  Tom Tromey  <tromey@adacore.com>
10603
10604         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
10605         method.
10606
10607 2019-05-08  Tom Tromey  <tromey@adacore.com>
10608
10609         * utils.c (fputs_maybe_filtered): Reset style after paging, even
10610         when no wrap column is set.
10611
10612 2019-05-08  Tom Tromey  <tromey@adacore.com>
10613
10614         * c-lang.c (c_get_string): Handle non-C-style arrays.
10615
10616 2019-05-08  Tom Tromey  <tromey@adacore.com>
10617
10618         * typeprint.c (print_offset_data::update): Print the bit offset,
10619         not the number of bits remaining.
10620
10621 2019-05-08  Tom Tromey  <tromey@adacore.com>
10622
10623         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
10624         padding at end of comment.
10625
10626 2019-05-08  Tom Tromey  <tromey@adacore.com>
10627
10628         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
10629         Compare main types.
10630
10631 2019-05-06  Tom Tromey  <tom@tromey.com>
10632
10633         * common/scoped_mmap.c: Include common-defs.h.
10634         * common/scoped_mmap.h: Don't include config.h.
10635
10636 2019-05-04  Tom Tromey  <tom@tromey.com>
10637
10638         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
10639         (struct aarch64_call_info): Add initializers.
10640         <si>: Now a std::vector.
10641         (pass_on_stack, aarch64_push_dummy_call): Update.
10642
10643 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
10644             Tom Tromey  <tom@tromey.com>
10645
10646         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
10647         (ppc_threads): Now a std::vector.  Now static.
10648         (hwdebug_find_thread_points_by_tid)
10649         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
10650         Update.
10651
10652 2019-05-04  Tom Tromey  <tom@tromey.com>
10653
10654         * arc-tdep.c (arc_tdesc_init): Return bool.
10655
10656 2019-05-04  Tom Tromey  <tom@tromey.com>
10657
10658         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
10659         Use gdb_assert_not_reached.
10660
10661 2019-05-04  Tom Tromey  <tom@tromey.com>
10662
10663         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
10664         "false".
10665
10666 2019-05-04  Tom Tromey  <tom@tromey.com>
10667
10668         * arc-tdep.c (arc_tdesc_init): Use bool.
10669
10670 2019-05-04  Tom Tromey  <tom@tromey.com>
10671
10672         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
10673
10674 2019-05-04  Tom Tromey  <tom@tromey.com>
10675
10676         * cli/cli-cmds.c (valid_command_p): Return bool.
10677
10678 2019-05-04  Tom Tromey  <tom@tromey.com>
10679
10680         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
10681         * command.h (valid_user_defined_cmd_name_p): Channge return type.
10682
10683 2019-05-04  Raul Tambre  <raul@tambre.ee>
10684
10685         * python/lib/gdb/prompt.py (_ExtendedPrompt)
10686         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
10687         operator for comparison.
10688
10689 2019-05-04  Tom Tromey  <tom@tromey.com>
10690
10691         * psymtab.c (psymbol_name_matches, match_partial_symbol)
10692         (lookup_partial_symbol, print_partial_symbols)
10693         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
10694         (psymbol_compare): Update.
10695         (add_psymbol_to_bcache): Clear the entire psymbol.
10696         (maintenance_check_psymtabs): Update.
10697         * psympriv.h (struct partial_symbol): Don't derive from
10698         general_symbol_info.
10699         <obj_section, unrelocated_address, address,
10700         set_unrelocated_address>: Update.
10701         <ginfo>: New member.
10702         * dwarf-index-write.c (write_psymbols, debug_names::insert)
10703         (debug_names::write_psymbols): Update.
10704
10705 2019-05-04  Tom de Vries  <tdevries@suse.de>
10706
10707         * contrib/cc-with-tweaks.sh: Support -n arg.
10708
10709 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10710
10711         * corelow.c (core_target::detach): Ensure frame cache and
10712         register caches are cleared.
10713         inferior.c (exit_inferior_1): Likewise.
10714
10715 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
10716             Tom Tromey  <tom@tromey.com>
10717
10718         * dictionary.c (collate_pending_symbols_by_language): Remove
10719         "struct" from foreach.
10720         * symtab.c (lookup_global_symbol_from_objfile)
10721         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
10722         foreach.
10723         * ser-tcp.c (net_open): Remove "struct" from foreach.
10724         * objfiles.c (objfile_relocate, objfile_rebase)
10725         (objfile_has_symbols): Remove "struct" from foreach.
10726         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
10727         from foreach.
10728         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
10729         foreach.
10730         * darwin-nat.c (thread_info_from_private_thread_info): Remove
10731         "struct" from foreach.
10732         * ada-lang.c (create_excep_cond_exprs)
10733         (ada_exception_catchpoint_cond_string): Remove "struct" from
10734         foreach.
10735
10736 2019-05-03  Tom Tromey  <tromey@adacore.com>
10737
10738         * ada-exp.y (convert_char_literal): Check suffix of each
10739         enumerator.
10740
10741 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
10742
10743         PR ada/21406:
10744         * ada-exp.y (yywrap): Don't define.
10745         * ada-lex.l (%option): Add noyywrap
10746         (yywrap): Remove.
10747
10748 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
10749
10750         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
10751         _WIN32_WINNT to the XP level, unless already defined to a higher
10752         level.
10753
10754         * unittests/parse-connection-spec-selftests.c:
10755         * ser-tcp.c:
10756         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
10757         override.
10758
10759         * symfile.c (find_separate_debug_file): Remove colon from the
10760         drive spec of DOS/Windows file names of the target, so that the
10761         file name produced from DEBUGDIR and the target's directory will
10762         be valid on DOS/Windows systems.
10763
10764 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
10765
10766         * rust-lang.c (val_print_struct): Handle printing structures
10767         containing strings.
10768
10769 2019-05-02  Tom Tromey  <tromey@adacore.com>
10770
10771         * valarith.c (_initialize_valarith): Remove.
10772
10773 2019-05-01  Tom Tromey  <tromey@adacore.com>
10774
10775         * ada-lang.c (ada_value_primitive_field): Treat more fields as
10776         bitfields.
10777
10778 2019-05-01  Tom Tromey  <tromey@adacore.com>
10779
10780         * ada-lang.c (ada_value_assign): Correctly compute starting offset
10781         for big-endian copies.
10782
10783 2019-04-30  Ali Tamur  <tamur@google.com>
10784         * gdb/dwarf2read.c (read_3_bytes): New declaration.
10785         (read_attribute_value): Added DW_FORM_strx1-4 cases.
10786         (read_3_bytes): New function.
10787
10788 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
10789
10790         * windows-nat.c (main_thread_id): Delete.
10791         (handle_output_debug_string): Replace main_thread_id by
10792         current_event.dwThreadId.
10793         (fake_create_process): Likewise.
10794         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
10795         Do not set main_thread_id.
10796         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
10797         current_event.dwThreadId.
10798         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
10799
10800 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
10801
10802         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
10803         Use current_event.dwThreadId instead of main_thread_id.
10804
10805 2019-04-30  Tom Tromey  <tromey@adacore.com>
10806
10807         * ada-lang.c (ada_lookup_simple_minsyms): New function.
10808         (create_excep_cond_exprs): Iterate over program spaces.
10809         (ada_exception_catchpoint_cond_string): Examine all minimal
10810         symbols for exception types.
10811
10812 2019-04-30  Tom Tromey  <tromey@adacore.com>
10813
10814         PR c++/24470:
10815         * dwarf2read.c (process_structure_scope): Handle case where type
10816         has template parameters but no symbol was created.
10817
10818 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
10819             Chris January  <chris.january@arm.com>
10820
10821         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
10822         qualifier.
10823         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
10824
10825 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
10826
10827         * f-typeprint.c (f_print_type): Update rules for printing
10828         whitespace.
10829         (f_type_print_varspec_suffix): Likewise.
10830
10831 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
10832             Chris January  <chris.january@arm.com>
10833
10834         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
10835         function arguments.
10836
10837 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
10838
10839         * f-lang.c (build_fortran_types): Change name of void type to
10840         lower case.
10841         * f-typeprint.c (f_type_print_base): Print the name of the void
10842         type, rather than a fixed string.
10843         * f-valprint.c (f_decorations): Use lower case void string.
10844
10845 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
10846             Chris January  <chris.january@arm.com>
10847
10848         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
10849         types for Fortran.
10850
10851 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
10852             Chris January  <chris.january@arm.com>
10853             David Lecomber  <david.lecomber@arm.com>
10854
10855         * f-exp.y (BINOP_INTRINSIC): New token.
10856         (exp): New parser rule handling BINOP_INTRINSIC.
10857         (f77_keywords): Add new builtin procedures.
10858         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
10859         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
10860         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
10861         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
10862         (print_unop_subexp_f): New function.
10863         (print_binop_subexp_f): New function.
10864         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
10865         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
10866         (dump_subexp_body_f): Likewise.
10867         (operator_check_f): Likewise.
10868         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
10869         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
10870
10871 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
10872
10873         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
10874         UNOP_KIND.
10875         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
10876         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
10877         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
10878         (operator_length_f): New fuction.
10879         (print_subexp_f): New function.
10880         (op_name_f): New function.
10881         (dump_subexp_body_f): New function.
10882         (operator_check_f): New function.
10883         (exp_descriptor_f): Replace standard expression handling functions
10884         with new functions.
10885         * gdb/fortran-operator.def: New file.
10886         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
10887         * gdb/std-operator.def: Remove UNOP_KIND.
10888
10889 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
10890
10891         * std-operator.def: Remove unbalanced, stray double quote
10892         character.
10893
10894 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
10895             Chris January  <chris.january@arm.com>
10896             Daniel Everett  <daniel.everett@arm.com>
10897             Nick Forrington  <nick.forrington@arm.com>
10898             Richard Bunt  <richard.bunt@arm.com>
10899
10900         * cp-valprint.c (cp_print_value_fields): Allow an additional level
10901         of depth when printing anonymous structs or unions.
10902         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
10903         Don't print either the top-level value, or the children if the
10904         max-depth is exceeded.
10905         (ppscm_print_children): When printing the key of a map, allow one
10906         extra level of depth.
10907         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
10908         print either the top-level value, or the children if the max-depth
10909         is exceeded.
10910         (print_children): When printing the key of a map, allow one extra
10911         level of depth.
10912         * python/py-value.c (valpy_format_string): Add max_depth keyword.
10913         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
10914         (user_print_options): Initialise max_depth field.
10915         (val_print_scalar_or_string_type_p): New function.
10916         (val_print): Check to see if the max depth has been reached.
10917         (val_print_check_max_depth): Define new function.
10918         (show_print_max_depth): New function.
10919         (_initialize_valprint): Add 'print max-depth' option.
10920         * valprint.h (struct value_print_options) <max_depth>: New field.
10921         (val_print_check_max_depth): Declare new function.
10922         * NEWS: Document new feature.
10923
10924 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
10925
10926         * ada-lang.c (ada_language_defn): Initialise new field.
10927         * c-lang.c (c_is_string_type_p): New function.
10928         (c_language_defn): Initialise new field.
10929         (cplus_language_defn): Initialise new field.
10930         (asm_language_defn): Initialise new field.
10931         (minimal_language_defn): Initialise new field.
10932         * c-lang.h (c_is_string_type_p): Declare new function.
10933         * d-lang.c (d_language_defn): Initialise new field.
10934         * f-lang.c (f_is_string_type_p): New function.
10935         (f_language_defn): Initialise new field.
10936         * go-lang.c (go_is_string_type_p): New function.
10937         (go_language_defn): Initialise new field.
10938         * language.c (default_is_string_type_p): New function.
10939         (unknown_language_defn): Initialise new field.
10940         (auto_language_defn): Initialise new field.
10941         * language.h (struct language_defn) <la_is_string_type_p>: New
10942         member variable.
10943         (default_is_string_type_p): Declare new function.
10944         * m2-lang.c (m2_language_defn): Initialise new field.
10945         * objc-lang.c (objc_language_defn): Initialise new field.
10946         * opencl-lang.c (opencl_language_defn): Initialise new field.
10947         * p-lang.c (pascal_is_string_type_p): New function.
10948         (pascal_language_defn): Initialise new field.
10949         * rust-lang.c (rust_is_string_type_p): New function.
10950         (rust_language_defn): Initialise new field.
10951
10952 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
10953
10954         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
10955         New field.
10956         * ada-lang.c (ada_language_defn): Initialise new field.
10957         * c-lang.c (c_language_defn): Likewise.
10958         (cplus_language_defn): Likewise.
10959         (asm_language_defn): Likewise.
10960         (minimal_language_defn): Likewise.
10961         * d-lang.c (d_language_defn): Likewise.
10962         * f-lang.c (f_language_defn): Likewise.
10963         * go-lang.c (go_language_defn): Likewise.
10964         * language.c (unknown_language_defn): Likewise.
10965         (auto_language_defn): Likewise.
10966         * m2-lang.c (m2_language_defn): Likewise.
10967         * objc-lang.c (objc_language_defn): Likewise.
10968         * opencl-lang.c (opencl_language_defn): Likewise.
10969         * p-lang.c (pascal_language_defn): Likewise.
10970         * rust-lang.c (rust_language_defn): Likewise.
10971
10972 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
10973
10974         * ada-lang.c (ada_is_character_type): Change return type to bool.
10975         (ada_is_string_type): Likewise.
10976         * ada-lang.h (ada_is_character_type): Update declaration
10977         (ada_is_string_type): Likewise.
10978
10979 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10980
10981         Support style in 'frame|thread apply'
10982
10983         * gdbcmd.h (execute_command_to_string): New term_out parameter.
10984         * record.c (record_start, record_stop): Update callers of
10985         execute_command_to_string with false.
10986         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
10987         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
10988         methods.
10989         (class string_file): New constructor with term_out parameter.
10990         Override methods term_out and can_emit_style_escape.  New member
10991         term_out.
10992         (class stdio_file): Override can_emit_style_escape.
10993         (class tee_file): Override term_out and can_emit_style_escape.
10994         * utils.h (can_emit_style_escape): Remove.
10995         * utils.c (can_emit_style_escape): Likewise.
10996         Update all callers of can_emit_style_escape (SOMESTREAM) to
10997         SOMESTREAM->can_emit_style_escape.
10998         * source-cache.c (source_cache::get_source_lines): Likewise.
10999         * stack.c (frame_apply_command_count): Call execute_command_to_string
11000         passing the term_out characteristic of the current gdb_stdout.
11001         * thread.c (thr_try_catch_cmd): Likewise.
11002         * top.c (execute_command_to_string): pass term_out parameter
11003         to construct the string_file for the command output.
11004         * ui-file.c (term_cli_styling): New function (most code moved
11005         from utils.c can_emit_style_escape).
11006         (string_file::string_file, string_file::can_emit_style_escape,
11007         stdio_file::can_emit_style_escape, tee_file::term_out,
11008         tee_file::can_emit_style_escape): New functions.
11009
11010 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11011
11012         * NEWS: Mention the new set|show may-call-functions.
11013         * infcall.c (may_call_functions_p): New variable.
11014         (show_may_call_functions_p): New function.
11015         (call_function_by_hand_dummy): Throws an error if not
11016         may-call-functions.
11017         (_initialize_infcall): Call add_setshow_boolean_cmd for
11018         may-call-functions.
11019
11020 2019-04-25  Keith Seitz  <keiths@redhat.com>
11021
11022         PR c++/24367
11023         * cp-support.c (inspect_type): Don't attempt substitutions
11024         of symbol with the same name.
11025
11026 2019-04-25  Tom Tromey  <tromey@adacore.com>
11027
11028         PR gdb/24475:
11029         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
11030         static.
11031
11032 2019-04-25  Tom Tromey  <tromey@adacore.com>
11033
11034         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
11035         rvalue reference.
11036         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
11037         (gdb_xml_parser::parse): Use std::move.
11038         * python/python-internal.h (gdbpy_convert_exception): Take a const
11039         reference.
11040         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
11041         std::move.
11042         * python/py-utils.c (gdbpy_convert_exception): Take a const
11043         reference.
11044         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
11045         Use std::move.
11046         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
11047         Use std::move.
11048         * mi/mi-main.c (mi_print_exception): Take a const reference.
11049         * main.c (handle_command_errors): Take a const reference.
11050         * linespec.c (parse_linespec): Use std::move.
11051         * infcall.c (run_inferior_call): Use std::move.
11052         (call_function_by_hand_dummy): Use std::move.
11053         * exec.c (try_open_exec_file): Use std::move.
11054         * exceptions.h (exception_print, exception_fprintf)
11055         (exception_print_same): Update.
11056         * exceptions.c (print_exception, exception_print)
11057         (exception_fprintf, exception_print_same): Change parameters to
11058         const reference.
11059         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
11060         * common/new-op.c: Use std::move.
11061         * common/common-exceptions.h (struct gdb_exception): Add move
11062         constructor.
11063         (struct gdb_exception_error, struct gdb_exception_quit, struct
11064         gdb_quit_bad_alloc): Change constructor to move constructor.
11065         (throw_exception): Change parameter to rvalue reference.
11066         * common/common-exceptions.c (throw_exception): Take rvalue
11067         reference.
11068         * cli/cli-interp.c (safe_execute_command): Use std::move.
11069         * breakpoint.c (insert_bp_location, location_to_sals): Use
11070         std::move.
11071
11072 2019-04-25  Tom Tromey  <tromey@adacore.com>
11073
11074         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
11075         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
11076         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
11077         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
11078         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
11079         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
11080         guile/scm-value.c: Use unpack.
11081         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
11082         gdbscm_gdb_exception.
11083         (gdbscm_throw_gdb_exception): Likewise.
11084         (struct gdbscm_gdb_exception): New.
11085         (unpack): New function.
11086         (gdbscm_wrap): Use unpack.
11087
11088 2019-04-25  Tom Tromey  <tromey@adacore.com>
11089
11090         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
11091         (gdb_rl_callback_handler): Use std::move.
11092         * common/common-exceptions.h (struct gdb_exception): Add move
11093         assignment operator.
11094         (throw_exception_sjlj): Change "exception" to const reference.
11095         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
11096         (throw_exception_sjlj): Change "exception" to const reference.
11097
11098 2019-04-25  Tom Tromey  <tromey@adacore.com>
11099
11100         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
11101         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
11102         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
11103         Update.
11104         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
11105         Update.
11106         * mi/mi-interp.c (mi_interp::exec): Update.
11107         * linespec.c (parse_linespec): Update.
11108         * infcall.c (run_inferior_call): Update.
11109         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
11110         * guile/scm-symbol.c (gdbscm_lookup_symbol)
11111         (gdbscm_lookup_global_symbol): Update.
11112         * guile/scm-param.c (gdbscm_parameter_value): Update.
11113         * guile/scm-frame.c (gdbscm_frame_read_register)
11114         (gdbscm_frame_read_var): Update.
11115         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
11116         * exec.c (try_open_exec_file): Update.
11117         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
11118         (gdb_rl_callback_handler): Update.
11119         * common/common-exceptions.h (exception_none): Don't declare.
11120         * common/common-exceptions.c (exception_none): Don't define.
11121         (struct catcher) <exception>: Update.
11122         * cli/cli-interp.c (safe_execute_command): Update.
11123         * breakpoint.c (insert_bp_location, location_to_sals): Update.
11124
11125 2019-04-25  Ali Tamur  <tamur@google.com>
11126
11127         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
11128         (read_attribute_value): Likewise.
11129         (dwarf2_read_addr_index): Update comment.
11130         (read_str_index): Add DW_FORM_strx.
11131         (dwarf2_string_attr): Likewise.
11132         (dwarf2_const_value_attr): Likewise.
11133         (dump_die_shallow): Likewise.
11134         (dwarf2_fetch_constant_bytes): Likewise.
11135         (skip_form_bytes): Likewise.
11136         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
11137
11138 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
11139
11140         PR corefiles/11608
11141         PR corefiles/18187
11142         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
11143         OFFSET.  Verify if current mapping contains an ELF header.
11144         (linux_find_memory_regions_full): Adjust call to
11145         dump_mapping_p.
11146
11147 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
11148             Kang Li <kanglictf@gmail.com>
11149
11150         PR gdb/21600
11151
11152         * dwarf2-frame.c (read_initial_length): Be consistent about using
11153         unsigned representation of length.
11154         (decode_frame_entry_1): Likewise.  Check for wraparound of
11155         end pointer as well as buffer overflow.
11156
11157 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
11158
11159         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
11160         "vq".
11161
11162 2019-04-24  Tom Tromey  <tromey@adacore.com>
11163
11164         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
11165
11166 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11167
11168         * s12z-tdep.c (s12z_unwind_pc): Delete.
11169         (s12z_unwind_sp): Delete.
11170         (s12z_gdbarch_init): Don't register deleted functions with
11171         gdbarch.
11172
11173 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11174
11175         * rl78-tdep.c (rl78_unwind_sp): Delete.
11176         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
11177
11178 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11179
11180         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
11181         (xstormy16_unwind_pc): Delete.
11182         (xstormy16_dummy_id): Delete.
11183         (xstormy16_gdbarch_init): Don't register deleted functions with
11184         gdbarch.
11185
11186 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11187
11188         * vax-tdep.c (vax_unwind_pc): Delete.
11189         (vax_gdbarch_init): Don't register deleted function with gdbarch.
11190
11191 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11192
11193         * v850-tdep.c (v850_unwind_sp): Delete.
11194         (v850_unwind_pc): Delete.
11195         (v850_dummy_id): Delete.
11196         (v850_gdbarch_init): Don't register deleted functions with
11197         gdbarch.
11198
11199 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11200
11201         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
11202         (tilegx_unwind_pc): Delete.
11203         (tilegx_unwind_dummy_id): Delete.
11204         (tilegx_gdbarch_init): Don't register deleted functions with
11205         gdbarch.
11206
11207 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11208
11209         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
11210         (tic6x_dummy_id): Delete.
11211         (tic6x_gdbarch_init): Don't register deleted functions with
11212         gdbarch.
11213
11214 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11215
11216         * sparc-tdep.c (sparc_unwind_pc): Delete.
11217         (sparc32_gdbarch_init): Don't register deleted function with
11218         gdbarch.
11219
11220 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11221
11222         * sh-tdep.c (sh_unwind_sp): Delete.
11223         (sh_unwind_pc): Delete.
11224         (sh_dummy_id): Delete.
11225         (sh_gdbarch_init): Don't register deleted functions with
11226         gdbarch.
11227
11228 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11229
11230         * score-tdep.c (score_unwind_sp): Delete.
11231         (score_unwind_pc): Delete.
11232         (score_dummy_id): Delete.
11233         (score_gdbarch_init): Don't register deleted functions with
11234         gdbarch.
11235
11236 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11237
11238         * rx-tdep.c (rx_unwind_pc): Delete.
11239         (rx_unwind_sp): Delete.
11240         (rx_dummy_id): Delete.
11241         (rx_gdbarch_init): Don't register deleted functions with
11242         gdbarch.  Update comment.
11243
11244 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11245
11246         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
11247         (rs6000_dummy_id): Delete.
11248         (rs6000_gdbarch_init): Don't register deleted functions with
11249         gdbarch.
11250
11251 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11252
11253         * or1k-tdep.c (or1k_dummy_id): Delete.
11254         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
11255
11256 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11257
11258         * nios2-tdep.c (nios2_dummy_id): Delete.
11259         (nios2_unwind_sp): Delete.
11260         (nios2_gdbarch_init): Don't register deleted functions with
11261         gdbarch.
11262
11263 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11264
11265         * nds32-tdep.c (nds32_dummy_id): Delete.
11266         (nds32_unwind_pc): Delete.
11267         (nds32_unwind_sp): Delete.
11268         (nds32_gdbarch_init): Don't register deleted functions with
11269         gdbarch.
11270
11271 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11272
11273         * msp430-tdep.c (msp430_unwind_pc): Delete.
11274         (msp430_unwind_sp): Delete.
11275         (msp430_dummy_id): Delete.
11276         (msp430_gdbarch_init): Don't register deleted functions with
11277         gdbarch.
11278
11279 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11280
11281         * moxie-tdep.c (moxie_unwind_sp): Delete.
11282         (moxie_unwind_pc): Delete.
11283         (moxie_dummy_id): Delete.
11284         (moxie_gdbarch_init): Don't register deleted functions with
11285         gdbarch.
11286
11287 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11288
11289         * mn10300-tdep.c (mn10300_dummy_id): Delete.
11290         (mn10300_unwind_pc): Delete.
11291         (mn10300_unwind_sp): Delete.
11292         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
11293         mn10300_unwind_sp.
11294         (mn10300_frame_unwind_init): Don't register deleted functions with
11295         gdbarch.
11296
11297 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11298
11299         * mep-tdep.c (mep_unwind_pc): Delete.
11300         (mep_unwind_sp): Delete.
11301         (mep_dummy_id): Delete.
11302         (mep_gdbarch_init): Don't register deleted functions with
11303         gdbarch.
11304
11305 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11306
11307         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
11308         (m68hc11_unwind_sp): Delete.
11309         (m68hc11_gdbarch_init): Don't register deleted functions with
11310         gdbarch.
11311
11312 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11313
11314         * m32r-tdep.c (m32r_unwind_sp): Delete.
11315         (m32r_unwind_pc): Delete.
11316         (m32r_dummy_id): Delete.
11317         (m32r_gdbarch_init): Don't register deleted functions with
11318         gdbarch.
11319
11320 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11321
11322         * m32c-tdep.c (m32c_unwind_pc): Delete.
11323         (m32c_unwind_sp): Delete.
11324         (m32c_dummy_id): Delete.
11325         (m32c_gdbarch_init): Don't register deleted functions with
11326         gdbarch.
11327
11328 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11329
11330         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
11331         (lm32_unwind_pc): Delete.
11332         (lm32_dummy_id): Delete.
11333         (lm32_gdbarch_init): Don't register deleted functions with
11334         gdbarch.
11335
11336 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11337
11338         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
11339         (iq2000_unwind_pc): Delete.
11340         (iq2000_dummy_id): Delete.
11341         (iq2000_gdbarch_init): Don't register deleted functions with
11342         gdbarch.
11343
11344 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11345
11346         * nds32-tdep.c (nds32_type_align): Delete.
11347         (nds32_push_dummy_call): Use type_align instead.
11348
11349 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11350
11351         * arm-tdep.c (arm_type_align): Only handle vector override case.
11352         (arm_push_dummy_call): Use type_align.
11353         (arm_gdbarch_init): Register arm_type_align gdbarch function.
11354
11355 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11356
11357         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
11358         case.
11359         (pass_on_stack): Use type_align.
11360         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
11361         function.
11362
11363 2019-04-23  Tom Tromey  <tromey@adacore.com>
11364
11365         * dwarf2read.c (line_header::file_name_at): Remove unused
11366         overload.
11367
11368 2019-04-23  Tom de Vries  <tdevries@suse.de>
11369
11370         PR gdb/24438
11371         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
11372         invocation.
11373
11374
11375 2019-03-27  Ali Tamur  <tamur@google.com>
11376
11377         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
11378         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
11379         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
11380         (dwarf_expr_context::get_addr_index): Likewise
11381         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
11382         (symbol_needs_eval_context::get_addr_index): Likewise
11383         (disassemble_dwarf_expression): Add DW_OP_addrx
11384         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
11385         (read_cutu_die_from_dwo): Update comment
11386         (skip_one_die): Add DW_FORM_addrx
11387         (read_attribute_value): Likewise
11388         (var_decode_location): Add DW_OP_addrx
11389         (dwarf2_const_value_attr): Add DW_FORM_addrx
11390         (dump_die_shallow): Likewise
11391         (dwarf2_fetch_constant_bytes): Likewise
11392         (decode_locdesc): Add DW_OP_addrx
11393         (skip_form_bytes): Add DW_FORM_addrx
11394
11395 2019-04-22  Ali Tamur  <tamur@google.com>
11396
11397         * MAINTAINERS (Write After Approval): Add self.
11398
11399 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
11400
11401         * solib-svr4.c (get_svr4_info): Add pspace parameter.
11402         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
11403         (open_symbol_file_object): Likewise.
11404         (svr4_default_sos): Add info parameter.
11405         (svr4_read_so_list): Likewise.
11406         (svr4_current_sos_direct): Adjust functions calls to pass down
11407         info.
11408         (svr4_current_sos_1): Add info parameter.
11409         (svr4_current_sos): Call get_svr4_info, pass info down to
11410         svr4_current_sos_1.
11411         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
11412         get_svr4_info.
11413         (svr4_in_dynsym_resolve_code): Pass current_program_space to
11414         get_svr4_info.
11415         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
11416         to get_svr4_info.
11417         (probes_table_remove_objfile_probes): Likewise.
11418         (register_solib_event_probe): Add info parameter.
11419         (solist_update_incremental): Pass info parameter down to
11420         svr4_read_so_list.
11421         (disable_probes_interface): Add info parameter.
11422         (svr4_handle_solib_event): Pass current_program_space to
11423         get_svr4_info.  Adjust disable_probes_interface cleanup.
11424         (svr4_create_probe_breakpoints): Add info parameter, pass it
11425         down to register_solib_event_probe.
11426         (svr4_create_solib_event_breakpoints): Add info parameter,
11427         pass it down to svr4_create_probe_breakpoints.
11428         (enable_break): Pass info down to
11429         svr4_create_solib_event_breakpoints.
11430         (svr4_solib_create_inferior_hook): Pass current_program_space to
11431         get_svr4_info.
11432         (svr4_clear_solib): Likewise.
11433
11434 2019-04-22  Pedro Alves  <palves@redhat.com>
11435
11436         * solib-svr4.c (svr4_free_objfile_observer): New.
11437         (probe_and_action::objfile): New field.
11438         (probes_table_htab_remove_objfile_probes)
11439         (probes_table_remove_objfile_probes): New functions.
11440         (register_solib_event_probe): Add 'objfile' parameter.  Store it
11441         in the new probe_and_action.  Don't store the probe in 'lookup'.
11442         (svr4_create_probe_breakpoints): Pass objfile to
11443         register_solib_event_probe.
11444         (_initialize_svr4_solib): Register a free_objfile observer.
11445
11446 2019-04-19  Tom Tromey  <tom@tromey.com>
11447
11448         * common/queue.h: Remove.
11449
11450 2019-04-19  Tom Tromey  <tom@tromey.com>
11451
11452         * event-loop.c: Don't include "common/queue.h".
11453
11454 2019-04-19  Tom Tromey  <tom@tromey.com>
11455
11456         * remote.c (remote_target): Use delete.
11457         * remote-notif.h: Include <list>, not "common/queue.h".
11458         (notif_client_p): Remove typedef.
11459         (remote_notif_state): Add constructor, destructor, initializer.
11460         <notif_queue>: Now a std::list.
11461         (remote_notif_state_xfree): Don't declare.
11462         * remote-notif.c (remote_notif_process, handle_notification)
11463         (remote_notif_state_allocate): Update.
11464         (~remote_notif_state): Rename from remote_notif_state_xfree.
11465
11466 2019-04-19  Tom Tromey  <tom@tromey.com>
11467
11468         * symfile.c (reread_symbols): Update.
11469         * objfiles.c (objfile_register_static_link)
11470         (objfile_lookup_static_link): Update
11471         (~objfile) Don't delete static_links.
11472         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
11473
11474 2019-04-19  Tom Tromey  <tom@tromey.com>
11475
11476         * type-stack.h (struct type_stack) <insert>: Constify string.
11477         * type-stack.c (type_stack::insert): Constify string.
11478         * gdbtypes.h (lookup_template_type): Update.
11479         (address_space_name_to_int): Update.
11480         * gdbtypes.c (address_space_name_to_int): Make space_identifier
11481         const.
11482         (lookup_template_type): Make name const.
11483         * c-exp.y: Update rules.
11484         (lex_one_token, classify_name, classify_inner_name)
11485         (c_print_token): Update.
11486         * p-exp.y: Update rules.
11487         (yylex): Update.
11488         * f-exp.y: Update rules.
11489         (yylex): Update.
11490         * d-exp.y: Update rules.
11491         (lex_one_token, classify_name, classify_inner_name): Update.
11492         * parse.c (write_dollar_variable, copy_name): Return std::string.
11493         * parser-defs.h (copy_name): Change return type.
11494         * m2-exp.y: Update rules.
11495         (yylex): Update.
11496         * go-exp.y (lex_one_token): Update.
11497         Update rules.
11498         (classify_unsafe_function, classify_packaged_name)
11499         (classify_name, yylex): Update.
11500
11501 2019-04-19  Sergei Trofimovich <siarheit@google.com>
11502
11503         * configure.ac: add --enable-source-highlight switch.
11504         * configure: Regenerate.
11505         * top.c (print_gdb_version): plumb --enable-source-highlight
11506         status to "show configuration".
11507
11508 2019-04-19  Tom Tromey  <tromey@adacore.com>
11509
11510         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
11511         Check ADA_TYPE_P.
11512         (empty_record, ada_template_to_fixed_record_type_1)
11513         (template_to_static_fixed_type)
11514         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
11515         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
11516         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
11517         macros.
11518
11519 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
11520
11521         PR symtab/24423:
11522         * source.c (print_source_lines_base): Advance "iter" when a
11523         control character is seen.
11524
11525 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11526
11527         * inferior.h (struct infcall_suspend_state_deleter):
11528         Catch exception in destructor to avoid crash.
11529
11530 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11531
11532         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
11533         close to the add_com "shell".
11534
11535 2019-04-18  Tom Tromey  <tromey@adacore.com>
11536
11537         * process-stratum-target.h (class process_stratum_target)
11538         <stratum>: Add "final".
11539
11540 2019-04-17  Tom Tromey  <tromey@adacore.com>
11541
11542         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
11543         against nullptr before use.
11544
11545 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
11546
11547         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
11548
11549 2019-04-17  Jim Wilson  <jimw@sifive.com>
11550             Andrew Burgess  <andrew.burgess@embecosm.com>
11551
11552         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
11553         code read might fail, assume 4-byte breakpoint in that case.
11554
11555 2019-04-15  Leszek Swirski  <leszeks@google.com>
11556
11557         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
11558         rather than a hand-rolled POD check when checking for forced MEMORY
11559         classification.
11560
11561 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
11562
11563         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
11564         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
11565         function.
11566         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
11567         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
11568         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
11569         declaration.
11570
11571 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
11572
11573         * aarch64-linux-nat.c
11574         (aarch64_linux_nat_target::thread_architecture): Add override.
11575         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
11576         each VQ.
11577
11578 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
11579
11580         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
11581
11582 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
11583
11584         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
11585         target types of size 96-bits, add some additional comments, and
11586         check that the builtin type we found was the correct size.
11587
11588 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
11589
11590         * utils.c (prompt_for_continue): Don't restore the styling at the
11591         end, as applied_style has the wrong value.  This fixes styling in
11592         long lists of file names that are interrupted by the "Continue?"
11593         prompt.
11594
11595 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
11596
11597         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
11598         * c-lang.c (c_language_defn): Likewise.
11599         (cplus_language_defn): Likewise.
11600         (asm_language_defn): Likewise.
11601         (minimal_language_defn): Likewise.
11602         * d-lang.c (d_language_defn): Likewise.
11603         * f-lang.c (f_language_defn): Likewise.
11604         * go-lang.c (go_language_defn): Likewise.
11605         * language.c (unknown_language_defn): Likewise.
11606         (auto_language_defn): Likewise.
11607         * language.h (struct language_defn): Remove la_magic field.
11608         (LANG_MAGIC): Delete.
11609         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
11610         * objc-lang.c (objc_language_defn): Likewise.
11611         * opencl-lang.c (opencl_language_defn): Likewise.
11612         * p-lang.c (pascal_language_defn): Likewise.
11613         * rust-lang.c (rust_language_defn): Likewise.
11614
11615 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
11616
11617         * riscv-tdep.c (riscv_type_align): New function.
11618         (riscv_type_alignment): Delete.
11619         (riscv_arg_location): Use 'type_align'.
11620         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
11621
11622 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
11623
11624         * gdbtypes.c (type_align): A struct with no non-static fields also
11625         has alignment of 1.
11626
11627 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
11628
11629         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
11630         component to 0.
11631         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
11632         member.
11633         (riscv_struct_info::analyse): New implementation using new
11634         analyse_inner member function.
11635         (riscv_struct_info::field_offset): New member function.
11636         (riscv_struct_info::m_offsets): New member variable.
11637         (riscv_struct_info::analyse_inner): New private member function,
11638         takes the old implementation of riscv_struct_info::analyse but
11639         extended to track field offsets.
11640         (riscv_call_arg_struct): Update the struct folding special cases
11641         to handle cases where empty C++ structs, which are non-zero
11642         length, are found.
11643         (riscv_arg_location): Initialise the length of each location, a
11644         non-zero length now indicates the location is in use.
11645         (riscv_push_dummy_call): Allow for the first location having a
11646         non-zero offset when setting up arguments.
11647         (riscv_return_value): Likewise, but for return values.
11648
11649 2019-04-11  Tom Tromey  <tromey@adacore.com>
11650
11651         * utils.c (internal_vproblem): Make "msg" const.
11652
11653 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
11654
11655         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
11656         * trad-frame.c (trad_frame_reset_saved_regs): New function.
11657         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
11658         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
11659
11660 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
11661
11662         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
11663         function.
11664         (fill_gregset): Call amd64_linux_collect_native_gregset instead
11665         of amd64_collect_native_gregset.
11666         (amd64_linux_nat_target::store_registers): Likewise.
11667
11668 2019-04-10  Tom Tromey  <tom@tromey.com>
11669
11670         * symtab.c (lookup_global_symbol_from_objfile)
11671         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
11672         * objfiles.h (class separate_debug_iterator): New.
11673         (class separate_debug_range): New.
11674         (struct objfile) <separate_debug_objfiles>: New method.
11675         (objfile_separate_debug_iterate): Don't declare.
11676         * objfiles.c (separate_debug_iterator::operator++): Rename from
11677         objfile_separate_debug_iterate.
11678         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
11679         iterator.
11680         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
11681         iterator.
11682
11683 2019-04-10  Tom Tromey  <tom@tromey.com>
11684
11685         * symfile.c (reread_symbols): Remove old comment.
11686         * objfiles.c (free_all_objfiles): Fix a typo.
11687
11688 2019-04-10  Tom Tromey  <tom@tromey.com>
11689
11690         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
11691         * minsyms.c (lookup_minimal_symbol): Use foreach.
11692         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
11693         (lookup_minimal_symbol_solib_trampoline): Likewise.
11694         * symfile.c (reread_symbols): Use foreach.
11695
11696 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
11697             Tom Tromey  <tromey@adacore.com>
11698
11699         PR rust/24414:
11700         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
11701         (rust_lex_int_test): Change "value" to be LONGEST.
11702         (rust_lex_tests): Add test for long integer literal.
11703
11704 2019-04-09  Tom Tromey  <tromey@adacore.com>
11705
11706         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
11707         to bool.
11708         (extended_remote_target::attach): Update.
11709         (remote_target::remote_notice_new_inferior): Update.
11710         (remote_target::add_current_inferior_and_thread): Update.
11711         * inferior.c (exit_inferior_1): Use "false".
11712         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
11713
11714 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
11715
11716         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
11717         the "start" command.
11718
11719 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
11720
11721         * python/py-inferior.c (infpy_thread_from_thread_handle):
11722         Adjust comments to reflect renaming of thread_from_thread_handle
11723         to thread_from_handle.  Adjust keywords.  Fix type error message.
11724         (inferior_object_methods): Add thread_from_handle.  Retain
11725         thread_from_thread_handle, but mark it as deprecated.
11726
11727 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
11728
11729         * gdbthread.h (find_thread_by_handle): Revise declaration.
11730         * thread.c (find_thread_by_handle): Likewise.  Adjust
11731         implementation too.
11732         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
11733         support for buffer objects as handles.
11734
11735 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
11736
11737         * python/py-infthread.c (thpy_thread_handle): New function.
11738         (thread_object_methods): Register thpy_thread_handle.
11739
11740 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
11741
11742         * gdbthread.h (thread_to_thread_handle): Declare.
11743         * thread.c (gdbtypes.h): Include.
11744         (thread_to_thread_handle): New function.
11745
11746         * target.h (struct target_ops): Add thread_info_to_thread_handle.
11747         (target_thread_info_to_thread_handle): Declare.
11748         * target.c (target_thread_info_to_thread_handle): New function.
11749         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
11750         * target-delegates.c: Regenerate.
11751
11752         * linux-thread-db.c (class thread_db_target): Add method
11753         thread_info_to_thread_handle.
11754         (thread_db_target::thread_info_to_thread_handle): Define.
11755         * remote.c (class remote_target): Add new method
11756         thread_info_to_thread_handle.
11757         (remote_target::thread_info_to_thread_handle): Define.
11758
11759 2019-04-08  Pedro Alves  <palves@redhat.com>
11760
11761         * common/common-exceptions.c (throw_exception): Don't create
11762         named object to throw; throw directly.
11763         (throw_it): Likewise.  Don't initialize gdb_exception::message
11764         here, with new; pass FMT and AP to the ctor instead.
11765         * common/common-exceptions.h: Include <string>.
11766         (gdb_exception::gdb_exception(enum return_reason, enum errors,
11767         const char *, va_list)): New ctor.  Use std::make_shared.
11768         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
11769         errors)): Delete.
11770         (gdb_exception_error::gdb_exception_error(enum errors, const char
11771         *, va_list)): New.
11772         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
11773         Add assertion.
11774         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
11775         errors)): Delete.
11776         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
11777         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
11778         Add assertion.
11779
11780 2019-04-08  Tom Tromey  <tom@tromey.com>
11781
11782         * valops.c (value_rtti_indirect_type): Replace throw_exception
11783         with throw.
11784         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
11785         with throw.
11786         * thread.c (thr_try_catch_cmd): Replace throw_exception with
11787         throw.
11788         * target.c (target_translate_tls_address): Replace throw_exception
11789         with throw.
11790         * stack.c (frame_apply_command_count): Replace throw_exception
11791         with throw.
11792         * solib-spu.c (append_ocl_sos): Replace throw_exception with
11793         throw.
11794         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
11795         with throw.
11796         * rs6000-tdep.c (rs6000_frame_cache)
11797         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
11798         * remote.c: Replace throw_exception with throw.
11799         * record-full.c (record_full_message, record_full_wait_1)
11800         (record_full_restore): Replace throw_exception with throw.
11801         * record-btrace.c:
11802         (get_thread_current_frame_id, record_btrace_start_replaying)
11803         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
11804         (cmd_record_btrace_start): Replace throw_exception with throw.
11805         * parse.c (parse_exp_in_context_1): Replace throw_exception with
11806         throw.
11807         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
11808         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
11809         * linespec.c:
11810         (find_linespec_symbols): Replace throw_exception with throw.
11811         * infrun.c (displaced_step_prepare, resume): Replace
11812         throw_exception with throw.
11813         * infcmd.c (post_create_inferior): Replace throw_exception with
11814         throw.
11815         * inf-loop.c (inferior_event_handler): Replace throw_exception
11816         with throw.
11817         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
11818         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
11819         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
11820         (get_prev_frame_always, get_frame_pc_if_available)
11821         (get_frame_address_in_block_if_available, get_frame_language):
11822         Replace throw_exception with throw.
11823         * frame-unwind.c (frame_unwind_try_unwinder): Replace
11824         throw_exception with throw.
11825         * eval.c (fetch_subexp_value, evaluate_var_value)
11826         (evaluate_funcall, evaluate_subexp_standard): Replace
11827         throw_exception with throw.
11828         * dwarf2loc.c (call_site_find_chain)
11829         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
11830         Replace throw_exception with throw.
11831         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
11832         with throw.
11833         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
11834         throw.
11835         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
11836         * completer.c (complete_line_internal): Replace throw_exception
11837         with throw.
11838         * compile/compile-object-run.c (compile_object_run): Replace
11839         throw_exception with throw.
11840         * cli/cli-script.c (process_next_line): Replace throw_exception
11841         with throw.
11842         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
11843         (btrace_enable, btrace_maint_update_pt_packets): Replace
11844         throw_exception with throw.
11845         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
11846         throw_exception with throw.
11847         * break-catch-throw.c (re_set_exception_catchpoint): Replace
11848         throw_exception with throw.
11849         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
11850         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
11851         * aarch64-tdep.c (aarch64_make_prologue_cache)
11852         (aarch64_make_stub_cache): Replace throw_exception with throw.
11853
11854 2019-04-08  Tom Tromey  <tom@tromey.com>
11855
11856         * common/common-exceptions.c (throw_exception): Rename from
11857         throw_exception_cxx.  Remove old copy.  Make argument const.
11858         (throw_it): Create and throw exception objects directly.
11859         * common/common-exceptions.h (throw_exception): Make argument
11860         const.
11861         (struct gdb_exception_error): Add constructor.
11862         (struct gdb_exception_quit): Add constructor.
11863
11864 2019-04-08  Tom Tromey  <tom@tromey.com>
11865
11866         * common/common-exceptions.h (exception_rethrow): Don't declare.
11867         (TRY_SJLJ): Update comment.
11868         (TRY, CATCH, END_CATCH): Remove.
11869         * common/common-exceptions.c (exception_rethrow): Remove.
11870
11871 2019-04-08  Tom Tromey  <tom@tromey.com>
11872
11873         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
11874         Remove.
11875         (gdb_exception_error): Rename from
11876         gdb_exception_RETURN_MASK_ERROR.
11877         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
11878         (gdb_quit_bad_alloc): Update.
11879         * aarch64-tdep.c: Update.
11880         * ada-lang.c: Update.
11881         * ada-typeprint.c: Update.
11882         * ada-valprint.c: Update.
11883         * amd64-tdep.c: Update.
11884         * arch-utils.c: Update.
11885         * break-catch-throw.c: Update.
11886         * breakpoint.c: Update.
11887         * btrace.c: Update.
11888         * c-varobj.c: Update.
11889         * cli/cli-cmds.c: Update.
11890         * cli/cli-interp.c: Update.
11891         * cli/cli-script.c: Update.
11892         * common/common-exceptions.c: Update.
11893         * common/new-op.c: Update.
11894         * common/selftest.c: Update.
11895         * compile/compile-c-symbols.c: Update.
11896         * compile/compile-cplus-symbols.c: Update.
11897         * compile/compile-object-load.c: Update.
11898         * compile/compile-object-run.c: Update.
11899         * completer.c: Update.
11900         * corelow.c: Update.
11901         * cp-abi.c: Update.
11902         * cp-support.c: Update.
11903         * cp-valprint.c: Update.
11904         * darwin-nat.c: Update.
11905         * disasm-selftests.c: Update.
11906         * dtrace-probe.c: Update.
11907         * dwarf-index-cache.c: Update.
11908         * dwarf-index-write.c: Update.
11909         * dwarf2-frame-tailcall.c: Update.
11910         * dwarf2-frame.c: Update.
11911         * dwarf2loc.c: Update.
11912         * dwarf2read.c: Update.
11913         * eval.c: Update.
11914         * event-loop.c: Update.
11915         * event-top.c: Update.
11916         * exec.c: Update.
11917         * f-valprint.c: Update.
11918         * fbsd-tdep.c: Update.
11919         * frame-unwind.c: Update.
11920         * frame.c: Update.
11921         * gdbtypes.c: Update.
11922         * gnu-v3-abi.c: Update.
11923         * guile/guile-internal.h: Update.
11924         * guile/scm-block.c: Update.
11925         * guile/scm-breakpoint.c: Update.
11926         * guile/scm-cmd.c: Update.
11927         * guile/scm-disasm.c: Update.
11928         * guile/scm-frame.c: Update.
11929         * guile/scm-lazy-string.c: Update.
11930         * guile/scm-math.c: Update.
11931         * guile/scm-param.c: Update.
11932         * guile/scm-ports.c: Update.
11933         * guile/scm-pretty-print.c: Update.
11934         * guile/scm-symbol.c: Update.
11935         * guile/scm-symtab.c: Update.
11936         * guile/scm-type.c: Update.
11937         * guile/scm-value.c: Update.
11938         * i386-linux-tdep.c: Update.
11939         * i386-tdep.c: Update.
11940         * inf-loop.c: Update.
11941         * infcall.c: Update.
11942         * infcmd.c: Update.
11943         * infrun.c: Update.
11944         * jit.c: Update.
11945         * language.c: Update.
11946         * linespec.c: Update.
11947         * linux-fork.c: Update.
11948         * linux-nat.c: Update.
11949         * linux-tdep.c: Update.
11950         * linux-thread-db.c: Update.
11951         * main.c: Update.
11952         * mi/mi-cmd-break.c: Update.
11953         * mi/mi-cmd-stack.c: Update.
11954         * mi/mi-interp.c: Update.
11955         * mi/mi-main.c: Update.
11956         * objc-lang.c: Update.
11957         * p-valprint.c: Update.
11958         * parse.c: Update.
11959         * ppc-linux-tdep.c: Update.
11960         * printcmd.c: Update.
11961         * python/py-arch.c: Update.
11962         * python/py-breakpoint.c: Update.
11963         * python/py-cmd.c: Update.
11964         * python/py-finishbreakpoint.c: Update.
11965         * python/py-frame.c: Update.
11966         * python/py-framefilter.c: Update.
11967         * python/py-gdb-readline.c: Update.
11968         * python/py-inferior.c: Update.
11969         * python/py-infthread.c: Update.
11970         * python/py-lazy-string.c: Update.
11971         * python/py-linetable.c: Update.
11972         * python/py-objfile.c: Update.
11973         * python/py-param.c: Update.
11974         * python/py-prettyprint.c: Update.
11975         * python/py-progspace.c: Update.
11976         * python/py-record-btrace.c: Update.
11977         * python/py-record.c: Update.
11978         * python/py-symbol.c: Update.
11979         * python/py-type.c: Update.
11980         * python/py-unwind.c: Update.
11981         * python/py-utils.c: Update.
11982         * python/py-value.c: Update.
11983         * python/python.c: Update.
11984         * record-btrace.c: Update.
11985         * record-full.c: Update.
11986         * remote-fileio.c: Update.
11987         * remote.c: Update.
11988         * riscv-tdep.c: Update.
11989         * rs6000-aix-tdep.c: Update.
11990         * rs6000-tdep.c: Update.
11991         * rust-exp.y: Update.
11992         * rust-lang.c: Update.
11993         * s390-tdep.c: Update.
11994         * selftest-arch.c: Update.
11995         * solib-dsbt.c: Update.
11996         * solib-frv.c: Update.
11997         * solib-spu.c: Update.
11998         * solib-svr4.c: Update.
11999         * solib.c: Update.
12000         * sparc64-linux-tdep.c: Update.
12001         * stack.c: Update.
12002         * symfile-mem.c: Update.
12003         * symmisc.c: Update.
12004         * target.c: Update.
12005         * thread.c: Update.
12006         * top.c: Update.
12007         * tracefile-tfile.c: Update.
12008         * tui/tui.c: Update.
12009         * typeprint.c: Update.
12010         * unittests/cli-utils-selftests.c: Update.
12011         * unittests/parse-connection-spec-selftests.c: Update.
12012         * valops.c: Update.
12013         * valprint.c: Update.
12014         * value.c: Update.
12015         * varobj.c: Update.
12016         * windows-nat.c: Update.
12017         * x86-linux-nat.c: Update.
12018         * xml-support.c: Update.
12019
12020 2019-04-08  Tom Tromey  <tom@tromey.com>
12021
12022         * xml-support.c: Use C++ exception handling.
12023         * x86-linux-nat.c: Use C++ exception handling.
12024         * windows-nat.c: Use C++ exception handling.
12025         * varobj.c: Use C++ exception handling.
12026         * value.c: Use C++ exception handling.
12027         * valprint.c: Use C++ exception handling.
12028         * valops.c: Use C++ exception handling.
12029         * unittests/parse-connection-spec-selftests.c: Use C++ exception
12030         handling.
12031         * unittests/cli-utils-selftests.c: Use C++ exception handling.
12032         * typeprint.c: Use C++ exception handling.
12033         * tui/tui.c: Use C++ exception handling.
12034         * tracefile-tfile.c: Use C++ exception handling.
12035         * top.c: Use C++ exception handling.
12036         * thread.c: Use C++ exception handling.
12037         * target.c: Use C++ exception handling.
12038         * symmisc.c: Use C++ exception handling.
12039         * symfile-mem.c: Use C++ exception handling.
12040         * stack.c: Use C++ exception handling.
12041         * sparc64-linux-tdep.c: Use C++ exception handling.
12042         * solib.c: Use C++ exception handling.
12043         * solib-svr4.c: Use C++ exception handling.
12044         * solib-spu.c: Use C++ exception handling.
12045         * solib-frv.c: Use C++ exception handling.
12046         * solib-dsbt.c: Use C++ exception handling.
12047         * selftest-arch.c: Use C++ exception handling.
12048         * s390-tdep.c: Use C++ exception handling.
12049         * rust-lang.c: Use C++ exception handling.
12050         * rust-exp.y: Use C++ exception handling.
12051         * rs6000-tdep.c: Use C++ exception handling.
12052         * rs6000-aix-tdep.c: Use C++ exception handling.
12053         * riscv-tdep.c: Use C++ exception handling.
12054         * remote.c: Use C++ exception handling.
12055         * remote-fileio.c: Use C++ exception handling.
12056         * record-full.c: Use C++ exception handling.
12057         * record-btrace.c: Use C++ exception handling.
12058         * python/python.c: Use C++ exception handling.
12059         * python/py-value.c: Use C++ exception handling.
12060         * python/py-utils.c: Use C++ exception handling.
12061         * python/py-unwind.c: Use C++ exception handling.
12062         * python/py-type.c: Use C++ exception handling.
12063         * python/py-symbol.c: Use C++ exception handling.
12064         * python/py-record.c: Use C++ exception handling.
12065         * python/py-record-btrace.c: Use C++ exception handling.
12066         * python/py-progspace.c: Use C++ exception handling.
12067         * python/py-prettyprint.c: Use C++ exception handling.
12068         * python/py-param.c: Use C++ exception handling.
12069         * python/py-objfile.c: Use C++ exception handling.
12070         * python/py-linetable.c: Use C++ exception handling.
12071         * python/py-lazy-string.c: Use C++ exception handling.
12072         * python/py-infthread.c: Use C++ exception handling.
12073         * python/py-inferior.c: Use C++ exception handling.
12074         * python/py-gdb-readline.c: Use C++ exception handling.
12075         * python/py-framefilter.c: Use C++ exception handling.
12076         * python/py-frame.c: Use C++ exception handling.
12077         * python/py-finishbreakpoint.c: Use C++ exception handling.
12078         * python/py-cmd.c: Use C++ exception handling.
12079         * python/py-breakpoint.c: Use C++ exception handling.
12080         * python/py-arch.c: Use C++ exception handling.
12081         * printcmd.c: Use C++ exception handling.
12082         * ppc-linux-tdep.c: Use C++ exception handling.
12083         * parse.c: Use C++ exception handling.
12084         * p-valprint.c: Use C++ exception handling.
12085         * objc-lang.c: Use C++ exception handling.
12086         * mi/mi-main.c: Use C++ exception handling.
12087         * mi/mi-interp.c: Use C++ exception handling.
12088         * mi/mi-cmd-stack.c: Use C++ exception handling.
12089         * mi/mi-cmd-break.c: Use C++ exception handling.
12090         * main.c: Use C++ exception handling.
12091         * linux-thread-db.c: Use C++ exception handling.
12092         * linux-tdep.c: Use C++ exception handling.
12093         * linux-nat.c: Use C++ exception handling.
12094         * linux-fork.c: Use C++ exception handling.
12095         * linespec.c: Use C++ exception handling.
12096         * language.c: Use C++ exception handling.
12097         * jit.c: Use C++ exception handling.
12098         * infrun.c: Use C++ exception handling.
12099         * infcmd.c: Use C++ exception handling.
12100         * infcall.c: Use C++ exception handling.
12101         * inf-loop.c: Use C++ exception handling.
12102         * i386-tdep.c: Use C++ exception handling.
12103         * i386-linux-tdep.c: Use C++ exception handling.
12104         * guile/scm-value.c: Use C++ exception handling.
12105         * guile/scm-type.c: Use C++ exception handling.
12106         * guile/scm-symtab.c: Use C++ exception handling.
12107         * guile/scm-symbol.c: Use C++ exception handling.
12108         * guile/scm-pretty-print.c: Use C++ exception handling.
12109         * guile/scm-ports.c: Use C++ exception handling.
12110         * guile/scm-param.c: Use C++ exception handling.
12111         * guile/scm-math.c: Use C++ exception handling.
12112         * guile/scm-lazy-string.c: Use C++ exception handling.
12113         * guile/scm-frame.c: Use C++ exception handling.
12114         * guile/scm-disasm.c: Use C++ exception handling.
12115         * guile/scm-cmd.c: Use C++ exception handling.
12116         * guile/scm-breakpoint.c: Use C++ exception handling.
12117         * guile/scm-block.c: Use C++ exception handling.
12118         * guile/guile-internal.h: Use C++ exception handling.
12119         * gnu-v3-abi.c: Use C++ exception handling.
12120         * gdbtypes.c: Use C++ exception handling.
12121         * frame.c: Use C++ exception handling.
12122         * frame-unwind.c: Use C++ exception handling.
12123         * fbsd-tdep.c: Use C++ exception handling.
12124         * f-valprint.c: Use C++ exception handling.
12125         * exec.c: Use C++ exception handling.
12126         * event-top.c: Use C++ exception handling.
12127         * event-loop.c: Use C++ exception handling.
12128         * eval.c: Use C++ exception handling.
12129         * dwarf2read.c: Use C++ exception handling.
12130         * dwarf2loc.c: Use C++ exception handling.
12131         * dwarf2-frame.c: Use C++ exception handling.
12132         * dwarf2-frame-tailcall.c: Use C++ exception handling.
12133         * dwarf-index-write.c: Use C++ exception handling.
12134         * dwarf-index-cache.c: Use C++ exception handling.
12135         * dtrace-probe.c: Use C++ exception handling.
12136         * disasm-selftests.c: Use C++ exception handling.
12137         * darwin-nat.c: Use C++ exception handling.
12138         * cp-valprint.c: Use C++ exception handling.
12139         * cp-support.c: Use C++ exception handling.
12140         * cp-abi.c: Use C++ exception handling.
12141         * corelow.c: Use C++ exception handling.
12142         * completer.c: Use C++ exception handling.
12143         * compile/compile-object-run.c: Use C++ exception handling.
12144         * compile/compile-object-load.c: Use C++ exception handling.
12145         * compile/compile-cplus-symbols.c: Use C++ exception handling.
12146         * compile/compile-c-symbols.c: Use C++ exception handling.
12147         * common/selftest.c: Use C++ exception handling.
12148         * common/new-op.c: Use C++ exception handling.
12149         * cli/cli-script.c: Use C++ exception handling.
12150         * cli/cli-interp.c: Use C++ exception handling.
12151         * cli/cli-cmds.c: Use C++ exception handling.
12152         * c-varobj.c: Use C++ exception handling.
12153         * btrace.c: Use C++ exception handling.
12154         * breakpoint.c: Use C++ exception handling.
12155         * break-catch-throw.c: Use C++ exception handling.
12156         * arch-utils.c: Use C++ exception handling.
12157         * amd64-tdep.c: Use C++ exception handling.
12158         * ada-valprint.c: Use C++ exception handling.
12159         * ada-typeprint.c: Use C++ exception handling.
12160         * ada-lang.c: Use C++ exception handling.
12161         * aarch64-tdep.c: Use C++ exception handling.
12162
12163 2019-04-08  Tom Tromey  <tom@tromey.com>
12164
12165         * xml-support.c (gdb_xml_parser::parse): Update.
12166         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
12167         * value.c (show_convenience): Update.
12168         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
12169         (test_parse_flags_qcs): Update.
12170         * thread.c (thr_try_catch_cmd): Update.
12171         * target.c (target_translate_tls_address): Update.
12172         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
12173         (info_frame_command_core, frame_apply_command_count): Update.
12174         * rust-exp.y (rust_lex_exception_test): Update.
12175         * riscv-tdep.c (riscv_print_one_register_info): Update.
12176         * remote.c (remote_target::enable_btrace): Update.
12177         * record-btrace.c (record_btrace_enable_warn): Update.
12178         * python/py-utils.c (gdbpy_convert_exception): Update.
12179         * printcmd.c (do_one_display, print_variable_and_value): Update.
12180         * mi/mi-main.c (mi_print_exception): Update.
12181         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
12182         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
12183         * linux-nat.c (linux_nat_target::attach): Update.
12184         * linux-fork.c (class scoped_switch_fork_info): Update.
12185         * infrun.c (displaced_step_prepare): Update.
12186         * infcall.c (call_function_by_hand_dummy): Update.
12187         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
12188         * gnu-v3-abi.c (print_one_vtable): Update.
12189         * frame.c (get_prev_frame_always): Update.
12190         * f-valprint.c (info_common_command_for_block): Update.
12191         * exec.c (try_open_exec_file): Update.
12192         * exceptions.c (print_exception, exception_print)
12193         (exception_fprintf, exception_print_same): Update.
12194         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
12195         * dwarf-index-cache.c (index_cache::store)
12196         (index_cache::lookup_gdb_index): Update.
12197         * darwin-nat.c (maybe_cache_shell): Update.
12198         * cp-valprint.c (cp_print_value_fields): Update.
12199         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
12200         (gcc_cplus_symbol_address): Update.
12201         * compile/compile-c-symbols.c (gcc_convert_symbol)
12202         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
12203         * common/selftest.c: Update.
12204         * common/common-exceptions.h (struct gdb_exception) <message>: Now
12205         a std::string.
12206         (exception_try_scope_entry, exception_try_scope_exit): Don't
12207         declare.
12208         (struct exception_try_scope): Remove.
12209         (TRY): Don't use exception_try_scope.
12210         (struct gdb_exception): Add constructor, operator=.
12211         <what>: New method.
12212         (struct gdb_exception_RETURN_MASK_ALL)
12213         (struct gdb_exception_RETURN_MASK_ERROR)
12214         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
12215         (struct gdb_quit_bad_alloc): Update.
12216         * common/common-exceptions.c (exception_none): Change
12217         initializer.
12218         (struct catcher) <state, exception>: Initialize inline.
12219         <prev>: Remove member.
12220         (current_catcher): Remove.
12221         (catchers): New global.
12222         (exceptions_state_mc_init): Simplify.
12223         (catcher_pop): Remove.
12224         (exceptions_state_mc, exceptions_state_mc_catch): Update.
12225         (try_scope_depth, exception_try_scope_entry)
12226         (exception_try_scope_exit): Remove.
12227         (throw_exception_sjlj): Update.
12228         (exception_messages, exception_messages_size): Remove.
12229         (throw_it): Simplify.
12230         (gdb_exception_sliced_copy): Remove.
12231         (throw_exception_cxx): Update.
12232         * cli/cli-script.c (script_from_file): Update.
12233         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
12234         Update.
12235         * ada-valprint.c (ada_val_print): Update.
12236         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
12237         (create_excep_cond_exprs): Update.
12238
12239 2019-04-08  Tom Tromey  <tom@tromey.com>
12240
12241         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
12242         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
12243         (TRY, CATCH, END_CATCH): Remove some definitions.
12244         * common/common-exceptions.c: Don't use GDB_XCPT.
12245         (catcher_list_size): Remove.
12246         (throw_exception, throw_it): Simplify.
12247
12248 2019-04-05  Tom Tromey  <tom@tromey.com>
12249
12250         Revert the header-sorting patch.
12251         * ft32-tdep.c: Revert.
12252         * frv-tdep.c: Revert.
12253         * frv-linux-tdep.c: Revert.
12254         * frame.c: Revert.
12255         * frame-unwind.c: Revert.
12256         * frame-base.c: Revert.
12257         * fork-child.c: Revert.
12258         * findvar.c: Revert.
12259         * findcmd.c: Revert.
12260         * filesystem.c: Revert.
12261         * filename-seen-cache.h: Revert.
12262         * filename-seen-cache.c: Revert.
12263         * fbsd-tdep.c: Revert.
12264         * fbsd-nat.h: Revert.
12265         * fbsd-nat.c: Revert.
12266         * f-valprint.c: Revert.
12267         * f-typeprint.c: Revert.
12268         * f-lang.c: Revert.
12269         * extension.h: Revert.
12270         * extension.c: Revert.
12271         * extension-priv.h: Revert.
12272         * expprint.c: Revert.
12273         * exec.h: Revert.
12274         * exec.c: Revert.
12275         * exceptions.c: Revert.
12276         * event-top.c: Revert.
12277         * event-loop.c: Revert.
12278         * eval.c: Revert.
12279         * elfread.c: Revert.
12280         * dwarf2read.h: Revert.
12281         * dwarf2read.c: Revert.
12282         * dwarf2loc.c: Revert.
12283         * dwarf2expr.h: Revert.
12284         * dwarf2expr.c: Revert.
12285         * dwarf2-frame.c: Revert.
12286         * dwarf2-frame-tailcall.c: Revert.
12287         * dwarf-index-write.h: Revert.
12288         * dwarf-index-write.c: Revert.
12289         * dwarf-index-common.c: Revert.
12290         * dwarf-index-cache.h: Revert.
12291         * dwarf-index-cache.c: Revert.
12292         * dummy-frame.c: Revert.
12293         * dtrace-probe.c: Revert.
12294         * disasm.h: Revert.
12295         * disasm.c: Revert.
12296         * disasm-selftests.c: Revert.
12297         * dictionary.c: Revert.
12298         * dicos-tdep.c: Revert.
12299         * demangle.c: Revert.
12300         * dcache.h: Revert.
12301         * dcache.c: Revert.
12302         * darwin-nat.h: Revert.
12303         * darwin-nat.c: Revert.
12304         * darwin-nat-info.c: Revert.
12305         * d-valprint.c: Revert.
12306         * d-namespace.c: Revert.
12307         * d-lang.c: Revert.
12308         * ctf.c: Revert.
12309         * csky-tdep.c: Revert.
12310         * csky-linux-tdep.c: Revert.
12311         * cris-tdep.c: Revert.
12312         * cris-linux-tdep.c: Revert.
12313         * cp-valprint.c: Revert.
12314         * cp-support.c: Revert.
12315         * cp-namespace.c: Revert.
12316         * cp-abi.c: Revert.
12317         * corelow.c: Revert.
12318         * corefile.c: Revert.
12319         * continuations.c: Revert.
12320         * completer.h: Revert.
12321         * completer.c: Revert.
12322         * complaints.c: Revert.
12323         * coffread.c: Revert.
12324         * coff-pe-read.c: Revert.
12325         * cli-out.h: Revert.
12326         * cli-out.c: Revert.
12327         * charset.c: Revert.
12328         * c-varobj.c: Revert.
12329         * c-valprint.c: Revert.
12330         * c-typeprint.c: Revert.
12331         * c-lang.c: Revert.
12332         * buildsym.c: Revert.
12333         * buildsym-legacy.c: Revert.
12334         * build-id.h: Revert.
12335         * build-id.c: Revert.
12336         * btrace.c: Revert.
12337         * bsd-uthread.c: Revert.
12338         * breakpoint.h: Revert.
12339         * breakpoint.c: Revert.
12340         * break-catch-throw.c: Revert.
12341         * break-catch-syscall.c: Revert.
12342         * break-catch-sig.c: Revert.
12343         * blockframe.c: Revert.
12344         * block.c: Revert.
12345         * bfin-tdep.c: Revert.
12346         * bfin-linux-tdep.c: Revert.
12347         * bfd-target.c: Revert.
12348         * bcache.c: Revert.
12349         * ax-general.c: Revert.
12350         * ax-gdb.h: Revert.
12351         * ax-gdb.c: Revert.
12352         * avr-tdep.c: Revert.
12353         * auxv.c: Revert.
12354         * auto-load.c: Revert.
12355         * arm-wince-tdep.c: Revert.
12356         * arm-tdep.c: Revert.
12357         * arm-symbian-tdep.c: Revert.
12358         * arm-pikeos-tdep.c: Revert.
12359         * arm-obsd-tdep.c: Revert.
12360         * arm-nbsd-tdep.c: Revert.
12361         * arm-nbsd-nat.c: Revert.
12362         * arm-linux-tdep.c: Revert.
12363         * arm-linux-nat.c: Revert.
12364         * arm-fbsd-tdep.c: Revert.
12365         * arm-fbsd-nat.c: Revert.
12366         * arm-bsd-tdep.c: Revert.
12367         * arch-utils.c: Revert.
12368         * arc-tdep.c: Revert.
12369         * arc-newlib-tdep.c: Revert.
12370         * annotate.h: Revert.
12371         * annotate.c: Revert.
12372         * amd64-windows-tdep.c: Revert.
12373         * amd64-windows-nat.c: Revert.
12374         * amd64-tdep.c: Revert.
12375         * amd64-sol2-tdep.c: Revert.
12376         * amd64-obsd-tdep.c: Revert.
12377         * amd64-obsd-nat.c: Revert.
12378         * amd64-nbsd-tdep.c: Revert.
12379         * amd64-nbsd-nat.c: Revert.
12380         * amd64-nat.c: Revert.
12381         * amd64-linux-tdep.c: Revert.
12382         * amd64-linux-nat.c: Revert.
12383         * amd64-fbsd-tdep.c: Revert.
12384         * amd64-fbsd-nat.c: Revert.
12385         * amd64-dicos-tdep.c: Revert.
12386         * amd64-darwin-tdep.c: Revert.
12387         * amd64-bsd-nat.c: Revert.
12388         * alpha-tdep.c: Revert.
12389         * alpha-obsd-tdep.c: Revert.
12390         * alpha-nbsd-tdep.c: Revert.
12391         * alpha-mdebug-tdep.c: Revert.
12392         * alpha-linux-tdep.c: Revert.
12393         * alpha-linux-nat.c: Revert.
12394         * alpha-bsd-tdep.c: Revert.
12395         * alpha-bsd-nat.c: Revert.
12396         * aix-thread.c: Revert.
12397         * agent.c: Revert.
12398         * addrmap.c: Revert.
12399         * ada-varobj.c: Revert.
12400         * ada-valprint.c: Revert.
12401         * ada-typeprint.c: Revert.
12402         * ada-tasks.c: Revert.
12403         * ada-lang.c: Revert.
12404         * aarch64-tdep.c: Revert.
12405         * aarch64-ravenscar-thread.c: Revert.
12406         * aarch64-newlib-tdep.c: Revert.
12407         * aarch64-linux-tdep.c: Revert.
12408         * aarch64-linux-nat.c: Revert.
12409         * aarch64-fbsd-tdep.c: Revert.
12410         * aarch64-fbsd-nat.c: Revert.
12411         * aarch32-linux-nat.c: Revert.
12412
12413 2019-04-05  Tom Tromey  <tom@tromey.com>
12414
12415         * ft32-tdep.c: Sort headers.
12416         * frv-tdep.c: Sort headers.
12417         * frv-linux-tdep.c: Sort headers.
12418         * frame.c: Sort headers.
12419         * frame-unwind.c: Sort headers.
12420         * frame-base.c: Sort headers.
12421         * fork-child.c: Sort headers.
12422         * findvar.c: Sort headers.
12423         * findcmd.c: Sort headers.
12424         * filesystem.c: Sort headers.
12425         * filename-seen-cache.h: Sort headers.
12426         * filename-seen-cache.c: Sort headers.
12427         * fbsd-tdep.c: Sort headers.
12428         * fbsd-nat.h: Sort headers.
12429         * fbsd-nat.c: Sort headers.
12430         * f-valprint.c: Sort headers.
12431         * f-typeprint.c: Sort headers.
12432         * f-lang.c: Sort headers.
12433         * extension.h: Sort headers.
12434         * extension.c: Sort headers.
12435         * extension-priv.h: Sort headers.
12436         * expprint.c: Sort headers.
12437         * exec.h: Sort headers.
12438         * exec.c: Sort headers.
12439         * exceptions.c: Sort headers.
12440         * event-top.c: Sort headers.
12441         * event-loop.c: Sort headers.
12442         * eval.c: Sort headers.
12443         * elfread.c: Sort headers.
12444         * dwarf2read.h: Sort headers.
12445         * dwarf2read.c: Sort headers.
12446         * dwarf2loc.c: Sort headers.
12447         * dwarf2expr.h: Sort headers.
12448         * dwarf2expr.c: Sort headers.
12449         * dwarf2-frame.c: Sort headers.
12450         * dwarf2-frame-tailcall.c: Sort headers.
12451         * dwarf-index-write.h: Sort headers.
12452         * dwarf-index-write.c: Sort headers.
12453         * dwarf-index-common.c: Sort headers.
12454         * dwarf-index-cache.h: Sort headers.
12455         * dwarf-index-cache.c: Sort headers.
12456         * dummy-frame.c: Sort headers.
12457         * dtrace-probe.c: Sort headers.
12458         * disasm.h: Sort headers.
12459         * disasm.c: Sort headers.
12460         * disasm-selftests.c: Sort headers.
12461         * dictionary.c: Sort headers.
12462         * dicos-tdep.c: Sort headers.
12463         * demangle.c: Sort headers.
12464         * dcache.h: Sort headers.
12465         * dcache.c: Sort headers.
12466         * darwin-nat.h: Sort headers.
12467         * darwin-nat.c: Sort headers.
12468         * darwin-nat-info.c: Sort headers.
12469         * d-valprint.c: Sort headers.
12470         * d-namespace.c: Sort headers.
12471         * d-lang.c: Sort headers.
12472         * ctf.c: Sort headers.
12473         * csky-tdep.c: Sort headers.
12474         * csky-linux-tdep.c: Sort headers.
12475         * cris-tdep.c: Sort headers.
12476         * cris-linux-tdep.c: Sort headers.
12477         * cp-valprint.c: Sort headers.
12478         * cp-support.c: Sort headers.
12479         * cp-namespace.c: Sort headers.
12480         * cp-abi.c: Sort headers.
12481         * corelow.c: Sort headers.
12482         * corefile.c: Sort headers.
12483         * continuations.c: Sort headers.
12484         * completer.h: Sort headers.
12485         * completer.c: Sort headers.
12486         * complaints.c: Sort headers.
12487         * coffread.c: Sort headers.
12488         * coff-pe-read.c: Sort headers.
12489         * cli-out.h: Sort headers.
12490         * cli-out.c: Sort headers.
12491         * charset.c: Sort headers.
12492         * c-varobj.c: Sort headers.
12493         * c-valprint.c: Sort headers.
12494         * c-typeprint.c: Sort headers.
12495         * c-lang.c: Sort headers.
12496         * buildsym.c: Sort headers.
12497         * buildsym-legacy.c: Sort headers.
12498         * build-id.h: Sort headers.
12499         * build-id.c: Sort headers.
12500         * btrace.c: Sort headers.
12501         * bsd-uthread.c: Sort headers.
12502         * breakpoint.h: Sort headers.
12503         * breakpoint.c: Sort headers.
12504         * break-catch-throw.c: Sort headers.
12505         * break-catch-syscall.c: Sort headers.
12506         * break-catch-sig.c: Sort headers.
12507         * blockframe.c: Sort headers.
12508         * block.c: Sort headers.
12509         * bfin-tdep.c: Sort headers.
12510         * bfin-linux-tdep.c: Sort headers.
12511         * bfd-target.c: Sort headers.
12512         * bcache.c: Sort headers.
12513         * ax-general.c: Sort headers.
12514         * ax-gdb.h: Sort headers.
12515         * ax-gdb.c: Sort headers.
12516         * avr-tdep.c: Sort headers.
12517         * auxv.c: Sort headers.
12518         * auto-load.c: Sort headers.
12519         * arm-wince-tdep.c: Sort headers.
12520         * arm-tdep.c: Sort headers.
12521         * arm-symbian-tdep.c: Sort headers.
12522         * arm-pikeos-tdep.c: Sort headers.
12523         * arm-obsd-tdep.c: Sort headers.
12524         * arm-nbsd-tdep.c: Sort headers.
12525         * arm-nbsd-nat.c: Sort headers.
12526         * arm-linux-tdep.c: Sort headers.
12527         * arm-linux-nat.c: Sort headers.
12528         * arm-fbsd-tdep.c: Sort headers.
12529         * arm-fbsd-nat.c: Sort headers.
12530         * arm-bsd-tdep.c: Sort headers.
12531         * arch-utils.c: Sort headers.
12532         * arc-tdep.c: Sort headers.
12533         * arc-newlib-tdep.c: Sort headers.
12534         * annotate.h: Sort headers.
12535         * annotate.c: Sort headers.
12536         * amd64-windows-tdep.c: Sort headers.
12537         * amd64-windows-nat.c: Sort headers.
12538         * amd64-tdep.c: Sort headers.
12539         * amd64-sol2-tdep.c: Sort headers.
12540         * amd64-obsd-tdep.c: Sort headers.
12541         * amd64-obsd-nat.c: Sort headers.
12542         * amd64-nbsd-tdep.c: Sort headers.
12543         * amd64-nbsd-nat.c: Sort headers.
12544         * amd64-nat.c: Sort headers.
12545         * amd64-linux-tdep.c: Sort headers.
12546         * amd64-linux-nat.c: Sort headers.
12547         * amd64-fbsd-tdep.c: Sort headers.
12548         * amd64-fbsd-nat.c: Sort headers.
12549         * amd64-dicos-tdep.c: Sort headers.
12550         * amd64-darwin-tdep.c: Sort headers.
12551         * amd64-bsd-nat.c: Sort headers.
12552         * alpha-tdep.c: Sort headers.
12553         * alpha-obsd-tdep.c: Sort headers.
12554         * alpha-nbsd-tdep.c: Sort headers.
12555         * alpha-mdebug-tdep.c: Sort headers.
12556         * alpha-linux-tdep.c: Sort headers.
12557         * alpha-linux-nat.c: Sort headers.
12558         * alpha-bsd-tdep.c: Sort headers.
12559         * alpha-bsd-nat.c: Sort headers.
12560         * aix-thread.c: Sort headers.
12561         * agent.c: Sort headers.
12562         * addrmap.c: Sort headers.
12563         * ada-varobj.c: Sort headers.
12564         * ada-valprint.c: Sort headers.
12565         * ada-typeprint.c: Sort headers.
12566         * ada-tasks.c: Sort headers.
12567         * ada-lang.c: Sort headers.
12568         * aarch64-tdep.c: Sort headers.
12569         * aarch64-ravenscar-thread.c: Sort headers.
12570         * aarch64-newlib-tdep.c: Sort headers.
12571         * aarch64-linux-tdep.c: Sort headers.
12572         * aarch64-linux-nat.c: Sort headers.
12573         * aarch64-fbsd-tdep.c: Sort headers.
12574         * aarch64-fbsd-nat.c: Sort headers.
12575         * aarch32-linux-nat.c: Sort headers.
12576
12577 2019-04-04  Tom Tromey  <tom@tromey.com>
12578
12579         * varobj.c (varobj_create): Update.
12580         * rust-exp.y (struct rust_parser) <update_innermost_block,
12581         lookup_symbol>: New methods.
12582         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
12583         Rename.
12584         (rust_parser::rust_lookup_type)
12585         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
12586         * printcmd.c (display_command, do_one_display): Update.
12587         * parser-defs.h (struct parser_state) <parser_state>: Add
12588         "tracker" parameter.
12589         (block_tracker): New member.
12590         (class innermost_block_tracker) <innermost_block_tracker>: Add
12591         "types" parameter.
12592         <reset>: Remove method.
12593         (innermost_block): Don't declare.
12594         (null_post_parser): Update.
12595         * parse.c (innermost_block): Remove global.
12596         (write_dollar_variable): Update.
12597         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
12598         Remove "tracker_types" parameter.
12599         (parse_expression): Add "tracker" parameter.
12600         (parse_expression_for_completion): Update.
12601         (null_post_parser): Add "tracker" parameter.
12602         * p-exp.y: Update rules.
12603         * m2-exp.y: Update rules.
12604         * language.h (struct language_defn) <la_post_parser>: Add
12605         "tracker" parameter.
12606         * go-exp.y: Update rules.
12607         * f-exp.y: Update rules.
12608         * expression.h (parse_expression, parse_exp_1): Add "tracker"
12609         parameter.
12610         * d-exp.y: Update rules.
12611         * c-exp.y: Update rules.
12612         * breakpoint.c (set_breakpoint_condition): Create an
12613         innermost_block_tracker.
12614         (watch_command_1): Likewise.
12615         * ada-lang.c (resolve): Add "tracker" parameter.
12616         (resolve_subexp): Likewise.
12617         * ada-exp.y (write_var_from_sym): Update.
12618
12619 2019-04-04  Tom Tromey  <tom@tromey.com>
12620
12621         * type-stack.h: New file.
12622         * type-stack.c: New file.
12623         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
12624         type-stack.h.
12625         (insert_into_type_stack, insert_type, push_type, push_type_int)
12626         (insert_type_address_space, pop_type, pop_type_int)
12627         (pop_typelist, pop_type_stack, append_type_stack)
12628         (push_type_stack, get_type_stack, push_typelist)
12629         (follow_type_instance_flags, follow_types): Don't declare.
12630         * parse.c (type_stack): Remove global.
12631         (parse_exp_in_context): Update.
12632         (insert_into_type_stack, insert_type, push_type, push_type_int)
12633         (insert_type_address_space, pop_type, pop_type_int)
12634         (pop_typelist, pop_type_stack, append_type_stack)
12635         (push_type_stack, get_type_stack, push_typelist)
12636         (follow_type_instance_flags, follow_types): Remove (moved to
12637         type-stack.c).
12638         * f-exp.y (type_stack): New global.
12639         Update rules.
12640         (push_kind_type, f_parse): Update.
12641         * d-exp.y (type_stack): New global.
12642         Update rules.
12643         (d_parse): Update.
12644         * c-exp.y (struct c_parse_state) <type_stack>: New member.
12645         Update rules.
12646         * Makefile.in (COMMON_SFILES): Add type-stack.c.
12647         (HFILES_NO_SRCDIR): Add type-stack.h.
12648
12649 2019-04-04  Tom Tromey  <tom@tromey.com>
12650
12651         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
12652         (rust_parser::convert_ast_to_expression, rust_parse)
12653         (rust_lex_test_completion, rust_lex_tests): Update.
12654         * parser-defs.h (struct expr_completion_state): New.
12655         (struct parser_state) <parser_state>: Add completion parameter.
12656         <mark_struct_expression, mark_completion_tag>: New methods.
12657         <parse_completion, m_completion_state>: New members.
12658         (prefixify_expression, null_post_parser): Update.
12659         (mark_struct_expression, mark_completion_tag): Don't declare.
12660         * parse.c (parse_completion, expout_last_struct)
12661         (expout_tag_completion_type, expout_completion_name): Remove
12662         globals.
12663         (parser_state::mark_struct_expression)
12664         (parser_state::mark_completion_tag): Now methods.
12665         (prefixify_expression): Add last_struct parameter.
12666         (prefixify_subexp): Likewise.
12667         (parse_exp_1): Update.
12668         (parse_exp_in_context): Add cstate parameter.  Update.
12669         (parse_expression_for_completion): Create an
12670         expr_completion_state.
12671         (null_post_parser): Add "completion" parameter.
12672         * p-exp.y: Update rules.
12673         (yylex): Update.
12674         * language.h (struct language_defn) <la_post_parser>: Add
12675         "completing" parameter.
12676         * go-exp.y: Update rules.
12677         (lex_one_token): Update.
12678         * expression.h (parse_completion): Don't declare.
12679         * d-exp.y: Update rules.
12680         (lex_one_token): Update rules.
12681         * c-exp.y: Update rules.
12682         (lex_one_token): Update.
12683         * ada-lang.c (resolve): Add "parse_completion" parameter.
12684         (resolve_subexp): Likewise.
12685         (ada_resolve_function): Likewise.
12686
12687 2019-04-04  Tom Tromey  <tom@tromey.com>
12688
12689         * parser-defs.h (struct parser_state) <start_arglist,
12690         end_arglist>: New methods.
12691         <arglist_len, m_funcall_chain>: New members.
12692         (arglist_len, start_arglist, end_arglist): Don't declare.
12693         * parse.c (arglist_len, funcall_chain): Remove global.
12694         (start_arglist, end_arglist): Remove functions.
12695         (parse_exp_in_context): Update.
12696         * p-exp.y: Update rules.
12697         * m2-exp.y: Update rules.
12698         * go-exp.y: Update rules.
12699         * f-exp.y: Update rules.
12700         * d-exp.y: Update rules.
12701         * c-exp.y: Update rules.
12702
12703 2019-04-04  Tom Tromey  <tom@tromey.com>
12704
12705         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
12706         lex_operator, push_back>: New methods.
12707         Update all rules.
12708         (rust_parser::lex_hex, lex_escape): Rename and update.
12709         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
12710         (rust_parser::lex_operator): Rename and update.
12711         (rust_parser::lex_number, rustyylex, rustyyerror)
12712         (rust_lex_test_init, rust_lex_test_sequence)
12713         (rust_lex_test_push_back, rust_lex_tests): Update.
12714         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
12715         parameter.
12716         <lexptr, prev_lexptr>: New members.
12717         (lexptr, prev_lexptr): Don't declare.
12718         * parse.c (lexptr, prev_lexptr): Remove globals.
12719         (parse_exp_in_context): Update.
12720         * p-exp.y (yylex, yyerror): Update.
12721         * m2-exp.y (parse_number, yylex, yyerror): Update.
12722         * go-exp.y (lex_one_token, yyerror): Update.
12723         * f-exp.y (match_string_literal, yylex, yyerror): Update.
12724         * d-exp.y (lex_one_token, yyerror): Update.
12725         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
12726         (lex_one_token, yyerror): Update.
12727         * ada-lex.l (YY_INPUT): Update.
12728         (rewind_to_char): Update.
12729         * ada-exp.y (yyerror): Update.
12730
12731 2019-04-04  Tom Tromey  <tom@tromey.com>
12732
12733         * rust-exp.y (rustyylex, rust_lex_tests): Update.
12734         * parser-defs.h (struct parser_state) <parser_state>: Add new
12735         parameter.
12736         <comma_terminates>: New member.
12737         (comma_terminates): Don't declare global.
12738         * parse.c (comma_terminates): Remove global.
12739         (parse_exp_in_context): Update.
12740         * p-exp.y (yylex): Update.
12741         * m2-exp.y (yylex): Update.
12742         * go-exp.y (lex_one_token): Update.
12743         * f-exp.y (yylex): Update.
12744         * d-exp.y (lex_one_token): Update.
12745         * c-exp.y (lex_one_token): Update.
12746         * ada-lex.l: Update.
12747
12748 2019-04-04  Tom Tromey  <tom@tromey.com>
12749
12750         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
12751         (rustyylex, rust_lex_test_init, rust_lex_test_one)
12752         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
12753         * parser-defs.h (paren_depth): Don't declare.
12754         * parse.c (paren_depth): Remove global.
12755         (parse_exp_in_context): Update.
12756         * p-exp.y (paren_depth): New global.
12757         (pascal_parse): Initialize it.
12758         * m2-exp.y (paren_depth): New global.
12759         (m2_parse): Initialize it.
12760         * go-exp.y (paren_depth): New global.
12761         (go_parse): Initialize it.
12762         * f-exp.y (paren_depth): New global.
12763         (f_parse): Initialize it.
12764         * d-exp.y (paren_depth): New global.
12765         (d_parse): Initialize it.
12766         * c-exp.y (paren_depth): New global.
12767         (c_parse): Initialize it.
12768         * ada-lex.l (paren_depth): New global.
12769         (lexer_init): Initialize it.
12770
12771 2019-04-04  Tom Tromey  <tom@tromey.com>
12772
12773         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
12774         (rust_parser::convert_ast_to_type)
12775         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
12776         * parser-defs.h (struct parser_state) <parser_state>: Add
12777         parameters.  Initialize new members.
12778         <expression_context_block, expression_context_pc>: New members.
12779         * parse.c (expression_context_block, expression_context_pc):
12780         Remove globals.
12781         (parse_exp_in_context): Update.
12782         * p-exp.y: Update all rules.
12783         (yylex): Update.
12784         * m2-exp.y: Update all rules.
12785         (yylex): Update.
12786         * go-exp.y (yylex): Update.
12787         * f-exp.y (yylex): Update.
12788         * d-exp.y: Update all rules.
12789         (yylex): Update.
12790         * c-exp.y: Update all rules.
12791         (lex_one_token, classify_name, yylex, c_parse): Update.
12792         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
12793
12794 2019-04-04  Tom Tromey  <tom@tromey.com>
12795
12796         * gdbarch.h, gdbarch.c: Rebuild.
12797         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
12798         * stap-probe.h:
12799         (struct stap_parse_info): Replace "parser_state" with
12800         "expr_builder".
12801         * parser-defs.h (struct expr_builder): Rename from "parser_state".
12802         (parser_state): New class.
12803         * parse.c (expr_builder): Rename.
12804         (expr_builder::release): Rename.
12805         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
12806         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
12807         (write_exp_elt_longcst, write_exp_elt_floatcst)
12808         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
12809         (write_exp_string_vector, write_exp_bitstring)
12810         (write_exp_msymbol, mark_struct_expression)
12811         (write_dollar_variable)
12812         (insert_type_address_space, increase_expout_size): Replace
12813         "parser_state" with "expr_builder".
12814         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
12815         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
12816         "parser_state" with "expr_builder".
12817
12818 2019-04-04  Tom Tromey  <tom@tromey.com>
12819
12820         * rust-exp.y: Replace "parse_language" with method call.
12821         * p-exp.y:
12822         (yylex): Replace "parse_language" with method call.
12823         * m2-exp.y:
12824         (yylex): Replace "parse_language" with method call.
12825         * go-exp.y (classify_name): Replace "parse_language" with method
12826         call.
12827         * f-exp.y (yylex): Replace "parse_language" with method call.
12828         * d-exp.y (lex_one_token): Replace "parse_language" with method
12829         call.
12830         * c-exp.y:
12831         (lex_one_token, classify_name, yylex): Replace "parse_language"
12832         with method call.
12833         * ada-exp.y (find_primitive_type, type_char)
12834         (type_system_address): Replace "parse_language" with method call.
12835
12836 2019-04-04  Tom Tromey  <tom@tromey.com>
12837
12838         * rust-exp.y: Replace "parse_gdbarch" with method call.
12839         * parse.c (write_dollar_variable, insert_type_address_space):
12840         Replace "parse_gdbarch" with method call.
12841         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
12842         call.
12843         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
12844         call.
12845         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
12846         "parse_gdbarch" with method call.
12847         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
12848         with method call.
12849         * f-exp.y (parse_type, parse_f_type, yylex): Replace
12850         "parse_gdbarch" with method call.
12851         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
12852         "parse_gdbarch" with method call.
12853         * c-exp.y (parse_type, parse_number, classify_name): Replace
12854         "parse_gdbarch" with method call.
12855         * ada-lex.l: Replace "parse_gdbarch" with method call.
12856         * ada-exp.y (parse_type, find_primitive_type, type_char)
12857         (type_system_address): Replace "parse_gdbarch" with method call.
12858
12859 2019-04-04  Tom Tromey  <tom@tromey.com>
12860
12861         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
12862         * stap-probe.c (stap_parse_argument): Update.
12863         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
12864         initial_size parameter.
12865         * rust-exp.y (rust_lex_tests): Update.
12866         * parse.c (parser_state): Update.
12867         (parse_exp_in_context): Update.
12868         * parser-defs.h (struct parser_state) <parser_state>: Remove
12869         "initial_size" parameter.
12870
12871 2019-04-04  Tom Tromey  <tom@tromey.com>
12872
12873         * parser-defs.h (increase_expout_size): Don't declare.
12874         * parse.c (increase_expout_size): Now static.
12875
12876 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
12877
12878         * gnu-nat.c (gnu_nat_target::wait): Fix
12879         target_waitstatus_to_string call.
12880
12881 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
12882
12883         * eval.c (evaluate_subexp_standard): Handle internal functions
12884         during Fortran function call handling.
12885
12886 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
12887
12888         * NEWS: Mention new internal functions.
12889         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
12890         (read_base_type): Use dwarf2_init_complex_target_type.
12891         * value.c (creal_internal_fn): New function.
12892         (cimag_internal_fn): New function.
12893         (_initialize_values): Register new internal functions.
12894
12895 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12896
12897         * infrun.c (stop_all_threads): If debug_infrun, always
12898         trace the wait status after wait_one, using
12899         target_waitstatus_to_string and target_pid_to_str.
12900         (handle_inferior_event): Replace various trace of
12901         wait status kind by a single trace.
12902         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
12903         wait status kind image by target_waitstatus_to_string.
12904         * target/waitstatus.c (target_waitstatus_to_string): Fix
12905         obsolete comment.
12906
12907 2019-04-01  Tom Tromey  <tromey@adacore.com>
12908
12909         PR symtab/23331:
12910         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
12911
12912 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
12913             Pedro Alves  <palves@redhat.com>
12914
12915         * top.c (quit_force): Call 'finalize_values'.
12916         * value.c (finalize_values): New function.
12917         * value.h (finalize_values): Declare.
12918
12919 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
12920
12921         * NEWS: Announce $_gdb_major and $_gdb_minor.
12922
12923         * top.c (init_gdb_version_vars): New function.
12924         (gdb_init): Call init_gdb_version_vars.
12925
12926 2019-03-29  Tom Tromey  <tromey@adacore.com>
12927
12928         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
12929         help text.  Remove dead code.
12930
12931 2019-03-29  Keith Seitz  <keiths@redhat.com>
12932
12933         From Siddhesh Poyarekar:
12934         * f-lang.h (f77_get_upperbound): Return LONGEST.
12935         (f77_get_lowerbound): Likewise.
12936         * f-typeprint.c (f_type_print_varspec_suffix): Expand
12937         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
12938         print them.
12939         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
12940         plongest to format print it.
12941         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
12942         (f77_get_upperbound): Likewise.
12943         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
12944         LOWER_BOUND to LONGEST.
12945         (f77_create_arrayprint_offset_tbl): Likewise.
12946
12947 2019-03-29  Keith Seitz  <keiths@redhat.com>
12948
12949         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
12950         %s/pulongest for TYPE_LENGTH instead of %d in format
12951         strings.
12952         * ada-typerint.c (ada_print_type): Likewise.
12953         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
12954         * compile/compile-c-support.c (generate_register_struct): Likewise.
12955         * gdbtypes.c (recursive_dump_type): Likewise.
12956         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
12957         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
12958         instead of %d in format strings.
12959         * riscv-tdep.c (riscv_type_alignment): Cast second argument
12960         to std::min to ULONGEST.
12961         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
12962         instead of %d in format strings.
12963         * tracepoint.c (info_scope_command): Likewise.
12964         * typeprint.c (print_offset_data::update)
12965         (print_offset_data::finish): Likewise.
12966         * xtensa-tdep.c (xtensa_store_return_value)
12967         (xtensa_push_dummy_call): Likewise.
12968
12969 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
12970
12971         * windows-nat.c (display_selector): Fixed format specifications
12972         for 64-bit Cygwin.
12973
12974 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12975
12976         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
12977
12978 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
12979
12980         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
12981         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
12982         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
12983         (nios2_linux_init_abi): Install it.
12984
12985 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
12986
12987         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
12988
12989 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
12990
12991         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
12992
12993 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12994             Tom Tromey  <tromey@adacore.com>
12995
12996         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
12997
12998 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
12999
13000         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
13001         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
13002         method to compute the bounds of range types. Also print "[evaluated]"
13003         if the bounds' values come from a dynamic evaluation.
13004
13005 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
13006
13007         * cp-valprint.c (cp_print_value_fields): Don't print trailing
13008         whitespace when pretty printing is on.
13009
13010 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
13011
13012         * ppc-linux-nat.c: Add include.
13013
13014 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
13015
13016         * NEWS: Mention AArch64 Pointer Authentication.
13017
13018 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
13019
13020         * arm-linux-nat.c: Add include.
13021
13022 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
13023
13024         * source-cache.c (source_cache::get_source_lines): Re-read
13025         fullname after calling open_source_file.
13026
13027 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
13028
13029         * NEWS: Mention TLS support for FreeBSD.
13030
13031 2019-03-25  Tom Tromey  <tromey@adacore.com>
13032
13033         * minsyms.c (BUNCH_SIZE): Update comment.
13034         (~minimal_symbol_reader): Remove old comment.
13035         (compact_minimal_symbols): Update comment.
13036         (minimal_symbol_reader::install): Remove old comment.  Update
13037         other comments.
13038
13039 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
13040
13041         * s390-linux-nat.c: Add include.
13042
13043 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
13044
13045         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
13046         Call linux_get_hwcap.
13047         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
13048         Likewise.
13049         (aarch64_linux_get_hwcap): Remove function.
13050         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
13051         declaration.
13052         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
13053         linux_get_hwcap.
13054         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
13055         * linux-tdep.c (linux_get_hwcap): Add function.
13056         (linux_get_hwcap2): Likewise.
13057         * linux-tdep.h (linux_get_hwcap): Add declaration.
13058         (linux_get_hwcap2): Likewise.
13059         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
13060         (ppc_linux_get_hwcap2): Likewise.
13061         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
13062         linux_get_hwcap.
13063         (ppc_linux_nat_target::insert_watchpoint): Likewise.
13064         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
13065         (ppc_linux_nat_target::read_description): Likewise.
13066         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
13067         * s390-linux-nat.c: Likewise.
13068         * s390-linux-tdep.c (s390_core_read_description): Likewise.
13069
13070 2019-03-24  Tom Tromey  <tom@tromey.com>
13071
13072         * ada-lang.c (standard_lookup): Simplify initialization.
13073         (ada_lookup_symbol_nonlocal): Simplify return.
13074         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
13075         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
13076         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
13077         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
13078         initialization.
13079         * solib.c (solib_global_lookup): Simplify.
13080         * symtab.c (null_block_symbol): Remove.
13081         (symbol_cache_lookup): Simplify returns.
13082         (lookup_language_this): Simplify returns.
13083         (lookup_symbol_aux): Simplify return.
13084         (lookup_local_symbol): Simplify returns.
13085         (lookup_global_symbol_from_objfile): Simplify return.
13086         (lookup_symbol_in_objfile_symtabs)
13087         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
13088         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
13089         (lookup_static_symbol, lookup_global_symbol): Simplify return.
13090         * cp-namespace.c (cp_lookup_bare_symbol)
13091         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
13092         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
13093         (cp_lookup_nested_symbol): Don't use null_block_symbol.
13094         (cp_lookup_symbol_via_imports): Simplify initialization.
13095         (find_symbol_in_baseclass): Likewise.
13096         * symtab.h (null_block_symbol): Remove.
13097         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
13098         (d_lookup_nested_symbol, d_lookup_symbol_imports)
13099         (d_lookup_symbol_module): Likewise.
13100         (find_symbol_in_baseclass): Simplify initialization.
13101
13102 2019-03-24  Tom Tromey  <tom@tromey.com>
13103
13104         * expression.h: Don't include symtab.h.
13105         (struct block): Forward declare.
13106
13107 2019-03-24  Tom Tromey  <tom@tromey.com>
13108
13109         * c-exp.y (typebase): Remove casts.
13110         * gdbtypes.c (lookup_unsigned_typename, )
13111         (lookup_signed_typename): Remove cast.
13112         * eval.c (parse_to_comma_and_eval): Remove cast.
13113         * parse.c (write_dollar_variable): Remove cast.
13114         * block.h (struct block) <superblock>: Now const.
13115         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
13116         * psymtab.c (psym_map_matching_symbols): Make "block" const.
13117         (map_block): Make "block" const.
13118         * symfile.h (struct quick_symbol_functions)
13119         <map_matching_symbols>: Constify block argument to "callback".
13120         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
13121         const.
13122         (find_pc_sect_compunit_symtab): Make "b" const.
13123         (find_symbol_at_address): Likewise.
13124         (search_symbols): Likewise.
13125         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
13126         (dw2_debug_names_lookup_symbol): Likewise.
13127         (dw2_map_matching_symbols): Update.
13128         * p-valprint.c (pascal_val_print): Remove "block".
13129         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
13130         (aux_add_nonlocal_symbols): Make "block" const.
13131         (resolve_subexp): Remove cast.
13132         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
13133         const.
13134         (iterate_over_file_blocks): Likewise.
13135         * f-exp.y (%union) <bval>: Remove.
13136         * coffread.c (patch_opaque_types): Make "b" const.
13137         * spu-tdep.c (spu_catch_start): Make "block" const.
13138         * c-valprint.c (print_unpacked_pointer): Remove "block".
13139         * symmisc.c (dump_symtab_1): Make "b" const.
13140         (block_depth): Make "block" const.
13141         * d-exp.y (%union) <bval>: Remove.
13142         * cp-support.h (cp_lookup_rtti_type): Update.
13143         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
13144         * psymtab.c (psym_lookup_symbol): Make "block" const.
13145         (maintenance_check_psymtabs): Make "b" const.
13146         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
13147         (enumerate_locals, enumerate_args): Update.
13148         * python/py-symtab.c (stpy_global_block): Make "block" const.
13149         (stpy_static_block): Likewise.
13150         * inline-frame.c (block_starting_point_at): Make "new_block"
13151         const.
13152         * block.c (find_block_in_blockvector): Make return type const.
13153         (blockvector_for_pc_sect): Make "b" const.
13154         (find_block_in_blockvector): Make "b" const.
13155
13156 2019-03-23  Tom Tromey  <tom@tromey.com>
13157
13158         * varobj.c (varobj_create): Update.
13159         * symfile.c (clear_symtab_users): Don't reset innermost_block.
13160         * printcmd.c (display_command, do_one_display): Don't reset
13161         innermost_block.
13162         * parser-defs.h (enum innermost_block_tracker_type): Move to
13163         expression.h.
13164         (innermost_block): Update comment.
13165         * parse.c (parse_exp_1): Add tracker_types parameter.
13166         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
13167         tracker_types parameter.  Reset innermost_block.
13168         (parse_exp_in_context): Remove.
13169         (parse_expression_for_completion): Update.
13170         * objfiles.c (~objfile): Don't reset expression_context_block or
13171         innermost_block.
13172         * expression.h (enum innermost_block_tracker_type): Move from
13173         parser-defs.h.
13174         (parse_exp_1): Add tracker_types parameter.
13175         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
13176         reset innermost_block.
13177
13178 2019-03-23  Tom Tromey  <tom@tromey.com>
13179
13180         * objfiles.h: Include bcache.h.
13181
13182 2019-03-23  Tom Tromey  <tom@tromey.com>
13183
13184         * linespec.c (get_current_search_block): Use
13185         scoped_restore_current_language.
13186         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
13187
13188 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
13189             Jiong Wang  <jiong.wang@arm.com>
13190
13191         * aarch64-linux-tdep.c
13192         (aarch64_linux_iterate_over_regset_sections): Check for pauth
13193         section.
13194         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
13195
13196 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
13197             Jiong Wang  <jiong.wang@arm.com>
13198
13199         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
13200         instructions.
13201         (aarch64_analyze_prologue_test): Add PACIASP test.
13202         (aarch64_prologue_prev_register): Unmask PC value.
13203
13204 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
13205             Jiong Wang  <jiong.wang@arm.com>
13206
13207         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
13208         (aarch64_dwarf2_prev_register): Unmask PC value.
13209         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
13210         (aarch64_execute_dwarf_cfa_vendor_op): Check for
13211         DW_CFA_AARCH64_negate_ra_state.
13212         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
13213
13214 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
13215             Jiong Wang  <jiong.wang@arm.com>
13216
13217         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
13218         registers.
13219         (aarch64_pseudo_register_name): Likewise.
13220         (aarch64_pseudo_register_type): Likewise.
13221         (aarch64_pseudo_register_reggroup_p): Likewise.
13222         (aarch64_gdbarch_init): Add pauth registers.
13223         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
13224         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
13225         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
13226         (struct gdbarch_tdep): Add regnum for ra_state.
13227
13228 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
13229             Jiong Wang  <jiong.wang@arm.com>
13230
13231         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
13232
13233 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
13234             Jiong Wang  <jiong.wang@arm.com>
13235
13236         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
13237         function.
13238         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
13239         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
13240         (aarch64_gdbarch_init): Add puth registers.
13241         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
13242         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
13243         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
13244
13245 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
13246             Jiong Wang  <jiong.wang@arm.com>
13247
13248         * aarch64-linux-nat.c
13249         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
13250         * aarch64-linux-tdep.c
13251         (aarch64_linux_core_read_description): Likewise.
13252         (aarch64_linux_get_hwcap): New function.
13253         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
13254         (aarch64_linux_get_hwcap): New declaration.
13255
13256 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
13257             Jiong Wang  <jiong.wang@arm.com>
13258
13259         * aarch64-linux-nat.c
13260         (aarch64_linux_nat_target::read_description): Add pauth param.
13261         * aarch64-linux-tdep.c
13262         (aarch64_linux_core_read_description): Likewise.
13263         * aarch64-tdep.c (struct target_desc): Add in pauth.
13264         (aarch64_read_description): Add pauth param.
13265         (aarch64_gdbarch_init): Likewise.
13266         * aarch64-tdep.h (aarch64_read_description): Likewise.
13267         * arch/aarch64.c (aarch64_create_target_description): Likewise.
13268         * arch/aarch64.h (aarch64_create_target_description): Likewise.
13269         * features/Makefile: Add new files.
13270         * features/aarch64-pauth.c: New file.
13271         * features/aarch64-pauth.xml: New file.
13272
13273 2019-03-20  Tom Tromey  <tromey@adacore.com>
13274
13275         * infrun.c (handle_inferior_event): Rename from
13276         handle_inferior_event_1.  Create a scoped_value_mark.
13277         (handle_inferior_event): Remove.
13278
13279 2019-03-19  Tom Tromey  <tromey@adacore.com>
13280
13281         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
13282         * infrun.h (print_stop_event): Add "displays" parameter.
13283         * infrun.c (print_stop_event): Add "displays" parameter.
13284
13285 2019-03-19  Pedro Alves  <palves@redhat.com>
13286
13287         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
13288         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
13289         to -1.  Fix TABs vs spaces.
13290         (tui_ui_out::tui_ui_out): Don't initialize fields here.
13291         * tui/tui-out.h (tui_ui_out) Add intro comments.
13292         <m_line, m_start_of_line>: In-class initialize, and add describing
13293         comment.
13294
13295 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
13296
13297         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
13298         variable names.
13299         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
13300
13301 2019-03-18  Pedro Alves  <palves@redhat.com>
13302             Eli Zaretskii <eliz@gnu.org>
13303
13304         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
13305         m_line and m_start_of_line.
13306
13307 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
13308
13309         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
13310         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
13311         it returns a newline.  This fixes a regression in TU mode, whereby
13312         the next line is output on the same screen line as the user input.
13313
13314 2019-03-18  Tom Tromey  <tromey@adacore.com>
13315
13316         * minsyms.c (minimal_symbol_reader::install): Remove call to
13317         obstack_blank.
13318
13319 2019-03-18  Pedro Alves  <palves@redhat.com>
13320
13321         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
13322         New globals.
13323         (apply_style): New, factored out from ...
13324         (apply_ansi_escape): ... this.  Handle reverse video mode.
13325         (tui_set_reverse_mode): New function.
13326         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
13327         * tui/tui-winsource.c (tui_show_source_line): Use
13328         tui_set_reverse_mode instead of setting A_STANDOUT.
13329         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
13330         New setter methods.
13331
13332 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
13333
13334         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
13335         Handle tabs.
13336
13337 2019-03-18  Tom Tromey  <tromey@adacore.com>
13338
13339         * ada-lang.c (empty_array): Add "high" parameter.
13340         (ada_evaluate_subexp): Update.
13341
13342 2019-03-17  Sergei Trofimovich <siarheit@google.com>
13343
13344         * unittests/string_view-selftests.c: Define
13345         _initialize_string_view_selftests unconditionally.
13346
13347 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
13348
13349         PR gdb/24350
13350         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
13351
13352 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
13353
13354         PR gdb/24351
13355         * windows-nat.c (display_selector): Fix format specifiers.
13356
13357 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
13358
13359         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
13360         tui_refill_source_window instead of tui_refresh_win, to update the
13361         current execution line.  This fixes redisplay of the current line
13362         when stepping through the code with "next" or "step".
13363
13364 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
13365
13366         * source-cache.c (source_cache::get_source_lines): Call
13367         find_source_lines to initialize s->nlines.  This fixes vertical
13368         scrolling of TUI source window when the DOWN arrow is pressed.
13369
13370 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13371
13372         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
13373         linux-thread-db.c (_initialize_thread_db): Likewise.
13374
13375 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
13376
13377         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
13378         wclrtoeol in tui_show_source_line".  This reverts changes made in
13379         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
13380
13381 2019-03-15  Tom Tromey  <tom@tromey.com>
13382
13383         * symtab.h (struct minimal_symbol): Derive from
13384         general_symbol_info.
13385         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
13386         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
13387         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
13388         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
13389         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
13390         (MSYMBOL_SEARCH_NAME): Update.
13391         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
13392         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
13393         * minsyms.c (minimal_symbol_reader::record_full): Update.
13394
13395 2019-03-15  Tom Tromey  <tom@tromey.com>
13396
13397         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
13398
13399 2019-03-15  Tom Tromey  <tom@tromey.com>
13400
13401         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
13402         unique_xmalloc_ptr.
13403         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
13404         Update.
13405         * minsyms.c (lookup_minimal_symbol_by_pc_section)
13406         (build_minimal_symbol_hash_tables)
13407         (minimal_symbol_reader::install): Update.
13408
13409 2019-03-15  Tom Tromey  <tom@tromey.com>
13410
13411         * symtab.c (create_demangled_names_hash): Update.
13412         (symbol_set_names): Update.
13413         * objfiles.h (struct objfile_per_bfd_storage)
13414         <demangled_names_hash>: Now an htab_up.
13415         * objfiles.c (objfile_per_bfd_storage): Simplify.
13416
13417 2019-03-15  Tom Tromey  <tom@tromey.com>
13418
13419         * objfiles.h (struct objfile_per_bfd_storage): Declare
13420         destructor.
13421         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
13422         New.
13423         (get_objfile_bfd_data): Use new.  Don't initialize
13424         language_of_main.
13425         (free_objfile_per_bfd_storage): Remove.
13426         (objfile_bfd_data_free, objfile::~objfile): Use delete.
13427
13428 2019-03-15  Tom Tromey  <tom@tromey.com>
13429
13430         * symfile.c (reread_symbols): Update.
13431         * objfiles.c (objfile::objfile): Update.
13432         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
13433         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
13434         comment.
13435         (minimal_symbol_reader::install): Update.
13436         (terminate_minimal_symbol_table): Remove.
13437         * jit.c (jit_object_close_impl): Update.
13438
13439 2019-03-15  Tom Tromey  <tom@tromey.com>
13440
13441         * minsyms.c (minimal_symbol_reader::record_full): Remove some
13442         initializations.
13443
13444 2019-03-15  Tom Tromey  <tom@tromey.com>
13445
13446         * objfiles.h (struct objfile_per_bfd_storage)
13447         <demangled_hash_languages>: Now a bitset.
13448         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
13449         (lookup_minimal_symbol): Update.
13450
13451 2019-03-15  Tom Tromey  <tom@tromey.com>
13452
13453         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
13454         Don't return the symbol.
13455         * coffread.c (record_minimal_symbol): Use record_full.
13456
13457 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
13458
13459         The MS-Windows port of ncurses fails to switch to a color pair if
13460         one or both of the colors are the implicit default colors.  This
13461         change records the default colors when TUI is initialized, and
13462         then specifies them explicitly when a color pair uses the default
13463         colors.  This allows color styling in TUI mode on MS-Windows.
13464
13465         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
13466         ncurses_norm_attr.
13467         (tui_initialize_io) [__MINGW32__]: Record the default terminal
13468         colors in ncurses_norm_attr.
13469         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
13470         "none", replace it with the default color recorded in
13471         ncurses_norm_attr.
13472
13473 2019-03-14  Tom Tromey  <tromey@adacore.com>
13474
13475         * source-cache.h (class source_cache) <get_source_lines>: Return
13476         std::string.
13477         * source-cache.c (source_cache::extract_lines): Handle case where
13478         first_pos==npos.  Return std::string.
13479         (source_cache::get_source_lines): Update.
13480
13481 2019-03-14  Tom Tromey  <tromey@adacore.com>
13482
13483         * NEWS: Add item for "style sources" commands.
13484         * source-cache.c (source_cache::get_source_lines): Check
13485         source_styling.
13486         * cli/cli-style.c (source_styling): New global.
13487         (_initialize_cli_style): Add "style sources" commands.
13488         (show_style_sources): New function.
13489         * cli/cli-style.h (source_styling): Declare.
13490
13491 2019-03-14  Pedro Alves  <palves@redhat.com>
13492             Tom Tromey  <tromey@adacore.com>
13493
13494         * tui/tui-winsource.h (tui_refill_source_window): Declare.
13495         * tui/tui-winsource.c (tui_refill_source_window): New function,
13496         from...
13497         (tui_horizontal_source_scroll): ... here.  Move some logic.
13498         * cli/cli-style.c (set_style_enabled): Notify new observable.
13499         * tui/tui-hooks.c (tui_redisplay_source): New function.
13500         (tui_attach_detach_observers): Attach or detach
13501         tui_redisplay_source.
13502         * observable.h (source_styling_changed): New observable.
13503         * observable.c: Define source_styling_changed observable.
13504
13505 2019-03-13  Tom Tromey  <tromey@adacore.com>
13506
13507         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
13508         (i386_gnu_nat_target::store_registers): Update.
13509         * target-debug.h (target_debug_print_std_string): New macro.
13510         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
13511         * windows-tdep.c (display_one_tib): Update.
13512         * tui/tui-stack.c (tui_make_status_line): Update.
13513         * top.c (print_inferior_quit_action): Update.
13514         * thread.c (thr_try_catch_cmd): Update.
13515         (add_thread_with_info): Update.
13516         (thread_target_id_str): Update.
13517         (thr_try_catch_cmd): Update.
13518         (thread_command): Update.
13519         (thread_find_command): Update.
13520         * record-btrace.c (record_btrace_target::info_record)
13521         (record_btrace_resume_thread, record_btrace_target::resume)
13522         (record_btrace_cancel_resume, record_btrace_step_thread)
13523         (record_btrace_target::wait, record_btrace_target::wait)
13524         (record_btrace_target::wait, record_btrace_target::stop): Update.
13525         * progspace.c (print_program_space): Update.
13526         * process-stratum-target.c
13527         (process_stratum_target::thread_address_space): Update.
13528         * linux-fork.c (linux_fork_mourn_inferior)
13529         (detach_checkpoint_command, info_checkpoints_command)
13530         (linux_fork_context): Update.
13531         (linux_fork_detach): Update.
13532         (class scoped_switch_fork_info): Update.
13533         (delete_checkpoint_command): Update.
13534         * infrun.c (follow_fork_inferior): Update.
13535         (follow_fork_inferior): Update.
13536         (proceed_after_vfork_done): Update.
13537         (handle_vfork_child_exec_or_exit): Update.
13538         (follow_exec): Update.
13539         (displaced_step_prepare_throw): Update.
13540         (displaced_step_restore): Update.
13541         (start_step_over): Update.
13542         (resume_1): Update.
13543         (clear_proceed_status_thread): Update.
13544         (proceed): Update.
13545         (print_target_wait_results): Update.
13546         (do_target_wait): Update.
13547         (context_switch): Update.
13548         (stop_all_threads): Update.
13549         (restart_threads): Update.
13550         (finish_step_over): Update.
13551         (handle_signal_stop): Update.
13552         (switch_back_to_stepped_thread): Update.
13553         (keep_going_pass_signal): Update.
13554         (print_exited_reason): Update.
13555         (normal_stop): Update.
13556         * inferior.c (inferior_pid_to_str): Change return type.
13557         (print_selected_inferior): Update.
13558         (add_inferior): Update.
13559         (detach_inferior): Update.
13560         * dummy-frame.c (fprint_dummy_frames): Update.
13561         * dcache.c (dcache_info_1): Update.
13562         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
13563         (btrace_fetch, btrace_clear): Update.
13564         * linux-tdep.c (linux_core_pid_to_str): Change return type.
13565         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
13566         type.
13567         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
13568         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
13569         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
13570         * gdbarch.c, gdbarch.h: Rebuild.
13571         * gdbarch.sh (core_pid_to_str): Change return type.
13572         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
13573         return type.
13574         (windows_nat_target::pid_to_str): Change return type.
13575         (windows_delete_thread): Update.
13576         (windows_nat_target::attach): Update.
13577         (windows_nat_target::files_info): Update.
13578         * target-delegates.c: Rebuild.
13579         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
13580         return type.
13581         (sol_thread_target::pid_to_str): Change return type.
13582         * remote.c (class remote_target) <pid_to_str>: Change return
13583         type.
13584         (remote_target::pid_to_str): Change return type.
13585         (extended_remote_target::attach, remote_target::remote_stop_ns)
13586         (remote_target::remote_notif_remove_queued_reply)
13587         (remote_target::push_stop_reply, remote_target::disable_btrace):
13588         Update.
13589         (extended_remote_target::attach): Update.
13590         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
13591         type.
13592         (gdbsim_target::pid_to_str): Change return type.
13593         * ravenscar-thread.c (struct ravenscar_thread_target)
13594         <pid_to_str>: Change return type.
13595         (ravenscar_thread_target::pid_to_str): Change return type.
13596         * procfs.c (class procfs_target) <pid_to_str>: Change return
13597         type.
13598         (procfs_target::pid_to_str): Change return type.
13599         (procfs_target::attach): Update.
13600         (procfs_target::detach): Update.
13601         (procfs_target::fetch_registers): Update.
13602         (procfs_target::store_registers): Update.
13603         (procfs_target::wait): Update.
13604         (procfs_target::files_info): Update.
13605         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
13606         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
13607         return type.
13608         (nto_procfs_target::pid_to_str): Change return type.
13609         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
13610         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
13611         return type.
13612         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
13613         (exit_lwp): Update.
13614         (attach_proc_task_lwp_callback, get_detach_signal)
13615         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
13616         (linux_nat_target::resume, wait_lwp, stop_callback)
13617         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
13618         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
13619         (linux_nat_wait_1, resume_stopped_resumed_lwps)
13620         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
13621         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
13622         type.
13623         (inf_ptrace_target::attach): Update.
13624         (inf_ptrace_target::files_info): Update.
13625         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
13626         type.
13627         (go32_nat_target::pid_to_str): Change return type.
13628         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
13629         (gnu_nat_target::wait): Update.
13630         (gnu_nat_target::wait): Update.
13631         (gnu_nat_target::resume): Update.
13632         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
13633         (fbsd_nat_target::wait): Update.
13634         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
13635         type.
13636         (darwin_nat_target::attach): Update.
13637         * corelow.c (class core_target) <pid_to_str>: Change return type.
13638         (core_target::pid_to_str): Change return type.
13639         * target.c (normal_pid_to_str): Change return type.
13640         (default_pid_to_str): Likewise.
13641         (target_pid_to_str): Change return type.
13642         (target_translate_tls_address): Update.
13643         (target_announce_detach): Update.
13644         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
13645         return type.
13646         (bsd_uthread_target::pid_to_str): Change return type.
13647         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
13648         type.
13649         (bsd_kvm_target::pid_to_str): Change return type.
13650         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
13651         return type.
13652         (aix_thread_target::pid_to_str): Change return type.
13653         * target.h (struct target_ops) <pid_to_str>: Change return type.
13654         (target_pid_to_str, normal_pid_to_str): Likewise.
13655         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
13656         type.
13657         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
13658         type.
13659         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
13660         return type.
13661         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
13662         type.
13663         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
13664         type.
13665         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
13666         return type.
13667
13668 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
13669
13670         * NEWS: Mention that the new default MI version is 3.  Mention
13671         changes to the output of commands and events that deal with
13672         multi-location breakpoints.
13673         * breakpoint.c: Include "mi/mi-out.h".
13674         (print_one_breakpoint): Change output syntax if using MI version
13675         >= 3.
13676         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
13677         New.
13678         (mi_multi_location_breakpoint_output_fixed): New.
13679         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
13680         (mi_cmd_fix_multi_location_breakpoint_output): New.
13681         (mi_multi_location_breakpoint_output_fixed): New.
13682         * mi/mi-cmds.c (mi_cmds): Register command
13683         -fix-multi-location-breakpoint-output.
13684         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
13685         interpreter "mi".
13686
13687 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
13688
13689         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
13690         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
13691         instantiate mi_ui_out based on interpreter name.
13692         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
13693         * mi/mi-main.c (mi_load_progress): Likewise.
13694
13695 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13696
13697         * NEWS: Combine separate "New targets" sections for 8.3.
13698
13699 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13700
13701         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
13702         (ppcfbsd_init_abi): Install gdbarch
13703         "fetch_tls_load_module_address" and "get_thread_local_address"
13704         methods.
13705
13706 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13707
13708         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
13709         (riscv_fbsd_init_abi): Install gdbarch
13710         "fetch_tls_load_module_address" and "get_thread_local_address"
13711         methods.
13712
13713 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13714
13715         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
13716         (i386fbsd_init_abi): Install gdbarch
13717         "fetch_tls_load_module_address" and "get_thread_local_address"
13718         methods.
13719
13720 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13721
13722         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
13723         (amd64fbsd_init_abi): Install gdbarch
13724         "fetch_tls_load_module_address" and "get_thread_local_address"
13725         methods.
13726
13727 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13728
13729         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
13730         (struct fbsd_pspace_data): New type.
13731         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
13732         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
13733         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
13734         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
13735         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
13736
13737 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13738
13739         * gdbtypes.c (lookup_struct_elt): New function.
13740         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
13741         * gdbtypes.h (struct struct_elt): New type.
13742         (lookup_struct_elt): New prototype.
13743
13744 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13745
13746         * gdbtypes.c (lookup_struct_elt_type): Update comment and
13747         remove disabled code block.
13748
13749 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13750
13751         * gdbarch.sh (get_thread_local_address): New method.
13752         * gdbarch.h, gdbarch.c: Regenerate.
13753         * target.c (target_translate_tls_address): Use
13754         gdbarch_get_thread_local_address if present instead of
13755         target::get_thread_local_address.
13756
13757 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13758
13759         * target.h (target::get_thread_local_address): Update comment.
13760
13761 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13762
13763         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
13764         objfile->separate_debug_objfile_backlink if not NULL.
13765
13766 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13767
13768         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
13769         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
13770         (amd64bsd_store_inferior_registers): Likewise.
13771         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
13772         Enable segment base registers.
13773         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
13774         PT_GETFSBASE and PT_GETGSBASE.
13775         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
13776         PT_SETGSBASE.
13777         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
13778         segment base registers.
13779         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
13780
13781 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13782
13783         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
13784         Update calls to i386_target_description to add 'segments'
13785         parameter.
13786         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
13787         add segment base registers.
13788         * arch/i386.c (i386_create_target_description): Add 'segments'
13789         parameter to enable segment base registers.
13790         * arch/i386.h (i386_create_target_description): Likewise.
13791         * features/i386/32bit-segments.xml: New file.
13792         * features/i386/32bit-segments.c: Generate.
13793         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
13794         call to i386_target_description to add 'segments' parameter.
13795         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
13796         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
13797         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
13798         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
13799         if feature is present.
13800         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
13801         Add 'segments' parameter to call to i386_target_description.
13802         (i386_target_description): Add 'segments' parameter to enable
13803         segment base registers.
13804         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
13805         to call to i386_target_description.
13806         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
13807         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
13808         Define I386_NUM_REGS.
13809         (i386_target_description): Add 'segments' parameter to enable
13810         segment base registers.
13811
13812 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
13813
13814         PR/24325
13815         * source-cache.c: #undef open and close, to avoid unresolved
13816         externals during linking.
13817
13818 2019-03-12  Tom Tromey  <tromey@adacore.com>
13819
13820         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
13821         const.  Add initializers.
13822         (_initialize_remote): Don't initialize ptid globals.
13823
13824 2019-03-12  Pedro Alves  <palves@redhat.com>
13825
13826         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
13827
13828 2019-03-12  Pedro Alves  <palves@redhat.com>
13829
13830         * cp-name-parser.y (main): Remove unused 'len' variable.
13831
13832 2019-03-12  Tom Tromey  <tromey@adacore.com>
13833
13834         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
13835         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
13836
13837 2019-03-12  Tom Tromey  <tromey@adacore.com>
13838
13839         * linux-nat.c (iterate_over_lwps): Update.
13840         (stop_callback): Remove parameter.
13841         (stop_wait_callback, detach_callback, resume_set_callback)
13842         (select_singlestep_lwp_callback, set_ignore_sigint)
13843         (status_callback, resumed_callback, resume_clear_callback)
13844         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
13845         data parameter.
13846         (linux_nat_target::detach, linux_nat_target::resume)
13847         (linux_stop_and_wait_all_lwps, select_event_lwp)
13848         (linux_nat_filter_event, linux_nat_wait_1)
13849         (linux_nat_target::kill, linux_nat_target::stop)
13850         (linux_nat_target::stop): Update.
13851         (linux_nat_resume_callback): Change type.
13852         (resume_stopped_resumed_lwps, count_events_callback)
13853         (select_event_lwp_callback): Likewise.
13854         (linux_stop_lwp, linux_nat_stop_lwp): Update.
13855         * arm-linux-nat.c (struct update_registers_data): Remove.
13856         (update_registers_callback): Change type.
13857         (arm_linux_insert_hw_breakpoint1): Update.
13858         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
13859         parameter.
13860         (x86_linux_dr_set_addr): Update.
13861         (x86_linux_dr_set_control): Update.
13862         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
13863         (iterate_over_lwps): Use gdb::function_view.
13864         * nat/aarch64-linux-hw-point.c (struct
13865         aarch64_dr_update_callback_param): Remove.
13866         (debug_reg_change_callback): Change type.
13867         (aarch64_notify_debug_reg_change): Update.
13868         * s390-linux-nat.c (s390_refresh_per_info): Update.
13869
13870 2019-03-11  Tom Tromey  <tromey@adacore.com>
13871
13872         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
13873         redundant assignment to "this_cu".
13874
13875 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13876
13877         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
13878
13879 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13880
13881         * gdbtypes.c (rank_one_type_parm_set): New function extracted
13882         from...
13883         (rank_one_type): ... this.
13884
13885 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13886
13887         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
13888         from...
13889         (rank_one_type): ... this.
13890
13891 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13892
13893         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
13894         from...
13895         (rank_one_type): ... this.
13896
13897 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13898
13899         * gdbtypes.c (rank_one_type_parm_float): New function extracted
13900         from...
13901         (rank_one_type): ... this.
13902
13903 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13904
13905         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
13906         from...
13907         (rank_one_type): ... this.
13908
13909 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13910
13911         * gdbtypes.c (rank_one_type_parm_range): New function extracted
13912         from...
13913         (rank_one_type): ... this.
13914
13915 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13916
13917         * gdbtypes.c (rank_one_type_parm_char): New function extracted
13918         from...
13919         (rank_one_type): ... this.
13920
13921 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13922
13923         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
13924         from...
13925         (rank_one_type): ... this.
13926
13927 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13928
13929         * gdbtypes.c (rank_one_type_parm_int): New function extracted
13930         from...
13931         (rank_one_type): ... this.
13932
13933 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13934
13935         * gdbtypes.c (rank_one_type_parm_func): New function extracted
13936         from...
13937         (rank_one_type): ... this.
13938
13939 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13940
13941         * gdbtypes.c (rank_one_type_parm_array): New function extracted
13942         from...
13943         (rank_one_type): ... this.
13944
13945 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13946
13947         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
13948         from...
13949         (rank_one_type): ... this.
13950
13951 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13952
13953         * inferior.c (initialize_inferiors): Ensure 'help set/show print
13954         inferior-events' shows the example events.
13955
13956 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
13957
13958         Support styling on native MS-Windows console
13959
13960         PR/24315
13961         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
13962         on MS-Windows if $TERM is not defined.
13963
13964         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
13965
13966         * posix-hdep.c (gdb_console_fputs):
13967         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
13968         functions.
13969         * ui-file.h (gdb_console_fputs): Add prototype.
13970
13971         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
13972         back to fputs only if the former returns zero.
13973
13974 2019-03-07  Tom Tromey  <tom@tromey.com>
13975
13976         * symmisc.c (print_symbol_bcache_statistics): Update.
13977         (print_objfile_statistics): Update.
13978         * symfile.c (allocate_symtab): Update.
13979         * stabsread.c: Don't include bcache.h.
13980         * psymtab.h (struct psymbol_bcache): Don't declare.
13981         (class psymtab_storage) <psymbol_cache>: Now a bcache.
13982         (psymbol_bcache_init, psymbol_bcache_free)
13983         (psymbol_bcache_get_bcache): Don't declare.
13984         * psymtab.c (struct psymbol_bcache): Remove.
13985         (psymtab_storage::psymtab_storage): Update.
13986         (psymtab_storage::~psymtab_storage): Update.
13987         (psymbol_bcache_init, psymbol_bcache_free)
13988         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
13989         (add_psymbol_to_bcache): Update.
13990         (allocate_psymtab): Update.
13991         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
13992         macro_cache>: No longer pointers.
13993         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
13994         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
13995         * macrotab.c (macro_bcache): Update.
13996         * macroexp.c: Don't include bcache.h.
13997         * gdbtypes.c (check_types_worklist): Update.
13998         (types_deeply_equal): Remove TRY/CATCH.  Update.
13999         * elfread.c (elf_symtab_read): Update.
14000         * dwarf2read.c: Don't include bcache.h.
14001         * buildsym.c (buildsym_compunit::get_macro_table): Update.
14002         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
14003         (print_bcache_statistics, bcache_memory_used): Don't declare.
14004         (struct bcache): Move from bcache.c.  Add constructor, destructor,
14005         methods.  Rename all data members.
14006         * bcache.c (struct bcache): Move to bcache.h.
14007         (bcache::expand_hash_table): Rename from expand_hash_table.
14008         (bcache): Remove.
14009         (bcache::insert): Rename from bcache_full.
14010         (bcache::compare): Rename from bcache_compare.
14011         (bcache_xmalloc): Remove.
14012         (bcache::~bcache): Rename from bcache_xfree.
14013         (bcache::print_statistics): Rename from print_bcache_statistics.
14014         (bcache::memory_used): Rename from bcache_memory_used.
14015
14016 2019-03-07  Pedro Alves  <palves@redhat.com>
14017
14018         * infrun.c (normal_stop): Also check for
14019         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
14020
14021 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
14022
14023         * f-lang.c (value_from_host_double): Moved to...
14024         * value.c (value_from_host_double): ...here.
14025         * value.h (value_from_host_double): Declare.
14026         * guile/scm-math.c (vlscm_convert_typed_number): Use
14027         value_from_host_double.
14028         (vlscm_convert_number): Likewise.
14029         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
14030         * python/py-value.c (convert_value_from_python): Likewise.
14031
14032 2019-03-06  Tom Tromey  <tom@tromey.com>
14033
14034         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
14035
14036 2019-03-06  Tom Tromey  <tom@tromey.com>
14037
14038         * utils.h (free_current_contents): Don't declare.
14039         * utils.c (free_current_contents): Remove.
14040
14041 2019-03-06  Tom Tromey  <tom@tromey.com>
14042
14043         * top.c (quit_force): Update.
14044         * main.c (captured_command_loop): Update.
14045         * common/new-op.c (operator new): Update.
14046         * common/common-exceptions.c (struct catcher)
14047         <save_cleanup_chain>: Remove member.
14048         (exceptions_state_mc_init): Update.
14049         (exception_try_scope_entry): Return nullptr.
14050         (exception_try_scope_exit, exception_rethrow)
14051         (throw_exception_sjlj, throw_exception_cxx): Update.
14052         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
14053         (all_cleanups, do_cleanups, discard_cleanups)
14054         (discard_final_cleanups, save_cleanups, save_final_cleanups)
14055         (restore_cleanups, restore_final_cleanups): Don't declare.
14056         (do_final_cleanups): Remove parameter.
14057         * common/cleanups.c (cleanup_chain, make_cleanup)
14058         (make_cleanup_dtor, all_cleanups, do_cleanups)
14059         (discard_my_cleanups, discard_cleanups)
14060         (discard_final_cleanups, save_my_cleanups, save_cleanups)
14061         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
14062         (null_cleanup): Remove.
14063         (do_final_cleanups): Remove parameter.
14064
14065 2019-03-06  Tom Tromey  <tom@tromey.com>
14066
14067         * remote.c (remote_target::remote_parse_stop_reply): Use
14068         unique_xmalloc_ptr.
14069
14070 2019-03-06  Tom Tromey  <tom@tromey.com>
14071
14072         * stabsread.c (struct stabs_field_info): Rename from field_info.
14073         <list, fnlist>: Add initializers.
14074         <obstack>: New member.
14075         (read_member_functions, read_struct_fields, read_baseclasses):
14076         Allocate on obstack.  Don't use cleanups.
14077         (read_one_struct_field, read_member_functions, read_struct_fields)
14078         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
14079         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
14080         (read_struct_type): Update.
14081
14082 2019-03-06  Tom Tromey  <tom@tromey.com>
14083
14084         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
14085         * common/filestuff.h (make_cleanup_close): Don't declare.
14086         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
14087         Remove.
14088
14089 2019-03-06  Tom Tromey  <tom@tromey.com>
14090
14091         * solib-aix.c: Use make_scope_exit.
14092
14093 2019-03-06  Tom Tromey  <tom@tromey.com>
14094
14095         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
14096         Use make_scope_exit.
14097
14098 2019-03-06  Tom Tromey  <tom@tromey.com>
14099
14100         * solib-svr4.c (disable_probes_interface): Remove parameter.
14101         (svr4_handle_solib_event): Use make_scope_exit.
14102
14103 2019-03-06  Tom Tromey  <tom@tromey.com>
14104
14105         * remote.c (struct stop_reply_deleter): Remove.
14106         (stop_reply_up): Update.
14107         (struct stop_reply): Derive from notif_event.  Don't typedef.
14108         <regcache>: Now a std::vector.
14109         (stop_reply_xfree): Remove.
14110         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
14111         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
14112         (remote_target::discard_pending_stop_replies): Use delete.
14113         (remote_target::remote_parse_stop_reply): Update.
14114         (remote_target::process_stop_reply): Update.
14115         * remote-notif.h (struct notif_event): Add virtual destructor.
14116         Remove "dtr" member.
14117         (struct notif_client) <alloc_event>: Return a unique_ptr.
14118         (notif_event_xfree): Don't declare.
14119         (notif_event_up): New typedef.
14120         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
14121         (notif_event_xfree, do_notif_event_xfree): Remove.
14122         (remote_notif_state_xfree): Update.
14123
14124 2019-03-06  Tom Tromey  <tom@tromey.com>
14125
14126         * infrun.c (displaced_step_clear_cleanup): Now a
14127         forward_scope_exit type.
14128         (displaced_step_prepare_throw): Update.
14129         (displaced_step_fixup): Update.
14130
14131 2019-03-06  Tom Tromey  <tom@tromey.com>
14132
14133         * inferior.h (class inferior): Update comment.
14134         * gdbthread.h (class thread_info): Update comment.
14135
14136 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
14137             Tom Tromey  <tom@tromey.com>
14138
14139         * stabsread.h (struct stab_section_list): Remove.
14140         (coffstab_build_psymtabs): Update.
14141         * dbxread.c (symbuf_sections): Now a std::vector.
14142         (sect_idx): New global.
14143         (fill_symbuf): Update.
14144         (coffstab_build_psymtabs): Change type of stabsects parameter.
14145         Update.
14146         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
14147         std::vector.
14148         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
14149         (coff_locate_sections): Update.
14150         (coff_symfile_read): Remove cleanups.  Update.
14151         (init_stringtab): Add storage parameter.
14152         (free_stringtab, free_stringtab_cleanup): Remove.
14153         (init_lineno): Add storage parameter.
14154         (free_linetab, free_linetab_cleanup): Remove.
14155
14156 2019-03-06  Pedro Alves  <palves@redhat.com>
14157
14158         * linux-fork.c (fork_info::clobber_regs): Delete.
14159         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
14160         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
14161         comment.  Adjust.
14162         (scoped_switch_fork_info::scoped_switch_fork_info)
14163         (checkpoint_command, linux_fork_context): Adjust
14164         fork_save_infrun_state calls.
14165
14166 2019-03-06  Pedro Alves  <palves@redhat.com>
14167
14168         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
14169         (inf_has_multiple_threads): Return 'bool' and rewrite using
14170         inferior_info::threads().
14171
14172 2019-03-06  Pedro Alves  <palves@redhat.com>
14173
14174         * linux-fork.c: Include <list>.
14175         (fork_list): Now a std::list instance.
14176         (fork_info): Add ctor, dtor, and in-class initialize all fields.
14177         (forks_exist_p, find_last_fork): Adjust.
14178         (new_fork): Delete.
14179         (one_fork_p): New.
14180         (add_fork): Adjust.
14181         (free_fork): Delete, folded into fork_info::~fork_info().
14182         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
14183         Adjust.
14184         (init_fork_list): Delete.
14185         (linux_fork_killall, linux_fork_mourn_inferior)
14186         (linux_fork_detach, info_checkpoints_command): Adjust.
14187         (_initialize_linux_fork): No longer call init_fork_list.
14188
14189 2019-03-06  Pedro Alves  <palves@redhat.com>
14190
14191         * linux-fork.c (new_fork): New, split out of ...
14192         (add_fork): ... this.  Return void.  Move "first fork" special
14193         case from here, to ...
14194         (checkpoint_command): ... here.
14195         * linux-linux.h (add_fork): Return void.
14196
14197 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
14198
14199         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
14200
14201 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
14202             Chris January  <chris.january@arm.com>
14203             David Lecomber  <david.lecomber@arm.com>
14204
14205         * f-exp.y: New token, UNOP_INTRINSIC.
14206         (exp): New pattern using UNOP_INTRINSIC token.
14207         (f77_keywords): Add 'abs' keyword.
14208         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
14209         (value_from_host_double): New function.
14210         (evaluate_subexp_f): Support UNOP_ABS.
14211
14212 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
14213
14214         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
14215         types.
14216
14217 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
14218
14219         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
14220         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
14221         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
14222
14223 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
14224
14225         * f-exp.y (convert_to_kind_type): Handle more type kinds.
14226
14227 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
14228             Chris January  <chris.january@arm.com>
14229
14230         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
14231         * f-exp.y: Define 'KIND' token.
14232         (exp): New pattern for KIND expressions.
14233         (ptype): Handle types with a kind extension.
14234         (direct_abs_decl): Extend to spot kind extensions.
14235         (f77_keywords): Add 'kind' to the list.
14236         (push_kind_type): New function.
14237         (convert_to_kind_type): New function.
14238         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
14239         * parse.c (operator_length_standard): Likewise.
14240         * parser-defs.h (enum type_pieces): Add tp_kind.
14241         * std-operator.def: Add UNOP_KIND.
14242
14243 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
14244
14245         * f-exp.y (f_parse): Set yydebug.
14246
14247 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
14248
14249         * f-lang.c (evaluate_subexp_f): New function.
14250         (exp_descriptor_f): New global.
14251         (f_language_defn): Use exp_descriptor_f instead of
14252         exp_descriptor_standard.
14253
14254 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
14255
14256         * f-exp.y (struct token): Add comments.
14257         (dot_ops): Remove uppercase versions and the end marker.
14258         (f77_keywords): Likewise.
14259         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
14260         entries in the dot_ops array are case insensitive, and use
14261         strncasecmp to compare strings.  Also some whitespace cleanup in
14262         this area.  Similar for the f77_keywords array, except entries in
14263         this list might be case sensitive.
14264
14265 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
14266
14267         * f-exp.y (struct f77_boolean_val): Add comments.
14268         (boolean_values): Remove uppercase versions, and end marker.
14269         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
14270         and use strncasecmp to achieve case insensitivity.  Additionally,
14271         perform whitespace cleanup around this code.
14272
14273 2019-03-06  Tom Tromey  <tromey@adacore.com>
14274
14275         * remote-sim.c (gdbsim_target_open): Use result of
14276         gdb_argv::release.
14277
14278 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
14279         Dirk Schubert  <dirk.schubert@arm.com>
14280         Chris January  <chris.january@arm.com>
14281
14282         * eval.c (evaluate_subexp_standard): Call Fortran argument
14283         wrapping logic.
14284         * f-lang.c (struct value): A value which can be passed into a
14285         Fortran function call.
14286         (fortran_argument_convert): Wrap Fortran arguments in a pointer
14287         where appropriate.
14288         (struct type): Value ready for a Fortran function call.
14289         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
14290         is needed.
14291         * f-lang.h (fortran_argument_convert): Declaration.
14292         (fortran_preserve_arg_pointer): Declaration.
14293         * infcall.c (value_arg_coerce): Call Fortran argument logic.
14294
14295 2019-03-05  Tom Tromey  <tromey@adacore.com>
14296
14297         * python/py-prettyprint.c (print_string_repr): Remove #if.
14298         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
14299
14300 2019-03-05  Tom Tromey  <tromey@adacore.com>
14301
14302         * target.c (the_dummy_target): Move later.  Change type to
14303         "dummy_target".
14304         (initialize_targets): Don't initialize the_dummy_target.
14305
14306 2019-03-05  Tom Tromey  <tromey@adacore.com>
14307
14308         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
14309         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
14310
14311 2019-03-05  Tom Tromey  <tromey@adacore.com>
14312
14313         * windows-nat.c (windows_nat_target::attach)
14314         (windows_nat_target::detach): Don't call gdb_flush.
14315         * valprint.c (generic_val_print, val_print, val_print_string):
14316         Don't call gdb_flush.
14317         * utils.c (defaulted_query): Don't call gdb_flush.
14318         * typeprint.c (print_type_scalar): Don't call gdb_flush.
14319         * target.c (target_announce_detach): Don't call gdb_flush.
14320         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
14321         * remote.c (extended_remote_target::attach): Don't call
14322         gdb_flush.
14323         * procfs.c (procfs_target::detach): Don't call gdb_flush.
14324         * printcmd.c (do_examine): Don't call gdb_flush.
14325         (info_display_command): Don't call gdb_flush.
14326         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
14327         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
14328         * memattr.c (info_mem_command): Don't call gdb_flush.
14329         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
14330         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
14331         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
14332         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
14333         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
14334         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
14335         (gnu_nat_target::detach): Don't call gdb_flush.
14336         * f-valprint.c (f_val_print): Don't call gdb_flush.
14337         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
14338         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
14339         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
14340         gdb_flush.
14341         * c-valprint.c (c_val_print): Don't call gdb_flush.
14342         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
14343
14344 2019-03-05  Tom Tromey  <tromey@adacore.com>
14345
14346         * varobj.c (update_dynamic_varobj_children): Update.
14347         (install_default_visualizer): Use reset, not release.
14348         * value.c (set_internalvar): Update.
14349         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
14350         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
14351         ATTRIBUTE_UNUSED_RESULT.
14352
14353 2019-03-05  Tom Tromey  <tromey@adacore.com>
14354
14355         * remote.c (class scoped_remote_fd) <release>: Add
14356         ATTRIBUTE_UNUSED_RESULT.
14357
14358 2019-03-05  Tom Tromey  <tromey@adacore.com>
14359
14360         * macroexp.c (struct macro_buffer) <release>: Add
14361         ATTRIBUTE_UNUSED_RESULT.
14362
14363 2019-03-05  Tom Tromey  <tromey@adacore.com>
14364
14365         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
14366         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
14367         ATTRIBUTE_UNUSED_RESULT.
14368
14369 2019-03-05  Tom Tromey  <tromey@adacore.com>
14370
14371         * common/scoped_fd.h (class scoped_fd) <release>: Add
14372         ATTRIBUTE_UNUSED_RESULT.
14373
14374 2019-03-05  Tom Tromey  <tromey@adacore.com>
14375
14376         * parser-defs.h (struct parser_state) <release>: Add
14377         ATTRIBUTE_UNUSED_RESULT.
14378
14379 2019-03-05  Tom Tromey  <tromey@adacore.com>
14380
14381         * utils.h (class gdb_argv) <release>: Add
14382         ATTRIBUTE_UNUSED_RESULT.
14383         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
14384
14385 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
14386
14387         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
14388         for-loop range, to avoid compiler warnings.
14389
14390         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
14391         avoid compiler warnings about unused variables.
14392
14393         * NEWS: Mention end of support for native debugging on MS-Windows
14394         before XP.
14395
14396         PR gdb/24292
14397         * common/netstuff.c:
14398         * gdbserver/gdbreplay.c
14399         * gdbserver/remote-utils.c:
14400         * ser-tcp.c:
14401         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
14402         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
14403         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
14404         'getaddrinfo' and 'freeaddrinfo' were not available before
14405         Windows XP, and mingw.org's MinGW headers by default define
14406         _WIN32_WINNT to 0x500.
14407
14408 2019-03-01  Gary Benson <gbenson@redhat.com>
14409
14410         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
14411
14412 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
14413             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
14414
14415         PR gdb/8527
14416         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
14417         set_sigint_trap, clear_sigint_trap.
14418
14419 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14420
14421         * target.c (target_detach): Clear the regcache and the
14422         frame cache.
14423
14424 2019-02-27  Pedro Alves  <palves@redhat.com>
14425
14426         * utils.c (set_screen_size): When we cap the height/width sizes,
14427         tweak the corresponding command variable to show "unlimited":
14428
14429 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
14430             Pedro Alves  <palves@redhat.com>
14431
14432         * utils.c (set_screen_size): Reduce "infinite" rows and columns
14433         before calling rl_set_screen_size.
14434
14435 2019-02-27  Tom Tromey  <tromey@adacore.com>
14436
14437         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
14438         define.
14439         * python/py-value.c: Remove Python 2.4 workaround.
14440         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
14441         workaround.
14442         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
14443         Python 2.4 workaround.
14444         * python/python-internal.h: Remove Python 2.4 comment.
14445         (Py_ssize_t): Don't define.
14446         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
14447         (gdb_Py_DECREF): Remove Python 2.4 workaround.
14448         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
14449         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
14450         * python/python.c (do_start_initialization): Remove Python 2.4
14451         workaround.
14452         * python/py-prettyprint.c (class dummy_python_frame): Remove.
14453         (print_children): Remove Python 2.4 workaround.
14454         * python/py-inferior.c (buffer_procs): Remove Python 2.4
14455         workaround.
14456         (CHARBUFFERPROC_NAME): Remove.
14457         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
14458         Python 2.4 workaround.
14459
14460 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
14461
14462         * NEWS: Note minimum Python version.
14463
14464 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
14465
14466         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
14467         code from these functions.  Remove corresponding ifdefs.  Use
14468         Py_buffer_up instead of explicit calls to PyBuffer_Release.
14469         Remove gotos and target of gotos.
14470         (infpy_search_memory): Likewise.
14471
14472 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14473
14474         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
14475         (hppa_gdbarch_init): Don't register deleted functions with
14476         gdbarch.
14477
14478 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14479
14480         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
14481         (h8300_unwind_sp): Delete.
14482         (h8300_dummy_id): Delete.
14483         (h8300_gdbarch_init): Don't register deleted functions with
14484         gdbarch.
14485
14486 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14487
14488         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
14489         (ft32_unwind_pc): Delete.
14490         (ft32_unwind_sp): Delete.
14491         (ft32_gdbarch_init): Don't register deleted functions with
14492         gdbarch.
14493
14494 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14495
14496         * gdb/frv-tdep.c (frv_dummy_id): Delete.
14497         (frv_unwind_pc): Delete.
14498         (frv_unwind_sp): Delete.
14499         (frv_gdbarch_init): Don't register deleted functions with
14500         gdbarch.
14501
14502 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14503
14504         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
14505         (riscv_unwind_pc): Delete.
14506         (riscv_unwind_sp): Delete.
14507         (riscv_gdbarch_init): Don't register deleted functions with
14508         gdbarch.
14509
14510 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14511
14512         * gdb/csky-tdep.c (csky_dummy_id): Delete.
14513         (csky_unwind_pc): Delete.
14514         (csky_unwind_sp): Delete.
14515         (csky_gdbarch_init): Don't register deleted functions with
14516         gdbarch.
14517
14518 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14519
14520         * gdb/cris-tdep.c (cris_dummy_id): Delete.
14521         (cris_unwind_pc): Delete.
14522         (cris_unwind_sp): Delete.
14523         (cris_gdbarch_init): Don't register deleted functions with
14524         gdbarch.
14525
14526 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14527
14528         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
14529         (bfin_unwind_pc): Delete.
14530         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
14531
14532 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14533
14534         * gdb/arm-tdep.c (arm_dummy_id): Delete.
14535         (arm_unwind_pc): Delete.
14536         (arm_unwind_sp): Delete.
14537         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
14538
14539 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14540
14541         * gdb/arc-tdep.c (arc_dummy_id): Delete.
14542         (arc_unwind_pc): Delete.
14543         (arc_unwind_sp): Delete.
14544         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
14545
14546 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14547
14548         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
14549         (alpha_unwind_pc): Delete.
14550         (alpha_gdbarch_init): Don't register deleted functions with
14551         gdbarch.
14552
14553 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14554
14555         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
14556         (aarch64_unwind_pc): Delete.
14557         (aarch64_unwind_sp): Delete.
14558         (aarch64_gdbarch_init): Don't register deleted functions with
14559         gdbarch.
14560
14561 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14562
14563         * gdbtypes.c (type_align): Don't consider static members when
14564         computing structure alignment.
14565
14566 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14567
14568         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
14569         return 0 for other types.
14570         * arch-utils.c (default_type_align): Always return 0.
14571         * gdbarch.h: Regenerate.
14572         * gdbarch.sh (type_align): Extend comment.
14573         * gdbtypes.c (type_align): Add additional comments, always call
14574         gdbarch_type_align before applying the default rules.
14575         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
14576         generic code will then apply a suitable default.
14577         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
14578         types, return 0 for other types.
14579
14580 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
14581
14582         * NEWS: Create a new section for the next release branch.
14583         Rename the section of the current branch, now that it has
14584         been cut.
14585
14586 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
14587
14588         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
14589         * version.in: Bump version to 8.3.50.DATE-git.
14590
14591 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
14592
14593         * aix-thread.c (ptid_cmp): Remove unused variable.
14594         (get_signaled_thread): Likewise.
14595         (store_regs_user_thread): Likewise.
14596         (store_regs_kernel_thread): Likewise.
14597         (fetch_regs_kernel_thread): Remove shadowed variable.
14598
14599 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
14600
14601         * features/riscv/32bit-cpu.xml: Add register numbers.
14602         * features/riscv/32bit-fpu.c: Regenerate.
14603         * features/riscv/32bit-fpu.xml: Add register numbers.
14604         * features/riscv/64bit-cpu.xml: Add register numbers.
14605         * features/riscv/64bit-fpu.c: Regenerate.
14606         * features/riscv/64bit-fpu.xml: Add register numbers.
14607
14608 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
14609
14610         * NEWS: Mention two argument form of gdb.Value constructor.
14611         * python/py-value.c (convert_buffer_and_type_to_value): New
14612         function.
14613         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
14614         Add support for handling an optional second argument.  Call
14615         convert_buffer_and_type_to_value as appropriate.
14616         * python/python-internal.h (Py_buffer_deleter): New struct.
14617         (Py_buffer_up): New typedef.
14618
14619 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
14620
14621         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
14622         instead of releasing ownership.
14623
14624 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
14625
14626         * dwarf2read.c (open_and_init_dwp_file): Call
14627         elf_numsections instead of bfd_count_sections to initialize
14628         dwp_file->num_sections.
14629
14630 2019-02-25  Tom Tromey  <tromey@adacore.com>
14631
14632         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
14633
14634 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
14635
14636         * gcore.in: Add '--readnever' option when invoking GDB.
14637
14638 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
14639
14640         * MAINTAINERS: Update my email address.
14641
14642 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
14643
14644         * build-id.c (build_id_to_debug_bfd_1): New function.
14645         (build_id_to_debug_bfd): Look for separate debug file in
14646         sysroot.
14647
14648 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
14649
14650         * gdbarch.sh: Update the copyright year range that is placed into
14651         generated files.
14652
14653 2019-02-22  Keith Seitz  <keiths@redhat.com>
14654
14655         PR symtab/23853
14656         * linespec.c (create_sals_line_offset): Search for the default
14657         symtab's filename instead of its fullname.
14658
14659 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
14660
14661         * NEWS: Update style defaults.
14662
14663 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
14664
14665         * main.c (captured_main_1): Disable styling in batch mode.
14666
14667 2019-02-20  Tom Tromey  <tom@tromey.com>
14668
14669         * symtab.c (symtab_symbol_info): Fix typos.
14670
14671 2019-02-20  Tom Tromey  <tromey@adacore.com>
14672
14673         * findcmd.c (_initialize_mem_search): Use upper case for
14674         metasyntactic variables.
14675
14676 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
14677
14678         * aarch64-tdep.c (aarch64_add_reggroups): New function.
14679         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
14680
14681 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
14682
14683         * top.h (source_file_name): Change to std::string.
14684         * top.c (source_file_name): Likewise.
14685         (command_line_input): Adjust.
14686         * cli/cli-script.c (script_from_file): Adjust.
14687
14688 2019-02-19  Tom Tromey  <tromey@adacore.com>
14689
14690         * ravenscar-thread.c
14691         (ravenscar_thread_target::update_thread_list): Don't call
14692         ada_build_task_list.
14693         * ada-lang.h (ada_build_task_list): Don't declare.
14694         * ada-tasks.c (struct ada_tasks_inferior_data)
14695         <task_list_valid_p>: Now bool.
14696         (read_known_tasks, ada_task_list_changed)
14697         (ada_tasks_invalidate_inferior_data): Update.
14698         (read_known_tasks_array): Return bool.
14699         (read_known_tasks_list): Likewise.
14700         (read_known_tasks): Return void.
14701         (ada_build_task_list): Now static.
14702
14703 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
14704
14705         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
14706         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
14707
14708 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14709
14710         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
14711         variant for ada_tasks_pspace_data_handle and
14712         ada_tasks_inferior_data_handle.
14713         (ada_tasks_pspace_data_cleanup): New function.
14714         (ada_tasks_inferior_data_cleanup): New function.
14715
14716 2019-02-17  Tom Tromey  <tom@tromey.com>
14717
14718         * macrotab.h (macro_source_fullname): Return a std::string.
14719         * macrotab.c (macro_include, check_for_redefinition)
14720         (macro_undef, macro_lookup_definition, foreach_macro)
14721         (foreach_macro_in_scope): Update.
14722         (macro_source_fullname): Return a std::string.
14723         * macrocmd.c (show_pp_source_pos): Update.
14724
14725 2019-02-17  Tom Tromey  <tom@tromey.com>
14726
14727         * macrocmd.c (show_pp_source_pos): Style the file names.
14728
14729 2019-02-17  Tom Tromey  <tom@tromey.com>
14730
14731         PR tui/24197:
14732         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
14733
14734 2019-02-17  Tom Tromey  <tom@tromey.com>
14735
14736         * ada-lang.c (user_select_syms): Use filtered printing.
14737         * utils.c (wrap_style): New global.
14738         (desired_style): Remove.
14739         (emit_style_escape): Add stream parameter.
14740         (set_output_style, reset_terminal_style, prompt_for_continue):
14741         Update.
14742         (flush_wrap_buffer): Only flush gdb_stdout.
14743         (wrap_here): Set wrap_style.
14744         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
14745         treat escape sequences as a character.  Change when wrap buffer is
14746         flushed.
14747         (fputs_styled): Do not set the output style when the default is
14748         requested.
14749         * ui-style.h (struct ui_file_style) <is_default>: New method.
14750         * source.c (print_source_lines_base): Emit escape sequences in one
14751         piece.
14752
14753 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
14754
14755         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
14756         integers and enumeration types.
14757
14758 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
14759
14760         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
14761         instead of lookup_symbol_in_language
14762         (do_exact_match): New function.
14763         (ada_get_symbol_name_matcher): Return do_exact_match when
14764         doing a verbatim match.
14765
14766 2019-02-15  Tom Tromey  <tromey@adacore.com>
14767
14768         * ravenscar-thread.c (ravenscar_thread_target::resume)
14769         (ravenscar_thread_target::wait): Special case wildcard requests.
14770
14771 2019-02-15  Tom Tromey  <tromey@adacore.com>
14772
14773         * ravenscar-thread.c (base_ptid): Remove.
14774         (struct ravenscar_thread_target) <close>: New method.
14775         <m_base_ptid>: New member.
14776         <update_inferior_ptid, active_task, task_is_currently_active,
14777         runtime_initialized>: Declare methods.
14778         <ravenscar_thread_target>: Add constructor.
14779         (ravenscar_thread_target::task_is_currently_active)
14780         (ravenscar_thread_target::update_inferior_ptid)
14781         (ravenscar_runtime_initialized): Rename.  Now methods.
14782         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
14783         (ravenscar_thread_target::update_thread_list): Update.
14784         (ravenscar_thread_target::active_task): Now method.
14785         (ravenscar_thread_target::store_registers)
14786         (ravenscar_thread_target::prepare_to_store)
14787         (ravenscar_thread_target::prepare_to_store)
14788         (ravenscar_thread_target::mourn_inferior): Update.
14789         (ravenscar_inferior_created): Use "new" to create target.
14790         (ravenscar_thread_target::get_ada_task_ptid): Update.
14791         (_initialize_ravenscar): Don't initialize base_ptid.
14792         (ravenscar_ops): Remove global.
14793
14794 2019-02-15  Tom Tromey  <tromey@adacore.com>
14795
14796         * target.h (push_target): Declare new overload.
14797         * target.c (push_target): New overload, taking an rvalue reference.
14798         * remote.c (remote_target::open_1): Use push_target overload.
14799         * corelow.c (core_target_open): Use push_target overload.
14800
14801 2019-02-15  Tom Tromey  <tromey@adacore.com>
14802
14803         * ravenscar-thread.c (is_ravenscar_task)
14804         (ravenscar_task_is_currently_active): Return bool.
14805         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
14806         (_initialize_ravenscar): Remove "(void)".
14807         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
14808         Return bool.
14809
14810 2019-02-15  Tom Tromey  <tromey@adacore.com>
14811
14812         * ravenscar-thread.c (ravenscar_runtime_initializer)
14813         (has_ravenscar_runtime, get_running_thread_id)
14814         (ravenscar_thread_target::resume): Fix indentation.
14815
14816 2019-02-15  Tom Tromey  <tromey@adacore.com>
14817
14818         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
14819         from ravenscar_arch_ops.
14820         (sparc_ravenscar_ops::fetch_registers)
14821         (sparc_ravenscar_ops::store_registers): Now methods.
14822         (sparc_ravenscar_prepare_to_store): Remove.
14823         (sparc_ravenscar_ops): Redefine.
14824         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
14825         methods and destructor.  Remove members.
14826         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
14827         (ravenscar_thread_target::store_registers)
14828         (ravenscar_thread_target::prepare_to_store): Update.
14829         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
14830         Remove.
14831         (struct ppc_ravenscar_powerpc_ops): Derive from
14832         ravenscar_arch_ops.
14833         (ppc_ravenscar_powerpc_ops::fetch_registers)
14834         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
14835         (ppc_ravenscar_powerpc_ops): Redefine.
14836         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
14837         (ppc_ravenscar_e500_ops::fetch_registers)
14838         (ppc_ravenscar_e500_ops::store_registers): Now methods.
14839         (ppc_ravenscar_e500_ops): Redefine.
14840         * aarch64-ravenscar-thread.c
14841         (aarch64_ravenscar_generic_prepare_to_store): Remove.
14842         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
14843         (aarch64_ravenscar_fetch_registers)
14844         (aarch64_ravenscar_store_registers): Now methods.
14845         (aarch64_ravenscar_ops): Redefine.
14846
14847 2019-02-15  Tom Tromey  <tromey@adacore.com>
14848
14849         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
14850         (ravenscar_thread_target::stopped_by_hw_breakpoint)
14851         (ravenscar_thread_target::stopped_by_watchpoint)
14852         (ravenscar_thread_target::stopped_data_address)
14853         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
14854
14855 2019-02-15  Tom Tromey  <tromey@adacore.com>
14856
14857         * ravenscar-thread.c: Fix some typos.
14858
14859 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14860             Tom Tromey  <tromey@adacore.com>
14861
14862         * ada-lang.c (ada_exception_sal): Change addr_string to a
14863         std::string.
14864         (create_ada_exception_catchpoint): Update.
14865
14866 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14867             Tom Tromey  <tromey@adacore.com>
14868
14869         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
14870         (bp_location_ops): Remove.
14871         (base_breakpoint_allocate_location): Update.
14872         (free_bp_location): Update.
14873         * ada-lang.c (class ada_catchpoint_location)
14874         <ada_catchpoint_location>: Remove ops parameter.
14875         (ada_catchpoint_location_dtor): Remove.
14876         (ada_catchpoint_location_ops): Remove.
14877         (allocate_location_exception): Update.
14878         * breakpoint.h (struct bp_location_ops): Remove.
14879         (class bp_location) <bp_location>: Remove bp_location_ops
14880         parameter.
14881         <~bp_location>: Add destructor.
14882         <ops>: Remove.
14883
14884 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
14885             Pedro Alves  <palves@redhat.com>
14886
14887         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
14888         'PATH_MAX'.
14889
14890 2019-02-14  David Michael  <fedora.dm0@gmail.com>
14891             Samuel Thibault  <samuel.thibault@gnu.org>
14892             Thomas Schwinge  <thomas@codesourcery.com>
14893
14894         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
14895         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
14896
14897 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
14898
14899         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
14900         (check_empty): Use "const char *".
14901
14902         * gnu-nat.c (gnu_nat_target::detach): Instead of
14903         'detach_inferior (pid)' call
14904         'detach_inferior (find_inferior_pid (pid))'.
14905
14906         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
14907         'nat/fork-inferior.o'.
14908         * gnu-nat.c: #include "nat/fork-inferior.h".
14909
14910         * gnu-nat.c (gnu_nat_target::detach): Instead of
14911         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
14912         * gnu-nat.h: #include "inf-child.h".
14913         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
14914         'i386_gnu_nat_target::fetch_registers'.
14915         (gnu_store_registers): Rename/move to
14916         'i386_gnu_nat_target::store_registers'.
14917
14918         * config/i386/nm-i386gnu.h: Don't "#include" any files.
14919         * gnu-nat.h (mach_thread_info): New function.
14920         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
14921
14922         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
14923
14924 2019-02-14  Frederic Konrad  <konrad@adacore.com>
14925
14926         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
14927
14928 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
14929
14930         * windows-nat.c (windows_add_thread): Add new parameter
14931         "main_thread_p" with default value set to false.  Update
14932         function documentation as well as all callers.
14933         (windows_delete_thread): Likewise.
14934         (fake_create_process): Update call to windows_add_thread.
14935         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
14936         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
14937         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
14938         call to windows_delete_thread.
14939
14940 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
14941
14942         * MAINTAINERS: Add Andrew Burgess as global maintainer.
14943
14944 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
14945
14946         * symfile.c (find_separate_debug_file): Use canonical path of
14947         sysroot with child_path instead of gdb_sysroot if it is valid.
14948
14949 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
14950
14951         * symfile.c (find_separate_debug_file): Use child_path to
14952         determine if an object file is under a sysroot.
14953
14954 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
14955
14956         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
14957         unittests/child-path-selftests.c.
14958         * common/pathstuff.c (child_path): New function.
14959         * common/pathstuff.h (child_path): New prototype.
14960         * unittests/child-path-selftests.c: New file.
14961
14962 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
14963
14964         * symfile.c (find_separate_debug_file): Look for separate debug
14965         files in debug directories under the sysroot.
14966
14967 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14968
14969         * symtab.h (struct minimal_symbol data_p): New const method.
14970         (struct minimal_symbol text_p): Likewise.
14971         * symtab.c (output_source_filename): Use file name style
14972         to print file name.
14973         (print_symbol_info): Likewise.
14974         (print_msymbol_info): Use address style to print addresses.
14975         Use function name style to print executable text symbols.
14976         (expand_symtab_containing_pc): Use data_p.
14977         (find_pc_sect_compunit_symtab): Likewise.
14978
14979 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14980
14981         * breakpoint.c (describe_other_breakpoints): Use address style
14982         to print addresses.
14983         (say_where): Likewise.
14984
14985 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14986
14987         * ada-typeprint.c (print_func_type): Print function name
14988         style to print function name.
14989         * c-typeprint.c (c_print_type_1): Likewise.
14990
14991 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
14992
14993         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
14994         for execve.
14995
14996 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14997
14998         * c-exp.y (direct_abs_decl): Use emplace_back to record the
14999         type_stack.
15000
15001 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
15002
15003         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
15004         TYPE_CODE_REF types.
15005
15006 2019-02-08  Jim Wilson  <jimw@sifive.com>
15007
15008         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
15009         (riscv_linux_fregset): New.
15010         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
15011
15012 2019-02-07  Tom Tromey  <tom@tromey.com>
15013
15014         * thread.c (thread_cancel_execution_command): Update.
15015         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
15016         methods.
15017         (struct thread_fsm_ops): Remove.
15018         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
15019         (thread_fsm_should_stop, thread_fsm_return_value)
15020         (thread_fsm_set_finished, thread_fsm_finished_p)
15021         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
15022         Don't declare.
15023         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
15024         * infrun.c (clear_proceed_status_thread)
15025         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
15026         (print_stop_event): Update.
15027         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
15028         Add constructor.
15029         (step_command_fsm_ops): Remove.
15030         (new_step_command_fsm): Remove.
15031         (step_1): Update.
15032         (step_command_fsm::should_stop): Rename from
15033         step_command_fsm_should_stop.
15034         (step_command_fsm::clean_up): Rename from
15035         step_command_fsm_clean_up.
15036         (step_command_fsm::do_async_reply_reason): Rename from
15037         step_command_fsm_async_reply_reason.
15038         (struct until_next_fsm): Inherit from thread_fsm.  Add
15039         constructor.
15040         (until_next_fsm_ops): Remove.
15041         (new_until_next_fsm): Remove.
15042         (until_next_fsm::should_stop): Rename from
15043         until_next_fsm_should_stop.
15044         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
15045         (until_next_fsm::do_async_reply_reason): Rename from
15046         until_next_fsm_async_reply_reason.
15047         (struct finish_command_fsm): Inherit from thread_fsm.  Add
15048         constructor.  Change type of breakpoint.
15049         (finish_command_fsm_ops): Remove.
15050         (new_finish_command_fsm): Remove.
15051         (finish_command_fsm::should_stop): Rename from
15052         finish_command_fsm_should_stop.
15053         (finish_command_fsm::clean_up): Rename from
15054         finish_command_fsm_clean_up.
15055         (finish_command_fsm::return_value): Rename from
15056         finish_command_fsm_return_value.
15057         (finish_command_fsm::do_async_reply_reason): Rename from
15058         finish_command_fsm_async_reply_reason.
15059         (finish_command): Update.
15060         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
15061         Add constructor.
15062         (call_thread_fsm_ops): Remove.
15063         (call_thread_fsm::call_thread_fsm): Rename from
15064         new_call_thread_fsm.
15065         (call_thread_fsm::should_stop): Rename from
15066         call_thread_fsm_should_stop.
15067         (call_thread_fsm::should_notify_stop): Rename from
15068         call_thread_fsm_should_notify_stop.
15069         (run_inferior_call, call_function_by_hand_dummy): Update.
15070         * cli/cli-interp.c (should_print_stop_to_console): Update.
15071         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
15072         Add constructor.  Change type of location_breakpoint,
15073         caller_breakpoint.
15074         (until_break_fsm_ops): Remove.
15075         (new_until_break_fsm): Remove.
15076         (until_break_fsm::should_stop): Rename from
15077         until_break_fsm_should_stop.
15078         (until_break_fsm::clean_up): Rename from
15079         until_break_fsm_clean_up.
15080         (until_break_fsm::do_async_reply_reason): Rename from
15081         until_break_fsm_async_reply_reason.
15082         (until_break_command): Update.
15083         * thread-fsm.c: Remove.
15084         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
15085
15086 2019-02-07  Tom Tromey  <tom@tromey.com>
15087
15088         * yy-remap.h: Add include guard.
15089         * xtensa-tdep.h: Add include guard.
15090         * xcoffread.h: Rename include guard.
15091         * varobj-iter.h: Add include guard.
15092         * tui/tui.h: Rename include guard.
15093         * tui/tui-winsource.h: Rename include guard.
15094         * tui/tui-wingeneral.h: Rename include guard.
15095         * tui/tui-windata.h: Rename include guard.
15096         * tui/tui-win.h: Rename include guard.
15097         * tui/tui-stack.h: Rename include guard.
15098         * tui/tui-source.h: Rename include guard.
15099         * tui/tui-regs.h: Rename include guard.
15100         * tui/tui-out.h: Rename include guard.
15101         * tui/tui-layout.h: Rename include guard.
15102         * tui/tui-io.h: Rename include guard.
15103         * tui/tui-hooks.h: Rename include guard.
15104         * tui/tui-file.h: Rename include guard.
15105         * tui/tui-disasm.h: Rename include guard.
15106         * tui/tui-data.h: Rename include guard.
15107         * tui/tui-command.h: Rename include guard.
15108         * tic6x-tdep.h: Add include guard.
15109         * target/waitstatus.h: Rename include guard.
15110         * target/wait.h: Rename include guard.
15111         * target/target.h: Rename include guard.
15112         * target/resume.h: Rename include guard.
15113         * target-float.h: Rename include guard.
15114         * stabsread.h: Add include guard.
15115         * rs6000-tdep.h: Add include guard.
15116         * riscv-fbsd-tdep.h: Add include guard.
15117         * regformats/regdef.h: Rename include guard.
15118         * record.h: Rename include guard.
15119         * python/python.h: Rename include guard.
15120         * python/python-internal.h: Rename include guard.
15121         * python/py-stopevent.h: Rename include guard.
15122         * python/py-ref.h: Rename include guard.
15123         * python/py-record.h: Rename include guard.
15124         * python/py-record-full.h: Rename include guard.
15125         * python/py-record-btrace.h: Rename include guard.
15126         * python/py-instruction.h: Rename include guard.
15127         * python/py-events.h: Rename include guard.
15128         * python/py-event.h: Rename include guard.
15129         * procfs.h: Add include guard.
15130         * proc-utils.h: Add include guard.
15131         * p-lang.h: Add include guard.
15132         * or1k-tdep.h: Rename include guard.
15133         * observable.h: Rename include guard.
15134         * nto-tdep.h: Rename include guard.
15135         * nat/x86-linux.h: Rename include guard.
15136         * nat/x86-linux-dregs.h: Rename include guard.
15137         * nat/x86-gcc-cpuid.h: Add include guard.
15138         * nat/x86-dregs.h: Rename include guard.
15139         * nat/x86-cpuid.h: Rename include guard.
15140         * nat/ppc-linux.h: Rename include guard.
15141         * nat/mips-linux-watch.h: Rename include guard.
15142         * nat/linux-waitpid.h: Rename include guard.
15143         * nat/linux-ptrace.h: Rename include guard.
15144         * nat/linux-procfs.h: Rename include guard.
15145         * nat/linux-osdata.h: Rename include guard.
15146         * nat/linux-nat.h: Rename include guard.
15147         * nat/linux-namespaces.h: Rename include guard.
15148         * nat/linux-btrace.h: Rename include guard.
15149         * nat/glibc_thread_db.h: Rename include guard.
15150         * nat/gdb_thread_db.h: Rename include guard.
15151         * nat/gdb_ptrace.h: Rename include guard.
15152         * nat/fork-inferior.h: Rename include guard.
15153         * nat/amd64-linux-siginfo.h: Rename include guard.
15154         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
15155         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
15156         * nat/aarch64-linux.h: Rename include guard.
15157         * nat/aarch64-linux-hw-point.h: Rename include guard.
15158         * mn10300-tdep.h: Add include guard.
15159         * mips-linux-tdep.h: Add include guard.
15160         * mi/mi-parse.h: Rename include guard.
15161         * mi/mi-out.h: Rename include guard.
15162         * mi/mi-main.h: Rename include guard.
15163         * mi/mi-interp.h: Rename include guard.
15164         * mi/mi-getopt.h: Rename include guard.
15165         * mi/mi-console.h: Rename include guard.
15166         * mi/mi-common.h: Rename include guard.
15167         * mi/mi-cmds.h: Rename include guard.
15168         * mi/mi-cmd-break.h: Rename include guard.
15169         * m2-lang.h: Add include guard.
15170         * location.h: Rename include guard.
15171         * linux-record.h: Rename include guard.
15172         * linux-nat.h: Add include guard.
15173         * linux-fork.h: Add include guard.
15174         * i386-darwin-tdep.h: Rename include guard.
15175         * hppa-linux-offsets.h: Add include guard.
15176         * guile/guile.h: Rename include guard.
15177         * guile/guile-internal.h: Rename include guard.
15178         * gnu-nat.h: Rename include guard.
15179         * gdb-stabs.h: Rename include guard.
15180         * frv-tdep.h: Add include guard.
15181         * f-lang.h: Add include guard.
15182         * event-loop.h: Add include guard.
15183         * darwin-nat.h: Rename include guard.
15184         * cp-abi.h: Rename include guard.
15185         * config/sparc/nm-sol2.h: Rename include guard.
15186         * config/nm-nto.h: Rename include guard.
15187         * config/nm-linux.h: Add include guard.
15188         * config/i386/nm-i386gnu.h: Rename include guard.
15189         * config/djgpp/nl_types.h: Rename include guard.
15190         * config/djgpp/langinfo.h: Rename include guard.
15191         * compile/gcc-cp-plugin.h: Add include guard.
15192         * compile/gcc-c-plugin.h: Add include guard.
15193         * compile/compile.h: Rename include guard.
15194         * compile/compile-object-run.h: Rename include guard.
15195         * compile/compile-object-load.h: Rename include guard.
15196         * compile/compile-internal.h: Rename include guard.
15197         * compile/compile-cplus.h: Rename include guard.
15198         * compile/compile-c.h: Rename include guard.
15199         * common/xml-utils.h: Rename include guard.
15200         * common/x86-xstate.h: Rename include guard.
15201         * common/version.h: Rename include guard.
15202         * common/vec.h: Rename include guard.
15203         * common/tdesc.h: Rename include guard.
15204         * common/selftest.h: Rename include guard.
15205         * common/scoped_restore.h: Rename include guard.
15206         * common/scoped_mmap.h: Rename include guard.
15207         * common/scoped_fd.h: Rename include guard.
15208         * common/safe-iterator.h: Rename include guard.
15209         * common/run-time-clock.h: Rename include guard.
15210         * common/refcounted-object.h: Rename include guard.
15211         * common/queue.h: Rename include guard.
15212         * common/ptid.h: Rename include guard.
15213         * common/print-utils.h: Rename include guard.
15214         * common/preprocessor.h: Rename include guard.
15215         * common/pathstuff.h: Rename include guard.
15216         * common/observable.h: Rename include guard.
15217         * common/netstuff.h: Rename include guard.
15218         * common/job-control.h: Rename include guard.
15219         * common/host-defs.h: Rename include guard.
15220         * common/gdb_wait.h: Rename include guard.
15221         * common/gdb_vecs.h: Rename include guard.
15222         * common/gdb_unlinker.h: Rename include guard.
15223         * common/gdb_unique_ptr.h: Rename include guard.
15224         * common/gdb_tilde_expand.h: Rename include guard.
15225         * common/gdb_sys_time.h: Rename include guard.
15226         * common/gdb_string_view.h: Rename include guard.
15227         * common/gdb_splay_tree.h: Rename include guard.
15228         * common/gdb_setjmp.h: Rename include guard.
15229         * common/gdb_ref_ptr.h: Rename include guard.
15230         * common/gdb_optional.h: Rename include guard.
15231         * common/gdb_locale.h: Rename include guard.
15232         * common/gdb_assert.h: Rename include guard.
15233         * common/filtered-iterator.h: Rename include guard.
15234         * common/filestuff.h: Rename include guard.
15235         * common/fileio.h: Rename include guard.
15236         * common/environ.h: Rename include guard.
15237         * common/common-utils.h: Rename include guard.
15238         * common/common-types.h: Rename include guard.
15239         * common/common-regcache.h: Rename include guard.
15240         * common/common-inferior.h: Rename include guard.
15241         * common/common-gdbthread.h: Rename include guard.
15242         * common/common-exceptions.h: Rename include guard.
15243         * common/common-defs.h: Rename include guard.
15244         * common/common-debug.h: Rename include guard.
15245         * common/cleanups.h: Rename include guard.
15246         * common/buffer.h: Rename include guard.
15247         * common/btrace-common.h: Rename include guard.
15248         * common/break-common.h: Rename include guard.
15249         * cli/cli-utils.h: Rename include guard.
15250         * cli/cli-style.h: Rename include guard.
15251         * cli/cli-setshow.h: Rename include guard.
15252         * cli/cli-script.h: Rename include guard.
15253         * cli/cli-interp.h: Rename include guard.
15254         * cli/cli-decode.h: Rename include guard.
15255         * cli/cli-cmds.h: Rename include guard.
15256         * charset-list.h: Add include guard.
15257         * buildsym-legacy.h: Rename include guard.
15258         * bfin-tdep.h: Add include guard.
15259         * ax.h: Rename include guard.
15260         * arm-linux-tdep.h: Add include guard.
15261         * arm-fbsd-tdep.h: Add include guard.
15262         * arch/xtensa.h: Rename include guard.
15263         * arch/tic6x.h: Add include guard.
15264         * arch/i386.h: Add include guard.
15265         * arch/arm.h: Rename include guard.
15266         * arch/arm-linux.h: Rename include guard.
15267         * arch/arm-get-next-pcs.h: Rename include guard.
15268         * arch/amd64.h: Add include guard.
15269         * arch/aarch64-insn.h: Rename include guard.
15270         * arch-utils.h: Rename include guard.
15271         * annotate.h: Add include guard.
15272         * amd64-darwin-tdep.h: Rename include guard.
15273         * aarch64-linux-tdep.h: Add include guard.
15274         * aarch64-fbsd-tdep.h: Add include guard.
15275         * aarch32-linux-nat.h: Add include guard.
15276
15277 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
15278
15279         * macrotab.c (macro_define_internal): New function that
15280         factorizes macro_define_object_internal and macro_define_function
15281         code.
15282         (macro_define_object_internal): Use macro_define_internal.
15283         (macro_define_function): Likewise.
15284
15285 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
15286
15287         * macrocmd.c (extract_identifier): Return
15288         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
15289         callers.
15290
15291 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
15292
15293         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
15294
15295 2019-02-05  Tom Tromey  <tom@tromey.com>
15296
15297         * target.c (target_stack::unpush): Move assertion earlier.
15298
15299 2019-01-30  Tom Tromey  <tom@tromey.com>
15300
15301         PR python/23615:
15302         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
15303         (gdbpy_parse_and_eval): Likewise.
15304         * python/python-internal.h (gdbpy_allow_threads): New class.
15305
15306 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
15307
15308         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
15309         (aarch64_fbsd_fpregmap): Move earlier.
15310         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
15311         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
15312         instead of individual calls to trad_frame_set_reg_addr.
15313         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
15314         earlier.
15315         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
15316         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
15317         instead of individual calls to trad_frame_set_reg_addr.
15318
15319 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
15320
15321         * CONTRIBUTE: Replace contribution list with wiki link.
15322
15323 2019-01-25  Tom Tromey  <tom@tromey.com>
15324
15325         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
15326
15327 2019-01-25  Tom Tromey  <tom@tromey.com>
15328
15329         * xtensa-linux-nat.c: Fix common/ includes.
15330         * xml-support.h: Fix common/ includes.
15331         * xml-support.c: Fix common/ includes.
15332         * x86-linux-nat.c: Fix common/ includes.
15333         * windows-nat.c: Fix common/ includes.
15334         * varobj.h: Fix common/ includes.
15335         * varobj.c: Fix common/ includes.
15336         * value.c: Fix common/ includes.
15337         * valops.c: Fix common/ includes.
15338         * utils.c: Fix common/ includes.
15339         * unittests/xml-utils-selftests.c: Fix common/ includes.
15340         * unittests/utils-selftests.c: Fix common/ includes.
15341         * unittests/unpack-selftests.c: Fix common/ includes.
15342         * unittests/tracepoint-selftests.c: Fix common/ includes.
15343         * unittests/style-selftests.c: Fix common/ includes.
15344         * unittests/string_view-selftests.c: Fix common/ includes.
15345         * unittests/scoped_restore-selftests.c: Fix common/ includes.
15346         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
15347         * unittests/scoped_fd-selftests.c: Fix common/ includes.
15348         * unittests/rsp-low-selftests.c: Fix common/ includes.
15349         * unittests/parse-connection-spec-selftests.c: Fix common/
15350         includes.
15351         * unittests/optional-selftests.c: Fix common/ includes.
15352         * unittests/offset-type-selftests.c: Fix common/ includes.
15353         * unittests/observable-selftests.c: Fix common/ includes.
15354         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
15355         * unittests/memrange-selftests.c: Fix common/ includes.
15356         * unittests/memory-map-selftests.c: Fix common/ includes.
15357         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
15358         * unittests/function-view-selftests.c: Fix common/ includes.
15359         * unittests/environ-selftests.c: Fix common/ includes.
15360         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
15361         * unittests/common-utils-selftests.c: Fix common/ includes.
15362         * unittests/cli-utils-selftests.c: Fix common/ includes.
15363         * unittests/array-view-selftests.c: Fix common/ includes.
15364         * ui-file.c: Fix common/ includes.
15365         * tui/tui-io.c: Fix common/ includes.
15366         * tracepoint.h: Fix common/ includes.
15367         * tracepoint.c: Fix common/ includes.
15368         * tracefile-tfile.c: Fix common/ includes.
15369         * top.h: Fix common/ includes.
15370         * top.c: Fix common/ includes.
15371         * thread.c: Fix common/ includes.
15372         * target/waitstatus.h: Fix common/ includes.
15373         * target/waitstatus.c: Fix common/ includes.
15374         * target.h: Fix common/ includes.
15375         * target.c: Fix common/ includes.
15376         * target-memory.c: Fix common/ includes.
15377         * target-descriptions.c: Fix common/ includes.
15378         * symtab.h: Fix common/ includes.
15379         * symfile.c: Fix common/ includes.
15380         * stap-probe.c: Fix common/ includes.
15381         * spu-linux-nat.c: Fix common/ includes.
15382         * sparc-nat.c: Fix common/ includes.
15383         * source.c: Fix common/ includes.
15384         * solib.c: Fix common/ includes.
15385         * solib-target.c: Fix common/ includes.
15386         * ser-unix.c: Fix common/ includes.
15387         * ser-tcp.c: Fix common/ includes.
15388         * ser-pipe.c: Fix common/ includes.
15389         * ser-base.c: Fix common/ includes.
15390         * selftest-arch.c: Fix common/ includes.
15391         * s12z-tdep.c: Fix common/ includes.
15392         * rust-exp.y: Fix common/ includes.
15393         * rs6000-aix-tdep.c: Fix common/ includes.
15394         * riscv-tdep.c: Fix common/ includes.
15395         * remote.c: Fix common/ includes.
15396         * remote-notif.h: Fix common/ includes.
15397         * remote-fileio.h: Fix common/ includes.
15398         * remote-fileio.c: Fix common/ includes.
15399         * regcache.h: Fix common/ includes.
15400         * regcache.c: Fix common/ includes.
15401         * record-btrace.c: Fix common/ includes.
15402         * python/python.c: Fix common/ includes.
15403         * python/py-type.c: Fix common/ includes.
15404         * python/py-inferior.c: Fix common/ includes.
15405         * progspace.h: Fix common/ includes.
15406         * producer.c: Fix common/ includes.
15407         * procfs.c: Fix common/ includes.
15408         * proc-api.c: Fix common/ includes.
15409         * printcmd.c: Fix common/ includes.
15410         * ppc-linux-nat.c: Fix common/ includes.
15411         * parser-defs.h: Fix common/ includes.
15412         * osdata.c: Fix common/ includes.
15413         * obsd-nat.c: Fix common/ includes.
15414         * nat/x86-linux.c: Fix common/ includes.
15415         * nat/x86-linux-dregs.c: Fix common/ includes.
15416         * nat/x86-dregs.h: Fix common/ includes.
15417         * nat/x86-dregs.c: Fix common/ includes.
15418         * nat/ppc-linux.c: Fix common/ includes.
15419         * nat/mips-linux-watch.h: Fix common/ includes.
15420         * nat/mips-linux-watch.c: Fix common/ includes.
15421         * nat/linux-waitpid.c: Fix common/ includes.
15422         * nat/linux-ptrace.h: Fix common/ includes.
15423         * nat/linux-ptrace.c: Fix common/ includes.
15424         * nat/linux-procfs.c: Fix common/ includes.
15425         * nat/linux-personality.c: Fix common/ includes.
15426         * nat/linux-osdata.c: Fix common/ includes.
15427         * nat/linux-namespaces.c: Fix common/ includes.
15428         * nat/linux-btrace.h: Fix common/ includes.
15429         * nat/linux-btrace.c: Fix common/ includes.
15430         * nat/fork-inferior.c: Fix common/ includes.
15431         * nat/amd64-linux-siginfo.c: Fix common/ includes.
15432         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
15433         * nat/aarch64-linux.c: Fix common/ includes.
15434         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
15435         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
15436         * namespace.h: Fix common/ includes.
15437         * mips-linux-tdep.c: Fix common/ includes.
15438         * minsyms.c: Fix common/ includes.
15439         * mi/mi-parse.h: Fix common/ includes.
15440         * mi/mi-main.c: Fix common/ includes.
15441         * mi/mi-cmd-env.c: Fix common/ includes.
15442         * memrange.h: Fix common/ includes.
15443         * memattr.c: Fix common/ includes.
15444         * maint.h: Fix common/ includes.
15445         * maint.c: Fix common/ includes.
15446         * main.c: Fix common/ includes.
15447         * machoread.c: Fix common/ includes.
15448         * location.c: Fix common/ includes.
15449         * linux-thread-db.c: Fix common/ includes.
15450         * linux-nat.c: Fix common/ includes.
15451         * linux-fork.c: Fix common/ includes.
15452         * inline-frame.c: Fix common/ includes.
15453         * infrun.c: Fix common/ includes.
15454         * inflow.c: Fix common/ includes.
15455         * inferior.h: Fix common/ includes.
15456         * inferior.c: Fix common/ includes.
15457         * infcmd.c: Fix common/ includes.
15458         * inf-ptrace.c: Fix common/ includes.
15459         * inf-child.c: Fix common/ includes.
15460         * ia64-linux-nat.c: Fix common/ includes.
15461         * i387-tdep.c: Fix common/ includes.
15462         * i386-tdep.c: Fix common/ includes.
15463         * i386-linux-tdep.c: Fix common/ includes.
15464         * i386-linux-nat.c: Fix common/ includes.
15465         * i386-go32-tdep.c: Fix common/ includes.
15466         * i386-fbsd-tdep.c: Fix common/ includes.
15467         * i386-fbsd-nat.c: Fix common/ includes.
15468         * guile/scm-type.c: Fix common/ includes.
15469         * guile/guile.c: Fix common/ includes.
15470         * go32-nat.c: Fix common/ includes.
15471         * gnu-nat.c: Fix common/ includes.
15472         * gdbthread.h: Fix common/ includes.
15473         * gdbarch-selftests.c: Fix common/ includes.
15474         * gdb_usleep.c: Fix common/ includes.
15475         * gdb_select.h: Fix common/ includes.
15476         * gdb_bfd.c: Fix common/ includes.
15477         * gcore.c: Fix common/ includes.
15478         * fork-child.c: Fix common/ includes.
15479         * findvar.c: Fix common/ includes.
15480         * fbsd-nat.c: Fix common/ includes.
15481         * event-top.c: Fix common/ includes.
15482         * event-loop.c: Fix common/ includes.
15483         * dwarf2read.c: Fix common/ includes.
15484         * dwarf2loc.c: Fix common/ includes.
15485         * dwarf2-frame.c: Fix common/ includes.
15486         * dwarf-index-cache.c: Fix common/ includes.
15487         * dtrace-probe.c: Fix common/ includes.
15488         * disasm-selftests.c: Fix common/ includes.
15489         * defs.h: Fix common/ includes.
15490         * csky-tdep.c: Fix common/ includes.
15491         * cp-valprint.c: Fix common/ includes.
15492         * cp-support.h: Fix common/ includes.
15493         * cp-support.c: Fix common/ includes.
15494         * corelow.c: Fix common/ includes.
15495         * completer.h: Fix common/ includes.
15496         * completer.c: Fix common/ includes.
15497         * compile/compile.c: Fix common/ includes.
15498         * compile/compile-loc2c.c: Fix common/ includes.
15499         * compile/compile-cplus-types.c: Fix common/ includes.
15500         * compile/compile-cplus-symbols.c: Fix common/ includes.
15501         * command.h: Fix common/ includes.
15502         * cli/cli-dump.c: Fix common/ includes.
15503         * cli/cli-cmds.c: Fix common/ includes.
15504         * charset.c: Fix common/ includes.
15505         * build-id.c: Fix common/ includes.
15506         * btrace.h: Fix common/ includes.
15507         * btrace.c: Fix common/ includes.
15508         * breakpoint.h: Fix common/ includes.
15509         * breakpoint.c: Fix common/ includes.
15510         * ax.h:
15511         (enum agent_op): Fix common/ includes.
15512         * ax-general.c (struct aop_map): Fix common/ includes.
15513         * ax-gdb.c: Fix common/ includes.
15514         * auxv.c: Fix common/ includes.
15515         * auto-load.c: Fix common/ includes.
15516         * arm-tdep.c: Fix common/ includes.
15517         * arch/riscv.c: Fix common/ includes.
15518         * arch/ppc-linux-common.c: Fix common/ includes.
15519         * arch/i386.c: Fix common/ includes.
15520         * arch/arm.c: Fix common/ includes.
15521         * arch/arm-linux.c: Fix common/ includes.
15522         * arch/arm-get-next-pcs.c: Fix common/ includes.
15523         * arch/amd64.c: Fix common/ includes.
15524         * arch/aarch64.c: Fix common/ includes.
15525         * arch/aarch64-insn.c: Fix common/ includes.
15526         * arch-utils.c: Fix common/ includes.
15527         * amd64-windows-tdep.c: Fix common/ includes.
15528         * amd64-tdep.c: Fix common/ includes.
15529         * amd64-sol2-tdep.c: Fix common/ includes.
15530         * amd64-obsd-tdep.c: Fix common/ includes.
15531         * amd64-nbsd-tdep.c: Fix common/ includes.
15532         * amd64-linux-tdep.c: Fix common/ includes.
15533         * amd64-linux-nat.c: Fix common/ includes.
15534         * amd64-fbsd-tdep.c: Fix common/ includes.
15535         * amd64-fbsd-nat.c: Fix common/ includes.
15536         * amd64-dicos-tdep.c: Fix common/ includes.
15537         * amd64-darwin-tdep.c: Fix common/ includes.
15538         * agent.c: Fix common/ includes.
15539         * ada-lang.h: Fix common/ includes.
15540         * ada-lang.c: Fix common/ includes.
15541         * aarch64-tdep.c: Fix common/ includes.
15542
15543 2019-01-25  Tom Tromey  <tom@tromey.com>
15544
15545         * common/create-version.sh: Use common/version.h.
15546
15547 2019-01-24  Pedro Alves  <palves@redhat.com>
15548
15549         * infrun.c (signal_stop, signal_print, signal_program)
15550         (signal_catch, signal_pass): Now arrays instead of pointers.
15551         (update_signals_program_target, do_target_resume)
15552         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
15553         * linux-nat.c (linux_nat_target::pass_signals)
15554         (linux_nat_target::create_inferior, linux_nat_target::attach):
15555         Adjust.
15556         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
15557         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
15558         * procfs.c (procfs_target::pass_signals): Adjust.
15559         * record-full.c (record_full_target::resume): Adjust.
15560         * remote.c (remote_target::pass_signals)
15561         (remote_target::program_signals): Adjust.
15562         * target-debug.h (target_debug_print_signals): Now takes a
15563         gdb::array_view as parameter.  Adjust.
15564         * target.h (target_ops) <pass_signals, program_signals>: Replace
15565         pointer and length parameters with gdb::array_view.
15566         (target_pass_signals, target_program_signals): Likewise.
15567         * target-delegates.c: Regenerate.
15568
15569 2019-01-24  Pedro Alves  <palves@redhat.com>
15570
15571         * common/forward-scope-exit.h
15572         (forward_scope_exit::forward_scope_exit): Pass arguments to
15573         m_bind_function directly, instead of creating a std::bind and
15574         copying that.
15575
15576 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
15577
15578         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
15579         for static members.
15580         (pass_in_v_vfp_candidate): Likewise.
15581
15582 2019-01-23  Tom Tromey  <tom@tromey.com>
15583             Pedro Alves  <palves@redhat.com>
15584
15585         * regcache.c (class regcache_invalidator): Remove.
15586         (regcache::raw_write): Use make_scope_exit.
15587
15588 2019-01-23  Tom Tromey  <tom@tromey.com>
15589
15590         * ui-out.h (class ui_out_emit_type): Update comment.
15591
15592 2019-01-23  Tom Tromey  <tom@tromey.com>
15593
15594         * infrun.c (fetch_inferior_event): Update comment.
15595
15596 2019-01-23  Tom Tromey  <tom@tromey.com>
15597             Pedro Alves  <palves@redhat.com>
15598
15599         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
15600         parameter.
15601         (fetch_inferior_event): Use SCOPE_EXIT.
15602
15603
15604 2019-01-23  Tom Tromey  <tom@tromey.com>
15605             Pedro Alves  <palves@redhat.com>
15606
15607         * infrun.c (disable_thread_events): Delete.
15608         (stop_all_threads): Use SCOPE_EXIT.
15609
15610 2019-01-23  Tom Tromey  <tom@tromey.com>
15611             Pedro Alves  <palves@redhat.com>
15612
15613         * symfile.c: Include forward-scope-exit.h.
15614         (clear_symtab_users_cleanup): Replace forward declaration with
15615         a FORWARD_SCOPE_EXIT.
15616         (syms_from_objfile_1): Use the forward_scope_exit and
15617         gdb::optional instead of cleanup_function.
15618         (reread_symbols): Use the forward_scope_exit instead of
15619         cleanup_function.
15620         (clear_symtab_users_cleanup): Remove function.
15621
15622 2019-01-23  Tom Tromey  <tom@tromey.com>
15623             Pedro Alves  <palves@redhat.com>
15624
15625         * linux-nat.c: Include scope-exit.h.
15626         (cleanup_target_stop): Remove.
15627         (linux_nat_target::static_tracepoint_markers_by_strid): Use
15628         SCOPE_EXIT.
15629
15630 2019-01-23  Tom Tromey  <tom@tromey.com>
15631             Pedro Alves  <palves@redhat.com>
15632
15633         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
15634         (call_function_by_hand_dummy): Use SCOPE_EXIT.
15635
15636 2019-01-23  Tom Tromey  <tom@tromey.com>
15637             Andrew Burgess  <andrew.burgess@embecosm.com>
15638             Pedro Alves  <palves@redhat.com>
15639
15640         * infrun.c (fetch_inferior_event): Use scope_exit.
15641         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
15642         * top.c (execute_command): Use scope_exit.
15643         * breakpoint.c (bpstat_do_actions): Use scope_exit.
15644         * utils.c (do_bpstat_clear_actions_cleanup)
15645         (make_bpstat_clear_actions_cleanup): Remove.
15646
15647 2019-01-23  Tom Tromey  <tom@tromey.com>
15648             Pedro Alves  <palves@redhat.com>
15649
15650         * infrun.c: Include "common/scope-exit.h"
15651         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
15652         (wait_for_inferior): Use SCOPE_EXIT.
15653         (fetch_inferior_event): Use scope_exit.
15654
15655 2019-01-23  Tom Tromey  <tom@tromey.com>
15656             Pedro Alves  <palves@redhat.com>
15657
15658         * breakpoint.c (create_breakpoint): Remove cleanup.
15659
15660 2019-01-23  Tom Tromey  <tom@tromey.com>
15661             Andrew Burgess  <andrew.burgess@embecosm.com>
15662             Pedro Alves  <palves@redhat.com>
15663
15664 2019-01-23  Pedro Alves  <palves@redhat.com>
15665
15666         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
15667
15668 2019-01-23  Pedro Alves  <palves@redhat.com>
15669             Andrew Burgess  <andrew.burgess@embecosm.com>
15670
15671         * gdbthread.h: Include "common/forward-scope-exit.h".
15672         (scoped_finish_thread_state): Redefine custom class in terms of
15673         forward_scope_exit.
15674
15675 2019-01-23  Pedro Alves  <palves@redhat.com>
15676             Andrew Burgess  <andrew.burgess@embecosm.com>
15677
15678         * common/forward-scope-exit.h: New file.
15679
15680 2019-01-23  Pedro Alves  <palves@redhat.com>
15681             Andrew Burgess  <andrew.burgess@embecosm.com>
15682             Tom Tromey  <tom@tromey.com>
15683
15684         * common/scope-exit.h: New file.
15685
15686 2019-01-23  Pedro Alves  <palves@redhat.com>
15687
15688         * common/preprocessor.h (ESC): Rename to ...
15689         (ESC_PARENS): ... this.
15690         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
15691         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
15692
15693 2019-01-23  Tom Tromey  <tom@tromey.com>
15694
15695         * language.h (class scoped_switch_to_sym_language_if_auto):
15696         Initialize m_lang in both cases.
15697
15698 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
15699
15700         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
15701         with XCNEW.
15702
15703 2019-01-22  Tom Tromey  <tom@tromey.com>
15704
15705         * corelow.c: Do not include sys/file.h.
15706
15707 2019-01-22  Tom Tromey  <tom@tromey.com>
15708
15709         * tui/tui-wingeneral.h: Include gdb_curses.h.
15710
15711 2019-01-22  Tom Tromey  <tom@tromey.com>
15712
15713         * source-cache.h (class source_cache) <get_source_lines,
15714         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
15715
15716 2019-01-22  Tom Tromey  <tom@tromey.com>
15717
15718         * remote-fileio.h (struct remote_target): Declare.
15719
15720 2019-01-22  Tom Tromey  <tom@tromey.com>
15721
15722         * python/py-arch.c: Do not include py-ref.h.
15723         * python/py-bpevent.c: Do not include py-ref.h.
15724         * python/py-cmd.c: Do not include py-ref.h.
15725         * python/py-continueevent.c: Do not include py-ref.h.
15726         * python/py-event.h: Do not include py-ref.h.
15727         * python/py-evtregistry.c: Do not include py-ref.h.
15728         * python/py-finishbreakpoint.c: Do not include py-ref.h.
15729         * python/py-frame.c: Do not include py-ref.h.
15730         * python/py-framefilter.c: Do not include py-ref.h.
15731         * python/py-function.c: Do not include py-ref.h.
15732         * python/py-infevents.c: Do not include py-ref.h.
15733         * python/py-linetable.c: Do not include py-ref.h.
15734         * python/py-objfile.c: Do not include py-ref.h.
15735         * python/py-param.c: Do not include py-ref.h.
15736         * python/py-prettyprint.c: Do not include py-ref.h.
15737         * python/py-progspace.c: Do not include py-ref.h.
15738         * python/py-symbol.c: Do not include py-ref.h.
15739         * python/py-symtab.c: Do not include py-ref.h.
15740         * python/py-type.c: Do not include py-ref.h.
15741         * python/py-unwind.c: Do not include py-ref.h.
15742         * python/py-utils.c: Do not include py-ref.h.
15743         * python/py-value.c: Do not include py-ref.h.
15744         * python/py-varobj.c: Do not include py-ref.h.
15745         * python/py-xmethods.c: Do not include py-ref.h.
15746         * python/python.c: Do not include py-ref.h.
15747         * varobj.c: Do not include py-ref.h.
15748
15749 2019-01-22  Tom Tromey  <tom@tromey.com>
15750
15751         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
15752         keyword for bcache.
15753
15754 2019-01-22  Tom Tromey  <tom@tromey.com>
15755
15756         * compile/compile-cplus-types.c: Remove a comment by #include.
15757
15758 2019-01-22  Tom Tromey  <tom@tromey.com>
15759
15760         * compile/gcc-c-plugin.h: Include compile-internal.h.
15761
15762 2019-01-22  Tom Tromey  <tom@tromey.com>
15763
15764         * stabsread.c (EXTERN): Do not define.
15765         (symnum, next_symbol_text_func, processing_gcc_compilation)
15766         (within_function, global_sym_chain, global_stabs)
15767         (previous_stab_code, this_object_header_files)
15768         (n_this_object_header_files)
15769         (n_allocated_this_object_header_files): Define.
15770         * stabsread.h (EXTERN): Never define.  Use "extern".
15771
15772 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
15773
15774         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
15775         history_value.
15776
15777 2019-01-21  Tom Tromey  <tom@tromey.com>
15778
15779         * ui-out.c: Fix includes.
15780         * tui/tui-source.c: Fix includes.
15781         * target.c: Fix includes.
15782         * remote.c: Fix includes.
15783         * regcache.c: Fix includes.
15784         * python/py-block.c: Fix includes.
15785         * printcmd.c: Fix includes.
15786         * or1k-tdep.c: Fix includes.
15787         * mi/mi-main.c: Fix includes.
15788         * m32r-tdep.c: Fix includes.
15789         * csky-tdep.c: Fix includes.
15790         * compile/compile-cplus-types.c: Fix includes.
15791         * cli/cli-interp.c: Fix includes.
15792
15793 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
15794
15795         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
15796         for padding.
15797
15798 2019-01-16  Tom Tromey  <tom@tromey.com>
15799
15800         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
15801         earlier.
15802         (struct objfile) <msymbols_range>: Move from top level.
15803         <msymbols>: New method.
15804         (class objfile_msymbols): Remove.
15805         * symtab.c (default_collect_symbol_completion_matches_break_on):
15806         Update.
15807         * symmisc.c (dump_msymbols): Update.
15808         * stabsread.c (scan_file_globals): Update.
15809         * objc-lang.c (info_selectors_command, info_classes_command)
15810         (find_methods): Update.
15811         * minsyms.c (find_solib_trampoline_target): Update.
15812         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
15813         * coffread.c (coff_symfile_read): Update.
15814         * ada-lang.c (ada_lookup_simple_minsym)
15815         (ada_collect_symbol_completion_matches): Update.
15816
15817 2019-01-16  Tom Tromey  <tom@tromey.com>
15818
15819         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
15820         type.  Remove no-argument constructor.
15821         <iterator::operator++>: Simplify.
15822         <begin>: Update.
15823         <end>: Use minimal_symbol_count.
15824
15825 2019-01-16  Tom Tromey  <tom@tromey.com>
15826
15827         * objfiles.h (struct objfile) <psymtabs>: New method.
15828         (class objfile_psymtabs): Remove.
15829         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
15830         typedef.
15831         <range>: New method.
15832         (require_partial_symbols): Change return type.
15833         * psymtab.c (require_partial_symbols)
15834         (psym_expand_symtabs_matching): Update.
15835         * mdebugread.c (parse_partial_symbols): Update.
15836         * dbxread.c (dbx_end_psymtab): Update.
15837
15838 2019-01-15  Tom Tromey  <tom@tromey.com>
15839
15840         * symtab.c (lookup_objfile_from_block)
15841         (lookup_symbol_in_objfile_symtabs)
15842         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
15843         (find_line_symtab, info_sources_command)
15844         (default_collect_symbol_completion_matches_break_on)
15845         (make_source_files_completion_list): Update.
15846         * symmisc.c (print_objfile_statistics, dump_objfile)
15847         (maintenance_print_symbols, maintenance_info_symtabs)
15848         (maintenance_check_symtabs, maintenance_info_line_tables):
15849         Update.
15850         * source.c (select_source_symtab)
15851         (forget_cached_source_info_for_objfile): Update.
15852         * objfiles.h (class objfile_compunits): Remove.
15853         (struct objfile) <compunits_range>: New typedef.
15854         (compunits): New method.
15855         * objfiles.c (objfile_relocate1): Update.
15856         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
15857         * maint.c (count_symtabs_and_blocks): Update.
15858         * linespec.c (iterate_over_all_matching_symtabs): Update.
15859         * cp-support.c (add_symbol_overload_list_qualified): Update.
15860         * coffread.c (coff_symtab_read): Update.
15861         * ada-lang.c (add_nonlocal_symbols)
15862         (ada_collect_symbol_completion_matches)
15863         (ada_add_global_exceptions): Update.
15864
15865 2019-01-15  Tom Tromey  <tom@tromey.com>
15866
15867         * progspace.h (program_space) <objfiles_safe_range>: New
15868         typedef.
15869         <objfiles_safe>: New method.
15870         * objfiles.h (class all_objfiles_safe): Remove.
15871         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
15872         * jit.c (jit_inferior_exit_hook): Update.
15873
15874 2019-01-17  Tom Tromey  <tom@tromey.com>
15875
15876         * progspace.h (program_space) <objfiles_range>: New typedef.
15877         <objfiles>: New method.
15878         <objfiles_head>: Rename from objfiles.
15879         (object_files): Update.
15880         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
15881         * guile/scm-pretty-print.c
15882         (ppscm_find_pretty_printer_from_objfiles): Update.
15883         * guile/scm-objfile.c (gdbscm_objfiles): Update.
15884         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
15885         Update.
15886         * python/py-progspace.c (pspy_get_objfiles): Update.
15887         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
15888         Update.
15889         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
15890         (objfpy_lookup_objfile_by_build_id): Update.
15891         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
15892         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
15893         Update.
15894         * symtab.c (iterate_over_symtabs, matching_obj_sections)
15895         (expand_symtab_containing_pc, lookup_objfile_from_block)
15896         (lookup_static_symbol, basic_lookup_transparent_type)
15897         (find_pc_sect_compunit_symtab, find_symbol_at_address)
15898         (find_line_symtab, info_sources_command)
15899         (default_collect_symbol_completion_matches_break_on)
15900         (make_source_files_completion_list, find_main_name): Update.
15901         * symmisc.c (print_symbol_bcache_statistics)
15902         (print_objfile_statistics, maintenance_print_symbols)
15903         (maintenance_print_msymbols, maintenance_print_objfiles)
15904         (maintenance_info_symtabs, maintenance_check_symtabs)
15905         (maintenance_expand_symtabs, maintenance_info_line_tables):
15906         Update.
15907         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
15908         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
15909         (map_overlay_command, unmap_overlay_command)
15910         (simple_overlay_update, expand_symtabs_matching)
15911         (map_symbol_filenames): Update.
15912         * symfile-debug.c (set_debug_symfile): Update.
15913         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
15914         Update.
15915         * source.c (select_source_symtab, forget_cached_source_info):
15916         Update.
15917         * solib.c (solib_read_symbols): Update.
15918         * solib-spu.c (append_ocl_sos): Update.
15919         * psymtab.c (maintenance_print_psymbols)
15920         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
15921         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
15922         * printcmd.c (info_symbol_command): Update.
15923         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
15924         Update.
15925         * objfiles.h (class all_objfiles): Remove.
15926         * objfiles.c (have_partial_symbols, have_full_symbols)
15927         (have_minimal_symbols, qsort_cmp, update_section_map)
15928         (shared_objfile_contains_address_p)
15929         (default_iterate_over_objfiles_in_search_order): Update.
15930         * objc-lang.c (info_selectors_command, info_classes_command)
15931         (find_methods): Update.
15932         * minsyms.c (find_solib_trampoline_target): Update.
15933         * maint.c (maintenance_info_sections)
15934         (maintenance_translate_address, count_symtabs_and_blocks):
15935         Update.
15936         * main.c (captured_main_1): Update.
15937         * linux-thread-db.c (try_thread_db_load_from_pdir)
15938         (has_libpthread): Update.
15939         * linespec.c (iterate_over_all_matching_symtabs)
15940         (search_minsyms_for_name): Update.
15941         * jit.c (jit_find_objf_with_entry_addr): Update.
15942         * hppa-tdep.c (find_unwind_entry)
15943         (hppa_lookup_stub_minimal_symbol): Update.
15944         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
15945         Update.
15946         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
15947         (elf_gnu_ifunc_resolve_by_got): Update.
15948         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
15949         * dwarf-index-write.c (save_gdb_index_command): Update.
15950         * cp-support.c (add_symbol_overload_list_qualified): Update.
15951         * breakpoint.c (create_overlay_event_breakpoint)
15952         (create_longjmp_master_breakpoint)
15953         (create_std_terminate_master_breakpoint)
15954         (create_exception_master_breakpoint): Update.
15955         * blockframe.c (find_pc_partial_function): Update.
15956         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
15957         (ada_collect_symbol_completion_matches)
15958         (ada_add_global_exceptions): Update.
15959
15960 2019-01-17  Tom Tromey  <tom@tromey.com>
15961
15962         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
15963         declare VEC.
15964         (solib_target_parse_libraries): Change return type.
15965         (library_list_start_segment, library_list_start_section)
15966         (library_list_end_library, library_list_start_library); Update.
15967         (solib_target_free_library_list): Remove.
15968         (solib_target_parse_libraries): Remove cleanup.  Change return
15969         type.
15970         (solib_target_current_sos): Update.
15971
15972 2019-01-17  Tom Tromey  <tromey@bapiya>
15973
15974         * valprint.c: Replace "the the" with "the".
15975         * symtab.c: Replace "the the" with "the".
15976         * solib.c: Replace "the the" with "the".
15977         * solib-dsbt.c: Replace "the the" with "the".
15978         * linespec.c: Replace "the the" with "the".
15979         * dwarf2loc.h: Replace "the the" with "the".
15980         * amd64-windows-tdep.c: Replace "the the" with "the".
15981         * aarch64-tdep.c: Replace "the the" with "the".
15982
15983 2019-01-16  Keith Seitz  <keiths@redhat.com>
15984
15985         PR gdb/23773
15986         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
15987         <builder>: Rename to ..
15988         <m_builder>: ... this and make private.
15989         (dwarf2_cu::get_builder): New method.  Change all users of
15990         `builder' to use this method.
15991         (dwarf2_start_symtab): Move to ...
15992         (dwarf2_cu::start_symtab): ... here.  Update all callers
15993         (setup_type_unit_groups): Move to ...
15994         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
15995         callers.
15996         (dwarf2_cu::reset_builder): New method.
15997         (process_full_compunit, process_full_type_unit): Use
15998         dwarf2_cu::reset_builder.
15999         (follow_die_offset): Record the ancestor CU if it is different
16000         from the followed DIE's CU.
16001         (follow_die_sig_1): Likewise.
16002
16003 2019-01-15  Tom Tromey  <tom@tromey.com>
16004
16005         * remote.c (class remote_state) <buf>: Now a char_vector.
16006         <buf_size>: Remove.
16007         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
16008         parameter.
16009         (remote_target::getpkt_or_notif_sane_1)
16010         (remote_target::getpkt_sane)
16011         (remote_target::getpkt_or_notif_sane): Likewise.
16012         (class remote_target) <putpkt>: New overload.
16013         (remote_target::read_frame): Change type of "buf_p".  Remove
16014         sizeof_p parameter.
16015         (packet_ok): New overload.
16016         (packet_check_result): New overload.
16017         Update all uses.
16018
16019 2019-01-14  Tom Tromey  <tom@tromey.com>
16020
16021         * remote-notif.c (handle_notification, remote_notif_ack)
16022         (remote_notif_parse): Make "buf" const.
16023         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
16024         const.
16025         (remote_notif_parse, remote_notif_ack, handle_notification):
16026         Likewise.
16027         * remote.c (remote_notif_stop_parse): Make "buf" const.
16028         (remote_target::remote_parse_stop_reply): Make "buf" const.
16029         (remote_notif_stop_ack): Make "buf" const.
16030
16031 2019-01-14  Tom Tromey  <tom@tromey.com>
16032
16033         * remote.c (remote_console_output): Make parameter const.
16034
16035 2019-01-14  Tom Tromey  <tom@tromey.com>
16036
16037         * target-debug.h (target_debug_print_signals): Constify.
16038         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
16039         * procfs.c (procfs_target::pass_signals): Update.
16040         * linux-nat.c (linux_nat_target::pass_signals): Update.
16041         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
16042         * target-delegates.c: Rebuild.
16043         * remote.c (remote_target::program_signals): Update.
16044         (remote_target::pass_signals): Update.
16045         * target.c (target_pass_signals): Constify argument.
16046         (target_program_signals): Likewise.
16047         * target.h (struct target_ops) <pass_signals, program_signals>:
16048         Constify argument.
16049         (target_pass_signals, target_program_signals): Constify argument.
16050
16051 2019-01-14  Tom Tromey  <tom@tromey.com>
16052
16053         PR tui/28819:
16054         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
16055
16056 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
16057
16058         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
16059         field.
16060         * rs6000-tdep.c: Include reggroups.h.
16061         (IS_V_ALIAS_PSEUDOREG): Define.
16062         (rs6000_register_name): Return names for the "vX" aliases.
16063         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
16064         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
16065         aliases.  Call default_register_reggroup_p for all other
16066         pseudo-registers.
16067         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
16068         New functions.
16069         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
16070         Handle "vX" aliases.
16071         (v_alias_pseudo_register_collect): New function.
16072         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
16073         (rs6000_gdbarch_init): Initialize "vX" aliases as
16074         pseudo-registers.  Restore registration of
16075         rs6000_pseudo_register_reggroup_p with
16076         set_tdesc_pseudo_register_reggroup_p.
16077
16078 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
16079
16080         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
16081         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
16082         set_gdbarch_num_pseudo_regs.
16083
16084 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
16085
16086         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
16087         Remove arg prefixname, add do_set and do_show.
16088         Add member functions set_list and show_list.
16089         * cli/cli-style.c (class cli_style_option): Update accordingly.
16090         (style_set_list): Move to file scope.
16091         (style_show_list): Likewise.
16092         (set_style): Call help_list.
16093         (show_style): Call cmd_show_list.
16094         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
16095         Update to use the new macro.
16096
16097 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
16098
16099         * ada-lang.c (_initialize_ada_language): Expand the help text
16100         for the "catch exception" command.
16101
16102 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
16103
16104         * symtab.c (matching_obj_sections): Initialize obj,
16105         declare it closer to its usage.
16106
16107 2019-01-10  Tom Tromey  <tom@tromey.com>
16108
16109         * thread-iter.h (inf_threads_iterator): Use next_iterator.
16110         (basic_inf_threads_range): Remove.
16111         (inf_threads_range, inf_non_exited_threads_range)
16112         (safe_inf_threads_range): Use next_adapter.
16113
16114 2019-01-10  Keith Seitz  <keiths@redhat.com>
16115
16116         PR gdb/23712
16117         PR symtab/23010
16118         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
16119         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
16120
16121 2019-01-10  Keith Seitz  <keiths@redhat.com>
16122
16123         PR gdb/23712
16124         PR symtab/23010
16125         * dictionary.c (pending_to_vector): Remove.
16126         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
16127         Remove _1 suffix, replacing functions of the same name.  Update
16128         all callers.
16129         (dict_create_hashed, dict_create_hashed_expandable)
16130         (dict_create_linear, dict_create_linear_expandable, dict_free)
16131         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
16132         Make functions static.
16133
16134 2019-01-10  Keith Seitz  <keiths@redhat.com>
16135
16136         PR gdb/23712
16137         PR symtab/23010
16138         * dictionary.h (struct dictionary): Replace declaration with
16139         multidictionary.
16140         (dict_create_hashed, dict_create_hashed_expandable)
16141         (dict_create_linear, dict_create_linear_expandable)
16142         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
16143         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
16144         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
16145         taking multidictionary argument.
16146         [ALL_DICT_SYMBOLS]: Update for multidictionary.
16147         * block.h (struct block) <dict>: Change to multidictionary
16148         and rename `multidict'.
16149         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
16150         symmisc.c: Update all dictionary references to multidictionary.
16151
16152 2019-01-10  Keith Seitz  <keiths@redhat.com>
16153
16154         PR gdb/23712
16155         PR symtab/23010
16156         * dictionary.c: Include unordered_map.
16157         (pending_to_vector): New function.
16158         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
16159         Rewrite the non-"_1" functions to take vector instead
16160         of linked list.
16161         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
16162         "new" _1 versions of the same name.
16163         (multidictionary): Define.
16164         (std::hash<enum language): New definition.
16165         (collate_pending_symbols_by_language, mdict_create_hashed)
16166         (mdict_create_hashed_expandable, mdict_create_linear)
16167         (mdict_create_linear_expandable, mdict_free)
16168         (find_language_dictionary, create_new_language_dictionary)
16169         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
16170         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
16171         (mdict_size, mdict_empty): New functions.
16172         * dictionary.h (mdict_iterator): Define.
16173
16174 2019-01-10  Pedro Alves  <palves@redhat.com>
16175
16176         * breakpoint.c (read_uploaded_action)
16177         (create_tracepoint_from_upload): Adjust to use
16178         gdb::unique_xmalloc_ptr.
16179         * ctf.c (ctf_write_uploaded_tp):
16180         (SET_ARRAY_FIELD): Use emplace_back.
16181         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
16182         * tracefile-tfile.c (tfile_write_uploaded_tp):
16183         * tracepoint.c (parse_tracepoint_definition): Adjust to use
16184         gdb::unique_xmalloc_ptr.
16185         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
16186         at_string, cond_string, cmd_strings>: Replace char pointers
16187         with gdb::unique_xmalloc_ptr.
16188
16189 2019-01-10  Pedro Alves  <palves@redhat.com>
16190
16191         * solib-target.c (library_list_start_library): Don't xstrdup name.
16192
16193 2019-01-10  Pedro Alves  <palves@redhat.com>
16194
16195         * mdebugread.c (parse_partial_symbols): Use
16196         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
16197
16198 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
16199
16200         * linux-fork.c (scoped_switch_fork_info)
16201         <~scoped_switch_fork_info>: Fix incorrect variable name.
16202
16203 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
16204
16205         * linux-fork.c (scoped_switch_fork_info)
16206         <scoped_switch_fork_info>: Make explicit.
16207         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
16208
16209 2019-01-10  Tom Tromey  <tom@tromey.com>
16210
16211         * objfiles.h (objfile::reset_psymtabs): Update.
16212         * objfiles.c (objfile::objfile): Update.
16213         * psymtab.h (psymtab_storage::obstack): Update.
16214         (psymtab_storage::m_obstack): Use gdb::optional.
16215         (class psymtab_storage): Update comment.  Remove objfile
16216         parameter.
16217         * psymtab.c (psymtab_storage::psymtab_storage): Update.
16218
16219 2019-01-10  Tom Tromey  <tom@tromey.com>
16220
16221         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
16222         <free_psymtabs>: Now private.
16223         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
16224         (allocate_psymtab): Use new method.
16225
16226 2019-01-10  Tom Tromey  <tom@tromey.com>
16227
16228         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
16229         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
16230         * mdebugread.c (parse_partial_symbols): Use
16231         allocate_dependencies.
16232         * dwarf2read.c (dwarf2_create_include_psymtab): Use
16233         allocate_dependencies.
16234         (process_psymtab_comp_unit_reader)
16235         (build_type_psymtab_dependencies): Likewise.
16236         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
16237
16238 2019-01-10  Tom Tromey  <tom@tromey.com>
16239
16240         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
16241         PSYMBOL_SET_LANGUAGE.
16242         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
16243
16244 2019-01-10  Tom Tromey  <tom@tromey.com>
16245
16246         * psymtab.h (psymtab_storage::obstack): New method.
16247         <m_obstack>: Rename from obstack; now private.
16248         * psymtab.c (psymtab_storage): Update.
16249         * dwarf2read.c (create_addrmap_from_index)
16250         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
16251         Update.
16252
16253 2019-01-10  Tom Tromey  <tom@tromey.com>
16254
16255         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
16256         * objfiles.h (objfile::reset_psymtabs): New method.
16257
16258 2019-01-10  Tom Tromey  <tom@tromey.com>
16259
16260         * symmisc.c (print_symbol_bcache_statistics): Update.
16261         (print_objfile_statistics): Update.
16262         * symfile.c (reread_symbols): Update.
16263         * psymtab.h (class psymtab_storage): New.
16264         * psymtab.c (psymtab_storage): New constructor.
16265         (~psymtab_storage): New destructor.
16266         (require_partial_symbols): Update.
16267         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
16268         (find_pc_sect_psymtab, find_pc_sect_psymbol)
16269         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
16270         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
16271         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
16272         (start_psymtab_common, end_psymtab_common)
16273         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
16274         (allocate_psymtab): Update.
16275         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
16276         Update.
16277         (dump_psymtab_addrmap, maintenance_print_psymbols)
16278         (maintenance_check_psymtabs): Update.
16279         (class objfile_psymtabs): Move to objfiles.h.
16280         * psympriv.h (discard_psymtab): Now inline.
16281         (psymtab_discarder::psymtab_discarder): Update.
16282         (psymtab_discarder::~psymtab_discarder): Update.
16283         (ALL_OBJFILE_PSYMTABS): Rewrite.
16284         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
16285         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
16286         Remove fields.
16287         <partial_symtabs>: New field.
16288         (class objfile_psymtabs): Move from psymtab.h.  Update.
16289         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
16290         psymbol_cache.
16291         (objfile::~objfile): Don't destroy psymbol_cache.
16292         * mdebugread.c (parse_partial_symbols): Update.
16293         * dwarf2read.c (create_addrmap_from_index)
16294         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
16295         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
16296         (add_partial_subprogram, dwarf2_ranges_read): Update.
16297         * dwarf-index-write.c (write_address_map)
16298         (write_one_signatured_type, recursively_write_psymbols)
16299         (class debug_names, class debug_names, write_psymtabs_to_index):
16300         Update.
16301
16302 2019-01-10  Tom Tromey  <tom@tromey.com>
16303
16304         * symtab.h (SYMBOL_SET_NAMES): Update.
16305         (symbol_set_names): Update.
16306         (MSYMBOL_SET_NAMES): Update.
16307         * symtab.c (symbol_set_names): Change argument to be an
16308         objfile_per_bfd_storage.
16309         * psymtab.c (add_psymbol_to_bcache): Update.
16310         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
16311
16312 2019-01-10  Tom Tromey  <tom@tromey.com>
16313
16314         * symtab.c (create_demangled_names_hash): Change argument to be an
16315         objfile_per_bfd_storage.
16316         (symbol_set_names): Update.
16317
16318 2019-01-10  Tom Tromey  <tom@tromey.com>
16319
16320         * xcoffread.c (xcoff_initial_scan): Unconditionally call
16321         init_psymbol_list.
16322         * psymtab.c (init_psymbol_list): Do nothing if already called.
16323         * psympriv.h (init_psymbol_list): Add comment.
16324         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
16325         init_psymbol_list.
16326         * dbxread.c (dbx_symfile_read): Unconditionally call
16327         init_psymbol_list.
16328
16329 2019-01-10  Tom Tromey  <tom@tromey.com>
16330
16331         * xcoffread.c (scan_xcoff_symtab): Update.
16332         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
16333         "where".
16334         * mdebugread.c (parse_partial_symbols)
16335         (handle_psymbol_enumerators): Update.
16336         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
16337         * dbxread.c (read_dbx_symtab): Update.
16338         * psympriv.h (psymbol_placement): New enum.
16339         (add_psymbol_to_list): Update.
16340
16341 2019-01-10  Tom Tromey  <tom@tromey.com>
16342
16343         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
16344         static_psymbols parameters.
16345         (scan_xcoff_symtab): Update.
16346         * psymtab.c (start_psymtab_common): Remove global_psymbols and
16347         static_psymbols parameters.
16348         * psympriv.h (start_psymtab_common): Update.
16349         * mdebugread.c (parse_partial_symbols): Update.
16350         * dwarf2read.c (create_partial_symtab): Update.
16351         * dbxread.c (read_dbx_symtab): Update.
16352         (start_psymtab): Remove global_psymbols and static_psymbols
16353         parameters.
16354
16355 2019-01-10  Tom Tromey  <tom@tromey.com>
16356
16357         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
16358         * psymtab.c (allocate_psymtab): Add comment.
16359         * psympriv.h (allocate_psymtab): Add comment.
16360         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
16361         initializations.
16362         * dbxread.c (dbx_end_psymtab): Remove some initializations.
16363
16364 2019-01-10  Tom Tromey  <tom@tromey.com>
16365
16366         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
16367         Don't declare.
16368         * mipsread.c: Include mdebugread.h.
16369         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
16370         Declare.
16371         * elfread.c: Include mdebugread.h.
16372
16373 2019-01-09  Tom Tromey  <tom@tromey.com>
16374
16375         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
16376         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
16377         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
16378         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
16379         (psym_lookup_symbol, psym_find_last_source_symtab)
16380         (psym_forget_cached_source_info, psym_print_stats)
16381         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
16382         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
16383         (psym_map_matching_symbols, psym_expand_symtabs_matching)
16384         (psym_find_compunit_symtab_by_address)
16385         (maintenance_print_psymbols, maintenance_info_psymtabs)
16386         (maintenance_check_psymtabs): Use ranged for.
16387         * psymtab.h (class objfile_psymtabs): New.
16388         (require_partial_symbols): Return objfile_psymtabs.
16389         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
16390
16391 2019-01-09  Tom Tromey  <tom@tromey.com>
16392
16393         * symfile.c (overlay_invalidate_all, find_pc_overlay)
16394         (find_pc_mapped_section, list_overlays_command)
16395         (map_overlay_command, unmap_overlay_command)
16396         (simple_overlay_update): Use all_objfiles.
16397         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
16398         * printcmd.c (info_symbol_command): Use all_objfiles.
16399         * objfiles.h (ALL_OBJSECTIONS): Remove.
16400         * maint.c (maintenance_translate_address): Use all_objfiles.
16401         * gcore.c (gcore_create_callback): Use all_objfiles.
16402         (objfile_find_memory_regions): Likewise.
16403
16404 2019-01-09  Tom Tromey  <tom@tromey.com>
16405
16406         * symtab.c (find_line_symtab, info_sources_command)
16407         (make_source_files_completion_list): Use objfile_compunits.
16408         * source.c (select_source_symtab): Use objfile_compunits.
16409         * objfiles.h (struct objfile): Update comment.
16410         (ALL_OBJFILES): Remove.
16411         (ALL_FILETABS): Remove.
16412         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
16413         objfile_compunits.
16414
16415 2019-01-09  Tom Tromey  <tom@tromey.com>
16416
16417         * symmisc.c (print_objfile_statistics, dump_objfile)
16418         (maintenance_print_symbols): Use compunit_filetabs.
16419         * source.c (forget_cached_source_info_for_objfile): Use
16420         compunit_filetabs.
16421         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
16422         (ALL_FILETABS): Use compunit_filetabs.
16423         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
16424         * coffread.c (coff_symtab_read): Use compunit_filetabs.
16425
16426 2019-01-09  Tom Tromey  <tom@tromey.com>
16427
16428         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
16429         (compunit_filetabs): New.
16430         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
16431         compunit_filetabs.
16432         (info_sources_command, make_source_files_completion_list): Remove
16433         declaration.
16434         * symmisc.c (print_objfile_statistics, dump_objfile)
16435         (maintenance_print_symbols): Remove declaration.
16436         (maintenance_info_symtabs): Use compunit_filetabs.
16437         (maintenance_info_line_tables): Likewise.
16438         * source.c (select_source_symtab): Change local variable name.
16439         (forget_cached_source_info_for_objfile): Remove declaration.
16440         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
16441         * objfiles.c (objfile_relocate1): Remove declaration.
16442         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
16443         declaration.
16444         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
16445         * coffread.c (coff_symtab_read): Remove declaration.
16446         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
16447         compunit_filetabs.
16448
16449 2019-01-09  Tom Tromey  <tom@tromey.com>
16450
16451         * symtab.c (lookup_objfile_from_block)
16452         (find_pc_sect_compunit_symtab, search_symbols)
16453         (default_collect_symbol_completion_matches_break_on): Use
16454         objfile_compunits.
16455         * objfiles.h (ALL_COMPUNITS): Remove.
16456         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
16457         * cp-support.c (add_symbol_overload_list_qualified): Use
16458         objfile_compunits.
16459         * ada-lang.c (ada_collect_symbol_completion_matches)
16460         (ada_add_global_exceptions): Use objfile_compunits.
16461
16462 2019-01-09  Tom Tromey  <tom@tromey.com>
16463
16464         * source.c (select_source_symtab)
16465         (forget_cached_source_info_for_objfile): Remove declaration.
16466         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
16467         declaration.
16468         * maint.c (count_symtabs_and_blocks): Remove declaration.
16469         * cp-support.c (add_symbol_overload_list_qualified): Remove
16470         declaration.
16471         * coffread.c (coff_symtab_read): Remove declaration.
16472         * symtab.c (lookup_symbol_in_objfile_symtabs)
16473         (basic_lookup_transparent_type_1): Use objfile_compunits.
16474         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
16475         (info_sources_command, search_symbols)
16476         (default_collect_symbol_completion_matches_break_on)
16477         (make_source_files_completion_list): Remove declaration.
16478         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
16479         (ada_collect_symbol_completion_matches)
16480         (ada_add_global_exceptions): Remove declaration.
16481         * linespec.c (iterate_over_all_matching_symtabs): Use
16482         objfile_compunits.
16483         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
16484         (class objfile_compunits): New.
16485         (ALL_COMPUNITS): Use objfile_compunits.
16486         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
16487         (maintenance_check_symtabs, maintenance_info_line_tables): Use
16488         objfile_compunits.
16489         * objfiles.c (objfile_relocate1): Use objfile_compunits.
16490
16491 2019-01-09  Tom Tromey  <tom@tromey.com>
16492
16493         * symtab.c (search_symbols)
16494         (default_collect_symbol_completion_matches_break_on): Use
16495         objfile_msymbols.
16496         * ada-lang.c (ada_lookup_simple_minsym)
16497         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
16498         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
16499         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
16500         objfile_msymbols.
16501         * coffread.c (coff_symfile_read): Use objfile_msymbols.
16502         * symmisc.c (dump_msymbols): Use objfile_msymbols.
16503         * objc-lang.c (find_methods): Use objfile_msymbols.
16504         (info_selectors_command, info_classes_command): Likewise.
16505         * stabsread.c (scan_file_globals): Use objfile_msymbols.
16506         * objfiles.h (class objfile_msymbols): New.
16507         (ALL_OBJFILE_MSYMBOLS): Remove.
16508         (ALL_MSYMBOLS): Remove.
16509
16510 2019-01-09  Tom Tromey  <tom@tromey.com>
16511
16512         * common/next-iterator.h (next_adapter): Add Iterator template
16513         parameter.
16514         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
16515         (class all_objfiles_safe): New.
16516         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
16517         * objfiles.c (put_objfile_before): Update comment.
16518         (add_separate_debug_objfile): Likewise.
16519         (free_all_objfiles): Use all_objfiles_safe.
16520         (objfile_purge_solibs): Likewise.
16521
16522 2019-01-09  Tom Tromey  <tom@tromey.com>
16523
16524         * symtab.c (iterate_over_symtabs, matching_obj_sections)
16525         (expand_symtab_containing_pc, lookup_static_symbol)
16526         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
16527         (find_symbol_at_address, find_line_symtab, find_main_name): Use
16528         all_objfiles.
16529         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
16530         * breakpoint.c (create_overlay_event_breakpoint)
16531         (create_longjmp_master_breakpoint)
16532         (create_std_terminate_master_breakpoint)
16533         (create_exception_master_breakpoint): Use all_objfiles.
16534         * linux-thread-db.c (try_thread_db_load_from_pdir)
16535         (has_libpthread): Use all_objfiles.
16536         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
16537         * linespec.c (iterate_over_all_matching_symtabs)
16538         (search_minsyms_for_name): Use all_objfiles.
16539         * maint.c (maintenance_info_sections): Use all_objfiles.
16540         * main.c (captured_main_1): Use all_objfiles.
16541         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
16542         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
16543         * guile/scm-pretty-print.c
16544         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
16545         * solib-spu.c (append_ocl_sos): Use all_objfiles.
16546         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
16547         (maintenance_print_msymbols): Use all_objfiles.
16548         * source.c (select_source_symtab): Use all_objfiles.
16549         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
16550         * symfile.c (remove_symbol_file_command)
16551         (expand_symtabs_matching, map_symbol_filenames): Use
16552         all_objfiles.
16553         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
16554         all_objfiles.
16555         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
16556         * objc-lang.c (find_methods): Use all_objfiles.
16557         * objfiles.c (have_partial_symbols, have_full_symbols)
16558         (have_minimal_symbols, qsort_cmp)
16559         (default_iterate_over_objfiles_in_search_order): Use
16560         all_objfiles.
16561         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
16562         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
16563         (maintenance_check_psymtabs): Use all_objfiles.
16564         (ALL_PSYMTABS): Remove.
16565         * compile/compile-object-run.c (do_module_cleanup): Use
16566         all_objfiles.
16567         * blockframe.c (find_pc_partial_function): Use all_objfiles.
16568         * cp-support.c (add_symbol_overload_list_qualified): Use
16569         all_objfiles.
16570         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
16571         Use all_objfiles.
16572         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
16573         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
16574         all_objfiles.
16575         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
16576         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
16577         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
16578         Uses all_objfiles.
16579         * solib.c (solib_read_symbols): Use all_objfiles
16580
16581 2019-01-09  Tom Tromey  <tom@tromey.com>
16582
16583         * probe.c (parse_probes_in_pspace): Use all_objfiles.
16584         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
16585         all_objfiles.
16586         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
16587         * symmisc.c (print_symbol_bcache_statistics)
16588         (print_objfile_statistics, maintenance_print_objfiles)
16589         (maintenance_info_symtabs, maintenance_check_symtabs)
16590         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
16591         all_objfiles.
16592         * source.c (forget_cached_source_info): Use all_objfiles.
16593         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
16594         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
16595         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
16596         * objfiles.c (update_section_map): Use all_objfiles.
16597         (shared_objfile_contains_address_p): Likewise.
16598         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
16599         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
16600
16601 2019-01-09  Tom Tromey  <tom@tromey.com>
16602
16603         * common/next-iterator.h: New file.
16604         * objfiles.h (class all_objfiles): New.
16605         (struct objfile_iterator): New.
16606
16607 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
16608
16609         * NEWS: Move the description of the changed "frame", "select-frame",
16610          and "info frame" commands to the Changed commands section.
16611
16612 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
16613
16614         * gdbtypes.c (check_stub_method_group): Remove handling of old
16615         mangling schemes.
16616         * linespec.c (find_methods): Likewise.
16617         * stabsread.c (read_member_functions): Likewise.
16618         * valops.c (search_struct_method): Likewise.
16619         (value_struct_elt_for_reference): Likewise.
16620         * NEWS: Mention this change.
16621
16622 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
16623
16624         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
16625         print_source_lines.
16626         * source.c (print_source_lines_base): Update line number check.
16627         (print_source_lines): New function.
16628         (source_lines_range::source_lines_range): New function.
16629         * source.h (class source_lines_range): New class.
16630         (print_source_lines): New declaration.
16631
16632 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
16633
16634         * linespec.c (linespec_state_destructor): Free self->canonical_names.
16635
16636 2019-01-08  Tom Tromey  <tom@tromey.com>
16637             Simon Marchi  <simon.marchi@ericsson.com>
16638
16639         PR gdb/24060
16640         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
16641         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
16642         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
16643         * f-exp.y (DOLLAR_VARIABLE): Likewise.
16644         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
16645         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
16646
16647 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
16648
16649         * source.c (select_source_symtab): Move header comment to
16650         declaration in source.h.
16651         (forget_cached_source_info_for_objfile): Likewise.
16652         (forget_cached_source_info): Likewise.
16653         (identify_source_line): Likewise.
16654         * source.h (identify_source_line): Move declaration from symtab.h
16655         and add comment from source.c
16656         (print_source_lines): Likewise.
16657         (forget_cached_source_info_for_objfile): Likewise.
16658         (forget_cached_source_info): Likewise.
16659         (select_source_symtab): Likewise.
16660         (enum print_source_lines_flag): Move definition from symtab.h.
16661         * symtab.h (identify_source_line): Move declaration to source.h.
16662         (print_source_lines): Likewise.
16663         (forget_cached_source_info_for_objfile): Likewise.
16664         (forget_cached_source_info): Likewise.
16665         (select_source_symtab): Likewise.
16666         (enum print_source_lines_flag): Move definition to source.h.
16667         * tui/tui-hooks.c: Add 'source.h' include.
16668
16669 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
16670
16671         * source.c (print_source_lines_base): Handle requests to print
16672         reverse line number sequences, and guard against empty lines
16673         string.
16674
16675 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
16676
16677         * source.c (print_source_lines_base): Fix skip of '\r' if next
16678         character is '\n'.
16679
16680 2019-01-06  Tom Tromey  <tom@tromey.com>
16681
16682         * c-exp.y (struct c_parse_state) <macro_original_text,
16683         expansion_obstack>: New member.
16684         (macro_original_text, expansion_obstack): Remove globals.
16685         (scan_macro_expansion, scanning_macro_expansion)
16686         (finished_macro_expansion): Update.
16687         (scan_macro_cleanup): Remove.
16688         (yylex, c_parse): Update.
16689
16690 2019-01-06  Tom Tromey  <tom@tromey.com>
16691
16692         * c-exp.y (struct c_parse_state) <strings>: New member.
16693         (operator_stoken): Update.
16694
16695 2019-01-06  Tom Tromey  <tom@tromey.com>
16696
16697         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
16698         (union type_stack_elt) <typelist_val>: Now a pointer to
16699         std::vector.
16700         (type_stack_cleanup): Don't declare.
16701         (push_typelist): Update.
16702         * parse.c (pop_typelist): Return a std::vector.
16703         (push_typelist): Take a std::vector.
16704         (follow_types): Update.  Do not free args.
16705         (type_stack_cleanup): Remove.
16706         * c-exp.y (struct c_parse_state): New.
16707         (cpstate): New global.
16708         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
16709         (nonempty_typelist): Update.
16710         (func_mod): Create a new vector.
16711         (c_parse): Create a c_parse_state.
16712         (check_parameter_typelist): Do not delete params.
16713         (function_method): Update.  Do not delete type_list.
16714
16715 2019-01-06  Tom Tromey  <tom@tromey.com>
16716
16717         PR gdb/28155:
16718         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
16719         check_typedef.
16720         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
16721         (print_return_value): Likewise.
16722
16723 2019-01-05  Tom Tromey  <tom@tromey.com>
16724
16725         * contrib/cleanup_check.py: Remove.
16726         * contrib/gcc-with-excheck: Remove.
16727         * contrib/exsummary.py: Remove.
16728         * contrib/excheck.py: Remove.
16729
16730 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
16731
16732         * thread.c (delete_thread_1): Add gdb_assert that THR is not
16733         NULL. Initialize tpprev to NULL instead of assigning it
16734         to NULL on the next statement.
16735         * windows-nat.c (windows_delete_thread): Remove check for
16736         main_thread_id before printing thread exit notifications.
16737         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
16738         Remove thread ID check against main_thread_id.
16739         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
16740         windows_delete_thread.
16741         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
16742
16743 2019-01-04  Tom Tromey  <tom@tromey.com>
16744
16745         * compile/compile.c (_initialize_compile): Use upper case for
16746         metasyntactic variables.
16747         * symmisc.c (_initialize_symmisc): Use upper case for
16748         metasyntactic variables.
16749         * psymtab.c (_initialize_psymtab): Use upper case for
16750         metasyntactic variables.
16751         * demangle.c (demangle_command): Use upper case for metasyntactic
16752         variables.
16753         (_initialize_demangler): Likewise.
16754         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
16755         variables.
16756
16757 2019-01-03  Tom Tromey  <tom@tromey.com>
16758
16759         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
16760
16761 2019-01-03  Tom Tromey  <tom@tromey.com>
16762
16763         * python/py-symtab.c (salpy_str): Update.
16764         (struct salpy_sal_object) <symtab>: Now a PyObject.
16765         (salpy_dealloc): Update.
16766         (del_objfile_sal): Use gdbpy_ref.
16767
16768 2019-01-03  Tom Tromey  <tom@tromey.com>
16769
16770         * python/py-type.c (convert_field): Use new_reference.  Return
16771         gdbpy_ref.
16772         (make_fielditem): Return gdbpy_ref.
16773         (typy_fields): Update.
16774         (typy_getitem): Update.
16775         (field_name): Return gdbpy_ref.  Use new_reference.
16776         (typy_iterator_iternext): Update.
16777
16778 2019-01-03  Tom Tromey  <tom@tromey.com>
16779
16780         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
16781
16782 2019-01-03  Tom Tromey  <tom@tromey.com>
16783
16784         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
16785         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
16786         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
16787         (pspy_set_frame_filters, pspy_set_frame_unwinders)
16788         (pspy_set_type_printers): Likewise.
16789         * python/py-function.c (fnpy_init): Use gdbpy_ref.
16790         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
16791         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
16792         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
16793         (objfpy_set_type_printers): Likewise.
16794
16795 2019-01-03  Tom Tromey  <tom@tromey.com>
16796
16797         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
16798         (gdbpy_print_stack): Use gdbpy_err_fetch.
16799         * python/python-internal.h (class gdbpy_err_fetch): New class.
16800         (class gdbpy_enter) <m_error_type, m_error_value,
16801         m_error_traceback>: Remove.
16802         <m_error>: New member.
16803         (gdbpy_exception_to_string): Don't declare.
16804         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
16805         * python/py-value.c (convert_value_from_python): Use
16806         gdbpy_err_fetch.
16807         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
16808         gdbpy_exception_to_string.
16809         (gdbpy_handle_exception): Use gdbpy_err_fetch.
16810         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
16811         gdbpy_err_fetch.
16812
16813 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
16814
16815         * linux-nat.c (delete_lwp_cleanup): Delete.
16816         (struct lwp_deleter): New struct.
16817         (lwp_info_up): New typedef.
16818         (linux_nat_target::follow_fork): Delete cleanup, and make use of
16819         lwp_info_up.
16820
16821 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
16822
16823         * linux-fork.c (class scoped_switch_fork_info): New class.
16824         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
16825
16826 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
16827
16828         * valops.c (find_overload_match): Remove use of null_cleanup, and
16829         calls to do_cleanups.
16830
16831 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
16832
16833         * compile/compile-cplus-types.c
16834         (compile_cplus_instance::decl_name): Handle changes to
16835         cp_func_name.
16836         * cp-support.c (cp_func_name): Update header comment, update
16837         return type.
16838         * cp-support.h (cp_func_name): Update return type in declaration.
16839         * valops.c (find_overload_match): Move temp_func local to top
16840         level of function and change its type.  Use temp_func to hold and
16841         delete temporary string obtained from cp_func_name.
16842
16843 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
16844
16845         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
16846         gdb::char_vector, remove cleanup, and update uses of `msg`.
16847
16848 2019-01-03  Jim Wilson  <jimw@sifive.com>
16849
16850         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
16851
16852 2019-01-02  Tom Tromey  <tom@tromey.com>
16853
16854         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
16855         (tdesc_parse_xml): Remove cleanups.
16856         * target-descriptions.h (make_cleanup_free_target_description):
16857         Don't declare.
16858         (target_desc_deleter): New struct.
16859         (target_desc_up): New typedef.
16860         * target-descriptions.c (target_desc_deleter::operator()): Rename
16861         from free_target_description.
16862         (make_cleanup_free_target_description): Remove.
16863
16864 2019-01-02  Tom Tromey  <tom@tromey.com>
16865
16866         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
16867         constructor, destructor.
16868         (linespec_parser): Remove typedef.
16869         (~linespec_parser): Rename from linespec_parser_delete.
16870         (linespec_lex_to_end, linespec_complete_label)
16871         (linespec_complete): Update.
16872         (decode_line_full): Remove cleanups.
16873         (decode_line_1): Update.
16874
16875 2019-01-02  Tom Tromey  <tom@tromey.com>
16876
16877         * python/python-internal.h (inferior_to_inferior_object): Change
16878         return type.
16879         * python/py-exitedevent.c (create_exited_event_object): Update.
16880         * python/py-inferior.c (inferior_to_inferior_object): Return
16881         gdbpy_ref.
16882         (python_new_inferior, python_inferior_deleted)
16883         (thread_to_thread_object, delete_thread_object)
16884         (build_inferior_list, gdbpy_selected_inferior): Update.
16885         * python/py-infthread.c (create_thread_object): Update.  Also fail
16886         if inferior_to_inferior_object fails.
16887
16888 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
16889
16890         * inferior.h (class inferior) <displaced_step_state>: New field.
16891         * infrun.h (struct displaced_step_state): Move here from
16892         infrun.c.  Initialize fields, add constructor.
16893         <inf>: Remove field.
16894         <reset>: New method.
16895         * infrun.c (struct displaced_step_inferior_state): Move to
16896         infrun.h.
16897         (displaced_step_inferior_states): Remove.
16898         (get_displaced_stepping_state): Adust.
16899         (displaced_step_in_progress_any_inferior): Adjust.
16900         (displaced_step_in_progress_thread): Adjust.
16901         (displaced_step_in_progress): Adjust.
16902         (add_displaced_stepping_state): Remove.
16903         (get_displaced_step_closure_by_addr): Adjust.
16904         (remove_displaced_stepping_state): Remove.
16905         (infrun_inferior_exit): Call displaced_step_state.reset.
16906         (use_displaced_stepping): Don't check for NULL.
16907         (displaced_step_prepare_throw): Call
16908         get_displaced_stepping_state.
16909         (displaced_step_fixup): Don't check for NULL.
16910         (prepare_for_detach): Don't check for NULL.
16911
16912 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
16913
16914         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
16915          in case of call that did not complete.
16916
16917 2019-01-02  Andrey Utkin  <autkin@undo.io>
16918
16919         * symfile.c (find_separate_debug_file): Fix search of debug files for
16920         remote debuggee.
16921
16922 2019-01-02  Tom Tromey  <tom@tromey.com>
16923
16924         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
16925         indentation.
16926         * python/py-frame.c (frapy_older): Remove cast.
16927         (frapy_newer): Likewise.
16928         * python/py-breakpoint.c (local_setattro): Remove cast.
16929         * python/py-arch.c (archpy_name): Remove local variable.
16930         * python/py-type.c (gdbpy_lookup_type): Remove cast.
16931
16932 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
16933
16934         * unittests/basic_string_view/element_access/char/empty.cc:
16935         Fix year range in copyright header.
16936
16937 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
16938
16939         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
16940         Delete.
16941         <operator==>: Update with for removed field.
16942         <hash>: Likewise.
16943         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
16944         <isa_features>: ...this.
16945         <abi_features>: New field.
16946         (riscv_isa_flen): Update comment.
16947         (riscv_abi_xlen): New declaration.
16948         (riscv_abi_flen): New declaration.
16949         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
16950         isa_features.
16951         (riscv_abi_xlen): New function.
16952         (riscv_isa_flen): Update to get answer from isa_features.
16953         (riscv_abi_flen): New function.
16954         (riscv_has_fp_abi): Update to get answer from abi_features.
16955         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
16956         xlen and flen.
16957         (riscv_call_info) <xlen, flen>: Update comment.
16958         (riscv_call_arg_struct): Remove invalid assertions
16959         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
16960         is removed.
16961         (riscv_gdbarch_init): Gather isa features and abi features
16962         separately, ensure both match on the gdbarch when reusing an old
16963         gdbarch.  Relax an error check to allow 32-bit abi float to run on
16964         a target with 64-bit float hardware.
16965
16966 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
16967
16968         * source.c (search_command_helper): Stop reverse search
16969         when line 1 has been searched.
16970
16971 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
16972
16973         * record-full.c (record_full_base_target::close): Rewrite
16974         record_full_core_buf_list free logic.
16975
16976 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
16977
16978         * break-catch-syscall.c (print_one_catch_syscall): xfree
16979         the last text.
16980
16981 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
16982
16983         * top.c (print_gdb_version): Update Copyright year in version
16984         message.
16985
16986 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
16987
16988         Update copyright year range in all GDB files.
16989
16990 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
16991
16992         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
16993
16994 For older changes see ChangeLog-2018.
16995 \f
16996 Local Variables:
16997 mode: change-log
16998 left-margin: 8
16999 fill-column: 74
17000 version-control: never
17001 coding: utf-8
17002 End:
17003