gdb/ChangeLog

   1 2019-08-30  Tom Tromey  <tom@tromey.com>
   2
   3         * tui/tui-regs.h (struct tui_data_window) <display_all_data>:
   4         Don't declare.
   5         * tui/tui-regs.c (tui_data_window::show_registers): Call
   6         rerender.
   7         (tui_data_window::rerender): Rename from display_all_data.
   8         (tui_data_window::rerender): Remove old implementation.
   9
  10 2019-08-30  Tom Tromey  <tom@tromey.com>
  11
  12         * tui/tui-regs.c (tui_data_window::display_all_data): Change
  13         text.
  14         * tui/tui-data.h (NO_DATA_STRING): Remove define.
  15
  16 2019-08-29  Bernhard Wodok  <barto@gmx.net>
  17             Sergio Durigan Junior  <sergiodj@redhat.com>
  18
  19         PR win32/24284
  20         * mingw-hdep.c (gdb_select): Handle case when 'n' is zero.
  21
  22 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
  23
  24         * symtab.c (search_symbols): Don't include MODULE_DOMAIN symbols
  25         when searching for types.
  26
  27 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
  28
  29         * f-lang.c (f_language_defn): Use f_print_typedef.
  30         * f-lang.h (f_print_typedef): Declare.
  31         * f-typeprint.c (f_print_typedef): Define.
  32
  33 2019-08-27  Christian Biesinger  <cbiesinger@google.com>
  34
  35         * nat/linux-namespaces.c (mnsh_main): Initialize fd (to -1).
  36
  37 2019-08-27  Andrew Burgess  <andrew.burgess@embecosm.com>
  38
  39         * cli/cli-utils.c (info_print_options_defs): Delete.
  40         (make_info_print_options_def_group): Delete.
  41         (extract_info_print_options): Delete.
  42         (info_print_command_completer): Delete.
  43         (info_print_args_help): Add extra parameter, and optionally
  44         include text about -n flag.
  45         * cli/cli-utils.h (struct info_print_options): Delete.
  46         (extract_info_print_options): Delete declaration.
  47         (info_print_command_completer): Delete declaration.
  48         (info_print_args_help): Add extra parameter, extend header
  49         comment.
  50         * python/python.c (gdbpy_rbreak): Pass additional parameter to
  51         search_symbols.
  52         * stack.c (struct info_print_options): New type.
  53         (info_print_options_defs): New file scoped variable.
  54         (make_info_print_options_def_group): New static function.
  55         (info_print_command_completer): New static function.
  56         (info_locals_command): Update to use new local functions.
  57         (info_args_command): Likewise.
  58         (_initialize_stack): Add extra parameter to calls to
  59         info_print_args_help.
  60         * symtab.c (search_symbols): Add extra parameter, use this to
  61         possibly excluse non-debug symbols.
  62         (symtab_symbol_info): Add extra parameter, which is passed on to
  63         search_symbols.
  64         (struct info_print_options): New type.
  65         (info_print_options_defs): New file scoped variable.
  66         (make_info_print_options_def_group): New static function.
  67         (info_print_command_completer): New static function.
  68         (info_variables_command): Update to use local functions, and pass
  69         extra parameter through to symtab_symbol_info.
  70         (info_functions_command): Likewise.
  71         (info_types_command): Pass additional argument through to
  72         symtab_symbol_info.
  73         (rbreak_command): Pass extra argument to search_symbols.
  74         (_initialize_symtab): Add extra arguments for calls to
  75         info_print_args_help, and update help text for 'info variables',
  76         'whereis', and 'info functions' commands.
  77         * symtab.h (search_symbols): Add extra argument to declaration.
  78         * NEWS: Mention new flags.
  79
  80 2019-08-26  Christian Biesinger  <cbiesinger@google.com>
  81
  82         * symtab.c (lookup_static_symbol): Call the new function (and move
  83         it down to be next to lookup_global_symbol).
  84         (struct global_sym_lookup_data): Add block_enum member and rename to...
  85         (struct global_or_static_sym_lookup_data): ...this.
  86         (lookup_symbol_global_iterator_cb): Pass block_index instead of
  87         GLOBAL_BLOCK to lookup_symbol_in_objfile and rename to...
  88         (lookup_symbol_global_or_static_iterator_cb): ...this.
  89         (lookup_global_or_static_symbol): New function.
  90         (lookup_global_symbol): Call new function.
  91
  92 2019-08-26  Tom de Vries  <tdevries@suse.de>
  93
  94         PR c++/24852
  95         * break-catch-throw.c (fetch_probe_arguments): Improve error mesage
  96         when pc_probe.prob == NULL.
  97
  98 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
  99
 100         * dwarf2read.c (dw2_debug_names_iterator::next): Rename local
 101         variable symbol_linkage to symbol_linkage_.
 102
 103 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
 104
 105         * dwarf2read.c (dw2_debug_names_iterator::next): Use enum to
 106         represent whether the symbol is static, dynamic, or we don't
 107         know.
 108
 109 2019-08-25  Yoshinori Sato <ysato@users.sourceforge.jp>
 110
 111         * gdb/rx-tdep.c (rx_register_names): New.
 112         (rx_register_name): Delete.
 113         (rx_psw_type): Delete.
 114         (rx_fpsw_type): Delete.
 115         (rx_register_type): Delete.
 116         (rx_gdbarch_init): Convert target-descriptions.
 117         (_initialize_rx_tdep): Add initialize_tdesc_rx.
 118         * gdb/features/Makefile: Add rx.xml.
 119         * gdb/features/rx.xml: New.
 120         * gdb/features/rx.c: Generated.
 121         * gdb/NEWS: Mention target description support.
 122
 123 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
 124
 125         * symtab.c (symbol_cache_lookup): Always initialize *bsc_ptr and
 126         *slot_ptr.
 127
 128 2019-08-23  Sergio Durigan Junior  <sergiodj@redhat.com>
 129
 130         * configure.ac: Don't check for 'dlfcn.h' (moved to
 131         gdbsupport/common.m4).
 132         * Makefile.in (COMMON_SFILES): Move 'gdb-dlfcn.c' to
 133         'gdbsupport/'.
 134         (HFILES_NO_SRCDIR): Likewise, for 'gdb-dlfcn.h'.
 135         * compile/compile-c-support.c: Include
 136         'gdbsupport/gdb-dlfcn.h'.
 137         * gdbsupport/common.m4: Check for 'dlfcn.h'.
 138         * gdb-dlfcn.c: Move to...
 139         * gdbsupport/gdb-dlfcn.c: ... here.
 140         * gdb-dlfcn.h: Move to...
 141         * gdbsupport/gdb-dlfcn.h: ... here.
 142
 143 2019-08-23  Sandra Loosemore  <sandra@codesourcery.com>
 144
 145         * nios2-tdep.c (struct reg_value): Improve comments.  Make
 146         the offset field signed.
 147
 148 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
 149
 150         * python/lib/gdb/__init__.py (_execute_file): New function.
 151         * python/python.c (python_run_simple_file): Call gdb._execute_file
 152         on Windows.
 153
 154 2019-08-22  Andrew Burgess  <andrew.burgess@embecosm.com>
 155
 156         * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
 157         all uses as this was never set to anything but a zero value.
 158
 159 2019-08-21  Bogdan Harjoc  <harjoc@gmail.com>
 160
 161         * cli/cli-cmds.c (with_command_1): Error out if no arguments.
 162
 163 2019-08-21  Christian Biesinger  <cbiesinger@google.com>
 164
 165         * tui/tui-data.h (tui_gen_win_info): Add an =default
 166         move constructor, required by some GCC versions.
 167
 168 2019-08-21  Jinke Fan  <fanjinke51@yeah.net>
 169
 170         * go32-nat.c (go32_sysinfo): Add hygon_p.
 171
 172 2019-08-20  Tom Tromey  <tom@tromey.com>
 173
 174         * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
 175         line_from_reg_element_no, first_reg_element_no_inline,
 176         display_all_data, delete_data_content_windows,
 177         erase_data_content>: Now private.
 178
 179 2019-08-20  Tom Tromey  <tom@tromey.com>
 180
 181         * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
 182         (tui_unhighlight_win, tui_highlight_win)
 183         (tui_win_info::make_window): Update.
 184         * tui/tui-data.h (HILITE, NO_HILITE): Remove.
 185
 186 2019-08-20  Tom Tromey  <tom@tromey.com>
 187
 188         * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
 189         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
 190         (MAX_PID_WIDTH): Move to tui-stack.c.
 191         * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
 192         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
 193         (MAX_PID_WIDTH): Move from tui-data.h.
 194
 195 2019-08-20  Tom Tromey  <tom@tromey.com>
 196
 197         * tui/tui-wingeneral.h (tui_make_window): Don't declare.
 198         * tui/tui-wingeneral.c (box_win): Change type of win_info.
 199         (box_win): Update.
 200         (tui_gen_win_info::make_window): Rename from tui_make_window.
 201         (tui_win_info::make_window): New method.
 202         (tui_gen_win_info::make_visible): Update.
 203         * tui/tui-source.c (tui_source_window::set_contents): Update.
 204         * tui/tui-regs.c (tui_data_window::show_register_group): Update.
 205         (tui_data_window::display_registers_from): Update.
 206         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
 207         * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
 208         Declare.
 209         <can_box>: Remove.
 210         <title>: Remove.
 211         (struct tui_win_info) <make_window>: Declare.
 212         <can_box>: Now virtual.
 213         <title>: New member.
 214         * tui/tui-data.c (~tui_gen_win_info): Don't free title.
 215         * tui/tui-command.c (tui_cmd_window::resize): Update.
 216
 217 2019-08-20  Tom Tromey  <tom@tromey.com>
 218
 219         * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
 220         * tui/tui-regs.c (tui_data_window::show_registers): Update.
 221         (tui_data_window::check_register_values): Update.
 222
 223 2019-08-20  Tom Tromey  <tom@tromey.com>
 224
 225         * tui/tui-regs.h (struct tui_data_window): Use
 226         DISABLE_COPY_AND_ASSIGN.
 227         <regs_content>: Change type, removing unique_ptr.
 228         <tui_data_window>: Add move constructor.
 229         * tui/tui-regs.c (tui_data_window::show_registers)
 230         (tui_data_window::show_register_group)
 231         (tui_data_window::display_registers_from)
 232         (tui_data_window::display_registers_from)
 233         (tui_data_window::first_data_item_displayed)
 234         (tui_data_window::delete_data_content_windows)
 235         (tui_data_window::rerender, tui_data_window::refresh_window)
 236         (tui_data_window::check_register_values): Update.
 237
 238 2019-08-20  Tom Tromey  <tom@tromey.com>
 239
 240         * tui/tui-regs.h (struct tui_data_window) <show_registers,
 241         show_register_group>: Declare.
 242         (tui_show_register_group): Don't declare.
 243         * tui/tui-regs.c (tui_data_window::show_registers): Rename from
 244         tui_show_registers.
 245         (tui_data_window::show_register_group): Rename from
 246         tui_show_register_group.
 247         (tui_data_window::check_register_values, tui_reg_command):
 248         Update.
 249         * tui/tui-layout.c (tui_set_layout): Update.
 250
 251 2019-08-20  Tom Tromey  <tom@tromey.com>
 252
 253         * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
 254         Declare.
 255         (tui_check_register_values): Don't declare.
 256         * tui/tui-regs.c (tui_data_window::check_register_values): Rename
 257         from tui_check_register_values.
 258         * tui/tui-hooks.c (tui_register_changed): Update.
 259
 260 2019-08-20  Tom Tromey  <tom@tromey.com>
 261
 262         * tui/tui-regs.c (tui_reg_layout): Move later.
 263         (tui_show_registers): Don't enable TUI mode or change layout.
 264
 265 2019-08-20  Tom Tromey  <tom@tromey.com>
 266
 267         * tui/tui-regs.h (struct tui_data_item_window)
 268         <~tui_data_item_window>: Remove.
 269         <content>: Now a unique_xmalloc_ptr.
 270         * tui/tui-regs.c (tui_register_format): Return a
 271         unique_xmalloc_ptr.
 272         (tui_get_register): Update.
 273         (~tui_data_item_window): Remove.
 274         (tui_data_window::display_registers_from, tui_display_register):
 275         Update.
 276         * tui/tui-io.h (tui_expand_tabs): Update.
 277         * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
 278         Remove "col" parameter.
 279
 280 2019-08-20  Tom Tromey  <tom@tromey.com>
 281
 282         * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
 283         field.
 284         * tui/tui-regs.c (~tui_data_item_window): Update.
 285
 286 2019-08-20  Tom Tromey  <tom@tromey.com>
 287
 288         * tui/tui-regs.c (tui_register_format, tui_get_register): Move
 289         earlier.
 290
 291 2019-08-20  Tom Tromey  <tom@tromey.com>
 292
 293         * tui/tui-regs.c (tui_reg_command): Remove NULL check.
 294
 295 2019-08-20  Tom Tromey  <tom@tromey.com>
 296
 297         * tui/tui-source.h (struct tui_source_window): Update.
 298         * tui/tui-regs.c (tui_show_registers): Update.
 299         * tui/tui-disasm.h (struct tui_disasm_window): Update.
 300         * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
 301         (NO_REGS_STRING): Remove defines.
 302
 303 2019-08-20  Conrad Meyer  <cem@FreeBSD.org>
 304
 305         * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
 306         unnecessary thread walk if remote doesn't support the packet.
 307
 308 2019-08-19  Tom Tromey  <tromey@adacore.com>
 309
 310         * python/py-value.c (value_has_field): Fix indentation.
 311
 312 2019-08-19  Tom Tromey  <tromey@adacore.com>
 313
 314         * printcmd.c (do_one_display, info_display_command): Update.
 315         * block.h (contained_in): Return bool.  Add allow_nested
 316         parameter.
 317         * block.c (contained_in): Return bool.  Add allow_nested
 318         parameter.
 319
 320 2019-08-19  Tom Tromey  <tom@tromey.com>
 321
 322         * configure: Rebuild.
 323         * configure.ac: Disallow the combination of -static-libstdc++ and
 324         source highlight.
 325         * source-cache.c (get_language_name): Handle rust.
 326         (source_cache::get_source_lines): Ignore highlighting exceptions.
 327
 328 2019-08-16  Tom Tromey  <tom@tromey.com>
 329
 330         * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
 331         * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
 332         (struct tui_source_window_base) <make_visible, refresh_window,
 333         resize>: Remove methods.
 334         <execution_info>: Remove field.
 335         * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
 336         (tui_show_source_line, tui_source_window_base)
 337         (~tui_source_window_base): Update.
 338         (tui_source_window_base::resize)
 339         (tui_source_window_base::make_visible)
 340         (tui_source_window_base::refresh_window): Remove.
 341         (tui_source_window_base::update_exec_info): Update.
 342         * tui/tui-source.c (tui_source_window::set_contents): Update.
 343         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
 344
 345 2019-08-16  Tom Tromey  <tom@tromey.com>
 346
 347         * tui/tui-hooks.c (tui_remove_hooks): Don't set
 348         deprecated_query_hook.
 349
 350 2019-08-16  Tom Tromey  <tom@tromey.com>
 351
 352         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
 353         (tui_update_source_windows_with_line): Update.
 354         * tui/tui-source.h (struct tui_source_window)
 355         <show_symtab_source>: Declare.
 356         (tui_show_symtab_source): Don't declare.
 357         * tui/tui-source.c (tui_show_symtab_source): Rename from
 358         tui_show_symtab_source.
 359
 360 2019-08-16  Tom Tromey  <tom@tromey.com>
 361
 362         * tui/tui-winsource.h (struct tui_source_window_base)
 363         <set_contents>: Declare.
 364         * tui/tui-winsource.c
 365         (tui_source_window_base::update_source_window_as_is): Update.
 366         * tui/tui-source.h (struct tui_source_window) <set_contents>:
 367         Declare.
 368         (tui_set_source_content): Don't declare.
 369         * tui/tui-source.c (tui_source_window::set_contents): Rename from
 370         tui_set_source_content.
 371         * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
 372         Declare.
 373         (tui_set_disassem_content): Don't declare.
 374         * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
 375         tui_set_disassem_content.
 376
 377 2019-08-16  Tom Tromey  <tom@tromey.com>
 378
 379         * tui/tui-winsource.h (struct tui_source_window_base)
 380         <update_breakpoint_info>: Declare.
 381         (tui_update_breakpoint_info): Don't declare.
 382         * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
 383         (tui_update_all_breakpoint_info): Update.
 384         (tui_source_window_base::update_breakpoint_info): Rename from
 385         tui_update_breakpoint_info.
 386         (tui_source_window_base::update_exec_info): Update.
 387
 388 2019-08-16  Tom Tromey  <tom@tromey.com>
 389
 390         * tui/tui-winsource.h (struct tui_source_window_base)
 391         <update_source_window>: Declare.
 392         (tui_update_source_window): Don't declare.
 393         * tui/tui-winsource.c
 394         (tui_source_window_base::update_source_window): Rename from
 395         tui_update_source_window.
 396         (tui_source_window_base::rerender): Update.
 397         * tui/tui-source.c (tui_source_window::maybe_update): Update.
 398         * tui/tui-disasm.c (tui_show_disassem)
 399         (tui_show_disassem_and_update_source)
 400         (tui_disasm_window::maybe_update): Update.
 401
 402 2019-08-16  Tom Tromey  <tom@tromey.com>
 403
 404         * tui/tui-winsource.h (struct tui_source_window_base)
 405         <update_source_window_as_is>: Declare.
 406         (tui_update_source_window_as_is): Don't declare.
 407         * tui/tui-winsource.c (tui_update_source_window): Update
 408         (tui_source_window_base::update_source_window_as_is): Rename from
 409         tui_update_source_window_as_is.
 410         (tui_source_window_base::refill): Update.
 411         * tui/tui-source.c (tui_show_symtab_source): Update.
 412         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
 413         Update.
 414
 415 2019-08-16  Tom Tromey  <tom@tromey.com>
 416
 417         * tui/tui-winsource.h (tui_update_source_window)
 418         (tui_update_source_window_as_is): Remove "noerror" parameter.
 419         * tui/tui-winsource.c (tui_update_source_window)
 420         (tui_update_source_window_as_is): Remove "noerror" parameter.
 421         (tui_update_source_windows_with_addr)
 422         (tui_update_source_windows_with_line)
 423         (tui_source_window_base::rerender)
 424         (tui_source_window_base::refill): Update.
 425         * tui/tui-source.h (tui_set_source_content)
 426         (tui_show_symtab_source): Remove "noerror" parameter.
 427         * tui/tui-source.c (tui_set_source_content): Remove "noerror"
 428         parameter.
 429         (tui_show_symtab_source): Likewise.
 430         (tui_source_window::maybe_update): Update.
 431         * tui/tui-disasm.c (tui_show_disassem)
 432         (tui_show_disassem_and_update_source)
 433         (tui_disasm_window::do_scroll_vertical)
 434         (tui_disasm_window::maybe_update): Update.
 435
 436 2019-08-16  Tom Tromey  <tom@tromey.com>
 437
 438         * tui/tui.c (tui_is_window_visible): Update.
 439         * tui/tui-wingeneral.c (tui_make_window)
 440         (tui_gen_win_info::make_visible, tui_refresh_all): Update.
 441         * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
 442         (tui_set_focus_command, tui_all_windows_info, update_tab_width)
 443         (tui_set_win_height_command, parse_scrolling_args): Update.
 444         * tui/tui-source.c (tui_source_window::style_changed): Update.
 445         * tui/tui-regs.c (tui_show_registers)
 446         (tui_data_window::first_data_item_displayed)
 447         (tui_data_window::delete_data_content_windows)
 448         (tui_check_register_values, tui_reg_command): Update.
 449         * tui/tui-disasm.c (tui_show_disassem): Update.
 450         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
 451         method.
 452         <is_visible>: Remove field.
 453         * tui/tui-data.c (tui_next_win, tui_prev_win)
 454         (tui_delete_invisible_windows): Update.
 455
 456 2019-08-16  Tom Tromey  <tom@tromey.com>
 457
 458         * tui/tui-winsource.h (struct tui_source_window_base)
 459         <m_has_locator>: Remove.
 460         * tui/tui-layout.c (show_source_disasm_command, show_data)
 461         (show_source_or_disasm_and_command): Update.
 462
 463 2019-08-16  Alan Hayward  <alan.hayward@arm.com>
 464
 465         * NEWS (Other MI changes): New subsection.
 466         * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
 467         (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
 468         * arch-utils.c (default_get_pc_address_flags): New function.
 469         * arch-utils.h (default_get_pc_address_flags): New declaration.
 470         * gdbarch.sh: Add get_pc_address_flags.
 471         * gdbarch.c: Regenerate.
 472         * gdbarch.h: Likewise.
 473         * stack.c (print_pc): New function.
 474         (print_frame_info) (print_frame): Call print_pc.
 475
 476 2019-08-16  Tom de Vries  <tdevries@suse.de>
 477
 478         * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
 479         print_objfile_section_info.
 480
 481 2019-08-15  Tom Tromey  <tom@tromey.com>
 482
 483         * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
 484         calling update_cmdwin_start_line.
 485         * tui/tui-winsource.h (struct tui_source_window_base)
 486         <do_make_visible_with_new_height, set_new_height>: Don't declare.
 487         <rerender>: Declare.
 488         * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
 489         Call rerender.
 490         (tui_source_window_base::set_new_height): Remove.
 491         (tui_source_window_base::rerender): Rename from
 492         do_make_visible_with_new_height.
 493         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
 494         resize method.
 495         (tui_win_info::make_invisible_and_set_new_height)
 496         (tui_win_info::make_visible_with_new_height): Remove.
 497         * tui/tui-stack.h (struct tui_locator_window) <rerender>:
 498         Declare.
 499         * tui/tui-stack.c (tui_locator_window::rerender): New method.
 500         * tui/tui-regs.h (struct tui_data_window) <set_new_height,
 501         do_make_visible_with_new_height>: Don't declare.
 502         <rerender>: Declare.
 503         * tui/tui-regs.c (tui_data_window::rerender): Rename from
 504         set_new_height.
 505         (tui_data_window::do_make_visible_with_new_height): Remove.
 506         * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
 507         call tui_show_locator_content.
 508         (tui_gen_win_info::resize): Call rerender.
 509         (show_source_or_disasm_and_command): Don't call
 510         tui_show_locator_content.
 511         * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
 512         method.
 513         (struct tui_win_info) <rerender>: Declare.
 514         <set_new_height, make_invisible_and_set_new_height,
 515         make_visible_with_new_height>: Don't declare.
 516         * tui/tui-data.c (tui_win_list::rerender): New method.
 517         * tui/tui-command.h (struct tui_cmd_window)
 518         <do_make_visible_with_new_height>: Don't declare.
 519         * tui/tui-command.c
 520         (tui_cmd_window::do_make_visible_with_new_height): Remove.
 521
 522 2019-08-15  Tom Tromey  <tromey@adacore.com>
 523
 524         * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
 525         * ada-lang.c (ada_enum_name): Likewise.
 526
 527 2019-08-15  Christian Biesinger  <cbiesinger@google.com>
 528
 529         * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
 530         leading underscore.
 531         (GdbOutputErrorFile): Likewise.
 532         (global scope): Adjust constructor calls to GdbOutput{,Error}File
 533         accordingly.
 534         (execute_unwinders): Rename to have a leading underscore.
 535         (auto_load_packages): Likewise.
 536         (global scope): Adjust call to auto_load_packages accordingly.
 537         (GdbSetPythonDirectory): Likewise.
 538         * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
 539         instead of execute_unwinders.
 540
 541 2019-08-15  Tom Tromey  <tom@tromey.com>
 542
 543         * tui/tui-layout.c (show_layout, show_source_disasm_command)
 544         (show_data): Don't change window visibility.
 545         (tui_gen_win_info::resize): Remove special case for command
 546         window.  Use wresize, when available.
 547         (show_source_or_disasm_and_command): Don't change window
 548         visibility.
 549         * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
 550         <make_visible>: New method.
 551         * tui/tui-command.c (tui_cmd_window::resize): New method.
 552
 553 2019-08-15  Tom Tromey  <tom@tromey.com>
 554
 555         * tui/tui-winsource.h (struct tui_source_window_iterator): New.
 556         (struct tui_source_windows): New.
 557         * tui/tui-winsource.c (tui_display_main): Update.
 558         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
 559         (new_height_ok, parse_scrolling_args): Update.
 560         * tui/tui-layout.c (show_layout, show_data): Update.
 561         * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
 562         (tui_add_to_source_windows): Don't declare.
 563         * tui/tui-data.c (source_windows, tui_source_windows)
 564         (tui_clear_source_windows, tui_add_to_source_windows): Remove.
 565
 566 2019-08-15  Tom Tromey  <tom@tromey.com>
 567
 568         * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
 569         Rename from reset.
 570         * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
 571         * tui/tui-layout.c (show_source_disasm_command, show_data):
 572         Update.
 573         (tui_gen_win_info::resize): Rename.
 574         (show_source_or_disasm_and_command): Update.
 575         * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
 576         reset.
 577
 578 2019-08-15  Tom Tromey  <tom@tromey.com>
 579
 580         * tui/tui-stack.c (tui_initialize_static_data): Remove.
 581         * tui/tui-interp.c (tui_interp::init): Don't call
 582         tui_initialize_static_data.
 583         * tui/tui-data.h (tui_initialize_static_data): Don't declare.
 584
 585 2019-08-15  Tom Tromey  <tom@tromey.com>
 586
 587         * tui/tui-layout.c (tui_default_win_viewport_height): Don't
 588         examine tui_win_list.
 589
 590 2019-08-15  Tom Tromey  <tom@tromey.com>
 591
 592         * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
 593         * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
 594         tui_clear_source_content.
 595         (tui_clear_source_content): Remove.
 596         (tui_source_window_base::do_erase_source_content): Hoist call to
 597         content.clear().
 598         * tui/tui-stack.c (tui_show_frame_info): Don't call
 599         tui_clear_source_content.
 600
 601 2019-08-15  Tom Tromey  <tom@tromey.com>
 602
 603         * tui/tui-winsource.h (struct tui_source_window_base)
 604         <do_erase_source_content>: New method.
 605         <erase_source_content>: New method.
 606         (tui_erase_source_content): Don't declare.
 607         * tui/tui-winsource.c (tui_clear_source_content): Update.
 608         (tui_source_window_base::do_erase_source_content): Rename from
 609         tui_erase_source_content.
 610         (tui_source_window_base::show_source_content): Update.
 611         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
 612         * tui/tui-source.h (struct tui_source_window)
 613         <erase_source_content>: New method.
 614         * tui/tui-disasm.h (struct tui_disasm_window)
 615         <erase_source_content>: New method.
 616
 617 2019-08-15  Tom Tromey  <tom@tromey.com>
 618
 619         * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
 620         (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
 621         constructor.
 622         * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
 623         * tui/tui-source.c (tui_set_source_content): Update.
 624         * tui/tui-disasm.c (tui_set_disassem_content): Update.
 625
 626 2019-08-15  Tom Tromey  <tom@tromey.com>
 627
 628         * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
 629         * tui/tui-winsource.c (tui_line_is_displayed): Move to
 630         tui-source.c.
 631         * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
 632         Declare.
 633         * tui/tui-source.c (tui_source_window::line_is_displayed): New
 634         method.
 635         (tui_source_window::maybe_update): Update.
 636
 637 2019-08-15  Tom Tromey  <tom@tromey.com>
 638
 639         * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
 640         * tui/tui-winsource.c (tui_addr_is_displayed): Move to
 641         tui-disasm.c.
 642         * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
 643         Declare.
 644         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
 645         method.
 646         (tui_disasm_window::maybe_update): Update.
 647
 648 2019-08-15  Tom Tromey  <tom@tromey.com>
 649
 650         * tui/tui-winsource.h (struct tui_source_window_base)
 651         <maybe_update>: Declare.
 652         * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
 653         method.
 654         * tui/tui-source.h (struct tui_source_window) <maybe_update>:
 655         Declare.
 656         * tui/tui-source.c (tui_source_window::maybe_update): New method.
 657         * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
 658         Declare.
 659         * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
 660
 661 2019-08-15  Tom Tromey  <tom@tromey.com>
 662
 663         * tui/tui-stack.c (tui_make_status_line): Use string constructor.
 664
 665 2019-08-15  Tom Tromey  <tom@tromey.com>
 666
 667         * tui/tui-wingeneral.c: Include tui-stack.h.
 668         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
 669         (struct tui_locator_window): Move from tui-data.h.
 670         * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
 671         (tui_initialize_static_data): Move from tui-data.c.
 672         * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
 673         (struct tui_locator_window): Move to tui-stack.c.
 674         * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
 675         (tui_initialize_static_data): Move to tui-stack.c.
 676
 677 2019-08-15  Tom Tromey  <tom@tromey.com>
 678
 679         * tui/tui-layout.c (show_source_disasm_command)
 680         (show_source_or_disasm_and_command): Use make_visible method, not
 681         tui_make_window.
 682         * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
 683         Remove.
 684
 685 2019-08-15  Tom Tromey  <tom@tromey.com>
 686
 687         * tui/tui-wingeneral.h (tui_make_window): Update.
 688         * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
 689         parameter.
 690         (tui_gen_win_info::make_visible): Update.
 691         * tui/tui-regs.c (tui_data_window::display_registers_from):
 692         Update.
 693         * tui/tui-layout.c (show_source_disasm_command)
 694         (show_source_or_disasm_and_command): Update.
 695         * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
 696         (enum tui_box): Remove.
 697         (struct tui_win_info) <can_box>: New method.
 698         * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
 699         method.
 700
 701 2019-08-15  Tom de Vries  <tdevries@suse.de>
 702
 703         * linux-nat-trad.c: Include gdbarch.h.
 704
 705 2019-08-14  Alan Hayward  <alan.hayward@arm.com>
 706
 707         * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
 708         register sizes.
 709
 710 2019-08-14  Tom Tromey  <tromey@adacore.com>
 711
 712         * darwin-nat.c: Include gdbarch.h.
 713         * darwin-nat-info.c: Include gdbarch.h.
 714
 715 2019-08-13  Tom Tromey  <tom@tromey.com>
 716
 717         * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
 718         Remove.
 719         * tui/tui-data.c (tui_initialize_static_data): Update.
 720
 721 2019-08-13  Tom Tromey  <tom@tromey.com>
 722
 723         * tui/tui-winsource.h (struct tui_exec_info_window)
 724         <~tui_exec_info_window, maybe_allocate_content, get_content,
 725         m_content>: Remove.
 726         (struct tui_source_window_base) <set_exec_info_content,
 727         show_exec_info_content>: Don't declare.
 728         * tui/tui-winsource.c
 729         (tui_exec_info_window::maybe_allocate_content): Remove.
 730         (tui_source_window_base::update_exec_info): Rename from
 731         set_exec_info_content.
 732         (tui_source_window_base::show_exec_info_content)
 733         (tui_source_window_base::update_exec_info): Remove.
 734
 735 2019-08-13  Tom Tromey  <tom@tromey.com>
 736
 737         * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
 738         declare.
 739         * tui/tui-winsource.c (tui_update_source_window_as_is)
 740         (tui_update_source_windows_with_addr, tui_erase_source_content):
 741         Update.
 742         (tui_clear_exec_info_content): Remove.
 743
 744 2019-08-13  Tom Tromey  <tom@tromey.com>
 745
 746         * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
 747         declare.
 748         * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
 749         call tui_erase_exec_info_content.
 750         (tui_clear_exec_info_content): Rename from
 751         tui_erase_exec_info_content.
 752         (tui_clear_exec_info_content): Delete.
 753
 754 2019-08-13  Tom Tromey  <tom@tromey.com>
 755
 756         * tui/tui-winsource.h (struct tui_source_window_base)
 757         <show_exec_info_content>: Declare.
 758         (tui_show_exec_info_content): Don't declare.
 759         * tui/tui-winsource.c
 760         (tui_source_window_base::show_exec_info_content): Rename from
 761         tui_show_exec_info_content.
 762         (tui_source_window_base::update_exec_info): Update.
 763
 764 2019-08-13  Tom Tromey  <tom@tromey.com>
 765
 766         * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
 767         (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
 768         (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
 769         * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
 770         tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
 771         (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
 772         ... here.
 773
 774 2019-08-13  Tom Tromey  <tom@tromey.com>
 775
 776         * tui/tui-winsource.h (struct tui_source_window_base)
 777         <update_exec_info>: Declare.
 778         (tui_update_exec_info): Don't declare.
 779         * tui/tui-winsource.c (tui_update_source_window_as_is)
 780         (tui_source_window_base::refresh_all)
 781         (tui_update_all_breakpoint_info): Update.
 782         (tui_source_window_base::update_exec_info): Rename from
 783         tui_update_exec_info.
 784         * tui/tui-stack.c (tui_show_frame_info): Update.
 785
 786 2019-08-13  Tom Tromey  <tom@tromey.com>
 787
 788         * tui/tui-winsource.h (struct tui_source_window_base)
 789         <set_exec_info_content>: Declare.
 790         (tui_set_exec_info_content): Don't declare.
 791         * tui/tui-winsource.c
 792         (tui_source_window_base::set_exec_info_content): Rename from
 793         tui_set_exec_info_content.
 794         (tui_update_exec_info): Update.
 795
 796 2019-08-13  Tom Tromey  <tom@tromey.com>
 797
 798         * tui/tui-winsource.h (struct tui_source_window_base)
 799         <show_source_content>: Declare.
 800         (tui_show_source_content): Don't declare.
 801         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
 802         (tui_source_window_base::show_source_content): Rename from
 803         tui_show_source_content.
 804         (tui_source_window_base::refresh_all): Update.
 805         * tui/tui-layout.c (show_source_disasm_command)
 806         (show_source_or_disasm_and_command): Update.
 807
 808 2019-08-13  Tom Tromey  <tom@tromey.com>
 809
 810         * tui/tui-winsource.c (tui_erase_source_content)
 811         (tui_show_source_content, tui_source_window_base::refresh_all):
 812         Update.
 813         * tui/tui-wingeneral.h
 814         (tui_check_and_display_highlight_if_needed): Don't declare.
 815         * tui/tui-wingeneral.c
 816         (tui_win_info::check_and_display_highlight_if_needed): Rename from
 817         check_and_display_highlight_if_needed.
 818         * tui/tui-win.c (tui_rehighlight_all)
 819         (tui_win_info::make_visible_with_new_height): Update.
 820         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
 821         (tui_data_window::erase_data_content)
 822         (tui_data_window::display_all_data): Update.
 823         * tui/tui-data.h (struct tui_win_info)
 824         <check_and_display_highlight_if_needed>: Declare.
 825
 826 2019-08-13  Tom Tromey  <tom@tromey.com>
 827
 828         * tui/tui-win.c (tui_resize_all): Call
 829         tui_delete_invisible_windows.
 830         * tui/tui-layout.c (show_layout): Call
 831         tui_delete_invisible_windows.
 832         * tui/tui-data.h (tui_delete_invisible_windows): Declare.
 833         * tui/tui-data.c (tui_delete_invisible_windows): New function.
 834
 835 2019-08-13  Tom Tromey  <tom@tromey.com>
 836
 837         * tui/tui-disasm.c (tui_show_disassem): Add assertion.  Don't call
 838         tui_add_win_to_layout.
 839
 840 2019-08-13  Tom Tromey  <tom@tromey.com>
 841
 842         * tui/tui-layout.h (tui_default_win_height): Don't declare.
 843         * tui/tui-layout.c (tui_default_win_height): Now static.
 844
 845 2019-08-13  Tom Tromey  <tom@tromey.com>
 846
 847         * tui/tui-layout.c (show_layout): Unify all layout cases into a
 848         single switch.
 849         (show_source_disasm_command, show_source_or_disasm_and_command):
 850         Don't check current layout.
 851
 852 2019-08-13  Tom Tromey  <tom@tromey.com>
 853
 854         * tui/tui-wingeneral.c (make_all_visible): Remove.
 855         (tui_make_all_invisible): Simplify.
 856         * tui/tui-layout.c (tui_make_all_invisible): Move from
 857         tui-wingeneral.c; simplify.
 858         (show_layout): Hoist call to tui_make_all_invisible.
 859         (show_data): Don't call tui_make_all_invisible.
 860
 861 2019-08-13  Tom Tromey  <tom@tromey.com>
 862
 863         * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
 864         * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
 865
 866 2019-08-13  Tom Tromey  <tom@tromey.com>
 867
 868         * tui/tui-layout.c (current_layout, tui_current_layout): Move from
 869         tui-data.c.
 870         (show_source_disasm_command, show_data)
 871         (show_source_or_disasm_and_command): Don't use
 872         tui_set_current_layout_to.
 873         * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
 874         * tui/tui-data.c (current_layout, tui_current_layout): Move to
 875         tui-layout.c.
 876         (tui_set_current_layout_to): Remove.
 877
 878 2019-08-13  Tom Tromey  <tom@tromey.com>
 879
 880         * tui/tui-layout.c (tui_set_layout): Update.
 881         * tui/tui-data.h (struct tui_layout_def): Remove.
 882         (tui_layout_def): Don't declare.
 883         * tui/tui-data.c (layout_def): Remove.
 884         (tui_layout_def): Remove.
 885
 886 2019-08-13  Tom Tromey  <tom@tromey.com>
 887
 888         * tui/tui-winsource.h (struct tui_source_window_base)
 889         <clear_detail>: No longer "override".
 890         * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
 891         * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
 892         * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
 893         * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
 894         Remove.
 895         * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
 896
 897 2019-08-13  Tom Tromey  <tromey@adacore.com>
 898
 899         * tracepoint.c: Don't include readline.h or history.h.
 900
 901 2019-08-12  Tom Tromey  <tom@tromey.com>
 902
 903         * configure: Rebuild.
 904         * configure.ac: Check for readline 7.
 905         * NEWS: Mention readline 7 requirement.
 906         * README: Update.
 907
 908 2019-08-12  Tom Tromey  <tom@tromey.com>
 909
 910         * mingw-hdep.c (gdb_select): Remove readline hack.
 911
 912 2019-08-09  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
 913
 914         * blockframe.c (find_pc_partial_function): Set *block to nullptr
 915         when the function fails.
 916
 917 2019-08-09  Andreas Arnez  <arnez@linux.ibm.com>
 918
 919         * s390-tdep.c (s390_type_align): New function.
 920         (s390_gdbarch_init): Set it as type_align gdbarch method.
 921
 922 2019-08-09  Tom de Vries  <tdevries@suse.de>
 923
 924         PR gdb/24591
 925         * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
 926         pc_low with relocation offset.
 927
 928 2019-08-07  Tom Tromey  <tromey@adacore.com>
 929
 930         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
 931         (print_frame_args): Update.
 932         * python/py-framefilter.c (py_print_single_arg, enumerate_args):
 933         Update.
 934         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
 935         * frame.h (struct frame_arg): Add initializers.
 936         <error>: Now a unique_xmalloc_ptr.
 937
 938 2019-08-07  Alan Hayward  <alan.hayward@arm.com>
 939
 940         * NEWS: Expand the Pointer Authentication entry.
 941         * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
 942         (aarch64_frame_unmask_lr): ... to this.
 943         (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
 944         Call aarch64_frame_unmask_lr.
 945         * frame.c (struct frame_info): Add "masked" variable.
 946         (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
 947         (fprint_frame): Check for masked pc.
 948         * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
 949         declarations.
 950         * python/py-framefilter.c (py_print_frame): Check for masked pc.
 951         * stack.c (print_frame): Check for masked pc.
 952
 953 2019-08-06  Tom Tromey  <tom@tromey.com>
 954
 955         * stabsread.c (patch_block_stabs, read_one_struct_field)
 956         (read_enum_type): Use obstack_strndup.
 957         * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
 958         * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
 959         * dwarf2read.c (guess_full_die_structure_name)
 960         (anonymous_struct_prefix): Use obstack_strndup.
 961         * dbxread.c (cp_set_block_scope): Use obstack_strndup.
 962         * c-exp.y (yylex): Use obstack_strndup.
 963         * ada-exp.y (write_object_renaming, write_ambiguous_var)
 964         (write_var_or_type): Use obstack_strndup.
 965
 966 2019-08-06  Tom Tromey  <tom@tromey.com>
 967
 968         * symfile.c (reread_symbols): Use obstack_strdup.
 969         * stabsread.c (read_type): Use obstack_strdup.
 970         * gdb_obstack.h (obstack_strdup): New overload.
 971         * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
 972         (create_dwo_unit_in_dwp_v2, build_error_marker_type)
 973         (dwarf2_canonicalize_name): Use obstack_strdup.
 974         * dbxread.c (read_dbx_symtab): Use obstack_strdup.
 975         * cp-support.c (inspect_type, replace_typedefs_qualified_name):
 976         Use obstack_strdup.
 977
 978 2019-08-06  Tom Tromey  <tom@tromey.com>
 979
 980         * gdb_obstack.h (obstack_strdup): Define.
 981         * gdb_obstack.c (obstack_strdup): Don't define.
 982
 983 2019-08-06  Tom Tromey  <tom@tromey.com>
 984
 985         * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
 986         obstack_strdup.
 987         * typeprint.c (typedef_hash_table::find_global_typedef): Use
 988         obstack_strdup.
 989         * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
 990         * stabsread.c (common_block_start): Use obstack_strdup.
 991         * objfiles.c (set_objfile_main_name, objfile): Use
 992         obstack_strdup.
 993         * namespace.c (add_using_directive): Use obstack_strdup.
 994         * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
 995         * jit.c (finalize_symtab): Use obstack_strdup.
 996         * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
 997         (guess_partial_die_structure_name, partial_die_info::fixup)
 998         (dwarf2_name): Use obstack_strdup.
 999         * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
1000         obstack_strdup.
1001         * c-exp.y (scan_macro_expansion): Use obstack_strdup.
1002         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
1003         obstack_strdup.
1004         * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
1005
1006 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1007
1008         * unittests/help-doc-selftests.c: New file.
1009         * Makefile.in: Add the new file.
1010
1011 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1012
1013         * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
1014         * cli/cli-decode.c (print_doc_line): Likewise.  It now prints
1015         the full first line, except when FOR_VALUE_PREFIX.  In this case,
1016         the trailing '.' is not output, and the first character is uppercased.
1017         (print_help_for_command): Update call to print_doc_line.
1018         (print_doc_of_command): Likewise.
1019         * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
1020         * cli/cli-option.c (append_indented_doc): Do not append newline.
1021         (build_help_option): Append newline after first appended_indented_doc
1022         only if a second call is done.
1023         (build_help): Append 2 new lines before each option, except the first
1024         one.
1025         * compile/compile.c (_initialize_compile): Add new lines after
1026         %OPTIONS%, when not at the end of the help.
1027         Change help doc or code
1028         producing the help doc to respect the invariants.
1029         * maint-test-options.c (_initialize_maint_test_options): Likewise.
1030         Also removed the new line after 'Options:', as all other commands
1031         do not put an empty line between 'Options:' and the first option.
1032         * printcmd.c (_initialize_printcmd): Likewise.
1033         * stack.c (_initialize_stack): Likewise.
1034         * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
1035         incorrectly telling COMMAND is optional.
1036         * ada-lang.c (_initialize_ada_language): Change help doc or code
1037         producing the help doc to respect the invariants.
1038         * ada-tasks.c (_initialize_ada_tasks): Likewise.
1039         * breakpoint.c (_initialize_breakpoint): Likewise.
1040         * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
1041         * cli/cli-logging.c (_initialize_cli_logging): Likewise.
1042         * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
1043         * cli/cli-style.c (cli_style_option::add_setshow_commands,
1044         _initialize_cli_style): Likewise.
1045         * corelow.c (core_target_info): Likewise.
1046         * dwarf-index-cache.c (_initialize_index_cache): Likewise.
1047         * dwarf2read.c (_initialize_dwarf2_read): Likewise.
1048         * filesystem.c (_initialize_filesystem): Likewise.
1049         * frame.c (_initialize_frame): Likewise.
1050         * gnu-nat.c (add_task_commands): Likewise.
1051         * infcall.c (_initialize_infcall): Likewise.
1052         * infcmd.c (_initialize_infcmd): Likewise.
1053         * interps.c (_initialize_interpreter): Likewise.
1054         * language.c (_initialize_language): Likewise.
1055         * linux-fork.c (_initialize_linux_fork): Likewise.
1056         * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
1057         * maint.c (_initialize_maint_cmds): Likewise.
1058         * memattr.c (_initialize_mem): Likewise.
1059         * printcmd.c (_initialize_printcmd): Likewise.
1060         * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
1061         _RegEx): Likewise.
1062         * ravenscar-thread.c (_initialize_ravenscar): Likewise.
1063         * record-btrace.c (_initialize_record_btrace): Likewise.
1064         * record-full.c (_initialize_record_full): Likewise.
1065         * record.c (_initialize_record): Likewise.
1066         * regcache-dump.c (_initialize_regcache_dump): Likewise.
1067         * regcache.c (_initialize_regcache): Likewise.
1068         * remote.c (add_packet_config_cmd, init_remote_threadtests,
1069         _initialize_remote): Likewise.
1070         * ser-tcp.c (_initialize_ser_tcp): Likewise.
1071         * serial.c (_initialize_serial): Likewise.
1072         * skip.c (_initialize_step_skip): Likewise.
1073         * source.c (_initialize_source): Likewise.
1074         * stack.c (_initialize_stack): Likewise.
1075         * symfile.c (_initialize_symfile): Likewise.
1076         * symtab.c (_initialize_symtab): Likewise.
1077         * target-descriptions.c (_initialize_target_descriptions): Likewise.
1078         * top.c (init_main): Likewise.
1079         * tracefile-tfile.c (tfile_target_info): Likewise.
1080         * tracepoint.c (_initialize_tracepoint): Likewise.
1081         * tui/tui-win.c (_initialize_tui_win): Likewise.
1082         * utils.c (add_internal_problem_command): Likewise.
1083         * valprint.c (value_print_option_defs): Likewise.
1084
1085 2019-08-06  Frank Ch. Eigler  <fche@redhat.com>
1086
1087         PR build/24886
1088         * configure.ac: Drop enable-libmcheck support.
1089         * configure, config.in: Rebuild.
1090         * libmcheck.m4: Remove.
1091         * acinclude.m4: Don't include it.
1092         * Makefile.in: Don't distribute it.
1093         * top.c (print_gdb_configuration): Don't mention it.
1094
1095 2019-08-06  Tom Tromey  <tom@tromey.com>
1096
1097         * utils.c (set_output_style): Sometimes pass stream to
1098         emit_style_escape.
1099         * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
1100         * record-btrace.c (btrace_insn_history): Update.
1101         * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
1102         method.
1103         * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
1104         Update initializers.
1105         <m_uiout>: New field.
1106         <m_di>: Move lower.
1107         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
1108         Remove "uiout" parameter.
1109         (dump_insns): Update.
1110         * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
1111         * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
1112
1113 2019-08-06  Christian Biesinger  <cbiesinger@google.com>
1114
1115         * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
1116         (error_in_psymtab_expansion): Likewise.
1117         (lookup_symbol_via_quick_fns): Likewise.
1118         (basic_lookup_transparent_type_quick): Likewise.
1119         (basic_lookup_transparent_type_1): Likewise.
1120
1121 2019-08-06  Tom Tromey  <tromey@adacore.com>
1122
1123         * source.c (last_source_error): Now bool.
1124         (print_source_lines_base): Make "noprint" bool.  Only open
1125         source file when last_source_visited changes.
1126
1127 2019-08-06  Tom Tromey  <tromey@adacore.com>
1128
1129         * annotate.c (annotate_source_line): Use g_source_cache.
1130         * source-cache.c (source_cache::get_plain_source_lines): Change
1131         parameters.  Populate m_offset_cache.
1132         (source_cache::ensure): New method.
1133         (source_cache::get_line_charpos): New method.
1134         (extract_lines): Move lower.  Change parameters.
1135         (source_cache::get_source_lines): Move lower.
1136         * source-cache.h (class source_cache): Update comment.
1137         <get_line_charpos>: New method.
1138         <get_source_lines>: Update comment.
1139         <clear>: Clear m_offset_cache.
1140         <get_plain_source_lines>: Change parameters.
1141         <ensure>: New method
1142         <m_offset_cache>: New member.
1143         * source.c (forget_cached_source_info_for_objfile): Update.
1144         (info_source_command): Use g_source_cache.
1145         (find_source_lines, open_source_file_with_line_charpos): Remove.
1146         (print_source_lines_base, search_command_helper): Use g_source_cache.
1147         * source.h (open_source_file_with_line_charpos): Don't declare.
1148         * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
1149         * tui/tui-source.c (tui_source_window::do_scroll_vertical):
1150         Use g_source_cache.
1151
1152 2019-08-06  Tom Tromey  <tromey@adacore.com>
1153
1154         * source-cache.c (source_cache::get_plain_source_lines):
1155         Remove "first_line" and "last_line" parameters.
1156         (source_cache::get_source_lines): Cache plain text.
1157         * source-cache.h (class source_cache)
1158         <get_plain_source_lines>: Update.
1159
1160 2019-08-06  Tom Tromey  <tromey@adacore.com>
1161
1162         * source-cache.c (extract_lines): No longer a method.
1163         Changed type of parameter.  Include final newline.
1164         (selftests::extract_lines_test): New function.
1165         (_initialize_source_cache): Likewise.
1166         * source-cache.h (class source_cache)
1167         <extract_lines>: Don't declare.
1168
1169 2019-08-06  Tom Tromey  <tromey@adacore.com>
1170
1171         * breakpoint.c (init_breakpoint_sal): Update.
1172         (breakpoint): Update.
1173         * breakpoint.h (struct breakpoint) <filter>: Now a
1174         unique_xmalloc_ptr.
1175
1176 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
1177
1178         * NEWS: Mention dictionary access on blocks.
1179         * python/py-block.c (blpy_getitem): New function.
1180         (block_object_as_mapping): New struct.
1181         (block_object_type): Use new struct for tp_as_mapping field.
1182
1183 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
1184
1185         * objfiles.h (objfile): Add a comment describing partial symbols.
1186
1187 2019-08-05  Tom Tromey  <tromey@adacore.com>
1188
1189         * compile/compile.c (_initialize_compile): Use _(), not N_().
1190         * thread.c (_initialize_thread): Use _(), not N_().
1191         * stack.c (_initialize_stack): Use _(), not N_().
1192         * printcmd.c (_initialize_printcmd): Use _(), not N_().
1193
1194 2019-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
1195
1196         * dwarf2read.c (struct dw2_symtab_iterator):
1197         <want_specific_block>: Remove.
1198         <block_index>: Change type to gdb::optional.
1199         (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
1200         change type of BLOCK_INDEX parameter to gdb::optional.
1201         (dw2_symtab_iter_next): Re-write in function of gdb::optional.
1202         (dw2_lookup_symbol): Don't pass argument for
1203         WANT_SPECIFIC_BLOCK.
1204         (dw2_expand_symtabs_for_function): Don't pass argument for
1205         WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
1206         (class dw2_debug_names_iterator)
1207         <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
1208         parameter, change BLOCK_INDEX type to gdb::optional.
1209         <m_want_specific_block>: Remove.
1210         <m_block_index>: Change type to gdb::optional.
1211         (dw2_debug_names_iterator::next): Change type of IS_STATIC to
1212         gdb::optional.  Re-write in function of gdb::optional.
1213         (dw2_debug_names_lookup_symbol): Don't pass argument for
1214         WANT_SPECIFIC_BLOCK.
1215         (dw2_debug_names_expand_symtabs_for_function): Don't pass
1216         argument for WANT_SPECIFIC_BLOCK, pass empty optional for
1217         BLOCK_INDEX.
1218
1219 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1220
1221         * NEWS: Mention changes to "info sources" command.
1222
1223 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1224
1225         * symtab.c (filename_partial_match_opts): New struct type.
1226         (struct output_source_filename_data): New members
1227         regexp, c_regexp, partial_match.
1228         (output_source_filename): Use new members to decide to print file.
1229         (info_sources_option_defs): New variable.
1230         (make_info_sources_options_def_group, print_info_sources_header,
1231         info_sources_command_completer):
1232         New functions.
1233         (info_sources_command): Read new optional arguments.
1234         (_initialize_symtab): Update info sources help.
1235
1236 2019-08-02  Alexandre Oliva <oliva@adacore.com>
1237
1238         * ada-lang.c (exception_support_info_v0): Renamed from...
1239         (default_exception_support_info): ... this.  Create new
1240         definition for v1.
1241         (ada_has_this_exception_support): Look up catch_handlers_sym.
1242         (ada_exception_support_info_sniffer): Try v0 after default.
1243
1244 2019-08-01  Tom Tromey  <tromey@adacore.com>
1245
1246         * ia64-libunwind-tdep.h (struct libunwind_descr): Include
1247         gdbarch.h.
1248
1249 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
1250
1251         * s12z-tdep.c: Fix include path for s12z-opc.h.
1252
1253 2019-08-01  Alan Hayward  <alan.hayward@arm.com>
1254
1255         * NEWS: Require GNU make 3.82.
1256
1257 2019-07-16  Tom Tromey  <tom@tromey.com>
1258
1259         * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
1260         declare.
1261
1262 2019-07-30  Tom Tromey  <tromey@adacore.com>
1263
1264         * block.c (contained_in): Remove BLOCK_FUNCTION check.
1265
1266 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
1267
1268         * printcmd.c (print_address_symbolic): Print negative offsets.
1269         (build_address_symbolic): Force signed arithmetic when computing
1270         offset.
1271
1272 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
1273
1274         PR/24474: Add a function to lookup static variables.
1275         * NEWS: Mention this new function.
1276         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
1277         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
1278         * python/python.c (python_GdbMethods): Add new function.
1279
1280 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
1281
1282         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
1283         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
1284         (objfpy_lookup_static_symbol): New function.
1285         (objfile_object_methods): Add new functions.
1286
1287 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1288
1289         * NEWS: Mention 'set|show print frame-info'.  Mention new
1290         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
1291         backtrace argument.  Mention that python frame filtering code
1292         is now consistent with what 'backtrace' command prints.
1293
1294 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1295
1296         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
1297         comments.
1298         (print_frame_info_auto, print_frame_info_source_line,
1299         print_frame_info_location, print_frame_info_source_and_location,
1300         print_frame_info_location_and_address, print_frame_info_short_location):
1301         New declarations.
1302         (struct frame_print_options): New member print_frame_info.
1303         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
1304         * stack.h (get_user_print_what_frame_info): New declaration.
1305         (frame_show_address): New declaration.
1306         * stack.c (print_frame_arguments_choices): New value 'presence'.
1307         (print_frame_info_auto, print_frame_info_source_line,
1308         print_frame_info_location, print_frame_info_source_and_location,
1309         print_frame_info_location_and_address, print_frame_info_short_location,
1310         print_frame_info_choices, print_frame_info_print_what): New definitions.
1311         (print_frame_args): Only print dots for args if print frame-arguments
1312         is 'presence'.
1313         (frame_print_option_defs): New element for "frame-info".
1314         (get_user_print_what_frame_info): New function.
1315         (frame_show_address): Make non static.  Move comment to stack.h.
1316         (print_frame_info_to_print_what): New function.
1317         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
1318         to decide what to print.
1319         (backtrace_command_1): Handle the new print_frame_arguments_presence
1320         value.
1321         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
1322         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
1323         (py_print_frame): In non-mi mode, use LOCATION as default for
1324         print_what, similarly to frame information printed directly by
1325         backtrace command. Handle frame-info user option in non MI mode.
1326
1327 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
1328
1329         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
1330         Add case for debugging 32-bit target on 64-bit host.  Revise
1331         comment.
1332
1333 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
1334
1335         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
1336         instead of find_function_entry_range_from_pc.
1337
1338 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
1339
1340         * stack.c (find_frame_funname): Remove code which preferred
1341         minsym over symtab sym in "certain pathological cases".
1342
1343         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
1344         parameter.  Change type of "do_demangle" to bool.
1345         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
1346         Pass suitable "prefer_sym_over_minsym" flag to
1347         build_address_symbolic().  Don't output "+" for negative offsets.
1348         * printcmd.c (print_address_symbolic): Update invocation of
1349         build_address_symbolic to include a "prefer_sym_over_minsym"
1350         flag.
1351         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
1352         Restrict cases in which use of minimal symbol is preferred to that
1353         of a found symbol.  Update comments.
1354
1355         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
1356         for entry pc when entry pc is out of range for that FDE.
1357
1358 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
1359
1360         PR gdb/24839:
1361         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
1362         type.
1363
1364 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
1365
1366         * python/py-objfile.c (add_separate_debug_file): Fix comment about
1367         this function's Python signature.
1368
1369
1370 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
1371
1372         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
1373         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
1374         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
1375         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
1376         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
1377
1378
1379 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
1380
1381         * h8300-tdep.c (h8300_register_name_common): New.
1382         h8300_register_name): Use h8300_register_name_common.
1383         (h8300s_register_name): Likewise.
1384         (h8300sx_register_name): Likewise.
1385         (h8300h_register_nam): New.
1386         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
1387
1388
1389 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
1390
1391         * arm-tdep.c (arm_skip_cmse_entry): New function.
1392         (arm_is_sgstubs_section): New function.
1393         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
1394
1395 2019-07-22  Tom Tromey  <tom@tromey.com>
1396
1397         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
1398         Don't self-assign.
1399
1400 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1401
1402         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
1403         type_print.
1404
1405 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1406
1407         * symtab.c (search_symbols): Adjust msymbol matching type arrays
1408         so that GDB doesn't match any msymbols when searching in the
1409         TYPES_DOMAIN.
1410         (print_symbol_info): Print using typedef_print or type_print based
1411         on the type of the symbol.  Add updated FIXME comment moved from...
1412         (_initialize_symtab): ... move and update FIXME comment to above.
1413
1414 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1415
1416         * NEWS: Mention adding -q option to "info types".
1417         * symtab.c (struct info_types_options): New struct.
1418         (info_types_options_defs): New variable.
1419         (make_info_types_options_def_group): New function.
1420         (info_types_command): Use gdb::option framework to parse options.
1421         (info_types_command_completer): New function.
1422         (_initialize_symtab): Extend the help text on "info types" and
1423         register command completer.
1424
1425 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
1426
1427         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
1428         (lookup_symbol_in_objfile): Change int to block_enum and add a
1429         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
1430
1431 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
1432
1433         * MAINTAINERS (Write After Approval): Add self.
1434
1435 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
1436
1437         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
1438         instruction to the dummy code region.
1439
1440 2019-07-19  Tom Tromey  <tromey@adacore.com>
1441
1442         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
1443         (ARGSUSED, PARAMS, __func__): Remove rules.
1444
1445 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1446
1447         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
1448         * features/arm/arm-with-iwmmxt.c: Remove.
1449         * features/arm/arm-with-iwmmxt.xml: Remove.
1450         * features/arm/arm-with-m-fpa-layout.c: Remove.
1451         * features/arm/arm-with-m-fpa-layout.xml: Remove.
1452         * features/arm/arm-with-m-vfp-d16.c: Remove.
1453         * features/arm/arm-with-m-vfp-d16.xml: Remove.
1454         * features/arm/arm-with-m.c: Remove.
1455         * features/arm/arm-with-m.xml: Remove.
1456         * features/arm/arm-with-neon.c: Remove.
1457         * features/arm/arm-with-neon.xml: Remove.
1458         * features/arm/arm-with-vfpv2.c: Remove.
1459         * features/arm/arm-with-vfpv2.xml: Remove.
1460         * features/arm/arm-with-vfpv3.c: Remove.
1461         * features/arm/arm-with-vfpv3.xml: Remove.
1462
1463 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1464
1465         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
1466
1467 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1468
1469         * arch/aarch32.c (aarch32_create_target_description): Create
1470         target descriptions using features.
1471         * arch/arm.c (arm_create_target_description)
1472         (arm_create_mprofile_target_description): Likewise.
1473         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
1474
1475 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1476
1477         * Makefile.in: Add new files.
1478         * aarch32-tdep.c: New file.
1479         * aarch32-tdep.h: New file.
1480         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
1481         Call aarch32_read_description.
1482         * arch/aarch32.c: New file.
1483         * arch/aarch32.h: New file.
1484         * arch/arm.c (arm_create_target_description)
1485         (arm_create_mprofile_target_description): New function.
1486         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
1487         (arm_create_target_description)
1488         (arm_create_mprofile_target_description): New declaration.
1489         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
1490         read_description functions.
1491         * arm-linux-nat.c (arm_linux_nat_target::read_description):
1492         Likewise.
1493         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
1494         * arm-tdep.c (tdesc_arm_list): New variable.
1495         (arm_register_g_packet_guesses): Call create description functions.
1496         (arm_read_description) (arm_read_mprofile_description): New
1497         function.
1498         * arm-tdep.h (arm_read_description)
1499         (arm_read_mprofile_description): Add declaration.
1500         * configure.tgt: Add new files.
1501
1502 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
1503
1504         * top.c (new_ui_command): Open specified terminal just once.
1505
1506 2019-07-18  Tom Tromey  <tromey@adacore.com>
1507
1508         * symtab.c (main_name): Constify return type.
1509         * symfile.c (set_initial_language): Update.
1510         * symtab.h (main_name): Constify return type.
1511
1512 2019-07-17  Tom Tromey  <tom@tromey.com>
1513
1514         * tui/tui-winsource.c (tui_update_source_window)
1515         (tui_update_source_window_as_is)
1516         (tui_update_source_windows_with_line): Remove return.
1517         * tui/tui-disasm.c (tui_show_disassem)
1518         (tui_show_disassem_and_update_source): Remove return.
1519         * tui/tui.c (tui_reset): Remove return.
1520         * tui/tui-wingeneral.c
1521         (tui_check_and_display_highlight_if_needed): Remove return.
1522
1523 2019-07-17  Tom Tromey  <tom@tromey.com>
1524
1525         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
1526
1527 2019-07-17  Tom Tromey  <tom@tromey.com>
1528
1529         * tui/tui-winsource.h (struct tui_exec_info_window)
1530         (struct tui_source_window_base): Move from tui-data.h.
1531         * tui/tui-winsource.c: Move many method definitions from
1532         elsewhere.  Remove "structuring" comments.
1533         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
1534         (tui_source_window_base::refresh_window): Move to
1535         tui-winsource.c.
1536         * tui/tui-win.c (tui_source_window_base::refresh_all)
1537         (tui_source_window_base::update_tab_width)
1538         (tui_source_window_base::set_new_height)
1539         (tui_source_window_base::do_make_visible_with_new_height): Move to
1540         tui-winsource.c.
1541         * tui/tui-source.h: Update.
1542         * tui/tui-source.c (tui_source_window_base::reset): Move to
1543         tui-winsource.c.
1544         * tui/tui-disasm.h: Update.
1545         * tui/tui-data.h (struct tui_exec_info_window): Move to
1546         tui-winsource.h.
1547         (struct tui_source_window_base): Likewise.
1548         * tui/tui-data.c (tui_source_window_base::clear_detail)
1549         (tui_source_window_base, ~tui_source_window_base): Move to
1550         tui-winsource.c.
1551
1552 2019-07-17  Tom Tromey  <tom@tromey.com>
1553
1554         * tui/tui-win.c (tui_resize_all)
1555         (tui_source_window_base::update_tab_width)
1556         (tui_adjust_win_heights): Update.
1557         (tui_win_info::make_invisible_and_set_new_height): Rename from
1558         make_invisible_and_set_new_height.
1559         * tui/tui-data.h (struct tui_win_info)
1560         <make_invisible_and_set_new_height>: New method.
1561
1562 2019-07-17  Tom Tromey  <tom@tromey.com>
1563
1564         * tui/tui.c: Update.
1565         * tui/tui-source.h (struct tui_source_window): Move from
1566         tui-data.h.
1567         * tui/tui-layout.c: Update.
1568         * tui/tui-disasm.c: Update.
1569         * tui/tui-data.h (struct tui_source_window): Move to
1570         tui-source.h.
1571
1572 2019-07-17  Tom Tromey  <tom@tromey.com>
1573
1574         * tui/tui-disasm.h (struct tui_disasm_window): Move from
1575         tui-data.h.
1576         * tui/tui-data.h (struct tui_disasm_window): Move to
1577         tui-disasm.h.
1578
1579 2019-07-17  Tom Tromey  <tom@tromey.com>
1580
1581         * tui/tui-regs.h (struct tui_data_item_window): Move from
1582         tui-data.h.
1583         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
1584         * tui/tui-data.h (struct tui_data_item_window): Move to
1585         tui-regs.h.
1586         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
1587
1588 2019-07-17  Tom Tromey  <tom@tromey.com>
1589
1590         * tui/tui.c: Update.
1591         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
1592         (tui_cmd_window::max_height): Move to tui-command.c.
1593         * tui/tui-layout.c: Update.
1594         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
1595         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
1596         tui-command.c.
1597         * tui/tui-command.h (struct tui_cmd_window): Move from
1598         tui-data.h.
1599         * tui/tui-command.c: Remove "structuring" comments.
1600         (tui_cmd_window::clear_detail)
1601         (tui_cmd_window::do_make_visible_with_new_height)
1602         (tui_cmd_window::max_height): Move from elsewhere.
1603
1604 2019-07-17  Tom Tromey  <tom@tromey.com>
1605
1606         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
1607         Now static.
1608         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
1609         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
1610
1611 2019-07-17  Tom Tromey  <tom@tromey.com>
1612
1613         * tui/tui.c: Update.
1614         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
1615         tui-regs.c.
1616         * tui/tui-windata.h: Remove file.
1617         * tui/tui-windata.c: Remove file.
1618         * tui/tui-win.c (tui_data_window::set_new_height)
1619         (tui_data_window::do_make_visible_with_new_height): Move to
1620         tui-regs.c.
1621         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
1622         * tui/tui-regs.c: Remove "structuring" comments.
1623         (tui_data_window::first_data_item_displayed)
1624         (tui_data_window::delete_data_content_windows)
1625         (tui_data_window::erase_data_content)
1626         (tui_data_window::display_all_data)
1627         (tui_data_window::refresh_all)
1628         (tui_data_window::do_scroll_vertical)
1629         (tui_data_window::clear_detail, tui_data_window::set_new_height)
1630         (tui_data_window::do_make_visible_with_new_height)
1631         (tui_data_window::refresh_window): Move from elsewhere.
1632         (_initialize_tui_regs): Move to end of file.
1633         * tui/tui-layout.c: Update.
1634         * tui/tui-hooks.c: Update.
1635         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
1636         * tui/tui-data.c (tui_data_window::clear_detail): Move to
1637         tui-regs.c.
1638         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
1639
1640 2019-07-17  Tom Tromey  <tom@tromey.com>
1641
1642         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
1643         seen.
1644
1645 2019-07-17  Tom Tromey  <tom@tromey.com>
1646
1647         * tui/tui-win.c (tui_source_window_base::set_new_height)
1648         (tui_source_window_base::do_make_visible_with_new_height): Use
1649         m_has_locator field directly.
1650         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
1651         method.
1652         (struct tui_source_window_base) <has_locator>: Likewise.
1653
1654 2019-07-17  Tom Tromey  <tom@tromey.com>
1655
1656         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
1657         Don't declare.
1658         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
1659         Remove.
1660         * tui/tui-win.c (tui_source_window_base::set_new_height)
1661         (tui_source_window_base::set_new_height)
1662         (make_invisible_and_set_new_height)
1663         (tui_source_window_base::do_make_visible_with_new_height)
1664         (tui_source_window_base::do_make_visible_with_new_height):
1665         Update.
1666         * tui/tui-layout.c (show_source_disasm_command, show_data)
1667         (show_source_or_disasm_and_command): Update.
1668         * tui/tui-layout.c (show_layout): Update.
1669
1670 2019-07-17  Tom Tromey  <tom@tromey.com>
1671
1672         * tui/tui-layout.c (make_data_window): Remove.
1673         (show_data): Unify creation and re-initialization cases.
1674
1675 2019-07-17  Tom Tromey  <tom@tromey.com>
1676
1677         * tui/tui-layout.c (make_source_window, make_disasm_window):
1678         Remove.
1679         (show_data): Unify creation and re-initialization cases.
1680
1681 2019-07-17  Tom Tromey  <tom@tromey.com>
1682
1683         * tui/tui-layout.c (make_command_window): Remove.
1684         (show_source_disasm_command, show_source_or_disasm_and_command):
1685         Unify creation and re-initialization cases.
1686
1687 2019-07-17  Tom Tromey  <tom@tromey.com>
1688
1689         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
1690         creation and re-initialization cases.
1691
1692 2019-07-17  Tom Tromey  <tom@tromey.com>
1693
1694         * tui/tui-regs.c (tui_get_register): Return void.
1695
1696 2019-07-17  Tom Tromey  <tom@tromey.com>
1697
1698         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
1699         Simplify.
1700
1701 2019-07-17  Tom Tromey  <tom@tromey.com>
1702
1703         * tui/tui-layout.c (show_source_disasm_command): Simplify window
1704         resetting.
1705
1706 2019-07-17  Tom Tromey  <tom@tromey.com>
1707
1708         * tui/tui.h (tui_set_layout_by_name): Don't declare.
1709         * tui/tui-regs.c (tui_reg_layout): New function.
1710         (tui_show_registers, tui_reg_command): Use it.
1711         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
1712         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
1713         parameters.
1714         (tui_layout_command): Remove.
1715
1716 2019-07-17  Tom Tromey  <tom@tromey.com>
1717
1718         * tui/tui-layout.h (tui/tui-layout): Return void.
1719         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
1720
1721 2019-07-17  Tom Tromey  <tom@tromey.com>
1722
1723         * tui/tui-layout.c (show_source_disasm_command, show_data):
1724         Update.
1725         (reset_locator): Remove.
1726         (show_source_or_disasm_and_command): Update.
1727
1728 2019-07-17  Tom Tromey  <tom@tromey.com>
1729
1730         * tui/tui-source.c (tui_source_window_base::reset): Remove
1731         win_type parameter.
1732         * tui/tui-layout.c (make_command_window, make_source_window)
1733         (make_disasm_window, make_data_window)
1734         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
1735         (reset_locator, show_source_or_disasm_and_command): Update.
1736         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
1737         win_type parameter.
1738         (struct tui_source_window_base) <reset>: Likewise.
1739
1740 2019-07-17  Tom Tromey  <tom@tromey.com>
1741
1742         * tui/tui-layout.c (show_source_disasm_command): Use
1743         reset_locator.
1744         (reset_locator): New function.
1745         (init_and_make_win): Remove.
1746         (show_source_or_disasm_and_command): Use reset_locator.
1747
1748 2019-07-17  Tom Tromey  <tom@tromey.com>
1749
1750         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
1751         condition.
1752         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
1753         Remove condition.
1754         * tui/tui-source.c (tui_source_window_base::reset): New method.
1755         * tui/tui-layout.c (make_command_window): Don't call
1756         init_and_make_win.
1757         (make_source_window, make_disasm_window): Don't call
1758         make_source_or_disasm_window.
1759         (make_data_window): Don't call init_and_make_win.  Change calling
1760         convention.
1761         (show_source_disasm_command, show_data): Simplify.
1762         (make_source_or_disasm_window): Remove.
1763         (show_source_or_disasm_and_command): Simplify.
1764         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
1765         (struct tui_source_window_base) <reset>: Likewise.
1766         <execution_info>: Remove initializer.
1767         * tui/tui-data.c (tui_source_window_base): Initialize
1768         execution_info.
1769
1770 2019-07-17  Tom Tromey  <tom@tromey.com>
1771
1772         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
1773         variable.
1774
1775 2019-07-17  Tom Tromey  <tom@tromey.com>
1776
1777         * tui/tui.c (tui_rl_other_window): Update.
1778         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
1779         superclass method first.  Always iterate over regs_content.
1780         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
1781         method.
1782         * tui/tui-win.c (tui_set_focus_command): Update.
1783
1784 2019-07-17  Tom Tromey  <tom@tromey.com>
1785
1786         * tui/tui-win.c (tui_set_focus_command): Rename from
1787         tui_set_focus.  Call tui_enable.
1788         (tui_set_focus_command): Remove.
1789
1790 2019-07-17  Tom Tromey  <tom@tromey.com>
1791
1792         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
1793         refresh_window.
1794         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
1795         touchwin.
1796         (tui_data_window::refresh_window): Call refresh_window on data
1797         items.  Always call superclass refresh_window.
1798         (tui_win_info::refresh): Remove.
1799         (tui_source_window_base::refresh_window): Update.
1800         (tui_refresh_all): Update.
1801         * tui/tui-layout.c (show_source_disasm_command): Remove call to
1802         refresh_window.
1803         (show_source_or_disasm_and_command): Likewise.
1804         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
1805         (struct tui_source_window_base) <refresh>: Likewise.
1806
1807 2019-07-17  Tom Tromey  <tom@tromey.com>
1808
1809         * tui/tui-winsource.c (tui_clear_source_content)
1810         (tui_show_source_content): Update.
1811         * tui/tui-source.c (tui_source_window::showing_source_p): Check
1812         whether content is empty.
1813         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
1814         Remove.
1815
1816 2019-07-17  Tom Tromey  <tom@tromey.com>
1817
1818         * tui/tui-winsource.c (tui_erase_source_content): Clear the
1819         window's contents.
1820         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
1821         * tui/tui-source.c (tui_set_source_content_nil): Remove.
1822
1823 2019-07-17  Tom Tromey  <tom@tromey.com>
1824
1825         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
1826         (struct tui_data_item_window): Update.
1827
1828 2019-07-17  Tom Tromey  <tom@tromey.com>
1829
1830         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
1831         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
1832         defines.
1833
1834 2019-07-17  Tom Tromey  <tom@tromey.com>
1835
1836         * tui/tui-winsource.h (tui_erase_source_content)
1837         (tui_clear_source_content): Remove "display_prompt" parameter.
1838         * tui/tui-winsource.c (tui_update_source_window_as_is)
1839         (tui_update_source_windows_with_addr): Update.
1840         (tui_clear_source_content): Remove "display_prompt" parameter.
1841         (tui_erase_source_content): Likewise.  Simplify.
1842         (tui_show_source_content): Update.
1843         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
1844         * tui/tui-stack.c (tui_show_frame_info): Update.
1845         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
1846         Remove defines.
1847
1848 2019-07-17  Tom Tromey  <tom@tromey.com>
1849
1850         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
1851         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
1852         parameter.
1853         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
1854         parameter.
1855
1856 2019-07-17  Tom Tromey  <tom@tromey.com>
1857
1858         * tui/tui-winsource.c (tui_clear_source_content)
1859         (tui_show_source_content, tui_show_exec_info_content)
1860         (tui_clear_exec_info_content): Update.
1861         * tui/tui-stack.c (tui_show_locator_content): Update.
1862         (tui_show_frame_info): Update.
1863         * tui/tui-source.h (tui_source_window): Don't declare.
1864         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
1865         from tui_source_is_displayed.
1866         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
1867         Remove field.
1868         (struct tui_source_window_base) <content_in_use>: New field.  Now
1869         bool.
1870         (struct tui_source_window) <showing_source_p>: New method.
1871         (TUI_SRC_WIN): Change cast.
1872         * tui/tui-data.c (tui_initialize_static_data): Update.
1873
1874 2019-07-17  Tom Tromey  <tom@tromey.com>
1875
1876         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
1877         location_matches_p.
1878         * tui/tui-source.c (tui_source_window::location_matches_p): New
1879         method.
1880         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
1881         method.
1882         * tui/tui-data.h (struct tui_source_window_base)
1883         <location_matches_p>: New method.
1884         (struct tui_source_window, struct tui_disasm_window)
1885         <location_matches_p>: Likewise.
1886
1887 2019-07-17  Tom Tromey  <tom@tromey.com>
1888
1889         * tui/tui-win.c (tui_set_win_height_command): Rename from
1890         tui_set_win_height.
1891         (tui_set_win_height_command): Remove.
1892
1893 2019-07-17  Tom Tromey  <tom@tromey.com>
1894
1895         * tui/tui-source.c (tui_source_window): New constructor.  Add
1896         observer.
1897         (~tui_source_window): New destructor.
1898         (tui_source_window::style_changed): New method.
1899         * tui/tui-hooks.c (tui_redisplay_source): Remove.
1900         (tui_attach_detach_observers): Update.
1901         * tui/tui-data.h (struct tui_source_window): Make constructor not
1902         inline.  Add destructor.
1903         (struct tui_source_window) <style_changed>: New method.
1904         <m_observable>: New member.
1905
1906 2019-07-17  Tom Tromey  <tom@tromey.com>
1907
1908         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
1909         * tui/tui-win.c (tui_resize_all): Fix typo.
1910
1911 2019-07-17  Tom Tromey  <tom@tromey.com>
1912
1913         * tui/tui-wingeneral.h (tui_refresh_all): Update.
1914         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
1915         (tui_refresh_all): Remove "list" parameter.  Use foreach.
1916         * tui/tui-win.c (window_name_completer): Use foreach.
1917         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
1918         (update_tab_width): Likewise.
1919         * tui/tui-layout.c (show_layout): Update.
1920         * tui/tui-data.h (class tui_window_iterator): New.
1921         (struct all_tui_windows): New.
1922         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
1923
1924 2019-07-17  Tom Tromey  <tom@tromey.com>
1925
1926         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
1927         parameter.  Don't reference globals.
1928         (tui_reg_command): Update.
1929
1930 2019-07-17  Tom Tromey  <tom@tromey.com>
1931
1932         * tui/tui-regs.c (tui_show_registers): Simplify.
1933
1934 2019-07-17  Tom Tromey  <tom@tromey.com>
1935
1936         * tui/tui-regs.c (tui_show_registers): Update.
1937         (tui_show_register_group): Add win_info parameter.
1938
1939 2019-07-17  Tom Tromey  <tom@tromey.com>
1940
1941         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
1942         Rename from tui_display_reg_element_at_line.
1943         (tui_data_window::display_registers_from_line): Update.
1944         * tui/tui-data.h (struct tui_data_window)
1945         <display_reg_element_at_line>: New method.
1946
1947 2019-07-17  Tom Tromey  <tom@tromey.com>
1948
1949         * tui/tui-regs.h (tui_display_registers_from)
1950         (tui_display_registers_from_line): Don't declare.
1951         * tui/tui-windata.c (tui_data_window::display_all_data)
1952         (tui_data_window::refresh_all)
1953         (tui_data_window::do_scroll_vertical): Update.
1954         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
1955         from tui_display_registers_from.
1956         (tui_display_reg_element_at_line): Update.
1957         (tui_data_window::display_registers_from_line): Rename from
1958         tui_display_registers_from_line.
1959         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
1960         display_registers_from_line>: New methods.
1961
1962 2019-07-17  Tom Tromey  <tom@tromey.com>
1963
1964         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
1965         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
1966         from tui_erase_data_content.
1967         (tui_data_window::display_all_data)
1968         (tui_data_window::refresh_all)
1969         (tui_data_window::do_scroll_vertical): Update.
1970         * tui/tui-regs.c (tui_show_registers): Update.
1971         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
1972         New method.
1973
1974 2019-07-17  Tom Tromey  <tom@tromey.com>
1975
1976         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
1977         declare.
1978         * tui/tui-windata.c
1979         (tui_data_window::delete_data_content_windows): Rename from
1980         tui_delete_data_content_windows.
1981         (tui_data_window::display_all_data)
1982         (tui_data_window::do_scroll_vertical): Update.
1983         * tui/tui-data.h (struct tui_data_window)
1984         <delete_data_content_windows>: New method.
1985
1986 2019-07-17  Tom Tromey  <tom@tromey.com>
1987
1988         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
1989         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
1990
1991 2019-07-17  Tom Tromey  <tom@tromey.com>
1992
1993         * tui/tui-windata.h (tui_display_all_data): Don't declare.
1994         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
1995         from tui_display_all_data.
1996         * tui/tui-win.c
1997         (tui_data_window::do_make_visible_with_new_height): Update.
1998         * tui/tui-regs.c (tui_show_registers): Update.
1999         * tui/tui-layout.c (tui_set_layout): Update.
2000         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
2001         method.
2002
2003 2019-07-17  Tom Tromey  <tom@tromey.com>
2004
2005         * tui/tui-windata.h (tui_display_data_from): Don't declare.
2006         * tui/tui-windata.c (tui_display_data_from): Remove.
2007         (tui_data_window::refresh_all): Update.
2008
2009 2019-07-17  Tom Tromey  <tom@tromey.com>
2010
2011         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
2012         * tui/tui-windata.c (tui_display_data_from_line): Remove.
2013         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
2014         tui_display_registers_from_line.
2015         * tui/tui-regs.h (tui_display_registers_from_line): Update.
2016         * tui/tui-regs.c (tui_display_registers_from_line): Remove
2017         "force_display" parameter.
2018
2019 2019-07-17  Tom Tromey  <tom@tromey.com>
2020
2021         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
2022         declare.
2023         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
2024         Rename from tui_first_reg_element_no_inline.
2025         (tui_display_reg_element_at_line)
2026         (tui_display_registers_from_line): Update.
2027         * tui/tui-data.h (struct tui_data_window)
2028         <first_reg_element_no_inline>: New method.
2029
2030 2019-07-17  Tom Tromey  <tom@tromey.com>
2031
2032         * tui/tui-windata.c (tui_display_data_from)
2033         (tui_data_window::do_scroll_vertical): Update.
2034         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
2035         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
2036         Rename from tui_line_from_reg_element_no.
2037         (tui_display_registers_from_line): Update.
2038         * tui/tui-data.h (struct tui_data_window)
2039         <line_from_reg_element_no>: New method.
2040
2041 2019-07-17  Tom Tromey  <tom@tromey.com>
2042
2043         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
2044         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
2045         tui_last_regs_line_no.
2046         (tui_display_reg_element_at_line)
2047         (tui_display_registers_from_line): Update.
2048         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
2049         method.
2050
2051 2019-07-17  Tom Tromey  <tom@tromey.com>
2052
2053         PR tui/24722:
2054         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
2055         (tui_update_breakpoint_info): Add "being_deleted" parameter.
2056         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
2057         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
2058         (tui_update_breakpoint_info): Likewise.
2059         * tui/tui-hooks.c (tui_event_create_breakpoint)
2060         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
2061         Update.
2062
2063 2019-07-17  Tom Tromey  <tom@tromey.com>
2064
2065         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
2066
2067 2019-07-17  Tom Tromey  <tom@tromey.com>
2068
2069         * tui/tui-winsource.c (tui_update_source_window_as_is)
2070         (tui_update_source_windows_with_addr): Update.
2071         * tui/tui-source.h (tui_set_source_content)
2072         (tui_show_symtab_source): Add "win_info" parameter.
2073         * tui/tui-source.c (tui_set_source_content): Add "win_info"
2074         parameter.
2075         (tui_show_symtab_source): Likewise.
2076
2077 2019-07-17  Tom Tromey  <tom@tromey.com>
2078
2079         * tui/tui-wingeneral.c
2080         (tui_check_and_display_highlight_if_needed): Check can_highlight.
2081
2082 2019-07-17  Tom Tromey  <tom@tromey.com>
2083
2084         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
2085         (struct tui_cmd_window) <can_scroll>: New method.
2086         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
2087         method.
2088
2089 2019-07-17  Tom Tromey  <tromey@adacore.com>
2090
2091         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
2092         do_field_signed>: Rename.  Change type of "value".
2093         * ui-out.c (ui_out::field_signed): Rename from field_int.
2094         Change type of "value".
2095         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
2096         type of "value".
2097         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
2098         do_field_int.  Change type of "value".
2099         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
2100         do_field_int.  Change type of "value".
2101         * tracepoint.c (trace_status_mi, tfind_1)
2102         (print_one_static_tracepoint_marker): Update.
2103         * thread.c (print_thread_info_1, print_selected_thread_frame):
2104         Update.
2105         * stack.c (print_frame, print_frame_info): Update.
2106         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
2107         Update.
2108         * source.c (print_source_lines_base): Update.
2109         * skip.c (info_skip_command): Update.
2110         * record-btrace.c (btrace_ui_out_decode_error)
2111         (btrace_call_history_src_line): Update.
2112         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
2113         Update.
2114         * progspace.c (print_program_space): Update.
2115         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
2116         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
2117         do_field_int.  Change type of "value".
2118         * mi/mi-out.c (mi_ui_out::do_table_begin)
2119         (mi_ui_out::do_table_header): Update.
2120         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
2121         type of "value".
2122         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
2123         (mi_cmd_data_list_changed_registers, output_register)
2124         (mi_cmd_data_read_memory, mi_load_progress)
2125         (mi_cmd_trace_frame_collected): Update.
2126         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
2127         Update.
2128         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
2129         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
2130         (mi_cmd_var_list_children, varobj_update_one): Update.
2131         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
2132         (mi_cmd_stack_list_args, list_arg_or_local): Update.
2133         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
2134         * inferior.c (print_inferior): Update.
2135         * gdb_bfd.c (print_one_bfd): Update.
2136         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
2137         Update.
2138         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
2139         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
2140         do_field_int.  Change type of "value".
2141         * cli-out.c (cli_ui_out::do_field_signed): Rename from
2142         do_field_int.  Change type of "value".
2143         * breakpoint.c (watchpoint_check, print_breakpoint_location)
2144         (print_one_breakpoint_location, print_it_catch_fork)
2145         (print_one_catch_fork, print_it_catch_vfork)
2146         (print_one_catch_vfork, print_it_catch_solib)
2147         (print_it_catch_exec, print_it_ranged_breakpoint)
2148         (print_mention_watchpoint, print_mention_masked_watchpoint)
2149         (bkpt_print_it, update_static_tracepoint): Update.
2150         * break-catch-throw.c (print_it_exception_catchpoint): Update.
2151         * break-catch-syscall.c (print_it_catch_syscall): Update.
2152         * ada-tasks.c (print_ada_task_info): Update.
2153         * ada-lang.c (print_it_exception, print_mention_exception):
2154         Update.
2155
2156 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
2157
2158         PR breakpoints/24541
2159         * gdbarch.c: Regenerate.
2160         * gdbarch.h: Regenerate.
2161         * gdbarch.sh: Adjust return type and parameter types for
2162         'stap_adjust_register'.
2163         (i386_stap_adjust_register): Adjust signature and return new
2164         register name.
2165         * stap-probe.c (stap_parse_register_operand): Adjust use of
2166         'gdbarch_stap_adjust_register'.
2167
2168 2019-07-17  Tom Tromey  <tromey@adacore.com>
2169
2170         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
2171         declare VEC.
2172         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
2173         std::vector.
2174         (struct s390_process_info): Add initializers.
2175         (s390_add_process): Use new.
2176         (s390_linux_nat_target::low_forget_process): Use delete.
2177         (s390_linux_nat_target::low_new_fork)
2178         (s390_linux_nat_target::stopped_by_watchpoint)
2179         (s390_linux_nat_target::low_prepare_to_resume)
2180         (s390_linux_nat_target::insert_watchpoint)
2181         (s390_linux_nat_target::insert_hw_breakpoint)
2182         (s390_linux_nat_target::remove_watchpoint)
2183         (s390_linux_nat_target::remove_hw_breakpoint): Update.
2184
2185 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
2186
2187         * aarch64-fbsd-nat.c: Include regcache.h.
2188         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
2189         argument.
2190         (aarch64_fbsd_nat_target::fetch_registers)
2191         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
2192         variable.
2193         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
2194
2195 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
2196
2197         * fbsd-nat.c: Include gdbarch.h.
2198
2199 2019-07-15  Tom Tromey  <tromey@adacore.com>
2200
2201         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
2202
2203 2019-07-15  Tom Tromey  <tromey@adacore.com>
2204
2205         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
2206         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
2207         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
2208         * cli-out.c (cli_ui_out::do_field_int): New method.
2209         * ui-out.c (ui_out::field_unsigned): New method.
2210         * symfile.c (generic_load): Use field_unsigned.
2211         (print_transfer_performance): Likewise.
2212         * record-btrace.c (ui_out_field_uint): Remove.
2213         (btrace_call_history_insn_range, btrace_call_history): Use
2214         field_unsigned.
2215         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
2216         field_unsigned.
2217         * ui-out.h (class ui_out) <field_unsigned>: New method.
2218         <do_field_unsigned>: Likewise.
2219
2220 2019-07-15  Tom Tromey  <tromey@adacore.com>
2221
2222         * mi/mi-main.c (list_available_thread_groups): Use field_string.
2223         * mi/mi-interp.c (mi_memory_changed): Use field_string.
2224         * target.c (flash_erase_command): Use field_string.
2225         * infrun.c (print_signal_received_reason): Use field_string.
2226         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
2227         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
2228         field_string.
2229         * ada-tasks.c (print_ada_task_info): Use field_string.
2230
2231 2019-07-15  Tom Tromey  <tromey@adacore.com>
2232
2233         * target.c (flash_erase_command): Use field_core_addr.
2234         * symfile.c (generic_load): Use field_core_addr.
2235         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
2236         Use field_core_addr.
2237         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
2238         field_core_addr.
2239
2240 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2241
2242         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
2243         value if its desired type is smaller than a CORE_ADDR and signed.
2244
2245 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2246
2247         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
2248         of changes to field names, and use new is_reference field to
2249         decide if a property is a reference or not.
2250         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
2251         field.
2252         (struct dwarf2_property_baton): Update header comment, rename
2253         'referenced_type' to 'property_type' and update comments.
2254         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
2255         default property type, store in property baton, update to take
2256         accound of renamed field.
2257         (read_func_scope): Update call to attr_to_dynamic_prop.
2258         (read_array_type): Likewise.
2259         (dwarf2_per_cu_addr_sized_int_type): New function.
2260         (read_subrange_index_type): Move type finding code to
2261         dwarf2_per_cu_addr_sized_int_type.
2262         (read_subrange_type): Update calls to attr_to_dynamic_prop.
2263         (dwarf2_per_cu_addr_type): New function.
2264         (set_die_type): Update calls to attr_to_dynamic_prop.
2265
2266 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2267
2268         * dwarf2read.c (read_subrange_index_type): New function.
2269         (read_subrange_type): Move code into new function and call it.
2270         * gdbtypes.c (create_range_type): Add some asserts.
2271
2272 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2273
2274         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
2275         update return statements.
2276         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
2277         declaration, and update comment to match.
2278         * gdbtypes.c (resolve_dynamic_array): Update call to
2279         dwarf2_evaluate_property to match new return type.
2280
2281 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2282
2283         * valarith.c (value_subscripted_rvalue): Change lowerbound
2284         parameter type from int to LONGEST.
2285         * value.h (value_subscripted_rvalue): Likewise in declaration.
2286
2287 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2288
2289         * cli/cli-utils.c (info_print_command_completer): New function.
2290         * cli/cli-utils.h: Add 'completer.h' include, and forward
2291         declaration for 'struct cmd_list_element'.
2292         (info_print_command_completer): Declare.
2293         * stack.c (_initialize_stack): Add completer for 'info locals' and
2294         'info args'.
2295         * symtab.c (_initialize_symtab): Add completer for 'info
2296         variables' and 'info functions'.
2297         * NEWS: Mention completion for additional info commands.
2298
2299 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2300
2301         * cli/cli-utils.c (extract_info_print_args): Delete.
2302         (extract_arg_maybe_quoted): Delete.
2303         (info_print_options_defs): New variable.
2304         (make_info_print_options_def_group): New function.
2305         (extract_info_print_options): Define new function.
2306         * cli/cli-utils.h (extract_info_print_args): Delete.
2307         (struct info_print_options): New structure.
2308         (extract_info_print_options): Declare new function.
2309         * stack.c (info_locals_command): Update to use new
2310         extract_info_print_options, also add a header comment.
2311         (info_args_command): Likewise.
2312         * symtab.c (info_variables_command): Likewise.
2313         (info_functions_command): Likewise.
2314
2315 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2316
2317         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
2318         to extract string arguments.
2319         * common/common-utils.c (extract_string_maybe_quoted): New function.
2320         * common/common-utils.h (extract_string_maybe_quoted): Declare.
2321
2322 2019-07-11  Tom Tromey  <tromey@adacore.com>
2323
2324         * main.c (get_init_files): Use GDBINIT, not gdbinit.
2325         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
2326         * top.h (gdbinit): Don't declare.
2327         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
2328         into...
2329         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
2330         * top.c (gdb_init): Don't call init_cli_cmds.
2331         (gdbinit): Remove.
2332         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
2333
2334 2019-07-11  Tom Tromey  <tromey@adacore.com>
2335
2336         * python/py-inferior.c (add_thread_object): Don't use thread_obj
2337         after it has been moved.
2338
2339 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
2340
2341         * valops.c (value_must_coerce_to_target): Change return type to
2342         bool.
2343         * value.h (value_must_coerce_to_target): Likewise.
2344
2345 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
2346
2347         * breakpoint.c (is_hardware_watchpoint): Remove
2348         forward-declaration.
2349         (is_masked_watchpoint): Change return type to bool.
2350         (is_tracepoint): Likewise.
2351         (is_breakpoint): Likewise.
2352         (is_hardware_watchpoint): Likewise.
2353         (is_watchpoint): Likewise.
2354         (is_no_memory_software_watchpoint): Likewise.
2355         (is_catchpoint): Likewise.
2356         (breakpoint_1): Make FILTER parameter's return type bool.
2357         is_masked_watchpoint): Change return type to bool.
2358         (save_breakpoints): Make FILTER parameter's return type bool.
2359         * breakpoint.h (is_breakpoint): Change return type to bool.
2360         (is_watchpoint): Likewise.
2361         (is_catchpoint): Likewise.
2362         (is_tracepoint): Likewise.
2363
2364 2019-07-10  Tom Tromey  <tom@tromey.com>
2365
2366         * defs.h: Don't include gdbarch.h.
2367         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
2368         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
2369         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
2370         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
2371         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
2372         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
2373         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
2374         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
2375         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
2376         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
2377         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
2378         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
2379         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
2380         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
2381         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
2382         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
2383         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
2384         record-btrace.c, record.h, regcache-dump.c, regcache.h,
2385         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
2386         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
2387         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
2388         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
2389         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
2390         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
2391         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
2392         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
2393         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
2394
2395 2019-07-10  Tom Tromey  <tromey@adacore.com>
2396
2397         * ada-lang.h (is_ada_exception_catchpoint): Declare.
2398         * breakpoint.c (init_ada_exception_breakpoint): Register as
2399         bp_catchpoint.
2400         (print_one_breakpoint_location, print_one_breakpoint): Use
2401         is_ada_exception_catchpoint.
2402         * ada-lang.c (class ada_catchpoint_location): Pass
2403         bp_loc_software_breakpoint to bp_location constructor.
2404         (is_ada_exception_catchpoint): New function.
2405
2406 2019-07-10  Tom Tromey  <tromey@adacore.com>
2407
2408         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
2409         VEC.
2410         (struct arm_exidx_entry): New method operator<.
2411         (struct arm_exidx_data) <section_maps>: Change type.
2412         (arm_exidx_data_free): Remove.
2413         (arm_exidx_data_key): Change type.  Move lower.
2414         (arm_exidx_new_objfile): Update.
2415         (arm_compare_exidx_entries): Remove.
2416         (arm_find_exidx_entry, _initialize_arm_tdep)
2417
2418 2019-07-10  Tom Tromey  <tromey@adacore.com>
2419
2420         * solib-spu.c (ocl_program_data_key): Change type.
2421         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
2422         Update.
2423
2424 2019-07-10  Tom Tromey  <tromey@adacore.com>
2425
2426         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
2427         (struct solib_aix_inferior_data) <library_list>: Change type.
2428         (solib_aix_inferior_data_handle): Change type.
2429         (get_solib_aix_inferior_data): Update.
2430         (solib_aix_free_library_list): Remove.
2431         (library_list_start_library): Update.
2432         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
2433         return type.
2434         (solib_aix_get_library_list)
2435         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
2436         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
2437
2438 2019-07-10  Tom Tromey  <tromey@adacore.com>
2439
2440         * solib-dsbt.c (struct dsbt_info): Add initializers.
2441         (solib_dsbt_pspace_data): Change type.
2442         (dsbt_pspace_data_cleanup): Remove.
2443         (get_dsbt_info, _initialize_dsbt_solib): Update.
2444
2445 2019-07-10  Tom Tromey  <tromey@adacore.com>
2446
2447         * spu-tdep.c (spu_overlay_data): Change type.
2448         (spu_get_overlay_table, spu_overlay_new_objfile)
2449         (_initialize_spu_tdep): Update.
2450
2451 2019-07-10  Tom Tromey  <tromey@adacore.com>
2452
2453         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
2454         destructor.
2455         (dbx_objfile_data_key): Change type and declare later.
2456         (DBX_SYMFILE_INFO): Rewrite.
2457         * dbxread.c (dbx_objfile_data_key): Change type.
2458         (dbx_symfile_init): Update.
2459         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
2460         (coffstab_build_psymtabs, elfstab_build_psymtabs)
2461         (stabsect_build_psymtabs, _initialize_dbxread): Update.
2462
2463 2019-07-10  Tom Tromey  <tromey@adacore.com>
2464
2465         * jit.c (jit_program_space_key): Change type.  Move lower.
2466         (get_jit_program_space_data): Update.
2467         (jit_program_space_data_cleanup): Remove.
2468         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
2469         Update.
2470         (struct jit_program_space_data): Add initializers.
2471
2472 2019-07-10  Tom Tromey  <tromey@adacore.com>
2473
2474         * solib-darwin.c (struct darwin_info): Add initializers.
2475         (solib_darwin_pspace_data): Change type.
2476         (darwin_pspace_data_cleanup): Remove.
2477         (get_darwin_info, _initialize_darwin_solib): Update.
2478
2479 2019-07-10  Tom Tromey  <tromey@adacore.com>
2480
2481         * remote-sim.c (struct sim_inferior_data): Add initializers,
2482         constructor, and destructor.
2483         (sim_inferior_data_key): Change type.  Move lower.
2484         (check_for_duplicate_sim_descriptor): Update.
2485         (get_sim_inferior_data): Use new.  Update.
2486         (~sim_inferior_data_cleanup): Rename from
2487         sim_inferior_data_cleanup.  Simplify.
2488         (gdbsim_close_inferior, simulator_command)
2489         (sim_command_completer, _initialize_remote_sim): Update.
2490         (next_pid, INITIAL_PID): Move earlier.
2491
2492 2019-07-10  Tom Tromey  <tromey@adacore.com>
2493
2494         * python/python-internal.h (create_thread_object): Return
2495         gdbpy_ref.
2496         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
2497         * python/py-inferior.c (struct threadlist_entry): Add
2498         constructor.
2499         <thread_obj>: Now a gdbpy_ref.
2500         (thread_to_thread_object): Update.
2501         (add_thread_object): Use new.
2502         (delete_thread_object): Use delete.
2503         (infpy_threads): Update.
2504         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
2505         GIL.
2506
2507 2019-07-10  Tom Tromey  <tromey@adacore.com>
2508
2509         * valops.c (value_cast): Specialize error message for Ada.
2510
2511 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
2512
2513         * breakpoint.c (breakpoint_1): Update doc and parameter names.
2514
2515 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
2516
2517         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
2518         bpstat_should_step): Return bool, adjust comments.
2519         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
2520         bpstat_should_step): Likewise.
2521
2522 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
2523
2524         * features/Makefile: Use feature target descriptions for Arm.
2525         * features/arm/arm-core.c: Generate new file.
2526         * features/arm/arm-fpa.c: Likewise.
2527         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
2528         * features/arm/arm-m-profile.c: Likewise.
2529         * features/arm/arm-vfpv2.c: Likewise.
2530         * features/arm/arm-vfpv3.c: Likewise.
2531         * features/arm/xscale-iwmmxt.c: Likewise.
2532         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
2533
2534 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
2535
2536         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
2537         ptrace earlier.
2538
2539 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
2540
2541         * features/aarch64-pauth.c: Regenerate.
2542
2543 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
2544
2545         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
2546         bool.
2547         (bpstat_what): Use false instead of 0.
2548
2549 2019-07-09  Pedro Alves  <palves@redhat.com>
2550
2551         * break-catch-throw.c (is_exception_catchpoint): New.
2552         * breakpoint.c (print_one_breakpoint_location): New parameter
2553         'raw_loc'.  Handle it.  Use
2554         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
2555         looking at the breakpoint's type.
2556         (print_one_breakpoint): If handling "maint info breakpoints", also
2557         print locations of exception catchpoints.
2558         * breakpoint.h (is_exception_catchpoint): Declare.
2559
2560 2019-07-09  Pedro Alves  <palves@redhat.com>
2561
2562         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
2563         "addr" field.
2564         (allocate_location_exception_catchpoint): New.
2565         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
2566         (initialize_throw_catchpoint_ops): Install
2567         allocate_location_exception_catchpoint as allocate_location
2568         method.
2569         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
2570         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
2571         bp_loc_other.
2572         (breakpoint_address_is_meaningful): Delete.
2573         (bl_address_is_meaningful): New.
2574         (breakpoint_locations_match): Adjust comment.
2575         (bp_location_from_bp_type): New, factored out of...
2576         (bp_location::bp_location(breakpoint *)): ... this.
2577         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
2578         factored out of...
2579         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
2580         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
2581         breakpoint_address_is_meaningful.
2582         (bp_locations_compare): Adjust comment.
2583         (update_global_location_list): Use bl_address_is_meaningful
2584         instead of breakpoint_address_is_meaningful.
2585         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
2586         explicit.
2587         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
2588         * python/py-breakpoint.c (bppy_get_location): No longer check
2589         whether location is null.
2590
2591 2019-07-09  Pedro Alves  <palves@redhat.com>
2592
2593         PR c++/15468
2594         * breakpoint.c (print_one_breakpoint_location): Remove
2595         single-location assert.
2596
2597 2019-07-09  Tom Tromey  <tom@tromey.com>
2598
2599         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
2600         * configure: Rebuild.
2601         * configure.ac: Change common to gdbsupport.
2602         * gdbsupport: Rename from common.
2603         * acinclude.m4: Change common to gdbsupport.
2604         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
2605         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
2606         gdbsupport.
2607         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
2608         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
2609         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
2610         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
2611         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
2612         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
2613         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
2614         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
2615         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
2616         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
2617         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
2618         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
2619         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
2620         coff-pe-read.c, command.h, compile/compile-c-support.c,
2621         compile/compile-c.h, compile/compile-cplus-symbols.c,
2622         compile/compile-cplus-types.c, compile/compile-cplus.h,
2623         compile/compile-loc2c.c, compile/compile.c, completer.c,
2624         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
2625         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
2626         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
2627         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
2628         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
2629         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
2630         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
2631         features/aarch64-core.c, features/aarch64-fpu.c,
2632         features/aarch64-pauth.c, features/aarch64-sve.c,
2633         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
2634         features/i386/32bit-core.c, features/i386/32bit-linux.c,
2635         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
2636         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
2637         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
2638         features/i386/64bit-core.c, features/i386/64bit-linux.c,
2639         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
2640         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
2641         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
2642         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
2643         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
2644         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
2645         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
2646         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
2647         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
2648         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
2649         go32-nat.c, guile/guile.c, guile/scm-ports.c,
2650         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
2651         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
2652         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
2653         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
2654         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
2655         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
2656         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
2657         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
2658         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
2659         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
2660         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
2661         minsyms.c, mips-linux-tdep.c, namespace.h,
2662         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
2663         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
2664         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
2665         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
2666         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
2667         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
2668         nat/linux-waitpid.c, nat/mips-linux-watch.c,
2669         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
2670         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
2671         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
2672         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
2673         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
2674         procfs.c, producer.c, progspace.h, psymtab.h,
2675         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
2676         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
2677         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
2678         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
2679         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
2680         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
2681         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
2682         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
2683         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
2684         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
2685         target-memory.c, target.c, target.h, target/waitstatus.c,
2686         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
2687         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
2688         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
2689         unittests/array-view-selftests.c,
2690         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
2691         unittests/common-utils-selftests.c,
2692         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
2693         unittests/format_pieces-selftests.c,
2694         unittests/function-view-selftests.c,
2695         unittests/lookup_name_info-selftests.c,
2696         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
2697         unittests/mkdir-recursive-selftests.c,
2698         unittests/observable-selftests.c,
2699         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
2700         unittests/parse-connection-spec-selftests.c,
2701         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
2702         unittests/scoped_fd-selftests.c,
2703         unittests/scoped_mmap-selftests.c,
2704         unittests/scoped_restore-selftests.c,
2705         unittests/string_view-selftests.c, unittests/style-selftests.c,
2706         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
2707         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
2708         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
2709         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
2710         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
2711         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
2712
2713 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2714
2715         * linespec.c (decode_digits_list_mode): Set explicit_line to a
2716         bool value.
2717         (decode_digits_ordinary): Set explicit_line field in sal.
2718         * symtab.c (skip_prologue_sal): Don't skip prologue for a
2719         symtab_and_line that was set on an explicit line number in
2720         assembler code.  Do always update the recorded symtab and line if
2721         we do skip the prologue.
2722
2723 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2724
2725         * breakpoint.c (set_breakpoint_location_function): Remove
2726         explicit_loc parameter.
2727         (momentary_breakpoint_from_master): Update call to
2728         set_breakpoint_location_function.
2729         (add_location_to_breakpoint): Likewise.
2730
2731 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2732
2733         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
2734         required features based on default bfd type when no specific bfd
2735         is present.
2736
2737 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2738
2739         * NEWS: Mention that GDB printf and eval commands can now print
2740         C-style and Ada-style convenience var strings without
2741         calling the inferior.
2742         * printcmd.c (printf_c_string): Locally print GDB internal var
2743         instead of transiting via the inferior.
2744         (printf_wide_c_string): Likewise.
2745
2746 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2747
2748         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
2749
2750 2019-07-04  Tom Tromey  <tom@tromey.com>
2751
2752         PR tui/24724:
2753         * tui/tui-winsource.c (tui_clear_source_content): Update.
2754         (tui_source_window_base::set_is_exec_point_at): Fix comment.
2755         (tui_update_breakpoint_info): Update.
2756         (tui_set_exec_info_content): Update.
2757         * tui/tui-source.c (tui_set_source_content_nil): Update.
2758         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
2759         has_break.
2760         * tui/tui-data.h (enum tui_bp_flag): New.
2761         (tui_bp_flags): New enum flags type.
2762         (struct tui_source_element) <break_mode>: Change type.  Rename
2763         from has_break.
2764         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
2765         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
2766         constants.
2767         * tui/tui-winsource.h: Fix comment.
2768
2769 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2770
2771         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
2772         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
2773         (store_fpregs_to_thread)
2774         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
2775         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
2776         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
2777         (IWMMXT_REGS_SIZE): Add define.
2778         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
2779         (fetch_vfp_regs, store_vfp_regs)
2780         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
2781         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
2782
2783 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2784
2785         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
2786         defines.
2787         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
2788         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
2789         (ARM_INT_REGISTER_SIZE): ...to this.
2790         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
2791         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
2792         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
2793         (arm_linux_collect_gregset, supply_nwfpe_register)
2794         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
2795         defines.
2796         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
2797         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
2798         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
2799         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
2800         (arm_return_in_memory, arm_store_return_value)
2801         (arm_get_longjmp_target, arm_register_g_packet_guesses)
2802         (arm_record_ld_st_multiple): Likewise.
2803         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
2804         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
2805
2806 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2807
2808         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
2809         AARCH64_DISPLACED_MODIFIED_INSNS.
2810         * aarch64-tdep.c (struct aarch64_displaced_step_data)
2811         (aarch64_displaced_step_copy_insn): Likewise.
2812         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
2813         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
2814         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
2815         ARM_DISPLACED_MODIFIED_INSNS.
2816         * arm-tdep.c (arm_gdbarch_init): Likewise.
2817         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
2818         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
2819         (struct arm_displaced_step_closure): Use
2820         ARM_DISPLACED_MODIFIED_INSNS.
2821
2822 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2823
2824         * features/Makefile: Remove unused xml files.
2825         * features/aarch64.xml: Remove.
2826         * features/i386/amd64-avx-avx512-linux.xml: Remove.
2827         * features/i386/amd64-avx-avx512.xml: Remove.
2828         * features/i386/amd64-avx-linux.xml: Remove.
2829         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
2830         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
2831         * features/i386/amd64-avx-mpx-linux.xml: Remove.
2832         * features/i386/amd64-avx-mpx.xml: Remove.
2833         * features/i386/amd64-avx.xml: Remove.
2834         * features/i386/amd64-linux.xml: Remove.
2835         * features/i386/amd64-mpx-linux.xml: Remove.
2836         * features/i386/amd64-mpx.xml: Remove.
2837         * features/i386/amd64.xml: Remove.
2838         * features/i386/i386-avx-avx512-linux.xml: Remove.
2839         * features/i386/i386-avx-avx512.xml: Remove.
2840         * features/i386/i386-avx-linux.xml: Remove.
2841         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
2842         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
2843         * features/i386/i386-avx-mpx-linux.xml: Remove.
2844         * features/i386/i386-avx-mpx.xml: Remove.
2845         * features/i386/i386-avx.xml: Remove.
2846         * features/i386/i386-linux.xml: Remove.
2847         * features/i386/i386-mmx-linux.xml: Remove.
2848         * features/i386/i386-mmx.xml: Remove.
2849         * features/i386/i386-mpx-linux.xml: Remove.
2850         * features/i386/i386-mpx.xml: Remove.
2851         * features/i386/i386.xml: Remove.
2852         * features/i386/x32-avx-avx512-linux.xml: Remove.
2853         * features/i386/x32-avx-linux.xml: Remove.
2854         * features/i386/x32-linux.xml: Remove.
2855
2856 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2857
2858         * regformats/aarch64.dat: Remove.
2859         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
2860         * regformats/i386/amd64-avx-linux.dat: Remove.
2861         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
2862         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
2863         * regformats/i386/amd64-linux.dat: Remove.
2864         * regformats/i386/amd64-mpx-linux.dat: Remove.
2865         * regformats/i386/amd64.dat: Remove.
2866         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
2867         * regformats/i386/i386-avx-linux.dat: Remove.
2868         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
2869         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
2870         * regformats/i386/i386-linux.dat: Remove.
2871         * regformats/i386/i386-mmx-linux.dat: Remove.
2872         * regformats/i386/i386-mpx-linux.dat: Remove.
2873         * regformats/i386/i386.dat: Remove.
2874         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
2875         * regformats/i386/x32-avx-linux.dat: Remove.
2876         * regformats/i386/x32-linux.dat: Remove.
2877
2878 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2879
2880         * aarch64-tdep.c: Remove xml self tests.
2881         * amd64-linux-tdep.c: Likewise.
2882         * amd64-tdep.c: Likewise.
2883         * i386-linux-tdep.c: Likewise.
2884         * i386-tdep.c: Likewise.
2885
2886 2019-07-03  Pedro Alves  <palves@redhat.com>
2887
2888         PR cli/24732
2889         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
2890         (pipe_cmd_option_defs): New.
2891         (make_pipe_cmd_options_def_group): New.
2892         (pipe_command): Use gdb::option::process_options.
2893         (pipe_command_completer): New function.
2894         (_initialize_cli_cmds): Install completer for "pipe" command.
2895
2896 2019-07-03  Pedro Alves  <palves@redhat.com>
2897
2898         * cli/cli-option.c (union option_value) <string>: New field.
2899         (struct option_def_and_value): Add ctor, move ctor, dtor and
2900         use DISABLE_COPY_AND_ASSIGN.
2901         (option_def_and_value::clear_value): New.
2902         (parse_option, save_option_value_in_ctx, get_val_type_str)
2903         (add_setshow_cmds_for_options): Handle var_string.
2904         * cli-option.h (union option_def::var_address) <string>: New
2905         field.
2906         (struct string_option_def): New.
2907         * maint-test-options.c (struct test_options_opts): Add default
2908         ctor and use DISABLE_COPY_AND_ASSIGN.
2909         <string_opt>: New field.
2910         (test_options_opts::~test_options_opts): New.
2911         (test_options_opts::dump): Also dump "-string".
2912         (test_options_option_defs): Install "string.
2913
2914 2019-07-03  Pedro Alves  <palves@redhat.com>
2915
2916         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
2917         option_value with a null enumeration.
2918         (complete_options): Save the option values in the context.
2919         (save_option_value_in_ctx): New, factored out from ...
2920         (process_options): ... here.
2921         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
2922         of the function.
2923         * maint-test-options.c (test_options_opts::dump): New, factored
2924         out from ...
2925         (maintenance_test_options_command_mode): ... here.
2926         (maintenance_test_options_command_completion_result): Delete.
2927         (maintenance_test_options_command_completion_text): Update
2928         comment.
2929         (maintenance_show_test_options_completion_result): Change
2930         prototype.  Just print
2931         maintenance_test_options_command_completion_text.
2932         (save_completion_result): New.
2933         (maintenance_test_options_completer_mode): Pass options context to
2934         complete_options, and then save a dump.
2935         (_initialize_maint_test_options): Use add_cmd to install "maint
2936         show test-options-completion-result".
2937
2938 2019-07-03  Pedro Alves  <palves@redhat.com>
2939
2940         * NEWS (New commands): Mention "with" and "maint with".
2941         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
2942         (with_command, with_command_completer): New.
2943         (pipe_command): Adjust to new repeat_previous
2944         interface.
2945         (_initialize_cli_cmds): Install the "with" command and its "w"
2946         alias.
2947         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
2948         declarations.
2949         * cli/cli-setshow.c (parse_cli_var_uinteger)
2950         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
2951         argument strings for all var_types.
2952         (get_setshow_command_value_string): New, factored out from ...
2953         (do_show_command): ... this.
2954         * cli/cli-setshow.h: Include <string>.
2955         (get_setshow_command_value_string): Declare.
2956         * command.h (repeat_previous): Now returns const char *.  Adjust
2957         comment.
2958         * maint.c: Include "cli/cli-cmds.h".
2959         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
2960         (_initialize_maint_cmds): Register the "maintenance with" command.
2961         * top.c (repeat_previous): Move bits from pipe_command here:
2962         Return the saved command line, if any; error out if there's no
2963         command to relaunch.
2964
2965 2019-07-03  Pedro Alves  <palves@redhat.com>
2966
2967         * NEWS (New commands): Mention "maint set/show test-settings"
2968         instead of "maint test-settings".
2969         * maint-test-settings.c (maintenance_test_settings_list): Delete.
2970         (maintenance_test_settings_set_list): Rename to ...
2971         (maintenance_set_test_settings_list): ... this.
2972         (maintenance_test_settings_show_list): Rename to  ...
2973         (maintenance_show_test_settings_list): ... this.
2974         (maintenance_test_settings_cmd): Delete.
2975         (maintenance_test_settings_set_cmd): ...
2976         (maintenance_set_test_settings_cmd): ... this.
2977         (maintenance_test_settings_show_cmd): ...
2978         (maintenance_show_test_settings_cmd): ... this.
2979         (maintenance_test_settings_show_value_cmd):
2980         (maintenance_show_test_settings_value_cmd): ... this.
2981         (_initialize_maint_test_settings): No longer install the "maint
2982         test-settings" prefix command.  Rename "maint test-settings set"
2983         to "maint set test-settings", and "maint test-settings show" to
2984         "maint show test-settings".  Adjust all subcommands.
2985
2986 2019-07-03  Pedro Alves  <palves@redhat.com>
2987
2988         * maint-test-settings.c: Fix file's intro comment.  Replace all
2989         references to "test-options" with references to "test-settings",
2990         in comments.
2991
2992 2019-07-03  Pedro Alves  <palves@redhat.com>
2993
2994         * maint-test-settings.c (maintenance_test_settings_xxx)
2995         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
2996         New.
2997         (maintenance_test_settings_enums): Use them.
2998         (maintenance_test_settings_enum): Default to
2999         maintenance_test_settings_xxx.
3000         (_initialize_maint_test_settings): Initialize
3001         MAINTENANCE_TEST_SETTINGS_FILENAME.
3002
3003 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
3004
3005         * breakpoint.h (remove_breakpoints_inf): Change return type to
3006         void, move function documentation here.
3007         * breakpoint.c (remove_breakpoints_inf): Change return type to
3008         void, move function documentation to header.
3009
3010 2019-07-02  Pedro Alves  <palves@redhat.com>
3011
3012         * NEWS (Completion improvements): Mention "info threads".
3013         * thread.c (struct info_threads_opts, info_threads_option_defs)
3014         (make_info_threads_options_def_group): New.
3015         (info_threads_command): Use gdb::option::process_options.
3016         (info_threads_command_completer): New.
3017         (_initialize_thread): Use gdb::option::build_help to build the
3018         help text for "info threads".
3019
3020 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
3021
3022         * defs.h (generic_load): Move from here...
3023         * symfile.h (generic_load): ... to here.  Rename name parameter
3024         to args.
3025         * symfile.c (generic_load): Add comment.
3026
3027 2019-07-01  Tom Tromey  <tromey@adacore.com>
3028
3029         * dwarf2read.c
3030         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
3031         declaration of without_params.  Fix formatting.
3032
3033 2019-07-01  Tom Tromey  <tromey@adacore.com>
3034
3035         * ada-exp.y (find_primitive_type): Update.
3036         * ada-lang.h (ada_lookup_symbol): Update.
3037         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
3038         parameter.
3039         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
3040
3041 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
3042
3043         PR breakpoints/24541
3044         * gdbarch.c: Regenerate.
3045         * gdbarch.h: Regenerate.
3046         * gdbarch.sh: Add 'stap_adjust_register'.
3047         * i386-tdep.c: Include '<unordered_set>'.
3048         (i386_stap_adjust_register): New function.
3049         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
3050         * stap-probe.c (stap_parse_register_operand): Call
3051         'gdbarch_stap_adjust_register'.
3052
3053 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
3054
3055         PR python/24742
3056         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
3057         * python/python.c (do_start_initialization): Use 'xmalloc'
3058         instead of 'PyMem_Malloc'.
3059
3060 2019-06-28  Tom Tromey  <tromey@adacore.com>
3061
3062         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
3063         for Ada.
3064
3065 2019-06-27  Tom Tromey  <tromey@adacore.com>
3066
3067         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
3068         objfile_key.
3069         (arm_find_mapping_symbol, arm_record_special_symbol)
3070         (_initialize_arm_tdep): Update.
3071         (arm_objfile_data_free): Remove.
3072
3073 2019-06-27  Tom Tromey  <tromey@adacore.com>
3074
3075         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
3076         to cp_print_static_field.
3077
3078 2019-06-26  Tom Tromey  <tromey@adacore.com>
3079
3080         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
3081         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
3082         declare.
3083
3084 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
3085
3086         * features/aarch64-core.c (create_feature_aarch64_core):
3087         Regenerate.
3088         * features/aarch64-core.xml: Add cpsr flags.
3089
3090 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
3091
3092         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
3093         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
3094
3095 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
3096
3097         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
3098         field.
3099         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
3100         use.
3101         (arm_record_special_symbol): Don't insert new symbol in sorted
3102         position, push it at the end.
3103
3104 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
3105
3106         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
3107         (arm_mapping_symbol_s): Remove.
3108         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
3109         (arm_mapping_symbol_vec): New typedef.
3110         (struct arm_per_objfile): Add constructor.
3111         <section_maps>: Change type to
3112         std::unique_ptr<arm_mapping_symbol_vec[]>.
3113         (arm_compare_mapping_symbols): Remove.
3114         (arm_find_mapping_symbol): Adjust to section_maps type change.
3115         (arm_objfile_data_free): Call delete on arm_per_objfile.
3116         (arm_record_special_symbol): Adjust to section_maps type change.
3117         Allocate arm_per_objfile with new.
3118
3119 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3120
3121         * cli/cli-cmds.c (alias_command): Compare the alias prefix
3122         with the command prefix.
3123
3124 2019-06-25  Tom Tromey  <tom@tromey.com>
3125
3126         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
3127         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
3128
3129 2019-06-25  Tom Tromey  <tom@tromey.com>
3130
3131         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
3132         type.
3133         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
3134         protected.
3135
3136 2019-06-25  Tom Tromey  <tom@tromey.com>
3137
3138         * tui/tui-winsource.c
3139         (tui_source_window_base::set_is_exec_point_at): Add check against
3140         LOA_ADDRESS.
3141
3142 2019-06-25  Tom Tromey  <tom@tromey.com>
3143
3144         * tui/tui-source.c (tui_set_source_content): Don't check before
3145         xfree.
3146         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
3147
3148 2019-06-25  Tom Tromey  <tom@tromey.com>
3149
3150         * tui/tui-winsource.h (tui_update_source_window_as_is)
3151         (tui_alloc_source_buffer, tui_line_is_displayed)
3152         (tui_addr_is_displayed): Change type of win_info.
3153         * tui/tui-winsource.c (tui_update_source_window_as_is)
3154         (tui_clear_source_content, tui_show_source_line)
3155         (tui_show_source_content, tui_source_window_base::refill)
3156         (tui_source_window_base::set_is_exec_point_at)
3157         (tui_source_window_base::set_is_exec_point_at)
3158         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
3159         (tui_alloc_source_buffer, tui_line_is_displayed)
3160         (tui_addr_is_displayed): Change type of win_info.  Update.
3161         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
3162         (tui_source_window_base::do_make_visible_with_new_height):
3163         Update.
3164         * tui/tui-source.c (tui_set_source_content)
3165         (tui_set_source_content_nil)
3166         (tui_source_window::do_scroll_vertical): Update.
3167         * tui/tui-layout.c (show_layout): Update.
3168         * tui/tui-disasm.c (tui_set_disassem_content)
3169         (tui_disasm_window::do_scroll_vertical): Update.
3170         * tui/tui-data.h (tui_win_content): Remove.
3171         (struct tui_gen_win_info) <content, content_size>: Remove.
3172         (struct tui_source_element): Add initializers and destructor.
3173         (union tui_which_element, struct tui_win_element): Remove.
3174         (struct tui_source_window_base) <content>: New field.
3175         (struct tui_data_window): Remove destructor.
3176         (tui_alloc_content, tui_free_win_content)
3177         (tui_free_all_source_wins_content): Don't declare.
3178         * tui/tui-data.c (tui_initialize_static_data): Update.
3179         (init_content_element, tui_alloc_content): Remove.
3180         (~tui_gen_win_info): Update.
3181         (~tui_data_window, tui_free_all_source_wins_content)
3182         (tui_free_win_content, free_content, free_content_elements):
3183         Remove.
3184
3185 2019-06-25  Tom Tromey  <tom@tromey.com>
3186
3187         * tui/tui-winsource.h (tui_clear_source_content)
3188         (tui_erase_source_content, tui_show_source_content): Change type
3189         of win_info.
3190         * tui/tui-winsource.c (tui_clear_source_content)
3191         (tui_erase_source_content, tui_show_source_content): Change type
3192         of win_info.
3193         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
3194         * tui/tui-source.h (tui_set_source_content_nil): Change type of
3195         win_info.
3196         * tui/tui-source.c (tui_set_source_content_nil): Change type of
3197         win_info.
3198         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
3199
3200 2019-06-25  Tom Tromey  <tom@tromey.com>
3201
3202         * tui/tui-winsource.c (tui_clear_source_content)
3203         (tui_source_window_base::set_is_exec_point_at): Update.
3204         * tui/tui-source.c (tui_set_source_content_nil): Update.
3205         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
3206         a bool.
3207         * tui/tui-data.c (init_content_element): Update.
3208
3209 2019-06-25  Tom Tromey  <tom@tromey.com>
3210
3211         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
3212         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
3213         * tui/tui-layout.c (init_and_make_win): Update.
3214         * tui/tui.h (enum tui_win_type): Update.
3215         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
3216         tui_win_is_auxillary.
3217         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
3218         tui_win_is_auxillary.
3219
3220 2019-06-25  Tom Tromey  <tom@tromey.com>
3221
3222         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
3223         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
3224         (tui_delete_data_content_windows, tui_display_all_data)
3225         (tui_data_window::do_scroll_vertical, tui_display_data_from):
3226         Update.
3227         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
3228         * tui/tui-regs.c (tui_last_regs_line_no)
3229         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
3230         (tui_show_registers): Update.
3231         (tui_show_register_group): Return void.  Update.
3232         (tui_display_registers_from, tui_display_reg_element_at_line)
3233         (tui_display_registers_from_line, tui_check_register_values):
3234         Update.
3235         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
3236         member.
3237         (struct tui_data_window) <regs_content>: Now a std::vector.
3238         <regs_content_count>: Remove.
3239         (tui_add_content_elements, tui_free_data_content): Don't declare.
3240         * tui/tui-data.c (tui_data_window::clear_detail): Update.
3241         (init_content_element): Remove DATA_WIN case.  Add assert.
3242         (tui_add_content_elements): Remove.
3243         (tui_data_window): Update.
3244         (tui_free_data_content): Remove.
3245         (free_content_elements): Remove DATA_WIN case.
3246
3247 2019-06-25  Tom Tromey  <tom@tromey.com>
3248
3249         * tui/tui-data.c (tui_data_item_window): Update.
3250         * tui/tui-windata.h (tui_check_data_values): Don't declare.
3251         * tui/tui-windata.c (tui_display_all_data)
3252         (tui_display_data_from_line): Update.
3253         (tui_check_data_values): Remove.
3254         * tui/tui-regs.c (tui_show_register_group)
3255         (tui_display_reg_element_at_line): Update.
3256         * tui/tui-hooks.c (tui_register_changed)
3257         (tui_refresh_frame_and_register_information): Call
3258         tui_check_register_values.
3259         * tui/tui-data.h (struct tui_data_window) <data_content,
3260         data_content_count, data_type>: Remove.
3261         (enum tui_data_type): Remove.
3262
3263         * tui/tui-data.c (tui_data_window::clear_detail)
3264         (~tui_data_window): Update.
3265
3266 2019-06-25  Tom Tromey  <tom@tromey.com>
3267
3268         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
3269         declare.
3270         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
3271         Rename from tui_first_data_item_displayed.  Update.
3272         (tui_data_window::refresh_all)
3273         (tui_data_window::do_scroll_vertical): Update.
3274         * tui/tui-data.h (struct tui_data_window)
3275         <first_data_item_displayed>: Declare new method.
3276
3277 2019-06-25  Tom Tromey  <tom@tromey.com>
3278
3279         * tui/tui-data.h (tui_init_generic_part): Don't declare.
3280         * tui/tui-data.c (tui_init_generic_part): Remove, moving
3281         contents...
3282         (tui_initialize_static_data): ...here.
3283
3284 2019-06-25  Tom Tromey  <tom@tromey.com>
3285
3286         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
3287         (tui_display_registers_from, tui_check_register_values): Update.
3288         (tui_display_register): Remove win_info parameter; update.
3289         (tui_get_register): Change type of parameters.
3290         * tui/tui-data.h (struct tui_data_element): Remove.
3291         (union tui_which_element) <data>: Remove.
3292         <data_window>: Change type.
3293         (struct tui_data_item_window): New.
3294         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
3295         case.  Add assert.
3296         (~tui_data_item_window): New destructor.
3297         (free_content_elements): Remove DATA_ITEM_WIN case.
3298
3299 2019-06-25  Tom Tromey  <tom@tromey.com>
3300
3301         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
3302         Remove.
3303
3304 2019-06-25  Tom Tromey  <tom@tromey.com>
3305
3306         * tui/tui-data.h (struct tui_command_element): Remove.
3307         (union tui_which_element) <command>: Remove.
3308         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
3309         assert.
3310         (free_content_elements): Remove CMD_WIN case.
3311
3312 2019-06-25  Tom Tromey  <tom@tromey.com>
3313
3314         * tui/tui-layout.c (tui_set_layout): Update.
3315         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
3316         * tui/tui-data.c (layout_def): Update.
3317
3318 2019-06-25  Tom Tromey  <tom@tromey.com>
3319
3320         * tui/tui-wingeneral.c (tui_refresh_all): Update.
3321         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
3322         (tui_source_window_base::set_new_height): Update.
3323         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
3324         Update.
3325         (tui_set_locator_fullname, tui_set_locator_info)
3326         (tui_show_frame_info): Update.
3327         * tui/tui-source.c (tui_set_source_content)
3328         (tui_source_is_displayed): Update.
3329         * tui/tui-layout.c (show_source_disasm_command, show_data)
3330         (show_source_or_disasm_and_command): Update.
3331         * tui/tui-disasm.c (tui_set_disassem_content)
3332         (tui_get_begin_asm_address): Update.
3333         * tui/tui-data.h (struct tui_locator_element): Remove.
3334         (union tui_which_element) <locator>: Remove.
3335         (struct tui_locator_window): New.
3336         (tui_locator_win_info_ptr): Change return type.
3337         * tui/tui-data.c (_locator): Change type.
3338         (tui_locator_win_info_ptr): Change return type.
3339         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
3340         (tui_alloc_content): Add assert.
3341
3342 2019-06-25  Tom Tromey  <tom@tromey.com>
3343
3344         * tui/tui-winsource.c
3345         (tui_exec_info_window::maybe_allocate_content): New method.
3346         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
3347         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
3348         (make_source_or_disasm_window): Add cast.
3349         * tui/tui-data.h (union tui_which_element) <simple_string>:
3350         Remove.
3351         (struct tui_source_info): New.
3352         (struct tui_source_window_base) <execution_info>: Change type.
3353         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
3354         case, and add assert.
3355         (tui_alloc_content): Add assert.
3356
3357 2019-06-25  Tom Tromey  <tom@tromey.com>
3358
3359         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
3360         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
3361         * tui/tui-data.c (tui_alloc_win_info): Remove.
3362
3363 2019-06-25  Tom Tromey  <tom@tromey.com>
3364
3365         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
3366         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
3367         can_highlight.
3368
3369 2019-06-25  Tom Tromey  <tom@tromey.com>
3370
3371         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
3372         make_visible_with_new_height method.
3373         (tui_win_info::make_visible_with_new_height): New method.
3374         (tui_source_window_base::do_make_visible_with_new_height)
3375         (tui_data_window::do_make_visible_with_new_height)
3376         (tui_cmd_window::do_make_visible_with_new_height): New methods.
3377         (make_visible_with_new_height): Remove.
3378         (tui_resize_all, tui_adjust_win_heights): Use
3379         make_visible_with_new_height method.
3380         * tui/tui-data.h (struct tui_win_info)
3381         <do_make_visible_with_new_height, make_visible_with_new_height>:
3382         New methods.
3383         (struct tui_source_window_base, struct tui_data_window)
3384         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
3385         methods.
3386
3387 2019-06-25  Tom Tromey  <tom@tromey.com>
3388
3389         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
3390         method.
3391         (update_tab_width): Call update_tab_width method.
3392         * tui/tui-data.h (struct tui_win_info)
3393         (struct tui_source_window_base) <update_tab_width>: New methods.
3394
3395 2019-06-25  Tom Tromey  <tom@tromey.com>
3396
3397         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
3398         parameter.
3399         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
3400         parameter.
3401         (tui_gen_win_info::make_visible): Update.
3402         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
3403         parameter.
3404         * tui/tui-data.h (enum tui_box): New enum.
3405         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
3406
3407 2019-06-25  Tom Tromey  <tom@tromey.com>
3408
3409         * tui/tui-layout.c (make_source_or_disasm_window): Always use
3410         init_and_make_win for EXEC_INFO_WIN.
3411         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
3412         longer inline.
3413         (struct tui_win_info) <~tui_win_info>: Inline.
3414         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
3415         Don't declare.
3416         * tui/tui-data.c (source_win, disasm_win): Remove globals.
3417         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
3418         Remove.
3419         (tui_initialize_static_data): Update.
3420         (~tui_gen_win_info): Handle more cleanup here.
3421         (~tui_source_window_base): Delete "execution_info".
3422         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
3423
3424 2019-06-25  Tom Tromey  <tom@tromey.com>
3425
3426         * tui/tui-layout.c (make_command_window): Don't set
3427         can_highlight.
3428         (show_source_disasm_command): Call the reset method.
3429         (show_data): Don't set can_highlight.  Call the reset method.
3430         (tui_gen_win_info::reset): Rename from init_gen_win_info
3431         (init_and_make_win): Simplify.  Return tui_gen_win_info.
3432         (show_source_or_disasm_and_command): Call the reset method.
3433         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
3434         (struct tui_cmd_window): Set can_highlight.
3435
3436 2019-06-25  Tom Tromey  <tom@tromey.com>
3437
3438         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
3439         from make_visible.
3440         (tui_make_visible, tui_make_invisible): Rewrite.
3441         (tui_win_info::make_visible): Remove.
3442         (tui_source_window_base::make_visible): Update.
3443         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
3444         method.  Moved from...
3445         (struct tui_win_info) <make_visible>: ...here.
3446
3447 2019-06-25  Tom Tromey  <tom@tromey.com>
3448
3449         * tui/tui-winsource.c
3450         (tui_source_window_base::do_scroll_horizontal): Remove direction
3451         parameter.
3452         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
3453         direction parameter.
3454         * tui/tui-win.c (tui_win_info::forward_scroll)
3455         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
3456         (tui_win_info::right_scroll): Update.
3457         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
3458         direction parameter.
3459         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
3460         direction parameter.
3461         * tui/tui-data.h (enum tui_scroll_direction): Remove.
3462         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
3463         Remove direction parameter.
3464         (struct tui_source_window_base, struct tui_source_window)
3465         (struct tui_disasm_window, struct tui_data_window)
3466         (struct tui_cmd_window): Update.
3467
3468 2019-06-25  Tom Tromey  <tom@tromey.com>
3469
3470         * tui/tui-winsource.h (tui_set_exec_info_content)
3471         (tui_show_exec_info_content, tui_erase_exec_info_content)
3472         (tui_clear_exec_info_content, tui_update_exec_info): Change
3473         argument to tui_source_window_base.
3474         * tui/tui-winsource.c (tui_set_exec_info_content)
3475         (tui_show_exec_info_content, tui_erase_exec_info_content)
3476         (tui_clear_exec_info_content, tui_update_exec_info): Change
3477         argument to tui_source_window_base.
3478
3479 2019-06-25  Tom Tromey  <tom@tromey.com>
3480
3481         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
3482         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
3483
3484 2019-06-25  Tom Tromey  <tom@tromey.com>
3485
3486         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
3487         check.
3488
3489 2019-06-25  Tom Tromey  <tom@tromey.com>
3490
3491         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
3492         type to void.
3493         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
3494         type to void.
3495         * tui/tui-source.c (tui_set_source_content): Update.
3496         * tui/tui-disasm.c (tui_set_disassem_content): Update.
3497
3498 2019-06-25  Tom Tromey  <tom@tromey.com>
3499
3500         * tui/tui-win.c (window_name_completer, tui_set_focus)
3501         (tui_all_windows_info): Use name method.
3502         * tui/tui-data.h (struct tui_gen_win_info)
3503         (struct tui_source_window, struct tui_disasm_window)
3504         (struct tui_data_window, struct tui_cmd_window) <name>: New
3505         method.
3506         (tui_win_name): Don't declare.
3507         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
3508         (tui_win_name): Remove.
3509
3510 2019-06-25  Tom Tromey  <tom@tromey.com>
3511
3512         * tui/tui-winsource.h (tui_update_source_window)
3513         (tui_update_source_window_as_is): Change parameter type.
3514         * tui/tui-winsource.c (tui_update_source_window): Change win_info
3515         to be a tui_source_window_base.
3516         (tui_update_source_window_as_is): Likewise.
3517         * tui/tui-win.c (make_visible_with_new_height): Update.
3518
3519 2019-06-25  Tom Tromey  <tom@tromey.com>
3520
3521         * tui/tui-winsource.c (tui_erase_source_content)
3522         (tui_show_source_content, tui_show_exec_info_content)
3523         (tui_erase_exec_info_content): Use refresh_window method.
3524         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
3525         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
3526         from tui_refresh_win.
3527         (tui_data_window::refresh_window): New method.
3528         (tui_win_info::refresh, tui_source_window_base::refresh)
3529         (tui_refresh_all): Use refresh_window method.
3530         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
3531         method.
3532         * tui/tui-regs.c (tui_display_register): Call refresh_window
3533         method.
3534         * tui/tui-layout.c (show_source_disasm_command)
3535         (show_source_or_disasm_and_command): Call refresh_window method.
3536         * tui/tui-data.h (struct tui_gen_win_info)
3537         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
3538         New method.
3539
3540 2019-06-25  Tom Tromey  <tom@tromey.com>
3541
3542         * tui/tui.c (tui_rl_other_window, tui_enable)
3543         (tui_is_window_visible, tui_get_command_dimension): Update.
3544         * tui/tui-winsource.c (tui_update_source_window_as_is)
3545         (tui_clear_source_content, tui_erase_source_content)
3546         (tui_show_source_line, tui_source_window_base::refill)
3547         (tui_source_window_base::do_scroll_horizontal)
3548         (tui_source_window_base::set_is_exec_point_at)
3549         (tui_update_breakpoint_info, tui_set_exec_info_content)
3550         (tui_alloc_source_buffer, tui_line_is_displayed)
3551         (tui_addr_is_displayed): Update.
3552         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
3553         (tui_check_and_display_highlight_if_needed)
3554         (tui_win_info::make_visible, tui_win_info::refresh)
3555         (tui_refresh_all): Update.
3556         * tui/tui-windata.c (tui_first_data_item_displayed)
3557         (tui_delete_data_content_windows, tui_erase_data_content)
3558         (tui_display_all_data, tui_data_window::refresh_all)
3559         (tui_check_data_values): Update.
3560         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
3561         (tui_set_win_focus_to, tui_win_info::forward_scroll)
3562         (tui_win_info::backward_scroll, tui_refresh_all_win)
3563         (tui_resize_all, tui_set_focus, tui_all_windows_info)
3564         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
3565         (tui_source_window_base::set_new_height)
3566         (tui_data_window::set_new_height)
3567         (make_invisible_and_set_new_height)
3568         (make_visible_with_new_height, new_height_ok)
3569         (parse_scrolling_args): Update.
3570         * tui/tui-stack.c (tui_show_frame_info): Update.
3571         * tui/tui-source.c (tui_set_source_content)
3572         (tui_set_source_content_nil, tui_source_is_displayed)
3573         (tui_source_window::do_scroll_vertical): Update.
3574         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
3575         (tui_display_registers_from, tui_display_reg_element_at_line)
3576         (tui_check_register_values, tui_reg_command): Update.
3577         * tui/tui-layout.c (tui_default_win_height)
3578         (show_source_disasm_command, show_data, init_and_make_win)
3579         (show_source_or_disasm_and_command): Update.
3580         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
3581         (tui_redisplay_readline, tui_mld_flush)
3582         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
3583         (tui_getc): Update.
3584         * tui/tui-disasm.c (tui_set_disassem_content)
3585         (tui_disasm_window::do_scroll_vertical): Update.
3586         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
3587         Now virtual.
3588         (struct tui_win_info): Derive from tui_gen_win_info.
3589         <~tui_win_info>: Mark as override.
3590         <generic>: Remove member.
3591         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
3592         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
3593         (~tui_data_window, ~tui_win_info)
3594         (tui_free_all_source_wins_content): Update.
3595         * tui/tui-command.c (tui_refresh_cmd_win): Update.
3596
3597 2019-06-25  Tom Tromey  <tom@tromey.com>
3598
3599         * tui/tui-layout.c (init_and_make_win): Use new.
3600         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
3601         destructor, initializers.
3602         (tui_alloc_generic_win_info): Don't declare.
3603         * tui/tui-data.c (_locator): Add argument to constructor.
3604         (source_win, disasm_win): New globals.
3605         (exec_info): Remove.
3606         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
3607         Update.
3608         (tui_alloc_generic_win_info): Remove.
3609         (init_content_element): Use new.
3610         (tui_win_info::tui_win_info): Update.
3611         (free_content_elements) <case DATA_WIN>: Use delete.
3612
3613 2019-06-25  Tom Tromey  <tom@tromey.com>
3614
3615         * tui/tui-wingeneral.c (tui_refresh_win): Update.
3616         * tui/tui-windata.c (tui_first_data_item_displayed)
3617         (tui_delete_data_content_windows): Update.
3618         * tui/tui-win.c (tui_data_window::set_new_height): Update.
3619         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
3620         (tui_display_registers_from, tui_check_register_values): Update.
3621         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
3622         pointer.
3623         * tui/tui-data.c (init_content_element): Update.  Allocate the new
3624         window.
3625         (tui_free_data_content): Update.
3626         (free_content_elements) <case DATA_WIN>: Free the window.
3627
3628 2019-06-25  Tom Tromey  <tom@tromey.com>
3629
3630         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
3631         Update.
3632         * tui/tui-layout.c (make_command_window)
3633         (show_source_disasm_command, show_data, init_and_make_win)
3634         (show_source_or_disasm_and_command): Update.
3635         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
3636         method.
3637         <can_highight, is_highlighted>: Now bool.
3638         (tui_set_win_highlight): Don't declare.
3639         * tui/tui-data.c (tui_set_win_highlight): Remove.
3640
3641 2019-06-25  Tom Tromey  <tom@tromey.com>
3642
3643         * tui/tui-wingeneral.c (make_visible): Remove check of window
3644         type.
3645
3646 2019-06-25  Tom Tromey  <tom@tromey.com>
3647
3648         * tui/tui-win.c (tui_win_info::max_height)
3649         (tui_cmd_window::max_height): New methods.
3650         (new_height_ok): Call max_height.
3651         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
3652         <max_height>: New method.
3653
3654 2019-06-25  Tom Tromey  <tom@tromey.com>
3655
3656         * tui/tui-win.c (tui_source_window_base::set_new_height)
3657         (tui_data_window::set_new_height): New methods.
3658         (make_invisible_and_set_new_height): Call set_new_height method.
3659         * tui/tui-data.h (struct tui_win_info)
3660         (struct tui_source_window_base, struct tui_data_window)
3661         <set_new_height>: New method.
3662
3663 2019-06-25  Tom Tromey  <tom@tromey.com>
3664
3665         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
3666         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
3667         tui_refresh_data_win.
3668         * tui/tui-win.c (tui_source_window_base::refresh_all): New
3669         method.
3670         (tui_refresh_all_win): Call the refresh_all method.
3671         (tui_set_focus): Likewise.
3672         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
3673         (struct tui_source_window_base, struct tui_data_window) <refresh>:
3674         Likewise.
3675
3676 2019-06-25  Tom Tromey  <tom@tromey.com>
3677
3678         * tui/tui-winsource.h (tui_refill_source_window)
3679         (tui_set_is_exec_point_at): Don't declare.
3680         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
3681         (tui_source_window_base::refill): Rename from
3682         tui_refill_source_window.
3683         (tui_source_window_base::do_scroll_horizontal): Update.
3684         (tui_source_window_base::set_is_exec_point_at): Rename from
3685         tui_set_is_exec_point_at.
3686         (tui_update_all_breakpoint_info): Update.
3687         * tui/tui-stack.c (tui_show_frame_info): Update.
3688         * tui/tui-layout.c (show_data): Add cast.
3689         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
3690         * tui/tui-data.h (struct tui_source_window_base) <refill,
3691         set_is_exec_point_at>: New methods.
3692         (tui_source_windows, tui_add_to_source_windows): Update types.
3693         (tui_add_to_source_windows): Remove redundant declaration.
3694         * tui/tui-data.c (source_windows): Store tui_source_window_base.
3695         (tui_source_windows): Change return type.
3696         (tui_clear_source_windows_detail): Update.
3697         (tui_add_to_source_windows): Change type of parameter.
3698         (tui_free_all_source_wins_content): Update.
3699
3700 2019-06-25  Tom Tromey  <tom@tromey.com>
3701
3702         * tui/tui-wingeneral.c (tui_win_info::refresh)
3703         (tui_source_window_base::refresh): New methods.
3704         (tui_refresh_all): Call the refresh method.
3705         * tui/tui-data.h (struct tui_win_info)
3706         (struct tui_source_window_base) <refresh>: New method.
3707
3708 2019-06-25  Tom Tromey  <tom@tromey.com>
3709
3710         * tui/tui.h (tui_is_window_visible): Return bool.
3711         * tui/tui.c (tui_is_window_visible): Return bool.
3712         * tui/tui-wingeneral.c (tui_make_window, make_visible)
3713         (tui_make_visible, tui_make_invisible)
3714         (tui_win_info::make_visible)
3715         (tui_source_window_base::make_visible, make_all_visible)
3716         (tui_make_all_visible, tui_make_all_invisible): Update.
3717         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
3718         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
3719         bool.
3720         (struct tui_win_info, struct tui_source_window_base)
3721         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
3722         * tui/tui-data.c (tui_init_generic_part): Update.
3723
3724 2019-06-25  Tom Tromey  <tom@tromey.com>
3725
3726         * tui/tui-wingeneral.c (tui_win_info::make_visible)
3727         (tui_source_window_base::make_visible): New methods.
3728         (make_all_visible): Make method call.
3729         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
3730         (struct tui_source_window_base, struct tui_cmd_window): Override
3731         make_visible.
3732         (tui_win_is_source_type): Don't declare.
3733         * tui/tui-data.c (tui_win_is_source_type): Remove.
3734
3735 2019-06-25  Tom Tromey  <tom@tromey.com>
3736
3737         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
3738         NULL check.
3739
3740 2019-06-25  Tom Tromey  <tom@tromey.com>
3741
3742         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
3743         Inline constructor.  Add initializers for members.
3744         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
3745         constructors; now inline in class.
3746
3747 2019-06-25  Tom Tromey  <tom@tromey.com>
3748
3749         * tui/tui-regs.c (tui_show_registers): Update.
3750         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
3751         bool.
3752         * tui/tui-data.c (tui_data_window::clear_detail)
3753         (tui_data_window): Update.
3754
3755 2019-06-25  Tom Tromey  <tom@tromey.com>
3756
3757         * tui/tui-windata.c (tui_display_all_data)
3758         (tui_display_data_from_line, tui_display_data_from)
3759         (tui_check_data_values, tui_data_window::do_scroll_vertical):
3760         Update.
3761         * tui/tui-regs.c (tui_last_regs_line_no)
3762         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
3763         (tui_show_registers, tui_show_register_group)
3764         (tui_display_registers_from, tui_display_reg_element_at_line)
3765         (tui_display_registers_from_line, tui_check_register_values)
3766         (tui_reg_next, tui_reg_prev): Update.
3767         * tui/tui-layout.c (tui_set_layout, show_data): Update.
3768         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
3769         tui_data_window.
3770         (struct tui_win_info) <detail>: Remove.  Add new fields from
3771         tui_data_info.
3772         (TUI_DATA_WIN): Add cast.
3773         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
3774         (~tui_data_window): Simplify.
3775
3776 2019-06-25  Tom Tromey  <tom@tromey.com>
3777
3778         * tui/tui-layout.c (show_source_disasm_command)
3779         (show_source_or_disasm_and_command): Update.
3780         * tui/tui-io.c (update_cmdwin_start_line)
3781         (tui_redisplay_readline): Update.
3782         * tui/tui-data.h (struct tui_command_info): Remove.
3783         (struct tui_win_info) <detail>: Remove command_info member.
3784         (struct tui_data_window) <start_line>: New member, from
3785         tui_command_info.
3786         (TUI_CMD_WIN): Add casts.
3787
3788 2019-06-25  Tom Tromey  <tom@tromey.com>
3789
3790         * tui/tui-winsource.c (tui_update_source_window)
3791         (tui_refill_source_window)
3792         (tui_source_window_base::do_scroll_horizontal)
3793         (tui_update_breakpoint_info, tui_set_exec_info_content)
3794         (tui_show_exec_info_content, tui_erase_exec_info_content)
3795         (tui_clear_exec_info_content): Update.
3796         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
3797         Update.
3798         * tui/tui-win.c (make_invisible_and_set_new_height)
3799         (make_visible_with_new_height): Update.
3800         * tui/tui-source.c (tui_set_source_content)
3801         (tui_show_symtab_source): Update.
3802         * tui/tui-layout.c (extract_display_start_addr)
3803         (show_source_disasm_command, show_data)
3804         (make_source_or_disasm_window)
3805         (show_source_or_disasm_and_command): Update.
3806         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
3807         (tui_disasm_window::do_scroll_vertical): Remove shadowing
3808         "gdbarch".
3809         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
3810         to tui_source_window_base.
3811         (struct tui_win_info) <detail>: Remove source_info member.
3812         (struct tui_source_window_base) <has_locator>: Inline.
3813         Move contents from tui_source_info; rename has_locator member to
3814         m_has_locator.
3815         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
3816         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
3817         header file.
3818         (tui_source_window_base::clear_detail, ~tui_source_window_base):
3819         Simplify.
3820         (tui_free_all_source_wins_content): Cast to
3821         tui_source_window_base.
3822
3823 2019-06-25  Tom Tromey  <tom@tromey.com>
3824
3825         * tui/tui-win.c (make_invisible_and_set_new_height)
3826         (make_visible_with_new_height): Call has_locator method.
3827         * tui/tui-layout.c (show_source_disasm_command, show_data)
3828         (show_source_or_disasm_and_command): Update for bool change.
3829         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
3830         (tui_win_info) <has_locator>: New method.
3831         (struct tui_source_window_base) <has_locator>: New method.
3832         (tui_win_has_locator): Don't declare.
3833         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
3834         from tui_win_has_locator.
3835         (tui_source_window_base): Use false, not FALSE.
3836
3837 2019-06-25  Tom Tromey  <tom@tromey.com>
3838
3839         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
3840         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
3841         clear_detail method directly.
3842         (tui_clear_win_detail): Remove.
3843
3844 2019-06-25  Tom Tromey  <tom@tromey.com>
3845
3846         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
3847         "this", not TUI_DISASM_WIN.
3848
3849 2019-06-25  Tom Tromey  <tom@tromey.com>
3850
3851         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
3852         declare.
3853         * tui/tui-winsource.c
3854         (tui_source_window_base::do_scroll_horizontal): Rename from
3855         tui_horizontal_source_scroll.
3856         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
3857         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
3858         from tui_vertical_data_scroll.
3859         * tui/tui-win.h (tui_scroll): Don't declare.
3860         * tui/tui-win.c (tui_win_info::forward_scroll)
3861         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
3862         (tui_win_info::right_scroll): Rename and update.
3863         (tui_scroll_forward_command, tui_scroll_backward_command)
3864         (tui_scroll_left_command, tui_scroll_right_command): Update.
3865         (tui_scroll): Remove.
3866         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
3867         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
3868         from tui_vertical_source_scroll.
3869         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
3870         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
3871         from tui_vertical_disassem_scroll.
3872         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
3873         do_scroll_horizontal>: New methods.
3874         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
3875         Likewise.
3876         (struct tui_source_window_base): Add do_scroll_horizontal.
3877         (struct tui_source_window, struct tui_disasm_window): Add
3878         do_scroll_vertical.
3879         (struct tui_data_window, struct tui_cmd_window): Add
3880         do_scroll_horizontal and do_scroll_vertical.
3881         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
3882
3883 2019-06-25  Tom Tromey  <tom@tromey.com>
3884
3885         * tui/tui-data.h (struct tui_source_window_base): New struct.
3886         (struct tui_source_window): Derive from tui_source_window_base.
3887         (struct tui_disasm_window): New struct.
3888         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
3889         from tui_source_window::clear_detail.
3890         (tui_source_window_base): Rename from tui_source_window.
3891         (~tui_source_window_base): Rename from ~tui_source_window.
3892         (tui_alloc_win_info): Create a tui_disasm_window.
3893
3894 2019-06-25  Tom Tromey  <tom@tromey.com>
3895
3896         * tui/tui-data.h (struct tui_source_window)
3897         (struct tui_data_window): Declare destructors.
3898         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
3899         destructors.
3900         (tui_win_info): Simplify.
3901
3902 2019-06-25  Tom Tromey  <tom@tromey.com>
3903
3904         * tui/tui-winsource.c (tui_display_main)
3905         (tui_update_source_windows_with_addr)
3906         (tui_update_all_breakpoint_info): Update.
3907         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
3908         (new_height_ok, parse_scrolling_args): Update.
3909         * tui/tui-stack.c (tui_show_frame_info): Update.
3910         * tui/tui-data.h (struct tui_list): Remove.
3911         (tui_source_windows): Return a reference to a std::vector.
3912         * tui/tui-data.c (source_windows): Now a std::vector.
3913         (tui_source_windows): Change return type.
3914         (tui_clear_source_windows): Rewrite.
3915         (tui_clear_source_windows_detail, tui_add_to_source_windows)
3916         (tui_free_all_source_wins_content): Rewrite.
3917
3918 2019-06-25  Tom Tromey  <tom@tromey.com>
3919
3920         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
3921         (struct tui_data_window, struct tui_cmd_window): Declare
3922         clear_detail method.
3923         * tui/tui-data.c (tui_source_window::clear_detail)
3924         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
3925         methods.
3926         (tui_clear_win_detail): Simplify.
3927
3928 2019-06-25  Tom Tromey  <tom@tromey.com>
3929
3930         * tui/tui-layout.c (make_source_window, make_disasm_window)
3931         (make_source_or_disasm_window): Remove win_info_ptr parameter.
3932         Return the new window.
3933         (show_source_disasm_command, show_data)
3934         (show_source_or_disasm_and_command): Update.
3935
3936 2019-06-25  Tom Tromey  <tom@tromey.com>
3937
3938         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
3939         parameter.  Return the new window.
3940         (show_source_disasm_command): Update and remove NULL check.
3941         (show_source_or_disasm_and_command): Update.
3942
3943 2019-06-25  Tom Tromey  <tom@tromey.com>
3944
3945         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
3946
3947 2019-06-25  Tom Tromey  <tom@tromey.com>
3948
3949         * tui/tui-data.h (struct tui_win_info): Make constructor
3950         protected.  Make destructor virtual.  Add initializers.
3951         (tui_source_window, tui_data_window, tui_cmd_window): New
3952         classes.
3953         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
3954         constructor.  Add "type" parameter.
3955         (tui_source_window, tui_data_window, tui_cmd_window): New
3956         constructors.
3957         (tui_alloc_win_info): Instantiate the appropriate subclass.
3958
3959 2019-06-25  Tom Tromey  <tom@tromey.com>
3960
3961         * tui/tui-win.c (tui_resize_all): Use delete.
3962         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
3963         destructor.
3964         (tui_free_window): Don't declare.
3965         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
3966         Update.
3967
3968 2019-06-25  Tom Tromey  <tom@tromey.com>
3969
3970         * tui/tui-data.h (struct tui_win_info): Add constructor.
3971         * tui/tui-data.c (tui_alloc_win_info): Use new.
3972         (tui_free_window): Use delete.
3973
3974 2019-06-22  Tom Tromey  <tom@tromey.com>
3975
3976         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
3977         declare.
3978         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
3979
3980 2019-06-22  Tom Tromey  <tom@tromey.com>
3981
3982         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
3983         declare.
3984         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
3985
3986 2019-06-22  Tom de Vries  <tdevries@suse.de>
3987
3988         * dwarf2read.c (create_addrmap_from_aranges)
3989         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
3990         instead of '%zu'.
3991
3992 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
3993
3994         * dwarf2read.h (dwarf2_section_info_def): Remove.
3995         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
3996         * dwarf2read.c (struct dwo_sections) <types>: Change type to
3997         std::vector<dwarf2_section_info>.
3998         (struct dwo_file) <~dwo_file>: Remove.
3999         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
4000         types field.
4001         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
4002         (dwarf2_read_debug_names): Likewise.
4003         (create_debug_types_hash_table): Change parameter type to
4004         array_view, adjust code accordingly.
4005         (dwarf2_locate_dwo_sections): Adjust to std::vector.
4006         (partial_die_info::fixup): Likewise.
4007         (determine_prefix): Likewise.
4008         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
4009
4010 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
4011
4012         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
4013         gdb_bfd_ref_ptr.
4014         <~dwo_file>: Remove call to gdb_bfd_unref.
4015         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
4016         gdb_bfd_ref_ptr::get.
4017
4018 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
4019
4020         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
4021         type to htab_up.
4022         * dwarf2read.c (struct dwo_file): Initialize fields.
4023         <~dwo_file>: New.
4024         (free_dwo_file): Remove, move content to ~dwo_file.
4025         (struct dwo_file_deleter): Remove.
4026         (dwo_file_up>: Remove custom deleter.
4027         (free_dwo_files): Remove.
4028         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
4029         dwo_files.
4030         (process_skeletonless_type_units): Call unique_ptr::get.
4031         (allocate_dwo_file_hash_table): Add deleter to created hash
4032         table.  Change return type to htab_up.
4033         (lookup_dwo_file_slot): Don't memset dwo_file, call
4034         unique_ptr::get.
4035         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
4036         (create_dwo_unit_in_dwp_v2): Likewise.
4037         (open_and_init_dwo_file): Likewise.
4038         (free_dwo_file_from_slot): Remove.
4039
4040 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
4041
4042         * dwarf2read.h (struct dwarf2_section_info) <readin,
4043         is_virtual>: Change type to bool.
4044         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
4045         true instead of 1.
4046
4047 2019-06-19  Tom Tromey  <tom@tromey.com>
4048
4049         * tui/tui-data.h (tui_init_content_element): Don't declare.
4050
4051 2019-06-19  Tom Tromey  <tom@tromey.com>
4052
4053         * tui/tui-data.h (tui_init_win_info): Don't declare.
4054
4055 2019-06-19  Tom de Vries  <tdevries@suse.de>
4056
4057         * dwarf2read.h (abstract_to_concrete): Change type to
4058         std::unordered_map<sect_offset, std::vector<sect_offset>,
4059         gdb::hash_enum<sect_offset>>.
4060
4061 2019-06-19  Tom Tromey  <tromey@adacore.com>
4062
4063         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
4064         EVAL_AVOID_SIDE_EFFECTS specially.
4065
4066 2019-06-19  Tom Tromey  <tromey@adacore.com>
4067
4068         * source-cache.c (highlighter): New global.
4069         (source_cache::get_source_lines): Create a highlighter on demand.
4070
4071 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
4072
4073         * defs.h (deprecated_interactive_hook): Delete declaration.
4074         * interps.c (clear_interpreter_hooks): Remove use of
4075         deprecated_interactive_hook.
4076         * top.c (deprecated_interactive_hook): Delete definition.
4077         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
4078
4079 2019-06-18  Tom de Vries  <tdevries@suse.de>
4080
4081         PR gdb/24515
4082         * dwarf2read.h (abstract_to_concrete): Change type from
4083         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
4084         std::unordered_map<sect_offset, std::vector<sect_offset>>.
4085         * dwarf2read.c (read_variable): Update.
4086         (dwarf2_fetch_die_loc_sect_off): Update.
4087
4088 2019-06-17  Tom de Vries  <tdevries@suse.de>
4089
4090         PR gdb/24617
4091         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
4092         accessing parent[parent_len - 1].
4093
4094 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
4095
4096         PR gdb/24364
4097         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
4098         call dtrace_process_dof with NULL dof.
4099
4100 2019-06-16  Tom de Vries  <tdevries@suse.de>
4101
4102         PR gdb/24445
4103         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
4104
4105 2019-06-16  Tom Tromey  <tom@tromey.com>
4106
4107         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
4108         (make_all_visible): Use address of member.
4109
4110 2019-06-16  Tom Tromey  <tom@tromey.com>
4111
4112         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
4113         (tui_free_window, free_content, free_content_elements): Remove
4114         unnecessary cast.
4115         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
4116         cast.
4117         * tui/tui-regs.c (tui_show_register_group)
4118         (tui_display_registers_from, tui_display_reg_element_at_line):
4119         Remove unnecessary cast.
4120
4121 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
4122
4123         * linux-nat.c (normal_mask): Delete.
4124         (_initialize_linux_nat): Don't initialise normal_mask.
4125
4126 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
4127
4128         PR gdb/24445
4129         * dwarf-index-write.h (write_psymtabs_to_index): Add
4130         dwz_basename parameter.
4131         * dwarf-index-write.c (write_gdbindex): Move file writing to
4132         write_gdbindex_1.  Change return type void.
4133         (assert_file_size): Move up, remove filename parameter.
4134         (write_gdbindex_1): New function.
4135         (write_debug_names): Change return type to void, call
4136         assert_file_size.
4137         (struct index_wip_file): New struct.
4138         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
4139         file logic to index_wip_file.  Write index for dwz file if
4140         needed.
4141         (save_gdb_index_command): Pass basename of dwz file, if present.
4142         * dwarf-index-cache.c (index_cache::store): Obtain and pass
4143         build-id of dwz file, if present.
4144         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
4145         (dwarf2_get_dwz_file): Likewise.
4146         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
4147         (dwarf2_get_dwz_file): Likewise.
4148
4149 2019-06-16  Tom Tromey  <tom@tromey.com>
4150
4151         * coffread.c (process_coff_symbol): Use xstrdup.
4152         * value.c (create_internalvar): Use xstrdup.
4153
4154 2019-06-16  Tom Tromey  <tom@tromey.com>
4155
4156         * valops.c (value_cast, value_slice): Remove unnecessary cast.
4157         * breakpoint.c (stopin_command, stopat_command)
4158         (until_break_command, decode_location_default): Remove unnecessary
4159         cast.
4160         * utils.c (subset_compare): Remove unnecessary cast.
4161         * ada-lang.c (ada_update_initial_language): Remove unnecessary
4162         cast.
4163         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
4164         cast.
4165         * infcmd.c (path_command): Remove unnecessary cast.
4166         * coffread.c (decode_type): Remove unnecessary cast.
4167         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
4168         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
4169         * tui/tui-stack.c (tui_show_locator_content)
4170         (tui_show_frame_info): Remove unnecessary cast.
4171         * tui/tui-win.c (tui_scroll_forward_command)
4172         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
4173         (parse_scrolling_args): Remove unnecessary cast.
4174         * tui/tui-data.c (init_win_info, tui_del_window)
4175         (tui_free_window, tui_del_data_windows, tui_free_data_content)
4176         (free_content_elements): Remove unnecessary cast.
4177         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
4178         unnecessary cast.
4179         * tui/tui-source.c (tui_set_source_content)
4180         (tui_vertical_source_scroll): Remove unnecessary cast.
4181         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
4182         cast.
4183         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
4184         * tui/tui-regs.c (tui_display_registers_from)
4185         (tui_display_register): Remove unnecessary cast.
4186         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
4187         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
4188         (make_visible): Remove unnecessary cast.
4189         * tui/tui-winsource.c (tui_erase_source_content)
4190         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
4191         unnecessary cast.
4192         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
4193         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
4194         * stabsread.c (read_type, read_array_type, read_range_type):
4195         Remove unnecessary cast.
4196         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
4197         (parse_symbol, parse_type, upgrade_type, parse_external)
4198         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
4199         unnecessary cast.
4200         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
4201
4202 2019-06-16  Tom Tromey  <tom@tromey.com>
4203
4204         * tui/tui-data.c (tui_alloc_generic_win_info)
4205         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
4206         checks.
4207
4208 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
4209             Andrew Burgess  <andrew.burgess@embecosm.com>
4210
4211         * f-typeprint.c (f_print_type): Don't return early for not
4212         associated or not allocated types.
4213         (f_type_print_varspec_suffix): Add print_rank parameter and print
4214         ranks of array types in case they dangling.
4215         (f_type_print_base): Add print_rank parameter.
4216
4217 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4218
4219         * NEWS: Mention new MI commands.
4220         * break-catch-throw.c (enum exception_event_kind): Move to
4221         breakpoint.h.
4222         (print_mention_exception_catchpoint): Output text as a single
4223         message.
4224         (catch_exception_command_1): Rename to...
4225         (catch_exception_event): ...this, make non-static, update header
4226         command, and change some parameter types.
4227         (catch_catch_command): Update for changes to
4228         catch_exception_command_1.
4229         (catch_throw_command): Likewise.
4230         (catch_rethrow_command): Likewise.
4231         * breakpoint.c (enum exception_event_kind): Delete.
4232         * breakpoint.h (enum exception_event_kind): Moved here from
4233         break-catch-throw.c.
4234         (catch_exception_event): Declare.
4235         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
4236         (mi_cmd_catch_throw): New function.
4237         (mi_cmd_catch_rethrow): New function.
4238         (mi_cmd_catch_catch): New function.
4239         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
4240         'catch-catch' entries.
4241         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
4242         (mi_cmd_catch_rethrow): Declare.
4243         (mi_cmd_catch_catch): Declare.
4244
4245 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4246
4247         * annotate.c (annotate_source_line): Change return type to void,
4248         update implementation to match.
4249         * annotate.h (annotate_source_line): Change return type to void,
4250         update header comment.
4251         * stack.c (print_frame_info): Don't change what frame information
4252         is printed based on whether annotations are on or not.
4253
4254 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4255
4256         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
4257         (annotate_source): Make static.
4258         (annotate_source_line): Moved from source.c and renamed from
4259         identify_source_line.  Update the return type.
4260         * annotate.h (annotate_source): Delete declaration.
4261         (annotate_source_line): Declaration moved from source.h, and
4262         renamed from identify_source_line.  Return type updated.
4263         * source.c (identify_source_line): Moved to annotate.c and renamed
4264         to annotate_source_line.
4265         (info_line_command): Remove check of annotation_level.
4266         * source.h (identify_source_line): Move declaration to annotate.h
4267         and rename to annotate_source_line.
4268         * stack.c: Add 'annotate.h' include.
4269         (print_frame_info): Remove check of annotation_level before
4270         calling annotate_source_line.
4271
4272 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4273
4274         * source-cache.c (source_cache::get_plain_source_lines): Use
4275         open_source_file_with_line_charpos instead of just
4276         open_source_file, remove call to find_source_lines.
4277         (source_cache::get_source_lines): Likewise.
4278         * source.c (find_source_lines): Make static.
4279         (get_filename_and_charpos): Renamed into...
4280         (open_source_file_with_line_charpos): ..this along with changes to
4281         return a scoped_fd, and some other minor clean ups.
4282         (identify_source_line): Use open_source_file_with_line_charpos.
4283         (search_command_helper): Use open_source_file_with_line_charpos
4284         instead of just open_source_file, remove call to
4285         find_source_lines.
4286         * source.h (open_source_file_with_line_charpos): Declare new
4287         function.
4288         (find_source_lines): Delete declaration.
4289
4290 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4291
4292         * source.c (get_filename_and_charpos): Remove fullname
4293         parameter.
4294         (identify_source_line): Update call to get_filename_and_charpos.
4295
4296 2019-06-14  Tom Tromey  <tromey@adacore.com>
4297
4298         PR gdb/24502:
4299         * ui-style.h (skip_ansi_escape): Update comment.
4300         * ui-file.h (class no_terminal_escape_file): New class.
4301         * ui-file.c (no_terminal_escape_file::write)
4302         (no_terminal_escape_file::puts): New methods.
4303         * cli/cli-logging.c (handle_redirections): Use
4304         no_terminal_escape_file.
4305
4306 2019-06-14  Tom Tromey  <tromey@adacore.com>
4307
4308         * NEWS: Move convenience variable news above Python news.
4309
4310 2019-06-14  Tom Tromey  <tom@tromey.com>
4311
4312         * gnulib: Move directory to top-level.
4313         * configure.ac: Don't configure gnulib.
4314         * configure: Rebuild.
4315         * common/common-defs.h: Use new path to gnulib.
4316         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
4317         (GNULIB_H): Remove.
4318         (INCGNU): Look in new gnulib location.
4319         (HFILES_NO_SRCDIR): Remove gnulib files.
4320         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
4321         (generated_files): Remove GNULIB_H.
4322         ($(LIBGNU), all-lib): Remove targets.
4323         (distclean): Don't mention GNULIB_BUILDDIR.
4324         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
4325
4326 2019-06-14  Tom Tromey  <tromey@adacore.com>
4327
4328         * symfile.c (add_symbol_file_command): Remove obsolete comment.
4329         Warn if symbol file does not provide any symbols.
4330
4331 2019-06-14  Tom Tromey  <tromey@adacore.com>
4332
4333         * source.c (find_and_open_source): Respect basenames_may_differ.
4334
4335 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
4336
4337         * annotate.c (annotate_breakpoints_invalid): Make use of
4338         scoped_restore_terminal_state.
4339         (annotate_frames_invalid): Likewise.
4340
4341 2019-06-14  Tom Tromey  <tromey@adacore.com>
4342
4343         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
4344         allow assignment to an internalvar.
4345
4346 2019-06-14  Tom Tromey  <tromey@adacore.com>
4347
4348         * ada-lex.l: Allow "_" in attribute names.
4349
4350 2019-06-14  Tom Tromey  <tromey@adacore.com>
4351
4352         PR gdb/24653:
4353         * regcache.c (registers_changed): Don't call alloca.
4354         * top.c (execute_command): Don't call alloca.
4355
4356 2019-06-13  Pedro Alves  <palves@redhat.com>
4357
4358         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
4359         'expression'.  When parsing an expression, error out if there's
4360         junk after "unlimited".
4361         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
4362         (do_set_command): Adjust calls to is_unlimited_literal.
4363
4364 2019-06-13  Pedro Alves  <palves@redhat.com>
4365
4366         * compile/compile.c (make_compile_options_def_group): Add braces
4367         around array_view initializer.
4368         * thread.c (make_thread_apply_all_options_def_group)
4369         (make_thread_apply_all_options_def_group): Likewise.
4370
4371 2019-06-13  Pedro Alves  <palves@redhat.com>
4372
4373         * NEWS (New commands): Mention "maint test-options
4374         require-delimiter", "maint test-options unknown-is-error", "maint
4375         test-options unknown-is-operand" and "maint show
4376         test-options-completion-result".
4377         (New command options, command completion): New section.
4378         (Completion improvements): New section.
4379         Mention that you can abbreviate "unlimited".
4380
4381 2019-06-13  Pedro Alves  <palves@redhat.com>
4382
4383         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
4384         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
4385         * unittests/cli-utils-selftests.c (test_parse_flags)
4386         (test_parse_flags_qcs): Delete.
4387         (test_cli_utils): Don't call deleted functions.
4388
4389 2019-06-13  Pedro Alves  <palves@redhat.com>
4390
4391         * thread.c: Include "cli/cli-option.h".
4392         (tp_array_compar_ascending): Global.
4393         (tp_array_compar): Delete function.
4394         (tp_array_compar_ascending, tp_array_compar_descending): New
4395         functions.
4396         (ascending_option_def, qcs_flag_option_def)
4397         (thr_qcs_flags_option_defs)
4398         (make_thread_apply_all_options_def_group)
4399         (make_thread_apply_options_def_group): New.
4400         (thread_apply_all_command): Use gdb::option::process_options.
4401         (thread_apply_command_completer)
4402         (thread_apply_all_command_completer): New.
4403         (thread_apply_command): Use gdb::option::process_options.
4404         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
4405         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
4406         to generate help text of "thread apply".  Adjust "taas"'s help.
4407         * tid-parse.c (tid_range_parser::in_thread_range): New method.
4408         * tid-parse.h (tid_range_parser::in_thread_range): New method.
4409
4410 2019-06-13  Pedro Alves  <palves@redhat.com>
4411
4412         * thread.c (thread_apply_command): Check for invalid TID with
4413         isdigit instead of !isalpha.
4414
4415 2019-06-13  Pedro Alves  <palves@redhat.com>
4416
4417         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
4418         (validate_flags_qcs): New.
4419         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
4420         (validate_flags_qcs): Declare.
4421         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
4422         (make_frame_apply_options_def_group): New.
4423         (frame_apply_command_count): Process options with
4424         gdb::option::process_options.
4425         (frame_apply_completer): New.
4426         (frame_apply_level_completer, frame_apply_all_completer)
4427         (frame_apply_completer): New.
4428         (_initialize_stack): Update help of "frame apply", "frame apply
4429         level", "frame apply all" and "faas" to mention supported options
4430         and install command completers.
4431         * stack.h (frame_apply_all_completer): Declare.
4432         * thread.c: Include "stack.h".
4433         (tfaas_command): Add "--".
4434         (_initialize_thread): Update help "tfaas" to mention supported
4435         options and install command completer.
4436
4437 2019-06-13  Pedro Alves  <palves@redhat.com>
4438
4439         * completer.c (complete_nested_command_line): New.
4440         (gdb_completion_word_break_characters_throw): Add assertion.
4441         * completer.h (complete_nested_command_line): Declare.
4442
4443 2019-06-13  Pedro Alves  <palves@redhat.com>
4444
4445         * stack.c (parse_backtrace_qualifiers): New.
4446         (backtrace_command): Use it.
4447         (backtrace_command_completer): Complete on qualifiers.
4448
4449 2019-06-13  Pedro Alves  <palves@redhat.com>
4450
4451         * frame.c: Include "cli/cli-option.h.
4452         (user_set_backtrace_options): New.
4453         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
4454         Delete.
4455         (get_prev_frame): Adjust.
4456         (boolean_option_def, uinteger_option_def)
4457         (set_backtrace_option_defs): New.
4458         (_initialize_frame): Adjust and use
4459         gdb::option::add_setshow_cmds_for_options to install "set
4460         backtrace past-main" and "set backtrace past-entry".
4461         * frame.h: Include "cli/cli-option.h".
4462         (struct frame_print_options): Forward declare.
4463         (print_frame_arguments_all, print_frame_arguments_scalars)
4464         (print_frame_arguments_none): Declare.
4465         (print_entry_values): Delete declaration.
4466         (struct frame_print_options, user_frame_print_options): New.
4467         (struct set_backtrace_options): New.
4468         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
4469         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
4470         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
4471         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
4472         (list_args_or_locals): Add frame_print_options parameter.
4473         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
4474         * python/py-framefilter.c (enumerate_args): Pass down
4475         USER_FRAME_PRINT_OPTIONS.
4476         * stack.c: Include "cli/cli-option.h".
4477         (print_frame_arguments_all, print_frame_arguments_scalars)
4478         (print_frame_arguments_none): Declare.
4479         (print_raw_frame_arguments, print_entry_values): Delete.
4480         (user_frame_print_options): New.
4481         (boolean_option_def, enum_option_def, frame_print_option_defs):
4482         New.
4483         (struct backtrace_cmd_options): New.
4484         (bt_flag_option_def): New.
4485         (backtrace_command_option_defs): New.
4486         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
4487         (print_frame_arg, read_frame_arg, print_frame_args)
4488         (print_frame_info, print_frame): Add frame_print_options parameter
4489         and use it.
4490         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
4491         (backtrace_command_1): Add frame_print_options and
4492         backtrace_cmd_options parameters and use them.
4493         (make_backtrace_options_def_group): New.
4494         (backtrace_command): Process command options with
4495         gdb::option::process_options.
4496         (backtrace_command_completer): New.
4497         (_initialize_stack): Extend "backtrace"'s help to mention
4498         supported options.  Install completer for "backtrace".
4499         Install some settings commands with add_setshow_cmds_for_options.
4500
4501 2019-06-13  Pedro Alves  <palves@redhat.com>
4502
4503         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
4504         and that "set/show print raw frame-arguments" are now deprecated.
4505
4506         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
4507         command.
4508         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
4509         * stack.c (_initialize_stack): Install "set/show print
4510         raw-frame-arguments", and deprecate "set/show print raw
4511         frame-arguments".
4512         * valprint.c (_initialize_valprint): Deprecate "set/show print
4513         raw".
4514
4515 2019-06-13  Pedro Alves  <palves@redhat.com>
4516
4517         * compile/compile.c (struct compile_options): New.
4518         (compile_flag_option_def, compile_command_option_defs)
4519         (make_compile_options_def_group): New.
4520         (compile_file_command): Handle options with
4521         gdb::option::process_options.
4522         (compile_file_command_completer): New function.
4523         (compile_code_command): Handle options with
4524         gdb::option::process_options.
4525         (compile_code_command_completer): New function.
4526         (_initialize_compiler): Install completers for "compile code" and
4527         "compile file".  Mention available options in "compile code" and
4528         "compile code"'s help.
4529         * completer.c (advance_to_completion_word): New, factored out from
4530         ...
4531         (advance_to_expression_complete_word_point): ... this.
4532         (advance_to_filename_complete_word_point): New.
4533         * completer.h (advance_to_filename_complete_word_point): New
4534         declaration.
4535
4536 2019-06-13  Pedro Alves  <palves@redhat.com>
4537
4538         * compile/compile.c: Include "cli/cli-option.h".
4539         (compile_print_value): Scope data pointer is now a
4540         value_print_options pointer; adjust.
4541         (compile_print_command): Process options.  Scope data pointer is
4542         now a value_print_options pointer; adjust.
4543         (_initialize_compile): Update "compile print"'s help to include
4544         supported options.  Install a completer for "compile print".
4545         * cp-valprint.c (show_vtblprint, show_objectprint)
4546         (show_static_field_print): Delete.
4547         (_initialize_cp_valprint): Don't install "set print
4548         static-members", "set print vtbl", "set print object" here.
4549         * printcmd.c: Include "cli/cli-option.h" and
4550         "common/gdb_optional.h".
4551         (print_command_parse_format): Rework to fill in a
4552         value_print_options instead of a format_data.
4553         (print_value): Change parameter type from format_data pointer to
4554         value_print_options reference.  Adjust.
4555         (print_command_1): Process options.  Adjust to pass down a
4556         value_print_options.
4557         (print_command_completer): New.
4558         (_initialize_printcmd): Install print_command_completer as
4559         handle_brkchars completer for the "print" command.  Update
4560         "print"'s help to include supported options.
4561         * valprint.c: Include "cli/cli-option.h".
4562         (show_vtblprint, show_objectprint, show_static_field_print): Moved
4563         here from cp-valprint.c.
4564         (boolean_option_def, uinteger_option_def)
4565         (value_print_option_defs, make_value_print_options_def_group):
4566         New.  Use gdb::option::add_setshow_cmds_for_options to install
4567         "set print elements", "set print null-stop", "set print repeats",
4568         "set print pretty", "set print union", "set print array", "set
4569         print address", "set print symbol", "set print array-indexes".
4570         * valprint.h: Include <string> and "cli/cli-option.h".
4571         (make_value_print_options_def_group): Declare.
4572         (print_value): Change parameter type from format_data pointer to
4573         value_print_options reference.
4574         (print_command_completer): Declare.
4575
4576 2019-06-13  Pedro Alves  <palves@redhat.com>
4577
4578         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
4579         (COMMON_SFILES): Add maint-test-settings.c.
4580         * cli/cli-decode.c (boolean_enums): New global, factored out from
4581         ...
4582         (add_setshow_boolean_cmd): ... here.
4583         * cli/cli-decode.h (boolean_enums): Declare.
4584         * cli/cli-option.c: New file.
4585         * cli/cli-option.h: New file.
4586         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
4587         factored out from ...
4588         (parse_cli_boolean_value(const char *)): ... this.
4589         (is_unlimited_literal): Change parameter type to pointer to
4590         pointer.  Adjust and advance ARG pointer.
4591         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
4592         (parse_cli_var_enum): New, factored out from ...
4593         (do_set_command): ... this.  Adjust.
4594         * cli/cli-setshow.h (parse_cli_boolean_value)
4595         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
4596         (parse_cli_var_enum): Declare.
4597         * cli/cli-utils.c: Include "cli/cli-option.h".
4598         (get_ulongest): New.
4599         * cli/cli-utils.h (get_ulongest): Declare.
4600         (check_for_argument): New overloads.
4601         * maint-test-options.c: New file.
4602
4603 2019-06-13  Pedro Alves  <palves@redhat.com>
4604
4605         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
4606         parse a range if "-" is at the end of the string.
4607
4608 2019-06-13  Pedro Alves  <palves@redhat.com>
4609
4610         * cli/cli-setshow.c (parse_auto_binary_operation)
4611         (parse_cli_boolean_value): Don't allow "o".
4612
4613 2019-06-13  Pedro Alves  <palves@redhat.com>
4614
4615         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
4616         * NEWS: Mention maint test-settings KIND.
4617         * maint-test-settings.c: New file.
4618
4619 2019-06-13  Pedro Alves  <palves@redhat.com>
4620
4621         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
4622         completer.
4623         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
4624         "set" completers.
4625
4626 2019-06-13  Pedro Alves  <palves@redhat.com>
4627
4628         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
4629         after item.
4630
4631 2019-06-13  Pedro Alves  <palves@redhat.com>
4632
4633         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
4634
4635 2019-06-13  Pedro Alves <palves@redhat.com>
4636
4637         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
4638         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
4639         call.
4640         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
4641         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
4642         calls.
4643         (check_for_argument): Skip spaces after argument.
4644
4645 2019-06-13  Pedro Alves  <palves@redhat.com>
4646
4647         * thread.c (thread_apply_command): Adjust TID parsing.
4648         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
4649         detected before end of string.
4650         (tid_is_in_list): Error out if LIST is invalid.
4651
4652 2019-06-13  Pedro Alves  <palves@redhat.com>
4653
4654         * completer.c (complete_line_internal_1): Rewind completion word
4655         point.
4656         (completion_tracker::advance_custom_word_point_by): Change
4657         parameter type to int.
4658         * completer.h (completion_tracker::advance_custom_word_point_by):
4659         Likewise.
4660
4661 2019-06-13  Pedro Alves  <palves@redhat.com>
4662
4663         * completer.c (advance_to_completion_word): Handle delimiters.
4664
4665 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
4666
4667         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
4668
4669 2019-06-11  Tom Tromey  <tom@tromey.com>
4670
4671         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
4672         (xmalloc_failed): Move to alloc.c.
4673         * alloc.c: New file.
4674         * Makefile.in (COMMON_SFILES): Add alloc.c.
4675
4676 2019-06-11  Tom Tromey  <tom@tromey.com>
4677
4678         * nat/linux-waitpid.c: Don't include server.h.
4679         (linux_debug): Remove.
4680         (my_waitpid): Update.
4681
4682 2019-06-11  Tom Tromey  <tromey@adacore.com>
4683
4684         * infcall.c (_initialize_infcall): Remove trailing newline from
4685         help.
4686         * user-regs.c (_initialize_user_regs): Remove trailing newline
4687         from help.
4688         * typeprint.c (_initialize_typeprint): Remove trailing newline
4689         from help.
4690         * reverse.c (_initialize_reverse): Remove trailing newlines from
4691         help.
4692         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
4693         from help.
4694         * language.c (add_set_language_command): Remove trailing newline
4695         from help.
4696         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
4697         help.
4698         * disasm.c (_initialize_disasm): Remove trailing newline from
4699         help.
4700         * top.c (init_main): Remove trailing newline from help.
4701         * interps.c (_initialize_interpreter): Remove trailing newline
4702         from help.
4703         * btrace.c (_initialize_btrace): Remove trailing newlines from
4704         help.
4705         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
4706         from help.
4707         * python/python.c (_initialize_python): Remove trailing newline
4708         from help.
4709         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
4710         help.
4711         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
4712         from help.  Reformat some text.
4713         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
4714         from help.
4715         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
4716         newline from help.
4717
4718 2019-06-11  Tom Tromey  <tromey@adacore.com>
4719
4720         * darwin-nat.c (darwin_decode_exception_message)
4721         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
4722
4723 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
4724
4725         * valops.c (value_slice): Check for not allocated or not
4726         associated values.
4727
4728 2019-06-10  Tom de Vries  <tdevries@suse.de>
4729
4730         PR gdb/24618
4731         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
4732         sure an empty slot (defined by a 32-bit zero pair) is recognized as
4733         invalid.
4734
4735 2019-06-10  Tom de Vries  <tdevries@suse.de>
4736
4737         PR gdb/24611
4738         * linespec.c (linespec_lexer_lex_string): Remove incorrect
4739         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
4740
4741 2019-06-10  Tom de Vries  <tdevries@suse.de>
4742
4743         PR symtab/24545
4744         * symtab.c (struct demangled_name_entry): Add language field.
4745         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
4746         static minimal symbol".  Set and use language field.
4747
4748 2019-06-10  Tom Tromey  <tromey@adacore.com>
4749
4750         * ada-lang.c (_initialize_ada_language): Update help text.
4751
4752 2019-06-10  Tom Tromey  <tromey@adacore.com>
4753
4754         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
4755         with a newline.
4756         * guile/guile.c (handle_boot_error): Don't end warning with a
4757         newline.
4758         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
4759         warning with a newline.
4760         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
4761         newline.
4762         (s12z_frame_cache): Likewise.
4763         * dwarf-index-cache.c (index_cache::store): Don't end warning with
4764         a newline.
4765         * solib-svr4.c (disable_probes_interface): Don't end warning with
4766         a newline.
4767         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
4768         newline.
4769         * python/python.c (do_finish_initialization): Don't end warning
4770         with a newline.
4771
4772 2019-06-10  Tom Tromey  <tom@tromey.com>
4773
4774         * python/py-breakpoint.c (gdbpy_breakpoint_created)
4775         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
4776         gdbpy_enter.
4777
4778 2019-06-10  Tom Tromey  <tromey@adacore.com>
4779
4780         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
4781         data.
4782         (elf_new_init): Don't call stabsread_new_init.
4783         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
4784         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
4785         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
4786
4787 2019-06-10  Tom de Vries  <tdevries@suse.de>
4788
4789         PR symtab/16264
4790         PR symtab/24517
4791         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
4792
4793 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
4794
4795         * source.c (find_and_open_source): Also rewrite relative file
4796         names.
4797
4798 2019-04-26  Amos Bird  <amosbird@gmail.com>
4799
4800         * annotate.c (annotate_thread_exited): Add "thread-exited"
4801         annotation.
4802
4803 2019-06-06  Tom Tromey  <tromey@adacore.com>
4804
4805         * maint.h (class scoped_command_stats): Use
4806         DISABLE_COPY_AND_ASSIGN.
4807         <print_time>: New method.
4808         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
4809         print_time.
4810         (scoped_command_stats::print_time): New method.
4811
4812 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
4813
4814         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
4815         instructions of lengths 6 or 8 bytes.
4816
4817 2019-06-04  Pedro Alves  <palves@redhat.com>
4818
4819         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
4820
4821         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
4822         * breakpoint.c (condition_completer): Likewise.
4823         * cli/cli-dump.c (scan_expression): Likewise.
4824         * common/filestuff.c (mkdir_recursive): Likewise.
4825         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
4826         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
4827         (gdb_abspath): Likewise.
4828         * compile/compile-cplus-types.c
4829         (compile_cplus_instance::decl_name): Likewise.
4830         * completer.c (complete_explicit_location):
4831         (signal_completer, reg_or_group_completer_1): Likewise.
4832         * cp-support.c (cp_remove_params_if_any): Likewise.
4833         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
4834         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
4835         * infcmd.c (strip_bg_char): Likewise.
4836         * linespec.c (copy_token_string): Likewise.
4837         * mi/mi-main.c (output_cores): Likewise.
4838         * psymtab.c (psymtab_search_name):
4839         * symfile.c (test_set_ext_lang_command): Likewise.
4840         * target.c (target_fileio_read_stralloc): Likewise.
4841         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
4842         * value.c (complete_internalvar): Likewise.
4843
4844 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
4845
4846         Add objfile property to gdb.Type.
4847         * NEWS: Mention Python API addition.
4848         * python/py-type.c (typy_get_objfile): New method.
4849
4850 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4851
4852         * NEWS: Mention the new set|show style [title|highlight].
4853         Mention changes to "show style", "help" and "apropos".
4854
4855 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4856
4857         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
4858         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
4859         instead of print_help_for_command.
4860         (print_doc_of_command): New function.
4861         (help_list): Add 'apropos -v word' suggestion.
4862         (print_help_for_command): Style the command name using title style.
4863         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
4864         (_initialize_cli_cmds): Describe -v in apropos_command help.
4865
4866 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4867
4868         * cli/cli-style.h (cli_style_option): Add name in constructor,
4869         add m_name class member, add constructor with intensity,
4870         add name class function.
4871         (cli_style_option::add_setshow_commands): Remove name argument.
4872         (highlight_style, title_style): New styles.
4873         * cli/cli-style.c (do_show): New function that shows a style
4874         characteristic styling the style name with itself.
4875         (set_style_name): New function.
4876         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
4877         Update all callers according to the changes in cli/cli-style.h.
4878         * utils.h (fputs_highlighted): New function.
4879         * utils.c (fputs_highlighted): Likewise.
4880
4881 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4882
4883         * NEWS: Mention new pipe command and new convenience variables.
4884
4885 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4886
4887         * cli/cli-cmds.c (pipe_command): New function.
4888         (_initialize_cli_cmds): Call add_com for pipe_command.
4889         Define | as an alias for pipe.
4890         (exit_status_set_internal_vars): New function.
4891         (shell_escape): Call exit_status_set_internal_vars.
4892         cli/cli-decode.c (find_command_name_length): Recognize | as
4893         a single character command.
4894
4895 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4896
4897         * gdbcmd.h (execute_command_to_ui_file): New declaration.
4898         top.c (execute_command_to_ui_file): New function, mostly a copy
4899         of execute_command_to_string.
4900         (execute_command_to_string): Implement by calling
4901         execute_command_to_ui_file.
4902
4903 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4904
4905         * top.h (saved_command_line): Remove declaration.
4906         * top.c (previous_saved_command_line, previous_repeat_arguments):
4907         New variables.
4908         (saved_command_line): Make static, define together with other
4909         'repeat variables'.
4910         (dont_repeat): Clear repeat_arguments.
4911         (repeat_previous, get_saved_command_line, save_command_line):
4912         New functions.
4913         (gdb_init): Initialize saved_command_line
4914         and previous_saved_command_line.
4915         * main.c (captured_main_1): Remove saved_command_line initialization.
4916         * event-top.c (handle_line_of_input): Update to use
4917         the new 'repeat' related functions instead of direct access to
4918         saved_command_line.
4919         * command.h (repeat_previous, get_saved_command_line,
4920         save_command_line): New declarations.
4921         (dont_repeat): Add comment.
4922
4923 2019-05-30  Tom Tromey  <tromey@adacore.com>
4924
4925         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
4926         Fix comment.
4927         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
4928
4929 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
4930
4931         PR cli/24587
4932         * completer.c (complete): Initialize variable word.
4933
4934 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
4935
4936         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
4937         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
4938         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
4939         'body' is NULL to the outter 'if', protecting the '!is_define'
4940         situation as well.
4941
4942 2019-05-29  Tom Tromey  <tromey@adacore.com>
4943
4944         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
4945         (dwarf_unknown): New function.
4946         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
4947         (dwarf_type_encoding_name): Use dwarf_unknown.
4948
4949 2019-05-29  Tom Tromey  <tromey@adacore.com>
4950
4951         PR c++/20020:
4952         * cp-valprint.c (cp_print_value_fields): Call
4953         cp_print_static_field inside "try".
4954
4955 2019-05-29  Tom Tromey  <tromey@adacore.com>
4956
4957         * inflow.c (struct terminal_info): Add default operator=.
4958         * configure: Rebuild.
4959         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
4960         -Wdeprecated-copy-dtor, -Wredundant-move.
4961
4962 2019-05-29  Tom Tromey  <tromey@adacore.com>
4963
4964         * NEWS: Add entry.
4965         * infcmd.c (print_return_value_1): Handle finish_print
4966         option.
4967         (show_print_finish): New function.
4968         (_initialize_infcmd): Add "set/show print finish" commands.
4969         * valprint.c (user_print_options): Initialize new member.
4970         * valprint.h (struct value_print_options) <finish_print>: New
4971         member.
4972
4973 2019-05-28  Tom Tromey  <tromey@adacore.com>
4974
4975         * ada-lang.c (ada_remove_Xbn_suffix)
4976         (find_old_style_renaming_symbol)
4977         (parse_old_style_renaming): Remove.
4978         (ada_find_renaming_symbol): Don't call
4979         find_old_style_renaming_symbol.
4980         (ada_is_renaming_symbol): Rename from
4981         ada_find_renaming_symbol.  Remove "block" parameter.  Return
4982         bool.  Now static.
4983         (ada_read_var_value): Update and simplify.
4984         * ada-exp.y (write_var_or_type): Remove old code.
4985
4986 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
4987
4988         * event-top.c: Remove include comment.
4989         * inflow.c (class scoped_ignore_sigttou): Move from here...
4990         * inflow.h (class scoped_ignore_sigttou): ...to here.
4991         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
4992         * top.c:  Remove include comment.
4993
4994 2019-05-27  Tom Tromey  <tom@tromey.com>
4995
4996         * NEWS: Fix typo.
4997
4998 2019-05-22  Tom Tromey  <tromey@adacore.com>
4999
5000         * target.c (target_follow_exec): Constify parameter.
5001         * target-delegates.c: Rebuild.
5002         * remote.c (remote_target::follow_exec): Constify parameter.
5003         * infrun.c (follow_exec): Constify parameter.
5004         * target.h (struct target_ops) <follow_exec>: Constify parameter.
5005         (target_follow_exec): Likewise.
5006
5007 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
5008
5009         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
5010         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
5011
5012 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
5013
5014         * NEWS: Add debugredirect and testsuite sections.
5015
5016 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
5017
5018         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
5019         target descriptions using exclusively floating point register name
5020         aliases.
5021
5022 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
5023
5024         PR gdb/18644:
5025         * f-lang.c (build_fortran_types): Handle the case where
5026         gdbarch_floatformat_for_type returns a nullptr.
5027
5028 2019-05-21  Tom de Vries  <tdevries@suse.de>
5029
5030         PR cli/24587
5031         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
5032
5033 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
5034
5035         PR gdb/18644:
5036         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
5037         16-byte floats.
5038         * i386-tdep.c (i386_floatformat_for_type): Use
5039         floatformats_ia64_quad for the 16-byte floating point component
5040         within a fortran 32-byte complex number.
5041
5042 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
5043
5044         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
5045         delete default constructor.
5046         (find_partial_die): Update to return const struct.
5047         (partial_die_parent_scope): Move variable declaration into scope
5048         of its use and change its type to auto.
5049         (guess_partial_die_structure_name): Likewise.
5050         (partial_die_info::fixup): Likewise.
5051
5052 2019-05-17  Tom Tromey  <tromey@adacore.com>
5053
5054         * source.c (find_and_open_source): Remove cast.
5055
5056 2019-05-17  Tom Tromey  <tromey@adacore.com>
5057
5058         * annotate.c (annotate_source): Make "filename" const.
5059         * annotate.h (annotate_source): Use const.
5060
5061 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
5062
5063         * disasm.c (set_disassembler_options): Send errors to stderr.
5064
5065 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
5066
5067         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
5068         (cli_interp_base::set_logging): Check debug_redirect.
5069         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
5070         * cli/cli-logging.c (debug_redirect): Add static variable.
5071         (pop_output_files): Add default param.
5072         (handle_redirections): Print debug setting.
5073         (show_logging_command): Likewise.
5074         (_initialize_cli_logging): Add debugredirect command.
5075         * interps.c (current_interp_set_logging): Add debug_redirect
5076         parameter.
5077         * interps.h (set_logging): Add debug_redirect parameter.
5078         (current_interp_set_logging): Likewise.
5079         * mi/mi-common.h: Likewise.
5080         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
5081
5082 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
5083             Tom Tromey  <tromey@adacore.com>
5084
5085         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
5086         directly.
5087         * cli/cli-interp.h (make_logging_output): Remove declaration.
5088         * cli/cli-logging.c (make_logging_output): Remove function.
5089         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
5090         directly.
5091         * ui-file.c (tee_file::tee_file): Remove bools.
5092         (tee_file::~tee_file): Remove deletes.
5093         * ui-file.h (tee_file): Remove bools.
5094
5095 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
5096
5097         * mi/mi-cmds.h (mi_cmd_complete): New function.
5098         * mi/mi-main.c (mi_cmd_complete): Likewise.
5099         * mi/mi-cmds.c: Define new MI command -complete.
5100         * NEWS: Mention new -complete command.
5101
5102 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
5103
5104         * completer.h (complete): New function.
5105         * completer.c (complete): Likewise.
5106         * cli/cli-cmds.c: (complete_command): Update to use new complete()
5107         function defined in completer.h.
5108
5109 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
5110
5111         * MAINTAINERS (Write After Approval): Add myself.
5112
5113 2019-05-17  Tom de Vries  <tdevries@suse.de>
5114
5115         PR gdb/24094
5116         * dwarf2read.c (struct cu_partial_die_info): New struct.
5117         (find_partial_die): Return cu_partial_die_info.
5118         (partial_die_parent_scope, guess_partial_die_structure_name)
5119         (partial_die_info::fixup): Handle new return type of find_partial_die.
5120
5121 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
5122
5123         * stap-probe.c (stap_parse_register_operand): Make "regname" an
5124         "std::string", simplifying the algorithm.
5125
5126 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
5127
5128         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
5129         (stap_static_probe_ops::get_probes): Likewise.
5130
5131 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
5132
5133         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
5134         '-')" and "else if".
5135         (stap_parse_single_operand): Join checks for
5136         "gdbarch_stap_parse_special_token_p" and
5137         "gdbarch_stap_parse_special_token" in the same "if" statement.
5138         Invert check when verifying for operation on register
5139         displacement.
5140
5141 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
5142
5143         * stap-probe.c (stap_get_opcode): Update comment.
5144         (stap_get_expected_argument_type): Likewise.
5145         (handle_stap_probe): Likewise.
5146
5147 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
5148
5149         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
5150         return type to 'bool'.  Adjust comment.  Use 'bool' when
5151         appropriate.
5152         (i386_stap_parse_special_token_three_arg_disp): Likewise.
5153         * stap-probe.c (stap_parse_argument_1): Likewise.
5154         (stap_is_operator): Likewise.
5155         (stap_is_generic_prefix): Likewise.
5156         (stap_is_register_prefix): Likewise.
5157         (stap_is_register_indirection_prefix): Likewise.
5158         (stap_is_integer_prefix): Likewise.
5159         (stap_generic_check_suffix): Likewise.
5160         (stap_check_integer_suffix): Likewise.
5161         (stap_check_register_suffix): Likewise.
5162         (stap_check_register_indirection_suffix): Likewise.
5163         (stap_parse_register_operand): Likewise.
5164         (stap_parse_single_operand): Likewise.
5165         (stap_parse_argument_1): Likewise.
5166         (stap_probe::get_argument_count): Likewise.
5167         (stap_is_operator): Likewise.
5168
5169 2019-05-16  Tom Tromey  <tromey@adacore.com>
5170
5171         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
5172         keyword to foreach.
5173
5174 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
5175
5176         * linux-thread-db.c (try_thread_db_load_1): Change return type
5177         to bool.
5178         (try_thread_db_load): Likewise.
5179         (try_thread_db_load_from_pdir_1): Likewise.
5180         (try_thread_db_load_from_pdir): Likewise.
5181         (try_thread_db_load_from_sdir): Likewise.
5182         (try_thread_db_load_from_dir): Likewise.
5183         (thread_db_load_search): Likewise.
5184         (has_libpthread): Likewise.
5185         (thread_db_load): Likewise.
5186
5187 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
5188
5189         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
5190         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
5191         NULL, and complain/return if that's the case.
5192
5193 2019-05-15  John Darrington <john@darrington.wattle.id.au>
5194
5195         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
5196         (advance, posn, abstract_read_memory): New functions.
5197         [struct mem_read_abstraction]: New struct.
5198         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
5199
5200 2019-05-14  Tom Tromey  <tromey@adacore.com>
5201
5202         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
5203         value is not lval_memory.
5204
5205 2019-05-14  Tom Tromey  <tromey@adacore.com>
5206
5207         * solib.c (info_sharedlibrary_command): Style the file name.
5208
5209 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
5210
5211         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
5212         (aarch64_vnv_type): Likewise.
5213         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
5214         * common/tdesc.c: Likewise.
5215         * common/tdesc.h (enum tdesc_type_kind): Likewise.
5216         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
5217         * features/aarch64-fpu.xml: Add ieee half view.
5218         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
5219         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
5220         * gdbtypes.h (struct builtin_type): Likewise.
5221         (struct objfile_type): Likewise.
5222
5223 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
5224
5225         * language.c (language_sniff_from_mangled_name): Fix "langauge"
5226         typo.
5227         * location.h (string_to_event_location): Likewise.
5228
5229 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
5230
5231         GDB 8.3 released.
5232
5233 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
5234
5235         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
5236         New variable declaration.
5237         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
5238         New variable.
5239         (print_one_breakpoint): Use ui_out::test_flags and new global
5240         variable to compute use_fixed_output.
5241         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
5242         Remove.
5243         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
5244         (mi_multi_location_breakpoint_output_fixed): Remove.
5245         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
5246         new variable.
5247         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
5248         fix_multi_location_breakpoint_output flag if version >= 3.
5249         * ui-out.h (enum ui_out_flag)
5250         <fix_multi_location_breakpoint_output>: New enumerator.
5251
5252 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
5253
5254         * contrib/cc-with-tweaks.sh: Validate dwz's work.
5255
5256 2019-05-10  Tom Tromey  <tromey@adacore.com>
5257
5258         * ada-lang.c (catch_ada_completer): New function.
5259         (_initialize_ada_language): Use it.
5260
5261 2019-05-10  Tom Tromey  <tromey@adacore.com>
5262
5263         * thread.c (print_thread_info): Make "requested_threads" const.
5264         * gdbthread.h (print_thread_info): Make "requested_threads"
5265         const.
5266         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
5267         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
5268
5269 2019-05-08  Tom Tromey  <tom@tromey.com>
5270
5271         * gdbtypes.c (objfile_type_data): Change type.
5272         (objfile_type, _initialize_gdbtypes): Update.
5273
5274 2019-05-08  Tom Tromey  <tom@tromey.com>
5275
5276         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
5277         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
5278         (_initialize_dwarf2_frame): Update.
5279
5280 2019-05-08  Tom Tromey  <tom@tromey.com>
5281
5282         * objc-lang.c (objc_objfile_data): Change type.
5283         (find_methods): Update.
5284         (_initialize_objc_lang): Remove.
5285
5286 2019-05-08  Tom Tromey  <tom@tromey.com>
5287
5288         * stabsread.c (rs6000_builtin_type_data): Change type.
5289         (rs6000_builtin_type, _initialize_stabsread): Update.
5290
5291 2019-05-08  Tom Tromey  <tom@tromey.com>
5292
5293         * mips-tdep.c (mips_pdr_data): Remove.
5294         (_initialize_mips_tdep): Update.
5295
5296 2019-05-08  Tom Tromey  <tom@tromey.com>
5297
5298         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
5299         (hppa_init_objfile_priv_data, read_unwind_info)
5300         (find_unwind_entry, _initialize_hppa_tdep): Update.
5301
5302 2019-05-08  Tom Tromey  <tom@tromey.com>
5303
5304         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
5305         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
5306         on obstack.
5307         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
5308
5309 2019-05-08  Tom Tromey  <tom@tromey.com>
5310
5311         * mdebugread.c (basic_type_data): Change type.
5312         (basic_type, _initialize_mdebugread): Update.
5313
5314 2019-05-08  Tom Tromey  <tom@tromey.com>
5315
5316         * common/gdb_unique_ptr.h (struct noop_deleter): New.
5317
5318 2019-05-08  Tom Tromey  <tom@tromey.com>
5319
5320         * nto-tdep.c (nto_inferior_data_reg): Change type.
5321         (nto_inferior_data): Update.
5322         (nto_inferior_data_cleanup, nto_new_inferior_data)
5323         (_initialize_nto_tdep): Remove.
5324         * nto-tdep.h (struct nto_inferior_data): Add initializers.
5325
5326 2019-05-08  Tom Tromey  <tom@tromey.com>
5327
5328         * ada-lang.c (struct ada_inferior_data): Add initializers.
5329         (ada_inferior_data): Change type.
5330         (ada_inferior_data_cleanup): Remove.
5331         (get_ada_inferior_data, ada_inferior_exit)
5332         (struct ada_pspace_data): Add initializers, destructor.
5333         (ada_pspace_data_handle): Change type.
5334         (get_ada_pspace_data): Update.
5335         (ada_pspace_data_cleanup): Remove.
5336
5337 2019-05-08  Tom Tromey  <tom@tromey.com>
5338
5339         * coffread.c (struct coff_symfile_info): Add initializers.
5340         (coff_objfile_data_key): Move lower.  Change type.
5341         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
5342         Update.
5343         (coff_free_info): Remove.
5344
5345 2019-05-08  Tom Tromey  <tom@tromey.com>
5346
5347         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
5348         (fbsd_pspace_data_handle): Move lower.  Change type.
5349         (get_fbsd_pspace_data): Update.
5350         (fbsd_pspace_data_cleanup): Remove.
5351         (_initialize_fbsd_tdep): Update.
5352
5353 2019-05-08  Tom Tromey  <tom@tromey.com>
5354
5355         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
5356         (get_ada_tasks_pspace_data): Update.
5357         (ada_tasks_pspace_data_cleanup): Remove.
5358         (_initialize_tasks): Update.
5359         (ada_tasks_inferior_data_handle): Change type.
5360         (get_ada_tasks_inferior_data): Update.
5361         (ada_tasks_inferior_data_cleanup): Remove.
5362         (struct ada_tasks_pspace_data): Add initializers.
5363
5364 2019-05-08  Tom Tromey  <tom@tromey.com>
5365
5366         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
5367         * symfile-debug.c (debug_sym_get_probes): Change type.
5368         * stap-probe.c (handle_stap_probe):
5369         (stap_static_probe_ops::get_probes): Change type.
5370         * probe.h (class static_probe_ops) <get_probes>: Change type.
5371         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
5372         (parse_probes_in_pspace): Update.
5373         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
5374         Update.
5375         (any_static_probe_ops::get_probes): Change type.
5376         * elfread.c (elfread_data): New typedef.
5377         (probe_key): Change type.
5378         (elf_get_probes): Likewise.  Update.
5379         (probe_key_free): Remove.
5380         (_initialize_elfread): Update.
5381         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
5382         Change type.
5383         (dtrace_process_dof_probe, dtrace_process_dof)
5384         (dtrace_static_probe_ops::get_probe): Change type.
5385
5386 2019-05-08  Tom Tromey  <tom@tromey.com>
5387
5388         * xcoffread.c (struct xcoff_symfile_info): Rename from
5389         coff_symfile_info.  Add initializers.
5390         (xcoff_objfile_data_key): Move lower.  Change type.
5391         (XCOFF_DATA): Rewrite.
5392         (xcoff_free_info): Remove.
5393         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
5394         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
5395         (xcoff_initial_scan): Update.
5396
5397 2019-05-08  Tom Tromey  <tom@tromey.com>
5398
5399         * solib-svr4.c (struct svr4_info): Add initializers and
5400         destructor.
5401         <probes_table>: Now an htab_up.
5402         (solib_svr4_pspace_data): Change type.
5403         (free_probes_table): Simplify.
5404         (~svr4_info): Rename from svr4_pspace_data_cleanup.
5405         (get_svr4_info, probes_table_htab_remove_objfile_probes)
5406         (probes_table_remove_objfile_probes, register_solib_event_probe)
5407         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
5408         (_initialize_svr4_solib): Update.
5409
5410 2019-05-08  Tom Tromey  <tom@tromey.com>
5411
5412         * remote.c (remote_pspace_data): Change type.
5413         (remote_pspace_data_cleanup): Remove.
5414         (get_remote_exec_file, set_pspace_remote_exec_file)
5415         (_initialize_remote): Update.
5416
5417 2019-05-08  Tom Tromey  <tom@tromey.com>
5418
5419         * breakpoint.c (breakpoint_objfile_key): Change type.
5420         (get_breakpoint_objfile_data): Update.
5421         (free_breakpoint_objfile_data): Remove.
5422         (_initialize_breakpoint): Update.
5423
5424 2019-05-08  Tom Tromey  <tom@tromey.com>
5425
5426         * linux-tdep.c (struct linux_info): Add initializers.
5427         (linux_inferior_data): Move.  Change type.
5428         (invalidate_linux_cache_inf): Update.
5429         (linux_inferior_data_cleanup): Remove.
5430         (get_linux_inferior_data, _initialize_linux_tdep): Update.
5431
5432 2019-05-08  Tom Tromey  <tom@tromey.com>
5433
5434         * auxv.c (auxv_inferior_data): Move.  Change type.
5435         (auxv_inferior_data_cleanup): Remove.
5436         (invalidate_auxv_cache_inf): Rewrite.
5437         (get_auxv_inferior_data, _initialize_auxv): Update.
5438
5439 2019-05-08  Tom Tromey  <tom@tromey.com>
5440
5441         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
5442         (symfile_debug_objfile_data_key): Change type.
5443         (symfile_debug_installed, debug_qf_has_symbols)
5444         (debug_qf_find_last_source_symtab)
5445         (debug_qf_forget_cached_source_info)
5446         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
5447         (debug_qf_print_stats, debug_qf_dump)
5448         (debug_qf_expand_symtabs_for_function)
5449         (debug_qf_expand_all_symtabs)
5450         (debug_qf_expand_symtabs_with_fullname)
5451         (debug_qf_map_matching_symbols)
5452         (debug_qf_expand_symtabs_matching)
5453         (debug_qf_find_pc_sect_compunit_symtab)
5454         (debug_qf_map_symbol_filenames)
5455         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
5456         (debug_sym_new_init, debug_sym_init, debug_sym_read)
5457         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
5458         (debug_sym_read_linetable, debug_sym_relocate): Update.
5459         (symfile_debug_free_objfile): Remove.
5460         (install_symfile_debug_logging, _initialize_symfile_debug):
5461         Update.
5462
5463 2019-05-08  Tom Tromey  <tom@tromey.com>
5464
5465         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
5466         allocate_on_obstack.
5467         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
5468         (get_dwarf2_per_objfile): Update.
5469         (set_dwarf2_per_objfile): Remove.
5470         (dwarf2_has_info, dwarf2_get_section_info): Update.
5471         (dwarf2_free_objfile): Remove.
5472         (_initialize_dwarf2_read): Update.
5473
5474 2019-05-08  Tom Tromey  <tom@tromey.com>
5475
5476         * auto-load.c (struct auto_load_pspace_info): Add destructor and
5477         initializers.
5478         <unsupported_script_warning_printed,
5479         script_not_found_warning_printed>: Now bool.
5480         (auto_load_pspace_data): Change type.
5481         (~auto_load_pspace_info): Rename from
5482         auto_load_pspace_data_cleanup.
5483         (get_auto_load_pspace_data, init_loaded_scripts_info)
5484         (clear_section_scripts, maybe_print_unsupported_script_warning)
5485         (maybe_print_script_not_found_warning, _initialize_auto_load):
5486         Update.
5487
5488 2019-05-08  Tom Tromey  <tom@tromey.com>
5489
5490         * objfiles.c (objfile_pspace_info): Add destructor and
5491         initializers.
5492         (objfiles_pspace_data): Change type.
5493         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
5494         (get_objfile_pspace_data): Update.
5495         (objfiles_bfd_data): Change type.
5496         (get_objfile_bfd_data): Update.
5497         (objfile_bfd_data_free, _initialize_objfiles): Remove.
5498
5499 2019-05-08  Tom Tromey  <tom@tromey.com>
5500
5501         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
5502         Change type.
5503         (get_catch_syscall_inferior_data): Update.
5504         (catch_syscall_inferior_data_cleanup): Remove.
5505         (_initialize_break_catch_syscall): Update.
5506
5507 2019-05-08  Tom Tromey  <tom@tromey.com>
5508
5509         * inflow.c (struct terminal_info): Add destructor and
5510         initializers.
5511         (inflow_inferior_data): Change type.
5512         (~terminal_info): Rename from inflow_inferior_data_cleanup.
5513         (get_inflow_inferior_data, inflow_inferior_exit)
5514         (swap_terminal_info, _initialize_inflow): Update.
5515
5516 2019-05-08  Tom Tromey  <tom@tromey.com>
5517
5518         * target-dcache.c (target_dcache_cleanup): Remove.
5519         (target_dcache_aspace_key): Change type.
5520         (target_dcache_init_p, target_dcache_invalidate)
5521         (target_dcache_get, target_dcache_get_or_init)
5522         (_initialize_target_dcache): Update.
5523         * dcache.h (struct dcache_deleter): New.
5524
5525 2019-05-08  Tom Tromey  <tom@tromey.com>
5526
5527         * symtab.c (struct symbol_cache): Add destructor and
5528         initializers.
5529         (symbol_cache_key): Move.  Change type.
5530         (make_symbol_cache, free_symbol_cache): Remove.
5531         (get_symbol_cache): Update.
5532         (symbol_cache_cleanup): Remove.
5533         (ALL_PSPACES, symbol_cache_flush)
5534         (maintenance_print_symbol_cache)
5535         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
5536         Update.
5537
5538 2019-05-08  Tom Tromey  <tom@tromey.com>
5539
5540         * symtab.c (struct main_info): Add destructor and initializers.
5541         (main_progspace_key): Move.  Change type.
5542         (get_main_info): Update.
5543         (main_info_cleanup): Remove.
5544         (_initialize_symtab): Update.
5545
5546 2019-05-08  Tom Tromey  <tom@tromey.com>
5547
5548         * registry.h (DECLARE_REGISTRY): Define the _key class.
5549
5550 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
5551
5552         * NEWS: Merge two 'New commands' sections.
5553
5554 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
5555
5556         * ada-valprint.c (ada_val_print_gnat_array): Remove language
5557         parameter and use Ada language definition instead.
5558         (ada_val_print_ptr): Remove unused language parameter.
5559         (ada_val_print_num): Remove language parameter and use Ada language
5560         definition instead.
5561         (ada_val_print_enum, ada_val_print_flt): Remove unused language
5562         parameter.
5563         (ada_val_print_struct_union, ada_val_print_ref): Remove language
5564         parameter and use Ada language definition instead.
5565         (ada_val_print_1): Update all ada_val_print_xxx calls.
5566         Remove language parameter.
5567         (ada_val_print): Update ada_val_print_1 call.
5568
5569 2019-05-08  Tom Tromey  <tromey@adacore.com>
5570
5571         * remote.c (remote_hw_watchpoint_limit)
5572         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
5573         Now static.
5574
5575 2019-05-08  Tom Tromey  <tromey@adacore.com>
5576
5577         * maint.c (_initialize_maint_cmds): Move initialization code to
5578         remote.c.
5579         (watchdog, show_watchdog): Move to remote.c.
5580         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
5581         "watchdog" static.
5582         (_initialize_remote): Move initialization code from maint.c.
5583         * defs.h (watchdog): Don't declare.
5584
5585 2019-05-08  Tom Tromey  <tromey@adacore.com>
5586
5587         * tui/tui-interp.c: Include main.h.
5588         * interps.c: Include main.h.
5589         * main.h (interpreter_p): Declare.
5590         * defs.h (interpreter_p): Don't declare.
5591
5592 2019-05-08  Tom Tromey  <tromey@adacore.com>
5593
5594         * dwarf2loc.c: Include dwarf2read.h.
5595         * defs.h (read_unsigned_leb128): Don't declare.
5596         * dwarf2read.h (read_unsigned_leb128): Declare.
5597
5598 2019-05-08  Tom Tromey  <tromey@adacore.com>
5599
5600         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
5601         method.
5602
5603 2019-05-08  Tom Tromey  <tromey@adacore.com>
5604
5605         * utils.c (fputs_maybe_filtered): Reset style after paging, even
5606         when no wrap column is set.
5607
5608 2019-05-08  Tom Tromey  <tromey@adacore.com>
5609
5610         * c-lang.c (c_get_string): Handle non-C-style arrays.
5611
5612 2019-05-08  Tom Tromey  <tromey@adacore.com>
5613
5614         * typeprint.c (print_offset_data::update): Print the bit offset,
5615         not the number of bits remaining.
5616
5617 2019-05-08  Tom Tromey  <tromey@adacore.com>
5618
5619         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
5620         padding at end of comment.
5621
5622 2019-05-08  Tom Tromey  <tromey@adacore.com>
5623
5624         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
5625         Compare main types.
5626
5627 2019-05-06  Tom Tromey  <tom@tromey.com>
5628
5629         * common/scoped_mmap.c: Include common-defs.h.
5630         * common/scoped_mmap.h: Don't include config.h.
5631
5632 2019-05-04  Tom Tromey  <tom@tromey.com>
5633
5634         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
5635         (struct aarch64_call_info): Add initializers.
5636         <si>: Now a std::vector.
5637         (pass_on_stack, aarch64_push_dummy_call): Update.
5638
5639 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
5640             Tom Tromey  <tom@tromey.com>
5641
5642         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
5643         (ppc_threads): Now a std::vector.  Now static.
5644         (hwdebug_find_thread_points_by_tid)
5645         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
5646         Update.
5647
5648 2019-05-04  Tom Tromey  <tom@tromey.com>
5649
5650         * arc-tdep.c (arc_tdesc_init): Return bool.
5651
5652 2019-05-04  Tom Tromey  <tom@tromey.com>
5653
5654         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
5655         Use gdb_assert_not_reached.
5656
5657 2019-05-04  Tom Tromey  <tom@tromey.com>
5658
5659         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
5660         "false".
5661
5662 2019-05-04  Tom Tromey  <tom@tromey.com>
5663
5664         * arc-tdep.c (arc_tdesc_init): Use bool.
5665
5666 2019-05-04  Tom Tromey  <tom@tromey.com>
5667
5668         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
5669
5670 2019-05-04  Tom Tromey  <tom@tromey.com>
5671
5672         * cli/cli-cmds.c (valid_command_p): Return bool.
5673
5674 2019-05-04  Tom Tromey  <tom@tromey.com>
5675
5676         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
5677         * command.h (valid_user_defined_cmd_name_p): Channge return type.
5678
5679 2019-05-04  Raul Tambre  <raul@tambre.ee>
5680
5681         * python/lib/gdb/prompt.py (_ExtendedPrompt)
5682         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
5683         operator for comparison.
5684
5685 2019-05-04  Tom Tromey  <tom@tromey.com>
5686
5687         * psymtab.c (psymbol_name_matches, match_partial_symbol)
5688         (lookup_partial_symbol, print_partial_symbols)
5689         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
5690         (psymbol_compare): Update.
5691         (add_psymbol_to_bcache): Clear the entire psymbol.
5692         (maintenance_check_psymtabs): Update.
5693         * psympriv.h (struct partial_symbol): Don't derive from
5694         general_symbol_info.
5695         <obj_section, unrelocated_address, address,
5696         set_unrelocated_address>: Update.
5697         <ginfo>: New member.
5698         * dwarf-index-write.c (write_psymbols, debug_names::insert)
5699         (debug_names::write_psymbols): Update.
5700
5701 2019-05-04  Tom de Vries  <tdevries@suse.de>
5702
5703         * contrib/cc-with-tweaks.sh: Support -n arg.
5704
5705 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5706
5707         * corelow.c (core_target::detach): Ensure frame cache and
5708         register caches are cleared.
5709         inferior.c (exit_inferior_1): Likewise.
5710
5711 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
5712             Tom Tromey  <tom@tromey.com>
5713
5714         * dictionary.c (collate_pending_symbols_by_language): Remove
5715         "struct" from foreach.
5716         * symtab.c (lookup_global_symbol_from_objfile)
5717         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
5718         foreach.
5719         * ser-tcp.c (net_open): Remove "struct" from foreach.
5720         * objfiles.c (objfile_relocate, objfile_rebase)
5721         (objfile_has_symbols): Remove "struct" from foreach.
5722         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
5723         from foreach.
5724         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
5725         foreach.
5726         * darwin-nat.c (thread_info_from_private_thread_info): Remove
5727         "struct" from foreach.
5728         * ada-lang.c (create_excep_cond_exprs)
5729         (ada_exception_catchpoint_cond_string): Remove "struct" from
5730         foreach.
5731
5732 2019-05-03  Tom Tromey  <tromey@adacore.com>
5733
5734         * ada-exp.y (convert_char_literal): Check suffix of each
5735         enumerator.
5736
5737 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
5738
5739         PR ada/21406:
5740         * ada-exp.y (yywrap): Don't define.
5741         * ada-lex.l (%option): Add noyywrap
5742         (yywrap): Remove.
5743
5744 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
5745
5746         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
5747         _WIN32_WINNT to the XP level, unless already defined to a higher
5748         level.
5749
5750         * unittests/parse-connection-spec-selftests.c:
5751         * ser-tcp.c:
5752         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
5753         override.
5754
5755         * symfile.c (find_separate_debug_file): Remove colon from the
5756         drive spec of DOS/Windows file names of the target, so that the
5757         file name produced from DEBUGDIR and the target's directory will
5758         be valid on DOS/Windows systems.
5759
5760 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
5761
5762         * rust-lang.c (val_print_struct): Handle printing structures
5763         containing strings.
5764
5765 2019-05-02  Tom Tromey  <tromey@adacore.com>
5766
5767         * valarith.c (_initialize_valarith): Remove.
5768
5769 2019-05-01  Tom Tromey  <tromey@adacore.com>
5770
5771         * ada-lang.c (ada_value_primitive_field): Treat more fields as
5772         bitfields.
5773
5774 2019-05-01  Tom Tromey  <tromey@adacore.com>
5775
5776         * ada-lang.c (ada_value_assign): Correctly compute starting offset
5777         for big-endian copies.
5778
5779 2019-04-30  Ali Tamur  <tamur@google.com>
5780         * gdb/dwarf2read.c (read_3_bytes): New declaration.
5781         (read_attribute_value): Added DW_FORM_strx1-4 cases.
5782         (read_3_bytes): New function.
5783
5784 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
5785
5786         * windows-nat.c (main_thread_id): Delete.
5787         (handle_output_debug_string): Replace main_thread_id by
5788         current_event.dwThreadId.
5789         (fake_create_process): Likewise.
5790         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
5791         Do not set main_thread_id.
5792         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
5793         current_event.dwThreadId.
5794         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
5795
5796 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
5797
5798         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
5799         Use current_event.dwThreadId instead of main_thread_id.
5800
5801 2019-04-30  Tom Tromey  <tromey@adacore.com>
5802
5803         * ada-lang.c (ada_lookup_simple_minsyms): New function.
5804         (create_excep_cond_exprs): Iterate over program spaces.
5805         (ada_exception_catchpoint_cond_string): Examine all minimal
5806         symbols for exception types.
5807
5808 2019-04-30  Tom Tromey  <tromey@adacore.com>
5809
5810         PR c++/24470:
5811         * dwarf2read.c (process_structure_scope): Handle case where type
5812         has template parameters but no symbol was created.
5813
5814 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5815             Chris January  <chris.january@arm.com>
5816
5817         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
5818         qualifier.
5819         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
5820
5821 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5822
5823         * f-typeprint.c (f_print_type): Update rules for printing
5824         whitespace.
5825         (f_type_print_varspec_suffix): Likewise.
5826
5827 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5828             Chris January  <chris.january@arm.com>
5829
5830         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
5831         function arguments.
5832
5833 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5834
5835         * f-lang.c (build_fortran_types): Change name of void type to
5836         lower case.
5837         * f-typeprint.c (f_type_print_base): Print the name of the void
5838         type, rather than a fixed string.
5839         * f-valprint.c (f_decorations): Use lower case void string.
5840
5841 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5842             Chris January  <chris.january@arm.com>
5843
5844         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
5845         types for Fortran.
5846
5847 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5848             Chris January  <chris.january@arm.com>
5849             David Lecomber  <david.lecomber@arm.com>
5850
5851         * f-exp.y (BINOP_INTRINSIC): New token.
5852         (exp): New parser rule handling BINOP_INTRINSIC.
5853         (f77_keywords): Add new builtin procedures.
5854         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
5855         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
5856         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
5857         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
5858         (print_unop_subexp_f): New function.
5859         (print_binop_subexp_f): New function.
5860         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
5861         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
5862         (dump_subexp_body_f): Likewise.
5863         (operator_check_f): Likewise.
5864         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
5865         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
5866
5867 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5868
5869         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
5870         UNOP_KIND.
5871         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
5872         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
5873         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
5874         (operator_length_f): New fuction.
5875         (print_subexp_f): New function.
5876         (op_name_f): New function.
5877         (dump_subexp_body_f): New function.
5878         (operator_check_f): New function.
5879         (exp_descriptor_f): Replace standard expression handling functions
5880         with new functions.
5881         * gdb/fortran-operator.def: New file.
5882         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
5883         * gdb/std-operator.def: Remove UNOP_KIND.
5884
5885 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5886
5887         * std-operator.def: Remove unbalanced, stray double quote
5888         character.
5889
5890 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5891             Chris January  <chris.january@arm.com>
5892             Daniel Everett  <daniel.everett@arm.com>
5893             Nick Forrington  <nick.forrington@arm.com>
5894             Richard Bunt  <richard.bunt@arm.com>
5895
5896         * cp-valprint.c (cp_print_value_fields): Allow an additional level
5897         of depth when printing anonymous structs or unions.
5898         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
5899         Don't print either the top-level value, or the children if the
5900         max-depth is exceeded.
5901         (ppscm_print_children): When printing the key of a map, allow one
5902         extra level of depth.
5903         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
5904         print either the top-level value, or the children if the max-depth
5905         is exceeded.
5906         (print_children): When printing the key of a map, allow one extra
5907         level of depth.
5908         * python/py-value.c (valpy_format_string): Add max_depth keyword.
5909         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
5910         (user_print_options): Initialise max_depth field.
5911         (val_print_scalar_or_string_type_p): New function.
5912         (val_print): Check to see if the max depth has been reached.
5913         (val_print_check_max_depth): Define new function.
5914         (show_print_max_depth): New function.
5915         (_initialize_valprint): Add 'print max-depth' option.
5916         * valprint.h (struct value_print_options) <max_depth>: New field.
5917         (val_print_check_max_depth): Declare new function.
5918         * NEWS: Document new feature.
5919
5920 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5921
5922         * ada-lang.c (ada_language_defn): Initialise new field.
5923         * c-lang.c (c_is_string_type_p): New function.
5924         (c_language_defn): Initialise new field.
5925         (cplus_language_defn): Initialise new field.
5926         (asm_language_defn): Initialise new field.
5927         (minimal_language_defn): Initialise new field.
5928         * c-lang.h (c_is_string_type_p): Declare new function.
5929         * d-lang.c (d_language_defn): Initialise new field.
5930         * f-lang.c (f_is_string_type_p): New function.
5931         (f_language_defn): Initialise new field.
5932         * go-lang.c (go_is_string_type_p): New function.
5933         (go_language_defn): Initialise new field.
5934         * language.c (default_is_string_type_p): New function.
5935         (unknown_language_defn): Initialise new field.
5936         (auto_language_defn): Initialise new field.
5937         * language.h (struct language_defn) <la_is_string_type_p>: New
5938         member variable.
5939         (default_is_string_type_p): Declare new function.
5940         * m2-lang.c (m2_language_defn): Initialise new field.
5941         * objc-lang.c (objc_language_defn): Initialise new field.
5942         * opencl-lang.c (opencl_language_defn): Initialise new field.
5943         * p-lang.c (pascal_is_string_type_p): New function.
5944         (pascal_language_defn): Initialise new field.
5945         * rust-lang.c (rust_is_string_type_p): New function.
5946         (rust_language_defn): Initialise new field.
5947
5948 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5949
5950         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
5951         New field.
5952         * ada-lang.c (ada_language_defn): Initialise new field.
5953         * c-lang.c (c_language_defn): Likewise.
5954         (cplus_language_defn): Likewise.
5955         (asm_language_defn): Likewise.
5956         (minimal_language_defn): Likewise.
5957         * d-lang.c (d_language_defn): Likewise.
5958         * f-lang.c (f_language_defn): Likewise.
5959         * go-lang.c (go_language_defn): Likewise.
5960         * language.c (unknown_language_defn): Likewise.
5961         (auto_language_defn): Likewise.
5962         * m2-lang.c (m2_language_defn): Likewise.
5963         * objc-lang.c (objc_language_defn): Likewise.
5964         * opencl-lang.c (opencl_language_defn): Likewise.
5965         * p-lang.c (pascal_language_defn): Likewise.
5966         * rust-lang.c (rust_language_defn): Likewise.
5967
5968 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5969
5970         * ada-lang.c (ada_is_character_type): Change return type to bool.
5971         (ada_is_string_type): Likewise.
5972         * ada-lang.h (ada_is_character_type): Update declaration
5973         (ada_is_string_type): Likewise.
5974
5975 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5976
5977         Support style in 'frame|thread apply'
5978
5979         * gdbcmd.h (execute_command_to_string): New term_out parameter.
5980         * record.c (record_start, record_stop): Update callers of
5981         execute_command_to_string with false.
5982         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
5983         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
5984         methods.
5985         (class string_file): New constructor with term_out parameter.
5986         Override methods term_out and can_emit_style_escape.  New member
5987         term_out.
5988         (class stdio_file): Override can_emit_style_escape.
5989         (class tee_file): Override term_out and can_emit_style_escape.
5990         * utils.h (can_emit_style_escape): Remove.
5991         * utils.c (can_emit_style_escape): Likewise.
5992         Update all callers of can_emit_style_escape (SOMESTREAM) to
5993         SOMESTREAM->can_emit_style_escape.
5994         * source-cache.c (source_cache::get_source_lines): Likewise.
5995         * stack.c (frame_apply_command_count): Call execute_command_to_string
5996         passing the term_out characteristic of the current gdb_stdout.
5997         * thread.c (thr_try_catch_cmd): Likewise.
5998         * top.c (execute_command_to_string): pass term_out parameter
5999         to construct the string_file for the command output.
6000         * ui-file.c (term_cli_styling): New function (most code moved
6001         from utils.c can_emit_style_escape).
6002         (string_file::string_file, string_file::can_emit_style_escape,
6003         stdio_file::can_emit_style_escape, tee_file::term_out,
6004         tee_file::can_emit_style_escape): New functions.
6005
6006 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6007
6008         * NEWS: Mention the new set|show may-call-functions.
6009         * infcall.c (may_call_functions_p): New variable.
6010         (show_may_call_functions_p): New function.
6011         (call_function_by_hand_dummy): Throws an error if not
6012         may-call-functions.
6013         (_initialize_infcall): Call add_setshow_boolean_cmd for
6014         may-call-functions.
6015
6016 2019-04-25  Keith Seitz  <keiths@redhat.com>
6017
6018         PR c++/24367
6019         * cp-support.c (inspect_type): Don't attempt substitutions
6020         of symbol with the same name.
6021
6022 2019-04-25  Tom Tromey  <tromey@adacore.com>
6023
6024         PR gdb/24475:
6025         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
6026         static.
6027
6028 2019-04-25  Tom Tromey  <tromey@adacore.com>
6029
6030         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
6031         rvalue reference.
6032         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
6033         (gdb_xml_parser::parse): Use std::move.
6034         * python/python-internal.h (gdbpy_convert_exception): Take a const
6035         reference.
6036         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
6037         std::move.
6038         * python/py-utils.c (gdbpy_convert_exception): Take a const
6039         reference.
6040         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
6041         Use std::move.
6042         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
6043         Use std::move.
6044         * mi/mi-main.c (mi_print_exception): Take a const reference.
6045         * main.c (handle_command_errors): Take a const reference.
6046         * linespec.c (parse_linespec): Use std::move.
6047         * infcall.c (run_inferior_call): Use std::move.
6048         (call_function_by_hand_dummy): Use std::move.
6049         * exec.c (try_open_exec_file): Use std::move.
6050         * exceptions.h (exception_print, exception_fprintf)
6051         (exception_print_same): Update.
6052         * exceptions.c (print_exception, exception_print)
6053         (exception_fprintf, exception_print_same): Change parameters to
6054         const reference.
6055         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
6056         * common/new-op.c: Use std::move.
6057         * common/common-exceptions.h (struct gdb_exception): Add move
6058         constructor.
6059         (struct gdb_exception_error, struct gdb_exception_quit, struct
6060         gdb_quit_bad_alloc): Change constructor to move constructor.
6061         (throw_exception): Change parameter to rvalue reference.
6062         * common/common-exceptions.c (throw_exception): Take rvalue
6063         reference.
6064         * cli/cli-interp.c (safe_execute_command): Use std::move.
6065         * breakpoint.c (insert_bp_location, location_to_sals): Use
6066         std::move.
6067
6068 2019-04-25  Tom Tromey  <tromey@adacore.com>
6069
6070         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
6071         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
6072         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
6073         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
6074         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
6075         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
6076         guile/scm-value.c: Use unpack.
6077         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
6078         gdbscm_gdb_exception.
6079         (gdbscm_throw_gdb_exception): Likewise.
6080         (struct gdbscm_gdb_exception): New.
6081         (unpack): New function.
6082         (gdbscm_wrap): Use unpack.
6083
6084 2019-04-25  Tom Tromey  <tromey@adacore.com>
6085
6086         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
6087         (gdb_rl_callback_handler): Use std::move.
6088         * common/common-exceptions.h (struct gdb_exception): Add move
6089         assignment operator.
6090         (throw_exception_sjlj): Change "exception" to const reference.
6091         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
6092         (throw_exception_sjlj): Change "exception" to const reference.
6093
6094 2019-04-25  Tom Tromey  <tromey@adacore.com>
6095
6096         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
6097         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
6098         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
6099         Update.
6100         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
6101         Update.
6102         * mi/mi-interp.c (mi_interp::exec): Update.
6103         * linespec.c (parse_linespec): Update.
6104         * infcall.c (run_inferior_call): Update.
6105         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
6106         * guile/scm-symbol.c (gdbscm_lookup_symbol)
6107         (gdbscm_lookup_global_symbol): Update.
6108         * guile/scm-param.c (gdbscm_parameter_value): Update.
6109         * guile/scm-frame.c (gdbscm_frame_read_register)
6110         (gdbscm_frame_read_var): Update.
6111         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
6112         * exec.c (try_open_exec_file): Update.
6113         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
6114         (gdb_rl_callback_handler): Update.
6115         * common/common-exceptions.h (exception_none): Don't declare.
6116         * common/common-exceptions.c (exception_none): Don't define.
6117         (struct catcher) <exception>: Update.
6118         * cli/cli-interp.c (safe_execute_command): Update.
6119         * breakpoint.c (insert_bp_location, location_to_sals): Update.
6120
6121 2019-04-25  Ali Tamur  <tamur@google.com>
6122
6123         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
6124         (read_attribute_value): Likewise.
6125         (dwarf2_read_addr_index): Update comment.
6126         (read_str_index): Add DW_FORM_strx.
6127         (dwarf2_string_attr): Likewise.
6128         (dwarf2_const_value_attr): Likewise.
6129         (dump_die_shallow): Likewise.
6130         (dwarf2_fetch_constant_bytes): Likewise.
6131         (skip_form_bytes): Likewise.
6132         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
6133
6134 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
6135
6136         PR corefiles/11608
6137         PR corefiles/18187
6138         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
6139         OFFSET.  Verify if current mapping contains an ELF header.
6140         (linux_find_memory_regions_full): Adjust call to
6141         dump_mapping_p.
6142
6143 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
6144             Kang Li <kanglictf@gmail.com>
6145
6146         PR gdb/21600
6147
6148         * dwarf2-frame.c (read_initial_length): Be consistent about using
6149         unsigned representation of length.
6150         (decode_frame_entry_1): Likewise.  Check for wraparound of
6151         end pointer as well as buffer overflow.
6152
6153 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
6154
6155         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
6156         "vq".
6157
6158 2019-04-24  Tom Tromey  <tromey@adacore.com>
6159
6160         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
6161
6162 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6163
6164         * s12z-tdep.c (s12z_unwind_pc): Delete.
6165         (s12z_unwind_sp): Delete.
6166         (s12z_gdbarch_init): Don't register deleted functions with
6167         gdbarch.
6168
6169 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6170
6171         * rl78-tdep.c (rl78_unwind_sp): Delete.
6172         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
6173
6174 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6175
6176         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
6177         (xstormy16_unwind_pc): Delete.
6178         (xstormy16_dummy_id): Delete.
6179         (xstormy16_gdbarch_init): Don't register deleted functions with
6180         gdbarch.
6181
6182 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6183
6184         * vax-tdep.c (vax_unwind_pc): Delete.
6185         (vax_gdbarch_init): Don't register deleted function with gdbarch.
6186
6187 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6188
6189         * v850-tdep.c (v850_unwind_sp): Delete.
6190         (v850_unwind_pc): Delete.
6191         (v850_dummy_id): Delete.
6192         (v850_gdbarch_init): Don't register deleted functions with
6193         gdbarch.
6194
6195 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6196
6197         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
6198         (tilegx_unwind_pc): Delete.
6199         (tilegx_unwind_dummy_id): Delete.
6200         (tilegx_gdbarch_init): Don't register deleted functions with
6201         gdbarch.
6202
6203 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6204
6205         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
6206         (tic6x_dummy_id): Delete.
6207         (tic6x_gdbarch_init): Don't register deleted functions with
6208         gdbarch.
6209
6210 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6211
6212         * sparc-tdep.c (sparc_unwind_pc): Delete.
6213         (sparc32_gdbarch_init): Don't register deleted function with
6214         gdbarch.
6215
6216 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6217
6218         * sh-tdep.c (sh_unwind_sp): Delete.
6219         (sh_unwind_pc): Delete.
6220         (sh_dummy_id): Delete.
6221         (sh_gdbarch_init): Don't register deleted functions with
6222         gdbarch.
6223
6224 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6225
6226         * score-tdep.c (score_unwind_sp): Delete.
6227         (score_unwind_pc): Delete.
6228         (score_dummy_id): Delete.
6229         (score_gdbarch_init): Don't register deleted functions with
6230         gdbarch.
6231
6232 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6233
6234         * rx-tdep.c (rx_unwind_pc): Delete.
6235         (rx_unwind_sp): Delete.
6236         (rx_dummy_id): Delete.
6237         (rx_gdbarch_init): Don't register deleted functions with
6238         gdbarch.  Update comment.
6239
6240 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6241
6242         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
6243         (rs6000_dummy_id): Delete.
6244         (rs6000_gdbarch_init): Don't register deleted functions with
6245         gdbarch.
6246
6247 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6248
6249         * or1k-tdep.c (or1k_dummy_id): Delete.
6250         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
6251
6252 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6253
6254         * nios2-tdep.c (nios2_dummy_id): Delete.
6255         (nios2_unwind_sp): Delete.
6256         (nios2_gdbarch_init): Don't register deleted functions with
6257         gdbarch.
6258
6259 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6260
6261         * nds32-tdep.c (nds32_dummy_id): Delete.
6262         (nds32_unwind_pc): Delete.
6263         (nds32_unwind_sp): Delete.
6264         (nds32_gdbarch_init): Don't register deleted functions with
6265         gdbarch.
6266
6267 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6268
6269         * msp430-tdep.c (msp430_unwind_pc): Delete.
6270         (msp430_unwind_sp): Delete.
6271         (msp430_dummy_id): Delete.
6272         (msp430_gdbarch_init): Don't register deleted functions with
6273         gdbarch.
6274
6275 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6276
6277         * moxie-tdep.c (moxie_unwind_sp): Delete.
6278         (moxie_unwind_pc): Delete.
6279         (moxie_dummy_id): Delete.
6280         (moxie_gdbarch_init): Don't register deleted functions with
6281         gdbarch.
6282
6283 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6284
6285         * mn10300-tdep.c (mn10300_dummy_id): Delete.
6286         (mn10300_unwind_pc): Delete.
6287         (mn10300_unwind_sp): Delete.
6288         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
6289         mn10300_unwind_sp.
6290         (mn10300_frame_unwind_init): Don't register deleted functions with
6291         gdbarch.
6292
6293 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6294
6295         * mep-tdep.c (mep_unwind_pc): Delete.
6296         (mep_unwind_sp): Delete.
6297         (mep_dummy_id): Delete.
6298         (mep_gdbarch_init): Don't register deleted functions with
6299         gdbarch.
6300
6301 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6302
6303         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
6304         (m68hc11_unwind_sp): Delete.
6305         (m68hc11_gdbarch_init): Don't register deleted functions with
6306         gdbarch.
6307
6308 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6309
6310         * m32r-tdep.c (m32r_unwind_sp): Delete.
6311         (m32r_unwind_pc): Delete.
6312         (m32r_dummy_id): Delete.
6313         (m32r_gdbarch_init): Don't register deleted functions with
6314         gdbarch.
6315
6316 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6317
6318         * m32c-tdep.c (m32c_unwind_pc): Delete.
6319         (m32c_unwind_sp): Delete.
6320         (m32c_dummy_id): Delete.
6321         (m32c_gdbarch_init): Don't register deleted functions with
6322         gdbarch.
6323
6324 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6325
6326         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
6327         (lm32_unwind_pc): Delete.
6328         (lm32_dummy_id): Delete.
6329         (lm32_gdbarch_init): Don't register deleted functions with
6330         gdbarch.
6331
6332 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6333
6334         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
6335         (iq2000_unwind_pc): Delete.
6336         (iq2000_dummy_id): Delete.
6337         (iq2000_gdbarch_init): Don't register deleted functions with
6338         gdbarch.
6339
6340 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6341
6342         * nds32-tdep.c (nds32_type_align): Delete.
6343         (nds32_push_dummy_call): Use type_align instead.
6344
6345 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6346
6347         * arm-tdep.c (arm_type_align): Only handle vector override case.
6348         (arm_push_dummy_call): Use type_align.
6349         (arm_gdbarch_init): Register arm_type_align gdbarch function.
6350
6351 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6352
6353         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
6354         case.
6355         (pass_on_stack): Use type_align.
6356         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
6357         function.
6358
6359 2019-04-23  Tom Tromey  <tromey@adacore.com>
6360
6361         * dwarf2read.c (line_header::file_name_at): Remove unused
6362         overload.
6363
6364 2019-04-23  Tom de Vries  <tdevries@suse.de>
6365
6366         PR gdb/24438
6367         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
6368         invocation.
6369
6370
6371 2019-03-27  Ali Tamur  <tamur@google.com>
6372
6373         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
6374         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
6375         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
6376         (dwarf_expr_context::get_addr_index): Likewise
6377         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
6378         (symbol_needs_eval_context::get_addr_index): Likewise
6379         (disassemble_dwarf_expression): Add DW_OP_addrx
6380         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
6381         (read_cutu_die_from_dwo): Update comment
6382         (skip_one_die): Add DW_FORM_addrx
6383         (read_attribute_value): Likewise
6384         (var_decode_location): Add DW_OP_addrx
6385         (dwarf2_const_value_attr): Add DW_FORM_addrx
6386         (dump_die_shallow): Likewise
6387         (dwarf2_fetch_constant_bytes): Likewise
6388         (decode_locdesc): Add DW_OP_addrx
6389         (skip_form_bytes): Add DW_FORM_addrx
6390
6391 2019-04-22  Ali Tamur  <tamur@google.com>
6392
6393         * MAINTAINERS (Write After Approval): Add self.
6394
6395 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
6396
6397         * solib-svr4.c (get_svr4_info): Add pspace parameter.
6398         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
6399         (open_symbol_file_object): Likewise.
6400         (svr4_default_sos): Add info parameter.
6401         (svr4_read_so_list): Likewise.
6402         (svr4_current_sos_direct): Adjust functions calls to pass down
6403         info.
6404         (svr4_current_sos_1): Add info parameter.
6405         (svr4_current_sos): Call get_svr4_info, pass info down to
6406         svr4_current_sos_1.
6407         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
6408         get_svr4_info.
6409         (svr4_in_dynsym_resolve_code): Pass current_program_space to
6410         get_svr4_info.
6411         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
6412         to get_svr4_info.
6413         (probes_table_remove_objfile_probes): Likewise.
6414         (register_solib_event_probe): Add info parameter.
6415         (solist_update_incremental): Pass info parameter down to
6416         svr4_read_so_list.
6417         (disable_probes_interface): Add info parameter.
6418         (svr4_handle_solib_event): Pass current_program_space to
6419         get_svr4_info.  Adjust disable_probes_interface cleanup.
6420         (svr4_create_probe_breakpoints): Add info parameter, pass it
6421         down to register_solib_event_probe.
6422         (svr4_create_solib_event_breakpoints): Add info parameter,
6423         pass it down to svr4_create_probe_breakpoints.
6424         (enable_break): Pass info down to
6425         svr4_create_solib_event_breakpoints.
6426         (svr4_solib_create_inferior_hook): Pass current_program_space to
6427         get_svr4_info.
6428         (svr4_clear_solib): Likewise.
6429
6430 2019-04-22  Pedro Alves  <palves@redhat.com>
6431
6432         * solib-svr4.c (svr4_free_objfile_observer): New.
6433         (probe_and_action::objfile): New field.
6434         (probes_table_htab_remove_objfile_probes)
6435         (probes_table_remove_objfile_probes): New functions.
6436         (register_solib_event_probe): Add 'objfile' parameter.  Store it
6437         in the new probe_and_action.  Don't store the probe in 'lookup'.
6438         (svr4_create_probe_breakpoints): Pass objfile to
6439         register_solib_event_probe.
6440         (_initialize_svr4_solib): Register a free_objfile observer.
6441
6442 2019-04-19  Tom Tromey  <tom@tromey.com>
6443
6444         * common/queue.h: Remove.
6445
6446 2019-04-19  Tom Tromey  <tom@tromey.com>
6447
6448         * event-loop.c: Don't include "common/queue.h".
6449
6450 2019-04-19  Tom Tromey  <tom@tromey.com>
6451
6452         * remote.c (remote_target): Use delete.
6453         * remote-notif.h: Include <list>, not "common/queue.h".
6454         (notif_client_p): Remove typedef.
6455         (remote_notif_state): Add constructor, destructor, initializer.
6456         <notif_queue>: Now a std::list.
6457         (remote_notif_state_xfree): Don't declare.
6458         * remote-notif.c (remote_notif_process, handle_notification)
6459         (remote_notif_state_allocate): Update.
6460         (~remote_notif_state): Rename from remote_notif_state_xfree.
6461
6462 2019-04-19  Tom Tromey  <tom@tromey.com>
6463
6464         * symfile.c (reread_symbols): Update.
6465         * objfiles.c (objfile_register_static_link)
6466         (objfile_lookup_static_link): Update
6467         (~objfile) Don't delete static_links.
6468         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
6469
6470 2019-04-19  Tom Tromey  <tom@tromey.com>
6471
6472         * type-stack.h (struct type_stack) <insert>: Constify string.
6473         * type-stack.c (type_stack::insert): Constify string.
6474         * gdbtypes.h (lookup_template_type): Update.
6475         (address_space_name_to_int): Update.
6476         * gdbtypes.c (address_space_name_to_int): Make space_identifier
6477         const.
6478         (lookup_template_type): Make name const.
6479         * c-exp.y: Update rules.
6480         (lex_one_token, classify_name, classify_inner_name)
6481         (c_print_token): Update.
6482         * p-exp.y: Update rules.
6483         (yylex): Update.
6484         * f-exp.y: Update rules.
6485         (yylex): Update.
6486         * d-exp.y: Update rules.
6487         (lex_one_token, classify_name, classify_inner_name): Update.
6488         * parse.c (write_dollar_variable, copy_name): Return std::string.
6489         * parser-defs.h (copy_name): Change return type.
6490         * m2-exp.y: Update rules.
6491         (yylex): Update.
6492         * go-exp.y (lex_one_token): Update.
6493         Update rules.
6494         (classify_unsafe_function, classify_packaged_name)
6495         (classify_name, yylex): Update.
6496
6497 2019-04-19  Sergei Trofimovich <siarheit@google.com>
6498
6499         * configure.ac: add --enable-source-highlight switch.
6500         * configure: Regenerate.
6501         * top.c (print_gdb_version): plumb --enable-source-highlight
6502         status to "show configuration".
6503
6504 2019-04-19  Tom Tromey  <tromey@adacore.com>
6505
6506         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
6507         Check ADA_TYPE_P.
6508         (empty_record, ada_template_to_fixed_record_type_1)
6509         (template_to_static_fixed_type)
6510         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
6511         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
6512         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
6513         macros.
6514
6515 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
6516
6517         PR symtab/24423:
6518         * source.c (print_source_lines_base): Advance "iter" when a
6519         control character is seen.
6520
6521 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6522
6523         * inferior.h (struct infcall_suspend_state_deleter):
6524         Catch exception in destructor to avoid crash.
6525
6526 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6527
6528         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
6529         close to the add_com "shell".
6530
6531 2019-04-18  Tom Tromey  <tromey@adacore.com>
6532
6533         * process-stratum-target.h (class process_stratum_target)
6534         <stratum>: Add "final".
6535
6536 2019-04-17  Tom Tromey  <tromey@adacore.com>
6537
6538         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
6539         against nullptr before use.
6540
6541 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
6542
6543         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
6544
6545 2019-04-17  Jim Wilson  <jimw@sifive.com>
6546             Andrew Burgess  <andrew.burgess@embecosm.com>
6547
6548         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
6549         code read might fail, assume 4-byte breakpoint in that case.
6550
6551 2019-04-15  Leszek Swirski  <leszeks@google.com>
6552
6553         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
6554         rather than a hand-rolled POD check when checking for forced MEMORY
6555         classification.
6556
6557 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
6558
6559         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
6560         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
6561         function.
6562         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
6563         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
6564         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
6565         declaration.
6566
6567 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
6568
6569         * aarch64-linux-nat.c
6570         (aarch64_linux_nat_target::thread_architecture): Add override.
6571         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
6572         each VQ.
6573
6574 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
6575
6576         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
6577
6578 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
6579
6580         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
6581         target types of size 96-bits, add some additional comments, and
6582         check that the builtin type we found was the correct size.
6583
6584 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
6585
6586         * utils.c (prompt_for_continue): Don't restore the styling at the
6587         end, as applied_style has the wrong value.  This fixes styling in
6588         long lists of file names that are interrupted by the "Continue?"
6589         prompt.
6590
6591 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
6592
6593         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
6594         * c-lang.c (c_language_defn): Likewise.
6595         (cplus_language_defn): Likewise.
6596         (asm_language_defn): Likewise.
6597         (minimal_language_defn): Likewise.
6598         * d-lang.c (d_language_defn): Likewise.
6599         * f-lang.c (f_language_defn): Likewise.
6600         * go-lang.c (go_language_defn): Likewise.
6601         * language.c (unknown_language_defn): Likewise.
6602         (auto_language_defn): Likewise.
6603         * language.h (struct language_defn): Remove la_magic field.
6604         (LANG_MAGIC): Delete.
6605         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
6606         * objc-lang.c (objc_language_defn): Likewise.
6607         * opencl-lang.c (opencl_language_defn): Likewise.
6608         * p-lang.c (pascal_language_defn): Likewise.
6609         * rust-lang.c (rust_language_defn): Likewise.
6610
6611 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6612
6613         * riscv-tdep.c (riscv_type_align): New function.
6614         (riscv_type_alignment): Delete.
6615         (riscv_arg_location): Use 'type_align'.
6616         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
6617
6618 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6619
6620         * gdbtypes.c (type_align): A struct with no non-static fields also
6621         has alignment of 1.
6622
6623 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6624
6625         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
6626         component to 0.
6627         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
6628         member.
6629         (riscv_struct_info::analyse): New implementation using new
6630         analyse_inner member function.
6631         (riscv_struct_info::field_offset): New member function.
6632         (riscv_struct_info::m_offsets): New member variable.
6633         (riscv_struct_info::analyse_inner): New private member function,
6634         takes the old implementation of riscv_struct_info::analyse but
6635         extended to track field offsets.
6636         (riscv_call_arg_struct): Update the struct folding special cases
6637         to handle cases where empty C++ structs, which are non-zero
6638         length, are found.
6639         (riscv_arg_location): Initialise the length of each location, a
6640         non-zero length now indicates the location is in use.
6641         (riscv_push_dummy_call): Allow for the first location having a
6642         non-zero offset when setting up arguments.
6643         (riscv_return_value): Likewise, but for return values.
6644
6645 2019-04-11  Tom Tromey  <tromey@adacore.com>
6646
6647         * utils.c (internal_vproblem): Make "msg" const.
6648
6649 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
6650
6651         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
6652         * trad-frame.c (trad_frame_reset_saved_regs): New function.
6653         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
6654         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
6655
6656 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
6657
6658         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
6659         function.
6660         (fill_gregset): Call amd64_linux_collect_native_gregset instead
6661         of amd64_collect_native_gregset.
6662         (amd64_linux_nat_target::store_registers): Likewise.
6663
6664 2019-04-10  Tom Tromey  <tom@tromey.com>
6665
6666         * symtab.c (lookup_global_symbol_from_objfile)
6667         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
6668         * objfiles.h (class separate_debug_iterator): New.
6669         (class separate_debug_range): New.
6670         (struct objfile) <separate_debug_objfiles>: New method.
6671         (objfile_separate_debug_iterate): Don't declare.
6672         * objfiles.c (separate_debug_iterator::operator++): Rename from
6673         objfile_separate_debug_iterate.
6674         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
6675         iterator.
6676         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
6677         iterator.
6678
6679 2019-04-10  Tom Tromey  <tom@tromey.com>
6680
6681         * symfile.c (reread_symbols): Remove old comment.
6682         * objfiles.c (free_all_objfiles): Fix a typo.
6683
6684 2019-04-10  Tom Tromey  <tom@tromey.com>
6685
6686         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
6687         * minsyms.c (lookup_minimal_symbol): Use foreach.
6688         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
6689         (lookup_minimal_symbol_solib_trampoline): Likewise.
6690         * symfile.c (reread_symbols): Use foreach.
6691
6692 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
6693             Tom Tromey  <tromey@adacore.com>
6694
6695         PR rust/24414:
6696         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
6697         (rust_lex_int_test): Change "value" to be LONGEST.
6698         (rust_lex_tests): Add test for long integer literal.
6699
6700 2019-04-09  Tom Tromey  <tromey@adacore.com>
6701
6702         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
6703         to bool.
6704         (extended_remote_target::attach): Update.
6705         (remote_target::remote_notice_new_inferior): Update.
6706         (remote_target::add_current_inferior_and_thread): Update.
6707         * inferior.c (exit_inferior_1): Use "false".
6708         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
6709
6710 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
6711
6712         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
6713         the "start" command.
6714
6715 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6716
6717         * python/py-inferior.c (infpy_thread_from_thread_handle):
6718         Adjust comments to reflect renaming of thread_from_thread_handle
6719         to thread_from_handle.  Adjust keywords.  Fix type error message.
6720         (inferior_object_methods): Add thread_from_handle.  Retain
6721         thread_from_thread_handle, but mark it as deprecated.
6722
6723 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6724
6725         * gdbthread.h (find_thread_by_handle): Revise declaration.
6726         * thread.c (find_thread_by_handle): Likewise.  Adjust
6727         implementation too.
6728         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
6729         support for buffer objects as handles.
6730
6731 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6732
6733         * python/py-infthread.c (thpy_thread_handle): New function.
6734         (thread_object_methods): Register thpy_thread_handle.
6735
6736 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6737
6738         * gdbthread.h (thread_to_thread_handle): Declare.
6739         * thread.c (gdbtypes.h): Include.
6740         (thread_to_thread_handle): New function.
6741
6742         * target.h (struct target_ops): Add thread_info_to_thread_handle.
6743         (target_thread_info_to_thread_handle): Declare.
6744         * target.c (target_thread_info_to_thread_handle): New function.
6745         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
6746         * target-delegates.c: Regenerate.
6747
6748         * linux-thread-db.c (class thread_db_target): Add method
6749         thread_info_to_thread_handle.
6750         (thread_db_target::thread_info_to_thread_handle): Define.
6751         * remote.c (class remote_target): Add new method
6752         thread_info_to_thread_handle.
6753         (remote_target::thread_info_to_thread_handle): Define.
6754
6755 2019-04-08  Pedro Alves  <palves@redhat.com>
6756
6757         * common/common-exceptions.c (throw_exception): Don't create
6758         named object to throw; throw directly.
6759         (throw_it): Likewise.  Don't initialize gdb_exception::message
6760         here, with new; pass FMT and AP to the ctor instead.
6761         * common/common-exceptions.h: Include <string>.
6762         (gdb_exception::gdb_exception(enum return_reason, enum errors,
6763         const char *, va_list)): New ctor.  Use std::make_shared.
6764         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
6765         errors)): Delete.
6766         (gdb_exception_error::gdb_exception_error(enum errors, const char
6767         *, va_list)): New.
6768         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
6769         Add assertion.
6770         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
6771         errors)): Delete.
6772         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
6773         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
6774         Add assertion.
6775
6776 2019-04-08  Tom Tromey  <tom@tromey.com>
6777
6778         * valops.c (value_rtti_indirect_type): Replace throw_exception
6779         with throw.
6780         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
6781         with throw.
6782         * thread.c (thr_try_catch_cmd): Replace throw_exception with
6783         throw.
6784         * target.c (target_translate_tls_address): Replace throw_exception
6785         with throw.
6786         * stack.c (frame_apply_command_count): Replace throw_exception
6787         with throw.
6788         * solib-spu.c (append_ocl_sos): Replace throw_exception with
6789         throw.
6790         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
6791         with throw.
6792         * rs6000-tdep.c (rs6000_frame_cache)
6793         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
6794         * remote.c: Replace throw_exception with throw.
6795         * record-full.c (record_full_message, record_full_wait_1)
6796         (record_full_restore): Replace throw_exception with throw.
6797         * record-btrace.c:
6798         (get_thread_current_frame_id, record_btrace_start_replaying)
6799         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
6800         (cmd_record_btrace_start): Replace throw_exception with throw.
6801         * parse.c (parse_exp_in_context_1): Replace throw_exception with
6802         throw.
6803         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
6804         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
6805         * linespec.c:
6806         (find_linespec_symbols): Replace throw_exception with throw.
6807         * infrun.c (displaced_step_prepare, resume): Replace
6808         throw_exception with throw.
6809         * infcmd.c (post_create_inferior): Replace throw_exception with
6810         throw.
6811         * inf-loop.c (inferior_event_handler): Replace throw_exception
6812         with throw.
6813         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
6814         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
6815         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
6816         (get_prev_frame_always, get_frame_pc_if_available)
6817         (get_frame_address_in_block_if_available, get_frame_language):
6818         Replace throw_exception with throw.
6819         * frame-unwind.c (frame_unwind_try_unwinder): Replace
6820         throw_exception with throw.
6821         * eval.c (fetch_subexp_value, evaluate_var_value)
6822         (evaluate_funcall, evaluate_subexp_standard): Replace
6823         throw_exception with throw.
6824         * dwarf2loc.c (call_site_find_chain)
6825         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
6826         Replace throw_exception with throw.
6827         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
6828         with throw.
6829         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
6830         throw.
6831         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
6832         * completer.c (complete_line_internal): Replace throw_exception
6833         with throw.
6834         * compile/compile-object-run.c (compile_object_run): Replace
6835         throw_exception with throw.
6836         * cli/cli-script.c (process_next_line): Replace throw_exception
6837         with throw.
6838         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
6839         (btrace_enable, btrace_maint_update_pt_packets): Replace
6840         throw_exception with throw.
6841         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
6842         throw_exception with throw.
6843         * break-catch-throw.c (re_set_exception_catchpoint): Replace
6844         throw_exception with throw.
6845         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
6846         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
6847         * aarch64-tdep.c (aarch64_make_prologue_cache)
6848         (aarch64_make_stub_cache): Replace throw_exception with throw.
6849
6850 2019-04-08  Tom Tromey  <tom@tromey.com>
6851
6852         * common/common-exceptions.c (throw_exception): Rename from
6853         throw_exception_cxx.  Remove old copy.  Make argument const.
6854         (throw_it): Create and throw exception objects directly.
6855         * common/common-exceptions.h (throw_exception): Make argument
6856         const.
6857         (struct gdb_exception_error): Add constructor.
6858         (struct gdb_exception_quit): Add constructor.
6859
6860 2019-04-08  Tom Tromey  <tom@tromey.com>
6861
6862         * common/common-exceptions.h (exception_rethrow): Don't declare.
6863         (TRY_SJLJ): Update comment.
6864         (TRY, CATCH, END_CATCH): Remove.
6865         * common/common-exceptions.c (exception_rethrow): Remove.
6866
6867 2019-04-08  Tom Tromey  <tom@tromey.com>
6868
6869         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
6870         Remove.
6871         (gdb_exception_error): Rename from
6872         gdb_exception_RETURN_MASK_ERROR.
6873         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
6874         (gdb_quit_bad_alloc): Update.
6875         * aarch64-tdep.c: Update.
6876         * ada-lang.c: Update.
6877         * ada-typeprint.c: Update.
6878         * ada-valprint.c: Update.
6879         * amd64-tdep.c: Update.
6880         * arch-utils.c: Update.
6881         * break-catch-throw.c: Update.
6882         * breakpoint.c: Update.
6883         * btrace.c: Update.
6884         * c-varobj.c: Update.
6885         * cli/cli-cmds.c: Update.
6886         * cli/cli-interp.c: Update.
6887         * cli/cli-script.c: Update.
6888         * common/common-exceptions.c: Update.
6889         * common/new-op.c: Update.
6890         * common/selftest.c: Update.
6891         * compile/compile-c-symbols.c: Update.
6892         * compile/compile-cplus-symbols.c: Update.
6893         * compile/compile-object-load.c: Update.
6894         * compile/compile-object-run.c: Update.
6895         * completer.c: Update.
6896         * corelow.c: Update.
6897         * cp-abi.c: Update.
6898         * cp-support.c: Update.
6899         * cp-valprint.c: Update.
6900         * darwin-nat.c: Update.
6901         * disasm-selftests.c: Update.
6902         * dtrace-probe.c: Update.
6903         * dwarf-index-cache.c: Update.
6904         * dwarf-index-write.c: Update.
6905         * dwarf2-frame-tailcall.c: Update.
6906         * dwarf2-frame.c: Update.
6907         * dwarf2loc.c: Update.
6908         * dwarf2read.c: Update.
6909         * eval.c: Update.
6910         * event-loop.c: Update.
6911         * event-top.c: Update.
6912         * exec.c: Update.
6913         * f-valprint.c: Update.
6914         * fbsd-tdep.c: Update.
6915         * frame-unwind.c: Update.
6916         * frame.c: Update.
6917         * gdbtypes.c: Update.
6918         * gnu-v3-abi.c: Update.
6919         * guile/guile-internal.h: Update.
6920         * guile/scm-block.c: Update.
6921         * guile/scm-breakpoint.c: Update.
6922         * guile/scm-cmd.c: Update.
6923         * guile/scm-disasm.c: Update.
6924         * guile/scm-frame.c: Update.
6925         * guile/scm-lazy-string.c: Update.
6926         * guile/scm-math.c: Update.
6927         * guile/scm-param.c: Update.
6928         * guile/scm-ports.c: Update.
6929         * guile/scm-pretty-print.c: Update.
6930         * guile/scm-symbol.c: Update.
6931         * guile/scm-symtab.c: Update.
6932         * guile/scm-type.c: Update.
6933         * guile/scm-value.c: Update.
6934         * i386-linux-tdep.c: Update.
6935         * i386-tdep.c: Update.
6936         * inf-loop.c: Update.
6937         * infcall.c: Update.
6938         * infcmd.c: Update.
6939         * infrun.c: Update.
6940         * jit.c: Update.
6941         * language.c: Update.
6942         * linespec.c: Update.
6943         * linux-fork.c: Update.
6944         * linux-nat.c: Update.
6945         * linux-tdep.c: Update.
6946         * linux-thread-db.c: Update.
6947         * main.c: Update.
6948         * mi/mi-cmd-break.c: Update.
6949         * mi/mi-cmd-stack.c: Update.
6950         * mi/mi-interp.c: Update.
6951         * mi/mi-main.c: Update.
6952         * objc-lang.c: Update.
6953         * p-valprint.c: Update.
6954         * parse.c: Update.
6955         * ppc-linux-tdep.c: Update.
6956         * printcmd.c: Update.
6957         * python/py-arch.c: Update.
6958         * python/py-breakpoint.c: Update.
6959         * python/py-cmd.c: Update.
6960         * python/py-finishbreakpoint.c: Update.
6961         * python/py-frame.c: Update.
6962         * python/py-framefilter.c: Update.
6963         * python/py-gdb-readline.c: Update.
6964         * python/py-inferior.c: Update.
6965         * python/py-infthread.c: Update.
6966         * python/py-lazy-string.c: Update.
6967         * python/py-linetable.c: Update.
6968         * python/py-objfile.c: Update.
6969         * python/py-param.c: Update.
6970         * python/py-prettyprint.c: Update.
6971         * python/py-progspace.c: Update.
6972         * python/py-record-btrace.c: Update.
6973         * python/py-record.c: Update.
6974         * python/py-symbol.c: Update.
6975         * python/py-type.c: Update.
6976         * python/py-unwind.c: Update.
6977         * python/py-utils.c: Update.
6978         * python/py-value.c: Update.
6979         * python/python.c: Update.
6980         * record-btrace.c: Update.
6981         * record-full.c: Update.
6982         * remote-fileio.c: Update.
6983         * remote.c: Update.
6984         * riscv-tdep.c: Update.
6985         * rs6000-aix-tdep.c: Update.
6986         * rs6000-tdep.c: Update.
6987         * rust-exp.y: Update.
6988         * rust-lang.c: Update.
6989         * s390-tdep.c: Update.
6990         * selftest-arch.c: Update.
6991         * solib-dsbt.c: Update.
6992         * solib-frv.c: Update.
6993         * solib-spu.c: Update.
6994         * solib-svr4.c: Update.
6995         * solib.c: Update.
6996         * sparc64-linux-tdep.c: Update.
6997         * stack.c: Update.
6998         * symfile-mem.c: Update.
6999         * symmisc.c: Update.
7000         * target.c: Update.
7001         * thread.c: Update.
7002         * top.c: Update.
7003         * tracefile-tfile.c: Update.
7004         * tui/tui.c: Update.
7005         * typeprint.c: Update.
7006         * unittests/cli-utils-selftests.c: Update.
7007         * unittests/parse-connection-spec-selftests.c: Update.
7008         * valops.c: Update.
7009         * valprint.c: Update.
7010         * value.c: Update.
7011         * varobj.c: Update.
7012         * windows-nat.c: Update.
7013         * x86-linux-nat.c: Update.
7014         * xml-support.c: Update.
7015
7016 2019-04-08  Tom Tromey  <tom@tromey.com>
7017
7018         * xml-support.c: Use C++ exception handling.
7019         * x86-linux-nat.c: Use C++ exception handling.
7020         * windows-nat.c: Use C++ exception handling.
7021         * varobj.c: Use C++ exception handling.
7022         * value.c: Use C++ exception handling.
7023         * valprint.c: Use C++ exception handling.
7024         * valops.c: Use C++ exception handling.
7025         * unittests/parse-connection-spec-selftests.c: Use C++ exception
7026         handling.
7027         * unittests/cli-utils-selftests.c: Use C++ exception handling.
7028         * typeprint.c: Use C++ exception handling.
7029         * tui/tui.c: Use C++ exception handling.
7030         * tracefile-tfile.c: Use C++ exception handling.
7031         * top.c: Use C++ exception handling.
7032         * thread.c: Use C++ exception handling.
7033         * target.c: Use C++ exception handling.
7034         * symmisc.c: Use C++ exception handling.
7035         * symfile-mem.c: Use C++ exception handling.
7036         * stack.c: Use C++ exception handling.
7037         * sparc64-linux-tdep.c: Use C++ exception handling.
7038         * solib.c: Use C++ exception handling.
7039         * solib-svr4.c: Use C++ exception handling.
7040         * solib-spu.c: Use C++ exception handling.
7041         * solib-frv.c: Use C++ exception handling.
7042         * solib-dsbt.c: Use C++ exception handling.
7043         * selftest-arch.c: Use C++ exception handling.
7044         * s390-tdep.c: Use C++ exception handling.
7045         * rust-lang.c: Use C++ exception handling.
7046         * rust-exp.y: Use C++ exception handling.
7047         * rs6000-tdep.c: Use C++ exception handling.
7048         * rs6000-aix-tdep.c: Use C++ exception handling.
7049         * riscv-tdep.c: Use C++ exception handling.
7050         * remote.c: Use C++ exception handling.
7051         * remote-fileio.c: Use C++ exception handling.
7052         * record-full.c: Use C++ exception handling.
7053         * record-btrace.c: Use C++ exception handling.
7054         * python/python.c: Use C++ exception handling.
7055         * python/py-value.c: Use C++ exception handling.
7056         * python/py-utils.c: Use C++ exception handling.
7057         * python/py-unwind.c: Use C++ exception handling.
7058         * python/py-type.c: Use C++ exception handling.
7059         * python/py-symbol.c: Use C++ exception handling.
7060         * python/py-record.c: Use C++ exception handling.
7061         * python/py-record-btrace.c: Use C++ exception handling.
7062         * python/py-progspace.c: Use C++ exception handling.
7063         * python/py-prettyprint.c: Use C++ exception handling.
7064         * python/py-param.c: Use C++ exception handling.
7065         * python/py-objfile.c: Use C++ exception handling.
7066         * python/py-linetable.c: Use C++ exception handling.
7067         * python/py-lazy-string.c: Use C++ exception handling.
7068         * python/py-infthread.c: Use C++ exception handling.
7069         * python/py-inferior.c: Use C++ exception handling.
7070         * python/py-gdb-readline.c: Use C++ exception handling.
7071         * python/py-framefilter.c: Use C++ exception handling.
7072         * python/py-frame.c: Use C++ exception handling.
7073         * python/py-finishbreakpoint.c: Use C++ exception handling.
7074         * python/py-cmd.c: Use C++ exception handling.
7075         * python/py-breakpoint.c: Use C++ exception handling.
7076         * python/py-arch.c: Use C++ exception handling.
7077         * printcmd.c: Use C++ exception handling.
7078         * ppc-linux-tdep.c: Use C++ exception handling.
7079         * parse.c: Use C++ exception handling.
7080         * p-valprint.c: Use C++ exception handling.
7081         * objc-lang.c: Use C++ exception handling.
7082         * mi/mi-main.c: Use C++ exception handling.
7083         * mi/mi-interp.c: Use C++ exception handling.
7084         * mi/mi-cmd-stack.c: Use C++ exception handling.
7085         * mi/mi-cmd-break.c: Use C++ exception handling.
7086         * main.c: Use C++ exception handling.
7087         * linux-thread-db.c: Use C++ exception handling.
7088         * linux-tdep.c: Use C++ exception handling.
7089         * linux-nat.c: Use C++ exception handling.
7090         * linux-fork.c: Use C++ exception handling.
7091         * linespec.c: Use C++ exception handling.
7092         * language.c: Use C++ exception handling.
7093         * jit.c: Use C++ exception handling.
7094         * infrun.c: Use C++ exception handling.
7095         * infcmd.c: Use C++ exception handling.
7096         * infcall.c: Use C++ exception handling.
7097         * inf-loop.c: Use C++ exception handling.
7098         * i386-tdep.c: Use C++ exception handling.
7099         * i386-linux-tdep.c: Use C++ exception handling.
7100         * guile/scm-value.c: Use C++ exception handling.
7101         * guile/scm-type.c: Use C++ exception handling.
7102         * guile/scm-symtab.c: Use C++ exception handling.
7103         * guile/scm-symbol.c: Use C++ exception handling.
7104         * guile/scm-pretty-print.c: Use C++ exception handling.
7105         * guile/scm-ports.c: Use C++ exception handling.
7106         * guile/scm-param.c: Use C++ exception handling.
7107         * guile/scm-math.c: Use C++ exception handling.
7108         * guile/scm-lazy-string.c: Use C++ exception handling.
7109         * guile/scm-frame.c: Use C++ exception handling.
7110         * guile/scm-disasm.c: Use C++ exception handling.
7111         * guile/scm-cmd.c: Use C++ exception handling.
7112         * guile/scm-breakpoint.c: Use C++ exception handling.
7113         * guile/scm-block.c: Use C++ exception handling.
7114         * guile/guile-internal.h: Use C++ exception handling.
7115         * gnu-v3-abi.c: Use C++ exception handling.
7116         * gdbtypes.c: Use C++ exception handling.
7117         * frame.c: Use C++ exception handling.
7118         * frame-unwind.c: Use C++ exception handling.
7119         * fbsd-tdep.c: Use C++ exception handling.
7120         * f-valprint.c: Use C++ exception handling.
7121         * exec.c: Use C++ exception handling.
7122         * event-top.c: Use C++ exception handling.
7123         * event-loop.c: Use C++ exception handling.
7124         * eval.c: Use C++ exception handling.
7125         * dwarf2read.c: Use C++ exception handling.
7126         * dwarf2loc.c: Use C++ exception handling.
7127         * dwarf2-frame.c: Use C++ exception handling.
7128         * dwarf2-frame-tailcall.c: Use C++ exception handling.
7129         * dwarf-index-write.c: Use C++ exception handling.
7130         * dwarf-index-cache.c: Use C++ exception handling.
7131         * dtrace-probe.c: Use C++ exception handling.
7132         * disasm-selftests.c: Use C++ exception handling.
7133         * darwin-nat.c: Use C++ exception handling.
7134         * cp-valprint.c: Use C++ exception handling.
7135         * cp-support.c: Use C++ exception handling.
7136         * cp-abi.c: Use C++ exception handling.
7137         * corelow.c: Use C++ exception handling.
7138         * completer.c: Use C++ exception handling.
7139         * compile/compile-object-run.c: Use C++ exception handling.
7140         * compile/compile-object-load.c: Use C++ exception handling.
7141         * compile/compile-cplus-symbols.c: Use C++ exception handling.
7142         * compile/compile-c-symbols.c: Use C++ exception handling.
7143         * common/selftest.c: Use C++ exception handling.
7144         * common/new-op.c: Use C++ exception handling.
7145         * cli/cli-script.c: Use C++ exception handling.
7146         * cli/cli-interp.c: Use C++ exception handling.
7147         * cli/cli-cmds.c: Use C++ exception handling.
7148         * c-varobj.c: Use C++ exception handling.
7149         * btrace.c: Use C++ exception handling.
7150         * breakpoint.c: Use C++ exception handling.
7151         * break-catch-throw.c: Use C++ exception handling.
7152         * arch-utils.c: Use C++ exception handling.
7153         * amd64-tdep.c: Use C++ exception handling.
7154         * ada-valprint.c: Use C++ exception handling.
7155         * ada-typeprint.c: Use C++ exception handling.
7156         * ada-lang.c: Use C++ exception handling.
7157         * aarch64-tdep.c: Use C++ exception handling.
7158
7159 2019-04-08  Tom Tromey  <tom@tromey.com>
7160
7161         * xml-support.c (gdb_xml_parser::parse): Update.
7162         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
7163         * value.c (show_convenience): Update.
7164         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
7165         (test_parse_flags_qcs): Update.
7166         * thread.c (thr_try_catch_cmd): Update.
7167         * target.c (target_translate_tls_address): Update.
7168         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
7169         (info_frame_command_core, frame_apply_command_count): Update.
7170         * rust-exp.y (rust_lex_exception_test): Update.
7171         * riscv-tdep.c (riscv_print_one_register_info): Update.
7172         * remote.c (remote_target::enable_btrace): Update.
7173         * record-btrace.c (record_btrace_enable_warn): Update.
7174         * python/py-utils.c (gdbpy_convert_exception): Update.
7175         * printcmd.c (do_one_display, print_variable_and_value): Update.
7176         * mi/mi-main.c (mi_print_exception): Update.
7177         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
7178         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
7179         * linux-nat.c (linux_nat_target::attach): Update.
7180         * linux-fork.c (class scoped_switch_fork_info): Update.
7181         * infrun.c (displaced_step_prepare): Update.
7182         * infcall.c (call_function_by_hand_dummy): Update.
7183         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
7184         * gnu-v3-abi.c (print_one_vtable): Update.
7185         * frame.c (get_prev_frame_always): Update.
7186         * f-valprint.c (info_common_command_for_block): Update.
7187         * exec.c (try_open_exec_file): Update.
7188         * exceptions.c (print_exception, exception_print)
7189         (exception_fprintf, exception_print_same): Update.
7190         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
7191         * dwarf-index-cache.c (index_cache::store)
7192         (index_cache::lookup_gdb_index): Update.
7193         * darwin-nat.c (maybe_cache_shell): Update.
7194         * cp-valprint.c (cp_print_value_fields): Update.
7195         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
7196         (gcc_cplus_symbol_address): Update.
7197         * compile/compile-c-symbols.c (gcc_convert_symbol)
7198         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
7199         * common/selftest.c: Update.
7200         * common/common-exceptions.h (struct gdb_exception) <message>: Now
7201         a std::string.
7202         (exception_try_scope_entry, exception_try_scope_exit): Don't
7203         declare.
7204         (struct exception_try_scope): Remove.
7205         (TRY): Don't use exception_try_scope.
7206         (struct gdb_exception): Add constructor, operator=.
7207         <what>: New method.
7208         (struct gdb_exception_RETURN_MASK_ALL)
7209         (struct gdb_exception_RETURN_MASK_ERROR)
7210         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
7211         (struct gdb_quit_bad_alloc): Update.
7212         * common/common-exceptions.c (exception_none): Change
7213         initializer.
7214         (struct catcher) <state, exception>: Initialize inline.
7215         <prev>: Remove member.
7216         (current_catcher): Remove.
7217         (catchers): New global.
7218         (exceptions_state_mc_init): Simplify.
7219         (catcher_pop): Remove.
7220         (exceptions_state_mc, exceptions_state_mc_catch): Update.
7221         (try_scope_depth, exception_try_scope_entry)
7222         (exception_try_scope_exit): Remove.
7223         (throw_exception_sjlj): Update.
7224         (exception_messages, exception_messages_size): Remove.
7225         (throw_it): Simplify.
7226         (gdb_exception_sliced_copy): Remove.
7227         (throw_exception_cxx): Update.
7228         * cli/cli-script.c (script_from_file): Update.
7229         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
7230         Update.
7231         * ada-valprint.c (ada_val_print): Update.
7232         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
7233         (create_excep_cond_exprs): Update.
7234
7235 2019-04-08  Tom Tromey  <tom@tromey.com>
7236
7237         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
7238         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
7239         (TRY, CATCH, END_CATCH): Remove some definitions.
7240         * common/common-exceptions.c: Don't use GDB_XCPT.
7241         (catcher_list_size): Remove.
7242         (throw_exception, throw_it): Simplify.
7243
7244 2019-04-05  Tom Tromey  <tom@tromey.com>
7245
7246         Revert the header-sorting patch.
7247         * ft32-tdep.c: Revert.
7248         * frv-tdep.c: Revert.
7249         * frv-linux-tdep.c: Revert.
7250         * frame.c: Revert.
7251         * frame-unwind.c: Revert.
7252         * frame-base.c: Revert.
7253         * fork-child.c: Revert.
7254         * findvar.c: Revert.
7255         * findcmd.c: Revert.
7256         * filesystem.c: Revert.
7257         * filename-seen-cache.h: Revert.
7258         * filename-seen-cache.c: Revert.
7259         * fbsd-tdep.c: Revert.
7260         * fbsd-nat.h: Revert.
7261         * fbsd-nat.c: Revert.
7262         * f-valprint.c: Revert.
7263         * f-typeprint.c: Revert.
7264         * f-lang.c: Revert.
7265         * extension.h: Revert.
7266         * extension.c: Revert.
7267         * extension-priv.h: Revert.
7268         * expprint.c: Revert.
7269         * exec.h: Revert.
7270         * exec.c: Revert.
7271         * exceptions.c: Revert.
7272         * event-top.c: Revert.
7273         * event-loop.c: Revert.
7274         * eval.c: Revert.
7275         * elfread.c: Revert.
7276         * dwarf2read.h: Revert.
7277         * dwarf2read.c: Revert.
7278         * dwarf2loc.c: Revert.
7279         * dwarf2expr.h: Revert.
7280         * dwarf2expr.c: Revert.
7281         * dwarf2-frame.c: Revert.
7282         * dwarf2-frame-tailcall.c: Revert.
7283         * dwarf-index-write.h: Revert.
7284         * dwarf-index-write.c: Revert.
7285         * dwarf-index-common.c: Revert.
7286         * dwarf-index-cache.h: Revert.
7287         * dwarf-index-cache.c: Revert.
7288         * dummy-frame.c: Revert.
7289         * dtrace-probe.c: Revert.
7290         * disasm.h: Revert.
7291         * disasm.c: Revert.
7292         * disasm-selftests.c: Revert.
7293         * dictionary.c: Revert.
7294         * dicos-tdep.c: Revert.
7295         * demangle.c: Revert.
7296         * dcache.h: Revert.
7297         * dcache.c: Revert.
7298         * darwin-nat.h: Revert.
7299         * darwin-nat.c: Revert.
7300         * darwin-nat-info.c: Revert.
7301         * d-valprint.c: Revert.
7302         * d-namespace.c: Revert.
7303         * d-lang.c: Revert.
7304         * ctf.c: Revert.
7305         * csky-tdep.c: Revert.
7306         * csky-linux-tdep.c: Revert.
7307         * cris-tdep.c: Revert.
7308         * cris-linux-tdep.c: Revert.
7309         * cp-valprint.c: Revert.
7310         * cp-support.c: Revert.
7311         * cp-namespace.c: Revert.
7312         * cp-abi.c: Revert.
7313         * corelow.c: Revert.
7314         * corefile.c: Revert.
7315         * continuations.c: Revert.
7316         * completer.h: Revert.
7317         * completer.c: Revert.
7318         * complaints.c: Revert.
7319         * coffread.c: Revert.
7320         * coff-pe-read.c: Revert.
7321         * cli-out.h: Revert.
7322         * cli-out.c: Revert.
7323         * charset.c: Revert.
7324         * c-varobj.c: Revert.
7325         * c-valprint.c: Revert.
7326         * c-typeprint.c: Revert.
7327         * c-lang.c: Revert.
7328         * buildsym.c: Revert.
7329         * buildsym-legacy.c: Revert.
7330         * build-id.h: Revert.
7331         * build-id.c: Revert.
7332         * btrace.c: Revert.
7333         * bsd-uthread.c: Revert.
7334         * breakpoint.h: Revert.
7335         * breakpoint.c: Revert.
7336         * break-catch-throw.c: Revert.
7337         * break-catch-syscall.c: Revert.
7338         * break-catch-sig.c: Revert.
7339         * blockframe.c: Revert.
7340         * block.c: Revert.
7341         * bfin-tdep.c: Revert.
7342         * bfin-linux-tdep.c: Revert.
7343         * bfd-target.c: Revert.
7344         * bcache.c: Revert.
7345         * ax-general.c: Revert.
7346         * ax-gdb.h: Revert.
7347         * ax-gdb.c: Revert.
7348         * avr-tdep.c: Revert.
7349         * auxv.c: Revert.
7350         * auto-load.c: Revert.
7351         * arm-wince-tdep.c: Revert.
7352         * arm-tdep.c: Revert.
7353         * arm-symbian-tdep.c: Revert.
7354         * arm-pikeos-tdep.c: Revert.
7355         * arm-obsd-tdep.c: Revert.
7356         * arm-nbsd-tdep.c: Revert.
7357         * arm-nbsd-nat.c: Revert.
7358         * arm-linux-tdep.c: Revert.
7359         * arm-linux-nat.c: Revert.
7360         * arm-fbsd-tdep.c: Revert.
7361         * arm-fbsd-nat.c: Revert.
7362         * arm-bsd-tdep.c: Revert.
7363         * arch-utils.c: Revert.
7364         * arc-tdep.c: Revert.
7365         * arc-newlib-tdep.c: Revert.
7366         * annotate.h: Revert.
7367         * annotate.c: Revert.
7368         * amd64-windows-tdep.c: Revert.
7369         * amd64-windows-nat.c: Revert.
7370         * amd64-tdep.c: Revert.
7371         * amd64-sol2-tdep.c: Revert.
7372         * amd64-obsd-tdep.c: Revert.
7373         * amd64-obsd-nat.c: Revert.
7374         * amd64-nbsd-tdep.c: Revert.
7375         * amd64-nbsd-nat.c: Revert.
7376         * amd64-nat.c: Revert.
7377         * amd64-linux-tdep.c: Revert.
7378         * amd64-linux-nat.c: Revert.
7379         * amd64-fbsd-tdep.c: Revert.
7380         * amd64-fbsd-nat.c: Revert.
7381         * amd64-dicos-tdep.c: Revert.
7382         * amd64-darwin-tdep.c: Revert.
7383         * amd64-bsd-nat.c: Revert.
7384         * alpha-tdep.c: Revert.
7385         * alpha-obsd-tdep.c: Revert.
7386         * alpha-nbsd-tdep.c: Revert.
7387         * alpha-mdebug-tdep.c: Revert.
7388         * alpha-linux-tdep.c: Revert.
7389         * alpha-linux-nat.c: Revert.
7390         * alpha-bsd-tdep.c: Revert.
7391         * alpha-bsd-nat.c: Revert.
7392         * aix-thread.c: Revert.
7393         * agent.c: Revert.
7394         * addrmap.c: Revert.
7395         * ada-varobj.c: Revert.
7396         * ada-valprint.c: Revert.
7397         * ada-typeprint.c: Revert.
7398         * ada-tasks.c: Revert.
7399         * ada-lang.c: Revert.
7400         * aarch64-tdep.c: Revert.
7401         * aarch64-ravenscar-thread.c: Revert.
7402         * aarch64-newlib-tdep.c: Revert.
7403         * aarch64-linux-tdep.c: Revert.
7404         * aarch64-linux-nat.c: Revert.
7405         * aarch64-fbsd-tdep.c: Revert.
7406         * aarch64-fbsd-nat.c: Revert.
7407         * aarch32-linux-nat.c: Revert.
7408
7409 2019-04-05  Tom Tromey  <tom@tromey.com>
7410
7411         * ft32-tdep.c: Sort headers.
7412         * frv-tdep.c: Sort headers.
7413         * frv-linux-tdep.c: Sort headers.
7414         * frame.c: Sort headers.
7415         * frame-unwind.c: Sort headers.
7416         * frame-base.c: Sort headers.
7417         * fork-child.c: Sort headers.
7418         * findvar.c: Sort headers.
7419         * findcmd.c: Sort headers.
7420         * filesystem.c: Sort headers.
7421         * filename-seen-cache.h: Sort headers.
7422         * filename-seen-cache.c: Sort headers.
7423         * fbsd-tdep.c: Sort headers.
7424         * fbsd-nat.h: Sort headers.
7425         * fbsd-nat.c: Sort headers.
7426         * f-valprint.c: Sort headers.
7427         * f-typeprint.c: Sort headers.
7428         * f-lang.c: Sort headers.
7429         * extension.h: Sort headers.
7430         * extension.c: Sort headers.
7431         * extension-priv.h: Sort headers.
7432         * expprint.c: Sort headers.
7433         * exec.h: Sort headers.
7434         * exec.c: Sort headers.
7435         * exceptions.c: Sort headers.
7436         * event-top.c: Sort headers.
7437         * event-loop.c: Sort headers.
7438         * eval.c: Sort headers.
7439         * elfread.c: Sort headers.
7440         * dwarf2read.h: Sort headers.
7441         * dwarf2read.c: Sort headers.
7442         * dwarf2loc.c: Sort headers.
7443         * dwarf2expr.h: Sort headers.
7444         * dwarf2expr.c: Sort headers.
7445         * dwarf2-frame.c: Sort headers.
7446         * dwarf2-frame-tailcall.c: Sort headers.
7447         * dwarf-index-write.h: Sort headers.
7448         * dwarf-index-write.c: Sort headers.
7449         * dwarf-index-common.c: Sort headers.
7450         * dwarf-index-cache.h: Sort headers.
7451         * dwarf-index-cache.c: Sort headers.
7452         * dummy-frame.c: Sort headers.
7453         * dtrace-probe.c: Sort headers.
7454         * disasm.h: Sort headers.
7455         * disasm.c: Sort headers.
7456         * disasm-selftests.c: Sort headers.
7457         * dictionary.c: Sort headers.
7458         * dicos-tdep.c: Sort headers.
7459         * demangle.c: Sort headers.
7460         * dcache.h: Sort headers.
7461         * dcache.c: Sort headers.
7462         * darwin-nat.h: Sort headers.
7463         * darwin-nat.c: Sort headers.
7464         * darwin-nat-info.c: Sort headers.
7465         * d-valprint.c: Sort headers.
7466         * d-namespace.c: Sort headers.
7467         * d-lang.c: Sort headers.
7468         * ctf.c: Sort headers.
7469         * csky-tdep.c: Sort headers.
7470         * csky-linux-tdep.c: Sort headers.
7471         * cris-tdep.c: Sort headers.
7472         * cris-linux-tdep.c: Sort headers.
7473         * cp-valprint.c: Sort headers.
7474         * cp-support.c: Sort headers.
7475         * cp-namespace.c: Sort headers.
7476         * cp-abi.c: Sort headers.
7477         * corelow.c: Sort headers.
7478         * corefile.c: Sort headers.
7479         * continuations.c: Sort headers.
7480         * completer.h: Sort headers.
7481         * completer.c: Sort headers.
7482         * complaints.c: Sort headers.
7483         * coffread.c: Sort headers.
7484         * coff-pe-read.c: Sort headers.
7485         * cli-out.h: Sort headers.
7486         * cli-out.c: Sort headers.
7487         * charset.c: Sort headers.
7488         * c-varobj.c: Sort headers.
7489         * c-valprint.c: Sort headers.
7490         * c-typeprint.c: Sort headers.
7491         * c-lang.c: Sort headers.
7492         * buildsym.c: Sort headers.
7493         * buildsym-legacy.c: Sort headers.
7494         * build-id.h: Sort headers.
7495         * build-id.c: Sort headers.
7496         * btrace.c: Sort headers.
7497         * bsd-uthread.c: Sort headers.
7498         * breakpoint.h: Sort headers.
7499         * breakpoint.c: Sort headers.
7500         * break-catch-throw.c: Sort headers.
7501         * break-catch-syscall.c: Sort headers.
7502         * break-catch-sig.c: Sort headers.
7503         * blockframe.c: Sort headers.
7504         * block.c: Sort headers.
7505         * bfin-tdep.c: Sort headers.
7506         * bfin-linux-tdep.c: Sort headers.
7507         * bfd-target.c: Sort headers.
7508         * bcache.c: Sort headers.
7509         * ax-general.c: Sort headers.
7510         * ax-gdb.h: Sort headers.
7511         * ax-gdb.c: Sort headers.
7512         * avr-tdep.c: Sort headers.
7513         * auxv.c: Sort headers.
7514         * auto-load.c: Sort headers.
7515         * arm-wince-tdep.c: Sort headers.
7516         * arm-tdep.c: Sort headers.
7517         * arm-symbian-tdep.c: Sort headers.
7518         * arm-pikeos-tdep.c: Sort headers.
7519         * arm-obsd-tdep.c: Sort headers.
7520         * arm-nbsd-tdep.c: Sort headers.
7521         * arm-nbsd-nat.c: Sort headers.
7522         * arm-linux-tdep.c: Sort headers.
7523         * arm-linux-nat.c: Sort headers.
7524         * arm-fbsd-tdep.c: Sort headers.
7525         * arm-fbsd-nat.c: Sort headers.
7526         * arm-bsd-tdep.c: Sort headers.
7527         * arch-utils.c: Sort headers.
7528         * arc-tdep.c: Sort headers.
7529         * arc-newlib-tdep.c: Sort headers.
7530         * annotate.h: Sort headers.
7531         * annotate.c: Sort headers.
7532         * amd64-windows-tdep.c: Sort headers.
7533         * amd64-windows-nat.c: Sort headers.
7534         * amd64-tdep.c: Sort headers.
7535         * amd64-sol2-tdep.c: Sort headers.
7536         * amd64-obsd-tdep.c: Sort headers.
7537         * amd64-obsd-nat.c: Sort headers.
7538         * amd64-nbsd-tdep.c: Sort headers.
7539         * amd64-nbsd-nat.c: Sort headers.
7540         * amd64-nat.c: Sort headers.
7541         * amd64-linux-tdep.c: Sort headers.
7542         * amd64-linux-nat.c: Sort headers.
7543         * amd64-fbsd-tdep.c: Sort headers.
7544         * amd64-fbsd-nat.c: Sort headers.
7545         * amd64-dicos-tdep.c: Sort headers.
7546         * amd64-darwin-tdep.c: Sort headers.
7547         * amd64-bsd-nat.c: Sort headers.
7548         * alpha-tdep.c: Sort headers.
7549         * alpha-obsd-tdep.c: Sort headers.
7550         * alpha-nbsd-tdep.c: Sort headers.
7551         * alpha-mdebug-tdep.c: Sort headers.
7552         * alpha-linux-tdep.c: Sort headers.
7553         * alpha-linux-nat.c: Sort headers.
7554         * alpha-bsd-tdep.c: Sort headers.
7555         * alpha-bsd-nat.c: Sort headers.
7556         * aix-thread.c: Sort headers.
7557         * agent.c: Sort headers.
7558         * addrmap.c: Sort headers.
7559         * ada-varobj.c: Sort headers.
7560         * ada-valprint.c: Sort headers.
7561         * ada-typeprint.c: Sort headers.
7562         * ada-tasks.c: Sort headers.
7563         * ada-lang.c: Sort headers.
7564         * aarch64-tdep.c: Sort headers.
7565         * aarch64-ravenscar-thread.c: Sort headers.
7566         * aarch64-newlib-tdep.c: Sort headers.
7567         * aarch64-linux-tdep.c: Sort headers.
7568         * aarch64-linux-nat.c: Sort headers.
7569         * aarch64-fbsd-tdep.c: Sort headers.
7570         * aarch64-fbsd-nat.c: Sort headers.
7571         * aarch32-linux-nat.c: Sort headers.
7572
7573 2019-04-04  Tom Tromey  <tom@tromey.com>
7574
7575         * varobj.c (varobj_create): Update.
7576         * rust-exp.y (struct rust_parser) <update_innermost_block,
7577         lookup_symbol>: New methods.
7578         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
7579         Rename.
7580         (rust_parser::rust_lookup_type)
7581         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
7582         * printcmd.c (display_command, do_one_display): Update.
7583         * parser-defs.h (struct parser_state) <parser_state>: Add
7584         "tracker" parameter.
7585         (block_tracker): New member.
7586         (class innermost_block_tracker) <innermost_block_tracker>: Add
7587         "types" parameter.
7588         <reset>: Remove method.
7589         (innermost_block): Don't declare.
7590         (null_post_parser): Update.
7591         * parse.c (innermost_block): Remove global.
7592         (write_dollar_variable): Update.
7593         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
7594         Remove "tracker_types" parameter.
7595         (parse_expression): Add "tracker" parameter.
7596         (parse_expression_for_completion): Update.
7597         (null_post_parser): Add "tracker" parameter.
7598         * p-exp.y: Update rules.
7599         * m2-exp.y: Update rules.
7600         * language.h (struct language_defn) <la_post_parser>: Add
7601         "tracker" parameter.
7602         * go-exp.y: Update rules.
7603         * f-exp.y: Update rules.
7604         * expression.h (parse_expression, parse_exp_1): Add "tracker"
7605         parameter.
7606         * d-exp.y: Update rules.
7607         * c-exp.y: Update rules.
7608         * breakpoint.c (set_breakpoint_condition): Create an
7609         innermost_block_tracker.
7610         (watch_command_1): Likewise.
7611         * ada-lang.c (resolve): Add "tracker" parameter.
7612         (resolve_subexp): Likewise.
7613         * ada-exp.y (write_var_from_sym): Update.
7614
7615 2019-04-04  Tom Tromey  <tom@tromey.com>
7616
7617         * type-stack.h: New file.
7618         * type-stack.c: New file.
7619         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
7620         type-stack.h.
7621         (insert_into_type_stack, insert_type, push_type, push_type_int)
7622         (insert_type_address_space, pop_type, pop_type_int)
7623         (pop_typelist, pop_type_stack, append_type_stack)
7624         (push_type_stack, get_type_stack, push_typelist)
7625         (follow_type_instance_flags, follow_types): Don't declare.
7626         * parse.c (type_stack): Remove global.
7627         (parse_exp_in_context): Update.
7628         (insert_into_type_stack, insert_type, push_type, push_type_int)
7629         (insert_type_address_space, pop_type, pop_type_int)
7630         (pop_typelist, pop_type_stack, append_type_stack)
7631         (push_type_stack, get_type_stack, push_typelist)
7632         (follow_type_instance_flags, follow_types): Remove (moved to
7633         type-stack.c).
7634         * f-exp.y (type_stack): New global.
7635         Update rules.
7636         (push_kind_type, f_parse): Update.
7637         * d-exp.y (type_stack): New global.
7638         Update rules.
7639         (d_parse): Update.
7640         * c-exp.y (struct c_parse_state) <type_stack>: New member.
7641         Update rules.
7642         * Makefile.in (COMMON_SFILES): Add type-stack.c.
7643         (HFILES_NO_SRCDIR): Add type-stack.h.
7644
7645 2019-04-04  Tom Tromey  <tom@tromey.com>
7646
7647         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
7648         (rust_parser::convert_ast_to_expression, rust_parse)
7649         (rust_lex_test_completion, rust_lex_tests): Update.
7650         * parser-defs.h (struct expr_completion_state): New.
7651         (struct parser_state) <parser_state>: Add completion parameter.
7652         <mark_struct_expression, mark_completion_tag>: New methods.
7653         <parse_completion, m_completion_state>: New members.
7654         (prefixify_expression, null_post_parser): Update.
7655         (mark_struct_expression, mark_completion_tag): Don't declare.
7656         * parse.c (parse_completion, expout_last_struct)
7657         (expout_tag_completion_type, expout_completion_name): Remove
7658         globals.
7659         (parser_state::mark_struct_expression)
7660         (parser_state::mark_completion_tag): Now methods.
7661         (prefixify_expression): Add last_struct parameter.
7662         (prefixify_subexp): Likewise.
7663         (parse_exp_1): Update.
7664         (parse_exp_in_context): Add cstate parameter.  Update.
7665         (parse_expression_for_completion): Create an
7666         expr_completion_state.
7667         (null_post_parser): Add "completion" parameter.
7668         * p-exp.y: Update rules.
7669         (yylex): Update.
7670         * language.h (struct language_defn) <la_post_parser>: Add
7671         "completing" parameter.
7672         * go-exp.y: Update rules.
7673         (lex_one_token): Update.
7674         * expression.h (parse_completion): Don't declare.
7675         * d-exp.y: Update rules.
7676         (lex_one_token): Update rules.
7677         * c-exp.y: Update rules.
7678         (lex_one_token): Update.
7679         * ada-lang.c (resolve): Add "parse_completion" parameter.
7680         (resolve_subexp): Likewise.
7681         (ada_resolve_function): Likewise.
7682
7683 2019-04-04  Tom Tromey  <tom@tromey.com>
7684
7685         * parser-defs.h (struct parser_state) <start_arglist,
7686         end_arglist>: New methods.
7687         <arglist_len, m_funcall_chain>: New members.
7688         (arglist_len, start_arglist, end_arglist): Don't declare.
7689         * parse.c (arglist_len, funcall_chain): Remove global.
7690         (start_arglist, end_arglist): Remove functions.
7691         (parse_exp_in_context): Update.
7692         * p-exp.y: Update rules.
7693         * m2-exp.y: Update rules.
7694         * go-exp.y: Update rules.
7695         * f-exp.y: Update rules.
7696         * d-exp.y: Update rules.
7697         * c-exp.y: Update rules.
7698
7699 2019-04-04  Tom Tromey  <tom@tromey.com>
7700
7701         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
7702         lex_operator, push_back>: New methods.
7703         Update all rules.
7704         (rust_parser::lex_hex, lex_escape): Rename and update.
7705         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
7706         (rust_parser::lex_operator): Rename and update.
7707         (rust_parser::lex_number, rustyylex, rustyyerror)
7708         (rust_lex_test_init, rust_lex_test_sequence)
7709         (rust_lex_test_push_back, rust_lex_tests): Update.
7710         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
7711         parameter.
7712         <lexptr, prev_lexptr>: New members.
7713         (lexptr, prev_lexptr): Don't declare.
7714         * parse.c (lexptr, prev_lexptr): Remove globals.
7715         (parse_exp_in_context): Update.
7716         * p-exp.y (yylex, yyerror): Update.
7717         * m2-exp.y (parse_number, yylex, yyerror): Update.
7718         * go-exp.y (lex_one_token, yyerror): Update.
7719         * f-exp.y (match_string_literal, yylex, yyerror): Update.
7720         * d-exp.y (lex_one_token, yyerror): Update.
7721         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
7722         (lex_one_token, yyerror): Update.
7723         * ada-lex.l (YY_INPUT): Update.
7724         (rewind_to_char): Update.
7725         * ada-exp.y (yyerror): Update.
7726
7727 2019-04-04  Tom Tromey  <tom@tromey.com>
7728
7729         * rust-exp.y (rustyylex, rust_lex_tests): Update.
7730         * parser-defs.h (struct parser_state) <parser_state>: Add new
7731         parameter.
7732         <comma_terminates>: New member.
7733         (comma_terminates): Don't declare global.
7734         * parse.c (comma_terminates): Remove global.
7735         (parse_exp_in_context): Update.
7736         * p-exp.y (yylex): Update.
7737         * m2-exp.y (yylex): Update.
7738         * go-exp.y (lex_one_token): Update.
7739         * f-exp.y (yylex): Update.
7740         * d-exp.y (lex_one_token): Update.
7741         * c-exp.y (lex_one_token): Update.
7742         * ada-lex.l: Update.
7743
7744 2019-04-04  Tom Tromey  <tom@tromey.com>
7745
7746         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
7747         (rustyylex, rust_lex_test_init, rust_lex_test_one)
7748         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
7749         * parser-defs.h (paren_depth): Don't declare.
7750         * parse.c (paren_depth): Remove global.
7751         (parse_exp_in_context): Update.
7752         * p-exp.y (paren_depth): New global.
7753         (pascal_parse): Initialize it.
7754         * m2-exp.y (paren_depth): New global.
7755         (m2_parse): Initialize it.
7756         * go-exp.y (paren_depth): New global.
7757         (go_parse): Initialize it.
7758         * f-exp.y (paren_depth): New global.
7759         (f_parse): Initialize it.
7760         * d-exp.y (paren_depth): New global.
7761         (d_parse): Initialize it.
7762         * c-exp.y (paren_depth): New global.
7763         (c_parse): Initialize it.
7764         * ada-lex.l (paren_depth): New global.
7765         (lexer_init): Initialize it.
7766
7767 2019-04-04  Tom Tromey  <tom@tromey.com>
7768
7769         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
7770         (rust_parser::convert_ast_to_type)
7771         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
7772         * parser-defs.h (struct parser_state) <parser_state>: Add
7773         parameters.  Initialize new members.
7774         <expression_context_block, expression_context_pc>: New members.
7775         * parse.c (expression_context_block, expression_context_pc):
7776         Remove globals.
7777         (parse_exp_in_context): Update.
7778         * p-exp.y: Update all rules.
7779         (yylex): Update.
7780         * m2-exp.y: Update all rules.
7781         (yylex): Update.
7782         * go-exp.y (yylex): Update.
7783         * f-exp.y (yylex): Update.
7784         * d-exp.y: Update all rules.
7785         (yylex): Update.
7786         * c-exp.y: Update all rules.
7787         (lex_one_token, classify_name, yylex, c_parse): Update.
7788         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
7789
7790 2019-04-04  Tom Tromey  <tom@tromey.com>
7791
7792         * gdbarch.h, gdbarch.c: Rebuild.
7793         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
7794         * stap-probe.h:
7795         (struct stap_parse_info): Replace "parser_state" with
7796         "expr_builder".
7797         * parser-defs.h (struct expr_builder): Rename from "parser_state".
7798         (parser_state): New class.
7799         * parse.c (expr_builder): Rename.
7800         (expr_builder::release): Rename.
7801         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
7802         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
7803         (write_exp_elt_longcst, write_exp_elt_floatcst)
7804         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
7805         (write_exp_string_vector, write_exp_bitstring)
7806         (write_exp_msymbol, mark_struct_expression)
7807         (write_dollar_variable)
7808         (insert_type_address_space, increase_expout_size): Replace
7809         "parser_state" with "expr_builder".
7810         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
7811         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
7812         "parser_state" with "expr_builder".
7813
7814 2019-04-04  Tom Tromey  <tom@tromey.com>
7815
7816         * rust-exp.y: Replace "parse_language" with method call.
7817         * p-exp.y:
7818         (yylex): Replace "parse_language" with method call.
7819         * m2-exp.y:
7820         (yylex): Replace "parse_language" with method call.
7821         * go-exp.y (classify_name): Replace "parse_language" with method
7822         call.
7823         * f-exp.y (yylex): Replace "parse_language" with method call.
7824         * d-exp.y (lex_one_token): Replace "parse_language" with method
7825         call.
7826         * c-exp.y:
7827         (lex_one_token, classify_name, yylex): Replace "parse_language"
7828         with method call.
7829         * ada-exp.y (find_primitive_type, type_char)
7830         (type_system_address): Replace "parse_language" with method call.
7831
7832 2019-04-04  Tom Tromey  <tom@tromey.com>
7833
7834         * rust-exp.y: Replace "parse_gdbarch" with method call.
7835         * parse.c (write_dollar_variable, insert_type_address_space):
7836         Replace "parse_gdbarch" with method call.
7837         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
7838         call.
7839         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
7840         call.
7841         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
7842         "parse_gdbarch" with method call.
7843         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
7844         with method call.
7845         * f-exp.y (parse_type, parse_f_type, yylex): Replace
7846         "parse_gdbarch" with method call.
7847         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
7848         "parse_gdbarch" with method call.
7849         * c-exp.y (parse_type, parse_number, classify_name): Replace
7850         "parse_gdbarch" with method call.
7851         * ada-lex.l: Replace "parse_gdbarch" with method call.
7852         * ada-exp.y (parse_type, find_primitive_type, type_char)
7853         (type_system_address): Replace "parse_gdbarch" with method call.
7854
7855 2019-04-04  Tom Tromey  <tom@tromey.com>
7856
7857         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
7858         * stap-probe.c (stap_parse_argument): Update.
7859         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
7860         initial_size parameter.
7861         * rust-exp.y (rust_lex_tests): Update.
7862         * parse.c (parser_state): Update.
7863         (parse_exp_in_context): Update.
7864         * parser-defs.h (struct parser_state) <parser_state>: Remove
7865         "initial_size" parameter.
7866
7867 2019-04-04  Tom Tromey  <tom@tromey.com>
7868
7869         * parser-defs.h (increase_expout_size): Don't declare.
7870         * parse.c (increase_expout_size): Now static.
7871
7872 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
7873
7874         * gnu-nat.c (gnu_nat_target::wait): Fix
7875         target_waitstatus_to_string call.
7876
7877 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
7878
7879         * eval.c (evaluate_subexp_standard): Handle internal functions
7880         during Fortran function call handling.
7881
7882 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
7883
7884         * NEWS: Mention new internal functions.
7885         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
7886         (read_base_type): Use dwarf2_init_complex_target_type.
7887         * value.c (creal_internal_fn): New function.
7888         (cimag_internal_fn): New function.
7889         (_initialize_values): Register new internal functions.
7890
7891 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7892
7893         * infrun.c (stop_all_threads): If debug_infrun, always
7894         trace the wait status after wait_one, using
7895         target_waitstatus_to_string and target_pid_to_str.
7896         (handle_inferior_event): Replace various trace of
7897         wait status kind by a single trace.
7898         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
7899         wait status kind image by target_waitstatus_to_string.
7900         * target/waitstatus.c (target_waitstatus_to_string): Fix
7901         obsolete comment.
7902
7903 2019-04-01  Tom Tromey  <tromey@adacore.com>
7904
7905         PR symtab/23331:
7906         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
7907
7908 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
7909             Pedro Alves  <palves@redhat.com>
7910
7911         * top.c (quit_force): Call 'finalize_values'.
7912         * value.c (finalize_values): New function.
7913         * value.h (finalize_values): Declare.
7914
7915 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
7916
7917         * NEWS: Announce $_gdb_major and $_gdb_minor.
7918
7919         * top.c (init_gdb_version_vars): New function.
7920         (gdb_init): Call init_gdb_version_vars.
7921
7922 2019-03-29  Tom Tromey  <tromey@adacore.com>
7923
7924         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
7925         help text.  Remove dead code.
7926
7927 2019-03-29  Keith Seitz  <keiths@redhat.com>
7928
7929         From Siddhesh Poyarekar:
7930         * f-lang.h (f77_get_upperbound): Return LONGEST.
7931         (f77_get_lowerbound): Likewise.
7932         * f-typeprint.c (f_type_print_varspec_suffix): Expand
7933         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
7934         print them.
7935         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
7936         plongest to format print it.
7937         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
7938         (f77_get_upperbound): Likewise.
7939         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
7940         LOWER_BOUND to LONGEST.
7941         (f77_create_arrayprint_offset_tbl): Likewise.
7942
7943 2019-03-29  Keith Seitz  <keiths@redhat.com>
7944
7945         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
7946         %s/pulongest for TYPE_LENGTH instead of %d in format
7947         strings.
7948         * ada-typerint.c (ada_print_type): Likewise.
7949         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
7950         * compile/compile-c-support.c (generate_register_struct): Likewise.
7951         * gdbtypes.c (recursive_dump_type): Likewise.
7952         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
7953         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
7954         instead of %d in format strings.
7955         * riscv-tdep.c (riscv_type_alignment): Cast second argument
7956         to std::min to ULONGEST.
7957         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
7958         instead of %d in format strings.
7959         * tracepoint.c (info_scope_command): Likewise.
7960         * typeprint.c (print_offset_data::update)
7961         (print_offset_data::finish): Likewise.
7962         * xtensa-tdep.c (xtensa_store_return_value)
7963         (xtensa_push_dummy_call): Likewise.
7964
7965 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
7966
7967         * windows-nat.c (display_selector): Fixed format specifications
7968         for 64-bit Cygwin.
7969
7970 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7971
7972         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
7973
7974 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
7975
7976         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
7977         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
7978         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
7979         (nios2_linux_init_abi): Install it.
7980
7981 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
7982
7983         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
7984
7985 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
7986
7987         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
7988
7989 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7990             Tom Tromey  <tromey@adacore.com>
7991
7992         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
7993
7994 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
7995
7996         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
7997         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
7998         method to compute the bounds of range types. Also print "[evaluated]"
7999         if the bounds' values come from a dynamic evaluation.
8000
8001 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
8002
8003         * cp-valprint.c (cp_print_value_fields): Don't print trailing
8004         whitespace when pretty printing is on.
8005
8006 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
8007
8008         * ppc-linux-nat.c: Add include.
8009
8010 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
8011
8012         * NEWS: Mention AArch64 Pointer Authentication.
8013
8014 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
8015
8016         * arm-linux-nat.c: Add include.
8017
8018 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
8019
8020         * source-cache.c (source_cache::get_source_lines): Re-read
8021         fullname after calling open_source_file.
8022
8023 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
8024
8025         * NEWS: Mention TLS support for FreeBSD.
8026
8027 2019-03-25  Tom Tromey  <tromey@adacore.com>
8028
8029         * minsyms.c (BUNCH_SIZE): Update comment.
8030         (~minimal_symbol_reader): Remove old comment.
8031         (compact_minimal_symbols): Update comment.
8032         (minimal_symbol_reader::install): Remove old comment.  Update
8033         other comments.
8034
8035 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
8036
8037         * s390-linux-nat.c: Add include.
8038
8039 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
8040
8041         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
8042         Call linux_get_hwcap.
8043         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
8044         Likewise.
8045         (aarch64_linux_get_hwcap): Remove function.
8046         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
8047         declaration.
8048         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
8049         linux_get_hwcap.
8050         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
8051         * linux-tdep.c (linux_get_hwcap): Add function.
8052         (linux_get_hwcap2): Likewise.
8053         * linux-tdep.h (linux_get_hwcap): Add declaration.
8054         (linux_get_hwcap2): Likewise.
8055         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
8056         (ppc_linux_get_hwcap2): Likewise.
8057         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
8058         linux_get_hwcap.
8059         (ppc_linux_nat_target::insert_watchpoint): Likewise.
8060         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
8061         (ppc_linux_nat_target::read_description): Likewise.
8062         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
8063         * s390-linux-nat.c: Likewise.
8064         * s390-linux-tdep.c (s390_core_read_description): Likewise.
8065
8066 2019-03-24  Tom Tromey  <tom@tromey.com>
8067
8068         * ada-lang.c (standard_lookup): Simplify initialization.
8069         (ada_lookup_symbol_nonlocal): Simplify return.
8070         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
8071         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
8072         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
8073         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
8074         initialization.
8075         * solib.c (solib_global_lookup): Simplify.
8076         * symtab.c (null_block_symbol): Remove.
8077         (symbol_cache_lookup): Simplify returns.
8078         (lookup_language_this): Simplify returns.
8079         (lookup_symbol_aux): Simplify return.
8080         (lookup_local_symbol): Simplify returns.
8081         (lookup_global_symbol_from_objfile): Simplify return.
8082         (lookup_symbol_in_objfile_symtabs)
8083         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
8084         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
8085         (lookup_static_symbol, lookup_global_symbol): Simplify return.
8086         * cp-namespace.c (cp_lookup_bare_symbol)
8087         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
8088         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
8089         (cp_lookup_nested_symbol): Don't use null_block_symbol.
8090         (cp_lookup_symbol_via_imports): Simplify initialization.
8091         (find_symbol_in_baseclass): Likewise.
8092         * symtab.h (null_block_symbol): Remove.
8093         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
8094         (d_lookup_nested_symbol, d_lookup_symbol_imports)
8095         (d_lookup_symbol_module): Likewise.
8096         (find_symbol_in_baseclass): Simplify initialization.
8097
8098 2019-03-24  Tom Tromey  <tom@tromey.com>
8099
8100         * expression.h: Don't include symtab.h.
8101         (struct block): Forward declare.
8102
8103 2019-03-24  Tom Tromey  <tom@tromey.com>
8104
8105         * c-exp.y (typebase): Remove casts.
8106         * gdbtypes.c (lookup_unsigned_typename, )
8107         (lookup_signed_typename): Remove cast.
8108         * eval.c (parse_to_comma_and_eval): Remove cast.
8109         * parse.c (write_dollar_variable): Remove cast.
8110         * block.h (struct block) <superblock>: Now const.
8111         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
8112         * psymtab.c (psym_map_matching_symbols): Make "block" const.
8113         (map_block): Make "block" const.
8114         * symfile.h (struct quick_symbol_functions)
8115         <map_matching_symbols>: Constify block argument to "callback".
8116         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
8117         const.
8118         (find_pc_sect_compunit_symtab): Make "b" const.
8119         (find_symbol_at_address): Likewise.
8120         (search_symbols): Likewise.
8121         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
8122         (dw2_debug_names_lookup_symbol): Likewise.
8123         (dw2_map_matching_symbols): Update.
8124         * p-valprint.c (pascal_val_print): Remove "block".
8125         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
8126         (aux_add_nonlocal_symbols): Make "block" const.
8127         (resolve_subexp): Remove cast.
8128         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
8129         const.
8130         (iterate_over_file_blocks): Likewise.
8131         * f-exp.y (%union) <bval>: Remove.
8132         * coffread.c (patch_opaque_types): Make "b" const.
8133         * spu-tdep.c (spu_catch_start): Make "block" const.
8134         * c-valprint.c (print_unpacked_pointer): Remove "block".
8135         * symmisc.c (dump_symtab_1): Make "b" const.
8136         (block_depth): Make "block" const.
8137         * d-exp.y (%union) <bval>: Remove.
8138         * cp-support.h (cp_lookup_rtti_type): Update.
8139         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
8140         * psymtab.c (psym_lookup_symbol): Make "block" const.
8141         (maintenance_check_psymtabs): Make "b" const.
8142         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
8143         (enumerate_locals, enumerate_args): Update.
8144         * python/py-symtab.c (stpy_global_block): Make "block" const.
8145         (stpy_static_block): Likewise.
8146         * inline-frame.c (block_starting_point_at): Make "new_block"
8147         const.
8148         * block.c (find_block_in_blockvector): Make return type const.
8149         (blockvector_for_pc_sect): Make "b" const.
8150         (find_block_in_blockvector): Make "b" const.
8151
8152 2019-03-23  Tom Tromey  <tom@tromey.com>
8153
8154         * varobj.c (varobj_create): Update.
8155         * symfile.c (clear_symtab_users): Don't reset innermost_block.
8156         * printcmd.c (display_command, do_one_display): Don't reset
8157         innermost_block.
8158         * parser-defs.h (enum innermost_block_tracker_type): Move to
8159         expression.h.
8160         (innermost_block): Update comment.
8161         * parse.c (parse_exp_1): Add tracker_types parameter.
8162         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
8163         tracker_types parameter.  Reset innermost_block.
8164         (parse_exp_in_context): Remove.
8165         (parse_expression_for_completion): Update.
8166         * objfiles.c (~objfile): Don't reset expression_context_block or
8167         innermost_block.
8168         * expression.h (enum innermost_block_tracker_type): Move from
8169         parser-defs.h.
8170         (parse_exp_1): Add tracker_types parameter.
8171         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
8172         reset innermost_block.
8173
8174 2019-03-23  Tom Tromey  <tom@tromey.com>
8175
8176         * objfiles.h: Include bcache.h.
8177
8178 2019-03-23  Tom Tromey  <tom@tromey.com>
8179
8180         * linespec.c (get_current_search_block): Use
8181         scoped_restore_current_language.
8182         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
8183
8184 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8185             Jiong Wang  <jiong.wang@arm.com>
8186
8187         * aarch64-linux-tdep.c
8188         (aarch64_linux_iterate_over_regset_sections): Check for pauth
8189         section.
8190         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
8191
8192 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8193             Jiong Wang  <jiong.wang@arm.com>
8194
8195         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
8196         instructions.
8197         (aarch64_analyze_prologue_test): Add PACIASP test.
8198         (aarch64_prologue_prev_register): Unmask PC value.
8199
8200 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8201             Jiong Wang  <jiong.wang@arm.com>
8202
8203         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
8204         (aarch64_dwarf2_prev_register): Unmask PC value.
8205         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
8206         (aarch64_execute_dwarf_cfa_vendor_op): Check for
8207         DW_CFA_AARCH64_negate_ra_state.
8208         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
8209
8210 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8211             Jiong Wang  <jiong.wang@arm.com>
8212
8213         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
8214         registers.
8215         (aarch64_pseudo_register_name): Likewise.
8216         (aarch64_pseudo_register_type): Likewise.
8217         (aarch64_pseudo_register_reggroup_p): Likewise.
8218         (aarch64_gdbarch_init): Add pauth registers.
8219         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
8220         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
8221         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
8222         (struct gdbarch_tdep): Add regnum for ra_state.
8223
8224 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8225             Jiong Wang  <jiong.wang@arm.com>
8226
8227         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
8228
8229 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8230             Jiong Wang  <jiong.wang@arm.com>
8231
8232         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
8233         function.
8234         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
8235         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
8236         (aarch64_gdbarch_init): Add puth registers.
8237         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
8238         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
8239         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
8240
8241 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8242             Jiong Wang  <jiong.wang@arm.com>
8243
8244         * aarch64-linux-nat.c
8245         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
8246         * aarch64-linux-tdep.c
8247         (aarch64_linux_core_read_description): Likewise.
8248         (aarch64_linux_get_hwcap): New function.
8249         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
8250         (aarch64_linux_get_hwcap): New declaration.
8251
8252 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8253             Jiong Wang  <jiong.wang@arm.com>
8254
8255         * aarch64-linux-nat.c
8256         (aarch64_linux_nat_target::read_description): Add pauth param.
8257         * aarch64-linux-tdep.c
8258         (aarch64_linux_core_read_description): Likewise.
8259         * aarch64-tdep.c (struct target_desc): Add in pauth.
8260         (aarch64_read_description): Add pauth param.
8261         (aarch64_gdbarch_init): Likewise.
8262         * aarch64-tdep.h (aarch64_read_description): Likewise.
8263         * arch/aarch64.c (aarch64_create_target_description): Likewise.
8264         * arch/aarch64.h (aarch64_create_target_description): Likewise.
8265         * features/Makefile: Add new files.
8266         * features/aarch64-pauth.c: New file.
8267         * features/aarch64-pauth.xml: New file.
8268
8269 2019-03-20  Tom Tromey  <tromey@adacore.com>
8270
8271         * infrun.c (handle_inferior_event): Rename from
8272         handle_inferior_event_1.  Create a scoped_value_mark.
8273         (handle_inferior_event): Remove.
8274
8275 2019-03-19  Tom Tromey  <tromey@adacore.com>
8276
8277         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
8278         * infrun.h (print_stop_event): Add "displays" parameter.
8279         * infrun.c (print_stop_event): Add "displays" parameter.
8280
8281 2019-03-19  Pedro Alves  <palves@redhat.com>
8282
8283         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
8284         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
8285         to -1.  Fix TABs vs spaces.
8286         (tui_ui_out::tui_ui_out): Don't initialize fields here.
8287         * tui/tui-out.h (tui_ui_out) Add intro comments.
8288         <m_line, m_start_of_line>: In-class initialize, and add describing
8289         comment.
8290
8291 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
8292
8293         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
8294         variable names.
8295         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
8296
8297 2019-03-18  Pedro Alves  <palves@redhat.com>
8298             Eli Zaretskii <eliz@gnu.org>
8299
8300         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
8301         m_line and m_start_of_line.
8302
8303 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
8304
8305         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
8306         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
8307         it returns a newline.  This fixes a regression in TU mode, whereby
8308         the next line is output on the same screen line as the user input.
8309
8310 2019-03-18  Tom Tromey  <tromey@adacore.com>
8311
8312         * minsyms.c (minimal_symbol_reader::install): Remove call to
8313         obstack_blank.
8314
8315 2019-03-18  Pedro Alves  <palves@redhat.com>
8316
8317         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
8318         New globals.
8319         (apply_style): New, factored out from ...
8320         (apply_ansi_escape): ... this.  Handle reverse video mode.
8321         (tui_set_reverse_mode): New function.
8322         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
8323         * tui/tui-winsource.c (tui_show_source_line): Use
8324         tui_set_reverse_mode instead of setting A_STANDOUT.
8325         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
8326         New setter methods.
8327
8328 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
8329
8330         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
8331         Handle tabs.
8332
8333 2019-03-18  Tom Tromey  <tromey@adacore.com>
8334
8335         * ada-lang.c (empty_array): Add "high" parameter.
8336         (ada_evaluate_subexp): Update.
8337
8338 2019-03-17  Sergei Trofimovich <siarheit@google.com>
8339
8340         * unittests/string_view-selftests.c: Define
8341         _initialize_string_view_selftests unconditionally.
8342
8343 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
8344
8345         PR gdb/24350
8346         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
8347
8348 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
8349
8350         PR gdb/24351
8351         * windows-nat.c (display_selector): Fix format specifiers.
8352
8353 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
8354
8355         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
8356         tui_refill_source_window instead of tui_refresh_win, to update the
8357         current execution line.  This fixes redisplay of the current line
8358         when stepping through the code with "next" or "step".
8359
8360 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
8361
8362         * source-cache.c (source_cache::get_source_lines): Call
8363         find_source_lines to initialize s->nlines.  This fixes vertical
8364         scrolling of TUI source window when the DOWN arrow is pressed.
8365
8366 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8367
8368         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
8369         linux-thread-db.c (_initialize_thread_db): Likewise.
8370
8371 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
8372
8373         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
8374         wclrtoeol in tui_show_source_line".  This reverts changes made in
8375         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
8376
8377 2019-03-15  Tom Tromey  <tom@tromey.com>
8378
8379         * symtab.h (struct minimal_symbol): Derive from
8380         general_symbol_info.
8381         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
8382         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
8383         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
8384         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
8385         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
8386         (MSYMBOL_SEARCH_NAME): Update.
8387         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
8388         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
8389         * minsyms.c (minimal_symbol_reader::record_full): Update.
8390
8391 2019-03-15  Tom Tromey  <tom@tromey.com>
8392
8393         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
8394
8395 2019-03-15  Tom Tromey  <tom@tromey.com>
8396
8397         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
8398         unique_xmalloc_ptr.
8399         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
8400         Update.
8401         * minsyms.c (lookup_minimal_symbol_by_pc_section)
8402         (build_minimal_symbol_hash_tables)
8403         (minimal_symbol_reader::install): Update.
8404
8405 2019-03-15  Tom Tromey  <tom@tromey.com>
8406
8407         * symtab.c (create_demangled_names_hash): Update.
8408         (symbol_set_names): Update.
8409         * objfiles.h (struct objfile_per_bfd_storage)
8410         <demangled_names_hash>: Now an htab_up.
8411         * objfiles.c (objfile_per_bfd_storage): Simplify.
8412
8413 2019-03-15  Tom Tromey  <tom@tromey.com>
8414
8415         * objfiles.h (struct objfile_per_bfd_storage): Declare
8416         destructor.
8417         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
8418         New.
8419         (get_objfile_bfd_data): Use new.  Don't initialize
8420         language_of_main.
8421         (free_objfile_per_bfd_storage): Remove.
8422         (objfile_bfd_data_free, objfile::~objfile): Use delete.
8423
8424 2019-03-15  Tom Tromey  <tom@tromey.com>
8425
8426         * symfile.c (reread_symbols): Update.
8427         * objfiles.c (objfile::objfile): Update.
8428         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
8429         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
8430         comment.
8431         (minimal_symbol_reader::install): Update.
8432         (terminate_minimal_symbol_table): Remove.
8433         * jit.c (jit_object_close_impl): Update.
8434
8435 2019-03-15  Tom Tromey  <tom@tromey.com>
8436
8437         * minsyms.c (minimal_symbol_reader::record_full): Remove some
8438         initializations.
8439
8440 2019-03-15  Tom Tromey  <tom@tromey.com>
8441
8442         * objfiles.h (struct objfile_per_bfd_storage)
8443         <demangled_hash_languages>: Now a bitset.
8444         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
8445         (lookup_minimal_symbol): Update.
8446
8447 2019-03-15  Tom Tromey  <tom@tromey.com>
8448
8449         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
8450         Don't return the symbol.
8451         * coffread.c (record_minimal_symbol): Use record_full.
8452
8453 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
8454
8455         The MS-Windows port of ncurses fails to switch to a color pair if
8456         one or both of the colors are the implicit default colors.  This
8457         change records the default colors when TUI is initialized, and
8458         then specifies them explicitly when a color pair uses the default
8459         colors.  This allows color styling in TUI mode on MS-Windows.
8460
8461         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
8462         ncurses_norm_attr.
8463         (tui_initialize_io) [__MINGW32__]: Record the default terminal
8464         colors in ncurses_norm_attr.
8465         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
8466         "none", replace it with the default color recorded in
8467         ncurses_norm_attr.
8468
8469 2019-03-14  Tom Tromey  <tromey@adacore.com>
8470
8471         * source-cache.h (class source_cache) <get_source_lines>: Return
8472         std::string.
8473         * source-cache.c (source_cache::extract_lines): Handle case where
8474         first_pos==npos.  Return std::string.
8475         (source_cache::get_source_lines): Update.
8476
8477 2019-03-14  Tom Tromey  <tromey@adacore.com>
8478
8479         * NEWS: Add item for "style sources" commands.
8480         * source-cache.c (source_cache::get_source_lines): Check
8481         source_styling.
8482         * cli/cli-style.c (source_styling): New global.
8483         (_initialize_cli_style): Add "style sources" commands.
8484         (show_style_sources): New function.
8485         * cli/cli-style.h (source_styling): Declare.
8486
8487 2019-03-14  Pedro Alves  <palves@redhat.com>
8488             Tom Tromey  <tromey@adacore.com>
8489
8490         * tui/tui-winsource.h (tui_refill_source_window): Declare.
8491         * tui/tui-winsource.c (tui_refill_source_window): New function,
8492         from...
8493         (tui_horizontal_source_scroll): ... here.  Move some logic.
8494         * cli/cli-style.c (set_style_enabled): Notify new observable.
8495         * tui/tui-hooks.c (tui_redisplay_source): New function.
8496         (tui_attach_detach_observers): Attach or detach
8497         tui_redisplay_source.
8498         * observable.h (source_styling_changed): New observable.
8499         * observable.c: Define source_styling_changed observable.
8500
8501 2019-03-13  Tom Tromey  <tromey@adacore.com>
8502
8503         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
8504         (i386_gnu_nat_target::store_registers): Update.
8505         * target-debug.h (target_debug_print_std_string): New macro.
8506         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
8507         * windows-tdep.c (display_one_tib): Update.
8508         * tui/tui-stack.c (tui_make_status_line): Update.
8509         * top.c (print_inferior_quit_action): Update.
8510         * thread.c (thr_try_catch_cmd): Update.
8511         (add_thread_with_info): Update.
8512         (thread_target_id_str): Update.
8513         (thr_try_catch_cmd): Update.
8514         (thread_command): Update.
8515         (thread_find_command): Update.
8516         * record-btrace.c (record_btrace_target::info_record)
8517         (record_btrace_resume_thread, record_btrace_target::resume)
8518         (record_btrace_cancel_resume, record_btrace_step_thread)
8519         (record_btrace_target::wait, record_btrace_target::wait)
8520         (record_btrace_target::wait, record_btrace_target::stop): Update.
8521         * progspace.c (print_program_space): Update.
8522         * process-stratum-target.c
8523         (process_stratum_target::thread_address_space): Update.
8524         * linux-fork.c (linux_fork_mourn_inferior)
8525         (detach_checkpoint_command, info_checkpoints_command)
8526         (linux_fork_context): Update.
8527         (linux_fork_detach): Update.
8528         (class scoped_switch_fork_info): Update.
8529         (delete_checkpoint_command): Update.
8530         * infrun.c (follow_fork_inferior): Update.
8531         (follow_fork_inferior): Update.
8532         (proceed_after_vfork_done): Update.
8533         (handle_vfork_child_exec_or_exit): Update.
8534         (follow_exec): Update.
8535         (displaced_step_prepare_throw): Update.
8536         (displaced_step_restore): Update.
8537         (start_step_over): Update.
8538         (resume_1): Update.
8539         (clear_proceed_status_thread): Update.
8540         (proceed): Update.
8541         (print_target_wait_results): Update.
8542         (do_target_wait): Update.
8543         (context_switch): Update.
8544         (stop_all_threads): Update.
8545         (restart_threads): Update.
8546         (finish_step_over): Update.
8547         (handle_signal_stop): Update.
8548         (switch_back_to_stepped_thread): Update.
8549         (keep_going_pass_signal): Update.
8550         (print_exited_reason): Update.
8551         (normal_stop): Update.
8552         * inferior.c (inferior_pid_to_str): Change return type.
8553         (print_selected_inferior): Update.
8554         (add_inferior): Update.
8555         (detach_inferior): Update.
8556         * dummy-frame.c (fprint_dummy_frames): Update.
8557         * dcache.c (dcache_info_1): Update.
8558         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
8559         (btrace_fetch, btrace_clear): Update.
8560         * linux-tdep.c (linux_core_pid_to_str): Change return type.
8561         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
8562         type.
8563         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
8564         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
8565         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
8566         * gdbarch.c, gdbarch.h: Rebuild.
8567         * gdbarch.sh (core_pid_to_str): Change return type.
8568         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
8569         return type.
8570         (windows_nat_target::pid_to_str): Change return type.
8571         (windows_delete_thread): Update.
8572         (windows_nat_target::attach): Update.
8573         (windows_nat_target::files_info): Update.
8574         * target-delegates.c: Rebuild.
8575         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
8576         return type.
8577         (sol_thread_target::pid_to_str): Change return type.
8578         * remote.c (class remote_target) <pid_to_str>: Change return
8579         type.
8580         (remote_target::pid_to_str): Change return type.
8581         (extended_remote_target::attach, remote_target::remote_stop_ns)
8582         (remote_target::remote_notif_remove_queued_reply)
8583         (remote_target::push_stop_reply, remote_target::disable_btrace):
8584         Update.
8585         (extended_remote_target::attach): Update.
8586         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
8587         type.
8588         (gdbsim_target::pid_to_str): Change return type.
8589         * ravenscar-thread.c (struct ravenscar_thread_target)
8590         <pid_to_str>: Change return type.
8591         (ravenscar_thread_target::pid_to_str): Change return type.
8592         * procfs.c (class procfs_target) <pid_to_str>: Change return
8593         type.
8594         (procfs_target::pid_to_str): Change return type.
8595         (procfs_target::attach): Update.
8596         (procfs_target::detach): Update.
8597         (procfs_target::fetch_registers): Update.
8598         (procfs_target::store_registers): Update.
8599         (procfs_target::wait): Update.
8600         (procfs_target::files_info): Update.
8601         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
8602         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
8603         return type.
8604         (nto_procfs_target::pid_to_str): Change return type.
8605         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
8606         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
8607         return type.
8608         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
8609         (exit_lwp): Update.
8610         (attach_proc_task_lwp_callback, get_detach_signal)
8611         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
8612         (linux_nat_target::resume, wait_lwp, stop_callback)
8613         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
8614         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
8615         (linux_nat_wait_1, resume_stopped_resumed_lwps)
8616         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
8617         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
8618         type.
8619         (inf_ptrace_target::attach): Update.
8620         (inf_ptrace_target::files_info): Update.
8621         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
8622         type.
8623         (go32_nat_target::pid_to_str): Change return type.
8624         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
8625         (gnu_nat_target::wait): Update.
8626         (gnu_nat_target::wait): Update.
8627         (gnu_nat_target::resume): Update.
8628         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
8629         (fbsd_nat_target::wait): Update.
8630         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
8631         type.
8632         (darwin_nat_target::attach): Update.
8633         * corelow.c (class core_target) <pid_to_str>: Change return type.
8634         (core_target::pid_to_str): Change return type.
8635         * target.c (normal_pid_to_str): Change return type.
8636         (default_pid_to_str): Likewise.
8637         (target_pid_to_str): Change return type.
8638         (target_translate_tls_address): Update.
8639         (target_announce_detach): Update.
8640         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
8641         return type.
8642         (bsd_uthread_target::pid_to_str): Change return type.
8643         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
8644         type.
8645         (bsd_kvm_target::pid_to_str): Change return type.
8646         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
8647         return type.
8648         (aix_thread_target::pid_to_str): Change return type.
8649         * target.h (struct target_ops) <pid_to_str>: Change return type.
8650         (target_pid_to_str, normal_pid_to_str): Likewise.
8651         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
8652         type.
8653         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
8654         type.
8655         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
8656         return type.
8657         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
8658         type.
8659         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
8660         type.
8661         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
8662         return type.
8663
8664 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
8665
8666         * NEWS: Mention that the new default MI version is 3.  Mention
8667         changes to the output of commands and events that deal with
8668         multi-location breakpoints.
8669         * breakpoint.c: Include "mi/mi-out.h".
8670         (print_one_breakpoint): Change output syntax if using MI version
8671         >= 3.
8672         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
8673         New.
8674         (mi_multi_location_breakpoint_output_fixed): New.
8675         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
8676         (mi_cmd_fix_multi_location_breakpoint_output): New.
8677         (mi_multi_location_breakpoint_output_fixed): New.
8678         * mi/mi-cmds.c (mi_cmds): Register command
8679         -fix-multi-location-breakpoint-output.
8680         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
8681         interpreter "mi".
8682
8683 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
8684
8685         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
8686         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
8687         instantiate mi_ui_out based on interpreter name.
8688         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
8689         * mi/mi-main.c (mi_load_progress): Likewise.
8690
8691 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8692
8693         * NEWS: Combine separate "New targets" sections for 8.3.
8694
8695 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8696
8697         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
8698         (ppcfbsd_init_abi): Install gdbarch
8699         "fetch_tls_load_module_address" and "get_thread_local_address"
8700         methods.
8701
8702 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8703
8704         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
8705         (riscv_fbsd_init_abi): Install gdbarch
8706         "fetch_tls_load_module_address" and "get_thread_local_address"
8707         methods.
8708
8709 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8710
8711         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
8712         (i386fbsd_init_abi): Install gdbarch
8713         "fetch_tls_load_module_address" and "get_thread_local_address"
8714         methods.
8715
8716 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8717
8718         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
8719         (amd64fbsd_init_abi): Install gdbarch
8720         "fetch_tls_load_module_address" and "get_thread_local_address"
8721         methods.
8722
8723 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8724
8725         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
8726         (struct fbsd_pspace_data): New type.
8727         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
8728         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
8729         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
8730         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
8731         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
8732
8733 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8734
8735         * gdbtypes.c (lookup_struct_elt): New function.
8736         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
8737         * gdbtypes.h (struct struct_elt): New type.
8738         (lookup_struct_elt): New prototype.
8739
8740 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8741
8742         * gdbtypes.c (lookup_struct_elt_type): Update comment and
8743         remove disabled code block.
8744
8745 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8746
8747         * gdbarch.sh (get_thread_local_address): New method.
8748         * gdbarch.h, gdbarch.c: Regenerate.
8749         * target.c (target_translate_tls_address): Use
8750         gdbarch_get_thread_local_address if present instead of
8751         target::get_thread_local_address.
8752
8753 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8754
8755         * target.h (target::get_thread_local_address): Update comment.
8756
8757 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8758
8759         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
8760         objfile->separate_debug_objfile_backlink if not NULL.
8761
8762 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8763
8764         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
8765         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
8766         (amd64bsd_store_inferior_registers): Likewise.
8767         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
8768         Enable segment base registers.
8769         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
8770         PT_GETFSBASE and PT_GETGSBASE.
8771         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
8772         PT_SETGSBASE.
8773         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
8774         segment base registers.
8775         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
8776
8777 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8778
8779         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
8780         Update calls to i386_target_description to add 'segments'
8781         parameter.
8782         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
8783         add segment base registers.
8784         * arch/i386.c (i386_create_target_description): Add 'segments'
8785         parameter to enable segment base registers.
8786         * arch/i386.h (i386_create_target_description): Likewise.
8787         * features/i386/32bit-segments.xml: New file.
8788         * features/i386/32bit-segments.c: Generate.
8789         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
8790         call to i386_target_description to add 'segments' parameter.
8791         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
8792         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
8793         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
8794         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
8795         if feature is present.
8796         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
8797         Add 'segments' parameter to call to i386_target_description.
8798         (i386_target_description): Add 'segments' parameter to enable
8799         segment base registers.
8800         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
8801         to call to i386_target_description.
8802         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
8803         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
8804         Define I386_NUM_REGS.
8805         (i386_target_description): Add 'segments' parameter to enable
8806         segment base registers.
8807
8808 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
8809
8810         PR/24325
8811         * source-cache.c: #undef open and close, to avoid unresolved
8812         externals during linking.
8813
8814 2019-03-12  Tom Tromey  <tromey@adacore.com>
8815
8816         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
8817         const.  Add initializers.
8818         (_initialize_remote): Don't initialize ptid globals.
8819
8820 2019-03-12  Pedro Alves  <palves@redhat.com>
8821
8822         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
8823
8824 2019-03-12  Pedro Alves  <palves@redhat.com>
8825
8826         * cp-name-parser.y (main): Remove unused 'len' variable.
8827
8828 2019-03-12  Tom Tromey  <tromey@adacore.com>
8829
8830         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
8831         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
8832
8833 2019-03-12  Tom Tromey  <tromey@adacore.com>
8834
8835         * linux-nat.c (iterate_over_lwps): Update.
8836         (stop_callback): Remove parameter.
8837         (stop_wait_callback, detach_callback, resume_set_callback)
8838         (select_singlestep_lwp_callback, set_ignore_sigint)
8839         (status_callback, resumed_callback, resume_clear_callback)
8840         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
8841         data parameter.
8842         (linux_nat_target::detach, linux_nat_target::resume)
8843         (linux_stop_and_wait_all_lwps, select_event_lwp)
8844         (linux_nat_filter_event, linux_nat_wait_1)
8845         (linux_nat_target::kill, linux_nat_target::stop)
8846         (linux_nat_target::stop): Update.
8847         (linux_nat_resume_callback): Change type.
8848         (resume_stopped_resumed_lwps, count_events_callback)
8849         (select_event_lwp_callback): Likewise.
8850         (linux_stop_lwp, linux_nat_stop_lwp): Update.
8851         * arm-linux-nat.c (struct update_registers_data): Remove.
8852         (update_registers_callback): Change type.
8853         (arm_linux_insert_hw_breakpoint1): Update.
8854         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
8855         parameter.
8856         (x86_linux_dr_set_addr): Update.
8857         (x86_linux_dr_set_control): Update.
8858         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
8859         (iterate_over_lwps): Use gdb::function_view.
8860         * nat/aarch64-linux-hw-point.c (struct
8861         aarch64_dr_update_callback_param): Remove.
8862         (debug_reg_change_callback): Change type.
8863         (aarch64_notify_debug_reg_change): Update.
8864         * s390-linux-nat.c (s390_refresh_per_info): Update.
8865
8866 2019-03-11  Tom Tromey  <tromey@adacore.com>
8867
8868         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
8869         redundant assignment to "this_cu".
8870
8871 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8872
8873         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
8874
8875 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8876
8877         * gdbtypes.c (rank_one_type_parm_set): New function extracted
8878         from...
8879         (rank_one_type): ... this.
8880
8881 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8882
8883         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
8884         from...
8885         (rank_one_type): ... this.
8886
8887 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8888
8889         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
8890         from...
8891         (rank_one_type): ... this.
8892
8893 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8894
8895         * gdbtypes.c (rank_one_type_parm_float): New function extracted
8896         from...
8897         (rank_one_type): ... this.
8898
8899 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8900
8901         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
8902         from...
8903         (rank_one_type): ... this.
8904
8905 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8906
8907         * gdbtypes.c (rank_one_type_parm_range): New function extracted
8908         from...
8909         (rank_one_type): ... this.
8910
8911 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8912
8913         * gdbtypes.c (rank_one_type_parm_char): New function extracted
8914         from...
8915         (rank_one_type): ... this.
8916
8917 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8918
8919         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
8920         from...
8921         (rank_one_type): ... this.
8922
8923 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8924
8925         * gdbtypes.c (rank_one_type_parm_int): New function extracted
8926         from...
8927         (rank_one_type): ... this.
8928
8929 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8930
8931         * gdbtypes.c (rank_one_type_parm_func): New function extracted
8932         from...
8933         (rank_one_type): ... this.
8934
8935 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8936
8937         * gdbtypes.c (rank_one_type_parm_array): New function extracted
8938         from...
8939         (rank_one_type): ... this.
8940
8941 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8942
8943         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
8944         from...
8945         (rank_one_type): ... this.
8946
8947 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8948
8949         * inferior.c (initialize_inferiors): Ensure 'help set/show print
8950         inferior-events' shows the example events.
8951
8952 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
8953
8954         Support styling on native MS-Windows console
8955
8956         PR/24315
8957         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
8958         on MS-Windows if $TERM is not defined.
8959
8960         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
8961
8962         * posix-hdep.c (gdb_console_fputs):
8963         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
8964         functions.
8965         * ui-file.h (gdb_console_fputs): Add prototype.
8966
8967         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
8968         back to fputs only if the former returns zero.
8969
8970 2019-03-07  Tom Tromey  <tom@tromey.com>
8971
8972         * symmisc.c (print_symbol_bcache_statistics): Update.
8973         (print_objfile_statistics): Update.
8974         * symfile.c (allocate_symtab): Update.
8975         * stabsread.c: Don't include bcache.h.
8976         * psymtab.h (struct psymbol_bcache): Don't declare.
8977         (class psymtab_storage) <psymbol_cache>: Now a bcache.
8978         (psymbol_bcache_init, psymbol_bcache_free)
8979         (psymbol_bcache_get_bcache): Don't declare.
8980         * psymtab.c (struct psymbol_bcache): Remove.
8981         (psymtab_storage::psymtab_storage): Update.
8982         (psymtab_storage::~psymtab_storage): Update.
8983         (psymbol_bcache_init, psymbol_bcache_free)
8984         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
8985         (add_psymbol_to_bcache): Update.
8986         (allocate_psymtab): Update.
8987         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
8988         macro_cache>: No longer pointers.
8989         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
8990         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
8991         * macrotab.c (macro_bcache): Update.
8992         * macroexp.c: Don't include bcache.h.
8993         * gdbtypes.c (check_types_worklist): Update.
8994         (types_deeply_equal): Remove TRY/CATCH.  Update.
8995         * elfread.c (elf_symtab_read): Update.
8996         * dwarf2read.c: Don't include bcache.h.
8997         * buildsym.c (buildsym_compunit::get_macro_table): Update.
8998         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
8999         (print_bcache_statistics, bcache_memory_used): Don't declare.
9000         (struct bcache): Move from bcache.c.  Add constructor, destructor,
9001         methods.  Rename all data members.
9002         * bcache.c (struct bcache): Move to bcache.h.
9003         (bcache::expand_hash_table): Rename from expand_hash_table.
9004         (bcache): Remove.
9005         (bcache::insert): Rename from bcache_full.
9006         (bcache::compare): Rename from bcache_compare.
9007         (bcache_xmalloc): Remove.
9008         (bcache::~bcache): Rename from bcache_xfree.
9009         (bcache::print_statistics): Rename from print_bcache_statistics.
9010         (bcache::memory_used): Rename from bcache_memory_used.
9011
9012 2019-03-07  Pedro Alves  <palves@redhat.com>
9013
9014         * infrun.c (normal_stop): Also check for
9015         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
9016
9017 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
9018
9019         * f-lang.c (value_from_host_double): Moved to...
9020         * value.c (value_from_host_double): ...here.
9021         * value.h (value_from_host_double): Declare.
9022         * guile/scm-math.c (vlscm_convert_typed_number): Use
9023         value_from_host_double.
9024         (vlscm_convert_number): Likewise.
9025         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
9026         * python/py-value.c (convert_value_from_python): Likewise.
9027
9028 2019-03-06  Tom Tromey  <tom@tromey.com>
9029
9030         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
9031
9032 2019-03-06  Tom Tromey  <tom@tromey.com>
9033
9034         * utils.h (free_current_contents): Don't declare.
9035         * utils.c (free_current_contents): Remove.
9036
9037 2019-03-06  Tom Tromey  <tom@tromey.com>
9038
9039         * top.c (quit_force): Update.
9040         * main.c (captured_command_loop): Update.
9041         * common/new-op.c (operator new): Update.
9042         * common/common-exceptions.c (struct catcher)
9043         <save_cleanup_chain>: Remove member.
9044         (exceptions_state_mc_init): Update.
9045         (exception_try_scope_entry): Return nullptr.
9046         (exception_try_scope_exit, exception_rethrow)
9047         (throw_exception_sjlj, throw_exception_cxx): Update.
9048         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
9049         (all_cleanups, do_cleanups, discard_cleanups)
9050         (discard_final_cleanups, save_cleanups, save_final_cleanups)
9051         (restore_cleanups, restore_final_cleanups): Don't declare.
9052         (do_final_cleanups): Remove parameter.
9053         * common/cleanups.c (cleanup_chain, make_cleanup)
9054         (make_cleanup_dtor, all_cleanups, do_cleanups)
9055         (discard_my_cleanups, discard_cleanups)
9056         (discard_final_cleanups, save_my_cleanups, save_cleanups)
9057         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
9058         (null_cleanup): Remove.
9059         (do_final_cleanups): Remove parameter.
9060
9061 2019-03-06  Tom Tromey  <tom@tromey.com>
9062
9063         * remote.c (remote_target::remote_parse_stop_reply): Use
9064         unique_xmalloc_ptr.
9065
9066 2019-03-06  Tom Tromey  <tom@tromey.com>
9067
9068         * stabsread.c (struct stabs_field_info): Rename from field_info.
9069         <list, fnlist>: Add initializers.
9070         <obstack>: New member.
9071         (read_member_functions, read_struct_fields, read_baseclasses):
9072         Allocate on obstack.  Don't use cleanups.
9073         (read_one_struct_field, read_member_functions, read_struct_fields)
9074         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
9075         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
9076         (read_struct_type): Update.
9077
9078 2019-03-06  Tom Tromey  <tom@tromey.com>
9079
9080         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
9081         * common/filestuff.h (make_cleanup_close): Don't declare.
9082         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
9083         Remove.
9084
9085 2019-03-06  Tom Tromey  <tom@tromey.com>
9086
9087         * solib-aix.c: Use make_scope_exit.
9088
9089 2019-03-06  Tom Tromey  <tom@tromey.com>
9090
9091         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
9092         Use make_scope_exit.
9093
9094 2019-03-06  Tom Tromey  <tom@tromey.com>
9095
9096         * solib-svr4.c (disable_probes_interface): Remove parameter.
9097         (svr4_handle_solib_event): Use make_scope_exit.
9098
9099 2019-03-06  Tom Tromey  <tom@tromey.com>
9100
9101         * remote.c (struct stop_reply_deleter): Remove.
9102         (stop_reply_up): Update.
9103         (struct stop_reply): Derive from notif_event.  Don't typedef.
9104         <regcache>: Now a std::vector.
9105         (stop_reply_xfree): Remove.
9106         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
9107         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
9108         (remote_target::discard_pending_stop_replies): Use delete.
9109         (remote_target::remote_parse_stop_reply): Update.
9110         (remote_target::process_stop_reply): Update.
9111         * remote-notif.h (struct notif_event): Add virtual destructor.
9112         Remove "dtr" member.
9113         (struct notif_client) <alloc_event>: Return a unique_ptr.
9114         (notif_event_xfree): Don't declare.
9115         (notif_event_up): New typedef.
9116         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
9117         (notif_event_xfree, do_notif_event_xfree): Remove.
9118         (remote_notif_state_xfree): Update.
9119
9120 2019-03-06  Tom Tromey  <tom@tromey.com>
9121
9122         * infrun.c (displaced_step_clear_cleanup): Now a
9123         forward_scope_exit type.
9124         (displaced_step_prepare_throw): Update.
9125         (displaced_step_fixup): Update.
9126
9127 2019-03-06  Tom Tromey  <tom@tromey.com>
9128
9129         * inferior.h (class inferior): Update comment.
9130         * gdbthread.h (class thread_info): Update comment.
9131
9132 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
9133             Tom Tromey  <tom@tromey.com>
9134
9135         * stabsread.h (struct stab_section_list): Remove.
9136         (coffstab_build_psymtabs): Update.
9137         * dbxread.c (symbuf_sections): Now a std::vector.
9138         (sect_idx): New global.
9139         (fill_symbuf): Update.
9140         (coffstab_build_psymtabs): Change type of stabsects parameter.
9141         Update.
9142         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
9143         std::vector.
9144         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
9145         (coff_locate_sections): Update.
9146         (coff_symfile_read): Remove cleanups.  Update.
9147         (init_stringtab): Add storage parameter.
9148         (free_stringtab, free_stringtab_cleanup): Remove.
9149         (init_lineno): Add storage parameter.
9150         (free_linetab, free_linetab_cleanup): Remove.
9151
9152 2019-03-06  Pedro Alves  <palves@redhat.com>
9153
9154         * linux-fork.c (fork_info::clobber_regs): Delete.
9155         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
9156         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
9157         comment.  Adjust.
9158         (scoped_switch_fork_info::scoped_switch_fork_info)
9159         (checkpoint_command, linux_fork_context): Adjust
9160         fork_save_infrun_state calls.
9161
9162 2019-03-06  Pedro Alves  <palves@redhat.com>
9163
9164         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
9165         (inf_has_multiple_threads): Return 'bool' and rewrite using
9166         inferior_info::threads().
9167
9168 2019-03-06  Pedro Alves  <palves@redhat.com>
9169
9170         * linux-fork.c: Include <list>.
9171         (fork_list): Now a std::list instance.
9172         (fork_info): Add ctor, dtor, and in-class initialize all fields.
9173         (forks_exist_p, find_last_fork): Adjust.
9174         (new_fork): Delete.
9175         (one_fork_p): New.
9176         (add_fork): Adjust.
9177         (free_fork): Delete, folded into fork_info::~fork_info().
9178         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
9179         Adjust.
9180         (init_fork_list): Delete.
9181         (linux_fork_killall, linux_fork_mourn_inferior)
9182         (linux_fork_detach, info_checkpoints_command): Adjust.
9183         (_initialize_linux_fork): No longer call init_fork_list.
9184
9185 2019-03-06  Pedro Alves  <palves@redhat.com>
9186
9187         * linux-fork.c (new_fork): New, split out of ...
9188         (add_fork): ... this.  Return void.  Move "first fork" special
9189         case from here, to ...
9190         (checkpoint_command): ... here.
9191         * linux-linux.h (add_fork): Return void.
9192
9193 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9194
9195         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
9196
9197 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9198             Chris January  <chris.january@arm.com>
9199             David Lecomber  <david.lecomber@arm.com>
9200
9201         * f-exp.y: New token, UNOP_INTRINSIC.
9202         (exp): New pattern using UNOP_INTRINSIC token.
9203         (f77_keywords): Add 'abs' keyword.
9204         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
9205         (value_from_host_double): New function.
9206         (evaluate_subexp_f): Support UNOP_ABS.
9207
9208 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9209
9210         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
9211         types.
9212
9213 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9214
9215         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
9216         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
9217         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
9218
9219 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9220
9221         * f-exp.y (convert_to_kind_type): Handle more type kinds.
9222
9223 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9224             Chris January  <chris.january@arm.com>
9225
9226         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
9227         * f-exp.y: Define 'KIND' token.
9228         (exp): New pattern for KIND expressions.
9229         (ptype): Handle types with a kind extension.
9230         (direct_abs_decl): Extend to spot kind extensions.
9231         (f77_keywords): Add 'kind' to the list.
9232         (push_kind_type): New function.
9233         (convert_to_kind_type): New function.
9234         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
9235         * parse.c (operator_length_standard): Likewise.
9236         * parser-defs.h (enum type_pieces): Add tp_kind.
9237         * std-operator.def: Add UNOP_KIND.
9238
9239 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9240
9241         * f-exp.y (f_parse): Set yydebug.
9242
9243 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9244
9245         * f-lang.c (evaluate_subexp_f): New function.
9246         (exp_descriptor_f): New global.
9247         (f_language_defn): Use exp_descriptor_f instead of
9248         exp_descriptor_standard.
9249
9250 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9251
9252         * f-exp.y (struct token): Add comments.
9253         (dot_ops): Remove uppercase versions and the end marker.
9254         (f77_keywords): Likewise.
9255         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
9256         entries in the dot_ops array are case insensitive, and use
9257         strncasecmp to compare strings.  Also some whitespace cleanup in
9258         this area.  Similar for the f77_keywords array, except entries in
9259         this list might be case sensitive.
9260
9261 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9262
9263         * f-exp.y (struct f77_boolean_val): Add comments.
9264         (boolean_values): Remove uppercase versions, and end marker.
9265         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
9266         and use strncasecmp to achieve case insensitivity.  Additionally,
9267         perform whitespace cleanup around this code.
9268
9269 2019-03-06  Tom Tromey  <tromey@adacore.com>
9270
9271         * remote-sim.c (gdbsim_target_open): Use result of
9272         gdb_argv::release.
9273
9274 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
9275         Dirk Schubert  <dirk.schubert@arm.com>
9276         Chris January  <chris.january@arm.com>
9277
9278         * eval.c (evaluate_subexp_standard): Call Fortran argument
9279         wrapping logic.
9280         * f-lang.c (struct value): A value which can be passed into a
9281         Fortran function call.
9282         (fortran_argument_convert): Wrap Fortran arguments in a pointer
9283         where appropriate.
9284         (struct type): Value ready for a Fortran function call.
9285         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
9286         is needed.
9287         * f-lang.h (fortran_argument_convert): Declaration.
9288         (fortran_preserve_arg_pointer): Declaration.
9289         * infcall.c (value_arg_coerce): Call Fortran argument logic.
9290
9291 2019-03-05  Tom Tromey  <tromey@adacore.com>
9292
9293         * python/py-prettyprint.c (print_string_repr): Remove #if.
9294         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
9295
9296 2019-03-05  Tom Tromey  <tromey@adacore.com>
9297
9298         * target.c (the_dummy_target): Move later.  Change type to
9299         "dummy_target".
9300         (initialize_targets): Don't initialize the_dummy_target.
9301
9302 2019-03-05  Tom Tromey  <tromey@adacore.com>
9303
9304         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
9305         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
9306
9307 2019-03-05  Tom Tromey  <tromey@adacore.com>
9308
9309         * windows-nat.c (windows_nat_target::attach)
9310         (windows_nat_target::detach): Don't call gdb_flush.
9311         * valprint.c (generic_val_print, val_print, val_print_string):
9312         Don't call gdb_flush.
9313         * utils.c (defaulted_query): Don't call gdb_flush.
9314         * typeprint.c (print_type_scalar): Don't call gdb_flush.
9315         * target.c (target_announce_detach): Don't call gdb_flush.
9316         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
9317         * remote.c (extended_remote_target::attach): Don't call
9318         gdb_flush.
9319         * procfs.c (procfs_target::detach): Don't call gdb_flush.
9320         * printcmd.c (do_examine): Don't call gdb_flush.
9321         (info_display_command): Don't call gdb_flush.
9322         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
9323         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
9324         * memattr.c (info_mem_command): Don't call gdb_flush.
9325         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
9326         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
9327         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
9328         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
9329         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
9330         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
9331         (gnu_nat_target::detach): Don't call gdb_flush.
9332         * f-valprint.c (f_val_print): Don't call gdb_flush.
9333         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
9334         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
9335         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
9336         gdb_flush.
9337         * c-valprint.c (c_val_print): Don't call gdb_flush.
9338         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
9339
9340 2019-03-05  Tom Tromey  <tromey@adacore.com>
9341
9342         * varobj.c (update_dynamic_varobj_children): Update.
9343         (install_default_visualizer): Use reset, not release.
9344         * value.c (set_internalvar): Update.
9345         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
9346         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
9347         ATTRIBUTE_UNUSED_RESULT.
9348
9349 2019-03-05  Tom Tromey  <tromey@adacore.com>
9350
9351         * remote.c (class scoped_remote_fd) <release>: Add
9352         ATTRIBUTE_UNUSED_RESULT.
9353
9354 2019-03-05  Tom Tromey  <tromey@adacore.com>
9355
9356         * macroexp.c (struct macro_buffer) <release>: Add
9357         ATTRIBUTE_UNUSED_RESULT.
9358
9359 2019-03-05  Tom Tromey  <tromey@adacore.com>
9360
9361         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
9362         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
9363         ATTRIBUTE_UNUSED_RESULT.
9364
9365 2019-03-05  Tom Tromey  <tromey@adacore.com>
9366
9367         * common/scoped_fd.h (class scoped_fd) <release>: Add
9368         ATTRIBUTE_UNUSED_RESULT.
9369
9370 2019-03-05  Tom Tromey  <tromey@adacore.com>
9371
9372         * parser-defs.h (struct parser_state) <release>: Add
9373         ATTRIBUTE_UNUSED_RESULT.
9374
9375 2019-03-05  Tom Tromey  <tromey@adacore.com>
9376
9377         * utils.h (class gdb_argv) <release>: Add
9378         ATTRIBUTE_UNUSED_RESULT.
9379         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
9380
9381 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
9382
9383         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
9384         for-loop range, to avoid compiler warnings.
9385
9386         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
9387         avoid compiler warnings about unused variables.
9388
9389         * NEWS: Mention end of support for native debugging on MS-Windows
9390         before XP.
9391
9392         PR gdb/24292
9393         * common/netstuff.c:
9394         * gdbserver/gdbreplay.c
9395         * gdbserver/remote-utils.c:
9396         * ser-tcp.c:
9397         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
9398         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
9399         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
9400         'getaddrinfo' and 'freeaddrinfo' were not available before
9401         Windows XP, and mingw.org's MinGW headers by default define
9402         _WIN32_WINNT to 0x500.
9403
9404 2019-03-01  Gary Benson <gbenson@redhat.com>
9405
9406         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
9407
9408 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
9409             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
9410
9411         PR gdb/8527
9412         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
9413         set_sigint_trap, clear_sigint_trap.
9414
9415 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9416
9417         * target.c (target_detach): Clear the regcache and the
9418         frame cache.
9419
9420 2019-02-27  Pedro Alves  <palves@redhat.com>
9421
9422         * utils.c (set_screen_size): When we cap the height/width sizes,
9423         tweak the corresponding command variable to show "unlimited":
9424
9425 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
9426             Pedro Alves  <palves@redhat.com>
9427
9428         * utils.c (set_screen_size): Reduce "infinite" rows and columns
9429         before calling rl_set_screen_size.
9430
9431 2019-02-27  Tom Tromey  <tromey@adacore.com>
9432
9433         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
9434         define.
9435         * python/py-value.c: Remove Python 2.4 workaround.
9436         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
9437         workaround.
9438         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
9439         Python 2.4 workaround.
9440         * python/python-internal.h: Remove Python 2.4 comment.
9441         (Py_ssize_t): Don't define.
9442         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
9443         (gdb_Py_DECREF): Remove Python 2.4 workaround.
9444         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
9445         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
9446         * python/python.c (do_start_initialization): Remove Python 2.4
9447         workaround.
9448         * python/py-prettyprint.c (class dummy_python_frame): Remove.
9449         (print_children): Remove Python 2.4 workaround.
9450         * python/py-inferior.c (buffer_procs): Remove Python 2.4
9451         workaround.
9452         (CHARBUFFERPROC_NAME): Remove.
9453         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
9454         Python 2.4 workaround.
9455
9456 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
9457
9458         * NEWS: Note minimum Python version.
9459
9460 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
9461
9462         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
9463         code from these functions.  Remove corresponding ifdefs.  Use
9464         Py_buffer_up instead of explicit calls to PyBuffer_Release.
9465         Remove gotos and target of gotos.
9466         (infpy_search_memory): Likewise.
9467
9468 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9469
9470         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
9471         (hppa_gdbarch_init): Don't register deleted functions with
9472         gdbarch.
9473
9474 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9475
9476         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
9477         (h8300_unwind_sp): Delete.
9478         (h8300_dummy_id): Delete.
9479         (h8300_gdbarch_init): Don't register deleted functions with
9480         gdbarch.
9481
9482 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9483
9484         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
9485         (ft32_unwind_pc): Delete.
9486         (ft32_unwind_sp): Delete.
9487         (ft32_gdbarch_init): Don't register deleted functions with
9488         gdbarch.
9489
9490 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9491
9492         * gdb/frv-tdep.c (frv_dummy_id): Delete.
9493         (frv_unwind_pc): Delete.
9494         (frv_unwind_sp): Delete.
9495         (frv_gdbarch_init): Don't register deleted functions with
9496         gdbarch.
9497
9498 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9499
9500         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
9501         (riscv_unwind_pc): Delete.
9502         (riscv_unwind_sp): Delete.
9503         (riscv_gdbarch_init): Don't register deleted functions with
9504         gdbarch.
9505
9506 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9507
9508         * gdb/csky-tdep.c (csky_dummy_id): Delete.
9509         (csky_unwind_pc): Delete.
9510         (csky_unwind_sp): Delete.
9511         (csky_gdbarch_init): Don't register deleted functions with
9512         gdbarch.
9513
9514 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9515
9516         * gdb/cris-tdep.c (cris_dummy_id): Delete.
9517         (cris_unwind_pc): Delete.
9518         (cris_unwind_sp): Delete.
9519         (cris_gdbarch_init): Don't register deleted functions with
9520         gdbarch.
9521
9522 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9523
9524         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
9525         (bfin_unwind_pc): Delete.
9526         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
9527
9528 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9529
9530         * gdb/arm-tdep.c (arm_dummy_id): Delete.
9531         (arm_unwind_pc): Delete.
9532         (arm_unwind_sp): Delete.
9533         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
9534
9535 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9536
9537         * gdb/arc-tdep.c (arc_dummy_id): Delete.
9538         (arc_unwind_pc): Delete.
9539         (arc_unwind_sp): Delete.
9540         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
9541
9542 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9543
9544         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
9545         (alpha_unwind_pc): Delete.
9546         (alpha_gdbarch_init): Don't register deleted functions with
9547         gdbarch.
9548
9549 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9550
9551         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
9552         (aarch64_unwind_pc): Delete.
9553         (aarch64_unwind_sp): Delete.
9554         (aarch64_gdbarch_init): Don't register deleted functions with
9555         gdbarch.
9556
9557 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9558
9559         * gdbtypes.c (type_align): Don't consider static members when
9560         computing structure alignment.
9561
9562 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9563
9564         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
9565         return 0 for other types.
9566         * arch-utils.c (default_type_align): Always return 0.
9567         * gdbarch.h: Regenerate.
9568         * gdbarch.sh (type_align): Extend comment.
9569         * gdbtypes.c (type_align): Add additional comments, always call
9570         gdbarch_type_align before applying the default rules.
9571         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
9572         generic code will then apply a suitable default.
9573         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
9574         types, return 0 for other types.
9575
9576 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
9577
9578         * NEWS: Create a new section for the next release branch.
9579         Rename the section of the current branch, now that it has
9580         been cut.
9581
9582 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
9583
9584         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
9585         * version.in: Bump version to 8.3.50.DATE-git.
9586
9587 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
9588
9589         * aix-thread.c (ptid_cmp): Remove unused variable.
9590         (get_signaled_thread): Likewise.
9591         (store_regs_user_thread): Likewise.
9592         (store_regs_kernel_thread): Likewise.
9593         (fetch_regs_kernel_thread): Remove shadowed variable.
9594
9595 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
9596
9597         * features/riscv/32bit-cpu.xml: Add register numbers.
9598         * features/riscv/32bit-fpu.c: Regenerate.
9599         * features/riscv/32bit-fpu.xml: Add register numbers.
9600         * features/riscv/64bit-cpu.xml: Add register numbers.
9601         * features/riscv/64bit-fpu.c: Regenerate.
9602         * features/riscv/64bit-fpu.xml: Add register numbers.
9603
9604 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
9605
9606         * NEWS: Mention two argument form of gdb.Value constructor.
9607         * python/py-value.c (convert_buffer_and_type_to_value): New
9608         function.
9609         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
9610         Add support for handling an optional second argument.  Call
9611         convert_buffer_and_type_to_value as appropriate.
9612         * python/python-internal.h (Py_buffer_deleter): New struct.
9613         (Py_buffer_up): New typedef.
9614
9615 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
9616
9617         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
9618         instead of releasing ownership.
9619
9620 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
9621
9622         * dwarf2read.c (open_and_init_dwp_file): Call
9623         elf_numsections instead of bfd_count_sections to initialize
9624         dwp_file->num_sections.
9625
9626 2019-02-25  Tom Tromey  <tromey@adacore.com>
9627
9628         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
9629
9630 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
9631
9632         * gcore.in: Add '--readnever' option when invoking GDB.
9633
9634 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
9635
9636         * MAINTAINERS: Update my email address.
9637
9638 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
9639
9640         * build-id.c (build_id_to_debug_bfd_1): New function.
9641         (build_id_to_debug_bfd): Look for separate debug file in
9642         sysroot.
9643
9644 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
9645
9646         * gdbarch.sh: Update the copyright year range that is placed into
9647         generated files.
9648
9649 2019-02-22  Keith Seitz  <keiths@redhat.com>
9650
9651         PR symtab/23853
9652         * linespec.c (create_sals_line_offset): Search for the default
9653         symtab's filename instead of its fullname.
9654
9655 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
9656
9657         * NEWS: Update style defaults.
9658
9659 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
9660
9661         * main.c (captured_main_1): Disable styling in batch mode.
9662
9663 2019-02-20  Tom Tromey  <tom@tromey.com>
9664
9665         * symtab.c (symtab_symbol_info): Fix typos.
9666
9667 2019-02-20  Tom Tromey  <tromey@adacore.com>
9668
9669         * findcmd.c (_initialize_mem_search): Use upper case for
9670         metasyntactic variables.
9671
9672 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
9673
9674         * aarch64-tdep.c (aarch64_add_reggroups): New function.
9675         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
9676
9677 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
9678
9679         * top.h (source_file_name): Change to std::string.
9680         * top.c (source_file_name): Likewise.
9681         (command_line_input): Adjust.
9682         * cli/cli-script.c (script_from_file): Adjust.
9683
9684 2019-02-19  Tom Tromey  <tromey@adacore.com>
9685
9686         * ravenscar-thread.c
9687         (ravenscar_thread_target::update_thread_list): Don't call
9688         ada_build_task_list.
9689         * ada-lang.h (ada_build_task_list): Don't declare.
9690         * ada-tasks.c (struct ada_tasks_inferior_data)
9691         <task_list_valid_p>: Now bool.
9692         (read_known_tasks, ada_task_list_changed)
9693         (ada_tasks_invalidate_inferior_data): Update.
9694         (read_known_tasks_array): Return bool.
9695         (read_known_tasks_list): Likewise.
9696         (read_known_tasks): Return void.
9697         (ada_build_task_list): Now static.
9698
9699 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
9700
9701         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
9702         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
9703
9704 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9705
9706         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
9707         variant for ada_tasks_pspace_data_handle and
9708         ada_tasks_inferior_data_handle.
9709         (ada_tasks_pspace_data_cleanup): New function.
9710         (ada_tasks_inferior_data_cleanup): New function.
9711
9712 2019-02-17  Tom Tromey  <tom@tromey.com>
9713
9714         * macrotab.h (macro_source_fullname): Return a std::string.
9715         * macrotab.c (macro_include, check_for_redefinition)
9716         (macro_undef, macro_lookup_definition, foreach_macro)
9717         (foreach_macro_in_scope): Update.
9718         (macro_source_fullname): Return a std::string.
9719         * macrocmd.c (show_pp_source_pos): Update.
9720
9721 2019-02-17  Tom Tromey  <tom@tromey.com>
9722
9723         * macrocmd.c (show_pp_source_pos): Style the file names.
9724
9725 2019-02-17  Tom Tromey  <tom@tromey.com>
9726
9727         PR tui/24197:
9728         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
9729
9730 2019-02-17  Tom Tromey  <tom@tromey.com>
9731
9732         * ada-lang.c (user_select_syms): Use filtered printing.
9733         * utils.c (wrap_style): New global.
9734         (desired_style): Remove.
9735         (emit_style_escape): Add stream parameter.
9736         (set_output_style, reset_terminal_style, prompt_for_continue):
9737         Update.
9738         (flush_wrap_buffer): Only flush gdb_stdout.
9739         (wrap_here): Set wrap_style.
9740         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
9741         treat escape sequences as a character.  Change when wrap buffer is
9742         flushed.
9743         (fputs_styled): Do not set the output style when the default is
9744         requested.
9745         * ui-style.h (struct ui_file_style) <is_default>: New method.
9746         * source.c (print_source_lines_base): Emit escape sequences in one
9747         piece.
9748
9749 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
9750
9751         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
9752         integers and enumeration types.
9753
9754 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
9755
9756         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
9757         instead of lookup_symbol_in_language
9758         (do_exact_match): New function.
9759         (ada_get_symbol_name_matcher): Return do_exact_match when
9760         doing a verbatim match.
9761
9762 2019-02-15  Tom Tromey  <tromey@adacore.com>
9763
9764         * ravenscar-thread.c (ravenscar_thread_target::resume)
9765         (ravenscar_thread_target::wait): Special case wildcard requests.
9766
9767 2019-02-15  Tom Tromey  <tromey@adacore.com>
9768
9769         * ravenscar-thread.c (base_ptid): Remove.
9770         (struct ravenscar_thread_target) <close>: New method.
9771         <m_base_ptid>: New member.
9772         <update_inferior_ptid, active_task, task_is_currently_active,
9773         runtime_initialized>: Declare methods.
9774         <ravenscar_thread_target>: Add constructor.
9775         (ravenscar_thread_target::task_is_currently_active)
9776         (ravenscar_thread_target::update_inferior_ptid)
9777         (ravenscar_runtime_initialized): Rename.  Now methods.
9778         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
9779         (ravenscar_thread_target::update_thread_list): Update.
9780         (ravenscar_thread_target::active_task): Now method.
9781         (ravenscar_thread_target::store_registers)
9782         (ravenscar_thread_target::prepare_to_store)
9783         (ravenscar_thread_target::prepare_to_store)
9784         (ravenscar_thread_target::mourn_inferior): Update.
9785         (ravenscar_inferior_created): Use "new" to create target.
9786         (ravenscar_thread_target::get_ada_task_ptid): Update.
9787         (_initialize_ravenscar): Don't initialize base_ptid.
9788         (ravenscar_ops): Remove global.
9789
9790 2019-02-15  Tom Tromey  <tromey@adacore.com>
9791
9792         * target.h (push_target): Declare new overload.
9793         * target.c (push_target): New overload, taking an rvalue reference.
9794         * remote.c (remote_target::open_1): Use push_target overload.
9795         * corelow.c (core_target_open): Use push_target overload.
9796
9797 2019-02-15  Tom Tromey  <tromey@adacore.com>
9798
9799         * ravenscar-thread.c (is_ravenscar_task)
9800         (ravenscar_task_is_currently_active): Return bool.
9801         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
9802         (_initialize_ravenscar): Remove "(void)".
9803         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
9804         Return bool.
9805
9806 2019-02-15  Tom Tromey  <tromey@adacore.com>
9807
9808         * ravenscar-thread.c (ravenscar_runtime_initializer)
9809         (has_ravenscar_runtime, get_running_thread_id)
9810         (ravenscar_thread_target::resume): Fix indentation.
9811
9812 2019-02-15  Tom Tromey  <tromey@adacore.com>
9813
9814         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
9815         from ravenscar_arch_ops.
9816         (sparc_ravenscar_ops::fetch_registers)
9817         (sparc_ravenscar_ops::store_registers): Now methods.
9818         (sparc_ravenscar_prepare_to_store): Remove.
9819         (sparc_ravenscar_ops): Redefine.
9820         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
9821         methods and destructor.  Remove members.
9822         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
9823         (ravenscar_thread_target::store_registers)
9824         (ravenscar_thread_target::prepare_to_store): Update.
9825         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
9826         Remove.
9827         (struct ppc_ravenscar_powerpc_ops): Derive from
9828         ravenscar_arch_ops.
9829         (ppc_ravenscar_powerpc_ops::fetch_registers)
9830         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
9831         (ppc_ravenscar_powerpc_ops): Redefine.
9832         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
9833         (ppc_ravenscar_e500_ops::fetch_registers)
9834         (ppc_ravenscar_e500_ops::store_registers): Now methods.
9835         (ppc_ravenscar_e500_ops): Redefine.
9836         * aarch64-ravenscar-thread.c
9837         (aarch64_ravenscar_generic_prepare_to_store): Remove.
9838         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
9839         (aarch64_ravenscar_fetch_registers)
9840         (aarch64_ravenscar_store_registers): Now methods.
9841         (aarch64_ravenscar_ops): Redefine.
9842
9843 2019-02-15  Tom Tromey  <tromey@adacore.com>
9844
9845         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
9846         (ravenscar_thread_target::stopped_by_hw_breakpoint)
9847         (ravenscar_thread_target::stopped_by_watchpoint)
9848         (ravenscar_thread_target::stopped_data_address)
9849         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
9850
9851 2019-02-15  Tom Tromey  <tromey@adacore.com>
9852
9853         * ravenscar-thread.c: Fix some typos.
9854
9855 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9856             Tom Tromey  <tromey@adacore.com>
9857
9858         * ada-lang.c (ada_exception_sal): Change addr_string to a
9859         std::string.
9860         (create_ada_exception_catchpoint): Update.
9861
9862 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9863             Tom Tromey  <tromey@adacore.com>
9864
9865         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
9866         (bp_location_ops): Remove.
9867         (base_breakpoint_allocate_location): Update.
9868         (free_bp_location): Update.
9869         * ada-lang.c (class ada_catchpoint_location)
9870         <ada_catchpoint_location>: Remove ops parameter.
9871         (ada_catchpoint_location_dtor): Remove.
9872         (ada_catchpoint_location_ops): Remove.
9873         (allocate_location_exception): Update.
9874         * breakpoint.h (struct bp_location_ops): Remove.
9875         (class bp_location) <bp_location>: Remove bp_location_ops
9876         parameter.
9877         <~bp_location>: Add destructor.
9878         <ops>: Remove.
9879
9880 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
9881             Pedro Alves  <palves@redhat.com>
9882
9883         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
9884         'PATH_MAX'.
9885
9886 2019-02-14  David Michael  <fedora.dm0@gmail.com>
9887             Samuel Thibault  <samuel.thibault@gnu.org>
9888             Thomas Schwinge  <thomas@codesourcery.com>
9889
9890         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
9891         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
9892
9893 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
9894
9895         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
9896         (check_empty): Use "const char *".
9897
9898         * gnu-nat.c (gnu_nat_target::detach): Instead of
9899         'detach_inferior (pid)' call
9900         'detach_inferior (find_inferior_pid (pid))'.
9901
9902         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
9903         'nat/fork-inferior.o'.
9904         * gnu-nat.c: #include "nat/fork-inferior.h".
9905
9906         * gnu-nat.c (gnu_nat_target::detach): Instead of
9907         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
9908         * gnu-nat.h: #include "inf-child.h".
9909         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
9910         'i386_gnu_nat_target::fetch_registers'.
9911         (gnu_store_registers): Rename/move to
9912         'i386_gnu_nat_target::store_registers'.
9913
9914         * config/i386/nm-i386gnu.h: Don't "#include" any files.
9915         * gnu-nat.h (mach_thread_info): New function.
9916         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
9917
9918         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
9919
9920 2019-02-14  Frederic Konrad  <konrad@adacore.com>
9921
9922         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
9923
9924 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
9925
9926         * windows-nat.c (windows_add_thread): Add new parameter
9927         "main_thread_p" with default value set to false.  Update
9928         function documentation as well as all callers.
9929         (windows_delete_thread): Likewise.
9930         (fake_create_process): Update call to windows_add_thread.
9931         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
9932         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
9933         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
9934         call to windows_delete_thread.
9935
9936 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
9937
9938         * MAINTAINERS: Add Andrew Burgess as global maintainer.
9939
9940 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9941
9942         * symfile.c (find_separate_debug_file): Use canonical path of
9943         sysroot with child_path instead of gdb_sysroot if it is valid.
9944
9945 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9946
9947         * symfile.c (find_separate_debug_file): Use child_path to
9948         determine if an object file is under a sysroot.
9949
9950 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9951
9952         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
9953         unittests/child-path-selftests.c.
9954         * common/pathstuff.c (child_path): New function.
9955         * common/pathstuff.h (child_path): New prototype.
9956         * unittests/child-path-selftests.c: New file.
9957
9958 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9959
9960         * symfile.c (find_separate_debug_file): Look for separate debug
9961         files in debug directories under the sysroot.
9962
9963 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9964
9965         * symtab.h (struct minimal_symbol data_p): New const method.
9966         (struct minimal_symbol text_p): Likewise.
9967         * symtab.c (output_source_filename): Use file name style
9968         to print file name.
9969         (print_symbol_info): Likewise.
9970         (print_msymbol_info): Use address style to print addresses.
9971         Use function name style to print executable text symbols.
9972         (expand_symtab_containing_pc): Use data_p.
9973         (find_pc_sect_compunit_symtab): Likewise.
9974
9975 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9976
9977         * breakpoint.c (describe_other_breakpoints): Use address style
9978         to print addresses.
9979         (say_where): Likewise.
9980
9981 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9982
9983         * ada-typeprint.c (print_func_type): Print function name
9984         style to print function name.
9985         * c-typeprint.c (c_print_type_1): Likewise.
9986
9987 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
9988
9989         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
9990         for execve.
9991
9992 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9993
9994         * c-exp.y (direct_abs_decl): Use emplace_back to record the
9995         type_stack.
9996
9997 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
9998
9999         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
10000         TYPE_CODE_REF types.
10001
10002 2019-02-08  Jim Wilson  <jimw@sifive.com>
10003
10004         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
10005         (riscv_linux_fregset): New.
10006         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
10007
10008 2019-02-07  Tom Tromey  <tom@tromey.com>
10009
10010         * thread.c (thread_cancel_execution_command): Update.
10011         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
10012         methods.
10013         (struct thread_fsm_ops): Remove.
10014         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
10015         (thread_fsm_should_stop, thread_fsm_return_value)
10016         (thread_fsm_set_finished, thread_fsm_finished_p)
10017         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
10018         Don't declare.
10019         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
10020         * infrun.c (clear_proceed_status_thread)
10021         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
10022         (print_stop_event): Update.
10023         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
10024         Add constructor.
10025         (step_command_fsm_ops): Remove.
10026         (new_step_command_fsm): Remove.
10027         (step_1): Update.
10028         (step_command_fsm::should_stop): Rename from
10029         step_command_fsm_should_stop.
10030         (step_command_fsm::clean_up): Rename from
10031         step_command_fsm_clean_up.
10032         (step_command_fsm::do_async_reply_reason): Rename from
10033         step_command_fsm_async_reply_reason.
10034         (struct until_next_fsm): Inherit from thread_fsm.  Add
10035         constructor.
10036         (until_next_fsm_ops): Remove.
10037         (new_until_next_fsm): Remove.
10038         (until_next_fsm::should_stop): Rename from
10039         until_next_fsm_should_stop.
10040         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
10041         (until_next_fsm::do_async_reply_reason): Rename from
10042         until_next_fsm_async_reply_reason.
10043         (struct finish_command_fsm): Inherit from thread_fsm.  Add
10044         constructor.  Change type of breakpoint.
10045         (finish_command_fsm_ops): Remove.
10046         (new_finish_command_fsm): Remove.
10047         (finish_command_fsm::should_stop): Rename from
10048         finish_command_fsm_should_stop.
10049         (finish_command_fsm::clean_up): Rename from
10050         finish_command_fsm_clean_up.
10051         (finish_command_fsm::return_value): Rename from
10052         finish_command_fsm_return_value.
10053         (finish_command_fsm::do_async_reply_reason): Rename from
10054         finish_command_fsm_async_reply_reason.
10055         (finish_command): Update.
10056         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
10057         Add constructor.
10058         (call_thread_fsm_ops): Remove.
10059         (call_thread_fsm::call_thread_fsm): Rename from
10060         new_call_thread_fsm.
10061         (call_thread_fsm::should_stop): Rename from
10062         call_thread_fsm_should_stop.
10063         (call_thread_fsm::should_notify_stop): Rename from
10064         call_thread_fsm_should_notify_stop.
10065         (run_inferior_call, call_function_by_hand_dummy): Update.
10066         * cli/cli-interp.c (should_print_stop_to_console): Update.
10067         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
10068         Add constructor.  Change type of location_breakpoint,
10069         caller_breakpoint.
10070         (until_break_fsm_ops): Remove.
10071         (new_until_break_fsm): Remove.
10072         (until_break_fsm::should_stop): Rename from
10073         until_break_fsm_should_stop.
10074         (until_break_fsm::clean_up): Rename from
10075         until_break_fsm_clean_up.
10076         (until_break_fsm::do_async_reply_reason): Rename from
10077         until_break_fsm_async_reply_reason.
10078         (until_break_command): Update.
10079         * thread-fsm.c: Remove.
10080         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
10081
10082 2019-02-07  Tom Tromey  <tom@tromey.com>
10083
10084         * yy-remap.h: Add include guard.
10085         * xtensa-tdep.h: Add include guard.
10086         * xcoffread.h: Rename include guard.
10087         * varobj-iter.h: Add include guard.
10088         * tui/tui.h: Rename include guard.
10089         * tui/tui-winsource.h: Rename include guard.
10090         * tui/tui-wingeneral.h: Rename include guard.
10091         * tui/tui-windata.h: Rename include guard.
10092         * tui/tui-win.h: Rename include guard.
10093         * tui/tui-stack.h: Rename include guard.
10094         * tui/tui-source.h: Rename include guard.
10095         * tui/tui-regs.h: Rename include guard.
10096         * tui/tui-out.h: Rename include guard.
10097         * tui/tui-layout.h: Rename include guard.
10098         * tui/tui-io.h: Rename include guard.
10099         * tui/tui-hooks.h: Rename include guard.
10100         * tui/tui-file.h: Rename include guard.
10101         * tui/tui-disasm.h: Rename include guard.
10102         * tui/tui-data.h: Rename include guard.
10103         * tui/tui-command.h: Rename include guard.
10104         * tic6x-tdep.h: Add include guard.
10105         * target/waitstatus.h: Rename include guard.
10106         * target/wait.h: Rename include guard.
10107         * target/target.h: Rename include guard.
10108         * target/resume.h: Rename include guard.
10109         * target-float.h: Rename include guard.
10110         * stabsread.h: Add include guard.
10111         * rs6000-tdep.h: Add include guard.
10112         * riscv-fbsd-tdep.h: Add include guard.
10113         * regformats/regdef.h: Rename include guard.
10114         * record.h: Rename include guard.
10115         * python/python.h: Rename include guard.
10116         * python/python-internal.h: Rename include guard.
10117         * python/py-stopevent.h: Rename include guard.
10118         * python/py-ref.h: Rename include guard.
10119         * python/py-record.h: Rename include guard.
10120         * python/py-record-full.h: Rename include guard.
10121         * python/py-record-btrace.h: Rename include guard.
10122         * python/py-instruction.h: Rename include guard.
10123         * python/py-events.h: Rename include guard.
10124         * python/py-event.h: Rename include guard.
10125         * procfs.h: Add include guard.
10126         * proc-utils.h: Add include guard.
10127         * p-lang.h: Add include guard.
10128         * or1k-tdep.h: Rename include guard.
10129         * observable.h: Rename include guard.
10130         * nto-tdep.h: Rename include guard.
10131         * nat/x86-linux.h: Rename include guard.
10132         * nat/x86-linux-dregs.h: Rename include guard.
10133         * nat/x86-gcc-cpuid.h: Add include guard.
10134         * nat/x86-dregs.h: Rename include guard.
10135         * nat/x86-cpuid.h: Rename include guard.
10136         * nat/ppc-linux.h: Rename include guard.
10137         * nat/mips-linux-watch.h: Rename include guard.
10138         * nat/linux-waitpid.h: Rename include guard.
10139         * nat/linux-ptrace.h: Rename include guard.
10140         * nat/linux-procfs.h: Rename include guard.
10141         * nat/linux-osdata.h: Rename include guard.
10142         * nat/linux-nat.h: Rename include guard.
10143         * nat/linux-namespaces.h: Rename include guard.
10144         * nat/linux-btrace.h: Rename include guard.
10145         * nat/glibc_thread_db.h: Rename include guard.
10146         * nat/gdb_thread_db.h: Rename include guard.
10147         * nat/gdb_ptrace.h: Rename include guard.
10148         * nat/fork-inferior.h: Rename include guard.
10149         * nat/amd64-linux-siginfo.h: Rename include guard.
10150         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
10151         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
10152         * nat/aarch64-linux.h: Rename include guard.
10153         * nat/aarch64-linux-hw-point.h: Rename include guard.
10154         * mn10300-tdep.h: Add include guard.
10155         * mips-linux-tdep.h: Add include guard.
10156         * mi/mi-parse.h: Rename include guard.
10157         * mi/mi-out.h: Rename include guard.
10158         * mi/mi-main.h: Rename include guard.
10159         * mi/mi-interp.h: Rename include guard.
10160         * mi/mi-getopt.h: Rename include guard.
10161         * mi/mi-console.h: Rename include guard.
10162         * mi/mi-common.h: Rename include guard.
10163         * mi/mi-cmds.h: Rename include guard.
10164         * mi/mi-cmd-break.h: Rename include guard.
10165         * m2-lang.h: Add include guard.
10166         * location.h: Rename include guard.
10167         * linux-record.h: Rename include guard.
10168         * linux-nat.h: Add include guard.
10169         * linux-fork.h: Add include guard.
10170         * i386-darwin-tdep.h: Rename include guard.
10171         * hppa-linux-offsets.h: Add include guard.
10172         * guile/guile.h: Rename include guard.
10173         * guile/guile-internal.h: Rename include guard.
10174         * gnu-nat.h: Rename include guard.
10175         * gdb-stabs.h: Rename include guard.
10176         * frv-tdep.h: Add include guard.
10177         * f-lang.h: Add include guard.
10178         * event-loop.h: Add include guard.
10179         * darwin-nat.h: Rename include guard.
10180         * cp-abi.h: Rename include guard.
10181         * config/sparc/nm-sol2.h: Rename include guard.
10182         * config/nm-nto.h: Rename include guard.
10183         * config/nm-linux.h: Add include guard.
10184         * config/i386/nm-i386gnu.h: Rename include guard.
10185         * config/djgpp/nl_types.h: Rename include guard.
10186         * config/djgpp/langinfo.h: Rename include guard.
10187         * compile/gcc-cp-plugin.h: Add include guard.
10188         * compile/gcc-c-plugin.h: Add include guard.
10189         * compile/compile.h: Rename include guard.
10190         * compile/compile-object-run.h: Rename include guard.
10191         * compile/compile-object-load.h: Rename include guard.
10192         * compile/compile-internal.h: Rename include guard.
10193         * compile/compile-cplus.h: Rename include guard.
10194         * compile/compile-c.h: Rename include guard.
10195         * common/xml-utils.h: Rename include guard.
10196         * common/x86-xstate.h: Rename include guard.
10197         * common/version.h: Rename include guard.
10198         * common/vec.h: Rename include guard.
10199         * common/tdesc.h: Rename include guard.
10200         * common/selftest.h: Rename include guard.
10201         * common/scoped_restore.h: Rename include guard.
10202         * common/scoped_mmap.h: Rename include guard.
10203         * common/scoped_fd.h: Rename include guard.
10204         * common/safe-iterator.h: Rename include guard.
10205         * common/run-time-clock.h: Rename include guard.
10206         * common/refcounted-object.h: Rename include guard.
10207         * common/queue.h: Rename include guard.
10208         * common/ptid.h: Rename include guard.
10209         * common/print-utils.h: Rename include guard.
10210         * common/preprocessor.h: Rename include guard.
10211         * common/pathstuff.h: Rename include guard.
10212         * common/observable.h: Rename include guard.
10213         * common/netstuff.h: Rename include guard.
10214         * common/job-control.h: Rename include guard.
10215         * common/host-defs.h: Rename include guard.
10216         * common/gdb_wait.h: Rename include guard.
10217         * common/gdb_vecs.h: Rename include guard.
10218         * common/gdb_unlinker.h: Rename include guard.
10219         * common/gdb_unique_ptr.h: Rename include guard.
10220         * common/gdb_tilde_expand.h: Rename include guard.
10221         * common/gdb_sys_time.h: Rename include guard.
10222         * common/gdb_string_view.h: Rename include guard.
10223         * common/gdb_splay_tree.h: Rename include guard.
10224         * common/gdb_setjmp.h: Rename include guard.
10225         * common/gdb_ref_ptr.h: Rename include guard.
10226         * common/gdb_optional.h: Rename include guard.
10227         * common/gdb_locale.h: Rename include guard.
10228         * common/gdb_assert.h: Rename include guard.
10229         * common/filtered-iterator.h: Rename include guard.
10230         * common/filestuff.h: Rename include guard.
10231         * common/fileio.h: Rename include guard.
10232         * common/environ.h: Rename include guard.
10233         * common/common-utils.h: Rename include guard.
10234         * common/common-types.h: Rename include guard.
10235         * common/common-regcache.h: Rename include guard.
10236         * common/common-inferior.h: Rename include guard.
10237         * common/common-gdbthread.h: Rename include guard.
10238         * common/common-exceptions.h: Rename include guard.
10239         * common/common-defs.h: Rename include guard.
10240         * common/common-debug.h: Rename include guard.
10241         * common/cleanups.h: Rename include guard.
10242         * common/buffer.h: Rename include guard.
10243         * common/btrace-common.h: Rename include guard.
10244         * common/break-common.h: Rename include guard.
10245         * cli/cli-utils.h: Rename include guard.
10246         * cli/cli-style.h: Rename include guard.
10247         * cli/cli-setshow.h: Rename include guard.
10248         * cli/cli-script.h: Rename include guard.
10249         * cli/cli-interp.h: Rename include guard.
10250         * cli/cli-decode.h: Rename include guard.
10251         * cli/cli-cmds.h: Rename include guard.
10252         * charset-list.h: Add include guard.
10253         * buildsym-legacy.h: Rename include guard.
10254         * bfin-tdep.h: Add include guard.
10255         * ax.h: Rename include guard.
10256         * arm-linux-tdep.h: Add include guard.
10257         * arm-fbsd-tdep.h: Add include guard.
10258         * arch/xtensa.h: Rename include guard.
10259         * arch/tic6x.h: Add include guard.
10260         * arch/i386.h: Add include guard.
10261         * arch/arm.h: Rename include guard.
10262         * arch/arm-linux.h: Rename include guard.
10263         * arch/arm-get-next-pcs.h: Rename include guard.
10264         * arch/amd64.h: Add include guard.
10265         * arch/aarch64-insn.h: Rename include guard.
10266         * arch-utils.h: Rename include guard.
10267         * annotate.h: Add include guard.
10268         * amd64-darwin-tdep.h: Rename include guard.
10269         * aarch64-linux-tdep.h: Add include guard.
10270         * aarch64-fbsd-tdep.h: Add include guard.
10271         * aarch32-linux-nat.h: Add include guard.
10272
10273 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10274
10275         * macrotab.c (macro_define_internal): New function that
10276         factorizes macro_define_object_internal and macro_define_function
10277         code.
10278         (macro_define_object_internal): Use macro_define_internal.
10279         (macro_define_function): Likewise.
10280
10281 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10282
10283         * macrocmd.c (extract_identifier): Return
10284         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
10285         callers.
10286
10287 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
10288
10289         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
10290
10291 2019-02-05  Tom Tromey  <tom@tromey.com>
10292
10293         * target.c (target_stack::unpush): Move assertion earlier.
10294
10295 2019-01-30  Tom Tromey  <tom@tromey.com>
10296
10297         PR python/23615:
10298         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
10299         (gdbpy_parse_and_eval): Likewise.
10300         * python/python-internal.h (gdbpy_allow_threads): New class.
10301
10302 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
10303
10304         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
10305         (aarch64_fbsd_fpregmap): Move earlier.
10306         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
10307         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
10308         instead of individual calls to trad_frame_set_reg_addr.
10309         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
10310         earlier.
10311         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
10312         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
10313         instead of individual calls to trad_frame_set_reg_addr.
10314
10315 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
10316
10317         * CONTRIBUTE: Replace contribution list with wiki link.
10318
10319 2019-01-25  Tom Tromey  <tom@tromey.com>
10320
10321         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
10322
10323 2019-01-25  Tom Tromey  <tom@tromey.com>
10324
10325         * xtensa-linux-nat.c: Fix common/ includes.
10326         * xml-support.h: Fix common/ includes.
10327         * xml-support.c: Fix common/ includes.
10328         * x86-linux-nat.c: Fix common/ includes.
10329         * windows-nat.c: Fix common/ includes.
10330         * varobj.h: Fix common/ includes.
10331         * varobj.c: Fix common/ includes.
10332         * value.c: Fix common/ includes.
10333         * valops.c: Fix common/ includes.
10334         * utils.c: Fix common/ includes.
10335         * unittests/xml-utils-selftests.c: Fix common/ includes.
10336         * unittests/utils-selftests.c: Fix common/ includes.
10337         * unittests/unpack-selftests.c: Fix common/ includes.
10338         * unittests/tracepoint-selftests.c: Fix common/ includes.
10339         * unittests/style-selftests.c: Fix common/ includes.
10340         * unittests/string_view-selftests.c: Fix common/ includes.
10341         * unittests/scoped_restore-selftests.c: Fix common/ includes.
10342         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
10343         * unittests/scoped_fd-selftests.c: Fix common/ includes.
10344         * unittests/rsp-low-selftests.c: Fix common/ includes.
10345         * unittests/parse-connection-spec-selftests.c: Fix common/
10346         includes.
10347         * unittests/optional-selftests.c: Fix common/ includes.
10348         * unittests/offset-type-selftests.c: Fix common/ includes.
10349         * unittests/observable-selftests.c: Fix common/ includes.
10350         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
10351         * unittests/memrange-selftests.c: Fix common/ includes.
10352         * unittests/memory-map-selftests.c: Fix common/ includes.
10353         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
10354         * unittests/function-view-selftests.c: Fix common/ includes.
10355         * unittests/environ-selftests.c: Fix common/ includes.
10356         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
10357         * unittests/common-utils-selftests.c: Fix common/ includes.
10358         * unittests/cli-utils-selftests.c: Fix common/ includes.
10359         * unittests/array-view-selftests.c: Fix common/ includes.
10360         * ui-file.c: Fix common/ includes.
10361         * tui/tui-io.c: Fix common/ includes.
10362         * tracepoint.h: Fix common/ includes.
10363         * tracepoint.c: Fix common/ includes.
10364         * tracefile-tfile.c: Fix common/ includes.
10365         * top.h: Fix common/ includes.
10366         * top.c: Fix common/ includes.
10367         * thread.c: Fix common/ includes.
10368         * target/waitstatus.h: Fix common/ includes.
10369         * target/waitstatus.c: Fix common/ includes.
10370         * target.h: Fix common/ includes.
10371         * target.c: Fix common/ includes.
10372         * target-memory.c: Fix common/ includes.
10373         * target-descriptions.c: Fix common/ includes.
10374         * symtab.h: Fix common/ includes.
10375         * symfile.c: Fix common/ includes.
10376         * stap-probe.c: Fix common/ includes.
10377         * spu-linux-nat.c: Fix common/ includes.
10378         * sparc-nat.c: Fix common/ includes.
10379         * source.c: Fix common/ includes.
10380         * solib.c: Fix common/ includes.
10381         * solib-target.c: Fix common/ includes.
10382         * ser-unix.c: Fix common/ includes.
10383         * ser-tcp.c: Fix common/ includes.
10384         * ser-pipe.c: Fix common/ includes.
10385         * ser-base.c: Fix common/ includes.
10386         * selftest-arch.c: Fix common/ includes.
10387         * s12z-tdep.c: Fix common/ includes.
10388         * rust-exp.y: Fix common/ includes.
10389         * rs6000-aix-tdep.c: Fix common/ includes.
10390         * riscv-tdep.c: Fix common/ includes.
10391         * remote.c: Fix common/ includes.
10392         * remote-notif.h: Fix common/ includes.
10393         * remote-fileio.h: Fix common/ includes.
10394         * remote-fileio.c: Fix common/ includes.
10395         * regcache.h: Fix common/ includes.
10396         * regcache.c: Fix common/ includes.
10397         * record-btrace.c: Fix common/ includes.
10398         * python/python.c: Fix common/ includes.
10399         * python/py-type.c: Fix common/ includes.
10400         * python/py-inferior.c: Fix common/ includes.
10401         * progspace.h: Fix common/ includes.
10402         * producer.c: Fix common/ includes.
10403         * procfs.c: Fix common/ includes.
10404         * proc-api.c: Fix common/ includes.
10405         * printcmd.c: Fix common/ includes.
10406         * ppc-linux-nat.c: Fix common/ includes.
10407         * parser-defs.h: Fix common/ includes.
10408         * osdata.c: Fix common/ includes.
10409         * obsd-nat.c: Fix common/ includes.
10410         * nat/x86-linux.c: Fix common/ includes.
10411         * nat/x86-linux-dregs.c: Fix common/ includes.
10412         * nat/x86-dregs.h: Fix common/ includes.
10413         * nat/x86-dregs.c: Fix common/ includes.
10414         * nat/ppc-linux.c: Fix common/ includes.
10415         * nat/mips-linux-watch.h: Fix common/ includes.
10416         * nat/mips-linux-watch.c: Fix common/ includes.
10417         * nat/linux-waitpid.c: Fix common/ includes.
10418         * nat/linux-ptrace.h: Fix common/ includes.
10419         * nat/linux-ptrace.c: Fix common/ includes.
10420         * nat/linux-procfs.c: Fix common/ includes.
10421         * nat/linux-personality.c: Fix common/ includes.
10422         * nat/linux-osdata.c: Fix common/ includes.
10423         * nat/linux-namespaces.c: Fix common/ includes.
10424         * nat/linux-btrace.h: Fix common/ includes.
10425         * nat/linux-btrace.c: Fix common/ includes.
10426         * nat/fork-inferior.c: Fix common/ includes.
10427         * nat/amd64-linux-siginfo.c: Fix common/ includes.
10428         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
10429         * nat/aarch64-linux.c: Fix common/ includes.
10430         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
10431         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
10432         * namespace.h: Fix common/ includes.
10433         * mips-linux-tdep.c: Fix common/ includes.
10434         * minsyms.c: Fix common/ includes.
10435         * mi/mi-parse.h: Fix common/ includes.
10436         * mi/mi-main.c: Fix common/ includes.
10437         * mi/mi-cmd-env.c: Fix common/ includes.
10438         * memrange.h: Fix common/ includes.
10439         * memattr.c: Fix common/ includes.
10440         * maint.h: Fix common/ includes.
10441         * maint.c: Fix common/ includes.
10442         * main.c: Fix common/ includes.
10443         * machoread.c: Fix common/ includes.
10444         * location.c: Fix common/ includes.
10445         * linux-thread-db.c: Fix common/ includes.
10446         * linux-nat.c: Fix common/ includes.
10447         * linux-fork.c: Fix common/ includes.
10448         * inline-frame.c: Fix common/ includes.
10449         * infrun.c: Fix common/ includes.
10450         * inflow.c: Fix common/ includes.
10451         * inferior.h: Fix common/ includes.
10452         * inferior.c: Fix common/ includes.
10453         * infcmd.c: Fix common/ includes.
10454         * inf-ptrace.c: Fix common/ includes.
10455         * inf-child.c: Fix common/ includes.
10456         * ia64-linux-nat.c: Fix common/ includes.
10457         * i387-tdep.c: Fix common/ includes.
10458         * i386-tdep.c: Fix common/ includes.
10459         * i386-linux-tdep.c: Fix common/ includes.
10460         * i386-linux-nat.c: Fix common/ includes.
10461         * i386-go32-tdep.c: Fix common/ includes.
10462         * i386-fbsd-tdep.c: Fix common/ includes.
10463         * i386-fbsd-nat.c: Fix common/ includes.
10464         * guile/scm-type.c: Fix common/ includes.
10465         * guile/guile.c: Fix common/ includes.
10466         * go32-nat.c: Fix common/ includes.
10467         * gnu-nat.c: Fix common/ includes.
10468         * gdbthread.h: Fix common/ includes.
10469         * gdbarch-selftests.c: Fix common/ includes.
10470         * gdb_usleep.c: Fix common/ includes.
10471         * gdb_select.h: Fix common/ includes.
10472         * gdb_bfd.c: Fix common/ includes.
10473         * gcore.c: Fix common/ includes.
10474         * fork-child.c: Fix common/ includes.
10475         * findvar.c: Fix common/ includes.
10476         * fbsd-nat.c: Fix common/ includes.
10477         * event-top.c: Fix common/ includes.
10478         * event-loop.c: Fix common/ includes.
10479         * dwarf2read.c: Fix common/ includes.
10480         * dwarf2loc.c: Fix common/ includes.
10481         * dwarf2-frame.c: Fix common/ includes.
10482         * dwarf-index-cache.c: Fix common/ includes.
10483         * dtrace-probe.c: Fix common/ includes.
10484         * disasm-selftests.c: Fix common/ includes.
10485         * defs.h: Fix common/ includes.
10486         * csky-tdep.c: Fix common/ includes.
10487         * cp-valprint.c: Fix common/ includes.
10488         * cp-support.h: Fix common/ includes.
10489         * cp-support.c: Fix common/ includes.
10490         * corelow.c: Fix common/ includes.
10491         * completer.h: Fix common/ includes.
10492         * completer.c: Fix common/ includes.
10493         * compile/compile.c: Fix common/ includes.
10494         * compile/compile-loc2c.c: Fix common/ includes.
10495         * compile/compile-cplus-types.c: Fix common/ includes.
10496         * compile/compile-cplus-symbols.c: Fix common/ includes.
10497         * command.h: Fix common/ includes.
10498         * cli/cli-dump.c: Fix common/ includes.
10499         * cli/cli-cmds.c: Fix common/ includes.
10500         * charset.c: Fix common/ includes.
10501         * build-id.c: Fix common/ includes.
10502         * btrace.h: Fix common/ includes.
10503         * btrace.c: Fix common/ includes.
10504         * breakpoint.h: Fix common/ includes.
10505         * breakpoint.c: Fix common/ includes.
10506         * ax.h:
10507         (enum agent_op): Fix common/ includes.
10508         * ax-general.c (struct aop_map): Fix common/ includes.
10509         * ax-gdb.c: Fix common/ includes.
10510         * auxv.c: Fix common/ includes.
10511         * auto-load.c: Fix common/ includes.
10512         * arm-tdep.c: Fix common/ includes.
10513         * arch/riscv.c: Fix common/ includes.
10514         * arch/ppc-linux-common.c: Fix common/ includes.
10515         * arch/i386.c: Fix common/ includes.
10516         * arch/arm.c: Fix common/ includes.
10517         * arch/arm-linux.c: Fix common/ includes.
10518         * arch/arm-get-next-pcs.c: Fix common/ includes.
10519         * arch/amd64.c: Fix common/ includes.
10520         * arch/aarch64.c: Fix common/ includes.
10521         * arch/aarch64-insn.c: Fix common/ includes.
10522         * arch-utils.c: Fix common/ includes.
10523         * amd64-windows-tdep.c: Fix common/ includes.
10524         * amd64-tdep.c: Fix common/ includes.
10525         * amd64-sol2-tdep.c: Fix common/ includes.
10526         * amd64-obsd-tdep.c: Fix common/ includes.
10527         * amd64-nbsd-tdep.c: Fix common/ includes.
10528         * amd64-linux-tdep.c: Fix common/ includes.
10529         * amd64-linux-nat.c: Fix common/ includes.
10530         * amd64-fbsd-tdep.c: Fix common/ includes.
10531         * amd64-fbsd-nat.c: Fix common/ includes.
10532         * amd64-dicos-tdep.c: Fix common/ includes.
10533         * amd64-darwin-tdep.c: Fix common/ includes.
10534         * agent.c: Fix common/ includes.
10535         * ada-lang.h: Fix common/ includes.
10536         * ada-lang.c: Fix common/ includes.
10537         * aarch64-tdep.c: Fix common/ includes.
10538
10539 2019-01-25  Tom Tromey  <tom@tromey.com>
10540
10541         * common/create-version.sh: Use common/version.h.
10542
10543 2019-01-24  Pedro Alves  <palves@redhat.com>
10544
10545         * infrun.c (signal_stop, signal_print, signal_program)
10546         (signal_catch, signal_pass): Now arrays instead of pointers.
10547         (update_signals_program_target, do_target_resume)
10548         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
10549         * linux-nat.c (linux_nat_target::pass_signals)
10550         (linux_nat_target::create_inferior, linux_nat_target::attach):
10551         Adjust.
10552         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
10553         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
10554         * procfs.c (procfs_target::pass_signals): Adjust.
10555         * record-full.c (record_full_target::resume): Adjust.
10556         * remote.c (remote_target::pass_signals)
10557         (remote_target::program_signals): Adjust.
10558         * target-debug.h (target_debug_print_signals): Now takes a
10559         gdb::array_view as parameter.  Adjust.
10560         * target.h (target_ops) <pass_signals, program_signals>: Replace
10561         pointer and length parameters with gdb::array_view.
10562         (target_pass_signals, target_program_signals): Likewise.
10563         * target-delegates.c: Regenerate.
10564
10565 2019-01-24  Pedro Alves  <palves@redhat.com>
10566
10567         * common/forward-scope-exit.h
10568         (forward_scope_exit::forward_scope_exit): Pass arguments to
10569         m_bind_function directly, instead of creating a std::bind and
10570         copying that.
10571
10572 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
10573
10574         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
10575         for static members.
10576         (pass_in_v_vfp_candidate): Likewise.
10577
10578 2019-01-23  Tom Tromey  <tom@tromey.com>
10579             Pedro Alves  <palves@redhat.com>
10580
10581         * regcache.c (class regcache_invalidator): Remove.
10582         (regcache::raw_write): Use make_scope_exit.
10583
10584 2019-01-23  Tom Tromey  <tom@tromey.com>
10585
10586         * ui-out.h (class ui_out_emit_type): Update comment.
10587
10588 2019-01-23  Tom Tromey  <tom@tromey.com>
10589
10590         * infrun.c (fetch_inferior_event): Update comment.
10591
10592 2019-01-23  Tom Tromey  <tom@tromey.com>
10593             Pedro Alves  <palves@redhat.com>
10594
10595         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
10596         parameter.
10597         (fetch_inferior_event): Use SCOPE_EXIT.
10598
10599
10600 2019-01-23  Tom Tromey  <tom@tromey.com>
10601             Pedro Alves  <palves@redhat.com>
10602
10603         * infrun.c (disable_thread_events): Delete.
10604         (stop_all_threads): Use SCOPE_EXIT.
10605
10606 2019-01-23  Tom Tromey  <tom@tromey.com>
10607             Pedro Alves  <palves@redhat.com>
10608
10609         * symfile.c: Include forward-scope-exit.h.
10610         (clear_symtab_users_cleanup): Replace forward declaration with
10611         a FORWARD_SCOPE_EXIT.
10612         (syms_from_objfile_1): Use the forward_scope_exit and
10613         gdb::optional instead of cleanup_function.
10614         (reread_symbols): Use the forward_scope_exit instead of
10615         cleanup_function.
10616         (clear_symtab_users_cleanup): Remove function.
10617
10618 2019-01-23  Tom Tromey  <tom@tromey.com>
10619             Pedro Alves  <palves@redhat.com>
10620
10621         * linux-nat.c: Include scope-exit.h.
10622         (cleanup_target_stop): Remove.
10623         (linux_nat_target::static_tracepoint_markers_by_strid): Use
10624         SCOPE_EXIT.
10625
10626 2019-01-23  Tom Tromey  <tom@tromey.com>
10627             Pedro Alves  <palves@redhat.com>
10628
10629         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
10630         (call_function_by_hand_dummy): Use SCOPE_EXIT.
10631
10632 2019-01-23  Tom Tromey  <tom@tromey.com>
10633             Andrew Burgess  <andrew.burgess@embecosm.com>
10634             Pedro Alves  <palves@redhat.com>
10635
10636         * infrun.c (fetch_inferior_event): Use scope_exit.
10637         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
10638         * top.c (execute_command): Use scope_exit.
10639         * breakpoint.c (bpstat_do_actions): Use scope_exit.
10640         * utils.c (do_bpstat_clear_actions_cleanup)
10641         (make_bpstat_clear_actions_cleanup): Remove.
10642
10643 2019-01-23  Tom Tromey  <tom@tromey.com>
10644             Pedro Alves  <palves@redhat.com>
10645
10646         * infrun.c: Include "common/scope-exit.h"
10647         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
10648         (wait_for_inferior): Use SCOPE_EXIT.
10649         (fetch_inferior_event): Use scope_exit.
10650
10651 2019-01-23  Tom Tromey  <tom@tromey.com>
10652             Pedro Alves  <palves@redhat.com>
10653
10654         * breakpoint.c (create_breakpoint): Remove cleanup.
10655
10656 2019-01-23  Tom Tromey  <tom@tromey.com>
10657             Andrew Burgess  <andrew.burgess@embecosm.com>
10658             Pedro Alves  <palves@redhat.com>
10659
10660 2019-01-23  Pedro Alves  <palves@redhat.com>
10661
10662         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
10663
10664 2019-01-23  Pedro Alves  <palves@redhat.com>
10665             Andrew Burgess  <andrew.burgess@embecosm.com>
10666
10667         * gdbthread.h: Include "common/forward-scope-exit.h".
10668         (scoped_finish_thread_state): Redefine custom class in terms of
10669         forward_scope_exit.
10670
10671 2019-01-23  Pedro Alves  <palves@redhat.com>
10672             Andrew Burgess  <andrew.burgess@embecosm.com>
10673
10674         * common/forward-scope-exit.h: New file.
10675
10676 2019-01-23  Pedro Alves  <palves@redhat.com>
10677             Andrew Burgess  <andrew.burgess@embecosm.com>
10678             Tom Tromey  <tom@tromey.com>
10679
10680         * common/scope-exit.h: New file.
10681
10682 2019-01-23  Pedro Alves  <palves@redhat.com>
10683
10684         * common/preprocessor.h (ESC): Rename to ...
10685         (ESC_PARENS): ... this.
10686         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
10687         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
10688
10689 2019-01-23  Tom Tromey  <tom@tromey.com>
10690
10691         * language.h (class scoped_switch_to_sym_language_if_auto):
10692         Initialize m_lang in both cases.
10693
10694 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
10695
10696         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
10697         with XCNEW.
10698
10699 2019-01-22  Tom Tromey  <tom@tromey.com>
10700
10701         * corelow.c: Do not include sys/file.h.
10702
10703 2019-01-22  Tom Tromey  <tom@tromey.com>
10704
10705         * tui/tui-wingeneral.h: Include gdb_curses.h.
10706
10707 2019-01-22  Tom Tromey  <tom@tromey.com>
10708
10709         * source-cache.h (class source_cache) <get_source_lines,
10710         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
10711
10712 2019-01-22  Tom Tromey  <tom@tromey.com>
10713
10714         * remote-fileio.h (struct remote_target): Declare.
10715
10716 2019-01-22  Tom Tromey  <tom@tromey.com>
10717
10718         * python/py-arch.c: Do not include py-ref.h.
10719         * python/py-bpevent.c: Do not include py-ref.h.
10720         * python/py-cmd.c: Do not include py-ref.h.
10721         * python/py-continueevent.c: Do not include py-ref.h.
10722         * python/py-event.h: Do not include py-ref.h.
10723         * python/py-evtregistry.c: Do not include py-ref.h.
10724         * python/py-finishbreakpoint.c: Do not include py-ref.h.
10725         * python/py-frame.c: Do not include py-ref.h.
10726         * python/py-framefilter.c: Do not include py-ref.h.
10727         * python/py-function.c: Do not include py-ref.h.
10728         * python/py-infevents.c: Do not include py-ref.h.
10729         * python/py-linetable.c: Do not include py-ref.h.
10730         * python/py-objfile.c: Do not include py-ref.h.
10731         * python/py-param.c: Do not include py-ref.h.
10732         * python/py-prettyprint.c: Do not include py-ref.h.
10733         * python/py-progspace.c: Do not include py-ref.h.
10734         * python/py-symbol.c: Do not include py-ref.h.
10735         * python/py-symtab.c: Do not include py-ref.h.
10736         * python/py-type.c: Do not include py-ref.h.
10737         * python/py-unwind.c: Do not include py-ref.h.
10738         * python/py-utils.c: Do not include py-ref.h.
10739         * python/py-value.c: Do not include py-ref.h.
10740         * python/py-varobj.c: Do not include py-ref.h.
10741         * python/py-xmethods.c: Do not include py-ref.h.
10742         * python/python.c: Do not include py-ref.h.
10743         * varobj.c: Do not include py-ref.h.
10744
10745 2019-01-22  Tom Tromey  <tom@tromey.com>
10746
10747         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
10748         keyword for bcache.
10749
10750 2019-01-22  Tom Tromey  <tom@tromey.com>
10751
10752         * compile/compile-cplus-types.c: Remove a comment by #include.
10753
10754 2019-01-22  Tom Tromey  <tom@tromey.com>
10755
10756         * compile/gcc-c-plugin.h: Include compile-internal.h.
10757
10758 2019-01-22  Tom Tromey  <tom@tromey.com>
10759
10760         * stabsread.c (EXTERN): Do not define.
10761         (symnum, next_symbol_text_func, processing_gcc_compilation)
10762         (within_function, global_sym_chain, global_stabs)
10763         (previous_stab_code, this_object_header_files)
10764         (n_this_object_header_files)
10765         (n_allocated_this_object_header_files): Define.
10766         * stabsread.h (EXTERN): Never define.  Use "extern".
10767
10768 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10769
10770         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
10771         history_value.
10772
10773 2019-01-21  Tom Tromey  <tom@tromey.com>
10774
10775         * ui-out.c: Fix includes.
10776         * tui/tui-source.c: Fix includes.
10777         * target.c: Fix includes.
10778         * remote.c: Fix includes.
10779         * regcache.c: Fix includes.
10780         * python/py-block.c: Fix includes.
10781         * printcmd.c: Fix includes.
10782         * or1k-tdep.c: Fix includes.
10783         * mi/mi-main.c: Fix includes.
10784         * m32r-tdep.c: Fix includes.
10785         * csky-tdep.c: Fix includes.
10786         * compile/compile-cplus-types.c: Fix includes.
10787         * cli/cli-interp.c: Fix includes.
10788
10789 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
10790
10791         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
10792         for padding.
10793
10794 2019-01-16  Tom Tromey  <tom@tromey.com>
10795
10796         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
10797         earlier.
10798         (struct objfile) <msymbols_range>: Move from top level.
10799         <msymbols>: New method.
10800         (class objfile_msymbols): Remove.
10801         * symtab.c (default_collect_symbol_completion_matches_break_on):
10802         Update.
10803         * symmisc.c (dump_msymbols): Update.
10804         * stabsread.c (scan_file_globals): Update.
10805         * objc-lang.c (info_selectors_command, info_classes_command)
10806         (find_methods): Update.
10807         * minsyms.c (find_solib_trampoline_target): Update.
10808         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
10809         * coffread.c (coff_symfile_read): Update.
10810         * ada-lang.c (ada_lookup_simple_minsym)
10811         (ada_collect_symbol_completion_matches): Update.
10812
10813 2019-01-16  Tom Tromey  <tom@tromey.com>
10814
10815         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
10816         type.  Remove no-argument constructor.
10817         <iterator::operator++>: Simplify.
10818         <begin>: Update.
10819         <end>: Use minimal_symbol_count.
10820
10821 2019-01-16  Tom Tromey  <tom@tromey.com>
10822
10823         * objfiles.h (struct objfile) <psymtabs>: New method.
10824         (class objfile_psymtabs): Remove.
10825         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
10826         typedef.
10827         <range>: New method.
10828         (require_partial_symbols): Change return type.
10829         * psymtab.c (require_partial_symbols)
10830         (psym_expand_symtabs_matching): Update.
10831         * mdebugread.c (parse_partial_symbols): Update.
10832         * dbxread.c (dbx_end_psymtab): Update.
10833
10834 2019-01-15  Tom Tromey  <tom@tromey.com>
10835
10836         * symtab.c (lookup_objfile_from_block)
10837         (lookup_symbol_in_objfile_symtabs)
10838         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
10839         (find_line_symtab, info_sources_command)
10840         (default_collect_symbol_completion_matches_break_on)
10841         (make_source_files_completion_list): Update.
10842         * symmisc.c (print_objfile_statistics, dump_objfile)
10843         (maintenance_print_symbols, maintenance_info_symtabs)
10844         (maintenance_check_symtabs, maintenance_info_line_tables):
10845         Update.
10846         * source.c (select_source_symtab)
10847         (forget_cached_source_info_for_objfile): Update.
10848         * objfiles.h (class objfile_compunits): Remove.
10849         (struct objfile) <compunits_range>: New typedef.
10850         (compunits): New method.
10851         * objfiles.c (objfile_relocate1): Update.
10852         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
10853         * maint.c (count_symtabs_and_blocks): Update.
10854         * linespec.c (iterate_over_all_matching_symtabs): Update.
10855         * cp-support.c (add_symbol_overload_list_qualified): Update.
10856         * coffread.c (coff_symtab_read): Update.
10857         * ada-lang.c (add_nonlocal_symbols)
10858         (ada_collect_symbol_completion_matches)
10859         (ada_add_global_exceptions): Update.
10860
10861 2019-01-15  Tom Tromey  <tom@tromey.com>
10862
10863         * progspace.h (program_space) <objfiles_safe_range>: New
10864         typedef.
10865         <objfiles_safe>: New method.
10866         * objfiles.h (class all_objfiles_safe): Remove.
10867         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
10868         * jit.c (jit_inferior_exit_hook): Update.
10869
10870 2019-01-17  Tom Tromey  <tom@tromey.com>
10871
10872         * progspace.h (program_space) <objfiles_range>: New typedef.
10873         <objfiles>: New method.
10874         <objfiles_head>: Rename from objfiles.
10875         (object_files): Update.
10876         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
10877         * guile/scm-pretty-print.c
10878         (ppscm_find_pretty_printer_from_objfiles): Update.
10879         * guile/scm-objfile.c (gdbscm_objfiles): Update.
10880         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
10881         Update.
10882         * python/py-progspace.c (pspy_get_objfiles): Update.
10883         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
10884         Update.
10885         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
10886         (objfpy_lookup_objfile_by_build_id): Update.
10887         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
10888         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
10889         Update.
10890         * symtab.c (iterate_over_symtabs, matching_obj_sections)
10891         (expand_symtab_containing_pc, lookup_objfile_from_block)
10892         (lookup_static_symbol, basic_lookup_transparent_type)
10893         (find_pc_sect_compunit_symtab, find_symbol_at_address)
10894         (find_line_symtab, info_sources_command)
10895         (default_collect_symbol_completion_matches_break_on)
10896         (make_source_files_completion_list, find_main_name): Update.
10897         * symmisc.c (print_symbol_bcache_statistics)
10898         (print_objfile_statistics, maintenance_print_symbols)
10899         (maintenance_print_msymbols, maintenance_print_objfiles)
10900         (maintenance_info_symtabs, maintenance_check_symtabs)
10901         (maintenance_expand_symtabs, maintenance_info_line_tables):
10902         Update.
10903         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
10904         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
10905         (map_overlay_command, unmap_overlay_command)
10906         (simple_overlay_update, expand_symtabs_matching)
10907         (map_symbol_filenames): Update.
10908         * symfile-debug.c (set_debug_symfile): Update.
10909         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
10910         Update.
10911         * source.c (select_source_symtab, forget_cached_source_info):
10912         Update.
10913         * solib.c (solib_read_symbols): Update.
10914         * solib-spu.c (append_ocl_sos): Update.
10915         * psymtab.c (maintenance_print_psymbols)
10916         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
10917         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
10918         * printcmd.c (info_symbol_command): Update.
10919         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
10920         Update.
10921         * objfiles.h (class all_objfiles): Remove.
10922         * objfiles.c (have_partial_symbols, have_full_symbols)
10923         (have_minimal_symbols, qsort_cmp, update_section_map)
10924         (shared_objfile_contains_address_p)
10925         (default_iterate_over_objfiles_in_search_order): Update.
10926         * objc-lang.c (info_selectors_command, info_classes_command)
10927         (find_methods): Update.
10928         * minsyms.c (find_solib_trampoline_target): Update.
10929         * maint.c (maintenance_info_sections)
10930         (maintenance_translate_address, count_symtabs_and_blocks):
10931         Update.
10932         * main.c (captured_main_1): Update.
10933         * linux-thread-db.c (try_thread_db_load_from_pdir)
10934         (has_libpthread): Update.
10935         * linespec.c (iterate_over_all_matching_symtabs)
10936         (search_minsyms_for_name): Update.
10937         * jit.c (jit_find_objf_with_entry_addr): Update.
10938         * hppa-tdep.c (find_unwind_entry)
10939         (hppa_lookup_stub_minimal_symbol): Update.
10940         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
10941         Update.
10942         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
10943         (elf_gnu_ifunc_resolve_by_got): Update.
10944         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
10945         * dwarf-index-write.c (save_gdb_index_command): Update.
10946         * cp-support.c (add_symbol_overload_list_qualified): Update.
10947         * breakpoint.c (create_overlay_event_breakpoint)
10948         (create_longjmp_master_breakpoint)
10949         (create_std_terminate_master_breakpoint)
10950         (create_exception_master_breakpoint): Update.
10951         * blockframe.c (find_pc_partial_function): Update.
10952         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
10953         (ada_collect_symbol_completion_matches)
10954         (ada_add_global_exceptions): Update.
10955
10956 2019-01-17  Tom Tromey  <tom@tromey.com>
10957
10958         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
10959         declare VEC.
10960         (solib_target_parse_libraries): Change return type.
10961         (library_list_start_segment, library_list_start_section)
10962         (library_list_end_library, library_list_start_library); Update.
10963         (solib_target_free_library_list): Remove.
10964         (solib_target_parse_libraries): Remove cleanup.  Change return
10965         type.
10966         (solib_target_current_sos): Update.
10967
10968 2019-01-17  Tom Tromey  <tromey@bapiya>
10969
10970         * valprint.c: Replace "the the" with "the".
10971         * symtab.c: Replace "the the" with "the".
10972         * solib.c: Replace "the the" with "the".
10973         * solib-dsbt.c: Replace "the the" with "the".
10974         * linespec.c: Replace "the the" with "the".
10975         * dwarf2loc.h: Replace "the the" with "the".
10976         * amd64-windows-tdep.c: Replace "the the" with "the".
10977         * aarch64-tdep.c: Replace "the the" with "the".
10978
10979 2019-01-16  Keith Seitz  <keiths@redhat.com>
10980
10981         PR gdb/23773
10982         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
10983         <builder>: Rename to ..
10984         <m_builder>: ... this and make private.
10985         (dwarf2_cu::get_builder): New method.  Change all users of
10986         `builder' to use this method.
10987         (dwarf2_start_symtab): Move to ...
10988         (dwarf2_cu::start_symtab): ... here.  Update all callers
10989         (setup_type_unit_groups): Move to ...
10990         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
10991         callers.
10992         (dwarf2_cu::reset_builder): New method.
10993         (process_full_compunit, process_full_type_unit): Use
10994         dwarf2_cu::reset_builder.
10995         (follow_die_offset): Record the ancestor CU if it is different
10996         from the followed DIE's CU.
10997         (follow_die_sig_1): Likewise.
10998
10999 2019-01-15  Tom Tromey  <tom@tromey.com>
11000
11001         * remote.c (class remote_state) <buf>: Now a char_vector.
11002         <buf_size>: Remove.
11003         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
11004         parameter.
11005         (remote_target::getpkt_or_notif_sane_1)
11006         (remote_target::getpkt_sane)
11007         (remote_target::getpkt_or_notif_sane): Likewise.
11008         (class remote_target) <putpkt>: New overload.
11009         (remote_target::read_frame): Change type of "buf_p".  Remove
11010         sizeof_p parameter.
11011         (packet_ok): New overload.
11012         (packet_check_result): New overload.
11013         Update all uses.
11014
11015 2019-01-14  Tom Tromey  <tom@tromey.com>
11016
11017         * remote-notif.c (handle_notification, remote_notif_ack)
11018         (remote_notif_parse): Make "buf" const.
11019         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
11020         const.
11021         (remote_notif_parse, remote_notif_ack, handle_notification):
11022         Likewise.
11023         * remote.c (remote_notif_stop_parse): Make "buf" const.
11024         (remote_target::remote_parse_stop_reply): Make "buf" const.
11025         (remote_notif_stop_ack): Make "buf" const.
11026
11027 2019-01-14  Tom Tromey  <tom@tromey.com>
11028
11029         * remote.c (remote_console_output): Make parameter const.
11030
11031 2019-01-14  Tom Tromey  <tom@tromey.com>
11032
11033         * target-debug.h (target_debug_print_signals): Constify.
11034         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
11035         * procfs.c (procfs_target::pass_signals): Update.
11036         * linux-nat.c (linux_nat_target::pass_signals): Update.
11037         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
11038         * target-delegates.c: Rebuild.
11039         * remote.c (remote_target::program_signals): Update.
11040         (remote_target::pass_signals): Update.
11041         * target.c (target_pass_signals): Constify argument.
11042         (target_program_signals): Likewise.
11043         * target.h (struct target_ops) <pass_signals, program_signals>:
11044         Constify argument.
11045         (target_pass_signals, target_program_signals): Constify argument.
11046
11047 2019-01-14  Tom Tromey  <tom@tromey.com>
11048
11049         PR tui/28819:
11050         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
11051
11052 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
11053
11054         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
11055         field.
11056         * rs6000-tdep.c: Include reggroups.h.
11057         (IS_V_ALIAS_PSEUDOREG): Define.
11058         (rs6000_register_name): Return names for the "vX" aliases.
11059         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
11060         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
11061         aliases.  Call default_register_reggroup_p for all other
11062         pseudo-registers.
11063         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
11064         New functions.
11065         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
11066         Handle "vX" aliases.
11067         (v_alias_pseudo_register_collect): New function.
11068         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
11069         (rs6000_gdbarch_init): Initialize "vX" aliases as
11070         pseudo-registers.  Restore registration of
11071         rs6000_pseudo_register_reggroup_p with
11072         set_tdesc_pseudo_register_reggroup_p.
11073
11074 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
11075
11076         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
11077         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
11078         set_gdbarch_num_pseudo_regs.
11079
11080 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11081
11082         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
11083         Remove arg prefixname, add do_set and do_show.
11084         Add member functions set_list and show_list.
11085         * cli/cli-style.c (class cli_style_option): Update accordingly.
11086         (style_set_list): Move to file scope.
11087         (style_show_list): Likewise.
11088         (set_style): Call help_list.
11089         (show_style): Call cmd_show_list.
11090         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
11091         Update to use the new macro.
11092
11093 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
11094
11095         * ada-lang.c (_initialize_ada_language): Expand the help text
11096         for the "catch exception" command.
11097
11098 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11099
11100         * symtab.c (matching_obj_sections): Initialize obj,
11101         declare it closer to its usage.
11102
11103 2019-01-10  Tom Tromey  <tom@tromey.com>
11104
11105         * thread-iter.h (inf_threads_iterator): Use next_iterator.
11106         (basic_inf_threads_range): Remove.
11107         (inf_threads_range, inf_non_exited_threads_range)
11108         (safe_inf_threads_range): Use next_adapter.
11109
11110 2019-01-10  Keith Seitz  <keiths@redhat.com>
11111
11112         PR gdb/23712
11113         PR symtab/23010
11114         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
11115         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
11116
11117 2019-01-10  Keith Seitz  <keiths@redhat.com>
11118
11119         PR gdb/23712
11120         PR symtab/23010
11121         * dictionary.c (pending_to_vector): Remove.
11122         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
11123         Remove _1 suffix, replacing functions of the same name.  Update
11124         all callers.
11125         (dict_create_hashed, dict_create_hashed_expandable)
11126         (dict_create_linear, dict_create_linear_expandable, dict_free)
11127         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
11128         Make functions static.
11129
11130 2019-01-10  Keith Seitz  <keiths@redhat.com>
11131
11132         PR gdb/23712
11133         PR symtab/23010
11134         * dictionary.h (struct dictionary): Replace declaration with
11135         multidictionary.
11136         (dict_create_hashed, dict_create_hashed_expandable)
11137         (dict_create_linear, dict_create_linear_expandable)
11138         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
11139         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
11140         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
11141         taking multidictionary argument.
11142         [ALL_DICT_SYMBOLS]: Update for multidictionary.
11143         * block.h (struct block) <dict>: Change to multidictionary
11144         and rename `multidict'.
11145         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
11146         symmisc.c: Update all dictionary references to multidictionary.
11147
11148 2019-01-10  Keith Seitz  <keiths@redhat.com>
11149
11150         PR gdb/23712
11151         PR symtab/23010
11152         * dictionary.c: Include unordered_map.
11153         (pending_to_vector): New function.
11154         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
11155         Rewrite the non-"_1" functions to take vector instead
11156         of linked list.
11157         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
11158         "new" _1 versions of the same name.
11159         (multidictionary): Define.
11160         (std::hash<enum language): New definition.
11161         (collate_pending_symbols_by_language, mdict_create_hashed)
11162         (mdict_create_hashed_expandable, mdict_create_linear)
11163         (mdict_create_linear_expandable, mdict_free)
11164         (find_language_dictionary, create_new_language_dictionary)
11165         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
11166         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
11167         (mdict_size, mdict_empty): New functions.
11168         * dictionary.h (mdict_iterator): Define.
11169
11170 2019-01-10  Pedro Alves  <palves@redhat.com>
11171
11172         * breakpoint.c (read_uploaded_action)
11173         (create_tracepoint_from_upload): Adjust to use
11174         gdb::unique_xmalloc_ptr.
11175         * ctf.c (ctf_write_uploaded_tp):
11176         (SET_ARRAY_FIELD): Use emplace_back.
11177         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
11178         * tracefile-tfile.c (tfile_write_uploaded_tp):
11179         * tracepoint.c (parse_tracepoint_definition): Adjust to use
11180         gdb::unique_xmalloc_ptr.
11181         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
11182         at_string, cond_string, cmd_strings>: Replace char pointers
11183         with gdb::unique_xmalloc_ptr.
11184
11185 2019-01-10  Pedro Alves  <palves@redhat.com>
11186
11187         * solib-target.c (library_list_start_library): Don't xstrdup name.
11188
11189 2019-01-10  Pedro Alves  <palves@redhat.com>
11190
11191         * mdebugread.c (parse_partial_symbols): Use
11192         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
11193
11194 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
11195
11196         * linux-fork.c (scoped_switch_fork_info)
11197         <~scoped_switch_fork_info>: Fix incorrect variable name.
11198
11199 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
11200
11201         * linux-fork.c (scoped_switch_fork_info)
11202         <scoped_switch_fork_info>: Make explicit.
11203         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
11204
11205 2019-01-10  Tom Tromey  <tom@tromey.com>
11206
11207         * objfiles.h (objfile::reset_psymtabs): Update.
11208         * objfiles.c (objfile::objfile): Update.
11209         * psymtab.h (psymtab_storage::obstack): Update.
11210         (psymtab_storage::m_obstack): Use gdb::optional.
11211         (class psymtab_storage): Update comment.  Remove objfile
11212         parameter.
11213         * psymtab.c (psymtab_storage::psymtab_storage): Update.
11214
11215 2019-01-10  Tom Tromey  <tom@tromey.com>
11216
11217         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
11218         <free_psymtabs>: Now private.
11219         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
11220         (allocate_psymtab): Use new method.
11221
11222 2019-01-10  Tom Tromey  <tom@tromey.com>
11223
11224         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
11225         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
11226         * mdebugread.c (parse_partial_symbols): Use
11227         allocate_dependencies.
11228         * dwarf2read.c (dwarf2_create_include_psymtab): Use
11229         allocate_dependencies.
11230         (process_psymtab_comp_unit_reader)
11231         (build_type_psymtab_dependencies): Likewise.
11232         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
11233
11234 2019-01-10  Tom Tromey  <tom@tromey.com>
11235
11236         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
11237         PSYMBOL_SET_LANGUAGE.
11238         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
11239
11240 2019-01-10  Tom Tromey  <tom@tromey.com>
11241
11242         * psymtab.h (psymtab_storage::obstack): New method.
11243         <m_obstack>: Rename from obstack; now private.
11244         * psymtab.c (psymtab_storage): Update.
11245         * dwarf2read.c (create_addrmap_from_index)
11246         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
11247         Update.
11248
11249 2019-01-10  Tom Tromey  <tom@tromey.com>
11250
11251         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
11252         * objfiles.h (objfile::reset_psymtabs): New method.
11253
11254 2019-01-10  Tom Tromey  <tom@tromey.com>
11255
11256         * symmisc.c (print_symbol_bcache_statistics): Update.
11257         (print_objfile_statistics): Update.
11258         * symfile.c (reread_symbols): Update.
11259         * psymtab.h (class psymtab_storage): New.
11260         * psymtab.c (psymtab_storage): New constructor.
11261         (~psymtab_storage): New destructor.
11262         (require_partial_symbols): Update.
11263         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
11264         (find_pc_sect_psymtab, find_pc_sect_psymbol)
11265         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
11266         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
11267         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
11268         (start_psymtab_common, end_psymtab_common)
11269         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
11270         (allocate_psymtab): Update.
11271         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
11272         Update.
11273         (dump_psymtab_addrmap, maintenance_print_psymbols)
11274         (maintenance_check_psymtabs): Update.
11275         (class objfile_psymtabs): Move to objfiles.h.
11276         * psympriv.h (discard_psymtab): Now inline.
11277         (psymtab_discarder::psymtab_discarder): Update.
11278         (psymtab_discarder::~psymtab_discarder): Update.
11279         (ALL_OBJFILE_PSYMTABS): Rewrite.
11280         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
11281         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
11282         Remove fields.
11283         <partial_symtabs>: New field.
11284         (class objfile_psymtabs): Move from psymtab.h.  Update.
11285         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
11286         psymbol_cache.
11287         (objfile::~objfile): Don't destroy psymbol_cache.
11288         * mdebugread.c (parse_partial_symbols): Update.
11289         * dwarf2read.c (create_addrmap_from_index)
11290         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
11291         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
11292         (add_partial_subprogram, dwarf2_ranges_read): Update.
11293         * dwarf-index-write.c (write_address_map)
11294         (write_one_signatured_type, recursively_write_psymbols)
11295         (class debug_names, class debug_names, write_psymtabs_to_index):
11296         Update.
11297
11298 2019-01-10  Tom Tromey  <tom@tromey.com>
11299
11300         * symtab.h (SYMBOL_SET_NAMES): Update.
11301         (symbol_set_names): Update.
11302         (MSYMBOL_SET_NAMES): Update.
11303         * symtab.c (symbol_set_names): Change argument to be an
11304         objfile_per_bfd_storage.
11305         * psymtab.c (add_psymbol_to_bcache): Update.
11306         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
11307
11308 2019-01-10  Tom Tromey  <tom@tromey.com>
11309
11310         * symtab.c (create_demangled_names_hash): Change argument to be an
11311         objfile_per_bfd_storage.
11312         (symbol_set_names): Update.
11313
11314 2019-01-10  Tom Tromey  <tom@tromey.com>
11315
11316         * xcoffread.c (xcoff_initial_scan): Unconditionally call
11317         init_psymbol_list.
11318         * psymtab.c (init_psymbol_list): Do nothing if already called.
11319         * psympriv.h (init_psymbol_list): Add comment.
11320         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
11321         init_psymbol_list.
11322         * dbxread.c (dbx_symfile_read): Unconditionally call
11323         init_psymbol_list.
11324
11325 2019-01-10  Tom Tromey  <tom@tromey.com>
11326
11327         * xcoffread.c (scan_xcoff_symtab): Update.
11328         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
11329         "where".
11330         * mdebugread.c (parse_partial_symbols)
11331         (handle_psymbol_enumerators): Update.
11332         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
11333         * dbxread.c (read_dbx_symtab): Update.
11334         * psympriv.h (psymbol_placement): New enum.
11335         (add_psymbol_to_list): Update.
11336
11337 2019-01-10  Tom Tromey  <tom@tromey.com>
11338
11339         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
11340         static_psymbols parameters.
11341         (scan_xcoff_symtab): Update.
11342         * psymtab.c (start_psymtab_common): Remove global_psymbols and
11343         static_psymbols parameters.
11344         * psympriv.h (start_psymtab_common): Update.
11345         * mdebugread.c (parse_partial_symbols): Update.
11346         * dwarf2read.c (create_partial_symtab): Update.
11347         * dbxread.c (read_dbx_symtab): Update.
11348         (start_psymtab): Remove global_psymbols and static_psymbols
11349         parameters.
11350
11351 2019-01-10  Tom Tromey  <tom@tromey.com>
11352
11353         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
11354         * psymtab.c (allocate_psymtab): Add comment.
11355         * psympriv.h (allocate_psymtab): Add comment.
11356         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
11357         initializations.
11358         * dbxread.c (dbx_end_psymtab): Remove some initializations.
11359
11360 2019-01-10  Tom Tromey  <tom@tromey.com>
11361
11362         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
11363         Don't declare.
11364         * mipsread.c: Include mdebugread.h.
11365         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
11366         Declare.
11367         * elfread.c: Include mdebugread.h.
11368
11369 2019-01-09  Tom Tromey  <tom@tromey.com>
11370
11371         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
11372         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
11373         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
11374         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
11375         (psym_lookup_symbol, psym_find_last_source_symtab)
11376         (psym_forget_cached_source_info, psym_print_stats)
11377         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
11378         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
11379         (psym_map_matching_symbols, psym_expand_symtabs_matching)
11380         (psym_find_compunit_symtab_by_address)
11381         (maintenance_print_psymbols, maintenance_info_psymtabs)
11382         (maintenance_check_psymtabs): Use ranged for.
11383         * psymtab.h (class objfile_psymtabs): New.
11384         (require_partial_symbols): Return objfile_psymtabs.
11385         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
11386
11387 2019-01-09  Tom Tromey  <tom@tromey.com>
11388
11389         * symfile.c (overlay_invalidate_all, find_pc_overlay)
11390         (find_pc_mapped_section, list_overlays_command)
11391         (map_overlay_command, unmap_overlay_command)
11392         (simple_overlay_update): Use all_objfiles.
11393         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
11394         * printcmd.c (info_symbol_command): Use all_objfiles.
11395         * objfiles.h (ALL_OBJSECTIONS): Remove.
11396         * maint.c (maintenance_translate_address): Use all_objfiles.
11397         * gcore.c (gcore_create_callback): Use all_objfiles.
11398         (objfile_find_memory_regions): Likewise.
11399
11400 2019-01-09  Tom Tromey  <tom@tromey.com>
11401
11402         * symtab.c (find_line_symtab, info_sources_command)
11403         (make_source_files_completion_list): Use objfile_compunits.
11404         * source.c (select_source_symtab): Use objfile_compunits.
11405         * objfiles.h (struct objfile): Update comment.
11406         (ALL_OBJFILES): Remove.
11407         (ALL_FILETABS): Remove.
11408         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
11409         objfile_compunits.
11410
11411 2019-01-09  Tom Tromey  <tom@tromey.com>
11412
11413         * symmisc.c (print_objfile_statistics, dump_objfile)
11414         (maintenance_print_symbols): Use compunit_filetabs.
11415         * source.c (forget_cached_source_info_for_objfile): Use
11416         compunit_filetabs.
11417         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
11418         (ALL_FILETABS): Use compunit_filetabs.
11419         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
11420         * coffread.c (coff_symtab_read): Use compunit_filetabs.
11421
11422 2019-01-09  Tom Tromey  <tom@tromey.com>
11423
11424         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
11425         (compunit_filetabs): New.
11426         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
11427         compunit_filetabs.
11428         (info_sources_command, make_source_files_completion_list): Remove
11429         declaration.
11430         * symmisc.c (print_objfile_statistics, dump_objfile)
11431         (maintenance_print_symbols): Remove declaration.
11432         (maintenance_info_symtabs): Use compunit_filetabs.
11433         (maintenance_info_line_tables): Likewise.
11434         * source.c (select_source_symtab): Change local variable name.
11435         (forget_cached_source_info_for_objfile): Remove declaration.
11436         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
11437         * objfiles.c (objfile_relocate1): Remove declaration.
11438         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
11439         declaration.
11440         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
11441         * coffread.c (coff_symtab_read): Remove declaration.
11442         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
11443         compunit_filetabs.
11444
11445 2019-01-09  Tom Tromey  <tom@tromey.com>
11446
11447         * symtab.c (lookup_objfile_from_block)
11448         (find_pc_sect_compunit_symtab, search_symbols)
11449         (default_collect_symbol_completion_matches_break_on): Use
11450         objfile_compunits.
11451         * objfiles.h (ALL_COMPUNITS): Remove.
11452         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
11453         * cp-support.c (add_symbol_overload_list_qualified): Use
11454         objfile_compunits.
11455         * ada-lang.c (ada_collect_symbol_completion_matches)
11456         (ada_add_global_exceptions): Use objfile_compunits.
11457
11458 2019-01-09  Tom Tromey  <tom@tromey.com>
11459
11460         * source.c (select_source_symtab)
11461         (forget_cached_source_info_for_objfile): Remove declaration.
11462         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
11463         declaration.
11464         * maint.c (count_symtabs_and_blocks): Remove declaration.
11465         * cp-support.c (add_symbol_overload_list_qualified): Remove
11466         declaration.
11467         * coffread.c (coff_symtab_read): Remove declaration.
11468         * symtab.c (lookup_symbol_in_objfile_symtabs)
11469         (basic_lookup_transparent_type_1): Use objfile_compunits.
11470         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
11471         (info_sources_command, search_symbols)
11472         (default_collect_symbol_completion_matches_break_on)
11473         (make_source_files_completion_list): Remove declaration.
11474         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
11475         (ada_collect_symbol_completion_matches)
11476         (ada_add_global_exceptions): Remove declaration.
11477         * linespec.c (iterate_over_all_matching_symtabs): Use
11478         objfile_compunits.
11479         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
11480         (class objfile_compunits): New.
11481         (ALL_COMPUNITS): Use objfile_compunits.
11482         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
11483         (maintenance_check_symtabs, maintenance_info_line_tables): Use
11484         objfile_compunits.
11485         * objfiles.c (objfile_relocate1): Use objfile_compunits.
11486
11487 2019-01-09  Tom Tromey  <tom@tromey.com>
11488
11489         * symtab.c (search_symbols)
11490         (default_collect_symbol_completion_matches_break_on): Use
11491         objfile_msymbols.
11492         * ada-lang.c (ada_lookup_simple_minsym)
11493         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
11494         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
11495         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
11496         objfile_msymbols.
11497         * coffread.c (coff_symfile_read): Use objfile_msymbols.
11498         * symmisc.c (dump_msymbols): Use objfile_msymbols.
11499         * objc-lang.c (find_methods): Use objfile_msymbols.
11500         (info_selectors_command, info_classes_command): Likewise.
11501         * stabsread.c (scan_file_globals): Use objfile_msymbols.
11502         * objfiles.h (class objfile_msymbols): New.
11503         (ALL_OBJFILE_MSYMBOLS): Remove.
11504         (ALL_MSYMBOLS): Remove.
11505
11506 2019-01-09  Tom Tromey  <tom@tromey.com>
11507
11508         * common/next-iterator.h (next_adapter): Add Iterator template
11509         parameter.
11510         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
11511         (class all_objfiles_safe): New.
11512         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
11513         * objfiles.c (put_objfile_before): Update comment.
11514         (add_separate_debug_objfile): Likewise.
11515         (free_all_objfiles): Use all_objfiles_safe.
11516         (objfile_purge_solibs): Likewise.
11517
11518 2019-01-09  Tom Tromey  <tom@tromey.com>
11519
11520         * symtab.c (iterate_over_symtabs, matching_obj_sections)
11521         (expand_symtab_containing_pc, lookup_static_symbol)
11522         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
11523         (find_symbol_at_address, find_line_symtab, find_main_name): Use
11524         all_objfiles.
11525         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
11526         * breakpoint.c (create_overlay_event_breakpoint)
11527         (create_longjmp_master_breakpoint)
11528         (create_std_terminate_master_breakpoint)
11529         (create_exception_master_breakpoint): Use all_objfiles.
11530         * linux-thread-db.c (try_thread_db_load_from_pdir)
11531         (has_libpthread): Use all_objfiles.
11532         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
11533         * linespec.c (iterate_over_all_matching_symtabs)
11534         (search_minsyms_for_name): Use all_objfiles.
11535         * maint.c (maintenance_info_sections): Use all_objfiles.
11536         * main.c (captured_main_1): Use all_objfiles.
11537         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
11538         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
11539         * guile/scm-pretty-print.c
11540         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
11541         * solib-spu.c (append_ocl_sos): Use all_objfiles.
11542         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
11543         (maintenance_print_msymbols): Use all_objfiles.
11544         * source.c (select_source_symtab): Use all_objfiles.
11545         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
11546         * symfile.c (remove_symbol_file_command)
11547         (expand_symtabs_matching, map_symbol_filenames): Use
11548         all_objfiles.
11549         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
11550         all_objfiles.
11551         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
11552         * objc-lang.c (find_methods): Use all_objfiles.
11553         * objfiles.c (have_partial_symbols, have_full_symbols)
11554         (have_minimal_symbols, qsort_cmp)
11555         (default_iterate_over_objfiles_in_search_order): Use
11556         all_objfiles.
11557         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
11558         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
11559         (maintenance_check_psymtabs): Use all_objfiles.
11560         (ALL_PSYMTABS): Remove.
11561         * compile/compile-object-run.c (do_module_cleanup): Use
11562         all_objfiles.
11563         * blockframe.c (find_pc_partial_function): Use all_objfiles.
11564         * cp-support.c (add_symbol_overload_list_qualified): Use
11565         all_objfiles.
11566         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
11567         Use all_objfiles.
11568         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
11569         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
11570         all_objfiles.
11571         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
11572         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
11573         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
11574         Uses all_objfiles.
11575         * solib.c (solib_read_symbols): Use all_objfiles
11576
11577 2019-01-09  Tom Tromey  <tom@tromey.com>
11578
11579         * probe.c (parse_probes_in_pspace): Use all_objfiles.
11580         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
11581         all_objfiles.
11582         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
11583         * symmisc.c (print_symbol_bcache_statistics)
11584         (print_objfile_statistics, maintenance_print_objfiles)
11585         (maintenance_info_symtabs, maintenance_check_symtabs)
11586         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
11587         all_objfiles.
11588         * source.c (forget_cached_source_info): Use all_objfiles.
11589         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
11590         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
11591         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
11592         * objfiles.c (update_section_map): Use all_objfiles.
11593         (shared_objfile_contains_address_p): Likewise.
11594         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
11595         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
11596
11597 2019-01-09  Tom Tromey  <tom@tromey.com>
11598
11599         * common/next-iterator.h: New file.
11600         * objfiles.h (class all_objfiles): New.
11601         (struct objfile_iterator): New.
11602
11603 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11604
11605         * NEWS: Move the description of the changed "frame", "select-frame",
11606          and "info frame" commands to the Changed commands section.
11607
11608 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
11609
11610         * gdbtypes.c (check_stub_method_group): Remove handling of old
11611         mangling schemes.
11612         * linespec.c (find_methods): Likewise.
11613         * stabsread.c (read_member_functions): Likewise.
11614         * valops.c (search_struct_method): Likewise.
11615         (value_struct_elt_for_reference): Likewise.
11616         * NEWS: Mention this change.
11617
11618 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
11619
11620         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
11621         print_source_lines.
11622         * source.c (print_source_lines_base): Update line number check.
11623         (print_source_lines): New function.
11624         (source_lines_range::source_lines_range): New function.
11625         * source.h (class source_lines_range): New class.
11626         (print_source_lines): New declaration.
11627
11628 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11629
11630         * linespec.c (linespec_state_destructor): Free self->canonical_names.
11631
11632 2019-01-08  Tom Tromey  <tom@tromey.com>
11633             Simon Marchi  <simon.marchi@ericsson.com>
11634
11635         PR gdb/24060
11636         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
11637         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
11638         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
11639         * f-exp.y (DOLLAR_VARIABLE): Likewise.
11640         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
11641         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
11642
11643 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
11644
11645         * source.c (select_source_symtab): Move header comment to
11646         declaration in source.h.
11647         (forget_cached_source_info_for_objfile): Likewise.
11648         (forget_cached_source_info): Likewise.
11649         (identify_source_line): Likewise.
11650         * source.h (identify_source_line): Move declaration from symtab.h
11651         and add comment from source.c
11652         (print_source_lines): Likewise.
11653         (forget_cached_source_info_for_objfile): Likewise.
11654         (forget_cached_source_info): Likewise.
11655         (select_source_symtab): Likewise.
11656         (enum print_source_lines_flag): Move definition from symtab.h.
11657         * symtab.h (identify_source_line): Move declaration to source.h.
11658         (print_source_lines): Likewise.
11659         (forget_cached_source_info_for_objfile): Likewise.
11660         (forget_cached_source_info): Likewise.
11661         (select_source_symtab): Likewise.
11662         (enum print_source_lines_flag): Move definition to source.h.
11663         * tui/tui-hooks.c: Add 'source.h' include.
11664
11665 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
11666
11667         * source.c (print_source_lines_base): Handle requests to print
11668         reverse line number sequences, and guard against empty lines
11669         string.
11670
11671 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
11672
11673         * source.c (print_source_lines_base): Fix skip of '\r' if next
11674         character is '\n'.
11675
11676 2019-01-06  Tom Tromey  <tom@tromey.com>
11677
11678         * c-exp.y (struct c_parse_state) <macro_original_text,
11679         expansion_obstack>: New member.
11680         (macro_original_text, expansion_obstack): Remove globals.
11681         (scan_macro_expansion, scanning_macro_expansion)
11682         (finished_macro_expansion): Update.
11683         (scan_macro_cleanup): Remove.
11684         (yylex, c_parse): Update.
11685
11686 2019-01-06  Tom Tromey  <tom@tromey.com>
11687
11688         * c-exp.y (struct c_parse_state) <strings>: New member.
11689         (operator_stoken): Update.
11690
11691 2019-01-06  Tom Tromey  <tom@tromey.com>
11692
11693         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
11694         (union type_stack_elt) <typelist_val>: Now a pointer to
11695         std::vector.
11696         (type_stack_cleanup): Don't declare.
11697         (push_typelist): Update.
11698         * parse.c (pop_typelist): Return a std::vector.
11699         (push_typelist): Take a std::vector.
11700         (follow_types): Update.  Do not free args.
11701         (type_stack_cleanup): Remove.
11702         * c-exp.y (struct c_parse_state): New.
11703         (cpstate): New global.
11704         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
11705         (nonempty_typelist): Update.
11706         (func_mod): Create a new vector.
11707         (c_parse): Create a c_parse_state.
11708         (check_parameter_typelist): Do not delete params.
11709         (function_method): Update.  Do not delete type_list.
11710
11711 2019-01-06  Tom Tromey  <tom@tromey.com>
11712
11713         PR gdb/28155:
11714         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
11715         check_typedef.
11716         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
11717         (print_return_value): Likewise.
11718
11719 2019-01-05  Tom Tromey  <tom@tromey.com>
11720
11721         * contrib/cleanup_check.py: Remove.
11722         * contrib/gcc-with-excheck: Remove.
11723         * contrib/exsummary.py: Remove.
11724         * contrib/excheck.py: Remove.
11725
11726 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
11727
11728         * thread.c (delete_thread_1): Add gdb_assert that THR is not
11729         NULL. Initialize tpprev to NULL instead of assigning it
11730         to NULL on the next statement.
11731         * windows-nat.c (windows_delete_thread): Remove check for
11732         main_thread_id before printing thread exit notifications.
11733         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
11734         Remove thread ID check against main_thread_id.
11735         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
11736         windows_delete_thread.
11737         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
11738
11739 2019-01-04  Tom Tromey  <tom@tromey.com>
11740
11741         * compile/compile.c (_initialize_compile): Use upper case for
11742         metasyntactic variables.
11743         * symmisc.c (_initialize_symmisc): Use upper case for
11744         metasyntactic variables.
11745         * psymtab.c (_initialize_psymtab): Use upper case for
11746         metasyntactic variables.
11747         * demangle.c (demangle_command): Use upper case for metasyntactic
11748         variables.
11749         (_initialize_demangler): Likewise.
11750         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
11751         variables.
11752
11753 2019-01-03  Tom Tromey  <tom@tromey.com>
11754
11755         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
11756
11757 2019-01-03  Tom Tromey  <tom@tromey.com>
11758
11759         * python/py-symtab.c (salpy_str): Update.
11760         (struct salpy_sal_object) <symtab>: Now a PyObject.
11761         (salpy_dealloc): Update.
11762         (del_objfile_sal): Use gdbpy_ref.
11763
11764 2019-01-03  Tom Tromey  <tom@tromey.com>
11765
11766         * python/py-type.c (convert_field): Use new_reference.  Return
11767         gdbpy_ref.
11768         (make_fielditem): Return gdbpy_ref.
11769         (typy_fields): Update.
11770         (typy_getitem): Update.
11771         (field_name): Return gdbpy_ref.  Use new_reference.
11772         (typy_iterator_iternext): Update.
11773
11774 2019-01-03  Tom Tromey  <tom@tromey.com>
11775
11776         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
11777
11778 2019-01-03  Tom Tromey  <tom@tromey.com>
11779
11780         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
11781         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
11782         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
11783         (pspy_set_frame_filters, pspy_set_frame_unwinders)
11784         (pspy_set_type_printers): Likewise.
11785         * python/py-function.c (fnpy_init): Use gdbpy_ref.
11786         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
11787         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
11788         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
11789         (objfpy_set_type_printers): Likewise.
11790
11791 2019-01-03  Tom Tromey  <tom@tromey.com>
11792
11793         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
11794         (gdbpy_print_stack): Use gdbpy_err_fetch.
11795         * python/python-internal.h (class gdbpy_err_fetch): New class.
11796         (class gdbpy_enter) <m_error_type, m_error_value,
11797         m_error_traceback>: Remove.
11798         <m_error>: New member.
11799         (gdbpy_exception_to_string): Don't declare.
11800         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
11801         * python/py-value.c (convert_value_from_python): Use
11802         gdbpy_err_fetch.
11803         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
11804         gdbpy_exception_to_string.
11805         (gdbpy_handle_exception): Use gdbpy_err_fetch.
11806         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
11807         gdbpy_err_fetch.
11808
11809 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11810
11811         * linux-nat.c (delete_lwp_cleanup): Delete.
11812         (struct lwp_deleter): New struct.
11813         (lwp_info_up): New typedef.
11814         (linux_nat_target::follow_fork): Delete cleanup, and make use of
11815         lwp_info_up.
11816
11817 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11818
11819         * linux-fork.c (class scoped_switch_fork_info): New class.
11820         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
11821
11822 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11823
11824         * valops.c (find_overload_match): Remove use of null_cleanup, and
11825         calls to do_cleanups.
11826
11827 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11828
11829         * compile/compile-cplus-types.c
11830         (compile_cplus_instance::decl_name): Handle changes to
11831         cp_func_name.
11832         * cp-support.c (cp_func_name): Update header comment, update
11833         return type.
11834         * cp-support.h (cp_func_name): Update return type in declaration.
11835         * valops.c (find_overload_match): Move temp_func local to top
11836         level of function and change its type.  Use temp_func to hold and
11837         delete temporary string obtained from cp_func_name.
11838
11839 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11840
11841         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
11842         gdb::char_vector, remove cleanup, and update uses of `msg`.
11843
11844 2019-01-03  Jim Wilson  <jimw@sifive.com>
11845
11846         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
11847
11848 2019-01-02  Tom Tromey  <tom@tromey.com>
11849
11850         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
11851         (tdesc_parse_xml): Remove cleanups.
11852         * target-descriptions.h (make_cleanup_free_target_description):
11853         Don't declare.
11854         (target_desc_deleter): New struct.
11855         (target_desc_up): New typedef.
11856         * target-descriptions.c (target_desc_deleter::operator()): Rename
11857         from free_target_description.
11858         (make_cleanup_free_target_description): Remove.
11859
11860 2019-01-02  Tom Tromey  <tom@tromey.com>
11861
11862         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
11863         constructor, destructor.
11864         (linespec_parser): Remove typedef.
11865         (~linespec_parser): Rename from linespec_parser_delete.
11866         (linespec_lex_to_end, linespec_complete_label)
11867         (linespec_complete): Update.
11868         (decode_line_full): Remove cleanups.
11869         (decode_line_1): Update.
11870
11871 2019-01-02  Tom Tromey  <tom@tromey.com>
11872
11873         * python/python-internal.h (inferior_to_inferior_object): Change
11874         return type.
11875         * python/py-exitedevent.c (create_exited_event_object): Update.
11876         * python/py-inferior.c (inferior_to_inferior_object): Return
11877         gdbpy_ref.
11878         (python_new_inferior, python_inferior_deleted)
11879         (thread_to_thread_object, delete_thread_object)
11880         (build_inferior_list, gdbpy_selected_inferior): Update.
11881         * python/py-infthread.c (create_thread_object): Update.  Also fail
11882         if inferior_to_inferior_object fails.
11883
11884 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
11885
11886         * inferior.h (class inferior) <displaced_step_state>: New field.
11887         * infrun.h (struct displaced_step_state): Move here from
11888         infrun.c.  Initialize fields, add constructor.
11889         <inf>: Remove field.
11890         <reset>: New method.
11891         * infrun.c (struct displaced_step_inferior_state): Move to
11892         infrun.h.
11893         (displaced_step_inferior_states): Remove.
11894         (get_displaced_stepping_state): Adust.
11895         (displaced_step_in_progress_any_inferior): Adjust.
11896         (displaced_step_in_progress_thread): Adjust.
11897         (displaced_step_in_progress): Adjust.
11898         (add_displaced_stepping_state): Remove.
11899         (get_displaced_step_closure_by_addr): Adjust.
11900         (remove_displaced_stepping_state): Remove.
11901         (infrun_inferior_exit): Call displaced_step_state.reset.
11902         (use_displaced_stepping): Don't check for NULL.
11903         (displaced_step_prepare_throw): Call
11904         get_displaced_stepping_state.
11905         (displaced_step_fixup): Don't check for NULL.
11906         (prepare_for_detach): Don't check for NULL.
11907
11908 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11909
11910         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
11911          in case of call that did not complete.
11912
11913 2019-01-02  Andrey Utkin  <autkin@undo.io>
11914
11915         * symfile.c (find_separate_debug_file): Fix search of debug files for
11916         remote debuggee.
11917
11918 2019-01-02  Tom Tromey  <tom@tromey.com>
11919
11920         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
11921         indentation.
11922         * python/py-frame.c (frapy_older): Remove cast.
11923         (frapy_newer): Likewise.
11924         * python/py-breakpoint.c (local_setattro): Remove cast.
11925         * python/py-arch.c (archpy_name): Remove local variable.
11926         * python/py-type.c (gdbpy_lookup_type): Remove cast.
11927
11928 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
11929
11930         * unittests/basic_string_view/element_access/char/empty.cc:
11931         Fix year range in copyright header.
11932
11933 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
11934
11935         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
11936         Delete.
11937         <operator==>: Update with for removed field.
11938         <hash>: Likewise.
11939         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
11940         <isa_features>: ...this.
11941         <abi_features>: New field.
11942         (riscv_isa_flen): Update comment.
11943         (riscv_abi_xlen): New declaration.
11944         (riscv_abi_flen): New declaration.
11945         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
11946         isa_features.
11947         (riscv_abi_xlen): New function.
11948         (riscv_isa_flen): Update to get answer from isa_features.
11949         (riscv_abi_flen): New function.
11950         (riscv_has_fp_abi): Update to get answer from abi_features.
11951         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
11952         xlen and flen.
11953         (riscv_call_info) <xlen, flen>: Update comment.
11954         (riscv_call_arg_struct): Remove invalid assertions
11955         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
11956         is removed.
11957         (riscv_gdbarch_init): Gather isa features and abi features
11958         separately, ensure both match on the gdbarch when reusing an old
11959         gdbarch.  Relax an error check to allow 32-bit abi float to run on
11960         a target with 64-bit float hardware.
11961
11962 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11963
11964         * source.c (search_command_helper): Stop reverse search
11965         when line 1 has been searched.
11966
11967 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11968
11969         * record-full.c (record_full_base_target::close): Rewrite
11970         record_full_core_buf_list free logic.
11971
11972 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11973
11974         * break-catch-syscall.c (print_one_catch_syscall): xfree
11975         the last text.
11976
11977 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
11978
11979         * top.c (print_gdb_version): Update Copyright year in version
11980         message.
11981
11982 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
11983
11984         Update copyright year range in all GDB files.
11985
11986 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
11987
11988         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
11989
11990 For older changes see ChangeLog-2018.
11991 \f
11992 Local Variables:
11993 mode: change-log
11994 left-margin: 8
11995 fill-column: 74
11996 version-control: never
11997 coding: utf-8
11998 End:
11999