gdb/ChangeLog

   1 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
   2
   3         * utils.h (fast_hash): New function.
   4         * symtab.c (hash_demangled_name_entry): Call new function
   5         fast_hash.
   6
   7 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
   8
   9         * symtab.c (struct demangled_name_entry): Change type of mangled
  10         to gdb::string_view. Also adds a constructor that takes the
  11         mangled name.
  12         (hash_demangled_name_entry): Update.
  13         (eq_demangled_name_entry): Update.
  14         (free_demangled_name_entry): New function to call the destructor
  15         now that this is not a POD anymore.
  16         (create_demangled_names_hash): Pass free_demangled_name_entry to
  17         htab_create_alloc.
  18         (symbol_set_names): Update.
  19
  20 2019-10-21  Ali Tamur  <tamu@google.com>
  21
  22         * dwarf2read.c (dir_index): Change type.
  23         (file_name_index): Likewise.
  24         (line_header::include_dir_at): Change comment and implementation on
  25         whether it is DWARF 5.
  26         (line_header::is_valid_file_index): New function.
  27         (line_header::file_name_at): Change comment and implementation on
  28         whether it is DWARF 5.
  29         (line_header::file_names): Change to private field renamed as
  30         m_file_names and introduce a new accessor method.
  31         (line_header::file_names_size): New method.
  32         (line_header::include_dirs): Change to private field and rename as
  33         m_include_dirs.
  34         (dw2_get_file_names_reader): Define local var at a smaller scope and
  35         reflect API change.
  36         (dwarf2_cu::setup_type_unit_groups): Reflect API change.
  37         (process_structure_scope): Likewise.
  38         (line_header::add_include_dir): Change message and reflect renaming.
  39         (line_header::add_file_name): Likewise.
  40         (read_formatted_entries): Handle DW_FORM_data16.
  41         (dwarf_decode_line_header): Fix line header length calculation.
  42         (psymtab_include_file_name): Change comment and API.
  43         (lnp_state_machine::m_file): Update comment and reflect type change.
  44         (lnp_state_machine::record_line): Reflect type change.
  45         (dwarf_decode_lines): Reflect API change.
  46         (file_file_name): Likewise.
  47         (file_full_name): Likewise.
  48
  49 2019-10-21  Andrew Burgess  <andrew.burgess@embecosm.com>
  50
  51         * objfiles.c (sort_cmp): Ensure that !(a < a) holds true.
  52
  53 2019-10-21  Tom Tromey  <tom@tromey.com>
  54
  55         * tui/tui-winsource.h (tui_exec_info_content): Remove typedef.
  56
  57 2019-10-21  Tom Tromey  <tom@tromey.com>
  58
  59         * configure.ac (nm.h): Conditionally create nm.h link.  Subst
  60         NM_H.   Use AC_CONFIG_LINKS.
  61         * configure: Rebuild.
  62         * Makefile.in (NM_H): New variable.
  63         (generated_files): Add NM_H.  Remove gcore.
  64         (nm.h, stamp-nmh): New targets.
  65
  66 2019-10-20  Tom Tromey  <tom@tromey.com>
  67
  68         * objfiles.h (unlink_objfile, put_objfile_before): Don't declare.
  69         * objfiles.c (unlink_objfile): Move earlier.  Now static.  Remove
  70         obsolete comment.
  71         (put_objfile_before): Now static.
  72
  73 2019-10-19  Simon Marchi  <simon.marchi@polymtl.ca>
  74
  75         * gdbsupport/common-utils.h (startswith): Change return type to
  76         bool.
  77
  78 2019-10-19  Christian Biesinger  <cbiesinger@google.com>
  79
  80         * bcache.c (bcache::print_statistics): Use std::sort instead of qsort.
  81         * breakpoint.c (bp_locations_compare): Rename to...
  82         (bp_location_is_less_than): ...this, and change to std::sort semantics.
  83         (update_global_location_list): Use std::sort instead of qsort.
  84         * buildsym.c (compare_line_numbers): Rename to...
  85         (lte_is_less_than): ...this, and change to std::sort semantics.
  86         (buildsym_compunit::end_symtab_with_blockvector): Use std::sort
  87         instead of qsort.
  88         * disasm.c (compare_lines): Rename to...
  89         (line_is_less_than): ...this, and change to std::sort semantics.
  90         (do_mixed_source_and_assembly_deprecated): Call std::sort instead
  91         of qsort.
  92         * dwarf2-frame.c (qsort_fde_cmp): Rename to...
  93         (fde_is_less_than): ...this, and change to std::sort semantics.
  94         (dwarf2_build_frame_info): Call std::sort instead of qsort.
  95         * mdebugread.c (compare_blocks):
  96         (block_is_less_than): ...this, and change to std::sort semantics.
  97         (sort_blocks): Call std::sort instead of qsort.
  98         * objfiles.c (qsort_cmp): Rename to...
  99         (sort_cmp): ...this, and change to std::sort semantics.
 100         (update_section_map): Call std::sort instead of qsort.
 101         * remote.c (compare_pnums): Remove.
 102         (map_regcache_remote_table): Call std::sort instead of qsort.
 103         * utils.c (compare_positive_ints): Remove.
 104         * utils.h (compare_positive_ints): Remove.
 105         * xcoffread.c (compare_lte): Remove.
 106         (arrange_linetable): Call std::sort instead of qsort.
 107
 108 2019-10-19  Sergio Durigan Junior  <sergiodj@redhat.com>
 109
 110         * symfile.c (init_entry_point_info): Fix typo.
 111         * i386-darwin-tdep.c (darwin_dwarf_signal_frame_p): Fix typo.
 112
 113 2019-10-18  Tom de Vries  <tdevries@suse.de>
 114
 115         * aarch64-tdep.c: Fix typos in comments.
 116         * ada-lang.c: Same.
 117         * ada-tasks.c: Same.
 118         * alpha-tdep.c: Same.
 119         * alpha-tdep.h: Same.
 120         * amd64-nat.c: Same.
 121         * amd64-windows-tdep.c: Same.
 122         * arc-tdep.c: Same.
 123         * arc-tdep.h: Same.
 124         * arch-utils.c: Same.
 125         * arm-nbsd-tdep.c: Same.
 126         * arm-tdep.c: Same.
 127         * ax-gdb.c: Same.
 128         * blockframe.c: Same.
 129         * btrace.c: Same.
 130         * c-varobj.c: Same.
 131         * coff-pe-read.c: Same.
 132         * coffread.c: Same.
 133         * cris-tdep.c: Same.
 134         * darwin-nat.c: Same.
 135         * dbxread.c: Same.
 136         * dcache.c: Same.
 137         * disasm.c: Same.
 138         * dtrace-probe.c: Same.
 139         * dwarf-index-write.c: Same.
 140         * dwarf2-frame-tailcall.c: Same.
 141         * dwarf2-frame.c: Same.
 142         * dwarf2read.c: Same.
 143         * eval.c: Same.
 144         * exceptions.c: Same.
 145         * fbsd-tdep.c: Same.
 146         * findvar.c: Same.
 147         * frame.c: Same.
 148         * frv-tdep.c: Same.
 149         * gnu-v3-abi.c: Same.
 150         * go32-nat.c: Same.
 151         * h8300-tdep.c: Same.
 152         * hppa-tdep.c: Same.
 153         * i386-linux-tdep.c: Same.
 154         * i386-tdep.c: Same.
 155         * ia64-libunwind-tdep.c: Same.
 156         * ia64-tdep.c: Same.
 157         * infcmd.c: Same.
 158         * infrun.c: Same.
 159         * linespec.c: Same.
 160         * linux-nat.c: Same.
 161         * linux-thread-db.c: Same.
 162         * machoread.c: Same.
 163         * mdebugread.c: Same.
 164         * mep-tdep.c: Same.
 165         * mn10300-tdep.c: Same.
 166         * namespace.c: Same.
 167         * objfiles.c: Same.
 168         * opencl-lang.c: Same.
 169         * or1k-tdep.c: Same.
 170         * osabi.c: Same.
 171         * ppc-linux-nat.c: Same.
 172         * ppc-linux-tdep.c: Same.
 173         * ppc-sysv-tdep.c: Same.
 174         * printcmd.c: Same.
 175         * procfs.c: Same.
 176         * record-btrace.c: Same.
 177         * record-full.c: Same.
 178         * remote-fileio.c: Same.
 179         * remote.c: Same.
 180         * rs6000-tdep.c: Same.
 181         * s12z-tdep.c: Same.
 182         * score-tdep.c: Same.
 183         * ser-base.c: Same.
 184         * ser-go32.c: Same.
 185         * skip.c: Same.
 186         * sol-thread.c: Same.
 187         * solib-svr4.c: Same.
 188         * solib.c: Same.
 189         * source.c: Same.
 190         * sparc-nat.c: Same.
 191         * sparc-sol2-tdep.c: Same.
 192         * sparc-tdep.c: Same.
 193         * sparc64-tdep.c: Same.
 194         * stabsread.c: Same.
 195         * stack.c: Same.
 196         * symfile.c: Same.
 197         * symtab.c: Same.
 198         * target-descriptions.c: Same.
 199         * target-float.c: Same.
 200         * thread.c: Same.
 201         * utils.c: Same.
 202         * valops.c: Same.
 203         * valprint.c: Same.
 204         * value.c: Same.
 205         * varobj.c: Same.
 206         * windows-nat.c: Same.
 207         * xcoffread.c: Same.
 208         * xstormy16-tdep.c: Same.
 209         * xtensa-tdep.c: Same.
 210
 211 2019-10-17  Tom Tromey  <tromey@adacore.com>
 212
 213         * configure: Rebuild.
 214         * configure.ac: Use AC_CONFIG_HEADERS.  Create stamp-h there, not
 215         in AC_CONFIG_FILES invocation.
 216         * Makefile.in (Makefile, data-directory/Makefile, stamp-h): Use
 217         new-style config.status invocation.
 218
 219 2019-10-17  Tom de Vries  <tdevries@suse.de>
 220
 221         * arm-nbsd-nat.c: Fix typos in comments.
 222         * arm-tdep.c: Same.
 223         * darwin-nat-info.c: Same.
 224         * dwarf2read.c: Same.
 225         * elfread.c: Same.
 226         * event-top.c: Same.
 227         * findvar.c: Same.
 228         * gdbtypes.c: Same.
 229         * hppa-tdep.c: Same.
 230         * i386-tdep.c: Same.
 231         * jit.c: Same.
 232         * main.c: Same.
 233         * mdebugread.c: Same.
 234         * moxie-tdep.c: Same.
 235         * nto-procfs.c: Same.
 236         * osabi.c: Same.
 237         * ppc-linux-tdep.c: Same.
 238         * remote.c: Same.
 239         * riscv-tdep.c: Same.
 240         * s390-tdep.c: Same.
 241         * sh-tdep.c: Same.
 242         * sparc-linux-tdep.c: Same.
 243         * sparc-nat.c: Same.
 244         * stack.c: Same.
 245         * target-descriptions.c: Same.
 246         * top.c: Same.
 247         * varobj.c: Same.
 248
 249 2019-10-16  Tom Tromey  <tom@tromey.com>
 250
 251         * objfiles.h (struct objfile) <original_name>: Now const.
 252
 253 2019-10-16  Christian Biesinger  <cbiesinger@google.com>
 254
 255         * gdbsupport/gdb_setjmp.h (SIGSETJMP): Allow passing in the value to
 256         pass on to sigsetjmp's second argument.
 257         * cp-support.c (gdb_demangle): Unblock SIGSEGV if we caught a crash.
 258
 259 2019-10-16  Keith Seitz  <keiths@redhat.com>
 260
 261         PR gdb/23567
 262         * dwarf2read.c (dwarf2_per_objfile::locate_sections): Discard
 263         sections whose size is greater than the file size.
 264
 265 2019-10-16  Jim Wilson  <jimw@sifive.com>
 266
 267         * riscv-tdep.c (riscv_gcc_target_options): New.
 268         (riscv_gnu_triplet_regexp): New.
 269         (riscv_gdbarch_init): Call set_gdbarch_gcc_triplet_options and
 270         set_gdbarch_gnu_triplet_regexp.
 271
 272 2019-10-16  Christian Biesinger  <cbiesinger@google.com>
 273
 274         * Makefile.in: Add xml-builtin.h.
 275         * features/feature_to_c.sh: Add an include for xml-builtin.h
 276         to ensure that the compiler checks that the types match.
 277         * xml-builtin.h: New file.
 278         * xml-support.c (fetch_xml_builtin): Add missing const.
 279         * xml-support.h: Remove declaration of xml_builtins.
 280
 281 2019-10-16  Tom de Vries  <tdevries@suse.de>
 282
 283         PR tdep/25096
 284         * amd64-tdep.c (amd64_classify_aggregate_field): Factor out of ...
 285         (amd64_classify_aggregate): ... here.
 286         (amd64_classify_aggregate_field): Handled fiels of nested structs
 287         recursively.
 288
 289 2019-10-16  Tom de Vries  <tdevries@suse.de>
 290
 291         PR tdep/24104
 292         * amd64-tdep.c (amd64_push_arguments): Handle AMD64_NO_CLASS in loop
 293         that handles 'theclass'.
 294
 295 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 296
 297         * linespec.c (decode_digits_ordinary): Update comment.
 298         * make-target-delegates: No longer need to handle VEC case.
 299         * memrange.c (normalize_mem_ranges): Update comment.
 300         * namespace.c (add_using_directive): Update comment.
 301         * objc-lang.c (uniquify_strings): Update comment.
 302         * ppc-linux-nat.c (struct thread_points): Update comment.
 303         * probe.h (find_probes_in_objfile): Update comment.
 304         * target.h (enum flash_preserve_mode): Update comment.
 305         * varobj.c (varobj_restrict_range): Update comment.
 306         * varobj.h (varobj_list_children): Update comment.
 307
 308 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 309
 310         * Makefile.in: Remove references to vec.h and vec.c.
 311         * aarch64-tdep.c: No longer include vec.h.
 312         * ada-lang.c: Likewise.
 313         * ada-lang.h: Likewise.
 314         * arm-tdep.c: Likewise.
 315         * ax.h: Likewise.
 316         * breakpoint.h: Likewise.
 317         * charset.c: Likewise.
 318         * cp-support.h: Likewise.
 319         * dtrace-probe.c: Likewise.
 320         * dwarf2read.c: Likewise.
 321         * extension.h: Likewise.
 322         * gdb_bfd.c: Likewise.
 323         * gdbsupport/gdb_vecs.h: Likewise.
 324         * gdbsupport/vec.c: Remove.
 325         * gdbsupport/vec.h: Remove.
 326         * gdbthread.h: Likewise.
 327         * guile/scm-type.c: Likewise.
 328         * inline-frame.c: Likewise.
 329         * machoread.c: Likewise.
 330         * memattr.c: Likewise.
 331         * memrange.h: Likewise.
 332         * namespace.h: Likewise.
 333         * nat/linux-btrace.h: Likewise.
 334         * osdata.c: Likewise.
 335         * parser-defs.h: Likewise.
 336         * progspace.h: Likewise.
 337         * python/py-type.c: Likewise.
 338         * record-btrace.c: Likewise.
 339         * rust-exp.y: Likewise.
 340         * solib-target.c: Likewise.
 341         * stap-probe.c: Likewise.
 342         * target-descriptions.c: Likewise.
 343         * target-memory.c: Likewise.
 344         * target.h: Likewise.
 345         * varobj.c: Likewise.
 346         * varobj.h: Likewise.
 347         * xml-support.h: Likewise.
 348
 349 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 350
 351         * gdb/dwarf2read.c (dwarf2_per_objfile::~dwarf2_per_objfile):
 352         Update for new std::vector based implementation.
 353         (process_psymtab_comp_unit_reader): Likewise.
 354         (scan_partial_symbols): Likewise.
 355         (recursively_compute_inclusions): Likewise.
 356         (compute_compunit_symtab_includes): Likewise.
 357         (process_imported_unit_die): Likewise.
 358         (queue_and_load_dwo_tu): Likewise.
 359         (follow_die_sig_1): Likewise.
 360         * gdb/dwarf2read.h: Remove DEF_VEC_P.
 361         (typedef dwarf2_per_cu_ptr): Remove.
 362         (struct dwarf2_per_cu_data) <imported_symtabs_empty>: New
 363         function.
 364         (struct dwarf2_per_cu_data) <imported_symtabs_push>: New function.
 365         (struct dwarf2_per_cu_data) <imported_symtabs_size>: New function.
 366         (struct dwarf2_per_cu_data) <imported_symtabs_free>: New function.
 367         (struct dwarf2_per_cu_data) <imported_symtabs>: Change to
 368         std::vector.
 369
 370 2019-10-15  Tom Tromey  <tromey@adacore.com>
 371
 372         * windows-nat.c (windows_nat_target::resume): Use %x when logging
 373         TID.
 374
 375 2019-10-15  Tom Tromey  <tromey@adacore.com>
 376
 377         * windows-nat.c (windows_nat_target::fetch_registers)
 378         (windows_nat_target::store_registers): Rename "pid" to "tid".
 379
 380 2019-10-15  Tom Tromey  <tromey@adacore.com>
 381
 382         * gdbarch.h, gdbarch.c: Rebuild.
 383         * gdbarch.sh (gcc_target_options): Change return type to
 384         std::string.
 385         * compile/compile.c (get_args): Update.
 386         * nios2-tdep.c (nios2_gcc_target_options): Return std::string.
 387         * arm-linux-tdep.c (arm_linux_gcc_target_options): Return
 388         std::string.
 389         * aarch64-linux-tdep.c (aarch64_linux_gcc_target_options): Return
 390         std::string.
 391         * arch-utils.c (default_gcc_target_options): Return std::string.
 392         * arch-utils.h (default_gcc_target_options): Return std::string.
 393         * s390-tdep.c (s390_gcc_target_options): Return std::string.
 394
 395 2019-10-15  Christian Biesinger  <cbiesinger@google.com>
 396
 397         * breakpoint.c (breakpoint_chain): Make static.
 398         * tui/tui-winsource.c: Call iterate_over_breakpoints instead
 399         of accessing breakpoint_chain.
 400
 401 2019-10-15  Christian Biesinger  <cbiesinger@google.com>
 402
 403         * breakpoint.c (iterate_over_breakpoints): Change function pointer
 404         to a gdb::function_view and return value to bool.
 405         * breakpoint.h (iterate_over_breakpoints): Likewise.
 406         * dummy-frame.c (pop_dummy_frame_bpt): Update.
 407         (pop_dummy_frame): Update.
 408         * guile/scm-breakpoint.c (bpscm_build_bp_list): Update.
 409         (gdbscm_breakpoints): Update.
 410         * python/py-breakpoint.c (build_bp_list): Update.
 411         (gdbpy_breakpoints): Update.
 412         * python/py-finishbreakpoint.c (bpfinishpy_detect_out_scope_cb):
 413         Update.
 414         (bpfinishpy_handle_stop): Update.
 415         (bpfinishpy_handle_exit): Update.
 416         * solib-svr4.c (svr4_update_solib_event_breakpoint): Update.
 417         (svr4_update_solib_event_breakpoints): Update.
 418
 419 2019-10-15  Andreas Arnez  <arnez@linux.ibm.com>
 420
 421         * s390-tdep.c (s390_effective_inner_type): Ignore static fields
 422         when unwrapping single-field structs.
 423
 424 2019-10-14  Simon Marchi  <simon.marchi@polymtl.ca>
 425
 426         * dwarf2read.c: Remove includes.
 427
 428 2019-10-13  Simon Marchi  <simon.marchi@polymtl.ca>
 429
 430         * ui-out.c (ui_out::call_do_message): Silence
 431         -Wformat-nonliteral warning.
 432
 433 2019-10-12  Simon Marchi  <simon.marchi@polymtl.ca>
 434
 435         * breakpoint.c: Remove some includes: continuations.h, skip.h,
 436         mi/mi-main.h, readline/readline.h, readline/history.h.  Add
 437         include: readline/tilde.h.
 438
 439 2019-10-12  Christian Biesinger  <cbiesinger@google.com>
 440
 441         * remote.c (remote_target::get_trace_status): Remove declaration of
 442         trace_regblock_size.
 443
 444 2019-10-12  Christian Biesinger  <cbiesinger@google.com>
 445
 446         * cli/cli-cmds.c (max_user_call_depth): Move comment to header.
 447         (show_user): Remove declaration of cmdlist.
 448         * cli/cli-cmds.h (max_user_call_depth): Declare.
 449         * cli/cli-script.c (execute_user_command): Remove declaration
 450         of max_user_call_depth.
 451
 452 2019-10-11  Jim Wilson  <jimw@sifive.com>
 453
 454         * gdbsupport/print-utils.h (pulongest): Fix comment.
 455         (plongest): Likewise.
 456         (phex): Add missing comment, mention leading zeros.
 457         (phex_nz): Add mention of no leading zeros to comment.
 458
 459         * riscv-tdep.c (riscv_push_dummy_code): Change %lld to %s and use
 460         plongest instead of unsigned long long cast.
 461
 462 2019-10-10  Christian Biesinger  <cbiesinger@google.com>
 463
 464         * main.c (captured_main_1): Include gdbtk.h and remove declarations
 465         for external_editor_command and gdbtk_test.
 466
 467 2019-10-10  Christian Biesinger  <cbiesinger@google.com>
 468
 469         * mi/mi-cmd-var.c (varobjdebug): Remove declaration.
 470         * varobj.c (varobjdebug): Move comment to...
 471         * varobj.h (varobjdebug): ...here, and declare.
 472
 473 2019-10-09  Tom Tromey  <tom@tromey.com>
 474
 475         * tui/tui-regs.c (tui_data_window::show_registers): Don't call
 476         erase_data_content.
 477
 478 2019-10-09  Tom Tromey  <tom@tromey.com>
 479
 480         * tui/tui-wingeneral.h (tui_delete_win): Don't declare.
 481         * tui/tui-stack.c (tui_locator_window::rerender): Update.
 482         * tui/tui-command.c (tui_cmd_window::resize)
 483         (tui_refresh_cmd_win): Update.
 484         * tui/tui-win.c (tui_resize_all, tui_set_focus_command): Update.
 485         * tui/tui.c (tui_rl_other_window, tui_enable): Update.
 486         * tui/tui-data.c (~tui_gen_win_info): Remove.
 487         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
 488         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
 489         (tui_redisplay_readline, tui_mld_flush)
 490         (tui_mld_erase_entire_line, tui_mld_getc, tui_getc): Update.
 491         * tui/tui-regs.c (tui_data_window::delete_data_content_windows)
 492         (tui_data_window::erase_data_content)
 493         (tui_data_item_window::rerender)
 494         (tui_data_item_window::refresh_window): Update.
 495         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window)
 496         (box_win, tui_gen_win_info::make_window)
 497         (tui_gen_win_info::make_visible): Update.
 498         (tui_delete_win): Remove.
 499         * tui/tui-winsource.c
 500         (tui_source_window_base::do_erase_source_content): Update.
 501         (tui_show_source_line, tui_source_window_base::update_tab_width)
 502         (tui_source_window_base::update_exec_info): Update.
 503         * tui/tui-data.h (struct curses_deleter): New.
 504         (struct tui_gen_win_info) <handle>: Now a unique_ptr.
 505         (struct tui_gen_win_info) <~tui_gen_win_info>: Define.
 506
 507 2019-10-09  Tom Tromey  <tom@tromey.com>
 508
 509         * tui/tui-wingeneral.h (struct tui_gen_win_info): Don't declare.
 510
 511 2019-10-09  Tom Tromey  <tom@tromey.com>
 512
 513         * tui/tui-data.c (tui_win_is_auxiliary): Remove.
 514         * tui/tui-data.h (tui_win_is_auxiliary): Don't declare.
 515
 516 2019-10-09  Tom Tromey  <tom@tromey.com>
 517
 518         * tui/tui-disasm.c (tui_get_low_disassembly_address): Compute
 519         window height directly.
 520         * tui/tui-layout.h (tui_default_win_viewport_height): Don't
 521         declare.
 522         * tui/tui-layout.c (tui_default_win_height): Remove.
 523         (tui_default_win_viewport_height): Remove.
 524
 525 2019-10-09  Tom Tromey  <tom@tromey.com>
 526
 527         * tui/tui.h: Remove comments.
 528
 529 2019-10-09  Tom de Vries  <tdevries@suse.de>
 530
 531         * python/lib/gdb/printer/bound_registers.py: Use
 532         '^builtin_type_bound128' as regexp argument for
 533         add_builtin_pretty_printer.
 534
 535 2019-10-09  Christian Biesinger  <cbiesinger@google.com>
 536
 537         * guile/guile.c (guile_extension_script_ops): Remove forward
 538         declaration and mark as static.
 539         (guile_script_ops): Likewise.
 540         (extension_language_guile): Move further down in the file so
 541         it can reference the definitions for guile_{extension_,}script_ops.
 542
 543 2019-10-09  Andreas Arnez  <arnez@linux.ibm.com>
 544
 545         * s390-tdep.c (390_process_record): Handle new arch13 instructions
 546         except SORTL, DFLTCC, and KDSA.
 547
 548 2019-10-08  Tom Tromey  <tromey@adacore.com>
 549
 550         * windows-nat.c (struct windows_thread_info_struct) <sf>: Remove.
 551         (struct safe_symbol_file_add_args): Remove.
 552
 553 2019-10-08  Tom Tromey  <tromey@adacore.com>
 554
 555         * windows-nat.c: Don't include buildsym-legacy.h.
 556
 557 2019-10-08  Tom Tromey  <tromey@adacore.com>
 558
 559         * contrib/ari/gdb_ari.sh (%p): Allow gdb-specific %p extensions.
 560
 561 2019-10-08  Christian Biesinger  <cbiesinger@google.com>
 562
 563         * gdbtypes.c (overload_debug): Move comment to header.
 564         * gdbtypes.h (overload_debug): Declare.
 565         * valops.c: Remove declaration of overload_debug, instead
 566         include gdbtypes.h.
 567
 568 2019-10-08  Christian Biesinger  <cbiesinger@google.com>
 569
 570         * language.c (show_language_command): Pass lang_frame_mismatch_warn
 571         through _().
 572         (lang_frame_mismatch_warn): Make const, mark with N_(), and
 573         move comment...
 574         * language.h (lang_frame_mismatch_warn): ... here. Also add
 575         declaration.
 576         * top.c (lang_frame_mismatch_warn): Remove declaration.
 577         (check_frame_language_change): Pass lang_frame_mismatch_warn
 578         through _().
 579
 580 2019-10-07  Christian Biesinger  <cbiesinger@google.com>
 581
 582         * c-lang.h (vtbl_ptr_name): Declare.
 583         * cp-valprint.c (vtbl_ptr_name): Remove "extern" now that we get
 584         it from the header.
 585         * stabsread.c (define_symbol): Remove declaration of vtbl_ptr_name.
 586
 587 2019-10-07  Christian Biesinger  <cbiesinger@google.com>
 588
 589         * charset.c (your_gdb_wchar_t_is_bogus): Replace with a
 590         gdb_static_assert.
 591
 592 2019-10-07  Weimin Pan  <weimin.pan@oracle.com>
 593
 594         * ../Makefile.def (dependencies): Add all-libctf to all-gdb
 595         * ../Makefile.in: Add "all-gdb: maybe-all-libctf"
 596         * ctfread.c: New file.
 597         * ctfread.h: New file.
 598         * elfread.c: Include ctfread.h.
 599         (struct elfinfo text_p): New member ctfsect.
 600         (elf_locate_sections): Mark CTF section.
 601         (elf_symfile_read): Call elfctf_build_psymtabs.
 602         * Makefile.in (LIBCTF): Add.
 603         (CLIBS): Use it.
 604         (CDEPS): Likewise.
 605         (DIST): Add ctfread.c.
 606
 607 2019-10-07  Andrew Burgess  <andrew.burgess@embecosm.com>
 608
 609         * ctfread.c (struct nextfield): Renamed to ...
 610         (struct ctf_nextfield): ... this.
 611         (struct field_info): Renamed to ...
 612         (strut ctf_field_info): ... this.
 613         (attach_fields_to_type): Update for renamed structures.
 614         (ctf_add_member_cb): Likewise.
 615         (ctf_add_enum_member_cb): Likewise.
 616         (process_struct_members): Likewise.
 617         (process_enum_type): Likewise.
 618
 619 2019-10-07  Weimin Pan  <weimin.pan@oracle.com>
 620
 621         * tracectf.h: Rename, was ctf.h.
 622         * tracectf.c: Rename, was ctf.c, replace ctf.h with tracectf.h.
 623         * tracefile.c: Likewise.
 624         * tracepoint.c: Remove unused include ctf.h.
 625         * mi/mi-main.c: Likewise.
 626         * Makefile.in Replace ctf.c with tracectf.c.
 627
 628 2019-10-06  Joel Brobecker  <brobecker@adacore.com>
 629
 630         * version.in: Change version number to "9.0.50.DATE-git".
 631
 632 2019-10-03  Tom Tromey  <tom@tromey.com>
 633
 634         PR rust/24976:
 635         * dwarf2read.c (quirk_rust_enum): Handle single-element unions.
 636
 637 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
 638
 639         * f-lang.c (f_language_defn): Use cp_get_symbol_name_matcher and
 640         cp_search_name_hash.
 641         * NEWS: Add entry about nested function support.
 642
 643 2019-10-03  Bernhard Heckel  <bernhard.heckel@intel.com>
 644             Andrew Burgess  <andrew.burgess@embecosm.com>
 645
 646         * cp-namespace.c (cp_search_static_and_baseclasses): Only search
 647         for nested static variables when searchin VAR_DOMAIN.
 648         * dwarf2read.c (add_partial_symbol): Add nested subroutines to the
 649         global scope, update comment.
 650         (add_partial_subprogram): Call add_partial_subprogram recursively
 651         for nested subroutines when processinng Fortran.
 652         (load_partial_dies): Process the child entities of a subprogram
 653         when processing Fortran.
 654         (partial_die_parent_scope): Handle building scope
 655         for Fortran nested functions.
 656         (process_die): Record that nested functions have a scope.
 657         (new_symbol): Always record Fortran subprograms on the global
 658         symbol list.
 659         (determine_prefix): How to build the prefix for Fortran
 660         subprograms.
 661
 662 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
 663
 664         * linux-nat.c (linux_nat_filter_event): Don't ignore SIGSTOP if we
 665         have just sent the thread a SIGSTOP and are waiting for it to
 666         arrive.
 667
 668 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
 669
 670         * btrace.c (btrace_add_pc): Remove whitespace before the template
 671         parameter in 'std::vector <...>'.
 672         (parse_xml_btrace_block): Likewise.
 673         (btrace_maint_decode_pt): Likewise.
 674         (btrace_maint_update_packets): Likewise.
 675         (btrace_maint_print_packets): Likewise.
 676         * btrace.h (struct btrace_maint_info): Likewise.
 677         * dwarf2read.c (struct type_unit_group): Likewise.
 678         (build_type_psymtabs_reader): Likewise.
 679         * gdbsupport/btrace-common.c (btrace_data_append): Likewise.
 680         * gdbsupport/btrace-common.h (struct btrace_data_bts): Likewise.
 681         * nat/linux-btrace.c (perf_event_read_bts): Likewise.
 682
 683 2019-10-03  Tom de Vries  <tdevries@suse.de>
 684
 685         * cli/cli-style.c (_initialize_cli_style): Adding a '.' at the end of
 686         the first line of the help text for set/show style metadata.
 687
 688 2019-10-02  Tom Tromey  <tromey@adacore.com>
 689
 690         * Makefile.in (COMMON_SFILES): Add common-inferior.c.
 691         * gdbsupport/common-inferior.c: New file.
 692         * infcmd.c (startup_with_shell): Don't define.
 693         * nat/fork-inferior.h (startup_with_shell): Don't declare.
 694         * gdbsupport/common-inferior.h (startup_with_shell): Declare.
 695         * inferior.h (startup_with_shell): Don't declare.
 696
 697 2019-10-02  Christian Biesinger  <cbiesinger@google.com>
 698
 699         * gdbsupport/gdb_assert.h: Include errors.h.
 700         * gdbsupport/gdb_string_view.h: Include gdb_assert.h.
 701
 702 2019-10-02  Tom Tromey  <tromey@adacore.com>
 703
 704         * NEWS: Add $_ada_exception entry.
 705         * ada-lang.c (struct ada_catchpoint): Add constructor.
 706         <m_kind>: New member.
 707         (allocate_location_exception, re_set_exception): Remove
 708         "ex" parameter.
 709         (should_stop_exception): Compute $_ada_exception.
 710         (check_status_exception, print_it_exception)
 711         (print_one_exception, print_mention_exception): Remove
 712         "ex" parameter.
 713         (allocate_location_catch_exception, re_set_catch_exception)
 714         (check_status_exception, print_it_catch_exception)
 715         (print_one_catch_exception, print_mention_catch_exception)
 716         (print_recreate_catch_exception)
 717         (allocate_location_catch_exception_unhandled)
 718         (re_set_catch_exception_unhandled)
 719         (check_status_exception, print_it_catch_exception_unhandled)
 720         (print_one_catch_exception_unhandled)
 721         (print_mention_catch_exception_unhandled)
 722         (print_recreate_catch_exception_unhandled)
 723         (allocate_location_catch_assert, re_set_catch_assert)
 724         (check_status_assert, print_it_catch_assert)
 725         (print_one_catch_assert, print_mention_catch_assert)
 726         (print_recreate_catch_assert)
 727         (allocate_location_catch_handlers, re_set_catch_handlers)
 728         (check_status_handlers, print_it_catch_handlers)
 729         (print_one_catch_handlers, print_mention_catch_handlers)
 730         (print_recreate_catch_handlers): Remove.
 731         (create_ada_exception_catchpoint): Update.
 732         (initialize_ada_catchpoint_ops): Update.
 733
 734 2019-10-02  Tom Tromey  <tromey@adacore.com>
 735
 736         * ada-lang.c (ada_lookup_simple_minsyms): Remove.
 737         (create_excep_cond_exprs): Simplify exception string computation.
 738         (ada_exception_catchpoint_cond_string): Likewise.
 739
 740 2019-10-02  Tom Tromey  <tromey@adacore.com>
 741
 742         * symmisc.c (dump_msymbols): Don't use MSYMBOL_VALUE_ADDRESS.
 743         * ada-lang.c (lesseq_defined_than): Handle
 744         LOC_STATIC.
 745         * dwarf2read.c (dwarf2_per_objfile): Add can_copy
 746         parameter.
 747         (dwarf2_has_info): Likewise.
 748         (new_symbol): Set maybe_copied on symbol when
 749         appropriate.
 750         * dwarf2read.h (dwarf2_per_objfile): Add can_copy
 751         parameter.
 752         <can_copy>: New member.
 753         * elfread.c (record_minimal_symbol): Set maybe_copied
 754         on symbol when appropriate.
 755         (elf_symfile_read): Update call to dwarf2_has_info.
 756         * minsyms.c (lookup_minimal_symbol_linkage): New
 757         function.
 758         * minsyms.h (lookup_minimal_symbol_linkage): Declare.
 759         * symtab.c (get_symbol_address, get_msymbol_address):
 760         New functions.
 761         * symtab.h (get_symbol_address, get_msymbol_address):
 762         Declare.
 763         (SYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_ADDRESS): Handle
 764         maybe_copied.
 765         (struct symbol, struct minimal_symbol) <maybe_copied>:
 766         New member.
 767
 768 2019-10-02  Tom Tromey  <tromey@adacore.com>
 769
 770         * source.c (struct current_source_location): New.
 771         (current_source_key): New global.
 772         (current_source_symtab, current_source_line)
 773         (current_source_pspace): Remove.
 774         (get_source_location): New function.
 775         (get_current_source_symtab_and_line)
 776         (set_default_source_symtab_and_line)
 777         (set_current_source_symtab_and_line)
 778         (clear_current_source_symtab_and_line, select_source_symtab)
 779         (info_source_command, print_source_lines_base)
 780         (info_line_command, search_command_helper, _initialize_source):
 781         Update.
 782
 783 2019-10-02  Tom Tromey  <tromey@adacore.com>
 784
 785         * source.c (select_source_symtab): Don't call
 786         decode_line_with_current_source.
 787
 788 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
 789
 790         * symtab.c (lookup_global_symbol): Search global block.
 791
 792 2019-10-02  Tom Tromey  <tromey@adacore.com>
 793
 794         * coffread.c (process_coff_symbol): Update.
 795         * dwarf2read.c (var_decode_location, new_symbol): Update.
 796         * mdebugread.c (parse_symbol): Update.
 797         * objfiles.c (relocate_one_symbol): Update.
 798         * stabsread.c (define_symbol, fix_common_block)
 799         (scan_file_globals): Update.
 800         * symtab.h (SYMBOL_VALUE_ADDRESS): Expand to an rvalue.
 801         (SET_SYMBOL_VALUE_ADDRESS): New macro.
 802         * xcoffread.c (process_xcoff_symbol): Update.
 803
 804 2019-10-02  Andreas Arnez  <arnez@linux.ibm.com>
 805
 806         * MAINTAINERS: Update my email address.
 807
 808 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
 809
 810         * dwarf2read.c (struct type_unit_group) <tus>: Convert to
 811         std::vector.
 812         (build_type_psymtabs_reader): Update for std::vector.
 813         (build_type_psymtab_dependencies): Likewise.
 814         * dwarf2read.h: Remove use of DEF_VEC_P.
 815         (typedef sig_type_ptr): Delete.
 816
 817 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
 818
 819         * btrace.c (btrace_maint_clear): Update to handle change from VEC
 820         to std::vector.
 821         (btrace_maint_decode_pt): Likewise, and move allocation of the
 822         vector outside of the loop.
 823         (btrace_maint_update_packets): Update to handle change from VEC to
 824         std::vector.
 825         (btrace_maint_print_packets): Likewise.
 826         (maint_info_btrace_cmd): Likewise.
 827         * btrace.h: Remove use of DEF_VEC_O.
 828         (typedef btrace_pt_packet_s): Delete.
 829         (struct btrace_maint_info) <packets>: Change fromm VEC to
 830         std::vector.
 831         * gdbsupport/btrace-common.h: Remove 'vec.h' include.
 832
 833 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
 834
 835         * btrace.c (btrace_compute_ftrace_bts): Update for std::vector,
 836         make accesses into the vector constant references.
 837         (btrace_add_pc): Update for std::vector.
 838         (btrace_stitch_bts): Likewise.
 839         (parse_xml_btrace_block): Likewise.
 840         (btrace_maint_update_packets): Likewise.
 841         (btrace_maint_print_packets): Likewise.
 842         (maint_info_btrace_cmd): Likewise.
 843         * gdbsupport/btrace-common.c (btrace_data::fini): Update for
 844         std::vector.
 845         (btrace_data::empty): Likewise.
 846         (btrace_data_append): Likewise.
 847         * gdbsupport/btrace-common.h: Remove use of DEF_VEC_O.
 848         (typedef btrace_block_s): Delete.
 849         (struct btrace_block): Add constructor.
 850         (struct btrace_data_bts) <blocks>: Change to std::vector.
 851         * nat/linux-btrace.c (perf_event_read_bts): Update for
 852         std::vector.
 853         (linux_read_bts): Likewise.
 854
 855 2019-10-01  Tom Tromey  <tom@tromey.com>
 856
 857         * cli/cli-logging.c (show_logging_filename): Use styled_string.
 858
 859 2019-10-01  Tom Tromey  <tom@tromey.com>
 860
 861         * stack.c (print_frame, info_frame_command_core): Use
 862         styled_string.
 863         * linux-thread-db.c (try_thread_db_load_1)
 864         (try_thread_db_load_from_pdir_1): Use styled_string.
 865         * auto-load.c (file_is_auto_load_safe, execute_script_contents)
 866         (auto_load_section_scripts, info_auto_load_local_gdbinit)
 867         (maybe_print_unsupported_script_warning)
 868         (maybe_print_script_not_found_warning): Use styled_string.
 869         * ada-lang.c (user_select_syms): Use styled_string.
 870
 871 2019-10-01  Tom Tromey  <tom@tromey.com>
 872
 873         * p-lang.c (pascal_printstr): Use metadata style.
 874         * value.c (show_convenience): Use metadata style.
 875         * valprint.c (valprint_check_validity, val_print_optimized_out)
 876         (val_print_not_saved, val_print_unavailable)
 877         (val_print_invalid_address, generic_val_print, val_print)
 878         (value_check_printable, val_print_array_elements): Use metadata
 879         style.
 880         * ui-out.h (class ui_out) <field_fmt>: New overload.
 881         <do_field_fmt>: Add style parameter.
 882         * ui-out.c (ui_out::field_fmt): New overload.
 883         * typeprint.c (type_print_unknown_return_type)
 884         (val_print_not_allocated, val_print_not_associated): Use metadata
 885         style.
 886         * tui/tui-out.h (class tui_ui_out) <do_field_fmt>: Add style
 887         parameter.
 888         * tui/tui-out.c (tui_ui_out::do_field_fmt): Update.
 889         * tracepoint.c (tvariables_info_1): Use metadata style.
 890         * stack.c (print_frame_arg, print_frame_info, print_frame)
 891         (info_frame_command_core): Use metadata style.
 892         * skip.c (info_skip_command): Use metadata style.
 893         * rust-lang.c (rust_print_enum): Use metadata style.
 894         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
 895         metadata style.
 896         * python/py-framefilter.c (py_print_single_arg): Use metadata
 897         style.
 898         * printcmd.c (do_one_display, print_variable_and_value): Use
 899         metadata style.
 900         * p-valprint.c (pascal_val_print)
 901         (pascal_object_print_value_fields): Use metadata style.
 902         * p-typeprint.c (pascal_type_print_base): Use metadata style.
 903         * mi/mi-out.h (class mi_ui_out) <do_field_fmt>: Add style
 904         parameter.
 905         * mi/mi-out.c (mi_ui_out::do_field_fmt): Update.
 906         * m2-valprint.c (m2_print_long_set): Use metadata style.
 907         * m2-typeprint.c (m2_print_type): Use metadata style.
 908         * infcmd.c (print_return_value_1): Use metadata style.
 909         * gnu-v3-abi.c (print_one_vtable): Use metadata style.
 910         * f-valprint.c (info_common_command_for_block): Use metadata
 911         style.
 912         * f-typeprint.c (f_type_print_base): Use metadata style.
 913         * expprint.c (print_subexp_standard): Use metadata style.
 914         * cp-valprint.c (cp_print_value_fields): Use metadata style.
 915         * cli/cli-style.h (class cli_style_option): Add constructor.
 916         (metadata_style): Declare.
 917         * cli/cli-style.c (metadata_style): New global.
 918         (_initialize_cli_style): Register metadata style.
 919         * cli-out.h (class cli_ui_out) <do_field_fmt>: Add style
 920         parameter.
 921         * cli-out.c (cli_ui_out::do_field_fmt): Update.
 922         * c-typeprint.c (c_type_print_base_struct_union)
 923         (c_type_print_base_1): Use metadata style.
 924         * breakpoint.c (watchpoint_value_print)
 925         (print_one_breakpoint_location): Use metadata style.
 926         * break-catch-syscall.c (print_one_catch_syscall): Use metadata
 927         style.
 928         * break-catch-sig.c (signal_catchpoint_print_one): Use metadata
 929         style.
 930         * ada-valprint.c (val_print_packed_array_elements, printstr)
 931         (print_field_values, ada_val_print_ref, ada_val_print): Use
 932         metadata style.
 933         * ada-typeprint.c (print_array_type, ada_print_type): Use metadata
 934         style.
 935         * ada-tasks.c (print_ada_task_info, info_task): Use metadata
 936         style.
 937         * ada-lang.c (user_select_syms): Use metadata style.
 938
 939 2019-10-01  Tom Tromey  <tom@tromey.com>
 940
 941         * cli/cli-cmds.c (pwd_command): Style output.
 942
 943 2019-10-01  Pedro Alves  <palves@redhat.com>
 944             Tom Tromey  <tom@tromey.com>
 945
 946         * symtab.c (print_symbol_info): Use %ps.
 947         (print_msymbol_info): Use %ps.
 948         * symfile.c (symbol_file_add_with_addrs): Use %ps.
 949         * printcmd.c (print_variable_and_value): Use %ps.
 950         * macrocmd.c (show_pp_source_pos): Use %ps.
 951         * infrun.c (print_exited_reason): Use ui_out::message.
 952         * breakpoint.c (watchpoint_check, print_one_breakpoint_location)
 953         (describe_other_breakpoints): Use ui_out::message and new
 954         formats.
 955         (say_where): Use new formats.
 956         (bkpt_print_it, tracepoint_print_one_detail): Use ui_out::message
 957         and new formats.
 958
 959 2019-10-01  Pedro Alves  <palves@redhat.com>
 960             Tom Tromey  <tom@tromey.com>
 961
 962         * unittests/format_pieces-selftests.c: Add gdb_format parameter.
 963         (test_gdb_formats): New function.
 964         (run_tests): Call it.
 965         (test_format_specifier): Update.
 966         * utils.h (fputs_filtered): Update comment.
 967         (vfprintf_styled, vfprintf_styled_no_gdbfmt)
 968         (fputs_styled_unfiltered): Declare.
 969         * utils.c (fputs_styled_unfiltered): New function.
 970         (vfprintf_maybe_filtered): Add gdbfmt parameter.
 971         (vfprintf_filtered): Update.
 972         (vfprintf_unfiltered, vprintf_filtered): Update.
 973         (vfprintf_styled, vfprintf_styled_no_gdbfmt): New functions.
 974         * ui-out.h (enum ui_out_flag) <unfiltered_output,
 975         disallow_ui_out_field>: New constants.
 976         (enum class field_kind): New.
 977         (struct base_field_s, struct signed_field_s): New.
 978         (signed_field): New function.
 979         (struct string_field_s): New.
 980         (string_field): New function.
 981         (struct styled_string_s): New.
 982         (styled_string): New function.
 983         (class ui_out) <message>: Add comment.
 984         <vmessage, call_do_message>: New methods.
 985         <do_message>: Add style parameter.
 986         * ui-out.c (ui_out::call_do_message, ui_out::vmessage): New
 987         methods.
 988         (ui_out::message): Rewrite.
 989         * mi/mi-out.h (class mi_ui_out) <do_message>: Add style
 990         parameter.
 991         * mi/mi-out.c (mi_ui_out::do_message): Add style parameter.
 992         * gdbsupport/format.h (class format_pieces) <format_pieces>: Add
 993         gdb_extensions parameter.
 994         (class format_piece): Add parameter to constructor.
 995         (n_int_args): New field.
 996         * gdbsupport/format.c (format_pieces::format_pieces): Add
 997         gdb_extensions parameter.  Handle '*'.
 998         * cli-out.h (class cli_ui_out) <do_message>: Add style parameter.
 999         * cli-out.c (cli_ui_out::do_message): Add style parameter.  Call
1000         vfprintf_styled_no_gdbfmt.
1001         (cli_ui_out::do_field_string, cli_ui_out::do_spaces)
1002         (cli_ui_out::do_text, cli_ui_out::field_separator): Allow
1003         unfiltered output.
1004         * ui-style.h (struct ui_file_style) <ptr>: New method.
1005
1006 2019-10-01  Tom Tromey  <tom@tromey.com>
1007
1008         * unittests/format_pieces-selftests.c: Update.  Add final format.
1009         * gdbsupport/format.c (format_pieces::format_pieces): Don't add
1010         empty literal pieces.
1011
1012 2019-10-01  Tom Tromey  <tom@tromey.com>
1013
1014         * ui-out.h (enum class ui_out_style_kind): Remove.
1015         (class ui_out) <field_string, field_stsream, do_field_string>:
1016         Change type of "style".
1017         * ui-out.c (ui_out::field_core_addr, ui_out::field_stream)
1018         (ui_out::field_string): Update.
1019         * tui/tui-out.h (class tui_ui_out) <do_field_string>: Change type
1020         of "style".
1021         * tui/tui-out.c (tui_ui_out::do_field_string): Update.
1022         * tracepoint.c (print_one_static_tracepoint_marker): Update.
1023         * stack.c (print_frame_arg, print_frame_info, print_frame):
1024         Update.
1025         * source.c (print_source_lines_base): Update.
1026         * solib.c (info_sharedlibrary_command): Update.
1027         * skip.c (info_skip_command): Update.
1028         * record-btrace.c (btrace_call_history_src_line)
1029         (btrace_call_history): Update.
1030         * python/py-framefilter.c (py_print_frame): Update.
1031         * mi/mi-out.h (class mi_ui_out) <do_field_string>: Change type of
1032         "style".
1033         * mi/mi-out.c (mi_ui_out::do_table_header)
1034         (mi_ui_out::do_field_signed, mi_ui_out::do_field_unsigned)
1035         (mi_ui_out::do_field_string): Update.
1036         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
1037         Update.
1038         * cli-out.h (class cli_ui_out) <do_field_string>: Change type of
1039         "style".
1040         * cli-out.c (cli_ui_out::do_table_header)
1041         (cli_ui_out::do_field_signed, cli_ui_out::do_field_unsigned)
1042         (cli_ui_out::do_field_skip, cli_ui_out::do_field_string)
1043         (cli_ui_out::do_field_fmt): Update.
1044         * breakpoint.c (print_breakpoint_location): Update.
1045         (update_static_tracepoint): Update.
1046
1047 2019-10-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1048
1049         * main.c (relocate_gdbinit_path_maybe_in_datadir): Remove std::string
1050         conversion of gdb_datadir.
1051         (captured_main_1): Remove xstrdup when assigning to gdb_datadir,
1052         remove not needed c_str ().
1053
1054 2019-09-30  Ali Tamur <tamur@google.com>
1055
1056         * dwarf2read.c (skip_one_die): Handle DW_FORM_strx forms.
1057         (dwarf2_string_attr): Likewise.
1058
1059 2019-09-30  Ali Tamur <tamur@google.com>
1060
1061         * dwarf2read.c (process_full_comp_unit): Remove whitespace at the EOL.
1062         (process_full_type_unit): Likewise.
1063         (dump_die_shallow): Likewise.
1064         (cu_debug_loc_section): Likewise.
1065
1066 2019-09-28  Christian Biesinger  <cbiesinger@google.com>
1067
1068         * minsyms.c (compare_minimal_symbols): Rename to...
1069         (minimal_symbol_is_less_than): ...this, and adjust to STL
1070         conventions (return bool, take arguments as references)
1071         (minimal_symbol_reader::install): Call std::sort instead
1072         of qsort.
1073
1074 2019-09-29  Christian Biesinger  <cbiesinger@google.com>
1075
1076         * minsyms.h (msymbol_hash): Document that this is a case-insensitive
1077         hash and why.
1078         * objfiles.h (struct objfile_per_bfd_storage) <demangled_names_hash,
1079         msymbol_hash, msymbol_demangled_hash>: Improve comments.
1080
1081 2019-09-30  Simon Marchi  <simon.marchi@polymtl.ca>
1082
1083         * psymtab.c (add_psymbol_to_list): Move comment to psympriv.h.
1084         * psympriv.h (add_psymbol_to_list): Move comment here and update
1085         it.
1086
1087 2019-09-29  Tom de Vries  <tdevries@suse.de>
1088
1089         * contrib/cc-with-tweaks.sh (get_tmpdir): New function.
1090         Use $tmpdir/$(basename "$output_file").dwz instead of
1091         "${output_file}.dwz".
1092
1093 2019-09-28  Simon Marchi  <simon.marchi@polymtl.ca>
1094
1095         PR gdb/25045
1096         * hppa-linux-nat.c: Include gdbarch.h.
1097
1098 2019-09-26  Christian Biesinger  <cbiesinger@google.com>
1099
1100         * blockframe.c (find_pc_partial_function): Change return type to bool.
1101         * elfread.c (elf_gnu_ifunc_resolve_name): Likewise.
1102         * minsyms.c (in_gnu_ifunc_stub): Likewise.
1103         (stub_gnu_ifunc_resolve_name): Likewise.
1104         * symtab.c (compare_filenames_for_search): Likewise.
1105         (compare_glob_filenames_for_search): Likewise.
1106         (matching_obj_sections): Likewise.
1107         (symbol_matches_domain): Likewise.
1108         (find_line_symtab): Change out param EXACT_MATCH to bool *.
1109         (find_line_pc): Change return type to bool.
1110         (find_line_pc_range): Likewise.
1111         (producer_is_realview): Likewise.
1112         * symtab.h (symbol_matches_domain): Likewise.
1113         (find_pc_partial_function): Likewise.
1114         (find_pc_line_pc_range): Likewise.
1115         (in_gnu_ifunc_stub): Likewise.
1116         (struct gnu_ifunc_fns) <gnu_ifunc_resolve_name>: Likewise.
1117         (find_line_pc): Likewise.
1118         (find_line_pc_range): Likewise.
1119         (matching_obj_sections): Likewise.
1120         (find_line_symtab): Change out parameter to bool.
1121         (producer_is_realview): Change return type to bool.
1122         (compare_filenames_for_search): Likewise.
1123         (compare_glob_filenames_for_search): Likewise.
1124
1125 2019-09-26  Tom Tromey  <tom@tromey.com>
1126
1127         * Makefile.in (COMMON_SFILES): Remove gdb_usleep.c.
1128         (HFILES_NO_SRCDIR): Remove gdb_usleep.h.
1129         * gdb_usleep.h: Remove.
1130         * gdb_usleep.c: Remove.
1131         * utils.c: Don't include gdb_usleep.h.
1132
1133 2019-09-26  Tom Tromey  <tromey@adacore.com>
1134
1135         * python/py-type.c (type_to_type_object): Call check_typedef
1136         for stub types.
1137
1138 2019-09-26  Tom Tromey  <tom@tromey.com>
1139
1140         * utils.h (initialize_utils): Don't declare.
1141         * top.c (gdb_init): Don't call initialize_utils.
1142         * utils.c (initialize_utils): Remove.  Move contents...
1143         (_initialize_utils): ... here.
1144
1145 2019-09-25  Tom Tromey  <tom@tromey.com>
1146
1147         * python/py-objfile.c (objfpy_get_build_id): Use bin2hex.
1148         * utils.h (make_hex_string): Don't declare.
1149         * utils.c (make_hex_string): Remove.
1150
1151 2019-09-24  Tom de Vries  <tdevries@suse.de>
1152
1153         PR gdb/23815
1154         * amd64-linux-nat.c (amd64_linux_nat_target::fetch_registers):
1155         Initialize xstateregs before ptrace PTRACE_GETREGSET call.
1156
1157 2019-09-23  Dimitar Dimitrov  <dimitar@dinux.eu>
1158
1159         * NEWS: Mention new simulator port for PRU.
1160
1161 2019-09-23  Christian Biesinger  <cbiesinger@google.com>
1162
1163         * ada-exp.y (write_object_remaining): Update.
1164         * ada-lang.c (ada_decode): Return a std::string instead of a char*
1165         and eliminate the static buffer.
1166         (ada_decode_symbol): Update.
1167         (ada_la_decode): Update.
1168         (ada_sniff_from_mangled_name): Update.
1169         (is_valid_name_for_wild_match): Update.
1170         (ada_lookup_name_info::matches): Update and simplify.
1171         (name_matches_regex): Update.
1172         (ada_add_global_exceptions): Update.
1173         * ada-lang.h (ada_decode): Update signature.
1174         * ada-varobj.c (ada_varobj_describe_simple_array_child): Update.
1175         * dwarf-index-write.c (debug_names::insert): Update.
1176
1177 2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>
1178
1179         * solib-svr4.c (svr4_iterate_over_objfiles_in_search_order): Fix
1180         formatting.
1181
1182 2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>
1183
1184         * breakpoint.h (bp_location) <inserted, permanent, duplicate>:
1185         Change "nonzero" to "true" in documentation.
1186
1187 2019-09-20  Christian Biesinger  <cbiesinger@google.com>
1188
1189         * solib-darwin.c (darwin_lookup_lib_symbol): Remove.
1190         (_initialize_darwin_solib): Don't set
1191         darwin_so_ops.lookup_lib_global_symbol.
1192         * solib-svr4.c (set_solib_svr4_fetch_link_map_offsets): Call
1193         set_gdbarch_iterate_over_objfiles_in_search_order.
1194         (elf_lookup_lib_symbol): Rename to...
1195         (svr4_iterate_over_objfiles_in_search_order): this, and update
1196         to iterate semantics.
1197         (_initialize_svr4_solib): Don't set lookup_lib_global_symbol.
1198         * solib.c (solib_global_lookup): Remove.
1199         * solist.h (struct target_so_ops): Remove lookup_lib_global_symbol.
1200         (solib_global_lookup): Remove.
1201         * symtab.c (lookup_global_or_static_symbol): Remove call to
1202         solib_global_lookup.
1203
1204 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
1205
1206         * NEWS: Move entries about default MI version now being
1207         version 3, and about the GDB/MI fix for multi-location
1208         breakpoints to the "since GDB 8.3" section.
1209
1210 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
1211
1212         GDB 8.3.1 released.
1213
1214 2019-09-20  Ulrich Weigand  <uweigand@de.ibm.com>
1215
1216         * NEWS: Mention that Cell/B.E. debugging support was removed.
1217         * MAINTAINERS: Remove spu target.
1218
1219         * config/djgpp/fnchange.lst: Remove entries for removed files.
1220
1221         * Makefile.in (ALL_TARGET_OBS): Remove solib-spu.o,
1222         spu-multiarch.o, and spu-tdep.o.
1223         (HFILES_NO_SRCDIR): Remove solib-spu.h and spu-tdep.h.
1224         (ALLDEPFILES): Remove solib-spu.c, spu-linux-nat.c,
1225         spu-multiarch.c, and spu-tdep.c.
1226         * spu-linux-nat.c: Remove file.
1227         * spu-multiarch.c: Remove file.
1228         * spu-tdep.c: Remove file.
1229         * spu-tdep.h: Remove file.
1230         * solib-spu.c: Remove file.
1231         * solib-spu.h: Remove file.
1232
1233         * configure.host (powerpc64*-*-linux*): Remove Cell/B.E. support.
1234         * configure.nat (spu-linux): Remove.
1235         * configure.tgt (powerpc*-*-linux*): Remove solib-spu.o and
1236         solib-multiarch.o from gdb_target_obs.
1237         (spu*-*-*): Remove.
1238
1239         * arch/ppc-linux-common.h (struct ppc_linux_features): Remove "cell"
1240         feature flag.
1241         (ppc_linux_no_features): Update.
1242         * arch/ppc-linux-common.c (ppc_linux_match_description): Remove
1243         Cell/B.E. support.
1244         * arch/ppc-linux-tdesc.h (tdesc_powerpc_cell32l): Remove declaration.
1245         (tdesc_powerpc_cell64l): Likewise.
1246         * nat/ppc-linux.h (PPC_FEATURE_CELL): Remove.
1247         * ppc-linux-nat.c (ppc_linux_nat_target::read_description): Remove
1248         Cell/B.E. support.
1249         * ppc-linux-tdep.h: Do not include "solib-spu.h" or "spu-tdep.h".
1250         Do not include "features/rs6000/powerpc-cell32l.c" or
1251         "features/rs6000/powerpc-cell64l.c".
1252         (ppc_linux_spu_section): Remove.
1253         (ppc_linux_core_read_description): Remove Cell/B.E. support.
1254         (spe_context_objfile, spe_context_lm_addr, spe_context_offset,
1255         spe_context_cache_ptid, spe_context_cache_ptid): Remove.
1256         (ppc_linux_spe_context_lookup): Remove.
1257         (ppc_linux_spe_context_inferior_created): Remove.
1258         (ppc_linux_spe_context_solib_loaded): Remove.
1259         (ppc_linux_spe_context_solib_unloaded): Remove.
1260         (ppc_linux_spe_context): Remove.
1261         (struct ppu2spu_cache): Remove.
1262         (ppu2spu_prev_arch, ppu2spu_this_id, ppu2spu_prev_register): Remove.
1263         (struct ppu2spu_data): Remove.
1264         (ppu2spu_unwind_register, ppu2spu_sniffer, ppu2spu_dealloc_cache,
1265         ppu2spu_unwind): Remove.
1266         (ppc_linux_init_abi): Remove Cell/B.E. support.
1267         * rs6000-tdep.h (rs6000_gdbarch_init): Remove Cell/B.E. support.
1268
1269         * features/Makefile (rs6000/powerpc-cell32l-expedite): Remove.
1270         (rs6000/powerpc-cell64l-expedite): Likewise
1271         (WHICH): Remove rs6000/powerpc-cell32l and rs6000/powerpc-cell64l.
1272         (XMLTOC): Remove rs6000/powerpc-cell32l.xml and
1273         rs6000/powerpc-cell64l.xml.
1274         * features/rs6000/powerpc-cell32l.xml: Remove.
1275         * features/rs6000/powerpc-cell64l.xml: Likewise.
1276         * features/rs6000/powerpc-cell32l.c: Remove generated file.
1277         * features/rs6000/powerpc-cell64l.c: Likewise.
1278         * regformats/rs6000/powerpc-cell32l.dat: Remove generated file.
1279         * regformats/rs6000/powerpc-cell64l.dat: Likewise.
1280         * regformats/reg-spu.dat: Remove.
1281
1282         * target.h (enum target_object): Remove TARGET_OBJECT_SPU.
1283         * corelow.c (struct spuid_list): Remove.
1284         (add_to_spuid_list): Remove.
1285         (core_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
1286         * remote.c (PACKET_qXfer_spu_read, PACKET_qXfer_spu_write): Remove.
1287         (remote_protocol_features): Remove associated entries.
1288         (_initialize_remote): No longer initialize them.
1289         (remote_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
1290         * linux-nat.c (SPUFS_MAGIC): Remove.
1291         (linux_proc_xfer_spu): Remove.
1292         (spu_enumerate_spu_ids): Remove.
1293         (linux_nat_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
1294         * linux-tdep.c (-linux_spu_make_corefile_notes): Remove.
1295         (linux_make_corefile_notes): No longer call it.
1296
1297         * regcache.c (cooked_read_test): Remove bfd_arch_spu special case.
1298         (cooked_write_test): Likewise.
1299
1300 2019-09-20  Tom Tromey  <tom@tromey.com>
1301
1302         * NEWS: Mention case-sensitivity of TUI commands.
1303         * tui/tui-win.c (tui_set_focus_command): Now case-sensitive.
1304         (tui_set_win_height_command, parse_scrolling_args): Likewise.
1305         * tui/tui-layout.c (tui_layout_command): Now case-sensitive.
1306
1307 2019-09-20  Tom Tromey  <tom@tromey.com>
1308
1309         * tui/tui-source.c (tui_source_window::set_contents): Use
1310         make_unique_xstrdup.
1311         * tui/tui-disasm.c (tui_disasm_window::set_contents): Use
1312         make_unique_xstrdup.
1313
1314 2019-09-20  Tom Tromey  <tom@tromey.com>
1315
1316         * tui/tui-data.c: Remove separator comments.
1317         * tui/tui-layout.c: Remove separator comments.
1318         * tui/tui-win.c: Remove separator comments.
1319         * tui/tui-wingeneral.c: Remove separator comments.
1320
1321 2019-09-20  Tom Tromey  <tom@tromey.com>
1322
1323         * tui/tui.h (strcat_to_buf): Don't declare.
1324         * tui/tui.c (strcat_to_buf): Remove.
1325
1326 2019-09-20  Tom Tromey  <tom@tromey.com>
1327
1328         * tui/tui-source.h (struct tui_source_window) <m_fullname>: Rename
1329         from "fullname".
1330         * tui/tui-source.c (tui_source_window::set_contents)
1331         (tui_source_window::location_matches_p)
1332         (tui_source_window::maybe_update): Update.
1333
1334 2019-09-20  Tom Tromey  <tom@tromey.com>
1335
1336         * tui/tui-regs.h (struct tui_data_window) <get_current_group>:
1337         Update.
1338         <m_regs_content, m_regs_column_count, m_current_group>: Add "m_"
1339         prefix.
1340         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
1341         (tui_data_window::line_from_reg_element_no)
1342         (tui_data_window::first_reg_element_no_inline)
1343         (tui_data_window::show_registers)
1344         (tui_data_window::show_register_group)
1345         (tui_data_window::display_registers_from)
1346         (tui_data_window::display_registers_from_line)
1347         (tui_data_window::first_data_item_displayed)
1348         (tui_data_window::delete_data_content_windows)
1349         (tui_data_window::erase_data_content)
1350         (tui_data_window::do_scroll_vertical)
1351         (tui_data_window::refresh_window)
1352         (tui_data_window::check_register_values): Update.
1353
1354 2019-09-20  Tom Tromey  <tom@tromey.com>
1355
1356         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN): Remove define.
1357         (struct tui_locator_window) <full_name, proc_name>: Now
1358         std::string.
1359         * tui/tui-stack.c (tui_locator_window::make_status_line)
1360         (tui_locator_window::set_locator_fullname)
1361         (tui_locator_window::set_locator_info): Update.
1362         * tui/tui-source.c (tui_source_window::set_contents)
1363         (tui_source_window::showing_source_p): Update.
1364
1365 2019-09-20  Tom Tromey  <tom@tromey.com>
1366
1367         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
1368         Don't call tui_locator_win_info_ptr.
1369
1370 2019-09-20  Tom Tromey  <tom@tromey.com>
1371
1372         * tui/tui-win.c (tui_resize_all): Don't call refresh.
1373
1374 2019-09-20  Tom Tromey  <tom@tromey.com>
1375
1376         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use 1 as
1377         height for locator.
1378         * tui/tui-stack.c (tui_locator_window::rerender): Call scrollok.
1379         * tui/tui-layout.c (show_source_disasm_command, show_data)
1380         (show_source_or_disasm_and_command): Use 1 as height for locator.
1381
1382 2019-09-20  Tom Tromey  <tom@tromey.com>
1383
1384         * tui/tui.c (tui_enable): Update.
1385         * tui/tui-win.c (tui_sigwinch_handler, tui_async_resize_screen):
1386         Update.
1387         * tui/tui-data.h (tui_win_resized, tui_set_win_resized_to):
1388         Update.
1389         * tui/tui-data.c (win_resized): Now bool.
1390         (tui_win_resized): Return bool.
1391         (tui_set_win_resized_to): Accept a bool.
1392
1393 2019-09-20  Tom Tromey  <tom@tromey.com>
1394
1395         * tui/tui-regs.h (struct tui_data_window) <show_register_group>:
1396         Change type of "refresh_values_only".
1397         * tui/tui-regs.c (tui_data_window::show_register_group): Change
1398         type of "refresh_values_only".
1399
1400 2019-09-20  Tom Tromey  <tom@tromey.com>
1401
1402         * tui/tui-disasm.c (struct tui_asm_line) <addr_string, insn>: Now
1403         std::string.
1404         (tui_disassemble): Add "pos" parameter.
1405         (tui_disasm_window::set_contents): Simplify.
1406
1407 2019-09-20  Tom Tromey  <tom@tromey.com>
1408
1409         * tui/tui-winsource.h (struct tui_source_window_base)
1410         <show_source_content>: Now private.
1411         * tui/tui-winsource.c
1412         (tui_source_window_base::show_source_content): Don't handle empty
1413         content case.
1414
1415 2019-09-20  Tom Tromey  <tom@tromey.com>
1416
1417         * tui/tui-layout.c (show_source_disasm_command)
1418         (show_source_or_disasm_and_command): Don't call
1419         show_source_content.
1420
1421 2019-09-20  Tom Tromey  <tom@tromey.com>
1422
1423         * tui/tui-stack.h (struct tui_locator_window) <make_status_line>:
1424         Declare.
1425         * tui/tui-stack.c (tui_locator_window::make_status_line): Rename
1426         from tui_make_status_line.
1427         (tui_locator_window::rerender): Update.
1428
1429 2019-09-20  Tom Tromey  <tom@tromey.com>
1430
1431         * tui/tui-stack.c (tui_make_status_line): Return std::string.
1432         (tui_locator_window::rerender): Update.
1433
1434 2019-09-20  Tom Tromey  <tom@tromey.com>
1435
1436         * tui/tui-winsource.h (struct tui_source_window_base)
1437         <~tui_source_window_base>: Don't declare.
1438         <fullname>: Remove.
1439         * tui/tui-winsource.c (~tui_source_window_base): Remove.
1440         * tui/tui-source.h (struct tui_source_window) <fullname>: New
1441         member.
1442         * tui/tui-source.c (tui_source_window::set_contents): Update.
1443         (tui_source_window::location_matches_p)
1444         (tui_source_window::maybe_update): Update.
1445
1446 2019-09-20  Tom Tromey  <tom@tromey.com>
1447
1448         * tui/tui-winsource.h (~tui_source_element): Remove.
1449         (tui_source_element): Update.
1450         (struct tui_source_element) <line>: Now a unique_xmalloc_ptr.
1451         * tui/tui-winsource.c (tui_show_source_line): Update.
1452         * tui/tui-source.c (tui_source_window::set_contents): Update.
1453         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
1454
1455 2019-09-20  Tom Tromey  <tom@tromey.com>
1456
1457         * tui/tui-data.h (tui_clear_source_windows_detail): Don't
1458         declare.
1459         * tui/tui-layout.c (tui_add_win_to_layout): Don't call
1460         tui_clear_source_windows_detail.
1461         * tui/tui-winsource.h (struct tui_source_window_base)
1462         <clear_detail>: Don't declare.
1463         * tui/tui-winsource.c (tui_source_window_base::clear_detail):
1464         Remove.
1465         * tui/tui-data.c (tui_clear_source_windows_detail): Remove.
1466
1467 2019-09-20  Tom Tromey  <tromey@adacore.com>
1468
1469         PR ada/24919:
1470         * block.c (contained_in): Fix final return value.
1471
1472 2019-09-20  Alan Modra  <amodra@gmail.com>
1473
1474         * gdb_bfd.c (gdb_bfd_ref, gdb_bfd_unref): Use bfd_set_usrdata.
1475         * dwarf2read.c (dwarf2_read_gdb_index, dwarf2_read_debug_names),
1476         (read_indirect_string_from_dwz): Use bfd accessor.
1477         * dwarf2read.h (struct dwz_file <filename>): Likewise.
1478         * machoread.c (macho_symfile_read_all_oso): Likewise.
1479         * solib.c (solib_bfd_open): Likewise.
1480
1481 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
1482
1483         * eval.c: Move declaration of overload_resolution to...
1484         * value.h: ...here.
1485
1486 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
1487
1488         * arm-linux-nat.c: Remove extern declaration for arm_apcs_32.
1489         * arm-linux-tdep.c: Likewise.
1490         * arm-nbsd-nat.c: Likewise.
1491         * arm-tdep.h: Declare arm_apcs_32.
1492         * arm-tdep.c: Move documentation for arm_apcs_32 to arm-tdep.h.
1493
1494 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
1495
1496         * dwarf2loc.c: Remove extern declaration of dwarf_always_disassemble.
1497         * dwarf2read.h: Declare dwarf_always_disassemble.
1498
1499 2019-09-19  Tom de Vries  <tdevries@suse.de>
1500
1501         PR gdb/25009
1502         * source-cache.c (source_cache::ensure): Catch exception thrown during
1503         construction of the highlighter.
1504
1505 2019-09-18  Alan Modra  <amodra@gmail.com>
1506
1507         * aarch64-linux-tdep.c, * arm-tdep.c, * auto-load.c,
1508         * coff-pe-read.c, * coffread.c, * corelow.c, * dbxread.c,
1509         * dicos-tdep.c, * dwarf2-frame.c, * dwarf2read.c, * elfread.c,
1510         * exec.c, * fbsd-tdep.c, * gcore.c, * gdb_bfd.c, * gdb_bfd.h,
1511         * hppa-tdep.c, * i386-cygwin-tdep.c, * i386-fbsd-tdep.c,
1512         * i386-linux-tdep.c, * jit.c, * linux-tdep.c, * machoread.c,
1513         * maint.c, * mdebugread.c, * minidebug.c, * mips-linux-tdep.c,
1514         * mips-sde-tdep.c, * mips-tdep.c, * mipsread.c, * nto-tdep.c,
1515         * objfiles.c, * objfiles.h, * osabi.c, * ppc-linux-tdep.c,
1516         * ppc64-tdep.c, * record-btrace.c, * record-full.c, * remote.c,
1517         * rs6000-aix-tdep.c, * rs6000-tdep.c, * s390-linux-tdep.c,
1518         * s390-tdep.c, * solib-aix.c, * solib-dsbt.c, * solib-frv.c,
1519         * solib-spu.c, * solib-svr4.c, * solib-target.c,
1520         * spu-linux-nat.c, * spu-tdep.c, * symfile-mem.c, * symfile.c,
1521         * symmisc.c, * symtab.c, * target.c, * windows-nat.c,
1522         * xcoffread.c, * cli/cli-dump.c, * compile/compile-object-load.c,
1523         * mi/mi-interp.c: Update throughout for bfd section macro and
1524         function changes.
1525         * gcore (gcore_create_callback): Use bfd_set_section_lma.
1526         * spu-tdep.c (spu_overlay_new_objfile): Likewise.
1527
1528 2019-09-18  Tom Tromey  <tom@tromey.com>
1529
1530         * NEWS: Add entry.
1531         * tui/tui.c (tui_initialize_readline): Set name of keymap.  Do not
1532         call rl_initialize.
1533         (tui_enable): Do not call rl_initialize.
1534
1535 2019-09-18  Christian Groessler  <chris@groessler.org>
1536
1537         * alpha-linux-nat.c: Include gdbarch.h.
1538
1539 2019-09-18  Simon Marchi  <simon.marchi@polymtl.ca>
1540
1541         * ui-file.c: Include cli/cli-style.h.
1542         (term_cli_styling): Remove cli_styling declaration.
1543
1544 2019-09-18  Alan Modra  <amodra@gmail.com>
1545
1546         * arm-tdep.c (arm_record_special_symbol): Update bfd_get_section
1547         to bfd_asymbol_section.
1548
1549 2019-09-18  Alan Modra  <amodra@gmail.com>
1550
1551         * amd64-dicos-tdep.c (amd64_dicos_osabi_sniffer): Constify target.
1552         * i386-cygwin-tdep.c (i386_cygwin_init_abi): Likewise.
1553         * i386-dicos-tdep.c (i386_dicos_osabi_sniffer): Likewise.
1554
1555 2019-09-18  Alan Modra  <amodra@gmail.com>
1556
1557         * solib-spu.c (spu_bfd_open): Use bfd_set_filename.
1558         * spu-linux-nat.c (spu_bfd_open): Likewise.
1559
1560 2019-09-18  Christian Biesinger  <cbiesinger@google.com>
1561
1562         * dwarf2loc.c: Change extern declaration of dwarf_always_disassemble
1563         to bool to match definition in dwarf2read.c.
1564
1565 2019-09-17  Christian Biesinger  <cbiesinger@google.com>
1566
1567         * ada-lang.c (ada_ignore_descriptive_types_p): Change to bool.
1568         (print_signatures): Likewise.
1569         (trust_pad_over_xvs): Likewise.
1570         * arch/aarch64-insn.c (aarch64_debug): Likewise.
1571         * arch/aarch64-insn.h (aarch64_debug): Likewise.
1572         * arm-linux-nat.c (arm_apcs_32): Likewise.
1573         * arm-linux-tdep.c (arm_apcs_32): Likewise.
1574         * arm-nbsd-nat.c (arm_apcs_32): Likewise.
1575         * arm-tdep.c (arm_debug): Likewise.
1576         (arm_apcs_32): Likewise.
1577         * auto-load.c (debug_auto_load): Likewise.
1578         (auto_load_gdb_scripts): Likewise.
1579         (global_auto_load): Likewise.
1580         (auto_load_local_gdbinit): Likewise.
1581         (auto_load_local_gdbinit_loaded): Likewise.
1582         * auto-load.h (global_auto_load): Likewise.
1583         (auto_load_local_gdbinit): Likewise.
1584         (auto_load_local_gdbinit_loaded): Likewise.
1585         * breakpoint.c (disconnected_dprintf): Likewise.
1586         (breakpoint_proceeded): Likewise.
1587         (automatic_hardware_breakpoints): Likewise.
1588         (always_inserted_mode): Likewise.
1589         (target_exact_watchpoints): Likewise.
1590         (_initialize_breakpoint): Update.
1591         * breakpoint.h (target_exact_watchpoints): Change to bool.
1592         * btrace.c (maint_btrace_pt_skip_pad): Likewise.
1593         * cli/cli-cmds.c (trace_commands): Likewise.
1594         * cli/cli-cmds.h (trace_commands): Likewise.
1595         * cli/cli-decode.c (add_setshow_boolean_cmd): Change int* argument
1596         to bool*.
1597         * cli/cli-logging.c (logging_overwrite): Change to bool.
1598         (logging_redirect): Likewise.
1599         (debug_redirect): Likewise.
1600         * cli/cli-option.h (option_def) <boolean>: Change return type to bool*.
1601         (struct boolean_option_def) <get_var_address_cb_>: Change return type
1602         to bool.
1603         <boolean_option_def>: Update.
1604         (struct flag_option_def): Change default type of Context to bool
1605         from int.
1606         <flag_option_def>: Change return type of var_address_cb_ to bool*.
1607         * cli/cli-setshow.c (do_set_command): Cast to bool* instead of int*.
1608         (get_setshow_command_value_string): Likewise.
1609         * cli/cli-style.c (cli_styling): Change to bool.
1610         (source_styling): Likewise.
1611         * cli/cli-style.h (source_styling): Likewise.
1612         (cli_styling): Likewise.
1613         * cli/cli-utils.h (struct qcs_flags) <quiet, cont, silent>: Change
1614         to bool.
1615         * command.h (var_types): Update comment.
1616         (add_setshow_boolean_cmd): Change int* var argument to bool*.
1617         * compile/compile-cplus-types.c (debug_compile_cplus_types): Change to
1618         bool.
1619         (debug_compile_cplus_scopes): Likewise.
1620         * compile/compile-internal.h (compile_debug): Likewise.
1621         * compile/compile.c (compile_debug): Likewise.
1622         (struct compile_options) <raw>: Likewise.
1623         * cp-support.c (catch_demangler_crashes): Likewise.
1624         * cris-tdep.c (usr_cmd_cris_version_valid): Likewise.
1625         (usr_cmd_cris_dwarf2_cfi): Likewise.
1626         * csky-tdep.c (csky_debug): Likewise.
1627         * darwin-nat.c (enable_mach_exceptions): Likewise.
1628         * dcache.c (dcache_enabled_p): Likewise.
1629         * defs.h (info_verbose): Likewise.
1630         * demangle.c (demangle): Likewise.
1631         (asm_demangle): Likewise.
1632         * dwarf-index-cache.c (debug_index_cache): Likewise.
1633         * dwarf2-frame.c (dwarf2_frame_unwinders_enabled_p): Likewise.
1634         * dwarf2-frame.h (dwarf2_frame_unwinders_enabled_p): Likewise.
1635         * dwarf2read.c (check_physname): Likewise.
1636         (use_deprecated_index_sections): Likewise.
1637         (dwarf_always_disassemble): Likewise.
1638         * eval.c (overload_resolution): Likewise.
1639         * event-top.c (set_editing_cmd_var): Likewise.
1640         (exec_done_display_p): Likewise.
1641         * event-top.h (set_editing_cmd_var): Likewise.
1642         (exec_done_display_p): Likewise.
1643         * exec.c (write_files): Likewise.
1644         * fbsd-nat.c (debug_fbsd_lwp): Likewise
1645         (debug_fbsd_nat): Likewise.
1646         * frame.h (struct frame_print_options) <print_raw_frame_arguments>:
1647         Likewise.
1648         (struct set_backtrace_options) <backtrace_past_main>: Likewise.
1649         <backtrace_past_entry> Likewise.
1650         * gdb-demangle.h (demangle): Likewise.
1651         (asm_demangle): Likewise.
1652         * gdb_bfd.c (bfd_sharing): Likewise.
1653         * gdbcore.h (write_files): Likewise.
1654         * gdbsupport/common-debug.c (show_debug_regs): Likewise.
1655         * gdbsupport/common-debug.h (show_debug_regs): Likewise.
1656         * gdbthread.h (print_thread_events): Likewise.
1657         * gdbtypes.c (opaque_type_resolution): Likewise.
1658         (strict_type_checking): Likewise.
1659         * gnu-nat.c (gnu_debug_flag): Likewise.
1660         * guile/scm-auto-load.c (auto_load_guile_scripts): Likewise.
1661         * guile/scm-param.c (pascm_variable): Add boolval.
1662         (add_setshow_generic): Update.
1663         (pascm_param_value): Update.
1664         (pascm_set_param_value_x): Update.
1665         * hppa-tdep.c (hppa_debug): Change to bool..
1666         * infcall.c (may_call_functions_p): Likewise.
1667         (coerce_float_to_double_p): Likewise.
1668         (unwind_on_signal_p): Likewise.
1669         (unwind_on_terminating_exception_p): Likewise.
1670         * infcmd.c (startup_with_shell): Likewise.
1671         * inferior.c (print_inferior_events): Likewise.
1672         * inferior.h (startup_with_shell): Likewise.
1673         (print_inferior_events): Likewise.
1674         * infrun.c (step_stop_if_no_debug): Likewise.
1675         (detach_fork): Likewise.
1676         (debug_displaced): Likewise.
1677         (disable_randomization): Likewise.
1678         (non_stop): Likewise.
1679         (non_stop_1): Likewise.
1680         (observer_mode): Likewise.
1681         (observer_mode_1): Likewise.
1682         (set_observer_mode): Update.
1683         (sched_multi): Change to bool.
1684         * infrun.h (debug_displaced): Likewise.
1685         (sched_multi): Likewise.
1686         (step_stop_if_no_debug): Likewise.
1687         (non_stop): Likewise.
1688         (disable_randomization): Likewise.
1689         * linux-tdep.c (use_coredump_filter): Likewise.
1690         (dump_excluded_mappings): Likewise.
1691         * linux-thread-db.c (auto_load_thread_db): Likewise.
1692         (check_thread_db_on_load): Likewise.
1693         * main.c (captured_main_1): Update.
1694         * maint-test-options.c (struct test_options_opts) <flag_opt, xx1_opt,
1695         xx2_opt, boolean_opt>: Change to bool.
1696         * maint-test-settings.c (maintenance_test_settings_boolean): Likewise.
1697         * maint.c (maintenance_profile_p): Likewise.
1698         (per_command_time): Likewise.
1699         (per_command_space): Likewise.
1700         (per_command_symtab): Likewise.
1701         * memattr.c (inaccessible_by_default): Likewise.
1702         * mi/mi-main.c (mi_async): Likewise.
1703         (mi_async_1): Likewise.
1704         * mips-tdep.c (mips64_transfers_32bit_regs_p): Likewise.
1705         * nat/fork-inferior.h (startup_with_shell): Likewise.
1706         * nat/linux-namespaces.c (debug_linux_namespaces): Likewise.
1707         * nat/linux-namespaces.h (debug_linux_namespaces): Likewise.
1708         * nios2-tdep.c (nios2_debug): Likewise.
1709         * or1k-tdep.c (or1k_debug): Likewise.
1710         * parse.c (parser_debug): Likewise.
1711         * parser-defs.h (parser_debug): Likewise.
1712         * printcmd.c (print_symbol_filename): Likewise.
1713         * proc-api.c (procfs_trace): Likewise.
1714         * python/py-auto-load.c (auto_load_python_scripts): Likewise.
1715         * python/py-param.c (union parmpy_variable): Add "bool boolval" field.
1716         (set_parameter_value): Update.
1717         (add_setshow_generic): Update.
1718         * python/py-value.c (copy_py_bool_obj): Change argument from int*
1719         to bool*.
1720         * python/python.c (gdbpy_parameter_value): Cast to bool* instead of
1721         int*.
1722         * ravenscar-thread.c (ravenscar_task_support): Change to bool.
1723         * record-btrace.c (record_btrace_target::store_registers): Update.
1724         * record-full.c (record_full_memory_query): Change to bool.
1725         (record_full_stop_at_limit): Likewise.
1726         * record-full.h (record_full_memory_query): Likewise.
1727         * remote-notif.c (notif_debug): Likewise.
1728         * remote-notif.h (notif_debug): Likewise.
1729         * remote.c (use_range_stepping): Likewise.
1730         (interrupt_on_connect): Likewise.
1731         (remote_break): Likewise.
1732         * ser-tcp.c (tcp_auto_retry): Likewise.
1733         * ser-unix.c (serial_hwflow): Likewise.
1734         * skip.c (debug_skip): Likewise.
1735         * solib-aix.c (solib_aix_debug): Likewise.
1736         * spu-tdep.c (spu_stop_on_load_p): Likewise.
1737         (spu_auto_flush_cache_p): Likewise.
1738         * stack.c (struct backtrace_cmd_options) <full, no_filters, hide>:
1739         Likewise.
1740         (struct info_print_options) <quiet>: Likewise.
1741         * symfile-debug.c (debug_symfile): Likewise.
1742         * symfile.c (auto_solib_add): Likewise.
1743         (separate_debug_file_debug): Likewise.
1744         * symfile.h (auto_solib_add): Likewise.
1745         (separate_debug_file_debug): Likewise.
1746         * symtab.c (basenames_may_differ): Likewise.
1747         (struct filename_partial_match_opts) <dirname, basename>: Likewise.
1748         (struct info_print_options) <quiet, exclude_minsyms>: Likewise.
1749         (struct info_types_options) <quiet>: Likewise.
1750         * symtab.h (demangle): Likewise.
1751         (basenames_may_differ): Likewise.
1752         * target-dcache.c (stack_cache_enabled_1): Likewise.
1753         (code_cache_enabled_1): Likewise.
1754         * target.c (trust_readonly): Likewise.
1755         (may_write_registers): Likewise.
1756         (may_write_memory): Likewise.
1757         (may_insert_breakpoints): Likewise.
1758         (may_insert_tracepoints): Likewise.
1759         (may_insert_fast_tracepoints): Likewise.
1760         (may_stop): Likewise.
1761         (auto_connect_native_target): Likewise.
1762         (target_stop_and_wait): Update.
1763         (target_async_permitted): Change to bool.
1764         (target_async_permitted_1): Likewise.
1765         (may_write_registers_1): Likewise.
1766         (may_write_memory_1): Likewise.
1767         (may_insert_breakpoints_1): Likewise.
1768         (may_insert_tracepoints_1): Likewise.
1769         (may_insert_fast_tracepoints_1): Likewise.
1770         (may_stop_1): Likewise.
1771         * target.h (target_async_permitted): Likewise.
1772         (may_write_registers): Likewise.
1773         (may_write_memory): Likewise.
1774         (may_insert_breakpoints): Likewise.
1775         (may_insert_tracepoints): Likewise.
1776         (may_insert_fast_tracepoints): Likewise.
1777         (may_stop): Likewise.
1778         * thread.c (struct info_threads_opts) <show_global_ids>: Likewise.
1779         (make_thread_apply_all_options_def_group): Change argument from int*
1780         to bool*.
1781         (thread_apply_all_command): Update.
1782         (print_thread_events): Change to bool.
1783         * top.c (confirm): Likewise.
1784         (command_editing_p): Likewise.
1785         (history_expansion_p): Likewise.
1786         (write_history_p): Likewise.
1787         (info_verbose): Likewise.
1788         * top.h (confirm): Likewise.
1789         (history_expansion_p): Likewise.
1790         * tracepoint.c (disconnected_tracing): Likewise.
1791         (circular_trace_buffer): Likewise.
1792         * typeprint.c (print_methods): Likewise.
1793         (print_typedefs): Likewise.
1794         * utils.c (debug_timestamp): Likewise.
1795         (sevenbit_strings): Likewise.
1796         (pagination_enabled): Likewise.
1797         * utils.h (sevenbit_strings): Likewise.
1798         (pagination_enabled): Likewise.
1799         * valops.c (overload_resolution): Likewise.
1800         * valprint.h (struct value_print_options) <prettyformat_arrays,
1801         prettyformat_structs, vtblprint, unionprint, addressprint, objectprint,
1802         stop_print_at_null, print_array_indexes, deref_ref, static_field_print,
1803         pascal_static_field_print, raw, summary, symbol_print, finish_print>:
1804         Likewise.
1805         * windows-nat.c (new_console): Likewise.
1806         (cygwin_exceptions): Likewise.
1807         (new_group): Likewise.
1808         (debug_exec): Likewise.
1809         (debug_events): Likewise.
1810         (debug_memory): Likewise.
1811         (debug_exceptions): Likewise.
1812         (useshell): Likewise.
1813         * windows-tdep.c (maint_display_all_tib): Likewise.
1814         * xml-support.c (debug_xml): Likewise.
1815
1816 2019-09-17  Mike Gulick  <mgulick@mathworks.com>
1817
1818         * source.c (prepare_path_for_appending): New function.
1819         (openp): Make use of new function.
1820         (find_and_open_source): Search for the compilation directory and
1821         source file as a relative path beneath the directory search path.
1822
1823 2019-09-17  Andrew Burgess  <andrew.burgess@embecosm.com>
1824
1825         * source-cache.c (source_cache::get_line_charpos): Catch
1826         exceptions and return false, this matches the behaviour documented
1827         in the header file.
1828
1829 2019-09-17  Joel Brobecker  <brobecker@adacore.com>
1830
1831         * ada-tasks.c (info_task): Remove quoting of the task's name.
1832
1833 2019-09-16  Christian Biesinger  <cbiesinger@google.com>
1834
1835         * symfile.c (auto_solib_add): Replace comment with a reference
1836         to the header file.
1837
1838 2019-09-14  Christian Biesinger  <cbiesinger@google.com>
1839
1840         * NEWS: Mention that gdb can now be compiled with Python 3
1841         on Windows.
1842
1843 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1844
1845         * maint.c (maint_print_section_data::maint_print_section_data):
1846         Force use of 'float log10 (float)' by casting the argument to
1847         float.
1848
1849 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1850
1851         * maint.c: Add 'cmath' include.
1852         (struct maint_print_section_data): New structure.
1853         (print_section_index): New function.
1854         (print_bfd_section_info): Add header comment, small whitespace
1855         cleanup, and update to call new print_section_index function.
1856         (print_objfile_section_info): Likewise.
1857         (maint_obj_section_from_bfd_section): New function.
1858         (print_bfd_section_info_maybe_relocated): New function.
1859         (maintenance_info_sections): Add header comment, always use
1860         bfd_map_over_sections instead of ALL_OBJFILE_OSECTIONS.
1861
1862 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1863
1864         * psymtab.c (find_pc_sect_psymtab): Move baseaddr local into more
1865         inner scope, add check that the objfile has psymtabs before
1866         checking psymtabs_addrmap.
1867         * psymtab.h (psymtab_storage) <psymtabs_addrmap>: Extend comment.
1868
1869 2019-09-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1870
1871         * NEWS: Announce that Ada task names are now shown at more places,
1872         and between quotes (except in info task output).
1873         * gdb/ada-tasks.c (task_to_str): New function.
1874         (display_current_task_id): Call task_to_str.
1875         (task_command_1): Likewise.
1876         (print_ada_task_info): In non-mi mode, Properly align headers and data
1877         when task-id length is > 9 (9 is the default for a 32 bits CORE_ADDR).
1878
1879 2019-09-12  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
1880
1881         * procfs.c (procfs_target::wait) <PR_FAULTED>: Get signal from
1882         prstatus.pr_lwp.pr_info instead of making it up.
1883
1884 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
1885
1886         * auto-load.c (auto_load_expand_dir_vars): Update.
1887         * defs.h (gdb_datadir): Change to std::string.
1888         (python_libdir): Likewise.
1889         (relocate_gdb_directory): Change return type to std::string.
1890         * guile/guile.c (gdbscm_data_directory): Update.
1891         (initialize_scheme_side): Update.
1892         * jit.c (jit_reader_dir): Change to std::string.
1893         (jit_reader_load_command): Update.
1894         * main.c (gdb_datadir): Change to std::string.
1895         (python_libdir): Likewise.
1896         (set_gdb_data_directory): Update.
1897         (relocate_path): Change to return std::string.
1898         (relocate_gdb_directory): Change to return std::string.
1899         (relocate_gdbinit_path_maybe_in_datadir): Update.
1900         (captured_main_1): Update.
1901         * python/python.c (do_start_initialization): Update.
1902         * top.c (show_gdb_datadir): Update.
1903         * xml-syscall.c (xml_init_syscalls_info): Update.
1904         (init_syscalls_info): Update.
1905
1906 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
1907
1908         * main.c (relocate_gdbinit_path_maybe_in_datadir): Factor this code
1909         out of get_init_files.
1910         (get_init_files): Update.
1911
1912 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
1913
1914         * main.c (get_init_files): Change to use std::string.
1915         (captured_main_1): Update.
1916         (print_gdb_help): Update.
1917
1918 2019-09-11  Ali Tamur  <tamur@google.com>
1919
1920         *gdb/target-float.c (host_float_ops<T>::to_longest): Update
1921         implementation.
1922
1923 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
1924
1925         * dbxread.c (read_dbx_symtab): Update.
1926         * dwarf2read.c (load_partial_dies): Update.
1927         * mdebugread.c (parse_partial_symbols): Update.
1928         (handle_psymbol_enumerators): Update.
1929         * psympriv.h (add_psymbol_to_list): Change type of copy_names to bool.
1930         * psymtab.c (add_psymbol_to_bcache): Likewise.
1931         (add_psymbol_to_list): Likewise.
1932         * symtab.c (symbol_set_names): Likewise.
1933         * symtab.h (symbol_set_names): Likewise.
1934         * xcoffread.c (scan_xcoff_symtab): Update.
1935
1936 2019-09-11  Tom Tromey  <tom@tromey.com>
1937
1938         * symfile-mem.c (symbol_file_add_from_memory): Use
1939         bfd_set_filename.
1940         * solib-darwin.c (darwin_bfd_open): Use bfd_set_filename.
1941         * solib-aix.c (solib_aix_bfd_open): Use bfd_set_filename.
1942
1943 2019-09-10  Tom Tromey  <tromey@adacore.com>
1944
1945         * dwarf-index-write.c (write_psymbols): Extend error message.
1946         (debug_names::insert): Add Ada code.
1947         (debug_names::write_psymbols): Remove Ada check.
1948         (debug_names) <m_string_obstack>: New member.
1949         * dwarf2read.c (gdb_index_symbol_name_matcher): Remove.
1950         (gdb_index_symbol_name_matcher::matches): Remove.
1951         (mapped_index_base::find_name_components_bounds): Add "lang"
1952         parameter.
1953         (mapped_index_base::build_name_components): Also split names
1954         according to Ada syntax.
1955         (dw2_expand_symtabs_matching_symbol): Loop over languages.  Change
1956         type of "match_callback".
1957         (check_match, check_find_bounds_finds)
1958         (dw2_expand_symtabs_matching): Update.
1959         (dw2_debug_names_iterator): Add new constructor.
1960         (dw2_debug_names_map_matching_symbols): New function.
1961         (dw2_debug_names_expand_symtabs_matching): Update.
1962         (dwarf2_debug_names_functions): Use
1963         dw2_debug_names_map_matching_symbols.
1964
1965 2019-09-10  Tom Tromey  <tromey@adacore.com>
1966
1967         * dwarf2read.c (dw2_get_file_names_reader): Add the
1968         CU's file name to the results.
1969
1970 2019-09-10  Tom Tromey  <tromey@adacore.com>
1971
1972         * ada-lang.c (add_nonlocal_symbols): Combine calls to
1973         map_matching_symbols.  Update.
1974         * dwarf2read.c (dw2_map_matching_symbols): Update.
1975         * psymtab.c (match_partial_symbol): Change type; update.
1976         (psym_map_matching_symbols): Likewise.
1977         * symfile-debug.c (debug_qf_map_matching_symbols): Change
1978         type; update.
1979         * symfile.h (struct quick_symbol_functions)
1980         <map_matching_symbols>: Change "name" to be a lookup_name_info.
1981         Remove "match".
1982
1983 2019-09-10  Tom Tromey  <tromey@adacore.com>
1984
1985         * psymtab.c (map_block): Remove.
1986         (psym_map_matching_symbols): Use iterate_over_symbols_terminated.
1987         * symtab.c (iterate_over_symbols_terminated): New function.
1988         * symtab.c (iterate_over_symbols_terminated): Declare.
1989
1990 2019-09-10  Tom Tromey  <tromey@adacore.com>
1991
1992         * ada-lang.c (ada_iterate_over_symbols): Return bool.
1993         * language.h (struct language_defn) <la_iterate_over_symbols>:
1994         Return bool.
1995         * symtab.c (iterate_over_symbols): Return bool.
1996         * symtab.h (iterate_over_symbols): Return bool.
1997
1998 2019-09-10  Tom Tromey  <tromey@adacore.com>
1999
2000         * ada-lang.c (aux_add_nonlocal_symbols): Change type.
2001         (add_nonlocal_symbols): Update.
2002         * dwarf2read.c (dw2_map_matching_symbols): Change type.
2003         * psymtab.c (map_block, psym_map_matching_symbols): Change type.
2004         * symfile-debug.c (debug_qf_map_matching_symbols): Change type.
2005         * symfile.h (struct quick_symbol_functions) <map_matching_symbols>:
2006         Change type of "callback".  Remove "data".
2007
2008
2009 2019-09-09  Ali Tamur  <tamur@google.com>
2010
2011         * dwarf2read.c (comp_unit_head): Update comment.
2012         (dwarf2_dwo_name): New function declaration.
2013         (dwarf_unit_type_name): New function declaration.
2014         (read_comp_unit_head): Add support for new compilation units,
2015         DW_UT_partial, DW_UT_skeleton, DW_UT_split_compile, DW_UT_split_type.
2016         Particularly, DW_UT_skeleton and DW_UT_split_compile have dwo_id
2017         (currently named as "signature") in their header. Also clarify error
2018         messages.
2019         (lookup_dwo_id): New function. Returns the dwo id of the given
2020         compile unit.
2021         (lookup_dwo_unit): Use the new lookup_dwo_id function.
2022         (init_cutu_and_read_dies): Use the new dwarf2_dwo_name and lookup_dwo_id
2023         functions.
2024         (create_dwo_cu_reader): Use the added lookup_dwo_id function.
2025         (dwarf2_dwo_name): Get the dwo name if present.
2026         (dwarf_unit_type_name): Convert DW_UT_* types to string for diagnostic
2027         purposes.
2028
2029 2019-09-09  Tom Tromey  <tom@tromey.com>
2030
2031         * tui/tui-win.c (tui_all_windows_info): Use ui_out.
2032
2033 2019-09-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2034
2035         * python/python.c (do_start_initialization): Make progname_copy static,
2036         to avoid a leak report.
2037
2038 2019-09-08  Tom Tromey  <tom@tromey.com>
2039
2040         * tui/tui-wingeneral.c (box_win): Truncate long window titles.
2041
2042 2019-09-07  Simon Marchi  <simon.marchi@efficios.com>
2043
2044         * dwarf2read.c (struct dw2_symtab_iterator) <block_index>:
2045         Change type to gdb::optional<block_enum>.
2046         (dw2_symtab_iter_init): Change block_index parameter type
2047         to gdb::optional<block_enum>.
2048         (dw2_lookup_symbol): Change block_index parameter
2049         type to block_enum.c
2050         (dw2_debug_names_lookup_symbol): Likewise.
2051         * psymtab.c (psym_lookup_symbol): Likewise.
2052         * symfile-debug.c (debug_qf_lookup_symbol): Likewise.
2053         * symfile.h (struct quick_symbol_functions) <lookup_symbol>:
2054         Likewise.
2055
2056 2019-09-06  Christian Biesinger  <cbiesinger@google.com>
2057
2058         * defs.h (relocate_gdb_directory): Change int to bool in
2059         signature and rename flag to relocatable.
2060         * main.c (relocate_path): Likewise.
2061         (relocate_gdb_directory): Likewise.
2062
2063 2019-09-06  Alan Modra  <amodra@gmail.com>
2064
2065         * coffread.c (coff_symfile_read): Constify filename variable.
2066         * dbxread.c (dbx_symfile_init, coffstab_build_psymtabs),
2067         (elfstab_build_psymtabs, stabsect_build_psymtabs): Likewise.
2068         * gdb_bfd.c (gdb_bfd_close_or_warn): Likewise.
2069         * solib.c (reload_shared_libraries_1): Likewise.
2070         * symfile.c (reread_symbols): Likewise.
2071         * solib-aix.c (solib_aix_bfd_open): Add cast for xfree of filename.
2072         * solib-darwin.c (darwin_bfd_open): Likewise.
2073         * symfile-mem.c (symbol_file_add_from_memory): Likewise.
2074
2075 2019-09-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2076
2077         * psymtab.c (print_partial_symbols): Handle missing domain_enum
2078         values MODULE_DOMAIN and COMMON_BLOCK_DOMAIN.
2079
2080 2019-09-03  Tom Tromey  <tromey@adacore.com>
2081
2082         * ada-valprint.c (ada_val_print_num): Don't recurse for range
2083         types.
2084         (has_negatives): Unbias a range type bound.
2085         * dwarf2read.c (read_subrange_type): Handle DW_AT_GNU_bias.
2086         * gdbtypes.c (operator==): Handle new field.
2087         (create_range_type): Add "bias" parameter.
2088         (create_static_range_type, resolve_dynamic_range): Update.
2089         * gdbtypes.h (struct range_bounds) <bias>: New member.
2090         (create_range_type): Add bias parameter.
2091         * printcmd.c (print_scalar_formatted): Unbias range types.
2092         * value.c (unpack_long): Unbias range types.
2093         (pack_long): Bias range types.
2094
2095 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
2096
2097         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Check all
2098         probe arguments.
2099
2100 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
2101
2102         * break-catch-throw.c (fetch_probe_arguments): Use gdbarch.
2103         * dtrace-probe.c (dtrace_probe::get_argument_count): Likewise.
2104         * probe.c (probe_safe_evaluate_at_pc) (compute_probe_arg)
2105         (compile_probe_arg): Likewise.
2106         * probe.h (get_argument_count): Likewise.
2107         * solib-svr4.c (solib_event_probe_action): Likewise.
2108         * stap-probe.c (stap_probe::get_argument_count): Likewise.
2109
2110 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
2111
2112         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Move
2113         code to here...
2114         (svr4_create_solib_event_breakpoints): ...from here.
2115
2116 2019-08-30  Sergio Durigan Junior  <sergiodj@redhat.com>
2117
2118         * nat/fork-inferior.c (trace_start_error): Remove "\nError: "
2119         suffix from warning message.
2120
2121 2019-08-30  Tom Tromey  <tom@tromey.com>
2122
2123         * tui/tui-winsource.h (struct tui_source_window_base)
2124         <refresh_all>: Don't declare.
2125         * tui/tui-winsource.c (tui_source_window_base::refresh_all):
2126         Remove.
2127         * tui/tui-win.c (tui_refresh_all_win): Don't call refresh_all or
2128         tui_show_locator_content.
2129         * tui/tui-regs.h (struct tui_data_window) <refresh_all>: Don't
2130         declare.
2131         * tui/tui-regs.c (tui_data_window::refresh_all): Remove.
2132         * tui/tui-data.h (struct tui_win_info) <refresh_all>: Don't
2133         declare.
2134
2135 2019-08-30  Tom Tromey  <tom@tromey.com>
2136
2137         * tui/tui-io.c (tui_cont_sig): Don't call wrefresh.
2138
2139 2019-08-30  Tom Tromey  <tom@tromey.com>
2140
2141         * tui/tui-stack.c (_initialize_tui_stack): Move later.
2142         Remove unnecessary forward declarations.
2143
2144 2019-08-30  Tom Tromey  <tom@tromey.com>
2145
2146         * tui/tui-stack.c (tui_locator_window::set_locator_fullname): Call
2147         rerender.
2148         (tui_update_locator_fullname, tui_show_frame_info): Don't call
2149         tui_show_locator_content.
2150
2151 2019-08-30  Tom Tromey  <tom@tromey.com>
2152
2153         * tui/tui-stack.c (tui_show_locator_content): Move lower.  Rewrite.
2154         (tui_locator_window::rerender): Rewrite using body of previous
2155         tui_show_locator_content.
2156
2157 2019-08-30  Tom Tromey  <tom@tromey.com>
2158
2159         * tui/tui-stack.h (struct tui_locator_window) <set_locator_info,
2160         set_locator_fullname>: New methods.
2161         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
2162         Rename from tui_set_locator_fullname.
2163         (tui_locator_window::set_locator_info): Rename from
2164         tui_set_locator_info.  Return bool.
2165         (tui_update_locator_fullname, tui_show_frame_info): Update.
2166
2167 2019-08-30  Tom Tromey  <tom@tromey.com>
2168
2169         * tui/tui-layout.c (show_layout): Don't call tui_refresh_all.
2170
2171 2019-08-30  Tom Tromey  <tom@tromey.com>
2172
2173         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Don't
2174         call touchwin.
2175
2176 2019-08-30  Tom Tromey  <tom@tromey.com>
2177
2178         * tui/tui-wingeneral.c (box_win): Assume win_info and
2179         win_info->handle cannot be NULL.
2180
2181 2019-08-30  Tom Tromey  <tom@tromey.com>
2182
2183         * tui/tui-regs.h (struct tui_data_item_window) <rerender,
2184         refresh_window>: Declare.
2185         * tui/tui-regs.c (tui_data_window::display_registers_from): Call
2186         resize.
2187         (tui_data_item_window::rerender): Rename from
2188         tui_display_register.
2189         (tui_data_item_window::refresh_window): New method.
2190         * tui/tui-layout.c (tui_gen_win_info::resize): Do nothing on
2191         no-op.
2192
2193 2019-08-30  Tom Tromey  <tom@tromey.com>
2194
2195         * tui/tui-regs.h (struct tui_data_window) <regs_content,
2196         regs_column_count, current_group>: Move later.  Now private.
2197         <get_current_group>: New method.
2198         * tui/tui-regs.c (tui_reg_command): Update.
2199         * tui/tui-layout.c (tui_set_layout): Update.
2200
2201 2019-08-30  Tom Tromey  <tom@tromey.com>
2202
2203         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
2204         (tui_data_window::rerender): Don't call
2205         check_and_display_highlight_if_needed.
2206         (tui_data_window::refresh_all): Remove call to
2207         erase_data_content.
2208
2209 2019-08-30  Tom Tromey  <tom@tromey.com>
2210
2211         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
2212         (tui_data_window::display_registers_from)
2213         (tui_data_window::display_reg_element_at_line)
2214         (tui_data_window::display_registers_from_line): Remove checks of
2215         "empty".
2216
2217 2019-08-30  Tom Tromey  <tom@tromey.com>
2218
2219         * tui/tui-regs.h (struct tui_data_window) <display_all_data>:
2220         Don't declare.
2221         * tui/tui-regs.c (tui_data_window::show_registers): Call
2222         rerender.
2223         (tui_data_window::rerender): Rename from display_all_data.
2224         (tui_data_window::rerender): Remove old implementation.
2225
2226 2019-08-30  Tom Tromey  <tom@tromey.com>
2227
2228         * tui/tui-regs.c (tui_data_window::display_all_data): Change
2229         text.
2230         * tui/tui-data.h (NO_DATA_STRING): Remove define.
2231
2232 2019-08-29  Bernhard Wodok  <barto@gmx.net>
2233             Sergio Durigan Junior  <sergiodj@redhat.com>
2234
2235         PR win32/24284
2236         * mingw-hdep.c (gdb_select): Handle case when 'n' is zero.
2237
2238 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
2239
2240         * symtab.c (search_symbols): Don't include MODULE_DOMAIN symbols
2241         when searching for types.
2242
2243 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
2244
2245         * f-lang.c (f_language_defn): Use f_print_typedef.
2246         * f-lang.h (f_print_typedef): Declare.
2247         * f-typeprint.c (f_print_typedef): Define.
2248
2249 2019-08-27  Christian Biesinger  <cbiesinger@google.com>
2250
2251         * nat/linux-namespaces.c (mnsh_main): Initialize fd (to -1).
2252
2253 2019-08-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2254
2255         * cli/cli-utils.c (info_print_options_defs): Delete.
2256         (make_info_print_options_def_group): Delete.
2257         (extract_info_print_options): Delete.
2258         (info_print_command_completer): Delete.
2259         (info_print_args_help): Add extra parameter, and optionally
2260         include text about -n flag.
2261         * cli/cli-utils.h (struct info_print_options): Delete.
2262         (extract_info_print_options): Delete declaration.
2263         (info_print_command_completer): Delete declaration.
2264         (info_print_args_help): Add extra parameter, extend header
2265         comment.
2266         * python/python.c (gdbpy_rbreak): Pass additional parameter to
2267         search_symbols.
2268         * stack.c (struct info_print_options): New type.
2269         (info_print_options_defs): New file scoped variable.
2270         (make_info_print_options_def_group): New static function.
2271         (info_print_command_completer): New static function.
2272         (info_locals_command): Update to use new local functions.
2273         (info_args_command): Likewise.
2274         (_initialize_stack): Add extra parameter to calls to
2275         info_print_args_help.
2276         * symtab.c (search_symbols): Add extra parameter, use this to
2277         possibly excluse non-debug symbols.
2278         (symtab_symbol_info): Add extra parameter, which is passed on to
2279         search_symbols.
2280         (struct info_print_options): New type.
2281         (info_print_options_defs): New file scoped variable.
2282         (make_info_print_options_def_group): New static function.
2283         (info_print_command_completer): New static function.
2284         (info_variables_command): Update to use local functions, and pass
2285         extra parameter through to symtab_symbol_info.
2286         (info_functions_command): Likewise.
2287         (info_types_command): Pass additional argument through to
2288         symtab_symbol_info.
2289         (rbreak_command): Pass extra argument to search_symbols.
2290         (_initialize_symtab): Add extra arguments for calls to
2291         info_print_args_help, and update help text for 'info variables',
2292         'whereis', and 'info functions' commands.
2293         * symtab.h (search_symbols): Add extra argument to declaration.
2294         * NEWS: Mention new flags.
2295
2296 2019-08-26  Christian Biesinger  <cbiesinger@google.com>
2297
2298         * symtab.c (lookup_static_symbol): Call the new function (and move
2299         it down to be next to lookup_global_symbol).
2300         (struct global_sym_lookup_data): Add block_enum member and rename to...
2301         (struct global_or_static_sym_lookup_data): ...this.
2302         (lookup_symbol_global_iterator_cb): Pass block_index instead of
2303         GLOBAL_BLOCK to lookup_symbol_in_objfile and rename to...
2304         (lookup_symbol_global_or_static_iterator_cb): ...this.
2305         (lookup_global_or_static_symbol): New function.
2306         (lookup_global_symbol): Call new function.
2307
2308 2019-08-26  Tom de Vries  <tdevries@suse.de>
2309
2310         PR c++/24852
2311         * break-catch-throw.c (fetch_probe_arguments): Improve error mesage
2312         when pc_probe.prob == NULL.
2313
2314 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
2315
2316         * dwarf2read.c (dw2_debug_names_iterator::next): Rename local
2317         variable symbol_linkage to symbol_linkage_.
2318
2319 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
2320
2321         * dwarf2read.c (dw2_debug_names_iterator::next): Use enum to
2322         represent whether the symbol is static, dynamic, or we don't
2323         know.
2324
2325 2019-08-25  Yoshinori Sato <ysato@users.sourceforge.jp>
2326
2327         * gdb/rx-tdep.c (rx_register_names): New.
2328         (rx_register_name): Delete.
2329         (rx_psw_type): Delete.
2330         (rx_fpsw_type): Delete.
2331         (rx_register_type): Delete.
2332         (rx_gdbarch_init): Convert target-descriptions.
2333         (_initialize_rx_tdep): Add initialize_tdesc_rx.
2334         * gdb/features/Makefile: Add rx.xml.
2335         * gdb/features/rx.xml: New.
2336         * gdb/features/rx.c: Generated.
2337         * gdb/NEWS: Mention target description support.
2338
2339 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
2340
2341         * symtab.c (symbol_cache_lookup): Always initialize *bsc_ptr and
2342         *slot_ptr.
2343
2344 2019-08-23  Sergio Durigan Junior  <sergiodj@redhat.com>
2345
2346         * configure.ac: Don't check for 'dlfcn.h' (moved to
2347         gdbsupport/common.m4).
2348         * Makefile.in (COMMON_SFILES): Move 'gdb-dlfcn.c' to
2349         'gdbsupport/'.
2350         (HFILES_NO_SRCDIR): Likewise, for 'gdb-dlfcn.h'.
2351         * compile/compile-c-support.c: Include
2352         'gdbsupport/gdb-dlfcn.h'.
2353         * gdbsupport/common.m4: Check for 'dlfcn.h'.
2354         * gdb-dlfcn.c: Move to...
2355         * gdbsupport/gdb-dlfcn.c: ... here.
2356         * gdb-dlfcn.h: Move to...
2357         * gdbsupport/gdb-dlfcn.h: ... here.
2358
2359 2019-08-23  Sandra Loosemore  <sandra@codesourcery.com>
2360
2361         * nios2-tdep.c (struct reg_value): Improve comments.  Make
2362         the offset field signed.
2363
2364 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
2365
2366         * python/lib/gdb/__init__.py (_execute_file): New function.
2367         * python/python.c (python_run_simple_file): Call gdb._execute_file
2368         on Windows.
2369
2370 2019-08-22  Andrew Burgess  <andrew.burgess@embecosm.com>
2371
2372         * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
2373         all uses as this was never set to anything but a zero value.
2374
2375 2019-08-21  Bogdan Harjoc  <harjoc@gmail.com>
2376
2377         * cli/cli-cmds.c (with_command_1): Error out if no arguments.
2378
2379 2019-08-21  Christian Biesinger  <cbiesinger@google.com>
2380
2381         * tui/tui-data.h (tui_gen_win_info): Add an =default
2382         move constructor, required by some GCC versions.
2383
2384 2019-08-21  Jinke Fan  <fanjinke51@yeah.net>
2385
2386         * go32-nat.c (go32_sysinfo): Add hygon_p.
2387
2388 2019-08-20  Tom Tromey  <tom@tromey.com>
2389
2390         * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
2391         line_from_reg_element_no, first_reg_element_no_inline,
2392         display_all_data, delete_data_content_windows,
2393         erase_data_content>: Now private.
2394
2395 2019-08-20  Tom Tromey  <tom@tromey.com>
2396
2397         * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
2398         (tui_unhighlight_win, tui_highlight_win)
2399         (tui_win_info::make_window): Update.
2400         * tui/tui-data.h (HILITE, NO_HILITE): Remove.
2401
2402 2019-08-20  Tom Tromey  <tom@tromey.com>
2403
2404         * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
2405         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
2406         (MAX_PID_WIDTH): Move to tui-stack.c.
2407         * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
2408         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
2409         (MAX_PID_WIDTH): Move from tui-data.h.
2410
2411 2019-08-20  Tom Tromey  <tom@tromey.com>
2412
2413         * tui/tui-wingeneral.h (tui_make_window): Don't declare.
2414         * tui/tui-wingeneral.c (box_win): Change type of win_info.
2415         (box_win): Update.
2416         (tui_gen_win_info::make_window): Rename from tui_make_window.
2417         (tui_win_info::make_window): New method.
2418         (tui_gen_win_info::make_visible): Update.
2419         * tui/tui-source.c (tui_source_window::set_contents): Update.
2420         * tui/tui-regs.c (tui_data_window::show_register_group): Update.
2421         (tui_data_window::display_registers_from): Update.
2422         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
2423         * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
2424         Declare.
2425         <can_box>: Remove.
2426         <title>: Remove.
2427         (struct tui_win_info) <make_window>: Declare.
2428         <can_box>: Now virtual.
2429         <title>: New member.
2430         * tui/tui-data.c (~tui_gen_win_info): Don't free title.
2431         * tui/tui-command.c (tui_cmd_window::resize): Update.
2432
2433 2019-08-20  Tom Tromey  <tom@tromey.com>
2434
2435         * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
2436         * tui/tui-regs.c (tui_data_window::show_registers): Update.
2437         (tui_data_window::check_register_values): Update.
2438
2439 2019-08-20  Tom Tromey  <tom@tromey.com>
2440
2441         * tui/tui-regs.h (struct tui_data_window): Use
2442         DISABLE_COPY_AND_ASSIGN.
2443         <regs_content>: Change type, removing unique_ptr.
2444         <tui_data_window>: Add move constructor.
2445         * tui/tui-regs.c (tui_data_window::show_registers)
2446         (tui_data_window::show_register_group)
2447         (tui_data_window::display_registers_from)
2448         (tui_data_window::display_registers_from)
2449         (tui_data_window::first_data_item_displayed)
2450         (tui_data_window::delete_data_content_windows)
2451         (tui_data_window::rerender, tui_data_window::refresh_window)
2452         (tui_data_window::check_register_values): Update.
2453
2454 2019-08-20  Tom Tromey  <tom@tromey.com>
2455
2456         * tui/tui-regs.h (struct tui_data_window) <show_registers,
2457         show_register_group>: Declare.
2458         (tui_show_register_group): Don't declare.
2459         * tui/tui-regs.c (tui_data_window::show_registers): Rename from
2460         tui_show_registers.
2461         (tui_data_window::show_register_group): Rename from
2462         tui_show_register_group.
2463         (tui_data_window::check_register_values, tui_reg_command):
2464         Update.
2465         * tui/tui-layout.c (tui_set_layout): Update.
2466
2467 2019-08-20  Tom Tromey  <tom@tromey.com>
2468
2469         * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
2470         Declare.
2471         (tui_check_register_values): Don't declare.
2472         * tui/tui-regs.c (tui_data_window::check_register_values): Rename
2473         from tui_check_register_values.
2474         * tui/tui-hooks.c (tui_register_changed): Update.
2475
2476 2019-08-20  Tom Tromey  <tom@tromey.com>
2477
2478         * tui/tui-regs.c (tui_reg_layout): Move later.
2479         (tui_show_registers): Don't enable TUI mode or change layout.
2480
2481 2019-08-20  Tom Tromey  <tom@tromey.com>
2482
2483         * tui/tui-regs.h (struct tui_data_item_window)
2484         <~tui_data_item_window>: Remove.
2485         <content>: Now a unique_xmalloc_ptr.
2486         * tui/tui-regs.c (tui_register_format): Return a
2487         unique_xmalloc_ptr.
2488         (tui_get_register): Update.
2489         (~tui_data_item_window): Remove.
2490         (tui_data_window::display_registers_from, tui_display_register):
2491         Update.
2492         * tui/tui-io.h (tui_expand_tabs): Update.
2493         * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
2494         Remove "col" parameter.
2495
2496 2019-08-20  Tom Tromey  <tom@tromey.com>
2497
2498         * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
2499         field.
2500         * tui/tui-regs.c (~tui_data_item_window): Update.
2501
2502 2019-08-20  Tom Tromey  <tom@tromey.com>
2503
2504         * tui/tui-regs.c (tui_register_format, tui_get_register): Move
2505         earlier.
2506
2507 2019-08-20  Tom Tromey  <tom@tromey.com>
2508
2509         * tui/tui-regs.c (tui_reg_command): Remove NULL check.
2510
2511 2019-08-20  Tom Tromey  <tom@tromey.com>
2512
2513         * tui/tui-source.h (struct tui_source_window): Update.
2514         * tui/tui-regs.c (tui_show_registers): Update.
2515         * tui/tui-disasm.h (struct tui_disasm_window): Update.
2516         * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
2517         (NO_REGS_STRING): Remove defines.
2518
2519 2019-08-20  Conrad Meyer  <cem@FreeBSD.org>
2520
2521         * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
2522         unnecessary thread walk if remote doesn't support the packet.
2523
2524 2019-08-19  Tom Tromey  <tromey@adacore.com>
2525
2526         * python/py-value.c (value_has_field): Fix indentation.
2527
2528 2019-08-19  Tom Tromey  <tromey@adacore.com>
2529
2530         * printcmd.c (do_one_display, info_display_command): Update.
2531         * block.h (contained_in): Return bool.  Add allow_nested
2532         parameter.
2533         * block.c (contained_in): Return bool.  Add allow_nested
2534         parameter.
2535
2536 2019-08-19  Tom Tromey  <tom@tromey.com>
2537
2538         * configure: Rebuild.
2539         * configure.ac: Disallow the combination of -static-libstdc++ and
2540         source highlight.
2541         * source-cache.c (get_language_name): Handle rust.
2542         (source_cache::get_source_lines): Ignore highlighting exceptions.
2543
2544 2019-08-16  Tom Tromey  <tom@tromey.com>
2545
2546         * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
2547         * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
2548         (struct tui_source_window_base) <make_visible, refresh_window,
2549         resize>: Remove methods.
2550         <execution_info>: Remove field.
2551         * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
2552         (tui_show_source_line, tui_source_window_base)
2553         (~tui_source_window_base): Update.
2554         (tui_source_window_base::resize)
2555         (tui_source_window_base::make_visible)
2556         (tui_source_window_base::refresh_window): Remove.
2557         (tui_source_window_base::update_exec_info): Update.
2558         * tui/tui-source.c (tui_source_window::set_contents): Update.
2559         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
2560
2561 2019-08-16  Tom Tromey  <tom@tromey.com>
2562
2563         * tui/tui-hooks.c (tui_remove_hooks): Don't set
2564         deprecated_query_hook.
2565
2566 2019-08-16  Tom Tromey  <tom@tromey.com>
2567
2568         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
2569         (tui_update_source_windows_with_line): Update.
2570         * tui/tui-source.h (struct tui_source_window)
2571         <show_symtab_source>: Declare.
2572         (tui_show_symtab_source): Don't declare.
2573         * tui/tui-source.c (tui_show_symtab_source): Rename from
2574         tui_show_symtab_source.
2575
2576 2019-08-16  Tom Tromey  <tom@tromey.com>
2577
2578         * tui/tui-winsource.h (struct tui_source_window_base)
2579         <set_contents>: Declare.
2580         * tui/tui-winsource.c
2581         (tui_source_window_base::update_source_window_as_is): Update.
2582         * tui/tui-source.h (struct tui_source_window) <set_contents>:
2583         Declare.
2584         (tui_set_source_content): Don't declare.
2585         * tui/tui-source.c (tui_source_window::set_contents): Rename from
2586         tui_set_source_content.
2587         * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
2588         Declare.
2589         (tui_set_disassem_content): Don't declare.
2590         * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
2591         tui_set_disassem_content.
2592
2593 2019-08-16  Tom Tromey  <tom@tromey.com>
2594
2595         * tui/tui-winsource.h (struct tui_source_window_base)
2596         <update_breakpoint_info>: Declare.
2597         (tui_update_breakpoint_info): Don't declare.
2598         * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
2599         (tui_update_all_breakpoint_info): Update.
2600         (tui_source_window_base::update_breakpoint_info): Rename from
2601         tui_update_breakpoint_info.
2602         (tui_source_window_base::update_exec_info): Update.
2603
2604 2019-08-16  Tom Tromey  <tom@tromey.com>
2605
2606         * tui/tui-winsource.h (struct tui_source_window_base)
2607         <update_source_window>: Declare.
2608         (tui_update_source_window): Don't declare.
2609         * tui/tui-winsource.c
2610         (tui_source_window_base::update_source_window): Rename from
2611         tui_update_source_window.
2612         (tui_source_window_base::rerender): Update.
2613         * tui/tui-source.c (tui_source_window::maybe_update): Update.
2614         * tui/tui-disasm.c (tui_show_disassem)
2615         (tui_show_disassem_and_update_source)
2616         (tui_disasm_window::maybe_update): Update.
2617
2618 2019-08-16  Tom Tromey  <tom@tromey.com>
2619
2620         * tui/tui-winsource.h (struct tui_source_window_base)
2621         <update_source_window_as_is>: Declare.
2622         (tui_update_source_window_as_is): Don't declare.
2623         * tui/tui-winsource.c (tui_update_source_window): Update
2624         (tui_source_window_base::update_source_window_as_is): Rename from
2625         tui_update_source_window_as_is.
2626         (tui_source_window_base::refill): Update.
2627         * tui/tui-source.c (tui_show_symtab_source): Update.
2628         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
2629         Update.
2630
2631 2019-08-16  Tom Tromey  <tom@tromey.com>
2632
2633         * tui/tui-winsource.h (tui_update_source_window)
2634         (tui_update_source_window_as_is): Remove "noerror" parameter.
2635         * tui/tui-winsource.c (tui_update_source_window)
2636         (tui_update_source_window_as_is): Remove "noerror" parameter.
2637         (tui_update_source_windows_with_addr)
2638         (tui_update_source_windows_with_line)
2639         (tui_source_window_base::rerender)
2640         (tui_source_window_base::refill): Update.
2641         * tui/tui-source.h (tui_set_source_content)
2642         (tui_show_symtab_source): Remove "noerror" parameter.
2643         * tui/tui-source.c (tui_set_source_content): Remove "noerror"
2644         parameter.
2645         (tui_show_symtab_source): Likewise.
2646         (tui_source_window::maybe_update): Update.
2647         * tui/tui-disasm.c (tui_show_disassem)
2648         (tui_show_disassem_and_update_source)
2649         (tui_disasm_window::do_scroll_vertical)
2650         (tui_disasm_window::maybe_update): Update.
2651
2652 2019-08-16  Tom Tromey  <tom@tromey.com>
2653
2654         * tui/tui.c (tui_is_window_visible): Update.
2655         * tui/tui-wingeneral.c (tui_make_window)
2656         (tui_gen_win_info::make_visible, tui_refresh_all): Update.
2657         * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
2658         (tui_set_focus_command, tui_all_windows_info, update_tab_width)
2659         (tui_set_win_height_command, parse_scrolling_args): Update.
2660         * tui/tui-source.c (tui_source_window::style_changed): Update.
2661         * tui/tui-regs.c (tui_show_registers)
2662         (tui_data_window::first_data_item_displayed)
2663         (tui_data_window::delete_data_content_windows)
2664         (tui_check_register_values, tui_reg_command): Update.
2665         * tui/tui-disasm.c (tui_show_disassem): Update.
2666         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
2667         method.
2668         <is_visible>: Remove field.
2669         * tui/tui-data.c (tui_next_win, tui_prev_win)
2670         (tui_delete_invisible_windows): Update.
2671
2672 2019-08-16  Tom Tromey  <tom@tromey.com>
2673
2674         * tui/tui-winsource.h (struct tui_source_window_base)
2675         <m_has_locator>: Remove.
2676         * tui/tui-layout.c (show_source_disasm_command, show_data)
2677         (show_source_or_disasm_and_command): Update.
2678
2679 2019-08-16  Alan Hayward  <alan.hayward@arm.com>
2680
2681         * NEWS (Other MI changes): New subsection.
2682         * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
2683         (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
2684         * arch-utils.c (default_get_pc_address_flags): New function.
2685         * arch-utils.h (default_get_pc_address_flags): New declaration.
2686         * gdbarch.sh: Add get_pc_address_flags.
2687         * gdbarch.c: Regenerate.
2688         * gdbarch.h: Likewise.
2689         * stack.c (print_pc): New function.
2690         (print_frame_info) (print_frame): Call print_pc.
2691
2692 2019-08-16  Tom de Vries  <tdevries@suse.de>
2693
2694         * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
2695         print_objfile_section_info.
2696
2697 2019-08-15  Tom Tromey  <tom@tromey.com>
2698
2699         * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
2700         calling update_cmdwin_start_line.
2701         * tui/tui-winsource.h (struct tui_source_window_base)
2702         <do_make_visible_with_new_height, set_new_height>: Don't declare.
2703         <rerender>: Declare.
2704         * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
2705         Call rerender.
2706         (tui_source_window_base::set_new_height): Remove.
2707         (tui_source_window_base::rerender): Rename from
2708         do_make_visible_with_new_height.
2709         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
2710         resize method.
2711         (tui_win_info::make_invisible_and_set_new_height)
2712         (tui_win_info::make_visible_with_new_height): Remove.
2713         * tui/tui-stack.h (struct tui_locator_window) <rerender>:
2714         Declare.
2715         * tui/tui-stack.c (tui_locator_window::rerender): New method.
2716         * tui/tui-regs.h (struct tui_data_window) <set_new_height,
2717         do_make_visible_with_new_height>: Don't declare.
2718         <rerender>: Declare.
2719         * tui/tui-regs.c (tui_data_window::rerender): Rename from
2720         set_new_height.
2721         (tui_data_window::do_make_visible_with_new_height): Remove.
2722         * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
2723         call tui_show_locator_content.
2724         (tui_gen_win_info::resize): Call rerender.
2725         (show_source_or_disasm_and_command): Don't call
2726         tui_show_locator_content.
2727         * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
2728         method.
2729         (struct tui_win_info) <rerender>: Declare.
2730         <set_new_height, make_invisible_and_set_new_height,
2731         make_visible_with_new_height>: Don't declare.
2732         * tui/tui-data.c (tui_win_list::rerender): New method.
2733         * tui/tui-command.h (struct tui_cmd_window)
2734         <do_make_visible_with_new_height>: Don't declare.
2735         * tui/tui-command.c
2736         (tui_cmd_window::do_make_visible_with_new_height): Remove.
2737
2738 2019-08-15  Tom Tromey  <tromey@adacore.com>
2739
2740         * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
2741         * ada-lang.c (ada_enum_name): Likewise.
2742
2743 2019-08-15  Christian Biesinger  <cbiesinger@google.com>
2744
2745         * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
2746         leading underscore.
2747         (GdbOutputErrorFile): Likewise.
2748         (global scope): Adjust constructor calls to GdbOutput{,Error}File
2749         accordingly.
2750         (execute_unwinders): Rename to have a leading underscore.
2751         (auto_load_packages): Likewise.
2752         (global scope): Adjust call to auto_load_packages accordingly.
2753         (GdbSetPythonDirectory): Likewise.
2754         * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
2755         instead of execute_unwinders.
2756
2757 2019-08-15  Tom Tromey  <tom@tromey.com>
2758
2759         * tui/tui-layout.c (show_layout, show_source_disasm_command)
2760         (show_data): Don't change window visibility.
2761         (tui_gen_win_info::resize): Remove special case for command
2762         window.  Use wresize, when available.
2763         (show_source_or_disasm_and_command): Don't change window
2764         visibility.
2765         * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
2766         <make_visible>: New method.
2767         * tui/tui-command.c (tui_cmd_window::resize): New method.
2768
2769 2019-08-15  Tom Tromey  <tom@tromey.com>
2770
2771         * tui/tui-winsource.h (struct tui_source_window_iterator): New.
2772         (struct tui_source_windows): New.
2773         * tui/tui-winsource.c (tui_display_main): Update.
2774         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2775         (new_height_ok, parse_scrolling_args): Update.
2776         * tui/tui-layout.c (show_layout, show_data): Update.
2777         * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
2778         (tui_add_to_source_windows): Don't declare.
2779         * tui/tui-data.c (source_windows, tui_source_windows)
2780         (tui_clear_source_windows, tui_add_to_source_windows): Remove.
2781
2782 2019-08-15  Tom Tromey  <tom@tromey.com>
2783
2784         * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
2785         Rename from reset.
2786         * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
2787         * tui/tui-layout.c (show_source_disasm_command, show_data):
2788         Update.
2789         (tui_gen_win_info::resize): Rename.
2790         (show_source_or_disasm_and_command): Update.
2791         * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
2792         reset.
2793
2794 2019-08-15  Tom Tromey  <tom@tromey.com>
2795
2796         * tui/tui-stack.c (tui_initialize_static_data): Remove.
2797         * tui/tui-interp.c (tui_interp::init): Don't call
2798         tui_initialize_static_data.
2799         * tui/tui-data.h (tui_initialize_static_data): Don't declare.
2800
2801 2019-08-15  Tom Tromey  <tom@tromey.com>
2802
2803         * tui/tui-layout.c (tui_default_win_viewport_height): Don't
2804         examine tui_win_list.
2805
2806 2019-08-15  Tom Tromey  <tom@tromey.com>
2807
2808         * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
2809         * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
2810         tui_clear_source_content.
2811         (tui_clear_source_content): Remove.
2812         (tui_source_window_base::do_erase_source_content): Hoist call to
2813         content.clear().
2814         * tui/tui-stack.c (tui_show_frame_info): Don't call
2815         tui_clear_source_content.
2816
2817 2019-08-15  Tom Tromey  <tom@tromey.com>
2818
2819         * tui/tui-winsource.h (struct tui_source_window_base)
2820         <do_erase_source_content>: New method.
2821         <erase_source_content>: New method.
2822         (tui_erase_source_content): Don't declare.
2823         * tui/tui-winsource.c (tui_clear_source_content): Update.
2824         (tui_source_window_base::do_erase_source_content): Rename from
2825         tui_erase_source_content.
2826         (tui_source_window_base::show_source_content): Update.
2827         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
2828         * tui/tui-source.h (struct tui_source_window)
2829         <erase_source_content>: New method.
2830         * tui/tui-disasm.h (struct tui_disasm_window)
2831         <erase_source_content>: New method.
2832
2833 2019-08-15  Tom Tromey  <tom@tromey.com>
2834
2835         * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
2836         (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
2837         constructor.
2838         * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
2839         * tui/tui-source.c (tui_set_source_content): Update.
2840         * tui/tui-disasm.c (tui_set_disassem_content): Update.
2841
2842 2019-08-15  Tom Tromey  <tom@tromey.com>
2843
2844         * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
2845         * tui/tui-winsource.c (tui_line_is_displayed): Move to
2846         tui-source.c.
2847         * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
2848         Declare.
2849         * tui/tui-source.c (tui_source_window::line_is_displayed): New
2850         method.
2851         (tui_source_window::maybe_update): Update.
2852
2853 2019-08-15  Tom Tromey  <tom@tromey.com>
2854
2855         * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
2856         * tui/tui-winsource.c (tui_addr_is_displayed): Move to
2857         tui-disasm.c.
2858         * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
2859         Declare.
2860         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
2861         method.
2862         (tui_disasm_window::maybe_update): Update.
2863
2864 2019-08-15  Tom Tromey  <tom@tromey.com>
2865
2866         * tui/tui-winsource.h (struct tui_source_window_base)
2867         <maybe_update>: Declare.
2868         * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
2869         method.
2870         * tui/tui-source.h (struct tui_source_window) <maybe_update>:
2871         Declare.
2872         * tui/tui-source.c (tui_source_window::maybe_update): New method.
2873         * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
2874         Declare.
2875         * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
2876
2877 2019-08-15  Tom Tromey  <tom@tromey.com>
2878
2879         * tui/tui-stack.c (tui_make_status_line): Use string constructor.
2880
2881 2019-08-15  Tom Tromey  <tom@tromey.com>
2882
2883         * tui/tui-wingeneral.c: Include tui-stack.h.
2884         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
2885         (struct tui_locator_window): Move from tui-data.h.
2886         * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
2887         (tui_initialize_static_data): Move from tui-data.c.
2888         * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
2889         (struct tui_locator_window): Move to tui-stack.c.
2890         * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
2891         (tui_initialize_static_data): Move to tui-stack.c.
2892
2893 2019-08-15  Tom Tromey  <tom@tromey.com>
2894
2895         * tui/tui-layout.c (show_source_disasm_command)
2896         (show_source_or_disasm_and_command): Use make_visible method, not
2897         tui_make_window.
2898         * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
2899         Remove.
2900
2901 2019-08-15  Tom Tromey  <tom@tromey.com>
2902
2903         * tui/tui-wingeneral.h (tui_make_window): Update.
2904         * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
2905         parameter.
2906         (tui_gen_win_info::make_visible): Update.
2907         * tui/tui-regs.c (tui_data_window::display_registers_from):
2908         Update.
2909         * tui/tui-layout.c (show_source_disasm_command)
2910         (show_source_or_disasm_and_command): Update.
2911         * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
2912         (enum tui_box): Remove.
2913         (struct tui_win_info) <can_box>: New method.
2914         * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
2915         method.
2916
2917 2019-08-15  Tom de Vries  <tdevries@suse.de>
2918
2919         * linux-nat-trad.c: Include gdbarch.h.
2920
2921 2019-08-14  Alan Hayward  <alan.hayward@arm.com>
2922
2923         * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
2924         register sizes.
2925
2926 2019-08-14  Tom Tromey  <tromey@adacore.com>
2927
2928         * darwin-nat.c: Include gdbarch.h.
2929         * darwin-nat-info.c: Include gdbarch.h.
2930
2931 2019-08-13  Tom Tromey  <tom@tromey.com>
2932
2933         * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
2934         Remove.
2935         * tui/tui-data.c (tui_initialize_static_data): Update.
2936
2937 2019-08-13  Tom Tromey  <tom@tromey.com>
2938
2939         * tui/tui-winsource.h (struct tui_exec_info_window)
2940         <~tui_exec_info_window, maybe_allocate_content, get_content,
2941         m_content>: Remove.
2942         (struct tui_source_window_base) <set_exec_info_content,
2943         show_exec_info_content>: Don't declare.
2944         * tui/tui-winsource.c
2945         (tui_exec_info_window::maybe_allocate_content): Remove.
2946         (tui_source_window_base::update_exec_info): Rename from
2947         set_exec_info_content.
2948         (tui_source_window_base::show_exec_info_content)
2949         (tui_source_window_base::update_exec_info): Remove.
2950
2951 2019-08-13  Tom Tromey  <tom@tromey.com>
2952
2953         * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
2954         declare.
2955         * tui/tui-winsource.c (tui_update_source_window_as_is)
2956         (tui_update_source_windows_with_addr, tui_erase_source_content):
2957         Update.
2958         (tui_clear_exec_info_content): Remove.
2959
2960 2019-08-13  Tom Tromey  <tom@tromey.com>
2961
2962         * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
2963         declare.
2964         * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
2965         call tui_erase_exec_info_content.
2966         (tui_clear_exec_info_content): Rename from
2967         tui_erase_exec_info_content.
2968         (tui_clear_exec_info_content): Delete.
2969
2970 2019-08-13  Tom Tromey  <tom@tromey.com>
2971
2972         * tui/tui-winsource.h (struct tui_source_window_base)
2973         <show_exec_info_content>: Declare.
2974         (tui_show_exec_info_content): Don't declare.
2975         * tui/tui-winsource.c
2976         (tui_source_window_base::show_exec_info_content): Rename from
2977         tui_show_exec_info_content.
2978         (tui_source_window_base::update_exec_info): Update.
2979
2980 2019-08-13  Tom Tromey  <tom@tromey.com>
2981
2982         * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
2983         (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
2984         (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
2985         * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
2986         tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
2987         (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
2988         ... here.
2989
2990 2019-08-13  Tom Tromey  <tom@tromey.com>
2991
2992         * tui/tui-winsource.h (struct tui_source_window_base)
2993         <update_exec_info>: Declare.
2994         (tui_update_exec_info): Don't declare.
2995         * tui/tui-winsource.c (tui_update_source_window_as_is)
2996         (tui_source_window_base::refresh_all)
2997         (tui_update_all_breakpoint_info): Update.
2998         (tui_source_window_base::update_exec_info): Rename from
2999         tui_update_exec_info.
3000         * tui/tui-stack.c (tui_show_frame_info): Update.
3001
3002 2019-08-13  Tom Tromey  <tom@tromey.com>
3003
3004         * tui/tui-winsource.h (struct tui_source_window_base)
3005         <set_exec_info_content>: Declare.
3006         (tui_set_exec_info_content): Don't declare.
3007         * tui/tui-winsource.c
3008         (tui_source_window_base::set_exec_info_content): Rename from
3009         tui_set_exec_info_content.
3010         (tui_update_exec_info): Update.
3011
3012 2019-08-13  Tom Tromey  <tom@tromey.com>
3013
3014         * tui/tui-winsource.h (struct tui_source_window_base)
3015         <show_source_content>: Declare.
3016         (tui_show_source_content): Don't declare.
3017         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
3018         (tui_source_window_base::show_source_content): Rename from
3019         tui_show_source_content.
3020         (tui_source_window_base::refresh_all): Update.
3021         * tui/tui-layout.c (show_source_disasm_command)
3022         (show_source_or_disasm_and_command): Update.
3023
3024 2019-08-13  Tom Tromey  <tom@tromey.com>
3025
3026         * tui/tui-winsource.c (tui_erase_source_content)
3027         (tui_show_source_content, tui_source_window_base::refresh_all):
3028         Update.
3029         * tui/tui-wingeneral.h
3030         (tui_check_and_display_highlight_if_needed): Don't declare.
3031         * tui/tui-wingeneral.c
3032         (tui_win_info::check_and_display_highlight_if_needed): Rename from
3033         check_and_display_highlight_if_needed.
3034         * tui/tui-win.c (tui_rehighlight_all)
3035         (tui_win_info::make_visible_with_new_height): Update.
3036         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
3037         (tui_data_window::erase_data_content)
3038         (tui_data_window::display_all_data): Update.
3039         * tui/tui-data.h (struct tui_win_info)
3040         <check_and_display_highlight_if_needed>: Declare.
3041
3042 2019-08-13  Tom Tromey  <tom@tromey.com>
3043
3044         * tui/tui-win.c (tui_resize_all): Call
3045         tui_delete_invisible_windows.
3046         * tui/tui-layout.c (show_layout): Call
3047         tui_delete_invisible_windows.
3048         * tui/tui-data.h (tui_delete_invisible_windows): Declare.
3049         * tui/tui-data.c (tui_delete_invisible_windows): New function.
3050
3051 2019-08-13  Tom Tromey  <tom@tromey.com>
3052
3053         * tui/tui-disasm.c (tui_show_disassem): Add assertion.  Don't call
3054         tui_add_win_to_layout.
3055
3056 2019-08-13  Tom Tromey  <tom@tromey.com>
3057
3058         * tui/tui-layout.h (tui_default_win_height): Don't declare.
3059         * tui/tui-layout.c (tui_default_win_height): Now static.
3060
3061 2019-08-13  Tom Tromey  <tom@tromey.com>
3062
3063         * tui/tui-layout.c (show_layout): Unify all layout cases into a
3064         single switch.
3065         (show_source_disasm_command, show_source_or_disasm_and_command):
3066         Don't check current layout.
3067
3068 2019-08-13  Tom Tromey  <tom@tromey.com>
3069
3070         * tui/tui-wingeneral.c (make_all_visible): Remove.
3071         (tui_make_all_invisible): Simplify.
3072         * tui/tui-layout.c (tui_make_all_invisible): Move from
3073         tui-wingeneral.c; simplify.
3074         (show_layout): Hoist call to tui_make_all_invisible.
3075         (show_data): Don't call tui_make_all_invisible.
3076
3077 2019-08-13  Tom Tromey  <tom@tromey.com>
3078
3079         * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
3080         * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
3081
3082 2019-08-13  Tom Tromey  <tom@tromey.com>
3083
3084         * tui/tui-layout.c (current_layout, tui_current_layout): Move from
3085         tui-data.c.
3086         (show_source_disasm_command, show_data)
3087         (show_source_or_disasm_and_command): Don't use
3088         tui_set_current_layout_to.
3089         * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
3090         * tui/tui-data.c (current_layout, tui_current_layout): Move to
3091         tui-layout.c.
3092         (tui_set_current_layout_to): Remove.
3093
3094 2019-08-13  Tom Tromey  <tom@tromey.com>
3095
3096         * tui/tui-layout.c (tui_set_layout): Update.
3097         * tui/tui-data.h (struct tui_layout_def): Remove.
3098         (tui_layout_def): Don't declare.
3099         * tui/tui-data.c (layout_def): Remove.
3100         (tui_layout_def): Remove.
3101
3102 2019-08-13  Tom Tromey  <tom@tromey.com>
3103
3104         * tui/tui-winsource.h (struct tui_source_window_base)
3105         <clear_detail>: No longer "override".
3106         * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
3107         * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
3108         * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
3109         * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
3110         Remove.
3111         * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
3112
3113 2019-08-13  Tom Tromey  <tromey@adacore.com>
3114
3115         * tracepoint.c: Don't include readline.h or history.h.
3116
3117 2019-08-12  Tom Tromey  <tom@tromey.com>
3118
3119         * configure: Rebuild.
3120         * configure.ac: Check for readline 7.
3121         * NEWS: Mention readline 7 requirement.
3122         * README: Update.
3123
3124 2019-08-12  Tom Tromey  <tom@tromey.com>
3125
3126         * mingw-hdep.c (gdb_select): Remove readline hack.
3127
3128 2019-08-09  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
3129
3130         * blockframe.c (find_pc_partial_function): Set *block to nullptr
3131         when the function fails.
3132
3133 2019-08-09  Andreas Arnez  <arnez@linux.ibm.com>
3134
3135         * s390-tdep.c (s390_type_align): New function.
3136         (s390_gdbarch_init): Set it as type_align gdbarch method.
3137
3138 2019-08-09  Tom de Vries  <tdevries@suse.de>
3139
3140         PR gdb/24591
3141         * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
3142         pc_low with relocation offset.
3143
3144 2019-08-07  Tom Tromey  <tromey@adacore.com>
3145
3146         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
3147         (print_frame_args): Update.
3148         * python/py-framefilter.c (py_print_single_arg, enumerate_args):
3149         Update.
3150         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
3151         * frame.h (struct frame_arg): Add initializers.
3152         <error>: Now a unique_xmalloc_ptr.
3153
3154 2019-08-07  Alan Hayward  <alan.hayward@arm.com>
3155
3156         * NEWS: Expand the Pointer Authentication entry.
3157         * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
3158         (aarch64_frame_unmask_lr): ... to this.
3159         (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
3160         Call aarch64_frame_unmask_lr.
3161         * frame.c (struct frame_info): Add "masked" variable.
3162         (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
3163         (fprint_frame): Check for masked pc.
3164         * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
3165         declarations.
3166         * python/py-framefilter.c (py_print_frame): Check for masked pc.
3167         * stack.c (print_frame): Check for masked pc.
3168
3169 2019-08-06  Tom Tromey  <tom@tromey.com>
3170
3171         * stabsread.c (patch_block_stabs, read_one_struct_field)
3172         (read_enum_type): Use obstack_strndup.
3173         * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
3174         * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
3175         * dwarf2read.c (guess_full_die_structure_name)
3176         (anonymous_struct_prefix): Use obstack_strndup.
3177         * dbxread.c (cp_set_block_scope): Use obstack_strndup.
3178         * c-exp.y (yylex): Use obstack_strndup.
3179         * ada-exp.y (write_object_renaming, write_ambiguous_var)
3180         (write_var_or_type): Use obstack_strndup.
3181
3182 2019-08-06  Tom Tromey  <tom@tromey.com>
3183
3184         * symfile.c (reread_symbols): Use obstack_strdup.
3185         * stabsread.c (read_type): Use obstack_strdup.
3186         * gdb_obstack.h (obstack_strdup): New overload.
3187         * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
3188         (create_dwo_unit_in_dwp_v2, build_error_marker_type)
3189         (dwarf2_canonicalize_name): Use obstack_strdup.
3190         * dbxread.c (read_dbx_symtab): Use obstack_strdup.
3191         * cp-support.c (inspect_type, replace_typedefs_qualified_name):
3192         Use obstack_strdup.
3193
3194 2019-08-06  Tom Tromey  <tom@tromey.com>
3195
3196         * gdb_obstack.h (obstack_strdup): Define.
3197         * gdb_obstack.c (obstack_strdup): Don't define.
3198
3199 2019-08-06  Tom Tromey  <tom@tromey.com>
3200
3201         * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
3202         obstack_strdup.
3203         * typeprint.c (typedef_hash_table::find_global_typedef): Use
3204         obstack_strdup.
3205         * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
3206         * stabsread.c (common_block_start): Use obstack_strdup.
3207         * objfiles.c (set_objfile_main_name, objfile): Use
3208         obstack_strdup.
3209         * namespace.c (add_using_directive): Use obstack_strdup.
3210         * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
3211         * jit.c (finalize_symtab): Use obstack_strdup.
3212         * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
3213         (guess_partial_die_structure_name, partial_die_info::fixup)
3214         (dwarf2_name): Use obstack_strdup.
3215         * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
3216         obstack_strdup.
3217         * c-exp.y (scan_macro_expansion): Use obstack_strdup.
3218         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
3219         obstack_strdup.
3220         * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
3221
3222 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3223
3224         * unittests/help-doc-selftests.c: New file.
3225         * Makefile.in: Add the new file.
3226
3227 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3228
3229         * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
3230         * cli/cli-decode.c (print_doc_line): Likewise.  It now prints
3231         the full first line, except when FOR_VALUE_PREFIX.  In this case,
3232         the trailing '.' is not output, and the first character is uppercased.
3233         (print_help_for_command): Update call to print_doc_line.
3234         (print_doc_of_command): Likewise.
3235         * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
3236         * cli/cli-option.c (append_indented_doc): Do not append newline.
3237         (build_help_option): Append newline after first appended_indented_doc
3238         only if a second call is done.
3239         (build_help): Append 2 new lines before each option, except the first
3240         one.
3241         * compile/compile.c (_initialize_compile): Add new lines after
3242         %OPTIONS%, when not at the end of the help.
3243         Change help doc or code
3244         producing the help doc to respect the invariants.
3245         * maint-test-options.c (_initialize_maint_test_options): Likewise.
3246         Also removed the new line after 'Options:', as all other commands
3247         do not put an empty line between 'Options:' and the first option.
3248         * printcmd.c (_initialize_printcmd): Likewise.
3249         * stack.c (_initialize_stack): Likewise.
3250         * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
3251         incorrectly telling COMMAND is optional.
3252         * ada-lang.c (_initialize_ada_language): Change help doc or code
3253         producing the help doc to respect the invariants.
3254         * ada-tasks.c (_initialize_ada_tasks): Likewise.
3255         * breakpoint.c (_initialize_breakpoint): Likewise.
3256         * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
3257         * cli/cli-logging.c (_initialize_cli_logging): Likewise.
3258         * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
3259         * cli/cli-style.c (cli_style_option::add_setshow_commands,
3260         _initialize_cli_style): Likewise.
3261         * corelow.c (core_target_info): Likewise.
3262         * dwarf-index-cache.c (_initialize_index_cache): Likewise.
3263         * dwarf2read.c (_initialize_dwarf2_read): Likewise.
3264         * filesystem.c (_initialize_filesystem): Likewise.
3265         * frame.c (_initialize_frame): Likewise.
3266         * gnu-nat.c (add_task_commands): Likewise.
3267         * infcall.c (_initialize_infcall): Likewise.
3268         * infcmd.c (_initialize_infcmd): Likewise.
3269         * interps.c (_initialize_interpreter): Likewise.
3270         * language.c (_initialize_language): Likewise.
3271         * linux-fork.c (_initialize_linux_fork): Likewise.
3272         * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
3273         * maint.c (_initialize_maint_cmds): Likewise.
3274         * memattr.c (_initialize_mem): Likewise.
3275         * printcmd.c (_initialize_printcmd): Likewise.
3276         * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
3277         _RegEx): Likewise.
3278         * ravenscar-thread.c (_initialize_ravenscar): Likewise.
3279         * record-btrace.c (_initialize_record_btrace): Likewise.
3280         * record-full.c (_initialize_record_full): Likewise.
3281         * record.c (_initialize_record): Likewise.
3282         * regcache-dump.c (_initialize_regcache_dump): Likewise.
3283         * regcache.c (_initialize_regcache): Likewise.
3284         * remote.c (add_packet_config_cmd, init_remote_threadtests,
3285         _initialize_remote): Likewise.
3286         * ser-tcp.c (_initialize_ser_tcp): Likewise.
3287         * serial.c (_initialize_serial): Likewise.
3288         * skip.c (_initialize_step_skip): Likewise.
3289         * source.c (_initialize_source): Likewise.
3290         * stack.c (_initialize_stack): Likewise.
3291         * symfile.c (_initialize_symfile): Likewise.
3292         * symtab.c (_initialize_symtab): Likewise.
3293         * target-descriptions.c (_initialize_target_descriptions): Likewise.
3294         * top.c (init_main): Likewise.
3295         * tracefile-tfile.c (tfile_target_info): Likewise.
3296         * tracepoint.c (_initialize_tracepoint): Likewise.
3297         * tui/tui-win.c (_initialize_tui_win): Likewise.
3298         * utils.c (add_internal_problem_command): Likewise.
3299         * valprint.c (value_print_option_defs): Likewise.
3300
3301 2019-08-06  Frank Ch. Eigler  <fche@redhat.com>
3302
3303         PR build/24886
3304         * configure.ac: Drop enable-libmcheck support.
3305         * configure, config.in: Rebuild.
3306         * libmcheck.m4: Remove.
3307         * acinclude.m4: Don't include it.
3308         * Makefile.in: Don't distribute it.
3309         * top.c (print_gdb_configuration): Don't mention it.
3310
3311 2019-08-06  Tom Tromey  <tom@tromey.com>
3312
3313         * utils.c (set_output_style): Sometimes pass stream to
3314         emit_style_escape.
3315         * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
3316         * record-btrace.c (btrace_insn_history): Update.
3317         * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
3318         method.
3319         * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
3320         Update initializers.
3321         <m_uiout>: New field.
3322         <m_di>: Move lower.
3323         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
3324         Remove "uiout" parameter.
3325         (dump_insns): Update.
3326         * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
3327         * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
3328
3329 2019-08-06  Christian Biesinger  <cbiesinger@google.com>
3330
3331         * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
3332         (error_in_psymtab_expansion): Likewise.
3333         (lookup_symbol_via_quick_fns): Likewise.
3334         (basic_lookup_transparent_type_quick): Likewise.
3335         (basic_lookup_transparent_type_1): Likewise.
3336
3337 2019-08-06  Tom Tromey  <tromey@adacore.com>
3338
3339         * source.c (last_source_error): Now bool.
3340         (print_source_lines_base): Make "noprint" bool.  Only open
3341         source file when last_source_visited changes.
3342
3343 2019-08-06  Tom Tromey  <tromey@adacore.com>
3344
3345         * annotate.c (annotate_source_line): Use g_source_cache.
3346         * source-cache.c (source_cache::get_plain_source_lines): Change
3347         parameters.  Populate m_offset_cache.
3348         (source_cache::ensure): New method.
3349         (source_cache::get_line_charpos): New method.
3350         (extract_lines): Move lower.  Change parameters.
3351         (source_cache::get_source_lines): Move lower.
3352         * source-cache.h (class source_cache): Update comment.
3353         <get_line_charpos>: New method.
3354         <get_source_lines>: Update comment.
3355         <clear>: Clear m_offset_cache.
3356         <get_plain_source_lines>: Change parameters.
3357         <ensure>: New method
3358         <m_offset_cache>: New member.
3359         * source.c (forget_cached_source_info_for_objfile): Update.
3360         (info_source_command): Use g_source_cache.
3361         (find_source_lines, open_source_file_with_line_charpos): Remove.
3362         (print_source_lines_base, search_command_helper): Use g_source_cache.
3363         * source.h (open_source_file_with_line_charpos): Don't declare.
3364         * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
3365         * tui/tui-source.c (tui_source_window::do_scroll_vertical):
3366         Use g_source_cache.
3367
3368 2019-08-06  Tom Tromey  <tromey@adacore.com>
3369
3370         * source-cache.c (source_cache::get_plain_source_lines):
3371         Remove "first_line" and "last_line" parameters.
3372         (source_cache::get_source_lines): Cache plain text.
3373         * source-cache.h (class source_cache)
3374         <get_plain_source_lines>: Update.
3375
3376 2019-08-06  Tom Tromey  <tromey@adacore.com>
3377
3378         * source-cache.c (extract_lines): No longer a method.
3379         Changed type of parameter.  Include final newline.
3380         (selftests::extract_lines_test): New function.
3381         (_initialize_source_cache): Likewise.
3382         * source-cache.h (class source_cache)
3383         <extract_lines>: Don't declare.
3384
3385 2019-08-06  Tom Tromey  <tromey@adacore.com>
3386
3387         * breakpoint.c (init_breakpoint_sal): Update.
3388         (breakpoint): Update.
3389         * breakpoint.h (struct breakpoint) <filter>: Now a
3390         unique_xmalloc_ptr.
3391
3392 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
3393
3394         * NEWS: Mention dictionary access on blocks.
3395         * python/py-block.c (blpy_getitem): New function.
3396         (block_object_as_mapping): New struct.
3397         (block_object_type): Use new struct for tp_as_mapping field.
3398
3399 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
3400
3401         * objfiles.h (objfile): Add a comment describing partial symbols.
3402
3403 2019-08-05  Tom Tromey  <tromey@adacore.com>
3404
3405         * compile/compile.c (_initialize_compile): Use _(), not N_().
3406         * thread.c (_initialize_thread): Use _(), not N_().
3407         * stack.c (_initialize_stack): Use _(), not N_().
3408         * printcmd.c (_initialize_printcmd): Use _(), not N_().
3409
3410 2019-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
3411
3412         * dwarf2read.c (struct dw2_symtab_iterator):
3413         <want_specific_block>: Remove.
3414         <block_index>: Change type to gdb::optional.
3415         (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
3416         change type of BLOCK_INDEX parameter to gdb::optional.
3417         (dw2_symtab_iter_next): Re-write in function of gdb::optional.
3418         (dw2_lookup_symbol): Don't pass argument for
3419         WANT_SPECIFIC_BLOCK.
3420         (dw2_expand_symtabs_for_function): Don't pass argument for
3421         WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
3422         (class dw2_debug_names_iterator)
3423         <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
3424         parameter, change BLOCK_INDEX type to gdb::optional.
3425         <m_want_specific_block>: Remove.
3426         <m_block_index>: Change type to gdb::optional.
3427         (dw2_debug_names_iterator::next): Change type of IS_STATIC to
3428         gdb::optional.  Re-write in function of gdb::optional.
3429         (dw2_debug_names_lookup_symbol): Don't pass argument for
3430         WANT_SPECIFIC_BLOCK.
3431         (dw2_debug_names_expand_symtabs_for_function): Don't pass
3432         argument for WANT_SPECIFIC_BLOCK, pass empty optional for
3433         BLOCK_INDEX.
3434
3435 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3436
3437         * NEWS: Mention changes to "info sources" command.
3438
3439 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3440
3441         * symtab.c (filename_partial_match_opts): New struct type.
3442         (struct output_source_filename_data): New members
3443         regexp, c_regexp, partial_match.
3444         (output_source_filename): Use new members to decide to print file.
3445         (info_sources_option_defs): New variable.
3446         (make_info_sources_options_def_group, print_info_sources_header,
3447         info_sources_command_completer):
3448         New functions.
3449         (info_sources_command): Read new optional arguments.
3450         (_initialize_symtab): Update info sources help.
3451
3452 2019-08-02  Alexandre Oliva <oliva@adacore.com>
3453
3454         * ada-lang.c (exception_support_info_v0): Renamed from...
3455         (default_exception_support_info): ... this.  Create new
3456         definition for v1.
3457         (ada_has_this_exception_support): Look up catch_handlers_sym.
3458         (ada_exception_support_info_sniffer): Try v0 after default.
3459
3460 2019-08-01  Tom Tromey  <tromey@adacore.com>
3461
3462         * ia64-libunwind-tdep.h (struct libunwind_descr): Include
3463         gdbarch.h.
3464
3465 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
3466
3467         * s12z-tdep.c: Fix include path for s12z-opc.h.
3468
3469 2019-08-01  Alan Hayward  <alan.hayward@arm.com>
3470
3471         * NEWS: Require GNU make 3.82.
3472
3473 2019-07-16  Tom Tromey  <tom@tromey.com>
3474
3475         * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
3476         declare.
3477
3478 2019-07-30  Tom Tromey  <tromey@adacore.com>
3479
3480         * block.c (contained_in): Remove BLOCK_FUNCTION check.
3481
3482 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
3483
3484         * printcmd.c (print_address_symbolic): Print negative offsets.
3485         (build_address_symbolic): Force signed arithmetic when computing
3486         offset.
3487
3488 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
3489
3490         PR/24474: Add a function to lookup static variables.
3491         * NEWS: Mention this new function.
3492         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
3493         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
3494         * python/python.c (python_GdbMethods): Add new function.
3495
3496 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
3497
3498         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
3499         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
3500         (objfpy_lookup_static_symbol): New function.
3501         (objfile_object_methods): Add new functions.
3502
3503 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3504
3505         * NEWS: Mention 'set|show print frame-info'.  Mention new
3506         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
3507         backtrace argument.  Mention that python frame filtering code
3508         is now consistent with what 'backtrace' command prints.
3509
3510 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3511
3512         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
3513         comments.
3514         (print_frame_info_auto, print_frame_info_source_line,
3515         print_frame_info_location, print_frame_info_source_and_location,
3516         print_frame_info_location_and_address, print_frame_info_short_location):
3517         New declarations.
3518         (struct frame_print_options): New member print_frame_info.
3519         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
3520         * stack.h (get_user_print_what_frame_info): New declaration.
3521         (frame_show_address): New declaration.
3522         * stack.c (print_frame_arguments_choices): New value 'presence'.
3523         (print_frame_info_auto, print_frame_info_source_line,
3524         print_frame_info_location, print_frame_info_source_and_location,
3525         print_frame_info_location_and_address, print_frame_info_short_location,
3526         print_frame_info_choices, print_frame_info_print_what): New definitions.
3527         (print_frame_args): Only print dots for args if print frame-arguments
3528         is 'presence'.
3529         (frame_print_option_defs): New element for "frame-info".
3530         (get_user_print_what_frame_info): New function.
3531         (frame_show_address): Make non static.  Move comment to stack.h.
3532         (print_frame_info_to_print_what): New function.
3533         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
3534         to decide what to print.
3535         (backtrace_command_1): Handle the new print_frame_arguments_presence
3536         value.
3537         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
3538         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
3539         (py_print_frame): In non-mi mode, use LOCATION as default for
3540         print_what, similarly to frame information printed directly by
3541         backtrace command. Handle frame-info user option in non MI mode.
3542
3543 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
3544
3545         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
3546         Add case for debugging 32-bit target on 64-bit host.  Revise
3547         comment.
3548
3549 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
3550
3551         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
3552         instead of find_function_entry_range_from_pc.
3553
3554 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
3555
3556         * stack.c (find_frame_funname): Remove code which preferred
3557         minsym over symtab sym in "certain pathological cases".
3558
3559         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
3560         parameter.  Change type of "do_demangle" to bool.
3561         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
3562         Pass suitable "prefer_sym_over_minsym" flag to
3563         build_address_symbolic().  Don't output "+" for negative offsets.
3564         * printcmd.c (print_address_symbolic): Update invocation of
3565         build_address_symbolic to include a "prefer_sym_over_minsym"
3566         flag.
3567         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
3568         Restrict cases in which use of minimal symbol is preferred to that
3569         of a found symbol.  Update comments.
3570
3571         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
3572         for entry pc when entry pc is out of range for that FDE.
3573
3574 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
3575
3576         PR gdb/24839:
3577         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
3578         type.
3579
3580 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
3581
3582         * python/py-objfile.c (add_separate_debug_file): Fix comment about
3583         this function's Python signature.
3584
3585
3586 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
3587
3588         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
3589         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
3590         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
3591         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
3592         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
3593
3594
3595 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
3596
3597         * h8300-tdep.c (h8300_register_name_common): New.
3598         h8300_register_name): Use h8300_register_name_common.
3599         (h8300s_register_name): Likewise.
3600         (h8300sx_register_name): Likewise.
3601         (h8300h_register_nam): New.
3602         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
3603
3604
3605 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
3606
3607         * arm-tdep.c (arm_skip_cmse_entry): New function.
3608         (arm_is_sgstubs_section): New function.
3609         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
3610
3611 2019-07-22  Tom Tromey  <tom@tromey.com>
3612
3613         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
3614         Don't self-assign.
3615
3616 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
3617
3618         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
3619         type_print.
3620
3621 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
3622
3623         * symtab.c (search_symbols): Adjust msymbol matching type arrays
3624         so that GDB doesn't match any msymbols when searching in the
3625         TYPES_DOMAIN.
3626         (print_symbol_info): Print using typedef_print or type_print based
3627         on the type of the symbol.  Add updated FIXME comment moved from...
3628         (_initialize_symtab): ... move and update FIXME comment to above.
3629
3630 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
3631
3632         * NEWS: Mention adding -q option to "info types".
3633         * symtab.c (struct info_types_options): New struct.
3634         (info_types_options_defs): New variable.
3635         (make_info_types_options_def_group): New function.
3636         (info_types_command): Use gdb::option framework to parse options.
3637         (info_types_command_completer): New function.
3638         (_initialize_symtab): Extend the help text on "info types" and
3639         register command completer.
3640
3641 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
3642
3643         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
3644         (lookup_symbol_in_objfile): Change int to block_enum and add a
3645         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
3646
3647 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
3648
3649         * MAINTAINERS (Write After Approval): Add self.
3650
3651 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
3652
3653         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
3654         instruction to the dummy code region.
3655
3656 2019-07-19  Tom Tromey  <tromey@adacore.com>
3657
3658         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
3659         (ARGSUSED, PARAMS, __func__): Remove rules.
3660
3661 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
3662
3663         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
3664         * features/arm/arm-with-iwmmxt.c: Remove.
3665         * features/arm/arm-with-iwmmxt.xml: Remove.
3666         * features/arm/arm-with-m-fpa-layout.c: Remove.
3667         * features/arm/arm-with-m-fpa-layout.xml: Remove.
3668         * features/arm/arm-with-m-vfp-d16.c: Remove.
3669         * features/arm/arm-with-m-vfp-d16.xml: Remove.
3670         * features/arm/arm-with-m.c: Remove.
3671         * features/arm/arm-with-m.xml: Remove.
3672         * features/arm/arm-with-neon.c: Remove.
3673         * features/arm/arm-with-neon.xml: Remove.
3674         * features/arm/arm-with-vfpv2.c: Remove.
3675         * features/arm/arm-with-vfpv2.xml: Remove.
3676         * features/arm/arm-with-vfpv3.c: Remove.
3677         * features/arm/arm-with-vfpv3.xml: Remove.
3678
3679 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
3680
3681         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
3682
3683 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
3684
3685         * arch/aarch32.c (aarch32_create_target_description): Create
3686         target descriptions using features.
3687         * arch/arm.c (arm_create_target_description)
3688         (arm_create_mprofile_target_description): Likewise.
3689         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
3690
3691 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
3692
3693         * Makefile.in: Add new files.
3694         * aarch32-tdep.c: New file.
3695         * aarch32-tdep.h: New file.
3696         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
3697         Call aarch32_read_description.
3698         * arch/aarch32.c: New file.
3699         * arch/aarch32.h: New file.
3700         * arch/arm.c (arm_create_target_description)
3701         (arm_create_mprofile_target_description): New function.
3702         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
3703         (arm_create_target_description)
3704         (arm_create_mprofile_target_description): New declaration.
3705         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
3706         read_description functions.
3707         * arm-linux-nat.c (arm_linux_nat_target::read_description):
3708         Likewise.
3709         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
3710         * arm-tdep.c (tdesc_arm_list): New variable.
3711         (arm_register_g_packet_guesses): Call create description functions.
3712         (arm_read_description) (arm_read_mprofile_description): New
3713         function.
3714         * arm-tdep.h (arm_read_description)
3715         (arm_read_mprofile_description): Add declaration.
3716         * configure.tgt: Add new files.
3717
3718 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
3719
3720         * top.c (new_ui_command): Open specified terminal just once.
3721
3722 2019-07-18  Tom Tromey  <tromey@adacore.com>
3723
3724         * symtab.c (main_name): Constify return type.
3725         * symfile.c (set_initial_language): Update.
3726         * symtab.h (main_name): Constify return type.
3727
3728 2019-07-17  Tom Tromey  <tom@tromey.com>
3729
3730         * tui/tui-winsource.c (tui_update_source_window)
3731         (tui_update_source_window_as_is)
3732         (tui_update_source_windows_with_line): Remove return.
3733         * tui/tui-disasm.c (tui_show_disassem)
3734         (tui_show_disassem_and_update_source): Remove return.
3735         * tui/tui.c (tui_reset): Remove return.
3736         * tui/tui-wingeneral.c
3737         (tui_check_and_display_highlight_if_needed): Remove return.
3738
3739 2019-07-17  Tom Tromey  <tom@tromey.com>
3740
3741         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
3742
3743 2019-07-17  Tom Tromey  <tom@tromey.com>
3744
3745         * tui/tui-winsource.h (struct tui_exec_info_window)
3746         (struct tui_source_window_base): Move from tui-data.h.
3747         * tui/tui-winsource.c: Move many method definitions from
3748         elsewhere.  Remove "structuring" comments.
3749         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
3750         (tui_source_window_base::refresh_window): Move to
3751         tui-winsource.c.
3752         * tui/tui-win.c (tui_source_window_base::refresh_all)
3753         (tui_source_window_base::update_tab_width)
3754         (tui_source_window_base::set_new_height)
3755         (tui_source_window_base::do_make_visible_with_new_height): Move to
3756         tui-winsource.c.
3757         * tui/tui-source.h: Update.
3758         * tui/tui-source.c (tui_source_window_base::reset): Move to
3759         tui-winsource.c.
3760         * tui/tui-disasm.h: Update.
3761         * tui/tui-data.h (struct tui_exec_info_window): Move to
3762         tui-winsource.h.
3763         (struct tui_source_window_base): Likewise.
3764         * tui/tui-data.c (tui_source_window_base::clear_detail)
3765         (tui_source_window_base, ~tui_source_window_base): Move to
3766         tui-winsource.c.
3767
3768 2019-07-17  Tom Tromey  <tom@tromey.com>
3769
3770         * tui/tui-win.c (tui_resize_all)
3771         (tui_source_window_base::update_tab_width)
3772         (tui_adjust_win_heights): Update.
3773         (tui_win_info::make_invisible_and_set_new_height): Rename from
3774         make_invisible_and_set_new_height.
3775         * tui/tui-data.h (struct tui_win_info)
3776         <make_invisible_and_set_new_height>: New method.
3777
3778 2019-07-17  Tom Tromey  <tom@tromey.com>
3779
3780         * tui/tui.c: Update.
3781         * tui/tui-source.h (struct tui_source_window): Move from
3782         tui-data.h.
3783         * tui/tui-layout.c: Update.
3784         * tui/tui-disasm.c: Update.
3785         * tui/tui-data.h (struct tui_source_window): Move to
3786         tui-source.h.
3787
3788 2019-07-17  Tom Tromey  <tom@tromey.com>
3789
3790         * tui/tui-disasm.h (struct tui_disasm_window): Move from
3791         tui-data.h.
3792         * tui/tui-data.h (struct tui_disasm_window): Move to
3793         tui-disasm.h.
3794
3795 2019-07-17  Tom Tromey  <tom@tromey.com>
3796
3797         * tui/tui-regs.h (struct tui_data_item_window): Move from
3798         tui-data.h.
3799         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
3800         * tui/tui-data.h (struct tui_data_item_window): Move to
3801         tui-regs.h.
3802         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
3803
3804 2019-07-17  Tom Tromey  <tom@tromey.com>
3805
3806         * tui/tui.c: Update.
3807         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
3808         (tui_cmd_window::max_height): Move to tui-command.c.
3809         * tui/tui-layout.c: Update.
3810         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
3811         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
3812         tui-command.c.
3813         * tui/tui-command.h (struct tui_cmd_window): Move from
3814         tui-data.h.
3815         * tui/tui-command.c: Remove "structuring" comments.
3816         (tui_cmd_window::clear_detail)
3817         (tui_cmd_window::do_make_visible_with_new_height)
3818         (tui_cmd_window::max_height): Move from elsewhere.
3819
3820 2019-07-17  Tom Tromey  <tom@tromey.com>
3821
3822         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
3823         Now static.
3824         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
3825         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
3826
3827 2019-07-17  Tom Tromey  <tom@tromey.com>
3828
3829         * tui/tui.c: Update.
3830         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
3831         tui-regs.c.
3832         * tui/tui-windata.h: Remove file.
3833         * tui/tui-windata.c: Remove file.
3834         * tui/tui-win.c (tui_data_window::set_new_height)
3835         (tui_data_window::do_make_visible_with_new_height): Move to
3836         tui-regs.c.
3837         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
3838         * tui/tui-regs.c: Remove "structuring" comments.
3839         (tui_data_window::first_data_item_displayed)
3840         (tui_data_window::delete_data_content_windows)
3841         (tui_data_window::erase_data_content)
3842         (tui_data_window::display_all_data)
3843         (tui_data_window::refresh_all)
3844         (tui_data_window::do_scroll_vertical)
3845         (tui_data_window::clear_detail, tui_data_window::set_new_height)
3846         (tui_data_window::do_make_visible_with_new_height)
3847         (tui_data_window::refresh_window): Move from elsewhere.
3848         (_initialize_tui_regs): Move to end of file.
3849         * tui/tui-layout.c: Update.
3850         * tui/tui-hooks.c: Update.
3851         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
3852         * tui/tui-data.c (tui_data_window::clear_detail): Move to
3853         tui-regs.c.
3854         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
3855
3856 2019-07-17  Tom Tromey  <tom@tromey.com>
3857
3858         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
3859         seen.
3860
3861 2019-07-17  Tom Tromey  <tom@tromey.com>
3862
3863         * tui/tui-win.c (tui_source_window_base::set_new_height)
3864         (tui_source_window_base::do_make_visible_with_new_height): Use
3865         m_has_locator field directly.
3866         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
3867         method.
3868         (struct tui_source_window_base) <has_locator>: Likewise.
3869
3870 2019-07-17  Tom Tromey  <tom@tromey.com>
3871
3872         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
3873         Don't declare.
3874         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
3875         Remove.
3876         * tui/tui-win.c (tui_source_window_base::set_new_height)
3877         (tui_source_window_base::set_new_height)
3878         (make_invisible_and_set_new_height)
3879         (tui_source_window_base::do_make_visible_with_new_height)
3880         (tui_source_window_base::do_make_visible_with_new_height):
3881         Update.
3882         * tui/tui-layout.c (show_source_disasm_command, show_data)
3883         (show_source_or_disasm_and_command): Update.
3884         * tui/tui-layout.c (show_layout): Update.
3885
3886 2019-07-17  Tom Tromey  <tom@tromey.com>
3887
3888         * tui/tui-layout.c (make_data_window): Remove.
3889         (show_data): Unify creation and re-initialization cases.
3890
3891 2019-07-17  Tom Tromey  <tom@tromey.com>
3892
3893         * tui/tui-layout.c (make_source_window, make_disasm_window):
3894         Remove.
3895         (show_data): Unify creation and re-initialization cases.
3896
3897 2019-07-17  Tom Tromey  <tom@tromey.com>
3898
3899         * tui/tui-layout.c (make_command_window): Remove.
3900         (show_source_disasm_command, show_source_or_disasm_and_command):
3901         Unify creation and re-initialization cases.
3902
3903 2019-07-17  Tom Tromey  <tom@tromey.com>
3904
3905         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
3906         creation and re-initialization cases.
3907
3908 2019-07-17  Tom Tromey  <tom@tromey.com>
3909
3910         * tui/tui-regs.c (tui_get_register): Return void.
3911
3912 2019-07-17  Tom Tromey  <tom@tromey.com>
3913
3914         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
3915         Simplify.
3916
3917 2019-07-17  Tom Tromey  <tom@tromey.com>
3918
3919         * tui/tui-layout.c (show_source_disasm_command): Simplify window
3920         resetting.
3921
3922 2019-07-17  Tom Tromey  <tom@tromey.com>
3923
3924         * tui/tui.h (tui_set_layout_by_name): Don't declare.
3925         * tui/tui-regs.c (tui_reg_layout): New function.
3926         (tui_show_registers, tui_reg_command): Use it.
3927         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
3928         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
3929         parameters.
3930         (tui_layout_command): Remove.
3931
3932 2019-07-17  Tom Tromey  <tom@tromey.com>
3933
3934         * tui/tui-layout.h (tui/tui-layout): Return void.
3935         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
3936
3937 2019-07-17  Tom Tromey  <tom@tromey.com>
3938
3939         * tui/tui-layout.c (show_source_disasm_command, show_data):
3940         Update.
3941         (reset_locator): Remove.
3942         (show_source_or_disasm_and_command): Update.
3943
3944 2019-07-17  Tom Tromey  <tom@tromey.com>
3945
3946         * tui/tui-source.c (tui_source_window_base::reset): Remove
3947         win_type parameter.
3948         * tui/tui-layout.c (make_command_window, make_source_window)
3949         (make_disasm_window, make_data_window)
3950         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
3951         (reset_locator, show_source_or_disasm_and_command): Update.
3952         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
3953         win_type parameter.
3954         (struct tui_source_window_base) <reset>: Likewise.
3955
3956 2019-07-17  Tom Tromey  <tom@tromey.com>
3957
3958         * tui/tui-layout.c (show_source_disasm_command): Use
3959         reset_locator.
3960         (reset_locator): New function.
3961         (init_and_make_win): Remove.
3962         (show_source_or_disasm_and_command): Use reset_locator.
3963
3964 2019-07-17  Tom Tromey  <tom@tromey.com>
3965
3966         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
3967         condition.
3968         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
3969         Remove condition.
3970         * tui/tui-source.c (tui_source_window_base::reset): New method.
3971         * tui/tui-layout.c (make_command_window): Don't call
3972         init_and_make_win.
3973         (make_source_window, make_disasm_window): Don't call
3974         make_source_or_disasm_window.
3975         (make_data_window): Don't call init_and_make_win.  Change calling
3976         convention.
3977         (show_source_disasm_command, show_data): Simplify.
3978         (make_source_or_disasm_window): Remove.
3979         (show_source_or_disasm_and_command): Simplify.
3980         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
3981         (struct tui_source_window_base) <reset>: Likewise.
3982         <execution_info>: Remove initializer.
3983         * tui/tui-data.c (tui_source_window_base): Initialize
3984         execution_info.
3985
3986 2019-07-17  Tom Tromey  <tom@tromey.com>
3987
3988         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
3989         variable.
3990
3991 2019-07-17  Tom Tromey  <tom@tromey.com>
3992
3993         * tui/tui.c (tui_rl_other_window): Update.
3994         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
3995         superclass method first.  Always iterate over regs_content.
3996         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
3997         method.
3998         * tui/tui-win.c (tui_set_focus_command): Update.
3999
4000 2019-07-17  Tom Tromey  <tom@tromey.com>
4001
4002         * tui/tui-win.c (tui_set_focus_command): Rename from
4003         tui_set_focus.  Call tui_enable.
4004         (tui_set_focus_command): Remove.
4005
4006 2019-07-17  Tom Tromey  <tom@tromey.com>
4007
4008         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
4009         refresh_window.
4010         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
4011         touchwin.
4012         (tui_data_window::refresh_window): Call refresh_window on data
4013         items.  Always call superclass refresh_window.
4014         (tui_win_info::refresh): Remove.
4015         (tui_source_window_base::refresh_window): Update.
4016         (tui_refresh_all): Update.
4017         * tui/tui-layout.c (show_source_disasm_command): Remove call to
4018         refresh_window.
4019         (show_source_or_disasm_and_command): Likewise.
4020         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
4021         (struct tui_source_window_base) <refresh>: Likewise.
4022
4023 2019-07-17  Tom Tromey  <tom@tromey.com>
4024
4025         * tui/tui-winsource.c (tui_clear_source_content)
4026         (tui_show_source_content): Update.
4027         * tui/tui-source.c (tui_source_window::showing_source_p): Check
4028         whether content is empty.
4029         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
4030         Remove.
4031
4032 2019-07-17  Tom Tromey  <tom@tromey.com>
4033
4034         * tui/tui-winsource.c (tui_erase_source_content): Clear the
4035         window's contents.
4036         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
4037         * tui/tui-source.c (tui_set_source_content_nil): Remove.
4038
4039 2019-07-17  Tom Tromey  <tom@tromey.com>
4040
4041         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
4042         (struct tui_data_item_window): Update.
4043
4044 2019-07-17  Tom Tromey  <tom@tromey.com>
4045
4046         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
4047         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
4048         defines.
4049
4050 2019-07-17  Tom Tromey  <tom@tromey.com>
4051
4052         * tui/tui-winsource.h (tui_erase_source_content)
4053         (tui_clear_source_content): Remove "display_prompt" parameter.
4054         * tui/tui-winsource.c (tui_update_source_window_as_is)
4055         (tui_update_source_windows_with_addr): Update.
4056         (tui_clear_source_content): Remove "display_prompt" parameter.
4057         (tui_erase_source_content): Likewise.  Simplify.
4058         (tui_show_source_content): Update.
4059         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
4060         * tui/tui-stack.c (tui_show_frame_info): Update.
4061         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
4062         Remove defines.
4063
4064 2019-07-17  Tom Tromey  <tom@tromey.com>
4065
4066         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
4067         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
4068         parameter.
4069         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
4070         parameter.
4071
4072 2019-07-17  Tom Tromey  <tom@tromey.com>
4073
4074         * tui/tui-winsource.c (tui_clear_source_content)
4075         (tui_show_source_content, tui_show_exec_info_content)
4076         (tui_clear_exec_info_content): Update.
4077         * tui/tui-stack.c (tui_show_locator_content): Update.
4078         (tui_show_frame_info): Update.
4079         * tui/tui-source.h (tui_source_window): Don't declare.
4080         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
4081         from tui_source_is_displayed.
4082         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
4083         Remove field.
4084         (struct tui_source_window_base) <content_in_use>: New field.  Now
4085         bool.
4086         (struct tui_source_window) <showing_source_p>: New method.
4087         (TUI_SRC_WIN): Change cast.
4088         * tui/tui-data.c (tui_initialize_static_data): Update.
4089
4090 2019-07-17  Tom Tromey  <tom@tromey.com>
4091
4092         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
4093         location_matches_p.
4094         * tui/tui-source.c (tui_source_window::location_matches_p): New
4095         method.
4096         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
4097         method.
4098         * tui/tui-data.h (struct tui_source_window_base)
4099         <location_matches_p>: New method.
4100         (struct tui_source_window, struct tui_disasm_window)
4101         <location_matches_p>: Likewise.
4102
4103 2019-07-17  Tom Tromey  <tom@tromey.com>
4104
4105         * tui/tui-win.c (tui_set_win_height_command): Rename from
4106         tui_set_win_height.
4107         (tui_set_win_height_command): Remove.
4108
4109 2019-07-17  Tom Tromey  <tom@tromey.com>
4110
4111         * tui/tui-source.c (tui_source_window): New constructor.  Add
4112         observer.
4113         (~tui_source_window): New destructor.
4114         (tui_source_window::style_changed): New method.
4115         * tui/tui-hooks.c (tui_redisplay_source): Remove.
4116         (tui_attach_detach_observers): Update.
4117         * tui/tui-data.h (struct tui_source_window): Make constructor not
4118         inline.  Add destructor.
4119         (struct tui_source_window) <style_changed>: New method.
4120         <m_observable>: New member.
4121
4122 2019-07-17  Tom Tromey  <tom@tromey.com>
4123
4124         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
4125         * tui/tui-win.c (tui_resize_all): Fix typo.
4126
4127 2019-07-17  Tom Tromey  <tom@tromey.com>
4128
4129         * tui/tui-wingeneral.h (tui_refresh_all): Update.
4130         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
4131         (tui_refresh_all): Remove "list" parameter.  Use foreach.
4132         * tui/tui-win.c (window_name_completer): Use foreach.
4133         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
4134         (update_tab_width): Likewise.
4135         * tui/tui-layout.c (show_layout): Update.
4136         * tui/tui-data.h (class tui_window_iterator): New.
4137         (struct all_tui_windows): New.
4138         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
4139
4140 2019-07-17  Tom Tromey  <tom@tromey.com>
4141
4142         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
4143         parameter.  Don't reference globals.
4144         (tui_reg_command): Update.
4145
4146 2019-07-17  Tom Tromey  <tom@tromey.com>
4147
4148         * tui/tui-regs.c (tui_show_registers): Simplify.
4149
4150 2019-07-17  Tom Tromey  <tom@tromey.com>
4151
4152         * tui/tui-regs.c (tui_show_registers): Update.
4153         (tui_show_register_group): Add win_info parameter.
4154
4155 2019-07-17  Tom Tromey  <tom@tromey.com>
4156
4157         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
4158         Rename from tui_display_reg_element_at_line.
4159         (tui_data_window::display_registers_from_line): Update.
4160         * tui/tui-data.h (struct tui_data_window)
4161         <display_reg_element_at_line>: New method.
4162
4163 2019-07-17  Tom Tromey  <tom@tromey.com>
4164
4165         * tui/tui-regs.h (tui_display_registers_from)
4166         (tui_display_registers_from_line): Don't declare.
4167         * tui/tui-windata.c (tui_data_window::display_all_data)
4168         (tui_data_window::refresh_all)
4169         (tui_data_window::do_scroll_vertical): Update.
4170         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
4171         from tui_display_registers_from.
4172         (tui_display_reg_element_at_line): Update.
4173         (tui_data_window::display_registers_from_line): Rename from
4174         tui_display_registers_from_line.
4175         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
4176         display_registers_from_line>: New methods.
4177
4178 2019-07-17  Tom Tromey  <tom@tromey.com>
4179
4180         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
4181         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
4182         from tui_erase_data_content.
4183         (tui_data_window::display_all_data)
4184         (tui_data_window::refresh_all)
4185         (tui_data_window::do_scroll_vertical): Update.
4186         * tui/tui-regs.c (tui_show_registers): Update.
4187         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
4188         New method.
4189
4190 2019-07-17  Tom Tromey  <tom@tromey.com>
4191
4192         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
4193         declare.
4194         * tui/tui-windata.c
4195         (tui_data_window::delete_data_content_windows): Rename from
4196         tui_delete_data_content_windows.
4197         (tui_data_window::display_all_data)
4198         (tui_data_window::do_scroll_vertical): Update.
4199         * tui/tui-data.h (struct tui_data_window)
4200         <delete_data_content_windows>: New method.
4201
4202 2019-07-17  Tom Tromey  <tom@tromey.com>
4203
4204         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
4205         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
4206
4207 2019-07-17  Tom Tromey  <tom@tromey.com>
4208
4209         * tui/tui-windata.h (tui_display_all_data): Don't declare.
4210         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
4211         from tui_display_all_data.
4212         * tui/tui-win.c
4213         (tui_data_window::do_make_visible_with_new_height): Update.
4214         * tui/tui-regs.c (tui_show_registers): Update.
4215         * tui/tui-layout.c (tui_set_layout): Update.
4216         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
4217         method.
4218
4219 2019-07-17  Tom Tromey  <tom@tromey.com>
4220
4221         * tui/tui-windata.h (tui_display_data_from): Don't declare.
4222         * tui/tui-windata.c (tui_display_data_from): Remove.
4223         (tui_data_window::refresh_all): Update.
4224
4225 2019-07-17  Tom Tromey  <tom@tromey.com>
4226
4227         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
4228         * tui/tui-windata.c (tui_display_data_from_line): Remove.
4229         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
4230         tui_display_registers_from_line.
4231         * tui/tui-regs.h (tui_display_registers_from_line): Update.
4232         * tui/tui-regs.c (tui_display_registers_from_line): Remove
4233         "force_display" parameter.
4234
4235 2019-07-17  Tom Tromey  <tom@tromey.com>
4236
4237         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
4238         declare.
4239         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
4240         Rename from tui_first_reg_element_no_inline.
4241         (tui_display_reg_element_at_line)
4242         (tui_display_registers_from_line): Update.
4243         * tui/tui-data.h (struct tui_data_window)
4244         <first_reg_element_no_inline>: New method.
4245
4246 2019-07-17  Tom Tromey  <tom@tromey.com>
4247
4248         * tui/tui-windata.c (tui_display_data_from)
4249         (tui_data_window::do_scroll_vertical): Update.
4250         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
4251         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
4252         Rename from tui_line_from_reg_element_no.
4253         (tui_display_registers_from_line): Update.
4254         * tui/tui-data.h (struct tui_data_window)
4255         <line_from_reg_element_no>: New method.
4256
4257 2019-07-17  Tom Tromey  <tom@tromey.com>
4258
4259         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
4260         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
4261         tui_last_regs_line_no.
4262         (tui_display_reg_element_at_line)
4263         (tui_display_registers_from_line): Update.
4264         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
4265         method.
4266
4267 2019-07-17  Tom Tromey  <tom@tromey.com>
4268
4269         PR tui/24722:
4270         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
4271         (tui_update_breakpoint_info): Add "being_deleted" parameter.
4272         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
4273         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
4274         (tui_update_breakpoint_info): Likewise.
4275         * tui/tui-hooks.c (tui_event_create_breakpoint)
4276         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
4277         Update.
4278
4279 2019-07-17  Tom Tromey  <tom@tromey.com>
4280
4281         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
4282
4283 2019-07-17  Tom Tromey  <tom@tromey.com>
4284
4285         * tui/tui-winsource.c (tui_update_source_window_as_is)
4286         (tui_update_source_windows_with_addr): Update.
4287         * tui/tui-source.h (tui_set_source_content)
4288         (tui_show_symtab_source): Add "win_info" parameter.
4289         * tui/tui-source.c (tui_set_source_content): Add "win_info"
4290         parameter.
4291         (tui_show_symtab_source): Likewise.
4292
4293 2019-07-17  Tom Tromey  <tom@tromey.com>
4294
4295         * tui/tui-wingeneral.c
4296         (tui_check_and_display_highlight_if_needed): Check can_highlight.
4297
4298 2019-07-17  Tom Tromey  <tom@tromey.com>
4299
4300         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
4301         (struct tui_cmd_window) <can_scroll>: New method.
4302         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
4303         method.
4304
4305 2019-07-17  Tom Tromey  <tromey@adacore.com>
4306
4307         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
4308         do_field_signed>: Rename.  Change type of "value".
4309         * ui-out.c (ui_out::field_signed): Rename from field_int.
4310         Change type of "value".
4311         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
4312         type of "value".
4313         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
4314         do_field_int.  Change type of "value".
4315         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
4316         do_field_int.  Change type of "value".
4317         * tracepoint.c (trace_status_mi, tfind_1)
4318         (print_one_static_tracepoint_marker): Update.
4319         * thread.c (print_thread_info_1, print_selected_thread_frame):
4320         Update.
4321         * stack.c (print_frame, print_frame_info): Update.
4322         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
4323         Update.
4324         * source.c (print_source_lines_base): Update.
4325         * skip.c (info_skip_command): Update.
4326         * record-btrace.c (btrace_ui_out_decode_error)
4327         (btrace_call_history_src_line): Update.
4328         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
4329         Update.
4330         * progspace.c (print_program_space): Update.
4331         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
4332         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
4333         do_field_int.  Change type of "value".
4334         * mi/mi-out.c (mi_ui_out::do_table_begin)
4335         (mi_ui_out::do_table_header): Update.
4336         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
4337         type of "value".
4338         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
4339         (mi_cmd_data_list_changed_registers, output_register)
4340         (mi_cmd_data_read_memory, mi_load_progress)
4341         (mi_cmd_trace_frame_collected): Update.
4342         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
4343         Update.
4344         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
4345         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
4346         (mi_cmd_var_list_children, varobj_update_one): Update.
4347         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
4348         (mi_cmd_stack_list_args, list_arg_or_local): Update.
4349         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
4350         * inferior.c (print_inferior): Update.
4351         * gdb_bfd.c (print_one_bfd): Update.
4352         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
4353         Update.
4354         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
4355         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
4356         do_field_int.  Change type of "value".
4357         * cli-out.c (cli_ui_out::do_field_signed): Rename from
4358         do_field_int.  Change type of "value".
4359         * breakpoint.c (watchpoint_check, print_breakpoint_location)
4360         (print_one_breakpoint_location, print_it_catch_fork)
4361         (print_one_catch_fork, print_it_catch_vfork)
4362         (print_one_catch_vfork, print_it_catch_solib)
4363         (print_it_catch_exec, print_it_ranged_breakpoint)
4364         (print_mention_watchpoint, print_mention_masked_watchpoint)
4365         (bkpt_print_it, update_static_tracepoint): Update.
4366         * break-catch-throw.c (print_it_exception_catchpoint): Update.
4367         * break-catch-syscall.c (print_it_catch_syscall): Update.
4368         * ada-tasks.c (print_ada_task_info): Update.
4369         * ada-lang.c (print_it_exception, print_mention_exception):
4370         Update.
4371
4372 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
4373
4374         PR breakpoints/24541
4375         * gdbarch.c: Regenerate.
4376         * gdbarch.h: Regenerate.
4377         * gdbarch.sh: Adjust return type and parameter types for
4378         'stap_adjust_register'.
4379         (i386_stap_adjust_register): Adjust signature and return new
4380         register name.
4381         * stap-probe.c (stap_parse_register_operand): Adjust use of
4382         'gdbarch_stap_adjust_register'.
4383
4384 2019-07-17  Tom Tromey  <tromey@adacore.com>
4385
4386         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
4387         declare VEC.
4388         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
4389         std::vector.
4390         (struct s390_process_info): Add initializers.
4391         (s390_add_process): Use new.
4392         (s390_linux_nat_target::low_forget_process): Use delete.
4393         (s390_linux_nat_target::low_new_fork)
4394         (s390_linux_nat_target::stopped_by_watchpoint)
4395         (s390_linux_nat_target::low_prepare_to_resume)
4396         (s390_linux_nat_target::insert_watchpoint)
4397         (s390_linux_nat_target::insert_hw_breakpoint)
4398         (s390_linux_nat_target::remove_watchpoint)
4399         (s390_linux_nat_target::remove_hw_breakpoint): Update.
4400
4401 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
4402
4403         * aarch64-fbsd-nat.c: Include regcache.h.
4404         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
4405         argument.
4406         (aarch64_fbsd_nat_target::fetch_registers)
4407         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
4408         variable.
4409         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
4410
4411 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
4412
4413         * fbsd-nat.c: Include gdbarch.h.
4414
4415 2019-07-15  Tom Tromey  <tromey@adacore.com>
4416
4417         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
4418
4419 2019-07-15  Tom Tromey  <tromey@adacore.com>
4420
4421         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
4422         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
4423         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
4424         * cli-out.c (cli_ui_out::do_field_int): New method.
4425         * ui-out.c (ui_out::field_unsigned): New method.
4426         * symfile.c (generic_load): Use field_unsigned.
4427         (print_transfer_performance): Likewise.
4428         * record-btrace.c (ui_out_field_uint): Remove.
4429         (btrace_call_history_insn_range, btrace_call_history): Use
4430         field_unsigned.
4431         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
4432         field_unsigned.
4433         * ui-out.h (class ui_out) <field_unsigned>: New method.
4434         <do_field_unsigned>: Likewise.
4435
4436 2019-07-15  Tom Tromey  <tromey@adacore.com>
4437
4438         * mi/mi-main.c (list_available_thread_groups): Use field_string.
4439         * mi/mi-interp.c (mi_memory_changed): Use field_string.
4440         * target.c (flash_erase_command): Use field_string.
4441         * infrun.c (print_signal_received_reason): Use field_string.
4442         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
4443         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
4444         field_string.
4445         * ada-tasks.c (print_ada_task_info): Use field_string.
4446
4447 2019-07-15  Tom Tromey  <tromey@adacore.com>
4448
4449         * target.c (flash_erase_command): Use field_core_addr.
4450         * symfile.c (generic_load): Use field_core_addr.
4451         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
4452         Use field_core_addr.
4453         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
4454         field_core_addr.
4455
4456 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4457
4458         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
4459         value if its desired type is smaller than a CORE_ADDR and signed.
4460
4461 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4462
4463         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
4464         of changes to field names, and use new is_reference field to
4465         decide if a property is a reference or not.
4466         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
4467         field.
4468         (struct dwarf2_property_baton): Update header comment, rename
4469         'referenced_type' to 'property_type' and update comments.
4470         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
4471         default property type, store in property baton, update to take
4472         accound of renamed field.
4473         (read_func_scope): Update call to attr_to_dynamic_prop.
4474         (read_array_type): Likewise.
4475         (dwarf2_per_cu_addr_sized_int_type): New function.
4476         (read_subrange_index_type): Move type finding code to
4477         dwarf2_per_cu_addr_sized_int_type.
4478         (read_subrange_type): Update calls to attr_to_dynamic_prop.
4479         (dwarf2_per_cu_addr_type): New function.
4480         (set_die_type): Update calls to attr_to_dynamic_prop.
4481
4482 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4483
4484         * dwarf2read.c (read_subrange_index_type): New function.
4485         (read_subrange_type): Move code into new function and call it.
4486         * gdbtypes.c (create_range_type): Add some asserts.
4487
4488 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4489
4490         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
4491         update return statements.
4492         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
4493         declaration, and update comment to match.
4494         * gdbtypes.c (resolve_dynamic_array): Update call to
4495         dwarf2_evaluate_property to match new return type.
4496
4497 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4498
4499         * valarith.c (value_subscripted_rvalue): Change lowerbound
4500         parameter type from int to LONGEST.
4501         * value.h (value_subscripted_rvalue): Likewise in declaration.
4502
4503 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4504
4505         * cli/cli-utils.c (info_print_command_completer): New function.
4506         * cli/cli-utils.h: Add 'completer.h' include, and forward
4507         declaration for 'struct cmd_list_element'.
4508         (info_print_command_completer): Declare.
4509         * stack.c (_initialize_stack): Add completer for 'info locals' and
4510         'info args'.
4511         * symtab.c (_initialize_symtab): Add completer for 'info
4512         variables' and 'info functions'.
4513         * NEWS: Mention completion for additional info commands.
4514
4515 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4516
4517         * cli/cli-utils.c (extract_info_print_args): Delete.
4518         (extract_arg_maybe_quoted): Delete.
4519         (info_print_options_defs): New variable.
4520         (make_info_print_options_def_group): New function.
4521         (extract_info_print_options): Define new function.
4522         * cli/cli-utils.h (extract_info_print_args): Delete.
4523         (struct info_print_options): New structure.
4524         (extract_info_print_options): Declare new function.
4525         * stack.c (info_locals_command): Update to use new
4526         extract_info_print_options, also add a header comment.
4527         (info_args_command): Likewise.
4528         * symtab.c (info_variables_command): Likewise.
4529         (info_functions_command): Likewise.
4530
4531 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4532
4533         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
4534         to extract string arguments.
4535         * common/common-utils.c (extract_string_maybe_quoted): New function.
4536         * common/common-utils.h (extract_string_maybe_quoted): Declare.
4537
4538 2019-07-11  Tom Tromey  <tromey@adacore.com>
4539
4540         * main.c (get_init_files): Use GDBINIT, not gdbinit.
4541         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
4542         * top.h (gdbinit): Don't declare.
4543         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
4544         into...
4545         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
4546         * top.c (gdb_init): Don't call init_cli_cmds.
4547         (gdbinit): Remove.
4548         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
4549
4550 2019-07-11  Tom Tromey  <tromey@adacore.com>
4551
4552         * python/py-inferior.c (add_thread_object): Don't use thread_obj
4553         after it has been moved.
4554
4555 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
4556
4557         * valops.c (value_must_coerce_to_target): Change return type to
4558         bool.
4559         * value.h (value_must_coerce_to_target): Likewise.
4560
4561 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
4562
4563         * breakpoint.c (is_hardware_watchpoint): Remove
4564         forward-declaration.
4565         (is_masked_watchpoint): Change return type to bool.
4566         (is_tracepoint): Likewise.
4567         (is_breakpoint): Likewise.
4568         (is_hardware_watchpoint): Likewise.
4569         (is_watchpoint): Likewise.
4570         (is_no_memory_software_watchpoint): Likewise.
4571         (is_catchpoint): Likewise.
4572         (breakpoint_1): Make FILTER parameter's return type bool.
4573         is_masked_watchpoint): Change return type to bool.
4574         (save_breakpoints): Make FILTER parameter's return type bool.
4575         * breakpoint.h (is_breakpoint): Change return type to bool.
4576         (is_watchpoint): Likewise.
4577         (is_catchpoint): Likewise.
4578         (is_tracepoint): Likewise.
4579
4580 2019-07-10  Tom Tromey  <tom@tromey.com>
4581
4582         * defs.h: Don't include gdbarch.h.
4583         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
4584         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
4585         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
4586         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
4587         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
4588         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
4589         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
4590         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
4591         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
4592         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
4593         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
4594         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
4595         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
4596         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
4597         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
4598         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
4599         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
4600         record-btrace.c, record.h, regcache-dump.c, regcache.h,
4601         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
4602         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
4603         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
4604         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
4605         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
4606         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
4607         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
4608         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
4609         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
4610
4611 2019-07-10  Tom Tromey  <tromey@adacore.com>
4612
4613         * ada-lang.h (is_ada_exception_catchpoint): Declare.
4614         * breakpoint.c (init_ada_exception_breakpoint): Register as
4615         bp_catchpoint.
4616         (print_one_breakpoint_location, print_one_breakpoint): Use
4617         is_ada_exception_catchpoint.
4618         * ada-lang.c (class ada_catchpoint_location): Pass
4619         bp_loc_software_breakpoint to bp_location constructor.
4620         (is_ada_exception_catchpoint): New function.
4621
4622 2019-07-10  Tom Tromey  <tromey@adacore.com>
4623
4624         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
4625         VEC.
4626         (struct arm_exidx_entry): New method operator<.
4627         (struct arm_exidx_data) <section_maps>: Change type.
4628         (arm_exidx_data_free): Remove.
4629         (arm_exidx_data_key): Change type.  Move lower.
4630         (arm_exidx_new_objfile): Update.
4631         (arm_compare_exidx_entries): Remove.
4632         (arm_find_exidx_entry, _initialize_arm_tdep)
4633
4634 2019-07-10  Tom Tromey  <tromey@adacore.com>
4635
4636         * solib-spu.c (ocl_program_data_key): Change type.
4637         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
4638         Update.
4639
4640 2019-07-10  Tom Tromey  <tromey@adacore.com>
4641
4642         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
4643         (struct solib_aix_inferior_data) <library_list>: Change type.
4644         (solib_aix_inferior_data_handle): Change type.
4645         (get_solib_aix_inferior_data): Update.
4646         (solib_aix_free_library_list): Remove.
4647         (library_list_start_library): Update.
4648         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
4649         return type.
4650         (solib_aix_get_library_list)
4651         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
4652         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
4653
4654 2019-07-10  Tom Tromey  <tromey@adacore.com>
4655
4656         * solib-dsbt.c (struct dsbt_info): Add initializers.
4657         (solib_dsbt_pspace_data): Change type.
4658         (dsbt_pspace_data_cleanup): Remove.
4659         (get_dsbt_info, _initialize_dsbt_solib): Update.
4660
4661 2019-07-10  Tom Tromey  <tromey@adacore.com>
4662
4663         * spu-tdep.c (spu_overlay_data): Change type.
4664         (spu_get_overlay_table, spu_overlay_new_objfile)
4665         (_initialize_spu_tdep): Update.
4666
4667 2019-07-10  Tom Tromey  <tromey@adacore.com>
4668
4669         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
4670         destructor.
4671         (dbx_objfile_data_key): Change type and declare later.
4672         (DBX_SYMFILE_INFO): Rewrite.
4673         * dbxread.c (dbx_objfile_data_key): Change type.
4674         (dbx_symfile_init): Update.
4675         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
4676         (coffstab_build_psymtabs, elfstab_build_psymtabs)
4677         (stabsect_build_psymtabs, _initialize_dbxread): Update.
4678
4679 2019-07-10  Tom Tromey  <tromey@adacore.com>
4680
4681         * jit.c (jit_program_space_key): Change type.  Move lower.
4682         (get_jit_program_space_data): Update.
4683         (jit_program_space_data_cleanup): Remove.
4684         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
4685         Update.
4686         (struct jit_program_space_data): Add initializers.
4687
4688 2019-07-10  Tom Tromey  <tromey@adacore.com>
4689
4690         * solib-darwin.c (struct darwin_info): Add initializers.
4691         (solib_darwin_pspace_data): Change type.
4692         (darwin_pspace_data_cleanup): Remove.
4693         (get_darwin_info, _initialize_darwin_solib): Update.
4694
4695 2019-07-10  Tom Tromey  <tromey@adacore.com>
4696
4697         * remote-sim.c (struct sim_inferior_data): Add initializers,
4698         constructor, and destructor.
4699         (sim_inferior_data_key): Change type.  Move lower.
4700         (check_for_duplicate_sim_descriptor): Update.
4701         (get_sim_inferior_data): Use new.  Update.
4702         (~sim_inferior_data_cleanup): Rename from
4703         sim_inferior_data_cleanup.  Simplify.
4704         (gdbsim_close_inferior, simulator_command)
4705         (sim_command_completer, _initialize_remote_sim): Update.
4706         (next_pid, INITIAL_PID): Move earlier.
4707
4708 2019-07-10  Tom Tromey  <tromey@adacore.com>
4709
4710         * python/python-internal.h (create_thread_object): Return
4711         gdbpy_ref.
4712         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
4713         * python/py-inferior.c (struct threadlist_entry): Add
4714         constructor.
4715         <thread_obj>: Now a gdbpy_ref.
4716         (thread_to_thread_object): Update.
4717         (add_thread_object): Use new.
4718         (delete_thread_object): Use delete.
4719         (infpy_threads): Update.
4720         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
4721         GIL.
4722
4723 2019-07-10  Tom Tromey  <tromey@adacore.com>
4724
4725         * valops.c (value_cast): Specialize error message for Ada.
4726
4727 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
4728
4729         * breakpoint.c (breakpoint_1): Update doc and parameter names.
4730
4731 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
4732
4733         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
4734         bpstat_should_step): Return bool, adjust comments.
4735         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
4736         bpstat_should_step): Likewise.
4737
4738 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
4739
4740         * features/Makefile: Use feature target descriptions for Arm.
4741         * features/arm/arm-core.c: Generate new file.
4742         * features/arm/arm-fpa.c: Likewise.
4743         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
4744         * features/arm/arm-m-profile.c: Likewise.
4745         * features/arm/arm-vfpv2.c: Likewise.
4746         * features/arm/arm-vfpv3.c: Likewise.
4747         * features/arm/xscale-iwmmxt.c: Likewise.
4748         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
4749
4750 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
4751
4752         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
4753         ptrace earlier.
4754
4755 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
4756
4757         * features/aarch64-pauth.c: Regenerate.
4758
4759 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
4760
4761         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
4762         bool.
4763         (bpstat_what): Use false instead of 0.
4764
4765 2019-07-09  Pedro Alves  <palves@redhat.com>
4766
4767         * break-catch-throw.c (is_exception_catchpoint): New.
4768         * breakpoint.c (print_one_breakpoint_location): New parameter
4769         'raw_loc'.  Handle it.  Use
4770         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
4771         looking at the breakpoint's type.
4772         (print_one_breakpoint): If handling "maint info breakpoints", also
4773         print locations of exception catchpoints.
4774         * breakpoint.h (is_exception_catchpoint): Declare.
4775
4776 2019-07-09  Pedro Alves  <palves@redhat.com>
4777
4778         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
4779         "addr" field.
4780         (allocate_location_exception_catchpoint): New.
4781         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
4782         (initialize_throw_catchpoint_ops): Install
4783         allocate_location_exception_catchpoint as allocate_location
4784         method.
4785         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
4786         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
4787         bp_loc_other.
4788         (breakpoint_address_is_meaningful): Delete.
4789         (bl_address_is_meaningful): New.
4790         (breakpoint_locations_match): Adjust comment.
4791         (bp_location_from_bp_type): New, factored out of...
4792         (bp_location::bp_location(breakpoint *)): ... this.
4793         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
4794         factored out of...
4795         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
4796         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
4797         breakpoint_address_is_meaningful.
4798         (bp_locations_compare): Adjust comment.
4799         (update_global_location_list): Use bl_address_is_meaningful
4800         instead of breakpoint_address_is_meaningful.
4801         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
4802         explicit.
4803         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
4804         * python/py-breakpoint.c (bppy_get_location): No longer check
4805         whether location is null.
4806
4807 2019-07-09  Pedro Alves  <palves@redhat.com>
4808
4809         PR c++/15468
4810         * breakpoint.c (print_one_breakpoint_location): Remove
4811         single-location assert.
4812
4813 2019-07-09  Tom Tromey  <tom@tromey.com>
4814
4815         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
4816         * configure: Rebuild.
4817         * configure.ac: Change common to gdbsupport.
4818         * gdbsupport: Rename from common.
4819         * acinclude.m4: Change common to gdbsupport.
4820         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
4821         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
4822         gdbsupport.
4823         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
4824         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
4825         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
4826         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
4827         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
4828         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
4829         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
4830         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
4831         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
4832         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
4833         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
4834         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
4835         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
4836         coff-pe-read.c, command.h, compile/compile-c-support.c,
4837         compile/compile-c.h, compile/compile-cplus-symbols.c,
4838         compile/compile-cplus-types.c, compile/compile-cplus.h,
4839         compile/compile-loc2c.c, compile/compile.c, completer.c,
4840         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
4841         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
4842         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
4843         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
4844         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
4845         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
4846         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
4847         features/aarch64-core.c, features/aarch64-fpu.c,
4848         features/aarch64-pauth.c, features/aarch64-sve.c,
4849         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
4850         features/i386/32bit-core.c, features/i386/32bit-linux.c,
4851         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
4852         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
4853         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
4854         features/i386/64bit-core.c, features/i386/64bit-linux.c,
4855         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
4856         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
4857         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
4858         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
4859         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
4860         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
4861         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
4862         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
4863         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
4864         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
4865         go32-nat.c, guile/guile.c, guile/scm-ports.c,
4866         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
4867         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
4868         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
4869         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
4870         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
4871         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
4872         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
4873         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
4874         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
4875         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
4876         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
4877         minsyms.c, mips-linux-tdep.c, namespace.h,
4878         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
4879         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
4880         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
4881         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
4882         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
4883         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
4884         nat/linux-waitpid.c, nat/mips-linux-watch.c,
4885         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
4886         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
4887         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
4888         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
4889         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
4890         procfs.c, producer.c, progspace.h, psymtab.h,
4891         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
4892         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
4893         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
4894         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
4895         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
4896         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
4897         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
4898         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
4899         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
4900         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
4901         target-memory.c, target.c, target.h, target/waitstatus.c,
4902         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
4903         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
4904         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
4905         unittests/array-view-selftests.c,
4906         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
4907         unittests/common-utils-selftests.c,
4908         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
4909         unittests/format_pieces-selftests.c,
4910         unittests/function-view-selftests.c,
4911         unittests/lookup_name_info-selftests.c,
4912         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
4913         unittests/mkdir-recursive-selftests.c,
4914         unittests/observable-selftests.c,
4915         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
4916         unittests/parse-connection-spec-selftests.c,
4917         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
4918         unittests/scoped_fd-selftests.c,
4919         unittests/scoped_mmap-selftests.c,
4920         unittests/scoped_restore-selftests.c,
4921         unittests/string_view-selftests.c, unittests/style-selftests.c,
4922         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
4923         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
4924         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
4925         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
4926         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
4927         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
4928
4929 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
4930
4931         * linespec.c (decode_digits_list_mode): Set explicit_line to a
4932         bool value.
4933         (decode_digits_ordinary): Set explicit_line field in sal.
4934         * symtab.c (skip_prologue_sal): Don't skip prologue for a
4935         symtab_and_line that was set on an explicit line number in
4936         assembler code.  Do always update the recorded symtab and line if
4937         we do skip the prologue.
4938
4939 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
4940
4941         * breakpoint.c (set_breakpoint_location_function): Remove
4942         explicit_loc parameter.
4943         (momentary_breakpoint_from_master): Update call to
4944         set_breakpoint_location_function.
4945         (add_location_to_breakpoint): Likewise.
4946
4947 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
4948
4949         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
4950         required features based on default bfd type when no specific bfd
4951         is present.
4952
4953 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4954
4955         * NEWS: Mention that GDB printf and eval commands can now print
4956         C-style and Ada-style convenience var strings without
4957         calling the inferior.
4958         * printcmd.c (printf_c_string): Locally print GDB internal var
4959         instead of transiting via the inferior.
4960         (printf_wide_c_string): Likewise.
4961
4962 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
4963
4964         PR breakpoints/25011
4965         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
4966
4967 2019-07-04  Tom Tromey  <tom@tromey.com>
4968
4969         PR tui/24724:
4970         * tui/tui-winsource.c (tui_clear_source_content): Update.
4971         (tui_source_window_base::set_is_exec_point_at): Fix comment.
4972         (tui_update_breakpoint_info): Update.
4973         (tui_set_exec_info_content): Update.
4974         * tui/tui-source.c (tui_set_source_content_nil): Update.
4975         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
4976         has_break.
4977         * tui/tui-data.h (enum tui_bp_flag): New.
4978         (tui_bp_flags): New enum flags type.
4979         (struct tui_source_element) <break_mode>: Change type.  Rename
4980         from has_break.
4981         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
4982         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
4983         constants.
4984         * tui/tui-winsource.h: Fix comment.
4985
4986 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
4987
4988         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
4989         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
4990         (store_fpregs_to_thread)
4991         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
4992         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
4993         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
4994         (IWMMXT_REGS_SIZE): Add define.
4995         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
4996         (fetch_vfp_regs, store_vfp_regs)
4997         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
4998         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
4999
5000 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5001
5002         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
5003         defines.
5004         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
5005         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
5006         (ARM_INT_REGISTER_SIZE): ...to this.
5007         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
5008         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
5009         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
5010         (arm_linux_collect_gregset, supply_nwfpe_register)
5011         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
5012         defines.
5013         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
5014         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
5015         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
5016         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
5017         (arm_return_in_memory, arm_store_return_value)
5018         (arm_get_longjmp_target, arm_register_g_packet_guesses)
5019         (arm_record_ld_st_multiple): Likewise.
5020         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
5021         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
5022
5023 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5024
5025         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
5026         AARCH64_DISPLACED_MODIFIED_INSNS.
5027         * aarch64-tdep.c (struct aarch64_displaced_step_data)
5028         (aarch64_displaced_step_copy_insn): Likewise.
5029         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
5030         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
5031         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
5032         ARM_DISPLACED_MODIFIED_INSNS.
5033         * arm-tdep.c (arm_gdbarch_init): Likewise.
5034         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
5035         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
5036         (struct arm_displaced_step_closure): Use
5037         ARM_DISPLACED_MODIFIED_INSNS.
5038
5039 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5040
5041         * features/Makefile: Remove unused xml files.
5042         * features/aarch64.xml: Remove.
5043         * features/i386/amd64-avx-avx512-linux.xml: Remove.
5044         * features/i386/amd64-avx-avx512.xml: Remove.
5045         * features/i386/amd64-avx-linux.xml: Remove.
5046         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
5047         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
5048         * features/i386/amd64-avx-mpx-linux.xml: Remove.
5049         * features/i386/amd64-avx-mpx.xml: Remove.
5050         * features/i386/amd64-avx.xml: Remove.
5051         * features/i386/amd64-linux.xml: Remove.
5052         * features/i386/amd64-mpx-linux.xml: Remove.
5053         * features/i386/amd64-mpx.xml: Remove.
5054         * features/i386/amd64.xml: Remove.
5055         * features/i386/i386-avx-avx512-linux.xml: Remove.
5056         * features/i386/i386-avx-avx512.xml: Remove.
5057         * features/i386/i386-avx-linux.xml: Remove.
5058         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
5059         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
5060         * features/i386/i386-avx-mpx-linux.xml: Remove.
5061         * features/i386/i386-avx-mpx.xml: Remove.
5062         * features/i386/i386-avx.xml: Remove.
5063         * features/i386/i386-linux.xml: Remove.
5064         * features/i386/i386-mmx-linux.xml: Remove.
5065         * features/i386/i386-mmx.xml: Remove.
5066         * features/i386/i386-mpx-linux.xml: Remove.
5067         * features/i386/i386-mpx.xml: Remove.
5068         * features/i386/i386.xml: Remove.
5069         * features/i386/x32-avx-avx512-linux.xml: Remove.
5070         * features/i386/x32-avx-linux.xml: Remove.
5071         * features/i386/x32-linux.xml: Remove.
5072
5073 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5074
5075         * regformats/aarch64.dat: Remove.
5076         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
5077         * regformats/i386/amd64-avx-linux.dat: Remove.
5078         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
5079         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
5080         * regformats/i386/amd64-linux.dat: Remove.
5081         * regformats/i386/amd64-mpx-linux.dat: Remove.
5082         * regformats/i386/amd64.dat: Remove.
5083         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
5084         * regformats/i386/i386-avx-linux.dat: Remove.
5085         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
5086         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
5087         * regformats/i386/i386-linux.dat: Remove.
5088         * regformats/i386/i386-mmx-linux.dat: Remove.
5089         * regformats/i386/i386-mpx-linux.dat: Remove.
5090         * regformats/i386/i386.dat: Remove.
5091         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
5092         * regformats/i386/x32-avx-linux.dat: Remove.
5093         * regformats/i386/x32-linux.dat: Remove.
5094
5095 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5096
5097         * aarch64-tdep.c: Remove xml self tests.
5098         * amd64-linux-tdep.c: Likewise.
5099         * amd64-tdep.c: Likewise.
5100         * i386-linux-tdep.c: Likewise.
5101         * i386-tdep.c: Likewise.
5102
5103 2019-07-03  Pedro Alves  <palves@redhat.com>
5104
5105         PR cli/24732
5106         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
5107         (pipe_cmd_option_defs): New.
5108         (make_pipe_cmd_options_def_group): New.
5109         (pipe_command): Use gdb::option::process_options.
5110         (pipe_command_completer): New function.
5111         (_initialize_cli_cmds): Install completer for "pipe" command.
5112
5113 2019-07-03  Pedro Alves  <palves@redhat.com>
5114
5115         * cli/cli-option.c (union option_value) <string>: New field.
5116         (struct option_def_and_value): Add ctor, move ctor, dtor and
5117         use DISABLE_COPY_AND_ASSIGN.
5118         (option_def_and_value::clear_value): New.
5119         (parse_option, save_option_value_in_ctx, get_val_type_str)
5120         (add_setshow_cmds_for_options): Handle var_string.
5121         * cli-option.h (union option_def::var_address) <string>: New
5122         field.
5123         (struct string_option_def): New.
5124         * maint-test-options.c (struct test_options_opts): Add default
5125         ctor and use DISABLE_COPY_AND_ASSIGN.
5126         <string_opt>: New field.
5127         (test_options_opts::~test_options_opts): New.
5128         (test_options_opts::dump): Also dump "-string".
5129         (test_options_option_defs): Install "string.
5130
5131 2019-07-03  Pedro Alves  <palves@redhat.com>
5132
5133         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
5134         option_value with a null enumeration.
5135         (complete_options): Save the option values in the context.
5136         (save_option_value_in_ctx): New, factored out from ...
5137         (process_options): ... here.
5138         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
5139         of the function.
5140         * maint-test-options.c (test_options_opts::dump): New, factored
5141         out from ...
5142         (maintenance_test_options_command_mode): ... here.
5143         (maintenance_test_options_command_completion_result): Delete.
5144         (maintenance_test_options_command_completion_text): Update
5145         comment.
5146         (maintenance_show_test_options_completion_result): Change
5147         prototype.  Just print
5148         maintenance_test_options_command_completion_text.
5149         (save_completion_result): New.
5150         (maintenance_test_options_completer_mode): Pass options context to
5151         complete_options, and then save a dump.
5152         (_initialize_maint_test_options): Use add_cmd to install "maint
5153         show test-options-completion-result".
5154
5155 2019-07-03  Pedro Alves  <palves@redhat.com>
5156
5157         * NEWS (New commands): Mention "with" and "maint with".
5158         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
5159         (with_command, with_command_completer): New.
5160         (pipe_command): Adjust to new repeat_previous
5161         interface.
5162         (_initialize_cli_cmds): Install the "with" command and its "w"
5163         alias.
5164         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
5165         declarations.
5166         * cli/cli-setshow.c (parse_cli_var_uinteger)
5167         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
5168         argument strings for all var_types.
5169         (get_setshow_command_value_string): New, factored out from ...
5170         (do_show_command): ... this.
5171         * cli/cli-setshow.h: Include <string>.
5172         (get_setshow_command_value_string): Declare.
5173         * command.h (repeat_previous): Now returns const char *.  Adjust
5174         comment.
5175         * maint.c: Include "cli/cli-cmds.h".
5176         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
5177         (_initialize_maint_cmds): Register the "maintenance with" command.
5178         * top.c (repeat_previous): Move bits from pipe_command here:
5179         Return the saved command line, if any; error out if there's no
5180         command to relaunch.
5181
5182 2019-07-03  Pedro Alves  <palves@redhat.com>
5183
5184         * NEWS (New commands): Mention "maint set/show test-settings"
5185         instead of "maint test-settings".
5186         * maint-test-settings.c (maintenance_test_settings_list): Delete.
5187         (maintenance_test_settings_set_list): Rename to ...
5188         (maintenance_set_test_settings_list): ... this.
5189         (maintenance_test_settings_show_list): Rename to  ...
5190         (maintenance_show_test_settings_list): ... this.
5191         (maintenance_test_settings_cmd): Delete.
5192         (maintenance_test_settings_set_cmd): ...
5193         (maintenance_set_test_settings_cmd): ... this.
5194         (maintenance_test_settings_show_cmd): ...
5195         (maintenance_show_test_settings_cmd): ... this.
5196         (maintenance_test_settings_show_value_cmd):
5197         (maintenance_show_test_settings_value_cmd): ... this.
5198         (_initialize_maint_test_settings): No longer install the "maint
5199         test-settings" prefix command.  Rename "maint test-settings set"
5200         to "maint set test-settings", and "maint test-settings show" to
5201         "maint show test-settings".  Adjust all subcommands.
5202
5203 2019-07-03  Pedro Alves  <palves@redhat.com>
5204
5205         * maint-test-settings.c: Fix file's intro comment.  Replace all
5206         references to "test-options" with references to "test-settings",
5207         in comments.
5208
5209 2019-07-03  Pedro Alves  <palves@redhat.com>
5210
5211         * maint-test-settings.c (maintenance_test_settings_xxx)
5212         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
5213         New.
5214         (maintenance_test_settings_enums): Use them.
5215         (maintenance_test_settings_enum): Default to
5216         maintenance_test_settings_xxx.
5217         (_initialize_maint_test_settings): Initialize
5218         MAINTENANCE_TEST_SETTINGS_FILENAME.
5219
5220 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
5221
5222         * breakpoint.h (remove_breakpoints_inf): Change return type to
5223         void, move function documentation here.
5224         * breakpoint.c (remove_breakpoints_inf): Change return type to
5225         void, move function documentation to header.
5226
5227 2019-07-02  Pedro Alves  <palves@redhat.com>
5228
5229         * NEWS (Completion improvements): Mention "info threads".
5230         * thread.c (struct info_threads_opts, info_threads_option_defs)
5231         (make_info_threads_options_def_group): New.
5232         (info_threads_command): Use gdb::option::process_options.
5233         (info_threads_command_completer): New.
5234         (_initialize_thread): Use gdb::option::build_help to build the
5235         help text for "info threads".
5236
5237 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
5238
5239         * defs.h (generic_load): Move from here...
5240         * symfile.h (generic_load): ... to here.  Rename name parameter
5241         to args.
5242         * symfile.c (generic_load): Add comment.
5243
5244 2019-07-01  Tom Tromey  <tromey@adacore.com>
5245
5246         * dwarf2read.c
5247         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
5248         declaration of without_params.  Fix formatting.
5249
5250 2019-07-01  Tom Tromey  <tromey@adacore.com>
5251
5252         * ada-exp.y (find_primitive_type): Update.
5253         * ada-lang.h (ada_lookup_symbol): Update.
5254         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
5255         parameter.
5256         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
5257
5258 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
5259
5260         PR breakpoints/24541
5261         * gdbarch.c: Regenerate.
5262         * gdbarch.h: Regenerate.
5263         * gdbarch.sh: Add 'stap_adjust_register'.
5264         * i386-tdep.c: Include '<unordered_set>'.
5265         (i386_stap_adjust_register): New function.
5266         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
5267         * stap-probe.c (stap_parse_register_operand): Call
5268         'gdbarch_stap_adjust_register'.
5269
5270 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
5271
5272         PR python/24742
5273         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
5274         * python/python.c (do_start_initialization): Use 'xmalloc'
5275         instead of 'PyMem_Malloc'.
5276
5277 2019-06-28  Tom Tromey  <tromey@adacore.com>
5278
5279         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
5280         for Ada.
5281
5282 2019-06-27  Tom Tromey  <tromey@adacore.com>
5283
5284         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
5285         objfile_key.
5286         (arm_find_mapping_symbol, arm_record_special_symbol)
5287         (_initialize_arm_tdep): Update.
5288         (arm_objfile_data_free): Remove.
5289
5290 2019-06-27  Tom Tromey  <tromey@adacore.com>
5291
5292         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
5293         to cp_print_static_field.
5294
5295 2019-06-26  Tom Tromey  <tromey@adacore.com>
5296
5297         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
5298         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
5299         declare.
5300
5301 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
5302
5303         * features/aarch64-core.c (create_feature_aarch64_core):
5304         Regenerate.
5305         * features/aarch64-core.xml: Add cpsr flags.
5306
5307 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
5308
5309         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
5310         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
5311
5312 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
5313
5314         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
5315         field.
5316         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
5317         use.
5318         (arm_record_special_symbol): Don't insert new symbol in sorted
5319         position, push it at the end.
5320
5321 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
5322
5323         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
5324         (arm_mapping_symbol_s): Remove.
5325         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
5326         (arm_mapping_symbol_vec): New typedef.
5327         (struct arm_per_objfile): Add constructor.
5328         <section_maps>: Change type to
5329         std::unique_ptr<arm_mapping_symbol_vec[]>.
5330         (arm_compare_mapping_symbols): Remove.
5331         (arm_find_mapping_symbol): Adjust to section_maps type change.
5332         (arm_objfile_data_free): Call delete on arm_per_objfile.
5333         (arm_record_special_symbol): Adjust to section_maps type change.
5334         Allocate arm_per_objfile with new.
5335
5336 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5337
5338         * cli/cli-cmds.c (alias_command): Compare the alias prefix
5339         with the command prefix.
5340
5341 2019-06-25  Tom Tromey  <tom@tromey.com>
5342
5343         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
5344         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
5345
5346 2019-06-25  Tom Tromey  <tom@tromey.com>
5347
5348         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
5349         type.
5350         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
5351         protected.
5352
5353 2019-06-25  Tom Tromey  <tom@tromey.com>
5354
5355         * tui/tui-winsource.c
5356         (tui_source_window_base::set_is_exec_point_at): Add check against
5357         LOA_ADDRESS.
5358
5359 2019-06-25  Tom Tromey  <tom@tromey.com>
5360
5361         * tui/tui-source.c (tui_set_source_content): Don't check before
5362         xfree.
5363         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
5364
5365 2019-06-25  Tom Tromey  <tom@tromey.com>
5366
5367         * tui/tui-winsource.h (tui_update_source_window_as_is)
5368         (tui_alloc_source_buffer, tui_line_is_displayed)
5369         (tui_addr_is_displayed): Change type of win_info.
5370         * tui/tui-winsource.c (tui_update_source_window_as_is)
5371         (tui_clear_source_content, tui_show_source_line)
5372         (tui_show_source_content, tui_source_window_base::refill)
5373         (tui_source_window_base::set_is_exec_point_at)
5374         (tui_source_window_base::set_is_exec_point_at)
5375         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
5376         (tui_alloc_source_buffer, tui_line_is_displayed)
5377         (tui_addr_is_displayed): Change type of win_info.  Update.
5378         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
5379         (tui_source_window_base::do_make_visible_with_new_height):
5380         Update.
5381         * tui/tui-source.c (tui_set_source_content)
5382         (tui_set_source_content_nil)
5383         (tui_source_window::do_scroll_vertical): Update.
5384         * tui/tui-layout.c (show_layout): Update.
5385         * tui/tui-disasm.c (tui_set_disassem_content)
5386         (tui_disasm_window::do_scroll_vertical): Update.
5387         * tui/tui-data.h (tui_win_content): Remove.
5388         (struct tui_gen_win_info) <content, content_size>: Remove.
5389         (struct tui_source_element): Add initializers and destructor.
5390         (union tui_which_element, struct tui_win_element): Remove.
5391         (struct tui_source_window_base) <content>: New field.
5392         (struct tui_data_window): Remove destructor.
5393         (tui_alloc_content, tui_free_win_content)
5394         (tui_free_all_source_wins_content): Don't declare.
5395         * tui/tui-data.c (tui_initialize_static_data): Update.
5396         (init_content_element, tui_alloc_content): Remove.
5397         (~tui_gen_win_info): Update.
5398         (~tui_data_window, tui_free_all_source_wins_content)
5399         (tui_free_win_content, free_content, free_content_elements):
5400         Remove.
5401
5402 2019-06-25  Tom Tromey  <tom@tromey.com>
5403
5404         * tui/tui-winsource.h (tui_clear_source_content)
5405         (tui_erase_source_content, tui_show_source_content): Change type
5406         of win_info.
5407         * tui/tui-winsource.c (tui_clear_source_content)
5408         (tui_erase_source_content, tui_show_source_content): Change type
5409         of win_info.
5410         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
5411         * tui/tui-source.h (tui_set_source_content_nil): Change type of
5412         win_info.
5413         * tui/tui-source.c (tui_set_source_content_nil): Change type of
5414         win_info.
5415         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
5416
5417 2019-06-25  Tom Tromey  <tom@tromey.com>
5418
5419         * tui/tui-winsource.c (tui_clear_source_content)
5420         (tui_source_window_base::set_is_exec_point_at): Update.
5421         * tui/tui-source.c (tui_set_source_content_nil): Update.
5422         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
5423         a bool.
5424         * tui/tui-data.c (init_content_element): Update.
5425
5426 2019-06-25  Tom Tromey  <tom@tromey.com>
5427
5428         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
5429         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
5430         * tui/tui-layout.c (init_and_make_win): Update.
5431         * tui/tui.h (enum tui_win_type): Update.
5432         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
5433         tui_win_is_auxillary.
5434         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
5435         tui_win_is_auxillary.
5436
5437 2019-06-25  Tom Tromey  <tom@tromey.com>
5438
5439         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
5440         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
5441         (tui_delete_data_content_windows, tui_display_all_data)
5442         (tui_data_window::do_scroll_vertical, tui_display_data_from):
5443         Update.
5444         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
5445         * tui/tui-regs.c (tui_last_regs_line_no)
5446         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
5447         (tui_show_registers): Update.
5448         (tui_show_register_group): Return void.  Update.
5449         (tui_display_registers_from, tui_display_reg_element_at_line)
5450         (tui_display_registers_from_line, tui_check_register_values):
5451         Update.
5452         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
5453         member.
5454         (struct tui_data_window) <regs_content>: Now a std::vector.
5455         <regs_content_count>: Remove.
5456         (tui_add_content_elements, tui_free_data_content): Don't declare.
5457         * tui/tui-data.c (tui_data_window::clear_detail): Update.
5458         (init_content_element): Remove DATA_WIN case.  Add assert.
5459         (tui_add_content_elements): Remove.
5460         (tui_data_window): Update.
5461         (tui_free_data_content): Remove.
5462         (free_content_elements): Remove DATA_WIN case.
5463
5464 2019-06-25  Tom Tromey  <tom@tromey.com>
5465
5466         * tui/tui-data.c (tui_data_item_window): Update.
5467         * tui/tui-windata.h (tui_check_data_values): Don't declare.
5468         * tui/tui-windata.c (tui_display_all_data)
5469         (tui_display_data_from_line): Update.
5470         (tui_check_data_values): Remove.
5471         * tui/tui-regs.c (tui_show_register_group)
5472         (tui_display_reg_element_at_line): Update.
5473         * tui/tui-hooks.c (tui_register_changed)
5474         (tui_refresh_frame_and_register_information): Call
5475         tui_check_register_values.
5476         * tui/tui-data.h (struct tui_data_window) <data_content,
5477         data_content_count, data_type>: Remove.
5478         (enum tui_data_type): Remove.
5479
5480         * tui/tui-data.c (tui_data_window::clear_detail)
5481         (~tui_data_window): Update.
5482
5483 2019-06-25  Tom Tromey  <tom@tromey.com>
5484
5485         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
5486         declare.
5487         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
5488         Rename from tui_first_data_item_displayed.  Update.
5489         (tui_data_window::refresh_all)
5490         (tui_data_window::do_scroll_vertical): Update.
5491         * tui/tui-data.h (struct tui_data_window)
5492         <first_data_item_displayed>: Declare new method.
5493
5494 2019-06-25  Tom Tromey  <tom@tromey.com>
5495
5496         * tui/tui-data.h (tui_init_generic_part): Don't declare.
5497         * tui/tui-data.c (tui_init_generic_part): Remove, moving
5498         contents...
5499         (tui_initialize_static_data): ...here.
5500
5501 2019-06-25  Tom Tromey  <tom@tromey.com>
5502
5503         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
5504         (tui_display_registers_from, tui_check_register_values): Update.
5505         (tui_display_register): Remove win_info parameter; update.
5506         (tui_get_register): Change type of parameters.
5507         * tui/tui-data.h (struct tui_data_element): Remove.
5508         (union tui_which_element) <data>: Remove.
5509         <data_window>: Change type.
5510         (struct tui_data_item_window): New.
5511         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
5512         case.  Add assert.
5513         (~tui_data_item_window): New destructor.
5514         (free_content_elements): Remove DATA_ITEM_WIN case.
5515
5516 2019-06-25  Tom Tromey  <tom@tromey.com>
5517
5518         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
5519         Remove.
5520
5521 2019-06-25  Tom Tromey  <tom@tromey.com>
5522
5523         * tui/tui-data.h (struct tui_command_element): Remove.
5524         (union tui_which_element) <command>: Remove.
5525         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
5526         assert.
5527         (free_content_elements): Remove CMD_WIN case.
5528
5529 2019-06-25  Tom Tromey  <tom@tromey.com>
5530
5531         * tui/tui-layout.c (tui_set_layout): Update.
5532         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
5533         * tui/tui-data.c (layout_def): Update.
5534
5535 2019-06-25  Tom Tromey  <tom@tromey.com>
5536
5537         * tui/tui-wingeneral.c (tui_refresh_all): Update.
5538         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
5539         (tui_source_window_base::set_new_height): Update.
5540         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
5541         Update.
5542         (tui_set_locator_fullname, tui_set_locator_info)
5543         (tui_show_frame_info): Update.
5544         * tui/tui-source.c (tui_set_source_content)
5545         (tui_source_is_displayed): Update.
5546         * tui/tui-layout.c (show_source_disasm_command, show_data)
5547         (show_source_or_disasm_and_command): Update.
5548         * tui/tui-disasm.c (tui_set_disassem_content)
5549         (tui_get_begin_asm_address): Update.
5550         * tui/tui-data.h (struct tui_locator_element): Remove.
5551         (union tui_which_element) <locator>: Remove.
5552         (struct tui_locator_window): New.
5553         (tui_locator_win_info_ptr): Change return type.
5554         * tui/tui-data.c (_locator): Change type.
5555         (tui_locator_win_info_ptr): Change return type.
5556         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
5557         (tui_alloc_content): Add assert.
5558
5559 2019-06-25  Tom Tromey  <tom@tromey.com>
5560
5561         * tui/tui-winsource.c
5562         (tui_exec_info_window::maybe_allocate_content): New method.
5563         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
5564         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
5565         (make_source_or_disasm_window): Add cast.
5566         * tui/tui-data.h (union tui_which_element) <simple_string>:
5567         Remove.
5568         (struct tui_source_info): New.
5569         (struct tui_source_window_base) <execution_info>: Change type.
5570         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
5571         case, and add assert.
5572         (tui_alloc_content): Add assert.
5573
5574 2019-06-25  Tom Tromey  <tom@tromey.com>
5575
5576         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
5577         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
5578         * tui/tui-data.c (tui_alloc_win_info): Remove.
5579
5580 2019-06-25  Tom Tromey  <tom@tromey.com>
5581
5582         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
5583         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
5584         can_highlight.
5585
5586 2019-06-25  Tom Tromey  <tom@tromey.com>
5587
5588         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
5589         make_visible_with_new_height method.
5590         (tui_win_info::make_visible_with_new_height): New method.
5591         (tui_source_window_base::do_make_visible_with_new_height)
5592         (tui_data_window::do_make_visible_with_new_height)
5593         (tui_cmd_window::do_make_visible_with_new_height): New methods.
5594         (make_visible_with_new_height): Remove.
5595         (tui_resize_all, tui_adjust_win_heights): Use
5596         make_visible_with_new_height method.
5597         * tui/tui-data.h (struct tui_win_info)
5598         <do_make_visible_with_new_height, make_visible_with_new_height>:
5599         New methods.
5600         (struct tui_source_window_base, struct tui_data_window)
5601         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
5602         methods.
5603
5604 2019-06-25  Tom Tromey  <tom@tromey.com>
5605
5606         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
5607         method.
5608         (update_tab_width): Call update_tab_width method.
5609         * tui/tui-data.h (struct tui_win_info)
5610         (struct tui_source_window_base) <update_tab_width>: New methods.
5611
5612 2019-06-25  Tom Tromey  <tom@tromey.com>
5613
5614         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
5615         parameter.
5616         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
5617         parameter.
5618         (tui_gen_win_info::make_visible): Update.
5619         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
5620         parameter.
5621         * tui/tui-data.h (enum tui_box): New enum.
5622         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
5623
5624 2019-06-25  Tom Tromey  <tom@tromey.com>
5625
5626         * tui/tui-layout.c (make_source_or_disasm_window): Always use
5627         init_and_make_win for EXEC_INFO_WIN.
5628         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
5629         longer inline.
5630         (struct tui_win_info) <~tui_win_info>: Inline.
5631         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
5632         Don't declare.
5633         * tui/tui-data.c (source_win, disasm_win): Remove globals.
5634         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
5635         Remove.
5636         (tui_initialize_static_data): Update.
5637         (~tui_gen_win_info): Handle more cleanup here.
5638         (~tui_source_window_base): Delete "execution_info".
5639         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
5640
5641 2019-06-25  Tom Tromey  <tom@tromey.com>
5642
5643         * tui/tui-layout.c (make_command_window): Don't set
5644         can_highlight.
5645         (show_source_disasm_command): Call the reset method.
5646         (show_data): Don't set can_highlight.  Call the reset method.
5647         (tui_gen_win_info::reset): Rename from init_gen_win_info
5648         (init_and_make_win): Simplify.  Return tui_gen_win_info.
5649         (show_source_or_disasm_and_command): Call the reset method.
5650         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
5651         (struct tui_cmd_window): Set can_highlight.
5652
5653 2019-06-25  Tom Tromey  <tom@tromey.com>
5654
5655         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
5656         from make_visible.
5657         (tui_make_visible, tui_make_invisible): Rewrite.
5658         (tui_win_info::make_visible): Remove.
5659         (tui_source_window_base::make_visible): Update.
5660         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
5661         method.  Moved from...
5662         (struct tui_win_info) <make_visible>: ...here.
5663
5664 2019-06-25  Tom Tromey  <tom@tromey.com>
5665
5666         * tui/tui-winsource.c
5667         (tui_source_window_base::do_scroll_horizontal): Remove direction
5668         parameter.
5669         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
5670         direction parameter.
5671         * tui/tui-win.c (tui_win_info::forward_scroll)
5672         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
5673         (tui_win_info::right_scroll): Update.
5674         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
5675         direction parameter.
5676         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
5677         direction parameter.
5678         * tui/tui-data.h (enum tui_scroll_direction): Remove.
5679         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
5680         Remove direction parameter.
5681         (struct tui_source_window_base, struct tui_source_window)
5682         (struct tui_disasm_window, struct tui_data_window)
5683         (struct tui_cmd_window): Update.
5684
5685 2019-06-25  Tom Tromey  <tom@tromey.com>
5686
5687         * tui/tui-winsource.h (tui_set_exec_info_content)
5688         (tui_show_exec_info_content, tui_erase_exec_info_content)
5689         (tui_clear_exec_info_content, tui_update_exec_info): Change
5690         argument to tui_source_window_base.
5691         * tui/tui-winsource.c (tui_set_exec_info_content)
5692         (tui_show_exec_info_content, tui_erase_exec_info_content)
5693         (tui_clear_exec_info_content, tui_update_exec_info): Change
5694         argument to tui_source_window_base.
5695
5696 2019-06-25  Tom Tromey  <tom@tromey.com>
5697
5698         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
5699         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
5700
5701 2019-06-25  Tom Tromey  <tom@tromey.com>
5702
5703         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
5704         check.
5705
5706 2019-06-25  Tom Tromey  <tom@tromey.com>
5707
5708         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
5709         type to void.
5710         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
5711         type to void.
5712         * tui/tui-source.c (tui_set_source_content): Update.
5713         * tui/tui-disasm.c (tui_set_disassem_content): Update.
5714
5715 2019-06-25  Tom Tromey  <tom@tromey.com>
5716
5717         * tui/tui-win.c (window_name_completer, tui_set_focus)
5718         (tui_all_windows_info): Use name method.
5719         * tui/tui-data.h (struct tui_gen_win_info)
5720         (struct tui_source_window, struct tui_disasm_window)
5721         (struct tui_data_window, struct tui_cmd_window) <name>: New
5722         method.
5723         (tui_win_name): Don't declare.
5724         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
5725         (tui_win_name): Remove.
5726
5727 2019-06-25  Tom Tromey  <tom@tromey.com>
5728
5729         * tui/tui-winsource.h (tui_update_source_window)
5730         (tui_update_source_window_as_is): Change parameter type.
5731         * tui/tui-winsource.c (tui_update_source_window): Change win_info
5732         to be a tui_source_window_base.
5733         (tui_update_source_window_as_is): Likewise.
5734         * tui/tui-win.c (make_visible_with_new_height): Update.
5735
5736 2019-06-25  Tom Tromey  <tom@tromey.com>
5737
5738         * tui/tui-winsource.c (tui_erase_source_content)
5739         (tui_show_source_content, tui_show_exec_info_content)
5740         (tui_erase_exec_info_content): Use refresh_window method.
5741         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
5742         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
5743         from tui_refresh_win.
5744         (tui_data_window::refresh_window): New method.
5745         (tui_win_info::refresh, tui_source_window_base::refresh)
5746         (tui_refresh_all): Use refresh_window method.
5747         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
5748         method.
5749         * tui/tui-regs.c (tui_display_register): Call refresh_window
5750         method.
5751         * tui/tui-layout.c (show_source_disasm_command)
5752         (show_source_or_disasm_and_command): Call refresh_window method.
5753         * tui/tui-data.h (struct tui_gen_win_info)
5754         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
5755         New method.
5756
5757 2019-06-25  Tom Tromey  <tom@tromey.com>
5758
5759         * tui/tui.c (tui_rl_other_window, tui_enable)
5760         (tui_is_window_visible, tui_get_command_dimension): Update.
5761         * tui/tui-winsource.c (tui_update_source_window_as_is)
5762         (tui_clear_source_content, tui_erase_source_content)
5763         (tui_show_source_line, tui_source_window_base::refill)
5764         (tui_source_window_base::do_scroll_horizontal)
5765         (tui_source_window_base::set_is_exec_point_at)
5766         (tui_update_breakpoint_info, tui_set_exec_info_content)
5767         (tui_alloc_source_buffer, tui_line_is_displayed)
5768         (tui_addr_is_displayed): Update.
5769         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
5770         (tui_check_and_display_highlight_if_needed)
5771         (tui_win_info::make_visible, tui_win_info::refresh)
5772         (tui_refresh_all): Update.
5773         * tui/tui-windata.c (tui_first_data_item_displayed)
5774         (tui_delete_data_content_windows, tui_erase_data_content)
5775         (tui_display_all_data, tui_data_window::refresh_all)
5776         (tui_check_data_values): Update.
5777         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
5778         (tui_set_win_focus_to, tui_win_info::forward_scroll)
5779         (tui_win_info::backward_scroll, tui_refresh_all_win)
5780         (tui_resize_all, tui_set_focus, tui_all_windows_info)
5781         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
5782         (tui_source_window_base::set_new_height)
5783         (tui_data_window::set_new_height)
5784         (make_invisible_and_set_new_height)
5785         (make_visible_with_new_height, new_height_ok)
5786         (parse_scrolling_args): Update.
5787         * tui/tui-stack.c (tui_show_frame_info): Update.
5788         * tui/tui-source.c (tui_set_source_content)
5789         (tui_set_source_content_nil, tui_source_is_displayed)
5790         (tui_source_window::do_scroll_vertical): Update.
5791         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
5792         (tui_display_registers_from, tui_display_reg_element_at_line)
5793         (tui_check_register_values, tui_reg_command): Update.
5794         * tui/tui-layout.c (tui_default_win_height)
5795         (show_source_disasm_command, show_data, init_and_make_win)
5796         (show_source_or_disasm_and_command): Update.
5797         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
5798         (tui_redisplay_readline, tui_mld_flush)
5799         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
5800         (tui_getc): Update.
5801         * tui/tui-disasm.c (tui_set_disassem_content)
5802         (tui_disasm_window::do_scroll_vertical): Update.
5803         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
5804         Now virtual.
5805         (struct tui_win_info): Derive from tui_gen_win_info.
5806         <~tui_win_info>: Mark as override.
5807         <generic>: Remove member.
5808         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
5809         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
5810         (~tui_data_window, ~tui_win_info)
5811         (tui_free_all_source_wins_content): Update.
5812         * tui/tui-command.c (tui_refresh_cmd_win): Update.
5813
5814 2019-06-25  Tom Tromey  <tom@tromey.com>
5815
5816         * tui/tui-layout.c (init_and_make_win): Use new.
5817         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
5818         destructor, initializers.
5819         (tui_alloc_generic_win_info): Don't declare.
5820         * tui/tui-data.c (_locator): Add argument to constructor.
5821         (source_win, disasm_win): New globals.
5822         (exec_info): Remove.
5823         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
5824         Update.
5825         (tui_alloc_generic_win_info): Remove.
5826         (init_content_element): Use new.
5827         (tui_win_info::tui_win_info): Update.
5828         (free_content_elements) <case DATA_WIN>: Use delete.
5829
5830 2019-06-25  Tom Tromey  <tom@tromey.com>
5831
5832         * tui/tui-wingeneral.c (tui_refresh_win): Update.
5833         * tui/tui-windata.c (tui_first_data_item_displayed)
5834         (tui_delete_data_content_windows): Update.
5835         * tui/tui-win.c (tui_data_window::set_new_height): Update.
5836         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
5837         (tui_display_registers_from, tui_check_register_values): Update.
5838         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
5839         pointer.
5840         * tui/tui-data.c (init_content_element): Update.  Allocate the new
5841         window.
5842         (tui_free_data_content): Update.
5843         (free_content_elements) <case DATA_WIN>: Free the window.
5844
5845 2019-06-25  Tom Tromey  <tom@tromey.com>
5846
5847         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
5848         Update.
5849         * tui/tui-layout.c (make_command_window)
5850         (show_source_disasm_command, show_data, init_and_make_win)
5851         (show_source_or_disasm_and_command): Update.
5852         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
5853         method.
5854         <can_highight, is_highlighted>: Now bool.
5855         (tui_set_win_highlight): Don't declare.
5856         * tui/tui-data.c (tui_set_win_highlight): Remove.
5857
5858 2019-06-25  Tom Tromey  <tom@tromey.com>
5859
5860         * tui/tui-wingeneral.c (make_visible): Remove check of window
5861         type.
5862
5863 2019-06-25  Tom Tromey  <tom@tromey.com>
5864
5865         * tui/tui-win.c (tui_win_info::max_height)
5866         (tui_cmd_window::max_height): New methods.
5867         (new_height_ok): Call max_height.
5868         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
5869         <max_height>: New method.
5870
5871 2019-06-25  Tom Tromey  <tom@tromey.com>
5872
5873         * tui/tui-win.c (tui_source_window_base::set_new_height)
5874         (tui_data_window::set_new_height): New methods.
5875         (make_invisible_and_set_new_height): Call set_new_height method.
5876         * tui/tui-data.h (struct tui_win_info)
5877         (struct tui_source_window_base, struct tui_data_window)
5878         <set_new_height>: New method.
5879
5880 2019-06-25  Tom Tromey  <tom@tromey.com>
5881
5882         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
5883         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
5884         tui_refresh_data_win.
5885         * tui/tui-win.c (tui_source_window_base::refresh_all): New
5886         method.
5887         (tui_refresh_all_win): Call the refresh_all method.
5888         (tui_set_focus): Likewise.
5889         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
5890         (struct tui_source_window_base, struct tui_data_window) <refresh>:
5891         Likewise.
5892
5893 2019-06-25  Tom Tromey  <tom@tromey.com>
5894
5895         * tui/tui-winsource.h (tui_refill_source_window)
5896         (tui_set_is_exec_point_at): Don't declare.
5897         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
5898         (tui_source_window_base::refill): Rename from
5899         tui_refill_source_window.
5900         (tui_source_window_base::do_scroll_horizontal): Update.
5901         (tui_source_window_base::set_is_exec_point_at): Rename from
5902         tui_set_is_exec_point_at.
5903         (tui_update_all_breakpoint_info): Update.
5904         * tui/tui-stack.c (tui_show_frame_info): Update.
5905         * tui/tui-layout.c (show_data): Add cast.
5906         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
5907         * tui/tui-data.h (struct tui_source_window_base) <refill,
5908         set_is_exec_point_at>: New methods.
5909         (tui_source_windows, tui_add_to_source_windows): Update types.
5910         (tui_add_to_source_windows): Remove redundant declaration.
5911         * tui/tui-data.c (source_windows): Store tui_source_window_base.
5912         (tui_source_windows): Change return type.
5913         (tui_clear_source_windows_detail): Update.
5914         (tui_add_to_source_windows): Change type of parameter.
5915         (tui_free_all_source_wins_content): Update.
5916
5917 2019-06-25  Tom Tromey  <tom@tromey.com>
5918
5919         * tui/tui-wingeneral.c (tui_win_info::refresh)
5920         (tui_source_window_base::refresh): New methods.
5921         (tui_refresh_all): Call the refresh method.
5922         * tui/tui-data.h (struct tui_win_info)
5923         (struct tui_source_window_base) <refresh>: New method.
5924
5925 2019-06-25  Tom Tromey  <tom@tromey.com>
5926
5927         * tui/tui.h (tui_is_window_visible): Return bool.
5928         * tui/tui.c (tui_is_window_visible): Return bool.
5929         * tui/tui-wingeneral.c (tui_make_window, make_visible)
5930         (tui_make_visible, tui_make_invisible)
5931         (tui_win_info::make_visible)
5932         (tui_source_window_base::make_visible, make_all_visible)
5933         (tui_make_all_visible, tui_make_all_invisible): Update.
5934         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
5935         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
5936         bool.
5937         (struct tui_win_info, struct tui_source_window_base)
5938         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
5939         * tui/tui-data.c (tui_init_generic_part): Update.
5940
5941 2019-06-25  Tom Tromey  <tom@tromey.com>
5942
5943         * tui/tui-wingeneral.c (tui_win_info::make_visible)
5944         (tui_source_window_base::make_visible): New methods.
5945         (make_all_visible): Make method call.
5946         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
5947         (struct tui_source_window_base, struct tui_cmd_window): Override
5948         make_visible.
5949         (tui_win_is_source_type): Don't declare.
5950         * tui/tui-data.c (tui_win_is_source_type): Remove.
5951
5952 2019-06-25  Tom Tromey  <tom@tromey.com>
5953
5954         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
5955         NULL check.
5956
5957 2019-06-25  Tom Tromey  <tom@tromey.com>
5958
5959         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
5960         Inline constructor.  Add initializers for members.
5961         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
5962         constructors; now inline in class.
5963
5964 2019-06-25  Tom Tromey  <tom@tromey.com>
5965
5966         * tui/tui-regs.c (tui_show_registers): Update.
5967         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
5968         bool.
5969         * tui/tui-data.c (tui_data_window::clear_detail)
5970         (tui_data_window): Update.
5971
5972 2019-06-25  Tom Tromey  <tom@tromey.com>
5973
5974         * tui/tui-windata.c (tui_display_all_data)
5975         (tui_display_data_from_line, tui_display_data_from)
5976         (tui_check_data_values, tui_data_window::do_scroll_vertical):
5977         Update.
5978         * tui/tui-regs.c (tui_last_regs_line_no)
5979         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
5980         (tui_show_registers, tui_show_register_group)
5981         (tui_display_registers_from, tui_display_reg_element_at_line)
5982         (tui_display_registers_from_line, tui_check_register_values)
5983         (tui_reg_next, tui_reg_prev): Update.
5984         * tui/tui-layout.c (tui_set_layout, show_data): Update.
5985         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
5986         tui_data_window.
5987         (struct tui_win_info) <detail>: Remove.  Add new fields from
5988         tui_data_info.
5989         (TUI_DATA_WIN): Add cast.
5990         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
5991         (~tui_data_window): Simplify.
5992
5993 2019-06-25  Tom Tromey  <tom@tromey.com>
5994
5995         * tui/tui-layout.c (show_source_disasm_command)
5996         (show_source_or_disasm_and_command): Update.
5997         * tui/tui-io.c (update_cmdwin_start_line)
5998         (tui_redisplay_readline): Update.
5999         * tui/tui-data.h (struct tui_command_info): Remove.
6000         (struct tui_win_info) <detail>: Remove command_info member.
6001         (struct tui_data_window) <start_line>: New member, from
6002         tui_command_info.
6003         (TUI_CMD_WIN): Add casts.
6004
6005 2019-06-25  Tom Tromey  <tom@tromey.com>
6006
6007         * tui/tui-winsource.c (tui_update_source_window)
6008         (tui_refill_source_window)
6009         (tui_source_window_base::do_scroll_horizontal)
6010         (tui_update_breakpoint_info, tui_set_exec_info_content)
6011         (tui_show_exec_info_content, tui_erase_exec_info_content)
6012         (tui_clear_exec_info_content): Update.
6013         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
6014         Update.
6015         * tui/tui-win.c (make_invisible_and_set_new_height)
6016         (make_visible_with_new_height): Update.
6017         * tui/tui-source.c (tui_set_source_content)
6018         (tui_show_symtab_source): Update.
6019         * tui/tui-layout.c (extract_display_start_addr)
6020         (show_source_disasm_command, show_data)
6021         (make_source_or_disasm_window)
6022         (show_source_or_disasm_and_command): Update.
6023         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
6024         (tui_disasm_window::do_scroll_vertical): Remove shadowing
6025         "gdbarch".
6026         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
6027         to tui_source_window_base.
6028         (struct tui_win_info) <detail>: Remove source_info member.
6029         (struct tui_source_window_base) <has_locator>: Inline.
6030         Move contents from tui_source_info; rename has_locator member to
6031         m_has_locator.
6032         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
6033         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
6034         header file.
6035         (tui_source_window_base::clear_detail, ~tui_source_window_base):
6036         Simplify.
6037         (tui_free_all_source_wins_content): Cast to
6038         tui_source_window_base.
6039
6040 2019-06-25  Tom Tromey  <tom@tromey.com>
6041
6042         * tui/tui-win.c (make_invisible_and_set_new_height)
6043         (make_visible_with_new_height): Call has_locator method.
6044         * tui/tui-layout.c (show_source_disasm_command, show_data)
6045         (show_source_or_disasm_and_command): Update for bool change.
6046         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
6047         (tui_win_info) <has_locator>: New method.
6048         (struct tui_source_window_base) <has_locator>: New method.
6049         (tui_win_has_locator): Don't declare.
6050         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
6051         from tui_win_has_locator.
6052         (tui_source_window_base): Use false, not FALSE.
6053
6054 2019-06-25  Tom Tromey  <tom@tromey.com>
6055
6056         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
6057         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
6058         clear_detail method directly.
6059         (tui_clear_win_detail): Remove.
6060
6061 2019-06-25  Tom Tromey  <tom@tromey.com>
6062
6063         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
6064         "this", not TUI_DISASM_WIN.
6065
6066 2019-06-25  Tom Tromey  <tom@tromey.com>
6067
6068         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
6069         declare.
6070         * tui/tui-winsource.c
6071         (tui_source_window_base::do_scroll_horizontal): Rename from
6072         tui_horizontal_source_scroll.
6073         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
6074         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
6075         from tui_vertical_data_scroll.
6076         * tui/tui-win.h (tui_scroll): Don't declare.
6077         * tui/tui-win.c (tui_win_info::forward_scroll)
6078         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
6079         (tui_win_info::right_scroll): Rename and update.
6080         (tui_scroll_forward_command, tui_scroll_backward_command)
6081         (tui_scroll_left_command, tui_scroll_right_command): Update.
6082         (tui_scroll): Remove.
6083         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
6084         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
6085         from tui_vertical_source_scroll.
6086         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
6087         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
6088         from tui_vertical_disassem_scroll.
6089         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
6090         do_scroll_horizontal>: New methods.
6091         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
6092         Likewise.
6093         (struct tui_source_window_base): Add do_scroll_horizontal.
6094         (struct tui_source_window, struct tui_disasm_window): Add
6095         do_scroll_vertical.
6096         (struct tui_data_window, struct tui_cmd_window): Add
6097         do_scroll_horizontal and do_scroll_vertical.
6098         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
6099
6100 2019-06-25  Tom Tromey  <tom@tromey.com>
6101
6102         * tui/tui-data.h (struct tui_source_window_base): New struct.
6103         (struct tui_source_window): Derive from tui_source_window_base.
6104         (struct tui_disasm_window): New struct.
6105         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
6106         from tui_source_window::clear_detail.
6107         (tui_source_window_base): Rename from tui_source_window.
6108         (~tui_source_window_base): Rename from ~tui_source_window.
6109         (tui_alloc_win_info): Create a tui_disasm_window.
6110
6111 2019-06-25  Tom Tromey  <tom@tromey.com>
6112
6113         * tui/tui-data.h (struct tui_source_window)
6114         (struct tui_data_window): Declare destructors.
6115         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
6116         destructors.
6117         (tui_win_info): Simplify.
6118
6119 2019-06-25  Tom Tromey  <tom@tromey.com>
6120
6121         * tui/tui-winsource.c (tui_display_main)
6122         (tui_update_source_windows_with_addr)
6123         (tui_update_all_breakpoint_info): Update.
6124         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
6125         (new_height_ok, parse_scrolling_args): Update.
6126         * tui/tui-stack.c (tui_show_frame_info): Update.
6127         * tui/tui-data.h (struct tui_list): Remove.
6128         (tui_source_windows): Return a reference to a std::vector.
6129         * tui/tui-data.c (source_windows): Now a std::vector.
6130         (tui_source_windows): Change return type.
6131         (tui_clear_source_windows): Rewrite.
6132         (tui_clear_source_windows_detail, tui_add_to_source_windows)
6133         (tui_free_all_source_wins_content): Rewrite.
6134
6135 2019-06-25  Tom Tromey  <tom@tromey.com>
6136
6137         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
6138         (struct tui_data_window, struct tui_cmd_window): Declare
6139         clear_detail method.
6140         * tui/tui-data.c (tui_source_window::clear_detail)
6141         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
6142         methods.
6143         (tui_clear_win_detail): Simplify.
6144
6145 2019-06-25  Tom Tromey  <tom@tromey.com>
6146
6147         * tui/tui-layout.c (make_source_window, make_disasm_window)
6148         (make_source_or_disasm_window): Remove win_info_ptr parameter.
6149         Return the new window.
6150         (show_source_disasm_command, show_data)
6151         (show_source_or_disasm_and_command): Update.
6152
6153 2019-06-25  Tom Tromey  <tom@tromey.com>
6154
6155         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
6156         parameter.  Return the new window.
6157         (show_source_disasm_command): Update and remove NULL check.
6158         (show_source_or_disasm_and_command): Update.
6159
6160 2019-06-25  Tom Tromey  <tom@tromey.com>
6161
6162         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
6163
6164 2019-06-25  Tom Tromey  <tom@tromey.com>
6165
6166         * tui/tui-data.h (struct tui_win_info): Make constructor
6167         protected.  Make destructor virtual.  Add initializers.
6168         (tui_source_window, tui_data_window, tui_cmd_window): New
6169         classes.
6170         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
6171         constructor.  Add "type" parameter.
6172         (tui_source_window, tui_data_window, tui_cmd_window): New
6173         constructors.
6174         (tui_alloc_win_info): Instantiate the appropriate subclass.
6175
6176 2019-06-25  Tom Tromey  <tom@tromey.com>
6177
6178         * tui/tui-win.c (tui_resize_all): Use delete.
6179         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
6180         destructor.
6181         (tui_free_window): Don't declare.
6182         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
6183         Update.
6184
6185 2019-06-25  Tom Tromey  <tom@tromey.com>
6186
6187         * tui/tui-data.h (struct tui_win_info): Add constructor.
6188         * tui/tui-data.c (tui_alloc_win_info): Use new.
6189         (tui_free_window): Use delete.
6190
6191 2019-06-22  Tom Tromey  <tom@tromey.com>
6192
6193         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
6194         declare.
6195         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
6196
6197 2019-06-22  Tom Tromey  <tom@tromey.com>
6198
6199         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
6200         declare.
6201         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
6202
6203 2019-06-22  Tom de Vries  <tdevries@suse.de>
6204
6205         * dwarf2read.c (create_addrmap_from_aranges)
6206         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
6207         instead of '%zu'.
6208
6209 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
6210
6211         * dwarf2read.h (dwarf2_section_info_def): Remove.
6212         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
6213         * dwarf2read.c (struct dwo_sections) <types>: Change type to
6214         std::vector<dwarf2_section_info>.
6215         (struct dwo_file) <~dwo_file>: Remove.
6216         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
6217         types field.
6218         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
6219         (dwarf2_read_debug_names): Likewise.
6220         (create_debug_types_hash_table): Change parameter type to
6221         array_view, adjust code accordingly.
6222         (dwarf2_locate_dwo_sections): Adjust to std::vector.
6223         (partial_die_info::fixup): Likewise.
6224         (determine_prefix): Likewise.
6225         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
6226
6227 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
6228
6229         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
6230         gdb_bfd_ref_ptr.
6231         <~dwo_file>: Remove call to gdb_bfd_unref.
6232         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
6233         gdb_bfd_ref_ptr::get.
6234
6235 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
6236
6237         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
6238         type to htab_up.
6239         * dwarf2read.c (struct dwo_file): Initialize fields.
6240         <~dwo_file>: New.
6241         (free_dwo_file): Remove, move content to ~dwo_file.
6242         (struct dwo_file_deleter): Remove.
6243         (dwo_file_up>: Remove custom deleter.
6244         (free_dwo_files): Remove.
6245         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
6246         dwo_files.
6247         (process_skeletonless_type_units): Call unique_ptr::get.
6248         (allocate_dwo_file_hash_table): Add deleter to created hash
6249         table.  Change return type to htab_up.
6250         (lookup_dwo_file_slot): Don't memset dwo_file, call
6251         unique_ptr::get.
6252         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
6253         (create_dwo_unit_in_dwp_v2): Likewise.
6254         (open_and_init_dwo_file): Likewise.
6255         (free_dwo_file_from_slot): Remove.
6256
6257 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
6258
6259         * dwarf2read.h (struct dwarf2_section_info) <readin,
6260         is_virtual>: Change type to bool.
6261         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
6262         true instead of 1.
6263
6264 2019-06-19  Tom Tromey  <tom@tromey.com>
6265
6266         * tui/tui-data.h (tui_init_content_element): Don't declare.
6267
6268 2019-06-19  Tom Tromey  <tom@tromey.com>
6269
6270         * tui/tui-data.h (tui_init_win_info): Don't declare.
6271
6272 2019-06-19  Tom de Vries  <tdevries@suse.de>
6273
6274         * dwarf2read.h (abstract_to_concrete): Change type to
6275         std::unordered_map<sect_offset, std::vector<sect_offset>,
6276         gdb::hash_enum<sect_offset>>.
6277
6278 2019-06-19  Tom Tromey  <tromey@adacore.com>
6279
6280         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
6281         EVAL_AVOID_SIDE_EFFECTS specially.
6282
6283 2019-06-19  Tom Tromey  <tromey@adacore.com>
6284
6285         * source-cache.c (highlighter): New global.
6286         (source_cache::get_source_lines): Create a highlighter on demand.
6287
6288 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
6289
6290         * defs.h (deprecated_interactive_hook): Delete declaration.
6291         * interps.c (clear_interpreter_hooks): Remove use of
6292         deprecated_interactive_hook.
6293         * top.c (deprecated_interactive_hook): Delete definition.
6294         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
6295
6296 2019-06-18  Tom de Vries  <tdevries@suse.de>
6297
6298         PR gdb/24515
6299         * dwarf2read.h (abstract_to_concrete): Change type from
6300         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
6301         std::unordered_map<sect_offset, std::vector<sect_offset>>.
6302         * dwarf2read.c (read_variable): Update.
6303         (dwarf2_fetch_die_loc_sect_off): Update.
6304
6305 2019-06-17  Tom de Vries  <tdevries@suse.de>
6306
6307         PR gdb/24617
6308         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
6309         accessing parent[parent_len - 1].
6310
6311 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
6312
6313         PR gdb/24364
6314         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
6315         call dtrace_process_dof with NULL dof.
6316
6317 2019-06-16  Tom de Vries  <tdevries@suse.de>
6318
6319         PR gdb/24445
6320         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
6321
6322 2019-06-16  Tom Tromey  <tom@tromey.com>
6323
6324         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
6325         (make_all_visible): Use address of member.
6326
6327 2019-06-16  Tom Tromey  <tom@tromey.com>
6328
6329         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
6330         (tui_free_window, free_content, free_content_elements): Remove
6331         unnecessary cast.
6332         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
6333         cast.
6334         * tui/tui-regs.c (tui_show_register_group)
6335         (tui_display_registers_from, tui_display_reg_element_at_line):
6336         Remove unnecessary cast.
6337
6338 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
6339
6340         * linux-nat.c (normal_mask): Delete.
6341         (_initialize_linux_nat): Don't initialise normal_mask.
6342
6343 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
6344
6345         PR gdb/24445
6346         * dwarf-index-write.h (write_psymtabs_to_index): Add
6347         dwz_basename parameter.
6348         * dwarf-index-write.c (write_gdbindex): Move file writing to
6349         write_gdbindex_1.  Change return type void.
6350         (assert_file_size): Move up, remove filename parameter.
6351         (write_gdbindex_1): New function.
6352         (write_debug_names): Change return type to void, call
6353         assert_file_size.
6354         (struct index_wip_file): New struct.
6355         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
6356         file logic to index_wip_file.  Write index for dwz file if
6357         needed.
6358         (save_gdb_index_command): Pass basename of dwz file, if present.
6359         * dwarf-index-cache.c (index_cache::store): Obtain and pass
6360         build-id of dwz file, if present.
6361         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
6362         (dwarf2_get_dwz_file): Likewise.
6363         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
6364         (dwarf2_get_dwz_file): Likewise.
6365
6366 2019-06-16  Tom Tromey  <tom@tromey.com>
6367
6368         * coffread.c (process_coff_symbol): Use xstrdup.
6369         * value.c (create_internalvar): Use xstrdup.
6370
6371 2019-06-16  Tom Tromey  <tom@tromey.com>
6372
6373         * valops.c (value_cast, value_slice): Remove unnecessary cast.
6374         * breakpoint.c (stopin_command, stopat_command)
6375         (until_break_command, decode_location_default): Remove unnecessary
6376         cast.
6377         * utils.c (subset_compare): Remove unnecessary cast.
6378         * ada-lang.c (ada_update_initial_language): Remove unnecessary
6379         cast.
6380         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
6381         cast.
6382         * infcmd.c (path_command): Remove unnecessary cast.
6383         * coffread.c (decode_type): Remove unnecessary cast.
6384         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
6385         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
6386         * tui/tui-stack.c (tui_show_locator_content)
6387         (tui_show_frame_info): Remove unnecessary cast.
6388         * tui/tui-win.c (tui_scroll_forward_command)
6389         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
6390         (parse_scrolling_args): Remove unnecessary cast.
6391         * tui/tui-data.c (init_win_info, tui_del_window)
6392         (tui_free_window, tui_del_data_windows, tui_free_data_content)
6393         (free_content_elements): Remove unnecessary cast.
6394         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
6395         unnecessary cast.
6396         * tui/tui-source.c (tui_set_source_content)
6397         (tui_vertical_source_scroll): Remove unnecessary cast.
6398         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
6399         cast.
6400         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
6401         * tui/tui-regs.c (tui_display_registers_from)
6402         (tui_display_register): Remove unnecessary cast.
6403         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
6404         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
6405         (make_visible): Remove unnecessary cast.
6406         * tui/tui-winsource.c (tui_erase_source_content)
6407         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
6408         unnecessary cast.
6409         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
6410         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
6411         * stabsread.c (read_type, read_array_type, read_range_type):
6412         Remove unnecessary cast.
6413         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
6414         (parse_symbol, parse_type, upgrade_type, parse_external)
6415         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
6416         unnecessary cast.
6417         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
6418
6419 2019-06-16  Tom Tromey  <tom@tromey.com>
6420
6421         * tui/tui-data.c (tui_alloc_generic_win_info)
6422         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
6423         checks.
6424
6425 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
6426             Andrew Burgess  <andrew.burgess@embecosm.com>
6427
6428         * f-typeprint.c (f_print_type): Don't return early for not
6429         associated or not allocated types.
6430         (f_type_print_varspec_suffix): Add print_rank parameter and print
6431         ranks of array types in case they dangling.
6432         (f_type_print_base): Add print_rank parameter.
6433
6434 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
6435
6436         * NEWS: Mention new MI commands.
6437         * break-catch-throw.c (enum exception_event_kind): Move to
6438         breakpoint.h.
6439         (print_mention_exception_catchpoint): Output text as a single
6440         message.
6441         (catch_exception_command_1): Rename to...
6442         (catch_exception_event): ...this, make non-static, update header
6443         command, and change some parameter types.
6444         (catch_catch_command): Update for changes to
6445         catch_exception_command_1.
6446         (catch_throw_command): Likewise.
6447         (catch_rethrow_command): Likewise.
6448         * breakpoint.c (enum exception_event_kind): Delete.
6449         * breakpoint.h (enum exception_event_kind): Moved here from
6450         break-catch-throw.c.
6451         (catch_exception_event): Declare.
6452         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
6453         (mi_cmd_catch_throw): New function.
6454         (mi_cmd_catch_rethrow): New function.
6455         (mi_cmd_catch_catch): New function.
6456         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
6457         'catch-catch' entries.
6458         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
6459         (mi_cmd_catch_rethrow): Declare.
6460         (mi_cmd_catch_catch): Declare.
6461
6462 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
6463
6464         * annotate.c (annotate_source_line): Change return type to void,
6465         update implementation to match.
6466         * annotate.h (annotate_source_line): Change return type to void,
6467         update header comment.
6468         * stack.c (print_frame_info): Don't change what frame information
6469         is printed based on whether annotations are on or not.
6470
6471 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
6472
6473         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
6474         (annotate_source): Make static.
6475         (annotate_source_line): Moved from source.c and renamed from
6476         identify_source_line.  Update the return type.
6477         * annotate.h (annotate_source): Delete declaration.
6478         (annotate_source_line): Declaration moved from source.h, and
6479         renamed from identify_source_line.  Return type updated.
6480         * source.c (identify_source_line): Moved to annotate.c and renamed
6481         to annotate_source_line.
6482         (info_line_command): Remove check of annotation_level.
6483         * source.h (identify_source_line): Move declaration to annotate.h
6484         and rename to annotate_source_line.
6485         * stack.c: Add 'annotate.h' include.
6486         (print_frame_info): Remove check of annotation_level before
6487         calling annotate_source_line.
6488
6489 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
6490
6491         * source-cache.c (source_cache::get_plain_source_lines): Use
6492         open_source_file_with_line_charpos instead of just
6493         open_source_file, remove call to find_source_lines.
6494         (source_cache::get_source_lines): Likewise.
6495         * source.c (find_source_lines): Make static.
6496         (get_filename_and_charpos): Renamed into...
6497         (open_source_file_with_line_charpos): ..this along with changes to
6498         return a scoped_fd, and some other minor clean ups.
6499         (identify_source_line): Use open_source_file_with_line_charpos.
6500         (search_command_helper): Use open_source_file_with_line_charpos
6501         instead of just open_source_file, remove call to
6502         find_source_lines.
6503         * source.h (open_source_file_with_line_charpos): Declare new
6504         function.
6505         (find_source_lines): Delete declaration.
6506
6507 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
6508
6509         * source.c (get_filename_and_charpos): Remove fullname
6510         parameter.
6511         (identify_source_line): Update call to get_filename_and_charpos.
6512
6513 2019-06-14  Tom Tromey  <tromey@adacore.com>
6514
6515         PR gdb/24502:
6516         * ui-style.h (skip_ansi_escape): Update comment.
6517         * ui-file.h (class no_terminal_escape_file): New class.
6518         * ui-file.c (no_terminal_escape_file::write)
6519         (no_terminal_escape_file::puts): New methods.
6520         * cli/cli-logging.c (handle_redirections): Use
6521         no_terminal_escape_file.
6522
6523 2019-06-14  Tom Tromey  <tromey@adacore.com>
6524
6525         * NEWS: Move convenience variable news above Python news.
6526
6527 2019-06-14  Tom Tromey  <tom@tromey.com>
6528
6529         * gnulib: Move directory to top-level.
6530         * configure.ac: Don't configure gnulib.
6531         * configure: Rebuild.
6532         * common/common-defs.h: Use new path to gnulib.
6533         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
6534         (GNULIB_H): Remove.
6535         (INCGNU): Look in new gnulib location.
6536         (HFILES_NO_SRCDIR): Remove gnulib files.
6537         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
6538         (generated_files): Remove GNULIB_H.
6539         ($(LIBGNU), all-lib): Remove targets.
6540         (distclean): Don't mention GNULIB_BUILDDIR.
6541         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
6542
6543 2019-06-14  Tom Tromey  <tromey@adacore.com>
6544
6545         * symfile.c (add_symbol_file_command): Remove obsolete comment.
6546         Warn if symbol file does not provide any symbols.
6547
6548 2019-06-14  Tom Tromey  <tromey@adacore.com>
6549
6550         * source.c (find_and_open_source): Respect basenames_may_differ.
6551
6552 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
6553
6554         * annotate.c (annotate_breakpoints_invalid): Make use of
6555         scoped_restore_terminal_state.
6556         (annotate_frames_invalid): Likewise.
6557
6558 2019-06-14  Tom Tromey  <tromey@adacore.com>
6559
6560         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
6561         allow assignment to an internalvar.
6562
6563 2019-06-14  Tom Tromey  <tromey@adacore.com>
6564
6565         * ada-lex.l: Allow "_" in attribute names.
6566
6567 2019-06-14  Tom Tromey  <tromey@adacore.com>
6568
6569         PR gdb/24653:
6570         * regcache.c (registers_changed): Don't call alloca.
6571         * top.c (execute_command): Don't call alloca.
6572
6573 2019-06-13  Pedro Alves  <palves@redhat.com>
6574
6575         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
6576         'expression'.  When parsing an expression, error out if there's
6577         junk after "unlimited".
6578         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
6579         (do_set_command): Adjust calls to is_unlimited_literal.
6580
6581 2019-06-13  Pedro Alves  <palves@redhat.com>
6582
6583         * compile/compile.c (make_compile_options_def_group): Add braces
6584         around array_view initializer.
6585         * thread.c (make_thread_apply_all_options_def_group)
6586         (make_thread_apply_all_options_def_group): Likewise.
6587
6588 2019-06-13  Pedro Alves  <palves@redhat.com>
6589
6590         * NEWS (New commands): Mention "maint test-options
6591         require-delimiter", "maint test-options unknown-is-error", "maint
6592         test-options unknown-is-operand" and "maint show
6593         test-options-completion-result".
6594         (New command options, command completion): New section.
6595         (Completion improvements): New section.
6596         Mention that you can abbreviate "unlimited".
6597
6598 2019-06-13  Pedro Alves  <palves@redhat.com>
6599
6600         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
6601         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
6602         * unittests/cli-utils-selftests.c (test_parse_flags)
6603         (test_parse_flags_qcs): Delete.
6604         (test_cli_utils): Don't call deleted functions.
6605
6606 2019-06-13  Pedro Alves  <palves@redhat.com>
6607
6608         * thread.c: Include "cli/cli-option.h".
6609         (tp_array_compar_ascending): Global.
6610         (tp_array_compar): Delete function.
6611         (tp_array_compar_ascending, tp_array_compar_descending): New
6612         functions.
6613         (ascending_option_def, qcs_flag_option_def)
6614         (thr_qcs_flags_option_defs)
6615         (make_thread_apply_all_options_def_group)
6616         (make_thread_apply_options_def_group): New.
6617         (thread_apply_all_command): Use gdb::option::process_options.
6618         (thread_apply_command_completer)
6619         (thread_apply_all_command_completer): New.
6620         (thread_apply_command): Use gdb::option::process_options.
6621         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
6622         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
6623         to generate help text of "thread apply".  Adjust "taas"'s help.
6624         * tid-parse.c (tid_range_parser::in_thread_range): New method.
6625         * tid-parse.h (tid_range_parser::in_thread_range): New method.
6626
6627 2019-06-13  Pedro Alves  <palves@redhat.com>
6628
6629         * thread.c (thread_apply_command): Check for invalid TID with
6630         isdigit instead of !isalpha.
6631
6632 2019-06-13  Pedro Alves  <palves@redhat.com>
6633
6634         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
6635         (validate_flags_qcs): New.
6636         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
6637         (validate_flags_qcs): Declare.
6638         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
6639         (make_frame_apply_options_def_group): New.
6640         (frame_apply_command_count): Process options with
6641         gdb::option::process_options.
6642         (frame_apply_completer): New.
6643         (frame_apply_level_completer, frame_apply_all_completer)
6644         (frame_apply_completer): New.
6645         (_initialize_stack): Update help of "frame apply", "frame apply
6646         level", "frame apply all" and "faas" to mention supported options
6647         and install command completers.
6648         * stack.h (frame_apply_all_completer): Declare.
6649         * thread.c: Include "stack.h".
6650         (tfaas_command): Add "--".
6651         (_initialize_thread): Update help "tfaas" to mention supported
6652         options and install command completer.
6653
6654 2019-06-13  Pedro Alves  <palves@redhat.com>
6655
6656         * completer.c (complete_nested_command_line): New.
6657         (gdb_completion_word_break_characters_throw): Add assertion.
6658         * completer.h (complete_nested_command_line): Declare.
6659
6660 2019-06-13  Pedro Alves  <palves@redhat.com>
6661
6662         * stack.c (parse_backtrace_qualifiers): New.
6663         (backtrace_command): Use it.
6664         (backtrace_command_completer): Complete on qualifiers.
6665
6666 2019-06-13  Pedro Alves  <palves@redhat.com>
6667
6668         * frame.c: Include "cli/cli-option.h.
6669         (user_set_backtrace_options): New.
6670         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
6671         Delete.
6672         (get_prev_frame): Adjust.
6673         (boolean_option_def, uinteger_option_def)
6674         (set_backtrace_option_defs): New.
6675         (_initialize_frame): Adjust and use
6676         gdb::option::add_setshow_cmds_for_options to install "set
6677         backtrace past-main" and "set backtrace past-entry".
6678         * frame.h: Include "cli/cli-option.h".
6679         (struct frame_print_options): Forward declare.
6680         (print_frame_arguments_all, print_frame_arguments_scalars)
6681         (print_frame_arguments_none): Declare.
6682         (print_entry_values): Delete declaration.
6683         (struct frame_print_options, user_frame_print_options): New.
6684         (struct set_backtrace_options): New.
6685         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
6686         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
6687         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
6688         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
6689         (list_args_or_locals): Add frame_print_options parameter.
6690         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
6691         * python/py-framefilter.c (enumerate_args): Pass down
6692         USER_FRAME_PRINT_OPTIONS.
6693         * stack.c: Include "cli/cli-option.h".
6694         (print_frame_arguments_all, print_frame_arguments_scalars)
6695         (print_frame_arguments_none): Declare.
6696         (print_raw_frame_arguments, print_entry_values): Delete.
6697         (user_frame_print_options): New.
6698         (boolean_option_def, enum_option_def, frame_print_option_defs):
6699         New.
6700         (struct backtrace_cmd_options): New.
6701         (bt_flag_option_def): New.
6702         (backtrace_command_option_defs): New.
6703         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
6704         (print_frame_arg, read_frame_arg, print_frame_args)
6705         (print_frame_info, print_frame): Add frame_print_options parameter
6706         and use it.
6707         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
6708         (backtrace_command_1): Add frame_print_options and
6709         backtrace_cmd_options parameters and use them.
6710         (make_backtrace_options_def_group): New.
6711         (backtrace_command): Process command options with
6712         gdb::option::process_options.
6713         (backtrace_command_completer): New.
6714         (_initialize_stack): Extend "backtrace"'s help to mention
6715         supported options.  Install completer for "backtrace".
6716         Install some settings commands with add_setshow_cmds_for_options.
6717
6718 2019-06-13  Pedro Alves  <palves@redhat.com>
6719
6720         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
6721         and that "set/show print raw frame-arguments" are now deprecated.
6722
6723         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
6724         command.
6725         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
6726         * stack.c (_initialize_stack): Install "set/show print
6727         raw-frame-arguments", and deprecate "set/show print raw
6728         frame-arguments".
6729         * valprint.c (_initialize_valprint): Deprecate "set/show print
6730         raw".
6731
6732 2019-06-13  Pedro Alves  <palves@redhat.com>
6733
6734         * compile/compile.c (struct compile_options): New.
6735         (compile_flag_option_def, compile_command_option_defs)
6736         (make_compile_options_def_group): New.
6737         (compile_file_command): Handle options with
6738         gdb::option::process_options.
6739         (compile_file_command_completer): New function.
6740         (compile_code_command): Handle options with
6741         gdb::option::process_options.
6742         (compile_code_command_completer): New function.
6743         (_initialize_compiler): Install completers for "compile code" and
6744         "compile file".  Mention available options in "compile code" and
6745         "compile code"'s help.
6746         * completer.c (advance_to_completion_word): New, factored out from
6747         ...
6748         (advance_to_expression_complete_word_point): ... this.
6749         (advance_to_filename_complete_word_point): New.
6750         * completer.h (advance_to_filename_complete_word_point): New
6751         declaration.
6752
6753 2019-06-13  Pedro Alves  <palves@redhat.com>
6754
6755         * compile/compile.c: Include "cli/cli-option.h".
6756         (compile_print_value): Scope data pointer is now a
6757         value_print_options pointer; adjust.
6758         (compile_print_command): Process options.  Scope data pointer is
6759         now a value_print_options pointer; adjust.
6760         (_initialize_compile): Update "compile print"'s help to include
6761         supported options.  Install a completer for "compile print".
6762         * cp-valprint.c (show_vtblprint, show_objectprint)
6763         (show_static_field_print): Delete.
6764         (_initialize_cp_valprint): Don't install "set print
6765         static-members", "set print vtbl", "set print object" here.
6766         * printcmd.c: Include "cli/cli-option.h" and
6767         "common/gdb_optional.h".
6768         (print_command_parse_format): Rework to fill in a
6769         value_print_options instead of a format_data.
6770         (print_value): Change parameter type from format_data pointer to
6771         value_print_options reference.  Adjust.
6772         (print_command_1): Process options.  Adjust to pass down a
6773         value_print_options.
6774         (print_command_completer): New.
6775         (_initialize_printcmd): Install print_command_completer as
6776         handle_brkchars completer for the "print" command.  Update
6777         "print"'s help to include supported options.
6778         * valprint.c: Include "cli/cli-option.h".
6779         (show_vtblprint, show_objectprint, show_static_field_print): Moved
6780         here from cp-valprint.c.
6781         (boolean_option_def, uinteger_option_def)
6782         (value_print_option_defs, make_value_print_options_def_group):
6783         New.  Use gdb::option::add_setshow_cmds_for_options to install
6784         "set print elements", "set print null-stop", "set print repeats",
6785         "set print pretty", "set print union", "set print array", "set
6786         print address", "set print symbol", "set print array-indexes".
6787         * valprint.h: Include <string> and "cli/cli-option.h".
6788         (make_value_print_options_def_group): Declare.
6789         (print_value): Change parameter type from format_data pointer to
6790         value_print_options reference.
6791         (print_command_completer): Declare.
6792
6793 2019-06-13  Pedro Alves  <palves@redhat.com>
6794
6795         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
6796         (COMMON_SFILES): Add maint-test-settings.c.
6797         * cli/cli-decode.c (boolean_enums): New global, factored out from
6798         ...
6799         (add_setshow_boolean_cmd): ... here.
6800         * cli/cli-decode.h (boolean_enums): Declare.
6801         * cli/cli-option.c: New file.
6802         * cli/cli-option.h: New file.
6803         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
6804         factored out from ...
6805         (parse_cli_boolean_value(const char *)): ... this.
6806         (is_unlimited_literal): Change parameter type to pointer to
6807         pointer.  Adjust and advance ARG pointer.
6808         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
6809         (parse_cli_var_enum): New, factored out from ...
6810         (do_set_command): ... this.  Adjust.
6811         * cli/cli-setshow.h (parse_cli_boolean_value)
6812         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
6813         (parse_cli_var_enum): Declare.
6814         * cli/cli-utils.c: Include "cli/cli-option.h".
6815         (get_ulongest): New.
6816         * cli/cli-utils.h (get_ulongest): Declare.
6817         (check_for_argument): New overloads.
6818         * maint-test-options.c: New file.
6819
6820 2019-06-13  Pedro Alves  <palves@redhat.com>
6821
6822         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
6823         parse a range if "-" is at the end of the string.
6824
6825 2019-06-13  Pedro Alves  <palves@redhat.com>
6826
6827         * cli/cli-setshow.c (parse_auto_binary_operation)
6828         (parse_cli_boolean_value): Don't allow "o".
6829
6830 2019-06-13  Pedro Alves  <palves@redhat.com>
6831
6832         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
6833         * NEWS: Mention maint test-settings KIND.
6834         * maint-test-settings.c: New file.
6835
6836 2019-06-13  Pedro Alves  <palves@redhat.com>
6837
6838         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
6839         completer.
6840         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
6841         "set" completers.
6842
6843 2019-06-13  Pedro Alves  <palves@redhat.com>
6844
6845         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
6846         after item.
6847
6848 2019-06-13  Pedro Alves  <palves@redhat.com>
6849
6850         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
6851
6852 2019-06-13  Pedro Alves <palves@redhat.com>
6853
6854         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
6855         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
6856         call.
6857         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
6858         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
6859         calls.
6860         (check_for_argument): Skip spaces after argument.
6861
6862 2019-06-13  Pedro Alves  <palves@redhat.com>
6863
6864         * thread.c (thread_apply_command): Adjust TID parsing.
6865         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
6866         detected before end of string.
6867         (tid_is_in_list): Error out if LIST is invalid.
6868
6869 2019-06-13  Pedro Alves  <palves@redhat.com>
6870
6871         * completer.c (complete_line_internal_1): Rewind completion word
6872         point.
6873         (completion_tracker::advance_custom_word_point_by): Change
6874         parameter type to int.
6875         * completer.h (completion_tracker::advance_custom_word_point_by):
6876         Likewise.
6877
6878 2019-06-13  Pedro Alves  <palves@redhat.com>
6879
6880         * completer.c (advance_to_completion_word): Handle delimiters.
6881
6882 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
6883
6884         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
6885
6886 2019-06-11  Tom Tromey  <tom@tromey.com>
6887
6888         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
6889         (xmalloc_failed): Move to alloc.c.
6890         * alloc.c: New file.
6891         * Makefile.in (COMMON_SFILES): Add alloc.c.
6892
6893 2019-06-11  Tom Tromey  <tom@tromey.com>
6894
6895         * nat/linux-waitpid.c: Don't include server.h.
6896         (linux_debug): Remove.
6897         (my_waitpid): Update.
6898
6899 2019-06-11  Tom Tromey  <tromey@adacore.com>
6900
6901         * infcall.c (_initialize_infcall): Remove trailing newline from
6902         help.
6903         * user-regs.c (_initialize_user_regs): Remove trailing newline
6904         from help.
6905         * typeprint.c (_initialize_typeprint): Remove trailing newline
6906         from help.
6907         * reverse.c (_initialize_reverse): Remove trailing newlines from
6908         help.
6909         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
6910         from help.
6911         * language.c (add_set_language_command): Remove trailing newline
6912         from help.
6913         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
6914         help.
6915         * disasm.c (_initialize_disasm): Remove trailing newline from
6916         help.
6917         * top.c (init_main): Remove trailing newline from help.
6918         * interps.c (_initialize_interpreter): Remove trailing newline
6919         from help.
6920         * btrace.c (_initialize_btrace): Remove trailing newlines from
6921         help.
6922         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
6923         from help.
6924         * python/python.c (_initialize_python): Remove trailing newline
6925         from help.
6926         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
6927         help.
6928         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
6929         from help.  Reformat some text.
6930         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
6931         from help.
6932         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
6933         newline from help.
6934
6935 2019-06-11  Tom Tromey  <tromey@adacore.com>
6936
6937         * darwin-nat.c (darwin_decode_exception_message)
6938         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
6939
6940 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
6941
6942         * valops.c (value_slice): Check for not allocated or not
6943         associated values.
6944
6945 2019-06-10  Tom de Vries  <tdevries@suse.de>
6946
6947         PR gdb/24618
6948         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
6949         sure an empty slot (defined by a 32-bit zero pair) is recognized as
6950         invalid.
6951
6952 2019-06-10  Tom de Vries  <tdevries@suse.de>
6953
6954         PR gdb/24611
6955         * linespec.c (linespec_lexer_lex_string): Remove incorrect
6956         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
6957
6958 2019-06-10  Tom de Vries  <tdevries@suse.de>
6959
6960         PR symtab/24545
6961         * symtab.c (struct demangled_name_entry): Add language field.
6962         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
6963         static minimal symbol".  Set and use language field.
6964
6965 2019-06-10  Tom Tromey  <tromey@adacore.com>
6966
6967         * ada-lang.c (_initialize_ada_language): Update help text.
6968
6969 2019-06-10  Tom Tromey  <tromey@adacore.com>
6970
6971         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
6972         with a newline.
6973         * guile/guile.c (handle_boot_error): Don't end warning with a
6974         newline.
6975         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
6976         warning with a newline.
6977         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
6978         newline.
6979         (s12z_frame_cache): Likewise.
6980         * dwarf-index-cache.c (index_cache::store): Don't end warning with
6981         a newline.
6982         * solib-svr4.c (disable_probes_interface): Don't end warning with
6983         a newline.
6984         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
6985         newline.
6986         * python/python.c (do_finish_initialization): Don't end warning
6987         with a newline.
6988
6989 2019-06-10  Tom Tromey  <tom@tromey.com>
6990
6991         * python/py-breakpoint.c (gdbpy_breakpoint_created)
6992         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
6993         gdbpy_enter.
6994
6995 2019-06-10  Tom Tromey  <tromey@adacore.com>
6996
6997         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
6998         data.
6999         (elf_new_init): Don't call stabsread_new_init.
7000         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
7001         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
7002         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
7003
7004 2019-06-10  Tom de Vries  <tdevries@suse.de>
7005
7006         PR symtab/16264
7007         PR symtab/24517
7008         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
7009
7010 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
7011
7012         * source.c (find_and_open_source): Also rewrite relative file
7013         names.
7014
7015 2019-04-26  Amos Bird  <amosbird@gmail.com>
7016
7017         * annotate.c (annotate_thread_exited): Add "thread-exited"
7018         annotation.
7019
7020 2019-06-06  Tom Tromey  <tromey@adacore.com>
7021
7022         * maint.h (class scoped_command_stats): Use
7023         DISABLE_COPY_AND_ASSIGN.
7024         <print_time>: New method.
7025         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
7026         print_time.
7027         (scoped_command_stats::print_time): New method.
7028
7029 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
7030
7031         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
7032         instructions of lengths 6 or 8 bytes.
7033
7034 2019-06-04  Pedro Alves  <palves@redhat.com>
7035
7036         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
7037
7038         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
7039         * breakpoint.c (condition_completer): Likewise.
7040         * cli/cli-dump.c (scan_expression): Likewise.
7041         * common/filestuff.c (mkdir_recursive): Likewise.
7042         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
7043         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
7044         (gdb_abspath): Likewise.
7045         * compile/compile-cplus-types.c
7046         (compile_cplus_instance::decl_name): Likewise.
7047         * completer.c (complete_explicit_location):
7048         (signal_completer, reg_or_group_completer_1): Likewise.
7049         * cp-support.c (cp_remove_params_if_any): Likewise.
7050         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
7051         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
7052         * infcmd.c (strip_bg_char): Likewise.
7053         * linespec.c (copy_token_string): Likewise.
7054         * mi/mi-main.c (output_cores): Likewise.
7055         * psymtab.c (psymtab_search_name):
7056         * symfile.c (test_set_ext_lang_command): Likewise.
7057         * target.c (target_fileio_read_stralloc): Likewise.
7058         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
7059         * value.c (complete_internalvar): Likewise.
7060
7061 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
7062
7063         Add objfile property to gdb.Type.
7064         * NEWS: Mention Python API addition.
7065         * python/py-type.c (typy_get_objfile): New method.
7066
7067 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7068
7069         * NEWS: Mention the new set|show style [title|highlight].
7070         Mention changes to "show style", "help" and "apropos".
7071
7072 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7073
7074         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
7075         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
7076         instead of print_help_for_command.
7077         (print_doc_of_command): New function.
7078         (help_list): Add 'apropos -v word' suggestion.
7079         (print_help_for_command): Style the command name using title style.
7080         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
7081         (_initialize_cli_cmds): Describe -v in apropos_command help.
7082
7083 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7084
7085         * cli/cli-style.h (cli_style_option): Add name in constructor,
7086         add m_name class member, add constructor with intensity,
7087         add name class function.
7088         (cli_style_option::add_setshow_commands): Remove name argument.
7089         (highlight_style, title_style): New styles.
7090         * cli/cli-style.c (do_show): New function that shows a style
7091         characteristic styling the style name with itself.
7092         (set_style_name): New function.
7093         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
7094         Update all callers according to the changes in cli/cli-style.h.
7095         * utils.h (fputs_highlighted): New function.
7096         * utils.c (fputs_highlighted): Likewise.
7097
7098 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7099
7100         * NEWS: Mention new pipe command and new convenience variables.
7101
7102 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7103
7104         * cli/cli-cmds.c (pipe_command): New function.
7105         (_initialize_cli_cmds): Call add_com for pipe_command.
7106         Define | as an alias for pipe.
7107         (exit_status_set_internal_vars): New function.
7108         (shell_escape): Call exit_status_set_internal_vars.
7109         cli/cli-decode.c (find_command_name_length): Recognize | as
7110         a single character command.
7111
7112 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7113
7114         * gdbcmd.h (execute_command_to_ui_file): New declaration.
7115         top.c (execute_command_to_ui_file): New function, mostly a copy
7116         of execute_command_to_string.
7117         (execute_command_to_string): Implement by calling
7118         execute_command_to_ui_file.
7119
7120 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7121
7122         * top.h (saved_command_line): Remove declaration.
7123         * top.c (previous_saved_command_line, previous_repeat_arguments):
7124         New variables.
7125         (saved_command_line): Make static, define together with other
7126         'repeat variables'.
7127         (dont_repeat): Clear repeat_arguments.
7128         (repeat_previous, get_saved_command_line, save_command_line):
7129         New functions.
7130         (gdb_init): Initialize saved_command_line
7131         and previous_saved_command_line.
7132         * main.c (captured_main_1): Remove saved_command_line initialization.
7133         * event-top.c (handle_line_of_input): Update to use
7134         the new 'repeat' related functions instead of direct access to
7135         saved_command_line.
7136         * command.h (repeat_previous, get_saved_command_line,
7137         save_command_line): New declarations.
7138         (dont_repeat): Add comment.
7139
7140 2019-05-30  Tom Tromey  <tromey@adacore.com>
7141
7142         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
7143         Fix comment.
7144         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
7145
7146 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
7147
7148         PR cli/24587
7149         * completer.c (complete): Initialize variable word.
7150
7151 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
7152
7153         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
7154         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
7155         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
7156         'body' is NULL to the outter 'if', protecting the '!is_define'
7157         situation as well.
7158
7159 2019-05-29  Tom Tromey  <tromey@adacore.com>
7160
7161         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
7162         (dwarf_unknown): New function.
7163         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
7164         (dwarf_type_encoding_name): Use dwarf_unknown.
7165
7166 2019-05-29  Tom Tromey  <tromey@adacore.com>
7167
7168         PR c++/20020:
7169         * cp-valprint.c (cp_print_value_fields): Call
7170         cp_print_static_field inside "try".
7171
7172 2019-05-29  Tom Tromey  <tromey@adacore.com>
7173
7174         * inflow.c (struct terminal_info): Add default operator=.
7175         * configure: Rebuild.
7176         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
7177         -Wdeprecated-copy-dtor, -Wredundant-move.
7178
7179 2019-05-29  Tom Tromey  <tromey@adacore.com>
7180
7181         * NEWS: Add entry.
7182         * infcmd.c (print_return_value_1): Handle finish_print
7183         option.
7184         (show_print_finish): New function.
7185         (_initialize_infcmd): Add "set/show print finish" commands.
7186         * valprint.c (user_print_options): Initialize new member.
7187         * valprint.h (struct value_print_options) <finish_print>: New
7188         member.
7189
7190 2019-05-28  Tom Tromey  <tromey@adacore.com>
7191
7192         * ada-lang.c (ada_remove_Xbn_suffix)
7193         (find_old_style_renaming_symbol)
7194         (parse_old_style_renaming): Remove.
7195         (ada_find_renaming_symbol): Don't call
7196         find_old_style_renaming_symbol.
7197         (ada_is_renaming_symbol): Rename from
7198         ada_find_renaming_symbol.  Remove "block" parameter.  Return
7199         bool.  Now static.
7200         (ada_read_var_value): Update and simplify.
7201         * ada-exp.y (write_var_or_type): Remove old code.
7202
7203 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
7204
7205         PR gdb/25010
7206         * event-top.c: Remove include comment.
7207         * inflow.c (class scoped_ignore_sigttou): Move from here...
7208         * inflow.h (class scoped_ignore_sigttou): ...to here.
7209         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
7210         * top.c:  Remove include comment.
7211
7212 2019-05-27  Tom Tromey  <tom@tromey.com>
7213
7214         * NEWS: Fix typo.
7215
7216 2019-05-22  Tom Tromey  <tromey@adacore.com>
7217
7218         * target.c (target_follow_exec): Constify parameter.
7219         * target-delegates.c: Rebuild.
7220         * remote.c (remote_target::follow_exec): Constify parameter.
7221         * infrun.c (follow_exec): Constify parameter.
7222         * target.h (struct target_ops) <follow_exec>: Constify parameter.
7223         (target_follow_exec): Likewise.
7224
7225 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
7226
7227         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
7228         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
7229
7230 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
7231
7232         * NEWS: Add debugredirect and testsuite sections.
7233
7234 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
7235
7236         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
7237         target descriptions using exclusively floating point register name
7238         aliases.
7239
7240 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
7241
7242         PR gdb/18644:
7243         * f-lang.c (build_fortran_types): Handle the case where
7244         gdbarch_floatformat_for_type returns a nullptr.
7245
7246 2019-05-21  Tom de Vries  <tdevries@suse.de>
7247
7248         PR cli/24587
7249         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
7250
7251 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
7252
7253         PR gdb/18644:
7254         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
7255         16-byte floats.
7256         * i386-tdep.c (i386_floatformat_for_type): Use
7257         floatformats_ia64_quad for the 16-byte floating point component
7258         within a fortran 32-byte complex number.
7259
7260 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
7261
7262         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
7263         delete default constructor.
7264         (find_partial_die): Update to return const struct.
7265         (partial_die_parent_scope): Move variable declaration into scope
7266         of its use and change its type to auto.
7267         (guess_partial_die_structure_name): Likewise.
7268         (partial_die_info::fixup): Likewise.
7269
7270 2019-05-17  Tom Tromey  <tromey@adacore.com>
7271
7272         * source.c (find_and_open_source): Remove cast.
7273
7274 2019-05-17  Tom Tromey  <tromey@adacore.com>
7275
7276         * annotate.c (annotate_source): Make "filename" const.
7277         * annotate.h (annotate_source): Use const.
7278
7279 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
7280
7281         * disasm.c (set_disassembler_options): Send errors to stderr.
7282
7283 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
7284
7285         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
7286         (cli_interp_base::set_logging): Check debug_redirect.
7287         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
7288         * cli/cli-logging.c (debug_redirect): Add static variable.
7289         (pop_output_files): Add default param.
7290         (handle_redirections): Print debug setting.
7291         (show_logging_command): Likewise.
7292         (_initialize_cli_logging): Add debugredirect command.
7293         * interps.c (current_interp_set_logging): Add debug_redirect
7294         parameter.
7295         * interps.h (set_logging): Add debug_redirect parameter.
7296         (current_interp_set_logging): Likewise.
7297         * mi/mi-common.h: Likewise.
7298         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
7299
7300 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
7301             Tom Tromey  <tromey@adacore.com>
7302
7303         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
7304         directly.
7305         * cli/cli-interp.h (make_logging_output): Remove declaration.
7306         * cli/cli-logging.c (make_logging_output): Remove function.
7307         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
7308         directly.
7309         * ui-file.c (tee_file::tee_file): Remove bools.
7310         (tee_file::~tee_file): Remove deletes.
7311         * ui-file.h (tee_file): Remove bools.
7312
7313 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
7314
7315         * mi/mi-cmds.h (mi_cmd_complete): New function.
7316         * mi/mi-main.c (mi_cmd_complete): Likewise.
7317         * mi/mi-cmds.c: Define new MI command -complete.
7318         * NEWS: Mention new -complete command.
7319
7320 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
7321
7322         * completer.h (complete): New function.
7323         * completer.c (complete): Likewise.
7324         * cli/cli-cmds.c: (complete_command): Update to use new complete()
7325         function defined in completer.h.
7326
7327 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
7328
7329         * MAINTAINERS (Write After Approval): Add myself.
7330
7331 2019-05-17  Tom de Vries  <tdevries@suse.de>
7332
7333         PR gdb/24094
7334         * dwarf2read.c (struct cu_partial_die_info): New struct.
7335         (find_partial_die): Return cu_partial_die_info.
7336         (partial_die_parent_scope, guess_partial_die_structure_name)
7337         (partial_die_info::fixup): Handle new return type of find_partial_die.
7338
7339 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
7340
7341         PR breakpoints/24541
7342         * stap-probe.c (stap_parse_register_operand): Make "regname" an
7343         "std::string", simplifying the algorithm.
7344
7345 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
7346
7347         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
7348         (stap_static_probe_ops::get_probes): Likewise.
7349
7350 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
7351
7352         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
7353         '-')" and "else if".
7354         (stap_parse_single_operand): Join checks for
7355         "gdbarch_stap_parse_special_token_p" and
7356         "gdbarch_stap_parse_special_token" in the same "if" statement.
7357         Invert check when verifying for operation on register
7358         displacement.
7359
7360 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
7361
7362         * stap-probe.c (stap_get_opcode): Update comment.
7363         (stap_get_expected_argument_type): Likewise.
7364         (handle_stap_probe): Likewise.
7365
7366 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
7367
7368         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
7369         return type to 'bool'.  Adjust comment.  Use 'bool' when
7370         appropriate.
7371         (i386_stap_parse_special_token_three_arg_disp): Likewise.
7372         * stap-probe.c (stap_parse_argument_1): Likewise.
7373         (stap_is_operator): Likewise.
7374         (stap_is_generic_prefix): Likewise.
7375         (stap_is_register_prefix): Likewise.
7376         (stap_is_register_indirection_prefix): Likewise.
7377         (stap_is_integer_prefix): Likewise.
7378         (stap_generic_check_suffix): Likewise.
7379         (stap_check_integer_suffix): Likewise.
7380         (stap_check_register_suffix): Likewise.
7381         (stap_check_register_indirection_suffix): Likewise.
7382         (stap_parse_register_operand): Likewise.
7383         (stap_parse_single_operand): Likewise.
7384         (stap_parse_argument_1): Likewise.
7385         (stap_probe::get_argument_count): Likewise.
7386         (stap_is_operator): Likewise.
7387
7388 2019-05-16  Tom Tromey  <tromey@adacore.com>
7389
7390         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
7391         keyword to foreach.
7392
7393 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
7394
7395         * linux-thread-db.c (try_thread_db_load_1): Change return type
7396         to bool.
7397         (try_thread_db_load): Likewise.
7398         (try_thread_db_load_from_pdir_1): Likewise.
7399         (try_thread_db_load_from_pdir): Likewise.
7400         (try_thread_db_load_from_sdir): Likewise.
7401         (try_thread_db_load_from_dir): Likewise.
7402         (thread_db_load_search): Likewise.
7403         (has_libpthread): Likewise.
7404         (thread_db_load): Likewise.
7405
7406 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
7407
7408         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
7409         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
7410         NULL, and complain/return if that's the case.
7411
7412 2019-05-15  John Darrington <john@darrington.wattle.id.au>
7413
7414         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
7415         (advance, posn, abstract_read_memory): New functions.
7416         [struct mem_read_abstraction]: New struct.
7417         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
7418
7419 2019-05-14  Tom Tromey  <tromey@adacore.com>
7420
7421         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
7422         value is not lval_memory.
7423
7424 2019-05-14  Tom Tromey  <tromey@adacore.com>
7425
7426         * solib.c (info_sharedlibrary_command): Style the file name.
7427
7428 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
7429
7430         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
7431         (aarch64_vnv_type): Likewise.
7432         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
7433         * common/tdesc.c: Likewise.
7434         * common/tdesc.h (enum tdesc_type_kind): Likewise.
7435         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
7436         * features/aarch64-fpu.xml: Add ieee half view.
7437         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
7438         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
7439         * gdbtypes.h (struct builtin_type): Likewise.
7440         (struct objfile_type): Likewise.
7441
7442 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
7443
7444         * language.c (language_sniff_from_mangled_name): Fix "langauge"
7445         typo.
7446         * location.h (string_to_event_location): Likewise.
7447
7448 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
7449
7450         GDB 8.3 released.
7451
7452 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
7453
7454         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
7455         New variable declaration.
7456         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
7457         New variable.
7458         (print_one_breakpoint): Use ui_out::test_flags and new global
7459         variable to compute use_fixed_output.
7460         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
7461         Remove.
7462         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
7463         (mi_multi_location_breakpoint_output_fixed): Remove.
7464         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
7465         new variable.
7466         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
7467         fix_multi_location_breakpoint_output flag if version >= 3.
7468         * ui-out.h (enum ui_out_flag)
7469         <fix_multi_location_breakpoint_output>: New enumerator.
7470
7471 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
7472
7473         * contrib/cc-with-tweaks.sh: Validate dwz's work.
7474
7475 2019-05-10  Tom Tromey  <tromey@adacore.com>
7476
7477         * ada-lang.c (catch_ada_completer): New function.
7478         (_initialize_ada_language): Use it.
7479
7480 2019-05-10  Tom Tromey  <tromey@adacore.com>
7481
7482         * thread.c (print_thread_info): Make "requested_threads" const.
7483         * gdbthread.h (print_thread_info): Make "requested_threads"
7484         const.
7485         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
7486         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
7487
7488 2019-05-08  Tom Tromey  <tom@tromey.com>
7489
7490         * gdbtypes.c (objfile_type_data): Change type.
7491         (objfile_type, _initialize_gdbtypes): Update.
7492
7493 2019-05-08  Tom Tromey  <tom@tromey.com>
7494
7495         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
7496         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
7497         (_initialize_dwarf2_frame): Update.
7498
7499 2019-05-08  Tom Tromey  <tom@tromey.com>
7500
7501         * objc-lang.c (objc_objfile_data): Change type.
7502         (find_methods): Update.
7503         (_initialize_objc_lang): Remove.
7504
7505 2019-05-08  Tom Tromey  <tom@tromey.com>
7506
7507         * stabsread.c (rs6000_builtin_type_data): Change type.
7508         (rs6000_builtin_type, _initialize_stabsread): Update.
7509
7510 2019-05-08  Tom Tromey  <tom@tromey.com>
7511
7512         * mips-tdep.c (mips_pdr_data): Remove.
7513         (_initialize_mips_tdep): Update.
7514
7515 2019-05-08  Tom Tromey  <tom@tromey.com>
7516
7517         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
7518         (hppa_init_objfile_priv_data, read_unwind_info)
7519         (find_unwind_entry, _initialize_hppa_tdep): Update.
7520
7521 2019-05-08  Tom Tromey  <tom@tromey.com>
7522
7523         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
7524         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
7525         on obstack.
7526         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
7527
7528 2019-05-08  Tom Tromey  <tom@tromey.com>
7529
7530         * mdebugread.c (basic_type_data): Change type.
7531         (basic_type, _initialize_mdebugread): Update.
7532
7533 2019-05-08  Tom Tromey  <tom@tromey.com>
7534
7535         * common/gdb_unique_ptr.h (struct noop_deleter): New.
7536
7537 2019-05-08  Tom Tromey  <tom@tromey.com>
7538
7539         * nto-tdep.c (nto_inferior_data_reg): Change type.
7540         (nto_inferior_data): Update.
7541         (nto_inferior_data_cleanup, nto_new_inferior_data)
7542         (_initialize_nto_tdep): Remove.
7543         * nto-tdep.h (struct nto_inferior_data): Add initializers.
7544
7545 2019-05-08  Tom Tromey  <tom@tromey.com>
7546
7547         * ada-lang.c (struct ada_inferior_data): Add initializers.
7548         (ada_inferior_data): Change type.
7549         (ada_inferior_data_cleanup): Remove.
7550         (get_ada_inferior_data, ada_inferior_exit)
7551         (struct ada_pspace_data): Add initializers, destructor.
7552         (ada_pspace_data_handle): Change type.
7553         (get_ada_pspace_data): Update.
7554         (ada_pspace_data_cleanup): Remove.
7555
7556 2019-05-08  Tom Tromey  <tom@tromey.com>
7557
7558         * coffread.c (struct coff_symfile_info): Add initializers.
7559         (coff_objfile_data_key): Move lower.  Change type.
7560         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
7561         Update.
7562         (coff_free_info): Remove.
7563
7564 2019-05-08  Tom Tromey  <tom@tromey.com>
7565
7566         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
7567         (fbsd_pspace_data_handle): Move lower.  Change type.
7568         (get_fbsd_pspace_data): Update.
7569         (fbsd_pspace_data_cleanup): Remove.
7570         (_initialize_fbsd_tdep): Update.
7571
7572 2019-05-08  Tom Tromey  <tom@tromey.com>
7573
7574         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
7575         (get_ada_tasks_pspace_data): Update.
7576         (ada_tasks_pspace_data_cleanup): Remove.
7577         (_initialize_tasks): Update.
7578         (ada_tasks_inferior_data_handle): Change type.
7579         (get_ada_tasks_inferior_data): Update.
7580         (ada_tasks_inferior_data_cleanup): Remove.
7581         (struct ada_tasks_pspace_data): Add initializers.
7582
7583 2019-05-08  Tom Tromey  <tom@tromey.com>
7584
7585         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
7586         * symfile-debug.c (debug_sym_get_probes): Change type.
7587         * stap-probe.c (handle_stap_probe):
7588         (stap_static_probe_ops::get_probes): Change type.
7589         * probe.h (class static_probe_ops) <get_probes>: Change type.
7590         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
7591         (parse_probes_in_pspace): Update.
7592         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
7593         Update.
7594         (any_static_probe_ops::get_probes): Change type.
7595         * elfread.c (elfread_data): New typedef.
7596         (probe_key): Change type.
7597         (elf_get_probes): Likewise.  Update.
7598         (probe_key_free): Remove.
7599         (_initialize_elfread): Update.
7600         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
7601         Change type.
7602         (dtrace_process_dof_probe, dtrace_process_dof)
7603         (dtrace_static_probe_ops::get_probe): Change type.
7604
7605 2019-05-08  Tom Tromey  <tom@tromey.com>
7606
7607         * xcoffread.c (struct xcoff_symfile_info): Rename from
7608         coff_symfile_info.  Add initializers.
7609         (xcoff_objfile_data_key): Move lower.  Change type.
7610         (XCOFF_DATA): Rewrite.
7611         (xcoff_free_info): Remove.
7612         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
7613         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
7614         (xcoff_initial_scan): Update.
7615
7616 2019-05-08  Tom Tromey  <tom@tromey.com>
7617
7618         * solib-svr4.c (struct svr4_info): Add initializers and
7619         destructor.
7620         <probes_table>: Now an htab_up.
7621         (solib_svr4_pspace_data): Change type.
7622         (free_probes_table): Simplify.
7623         (~svr4_info): Rename from svr4_pspace_data_cleanup.
7624         (get_svr4_info, probes_table_htab_remove_objfile_probes)
7625         (probes_table_remove_objfile_probes, register_solib_event_probe)
7626         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
7627         (_initialize_svr4_solib): Update.
7628
7629 2019-05-08  Tom Tromey  <tom@tromey.com>
7630
7631         * remote.c (remote_pspace_data): Change type.
7632         (remote_pspace_data_cleanup): Remove.
7633         (get_remote_exec_file, set_pspace_remote_exec_file)
7634         (_initialize_remote): Update.
7635
7636 2019-05-08  Tom Tromey  <tom@tromey.com>
7637
7638         * breakpoint.c (breakpoint_objfile_key): Change type.
7639         (get_breakpoint_objfile_data): Update.
7640         (free_breakpoint_objfile_data): Remove.
7641         (_initialize_breakpoint): Update.
7642
7643 2019-05-08  Tom Tromey  <tom@tromey.com>
7644
7645         * linux-tdep.c (struct linux_info): Add initializers.
7646         (linux_inferior_data): Move.  Change type.
7647         (invalidate_linux_cache_inf): Update.
7648         (linux_inferior_data_cleanup): Remove.
7649         (get_linux_inferior_data, _initialize_linux_tdep): Update.
7650
7651 2019-05-08  Tom Tromey  <tom@tromey.com>
7652
7653         * auxv.c (auxv_inferior_data): Move.  Change type.
7654         (auxv_inferior_data_cleanup): Remove.
7655         (invalidate_auxv_cache_inf): Rewrite.
7656         (get_auxv_inferior_data, _initialize_auxv): Update.
7657
7658 2019-05-08  Tom Tromey  <tom@tromey.com>
7659
7660         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
7661         (symfile_debug_objfile_data_key): Change type.
7662         (symfile_debug_installed, debug_qf_has_symbols)
7663         (debug_qf_find_last_source_symtab)
7664         (debug_qf_forget_cached_source_info)
7665         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
7666         (debug_qf_print_stats, debug_qf_dump)
7667         (debug_qf_expand_symtabs_for_function)
7668         (debug_qf_expand_all_symtabs)
7669         (debug_qf_expand_symtabs_with_fullname)
7670         (debug_qf_map_matching_symbols)
7671         (debug_qf_expand_symtabs_matching)
7672         (debug_qf_find_pc_sect_compunit_symtab)
7673         (debug_qf_map_symbol_filenames)
7674         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
7675         (debug_sym_new_init, debug_sym_init, debug_sym_read)
7676         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
7677         (debug_sym_read_linetable, debug_sym_relocate): Update.
7678         (symfile_debug_free_objfile): Remove.
7679         (install_symfile_debug_logging, _initialize_symfile_debug):
7680         Update.
7681
7682 2019-05-08  Tom Tromey  <tom@tromey.com>
7683
7684         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
7685         allocate_on_obstack.
7686         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
7687         (get_dwarf2_per_objfile): Update.
7688         (set_dwarf2_per_objfile): Remove.
7689         (dwarf2_has_info, dwarf2_get_section_info): Update.
7690         (dwarf2_free_objfile): Remove.
7691         (_initialize_dwarf2_read): Update.
7692
7693 2019-05-08  Tom Tromey  <tom@tromey.com>
7694
7695         * auto-load.c (struct auto_load_pspace_info): Add destructor and
7696         initializers.
7697         <unsupported_script_warning_printed,
7698         script_not_found_warning_printed>: Now bool.
7699         (auto_load_pspace_data): Change type.
7700         (~auto_load_pspace_info): Rename from
7701         auto_load_pspace_data_cleanup.
7702         (get_auto_load_pspace_data, init_loaded_scripts_info)
7703         (clear_section_scripts, maybe_print_unsupported_script_warning)
7704         (maybe_print_script_not_found_warning, _initialize_auto_load):
7705         Update.
7706
7707 2019-05-08  Tom Tromey  <tom@tromey.com>
7708
7709         * objfiles.c (objfile_pspace_info): Add destructor and
7710         initializers.
7711         (objfiles_pspace_data): Change type.
7712         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
7713         (get_objfile_pspace_data): Update.
7714         (objfiles_bfd_data): Change type.
7715         (get_objfile_bfd_data): Update.
7716         (objfile_bfd_data_free, _initialize_objfiles): Remove.
7717
7718 2019-05-08  Tom Tromey  <tom@tromey.com>
7719
7720         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
7721         Change type.
7722         (get_catch_syscall_inferior_data): Update.
7723         (catch_syscall_inferior_data_cleanup): Remove.
7724         (_initialize_break_catch_syscall): Update.
7725
7726 2019-05-08  Tom Tromey  <tom@tromey.com>
7727
7728         * inflow.c (struct terminal_info): Add destructor and
7729         initializers.
7730         (inflow_inferior_data): Change type.
7731         (~terminal_info): Rename from inflow_inferior_data_cleanup.
7732         (get_inflow_inferior_data, inflow_inferior_exit)
7733         (swap_terminal_info, _initialize_inflow): Update.
7734
7735 2019-05-08  Tom Tromey  <tom@tromey.com>
7736
7737         * target-dcache.c (target_dcache_cleanup): Remove.
7738         (target_dcache_aspace_key): Change type.
7739         (target_dcache_init_p, target_dcache_invalidate)
7740         (target_dcache_get, target_dcache_get_or_init)
7741         (_initialize_target_dcache): Update.
7742         * dcache.h (struct dcache_deleter): New.
7743
7744 2019-05-08  Tom Tromey  <tom@tromey.com>
7745
7746         * symtab.c (struct symbol_cache): Add destructor and
7747         initializers.
7748         (symbol_cache_key): Move.  Change type.
7749         (make_symbol_cache, free_symbol_cache): Remove.
7750         (get_symbol_cache): Update.
7751         (symbol_cache_cleanup): Remove.
7752         (ALL_PSPACES, symbol_cache_flush)
7753         (maintenance_print_symbol_cache)
7754         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
7755         Update.
7756
7757 2019-05-08  Tom Tromey  <tom@tromey.com>
7758
7759         * symtab.c (struct main_info): Add destructor and initializers.
7760         (main_progspace_key): Move.  Change type.
7761         (get_main_info): Update.
7762         (main_info_cleanup): Remove.
7763         (_initialize_symtab): Update.
7764
7765 2019-05-08  Tom Tromey  <tom@tromey.com>
7766
7767         * registry.h (DECLARE_REGISTRY): Define the _key class.
7768
7769 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
7770
7771         * NEWS: Merge two 'New commands' sections.
7772
7773 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
7774
7775         * ada-valprint.c (ada_val_print_gnat_array): Remove language
7776         parameter and use Ada language definition instead.
7777         (ada_val_print_ptr): Remove unused language parameter.
7778         (ada_val_print_num): Remove language parameter and use Ada language
7779         definition instead.
7780         (ada_val_print_enum, ada_val_print_flt): Remove unused language
7781         parameter.
7782         (ada_val_print_struct_union, ada_val_print_ref): Remove language
7783         parameter and use Ada language definition instead.
7784         (ada_val_print_1): Update all ada_val_print_xxx calls.
7785         Remove language parameter.
7786         (ada_val_print): Update ada_val_print_1 call.
7787
7788 2019-05-08  Tom Tromey  <tromey@adacore.com>
7789
7790         * remote.c (remote_hw_watchpoint_limit)
7791         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
7792         Now static.
7793
7794 2019-05-08  Tom Tromey  <tromey@adacore.com>
7795
7796         * maint.c (_initialize_maint_cmds): Move initialization code to
7797         remote.c.
7798         (watchdog, show_watchdog): Move to remote.c.
7799         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
7800         "watchdog" static.
7801         (_initialize_remote): Move initialization code from maint.c.
7802         * defs.h (watchdog): Don't declare.
7803
7804 2019-05-08  Tom Tromey  <tromey@adacore.com>
7805
7806         * tui/tui-interp.c: Include main.h.
7807         * interps.c: Include main.h.
7808         * main.h (interpreter_p): Declare.
7809         * defs.h (interpreter_p): Don't declare.
7810
7811 2019-05-08  Tom Tromey  <tromey@adacore.com>
7812
7813         * dwarf2loc.c: Include dwarf2read.h.
7814         * defs.h (read_unsigned_leb128): Don't declare.
7815         * dwarf2read.h (read_unsigned_leb128): Declare.
7816
7817 2019-05-08  Tom Tromey  <tromey@adacore.com>
7818
7819         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
7820         method.
7821
7822 2019-05-08  Tom Tromey  <tromey@adacore.com>
7823
7824         * utils.c (fputs_maybe_filtered): Reset style after paging, even
7825         when no wrap column is set.
7826
7827 2019-05-08  Tom Tromey  <tromey@adacore.com>
7828
7829         * c-lang.c (c_get_string): Handle non-C-style arrays.
7830
7831 2019-05-08  Tom Tromey  <tromey@adacore.com>
7832
7833         * typeprint.c (print_offset_data::update): Print the bit offset,
7834         not the number of bits remaining.
7835
7836 2019-05-08  Tom Tromey  <tromey@adacore.com>
7837
7838         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
7839         padding at end of comment.
7840
7841 2019-05-08  Tom Tromey  <tromey@adacore.com>
7842
7843         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
7844         Compare main types.
7845
7846 2019-05-06  Tom Tromey  <tom@tromey.com>
7847
7848         * common/scoped_mmap.c: Include common-defs.h.
7849         * common/scoped_mmap.h: Don't include config.h.
7850
7851 2019-05-04  Tom Tromey  <tom@tromey.com>
7852
7853         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
7854         (struct aarch64_call_info): Add initializers.
7855         <si>: Now a std::vector.
7856         (pass_on_stack, aarch64_push_dummy_call): Update.
7857
7858 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
7859             Tom Tromey  <tom@tromey.com>
7860
7861         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
7862         (ppc_threads): Now a std::vector.  Now static.
7863         (hwdebug_find_thread_points_by_tid)
7864         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
7865         Update.
7866
7867 2019-05-04  Tom Tromey  <tom@tromey.com>
7868
7869         * arc-tdep.c (arc_tdesc_init): Return bool.
7870
7871 2019-05-04  Tom Tromey  <tom@tromey.com>
7872
7873         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
7874         Use gdb_assert_not_reached.
7875
7876 2019-05-04  Tom Tromey  <tom@tromey.com>
7877
7878         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
7879         "false".
7880
7881 2019-05-04  Tom Tromey  <tom@tromey.com>
7882
7883         * arc-tdep.c (arc_tdesc_init): Use bool.
7884
7885 2019-05-04  Tom Tromey  <tom@tromey.com>
7886
7887         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
7888
7889 2019-05-04  Tom Tromey  <tom@tromey.com>
7890
7891         * cli/cli-cmds.c (valid_command_p): Return bool.
7892
7893 2019-05-04  Tom Tromey  <tom@tromey.com>
7894
7895         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
7896         * command.h (valid_user_defined_cmd_name_p): Channge return type.
7897
7898 2019-05-04  Raul Tambre  <raul@tambre.ee>
7899
7900         * python/lib/gdb/prompt.py (_ExtendedPrompt)
7901         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
7902         operator for comparison.
7903
7904 2019-05-04  Tom Tromey  <tom@tromey.com>
7905
7906         * psymtab.c (psymbol_name_matches, match_partial_symbol)
7907         (lookup_partial_symbol, print_partial_symbols)
7908         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
7909         (psymbol_compare): Update.
7910         (add_psymbol_to_bcache): Clear the entire psymbol.
7911         (maintenance_check_psymtabs): Update.
7912         * psympriv.h (struct partial_symbol): Don't derive from
7913         general_symbol_info.
7914         <obj_section, unrelocated_address, address,
7915         set_unrelocated_address>: Update.
7916         <ginfo>: New member.
7917         * dwarf-index-write.c (write_psymbols, debug_names::insert)
7918         (debug_names::write_psymbols): Update.
7919
7920 2019-05-04  Tom de Vries  <tdevries@suse.de>
7921
7922         * contrib/cc-with-tweaks.sh: Support -n arg.
7923
7924 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7925
7926         * corelow.c (core_target::detach): Ensure frame cache and
7927         register caches are cleared.
7928         inferior.c (exit_inferior_1): Likewise.
7929
7930 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
7931             Tom Tromey  <tom@tromey.com>
7932
7933         * dictionary.c (collate_pending_symbols_by_language): Remove
7934         "struct" from foreach.
7935         * symtab.c (lookup_global_symbol_from_objfile)
7936         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
7937         foreach.
7938         * ser-tcp.c (net_open): Remove "struct" from foreach.
7939         * objfiles.c (objfile_relocate, objfile_rebase)
7940         (objfile_has_symbols): Remove "struct" from foreach.
7941         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
7942         from foreach.
7943         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
7944         foreach.
7945         * darwin-nat.c (thread_info_from_private_thread_info): Remove
7946         "struct" from foreach.
7947         * ada-lang.c (create_excep_cond_exprs)
7948         (ada_exception_catchpoint_cond_string): Remove "struct" from
7949         foreach.
7950
7951 2019-05-03  Tom Tromey  <tromey@adacore.com>
7952
7953         * ada-exp.y (convert_char_literal): Check suffix of each
7954         enumerator.
7955
7956 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
7957
7958         PR ada/21406:
7959         * ada-exp.y (yywrap): Don't define.
7960         * ada-lex.l (%option): Add noyywrap
7961         (yywrap): Remove.
7962
7963 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
7964
7965         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
7966         _WIN32_WINNT to the XP level, unless already defined to a higher
7967         level.
7968
7969         * unittests/parse-connection-spec-selftests.c:
7970         * ser-tcp.c:
7971         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
7972         override.
7973
7974         * symfile.c (find_separate_debug_file): Remove colon from the
7975         drive spec of DOS/Windows file names of the target, so that the
7976         file name produced from DEBUGDIR and the target's directory will
7977         be valid on DOS/Windows systems.
7978
7979 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
7980
7981         * rust-lang.c (val_print_struct): Handle printing structures
7982         containing strings.
7983
7984 2019-05-02  Tom Tromey  <tromey@adacore.com>
7985
7986         * valarith.c (_initialize_valarith): Remove.
7987
7988 2019-05-01  Tom Tromey  <tromey@adacore.com>
7989
7990         * ada-lang.c (ada_value_primitive_field): Treat more fields as
7991         bitfields.
7992
7993 2019-05-01  Tom Tromey  <tromey@adacore.com>
7994
7995         * ada-lang.c (ada_value_assign): Correctly compute starting offset
7996         for big-endian copies.
7997
7998 2019-04-30  Ali Tamur  <tamur@google.com>
7999         * gdb/dwarf2read.c (read_3_bytes): New declaration.
8000         (read_attribute_value): Added DW_FORM_strx1-4 cases.
8001         (read_3_bytes): New function.
8002
8003 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
8004
8005         * windows-nat.c (main_thread_id): Delete.
8006         (handle_output_debug_string): Replace main_thread_id by
8007         current_event.dwThreadId.
8008         (fake_create_process): Likewise.
8009         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
8010         Do not set main_thread_id.
8011         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
8012         current_event.dwThreadId.
8013         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
8014
8015 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
8016
8017         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
8018         Use current_event.dwThreadId instead of main_thread_id.
8019
8020 2019-04-30  Tom Tromey  <tromey@adacore.com>
8021
8022         * ada-lang.c (ada_lookup_simple_minsyms): New function.
8023         (create_excep_cond_exprs): Iterate over program spaces.
8024         (ada_exception_catchpoint_cond_string): Examine all minimal
8025         symbols for exception types.
8026
8027 2019-04-30  Tom Tromey  <tromey@adacore.com>
8028
8029         PR c++/24470:
8030         * dwarf2read.c (process_structure_scope): Handle case where type
8031         has template parameters but no symbol was created.
8032
8033 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8034             Chris January  <chris.january@arm.com>
8035
8036         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
8037         qualifier.
8038         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
8039
8040 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8041
8042         * f-typeprint.c (f_print_type): Update rules for printing
8043         whitespace.
8044         (f_type_print_varspec_suffix): Likewise.
8045
8046 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8047             Chris January  <chris.january@arm.com>
8048
8049         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
8050         function arguments.
8051
8052 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8053
8054         * f-lang.c (build_fortran_types): Change name of void type to
8055         lower case.
8056         * f-typeprint.c (f_type_print_base): Print the name of the void
8057         type, rather than a fixed string.
8058         * f-valprint.c (f_decorations): Use lower case void string.
8059
8060 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8061             Chris January  <chris.january@arm.com>
8062
8063         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
8064         types for Fortran.
8065
8066 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8067             Chris January  <chris.january@arm.com>
8068             David Lecomber  <david.lecomber@arm.com>
8069
8070         * f-exp.y (BINOP_INTRINSIC): New token.
8071         (exp): New parser rule handling BINOP_INTRINSIC.
8072         (f77_keywords): Add new builtin procedures.
8073         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
8074         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
8075         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
8076         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
8077         (print_unop_subexp_f): New function.
8078         (print_binop_subexp_f): New function.
8079         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
8080         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
8081         (dump_subexp_body_f): Likewise.
8082         (operator_check_f): Likewise.
8083         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
8084         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
8085
8086 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8087
8088         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
8089         UNOP_KIND.
8090         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
8091         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
8092         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
8093         (operator_length_f): New fuction.
8094         (print_subexp_f): New function.
8095         (op_name_f): New function.
8096         (dump_subexp_body_f): New function.
8097         (operator_check_f): New function.
8098         (exp_descriptor_f): Replace standard expression handling functions
8099         with new functions.
8100         * gdb/fortran-operator.def: New file.
8101         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
8102         * gdb/std-operator.def: Remove UNOP_KIND.
8103
8104 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8105
8106         * std-operator.def: Remove unbalanced, stray double quote
8107         character.
8108
8109 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
8110             Chris January  <chris.january@arm.com>
8111             Daniel Everett  <daniel.everett@arm.com>
8112             Nick Forrington  <nick.forrington@arm.com>
8113             Richard Bunt  <richard.bunt@arm.com>
8114
8115         * cp-valprint.c (cp_print_value_fields): Allow an additional level
8116         of depth when printing anonymous structs or unions.
8117         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
8118         Don't print either the top-level value, or the children if the
8119         max-depth is exceeded.
8120         (ppscm_print_children): When printing the key of a map, allow one
8121         extra level of depth.
8122         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
8123         print either the top-level value, or the children if the max-depth
8124         is exceeded.
8125         (print_children): When printing the key of a map, allow one extra
8126         level of depth.
8127         * python/py-value.c (valpy_format_string): Add max_depth keyword.
8128         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
8129         (user_print_options): Initialise max_depth field.
8130         (val_print_scalar_or_string_type_p): New function.
8131         (val_print): Check to see if the max depth has been reached.
8132         (val_print_check_max_depth): Define new function.
8133         (show_print_max_depth): New function.
8134         (_initialize_valprint): Add 'print max-depth' option.
8135         * valprint.h (struct value_print_options) <max_depth>: New field.
8136         (val_print_check_max_depth): Declare new function.
8137         * NEWS: Document new feature.
8138
8139 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
8140
8141         * ada-lang.c (ada_language_defn): Initialise new field.
8142         * c-lang.c (c_is_string_type_p): New function.
8143         (c_language_defn): Initialise new field.
8144         (cplus_language_defn): Initialise new field.
8145         (asm_language_defn): Initialise new field.
8146         (minimal_language_defn): Initialise new field.
8147         * c-lang.h (c_is_string_type_p): Declare new function.
8148         * d-lang.c (d_language_defn): Initialise new field.
8149         * f-lang.c (f_is_string_type_p): New function.
8150         (f_language_defn): Initialise new field.
8151         * go-lang.c (go_is_string_type_p): New function.
8152         (go_language_defn): Initialise new field.
8153         * language.c (default_is_string_type_p): New function.
8154         (unknown_language_defn): Initialise new field.
8155         (auto_language_defn): Initialise new field.
8156         * language.h (struct language_defn) <la_is_string_type_p>: New
8157         member variable.
8158         (default_is_string_type_p): Declare new function.
8159         * m2-lang.c (m2_language_defn): Initialise new field.
8160         * objc-lang.c (objc_language_defn): Initialise new field.
8161         * opencl-lang.c (opencl_language_defn): Initialise new field.
8162         * p-lang.c (pascal_is_string_type_p): New function.
8163         (pascal_language_defn): Initialise new field.
8164         * rust-lang.c (rust_is_string_type_p): New function.
8165         (rust_language_defn): Initialise new field.
8166
8167 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
8168
8169         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
8170         New field.
8171         * ada-lang.c (ada_language_defn): Initialise new field.
8172         * c-lang.c (c_language_defn): Likewise.
8173         (cplus_language_defn): Likewise.
8174         (asm_language_defn): Likewise.
8175         (minimal_language_defn): Likewise.
8176         * d-lang.c (d_language_defn): Likewise.
8177         * f-lang.c (f_language_defn): Likewise.
8178         * go-lang.c (go_language_defn): Likewise.
8179         * language.c (unknown_language_defn): Likewise.
8180         (auto_language_defn): Likewise.
8181         * m2-lang.c (m2_language_defn): Likewise.
8182         * objc-lang.c (objc_language_defn): Likewise.
8183         * opencl-lang.c (opencl_language_defn): Likewise.
8184         * p-lang.c (pascal_language_defn): Likewise.
8185         * rust-lang.c (rust_language_defn): Likewise.
8186
8187 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
8188
8189         * ada-lang.c (ada_is_character_type): Change return type to bool.
8190         (ada_is_string_type): Likewise.
8191         * ada-lang.h (ada_is_character_type): Update declaration
8192         (ada_is_string_type): Likewise.
8193
8194 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8195
8196         Support style in 'frame|thread apply'
8197
8198         * gdbcmd.h (execute_command_to_string): New term_out parameter.
8199         * record.c (record_start, record_stop): Update callers of
8200         execute_command_to_string with false.
8201         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
8202         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
8203         methods.
8204         (class string_file): New constructor with term_out parameter.
8205         Override methods term_out and can_emit_style_escape.  New member
8206         term_out.
8207         (class stdio_file): Override can_emit_style_escape.
8208         (class tee_file): Override term_out and can_emit_style_escape.
8209         * utils.h (can_emit_style_escape): Remove.
8210         * utils.c (can_emit_style_escape): Likewise.
8211         Update all callers of can_emit_style_escape (SOMESTREAM) to
8212         SOMESTREAM->can_emit_style_escape.
8213         * source-cache.c (source_cache::get_source_lines): Likewise.
8214         * stack.c (frame_apply_command_count): Call execute_command_to_string
8215         passing the term_out characteristic of the current gdb_stdout.
8216         * thread.c (thr_try_catch_cmd): Likewise.
8217         * top.c (execute_command_to_string): pass term_out parameter
8218         to construct the string_file for the command output.
8219         * ui-file.c (term_cli_styling): New function (most code moved
8220         from utils.c can_emit_style_escape).
8221         (string_file::string_file, string_file::can_emit_style_escape,
8222         stdio_file::can_emit_style_escape, tee_file::term_out,
8223         tee_file::can_emit_style_escape): New functions.
8224
8225 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8226
8227         * NEWS: Mention the new set|show may-call-functions.
8228         * infcall.c (may_call_functions_p): New variable.
8229         (show_may_call_functions_p): New function.
8230         (call_function_by_hand_dummy): Throws an error if not
8231         may-call-functions.
8232         (_initialize_infcall): Call add_setshow_boolean_cmd for
8233         may-call-functions.
8234
8235 2019-04-25  Keith Seitz  <keiths@redhat.com>
8236
8237         PR c++/24367
8238         * cp-support.c (inspect_type): Don't attempt substitutions
8239         of symbol with the same name.
8240
8241 2019-04-25  Tom Tromey  <tromey@adacore.com>
8242
8243         PR gdb/24475:
8244         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
8245         static.
8246
8247 2019-04-25  Tom Tromey  <tromey@adacore.com>
8248
8249         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
8250         rvalue reference.
8251         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
8252         (gdb_xml_parser::parse): Use std::move.
8253         * python/python-internal.h (gdbpy_convert_exception): Take a const
8254         reference.
8255         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
8256         std::move.
8257         * python/py-utils.c (gdbpy_convert_exception): Take a const
8258         reference.
8259         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
8260         Use std::move.
8261         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
8262         Use std::move.
8263         * mi/mi-main.c (mi_print_exception): Take a const reference.
8264         * main.c (handle_command_errors): Take a const reference.
8265         * linespec.c (parse_linespec): Use std::move.
8266         * infcall.c (run_inferior_call): Use std::move.
8267         (call_function_by_hand_dummy): Use std::move.
8268         * exec.c (try_open_exec_file): Use std::move.
8269         * exceptions.h (exception_print, exception_fprintf)
8270         (exception_print_same): Update.
8271         * exceptions.c (print_exception, exception_print)
8272         (exception_fprintf, exception_print_same): Change parameters to
8273         const reference.
8274         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
8275         * common/new-op.c: Use std::move.
8276         * common/common-exceptions.h (struct gdb_exception): Add move
8277         constructor.
8278         (struct gdb_exception_error, struct gdb_exception_quit, struct
8279         gdb_quit_bad_alloc): Change constructor to move constructor.
8280         (throw_exception): Change parameter to rvalue reference.
8281         * common/common-exceptions.c (throw_exception): Take rvalue
8282         reference.
8283         * cli/cli-interp.c (safe_execute_command): Use std::move.
8284         * breakpoint.c (insert_bp_location, location_to_sals): Use
8285         std::move.
8286
8287 2019-04-25  Tom Tromey  <tromey@adacore.com>
8288
8289         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
8290         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
8291         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
8292         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
8293         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
8294         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
8295         guile/scm-value.c: Use unpack.
8296         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
8297         gdbscm_gdb_exception.
8298         (gdbscm_throw_gdb_exception): Likewise.
8299         (struct gdbscm_gdb_exception): New.
8300         (unpack): New function.
8301         (gdbscm_wrap): Use unpack.
8302
8303 2019-04-25  Tom Tromey  <tromey@adacore.com>
8304
8305         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
8306         (gdb_rl_callback_handler): Use std::move.
8307         * common/common-exceptions.h (struct gdb_exception): Add move
8308         assignment operator.
8309         (throw_exception_sjlj): Change "exception" to const reference.
8310         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
8311         (throw_exception_sjlj): Change "exception" to const reference.
8312
8313 2019-04-25  Tom Tromey  <tromey@adacore.com>
8314
8315         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
8316         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
8317         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
8318         Update.
8319         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
8320         Update.
8321         * mi/mi-interp.c (mi_interp::exec): Update.
8322         * linespec.c (parse_linespec): Update.
8323         * infcall.c (run_inferior_call): Update.
8324         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
8325         * guile/scm-symbol.c (gdbscm_lookup_symbol)
8326         (gdbscm_lookup_global_symbol): Update.
8327         * guile/scm-param.c (gdbscm_parameter_value): Update.
8328         * guile/scm-frame.c (gdbscm_frame_read_register)
8329         (gdbscm_frame_read_var): Update.
8330         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
8331         * exec.c (try_open_exec_file): Update.
8332         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
8333         (gdb_rl_callback_handler): Update.
8334         * common/common-exceptions.h (exception_none): Don't declare.
8335         * common/common-exceptions.c (exception_none): Don't define.
8336         (struct catcher) <exception>: Update.
8337         * cli/cli-interp.c (safe_execute_command): Update.
8338         * breakpoint.c (insert_bp_location, location_to_sals): Update.
8339
8340 2019-04-25  Ali Tamur  <tamur@google.com>
8341
8342         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
8343         (read_attribute_value): Likewise.
8344         (dwarf2_read_addr_index): Update comment.
8345         (read_str_index): Add DW_FORM_strx.
8346         (dwarf2_string_attr): Likewise.
8347         (dwarf2_const_value_attr): Likewise.
8348         (dump_die_shallow): Likewise.
8349         (dwarf2_fetch_constant_bytes): Likewise.
8350         (skip_form_bytes): Likewise.
8351         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
8352
8353 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
8354
8355         PR corefiles/11608
8356         PR corefiles/18187
8357         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
8358         OFFSET.  Verify if current mapping contains an ELF header.
8359         (linux_find_memory_regions_full): Adjust call to
8360         dump_mapping_p.
8361
8362 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
8363             Kang Li <kanglictf@gmail.com>
8364
8365         PR gdb/21600
8366
8367         * dwarf2-frame.c (read_initial_length): Be consistent about using
8368         unsigned representation of length.
8369         (decode_frame_entry_1): Likewise.  Check for wraparound of
8370         end pointer as well as buffer overflow.
8371
8372 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
8373
8374         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
8375         "vq".
8376
8377 2019-04-24  Tom Tromey  <tromey@adacore.com>
8378
8379         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
8380
8381 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8382
8383         * s12z-tdep.c (s12z_unwind_pc): Delete.
8384         (s12z_unwind_sp): Delete.
8385         (s12z_gdbarch_init): Don't register deleted functions with
8386         gdbarch.
8387
8388 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8389
8390         * rl78-tdep.c (rl78_unwind_sp): Delete.
8391         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
8392
8393 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8394
8395         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
8396         (xstormy16_unwind_pc): Delete.
8397         (xstormy16_dummy_id): Delete.
8398         (xstormy16_gdbarch_init): Don't register deleted functions with
8399         gdbarch.
8400
8401 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8402
8403         * vax-tdep.c (vax_unwind_pc): Delete.
8404         (vax_gdbarch_init): Don't register deleted function with gdbarch.
8405
8406 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8407
8408         * v850-tdep.c (v850_unwind_sp): Delete.
8409         (v850_unwind_pc): Delete.
8410         (v850_dummy_id): Delete.
8411         (v850_gdbarch_init): Don't register deleted functions with
8412         gdbarch.
8413
8414 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8415
8416         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
8417         (tilegx_unwind_pc): Delete.
8418         (tilegx_unwind_dummy_id): Delete.
8419         (tilegx_gdbarch_init): Don't register deleted functions with
8420         gdbarch.
8421
8422 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8423
8424         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
8425         (tic6x_dummy_id): Delete.
8426         (tic6x_gdbarch_init): Don't register deleted functions with
8427         gdbarch.
8428
8429 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8430
8431         * sparc-tdep.c (sparc_unwind_pc): Delete.
8432         (sparc32_gdbarch_init): Don't register deleted function with
8433         gdbarch.
8434
8435 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8436
8437         * sh-tdep.c (sh_unwind_sp): Delete.
8438         (sh_unwind_pc): Delete.
8439         (sh_dummy_id): Delete.
8440         (sh_gdbarch_init): Don't register deleted functions with
8441         gdbarch.
8442
8443 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8444
8445         * score-tdep.c (score_unwind_sp): Delete.
8446         (score_unwind_pc): Delete.
8447         (score_dummy_id): Delete.
8448         (score_gdbarch_init): Don't register deleted functions with
8449         gdbarch.
8450
8451 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8452
8453         * rx-tdep.c (rx_unwind_pc): Delete.
8454         (rx_unwind_sp): Delete.
8455         (rx_dummy_id): Delete.
8456         (rx_gdbarch_init): Don't register deleted functions with
8457         gdbarch.  Update comment.
8458
8459 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8460
8461         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
8462         (rs6000_dummy_id): Delete.
8463         (rs6000_gdbarch_init): Don't register deleted functions with
8464         gdbarch.
8465
8466 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8467
8468         * or1k-tdep.c (or1k_dummy_id): Delete.
8469         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
8470
8471 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8472
8473         * nios2-tdep.c (nios2_dummy_id): Delete.
8474         (nios2_unwind_sp): Delete.
8475         (nios2_gdbarch_init): Don't register deleted functions with
8476         gdbarch.
8477
8478 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8479
8480         * nds32-tdep.c (nds32_dummy_id): Delete.
8481         (nds32_unwind_pc): Delete.
8482         (nds32_unwind_sp): Delete.
8483         (nds32_gdbarch_init): Don't register deleted functions with
8484         gdbarch.
8485
8486 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8487
8488         * msp430-tdep.c (msp430_unwind_pc): Delete.
8489         (msp430_unwind_sp): Delete.
8490         (msp430_dummy_id): Delete.
8491         (msp430_gdbarch_init): Don't register deleted functions with
8492         gdbarch.
8493
8494 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8495
8496         * moxie-tdep.c (moxie_unwind_sp): Delete.
8497         (moxie_unwind_pc): Delete.
8498         (moxie_dummy_id): Delete.
8499         (moxie_gdbarch_init): Don't register deleted functions with
8500         gdbarch.
8501
8502 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8503
8504         * mn10300-tdep.c (mn10300_dummy_id): Delete.
8505         (mn10300_unwind_pc): Delete.
8506         (mn10300_unwind_sp): Delete.
8507         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
8508         mn10300_unwind_sp.
8509         (mn10300_frame_unwind_init): Don't register deleted functions with
8510         gdbarch.
8511
8512 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8513
8514         * mep-tdep.c (mep_unwind_pc): Delete.
8515         (mep_unwind_sp): Delete.
8516         (mep_dummy_id): Delete.
8517         (mep_gdbarch_init): Don't register deleted functions with
8518         gdbarch.
8519
8520 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8521
8522         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
8523         (m68hc11_unwind_sp): Delete.
8524         (m68hc11_gdbarch_init): Don't register deleted functions with
8525         gdbarch.
8526
8527 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8528
8529         * m32r-tdep.c (m32r_unwind_sp): Delete.
8530         (m32r_unwind_pc): Delete.
8531         (m32r_dummy_id): Delete.
8532         (m32r_gdbarch_init): Don't register deleted functions with
8533         gdbarch.
8534
8535 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8536
8537         * m32c-tdep.c (m32c_unwind_pc): Delete.
8538         (m32c_unwind_sp): Delete.
8539         (m32c_dummy_id): Delete.
8540         (m32c_gdbarch_init): Don't register deleted functions with
8541         gdbarch.
8542
8543 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8544
8545         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
8546         (lm32_unwind_pc): Delete.
8547         (lm32_dummy_id): Delete.
8548         (lm32_gdbarch_init): Don't register deleted functions with
8549         gdbarch.
8550
8551 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8552
8553         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
8554         (iq2000_unwind_pc): Delete.
8555         (iq2000_dummy_id): Delete.
8556         (iq2000_gdbarch_init): Don't register deleted functions with
8557         gdbarch.
8558
8559 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8560
8561         * nds32-tdep.c (nds32_type_align): Delete.
8562         (nds32_push_dummy_call): Use type_align instead.
8563
8564 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8565
8566         * arm-tdep.c (arm_type_align): Only handle vector override case.
8567         (arm_push_dummy_call): Use type_align.
8568         (arm_gdbarch_init): Register arm_type_align gdbarch function.
8569
8570 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8571
8572         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
8573         case.
8574         (pass_on_stack): Use type_align.
8575         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
8576         function.
8577
8578 2019-04-23  Tom Tromey  <tromey@adacore.com>
8579
8580         * dwarf2read.c (line_header::file_name_at): Remove unused
8581         overload.
8582
8583 2019-04-23  Tom de Vries  <tdevries@suse.de>
8584
8585         PR gdb/24438
8586         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
8587         invocation.
8588
8589
8590 2019-03-27  Ali Tamur  <tamur@google.com>
8591
8592         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
8593         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
8594         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
8595         (dwarf_expr_context::get_addr_index): Likewise
8596         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
8597         (symbol_needs_eval_context::get_addr_index): Likewise
8598         (disassemble_dwarf_expression): Add DW_OP_addrx
8599         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
8600         (read_cutu_die_from_dwo): Update comment
8601         (skip_one_die): Add DW_FORM_addrx
8602         (read_attribute_value): Likewise
8603         (var_decode_location): Add DW_OP_addrx
8604         (dwarf2_const_value_attr): Add DW_FORM_addrx
8605         (dump_die_shallow): Likewise
8606         (dwarf2_fetch_constant_bytes): Likewise
8607         (decode_locdesc): Add DW_OP_addrx
8608         (skip_form_bytes): Add DW_FORM_addrx
8609
8610 2019-04-22  Ali Tamur  <tamur@google.com>
8611
8612         * MAINTAINERS (Write After Approval): Add self.
8613
8614 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
8615
8616         * solib-svr4.c (get_svr4_info): Add pspace parameter.
8617         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
8618         (open_symbol_file_object): Likewise.
8619         (svr4_default_sos): Add info parameter.
8620         (svr4_read_so_list): Likewise.
8621         (svr4_current_sos_direct): Adjust functions calls to pass down
8622         info.
8623         (svr4_current_sos_1): Add info parameter.
8624         (svr4_current_sos): Call get_svr4_info, pass info down to
8625         svr4_current_sos_1.
8626         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
8627         get_svr4_info.
8628         (svr4_in_dynsym_resolve_code): Pass current_program_space to
8629         get_svr4_info.
8630         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
8631         to get_svr4_info.
8632         (probes_table_remove_objfile_probes): Likewise.
8633         (register_solib_event_probe): Add info parameter.
8634         (solist_update_incremental): Pass info parameter down to
8635         svr4_read_so_list.
8636         (disable_probes_interface): Add info parameter.
8637         (svr4_handle_solib_event): Pass current_program_space to
8638         get_svr4_info.  Adjust disable_probes_interface cleanup.
8639         (svr4_create_probe_breakpoints): Add info parameter, pass it
8640         down to register_solib_event_probe.
8641         (svr4_create_solib_event_breakpoints): Add info parameter,
8642         pass it down to svr4_create_probe_breakpoints.
8643         (enable_break): Pass info down to
8644         svr4_create_solib_event_breakpoints.
8645         (svr4_solib_create_inferior_hook): Pass current_program_space to
8646         get_svr4_info.
8647         (svr4_clear_solib): Likewise.
8648
8649 2019-04-22  Pedro Alves  <palves@redhat.com>
8650
8651         * solib-svr4.c (svr4_free_objfile_observer): New.
8652         (probe_and_action::objfile): New field.
8653         (probes_table_htab_remove_objfile_probes)
8654         (probes_table_remove_objfile_probes): New functions.
8655         (register_solib_event_probe): Add 'objfile' parameter.  Store it
8656         in the new probe_and_action.  Don't store the probe in 'lookup'.
8657         (svr4_create_probe_breakpoints): Pass objfile to
8658         register_solib_event_probe.
8659         (_initialize_svr4_solib): Register a free_objfile observer.
8660
8661 2019-04-19  Tom Tromey  <tom@tromey.com>
8662
8663         * common/queue.h: Remove.
8664
8665 2019-04-19  Tom Tromey  <tom@tromey.com>
8666
8667         * event-loop.c: Don't include "common/queue.h".
8668
8669 2019-04-19  Tom Tromey  <tom@tromey.com>
8670
8671         * remote.c (remote_target): Use delete.
8672         * remote-notif.h: Include <list>, not "common/queue.h".
8673         (notif_client_p): Remove typedef.
8674         (remote_notif_state): Add constructor, destructor, initializer.
8675         <notif_queue>: Now a std::list.
8676         (remote_notif_state_xfree): Don't declare.
8677         * remote-notif.c (remote_notif_process, handle_notification)
8678         (remote_notif_state_allocate): Update.
8679         (~remote_notif_state): Rename from remote_notif_state_xfree.
8680
8681 2019-04-19  Tom Tromey  <tom@tromey.com>
8682
8683         * symfile.c (reread_symbols): Update.
8684         * objfiles.c (objfile_register_static_link)
8685         (objfile_lookup_static_link): Update
8686         (~objfile) Don't delete static_links.
8687         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
8688
8689 2019-04-19  Tom Tromey  <tom@tromey.com>
8690
8691         * type-stack.h (struct type_stack) <insert>: Constify string.
8692         * type-stack.c (type_stack::insert): Constify string.
8693         * gdbtypes.h (lookup_template_type): Update.
8694         (address_space_name_to_int): Update.
8695         * gdbtypes.c (address_space_name_to_int): Make space_identifier
8696         const.
8697         (lookup_template_type): Make name const.
8698         * c-exp.y: Update rules.
8699         (lex_one_token, classify_name, classify_inner_name)
8700         (c_print_token): Update.
8701         * p-exp.y: Update rules.
8702         (yylex): Update.
8703         * f-exp.y: Update rules.
8704         (yylex): Update.
8705         * d-exp.y: Update rules.
8706         (lex_one_token, classify_name, classify_inner_name): Update.
8707         * parse.c (write_dollar_variable, copy_name): Return std::string.
8708         * parser-defs.h (copy_name): Change return type.
8709         * m2-exp.y: Update rules.
8710         (yylex): Update.
8711         * go-exp.y (lex_one_token): Update.
8712         Update rules.
8713         (classify_unsafe_function, classify_packaged_name)
8714         (classify_name, yylex): Update.
8715
8716 2019-04-19  Sergei Trofimovich <siarheit@google.com>
8717
8718         * configure.ac: add --enable-source-highlight switch.
8719         * configure: Regenerate.
8720         * top.c (print_gdb_version): plumb --enable-source-highlight
8721         status to "show configuration".
8722
8723 2019-04-19  Tom Tromey  <tromey@adacore.com>
8724
8725         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
8726         Check ADA_TYPE_P.
8727         (empty_record, ada_template_to_fixed_record_type_1)
8728         (template_to_static_fixed_type)
8729         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
8730         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
8731         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
8732         macros.
8733
8734 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
8735
8736         PR symtab/24423:
8737         * source.c (print_source_lines_base): Advance "iter" when a
8738         control character is seen.
8739
8740 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8741
8742         * inferior.h (struct infcall_suspend_state_deleter):
8743         Catch exception in destructor to avoid crash.
8744
8745 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8746
8747         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
8748         close to the add_com "shell".
8749
8750 2019-04-18  Tom Tromey  <tromey@adacore.com>
8751
8752         * process-stratum-target.h (class process_stratum_target)
8753         <stratum>: Add "final".
8754
8755 2019-04-17  Tom Tromey  <tromey@adacore.com>
8756
8757         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
8758         against nullptr before use.
8759
8760 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
8761
8762         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
8763
8764 2019-04-17  Jim Wilson  <jimw@sifive.com>
8765             Andrew Burgess  <andrew.burgess@embecosm.com>
8766
8767         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
8768         code read might fail, assume 4-byte breakpoint in that case.
8769
8770 2019-04-15  Leszek Swirski  <leszeks@google.com>
8771
8772         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
8773         rather than a hand-rolled POD check when checking for forced MEMORY
8774         classification.
8775
8776 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
8777
8778         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
8779         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
8780         function.
8781         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
8782         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
8783         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
8784         declaration.
8785
8786 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
8787
8788         * aarch64-linux-nat.c
8789         (aarch64_linux_nat_target::thread_architecture): Add override.
8790         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
8791         each VQ.
8792
8793 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
8794
8795         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
8796
8797 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
8798
8799         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
8800         target types of size 96-bits, add some additional comments, and
8801         check that the builtin type we found was the correct size.
8802
8803 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
8804
8805         * utils.c (prompt_for_continue): Don't restore the styling at the
8806         end, as applied_style has the wrong value.  This fixes styling in
8807         long lists of file names that are interrupted by the "Continue?"
8808         prompt.
8809
8810 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
8811
8812         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
8813         * c-lang.c (c_language_defn): Likewise.
8814         (cplus_language_defn): Likewise.
8815         (asm_language_defn): Likewise.
8816         (minimal_language_defn): Likewise.
8817         * d-lang.c (d_language_defn): Likewise.
8818         * f-lang.c (f_language_defn): Likewise.
8819         * go-lang.c (go_language_defn): Likewise.
8820         * language.c (unknown_language_defn): Likewise.
8821         (auto_language_defn): Likewise.
8822         * language.h (struct language_defn): Remove la_magic field.
8823         (LANG_MAGIC): Delete.
8824         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
8825         * objc-lang.c (objc_language_defn): Likewise.
8826         * opencl-lang.c (opencl_language_defn): Likewise.
8827         * p-lang.c (pascal_language_defn): Likewise.
8828         * rust-lang.c (rust_language_defn): Likewise.
8829
8830 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
8831
8832         * riscv-tdep.c (riscv_type_align): New function.
8833         (riscv_type_alignment): Delete.
8834         (riscv_arg_location): Use 'type_align'.
8835         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
8836
8837 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
8838
8839         * gdbtypes.c (type_align): A struct with no non-static fields also
8840         has alignment of 1.
8841
8842 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
8843
8844         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
8845         component to 0.
8846         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
8847         member.
8848         (riscv_struct_info::analyse): New implementation using new
8849         analyse_inner member function.
8850         (riscv_struct_info::field_offset): New member function.
8851         (riscv_struct_info::m_offsets): New member variable.
8852         (riscv_struct_info::analyse_inner): New private member function,
8853         takes the old implementation of riscv_struct_info::analyse but
8854         extended to track field offsets.
8855         (riscv_call_arg_struct): Update the struct folding special cases
8856         to handle cases where empty C++ structs, which are non-zero
8857         length, are found.
8858         (riscv_arg_location): Initialise the length of each location, a
8859         non-zero length now indicates the location is in use.
8860         (riscv_push_dummy_call): Allow for the first location having a
8861         non-zero offset when setting up arguments.
8862         (riscv_return_value): Likewise, but for return values.
8863
8864 2019-04-11  Tom Tromey  <tromey@adacore.com>
8865
8866         * utils.c (internal_vproblem): Make "msg" const.
8867
8868 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
8869
8870         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
8871         * trad-frame.c (trad_frame_reset_saved_regs): New function.
8872         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
8873         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
8874
8875 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
8876
8877         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
8878         function.
8879         (fill_gregset): Call amd64_linux_collect_native_gregset instead
8880         of amd64_collect_native_gregset.
8881         (amd64_linux_nat_target::store_registers): Likewise.
8882
8883 2019-04-10  Tom Tromey  <tom@tromey.com>
8884
8885         * symtab.c (lookup_global_symbol_from_objfile)
8886         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
8887         * objfiles.h (class separate_debug_iterator): New.
8888         (class separate_debug_range): New.
8889         (struct objfile) <separate_debug_objfiles>: New method.
8890         (objfile_separate_debug_iterate): Don't declare.
8891         * objfiles.c (separate_debug_iterator::operator++): Rename from
8892         objfile_separate_debug_iterate.
8893         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
8894         iterator.
8895         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
8896         iterator.
8897
8898 2019-04-10  Tom Tromey  <tom@tromey.com>
8899
8900         * symfile.c (reread_symbols): Remove old comment.
8901         * objfiles.c (free_all_objfiles): Fix a typo.
8902
8903 2019-04-10  Tom Tromey  <tom@tromey.com>
8904
8905         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
8906         * minsyms.c (lookup_minimal_symbol): Use foreach.
8907         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
8908         (lookup_minimal_symbol_solib_trampoline): Likewise.
8909         * symfile.c (reread_symbols): Use foreach.
8910
8911 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
8912             Tom Tromey  <tromey@adacore.com>
8913
8914         PR rust/24414:
8915         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
8916         (rust_lex_int_test): Change "value" to be LONGEST.
8917         (rust_lex_tests): Add test for long integer literal.
8918
8919 2019-04-09  Tom Tromey  <tromey@adacore.com>
8920
8921         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
8922         to bool.
8923         (extended_remote_target::attach): Update.
8924         (remote_target::remote_notice_new_inferior): Update.
8925         (remote_target::add_current_inferior_and_thread): Update.
8926         * inferior.c (exit_inferior_1): Use "false".
8927         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
8928
8929 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
8930
8931         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
8932         the "start" command.
8933
8934 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
8935
8936         * python/py-inferior.c (infpy_thread_from_thread_handle):
8937         Adjust comments to reflect renaming of thread_from_thread_handle
8938         to thread_from_handle.  Adjust keywords.  Fix type error message.
8939         (inferior_object_methods): Add thread_from_handle.  Retain
8940         thread_from_thread_handle, but mark it as deprecated.
8941
8942 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
8943
8944         * gdbthread.h (find_thread_by_handle): Revise declaration.
8945         * thread.c (find_thread_by_handle): Likewise.  Adjust
8946         implementation too.
8947         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
8948         support for buffer objects as handles.
8949
8950 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
8951
8952         * python/py-infthread.c (thpy_thread_handle): New function.
8953         (thread_object_methods): Register thpy_thread_handle.
8954
8955 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
8956
8957         * gdbthread.h (thread_to_thread_handle): Declare.
8958         * thread.c (gdbtypes.h): Include.
8959         (thread_to_thread_handle): New function.
8960
8961         * target.h (struct target_ops): Add thread_info_to_thread_handle.
8962         (target_thread_info_to_thread_handle): Declare.
8963         * target.c (target_thread_info_to_thread_handle): New function.
8964         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
8965         * target-delegates.c: Regenerate.
8966
8967         * linux-thread-db.c (class thread_db_target): Add method
8968         thread_info_to_thread_handle.
8969         (thread_db_target::thread_info_to_thread_handle): Define.
8970         * remote.c (class remote_target): Add new method
8971         thread_info_to_thread_handle.
8972         (remote_target::thread_info_to_thread_handle): Define.
8973
8974 2019-04-08  Pedro Alves  <palves@redhat.com>
8975
8976         * common/common-exceptions.c (throw_exception): Don't create
8977         named object to throw; throw directly.
8978         (throw_it): Likewise.  Don't initialize gdb_exception::message
8979         here, with new; pass FMT and AP to the ctor instead.
8980         * common/common-exceptions.h: Include <string>.
8981         (gdb_exception::gdb_exception(enum return_reason, enum errors,
8982         const char *, va_list)): New ctor.  Use std::make_shared.
8983         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
8984         errors)): Delete.
8985         (gdb_exception_error::gdb_exception_error(enum errors, const char
8986         *, va_list)): New.
8987         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
8988         Add assertion.
8989         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
8990         errors)): Delete.
8991         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
8992         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
8993         Add assertion.
8994
8995 2019-04-08  Tom Tromey  <tom@tromey.com>
8996
8997         * valops.c (value_rtti_indirect_type): Replace throw_exception
8998         with throw.
8999         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
9000         with throw.
9001         * thread.c (thr_try_catch_cmd): Replace throw_exception with
9002         throw.
9003         * target.c (target_translate_tls_address): Replace throw_exception
9004         with throw.
9005         * stack.c (frame_apply_command_count): Replace throw_exception
9006         with throw.
9007         * solib-spu.c (append_ocl_sos): Replace throw_exception with
9008         throw.
9009         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
9010         with throw.
9011         * rs6000-tdep.c (rs6000_frame_cache)
9012         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
9013         * remote.c: Replace throw_exception with throw.
9014         * record-full.c (record_full_message, record_full_wait_1)
9015         (record_full_restore): Replace throw_exception with throw.
9016         * record-btrace.c:
9017         (get_thread_current_frame_id, record_btrace_start_replaying)
9018         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
9019         (cmd_record_btrace_start): Replace throw_exception with throw.
9020         * parse.c (parse_exp_in_context_1): Replace throw_exception with
9021         throw.
9022         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
9023         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
9024         * linespec.c:
9025         (find_linespec_symbols): Replace throw_exception with throw.
9026         * infrun.c (displaced_step_prepare, resume): Replace
9027         throw_exception with throw.
9028         * infcmd.c (post_create_inferior): Replace throw_exception with
9029         throw.
9030         * inf-loop.c (inferior_event_handler): Replace throw_exception
9031         with throw.
9032         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
9033         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
9034         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
9035         (get_prev_frame_always, get_frame_pc_if_available)
9036         (get_frame_address_in_block_if_available, get_frame_language):
9037         Replace throw_exception with throw.
9038         * frame-unwind.c (frame_unwind_try_unwinder): Replace
9039         throw_exception with throw.
9040         * eval.c (fetch_subexp_value, evaluate_var_value)
9041         (evaluate_funcall, evaluate_subexp_standard): Replace
9042         throw_exception with throw.
9043         * dwarf2loc.c (call_site_find_chain)
9044         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
9045         Replace throw_exception with throw.
9046         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
9047         with throw.
9048         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
9049         throw.
9050         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
9051         * completer.c (complete_line_internal): Replace throw_exception
9052         with throw.
9053         * compile/compile-object-run.c (compile_object_run): Replace
9054         throw_exception with throw.
9055         * cli/cli-script.c (process_next_line): Replace throw_exception
9056         with throw.
9057         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
9058         (btrace_enable, btrace_maint_update_pt_packets): Replace
9059         throw_exception with throw.
9060         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
9061         throw_exception with throw.
9062         * break-catch-throw.c (re_set_exception_catchpoint): Replace
9063         throw_exception with throw.
9064         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
9065         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
9066         * aarch64-tdep.c (aarch64_make_prologue_cache)
9067         (aarch64_make_stub_cache): Replace throw_exception with throw.
9068
9069 2019-04-08  Tom Tromey  <tom@tromey.com>
9070
9071         * common/common-exceptions.c (throw_exception): Rename from
9072         throw_exception_cxx.  Remove old copy.  Make argument const.
9073         (throw_it): Create and throw exception objects directly.
9074         * common/common-exceptions.h (throw_exception): Make argument
9075         const.
9076         (struct gdb_exception_error): Add constructor.
9077         (struct gdb_exception_quit): Add constructor.
9078
9079 2019-04-08  Tom Tromey  <tom@tromey.com>
9080
9081         * common/common-exceptions.h (exception_rethrow): Don't declare.
9082         (TRY_SJLJ): Update comment.
9083         (TRY, CATCH, END_CATCH): Remove.
9084         * common/common-exceptions.c (exception_rethrow): Remove.
9085
9086 2019-04-08  Tom Tromey  <tom@tromey.com>
9087
9088         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
9089         Remove.
9090         (gdb_exception_error): Rename from
9091         gdb_exception_RETURN_MASK_ERROR.
9092         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
9093         (gdb_quit_bad_alloc): Update.
9094         * aarch64-tdep.c: Update.
9095         * ada-lang.c: Update.
9096         * ada-typeprint.c: Update.
9097         * ada-valprint.c: Update.
9098         * amd64-tdep.c: Update.
9099         * arch-utils.c: Update.
9100         * break-catch-throw.c: Update.
9101         * breakpoint.c: Update.
9102         * btrace.c: Update.
9103         * c-varobj.c: Update.
9104         * cli/cli-cmds.c: Update.
9105         * cli/cli-interp.c: Update.
9106         * cli/cli-script.c: Update.
9107         * common/common-exceptions.c: Update.
9108         * common/new-op.c: Update.
9109         * common/selftest.c: Update.
9110         * compile/compile-c-symbols.c: Update.
9111         * compile/compile-cplus-symbols.c: Update.
9112         * compile/compile-object-load.c: Update.
9113         * compile/compile-object-run.c: Update.
9114         * completer.c: Update.
9115         * corelow.c: Update.
9116         * cp-abi.c: Update.
9117         * cp-support.c: Update.
9118         * cp-valprint.c: Update.
9119         * darwin-nat.c: Update.
9120         * disasm-selftests.c: Update.
9121         * dtrace-probe.c: Update.
9122         * dwarf-index-cache.c: Update.
9123         * dwarf-index-write.c: Update.
9124         * dwarf2-frame-tailcall.c: Update.
9125         * dwarf2-frame.c: Update.
9126         * dwarf2loc.c: Update.
9127         * dwarf2read.c: Update.
9128         * eval.c: Update.
9129         * event-loop.c: Update.
9130         * event-top.c: Update.
9131         * exec.c: Update.
9132         * f-valprint.c: Update.
9133         * fbsd-tdep.c: Update.
9134         * frame-unwind.c: Update.
9135         * frame.c: Update.
9136         * gdbtypes.c: Update.
9137         * gnu-v3-abi.c: Update.
9138         * guile/guile-internal.h: Update.
9139         * guile/scm-block.c: Update.
9140         * guile/scm-breakpoint.c: Update.
9141         * guile/scm-cmd.c: Update.
9142         * guile/scm-disasm.c: Update.
9143         * guile/scm-frame.c: Update.
9144         * guile/scm-lazy-string.c: Update.
9145         * guile/scm-math.c: Update.
9146         * guile/scm-param.c: Update.
9147         * guile/scm-ports.c: Update.
9148         * guile/scm-pretty-print.c: Update.
9149         * guile/scm-symbol.c: Update.
9150         * guile/scm-symtab.c: Update.
9151         * guile/scm-type.c: Update.
9152         * guile/scm-value.c: Update.
9153         * i386-linux-tdep.c: Update.
9154         * i386-tdep.c: Update.
9155         * inf-loop.c: Update.
9156         * infcall.c: Update.
9157         * infcmd.c: Update.
9158         * infrun.c: Update.
9159         * jit.c: Update.
9160         * language.c: Update.
9161         * linespec.c: Update.
9162         * linux-fork.c: Update.
9163         * linux-nat.c: Update.
9164         * linux-tdep.c: Update.
9165         * linux-thread-db.c: Update.
9166         * main.c: Update.
9167         * mi/mi-cmd-break.c: Update.
9168         * mi/mi-cmd-stack.c: Update.
9169         * mi/mi-interp.c: Update.
9170         * mi/mi-main.c: Update.
9171         * objc-lang.c: Update.
9172         * p-valprint.c: Update.
9173         * parse.c: Update.
9174         * ppc-linux-tdep.c: Update.
9175         * printcmd.c: Update.
9176         * python/py-arch.c: Update.
9177         * python/py-breakpoint.c: Update.
9178         * python/py-cmd.c: Update.
9179         * python/py-finishbreakpoint.c: Update.
9180         * python/py-frame.c: Update.
9181         * python/py-framefilter.c: Update.
9182         * python/py-gdb-readline.c: Update.
9183         * python/py-inferior.c: Update.
9184         * python/py-infthread.c: Update.
9185         * python/py-lazy-string.c: Update.
9186         * python/py-linetable.c: Update.
9187         * python/py-objfile.c: Update.
9188         * python/py-param.c: Update.
9189         * python/py-prettyprint.c: Update.
9190         * python/py-progspace.c: Update.
9191         * python/py-record-btrace.c: Update.
9192         * python/py-record.c: Update.
9193         * python/py-symbol.c: Update.
9194         * python/py-type.c: Update.
9195         * python/py-unwind.c: Update.
9196         * python/py-utils.c: Update.
9197         * python/py-value.c: Update.
9198         * python/python.c: Update.
9199         * record-btrace.c: Update.
9200         * record-full.c: Update.
9201         * remote-fileio.c: Update.
9202         * remote.c: Update.
9203         * riscv-tdep.c: Update.
9204         * rs6000-aix-tdep.c: Update.
9205         * rs6000-tdep.c: Update.
9206         * rust-exp.y: Update.
9207         * rust-lang.c: Update.
9208         * s390-tdep.c: Update.
9209         * selftest-arch.c: Update.
9210         * solib-dsbt.c: Update.
9211         * solib-frv.c: Update.
9212         * solib-spu.c: Update.
9213         * solib-svr4.c: Update.
9214         * solib.c: Update.
9215         * sparc64-linux-tdep.c: Update.
9216         * stack.c: Update.
9217         * symfile-mem.c: Update.
9218         * symmisc.c: Update.
9219         * target.c: Update.
9220         * thread.c: Update.
9221         * top.c: Update.
9222         * tracefile-tfile.c: Update.
9223         * tui/tui.c: Update.
9224         * typeprint.c: Update.
9225         * unittests/cli-utils-selftests.c: Update.
9226         * unittests/parse-connection-spec-selftests.c: Update.
9227         * valops.c: Update.
9228         * valprint.c: Update.
9229         * value.c: Update.
9230         * varobj.c: Update.
9231         * windows-nat.c: Update.
9232         * x86-linux-nat.c: Update.
9233         * xml-support.c: Update.
9234
9235 2019-04-08  Tom Tromey  <tom@tromey.com>
9236
9237         * xml-support.c: Use C++ exception handling.
9238         * x86-linux-nat.c: Use C++ exception handling.
9239         * windows-nat.c: Use C++ exception handling.
9240         * varobj.c: Use C++ exception handling.
9241         * value.c: Use C++ exception handling.
9242         * valprint.c: Use C++ exception handling.
9243         * valops.c: Use C++ exception handling.
9244         * unittests/parse-connection-spec-selftests.c: Use C++ exception
9245         handling.
9246         * unittests/cli-utils-selftests.c: Use C++ exception handling.
9247         * typeprint.c: Use C++ exception handling.
9248         * tui/tui.c: Use C++ exception handling.
9249         * tracefile-tfile.c: Use C++ exception handling.
9250         * top.c: Use C++ exception handling.
9251         * thread.c: Use C++ exception handling.
9252         * target.c: Use C++ exception handling.
9253         * symmisc.c: Use C++ exception handling.
9254         * symfile-mem.c: Use C++ exception handling.
9255         * stack.c: Use C++ exception handling.
9256         * sparc64-linux-tdep.c: Use C++ exception handling.
9257         * solib.c: Use C++ exception handling.
9258         * solib-svr4.c: Use C++ exception handling.
9259         * solib-spu.c: Use C++ exception handling.
9260         * solib-frv.c: Use C++ exception handling.
9261         * solib-dsbt.c: Use C++ exception handling.
9262         * selftest-arch.c: Use C++ exception handling.
9263         * s390-tdep.c: Use C++ exception handling.
9264         * rust-lang.c: Use C++ exception handling.
9265         * rust-exp.y: Use C++ exception handling.
9266         * rs6000-tdep.c: Use C++ exception handling.
9267         * rs6000-aix-tdep.c: Use C++ exception handling.
9268         * riscv-tdep.c: Use C++ exception handling.
9269         * remote.c: Use C++ exception handling.
9270         * remote-fileio.c: Use C++ exception handling.
9271         * record-full.c: Use C++ exception handling.
9272         * record-btrace.c: Use C++ exception handling.
9273         * python/python.c: Use C++ exception handling.
9274         * python/py-value.c: Use C++ exception handling.
9275         * python/py-utils.c: Use C++ exception handling.
9276         * python/py-unwind.c: Use C++ exception handling.
9277         * python/py-type.c: Use C++ exception handling.
9278         * python/py-symbol.c: Use C++ exception handling.
9279         * python/py-record.c: Use C++ exception handling.
9280         * python/py-record-btrace.c: Use C++ exception handling.
9281         * python/py-progspace.c: Use C++ exception handling.
9282         * python/py-prettyprint.c: Use C++ exception handling.
9283         * python/py-param.c: Use C++ exception handling.
9284         * python/py-objfile.c: Use C++ exception handling.
9285         * python/py-linetable.c: Use C++ exception handling.
9286         * python/py-lazy-string.c: Use C++ exception handling.
9287         * python/py-infthread.c: Use C++ exception handling.
9288         * python/py-inferior.c: Use C++ exception handling.
9289         * python/py-gdb-readline.c: Use C++ exception handling.
9290         * python/py-framefilter.c: Use C++ exception handling.
9291         * python/py-frame.c: Use C++ exception handling.
9292         * python/py-finishbreakpoint.c: Use C++ exception handling.
9293         * python/py-cmd.c: Use C++ exception handling.
9294         * python/py-breakpoint.c: Use C++ exception handling.
9295         * python/py-arch.c: Use C++ exception handling.
9296         * printcmd.c: Use C++ exception handling.
9297         * ppc-linux-tdep.c: Use C++ exception handling.
9298         * parse.c: Use C++ exception handling.
9299         * p-valprint.c: Use C++ exception handling.
9300         * objc-lang.c: Use C++ exception handling.
9301         * mi/mi-main.c: Use C++ exception handling.
9302         * mi/mi-interp.c: Use C++ exception handling.
9303         * mi/mi-cmd-stack.c: Use C++ exception handling.
9304         * mi/mi-cmd-break.c: Use C++ exception handling.
9305         * main.c: Use C++ exception handling.
9306         * linux-thread-db.c: Use C++ exception handling.
9307         * linux-tdep.c: Use C++ exception handling.
9308         * linux-nat.c: Use C++ exception handling.
9309         * linux-fork.c: Use C++ exception handling.
9310         * linespec.c: Use C++ exception handling.
9311         * language.c: Use C++ exception handling.
9312         * jit.c: Use C++ exception handling.
9313         * infrun.c: Use C++ exception handling.
9314         * infcmd.c: Use C++ exception handling.
9315         * infcall.c: Use C++ exception handling.
9316         * inf-loop.c: Use C++ exception handling.
9317         * i386-tdep.c: Use C++ exception handling.
9318         * i386-linux-tdep.c: Use C++ exception handling.
9319         * guile/scm-value.c: Use C++ exception handling.
9320         * guile/scm-type.c: Use C++ exception handling.
9321         * guile/scm-symtab.c: Use C++ exception handling.
9322         * guile/scm-symbol.c: Use C++ exception handling.
9323         * guile/scm-pretty-print.c: Use C++ exception handling.
9324         * guile/scm-ports.c: Use C++ exception handling.
9325         * guile/scm-param.c: Use C++ exception handling.
9326         * guile/scm-math.c: Use C++ exception handling.
9327         * guile/scm-lazy-string.c: Use C++ exception handling.
9328         * guile/scm-frame.c: Use C++ exception handling.
9329         * guile/scm-disasm.c: Use C++ exception handling.
9330         * guile/scm-cmd.c: Use C++ exception handling.
9331         * guile/scm-breakpoint.c: Use C++ exception handling.
9332         * guile/scm-block.c: Use C++ exception handling.
9333         * guile/guile-internal.h: Use C++ exception handling.
9334         * gnu-v3-abi.c: Use C++ exception handling.
9335         * gdbtypes.c: Use C++ exception handling.
9336         * frame.c: Use C++ exception handling.
9337         * frame-unwind.c: Use C++ exception handling.
9338         * fbsd-tdep.c: Use C++ exception handling.
9339         * f-valprint.c: Use C++ exception handling.
9340         * exec.c: Use C++ exception handling.
9341         * event-top.c: Use C++ exception handling.
9342         * event-loop.c: Use C++ exception handling.
9343         * eval.c: Use C++ exception handling.
9344         * dwarf2read.c: Use C++ exception handling.
9345         * dwarf2loc.c: Use C++ exception handling.
9346         * dwarf2-frame.c: Use C++ exception handling.
9347         * dwarf2-frame-tailcall.c: Use C++ exception handling.
9348         * dwarf-index-write.c: Use C++ exception handling.
9349         * dwarf-index-cache.c: Use C++ exception handling.
9350         * dtrace-probe.c: Use C++ exception handling.
9351         * disasm-selftests.c: Use C++ exception handling.
9352         * darwin-nat.c: Use C++ exception handling.
9353         * cp-valprint.c: Use C++ exception handling.
9354         * cp-support.c: Use C++ exception handling.
9355         * cp-abi.c: Use C++ exception handling.
9356         * corelow.c: Use C++ exception handling.
9357         * completer.c: Use C++ exception handling.
9358         * compile/compile-object-run.c: Use C++ exception handling.
9359         * compile/compile-object-load.c: Use C++ exception handling.
9360         * compile/compile-cplus-symbols.c: Use C++ exception handling.
9361         * compile/compile-c-symbols.c: Use C++ exception handling.
9362         * common/selftest.c: Use C++ exception handling.
9363         * common/new-op.c: Use C++ exception handling.
9364         * cli/cli-script.c: Use C++ exception handling.
9365         * cli/cli-interp.c: Use C++ exception handling.
9366         * cli/cli-cmds.c: Use C++ exception handling.
9367         * c-varobj.c: Use C++ exception handling.
9368         * btrace.c: Use C++ exception handling.
9369         * breakpoint.c: Use C++ exception handling.
9370         * break-catch-throw.c: Use C++ exception handling.
9371         * arch-utils.c: Use C++ exception handling.
9372         * amd64-tdep.c: Use C++ exception handling.
9373         * ada-valprint.c: Use C++ exception handling.
9374         * ada-typeprint.c: Use C++ exception handling.
9375         * ada-lang.c: Use C++ exception handling.
9376         * aarch64-tdep.c: Use C++ exception handling.
9377
9378 2019-04-08  Tom Tromey  <tom@tromey.com>
9379
9380         * xml-support.c (gdb_xml_parser::parse): Update.
9381         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
9382         * value.c (show_convenience): Update.
9383         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
9384         (test_parse_flags_qcs): Update.
9385         * thread.c (thr_try_catch_cmd): Update.
9386         * target.c (target_translate_tls_address): Update.
9387         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
9388         (info_frame_command_core, frame_apply_command_count): Update.
9389         * rust-exp.y (rust_lex_exception_test): Update.
9390         * riscv-tdep.c (riscv_print_one_register_info): Update.
9391         * remote.c (remote_target::enable_btrace): Update.
9392         * record-btrace.c (record_btrace_enable_warn): Update.
9393         * python/py-utils.c (gdbpy_convert_exception): Update.
9394         * printcmd.c (do_one_display, print_variable_and_value): Update.
9395         * mi/mi-main.c (mi_print_exception): Update.
9396         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
9397         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
9398         * linux-nat.c (linux_nat_target::attach): Update.
9399         * linux-fork.c (class scoped_switch_fork_info): Update.
9400         * infrun.c (displaced_step_prepare): Update.
9401         * infcall.c (call_function_by_hand_dummy): Update.
9402         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
9403         * gnu-v3-abi.c (print_one_vtable): Update.
9404         * frame.c (get_prev_frame_always): Update.
9405         * f-valprint.c (info_common_command_for_block): Update.
9406         * exec.c (try_open_exec_file): Update.
9407         * exceptions.c (print_exception, exception_print)
9408         (exception_fprintf, exception_print_same): Update.
9409         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
9410         * dwarf-index-cache.c (index_cache::store)
9411         (index_cache::lookup_gdb_index): Update.
9412         * darwin-nat.c (maybe_cache_shell): Update.
9413         * cp-valprint.c (cp_print_value_fields): Update.
9414         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
9415         (gcc_cplus_symbol_address): Update.
9416         * compile/compile-c-symbols.c (gcc_convert_symbol)
9417         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
9418         * common/selftest.c: Update.
9419         * common/common-exceptions.h (struct gdb_exception) <message>: Now
9420         a std::string.
9421         (exception_try_scope_entry, exception_try_scope_exit): Don't
9422         declare.
9423         (struct exception_try_scope): Remove.
9424         (TRY): Don't use exception_try_scope.
9425         (struct gdb_exception): Add constructor, operator=.
9426         <what>: New method.
9427         (struct gdb_exception_RETURN_MASK_ALL)
9428         (struct gdb_exception_RETURN_MASK_ERROR)
9429         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
9430         (struct gdb_quit_bad_alloc): Update.
9431         * common/common-exceptions.c (exception_none): Change
9432         initializer.
9433         (struct catcher) <state, exception>: Initialize inline.
9434         <prev>: Remove member.
9435         (current_catcher): Remove.
9436         (catchers): New global.
9437         (exceptions_state_mc_init): Simplify.
9438         (catcher_pop): Remove.
9439         (exceptions_state_mc, exceptions_state_mc_catch): Update.
9440         (try_scope_depth, exception_try_scope_entry)
9441         (exception_try_scope_exit): Remove.
9442         (throw_exception_sjlj): Update.
9443         (exception_messages, exception_messages_size): Remove.
9444         (throw_it): Simplify.
9445         (gdb_exception_sliced_copy): Remove.
9446         (throw_exception_cxx): Update.
9447         * cli/cli-script.c (script_from_file): Update.
9448         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
9449         Update.
9450         * ada-valprint.c (ada_val_print): Update.
9451         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
9452         (create_excep_cond_exprs): Update.
9453
9454 2019-04-08  Tom Tromey  <tom@tromey.com>
9455
9456         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
9457         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
9458         (TRY, CATCH, END_CATCH): Remove some definitions.
9459         * common/common-exceptions.c: Don't use GDB_XCPT.
9460         (catcher_list_size): Remove.
9461         (throw_exception, throw_it): Simplify.
9462
9463 2019-04-05  Tom Tromey  <tom@tromey.com>
9464
9465         Revert the header-sorting patch.
9466         * ft32-tdep.c: Revert.
9467         * frv-tdep.c: Revert.
9468         * frv-linux-tdep.c: Revert.
9469         * frame.c: Revert.
9470         * frame-unwind.c: Revert.
9471         * frame-base.c: Revert.
9472         * fork-child.c: Revert.
9473         * findvar.c: Revert.
9474         * findcmd.c: Revert.
9475         * filesystem.c: Revert.
9476         * filename-seen-cache.h: Revert.
9477         * filename-seen-cache.c: Revert.
9478         * fbsd-tdep.c: Revert.
9479         * fbsd-nat.h: Revert.
9480         * fbsd-nat.c: Revert.
9481         * f-valprint.c: Revert.
9482         * f-typeprint.c: Revert.
9483         * f-lang.c: Revert.
9484         * extension.h: Revert.
9485         * extension.c: Revert.
9486         * extension-priv.h: Revert.
9487         * expprint.c: Revert.
9488         * exec.h: Revert.
9489         * exec.c: Revert.
9490         * exceptions.c: Revert.
9491         * event-top.c: Revert.
9492         * event-loop.c: Revert.
9493         * eval.c: Revert.
9494         * elfread.c: Revert.
9495         * dwarf2read.h: Revert.
9496         * dwarf2read.c: Revert.
9497         * dwarf2loc.c: Revert.
9498         * dwarf2expr.h: Revert.
9499         * dwarf2expr.c: Revert.
9500         * dwarf2-frame.c: Revert.
9501         * dwarf2-frame-tailcall.c: Revert.
9502         * dwarf-index-write.h: Revert.
9503         * dwarf-index-write.c: Revert.
9504         * dwarf-index-common.c: Revert.
9505         * dwarf-index-cache.h: Revert.
9506         * dwarf-index-cache.c: Revert.
9507         * dummy-frame.c: Revert.
9508         * dtrace-probe.c: Revert.
9509         * disasm.h: Revert.
9510         * disasm.c: Revert.
9511         * disasm-selftests.c: Revert.
9512         * dictionary.c: Revert.
9513         * dicos-tdep.c: Revert.
9514         * demangle.c: Revert.
9515         * dcache.h: Revert.
9516         * dcache.c: Revert.
9517         * darwin-nat.h: Revert.
9518         * darwin-nat.c: Revert.
9519         * darwin-nat-info.c: Revert.
9520         * d-valprint.c: Revert.
9521         * d-namespace.c: Revert.
9522         * d-lang.c: Revert.
9523         * ctf.c: Revert.
9524         * csky-tdep.c: Revert.
9525         * csky-linux-tdep.c: Revert.
9526         * cris-tdep.c: Revert.
9527         * cris-linux-tdep.c: Revert.
9528         * cp-valprint.c: Revert.
9529         * cp-support.c: Revert.
9530         * cp-namespace.c: Revert.
9531         * cp-abi.c: Revert.
9532         * corelow.c: Revert.
9533         * corefile.c: Revert.
9534         * continuations.c: Revert.
9535         * completer.h: Revert.
9536         * completer.c: Revert.
9537         * complaints.c: Revert.
9538         * coffread.c: Revert.
9539         * coff-pe-read.c: Revert.
9540         * cli-out.h: Revert.
9541         * cli-out.c: Revert.
9542         * charset.c: Revert.
9543         * c-varobj.c: Revert.
9544         * c-valprint.c: Revert.
9545         * c-typeprint.c: Revert.
9546         * c-lang.c: Revert.
9547         * buildsym.c: Revert.
9548         * buildsym-legacy.c: Revert.
9549         * build-id.h: Revert.
9550         * build-id.c: Revert.
9551         * btrace.c: Revert.
9552         * bsd-uthread.c: Revert.
9553         * breakpoint.h: Revert.
9554         * breakpoint.c: Revert.
9555         * break-catch-throw.c: Revert.
9556         * break-catch-syscall.c: Revert.
9557         * break-catch-sig.c: Revert.
9558         * blockframe.c: Revert.
9559         * block.c: Revert.
9560         * bfin-tdep.c: Revert.
9561         * bfin-linux-tdep.c: Revert.
9562         * bfd-target.c: Revert.
9563         * bcache.c: Revert.
9564         * ax-general.c: Revert.
9565         * ax-gdb.h: Revert.
9566         * ax-gdb.c: Revert.
9567         * avr-tdep.c: Revert.
9568         * auxv.c: Revert.
9569         * auto-load.c: Revert.
9570         * arm-wince-tdep.c: Revert.
9571         * arm-tdep.c: Revert.
9572         * arm-symbian-tdep.c: Revert.
9573         * arm-pikeos-tdep.c: Revert.
9574         * arm-obsd-tdep.c: Revert.
9575         * arm-nbsd-tdep.c: Revert.
9576         * arm-nbsd-nat.c: Revert.
9577         * arm-linux-tdep.c: Revert.
9578         * arm-linux-nat.c: Revert.
9579         * arm-fbsd-tdep.c: Revert.
9580         * arm-fbsd-nat.c: Revert.
9581         * arm-bsd-tdep.c: Revert.
9582         * arch-utils.c: Revert.
9583         * arc-tdep.c: Revert.
9584         * arc-newlib-tdep.c: Revert.
9585         * annotate.h: Revert.
9586         * annotate.c: Revert.
9587         * amd64-windows-tdep.c: Revert.
9588         * amd64-windows-nat.c: Revert.
9589         * amd64-tdep.c: Revert.
9590         * amd64-sol2-tdep.c: Revert.
9591         * amd64-obsd-tdep.c: Revert.
9592         * amd64-obsd-nat.c: Revert.
9593         * amd64-nbsd-tdep.c: Revert.
9594         * amd64-nbsd-nat.c: Revert.
9595         * amd64-nat.c: Revert.
9596         * amd64-linux-tdep.c: Revert.
9597         * amd64-linux-nat.c: Revert.
9598         * amd64-fbsd-tdep.c: Revert.
9599         * amd64-fbsd-nat.c: Revert.
9600         * amd64-dicos-tdep.c: Revert.
9601         * amd64-darwin-tdep.c: Revert.
9602         * amd64-bsd-nat.c: Revert.
9603         * alpha-tdep.c: Revert.
9604         * alpha-obsd-tdep.c: Revert.
9605         * alpha-nbsd-tdep.c: Revert.
9606         * alpha-mdebug-tdep.c: Revert.
9607         * alpha-linux-tdep.c: Revert.
9608         * alpha-linux-nat.c: Revert.
9609         * alpha-bsd-tdep.c: Revert.
9610         * alpha-bsd-nat.c: Revert.
9611         * aix-thread.c: Revert.
9612         * agent.c: Revert.
9613         * addrmap.c: Revert.
9614         * ada-varobj.c: Revert.
9615         * ada-valprint.c: Revert.
9616         * ada-typeprint.c: Revert.
9617         * ada-tasks.c: Revert.
9618         * ada-lang.c: Revert.
9619         * aarch64-tdep.c: Revert.
9620         * aarch64-ravenscar-thread.c: Revert.
9621         * aarch64-newlib-tdep.c: Revert.
9622         * aarch64-linux-tdep.c: Revert.
9623         * aarch64-linux-nat.c: Revert.
9624         * aarch64-fbsd-tdep.c: Revert.
9625         * aarch64-fbsd-nat.c: Revert.
9626         * aarch32-linux-nat.c: Revert.
9627
9628 2019-04-05  Tom Tromey  <tom@tromey.com>
9629
9630         * ft32-tdep.c: Sort headers.
9631         * frv-tdep.c: Sort headers.
9632         * frv-linux-tdep.c: Sort headers.
9633         * frame.c: Sort headers.
9634         * frame-unwind.c: Sort headers.
9635         * frame-base.c: Sort headers.
9636         * fork-child.c: Sort headers.
9637         * findvar.c: Sort headers.
9638         * findcmd.c: Sort headers.
9639         * filesystem.c: Sort headers.
9640         * filename-seen-cache.h: Sort headers.
9641         * filename-seen-cache.c: Sort headers.
9642         * fbsd-tdep.c: Sort headers.
9643         * fbsd-nat.h: Sort headers.
9644         * fbsd-nat.c: Sort headers.
9645         * f-valprint.c: Sort headers.
9646         * f-typeprint.c: Sort headers.
9647         * f-lang.c: Sort headers.
9648         * extension.h: Sort headers.
9649         * extension.c: Sort headers.
9650         * extension-priv.h: Sort headers.
9651         * expprint.c: Sort headers.
9652         * exec.h: Sort headers.
9653         * exec.c: Sort headers.
9654         * exceptions.c: Sort headers.
9655         * event-top.c: Sort headers.
9656         * event-loop.c: Sort headers.
9657         * eval.c: Sort headers.
9658         * elfread.c: Sort headers.
9659         * dwarf2read.h: Sort headers.
9660         * dwarf2read.c: Sort headers.
9661         * dwarf2loc.c: Sort headers.
9662         * dwarf2expr.h: Sort headers.
9663         * dwarf2expr.c: Sort headers.
9664         * dwarf2-frame.c: Sort headers.
9665         * dwarf2-frame-tailcall.c: Sort headers.
9666         * dwarf-index-write.h: Sort headers.
9667         * dwarf-index-write.c: Sort headers.
9668         * dwarf-index-common.c: Sort headers.
9669         * dwarf-index-cache.h: Sort headers.
9670         * dwarf-index-cache.c: Sort headers.
9671         * dummy-frame.c: Sort headers.
9672         * dtrace-probe.c: Sort headers.
9673         * disasm.h: Sort headers.
9674         * disasm.c: Sort headers.
9675         * disasm-selftests.c: Sort headers.
9676         * dictionary.c: Sort headers.
9677         * dicos-tdep.c: Sort headers.
9678         * demangle.c: Sort headers.
9679         * dcache.h: Sort headers.
9680         * dcache.c: Sort headers.
9681         * darwin-nat.h: Sort headers.
9682         * darwin-nat.c: Sort headers.
9683         * darwin-nat-info.c: Sort headers.
9684         * d-valprint.c: Sort headers.
9685         * d-namespace.c: Sort headers.
9686         * d-lang.c: Sort headers.
9687         * ctf.c: Sort headers.
9688         * csky-tdep.c: Sort headers.
9689         * csky-linux-tdep.c: Sort headers.
9690         * cris-tdep.c: Sort headers.
9691         * cris-linux-tdep.c: Sort headers.
9692         * cp-valprint.c: Sort headers.
9693         * cp-support.c: Sort headers.
9694         * cp-namespace.c: Sort headers.
9695         * cp-abi.c: Sort headers.
9696         * corelow.c: Sort headers.
9697         * corefile.c: Sort headers.
9698         * continuations.c: Sort headers.
9699         * completer.h: Sort headers.
9700         * completer.c: Sort headers.
9701         * complaints.c: Sort headers.
9702         * coffread.c: Sort headers.
9703         * coff-pe-read.c: Sort headers.
9704         * cli-out.h: Sort headers.
9705         * cli-out.c: Sort headers.
9706         * charset.c: Sort headers.
9707         * c-varobj.c: Sort headers.
9708         * c-valprint.c: Sort headers.
9709         * c-typeprint.c: Sort headers.
9710         * c-lang.c: Sort headers.
9711         * buildsym.c: Sort headers.
9712         * buildsym-legacy.c: Sort headers.
9713         * build-id.h: Sort headers.
9714         * build-id.c: Sort headers.
9715         * btrace.c: Sort headers.
9716         * bsd-uthread.c: Sort headers.
9717         * breakpoint.h: Sort headers.
9718         * breakpoint.c: Sort headers.
9719         * break-catch-throw.c: Sort headers.
9720         * break-catch-syscall.c: Sort headers.
9721         * break-catch-sig.c: Sort headers.
9722         * blockframe.c: Sort headers.
9723         * block.c: Sort headers.
9724         * bfin-tdep.c: Sort headers.
9725         * bfin-linux-tdep.c: Sort headers.
9726         * bfd-target.c: Sort headers.
9727         * bcache.c: Sort headers.
9728         * ax-general.c: Sort headers.
9729         * ax-gdb.h: Sort headers.
9730         * ax-gdb.c: Sort headers.
9731         * avr-tdep.c: Sort headers.
9732         * auxv.c: Sort headers.
9733         * auto-load.c: Sort headers.
9734         * arm-wince-tdep.c: Sort headers.
9735         * arm-tdep.c: Sort headers.
9736         * arm-symbian-tdep.c: Sort headers.
9737         * arm-pikeos-tdep.c: Sort headers.
9738         * arm-obsd-tdep.c: Sort headers.
9739         * arm-nbsd-tdep.c: Sort headers.
9740         * arm-nbsd-nat.c: Sort headers.
9741         * arm-linux-tdep.c: Sort headers.
9742         * arm-linux-nat.c: Sort headers.
9743         * arm-fbsd-tdep.c: Sort headers.
9744         * arm-fbsd-nat.c: Sort headers.
9745         * arm-bsd-tdep.c: Sort headers.
9746         * arch-utils.c: Sort headers.
9747         * arc-tdep.c: Sort headers.
9748         * arc-newlib-tdep.c: Sort headers.
9749         * annotate.h: Sort headers.
9750         * annotate.c: Sort headers.
9751         * amd64-windows-tdep.c: Sort headers.
9752         * amd64-windows-nat.c: Sort headers.
9753         * amd64-tdep.c: Sort headers.
9754         * amd64-sol2-tdep.c: Sort headers.
9755         * amd64-obsd-tdep.c: Sort headers.
9756         * amd64-obsd-nat.c: Sort headers.
9757         * amd64-nbsd-tdep.c: Sort headers.
9758         * amd64-nbsd-nat.c: Sort headers.
9759         * amd64-nat.c: Sort headers.
9760         * amd64-linux-tdep.c: Sort headers.
9761         * amd64-linux-nat.c: Sort headers.
9762         * amd64-fbsd-tdep.c: Sort headers.
9763         * amd64-fbsd-nat.c: Sort headers.
9764         * amd64-dicos-tdep.c: Sort headers.
9765         * amd64-darwin-tdep.c: Sort headers.
9766         * amd64-bsd-nat.c: Sort headers.
9767         * alpha-tdep.c: Sort headers.
9768         * alpha-obsd-tdep.c: Sort headers.
9769         * alpha-nbsd-tdep.c: Sort headers.
9770         * alpha-mdebug-tdep.c: Sort headers.
9771         * alpha-linux-tdep.c: Sort headers.
9772         * alpha-linux-nat.c: Sort headers.
9773         * alpha-bsd-tdep.c: Sort headers.
9774         * alpha-bsd-nat.c: Sort headers.
9775         * aix-thread.c: Sort headers.
9776         * agent.c: Sort headers.
9777         * addrmap.c: Sort headers.
9778         * ada-varobj.c: Sort headers.
9779         * ada-valprint.c: Sort headers.
9780         * ada-typeprint.c: Sort headers.
9781         * ada-tasks.c: Sort headers.
9782         * ada-lang.c: Sort headers.
9783         * aarch64-tdep.c: Sort headers.
9784         * aarch64-ravenscar-thread.c: Sort headers.
9785         * aarch64-newlib-tdep.c: Sort headers.
9786         * aarch64-linux-tdep.c: Sort headers.
9787         * aarch64-linux-nat.c: Sort headers.
9788         * aarch64-fbsd-tdep.c: Sort headers.
9789         * aarch64-fbsd-nat.c: Sort headers.
9790         * aarch32-linux-nat.c: Sort headers.
9791
9792 2019-04-04  Tom Tromey  <tom@tromey.com>
9793
9794         * varobj.c (varobj_create): Update.
9795         * rust-exp.y (struct rust_parser) <update_innermost_block,
9796         lookup_symbol>: New methods.
9797         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
9798         Rename.
9799         (rust_parser::rust_lookup_type)
9800         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
9801         * printcmd.c (display_command, do_one_display): Update.
9802         * parser-defs.h (struct parser_state) <parser_state>: Add
9803         "tracker" parameter.
9804         (block_tracker): New member.
9805         (class innermost_block_tracker) <innermost_block_tracker>: Add
9806         "types" parameter.
9807         <reset>: Remove method.
9808         (innermost_block): Don't declare.
9809         (null_post_parser): Update.
9810         * parse.c (innermost_block): Remove global.
9811         (write_dollar_variable): Update.
9812         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
9813         Remove "tracker_types" parameter.
9814         (parse_expression): Add "tracker" parameter.
9815         (parse_expression_for_completion): Update.
9816         (null_post_parser): Add "tracker" parameter.
9817         * p-exp.y: Update rules.
9818         * m2-exp.y: Update rules.
9819         * language.h (struct language_defn) <la_post_parser>: Add
9820         "tracker" parameter.
9821         * go-exp.y: Update rules.
9822         * f-exp.y: Update rules.
9823         * expression.h (parse_expression, parse_exp_1): Add "tracker"
9824         parameter.
9825         * d-exp.y: Update rules.
9826         * c-exp.y: Update rules.
9827         * breakpoint.c (set_breakpoint_condition): Create an
9828         innermost_block_tracker.
9829         (watch_command_1): Likewise.
9830         * ada-lang.c (resolve): Add "tracker" parameter.
9831         (resolve_subexp): Likewise.
9832         * ada-exp.y (write_var_from_sym): Update.
9833
9834 2019-04-04  Tom Tromey  <tom@tromey.com>
9835
9836         * type-stack.h: New file.
9837         * type-stack.c: New file.
9838         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
9839         type-stack.h.
9840         (insert_into_type_stack, insert_type, push_type, push_type_int)
9841         (insert_type_address_space, pop_type, pop_type_int)
9842         (pop_typelist, pop_type_stack, append_type_stack)
9843         (push_type_stack, get_type_stack, push_typelist)
9844         (follow_type_instance_flags, follow_types): Don't declare.
9845         * parse.c (type_stack): Remove global.
9846         (parse_exp_in_context): Update.
9847         (insert_into_type_stack, insert_type, push_type, push_type_int)
9848         (insert_type_address_space, pop_type, pop_type_int)
9849         (pop_typelist, pop_type_stack, append_type_stack)
9850         (push_type_stack, get_type_stack, push_typelist)
9851         (follow_type_instance_flags, follow_types): Remove (moved to
9852         type-stack.c).
9853         * f-exp.y (type_stack): New global.
9854         Update rules.
9855         (push_kind_type, f_parse): Update.
9856         * d-exp.y (type_stack): New global.
9857         Update rules.
9858         (d_parse): Update.
9859         * c-exp.y (struct c_parse_state) <type_stack>: New member.
9860         Update rules.
9861         * Makefile.in (COMMON_SFILES): Add type-stack.c.
9862         (HFILES_NO_SRCDIR): Add type-stack.h.
9863
9864 2019-04-04  Tom Tromey  <tom@tromey.com>
9865
9866         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
9867         (rust_parser::convert_ast_to_expression, rust_parse)
9868         (rust_lex_test_completion, rust_lex_tests): Update.
9869         * parser-defs.h (struct expr_completion_state): New.
9870         (struct parser_state) <parser_state>: Add completion parameter.
9871         <mark_struct_expression, mark_completion_tag>: New methods.
9872         <parse_completion, m_completion_state>: New members.
9873         (prefixify_expression, null_post_parser): Update.
9874         (mark_struct_expression, mark_completion_tag): Don't declare.
9875         * parse.c (parse_completion, expout_last_struct)
9876         (expout_tag_completion_type, expout_completion_name): Remove
9877         globals.
9878         (parser_state::mark_struct_expression)
9879         (parser_state::mark_completion_tag): Now methods.
9880         (prefixify_expression): Add last_struct parameter.
9881         (prefixify_subexp): Likewise.
9882         (parse_exp_1): Update.
9883         (parse_exp_in_context): Add cstate parameter.  Update.
9884         (parse_expression_for_completion): Create an
9885         expr_completion_state.
9886         (null_post_parser): Add "completion" parameter.
9887         * p-exp.y: Update rules.
9888         (yylex): Update.
9889         * language.h (struct language_defn) <la_post_parser>: Add
9890         "completing" parameter.
9891         * go-exp.y: Update rules.
9892         (lex_one_token): Update.
9893         * expression.h (parse_completion): Don't declare.
9894         * d-exp.y: Update rules.
9895         (lex_one_token): Update rules.
9896         * c-exp.y: Update rules.
9897         (lex_one_token): Update.
9898         * ada-lang.c (resolve): Add "parse_completion" parameter.
9899         (resolve_subexp): Likewise.
9900         (ada_resolve_function): Likewise.
9901
9902 2019-04-04  Tom Tromey  <tom@tromey.com>
9903
9904         * parser-defs.h (struct parser_state) <start_arglist,
9905         end_arglist>: New methods.
9906         <arglist_len, m_funcall_chain>: New members.
9907         (arglist_len, start_arglist, end_arglist): Don't declare.
9908         * parse.c (arglist_len, funcall_chain): Remove global.
9909         (start_arglist, end_arglist): Remove functions.
9910         (parse_exp_in_context): Update.
9911         * p-exp.y: Update rules.
9912         * m2-exp.y: Update rules.
9913         * go-exp.y: Update rules.
9914         * f-exp.y: Update rules.
9915         * d-exp.y: Update rules.
9916         * c-exp.y: Update rules.
9917
9918 2019-04-04  Tom Tromey  <tom@tromey.com>
9919
9920         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
9921         lex_operator, push_back>: New methods.
9922         Update all rules.
9923         (rust_parser::lex_hex, lex_escape): Rename and update.
9924         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
9925         (rust_parser::lex_operator): Rename and update.
9926         (rust_parser::lex_number, rustyylex, rustyyerror)
9927         (rust_lex_test_init, rust_lex_test_sequence)
9928         (rust_lex_test_push_back, rust_lex_tests): Update.
9929         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
9930         parameter.
9931         <lexptr, prev_lexptr>: New members.
9932         (lexptr, prev_lexptr): Don't declare.
9933         * parse.c (lexptr, prev_lexptr): Remove globals.
9934         (parse_exp_in_context): Update.
9935         * p-exp.y (yylex, yyerror): Update.
9936         * m2-exp.y (parse_number, yylex, yyerror): Update.
9937         * go-exp.y (lex_one_token, yyerror): Update.
9938         * f-exp.y (match_string_literal, yylex, yyerror): Update.
9939         * d-exp.y (lex_one_token, yyerror): Update.
9940         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
9941         (lex_one_token, yyerror): Update.
9942         * ada-lex.l (YY_INPUT): Update.
9943         (rewind_to_char): Update.
9944         * ada-exp.y (yyerror): Update.
9945
9946 2019-04-04  Tom Tromey  <tom@tromey.com>
9947
9948         * rust-exp.y (rustyylex, rust_lex_tests): Update.
9949         * parser-defs.h (struct parser_state) <parser_state>: Add new
9950         parameter.
9951         <comma_terminates>: New member.
9952         (comma_terminates): Don't declare global.
9953         * parse.c (comma_terminates): Remove global.
9954         (parse_exp_in_context): Update.
9955         * p-exp.y (yylex): Update.
9956         * m2-exp.y (yylex): Update.
9957         * go-exp.y (lex_one_token): Update.
9958         * f-exp.y (yylex): Update.
9959         * d-exp.y (lex_one_token): Update.
9960         * c-exp.y (lex_one_token): Update.
9961         * ada-lex.l: Update.
9962
9963 2019-04-04  Tom Tromey  <tom@tromey.com>
9964
9965         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
9966         (rustyylex, rust_lex_test_init, rust_lex_test_one)
9967         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
9968         * parser-defs.h (paren_depth): Don't declare.
9969         * parse.c (paren_depth): Remove global.
9970         (parse_exp_in_context): Update.
9971         * p-exp.y (paren_depth): New global.
9972         (pascal_parse): Initialize it.
9973         * m2-exp.y (paren_depth): New global.
9974         (m2_parse): Initialize it.
9975         * go-exp.y (paren_depth): New global.
9976         (go_parse): Initialize it.
9977         * f-exp.y (paren_depth): New global.
9978         (f_parse): Initialize it.
9979         * d-exp.y (paren_depth): New global.
9980         (d_parse): Initialize it.
9981         * c-exp.y (paren_depth): New global.
9982         (c_parse): Initialize it.
9983         * ada-lex.l (paren_depth): New global.
9984         (lexer_init): Initialize it.
9985
9986 2019-04-04  Tom Tromey  <tom@tromey.com>
9987
9988         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
9989         (rust_parser::convert_ast_to_type)
9990         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
9991         * parser-defs.h (struct parser_state) <parser_state>: Add
9992         parameters.  Initialize new members.
9993         <expression_context_block, expression_context_pc>: New members.
9994         * parse.c (expression_context_block, expression_context_pc):
9995         Remove globals.
9996         (parse_exp_in_context): Update.
9997         * p-exp.y: Update all rules.
9998         (yylex): Update.
9999         * m2-exp.y: Update all rules.
10000         (yylex): Update.
10001         * go-exp.y (yylex): Update.
10002         * f-exp.y (yylex): Update.
10003         * d-exp.y: Update all rules.
10004         (yylex): Update.
10005         * c-exp.y: Update all rules.
10006         (lex_one_token, classify_name, yylex, c_parse): Update.
10007         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
10008
10009 2019-04-04  Tom Tromey  <tom@tromey.com>
10010
10011         * gdbarch.h, gdbarch.c: Rebuild.
10012         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
10013         * stap-probe.h:
10014         (struct stap_parse_info): Replace "parser_state" with
10015         "expr_builder".
10016         * parser-defs.h (struct expr_builder): Rename from "parser_state".
10017         (parser_state): New class.
10018         * parse.c (expr_builder): Rename.
10019         (expr_builder::release): Rename.
10020         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
10021         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
10022         (write_exp_elt_longcst, write_exp_elt_floatcst)
10023         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
10024         (write_exp_string_vector, write_exp_bitstring)
10025         (write_exp_msymbol, mark_struct_expression)
10026         (write_dollar_variable)
10027         (insert_type_address_space, increase_expout_size): Replace
10028         "parser_state" with "expr_builder".
10029         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
10030         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
10031         "parser_state" with "expr_builder".
10032
10033 2019-04-04  Tom Tromey  <tom@tromey.com>
10034
10035         * rust-exp.y: Replace "parse_language" with method call.
10036         * p-exp.y:
10037         (yylex): Replace "parse_language" with method call.
10038         * m2-exp.y:
10039         (yylex): Replace "parse_language" with method call.
10040         * go-exp.y (classify_name): Replace "parse_language" with method
10041         call.
10042         * f-exp.y (yylex): Replace "parse_language" with method call.
10043         * d-exp.y (lex_one_token): Replace "parse_language" with method
10044         call.
10045         * c-exp.y:
10046         (lex_one_token, classify_name, yylex): Replace "parse_language"
10047         with method call.
10048         * ada-exp.y (find_primitive_type, type_char)
10049         (type_system_address): Replace "parse_language" with method call.
10050
10051 2019-04-04  Tom Tromey  <tom@tromey.com>
10052
10053         * rust-exp.y: Replace "parse_gdbarch" with method call.
10054         * parse.c (write_dollar_variable, insert_type_address_space):
10055         Replace "parse_gdbarch" with method call.
10056         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
10057         call.
10058         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
10059         call.
10060         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
10061         "parse_gdbarch" with method call.
10062         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
10063         with method call.
10064         * f-exp.y (parse_type, parse_f_type, yylex): Replace
10065         "parse_gdbarch" with method call.
10066         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
10067         "parse_gdbarch" with method call.
10068         * c-exp.y (parse_type, parse_number, classify_name): Replace
10069         "parse_gdbarch" with method call.
10070         * ada-lex.l: Replace "parse_gdbarch" with method call.
10071         * ada-exp.y (parse_type, find_primitive_type, type_char)
10072         (type_system_address): Replace "parse_gdbarch" with method call.
10073
10074 2019-04-04  Tom Tromey  <tom@tromey.com>
10075
10076         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
10077         * stap-probe.c (stap_parse_argument): Update.
10078         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
10079         initial_size parameter.
10080         * rust-exp.y (rust_lex_tests): Update.
10081         * parse.c (parser_state): Update.
10082         (parse_exp_in_context): Update.
10083         * parser-defs.h (struct parser_state) <parser_state>: Remove
10084         "initial_size" parameter.
10085
10086 2019-04-04  Tom Tromey  <tom@tromey.com>
10087
10088         * parser-defs.h (increase_expout_size): Don't declare.
10089         * parse.c (increase_expout_size): Now static.
10090
10091 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
10092
10093         * gnu-nat.c (gnu_nat_target::wait): Fix
10094         target_waitstatus_to_string call.
10095
10096 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
10097
10098         * eval.c (evaluate_subexp_standard): Handle internal functions
10099         during Fortran function call handling.
10100
10101 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
10102
10103         * NEWS: Mention new internal functions.
10104         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
10105         (read_base_type): Use dwarf2_init_complex_target_type.
10106         * value.c (creal_internal_fn): New function.
10107         (cimag_internal_fn): New function.
10108         (_initialize_values): Register new internal functions.
10109
10110 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10111
10112         * infrun.c (stop_all_threads): If debug_infrun, always
10113         trace the wait status after wait_one, using
10114         target_waitstatus_to_string and target_pid_to_str.
10115         (handle_inferior_event): Replace various trace of
10116         wait status kind by a single trace.
10117         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
10118         wait status kind image by target_waitstatus_to_string.
10119         * target/waitstatus.c (target_waitstatus_to_string): Fix
10120         obsolete comment.
10121
10122 2019-04-01  Tom Tromey  <tromey@adacore.com>
10123
10124         PR symtab/23331:
10125         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
10126
10127 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
10128             Pedro Alves  <palves@redhat.com>
10129
10130         * top.c (quit_force): Call 'finalize_values'.
10131         * value.c (finalize_values): New function.
10132         * value.h (finalize_values): Declare.
10133
10134 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
10135
10136         * NEWS: Announce $_gdb_major and $_gdb_minor.
10137
10138         * top.c (init_gdb_version_vars): New function.
10139         (gdb_init): Call init_gdb_version_vars.
10140
10141 2019-03-29  Tom Tromey  <tromey@adacore.com>
10142
10143         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
10144         help text.  Remove dead code.
10145
10146 2019-03-29  Keith Seitz  <keiths@redhat.com>
10147
10148         From Siddhesh Poyarekar:
10149         * f-lang.h (f77_get_upperbound): Return LONGEST.
10150         (f77_get_lowerbound): Likewise.
10151         * f-typeprint.c (f_type_print_varspec_suffix): Expand
10152         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
10153         print them.
10154         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
10155         plongest to format print it.
10156         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
10157         (f77_get_upperbound): Likewise.
10158         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
10159         LOWER_BOUND to LONGEST.
10160         (f77_create_arrayprint_offset_tbl): Likewise.
10161
10162 2019-03-29  Keith Seitz  <keiths@redhat.com>
10163
10164         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
10165         %s/pulongest for TYPE_LENGTH instead of %d in format
10166         strings.
10167         * ada-typerint.c (ada_print_type): Likewise.
10168         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
10169         * compile/compile-c-support.c (generate_register_struct): Likewise.
10170         * gdbtypes.c (recursive_dump_type): Likewise.
10171         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
10172         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
10173         instead of %d in format strings.
10174         * riscv-tdep.c (riscv_type_alignment): Cast second argument
10175         to std::min to ULONGEST.
10176         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
10177         instead of %d in format strings.
10178         * tracepoint.c (info_scope_command): Likewise.
10179         * typeprint.c (print_offset_data::update)
10180         (print_offset_data::finish): Likewise.
10181         * xtensa-tdep.c (xtensa_store_return_value)
10182         (xtensa_push_dummy_call): Likewise.
10183
10184 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
10185
10186         * windows-nat.c (display_selector): Fixed format specifications
10187         for 64-bit Cygwin.
10188
10189 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10190
10191         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
10192
10193 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
10194
10195         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
10196         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
10197         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
10198         (nios2_linux_init_abi): Install it.
10199
10200 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
10201
10202         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
10203
10204 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
10205
10206         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
10207
10208 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10209             Tom Tromey  <tromey@adacore.com>
10210
10211         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
10212
10213 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
10214
10215         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
10216         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
10217         method to compute the bounds of range types. Also print "[evaluated]"
10218         if the bounds' values come from a dynamic evaluation.
10219
10220 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
10221
10222         * cp-valprint.c (cp_print_value_fields): Don't print trailing
10223         whitespace when pretty printing is on.
10224
10225 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
10226
10227         * ppc-linux-nat.c: Add include.
10228
10229 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
10230
10231         * NEWS: Mention AArch64 Pointer Authentication.
10232
10233 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
10234
10235         * arm-linux-nat.c: Add include.
10236
10237 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
10238
10239         * source-cache.c (source_cache::get_source_lines): Re-read
10240         fullname after calling open_source_file.
10241
10242 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
10243
10244         * NEWS: Mention TLS support for FreeBSD.
10245
10246 2019-03-25  Tom Tromey  <tromey@adacore.com>
10247
10248         * minsyms.c (BUNCH_SIZE): Update comment.
10249         (~minimal_symbol_reader): Remove old comment.
10250         (compact_minimal_symbols): Update comment.
10251         (minimal_symbol_reader::install): Remove old comment.  Update
10252         other comments.
10253
10254 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
10255
10256         * s390-linux-nat.c: Add include.
10257
10258 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
10259
10260         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
10261         Call linux_get_hwcap.
10262         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
10263         Likewise.
10264         (aarch64_linux_get_hwcap): Remove function.
10265         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
10266         declaration.
10267         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
10268         linux_get_hwcap.
10269         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
10270         * linux-tdep.c (linux_get_hwcap): Add function.
10271         (linux_get_hwcap2): Likewise.
10272         * linux-tdep.h (linux_get_hwcap): Add declaration.
10273         (linux_get_hwcap2): Likewise.
10274         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
10275         (ppc_linux_get_hwcap2): Likewise.
10276         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
10277         linux_get_hwcap.
10278         (ppc_linux_nat_target::insert_watchpoint): Likewise.
10279         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
10280         (ppc_linux_nat_target::read_description): Likewise.
10281         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
10282         * s390-linux-nat.c: Likewise.
10283         * s390-linux-tdep.c (s390_core_read_description): Likewise.
10284
10285 2019-03-24  Tom Tromey  <tom@tromey.com>
10286
10287         * ada-lang.c (standard_lookup): Simplify initialization.
10288         (ada_lookup_symbol_nonlocal): Simplify return.
10289         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
10290         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
10291         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
10292         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
10293         initialization.
10294         * solib.c (solib_global_lookup): Simplify.
10295         * symtab.c (null_block_symbol): Remove.
10296         (symbol_cache_lookup): Simplify returns.
10297         (lookup_language_this): Simplify returns.
10298         (lookup_symbol_aux): Simplify return.
10299         (lookup_local_symbol): Simplify returns.
10300         (lookup_global_symbol_from_objfile): Simplify return.
10301         (lookup_symbol_in_objfile_symtabs)
10302         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
10303         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
10304         (lookup_static_symbol, lookup_global_symbol): Simplify return.
10305         * cp-namespace.c (cp_lookup_bare_symbol)
10306         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
10307         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
10308         (cp_lookup_nested_symbol): Don't use null_block_symbol.
10309         (cp_lookup_symbol_via_imports): Simplify initialization.
10310         (find_symbol_in_baseclass): Likewise.
10311         * symtab.h (null_block_symbol): Remove.
10312         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
10313         (d_lookup_nested_symbol, d_lookup_symbol_imports)
10314         (d_lookup_symbol_module): Likewise.
10315         (find_symbol_in_baseclass): Simplify initialization.
10316
10317 2019-03-24  Tom Tromey  <tom@tromey.com>
10318
10319         * expression.h: Don't include symtab.h.
10320         (struct block): Forward declare.
10321
10322 2019-03-24  Tom Tromey  <tom@tromey.com>
10323
10324         * c-exp.y (typebase): Remove casts.
10325         * gdbtypes.c (lookup_unsigned_typename, )
10326         (lookup_signed_typename): Remove cast.
10327         * eval.c (parse_to_comma_and_eval): Remove cast.
10328         * parse.c (write_dollar_variable): Remove cast.
10329         * block.h (struct block) <superblock>: Now const.
10330         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
10331         * psymtab.c (psym_map_matching_symbols): Make "block" const.
10332         (map_block): Make "block" const.
10333         * symfile.h (struct quick_symbol_functions)
10334         <map_matching_symbols>: Constify block argument to "callback".
10335         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
10336         const.
10337         (find_pc_sect_compunit_symtab): Make "b" const.
10338         (find_symbol_at_address): Likewise.
10339         (search_symbols): Likewise.
10340         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
10341         (dw2_debug_names_lookup_symbol): Likewise.
10342         (dw2_map_matching_symbols): Update.
10343         * p-valprint.c (pascal_val_print): Remove "block".
10344         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
10345         (aux_add_nonlocal_symbols): Make "block" const.
10346         (resolve_subexp): Remove cast.
10347         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
10348         const.
10349         (iterate_over_file_blocks): Likewise.
10350         * f-exp.y (%union) <bval>: Remove.
10351         * coffread.c (patch_opaque_types): Make "b" const.
10352         * spu-tdep.c (spu_catch_start): Make "block" const.
10353         * c-valprint.c (print_unpacked_pointer): Remove "block".
10354         * symmisc.c (dump_symtab_1): Make "b" const.
10355         (block_depth): Make "block" const.
10356         * d-exp.y (%union) <bval>: Remove.
10357         * cp-support.h (cp_lookup_rtti_type): Update.
10358         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
10359         * psymtab.c (psym_lookup_symbol): Make "block" const.
10360         (maintenance_check_psymtabs): Make "b" const.
10361         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
10362         (enumerate_locals, enumerate_args): Update.
10363         * python/py-symtab.c (stpy_global_block): Make "block" const.
10364         (stpy_static_block): Likewise.
10365         * inline-frame.c (block_starting_point_at): Make "new_block"
10366         const.
10367         * block.c (find_block_in_blockvector): Make return type const.
10368         (blockvector_for_pc_sect): Make "b" const.
10369         (find_block_in_blockvector): Make "b" const.
10370
10371 2019-03-23  Tom Tromey  <tom@tromey.com>
10372
10373         * varobj.c (varobj_create): Update.
10374         * symfile.c (clear_symtab_users): Don't reset innermost_block.
10375         * printcmd.c (display_command, do_one_display): Don't reset
10376         innermost_block.
10377         * parser-defs.h (enum innermost_block_tracker_type): Move to
10378         expression.h.
10379         (innermost_block): Update comment.
10380         * parse.c (parse_exp_1): Add tracker_types parameter.
10381         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
10382         tracker_types parameter.  Reset innermost_block.
10383         (parse_exp_in_context): Remove.
10384         (parse_expression_for_completion): Update.
10385         * objfiles.c (~objfile): Don't reset expression_context_block or
10386         innermost_block.
10387         * expression.h (enum innermost_block_tracker_type): Move from
10388         parser-defs.h.
10389         (parse_exp_1): Add tracker_types parameter.
10390         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
10391         reset innermost_block.
10392
10393 2019-03-23  Tom Tromey  <tom@tromey.com>
10394
10395         * objfiles.h: Include bcache.h.
10396
10397 2019-03-23  Tom Tromey  <tom@tromey.com>
10398
10399         * linespec.c (get_current_search_block): Use
10400         scoped_restore_current_language.
10401         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
10402
10403 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10404             Jiong Wang  <jiong.wang@arm.com>
10405
10406         * aarch64-linux-tdep.c
10407         (aarch64_linux_iterate_over_regset_sections): Check for pauth
10408         section.
10409         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
10410
10411 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10412             Jiong Wang  <jiong.wang@arm.com>
10413
10414         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
10415         instructions.
10416         (aarch64_analyze_prologue_test): Add PACIASP test.
10417         (aarch64_prologue_prev_register): Unmask PC value.
10418
10419 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10420             Jiong Wang  <jiong.wang@arm.com>
10421
10422         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
10423         (aarch64_dwarf2_prev_register): Unmask PC value.
10424         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
10425         (aarch64_execute_dwarf_cfa_vendor_op): Check for
10426         DW_CFA_AARCH64_negate_ra_state.
10427         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
10428
10429 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10430             Jiong Wang  <jiong.wang@arm.com>
10431
10432         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
10433         registers.
10434         (aarch64_pseudo_register_name): Likewise.
10435         (aarch64_pseudo_register_type): Likewise.
10436         (aarch64_pseudo_register_reggroup_p): Likewise.
10437         (aarch64_gdbarch_init): Add pauth registers.
10438         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
10439         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
10440         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
10441         (struct gdbarch_tdep): Add regnum for ra_state.
10442
10443 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10444             Jiong Wang  <jiong.wang@arm.com>
10445
10446         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
10447
10448 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10449             Jiong Wang  <jiong.wang@arm.com>
10450
10451         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
10452         function.
10453         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
10454         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
10455         (aarch64_gdbarch_init): Add puth registers.
10456         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
10457         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
10458         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
10459
10460 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10461             Jiong Wang  <jiong.wang@arm.com>
10462
10463         * aarch64-linux-nat.c
10464         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
10465         * aarch64-linux-tdep.c
10466         (aarch64_linux_core_read_description): Likewise.
10467         (aarch64_linux_get_hwcap): New function.
10468         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
10469         (aarch64_linux_get_hwcap): New declaration.
10470
10471 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10472             Jiong Wang  <jiong.wang@arm.com>
10473
10474         * aarch64-linux-nat.c
10475         (aarch64_linux_nat_target::read_description): Add pauth param.
10476         * aarch64-linux-tdep.c
10477         (aarch64_linux_core_read_description): Likewise.
10478         * aarch64-tdep.c (struct target_desc): Add in pauth.
10479         (aarch64_read_description): Add pauth param.
10480         (aarch64_gdbarch_init): Likewise.
10481         * aarch64-tdep.h (aarch64_read_description): Likewise.
10482         * arch/aarch64.c (aarch64_create_target_description): Likewise.
10483         * arch/aarch64.h (aarch64_create_target_description): Likewise.
10484         * features/Makefile: Add new files.
10485         * features/aarch64-pauth.c: New file.
10486         * features/aarch64-pauth.xml: New file.
10487
10488 2019-03-20  Tom Tromey  <tromey@adacore.com>
10489
10490         * infrun.c (handle_inferior_event): Rename from
10491         handle_inferior_event_1.  Create a scoped_value_mark.
10492         (handle_inferior_event): Remove.
10493
10494 2019-03-19  Tom Tromey  <tromey@adacore.com>
10495
10496         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
10497         * infrun.h (print_stop_event): Add "displays" parameter.
10498         * infrun.c (print_stop_event): Add "displays" parameter.
10499
10500 2019-03-19  Pedro Alves  <palves@redhat.com>
10501
10502         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
10503         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
10504         to -1.  Fix TABs vs spaces.
10505         (tui_ui_out::tui_ui_out): Don't initialize fields here.
10506         * tui/tui-out.h (tui_ui_out) Add intro comments.
10507         <m_line, m_start_of_line>: In-class initialize, and add describing
10508         comment.
10509
10510 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
10511
10512         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
10513         variable names.
10514         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
10515
10516 2019-03-18  Pedro Alves  <palves@redhat.com>
10517             Eli Zaretskii <eliz@gnu.org>
10518
10519         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
10520         m_line and m_start_of_line.
10521
10522 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
10523
10524         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
10525         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
10526         it returns a newline.  This fixes a regression in TU mode, whereby
10527         the next line is output on the same screen line as the user input.
10528
10529 2019-03-18  Tom Tromey  <tromey@adacore.com>
10530
10531         * minsyms.c (minimal_symbol_reader::install): Remove call to
10532         obstack_blank.
10533
10534 2019-03-18  Pedro Alves  <palves@redhat.com>
10535
10536         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
10537         New globals.
10538         (apply_style): New, factored out from ...
10539         (apply_ansi_escape): ... this.  Handle reverse video mode.
10540         (tui_set_reverse_mode): New function.
10541         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
10542         * tui/tui-winsource.c (tui_show_source_line): Use
10543         tui_set_reverse_mode instead of setting A_STANDOUT.
10544         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
10545         New setter methods.
10546
10547 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
10548
10549         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
10550         Handle tabs.
10551
10552 2019-03-18  Tom Tromey  <tromey@adacore.com>
10553
10554         * ada-lang.c (empty_array): Add "high" parameter.
10555         (ada_evaluate_subexp): Update.
10556
10557 2019-03-17  Sergei Trofimovich <siarheit@google.com>
10558
10559         * unittests/string_view-selftests.c: Define
10560         _initialize_string_view_selftests unconditionally.
10561
10562 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
10563
10564         PR gdb/24350
10565         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
10566
10567 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
10568
10569         PR gdb/24351
10570         * windows-nat.c (display_selector): Fix format specifiers.
10571
10572 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
10573
10574         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
10575         tui_refill_source_window instead of tui_refresh_win, to update the
10576         current execution line.  This fixes redisplay of the current line
10577         when stepping through the code with "next" or "step".
10578
10579 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
10580
10581         * source-cache.c (source_cache::get_source_lines): Call
10582         find_source_lines to initialize s->nlines.  This fixes vertical
10583         scrolling of TUI source window when the DOWN arrow is pressed.
10584
10585 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10586
10587         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
10588         linux-thread-db.c (_initialize_thread_db): Likewise.
10589
10590 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
10591
10592         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
10593         wclrtoeol in tui_show_source_line".  This reverts changes made in
10594         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
10595
10596 2019-03-15  Tom Tromey  <tom@tromey.com>
10597
10598         * symtab.h (struct minimal_symbol): Derive from
10599         general_symbol_info.
10600         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
10601         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
10602         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
10603         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
10604         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
10605         (MSYMBOL_SEARCH_NAME): Update.
10606         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
10607         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
10608         * minsyms.c (minimal_symbol_reader::record_full): Update.
10609
10610 2019-03-15  Tom Tromey  <tom@tromey.com>
10611
10612         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
10613
10614 2019-03-15  Tom Tromey  <tom@tromey.com>
10615
10616         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
10617         unique_xmalloc_ptr.
10618         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
10619         Update.
10620         * minsyms.c (lookup_minimal_symbol_by_pc_section)
10621         (build_minimal_symbol_hash_tables)
10622         (minimal_symbol_reader::install): Update.
10623
10624 2019-03-15  Tom Tromey  <tom@tromey.com>
10625
10626         * symtab.c (create_demangled_names_hash): Update.
10627         (symbol_set_names): Update.
10628         * objfiles.h (struct objfile_per_bfd_storage)
10629         <demangled_names_hash>: Now an htab_up.
10630         * objfiles.c (objfile_per_bfd_storage): Simplify.
10631
10632 2019-03-15  Tom Tromey  <tom@tromey.com>
10633
10634         * objfiles.h (struct objfile_per_bfd_storage): Declare
10635         destructor.
10636         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
10637         New.
10638         (get_objfile_bfd_data): Use new.  Don't initialize
10639         language_of_main.
10640         (free_objfile_per_bfd_storage): Remove.
10641         (objfile_bfd_data_free, objfile::~objfile): Use delete.
10642
10643 2019-03-15  Tom Tromey  <tom@tromey.com>
10644
10645         * symfile.c (reread_symbols): Update.
10646         * objfiles.c (objfile::objfile): Update.
10647         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
10648         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
10649         comment.
10650         (minimal_symbol_reader::install): Update.
10651         (terminate_minimal_symbol_table): Remove.
10652         * jit.c (jit_object_close_impl): Update.
10653
10654 2019-03-15  Tom Tromey  <tom@tromey.com>
10655
10656         * minsyms.c (minimal_symbol_reader::record_full): Remove some
10657         initializations.
10658
10659 2019-03-15  Tom Tromey  <tom@tromey.com>
10660
10661         * objfiles.h (struct objfile_per_bfd_storage)
10662         <demangled_hash_languages>: Now a bitset.
10663         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
10664         (lookup_minimal_symbol): Update.
10665
10666 2019-03-15  Tom Tromey  <tom@tromey.com>
10667
10668         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
10669         Don't return the symbol.
10670         * coffread.c (record_minimal_symbol): Use record_full.
10671
10672 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
10673
10674         The MS-Windows port of ncurses fails to switch to a color pair if
10675         one or both of the colors are the implicit default colors.  This
10676         change records the default colors when TUI is initialized, and
10677         then specifies them explicitly when a color pair uses the default
10678         colors.  This allows color styling in TUI mode on MS-Windows.
10679
10680         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
10681         ncurses_norm_attr.
10682         (tui_initialize_io) [__MINGW32__]: Record the default terminal
10683         colors in ncurses_norm_attr.
10684         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
10685         "none", replace it with the default color recorded in
10686         ncurses_norm_attr.
10687
10688 2019-03-14  Tom Tromey  <tromey@adacore.com>
10689
10690         * source-cache.h (class source_cache) <get_source_lines>: Return
10691         std::string.
10692         * source-cache.c (source_cache::extract_lines): Handle case where
10693         first_pos==npos.  Return std::string.
10694         (source_cache::get_source_lines): Update.
10695
10696 2019-03-14  Tom Tromey  <tromey@adacore.com>
10697
10698         * NEWS: Add item for "style sources" commands.
10699         * source-cache.c (source_cache::get_source_lines): Check
10700         source_styling.
10701         * cli/cli-style.c (source_styling): New global.
10702         (_initialize_cli_style): Add "style sources" commands.
10703         (show_style_sources): New function.
10704         * cli/cli-style.h (source_styling): Declare.
10705
10706 2019-03-14  Pedro Alves  <palves@redhat.com>
10707             Tom Tromey  <tromey@adacore.com>
10708
10709         * tui/tui-winsource.h (tui_refill_source_window): Declare.
10710         * tui/tui-winsource.c (tui_refill_source_window): New function,
10711         from...
10712         (tui_horizontal_source_scroll): ... here.  Move some logic.
10713         * cli/cli-style.c (set_style_enabled): Notify new observable.
10714         * tui/tui-hooks.c (tui_redisplay_source): New function.
10715         (tui_attach_detach_observers): Attach or detach
10716         tui_redisplay_source.
10717         * observable.h (source_styling_changed): New observable.
10718         * observable.c: Define source_styling_changed observable.
10719
10720 2019-03-13  Tom Tromey  <tromey@adacore.com>
10721
10722         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
10723         (i386_gnu_nat_target::store_registers): Update.
10724         * target-debug.h (target_debug_print_std_string): New macro.
10725         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
10726         * windows-tdep.c (display_one_tib): Update.
10727         * tui/tui-stack.c (tui_make_status_line): Update.
10728         * top.c (print_inferior_quit_action): Update.
10729         * thread.c (thr_try_catch_cmd): Update.
10730         (add_thread_with_info): Update.
10731         (thread_target_id_str): Update.
10732         (thr_try_catch_cmd): Update.
10733         (thread_command): Update.
10734         (thread_find_command): Update.
10735         * record-btrace.c (record_btrace_target::info_record)
10736         (record_btrace_resume_thread, record_btrace_target::resume)
10737         (record_btrace_cancel_resume, record_btrace_step_thread)
10738         (record_btrace_target::wait, record_btrace_target::wait)
10739         (record_btrace_target::wait, record_btrace_target::stop): Update.
10740         * progspace.c (print_program_space): Update.
10741         * process-stratum-target.c
10742         (process_stratum_target::thread_address_space): Update.
10743         * linux-fork.c (linux_fork_mourn_inferior)
10744         (detach_checkpoint_command, info_checkpoints_command)
10745         (linux_fork_context): Update.
10746         (linux_fork_detach): Update.
10747         (class scoped_switch_fork_info): Update.
10748         (delete_checkpoint_command): Update.
10749         * infrun.c (follow_fork_inferior): Update.
10750         (follow_fork_inferior): Update.
10751         (proceed_after_vfork_done): Update.
10752         (handle_vfork_child_exec_or_exit): Update.
10753         (follow_exec): Update.
10754         (displaced_step_prepare_throw): Update.
10755         (displaced_step_restore): Update.
10756         (start_step_over): Update.
10757         (resume_1): Update.
10758         (clear_proceed_status_thread): Update.
10759         (proceed): Update.
10760         (print_target_wait_results): Update.
10761         (do_target_wait): Update.
10762         (context_switch): Update.
10763         (stop_all_threads): Update.
10764         (restart_threads): Update.
10765         (finish_step_over): Update.
10766         (handle_signal_stop): Update.
10767         (switch_back_to_stepped_thread): Update.
10768         (keep_going_pass_signal): Update.
10769         (print_exited_reason): Update.
10770         (normal_stop): Update.
10771         * inferior.c (inferior_pid_to_str): Change return type.
10772         (print_selected_inferior): Update.
10773         (add_inferior): Update.
10774         (detach_inferior): Update.
10775         * dummy-frame.c (fprint_dummy_frames): Update.
10776         * dcache.c (dcache_info_1): Update.
10777         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
10778         (btrace_fetch, btrace_clear): Update.
10779         * linux-tdep.c (linux_core_pid_to_str): Change return type.
10780         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
10781         type.
10782         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
10783         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
10784         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
10785         * gdbarch.c, gdbarch.h: Rebuild.
10786         * gdbarch.sh (core_pid_to_str): Change return type.
10787         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
10788         return type.
10789         (windows_nat_target::pid_to_str): Change return type.
10790         (windows_delete_thread): Update.
10791         (windows_nat_target::attach): Update.
10792         (windows_nat_target::files_info): Update.
10793         * target-delegates.c: Rebuild.
10794         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
10795         return type.
10796         (sol_thread_target::pid_to_str): Change return type.
10797         * remote.c (class remote_target) <pid_to_str>: Change return
10798         type.
10799         (remote_target::pid_to_str): Change return type.
10800         (extended_remote_target::attach, remote_target::remote_stop_ns)
10801         (remote_target::remote_notif_remove_queued_reply)
10802         (remote_target::push_stop_reply, remote_target::disable_btrace):
10803         Update.
10804         (extended_remote_target::attach): Update.
10805         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
10806         type.
10807         (gdbsim_target::pid_to_str): Change return type.
10808         * ravenscar-thread.c (struct ravenscar_thread_target)
10809         <pid_to_str>: Change return type.
10810         (ravenscar_thread_target::pid_to_str): Change return type.
10811         * procfs.c (class procfs_target) <pid_to_str>: Change return
10812         type.
10813         (procfs_target::pid_to_str): Change return type.
10814         (procfs_target::attach): Update.
10815         (procfs_target::detach): Update.
10816         (procfs_target::fetch_registers): Update.
10817         (procfs_target::store_registers): Update.
10818         (procfs_target::wait): Update.
10819         (procfs_target::files_info): Update.
10820         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
10821         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
10822         return type.
10823         (nto_procfs_target::pid_to_str): Change return type.
10824         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
10825         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
10826         return type.
10827         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
10828         (exit_lwp): Update.
10829         (attach_proc_task_lwp_callback, get_detach_signal)
10830         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
10831         (linux_nat_target::resume, wait_lwp, stop_callback)
10832         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
10833         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
10834         (linux_nat_wait_1, resume_stopped_resumed_lwps)
10835         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
10836         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
10837         type.
10838         (inf_ptrace_target::attach): Update.
10839         (inf_ptrace_target::files_info): Update.
10840         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
10841         type.
10842         (go32_nat_target::pid_to_str): Change return type.
10843         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
10844         (gnu_nat_target::wait): Update.
10845         (gnu_nat_target::wait): Update.
10846         (gnu_nat_target::resume): Update.
10847         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
10848         (fbsd_nat_target::wait): Update.
10849         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
10850         type.
10851         (darwin_nat_target::attach): Update.
10852         * corelow.c (class core_target) <pid_to_str>: Change return type.
10853         (core_target::pid_to_str): Change return type.
10854         * target.c (normal_pid_to_str): Change return type.
10855         (default_pid_to_str): Likewise.
10856         (target_pid_to_str): Change return type.
10857         (target_translate_tls_address): Update.
10858         (target_announce_detach): Update.
10859         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
10860         return type.
10861         (bsd_uthread_target::pid_to_str): Change return type.
10862         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
10863         type.
10864         (bsd_kvm_target::pid_to_str): Change return type.
10865         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
10866         return type.
10867         (aix_thread_target::pid_to_str): Change return type.
10868         * target.h (struct target_ops) <pid_to_str>: Change return type.
10869         (target_pid_to_str, normal_pid_to_str): Likewise.
10870         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
10871         type.
10872         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
10873         type.
10874         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
10875         return type.
10876         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
10877         type.
10878         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
10879         type.
10880         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
10881         return type.
10882
10883 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
10884
10885         * NEWS: Mention that the new default MI version is 3.  Mention
10886         changes to the output of commands and events that deal with
10887         multi-location breakpoints.
10888         * breakpoint.c: Include "mi/mi-out.h".
10889         (print_one_breakpoint): Change output syntax if using MI version
10890         >= 3.
10891         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
10892         New.
10893         (mi_multi_location_breakpoint_output_fixed): New.
10894         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
10895         (mi_cmd_fix_multi_location_breakpoint_output): New.
10896         (mi_multi_location_breakpoint_output_fixed): New.
10897         * mi/mi-cmds.c (mi_cmds): Register command
10898         -fix-multi-location-breakpoint-output.
10899         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
10900         interpreter "mi".
10901
10902 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
10903
10904         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
10905         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
10906         instantiate mi_ui_out based on interpreter name.
10907         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
10908         * mi/mi-main.c (mi_load_progress): Likewise.
10909
10910 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10911
10912         * NEWS: Combine separate "New targets" sections for 8.3.
10913
10914 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10915
10916         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
10917         (ppcfbsd_init_abi): Install gdbarch
10918         "fetch_tls_load_module_address" and "get_thread_local_address"
10919         methods.
10920
10921 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10922
10923         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
10924         (riscv_fbsd_init_abi): Install gdbarch
10925         "fetch_tls_load_module_address" and "get_thread_local_address"
10926         methods.
10927
10928 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10929
10930         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
10931         (i386fbsd_init_abi): Install gdbarch
10932         "fetch_tls_load_module_address" and "get_thread_local_address"
10933         methods.
10934
10935 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10936
10937         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
10938         (amd64fbsd_init_abi): Install gdbarch
10939         "fetch_tls_load_module_address" and "get_thread_local_address"
10940         methods.
10941
10942 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10943
10944         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
10945         (struct fbsd_pspace_data): New type.
10946         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
10947         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
10948         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
10949         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
10950         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
10951
10952 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10953
10954         * gdbtypes.c (lookup_struct_elt): New function.
10955         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
10956         * gdbtypes.h (struct struct_elt): New type.
10957         (lookup_struct_elt): New prototype.
10958
10959 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10960
10961         * gdbtypes.c (lookup_struct_elt_type): Update comment and
10962         remove disabled code block.
10963
10964 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10965
10966         * gdbarch.sh (get_thread_local_address): New method.
10967         * gdbarch.h, gdbarch.c: Regenerate.
10968         * target.c (target_translate_tls_address): Use
10969         gdbarch_get_thread_local_address if present instead of
10970         target::get_thread_local_address.
10971
10972 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10973
10974         * target.h (target::get_thread_local_address): Update comment.
10975
10976 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10977
10978         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
10979         objfile->separate_debug_objfile_backlink if not NULL.
10980
10981 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10982
10983         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
10984         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
10985         (amd64bsd_store_inferior_registers): Likewise.
10986         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
10987         Enable segment base registers.
10988         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
10989         PT_GETFSBASE and PT_GETGSBASE.
10990         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
10991         PT_SETGSBASE.
10992         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
10993         segment base registers.
10994         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
10995
10996 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10997
10998         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
10999         Update calls to i386_target_description to add 'segments'
11000         parameter.
11001         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
11002         add segment base registers.
11003         * arch/i386.c (i386_create_target_description): Add 'segments'
11004         parameter to enable segment base registers.
11005         * arch/i386.h (i386_create_target_description): Likewise.
11006         * features/i386/32bit-segments.xml: New file.
11007         * features/i386/32bit-segments.c: Generate.
11008         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
11009         call to i386_target_description to add 'segments' parameter.
11010         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
11011         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
11012         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
11013         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
11014         if feature is present.
11015         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
11016         Add 'segments' parameter to call to i386_target_description.
11017         (i386_target_description): Add 'segments' parameter to enable
11018         segment base registers.
11019         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
11020         to call to i386_target_description.
11021         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
11022         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
11023         Define I386_NUM_REGS.
11024         (i386_target_description): Add 'segments' parameter to enable
11025         segment base registers.
11026
11027 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
11028
11029         PR/24325
11030         * source-cache.c: #undef open and close, to avoid unresolved
11031         externals during linking.
11032
11033 2019-03-12  Tom Tromey  <tromey@adacore.com>
11034
11035         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
11036         const.  Add initializers.
11037         (_initialize_remote): Don't initialize ptid globals.
11038
11039 2019-03-12  Pedro Alves  <palves@redhat.com>
11040
11041         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
11042
11043 2019-03-12  Pedro Alves  <palves@redhat.com>
11044
11045         * cp-name-parser.y (main): Remove unused 'len' variable.
11046
11047 2019-03-12  Tom Tromey  <tromey@adacore.com>
11048
11049         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
11050         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
11051
11052 2019-03-12  Tom Tromey  <tromey@adacore.com>
11053
11054         * linux-nat.c (iterate_over_lwps): Update.
11055         (stop_callback): Remove parameter.
11056         (stop_wait_callback, detach_callback, resume_set_callback)
11057         (select_singlestep_lwp_callback, set_ignore_sigint)
11058         (status_callback, resumed_callback, resume_clear_callback)
11059         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
11060         data parameter.
11061         (linux_nat_target::detach, linux_nat_target::resume)
11062         (linux_stop_and_wait_all_lwps, select_event_lwp)
11063         (linux_nat_filter_event, linux_nat_wait_1)
11064         (linux_nat_target::kill, linux_nat_target::stop)
11065         (linux_nat_target::stop): Update.
11066         (linux_nat_resume_callback): Change type.
11067         (resume_stopped_resumed_lwps, count_events_callback)
11068         (select_event_lwp_callback): Likewise.
11069         (linux_stop_lwp, linux_nat_stop_lwp): Update.
11070         * arm-linux-nat.c (struct update_registers_data): Remove.
11071         (update_registers_callback): Change type.
11072         (arm_linux_insert_hw_breakpoint1): Update.
11073         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
11074         parameter.
11075         (x86_linux_dr_set_addr): Update.
11076         (x86_linux_dr_set_control): Update.
11077         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
11078         (iterate_over_lwps): Use gdb::function_view.
11079         * nat/aarch64-linux-hw-point.c (struct
11080         aarch64_dr_update_callback_param): Remove.
11081         (debug_reg_change_callback): Change type.
11082         (aarch64_notify_debug_reg_change): Update.
11083         * s390-linux-nat.c (s390_refresh_per_info): Update.
11084
11085 2019-03-11  Tom Tromey  <tromey@adacore.com>
11086
11087         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
11088         redundant assignment to "this_cu".
11089
11090 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11091
11092         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
11093
11094 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11095
11096         * gdbtypes.c (rank_one_type_parm_set): New function extracted
11097         from...
11098         (rank_one_type): ... this.
11099
11100 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11101
11102         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
11103         from...
11104         (rank_one_type): ... this.
11105
11106 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11107
11108         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
11109         from...
11110         (rank_one_type): ... this.
11111
11112 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11113
11114         * gdbtypes.c (rank_one_type_parm_float): New function extracted
11115         from...
11116         (rank_one_type): ... this.
11117
11118 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11119
11120         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
11121         from...
11122         (rank_one_type): ... this.
11123
11124 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11125
11126         * gdbtypes.c (rank_one_type_parm_range): New function extracted
11127         from...
11128         (rank_one_type): ... this.
11129
11130 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11131
11132         * gdbtypes.c (rank_one_type_parm_char): New function extracted
11133         from...
11134         (rank_one_type): ... this.
11135
11136 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11137
11138         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
11139         from...
11140         (rank_one_type): ... this.
11141
11142 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11143
11144         * gdbtypes.c (rank_one_type_parm_int): New function extracted
11145         from...
11146         (rank_one_type): ... this.
11147
11148 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11149
11150         * gdbtypes.c (rank_one_type_parm_func): New function extracted
11151         from...
11152         (rank_one_type): ... this.
11153
11154 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11155
11156         * gdbtypes.c (rank_one_type_parm_array): New function extracted
11157         from...
11158         (rank_one_type): ... this.
11159
11160 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11161
11162         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
11163         from...
11164         (rank_one_type): ... this.
11165
11166 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11167
11168         * inferior.c (initialize_inferiors): Ensure 'help set/show print
11169         inferior-events' shows the example events.
11170
11171 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
11172
11173         Support styling on native MS-Windows console
11174
11175         PR/24315
11176         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
11177         on MS-Windows if $TERM is not defined.
11178
11179         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
11180
11181         * posix-hdep.c (gdb_console_fputs):
11182         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
11183         functions.
11184         * ui-file.h (gdb_console_fputs): Add prototype.
11185
11186         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
11187         back to fputs only if the former returns zero.
11188
11189 2019-03-07  Tom Tromey  <tom@tromey.com>
11190
11191         * symmisc.c (print_symbol_bcache_statistics): Update.
11192         (print_objfile_statistics): Update.
11193         * symfile.c (allocate_symtab): Update.
11194         * stabsread.c: Don't include bcache.h.
11195         * psymtab.h (struct psymbol_bcache): Don't declare.
11196         (class psymtab_storage) <psymbol_cache>: Now a bcache.
11197         (psymbol_bcache_init, psymbol_bcache_free)
11198         (psymbol_bcache_get_bcache): Don't declare.
11199         * psymtab.c (struct psymbol_bcache): Remove.
11200         (psymtab_storage::psymtab_storage): Update.
11201         (psymtab_storage::~psymtab_storage): Update.
11202         (psymbol_bcache_init, psymbol_bcache_free)
11203         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
11204         (add_psymbol_to_bcache): Update.
11205         (allocate_psymtab): Update.
11206         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
11207         macro_cache>: No longer pointers.
11208         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
11209         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
11210         * macrotab.c (macro_bcache): Update.
11211         * macroexp.c: Don't include bcache.h.
11212         * gdbtypes.c (check_types_worklist): Update.
11213         (types_deeply_equal): Remove TRY/CATCH.  Update.
11214         * elfread.c (elf_symtab_read): Update.
11215         * dwarf2read.c: Don't include bcache.h.
11216         * buildsym.c (buildsym_compunit::get_macro_table): Update.
11217         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
11218         (print_bcache_statistics, bcache_memory_used): Don't declare.
11219         (struct bcache): Move from bcache.c.  Add constructor, destructor,
11220         methods.  Rename all data members.
11221         * bcache.c (struct bcache): Move to bcache.h.
11222         (bcache::expand_hash_table): Rename from expand_hash_table.
11223         (bcache): Remove.
11224         (bcache::insert): Rename from bcache_full.
11225         (bcache::compare): Rename from bcache_compare.
11226         (bcache_xmalloc): Remove.
11227         (bcache::~bcache): Rename from bcache_xfree.
11228         (bcache::print_statistics): Rename from print_bcache_statistics.
11229         (bcache::memory_used): Rename from bcache_memory_used.
11230
11231 2019-03-07  Pedro Alves  <palves@redhat.com>
11232
11233         * infrun.c (normal_stop): Also check for
11234         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
11235
11236 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
11237
11238         * f-lang.c (value_from_host_double): Moved to...
11239         * value.c (value_from_host_double): ...here.
11240         * value.h (value_from_host_double): Declare.
11241         * guile/scm-math.c (vlscm_convert_typed_number): Use
11242         value_from_host_double.
11243         (vlscm_convert_number): Likewise.
11244         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
11245         * python/py-value.c (convert_value_from_python): Likewise.
11246
11247 2019-03-06  Tom Tromey  <tom@tromey.com>
11248
11249         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
11250
11251 2019-03-06  Tom Tromey  <tom@tromey.com>
11252
11253         * utils.h (free_current_contents): Don't declare.
11254         * utils.c (free_current_contents): Remove.
11255
11256 2019-03-06  Tom Tromey  <tom@tromey.com>
11257
11258         * top.c (quit_force): Update.
11259         * main.c (captured_command_loop): Update.
11260         * common/new-op.c (operator new): Update.
11261         * common/common-exceptions.c (struct catcher)
11262         <save_cleanup_chain>: Remove member.
11263         (exceptions_state_mc_init): Update.
11264         (exception_try_scope_entry): Return nullptr.
11265         (exception_try_scope_exit, exception_rethrow)
11266         (throw_exception_sjlj, throw_exception_cxx): Update.
11267         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
11268         (all_cleanups, do_cleanups, discard_cleanups)
11269         (discard_final_cleanups, save_cleanups, save_final_cleanups)
11270         (restore_cleanups, restore_final_cleanups): Don't declare.
11271         (do_final_cleanups): Remove parameter.
11272         * common/cleanups.c (cleanup_chain, make_cleanup)
11273         (make_cleanup_dtor, all_cleanups, do_cleanups)
11274         (discard_my_cleanups, discard_cleanups)
11275         (discard_final_cleanups, save_my_cleanups, save_cleanups)
11276         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
11277         (null_cleanup): Remove.
11278         (do_final_cleanups): Remove parameter.
11279
11280 2019-03-06  Tom Tromey  <tom@tromey.com>
11281
11282         * remote.c (remote_target::remote_parse_stop_reply): Use
11283         unique_xmalloc_ptr.
11284
11285 2019-03-06  Tom Tromey  <tom@tromey.com>
11286
11287         * stabsread.c (struct stabs_field_info): Rename from field_info.
11288         <list, fnlist>: Add initializers.
11289         <obstack>: New member.
11290         (read_member_functions, read_struct_fields, read_baseclasses):
11291         Allocate on obstack.  Don't use cleanups.
11292         (read_one_struct_field, read_member_functions, read_struct_fields)
11293         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
11294         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
11295         (read_struct_type): Update.
11296
11297 2019-03-06  Tom Tromey  <tom@tromey.com>
11298
11299         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
11300         * common/filestuff.h (make_cleanup_close): Don't declare.
11301         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
11302         Remove.
11303
11304 2019-03-06  Tom Tromey  <tom@tromey.com>
11305
11306         * solib-aix.c: Use make_scope_exit.
11307
11308 2019-03-06  Tom Tromey  <tom@tromey.com>
11309
11310         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
11311         Use make_scope_exit.
11312
11313 2019-03-06  Tom Tromey  <tom@tromey.com>
11314
11315         * solib-svr4.c (disable_probes_interface): Remove parameter.
11316         (svr4_handle_solib_event): Use make_scope_exit.
11317
11318 2019-03-06  Tom Tromey  <tom@tromey.com>
11319
11320         * remote.c (struct stop_reply_deleter): Remove.
11321         (stop_reply_up): Update.
11322         (struct stop_reply): Derive from notif_event.  Don't typedef.
11323         <regcache>: Now a std::vector.
11324         (stop_reply_xfree): Remove.
11325         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
11326         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
11327         (remote_target::discard_pending_stop_replies): Use delete.
11328         (remote_target::remote_parse_stop_reply): Update.
11329         (remote_target::process_stop_reply): Update.
11330         * remote-notif.h (struct notif_event): Add virtual destructor.
11331         Remove "dtr" member.
11332         (struct notif_client) <alloc_event>: Return a unique_ptr.
11333         (notif_event_xfree): Don't declare.
11334         (notif_event_up): New typedef.
11335         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
11336         (notif_event_xfree, do_notif_event_xfree): Remove.
11337         (remote_notif_state_xfree): Update.
11338
11339 2019-03-06  Tom Tromey  <tom@tromey.com>
11340
11341         * infrun.c (displaced_step_clear_cleanup): Now a
11342         forward_scope_exit type.
11343         (displaced_step_prepare_throw): Update.
11344         (displaced_step_fixup): Update.
11345
11346 2019-03-06  Tom Tromey  <tom@tromey.com>
11347
11348         * inferior.h (class inferior): Update comment.
11349         * gdbthread.h (class thread_info): Update comment.
11350
11351 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
11352             Tom Tromey  <tom@tromey.com>
11353
11354         * stabsread.h (struct stab_section_list): Remove.
11355         (coffstab_build_psymtabs): Update.
11356         * dbxread.c (symbuf_sections): Now a std::vector.
11357         (sect_idx): New global.
11358         (fill_symbuf): Update.
11359         (coffstab_build_psymtabs): Change type of stabsects parameter.
11360         Update.
11361         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
11362         std::vector.
11363         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
11364         (coff_locate_sections): Update.
11365         (coff_symfile_read): Remove cleanups.  Update.
11366         (init_stringtab): Add storage parameter.
11367         (free_stringtab, free_stringtab_cleanup): Remove.
11368         (init_lineno): Add storage parameter.
11369         (free_linetab, free_linetab_cleanup): Remove.
11370
11371 2019-03-06  Pedro Alves  <palves@redhat.com>
11372
11373         * linux-fork.c (fork_info::clobber_regs): Delete.
11374         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
11375         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
11376         comment.  Adjust.
11377         (scoped_switch_fork_info::scoped_switch_fork_info)
11378         (checkpoint_command, linux_fork_context): Adjust
11379         fork_save_infrun_state calls.
11380
11381 2019-03-06  Pedro Alves  <palves@redhat.com>
11382
11383         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
11384         (inf_has_multiple_threads): Return 'bool' and rewrite using
11385         inferior_info::threads().
11386
11387 2019-03-06  Pedro Alves  <palves@redhat.com>
11388
11389         * linux-fork.c: Include <list>.
11390         (fork_list): Now a std::list instance.
11391         (fork_info): Add ctor, dtor, and in-class initialize all fields.
11392         (forks_exist_p, find_last_fork): Adjust.
11393         (new_fork): Delete.
11394         (one_fork_p): New.
11395         (add_fork): Adjust.
11396         (free_fork): Delete, folded into fork_info::~fork_info().
11397         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
11398         Adjust.
11399         (init_fork_list): Delete.
11400         (linux_fork_killall, linux_fork_mourn_inferior)
11401         (linux_fork_detach, info_checkpoints_command): Adjust.
11402         (_initialize_linux_fork): No longer call init_fork_list.
11403
11404 2019-03-06  Pedro Alves  <palves@redhat.com>
11405
11406         * linux-fork.c (new_fork): New, split out of ...
11407         (add_fork): ... this.  Return void.  Move "first fork" special
11408         case from here, to ...
11409         (checkpoint_command): ... here.
11410         * linux-linux.h (add_fork): Return void.
11411
11412 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11413
11414         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
11415
11416 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11417             Chris January  <chris.january@arm.com>
11418             David Lecomber  <david.lecomber@arm.com>
11419
11420         * f-exp.y: New token, UNOP_INTRINSIC.
11421         (exp): New pattern using UNOP_INTRINSIC token.
11422         (f77_keywords): Add 'abs' keyword.
11423         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
11424         (value_from_host_double): New function.
11425         (evaluate_subexp_f): Support UNOP_ABS.
11426
11427 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11428
11429         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
11430         types.
11431
11432 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11433
11434         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
11435         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
11436         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
11437
11438 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11439
11440         * f-exp.y (convert_to_kind_type): Handle more type kinds.
11441
11442 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11443             Chris January  <chris.january@arm.com>
11444
11445         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
11446         * f-exp.y: Define 'KIND' token.
11447         (exp): New pattern for KIND expressions.
11448         (ptype): Handle types with a kind extension.
11449         (direct_abs_decl): Extend to spot kind extensions.
11450         (f77_keywords): Add 'kind' to the list.
11451         (push_kind_type): New function.
11452         (convert_to_kind_type): New function.
11453         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
11454         * parse.c (operator_length_standard): Likewise.
11455         * parser-defs.h (enum type_pieces): Add tp_kind.
11456         * std-operator.def: Add UNOP_KIND.
11457
11458 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11459
11460         * f-exp.y (f_parse): Set yydebug.
11461
11462 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11463
11464         * f-lang.c (evaluate_subexp_f): New function.
11465         (exp_descriptor_f): New global.
11466         (f_language_defn): Use exp_descriptor_f instead of
11467         exp_descriptor_standard.
11468
11469 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11470
11471         * f-exp.y (struct token): Add comments.
11472         (dot_ops): Remove uppercase versions and the end marker.
11473         (f77_keywords): Likewise.
11474         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
11475         entries in the dot_ops array are case insensitive, and use
11476         strncasecmp to compare strings.  Also some whitespace cleanup in
11477         this area.  Similar for the f77_keywords array, except entries in
11478         this list might be case sensitive.
11479
11480 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11481
11482         * f-exp.y (struct f77_boolean_val): Add comments.
11483         (boolean_values): Remove uppercase versions, and end marker.
11484         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
11485         and use strncasecmp to achieve case insensitivity.  Additionally,
11486         perform whitespace cleanup around this code.
11487
11488 2019-03-06  Tom Tromey  <tromey@adacore.com>
11489
11490         * remote-sim.c (gdbsim_target_open): Use result of
11491         gdb_argv::release.
11492
11493 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
11494         Dirk Schubert  <dirk.schubert@arm.com>
11495         Chris January  <chris.january@arm.com>
11496
11497         * eval.c (evaluate_subexp_standard): Call Fortran argument
11498         wrapping logic.
11499         * f-lang.c (struct value): A value which can be passed into a
11500         Fortran function call.
11501         (fortran_argument_convert): Wrap Fortran arguments in a pointer
11502         where appropriate.
11503         (struct type): Value ready for a Fortran function call.
11504         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
11505         is needed.
11506         * f-lang.h (fortran_argument_convert): Declaration.
11507         (fortran_preserve_arg_pointer): Declaration.
11508         * infcall.c (value_arg_coerce): Call Fortran argument logic.
11509
11510 2019-03-05  Tom Tromey  <tromey@adacore.com>
11511
11512         * python/py-prettyprint.c (print_string_repr): Remove #if.
11513         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
11514
11515 2019-03-05  Tom Tromey  <tromey@adacore.com>
11516
11517         * target.c (the_dummy_target): Move later.  Change type to
11518         "dummy_target".
11519         (initialize_targets): Don't initialize the_dummy_target.
11520
11521 2019-03-05  Tom Tromey  <tromey@adacore.com>
11522
11523         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
11524         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
11525
11526 2019-03-05  Tom Tromey  <tromey@adacore.com>
11527
11528         * windows-nat.c (windows_nat_target::attach)
11529         (windows_nat_target::detach): Don't call gdb_flush.
11530         * valprint.c (generic_val_print, val_print, val_print_string):
11531         Don't call gdb_flush.
11532         * utils.c (defaulted_query): Don't call gdb_flush.
11533         * typeprint.c (print_type_scalar): Don't call gdb_flush.
11534         * target.c (target_announce_detach): Don't call gdb_flush.
11535         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
11536         * remote.c (extended_remote_target::attach): Don't call
11537         gdb_flush.
11538         * procfs.c (procfs_target::detach): Don't call gdb_flush.
11539         * printcmd.c (do_examine): Don't call gdb_flush.
11540         (info_display_command): Don't call gdb_flush.
11541         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
11542         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
11543         * memattr.c (info_mem_command): Don't call gdb_flush.
11544         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
11545         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
11546         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
11547         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
11548         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
11549         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
11550         (gnu_nat_target::detach): Don't call gdb_flush.
11551         * f-valprint.c (f_val_print): Don't call gdb_flush.
11552         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
11553         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
11554         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
11555         gdb_flush.
11556         * c-valprint.c (c_val_print): Don't call gdb_flush.
11557         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
11558
11559 2019-03-05  Tom Tromey  <tromey@adacore.com>
11560
11561         * varobj.c (update_dynamic_varobj_children): Update.
11562         (install_default_visualizer): Use reset, not release.
11563         * value.c (set_internalvar): Update.
11564         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
11565         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
11566         ATTRIBUTE_UNUSED_RESULT.
11567
11568 2019-03-05  Tom Tromey  <tromey@adacore.com>
11569
11570         * remote.c (class scoped_remote_fd) <release>: Add
11571         ATTRIBUTE_UNUSED_RESULT.
11572
11573 2019-03-05  Tom Tromey  <tromey@adacore.com>
11574
11575         * macroexp.c (struct macro_buffer) <release>: Add
11576         ATTRIBUTE_UNUSED_RESULT.
11577
11578 2019-03-05  Tom Tromey  <tromey@adacore.com>
11579
11580         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
11581         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
11582         ATTRIBUTE_UNUSED_RESULT.
11583
11584 2019-03-05  Tom Tromey  <tromey@adacore.com>
11585
11586         * common/scoped_fd.h (class scoped_fd) <release>: Add
11587         ATTRIBUTE_UNUSED_RESULT.
11588
11589 2019-03-05  Tom Tromey  <tromey@adacore.com>
11590
11591         * parser-defs.h (struct parser_state) <release>: Add
11592         ATTRIBUTE_UNUSED_RESULT.
11593
11594 2019-03-05  Tom Tromey  <tromey@adacore.com>
11595
11596         * utils.h (class gdb_argv) <release>: Add
11597         ATTRIBUTE_UNUSED_RESULT.
11598         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
11599
11600 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
11601
11602         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
11603         for-loop range, to avoid compiler warnings.
11604
11605         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
11606         avoid compiler warnings about unused variables.
11607
11608         * NEWS: Mention end of support for native debugging on MS-Windows
11609         before XP.
11610
11611         PR gdb/24292
11612         * common/netstuff.c:
11613         * gdbserver/gdbreplay.c
11614         * gdbserver/remote-utils.c:
11615         * ser-tcp.c:
11616         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
11617         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
11618         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
11619         'getaddrinfo' and 'freeaddrinfo' were not available before
11620         Windows XP, and mingw.org's MinGW headers by default define
11621         _WIN32_WINNT to 0x500.
11622
11623 2019-03-01  Gary Benson <gbenson@redhat.com>
11624
11625         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
11626
11627 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
11628             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
11629
11630         PR gdb/8527
11631         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
11632         set_sigint_trap, clear_sigint_trap.
11633
11634 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11635
11636         * target.c (target_detach): Clear the regcache and the
11637         frame cache.
11638
11639 2019-02-27  Pedro Alves  <palves@redhat.com>
11640
11641         * utils.c (set_screen_size): When we cap the height/width sizes,
11642         tweak the corresponding command variable to show "unlimited":
11643
11644 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
11645             Pedro Alves  <palves@redhat.com>
11646
11647         * utils.c (set_screen_size): Reduce "infinite" rows and columns
11648         before calling rl_set_screen_size.
11649
11650 2019-02-27  Tom Tromey  <tromey@adacore.com>
11651
11652         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
11653         define.
11654         * python/py-value.c: Remove Python 2.4 workaround.
11655         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
11656         workaround.
11657         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
11658         Python 2.4 workaround.
11659         * python/python-internal.h: Remove Python 2.4 comment.
11660         (Py_ssize_t): Don't define.
11661         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
11662         (gdb_Py_DECREF): Remove Python 2.4 workaround.
11663         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
11664         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
11665         * python/python.c (do_start_initialization): Remove Python 2.4
11666         workaround.
11667         * python/py-prettyprint.c (class dummy_python_frame): Remove.
11668         (print_children): Remove Python 2.4 workaround.
11669         * python/py-inferior.c (buffer_procs): Remove Python 2.4
11670         workaround.
11671         (CHARBUFFERPROC_NAME): Remove.
11672         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
11673         Python 2.4 workaround.
11674
11675 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
11676
11677         * NEWS: Note minimum Python version.
11678
11679 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
11680
11681         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
11682         code from these functions.  Remove corresponding ifdefs.  Use
11683         Py_buffer_up instead of explicit calls to PyBuffer_Release.
11684         Remove gotos and target of gotos.
11685         (infpy_search_memory): Likewise.
11686
11687 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11688
11689         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
11690         (hppa_gdbarch_init): Don't register deleted functions with
11691         gdbarch.
11692
11693 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11694
11695         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
11696         (h8300_unwind_sp): Delete.
11697         (h8300_dummy_id): Delete.
11698         (h8300_gdbarch_init): Don't register deleted functions with
11699         gdbarch.
11700
11701 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11702
11703         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
11704         (ft32_unwind_pc): Delete.
11705         (ft32_unwind_sp): Delete.
11706         (ft32_gdbarch_init): Don't register deleted functions with
11707         gdbarch.
11708
11709 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11710
11711         * gdb/frv-tdep.c (frv_dummy_id): Delete.
11712         (frv_unwind_pc): Delete.
11713         (frv_unwind_sp): Delete.
11714         (frv_gdbarch_init): Don't register deleted functions with
11715         gdbarch.
11716
11717 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11718
11719         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
11720         (riscv_unwind_pc): Delete.
11721         (riscv_unwind_sp): Delete.
11722         (riscv_gdbarch_init): Don't register deleted functions with
11723         gdbarch.
11724
11725 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11726
11727         * gdb/csky-tdep.c (csky_dummy_id): Delete.
11728         (csky_unwind_pc): Delete.
11729         (csky_unwind_sp): Delete.
11730         (csky_gdbarch_init): Don't register deleted functions with
11731         gdbarch.
11732
11733 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11734
11735         * gdb/cris-tdep.c (cris_dummy_id): Delete.
11736         (cris_unwind_pc): Delete.
11737         (cris_unwind_sp): Delete.
11738         (cris_gdbarch_init): Don't register deleted functions with
11739         gdbarch.
11740
11741 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11742
11743         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
11744         (bfin_unwind_pc): Delete.
11745         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
11746
11747 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11748
11749         * gdb/arm-tdep.c (arm_dummy_id): Delete.
11750         (arm_unwind_pc): Delete.
11751         (arm_unwind_sp): Delete.
11752         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
11753
11754 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11755
11756         * gdb/arc-tdep.c (arc_dummy_id): Delete.
11757         (arc_unwind_pc): Delete.
11758         (arc_unwind_sp): Delete.
11759         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
11760
11761 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11762
11763         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
11764         (alpha_unwind_pc): Delete.
11765         (alpha_gdbarch_init): Don't register deleted functions with
11766         gdbarch.
11767
11768 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11769
11770         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
11771         (aarch64_unwind_pc): Delete.
11772         (aarch64_unwind_sp): Delete.
11773         (aarch64_gdbarch_init): Don't register deleted functions with
11774         gdbarch.
11775
11776 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11777
11778         * gdbtypes.c (type_align): Don't consider static members when
11779         computing structure alignment.
11780
11781 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11782
11783         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
11784         return 0 for other types.
11785         * arch-utils.c (default_type_align): Always return 0.
11786         * gdbarch.h: Regenerate.
11787         * gdbarch.sh (type_align): Extend comment.
11788         * gdbtypes.c (type_align): Add additional comments, always call
11789         gdbarch_type_align before applying the default rules.
11790         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
11791         generic code will then apply a suitable default.
11792         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
11793         types, return 0 for other types.
11794
11795 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
11796
11797         * NEWS: Create a new section for the next release branch.
11798         Rename the section of the current branch, now that it has
11799         been cut.
11800
11801 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
11802
11803         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
11804         * version.in: Bump version to 8.3.50.DATE-git.
11805
11806 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
11807
11808         * aix-thread.c (ptid_cmp): Remove unused variable.
11809         (get_signaled_thread): Likewise.
11810         (store_regs_user_thread): Likewise.
11811         (store_regs_kernel_thread): Likewise.
11812         (fetch_regs_kernel_thread): Remove shadowed variable.
11813
11814 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
11815
11816         * features/riscv/32bit-cpu.xml: Add register numbers.
11817         * features/riscv/32bit-fpu.c: Regenerate.
11818         * features/riscv/32bit-fpu.xml: Add register numbers.
11819         * features/riscv/64bit-cpu.xml: Add register numbers.
11820         * features/riscv/64bit-fpu.c: Regenerate.
11821         * features/riscv/64bit-fpu.xml: Add register numbers.
11822
11823 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
11824
11825         * NEWS: Mention two argument form of gdb.Value constructor.
11826         * python/py-value.c (convert_buffer_and_type_to_value): New
11827         function.
11828         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
11829         Add support for handling an optional second argument.  Call
11830         convert_buffer_and_type_to_value as appropriate.
11831         * python/python-internal.h (Py_buffer_deleter): New struct.
11832         (Py_buffer_up): New typedef.
11833
11834 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
11835
11836         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
11837         instead of releasing ownership.
11838
11839 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
11840
11841         * dwarf2read.c (open_and_init_dwp_file): Call
11842         elf_numsections instead of bfd_count_sections to initialize
11843         dwp_file->num_sections.
11844
11845 2019-02-25  Tom Tromey  <tromey@adacore.com>
11846
11847         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
11848
11849 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
11850
11851         * gcore.in: Add '--readnever' option when invoking GDB.
11852
11853 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
11854
11855         * MAINTAINERS: Update my email address.
11856
11857 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
11858
11859         * build-id.c (build_id_to_debug_bfd_1): New function.
11860         (build_id_to_debug_bfd): Look for separate debug file in
11861         sysroot.
11862
11863 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
11864
11865         * gdbarch.sh: Update the copyright year range that is placed into
11866         generated files.
11867
11868 2019-02-22  Keith Seitz  <keiths@redhat.com>
11869
11870         PR symtab/23853
11871         * linespec.c (create_sals_line_offset): Search for the default
11872         symtab's filename instead of its fullname.
11873
11874 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
11875
11876         * NEWS: Update style defaults.
11877
11878 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
11879
11880         * main.c (captured_main_1): Disable styling in batch mode.
11881
11882 2019-02-20  Tom Tromey  <tom@tromey.com>
11883
11884         * symtab.c (symtab_symbol_info): Fix typos.
11885
11886 2019-02-20  Tom Tromey  <tromey@adacore.com>
11887
11888         * findcmd.c (_initialize_mem_search): Use upper case for
11889         metasyntactic variables.
11890
11891 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
11892
11893         * aarch64-tdep.c (aarch64_add_reggroups): New function.
11894         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
11895
11896 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
11897
11898         * top.h (source_file_name): Change to std::string.
11899         * top.c (source_file_name): Likewise.
11900         (command_line_input): Adjust.
11901         * cli/cli-script.c (script_from_file): Adjust.
11902
11903 2019-02-19  Tom Tromey  <tromey@adacore.com>
11904
11905         * ravenscar-thread.c
11906         (ravenscar_thread_target::update_thread_list): Don't call
11907         ada_build_task_list.
11908         * ada-lang.h (ada_build_task_list): Don't declare.
11909         * ada-tasks.c (struct ada_tasks_inferior_data)
11910         <task_list_valid_p>: Now bool.
11911         (read_known_tasks, ada_task_list_changed)
11912         (ada_tasks_invalidate_inferior_data): Update.
11913         (read_known_tasks_array): Return bool.
11914         (read_known_tasks_list): Likewise.
11915         (read_known_tasks): Return void.
11916         (ada_build_task_list): Now static.
11917
11918 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
11919
11920         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
11921         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
11922
11923 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11924
11925         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
11926         variant for ada_tasks_pspace_data_handle and
11927         ada_tasks_inferior_data_handle.
11928         (ada_tasks_pspace_data_cleanup): New function.
11929         (ada_tasks_inferior_data_cleanup): New function.
11930
11931 2019-02-17  Tom Tromey  <tom@tromey.com>
11932
11933         * macrotab.h (macro_source_fullname): Return a std::string.
11934         * macrotab.c (macro_include, check_for_redefinition)
11935         (macro_undef, macro_lookup_definition, foreach_macro)
11936         (foreach_macro_in_scope): Update.
11937         (macro_source_fullname): Return a std::string.
11938         * macrocmd.c (show_pp_source_pos): Update.
11939
11940 2019-02-17  Tom Tromey  <tom@tromey.com>
11941
11942         * macrocmd.c (show_pp_source_pos): Style the file names.
11943
11944 2019-02-17  Tom Tromey  <tom@tromey.com>
11945
11946         PR tui/24197:
11947         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
11948
11949 2019-02-17  Tom Tromey  <tom@tromey.com>
11950
11951         * ada-lang.c (user_select_syms): Use filtered printing.
11952         * utils.c (wrap_style): New global.
11953         (desired_style): Remove.
11954         (emit_style_escape): Add stream parameter.
11955         (set_output_style, reset_terminal_style, prompt_for_continue):
11956         Update.
11957         (flush_wrap_buffer): Only flush gdb_stdout.
11958         (wrap_here): Set wrap_style.
11959         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
11960         treat escape sequences as a character.  Change when wrap buffer is
11961         flushed.
11962         (fputs_styled): Do not set the output style when the default is
11963         requested.
11964         * ui-style.h (struct ui_file_style) <is_default>: New method.
11965         * source.c (print_source_lines_base): Emit escape sequences in one
11966         piece.
11967
11968 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
11969
11970         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
11971         integers and enumeration types.
11972
11973 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
11974
11975         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
11976         instead of lookup_symbol_in_language
11977         (do_exact_match): New function.
11978         (ada_get_symbol_name_matcher): Return do_exact_match when
11979         doing a verbatim match.
11980
11981 2019-02-15  Tom Tromey  <tromey@adacore.com>
11982
11983         * ravenscar-thread.c (ravenscar_thread_target::resume)
11984         (ravenscar_thread_target::wait): Special case wildcard requests.
11985
11986 2019-02-15  Tom Tromey  <tromey@adacore.com>
11987
11988         * ravenscar-thread.c (base_ptid): Remove.
11989         (struct ravenscar_thread_target) <close>: New method.
11990         <m_base_ptid>: New member.
11991         <update_inferior_ptid, active_task, task_is_currently_active,
11992         runtime_initialized>: Declare methods.
11993         <ravenscar_thread_target>: Add constructor.
11994         (ravenscar_thread_target::task_is_currently_active)
11995         (ravenscar_thread_target::update_inferior_ptid)
11996         (ravenscar_runtime_initialized): Rename.  Now methods.
11997         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
11998         (ravenscar_thread_target::update_thread_list): Update.
11999         (ravenscar_thread_target::active_task): Now method.
12000         (ravenscar_thread_target::store_registers)
12001         (ravenscar_thread_target::prepare_to_store)
12002         (ravenscar_thread_target::prepare_to_store)
12003         (ravenscar_thread_target::mourn_inferior): Update.
12004         (ravenscar_inferior_created): Use "new" to create target.
12005         (ravenscar_thread_target::get_ada_task_ptid): Update.
12006         (_initialize_ravenscar): Don't initialize base_ptid.
12007         (ravenscar_ops): Remove global.
12008
12009 2019-02-15  Tom Tromey  <tromey@adacore.com>
12010
12011         * target.h (push_target): Declare new overload.
12012         * target.c (push_target): New overload, taking an rvalue reference.
12013         * remote.c (remote_target::open_1): Use push_target overload.
12014         * corelow.c (core_target_open): Use push_target overload.
12015
12016 2019-02-15  Tom Tromey  <tromey@adacore.com>
12017
12018         * ravenscar-thread.c (is_ravenscar_task)
12019         (ravenscar_task_is_currently_active): Return bool.
12020         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
12021         (_initialize_ravenscar): Remove "(void)".
12022         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
12023         Return bool.
12024
12025 2019-02-15  Tom Tromey  <tromey@adacore.com>
12026
12027         * ravenscar-thread.c (ravenscar_runtime_initializer)
12028         (has_ravenscar_runtime, get_running_thread_id)
12029         (ravenscar_thread_target::resume): Fix indentation.
12030
12031 2019-02-15  Tom Tromey  <tromey@adacore.com>
12032
12033         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
12034         from ravenscar_arch_ops.
12035         (sparc_ravenscar_ops::fetch_registers)
12036         (sparc_ravenscar_ops::store_registers): Now methods.
12037         (sparc_ravenscar_prepare_to_store): Remove.
12038         (sparc_ravenscar_ops): Redefine.
12039         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
12040         methods and destructor.  Remove members.
12041         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
12042         (ravenscar_thread_target::store_registers)
12043         (ravenscar_thread_target::prepare_to_store): Update.
12044         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
12045         Remove.
12046         (struct ppc_ravenscar_powerpc_ops): Derive from
12047         ravenscar_arch_ops.
12048         (ppc_ravenscar_powerpc_ops::fetch_registers)
12049         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
12050         (ppc_ravenscar_powerpc_ops): Redefine.
12051         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
12052         (ppc_ravenscar_e500_ops::fetch_registers)
12053         (ppc_ravenscar_e500_ops::store_registers): Now methods.
12054         (ppc_ravenscar_e500_ops): Redefine.
12055         * aarch64-ravenscar-thread.c
12056         (aarch64_ravenscar_generic_prepare_to_store): Remove.
12057         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
12058         (aarch64_ravenscar_fetch_registers)
12059         (aarch64_ravenscar_store_registers): Now methods.
12060         (aarch64_ravenscar_ops): Redefine.
12061
12062 2019-02-15  Tom Tromey  <tromey@adacore.com>
12063
12064         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
12065         (ravenscar_thread_target::stopped_by_hw_breakpoint)
12066         (ravenscar_thread_target::stopped_by_watchpoint)
12067         (ravenscar_thread_target::stopped_data_address)
12068         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
12069
12070 2019-02-15  Tom Tromey  <tromey@adacore.com>
12071
12072         * ravenscar-thread.c: Fix some typos.
12073
12074 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12075             Tom Tromey  <tromey@adacore.com>
12076
12077         * ada-lang.c (ada_exception_sal): Change addr_string to a
12078         std::string.
12079         (create_ada_exception_catchpoint): Update.
12080
12081 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12082             Tom Tromey  <tromey@adacore.com>
12083
12084         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
12085         (bp_location_ops): Remove.
12086         (base_breakpoint_allocate_location): Update.
12087         (free_bp_location): Update.
12088         * ada-lang.c (class ada_catchpoint_location)
12089         <ada_catchpoint_location>: Remove ops parameter.
12090         (ada_catchpoint_location_dtor): Remove.
12091         (ada_catchpoint_location_ops): Remove.
12092         (allocate_location_exception): Update.
12093         * breakpoint.h (struct bp_location_ops): Remove.
12094         (class bp_location) <bp_location>: Remove bp_location_ops
12095         parameter.
12096         <~bp_location>: Add destructor.
12097         <ops>: Remove.
12098
12099 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
12100             Pedro Alves  <palves@redhat.com>
12101
12102         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
12103         'PATH_MAX'.
12104
12105 2019-02-14  David Michael  <fedora.dm0@gmail.com>
12106             Samuel Thibault  <samuel.thibault@gnu.org>
12107             Thomas Schwinge  <thomas@codesourcery.com>
12108
12109         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
12110         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
12111
12112 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
12113
12114         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
12115         (check_empty): Use "const char *".
12116
12117         * gnu-nat.c (gnu_nat_target::detach): Instead of
12118         'detach_inferior (pid)' call
12119         'detach_inferior (find_inferior_pid (pid))'.
12120
12121         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
12122         'nat/fork-inferior.o'.
12123         * gnu-nat.c: #include "nat/fork-inferior.h".
12124
12125         * gnu-nat.c (gnu_nat_target::detach): Instead of
12126         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
12127         * gnu-nat.h: #include "inf-child.h".
12128         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
12129         'i386_gnu_nat_target::fetch_registers'.
12130         (gnu_store_registers): Rename/move to
12131         'i386_gnu_nat_target::store_registers'.
12132
12133         * config/i386/nm-i386gnu.h: Don't "#include" any files.
12134         * gnu-nat.h (mach_thread_info): New function.
12135         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
12136
12137         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
12138
12139 2019-02-14  Frederic Konrad  <konrad@adacore.com>
12140
12141         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
12142
12143 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
12144
12145         * windows-nat.c (windows_add_thread): Add new parameter
12146         "main_thread_p" with default value set to false.  Update
12147         function documentation as well as all callers.
12148         (windows_delete_thread): Likewise.
12149         (fake_create_process): Update call to windows_add_thread.
12150         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
12151         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
12152         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
12153         call to windows_delete_thread.
12154
12155 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
12156
12157         * MAINTAINERS: Add Andrew Burgess as global maintainer.
12158
12159 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
12160
12161         * symfile.c (find_separate_debug_file): Use canonical path of
12162         sysroot with child_path instead of gdb_sysroot if it is valid.
12163
12164 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
12165
12166         * symfile.c (find_separate_debug_file): Use child_path to
12167         determine if an object file is under a sysroot.
12168
12169 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
12170
12171         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
12172         unittests/child-path-selftests.c.
12173         * common/pathstuff.c (child_path): New function.
12174         * common/pathstuff.h (child_path): New prototype.
12175         * unittests/child-path-selftests.c: New file.
12176
12177 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
12178
12179         * symfile.c (find_separate_debug_file): Look for separate debug
12180         files in debug directories under the sysroot.
12181
12182 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12183
12184         * symtab.h (struct minimal_symbol data_p): New const method.
12185         (struct minimal_symbol text_p): Likewise.
12186         * symtab.c (output_source_filename): Use file name style
12187         to print file name.
12188         (print_symbol_info): Likewise.
12189         (print_msymbol_info): Use address style to print addresses.
12190         Use function name style to print executable text symbols.
12191         (expand_symtab_containing_pc): Use data_p.
12192         (find_pc_sect_compunit_symtab): Likewise.
12193
12194 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12195
12196         * breakpoint.c (describe_other_breakpoints): Use address style
12197         to print addresses.
12198         (say_where): Likewise.
12199
12200 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12201
12202         * ada-typeprint.c (print_func_type): Print function name
12203         style to print function name.
12204         * c-typeprint.c (c_print_type_1): Likewise.
12205
12206 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
12207
12208         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
12209         for execve.
12210
12211 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12212
12213         * c-exp.y (direct_abs_decl): Use emplace_back to record the
12214         type_stack.
12215
12216 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
12217
12218         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
12219         TYPE_CODE_REF types.
12220
12221 2019-02-08  Jim Wilson  <jimw@sifive.com>
12222
12223         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
12224         (riscv_linux_fregset): New.
12225         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
12226
12227 2019-02-07  Tom Tromey  <tom@tromey.com>
12228
12229         * thread.c (thread_cancel_execution_command): Update.
12230         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
12231         methods.
12232         (struct thread_fsm_ops): Remove.
12233         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
12234         (thread_fsm_should_stop, thread_fsm_return_value)
12235         (thread_fsm_set_finished, thread_fsm_finished_p)
12236         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
12237         Don't declare.
12238         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
12239         * infrun.c (clear_proceed_status_thread)
12240         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
12241         (print_stop_event): Update.
12242         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
12243         Add constructor.
12244         (step_command_fsm_ops): Remove.
12245         (new_step_command_fsm): Remove.
12246         (step_1): Update.
12247         (step_command_fsm::should_stop): Rename from
12248         step_command_fsm_should_stop.
12249         (step_command_fsm::clean_up): Rename from
12250         step_command_fsm_clean_up.
12251         (step_command_fsm::do_async_reply_reason): Rename from
12252         step_command_fsm_async_reply_reason.
12253         (struct until_next_fsm): Inherit from thread_fsm.  Add
12254         constructor.
12255         (until_next_fsm_ops): Remove.
12256         (new_until_next_fsm): Remove.
12257         (until_next_fsm::should_stop): Rename from
12258         until_next_fsm_should_stop.
12259         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
12260         (until_next_fsm::do_async_reply_reason): Rename from
12261         until_next_fsm_async_reply_reason.
12262         (struct finish_command_fsm): Inherit from thread_fsm.  Add
12263         constructor.  Change type of breakpoint.
12264         (finish_command_fsm_ops): Remove.
12265         (new_finish_command_fsm): Remove.
12266         (finish_command_fsm::should_stop): Rename from
12267         finish_command_fsm_should_stop.
12268         (finish_command_fsm::clean_up): Rename from
12269         finish_command_fsm_clean_up.
12270         (finish_command_fsm::return_value): Rename from
12271         finish_command_fsm_return_value.
12272         (finish_command_fsm::do_async_reply_reason): Rename from
12273         finish_command_fsm_async_reply_reason.
12274         (finish_command): Update.
12275         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
12276         Add constructor.
12277         (call_thread_fsm_ops): Remove.
12278         (call_thread_fsm::call_thread_fsm): Rename from
12279         new_call_thread_fsm.
12280         (call_thread_fsm::should_stop): Rename from
12281         call_thread_fsm_should_stop.
12282         (call_thread_fsm::should_notify_stop): Rename from
12283         call_thread_fsm_should_notify_stop.
12284         (run_inferior_call, call_function_by_hand_dummy): Update.
12285         * cli/cli-interp.c (should_print_stop_to_console): Update.
12286         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
12287         Add constructor.  Change type of location_breakpoint,
12288         caller_breakpoint.
12289         (until_break_fsm_ops): Remove.
12290         (new_until_break_fsm): Remove.
12291         (until_break_fsm::should_stop): Rename from
12292         until_break_fsm_should_stop.
12293         (until_break_fsm::clean_up): Rename from
12294         until_break_fsm_clean_up.
12295         (until_break_fsm::do_async_reply_reason): Rename from
12296         until_break_fsm_async_reply_reason.
12297         (until_break_command): Update.
12298         * thread-fsm.c: Remove.
12299         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
12300
12301 2019-02-07  Tom Tromey  <tom@tromey.com>
12302
12303         * yy-remap.h: Add include guard.
12304         * xtensa-tdep.h: Add include guard.
12305         * xcoffread.h: Rename include guard.
12306         * varobj-iter.h: Add include guard.
12307         * tui/tui.h: Rename include guard.
12308         * tui/tui-winsource.h: Rename include guard.
12309         * tui/tui-wingeneral.h: Rename include guard.
12310         * tui/tui-windata.h: Rename include guard.
12311         * tui/tui-win.h: Rename include guard.
12312         * tui/tui-stack.h: Rename include guard.
12313         * tui/tui-source.h: Rename include guard.
12314         * tui/tui-regs.h: Rename include guard.
12315         * tui/tui-out.h: Rename include guard.
12316         * tui/tui-layout.h: Rename include guard.
12317         * tui/tui-io.h: Rename include guard.
12318         * tui/tui-hooks.h: Rename include guard.
12319         * tui/tui-file.h: Rename include guard.
12320         * tui/tui-disasm.h: Rename include guard.
12321         * tui/tui-data.h: Rename include guard.
12322         * tui/tui-command.h: Rename include guard.
12323         * tic6x-tdep.h: Add include guard.
12324         * target/waitstatus.h: Rename include guard.
12325         * target/wait.h: Rename include guard.
12326         * target/target.h: Rename include guard.
12327         * target/resume.h: Rename include guard.
12328         * target-float.h: Rename include guard.
12329         * stabsread.h: Add include guard.
12330         * rs6000-tdep.h: Add include guard.
12331         * riscv-fbsd-tdep.h: Add include guard.
12332         * regformats/regdef.h: Rename include guard.
12333         * record.h: Rename include guard.
12334         * python/python.h: Rename include guard.
12335         * python/python-internal.h: Rename include guard.
12336         * python/py-stopevent.h: Rename include guard.
12337         * python/py-ref.h: Rename include guard.
12338         * python/py-record.h: Rename include guard.
12339         * python/py-record-full.h: Rename include guard.
12340         * python/py-record-btrace.h: Rename include guard.
12341         * python/py-instruction.h: Rename include guard.
12342         * python/py-events.h: Rename include guard.
12343         * python/py-event.h: Rename include guard.
12344         * procfs.h: Add include guard.
12345         * proc-utils.h: Add include guard.
12346         * p-lang.h: Add include guard.
12347         * or1k-tdep.h: Rename include guard.
12348         * observable.h: Rename include guard.
12349         * nto-tdep.h: Rename include guard.
12350         * nat/x86-linux.h: Rename include guard.
12351         * nat/x86-linux-dregs.h: Rename include guard.
12352         * nat/x86-gcc-cpuid.h: Add include guard.
12353         * nat/x86-dregs.h: Rename include guard.
12354         * nat/x86-cpuid.h: Rename include guard.
12355         * nat/ppc-linux.h: Rename include guard.
12356         * nat/mips-linux-watch.h: Rename include guard.
12357         * nat/linux-waitpid.h: Rename include guard.
12358         * nat/linux-ptrace.h: Rename include guard.
12359         * nat/linux-procfs.h: Rename include guard.
12360         * nat/linux-osdata.h: Rename include guard.
12361         * nat/linux-nat.h: Rename include guard.
12362         * nat/linux-namespaces.h: Rename include guard.
12363         * nat/linux-btrace.h: Rename include guard.
12364         * nat/glibc_thread_db.h: Rename include guard.
12365         * nat/gdb_thread_db.h: Rename include guard.
12366         * nat/gdb_ptrace.h: Rename include guard.
12367         * nat/fork-inferior.h: Rename include guard.
12368         * nat/amd64-linux-siginfo.h: Rename include guard.
12369         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
12370         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
12371         * nat/aarch64-linux.h: Rename include guard.
12372         * nat/aarch64-linux-hw-point.h: Rename include guard.
12373         * mn10300-tdep.h: Add include guard.
12374         * mips-linux-tdep.h: Add include guard.
12375         * mi/mi-parse.h: Rename include guard.
12376         * mi/mi-out.h: Rename include guard.
12377         * mi/mi-main.h: Rename include guard.
12378         * mi/mi-interp.h: Rename include guard.
12379         * mi/mi-getopt.h: Rename include guard.
12380         * mi/mi-console.h: Rename include guard.
12381         * mi/mi-common.h: Rename include guard.
12382         * mi/mi-cmds.h: Rename include guard.
12383         * mi/mi-cmd-break.h: Rename include guard.
12384         * m2-lang.h: Add include guard.
12385         * location.h: Rename include guard.
12386         * linux-record.h: Rename include guard.
12387         * linux-nat.h: Add include guard.
12388         * linux-fork.h: Add include guard.
12389         * i386-darwin-tdep.h: Rename include guard.
12390         * hppa-linux-offsets.h: Add include guard.
12391         * guile/guile.h: Rename include guard.
12392         * guile/guile-internal.h: Rename include guard.
12393         * gnu-nat.h: Rename include guard.
12394         * gdb-stabs.h: Rename include guard.
12395         * frv-tdep.h: Add include guard.
12396         * f-lang.h: Add include guard.
12397         * event-loop.h: Add include guard.
12398         * darwin-nat.h: Rename include guard.
12399         * cp-abi.h: Rename include guard.
12400         * config/sparc/nm-sol2.h: Rename include guard.
12401         * config/nm-nto.h: Rename include guard.
12402         * config/nm-linux.h: Add include guard.
12403         * config/i386/nm-i386gnu.h: Rename include guard.
12404         * config/djgpp/nl_types.h: Rename include guard.
12405         * config/djgpp/langinfo.h: Rename include guard.
12406         * compile/gcc-cp-plugin.h: Add include guard.
12407         * compile/gcc-c-plugin.h: Add include guard.
12408         * compile/compile.h: Rename include guard.
12409         * compile/compile-object-run.h: Rename include guard.
12410         * compile/compile-object-load.h: Rename include guard.
12411         * compile/compile-internal.h: Rename include guard.
12412         * compile/compile-cplus.h: Rename include guard.
12413         * compile/compile-c.h: Rename include guard.
12414         * common/xml-utils.h: Rename include guard.
12415         * common/x86-xstate.h: Rename include guard.
12416         * common/version.h: Rename include guard.
12417         * common/vec.h: Rename include guard.
12418         * common/tdesc.h: Rename include guard.
12419         * common/selftest.h: Rename include guard.
12420         * common/scoped_restore.h: Rename include guard.
12421         * common/scoped_mmap.h: Rename include guard.
12422         * common/scoped_fd.h: Rename include guard.
12423         * common/safe-iterator.h: Rename include guard.
12424         * common/run-time-clock.h: Rename include guard.
12425         * common/refcounted-object.h: Rename include guard.
12426         * common/queue.h: Rename include guard.
12427         * common/ptid.h: Rename include guard.
12428         * common/print-utils.h: Rename include guard.
12429         * common/preprocessor.h: Rename include guard.
12430         * common/pathstuff.h: Rename include guard.
12431         * common/observable.h: Rename include guard.
12432         * common/netstuff.h: Rename include guard.
12433         * common/job-control.h: Rename include guard.
12434         * common/host-defs.h: Rename include guard.
12435         * common/gdb_wait.h: Rename include guard.
12436         * common/gdb_vecs.h: Rename include guard.
12437         * common/gdb_unlinker.h: Rename include guard.
12438         * common/gdb_unique_ptr.h: Rename include guard.
12439         * common/gdb_tilde_expand.h: Rename include guard.
12440         * common/gdb_sys_time.h: Rename include guard.
12441         * common/gdb_string_view.h: Rename include guard.
12442         * common/gdb_splay_tree.h: Rename include guard.
12443         * common/gdb_setjmp.h: Rename include guard.
12444         * common/gdb_ref_ptr.h: Rename include guard.
12445         * common/gdb_optional.h: Rename include guard.
12446         * common/gdb_locale.h: Rename include guard.
12447         * common/gdb_assert.h: Rename include guard.
12448         * common/filtered-iterator.h: Rename include guard.
12449         * common/filestuff.h: Rename include guard.
12450         * common/fileio.h: Rename include guard.
12451         * common/environ.h: Rename include guard.
12452         * common/common-utils.h: Rename include guard.
12453         * common/common-types.h: Rename include guard.
12454         * common/common-regcache.h: Rename include guard.
12455         * common/common-inferior.h: Rename include guard.
12456         * common/common-gdbthread.h: Rename include guard.
12457         * common/common-exceptions.h: Rename include guard.
12458         * common/common-defs.h: Rename include guard.
12459         * common/common-debug.h: Rename include guard.
12460         * common/cleanups.h: Rename include guard.
12461         * common/buffer.h: Rename include guard.
12462         * common/btrace-common.h: Rename include guard.
12463         * common/break-common.h: Rename include guard.
12464         * cli/cli-utils.h: Rename include guard.
12465         * cli/cli-style.h: Rename include guard.
12466         * cli/cli-setshow.h: Rename include guard.
12467         * cli/cli-script.h: Rename include guard.
12468         * cli/cli-interp.h: Rename include guard.
12469         * cli/cli-decode.h: Rename include guard.
12470         * cli/cli-cmds.h: Rename include guard.
12471         * charset-list.h: Add include guard.
12472         * buildsym-legacy.h: Rename include guard.
12473         * bfin-tdep.h: Add include guard.
12474         * ax.h: Rename include guard.
12475         * arm-linux-tdep.h: Add include guard.
12476         * arm-fbsd-tdep.h: Add include guard.
12477         * arch/xtensa.h: Rename include guard.
12478         * arch/tic6x.h: Add include guard.
12479         * arch/i386.h: Add include guard.
12480         * arch/arm.h: Rename include guard.
12481         * arch/arm-linux.h: Rename include guard.
12482         * arch/arm-get-next-pcs.h: Rename include guard.
12483         * arch/amd64.h: Add include guard.
12484         * arch/aarch64-insn.h: Rename include guard.
12485         * arch-utils.h: Rename include guard.
12486         * annotate.h: Add include guard.
12487         * amd64-darwin-tdep.h: Rename include guard.
12488         * aarch64-linux-tdep.h: Add include guard.
12489         * aarch64-fbsd-tdep.h: Add include guard.
12490         * aarch32-linux-nat.h: Add include guard.
12491
12492 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12493
12494         * macrotab.c (macro_define_internal): New function that
12495         factorizes macro_define_object_internal and macro_define_function
12496         code.
12497         (macro_define_object_internal): Use macro_define_internal.
12498         (macro_define_function): Likewise.
12499
12500 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12501
12502         * macrocmd.c (extract_identifier): Return
12503         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
12504         callers.
12505
12506 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
12507
12508         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
12509
12510 2019-02-05  Tom Tromey  <tom@tromey.com>
12511
12512         * target.c (target_stack::unpush): Move assertion earlier.
12513
12514 2019-01-30  Tom Tromey  <tom@tromey.com>
12515
12516         PR python/23615:
12517         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
12518         (gdbpy_parse_and_eval): Likewise.
12519         * python/python-internal.h (gdbpy_allow_threads): New class.
12520
12521 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
12522
12523         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
12524         (aarch64_fbsd_fpregmap): Move earlier.
12525         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
12526         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
12527         instead of individual calls to trad_frame_set_reg_addr.
12528         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
12529         earlier.
12530         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
12531         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
12532         instead of individual calls to trad_frame_set_reg_addr.
12533
12534 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
12535
12536         * CONTRIBUTE: Replace contribution list with wiki link.
12537
12538 2019-01-25  Tom Tromey  <tom@tromey.com>
12539
12540         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
12541
12542 2019-01-25  Tom Tromey  <tom@tromey.com>
12543
12544         * xtensa-linux-nat.c: Fix common/ includes.
12545         * xml-support.h: Fix common/ includes.
12546         * xml-support.c: Fix common/ includes.
12547         * x86-linux-nat.c: Fix common/ includes.
12548         * windows-nat.c: Fix common/ includes.
12549         * varobj.h: Fix common/ includes.
12550         * varobj.c: Fix common/ includes.
12551         * value.c: Fix common/ includes.
12552         * valops.c: Fix common/ includes.
12553         * utils.c: Fix common/ includes.
12554         * unittests/xml-utils-selftests.c: Fix common/ includes.
12555         * unittests/utils-selftests.c: Fix common/ includes.
12556         * unittests/unpack-selftests.c: Fix common/ includes.
12557         * unittests/tracepoint-selftests.c: Fix common/ includes.
12558         * unittests/style-selftests.c: Fix common/ includes.
12559         * unittests/string_view-selftests.c: Fix common/ includes.
12560         * unittests/scoped_restore-selftests.c: Fix common/ includes.
12561         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
12562         * unittests/scoped_fd-selftests.c: Fix common/ includes.
12563         * unittests/rsp-low-selftests.c: Fix common/ includes.
12564         * unittests/parse-connection-spec-selftests.c: Fix common/
12565         includes.
12566         * unittests/optional-selftests.c: Fix common/ includes.
12567         * unittests/offset-type-selftests.c: Fix common/ includes.
12568         * unittests/observable-selftests.c: Fix common/ includes.
12569         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
12570         * unittests/memrange-selftests.c: Fix common/ includes.
12571         * unittests/memory-map-selftests.c: Fix common/ includes.
12572         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
12573         * unittests/function-view-selftests.c: Fix common/ includes.
12574         * unittests/environ-selftests.c: Fix common/ includes.
12575         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
12576         * unittests/common-utils-selftests.c: Fix common/ includes.
12577         * unittests/cli-utils-selftests.c: Fix common/ includes.
12578         * unittests/array-view-selftests.c: Fix common/ includes.
12579         * ui-file.c: Fix common/ includes.
12580         * tui/tui-io.c: Fix common/ includes.
12581         * tracepoint.h: Fix common/ includes.
12582         * tracepoint.c: Fix common/ includes.
12583         * tracefile-tfile.c: Fix common/ includes.
12584         * top.h: Fix common/ includes.
12585         * top.c: Fix common/ includes.
12586         * thread.c: Fix common/ includes.
12587         * target/waitstatus.h: Fix common/ includes.
12588         * target/waitstatus.c: Fix common/ includes.
12589         * target.h: Fix common/ includes.
12590         * target.c: Fix common/ includes.
12591         * target-memory.c: Fix common/ includes.
12592         * target-descriptions.c: Fix common/ includes.
12593         * symtab.h: Fix common/ includes.
12594         * symfile.c: Fix common/ includes.
12595         * stap-probe.c: Fix common/ includes.
12596         * spu-linux-nat.c: Fix common/ includes.
12597         * sparc-nat.c: Fix common/ includes.
12598         * source.c: Fix common/ includes.
12599         * solib.c: Fix common/ includes.
12600         * solib-target.c: Fix common/ includes.
12601         * ser-unix.c: Fix common/ includes.
12602         * ser-tcp.c: Fix common/ includes.
12603         * ser-pipe.c: Fix common/ includes.
12604         * ser-base.c: Fix common/ includes.
12605         * selftest-arch.c: Fix common/ includes.
12606         * s12z-tdep.c: Fix common/ includes.
12607         * rust-exp.y: Fix common/ includes.
12608         * rs6000-aix-tdep.c: Fix common/ includes.
12609         * riscv-tdep.c: Fix common/ includes.
12610         * remote.c: Fix common/ includes.
12611         * remote-notif.h: Fix common/ includes.
12612         * remote-fileio.h: Fix common/ includes.
12613         * remote-fileio.c: Fix common/ includes.
12614         * regcache.h: Fix common/ includes.
12615         * regcache.c: Fix common/ includes.
12616         * record-btrace.c: Fix common/ includes.
12617         * python/python.c: Fix common/ includes.
12618         * python/py-type.c: Fix common/ includes.
12619         * python/py-inferior.c: Fix common/ includes.
12620         * progspace.h: Fix common/ includes.
12621         * producer.c: Fix common/ includes.
12622         * procfs.c: Fix common/ includes.
12623         * proc-api.c: Fix common/ includes.
12624         * printcmd.c: Fix common/ includes.
12625         * ppc-linux-nat.c: Fix common/ includes.
12626         * parser-defs.h: Fix common/ includes.
12627         * osdata.c: Fix common/ includes.
12628         * obsd-nat.c: Fix common/ includes.
12629         * nat/x86-linux.c: Fix common/ includes.
12630         * nat/x86-linux-dregs.c: Fix common/ includes.
12631         * nat/x86-dregs.h: Fix common/ includes.
12632         * nat/x86-dregs.c: Fix common/ includes.
12633         * nat/ppc-linux.c: Fix common/ includes.
12634         * nat/mips-linux-watch.h: Fix common/ includes.
12635         * nat/mips-linux-watch.c: Fix common/ includes.
12636         * nat/linux-waitpid.c: Fix common/ includes.
12637         * nat/linux-ptrace.h: Fix common/ includes.
12638         * nat/linux-ptrace.c: Fix common/ includes.
12639         * nat/linux-procfs.c: Fix common/ includes.
12640         * nat/linux-personality.c: Fix common/ includes.
12641         * nat/linux-osdata.c: Fix common/ includes.
12642         * nat/linux-namespaces.c: Fix common/ includes.
12643         * nat/linux-btrace.h: Fix common/ includes.
12644         * nat/linux-btrace.c: Fix common/ includes.
12645         * nat/fork-inferior.c: Fix common/ includes.
12646         * nat/amd64-linux-siginfo.c: Fix common/ includes.
12647         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
12648         * nat/aarch64-linux.c: Fix common/ includes.
12649         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
12650         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
12651         * namespace.h: Fix common/ includes.
12652         * mips-linux-tdep.c: Fix common/ includes.
12653         * minsyms.c: Fix common/ includes.
12654         * mi/mi-parse.h: Fix common/ includes.
12655         * mi/mi-main.c: Fix common/ includes.
12656         * mi/mi-cmd-env.c: Fix common/ includes.
12657         * memrange.h: Fix common/ includes.
12658         * memattr.c: Fix common/ includes.
12659         * maint.h: Fix common/ includes.
12660         * maint.c: Fix common/ includes.
12661         * main.c: Fix common/ includes.
12662         * machoread.c: Fix common/ includes.
12663         * location.c: Fix common/ includes.
12664         * linux-thread-db.c: Fix common/ includes.
12665         * linux-nat.c: Fix common/ includes.
12666         * linux-fork.c: Fix common/ includes.
12667         * inline-frame.c: Fix common/ includes.
12668         * infrun.c: Fix common/ includes.
12669         * inflow.c: Fix common/ includes.
12670         * inferior.h: Fix common/ includes.
12671         * inferior.c: Fix common/ includes.
12672         * infcmd.c: Fix common/ includes.
12673         * inf-ptrace.c: Fix common/ includes.
12674         * inf-child.c: Fix common/ includes.
12675         * ia64-linux-nat.c: Fix common/ includes.
12676         * i387-tdep.c: Fix common/ includes.
12677         * i386-tdep.c: Fix common/ includes.
12678         * i386-linux-tdep.c: Fix common/ includes.
12679         * i386-linux-nat.c: Fix common/ includes.
12680         * i386-go32-tdep.c: Fix common/ includes.
12681         * i386-fbsd-tdep.c: Fix common/ includes.
12682         * i386-fbsd-nat.c: Fix common/ includes.
12683         * guile/scm-type.c: Fix common/ includes.
12684         * guile/guile.c: Fix common/ includes.
12685         * go32-nat.c: Fix common/ includes.
12686         * gnu-nat.c: Fix common/ includes.
12687         * gdbthread.h: Fix common/ includes.
12688         * gdbarch-selftests.c: Fix common/ includes.
12689         * gdb_usleep.c: Fix common/ includes.
12690         * gdb_select.h: Fix common/ includes.
12691         * gdb_bfd.c: Fix common/ includes.
12692         * gcore.c: Fix common/ includes.
12693         * fork-child.c: Fix common/ includes.
12694         * findvar.c: Fix common/ includes.
12695         * fbsd-nat.c: Fix common/ includes.
12696         * event-top.c: Fix common/ includes.
12697         * event-loop.c: Fix common/ includes.
12698         * dwarf2read.c: Fix common/ includes.
12699         * dwarf2loc.c: Fix common/ includes.
12700         * dwarf2-frame.c: Fix common/ includes.
12701         * dwarf-index-cache.c: Fix common/ includes.
12702         * dtrace-probe.c: Fix common/ includes.
12703         * disasm-selftests.c: Fix common/ includes.
12704         * defs.h: Fix common/ includes.
12705         * csky-tdep.c: Fix common/ includes.
12706         * cp-valprint.c: Fix common/ includes.
12707         * cp-support.h: Fix common/ includes.
12708         * cp-support.c: Fix common/ includes.
12709         * corelow.c: Fix common/ includes.
12710         * completer.h: Fix common/ includes.
12711         * completer.c: Fix common/ includes.
12712         * compile/compile.c: Fix common/ includes.
12713         * compile/compile-loc2c.c: Fix common/ includes.
12714         * compile/compile-cplus-types.c: Fix common/ includes.
12715         * compile/compile-cplus-symbols.c: Fix common/ includes.
12716         * command.h: Fix common/ includes.
12717         * cli/cli-dump.c: Fix common/ includes.
12718         * cli/cli-cmds.c: Fix common/ includes.
12719         * charset.c: Fix common/ includes.
12720         * build-id.c: Fix common/ includes.
12721         * btrace.h: Fix common/ includes.
12722         * btrace.c: Fix common/ includes.
12723         * breakpoint.h: Fix common/ includes.
12724         * breakpoint.c: Fix common/ includes.
12725         * ax.h:
12726         (enum agent_op): Fix common/ includes.
12727         * ax-general.c (struct aop_map): Fix common/ includes.
12728         * ax-gdb.c: Fix common/ includes.
12729         * auxv.c: Fix common/ includes.
12730         * auto-load.c: Fix common/ includes.
12731         * arm-tdep.c: Fix common/ includes.
12732         * arch/riscv.c: Fix common/ includes.
12733         * arch/ppc-linux-common.c: Fix common/ includes.
12734         * arch/i386.c: Fix common/ includes.
12735         * arch/arm.c: Fix common/ includes.
12736         * arch/arm-linux.c: Fix common/ includes.
12737         * arch/arm-get-next-pcs.c: Fix common/ includes.
12738         * arch/amd64.c: Fix common/ includes.
12739         * arch/aarch64.c: Fix common/ includes.
12740         * arch/aarch64-insn.c: Fix common/ includes.
12741         * arch-utils.c: Fix common/ includes.
12742         * amd64-windows-tdep.c: Fix common/ includes.
12743         * amd64-tdep.c: Fix common/ includes.
12744         * amd64-sol2-tdep.c: Fix common/ includes.
12745         * amd64-obsd-tdep.c: Fix common/ includes.
12746         * amd64-nbsd-tdep.c: Fix common/ includes.
12747         * amd64-linux-tdep.c: Fix common/ includes.
12748         * amd64-linux-nat.c: Fix common/ includes.
12749         * amd64-fbsd-tdep.c: Fix common/ includes.
12750         * amd64-fbsd-nat.c: Fix common/ includes.
12751         * amd64-dicos-tdep.c: Fix common/ includes.
12752         * amd64-darwin-tdep.c: Fix common/ includes.
12753         * agent.c: Fix common/ includes.
12754         * ada-lang.h: Fix common/ includes.
12755         * ada-lang.c: Fix common/ includes.
12756         * aarch64-tdep.c: Fix common/ includes.
12757
12758 2019-01-25  Tom Tromey  <tom@tromey.com>
12759
12760         * common/create-version.sh: Use common/version.h.
12761
12762 2019-01-24  Pedro Alves  <palves@redhat.com>
12763
12764         * infrun.c (signal_stop, signal_print, signal_program)
12765         (signal_catch, signal_pass): Now arrays instead of pointers.
12766         (update_signals_program_target, do_target_resume)
12767         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
12768         * linux-nat.c (linux_nat_target::pass_signals)
12769         (linux_nat_target::create_inferior, linux_nat_target::attach):
12770         Adjust.
12771         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
12772         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
12773         * procfs.c (procfs_target::pass_signals): Adjust.
12774         * record-full.c (record_full_target::resume): Adjust.
12775         * remote.c (remote_target::pass_signals)
12776         (remote_target::program_signals): Adjust.
12777         * target-debug.h (target_debug_print_signals): Now takes a
12778         gdb::array_view as parameter.  Adjust.
12779         * target.h (target_ops) <pass_signals, program_signals>: Replace
12780         pointer and length parameters with gdb::array_view.
12781         (target_pass_signals, target_program_signals): Likewise.
12782         * target-delegates.c: Regenerate.
12783
12784 2019-01-24  Pedro Alves  <palves@redhat.com>
12785
12786         * common/forward-scope-exit.h
12787         (forward_scope_exit::forward_scope_exit): Pass arguments to
12788         m_bind_function directly, instead of creating a std::bind and
12789         copying that.
12790
12791 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
12792
12793         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
12794         for static members.
12795         (pass_in_v_vfp_candidate): Likewise.
12796
12797 2019-01-23  Tom Tromey  <tom@tromey.com>
12798             Pedro Alves  <palves@redhat.com>
12799
12800         * regcache.c (class regcache_invalidator): Remove.
12801         (regcache::raw_write): Use make_scope_exit.
12802
12803 2019-01-23  Tom Tromey  <tom@tromey.com>
12804
12805         * ui-out.h (class ui_out_emit_type): Update comment.
12806
12807 2019-01-23  Tom Tromey  <tom@tromey.com>
12808
12809         * infrun.c (fetch_inferior_event): Update comment.
12810
12811 2019-01-23  Tom Tromey  <tom@tromey.com>
12812             Pedro Alves  <palves@redhat.com>
12813
12814         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
12815         parameter.
12816         (fetch_inferior_event): Use SCOPE_EXIT.
12817
12818
12819 2019-01-23  Tom Tromey  <tom@tromey.com>
12820             Pedro Alves  <palves@redhat.com>
12821
12822         * infrun.c (disable_thread_events): Delete.
12823         (stop_all_threads): Use SCOPE_EXIT.
12824
12825 2019-01-23  Tom Tromey  <tom@tromey.com>
12826             Pedro Alves  <palves@redhat.com>
12827
12828         * symfile.c: Include forward-scope-exit.h.
12829         (clear_symtab_users_cleanup): Replace forward declaration with
12830         a FORWARD_SCOPE_EXIT.
12831         (syms_from_objfile_1): Use the forward_scope_exit and
12832         gdb::optional instead of cleanup_function.
12833         (reread_symbols): Use the forward_scope_exit instead of
12834         cleanup_function.
12835         (clear_symtab_users_cleanup): Remove function.
12836
12837 2019-01-23  Tom Tromey  <tom@tromey.com>
12838             Pedro Alves  <palves@redhat.com>
12839
12840         * linux-nat.c: Include scope-exit.h.
12841         (cleanup_target_stop): Remove.
12842         (linux_nat_target::static_tracepoint_markers_by_strid): Use
12843         SCOPE_EXIT.
12844
12845 2019-01-23  Tom Tromey  <tom@tromey.com>
12846             Pedro Alves  <palves@redhat.com>
12847
12848         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
12849         (call_function_by_hand_dummy): Use SCOPE_EXIT.
12850
12851 2019-01-23  Tom Tromey  <tom@tromey.com>
12852             Andrew Burgess  <andrew.burgess@embecosm.com>
12853             Pedro Alves  <palves@redhat.com>
12854
12855         * infrun.c (fetch_inferior_event): Use scope_exit.
12856         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
12857         * top.c (execute_command): Use scope_exit.
12858         * breakpoint.c (bpstat_do_actions): Use scope_exit.
12859         * utils.c (do_bpstat_clear_actions_cleanup)
12860         (make_bpstat_clear_actions_cleanup): Remove.
12861
12862 2019-01-23  Tom Tromey  <tom@tromey.com>
12863             Pedro Alves  <palves@redhat.com>
12864
12865         * infrun.c: Include "common/scope-exit.h"
12866         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
12867         (wait_for_inferior): Use SCOPE_EXIT.
12868         (fetch_inferior_event): Use scope_exit.
12869
12870 2019-01-23  Tom Tromey  <tom@tromey.com>
12871             Pedro Alves  <palves@redhat.com>
12872
12873         * breakpoint.c (create_breakpoint): Remove cleanup.
12874
12875 2019-01-23  Tom Tromey  <tom@tromey.com>
12876             Andrew Burgess  <andrew.burgess@embecosm.com>
12877             Pedro Alves  <palves@redhat.com>
12878
12879 2019-01-23  Pedro Alves  <palves@redhat.com>
12880
12881         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
12882
12883 2019-01-23  Pedro Alves  <palves@redhat.com>
12884             Andrew Burgess  <andrew.burgess@embecosm.com>
12885
12886         * gdbthread.h: Include "common/forward-scope-exit.h".
12887         (scoped_finish_thread_state): Redefine custom class in terms of
12888         forward_scope_exit.
12889
12890 2019-01-23  Pedro Alves  <palves@redhat.com>
12891             Andrew Burgess  <andrew.burgess@embecosm.com>
12892
12893         * common/forward-scope-exit.h: New file.
12894
12895 2019-01-23  Pedro Alves  <palves@redhat.com>
12896             Andrew Burgess  <andrew.burgess@embecosm.com>
12897             Tom Tromey  <tom@tromey.com>
12898
12899         * common/scope-exit.h: New file.
12900
12901 2019-01-23  Pedro Alves  <palves@redhat.com>
12902
12903         * common/preprocessor.h (ESC): Rename to ...
12904         (ESC_PARENS): ... this.
12905         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
12906         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
12907
12908 2019-01-23  Tom Tromey  <tom@tromey.com>
12909
12910         * language.h (class scoped_switch_to_sym_language_if_auto):
12911         Initialize m_lang in both cases.
12912
12913 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
12914
12915         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
12916         with XCNEW.
12917
12918 2019-01-22  Tom Tromey  <tom@tromey.com>
12919
12920         * corelow.c: Do not include sys/file.h.
12921
12922 2019-01-22  Tom Tromey  <tom@tromey.com>
12923
12924         * tui/tui-wingeneral.h: Include gdb_curses.h.
12925
12926 2019-01-22  Tom Tromey  <tom@tromey.com>
12927
12928         * source-cache.h (class source_cache) <get_source_lines,
12929         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
12930
12931 2019-01-22  Tom Tromey  <tom@tromey.com>
12932
12933         * remote-fileio.h (struct remote_target): Declare.
12934
12935 2019-01-22  Tom Tromey  <tom@tromey.com>
12936
12937         * python/py-arch.c: Do not include py-ref.h.
12938         * python/py-bpevent.c: Do not include py-ref.h.
12939         * python/py-cmd.c: Do not include py-ref.h.
12940         * python/py-continueevent.c: Do not include py-ref.h.
12941         * python/py-event.h: Do not include py-ref.h.
12942         * python/py-evtregistry.c: Do not include py-ref.h.
12943         * python/py-finishbreakpoint.c: Do not include py-ref.h.
12944         * python/py-frame.c: Do not include py-ref.h.
12945         * python/py-framefilter.c: Do not include py-ref.h.
12946         * python/py-function.c: Do not include py-ref.h.
12947         * python/py-infevents.c: Do not include py-ref.h.
12948         * python/py-linetable.c: Do not include py-ref.h.
12949         * python/py-objfile.c: Do not include py-ref.h.
12950         * python/py-param.c: Do not include py-ref.h.
12951         * python/py-prettyprint.c: Do not include py-ref.h.
12952         * python/py-progspace.c: Do not include py-ref.h.
12953         * python/py-symbol.c: Do not include py-ref.h.
12954         * python/py-symtab.c: Do not include py-ref.h.
12955         * python/py-type.c: Do not include py-ref.h.
12956         * python/py-unwind.c: Do not include py-ref.h.
12957         * python/py-utils.c: Do not include py-ref.h.
12958         * python/py-value.c: Do not include py-ref.h.
12959         * python/py-varobj.c: Do not include py-ref.h.
12960         * python/py-xmethods.c: Do not include py-ref.h.
12961         * python/python.c: Do not include py-ref.h.
12962         * varobj.c: Do not include py-ref.h.
12963
12964 2019-01-22  Tom Tromey  <tom@tromey.com>
12965
12966         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
12967         keyword for bcache.
12968
12969 2019-01-22  Tom Tromey  <tom@tromey.com>
12970
12971         * compile/compile-cplus-types.c: Remove a comment by #include.
12972
12973 2019-01-22  Tom Tromey  <tom@tromey.com>
12974
12975         * compile/gcc-c-plugin.h: Include compile-internal.h.
12976
12977 2019-01-22  Tom Tromey  <tom@tromey.com>
12978
12979         * stabsread.c (EXTERN): Do not define.
12980         (symnum, next_symbol_text_func, processing_gcc_compilation)
12981         (within_function, global_sym_chain, global_stabs)
12982         (previous_stab_code, this_object_header_files)
12983         (n_this_object_header_files)
12984         (n_allocated_this_object_header_files): Define.
12985         * stabsread.h (EXTERN): Never define.  Use "extern".
12986
12987 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12988
12989         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
12990         history_value.
12991
12992 2019-01-21  Tom Tromey  <tom@tromey.com>
12993
12994         * ui-out.c: Fix includes.
12995         * tui/tui-source.c: Fix includes.
12996         * target.c: Fix includes.
12997         * remote.c: Fix includes.
12998         * regcache.c: Fix includes.
12999         * python/py-block.c: Fix includes.
13000         * printcmd.c: Fix includes.
13001         * or1k-tdep.c: Fix includes.
13002         * mi/mi-main.c: Fix includes.
13003         * m32r-tdep.c: Fix includes.
13004         * csky-tdep.c: Fix includes.
13005         * compile/compile-cplus-types.c: Fix includes.
13006         * cli/cli-interp.c: Fix includes.
13007
13008 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
13009
13010         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
13011         for padding.
13012
13013 2019-01-16  Tom Tromey  <tom@tromey.com>
13014
13015         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
13016         earlier.
13017         (struct objfile) <msymbols_range>: Move from top level.
13018         <msymbols>: New method.
13019         (class objfile_msymbols): Remove.
13020         * symtab.c (default_collect_symbol_completion_matches_break_on):
13021         Update.
13022         * symmisc.c (dump_msymbols): Update.
13023         * stabsread.c (scan_file_globals): Update.
13024         * objc-lang.c (info_selectors_command, info_classes_command)
13025         (find_methods): Update.
13026         * minsyms.c (find_solib_trampoline_target): Update.
13027         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
13028         * coffread.c (coff_symfile_read): Update.
13029         * ada-lang.c (ada_lookup_simple_minsym)
13030         (ada_collect_symbol_completion_matches): Update.
13031
13032 2019-01-16  Tom Tromey  <tom@tromey.com>
13033
13034         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
13035         type.  Remove no-argument constructor.
13036         <iterator::operator++>: Simplify.
13037         <begin>: Update.
13038         <end>: Use minimal_symbol_count.
13039
13040 2019-01-16  Tom Tromey  <tom@tromey.com>
13041
13042         * objfiles.h (struct objfile) <psymtabs>: New method.
13043         (class objfile_psymtabs): Remove.
13044         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
13045         typedef.
13046         <range>: New method.
13047         (require_partial_symbols): Change return type.
13048         * psymtab.c (require_partial_symbols)
13049         (psym_expand_symtabs_matching): Update.
13050         * mdebugread.c (parse_partial_symbols): Update.
13051         * dbxread.c (dbx_end_psymtab): Update.
13052
13053 2019-01-15  Tom Tromey  <tom@tromey.com>
13054
13055         * symtab.c (lookup_objfile_from_block)
13056         (lookup_symbol_in_objfile_symtabs)
13057         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
13058         (find_line_symtab, info_sources_command)
13059         (default_collect_symbol_completion_matches_break_on)
13060         (make_source_files_completion_list): Update.
13061         * symmisc.c (print_objfile_statistics, dump_objfile)
13062         (maintenance_print_symbols, maintenance_info_symtabs)
13063         (maintenance_check_symtabs, maintenance_info_line_tables):
13064         Update.
13065         * source.c (select_source_symtab)
13066         (forget_cached_source_info_for_objfile): Update.
13067         * objfiles.h (class objfile_compunits): Remove.
13068         (struct objfile) <compunits_range>: New typedef.
13069         (compunits): New method.
13070         * objfiles.c (objfile_relocate1): Update.
13071         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
13072         * maint.c (count_symtabs_and_blocks): Update.
13073         * linespec.c (iterate_over_all_matching_symtabs): Update.
13074         * cp-support.c (add_symbol_overload_list_qualified): Update.
13075         * coffread.c (coff_symtab_read): Update.
13076         * ada-lang.c (add_nonlocal_symbols)
13077         (ada_collect_symbol_completion_matches)
13078         (ada_add_global_exceptions): Update.
13079
13080 2019-01-15  Tom Tromey  <tom@tromey.com>
13081
13082         * progspace.h (program_space) <objfiles_safe_range>: New
13083         typedef.
13084         <objfiles_safe>: New method.
13085         * objfiles.h (class all_objfiles_safe): Remove.
13086         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
13087         * jit.c (jit_inferior_exit_hook): Update.
13088
13089 2019-01-17  Tom Tromey  <tom@tromey.com>
13090
13091         * progspace.h (program_space) <objfiles_range>: New typedef.
13092         <objfiles>: New method.
13093         <objfiles_head>: Rename from objfiles.
13094         (object_files): Update.
13095         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
13096         * guile/scm-pretty-print.c
13097         (ppscm_find_pretty_printer_from_objfiles): Update.
13098         * guile/scm-objfile.c (gdbscm_objfiles): Update.
13099         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
13100         Update.
13101         * python/py-progspace.c (pspy_get_objfiles): Update.
13102         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
13103         Update.
13104         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
13105         (objfpy_lookup_objfile_by_build_id): Update.
13106         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
13107         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
13108         Update.
13109         * symtab.c (iterate_over_symtabs, matching_obj_sections)
13110         (expand_symtab_containing_pc, lookup_objfile_from_block)
13111         (lookup_static_symbol, basic_lookup_transparent_type)
13112         (find_pc_sect_compunit_symtab, find_symbol_at_address)
13113         (find_line_symtab, info_sources_command)
13114         (default_collect_symbol_completion_matches_break_on)
13115         (make_source_files_completion_list, find_main_name): Update.
13116         * symmisc.c (print_symbol_bcache_statistics)
13117         (print_objfile_statistics, maintenance_print_symbols)
13118         (maintenance_print_msymbols, maintenance_print_objfiles)
13119         (maintenance_info_symtabs, maintenance_check_symtabs)
13120         (maintenance_expand_symtabs, maintenance_info_line_tables):
13121         Update.
13122         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
13123         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
13124         (map_overlay_command, unmap_overlay_command)
13125         (simple_overlay_update, expand_symtabs_matching)
13126         (map_symbol_filenames): Update.
13127         * symfile-debug.c (set_debug_symfile): Update.
13128         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
13129         Update.
13130         * source.c (select_source_symtab, forget_cached_source_info):
13131         Update.
13132         * solib.c (solib_read_symbols): Update.
13133         * solib-spu.c (append_ocl_sos): Update.
13134         * psymtab.c (maintenance_print_psymbols)
13135         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
13136         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
13137         * printcmd.c (info_symbol_command): Update.
13138         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
13139         Update.
13140         * objfiles.h (class all_objfiles): Remove.
13141         * objfiles.c (have_partial_symbols, have_full_symbols)
13142         (have_minimal_symbols, qsort_cmp, update_section_map)
13143         (shared_objfile_contains_address_p)
13144         (default_iterate_over_objfiles_in_search_order): Update.
13145         * objc-lang.c (info_selectors_command, info_classes_command)
13146         (find_methods): Update.
13147         * minsyms.c (find_solib_trampoline_target): Update.
13148         * maint.c (maintenance_info_sections)
13149         (maintenance_translate_address, count_symtabs_and_blocks):
13150         Update.
13151         * main.c (captured_main_1): Update.
13152         * linux-thread-db.c (try_thread_db_load_from_pdir)
13153         (has_libpthread): Update.
13154         * linespec.c (iterate_over_all_matching_symtabs)
13155         (search_minsyms_for_name): Update.
13156         * jit.c (jit_find_objf_with_entry_addr): Update.
13157         * hppa-tdep.c (find_unwind_entry)
13158         (hppa_lookup_stub_minimal_symbol): Update.
13159         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
13160         Update.
13161         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
13162         (elf_gnu_ifunc_resolve_by_got): Update.
13163         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
13164         * dwarf-index-write.c (save_gdb_index_command): Update.
13165         * cp-support.c (add_symbol_overload_list_qualified): Update.
13166         * breakpoint.c (create_overlay_event_breakpoint)
13167         (create_longjmp_master_breakpoint)
13168         (create_std_terminate_master_breakpoint)
13169         (create_exception_master_breakpoint): Update.
13170         * blockframe.c (find_pc_partial_function): Update.
13171         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
13172         (ada_collect_symbol_completion_matches)
13173         (ada_add_global_exceptions): Update.
13174
13175 2019-01-17  Tom Tromey  <tom@tromey.com>
13176
13177         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
13178         declare VEC.
13179         (solib_target_parse_libraries): Change return type.
13180         (library_list_start_segment, library_list_start_section)
13181         (library_list_end_library, library_list_start_library); Update.
13182         (solib_target_free_library_list): Remove.
13183         (solib_target_parse_libraries): Remove cleanup.  Change return
13184         type.
13185         (solib_target_current_sos): Update.
13186
13187 2019-01-17  Tom Tromey  <tromey@bapiya>
13188
13189         * valprint.c: Replace "the the" with "the".
13190         * symtab.c: Replace "the the" with "the".
13191         * solib.c: Replace "the the" with "the".
13192         * solib-dsbt.c: Replace "the the" with "the".
13193         * linespec.c: Replace "the the" with "the".
13194         * dwarf2loc.h: Replace "the the" with "the".
13195         * amd64-windows-tdep.c: Replace "the the" with "the".
13196         * aarch64-tdep.c: Replace "the the" with "the".
13197
13198 2019-01-16  Keith Seitz  <keiths@redhat.com>
13199
13200         PR gdb/23773
13201         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
13202         <builder>: Rename to ..
13203         <m_builder>: ... this and make private.
13204         (dwarf2_cu::get_builder): New method.  Change all users of
13205         `builder' to use this method.
13206         (dwarf2_start_symtab): Move to ...
13207         (dwarf2_cu::start_symtab): ... here.  Update all callers
13208         (setup_type_unit_groups): Move to ...
13209         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
13210         callers.
13211         (dwarf2_cu::reset_builder): New method.
13212         (process_full_compunit, process_full_type_unit): Use
13213         dwarf2_cu::reset_builder.
13214         (follow_die_offset): Record the ancestor CU if it is different
13215         from the followed DIE's CU.
13216         (follow_die_sig_1): Likewise.
13217
13218 2019-01-15  Tom Tromey  <tom@tromey.com>
13219
13220         * remote.c (class remote_state) <buf>: Now a char_vector.
13221         <buf_size>: Remove.
13222         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
13223         parameter.
13224         (remote_target::getpkt_or_notif_sane_1)
13225         (remote_target::getpkt_sane)
13226         (remote_target::getpkt_or_notif_sane): Likewise.
13227         (class remote_target) <putpkt>: New overload.
13228         (remote_target::read_frame): Change type of "buf_p".  Remove
13229         sizeof_p parameter.
13230         (packet_ok): New overload.
13231         (packet_check_result): New overload.
13232         Update all uses.
13233
13234 2019-01-14  Tom Tromey  <tom@tromey.com>
13235
13236         * remote-notif.c (handle_notification, remote_notif_ack)
13237         (remote_notif_parse): Make "buf" const.
13238         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
13239         const.
13240         (remote_notif_parse, remote_notif_ack, handle_notification):
13241         Likewise.
13242         * remote.c (remote_notif_stop_parse): Make "buf" const.
13243         (remote_target::remote_parse_stop_reply): Make "buf" const.
13244         (remote_notif_stop_ack): Make "buf" const.
13245
13246 2019-01-14  Tom Tromey  <tom@tromey.com>
13247
13248         * remote.c (remote_console_output): Make parameter const.
13249
13250 2019-01-14  Tom Tromey  <tom@tromey.com>
13251
13252         * target-debug.h (target_debug_print_signals): Constify.
13253         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
13254         * procfs.c (procfs_target::pass_signals): Update.
13255         * linux-nat.c (linux_nat_target::pass_signals): Update.
13256         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
13257         * target-delegates.c: Rebuild.
13258         * remote.c (remote_target::program_signals): Update.
13259         (remote_target::pass_signals): Update.
13260         * target.c (target_pass_signals): Constify argument.
13261         (target_program_signals): Likewise.
13262         * target.h (struct target_ops) <pass_signals, program_signals>:
13263         Constify argument.
13264         (target_pass_signals, target_program_signals): Constify argument.
13265
13266 2019-01-14  Tom Tromey  <tom@tromey.com>
13267
13268         PR tui/28819:
13269         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
13270
13271 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
13272
13273         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
13274         field.
13275         * rs6000-tdep.c: Include reggroups.h.
13276         (IS_V_ALIAS_PSEUDOREG): Define.
13277         (rs6000_register_name): Return names for the "vX" aliases.
13278         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
13279         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
13280         aliases.  Call default_register_reggroup_p for all other
13281         pseudo-registers.
13282         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
13283         New functions.
13284         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
13285         Handle "vX" aliases.
13286         (v_alias_pseudo_register_collect): New function.
13287         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
13288         (rs6000_gdbarch_init): Initialize "vX" aliases as
13289         pseudo-registers.  Restore registration of
13290         rs6000_pseudo_register_reggroup_p with
13291         set_tdesc_pseudo_register_reggroup_p.
13292
13293 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
13294
13295         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
13296         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
13297         set_gdbarch_num_pseudo_regs.
13298
13299 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13300
13301         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
13302         Remove arg prefixname, add do_set and do_show.
13303         Add member functions set_list and show_list.
13304         * cli/cli-style.c (class cli_style_option): Update accordingly.
13305         (style_set_list): Move to file scope.
13306         (style_show_list): Likewise.
13307         (set_style): Call help_list.
13308         (show_style): Call cmd_show_list.
13309         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
13310         Update to use the new macro.
13311
13312 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
13313
13314         * ada-lang.c (_initialize_ada_language): Expand the help text
13315         for the "catch exception" command.
13316
13317 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13318
13319         * symtab.c (matching_obj_sections): Initialize obj,
13320         declare it closer to its usage.
13321
13322 2019-01-10  Tom Tromey  <tom@tromey.com>
13323
13324         * thread-iter.h (inf_threads_iterator): Use next_iterator.
13325         (basic_inf_threads_range): Remove.
13326         (inf_threads_range, inf_non_exited_threads_range)
13327         (safe_inf_threads_range): Use next_adapter.
13328
13329 2019-01-10  Keith Seitz  <keiths@redhat.com>
13330
13331         PR gdb/23712
13332         PR symtab/23010
13333         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
13334         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
13335
13336 2019-01-10  Keith Seitz  <keiths@redhat.com>
13337
13338         PR gdb/23712
13339         PR symtab/23010
13340         * dictionary.c (pending_to_vector): Remove.
13341         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
13342         Remove _1 suffix, replacing functions of the same name.  Update
13343         all callers.
13344         (dict_create_hashed, dict_create_hashed_expandable)
13345         (dict_create_linear, dict_create_linear_expandable, dict_free)
13346         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
13347         Make functions static.
13348
13349 2019-01-10  Keith Seitz  <keiths@redhat.com>
13350
13351         PR gdb/23712
13352         PR symtab/23010
13353         * dictionary.h (struct dictionary): Replace declaration with
13354         multidictionary.
13355         (dict_create_hashed, dict_create_hashed_expandable)
13356         (dict_create_linear, dict_create_linear_expandable)
13357         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
13358         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
13359         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
13360         taking multidictionary argument.
13361         [ALL_DICT_SYMBOLS]: Update for multidictionary.
13362         * block.h (struct block) <dict>: Change to multidictionary
13363         and rename `multidict'.
13364         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
13365         symmisc.c: Update all dictionary references to multidictionary.
13366
13367 2019-01-10  Keith Seitz  <keiths@redhat.com>
13368
13369         PR gdb/23712
13370         PR symtab/23010
13371         * dictionary.c: Include unordered_map.
13372         (pending_to_vector): New function.
13373         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
13374         Rewrite the non-"_1" functions to take vector instead
13375         of linked list.
13376         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
13377         "new" _1 versions of the same name.
13378         (multidictionary): Define.
13379         (std::hash<enum language): New definition.
13380         (collate_pending_symbols_by_language, mdict_create_hashed)
13381         (mdict_create_hashed_expandable, mdict_create_linear)
13382         (mdict_create_linear_expandable, mdict_free)
13383         (find_language_dictionary, create_new_language_dictionary)
13384         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
13385         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
13386         (mdict_size, mdict_empty): New functions.
13387         * dictionary.h (mdict_iterator): Define.
13388
13389 2019-01-10  Pedro Alves  <palves@redhat.com>
13390
13391         * breakpoint.c (read_uploaded_action)
13392         (create_tracepoint_from_upload): Adjust to use
13393         gdb::unique_xmalloc_ptr.
13394         * ctf.c (ctf_write_uploaded_tp):
13395         (SET_ARRAY_FIELD): Use emplace_back.
13396         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
13397         * tracefile-tfile.c (tfile_write_uploaded_tp):
13398         * tracepoint.c (parse_tracepoint_definition): Adjust to use
13399         gdb::unique_xmalloc_ptr.
13400         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
13401         at_string, cond_string, cmd_strings>: Replace char pointers
13402         with gdb::unique_xmalloc_ptr.
13403
13404 2019-01-10  Pedro Alves  <palves@redhat.com>
13405
13406         * solib-target.c (library_list_start_library): Don't xstrdup name.
13407
13408 2019-01-10  Pedro Alves  <palves@redhat.com>
13409
13410         * mdebugread.c (parse_partial_symbols): Use
13411         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
13412
13413 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
13414
13415         * linux-fork.c (scoped_switch_fork_info)
13416         <~scoped_switch_fork_info>: Fix incorrect variable name.
13417
13418 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
13419
13420         * linux-fork.c (scoped_switch_fork_info)
13421         <scoped_switch_fork_info>: Make explicit.
13422         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
13423
13424 2019-01-10  Tom Tromey  <tom@tromey.com>
13425
13426         * objfiles.h (objfile::reset_psymtabs): Update.
13427         * objfiles.c (objfile::objfile): Update.
13428         * psymtab.h (psymtab_storage::obstack): Update.
13429         (psymtab_storage::m_obstack): Use gdb::optional.
13430         (class psymtab_storage): Update comment.  Remove objfile
13431         parameter.
13432         * psymtab.c (psymtab_storage::psymtab_storage): Update.
13433
13434 2019-01-10  Tom Tromey  <tom@tromey.com>
13435
13436         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
13437         <free_psymtabs>: Now private.
13438         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
13439         (allocate_psymtab): Use new method.
13440
13441 2019-01-10  Tom Tromey  <tom@tromey.com>
13442
13443         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
13444         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
13445         * mdebugread.c (parse_partial_symbols): Use
13446         allocate_dependencies.
13447         * dwarf2read.c (dwarf2_create_include_psymtab): Use
13448         allocate_dependencies.
13449         (process_psymtab_comp_unit_reader)
13450         (build_type_psymtab_dependencies): Likewise.
13451         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
13452
13453 2019-01-10  Tom Tromey  <tom@tromey.com>
13454
13455         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
13456         PSYMBOL_SET_LANGUAGE.
13457         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
13458
13459 2019-01-10  Tom Tromey  <tom@tromey.com>
13460
13461         * psymtab.h (psymtab_storage::obstack): New method.
13462         <m_obstack>: Rename from obstack; now private.
13463         * psymtab.c (psymtab_storage): Update.
13464         * dwarf2read.c (create_addrmap_from_index)
13465         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
13466         Update.
13467
13468 2019-01-10  Tom Tromey  <tom@tromey.com>
13469
13470         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
13471         * objfiles.h (objfile::reset_psymtabs): New method.
13472
13473 2019-01-10  Tom Tromey  <tom@tromey.com>
13474
13475         * symmisc.c (print_symbol_bcache_statistics): Update.
13476         (print_objfile_statistics): Update.
13477         * symfile.c (reread_symbols): Update.
13478         * psymtab.h (class psymtab_storage): New.
13479         * psymtab.c (psymtab_storage): New constructor.
13480         (~psymtab_storage): New destructor.
13481         (require_partial_symbols): Update.
13482         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
13483         (find_pc_sect_psymtab, find_pc_sect_psymbol)
13484         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
13485         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
13486         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
13487         (start_psymtab_common, end_psymtab_common)
13488         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
13489         (allocate_psymtab): Update.
13490         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
13491         Update.
13492         (dump_psymtab_addrmap, maintenance_print_psymbols)
13493         (maintenance_check_psymtabs): Update.
13494         (class objfile_psymtabs): Move to objfiles.h.
13495         * psympriv.h (discard_psymtab): Now inline.
13496         (psymtab_discarder::psymtab_discarder): Update.
13497         (psymtab_discarder::~psymtab_discarder): Update.
13498         (ALL_OBJFILE_PSYMTABS): Rewrite.
13499         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
13500         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
13501         Remove fields.
13502         <partial_symtabs>: New field.
13503         (class objfile_psymtabs): Move from psymtab.h.  Update.
13504         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
13505         psymbol_cache.
13506         (objfile::~objfile): Don't destroy psymbol_cache.
13507         * mdebugread.c (parse_partial_symbols): Update.
13508         * dwarf2read.c (create_addrmap_from_index)
13509         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
13510         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
13511         (add_partial_subprogram, dwarf2_ranges_read): Update.
13512         * dwarf-index-write.c (write_address_map)
13513         (write_one_signatured_type, recursively_write_psymbols)
13514         (class debug_names, class debug_names, write_psymtabs_to_index):
13515         Update.
13516
13517 2019-01-10  Tom Tromey  <tom@tromey.com>
13518
13519         * symtab.h (SYMBOL_SET_NAMES): Update.
13520         (symbol_set_names): Update.
13521         (MSYMBOL_SET_NAMES): Update.
13522         * symtab.c (symbol_set_names): Change argument to be an
13523         objfile_per_bfd_storage.
13524         * psymtab.c (add_psymbol_to_bcache): Update.
13525         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
13526
13527 2019-01-10  Tom Tromey  <tom@tromey.com>
13528
13529         * symtab.c (create_demangled_names_hash): Change argument to be an
13530         objfile_per_bfd_storage.
13531         (symbol_set_names): Update.
13532
13533 2019-01-10  Tom Tromey  <tom@tromey.com>
13534
13535         * xcoffread.c (xcoff_initial_scan): Unconditionally call
13536         init_psymbol_list.
13537         * psymtab.c (init_psymbol_list): Do nothing if already called.
13538         * psympriv.h (init_psymbol_list): Add comment.
13539         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
13540         init_psymbol_list.
13541         * dbxread.c (dbx_symfile_read): Unconditionally call
13542         init_psymbol_list.
13543
13544 2019-01-10  Tom Tromey  <tom@tromey.com>
13545
13546         * xcoffread.c (scan_xcoff_symtab): Update.
13547         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
13548         "where".
13549         * mdebugread.c (parse_partial_symbols)
13550         (handle_psymbol_enumerators): Update.
13551         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
13552         * dbxread.c (read_dbx_symtab): Update.
13553         * psympriv.h (psymbol_placement): New enum.
13554         (add_psymbol_to_list): Update.
13555
13556 2019-01-10  Tom Tromey  <tom@tromey.com>
13557
13558         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
13559         static_psymbols parameters.
13560         (scan_xcoff_symtab): Update.
13561         * psymtab.c (start_psymtab_common): Remove global_psymbols and
13562         static_psymbols parameters.
13563         * psympriv.h (start_psymtab_common): Update.
13564         * mdebugread.c (parse_partial_symbols): Update.
13565         * dwarf2read.c (create_partial_symtab): Update.
13566         * dbxread.c (read_dbx_symtab): Update.
13567         (start_psymtab): Remove global_psymbols and static_psymbols
13568         parameters.
13569
13570 2019-01-10  Tom Tromey  <tom@tromey.com>
13571
13572         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
13573         * psymtab.c (allocate_psymtab): Add comment.
13574         * psympriv.h (allocate_psymtab): Add comment.
13575         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
13576         initializations.
13577         * dbxread.c (dbx_end_psymtab): Remove some initializations.
13578
13579 2019-01-10  Tom Tromey  <tom@tromey.com>
13580
13581         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
13582         Don't declare.
13583         * mipsread.c: Include mdebugread.h.
13584         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
13585         Declare.
13586         * elfread.c: Include mdebugread.h.
13587
13588 2019-01-09  Tom Tromey  <tom@tromey.com>
13589
13590         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
13591         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
13592         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
13593         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
13594         (psym_lookup_symbol, psym_find_last_source_symtab)
13595         (psym_forget_cached_source_info, psym_print_stats)
13596         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
13597         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
13598         (psym_map_matching_symbols, psym_expand_symtabs_matching)
13599         (psym_find_compunit_symtab_by_address)
13600         (maintenance_print_psymbols, maintenance_info_psymtabs)
13601         (maintenance_check_psymtabs): Use ranged for.
13602         * psymtab.h (class objfile_psymtabs): New.
13603         (require_partial_symbols): Return objfile_psymtabs.
13604         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
13605
13606 2019-01-09  Tom Tromey  <tom@tromey.com>
13607
13608         * symfile.c (overlay_invalidate_all, find_pc_overlay)
13609         (find_pc_mapped_section, list_overlays_command)
13610         (map_overlay_command, unmap_overlay_command)
13611         (simple_overlay_update): Use all_objfiles.
13612         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
13613         * printcmd.c (info_symbol_command): Use all_objfiles.
13614         * objfiles.h (ALL_OBJSECTIONS): Remove.
13615         * maint.c (maintenance_translate_address): Use all_objfiles.
13616         * gcore.c (gcore_create_callback): Use all_objfiles.
13617         (objfile_find_memory_regions): Likewise.
13618
13619 2019-01-09  Tom Tromey  <tom@tromey.com>
13620
13621         * symtab.c (find_line_symtab, info_sources_command)
13622         (make_source_files_completion_list): Use objfile_compunits.
13623         * source.c (select_source_symtab): Use objfile_compunits.
13624         * objfiles.h (struct objfile): Update comment.
13625         (ALL_OBJFILES): Remove.
13626         (ALL_FILETABS): Remove.
13627         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
13628         objfile_compunits.
13629
13630 2019-01-09  Tom Tromey  <tom@tromey.com>
13631
13632         * symmisc.c (print_objfile_statistics, dump_objfile)
13633         (maintenance_print_symbols): Use compunit_filetabs.
13634         * source.c (forget_cached_source_info_for_objfile): Use
13635         compunit_filetabs.
13636         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
13637         (ALL_FILETABS): Use compunit_filetabs.
13638         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
13639         * coffread.c (coff_symtab_read): Use compunit_filetabs.
13640
13641 2019-01-09  Tom Tromey  <tom@tromey.com>
13642
13643         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
13644         (compunit_filetabs): New.
13645         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
13646         compunit_filetabs.
13647         (info_sources_command, make_source_files_completion_list): Remove
13648         declaration.
13649         * symmisc.c (print_objfile_statistics, dump_objfile)
13650         (maintenance_print_symbols): Remove declaration.
13651         (maintenance_info_symtabs): Use compunit_filetabs.
13652         (maintenance_info_line_tables): Likewise.
13653         * source.c (select_source_symtab): Change local variable name.
13654         (forget_cached_source_info_for_objfile): Remove declaration.
13655         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
13656         * objfiles.c (objfile_relocate1): Remove declaration.
13657         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
13658         declaration.
13659         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
13660         * coffread.c (coff_symtab_read): Remove declaration.
13661         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
13662         compunit_filetabs.
13663
13664 2019-01-09  Tom Tromey  <tom@tromey.com>
13665
13666         * symtab.c (lookup_objfile_from_block)
13667         (find_pc_sect_compunit_symtab, search_symbols)
13668         (default_collect_symbol_completion_matches_break_on): Use
13669         objfile_compunits.
13670         * objfiles.h (ALL_COMPUNITS): Remove.
13671         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
13672         * cp-support.c (add_symbol_overload_list_qualified): Use
13673         objfile_compunits.
13674         * ada-lang.c (ada_collect_symbol_completion_matches)
13675         (ada_add_global_exceptions): Use objfile_compunits.
13676
13677 2019-01-09  Tom Tromey  <tom@tromey.com>
13678
13679         * source.c (select_source_symtab)
13680         (forget_cached_source_info_for_objfile): Remove declaration.
13681         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
13682         declaration.
13683         * maint.c (count_symtabs_and_blocks): Remove declaration.
13684         * cp-support.c (add_symbol_overload_list_qualified): Remove
13685         declaration.
13686         * coffread.c (coff_symtab_read): Remove declaration.
13687         * symtab.c (lookup_symbol_in_objfile_symtabs)
13688         (basic_lookup_transparent_type_1): Use objfile_compunits.
13689         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
13690         (info_sources_command, search_symbols)
13691         (default_collect_symbol_completion_matches_break_on)
13692         (make_source_files_completion_list): Remove declaration.
13693         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
13694         (ada_collect_symbol_completion_matches)
13695         (ada_add_global_exceptions): Remove declaration.
13696         * linespec.c (iterate_over_all_matching_symtabs): Use
13697         objfile_compunits.
13698         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
13699         (class objfile_compunits): New.
13700         (ALL_COMPUNITS): Use objfile_compunits.
13701         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
13702         (maintenance_check_symtabs, maintenance_info_line_tables): Use
13703         objfile_compunits.
13704         * objfiles.c (objfile_relocate1): Use objfile_compunits.
13705
13706 2019-01-09  Tom Tromey  <tom@tromey.com>
13707
13708         * symtab.c (search_symbols)
13709         (default_collect_symbol_completion_matches_break_on): Use
13710         objfile_msymbols.
13711         * ada-lang.c (ada_lookup_simple_minsym)
13712         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
13713         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
13714         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
13715         objfile_msymbols.
13716         * coffread.c (coff_symfile_read): Use objfile_msymbols.
13717         * symmisc.c (dump_msymbols): Use objfile_msymbols.
13718         * objc-lang.c (find_methods): Use objfile_msymbols.
13719         (info_selectors_command, info_classes_command): Likewise.
13720         * stabsread.c (scan_file_globals): Use objfile_msymbols.
13721         * objfiles.h (class objfile_msymbols): New.
13722         (ALL_OBJFILE_MSYMBOLS): Remove.
13723         (ALL_MSYMBOLS): Remove.
13724
13725 2019-01-09  Tom Tromey  <tom@tromey.com>
13726
13727         * common/next-iterator.h (next_adapter): Add Iterator template
13728         parameter.
13729         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
13730         (class all_objfiles_safe): New.
13731         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
13732         * objfiles.c (put_objfile_before): Update comment.
13733         (add_separate_debug_objfile): Likewise.
13734         (free_all_objfiles): Use all_objfiles_safe.
13735         (objfile_purge_solibs): Likewise.
13736
13737 2019-01-09  Tom Tromey  <tom@tromey.com>
13738
13739         * symtab.c (iterate_over_symtabs, matching_obj_sections)
13740         (expand_symtab_containing_pc, lookup_static_symbol)
13741         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
13742         (find_symbol_at_address, find_line_symtab, find_main_name): Use
13743         all_objfiles.
13744         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
13745         * breakpoint.c (create_overlay_event_breakpoint)
13746         (create_longjmp_master_breakpoint)
13747         (create_std_terminate_master_breakpoint)
13748         (create_exception_master_breakpoint): Use all_objfiles.
13749         * linux-thread-db.c (try_thread_db_load_from_pdir)
13750         (has_libpthread): Use all_objfiles.
13751         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
13752         * linespec.c (iterate_over_all_matching_symtabs)
13753         (search_minsyms_for_name): Use all_objfiles.
13754         * maint.c (maintenance_info_sections): Use all_objfiles.
13755         * main.c (captured_main_1): Use all_objfiles.
13756         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
13757         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
13758         * guile/scm-pretty-print.c
13759         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
13760         * solib-spu.c (append_ocl_sos): Use all_objfiles.
13761         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
13762         (maintenance_print_msymbols): Use all_objfiles.
13763         * source.c (select_source_symtab): Use all_objfiles.
13764         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
13765         * symfile.c (remove_symbol_file_command)
13766         (expand_symtabs_matching, map_symbol_filenames): Use
13767         all_objfiles.
13768         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
13769         all_objfiles.
13770         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
13771         * objc-lang.c (find_methods): Use all_objfiles.
13772         * objfiles.c (have_partial_symbols, have_full_symbols)
13773         (have_minimal_symbols, qsort_cmp)
13774         (default_iterate_over_objfiles_in_search_order): Use
13775         all_objfiles.
13776         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
13777         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
13778         (maintenance_check_psymtabs): Use all_objfiles.
13779         (ALL_PSYMTABS): Remove.
13780         * compile/compile-object-run.c (do_module_cleanup): Use
13781         all_objfiles.
13782         * blockframe.c (find_pc_partial_function): Use all_objfiles.
13783         * cp-support.c (add_symbol_overload_list_qualified): Use
13784         all_objfiles.
13785         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
13786         Use all_objfiles.
13787         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
13788         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
13789         all_objfiles.
13790         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
13791         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
13792         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
13793         Uses all_objfiles.
13794         * solib.c (solib_read_symbols): Use all_objfiles
13795
13796 2019-01-09  Tom Tromey  <tom@tromey.com>
13797
13798         * probe.c (parse_probes_in_pspace): Use all_objfiles.
13799         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
13800         all_objfiles.
13801         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
13802         * symmisc.c (print_symbol_bcache_statistics)
13803         (print_objfile_statistics, maintenance_print_objfiles)
13804         (maintenance_info_symtabs, maintenance_check_symtabs)
13805         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
13806         all_objfiles.
13807         * source.c (forget_cached_source_info): Use all_objfiles.
13808         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
13809         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
13810         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
13811         * objfiles.c (update_section_map): Use all_objfiles.
13812         (shared_objfile_contains_address_p): Likewise.
13813         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
13814         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
13815
13816 2019-01-09  Tom Tromey  <tom@tromey.com>
13817
13818         * common/next-iterator.h: New file.
13819         * objfiles.h (class all_objfiles): New.
13820         (struct objfile_iterator): New.
13821
13822 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13823
13824         * NEWS: Move the description of the changed "frame", "select-frame",
13825          and "info frame" commands to the Changed commands section.
13826
13827 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
13828
13829         * gdbtypes.c (check_stub_method_group): Remove handling of old
13830         mangling schemes.
13831         * linespec.c (find_methods): Likewise.
13832         * stabsread.c (read_member_functions): Likewise.
13833         * valops.c (search_struct_method): Likewise.
13834         (value_struct_elt_for_reference): Likewise.
13835         * NEWS: Mention this change.
13836
13837 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
13838
13839         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
13840         print_source_lines.
13841         * source.c (print_source_lines_base): Update line number check.
13842         (print_source_lines): New function.
13843         (source_lines_range::source_lines_range): New function.
13844         * source.h (class source_lines_range): New class.
13845         (print_source_lines): New declaration.
13846
13847 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13848
13849         * linespec.c (linespec_state_destructor): Free self->canonical_names.
13850
13851 2019-01-08  Tom Tromey  <tom@tromey.com>
13852             Simon Marchi  <simon.marchi@ericsson.com>
13853
13854         PR gdb/24060
13855         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
13856         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
13857         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
13858         * f-exp.y (DOLLAR_VARIABLE): Likewise.
13859         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
13860         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
13861
13862 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
13863
13864         * source.c (select_source_symtab): Move header comment to
13865         declaration in source.h.
13866         (forget_cached_source_info_for_objfile): Likewise.
13867         (forget_cached_source_info): Likewise.
13868         (identify_source_line): Likewise.
13869         * source.h (identify_source_line): Move declaration from symtab.h
13870         and add comment from source.c
13871         (print_source_lines): Likewise.
13872         (forget_cached_source_info_for_objfile): Likewise.
13873         (forget_cached_source_info): Likewise.
13874         (select_source_symtab): Likewise.
13875         (enum print_source_lines_flag): Move definition from symtab.h.
13876         * symtab.h (identify_source_line): Move declaration to source.h.
13877         (print_source_lines): Likewise.
13878         (forget_cached_source_info_for_objfile): Likewise.
13879         (forget_cached_source_info): Likewise.
13880         (select_source_symtab): Likewise.
13881         (enum print_source_lines_flag): Move definition to source.h.
13882         * tui/tui-hooks.c: Add 'source.h' include.
13883
13884 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
13885
13886         * source.c (print_source_lines_base): Handle requests to print
13887         reverse line number sequences, and guard against empty lines
13888         string.
13889
13890 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
13891
13892         * source.c (print_source_lines_base): Fix skip of '\r' if next
13893         character is '\n'.
13894
13895 2019-01-06  Tom Tromey  <tom@tromey.com>
13896
13897         * c-exp.y (struct c_parse_state) <macro_original_text,
13898         expansion_obstack>: New member.
13899         (macro_original_text, expansion_obstack): Remove globals.
13900         (scan_macro_expansion, scanning_macro_expansion)
13901         (finished_macro_expansion): Update.
13902         (scan_macro_cleanup): Remove.
13903         (yylex, c_parse): Update.
13904
13905 2019-01-06  Tom Tromey  <tom@tromey.com>
13906
13907         * c-exp.y (struct c_parse_state) <strings>: New member.
13908         (operator_stoken): Update.
13909
13910 2019-01-06  Tom Tromey  <tom@tromey.com>
13911
13912         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
13913         (union type_stack_elt) <typelist_val>: Now a pointer to
13914         std::vector.
13915         (type_stack_cleanup): Don't declare.
13916         (push_typelist): Update.
13917         * parse.c (pop_typelist): Return a std::vector.
13918         (push_typelist): Take a std::vector.
13919         (follow_types): Update.  Do not free args.
13920         (type_stack_cleanup): Remove.
13921         * c-exp.y (struct c_parse_state): New.
13922         (cpstate): New global.
13923         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
13924         (nonempty_typelist): Update.
13925         (func_mod): Create a new vector.
13926         (c_parse): Create a c_parse_state.
13927         (check_parameter_typelist): Do not delete params.
13928         (function_method): Update.  Do not delete type_list.
13929
13930 2019-01-06  Tom Tromey  <tom@tromey.com>
13931
13932         PR gdb/28155:
13933         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
13934         check_typedef.
13935         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
13936         (print_return_value): Likewise.
13937
13938 2019-01-05  Tom Tromey  <tom@tromey.com>
13939
13940         * contrib/cleanup_check.py: Remove.
13941         * contrib/gcc-with-excheck: Remove.
13942         * contrib/exsummary.py: Remove.
13943         * contrib/excheck.py: Remove.
13944
13945 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
13946
13947         * thread.c (delete_thread_1): Add gdb_assert that THR is not
13948         NULL. Initialize tpprev to NULL instead of assigning it
13949         to NULL on the next statement.
13950         * windows-nat.c (windows_delete_thread): Remove check for
13951         main_thread_id before printing thread exit notifications.
13952         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
13953         Remove thread ID check against main_thread_id.
13954         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
13955         windows_delete_thread.
13956         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
13957
13958 2019-01-04  Tom Tromey  <tom@tromey.com>
13959
13960         * compile/compile.c (_initialize_compile): Use upper case for
13961         metasyntactic variables.
13962         * symmisc.c (_initialize_symmisc): Use upper case for
13963         metasyntactic variables.
13964         * psymtab.c (_initialize_psymtab): Use upper case for
13965         metasyntactic variables.
13966         * demangle.c (demangle_command): Use upper case for metasyntactic
13967         variables.
13968         (_initialize_demangler): Likewise.
13969         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
13970         variables.
13971
13972 2019-01-03  Tom Tromey  <tom@tromey.com>
13973
13974         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
13975
13976 2019-01-03  Tom Tromey  <tom@tromey.com>
13977
13978         * python/py-symtab.c (salpy_str): Update.
13979         (struct salpy_sal_object) <symtab>: Now a PyObject.
13980         (salpy_dealloc): Update.
13981         (del_objfile_sal): Use gdbpy_ref.
13982
13983 2019-01-03  Tom Tromey  <tom@tromey.com>
13984
13985         * python/py-type.c (convert_field): Use new_reference.  Return
13986         gdbpy_ref.
13987         (make_fielditem): Return gdbpy_ref.
13988         (typy_fields): Update.
13989         (typy_getitem): Update.
13990         (field_name): Return gdbpy_ref.  Use new_reference.
13991         (typy_iterator_iternext): Update.
13992
13993 2019-01-03  Tom Tromey  <tom@tromey.com>
13994
13995         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
13996
13997 2019-01-03  Tom Tromey  <tom@tromey.com>
13998
13999         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
14000         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
14001         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
14002         (pspy_set_frame_filters, pspy_set_frame_unwinders)
14003         (pspy_set_type_printers): Likewise.
14004         * python/py-function.c (fnpy_init): Use gdbpy_ref.
14005         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
14006         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
14007         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
14008         (objfpy_set_type_printers): Likewise.
14009
14010 2019-01-03  Tom Tromey  <tom@tromey.com>
14011
14012         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
14013         (gdbpy_print_stack): Use gdbpy_err_fetch.
14014         * python/python-internal.h (class gdbpy_err_fetch): New class.
14015         (class gdbpy_enter) <m_error_type, m_error_value,
14016         m_error_traceback>: Remove.
14017         <m_error>: New member.
14018         (gdbpy_exception_to_string): Don't declare.
14019         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
14020         * python/py-value.c (convert_value_from_python): Use
14021         gdbpy_err_fetch.
14022         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
14023         gdbpy_exception_to_string.
14024         (gdbpy_handle_exception): Use gdbpy_err_fetch.
14025         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
14026         gdbpy_err_fetch.
14027
14028 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
14029
14030         * linux-nat.c (delete_lwp_cleanup): Delete.
14031         (struct lwp_deleter): New struct.
14032         (lwp_info_up): New typedef.
14033         (linux_nat_target::follow_fork): Delete cleanup, and make use of
14034         lwp_info_up.
14035
14036 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
14037
14038         * linux-fork.c (class scoped_switch_fork_info): New class.
14039         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
14040
14041 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
14042
14043         * valops.c (find_overload_match): Remove use of null_cleanup, and
14044         calls to do_cleanups.
14045
14046 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
14047
14048         * compile/compile-cplus-types.c
14049         (compile_cplus_instance::decl_name): Handle changes to
14050         cp_func_name.
14051         * cp-support.c (cp_func_name): Update header comment, update
14052         return type.
14053         * cp-support.h (cp_func_name): Update return type in declaration.
14054         * valops.c (find_overload_match): Move temp_func local to top
14055         level of function and change its type.  Use temp_func to hold and
14056         delete temporary string obtained from cp_func_name.
14057
14058 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
14059
14060         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
14061         gdb::char_vector, remove cleanup, and update uses of `msg`.
14062
14063 2019-01-03  Jim Wilson  <jimw@sifive.com>
14064
14065         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
14066
14067 2019-01-02  Tom Tromey  <tom@tromey.com>
14068
14069         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
14070         (tdesc_parse_xml): Remove cleanups.
14071         * target-descriptions.h (make_cleanup_free_target_description):
14072         Don't declare.
14073         (target_desc_deleter): New struct.
14074         (target_desc_up): New typedef.
14075         * target-descriptions.c (target_desc_deleter::operator()): Rename
14076         from free_target_description.
14077         (make_cleanup_free_target_description): Remove.
14078
14079 2019-01-02  Tom Tromey  <tom@tromey.com>
14080
14081         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
14082         constructor, destructor.
14083         (linespec_parser): Remove typedef.
14084         (~linespec_parser): Rename from linespec_parser_delete.
14085         (linespec_lex_to_end, linespec_complete_label)
14086         (linespec_complete): Update.
14087         (decode_line_full): Remove cleanups.
14088         (decode_line_1): Update.
14089
14090 2019-01-02  Tom Tromey  <tom@tromey.com>
14091
14092         * python/python-internal.h (inferior_to_inferior_object): Change
14093         return type.
14094         * python/py-exitedevent.c (create_exited_event_object): Update.
14095         * python/py-inferior.c (inferior_to_inferior_object): Return
14096         gdbpy_ref.
14097         (python_new_inferior, python_inferior_deleted)
14098         (thread_to_thread_object, delete_thread_object)
14099         (build_inferior_list, gdbpy_selected_inferior): Update.
14100         * python/py-infthread.c (create_thread_object): Update.  Also fail
14101         if inferior_to_inferior_object fails.
14102
14103 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
14104
14105         * inferior.h (class inferior) <displaced_step_state>: New field.
14106         * infrun.h (struct displaced_step_state): Move here from
14107         infrun.c.  Initialize fields, add constructor.
14108         <inf>: Remove field.
14109         <reset>: New method.
14110         * infrun.c (struct displaced_step_inferior_state): Move to
14111         infrun.h.
14112         (displaced_step_inferior_states): Remove.
14113         (get_displaced_stepping_state): Adust.
14114         (displaced_step_in_progress_any_inferior): Adjust.
14115         (displaced_step_in_progress_thread): Adjust.
14116         (displaced_step_in_progress): Adjust.
14117         (add_displaced_stepping_state): Remove.
14118         (get_displaced_step_closure_by_addr): Adjust.
14119         (remove_displaced_stepping_state): Remove.
14120         (infrun_inferior_exit): Call displaced_step_state.reset.
14121         (use_displaced_stepping): Don't check for NULL.
14122         (displaced_step_prepare_throw): Call
14123         get_displaced_stepping_state.
14124         (displaced_step_fixup): Don't check for NULL.
14125         (prepare_for_detach): Don't check for NULL.
14126
14127 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14128
14129         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
14130          in case of call that did not complete.
14131
14132 2019-01-02  Andrey Utkin  <autkin@undo.io>
14133
14134         * symfile.c (find_separate_debug_file): Fix search of debug files for
14135         remote debuggee.
14136
14137 2019-01-02  Tom Tromey  <tom@tromey.com>
14138
14139         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
14140         indentation.
14141         * python/py-frame.c (frapy_older): Remove cast.
14142         (frapy_newer): Likewise.
14143         * python/py-breakpoint.c (local_setattro): Remove cast.
14144         * python/py-arch.c (archpy_name): Remove local variable.
14145         * python/py-type.c (gdbpy_lookup_type): Remove cast.
14146
14147 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
14148
14149         * unittests/basic_string_view/element_access/char/empty.cc:
14150         Fix year range in copyright header.
14151
14152 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
14153
14154         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
14155         Delete.
14156         <operator==>: Update with for removed field.
14157         <hash>: Likewise.
14158         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
14159         <isa_features>: ...this.
14160         <abi_features>: New field.
14161         (riscv_isa_flen): Update comment.
14162         (riscv_abi_xlen): New declaration.
14163         (riscv_abi_flen): New declaration.
14164         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
14165         isa_features.
14166         (riscv_abi_xlen): New function.
14167         (riscv_isa_flen): Update to get answer from isa_features.
14168         (riscv_abi_flen): New function.
14169         (riscv_has_fp_abi): Update to get answer from abi_features.
14170         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
14171         xlen and flen.
14172         (riscv_call_info) <xlen, flen>: Update comment.
14173         (riscv_call_arg_struct): Remove invalid assertions
14174         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
14175         is removed.
14176         (riscv_gdbarch_init): Gather isa features and abi features
14177         separately, ensure both match on the gdbarch when reusing an old
14178         gdbarch.  Relax an error check to allow 32-bit abi float to run on
14179         a target with 64-bit float hardware.
14180
14181 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14182
14183         * source.c (search_command_helper): Stop reverse search
14184         when line 1 has been searched.
14185
14186 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14187
14188         * record-full.c (record_full_base_target::close): Rewrite
14189         record_full_core_buf_list free logic.
14190
14191 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14192
14193         * break-catch-syscall.c (print_one_catch_syscall): xfree
14194         the last text.
14195
14196 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
14197
14198         * top.c (print_gdb_version): Update Copyright year in version
14199         message.
14200
14201 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
14202
14203         Update copyright year range in all GDB files.
14204
14205 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
14206
14207         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
14208
14209 For older changes see ChangeLog-2018.
14210 \f
14211 Local Variables:
14212 mode: change-log
14213 left-margin: 8
14214 fill-column: 74
14215 version-control: never
14216 coding: utf-8
14217 End:
14218