gdb/ChangeLog

   1 2020-06-23  Simon Marchi  <simon.marchi@efficios.com>
   2
   3         * dwarf2/loc.c (decode_debug_loclists_addresses): Add empty
   4         lines.
   5
   6 2020-06-23  Simon Marchi  <simon.marchi@efficios.com>
   7
   8         * dwarf2/loc.c (decode_debug_loc_dwo_addresses): Add empty
   9         lines.
  10         (dwarf2_find_location_expression): Likewise.
  11         (call_site_parameter_matches): Likewise.
  12         (dwarf2_compile_expr_to_ax): Likewise.
  13         (disassemble_dwarf_expression): Likewise.
  14         (loclist_describe_location): Likewise.
  15
  16 2020-06-23  Pedro Alves  <palves@redhat.com>
  17
  18         * gdbarch-selftests.c: Don't include inferior.h, gdbthread.h or
  19         progspace-and-thread.h.  Include scoped-mock-context.h instead.
  20         (register_to_value_test): Use scoped_mock_context.
  21         * regcache.c: Include "scoped-mock-context.h".
  22         (cooked_read_test): Don't error out if a target is already pushed.
  23         Use scoped_mock_context.  Adjust.
  24         * scoped-mock-context.h: New file.
  25
  26 2020-06-23  Andrew Burgess  <andrew.burgess@embecosm.com>
  27
  28         * ada-lang.c (ada_language_data): Delete la_is_string_type_p
  29         initializer.
  30         (ada_language::is_string_type_p): New member function.
  31         * c-lang.c (c_language_data): Delete la_is_string_type_p
  32         initializer.
  33         (cplus_language_data): Likewise.
  34         (asm_language_data): Likewise.
  35         (minimal_language_data): Likewise.
  36         * d-lang.c (d_language_data): Likewise.
  37         * f-lang.c (f_is_string_type_p): Delete function, implementation
  38         moved to f_language::is_string_type_p.
  39         (f_language_data): Delete la_is_string_type_p initializer.
  40         (f_language::is_string_type_p): New member function,
  41         implementation from f_is_string_type_p.
  42         * go-lang.c (go_is_string_type_p): Delete function, implementation
  43         moved to go_language::is_string_type_p.
  44         (go_language_data): Delete la_is_string_type_p initializer.
  45         (go_language::is_string_type_p): New member function,
  46         implementation from go_is_string_type_p.
  47         * language.c (language_defn::is_string_type_p): Define new member
  48         function.
  49         (default_is_string_type_p): Make static, add comment copied from
  50         header file.
  51         (unknown_language_data): Delete la_is_string_type_p initializer.
  52         (unknown_language::is_string_type_p): New member function.
  53         (auto_language_data): Delete la_is_string_type_p initializer.
  54         (auto_language::is_string_type_p): New member function.
  55         * language.h (language_data): Delete la_is_string_type_p field.
  56         (language_defn::is_string_type_p): Declare new function.
  57         (default_is_string_type_p): Delete desclaration, move comment to
  58         definition.
  59         * m2-lang.c (m2_is_string_type_p): Delete function, implementation
  60         moved to m2_language::is_string_type_p.
  61         (m2_language_data): Delete la_is_string_type_p initializer.
  62         (m2_language::is_string_type_p): New member function,
  63         implementation from m2_is_string_type_p.
  64         * objc-lang.c (objc_language_data): Delete la_is_string_type_p
  65         initializer.
  66         * opencl-lang.c (opencl_language_data): Likewise.
  67         * p-lang.c (pascal_is_string_type_p): Delete function,
  68         implementation moved to pascal_language::is_string_type_p.
  69         (pascal_language_data): Delete la_is_string_type_p initializer.
  70         (pascal_language::is_string_type_p): New member function,
  71         implementation from pascal_is_string_type_p.
  72         * rust-lang.c (rust_is_string_type_p): Delete function,
  73         implementation moved to rust_language::is_string_type_p.
  74         (rust_language_data): Delete la_is_string_type_p initializer.
  75         (rust_language::is_string_type_p): New member function,
  76         implementation from rust_is_string_type_p.
  77         * valprint.c (val_print_scalar_or_string_type_p): Update call to
  78         is_string_type_p.
  79
  80 2020-06-23  Andrew Burgess  <andrew.burgess@embecosm.com>
  81
  82         * ada-lang.c (ada_language_data): Delete la_print_typedef
  83         initializer.
  84         (ada_language::print_typedef): New member function.
  85         * c-lang.c (c_language_data): Delete la_print_typedef initializer.
  86         (cplus_language_data): Likewise.
  87         (asm_language_data): Likewise.
  88         (minimal_language_data): Likewise.
  89         * d-lang.c (d_language_data): Likewise.
  90         * f-lang.c (f_language_data): Likewise.
  91         (f_language::print_typedef): New member function.
  92         * go-lang.c (go_language_data): Delete la_print_typedef
  93         initializer.
  94         * language.c (language_defn::print_typedef): Define member
  95         function.
  96         (unknown_language_data): Delete la_print_typedef initializer.
  97         (unknown_language::print_typedef): New member function.
  98         (auto_language_data): Delete la_print_typedef initializer.
  99         (auto_language::print_typedef): New member function.
 100         * language.h (language_data): Delete la_print_typedef field.
 101         (language_defn::print_typedef): Declare new member function.
 102         (LA_PRINT_TYPEDEF): Update call to print_typedef.
 103         (default_print_typedef): Delete declaration.
 104         * m2-lang.c (m2_language_data): Delete la_print_typedef
 105         initializer.
 106         (m2_language::print_typedef): New member function.
 107         * objc-lang.c (objc_language_data): Delete la_print_typedef
 108         initializer.
 109         * opencl-lang.c (opencl_language_data): Likewise.
 110         * p-lang.c (pascal_language_data): Likewise.
 111         (pascal_language::print_typedef): New member function.
 112         * rust-lang.c (rust_print_typedef): Delete function,
 113         implementation moved to rust_language::print_typedef.
 114         (rust_language): Delete la_print_typedef initializer.
 115         (rust_language::print_typedef): New member function,
 116         implementation from rust_print_typedef.
 117         * typeprint.c (default_print_typedef): Delete.
 118
 119 2020-06-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 120
 121         * ada-lang.c (ada_language_data): Delete la_printstr initializer.
 122         (ada_language::printstr): New member function.
 123         * c-lang.c (c_language_data): Delete la_printstr initializer.
 124         (cplus_language_data): Likewise.
 125         (asm_language_data): Likewise.
 126         (minimal_language_data): Likewise.
 127         * d-lang.c (d_language_data): Likewise.
 128         * f-lang.c (f_printstr): Rename to f_language::printstr.
 129         (f_language_data): Delete la_printstr initializer.
 130         (f_language::printstr): New member function, implementation from
 131         f_printstr.
 132         * go-lang.c (go_language_data): Delete la_printstr initializer.
 133         * language.c (language_defn::printstr): Define new member
 134         function.
 135         (unk_lang_printstr): Delete.
 136         (unknown_language_data): Delete la_printstr initializer.
 137         (unknown_language::printstr): New member function.
 138         (auto_language_data): Delete la_printstr initializer.
 139         (auto_language::printstr): New member function.
 140         * language.h (language_data): Delete la_printstr field.
 141         (language_defn::printstr): Declare new member function.
 142         (LA_PRINT_STRING): Update call to printstr.
 143         * m2-lang.c (m2_printstr): Rename to m2_language::printstr.
 144         (m2_language_data): Delete la_printstr initializer.
 145         (m2_language::printstr): New member function, implementation from
 146         m2_printstr.
 147         * objc-lang.c (objc_language_data): Delete la_printstr
 148         initializer.
 149         * opencl-lang.c (opencl_language_data): Likewise.
 150         * p-lang.c (pascal_printstr): Rename to pascal_language::printstr.
 151         (pascal_language_data): Delete la_printstr initializer.
 152         (pascal_language::printstr): New member function, implementation
 153         from pascal_printstr.
 154         * p-lang.h (pascal_printstr): Delete declaration.
 155         * rust-lang.c (rust_printstr): Update header comment.
 156         (rust_language_data): Delete la_printstr initializer.
 157         (rust_language::printstr): New member function.
 158
 159 2020-06-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 160
 161         * ada-lang.c (ada_language_data): Delete la_printchar initializer.
 162         (ada_language::printchar): New member function.
 163         * c-lang.c (c_language_data): Delete la_printchar initializer.
 164         (cplus_language_data): Likewise.
 165         (asm_language_data): Likewise.
 166         (minimal_language_data): Likewise.
 167         * d-lang.c (d_language_data): Likewise.
 168         * f-lang.c (f_printchar): Rename to f_language::printchar.
 169         (f_language_data): Delete la_printchar initializer.
 170         (f_language::printchar): New member function, implementation from
 171         f_printchar.
 172         * go-lang.c (go_language_data): Delete la_printchar initializer.
 173         * language.c (unk_lang_printchar): Delete.
 174         (language_defn::printchar): Define new member function.
 175         (unknown_language_data): Delete la_printchar initializer.
 176         (unknown_language::printchar): New member function.
 177         (auto_language_data): Delete la_printchar initializer.
 178         (auto_language::printchar): New member function.
 179         * language.h (language_data): Delete la_printchar field.
 180         (language_defn::printchar): Declare new member function.
 181         (LA_PRINT_CHAR): Update call to printchar.
 182         * m2-lang.c (m2_language_data): Delete la_printchar initializer.
 183         (m2_language::printchar): New member function.
 184         * objc-lang.c (objc_language_data): Delete la_printchar
 185         initializer.
 186         * opencl-lang.c (opencl_language_data): Likewise.
 187         * p-lang.c (pascal_language_data): Delete la_printchar
 188         initializer.
 189         (pascal_language::printchar): New member function.
 190         * rust-lang.c (rust_printchar): Rename to
 191         rust_language::printchar.
 192         (rust_language_data): Delete la_printchar initializer.
 193         (rust_language::printchar): New member function, implementation
 194         from rust_printchar.
 195
 196 2020-06-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 197
 198         * ada-lang.c (emit_char): Renamed to ada_language::emitchar.
 199         (ada_language_data): Delete la_emitchar initializer.
 200         (ada_language::emitchar): New member function, implementation from
 201         emit_char.
 202         * c-lang.c (c_language_data): Delete la_emitchar initializer.
 203         (cplus_language_data): Likewise.
 204         (asm_language_data): Likewise.
 205         (minimal_language_data): Likewise.
 206         * d-lang.c (d_language_data): Likewise.
 207         * f-lang.c (f_emit_char): Rename to f_language::emitchar.
 208         (f_language_data): Delete la_emitchar initializer.
 209         (f_language::emitchar): New member function, implementation from
 210         f_emit_char.
 211         * go-lang.c (go_language_data): Delete la_emitchar initializer.
 212         * language.c (unk_lang_emit_char): Delete.
 213         (language_defn::emitchar): New member function definition.
 214         (unknown_language_data): Delete la_emitchar initializer.
 215         (unknown_language::emitchar): New member function.
 216         (auto_language_data): Delete la_emitchar initializer.
 217         (auto_language::emitchar): New member function.
 218         * language.h (language_data): Delete la_emitchar field.
 219         (language_defn::emitchar): New member field declaration.
 220         (LA_EMIT_CHAR): Update call to emitchar.
 221         * m2-lang.c (m2_emit_char): Rename to m2_language::emitchar.
 222         (m2_language_data): Delete la_emitchar initializer.
 223         (m2_language::emitchar): New member function, implementation from
 224         m2_emit_char.
 225         * objc-lang.c (objc_language_data): Delete la_emitchar
 226         initializer.
 227         * opencl-lang.c (opencl_language_data): Likewise.
 228         * p-lang.c (pascal_emit_char): Rename to pascal_language::emitchar.
 229         (pascal_language_data): Delete la_emitchar initializer.
 230         (pascal_language::emitchar): New member function, implementation
 231         from pascal_emit_char.
 232         * rust-lang.c (rust_emitchar): Rename to rust_language::emitchar.
 233         (rust_language_data): Delete la_emitchar initializer.
 234         (rust_language::emitchar): New member function, implementation
 235         from rust_emitchar.
 236
 237 2020-06-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 238
 239         * ada-lang.c (resolve): Rename to ada_language::post_parser.
 240         (ada_language_data): Delete la_post_parser initializer.
 241         (ada_language::post_parser): New member function.
 242         * c-lang.c (c_language_data): Delete la_post_parser initializer.
 243         (cplus_language_data): Likewise.
 244         (asm_language_data): Likewise.
 245         (minimal_language_data): Likewise.
 246         * d-lang.c (d_language_data): Likewise.
 247         * f-lang.c (f_language_data): Likewise.
 248         * go-lang.c (go_language_data): Likewise.
 249         * language.c (unknown_language_data): Likewise.
 250         (auto_language_data): Likewise.
 251         * language.h (language_data): Delete la_post_parser field.
 252         (language_defn::post_parser): New member function.
 253         * m2-lang.c (m2_language_data): Delete la_post_parser initializer.
 254         * objc-lang.c (objc_language_data): Likewise.
 255         * opencl-lang.c (opencl_language_data): Likewise.
 256         * p-lang.c (pascal_language_data): Likewise.
 257         * parse.c (parse_exp_in_context): Update call to post_parser.
 258         (null_post_parser): Delete definition.
 259         * parser-defs.h (null_post_parser): Delete declaration.
 260         * rust-lang.c (rust_language_data): Delete la_post_parser
 261         initializer.
 262
 263 2020-06-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 264
 265         * ada-lang.c (parse): Rename to ada_language::parser.
 266         (ada_language_data): Delete la_parser initializer.
 267         (ada_language::parser): New member function, implementation from
 268         parse.
 269         * c-lang.c (c_language_data): Delete la_parser initializer.
 270         (cplus_language_data): Likewise.
 271         (asm_language_data): Likewise.
 272         (minimal_language_data): Likewise.
 273         * d-lang.c (d_language_data): Likewise.
 274         (d_language::parser): New member function.
 275         * f-lang.c (f_language_data): Delete la_parser initializer.
 276         (f_language::parser): New member function.
 277         * go-lang.c (go_language_data): Delete la_parser initializer.
 278         (go_language::parser): New member function.
 279         * language.c (unk_lang_parser): Delete.
 280         (language_defn::parser): Define new member function.
 281         (unknown_language_data): Delete la_parser initializer.
 282         (unknown_language::parser): New member function.
 283         (auto_language_data): Delete la_parser initializer.
 284         (auto_language::parser): New member function.
 285         * language.h (language_data): Delete la_parser field.
 286         (language_defn::parser): Declare new member function.
 287         * m2-lang.c (m2_language_data): Delete la_parser initializer.
 288         (m2_language::parser): New member function.
 289         * objc-lang.c (objc_language_data): Delete la_parser initializer.
 290         * opencl-lang.c (opencl_language_data): Likewise.
 291         * p-lang.c (pascal_language_data): Likewise.
 292         (pascal_language::parser): New member function.
 293         * parse.c (parse_exp_in_context): Update call to parser.
 294         * rust-lang.c (rust_language_data): Delete la_parser initializer.
 295         (rust_language::parser): New member function.
 296
 297 2020-06-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 298
 299         * top.c (print_gdb_configuration): Print --with-python-libdir
 300         configuration value.
 301
 302 2020-06-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 303
 304         * NEWS: Mention change to the alias command.
 305
 306 2020-06-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 307
 308         * cli/cli-cmds.c (lookup_cmd_for_default_args)
 309         (alias_command_completer)
 310         (make_alias_options_def_group): New functions.
 311         (alias_opts, alias_option_defs): New struct and array.
 312         (alias_usage_error): Update usage.
 313         (alias_command): Handles optional DEFAULT-ARGS... arguments.
 314         Use option framework.
 315         (_initialize_cli_cmds): Update alias command help.
 316         Update aliases command help.
 317         (show_user):
 318         Add NULL for new default_args lookup_cmd argument.
 319         (valid_command_p): Rename to validate_aliased_command.
 320         Add NULL for new default_args lookup_cmd argument.  Verify that the
 321         aliased_command has no default args.
 322         * cli/cli-decode.c (help_cmd): Show aliases definitions.
 323         (lookup_cmd_1, lookup_cmd): New argument default_args.
 324         (add_alias_cmd):
 325         Add NULL for new default_args lookup_cmd argument.
 326         (print_help_for_command): Show default args under the layout
 327          alias some_alias = some_aliased_cmd some_alias_default_arg.
 328         * cli/cli-decode.h (struct cmd_list_element): New member default_args.
 329         xfree default_args in destructor.
 330         * cli/cli-script.c (process_next_line, do_define_command):
 331         Add NULL for new default_args lookup_cmd argument.
 332         * command.h: Declare new default_args argument in lookup_cmd
 333         and lookup_cmd_1.
 334         * completer.c (complete_line_internal_1):
 335         Add NULL for new default_args lookup_cmd or lookup_cmd_1 argument.
 336         * guile/scm-cmd.c (gdbscm_parse_command_name): Likewise.
 337         * guile/scm-param.c (add_setshow_generic, pascm_parameter_defined_p):
 338         Likewise.
 339         * infcmd.c (_initialize_infcmd): Likewise.
 340         * python/py-auto-load.c (gdbpy_initialize_auto_load): Likewise.
 341         * python/py-cmd.c (gdbpy_parse_command_name): Likewise.
 342         * python/py-param.c (add_setshow_generic): Likewise.
 343         * remote.c (_initialize_remote): Likewise.
 344         * top.c (execute_command): Prepend default_args if command has some.
 345         (set_verbose):
 346         Add NULL for new default_args lookup_cmd or lookup_cmd_1 argument.
 347         * tracepoint.c (validate_actionline, encode_actions_1):
 348         Add NULL for new default_args lookup_cmd or lookup_cmd_1 argument.
 349
 350 2020-06-22  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 351
 352         * jit.c (jit_read_descriptor): Use bool as the return type.
 353         (jit_breakpoint_re_set_internal): Use bool as the return type.
 354         Invert the return value logic; return true if the jit breakpoint
 355         has been successfully initialized.
 356         (jit_inferior_init): Update the call to
 357         jit_breakpoint_re_set_internal.
 358
 359 2020-06-22  Pedro Alves  <palves@redhat.com>
 360
 361         PR gdb/25939
 362         * procfs.c (procfs_target::wait): Don't reference inferior_ptid.
 363         Use the current inferior instead.  Don't return
 364         TARGET_WAITKIND_SPURIOUS/inferior_ptid -- instead continue and
 365         wait again.
 366         * sol-thread.c (sol_thread_target::wait): Don't reference
 367         inferior_ptid.
 368         (ps_lgetregs, ps_lsetregs, ps_lgetfpregs, ps_lsetfpregs)
 369         (sol_update_thread_list_callback): Use the current inferior's pid
 370         instead of inferior_ptid.
 371
 372 2020-06-21  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
 373
 374         * procfs.c: Cleanup many comments.
 375
 376         (READ_WATCHFLAG, WRITE_WATCHFLAG, EXEC_WATCHFLAG)
 377         (AFTER_WATCHFLAG): Replace by value.
 378
 379         (MAIN_PROC_NAME_FORMAT): Inline ...
 380         (create_procinfo): ... here.
 381
 382         (procfs_debug_inferior): Remove SYS_exec handling.
 383         (syscall_is_exec): Likewise.
 384         (procfs_set_exec_trap): Likewise.
 385
 386         (syscall_is_lwp_exit): Inline in callers.
 387         (syscall_is_exit): Likewise.
 388         (syscall_is_exec): Likewise.
 389         (syscall_is_lwp_create): Likewise.
 390
 391         (invalidate_cache): Remove #if 0 code.
 392
 393         (make_signal_thread_runnable):  Remove.
 394         (procfs_target::resume): Remove #if 0 code.
 395
 396 2020-06-21  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
 397
 398         PR gdb/25939
 399         * procfs.c (procfs_target::procfs_init_inferior): Move push_target
 400         call ...
 401         (procfs_target::create_inferior): ... here.
 402
 403 2020-06-21  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 404
 405         * exec.c (validate_exec_file): Ensure the build-id is up to
 406         date by calling reopen_exec_file (that checks file timestamp
 407         to decide to re-read the file).
 408
 409 2020-06-18  Pedro Alves  <palves@redhat.com>
 410
 411         PR gdb/25412
 412         * gdbthread.h (delete_thread, delete_thread_silent)
 413         (find_thread_ptid): Update comments.
 414         * thread.c (current_thread_): New global.
 415         (is_current_thread): Move higher, and reimplement.
 416         (inferior_thread): Reimplement.
 417         (set_thread_exited): Use bool.  Add assertions.
 418         (add_thread_silent): Simplify thread-reuse handling by always
 419         calling delete_thread.
 420         (delete_thread): Remove intro comment.
 421         (find_thread_ptid): Skip exited threads.
 422         (switch_to_thread_no_regs): Write to current_thread_.
 423         (switch_to_no_thread): Check CURRENT_THREAD_ instead of
 424         INFERIOR_PTID.  Clear current_thread_.
 425
 426 2020-06-18  Pedro Alves  <palves@redhat.com>
 427
 428         * aix-thread.c (pd_update): Use switch_to_thread.
 429
 430 2020-06-18  Pedro Alves  <palves@redhat.com>
 431
 432         * ravenscar-thread.c (ravenscar_thread_target): Update.
 433         (ravenscar_thread_target::update_inferior_ptid): Rename to ...
 434         (ravenscar_thread_target::add_active_thread): ... this.  Don't
 435         set m_base_ptid here.  Update to avoid referencing inferior_ptid.
 436         (ravenscar_thread_target::wait): Don't write to inferior_ptid.
 437
 438 2020-06-18  Pedro Alves  <palves@redhat.com>
 439
 440         * nat/windows-nat.c (current_windows_thread): Remove.
 441         * nat/windows-nat.h (current_windows_thread): Remove.
 442         * windows-nat.c (windows_nat_target::stopped_by_sw_breakpoint):
 443         Adjust.
 444         (display_selectors): Adjust to fetch the current
 445         windows_thread_info based on inferior_ptid.
 446         (fake_create_process): No longer write to current_windows_thread.
 447         (windows_nat_target::get_windows_debug_event):
 448         Don't set inferior_ptid or current_windows_thread.
 449         (windows_nat_target::wait): Adjust to not rely on
 450         current_windows_thread.
 451         (do_initial_windows_stuff): Now a method of windows_nat_target.
 452         Switch to the last_ptid thread.
 453         (windows_nat_target::attach): Adjust.
 454         (windows_nat_target::detach): Use switch_to_no_thread instead of
 455         writing to inferior_ptid directly.
 456         (windows_nat_target::create_inferior): Adjust.
 457
 458 2020-06-18  Pedro Alves  <palves@redhat.com>
 459
 460         * windows-nat.c (do_initial_windows_stuff): No longer set inferior_ptid.
 461
 462 2020-06-18  Pedro Alves  <palves@redhat.com>
 463
 464         * go32-nat.c (go32_nat_target::create_inferior): Switch to thread
 465         after creating it, instead of writing to inferior_ptid.  Don't
 466         write to inferior_ptid.
 467
 468 2020-06-18  Pedro Alves  <palves@redhat.com>
 469
 470         * fork-child.c (postfork_hook): Don't write to inferior_ptid.
 471
 472 2020-06-18  Pedro Alves  <palves@redhat.com>
 473
 474         * bsd-kvm.c (bsd_kvm_target_open): Switch to thread after adding
 475         it, instead of writing to inferior_ptid.
 476
 477 2020-06-18  Pedro Alves  <palves@redhat.com>
 478
 479         * btrace.c (btrace_fetch): Use switch_to_thread instead of writing
 480         to inferior_ptid.
 481
 482 2020-06-18  Pedro Alves  <palves@redhat.com>
 483
 484         * bsd-kvm.c (bsd_kvm_target::close): Use switch_to_no_thread
 485         instead of writing to inferior_ptid directly.
 486
 487 2020-06-18  Pedro Alves  <palves@redhat.com>
 488
 489         * corelow.c (core_target::close): Use switch_to_no_thread instead
 490         of writing to inferior_ptid directly.
 491         (add_to_thread_list, core_target_open): Use switch_to_thread
 492         instead of writing to inferior_ptid directly.
 493
 494 2020-06-18  Pedro Alves  <palves@redhat.com>
 495
 496         * darwin-nat.c (darwin_nat_target::decode_message): Don't write to
 497         inferior_ptid.
 498         (darwin_nat_target::stop_inferior, darwin_nat_target::kill): Avoid
 499         inferior_ptid.
 500         (darwin_attach_pid): Use switch_to_no_thread instead of writing to
 501         inferior_ptid directly.
 502         (darwin_nat_target::init_thread_list): Switch to thread, instead
 503         of writing to inferior_ptid.
 504         (darwin_nat_target::attach): Don't write to inferior_ptid.
 505         (darwin_nat_target::get_ada_task_ptid): Avoid inferior_ptid.
 506
 507 2020-06-18  Pedro Alves  <palves@redhat.com>
 508
 509         * gnu-nat.c (gnu_nat_target::create_inferior): Switch to the added
 510         thread.
 511         (gnu_nat_target::attach): Don't write to inferior_ptid directly.
 512         Instead use switch_to_thread.
 513         (gnu_nat_target::detach): Use switch_to_no_thread
 514         instead of writing to inferior_ptid directly.  Used passed-in
 515         inferior instead of looking up the inferior by pid.
 516
 517 2020-06-18  Pedro Alves  <palves@redhat.com>
 518
 519         * go32-nat.c (go32_nat_target::create_inferior): Don't write to
 520         inferior_ptid.
 521
 522 2020-06-18  Pedro Alves  <palves@redhat.com>
 523
 524         * nto-procfs.c (nto_procfs_target::update_thread_list): Avoid
 525         inferior_ptid.
 526         (nto_procfs_target::attach): Avoid inferior_ptid.  Switch to
 527         thread.
 528         (nto_procfs_target::detach): Avoid referencing
 529         inferior_ptid.  Use switch_to_no_thread instead of writing to
 530         inferior_ptid directly.
 531         (nto_procfs_target::mourn_inferior): Use switch_to_no_thread
 532         instead of writing to inferior_ptid directly.
 533         (nto_procfs_target::create_inferior): Avoid inferior_ptid.  Switch
 534         to thread.
 535
 536 2020-06-18  Pedro Alves  <palves@redhat.com>
 537
 538         * remote-sim.c (gdbsim_target::create_inferior): Switch to thread
 539         after creating it, instead of writing to inferior_ptid.
 540         (gdbsim_target_open): Use switch_to_no_thread instead of writing
 541         to inferior_ptid directly.
 542         (gdbsim_target::wait): Don't write to inferior_ptid.
 543
 544 2020-06-18  Pedro Alves  <palves@redhat.com>
 545
 546         * remote.c (remote_target::remote_notice_new_inferior): Use
 547         switch_to_thread instead of writing to inferior_ptid directly.
 548         (remote_target::add_current_inferior_and_thread): Use
 549         switch_to_no_thread instead of writing to inferior_ptid directly.
 550         (extended_remote_target::attach): Use switch_to_inferior_no_thread
 551         and switch_to_thread instead of using set_current_inferior or
 552         writing to inferior_ptid directly.
 553
 554 2020-06-18  Pedro Alves  <palves@redhat.com>
 555
 556         * tracectf.c (ctf_target_open): Switch to added thread instead of
 557         writing to inferior_ptid directly.
 558         (ctf_target::close): Use switch_to_no_thread instead of writing to
 559         inferior_ptid directly.
 560
 561 2020-06-18  Pedro Alves  <palves@redhat.com>
 562
 563         * tracefile-tfile.c (tfile_target_open): Don't write to
 564         inferior_ptid directly, instead switch to added thread.
 565         (tfile_target::close): Use switch_to_no_thread instead of writing
 566         to inferior_ptid directly.
 567
 568 2020-06-18  Pedro Alves  <palves@redhat.com>
 569
 570         * procfs.c (procfs_target::attach): Don't write to inferior_ptid.
 571         (procfs_target::detach): Use switch_to_no_thread
 572         instead of writing to inferior_ptid directly.
 573         (do_attach): Change return type to void.  Switch to the added
 574         thread.
 575         (procfs_target::create_inferior): Switch to the added thread.
 576         (procfs_do_thread_registers): Don't write to inferior_ptid.
 577
 578 2020-06-18  Pedro Alves  <palves@redhat.com>
 579
 580         * infrun.c (generic_mourn_inferior): Use switch_to_thread instead
 581         of writing to inferior_ptid.
 582         (scoped_restore_exited_inferior): Delete.
 583         (handle_vfork_child_exec_or_exit): Simplify using
 584         scoped_restore_current_pspace_and_thread.  Use switch_to_thread
 585         instead of writing to inferior_ptid.
 586         (THREAD_STOPPED_BY): Delete.
 587         (thread_stopped_by_watchpoint, thread_stopped_by_sw_breakpoint)
 588         (thread_stopped_by_hw_breakpoint): Delete.
 589         (save_waitstatus): Use
 590         scoped_restore_current_thread+switch_to_thread, and call
 591         target_stopped_by_watchpoint instead of
 592         thread_stopped_by_watchpoint, target_stopped_by_sw_breakpoint
 593         instead of thread_stopped_by_sw_breakpoint, and
 594         target_stopped_by_hw_breakpoint instead of
 595         thread_stopped_by_hw_breakpoint.
 596         (handle_inferior_event)
 597         <TARGET_WAITKIND_EXITED/TARGET_WAITKIND_SIGNALLED>: Don't write to
 598         inferior_ptid directly, nor
 599         set_current_inferior/set_current_program_space.  Use
 600         switch_to_thread / switch_to_inferior_no_thread instead.
 601
 602 2020-06-18  Pedro Alves  <palves@redhat.com>
 603
 604         * target.c (generic_mourn_inferior): Use switch_to_no_thread
 605         instead of writing to inferior_ptid.
 606
 607 2020-06-18  Pedro Alves  <palves@redhat.com>
 608
 609         * inf-ptrace.c (inf_ptrace_target::create_inferior): Switch to the
 610         added thread.
 611         (inf_ptrace_target::attach): Don't write to inferior_ptid.  Switch
 612         to the added thread.
 613         (inf_ptrace_target::detach_success): Use switch_to_no_thread
 614         instead of writing to inferior_ptid.
 615
 616 2020-06-18  Pedro Alves  <palves@redhat.com>
 617
 618         * gdbarch-selftests.c: Include "progspace-and-thread.h".
 619         (register_to_value_test): Mock a program_space too.  Heap-allocate
 620         the address space.  Don't write to inferior_ptid.  Use
 621         switch_to_thread instead.
 622
 623 2020-06-18  Pedro Alves  <palves@redhat.com>
 624
 625         * linux-tdep.c (find_signalled_thread(thread_info *,void *)):
 626         Delete.
 627         (find_signalled_thread()): New, factored out from
 628         linux_make_corefile_notes and adjusted to handle exited threads.
 629         (linux_make_corefile_notes): Adjust to use the new
 630         find_signalled_thread.
 631
 632 2020-06-18  Pedro Alves  <palves@redhat.com>
 633
 634         * linux-tdep.c (btrace_fetch): Save/restore current thread instead
 635         of saving/restoring inferior_ptid.
 636
 637 2020-06-17  Tom Tromey  <tom@tromey.com>
 638
 639         * tui/tui-win.h (tui_scroll_forward, tui_scroll_backward)
 640         (tui_scroll_left, tui_scroll_right, struct tui_win_info): Don't
 641         declare.
 642         * tui/tui-data.h (MIN_CMD_WIN_HEIGHT): Remove.
 643
 644 2020-06-15  Simon Marchi  <simon.marchi@efficios.com>
 645
 646         * dwarf2/read.c (dwarf2_initialize_objfile): Check for presence
 647         of partial symtabs.
 648
 649 2020-06-17  Simon Marchi  <simon.marchi@efficios.com>
 650
 651         * regformats/reg-arm.dat: Remove.
 652         * regformats/reg-bfin.dat: Remove.
 653         * regformats/reg-cris.dat: Remove.
 654         * regformats/reg-crisv32.dat: Remove.
 655         * regformats/reg-m32r.dat: Remove.
 656         * regformats/reg-tilegx.dat: Remove.
 657         * regformats/reg-tilegx32.dat: Remove.
 658
 659 2020-06-17  Simon Marchi  <simon.marchi@efficios.com>
 660
 661         * features/Makefile (WHICH): Remove arm files.
 662         * regformats/arm/arm-with-iwmmxt.dat: Remove.
 663         * regformats/arm/arm-with-neon.dat: Remove.
 664         * regformats/arm/arm-with-vfpv2.dat: Remove.
 665         * regformats/arm/arm-with-vfpv3.dat: Remove.
 666
 667 2020-06-17  Simon Marchi  <simon.marchi@efficios.com>
 668
 669         * features/Makefile (XMLTOC): Remove rx.xml.
 670
 671 2020-06-17  Pedro Alves  <palves@redhat.com>
 672
 673         * gdbthread.h (thread_control_state) <trap_expected> Update
 674         comments.
 675
 676 2020-06-17  Andrew Burgess  <andrew.burgess@embecosm.com>
 677
 678         * ada-lang.c (ada_lookup_symbol_nonlocal): Rename to
 679         ada_language::lookup_symbol_nonlocal.
 680         (ada_language_data): Delete la_lookup_symbol_nonlocal initializer.
 681         (ada_language::lookup_symbol_nonlocal): New member function,
 682         implementation from ada_lookup_symbol_nonlocal.
 683         * c-lang.c (c_language_data): Delete la_lookup_symbol_nonlocal
 684         initializer.
 685         (cplus_language_data): Delete la_lookup_symbol_nonlocal
 686         initializer.
 687         (cplus_language::lookup_symbol_nonlocal): New member function.
 688         (asm_language_data): Delete la_lookup_symbol_nonlocal initializer.
 689         (minimal_language_data) Likewise.
 690         * cp-namespace.c (cp_lookup_nested_symbol): Update comment.
 691         * d-lang.c (d_language_data): Delete la_lookup_symbol_nonlocal
 692         initializer.
 693         (d_language::lookup_symbol_nonlocal): New member function.
 694         * f-lang.c (f_language_data): Delete la_lookup_symbol_nonlocal
 695         initializer.
 696         (f_language::lookup_symbol_nonlocal): New member function.
 697         * go-lang.c (go_language_data): Delete la_lookup_symbol_nonlocal
 698         initializer.
 699         * language.c (unknown_language_data): Likewise.
 700         (auto_language_data): Likewise.
 701         * language.h (language_data): Delete la_lookup_symbol_nonlocal
 702         field.
 703         (language_defn::lookup_symbol_nonlocal): New member function.
 704         * m2-lang.c (m2_language_data): Delete la_lookup_symbol_nonlocal
 705         initializer.
 706         * objc-lang.c (objc_language_data): Likewise.
 707         * opencl-lang.c (opencl_language_data): Likewise.
 708         * p-lang.c (pascal_language_data): Likewise.
 709         * rust-lang.c (rust_lookup_symbol_nonlocal): Rename to
 710         rust_language::lookup_symbol_nonlocal.
 711         (rust_language_data): Delete la_lookup_symbol_nonlocal
 712         initializer.
 713         (rust_language::lookup_symbol_nonlocal): New member function,
 714         implementation from rust_lookup_symbol_nonlocal.
 715         * symtab.c (lookup_symbol_aux): Update call to
 716         lookup_symbol_nonlocal.
 717         (basic_lookup_symbol_nonlocal): Rename to...
 718         (language_defn::lookup_symbol_nonlocal): ...this, and update
 719         header comment.  Remove language_defn parameter, and replace with
 720         uses of `this'.
 721         * symtab.h (basic_lookup_symbol_nonlocal): Delete declaration.
 722
 723 2020-06-17  Andrew Burgess  <andrew.burgess@embecosm.com>
 724
 725         * ada-lang.c (ada_language_data): Delete la_value_print_inner
 726         initializer.
 727         (ada_language::value_print_inner): New member function.
 728         * c-lang.c (c_language_data): Delete la_value_print_inner
 729         initializer.
 730         (cplus_language_data): Likewise.
 731         (asm_language_data): Likewise.
 732         (minimal_language_data): Likewise.
 733         * d-lang.c (d_language_data): Likewise.
 734         (d_language::value_print_inner): New member function.
 735         * f-lang.c (f_language_data): Delete la_value_print_inner
 736         initializer.
 737         (f_language::value_print_inner): New member function.
 738         * f-lang.h (f_value_print_innner): Rename to...
 739         (f_value_print_inner): ...this (note spelling of 'inner').
 740         * f-valprint.c (f_value_print_innner): Rename to...
 741         (f_value_print_inner): ...this (note spelling of 'inner').
 742         * go-lang.c (go_language_data): Delete la_value_print_inner
 743         initializer.
 744         (go_language::value_print_inner): New member function.
 745         * language.c (language_defn::value_print_inner): Define new member
 746         function.
 747         (unk_lang_value_print_inner): Delete.
 748         (unknown_language_data): Delete la_value_print_inner initializer.
 749         (unknown_language::value_print_inner): New member function.
 750         (auto_language_data): Delete la_value_print_inner initializer.
 751         (auto_language::value_print_inner): New member function.
 752         * language.h (language_data): Delete la_value_print_inner field.
 753         (language_defn::value_print_inner): Delcare new member function.
 754         * m2-lang.c (m2_language_data): Delete la_value_print_inner
 755         initializer.
 756         (m2_language::value_print_inner): New member function.
 757         * objc-lang.c (objc_language_data): Delete la_value_print_inner
 758         initializer.
 759         * opencl-lang.c (opencl_language_data): Likewise.
 760         * p-lang.c (pascal_language_data): Likewise.
 761         (pascal_language::value_print_inner): New member function.
 762         * rust-lang.c (rust_language_data): Delete la_value_print_inner
 763         initializer.
 764         (rust_language::value_print_inner): New member function.
 765         * valprint.c (do_val_print): Update call to value_print_inner.
 766
 767 2020-06-17  Andrew Burgess  <andrew.burgess@embecosm.com>
 768
 769         * ada-lang.c (ada_language_data): Delete la_value_print
 770         initializer.
 771         (ada_language::value_print): New member function.
 772         * c-lang.c (c_language_data): Delete la_value_print initializer.
 773         (cplus_language_data): Likewise.
 774         (asm_language_data): Likewise.
 775         (minimal_language_data): Likewise.
 776         * d-lang.c (d_language_data): Likewise.
 777         * f-lang.c (f_language_data): Likewise.
 778         * go-lang.c (go_language_data): Likewise.
 779         * language.c (unk_lang_value_print): Delete.
 780         (language_defn::value_print): Define new member function.
 781         (unknown_language_data): Delete la_value_print initializer.
 782         (unknown_language::value_print): New member function.
 783         (auto_language_data): Delete la_value_print initializer.
 784         (auto_language::value_print): New member function.
 785         * language.h (language_data): Delete la_value_print field.
 786         (language_defn::value_print): Declare new member function.
 787         (LA_VALUE_PRINT): Update call to value_print.
 788         * m2-lang.c (m2_language_data): Delete la_value_print initializer.
 789         * objc-lang.c (objc_language_data): Likewise.
 790         * opencl-lang.c (opencl_language_data): Likewise.
 791         * p-lang.c (pascal_language_data): Likewise.
 792         (pascal_language::value_print): New member function.
 793         * rust-lang.c (rust_language_data): Delete la_value_print
 794         initializer.
 795
 796 2020-06-17  Andrew Burgess  <andrew.burgess@embecosm.com>
 797
 798         * ada-lang.c (ada_watch_location_expression): Rename to
 799         ada_language::watch_location_expression.
 800         (ada_language_data): Delete la_watch_location_expression
 801         initializer.
 802         (ada_language::watch_location_expression): New member function,
 803         implementation from ada_watch_location_expression.
 804         * breakpoint.c (watch_command_1): Update call to
 805         watch_location_expression.
 806         * c-lang.c (c_watch_location_expression): Rename to
 807         language_defn::watch_location_expression.
 808         (c_language_data): Delete la_watch_location_expression
 809         initializer.
 810         (cplus_language_data): Likewise.
 811         (asm_language_data): Likewise.
 812         (minimal_language_data): Likewise.
 813         * c-lang.h (c_watch_location_expression): Delete declaration.
 814         * d-lang.c (d_language_data): Delete la_watch_location_expression
 815         initializer.
 816         * f-lang.c (f_language_data): Likewise.
 817         * go-lang.c (go_language_data): Likewise.
 818         * language.c (language_defn::watch_location_expression): Member
 819         function implementation from c_watch_location_expression.
 820         (unknown_language_data): Delete la_watch_location_expression
 821         initializer.
 822         (auto_language_data): Likewise.
 823         * language.h (language_data): Delete la_watch_location_expression
 824         field.
 825         (language_defn::watch_location_expression): Declare new member
 826         function.
 827         * m2-lang.c (m2_language_data): Delete
 828         la_watch_location_expression initializer.
 829         * objc-lang.c (objc_language_data): Likewise.
 830         * opencl-lang.c (opencl_language_data): Likewise.
 831         * p-lang.c (pascal_language_data): Likewise.
 832         * rust-lang.c (rust_watch_location_expression): Rename to
 833         rust_language::watch_location_expression.
 834         (rust_language_data): Delete la_watch_location_expression
 835         initializer.
 836         (rust_language::watch_location_expression): New member function,
 837         implementation from rust_watch_location_expression.
 838
 839 2020-06-17  Andrew Burgess  <andrew.burgess@embecosm.com>
 840
 841         * ada-lang.c (ada_collect_symbol_completion_matches): Rename to
 842         ada_language::collect_symbol_completion_matches.
 843         (ada_language_data): Delete la_collect_symbol_completion_matches
 844         initializer.
 845         (ada_language::collect_symbol_completion_matches): New member
 846         function, implementation from
 847         ada_collect_symbol_completion_matches.
 848         * c-lang.c (c_language_data): Delete
 849         la_collect_symbol_completion_matches initializer.
 850         (cplus_language_data): Likewise.
 851         (asm_language_data): Likewise.
 852         (minimal_language_data): Likewise.
 853         * d-lang.c (d_language_data): Likewise.
 854         * f-lang.c (f_collect_symbol_completion_matches): Rename to
 855         f_language::collect_symbol_completion_matches.
 856         (f_language_data): Delete la_collect_symbol_completion_matches
 857         initializer.
 858         (f_language::collect_symbol_completion_matches) New member
 859         function, implementation from f_collect_symbol_completion_matches.
 860         * go-lang.c (go_language_data): Delete
 861         la_collect_symbol_completion_matches initializer.
 862         * language.c (unknown_language_data): Likewise.
 863         (auto_language_data): Likewise.
 864         * language.h (language_data): Delete
 865         la_collect_symbol_completion_matches field.
 866         (language_defn::collect_symbol_completion_matches): New member
 867         function.
 868         * m2-lang.c (m2_language_data): Delete
 869         la_collect_symbol_completion_matches initializer.
 870         * objc-lang.c (objc_language_data): Likewise.
 871         * opencl-lang.c (opencl_language_data): Likewise.
 872         * p-lang.c (pascal_language_data): Likewise.
 873         * rust-lang.c (rust_language_data): Likewise.
 874         * symtab.c (default_collect_symbol_completion_matches): Delete.
 875         (collect_symbol_completion_matches): Update call to
 876         collect_symbol_completion_matches.
 877         (collect_symbol_completion_matches_type): Likewise.
 878         * symtab.h (default_collect_symbol_completion_matches): Delete
 879         declaration.
 880
 881 2020-06-17  Andrew Burgess  <andrew.burgess@embecosm.com>
 882
 883         * ada-lang.c (ada_get_gdb_completer_word_break_characters): Delete.
 884         (ada_language_data): Delete la_word_break_characters initializer.
 885         (ada_language::word_break_characters): New member function.
 886         * c-lang.c (c_language_data): Delete la_word_break_characters
 887         initializer.
 888         (cplus_language_data): Likewise.
 889         (asm_language_data): Likewise.
 890         (minimal_language_data): Likewise.
 891         * completer.c: Update global comment.
 892         (advance_to_expression_complete_word_point): Update call to
 893         word_break_characters.
 894         (complete_files_symbols): Likewise.
 895         (complete_line_internal_1): Likewise.
 896         (default_completer_handle_brkchars): Likewise.
 897         (skip_quoted_chars): Likewise.
 898         * d-lang.c (d_language_data): Delete la_word_break_characters
 899         initializer.
 900         * f-lang.c (f_word_break_characters): Delete.
 901         (f_language_data): Delete la_word_break_characters initializer.
 902         (f_language::word_break_characters): New member function.
 903         * go-lang.c (go_language_data): Delete la_word_break_characters
 904         initializer.
 905         * language.c (unknown_language_data): Likewise.
 906         (auto_language_data): Likewise.
 907         * language.h (default_word_break_characters): Move declaration to
 908         earlier in the file.
 909         (language_data): Delete la_word_break_characters field.
 910         (language_defn::word_break_characters): New member function.
 911         * m2-lang.c (m2_language_data): Delete la_word_break_characters
 912         initializer.
 913         * objc-lang.c (objc_language_data): Likewise.
 914         * opencl-lang.c (opencl_language_data): Likewise.
 915         * p-lang.c (pascal_language_data): Likewise.
 916         * rust-lang.c (rust_language_data): Likewise.
 917
 918 2020-06-17  Andrew Burgess  <andrew.burgess@embecosm.com>
 919
 920         * ada-lang.c (ada_get_symbol_name_matcher): Update header comment.
 921         (ada_language_data): Delete la_get_symbol_name_matcher
 922         initializer.
 923         (language_defn::get_symbol_name_matcher_inner): New member
 924         function.
 925         * c-lang.c (c_language_data): Delete la_get_symbol_name_matcher
 926         initializer.
 927         (cplus_language_data): Likewise.
 928         (cplus_language::get_symbol_name_matcher_inner): New member
 929         function.
 930         (asm_language_data): Delete la_get_symbol_name_matcher initializer.
 931         (minimal_language_data): Likewise.
 932         * cp-support.h (cp_get_symbol_name_matcher): Update header comment.
 933         * d-lang.c (d_language_data): Delete la_get_symbol_name_matcher
 934         initializer.
 935         * dictionary.c (iter_match_first_hashed): Update call to
 936         get_symbol_name_matcher.
 937         (iter_match_next_hashed): Likewise.
 938         (iter_match_next_linear): Likewise.
 939         * dwarf2/read.c (dw2_expand_symtabs_matching_symbol): Likewise.
 940         * f-lang.c (f_language_data): Delete la_get_symbol_name_matcher
 941         initializer.
 942         (f_language::get_symbol_name_matcher_inner): New member function.
 943         * go-lang.c (go_language_data): Delete la_get_symbol_name_matcher
 944         initializer.
 945         * language.c (default_symbol_name_matcher): Update header comment,
 946         make static.
 947         (language_defn::get_symbol_name_matcher): New definition.
 948         (language_defn::get_symbol_name_matcher_inner): Likewise.
 949         (get_symbol_name_matcher): Delete.
 950         (unknown_language_data): Delete la_get_symbol_name_matcher
 951         initializer.
 952         (auto_language_data): Likewise.
 953         * language.h (language_data): Delete la_get_symbol_name_matcher
 954         field.
 955         (language_defn::get_symbol_name_matcher): New member function.
 956         (language_defn::get_symbol_name_matcher_inner): Likewise.
 957         (default_symbol_name_matcher): Delete declaration.
 958         * linespec.c (find_methods): Update call to
 959         get_symbol_name_matcher.
 960         * m2-lang.c (m2_language_data): Delete la_get_symbol_name_matcher
 961         initializer.
 962         * minsyms.c (lookup_minimal_symbol): Update call to
 963         get_symbol_name_matcher.
 964         (iterate_over_minimal_symbols): Likewise.
 965         * objc-lang.c (objc_language_data): Delete
 966         la_get_symbol_name_matcher initializer.
 967         * opencl-lang.c (opencl_language_data): Likewise.
 968         * p-lang.c (pascal_language_data): Likewise.
 969         * psymtab.c (psymbol_name_matches): Update call to
 970         get_symbol_name_matcher.
 971         * rust-lang.c (rust_language_data): Delete
 972         la_get_symbol_name_matcher initializer.
 973         * symtab.c (symbol_matches_search_name): Update call to
 974         get_symbol_name_matcher.
 975         (compare_symbol_name): Likewise.
 976
 977 2020-06-17  Andrew Burgess  <andrew.burgess@embecosm.com>
 978
 979         * ada-lang.c (ada_language_data): Delete la_compute_program
 980         initializer.
 981         * c-lang.c (c_language_data): Likewise.
 982         (c_language::compute_program): New member function.
 983         (cplus_language_data): Delete la_compute_program initializer.
 984         (cplus_language::compute_program): New member function.
 985         (asm_language_data): Delete la_compute_program initializer.
 986         (minimal_language_data): Likewise.
 987         * c-lang.h (c_compute_program): Update comment.
 988         (cplus_compute_program): Likewise.
 989         * compile/compile-c-support.c (c_compute_program): Likewise.
 990         (cplus_compute_program): Likewise.
 991         * compile/compile.c (compile_to_object): Update call to
 992         la_compute_program.
 993         * d-lang.c (d_language_data): Delete la_compute_program
 994         initializer.
 995         * f-lang.c (f_language_data): Likewise.
 996         * go-lang.c (go_language_data): Likewise.
 997         * language.c (unknown_language_data): Likewise.
 998         (auto_language_data): Likewise.
 999         * language.h (language_data): Delete la_compute_program field.
1000         (language_defn::compute_program): New member function.
1001         * m2-lang.c (m2_language_data): Delete la_compute_program
1002         initializer.
1003         * objc-lang.c (objc_language_data): Likewise.
1004         * opencl-lang.c (opencl_language_data): Likewise.
1005         * p-lang.c (pascal_language_data): Likewise.
1006         * rust-lang.c (rust_language_data): Likewise.
1007
1008 2020-06-17  Andrew Burgess  <andrew.burgess@embecosm.com>
1009
1010         * ada-lang.c (ada_language_data) Delete
1011         la_class_name_from_physname initializer.
1012         * c-lang.c (c_language_data): Likewise.
1013         (cplus_language_data): Likewise.
1014         (cplus_language::class_name_from_physname): New member function.
1015         (asm_language_data): Delete la_class_name_from_physname
1016         initializer.
1017         (minimal_language_data): Likewise.
1018         * d-lang.c (d_language_data): Likewise.
1019         * dwarf2/read.c (guess_partial_die_structure_name): Update to call
1020         method on language_defn class.
1021         (guess_full_die_structure_name): Likewise.
1022         * f-lang.c (f_language_data): Delete la_class_name_from_physname
1023         initializer.
1024         * go-lang.c (go_language_data): Likewise.
1025         * language.c (language_class_name_from_physname): Delete.
1026         (unk_lang_class_name): Delete.
1027         (unknown_language_data): Delete la_class_name_from_physname
1028         initializer.
1029         (auto_language_data): Likewise.
1030         * language.h (language_data): Delete la_class_name_from_physname
1031         field.
1032         (language_defn::class_name_from_physname): New function.
1033         (language_class_name_from_physname): Delete declaration.
1034         * m2-lang.c (m2_language_data): Delete la_class_name_from_physname
1035         initializer.
1036         * objc-lang.c (objc_language_data): Likewise.
1037         * opencl-lang.c (opencl_language_data): Likewise.
1038         * p-lang.c (pascal_language_data): Likewise.
1039         * rust-lang.c (rust_language_data): Likewise.
1040
1041 2020-06-16  Tom Tromey  <tom@tromey.com>
1042
1043         * tui/tui-data.h (STATUS_NAME): New macro.
1044         * tui/tui-layout.c (tui_remove_some_windows)
1045         (initialize_known_windows, tui_register_window)
1046         (tui_layout_split::remove_windows, initialize_layouts)
1047         (tui_new_layout_command): Don't use hard-coded window names.
1048
1049 2020-06-16  Tom Tromey  <tom@tromey.com>
1050
1051         PR tui/25348:
1052         * tui/tui.c (tui_ensure_readline_initialized): Rename from
1053         tui_initialize_readline.  Only run once.  Call rl_initialize.
1054         * tui/tui.h (tui_ensure_readline_initialized): Rename from
1055         tui_initialize_readline.
1056         * tui/tui-io.c (tui_setup_io): Call
1057         tui_ensure_readline_initialized.
1058         * tui/tui-interp.c (tui_interp::init): Update.
1059
1060 2020-06-16  Tom Tromey  <tom@tromey.com>
1061
1062         * tui/tui-layout.c (tui_layout_split::remove_windows): Fix logic.
1063         Also preserve the status window.
1064
1065 2020-06-16  Tom Tromey  <tom@tromey.com>
1066
1067         * python/py-tui.c (tui_py_window::~tui_py_window): Handle case
1068         where m_window==nullptr.
1069
1070 2020-06-15  Tom Tromey  <tromey@adacore.com>
1071
1072         * windows-nat.c (windows_nat::handle_output_debug_string):
1073         Update.
1074         (windows_nat::handle_ms_vc_exception): Update.
1075         * target.h (target_read_string): Change API.
1076         * target.c (target_read_string): Change API.
1077         * solib-svr4.c (open_symbol_file_object, svr4_read_so_list):
1078         Update.
1079         * solib-frv.c (frv_current_sos): Update.
1080         * solib-dsbt.c (dsbt_current_sos): Update.
1081         * solib-darwin.c (darwin_current_sos): Update.
1082         * linux-thread-db.c (inferior_has_bug): Update.
1083         * expprint.c (print_subexp_standard): Update.
1084         * ada-lang.c (ada_main_name, ada_tag_name_from_tsd)
1085         (ada_exception_message_1): Update.
1086
1087 2020-06-15  Tom Tromey  <tromey@adacore.com>
1088
1089         * linux-tdep.c (dump_mapping_p): Use target_read_memory.
1090
1091 2020-06-15  Tom Tromey  <tromey@adacore.com>
1092
1093         * valprint.c (read_string): Update comment.
1094         * target.c (MIN): Remove.
1095         (target_read_string): Rewrite.
1096
1097 2020-06-15  Tom Tromey  <tromey@adacore.com>
1098
1099         * corefile.c (read_memory_string): Remove.
1100         * ada-valprint.c (ada_value_print_ptr): Update.
1101         * ada-lang.h (ada_tag_name): Change return type.
1102         * ada-lang.c (type_from_tag): Update.
1103         (ada_tag_name_from_tsd): Change return type.  Use
1104         target_read_string.
1105         (ada_tag_name): Likewise.
1106         * gdbcore.h (read_memory_string): Don't declare.
1107
1108 2020-06-14  Hannes Domani  <ssbssa@yahoo.de>
1109
1110         * symtab.c (rbreak_command): Ignore Windows drive colon.
1111
1112 2020-06-12  Simon Marchi  <simon.marchi@efficios.com>
1113
1114         * NEWS: Mention removed GDBserver host support.
1115
1116 2020-06-12  Nelson Chu  <nelson.chu@sifive.com>
1117
1118         * features/riscv/rebuild-csr-xml.sh: Updated.
1119
1120 2020-06-11  Tom Tromey  <tom@tromey.com>
1121
1122         PR gdb/18318:
1123         * c-exp.y (lex_one_token): Handle 'p' like 'e'.
1124
1125 2020-06-09  Jonny Grant  <jg@jguk.org>
1126 2020-06-09  Simon Marchi  <simon.marchi@polymtl.ca>
1127
1128         * main.c (captured_main_1): Don't print new line after help.
1129         (print_gdb_help): add mailing list and IRC channel information
1130         to --help.  Add new lines between items in the footer.  Remove
1131         quotes around bug url.
1132
1133 2020-06-11  Keith Seitz  <keiths@redhat.com>
1134
1135         PR gdb/21356
1136         * gdbtypes.c (resolve_dynamic_union, resolve_dynamic_struct):
1137         Resolve typedefs for type length calculations.
1138
1139 2020-06-10  Tom de Vries  <tdevries@suse.de>
1140
1141         PR ada/24713
1142         * dwarf2/index-write.c (struct mapped_symtab): Add m_string_obstack.
1143         (write_psymbols): Enable .gdb_index for ada.
1144         * dwarf2/read.c: Remove comment stating .gdb_index is unsupported for
1145         ada.
1146
1147 2020-06-10  Tom de Vries  <tdevries@suse.de>
1148
1149         * dwarf2/read.c (dw2_symtab_iter_init_common): Factor out of ...
1150         (dw2_symtab_iter_init): ... here.  Add variant with "offset_type
1151         namei" instead of "const char *name" argument.
1152         (dw2_map_matching_symbols): Use "offset_type namei" variant of
1153         dw2_symtab_iter_init.
1154
1155 2020-06-08  Simon Marchi  <simon.marchi@efficios.com>
1156
1157         * gdbtypes.h (TYPE_FIELD_TYPE): Remove.  Change all call sites
1158         to use type::field and field::type instead.
1159
1160 2020-06-08  Simon Marchi  <simon.marchi@efficios.com>
1161
1162         * gdbtypes.h (FIELD_TYPE): Remove.  Change all call sites
1163         to use field::type instead.
1164
1165 2020-06-08  Simon Marchi  <simon.marchi@efficios.com>
1166
1167         * gdbtypes.h (struct field) <type, set_type>: New methods.
1168         Rename `type` field to...
1169         <m_type>: ... this.  Change references throughout to use type or
1170         set_type methods.
1171         (FIELD_TYPE): Use field::type.  Change call sites that modify
1172         the field's type to use field::set_type instead.
1173
1174 2020-06-08  Simon Marchi  <simon.marchi@efficios.com>
1175
1176         * gdbtypes.h (TYPE_INDEX_TYPE): Remove.  Change all call sites
1177         to use type::index_type instead.
1178
1179 2020-06-08  Simon Marchi  <simon.marchi@efficios.com>
1180
1181         * gdbtypes.h (struct type) <index_type, set_index_type>: New
1182         methods.
1183         (TYPE_INDEX_TYPE): Use type::index_type.
1184         * gdbtypes.c (create_array_type_with_stride): Likewise.
1185
1186 2020-06-07  Tom Tromey  <tom@tromey.com>
1187
1188         * valprint.c (generic_val_print_float): Remove "embedded_offset"
1189         parameter.
1190         (generic_value_print): Update.
1191
1192 2020-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
1193
1194         Revert commit 982a38f60b0.
1195         * python/py-tui.c (gdbpy_tui_set_title): Restore use of get.
1196
1197 2020-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
1198
1199         * python/py-tui.c (gdbpy_tui_set_title): Use release, not get, to
1200         avoid use after free.
1201
1202 2020-06-05  Tom de Vries  <tdevries@suse.de>
1203
1204         * NEWS: Fix typos.
1205
1206 2020-06-04  Simon Marchi  <simon.marchi@efficios.com>
1207
1208         * dwarf2/read.c (dwarf2_read_gdb_index): Save partial_symtabs in
1209         the per_bfd object.
1210         (dwarf2_read_debug_names): Likewise.
1211         (dwarf2_initialize_objfile): Use partial_symtabs from per_bfd
1212         object when re-using a per_bfd object with an index.
1213
1214 2020-06-03  Tom de Vries  <tdevries@suse.de>
1215
1216         PR symtab/26046
1217         * dwarf2/read.c (scan_partial_symbols): Recurse into DW_TAG_subprogram
1218         children for C++.
1219         (load_partial_dies): Don't skip DW_TAG_inlined_subroutine child of
1220         DW_TAG_subprogram.
1221
1222 2020-06-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1223
1224         * ada-lang.c (ada_language_data): Delete skip_trampoline
1225         initializer.
1226         * c-lang.c (c_language_data): Likewise.
1227         (cplus_language_data): Likewise.
1228         (cplus_language::skip_trampoline): New member function.
1229         (asm_language_data): Delete skip_trampoline initializer.
1230         (minimal_language_data): Likewise.
1231         * d-lang.c (d_language_data): Likewise.
1232         * f-lang.c (f_language_data): Likewise.
1233         * go-lang.c (go_language_data): Likewise.
1234         * language.c (unk_lang_trampoline): Delete function.
1235         (skip_language_trampoline): Update.
1236         (unknown_language_data): Delete skip_trampoline initializer.
1237         (auto_language_data): Likewise.
1238         * language.h (language_data): Delete skip_trampoline field.
1239         (language_defn::skip_trampoline): New function.
1240         * m2-lang.c (m2_language_data): Delete skip_trampoline
1241         initializer.
1242         * objc-lang.c (objc_skip_trampoline): Delete function, move
1243         implementation to objc_language::skip_trampoline.
1244         (objc_language_data): Delete skip_trampoline initializer.
1245         (objc_language::skip_trampoline): New member function with
1246         implementation from objc_skip_trampoline.
1247         * opencl-lang.c (opencl_language_data): Delete skip_trampoline
1248         initializer.
1249         * p-lang.c (pascal_language_data): Likewise.
1250         * rust-lang.c (rust_language_data): Likewise.
1251
1252 2020-06-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1253
1254         * ada-lang.c (ada_language_data): Delete la_demangle initializer.
1255         (ada_language::demangle): New member function.
1256         * c-lang.c (c_language_data): Delete la_demangle initializer.
1257         (cplus_language_data): Delete la_demangle initializer.
1258         (cplus_language::demangle): New member function.
1259         (asm_language_data): Delete la_demangle initializer.
1260         (minimal_language_data): Delete la_demangle initializer.
1261         * d-lang.c (d_language_data): Delete la_demangle initializer.
1262         (d_language::demangle): New member function.
1263         * f-lang.c (f_language_data): Delete la_demangle initializer.
1264         (f_language::demangle): New member function.
1265         * go-lang.c (go_language_data): Delete la_demangle initializer.
1266         (go_language::demangle): New member function.
1267         * language.c (language_demangle): Update.
1268         (unk_lang_demangle): Delete.
1269         (unknown_language_data): Delete la_demangle initializer.
1270         (unknown_language::demangle): New member function.
1271         (auto_language_data): Delete la_demangle initializer.
1272         (auto_language::demangle): New member function.
1273         * language.h (language_data): Delete la_demangle field.
1274         (language_defn::demangle): New function.
1275         * m2-lang.c (m2_language_data): Delete la_demangle initializer.
1276         * objc-lang.c (objc_language_data): Delete la_demangle
1277         initializer.
1278         (objc_language::demangle): New member function.
1279         * opencl-lang.c (opencl_language_data): Delete la_demangle
1280         initializer.
1281         * p-lang.c (pascal_language_data): Likewise.
1282         * rust-lang.c (rust_language_data): Likewise.
1283         (rust_language::demangle): New member function.
1284
1285 2020-06-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1286
1287         * ada-lang.c (ada_language_data): Delete la_print_type
1288         initializer.
1289         (ada_language::print_type): New member function.
1290         * c-lang.c (c_language_data): Delete la_print_type initializer.
1291         (c_language::print_type): New member function.
1292         (cplus_language_data): Delete la_print_type initializer.
1293         (cplus_language::print_type): New member function.
1294         (asm_language_data): Delete la_print_type initializer.
1295         (asm_language::print_type): New member function.
1296         (minimal_language_data): Delete la_print_type initializer.
1297         (minimal_language::print_type): New member function.
1298         * d-lang.c (d_language_data): Delete la_print_type initializer.
1299         (d_language::print_type): New member function.
1300         * f-lang.c (f_language_data): Delete la_print_type initializer.
1301         (f_language::print_type): New member function.
1302         * go-lang.c (go_language_data): Delete la_print_type initializer.
1303         (go_language::print_type): New member function.
1304         * language.c (unk_lang_print_type): Delete.
1305         (unknown_language_data): Delete la_print_type initializer.
1306         (unknown_language::print_type): New member function.
1307         (auto_language_data): Delete la_print_type initializer.
1308         (auto_language::print_type): New member function.
1309         * language.h (language_data): Delete la_print_type field.
1310         (language_defn::print_type): New function.
1311         (LA_PRINT_TYPE): Update.
1312         * m2-lang.c (m2_language_data): Delete la_print_type initializer.
1313         (m2_language::print_type): New member function.
1314         * objc-lang.c (objc_language_data): Delete la_print_type
1315         initializer.
1316         (objc_language::print_type): New member function.
1317         * opencl-lang.c (opencl_print_type): Delete, implementation moved
1318         to opencl_language::print_type.
1319         (opencl_language_data): Delete la_print_type initializer.
1320         (opencl_language::print_type): New member function, implementation
1321         from opencl_print_type.
1322         * p-lang.c (pascal_language_data): Delete la_print_type
1323         initializer.
1324         (pascal_language::print_type): New member function.
1325         * rust-lang.c (rust_print_type): Delete, implementation moved to
1326         rust_language::print_type.
1327         (rust_language_data): Delete la_print_type initializer.
1328         (rust_language::print_type): New member function, implementation
1329         from rust_print_type.
1330
1331 2020-06-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1332
1333         * ada-lang.c (ada_sniff_from_mangled_name): Delete function,
1334         implementation moves to...
1335         (ada_language::sniff_from_mangled_name): ...here.  Update return
1336         type.
1337         (ada_language_data): Delete la_sniff_from_mangled_name
1338         initializer.
1339         * c-lang.c (c_language_data): Likewise.
1340         (cplus_language_data): Likewise.
1341         (cplus_language::sniff_from_mangled_name): New member function,
1342         implementation taken from gdb_sniff_from_mangled_name.
1343         (asm_language_data): Delete la_sniff_from_mangled_name
1344         initializer.
1345         (minimal_language_data): Likewise.
1346         * cp-support.c (gdb_sniff_from_mangled_name): Delete,
1347         implementation moves to cplus_language::sniff_from_mangled_name.
1348         * cp-support.h (gdb_sniff_from_mangled_name): Delete declaration.
1349         * d-lang.c (d_sniff_from_mangled_name): Delete, implementation
1350         moves to...
1351         (d_language::sniff_from_mangled_name): ...here.
1352         (d_language_data): Delete la_sniff_from_mangled_name initializer.
1353         * f-lang.c (f_language_data): Likewise.
1354         * go-lang.c (go_sniff_from_mangled_name): Delete, implementation
1355         moves to...
1356         (go_language::sniff_from_mangled_name): ...here.
1357         (go_language_data): Delete la_sniff_from_mangled_name initializer.
1358         * language.c (language_sniff_from_mangled_name): Delete.
1359         (unknown_language_data): Delete la_sniff_from_mangled_name
1360         initializer.
1361         (auto_language_data): Likewise.
1362         * language.h (language_data): Delete la_sniff_from_mangled_name
1363         field.
1364         (language_defn::sniff_from_mangled_name): New function.
1365         (language_sniff_from_mangled_name): Delete declaration.
1366         * m2-lang.c (m2_language_data): Delete la_sniff_from_mangled_name
1367         field.
1368         * objc-lang.c (objc_sniff_from_mangled_name): Delete,
1369         implementation moves to...
1370         (objc_language::sniff_from_mangled_name): ...here.
1371         (objc_language_data): Delete la_sniff_from_mangled_name initializer.
1372         * opencl-lang.c (opencl_language_data): Likewise.
1373         * p-lang.c (pascal_language_data): Likewise.
1374         * rust-lang.c (rust_sniff_from_mangled_name): Delete,
1375         implementation moves to...
1376         (rust_language::sniff_from_mangled_name): ...here.
1377         (rust_language_data): Delete la_sniff_from_mangled_name
1378         initializer.
1379         * symtab.c (symbol_find_demangled_name): Call
1380         sniff_from_mangled_name member function.
1381
1382 2020-06-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1383
1384         * ada-lang.c (ada_language_data): Delete la_search_name_hash
1385         initializer.
1386         * c-lang.c (c_language_data): Likewise.
1387         (cplus_language_data): Likewise.
1388         (cplus_language::search_name_hash): New member function.
1389         (asm_language_data): Delete la_search_name_hash initializer.
1390         (minimal_language_data): Likewise.
1391         * d-lang.c (d_language_data): Likewise.
1392         * dictionary.c (default_search_name_hash): Rename to...
1393         (language_defn::search_name_hash): ...this.
1394         * f-lang.c (f_language_data): Likewise.
1395         (f_language::search_name_hash): New member function.
1396         * go-lang.c (go_language_data): Delete la_search_name_hash
1397         initializer.
1398         * language.c (unknown_language_data): Likewise.
1399         (auto_language_data): Likewise.
1400         * language.h (struct language_data): Delete la_search_name_hash
1401         field.
1402         (language_defn::search_name_hash): Declare new member function.
1403         (default_search_name_hash): Delete declaration.
1404         * m2-lang.c (m2_language_data): Delete la_search_name_hash
1405         initializer.
1406         * objc-lang.c (objc_language_data): Likewise.
1407         * opencl-lang.c (opencl_language_data): Likewise.
1408         * p-lang.c (pascal_language_data): Likewise.
1409         * rust-lang.c (rust_language_data): Likewise.
1410         * symtab.c (search_name_hash): Update call.
1411
1412 2020-06-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1413
1414         * ada-lang.c (ada_language_data): Delete la_get_compile_instance
1415         initializer.
1416         * c-lang.c (class compile_instance): Declare.
1417         (c_language_data): Delete la_get_compile_instance initializer.
1418         (c_language::get_compile_instance): New member function.
1419         (cplus_language_data): Delete la_get_compile_instance initializer.
1420         (cplus_language::get_compile_instance): New member function.
1421         (asm_language_data): Delete la_get_compile_instance initializer.
1422         (minimal_language_data): Likewise.
1423         * c-lang.h (c_get_compile_context): Update comment.
1424         (cplus_get_compile_context): Update comment.
1425         * compile/compile.c (compile_to_object): Update calls, don't rely
1426         on function pointer being NULL.
1427         * d-lang.c (d_language_data): Delete la_get_compile_instance
1428         initializer.
1429         * f-lang.c (f_language_data): Likewise.
1430         * go-lang.c (go_language_data): Likewise.
1431         * language.c (unknown_language_data): Likewise.
1432         (auto_language_data): Likewise.
1433         * language.h (language_data): Delete la_get_compile_instance field.
1434         (language_defn::get_compile_instance): New member function.
1435         * m2-lang.c (m2_language_data): Delete la_get_compile_instance
1436         initializer.
1437         * objc-lang.c (objc_language_data): Likewise.
1438         * opencl-lang.c (opencl_language_data): Likewise.
1439         * p-lang.c (pascal_language_data): Likewise.
1440         * rust-lang.c (rust_language_data): Likewise.
1441
1442 2020-06-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1443
1444         * ada-lang.c (ada_add_all_symbols): Update comment.
1445         (ada_iterate_over_symbols): Delete, move implementation to...
1446         (ada_language::iterate_over_symbols): ...here, a new member
1447         function, rewrite to use range based for loop.
1448         (ada_language_data): Delete la_iterate_over_symbols initializer.
1449         * c-lang.c (c_language_data): Likewise.
1450         (cplus_language_data): Likewise.
1451         (asm_language_data): Likewise.
1452         (minimal_language_data): Likewise.
1453         * d-lang.c (d_language_data): Likewise.
1454         * f-lang.c (f_language_data): Likewise.
1455         * go-lang.c (go_language_data): Likewise.
1456         * language.c (unknown_language_data): Likewise.
1457         (auto_language_data): Likewise.
1458         * language.h (language_data): Delete la_iterate_over_symbols field.
1459         (language_defn::iterate_over_symbols): New member function.
1460         (LA_ITERATE_OVER_SYMBOLS): Update.
1461         * linespec.c (iterate_over_all_matching_symtabs): Update.
1462         * m2-lang.c (m2_language_data): Delete la_iterate_over_symbols
1463         initializer.
1464         * objc-lang.c (objc_language_data): Likewise.
1465         * opencl-lang.c (opencl_language_data): Likewise.
1466         * p-lang.c (pascal_language_data): Likewise.
1467         * rust-lang.c (rust_language_data): Likewise.
1468
1469 2020-06-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1470
1471         * ada-lang.c (ada_language_data): Delete
1472         la_lookup_transparent_type initializer.
1473         * c-lang.c (c_language_data): Likewise.
1474         (cplus_language_data): Likewise.
1475         (cplus_language::lookup_transparent_type): New member function.
1476         (asm_language_data): Delete la_lookup_transparent_type
1477         initializer.
1478         (minimal_language_data): Likewise.
1479         * d-lang.c (d_language_data): Likewise.
1480         * f-lang.c (f_language_data): Likewise.
1481         * go-lang.c (go_language_data): Likewise.
1482         * language.c (unknown_language_data): Likewise.
1483         (auto_language_data): Likewise.
1484         * language.h (struct language_data): Delete
1485         la_lookup_transparent_type field.
1486         (language_defn::lookup_transparent_type): New member function.
1487         * m2-lang.c (m2_language_data): Delete la_lookup_transparent_type
1488         initializer.
1489         * objc-lang.c (objc_language_data): Likewise.
1490         * opencl-lang.c (opencl_language_data): Likewise.
1491         * p-lang.c (pascal_language_data): Likewise.
1492         * rust-lang.c (rust_language_data): Likewise.
1493         * symtab.c (symbol_matches_domain): Update call.
1494
1495 2020-06-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1496
1497         * ada-lang.c (ada_language_arch_info): Delete function, move
1498         implementation to...
1499         (ada_language::language_arch_info): ...here, a new member
1500         function.
1501         (ada_language_data): Delete la_language_arch_info.
1502         * c-lang.c (c_language_data): Likewise.
1503         (c_language::language_arch_info): New member function.
1504         (cplus_language_arch_info): Delete function, move
1505         implementation to...
1506         (cplus_language::language_arch_info): ...here, a new member
1507         function.
1508         (cplus_language_data): Delete la_language_arch_info.
1509         (asm_language_data): Likewise.
1510         (asm_language::language_arch_info): New member function.
1511         (minimal_language_data): Delete la_language_arch_info.
1512         (minimal_language::language_arch_info): New member function.
1513         * d-lang.c (d_language_arch_info): Delete function, move
1514         implementation to...
1515         (d_language::language_arch_info): ...here, a new member
1516         function.
1517         (d_language_data): Delete la_language_arch_info.
1518         * f-lang.c (f_language_arch_info): Delete function, move
1519         implementation to...
1520         (f_language::language_arch_info): ...here, a new member
1521         function.
1522         (f_language_data): Delete la_language_arch_info.
1523         * go-lang.c (go_language_arch_info): Delete function, move
1524         implementation to...
1525         (go_language::language_arch_info): ...here, a new member
1526         function.
1527         (go_language_data): Delete la_language_arch_info.
1528         * language.c (unknown_language_data): Likewise.
1529         (unknown_language::language_arch_info): New member function.
1530         (auto_language_data): Delete la_language_arch_info.
1531         (auto_language::language_arch_info): New member function.
1532         (language_gdbarch_post_init): Update call to
1533         la_language_arch_info.
1534         * language.h (language_data): Delete la_language_arch_info
1535         function pointer.
1536         (language_defn::language_arch_info): New function.
1537         * m2-lang.c (m2_language_arch_info): Delete function, move
1538         implementation to...
1539         (m2_language::language_arch_info): ...here, a new member
1540         function.
1541         (m2_language_data): Delete la_language_arch_info.
1542         * objc-lang.c (objc_language_arch_info): Delete function, move
1543         implementation to...
1544         (objc_language::language_arch_info): ...here, a new member
1545         function.
1546         (objc_language_data): Delete la_language_arch_info.
1547         * opencl-lang.c (opencl_language_arch_info): Delete function, move
1548         implementation to...
1549         (opencl_language::language_arch_info): ...here, a new member
1550         function.
1551         (opencl_language_data): Delete la_language_arch_info.
1552         * p-lang.c (pascal_language_arch_info): Delete function, move
1553         implementation to...
1554         (pascal_language::language_arch_info): ...here, a new member
1555         function.
1556         (pascal_language_data): Delete la_language_arch_info.
1557         * rust-lang.c (rust_language_arch_info): Delete function, move
1558         implementation to...
1559         (rust_language::language_arch_info): ...here, a new member
1560         function.
1561         (rust_language_data): Delete la_language_arch_info.
1562
1563 2020-06-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1564
1565         * ada-lang.c (ada_language_data): Delete la_pass_by_reference
1566         initializer.
1567         * c-lang.c (c_language_data): Likewise.
1568         (cplus_language_data): Likewise.
1569         (cplus_language::pass_by_reference_info): New method.
1570         (asm_language_data): Delete la_pass_by_reference initializer.
1571         (minimal_language_data): Likewise.
1572         * cp-abi.c (cp_pass_by_reference): Remove use of
1573         default_pass_by_reference.
1574         * d-lang.c (d_language_data): Likewise.
1575         * f-lang.c (f_language_data): Likewise.
1576         * gnu-v3-abi.c (gnuv3_pass_by_reference): Remove use of
1577         default_pass_by_reference.
1578         * go-lang.c (go_language_data): Likewise.
1579         * language.c (language_pass_by_reference): Update.
1580         (default_pass_by_reference): Delete.
1581         (unknown_language_data): Delete la_pass_by_reference
1582         initializer.
1583         (auto_language_data): Likewise.
1584         * language.h (struct language_data): Delete la_pass_by_reference
1585         field.
1586         (language_defn::pass_by_reference_info): New member function.
1587         (default_pass_by_reference): Delete declaration.
1588         * m2-lang.c (m2_language_data): Delete la_pass_by_reference
1589         initializer.
1590         * objc-lang.c (objc_language_data): Likewise.
1591         * opencl-lang.c (opencl_language_data): Likewise.
1592         * p-lang.c (pascal_language_data): Likewise.
1593         * rust-lang.c (rust_language_data): Likewise.
1594
1595 2020-06-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1596
1597         * ada-lang.c (ada_read_var_value): Delete function, move
1598         implementation to...
1599         (ada_language::read_var_value): ...here.
1600         (ada_language_data): Delete la_read_var_value initializer.
1601         * c-lang.c (c_language_data): Likewise.
1602         (cplus_language_data): Likewise.
1603         (minimal_language_data): Likewise.
1604         * d-lang.c (d_language_data): Likewise.
1605         * f-lang.c (f_language_data): Likewise.
1606         * findvar.c (default_read_var_value): Rename to...
1607         (language_defn::read_var_value): ...this.
1608         * findvar.c (read_var_value): Update header comment, and change to
1609         call member function instead of function pointer.
1610         * go-lang.c (go_language_data): Likewise.
1611         * language.c (unknown_language_data): Delete la_read_var_value
1612         initializer.
1613         (auto_language_data): Likewise.
1614         * language.h (struct language_data): Delete la_read_var_value
1615         field.
1616         (language_defn::read_var_value): New member function.
1617         (default_read_var_value): Delete declaration.
1618         * m2-lang.c (m2_language_data): Delete la_read_var_value
1619         initializer.
1620         * objc-lang.c (objc_language_data): Likewise.
1621         * opencl-lang.c (opencl_language_data): Likewise.
1622         * p-lang.c (pascal_language_data): Likewise.
1623         * rust-lang.c (rust_language_data): Likewise.
1624         * value.h (default_read_var_value): Delete declaration.
1625
1626 2020-06-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1627
1628         * ada-lang.c (ada_print_array_index): Delete function, move
1629         implementation to...
1630         (ada_language::print_array_index): ...here.
1631         (ada_language_data): Delete la_print_array_index initializer.
1632         * c-lang.c (c_language_data): Likewise.
1633         (cplus_language_data): Likewise.
1634         (minimal_language_data): Likewise.
1635         * d-lang.c (d_language_data): Likewise.
1636         * f-lang.c (f_language_data): Likewise.
1637         * go-lang.c (go_language_data): Likewise.
1638         * language.c (default_print_array_index): Delete function, move
1639         implementation to...
1640         (language_defn::print_array_index): ...here.
1641         (unknown_language_data): Delete la_print_array_index initializer.
1642         (auto_language_data): Likewise.
1643         * language.h (struct language_data): Delete la_print_array_index
1644         field.
1645         (language_defn::print_array_index): New member function.
1646         (LA_PRINT_ARRAY_INDEX): Update.
1647         (default_print_array_index): Delete declaration.
1648         * m2-lang.c (m2_language_data): Delete la_print_array_index
1649         initializer.
1650         * objc-lang.c (objc_language_data): Likewise.
1651         * opencl-lang.c (opencl_language_data): Likewise.
1652         * p-lang.c (pascal_language_data): Likewise.
1653         * rust-lang.c (rust_language_data): Likewise.
1654
1655 2020-06-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1656
1657         * gdb/ada-lang.c (ada_language_defn): Convert to...
1658         (ada_language_data): ...this.
1659         (class ada_language): New class.
1660         (ada_language_defn): New static global.
1661         * gdb/c-lang.c (c_language_defn): Convert to...
1662         (c_language_data): ...this.
1663         (class c_language): New class.
1664         (c_language_defn): New static global.
1665         (cplus_language_defn): Convert to...
1666         (cplus_language_data): ...this.
1667         (class cplus_language): New class.
1668         (cplus_language_defn): New static global.
1669         (asm_language_defn): Convert to...
1670         (asm_language_data): ...this.
1671         (class asm_language): New class.
1672         (asm_language_defn): New static global.
1673         (minimal_language_defn): Convert to...
1674         (minimal_language_data): ...this.
1675         (class minimal_language): New class.
1676         (minimal_language_defn): New static global.
1677         * gdb/d-lang.c (d_language_defn): Convert to...
1678         (d_language_data): ...this.
1679         (class d_language): New class.
1680         (d_language_defn): New static global.
1681         * gdb/f-lang.c (f_language_defn): Convert to...
1682         (f_language_data): ...this.
1683         (class f_language): New class.
1684         (f_language_defn): New static global.
1685         * gdb/go-lang.c (go_language_defn): Convert to...
1686         (go_language_data): ...this.
1687         (class go_language): New class.
1688         (go_language_defn): New static global.
1689         * gdb/language.c (unknown_language_defn): Remove declaration.
1690         (current_language): Initialize to nullptr, real initialization is
1691         moved to _initialize_language.
1692         (languages): Delete global.
1693         (language_defn::languages): Define.
1694         (set_language_command): Use language_defn::languages.
1695         (set_language): Likewise.
1696         (range_error): Likewise.
1697         (language_enum): Likewise.
1698         (language_def): Likewise.
1699         (add_set_language_command): Use language_def::languages for the
1700         language list, and language_def to lookup language pointers.
1701         (skip_language_trampoline): Use language_defn::languages.
1702         (unknown_language_defn): Convert to...
1703         (unknown_language_data): ...this.
1704         (class unknown_language): New class.
1705         (unknown_language_defn): New static global.
1706         (auto_language_defn): Convert to...
1707         (auto_language_data): ...this.
1708         (class auto_language): New class.
1709         (auto_language_defn): New static global.
1710         (language_gdbarch_post_init): Use language_defn::languages.
1711         (_initialize_language): Initialize current_language.
1712         * gdb/language.h (struct language_defn): Rename to...
1713         (struct language_data): ...this.
1714         (struct language_defn): New.
1715         (auto_language_defn): Delete.
1716         (unknown_language_defn): Delete.
1717         (minimal_language_defn): Delete.
1718         (ada_language_defn): Delete.
1719         (asm_language_defn): Delete.
1720         (c_language_defn): Delete.
1721         (cplus_language_defn): Delete.
1722         (d_language_defn): Delete.
1723         (f_language_defn): Delete.
1724         (go_language_defn): Delete.
1725         (m2_language_defn): Delete.
1726         (objc_language_defn): Delete.
1727         (opencl_language_defn): Delete.
1728         (pascal_language_defn): Delete.
1729         (rust_language_defn): Delete.
1730         * gdb/m2-lang.c (m2_language_defn): Convert to...
1731         (m2_language_data): ...this.
1732         (class m2_language): New class.
1733         (m2_language_defn): New static global.
1734         * gdb/objc-lang.c (objc_language_defn): Convert to...
1735         (objc_language_data): ...this.
1736         (class objc_language): New class.
1737         (objc_language_defn): New static global.
1738         * gdb/opencl-lang.c (opencl_language_defn): Convert to...
1739         (opencl_language_data): ...this.
1740         (class opencl_language): New class.
1741         (opencl_language_defn): New static global.
1742         * gdb/p-lang.c (pascal_language_defn): Convert to...
1743         (pascal_language_data): ...this.
1744         (class pascal_language): New class.
1745         (pascal_language_defn): New static global.
1746         * gdb/rust-exp.y (rust_lex_tests): Use language_def to find
1747         language pointer, update comment format.
1748         * gdb/rust-lang.c (rust_language_defn): Convert to...
1749         (rust_language_data): ...this.
1750         (class rust_language): New class.
1751         (rust_language_defn): New static global.
1752
1753 2020-06-01  Andrew Burgess  <andrew.burgess@embecosm.com>
1754
1755         * dwarf2/read.c (class lnp_state_machine) <m_last_address>: New
1756         member variable.
1757         <m_stmt_at_address>: New member variable.
1758         (lnp_state_machine::record_line): Don't record some lines, update
1759         tracking of is_stmt at the same address.
1760         (lnp_state_machine::lnp_state_machine): Initialise new member
1761         variables.
1762
1763 2020-06-01  Samuel Thibault  <samuel.thibault@ens-lyon.org>
1764
1765         * config/i386/i386gnu.mn [%_S.o %_U.o] (COMPILE.post): Add
1766         "-include gnu-nat-mig.h".
1767         * gnu-nat-mig.h: New file.
1768         * gnu-nat.c: Include "gnu-nat-mig.h".
1769         (exc_server, msg_reply_server, notify_server,
1770         process_reply_server): Remove declarations.
1771
1772 2020-05-30  Samuel Thibault  <samuel.thibault@ens-lyon.org>
1773
1774         * gnu-nat.h (inf_validate_procs, inf_suspend, inf_set_traced,
1775         steal_exc_port, proc_get_state, inf_clear_wait, inf_cleanup,
1776         inf_startup, inf_update_suspends, inf_set_pid, inf_steal_exc_ports,
1777         inf_validate_procinfo, inf_validate_task_sc, inf_restore_exc_ports,
1778         inf_set_threads_resume_sc, inf_set_threads_resume_sc_for_signal_thread,
1779         inf_resume, inf_set_step_thread, inf_detach, inf_attach, inf_signal,
1780         inf_continue, make_proc, proc_abort, _proc_free, proc_update_sc,
1781         proc_get_exception_port, proc_set_exception_port, _proc_get_exc_port,
1782         proc_steal_exc_port, proc_restore_exc_port, proc_trace): Move functions
1783         to gnu_nat_target class.
1784         * gnu-nat.c: Likewise.
1785         (inf_update_procs, S_proc_wait_reply, set_task_pause_cmd,
1786         set_task_exc_port_cmd, set_signals_cmd, set_thread_pause_cmd,
1787         set_thread_exc_port_cmd): Call inf_validate_procs through gnu_target
1788         object.
1789         (gnu_nat_target::create_inferior, gnu_nat_target::detach): Pass `this'
1790         instead of `gnu_target'.
1791
1792 2020-05-30  Samuel Thibault  <samuel.thibault@ens-lyon.org>
1793
1794         * i386-gnu-tdep.c: Include "gdbcore.h"
1795         (gnu_sigtramp_code, i386_gnu_sc_reg_offset): New arrays.
1796         (GNU_SIGTRAMP_LEN, GNU_SIGTRAMP_TAIL,
1797         I386_GNU_SIGCONTEXT_THREAD_STATE_OFFSET): New macros
1798         (i386_gnu_sigtramp_start, i386_gnu_sigtramp_p,
1799         i386_gnu_sigcontext_addr): New functions
1800         (i386gnu_init_abi): Register i386_gnu_sigtramp_p,
1801         i386_gnu_sigcontext_addr, and i386_gnu_sc_reg_offset in the gdbarch
1802         tdep.
1803
1804 2020-05-30  Samuel Thibault  <samuel.thibault@ens-lyon.org>
1805
1806         * gnu-nat.c (gnu_nat_target::create_inferior): Move push_target call
1807         before fork_inferior call. Avoid calling it if target_is_pushed returns
1808         true.
1809
1810 2020-05-30  Samuel Thibault  <samuel.thibault@ens-lyon.org>
1811
1812         * gnu-nat.h (gnu_target): New variable declaration.
1813         * i386-gnu-nat.c (_initialize_i386gnu_nat): Initialize
1814         gnu_target.
1815         * gnu-nat.c (gnu_target): New variable.
1816         (inf_validate_procs): Pass gnu_target to thread_change_ptid,
1817         add_thread_silent, and add_thread calls.
1818         (gnu_nat_target::create_inferior): Pass gnu_target to
1819         add_thread_silent, thread_change_ptid call.
1820         (gnu_nat_target::detach): Pass gnu_target to detach_inferior
1821         call.
1822
1823 2020-05-30  Samuel Thibault  <samuel.thibault@ens-lyon.org>
1824
1825         * gnu-nat.c (gnu_xfer_auxv): Remove unused `res' variable.
1826         (gnu_nat_target::find_memory_regions): Remove unused
1827         `old_address' variable.
1828
1829 2020-05-30  Samuel Thibault  <samuel.thibault@ens-lyon.org>
1830
1831         * gnu-nat.c: Include "gdbarch.h".
1832
1833 2020-05-30  Samuel Thibault  <samuel.thibault@ens-lyon.org>
1834
1835         * reply_mig_hack.awk (Error return): Cast function through
1836         void *, to bypass compiler function call check.
1837
1838 2020-05-30  Samuel Thibault  <samuel.thibault@ens-lyon.org>
1839
1840         * config/i386/i386gnu.mn (%_reply_S.c): Add dependency on
1841         $(srcdir)/reply_mig_hack.awk.
1842
1843 2020-05-30  Samuel Thibault  <samuel.thibault@ens-lyon.org>
1844
1845         * gnu-nat.h (gnu_debug_flag): Set type to bool.
1846
1847 2020-05-30  Jonny Grant  <jg@jguk.org>
1848
1849         * configure.ac (ACX_BUGURL): change bug URL to https.
1850
1851 2020-05-30  Pedro Alves  <palves@redhat.com>
1852
1853         * cp-support.c (replace_typedefs_template): New.
1854         (replace_typedefs_qualified_name): Handle
1855         DEMANGLE_COMPONENT_TEMPLATE.
1856
1857 2020-05-29  Simon Marchi  <simon.marchi@efficios.com>
1858
1859         * dwarf2/comp-unit.c, dwarf2/comp-unit.h, dwarf2/index-cache.c,
1860         dwarf2/index-cache.h, dwarf2/index-write.c,
1861         dwarf2/index-write.h, dwarf2/line-header.c,
1862         dwarf2/line-header.h, dwarf2/macro.c, dwarf2/macro.h,
1863         dwarf2/read.c, dwarf2/read.h: Rename struct dwarf2_per_objfile
1864         variables and fields from `dwarf2_per_objfile` to just
1865         `per_objfile` throughout.
1866
1867 2020-05-28  Simon Marchi  <simon.marchi@polymtl.ca>
1868
1869         * dwarf2/loc.c (class dwarf_evaluate_loc_desc)
1870         <push_dwarf_reg_entry_value>: Add comment.
1871
1872 2020-05-28  Kevin Buettner  <kevinb@redhat.com>
1873             Keith Seitz  <keiths@redhat.com>
1874
1875         * python/python.c (do_start_initialization): Call PyEval_SaveThread
1876         instead of PyEval_ReleaseLock.
1877         (class gdbpy_gil): Move to earlier in file.
1878         (finalize_python): Set gdb_python_initialized.
1879         (gdbpy_check_quit_flag): Acquire GIL via gdbpy_gil.  Return early
1880         when not initialized.
1881
1882 2020-05-28  Simon Marchi  <simon.marchi@efficios.com>
1883
1884         * dwarf2/loc.c (class dwarf_evaluate_loc_desc)
1885         <push_dwarf_reg_entry_value>: Remove assert.  Override
1886         per_objfile with caller_per_objfile.
1887
1888 2020-05-28  Tom de Vries  <tdevries@suse.de>
1889
1890         * dwarf2/read.c (dw2_symtab_iter_next, dw2_expand_marked_cus): Limit
1891         PR gold/15646 workaround to symbol kind "type".
1892
1893 2020-05-27  Tom Tromey  <tromey@adacore.com>
1894
1895         * dwarf2/read.c (load_partial_dies): Use add_partial_symbol.
1896
1897 2020-05-27  Tom Tromey  <tromey@adacore.com>
1898
1899         * dwarf2/abbrev.h (struct abbrev_table) <lookup_abbrev>: Inline.
1900         Use htab_find_with_hash.
1901         <add_abbrev>: Remove "abbrev_number" parameter.
1902         * dwarf2/abbrev.c (abbrev_table::add_abbrev): Remove
1903         "abbrev_number" parameter.  Use htab_find_slot_with_hash.
1904         (hash_abbrev): Add comment.
1905         (abbrev_table::lookup_abbrev): Move to header file.
1906         (abbrev_table::read): Update.
1907
1908 2020-05-27  Tom Tromey  <tromey@adacore.com>
1909
1910         * dwarf2/read.c (struct partial_die_info) <name>: Declare new
1911         method.
1912         <canonical_name>: New member.
1913         <raw_name>: Rename from "name".
1914         (partial_die_info): Initialize canonical_name.
1915         (scan_partial_symbols): Check raw_name.
1916         (partial_die_parent_scope, partial_die_full_name)
1917         (add_partial_symbol, add_partial_subprogram)
1918         (add_partial_enumeration, load_partial_dies): Use "name" method.
1919         (partial_die_info::name): New method.
1920         (partial_die_info::read, guess_partial_die_structure_name)
1921         (partial_die_info::fixup): Update.
1922
1923 2020-05-27  Tom Tromey  <tromey@adacore.com>
1924
1925         * dwarf2/attribute.h (struct attribute) <form_is_ref>: Inline.
1926         <get_ref_die_offset>: Inline.
1927         <get_ref_die_offset_complaint>: New method.
1928         * dwarf2/attribute.c (attribute::form_is_ref): Move to header.
1929         (attribute::get_ref_die_offset_complaint): Rename from
1930         get_ref_die_offset.  Just issue complaint.
1931
1932 2020-05-27  Hannes Domani  <ssbssa@yahoo.de>
1933
1934         * cli/cli-cmds.c (shell_escape): Move exit_status_set_internal_vars.
1935
1936 2020-05-27  Hannes Domani  <ssbssa@yahoo.de>
1937
1938         * exec.c (exec_file_attach): Use errno value of first openp failure.
1939
1940 2020-05-27  Hannes Domani  <ssbssa@yahoo.de>
1941
1942         * nat/windows-nat.c (windows_thread_info::~windows_thread_info):
1943         Don't close thread handle.
1944
1945 2020-05-27  Tom Tromey  <tom@tromey.com>
1946             Simon Marchi  <simon.marchi@efficios.com>
1947
1948         * objfiles.h (struct objfile) <partial_symtabs>: Now a
1949         shared_ptr.
1950         * dwarf2/read.h (struct dwarf2_per_objfile) <partial_symtabs>: New
1951         member.
1952         * dwarf2/read.c (dwarf2_per_bfd_bfd_data_key,
1953         dwarf2_per_bfd_objfile_data_key>: New globals.
1954         (dwarf2_has_info): Use shared dwarf2_per_bfd if possible.
1955         (dwarf2_get_section_info): Use get_dwarf2_per_objfile.
1956         (dwarf2_initialize_objfile): Consider cases where per_bfd can be
1957         shared.
1958         (dwarf2_build_psymtabs): Set objfile::partial_symtabs and
1959         short-circuit when sharing.
1960         (dwarf2_build_psymtabs): Set dwarf2_per_objfile::partial_symtabs.
1961         (dwarf2_psymtab::expand_psymtab): Use free_cached_comp_units.
1962
1963 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
1964
1965         * dwarf2/read.h (struct dwarf2_per_bfd) <line_header_hash>: Move
1966         to...
1967         (struct dwarf2_per_objfile) <line_header_hash>: ... here.
1968         * dwarf2/read.c (handle_DW_AT_stmt_list): Update.
1969
1970 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
1971
1972         * dwarf2/read.c (struct mapped_index_base) <symbol_name_at,
1973         build_name_components, find_name_components_bounds>:
1974         Add per_objfile parameter.
1975         (struct mapped_index) <symbol_name_at>: Likewise.
1976         (struct mapped_debug_names): Remove constructor.
1977         <dwarf2_per_objfile>: Remove field.
1978         <namei_to_name, symbol_name_at>: Add per_objfile parameter.
1979         (mapped_index_base::find_name_components_bounds,
1980         mapped_index_base::build_name_components,
1981         dw2_expand_symtabs_matching_symbol): Likewise.
1982         (class mock_mapped_index) <symbol_name_at>: Likewise.
1983         (check_match): Likewise.
1984         (check_find_bounds_finds): Likewise.
1985         (test_mapped_index_find_name_component_bounds): Update.
1986         (CHECK_MATCH): Update.
1987         (dw2_expand_symtabs_matching): Update.
1988         (class dw2_debug_names_iterator) <dw2_debug_names_iterator>: Add
1989         per_objfile parameter.
1990         <find_vec_in_debug_names>: Likewise.
1991         <m_per_objfile>: New field.
1992         (mapped_debug_names::namei_to_name): Add dwarf2_per_objfile
1993         parameter.
1994         (dw2_debug_names_iterator::find_vec_in_debug_names): Likewise.
1995         (dw2_debug_names_iterator::next): Update.
1996         (dw2_debug_names_lookup_symbol): Update.
1997         (dw2_debug_names_expand_symtabs_for_function): Update.
1998         (dw2_debug_names_map_matching_symbols): Update.
1999         (dw2_debug_names_expand_symtabs_matching): Update.
2000         (dwarf2_read_debug_names): Update.
2001
2002 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
2003
2004         * dwarf2/read.h (struct dwarf2_cu): Forward-declare.
2005         (struct dwarf2_per_bfd) <free_cached_comp_units>: Remove,
2006         move to dwarf2_per_objfile.
2007         <read_in_chain>: Remove.
2008         (struct dwarf2_per_objfile) <get_cu, set_cu, remove_cu,
2009         remove_all_cus, age_comp_units>: New methods.
2010         <m_dwarf2_cus>: New member.
2011         (struct dwarf2_per_cu_data) <cu>: Remove.
2012         * dwarf2/read.c (struct dwarf2_cu) <read_in_chain>: Remove.
2013         (age_cached_comp_units, free_one_cached_comp_unit): Remove,
2014         moved to methods of dwarf2_per_objfile.
2015         (dwarf2_clear_marks): Remove.
2016         (dwarf2_queue_item::~dwarf2_queue_item): Update.
2017         (dwarf2_per_bfd::~dwarf2_per_bfd): Don't free dwarf2_cus.
2018         (dwarf2_per_bfd::free_cached_comp_units): Remove.
2019         (dwarf2_per_objfile::remove_all_cus): New.
2020         (class free_cached_comp_units) <~free_cached_comp_units>:
2021         Update.
2022         (load_cu): Update.
2023         (dw2_do_instantiate_symtab): Adjust.
2024         (fill_in_sig_entry_from_dwo_entry): Adjust.
2025         (cutu_reader::init_tu_and_read_dwo_dies): Update.
2026         (cutu_reader::cutu_reader): Likewise.
2027         (cutu_reader::keep): Use dwarf2_per_objfile::set_cu.
2028         (cutu_reader::cutu_reader): Use dwarf2_per_objfile::get_cu.
2029         (process_psymtab_comp_unit): Use dwarf2_per_objfile::remove_cu
2030         and dwarf2_per_objfile::age_comp_units.
2031         (load_partial_comp_unit): Update.
2032         (maybe_queue_comp_unit): Use dwarf2_per_objfile::get_cu.
2033         (process_queue): Likewise.
2034         (find_partial_die): Use dwarf2_per_objfile::get_cu instead of cu
2035         backlink.
2036         (dwarf2_read_addr_index): Likewise.
2037         (follow_die_offset): Likewise.
2038         (dwarf2_fetch_die_loc_sect_off): Likewise.
2039         (dwarf2_fetch_constant_bytes): Likewise.
2040         (dwarf2_fetch_die_type_sect_off): Likewise.
2041         (follow_die_sig_1): Likewise.
2042         (load_full_type_unit): Likewise.
2043         (read_signatured_type): Likewise.
2044         (dwarf2_cu::dwarf2_cu): Don't set cu field.
2045         (dwarf2_cu::~dwarf2_cu): Remove.
2046         (dwarf2_per_objfile::get_cu): New.
2047         (dwarf2_per_objfile::set_cu): New.
2048         (age_cached_comp_units): Rename to...
2049         (dwarf2_per_objfile::age_comp_units): ... this.  Adjust
2050         to std::unordered_map.
2051         (free_one_cached_comp_unit): Rename to...
2052         (dwarf2_per_objfile::remove_cu): ... this.  Adjust
2053         to std::unordered_map.
2054         (dwarf2_per_objfile::~dwarf2_per_objfile): New.
2055         (dwarf2_mark_helper): Use dwarf2_per_objfile::get_cu, expect
2056         a dwarf2_per_objfile in data.
2057         (dwarf2_mark): Pass dwarf2_per_objfile in data to htab_traverse.
2058         (dwarf2_clear_marks): Remove.
2059
2060 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
2061
2062         * dwarf2/read.c (class cutu_reader) <cutu_reader>: Replace
2063         `int use_existing_cu` parameter with `dwarf2_cu *existing_cu`.
2064         (init_tu_and_read_dwo_dies): Likewise.
2065         (cutu_reader::init_tu_and_read_dwo_dies): Likewise.
2066         (cutu_reader::cutu_reader): Likewise.
2067         (load_partial_comp_unit): Likewise.
2068         (process_psymtab_comp_unit): Update.
2069         (build_type_psymtabs_1): Update.
2070         (process_skeletonless_type_unit): Update.
2071         (load_full_comp_unit): Update.
2072         (find_partial_die): Update.
2073         (dwarf2_read_addr_index): Update.
2074         (read_signatured_type): Update.
2075
2076 2020-05-27  Simon Marchi  <simon.marchi@polymtl.ca>
2077
2078         * dwarf2/read.h (struct dwarf2_per_cu_data) <m_header,
2079         m_header_read_in>: New fields.
2080         <get_header>: New method.
2081         * dwarf2/read.c (per_cu_header_read_in): Remove.
2082         (dwarf2_per_cu_data::get_header): New.
2083         (dwarf2_per_cu_data::addr_size): Update.
2084         (dwarf2_per_cu_data::offset_size): Update.
2085         (dwarf2_per_cu_data::ref_addr_size): Update.
2086
2087 2020-05-27  Simon Marchi  <simon.marchi@polymtl.ca>
2088
2089         * dwarf2/read.c (load_cu): Return dwarf2_cu.
2090         (dw2_do_instantiate_symtab): Update.
2091         (queue_and_load_all_dwo_tus): Change parameter from
2092         dwarf2_per_cu_data to dwarf2_cu.
2093         (dwarf2_fetch_die_loc_sect_off): Update.
2094         (dwarf2_fetch_constant_bytes): Update.
2095         (dwarf2_fetch_die_type_sect_off): Update.
2096
2097 2020-05-27  Simon Marchi  <simon.marchi@polymtl.ca>
2098
2099         * dwarf2/read.c (process_full_comp_unit,
2100         process_full_type_unit): Remove per_cu, per_objfile paramters.
2101         Add dwarf2_cu parameter.
2102         (process_queue): Update.
2103
2104 2020-05-27  Simon Marchi  <simon.marchi@polymtl.ca>
2105
2106         * dwarf2/read.c (create_cu_from_index_list): Replace
2107         dwarf2_per_objfile parameter with dwarf2_per_bfd.
2108         (create_cus_from_index_list): Likewise.
2109         (create_cus_from_index): Likewise.
2110         (create_signatured_type_table_from_index): Likewise.
2111         (create_cus_from_debug_names_list): Likewise.
2112         (create_cus_from_debug_names): Likewise.
2113         (dwarf2_read_gdb_index): Update.
2114         (dwarf2_read_debug_names): Update.
2115
2116 2020-05-27  Tom Tromey  <tom@tromey.com>
2117             Simon Marchi  <simon.marchi@efficios.com>
2118
2119         * dwarf2/read.h (struct dwarf2_per_objfile)
2120         <get_type_for_signatured_type, set_type_for_signatured_type>:
2121         New methods.
2122         <m_type_map>: New member.
2123         (struct signatured_type) <type>: Remove.
2124         * dwarf2/read.c
2125         (dwarf2_per_objfile::get_type_for_signatured_type,
2126         dwarf2_per_objfile::set_type_for_signatured_type): New.
2127         (get_signatured_type): Use new methods.
2128
2129 2020-05-27  Tom Tromey  <tom@tromey.com>
2130             Simon Marchi  <simon.marchi@efficios.com>
2131
2132         * dwarf2/read.h (struct type_unit_group_unshareable): New.
2133         (struct dwarf2_per_objfile) <type_units>: New member.
2134         <get_type_unit_group_unshareable>: New method.
2135         * dwarf2/read.c (struct type_unit_group) <compunit_symtab,
2136         num_symtabs, symtabs>: Remove; move to
2137         type_unit_group_unshareable.
2138         (dwarf2_per_objfile::get_type_unit_group_unshareable): New.
2139         (process_full_type_unit, dwarf2_cu::setup_type_unit_groups)
2140         (dwarf2_cu::setup_type_unit_groups): Use type_unit_group_unshareable.
2141
2142 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
2143
2144         * dwarf2/read.h (struct dwarf2_per_cu_data):
2145         <dwarf2_per_objfile>: Remove.
2146         * dwarf2/read.c (create_cu_from_index_list): Don't assign
2147         dwarf2_per_objfile.
2148         (create_signatured_type_table_from_index): Likewise.
2149         (create_signatured_type_table_from_debug_names): Likewise.
2150         (create_debug_type_hash_table): Likewise.
2151         (fill_in_sig_entry_from_dwo_entry): Likewise.
2152         (create_type_unit_group): Likewise.
2153         (read_comp_units_from_section): Likewise.
2154         (create_cus_hash_table): Likewise.
2155
2156 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
2157
2158         * dwarf2/read.c (process_psymtab_comp_unit): Remove reference to
2159         dwarf2_per_cu_data::dwarf2_per_objfile.
2160         (compute_compunit_symtab_includes): Likewise.
2161         (dwarf2_cu::start_symtab): Likewise.
2162
2163 2020-05-27  Simon Marchi  <simon.marchi@polymtl.ca>
2164
2165         * dwarf2/read.h (dwarf2_get_die_type): Add dwarf2_per_objfile
2166         parameter.
2167         * dwarf2/read.c (get_die_type_at_offset): Likewise.
2168         (read_namespace_alias): Update.
2169         (lookup_die_type): Update.
2170         (dwarf2_get_die_type): Add dwarf2_per_objfile parameter.
2171         * dwarf2/loc.c (class dwarf_evaluate_loc_desc) <get_base_type>:
2172         Update.
2173         (disassemble_dwarf_expression): Update.
2174
2175 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
2176
2177         * dwarf2/read.h (struct dwarf2_queue_item): Add
2178         dwarf2_per_objfile parameter, assign new parameter.
2179         <per_objfile>: New field.
2180         * dwarf2/read.c (free_one_cached_comp_unit): Add
2181         dwarf2_per_objfile parameter.
2182         (queue_comp_unit): Likewise.
2183         (dw2_do_instantiate_symtab): Update.
2184         (process_psymtab_comp_unit): Update.
2185         (maybe_queue_comp_unit): Add dwarf2_per_objfile parameter.
2186         (process_imported_unit_die): Update.
2187         (queue_and_load_dwo_tu): Update.
2188         (follow_die_offset): Update.
2189         (follow_die_sig_1): Update.
2190
2191 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
2192
2193         * dwarf2/read.h (struct dwarf2_per_cu_data) <objfile>: Remove.
2194         * dwarf2/read.c (dwarf2_compute_name): Pass per_objfile down.
2195         (read_call_site_scope): Assign per_objfile.
2196         (dwarf2_per_cu_data::objfile): Remove.
2197         * gdbtypes.h (struct call_site) <per_objfile>: New member.
2198         * dwarf2/loc.h (dwarf2_evaluate_loc_desc): Add
2199         dwarf2_per_objfile parameter.
2200         * dwarf2/loc.c (dwarf2_evaluate_loc_desc_full): Add
2201         dwarf2_per_objfile parameter.
2202         (dwarf_expr_reg_to_entry_parameter): Add output
2203         dwarf2_per_objfile parameter.
2204         (locexpr_get_frame_base): Update.
2205         (class dwarf_evaluate_loc_desc) <get_tls_address>: Update.
2206         <push_dwarf_reg_entry_value>: Update.
2207         <call_site_to_target_addr>: Update.
2208         (dwarf_entry_parameter_to_value): Add dwarf2_per_objfile
2209         parameter.
2210         (value_of_dwarf_reg_entry): Update.
2211         (rw_pieced_value): Update.
2212         (indirect_synthetic_pointer): Update.
2213         (dwarf2_evaluate_property): Update.
2214         (dwarf2_loc_desc_get_symbol_read_needs): Add dwarf2_per_objfile
2215         parameter.
2216         (locexpr_read_variable): Update.
2217         (locexpr_get_symbol_read_needs): Update.
2218         (loclist_read_variable): Update.
2219
2220 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
2221
2222         * dwarf2/read.h (dwarf2_fetch_die_loc_sect_off,
2223         dwarf2_fetch_die_loc_cu_off, dwarf2_fetch_constant_bytes,
2224         dwarf2_fetch_die_type_sect_off): Add dwarf2_per_objfile
2225         parameter.
2226         * dwarf2/read.c (dwarf2_fetch_die_loc_sect_off,
2227         dwarf2_fetch_die_loc_cu_off, dwarf2_fetch_constant_bytes,
2228         dwarf2_fetch_die_type_sect_off): Add dwarf2_per_objfile
2229         parameter.
2230         * dwarf2/loc.c (indirect_synthetic_pointer, per_cu_dwarf_call,
2231         sect_variable_value): Add dwarf2_per_objfile parameter.
2232         (class dwarf_evaluate_loc_desc) <dwarf_call,
2233         dwarf_variable_value>: Update.
2234         (fetch_const_value_from_synthetic_pointer): Add
2235         dwarf2_per_objfile parameter.
2236         (fetch_const_value_from_synthetic_pointer): Update.
2237         (coerced_pieced_ref): Update.
2238         (class symbol_needs_eval_context) <dwarf_call,
2239         dwarf_variable_value>: Update.
2240         (dwarf2_compile_expr_to_ax): Update.
2241
2242 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
2243
2244         * dwarf2/loc.c (allocate_piece_closure): Add dwarf2_per_objfile
2245         parameter.
2246         (dwarf2_evaluate_loc_desc_full): Update.
2247
2248 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
2249
2250         * dwarf2/read.h (dwarf2_read_addr_index): Add dwarf2_per_objfile
2251         parameter.
2252         * dwarf2/read.c (dwarf2_read_addr_index): Likewise.
2253         * dwarf2/loc.c (decode_debug_loclists_addresses): Add
2254         dwarf2_per_objfile parameter.
2255         (decode_debug_loc_dwo_addresses): Likewise.
2256         (dwarf2_find_location_expression): Update.
2257         (class dwarf_evaluate_loc_desc) <get_addr_index>: Update.
2258         (locexpr_describe_location_piece): Add dwarf2_per_objfile
2259         parameter.
2260         (disassemble_dwarf_expression): Add dwarf2_per_objfile
2261         parameter.
2262         (locexpr_describe_location_1): Likewise.
2263         (locexpr_describe_location): Update.
2264
2265 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
2266
2267         * dwarf2/read.h (struct dwarf2_per_cu_data) <text_offset>:
2268         Remove.
2269         * dwarf2/read.c (dwarf2_per_cu_data::text_offset): Remove.
2270         * dwarf2/loc.c (dwarf2_find_location_expression): Update.
2271         (dwarf2_compile_property_to_c): Update.
2272         (dwarf2_compile_expr_to_ax): Add dwarf2_per_objfile parameter,
2273         use text offset from objfile.
2274         (locexpr_tracepoint_var_ref): Update.
2275         (locexpr_generate_c_location): Update.
2276         (loclist_describe_location): Update.
2277         (loclist_tracepoint_var_ref): Update.
2278         * dwarf2/compile.h (compile_dwarf_bounds_to_c): Add
2279         dwarf2_per_objfile parameter.
2280         * dwarf2/loc2c.c (do_compile_dwarf_expr_to_c): Likewise,
2281         use text offset from objfile.
2282         (compile_dwarf_expr_to_c): Add dwarf2_per_objfile parameter.
2283
2284 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
2285
2286         * dwarf2/expr.h (struct dwarf_expr_context)
2287         <dwarf_expr_context>: Add dwarf2_per_objfile parameter.
2288         <offset>: Remove.
2289         <per_objfile>: New member.
2290         * dwarf2/expr.c (dwarf_expr_context::dwarf_expr_context): Add
2291         dwarf2_per_objfile parameter.  Don't set offset, set
2292         per_objfile.
2293         (dwarf_expr_context::execute_stack_op): Use offset from objfile.
2294         * dwarf2/frame.c (dwarf2_frame_find_fde): Return (by parameter)
2295         a dwarf2_per_objfile object instead of an offset.
2296         (class dwarf_expr_executor) <dwarf_expr_executor>: Add
2297         constructor.
2298         (execute_stack_op): Add dwarf2_per_objfile parameter, pass it
2299         to dwarf2_expr_executor constructor.  Don't set offset.
2300         (dwarf2_fetch_cfa_info): Update.
2301         (struct dwarf2_frame_cache) <text_offset>: Remove.
2302         <per_objfile>: New field.
2303         (dwarf2_frame_cache): Update.
2304         (dwarf2_frame_prev_register): Update.
2305         * dwarf2/loc.c (class dwarf_evaluate_loc_desc)
2306         <dwarf_evaluate_loc_desc>: Add constructor.
2307         (dwarf2_evaluate_loc_desc_full): Update.
2308         (dwarf2_locexpr_baton_eval): Update.
2309         (class symbol_needs_eval_context) <symbol_needs_eval_context>:
2310         Add constructor.
2311         (dwarf2_loc_desc_get_symbol_read_needs): Update.
2312
2313 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
2314
2315         * dwarf2/read.h (struct dwarf2_per_cu_data) <addr_type,
2316         addr_sized_int_type>: Move to dwarf2_cu.
2317         <int_type>: Move to dwarf2_per_objfile.
2318         (struct dwarf2_per_objfile) <int_type>: Move here.
2319         * dwarf2/read.c (struct dwarf2_cu) <addr_type,
2320         addr_sized_int_type>: Move here.
2321         (read_func_scope): Update.
2322         (read_array_type): Update.
2323         (read_tag_string_type): Update.
2324         (attr_to_dynamic_prop): Update.
2325         (dwarf2_per_cu_data::int_type): Rename to...
2326         (dwarf2_per_objfile::int_type): ... this.
2327         (dwarf2_per_cu_data::addr_sized_int_type): Rename to...
2328         (dwarf2_cu::addr_sized_int_type): ... this.
2329         (read_subrange_type): Update.
2330         (dwarf2_per_cu_data::addr_type): Rename to...
2331         (dwarf2_cu::addr_type): ... this.
2332         (set_die_type): Update.
2333
2334 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
2335
2336         * dwarf2/read.c (queue_and_load_all_dwo_tus): Access per_objfile
2337         data through per_cu->cu.
2338
2339 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
2340
2341         * dwarf2/read.c (lookup_dwo_comp_unit): Change
2342         dwarf2_per_cu_data parameter fo dwarf2_cu.
2343         (lookup_dwo_type_unit): Likewise.
2344         (read_cutu_die_from_dwo): Likewise.
2345         (lookup_dwo_unit): Likewise.
2346         (open_and_init_dwo_file): Likewise.
2347         (lookup_dwo_cutu): Likewise.
2348         (lookup_dwo_comp_unit): Likewise.
2349         (lookup_dwo_type_unit): Likewise.
2350         (cutu_reader::init_tu_and_read_dwo_dies): Update.
2351         (cutu_reader::cutu_reader): Update.
2352
2353 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
2354
2355         * dwarf2/read.c (process_full_comp_unit): Add dwarf2_per_objfile
2356         parameter.
2357         (process_full_type_unit): Likewise.
2358         (process_queue): Update.
2359
2360 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
2361
2362         * dwarf2/read.c (recursively_compute_inclusions): Add
2363         dwarf2_per_objfile parameter.
2364         (compute_compunit_symtab_includes): Likewise.
2365         (process_cu_includes): Update.
2366
2367 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
2368
2369         * dwarf2/read.c (create_partial_symtab): Add dwarf2_per_objfile
2370         parameter.
2371         (create_type_unit_group): Update.
2372         (process_psymtab_comp_unit_reader): Update.
2373         (build_type_psymtabs_reader): Update.
2374
2375 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
2376
2377         * dwarf2/read.c (cutu_reader::keep): Access dwarf2_per_objfile
2378         object through m_this_cu->cu.
2379
2380 2020-05-27  Simon Marchi  <simon.marchi@polymtl.ca>
2381
2382         * dwarf2/read.c (queue_and_load_dwo_tu): Expect a dwarf2_cu as
2383         the info parameter.
2384         (queue_and_load_all_dwo_tus): Pass per_cu->cu.
2385
2386 2020-05-27  Simon Marchi  <simon.marchi@polymtl.ca>
2387
2388         * dwarf2/read.c (class cutu_reader) <cutu_reader>: Add
2389         per_objfile parameter.
2390         (load_full_type_unit): Add per_objfile parameter.
2391         (read_signatured_type): Likewise.
2392         (load_full_comp_unit): Likewise.
2393         (load_cu): Likewise.
2394         (dw2_do_instantiate_symtab): Likewise.
2395         (dw2_get_file_names): Likewise.
2396         (dw2_map_symtabs_matching_filename): Update.
2397         (dw_expand_symtabs_matching_file_matcher): Update.
2398         (dw2_map_symbol_filenames): Update.
2399         (process_psymtab_comp_unit): Add per_objfile parameter.
2400         (build_type_psymtabs_1): Update.
2401         (process_skeletonless_type_unit): Update.
2402         (dwarf2_build_psymtabs_hard): Update.
2403         (load_partial_comp_unit): Add per_objfile parameter.
2404         (scan_partial_symbols): Update.
2405         (load_full_comp_unit): Add per_objfile parameter.
2406         (process_imported_unit_die): Update.
2407         (create_cus_hash_table): Update.
2408         (find_partial_die): Update.
2409         (dwarf2_read_addr_index): Update.
2410         (follow_die_offset): Update.
2411         (dwarf2_fetch_die_loc_sect_off): Update.
2412         (dwarf2_fetch_constant_bytes): Update.
2413         (dwarf2_fetch_die_type_sect_off): Update.
2414         (follow_die_sig_1): Update.
2415         (load_full_type_unit): Add per_objfile parameter.
2416         (read_signatured_type): Likewise.
2417
2418 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
2419
2420         * dwarf2/read.c (lookup_dwo_unit): Use bfd_get_filename instead
2421         of objfile_name.
2422
2423 2020-05-27  Simon Marchi  <simon.marchi@polymtl.ca>
2424
2425         * dwarf2/read.h (struct dwarf2_per_bfd) <obfd>: New member.
2426         (dwarf2_get_dwz_file): Replace parameter with dwarf2_per_bfd.
2427         * dwarf2/read.c (dwarf2_per_bfd::dwarf2_per_bfd): Assign obfd
2428         field.
2429         (dwarf2_get_dwz_file): Replace parameter with dwarf2_per_bfd.
2430         (create_cus_from_index): Update.
2431         (dwarf2_read_gdb_index): Update.
2432         (create_cus_from_debug_names): Update.
2433         (dwarf2_read_debug_names): Update.
2434         (get_abbrev_section_for_cu): Update.
2435         (create_all_comp_units): Update.
2436         (read_attribute_value): Update.
2437         (get_debug_line_section): Update.
2438         * dwarf2/index-cache.c (index_cache::store): Update.
2439         * dwarf2/index-write.c (save_gdb_index_command): Update.
2440         * dwarf2/macro.c (dwarf_decode_macro_bytes): Update.
2441
2442 2020-05-27  Simon Marchi  <simon.marchi@polymtl.ca>
2443
2444         * dwarf2/read.h (struct dwarf2_per_cu_data) <per_bfd>: New
2445         member.
2446         * dwarf2/read.c (dwarf2_per_bfd::allocate_per_cu): Initialize
2447         dwarf2_per_cu_data::per_bfd.
2448         (dwarf2_per_bfd::allocate_signatured_type): Likewise.
2449         (create_type_unit_group): Likewise.
2450         (queue_comp_unit): Remove reference to
2451         per_cu->dwarf2_per_objfile.
2452         (maybe_queue_comp_unit): Likewise.
2453         (fill_in_sig_entry_from_dwo_entry): Assign new field.
2454         (create_cus_hash_table): Assign new field.
2455
2456 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
2457
2458         * dwarf2/read.c: Replace
2459         dwarf2_cu->per_cu->dwarf2_per_objfile references with
2460         dwarf2_cu->per_objfile throughout.
2461
2462 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
2463
2464         * dwarf2/read.c (dw2_do_instantiate_symtab): Add per_objfile
2465         parameter, don't use per_cu->dwarf2_per_objfile.
2466         (dw2_instantiate_symtab): Likewise.
2467         (dw2_find_last_source_symtab): Update.
2468         (dw2_map_expand_apply): Update.
2469         (dw2_lookup_symbol): Update.
2470         (dw2_expand_symtabs_for_function): Update.
2471         (dw2_expand_all_symtabs): Update.
2472         (dw2_expand_symtabs_with_fullname): Update.
2473         (dw2_expand_symtabs_matching_one): Add per_objfile parameter,
2474         don't use per_cu->dwarf2_per_objfile.
2475         (dw2_expand_marked_cus): Update.
2476         (dw2_find_pc_sect_compunit_symtab): Update.
2477         (dw2_debug_names_lookup_symbol): Update.
2478         (dw2_debug_names_expand_symtabs_for_function): Update.
2479         (dw2_debug_names_map_matching_symbols): Update.
2480         (dwarf2_psymtab::expand_psymtab): Update.
2481
2482 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
2483
2484         * dwarf2/read.c (struct dwarf2_cu) <dwarf2_cu>: Add parameter.
2485         <per_objfile>: New member.
2486         (class cutu_reader) <init_tu_and_read_dwo_dies>: Add parameter.
2487         (cutu_reader::init_tu_and_read_dwo_dies): Add parameter, update
2488         call to dwarf2_cu.
2489         (cutu_reader::cutu_reader): Update.
2490         (dwarf2_cu::dwarf2_cu): Add parameter, initialize per_objfile.
2491
2492 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
2493
2494         * dwarf2/read.h (struct dwarf2_per_bfd) <die_type_hash>: Move to
2495         struct dwarf2_per_objfile.
2496         (struct dwarf2_per_objfile) <die_type_hash>: Move from struct
2497         dwarf2_per_bfd.
2498         * dwarf2/read.c (set_die_type): Update.
2499         (get_die_type_at_offset): Update.
2500
2501 2020-05-27  Tom Tromey  <tom@tromey.com>
2502             Simon Marchi  <simon.marchi@efficios.com>
2503
2504         * dwarf2/read.h (struct dwarf2_per_bfd) <num_psymtabs>: New
2505         method.
2506         (struct dwarf2_per_objfile) <resize_symtabs, symtab_set_p,
2507         get_symtab, set_symtab>: New methods.
2508         <m_symtabs>: New field.
2509         (struct dwarf2_psymtab): Derive from partial_symtab.
2510         <readin_p, get_compunit_symtab>: Declare methods.
2511         * dwarf2/read.c (dwarf2_per_objfile::symtab_set_p,
2512         dwarf2_per_objfile::get_symtab, dwarf2_per_objfile::set_symtab):
2513         New methods.
2514         (struct dwarf2_per_cu_quick_data) <compunit_symtab>: Remove.
2515         (dw2_do_instantiate_symtab, dw2_instantiate_symtab)
2516         (dw2_map_expand_apply, dw2_map_symtabs_matching_filename)
2517         (dw2_symtab_iter_next, dw2_print_stats)
2518         (dw2_expand_symtabs_with_fullname)
2519         (dw2_expand_symtabs_matching_one)
2520         (dw_expand_symtabs_matching_file_matcher)
2521         (dw2_find_pc_sect_compunit_symtab, dw2_map_symbol_filenames)
2522         (dw2_debug_names_iterator::next)
2523         (dw2_debug_names_map_matching_symbols)
2524         (fill_in_sig_entry_from_dwo_entry, dwarf2_psymtab::read_symtab)
2525         (process_queue, dwarf2_psymtab::expand_psymtab): Update.
2526         (dwarf2_psymtab::readin_p, dwarf2_psymtab::get_compunit_symtab):
2527         New methods.
2528         (get_compunit_symtab, process_full_comp_unit)
2529         (process_full_type_unit): Update.
2530         (dwarf2_build_psymtabs, dwarf2_initialize_objfile, add_type_unit): Call
2531
2532 2020-05-27  Simon Marchi  <simon.marchi@polymtl.ca>
2533
2534         * dwarf2/read.h (dwarf2_per_objfile): Rename to dwarf2_per_bfd,
2535         then introduce a new dwarf2_per_objfile type.
2536         <read_line_string>: Move to the new dwarf2_per_objfile type.
2537         <objfile>: Likewise.
2538         (dwarf2_per_bfd): Rename dwarf2_per_objfile to this.
2539         * dwarf2/read.c: Replace references to dwarf2_per_objfile with
2540         dwarf2_per_objfile->per_bfd.
2541         (dwarf2_per_objfile::dwarf2_per_objfile): Rename to...
2542         (dwarf2_per_bfd::dwarf2_per_bfd): ... this.
2543         (dwarf2_per_objfile::free_cached_comp_units): Rename to...
2544         (dwarf2_per_bfd::free_cached_comp_units): ... this.
2545         (dwarf2_has_info): Allocate dwarf2_per_bfd.
2546         (dwarf2_per_objfile::locate_sections): Rename to...
2547         (dwarf2_per_bfd::locate_sections): ... this.
2548         (dwarf2_per_objfile::get_cutu): Rename to...
2549         (dwarf2_per_bfd::get_cutu): ... this.
2550         (dwarf2_per_objfile::get_cu): Rename to...
2551         (dwarf2_per_bfd::get_cu): ... this.
2552         (dwarf2_per_objfile::get_tu): Rename to...
2553         (dwarf2_per_bfd::get_tu): ... this.
2554         (dwarf2_per_objfile::allocate_per_cu): Rename to...
2555         (dwarf2_per_bfd::allocate_per_cu): ... this.
2556         (dwarf2_per_objfile::allocate_signatured_type): Rename to...
2557         (dwarf2_per_bfd::allocate_signatured_type): ... this.
2558         (get_gdb_index_contents_ftype): Change parameter from
2559         dwarf2_per_objfile to dwarf2_per_bfd.
2560         * dwarf2/macro.c, dwarf2/index-write.c: Replace references to
2561         dwarf2_per_objfile with dwarf2_per_objfile->per_bfd.
2562
2563 2020-05-27  Tom Tromey  <tom@tromey.com>
2564             Simon Marchi  <simon.marchi@efficios.com>
2565
2566         * dwarf2/loc.c (struct piece_closure) <per_objfile>: New member.
2567         (allocate_piece_closure): Set "per_objfile" member.
2568         (dwarf2_find_location_expression, dwarf2_locexpr_baton_eval)
2569         (locexpr_describe_location, loclist_describe_location): Use new
2570         member.
2571         * dwarf2/read.c (read_call_site_scope)
2572         (mark_common_block_symbol_computed, attr_to_dynamic_prop)
2573         (dwarf2_const_value_attr, dwarf2_fetch_die_loc_sect_off)
2574         (fill_in_loclist_baton, dwarf2_symbol_mark_computed,
2575         handle_data_member_location): Set per_objfile member.
2576         * dwarf2/loc.h (struct dwarf2_locexpr_baton) <per_objfile>: New
2577         member.
2578         (struct dwarf2_loclist_baton) <per_objfile>: New member.
2579
2580 2020-05-27  Tom Tromey  <tom@tromey.com>
2581
2582         * dwarf2/read.h (struct dwarf2_per_objfile) <allocate_per_cu,
2583         allocate_signatured_type>: Declare new methods.
2584         <m_num_psymtabs>: New member.
2585         (struct dwarf2_per_cu_data) <index>: New member.
2586         * dwarf2/read.c (dwarf2_per_objfile::allocate_per_cu)
2587         (dwarf2_per_objfile::allocate_signatured_type): New methods.
2588         (create_cu_from_index_list): Use allocate_per_cu.
2589         (create_signatured_type_table_from_index)
2590         (create_signatured_type_table_from_debug_names)
2591         (create_debug_type_hash_table, add_type_unit)
2592         (read_comp_units_from_section): Use allocate_signatured_type.
2593
2594 2020-05-27  Tom Tromey  <tom@tromey.com>
2595
2596         * psymtab.c (partial_map_expand_apply)
2597         (psym_find_pc_sect_compunit_symtab, psym_lookup_symbol)
2598         (psym_lookup_global_symbol_language)
2599         (psymtab_to_symtab, psym_find_last_source_symtab, dump_psymtab)
2600         (psym_print_stats, psym_expand_symtabs_for_function)
2601         (psym_map_symbol_filenames, psym_map_matching_symbols)
2602         (psym_expand_symtabs_matching)
2603         (partial_symtab::read_dependencies, maintenance_info_psymtabs)
2604         (maintenance_check_psymtabs): Update.
2605         * psympriv.h (struct partial_symtab) <readin_p,
2606         get_compunit_symtab>: Add objfile parameter.
2607         (struct standard_psymtab) <readin_p, get_compunit_symtab>:
2608         Likewise.
2609         * dwarf2/read.c (struct dwarf2_include_psymtab) <readin_p,
2610         get_compunit_symtab>: Likewise.
2611         (dwarf2_psymtab::expand_psymtab): Pass objfile argument.
2612
2613 2020-05-27  Tom Tromey  <tom@tromey.com>
2614
2615         * dwarf2/read.h (struct dwarf2_per_objfile) <obstack>: New
2616         member.
2617         * dwarf2/read.c (delete_file_name_entry): Fix comment.
2618         (create_cu_from_index_list)
2619         (create_signatured_type_table_from_index)
2620         (create_signatured_type_table_from_debug_names)
2621         (dw2_get_file_names_reader, dwarf2_initialize_objfile)
2622         (dwarf2_create_include_psymtab)
2623         (create_debug_type_hash_table, add_type_unit)
2624         (create_type_unit_group, read_comp_units_from_section)
2625         (dwarf2_compute_name, create_cus_hash_table)
2626         (create_dwp_hash_table, create_dwo_unit_in_dwp_v1)
2627         (create_dwo_unit_in_dwp_v2, open_and_init_dwp_file): Use new
2628         obstack.
2629         (dw2_get_real_path): Likewise.  Change argument to
2630         dwarf2_per_objfile.
2631
2632 2020-05-27  Luis Machado  <luis.machado@linaro.org>
2633
2634         PR tdep/26000
2635         * arm-tdep.c (thumb_analyze_prologue): Fix instruction matching
2636         for ldrd (immediate).
2637
2638 2020-05-26  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2639
2640         * command.h: Add comment giving the name of class_tui.
2641         * cli/cli-cmds.c (_initialize_cli_cmds): If TUI defined,
2642         create the fake command for the help for class_tui.
2643
2644 2020-05-26  Tom Tromey  <tromey@adacore.com>
2645
2646         * ada-lang.c (ada_print_array_index): Change type.  Call val_atr.
2647         (ada_value_ptr_subscript): Don't call pos_atr on the lower bound.
2648         (val_atr): New function.
2649         (value_val_atr): Use it.
2650         * ada-valprint.c (print_optional_low_bound): Change low bound
2651         handling for enums.
2652         (val_print_packed_array_elements): Don't call discrete_position.
2653         * gdbtypes.c (get_discrete_bounds) <TYPE_CODE_RANGE>: Call
2654         discrete_position for enum types.
2655         * language.c (default_print_array_index): Change type.
2656         * language.h (struct language_defn) <la_print_array_index>: Add
2657         index_type parameter, change type of index_value.
2658         (LA_PRINT_ARRAY_INDEX): Add index_type parameter.
2659         (default_print_array_index): Update.
2660         * valprint.c (maybe_print_array_index): Don't call
2661         value_from_longest.  Update.
2662         (value_print_array_elements): Don't call discrete_position.
2663
2664 2020-05-26  Tom Tromey  <tromey@adacore.com>
2665
2666         * ada-lang.c (value_val_atr): Handle TYPE_CODE_RANGE.
2667         * gdbtypes.c (discrete_position): Handle TYPE_CODE_RANGE.
2668
2669 2020-05-25  Cristiano De Alti  <cristiano_dealti@hotmail.com>
2670
2671         PR gdb/13519
2672         * avr-tdep.c (avr_integer_to_address): Return data or code
2673         address accordingly to the second 'type' argument of the
2674         function.
2675
2676 2020-05-25  Michael Weghorn  <m.weghorn@posteo.de>
2677
2678         * infcmd.c, inferior.h: (construct_inferior_arguments):
2679         Moved function from here to gdbsupport/common-inferior.{h,cc}
2680
2681 2020-05-23  Tom Tromey  <tom@tromey.com>
2682
2683         Revert commit eca1f90c:
2684         * NEWS: Remove entry for completion styling.
2685         * completer.c (_rl_completion_prefix_display_length): Move
2686         declaration later.
2687         (gdb_fnprint): Revert.
2688         (gdb_display_match_list_1): Likewise.
2689         * cli/cli-style.c (completion_prefix_style)
2690         (completion_difference_style, completion_suffix_style): Remove.
2691         (_initialize_cli_style): Revert.
2692         * cli/cli-style.h (completion_prefix_style)
2693         (completion_difference_style, completion_suffix_style): Don't
2694         declare.
2695
2696 2020-05-24  Pedro Alves  <palves@redhat.com>
2697
2698         * symtab.c (completion_list_add_name): Return boolean indication
2699         of whether the symbol matched.
2700         (completion_list_add_symbol): Don't try to remove C++ aliases if
2701         the symbol didn't match in the first place.
2702         * symtab.h (completion_list_add_name): Return bool.
2703
2704 2020-05-23  Simon Marchi  <simon.marchi@polymtl.ca>
2705
2706         * gdbtypes.h (TYPE_FIELD): Remove.  Replace all uses with
2707         type::field.
2708
2709 2020-05-23  Joel Brobecker  <brobecker@adacore.com>
2710
2711         GDB 9.2 released.
2712
2713 2020-05-23  Tom Tromey  <tom@tromey.com>
2714
2715         * NEWS: Add entry for completion styling.
2716         * completer.c (_rl_completion_prefix_display_length): Move
2717         declaration earlier.
2718         (gdb_fnprint): Use completion_style.
2719         (gdb_display_match_list_1): Likewise.
2720         * cli/cli-style.c (completion_prefix_style)
2721         (completion_difference_style, completion_suffix_style): New
2722         globals.
2723         (_initialize_cli_style): Register new globals.
2724         * cli/cli-style.h (completion_prefix_style)
2725         (completion_difference_style, completion_suffix_style): Declare.
2726
2727 2020-05-23  Pedro Alves  <palves@redhat.com>
2728
2729         * utils.c: Include "gdbsupport/gdb-safe-ctype.h".
2730         (parse_escape): Use ISDIGIT instead of isdigit.
2731         (puts_debug): Use gdb_isprint instead of isprint.
2732         (fprintf_symbol_filtered): Use ISALNUM instead of isalnum.
2733         (cp_skip_operator_token, skip_ws, strncmp_iw_with_mode): Use
2734         ISSPACE instead of isspace.
2735         (strncmp_iw_with_mode): Use TOLOWER instead of tolower and ISSPACE
2736         instead of isspace.
2737         (strcmp_iw_ordered): Use ISSPACE instead of isspace.
2738         (string_to_core_addr): Use TOLOWER instead of tolower, ISXDIGIT
2739         instead of isxdigit and ISDIGIT instead of isdigit.
2740
2741 2020-05-22  Simon Marchi  <simon.marchi@efficios.com>
2742
2743         * gdbtypes.h (struct type) <field>: New method.
2744         (TYPE_FIELDS): Remove, replace all uses with either type::fields
2745         or type::field.
2746
2747 2020-05-22  Simon Marchi  <simon.marchi@efficios.com>
2748
2749         * gdbtypes.h (struct type) <fields, set_fields>: New methods.
2750         (TYPE_FIELDS): Use type::fields.  Change all call sites that
2751         modify the propery to use type::set_fields instead.
2752
2753 2020-05-22  Simon Marchi  <simon.marchi@efficios.com>
2754
2755         * gdbtypes.h (TYPE_NFIELDS): Remove.  Change all cal sites to use
2756         type::num_fields instead.
2757
2758 2020-05-22  Simon Marchi  <simon.marchi@efficios.com>
2759
2760         * gdbtypes.h (struct type) <num_fields, set_num_fields>: New
2761         methods.
2762         (TYPE_NFIELDS): Use type::num_fields.  Change all call sites
2763         that modify the number of fields to use type::set_num_fields
2764         instead.
2765
2766 2020-05-22  Tom Tromey  <tromey@adacore.com>
2767
2768         * compile/compile-object-load.h (munmap_list_free): Don't
2769         declare.
2770
2771 2020-05-22  Andrew Burgess  <andrew.burgess@embecosm.com>
2772
2773         * annotate.c (annotate_source_line): Update return type, add call
2774         to update current symtab and line.
2775         * annotate.h (annotate_source_line): Update return type, and
2776         extend header comment.
2777         * source.c (info_line_command): Check annotation_level before
2778         calling annotate_source_line.
2779         * stack.c (print_frame_info): If calling annotate_source_line
2780         returns true, then don't print any other source line information.
2781
2782 2020-05-21  Simon Marchi  <simon.marchi@efficios.com>
2783
2784         * lm32-tdep.c (lm32_register_reggroup_p): Fix condition.
2785
2786 2020-05-21  Simon Marchi  <simon.marchi@efficios.com>
2787
2788         * coffread.c (patch_type): Remove NULL check before xfree.
2789         * corefile.c (set_gnutarget): Likewise.
2790         * cp-abi.c (set_cp_abi_as_auto_default): Likewise.
2791         * exec.c (build_section_table): Likewise.
2792         * remote.c (remote_target::pass_signals): Likewise.
2793         * utils.c (n_spaces): Likewise.
2794         * cli/cli-script.c (document_command): Likewise.
2795         * i386-windows-tdep.c (core_process_module_section): Likewise.
2796         * linux-fork.c (struct fork_info) <~fork_info>: Likewise.
2797
2798 2020-05-20  Simon Marchi  <simon.marchi@efficios.com>
2799
2800         * symfile.c (reread_symbols): Clear objfile's section_offsets
2801         vector and section indices, re-compute them by calling
2802         sym_offsets.
2803
2804 2020-05-20  Tom Tromey  <tromey@adacore.com>
2805
2806         * ada-lang.c (bound_name, MAX_ADA_DIMENS): Remove.
2807         (desc_one_bound, desc_index_type): Compute field name.
2808
2809 2020-05-20  Tom de Vries  <tdevries@suse.de>
2810
2811         PR symtab/25833
2812         * dwarf2/read.c (dw2_map_matching_symbols): Handle .gdb_index.
2813
2814 2020-05-20  Alan Modra  <amodra@gmail.com>
2815
2816         PR 25993
2817         * solib-darwin.c (darwin_bfd_open): Don't strdup pathname for
2818         bfd_set_filename.
2819         * solib-aix.c (solib_aix_bfd_open): Use std::string for name
2820         passed to bfd_set_filename.
2821         * symfile-mem.c (add_vsyscall_page): Likewise for string
2822         passed to symbol_file_add_from_memory.
2823         (symbol_file_add_from_memory): Make name param a const char* and
2824         don't strdup.
2825
2826 2020-05-20  Alan Modra  <amodra@gmail.com>
2827
2828         * coff-pe-read.c (read_pe_exported_syms): Use bfd_get_filename
2829         rather than accessing bfd->filename directly.
2830         * dtrace-probe.c (dtrace_static_probe_ops::get_probes): Likewise,
2831         and use bfd_section_name.
2832         * dwarf2/frame.c (decode_frame_entry): Likewise.
2833         * exec.c (exec_set_section_address): Likewise.
2834         * solib-aix.c (solib_aix_bfd_open): Likewise.
2835         * stap-probe.c (get_stap_base_address): Likewise.
2836         * symfile.c (reread_symbols): Likewise.
2837
2838 2020-05-19  Tom Tromey  <tromey@adacore.com>
2839
2840         * sparc64-tdep.c (adi_tag_fd): Update call to target_fileio_open.
2841
2842 2020-05-19  Simon Marchi  <simon.marchi@efficios.com>
2843
2844         * dwarf2/read.c (quirk_rust_enum): Allocate enough fields.
2845
2846 2020-05-19  Pedro Alves  <palves@redhat.com>
2847
2848         * NEWS (set exec-file-mismatch): Adjust entry.
2849         * exec.c: Include "build-id.h".
2850         (validate_exec_file): Try to match build IDs instead of filenames.
2851         * gdb_bfd.c (struct gdb_bfd_open_closure): New.
2852         (gdb_bfd_iovec_fileio_open): Adjust to use gdb_bfd_open_closure
2853         and pass down 'warn_if_slow'.
2854         (gdb_bfd_open): Add 'warn_if_slow' parameter.  Use
2855         gdb_bfd_open_closure to pass it down.
2856         * gdb_bfd.h (gdb_bfd_open): Add 'warn_if_slow' parameter.
2857
2858 2020-05-19  Pedro Alves  <palves@redhat.com>
2859
2860         * gdb_bfd.c (gdb_bfd_iovec_fileio_open): Adjust.
2861         * target.c (target_fileio_open_1): Rename to target_fileio_open
2862         and make extern.  Use bool.
2863         (target_fileio_open, target_fileio_open_warn_if_slow): Delete.
2864         (target_fileio_read_alloc_1): Adjust.
2865         * target.h (target_fileio_open): Add 'warn_if_slow' parameter.
2866         (target_fileio_open_warn_if_slow): Delete declaration.
2867
2868 2020-05-19  Pedro Alves  <palves@redhat.com>
2869
2870         * gdb_bfd.h: (gdb_bfd_open): Default to 'fd' parameter to -1.
2871         Adjust all callers.
2872
2873 2020-05-19  Yoshinori Sato  <ysato@users.sourceforge.jp>
2874
2875         * h8300-tdep.c (h8300_is_argument_spill): Change how we check
2876         whether disp is negative.
2877
2878 2020-05-19  Simon Marchi  <simon.marchi@efficios.com>
2879
2880         * symfile.h (struct symfile_segment_data)
2881         <~symfile_segment_data>: Remove.
2882         <segment_info>: Change to std::vector.
2883         * symfile.c (default_symfile_segments): Update.
2884         * elfread.c (elf_symfile_segments): Update.
2885
2886 2020-05-19  Simon Marchi  <simon.marchi@efficios.com>
2887
2888         * symfile.h (struct symfile_segment_data) <struct segment>: New.
2889         <segments>: New.
2890         <segment_bases, segment_sizes>: Remove.
2891         * symfile.c (default_symfile_segments): Update.
2892         * elfread.c (elf_symfile_segments): Update.
2893         * remote.c (remote_target::get_offsets): Update.
2894         * solib-target.c (solib_target_relocate_section_addresses):
2895         Update.
2896
2897 2020-05-19  Simon Marchi  <simon.marchi@efficios.com>
2898
2899         * symfile.h (struct symfile_segment_data): Initialize fields.
2900         <~symfile_segment_data>: Add.
2901         (symfile_segment_data_up): New.
2902         (struct sym_fns) <sym_segments>: Return a
2903         symfile_segment_data_up.
2904         (default_symfile_segments): Return a symfile_segment_data_up.
2905         (free_symfile_segment_data): Remove.
2906         (get_symfile_segment_data): Return a symfile_segment_data_up.
2907         * symfile.c (default_symfile_segments): Likewise.
2908         (get_symfile_segment_data): Likewise.
2909         (free_symfile_segment_data): Remove.
2910         (symfile_find_segment_sections): Update.
2911         * elfread.c (elf_symfile_segments): Return a
2912         symfile_segment_data_up.
2913         * remote.c (remote_target::get_offsets): Update.
2914         * solib-target.c (solib_target_relocate_section_addresses):
2915         Update.
2916         * symfile-debug.c (debug_sym_segments): Return a
2917         symfile_segment_data_up.
2918
2919 2020-05-18  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
2920
2921         PR build/25981
2922         * i386-sol2-nat.c [PR_MODEL_NATIVE != PR_MODEL_LP64] (regmap):
2923         Hardcode register numbers.
2924
2925         PR build/25981
2926         * procfs.c [(__i386__ || __x86_64__) && sun] (proc_get_LDT_entry,
2927         procfs_find_LDT_entry): Remove.
2928         * procfs.h [(__i386__ || __x86_64__) && sun] (struct ssd,
2929         procfs_find_LDT_entry): Remove.
2930         * sol-thread.c [(__i386__ || __x86_64__) && sun] (ps_lgetLDT):
2931         Remove.
2932
2933 2020-05-17  Pedro Alves  <palves@redhat.com>
2934             Andrew Burgess  <andrew.burgess@embecosm.com>
2935             Keno Fischer  <keno@juliacomputing.com>
2936
2937         PR gdb/25741
2938         * breakpoint.c (build_target_condition_list): Update comments.
2939         (build_target_command_list): Update comments and skip matching
2940         locations.
2941         (insert_bp_location): Move "set breakpoint auto-hw on" handling to
2942         a separate function.  Simplify "set breakpoint auto-hw off"
2943         handling.
2944         (insert_breakpoints): Update comment.
2945         (tracepoint_locations_match): New parameter.  For breakpoints,
2946         compare location types too, if the caller wants to.
2947         (handle_automatic_hardware_breakpoints): New functions.
2948         (bp_location_is_less_than): Also sort by location type and
2949         hardware breakpoint length.
2950         (update_global_location_list): Handle "set breakpoint auto-hw on"
2951         here.
2952         (update_breakpoint_locations): Ask breakpoint_locations_match to
2953         ignore location types.
2954
2955 2020-05-16  Simon Marchi  <simon.marchi@efficios.com>
2956
2957         * gdbtypes.h (TYPE_NAME): Remove.  Change all cal sites to use
2958         type::name instead.
2959
2960 2020-05-16  Simon Marchi  <simon.marchi@efficios.com>
2961
2962         * gdbtypes.h (struct type) <name, set_name>: New methods.
2963         (TYPE_CODE): Use type::name.  Change all call sites used to set
2964         the name to use type::set_name instead.
2965
2966 2020-05-16  Tom Tromey  <tom@tromey.com>
2967
2968         * top.c (quit_force): Update.
2969         * infrun.c (handle_no_resumed): Update.
2970         * top.h (all_uis): New function.
2971         (ALL_UIS): Remove.
2972
2973 2020-05-16  Simon Marchi  <simon.marchi@efficios.com>
2974
2975         * mips-linux-tdep.c (mips_linux_in_dynsym_stub): Fix condition.
2976
2977 2020-05-16  Pedro Alves  <palves@redhat.com>
2978
2979         * ia64-linux-nat.c
2980         (ia64_linux_nat_target) <enable_watchpoints_in_psr(ptid_t)>:
2981         Declare method.
2982         (enable_watchpoints_in_psr): Now a method of ia64_linux_nat_target.
2983
2984 2020-05-15  Simon Marchi  <simon.marchi@efficios.com>
2985
2986         * sparc64-tdep.c (adi_stat_t): Remove typedef (leaving struct).
2987         (sparc64_adi_info): Likewise.
2988
2989 2020-05-15  Tom Tromey  <tom@tromey.com>
2990
2991         * symtab.c (lookup_language_this, lookup_symbol_aux): Use
2992         block_objfile.
2993         (lookup_objfile_from_block): Remove.
2994         (lookup_symbol_in_block, lookup_symbol_in_static_block)
2995         (lookup_global_symbol): Use block_objfile.
2996         * symtab.h (lookup_objfile_from_block): Don't declare.
2997         * printcmd.c (clear_dangling_display_expressions): Use
2998         block_objfile.
2999         * parse.c (operator_check_standard): Use block_objfile.
3000
3001 2020-05-15  Tom Tromey  <tom@tromey.com>
3002
3003         * language.c (language_alloc_type_symbol): Set
3004         SYMBOL_SECTION.
3005         * symtab.c (initialize_objfile_symbol): Remove.
3006         (allocate_symbol): Remove.
3007         (allocate_template_symbol): Remove.
3008         * dwarf2/read.c (fixup_go_packaging): Use "new".
3009         (new_symbol): Use "new".
3010         (read_variable): Don't call initialize_objfile_symbol.  Use
3011         "new".
3012         (read_func_scope): Use "new".
3013         * xcoffread.c (process_xcoff_symbol): Don't call
3014         initialize_objfile_symbol.
3015         (SYMBOL_DUP): Remove.
3016         * coffread.c (process_coff_symbol, coff_read_enum_type): Use
3017         "new".
3018         * symtab.h (allocate_symbol, initialize_objfile_symbol)
3019         (allocate_template_symbol): Don't declare.
3020         (struct symbol): Add copy constructor.  Change defaults.
3021         * jit.c (finalize_symtab): Use "new".
3022         * ctfread.c (ctf_add_enum_member_cb, new_symbol, ctf_add_var_cb):
3023         Use "new".
3024         * stabsread.c (patch_block_stabs, define_symbol, read_enum_type)
3025         (common_block_end): Use "new".
3026         * mdebugread.c (parse_symbol): Use "new".
3027         (new_symbol): Likewise.
3028
3029 2020-05-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3030
3031         * NEWS: Mention changes to help and apropos.
3032
3033 2020-05-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3034
3035         * command.h (enum command_class): Improve comments, document
3036         that class_alias is for user-defined aliases, give the class
3037         name for each class, remove unused class_xdb.
3038         * cli/cli-decode.c (add_com_alias): Document THECLASS intended usage.
3039         * breakpoint.c (_initialize_breakpoint): Replace class_alias
3040         by a precise class.
3041         * infcmd.c (_initialize_infcmd): Likewise.
3042         * reverse.c (_initialize_reverse): Likewise.
3043         * stack.c (_initialize_stack): Likewise.
3044         * symfile.c (_initialize_symfile): Likewise.
3045         * tracepoint.c (_initialize_tracepoint): Likewise.
3046
3047 2020-05-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3048
3049         * cli/cli-decode.c (apropos_cmd): Produce output for aliases
3050         when their aliased command is traversed.
3051         (help_cmd): Add fput_command_names_styled call to
3052         output command name and aliases when command has an alias.
3053
3054 2020-05-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3055
3056         * cli/cli-decode.h (help_cmd_list): Remove declaration.
3057         * cli/cli-decode.c (help_cmd_list): Declare as static,
3058         remove prefix argument, use bool for recurse arg, rework to show the aliases of
3059         a command together with the command.
3060         (fput_command_name_styled, fput_command_names_styled): New functions.
3061         (print_help_for_command): Remove prefix arg, use bool for recurse arg, use
3062         fput_command_name_styled.
3063         (help_list, help_all): Update callers to remove prefix arg and use bool recurse.
3064         * cli/cli-cmds.c (_initialize_cli_cmds): Update alias_command doc.
3065
3066 2020-05-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3067
3068         * cli/cli-setshow.h (cmd_show_list): Remove prefix argument.
3069         * cli/cli-decode.c (do_show_prefix_cmd): Likewise.
3070         * command.h (cmd_show_list): Likewise.
3071         * dwarf2/index-cache.c (show_index_cache_command): Likewise.
3072         * cli/cli-setshow.c (cmd_show_list): Use the prefix to produce the output.  Skip aliases.
3073
3074 2020-05-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3075
3076         * unittests/command-def-selftests.c (traverse_command_structure):
3077         Verify all commands of a list have the same prefix command and
3078         that only the top cmdlist commands have a null prefix.
3079
3080 2020-05-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3081
3082         * cli/cli-decode.c (lookup_cmd_for_prefix): Return the aliased command
3083         as prefix, not one of its aliases.
3084         (set_cmd_prefix): Remove.
3085         (do_add_cmd): Centralize the setting of the prefix of a command, when
3086         command is defined after its full chain of prefix commands.
3087         (add_alias_cmd): Remove call to set_cmd_prefix, as do_add_cmd does it.
3088         (add_setshow_cmd_full): Likewise.
3089         (update_prefix_field_of_prefixed_commands): New function.
3090         (add_prefix_cmd): Replace non working call to set_cmd_prefix by
3091         update_prefix_field_of_prefixed_commands.
3092         * gdb/remote-fileio.c (initialize_remote_fileio): Use the real
3093         addresses of remote_set_cmdlist and remote_show_cmdlist given
3094         as argument, not the address of an argument.
3095         * gdb/remote-fileio.h (initialize_remote_fileio): Likewise.
3096         * gdb/remote.c (_initialize_remote): Likewise.
3097
3098 2020-05-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3099
3100         * cli/cli-cmds.c (alias_command): Check for an existing alias
3101         using lookup_cmd_composition, as valid_command_p is too strict
3102         and forbids aliases that are the prefix of an existing alias
3103         or command.
3104         * cli/cli-decode.c (lookup_cmd_composition): Ensure a prefix
3105         command is properly recognised as a valid command.
3106
3107 2020-05-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3108
3109         * unittests/help-doc-selftests.c: Rename to
3110         unittests/command-def-selftests.c
3111         * unittests/command-def-selftests.c (help_doc_tests): Update some
3112         comments.
3113         (command_structure_tests, traverse_command_structure): New namespace
3114         and function.
3115         (command_structure_invariants_tests): New function.
3116         (_initialize_command_def_selftests) Renamed from
3117         _initialize_help_doc_selftests, register command_structure_invariants
3118         selftest.
3119
3120 2020-05-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3121
3122         * cli/cli-cmds.c (_initialize_cli_cmds): Define 'info set' as
3123         an alias of 'show'.
3124
3125 2020-05-15  Joel Brobecker  <brobecker@adacore.com>
3126
3127         * ada-lang.h: (ada_is_gnat_encoded_fixed_point_type): Renames
3128         ada_is_fixed_point_type.  Update all callers.
3129         (gnat_encoded_fixed_point_delta): Renames ada_delta.  Update
3130         all callers.
3131         * ada-lang.c (gnat_encoded_fixed_type_info): Renames fixed_type_info.
3132         Update all callers.
3133         * ada-typeprint.c (print_gnat_encoded_fixed_point_type): Renames
3134         print_fixed_point_type.  Update all callers.
3135         * ada-valprint.c (ada_value_print_num): Replace call to
3136         ada_is_fixed_point_type by ada_is_gnat_encoded_fixed_point_type.
3137
3138 2020-05-14  Kevin Buettner  <kevinb@redhat.com>
3139
3140         * nat/linux-btrace.c (btrace_this_cpu): Add check for AMD
3141         processors.
3142         (cpu_supports_bts): Add CV_AMD case.
3143
3144 2020-05-14  Laurent Morichetti  <Laurent.Morichetti@amd.com>
3145             Simon Marchi  <simon.marchi@efficios.com>
3146
3147         * infrun.c (stop_all_threads): Collect multiple wait events at
3148         each pass.
3149
3150 2020-05-14  Simon Marchi  <simon.marchi@efficios.com>
3151
3152         * gdbtypes.h (TYPE_CODE): Remove.  Change all call sites to use
3153         type::code instead.
3154
3155 2020-05-14  Simon Marchi  <simon.marchi@efficios.com>
3156
3157         * gdbtypes.h (struct type) <code, set_code>: New methods.
3158         (TYPE_CODE): Use type::code.  Change all call sites used to set
3159         the code to use type::set_code instead.
3160
3161 2020-05-14  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
3162             Tom de Vries  <tdevries@suse.de>
3163             Pedro Alves  <palves@redhat.com>
3164
3165         PR threads/25478
3166         * infrun.c (stop_all_threads): Do NOT ignore
3167         TARGET_WAITKIND_NO_RESUMED, TARGET_WAITKIND_THREAD_EXITED,
3168         TARGET_WAITKIND_EXITED, TARGET_WAITKIND_SIGNALLED wait statuses
3169         received.
3170         (handle_no_resumed): Remove code handling a live inferior with no
3171         threads.
3172         * remote.c (has_single_non_exited_thread): New.
3173         (remote_target::update_thread_list): Do not delete a thread if is
3174         the last thread of the process.
3175         * thread.c (thread_select): Call delete_exited_threads instead of
3176         prune_threads.
3177
3178 2020-05-14  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
3179
3180         * infrun.c (stop_all_threads): Enable/disable thread events of all
3181         targets.  Move a debug message denoting the end of the function
3182         into the SCOPED_EXIT block.
3183
3184 2020-05-14  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
3185
3186         * process-stratum-target.h: Include <set>.
3187         (all_non_exited_process_targets, switch_to_target_no_thread): New
3188         function declarations.
3189         * process-stratum-target.c (all_non_exited_process_targets)
3190         (switch_to_target_no_thread): New function implementations.
3191
3192 2020-05-14  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
3193
3194         * infrun.c (handle_inferior_event): Extract out a piece of code
3195         into...
3196         (mark_non_executing_threads): ...this new function.
3197
3198 2020-05-14  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
3199
3200         * infrun.c (resume_1): Move a 'regcache_read_pc' call down to first
3201         use.
3202
3203 2020-05-14  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
3204
3205         * regcache.c (regcache_read_pc_protected): New function
3206         implementation that returns 0 if the PC cannot read via
3207         'regcache_read_pc'.
3208         * infrun.c (proceed): Call 'regcache_read_pc_protected'
3209         instead of 'regcache_read_pc'.
3210         (keep_going_pass_signal): Ditto.
3211
3212 2020-05-13  Tom Tromey  <tromey@adacore.com>
3213
3214         * ada-lang.c (align_value): Remove.
3215         (ada_template_to_fixed_record_type_1): Use align_up.
3216
3217 2020-05-13  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
3218
3219         * async-event.c: Update the copyright year.
3220         * async-event.h: Update the copyright year.
3221
3222 2020-05-12  Simon Marchi  <simon.marchi@efficios.com>
3223
3224         * objfiles.h (is_addr_in_objfile,
3225         shared_objfile_contains_address_p): Return bool.
3226         * objfile.c (is_addr_in_objfile,
3227         shared_objfile_contains_address_p): Return bool.
3228
3229 2020-05-11  Tom Tromey  <tromey@adacore.com>
3230
3231         * cli/cli-cmds.c (info_command): Restore.
3232         (_initialize_cli_cmds): Use add_prefix_command for "info".
3233         * gdb-gdb.gdb.in: Restore breakpoint on info_command.
3234
3235 2020-05-11  Tom Tromey  <tromey@adacore.com>
3236
3237         * ada-lang.c (ada_value_primitive_field): Now public.
3238         * ada-lang.h (ada_value_primitive_field): Declare.
3239         * ada-valprint.c (print_field_values): Use
3240         ada_value_primitive_field for wrapper fields.
3241
3242 2020-05-11  Tom de Vries  <tdevries@suse.de>
3243
3244         * dwarf2/index-write.c (debug_names::psymbol_tag): Handle
3245         MODULE_DOMAIN.
3246
3247 2020-05-11  Tom de Vries  <tdevries@suse.de>
3248
3249         PR symtab/25941
3250         * dwarf2/read.c (create_cus_from_debug_names_list): Initialize CUs
3251         with length 0, if not gdb-produced.
3252         (cutu_reader::cutu_reader): Set CU length to actual length if 0.
3253
3254 2020-05-09  Tom de Vries  <tdevries@suse.de>
3255
3256         PR gdb/25955
3257         * break-catch-throw.c (check_status_exception_catchpoint): Fix name
3258         calculation.
3259
3260 2020-05-09  Tom Tromey  <tom@tromey.com>
3261
3262         * top.c (server_command): Now bool.
3263         * top.h (server_command): Now bool.
3264
3265 2020-05-08  Tom Tromey  <tromey@adacore.com>
3266
3267         * dwarf2/read.c (read_lexical_block_scope): Don't process a DIE
3268         already being processed.
3269
3270 2020-05-08  Tom Tromey  <tom@tromey.com>
3271
3272         * printcmd.c (struct display) <next>: Remove.
3273         <display>: New constructor.
3274         <exp_string>: Now a std::string.
3275         <enabled_p>: Now a bool.
3276         (display_number): Move definition earlier.
3277         (displays): Rename from display_chain.  Now a std::vector.
3278         (ALL_DISPLAYS, ALL_DISPLAYS_SAFE): Remove.
3279         (display_command): Update.
3280         (do_one_display, disable_display)
3281         (enable_disable_display_command, do_enable_disable_display):
3282         Update.
3283         (free_display): Remove.
3284         (clear_displays): Rewrite.
3285         (delete_display): Update.
3286         (map_display_numbers): Use function_view.  Remove "data"
3287         parameter.  Update.
3288         (do_delete_display): Remove.
3289         (undisplay_command): Update.
3290         (do_one_display, do_displays, disable_display)
3291         (info_display_command): Update.
3292         (do_enable_disable_display): Remove.
3293         (enable_disable_display_command)
3294         (clear_dangling_display_expressions): Update.
3295
3296 2020-05-08  Tom Tromey  <tom@tromey.com>
3297
3298         * symtab.c (set_symbol_cache_size)
3299         (maintenance_print_symbol_cache, maintenance_flush_symbol_cache)
3300         (maintenance_print_symbol_cache_statistics): Update.
3301         * symmisc.c (print_symbol_bcache_statistics)
3302         (print_objfile_statistics, maintenance_print_objfiles)
3303         (maintenance_info_symtabs, maintenance_check_symtabs)
3304         (maintenance_expand_symtabs, maintenance_info_line_tables):
3305         Update.
3306         * symfile-debug.c (set_debug_symfile): Update.
3307         * source.c (forget_cached_source_info): Update.
3308         * python/python.c (gdbpy_progspaces): Update.
3309         * psymtab.c (maintenance_info_psymtabs): Update.
3310         * probe.c (parse_probes): Update.
3311         * linespec.c (iterate_over_all_matching_symtabs)
3312         (collect_symtabs_from_filename, search_minsyms_for_name): Update.
3313         * guile/scm-progspace.c (gdbscm_progspaces): Update.
3314         * exec.c (exec_target::close): Update.
3315         * ada-tasks.c (ada_tasks_new_objfile_observer): Update.
3316         * breakpoint.c (print_one_breakpoint_location)
3317         (create_longjmp_master_breakpoint)
3318         (create_std_terminate_master_breakpoint): Update.
3319         * progspace.c (program_spaces): Now a std::vector.
3320         (maybe_new_address_space): Update.
3321         (add_program_space): Remove.
3322         (program_space::program_space): Update.
3323         (remove_program_space): Update.
3324         (number_of_program_spaces): Remove.
3325         (print_program_space, update_address_spaces): Update.
3326         * progspace.h (program_spaces): Change type.
3327         (ALL_PSPACES): Remove.
3328         (number_of_program_spaces): Don't declare.
3329         (struct program_space) <next>: Remove.
3330
3331 2020-05-08  Tom Tromey  <tom@tromey.com>
3332
3333         * mi/mi-cmd-file.c (mi_cmd_file_list_shared_libraries): Update.
3334         * solib-svr4.c (svr4_fetch_objfile_link_map): Update.
3335         (enable_break): Update.
3336         * solib-frv.c (frv_fdpic_find_global_pointer): Update.
3337         (frv_fdpic_find_canonical_descriptor): Update.
3338         (frv_fetch_objfile_link_map): Update.
3339         * progspace.c (program_space::free_all_objfiles): Update.
3340         (program_space::solibs): New method.
3341         * progspace.h (struct program_space) <solibs>: New method.
3342         * solist.h (master_so_list): Don't declare.
3343         (ALL_SO_LIBS): Remove.
3344         * solib.h (so_list_head): Remove.
3345         (update_solib_list): Update comment.
3346         * solib.c (master_so_list): Remove.
3347         (solib_used, update_solib_list, solib_add)
3348         (info_sharedlibrary_command, clear_solib)
3349         (reload_shared_libraries_1, remove_user_added_objfile): Update.
3350
3351 2020-05-08  Tom Tromey  <tom@tromey.com>
3352
3353         * extension.c (extension_languages): Now a std::array.
3354         (ALL_EXTENSION_LANGUAGES): Remove.
3355         (get_ext_lang_defn, get_ext_lang_of_file)
3356         (eval_ext_lang_from_control_command): Update.
3357         (finish_ext_lang_initialization)
3358         (auto_load_ext_lang_scripts_for_objfile)
3359         (ext_lang_type_printers::ext_lang_type_printers)
3360         (apply_ext_lang_type_printers)
3361         (ext_lang_type_printers::~ext_lang_type_printers)
3362         (apply_ext_lang_val_pretty_printer, apply_ext_lang_frame_filter)
3363         (preserve_ext_lang_values, get_breakpoint_cond_ext_lang)
3364         (breakpoint_ext_lang_cond_says_stop, check_quit_flag)
3365         (get_matching_xmethod_workers, ext_lang_colorize)
3366         (ext_lang_before_prompt): Update.
3367         (ALL_ENABLED_EXTENSION_LANGUAGES): Remove.
3368
3369 2020-05-08  Tom Tromey  <tom@tromey.com>
3370
3371         * symtab.h (class demangle_result_storage) <set_malloc_ptr>: New
3372         overload.
3373         <swap_string, m_string>: Remove.
3374         * symtab.c (demangle_for_lookup, completion_list_add_symbol):
3375         Update.
3376         * stabsread.c (define_symbol, read_type): Update.
3377         * linespec.c (find_linespec_symbols): Update.
3378         * gnu-v3-abi.c (gnuv3_get_typeid): Update.
3379         * dwarf2/read.c (dwarf2_canonicalize_name): Update.
3380         * dbxread.c (read_dbx_symtab): Update.
3381         * cp-support.h (cp_canonicalize_string_full)
3382         (cp_canonicalize_string, cp_canonicalize_string_no_typedefs):
3383         Return unique_xmalloc_ptr.
3384         * cp-support.c (inspect_type): Update.
3385         (cp_canonicalize_string_full): Return unique_xmalloc_ptr.
3386         (cp_canonicalize_string_no_typedefs, cp_canonicalize_string):
3387         Likewise.
3388         * c-typeprint.c (print_name_maybe_canonical): Update.
3389         * break-catch-throw.c (check_status_exception_catchpoint):
3390         Update.
3391
3392 2020-05-08  Tom de Vries  <tdevries@suse.de>
3393
3394         * infrun.c (follow_fork): Copy current_line and current_symtab to
3395         child thread.
3396
3397 2020-05-07  Simon Marchi  <simon.marchi@efficios.com>
3398
3399         * async-event.c (struct async_signal_handler, struct
3400         async_event_handler): Reformat, remove typedef.
3401
3402 2020-05-07  Simon Marchi  <simon.marchi@efficios.com>
3403
3404         * gdbtypes.h (TYPE_DYN_PROP_LIST): Remove.  Update all users
3405         access thistype->main_type->dyn_prop_list directly.
3406
3407 2020-05-07  Simon Marchi  <simon.marchi@efficios.com>
3408
3409         * gdbtypes.h (struct type) <remove_dyn_prop>: New method.
3410         (remove_dyn_prop): Remove.  Update all users to use
3411         type::remove_dyn_prop.
3412         * gdbtypes.c (remove_dyn_prop): Rename to...
3413         (type::remove_dyn_prop): ... this.
3414
3415 2020-05-07  Simon Marchi via Gdb-patches  <gdb-patches@sourceware.org>
3416
3417         * gdbtypes.h (struct type) <add_dyn_prop>: New method.
3418         (add_dyn_prop): Remove.  Update all users to use
3419         type::add_dyn_prop.
3420         * gdbtypes.c (add_dyn_prop): Rename to...
3421         (type::add_dyn_prop): ... this.
3422
3423 2020-05-07  Simon Marchi  <simon.marchi@efficios.com>
3424
3425         * gdbtypes.h (struct type) <get_dyn_prop>: New method.
3426         (get_dyn_prop): Remove.  Update all users to use
3427         type::dyn_prop.
3428         * gdbtypes.c (get_dyn_prop): Rename to...
3429         (type::dyn_prop): ... this.
3430
3431 2020-05-06  Simon Marchi  <simon.marchi@efficios.com>
3432
3433         * gdbtypes.h (struct main_type) <flag_static>: Remove.
3434
3435 2020-05-06  Simon Marchi  <simon.marchi@efficios.com>
3436
3437         * amd64-tdep.c (amd64_analyze_prologue): Check for `endbr64`
3438         instruction, skip it if it's there.
3439
3440 2020-05-05  Simon Marchi  <simon.marchi@efficios.com>
3441
3442         * gdbtypes.h (struct main_type) <flag_incomplete>: Remove.
3443
3444 2020-05-04  Simon Marchi  <simon.marchi@efficios.com>
3445
3446         * gdbtypes.h (TYPE_INCOMPLETE): Remove.
3447         * gdbtypes.c (recursive_dump_type): Remove use of
3448         TYPE_INCOMPLETE.
3449
3450 2020-05-03  Tom Tromey  <tom@tromey.com>
3451
3452         * breakpoint.c (catch_command, tcatch_command): Remove.
3453         (_initialize_breakpoint): Use add_basic_prefix_cmd,
3454         add_show_prefix_cmd.
3455         (set_breakpoint_cmd, show_breakpoint_cmd): Remove
3456         * utils.c (set_internal_problem_cmd, show_internal_problem_cmd):
3457         Remove.
3458         (add_internal_problem_command): Use add_basic_prefix_cmd,
3459         add_show_prefix_cmd.
3460         * mips-tdep.c (set_mipsfpu_command): Remove.
3461         (_initialize_mips_tdep): Use add_basic_prefix_cmd.
3462         * dwarf2/index-cache.c (set_index_cache_command): Remove.
3463         (_initialize_index_cache): Use add_basic_prefix_cmd.
3464         * memattr.c (dummy_cmd): Remove.
3465         (_initialize_mem): Use add_basic_prefix_cmd, add_show_prefix_cmd.
3466         * tui/tui-win.c (set_tui_cmd, show_tui_cmd): Remove.
3467         (_initialize_tui_win): Use add_basic_prefix_cmd,
3468         add_show_prefix_cmd.
3469         * cli/cli-logging.c (set_logging_command): Remove.
3470         (_initialize_cli_logging): Use add_basic_prefix_cmd,
3471         add_show_prefix_cmd.
3472         (show_logging_command): Remove.
3473         * target.c (target_command): Remove.
3474         (add_target): Use add_basic_prefix_cmd.
3475
3476 2020-05-02  Hannes Domani  <ssbssa@yahoo.de>
3477
3478         * gdbtypes.h (enum dynamic_prop_node_kind): Fix typo.
3479
3480 2020-05-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3481
3482         * gdb-gdb.gdb-in: Remove breakpoint on disappeared function
3483         info_command.
3484
3485 2020-04-30  Kamil Rytarowski  <n54@gmx.com>
3486
3487         * nbsd-nat.c (nbsd_enable_proc_events)
3488         (nbsd_nat_target::post_startup_inferior): Add.
3489         (nbsd_nat_target::post_attach): Call `nbsd_enable_proc_events'.
3490         (nbsd_nat_target::update_thread_list): Rewrite.
3491         (nbsd_nat_target::wait): Handle "PTRACE_LWP_EXIT" and
3492         "PTRACE_LWP_CREATE".
3493         * nbsd-nat.h (nbsd_nat_target::post_startup_inferior): Add.
3494
3495 2020-04-30  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3496
3497         * stack.c (_initialize_stack): Remove duplicated creation
3498         of "frame" command and "f" alias.
3499
3500 2020-04-30  Hannes Domani  <ssbssa@yahoo.de>
3501
3502         PR gdb/18706
3503         * gdbtypes.c (check_typedef): Calculate size of array of
3504         stubbed type.
3505
3506 2020-04-30  Hannes Domani  <ssbssa@yahoo.de>
3507
3508         PR gdb/15559
3509         * i386-tdep.c (i386_push_dummy_call): Call
3510         i386_thiscall_push_dummy_call.
3511         (i386_thiscall_push_dummy_call): New function.
3512         * i386-tdep.h (i386_thiscall_push_dummy_call): Declare.
3513         * i386-windows-tdep.c (i386_windows_push_dummy_call): New function.
3514         (i386_windows_init_abi): Call set_gdbarch_push_dummy_call.
3515
3516 2020-04-29  Simon Marchi  <simon.marchi@efficios.com>
3517
3518         * gdbarch.sh (do_read): Add shellcheck disable directive for
3519         warning SC2162.
3520
3521 2020-04-29  Simon Marchi  <simon.marchi@efficios.com>
3522
3523         * gdbarch.sh: Use ${foo:-} where shellcheck would report a
3524         "referenced but not assigned" warning.
3525
3526 2020-04-29  Simon Marchi  <simon.marchi@efficios.com>
3527
3528         * gdbarch.sh: Remove code that sets fallbackdefault.
3529
3530 2020-04-29  Simon Marchi  <simon.marchi@efficios.com>
3531
3532         * gdbarch.sh: Use shell operators && and || instead of
3533         -a and -o.
3534
3535 2020-04-29  Simon Marchi  <simon.marchi@efficios.com>
3536
3537         * gdbarch.sh: Use $(...) instead of `...`.
3538
3539 2020-04-29  Simon Marchi  <simon.marchi@efficios.com>
3540
3541         * gdbarch.sh: Use double quotes around variables.
3542
3543 2020-04-29  Simon Marchi  <simon.marchi@efficios.com>
3544
3545         * gdbarch.sh: Use %s with printf, instead of variables in the
3546         format string.
3547
3548 2020-04-29  Tom Tromey  <tromey@adacore.com>
3549
3550         PR ada/25875:
3551         * dwarf2/read.c (update_enumeration_type_from_children): Compute
3552         type fields here.
3553         (read_enumeration_type): Call
3554         update_enumeration_type_from_children later.  Update comments.
3555         (process_enumeration_scope): Don't create type fields.
3556
3557 2020-04-29  Kamil Rytarowski  <n54@gmx.com>
3558
3559         * nbsd-tdep.c: Include "xml-syscall.h".
3560         (nbsd_init_abi): Call `set_xml_syscall_file_name'.
3561
3562 2020-04-29  Kamil Rytarowski  <n54@gmx.com>
3563
3564         * nbsd-nat.c: Include "sys/wait.h".
3565         (nbsd_resume, nbsd_nat_target::resume, nbsd_wait)
3566         (nbsd_nat_target::wait, nbsd_nat_target::insert_exec_catchpoint)
3567         (nbsd_nat_target::remove_exec_catchpoint)
3568         (nbsd_nat_target::set_syscall_catchpoint): Add.
3569         * nbsd-nat.h (nbsd_nat_target::resume, nbsd_nat_target::wait)
3570         (nbsd_nat_target::insert_exec_catchpoint)
3571         (nbsd_nat_target::remove_exec_catchpoint)
3572         (nbsd_nat_target::set_syscall_catchpoint): Add.
3573         * nbsd-tdep.c (nbsd_get_syscall_number): Add.
3574         (nbsd_init_abi): Call `set_gdbarch_get_syscall_number' and pass
3575         `nbsd_get_syscall_number'.
3576
3577 2020-04-29  Tom Tromey  <tom@tromey.com>
3578
3579         * stack.c (print_block_frame_labels): Remove.
3580
3581 2020-04-29  Hannes Domani  <ssbssa@yahoo.de>
3582
3583         PR gdb/17320
3584         * ada-valprint.c (val_print_packed_array_elements): Move array
3585         end bracket to new line.
3586         (ada_val_print_string): Remove extra spaces before first array
3587         element.
3588         * c-valprint.c (c_value_print_array): Likewise.
3589         * m2-valprint.c (m2_print_array_contents): Likewise.
3590         (m2_value_print_inner): Likewise.
3591         * p-valprint.c (pascal_value_print_inner): Likewise.
3592         * valprint.c (generic_val_print_array): Likewise.
3593         (value_print_array_elements): Move first array element and array
3594         end bracket to new line.
3595
3596 2020-04-29  Tom de Vries  <tdevries@suse.de>
3597
3598         PR symtab/25889
3599         * linespec.c (find_method): Fix ix calculation.
3600
3601 2020-04-28  Kamil Rytarowski  <n54@gmx.com>
3602
3603         * syscalls/update-netbsd.sh: New file.
3604         * syscalls/netbsd.xml: Regenerate.
3605         * data-directory/Makefile.in: Register `netbsd.xml' in
3606         `SYSCALLS_FILES'.
3607
3608 2020-04-28  Simon Marchi  <simon.marchi@efficios.com>
3609
3610         * syscalls/update-freebsd.sh: Add double quotes.
3611
3612 2020-04-28  Tom Tromey  <tom@tromey.com>
3613
3614         * NEWS: Update.
3615         * python/py-cmd.c (gdbpy_initialize_commands): Add COMMAND_TUI.
3616         (cmdpy_init): Allow class_tui.
3617
3618 2020-04-28 Mark Williams <mark@myosotissp.com>
3619
3620         PR gdb/24480
3621         * dwarf2read.c: Add missing assingments to list_in_scope when
3622         start_symtab was already called.
3623
3624 2020-04-28  Simon Marchi  <simon.marchi@efficios.com>
3625
3626         PR gdb/25881
3627         * dwarf2/read.c (offset_map_type): Use
3628         gdb:hash_enum<sect_offset> as hash function.
3629
3630 2020-04-28  Tom de Vries  <tdevries@suse.de>
3631
3632         * dwarf2/read.c (process_structure_scope): Add symbol for struct decl
3633         with DW_AT_signature.
3634
3635 2020-04-27  Simon Marchi  <simon.marchi@efficios.com>
3636
3637         * configure.ac: Remove check for fs_base/gs_base in
3638         user_regs_struct.
3639         * configure: Re-generate.
3640         * config.in: Re-generate.
3641         * amd64-nat.c (amd64_native_gregset_reg_offset): Adjust.
3642         * amd64-linux-nat.c (amd64_linux_nat_target::fetch_registers,
3643         amd64_linux_nat_target::store_registers, ps_get_thread_area, ): Adjust.
3644
3645 2020-04-27  Luis Machado  <luis.machado@linaro.org>
3646
3647         * dwarf2/frame-tailcall.c (dwarf2_tailcall_sniffer_first): Handle
3648         problematic inline frame unwinding situation.
3649         * frame.c (frame_id_computed_p): New function.
3650         * frame.h (frame_id_computed_p): New prototype.
3651
3652 2020-04-26  Tom Tromey  <tom@tromey.com>
3653
3654         * command.h (enum command_class) <class_pseudo>: Remove.
3655
3656 2020-04-26  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3657
3658         * cli/cli-decode.c (lookup_cmd_composition): Fix comments
3659         and whitespace.
3660
3661 2020-04-25  Kamil Rytarowski  <n54@gmx.com>
3662
3663         * inf-ptrace.c (inf_ptrace_target::wait): Remove
3664         `PT_GET_PROCESS_STATE' block.
3665
3666 2020-04-24  Tom Tromey  <tom@tromey.com>
3667
3668         * symtab.h (symbol_get_demangled_name): Don't declare.
3669         * symtab.c (symbol_get_demangled_name): Remove.
3670         (general_symbol_info::natural_name)
3671         (general_symbol_info::demangled_name): Update.
3672
3673 2020-04-24  Tom Tromey  <tom@tromey.com>
3674
3675         PR rust/25025:
3676         * dwarf2/read.c (dwarf2_physname): Do not demangle for Rust.
3677
3678 2020-04-24  Tom Tromey  <tom@tromey.com>
3679
3680         PR symtab/12707:
3681         * dwarf2/read.c (add_partial_symbol): Use the linkage name if it
3682         exists.
3683         (new_symbol): Likewise.
3684         * compile/compile-object-load.c (get_out_value_type): Use
3685         symbol_matches_search_name.
3686
3687 2020-04-24  Tom Tromey  <tom@tromey.com>
3688
3689         * dwarf2/read.c (add_partial_symbol): Do not call
3690         compute_and_set_names.
3691
3692 2020-04-24  Tom Tromey  <tom@tromey.com>
3693
3694         * dwarf2/read.c (add_partial_symbol): Use new add_psymbol_to_list
3695         overload.
3696
3697 2020-04-24  Tom Tromey  <tom@tromey.com>
3698
3699         * psymtab.c (add_psymbol_to_bcache): Simplify calling convention.
3700         (add_psymbol_to_list): New overload.  Make old overload call new
3701         one.
3702         * psympriv.h (add_psymbol_to_list): New overload.
3703
3704 2020-04-24  Tom Tromey  <tom@tromey.com>
3705
3706         * dwarf2/read.c (partial_die_info::read) <case
3707         DW_AT_linkage_name>: Use value_as_string.
3708         (dwarf2_string_attr): Use value_as_string.
3709         * dwarf2/attribute.h (struct attribute) <value_as_string>: Declare
3710         method.
3711         * dwarf2/attribute.c (attribute::value_as_string): New method.
3712
3713 2020-04-24  Tom Tromey  <tom@tromey.com>
3714
3715         * symtab.c (general_symbol_info::natural_name)
3716         (general_symbol_info::demangled_name): Check for language_rust.
3717
3718 2020-04-24  Tom Tromey  <tom@tromey.com>
3719
3720         * dwarf2/read.c (dw2_linkage_name): Move Rust "{" hack here...
3721         (dwarf2_physname): ... from here.
3722         (partial_die_info::read): Add Rust "{" hack.
3723
3724 2020-04-24  Tom Tromey  <tom@tromey.com>
3725
3726         * symtab.h (struct general_symbol_info) <set_demangled_name>: New
3727         method.
3728         (symbol_set_demangled_name): Don't declare.
3729         * symtab.c (general_symbol_info::set_demangled_name): Rename from
3730         symbol_set_demangled_name.
3731         (general_symbol_info::set_language)
3732         (general_symbol_info::compute_and_set_names): Update.
3733         * minsyms.c (minimal_symbol_reader::install): Update.
3734         * dwarf2/read.c (new_symbol): Update.
3735
3736 2020-04-24  Tom Tromey  <tromey@adacore.com>
3737
3738         PR python/23662:
3739         * python/py-type.c (convert_field): Handle
3740         FIELD_LOC_KIND_DWARF_BLOCK.
3741         (typy_get_sizeof): Handle TYPE_HAS_DYNAMIC_LENGTH.
3742         (typy_get_dynamic): Nw function.
3743         (type_object_getset): Add "dynamic".
3744         * NEWS: Add entry.
3745
3746 2020-04-24  Tom Tromey  <tromey@adacore.com>
3747
3748         * ada-typeprint.c (print_choices, print_variant_part)
3749         (print_record_field_types_dynamic): New functions.
3750         (print_record_field_types): Use print_record_field_types_dynamic.
3751
3752 2020-04-24  Tom Tromey  <tromey@adacore.com>
3753
3754         * dwarf2/read.c (handle_data_member_location): New overload.
3755         (dwarf2_add_field): Use it.
3756         (decode_locdesc): Add "computed" parameter.  Update comment.
3757         * gdbtypes.c (is_dynamic_type_internal): Also look for
3758         FIELD_LOC_KIND_DWARF_BLOCK.
3759         (resolve_dynamic_struct): Handle FIELD_LOC_KIND_DWARF_BLOCK.
3760         * gdbtypes.c (is_dynamic_type_internal): Add special case for C++
3761         virtual base classes.
3762         * gnu-v3-abi.c (gnuv3_baseclass_offset): Handle
3763         FIELD_LOC_KIND_DWARF_BLOCK.
3764
3765 2020-04-24  Tom Tromey  <tromey@adacore.com>
3766
3767         * dwarf2/read.c (read_structure_type): Handle dynamic length.
3768         * gdbtypes.c (is_dynamic_type_internal): Check
3769         TYPE_HAS_DYNAMIC_LENGTH.
3770         (resolve_dynamic_type_internal): Use TYPE_DYNAMIC_LENGTH.
3771         * gdbtypes.h (TYPE_HAS_DYNAMIC_LENGTH, TYPE_DYNAMIC_LENGTH):
3772         New macros.
3773         (enum dynamic_prop_node_kind) <DYN_PROP_BYTE_SIZE>: New
3774         constant.
3775
3776 2020-04-24  Tom Tromey  <tromey@adacore.com>
3777
3778         * dwarf2/read.c (struct variant_field): Rewrite.
3779         (struct variant_part_builder): New.
3780         (struct nextfield): Remove "variant" field.  Add "offset".
3781         (struct field_info): Add "current_variant_part" and
3782         "variant_parts".
3783         (alloc_discriminant_info): Remove.
3784         (alloc_rust_variant): New function.
3785         (quirk_rust_enum): Update.
3786         (dwarf2_add_field): Set "offset" member.  Don't handle
3787         DW_TAG_variant_part.
3788         (offset_map_type): New typedef.
3789         (convert_variant_range, create_one_variant)
3790         (create_one_variant_part, create_variant_parts)
3791         (add_variant_property): New functions.
3792         (dwarf2_attach_fields_to_type): Call add_variant_property.
3793         (read_structure_type): Don't handle DW_TAG_variant_part.
3794         (handle_variant_part, handle_variant): New functions.
3795         (handle_struct_member_die): Use them.
3796         (process_structure_scope): Don't handle variant parts.
3797         * gdbtypes.h (TYPE_FLAG_DISCRIMINATED_UNION): Remove.
3798         (struct discriminant_info): Remove.
3799         (enum dynamic_prop_node_kind) <DYN_PROP_DISCRIMINATED>: Remove.
3800         (struct main_type) <flag_discriminated_union>: Remove.
3801         * rust-lang.c (rust_enum_p, rust_empty_enum_p): Rewrite.
3802         (rust_enum_variant): Return int.  Remove "contents".  Rewrite.
3803         (rust_print_enum, rust_print_struct_def, rust_evaluate_subexp):
3804         Update.
3805         * valops.c (value_union_variant): Remove.
3806         * value.h (value_union_variant): Don't declare.
3807
3808 2020-04-24  Tom Tromey  <tromey@adacore.com>
3809
3810         * ada-lang.c (ada_discrete_type_high_bound, ada_discrete_type_low)
3811         (ada_value_primitive_packed_val): Update.
3812         * ada-valprint.c (ada_value_print_1): Update.
3813         * dwarf2/loc.c (evaluate_for_locexpr_baton): New struct.
3814         (dwarf2_locexpr_baton_eval): Take a property_addr_info rather than
3815         just an address.  Use evaluate_for_locexpr_baton.
3816         (dwarf2_evaluate_property): Update.
3817         * dwarf2/loc.h (struct property_addr_info) <valaddr>: Now an
3818         array_view.
3819         * findvar.c (default_read_var_value): Update.
3820         * gdbtypes.c (compute_variant_fields_inner)
3821         (resolve_dynamic_type_internal): Update.
3822         (resolve_dynamic_type): Change type of valaddr parameter.
3823         * gdbtypes.h (resolve_dynamic_type): Update.
3824         * valarith.c (value_subscripted_rvalue): Update.
3825         * value.c (value_from_contents_and_address): Update.
3826
3827 2020-04-24  Tom Tromey  <tromey@adacore.com>
3828
3829         * dwarf2/loc.c (dwarf2_locexpr_baton_eval): Add
3830         "push_initial_value" parameter.
3831         (dwarf2_evaluate_property): Likewise.
3832         * dwarf2/loc.h (dwarf2_evaluate_property): Update.
3833
3834 2020-04-24  Tom Tromey  <tromey@adacore.com>
3835
3836         * gdbtypes.c (is_dynamic_type_internal): Check for variant parts.
3837         (variant::matches, compute_variant_fields_recurse)
3838         (compute_variant_fields_inner, compute_variant_fields): New
3839         functions.
3840         (resolve_dynamic_struct): Check for DYN_PROP_VARIANT_PARTS.
3841         Use resolved_type after type is made.
3842         (operator==): Add new cases.
3843         * gdbtypes.h (TYPE_HAS_VARIANT_PARTS): New macro.
3844         (struct discriminant_range, struct variant, struct variant_part):
3845         New.
3846         (union dynamic_prop_data) <variant_parts, original_type>: New
3847         members.
3848         (enum dynamic_prop_node_kind) <DYN_PROP_VARIANT_PARTS>: New constant.
3849         (enum dynamic_prop_kind) <PROP_TYPE, PROP_VARIANT_PARTS>: New
3850         constants.
3851         * value.c (unpack_bits_as_long): Now public.
3852         * value.h (unpack_bits_as_long): Declare.
3853
3854 2020-04-24  Tom Tromey  <tromey@adacore.com>
3855
3856         * rs6000-tdep.c (struct ppc_variant): Rename from "variant".
3857         (variants, find_variant_by_arch, rs6000_gdbarch_init): Update.
3858
3859 2020-04-24  Hannes Domani  <ssbssa@yahoo.de>
3860
3861         * windows-tdep.c (exception_values): Add WOW64 exception numbers.
3862
3863 2020-04-24  Kamil Rytarowski  <n54@gmx.com>
3864
3865         * inf-ptrace.h (follow_fork, insert_fork_catchpoint)
3866         (remove_fork_catchpoint, post_startup_inferior)
3867         (post_attach): Move...
3868         * obsd-nat.h (follow_fork, insert_fork_catchpoint)
3869         (remove_fork_catchpoint, post_startup_inferior)
3870         (post_attach): ...here.
3871         * inf-ptrace.c (follow_fork, insert_fork_catchpoint)
3872         (remove_fork_catchpoint, post_startup_inferior)
3873         (post_attach): Move...
3874         * obsd-nat.c (follow_fork, insert_fork_catchpoint)
3875         (remove_fork_catchpoint, post_startup_inferior)
3876         (post_attach): ...here.
3877
3878 2020-04-24  Tom Tromey  <tromey@adacore.com>
3879
3880         * nat/windows-nat.h (struct windows_thread_info)
3881         <pc_adjusted>: New member.
3882         * windows-nat.c (windows_fetch_one_register): Check
3883         pc_adjusted.
3884         (windows_nat_target::get_windows_debug_event)
3885         (windows_nat_target::wait): Set pc_adjusted.
3886
3887 2020-04-24  Tom de Vries  <tdevries@suse.de>
3888
3889         * contrib/cc-with-tweaks.sh: Remove <exec>.gdb-index file handling.
3890         Run gdb-add-index inside temp dir.
3891
3892 2020-04-23  Tom Tromey  <tromey@adacore.com>
3893
3894         * windows-tdep.c (is_linked_with_cygwin_dll): Always update "iter"
3895         in loop.
3896
3897 2020-04-23  Luis Machado  <luis.machado@linaro.org>
3898
3899         * dwarf2/frame-tailcall.c (dwarf2_tailcall_sniffer_first): Use
3900         get_frame_register instead of gdbarch_unwind_pc.
3901
3902 2020-04-23  Tom de Vries  <tdevries@suse.de>
3903
3904         * symtab.c (lookup_global_symbol): Prefer def over decl.
3905
3906 2020-04-23  Tom de Vries  <tdevries@suse.de>
3907
3908         PR symtab/25807
3909         * block.c (best_symbol, better_symbol): Promote to external.
3910         * block.h (best_symbol, better_symbol): Declare.
3911         * symtab.c (lookup_symbol_in_objfile_symtabs): Prefer def over
3912         decl.
3913
3914 2020-04-23  Tom Tromey  <tromey@adacore.com>
3915
3916         PR ada/25837:
3917         * dwarf2/read.c (dw2_expand_symtabs_matching_symbol): Store a
3918         "const char *", not a "const std::string &".
3919         <name_and_matcher::operator==>: Update.
3920         * unittests/lookup_name_info-selftests.c: Change type of
3921         "result".
3922
3923 2020-04-23  Tom Tromey  <tom@tromey.com>
3924
3925         * inferior.h (iterate_over_inferiors): Don't declare.
3926         * inferior.c (iterate_over_inferiors): Remove.
3927         * darwin-nat.c (find_inferior_task_it, find_inferior_pid_it):
3928         Remove.
3929         (darwin_find_inferior_by_task, darwin_find_inferior_by_pid): Don't
3930         use iterate_over_inferiors.
3931         (darwin_resume_inferior_it)
3932         (struct resume_inferior_threads_param)
3933         (darwin_resume_inferior_threads_it): Remove.
3934         (darwin_nat_target::resume): Don't use iterate_over_inferiors.
3935
3936 2020-04-23  Tom de Vries  <tdevries@suse.de>
3937
3938         * blockframe.c (find_pc_partial_function): Use
3939         find_pc_sect_compunit_symtab rather than
3940         objfile->sf->qf->find_pc_sect_compunit_symtab.
3941
3942 2020-04-22  Tom de Vries  <tdevries@suse.de>
3943
3944         PR symtab/25764
3945         * dwarf2/read.c (scan_partial_symbols): Allow external variable decls
3946         in psymtabs.
3947
3948 2020-04-22  Tom de Vries  <tdevries@suse.de>
3949
3950         PR symtab/25801
3951         * psymtab.c (psym_map_symtabs_matching_filename): Don't skip shared
3952         symtabs.
3953
3954 2020-04-22  Tom de Vries  <tdevries@suse.de>
3955
3956         PR symtab/25700
3957         * dwarf2/read.c (dwarf2_build_psymtabs_hard): Don't create psymtab for
3958         CU if already created.
3959
3960 2020-04-21  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
3961
3962         * infrun.c (displaced_step_fixup): Switch to the event_thread
3963         before calling displaced_step_restore, not after.
3964
3965 2020-04-21  Markus Metzger  <markus.t.metzger@intel.com>
3966
3967         * record-btrace.c (record_btrace_enable_warn): Ignore thread if
3968         its inferior is not recorded by us.
3969         (record_btrace_target_open): Replace call to
3970         all_non_exited_threads () with call to current_inferior
3971         ()->non_exited_threads ().
3972         (record_btrace_target::stop_recording): Likewise.
3973         (record_btrace_target::close): Likewise.
3974         (record_btrace_target::wait): Likewise.
3975         (record_btrace_target::record_stop_replaying): Likewise.
3976
3977 2020-04-21  Markus Metzger  <markus.t.metzger@intel.com>
3978
3979         * btrace.c (btrace_enable): Throw an error on double enables and
3980         when enabling recording fails.
3981         (btrace_disable): Throw an error if the thread is not recorded.
3982
3983 2020-04-21  Markus Metzger  <markus.t.metzger@intel.com>
3984
3985         * record-btrace.c (record_btrace_target::fetch_registers): Forward
3986         request if we do not have a thread_info.
3987
3988 2020-04-21  Tom de Vries  <tdevries@suse.de>
3989
3990         PR gdb/25471
3991         * thread.c
3992         (scoped_restore_current_thread::scoped_restore_current_thread): Catch
3993         exception in get_frame_id.
3994
3995 2020-04-20  Tom Tromey  <tromey@adacore.com>
3996
3997         * python/python.c (struct gdbpy_event): Mark move constructor as
3998         noexcept.
3999         * python/py-tui.c (class gdbpy_tui_window_maker): Mark move
4000         constructor as noexcept.
4001         * completer.h (struct completion_result): Mark move constructor as
4002         noexcept.
4003         * completer.c (completion_result::completion_result): Use
4004         initialization style.  Don't call reset_match_list.
4005
4006 2020-04-20  Mihails Strasuns  <mihails.strasuns@intel.com>
4007
4008         * MAINTAINERS (Write After Approval): Add myself.
4009
4010 2020-04-18  Tom Tromey  <tom@tromey.com>
4011
4012         * windows-tdep.c (init_w32_command_list)
4013         (w32_prefix_command_valid): Restore.
4014         (_initialize_windows_tdep): Call init_w32_command_list.
4015
4016 2020-04-18  Tom Tromey  <tom@tromey.com>
4017
4018         * xcoffread.c (enter_line_range, scan_xcoff_symtab): Update.
4019         * value.c (value_fn_field): Update.
4020         * valops.c (find_function_in_inferior)
4021         (value_allocate_space_in_inferior): Update.
4022         * tui/tui-winsource.c (tui_update_source_windows_with_line):
4023         Update.
4024         * tui/tui-source.c (tui_source_window::set_contents): Update.
4025         * symtab.c (lookup_global_or_static_symbol)
4026         (find_function_start_sal_1, skip_prologue_sal)
4027         (print_msymbol_info, find_gnu_ifunc, symbol_arch): Update.
4028         * symmisc.c (dump_msymbols, dump_symtab_1)
4029         (maintenance_print_one_line_table): Update.
4030         * symfile.c (init_entry_point_info, section_is_mapped)
4031         (list_overlays_command, simple_read_overlay_table)
4032         (simple_overlay_update_1): Update.
4033         * stap-probe.c (handle_stap_probe): Update.
4034         * stabsread.c (dbx_init_float_type, define_symbol)
4035         (read_one_struct_field, read_enum_type, read_range_type): Update.
4036         * source.c (info_line_command): Update.
4037         * python/python.c (gdbpy_source_objfile_script)
4038         (gdbpy_execute_objfile_script): Update.
4039         * python/py-type.c (save_objfile_types): Update.
4040         * python/py-objfile.c (py_free_objfile): Update.
4041         * python/py-inferior.c (python_new_objfile): Update.
4042         * psymtab.c (psym_find_pc_sect_compunit_symtab, dump_psymtab)
4043         (dump_psymtab_addrmap_1, maintenance_info_psymtabs)
4044         (maintenance_check_psymtabs): Update.
4045         * printcmd.c (info_address_command): Update.
4046         * objfiles.h (struct objfile) <arch>: New method, from
4047         get_objfile_arch.
4048         (get_objfile_arch): Don't declare.
4049         * objfiles.c (get_objfile_arch): Remove.
4050         (filter_overlapping_sections): Update.
4051         * minsyms.c (msymbol_is_function): Update.
4052         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines)
4053         (output_nondebug_symbol): Update.
4054         * mdebugread.c (parse_symbol, basic_type, parse_partial_symbols)
4055         (mdebug_expand_psymtab): Update.
4056         * machoread.c (macho_add_oso_symfile): Update.
4057         * linux-tdep.c (linux_infcall_mmap, linux_infcall_munmap):
4058         Update.
4059         * linux-fork.c (checkpoint_command): Update.
4060         * linespec.c (convert_linespec_to_sals): Update.
4061         * jit.c (finalize_symtab): Update.
4062         * infrun.c (insert_exception_resume_from_probe): Update.
4063         * ia64-tdep.c (ia64_find_unwind_table): Update.
4064         * hppa-tdep.c (internalize_unwinds): Update.
4065         * gdbtypes.c (get_type_arch, init_float_type, objfile_type):
4066         Update.
4067         * gcore.c (call_target_sbrk): Update.
4068         * elfread.c (record_minimal_symbol, elf_symtab_read)
4069         (elf_rel_plt_read, elf_gnu_ifunc_record_cache)
4070         (elf_gnu_ifunc_resolve_by_got): Update.
4071         * dwarf2/read.c (create_addrmap_from_index)
4072         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
4073         (read_debug_names_from_section)
4074         (process_psymtab_comp_unit_reader, add_partial_symbol)
4075         (add_partial_subprogram, process_full_comp_unit)
4076         (read_file_scope, read_func_scope, read_lexical_block_scope)
4077         (read_call_site_scope, dwarf2_ranges_read)
4078         (dwarf2_record_block_ranges, dwarf2_add_field)
4079         (mark_common_block_symbol_computed, read_tag_pointer_type)
4080         (read_tag_string_type, dwarf2_init_float_type)
4081         (dwarf2_init_complex_target_type, read_base_type)
4082         (partial_die_info::read, partial_die_info::read)
4083         (read_attribute_value, dwarf_decode_lines_1, new_symbol)
4084         (dwarf2_fetch_die_loc_sect_off): Update.
4085         * dwarf2/loc.c (dwarf2_find_location_expression)
4086         (class dwarf_evaluate_loc_desc, rw_pieced_value)
4087         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval)
4088         (dwarf2_loc_desc_get_symbol_read_needs)
4089         (locexpr_describe_location_piece, locexpr_describe_location_1)
4090         (loclist_describe_location): Update.
4091         * dwarf2/index-write.c (write_debug_names): Update.
4092         * dwarf2/frame.c (dwarf2_build_frame_info): Update.
4093         * dtrace-probe.c (dtrace_process_dof): Update.
4094         * dbxread.c (read_dbx_symtab, dbx_end_psymtab)
4095         (process_one_symbol): Update.
4096         * ctfread.c (ctf_init_float_type, read_base_type): Update.
4097         * coffread.c (coff_symtab_read, enter_linenos, decode_base_type)
4098         (coff_read_enum_type): Update.
4099         * cli/cli-cmds.c (edit_command, list_command): Update.
4100         * buildsym.c (buildsym_compunit::finish_block_internal): Update.
4101         * breakpoint.c (create_overlay_event_breakpoint)
4102         (create_longjmp_master_breakpoint)
4103         (create_std_terminate_master_breakpoint)
4104         (create_exception_master_breakpoint, get_sal_arch): Update.
4105         * block.c (block_gdbarch): Update.
4106         * annotate.c (annotate_source_line): Update.
4107
4108 2020-04-17  Tom Tromey  <tromey@adacore.com>
4109
4110         * auto-load.c (show_auto_load_cmd): Remove.
4111         (auto_load_show_cmdlist_get): Use add_show_prefix_cmd.
4112         * arc-tdep.c (_initialize_arc_tdep): Use add_show_prefix_cmd.
4113         (maintenance_print_arc_command): Remove.
4114         * tui/tui-win.c (tui_command): Remove.
4115         (tui_get_cmd_list): Use add_basic_prefix_cmd.
4116         * tui/tui-layout.c (tui_layout_command): Remove.
4117         (_initialize_tui_layout): Use add_basic_prefix_cmd.
4118         * python/python.c (user_set_python, user_show_python): Remove.
4119         (_initialize_python): Use add_basic_prefix_cmd,
4120         add_show_prefix_cmd.
4121         * guile/guile.c (set_guile_command, show_guile_command): Remove.
4122         (install_gdb_commands): Use add_basic_prefix_cmd,
4123         add_show_prefix_cmd.
4124         (info_guile_command): Remove.
4125         * dwarf2/read.c (set_dwarf_cmd, show_dwarf_cmd): Remove.
4126         (_initialize_dwarf2_read): Use add_basic_prefix_cmd,
4127         add_show_prefix_cmd.
4128         * cli/cli-style.h (class cli_style_option) <add_setshow_commands>:
4129         Remove do_set and do_show parameters.
4130         * cli/cli-style.c (set_style, show_style): Remove.
4131         (_initialize_cli_style): Use add_basic_prefix_cmd,
4132         add_show_prefix_cmd.
4133         (cli_style_option::add_setshow_commands): Remove do_set and
4134         do_show parameters.
4135         (cli_style_option::add_setshow_commands): Use
4136         add_basic_prefix_cmd, add_show_prefix_cmd.
4137         (STYLE_ADD_SETSHOW_COMMANDS): Remove macro.
4138         (set_style_name): Remove.
4139         * cli/cli-dump.c (dump_command, append_command): Remove.
4140         (srec_dump_command, ihex_dump_command, verilog_dump_command)
4141         (tekhex_dump_command, binary_dump_command)
4142         (binary_append_command): Remove.
4143         (_initialize_cli_dump): Use add_basic_prefix_cmd.
4144         * windows-tdep.c (w32_prefix_command_valid): Remove global.
4145         (init_w32_command_list): Remove; move into ...
4146         (_initialize_windows_tdep): ... here.  Use add_basic_prefix_cmd.
4147         * valprint.c (set_print, show_print, set_print_raw)
4148         (show_print_raw): Remove.
4149         (_initialize_valprint): Use add_basic_prefix_cmd,
4150         add_show_prefix_cmd.
4151         * typeprint.c (set_print_type, show_print_type): Remove.
4152         (_initialize_typeprint): Use add_basic_prefix_cmd,
4153         add_show_prefix_cmd.
4154         * record.c (set_record_command, show_record_command): Remove.
4155         (_initialize_record): Use add_basic_prefix_cmd,
4156         add_show_prefix_cmd.
4157         * cli/cli-cmds.c (_initialize_cli_cmds): Use add_basic_prefix_cmd,
4158         add_show_prefix_cmd.
4159         (info_command, show_command, set_debug, show_debug): Remove.
4160         * top.h (set_history, show_history): Don't declare.
4161         * top.c (set_history, show_history): Remove.
4162         * target-descriptions.c (set_tdesc_cmd, show_tdesc_cmd)
4163         (unset_tdesc_cmd): Remove.
4164         (_initialize_target_descriptions): Use add_basic_prefix_cmd,
4165         add_show_prefix_cmd.
4166         * symtab.c (info_module_command): Remove.
4167         (_initialize_symtab): Use add_basic_prefix_cmd.
4168         * symfile.c (overlay_command): Remove.
4169         (_initialize_symfile): Use add_basic_prefix_cmd.
4170         * sparc64-tdep.c (info_adi_command): Remove.
4171         (_initialize_sparc64_adi_tdep): Use add_basic_prefix_cmd.
4172         * sh-tdep.c (show_sh_command, set_sh_command): Remove.
4173         (_initialize_sh_tdep): Use add_basic_prefix_cmd,
4174         add_show_prefix_cmd.
4175         * serial.c (serial_set_cmd, serial_show_cmd): Remove.
4176         (_initialize_serial): Use add_basic_prefix_cmd,
4177         add_show_prefix_cmd.
4178         * ser-tcp.c (set_tcp_cmd, show_tcp_cmd): Remove.
4179         (_initialize_ser_tcp): Use add_basic_prefix_cmd,
4180         add_show_prefix_cmd.
4181         * rs6000-tdep.c (set_powerpc_command, show_powerpc_command)
4182         (_initialize_rs6000_tdep): Use add_basic_prefix_cmd,
4183         add_show_prefix_cmd.
4184         * riscv-tdep.c (show_riscv_command, set_riscv_command)
4185         (show_debug_riscv_command, set_debug_riscv_command): Remove.
4186         (_initialize_riscv_tdep): Use add_basic_prefix_cmd,
4187         add_show_prefix_cmd.
4188         * remote.c (remote_command, set_remote_cmd): Remove.
4189         (_initialize_remote): Use add_basic_prefix_cmd.
4190         * record-full.c (set_record_full_command)
4191         (show_record_full_command): Remove.
4192         (_initialize_record_full): Use add_basic_prefix_cmd,
4193         add_show_prefix_cmd.
4194         * record-btrace.c (cmd_set_record_btrace)
4195         (cmd_show_record_btrace, cmd_set_record_btrace_bts)
4196         (cmd_show_record_btrace_bts, cmd_set_record_btrace_pt)
4197         (cmd_show_record_btrace_pt): Remove.
4198         (_initialize_record_btrace): Use add_basic_prefix_cmd,
4199         add_show_prefix_cmd.
4200         * ravenscar-thread.c (set_ravenscar_command)
4201         (show_ravenscar_command): Remove.
4202         (_initialize_ravenscar): Use add_basic_prefix_cmd,
4203         add_show_prefix_cmd.
4204         * mips-tdep.c (show_mips_command, set_mips_command)
4205         (_initialize_mips_tdep): Use add_basic_prefix_cmd,
4206         add_show_prefix_cmd.
4207         * maint.c (maintenance_command, maintenance_info_command)
4208         (maintenance_check_command, maintenance_print_command)
4209         (maintenance_set_cmd, maintenance_show_cmd): Remove.
4210         (_initialize_maint_cmds): Use add_basic_prefix_cmd,
4211         add_show_prefix_cmd.
4212         (show_per_command_cmd): Remove.
4213         * maint-test-settings.c (maintenance_set_test_settings_cmd):
4214         Remove.
4215         (maintenance_show_test_settings_cmd): Remove.
4216         (_initialize_maint_test_settings): Use add_basic_prefix_cmd,
4217         add_show_prefix_cmd.
4218         * maint-test-options.c (maintenance_test_options_command):
4219         Remove.
4220         (_initialize_maint_test_options): Use add_basic_prefix_cmd.
4221         * macrocmd.c (macro_command): Remove
4222         (_initialize_macrocmd): Use add_basic_prefix_cmd.
4223         * language.c (set_check, show_check): Remove.
4224         (_initialize_language): Use add_basic_prefix_cmd,
4225         add_show_prefix_cmd.
4226         * infcmd.c (unset_command): Remove.
4227         (_initialize_infcmd): Use add_basic_prefix_cmd.
4228         * i386-tdep.c (set_mpx_cmd, show_mpx_cmd): Remove.
4229         (_initialize_i386_tdep): Use add_basic_prefix_cmd,
4230         add_show_prefix_cmd.
4231         * go32-nat.c (go32_info_dos_command): Remove.
4232         (_initialize_go32_nat): Use add_basic_prefix_cmd.
4233         * cli/cli-decode.c (do_prefix_cmd, add_basic_prefix_cmd)
4234         (do_show_prefix_cmd, add_show_prefix_cmd): New functions.
4235         * frame.c (set_backtrace_cmd, show_backtrace_cmd): Remove.
4236         (_initialize_frame): Use add_basic_prefix_cmd,
4237         add_show_prefix_cmd.
4238         * dcache.c (set_dcache_command, show_dcache_command): Remove.
4239         (_initialize_dcache): Use add_basic_prefix_cmd,
4240         add_show_prefix_cmd.
4241         * cp-support.c (maint_cplus_command): Remove.
4242         (_initialize_cp_support): Use add_basic_prefix_cmd.
4243         * btrace.c (maint_btrace_cmd, maint_btrace_set_cmd)
4244         (maint_btrace_show_cmd, maint_btrace_pt_set_cmd)
4245         (maint_btrace_pt_show_cmd, _initialize_btrace): Use
4246         add_basic_prefix_cmd, add_show_prefix_cmd.
4247         * breakpoint.c (save_command): Remove.
4248         (_initialize_breakpoint): Use add_basic_prefix_cmd.
4249         * arm-tdep.c (set_arm_command, show_arm_command): Remove.
4250         (_initialize_arm_tdep): Use add_basic_prefix_cmd,
4251         add_show_prefix_cmd.
4252         * ada-lang.c (maint_set_ada_cmd, maint_show_ada_cmd)
4253         (set_ada_command, show_ada_command): Remove.
4254         (_initialize_ada_language): Use add_basic_prefix_cmd,
4255         add_show_prefix_cmd.
4256         * command.h (add_basic_prefix_cmd, add_show_prefix_cmd): Declare.
4257
4258 2020-04-16  Kamil Rytarowski  <n54@gmx.com>
4259
4260         * nbsd-nat.c (inf_ptrace_target::auxv_parse): Remove.
4261         * nbsd-nat.h (inf_ptrace_target::auxv_parse): Likewise.
4262
4263 2020-04-16  Simon Marchi  <simon.marchi@polymtl.ca>
4264
4265         * windows-tdep.c (is_linked_with_cygwin_dll): Add filename to
4266         warning messages.
4267
4268 2020-04-16  Simon Marchi  <simon.marchi@polymtl.ca>
4269
4270         * windows-tdep.c (is_linked_with_cygwin_dll): Consider case where
4271         import table is not at beginning of .idata section.
4272
4273 2020-04-16  Pedro Alves  <palves@redhat.com>
4274
4275         * inferior.c (delete_inferior): Use delete operator directly
4276         instead of delete_program_space.
4277         * progspace.c (add_program_space): New, factored out from
4278         program_space::program_space.
4279         (remove_program_space): New, factored out from
4280         delete_program_space.
4281         (program_space::program_space): Remove intro comment.  Rewrite.
4282         (program_space::~program_space): Remove intro comment.  Call
4283         remove_program_space.
4284         (delete_program_space): Delete.
4285         * progspace.h (program_space::program_space): Make explicit.  Move
4286         intro comment here, adjusted.
4287         (program_space::~program_space): Move intro comment here,
4288         adjusted.
4289         (delete_program_space): Remove.
4290
4291 2020-04-16  Tom Tromey  <tromey@adacore.com>
4292
4293         * windows-nat.c (windows_nat::handle_access_violation): New
4294         function.
4295         * nat/windows-nat.h (handle_access_violation): Declare.
4296         * nat/windows-nat.c (handle_exception): Move Cygwin code to
4297         windows-nat.c.  Call handle_access_violation.
4298
4299 2020-04-16  Tom de Vries  <tdevries@suse.de>
4300
4301         PR symtab/25791
4302         * dwarf2/index-write.c (write_gdbindex): Generate CU table entries for
4303         CUs without psymtab.
4304
4305 2020-04-16  Kevin Buettner  <kevinb@redhat.com>
4306
4307         * python/python.c (do_start_initialization): Don't call
4308         PyEval_InitThreads for Python 3.9 and beyond.
4309
4310 2020-04-15  Kamil Rytarowski  <n54@gmx.com>
4311
4312         * obsd-nat.c (obsd_nat_target::update_thread_list): Pass "this" to
4313         thread functions.
4314         (obsd_nat_target::wait): Likewise.
4315
4316 2020-04-15  Tom Tromey  <tromey@adacore.com>
4317
4318         * windows-nat.c (DEBUG_EXEC, DEBUG_EVENTS, DEBUG_MEM)
4319         (DEBUG_EXCEPT): Use debug_printf.
4320
4321 2020-04-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4322
4323         * completer.c (class completion_tracker::completion_hash_entry)
4324         <hash_name>: New member function.
4325         (completion_tracker::discard_completions): New callback to hash a
4326         completion_hash_entry, pass this to htab_create_alloc.
4327
4328 2016-01-20  Jon Turney  <jon.turney@dronecode.org.uk>
4329
4330         * windows-nat.c (windows_make_so): Warn rather than stopping with
4331         an error if realpath() fails.
4332
4333 2020-04-14  Kamil Rytarowski  <n54@gmx.com>
4334
4335         * nbsd-nat.c (nbsd_pid_to_kinfo_proc2): New.
4336         (nbsd_nat_target::info_proc): Add do_status.
4337
4338 2020-04-14  Simon Marchi  <simon.marchi@polymtl.ca>
4339             Tom de Vries  <tdevries@suse.de>
4340
4341         PR symtab/25718
4342         * psympriv.h (struct partial_symtab::read_symtab)
4343         (struct partial_symtab::expand_psymtab)
4344         (struct partial_symtab::read_dependencies): Update comments.
4345         * dwarf2/read.c (struct dwarf2_include_psymtab::read_symtab): Call
4346         read_symtab for includer.
4347         (struct dwarf2_include_psymtab::expand_psymtab): Assert false.
4348         (struct dwarf2_include_psymtab::readin_p): Call readin_p () for includer.
4349         (struct dwarf2_include_psymtab::m_readin): Remove.
4350         (struct dwarf2_include_psymtab::includer): New member function.
4351         (dwarf2_psymtab::expand_psymtab): Assert !readin.
4352
4353 2020-04-14  Tom de Vries  <tdevries@suse.de>
4354
4355         PR symtab/25720
4356         * symmisc.c (maintenance_expand_symtabs): Call expand_symtabs_matching
4357         with NULL symbol_matcher and lookup_name.
4358         * psymtab.c (psym_expand_symtabs_matching): Handle NULL symbol_matcher
4359         and lookup_name.
4360         * dwarf2/read.c (dw2_expand_symtabs_matching)
4361         (dw2_debug_names_expand_symtabs_matching): Same.
4362         * symfile.h (struct quick_symbol_functions::expand_symtabs_matching):
4363         Make lookup_name a pointer.  Update comment.
4364         * symtab.c (global_symbol_searcher::expand_symtabs): Handle
4365         lookup_name being a pointer.
4366         * symfile.c (expand_symtabs_matching): Same.
4367         * symfile-debug.c (debug_qf_expand_symtabs_matching): Same.
4368         * linespec.c (iterate_over_all_matching_symtabs): Same.
4369
4370 2020-04-13  Tom Tromey  <tom@tromey.com>
4371
4372         * run-on-main-thread.c: Update include.
4373         * unittests/main-thread-selftests.c: Update include.
4374         * tui/tui-win.c: Update include.
4375         * tui/tui-io.c: Update include.
4376         * tui/tui-interp.c: Update include.
4377         * tui/tui-hooks.c: Update include.
4378         * top.h: Update include.
4379         * top.c: Update include.
4380         * ser-base.c: Update include.
4381         * remote.c: Update include.
4382         * remote-notif.c: Update include.
4383         * remote-fileio.c: Update include.
4384         * record-full.c: Update include.
4385         * record-btrace.c: Update include.
4386         * python/python.c: Update include.
4387         * posix-hdep.c: Update include.
4388         * mingw-hdep.c: Update include.
4389         * mi/mi-main.c: Update include.
4390         * mi/mi-interp.c: Update include.
4391         * main.c: Update include.
4392         * linux-nat.c: Update include.
4393         * interps.c: Update include.
4394         * infrun.c: Update include.
4395         * inf-loop.c: Update include.
4396         * event-top.c: Update include.
4397         * event-loop.c: Move to ../gdbsupport/.
4398         * event-loop.h: Move to ../gdbsupport/.
4399         * async-event.h: Update include.
4400         * Makefile.in (COMMON_SFILES, HFILES_NO_SRCDIR): Update.
4401
4402 2020-04-13  Tom Tromey  <tom@tromey.com>
4403
4404         * tui/tui-win.c: Include async-event.h.
4405         * remote.c: Include async-event.h.
4406         * remote-notif.c: Include async-event.h.
4407         * record-full.c: Include async-event.h.
4408         * record-btrace.c: Include async-event.h.
4409         * infrun.c: Include async-event.h.
4410         * event-top.c: Include async-event.h.
4411         * event-loop.h: Move some declarations to async-event.h.
4412         * event-loop.c: Don't include ser-event.h or top.h.  Move some
4413         code to async-event.c.
4414         * async-event.h: New file.
4415         * async-event.c: New file.
4416         * Makefile.in (COMMON_SFILES): Add async-event.c.
4417         (HFILES_NO_SRCDIR): Add async-event.h.
4418
4419 2020-04-13  Tom Tromey  <tom@tromey.com>
4420
4421         * utils.c (flush_streams): New function.
4422         * event-loop.c (gdb_wait_for_event): Call flush_streams.
4423
4424 2020-04-13  Tom Tromey  <tom@tromey.com>
4425
4426         * event-loop.c (handle_file_event): Use warning, not
4427         printf_unfiltered.
4428
4429 2020-04-13  Tom Tromey  <tom@tromey.com>
4430
4431         * event-loop.c: Include <chrono>.
4432
4433 2020-04-13  Tom Tromey  <tom@tromey.com>
4434
4435         * gdb_select.h: Move to ../gdbsupport/.
4436         * event-loop.c: Update include path.
4437         * top.c: Update include path.
4438         * ser-base.c: Update include path.
4439         * ui-file.c: Update include path.
4440         * ser-tcp.c: Update include path.
4441         * guile/scm-ports.c: Update include path.
4442         * posix-hdep.c: Update include path.
4443         * ser-unix.c: Update include path.
4444         * gdb_usleep.c: Update include path.
4445         * mingw-hdep.c: Update include path.
4446         * inflow.c: Update include path.
4447         * infrun.c: Update include path.
4448         * event-top.c: Update include path.
4449
4450 2020-04-13  Tom Tromey  <tom@tromey.com>
4451
4452         * configure: Rebuild.
4453         * configure.ac: Remove checks that are now in GDB_AC_COMMON.
4454
4455 2020-04-13  Tom Tromey  <tom@tromey.com>
4456
4457         * event-loop.h (start_event_loop): Don't declare.
4458         * event-loop.c (start_event_loop): Move...
4459         * main.c (start_event_loop): ...here.  Now static.
4460
4461 2020-04-13  Sergio Durigan Junior  <sergiodj@sergiodj.net>
4462
4463         * MAINTAINERS: Update my email address.
4464
4465 2020-04-12  Kamil Rytarowski  <n54@gmx.com>
4466
4467         * nbsd-nat.c (nbsd_nat_target::info_proc): Add IP_MINIMAL and
4468         IP_ALL.
4469
4470 2020-04-12  Kamil Rytarowski  <n54@gmx.com>
4471
4472         * nbsd-nat.c (nbsd_pid_to_cmdline): Add.
4473         (nbsd_nat_target::info_proc): Add do_cmdline.
4474
4475 2020-04-12  Kamil Rytarowski  <n54@gmx.com>
4476
4477         * nbsd-nat.c (nbsd_pid_to_cwd): Add.
4478         (nbsd_nat_target::info_proc): Add do_cwd.
4479
4480 2020-04-12  Kamil Rytarowski  <n54@gmx.com>
4481
4482         * nbsd-nat.c (nbsd_nat_target::info_proc): Add do_exe.
4483
4484 2020-04-11  Kamil Rytarowski  <n54@gmx.com>
4485
4486         * nbsd-nat.c; Include "nbsd-tdep.h" and "gdbarch.h".
4487         * nbsd-nat.c (nbsd_nat_target::find_memory_regions)
4488         (nbsd_nat_target::info_proc): New functions.
4489         * nbsd-nat.c (kinfo_get_vmmap): New function.
4490         * nbsd-nat.c (nbsd_nat_target::info_proc) Use
4491         nbsd_info_proc_mappings_header and nbsd_info_proc_mappings_entry.
4492         * nbsd-tdep.c (nbsd_info_proc_mappings_header)
4493         (nbsd_info_proc_mappings_entry, nbsd_vm_map_entry_flags): New
4494         functions.
4495         * nbsd-tdep.c (KINFO_VME_PROT_READ, KINFO_VME_PROT_WRITE)
4496         (KINFO_VME_PROT_EXEC, KINFO_VME_FLAG_COW)
4497         (KINFO_VME_FLAG_NEEDS_COPY, KINFO_VME_FLAG_NOCOREDUMP)
4498         (KINFO_VME_FLAG_PAGEABLE, KINFO_VME_FLAG_GROWS_UP)
4499         (KINFO_VME_FLAG_GROWS_DOWN): New.
4500
4501 2020-04-10  Artur Shepilko  <nomadbyte@gmail.com>
4502
4503         * utils.c (copy_bitwise): Use unsigned 0 constant as operand of
4504         bit shift.
4505
4506 2020-04-10  Tom Tromey  <tromey@adacore.com>
4507
4508         * symfile.c (symbol_file_add_separate): Preserve OBJF_MAINLINE.
4509
4510 2020-04-10  Tom Tromey  <tromey@adacore.com>
4511
4512         * symtab.c (get_symbol_address, get_msymbol_address): Skip
4513         separate debug files.
4514
4515 2020-04-10  Hannes Domani  <ssbssa@yahoo.de>
4516
4517         * nat/windows-nat.c (STATUS_WX86_BREAKPOINT, STATUS_WX86_SINGLE_STEP):
4518         Move to...
4519         * nat/windows-nat.h (STATUS_WX86_BREAKPOINT, STATUS_WX86_SINGLE_STEP):
4520         ... here.
4521         * windows-nat.c (windows_nat_target::get_windows_debug_event):
4522         Check for STATUS_WX86_BREAKPOINT.
4523         (windows_nat_target::wait): Same.
4524
4525 2020-04-10  Tom de Vries  <tdevries@suse.de>
4526
4527         PR cli/25808
4528         * python/lib/gdb/__init__.py: Initialize lexer with stripnl=False.
4529
4530 2020-04-09  Simon Marchi  <simon.marchi@polymtl.ca>
4531
4532         * MAINTAINERS (Global Maintainers): Add Tom de Vries.
4533         (Write After Approval): Remove Tom de Vries.
4534
4535 2020-04-09  Bernd Edlinger  <bernd.edlinger@hotmail.de>
4536
4537         revert partially:
4538         2020-04-01  Bernd Edlinger  <bernd.edlinger@hotmail.de>
4539
4540         * buildsym.c (record_line): Fix undefined behavior and preserve
4541         lines at eof.
4542
4543 2020-04-09  Kamil Rytarowski  <n54@gmx.com>
4544
4545         * auxv.h (svr4_auxv_parse): New.
4546         * auxv.c (default_auxv_parse): Split into default_auxv_parse
4547         and generic_auxv_parse.
4548         (svr4_auxv_parse): Add.
4549         * obsd-tdep.c: Include "auxv.h".
4550         (obsd_auxv_parse): Remove.
4551         (obsd_init_abi): Remove comment.
4552         (obsd_init_abi): Change set_gdbarch_auxv_parse passed argument
4553         from `obsd_auxv_parse' to `svr4_auxv_parse'.
4554         * nbsd-tdep.c: Include "auxv.h".
4555         (nbsd_init_abi): Call set_gdbarch_auxv_parse.
4556
4557 2020-04-08  Tom Tromey  <tromey@adacore.com>
4558
4559         * nat/windows-nat.h (last_wait_event): Don't declare.
4560         (wait_for_debug_event): Update comment.
4561         * nat/windows-nat.c (last_wait_event): Now static.
4562
4563 2020-04-08  Tom Tromey  <tromey@adacore.com>
4564
4565         * windows-nat.c (wait_for_debug_event): Move to
4566         nat/windows-nat.c.
4567         * nat/windows-nat.h (wait_for_debug_event): Declare.
4568         * nat/windows-nat.c (wait_for_debug_event): Move from
4569         windows-nat.c.  No longer static.
4570
4571 2020-04-08  Tom Tromey  <tromey@adacore.com>
4572
4573         * windows-nat.c (get_windows_debug_event): Use
4574         fetch_pending_stop.
4575         * nat/windows-nat.h (fetch_pending_stop): Declare.
4576         * nat/windows-nat.c (fetch_pending_stop): New function.
4577
4578 2020-04-08  Tom Tromey  <tromey@adacore.com>
4579
4580         * windows-nat.c (windows_continue): Use matching_pending_stop and
4581         continue_last_debug_event.
4582         * nat/windows-nat.h (matching_pending_stop)
4583         (continue_last_debug_event): Declare.
4584         * nat/windows-nat.c (DEBUG_EVENTS): New define.
4585         (matching_pending_stop, continue_last_debug_event): New
4586         functions.
4587
4588 2020-04-08  Tom Tromey  <tromey@adacore.com>
4589
4590         * windows-nat.c (MS_VC_EXCEPTION): Move to nat/windows-nat.c.
4591         (handle_exception_result): Move to nat/windows-nat.h.
4592         (DEBUG_EXCEPTION_SIMPLE): Remove.
4593         (windows_nat::handle_ms_vc_exception): New function.
4594         (handle_exception): Move to nat/windows-nat.c.
4595         (get_windows_debug_event): Update.
4596         (STATUS_WX86_BREAKPOINT, STATUS_WX86_SINGLE_STEP): Move to
4597         nat/windows-nat.c.
4598         * nat/windows-nat.h (handle_ms_vc_exception): Declare.
4599         (handle_exception_result): Move from windows-nat.c.
4600         (handle_exception): Declare.
4601         * nat/windows-nat.c (MS_VC_EXCEPTION, handle_exception)
4602         (STATUS_WX86_SINGLE_STEP, STATUS_WX86_BREAKPOINT): Move from
4603         windows-nat.c.
4604
4605 2020-04-08  Tom Tromey  <tromey@adacore.com>
4606
4607         * windows-nat.c (exception_count, event_count): Remove.
4608         (handle_exception, get_windows_debug_event)
4609         (do_initial_windows_stuff): Update.
4610
4611 2020-04-08  Tom Tromey  <tromey@adacore.com>
4612
4613         * windows-nat.c (windows_nat::handle_load_dll)
4614         (windows_nat::handle_unload_dll): Rename.  No longer static.
4615         * nat/windows-nat.h (handle_load_dll, handle_unload_dll):
4616         Declare.
4617
4618 2020-04-08  Tom Tromey  <tromey@adacore.com>
4619
4620         * complaints.h (stop_whining): Declare at top-level.
4621         (complaint): Don't declare stop_whining.
4622
4623 2020-04-08  Tom Tromey  <tromey@adacore.com>
4624
4625         * windows-nat.c (windows_nat::handle_output_debug_string):
4626         Rename.  No longer static.
4627         * nat/windows-nat.h (handle_output_debug_string): Declare.
4628
4629 2020-04-08  Tom Tromey  <tromey@adacore.com>
4630
4631         * windows-nat.c (current_process_handle, current_process_id)
4632         (main_thread_id, last_sig, current_event, last_wait_event)
4633         (current_windows_thread, desired_stop_thread_id, pending_stops)
4634         (struct pending_stop, siginfo_er): Move to nat/windows-nat.c.
4635         (display_selectors, fake_create_process)
4636         (get_windows_debug_event): Update.
4637         * nat/windows-nat.h (current_process_handle, current_process_id)
4638         (main_thread_id, last_sig, current_event, last_wait_event)
4639         (current_windows_thread, desired_stop_thread_id, pending_stops)
4640         (struct pending_stop, siginfo_er): Move from windows-nat.c.
4641         * nat/windows-nat.c (current_process_handle, current_process_id)
4642         (main_thread_id, last_sig, current_event, last_wait_event)
4643         (current_windows_thread, desired_stop_thread_id, pending_stops)
4644         (siginfo_er): New globals.  Move from windows-nat.c.
4645
4646 2020-04-08  Tom Tromey  <tromey@adacore.com>
4647
4648         * windows-nat.c (get_image_name): Move to nat/windows-nat.c.
4649         (handle_load_dll): Update.
4650         * nat/windows-nat.c (get_image_name): Move from windows-nat.c.
4651
4652 2020-04-08  Tom Tromey  <tromey@adacore.com>
4653
4654         * windows-nat.c (enum thread_disposition_type): Move to
4655         nat/windows-nat.h.
4656         (windows_nat::thread_rec): Rename from thread_rec.  No longer
4657         static.
4658         (windows_add_thread, windows_nat_target::fetch_registers)
4659         (windows_nat_target::store_registers, handle_exception)
4660         (windows_nat_target::resume, get_windows_debug_event)
4661         (windows_nat_target::get_tib_address)
4662         (windows_nat_target::thread_name)
4663         (windows_nat_target::thread_alive): Update.
4664         * nat/windows-nat.h (enum thread_disposition_type): Move from
4665         windows-nat.c.
4666         (thread_rec): Declare.
4667
4668 2020-04-08  Tom Tromey  <tromey@adacore.com>
4669
4670         * windows-nat.c: Add "using namespace".
4671         * nat/windows-nat.h: Wrap contents in windows_nat namespace.
4672         * nat/windows-nat.c: Wrap contents in windows_nat namespace.
4673
4674 2020-04-08  Tom Tromey  <tromey@adacore.com>
4675
4676         * nat/windows-nat.h (struct windows_thread_info): Declare
4677         destructor.
4678         * nat/windows-nat.c (~windows_thread_info): New.
4679
4680 2020-04-08  Tom Tromey  <tromey@adacore.com>
4681
4682         PR gdb/22992
4683         * windows-nat.c (current_event): Update comment.
4684         (last_wait_event, desired_stop_thread_id): New globals.
4685         (struct pending_stop): New.
4686         (pending_stops): New global.
4687         (windows_nat_target) <stopped_by_sw_breakpoint>
4688         <supports_stopped_by_sw_breakpoint>: New methods.
4689         (windows_fetch_one_register): Add assertions.  Adjust PC.
4690         (windows_continue): Handle pending stops.  Suspend other threads
4691         when stepping.  Use last_wait_event
4692         (wait_for_debug_event): New function.
4693         (get_windows_debug_event): Use wait_for_debug_event.  Handle
4694         pending stops.  Queue spurious stops.
4695         (windows_nat_target::wait): Set stopped_at_software_breakpoint.
4696         (windows_nat_target::kill): Use wait_for_debug_event.
4697         * nat/windows-nat.h (struct windows_thread_info)
4698         <stopped_at_software_breakpoint>: New field.
4699         * nat/windows-nat.c (windows_thread_info::resume): Clear
4700         stopped_at_software_breakpoint.
4701
4702 2020-04-08  Tom Tromey  <tromey@adacore.com>
4703
4704         * windows-nat.c (enum thread_disposition_type): New.
4705         (thread_rec): Replace "get_context" parameter with "disposition";
4706         change type.
4707         (windows_add_thread, windows_nat_target::fetch_registers)
4708         (windows_nat_target::store_registers, handle_exception)
4709         (windows_nat_target::resume, get_windows_debug_event)
4710         (windows_nat_target::get_tib_address)
4711         (windows_nat_target::thread_name)
4712         (windows_nat_target::thread_alive): Update.
4713
4714 2020-04-08  Tom Tromey  <tromey@adacore.com>
4715
4716         * windows-nat.c (thread_rec): Use windows_thread_info::suspend.
4717         (windows_continue): Use windows_continue::resume.
4718         * nat/windows-nat.h (struct windows_thread_info) <suspend,
4719         resume>: Declare new methods.
4720         * nat/windows-nat.c: New file.
4721         * configure.nat (NATDEPFILES): Add nat/windows-nat.o when needed.
4722
4723 2020-04-08  Tom Tromey  <tromey@adacore.com>
4724
4725         * windows-nat.c (windows_add_thread, windows_delete_thread)
4726         (windows_nat_target::fetch_registers)
4727         (windows_nat_target::store_registers, fake_create_process)
4728         (windows_nat_target::resume, windows_nat_target::resume)
4729         (get_windows_debug_event, windows_nat_target::wait)
4730         (windows_nat_target::pid_to_str)
4731         (windows_nat_target::get_tib_address)
4732         (windows_nat_target::get_ada_task_ptid)
4733         (windows_nat_target::thread_name)
4734         (windows_nat_target::thread_alive): Use lwp, not tid.
4735
4736 2020-04-08  Tom Tromey  <tromey@adacore.com>
4737
4738         * windows-nat.c (handle_exception)
4739         (windows_nat_target::thread_name): Update.
4740         * nat/windows-nat.h (windows_thread_info): Remove destructor.
4741         <name>: Now unique_xmalloc_ptr.
4742
4743 2020-04-08  Tom Tromey  <tromey@adacore.com>
4744
4745         * windows-nat.c (thread_rec)
4746         (windows_nat_target::fetch_registers): Update.
4747         * nat/windows-nat.h (struct windows_thread_info) <suspended>:
4748         Update comment.
4749         <debug_registers_changed, reload_context>: Now bool.
4750
4751 2020-04-08  Tom Tromey  <tromey@adacore.com>
4752
4753         * windows-nat.c (windows_add_thread): Use new.
4754         (windows_init_thread_list, windows_delete_thread): Use delete.
4755         (get_windows_debug_event): Update.
4756         * nat/windows-nat.h (struct windows_thread_info): Add constructor,
4757         destructor, and initializers.
4758
4759 2020-04-08  Tom Tromey  <tromey@adacore.com>
4760
4761         * windows-nat.c (struct windows_thread_info): Remove.
4762         * nat/windows-nat.h: New file.
4763
4764 2020-04-08  Tom Tromey  <tromey@adacore.com>
4765
4766         * windows-nat.c (struct windows_thread_info) <tid>: Rename from "id".
4767         (thread_rec, windows_add_thread, windows_delete_thread)
4768         (windows_continue): Update.
4769
4770 2020-04-08  Tom Tromey  <tromey@adacore.com>
4771
4772         * windows-nat.c (struct windows_thread_info): Remove typedef.
4773         (thread_head): Remove.
4774         (thread_list): New global.
4775         (thread_rec, windows_add_thread, windows_init_thread_list)
4776         (windows_delete_thread, windows_continue): Update.
4777
4778 2020-04-08  Simon Marchi  <simon.marchi@polymtl.ca>
4779
4780         * windows-tdep.h (windows_init_abi): Add comment.
4781         (cygwin_init_abi): New declaration.
4782         * windows-tdep.c: Split signal enumeration in two, one for
4783         Windows and one for Cygwin.
4784         (windows_gdb_signal_to_target): Only deal with signal of the
4785         Windows OS ABI.
4786         (cygwin_gdb_signal_to_target): New function.
4787         (windows_init_abi): Rename to windows_init_abi_common, don't set
4788         gdb_signal_to_target gdbarch method.  Add new new function with
4789         this name.
4790         (cygwin_init_abi): New function.
4791         * amd64-windows-tdep.c (amd64_windows_init_abi_common): Add
4792         comment.  Don't call windows_init_abi.
4793         (amd64_windows_init_abi): Add comment, call windows_init_abi.
4794         (amd64_cygwin_init_abi): Add comment, call cygwin_init_abi.
4795         * i386-windows-tdep.c (i386_windows_init_abi): Rename to
4796         i386_windows_init_abi_common, don't call windows_init_abi.  Add
4797         a new function of this name.
4798         (i386_cygwin_init_abi): New function.
4799         (_initialize_i386_windows_tdep): Bind i386_cygwin_init_abi to
4800         OS ABI Cygwin.
4801
4802 2020-04-08  Simon Marchi  <simon.marchi@polymtl.ca>
4803
4804         * dwarf2/read.c (read_gdb_index_from_buffer): Remove objfile
4805         parameter.c.
4806         (dwarf2_read_gdb_index): Update.
4807
4808 2020-04-07  Kamil Rytarowski  <n54@gmx.com>
4809
4810         * nbsd-tdep.c: Include "objfiles.h".
4811         (nbsd_skip_solib_resolver): New.
4812         (nbsd_init_abi): Call set_gdbarch_skip_solib_resolver().
4813
4814 2020-04-07  Nitika Achra  <Nitika.Achra@amd.com>
4815
4816         * dwarf2/loc.c (loclist_describe_location): Call the function decode_debug_loclists_
4817         addresses if DWARF version is 5 or more because DW_LLE_start* or DW_LLE_offset_pair
4818         with DW_LLE_base_addressx are being emitted in DWARFv5.
4819         Add the newly added kind DW_LOC_OFFSET_PAIR also.
4820         The length of location description is an unsigned ULEB integer in DWARFv5 instead of
4821         unsigned integer.
4822
4823 2020-04-07  Nitika Achra  <Nitika.Achra@amd.com>
4824
4825         * dwarf2/loc.c (enum debug_loc_kind): Add a new kind DEBUG_LOC_OFFSET_PAIR.
4826         (dwarf2_find_location_expression): Call the function decode_debug_loclists_
4827         addresses if DWARF version is 5 or more. DW_LLE_start* or DW_LLE_offset_pair
4828         with DW_LLE_base_addressx are being emitted in DWARFv5 instead of DW_LLE_GNU*.
4829         Add applicable base address if the entry is DW_LLE_offset_pair from DWO.
4830         (decode_debug_loclists_addresses): Return DEBUG_LOC_OFFSET_PAIR instead of
4831         DEBUG_LOC_START_END in case of DW_LLE_offset_pair.
4832
4833
4834 2020-04-07  Nitika Achra  <Nitika.Achra@amd.com>
4835
4836         * dwarf2/read.c (cu_debug_loc_section): Added the declaration for the function.
4837         (read_loclist_index): New function definition.
4838         (lookup_loclist_base): New function definition.
4839         (read_loclist_header): New function definition.
4840         (dwarf2_cu): Add loclist_base and loclist_header field.
4841         (dwarf2_locate_dwo_sections): Handle .debug_loclists.dwo section.
4842         (read_full_die_1): Read the value of DW_AT_loclists_base.
4843         (read_attribute_reprocess): Handle DW_FORM_loclistx.
4844         (read_attribute_value): Handle DW_FORM_loclistx.
4845         (skip_one_die): Handle DW_FORM_loclistx.
4846         (loclist_header): New structure declaration.
4847         * dwarf2/attribute.c (form_is_section_offset): Handle DW_FORM_loclistx.
4848
4849 2020-04-07  Simon Marchi  <simon.marchi@polymtl.ca>
4850
4851         * dwarf2/read.h (struct dwarf2_psymtab): Remove two-parameters
4852         constructor.  Remove `addr` parameter from other constructor and
4853         add `per_cu` parameter.
4854         * dwarf2/read.c (create_partial_symtab): Update.
4855
4856 2020-04-07  Tom de Vries  <tdevries@suse.de>
4857
4858         PR symtab/25796
4859         * dwarf2/read.c (can_have_DW_AT_const_value_p): New function.
4860         (partial_die_info::fixup): Inherit has_const_value.
4861
4862 2020-04-07  Tom de Vries  <tdevries@suse.de>
4863
4864         * psymtab.c (maintenance_check_psymtabs): Skip static LOC_BLOCK
4865         symbols without address.
4866
4867 2020-04-06  Kamil Rytarowski  <n54@gmx.com>
4868
4869         * nbsd-nat.h (struct thread_info): Add forward declaration.
4870         (nbsd_nat_target::thread_alive): Add.
4871         (nbsd_nat_target::thread_name): Likewise.
4872         (nbsd_nat_target::update_thread_list): Likewise.
4873         (update_thread_list::post_attach): Likewise.
4874         (post_attach::pid_to_str): Likewise.
4875         * nbsd-nat.c: Include "gdbthread.h" and "inferior.h".
4876         (nbsd_thread_lister): Add.
4877         (nbsd_nat_target::thread_alive): Likewise.
4878         (nbsd_nat_target::thread_name): Likewise.
4879         (nbsd_add_threads): Likewise.
4880         (update_thread_list::post_attach): Likewise.
4881         (nbsd_nat_target::update_thread_list): Likewise.
4882         (post_attach::pid_to_str): Likewise.
4883
4884 2020-04-06  Tom Tromey  <tromey@adacore.com>
4885
4886         * ada-valprint.c (print_variant_part): Extract the variant field.
4887         (print_field_values): Use the field as the outer value when
4888         recursing.
4889
4890 2020-04-06  Tom Tromey  <tromey@adacore.com>
4891
4892         * sh-nbsd-tdep.c: Include nbsd-tdep.h.
4893         * ppc-nbsd-tdep.c: Include nbsd-tdep.h.
4894         * mips-nbsd-tdep.c (mipsnbsd_init_abi): Add missing ";".
4895         * arm-nbsd-tdep.c: Include nbsd-tdep.h.
4896         * hppa-nbsd-tdep.c: Include nbsd-tdep.h.
4897
4898 2020-04-06  Tom Tromey  <tromey@adacore.com>
4899
4900         * dwarf2/read.c (read_base_type) <DW_ATE_complex_float>: Handle
4901         TYPE_CODE_ERROR.
4902
4903 2020-04-06  Kamil Rytarowski  <n54@gmx.com>
4904
4905         * nbsd-tdep.c: Include "gdbarch.h".
4906         Define enum with NetBSD signal numbers.
4907         (nbsd_gdb_signal_from_target, nbsd_gdb_signal_to_target): New.
4908         * alpha-nbsd-tdep.c (alphanbsd_init_abi): Call nbsd_init_abi().
4909         * amd64-nbsd-tdep.c (amd64nbsd_init_abi): Likewise.
4910         * arm-nbsd-tdep.c (arm_netbsd_elf_init_abi): Likewise.
4911         * hppa-nbsd-tdep.c (hppanbsd_init_abi): Likewise.
4912         * i386-nbsd-tdep.c (i386nbsd_init_abi): Likewise.
4913         * mips-nbsd-tdep.c (nbsd_init_abi): Likewise.
4914         * ppc-nbsd-tdep.c (ppcnbsd_init_abi): Likewise.
4915         * sh-nbsd-tdep.c (shnbsd_init_abi): Likewise.
4916         * sparc-nbsd-tdep.c (sparc32nbsd_init_abi): Likewise.
4917         * sparc64-nbsd-tdep.c (sparc64nbsd_init_abi): Likewise.
4918         * vax-nbsd-tdep.c (vaxnbsd_elf_init_abi): Likewise.
4919
4920 2020-04-03  Hannes Domani  <ssbssa@yahoo.de>
4921
4922         PR gdb/25325
4923         * dwarf2/read.c (read_enumeration_type): Fix typed enum attributes.
4924
4925 2020-04-03  Tom Tromey  <tromey@adacore.com>
4926
4927         * dwarf2/loc.c (disassemble_dwarf_expression) <DW_OP_const_type>:
4928         Read constant block.
4929
4930 2020-04-02  Simon Marchi  <simon.marchi@polymtl.ca>
4931
4932         * gdb_bfd.h: Include gdbsupport/byte-vector.h.
4933         (gdb_bfd_get_full_section_contents): New declaration.
4934         * gdb_bfd.c (gdb_bfd_get_full_section_contents): New function.
4935         * windows-tdep.c (is_linked_with_cygwin_dll): Use
4936         gdb_bfd_get_full_section_contents.
4937
4938 2020-04-02  Simon Marchi  <simon.marchi@polymtl.ca>
4939
4940         * exec.c (build_section_table): Replace internal_error with
4941         gdb_assert.
4942         (section_table_xfer_memory_partial): Likewise.
4943         * mdebugread.c (parse_partial_symbols): Likewise.
4944         * psymtab.c (lookup_partial_symbol): Likewise.
4945         * utils.c (wrap_here): Likewise.
4946
4947 2020-04-02  Tom Tromey  <tromey@adacore.com>
4948
4949         * f-lang.c (build_fortran_types): Use arch_type to initialize
4950         builtin_complex_s32 in the TYPE_CODE_ERROR case.
4951
4952 2020-04-02  Tom Tromey  <tromey@adacore.com>
4953
4954         * dwarf2/read.c (partial_die_info::read): Do not create a vector
4955         of attributes.
4956
4957 2020-04-02  Andrew Burgess  <andrew.burgess@embecosm.com>
4958             Bernd Edlinger <bernd.edlinger@hotmail.de>
4959             Tom Tromey  <tromey@adacore.com>
4960
4961         * buildsym.c (buildsym_compunit::record_line): Remove
4962         deduplication code.
4963
4964 2020-04-02  Tom de Vries  <tdevries@suse.de>
4965
4966         PR ada/24671
4967         * dwarf2/read.c (dw2_map_matching_symbols): Handle -readnow.
4968
4969 2020-04-02  Tom de Vries  <tdevries@suse.de>
4970
4971         * dwarf2/read.c (dwarf2_gdb_index_functions,
4972         dwarf2_debug_names_functions): Init lookup_global_symbol_language with
4973         NULL.
4974         * psymtab.c (psym_lookup_global_symbol_language): New function.
4975         (psym_functions): Init psym_lookup_global_symbol_language with
4976         psym_lookup_global_symbol_language.
4977         * symfile-debug.c (debug_sym_quick_functions): Init
4978         lookup_global_symbol_language with NULL.
4979         * symfile.c (set_initial_language): Remove fixme comment.
4980         * symfile.h (struct quick_symbol_functions): Add
4981         lookup_global_symbol_language.
4982         * symtab.c (find_quick_global_symbol_language): New function.
4983         (find_main_name): Use find_quick_global_symbol_language.
4984
4985 2020-04-01  Simon Marchi  <simon.marchi@polymtl.ca>
4986
4987         * windows-tdep.c (is_linked_with_cygwin_dll): Fix style.
4988
4989 2020-04-01  Bernd Edlinger  <bernd.edlinger@hotmail.de>
4990
4991         * buildsym.c (record_line): Fix undefined behavior and preserve
4992         lines at eof.
4993
4994 2020-04-01  Bernd Edlinger  <bernd.edlinger@hotmail.de>
4995
4996         * buildsym.c (record_line): Fix the resizing condition.
4997
4998 2020-04-01  Tom Tromey  <tom@tromey.com>
4999
5000         * value.h (value_literal_complex): Add comment.
5001         * valops.c (value_literal_complex): Refer to value.h.
5002
5003 2020-04-01  Tom Tromey  <tom@tromey.com>
5004
5005         * c-exp.y (FLOAT_KEYWORD, COMPLEX): New tokens.
5006         (scalar_type): New rule, from typebase.
5007         (typebase): Use scalar_type.  Recognize complex types.
5008         (field_name): Handle FLOAT_KEYWORD.
5009         (ident_tokens): Add _Complex and __complex__.
5010
5011 2020-04-01  Tom Tromey  <tom@tromey.com>
5012
5013         PR exp/25299:
5014         * valarith.c (promotion_type, complex_binop): New functions.
5015         (scalar_binop): Handle complex numbers.  Use promotion_type.
5016         (value_pos, value_neg, value_complement): Handle complex numbers.
5017
5018 2020-04-01  Tom Tromey  <tom@tromey.com>
5019
5020         * c-exp.y (COMPLEX_INT, COMPLEX_FLOAT): New tokens.
5021         (exp) <COMPLEX_INT, COMPLEX_FLOAT>: New rules.
5022         (parse_number): Handle complex numbers.
5023
5024 2020-04-01  Tom Tromey  <tom@tromey.com>
5025
5026         * c-valprint.c (c_decorations): Change complex suffix to "i".
5027
5028 2020-04-01  Tom Tromey  <tom@tromey.com>
5029
5030         * valprint.c (generic_value_print_complex): Use accessors.
5031         * value.h (value_real_part, value_imaginary_part): Declare.
5032         * valops.c (value_real_part, value_imaginary_part): New
5033         functions.
5034         * value.c (creal_internal_fn, cimag_internal_fn): Use accessors.
5035
5036 2020-04-01  Tom Tromey  <tom@tromey.com>
5037
5038         * stabsread.c (rs6000_builtin_type, read_sun_floating_type)
5039         (read_range_type): Update.
5040         * mdebugread.c (basic_type): Update.
5041         * go-lang.c (build_go_types): Use init_complex_type.
5042         * gdbtypes.h (struct main_type) <complex_type>: New member.
5043         (init_complex_type): Update.
5044         (arch_complex_type): Don't declare.
5045         * gdbtypes.c (init_complex_type): Remove "objfile" parameter.
5046         Make name if none given.  Use alloc_type_copy.  Look for cached
5047         complex type.
5048         (arch_complex_type): Remove.
5049         (gdbtypes_post_init): Use init_complex_type.
5050         * f-lang.c (build_fortran_types): Use init_complex_type.
5051         * dwarf2/read.c (read_base_type): Update.
5052         * d-lang.c (build_d_types): Use init_complex_type.
5053         * ctfread.c (read_base_type): Update.
5054
5055 2020-04-01  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
5056
5057         * infrun.c (stop_all_threads): Update assertion, plus when
5058         stopping threads, take into account that we might be trying
5059         to stop an all-stop target.
5060         (stop_waiting): Call 'stop_all_threads' if there exists a
5061         non-stop target.
5062
5063 2020-04-01  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
5064
5065         * target.h (exists_non_stop_target): New function declaration.
5066         * target.c (exists_non_stop_target): New function.
5067
5068 2020-04-01  Hannes Domani  <ssbssa@yahoo.de>
5069
5070         PR gdb/24789
5071         * eval.c (is_integral_or_integral_reference): New function.
5072         (evaluate_subexp_standard): Allow integer references in
5073         pointer arithmetic.
5074
5075 2020-04-01  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
5076
5077         * remote.c (remote_target::remote_parse_stop_reply): Remove the
5078         check for no ptid in the stop reply when the target is non-stop.
5079
5080 2020-04-01  Tom Tromey  <tromey@adacore.com>
5081
5082         * symtab.h (class lookup_name_info) <lookup_name_info>: Change
5083         "name" parameter to rvalue reference.  Initialize m_name_holder.
5084         <lookup_name_info>: New overloads.
5085         <name>: Return gdb::string_view.
5086         <c_str>: New method.
5087         <make_ignore_params>: Update.
5088         <search_name_hash>: Update.
5089         <language_lookup_name>: Return const char *.
5090         <m_name>: Change type.
5091         * symtab.c (demangle_for_lookup_info::demangle_for_lookup_info)
5092         (demangle_for_lookup_info::demangle_for_lookup_info): Update.
5093         (lookup_name_info::match_any): Update.
5094         * psymtab.c (match_partial_symbol, lookup_partial_symbol):
5095         Update.
5096         * minsyms.c (linkage_name_str): Update.
5097         * language.c (default_symbol_name_matcher): Update.
5098         * dwarf2/read.c (mapped_index_base::find_name_components_bounds):
5099         Update.
5100         * ada-lang.c (ada_fold_name): Change parameter to string_view.
5101         (ada_lookup_name_info::ada_lookup_name_info): Update.
5102         (literal_symbol_name_matcher): Update.
5103
5104 2020-04-01  Tom Tromey  <tromey@adacore.com>
5105
5106         * psymtab.c (psymtab_search_name): Remove function.
5107         (psym_lookup_symbol): Create search name and lookup name here.
5108         (lookup_partial_symbol): Remove "name" parameter; add
5109         lookup_name.
5110         (psym_expand_symtabs_for_function): Update.
5111
5112 2020-03-31  Joel Jones  <joelkevinjones@gmail.com>
5113
5114         PR tui/25597:
5115         * python/py-tui.c: Include gdb_curses.h inside of #ifdef TUI.
5116
5117 2020-03-31  Tom Tromey  <tromey@adacore.com>
5118
5119         * dwarf2/abbrev.c (abbrev_table::read): Conditionally call
5120         memcpy.
5121
5122 2020-03-30  Nelson Chu  <nelson.chu@sifive.com>
5123
5124         * features/riscv/32bit-csr.xml: Regenerated.
5125         * features/riscv/64bit-csr.xml: Regenerated.
5126
5127 2020-03-30  Tom Tromey  <tromey@adacore.com>
5128
5129         * ada-valprint.c (print_variant_part): Update.
5130         * ada-lang.h (ada_which_variant_applies): Update.
5131         * ada-lang.c (ada_which_variant_applies): Remove outer_type and
5132         outer_valaddr parameters; replace with "outer" value parameter.
5133         (to_fixed_variant_branch_type): Update.
5134
5135 2020-03-30  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
5136
5137         * ppc-linux-nat.c: Include <algorithm>, <unordered_map>, and
5138         <list>.  Remove inclusion of observable.h.
5139         (PPC_DEBUG_CURRENT_VERSION): Move up define.
5140         (struct arch_lwp_info): New struct.
5141         (class ppc_linux_dreg_interface): New class.
5142         (struct ppc_linux_process_info): New struct.
5143         (struct ppc_linux_nat_target) <low_delete_thread, low_new_fork>
5144         <low_new_clone, low_forget_process, low_prepare_to_resume>
5145         <copy_thread_dreg_state, mark_thread_stale>
5146         <mark_debug_registers_changed, register_hw_breakpoint>
5147         <clear_hw_breakpoint, register_wp, clear_wp>
5148         <can_use_watchpoint_cond_accel, calculate_dvc, check_condition>
5149         <num_memory_accesses, get_trigger_type>
5150         <create_watchpoint_request, hwdebug_point_cmp>
5151         <init_arch_lwp_info, get_arch_lwp_info>
5152         <low_stopped_by_watchpoint, low_stopped_data_address>: Declare as
5153         methods.
5154         <struct ptid_hash>: New inner struct.
5155         <m_dreg_interface, m_process_info, m_installed_hw_bps>: Declare
5156         members.
5157         (saved_dabr_value, hwdebug_info, max_slots_number)
5158         (struct hw_break_tuple, struct thread_points, ppc_threads)
5159         (have_ptrace_hwdebug_interface)
5160         (hwdebug_find_thread_points_by_tid)
5161         (hwdebug_insert_point, hwdebug_remove_point): Remove.
5162         (ppc_linux_nat_target::can_use_hw_breakpoint): Use
5163         m_dreg_interface, remove call to PTRACE_SET_DEBUGREG.
5164         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Add comment,
5165         use m_dreg_interface.
5166         (hwdebug_point_cmp): Change to...
5167         (ppc_linux_nat_target::hwdebug_point_cmp): ...this method.  Use
5168         reference arguments instead of pointers.
5169         (ppc_linux_nat_target::ranged_break_num_registers): Use
5170         m_dreg_interface.
5171         (ppc_linux_nat_target::insert_hw_breakpoint): Add comment, use
5172         m_dreg_interface.  Call register_hw_breakpoint.
5173         (ppc_linux_nat_target::remove_hw_breakpoint): Add comment, use
5174         m_dreg_interface.  Call clear_hw_breakpoint.
5175         (get_trigger_type): Change to...
5176         (ppc_linux_nat_target::get_trigger_type): ...this method.  Add
5177         comment.
5178         (ppc_linux_nat_target::insert_mask_watchpoint): Update comment,
5179         use m_dreg_interface.  Call register_hw_breakpoint.
5180         (ppc_linux_nat_target::remove_mask_watchpoint): Update comment,
5181         use m_dreg_interface.  Call clear_hw_breakpoint.
5182         (can_use_watchpoint_cond_accel): Change to...
5183         (ppc_linux_nat_target::can_use_watchpoint_cond_accel): ...this
5184         method.  Update comment, use m_dreg_interface and
5185         m_process_info.
5186         (calculate_dvc): Change to...
5187         (ppc_linux_nat_target::calculate_dvc): ...this method.  Use
5188         m_dreg_interface.
5189         (num_memory_accesses): Change to...
5190         (ppc_linux_nat_target::num_memory_accesses): ...this method.
5191         (check_condition): Change to...
5192         (ppc_linux_nat_target::check_condition): ...this method.
5193         (ppc_linux_nat_target::can_accel_watchpoint_condition): Update
5194         comment, use m_dreg_interface.
5195         (create_watchpoint_request): Change to...
5196         (ppc_linux_nat_target::create_watchpoint_request): ...this
5197         method.  Use m_dreg_interface.
5198         (ppc_linux_nat_target::insert_watchpoint): Add comment, use
5199         m_dreg_interface.  Call register_hw_breakpoint or register_wp.
5200         (ppc_linux_nat_target::remove_watchpoint): Add comment, use
5201         m_dreg_interface.  Call clear_hw_breakpoint or clear_wp.
5202         (ppc_linux_nat_target::low_forget_process)
5203         (ppc_linux_nat_target::low_new_fork)
5204         (ppc_linux_nat_target::low_new_clone)
5205         (ppc_linux_nat_target::low_delete_thread)
5206         (ppc_linux_nat_target::low_prepare_to_resume): New methods.
5207         (ppc_linux_nat_target::low_new_thread): Remove previous logic,
5208         only call mark_thread_stale.
5209         (ppc_linux_thread_exit): Remove.
5210         (ppc_linux_nat_target::stopped_data_address): Change to...
5211         (ppc_linux_nat_target::low_stopped_data_address): This. Add
5212         comment, use m_dreg_interface and m_thread_hw_breakpoints.
5213         (ppc_linux_nat_target::stopped_by_watchpoint): Change to...
5214         (ppc_linux_nat_target::stopped_by_watchpoint): This.  Add
5215         comment.  Call low_stopped_data_address.
5216         (ppc_linux_nat_target::watchpoint_addr_within_range): Use
5217         m_dreg_interface.
5218         (ppc_linux_nat_target::masked_watch_num_registers): Use
5219         m_dreg_interface.
5220         (ppc_linux_nat_target::copy_thread_dreg_state)
5221         (ppc_linux_nat_target::mark_thread_stale)
5222         (ppc_linux_nat_target::mark_debug_registers_changed)
5223         (ppc_linux_nat_target::register_hw_breakpoint)
5224         (ppc_linux_nat_target::clear_hw_breakpoint)
5225         (ppc_linux_nat_target::register_wp)
5226         (ppc_linux_nat_target::clear_wp)
5227         (ppc_linux_nat_target::init_arch_lwp_info)
5228         (ppc_linux_nat_target::get_arch_lwp_info): New methods.
5229         (_initialize_ppc_linux_nat): Remove observer callback.
5230
5231 2020-03-30  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
5232
5233         * ppc-linux-nat.c (ppc_linux_nat_target::store_registers)
5234         (ppc_linux_nat_target::auxv_parse)
5235         (ppc_linux_nat_target::read_description)
5236         (supply_gregset, fill_gregset, supply_fpregset, fill_fpregset):
5237         Move up.
5238
5239 2020-03-30  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
5240
5241         * linux-nat.h (low_new_clone): New method.
5242         * linux-nat.c (linux_handle_extended_wait): Call low_new_clone.
5243
5244 2020-03-29  Simon Marchi  <simon.marchi@polymtl.ca>
5245
5246         * dbxread.c (dbx_psymtab_to_symtab_1): Rename to...
5247         (dbx_expand_psymtab): ... this.
5248         (start_psymtab): Update.
5249         * mdebugread.c (psymtab_to_symtab_1): Rename to...
5250         (mdebug_expand_psymtab): ... this.
5251         (parse_partial_symbols): Update.
5252         (new_psymtab): Update.
5253         * xcoffread.c (xcoff_psymtab_to_symtab_1): Rename to...
5254         (xcoff_expand_psymtab): ... this.
5255         (xcoff_start_psymtab): Update.
5256
5257 2020-03-29  Simon Marchi  <simon.marchi@polymtl.ca>
5258
5259         * psympriv.h (partial_symtab) <read_dependencies>: Rename to...
5260         <expand_dependencies>: ... this.
5261         * psymtab.c (partial_symtab::read_dependencies): Rename to...
5262         (partial_symtab::expand_dependencies): ... this.
5263         * dwarf2/read.c (dwarf2_include_psymtab) <expand_psymtab>:
5264         Update.
5265         (dwarf2_psymtab::expand_psymtab): Update.
5266         * dbxread.c (dbx_psymtab_to_symtab_1): Update.
5267         * mdebugread.c (psymtab_to_symtab_1): Update.
5268         * xcoffread.c (xcoff_psymtab_to_symtab_1): Update.
5269
5270 2020-03-29  Simon Marchi  <simon.marchi@polymtl.ca>
5271
5272         * psympriv.h (discard_psymtab): Remove.
5273         * dbxread.c (dbx_end_psymtab): Update.
5274         * xcoffread.c (xcoff_end_psymtab): Update.
5275
5276 2020-03-28  Tom Tromey  <tom@tromey.com>
5277
5278         * dwarf2/attribute.h (struct attribute) <form_is_constant>: Update
5279         comment.
5280
5281 2020-03-28  Tom Tromey  <tom@tromey.com>
5282
5283         * dwarf2/read.c (read_attribute_reprocess): Fix formatting.
5284
5285 2020-03-27  Hannes Domani  <ssbssa@yahoo.de>
5286
5287         * windows-nat.c (windows_add_all_dlls): Fix system dll paths.
5288
5289 2020-03-26  John Baldwin  <jhb@FreeBSD.org>
5290
5291         * fbsd-tdep.c (fbsd_print_auxv_entry): Handle AT_FREEBSD_BSDFLAGS.
5292
5293 2020-03-26  Tom Tromey  <tom@tromey.com>
5294
5295         * dwarf2/read.c (handle_data_member_location, dwarf2_add_field)
5296         (mark_common_block_symbol_computed, read_tag_string_type)
5297         (attr_to_dynamic_prop, read_subrange_type): Update.
5298         (dwarf2_get_ref_die_offset, dwarf2_get_attr_constant_value): Move
5299         to be methods on struct attribute.
5300         (skip_one_die, process_imported_unit_die, read_namespace_alias)
5301         (read_call_site_scope, partial_die_info::read)
5302         (partial_die_info::read, lookup_die_type, follow_die_ref):
5303         Update.
5304         * dwarf2/attribute.c (attribute::get_ref_die_offset): New method,
5305         from dwarf2_get_ref_die_offset.
5306         (attribute::constant_value): New method, from
5307         dwarf2_get_attr_constant_value.
5308         * dwarf2/attribute.h (struct attribute) <get_ref_die_offset>:
5309         Declare method.
5310         <constant_value>: New method.
5311
5312 2020-03-26  Tom Tromey  <tom@tromey.com>
5313
5314         * dwarf2/read.c (dwarf_unit_type_name, dwarf_tag_name)
5315         (dwarf_attr_name, dwarf_form_name, dwarf_bool_name)
5316         (dwarf_type_encoding_name): Move to stringify.c.
5317         * Makefile.in (COMMON_SFILES): Add dwarf2/stringify.c.
5318         * dwarf2/stringify.c: New file.
5319         * dwarf2/stringify.h: New file.
5320
5321 2020-03-26  Tom Tromey  <tom@tromey.com>
5322
5323         * dwarf2/die.h (struct die_info) <addr_base, ranges_base>:
5324         Rewrite.
5325
5326 2020-03-26  Tom Tromey  <tom@tromey.com>
5327
5328         * dwarf2/die.h (struct die_info) <addr_base, ranges_base>: New
5329         methods.
5330         * dwarf2/read.c (lookup_addr_base): Move to die.h.
5331         (lookup_ranges_base): Likewise.
5332         (read_cutu_die_from_dwo, read_full_die_1): Update.
5333
5334 2020-03-26  Tom Tromey  <tom@tromey.com>
5335
5336         * dwarf2/read.c (read_import_statement, read_file_scope)
5337         (read_type_unit_scope, inherit_abstract_dies, read_func_scope)
5338         (read_lexical_block_scope, read_call_site_scope)
5339         (dwarf2_get_subprogram_pc_bounds, get_scope_pc_bounds)
5340         (handle_struct_member_die, process_structure_scope)
5341         (update_enumeration_type_from_children)
5342         (process_enumeration_scope, read_array_type, read_common_block)
5343         (read_namespace, read_module, read_subroutine_type): Update.
5344         (sibling_die): Remove.
5345
5346 2020-03-26  Tom Tromey  <tom@tromey.com>
5347
5348         * dwarf2/read.c (lookup_addr_base, lookup_ranges_base)
5349         (build_type_psymtabs_reader, read_structure_type)
5350         (read_enumeration_type, read_full_die_1): Update.
5351         (dwarf2_attr_no_follow): Move to die.h.
5352         * dwarf2/die.h (struct die_info) <attr>: New method.
5353
5354 2020-03-26  Tom Tromey  <tom@tromey.com>
5355
5356         * dwarf2/read.c (struct dwarf2_cu) <base_known>: Remove.
5357         <base_address>: Now an optional.
5358         (dwarf2_find_base_address, dwarf2_rnglists_process)
5359         (dwarf2_ranges_process, fill_in_loclist_baton)
5360         (dwarf2_symbol_mark_computed): Update.
5361
5362 2020-03-26  Tom Tromey  <tom@tromey.com>
5363
5364         * dwarf2/read.c (struct die_info): Move to die.h.
5365         * dwarf2/die.h: New file.
5366
5367 2020-03-26  Tom Tromey  <tom@tromey.com>
5368
5369         * dwarf2/line-header.h (dwarf_decode_line_header): Declare.
5370         * dwarf2/read.c
5371         (dwarf2_statement_list_fits_in_line_number_section_complaint):
5372         Move to line-header.c.
5373         (read_checked_initial_length_and_offset, read_formatted_entries):
5374         Likewise.
5375         (dwarf_decode_line_header): Split into two.
5376         * dwarf2/line-header.c
5377         (dwarf2_statement_list_fits_in_line_number_section_complaint):
5378         Move from read.c.
5379         (read_checked_initial_length_and_offset, read_formatted_entries):
5380         Likewise.
5381         (dwarf_decode_line_header): New function, split from read.c.
5382
5383 2020-03-26  Tom Tromey  <tom@tromey.com>
5384
5385         * dwarf2/read.h (struct dwarf2_per_objfile) <read_line_string>:
5386         Declare method.
5387         * dwarf2/read.c (read_attribute_value): Update.
5388         (dwarf2_per_objfile::read_line_string): Rename from
5389         read_indirect_line_string.
5390         (read_formatted_entries): Update.
5391
5392 2020-03-26  Tom Tromey  <tom@tromey.com>
5393
5394         * dwarf2/macro.c (dwarf_decode_macro_bytes): Use objfile local
5395         variable.
5396
5397 2020-03-26  Tom Tromey  <tom@tromey.com>
5398
5399         * dwarf2/macro.h (dwarf_decode_macros): Make section parameter
5400         const.
5401         * dwarf2/macro.c (skip_form_bytes, skip_unknown_opcode)
5402         (dwarf_decode_macro_bytes, dwarf_decode_macros): Make section
5403         parameter const.
5404
5405 2020-03-26  Tom Tromey  <tom@tromey.com>
5406
5407         * dwarf2/read.c (dwarf_decode_macros): Make "lh" const.
5408         * dwarf2/macro.h (dwarf_decode_macros): Constify "lh" parameter.
5409         * dwarf2/macro.c (macro_start_file): Constify "lh" parameter.
5410         (dwarf_decode_macro_bytes, dwarf_decode_macros): Likewise.
5411
5412 2020-03-26  Tom Tromey  <tom@tromey.com>
5413
5414         * dwarf2/line-header.h (struct line_header) <is_valid_file_index,
5415         file_names_size, file_full_name, file_file_name>: Use const.
5416         <file_name_at, file_names>: Add const overload.
5417         * dwarf2/line-header.c (line_header::file_file_name)
5418         (line_header::file_full_name): Update.
5419
5420 2020-03-26  Tom Tromey  <tom@tromey.com>
5421
5422         * dwarf2/read.c (dwarf2_macro_malformed_definition_complaint)
5423         (macro_start_file, consume_improper_spaces)
5424         (parse_macro_definition, skip_form_bytes, skip_unknown_opcode)
5425         (dwarf_parse_macro_header, dwarf_decode_macro_bytes)
5426         (dwarf_decode_macros): Move to macro.c.
5427         * dwarf2/macro.c: New file.
5428         * dwarf2/macro.h: New file.
5429         * Makefile.in (COMMON_SFILES): Add dwarf2/macro.c.
5430
5431 2020-03-26  Tom Tromey  <tom@tromey.com>
5432
5433         * dwarf2/section.h (struct dwarf2_section_info) <read_string>: New
5434         method.
5435         * dwarf2/section.c: New method.  From
5436         read_indirect_string_at_offset_from.
5437         * dwarf2/read.c (mapped_debug_names::namei_to_name): Update.
5438         (read_indirect_string_at_offset_from): Move to section.c.
5439         (read_indirect_string_at_offset): Rewrite.
5440         (read_indirect_line_string_at_offset): Remove.
5441         (read_indirect_string, read_indirect_line_string)
5442         (dwarf_decode_macro_bytes): Update.
5443
5444 2020-03-26  Tom Tromey  <tom@tromey.com>
5445
5446         * dwarf2/section.h (struct dwarf2_section_info)
5447         <overload_complaint>: Declare.
5448         (dwarf2_section_buffer_overflow_complaint): Don't declare.
5449         * dwarf2/section.c (dwarf2_section_info::overflow_complaint):
5450         Rename from dwarf2_section_buffer_overflow_complaint.
5451         * dwarf2/read.c (skip_one_die, partial_die_info::read)
5452         (skip_form_bytes, dwarf_decode_macro_bytes): Update.
5453
5454 2020-03-26  Tom Tromey  <tom@tromey.com>
5455
5456         * dwarf2/section.h (dwarf2_section_buffer_overflow_complaint):
5457         Declare.
5458         * dwarf2/section.c (dwarf2_section_buffer_overflow_complaint):
5459         Move from read.c.
5460         * dwarf2/read.c (dwarf2_section_buffer_overflow_complaint): Move
5461         to section.c.
5462
5463 2020-03-26  Tom Tromey  <tom@tromey.com>
5464
5465         * dwarf2/read.c (dwarf_decode_macros): Split into two overloads.
5466
5467 2020-03-26  Tom Tromey  <tom@tromey.com>
5468
5469         * dwarf2/read.c (macro_start_file): Change "cu" parameter to
5470         "builder".
5471         (dwarf_decode_macro_bytes): Likewise.  Add dwarf2_per_objfile
5472         parameter.
5473         (dwarf_decode_macros): Update.
5474
5475 2020-03-26  Tom Tromey  <tom@tromey.com>
5476
5477         * dwarf2/read.c (read_attribute_value): Update.
5478         (read_indirect_string_from_dwz): Move to dwz.c; change into
5479         method.
5480         (dwarf_decode_macro_bytes): Update.
5481         * dwarf2/dwz.h (struct dwz_file) <read_string>: Declare method.
5482         * dwarf2/dwz.c: New file.
5483         * Makefile.in (COMMON_SFILES): Add dwz.c.
5484
5485 2020-03-26  Tom Tromey  <tom@tromey.com>
5486
5487         * dwarf2/read.h (struct dwz_file): Move to dwz.h.
5488         * dwarf2/read.c: Add include.
5489         * dwarf2/index-write.c: Add include.
5490         * dwarf2/index-cache.c: Add include.
5491         * dwarf2/dwz.h: New file.
5492
5493 2020-03-25  Tom Tromey  <tom@tromey.com>
5494
5495         * compile/compile-object-load.c (get_out_value_type): Mention
5496         correct symbol name in error message.
5497
5498 2020-03-25  Hannes Domani  <ssbssa@yahoo.de>
5499
5500         * windows-nat.c (windows_add_all_dlls): Fix system dll paths.
5501
5502 2020-03-25  Tom de Vries  <tdevries@suse.de>
5503
5504         * symtab.h (is_main_symtab_of_compunit_symtab): New function.
5505         * symmisc.c (dump_symtab_1): Print user and includes fields.
5506         (maintenance_info_symtabs): Same.
5507
5508 2020-03-25  Andrew Burgess  <andrew.burgess@embecosm.com>
5509
5510         PR gdb/25534
5511         * riscv-tdep.c (riscv_arg_info::c_offset): Update comment.
5512         (riscv_regcache_cooked_write): New function.
5513         (riscv_push_dummy_call): Use new function.
5514         (riscv_return_value): Likewise.
5515
5516 2020-03-24  Simon Marchi  <simon.marchi@polymtl.ca>
5517
5518         * fbsd-nat.c (fbsd_nat_target::follow_fork): Change bool to int.
5519         * fbsd-nat.h (class fbsd_nat_target) <follow_fork>: Likewise.
5520         * inf-ptrace.c (inf_ptrace_target::follow_fork): Likewise.
5521         * inf-ptrace.h (struct inf_ptrace_target) <follow_fork>: Likewise.
5522         * infrun.c (follow_fork): Likewise.
5523         (follow_fork_inferior): Likewise.
5524         * linux-nat.c (linux_nat_target::follow_fork): Likewise.
5525         * linux-nat.h (class linux_nat_target): Likewise.
5526         * remote.c (class remote_target) <follow_fork>: Likewise.
5527         (remote_target::follow_fork): Likewise.
5528         * target-delegates.c: Re-generate.
5529         * target.c (default_follow_fork): Likewise.
5530         (target_follow_fork): Likewise.
5531         * target.h (struct target_ops) <follow_fork>: Likewise.
5532         (target_follow_fork): Likewise.
5533
5534 2020-03-24  Tom de Vries  <tdevries@suse.de>
5535
5536         * psymtab.c (maintenance_info_psymtabs): Print user field.
5537
5538 2020-03-20  Tom Tromey  <tromey@adacore.com>
5539
5540         * dwarf2/loc.h (dwarf2_evaluate_property): Make "addr_stack"
5541         const.
5542         * dwarf2/loc.c (dwarf2_evaluate_property): Make "addr_stack"
5543         const.
5544
5545 2020-03-20  Simon Marchi  <simon.marchi@efficios.com>
5546
5547         * ptrace.m4: Don't check for ptrace declaration.
5548         * config.in: Re-generate.
5549         * configure: Re-generate.
5550         * nat/gdb_ptrace.h: Don't declare ptrace if HAVE_DECL_PTRACE is
5551         not defined.
5552
5553 2020-03-20  Kamil Rytarowski  <n54@gmx.com>
5554
5555         * amd64-bsd-nat.c (gdb_ptrace): Change return type from `int' to
5556         `PTRACE_TYPE_RET'.
5557         * i386-bsd-nat.c (gdb_ptrace): Likewise.
5558         * sparc-nat.c (gdb_ptrace): Likewise.
5559         * x86-bsd-nat.c (gdb_ptrace): Likewise.
5560
5561 2020-03-20  Tom Tromey  <tromey@adacore.com>
5562
5563         * c-exp.y (lex_one_token): Fix assert.
5564
5565 2020-03-20  Tom Tromey  <tromey@adacore.com>
5566
5567         * ada-tasks.c (read_atcb): Use smaller length in strncpy call.
5568         * linux-tdep.c (linux_fill_prpsinfo): Use smaller length in
5569         strncpy call.
5570
5571 2020-03-20  Tom Tromey  <tromey@adacore.com>
5572
5573         * symmisc.c (maintenance_print_one_line_table): Use ui_out.
5574
5575 2020-03-20  Tom Tromey  <tromey@adacore.com>
5576
5577         * ada-valprint.c (print_variant_part): Remove parameters; switch
5578         to value-based API.
5579         (print_field_values): Likewise.
5580         (ada_val_print_struct_union): Likewise.
5581         (ada_value_print_1): Update.
5582
5583 2020-03-20  Kamil Rytarowski  <n54@gmx.com>
5584
5585         * ppc-nbsd-nat.c (ppc_nbsd_nat_target): Inherit from
5586         nbsd_nat_target instead of inf_ptrace_target.
5587         * ppc-nbsd-nat.c: Include "nbsd-nat.h", as we are now using
5588         nbsd_nat_target.
5589
5590 2020-03-20  Kamil Rytarowski  <n54@gmx.com>
5591
5592         * hppa-nbsd-nat.c (fetch_registers): New variable lwp and pass
5593         it to the ptrace call.
5594         * (store_registers): Likewise.
5595
5596 2020-03-20  Kamil Rytarowski  <n54@gmx.com>
5597
5598         * ppc-nbsd-nat.c (fetch_registers): New variable lwp and pass
5599         it to the ptrace call.
5600         * (store_registers): Likewise.
5601
5602 2020-03-19  Luis Machado  <luis.machado@linaro.org>
5603
5604         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): If vg is not
5605         valid, fetch vg value from ptrace.
5606
5607 2020-03-19  Kamil Rytarowski  <n54@gmx.com>
5608         * inf-ptrace.h: Disable get_ptrace_pid on NetBSD.
5609         * inf-ptrace.c: Likewise.
5610         * (gdb_ptrace): Add.
5611         * (inf_ptrace_target::resume): Update.
5612         * (inf_ptrace_target::xfer_partial): Likewise.
5613         * (inf_ptrace_peek_poke): Change argument `pid' to `ptid'.
5614         * (inf_ptrace_peek_poke): Update.
5615
5616 2020-03-19  Kamil Rytarowski  <n54@gmx.com>
5617
5618         * x86-bsd-nat.c (gdb_ptrace): New.
5619         * (x86bsd_dr_set): Add new argument `ptid'.
5620         * (x86bsd_dr_get, x86bsd_dr_set, x86bsd_dr_set_control,
5621         x86bsd_dr_set_addr): Update.
5622
5623 2020-03-19  Andrew Burgess  <andrew.burgess@embecosm.com>
5624
5625         * remote.c (remote_target::process_stop_reply): Handle events for
5626         all threads differently.
5627
5628 2020-03-19  Andrew Burgess  <andrew.burgess@embecosm.com>
5629
5630         * completer.c (completion_tracker::remove_completion): Define new
5631         function.
5632         * completer.h (completion_tracker::remove_completion): Declare new
5633         function.
5634         * symtab.c (completion_list_add_symbol): Remove aliasing msymbols
5635         when adding a C++ function symbol.
5636
5637 2020-03-19  Andrew Burgess  <andrew.burgess@embecosm.com>
5638
5639         * completer.c (completion_tracker::completion_hash_entry): Define
5640         new class.
5641         (advance_to_filename_complete_word_point): Call
5642         recompute_lowest_common_denominator.
5643         (completion_tracker::completion_tracker): Call discard_completions
5644         to setup the hash table.
5645         (completion_tracker::discard_completions): Allow for being called
5646         from the constructor, pass new equal function, and element deleter
5647         when constructing the hash table.  Initialise new class member
5648         variables.
5649         (completion_tracker::maybe_add_completion): Remove use of
5650         m_entries_vec, and store more information into m_entries_hash.
5651         (completion_tracker::recompute_lcd_visitor): New function, most
5652         content taken from...
5653         (completion_tracker::recompute_lowest_common_denominator):
5654         ...here, this now just visits each item in the hash calling the
5655         above visitor.
5656         (completion_tracker::build_completion_result): Remove use of
5657         m_entries_vec, call recompute_lowest_common_denominator.
5658         * completer.h (completion_tracker::have_completions): Remove use
5659         of m_entries_vec.
5660         (completion_tracker::completion_hash_entry): Declare new class.
5661         (completion_tracker::recompute_lowest_common_denominator): Change
5662         function signature.
5663         (completion_tracker::recompute_lcd_visitor): Declare new function.
5664         (completion_tracker::m_entries_vec): Delete.
5665         (completion_tracker::m_entries_hash): Initialize to NULL.
5666         (completion_tracker::m_lowest_common_denominator_valid): New
5667         member variable.
5668         (completion_tracker::m_lowest_common_denominator_max_length): New
5669         member variable.
5670
5671 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
5672
5673         * regformats/regdef.h: Put reg in gdb namespace.
5674
5675 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
5676
5677         * i386-bsd-nat.c (gdb_ptrace): New.
5678         * (i386bsd_fetch_inferior_registers,
5679         i386bsd_store_inferior_registers) Switch from pid_t to ptid_t.
5680         * (i386bsd_fetch_inferior_registers,
5681         i386bsd_store_inferior_registers) Use gdb_ptrace.
5682
5683 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
5684
5685         * amd64-bsd-nat.c (gdb_ptrace): New.
5686         * (amd64bsd_fetch_inferior_registers,
5687         amd64bsd_store_inferior_registers) Switch from pid_t to ptid_t.
5688         * (amd64bsd_fetch_inferior_registers,
5689         amd64bsd_store_inferior_registers) Use gdb_ptrace.
5690
5691 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
5692
5693         * user-regs.c (user_reg::read): Rename to...
5694         (user_reg::xread): ...this.
5695         * (append_user_reg): Rename argument `read' to `xread'.
5696         * (user_reg_add_builtin): Likewise.
5697         * (user_reg_add): Likewise.
5698         * (value_of_user_reg): Likewise.
5699
5700 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
5701
5702         * sparc-nat.c (gdb_ptrace): New.
5703         * sparc-nat.c (sparc_fetch_inferior_registers)
5704         (sparc_store_inferior_registers) Remove obsolete comment.
5705         * sparc-nat.c (sparc_fetch_inferior_registers)
5706         (sparc_store_inferior_registers) Switch from pid_t to ptid_t.
5707         * sparc-nat.c (sparc_fetch_inferior_registers)
5708         (sparc_store_inferior_registers) Use gdb_ptrace.
5709
5710 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
5711
5712         * sh-nbsd-nat.c (fetch_registers): New variable lwp and pass
5713         it to the ptrace call.
5714         * sh-nbsd-nat.c (store_registers): Likewise.
5715
5716 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
5717
5718         * sh-nbsd-nat.c (sh_nbsd_nat_target): Inherit from
5719         nbsd_nat_target instead of inf_ptrace_target.
5720         * sh-nbsd-nat.c: Include "nbsd-nat.h", as we are now using
5721         nbsd_nat_target.
5722
5723 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
5724
5725         * amd64-bsd-nat.c: Include amd64-bsd-nat.h".
5726
5727 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
5728
5729         * nbsd-nat.c: Include <sys/types.h>, <sys/ptrace.h> and
5730         <sys/sysctl.h>.
5731         * nbsd-nat.c (nbsd_nat_target::pid_to_exec_file): Rewrite.
5732
5733 2020-03-17  Tom de Vries  <tdevries@suse.de>
5734
5735         PR gdb/23710
5736         * dwarf2/read.h (struct dwarf2_per_cu_data): Add unit_type and lang
5737         fields.
5738         * dwarf2/read.c (process_psymtab_comp_unit): Initialize unit_type and lang
5739         fields.
5740         (process_imported_unit_die): Skip import of c++ CUs.
5741
5742 2020-03-16  Tom Tromey  <tom@tromey.com>
5743
5744         * p-valprint.c (pascal_object_print_value): Initialize
5745         base_value.
5746
5747 2020-03-16  Anton Kolesov  <anton.kolesov@synopsys.com>
5748             Shahab Vahedi  <shahab@synopsys.com>
5749
5750         * Makefile.in: Add arch/arc.o
5751         * configure.tgt: Likewise.
5752         * arc-tdep.c (arc_tdesc_init): Use arc_read_description.
5753         (_initialize_arc_tdep): Don't initialize old target descriptions.
5754         (arc_read_description): New function to cache target descriptions.
5755         * arc-tdep.h (arc_read_description): Add proto type.
5756         * arch/arc.c: New file.
5757         * arch/arc.h: Likewise.
5758         * features/Makefile: Replace old target descriptions with new.
5759         * features/arc-arcompact.c: Remove.
5760         * features/arc-arcompact.xml: Likewise.
5761         * features/arc-v2.c: Likewise
5762         * features/arc-v2.xml: Likewise
5763         * features/arc/aux-arcompact.xml: New file.
5764         * features/arc/aux-v2.xml: Likewise.
5765         * features/arc/core-arcompact.xml: Likewise.
5766         * features/arc/core-v2.xml: Likewise.
5767         * features/arc/aux-arcompact.c: Generate.
5768         * features/arc/aux-v2.c: Likewise.
5769         * features/arc/core-arcompact.c: Likewise.
5770         * features/arc/core-v2.c: Likewise.
5771         * target-descriptions (maint_print_c_tdesc_cmd): Support ARC features.
5772
5773 2020-03-16  Tom Tromey  <tromey@adacore.com>
5774
5775         PR gdb/25663:
5776         * dwarf2/read.c (dwarf2_name): Strip leading namespaces after
5777         putting value into bcache.
5778
5779 2020-03-16  Simon Marchi  <simon.marchi@efficios.com>
5780
5781         PR gdb/21500
5782         * amd64-windows-tdep.c (amd64_windows_init_abi): Rename
5783         to...
5784         (amd64_windows_init_abi_common): ... this.  Don't set size of
5785         long type.
5786         (amd64_windows_init_abi): New function.
5787         (amd64_cygwin_init_abi): New function.
5788         (_initialize_amd64_windows_tdep): Use amd64_cygwin_init_abi for
5789         the Cygwin OS ABI.
5790         * i386-windows-tdep.c (_initialize_i386_windows_tdep): Clarify
5791         comment.
5792
5793 2020-03-16  Simon Marchi  <simon.marchi@efficios.com>
5794
5795         * windows-tdep.h (is_linked_with_cygwin_dll): New declaration.
5796         * windows-tdep.c (CYGWIN_DLL_NAME): New.
5797         (pe_import_directory_entry): New struct type.
5798         (is_linked_with_cygwin_dll): New function.
5799         * amd64-windows-tdep.c (amd64_windows_osabi_sniffer): Select
5800         GDB_OSABI_CYGWIN if the BFD is linked with the Cygwin DLL.
5801         * i386-windows-tdep.c (i386_windows_osabi_sniffer): Likewise.
5802
5803 2020-03-16  Simon Marchi  <simon.marchi@efficios.com>
5804
5805         * i386-windows-tdep.c: Mass-rename "cygwin" to "windows", except
5806         i386_cygwin_core_osabi_sniffer.
5807
5808 2020-03-16  Simon Marchi  <simon.marchi@efficios.com>
5809
5810         * i386-cygwin-tdep.c: Rename to...
5811         * i386-windows-tdep.c: ... this.
5812         * Makefile.in (ALL_TARGET_OBS): Rename i386-cygwin-tdep.c to
5813         i386-windows-tdep.c.
5814         * configure.tgt: Likewise.
5815
5816 2020-03-16  Simon Marchi  <simon.marchi@efficios.com>
5817
5818         * osabi.h (enum gdb_osabi): Add GDB_OSABI_WINDOWS.
5819         * osabi.c (gdb_osabi_names): Add "Windows".
5820         * i386-cygwin-tdep.c (i386_cygwin_osabi_sniffer): Return
5821         GDB_OSABI_WINDOWS when the binary's target is "pei-i386".
5822         (i386_cygwin_core_osabi_sniffer): New function, extracted from
5823         i386_cygwin_osabi_sniffer.
5824         (_initialize_i386_cygwin_tdep): Register OS ABI
5825         GDB_OSABI_WINDOWS for i386.
5826         * amd64-windows-tdep.c (amd64_windows_osabi_sniffer): Return
5827         GDB_OSABI_WINDOWS when the binary's target is "pei-x86-64".
5828         (_initialize_amd64_windows_tdep): Register OS ABI GDB_OSABI_WINDOWS
5829         for x86-64.
5830         * configure.tgt: Use GDB_OSABI_WINDOWS as the default OS ABI
5831         when the target matches '*-*-mingw*'.
5832
5833 2020-03-16  Simon Marchi  <simon.marchi@efficios.com>
5834
5835         * defs.h (enum gdb_osabi): Move to...
5836         * osabi.h (enum gdb_osabi): ... here.
5837         * gdbarch.sh: Include osabi.h in gdbarch.h.
5838         * gdbarch.h: Re-generate.
5839
5840 2020-03-16  Simon Marchi  <simon.marchi@efficios.com>
5841
5842         * amd64-windows-tdep.c (amd64_windows_osabi_sniffer): New
5843         function.
5844         (_initialize_amd64_windows_tdep): Register osabi sniffer.
5845
5846 2020-03-14  Tom Tromey  <tom@tromey.com>
5847
5848         * c-typeprint.c (cp_type_print_method_args): Print "__restrict__"
5849         for C++.
5850         (c_type_print_modifier): Likewise.  Add "language" parameter.
5851         (c_type_print_varspec_prefix, c_type_print_base_struct_union)
5852         (c_type_print_base_1): Update.
5853         * type-stack.h (enum type_pieces) <tp_atomic, tp_restrict>: New
5854         constants.
5855         * type-stack.c (type_stack::insert): Handle tp_atomic and
5856         tp_restrict.
5857         (type_stack::follow_type_instance_flags): Likewise.
5858         (type_stack::follow_types): Likewise.  Merge type-following code.
5859         * c-exp.y (RESTRICT, ATOMIC): New tokens.
5860         (space_identifier, cv_with_space_id)
5861         (const_or_volatile_or_space_identifier_noopt)
5862         (const_or_volatile_or_space_identifier): Remove.
5863         (single_qualifier, qualifier_seq_noopt, qualifier_seq): New
5864         rules.
5865         (ptr_operator, typebase): Update.
5866         (enum token_flag) <FLAG_C>: New constant.
5867         (ident_tokens): Add "restrict", "__restrict__", "__restrict", and
5868         "_Atomic".
5869         (lex_one_token): Handle FLAG_C.
5870
5871 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
5872
5873         * m68k-bsd-nat.c (fetch_registers): New variable lwp and pass
5874         it to the ptrace call.
5875         * m68k-bsd-nat.c (store_registers): Likewise.
5876
5877 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
5878
5879         * m68k-bsd-nat.c (m68kbsd_supply_gregset): Change type of regs to
5880         gdb_byte *.
5881         * m68k-bsd-nat.c (m68kbsd_supply_fpregset): Likewise.
5882         * m68k-bsd-nat.c (m68kbsd_collect_gregset): Likewise.
5883         * m68k-bsd-nat.c (m68kbsd_supply_pcb): Cast &tmp to gdb_byte *.
5884
5885 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
5886
5887         * m68k-bsd-nat.c (m68k_bsd_nat_target): Inherit from
5888         nbsd_nat_target instead of inf_ptrace_target.
5889         * m68k-bsd-nat.c: Include "nbsd-nat.h", as we are now using
5890         nbsd_nat_target.
5891
5892 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
5893
5894         * m68k-bsd-nat.c: Define _KERNTYPES to get the declaration of
5895         register_t.
5896
5897 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
5898
5899         * alpha-bsd-nat.c (fetch_registers): New variable lwp and pass
5900         it to the ptrace call.
5901         * alpha-bsd-nat.c (store_registers): Likewise.
5902
5903 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
5904
5905         * alpha-bsd-nat.c: Remove <sys/procfs.h> and "gregset.h" from
5906         includes.
5907         * alpha-bsd-nat.c (gregset_t, fpregset_t): Remove.
5908         * alpha-bsd-nat.c (supply_gregset, fill_gregset, supply_fpregset,
5909         fill_fpregset): Likewise.
5910
5911 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
5912
5913         * alpha-bsd-nat.c (alpha_netbsd_nat_target): Inherit from
5914         nbsd_nat_target instead of inf_ptrace_target.
5915         * alpha-bsd-nat.c: Include "nbsd-nat.h", as we are now using
5916         nbsd_nat_target.
5917
5918 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
5919
5920         * alpha-bsd-nat.c: Define _KERNTYPES to get the declaration of
5921         register_t.
5922
5923 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
5924
5925         * arm-nbsd-nat.c (fetch_register): New variable lwp and pass
5926         it to the ptrace call.
5927         * arm-nbsd-nat.c (fetch_fp_register): Likewise.
5928         * arm-nbsd-nat.c (fetch_fp_regs): Likewise.
5929         * arm-nbsd-nat.c (store_register): Likewise.
5930         * arm-nbsd-nat.c (store_regs): Likewise.
5931         * arm-nbsd-nat.c (store_fp_register): Likewise.
5932         * arm-nbsd-nat.c (store_fp_regs): Likewise.
5933
5934 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
5935
5936         * arm-nbsd-nat.c (arm_netbsd_nat_target): Inherit from
5937         nbsd_nat_target instead of inf_ptrace_target.
5938         * arm-nbsd-nat.c: Include "nbsd-nat.h", as we are now using
5939         nbsd_nat_target.
5940
5941 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
5942
5943         * x86-bsd-nat.c (x86bsd_dr_get): New variable lwp and pass
5944         it to the ptrace call.
5945         * x86-bsd-nat.c (x86bsd_dr_set): Likewise.
5946
5947 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
5948
5949         * vax-bsd-nat.c (vaxbsd_supply_gregset): New variable lwp and pass
5950         it to the ptrace call.
5951         * vax-bsd-nat.c (vaxbsd_collect_gregset): Likewise.
5952
5953 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
5954
5955         * vax-bsd-nat.c (vaxbsd_supply_gregset): Cast gregs to const
5956         gdb_byte *.
5957         * vax-bsd-nat.c (vaxbsd_collect_gregset): Cast gregs to void *.
5958
5959 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
5960
5961         * vax-bsd-nat.c (vax_bsd_nat_target): Inherit from nbsd_nat_target
5962         instead of inf_ptrace_target.
5963         * vax-bsd-nat.c: Include "nbsd-nat.h", as we are now using
5964         nbsd_nat_target.
5965
5966 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
5967
5968         * mips-nbsd-nat.c: Define _KERNTYPES to get the declaration of
5969         register_t.
5970
5971 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
5972
5973         * ppc-nbsd-nat.c: Define _KERNTYPES to get the declaration of
5974         register_t.
5975
5976 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
5977
5978         * vax-bsd-nat.c: Define _KERNTYPES to get the declaration of
5979         register_t.
5980
5981 2020-03-13  Tom Tromey  <tom@tromey.com>
5982
5983         * value.h (val_print): Don't declare.
5984         * valprint.h (val_print_array_elements)
5985         (val_print_scalar_formatted, generic_val_print): Don't declare.
5986         * valprint.c (generic_val_print_array): Take a struct value.
5987         (generic_val_print_ptr, generic_val_print_memberptr)
5988         (generic_val_print_bool, generic_val_print_int)
5989         (generic_val_print_char, generic_val_print_complex)
5990         (generic_val_print): Remove.
5991         (generic_value_print): Update.
5992         (do_val_print): Remove unused parameters.  Don't call
5993         la_val_print.
5994         (val_print): Remove.
5995         (common_val_print): Update.  Don't call value_check_printable.
5996         (val_print_scalar_formatted, val_print_array_elements): Remove.
5997         * rust-lang.c (rust_val_print): Remove.
5998         (rust_language_defn): Update.
5999         * p-valprint.c (pascal_val_print): Remove.
6000         (pascal_value_print_inner): Update.
6001         (pascal_object_print_val_fields, pascal_object_print_val):
6002         Remove.
6003         (pascal_object_print_static_field): Update.
6004         * p-lang.h (pascal_val_print): Don't declare.
6005         * p-lang.c (pascal_language_defn): Update.
6006         * opencl-lang.c (opencl_language_defn): Update.
6007         * objc-lang.c (objc_language_defn): Update.
6008         * m2-valprint.c (m2_print_unbounded_array, m2_val_print): Remove.
6009         * m2-lang.h (m2_val_print): Don't declare.
6010         * m2-lang.c (m2_language_defn): Update.
6011         * language.h (struct language_defn) <la_val_print>: Remove.
6012         * language.c (unk_lang_value_print_inner): Rename.  Change
6013         argument types.
6014         (unknown_language_defn, auto_language_defn): Update.
6015         * go-valprint.c (go_val_print): Remove.
6016         * go-lang.h (go_val_print): Don't declare.
6017         * go-lang.c (go_language_defn): Update.
6018         * f-valprint.c (f_val_print): Remove.
6019         * f-lang.h (f_value_print): Don't declare.
6020         * f-lang.c (f_language_defn): Update.
6021         * d-valprint.c (d_val_print): Remove.
6022         * d-lang.h (d_value_print): Don't declare.
6023         * d-lang.c (d_language_defn): Update.
6024         * cp-valprint.c (cp_print_value_fields)
6025         (cp_print_value_fields_rtti, cp_print_value): Remove.
6026         (cp_print_static_field): Update.
6027         * c-valprint.c (c_val_print_array, c_val_print_ptr)
6028         (c_val_print_struct, c_val_print_union, c_val_print_int)
6029         (c_val_print_memberptr, c_val_print): Remove.
6030         * c-lang.h (c_val_print_array, cp_print_value_fields)
6031         (cp_print_value_fields_rtti): Don't declare.
6032         * c-lang.c (c_language_defn, cplus_language_defn)
6033         (asm_language_defn, minimal_language_defn): Update.
6034         * ada-valprint.c (ada_val_print_ptr, ada_val_print_num): Remove.
6035         (ada_val_print_enum): Take a struct value.
6036         (ada_val_print_flt, ada_val_print_array, ada_val_print_1)
6037         (ada_val_print): Remove.
6038         (ada_value_print_1): Update.
6039         (printable_val_type): Remove.
6040         * ada-lang.h (ada_val_print): Don't declare.
6041         * ada-lang.c (ada_language_defn): Update.
6042
6043 2020-03-13  Tom Tromey  <tom@tromey.com>
6044
6045         * valprint.c (do_val_print): Update.
6046         * python/python-internal.h (gdbpy_apply_val_pretty_printer): Take
6047         a struct value.
6048         (value_to_value_object_no_release): Declare.
6049         * python/py-value.c (value_to_value_object_no_release): New
6050         function.
6051         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Take a
6052         struct value.
6053         * guile/scm-value.c (vlscm_scm_from_value_no_release): New
6054         function.
6055         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer): Take
6056         a struct value.
6057         * guile/guile-internal.h (vlscm_scm_from_value_no_release):
6058         Declare.
6059         (gdbscm_apply_val_pretty_printer): Take a struct value.
6060         * extension.h (apply_ext_lang_val_pretty_printer): Take a struct
6061         value.
6062         * extension.c (apply_ext_lang_val_pretty_printer): Take a struct
6063         value.
6064         * extension-priv.h (struct extension_language_ops)
6065         <apply_val_pretty_printer>: Take a struct value.
6066         * cp-valprint.c (cp_print_value): Create a struct value.
6067         (cp_print_value): Update.
6068
6069 2020-03-13  Tom Tromey  <tom@tromey.com>
6070
6071         * ada-valprint.c (print_field_values): Call common_val_print.
6072
6073 2020-03-13  Tom Tromey  <tom@tromey.com>
6074
6075         * ada-valprint.c (val_print_packed_array_elements): Remove
6076         bitoffset and val parameters.  Call common_val_print.
6077         (ada_val_print_string): Remove offset, address, and original_value
6078         parameters.
6079         (ada_val_print_array): Update.
6080         (ada_value_print_array): New function.
6081         (ada_value_print_1): Call it.
6082
6083 2020-03-13  Tom Tromey  <tom@tromey.com>
6084
6085         * ada-valprint.c (ada_value_print): Use common_val_print.
6086
6087 2020-03-13  Tom Tromey  <tom@tromey.com>
6088
6089         * ada-valprint.c (ada_val_print_ref): Use common_val_print.
6090
6091 2020-03-13  Tom Tromey  <tom@tromey.com>
6092
6093         * ada-valprint.c (ada_value_print_num): New function.
6094         (ada_value_print_1): Use it.
6095
6096 2020-03-13  Tom Tromey  <tom@tromey.com>
6097
6098         * ada-valprint.c (ada_value_print_1) <TYPE_CODE_FLT>: Rewrite.
6099
6100 2020-03-13  Tom Tromey  <tom@tromey.com>
6101
6102         * ada-valprint.c (ada_value_print_ptr): New function.
6103         (ada_value_print_1): Use it.
6104
6105 2020-03-13  Tom Tromey  <tom@tromey.com>
6106
6107         * ada-valprint.c (ada_val_print_gnat_array): Take a struct value;
6108         call common_val_print.
6109         (ada_val_print_1): Update.
6110         (ada_value_print_1): New function.
6111         (ada_value_print_inner): Rewrite.
6112
6113 2020-03-13  Tom Tromey  <tom@tromey.com>
6114
6115         * cp-valprint.c (cp_print_value_fields): Update.
6116         (cp_print_value): New function.
6117
6118 2020-03-13  Tom Tromey  <tom@tromey.com>
6119
6120         * m2-valprint.c (m2_value_print_inner): Use
6121         cp_print_value_fields.
6122         * cp-valprint.c (cp_print_value_fields): New function.
6123         * c-valprint.c (c_value_print_struct): New function.
6124         (c_value_print_inner): Use c_value_print_struct.
6125         * c-lang.h (cp_print_value_fields): Declare.
6126
6127 2020-03-13  Tom Tromey  <tom@tromey.com>
6128
6129         * c-valprint.c (c_value_print_array): New function.
6130         (c_value_print_inner): Use it.
6131
6132 2020-03-13  Tom Tromey  <tom@tromey.com>
6133
6134         * c-valprint.c (c_value_print_memberptr): New function.
6135         (c_value_print_inner): Use it.
6136
6137 2020-03-13  Tom Tromey  <tom@tromey.com>
6138
6139         * c-valprint.c (c_value_print_int): New function.
6140         (c_value_print_inner): Use it.
6141
6142 2020-03-13  Tom Tromey  <tom@tromey.com>
6143
6144         * c-valprint.c (c_value_print_ptr): New function.
6145         (c_value_print_inner): Use it.
6146
6147 2020-03-13  Tom Tromey  <tom@tromey.com>
6148
6149         * c-valprint.c (c_value_print_inner): Rewrite.
6150
6151 2020-03-13  Tom Tromey  <tom@tromey.com>
6152
6153         * valprint.c (generic_value_print_complex): New function.
6154         (generic_value_print): Use it.
6155
6156 2020-03-13  Tom Tromey  <tom@tromey.com>
6157
6158         * valprint.c (generic_val_print_float): Don't call
6159         val_print_scalar_formatted.
6160         (generic_val_print, generic_value_print): Update.
6161
6162 2020-03-13  Tom Tromey  <tom@tromey.com>
6163
6164         * valprint.c (generic_value_print_char): New function
6165         (generic_value_print): Use it.
6166
6167 2020-03-13  Tom Tromey  <tom@tromey.com>
6168
6169         * valprint.c (generic_value_print_int): New function.
6170         (generic_value_print): Use it.
6171
6172 2020-03-13  Tom Tromey  <tom@tromey.com>
6173
6174         * valprint.c (generic_value_print_bool): New function.
6175         (generic_value_print): Use it.
6176
6177 2020-03-13  Tom Tromey  <tom@tromey.com>
6178
6179         * valprint.c (generic_val_print_func): Simplify.
6180         (generic_val_print, generic_value_print): Update.
6181
6182 2020-03-13  Tom Tromey  <tom@tromey.com>
6183
6184         * valprint.c (generic_val_print_flags): Remove.
6185         (generic_val_print, generic_value_print): Update.
6186         (val_print_type_code_flags): Add original_value parameter.
6187
6188 2020-03-13  Tom Tromey  <tom@tromey.com>
6189
6190         * valprint.c (generic_val_print): Update.
6191         (generic_value_print): Update.
6192         * valprint.c (generic_val_print_enum): Don't call
6193         val_print_scalar_formatted.
6194
6195 2020-03-13  Tom Tromey  <tom@tromey.com>
6196
6197         * valprint.c (generic_value_print): Call generic_value_print_ptr.
6198         * valprint.c (generic_value_print_ptr): New function.
6199
6200 2020-03-13  Tom Tromey  <tom@tromey.com>
6201
6202         * valprint.c (generic_value_print): Rewrite.
6203
6204 2020-03-13  Tom Tromey  <tom@tromey.com>
6205
6206         * p-valprint.c (pascal_object_print_value_fields)
6207         (pascal_object_print_value): New functions.
6208
6209 2020-03-13  Tom Tromey  <tom@tromey.com>
6210
6211         * p-valprint.c (pascal_value_print_inner): Rewrite.
6212
6213 2020-03-13  Tom Tromey  <tom@tromey.com>
6214
6215         * f-valprint.c (f_value_print_innner): Rewrite.
6216
6217 2020-03-13  Tom Tromey  <tom@tromey.com>
6218
6219         * m2-valprint.c (m2_print_unbounded_array): New overload.
6220         (m2_print_unbounded_array): Update.
6221         (m2_print_array_contents): Take a struct value.
6222         (m2_value_print_inner): Rewrite.
6223
6224 2020-03-13  Tom Tromey  <tom@tromey.com>
6225
6226         * d-valprint.c (dynamic_array_type): Call d_value_print_inner.
6227         (d_value_print_inner): New function.
6228         * d-lang.h (d_value_print_inner): Declare.
6229         * d-lang.c (d_language_defn): Use d_value_print_inner.
6230
6231 2020-03-13  Tom Tromey  <tom@tromey.com>
6232
6233         * go-valprint.c (go_value_print_inner): New function.
6234         * go-lang.h (go_value_print_inner): Declare.
6235         * go-lang.c (go_language_defn): Use go_value_print_inner.
6236
6237 2020-03-13  Tom Tromey  <tom@tromey.com>
6238
6239         * rust-lang.c (val_print_struct, rust_print_enum): Use the value
6240         API.
6241         (rust_val_print): Rewrite.
6242         (rust_value_print_inner): New function, from rust_val_print.
6243         (rust_language_defn): Use rust_value_print_inner.
6244
6245 2020-03-13  Tom Tromey  <tom@tromey.com>
6246
6247         * ada-valprint.c (ada_value_print_inner): New function.
6248         * ada-lang.h (ada_value_print_inner): Declare.
6249         * ada-lang.c (ada_language_defn): Use ada_value_print_inner.
6250
6251 2020-03-13  Tom Tromey  <tom@tromey.com>
6252
6253         * f-valprint.c (f_value_print_innner): New function.
6254         * f-lang.h (f_value_print_innner): Declare.
6255         * f-lang.c (f_language_defn): Use f_value_print_innner.
6256
6257 2020-03-13  Tom Tromey  <tom@tromey.com>
6258
6259         * p-valprint.c (pascal_value_print_inner): New function.
6260         * p-lang.h (pascal_value_print_inner): Declare.
6261         * p-lang.c (pascal_language_defn): Use pascal_value_print_inner.
6262
6263 2020-03-13  Tom Tromey  <tom@tromey.com>
6264
6265         * m2-valprint.c (m2_value_print_inner): New function.
6266         * m2-lang.h (m2_value_print_inner): Declare.
6267         * m2-lang.c (m2_language_defn): Use m2_value_print_inner.
6268
6269 2020-03-13  Tom Tromey  <tom@tromey.com>
6270
6271         * opencl-lang.c (opencl_language_defn): Use c_value_print_inner.
6272         * objc-lang.c (objc_language_defn): Use c_value_print_inner.
6273         * c-valprint.c (c_value_print_inner): New function.
6274         * c-lang.h (c_value_print_inner): Declare.
6275         * c-lang.c (c_language_defn, cplus_language_defn)
6276         (asm_language_defn, minimal_language_defn): Use
6277         c_value_print_inner.
6278
6279 2020-03-13  Tom Tromey  <tom@tromey.com>
6280
6281         * p-valprint.c (pascal_object_print_value_fields): Now static.
6282         * p-lang.h (pascal_object_print_value_fields): Don't declare.
6283
6284 2020-03-13  Tom Tromey  <tom@tromey.com>
6285
6286         * c-valprint.c (c_val_print_array): Simplify.
6287
6288 2020-03-13  Tom Tromey  <tom@tromey.com>
6289
6290         * valprint.c (value_print_array_elements): New function.
6291         * valprint.h (value_print_array_elements): Declare.
6292
6293 2020-03-13  Tom Tromey  <tom@tromey.com>
6294
6295         * printcmd.c (print_formatted): Use value_print_scalar_formatted.
6296         * mips-tdep.c (mips_print_register): Use
6297         value_print_scalar_formatted.
6298
6299 2020-03-13  Tom Tromey  <tom@tromey.com>
6300
6301         * valprint.h (value_print_scalar_formatted): Declare.
6302         * valprint.c (value_print_scalar_formatted): New function.
6303
6304 2020-03-13  Tom Tromey  <tom@tromey.com>
6305
6306         * valprint.h (generic_value_print): Declare.
6307         * valprint.c (generic_value_print): New function.
6308
6309 2020-03-13  Tom Tromey  <tom@tromey.com>
6310
6311         * valprint.c (do_val_print): Call la_value_print_inner, if
6312         available.
6313         * rust-lang.c (rust_language_defn): Update.
6314         * p-lang.c (pascal_language_defn): Update.
6315         * opencl-lang.c (opencl_language_defn): Update.
6316         * objc-lang.c (objc_language_defn): Update.
6317         * m2-lang.c (m2_language_defn): Update.
6318         * language.h (struct language_defn) <la_value_print_inner>: New
6319         member.
6320         * language.c (unknown_language_defn, auto_language_defn): Update.
6321         * go-lang.c (go_language_defn): Update.
6322         * f-lang.c (f_language_defn): Update.
6323         * d-lang.c (d_language_defn): Update.
6324         * c-lang.c (c_language_defn, cplus_language_defn)
6325         (asm_language_defn, minimal_language_defn): Update.
6326         * ada-lang.c (ada_language_defn): Update.
6327
6328 2020-03-13  Tom Tromey  <tom@tromey.com>
6329
6330         * c-valprint.c (c_value_print): Use common_val_print.
6331
6332 2020-03-13  Tom Tromey  <tom@tromey.com>
6333
6334         * cp-valprint.c (cp_print_static_field): Use common_val_print.
6335
6336 2020-03-13  Tom Tromey  <tom@tromey.com>
6337
6338         * f-valprint.c (f77_print_array_1, f_val_print): Use
6339         common_val_print.
6340
6341 2020-03-13  Tom Tromey  <tom@tromey.com>
6342
6343         * riscv-tdep.c (riscv_print_one_register_info): Use
6344         common_val_print.
6345
6346 2020-03-13  Tom Tromey  <tom@tromey.com>
6347
6348         * mi/mi-main.c (output_register): Use common_val_print.
6349
6350 2020-03-13  Tom Tromey  <tom@tromey.com>
6351
6352         * infcmd.c (default_print_one_register_info): Use
6353         common_val_print.
6354
6355 2020-03-13  Tom Tromey  <tom@tromey.com>
6356
6357         * valprint.h (common_val_print_checked): Declare.
6358         * valprint.c (common_val_print_checked): New function.
6359         * stack.c (print_frame_arg): Use common_val_print_checked.
6360
6361 2020-03-13  Tom Tromey  <tom@tromey.com>
6362
6363         * valprint.c (do_val_print): New function, from val_print.
6364         (val_print): Use do_val_print.
6365         (common_val_print): Use do_val_print.
6366
6367 2020-03-13  Tom Tromey  <tom@tromey.com>
6368
6369         * valprint.c (value_print): Use scoped_value_mark.
6370
6371 2020-03-13  Tom de Vries  <tdevries@suse.de>
6372
6373         PR symtab/25646
6374         * psymtab.c (partial_symtab::partial_symtab): Don't set
6375         globals_offset and statics_offset.  Push element onto
6376         current_global_psymbols and current_static_psymbols stacks.
6377         (concat): New function.
6378         (end_psymtab_common): Set globals_offset and statics_offset.  Pop
6379         element from current_global_psymbols and current_static_psymbols
6380         stacks.  Concat popped elements to global_psymbols and
6381         static_symbols.
6382         (add_psymbol_to_list): Use current_global_psymbols and
6383         current_static_psymbols stacks.
6384         * psymtab.h (class psymtab_storage): Add current_global_psymbols and
6385         current_static_psymbols fields.
6386
6387 2020-03-12  Christian Biesinger  <cbiesinger@google.com>
6388
6389         * corelow.c (sniff_core_bfd): Remove.
6390         (class core_target) <m_core_vec>: Remove.
6391         (core_target::core_target): Update.
6392         (core_file_fns): Remove.
6393         (deprecated_add_core_fns): Remove.
6394         (default_core_sniffer): Remove.
6395         (sniff_core_bfd): Remove.
6396         (default_check_format): Remove.
6397         (gdb_check_format): Remove.
6398         (core_target_open): Update.
6399         (core_target::get_core_register_section): Update.
6400         (get_core_registers_cb): Update.
6401         (core_target::fetch_registers): Update.
6402         * gdbcore.h (struct core_fns): Remove.
6403         (deprecated_add_core_fns): Remove.
6404         (default_core_sniffer): Remove.
6405         (default_check_format): Remove.
6406
6407 2020-03-12  Tom Tromey  <tom@tromey.com>
6408
6409         * arm-tdep.c (struct arm_mapping_symbol) <value>: Now a
6410         CORE_ADDR.
6411         (struct arm_exidx_entry) <addr>: Now a CORE_ADDR.
6412
6413 2020-03-12  Tom Tromey  <tom@tromey.com>
6414
6415         * remote.c (remote_target::download_tracepoint)
6416         (remote_target::enable_tracepoint)
6417         (remote_target::disable_tracepoint): Use phex, not sprintf_vma.
6418         * breakpoint.c (print_recreate_masked_watchpoint): Use phex, not
6419         sprintf_vma.
6420
6421 2020-03-12  Tom Tromey  <tom@tromey.com>
6422
6423         * symfile-mem.c: Update CORE_ADDR size assert.
6424
6425 2020-03-12  Simon Marchi  <simon.marchi@efficios.com>
6426
6427         * selftest.m4: Move to gdbsupport/.
6428         * acinclude.m4: Update path to selftest.m4.
6429
6430 2020-03-12  Simon Marchi  <simon.marchi@efficios.com>
6431
6432         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Rename to...
6433         (SELFTESTS_SRCS): ... this.  Add disasm-selftests.c,
6434         gdbarch-selfselftests.c and selftest-arch.c.
6435         (SUBDIR_UNITTESTS_OBS): Rename to...
6436         (SELFTESTS_OBS): ... this.
6437         (COMMON_SFILES): Remove disasm-selftests.c and
6438         gdbarch-selftests.c.
6439         * configure.ac: Don't add selftest-arch.{c,o} to
6440         CONFIG_{SRCS,OBS}.
6441         * disasm-selftests.c, gdbarch-selftests.c: Remove GDB_SELF_TEST
6442         preprocessor conditions.
6443
6444 2020-03-12  Simon Marchi  <simon.marchi@efficios.com>
6445
6446         * configure.ac: Don't source bfd/development.sh.
6447         * selftest.m4: Modify comment.
6448         * configure: Re-generate.
6449
6450 2020-03-12  Simon Marchi  <simon.marchi@efficios.com>
6451
6452         * selftest.m4 (GDB_AC_SELFTEST): Error out if $development is
6453         not "true" or "false".
6454         * configure: Re-generate.
6455
6456 2020-03-12  Christian Biesinger  <cbiesinger@google.com>
6457
6458         * Makefile.in (HFILES_NO_SRCDIR): Add new arm-nbsd-tdep.h file.
6459         * arm-nbsd-nat.c (arm_supply_gregset): Moved to arm-nbsd-tdep and
6460         renamed to arm_nbsd_supply_gregset.
6461         (fetch_register): Update to call arm_nbsd_supply_gregset.
6462         (fetch_regs): Remove in favor of fetch_register with a -1 regno.
6463         (arm_netbsd_nat_target::fetch_registers): Update.
6464         (fetch_elfcore_registers): Removed.
6465         (_initialize_arm_netbsd_nat): Removed call to deprecated_add_core_fns.
6466         * arm-nbsd-tdep.c (struct arm_nbsd_reg): New struct.
6467         (arm_nbsd_supply_gregset): Moved from arm-nbsd-nat.c and updated to
6468         not require NetBSD system headers.
6469         (arm_nbsd_regset): New struct.
6470         (arm_nbsd_iterate_over_regset_sections): New function.
6471         (arm_netbsd_init_abi_common): Updated to call
6472         set_gdbarch_iterate_over_regset_sections.
6473         * arm-nbsd-tdep.h: New file.
6474
6475 2020-03-11  Kevin Buettner  <kevinb@redhat.com>
6476
6477         * symtab.c (find_pc_sect_line): Add check which prevents infinite
6478         recursion.
6479
6480 2020-03-11  Simon Marchi  <simon.marchi@efficios.com>
6481
6482         * configure: Re-generate.
6483
6484 2020-03-11  Tom Tromey  <tromey@adacore.com>
6485
6486         * ada-typeprint.c (print_choices): Fix comment.
6487
6488 2020-03-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6489
6490         * buildsyms.c (buildsym_compunit::record_line): Avoid accessing
6491         previous item in the list, when the list has no items.
6492
6493 2020-03-11  Tom de Vries  <tdevries@suse.de>
6494
6495         * dwarf2/loc.c (dwarf2_evaluate_property): Handle NULL frame in
6496         PROP_LOCLIST handling code.
6497
6498 2020-03-10  Andrew Burgess  <andrew.burgess@embecosm.com>
6499
6500         * buildsym-legacy.c (record_line): Pass extra parameter to
6501         record_line.
6502         * buildsym.c (buildsym_compunit::record_line): Take an extra
6503         parameter, reduce duplication in the line table, and record the
6504         is_stmt flag in the line table.
6505         * buildsym.h (buildsym_compunit::record_line): Add extra
6506         parameter.
6507         * disasm.c (do_mixed_source_and_assembly_deprecated): Ignore
6508         non-statement lines.
6509         * dwarf2/read.c (dwarf_record_line_1): Add extra parameter, pass
6510         this to the symtab builder.
6511         (dwarf_finish_line): Pass extra parameter to dwarf_record_line_1.
6512         (lnp_state_machine::record_line): Pass a suitable is_stmt flag
6513         through to dwarf_record_line_1.
6514         * infrun.c (process_event_stop_test): When stepping, don't stop at
6515         a non-statement instruction, and only refresh the step info when
6516         we land in the middle of a line's range.  Also add an extra
6517         comment.
6518         * jit.c (jit_symtab_line_mapping_add_impl): Initialise is_stmt
6519         field.
6520         * record-btrace.c (btrace_find_line_range): Only record lines
6521         marked as is-statement.
6522         * stack.c (frame_show_address): Show the frame address if we are
6523         in a non-statement sal.
6524         * symmisc.c (dump_symtab_1): Print the is_stmt flag.
6525         (maintenance_print_one_line_table): Print a header for the is_stmt
6526         column, and include is_stmt information in the output.
6527         * symtab.c (find_pc_sect_line): Find lines marked as statements in
6528         preference to non-statements.
6529         (find_pcs_for_symtab_line): Prefer is-statement entries.
6530         (find_line_common): Likewise.
6531         * symtab.h (struct linetable_entry): Add is_stmt field.
6532         (struct symtab_and_line): Likewise.
6533         * xcoffread.c (arrange_linetable): Initialise is_stmt field when
6534         arranging the line table.
6535
6536 2020-03-07  Tom de Vries  <tdevries@suse.de>
6537
6538         * dwarf2/read.c (read_typedef): Treat anonymous typedef as forwarder
6539         DIE.
6540
6541 2020-03-07  Tom Tromey  <tom@tromey.com>
6542
6543         * valops.c (value_literal_complex): Remove obsolete comment.
6544         * gdbtypes.h (enum type_code) <TYPE_CODE_FLT>: Remove obsolete
6545         comment.
6546
6547 2020-03-06  Simon Marchi  <simon.marchi@polymtl.ca>
6548
6549         * infrun.h: Forward-declare thread_info.
6550         (set_step_info): Add thread_info parameter, add doc.
6551         * infrun.c (set_step_info): Add thread_info parameter, move doc
6552         to header.
6553         * infrun.c (process_event_stop_test): Pass thread to
6554         set_step_info call.
6555         * infcmd.c (set_step_frame): Add thread_info pointer, pass it to
6556         set_step_info.
6557         (prepare_one_step): Add thread_info parameter, pass it to
6558         set_step_frame and prepare_one_step (recursive) call.
6559         (step_1): Pass thread to prepare_one_step call.
6560         (step_command_fsm::should_stop): Pass thread to
6561         prepare_one_step.
6562         (until_next_fsm): Pass thread to set_step_frame call.
6563         (finish_command): Pass thread to set_step_info call.
6564
6565 2020-03-06  Hannes Domani  <ssbssa@yahoo.de>
6566
6567         * windows-tdep.c (windows_solib_create_inferior_hook):
6568         Check if inferior is running.
6569
6570 2020-03-06  Tom de Vries  <tdevries@suse.de>
6571
6572         * NEWS: Fix "the the".
6573         * ctfread.c: Same.
6574
6575 2020-03-06  Tom de Vries  <tdevries@suse.de>
6576
6577         * psymtab.c (psymtab_to_symtab): Don't print "done.".
6578
6579 2020-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6580
6581         * .dir-locals.el: Add a comment referencing the other copies of
6582         this file.
6583
6584 2020-03-05  John Baldwin  <jhb@FreeBSD.org>
6585
6586         * fbsd-tdep.c (fbsd_make_corefile_notes): Use std::string for
6587         psargs.
6588
6589 2020-03-05  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
6590
6591         * .gitattributes: New file.
6592
6593 2020-03-04  Tom Tromey  <tom@tromey.com>
6594
6595         * symmisc.c (print_symbol_bcache_statistics)
6596         (print_objfile_statistics): Update.
6597         * symfile.c (allocate_symtab): Use intern.
6598         * psymtab.c (partial_symtab::partial_symtab): Use intern.
6599         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
6600         macro_cache>: Remove.
6601         <string_cache>: New member.
6602         (struct objfile) <intern>: New methods.
6603         * elfread.c (elf_symtab_read): Use intern.
6604         * dwarf2/read.c (fixup_go_packaging): Intern package name.
6605         (dwarf2_compute_name, dwarf2_physname)
6606         (create_dwo_unit_in_dwp_v1, create_dwo_unit_in_dwp_v2): Intern
6607         names.
6608         (guess_partial_die_structure_name): Update.
6609         (partial_die_info::fixup): Intern name.
6610         (dwarf2_canonicalize_name): Change parameter to objfile.  Intern
6611         name.
6612         (dwarf2_name): Intern name.  Update.
6613         * buildsym.c (buildsym_compunit::get_macro_table): Use
6614         string_cache.
6615
6616 2020-03-04  Tom Tromey  <tom@tromey.com>
6617
6618         * jit.c (bfd_open_from_target_memory): Make "target" const.
6619         * corefile.c (gnutarget): Now const.
6620         * gdbcore.h (gnutarget): Now const.
6621
6622 2020-03-04  Hannes Domani  <ssbssa@yahoo.de>
6623
6624         * NEWS: Mention support for WOW64 processes.
6625         * amd64-windows-nat.c (amd64_mappings): Rename and remove static.
6626         (amd64_windows_segment_register_p): Remove static.
6627         (_initialize_amd64_windows_nat): Update.
6628         * configure.nat <windows> (NATDEPFILES): Add i386-windows-nat.o.
6629         * i386-windows-nat.c (context_offset): Update.
6630         (i386_mappings): Rename and remove static.
6631         (i386_windows_segment_register_p): Remove static.
6632         (_initialize_i386_windows_nat): Update.
6633         * windows-nat.c (STATUS_WX86_BREAKPOINT): New macro.
6634         (STATUS_WX86_SINGLE_STEP): New macro.
6635         (EnumProcessModulesEx): New macro.
6636         (Wow64SuspendThread): New macro.
6637         (Wow64GetThreadContext): New macro.
6638         (Wow64SetThreadContext): New macro.
6639         (Wow64GetThreadSelectorEntry): New macro.
6640         (windows_set_context_register_offsets): Add static.
6641         (windows_set_segment_register_p): Likewise.
6642         (windows_add_thread): Adapt for WOW64 processes.
6643         (windows_fetch_one_register): Likewise.
6644         (windows_nat_target::fetch_registers): Likewise.
6645         (windows_store_one_register): Likewise.
6646         (display_selector): Likewise.
6647         (display_selectors): Likewise.
6648         (handle_exception): Likewise.
6649         (windows_continue): Likewise.
6650         (windows_nat_target::resume): Likewise.
6651         (windows_add_all_dlls): Likewise.
6652         (do_initial_windows_stuff): Likewise.
6653         (windows_nat_target::attach): Likewise.
6654         (windows_get_exec_module_filename): Likewise.
6655         (windows_nat_target::create_inferior): Likewise.
6656         (windows_xfer_siginfo): Likewise.
6657         (_initialize_loadable): Initialize Wow64SuspendThread,
6658         Wow64GetThreadContext, Wow64SetThreadContext,
6659         Wow64GetThreadSelectorEntry and EnumProcessModulesEx.
6660         * windows-nat.h (windows_set_context_register_offsets):
6661         Remove declaration.
6662         (windows_set_segment_register_p): Likewise.
6663         (i386_windows_segment_register_p): Add declaration.
6664         (amd64_windows_segment_register_p): Likewise.
6665
6666 2020-03-04  Luis Machado  <luis.machado@linaro.org>
6667
6668         Revert aa66aac47b4dd38f9524ddb5546c08cc09930d37 due to regressions
6669         in "info registers" for AArch64/ARM.
6670
6671         The change caused "info registers" to not print GPR's.
6672
6673         gdb/ChangeLog:
6674
6675         2020-02-01  Shahab Vahedi  <shahab@synopsys.com>
6676
6677         * target-descriptions.c (tdesc_register_in_reggroup_p): Return 0
6678         when reg->group is empty and reggroup is not.
6679
6680 2020-03-03  Tom Tromey  <tromey@adacore.com>
6681
6682         * dwarf2/frame.c (struct dwarf2_frame_cache)
6683         <checked_tailcall_bottom, entry_cfa_sp_offset,
6684         entry_cfa_sp_offset_p>: Remove members.
6685         (dwarf2_frame_cache): Call dwarf2_tailcall_sniffer_first.
6686         (dwarf2_frame_prev_register): Don't call
6687         dwarf2_tailcall_sniffer_first.
6688         (dwarf2_append_unwinders): Don't append tailcall unwinder.
6689         * frame-unwind.c (add_unwinder): New fuction.
6690         (frame_unwind_init): Use it.  Add tailcall unwinder.
6691
6692 2020-03-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6693             Alok Kumar Sharma  <AlokKumar.Sharma@amd.com>
6694
6695         * f-valprint.c (f_val_print): Handle TYPE_CODE_BOOL, any non-zero
6696         value should be printed as true.
6697
6698 2020-03-03  Hannes Domani  <ssbssa@yahoo.de>
6699
6700         * windows-tdep.c (windows_solib_create_inferior_hook): New function.
6701         (windows_init_abi): Set and use windows_so_ops.
6702
6703 2020-03-03  Sergio Durigan Junior  <sergiodj@redhat.com>
6704
6705         * printcmd.c (print_c_string): Check also for TYPE_CODE_PTR
6706         when verifying if dealing with a convenience variable.
6707
6708 2020-03-03  Luis Machado  <luis.machado@linaro.org>
6709
6710         * auxv.c (default_print_auxv_entry): Add new AUXV entries.
6711
6712 2020-03-02  Simon Marchi  <simon.marchi@polymtl.ca>
6713
6714         * infrun.c (gdbarch_supports_displaced_stepping): New.
6715         (use_displaced_stepping): Break up conditions in smaller pieces.
6716         Use gdbarch_supports_displaced_stepping.
6717         (displaced_step_prepare_throw): Use
6718         gdbarch_supports_displaced_stepping.
6719
6720 2020-03-02  Andrew Burgess  <andrew.burgess@embecosm.com>
6721
6722         * NEWS: Mention new behaviour of the history filename.
6723         * top.c (write_history_p): Add comment.
6724         (show_write_history_p): Add header comment, give a different
6725         message when history writing is on, but the history filename is
6726         empty.
6727         (history_filename): Add comment.
6728         (history_filename_empty): New function.
6729         (show_history_filename): Add header comment, give a different
6730         message when the filename is empty.
6731         (init_history): Compare history_filename against nullptr, and only
6732         read history if the filename is not empty.
6733         (set_history_filename): Add header comment, and only make
6734         non-empty filenames absolute.
6735         (init_main): Make the filename argument to 'set history filename'
6736         optional.
6737
6738 2020-03-02  Christian Biesinger  <cbiesinger@google.com>
6739
6740         * arm-nbsd-nat.c (arm_supply_fparegset): Rename to...
6741         (arm_supply_vfpregset): ...this, and update to use VFP registers.
6742         (fetch_fp_register): Update.
6743         (fetch_fp_regs): Update.
6744         (store_fp_register): Update.
6745         (store_fp_regs): Update.
6746         (arm_netbsd_nat_target::read_description): New function.
6747         (fetch_elfcore_registers): Update.
6748
6749 2020-03-02  Andrew Burgess  <andrew.burgess@embecosm.com>
6750
6751         * remote.c (remote_target::remote_parse_stop_reply): Don't use the
6752         general_thread if the stop reply is missing a thread-id.
6753         (remote_target::process_stop_reply): Use the first non-exited
6754         thread if the target didn't pass a thread-id.
6755         * infrun.c (do_target_wait): Move call to
6756         switch_to_inferior_no_thread to ....
6757         (do_target_wait_1): ... here.
6758
6759 2020-02-29  Jon Turney  <jon.turney@dronecode.org.uk>
6760
6761         * debuginfod-support.c: Include defs.h first.
6762
6763 2020-02-28  Tom de Vries  <tdevries@suse.de>
6764
6765         * symfile.c (set_initial_language): Use default language for lookup.
6766
6767 2020-02-28  Simon Marchi  <simon.marchi@efficios.com>
6768
6769         * dwarf2/read.c (cutu_reader::init_tu_and_read_dwo_dies): Remove
6770         reader variable, pass `this` to read_cutu_die_from_dwo.
6771
6772 2020-02-27  Aaron Merey  <amerey@redhat.com>
6773
6774         * source.c (open_source_file): Check for nullptr when computing
6775         srcpath.
6776
6777 2020-02-27  Tom Tromey  <tromey@adacore.com>
6778
6779         * dwarf2/read.c (struct field_info) <nfields>: Now a method, not a
6780         member.
6781         (dwarf2_add_field): Don't update nfields.
6782         (dwarf2_attach_fields_to_type, process_structure_scope): Update.
6783
6784 2020-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6785
6786         * gdbtypes.c (create_array_type_with_stride): Use std::abs not
6787         abs.
6788
6789 2020-02-26  Tom Tromey  <tom@tromey.com>
6790
6791         * dwarf2/read.c (struct dwarf2_include_psymtab): New.
6792         (dwarf2_create_include_psymtab): Use dwarf2_include_psymtab.
6793         (dwarf2_psymtab::expand_psymtab, dwarf2_psymtab::readin_p)
6794         (dwarf2_psymtab::get_compunit_symtab): Remove null checks for
6795         per_cu_data.
6796
6797 2020-02-26  Tom Tromey  <tom@tromey.com>
6798
6799         * dwarf2/index-write.c (psym_index_map): Change type.
6800         (add_address_entry_worker, write_one_signatured_type)
6801         (recursively_count_psymbols, recursively_write_psymbols)
6802         (class debug_names, psyms_seen_size, write_gdbindex)
6803         (write_debug_names): Use partial_symtab, not dwarf2_psymtab.
6804
6805 2020-02-26  Aaron Merey  <amerey@redhat.com>
6806
6807         * Makefile.in: Handle optional debuginfod support.
6808         * NEWS: Update.
6809         * README: Add --with-debuginfod summary.
6810         * config.in: Regenerate.
6811         * configure: Regenerate.
6812         * configure.ac: Handle optional debuginfod support.
6813         * debuginfod-support.c: debuginfod helper functions.
6814         * debuginfod-support.h: Ditto.
6815         * doc/gdb.texinfo: Add --with-debuginfod to configure options
6816         summary.
6817         * dwarf2/read.c (dwarf2_get_dwz_file): Query debuginfod servers
6818         when a dwz file cannot be found.
6819         * elfread.c (elf_symfile_read): Query debuginfod servers when a
6820         debuginfo file cannot be found.
6821         * source.c (open_source_file): Query debuginfod servers when a
6822         source file cannot be found.
6823         * top.c (print_gdb_configuration): Include
6824         --{with,without}-debuginfod in the output.
6825
6826 2020-02-26  Jérémie Galarneau  <jeremie.galarneau@efficios.com>
6827
6828         * thread.c (thr_try_catch_cmd): Print thread name.
6829
6830 2020-02-26  Simon Marchi  <simon.marchi@efficios.com>
6831
6832         * dwarf2/loc.h (dwarf2_fetch_die_loc_sect_off,
6833         dwarf2_fetch_die_loc_cu_off, dwarf2_fetch_constant_bytes,
6834         dwarf2_fetch_die_type_sect_off): Move to...
6835         * dwarf2/read.h (dwarf2_fetch_die_loc_sect_off,
6836         dwarf2_fetch_die_loc_cu_off, dwarf2_fetch_constant_bytes,
6837         dwarf2_fetch_die_type_sect_off): ... here.
6838         * dwarf2/read.c (dwarf2_fetch_die_loc_sect_off,
6839         dwarf2_fetch_die_loc_cu_off, dwarf2_fetch_constant_bytes,
6840         dwarf2_fetch_die_type_sect_off): Move doc to header file.
6841
6842 2020-02-26  Tom de Vries  <tdevries@suse.de>
6843
6844         PR gdb/25603
6845         * symfile.c (set_initial_language): Exit-early if
6846         language_mode == language_mode_manual.
6847
6848 2020-02-25  Simon Marchi  <simon.marchi@polymtl.ca>
6849
6850         * dwarf2/loc.h (dwarf2_read_addr_index): Move...
6851         * dwarf2/read.h (dwarf2_read_addr_index): ... here.
6852         * dwarf2/read.c (dwarf2_read_addr_index): Move doc to header.
6853
6854 2020-02-25  Andrew Burgess  <andrew.burgess@embecosm.com>
6855
6856         * gdbtypes.c (create_array_type_with_stride): Handle negative
6857         array strides.
6858         * valarith.c (value_subscripted_rvalue): Likewise.
6859
6860 2020-02-25  Luis Machado  <luis.machado@linaro.org>
6861
6862         * aarch64-tdep.c (aarch64_vnv_type): Fix comment typo.
6863
6864 2020-02-25  Simon Marchi  <simon.marchi@polymtl.ca>
6865
6866         * loc.h (dwarf2_get_die_type): Move to...
6867         * read.h (dwarf2_get_die_type): ... here.
6868         * read.c (dwarf2_get_die_type): Move doc to header.
6869
6870 2020-02-25  Joel Brobecker  <brobecker@adacore.com>
6871
6872         * copypright.py (EXCLUDE_LIST): Add 'gnulib/config.in' and
6873         'gnulib/Makefile.in' to the list.
6874
6875 2020-02-24  Tom Tromey  <tom@tromey.com>
6876
6877         * dwarf2/read.h (struct type_unit_unshareable) <num_symtabs>:
6878         Remove.
6879         * dwarf2/read.c (dwarf2_cu::setup_type_unit_groups): Use
6880         XOBNEWVEC.
6881
6882 2020-02-24  Tom Tromey  <tom@tromey.com>
6883
6884         * dwarf2/read.h (struct dwarf2_per_cu_data) <type_unit_group_p>:
6885         New method.
6886         * dwarf2/read.c (IS_TYPE_UNIT_GROUP): Remove.
6887         (dw2_do_instantiate_symtab, dw2_get_file_names)
6888         (build_type_psymtab_dependencies, load_full_type_unit): Update.
6889
6890 2020-02-24  Tom Tromey  <tom@tromey.com>
6891
6892         * dwarf2read.c (dwarf2_build_psymtabs_hard): Use
6893         make_scoped_restore.
6894         (dwarf2_psymtab::read_symtab): Don't clear
6895         reading_partial_symbols.
6896
6897 2020-02-24  Tom de Vries  <tdevries@suse.de>
6898
6899         PR gdb/25592
6900         * stack.c (iterate_over_block_locals): Handle LOC_CONST.
6901
6902 2020-02-24  Tom de Vries  <tdevries@suse.de>
6903
6904         * tui/tui-layout.c (_initialize_tui_layout): Fix help messages for
6905         commands layout next/prev/regs.
6906
6907 2020-02-22  Tom Tromey  <tom@tromey.com>
6908
6909         * dwarf2/loc.h (dwarf2_compile_expr_to_ax): Don't declare.
6910         * dwarf2/loc.c (dwarf2_compile_expr_to_ax): Now static.
6911
6912 2020-02-22  Tom Tromey  <tom@tromey.com>
6913
6914         * tui/tui-data.h (TUI_DISASM_WIN): Cast to tui_disasm_window.
6915
6916 2020-02-22  Tom Tromey  <tom@tromey.com>
6917
6918         * tui/tui-win.c (_initialize_tui_win): Add usage text.
6919         * tui/tui-stack.c (_initialize_tui_stack): Add usage text.
6920         * tui/tui-regs.c (_initialize_tui_regs): Add usage text.
6921         * tui/tui.c (_initialize_tui): Add usage text.
6922
6923 2020-02-22  Tom Tromey  <tom@tromey.com>
6924
6925         * tui/tui-win.c (tui_set_focus_command)
6926         (tui_set_win_height_command): Use error_no_arg.
6927         (_initialize_tui_win): Update help text.
6928         (FOCUS_USAGE, WIN_HEIGHT_USAGE): Don't define.
6929
6930 2020-02-22  Tom Tromey  <tom@tromey.com>
6931
6932         * tui/tui-layout.c (extract_display_start_addr): Rewrite.
6933         * tui/tui-disasm.h (struct tui_disasm_window)
6934         <display_start_addr>: Declare.
6935         * tui/tui-source.h (struct tui_source_window)
6936         <display_start_addr>: Declare.
6937         * tui/tui-winsource.h (struct tui_source_window_base)
6938         <show_source_line, display_start_addr>: New methods.
6939         <m_horizontal_offset, m_start_line_or_addr, m_gdbarch, m_content>:
6940         Rename and move to protected section.
6941         * tui/tui-winsource.c (tui_source_window_base::update_source_window)
6942         (tui_source_window_base::do_erase_source_content): Update.
6943         (tui_source_window_base::show_source_line): Now a method.
6944         (tui_source_window_base::show_source_content)
6945         (tui_source_window_base::tui_source_window_base)
6946         (tui_source_window_base::rerender)
6947         (tui_source_window_base::refill)
6948         (tui_source_window_base::do_scroll_horizontal)
6949         (tui_source_window_base::set_is_exec_point_at)
6950         (tui_source_window_base::update_breakpoint_info)
6951         (tui_source_window_base::update_exec_info): Update.
6952         * tui/tui-source.c (tui_source_window::set_contents)
6953         (tui_source_window::showing_source_p)
6954         (tui_source_window::do_scroll_vertical)
6955         (tui_source_window::location_matches_p)
6956         (tui_source_window::line_is_displayed): Update.
6957         (tui_source_window::display_start_addr): New method.
6958         * tui/tui-disasm.c (tui_disasm_window::set_contents)
6959         (tui_disasm_window::do_scroll_vertical)
6960         (tui_disasm_window::location_matches_p): Update.
6961         (tui_disasm_window::display_start_addr): New method.
6962
6963 2020-02-22  Tom Tromey  <tom@tromey.com>
6964
6965         * NEWS: Add entry for gdb.register_window_type.
6966         * tui/tui-layout.h (window_factory): New typedef.
6967         (tui_register_window): Declare.
6968         * tui/tui-layout.c (saved_tui_windows): New global.
6969         (tui_apply_current_layout): Use it.
6970         (tui_register_window): New function.
6971         * python/python.c (do_start_initialization): Call
6972         gdbpy_initialize_tui.
6973         (python_GdbMethods): Add "register_window_type" function.
6974         * python/python-internal.h (gdbpy_register_tui_window)
6975         (gdbpy_initialize_tui): Declare.
6976         * python/py-tui.c: New file.
6977         * Makefile.in (SUBDIR_PYTHON_SRCS): Add py-tui.c.
6978
6979 2020-02-22  Tom Tromey  <tom@tromey.com>
6980
6981         * tui/tui-io.c (do_tui_putc): Don't omit annotations.
6982
6983 2020-02-22  Tom Tromey  <tom@tromey.com>
6984
6985         * tui/tui-win.c (tui_set_win_focus_to): Move to tui-data.c.
6986         * tui/tui-data.h (tui_set_win_with_focus): Don't declare.
6987         * tui/tui-data.c (tui_set_win_with_focus): Remove.
6988         (tui_set_win_focus_to): Move from tui-win.c.
6989
6990 2020-02-22  Tom Tromey  <tom@tromey.com>
6991
6992         * tui/tui-layout.c (make_standard_window, get_locator_window): New
6993         functions.
6994         (known_window_types): New global.
6995         (tui_get_window_by_name): Reimplement.
6996         (initialize_known_windows): New function.
6997         (validate_window_name): Rewrite.
6998         (_initialize_tui_layout): Call initialize_known_windows.
6999
7000 2020-02-22  Tom Tromey  <tom@tromey.com>
7001
7002         * tui/tui.h (enum tui_win_type) <LOCATOR_WIN, DATA_ITEM_WIN>:
7003         Remove constants.
7004         * tui/tui-winsource.h (struct tui_source_window_base)
7005         <tui_source_window_base>: Remove parameter.
7006         * tui/tui-winsource.c
7007         (tui_source_window_base::tui_source_window_base): Remove
7008         parameter.
7009         (tui_source_window_base::refill): Update.
7010         * tui/tui-stack.h (struct tui_locator_window)
7011         <tui_locator_window>: Update.
7012         * tui/tui-source.h (struct tui_source_window) <tui_source_window>:
7013         Default the constructor.
7014         * tui/tui-regs.h (struct tui_data_item_window)
7015         <tui_data_item_window>: Default the constructor.
7016         (struct tui_data_window) <tui_data_window>: Likewise.
7017         * tui/tui-disasm.h (struct tui_disasm_window) <tui_disasm_window>:
7018         Default the constructor.
7019         * tui/tui-data.h (struct tui_gen_win_info) <tui_gen_win_info>:
7020         Default the constructor.
7021         <type>: Remove.
7022         (struct tui_win_info) <tui_win_info>: Default the constructor.
7023         * tui/tui-data.c (tui_win_info::tui_win_info): Remove.
7024         * tui/tui-command.h (struct tui_cmd_window) <tui_cmd_window>:
7025         Default the constructor.
7026
7027 2020-02-22  Tom Tromey  <tom@tromey.com>
7028
7029         * tui/tui-wingeneral.h (tui_make_all_invisible): Don't declare.
7030         * tui/tui-wingeneral.c (tui_make_all_invisible): Remove.
7031         * tui/tui-win.c (tui_resize_all): Don't call
7032         tui_delete_invisible_windows.
7033         * tui/tui-layout.c (tui_apply_current_layout): Delete windows when
7034         done.
7035         (tui_set_layout): Update.
7036         (tui_add_win_to_layout): Don't call tui_delete_invisible_windows.
7037         * tui/tui-data.h (tui_delete_invisible_windows): Don't declare.
7038         * tui/tui-data.c (tui_delete_invisible_windows): Remove.
7039
7040 2020-02-22  Tom Tromey  <tom@tromey.com>
7041
7042         * tui/tui-win.c (tui_partial_win_by_name): Handle ambiguity
7043         correctly.
7044
7045 2020-02-22  Tom Tromey  <tom@tromey.com>
7046
7047         * tui/tui-data.c (tui_next_win, tui_prev_win): Reimplement.
7048
7049 2020-02-22  Tom Tromey  <tom@tromey.com>
7050
7051         * tui/tui-winsource.h (struct tui_source_window_iterator)
7052         <inner_iterator>: New etytypedef.
7053         <tui_source_window_iterator>: Take "end" parameter.
7054         <tui_source_window_iterator>: Take iterator.
7055         <operator*, advance>: Update.
7056         <m_iter>: Change type.
7057         <m_end>: New field.
7058         (struct tui_source_windows) <begin, end>: Update.
7059         * tui/tui-layout.c (tui_windows): New global.
7060         (tui_apply_current_layout): Clear tui_windows.
7061         (tui_layout_window::apply): Update tui_windows.
7062         * tui/tui-data.h (tui_windows): Declare.
7063         (all_tui_windows): Now inline function.
7064         (class tui_window_iterator, struct all_tui_windows): Remove.
7065
7066 2020-02-22  Tom Tromey  <tom@tromey.com>
7067
7068         PR tui/17850:
7069         * tui/tui-win.c (tui_gen_win_info::max_width): New method.
7070         * tui/tui-layout.h (class tui_layout_base) <get_sizes>: Add
7071         "height" argument.
7072         (class tui_layout_window) <get_sizes>: Likewise.
7073         (class tui_layout_split) <tui_layout_split>: Add "vertical"
7074         argument.
7075         <get_sizes>: Add "height" argument.
7076         <m_vertical>: New field.
7077         * tui/tui-layout.c (tui_layout_split::clone): Update.
7078         (tui_layout_split::get_sizes): Add "height" argument.
7079         (tui_layout_split::adjust_size, tui_layout_split::apply): Update.
7080         (tui_new_layout_command): Parse "-horizontal".
7081         (_initialize_tui_layout): Update help string.
7082         (tui_layout_split::specification): Add "-horizontal" when needed.
7083         * tui/tui-layout.c (tui_layout_window::get_sizes): Add "height"
7084         argument.
7085         * tui/tui-data.h (struct tui_gen_win_info) <max_width, min_width>:
7086         New methods.
7087
7088 2020-02-22  Tom Tromey  <tom@tromey.com>
7089
7090         * tui/tui-layout.h (enum tui_adjust_result): New.
7091         (class tui_layout_base) <adjust_size>: Return tui_adjust_result.
7092         (class tui_layout_window) <adjust_size>: Return
7093         tui_adjust_result.  Rewrite.
7094         (class tui_layout_split) <adjust_size>: Return tui_adjust_result.
7095         * tui/tui-layout.c (tui_layout_split::adjust_size): Update.
7096
7097 2020-02-22  Tom Tromey  <tom@tromey.com>
7098
7099         * tui/tui-layout.h (class tui_layout_split) <add_split>: Change
7100         parameter and return types.
7101         (class tui_layout_base) <specification>: Add "depth".
7102         (class tui_layout_window) <specification>: Add "depth".
7103         (class tui_layout_split) <specification>: Add "depth".
7104         * tui/tui-layout.c (tui_layout_split::add_split): Change parameter
7105         and return types.
7106         (tui_new_layout_command): Parse sub-layouts.
7107         (_initialize_tui_layout): Update help string.
7108         (tui_layout_window::specification): Add "depth".
7109         (add_layout_command): Update.
7110
7111 2020-02-22  Tom Tromey  <tom@tromey.com>
7112
7113         * NEWS: Add "tui new-layout" item.
7114         * tui/tui-layout.c (add_layout_command): Return cmd_list_element.
7115         Add new-layout command to help text.
7116         (validate_window_name): New function.
7117         (tui_new_layout_command): New function.
7118         (_initialize_tui_layout): Register "new-layout".
7119         (tui_layout_window::specification): New method.
7120         (tui_layout_window::specification): New method.
7121         * tui/tui-layout.h (class tui_layout_base) <specification>: New
7122         method.
7123         (class tui_layout_window) <specification>: New method.
7124         (class tui_layout_split) <specification>: New method.
7125
7126 2020-02-22  Tom Tromey  <tom@tromey.com>
7127
7128         * tui/tui.c (tui_enable): Call tui_set_initial_layout.
7129         * tui/tui-win.c (window_name_completer): Update comment.
7130         * tui/tui-layout.h (class tui_layout_base) <replace_window>:
7131         Declare method.
7132         (class tui_layout_window) <replace_window>: Likewise.
7133         (class tui_layout_split) <replace_window>: Likewise.
7134         (tui_set_layout): Don't declare.
7135         (tui_set_initial_layout): Declare function.
7136         * tui/tui-layout.c (layouts, applied_skeleton, src_regs_layout)
7137         (asm_regs_layout): New globals.
7138         (tui_current_layout, show_layout): Remove.
7139         (tui_set_layout, tui_add_win_to_layout): Rewrite.
7140         (find_layout, tui_apply_layout): New function.
7141         (layout_completer): Remove.
7142         (tui_next_layout): Reimplement.
7143         (tui_next_layout_command): New function.
7144         (tui_set_initial_layout, tui_prev_layout_command): New functions.
7145         (tui_regs_layout): Reimplement.
7146         (tui_regs_layout_command): New function.
7147         (extract_display_start_addr): Rewrite.
7148         (next_layout, prev_layout): Remove.
7149         (tui_layout_window::replace_window): New method.
7150         (tui_layout_split::replace_window): New method.
7151         (destroy_layout): New function.
7152         (layout_list): New global.
7153         (add_layout_command): New function.
7154         (initialize_layouts): Update.
7155         (tui_layout_command): New function.
7156         (_initialize_tui_layout): Install "layout" commands.
7157         * tui/tui-data.h (enum tui_layout_type): Remove.
7158         (tui_current_layout): Don't declare.
7159
7160 2020-02-22  Tom Tromey  <tom@tromey.com>
7161
7162         * tui/tui-regs.c (tui_reg_layout): Remove.
7163         (tui_reg_command): Use tui_regs_layout.
7164         * tui/tui-layout.h (tui_reg_command): Declare.
7165         * tui/tui-layout.c (tui_reg_command): New function.
7166
7167 2020-02-22  Tom Tromey  <tom@tromey.com>
7168
7169         * tui/tui.c (tui_rl_delete_other_windows): Call
7170         tui_remove_some_windows.
7171         * tui/tui-layout.h (class tui_layout_base) <remove_windows>:
7172         Declare method.
7173         (class tui_layout_window) <remove_windows>: New method.
7174         (class tui_layout_split) <remove_windows>: Declare.
7175         (tui_remove_some_windows): Declare.
7176         * tui/tui-layout.c (tui_remove_some_windows): New function.
7177         (tui_layout_split::remove_windows): New method.
7178
7179 2020-02-22  Tom Tromey  <tom@tromey.com>
7180
7181         * tui/tui.c (tui_rl_change_windows): Call tui_next_layout.
7182         * tui/tui-layout.h (tui_next_layout): Declare.
7183         * tui/tui-layout.c (tui_next_layout): New function.
7184
7185 2020-02-22  Tom Tromey  <tom@tromey.com>
7186
7187         * tui/tui-regs.c (tui_data_window::display_registers_from): Use
7188         correct coordinates.
7189
7190 2020-02-22  Tom Tromey  <tom@tromey.com>
7191
7192         * tui/tui-layout.h (tui_add_win_to_layout): Add comment.
7193         * tui/tui-layout.c (tui_add_win_to_layout): Add assert.  Remove
7194         DATA_WIN case.
7195
7196 2020-02-22  Tom Tromey  <tom@tromey.com>
7197
7198         * tui/tui-disasm.c (tui_get_low_disassembly_address): Use
7199         TUI_DISASM_WIN, not tui_win_list.
7200
7201 2020-02-22  Tom Tromey  <tom@tromey.com>
7202
7203         * valprint.c (generic_val_print_enum_1)
7204         (val_print_type_code_flags): Style member names.
7205         * rust-lang.c (val_print_struct, rust_print_enum)
7206         (rust_print_struct_def, rust_internal_print_type): Style member
7207         names.
7208         * p-valprint.c (pascal_object_print_value_fields): Style member
7209         names.  Only call fprintf_symbol_filtered for static members.
7210         * m2-typeprint.c (m2_record_fields, m2_enum): Style member names.
7211         * f-valprint.c (f_val_print): Style member names.
7212         * f-typeprint.c (f_type_print_base): Style member names.
7213         * cp-valprint.c (cp_print_value_fields): Style member names.  Only
7214         call fprintf_symbol_filtered for static members.
7215         (cp_print_class_member): Style member names.
7216         * c-typeprint.c (c_print_type_1, c_type_print_base_1): Style
7217         member names.
7218         * ada-valprint.c (ada_print_scalar): Style enum names.
7219         (ada_val_print_enum): Likewise.
7220         * ada-typeprint.c (print_enum_type): Style enum names.
7221
7222 2020-02-21  Tom Tromey  <tom@tromey.com>
7223
7224         * psympriv.h (struct partial_symtab): Update comment.
7225
7226 2020-02-21  Tom Tromey  <tromey@adacore.com>
7227
7228         * mips-tdep.h (mips_pc_is_mips16, mips_pc_is_micromips): Parameter
7229         type is CORE_ADDR.
7230
7231 2020-02-21  Tom de Vries  <tdevries@suse.de>
7232
7233         PR gdb/25534
7234         * psymtab.c (partial_symtab::read_dependencies): Don't read dependency
7235         if dependencies[i]->user != NULL.
7236
7237 2020-02-21  Ali Tamur  <tamur@google.com>
7238
7239         * dwarf2/read.c (dwarf2_name): Add null check.
7240
7241 2020-02-20  Tom Tromey  <tom@tromey.com>
7242
7243         * dwarf2/read.c (dwarf2_find_containing_comp_unit): Use ">", not
7244         ">=", in binary search.
7245         (dwarf2_find_containing_comp_unit): New overload.
7246         (run_test): New self-test.
7247         (_initialize_dwarf2_read): Register new test.
7248
7249 2020-02-20  Nelson Chu  <nelson.chu@sifive.com>
7250
7251         * riscv-tdep.c: Updated since the DECLARE_CSR is changed.
7252         * riscv-tdep.h: Likewise.
7253         * features/riscv/rebuild-csr-xml.sh: Generate the 64bit-csr.xml without
7254         rv32-only CSR.
7255         * features/riscv/64bit-csr.xml: Regenerated.
7256
7257 2020-02-20  Sergio Durigan Junior  <sergiodj@redhat.com>
7258             Tom Tromey  <tom@tromey.com>
7259
7260         * utils.c (fputs_maybe_filtered): Call 'stream->puts' instead
7261         of 'fputc_unfiltered'.
7262         (putchar_unfiltered): Call 'fputc_unfiltered'.
7263         (fputc_unfiltered): Call 'fputs_unfiltered'.
7264
7265 2020-02-20  Andrew Burgess  <andrew.burgess@embecosm.com>
7266
7267         * config.in: Regenerate.
7268         * configure: Regenerate.
7269         * configure.ac: Add --with-python-libdir option.
7270         * main.c: Use WITH_PYTHON_LIBDIR.
7271
7272 2020-02-19  Tom Tromey  <tom@tromey.com>
7273
7274         * symtab.c (general_symbol_info::compute_and_set_names): Use
7275         obstack_strndup.  Simplify call to symbol_set_demangled_name.
7276
7277 2020-02-19  Simon Marchi  <simon.marchi@efficios.com>
7278
7279         * dwarf2/read.c (allocate_signatured_type_table,
7280         allocate_dwo_unit_table, allocate_type_unit_groups_table,
7281         allocate_dwo_file_hash_table, allocate_dwp_loaded_cutus_table):
7282         Remove objfile parameter, update all callers.
7283
7284 2020-02-19  Doug Evans  <dje@google.com>
7285
7286         PR rust/25535
7287         * rust-lang.c (rust_print_enum): Apply embedded_offset to
7288         rust_enum_variant calculation.
7289
7290 2020-02-19  Tom Tromey  <tromey@adacore.com>
7291
7292         * mips-tdep.h (mips_pc_is_mips): Parameter type is CORE_ADDR.
7293
7294 2020-02-19  Tom Tromey  <tromey@adacore.com>
7295
7296         * ada-lang.c (cache_symbol): Use obstack_strdup.
7297
7298 2020-02-19  Andrew Burgess  <andrew.burgess@embecosm.com>
7299
7300         * configure: Regenerate.
7301
7302 2020-02-19  Tom Tromey  <tromey@adacore.com>
7303
7304         * python/python.c (do_start_initialization): Use XNEWVEC.  Remove
7305         NULL check.
7306
7307 2020-02-19  Maciej W. Rozycki  <macro@wdc.com>
7308
7309         * NEWS: Mention RISC-V GNU/Linux GDBserver support.
7310
7311 2020-02-19  Andrew Burgess  <andrew.burgess@embecosm.com>
7312
7313         * arch/riscv.c (struct riscv_gdbarch_features_hasher): Only define
7314         if GDBSERVER is not defined.
7315         (riscv_tdesc_cache): Likewise, also store const target_desc.
7316         (STATIC_IN_GDB): Define.
7317         (riscv_create_target_description): Update declaration with
7318         STATIC_IN_GDB.
7319         (riscv_lookup_target_description): New function, only define if
7320         GDBSERVER is not defined.
7321         * arch/riscv.h (riscv_create_target_description): Declare only
7322         when GDBSERVER is defined.
7323         (riscv_lookup_target_description): New declaration when GDBSERVER
7324         is not defined.
7325         * nat/riscv-linux-tdesc.c (riscv_linux_read_description): Rename to...
7326         (riscv_linux_read_features): ...this, and return
7327         riscv_gdbarch_features instead of target_desc.
7328         * nat/riscv-linux-tdesc.h: Include 'arch/riscv.h'.
7329         (riscv_linux_read_description): Rename to...
7330         (riscv_linux_read_features): ...this.
7331         * riscv-linux-nat.c (riscv_linux_nat_target::read_description):
7332         Update to use riscv_gdbarch_features and
7333         riscv_lookup_target_description.
7334         * riscv-tdep.c (riscv_find_default_target_description): Use
7335         riscv_lookup_target_description instead of
7336         riscv_create_target_description.
7337
7338 2020-02-18  Simon Marchi  <simon.marchi@efficios.com>
7339
7340         * valprint.c (generic_val_print_enum_1): When printing a flag
7341         enum with value 0 and there is no enumerator with value 0, print
7342         just "0" instead of "(unknown: 0x0)".
7343
7344 2020-02-18  Simon Marchi  <simon.marchi@efficios.com>
7345
7346         * valprint.c (generic_val_print_enum_1): Print unknown part of
7347         flag enum in hex.
7348
7349 2020-02-18  Simon Marchi  <simon.marchi@efficios.com>
7350
7351         * dwarf2/read.c (update_enumeration_type_from_children): Allow
7352         flag enums to contain duplicate enumerators.
7353         * valprint.c (generic_val_print_enum_1): Update comment.
7354
7355 2020-02-18  Simon Marchi  <simon.marchi@efficios.com>
7356
7357         * dwarf2/read.c: Include "count-one-bits.h".
7358         (update_enumeration_type_from_children): If an enumerator has
7359         multiple bits set, don't treat the enumeration as a "flag enum".
7360         * valprint.c (generic_val_print_enum_1): Assert that enumerators
7361         of flag enums have 0 or 1 bit set.
7362
7363 2020-02-18  Bernd Edlinger  <bernd.edlinger@hotmail.de>
7364
7365         * aarch64-tdep.c (aarch64_displaced_step_copy_insn): Use an explicit
7366         conversion.
7367         * amd64-tdep.c (amd64_displaced_step_copy_insn): Likewise.
7368         * arm-linux-tdep.c (arm_linux_displaced_step_copy_insn): Likewise.
7369         * i386-tdep.c (i386_displaced_step_copy_insn): Likewise.
7370         * rs6000-tdep.c (ppc_displaced_step_copy_insn): Likewise.
7371         * s390-tdep.c (s390_displaced_step_copy_insn): Likewise.
7372
7373 2020-02-18  Simon Marchi  <simon.marchi@efficios.com>
7374
7375         * MAINTAINERS: Change palmer@sifive.com to palmer@dabbelt.com.
7376
7377 2020-02-14  Simon Marchi  <simon.marchi@efficios.com>
7378
7379         * aarch64-tdep.c (aarch64_displaced_step_copy_insn): Use
7380         displaced_step_closure_up.
7381         * aarch64-tdep.h (aarch64_displaced_step_copy_insn): Likewise.
7382         (struct displaced_step_closure_up):
7383         * amd64-tdep.c (amd64_displaced_step_copy_insn): Likewise.
7384         * amd64-tdep.h (amd64_displaced_step_copy_insn): Likewise.
7385         * arm-linux-tdep.c (arm_linux_displaced_step_copy_insn):
7386         Likewise.
7387         * gdbarch.sh (displaced_step_copy_insn): Likewise.
7388         * gdbarch.c, gdbarch.h: Re-generate.
7389         * i386-linux-tdep.c (i386_linux_displaced_step_copy_insn): Use
7390         displaced_step_closure_up.
7391         * i386-tdep.c (i386_displaced_step_copy_insn): Likewise.
7392         * i386-tdep.h (i386_displaced_step_copy_insn): Likewise.
7393         * infrun.h (displaced_step_closure_up): New type alias.
7394         (struct displaced_step_inferior_state) <step_closure>: Change
7395         type to displaced_step_closure_up.
7396         * rs6000-tdep.c (ppc_displaced_step_copy_insn): Use
7397         displaced_step_closure_up.
7398         * s390-tdep.c (s390_displaced_step_copy_insn): Likewise.
7399
7400 2020-02-14  Tom Tromey  <tom@tromey.com>
7401
7402         * minidebug.c (gnu_debug_key): New global.
7403         (find_separate_debug_file_in_section): Use it.
7404
7405 2020-02-14  Simon Marchi  <simon.marchi@efficios.com>
7406
7407         * gdbarch.sh (displaced_step_copy_insn): Change return type to an
7408         std::unique_ptr.
7409         * gdbarch.c: Re-generate.
7410         * gdbarch.h: Re-generate.
7411         * infrun.c (displaced_step_prepare_throw): Adjust to std::unique_ptr
7412         change.
7413         * aarch64-tdep.c (aarch64_displaced_step_copy_insn): Change return
7414         type to std::unique_ptr.
7415         * aarch64-tdep.h (aarch64_displaced_step_copy_insn): Likewise.
7416         * amd64-tdep.c (amd64_displaced_step_copy_insn): Likewise.
7417         * amd64-tdep.h (amd64_displaced_step_copy_insn): Likewise.
7418         * arm-linux-tdep.c (arm_linux_displaced_step_copy_insn): Likewise.
7419         * i386-linux-tdep.c (i386_linux_displaced_step_copy_insn): Likewise.
7420         * i386-tdep.c (i386_displaced_step_copy_insn): Likewise.
7421         * i386-tdep.h (i386_displaced_step_copy_insn): Likewise.
7422         * rs6000-tdep.c (ppc_displaced_step_copy_insn): Likewise.
7423         * s390-tdep.c (s390_displaced_step_copy_insn): Likewise.
7424
7425 2020-02-14  Simon Marchi  <simon.marchi@efficios.com>
7426
7427         * infrun.c (get_displaced_step_closure_by_addr): Adjust to
7428         std::unique_ptr.
7429         (displaced_step_clear): Rename to...
7430         (displaced_step_reset): ... this.  Just call displaced->reset ().
7431         (displaced_step_clear_cleanup): Rename to...
7432         (displaced_step_reset_cleanup): ... this.
7433         (displaced_step_prepare_throw): Adjust to std::unique_ptr.
7434         (displaced_step_fixup): Likewise.
7435         (resume_1): Likewise.
7436         (handle_inferior_event): Restore child's memory before calling
7437         displaced_step_fixup on the parent.
7438         * infrun.h (displaced_step_inferior_state) <reset>: Adjust
7439         to std::unique_ptr.
7440         <step_closure>: Change type to std::unique_ptr.
7441
7442 2020-02-14  Simon Marchi  <simon.marchi@efficios.com>
7443
7444         * arm-tdep.c: Include count-one-bits.h.
7445         (cleanup_block_store_pc): Use count_one_bits.
7446         (cleanup_block_load_pc): Use count_one_bits.
7447         (arm_copy_block_xfer): Use count_one_bits.
7448         (thumb2_copy_block_xfer): Use count_one_bits.
7449         (thumb_copy_pop_pc_16bit): Use count_one_bits.
7450         * arch/arm-get-next-pcs.c: Include count-one-bits.h.
7451         (thumb_get_next_pcs_raw): Use count_one_bits.
7452         (arm_get_next_pcs_raw): Use count_one_bits_l.
7453         * arch/arm.c (bitcount): Remove.
7454         * arch/arm.h (bitcount): Remove.
7455
7456 2020-02-14  Tom Tromey  <tromey@adacore.com>
7457
7458         * dwarf2/frame-tailcall.c (dwarf2_tailcall_sniffer_first):
7459         Update.
7460         * dwarf2/loc.h (call_site_find_chain): Return unique_xmalloc_ptr.
7461         * dwarf2/loc.c (call_site_find_chain_1): Return
7462         unique_xmalloc_ptr.
7463         (call_site_find_chain): Likewise.
7464
7465 2020-02-14  Richard Biener  <rguenther@suse.de>
7466
7467         * dwarf2/read.c (lnp_state_machine::handle_special_opcode): Apply CSE
7468         on expression with division operators.
7469
7470 2020-02-13  Alok Kumar Sharma  <AlokKumar.Sharma@amd.com>
7471
7472         * MAINTAINERS (Write After Approval): Adding myself.
7473
7474 2020-02-12  Tom Tromey  <tom@tromey.com>
7475
7476         * event-loop.c (event_data, gdb_event, event_handler_func):
7477         Remove.
7478
7479 2020-02-12  Tom Tromey  <tom@tromey.com>
7480
7481         * dwarf2/frame.c (dwarf2_frame_bfd_data): New global.
7482         (dwarf2_frame_objfile_data): Add comment.
7483         (find_comp_unit, set_comp_unit): New functions.
7484         (dwarf2_frame_find_fde): Use find_comp_unit.
7485         (dwarf2_build_frame_info): Use set_comp_unit.
7486
7487 2020-02-12  Tom Tromey  <tom@tromey.com>
7488
7489         * dwarf2/frame.c (struct comp_unit) <objfile>: Remove.
7490         (comp_unit): Don't initialize objfile.
7491         (execute_cfa_program): Add text_offset parameter.
7492         (execute_cfa_program_test, dwarf2_fetch_cfa_info)
7493         (dwarf2_frame_cache): Update.
7494         (dwarf2_build_frame_info): Don't set "objfile" member.
7495
7496 2020-02-12  Tom Tromey  <tom@tromey.com>
7497
7498         * dwarf2/frame.c (decode_frame_entry_1): Add gdbarch parameter.
7499         (decode_frame_entry): Likewise.
7500         (dwarf2_build_frame_info): Update.
7501
7502 2020-02-12  Tom Tromey  <tom@tromey.com>
7503
7504         * dwarf2/frame.c (struct comp_unit) <obstack>: New member.
7505         (decode_frame_entry_1): Use the comp_unit obstack.
7506
7507 2020-02-12  Tom Tromey  <tom@tromey.com>
7508
7509         * dwarf2/frame.c (struct comp_unit): Add initializers and
7510         constructor.
7511         (dwarf2_frame_objfile_data): Store a comp_unit.
7512         (dwarf2_frame_find_fde): Update.
7513         (dwarf2_build_frame_info): Use "new".
7514
7515 2020-02-12  Tom Tromey  <tom@tromey.com>
7516
7517         * dwarf2/frame.c (struct dwarf2_fde_table): Remove.
7518         (dwarf2_fde_table): Typedef for std::vector.
7519         (dwarf2_frame_objfile_data): Remove the deleter.  Now static.
7520         (dwarf2_frame_find_fde, add_fde, decode_frame_entry_1)
7521         (decode_frame_entry): Update.
7522         (dwarf2_build_frame_info): Use "new".
7523
7524 2020-02-12  Christian Biesinger  <cbiesinger@google.com>
7525
7526         * arm-tdep.c (arm_gdbarch_init): Update.
7527         * arm-tdep.h (struct gdbarch_tdep) <have_fpa_registers,
7528         have_wmmx_registers, have_vfp_pseudos, have_neon_pseudos,
7529         have_neon, is_m>: Change to bool.
7530
7531 2020-02-12  Christian Biesinger  <cbiesinger@google.com>
7532
7533         * arm-tdep.c (arm_dump_tdep): Print more fields of tdep.
7534
7535 2020-02-12  Tom Tromey  <tom@tromey.com>
7536
7537         * dwarf2/loc.c (struct dwarf_expr_baton): Remove.
7538
7539 2020-02-12  Hannes Domani  <ssbssa@yahoo.de>
7540
7541         * windows-tdep.c (struct windows_gdbarch_data): Add tib_ptr_type.
7542         (windows_get_tlb_type): Use windows_gdbarch_data->tib_ptr_type.
7543
7544 2020-02-11  Tom Tromey  <tom@tromey.com>
7545
7546         * psymtab.h: Update comment.
7547
7548 2020-02-11  Tom Tromey  <tom@tromey.com>
7549
7550         * gdb_obstack.h (struct auto_obstack): Use
7551         DISABLE_COPY_AND_ASSIGN.
7552
7553 2020-02-11  Tom Tromey  <tom@tromey.com>
7554
7555         * dwarf2/frame.h (struct objfile): Don't forward declare.
7556
7557 2020-02-11  Christian Biesinger  <cbiesinger@google.com>
7558
7559         * cris-tdep.c (cris_supply_gregset): Change signature to match
7560         what struct regset expects.
7561         (cris_regset): New struct.
7562         (fetch_core_registers): Remove.
7563         (cris_iterate_over_regset_sections): New function.
7564         (_initialize_cris_tdep): Don't call deprecated_add_core_fns.
7565         (cris_gdbarch_init): Call set_gdbarch_iterate_over_regset_sections.
7566
7567 2020-02-11  Christian Biesinger  <cbiesinger@google.com>
7568
7569         * arch/arm.h (enum gdb_regnum): Add comment for the FP0..7
7570         registers.
7571
7572 2020-02-11  Christian Biesinger  <cbiesinger@google.com>
7573
7574         * arm-tdep.c (arm_dump_tdep): Add \n in fprintf.
7575
7576 2020-02-11  Simon Marchi  <simon.marchi@efficios.com>
7577
7578         * configure: Re-generate.
7579
7580 2020-02-11  Simon Marchi  <simon.marchi@efficios.com>
7581
7582         * configure: Re-generate.
7583
7584 2020-02-11  Simon Marchi  <simon.marchi@efficios.com>
7585
7586         * acinclude: Update warning.m4 path.
7587         * warning.m4: Move to gdbsupport.
7588
7589 2020-02-11  Tom Tromey  <tromey@adacore.com>
7590
7591         * remote.c (remote_console_output): Update.
7592         * printcmd.c (printf_command): Update.
7593         * event-loop.c (gdb_wait_for_event): Update.
7594         * linux-nat.c (sigchld_handler): Update.
7595         * remote-sim.c (gdb_os_write_stdout): Update.
7596         (gdb_os_flush_stdout): Update.
7597         (gdb_os_flush_stderr): Update.
7598         (gdb_os_write_stderr): Update.
7599         * exceptions.c (print_exception): Update.
7600         * remote-fileio.c (remote_fileio_func_read): Update.
7601         (remote_fileio_func_write): Update.
7602         * tui/tui.c (tui_enable): Update.
7603         * tui/tui-interp.c (tui_interp::init): Update.
7604         * utils.c (init_page_info): Update.
7605         (putchar_unfiltered, fputc_unfiltered): Update.
7606         (gdb_flush): Update.
7607         (emit_style_escape): Update.
7608         (flush_wrap_buffer, fputs_maybe_filtered): Update.
7609         * ui-file.c (ui_file_isatty, ui_file_read, ui_file_write)
7610         (ui_file_write_async_safe, ui_file_flush, ui_file_puts): Remove.
7611         (stderr_file::write): Update.
7612         (stderr_file::puts): Update.
7613         * ui-file.h (ui_file_isatty, ui_file_write)
7614         (ui_file_write_async_safe, ui_file_read, ui_file_flush)
7615         (ui_file_puts): Don't declare.
7616
7617 2020-02-10  Tom de Vries  <tdevries@suse.de>
7618
7619         * dwarf2/read.c (process_psymtab_comp_unit_reader): Cast concat NULL
7620         sentinel to char *.
7621
7622 2020-02-09  Tom de Vries  <tdevries@suse.de>
7623
7624         * dwarf2read.c (process_psymtab_comp_unit_reader): Append CU offset to
7625         filename if it matches "<artificial>".
7626
7627 2020-02-09  Hannes Domani  <ssbssa@yahoo.de>
7628
7629         * windows-tdep.c (struct enum_value_name): New struct.
7630         (create_enum): New function.
7631         (windows_get_siginfo_type): Create and use enum types.
7632
7633 2020-02-09  Hannes Domani  <ssbssa@yahoo.de>
7634
7635         * NEWS: Mention $_siginfo support for Windows.
7636         * windows-nat.c (handle_exception): Set siginfo_er.
7637         (windows_nat_target::mourn_inferior): Reset siginfo_er.
7638         (windows_xfer_siginfo): New function.
7639         (windows_nat_target::xfer_partial): Call windows_xfer_siginfo.
7640         * windows-tdep.c (struct windows_gdbarch_data): New struct.
7641         (init_windows_gdbarch_data): New function.
7642         (get_windows_gdbarch_data): New function.
7643         (windows_get_siginfo_type): New function.
7644         (windows_init_abi): Register windows_get_siginfo_type.
7645         (_initialize_windows_tdep): Register init_windows_gdbarch_data.
7646
7647 2020-02-08  Tom Tromey  <tom@tromey.com>
7648
7649         * dwarf2/read.c (class cutu_reader) <cutu_reader,
7650         init_tu_and_read_dwo_dies>: Remove "keep" parameter.
7651         <keep>: Declare method.
7652         <m_keep>: Remove member.
7653         <~cutu_reader>: Remove.
7654         (cutu_reader::init_tu_and_read_dwo_dies): Update.
7655         (cutu_reader::cutu_reader): Update.
7656         (cutu_reader::keep): Rename from ~cutu_reader.
7657         (process_psymtab_comp_unit, build_type_psymtabs_1)
7658         (process_skeletonless_type_unit, load_partial_comp_unit)
7659         (load_full_comp_unit, dwarf2_read_addr_index)
7660         (read_signatured_type): Update.
7661
7662 2020-02-08  Tom Tromey  <tom@tromey.com>
7663
7664         * dwarf2/read.c (process_psymtab_comp_unit_reader): Remove
7665         "want_partial_unit" parameter.
7666         (process_psymtab_comp_unit): Change want_partial_unit to bool.
7667         Inline check for DW_TAG_partial_unit.
7668         (dwarf2_build_psymtabs_hard, scan_partial_symbols): Update.
7669
7670 2020-02-08  Tom Tromey  <tom@tromey.com>
7671
7672         * dwarf2/read.c (read_n_bytes, read_direct_string): Move to
7673         read.c.
7674         * dwarf2/leb.h (read_n_bytes, read_direct_string): Move from
7675         read.c.
7676
7677 2020-02-08  Tom Tromey  <tom@tromey.com>
7678
7679         * dwarf2/read.c (read_address): Move to comp-unit.c.
7680         (dwarf2_rnglists_process, dwarf2_ranges_process)
7681         (read_attribute_value, dwarf_decode_lines_1)
7682         (var_decode_location, decode_locdesc): Update.
7683         * dwarf2/comp-unit.c (comp_unit_head::read_address): Move from
7684         read.c.  Remove "cu" parameter.
7685         * dwarf2/comp-unit.h (struct comp_unit_head) <read_address>: New
7686         method.
7687
7688 2020-02-08  Tom Tromey  <tom@tromey.com>
7689
7690         * dwarf2/read.c (read_attribute_value, read_indirect_string)
7691         (read_indirect_line_string): Update.
7692         * dwarf2/comp-unit.c (read_offset): Remove.
7693         (read_comp_unit_head): Update.
7694         * dwarf2/comp-unit.h (struct comp_unit_head) <read_offset>: New
7695         method.
7696         (read_offset): Don't declare.
7697
7698 2020-02-08  Tom Tromey  <tom@tromey.com>
7699
7700         * Makefile.in (COMMON_SFILES): Add dwarf2/comp-unit.c.
7701         * dwarf2/read.c (struct comp_unit_head): Move to
7702         dwarf2/comp-unit.h.
7703         (enum class rcuh_kind): Move to comp-unit.h.
7704         (get_cu_length, offset_in_cu_p): Now methods on comp_unit_head.
7705         (read_comp_unit_head, error_check_comp_unit_head)
7706         (read_and_check_comp_unit_head): Move to comp-unit.c.
7707         (read_offset, dwarf_unit_type_name): Likewise.
7708         (create_debug_type_hash_table, read_cutu_die_from_dwo)
7709         (cutu_reader::cutu_reader, read_call_site_scope)
7710         (find_partial_die, follow_die_offset): Update.
7711         * dwarf2/comp-unit.h: New file, from dwarf2read.c.
7712
7713 2020-02-08  Tom Tromey  <tom@tromey.com>
7714
7715         * dwarf2/read.c (read_offset_1): Move to leb.c.
7716         (read_abbrev_offset, read_offset, dwarf_decode_line_header)
7717         (dwarf_decode_macro_bytes): Update.
7718         * dwarf2/leb.c (read_offset): Rename; move from read.c.
7719         * dwarf2/leb.h (read_offset): Declare.
7720
7721 2020-02-08  Tom Tromey  <tom@tromey.com>
7722
7723         * dwarf2/read.c (dwarf2_section_size): Remove.
7724         (error_check_comp_unit_head, dwarf2_symbol_mark_computed):
7725         Update.
7726         * dwarf2/section.h (struct dwarf2_section_info) <get_size>: New method.
7727
7728 2020-02-08  Tom Tromey  <tom@tromey.com>
7729
7730         * dwarf2/read.c (read_initial_length): Move to leb.c.
7731         * dwarf2/leb.h (read_initial_length): Declare.
7732         * dwarf2/leb.c (read_initial_length): Move from read.c.  Add
7733         handle_nonstd parameter.
7734         * dwarf2/frame.c (read_initial_length): Remove.
7735         (decode_frame_entry_1): Update.
7736
7737 2020-02-08  Tom Tromey  <tom@tromey.com>
7738
7739         * dwarf2/loc.c (dwarf2_find_location_expression)
7740         (dwarf_evaluate_loc_desc::get_tls_address)
7741         (dwarf_evaluate_loc_desc::push_dwarf_reg_entry_value)
7742         (rw_pieced_value, dwarf2_evaluate_loc_desc_full)
7743         (dwarf2_locexpr_baton_eval, dwarf2_evaluate_property)
7744         (dwarf2_compile_property_to_c)
7745         (dwarf2_loc_desc_get_symbol_read_needs)
7746         (dwarf2_compile_expr_to_ax, locexpr_describe_location)
7747         (locexpr_tracepoint_var_ref, locexpr_generate_c_location)
7748         (loclist_describe_location, loclist_tracepoint_var_ref)
7749         (loclist_generate_c_location): Update.
7750         * compile/compile-loc2c.c (do_compile_dwarf_expr_to_c): Update.
7751         * dwarf2/loc.h (dwarf2_per_cu_objfile, dwarf2_per_cu_addr_size)
7752         (dwarf2_per_cu_ref_addr_size, dwarf2_per_cu_offset_size)
7753         (dwarf2_per_cu_text_offset, dwarf2_version): Don't declare.
7754         * dwarf2/read.c (dwarf2_per_cu_data::objfile)
7755         (dwarf2_per_cu_data::addr_size)
7756         (dwarf2_per_cu_data::ref_addr_size)
7757         (dwarf2_per_cu_data::text_offset)
7758         (dwarf2_per_cu_data::addr_type): Now methods.
7759         (per_cu_header_read_in): Make per_cu "const".
7760         (dwarf2_version): Remove.
7761         (dwarf2_per_cu_data::int_type): Now a method.
7762         (dwarf2_per_cu_data::_addr_sized_int_type): Likewise.
7763         (set_die_type, read_array_type, read_subrange_index_type)
7764         (read_tag_string_type, read_subrange_type): Update.
7765         * dwarf2/read.h (struct dwarf2_per_cu_data) <addr_size,
7766         offset_size, ref_addr_size, text_offset, addr_type, version,
7767         objfile, int_type, addr_sized_int_type>: Declare methods.
7768
7769 2020-02-08  Tom Tromey  <tom@tromey.com>
7770
7771         * dwarf2/read.h (struct dwarf2_per_cu_data) <imported_symtabs>:
7772         Move earlier.
7773
7774 2020-02-08  Tom Tromey  <tom@tromey.com>
7775
7776         * dwarf2/read.h (dwarf_line_debug): Declare.
7777         * Makefile.in (COMMON_SFILES): Add dwarf2/line-header.c.
7778         * dwarf2/read.c: Move line_header code to new files.
7779         (dwarf_line_debug): No longer static.
7780         * dwarf2/line-header.c: New file.
7781         * dwarf2/line-header.h: New file.
7782
7783 2020-02-08  Tom Tromey  <tom@tromey.com>
7784
7785         * dwarf2/read.c (struct line_header) <file_full_name,
7786         file_file_name>: Return unique_xmalloc_ptr.
7787         (line_header::file_file_name): Update.
7788         (line_header::file_full_name): Update.
7789         (dw2_get_file_names_reader): Update.
7790         (macro_start_file): Update.
7791
7792 2020-02-08  Tom Tromey  <tom@tromey.com>
7793
7794         * dwarf2/read.c (struct line_header) <file_full_name,
7795         file_file_name>: Declare methods.
7796         (dw2_get_file_names_reader): Update.
7797         (file_file_name): Now a method.
7798         (file_full_name): Likewise.
7799         (macro_start_file): Update.
7800
7801 2020-02-08  Tom Tromey  <tom@tromey.com>
7802
7803         * dwarf2/read.c (dwarf_always_disassemble)
7804         (show_dwarf_always_disassemble): Move to loc.c.
7805         (_initialize_dwarf2_read): Move "always-disassemble" registration
7806         to loc.c.
7807         * dwarf2/read.h (dwarf_always_disassemble): Don't declare.
7808         * dwarf2/loc.c (dwarf_always_disassemble): Move from read.c.  Now
7809         static.
7810         (show_dwarf_always_disassemble): Move from read.c.
7811         (_initialize_dwarf2loc): Move always-disassemble from read.c.
7812
7813 2020-02-08  Tom Tromey  <tom@tromey.com>
7814
7815         * dwarf2/read.c (~dwarf2_per_objfile): Update.
7816         (create_quick_file_names_table): Return htab_up.
7817         (dw2_get_file_names_reader, dw2_forget_cached_source_info):
7818         Update.
7819         * dwarf2/read.h (struct dwarf2_per_objfile)
7820         <quick_file_names_table>: Now htab_up.
7821
7822 2020-02-08  Tom Tromey  <tom@tromey.com>
7823
7824         * dwarf2/abbrev.c (abbrev_table::read): Simplify.
7825
7826 2020-02-08  Tom Tromey  <tom@tromey.com>
7827
7828         * dwarf2/abbrev.c (abbrev_table): Move constructor from header.
7829         Rewrite.
7830         (abbrev_table::add_abbrev, abbrev_table::lookup_abbrev): Rewrite.
7831         * dwarf2/abbrev.h (struct abbrev_info) <next>: Remove.
7832         (abbrev_table::abbrev_table): No longer inline.
7833         (ABBREV_HASH_SIZE): Remove.
7834         (abbrev_table::m_abbrevs): Now an htab_up.
7835
7836 2020-02-08  Tom Tromey  <tom@tromey.com>
7837
7838         * dwarf2/read.c (read_cutu_die_from_dwo): Update.
7839         (cutu_reader): Update.
7840         (build_type_psymtabs_1): Update.
7841         * dwarf2/abbrev.c (abbrev_table::read): Rename.
7842         (abbrev_table::alloc_abbrev): Update.
7843         * dwarf2/abbrev.h (abbrev_table_up): Move earlier.
7844         (abbrev_table::read): New static method, renamed from
7845         abbrev_table_read_table.
7846         (abbrev_table::alloc_abbrev)
7847         (abbrev_table::add_abbrev): Now private.
7848         (abbrev_table::abbrev_table): Now private.
7849         (abbrev_table::m_abbrev_obstack): Now private.  Rename.
7850
7851 2020-02-08  Tom Tromey  <tom@tromey.com>
7852
7853         * dwarf2/read.c (set_die_type, get_die_type_at_offset): Update.
7854         * dwarf2/read.h (struct dwarf2_per_objfile) <die_type_hash>: Now
7855         htab_up.
7856
7857 2020-02-08  Tom Tromey  <tom@tromey.com>
7858
7859         * dwarf2/read.c (struct dwp_file) <loaded_cus, loaded_tus>: Now
7860         htab_up.
7861         (lookup_dwo_unit_in_dwp): Update.
7862         (allocate_dwp_loaded_cutus_table): Return htab_up.  Don't allocate
7863         on obstack.
7864
7865 2020-02-08  Tom Tromey  <tom@tromey.com>
7866
7867         * dwarf2/read.c (allocate_dwo_file_hash_table): Don't allocate on
7868         obstack.
7869
7870 2020-02-08  Tom Tromey  <tom@tromey.com>
7871
7872         * dwarf2/read.c (~dwarf2_per_objfile): Don't delete
7873         line_header_hash.
7874         (handle_DW_AT_stmt_list): Update.  Don't allocate on obstack.
7875         * dwarf2/read.h (struct dwarf2_per_objfile) <line_header_hash>:
7876         Change type to htab_up.
7877
7878 2020-02-08  Tom Tromey  <tom@tromey.com>
7879
7880         * dwarf2/read.c (allocate_type_unit_groups_table): Return
7881         htab_up.  Don't allocate on obstack.
7882         (get_type_unit_group, dwarf2_build_psymtabs_hard): Update.
7883         * dwarf2/read.h (struct dwarf2_per_objfile) <type_unit_groups>:
7884         Change type to htab_up.
7885
7886 2020-02-08  Tom Tromey  <tom@tromey.com>
7887
7888         * dwarf2/read.h (struct dwarf2_per_objfile) <signatured_types>:
7889         Change type to htab_up.
7890         * dwarf2/read.c (create_signatured_type_table_from_index)
7891         (create_signatured_type_table_from_debug_names)
7892         (create_all_type_units, add_type_unit)
7893         (lookup_dwo_signatured_type, lookup_signatured_type)
7894         (process_skeletonless_type_unit): Update.
7895         (create_debug_type_hash_table, create_debug_types_hash_table):
7896         Change type of types_htab.
7897         (allocate_signatured_type_table, allocate_dwo_unit_table): Return
7898         htab_up.  Don't allocate on obstack.
7899         (create_cus_hash_table): Change type of cus_htab parameter.
7900         (struct dwo_file) <cus, tus>: Now htab_up.
7901         (lookup_dwo_signatured_type, lookup_dwo_cutu)
7902         (process_dwo_file_for_skeletonless_type_units, lookup_dwo_cutu)
7903         (queue_and_load_all_dwo_tus): Update.
7904         * dwarf2/index-write.c (write_gdbindex): Update.
7905         (write_debug_names): Update.
7906
7907 2020-02-08  Tom Tromey  <tom@tromey.com>
7908
7909         * dwarf2/read.h (struct dwarf2_queue_item): Move from
7910         dwarf2/read.c.  Remove "next" member.  Add constructor ntad
7911         destructor.
7912         (struct dwarf2_per_objfile) <queue>: New member.
7913         * dwarf2/read.c (struct dwarf2_queue_item): Move to
7914         dwarf2/read.h.
7915         (dwarf2_queue, dwarf2_queue_tail): Remove.
7916         (class dwarf2_queue_guard): Add parameter to constructor.  Use
7917         DISABLE_COPY_AND_ASSIGN.
7918         <m_per_objfile>: New member.
7919         <~dwarf2_queue_guard>: Rewrite.
7920         (dw2_do_instantiate_symtab, queue_comp_unit, process_queue):
7921         Update.
7922         (~dwarf2_queue_item): New.
7923
7924 2020-02-08  Tom Tromey  <tom@tromey.com>
7925
7926         * dwarf2/read.c (struct die_info) <has_children>: New member.
7927         (dw2_get_file_names_reader): Remove has_children.
7928         (dw2_get_file_names): Update.
7929         (read_cutu_die_from_dwo): Remove has_children.
7930         (cutu_reader::init_tu_and_read_dwo_dies)
7931         (cutu_reader::cutu_reader): Update.
7932         (process_psymtab_comp_unit_reader, build_type_psymtabs_reader):
7933         Remove has_children.
7934         (build_type_psymtabs_1, process_skeletonless_type_unit)
7935         (load_partial_comp_unit, load_full_comp_unit): Update.
7936         (create_dwo_cu_reader): Remove has_children.
7937         (create_cus_hash_table, read_die_and_children): Update.
7938         (read_full_die_1,read_full_die): Remove has_children.
7939         (read_signatured_type): Update.
7940         (class cutu_reader) <has_children>: Remove.
7941
7942 2020-02-08  Tom Tromey  <tom@tromey.com>
7943
7944         * dwarf2/expr.c: Rename from dwarf2expr.c.
7945         * dwarf2/expr.h: Rename from dwarf2expr.h.
7946         * dwarf2/frame-tailcall.c: Rename from dwarf2-frame-tailcall.c.
7947         * dwarf2/frame-tailcall.h: Rename from dwarf2-frame-tailcall.h.
7948         * dwarf2/frame.c: Rename from dwarf2-frame.c.
7949         * dwarf2/frame.h: Rename from dwarf2-frame.h.
7950         * dwarf2/index-cache.c: Rename from dwarf-index-cache.c.
7951         * dwarf2/index-cache.h: Rename from dwarf-index-cache.h.
7952         * dwarf2/index-common.c: Rename from dwarf-index-common.c.
7953         * dwarf2/index-common.h: Rename from dwarf-index-common.h.
7954         * dwarf2/index-write.c: Rename from dwarf-index-write.c.
7955         * dwarf2/index-write.h: Rename from dwarf-index-write.h.
7956         * dwarf2/loc.c: Rename from dwarf2loc.c.
7957         * dwarf2/loc.h: Rename from dwarf2loc.h.
7958         * dwarf2/read.c: Rename from dwarf2read.c.
7959         * dwarf2/read.h: Rename from dwarf2read.h.
7960         * dwarf2/abbrev.c, aarch64-tdep.c, alpha-tdep.c,
7961         amd64-darwin-tdep.c, arc-tdep.c, arm-tdep.c, bfin-tdep.c,
7962         compile/compile-c-symbols.c, compile/compile-cplus-symbols.c,
7963         compile/compile-loc2c.c, cris-tdep.c, csky-tdep.c, findvar.c,
7964         gdbtypes.c, guile/scm-type.c, h8300-tdep.c, hppa-bsd-tdep.c,
7965         hppa-linux-tdep.c, i386-darwin-tdep.c, i386-linux-tdep.c,
7966         i386-tdep.c, iq2000-tdep.c, m32c-tdep.c, m68hc11-tdep.c,
7967         m68k-tdep.c, microblaze-tdep.c, mips-tdep.c, mn10300-tdep.c,
7968         msp430-tdep.c, nds32-tdep.c, nios2-tdep.c, or1k-tdep.c,
7969         riscv-tdep.c, rl78-tdep.c, rs6000-tdep.c, rx-tdep.c, s12z-tdep.c,
7970         s390-tdep.c, score-tdep.c, sh-tdep.c, sparc-linux-tdep.c,
7971         sparc-tdep.c, sparc64-linux-tdep.c, sparc64-tdep.c, tic6x-tdep.c,
7972         tilegx-tdep.c, v850-tdep.c, xstormy16-tdep.c, xtensa-tdep.c:
7973         Update.
7974         * Makefile.in (COMMON_SFILES): Update.
7975         (HFILES_NO_SRCDIR): Update.
7976
7977 2020-02-08  Tom Tromey  <tom@tromey.com>
7978
7979         * dwarf2read.c (struct die_reader_specs) <comp_dir>: Remove.
7980         (init_cu_die_reader, read_cutu_die_from_dwo): Update.
7981
7982 2020-02-08  Tom Tromey  <tom@tromey.com>
7983
7984         * dwarf2read.h (struct die_info): Don't declare.
7985
7986 2020-02-08  Tom Tromey  <tom@tromey.com>
7987
7988         * dwarf2read.h (die_info_ptr): Remove typedef.
7989
7990 2020-02-08  Tom Tromey  <tom@tromey.com>
7991
7992         * dwarf2read.c (read_call_site_scope)
7993         (handle_data_member_location, dwarf2_add_member_fn)
7994         (mark_common_block_symbol_computed, read_common_block)
7995         (attr_to_dynamic_prop, partial_die_info::read)
7996         (var_decode_location, dwarf2_fetch_die_loc_sect_off)
7997         (dwarf2_symbol_mark_computed, set_die_type): Update.
7998         * dwarf2/attribute.h (struct attribute) <form_is_block>: Declare
7999         method.
8000         (attr_form_is_block): Don't declare.
8001         * dwarf2/attribute.c (attribute::form_is_block): Now a method.
8002
8003 2020-02-08  Tom Tromey  <tom@tromey.com>
8004
8005         * dwarf2read.c (dwarf2_find_base_address, )
8006         (read_call_site_scope, rust_containing_type)
8007         (dwarf2_get_pc_bounds, dwarf2_record_block_ranges)
8008         (handle_data_member_location, dwarf2_add_member_fn)
8009         (get_alignment, read_structure_type, process_structure_scope)
8010         (mark_common_block_symbol_computed, read_common_block)
8011         (read_tag_string_type, attr_to_dynamic_prop, read_subrange_type)
8012         (partial_die_info::read, read_attribute_value, new_symbol)
8013         (lookup_die_type, dwarf2_get_ref_die_offset)
8014         (dwarf2_get_attr_constant_value, follow_die_ref_or_sig)
8015         (dwarf2_fetch_die_loc_sect_off, get_DW_AT_signature_type)
8016         (dwarf2_symbol_mark_computed): Update.
8017         * dwarf2/attribute.h (struct attribute) <value_as_address,
8018         form_is_section_offset, form_is_constant, form_is_ref>: Declare
8019         methods.
8020         (value_as_address, attr_form_is_section_offset)
8021         (attr_form_is_constant, attr_form_is_ref): Don't declare.
8022         * dwarf2/attribute.c (attribute::value_as_address)
8023         (attribute::form_is_section_offset, attribute::form_is_constant)
8024         (attribute::form_is_ref): Now methods.
8025
8026 2020-02-08  Tom Tromey  <tom@tromey.com>
8027
8028         * dwarf2read.c (struct attribute, DW_STRING)
8029         (DW_STRING_IS_CANONICAL, DW_UNSND, DW_BLOCK, DW_SND, DW_ADDR)
8030         (DW_SIGNATURE, struct dwarf_block, attr_value_as_address)
8031         (attr_form_is_block, attr_form_is_section_offset)
8032         (attr_form_is_constant, attr_form_is_ref): Move.
8033         * dwarf2/attribute.h: New file.
8034         * dwarf2/attribute.c: New file, from dwarf2read.c.
8035         * Makefile.in (COMMON_SFILES): Add dwarf2/attribute.c.
8036
8037 2020-02-08  Tom Tromey  <tom@tromey.com>
8038
8039         * dwarf2read.c (abbrev_table_up, struct abbrev_info)
8040         (struct attr_abbrev, ABBREV_HASH_SIZE, struct abbrev_table):
8041         Move.
8042         (read_cutu_die_from_dwo, build_type_psymtabs_1): Update.
8043         (abbrev_table::alloc_abbrev, abbrev_table::add_abbrev)
8044         (abbrev_table::lookup_abbrev, abbrev_table_read_table): Move to
8045         abbrev.c.
8046         * dwarf2/abbrev.h: New file.
8047         * dwarf2/abbrev.c: New file, from dwarf2read.c.
8048         * Makefile.in (COMMON_SFILES): Add dwarf2/abbrev.c.
8049
8050 2020-02-08  Tom Tromey  <tom@tromey.com>
8051
8052         * dwarf2read.c (dwarf2_section_buffer_overflow_complaint)
8053         (dwarf2_section_size, dwarf2_get_section_info)
8054         (create_signatured_type_table_from_debug_names)
8055         (create_addrmap_from_aranges, read_debug_names_from_section)
8056         (get_gdb_index_contents_from_section, read_comp_unit_head)
8057         (error_check_comp_unit_head, read_abbrev_offset)
8058         (create_debug_type_hash_table, init_cu_die_reader)
8059         (read_cutu_die_from_dwo, dwarf2_build_psymtabs_hard)
8060         (read_comp_units_from_section, create_cus_hash_table)
8061         (create_dwp_hash_table, create_dwo_unit_in_dwp_v1)
8062         (create_dwp_v2_section, dwarf2_rnglists_process)
8063         (dwarf2_ranges_process, read_die_and_siblings, read_full_die)
8064         (abbrev_table_read_table, read_indirect_string_at_offset_from)
8065         (read_indirect_string_from_dwz, read_addr_index_1)
8066         (read_str_index, dwarf_decode_line_header, skip_form_bytes)
8067         (dwarf_decode_macro_bytes, dwarf_decode_macros)
8068         (fill_in_loclist_baton): Update.
8069         * dwarf2/section.h (struct dwarf2_section_info) <get_name,
8070         get_containing_section, get_bfd_owner, get_bfd_section,
8071         get_file_name, get_id, get_flags, empty, read>: Declare methods.
8072         (dwarf2_read_section, get_section_name, get_section_file_name)
8073         (get_containing_section, get_section_bfd_owner)
8074         (get_section_bfd_section, get_section_name, get_section_file_name)
8075         (get_section_id, get_section_flags, dwarf2_section_empty_p): Don't
8076         declare.
8077         * dwarf2/section.c (dwarf2_section_info::get_containing_section)
8078         (dwarf2_section_info::get_bfd_owner)
8079         (dwarf2_section_info::get_bfd_section)
8080         (dwarf2_section_info::get_name)
8081         (dwarf2_section_info::get_file_name, dwarf2_section_info::get_id)
8082         (dwarf2_section_info::get_flags, dwarf2_section_info::empty)
8083         (dwarf2_section_info::read): Now methods.
8084         * dwarf-index-write.c (class debug_names): Update.
8085
8086 2020-02-08  Tom Tromey  <tom@tromey.com>
8087
8088         * dwarf2read.h (struct dwarf2_section_info, dwarf2_read_section):
8089         Move to dwarf2/section.h.
8090         * dwarf2read.c (get_containing_section, get_section_bfd_owner)
8091         (get_section_bfd_section, get_section_name)
8092         (get_section_file_name, get_section_id, get_section_flags)
8093         (dwarf2_section_empty_p, dwarf2_read_section): Moe to
8094         dwarf2/section.c.
8095         * dwarf2/section.h: New file.
8096         * dwarf2/section.c: New file, from dwarf2read.c.
8097         * Makefile.in (COMMON_SFILES): Add dwarf2/section.c.
8098
8099 2020-02-08  Tom Tromey  <tom@tromey.com>
8100
8101         * dwarf2read.h (read_unsigned_leb128): Don't declare.
8102         * dwarf2read.c (read_1_byte, read_1_signed_byte, read_2_bytes)
8103         (read_2_signed_bytes, read_3_bytes, read_4_bytes)
8104         (read_4_signed_bytes, read_8_bytes): Move to dwarf2/leb.h.
8105         (read_unsigned_leb128, read_signed_leb128): Move to dwarf2/leb.c.
8106         * dwarf2/leb.h: New file, from dwarf2read.c.
8107         * dwarf2/leb.c: New file, from dwarf2read.c.
8108         * dwarf2-frame.c (read_1_byte, read_4_bytes, read_8_bytes):
8109         Remove.
8110         * Makefile.in (CONFIG_SRC_SUBDIR): Add dwarf2.
8111         (COMMON_SFILES): Add dwarf2/leb.c.
8112
8113 2020-02-08  Joel Brobecker  <brobecker@adacore.com>
8114
8115         GDB 9.1 released.
8116
8117 2020-02-05  Iain Buclaw  <ibuclaw@gdcproject.org>
8118
8119         PR gdb/25190:
8120         * gdb/remote-sim.c (gdb_os_write_stderr): Update.
8121         * gdb/remote.c (remote_console_output): Update.
8122         * gdb/ui-file.c (fputs_unfiltered): Rename to...
8123         (ui_file_puts): ...this.
8124         * gdb/ui-file.h (ui_file_puts): Add declaration.
8125         * gdb/utils.c (emit_style_escape): Update.
8126         (flush_wrap_buffer): Update.
8127         (fputs_maybe_filtered): Update.
8128         (fputs_unfiltered): Add function.
8129
8130 2020-02-05  Iain Buclaw  <ibuclaw@gdcproject.org>
8131
8132         * gdb/event-loop.c (gdb_wait_for_event): Update.
8133         * gdb/printcmd.c (printf_command): Update.
8134         * gdb/remote-fileio.c (remote_fileio_func_write): Update.
8135         * gdb/remote-sim.c (gdb_os_flush_stdout): Update.
8136         (gdb_os_flush_stderr): Update.
8137         * gdb/remote.c (remote_console_output): Update.
8138         * gdb/ui-file.c (gdb_flush): Rename to...
8139         (ui_file_flush): ...this.
8140         (stderr_file::write): Update.
8141         (stderr_file::puts): Update.
8142         * gdb/ui-file.h (gdb_flush): Rename to...
8143         (ui_file_flush): ...this.
8144         * gdb/utils.c (gdb_flush): Add function.
8145         * gdb/utils.h (gdb_flush): Add declaration.
8146
8147 2020-02-07  Tom Tromey  <tromey@adacore.com>
8148
8149         PR breakpoints/24915:
8150         * source.c (find_and_open_source): Do not check basenames_may_differ.
8151
8152 2020-02-07  Tom Tromey  <tom@tromey.com>
8153
8154         * README: Update gdbserver documentation.
8155         * gdbserver: Move to top level.
8156         * configure.tgt (build_gdbserver): Remove.
8157         * configure.ac: Remove --enable-gdbserver.
8158         * configure: Rebuild.
8159         * Makefile.in (distclean): Don't mention gdbserver.
8160
8161 2020-02-06  Shahab Vahedi  <shahab@synopsys.com>
8162
8163         * source-cache.c (source_cache::ensure): Surround
8164         get_plain_source_lines with a try/catch.
8165         (source_cache::get_line_charpos): Get rid of try/catch
8166         and only check for the return value of "ensure".
8167         * tui/tui-source.c (tui_source_window::set_contents):
8168         Simplify "nlines" calculation.
8169
8170 2020-02-06  Shahab Vahedi  <shahab@synopsys.com>
8171
8172         * MAINTAINERS (Write After Approval): Add myself.
8173
8174 2020-02-05  Christian Biesinger  <cbiesinger@google.com>
8175
8176         * sparc-nat.h (struct sparc_target) <xfer_partial>: Fix base class
8177         function call.
8178
8179 2020-02-05  Christian Biesinger  <cbiesinger@google.com>
8180
8181         * ppc-nbsd-tdep.h: Fix macro name in #endif comment.
8182
8183 2020-02-05  Maciej W. Rozycki  <macro@wdc.com>
8184
8185         * nat/riscv-linux-tdesc.h: New file.
8186         * nat/riscv-linux-tdesc.c: New file, taking code from...
8187         * riscv-linux-nat.c (riscv_linux_nat_target::read_description):
8188         ... here.
8189         * configure.nat <linux> <riscv*>: Add nat/riscv-linux-tdesc.o to
8190         NATDEPFILES.
8191
8192 2020-02-04  Andrew Burgess  <andrew.burgess@embecosm.com>
8193
8194         * remote-sim.c (sim_inferior_data::sim_inferior_data): Assert that
8195         we don't set the fake simulator ptid to the null_ptid.
8196
8197 2020-02-03  Simon Marchi  <simon.marchi@efficios.com>
8198
8199         * fork-child.c (gdb_startup_inferior): Use bool instead of int.
8200         * gdbthread.h (class thread_info) <resumed>: Likewise.
8201         * infrun.c (resume_1): Likewise.
8202         (proceed): Likewise.
8203         (infrun_thread_stop_requested): Likewise.
8204         (stop_all_threads): Likewise.
8205         (handle_inferior_event): Likewise.
8206         (restart_threads): Likewise.
8207         (finish_step_over): Likewise.
8208         (keep_going_stepped_thread): Likewise.
8209         * linux-nat.c (attach_proc_task_lwp_callback): Likewise.
8210         (linux_handle_extended_wait): Likewise.
8211         * record-btrace.c (get_thread_current_frame_id): Likewise.
8212         * record-full.c (record_full_wait_1): Likewise.
8213         * remote.c (remote_target::process_initial_stop_replies): Likewise.
8214         * target.c (target_resume): Likewise.
8215         * thread.c (set_running_thread): Likewise.
8216
8217 2020-02-03  Alok Kumar Sharma  <AlokKumar.Sharma@amd.com>
8218
8219         * f-valprint.c (f77_print_array_1): Changed datatype of index
8220         variable to LONGEST from int to enable it to contain bound
8221         values correctly.
8222
8223 2020-02-03  Maciej W. Rozycki  <macro@wdc.com>
8224
8225         * riscv-linux-nat.c [!NFPREG] (NFPREG): New macro.
8226         (supply_fpregset_regnum, fill_fpregset): Handle regset buffer
8227         offsets according to FLEN determined.
8228         (riscv_linux_nat_target::read_description): Determine FLEN
8229         dynamically.
8230         (riscv_linux_nat_target::fetch_registers): Size regset buffer
8231         according to FLEN determined.
8232         (riscv_linux_nat_target::store_registers): Likewise.
8233
8234 2020-02-01  Shahab Vahedi  <shahab@synopsys.com>
8235
8236         * target-descriptions.c (tdesc_register_in_reggroup_p): Return 0
8237         when reg->group is empty and reggroup is not.
8238
8239 2020-01-31  Tom Tromey  <tromey@adacore.com>
8240
8241         * ravenscar-thread.c (ravenscar_thread_target::mourn_inferior):
8242         Call beneath target's mourn_inferior after unpushing.
8243
8244 2020-01-31  Andrew Burgess  <andrew.burgess@embecosm.com>
8245
8246         PR tui/9765
8247         * tui/tui-disasm.c (tui_find_disassembly_address): If we don't
8248         have enough lines to fill the screen, still return the lowest
8249         address we found.
8250
8251 2020-01-31  Andrew Burgess  <andrew.burgess@embecosm.com>
8252
8253         * tui/tui-win.c (_initialize_tui_win): Update help text for '+',
8254         '-', '<', and '>' commands.
8255
8256 2020-01-29  Pedro Alves  <palves@redhat.com>
8257             Sergio Durigan Junior  <sergiodj@redhat.com>
8258
8259         * infcmd.c (construct_inferior_arguments): Assert that
8260         'argc' is greater than 0.
8261
8262 2020-01-29  Luis Machado  <luis.machado@linaro.org>
8263
8264         * aarch64-tdep.c (BRK_INSN_MASK): Define to 0xffe0001f.
8265         (BRK_INSN_MASK): Define to 0xd4200000.
8266         (aarch64_program_breakpoint_here_p): New function.
8267         (aarch64_gdbarch_init): Set gdbarch_program_breakpoint_here_p hook.
8268         * arch-utils.c (default_program_breakpoint_here_p): Moved from
8269         breakpoint.c.
8270         * arch-utils.h (default_program_breakpoint_here_p): Moved from
8271         breakpoint.h
8272         * breakpoint.c (bp_loc_is_permanent): Changed return type to bool and
8273         call gdbarch_program_breakpoint_here_p.
8274         (program_breakpoint_here): Moved to arch-utils.c, renamed to
8275         default_program_breakpoint_here_p, changed return type to bool and
8276         simplified.
8277         * breakpoint.h (program_breakpoint_here): Moved prototype to
8278         arch-utils.h, renamed to default_program_breakpoint_here_p and changed
8279         return type to bool.
8280         * gdbarch.c: Regenerate.
8281         * gdbarch.h: Regenerate.
8282         * gdbarch.sh (program_breakpoint_here_p): New method.
8283         * infrun.c (handle_signal_stop): Call
8284         gdbarch_program_breakpoint_here_p.
8285
8286 2020-01-26  Tom Tromey  <tom@tromey.com>
8287
8288         * ctfread.c (struct ctf_fp_info): Reindent.
8289         (_initialize_ctfread): Remove.
8290
8291 2020-01-26  Tom Tromey  <tom@tromey.com>
8292
8293         * psymtab.c (partial_map_expand_apply)
8294         (psym_find_pc_sect_compunit_symtab, psym_lookup_symbol)
8295         (psymtab_to_symtab, psym_find_last_source_symtab, dump_psymtab)
8296         (psym_print_stats, psym_expand_symtabs_for_function)
8297         (psym_map_symbol_filenames, psym_map_matching_symbols)
8298         (psym_expand_symtabs_matching)
8299         (partial_symtab::read_dependencies, maintenance_info_psymtabs)
8300         (maintenance_check_psymtabs): Use new methods.
8301         * psympriv.h (struct partial_symtab) <readin_p,
8302         get_compunit_symtab>: New methods.
8303         <readin, compunit_symtab>: Remove members.
8304         (struct standard_psymtab): New.
8305         (struct legacy_psymtab): Derive from standard_psymtab.
8306         * dwarf2read.h (struct dwarf2_psymtab): Derive from
8307         standard_psymtab.
8308         * ctfread.c (struct ctf_psymtab): Derive from standard_psymtab.
8309
8310 2020-01-26  Tom Tromey  <tom@tromey.com>
8311
8312         * xcoffread.c (xcoff_psymtab_to_symtab_1): Call
8313         read_dependencies.  Add assert.
8314         * psymtab.c (partial_symtab::read_dependencies): New method.
8315         * psympriv.h (struct partial_symtab) <read_dependencies>: New
8316         method.
8317         * mdebugread.c (psymtab_to_symtab_1): Call read_dependencies.
8318         * dwarf2read.c (dwarf2_psymtab::expand_psymtab): Call
8319         read_dependencies.
8320         * dbxread.c (dbx_psymtab_to_symtab_1): Call read_dependencies.
8321         Add assert.
8322
8323 2020-01-26  Tom Tromey  <tom@tromey.com>
8324
8325         * xcoffread.c (xcoff_psymtab_to_symtab_1): Change argument order.
8326         Call expand_psymtab.
8327         (xcoff_read_symtab): Call expand_psymtab.
8328         (xcoff_start_psymtab, xcoff_end_psymtab): Set
8329         legacy_expand_psymtab.
8330         * psympriv.h (struct partial_symtab) <expand_psymtab>: New
8331         method.
8332         (struct legacy_psymtab) <expand_psymtab>: Implement.
8333         <legacy_expand_psymtab>: New member.
8334         * mdebugread.c (mdebug_read_symtab): Call expand_psymtab.
8335         (parse_partial_symbols): Set legacy_expand_psymtab.
8336         (psymtab_to_symtab_1): Change argument order.  Call
8337         expand_psymtab.
8338         (new_psymtab): Set legacy_expand_psymtab.
8339         * dwarf2read.h (struct dwarf2_psymtab) <expand_psymtab>: Declare.
8340         * dwarf2read.c (dwarf2_psymtab::read_symtab): Call
8341         expand_psymtab.
8342         (dwarf2_psymtab::expand_psymtab): Rename from
8343         psymtab_to_symtab_1.  Call expand_psymtab.
8344         * dbxread.c (start_psymtab): Set legacy_expand_psymtab.
8345         (dbx_end_psymtab): Likewise.
8346         (dbx_psymtab_to_symtab_1): Change argument order. Call
8347         expand_psymtab.
8348         (dbx_read_symtab): Call expand_psymtab.
8349         * ctfread.c (struct ctf_psymtab) <expand_psymtab>: Declare.
8350         (ctf_psymtab::expand_psymtab): Rename from psymtab_to_symtab.
8351         (ctf_psymtab::read_symtab): Call expand_psymtab.
8352
8353 2020-01-26  Tom Tromey  <tom@tromey.com>
8354
8355         * xcoffread.c (xcoff_read_symtab): Remove prints.  Add assert.
8356         * psymtab.c (psymtab_to_symtab): Print verbose "Reading"
8357         messages.
8358         * mdebugread.c (mdebug_read_symtab): Remove prints.
8359         * dwarf2read.c (dwarf2_psymtab::read_symtab): Remove prints.  Add
8360         assert.
8361         * dbxread.c (dbx_read_symtab): Remove prints.  Add assert.
8362
8363 2020-01-26  Tom Tromey  <tom@tromey.com>
8364
8365         * xcoffread.c (this_symtab_psymtab, read_xcoff_symtab)
8366         (xcoff_psymtab_to_symtab_1, xcoff_read_symtab)
8367         (xcoff_start_psymtab, xcoff_end_psymtab, scan_xcoff_symtab): Use
8368         legacy_symtab.
8369         * stabsread.h (dbx_end_psymtab): Use legacy_symtab.
8370         * psymtab.c (psymtab_to_symtab): Call method.
8371         (dump_psymtab): Update.
8372         * psympriv.h (struct partial_symtab): Add virtual destructor.
8373         <read_symtab>: New method.
8374         (struct legacy_symtab): New.
8375         * mdebugread.c (mdebug_read_symtab): Use legacy_psymtab.
8376         (struct pst_map) <pst>: Now a legacy_psymtab.
8377         (parse_procedure, parse_partial_symbols, psymtab_to_symtab_1)
8378         (new_psymtab): Use legacy_psymtab.
8379         * dwarf2read.h (struct dwarf2_psymtab): New.
8380         (struct dwarf2_per_cu_data) <psymtab>: Use it.
8381         * dwarf2read.c (dwarf2_create_include_psymtab)
8382         (dwarf2_build_include_psymtabs, create_type_unit_group)
8383         (create_partial_symtab, process_psymtab_comp_unit_reader)
8384         (build_type_psymtabs_reader, build_type_psymtab_dependencies)
8385         (set_partial_user): Use dwarf2_psymtab.
8386         (dwarf2_psymtab::read_symtab): Rename from dwarf2_read_symtab.
8387         (psymtab_to_symtab_1, process_full_comp_unit)
8388         (process_full_type_unit, dwarf2_ranges_read)
8389         (dwarf2_get_pc_bounds, psymtab_include_file_name)
8390         (dwarf_decode_lines): Use dwarf2_psymtab.
8391         * dwarf-index-write.c (psym_index_map): Use dwarf2_psymtab.
8392         (add_address_entry_worker, write_one_signatured_type)
8393         (recursively_count_psymbols, recursively_write_psymbols)
8394         (write_one_signatured_type, psyms_seen_size, write_gdbindex)
8395         (write_debug_names): Likewise.
8396         * dbxread.c (struct header_file_location): Take a legacy_psymtab.
8397         <pst>: Now a legacy_psymtab.
8398         (find_corresponding_bincl_psymtab): Return a legacy_psymtab.
8399         (read_dbx_symtab, start_psymtab, dbx_end_psymtab)
8400         (dbx_psymtab_to_symtab_1, read_ofile_symtab): Use legacy_psymtab.
8401         * ctfread.c (struct ctf_psymtab): New.
8402         (ctf_start_symtab, ctf_end_symtab, psymtab_to_symtab): Take a
8403         ctf_psymtab.
8404         (ctf_psymtab::read_symtab): Rename from ctf_read_symtab.
8405         (create_partial_symtab): Return a ctf_psymtab.
8406         (scan_partial_symbols): Update.
8407
8408 2020-01-26  Tom Tromey  <tom@tromey.com>
8409
8410         * xcoffread.c (xcoff_start_psymtab): Use new.
8411         * psymtab.c (partial_symtab::partial_symtab): New constructor,
8412         renamed from start_psymtab_common.
8413         * psympriv.h (struct partial_symtab): Add new constructor.
8414         (start_psymtab_common): Don't declare.
8415         * mdebugread.c (parse_partial_symbols): Use new.
8416         * dwarf2read.c (create_partial_symtab): Use new.
8417         * dbxread.c (start_psymtab): Use new.
8418         * ctfread.c (create_partial_symtab): Use new.
8419
8420 2020-01-26  Tom Tromey  <tom@tromey.com>
8421
8422         * xcoffread.c (xcoff_end_psymtab): Use new.
8423         * psymtab.c (start_psymtab_common): Use new.
8424         (partial_symtab::partial_symtab): Rename from allocate_psymtab.
8425         Update.
8426         * psympriv.h (struct partial_symtab): Add parameters to
8427         constructor.  Don't inline.
8428         (allocate_psymtab): Don't declare.
8429         * mdebugread.c (new_psymtab): Use new.
8430         * dwarf2read.c (dwarf2_create_include_psymtab): Use new.
8431         * dbxread.c (dbx_end_psymtab): Use new.
8432
8433 2020-01-26  Tom Tromey  <tom@tromey.com>
8434
8435         * psymtab.h (class psymtab_storage) <install_psymtab>: Rename from
8436         allocate_psymtab.  Update documentation.
8437         * psymtab.c (psymtab_storage::install_psymtab): Rename from
8438         allocate_psymtab.  Do not use new.
8439         (allocate_psymtab): Use new.  Update.
8440
8441 2020-01-26  Tom Tromey  <tom@tromey.com>
8442
8443         * xcoffread.c (xcoff_psymtab_to_symtab_1): Update.
8444         * psymtab.c (psym_print_stats): Update.
8445         * psympriv.h (struct partial_symtab) <readin,
8446         psymtabs_addrmap_supported, anonymous>: Now bool.
8447         * mdebugread.c (psymtab_to_symtab_1): Update.
8448         * dwarf2read.c (create_type_unit_group, create_partial_symtab)
8449         (build_type_psymtabs_reader, psymtab_to_symtab_1)
8450         (process_full_comp_unit, process_full_type_unit): Update.
8451         * dbxread.c (dbx_psymtab_to_symtab_1): Update.
8452         * ctfread.c (psymtab_to_symtab): Update.
8453
8454 2020-01-26  Tom Tromey  <tom@tromey.com>
8455
8456         * mdebugread.c (parse_partial_symbols): Use discard_psymtab.
8457         * psymtab.h (class psymtab_storage) <free_psymtabs>: Remove.
8458         * psymtab.c (psymtab_storage): Delete psymtabs.
8459         (psymtab_storage::allocate_psymtab): Use new.
8460         (psymtab_storage::discard_psymtab): Use delete.
8461         * psympriv.h (struct partial_symtab): Add constructor and
8462         initializers.
8463
8464 2020-01-26  Tom Tromey  <tom@tromey.com>
8465
8466         * machoread.c: Do not include psympriv.h.
8467
8468 2020-01-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8469
8470         * NEWS: Mention the new option and the set/show commands.
8471
8472 2020-01-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8473
8474         * exec.c (exec_file_mismatch_names, exec_file_mismatch_mode)
8475         (show_exec_file_mismatch_command, set_exec_file_mismatch_command)
8476         (validate_exec_file): New variables, enums, functions.
8477         (exec_file_locate_attach, print_section_info): Style the filenames.
8478         (_initialize_exec): Install show_exec_file_mismatch_command and
8479          set_exec_file_mismatch_command.
8480         * gdbcore.h (validate_exec_file): Declare.
8481         * infcmd.c (attach_command): Call validate_exec_file.
8482         * remote.c ( remote_target::remote_add_inferior): Likewise.
8483
8484 2020-01-24  Andrew Burgess  <andrew.burgess@embecosm.com>
8485
8486         * frame.c (find_frame_sal): Move call to get_next_frame into more
8487         inner scope.
8488         * inline-frame.c (inilne_state) <inline_state>: Update argument
8489         types.
8490         (inilne_state) <skipped_symbol>: Rename to...
8491         (inilne_state) <skipped_symbols>: ...this, and change to a vector.
8492         (skip_inline_frames): Build vector of skipped symbols and use this
8493         to reate the inline_state.
8494         (inline_skipped_symbol): Add a comment and some assertions, fetch
8495         skipped symbol from the list.
8496
8497 2020-01-24  Andrew Burgess  <andrew.burgess@embecosm.com>
8498
8499         * buildsym.c (lte_is_less_than): Delete.
8500         (buildsym_compunit::end_symtab_with_blockvector): Create local
8501         lambda function to sort line table entries, and use
8502         std::stable_sort instead of std::sort.
8503         * symtab.c (find_pc_sect_line): Skip backward over end of sequence
8504         markers when looking for a previous line.
8505
8506 2020-01-24  Andrew Burgess  <andrew.burgess@embecosm.com>
8507
8508         * dwarf2read.c (lnp_state_machine::record_line): Include
8509         end_sequence parameter in debug print out.  Record the line if we
8510         are at an end_sequence marker even if it's not the start of a
8511         statement.
8512         * symmisc.c (maintenance_print_one_line_table): Print end of
8513         sequence markers with 'END' not '0'.
8514
8515 2020-01-24  Pedro Alves  <palves@redhat.com>
8516
8517         PR gdb/25410
8518         * thread.c (scoped_restore_current_thread::restore): Use
8519         switch_to_inferior_no_thread.
8520         * exec.c: Include "progspace-and-thread.h".
8521         (add_target_sections, remove_target_sections):
8522         scoped_restore_current_pspace_and_thread instead of
8523         scoped_restore_current_thread.
8524         * infrun.c (handle_vfork_child_exec_or_exit): Assign the pspace
8525         and aspace to the inferior before calling clone_program_space.
8526         Remove stale comment.
8527
8528 2020-01-24  Christian Biesinger  <cbiesinger@google.com>
8529
8530         * arm-nbsd-nat.c (arm_nbsd_nat_target::fetch_registers): Rename to...
8531         (arm_netbsd_nat_target::fetch_registers): ...this.
8532         (arm_nbsd_nat_target::store_registers): Rename to...
8533         (arm_netbsd_nat_target::store_registers): ...this.
8534
8535 2020-01-24  Christian Biesinger  <cbiesinger@google.com>
8536
8537         * arm-nbsd-nat.c: Define _KERNTYPES to get the declaration of
8538         register_t.
8539
8540 2020-01-24  Christian Biesinger  <cbiesinger@google.com>
8541
8542         * aarch64-fbsd-tdep.c (aarch64_fbsd_iterate_over_regset_sections):
8543         Update comment.
8544         * aarch64-linux-tdep.c (aarch64_linux_iterate_over_regset_sections):
8545         Likewise.
8546         * arm-fbsd-tdep.c (arm_fbsd_iterate_over_regset_sections): Likewise.
8547         * gdbcore.h (deprecated_add_core_fns): Update comment to point to
8548         the correct replacement (iterate_over_regset_sections).
8549         * riscv-fbsd-tdep.c (riscv_fbsd_iterate_over_regset_sections):
8550         Update comment.
8551
8552 2020-01-24  Graham Markall  <graham.markall@embecosm.com>
8553
8554         PR gdb/23718
8555         * gdb/python/python.c (execute_gdb_command): Call
8556         async_enable_stdin in catch block.
8557
8558 2020-01-24  Andrew Burgess  <andrew.burgess@embecosm.com>
8559
8560         * event-loop.c (start_event_loop): Wrap async_enable_stdin with
8561         SWITCH_THRU_ALL_UIS.
8562
8563 2020-01-24  Andrew Burgess  <andrew.burgess@embecosm.com>
8564
8565         PR tui/9765
8566         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update header
8567         comment, add extra parameter, and update to store previous symbol
8568         when appropriate.
8569         * minsyms.h (lookup_minimal_symbol_by_pc_section): Update comment,
8570         add extra parameter.
8571         * tui/tui-disasm.c (tui_disassemble): Update header comment,
8572         remove unneeded parameter, add try/catch around gdb_print_insn,
8573         rewrite to add items to asm_lines vector.
8574         (tui_find_backward_disassembly_start_address): New function.
8575         (tui_find_disassembly_address): Updated throughout.
8576         (tui_disasm_window::set_contents): Update for changes to
8577         tui_disassemble.
8578         (tui_disasm_window::do_scroll_vertical): No need to adjust the
8579         number of lines to scroll.
8580
8581 2020-01-23  Simon Marchi  <simon.marchi@polymtl.ca>
8582
8583         * objfiles.h (ALL_OBJFILE_OSECTIONS): Move up.
8584         (SECT_OFF_DATA): Likewise.
8585         (SECT_OFF_RODATA): Likewise.
8586         (SECT_OFF_TEXT): Likewise.
8587         (SECT_OFF_BSS): Likewise.
8588         (struct objfile) <text_section_offset, data_section_offset>: New
8589         methods.
8590         * amd64-windows-tdep.c (amd64_windows_find_unwind_info): Use
8591         objfile::text_section_offset.
8592         * coff-pe-read.c (add_pe_forwarded_sym): Likewise.
8593         * coffread.c (coff_symtab_read): Likewise.
8594         (enter_linenos): Likewise.
8595         (process_coff_symbol): Likewise.
8596         * ctfread.c (get_objfile_text_range): Likewise.
8597         * dtrace-probe.c (dtrace_probe::get_relocated_address):
8598         Use objfile::data_section_offset.
8599         * dwarf2-frame.c (execute_cfa_program): Use
8600         objfile::text_section_offset.
8601         (dwarf2_frame_find_fde): Likewise.
8602         * dwarf2read.c (create_addrmap_from_index): Likewise.
8603         (create_addrmap_from_aranges): Likewise.
8604         (dw2_find_pc_sect_compunit_symtab): Likewise.
8605         (process_psymtab_comp_unit_reader): Likewise.
8606         (add_partial_symbol): Likewise.
8607         (add_partial_subprogram): Likewise.
8608         (process_full_comp_unit): Likewise.
8609         (read_file_scope): Likewise.
8610         (read_func_scope): Likewise.
8611         (read_lexical_block_scope): Likewise.
8612         (read_call_site_scope): Likewise.
8613         (dwarf2_rnglists_process): Likewise.
8614         (dwarf2_ranges_process): Likewise.
8615         (dwarf2_ranges_read): Likewise.
8616         (dwarf_decode_lines_1): Likewise.
8617         (new_symbol): Likewise.
8618         (dwarf2_fetch_die_loc_sect_off): Likewise.
8619         (dwarf2_per_cu_text_offset): Likewise.
8620         * hppa-bsd-tdep.c (hppabsd_find_global_pointer): Likewise.
8621         * hppa-tdep.c (read_unwind_info): Likewise.
8622         * ia64-tdep.c (ia64_find_unwind_table): Likewise.
8623         * psympriv.h (struct partial_symtab): Likewise.
8624         * psymtab.c (find_pc_sect_psymtab): Likewise.
8625         * solib-svr4.c (enable_break): Likewise.
8626         * stap-probe.c (relocate_address): Use
8627         objfile::data_section_offset.
8628         * xcoffread.c (enter_line_range): Use
8629         objfile::text_section_offset.
8630         (read_xcoff_symtab): Likewise.
8631
8632 2020-01-23  Simon Marchi  <simon.marchi@efficios.com>
8633
8634         * darwin-nat.c (darwin_nat_target::wait_1): Move `inf`
8635         declaration to narrower scopes.
8636
8637 2020-01-23  Simon Marchi  <simon.marchi@efficios.com>
8638
8639         * darwin-nat.h (struct darwin_exception_msg, enum
8640         darwin_msg_state, struct darwin_thread_info, darwin_thread_t):
8641         Move up.
8642         (class darwin_nat_target) <wait_1, check_new_threads,
8643         decode_exception_message, decode_message, stop_inferior,
8644         init_thread_list, ptrace_him, cancel_breakpoint>: Declare.
8645         * darwin-nat.c (darwin_check_new_threads): Rename to...
8646         (darwin_nat_target::check_new_threads): ... this.
8647         (darwin_suspend_inferior_it): Remove.
8648         (darwin_decode_exception_message): Rename to...
8649         (darwin_nat_target::decode_exception_message): ... this.
8650         (darwin_nat_target::resume): Pass target to find_inferior_ptid.
8651         (darwin_decode_message): Rename to...
8652         (darwin_nat_target::decode_message): ... this.
8653         (cancel_breakpoint): Rename to...
8654         (darwin_nat_target::cancel_breakpoint): ... this.
8655         (darwin_wait): Rename to...
8656         (darwin_nat_target::wait_1): ... this.  Use range-based for loop
8657         instead of iterate_over_inferiors.
8658         (darwin_nat_target::wait): Call wait_1 instead of darwin_wait.
8659         (darwin_stop_inferior): Rename to...
8660         (darwin_nat_target::stop_inferior): ... this.
8661         (darwin_nat_target::kill): Call wait_1 instead of darwin_wait.
8662         (darwin_init_thread_list): Rename to...
8663         (darwin_nat_target::init_thread_list): ... this.
8664         (darwin_ptrace_him): Rename to...
8665         (darwin_nat_target::ptrace_him): ... this.
8666         (darwin_nat_target::create_inferior): Pass lambda function to
8667         fork_inferior.
8668         (darwin_nat_target::detach): Call stop_inferior instead of
8669         darwin_stop_inferior.
8670         * fork-inferior.h (fork_inferior): Change init_trace_fun
8671         parameter to gdb::function_view.
8672         * fork-inferior.c (fork_inferior): Likewise.
8673
8674 2020-01-23  Hannes Domani  <ssbssa@yahoo.de>
8675
8676         * i386-cygwin-tdep.c (core_process_module_section): Update.
8677         * windows-nat.c (struct lm_info_windows): Add text_offset.
8678         (windows_xfer_shared_libraries): Update.
8679         * windows-tdep.c (windows_xfer_shared_library):
8680         Add text_offset_cached argument.
8681         * windows-tdep.h (windows_xfer_shared_library): Update.
8682
8683 2020-01-21  Simon Marchi  <simon.marchi@efficios.com>
8684
8685         * gdbarch.sh: Add declaration for _initialize_gdbarch.
8686
8687 2020-01-21  Simon Marchi  <simon.marchi@efficios.com>
8688
8689         * remote-sim.c (check_for_duplicate_sim_descriptor): Remove.
8690         (get_sim_inferior_data): Remove use of iterate_over_inferiors,
8691         replace with range-based for.
8692         (gdbsim_interrupt_inferior): Remove.
8693         (gdbsim_target::interrupt): Replace iterate_over_inferiors use
8694         with a range-based for.  Inline code from
8695         gdbsim_interrupt_inferior.
8696
8697 2020-01-21  Simon Marchi  <simon.marchi@efficios.com>
8698
8699         * infrun.c (proceed): Fix indentation.
8700
8701 2020-01-21  Tom Tromey  <tromey@adacore.com>
8702
8703         * source-cache.c (source_cache::ensure): Call ext_lang_colorize.
8704         * python/python.c (python_extension_ops): Update.
8705         (gdbpy_colorize): New function.
8706         * python/lib/gdb/__init__.py (colorize): New function.
8707         * extension.h (ext_lang_colorize): Declare.
8708         * extension.c (ext_lang_colorize): New function.
8709         * extension-priv.h (struct extension_language_ops) <colorize>: New
8710         member.
8711         * cli/cli-style.c (_initialize_cli_style): Update help text.
8712
8713 2020-01-21  Luis Machado  <luis.machado@linaro.org>
8714
8715         * aarch64-tdep.c (struct aarch64_displaced_step_closure)
8716         <cond>: Change type to bool.
8717         (aarch64_displaced_step_b_cond): Update cond to use bool type.
8718         (aarch64_displaced_step_cb): Likewise.
8719         (aarch64_displaced_step_tb): Likewise.
8720
8721 2020-01-21  Luis Machado  <luis.machado@linaro.org>
8722
8723         * aarch64-tdep.c (aarch64_displaced_step_fixup): Add more debugging
8724         output.
8725
8726 2020-01-21  Luis Machado  <luis.machado@linaro.org>
8727
8728         * aarch64-tdep.c (struct aarch64_displaced_step_closure )
8729         <pc_adjust>: Adjust the documentation.
8730         (aarch64_displaced_step_fixup): Check if PC really moved before
8731         adjusting it.
8732
8733 2020-01-19  Tom Tromey  <tom@tromey.com>
8734
8735         * disasm.c (~gdb_disassembler): New destructor.
8736         (gdb_buffered_insn_length): Call disassemble_free_target.
8737         * disasm.h (class gdb_disassembler): Declare destructor.  Use
8738         DISABLE_COPY_AND_ASSIGN.
8739
8740 2020-01-19  Tom Tromey  <tom@tromey.com>
8741
8742         * dwarf2read.c (abbrev_table_up): Move typedef earlier.
8743         (die_reader_func_ftype): Remove.
8744         (cutu_reader): New class.
8745         (dw2_get_file_names_reader): Remove "data" parameter.
8746         (dw2_get_file_names): Use cutu_reader.
8747         (create_debug_type_hash_table): Update.
8748         (read_cutu_die_from_dwo): Update comment.
8749         (lookup_dwo_unit): Add dwo_name parameter.
8750         (cutu_reader::init_tu_and_read_dwo_dies): Now a method.  Remove
8751         die_reader_func_ftype and data parameters.
8752         (cutu_reader::cutu_reader): Rename from init_cutu_and_read_dies.
8753         Remove die_reader_func_ftype and data parameters.
8754         (~cutu_reader): New; from init_cutu_and_read_dies.
8755         (cutu_reader::cutu_reader): Rename from
8756         init_cutu_and_read_dies_no_follow.  Remove die_reader_func_ftype
8757         and data parameters.
8758         (init_cutu_and_read_dies_simple): Remove.
8759         (struct process_psymtab_comp_unit_data): Remove.
8760         (process_psymtab_comp_unit_reader): Remove data parameter; add
8761         want_partial_unit and pretend_language parameters.
8762         (process_psymtab_comp_unit): Use cutu_reader.
8763         (build_type_psymtabs_reader): Remove data parameter.
8764         (build_type_psymtabs_1): Use cutu_reader.
8765         (process_skeletonless_type_unit): Likewise.
8766         (load_partial_comp_unit_reader): Remove.
8767         (load_partial_comp_unit): Use cutu_reader.
8768         (load_full_comp_unit_reader): Remove.
8769         (load_full_comp_unit): Use cutu_reader.
8770         (struct create_dwo_cu_data): Remove.
8771         (create_dwo_cu_reader): Remove datap parameter; add dwo_file and
8772         dwo_unit parameters.
8773         (create_cus_hash_table): Use cutu_reader.
8774         (struct dwarf2_read_addr_index_data): Remove.
8775         (dwarf2_read_addr_index_reader): Remove.
8776         (dwarf2_read_addr_index): Use cutu_reader.
8777         (read_signatured_type_reader): Remove.
8778         (read_signatured_type): Use cutu_reader.
8779
8780 2020-01-19  Tom Tromey  <tom@tromey.com>
8781
8782         * tui/tui.c (tui_show_assembly): Use tui_suppress_output.
8783         * tui/tui-wingeneral.h (class tui_suppress_output): New.
8784         (tui_wrefresh): Declare.
8785         * tui/tui-wingeneral.c (suppress_output): New global.
8786         (tui_suppress_output, ~tui_suppress_output): New constructor and
8787         destructor.
8788         (tui_wrefresh): New function.
8789         (tui_gen_win_info::refresh_window): Use tui_wrefresh.
8790         (tui_gen_win_info::make_window): Call wnoutrefresh when needed.
8791         * tui/tui-regs.h (struct tui_data_window) <no_refresh>: Declare
8792         method.
8793         * tui/tui-regs.c (tui_data_window::erase_data_content): Call
8794         tui_wrefresh.
8795         (tui_data_window::no_refresh): New method.
8796         (tui_data_item_window::refresh_window): Call tui_wrefresh.
8797         (tui_reg_command): Use tui_suppress_output
8798         * tui/tui-layout.c (tui_set_layout): Use tui_suppress_output.
8799         * tui/tui-data.h (struct tui_gen_win_info) <no_refresh>: New
8800         method.
8801         * tui/tui-command.c (tui_refresh_cmd_win): Call tui_wrefresh.
8802
8803 2020-01-19  Tom Tromey  <tom@tromey.com>
8804
8805         * tui/tui-winsource.c (tui_update_source_windows_with_line):
8806         Handle case where symtab is null.
8807
8808 2020-01-19  Simon Marchi  <simon.marchi@polymtl.ca>
8809
8810         * linux-fork.c (one_fork_p): Simplify.
8811
8812 2020-01-17  Simon Marchi  <simon.marchi@efficios.com>
8813
8814         * top.c (struct qt_args): Remove.
8815         (kill_or_detach): Change return type to void, replace `void *`
8816         parameter with a proper one.
8817         (print_inferior_quit_action):  Likewise.
8818         (quit_confirm): Use range-based for loop to iterate over inferiors.
8819         (quit_force): Likewise.
8820
8821 2020-01-17  Simon Marchi  <simon.marchi@efficios.com>
8822
8823         * mi/mi-main.c (run_one_inferior): Change return type to void, replace
8824         `void *` parameter with proper parameters.
8825         (mi_cmd_exec_run): Use range-based loop to iterate over inferiors.
8826         (print_one_inferior): Change return type to void, replace `void *`
8827         parameter with proper parameters.
8828         (mi_cmd_list_thread_groups): Use range-based loop to iterate over
8829         inferiors.
8830         (get_other_inferior): Remove.
8831         (mi_cmd_remove_inferior): Use range-based loop to iterate over
8832         inferiors.
8833
8834 2020-01-17  Simon Marchi  <simon.marchi@efficios.com>
8835
8836         * mi/mi-interp.c (report_initial_inferior): Remove.
8837         (mi_interp::init): Use range-based for to iterate over inferiors.
8838
8839 2020-01-17  Simon Marchi  <simon.marchi@efficios.com>
8840
8841         * python/py-inferior.c (build_inferior_list): Remove.
8842         (gdbpy_ref): Use range-based for loop to iterate over inferiors.
8843
8844 2020-01-16  Christian Biesinger  <cbiesinger@google.com>
8845
8846         * btrace.c (btrace_compute_ftrace_1): Fix spelling error (Unkown).
8847         (btrace_stitch_trace): Likewise.
8848         * charset.c (intermediate_encoding): Likewise (vaild).
8849         * nat/linux-btrace.c (linux_read_pt): Likewise (Unkown).
8850         * python/py-record-btrace.c (struct PyMethodDef): Likewise (occurences).
8851         * record-btrace.c (record_btrace_print_conf): Likewise (unkown).
8852
8853 2020-01-16  Hannes Domani  <ssbssa@yahoo.de>
8854
8855         * windows-tdep.c (windows_get_tlb_type):
8856         Add rtl_user_process_parameters type.
8857
8858 2020-01-16  Pedro Alves  <palves@redhat.com>
8859             Norbert Lange  <nolange79@gmail.com>
8860
8861         PR build/24805
8862         * gdbsupport/gdb_proc_service.h (PS_EXPORT): New.
8863         (ps_get_thread_area, ps_getpid, ps_lcontinue, ps_lgetfpregs)
8864         (ps_lgetregs, ps_lsetfpregs, ps_lsetregs, ps_lstop, ps_pcontinue)
8865         (ps_pdread, ps_pdwrite, ps_pglobal_lookup, ps_pstop, ps_ptread)
8866         (ps_ptwrite, ps_lgetxregs, ps_lgetxregsize, ps_lsetxregs)
8867         (ps_plog): Redeclare exported functions with default visibility.
8868
8869 2020-01-16  Nitika Achra  <Nitika.Achra@amd.com>
8870
8871         * dwarf2loc.c (decode_debug_loclists_addresses): Handle
8872         DW_LLE_base_addressx, DW_LLE_startx_length, DW_LLE_start_length.
8873
8874 2020-01-15  Simon Marchi  <simon.marchi@efficios.com>
8875
8876         * infcmd.c (post_create_inferior): Use get_thread_regcache
8877         instead of get_current_regcache.
8878
8879 2020-01-14  Tom Tromey  <tom@tromey.com>
8880
8881         PR symtab/12535:
8882         * python/python.c (gdbpy_decode_line): Treat empty string the same
8883         as no argument.
8884
8885 2020-01-14  Tom Tromey  <tom@tromey.com>
8886
8887         * Makefile.in (CLIBS): Remove second use of $(LIBIBERTY).
8888
8889 2020-01-14  Tom Tromey  <tom@tromey.com>
8890
8891         * nat/linux-btrace.c: Don't include <config.h>.
8892         * nat/linux-ptrace.c: Don't include <config.h>.
8893         * nat/x86-linux-dregs.c: Don't include <config.h>.
8894
8895 2020-01-14  Tom Tromey  <tom@tromey.com>
8896
8897         * configure: Rebuild.
8898         * configure.ac: Move many checks to ../gdbsupport/common.m4.
8899
8900 2020-01-14  Tom Tromey  <tom@tromey.com>
8901
8902         * nat/x86-linux-dregs.c: Include configh.h.
8903         * nat/linux-ptrace.c: Include configh.h.
8904         * nat/linux-btrace.c: Include configh.h.
8905         * defs.h: Include config.h, bfd.h.
8906         * configure.ac: Don't source common.host.
8907         (CONFIG_OBS, CONFIG_SRCS): Remove gdbsupport files.
8908         * configure: Rebuild.
8909         * acinclude.m4: Update path.
8910         * Makefile.in (SUPPORT, LIBSUPPORT, INCSUPPORT): New variables.
8911         (CONFIG_SRC_SUBDIR): Remove gdbsupport.
8912         (INTERNAL_CFLAGS_BASE): Add INCSUPPORT.
8913         (CLIBS): Add LIBSUPPORT.
8914         (CDEPS): Likewise.
8915         (COMMON_SFILES): Remove gdbsupport files.
8916         (HFILES_NO_SRCDIR): Likewise.
8917         (stamp-version): Update path to create-version.sh.
8918         (ALLDEPFILES): Remove gdbsupport files.
8919
8920 2020-01-14  Tom Tromey  <tom@tromey.com>
8921
8922         * gdbsupport/common.m4 (GDB_AC_COMMON): Define WIN32APILIBS and
8923         USE_WIN32API when needed.
8924         * configure.ac (USE_WIN32API): Don't define.
8925         (WIN32LIBS): Use WIN32APILIBS.
8926         * configure: Rebuild.
8927
8928 2020-01-14  Tom Tromey  <tom@tromey.com>
8929
8930         * configure: Rebuild.
8931         * gdbsupport/common.m4 (GDB_AC_COMMON): Fix indentation.
8932
8933 2020-01-14  Bernd Edlinger  <bernd.edlinger@hotmail.de>
8934
8935         * skip.c (skip_function_command): Make skip w/o arguments use the
8936         name of the inlined function if pc is inside any inlined function.
8937
8938 2020-01-14  Luis Machado  <luis.machado@linaro.org>
8939
8940         * inf-ptrace.c (inf_ptrace_target::resume): Update comments.
8941         * infrun.c (resume_1): Likewise.
8942         (handle_inferior_event): Remove stale comment.
8943         * linux-nat.c (linux_nat_target::resume): Update comments.
8944         (save_stop_reason): Likewise.
8945         (linux_nat_filter_event): Likewise.
8946         * linux-nat.h (struct lwp_info) <stop_pc>, <stop_reason>: Likewise.
8947
8948 2020-01-13  Andrew Burgess  <andrew.burgess@embecosm.com>
8949
8950         * elfread.c (record_minimal_symbol): Set section index to 0 for
8951         non-allocatable sections.
8952
8953
8954 2020-01-13  Ali Tamur <tamur@google.com>
8955
8956         * dwarf2read.c (dwarf2_debug_sections): Add debug_str_offsets sections.
8957         (dwarf2_cu): Add str_offsets_base field.  Change the type of addr_base
8958         to gdb::optional.  Update comments.
8959         (dwo_file): Update comments.
8960         (read_attribute): Update API to take an additional out parameter,
8961         need_reprocess.  This is used to mark attributes that need other
8962         attributes (e.g. str_offsets_base) for correct computation which may not
8963         have been read yet.
8964         (read_attribute_reprocess): New function declaration.
8965         (read_addr_index): Likewise.
8966         (read_dwo_str_index): Likewise.
8967         (read_stub_str_index): Likewise.
8968         (dwarf2_per_objfile::locate_sections): Handle debug_str_offsets section.
8969         (lookup_addr_base): New function definition.
8970         (lookup_ranges_base): Likewise.
8971         (read_cutu_die_from_dwo): Use the new functions: lookup_addr_base,
8972         lookup_ranges_base.
8973         (init_cutu_and_read_dies): Update comments.
8974         (init_cutu_and_read_dies_no_follow): Change API to take parent compile
8975         unit.  This is used to inherit parent's str_offsets_base and addr_base.
8976         Update comments.
8977         (init_cutu_and_read_dies_simple): Reflect API changes.
8978         (skip_one_die): Reflect API changes.  Handle DW_FORM_rnglistx.
8979         (create_cus_hash_table): Change API to take parent compile unit.
8980         Reflect API changes.
8981         (open_and_init_dwo_file): Reflect API changes.
8982         (dwarf2_get_pc_bounds): Update comments.
8983         (dwarf2_record_block_ranges): Likewise.
8984         (read_full_die_1): Change implementation to reprocess attributes that
8985         need str_offsets_base and addr_base.
8986         (partial_die_info::read): Likewise.
8987         (read_attribute_reprocess): New function definition.
8988         (read_attribute_value): Change API to take an additional out parameter,
8989         need_reprocess.  Handle DW_FORM_rnglistx.  No longer trigger an error
8990         when a non-dwo compile unit has index based attributes.
8991         (read_attribute): Reflect API changes.
8992         (read_addr_index_1): Reflect API changes.  Update comments.
8993         (dwarf2_read_addr_index_data): Reflect API changes.
8994         (dwarf2_read_addr_index): Likewise.
8995         (read_str_index): Change API and implementation.  This becomes a helper
8996         to be used by the new string index related methods.  Update error
8997         message and comments.
8998         (read_dwo_str_index): New function definition.
8999         (read_stub_str_index): Likewise.
9000         * dwarf2read.h (dwarf2_per_objfile): Add str_offsets field.
9001         * symfile.h (dwarf2_debug_sections): Likewise.
9002         * xcoffread.c (dwarf2_debug_sections): Likewise.
9003
9004 2020-01-13  Simon Marchi  <simon.marchi@efficios.com>
9005
9006         * gdbcore.h (struct core_fns) <core_read_registers>: Change
9007         core_reg_sect type to gdb_byte *.
9008         * arm-nbsd-nat.c (fetch_elfcore_registers): Likewise.
9009         * cris-tdep.c (fetch_core_registers): Likewise.
9010         * corelow.c (core_target::get_core_register_section): Change
9011         type of `contents` to gdb::byte_vector.
9012
9013 2020-01-13  Andrew Burgess  <andrew.burgess@embecosm.com>
9014
9015         * tui/tui-wingeneral.c (box_win): Position the title in the center
9016         of the border.
9017
9018 2020-01-13  Simon Marchi  <simon.marchi@polymtl.ca>
9019
9020         * corelow.c (core_target::get_core_register_section): Use
9021           std::vector instead of alloca.
9022
9023 2020-01-13  Simon Marchi  <simon.marchi@efficios.com>
9024
9025         * warning.m4: Add -Wmissing-declarations to build_warnings.
9026         * configure: Re-generate.
9027
9028 2020-01-13  Simon Marchi  <simon.marchi@efficios.com>
9029
9030         * python/python.c (init__gdb_module): Add declaration.
9031
9032 2020-01-13  Simon Marchi  <simon.marchi@efficios.com>
9033
9034         * aarch64-fbsd-nat.c (_initialize_aarch64_fbsd_nat): Add declaration.
9035         * aarch64-fbsd-tdep.c (_initialize_aarch64_fbsd_tdep): Add declaration.
9036         * aarch64-linux-nat.c (_initialize_aarch64_linux_nat): Add declaration.
9037         * aarch64-linux-tdep.c (_initialize_aarch64_linux_tdep): Add declaration.
9038         * aarch64-newlib-tdep.c (_initialize_aarch64_newlib_tdep): Add declaration.
9039         * aarch64-tdep.c (_initialize_aarch64_tdep): Add declaration.
9040         * ada-exp.y (_initialize_ada_exp): Add declaration.
9041         * ada-lang.c (_initialize_ada_language): Add declaration.
9042         * ada-tasks.c (_initialize_tasks): Add declaration.
9043         * agent.c (_initialize_agent): Add declaration.
9044         * aix-thread.c (_initialize_aix_thread): Add declaration.
9045         * alpha-bsd-nat.c (_initialize_alphabsd_nat): Add declaration.
9046         * alpha-linux-nat.c (_initialize_alpha_linux_nat): Add declaration.
9047         * alpha-linux-tdep.c (_initialize_alpha_linux_tdep): Add declaration.
9048         * alpha-nbsd-tdep.c (_initialize_alphanbsd_tdep): Add declaration.
9049         * alpha-obsd-tdep.c (_initialize_alphaobsd_tdep): Add declaration.
9050         * alpha-tdep.c (_initialize_alpha_tdep): Add declaration.
9051         * amd64-darwin-tdep.c (_initialize_amd64_darwin_tdep): Add declaration.
9052         * amd64-dicos-tdep.c (_initialize_amd64_dicos_tdep): Add declaration.
9053         * amd64-fbsd-nat.c (_initialize_amd64fbsd_nat): Add declaration.
9054         * amd64-fbsd-tdep.c (_initialize_amd64fbsd_tdep): Add declaration.
9055         * amd64-linux-nat.c (_initialize_amd64_linux_nat): Add declaration.
9056         * amd64-linux-tdep.c (_initialize_amd64_linux_tdep): Add declaration.
9057         * amd64-nbsd-nat.c (_initialize_amd64nbsd_nat): Add declaration.
9058         * amd64-nbsd-tdep.c (_initialize_amd64nbsd_tdep): Add declaration.
9059         * amd64-obsd-nat.c (_initialize_amd64obsd_nat): Add declaration.
9060         * amd64-obsd-tdep.c (_initialize_amd64obsd_tdep): Add declaration.
9061         * amd64-sol2-tdep.c (_initialize_amd64_sol2_tdep): Add declaration.
9062         * amd64-tdep.c (_initialize_amd64_tdep): Add declaration.
9063         * amd64-windows-nat.c (_initialize_amd64_windows_nat): Add declaration.
9064         * amd64-windows-tdep.c (_initialize_amd64_windows_tdep): Add declaration.
9065         * annotate.c (_initialize_annotate): Add declaration.
9066         * arc-newlib-tdep.c (_initialize_arc_newlib_tdep): Add declaration.
9067         * arc-tdep.c (_initialize_arc_tdep): Add declaration.
9068         * arch-utils.c (_initialize_gdbarch_utils): Add declaration.
9069         * arm-fbsd-nat.c (_initialize_arm_fbsd_nat): Add declaration.
9070         * arm-fbsd-tdep.c (_initialize_arm_fbsd_tdep): Add declaration.
9071         * arm-linux-nat.c (_initialize_arm_linux_nat): Add declaration.
9072         * arm-linux-tdep.c (_initialize_arm_linux_tdep): Add declaration.
9073         * arm-nbsd-nat.c (_initialize_arm_netbsd_nat): Add declaration.
9074         * arm-nbsd-tdep.c (_initialize_arm_netbsd_tdep): Add declaration.
9075         * arm-obsd-tdep.c (_initialize_armobsd_tdep): Add declaration.
9076         * arm-pikeos-tdep.c (_initialize_arm_pikeos_tdep): Add declaration.
9077         * arm-symbian-tdep.c (_initialize_arm_symbian_tdep): Add declaration.
9078         * arm-tdep.c (_initialize_arm_tdep): Add declaration.
9079         * arm-wince-tdep.c (_initialize_arm_wince_tdep): Add declaration.
9080         * auto-load.c (_initialize_auto_load): Add declaration.
9081         * auxv.c (_initialize_auxv): Add declaration.
9082         * avr-tdep.c (_initialize_avr_tdep): Add declaration.
9083         * ax-gdb.c (_initialize_ax_gdb): Add declaration.
9084         * bfin-linux-tdep.c (_initialize_bfin_linux_tdep): Add declaration.
9085         * bfin-tdep.c (_initialize_bfin_tdep): Add declaration.
9086         * break-catch-sig.c (_initialize_break_catch_sig): Add declaration.
9087         * break-catch-syscall.c (_initialize_break_catch_syscall): Add declaration.
9088         * break-catch-throw.c (_initialize_break_catch_throw): Add declaration.
9089         * breakpoint.c (_initialize_breakpoint): Add declaration.
9090         * bsd-uthread.c (_initialize_bsd_uthread): Add declaration.
9091         * btrace.c (_initialize_btrace): Add declaration.
9092         * charset.c (_initialize_charset): Add declaration.
9093         * cli/cli-cmds.c (_initialize_cli_cmds): Add declaration.
9094         * cli/cli-dump.c (_initialize_cli_dump): Add declaration.
9095         * cli/cli-interp.c (_initialize_cli_interp): Add declaration.
9096         * cli/cli-logging.c (_initialize_cli_logging): Add declaration.
9097         * cli/cli-script.c (_initialize_cli_script): Add declaration.
9098         * cli/cli-style.c (_initialize_cli_style): Add declaration.
9099         * coff-pe-read.c (_initialize_coff_pe_read): Add declaration.
9100         * coffread.c (_initialize_coffread): Add declaration.
9101         * compile/compile-cplus-types.c (_initialize_compile_cplus_types): Add declaration.
9102         * compile/compile.c (_initialize_compile): Add declaration.
9103         * complaints.c (_initialize_complaints): Add declaration.
9104         * completer.c (_initialize_completer): Add declaration.
9105         * copying.c (_initialize_copying): Add declaration.
9106         * corefile.c (_initialize_core): Add declaration.
9107         * corelow.c (_initialize_corelow): Add declaration.
9108         * cp-abi.c (_initialize_cp_abi): Add declaration.
9109         * cp-namespace.c (_initialize_cp_namespace): Add declaration.
9110         * cp-support.c (_initialize_cp_support): Add declaration.
9111         * cp-valprint.c (_initialize_cp_valprint): Add declaration.
9112         * cris-linux-tdep.c (_initialize_cris_linux_tdep): Add declaration.
9113         * cris-tdep.c (_initialize_cris_tdep): Add declaration.
9114         * csky-linux-tdep.c (_initialize_csky_linux_tdep): Add declaration.
9115         * csky-tdep.c (_initialize_csky_tdep): Add declaration.
9116         * ctfread.c (_initialize_ctfread): Add declaration.
9117         * d-lang.c (_initialize_d_language): Add declaration.
9118         * darwin-nat-info.c (_initialize_darwin_info_commands): Add declaration.
9119         * darwin-nat.c (_initialize_darwin_nat): Add declaration.
9120         * dbxread.c (_initialize_dbxread): Add declaration.
9121         * dcache.c (_initialize_dcache): Add declaration.
9122         * disasm-selftests.c (_initialize_disasm_selftests): Add declaration.
9123         * disasm.c (_initialize_disasm): Add declaration.
9124         * dtrace-probe.c (_initialize_dtrace_probe): Add declaration.
9125         * dummy-frame.c (_initialize_dummy_frame): Add declaration.
9126         * dwarf-index-cache.c (_initialize_index_cache): Add declaration.
9127         * dwarf-index-write.c (_initialize_dwarf_index_write): Add declaration.
9128         * dwarf2-frame-tailcall.c (_initialize_tailcall_frame): Add declaration.
9129         * dwarf2-frame.c (_initialize_dwarf2_frame): Add declaration.
9130         * dwarf2expr.c (_initialize_dwarf2expr): Add declaration.
9131         * dwarf2loc.c (_initialize_dwarf2loc): Add declaration.
9132         * dwarf2read.c (_initialize_dwarf2_read): Add declaration.
9133         * elfread.c (_initialize_elfread): Add declaration.
9134         * exec.c (_initialize_exec): Add declaration.
9135         * extension.c (_initialize_extension): Add declaration.
9136         * f-lang.c (_initialize_f_language): Add declaration.
9137         * f-valprint.c (_initialize_f_valprint): Add declaration.
9138         * fbsd-nat.c (_initialize_fbsd_nat): Add declaration.
9139         * fbsd-tdep.c (_initialize_fbsd_tdep): Add declaration.
9140         * filesystem.c (_initialize_filesystem): Add declaration.
9141         * findcmd.c (_initialize_mem_search): Add declaration.
9142         * findvar.c (_initialize_findvar): Add declaration.
9143         * fork-child.c (_initialize_fork_child): Add declaration.
9144         * frame-base.c (_initialize_frame_base): Add declaration.
9145         * frame-unwind.c (_initialize_frame_unwind): Add declaration.
9146         * frame.c (_initialize_frame): Add declaration.
9147         * frv-linux-tdep.c (_initialize_frv_linux_tdep): Add declaration.
9148         * frv-tdep.c (_initialize_frv_tdep): Add declaration.
9149         * ft32-tdep.c (_initialize_ft32_tdep): Add declaration.
9150         * gcore.c (_initialize_gcore): Add declaration.
9151         * gdb-demangle.c (_initialize_gdb_demangle): Add declaration.
9152         * gdb_bfd.c (_initialize_gdb_bfd): Add declaration.
9153         * gdbarch-selftests.c (_initialize_gdbarch_selftests): Add declaration.
9154         * gdbarch.c (_initialize_gdbarch): Add declaration.
9155         * gdbtypes.c (_initialize_gdbtypes): Add declaration.
9156         * gnu-nat.c (_initialize_gnu_nat): Add declaration.
9157         * gnu-v2-abi.c (_initialize_gnu_v2_abi): Add declaration.
9158         * gnu-v3-abi.c (_initialize_gnu_v3_abi): Add declaration.
9159         * go-lang.c (_initialize_go_language): Add declaration.
9160         * go32-nat.c (_initialize_go32_nat): Add declaration.
9161         * guile/guile.c (_initialize_guile): Add declaration.
9162         * h8300-tdep.c (_initialize_h8300_tdep): Add declaration.
9163         * hppa-linux-nat.c (_initialize_hppa_linux_nat): Add declaration.
9164         * hppa-linux-tdep.c (_initialize_hppa_linux_tdep): Add declaration.
9165         * hppa-nbsd-nat.c (_initialize_hppanbsd_nat): Add declaration.
9166         * hppa-nbsd-tdep.c (_initialize_hppanbsd_tdep): Add declaration.
9167         * hppa-obsd-nat.c (_initialize_hppaobsd_nat): Add declaration.
9168         * hppa-obsd-tdep.c (_initialize_hppabsd_tdep): Add declaration.
9169         * hppa-tdep.c (_initialize_hppa_tdep): Add declaration.
9170         * i386-bsd-nat.c (_initialize_i386bsd_nat): Add declaration.
9171         * i386-cygwin-tdep.c (_initialize_i386_cygwin_tdep): Add declaration.
9172         * i386-darwin-nat.c (_initialize_i386_darwin_nat): Add declaration.
9173         * i386-darwin-tdep.c (_initialize_i386_darwin_tdep): Add declaration.
9174         * i386-dicos-tdep.c (_initialize_i386_dicos_tdep): Add declaration.
9175         * i386-fbsd-nat.c (_initialize_i386fbsd_nat): Add declaration.
9176         * i386-fbsd-tdep.c (_initialize_i386fbsd_tdep): Add declaration.
9177         * i386-gnu-nat.c (_initialize_i386gnu_nat): Add declaration.
9178         * i386-gnu-tdep.c (_initialize_i386gnu_tdep): Add declaration.
9179         * i386-go32-tdep.c (_initialize_i386_go32_tdep): Add declaration.
9180         * i386-linux-nat.c (_initialize_i386_linux_nat): Add declaration.
9181         * i386-linux-tdep.c (_initialize_i386_linux_tdep): Add declaration.
9182         * i386-nbsd-nat.c (_initialize_i386nbsd_nat): Add declaration.
9183         * i386-nbsd-tdep.c (_initialize_i386nbsd_tdep): Add declaration.
9184         * i386-nto-tdep.c (_initialize_i386nto_tdep): Add declaration.
9185         * i386-obsd-nat.c (_initialize_i386obsd_nat): Add declaration.
9186         * i386-obsd-tdep.c (_initialize_i386obsd_tdep): Add declaration.
9187         * i386-sol2-nat.c (_initialize_amd64_sol2_nat): Add declaration.
9188         * i386-sol2-tdep.c (_initialize_i386_sol2_tdep): Add declaration.
9189         * i386-tdep.c (_initialize_i386_tdep): Add declaration.
9190         * i386-windows-nat.c (_initialize_i386_windows_nat): Add declaration.
9191         * ia64-libunwind-tdep.c (_initialize_libunwind_frame): Add declaration.
9192         * ia64-linux-nat.c (_initialize_ia64_linux_nat): Add declaration.
9193         * ia64-linux-tdep.c (_initialize_ia64_linux_tdep): Add declaration.
9194         * ia64-tdep.c (_initialize_ia64_tdep): Add declaration.
9195         * ia64-vms-tdep.c (_initialize_ia64_vms_tdep): Add declaration.
9196         * infcall.c (_initialize_infcall): Add declaration.
9197         * infcmd.c (_initialize_infcmd): Add declaration.
9198         * inflow.c (_initialize_inflow): Add declaration.
9199         * infrun.c (_initialize_infrun): Add declaration.
9200         * interps.c (_initialize_interpreter): Add declaration.
9201         * iq2000-tdep.c (_initialize_iq2000_tdep): Add declaration.
9202         * jit.c (_initialize_jit): Add declaration.
9203         * language.c (_initialize_language): Add declaration.
9204         * linux-fork.c (_initialize_linux_fork): Add declaration.
9205         * linux-nat.c (_initialize_linux_nat): Add declaration.
9206         * linux-tdep.c (_initialize_linux_tdep): Add declaration.
9207         * linux-thread-db.c (_initialize_thread_db): Add declaration.
9208         * lm32-tdep.c (_initialize_lm32_tdep): Add declaration.
9209         * m2-lang.c (_initialize_m2_language): Add declaration.
9210         * m32c-tdep.c (_initialize_m32c_tdep): Add declaration.
9211         * m32r-linux-nat.c (_initialize_m32r_linux_nat): Add declaration.
9212         * m32r-linux-tdep.c (_initialize_m32r_linux_tdep): Add declaration.
9213         * m32r-tdep.c (_initialize_m32r_tdep): Add declaration.
9214         * m68hc11-tdep.c (_initialize_m68hc11_tdep): Add declaration.
9215         * m68k-bsd-nat.c (_initialize_m68kbsd_nat): Add declaration.
9216         * m68k-bsd-tdep.c (_initialize_m68kbsd_tdep): Add declaration.
9217         * m68k-linux-nat.c (_initialize_m68k_linux_nat): Add declaration.
9218         * m68k-linux-tdep.c (_initialize_m68k_linux_tdep): Add declaration.
9219         * m68k-tdep.c (_initialize_m68k_tdep): Add declaration.
9220         * machoread.c (_initialize_machoread): Add declaration.
9221         * macrocmd.c (_initialize_macrocmd): Add declaration.
9222         * macroscope.c (_initialize_macroscope): Add declaration.
9223         * maint-test-options.c (_initialize_maint_test_options): Add declaration.
9224         * maint-test-settings.c (_initialize_maint_test_settings): Add declaration.
9225         * maint.c (_initialize_maint_cmds): Add declaration.
9226         * mdebugread.c (_initialize_mdebugread): Add declaration.
9227         * memattr.c (_initialize_mem): Add declaration.
9228         * mep-tdep.c (_initialize_mep_tdep): Add declaration.
9229         * mi/mi-cmd-env.c (_initialize_mi_cmd_env): Add declaration.
9230         * mi/mi-cmds.c (_initialize_mi_cmds): Add declaration.
9231         * mi/mi-interp.c (_initialize_mi_interp): Add declaration.
9232         * mi/mi-main.c (_initialize_mi_main): Add declaration.
9233         * microblaze-linux-tdep.c (_initialize_microblaze_linux_tdep): Add declaration.
9234         * microblaze-tdep.c (_initialize_microblaze_tdep): Add declaration.
9235         * mips-fbsd-nat.c (_initialize_mips_fbsd_nat): Add declaration.
9236         * mips-fbsd-tdep.c (_initialize_mips_fbsd_tdep): Add declaration.
9237         * mips-linux-nat.c (_initialize_mips_linux_nat): Add declaration.
9238         * mips-linux-tdep.c (_initialize_mips_linux_tdep): Add declaration.
9239         * mips-nbsd-nat.c (_initialize_mipsnbsd_nat): Add declaration.
9240         * mips-nbsd-tdep.c (_initialize_mipsnbsd_tdep): Add declaration.
9241         * mips-sde-tdep.c (_initialize_mips_sde_tdep): Add declaration.
9242         * mips-tdep.c (_initialize_mips_tdep): Add declaration.
9243         * mips64-obsd-nat.c (_initialize_mips64obsd_nat): Add declaration.
9244         * mips64-obsd-tdep.c (_initialize_mips64obsd_tdep): Add declaration.
9245         * mipsread.c (_initialize_mipsread): Add declaration.
9246         * mn10300-linux-tdep.c (_initialize_mn10300_linux_tdep): Add declaration.
9247         * mn10300-tdep.c (_initialize_mn10300_tdep): Add declaration.
9248         * moxie-tdep.c (_initialize_moxie_tdep): Add declaration.
9249         * msp430-tdep.c (_initialize_msp430_tdep): Add declaration.
9250         * nds32-tdep.c (_initialize_nds32_tdep): Add declaration.
9251         * nios2-linux-tdep.c (_initialize_nios2_linux_tdep): Add declaration.
9252         * nios2-tdep.c (_initialize_nios2_tdep): Add declaration.
9253         * nto-procfs.c (_initialize_procfs): Add declaration.
9254         * objc-lang.c (_initialize_objc_language): Add declaration.
9255         * observable.c (_initialize_observer): Add declaration.
9256         * opencl-lang.c (_initialize_opencl_language): Add declaration.
9257         * or1k-linux-tdep.c (_initialize_or1k_linux_tdep): Add declaration.
9258         * or1k-tdep.c (_initialize_or1k_tdep): Add declaration.
9259         * osabi.c (_initialize_gdb_osabi): Add declaration.
9260         * osdata.c (_initialize_osdata): Add declaration.
9261         * p-valprint.c (_initialize_pascal_valprint): Add declaration.
9262         * parse.c (_initialize_parse): Add declaration.
9263         * ppc-fbsd-nat.c (_initialize_ppcfbsd_nat): Add declaration.
9264         * ppc-fbsd-tdep.c (_initialize_ppcfbsd_tdep): Add declaration.
9265         * ppc-linux-nat.c (_initialize_ppc_linux_nat): Add declaration.
9266         * ppc-linux-tdep.c (_initialize_ppc_linux_tdep): Add declaration.
9267         * ppc-nbsd-nat.c (_initialize_ppcnbsd_nat): Add declaration.
9268         * ppc-nbsd-tdep.c (_initialize_ppcnbsd_tdep): Add declaration.
9269         * ppc-obsd-nat.c (_initialize_ppcobsd_nat): Add declaration.
9270         * ppc-obsd-tdep.c (_initialize_ppcobsd_tdep): Add declaration.
9271         * printcmd.c (_initialize_printcmd): Add declaration.
9272         * probe.c (_initialize_probe): Add declaration.
9273         * proc-api.c (_initialize_proc_api): Add declaration.
9274         * proc-events.c (_initialize_proc_events): Add declaration.
9275         * proc-service.c (_initialize_proc_service): Add declaration.
9276         * procfs.c (_initialize_procfs): Add declaration.
9277         * producer.c (_initialize_producer): Add declaration.
9278         * psymtab.c (_initialize_psymtab): Add declaration.
9279         * python/python.c (_initialize_python): Add declaration.
9280         * ravenscar-thread.c (_initialize_ravenscar): Add declaration.
9281         * record-btrace.c (_initialize_record_btrace): Add declaration.
9282         * record-full.c (_initialize_record_full): Add declaration.
9283         * record.c (_initialize_record): Add declaration.
9284         * regcache-dump.c (_initialize_regcache_dump): Add declaration.
9285         * regcache.c (_initialize_regcache): Add declaration.
9286         * reggroups.c (_initialize_reggroup): Add declaration.
9287         * remote-notif.c (_initialize_notif): Add declaration.
9288         * remote-sim.c (_initialize_remote_sim): Add declaration.
9289         * remote.c (_initialize_remote): Add declaration.
9290         * reverse.c (_initialize_reverse): Add declaration.
9291         * riscv-fbsd-nat.c (_initialize_riscv_fbsd_nat): Add declaration.
9292         * riscv-fbsd-tdep.c (_initialize_riscv_fbsd_tdep): Add declaration.
9293         * riscv-linux-nat.c (_initialize_riscv_linux_nat): Add declaration.
9294         * riscv-linux-tdep.c (_initialize_riscv_linux_tdep): Add declaration.
9295         * riscv-tdep.c (_initialize_riscv_tdep): Add declaration.
9296         * rl78-tdep.c (_initialize_rl78_tdep): Add declaration.
9297         * rs6000-aix-tdep.c (_initialize_rs6000_aix_tdep): Add declaration.
9298         * rs6000-lynx178-tdep.c (_initialize_rs6000_lynx178_tdep):
9299         Add declaration.
9300         * rs6000-nat.c (_initialize_rs6000_nat): Add declaration.
9301         * rs6000-tdep.c (_initialize_rs6000_tdep): Add declaration.
9302         * run-on-main-thread.c (_initialize_run_on_main_thread): Add declaration.
9303         * rust-exp.y (_initialize_rust_exp): Add declaration.
9304         * rx-tdep.c (_initialize_rx_tdep): Add declaration.
9305         * s12z-tdep.c (_initialize_s12z_tdep): Add declaration.
9306         * s390-linux-nat.c (_initialize_s390_nat): Add declaration.
9307         * s390-linux-tdep.c (_initialize_s390_linux_tdep): Add declaration.
9308         * s390-tdep.c (_initialize_s390_tdep): Add declaration.
9309         * score-tdep.c (_initialize_score_tdep): Add declaration.
9310         * ser-go32.c (_initialize_ser_dos): Add declaration.
9311         * ser-mingw.c (_initialize_ser_windows): Add declaration.
9312         * ser-pipe.c (_initialize_ser_pipe): Add declaration.
9313         * ser-tcp.c (_initialize_ser_tcp): Add declaration.
9314         * ser-uds.c (_initialize_ser_socket): Add declaration.
9315         * ser-unix.c (_initialize_ser_hardwire): Add declaration.
9316         * serial.c (_initialize_serial): Add declaration.
9317         * sh-linux-tdep.c (_initialize_sh_linux_tdep): Add declaration.
9318         * sh-nbsd-nat.c (_initialize_shnbsd_nat): Add declaration.
9319         * sh-nbsd-tdep.c (_initialize_shnbsd_tdep): Add declaration.
9320         * sh-tdep.c (_initialize_sh_tdep): Add declaration.
9321         * skip.c (_initialize_step_skip): Add declaration.
9322         * sol-thread.c (_initialize_sol_thread): Add declaration.
9323         * solib-aix.c (_initialize_solib_aix): Add declaration.
9324         * solib-darwin.c (_initialize_darwin_solib): Add declaration.
9325         * solib-dsbt.c (_initialize_dsbt_solib): Add declaration.
9326         * solib-frv.c (_initialize_frv_solib): Add declaration.
9327         * solib-svr4.c (_initialize_svr4_solib): Add declaration.
9328         * solib-target.c (_initialize_solib_target): Add declaration.
9329         * solib.c (_initialize_solib): Add declaration.
9330         * source-cache.c (_initialize_source_cache): Add declaration.
9331         * source.c (_initialize_source): Add declaration.
9332         * sparc-linux-nat.c (_initialize_sparc_linux_nat): Add declaration.
9333         * sparc-linux-tdep.c (_initialize_sparc_linux_tdep): Add declaration.
9334         * sparc-nat.c (_initialize_sparc_nat): Add declaration.
9335         * sparc-nbsd-nat.c (_initialize_sparcnbsd_nat): Add declaration.
9336         * sparc-nbsd-tdep.c (_initialize_sparcnbsd_tdep): Add declaration.
9337         * sparc-obsd-tdep.c (_initialize_sparc32obsd_tdep): Add declaration.
9338         * sparc-sol2-tdep.c (_initialize_sparc_sol2_tdep): Add declaration.
9339         * sparc-tdep.c (_initialize_sparc_tdep): Add declaration.
9340         * sparc64-fbsd-nat.c (_initialize_sparc64fbsd_nat): Add declaration.
9341         * sparc64-fbsd-tdep.c (_initialize_sparc64fbsd_tdep): Add declaration.
9342         * sparc64-linux-nat.c (_initialize_sparc64_linux_nat): Add declaration.
9343         * sparc64-linux-tdep.c (_initialize_sparc64_linux_tdep): Add declaration.
9344         * sparc64-nat.c (_initialize_sparc64_nat): Add declaration.
9345         * sparc64-nbsd-nat.c (_initialize_sparc64nbsd_nat): Add declaration.
9346         * sparc64-nbsd-tdep.c (_initialize_sparc64nbsd_tdep): Add declaration.
9347         * sparc64-obsd-nat.c (_initialize_sparc64obsd_nat): Add declaration.
9348         * sparc64-obsd-tdep.c (_initialize_sparc64obsd_tdep): Add declaration.
9349         * sparc64-sol2-tdep.c (_initialize_sparc64_sol2_tdep): Add declaration.
9350         * sparc64-tdep.c (_initialize_sparc64_adi_tdep): Add declaration.
9351         * stabsread.c (_initialize_stabsread): Add declaration.
9352         * stack.c (_initialize_stack): Add declaration.
9353         * stap-probe.c (_initialize_stap_probe): Add declaration.
9354         * std-regs.c (_initialize_frame_reg): Add declaration.
9355         * symfile-debug.c (_initialize_symfile_debug): Add declaration.
9356         * symfile-mem.c (_initialize_symfile_mem): Add declaration.
9357         * symfile.c (_initialize_symfile): Add declaration.
9358         * symmisc.c (_initialize_symmisc): Add declaration.
9359         * symtab.c (_initialize_symtab): Add declaration.
9360         * target.c (_initialize_target): Add declaration.
9361         * target-connection.c (_initialize_target_connection): Add
9362         declaration.
9363         * target-dcache.c (_initialize_target_dcache): Add declaration.
9364         * target-descriptions.c (_initialize_target_descriptions): Add declaration.
9365         * thread.c (_initialize_thread): Add declaration.
9366         * tic6x-linux-tdep.c (_initialize_tic6x_linux_tdep): Add declaration.
9367         * tic6x-tdep.c (_initialize_tic6x_tdep): Add declaration.
9368         * tilegx-linux-nat.c (_initialize_tile_linux_nat): Add declaration.
9369         * tilegx-linux-tdep.c (_initialize_tilegx_linux_tdep): Add declaration.
9370         * tilegx-tdep.c (_initialize_tilegx_tdep): Add declaration.
9371         * tracectf.c (_initialize_ctf): Add declaration.
9372         * tracefile-tfile.c (_initialize_tracefile_tfile): Add declaration.
9373         * tracefile.c (_initialize_tracefile): Add declaration.
9374         * tracepoint.c (_initialize_tracepoint): Add declaration.
9375         * tui/tui-hooks.c (_initialize_tui_hooks): Add declaration.
9376         * tui/tui-interp.c (_initialize_tui_interp): Add declaration.
9377         * tui/tui-layout.c (_initialize_tui_layout): Add declaration.
9378         * tui/tui-regs.c (_initialize_tui_regs): Add declaration.
9379         * tui/tui-stack.c (_initialize_tui_stack): Add declaration.
9380         * tui/tui-win.c (_initialize_tui_win): Add declaration.
9381         * tui/tui.c (_initialize_tui): Add declaration.
9382         * typeprint.c (_initialize_typeprint): Add declaration.
9383         * ui-style.c (_initialize_ui_style): Add declaration.
9384         * unittests/array-view-selftests.c (_initialize_array_view_selftests): Add declaration.
9385         * unittests/child-path-selftests.c (_initialize_child_path_selftests): Add declaration.
9386         * unittests/cli-utils-selftests.c (_initialize_cli_utils_selftests): Add declaration.
9387         * unittests/common-utils-selftests.c (_initialize_common_utils_selftests): Add declaration.
9388         * unittests/copy_bitwise-selftests.c (_initialize_copy_bitwise_utils_selftests): Add declaration.
9389         * unittests/environ-selftests.c (_initialize_environ_selftests): Add declaration.
9390         * unittests/filtered_iterator-selftests.c
9391         (_initialize_filtered_iterator_selftests): Add declaration.
9392         * unittests/format_pieces-selftests.c (_initialize_format_pieces_selftests): Add declaration.
9393         * unittests/function-view-selftests.c (_initialize_function_view_selftests): Add declaration.
9394         * unittests/help-doc-selftests.c (_initialize_help_doc_selftests): Add declaration.
9395         * unittests/lookup_name_info-selftests.c (_initialize_lookup_name_info_selftests): Add declaration.
9396         * unittests/main-thread-selftests.c
9397         (_initialize_main_thread_selftests): Add declaration.
9398         * unittests/memory-map-selftests.c (_initialize_memory_map_selftests): Add declaration.
9399         * unittests/memrange-selftests.c (_initialize_memrange_selftests): Add declaration.
9400         * unittests/mkdir-recursive-selftests.c (_initialize_mkdir_recursive_selftests): Add declaration.
9401         * unittests/observable-selftests.c (_initialize_observer_selftest): Add declaration.
9402         * unittests/offset-type-selftests.c (_initialize_offset_type_selftests): Add declaration.
9403         * unittests/optional-selftests.c (_initialize_optional_selftests): Add declaration.
9404         * unittests/parse-connection-spec-selftests.c (_initialize_parse_connection_spec_selftests): Add declaration.
9405         * unittests/rsp-low-selftests.c (_initialize_rsp_low_selftests): Add declaration.
9406         * unittests/scoped_fd-selftests.c (_initialize_scoped_fd_selftests): Add declaration.
9407         * unittests/scoped_mmap-selftests.c (_initialize_scoped_mmap_selftests): Add declaration.
9408         * unittests/scoped_restore-selftests.c (_initialize_scoped_restore_selftests): Add declaration.
9409         * unittests/string_view-selftests.c (_initialize_string_view_selftests): Add declaration.
9410         * unittests/style-selftests.c (_initialize_style_selftest): Add declaration.
9411         * unittests/tracepoint-selftests.c (_initialize_tracepoint_selftests): Add declaration.
9412         * unittests/tui-selftests.c (_initialize_tui_selftest): Add
9413         declaration.
9414         * unittests/unpack-selftests.c (_initialize_unpack_selftests): Add declaration.
9415         * unittests/utils-selftests.c (_initialize_utils_selftests): Add declaration.
9416         * unittests/vec-utils-selftests.c (_initialize_vec_utils_selftests): Add declaration.
9417         * unittests/xml-utils-selftests.c (_initialize_xml_utils): Add declaration.
9418         * user-regs.c (_initialize_user_regs): Add declaration.
9419         * utils.c (_initialize_utils): Add declaration.
9420         * v850-tdep.c (_initialize_v850_tdep): Add declaration.
9421         * valops.c (_initialize_valops): Add declaration.
9422         * valprint.c (_initialize_valprint): Add declaration.
9423         * value.c (_initialize_values): Add declaration.
9424         * varobj.c (_initialize_varobj): Add declaration.
9425         * vax-bsd-nat.c (_initialize_vaxbsd_nat): Add declaration.
9426         * vax-nbsd-tdep.c (_initialize_vaxnbsd_tdep): Add declaration.
9427         * vax-tdep.c (_initialize_vax_tdep): Add declaration.
9428         * windows-nat.c (_initialize_windows_nat): Add declaration.
9429         (_initialize_check_for_gdb_ini): Add declaration.
9430         (_initialize_loadable): Add declaration.
9431         * windows-tdep.c (_initialize_windows_tdep): Add declaration.
9432         * x86-bsd-nat.c (_initialize_x86_bsd_nat): Add declaration.
9433         * x86-linux-nat.c (_initialize_x86_linux_nat): Add declaration.
9434         * xcoffread.c (_initialize_xcoffread): Add declaration.
9435         * xml-support.c (_initialize_xml_support): Add declaration.
9436         * xstormy16-tdep.c (_initialize_xstormy16_tdep): Add declaration.
9437         * xtensa-linux-nat.c (_initialize_xtensa_linux_nat): Add declaration.
9438         * xtensa-linux-tdep.c (_initialize_xtensa_linux_tdep): Add declaration.
9439         * xtensa-tdep.c (_initialize_xtensa_tdep): Add declaration.
9440
9441 2020-01-13  Simon Marchi  <simon.marchi@polymtl.ca>
9442
9443         * regformats/regdat.sh: Generate declaration for init function.
9444
9445 2020-01-13  Simon Marchi  <simon.marchi@polymtl.ca>
9446
9447         * remote-sim.c (next_pid, INITIAL_PID, sim_inferior_data): Move
9448         up.
9449         (gdbsim_target) <get_inferior_data_by_ptid, resume_one_inferior,
9450         close_one_inferior>: New methods.
9451         (get_sim_inferior_data_by_ptid): Move to gdbsim_target,
9452         pass down target to find_inferior_pid.
9453         (gdbsim_target::fetch_registers, gdbsim_target::store_registers):
9454         Pass down target to find_inferior_ptid.
9455         (gdbsim_target::create_inferior): Pass down target to
9456         add_thread_silent.
9457         (gdbsim_close_inferior): Move to gdbsim_close_inferior, pass
9458         target down to find_inferior_ptid and switch_to_thread.
9459         (gdbsim_target::close): Update to call close_one_inferior.
9460         (struct resume_data): Remove.
9461         (gdbsim_resume_inferior): Move to gdbsim_target.  Take arguments
9462         directly, rather than through a void pointer.
9463         (gdbsim_target::resume): Update to call resume_one_inferior.
9464
9465 2020-01-12  Simon Marchi  <simon.marchi@polymtl.ca>
9466
9467         * gdbsupport/gdb_wait.c: Include gdb_wait.h.
9468
9469 2020-01-12  Pedro Alves  <palves@redhat.com>
9470
9471         * bsd-kvm.c (bsd_kvm_target::close): Call exit_inferior_silent
9472         directly for the current inferior instead of
9473         discard_all_inferiors.
9474         (discard_all_inferiors): Delete.
9475
9476 2020-01-11  Tom Tromey  <tom@tromey.com>
9477
9478         * tui/tui-wingeneral.c (box_win): Check cli_styling.
9479         * tui/tui-winsource.c (tui_source_window_base::refill): Use
9480         deprecated_safe_get_selected_frame.
9481
9482 2020-01-10  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
9483
9484         * inferior.c (print_inferior): Switch inferior before printing it.
9485
9486 2020-01-10  Aleksandar Paunovic  <aleksandar.paunovic@intel.com>
9487             Pedro Alves  <palves@redhat.com>
9488
9489         * progspace-and-thread.c (switch_to_program_space_and_thread):
9490         Assert there's an inferior for PSPACE.  Use
9491         switch_to_inferior_no_thread to switch the inferior too.
9492         * progspace.c (program_space::~program_space): Call
9493         clear_symtab_users here, with SYMFILE_DEFER_BP_RESET.
9494         (program_space::free_all_objfiles): Don't call clear_symtab_users
9495         here.
9496         * symfile.c (symbol_file_clear): Call clear_symtab_users here.
9497
9498 2020-01-10  Pedro Alves  <palves@redhat.com>
9499
9500         * NEWS: Mention multi-target debugging, "info connections", and
9501         "add-inferior -no-connection".
9502
9503 2020-01-10  Pedro Alves  <palves@redhat.com>
9504
9505         * infrun.c: Include "target-connection.h".
9506         (check_multi_target_resumption): New.
9507         (proceed): Call it.
9508         * target-connection.c (make_target_connection_string): Make
9509         extern.
9510         * target-connection.h (make_target_connection_string): Declare.
9511
9512 2020-01-10  Pedro Alves  <palves@redhat.com>
9513
9514         * Makefile.in (COMMON_SFILES): Add target-connection.c.
9515         * inferior.c (uiout_field_connection): New function.
9516         (print_inferior): Add new "connection-id" column.
9517         (add_inferior_command): Show connection number/string of added
9518         inferior.
9519         * process-stratum-target.h
9520         (process_stratum_target::connection_string): New virtual method.
9521         (process_stratum_target::connection_number): New field.
9522         * remote.c (remote_target::connection_string): New override.
9523         * target-connection.c: New file.
9524         * target-connection.h: New file.
9525         * target.c (decref_target): Remove process_stratum targets from
9526         the connection list.
9527         (target_stack::push): Add process_stratum targets to the
9528         connection list.
9529
9530 2020-01-10  Pedro Alves  <palves@redhat.com>
9531
9532         Revert:
9533         2016-04-12  Pedro Alves  <palves@redhat.com>
9534         * serial.c (serial_open, serial_fdopen_ops, do_serial_close):
9535         Remove references to name.
9536         * serial.h (struct serial) <name>: Delete.
9537
9538 2020-01-10  Pedro Alves  <palves@redhat.com>
9539
9540         * gdbarch-selftests.c (register_to_value_test): Remove "target
9541         already pushed" check.
9542
9543 2020-01-10  Pedro Alves  <palves@redhat.com>
9544             John Baldwin  <jhb@FreeBSD.org>
9545
9546         * aarch64-linux-nat.c
9547         (aarch64_linux_nat_target::thread_architecture): Adjust.
9548         * ada-tasks.c (print_ada_task_info): Adjust find_thread_ptid call.
9549         (task_command_1): Likewise.
9550         * aix-thread.c (sync_threadlists, aix_thread_target::resume)
9551         (aix_thread_target::wait, aix_thread_target::fetch_registers)
9552         (aix_thread_target::store_registers)
9553         (aix_thread_target::thread_alive): Adjust.
9554         * amd64-fbsd-tdep.c: Include "inferior.h".
9555         (amd64fbsd_get_thread_local_address): Pass down target.
9556         * amd64-linux-nat.c (ps_get_thread_area): Use ps_prochandle
9557         thread's gdbarch instead of target_gdbarch.
9558         * break-catch-sig.c (signal_catchpoint_print_it): Adjust call to
9559         get_last_target_status.
9560         * break-catch-syscall.c (print_it_catch_syscall): Likewise.
9561         * breakpoint.c (breakpoints_should_be_inserted_now): Consider all
9562         inferiors.
9563         (update_inserted_breakpoint_locations): Skip if inferiors with no
9564         execution.
9565         (update_global_location_list): When handling moribund locations,
9566         find representative inferior for location's pspace, and use thread
9567         count of its process_stratum target.
9568         * bsd-kvm.c (bsd_kvm_target_open): Pass target down.
9569         * bsd-uthread.c (bsd_uthread_target::wait): Use
9570         as_process_stratum_target and adjust thread_change_ptid and
9571         add_thread calls.
9572         (bsd_uthread_target::update_thread_list): Use
9573         as_process_stratum_target and adjust find_thread_ptid,
9574         thread_change_ptid and add_thread calls.
9575         * btrace.c (maint_btrace_packet_history_cmd): Adjust
9576         find_thread_ptid call.
9577         * corelow.c (add_to_thread_list): Adjust add_thread call.
9578         (core_target_open): Adjust add_thread_silent and thread_count
9579         calls.
9580         (core_target::pid_to_str): Adjust find_inferior_ptid call.
9581         * ctf.c (ctf_target_open): Adjust add_thread_silent call.
9582         * event-top.c (async_disconnect): Pop targets from all inferiors.
9583         * exec.c (add_target_sections): Push exec target on all inferiors
9584         sharing the program space.
9585         (remove_target_sections): Remove the exec target from all
9586         inferiors sharing the program space.
9587         (exec_on_vfork): New.
9588         * exec.h (exec_on_vfork): Declare.
9589         * fbsd-nat.c (fbsd_add_threads): Add fbsd_nat_target parameter.
9590         Pass it down.
9591         (fbsd_nat_target::update_thread_list): Adjust.
9592         (fbsd_nat_target::resume): Adjust.
9593         (fbsd_handle_debug_trap): Add fbsd_nat_target parameter.  Pass it
9594         down.
9595         (fbsd_nat_target::wait, fbsd_nat_target::post_attach): Adjust.
9596         * fbsd-tdep.c (fbsd_corefile_thread): Adjust
9597         get_thread_arch_regcache call.
9598         * fork-child.c (gdb_startup_inferior): Pass target down to
9599         startup_inferior and set_executing.
9600         * gdbthread.h (struct process_stratum_target): Forward declare.
9601         (add_thread, add_thread_silent, add_thread_with_info)
9602         (in_thread_list): Add process_stratum_target parameter.
9603         (find_thread_ptid(inferior*, ptid_t)): New overload.
9604         (find_thread_ptid, thread_change_ptid): Add process_stratum_target
9605         parameter.
9606         (all_threads()): Delete overload.
9607         (all_threads, all_non_exited_threads): Add process_stratum_target
9608         parameter.
9609         (all_threads_safe): Use brace initialization.
9610         (thread_count): Add process_stratum_target parameter.
9611         (set_resumed, set_running, set_stop_requested, set_executing)
9612         (threads_are_executing, finish_thread_state): Add
9613         process_stratum_target parameter.
9614         (switch_to_thread): Use is_current_thread.
9615         * i386-fbsd-tdep.c: Include "inferior.h".
9616         (i386fbsd_get_thread_local_address): Pass down target.
9617         * i386-linux-nat.c (i386_linux_nat_target::low_resume): Adjust.
9618         * inf-child.c (inf_child_target::maybe_unpush_target): Remove
9619         have_inferiors check.
9620         * inf-ptrace.c (inf_ptrace_target::create_inferior)
9621         (inf_ptrace_target::attach): Adjust.
9622         * infcall.c (run_inferior_call): Adjust.
9623         * infcmd.c (run_command_1): Pass target to
9624         scoped_finish_thread_state.
9625         (proceed_thread_callback): Skip inferiors with no execution.
9626         (continue_command): Rename 'all_threads' local to avoid hiding
9627         'all_threads' function.  Adjust get_last_target_status call.
9628         (prepare_one_step): Adjust set_running call.
9629         (signal_command): Use user_visible_resume_target.  Compare thread
9630         pointers instead of inferior_ptid.
9631         (info_program_command): Adjust to pass down target.
9632         (attach_command): Mark target's 'thread_executing' flag.
9633         (stop_current_target_threads_ns): New, factored out from ...
9634         (interrupt_target_1): ... this.  Switch inferior before making
9635         target calls.
9636         * inferior-iter.h
9637         (struct all_inferiors_iterator, struct all_inferiors_range)
9638         (struct all_inferiors_safe_range)
9639         (struct all_non_exited_inferiors_range): Filter on
9640         process_stratum_target too.  Remove explicit.
9641         * inferior.c (inferior::inferior): Push dummy target on target
9642         stack.
9643         (find_inferior_pid, find_inferior_ptid, number_of_live_inferiors):
9644         Add process_stratum_target parameter, and pass it down.
9645         (have_live_inferiors): Adjust.
9646         (switch_to_inferior_and_push_target): New.
9647         (add_inferior_command, clone_inferior_command): Handle
9648         "-no-connection" parameter.  Use
9649         switch_to_inferior_and_push_target.
9650         (_initialize_inferior): Mention "-no-connection" option in
9651         the help of "add-inferior" and "clone-inferior" commands.
9652         * inferior.h: Include "process-stratum-target.h".
9653         (interrupt_target_1): Use bool.
9654         (struct inferior) <push_target, unpush_target, target_is_pushed,
9655         find_target_beneath, top_target, process_target, target_at,
9656         m_stack>: New.
9657         (discard_all_inferiors): Delete.
9658         (find_inferior_pid, find_inferior_ptid, number_of_live_inferiors)
9659         (all_inferiors, all_non_exited_inferiors): Add
9660         process_stratum_target parameter.
9661         * infrun.c: Include "gdb_select.h" and <unordered_map>.
9662         (target_last_proc_target): New global.
9663         (follow_fork_inferior): Push target on new inferior.  Pass target
9664         to add_thread_silent.  Call exec_on_vfork.  Handle target's
9665         reference count.
9666         (follow_fork): Adjust get_last_target_status call.  Also consider
9667         target.
9668         (follow_exec): Push target on new inferior.
9669         (struct execution_control_state) <target>: New field.
9670         (user_visible_resume_target): New.
9671         (do_target_resume): Call target_async.
9672         (resume_1): Set target's threads_executing flag.  Consider resume
9673         target.
9674         (commit_resume_all_targets): New.
9675         (proceed): Also consider resume target.  Skip threads of inferiors
9676         with no execution.  Commit resumtion in all targets.
9677         (start_remote): Pass current inferior to wait_for_inferior.
9678         (infrun_thread_stop_requested): Consider target as well.  Pass
9679         thread_info pointer to clear_inline_frame_state instead of ptid.
9680         (infrun_thread_thread_exit): Consider target as well.
9681         (random_pending_event_thread): New inferior parameter.  Use it.
9682         (do_target_wait): Rename to ...
9683         (do_target_wait_1): ... this.  Add inferior parameter, and pass it
9684         down.
9685         (threads_are_resumed_pending_p, do_target_wait): New.
9686         (prepare_for_detach): Adjust calls.
9687         (wait_for_inferior): New inferior parameter.  Handle it.  Use
9688         do_target_wait_1 instead of do_target_wait.
9689         (fetch_inferior_event): Adjust.  Switch to representative
9690         inferior.  Pass target down.
9691         (set_last_target_status): Add process_stratum_target parameter.
9692         Save target in global.
9693         (get_last_target_status): Add process_stratum_target parameter and
9694         handle it.
9695         (nullify_last_target_wait_ptid): Clear 'target_last_proc_target'.
9696         (context_switch): Check inferior_ptid == null_ptid before calling
9697         inferior_thread().
9698         (get_inferior_stop_soon): Pass down target.
9699         (wait_one): Rename to ...
9700         (poll_one_curr_target): ... this.
9701         (struct wait_one_event): New.
9702         (wait_one): New.
9703         (stop_all_threads): Adjust.
9704         (handle_no_resumed, handle_inferior_event): Adjust to consider the
9705         event's target.
9706         (switch_back_to_stepped_thread): Also consider target.
9707         (print_stop_event): Update.
9708         (normal_stop): Update.  Also consider the resume target.
9709         * infrun.h (wait_for_inferior): Remove declaration.
9710         (user_visible_resume_target): New declaration.
9711         (get_last_target_status, set_last_target_status): New
9712         process_stratum_target parameter.
9713         * inline-frame.c (clear_inline_frame_state(ptid_t)): Add
9714         process_stratum_target parameter, and use it.
9715         (clear_inline_frame_state (thread_info*)): New.
9716         * inline-frame.c (clear_inline_frame_state(ptid_t)): Add
9717         process_stratum_target parameter.
9718         (clear_inline_frame_state (thread_info*)): Declare.
9719         * linux-fork.c (delete_checkpoint_command): Pass target down to
9720         find_thread_ptid.
9721         (checkpoint_command): Adjust.
9722         * linux-nat.c (linux_nat_target::follow_fork): Switch to thread
9723         instead of just tweaking inferior_ptid.
9724         (linux_nat_switch_fork): Pass target down to thread_change_ptid.
9725         (exit_lwp): Pass target down to find_thread_ptid.
9726         (attach_proc_task_lwp_callback): Pass target down to
9727         add_thread/set_running/set_executing.
9728         (linux_nat_target::attach): Pass target down to
9729         thread_change_ptid.
9730         (get_detach_signal): Pass target down to find_thread_ptid.
9731         Consider last target status's target.
9732         (linux_resume_one_lwp_throw, resume_lwp)
9733         (linux_handle_syscall_trap, linux_handle_extended_wait, wait_lwp)
9734         (stop_wait_callback, save_stop_reason, linux_nat_filter_event)
9735         (linux_nat_wait_1, resume_stopped_resumed_lwps): Pass target down.
9736         (linux_nat_target::async_wait_fd): New.
9737         (linux_nat_stop_lwp, linux_nat_target::thread_address_space): Pass
9738         target down.
9739         * linux-nat.h (linux_nat_target::async_wait_fd): Declare.
9740         * linux-tdep.c (get_thread_arch_regcache): Pass target down.
9741         * linux-thread-db.c (struct thread_db_info::process_target): New
9742         field.
9743         (add_thread_db_info): Save target.
9744         (get_thread_db_info): New process_stratum_target parameter.  Also
9745         match target.
9746         (delete_thread_db_info): New process_stratum_target parameter.
9747         Also match target.
9748         (thread_from_lwp): Adjust to pass down target.
9749         (thread_db_notice_clone): Pass down target.
9750         (check_thread_db_callback): Pass down target.
9751         (try_thread_db_load_1): Always push the thread_db target.
9752         (try_thread_db_load, record_thread): Pass target down.
9753         (thread_db_target::detach): Pass target down.  Always unpush the
9754         thread_db target.
9755         (thread_db_target::wait, thread_db_target::mourn_inferior): Pass
9756         target down.  Always unpush the thread_db target.
9757         (find_new_threads_callback, thread_db_find_new_threads_2)
9758         (thread_db_target::update_thread_list): Pass target down.
9759         (thread_db_target::pid_to_str): Pass current inferior down.
9760         (thread_db_target::get_thread_local_address): Pass target down.
9761         (thread_db_target::resume, maintenance_check_libthread_db): Pass
9762         target down.
9763         * nto-procfs.c (nto_procfs_target::update_thread_list): Adjust.
9764         * procfs.c (procfs_target::procfs_init_inferior): Declare.
9765         (proc_set_current_signal, do_attach, procfs_target::wait): Adjust.
9766         (procfs_init_inferior): Rename to ...
9767         (procfs_target::procfs_init_inferior): ... this and adjust.
9768         (procfs_target::create_inferior, procfs_notice_thread)
9769         (procfs_do_thread_registers): Adjust.
9770         * ppc-fbsd-tdep.c: Include "inferior.h".
9771         (ppcfbsd_get_thread_local_address): Pass down target.
9772         * proc-service.c (ps_xfer_memory): Switch current inferior and
9773         program space as well.
9774         (get_ps_regcache): Pass target down.
9775         * process-stratum-target.c
9776         (process_stratum_target::thread_address_space)
9777         (process_stratum_target::thread_architecture): Pass target down.
9778         * process-stratum-target.h
9779         (process_stratum_target::threads_executing): New field.
9780         (as_process_stratum_target): New.
9781         * ravenscar-thread.c
9782         (ravenscar_thread_target::update_inferior_ptid): Pass target down.
9783         (ravenscar_thread_target::wait, ravenscar_add_thread): Pass target
9784         down.
9785         * record-btrace.c (record_btrace_target::info_record): Adjust.
9786         (record_btrace_target::record_method)
9787         (record_btrace_target::record_is_replaying)
9788         (record_btrace_target::fetch_registers)
9789         (get_thread_current_frame_id, record_btrace_target::resume)
9790         (record_btrace_target::wait, record_btrace_target::stop): Pass
9791         target down.
9792         * record-full.c (record_full_wait_1): Switch to event thread.
9793         Pass target down.
9794         * regcache.c (regcache::regcache)
9795         (get_thread_arch_aspace_regcache, get_thread_arch_regcache): Add
9796         process_stratum_target parameter and handle it.
9797         (current_thread_target): New global.
9798         (get_thread_regcache): Add process_stratum_target parameter and
9799         handle it.  Switch inferior before calling target method.
9800         (get_thread_regcache): Pass target down.
9801         (get_thread_regcache_for_ptid): Pass target down.
9802         (registers_changed_ptid): Add process_stratum_target parameter and
9803         handle it.
9804         (registers_changed_thread, registers_changed): Pass target down.
9805         (test_get_thread_arch_aspace_regcache): New.
9806         (current_regcache_test): Define a couple local test_target_ops
9807         instances and use them for testing.
9808         (readwrite_regcache): Pass process_stratum_target parameter.
9809         (cooked_read_test, cooked_write_test): Pass mock_target down.
9810         * regcache.h (get_thread_regcache, get_thread_arch_regcache)
9811         (get_thread_arch_aspace_regcache): Add process_stratum_target
9812         parameter.
9813         (regcache::target): New method.
9814         (regcache::regcache, regcache::get_thread_arch_aspace_regcache)
9815         (regcache::registers_changed_ptid): Add process_stratum_target
9816         parameter.
9817         (regcache::m_target): New field.
9818         (registers_changed_ptid): Add process_stratum_target parameter.
9819         * remote.c (remote_state::supports_vCont_probed): New field.
9820         (remote_target::async_wait_fd): New method.
9821         (remote_unpush_and_throw): Add remote_target parameter.
9822         (get_current_remote_target): Adjust.
9823         (remote_target::remote_add_inferior): Push target.
9824         (remote_target::remote_add_thread)
9825         (remote_target::remote_notice_new_inferior)
9826         (get_remote_thread_info): Pass target down.
9827         (remote_target::update_thread_list): Skip threads of inferiors
9828         bound to other targets.  (remote_target::close): Don't discard
9829         inferiors.  (remote_target::add_current_inferior_and_thread)
9830         (remote_target::process_initial_stop_replies)
9831         (remote_target::start_remote)
9832         (remote_target::remote_serial_quit_handler): Pass down target.
9833         (remote_target::remote_unpush_target): New remote_target
9834         parameter.  Unpush the target from all inferiors.
9835         (remote_target::remote_unpush_and_throw): New remote_target
9836         parameter.  Pass it down.
9837         (remote_target::open_1): Check whether the current inferior has
9838         execution instead of checking whether any inferior is live.  Pass
9839         target down.
9840         (remote_target::remote_detach_1): Pass down target.  Use
9841         remote_unpush_target.
9842         (extended_remote_target::attach): Pass down target.
9843         (remote_target::remote_vcont_probe): Set supports_vCont_probed.
9844         (remote_target::append_resumption): Pass down target.
9845         (remote_target::append_pending_thread_resumptions)
9846         (remote_target::remote_resume_with_hc, remote_target::resume)
9847         (remote_target::commit_resume): Pass down target.
9848         (remote_target::remote_stop_ns): Check supports_vCont_probed.
9849         (remote_target::interrupt_query)
9850         (remote_target::remove_new_fork_children)
9851         (remote_target::check_pending_events_prevent_wildcard_vcont)
9852         (remote_target::remote_parse_stop_reply)
9853         (remote_target::process_stop_reply): Pass down target.
9854         (first_remote_resumed_thread): New remote_target parameter.  Pass
9855         it down.
9856         (remote_target::wait_as): Pass down target.
9857         (unpush_and_perror): New remote_target parameter.  Pass it down.
9858         (remote_target::readchar, remote_target::remote_serial_write)
9859         (remote_target::getpkt_or_notif_sane_1)
9860         (remote_target::kill_new_fork_children, remote_target::kill): Pass
9861         down target.
9862         (remote_target::mourn_inferior): Pass down target.  Use
9863         remote_unpush_target.
9864         (remote_target::core_of_thread)
9865         (remote_target::remote_btrace_maybe_reopen): Pass down target.
9866         (remote_target::pid_to_exec_file)
9867         (remote_target::thread_handle_to_thread_info): Pass down target.
9868         (remote_target::async_wait_fd): New.
9869         * riscv-fbsd-tdep.c: Include "inferior.h".
9870         (riscv_fbsd_get_thread_local_address): Pass down target.
9871         * sol2-tdep.c (sol2_core_pid_to_str): Pass down target.
9872         * sol-thread.c (sol_thread_target::wait, ps_lgetregs, ps_lsetregs)
9873         (ps_lgetfpregs, ps_lsetfpregs, sol_update_thread_list_callback):
9874         Adjust.
9875         * solib-spu.c (spu_skip_standalone_loader): Pass down target.
9876         * solib-svr4.c (enable_break): Pass down target.
9877         * spu-multiarch.c (parse_spufs_run): Pass down target.
9878         * spu-tdep.c (spu2ppu_sniffer): Pass down target.
9879         * target-delegates.c: Regenerate.
9880         * target.c (g_target_stack): Delete.
9881         (current_top_target): Return the current inferior's top target.
9882         (target_has_execution_1): Refer to the passed-in inferior's top
9883         target.
9884         (target_supports_terminal_ours): Check whether the initial
9885         inferior was already created.
9886         (decref_target): New.
9887         (target_stack::push): Incref/decref the target.
9888         (push_target, push_target, unpush_target): Adjust.
9889         (target_stack::unpush): Defref target.
9890         (target_is_pushed): Return bool.  Adjust to refer to the current
9891         inferior's target stack.
9892         (dispose_inferior): Delete, and inline parts ...
9893         (target_preopen): ... here.  Only dispose of the current inferior.
9894         (target_detach): Hold strong target reference while detaching.
9895         Pass target down.
9896         (target_thread_name): Add assertion.
9897         (target_resume): Pass down target.
9898         (target_ops::beneath, find_target_at): Adjust to refer to the
9899         current inferior's target stack.
9900         (get_dummy_target): New.
9901         (target_pass_ctrlc): Pass the Ctrl-C to the first inferior that
9902         has a thread running.
9903         (initialize_targets): Rename to ...
9904         (_initialize_target): ... this.
9905         * target.h: Include "gdbsupport/refcounted-object.h".
9906         (struct target_ops): Inherit refcounted_object.
9907         (target_ops::shortname, target_ops::longname): Make const.
9908         (target_ops::async_wait_fd): New method.
9909         (decref_target): Declare.
9910         (struct target_ops_ref_policy): New.
9911         (target_ops_ref): New typedef.
9912         (get_dummy_target): Declare function.
9913         (target_is_pushed): Return bool.
9914         * thread-iter.c (all_matching_threads_iterator::m_inf_matches)
9915         (all_matching_threads_iterator::all_matching_threads_iterator):
9916         Handle filter target.
9917         * thread-iter.h (struct all_matching_threads_iterator, struct
9918         all_matching_threads_range, class all_non_exited_threads_range):
9919         Filter by target too.  Remove explicit.
9920         * thread.c (threads_executing): Delete.
9921         (inferior_thread): Pass down current inferior.
9922         (clear_thread_inferior_resources): Pass down thread pointer
9923         instead of ptid_t.
9924         (add_thread_silent, add_thread_with_info, add_thread): Add
9925         process_stratum_target parameter.  Use it for thread and inferior
9926         searches.
9927         (is_current_thread): New.
9928         (thread_info::deletable): Use it.
9929         (find_thread_ptid, thread_count, in_thread_list)
9930         (thread_change_ptid, set_resumed, set_running): New
9931         process_stratum_target parameter.  Pass it down.
9932         (set_executing): New process_stratum_target parameter.  Pass it
9933         down.  Adjust reference to 'threads_executing'.
9934         (threads_are_executing): New process_stratum_target parameter.
9935         Adjust reference to 'threads_executing'.
9936         (set_stop_requested, finish_thread_state): New
9937         process_stratum_target parameter.  Pass it down.
9938         (switch_to_thread): Also match inferior.
9939         (switch_to_thread): New process_stratum_target parameter.  Pass it
9940         down.
9941         (update_threads_executing): Reimplement.
9942         * top.c (quit_force): Pop targets from all inferior.
9943         (gdb_init): Don't call initialize_targets.
9944         * windows-nat.c (windows_nat_target) <get_windows_debug_event>:
9945         Declare.
9946         (windows_add_thread, windows_delete_thread): Adjust.
9947         (get_windows_debug_event): Rename to ...
9948         (windows_nat_target::get_windows_debug_event): ... this.  Adjust.
9949         * tracefile-tfile.c (tfile_target_open): Pass down target.
9950         * gdbsupport/common-gdbthread.h (struct process_stratum_target):
9951         Forward declare.
9952         (switch_to_thread): Add process_stratum_target parameter.
9953         * mi/mi-interp.c (mi_on_resume_1): Add process_stratum_target
9954         parameter.  Use it.
9955         (mi_on_resume): Pass target down.
9956         * nat/fork-inferior.c (startup_inferior): Add
9957         process_stratum_target parameter.  Pass it down.
9958         * nat/fork-inferior.h (startup_inferior): Add
9959         process_stratum_target parameter.
9960         * python/py-threadevent.c (py_get_event_thread): Pass target down.
9961
9962 2020-01-10  Pedro Alves  <palves@redhat.com>
9963
9964         * remote.c (remote_target::start_remote): Don't set inferior_ptid
9965         directly.  Instead find the first thread in the thread list and
9966         use switch_to_thread.
9967
9968 2020-01-10  Pedro Alves  <palves@redhat.com>
9969
9970         * remote.c (remote_target::remote_add_inferior): Don't bind a
9971         process to the current inferior if the current inferior is already
9972         bound to a process.
9973
9974 2020-01-10  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
9975             Pedro Alves  <palves@redhat.com>
9976
9977         * remote.c (remote_target::remote_parse_stop_reply) <W/X packets>:
9978         If no process is specified, return null_ptid instead of
9979         inferior_ptid.
9980         (remote_target::wait_as): Handle TARGET_WAITKIND_EXITED /
9981         TARGET_WAITKIND_SIGNALLED with no pid.
9982
9983 2020-01-10  Pedro Alves  <palves@redhat.com>
9984
9985         * remote.c (first_remote_resumed_thread): New.
9986         (remote_target::wait_as): Use it as default event_ptid instead of
9987         inferior_ptid.
9988
9989 2020-01-10  Pedro Alves  <palves@redhat.com>
9990
9991         * infrun.c (handle_no_resumed): Use all_non_exited_inferiors.
9992
9993 2020-01-10  Pedro Alves  <palves@redhat.com>
9994
9995         * tracefile-tfile.c (tfile_target::close): Assert that trace_fd is
9996         not -1.
9997
9998 2020-01-10  Pedro Alves  <palves@redhat.com>
9999
10000         * break-catch-sig.c (signal_catchpoint_print_it): Don't pass a
10001         ptid to get_last_target_status.
10002         * break-catch-syscall.c (print_it_catch_syscall): Don't pass a
10003         ptid to get_last_target_status.
10004         * infcmd.c (continue_command): Don't pass a target_waitstatus to
10005         get_last_target_status.
10006         (info_program_command): Don't pass a target_waitstatus to
10007         get_last_target_status.
10008         * infrun.c (init_wait_for_inferior): Use
10009         nullify_last_target_wait_ptid.
10010         (get_last_target_status): Handle nullptr arguments.
10011         (nullify_last_target_wait_ptid): Clear target_last_waitstatus.
10012         (print_stop_event): Don't pass a ptid to get_last_target_status.
10013         (normal_stop): Don't pass a ptid to get_last_target_status.
10014         * infrun.h (get_last_target_status, set_last_target_status): Move
10015         comments here and update.
10016         (nullify_last_target_wait_ptid): Declare.
10017         * linux-fork.c (fork_load_infrun_state): Remove local extern
10018         declaration of nullify_last_target_wait_ptid.
10019         * linux-nat.c (get_detach_signal): Don't pass a target_waitstatus
10020         to get_last_target_status.
10021
10022 2020-01-10  Pedro Alves  <palves@redhat.com>
10023
10024         * gdbthread.h (scoped_restore_current_thread)
10025         <dont_restore, restore, m_dont_restore>: Declare.
10026         * thread.c (thread_alive): Add assertion.  Return bool.
10027         (switch_to_thread_if_alive): New.
10028         (prune_threads): Switch inferior/thread.
10029         (print_thread_info_1): Switch thread before calling target methods.
10030         (scoped_restore_current_thread::restore): New, factored out from
10031         ...
10032         (scoped_restore_current_thread::~scoped_restore_current_thread):
10033         ... this.
10034         (scoped_restore_current_thread::scoped_restore_current_thread):
10035         Add assertion.
10036         (thread_apply_all_command, thread_select): Use
10037         switch_to_thread_if_alive.
10038         * infrun.c (proceed, restart_threads, handle_signal_stop)
10039         (switch_back_to_stepped_thread): Switch current thread before
10040         calling target methods.
10041
10042 2020-01-10  Pedro Alves <palves@redhat.com>
10043
10044         * inferior.c (switch_to_inferior_no_thread): New function,
10045         factored out from ...
10046         (inferior_command): ... here.
10047         * inferior.h (switch_to_inferior_no_thread): Declare.
10048         * mi/mi-main.c (run_one_inferior): Use
10049         switch_to_inferior_no_thread.
10050
10051 2020-01-10  Pedro Alves  <palves@redhat.com>
10052
10053         * infcmd.c (kill_command): Remove dead code.
10054
10055 2020-01-10  Pedro Alves  <palves@redhat.com>
10056
10057         * remote.c (remote_target::mourn_inferior): No longer check
10058         whether the target is running.
10059
10060 2020-01-10  Pedro Alves  <palves@redhat.com>
10061
10062         * corelow.c (core_target::has_execution): Change parameter type to
10063         inferior pointer.
10064         * inferior.c (number_of_live_inferiors): Use
10065         inferior::has_execution instead of target_has_execution_1.
10066         * inferior.h (inferior::has_execution): New.
10067         * linux-thread-db.c (thread_db_target::update_thread_list): Use
10068         inferior::has_execution instead of target_has_execution_1.
10069         * process-stratum-target.c
10070         (process_stratum_target::has_execution): Change parameter type to
10071         inferior pointer.  Check the inferior's PID instead of
10072         inferior_ptid.
10073         * process-stratum-target.h
10074         (process_stratum_target::has_execution): Change parameter type to
10075         inferior pointer.
10076         * record-full.c (record_full_core_target::has_execution): Change
10077         parameter type to inferior pointer.
10078         * target.c (target_has_execution_1): Change parameter type to
10079         inferior pointer.
10080         (target_has_execution_current): Adjust.
10081         * target.h (target_ops::has_execution): Change parameter type to
10082         inferior pointer.
10083         (target_has_execution_1): Change parameter type to inferior
10084         pointer.  Change return type to bool.
10085         * tracefile.h (tracefile_target::has_execution): Change parameter
10086         type to inferior pointer.
10087
10088 2020-01-10  Pedro Alves  <palves@redhat.com>
10089
10090         * exceptions.c (print_flush): Remove current_top_target() check.
10091
10092 2020-01-10  Pedro Alves  <palves@redhat.com>
10093
10094         * remote.c (show_remote_exec_file): Show the current inferior's
10095         exec-file instead of the command variable's value.
10096
10097 2020-01-10  Pedro Alves  <palves@redhat.com>
10098
10099         * record-full.c (record_full_resume_ptid): New global.
10100         (record_full_target::resume): Set it.
10101         (record_full_wait_1): Use record_full_resume_ptid instead of
10102         inferior_ptid.
10103
10104 2020-01-10  Pedro Alves  <palves@redhat.com>
10105
10106         * gdbthread.h (scoped_restore_current_thread)
10107         <dont_restore, restore, m_dont_restore>: Declare.
10108         * thread.c (thread_alive): Add assertion.  Return bool.
10109         (switch_to_thread_if_alive): New.
10110         (prune_threads): Switch inferior/thread.
10111         (print_thread_info_1): Switch thread before calling target methods.
10112         (scoped_restore_current_thread::restore): New, factored out from
10113         ...
10114         (scoped_restore_current_thread::~scoped_restore_current_thread):
10115         ... this.
10116         (scoped_restore_current_thread::scoped_restore_current_thread):
10117         Add assertion.
10118         (thread_apply_all_command, thread_select): Use
10119         switch_to_thread_if_alive.
10120
10121 2020-01-10  George Barrett  <bob@bob131.so>
10122
10123         * stap-probe.c (stap_modify_semaphore): Don't check for null
10124         semaphores.
10125         (stap_probe::set_semaphore, stap_probe::clear_semaphore): Check
10126         for null semaphores.
10127
10128 2020-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
10129
10130         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Update
10131         all source windows, and maintain horizontal scroll status while
10132         doing so.
10133
10134 2020-01-09  Tom Tromey  <tom@tromey.com>
10135
10136         PR tui/18932:
10137         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Call
10138         update_source_window, not print_source_lines.
10139
10140 2020-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
10141
10142         * tui/tui.c (tui_enable): Register tui hooks after calling
10143         tui_display_main.
10144
10145 2020-01-09  Christian Biesinger  <cbiesinger@google.com>
10146
10147         * gdbsupport/common-defs.h: Don't define _FORTIFY_SOURCE on MinGW.
10148
10149 2020-01-08  Simon Marchi  <simon.marchi@efficios.com>
10150
10151         * thread.c (print_thread_info_1): Fix indentation.
10152
10153 2020-01-09  Christian Biesinger  <cbiesinger@google.com>
10154
10155         * symtab.c (general_symbol_info::compute_and_set_names): Move the
10156         unique_xmalloc_ptr outside the if to always free the demangled name.
10157
10158 2020-01-08  Tom Tromey  <tromey@adacore.com>
10159
10160         * xcoffread.c (enter_line_range, read_xcoff_symtab)
10161         (process_xcoff_symbol, xcoff_symfile_offsets): Update.
10162         * symtab.h (MSYMBOL_VALUE_ADDRESS): Update.
10163         (struct section_offsets, ANOFFSET, SIZEOF_N_SECTION_OFFSETS):
10164         Remove.
10165         (section_offsets): New typedef.
10166         * symtab.c (fixup_section, get_msymbol_address): Update.
10167         * symmisc.c (dump_msymbols): Update.
10168         * symfile.h (relative_addr_info_to_section_offsets)
10169         (symfile_map_offsets_to_segments): Update.
10170         * symfile.c (build_section_addr_info_from_objfile)
10171         (init_objfile_sect_indices): Update.
10172         (struct place_section_arg): Change type of "offsets".
10173         (place_section): Update.
10174         (relative_addr_info_to_section_offsets): Change type of
10175         "section_offsets".  Remove "num_sections" parameter.
10176         (default_symfile_offsets, syms_from_objfile_1)
10177         (set_objfile_default_section_offset): Update.
10178         (reread_symbols): No need to preserve section offsets by hand.
10179         (symfile_map_offsets_to_segments): Change type of "offsets".
10180         * stap-probe.c (relocate_address): Update.
10181         * stabsread.h (process_one_symbol): Update.
10182         * solib-target.c (struct lm_info_target) <offsets>: Change type.
10183         (solib_target_relocate_section_addresses): Update.
10184         * solib-svr4.c (enable_break, svr4_relocate_main_executable):
10185         Update.
10186         * solib-frv.c (frv_relocate_main_executable): Update.
10187         * solib-dsbt.c (dsbt_relocate_main_executable): Update.
10188         * solib-aix.c (solib_aix_get_section_offsets): Change return
10189         type.
10190         (solib_aix_solib_create_inferior_hook): Update.
10191         * remote.c (remote_target::get_offsets): Update.
10192         * psymtab.c (find_pc_sect_psymtab): Update.
10193         * psympriv.h (struct partial_symbol) <address, text_low,
10194         text_high>: Update.
10195         * objfiles.h (obj_section_offset): Update.
10196         (struct objfile) <section_offsets>: Change type.
10197         <num_sections>: Remove.
10198         (objfile_relocate): Update.
10199         * objfiles.c (entry_point_address_query): Update
10200         (relocate_one_symbol): Change type of "section_offsets".
10201         (objfile_relocate1, objfile_relocate1): Change type of
10202         "new_offsets".
10203         (objfile_rebase1): Update.
10204         * mipsread.c (mipscoff_symfile_read): Update.
10205         (read_alphacoff_dynamic_symtab): Remove "section_offsets"
10206         parameter.
10207         * mdebugread.c (parse_symbol): Change type of "section_offsets".
10208         (parse_external, psymtab_to_symtab_1): Update.
10209         * machoread.c (macho_symfile_offsets): Update.
10210         * ia64-tdep.c (ia64_find_unwind_table): Update.
10211         * hppa-tdep.c (read_unwind_info): Update.
10212         * hppa-bsd-tdep.c (hppabsd_find_global_pointer): Update.
10213         * dwarf2read.c (create_addrmap_from_index)
10214         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
10215         (process_psymtab_comp_unit_reader, add_partial_symbol)
10216         (add_partial_subprogram, process_full_comp_unit)
10217         (read_file_scope, read_func_scope, read_lexical_block_scope)
10218         (read_call_site_scope, dwarf2_rnglists_process)
10219         (dwarf2_ranges_process, dwarf2_ranges_read)
10220         (dwarf_decode_lines_1, var_decode_location, new_symbol)
10221         (dwarf2_fetch_die_loc_sect_off, dwarf2_per_cu_text_offset):
10222         Update.
10223         * dwarf2-frame.c (execute_cfa_program, dwarf2_frame_find_fde):
10224         Update.
10225         * dtrace-probe.c (dtrace_probe::get_relocated_address): Update.
10226         * dbxread.c (read_dbx_symtab, read_ofile_symtab): Update.
10227         (process_one_symbol): Change type of "section_offsets".
10228         * ctfread.c (get_objfile_text_range): Update.
10229         * coffread.c (coff_symtab_read, enter_linenos)
10230         (process_coff_symbol): Update.
10231         * coff-pe-read.c (add_pe_forwarded_sym): Update.
10232         * amd64-windows-tdep.c (amd64_windows_find_unwind_info): Update.
10233
10234 2020-01-08  Tom Tromey  <tromey@adacore.com>
10235
10236         * dwarf2read.c (parse_macro_definition): Use std::string.
10237         (parse_macro_definition): Likewise.
10238
10239 2020-01-08  Tom Tromey  <tromey@adacore.com>
10240
10241         * dwarf2read.c (abbrev_table_read_table): Use std::vector.
10242         (ATTR_ALLOC_CHUNK): Remove.
10243
10244 2020-01-08  Tom Tromey  <tromey@adacore.com>
10245
10246         * dwarf2read.c (fixup_go_packaging): Use unique_xmalloc_ptr.
10247
10248 2020-01-08  Tom Tromey  <tromey@adacore.com>
10249
10250         * dwarf2read.c (add_partial_symbol): Use unique_xmalloc_ptr.
10251         (dwarf2_compute_name, open_dwo_file): Likewise.
10252         (process_enumeration_scope): Use std::vector.
10253         (guess_partial_die_structure_name): Use unique_xmalloc_ptr.
10254         (partial_die_info::fixup, dwarf2_start_subfile)
10255         (guess_full_die_structure_name, dwarf2_name): Likewise.
10256         (determine_prefix): Update.
10257         (guess_full_die_structure_name): Make return type const.
10258         (partial_die_full_name): Return unique_xmalloc_ptr.
10259         (DW_FIELD_ALLOC_CHUNK): Remove.
10260
10261 2020-01-07  Tom Tromey  <tromey@adacore.com>
10262
10263         PR build/24937:
10264         * stap-probe.c (class stap_static_probe_ops): Add constructor.
10265
10266 2020-01-02  Jon Turney  <jon.turney@dronecode.org.uk>
10267
10268         * cli/cli-style.c: Set cli_styling to 'true' in the Cygwin build.
10269
10270 2020-01-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10271
10272         * stack.c (print_frame_info): Move disassemble_next_line code
10273         inside source_print block.
10274
10275 2020-01-06  Eli Zaretskii  <eliz@gnu.org>
10276
10277         * gdbsupport/gdb_wait.c: Include <signal.h> instead of
10278         gdb/signals.h, as we are now using native signal symbols.
10279
10280 2020-01-06  Shahab Vahedi  <shahab@synopsys.com>
10281
10282         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): Avoid
10283         overflow by an early check of content vs threshold.
10284         * tui/tui-source.c (tui_source_window::line_is_displayed):
10285         Likewise.
10286
10287 2020-01-06  Eli Zaretskii  <eliz@gnu.org>
10288
10289         * NEWS: Mention the recent fix of $_exitsignal on MS-Windows.
10290
10291 2020-01-02  Jon Turney  <jon.turney@dronecode.org.uk>
10292
10293         * coff-pe-read.c (read_pe_exported_syms): Don't try to read the
10294         export table if no section contains it's RVA.
10295
10296 2020-01-06  Eli Zaretskii  <eliz@gnu.org>
10297
10298         * windows-tdep.c: Fix a typo in WINDOWS_SIGABRT.
10299
10300 2020-01-06  Hannes Domani  <ssbssa@yahoo.de>
10301
10302         * source.c (print_source_lines_base): Set last_line_listed.
10303
10304 2020-01-06  Shahab Vahedi  <shahab@synopsys.com>
10305
10306         * tui/tui-disasm.c: Remove trailing spaces.
10307
10308 2020-01-06  Eli Zaretskii  <eliz@gnu.org>
10309             Pedro Alves  <palves@redhat.com>
10310
10311         * Makefile.in (COMMON_SFILES): Add gdbsupport/gdb_wait.c.
10312         * windows-tdep.c: New enumeration of WINDOWS_SIG* signals.
10313         (windows_gdb_signal_to_target): New function, uses the above
10314         enumeration to convert GDB internal signal codes to equivalent
10315         Windows codes.
10316         (windows_init_abi): Call set_gdbarch_gdb_signal_to_target.
10317         * windows-nat.c: Include "gdb_wait.h".
10318         (get_windows_debug_event): Extract the fatal exception from the
10319         exit status and convert to the equivalent Posix signal number.
10320         * cli/cli-cmds.c (exit_status_set_internal_vars): Account for the
10321         possibility that WTERMSIG returns GDB_SIGNAL_UNKNOWN.
10322         * gdbsupport/gdb_wait.c: New file, implements
10323         windows_status_to_termsig.
10324         * gdbsupport/gdb_wait.h (WIFEXITED, WIFSIGNALED, WEXITSTATUS)
10325         (WTERMSIG) [__MINGW32__]: Separate definitions for MinGW.
10326
10327 2020-01-05  Andrew Burgess  <andrew.burgess@embecosm.com>
10328
10329         * tui/tui-layout.c (tui_add_win_to_layout): Use tui_set_layout not
10330         show_layout.
10331
10332 2020-01-05  Luis Machado  <luis.machado@linaro.org>
10333
10334         * aarch64-linux-nat.c
10335         (aarch64_linux_nat_target::thread_architecture): Use bfd_arch_aarch64
10336         and bfd_mach_aarch64.
10337
10338 2020-01-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10339
10340         * ui-file.c (stdio_file::can_emit_style_escape)
10341         (tee_file::can_emit_style_escape): Ensure style is used also on
10342         gdb_stderr when gdb_stderr is a tty supporting styling, similarly
10343         to gdb_stdout.
10344         * main.c (set_gdb_data_directory): Use file style to output the
10345         warning that the given pathname is not a directory.
10346         * top.c (show_history_filename, gdb_safe_append_history)
10347         (show_gdb_datadir): Use file style.
10348
10349 2020-01-03  Hannes Domani  <ssbssa@yahoo.de>
10350
10351         * solib-target.c (struct lm_info_target):
10352         Change offsets to be a unique_xmalloc_ptr.
10353         (solib_target_relocate_section_addresses): Update.
10354
10355 2020-01-03  Hannes Domani  <ssbssa@yahoo.de>
10356
10357         * windows-nat.c (windows_clear_solib): Free so_list linked list.
10358
10359 2020-01-03  Bernd Edlinger  <bernd.edlinger@hotmail.de>
10360
10361         * MAINTAINERS (Write After Approval): Add myself.
10362
10363 2020-01-02  Luis Machado  <luis.machado@linaro.org>
10364
10365         * proc-service.c (get_ps_regcache): Remove reference to obsolete
10366         Cell BE architecture.
10367         * target.h (struct target_ops) <thread_architecture>: Likewise.
10368
10369 2020-01-01  Hannes Domani  <ssbssa@yahoo.de>
10370
10371         * Makefile.in: Use INSTALL_PROGRAM_ENV.
10372
10373 2020-01-01  Hannes Domani  <ssbssa@yahoo.de>
10374
10375         * MAINTAINERS (Write After Approval): Add myself.
10376
10377 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
10378
10379         * gdbarch.sh: Update copyright year range of generated files.
10380
10381 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
10382
10383         Update copyright year range in all GDB files.
10384
10385 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
10386
10387         * copyright.py: Convert to Python 3.
10388
10389 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
10390
10391         * copyright.py: Adapt after move of gnulib directory from gdb
10392         directory to toplevel directory.
10393
10394 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
10395
10396         * copyright.py (main): Exit if run from the wrong directory.
10397
10398 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
10399
10400         * top.c (print_gdb_version): Change copyright year to 2020.
10401
10402 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
10403
10404         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2019.
10405
10406 For older changes see ChangeLog-2019.
10407 \f
10408 Local Variables:
10409 mode: change-log
10410 left-margin: 8
10411 fill-column: 74
10412 version-control: never
10413 coding: utf-8
10414 End: