gdb/ChangeLog

   1 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
   2
   3         * arm-tdep.c (arm_skip_cmse_entry): New function.
   4         (arm_is_sgstubs_section): New function.
   5         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
   6
   7 2019-07-22  Tom Tromey  <tom@tromey.com>
   8
   9         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
  10         Don't self-assign.
  11
  12 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
  13
  14         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
  15         type_print.
  16
  17 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
  18
  19         * symtab.c (search_symbols): Adjust msymbol matching type arrays
  20         so that GDB doesn't match any msymbols when searching in the
  21         TYPES_DOMAIN.
  22         (print_symbol_info): Print using typedef_print or type_print based
  23         on the type of the symbol.  Add updated FIXME comment moved from...
  24         (_initialize_symtab): ... move and update FIXME comment to above.
  25
  26 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
  27
  28         * NEWS: Mention adding -q option to "info types".
  29         * symtab.c (struct info_types_options): New struct.
  30         (info_types_options_defs): New variable.
  31         (make_info_types_options_def_group): New function.
  32         (info_types_command): Use gdb::option framework to parse options.
  33         (info_types_command_completer): New function.
  34         (_initialize_symtab): Extend the help text on "info types" and
  35         register command completer.
  36
  37 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
  38
  39         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
  40         (lookup_symbol_in_objfile): Change int to block_enum and add a
  41         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
  42
  43 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
  44
  45         * MAINTAINERS (Write After Approval): Add self.
  46
  47 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
  48
  49         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
  50         instruction to the dummy code region.
  51
  52 2019-07-19  Tom Tromey  <tromey@adacore.com>
  53
  54         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
  55         (ARGSUSED, PARAMS, __func__): Remove rules.
  56
  57 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
  58
  59         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
  60         * features/arm/arm-with-iwmmxt.c: Remove.
  61         * features/arm/arm-with-iwmmxt.xml: Remove.
  62         * features/arm/arm-with-m-fpa-layout.c: Remove.
  63         * features/arm/arm-with-m-fpa-layout.xml: Remove.
  64         * features/arm/arm-with-m-vfp-d16.c: Remove.
  65         * features/arm/arm-with-m-vfp-d16.xml: Remove.
  66         * features/arm/arm-with-m.c: Remove.
  67         * features/arm/arm-with-m.xml: Remove.
  68         * features/arm/arm-with-neon.c: Remove.
  69         * features/arm/arm-with-neon.xml: Remove.
  70         * features/arm/arm-with-vfpv2.c: Remove.
  71         * features/arm/arm-with-vfpv2.xml: Remove.
  72         * features/arm/arm-with-vfpv3.c: Remove.
  73         * features/arm/arm-with-vfpv3.xml: Remove.
  74
  75 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
  76
  77         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
  78
  79 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
  80
  81         * arch/aarch32.c (aarch32_create_target_description): Create
  82         target descriptions using features.
  83         * arch/arm.c (arm_create_target_description)
  84         (arm_create_mprofile_target_description): Likewise.
  85         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
  86
  87 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
  88
  89         * Makefile.in: Add new files.
  90         * aarch32-tdep.c: New file.
  91         * aarch32-tdep.h: New file.
  92         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
  93         Call aarch32_read_description.
  94         * arch/aarch32.c: New file.
  95         * arch/aarch32.h: New file.
  96         * arch/arm.c (arm_create_target_description)
  97         (arm_create_mprofile_target_description): New function.
  98         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
  99         (arm_create_target_description)
 100         (arm_create_mprofile_target_description): New declaration.
 101         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
 102         read_description functions.
 103         * arm-linux-nat.c (arm_linux_nat_target::read_description):
 104         Likewise.
 105         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
 106         * arm-tdep.c (tdesc_arm_list): New variable.
 107         (arm_register_g_packet_guesses): Call create description functions.
 108         (arm_read_description) (arm_read_mprofile_description): New
 109         function.
 110         * arm-tdep.h (arm_read_description)
 111         (arm_read_mprofile_description): Add declaration.
 112         * configure.tgt: Add new files.
 113
 114 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
 115
 116         * top.c (new_ui_command): Open specified terminal just once.
 117
 118 2019-07-18  Tom Tromey  <tromey@adacore.com>
 119
 120         * symtab.c (main_name): Constify return type.
 121         * symfile.c (set_initial_language): Update.
 122         * symtab.h (main_name): Constify return type.
 123
 124 2019-07-17  Tom Tromey  <tom@tromey.com>
 125
 126         * tui/tui-winsource.c (tui_update_source_window)
 127         (tui_update_source_window_as_is)
 128         (tui_update_source_windows_with_line): Remove return.
 129         * tui/tui-disasm.c (tui_show_disassem)
 130         (tui_show_disassem_and_update_source): Remove return.
 131         * tui/tui.c (tui_reset): Remove return.
 132         * tui/tui-wingeneral.c
 133         (tui_check_and_display_highlight_if_needed): Remove return.
 134
 135 2019-07-17  Tom Tromey  <tom@tromey.com>
 136
 137         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
 138
 139 2019-07-17  Tom Tromey  <tom@tromey.com>
 140
 141         * tui/tui-winsource.h (struct tui_exec_info_window)
 142         (struct tui_source_window_base): Move from tui-data.h.
 143         * tui/tui-winsource.c: Move many method definitions from
 144         elsewhere.  Remove "structuring" comments.
 145         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
 146         (tui_source_window_base::refresh_window): Move to
 147         tui-winsource.c.
 148         * tui/tui-win.c (tui_source_window_base::refresh_all)
 149         (tui_source_window_base::update_tab_width)
 150         (tui_source_window_base::set_new_height)
 151         (tui_source_window_base::do_make_visible_with_new_height): Move to
 152         tui-winsource.c.
 153         * tui/tui-source.h: Update.
 154         * tui/tui-source.c (tui_source_window_base::reset): Move to
 155         tui-winsource.c.
 156         * tui/tui-disasm.h: Update.
 157         * tui/tui-data.h (struct tui_exec_info_window): Move to
 158         tui-winsource.h.
 159         (struct tui_source_window_base): Likewise.
 160         * tui/tui-data.c (tui_source_window_base::clear_detail)
 161         (tui_source_window_base, ~tui_source_window_base): Move to
 162         tui-winsource.c.
 163
 164 2019-07-17  Tom Tromey  <tom@tromey.com>
 165
 166         * tui/tui-win.c (tui_resize_all)
 167         (tui_source_window_base::update_tab_width)
 168         (tui_adjust_win_heights): Update.
 169         (tui_win_info::make_invisible_and_set_new_height): Rename from
 170         make_invisible_and_set_new_height.
 171         * tui/tui-data.h (struct tui_win_info)
 172         <make_invisible_and_set_new_height>: New method.
 173
 174 2019-07-17  Tom Tromey  <tom@tromey.com>
 175
 176         * tui/tui.c: Update.
 177         * tui/tui-source.h (struct tui_source_window): Move from
 178         tui-data.h.
 179         * tui/tui-layout.c: Update.
 180         * tui/tui-disasm.c: Update.
 181         * tui/tui-data.h (struct tui_source_window): Move to
 182         tui-source.h.
 183
 184 2019-07-17  Tom Tromey  <tom@tromey.com>
 185
 186         * tui/tui-disasm.h (struct tui_disasm_window): Move from
 187         tui-data.h.
 188         * tui/tui-data.h (struct tui_disasm_window): Move to
 189         tui-disasm.h.
 190
 191 2019-07-17  Tom Tromey  <tom@tromey.com>
 192
 193         * tui/tui-regs.h (struct tui_data_item_window): Move from
 194         tui-data.h.
 195         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
 196         * tui/tui-data.h (struct tui_data_item_window): Move to
 197         tui-regs.h.
 198         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
 199
 200 2019-07-17  Tom Tromey  <tom@tromey.com>
 201
 202         * tui/tui.c: Update.
 203         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
 204         (tui_cmd_window::max_height): Move to tui-command.c.
 205         * tui/tui-layout.c: Update.
 206         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
 207         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
 208         tui-command.c.
 209         * tui/tui-command.h (struct tui_cmd_window): Move from
 210         tui-data.h.
 211         * tui/tui-command.c: Remove "structuring" comments.
 212         (tui_cmd_window::clear_detail)
 213         (tui_cmd_window::do_make_visible_with_new_height)
 214         (tui_cmd_window::max_height): Move from elsewhere.
 215
 216 2019-07-17  Tom Tromey  <tom@tromey.com>
 217
 218         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
 219         Now static.
 220         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
 221         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
 222
 223 2019-07-17  Tom Tromey  <tom@tromey.com>
 224
 225         * tui/tui.c: Update.
 226         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
 227         tui-regs.c.
 228         * tui/tui-windata.h: Remove file.
 229         * tui/tui-windata.c: Remove file.
 230         * tui/tui-win.c (tui_data_window::set_new_height)
 231         (tui_data_window::do_make_visible_with_new_height): Move to
 232         tui-regs.c.
 233         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
 234         * tui/tui-regs.c: Remove "structuring" comments.
 235         (tui_data_window::first_data_item_displayed)
 236         (tui_data_window::delete_data_content_windows)
 237         (tui_data_window::erase_data_content)
 238         (tui_data_window::display_all_data)
 239         (tui_data_window::refresh_all)
 240         (tui_data_window::do_scroll_vertical)
 241         (tui_data_window::clear_detail, tui_data_window::set_new_height)
 242         (tui_data_window::do_make_visible_with_new_height)
 243         (tui_data_window::refresh_window): Move from elsewhere.
 244         (_initialize_tui_regs): Move to end of file.
 245         * tui/tui-layout.c: Update.
 246         * tui/tui-hooks.c: Update.
 247         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
 248         * tui/tui-data.c (tui_data_window::clear_detail): Move to
 249         tui-regs.c.
 250         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
 251
 252 2019-07-17  Tom Tromey  <tom@tromey.com>
 253
 254         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
 255         seen.
 256
 257 2019-07-17  Tom Tromey  <tom@tromey.com>
 258
 259         * tui/tui-win.c (tui_source_window_base::set_new_height)
 260         (tui_source_window_base::do_make_visible_with_new_height): Use
 261         m_has_locator field directly.
 262         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
 263         method.
 264         (struct tui_source_window_base) <has_locator>: Likewise.
 265
 266 2019-07-17  Tom Tromey  <tom@tromey.com>
 267
 268         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
 269         Don't declare.
 270         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
 271         Remove.
 272         * tui/tui-win.c (tui_source_window_base::set_new_height)
 273         (tui_source_window_base::set_new_height)
 274         (make_invisible_and_set_new_height)
 275         (tui_source_window_base::do_make_visible_with_new_height)
 276         (tui_source_window_base::do_make_visible_with_new_height):
 277         Update.
 278         * tui/tui-layout.c (show_source_disasm_command, show_data)
 279         (show_source_or_disasm_and_command): Update.
 280         * tui/tui-layout.c (show_layout): Update.
 281
 282 2019-07-17  Tom Tromey  <tom@tromey.com>
 283
 284         * tui/tui-layout.c (make_data_window): Remove.
 285         (show_data): Unify creation and re-initialization cases.
 286
 287 2019-07-17  Tom Tromey  <tom@tromey.com>
 288
 289         * tui/tui-layout.c (make_source_window, make_disasm_window):
 290         Remove.
 291         (show_data): Unify creation and re-initialization cases.
 292
 293 2019-07-17  Tom Tromey  <tom@tromey.com>
 294
 295         * tui/tui-layout.c (make_command_window): Remove.
 296         (show_source_disasm_command, show_source_or_disasm_and_command):
 297         Unify creation and re-initialization cases.
 298
 299 2019-07-17  Tom Tromey  <tom@tromey.com>
 300
 301         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
 302         creation and re-initialization cases.
 303
 304 2019-07-17  Tom Tromey  <tom@tromey.com>
 305
 306         * tui/tui-regs.c (tui_get_register): Return void.
 307
 308 2019-07-17  Tom Tromey  <tom@tromey.com>
 309
 310         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
 311         Simplify.
 312
 313 2019-07-17  Tom Tromey  <tom@tromey.com>
 314
 315         * tui/tui-layout.c (show_source_disasm_command): Simplify window
 316         resetting.
 317
 318 2019-07-17  Tom Tromey  <tom@tromey.com>
 319
 320         * tui/tui.h (tui_set_layout_by_name): Don't declare.
 321         * tui/tui-regs.c (tui_reg_layout): New function.
 322         (tui_show_registers, tui_reg_command): Use it.
 323         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
 324         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
 325         parameters.
 326         (tui_layout_command): Remove.
 327
 328 2019-07-17  Tom Tromey  <tom@tromey.com>
 329
 330         * tui/tui-layout.h (tui/tui-layout): Return void.
 331         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
 332
 333 2019-07-17  Tom Tromey  <tom@tromey.com>
 334
 335         * tui/tui-layout.c (show_source_disasm_command, show_data):
 336         Update.
 337         (reset_locator): Remove.
 338         (show_source_or_disasm_and_command): Update.
 339
 340 2019-07-17  Tom Tromey  <tom@tromey.com>
 341
 342         * tui/tui-source.c (tui_source_window_base::reset): Remove
 343         win_type parameter.
 344         * tui/tui-layout.c (make_command_window, make_source_window)
 345         (make_disasm_window, make_data_window)
 346         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
 347         (reset_locator, show_source_or_disasm_and_command): Update.
 348         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
 349         win_type parameter.
 350         (struct tui_source_window_base) <reset>: Likewise.
 351
 352 2019-07-17  Tom Tromey  <tom@tromey.com>
 353
 354         * tui/tui-layout.c (show_source_disasm_command): Use
 355         reset_locator.
 356         (reset_locator): New function.
 357         (init_and_make_win): Remove.
 358         (show_source_or_disasm_and_command): Use reset_locator.
 359
 360 2019-07-17  Tom Tromey  <tom@tromey.com>
 361
 362         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
 363         condition.
 364         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
 365         Remove condition.
 366         * tui/tui-source.c (tui_source_window_base::reset): New method.
 367         * tui/tui-layout.c (make_command_window): Don't call
 368         init_and_make_win.
 369         (make_source_window, make_disasm_window): Don't call
 370         make_source_or_disasm_window.
 371         (make_data_window): Don't call init_and_make_win.  Change calling
 372         convention.
 373         (show_source_disasm_command, show_data): Simplify.
 374         (make_source_or_disasm_window): Remove.
 375         (show_source_or_disasm_and_command): Simplify.
 376         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
 377         (struct tui_source_window_base) <reset>: Likewise.
 378         <execution_info>: Remove initializer.
 379         * tui/tui-data.c (tui_source_window_base): Initialize
 380         execution_info.
 381
 382 2019-07-17  Tom Tromey  <tom@tromey.com>
 383
 384         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
 385         variable.
 386
 387 2019-07-17  Tom Tromey  <tom@tromey.com>
 388
 389         * tui/tui.c (tui_rl_other_window): Update.
 390         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
 391         superclass method first.  Always iterate over regs_content.
 392         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
 393         method.
 394         * tui/tui-win.c (tui_set_focus_command): Update.
 395
 396 2019-07-17  Tom Tromey  <tom@tromey.com>
 397
 398         * tui/tui-win.c (tui_set_focus_command): Rename from
 399         tui_set_focus.  Call tui_enable.
 400         (tui_set_focus_command): Remove.
 401
 402 2019-07-17  Tom Tromey  <tom@tromey.com>
 403
 404         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
 405         refresh_window.
 406         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
 407         touchwin.
 408         (tui_data_window::refresh_window): Call refresh_window on data
 409         items.  Always call superclass refresh_window.
 410         (tui_win_info::refresh): Remove.
 411         (tui_source_window_base::refresh_window): Update.
 412         (tui_refresh_all): Update.
 413         * tui/tui-layout.c (show_source_disasm_command): Remove call to
 414         refresh_window.
 415         (show_source_or_disasm_and_command): Likewise.
 416         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
 417         (struct tui_source_window_base) <refresh>: Likewise.
 418
 419 2019-07-17  Tom Tromey  <tom@tromey.com>
 420
 421         * tui/tui-winsource.c (tui_clear_source_content)
 422         (tui_show_source_content): Update.
 423         * tui/tui-source.c (tui_source_window::showing_source_p): Check
 424         whether content is empty.
 425         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
 426         Remove.
 427
 428 2019-07-17  Tom Tromey  <tom@tromey.com>
 429
 430         * tui/tui-winsource.c (tui_erase_source_content): Clear the
 431         window's contents.
 432         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
 433         * tui/tui-source.c (tui_set_source_content_nil): Remove.
 434
 435 2019-07-17  Tom Tromey  <tom@tromey.com>
 436
 437         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
 438         (struct tui_data_item_window): Update.
 439
 440 2019-07-17  Tom Tromey  <tom@tromey.com>
 441
 442         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
 443         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
 444         defines.
 445
 446 2019-07-17  Tom Tromey  <tom@tromey.com>
 447
 448         * tui/tui-winsource.h (tui_erase_source_content)
 449         (tui_clear_source_content): Remove "display_prompt" parameter.
 450         * tui/tui-winsource.c (tui_update_source_window_as_is)
 451         (tui_update_source_windows_with_addr): Update.
 452         (tui_clear_source_content): Remove "display_prompt" parameter.
 453         (tui_erase_source_content): Likewise.  Simplify.
 454         (tui_show_source_content): Update.
 455         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
 456         * tui/tui-stack.c (tui_show_frame_info): Update.
 457         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
 458         Remove defines.
 459
 460 2019-07-17  Tom Tromey  <tom@tromey.com>
 461
 462         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
 463         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
 464         parameter.
 465         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
 466         parameter.
 467
 468 2019-07-17  Tom Tromey  <tom@tromey.com>
 469
 470         * tui/tui-winsource.c (tui_clear_source_content)
 471         (tui_show_source_content, tui_show_exec_info_content)
 472         (tui_clear_exec_info_content): Update.
 473         * tui/tui-stack.c (tui_show_locator_content): Update.
 474         (tui_show_frame_info): Update.
 475         * tui/tui-source.h (tui_source_window): Don't declare.
 476         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
 477         from tui_source_is_displayed.
 478         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
 479         Remove field.
 480         (struct tui_source_window_base) <content_in_use>: New field.  Now
 481         bool.
 482         (struct tui_source_window) <showing_source_p>: New method.
 483         (TUI_SRC_WIN): Change cast.
 484         * tui/tui-data.c (tui_initialize_static_data): Update.
 485
 486 2019-07-17  Tom Tromey  <tom@tromey.com>
 487
 488         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
 489         location_matches_p.
 490         * tui/tui-source.c (tui_source_window::location_matches_p): New
 491         method.
 492         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
 493         method.
 494         * tui/tui-data.h (struct tui_source_window_base)
 495         <location_matches_p>: New method.
 496         (struct tui_source_window, struct tui_disasm_window)
 497         <location_matches_p>: Likewise.
 498
 499 2019-07-17  Tom Tromey  <tom@tromey.com>
 500
 501         * tui/tui-win.c (tui_set_win_height_command): Rename from
 502         tui_set_win_height.
 503         (tui_set_win_height_command): Remove.
 504
 505 2019-07-17  Tom Tromey  <tom@tromey.com>
 506
 507         * tui/tui-source.c (tui_source_window): New constructor.  Add
 508         observer.
 509         (~tui_source_window): New destructor.
 510         (tui_source_window::style_changed): New method.
 511         * tui/tui-hooks.c (tui_redisplay_source): Remove.
 512         (tui_attach_detach_observers): Update.
 513         * tui/tui-data.h (struct tui_source_window): Make constructor not
 514         inline.  Add destructor.
 515         (struct tui_source_window) <style_changed>: New method.
 516         <m_observable>: New member.
 517
 518 2019-07-17  Tom Tromey  <tom@tromey.com>
 519
 520         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
 521         * tui/tui-win.c (tui_resize_all): Fix typo.
 522
 523 2019-07-17  Tom Tromey  <tom@tromey.com>
 524
 525         * tui/tui-wingeneral.h (tui_refresh_all): Update.
 526         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
 527         (tui_refresh_all): Remove "list" parameter.  Use foreach.
 528         * tui/tui-win.c (window_name_completer): Use foreach.
 529         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
 530         (update_tab_width): Likewise.
 531         * tui/tui-layout.c (show_layout): Update.
 532         * tui/tui-data.h (class tui_window_iterator): New.
 533         (struct all_tui_windows): New.
 534         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
 535
 536 2019-07-17  Tom Tromey  <tom@tromey.com>
 537
 538         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
 539         parameter.  Don't reference globals.
 540         (tui_reg_command): Update.
 541
 542 2019-07-17  Tom Tromey  <tom@tromey.com>
 543
 544         * tui/tui-regs.c (tui_show_registers): Simplify.
 545
 546 2019-07-17  Tom Tromey  <tom@tromey.com>
 547
 548         * tui/tui-regs.c (tui_show_registers): Update.
 549         (tui_show_register_group): Add win_info parameter.
 550
 551 2019-07-17  Tom Tromey  <tom@tromey.com>
 552
 553         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
 554         Rename from tui_display_reg_element_at_line.
 555         (tui_data_window::display_registers_from_line): Update.
 556         * tui/tui-data.h (struct tui_data_window)
 557         <display_reg_element_at_line>: New method.
 558
 559 2019-07-17  Tom Tromey  <tom@tromey.com>
 560
 561         * tui/tui-regs.h (tui_display_registers_from)
 562         (tui_display_registers_from_line): Don't declare.
 563         * tui/tui-windata.c (tui_data_window::display_all_data)
 564         (tui_data_window::refresh_all)
 565         (tui_data_window::do_scroll_vertical): Update.
 566         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
 567         from tui_display_registers_from.
 568         (tui_display_reg_element_at_line): Update.
 569         (tui_data_window::display_registers_from_line): Rename from
 570         tui_display_registers_from_line.
 571         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
 572         display_registers_from_line>: New methods.
 573
 574 2019-07-17  Tom Tromey  <tom@tromey.com>
 575
 576         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
 577         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
 578         from tui_erase_data_content.
 579         (tui_data_window::display_all_data)
 580         (tui_data_window::refresh_all)
 581         (tui_data_window::do_scroll_vertical): Update.
 582         * tui/tui-regs.c (tui_show_registers): Update.
 583         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
 584         New method.
 585
 586 2019-07-17  Tom Tromey  <tom@tromey.com>
 587
 588         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
 589         declare.
 590         * tui/tui-windata.c
 591         (tui_data_window::delete_data_content_windows): Rename from
 592         tui_delete_data_content_windows.
 593         (tui_data_window::display_all_data)
 594         (tui_data_window::do_scroll_vertical): Update.
 595         * tui/tui-data.h (struct tui_data_window)
 596         <delete_data_content_windows>: New method.
 597
 598 2019-07-17  Tom Tromey  <tom@tromey.com>
 599
 600         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
 601         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
 602
 603 2019-07-17  Tom Tromey  <tom@tromey.com>
 604
 605         * tui/tui-windata.h (tui_display_all_data): Don't declare.
 606         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
 607         from tui_display_all_data.
 608         * tui/tui-win.c
 609         (tui_data_window::do_make_visible_with_new_height): Update.
 610         * tui/tui-regs.c (tui_show_registers): Update.
 611         * tui/tui-layout.c (tui_set_layout): Update.
 612         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
 613         method.
 614
 615 2019-07-17  Tom Tromey  <tom@tromey.com>
 616
 617         * tui/tui-windata.h (tui_display_data_from): Don't declare.
 618         * tui/tui-windata.c (tui_display_data_from): Remove.
 619         (tui_data_window::refresh_all): Update.
 620
 621 2019-07-17  Tom Tromey  <tom@tromey.com>
 622
 623         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
 624         * tui/tui-windata.c (tui_display_data_from_line): Remove.
 625         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
 626         tui_display_registers_from_line.
 627         * tui/tui-regs.h (tui_display_registers_from_line): Update.
 628         * tui/tui-regs.c (tui_display_registers_from_line): Remove
 629         "force_display" parameter.
 630
 631 2019-07-17  Tom Tromey  <tom@tromey.com>
 632
 633         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
 634         declare.
 635         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
 636         Rename from tui_first_reg_element_no_inline.
 637         (tui_display_reg_element_at_line)
 638         (tui_display_registers_from_line): Update.
 639         * tui/tui-data.h (struct tui_data_window)
 640         <first_reg_element_no_inline>: New method.
 641
 642 2019-07-17  Tom Tromey  <tom@tromey.com>
 643
 644         * tui/tui-windata.c (tui_display_data_from)
 645         (tui_data_window::do_scroll_vertical): Update.
 646         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
 647         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
 648         Rename from tui_line_from_reg_element_no.
 649         (tui_display_registers_from_line): Update.
 650         * tui/tui-data.h (struct tui_data_window)
 651         <line_from_reg_element_no>: New method.
 652
 653 2019-07-17  Tom Tromey  <tom@tromey.com>
 654
 655         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
 656         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
 657         tui_last_regs_line_no.
 658         (tui_display_reg_element_at_line)
 659         (tui_display_registers_from_line): Update.
 660         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
 661         method.
 662
 663 2019-07-17  Tom Tromey  <tom@tromey.com>
 664
 665         PR tui/24722:
 666         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
 667         (tui_update_breakpoint_info): Add "being_deleted" parameter.
 668         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
 669         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
 670         (tui_update_breakpoint_info): Likewise.
 671         * tui/tui-hooks.c (tui_event_create_breakpoint)
 672         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
 673         Update.
 674
 675 2019-07-17  Tom Tromey  <tom@tromey.com>
 676
 677         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
 678
 679 2019-07-17  Tom Tromey  <tom@tromey.com>
 680
 681         * tui/tui-winsource.c (tui_update_source_window_as_is)
 682         (tui_update_source_windows_with_addr): Update.
 683         * tui/tui-source.h (tui_set_source_content)
 684         (tui_show_symtab_source): Add "win_info" parameter.
 685         * tui/tui-source.c (tui_set_source_content): Add "win_info"
 686         parameter.
 687         (tui_show_symtab_source): Likewise.
 688
 689 2019-07-17  Tom Tromey  <tom@tromey.com>
 690
 691         * tui/tui-wingeneral.c
 692         (tui_check_and_display_highlight_if_needed): Check can_highlight.
 693
 694 2019-07-17  Tom Tromey  <tom@tromey.com>
 695
 696         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
 697         (struct tui_cmd_window) <can_scroll>: New method.
 698         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
 699         method.
 700
 701 2019-07-17  Tom Tromey  <tromey@adacore.com>
 702
 703         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
 704         do_field_signed>: Rename.  Change type of "value".
 705         * ui-out.c (ui_out::field_signed): Rename from field_int.
 706         Change type of "value".
 707         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
 708         type of "value".
 709         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
 710         do_field_int.  Change type of "value".
 711         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
 712         do_field_int.  Change type of "value".
 713         * tracepoint.c (trace_status_mi, tfind_1)
 714         (print_one_static_tracepoint_marker): Update.
 715         * thread.c (print_thread_info_1, print_selected_thread_frame):
 716         Update.
 717         * stack.c (print_frame, print_frame_info): Update.
 718         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
 719         Update.
 720         * source.c (print_source_lines_base): Update.
 721         * skip.c (info_skip_command): Update.
 722         * record-btrace.c (btrace_ui_out_decode_error)
 723         (btrace_call_history_src_line): Update.
 724         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
 725         Update.
 726         * progspace.c (print_program_space): Update.
 727         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
 728         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
 729         do_field_int.  Change type of "value".
 730         * mi/mi-out.c (mi_ui_out::do_table_begin)
 731         (mi_ui_out::do_table_header): Update.
 732         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
 733         type of "value".
 734         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
 735         (mi_cmd_data_list_changed_registers, output_register)
 736         (mi_cmd_data_read_memory, mi_load_progress)
 737         (mi_cmd_trace_frame_collected): Update.
 738         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
 739         Update.
 740         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
 741         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
 742         (mi_cmd_var_list_children, varobj_update_one): Update.
 743         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
 744         (mi_cmd_stack_list_args, list_arg_or_local): Update.
 745         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
 746         * inferior.c (print_inferior): Update.
 747         * gdb_bfd.c (print_one_bfd): Update.
 748         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
 749         Update.
 750         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
 751         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
 752         do_field_int.  Change type of "value".
 753         * cli-out.c (cli_ui_out::do_field_signed): Rename from
 754         do_field_int.  Change type of "value".
 755         * breakpoint.c (watchpoint_check, print_breakpoint_location)
 756         (print_one_breakpoint_location, print_it_catch_fork)
 757         (print_one_catch_fork, print_it_catch_vfork)
 758         (print_one_catch_vfork, print_it_catch_solib)
 759         (print_it_catch_exec, print_it_ranged_breakpoint)
 760         (print_mention_watchpoint, print_mention_masked_watchpoint)
 761         (bkpt_print_it, update_static_tracepoint): Update.
 762         * break-catch-throw.c (print_it_exception_catchpoint): Update.
 763         * break-catch-syscall.c (print_it_catch_syscall): Update.
 764         * ada-tasks.c (print_ada_task_info): Update.
 765         * ada-lang.c (print_it_exception, print_mention_exception):
 766         Update.
 767
 768 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
 769
 770         PR breakpoints/24541
 771         * gdbarch.c: Regenerate.
 772         * gdbarch.h: Regenerate.
 773         * gdbarch.sh: Adjust return type and parameter types for
 774         'stap_adjust_register'.
 775         (i386_stap_adjust_register): Adjust signature and return new
 776         register name.
 777         * stap-probe.c (stap_parse_register_operand): Adjust use of
 778         'gdbarch_stap_adjust_register'.
 779
 780 2019-07-17  Tom Tromey  <tromey@adacore.com>
 781
 782         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
 783         declare VEC.
 784         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
 785         std::vector.
 786         (struct s390_process_info): Add initializers.
 787         (s390_add_process): Use new.
 788         (s390_linux_nat_target::low_forget_process): Use delete.
 789         (s390_linux_nat_target::low_new_fork)
 790         (s390_linux_nat_target::stopped_by_watchpoint)
 791         (s390_linux_nat_target::low_prepare_to_resume)
 792         (s390_linux_nat_target::insert_watchpoint)
 793         (s390_linux_nat_target::insert_hw_breakpoint)
 794         (s390_linux_nat_target::remove_watchpoint)
 795         (s390_linux_nat_target::remove_hw_breakpoint): Update.
 796
 797 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
 798
 799         * aarch64-fbsd-nat.c: Include regcache.h.
 800         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
 801         argument.
 802         (aarch64_fbsd_nat_target::fetch_registers)
 803         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
 804         variable.
 805         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
 806
 807 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
 808
 809         * fbsd-nat.c: Include gdbarch.h.
 810
 811 2019-07-15  Tom Tromey  <tromey@adacore.com>
 812
 813         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
 814
 815 2019-07-15  Tom Tromey  <tromey@adacore.com>
 816
 817         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
 818         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
 819         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
 820         * cli-out.c (cli_ui_out::do_field_int): New method.
 821         * ui-out.c (ui_out::field_unsigned): New method.
 822         * symfile.c (generic_load): Use field_unsigned.
 823         (print_transfer_performance): Likewise.
 824         * record-btrace.c (ui_out_field_uint): Remove.
 825         (btrace_call_history_insn_range, btrace_call_history): Use
 826         field_unsigned.
 827         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
 828         field_unsigned.
 829         * ui-out.h (class ui_out) <field_unsigned>: New method.
 830         <do_field_unsigned>: Likewise.
 831
 832 2019-07-15  Tom Tromey  <tromey@adacore.com>
 833
 834         * mi/mi-main.c (list_available_thread_groups): Use field_string.
 835         * mi/mi-interp.c (mi_memory_changed): Use field_string.
 836         * target.c (flash_erase_command): Use field_string.
 837         * infrun.c (print_signal_received_reason): Use field_string.
 838         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
 839         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
 840         field_string.
 841         * ada-tasks.c (print_ada_task_info): Use field_string.
 842
 843 2019-07-15  Tom Tromey  <tromey@adacore.com>
 844
 845         * target.c (flash_erase_command): Use field_core_addr.
 846         * symfile.c (generic_load): Use field_core_addr.
 847         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
 848         Use field_core_addr.
 849         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
 850         field_core_addr.
 851
 852 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 853
 854         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
 855         value if its desired type is smaller than a CORE_ADDR and signed.
 856
 857 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 858
 859         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
 860         of changes to field names, and use new is_reference field to
 861         decide if a property is a reference or not.
 862         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
 863         field.
 864         (struct dwarf2_property_baton): Update header comment, rename
 865         'referenced_type' to 'property_type' and update comments.
 866         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
 867         default property type, store in property baton, update to take
 868         accound of renamed field.
 869         (read_func_scope): Update call to attr_to_dynamic_prop.
 870         (read_array_type): Likewise.
 871         (dwarf2_per_cu_addr_sized_int_type): New function.
 872         (read_subrange_index_type): Move type finding code to
 873         dwarf2_per_cu_addr_sized_int_type.
 874         (read_subrange_type): Update calls to attr_to_dynamic_prop.
 875         (dwarf2_per_cu_addr_type): New function.
 876         (set_die_type): Update calls to attr_to_dynamic_prop.
 877
 878 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 879
 880         * dwarf2read.c (read_subrange_index_type): New function.
 881         (read_subrange_type): Move code into new function and call it.
 882         * gdbtypes.c (create_range_type): Add some asserts.
 883
 884 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 885
 886         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
 887         update return statements.
 888         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
 889         declaration, and update comment to match.
 890         * gdbtypes.c (resolve_dynamic_array): Update call to
 891         dwarf2_evaluate_property to match new return type.
 892
 893 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 894
 895         * valarith.c (value_subscripted_rvalue): Change lowerbound
 896         parameter type from int to LONGEST.
 897         * value.h (value_subscripted_rvalue): Likewise in declaration.
 898
 899 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 900
 901         * cli/cli-utils.c (info_print_command_completer): New function.
 902         * cli/cli-utils.h: Add 'completer.h' include, and forward
 903         declaration for 'struct cmd_list_element'.
 904         (info_print_command_completer): Declare.
 905         * stack.c (_initialize_stack): Add completer for 'info locals' and
 906         'info args'.
 907         * symtab.c (_initialize_symtab): Add completer for 'info
 908         variables' and 'info functions'.
 909         * NEWS: Mention completion for additional info commands.
 910
 911 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 912
 913         * cli/cli-utils.c (extract_info_print_args): Delete.
 914         (extract_arg_maybe_quoted): Delete.
 915         (info_print_options_defs): New variable.
 916         (make_info_print_options_def_group): New function.
 917         (extract_info_print_options): Define new function.
 918         * cli/cli-utils.h (extract_info_print_args): Delete.
 919         (struct info_print_options): New structure.
 920         (extract_info_print_options): Declare new function.
 921         * stack.c (info_locals_command): Update to use new
 922         extract_info_print_options, also add a header comment.
 923         (info_args_command): Likewise.
 924         * symtab.c (info_variables_command): Likewise.
 925         (info_functions_command): Likewise.
 926
 927 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 928
 929         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
 930         to extract string arguments.
 931         * common/common-utils.c (extract_string_maybe_quoted): New function.
 932         * common/common-utils.h (extract_string_maybe_quoted): Declare.
 933
 934 2019-07-11  Tom Tromey  <tromey@adacore.com>
 935
 936         * main.c (get_init_files): Use GDBINIT, not gdbinit.
 937         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
 938         * top.h (gdbinit): Don't declare.
 939         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
 940         into...
 941         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
 942         * top.c (gdb_init): Don't call init_cli_cmds.
 943         (gdbinit): Remove.
 944         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
 945
 946 2019-07-11  Tom Tromey  <tromey@adacore.com>
 947
 948         * python/py-inferior.c (add_thread_object): Don't use thread_obj
 949         after it has been moved.
 950
 951 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
 952
 953         * valops.c (value_must_coerce_to_target): Change return type to
 954         bool.
 955         * value.h (value_must_coerce_to_target): Likewise.
 956
 957 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
 958
 959         * breakpoint.c (is_hardware_watchpoint): Remove
 960         forward-declaration.
 961         (is_masked_watchpoint): Change return type to bool.
 962         (is_tracepoint): Likewise.
 963         (is_breakpoint): Likewise.
 964         (is_hardware_watchpoint): Likewise.
 965         (is_watchpoint): Likewise.
 966         (is_no_memory_software_watchpoint): Likewise.
 967         (is_catchpoint): Likewise.
 968         (breakpoint_1): Make FILTER parameter's return type bool.
 969         is_masked_watchpoint): Change return type to bool.
 970         (save_breakpoints): Make FILTER parameter's return type bool.
 971         * breakpoint.h (is_breakpoint): Change return type to bool.
 972         (is_watchpoint): Likewise.
 973         (is_catchpoint): Likewise.
 974         (is_tracepoint): Likewise.
 975
 976 2019-07-10  Tom Tromey  <tom@tromey.com>
 977
 978         * defs.h: Don't include gdbarch.h.
 979         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
 980         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
 981         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
 982         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
 983         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
 984         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
 985         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
 986         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
 987         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
 988         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
 989         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
 990         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
 991         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
 992         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
 993         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
 994         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
 995         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
 996         record-btrace.c, record.h, regcache-dump.c, regcache.h,
 997         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
 998         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
 999         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
1000         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
1001         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
1002         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
1003         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
1004         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
1005         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
1006
1007 2019-07-10  Tom Tromey  <tromey@adacore.com>
1008
1009         * ada-lang.h (is_ada_exception_catchpoint): Declare.
1010         * breakpoint.c (init_ada_exception_breakpoint): Register as
1011         bp_catchpoint.
1012         (print_one_breakpoint_location, print_one_breakpoint): Use
1013         is_ada_exception_catchpoint.
1014         * ada-lang.c (class ada_catchpoint_location): Pass
1015         bp_loc_software_breakpoint to bp_location constructor.
1016         (is_ada_exception_catchpoint): New function.
1017
1018 2019-07-10  Tom Tromey  <tromey@adacore.com>
1019
1020         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
1021         VEC.
1022         (struct arm_exidx_entry): New method operator<.
1023         (struct arm_exidx_data) <section_maps>: Change type.
1024         (arm_exidx_data_free): Remove.
1025         (arm_exidx_data_key): Change type.  Move lower.
1026         (arm_exidx_new_objfile): Update.
1027         (arm_compare_exidx_entries): Remove.
1028         (arm_find_exidx_entry, _initialize_arm_tdep)
1029
1030 2019-07-10  Tom Tromey  <tromey@adacore.com>
1031
1032         * solib-spu.c (ocl_program_data_key): Change type.
1033         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
1034         Update.
1035
1036 2019-07-10  Tom Tromey  <tromey@adacore.com>
1037
1038         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
1039         (struct solib_aix_inferior_data) <library_list>: Change type.
1040         (solib_aix_inferior_data_handle): Change type.
1041         (get_solib_aix_inferior_data): Update.
1042         (solib_aix_free_library_list): Remove.
1043         (library_list_start_library): Update.
1044         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
1045         return type.
1046         (solib_aix_get_library_list)
1047         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
1048         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
1049
1050 2019-07-10  Tom Tromey  <tromey@adacore.com>
1051
1052         * solib-dsbt.c (struct dsbt_info): Add initializers.
1053         (solib_dsbt_pspace_data): Change type.
1054         (dsbt_pspace_data_cleanup): Remove.
1055         (get_dsbt_info, _initialize_dsbt_solib): Update.
1056
1057 2019-07-10  Tom Tromey  <tromey@adacore.com>
1058
1059         * spu-tdep.c (spu_overlay_data): Change type.
1060         (spu_get_overlay_table, spu_overlay_new_objfile)
1061         (_initialize_spu_tdep): Update.
1062
1063 2019-07-10  Tom Tromey  <tromey@adacore.com>
1064
1065         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
1066         destructor.
1067         (dbx_objfile_data_key): Change type and declare later.
1068         (DBX_SYMFILE_INFO): Rewrite.
1069         * dbxread.c (dbx_objfile_data_key): Change type.
1070         (dbx_symfile_init): Update.
1071         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
1072         (coffstab_build_psymtabs, elfstab_build_psymtabs)
1073         (stabsect_build_psymtabs, _initialize_dbxread): Update.
1074
1075 2019-07-10  Tom Tromey  <tromey@adacore.com>
1076
1077         * jit.c (jit_program_space_key): Change type.  Move lower.
1078         (get_jit_program_space_data): Update.
1079         (jit_program_space_data_cleanup): Remove.
1080         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
1081         Update.
1082         (struct jit_program_space_data): Add initializers.
1083
1084 2019-07-10  Tom Tromey  <tromey@adacore.com>
1085
1086         * solib-darwin.c (struct darwin_info): Add initializers.
1087         (solib_darwin_pspace_data): Change type.
1088         (darwin_pspace_data_cleanup): Remove.
1089         (get_darwin_info, _initialize_darwin_solib): Update.
1090
1091 2019-07-10  Tom Tromey  <tromey@adacore.com>
1092
1093         * remote-sim.c (struct sim_inferior_data): Add initializers,
1094         constructor, and destructor.
1095         (sim_inferior_data_key): Change type.  Move lower.
1096         (check_for_duplicate_sim_descriptor): Update.
1097         (get_sim_inferior_data): Use new.  Update.
1098         (~sim_inferior_data_cleanup): Rename from
1099         sim_inferior_data_cleanup.  Simplify.
1100         (gdbsim_close_inferior, simulator_command)
1101         (sim_command_completer, _initialize_remote_sim): Update.
1102         (next_pid, INITIAL_PID): Move earlier.
1103
1104 2019-07-10  Tom Tromey  <tromey@adacore.com>
1105
1106         * python/python-internal.h (create_thread_object): Return
1107         gdbpy_ref.
1108         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
1109         * python/py-inferior.c (struct threadlist_entry): Add
1110         constructor.
1111         <thread_obj>: Now a gdbpy_ref.
1112         (thread_to_thread_object): Update.
1113         (add_thread_object): Use new.
1114         (delete_thread_object): Use delete.
1115         (infpy_threads): Update.
1116         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
1117         GIL.
1118
1119 2019-07-10  Tom Tromey  <tromey@adacore.com>
1120
1121         * valops.c (value_cast): Specialize error message for Ada.
1122
1123 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
1124
1125         * breakpoint.c (breakpoint_1): Update doc and parameter names.
1126
1127 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
1128
1129         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
1130         bpstat_should_step): Return bool, adjust comments.
1131         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
1132         bpstat_should_step): Likewise.
1133
1134 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
1135
1136         * features/Makefile: Use feature target descriptions for Arm.
1137         * features/arm/arm-core.c: Generate new file.
1138         * features/arm/arm-fpa.c: Likewise.
1139         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
1140         * features/arm/arm-m-profile.c: Likewise.
1141         * features/arm/arm-vfpv2.c: Likewise.
1142         * features/arm/arm-vfpv3.c: Likewise.
1143         * features/arm/xscale-iwmmxt.c: Likewise.
1144         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
1145
1146 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
1147
1148         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
1149         ptrace earlier.
1150
1151 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
1152
1153         * features/aarch64-pauth.c: Regenerate.
1154
1155 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
1156
1157         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
1158         bool.
1159         (bpstat_what): Use false instead of 0.
1160
1161 2019-07-09  Pedro Alves  <palves@redhat.com>
1162
1163         * break-catch-throw.c (is_exception_catchpoint): New.
1164         * breakpoint.c (print_one_breakpoint_location): New parameter
1165         'raw_loc'.  Handle it.  Use
1166         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
1167         looking at the breakpoint's type.
1168         (print_one_breakpoint): If handling "maint info breakpoints", also
1169         print locations of exception catchpoints.
1170         * breakpoint.h (is_exception_catchpoint): Declare.
1171
1172 2019-07-09  Pedro Alves  <palves@redhat.com>
1173
1174         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
1175         "addr" field.
1176         (allocate_location_exception_catchpoint): New.
1177         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
1178         (initialize_throw_catchpoint_ops): Install
1179         allocate_location_exception_catchpoint as allocate_location
1180         method.
1181         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
1182         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
1183         bp_loc_other.
1184         (breakpoint_address_is_meaningful): Delete.
1185         (bl_address_is_meaningful): New.
1186         (breakpoint_locations_match): Adjust comment.
1187         (bp_location_from_bp_type): New, factored out of...
1188         (bp_location::bp_location(breakpoint *)): ... this.
1189         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
1190         factored out of...
1191         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
1192         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
1193         breakpoint_address_is_meaningful.
1194         (bp_locations_compare): Adjust comment.
1195         (update_global_location_list): Use bl_address_is_meaningful
1196         instead of breakpoint_address_is_meaningful.
1197         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
1198         explicit.
1199         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
1200         * python/py-breakpoint.c (bppy_get_location): No longer check
1201         whether location is null.
1202
1203 2019-07-09  Pedro Alves  <palves@redhat.com>
1204
1205         PR c++/15468
1206         * breakpoint.c (print_one_breakpoint_location): Remove
1207         single-location assert.
1208
1209 2019-07-09  Tom Tromey  <tom@tromey.com>
1210
1211         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
1212         * configure: Rebuild.
1213         * configure.ac: Change common to gdbsupport.
1214         * gdbsupport: Rename from common.
1215         * acinclude.m4: Change common to gdbsupport.
1216         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
1217         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
1218         gdbsupport.
1219         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
1220         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
1221         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
1222         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
1223         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
1224         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
1225         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
1226         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
1227         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
1228         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
1229         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
1230         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
1231         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
1232         coff-pe-read.c, command.h, compile/compile-c-support.c,
1233         compile/compile-c.h, compile/compile-cplus-symbols.c,
1234         compile/compile-cplus-types.c, compile/compile-cplus.h,
1235         compile/compile-loc2c.c, compile/compile.c, completer.c,
1236         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
1237         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
1238         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
1239         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
1240         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
1241         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
1242         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
1243         features/aarch64-core.c, features/aarch64-fpu.c,
1244         features/aarch64-pauth.c, features/aarch64-sve.c,
1245         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
1246         features/i386/32bit-core.c, features/i386/32bit-linux.c,
1247         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
1248         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
1249         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
1250         features/i386/64bit-core.c, features/i386/64bit-linux.c,
1251         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
1252         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
1253         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
1254         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
1255         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
1256         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
1257         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
1258         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
1259         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
1260         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
1261         go32-nat.c, guile/guile.c, guile/scm-ports.c,
1262         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
1263         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
1264         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
1265         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
1266         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
1267         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
1268         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
1269         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
1270         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
1271         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
1272         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
1273         minsyms.c, mips-linux-tdep.c, namespace.h,
1274         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
1275         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
1276         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
1277         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
1278         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
1279         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
1280         nat/linux-waitpid.c, nat/mips-linux-watch.c,
1281         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
1282         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
1283         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
1284         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
1285         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
1286         procfs.c, producer.c, progspace.h, psymtab.h,
1287         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
1288         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
1289         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
1290         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
1291         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
1292         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
1293         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
1294         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
1295         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
1296         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
1297         target-memory.c, target.c, target.h, target/waitstatus.c,
1298         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
1299         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
1300         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
1301         unittests/array-view-selftests.c,
1302         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
1303         unittests/common-utils-selftests.c,
1304         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
1305         unittests/format_pieces-selftests.c,
1306         unittests/function-view-selftests.c,
1307         unittests/lookup_name_info-selftests.c,
1308         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
1309         unittests/mkdir-recursive-selftests.c,
1310         unittests/observable-selftests.c,
1311         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
1312         unittests/parse-connection-spec-selftests.c,
1313         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
1314         unittests/scoped_fd-selftests.c,
1315         unittests/scoped_mmap-selftests.c,
1316         unittests/scoped_restore-selftests.c,
1317         unittests/string_view-selftests.c, unittests/style-selftests.c,
1318         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
1319         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
1320         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
1321         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
1322         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
1323         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
1324
1325 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1326
1327         * linespec.c (decode_digits_list_mode): Set explicit_line to a
1328         bool value.
1329         (decode_digits_ordinary): Set explicit_line field in sal.
1330         * symtab.c (skip_prologue_sal): Don't skip prologue for a
1331         symtab_and_line that was set on an explicit line number in
1332         assembler code.  Do always update the recorded symtab and line if
1333         we do skip the prologue.
1334
1335 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1336
1337         * breakpoint.c (set_breakpoint_location_function): Remove
1338         explicit_loc parameter.
1339         (momentary_breakpoint_from_master): Update call to
1340         set_breakpoint_location_function.
1341         (add_location_to_breakpoint): Likewise.
1342
1343 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1344
1345         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
1346         required features based on default bfd type when no specific bfd
1347         is present.
1348
1349 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1350
1351         * NEWS: Mention that GDB printf and eval commands can now print
1352         C-style and Ada-style convenience var strings without
1353         calling the inferior.
1354         * printcmd.c (printf_c_string): Locally print GDB internal var
1355         instead of transiting via the inferior.
1356         (printf_wide_c_string): Likewise.
1357
1358 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1359
1360         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
1361
1362 2019-07-04  Tom Tromey  <tom@tromey.com>
1363
1364         PR tui/24724:
1365         * tui/tui-winsource.c (tui_clear_source_content): Update.
1366         (tui_source_window_base::set_is_exec_point_at): Fix comment.
1367         (tui_update_breakpoint_info): Update.
1368         (tui_set_exec_info_content): Update.
1369         * tui/tui-source.c (tui_set_source_content_nil): Update.
1370         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
1371         has_break.
1372         * tui/tui-data.h (enum tui_bp_flag): New.
1373         (tui_bp_flags): New enum flags type.
1374         (struct tui_source_element) <break_mode>: Change type.  Rename
1375         from has_break.
1376         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
1377         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
1378         constants.
1379         * tui/tui-winsource.h: Fix comment.
1380
1381 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1382
1383         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
1384         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
1385         (store_fpregs_to_thread)
1386         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
1387         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
1388         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
1389         (IWMMXT_REGS_SIZE): Add define.
1390         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
1391         (fetch_vfp_regs, store_vfp_regs)
1392         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
1393         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
1394
1395 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1396
1397         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
1398         defines.
1399         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
1400         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
1401         (ARM_INT_REGISTER_SIZE): ...to this.
1402         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
1403         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
1404         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
1405         (arm_linux_collect_gregset, supply_nwfpe_register)
1406         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
1407         defines.
1408         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
1409         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
1410         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
1411         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
1412         (arm_return_in_memory, arm_store_return_value)
1413         (arm_get_longjmp_target, arm_register_g_packet_guesses)
1414         (arm_record_ld_st_multiple): Likewise.
1415         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
1416         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
1417
1418 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1419
1420         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
1421         AARCH64_DISPLACED_MODIFIED_INSNS.
1422         * aarch64-tdep.c (struct aarch64_displaced_step_data)
1423         (aarch64_displaced_step_copy_insn): Likewise.
1424         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
1425         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
1426         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
1427         ARM_DISPLACED_MODIFIED_INSNS.
1428         * arm-tdep.c (arm_gdbarch_init): Likewise.
1429         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
1430         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
1431         (struct arm_displaced_step_closure): Use
1432         ARM_DISPLACED_MODIFIED_INSNS.
1433
1434 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1435
1436         * features/Makefile: Remove unused xml files.
1437         * features/aarch64.xml: Remove.
1438         * features/i386/amd64-avx-avx512-linux.xml: Remove.
1439         * features/i386/amd64-avx-avx512.xml: Remove.
1440         * features/i386/amd64-avx-linux.xml: Remove.
1441         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
1442         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
1443         * features/i386/amd64-avx-mpx-linux.xml: Remove.
1444         * features/i386/amd64-avx-mpx.xml: Remove.
1445         * features/i386/amd64-avx.xml: Remove.
1446         * features/i386/amd64-linux.xml: Remove.
1447         * features/i386/amd64-mpx-linux.xml: Remove.
1448         * features/i386/amd64-mpx.xml: Remove.
1449         * features/i386/amd64.xml: Remove.
1450         * features/i386/i386-avx-avx512-linux.xml: Remove.
1451         * features/i386/i386-avx-avx512.xml: Remove.
1452         * features/i386/i386-avx-linux.xml: Remove.
1453         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
1454         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
1455         * features/i386/i386-avx-mpx-linux.xml: Remove.
1456         * features/i386/i386-avx-mpx.xml: Remove.
1457         * features/i386/i386-avx.xml: Remove.
1458         * features/i386/i386-linux.xml: Remove.
1459         * features/i386/i386-mmx-linux.xml: Remove.
1460         * features/i386/i386-mmx.xml: Remove.
1461         * features/i386/i386-mpx-linux.xml: Remove.
1462         * features/i386/i386-mpx.xml: Remove.
1463         * features/i386/i386.xml: Remove.
1464         * features/i386/x32-avx-avx512-linux.xml: Remove.
1465         * features/i386/x32-avx-linux.xml: Remove.
1466         * features/i386/x32-linux.xml: Remove.
1467
1468 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1469
1470         * regformats/aarch64.dat: Remove.
1471         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
1472         * regformats/i386/amd64-avx-linux.dat: Remove.
1473         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
1474         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
1475         * regformats/i386/amd64-linux.dat: Remove.
1476         * regformats/i386/amd64-mpx-linux.dat: Remove.
1477         * regformats/i386/amd64.dat: Remove.
1478         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
1479         * regformats/i386/i386-avx-linux.dat: Remove.
1480         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
1481         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
1482         * regformats/i386/i386-linux.dat: Remove.
1483         * regformats/i386/i386-mmx-linux.dat: Remove.
1484         * regformats/i386/i386-mpx-linux.dat: Remove.
1485         * regformats/i386/i386.dat: Remove.
1486         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
1487         * regformats/i386/x32-avx-linux.dat: Remove.
1488         * regformats/i386/x32-linux.dat: Remove.
1489
1490 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1491
1492         * aarch64-tdep.c: Remove xml self tests.
1493         * amd64-linux-tdep.c: Likewise.
1494         * amd64-tdep.c: Likewise.
1495         * i386-linux-tdep.c: Likewise.
1496         * i386-tdep.c: Likewise.
1497
1498 2019-07-03  Pedro Alves  <palves@redhat.com>
1499
1500         PR cli/24732
1501         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
1502         (pipe_cmd_option_defs): New.
1503         (make_pipe_cmd_options_def_group): New.
1504         (pipe_command): Use gdb::option::process_options.
1505         (pipe_command_completer): New function.
1506         (_initialize_cli_cmds): Install completer for "pipe" command.
1507
1508 2019-07-03  Pedro Alves  <palves@redhat.com>
1509
1510         * cli/cli-option.c (union option_value) <string>: New field.
1511         (struct option_def_and_value): Add ctor, move ctor, dtor and
1512         use DISABLE_COPY_AND_ASSIGN.
1513         (option_def_and_value::clear_value): New.
1514         (parse_option, save_option_value_in_ctx, get_val_type_str)
1515         (add_setshow_cmds_for_options): Handle var_string.
1516         * cli-option.h (union option_def::var_address) <string>: New
1517         field.
1518         (struct string_option_def): New.
1519         * maint-test-options.c (struct test_options_opts): Add default
1520         ctor and use DISABLE_COPY_AND_ASSIGN.
1521         <string_opt>: New field.
1522         (test_options_opts::~test_options_opts): New.
1523         (test_options_opts::dump): Also dump "-string".
1524         (test_options_option_defs): Install "string.
1525
1526 2019-07-03  Pedro Alves  <palves@redhat.com>
1527
1528         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
1529         option_value with a null enumeration.
1530         (complete_options): Save the option values in the context.
1531         (save_option_value_in_ctx): New, factored out from ...
1532         (process_options): ... here.
1533         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
1534         of the function.
1535         * maint-test-options.c (test_options_opts::dump): New, factored
1536         out from ...
1537         (maintenance_test_options_command_mode): ... here.
1538         (maintenance_test_options_command_completion_result): Delete.
1539         (maintenance_test_options_command_completion_text): Update
1540         comment.
1541         (maintenance_show_test_options_completion_result): Change
1542         prototype.  Just print
1543         maintenance_test_options_command_completion_text.
1544         (save_completion_result): New.
1545         (maintenance_test_options_completer_mode): Pass options context to
1546         complete_options, and then save a dump.
1547         (_initialize_maint_test_options): Use add_cmd to install "maint
1548         show test-options-completion-result".
1549
1550 2019-07-03  Pedro Alves  <palves@redhat.com>
1551
1552         * NEWS (New commands): Mention "with" and "maint with".
1553         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
1554         (with_command, with_command_completer): New.
1555         (pipe_command): Adjust to new repeat_previous
1556         interface.
1557         (_initialize_cli_cmds): Install the "with" command and its "w"
1558         alias.
1559         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
1560         declarations.
1561         * cli/cli-setshow.c (parse_cli_var_uinteger)
1562         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
1563         argument strings for all var_types.
1564         (get_setshow_command_value_string): New, factored out from ...
1565         (do_show_command): ... this.
1566         * cli/cli-setshow.h: Include <string>.
1567         (get_setshow_command_value_string): Declare.
1568         * command.h (repeat_previous): Now returns const char *.  Adjust
1569         comment.
1570         * maint.c: Include "cli/cli-cmds.h".
1571         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
1572         (_initialize_maint_cmds): Register the "maintenance with" command.
1573         * top.c (repeat_previous): Move bits from pipe_command here:
1574         Return the saved command line, if any; error out if there's no
1575         command to relaunch.
1576
1577 2019-07-03  Pedro Alves  <palves@redhat.com>
1578
1579         * NEWS (New commands): Mention "maint set/show test-settings"
1580         instead of "maint test-settings".
1581         * maint-test-settings.c (maintenance_test_settings_list): Delete.
1582         (maintenance_test_settings_set_list): Rename to ...
1583         (maintenance_set_test_settings_list): ... this.
1584         (maintenance_test_settings_show_list): Rename to  ...
1585         (maintenance_show_test_settings_list): ... this.
1586         (maintenance_test_settings_cmd): Delete.
1587         (maintenance_test_settings_set_cmd): ...
1588         (maintenance_set_test_settings_cmd): ... this.
1589         (maintenance_test_settings_show_cmd): ...
1590         (maintenance_show_test_settings_cmd): ... this.
1591         (maintenance_test_settings_show_value_cmd):
1592         (maintenance_show_test_settings_value_cmd): ... this.
1593         (_initialize_maint_test_settings): No longer install the "maint
1594         test-settings" prefix command.  Rename "maint test-settings set"
1595         to "maint set test-settings", and "maint test-settings show" to
1596         "maint show test-settings".  Adjust all subcommands.
1597
1598 2019-07-03  Pedro Alves  <palves@redhat.com>
1599
1600         * maint-test-settings.c: Fix file's intro comment.  Replace all
1601         references to "test-options" with references to "test-settings",
1602         in comments.
1603
1604 2019-07-03  Pedro Alves  <palves@redhat.com>
1605
1606         * maint-test-settings.c (maintenance_test_settings_xxx)
1607         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
1608         New.
1609         (maintenance_test_settings_enums): Use them.
1610         (maintenance_test_settings_enum): Default to
1611         maintenance_test_settings_xxx.
1612         (_initialize_maint_test_settings): Initialize
1613         MAINTENANCE_TEST_SETTINGS_FILENAME.
1614
1615 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
1616
1617         * breakpoint.h (remove_breakpoints_inf): Change return type to
1618         void, move function documentation here.
1619         * breakpoint.c (remove_breakpoints_inf): Change return type to
1620         void, move function documentation to header.
1621
1622 2019-07-02  Pedro Alves  <palves@redhat.com>
1623
1624         * NEWS (Completion improvements): Mention "info threads".
1625         * thread.c (struct info_threads_opts, info_threads_option_defs)
1626         (make_info_threads_options_def_group): New.
1627         (info_threads_command): Use gdb::option::process_options.
1628         (info_threads_command_completer): New.
1629         (_initialize_thread): Use gdb::option::build_help to build the
1630         help text for "info threads".
1631
1632 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
1633
1634         * defs.h (generic_load): Move from here...
1635         * symfile.h (generic_load): ... to here.  Rename name parameter
1636         to args.
1637         * symfile.c (generic_load): Add comment.
1638
1639 2019-07-01  Tom Tromey  <tromey@adacore.com>
1640
1641         * dwarf2read.c
1642         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
1643         declaration of without_params.  Fix formatting.
1644
1645 2019-07-01  Tom Tromey  <tromey@adacore.com>
1646
1647         * ada-exp.y (find_primitive_type): Update.
1648         * ada-lang.h (ada_lookup_symbol): Update.
1649         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
1650         parameter.
1651         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
1652
1653 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
1654
1655         PR breakpoints/24541
1656         * gdbarch.c: Regenerate.
1657         * gdbarch.h: Regenerate.
1658         * gdbarch.sh: Add 'stap_adjust_register'.
1659         * i386-tdep.c: Include '<unordered_set>'.
1660         (i386_stap_adjust_register): New function.
1661         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
1662         * stap-probe.c (stap_parse_register_operand): Call
1663         'gdbarch_stap_adjust_register'.
1664
1665 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
1666
1667         PR python/24742
1668         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
1669         * python/python.c (do_start_initialization): Use 'xmalloc'
1670         instead of 'PyMem_Malloc'.
1671
1672 2019-06-28  Tom Tromey  <tromey@adacore.com>
1673
1674         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
1675         for Ada.
1676
1677 2019-06-27  Tom Tromey  <tromey@adacore.com>
1678
1679         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
1680         objfile_key.
1681         (arm_find_mapping_symbol, arm_record_special_symbol)
1682         (_initialize_arm_tdep): Update.
1683         (arm_objfile_data_free): Remove.
1684
1685 2019-06-27  Tom Tromey  <tromey@adacore.com>
1686
1687         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
1688         to cp_print_static_field.
1689
1690 2019-06-26  Tom Tromey  <tromey@adacore.com>
1691
1692         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
1693         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
1694         declare.
1695
1696 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
1697
1698         * features/aarch64-core.c (create_feature_aarch64_core):
1699         Regenerate.
1700         * features/aarch64-core.xml: Add cpsr flags.
1701
1702 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
1703
1704         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
1705         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
1706
1707 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
1708
1709         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
1710         field.
1711         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
1712         use.
1713         (arm_record_special_symbol): Don't insert new symbol in sorted
1714         position, push it at the end.
1715
1716 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
1717
1718         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
1719         (arm_mapping_symbol_s): Remove.
1720         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
1721         (arm_mapping_symbol_vec): New typedef.
1722         (struct arm_per_objfile): Add constructor.
1723         <section_maps>: Change type to
1724         std::unique_ptr<arm_mapping_symbol_vec[]>.
1725         (arm_compare_mapping_symbols): Remove.
1726         (arm_find_mapping_symbol): Adjust to section_maps type change.
1727         (arm_objfile_data_free): Call delete on arm_per_objfile.
1728         (arm_record_special_symbol): Adjust to section_maps type change.
1729         Allocate arm_per_objfile with new.
1730
1731 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1732
1733         * cli/cli-cmds.c (alias_command): Compare the alias prefix
1734         with the command prefix.
1735
1736 2019-06-25  Tom Tromey  <tom@tromey.com>
1737
1738         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
1739         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
1740
1741 2019-06-25  Tom Tromey  <tom@tromey.com>
1742
1743         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
1744         type.
1745         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
1746         protected.
1747
1748 2019-06-25  Tom Tromey  <tom@tromey.com>
1749
1750         * tui/tui-winsource.c
1751         (tui_source_window_base::set_is_exec_point_at): Add check against
1752         LOA_ADDRESS.
1753
1754 2019-06-25  Tom Tromey  <tom@tromey.com>
1755
1756         * tui/tui-source.c (tui_set_source_content): Don't check before
1757         xfree.
1758         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
1759
1760 2019-06-25  Tom Tromey  <tom@tromey.com>
1761
1762         * tui/tui-winsource.h (tui_update_source_window_as_is)
1763         (tui_alloc_source_buffer, tui_line_is_displayed)
1764         (tui_addr_is_displayed): Change type of win_info.
1765         * tui/tui-winsource.c (tui_update_source_window_as_is)
1766         (tui_clear_source_content, tui_show_source_line)
1767         (tui_show_source_content, tui_source_window_base::refill)
1768         (tui_source_window_base::set_is_exec_point_at)
1769         (tui_source_window_base::set_is_exec_point_at)
1770         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
1771         (tui_alloc_source_buffer, tui_line_is_displayed)
1772         (tui_addr_is_displayed): Change type of win_info.  Update.
1773         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1774         (tui_source_window_base::do_make_visible_with_new_height):
1775         Update.
1776         * tui/tui-source.c (tui_set_source_content)
1777         (tui_set_source_content_nil)
1778         (tui_source_window::do_scroll_vertical): Update.
1779         * tui/tui-layout.c (show_layout): Update.
1780         * tui/tui-disasm.c (tui_set_disassem_content)
1781         (tui_disasm_window::do_scroll_vertical): Update.
1782         * tui/tui-data.h (tui_win_content): Remove.
1783         (struct tui_gen_win_info) <content, content_size>: Remove.
1784         (struct tui_source_element): Add initializers and destructor.
1785         (union tui_which_element, struct tui_win_element): Remove.
1786         (struct tui_source_window_base) <content>: New field.
1787         (struct tui_data_window): Remove destructor.
1788         (tui_alloc_content, tui_free_win_content)
1789         (tui_free_all_source_wins_content): Don't declare.
1790         * tui/tui-data.c (tui_initialize_static_data): Update.
1791         (init_content_element, tui_alloc_content): Remove.
1792         (~tui_gen_win_info): Update.
1793         (~tui_data_window, tui_free_all_source_wins_content)
1794         (tui_free_win_content, free_content, free_content_elements):
1795         Remove.
1796
1797 2019-06-25  Tom Tromey  <tom@tromey.com>
1798
1799         * tui/tui-winsource.h (tui_clear_source_content)
1800         (tui_erase_source_content, tui_show_source_content): Change type
1801         of win_info.
1802         * tui/tui-winsource.c (tui_clear_source_content)
1803         (tui_erase_source_content, tui_show_source_content): Change type
1804         of win_info.
1805         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
1806         * tui/tui-source.h (tui_set_source_content_nil): Change type of
1807         win_info.
1808         * tui/tui-source.c (tui_set_source_content_nil): Change type of
1809         win_info.
1810         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
1811
1812 2019-06-25  Tom Tromey  <tom@tromey.com>
1813
1814         * tui/tui-winsource.c (tui_clear_source_content)
1815         (tui_source_window_base::set_is_exec_point_at): Update.
1816         * tui/tui-source.c (tui_set_source_content_nil): Update.
1817         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
1818         a bool.
1819         * tui/tui-data.c (init_content_element): Update.
1820
1821 2019-06-25  Tom Tromey  <tom@tromey.com>
1822
1823         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
1824         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
1825         * tui/tui-layout.c (init_and_make_win): Update.
1826         * tui/tui.h (enum tui_win_type): Update.
1827         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
1828         tui_win_is_auxillary.
1829         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
1830         tui_win_is_auxillary.
1831
1832 2019-06-25  Tom Tromey  <tom@tromey.com>
1833
1834         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
1835         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
1836         (tui_delete_data_content_windows, tui_display_all_data)
1837         (tui_data_window::do_scroll_vertical, tui_display_data_from):
1838         Update.
1839         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
1840         * tui/tui-regs.c (tui_last_regs_line_no)
1841         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
1842         (tui_show_registers): Update.
1843         (tui_show_register_group): Return void.  Update.
1844         (tui_display_registers_from, tui_display_reg_element_at_line)
1845         (tui_display_registers_from_line, tui_check_register_values):
1846         Update.
1847         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
1848         member.
1849         (struct tui_data_window) <regs_content>: Now a std::vector.
1850         <regs_content_count>: Remove.
1851         (tui_add_content_elements, tui_free_data_content): Don't declare.
1852         * tui/tui-data.c (tui_data_window::clear_detail): Update.
1853         (init_content_element): Remove DATA_WIN case.  Add assert.
1854         (tui_add_content_elements): Remove.
1855         (tui_data_window): Update.
1856         (tui_free_data_content): Remove.
1857         (free_content_elements): Remove DATA_WIN case.
1858
1859 2019-06-25  Tom Tromey  <tom@tromey.com>
1860
1861         * tui/tui-data.c (tui_data_item_window): Update.
1862         * tui/tui-windata.h (tui_check_data_values): Don't declare.
1863         * tui/tui-windata.c (tui_display_all_data)
1864         (tui_display_data_from_line): Update.
1865         (tui_check_data_values): Remove.
1866         * tui/tui-regs.c (tui_show_register_group)
1867         (tui_display_reg_element_at_line): Update.
1868         * tui/tui-hooks.c (tui_register_changed)
1869         (tui_refresh_frame_and_register_information): Call
1870         tui_check_register_values.
1871         * tui/tui-data.h (struct tui_data_window) <data_content,
1872         data_content_count, data_type>: Remove.
1873         (enum tui_data_type): Remove.
1874
1875         * tui/tui-data.c (tui_data_window::clear_detail)
1876         (~tui_data_window): Update.
1877
1878 2019-06-25  Tom Tromey  <tom@tromey.com>
1879
1880         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
1881         declare.
1882         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
1883         Rename from tui_first_data_item_displayed.  Update.
1884         (tui_data_window::refresh_all)
1885         (tui_data_window::do_scroll_vertical): Update.
1886         * tui/tui-data.h (struct tui_data_window)
1887         <first_data_item_displayed>: Declare new method.
1888
1889 2019-06-25  Tom Tromey  <tom@tromey.com>
1890
1891         * tui/tui-data.h (tui_init_generic_part): Don't declare.
1892         * tui/tui-data.c (tui_init_generic_part): Remove, moving
1893         contents...
1894         (tui_initialize_static_data): ...here.
1895
1896 2019-06-25  Tom Tromey  <tom@tromey.com>
1897
1898         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1899         (tui_display_registers_from, tui_check_register_values): Update.
1900         (tui_display_register): Remove win_info parameter; update.
1901         (tui_get_register): Change type of parameters.
1902         * tui/tui-data.h (struct tui_data_element): Remove.
1903         (union tui_which_element) <data>: Remove.
1904         <data_window>: Change type.
1905         (struct tui_data_item_window): New.
1906         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
1907         case.  Add assert.
1908         (~tui_data_item_window): New destructor.
1909         (free_content_elements): Remove DATA_ITEM_WIN case.
1910
1911 2019-06-25  Tom Tromey  <tom@tromey.com>
1912
1913         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
1914         Remove.
1915
1916 2019-06-25  Tom Tromey  <tom@tromey.com>
1917
1918         * tui/tui-data.h (struct tui_command_element): Remove.
1919         (union tui_which_element) <command>: Remove.
1920         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
1921         assert.
1922         (free_content_elements): Remove CMD_WIN case.
1923
1924 2019-06-25  Tom Tromey  <tom@tromey.com>
1925
1926         * tui/tui-layout.c (tui_set_layout): Update.
1927         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
1928         * tui/tui-data.c (layout_def): Update.
1929
1930 2019-06-25  Tom Tromey  <tom@tromey.com>
1931
1932         * tui/tui-wingeneral.c (tui_refresh_all): Update.
1933         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1934         (tui_source_window_base::set_new_height): Update.
1935         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
1936         Update.
1937         (tui_set_locator_fullname, tui_set_locator_info)
1938         (tui_show_frame_info): Update.
1939         * tui/tui-source.c (tui_set_source_content)
1940         (tui_source_is_displayed): Update.
1941         * tui/tui-layout.c (show_source_disasm_command, show_data)
1942         (show_source_or_disasm_and_command): Update.
1943         * tui/tui-disasm.c (tui_set_disassem_content)
1944         (tui_get_begin_asm_address): Update.
1945         * tui/tui-data.h (struct tui_locator_element): Remove.
1946         (union tui_which_element) <locator>: Remove.
1947         (struct tui_locator_window): New.
1948         (tui_locator_win_info_ptr): Change return type.
1949         * tui/tui-data.c (_locator): Change type.
1950         (tui_locator_win_info_ptr): Change return type.
1951         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
1952         (tui_alloc_content): Add assert.
1953
1954 2019-06-25  Tom Tromey  <tom@tromey.com>
1955
1956         * tui/tui-winsource.c
1957         (tui_exec_info_window::maybe_allocate_content): New method.
1958         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
1959         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
1960         (make_source_or_disasm_window): Add cast.
1961         * tui/tui-data.h (union tui_which_element) <simple_string>:
1962         Remove.
1963         (struct tui_source_info): New.
1964         (struct tui_source_window_base) <execution_info>: Change type.
1965         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
1966         case, and add assert.
1967         (tui_alloc_content): Add assert.
1968
1969 2019-06-25  Tom Tromey  <tom@tromey.com>
1970
1971         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
1972         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
1973         * tui/tui-data.c (tui_alloc_win_info): Remove.
1974
1975 2019-06-25  Tom Tromey  <tom@tromey.com>
1976
1977         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
1978         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
1979         can_highlight.
1980
1981 2019-06-25  Tom Tromey  <tom@tromey.com>
1982
1983         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
1984         make_visible_with_new_height method.
1985         (tui_win_info::make_visible_with_new_height): New method.
1986         (tui_source_window_base::do_make_visible_with_new_height)
1987         (tui_data_window::do_make_visible_with_new_height)
1988         (tui_cmd_window::do_make_visible_with_new_height): New methods.
1989         (make_visible_with_new_height): Remove.
1990         (tui_resize_all, tui_adjust_win_heights): Use
1991         make_visible_with_new_height method.
1992         * tui/tui-data.h (struct tui_win_info)
1993         <do_make_visible_with_new_height, make_visible_with_new_height>:
1994         New methods.
1995         (struct tui_source_window_base, struct tui_data_window)
1996         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
1997         methods.
1998
1999 2019-06-25  Tom Tromey  <tom@tromey.com>
2000
2001         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
2002         method.
2003         (update_tab_width): Call update_tab_width method.
2004         * tui/tui-data.h (struct tui_win_info)
2005         (struct tui_source_window_base) <update_tab_width>: New methods.
2006
2007 2019-06-25  Tom Tromey  <tom@tromey.com>
2008
2009         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
2010         parameter.
2011         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
2012         parameter.
2013         (tui_gen_win_info::make_visible): Update.
2014         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
2015         parameter.
2016         * tui/tui-data.h (enum tui_box): New enum.
2017         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
2018
2019 2019-06-25  Tom Tromey  <tom@tromey.com>
2020
2021         * tui/tui-layout.c (make_source_or_disasm_window): Always use
2022         init_and_make_win for EXEC_INFO_WIN.
2023         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
2024         longer inline.
2025         (struct tui_win_info) <~tui_win_info>: Inline.
2026         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
2027         Don't declare.
2028         * tui/tui-data.c (source_win, disasm_win): Remove globals.
2029         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
2030         Remove.
2031         (tui_initialize_static_data): Update.
2032         (~tui_gen_win_info): Handle more cleanup here.
2033         (~tui_source_window_base): Delete "execution_info".
2034         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
2035
2036 2019-06-25  Tom Tromey  <tom@tromey.com>
2037
2038         * tui/tui-layout.c (make_command_window): Don't set
2039         can_highlight.
2040         (show_source_disasm_command): Call the reset method.
2041         (show_data): Don't set can_highlight.  Call the reset method.
2042         (tui_gen_win_info::reset): Rename from init_gen_win_info
2043         (init_and_make_win): Simplify.  Return tui_gen_win_info.
2044         (show_source_or_disasm_and_command): Call the reset method.
2045         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
2046         (struct tui_cmd_window): Set can_highlight.
2047
2048 2019-06-25  Tom Tromey  <tom@tromey.com>
2049
2050         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
2051         from make_visible.
2052         (tui_make_visible, tui_make_invisible): Rewrite.
2053         (tui_win_info::make_visible): Remove.
2054         (tui_source_window_base::make_visible): Update.
2055         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
2056         method.  Moved from...
2057         (struct tui_win_info) <make_visible>: ...here.
2058
2059 2019-06-25  Tom Tromey  <tom@tromey.com>
2060
2061         * tui/tui-winsource.c
2062         (tui_source_window_base::do_scroll_horizontal): Remove direction
2063         parameter.
2064         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
2065         direction parameter.
2066         * tui/tui-win.c (tui_win_info::forward_scroll)
2067         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
2068         (tui_win_info::right_scroll): Update.
2069         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
2070         direction parameter.
2071         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
2072         direction parameter.
2073         * tui/tui-data.h (enum tui_scroll_direction): Remove.
2074         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
2075         Remove direction parameter.
2076         (struct tui_source_window_base, struct tui_source_window)
2077         (struct tui_disasm_window, struct tui_data_window)
2078         (struct tui_cmd_window): Update.
2079
2080 2019-06-25  Tom Tromey  <tom@tromey.com>
2081
2082         * tui/tui-winsource.h (tui_set_exec_info_content)
2083         (tui_show_exec_info_content, tui_erase_exec_info_content)
2084         (tui_clear_exec_info_content, tui_update_exec_info): Change
2085         argument to tui_source_window_base.
2086         * tui/tui-winsource.c (tui_set_exec_info_content)
2087         (tui_show_exec_info_content, tui_erase_exec_info_content)
2088         (tui_clear_exec_info_content, tui_update_exec_info): Change
2089         argument to tui_source_window_base.
2090
2091 2019-06-25  Tom Tromey  <tom@tromey.com>
2092
2093         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
2094         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
2095
2096 2019-06-25  Tom Tromey  <tom@tromey.com>
2097
2098         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
2099         check.
2100
2101 2019-06-25  Tom Tromey  <tom@tromey.com>
2102
2103         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
2104         type to void.
2105         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
2106         type to void.
2107         * tui/tui-source.c (tui_set_source_content): Update.
2108         * tui/tui-disasm.c (tui_set_disassem_content): Update.
2109
2110 2019-06-25  Tom Tromey  <tom@tromey.com>
2111
2112         * tui/tui-win.c (window_name_completer, tui_set_focus)
2113         (tui_all_windows_info): Use name method.
2114         * tui/tui-data.h (struct tui_gen_win_info)
2115         (struct tui_source_window, struct tui_disasm_window)
2116         (struct tui_data_window, struct tui_cmd_window) <name>: New
2117         method.
2118         (tui_win_name): Don't declare.
2119         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
2120         (tui_win_name): Remove.
2121
2122 2019-06-25  Tom Tromey  <tom@tromey.com>
2123
2124         * tui/tui-winsource.h (tui_update_source_window)
2125         (tui_update_source_window_as_is): Change parameter type.
2126         * tui/tui-winsource.c (tui_update_source_window): Change win_info
2127         to be a tui_source_window_base.
2128         (tui_update_source_window_as_is): Likewise.
2129         * tui/tui-win.c (make_visible_with_new_height): Update.
2130
2131 2019-06-25  Tom Tromey  <tom@tromey.com>
2132
2133         * tui/tui-winsource.c (tui_erase_source_content)
2134         (tui_show_source_content, tui_show_exec_info_content)
2135         (tui_erase_exec_info_content): Use refresh_window method.
2136         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
2137         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
2138         from tui_refresh_win.
2139         (tui_data_window::refresh_window): New method.
2140         (tui_win_info::refresh, tui_source_window_base::refresh)
2141         (tui_refresh_all): Use refresh_window method.
2142         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
2143         method.
2144         * tui/tui-regs.c (tui_display_register): Call refresh_window
2145         method.
2146         * tui/tui-layout.c (show_source_disasm_command)
2147         (show_source_or_disasm_and_command): Call refresh_window method.
2148         * tui/tui-data.h (struct tui_gen_win_info)
2149         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
2150         New method.
2151
2152 2019-06-25  Tom Tromey  <tom@tromey.com>
2153
2154         * tui/tui.c (tui_rl_other_window, tui_enable)
2155         (tui_is_window_visible, tui_get_command_dimension): Update.
2156         * tui/tui-winsource.c (tui_update_source_window_as_is)
2157         (tui_clear_source_content, tui_erase_source_content)
2158         (tui_show_source_line, tui_source_window_base::refill)
2159         (tui_source_window_base::do_scroll_horizontal)
2160         (tui_source_window_base::set_is_exec_point_at)
2161         (tui_update_breakpoint_info, tui_set_exec_info_content)
2162         (tui_alloc_source_buffer, tui_line_is_displayed)
2163         (tui_addr_is_displayed): Update.
2164         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
2165         (tui_check_and_display_highlight_if_needed)
2166         (tui_win_info::make_visible, tui_win_info::refresh)
2167         (tui_refresh_all): Update.
2168         * tui/tui-windata.c (tui_first_data_item_displayed)
2169         (tui_delete_data_content_windows, tui_erase_data_content)
2170         (tui_display_all_data, tui_data_window::refresh_all)
2171         (tui_check_data_values): Update.
2172         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
2173         (tui_set_win_focus_to, tui_win_info::forward_scroll)
2174         (tui_win_info::backward_scroll, tui_refresh_all_win)
2175         (tui_resize_all, tui_set_focus, tui_all_windows_info)
2176         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
2177         (tui_source_window_base::set_new_height)
2178         (tui_data_window::set_new_height)
2179         (make_invisible_and_set_new_height)
2180         (make_visible_with_new_height, new_height_ok)
2181         (parse_scrolling_args): Update.
2182         * tui/tui-stack.c (tui_show_frame_info): Update.
2183         * tui/tui-source.c (tui_set_source_content)
2184         (tui_set_source_content_nil, tui_source_is_displayed)
2185         (tui_source_window::do_scroll_vertical): Update.
2186         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
2187         (tui_display_registers_from, tui_display_reg_element_at_line)
2188         (tui_check_register_values, tui_reg_command): Update.
2189         * tui/tui-layout.c (tui_default_win_height)
2190         (show_source_disasm_command, show_data, init_and_make_win)
2191         (show_source_or_disasm_and_command): Update.
2192         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
2193         (tui_redisplay_readline, tui_mld_flush)
2194         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
2195         (tui_getc): Update.
2196         * tui/tui-disasm.c (tui_set_disassem_content)
2197         (tui_disasm_window::do_scroll_vertical): Update.
2198         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
2199         Now virtual.
2200         (struct tui_win_info): Derive from tui_gen_win_info.
2201         <~tui_win_info>: Mark as override.
2202         <generic>: Remove member.
2203         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
2204         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
2205         (~tui_data_window, ~tui_win_info)
2206         (tui_free_all_source_wins_content): Update.
2207         * tui/tui-command.c (tui_refresh_cmd_win): Update.
2208
2209 2019-06-25  Tom Tromey  <tom@tromey.com>
2210
2211         * tui/tui-layout.c (init_and_make_win): Use new.
2212         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
2213         destructor, initializers.
2214         (tui_alloc_generic_win_info): Don't declare.
2215         * tui/tui-data.c (_locator): Add argument to constructor.
2216         (source_win, disasm_win): New globals.
2217         (exec_info): Remove.
2218         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
2219         Update.
2220         (tui_alloc_generic_win_info): Remove.
2221         (init_content_element): Use new.
2222         (tui_win_info::tui_win_info): Update.
2223         (free_content_elements) <case DATA_WIN>: Use delete.
2224
2225 2019-06-25  Tom Tromey  <tom@tromey.com>
2226
2227         * tui/tui-wingeneral.c (tui_refresh_win): Update.
2228         * tui/tui-windata.c (tui_first_data_item_displayed)
2229         (tui_delete_data_content_windows): Update.
2230         * tui/tui-win.c (tui_data_window::set_new_height): Update.
2231         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
2232         (tui_display_registers_from, tui_check_register_values): Update.
2233         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
2234         pointer.
2235         * tui/tui-data.c (init_content_element): Update.  Allocate the new
2236         window.
2237         (tui_free_data_content): Update.
2238         (free_content_elements) <case DATA_WIN>: Free the window.
2239
2240 2019-06-25  Tom Tromey  <tom@tromey.com>
2241
2242         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
2243         Update.
2244         * tui/tui-layout.c (make_command_window)
2245         (show_source_disasm_command, show_data, init_and_make_win)
2246         (show_source_or_disasm_and_command): Update.
2247         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
2248         method.
2249         <can_highight, is_highlighted>: Now bool.
2250         (tui_set_win_highlight): Don't declare.
2251         * tui/tui-data.c (tui_set_win_highlight): Remove.
2252
2253 2019-06-25  Tom Tromey  <tom@tromey.com>
2254
2255         * tui/tui-wingeneral.c (make_visible): Remove check of window
2256         type.
2257
2258 2019-06-25  Tom Tromey  <tom@tromey.com>
2259
2260         * tui/tui-win.c (tui_win_info::max_height)
2261         (tui_cmd_window::max_height): New methods.
2262         (new_height_ok): Call max_height.
2263         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
2264         <max_height>: New method.
2265
2266 2019-06-25  Tom Tromey  <tom@tromey.com>
2267
2268         * tui/tui-win.c (tui_source_window_base::set_new_height)
2269         (tui_data_window::set_new_height): New methods.
2270         (make_invisible_and_set_new_height): Call set_new_height method.
2271         * tui/tui-data.h (struct tui_win_info)
2272         (struct tui_source_window_base, struct tui_data_window)
2273         <set_new_height>: New method.
2274
2275 2019-06-25  Tom Tromey  <tom@tromey.com>
2276
2277         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
2278         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
2279         tui_refresh_data_win.
2280         * tui/tui-win.c (tui_source_window_base::refresh_all): New
2281         method.
2282         (tui_refresh_all_win): Call the refresh_all method.
2283         (tui_set_focus): Likewise.
2284         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
2285         (struct tui_source_window_base, struct tui_data_window) <refresh>:
2286         Likewise.
2287
2288 2019-06-25  Tom Tromey  <tom@tromey.com>
2289
2290         * tui/tui-winsource.h (tui_refill_source_window)
2291         (tui_set_is_exec_point_at): Don't declare.
2292         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
2293         (tui_source_window_base::refill): Rename from
2294         tui_refill_source_window.
2295         (tui_source_window_base::do_scroll_horizontal): Update.
2296         (tui_source_window_base::set_is_exec_point_at): Rename from
2297         tui_set_is_exec_point_at.
2298         (tui_update_all_breakpoint_info): Update.
2299         * tui/tui-stack.c (tui_show_frame_info): Update.
2300         * tui/tui-layout.c (show_data): Add cast.
2301         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
2302         * tui/tui-data.h (struct tui_source_window_base) <refill,
2303         set_is_exec_point_at>: New methods.
2304         (tui_source_windows, tui_add_to_source_windows): Update types.
2305         (tui_add_to_source_windows): Remove redundant declaration.
2306         * tui/tui-data.c (source_windows): Store tui_source_window_base.
2307         (tui_source_windows): Change return type.
2308         (tui_clear_source_windows_detail): Update.
2309         (tui_add_to_source_windows): Change type of parameter.
2310         (tui_free_all_source_wins_content): Update.
2311
2312 2019-06-25  Tom Tromey  <tom@tromey.com>
2313
2314         * tui/tui-wingeneral.c (tui_win_info::refresh)
2315         (tui_source_window_base::refresh): New methods.
2316         (tui_refresh_all): Call the refresh method.
2317         * tui/tui-data.h (struct tui_win_info)
2318         (struct tui_source_window_base) <refresh>: New method.
2319
2320 2019-06-25  Tom Tromey  <tom@tromey.com>
2321
2322         * tui/tui.h (tui_is_window_visible): Return bool.
2323         * tui/tui.c (tui_is_window_visible): Return bool.
2324         * tui/tui-wingeneral.c (tui_make_window, make_visible)
2325         (tui_make_visible, tui_make_invisible)
2326         (tui_win_info::make_visible)
2327         (tui_source_window_base::make_visible, make_all_visible)
2328         (tui_make_all_visible, tui_make_all_invisible): Update.
2329         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
2330         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
2331         bool.
2332         (struct tui_win_info, struct tui_source_window_base)
2333         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
2334         * tui/tui-data.c (tui_init_generic_part): Update.
2335
2336 2019-06-25  Tom Tromey  <tom@tromey.com>
2337
2338         * tui/tui-wingeneral.c (tui_win_info::make_visible)
2339         (tui_source_window_base::make_visible): New methods.
2340         (make_all_visible): Make method call.
2341         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
2342         (struct tui_source_window_base, struct tui_cmd_window): Override
2343         make_visible.
2344         (tui_win_is_source_type): Don't declare.
2345         * tui/tui-data.c (tui_win_is_source_type): Remove.
2346
2347 2019-06-25  Tom Tromey  <tom@tromey.com>
2348
2349         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
2350         NULL check.
2351
2352 2019-06-25  Tom Tromey  <tom@tromey.com>
2353
2354         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
2355         Inline constructor.  Add initializers for members.
2356         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
2357         constructors; now inline in class.
2358
2359 2019-06-25  Tom Tromey  <tom@tromey.com>
2360
2361         * tui/tui-regs.c (tui_show_registers): Update.
2362         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
2363         bool.
2364         * tui/tui-data.c (tui_data_window::clear_detail)
2365         (tui_data_window): Update.
2366
2367 2019-06-25  Tom Tromey  <tom@tromey.com>
2368
2369         * tui/tui-windata.c (tui_display_all_data)
2370         (tui_display_data_from_line, tui_display_data_from)
2371         (tui_check_data_values, tui_data_window::do_scroll_vertical):
2372         Update.
2373         * tui/tui-regs.c (tui_last_regs_line_no)
2374         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
2375         (tui_show_registers, tui_show_register_group)
2376         (tui_display_registers_from, tui_display_reg_element_at_line)
2377         (tui_display_registers_from_line, tui_check_register_values)
2378         (tui_reg_next, tui_reg_prev): Update.
2379         * tui/tui-layout.c (tui_set_layout, show_data): Update.
2380         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
2381         tui_data_window.
2382         (struct tui_win_info) <detail>: Remove.  Add new fields from
2383         tui_data_info.
2384         (TUI_DATA_WIN): Add cast.
2385         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
2386         (~tui_data_window): Simplify.
2387
2388 2019-06-25  Tom Tromey  <tom@tromey.com>
2389
2390         * tui/tui-layout.c (show_source_disasm_command)
2391         (show_source_or_disasm_and_command): Update.
2392         * tui/tui-io.c (update_cmdwin_start_line)
2393         (tui_redisplay_readline): Update.
2394         * tui/tui-data.h (struct tui_command_info): Remove.
2395         (struct tui_win_info) <detail>: Remove command_info member.
2396         (struct tui_data_window) <start_line>: New member, from
2397         tui_command_info.
2398         (TUI_CMD_WIN): Add casts.
2399
2400 2019-06-25  Tom Tromey  <tom@tromey.com>
2401
2402         * tui/tui-winsource.c (tui_update_source_window)
2403         (tui_refill_source_window)
2404         (tui_source_window_base::do_scroll_horizontal)
2405         (tui_update_breakpoint_info, tui_set_exec_info_content)
2406         (tui_show_exec_info_content, tui_erase_exec_info_content)
2407         (tui_clear_exec_info_content): Update.
2408         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
2409         Update.
2410         * tui/tui-win.c (make_invisible_and_set_new_height)
2411         (make_visible_with_new_height): Update.
2412         * tui/tui-source.c (tui_set_source_content)
2413         (tui_show_symtab_source): Update.
2414         * tui/tui-layout.c (extract_display_start_addr)
2415         (show_source_disasm_command, show_data)
2416         (make_source_or_disasm_window)
2417         (show_source_or_disasm_and_command): Update.
2418         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
2419         (tui_disasm_window::do_scroll_vertical): Remove shadowing
2420         "gdbarch".
2421         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
2422         to tui_source_window_base.
2423         (struct tui_win_info) <detail>: Remove source_info member.
2424         (struct tui_source_window_base) <has_locator>: Inline.
2425         Move contents from tui_source_info; rename has_locator member to
2426         m_has_locator.
2427         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
2428         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
2429         header file.
2430         (tui_source_window_base::clear_detail, ~tui_source_window_base):
2431         Simplify.
2432         (tui_free_all_source_wins_content): Cast to
2433         tui_source_window_base.
2434
2435 2019-06-25  Tom Tromey  <tom@tromey.com>
2436
2437         * tui/tui-win.c (make_invisible_and_set_new_height)
2438         (make_visible_with_new_height): Call has_locator method.
2439         * tui/tui-layout.c (show_source_disasm_command, show_data)
2440         (show_source_or_disasm_and_command): Update for bool change.
2441         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
2442         (tui_win_info) <has_locator>: New method.
2443         (struct tui_source_window_base) <has_locator>: New method.
2444         (tui_win_has_locator): Don't declare.
2445         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
2446         from tui_win_has_locator.
2447         (tui_source_window_base): Use false, not FALSE.
2448
2449 2019-06-25  Tom Tromey  <tom@tromey.com>
2450
2451         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
2452         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
2453         clear_detail method directly.
2454         (tui_clear_win_detail): Remove.
2455
2456 2019-06-25  Tom Tromey  <tom@tromey.com>
2457
2458         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
2459         "this", not TUI_DISASM_WIN.
2460
2461 2019-06-25  Tom Tromey  <tom@tromey.com>
2462
2463         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
2464         declare.
2465         * tui/tui-winsource.c
2466         (tui_source_window_base::do_scroll_horizontal): Rename from
2467         tui_horizontal_source_scroll.
2468         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
2469         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
2470         from tui_vertical_data_scroll.
2471         * tui/tui-win.h (tui_scroll): Don't declare.
2472         * tui/tui-win.c (tui_win_info::forward_scroll)
2473         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
2474         (tui_win_info::right_scroll): Rename and update.
2475         (tui_scroll_forward_command, tui_scroll_backward_command)
2476         (tui_scroll_left_command, tui_scroll_right_command): Update.
2477         (tui_scroll): Remove.
2478         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
2479         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
2480         from tui_vertical_source_scroll.
2481         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
2482         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
2483         from tui_vertical_disassem_scroll.
2484         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
2485         do_scroll_horizontal>: New methods.
2486         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
2487         Likewise.
2488         (struct tui_source_window_base): Add do_scroll_horizontal.
2489         (struct tui_source_window, struct tui_disasm_window): Add
2490         do_scroll_vertical.
2491         (struct tui_data_window, struct tui_cmd_window): Add
2492         do_scroll_horizontal and do_scroll_vertical.
2493         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
2494
2495 2019-06-25  Tom Tromey  <tom@tromey.com>
2496
2497         * tui/tui-data.h (struct tui_source_window_base): New struct.
2498         (struct tui_source_window): Derive from tui_source_window_base.
2499         (struct tui_disasm_window): New struct.
2500         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
2501         from tui_source_window::clear_detail.
2502         (tui_source_window_base): Rename from tui_source_window.
2503         (~tui_source_window_base): Rename from ~tui_source_window.
2504         (tui_alloc_win_info): Create a tui_disasm_window.
2505
2506 2019-06-25  Tom Tromey  <tom@tromey.com>
2507
2508         * tui/tui-data.h (struct tui_source_window)
2509         (struct tui_data_window): Declare destructors.
2510         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
2511         destructors.
2512         (tui_win_info): Simplify.
2513
2514 2019-06-25  Tom Tromey  <tom@tromey.com>
2515
2516         * tui/tui-winsource.c (tui_display_main)
2517         (tui_update_source_windows_with_addr)
2518         (tui_update_all_breakpoint_info): Update.
2519         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2520         (new_height_ok, parse_scrolling_args): Update.
2521         * tui/tui-stack.c (tui_show_frame_info): Update.
2522         * tui/tui-data.h (struct tui_list): Remove.
2523         (tui_source_windows): Return a reference to a std::vector.
2524         * tui/tui-data.c (source_windows): Now a std::vector.
2525         (tui_source_windows): Change return type.
2526         (tui_clear_source_windows): Rewrite.
2527         (tui_clear_source_windows_detail, tui_add_to_source_windows)
2528         (tui_free_all_source_wins_content): Rewrite.
2529
2530 2019-06-25  Tom Tromey  <tom@tromey.com>
2531
2532         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
2533         (struct tui_data_window, struct tui_cmd_window): Declare
2534         clear_detail method.
2535         * tui/tui-data.c (tui_source_window::clear_detail)
2536         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
2537         methods.
2538         (tui_clear_win_detail): Simplify.
2539
2540 2019-06-25  Tom Tromey  <tom@tromey.com>
2541
2542         * tui/tui-layout.c (make_source_window, make_disasm_window)
2543         (make_source_or_disasm_window): Remove win_info_ptr parameter.
2544         Return the new window.
2545         (show_source_disasm_command, show_data)
2546         (show_source_or_disasm_and_command): Update.
2547
2548 2019-06-25  Tom Tromey  <tom@tromey.com>
2549
2550         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
2551         parameter.  Return the new window.
2552         (show_source_disasm_command): Update and remove NULL check.
2553         (show_source_or_disasm_and_command): Update.
2554
2555 2019-06-25  Tom Tromey  <tom@tromey.com>
2556
2557         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
2558
2559 2019-06-25  Tom Tromey  <tom@tromey.com>
2560
2561         * tui/tui-data.h (struct tui_win_info): Make constructor
2562         protected.  Make destructor virtual.  Add initializers.
2563         (tui_source_window, tui_data_window, tui_cmd_window): New
2564         classes.
2565         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
2566         constructor.  Add "type" parameter.
2567         (tui_source_window, tui_data_window, tui_cmd_window): New
2568         constructors.
2569         (tui_alloc_win_info): Instantiate the appropriate subclass.
2570
2571 2019-06-25  Tom Tromey  <tom@tromey.com>
2572
2573         * tui/tui-win.c (tui_resize_all): Use delete.
2574         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
2575         destructor.
2576         (tui_free_window): Don't declare.
2577         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
2578         Update.
2579
2580 2019-06-25  Tom Tromey  <tom@tromey.com>
2581
2582         * tui/tui-data.h (struct tui_win_info): Add constructor.
2583         * tui/tui-data.c (tui_alloc_win_info): Use new.
2584         (tui_free_window): Use delete.
2585
2586 2019-06-22  Tom Tromey  <tom@tromey.com>
2587
2588         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
2589         declare.
2590         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
2591
2592 2019-06-22  Tom Tromey  <tom@tromey.com>
2593
2594         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
2595         declare.
2596         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
2597
2598 2019-06-22  Tom de Vries  <tdevries@suse.de>
2599
2600         * dwarf2read.c (create_addrmap_from_aranges)
2601         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
2602         instead of '%zu'.
2603
2604 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
2605
2606         * dwarf2read.h (dwarf2_section_info_def): Remove.
2607         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
2608         * dwarf2read.c (struct dwo_sections) <types>: Change type to
2609         std::vector<dwarf2_section_info>.
2610         (struct dwo_file) <~dwo_file>: Remove.
2611         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
2612         types field.
2613         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
2614         (dwarf2_read_debug_names): Likewise.
2615         (create_debug_types_hash_table): Change parameter type to
2616         array_view, adjust code accordingly.
2617         (dwarf2_locate_dwo_sections): Adjust to std::vector.
2618         (partial_die_info::fixup): Likewise.
2619         (determine_prefix): Likewise.
2620         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
2621
2622 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2623
2624         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
2625         gdb_bfd_ref_ptr.
2626         <~dwo_file>: Remove call to gdb_bfd_unref.
2627         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
2628         gdb_bfd_ref_ptr::get.
2629
2630 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2631
2632         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
2633         type to htab_up.
2634         * dwarf2read.c (struct dwo_file): Initialize fields.
2635         <~dwo_file>: New.
2636         (free_dwo_file): Remove, move content to ~dwo_file.
2637         (struct dwo_file_deleter): Remove.
2638         (dwo_file_up>: Remove custom deleter.
2639         (free_dwo_files): Remove.
2640         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
2641         dwo_files.
2642         (process_skeletonless_type_units): Call unique_ptr::get.
2643         (allocate_dwo_file_hash_table): Add deleter to created hash
2644         table.  Change return type to htab_up.
2645         (lookup_dwo_file_slot): Don't memset dwo_file, call
2646         unique_ptr::get.
2647         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
2648         (create_dwo_unit_in_dwp_v2): Likewise.
2649         (open_and_init_dwo_file): Likewise.
2650         (free_dwo_file_from_slot): Remove.
2651
2652 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2653
2654         * dwarf2read.h (struct dwarf2_section_info) <readin,
2655         is_virtual>: Change type to bool.
2656         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
2657         true instead of 1.
2658
2659 2019-06-19  Tom Tromey  <tom@tromey.com>
2660
2661         * tui/tui-data.h (tui_init_content_element): Don't declare.
2662
2663 2019-06-19  Tom Tromey  <tom@tromey.com>
2664
2665         * tui/tui-data.h (tui_init_win_info): Don't declare.
2666
2667 2019-06-19  Tom de Vries  <tdevries@suse.de>
2668
2669         * dwarf2read.h (abstract_to_concrete): Change type to
2670         std::unordered_map<sect_offset, std::vector<sect_offset>,
2671         gdb::hash_enum<sect_offset>>.
2672
2673 2019-06-19  Tom Tromey  <tromey@adacore.com>
2674
2675         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
2676         EVAL_AVOID_SIDE_EFFECTS specially.
2677
2678 2019-06-19  Tom Tromey  <tromey@adacore.com>
2679
2680         * source-cache.c (highlighter): New global.
2681         (source_cache::get_source_lines): Create a highlighter on demand.
2682
2683 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
2684
2685         * defs.h (deprecated_interactive_hook): Delete declaration.
2686         * interps.c (clear_interpreter_hooks): Remove use of
2687         deprecated_interactive_hook.
2688         * top.c (deprecated_interactive_hook): Delete definition.
2689         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
2690
2691 2019-06-18  Tom de Vries  <tdevries@suse.de>
2692
2693         PR gdb/24515
2694         * dwarf2read.h (abstract_to_concrete): Change type from
2695         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
2696         std::unordered_map<sect_offset, std::vector<sect_offset>>.
2697         * dwarf2read.c (read_variable): Update.
2698         (dwarf2_fetch_die_loc_sect_off): Update.
2699
2700 2019-06-17  Tom de Vries  <tdevries@suse.de>
2701
2702         PR gdb/24617
2703         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
2704         accessing parent[parent_len - 1].
2705
2706 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
2707
2708         PR gdb/24364
2709         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
2710         call dtrace_process_dof with NULL dof.
2711
2712 2019-06-16  Tom de Vries  <tdevries@suse.de>
2713
2714         PR gdb/24445
2715         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
2716
2717 2019-06-16  Tom Tromey  <tom@tromey.com>
2718
2719         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
2720         (make_all_visible): Use address of member.
2721
2722 2019-06-16  Tom Tromey  <tom@tromey.com>
2723
2724         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
2725         (tui_free_window, free_content, free_content_elements): Remove
2726         unnecessary cast.
2727         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
2728         cast.
2729         * tui/tui-regs.c (tui_show_register_group)
2730         (tui_display_registers_from, tui_display_reg_element_at_line):
2731         Remove unnecessary cast.
2732
2733 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
2734
2735         * linux-nat.c (normal_mask): Delete.
2736         (_initialize_linux_nat): Don't initialise normal_mask.
2737
2738 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
2739
2740         PR gdb/24445
2741         * dwarf-index-write.h (write_psymtabs_to_index): Add
2742         dwz_basename parameter.
2743         * dwarf-index-write.c (write_gdbindex): Move file writing to
2744         write_gdbindex_1.  Change return type void.
2745         (assert_file_size): Move up, remove filename parameter.
2746         (write_gdbindex_1): New function.
2747         (write_debug_names): Change return type to void, call
2748         assert_file_size.
2749         (struct index_wip_file): New struct.
2750         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
2751         file logic to index_wip_file.  Write index for dwz file if
2752         needed.
2753         (save_gdb_index_command): Pass basename of dwz file, if present.
2754         * dwarf-index-cache.c (index_cache::store): Obtain and pass
2755         build-id of dwz file, if present.
2756         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
2757         (dwarf2_get_dwz_file): Likewise.
2758         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
2759         (dwarf2_get_dwz_file): Likewise.
2760
2761 2019-06-16  Tom Tromey  <tom@tromey.com>
2762
2763         * coffread.c (process_coff_symbol): Use xstrdup.
2764         * value.c (create_internalvar): Use xstrdup.
2765
2766 2019-06-16  Tom Tromey  <tom@tromey.com>
2767
2768         * valops.c (value_cast, value_slice): Remove unnecessary cast.
2769         * breakpoint.c (stopin_command, stopat_command)
2770         (until_break_command, decode_location_default): Remove unnecessary
2771         cast.
2772         * utils.c (subset_compare): Remove unnecessary cast.
2773         * ada-lang.c (ada_update_initial_language): Remove unnecessary
2774         cast.
2775         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
2776         cast.
2777         * infcmd.c (path_command): Remove unnecessary cast.
2778         * coffread.c (decode_type): Remove unnecessary cast.
2779         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
2780         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
2781         * tui/tui-stack.c (tui_show_locator_content)
2782         (tui_show_frame_info): Remove unnecessary cast.
2783         * tui/tui-win.c (tui_scroll_forward_command)
2784         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
2785         (parse_scrolling_args): Remove unnecessary cast.
2786         * tui/tui-data.c (init_win_info, tui_del_window)
2787         (tui_free_window, tui_del_data_windows, tui_free_data_content)
2788         (free_content_elements): Remove unnecessary cast.
2789         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
2790         unnecessary cast.
2791         * tui/tui-source.c (tui_set_source_content)
2792         (tui_vertical_source_scroll): Remove unnecessary cast.
2793         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
2794         cast.
2795         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
2796         * tui/tui-regs.c (tui_display_registers_from)
2797         (tui_display_register): Remove unnecessary cast.
2798         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
2799         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
2800         (make_visible): Remove unnecessary cast.
2801         * tui/tui-winsource.c (tui_erase_source_content)
2802         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
2803         unnecessary cast.
2804         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
2805         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
2806         * stabsread.c (read_type, read_array_type, read_range_type):
2807         Remove unnecessary cast.
2808         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
2809         (parse_symbol, parse_type, upgrade_type, parse_external)
2810         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
2811         unnecessary cast.
2812         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
2813
2814 2019-06-16  Tom Tromey  <tom@tromey.com>
2815
2816         * tui/tui-data.c (tui_alloc_generic_win_info)
2817         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
2818         checks.
2819
2820 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
2821             Andrew Burgess  <andrew.burgess@embecosm.com>
2822
2823         * f-typeprint.c (f_print_type): Don't return early for not
2824         associated or not allocated types.
2825         (f_type_print_varspec_suffix): Add print_rank parameter and print
2826         ranks of array types in case they dangling.
2827         (f_type_print_base): Add print_rank parameter.
2828
2829 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2830
2831         * NEWS: Mention new MI commands.
2832         * break-catch-throw.c (enum exception_event_kind): Move to
2833         breakpoint.h.
2834         (print_mention_exception_catchpoint): Output text as a single
2835         message.
2836         (catch_exception_command_1): Rename to...
2837         (catch_exception_event): ...this, make non-static, update header
2838         command, and change some parameter types.
2839         (catch_catch_command): Update for changes to
2840         catch_exception_command_1.
2841         (catch_throw_command): Likewise.
2842         (catch_rethrow_command): Likewise.
2843         * breakpoint.c (enum exception_event_kind): Delete.
2844         * breakpoint.h (enum exception_event_kind): Moved here from
2845         break-catch-throw.c.
2846         (catch_exception_event): Declare.
2847         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
2848         (mi_cmd_catch_throw): New function.
2849         (mi_cmd_catch_rethrow): New function.
2850         (mi_cmd_catch_catch): New function.
2851         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
2852         'catch-catch' entries.
2853         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
2854         (mi_cmd_catch_rethrow): Declare.
2855         (mi_cmd_catch_catch): Declare.
2856
2857 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2858
2859         * annotate.c (annotate_source_line): Change return type to void,
2860         update implementation to match.
2861         * annotate.h (annotate_source_line): Change return type to void,
2862         update header comment.
2863         * stack.c (print_frame_info): Don't change what frame information
2864         is printed based on whether annotations are on or not.
2865
2866 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2867
2868         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
2869         (annotate_source): Make static.
2870         (annotate_source_line): Moved from source.c and renamed from
2871         identify_source_line.  Update the return type.
2872         * annotate.h (annotate_source): Delete declaration.
2873         (annotate_source_line): Declaration moved from source.h, and
2874         renamed from identify_source_line.  Return type updated.
2875         * source.c (identify_source_line): Moved to annotate.c and renamed
2876         to annotate_source_line.
2877         (info_line_command): Remove check of annotation_level.
2878         * source.h (identify_source_line): Move declaration to annotate.h
2879         and rename to annotate_source_line.
2880         * stack.c: Add 'annotate.h' include.
2881         (print_frame_info): Remove check of annotation_level before
2882         calling annotate_source_line.
2883
2884 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2885
2886         * source-cache.c (source_cache::get_plain_source_lines): Use
2887         open_source_file_with_line_charpos instead of just
2888         open_source_file, remove call to find_source_lines.
2889         (source_cache::get_source_lines): Likewise.
2890         * source.c (find_source_lines): Make static.
2891         (get_filename_and_charpos): Renamed into...
2892         (open_source_file_with_line_charpos): ..this along with changes to
2893         return a scoped_fd, and some other minor clean ups.
2894         (identify_source_line): Use open_source_file_with_line_charpos.
2895         (search_command_helper): Use open_source_file_with_line_charpos
2896         instead of just open_source_file, remove call to
2897         find_source_lines.
2898         * source.h (open_source_file_with_line_charpos): Declare new
2899         function.
2900         (find_source_lines): Delete declaration.
2901
2902 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2903
2904         * source.c (get_filename_and_charpos): Remove fullname
2905         parameter.
2906         (identify_source_line): Update call to get_filename_and_charpos.
2907
2908 2019-06-14  Tom Tromey  <tromey@adacore.com>
2909
2910         PR gdb/24502:
2911         * ui-style.h (skip_ansi_escape): Update comment.
2912         * ui-file.h (class no_terminal_escape_file): New class.
2913         * ui-file.c (no_terminal_escape_file::write)
2914         (no_terminal_escape_file::puts): New methods.
2915         * cli/cli-logging.c (handle_redirections): Use
2916         no_terminal_escape_file.
2917
2918 2019-06-14  Tom Tromey  <tromey@adacore.com>
2919
2920         * NEWS: Move convenience variable news above Python news.
2921
2922 2019-06-14  Tom Tromey  <tom@tromey.com>
2923
2924         * gnulib: Move directory to top-level.
2925         * configure.ac: Don't configure gnulib.
2926         * configure: Rebuild.
2927         * common/common-defs.h: Use new path to gnulib.
2928         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
2929         (GNULIB_H): Remove.
2930         (INCGNU): Look in new gnulib location.
2931         (HFILES_NO_SRCDIR): Remove gnulib files.
2932         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
2933         (generated_files): Remove GNULIB_H.
2934         ($(LIBGNU), all-lib): Remove targets.
2935         (distclean): Don't mention GNULIB_BUILDDIR.
2936         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
2937
2938 2019-06-14  Tom Tromey  <tromey@adacore.com>
2939
2940         * symfile.c (add_symbol_file_command): Remove obsolete comment.
2941         Warn if symbol file does not provide any symbols.
2942
2943 2019-06-14  Tom Tromey  <tromey@adacore.com>
2944
2945         * source.c (find_and_open_source): Respect basenames_may_differ.
2946
2947 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
2948
2949         * annotate.c (annotate_breakpoints_invalid): Make use of
2950         scoped_restore_terminal_state.
2951         (annotate_frames_invalid): Likewise.
2952
2953 2019-06-14  Tom Tromey  <tromey@adacore.com>
2954
2955         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
2956         allow assignment to an internalvar.
2957
2958 2019-06-14  Tom Tromey  <tromey@adacore.com>
2959
2960         * ada-lex.l: Allow "_" in attribute names.
2961
2962 2019-06-14  Tom Tromey  <tromey@adacore.com>
2963
2964         PR gdb/24653:
2965         * regcache.c (registers_changed): Don't call alloca.
2966         * top.c (execute_command): Don't call alloca.
2967
2968 2019-06-13  Pedro Alves  <palves@redhat.com>
2969
2970         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
2971         'expression'.  When parsing an expression, error out if there's
2972         junk after "unlimited".
2973         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2974         (do_set_command): Adjust calls to is_unlimited_literal.
2975
2976 2019-06-13  Pedro Alves  <palves@redhat.com>
2977
2978         * compile/compile.c (make_compile_options_def_group): Add braces
2979         around array_view initializer.
2980         * thread.c (make_thread_apply_all_options_def_group)
2981         (make_thread_apply_all_options_def_group): Likewise.
2982
2983 2019-06-13  Pedro Alves  <palves@redhat.com>
2984
2985         * NEWS (New commands): Mention "maint test-options
2986         require-delimiter", "maint test-options unknown-is-error", "maint
2987         test-options unknown-is-operand" and "maint show
2988         test-options-completion-result".
2989         (New command options, command completion): New section.
2990         (Completion improvements): New section.
2991         Mention that you can abbreviate "unlimited".
2992
2993 2019-06-13  Pedro Alves  <palves@redhat.com>
2994
2995         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
2996         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
2997         * unittests/cli-utils-selftests.c (test_parse_flags)
2998         (test_parse_flags_qcs): Delete.
2999         (test_cli_utils): Don't call deleted functions.
3000
3001 2019-06-13  Pedro Alves  <palves@redhat.com>
3002
3003         * thread.c: Include "cli/cli-option.h".
3004         (tp_array_compar_ascending): Global.
3005         (tp_array_compar): Delete function.
3006         (tp_array_compar_ascending, tp_array_compar_descending): New
3007         functions.
3008         (ascending_option_def, qcs_flag_option_def)
3009         (thr_qcs_flags_option_defs)
3010         (make_thread_apply_all_options_def_group)
3011         (make_thread_apply_options_def_group): New.
3012         (thread_apply_all_command): Use gdb::option::process_options.
3013         (thread_apply_command_completer)
3014         (thread_apply_all_command_completer): New.
3015         (thread_apply_command): Use gdb::option::process_options.
3016         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
3017         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
3018         to generate help text of "thread apply".  Adjust "taas"'s help.
3019         * tid-parse.c (tid_range_parser::in_thread_range): New method.
3020         * tid-parse.h (tid_range_parser::in_thread_range): New method.
3021
3022 2019-06-13  Pedro Alves  <palves@redhat.com>
3023
3024         * thread.c (thread_apply_command): Check for invalid TID with
3025         isdigit instead of !isalpha.
3026
3027 2019-06-13  Pedro Alves  <palves@redhat.com>
3028
3029         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
3030         (validate_flags_qcs): New.
3031         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
3032         (validate_flags_qcs): Declare.
3033         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
3034         (make_frame_apply_options_def_group): New.
3035         (frame_apply_command_count): Process options with
3036         gdb::option::process_options.
3037         (frame_apply_completer): New.
3038         (frame_apply_level_completer, frame_apply_all_completer)
3039         (frame_apply_completer): New.
3040         (_initialize_stack): Update help of "frame apply", "frame apply
3041         level", "frame apply all" and "faas" to mention supported options
3042         and install command completers.
3043         * stack.h (frame_apply_all_completer): Declare.
3044         * thread.c: Include "stack.h".
3045         (tfaas_command): Add "--".
3046         (_initialize_thread): Update help "tfaas" to mention supported
3047         options and install command completer.
3048
3049 2019-06-13  Pedro Alves  <palves@redhat.com>
3050
3051         * completer.c (complete_nested_command_line): New.
3052         (gdb_completion_word_break_characters_throw): Add assertion.
3053         * completer.h (complete_nested_command_line): Declare.
3054
3055 2019-06-13  Pedro Alves  <palves@redhat.com>
3056
3057         * stack.c (parse_backtrace_qualifiers): New.
3058         (backtrace_command): Use it.
3059         (backtrace_command_completer): Complete on qualifiers.
3060
3061 2019-06-13  Pedro Alves  <palves@redhat.com>
3062
3063         * frame.c: Include "cli/cli-option.h.
3064         (user_set_backtrace_options): New.
3065         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
3066         Delete.
3067         (get_prev_frame): Adjust.
3068         (boolean_option_def, uinteger_option_def)
3069         (set_backtrace_option_defs): New.
3070         (_initialize_frame): Adjust and use
3071         gdb::option::add_setshow_cmds_for_options to install "set
3072         backtrace past-main" and "set backtrace past-entry".
3073         * frame.h: Include "cli/cli-option.h".
3074         (struct frame_print_options): Forward declare.
3075         (print_frame_arguments_all, print_frame_arguments_scalars)
3076         (print_frame_arguments_none): Declare.
3077         (print_entry_values): Delete declaration.
3078         (struct frame_print_options, user_frame_print_options): New.
3079         (struct set_backtrace_options): New.
3080         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
3081         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
3082         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
3083         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
3084         (list_args_or_locals): Add frame_print_options parameter.
3085         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
3086         * python/py-framefilter.c (enumerate_args): Pass down
3087         USER_FRAME_PRINT_OPTIONS.
3088         * stack.c: Include "cli/cli-option.h".
3089         (print_frame_arguments_all, print_frame_arguments_scalars)
3090         (print_frame_arguments_none): Declare.
3091         (print_raw_frame_arguments, print_entry_values): Delete.
3092         (user_frame_print_options): New.
3093         (boolean_option_def, enum_option_def, frame_print_option_defs):
3094         New.
3095         (struct backtrace_cmd_options): New.
3096         (bt_flag_option_def): New.
3097         (backtrace_command_option_defs): New.
3098         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
3099         (print_frame_arg, read_frame_arg, print_frame_args)
3100         (print_frame_info, print_frame): Add frame_print_options parameter
3101         and use it.
3102         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
3103         (backtrace_command_1): Add frame_print_options and
3104         backtrace_cmd_options parameters and use them.
3105         (make_backtrace_options_def_group): New.
3106         (backtrace_command): Process command options with
3107         gdb::option::process_options.
3108         (backtrace_command_completer): New.
3109         (_initialize_stack): Extend "backtrace"'s help to mention
3110         supported options.  Install completer for "backtrace".
3111         Install some settings commands with add_setshow_cmds_for_options.
3112
3113 2019-06-13  Pedro Alves  <palves@redhat.com>
3114
3115         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
3116         and that "set/show print raw frame-arguments" are now deprecated.
3117
3118         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
3119         command.
3120         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
3121         * stack.c (_initialize_stack): Install "set/show print
3122         raw-frame-arguments", and deprecate "set/show print raw
3123         frame-arguments".
3124         * valprint.c (_initialize_valprint): Deprecate "set/show print
3125         raw".
3126
3127 2019-06-13  Pedro Alves  <palves@redhat.com>
3128
3129         * compile/compile.c (struct compile_options): New.
3130         (compile_flag_option_def, compile_command_option_defs)
3131         (make_compile_options_def_group): New.
3132         (compile_file_command): Handle options with
3133         gdb::option::process_options.
3134         (compile_file_command_completer): New function.
3135         (compile_code_command): Handle options with
3136         gdb::option::process_options.
3137         (compile_code_command_completer): New function.
3138         (_initialize_compiler): Install completers for "compile code" and
3139         "compile file".  Mention available options in "compile code" and
3140         "compile code"'s help.
3141         * completer.c (advance_to_completion_word): New, factored out from
3142         ...
3143         (advance_to_expression_complete_word_point): ... this.
3144         (advance_to_filename_complete_word_point): New.
3145         * completer.h (advance_to_filename_complete_word_point): New
3146         declaration.
3147
3148 2019-06-13  Pedro Alves  <palves@redhat.com>
3149
3150         * compile/compile.c: Include "cli/cli-option.h".
3151         (compile_print_value): Scope data pointer is now a
3152         value_print_options pointer; adjust.
3153         (compile_print_command): Process options.  Scope data pointer is
3154         now a value_print_options pointer; adjust.
3155         (_initialize_compile): Update "compile print"'s help to include
3156         supported options.  Install a completer for "compile print".
3157         * cp-valprint.c (show_vtblprint, show_objectprint)
3158         (show_static_field_print): Delete.
3159         (_initialize_cp_valprint): Don't install "set print
3160         static-members", "set print vtbl", "set print object" here.
3161         * printcmd.c: Include "cli/cli-option.h" and
3162         "common/gdb_optional.h".
3163         (print_command_parse_format): Rework to fill in a
3164         value_print_options instead of a format_data.
3165         (print_value): Change parameter type from format_data pointer to
3166         value_print_options reference.  Adjust.
3167         (print_command_1): Process options.  Adjust to pass down a
3168         value_print_options.
3169         (print_command_completer): New.
3170         (_initialize_printcmd): Install print_command_completer as
3171         handle_brkchars completer for the "print" command.  Update
3172         "print"'s help to include supported options.
3173         * valprint.c: Include "cli/cli-option.h".
3174         (show_vtblprint, show_objectprint, show_static_field_print): Moved
3175         here from cp-valprint.c.
3176         (boolean_option_def, uinteger_option_def)
3177         (value_print_option_defs, make_value_print_options_def_group):
3178         New.  Use gdb::option::add_setshow_cmds_for_options to install
3179         "set print elements", "set print null-stop", "set print repeats",
3180         "set print pretty", "set print union", "set print array", "set
3181         print address", "set print symbol", "set print array-indexes".
3182         * valprint.h: Include <string> and "cli/cli-option.h".
3183         (make_value_print_options_def_group): Declare.
3184         (print_value): Change parameter type from format_data pointer to
3185         value_print_options reference.
3186         (print_command_completer): Declare.
3187
3188 2019-06-13  Pedro Alves  <palves@redhat.com>
3189
3190         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
3191         (COMMON_SFILES): Add maint-test-settings.c.
3192         * cli/cli-decode.c (boolean_enums): New global, factored out from
3193         ...
3194         (add_setshow_boolean_cmd): ... here.
3195         * cli/cli-decode.h (boolean_enums): Declare.
3196         * cli/cli-option.c: New file.
3197         * cli/cli-option.h: New file.
3198         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
3199         factored out from ...
3200         (parse_cli_boolean_value(const char *)): ... this.
3201         (is_unlimited_literal): Change parameter type to pointer to
3202         pointer.  Adjust and advance ARG pointer.
3203         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
3204         (parse_cli_var_enum): New, factored out from ...
3205         (do_set_command): ... this.  Adjust.
3206         * cli/cli-setshow.h (parse_cli_boolean_value)
3207         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
3208         (parse_cli_var_enum): Declare.
3209         * cli/cli-utils.c: Include "cli/cli-option.h".
3210         (get_ulongest): New.
3211         * cli/cli-utils.h (get_ulongest): Declare.
3212         (check_for_argument): New overloads.
3213         * maint-test-options.c: New file.
3214
3215 2019-06-13  Pedro Alves  <palves@redhat.com>
3216
3217         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
3218         parse a range if "-" is at the end of the string.
3219
3220 2019-06-13  Pedro Alves  <palves@redhat.com>
3221
3222         * cli/cli-setshow.c (parse_auto_binary_operation)
3223         (parse_cli_boolean_value): Don't allow "o".
3224
3225 2019-06-13  Pedro Alves  <palves@redhat.com>
3226
3227         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
3228         * NEWS: Mention maint test-settings KIND.
3229         * maint-test-settings.c: New file.
3230
3231 2019-06-13  Pedro Alves  <palves@redhat.com>
3232
3233         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
3234         completer.
3235         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
3236         "set" completers.
3237
3238 2019-06-13  Pedro Alves  <palves@redhat.com>
3239
3240         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
3241         after item.
3242
3243 2019-06-13  Pedro Alves  <palves@redhat.com>
3244
3245         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
3246
3247 2019-06-13  Pedro Alves <palves@redhat.com>
3248
3249         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
3250         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
3251         call.
3252         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
3253         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
3254         calls.
3255         (check_for_argument): Skip spaces after argument.
3256
3257 2019-06-13  Pedro Alves  <palves@redhat.com>
3258
3259         * thread.c (thread_apply_command): Adjust TID parsing.
3260         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
3261         detected before end of string.
3262         (tid_is_in_list): Error out if LIST is invalid.
3263
3264 2019-06-13  Pedro Alves  <palves@redhat.com>
3265
3266         * completer.c (complete_line_internal_1): Rewind completion word
3267         point.
3268         (completion_tracker::advance_custom_word_point_by): Change
3269         parameter type to int.
3270         * completer.h (completion_tracker::advance_custom_word_point_by):
3271         Likewise.
3272
3273 2019-06-13  Pedro Alves  <palves@redhat.com>
3274
3275         * completer.c (advance_to_completion_word): Handle delimiters.
3276
3277 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
3278
3279         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
3280
3281 2019-06-11  Tom Tromey  <tom@tromey.com>
3282
3283         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
3284         (xmalloc_failed): Move to alloc.c.
3285         * alloc.c: New file.
3286         * Makefile.in (COMMON_SFILES): Add alloc.c.
3287
3288 2019-06-11  Tom Tromey  <tom@tromey.com>
3289
3290         * nat/linux-waitpid.c: Don't include server.h.
3291         (linux_debug): Remove.
3292         (my_waitpid): Update.
3293
3294 2019-06-11  Tom Tromey  <tromey@adacore.com>
3295
3296         * infcall.c (_initialize_infcall): Remove trailing newline from
3297         help.
3298         * user-regs.c (_initialize_user_regs): Remove trailing newline
3299         from help.
3300         * typeprint.c (_initialize_typeprint): Remove trailing newline
3301         from help.
3302         * reverse.c (_initialize_reverse): Remove trailing newlines from
3303         help.
3304         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
3305         from help.
3306         * language.c (add_set_language_command): Remove trailing newline
3307         from help.
3308         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
3309         help.
3310         * disasm.c (_initialize_disasm): Remove trailing newline from
3311         help.
3312         * top.c (init_main): Remove trailing newline from help.
3313         * interps.c (_initialize_interpreter): Remove trailing newline
3314         from help.
3315         * btrace.c (_initialize_btrace): Remove trailing newlines from
3316         help.
3317         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
3318         from help.
3319         * python/python.c (_initialize_python): Remove trailing newline
3320         from help.
3321         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
3322         help.
3323         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
3324         from help.  Reformat some text.
3325         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
3326         from help.
3327         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
3328         newline from help.
3329
3330 2019-06-11  Tom Tromey  <tromey@adacore.com>
3331
3332         * darwin-nat.c (darwin_decode_exception_message)
3333         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
3334
3335 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
3336
3337         * valops.c (value_slice): Check for not allocated or not
3338         associated values.
3339
3340 2019-06-10  Tom de Vries  <tdevries@suse.de>
3341
3342         PR gdb/24618
3343         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
3344         sure an empty slot (defined by a 32-bit zero pair) is recognized as
3345         invalid.
3346
3347 2019-06-10  Tom de Vries  <tdevries@suse.de>
3348
3349         PR gdb/24611
3350         * linespec.c (linespec_lexer_lex_string): Remove incorrect
3351         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
3352
3353 2019-06-10  Tom de Vries  <tdevries@suse.de>
3354
3355         PR symtab/24545
3356         * symtab.c (struct demangled_name_entry): Add language field.
3357         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
3358         static minimal symbol".  Set and use language field.
3359
3360 2019-06-10  Tom Tromey  <tromey@adacore.com>
3361
3362         * ada-lang.c (_initialize_ada_language): Update help text.
3363
3364 2019-06-10  Tom Tromey  <tromey@adacore.com>
3365
3366         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
3367         with a newline.
3368         * guile/guile.c (handle_boot_error): Don't end warning with a
3369         newline.
3370         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
3371         warning with a newline.
3372         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
3373         newline.
3374         (s12z_frame_cache): Likewise.
3375         * dwarf-index-cache.c (index_cache::store): Don't end warning with
3376         a newline.
3377         * solib-svr4.c (disable_probes_interface): Don't end warning with
3378         a newline.
3379         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
3380         newline.
3381         * python/python.c (do_finish_initialization): Don't end warning
3382         with a newline.
3383
3384 2019-06-10  Tom Tromey  <tom@tromey.com>
3385
3386         * python/py-breakpoint.c (gdbpy_breakpoint_created)
3387         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
3388         gdbpy_enter.
3389
3390 2019-06-10  Tom Tromey  <tromey@adacore.com>
3391
3392         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
3393         data.
3394         (elf_new_init): Don't call stabsread_new_init.
3395         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
3396         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
3397         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
3398
3399 2019-06-10  Tom de Vries  <tdevries@suse.de>
3400
3401         PR symtab/16264
3402         PR symtab/24517
3403         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
3404
3405 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
3406
3407         * source.c (find_and_open_source): Also rewrite relative file
3408         names.
3409
3410 2019-04-26  Amos Bird  <amosbird@gmail.com>
3411
3412         * annotate.c (annotate_thread_exited): Add "thread-exited"
3413         annotation.
3414
3415 2019-06-06  Tom Tromey  <tromey@adacore.com>
3416
3417         * maint.h (class scoped_command_stats): Use
3418         DISABLE_COPY_AND_ASSIGN.
3419         <print_time>: New method.
3420         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
3421         print_time.
3422         (scoped_command_stats::print_time): New method.
3423
3424 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
3425
3426         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
3427         instructions of lengths 6 or 8 bytes.
3428
3429 2019-06-04  Pedro Alves  <palves@redhat.com>
3430
3431         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
3432
3433         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
3434         * breakpoint.c (condition_completer): Likewise.
3435         * cli/cli-dump.c (scan_expression): Likewise.
3436         * common/filestuff.c (mkdir_recursive): Likewise.
3437         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
3438         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
3439         (gdb_abspath): Likewise.
3440         * compile/compile-cplus-types.c
3441         (compile_cplus_instance::decl_name): Likewise.
3442         * completer.c (complete_explicit_location):
3443         (signal_completer, reg_or_group_completer_1): Likewise.
3444         * cp-support.c (cp_remove_params_if_any): Likewise.
3445         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
3446         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
3447         * infcmd.c (strip_bg_char): Likewise.
3448         * linespec.c (copy_token_string): Likewise.
3449         * mi/mi-main.c (output_cores): Likewise.
3450         * psymtab.c (psymtab_search_name):
3451         * symfile.c (test_set_ext_lang_command): Likewise.
3452         * target.c (target_fileio_read_stralloc): Likewise.
3453         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
3454         * value.c (complete_internalvar): Likewise.
3455
3456 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
3457
3458         Add objfile property to gdb.Type.
3459         * NEWS: Mention Python API addition.
3460         * python/py-type.c (typy_get_objfile): New method.
3461
3462 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3463
3464         * NEWS: Mention the new set|show style [title|highlight].
3465         Mention changes to "show style", "help" and "apropos".
3466
3467 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3468
3469         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
3470         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
3471         instead of print_help_for_command.
3472         (print_doc_of_command): New function.
3473         (help_list): Add 'apropos -v word' suggestion.
3474         (print_help_for_command): Style the command name using title style.
3475         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
3476         (_initialize_cli_cmds): Describe -v in apropos_command help.
3477
3478 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3479
3480         * cli/cli-style.h (cli_style_option): Add name in constructor,
3481         add m_name class member, add constructor with intensity,
3482         add name class function.
3483         (cli_style_option::add_setshow_commands): Remove name argument.
3484         (highlight_style, title_style): New styles.
3485         * cli/cli-style.c (do_show): New function that shows a style
3486         characteristic styling the style name with itself.
3487         (set_style_name): New function.
3488         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
3489         Update all callers according to the changes in cli/cli-style.h.
3490         * utils.h (fputs_highlighted): New function.
3491         * utils.c (fputs_highlighted): Likewise.
3492
3493 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3494
3495         * NEWS: Mention new pipe command and new convenience variables.
3496
3497 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3498
3499         * cli/cli-cmds.c (pipe_command): New function.
3500         (_initialize_cli_cmds): Call add_com for pipe_command.
3501         Define | as an alias for pipe.
3502         (exit_status_set_internal_vars): New function.
3503         (shell_escape): Call exit_status_set_internal_vars.
3504         cli/cli-decode.c (find_command_name_length): Recognize | as
3505         a single character command.
3506
3507 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3508
3509         * gdbcmd.h (execute_command_to_ui_file): New declaration.
3510         top.c (execute_command_to_ui_file): New function, mostly a copy
3511         of execute_command_to_string.
3512         (execute_command_to_string): Implement by calling
3513         execute_command_to_ui_file.
3514
3515 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3516
3517         * top.h (saved_command_line): Remove declaration.
3518         * top.c (previous_saved_command_line, previous_repeat_arguments):
3519         New variables.
3520         (saved_command_line): Make static, define together with other
3521         'repeat variables'.
3522         (dont_repeat): Clear repeat_arguments.
3523         (repeat_previous, get_saved_command_line, save_command_line):
3524         New functions.
3525         (gdb_init): Initialize saved_command_line
3526         and previous_saved_command_line.
3527         * main.c (captured_main_1): Remove saved_command_line initialization.
3528         * event-top.c (handle_line_of_input): Update to use
3529         the new 'repeat' related functions instead of direct access to
3530         saved_command_line.
3531         * command.h (repeat_previous, get_saved_command_line,
3532         save_command_line): New declarations.
3533         (dont_repeat): Add comment.
3534
3535 2019-05-30  Tom Tromey  <tromey@adacore.com>
3536
3537         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
3538         Fix comment.
3539         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
3540
3541 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
3542
3543         PR cli/24587
3544         * completer.c (complete): Initialize variable word.
3545
3546 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
3547
3548         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
3549         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
3550         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
3551         'body' is NULL to the outter 'if', protecting the '!is_define'
3552         situation as well.
3553
3554 2019-05-29  Tom Tromey  <tromey@adacore.com>
3555
3556         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
3557         (dwarf_unknown): New function.
3558         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
3559         (dwarf_type_encoding_name): Use dwarf_unknown.
3560
3561 2019-05-29  Tom Tromey  <tromey@adacore.com>
3562
3563         PR c++/20020:
3564         * cp-valprint.c (cp_print_value_fields): Call
3565         cp_print_static_field inside "try".
3566
3567 2019-05-29  Tom Tromey  <tromey@adacore.com>
3568
3569         * inflow.c (struct terminal_info): Add default operator=.
3570         * configure: Rebuild.
3571         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
3572         -Wdeprecated-copy-dtor, -Wredundant-move.
3573
3574 2019-05-29  Tom Tromey  <tromey@adacore.com>
3575
3576         * NEWS: Add entry.
3577         * infcmd.c (print_return_value_1): Handle finish_print
3578         option.
3579         (show_print_finish): New function.
3580         (_initialize_infcmd): Add "set/show print finish" commands.
3581         * valprint.c (user_print_options): Initialize new member.
3582         * valprint.h (struct value_print_options) <finish_print>: New
3583         member.
3584
3585 2019-05-28  Tom Tromey  <tromey@adacore.com>
3586
3587         * ada-lang.c (ada_remove_Xbn_suffix)
3588         (find_old_style_renaming_symbol)
3589         (parse_old_style_renaming): Remove.
3590         (ada_find_renaming_symbol): Don't call
3591         find_old_style_renaming_symbol.
3592         (ada_is_renaming_symbol): Rename from
3593         ada_find_renaming_symbol.  Remove "block" parameter.  Return
3594         bool.  Now static.
3595         (ada_read_var_value): Update and simplify.
3596         * ada-exp.y (write_var_or_type): Remove old code.
3597
3598 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
3599
3600         * event-top.c: Remove include comment.
3601         * inflow.c (class scoped_ignore_sigttou): Move from here...
3602         * inflow.h (class scoped_ignore_sigttou): ...to here.
3603         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
3604         * top.c:  Remove include comment.
3605
3606 2019-05-27  Tom Tromey  <tom@tromey.com>
3607
3608         * NEWS: Fix typo.
3609
3610 2019-05-22  Tom Tromey  <tromey@adacore.com>
3611
3612         * target.c (target_follow_exec): Constify parameter.
3613         * target-delegates.c: Rebuild.
3614         * remote.c (remote_target::follow_exec): Constify parameter.
3615         * infrun.c (follow_exec): Constify parameter.
3616         * target.h (struct target_ops) <follow_exec>: Constify parameter.
3617         (target_follow_exec): Likewise.
3618
3619 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
3620
3621         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
3622         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
3623
3624 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
3625
3626         * NEWS: Add debugredirect and testsuite sections.
3627
3628 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
3629
3630         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
3631         target descriptions using exclusively floating point register name
3632         aliases.
3633
3634 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
3635
3636         PR gdb/18644:
3637         * f-lang.c (build_fortran_types): Handle the case where
3638         gdbarch_floatformat_for_type returns a nullptr.
3639
3640 2019-05-21  Tom de Vries  <tdevries@suse.de>
3641
3642         PR cli/24587
3643         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
3644
3645 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3646
3647         PR gdb/18644:
3648         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
3649         16-byte floats.
3650         * i386-tdep.c (i386_floatformat_for_type): Use
3651         floatformats_ia64_quad for the 16-byte floating point component
3652         within a fortran 32-byte complex number.
3653
3654 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3655
3656         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
3657         delete default constructor.
3658         (find_partial_die): Update to return const struct.
3659         (partial_die_parent_scope): Move variable declaration into scope
3660         of its use and change its type to auto.
3661         (guess_partial_die_structure_name): Likewise.
3662         (partial_die_info::fixup): Likewise.
3663
3664 2019-05-17  Tom Tromey  <tromey@adacore.com>
3665
3666         * source.c (find_and_open_source): Remove cast.
3667
3668 2019-05-17  Tom Tromey  <tromey@adacore.com>
3669
3670         * annotate.c (annotate_source): Make "filename" const.
3671         * annotate.h (annotate_source): Use const.
3672
3673 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3674
3675         * disasm.c (set_disassembler_options): Send errors to stderr.
3676
3677 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3678
3679         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
3680         (cli_interp_base::set_logging): Check debug_redirect.
3681         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
3682         * cli/cli-logging.c (debug_redirect): Add static variable.
3683         (pop_output_files): Add default param.
3684         (handle_redirections): Print debug setting.
3685         (show_logging_command): Likewise.
3686         (_initialize_cli_logging): Add debugredirect command.
3687         * interps.c (current_interp_set_logging): Add debug_redirect
3688         parameter.
3689         * interps.h (set_logging): Add debug_redirect parameter.
3690         (current_interp_set_logging): Likewise.
3691         * mi/mi-common.h: Likewise.
3692         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
3693
3694 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3695             Tom Tromey  <tromey@adacore.com>
3696
3697         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
3698         directly.
3699         * cli/cli-interp.h (make_logging_output): Remove declaration.
3700         * cli/cli-logging.c (make_logging_output): Remove function.
3701         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
3702         directly.
3703         * ui-file.c (tee_file::tee_file): Remove bools.
3704         (tee_file::~tee_file): Remove deletes.
3705         * ui-file.h (tee_file): Remove bools.
3706
3707 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
3708
3709         * mi/mi-cmds.h (mi_cmd_complete): New function.
3710         * mi/mi-main.c (mi_cmd_complete): Likewise.
3711         * mi/mi-cmds.c: Define new MI command -complete.
3712         * NEWS: Mention new -complete command.
3713
3714 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
3715
3716         * completer.h (complete): New function.
3717         * completer.c (complete): Likewise.
3718         * cli/cli-cmds.c: (complete_command): Update to use new complete()
3719         function defined in completer.h.
3720
3721 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
3722
3723         * MAINTAINERS (Write After Approval): Add myself.
3724
3725 2019-05-17  Tom de Vries  <tdevries@suse.de>
3726
3727         PR gdb/24094
3728         * dwarf2read.c (struct cu_partial_die_info): New struct.
3729         (find_partial_die): Return cu_partial_die_info.
3730         (partial_die_parent_scope, guess_partial_die_structure_name)
3731         (partial_die_info::fixup): Handle new return type of find_partial_die.
3732
3733 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3734
3735         * stap-probe.c (stap_parse_register_operand): Make "regname" an
3736         "std::string", simplifying the algorithm.
3737
3738 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3739
3740         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
3741         (stap_static_probe_ops::get_probes): Likewise.
3742
3743 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3744
3745         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
3746         '-')" and "else if".
3747         (stap_parse_single_operand): Join checks for
3748         "gdbarch_stap_parse_special_token_p" and
3749         "gdbarch_stap_parse_special_token" in the same "if" statement.
3750         Invert check when verifying for operation on register
3751         displacement.
3752
3753 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3754
3755         * stap-probe.c (stap_get_opcode): Update comment.
3756         (stap_get_expected_argument_type): Likewise.
3757         (handle_stap_probe): Likewise.
3758
3759 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3760
3761         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
3762         return type to 'bool'.  Adjust comment.  Use 'bool' when
3763         appropriate.
3764         (i386_stap_parse_special_token_three_arg_disp): Likewise.
3765         * stap-probe.c (stap_parse_argument_1): Likewise.
3766         (stap_is_operator): Likewise.
3767         (stap_is_generic_prefix): Likewise.
3768         (stap_is_register_prefix): Likewise.
3769         (stap_is_register_indirection_prefix): Likewise.
3770         (stap_is_integer_prefix): Likewise.
3771         (stap_generic_check_suffix): Likewise.
3772         (stap_check_integer_suffix): Likewise.
3773         (stap_check_register_suffix): Likewise.
3774         (stap_check_register_indirection_suffix): Likewise.
3775         (stap_parse_register_operand): Likewise.
3776         (stap_parse_single_operand): Likewise.
3777         (stap_parse_argument_1): Likewise.
3778         (stap_probe::get_argument_count): Likewise.
3779         (stap_is_operator): Likewise.
3780
3781 2019-05-16  Tom Tromey  <tromey@adacore.com>
3782
3783         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
3784         keyword to foreach.
3785
3786 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
3787
3788         * linux-thread-db.c (try_thread_db_load_1): Change return type
3789         to bool.
3790         (try_thread_db_load): Likewise.
3791         (try_thread_db_load_from_pdir_1): Likewise.
3792         (try_thread_db_load_from_pdir): Likewise.
3793         (try_thread_db_load_from_sdir): Likewise.
3794         (try_thread_db_load_from_dir): Likewise.
3795         (thread_db_load_search): Likewise.
3796         (has_libpthread): Likewise.
3797         (thread_db_load): Likewise.
3798
3799 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
3800
3801         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
3802         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
3803         NULL, and complain/return if that's the case.
3804
3805 2019-05-15  John Darrington <john@darrington.wattle.id.au>
3806
3807         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
3808         (advance, posn, abstract_read_memory): New functions.
3809         [struct mem_read_abstraction]: New struct.
3810         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
3811
3812 2019-05-14  Tom Tromey  <tromey@adacore.com>
3813
3814         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
3815         value is not lval_memory.
3816
3817 2019-05-14  Tom Tromey  <tromey@adacore.com>
3818
3819         * solib.c (info_sharedlibrary_command): Style the file name.
3820
3821 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
3822
3823         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
3824         (aarch64_vnv_type): Likewise.
3825         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
3826         * common/tdesc.c: Likewise.
3827         * common/tdesc.h (enum tdesc_type_kind): Likewise.
3828         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
3829         * features/aarch64-fpu.xml: Add ieee half view.
3830         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
3831         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
3832         * gdbtypes.h (struct builtin_type): Likewise.
3833         (struct objfile_type): Likewise.
3834
3835 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
3836
3837         * language.c (language_sniff_from_mangled_name): Fix "langauge"
3838         typo.
3839         * location.h (string_to_event_location): Likewise.
3840
3841 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
3842
3843         GDB 8.3 released.
3844
3845 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
3846
3847         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
3848         New variable declaration.
3849         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
3850         New variable.
3851         (print_one_breakpoint): Use ui_out::test_flags and new global
3852         variable to compute use_fixed_output.
3853         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
3854         Remove.
3855         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
3856         (mi_multi_location_breakpoint_output_fixed): Remove.
3857         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
3858         new variable.
3859         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
3860         fix_multi_location_breakpoint_output flag if version >= 3.
3861         * ui-out.h (enum ui_out_flag)
3862         <fix_multi_location_breakpoint_output>: New enumerator.
3863
3864 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
3865
3866         * contrib/cc-with-tweaks.sh: Validate dwz's work.
3867
3868 2019-05-10  Tom Tromey  <tromey@adacore.com>
3869
3870         * ada-lang.c (catch_ada_completer): New function.
3871         (_initialize_ada_language): Use it.
3872
3873 2019-05-10  Tom Tromey  <tromey@adacore.com>
3874
3875         * thread.c (print_thread_info): Make "requested_threads" const.
3876         * gdbthread.h (print_thread_info): Make "requested_threads"
3877         const.
3878         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
3879         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
3880
3881 2019-05-08  Tom Tromey  <tom@tromey.com>
3882
3883         * gdbtypes.c (objfile_type_data): Change type.
3884         (objfile_type, _initialize_gdbtypes): Update.
3885
3886 2019-05-08  Tom Tromey  <tom@tromey.com>
3887
3888         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
3889         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
3890         (_initialize_dwarf2_frame): Update.
3891
3892 2019-05-08  Tom Tromey  <tom@tromey.com>
3893
3894         * objc-lang.c (objc_objfile_data): Change type.
3895         (find_methods): Update.
3896         (_initialize_objc_lang): Remove.
3897
3898 2019-05-08  Tom Tromey  <tom@tromey.com>
3899
3900         * stabsread.c (rs6000_builtin_type_data): Change type.
3901         (rs6000_builtin_type, _initialize_stabsread): Update.
3902
3903 2019-05-08  Tom Tromey  <tom@tromey.com>
3904
3905         * mips-tdep.c (mips_pdr_data): Remove.
3906         (_initialize_mips_tdep): Update.
3907
3908 2019-05-08  Tom Tromey  <tom@tromey.com>
3909
3910         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
3911         (hppa_init_objfile_priv_data, read_unwind_info)
3912         (find_unwind_entry, _initialize_hppa_tdep): Update.
3913
3914 2019-05-08  Tom Tromey  <tom@tromey.com>
3915
3916         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
3917         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
3918         on obstack.
3919         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
3920
3921 2019-05-08  Tom Tromey  <tom@tromey.com>
3922
3923         * mdebugread.c (basic_type_data): Change type.
3924         (basic_type, _initialize_mdebugread): Update.
3925
3926 2019-05-08  Tom Tromey  <tom@tromey.com>
3927
3928         * common/gdb_unique_ptr.h (struct noop_deleter): New.
3929
3930 2019-05-08  Tom Tromey  <tom@tromey.com>
3931
3932         * nto-tdep.c (nto_inferior_data_reg): Change type.
3933         (nto_inferior_data): Update.
3934         (nto_inferior_data_cleanup, nto_new_inferior_data)
3935         (_initialize_nto_tdep): Remove.
3936         * nto-tdep.h (struct nto_inferior_data): Add initializers.
3937
3938 2019-05-08  Tom Tromey  <tom@tromey.com>
3939
3940         * ada-lang.c (struct ada_inferior_data): Add initializers.
3941         (ada_inferior_data): Change type.
3942         (ada_inferior_data_cleanup): Remove.
3943         (get_ada_inferior_data, ada_inferior_exit)
3944         (struct ada_pspace_data): Add initializers, destructor.
3945         (ada_pspace_data_handle): Change type.
3946         (get_ada_pspace_data): Update.
3947         (ada_pspace_data_cleanup): Remove.
3948
3949 2019-05-08  Tom Tromey  <tom@tromey.com>
3950
3951         * coffread.c (struct coff_symfile_info): Add initializers.
3952         (coff_objfile_data_key): Move lower.  Change type.
3953         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
3954         Update.
3955         (coff_free_info): Remove.
3956
3957 2019-05-08  Tom Tromey  <tom@tromey.com>
3958
3959         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
3960         (fbsd_pspace_data_handle): Move lower.  Change type.
3961         (get_fbsd_pspace_data): Update.
3962         (fbsd_pspace_data_cleanup): Remove.
3963         (_initialize_fbsd_tdep): Update.
3964
3965 2019-05-08  Tom Tromey  <tom@tromey.com>
3966
3967         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
3968         (get_ada_tasks_pspace_data): Update.
3969         (ada_tasks_pspace_data_cleanup): Remove.
3970         (_initialize_tasks): Update.
3971         (ada_tasks_inferior_data_handle): Change type.
3972         (get_ada_tasks_inferior_data): Update.
3973         (ada_tasks_inferior_data_cleanup): Remove.
3974         (struct ada_tasks_pspace_data): Add initializers.
3975
3976 2019-05-08  Tom Tromey  <tom@tromey.com>
3977
3978         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
3979         * symfile-debug.c (debug_sym_get_probes): Change type.
3980         * stap-probe.c (handle_stap_probe):
3981         (stap_static_probe_ops::get_probes): Change type.
3982         * probe.h (class static_probe_ops) <get_probes>: Change type.
3983         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
3984         (parse_probes_in_pspace): Update.
3985         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
3986         Update.
3987         (any_static_probe_ops::get_probes): Change type.
3988         * elfread.c (elfread_data): New typedef.
3989         (probe_key): Change type.
3990         (elf_get_probes): Likewise.  Update.
3991         (probe_key_free): Remove.
3992         (_initialize_elfread): Update.
3993         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
3994         Change type.
3995         (dtrace_process_dof_probe, dtrace_process_dof)
3996         (dtrace_static_probe_ops::get_probe): Change type.
3997
3998 2019-05-08  Tom Tromey  <tom@tromey.com>
3999
4000         * xcoffread.c (struct xcoff_symfile_info): Rename from
4001         coff_symfile_info.  Add initializers.
4002         (xcoff_objfile_data_key): Move lower.  Change type.
4003         (XCOFF_DATA): Rewrite.
4004         (xcoff_free_info): Remove.
4005         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
4006         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
4007         (xcoff_initial_scan): Update.
4008
4009 2019-05-08  Tom Tromey  <tom@tromey.com>
4010
4011         * solib-svr4.c (struct svr4_info): Add initializers and
4012         destructor.
4013         <probes_table>: Now an htab_up.
4014         (solib_svr4_pspace_data): Change type.
4015         (free_probes_table): Simplify.
4016         (~svr4_info): Rename from svr4_pspace_data_cleanup.
4017         (get_svr4_info, probes_table_htab_remove_objfile_probes)
4018         (probes_table_remove_objfile_probes, register_solib_event_probe)
4019         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
4020         (_initialize_svr4_solib): Update.
4021
4022 2019-05-08  Tom Tromey  <tom@tromey.com>
4023
4024         * remote.c (remote_pspace_data): Change type.
4025         (remote_pspace_data_cleanup): Remove.
4026         (get_remote_exec_file, set_pspace_remote_exec_file)
4027         (_initialize_remote): Update.
4028
4029 2019-05-08  Tom Tromey  <tom@tromey.com>
4030
4031         * breakpoint.c (breakpoint_objfile_key): Change type.
4032         (get_breakpoint_objfile_data): Update.
4033         (free_breakpoint_objfile_data): Remove.
4034         (_initialize_breakpoint): Update.
4035
4036 2019-05-08  Tom Tromey  <tom@tromey.com>
4037
4038         * linux-tdep.c (struct linux_info): Add initializers.
4039         (linux_inferior_data): Move.  Change type.
4040         (invalidate_linux_cache_inf): Update.
4041         (linux_inferior_data_cleanup): Remove.
4042         (get_linux_inferior_data, _initialize_linux_tdep): Update.
4043
4044 2019-05-08  Tom Tromey  <tom@tromey.com>
4045
4046         * auxv.c (auxv_inferior_data): Move.  Change type.
4047         (auxv_inferior_data_cleanup): Remove.
4048         (invalidate_auxv_cache_inf): Rewrite.
4049         (get_auxv_inferior_data, _initialize_auxv): Update.
4050
4051 2019-05-08  Tom Tromey  <tom@tromey.com>
4052
4053         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
4054         (symfile_debug_objfile_data_key): Change type.
4055         (symfile_debug_installed, debug_qf_has_symbols)
4056         (debug_qf_find_last_source_symtab)
4057         (debug_qf_forget_cached_source_info)
4058         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
4059         (debug_qf_print_stats, debug_qf_dump)
4060         (debug_qf_expand_symtabs_for_function)
4061         (debug_qf_expand_all_symtabs)
4062         (debug_qf_expand_symtabs_with_fullname)
4063         (debug_qf_map_matching_symbols)
4064         (debug_qf_expand_symtabs_matching)
4065         (debug_qf_find_pc_sect_compunit_symtab)
4066         (debug_qf_map_symbol_filenames)
4067         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
4068         (debug_sym_new_init, debug_sym_init, debug_sym_read)
4069         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
4070         (debug_sym_read_linetable, debug_sym_relocate): Update.
4071         (symfile_debug_free_objfile): Remove.
4072         (install_symfile_debug_logging, _initialize_symfile_debug):
4073         Update.
4074
4075 2019-05-08  Tom Tromey  <tom@tromey.com>
4076
4077         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
4078         allocate_on_obstack.
4079         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
4080         (get_dwarf2_per_objfile): Update.
4081         (set_dwarf2_per_objfile): Remove.
4082         (dwarf2_has_info, dwarf2_get_section_info): Update.
4083         (dwarf2_free_objfile): Remove.
4084         (_initialize_dwarf2_read): Update.
4085
4086 2019-05-08  Tom Tromey  <tom@tromey.com>
4087
4088         * auto-load.c (struct auto_load_pspace_info): Add destructor and
4089         initializers.
4090         <unsupported_script_warning_printed,
4091         script_not_found_warning_printed>: Now bool.
4092         (auto_load_pspace_data): Change type.
4093         (~auto_load_pspace_info): Rename from
4094         auto_load_pspace_data_cleanup.
4095         (get_auto_load_pspace_data, init_loaded_scripts_info)
4096         (clear_section_scripts, maybe_print_unsupported_script_warning)
4097         (maybe_print_script_not_found_warning, _initialize_auto_load):
4098         Update.
4099
4100 2019-05-08  Tom Tromey  <tom@tromey.com>
4101
4102         * objfiles.c (objfile_pspace_info): Add destructor and
4103         initializers.
4104         (objfiles_pspace_data): Change type.
4105         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
4106         (get_objfile_pspace_data): Update.
4107         (objfiles_bfd_data): Change type.
4108         (get_objfile_bfd_data): Update.
4109         (objfile_bfd_data_free, _initialize_objfiles): Remove.
4110
4111 2019-05-08  Tom Tromey  <tom@tromey.com>
4112
4113         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
4114         Change type.
4115         (get_catch_syscall_inferior_data): Update.
4116         (catch_syscall_inferior_data_cleanup): Remove.
4117         (_initialize_break_catch_syscall): Update.
4118
4119 2019-05-08  Tom Tromey  <tom@tromey.com>
4120
4121         * inflow.c (struct terminal_info): Add destructor and
4122         initializers.
4123         (inflow_inferior_data): Change type.
4124         (~terminal_info): Rename from inflow_inferior_data_cleanup.
4125         (get_inflow_inferior_data, inflow_inferior_exit)
4126         (swap_terminal_info, _initialize_inflow): Update.
4127
4128 2019-05-08  Tom Tromey  <tom@tromey.com>
4129
4130         * target-dcache.c (target_dcache_cleanup): Remove.
4131         (target_dcache_aspace_key): Change type.
4132         (target_dcache_init_p, target_dcache_invalidate)
4133         (target_dcache_get, target_dcache_get_or_init)
4134         (_initialize_target_dcache): Update.
4135         * dcache.h (struct dcache_deleter): New.
4136
4137 2019-05-08  Tom Tromey  <tom@tromey.com>
4138
4139         * symtab.c (struct symbol_cache): Add destructor and
4140         initializers.
4141         (symbol_cache_key): Move.  Change type.
4142         (make_symbol_cache, free_symbol_cache): Remove.
4143         (get_symbol_cache): Update.
4144         (symbol_cache_cleanup): Remove.
4145         (ALL_PSPACES, symbol_cache_flush)
4146         (maintenance_print_symbol_cache)
4147         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
4148         Update.
4149
4150 2019-05-08  Tom Tromey  <tom@tromey.com>
4151
4152         * symtab.c (struct main_info): Add destructor and initializers.
4153         (main_progspace_key): Move.  Change type.
4154         (get_main_info): Update.
4155         (main_info_cleanup): Remove.
4156         (_initialize_symtab): Update.
4157
4158 2019-05-08  Tom Tromey  <tom@tromey.com>
4159
4160         * registry.h (DECLARE_REGISTRY): Define the _key class.
4161
4162 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
4163
4164         * NEWS: Merge two 'New commands' sections.
4165
4166 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
4167
4168         * ada-valprint.c (ada_val_print_gnat_array): Remove language
4169         parameter and use Ada language definition instead.
4170         (ada_val_print_ptr): Remove unused language parameter.
4171         (ada_val_print_num): Remove language parameter and use Ada language
4172         definition instead.
4173         (ada_val_print_enum, ada_val_print_flt): Remove unused language
4174         parameter.
4175         (ada_val_print_struct_union, ada_val_print_ref): Remove language
4176         parameter and use Ada language definition instead.
4177         (ada_val_print_1): Update all ada_val_print_xxx calls.
4178         Remove language parameter.
4179         (ada_val_print): Update ada_val_print_1 call.
4180
4181 2019-05-08  Tom Tromey  <tromey@adacore.com>
4182
4183         * remote.c (remote_hw_watchpoint_limit)
4184         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
4185         Now static.
4186
4187 2019-05-08  Tom Tromey  <tromey@adacore.com>
4188
4189         * maint.c (_initialize_maint_cmds): Move initialization code to
4190         remote.c.
4191         (watchdog, show_watchdog): Move to remote.c.
4192         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
4193         "watchdog" static.
4194         (_initialize_remote): Move initialization code from maint.c.
4195         * defs.h (watchdog): Don't declare.
4196
4197 2019-05-08  Tom Tromey  <tromey@adacore.com>
4198
4199         * tui/tui-interp.c: Include main.h.
4200         * interps.c: Include main.h.
4201         * main.h (interpreter_p): Declare.
4202         * defs.h (interpreter_p): Don't declare.
4203
4204 2019-05-08  Tom Tromey  <tromey@adacore.com>
4205
4206         * dwarf2loc.c: Include dwarf2read.h.
4207         * defs.h (read_unsigned_leb128): Don't declare.
4208         * dwarf2read.h (read_unsigned_leb128): Declare.
4209
4210 2019-05-08  Tom Tromey  <tromey@adacore.com>
4211
4212         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
4213         method.
4214
4215 2019-05-08  Tom Tromey  <tromey@adacore.com>
4216
4217         * utils.c (fputs_maybe_filtered): Reset style after paging, even
4218         when no wrap column is set.
4219
4220 2019-05-08  Tom Tromey  <tromey@adacore.com>
4221
4222         * c-lang.c (c_get_string): Handle non-C-style arrays.
4223
4224 2019-05-08  Tom Tromey  <tromey@adacore.com>
4225
4226         * typeprint.c (print_offset_data::update): Print the bit offset,
4227         not the number of bits remaining.
4228
4229 2019-05-08  Tom Tromey  <tromey@adacore.com>
4230
4231         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
4232         padding at end of comment.
4233
4234 2019-05-08  Tom Tromey  <tromey@adacore.com>
4235
4236         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
4237         Compare main types.
4238
4239 2019-05-06  Tom Tromey  <tom@tromey.com>
4240
4241         * common/scoped_mmap.c: Include common-defs.h.
4242         * common/scoped_mmap.h: Don't include config.h.
4243
4244 2019-05-04  Tom Tromey  <tom@tromey.com>
4245
4246         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
4247         (struct aarch64_call_info): Add initializers.
4248         <si>: Now a std::vector.
4249         (pass_on_stack, aarch64_push_dummy_call): Update.
4250
4251 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
4252             Tom Tromey  <tom@tromey.com>
4253
4254         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
4255         (ppc_threads): Now a std::vector.  Now static.
4256         (hwdebug_find_thread_points_by_tid)
4257         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
4258         Update.
4259
4260 2019-05-04  Tom Tromey  <tom@tromey.com>
4261
4262         * arc-tdep.c (arc_tdesc_init): Return bool.
4263
4264 2019-05-04  Tom Tromey  <tom@tromey.com>
4265
4266         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
4267         Use gdb_assert_not_reached.
4268
4269 2019-05-04  Tom Tromey  <tom@tromey.com>
4270
4271         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
4272         "false".
4273
4274 2019-05-04  Tom Tromey  <tom@tromey.com>
4275
4276         * arc-tdep.c (arc_tdesc_init): Use bool.
4277
4278 2019-05-04  Tom Tromey  <tom@tromey.com>
4279
4280         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
4281
4282 2019-05-04  Tom Tromey  <tom@tromey.com>
4283
4284         * cli/cli-cmds.c (valid_command_p): Return bool.
4285
4286 2019-05-04  Tom Tromey  <tom@tromey.com>
4287
4288         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
4289         * command.h (valid_user_defined_cmd_name_p): Channge return type.
4290
4291 2019-05-04  Raul Tambre  <raul@tambre.ee>
4292
4293         * python/lib/gdb/prompt.py (_ExtendedPrompt)
4294         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
4295         operator for comparison.
4296
4297 2019-05-04  Tom Tromey  <tom@tromey.com>
4298
4299         * psymtab.c (psymbol_name_matches, match_partial_symbol)
4300         (lookup_partial_symbol, print_partial_symbols)
4301         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
4302         (psymbol_compare): Update.
4303         (add_psymbol_to_bcache): Clear the entire psymbol.
4304         (maintenance_check_psymtabs): Update.
4305         * psympriv.h (struct partial_symbol): Don't derive from
4306         general_symbol_info.
4307         <obj_section, unrelocated_address, address,
4308         set_unrelocated_address>: Update.
4309         <ginfo>: New member.
4310         * dwarf-index-write.c (write_psymbols, debug_names::insert)
4311         (debug_names::write_psymbols): Update.
4312
4313 2019-05-04  Tom de Vries  <tdevries@suse.de>
4314
4315         * contrib/cc-with-tweaks.sh: Support -n arg.
4316
4317 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4318
4319         * corelow.c (core_target::detach): Ensure frame cache and
4320         register caches are cleared.
4321         inferior.c (exit_inferior_1): Likewise.
4322
4323 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
4324             Tom Tromey  <tom@tromey.com>
4325
4326         * dictionary.c (collate_pending_symbols_by_language): Remove
4327         "struct" from foreach.
4328         * symtab.c (lookup_global_symbol_from_objfile)
4329         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
4330         foreach.
4331         * ser-tcp.c (net_open): Remove "struct" from foreach.
4332         * objfiles.c (objfile_relocate, objfile_rebase)
4333         (objfile_has_symbols): Remove "struct" from foreach.
4334         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
4335         from foreach.
4336         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
4337         foreach.
4338         * darwin-nat.c (thread_info_from_private_thread_info): Remove
4339         "struct" from foreach.
4340         * ada-lang.c (create_excep_cond_exprs)
4341         (ada_exception_catchpoint_cond_string): Remove "struct" from
4342         foreach.
4343
4344 2019-05-03  Tom Tromey  <tromey@adacore.com>
4345
4346         * ada-exp.y (convert_char_literal): Check suffix of each
4347         enumerator.
4348
4349 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
4350
4351         PR ada/21406:
4352         * ada-exp.y (yywrap): Don't define.
4353         * ada-lex.l (%option): Add noyywrap
4354         (yywrap): Remove.
4355
4356 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
4357
4358         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
4359         _WIN32_WINNT to the XP level, unless already defined to a higher
4360         level.
4361
4362         * unittests/parse-connection-spec-selftests.c:
4363         * ser-tcp.c:
4364         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
4365         override.
4366
4367         * symfile.c (find_separate_debug_file): Remove colon from the
4368         drive spec of DOS/Windows file names of the target, so that the
4369         file name produced from DEBUGDIR and the target's directory will
4370         be valid on DOS/Windows systems.
4371
4372 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
4373
4374         * rust-lang.c (val_print_struct): Handle printing structures
4375         containing strings.
4376
4377 2019-05-02  Tom Tromey  <tromey@adacore.com>
4378
4379         * valarith.c (_initialize_valarith): Remove.
4380
4381 2019-05-01  Tom Tromey  <tromey@adacore.com>
4382
4383         * ada-lang.c (ada_value_primitive_field): Treat more fields as
4384         bitfields.
4385
4386 2019-05-01  Tom Tromey  <tromey@adacore.com>
4387
4388         * ada-lang.c (ada_value_assign): Correctly compute starting offset
4389         for big-endian copies.
4390
4391 2019-04-30  Ali Tamur  <tamur@google.com>
4392         * gdb/dwarf2read.c (read_3_bytes): New declaration.
4393         (read_attribute_value): Added DW_FORM_strx1-4 cases.
4394         (read_3_bytes): New function.
4395
4396 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
4397
4398         * windows-nat.c (main_thread_id): Delete.
4399         (handle_output_debug_string): Replace main_thread_id by
4400         current_event.dwThreadId.
4401         (fake_create_process): Likewise.
4402         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
4403         Do not set main_thread_id.
4404         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
4405         current_event.dwThreadId.
4406         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
4407
4408 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
4409
4410         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
4411         Use current_event.dwThreadId instead of main_thread_id.
4412
4413 2019-04-30  Tom Tromey  <tromey@adacore.com>
4414
4415         * ada-lang.c (ada_lookup_simple_minsyms): New function.
4416         (create_excep_cond_exprs): Iterate over program spaces.
4417         (ada_exception_catchpoint_cond_string): Examine all minimal
4418         symbols for exception types.
4419
4420 2019-04-30  Tom Tromey  <tromey@adacore.com>
4421
4422         PR c++/24470:
4423         * dwarf2read.c (process_structure_scope): Handle case where type
4424         has template parameters but no symbol was created.
4425
4426 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4427             Chris January  <chris.january@arm.com>
4428
4429         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
4430         qualifier.
4431         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
4432
4433 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4434
4435         * f-typeprint.c (f_print_type): Update rules for printing
4436         whitespace.
4437         (f_type_print_varspec_suffix): Likewise.
4438
4439 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4440             Chris January  <chris.january@arm.com>
4441
4442         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
4443         function arguments.
4444
4445 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4446
4447         * f-lang.c (build_fortran_types): Change name of void type to
4448         lower case.
4449         * f-typeprint.c (f_type_print_base): Print the name of the void
4450         type, rather than a fixed string.
4451         * f-valprint.c (f_decorations): Use lower case void string.
4452
4453 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4454             Chris January  <chris.january@arm.com>
4455
4456         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
4457         types for Fortran.
4458
4459 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4460             Chris January  <chris.january@arm.com>
4461             David Lecomber  <david.lecomber@arm.com>
4462
4463         * f-exp.y (BINOP_INTRINSIC): New token.
4464         (exp): New parser rule handling BINOP_INTRINSIC.
4465         (f77_keywords): Add new builtin procedures.
4466         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
4467         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4468         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
4469         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4470         (print_unop_subexp_f): New function.
4471         (print_binop_subexp_f): New function.
4472         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
4473         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4474         (dump_subexp_body_f): Likewise.
4475         (operator_check_f): Likewise.
4476         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
4477         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
4478
4479 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4480
4481         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
4482         UNOP_KIND.
4483         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
4484         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
4485         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
4486         (operator_length_f): New fuction.
4487         (print_subexp_f): New function.
4488         (op_name_f): New function.
4489         (dump_subexp_body_f): New function.
4490         (operator_check_f): New function.
4491         (exp_descriptor_f): Replace standard expression handling functions
4492         with new functions.
4493         * gdb/fortran-operator.def: New file.
4494         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
4495         * gdb/std-operator.def: Remove UNOP_KIND.
4496
4497 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4498
4499         * std-operator.def: Remove unbalanced, stray double quote
4500         character.
4501
4502 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4503             Chris January  <chris.january@arm.com>
4504             Daniel Everett  <daniel.everett@arm.com>
4505             Nick Forrington  <nick.forrington@arm.com>
4506             Richard Bunt  <richard.bunt@arm.com>
4507
4508         * cp-valprint.c (cp_print_value_fields): Allow an additional level
4509         of depth when printing anonymous structs or unions.
4510         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
4511         Don't print either the top-level value, or the children if the
4512         max-depth is exceeded.
4513         (ppscm_print_children): When printing the key of a map, allow one
4514         extra level of depth.
4515         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
4516         print either the top-level value, or the children if the max-depth
4517         is exceeded.
4518         (print_children): When printing the key of a map, allow one extra
4519         level of depth.
4520         * python/py-value.c (valpy_format_string): Add max_depth keyword.
4521         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
4522         (user_print_options): Initialise max_depth field.
4523         (val_print_scalar_or_string_type_p): New function.
4524         (val_print): Check to see if the max depth has been reached.
4525         (val_print_check_max_depth): Define new function.
4526         (show_print_max_depth): New function.
4527         (_initialize_valprint): Add 'print max-depth' option.
4528         * valprint.h (struct value_print_options) <max_depth>: New field.
4529         (val_print_check_max_depth): Declare new function.
4530         * NEWS: Document new feature.
4531
4532 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4533
4534         * ada-lang.c (ada_language_defn): Initialise new field.
4535         * c-lang.c (c_is_string_type_p): New function.
4536         (c_language_defn): Initialise new field.
4537         (cplus_language_defn): Initialise new field.
4538         (asm_language_defn): Initialise new field.
4539         (minimal_language_defn): Initialise new field.
4540         * c-lang.h (c_is_string_type_p): Declare new function.
4541         * d-lang.c (d_language_defn): Initialise new field.
4542         * f-lang.c (f_is_string_type_p): New function.
4543         (f_language_defn): Initialise new field.
4544         * go-lang.c (go_is_string_type_p): New function.
4545         (go_language_defn): Initialise new field.
4546         * language.c (default_is_string_type_p): New function.
4547         (unknown_language_defn): Initialise new field.
4548         (auto_language_defn): Initialise new field.
4549         * language.h (struct language_defn) <la_is_string_type_p>: New
4550         member variable.
4551         (default_is_string_type_p): Declare new function.
4552         * m2-lang.c (m2_language_defn): Initialise new field.
4553         * objc-lang.c (objc_language_defn): Initialise new field.
4554         * opencl-lang.c (opencl_language_defn): Initialise new field.
4555         * p-lang.c (pascal_is_string_type_p): New function.
4556         (pascal_language_defn): Initialise new field.
4557         * rust-lang.c (rust_is_string_type_p): New function.
4558         (rust_language_defn): Initialise new field.
4559
4560 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4561
4562         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
4563         New field.
4564         * ada-lang.c (ada_language_defn): Initialise new field.
4565         * c-lang.c (c_language_defn): Likewise.
4566         (cplus_language_defn): Likewise.
4567         (asm_language_defn): Likewise.
4568         (minimal_language_defn): Likewise.
4569         * d-lang.c (d_language_defn): Likewise.
4570         * f-lang.c (f_language_defn): Likewise.
4571         * go-lang.c (go_language_defn): Likewise.
4572         * language.c (unknown_language_defn): Likewise.
4573         (auto_language_defn): Likewise.
4574         * m2-lang.c (m2_language_defn): Likewise.
4575         * objc-lang.c (objc_language_defn): Likewise.
4576         * opencl-lang.c (opencl_language_defn): Likewise.
4577         * p-lang.c (pascal_language_defn): Likewise.
4578         * rust-lang.c (rust_language_defn): Likewise.
4579
4580 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4581
4582         * ada-lang.c (ada_is_character_type): Change return type to bool.
4583         (ada_is_string_type): Likewise.
4584         * ada-lang.h (ada_is_character_type): Update declaration
4585         (ada_is_string_type): Likewise.
4586
4587 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4588
4589         Support style in 'frame|thread apply'
4590
4591         * gdbcmd.h (execute_command_to_string): New term_out parameter.
4592         * record.c (record_start, record_stop): Update callers of
4593         execute_command_to_string with false.
4594         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
4595         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
4596         methods.
4597         (class string_file): New constructor with term_out parameter.
4598         Override methods term_out and can_emit_style_escape.  New member
4599         term_out.
4600         (class stdio_file): Override can_emit_style_escape.
4601         (class tee_file): Override term_out and can_emit_style_escape.
4602         * utils.h (can_emit_style_escape): Remove.
4603         * utils.c (can_emit_style_escape): Likewise.
4604         Update all callers of can_emit_style_escape (SOMESTREAM) to
4605         SOMESTREAM->can_emit_style_escape.
4606         * source-cache.c (source_cache::get_source_lines): Likewise.
4607         * stack.c (frame_apply_command_count): Call execute_command_to_string
4608         passing the term_out characteristic of the current gdb_stdout.
4609         * thread.c (thr_try_catch_cmd): Likewise.
4610         * top.c (execute_command_to_string): pass term_out parameter
4611         to construct the string_file for the command output.
4612         * ui-file.c (term_cli_styling): New function (most code moved
4613         from utils.c can_emit_style_escape).
4614         (string_file::string_file, string_file::can_emit_style_escape,
4615         stdio_file::can_emit_style_escape, tee_file::term_out,
4616         tee_file::can_emit_style_escape): New functions.
4617
4618 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4619
4620         * NEWS: Mention the new set|show may-call-functions.
4621         * infcall.c (may_call_functions_p): New variable.
4622         (show_may_call_functions_p): New function.
4623         (call_function_by_hand_dummy): Throws an error if not
4624         may-call-functions.
4625         (_initialize_infcall): Call add_setshow_boolean_cmd for
4626         may-call-functions.
4627
4628 2019-04-25  Keith Seitz  <keiths@redhat.com>
4629
4630         PR c++/24367
4631         * cp-support.c (inspect_type): Don't attempt substitutions
4632         of symbol with the same name.
4633
4634 2019-04-25  Tom Tromey  <tromey@adacore.com>
4635
4636         PR gdb/24475:
4637         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
4638         static.
4639
4640 2019-04-25  Tom Tromey  <tromey@adacore.com>
4641
4642         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
4643         rvalue reference.
4644         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
4645         (gdb_xml_parser::parse): Use std::move.
4646         * python/python-internal.h (gdbpy_convert_exception): Take a const
4647         reference.
4648         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
4649         std::move.
4650         * python/py-utils.c (gdbpy_convert_exception): Take a const
4651         reference.
4652         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
4653         Use std::move.
4654         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
4655         Use std::move.
4656         * mi/mi-main.c (mi_print_exception): Take a const reference.
4657         * main.c (handle_command_errors): Take a const reference.
4658         * linespec.c (parse_linespec): Use std::move.
4659         * infcall.c (run_inferior_call): Use std::move.
4660         (call_function_by_hand_dummy): Use std::move.
4661         * exec.c (try_open_exec_file): Use std::move.
4662         * exceptions.h (exception_print, exception_fprintf)
4663         (exception_print_same): Update.
4664         * exceptions.c (print_exception, exception_print)
4665         (exception_fprintf, exception_print_same): Change parameters to
4666         const reference.
4667         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
4668         * common/new-op.c: Use std::move.
4669         * common/common-exceptions.h (struct gdb_exception): Add move
4670         constructor.
4671         (struct gdb_exception_error, struct gdb_exception_quit, struct
4672         gdb_quit_bad_alloc): Change constructor to move constructor.
4673         (throw_exception): Change parameter to rvalue reference.
4674         * common/common-exceptions.c (throw_exception): Take rvalue
4675         reference.
4676         * cli/cli-interp.c (safe_execute_command): Use std::move.
4677         * breakpoint.c (insert_bp_location, location_to_sals): Use
4678         std::move.
4679
4680 2019-04-25  Tom Tromey  <tromey@adacore.com>
4681
4682         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
4683         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
4684         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
4685         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
4686         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
4687         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
4688         guile/scm-value.c: Use unpack.
4689         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
4690         gdbscm_gdb_exception.
4691         (gdbscm_throw_gdb_exception): Likewise.
4692         (struct gdbscm_gdb_exception): New.
4693         (unpack): New function.
4694         (gdbscm_wrap): Use unpack.
4695
4696 2019-04-25  Tom Tromey  <tromey@adacore.com>
4697
4698         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
4699         (gdb_rl_callback_handler): Use std::move.
4700         * common/common-exceptions.h (struct gdb_exception): Add move
4701         assignment operator.
4702         (throw_exception_sjlj): Change "exception" to const reference.
4703         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
4704         (throw_exception_sjlj): Change "exception" to const reference.
4705
4706 2019-04-25  Tom Tromey  <tromey@adacore.com>
4707
4708         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
4709         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
4710         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
4711         Update.
4712         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
4713         Update.
4714         * mi/mi-interp.c (mi_interp::exec): Update.
4715         * linespec.c (parse_linespec): Update.
4716         * infcall.c (run_inferior_call): Update.
4717         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
4718         * guile/scm-symbol.c (gdbscm_lookup_symbol)
4719         (gdbscm_lookup_global_symbol): Update.
4720         * guile/scm-param.c (gdbscm_parameter_value): Update.
4721         * guile/scm-frame.c (gdbscm_frame_read_register)
4722         (gdbscm_frame_read_var): Update.
4723         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
4724         * exec.c (try_open_exec_file): Update.
4725         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
4726         (gdb_rl_callback_handler): Update.
4727         * common/common-exceptions.h (exception_none): Don't declare.
4728         * common/common-exceptions.c (exception_none): Don't define.
4729         (struct catcher) <exception>: Update.
4730         * cli/cli-interp.c (safe_execute_command): Update.
4731         * breakpoint.c (insert_bp_location, location_to_sals): Update.
4732
4733 2019-04-25  Ali Tamur  <tamur@google.com>
4734
4735         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
4736         (read_attribute_value): Likewise.
4737         (dwarf2_read_addr_index): Update comment.
4738         (read_str_index): Add DW_FORM_strx.
4739         (dwarf2_string_attr): Likewise.
4740         (dwarf2_const_value_attr): Likewise.
4741         (dump_die_shallow): Likewise.
4742         (dwarf2_fetch_constant_bytes): Likewise.
4743         (skip_form_bytes): Likewise.
4744         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
4745
4746 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
4747
4748         PR corefiles/11608
4749         PR corefiles/18187
4750         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
4751         OFFSET.  Verify if current mapping contains an ELF header.
4752         (linux_find_memory_regions_full): Adjust call to
4753         dump_mapping_p.
4754
4755 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
4756             Kang Li <kanglictf@gmail.com>
4757
4758         PR gdb/21600
4759
4760         * dwarf2-frame.c (read_initial_length): Be consistent about using
4761         unsigned representation of length.
4762         (decode_frame_entry_1): Likewise.  Check for wraparound of
4763         end pointer as well as buffer overflow.
4764
4765 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
4766
4767         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
4768         "vq".
4769
4770 2019-04-24  Tom Tromey  <tromey@adacore.com>
4771
4772         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
4773
4774 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4775
4776         * s12z-tdep.c (s12z_unwind_pc): Delete.
4777         (s12z_unwind_sp): Delete.
4778         (s12z_gdbarch_init): Don't register deleted functions with
4779         gdbarch.
4780
4781 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4782
4783         * rl78-tdep.c (rl78_unwind_sp): Delete.
4784         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
4785
4786 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4787
4788         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
4789         (xstormy16_unwind_pc): Delete.
4790         (xstormy16_dummy_id): Delete.
4791         (xstormy16_gdbarch_init): Don't register deleted functions with
4792         gdbarch.
4793
4794 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4795
4796         * vax-tdep.c (vax_unwind_pc): Delete.
4797         (vax_gdbarch_init): Don't register deleted function with gdbarch.
4798
4799 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4800
4801         * v850-tdep.c (v850_unwind_sp): Delete.
4802         (v850_unwind_pc): Delete.
4803         (v850_dummy_id): Delete.
4804         (v850_gdbarch_init): Don't register deleted functions with
4805         gdbarch.
4806
4807 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4808
4809         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
4810         (tilegx_unwind_pc): Delete.
4811         (tilegx_unwind_dummy_id): Delete.
4812         (tilegx_gdbarch_init): Don't register deleted functions with
4813         gdbarch.
4814
4815 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4816
4817         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
4818         (tic6x_dummy_id): Delete.
4819         (tic6x_gdbarch_init): Don't register deleted functions with
4820         gdbarch.
4821
4822 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4823
4824         * sparc-tdep.c (sparc_unwind_pc): Delete.
4825         (sparc32_gdbarch_init): Don't register deleted function with
4826         gdbarch.
4827
4828 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4829
4830         * sh-tdep.c (sh_unwind_sp): Delete.
4831         (sh_unwind_pc): Delete.
4832         (sh_dummy_id): Delete.
4833         (sh_gdbarch_init): Don't register deleted functions with
4834         gdbarch.
4835
4836 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4837
4838         * score-tdep.c (score_unwind_sp): Delete.
4839         (score_unwind_pc): Delete.
4840         (score_dummy_id): Delete.
4841         (score_gdbarch_init): Don't register deleted functions with
4842         gdbarch.
4843
4844 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4845
4846         * rx-tdep.c (rx_unwind_pc): Delete.
4847         (rx_unwind_sp): Delete.
4848         (rx_dummy_id): Delete.
4849         (rx_gdbarch_init): Don't register deleted functions with
4850         gdbarch.  Update comment.
4851
4852 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4853
4854         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
4855         (rs6000_dummy_id): Delete.
4856         (rs6000_gdbarch_init): Don't register deleted functions with
4857         gdbarch.
4858
4859 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4860
4861         * or1k-tdep.c (or1k_dummy_id): Delete.
4862         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
4863
4864 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4865
4866         * nios2-tdep.c (nios2_dummy_id): Delete.
4867         (nios2_unwind_sp): Delete.
4868         (nios2_gdbarch_init): Don't register deleted functions with
4869         gdbarch.
4870
4871 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4872
4873         * nds32-tdep.c (nds32_dummy_id): Delete.
4874         (nds32_unwind_pc): Delete.
4875         (nds32_unwind_sp): Delete.
4876         (nds32_gdbarch_init): Don't register deleted functions with
4877         gdbarch.
4878
4879 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4880
4881         * msp430-tdep.c (msp430_unwind_pc): Delete.
4882         (msp430_unwind_sp): Delete.
4883         (msp430_dummy_id): Delete.
4884         (msp430_gdbarch_init): Don't register deleted functions with
4885         gdbarch.
4886
4887 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4888
4889         * moxie-tdep.c (moxie_unwind_sp): Delete.
4890         (moxie_unwind_pc): Delete.
4891         (moxie_dummy_id): Delete.
4892         (moxie_gdbarch_init): Don't register deleted functions with
4893         gdbarch.
4894
4895 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4896
4897         * mn10300-tdep.c (mn10300_dummy_id): Delete.
4898         (mn10300_unwind_pc): Delete.
4899         (mn10300_unwind_sp): Delete.
4900         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
4901         mn10300_unwind_sp.
4902         (mn10300_frame_unwind_init): Don't register deleted functions with
4903         gdbarch.
4904
4905 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4906
4907         * mep-tdep.c (mep_unwind_pc): Delete.
4908         (mep_unwind_sp): Delete.
4909         (mep_dummy_id): Delete.
4910         (mep_gdbarch_init): Don't register deleted functions with
4911         gdbarch.
4912
4913 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4914
4915         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
4916         (m68hc11_unwind_sp): Delete.
4917         (m68hc11_gdbarch_init): Don't register deleted functions with
4918         gdbarch.
4919
4920 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4921
4922         * m32r-tdep.c (m32r_unwind_sp): Delete.
4923         (m32r_unwind_pc): Delete.
4924         (m32r_dummy_id): Delete.
4925         (m32r_gdbarch_init): Don't register deleted functions with
4926         gdbarch.
4927
4928 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4929
4930         * m32c-tdep.c (m32c_unwind_pc): Delete.
4931         (m32c_unwind_sp): Delete.
4932         (m32c_dummy_id): Delete.
4933         (m32c_gdbarch_init): Don't register deleted functions with
4934         gdbarch.
4935
4936 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4937
4938         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
4939         (lm32_unwind_pc): Delete.
4940         (lm32_dummy_id): Delete.
4941         (lm32_gdbarch_init): Don't register deleted functions with
4942         gdbarch.
4943
4944 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4945
4946         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
4947         (iq2000_unwind_pc): Delete.
4948         (iq2000_dummy_id): Delete.
4949         (iq2000_gdbarch_init): Don't register deleted functions with
4950         gdbarch.
4951
4952 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4953
4954         * nds32-tdep.c (nds32_type_align): Delete.
4955         (nds32_push_dummy_call): Use type_align instead.
4956
4957 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4958
4959         * arm-tdep.c (arm_type_align): Only handle vector override case.
4960         (arm_push_dummy_call): Use type_align.
4961         (arm_gdbarch_init): Register arm_type_align gdbarch function.
4962
4963 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4964
4965         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
4966         case.
4967         (pass_on_stack): Use type_align.
4968         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
4969         function.
4970
4971 2019-04-23  Tom Tromey  <tromey@adacore.com>
4972
4973         * dwarf2read.c (line_header::file_name_at): Remove unused
4974         overload.
4975
4976 2019-04-23  Tom de Vries  <tdevries@suse.de>
4977
4978         PR gdb/24438
4979         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
4980         invocation.
4981
4982
4983 2019-03-27  Ali Tamur  <tamur@google.com>
4984
4985         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
4986         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
4987         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
4988         (dwarf_expr_context::get_addr_index): Likewise
4989         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
4990         (symbol_needs_eval_context::get_addr_index): Likewise
4991         (disassemble_dwarf_expression): Add DW_OP_addrx
4992         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
4993         (read_cutu_die_from_dwo): Update comment
4994         (skip_one_die): Add DW_FORM_addrx
4995         (read_attribute_value): Likewise
4996         (var_decode_location): Add DW_OP_addrx
4997         (dwarf2_const_value_attr): Add DW_FORM_addrx
4998         (dump_die_shallow): Likewise
4999         (dwarf2_fetch_constant_bytes): Likewise
5000         (decode_locdesc): Add DW_OP_addrx
5001         (skip_form_bytes): Add DW_FORM_addrx
5002
5003 2019-04-22  Ali Tamur  <tamur@google.com>
5004
5005         * MAINTAINERS (Write After Approval): Add self.
5006
5007 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
5008
5009         * solib-svr4.c (get_svr4_info): Add pspace parameter.
5010         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
5011         (open_symbol_file_object): Likewise.
5012         (svr4_default_sos): Add info parameter.
5013         (svr4_read_so_list): Likewise.
5014         (svr4_current_sos_direct): Adjust functions calls to pass down
5015         info.
5016         (svr4_current_sos_1): Add info parameter.
5017         (svr4_current_sos): Call get_svr4_info, pass info down to
5018         svr4_current_sos_1.
5019         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
5020         get_svr4_info.
5021         (svr4_in_dynsym_resolve_code): Pass current_program_space to
5022         get_svr4_info.
5023         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
5024         to get_svr4_info.
5025         (probes_table_remove_objfile_probes): Likewise.
5026         (register_solib_event_probe): Add info parameter.
5027         (solist_update_incremental): Pass info parameter down to
5028         svr4_read_so_list.
5029         (disable_probes_interface): Add info parameter.
5030         (svr4_handle_solib_event): Pass current_program_space to
5031         get_svr4_info.  Adjust disable_probes_interface cleanup.
5032         (svr4_create_probe_breakpoints): Add info parameter, pass it
5033         down to register_solib_event_probe.
5034         (svr4_create_solib_event_breakpoints): Add info parameter,
5035         pass it down to svr4_create_probe_breakpoints.
5036         (enable_break): Pass info down to
5037         svr4_create_solib_event_breakpoints.
5038         (svr4_solib_create_inferior_hook): Pass current_program_space to
5039         get_svr4_info.
5040         (svr4_clear_solib): Likewise.
5041
5042 2019-04-22  Pedro Alves  <palves@redhat.com>
5043
5044         * solib-svr4.c (svr4_free_objfile_observer): New.
5045         (probe_and_action::objfile): New field.
5046         (probes_table_htab_remove_objfile_probes)
5047         (probes_table_remove_objfile_probes): New functions.
5048         (register_solib_event_probe): Add 'objfile' parameter.  Store it
5049         in the new probe_and_action.  Don't store the probe in 'lookup'.
5050         (svr4_create_probe_breakpoints): Pass objfile to
5051         register_solib_event_probe.
5052         (_initialize_svr4_solib): Register a free_objfile observer.
5053
5054 2019-04-19  Tom Tromey  <tom@tromey.com>
5055
5056         * common/queue.h: Remove.
5057
5058 2019-04-19  Tom Tromey  <tom@tromey.com>
5059
5060         * event-loop.c: Don't include "common/queue.h".
5061
5062 2019-04-19  Tom Tromey  <tom@tromey.com>
5063
5064         * remote.c (remote_target): Use delete.
5065         * remote-notif.h: Include <list>, not "common/queue.h".
5066         (notif_client_p): Remove typedef.
5067         (remote_notif_state): Add constructor, destructor, initializer.
5068         <notif_queue>: Now a std::list.
5069         (remote_notif_state_xfree): Don't declare.
5070         * remote-notif.c (remote_notif_process, handle_notification)
5071         (remote_notif_state_allocate): Update.
5072         (~remote_notif_state): Rename from remote_notif_state_xfree.
5073
5074 2019-04-19  Tom Tromey  <tom@tromey.com>
5075
5076         * symfile.c (reread_symbols): Update.
5077         * objfiles.c (objfile_register_static_link)
5078         (objfile_lookup_static_link): Update
5079         (~objfile) Don't delete static_links.
5080         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
5081
5082 2019-04-19  Tom Tromey  <tom@tromey.com>
5083
5084         * type-stack.h (struct type_stack) <insert>: Constify string.
5085         * type-stack.c (type_stack::insert): Constify string.
5086         * gdbtypes.h (lookup_template_type): Update.
5087         (address_space_name_to_int): Update.
5088         * gdbtypes.c (address_space_name_to_int): Make space_identifier
5089         const.
5090         (lookup_template_type): Make name const.
5091         * c-exp.y: Update rules.
5092         (lex_one_token, classify_name, classify_inner_name)
5093         (c_print_token): Update.
5094         * p-exp.y: Update rules.
5095         (yylex): Update.
5096         * f-exp.y: Update rules.
5097         (yylex): Update.
5098         * d-exp.y: Update rules.
5099         (lex_one_token, classify_name, classify_inner_name): Update.
5100         * parse.c (write_dollar_variable, copy_name): Return std::string.
5101         * parser-defs.h (copy_name): Change return type.
5102         * m2-exp.y: Update rules.
5103         (yylex): Update.
5104         * go-exp.y (lex_one_token): Update.
5105         Update rules.
5106         (classify_unsafe_function, classify_packaged_name)
5107         (classify_name, yylex): Update.
5108
5109 2019-04-19  Sergei Trofimovich <siarheit@google.com>
5110
5111         * configure.ac: add --enable-source-highlight switch.
5112         * configure: Regenerate.
5113         * top.c (print_gdb_version): plumb --enable-source-highlight
5114         status to "show configuration".
5115
5116 2019-04-19  Tom Tromey  <tromey@adacore.com>
5117
5118         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
5119         Check ADA_TYPE_P.
5120         (empty_record, ada_template_to_fixed_record_type_1)
5121         (template_to_static_fixed_type)
5122         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
5123         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
5124         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
5125         macros.
5126
5127 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
5128
5129         PR symtab/24423:
5130         * source.c (print_source_lines_base): Advance "iter" when a
5131         control character is seen.
5132
5133 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5134
5135         * inferior.h (struct infcall_suspend_state_deleter):
5136         Catch exception in destructor to avoid crash.
5137
5138 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5139
5140         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
5141         close to the add_com "shell".
5142
5143 2019-04-18  Tom Tromey  <tromey@adacore.com>
5144
5145         * process-stratum-target.h (class process_stratum_target)
5146         <stratum>: Add "final".
5147
5148 2019-04-17  Tom Tromey  <tromey@adacore.com>
5149
5150         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
5151         against nullptr before use.
5152
5153 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
5154
5155         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
5156
5157 2019-04-17  Jim Wilson  <jimw@sifive.com>
5158             Andrew Burgess  <andrew.burgess@embecosm.com>
5159
5160         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
5161         code read might fail, assume 4-byte breakpoint in that case.
5162
5163 2019-04-15  Leszek Swirski  <leszeks@google.com>
5164
5165         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
5166         rather than a hand-rolled POD check when checking for forced MEMORY
5167         classification.
5168
5169 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
5170
5171         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
5172         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
5173         function.
5174         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
5175         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
5176         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
5177         declaration.
5178
5179 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
5180
5181         * aarch64-linux-nat.c
5182         (aarch64_linux_nat_target::thread_architecture): Add override.
5183         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
5184         each VQ.
5185
5186 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
5187
5188         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
5189
5190 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
5191
5192         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
5193         target types of size 96-bits, add some additional comments, and
5194         check that the builtin type we found was the correct size.
5195
5196 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
5197
5198         * utils.c (prompt_for_continue): Don't restore the styling at the
5199         end, as applied_style has the wrong value.  This fixes styling in
5200         long lists of file names that are interrupted by the "Continue?"
5201         prompt.
5202
5203 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
5204
5205         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
5206         * c-lang.c (c_language_defn): Likewise.
5207         (cplus_language_defn): Likewise.
5208         (asm_language_defn): Likewise.
5209         (minimal_language_defn): Likewise.
5210         * d-lang.c (d_language_defn): Likewise.
5211         * f-lang.c (f_language_defn): Likewise.
5212         * go-lang.c (go_language_defn): Likewise.
5213         * language.c (unknown_language_defn): Likewise.
5214         (auto_language_defn): Likewise.
5215         * language.h (struct language_defn): Remove la_magic field.
5216         (LANG_MAGIC): Delete.
5217         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
5218         * objc-lang.c (objc_language_defn): Likewise.
5219         * opencl-lang.c (opencl_language_defn): Likewise.
5220         * p-lang.c (pascal_language_defn): Likewise.
5221         * rust-lang.c (rust_language_defn): Likewise.
5222
5223 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5224
5225         * riscv-tdep.c (riscv_type_align): New function.
5226         (riscv_type_alignment): Delete.
5227         (riscv_arg_location): Use 'type_align'.
5228         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
5229
5230 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5231
5232         * gdbtypes.c (type_align): A struct with no non-static fields also
5233         has alignment of 1.
5234
5235 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5236
5237         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
5238         component to 0.
5239         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
5240         member.
5241         (riscv_struct_info::analyse): New implementation using new
5242         analyse_inner member function.
5243         (riscv_struct_info::field_offset): New member function.
5244         (riscv_struct_info::m_offsets): New member variable.
5245         (riscv_struct_info::analyse_inner): New private member function,
5246         takes the old implementation of riscv_struct_info::analyse but
5247         extended to track field offsets.
5248         (riscv_call_arg_struct): Update the struct folding special cases
5249         to handle cases where empty C++ structs, which are non-zero
5250         length, are found.
5251         (riscv_arg_location): Initialise the length of each location, a
5252         non-zero length now indicates the location is in use.
5253         (riscv_push_dummy_call): Allow for the first location having a
5254         non-zero offset when setting up arguments.
5255         (riscv_return_value): Likewise, but for return values.
5256
5257 2019-04-11  Tom Tromey  <tromey@adacore.com>
5258
5259         * utils.c (internal_vproblem): Make "msg" const.
5260
5261 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
5262
5263         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
5264         * trad-frame.c (trad_frame_reset_saved_regs): New function.
5265         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
5266         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
5267
5268 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
5269
5270         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
5271         function.
5272         (fill_gregset): Call amd64_linux_collect_native_gregset instead
5273         of amd64_collect_native_gregset.
5274         (amd64_linux_nat_target::store_registers): Likewise.
5275
5276 2019-04-10  Tom Tromey  <tom@tromey.com>
5277
5278         * symtab.c (lookup_global_symbol_from_objfile)
5279         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
5280         * objfiles.h (class separate_debug_iterator): New.
5281         (class separate_debug_range): New.
5282         (struct objfile) <separate_debug_objfiles>: New method.
5283         (objfile_separate_debug_iterate): Don't declare.
5284         * objfiles.c (separate_debug_iterator::operator++): Rename from
5285         objfile_separate_debug_iterate.
5286         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
5287         iterator.
5288         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
5289         iterator.
5290
5291 2019-04-10  Tom Tromey  <tom@tromey.com>
5292
5293         * symfile.c (reread_symbols): Remove old comment.
5294         * objfiles.c (free_all_objfiles): Fix a typo.
5295
5296 2019-04-10  Tom Tromey  <tom@tromey.com>
5297
5298         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
5299         * minsyms.c (lookup_minimal_symbol): Use foreach.
5300         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
5301         (lookup_minimal_symbol_solib_trampoline): Likewise.
5302         * symfile.c (reread_symbols): Use foreach.
5303
5304 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
5305             Tom Tromey  <tromey@adacore.com>
5306
5307         PR rust/24414:
5308         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
5309         (rust_lex_int_test): Change "value" to be LONGEST.
5310         (rust_lex_tests): Add test for long integer literal.
5311
5312 2019-04-09  Tom Tromey  <tromey@adacore.com>
5313
5314         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
5315         to bool.
5316         (extended_remote_target::attach): Update.
5317         (remote_target::remote_notice_new_inferior): Update.
5318         (remote_target::add_current_inferior_and_thread): Update.
5319         * inferior.c (exit_inferior_1): Use "false".
5320         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
5321
5322 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
5323
5324         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
5325         the "start" command.
5326
5327 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5328
5329         * python/py-inferior.c (infpy_thread_from_thread_handle):
5330         Adjust comments to reflect renaming of thread_from_thread_handle
5331         to thread_from_handle.  Adjust keywords.  Fix type error message.
5332         (inferior_object_methods): Add thread_from_handle.  Retain
5333         thread_from_thread_handle, but mark it as deprecated.
5334
5335 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5336
5337         * gdbthread.h (find_thread_by_handle): Revise declaration.
5338         * thread.c (find_thread_by_handle): Likewise.  Adjust
5339         implementation too.
5340         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
5341         support for buffer objects as handles.
5342
5343 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5344
5345         * python/py-infthread.c (thpy_thread_handle): New function.
5346         (thread_object_methods): Register thpy_thread_handle.
5347
5348 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5349
5350         * gdbthread.h (thread_to_thread_handle): Declare.
5351         * thread.c (gdbtypes.h): Include.
5352         (thread_to_thread_handle): New function.
5353
5354         * target.h (struct target_ops): Add thread_info_to_thread_handle.
5355         (target_thread_info_to_thread_handle): Declare.
5356         * target.c (target_thread_info_to_thread_handle): New function.
5357         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
5358         * target-delegates.c: Regenerate.
5359
5360         * linux-thread-db.c (class thread_db_target): Add method
5361         thread_info_to_thread_handle.
5362         (thread_db_target::thread_info_to_thread_handle): Define.
5363         * remote.c (class remote_target): Add new method
5364         thread_info_to_thread_handle.
5365         (remote_target::thread_info_to_thread_handle): Define.
5366
5367 2019-04-08  Pedro Alves  <palves@redhat.com>
5368
5369         * common/common-exceptions.c (throw_exception): Don't create
5370         named object to throw; throw directly.
5371         (throw_it): Likewise.  Don't initialize gdb_exception::message
5372         here, with new; pass FMT and AP to the ctor instead.
5373         * common/common-exceptions.h: Include <string>.
5374         (gdb_exception::gdb_exception(enum return_reason, enum errors,
5375         const char *, va_list)): New ctor.  Use std::make_shared.
5376         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
5377         errors)): Delete.
5378         (gdb_exception_error::gdb_exception_error(enum errors, const char
5379         *, va_list)): New.
5380         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
5381         Add assertion.
5382         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
5383         errors)): Delete.
5384         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
5385         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
5386         Add assertion.
5387
5388 2019-04-08  Tom Tromey  <tom@tromey.com>
5389
5390         * valops.c (value_rtti_indirect_type): Replace throw_exception
5391         with throw.
5392         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
5393         with throw.
5394         * thread.c (thr_try_catch_cmd): Replace throw_exception with
5395         throw.
5396         * target.c (target_translate_tls_address): Replace throw_exception
5397         with throw.
5398         * stack.c (frame_apply_command_count): Replace throw_exception
5399         with throw.
5400         * solib-spu.c (append_ocl_sos): Replace throw_exception with
5401         throw.
5402         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
5403         with throw.
5404         * rs6000-tdep.c (rs6000_frame_cache)
5405         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
5406         * remote.c: Replace throw_exception with throw.
5407         * record-full.c (record_full_message, record_full_wait_1)
5408         (record_full_restore): Replace throw_exception with throw.
5409         * record-btrace.c:
5410         (get_thread_current_frame_id, record_btrace_start_replaying)
5411         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
5412         (cmd_record_btrace_start): Replace throw_exception with throw.
5413         * parse.c (parse_exp_in_context_1): Replace throw_exception with
5414         throw.
5415         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
5416         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
5417         * linespec.c:
5418         (find_linespec_symbols): Replace throw_exception with throw.
5419         * infrun.c (displaced_step_prepare, resume): Replace
5420         throw_exception with throw.
5421         * infcmd.c (post_create_inferior): Replace throw_exception with
5422         throw.
5423         * inf-loop.c (inferior_event_handler): Replace throw_exception
5424         with throw.
5425         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
5426         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
5427         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
5428         (get_prev_frame_always, get_frame_pc_if_available)
5429         (get_frame_address_in_block_if_available, get_frame_language):
5430         Replace throw_exception with throw.
5431         * frame-unwind.c (frame_unwind_try_unwinder): Replace
5432         throw_exception with throw.
5433         * eval.c (fetch_subexp_value, evaluate_var_value)
5434         (evaluate_funcall, evaluate_subexp_standard): Replace
5435         throw_exception with throw.
5436         * dwarf2loc.c (call_site_find_chain)
5437         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
5438         Replace throw_exception with throw.
5439         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
5440         with throw.
5441         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
5442         throw.
5443         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
5444         * completer.c (complete_line_internal): Replace throw_exception
5445         with throw.
5446         * compile/compile-object-run.c (compile_object_run): Replace
5447         throw_exception with throw.
5448         * cli/cli-script.c (process_next_line): Replace throw_exception
5449         with throw.
5450         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
5451         (btrace_enable, btrace_maint_update_pt_packets): Replace
5452         throw_exception with throw.
5453         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
5454         throw_exception with throw.
5455         * break-catch-throw.c (re_set_exception_catchpoint): Replace
5456         throw_exception with throw.
5457         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
5458         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
5459         * aarch64-tdep.c (aarch64_make_prologue_cache)
5460         (aarch64_make_stub_cache): Replace throw_exception with throw.
5461
5462 2019-04-08  Tom Tromey  <tom@tromey.com>
5463
5464         * common/common-exceptions.c (throw_exception): Rename from
5465         throw_exception_cxx.  Remove old copy.  Make argument const.
5466         (throw_it): Create and throw exception objects directly.
5467         * common/common-exceptions.h (throw_exception): Make argument
5468         const.
5469         (struct gdb_exception_error): Add constructor.
5470         (struct gdb_exception_quit): Add constructor.
5471
5472 2019-04-08  Tom Tromey  <tom@tromey.com>
5473
5474         * common/common-exceptions.h (exception_rethrow): Don't declare.
5475         (TRY_SJLJ): Update comment.
5476         (TRY, CATCH, END_CATCH): Remove.
5477         * common/common-exceptions.c (exception_rethrow): Remove.
5478
5479 2019-04-08  Tom Tromey  <tom@tromey.com>
5480
5481         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
5482         Remove.
5483         (gdb_exception_error): Rename from
5484         gdb_exception_RETURN_MASK_ERROR.
5485         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
5486         (gdb_quit_bad_alloc): Update.
5487         * aarch64-tdep.c: Update.
5488         * ada-lang.c: Update.
5489         * ada-typeprint.c: Update.
5490         * ada-valprint.c: Update.
5491         * amd64-tdep.c: Update.
5492         * arch-utils.c: Update.
5493         * break-catch-throw.c: Update.
5494         * breakpoint.c: Update.
5495         * btrace.c: Update.
5496         * c-varobj.c: Update.
5497         * cli/cli-cmds.c: Update.
5498         * cli/cli-interp.c: Update.
5499         * cli/cli-script.c: Update.
5500         * common/common-exceptions.c: Update.
5501         * common/new-op.c: Update.
5502         * common/selftest.c: Update.
5503         * compile/compile-c-symbols.c: Update.
5504         * compile/compile-cplus-symbols.c: Update.
5505         * compile/compile-object-load.c: Update.
5506         * compile/compile-object-run.c: Update.
5507         * completer.c: Update.
5508         * corelow.c: Update.
5509         * cp-abi.c: Update.
5510         * cp-support.c: Update.
5511         * cp-valprint.c: Update.
5512         * darwin-nat.c: Update.
5513         * disasm-selftests.c: Update.
5514         * dtrace-probe.c: Update.
5515         * dwarf-index-cache.c: Update.
5516         * dwarf-index-write.c: Update.
5517         * dwarf2-frame-tailcall.c: Update.
5518         * dwarf2-frame.c: Update.
5519         * dwarf2loc.c: Update.
5520         * dwarf2read.c: Update.
5521         * eval.c: Update.
5522         * event-loop.c: Update.
5523         * event-top.c: Update.
5524         * exec.c: Update.
5525         * f-valprint.c: Update.
5526         * fbsd-tdep.c: Update.
5527         * frame-unwind.c: Update.
5528         * frame.c: Update.
5529         * gdbtypes.c: Update.
5530         * gnu-v3-abi.c: Update.
5531         * guile/guile-internal.h: Update.
5532         * guile/scm-block.c: Update.
5533         * guile/scm-breakpoint.c: Update.
5534         * guile/scm-cmd.c: Update.
5535         * guile/scm-disasm.c: Update.
5536         * guile/scm-frame.c: Update.
5537         * guile/scm-lazy-string.c: Update.
5538         * guile/scm-math.c: Update.
5539         * guile/scm-param.c: Update.
5540         * guile/scm-ports.c: Update.
5541         * guile/scm-pretty-print.c: Update.
5542         * guile/scm-symbol.c: Update.
5543         * guile/scm-symtab.c: Update.
5544         * guile/scm-type.c: Update.
5545         * guile/scm-value.c: Update.
5546         * i386-linux-tdep.c: Update.
5547         * i386-tdep.c: Update.
5548         * inf-loop.c: Update.
5549         * infcall.c: Update.
5550         * infcmd.c: Update.
5551         * infrun.c: Update.
5552         * jit.c: Update.
5553         * language.c: Update.
5554         * linespec.c: Update.
5555         * linux-fork.c: Update.
5556         * linux-nat.c: Update.
5557         * linux-tdep.c: Update.
5558         * linux-thread-db.c: Update.
5559         * main.c: Update.
5560         * mi/mi-cmd-break.c: Update.
5561         * mi/mi-cmd-stack.c: Update.
5562         * mi/mi-interp.c: Update.
5563         * mi/mi-main.c: Update.
5564         * objc-lang.c: Update.
5565         * p-valprint.c: Update.
5566         * parse.c: Update.
5567         * ppc-linux-tdep.c: Update.
5568         * printcmd.c: Update.
5569         * python/py-arch.c: Update.
5570         * python/py-breakpoint.c: Update.
5571         * python/py-cmd.c: Update.
5572         * python/py-finishbreakpoint.c: Update.
5573         * python/py-frame.c: Update.
5574         * python/py-framefilter.c: Update.
5575         * python/py-gdb-readline.c: Update.
5576         * python/py-inferior.c: Update.
5577         * python/py-infthread.c: Update.
5578         * python/py-lazy-string.c: Update.
5579         * python/py-linetable.c: Update.
5580         * python/py-objfile.c: Update.
5581         * python/py-param.c: Update.
5582         * python/py-prettyprint.c: Update.
5583         * python/py-progspace.c: Update.
5584         * python/py-record-btrace.c: Update.
5585         * python/py-record.c: Update.
5586         * python/py-symbol.c: Update.
5587         * python/py-type.c: Update.
5588         * python/py-unwind.c: Update.
5589         * python/py-utils.c: Update.
5590         * python/py-value.c: Update.
5591         * python/python.c: Update.
5592         * record-btrace.c: Update.
5593         * record-full.c: Update.
5594         * remote-fileio.c: Update.
5595         * remote.c: Update.
5596         * riscv-tdep.c: Update.
5597         * rs6000-aix-tdep.c: Update.
5598         * rs6000-tdep.c: Update.
5599         * rust-exp.y: Update.
5600         * rust-lang.c: Update.
5601         * s390-tdep.c: Update.
5602         * selftest-arch.c: Update.
5603         * solib-dsbt.c: Update.
5604         * solib-frv.c: Update.
5605         * solib-spu.c: Update.
5606         * solib-svr4.c: Update.
5607         * solib.c: Update.
5608         * sparc64-linux-tdep.c: Update.
5609         * stack.c: Update.
5610         * symfile-mem.c: Update.
5611         * symmisc.c: Update.
5612         * target.c: Update.
5613         * thread.c: Update.
5614         * top.c: Update.
5615         * tracefile-tfile.c: Update.
5616         * tui/tui.c: Update.
5617         * typeprint.c: Update.
5618         * unittests/cli-utils-selftests.c: Update.
5619         * unittests/parse-connection-spec-selftests.c: Update.
5620         * valops.c: Update.
5621         * valprint.c: Update.
5622         * value.c: Update.
5623         * varobj.c: Update.
5624         * windows-nat.c: Update.
5625         * x86-linux-nat.c: Update.
5626         * xml-support.c: Update.
5627
5628 2019-04-08  Tom Tromey  <tom@tromey.com>
5629
5630         * xml-support.c: Use C++ exception handling.
5631         * x86-linux-nat.c: Use C++ exception handling.
5632         * windows-nat.c: Use C++ exception handling.
5633         * varobj.c: Use C++ exception handling.
5634         * value.c: Use C++ exception handling.
5635         * valprint.c: Use C++ exception handling.
5636         * valops.c: Use C++ exception handling.
5637         * unittests/parse-connection-spec-selftests.c: Use C++ exception
5638         handling.
5639         * unittests/cli-utils-selftests.c: Use C++ exception handling.
5640         * typeprint.c: Use C++ exception handling.
5641         * tui/tui.c: Use C++ exception handling.
5642         * tracefile-tfile.c: Use C++ exception handling.
5643         * top.c: Use C++ exception handling.
5644         * thread.c: Use C++ exception handling.
5645         * target.c: Use C++ exception handling.
5646         * symmisc.c: Use C++ exception handling.
5647         * symfile-mem.c: Use C++ exception handling.
5648         * stack.c: Use C++ exception handling.
5649         * sparc64-linux-tdep.c: Use C++ exception handling.
5650         * solib.c: Use C++ exception handling.
5651         * solib-svr4.c: Use C++ exception handling.
5652         * solib-spu.c: Use C++ exception handling.
5653         * solib-frv.c: Use C++ exception handling.
5654         * solib-dsbt.c: Use C++ exception handling.
5655         * selftest-arch.c: Use C++ exception handling.
5656         * s390-tdep.c: Use C++ exception handling.
5657         * rust-lang.c: Use C++ exception handling.
5658         * rust-exp.y: Use C++ exception handling.
5659         * rs6000-tdep.c: Use C++ exception handling.
5660         * rs6000-aix-tdep.c: Use C++ exception handling.
5661         * riscv-tdep.c: Use C++ exception handling.
5662         * remote.c: Use C++ exception handling.
5663         * remote-fileio.c: Use C++ exception handling.
5664         * record-full.c: Use C++ exception handling.
5665         * record-btrace.c: Use C++ exception handling.
5666         * python/python.c: Use C++ exception handling.
5667         * python/py-value.c: Use C++ exception handling.
5668         * python/py-utils.c: Use C++ exception handling.
5669         * python/py-unwind.c: Use C++ exception handling.
5670         * python/py-type.c: Use C++ exception handling.
5671         * python/py-symbol.c: Use C++ exception handling.
5672         * python/py-record.c: Use C++ exception handling.
5673         * python/py-record-btrace.c: Use C++ exception handling.
5674         * python/py-progspace.c: Use C++ exception handling.
5675         * python/py-prettyprint.c: Use C++ exception handling.
5676         * python/py-param.c: Use C++ exception handling.
5677         * python/py-objfile.c: Use C++ exception handling.
5678         * python/py-linetable.c: Use C++ exception handling.
5679         * python/py-lazy-string.c: Use C++ exception handling.
5680         * python/py-infthread.c: Use C++ exception handling.
5681         * python/py-inferior.c: Use C++ exception handling.
5682         * python/py-gdb-readline.c: Use C++ exception handling.
5683         * python/py-framefilter.c: Use C++ exception handling.
5684         * python/py-frame.c: Use C++ exception handling.
5685         * python/py-finishbreakpoint.c: Use C++ exception handling.
5686         * python/py-cmd.c: Use C++ exception handling.
5687         * python/py-breakpoint.c: Use C++ exception handling.
5688         * python/py-arch.c: Use C++ exception handling.
5689         * printcmd.c: Use C++ exception handling.
5690         * ppc-linux-tdep.c: Use C++ exception handling.
5691         * parse.c: Use C++ exception handling.
5692         * p-valprint.c: Use C++ exception handling.
5693         * objc-lang.c: Use C++ exception handling.
5694         * mi/mi-main.c: Use C++ exception handling.
5695         * mi/mi-interp.c: Use C++ exception handling.
5696         * mi/mi-cmd-stack.c: Use C++ exception handling.
5697         * mi/mi-cmd-break.c: Use C++ exception handling.
5698         * main.c: Use C++ exception handling.
5699         * linux-thread-db.c: Use C++ exception handling.
5700         * linux-tdep.c: Use C++ exception handling.
5701         * linux-nat.c: Use C++ exception handling.
5702         * linux-fork.c: Use C++ exception handling.
5703         * linespec.c: Use C++ exception handling.
5704         * language.c: Use C++ exception handling.
5705         * jit.c: Use C++ exception handling.
5706         * infrun.c: Use C++ exception handling.
5707         * infcmd.c: Use C++ exception handling.
5708         * infcall.c: Use C++ exception handling.
5709         * inf-loop.c: Use C++ exception handling.
5710         * i386-tdep.c: Use C++ exception handling.
5711         * i386-linux-tdep.c: Use C++ exception handling.
5712         * guile/scm-value.c: Use C++ exception handling.
5713         * guile/scm-type.c: Use C++ exception handling.
5714         * guile/scm-symtab.c: Use C++ exception handling.
5715         * guile/scm-symbol.c: Use C++ exception handling.
5716         * guile/scm-pretty-print.c: Use C++ exception handling.
5717         * guile/scm-ports.c: Use C++ exception handling.
5718         * guile/scm-param.c: Use C++ exception handling.
5719         * guile/scm-math.c: Use C++ exception handling.
5720         * guile/scm-lazy-string.c: Use C++ exception handling.
5721         * guile/scm-frame.c: Use C++ exception handling.
5722         * guile/scm-disasm.c: Use C++ exception handling.
5723         * guile/scm-cmd.c: Use C++ exception handling.
5724         * guile/scm-breakpoint.c: Use C++ exception handling.
5725         * guile/scm-block.c: Use C++ exception handling.
5726         * guile/guile-internal.h: Use C++ exception handling.
5727         * gnu-v3-abi.c: Use C++ exception handling.
5728         * gdbtypes.c: Use C++ exception handling.
5729         * frame.c: Use C++ exception handling.
5730         * frame-unwind.c: Use C++ exception handling.
5731         * fbsd-tdep.c: Use C++ exception handling.
5732         * f-valprint.c: Use C++ exception handling.
5733         * exec.c: Use C++ exception handling.
5734         * event-top.c: Use C++ exception handling.
5735         * event-loop.c: Use C++ exception handling.
5736         * eval.c: Use C++ exception handling.
5737         * dwarf2read.c: Use C++ exception handling.
5738         * dwarf2loc.c: Use C++ exception handling.
5739         * dwarf2-frame.c: Use C++ exception handling.
5740         * dwarf2-frame-tailcall.c: Use C++ exception handling.
5741         * dwarf-index-write.c: Use C++ exception handling.
5742         * dwarf-index-cache.c: Use C++ exception handling.
5743         * dtrace-probe.c: Use C++ exception handling.
5744         * disasm-selftests.c: Use C++ exception handling.
5745         * darwin-nat.c: Use C++ exception handling.
5746         * cp-valprint.c: Use C++ exception handling.
5747         * cp-support.c: Use C++ exception handling.
5748         * cp-abi.c: Use C++ exception handling.
5749         * corelow.c: Use C++ exception handling.
5750         * completer.c: Use C++ exception handling.
5751         * compile/compile-object-run.c: Use C++ exception handling.
5752         * compile/compile-object-load.c: Use C++ exception handling.
5753         * compile/compile-cplus-symbols.c: Use C++ exception handling.
5754         * compile/compile-c-symbols.c: Use C++ exception handling.
5755         * common/selftest.c: Use C++ exception handling.
5756         * common/new-op.c: Use C++ exception handling.
5757         * cli/cli-script.c: Use C++ exception handling.
5758         * cli/cli-interp.c: Use C++ exception handling.
5759         * cli/cli-cmds.c: Use C++ exception handling.
5760         * c-varobj.c: Use C++ exception handling.
5761         * btrace.c: Use C++ exception handling.
5762         * breakpoint.c: Use C++ exception handling.
5763         * break-catch-throw.c: Use C++ exception handling.
5764         * arch-utils.c: Use C++ exception handling.
5765         * amd64-tdep.c: Use C++ exception handling.
5766         * ada-valprint.c: Use C++ exception handling.
5767         * ada-typeprint.c: Use C++ exception handling.
5768         * ada-lang.c: Use C++ exception handling.
5769         * aarch64-tdep.c: Use C++ exception handling.
5770
5771 2019-04-08  Tom Tromey  <tom@tromey.com>
5772
5773         * xml-support.c (gdb_xml_parser::parse): Update.
5774         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
5775         * value.c (show_convenience): Update.
5776         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
5777         (test_parse_flags_qcs): Update.
5778         * thread.c (thr_try_catch_cmd): Update.
5779         * target.c (target_translate_tls_address): Update.
5780         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
5781         (info_frame_command_core, frame_apply_command_count): Update.
5782         * rust-exp.y (rust_lex_exception_test): Update.
5783         * riscv-tdep.c (riscv_print_one_register_info): Update.
5784         * remote.c (remote_target::enable_btrace): Update.
5785         * record-btrace.c (record_btrace_enable_warn): Update.
5786         * python/py-utils.c (gdbpy_convert_exception): Update.
5787         * printcmd.c (do_one_display, print_variable_and_value): Update.
5788         * mi/mi-main.c (mi_print_exception): Update.
5789         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
5790         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
5791         * linux-nat.c (linux_nat_target::attach): Update.
5792         * linux-fork.c (class scoped_switch_fork_info): Update.
5793         * infrun.c (displaced_step_prepare): Update.
5794         * infcall.c (call_function_by_hand_dummy): Update.
5795         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
5796         * gnu-v3-abi.c (print_one_vtable): Update.
5797         * frame.c (get_prev_frame_always): Update.
5798         * f-valprint.c (info_common_command_for_block): Update.
5799         * exec.c (try_open_exec_file): Update.
5800         * exceptions.c (print_exception, exception_print)
5801         (exception_fprintf, exception_print_same): Update.
5802         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
5803         * dwarf-index-cache.c (index_cache::store)
5804         (index_cache::lookup_gdb_index): Update.
5805         * darwin-nat.c (maybe_cache_shell): Update.
5806         * cp-valprint.c (cp_print_value_fields): Update.
5807         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
5808         (gcc_cplus_symbol_address): Update.
5809         * compile/compile-c-symbols.c (gcc_convert_symbol)
5810         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
5811         * common/selftest.c: Update.
5812         * common/common-exceptions.h (struct gdb_exception) <message>: Now
5813         a std::string.
5814         (exception_try_scope_entry, exception_try_scope_exit): Don't
5815         declare.
5816         (struct exception_try_scope): Remove.
5817         (TRY): Don't use exception_try_scope.
5818         (struct gdb_exception): Add constructor, operator=.
5819         <what>: New method.
5820         (struct gdb_exception_RETURN_MASK_ALL)
5821         (struct gdb_exception_RETURN_MASK_ERROR)
5822         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
5823         (struct gdb_quit_bad_alloc): Update.
5824         * common/common-exceptions.c (exception_none): Change
5825         initializer.
5826         (struct catcher) <state, exception>: Initialize inline.
5827         <prev>: Remove member.
5828         (current_catcher): Remove.
5829         (catchers): New global.
5830         (exceptions_state_mc_init): Simplify.
5831         (catcher_pop): Remove.
5832         (exceptions_state_mc, exceptions_state_mc_catch): Update.
5833         (try_scope_depth, exception_try_scope_entry)
5834         (exception_try_scope_exit): Remove.
5835         (throw_exception_sjlj): Update.
5836         (exception_messages, exception_messages_size): Remove.
5837         (throw_it): Simplify.
5838         (gdb_exception_sliced_copy): Remove.
5839         (throw_exception_cxx): Update.
5840         * cli/cli-script.c (script_from_file): Update.
5841         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
5842         Update.
5843         * ada-valprint.c (ada_val_print): Update.
5844         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
5845         (create_excep_cond_exprs): Update.
5846
5847 2019-04-08  Tom Tromey  <tom@tromey.com>
5848
5849         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
5850         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
5851         (TRY, CATCH, END_CATCH): Remove some definitions.
5852         * common/common-exceptions.c: Don't use GDB_XCPT.
5853         (catcher_list_size): Remove.
5854         (throw_exception, throw_it): Simplify.
5855
5856 2019-04-05  Tom Tromey  <tom@tromey.com>
5857
5858         Revert the header-sorting patch.
5859         * ft32-tdep.c: Revert.
5860         * frv-tdep.c: Revert.
5861         * frv-linux-tdep.c: Revert.
5862         * frame.c: Revert.
5863         * frame-unwind.c: Revert.
5864         * frame-base.c: Revert.
5865         * fork-child.c: Revert.
5866         * findvar.c: Revert.
5867         * findcmd.c: Revert.
5868         * filesystem.c: Revert.
5869         * filename-seen-cache.h: Revert.
5870         * filename-seen-cache.c: Revert.
5871         * fbsd-tdep.c: Revert.
5872         * fbsd-nat.h: Revert.
5873         * fbsd-nat.c: Revert.
5874         * f-valprint.c: Revert.
5875         * f-typeprint.c: Revert.
5876         * f-lang.c: Revert.
5877         * extension.h: Revert.
5878         * extension.c: Revert.
5879         * extension-priv.h: Revert.
5880         * expprint.c: Revert.
5881         * exec.h: Revert.
5882         * exec.c: Revert.
5883         * exceptions.c: Revert.
5884         * event-top.c: Revert.
5885         * event-loop.c: Revert.
5886         * eval.c: Revert.
5887         * elfread.c: Revert.
5888         * dwarf2read.h: Revert.
5889         * dwarf2read.c: Revert.
5890         * dwarf2loc.c: Revert.
5891         * dwarf2expr.h: Revert.
5892         * dwarf2expr.c: Revert.
5893         * dwarf2-frame.c: Revert.
5894         * dwarf2-frame-tailcall.c: Revert.
5895         * dwarf-index-write.h: Revert.
5896         * dwarf-index-write.c: Revert.
5897         * dwarf-index-common.c: Revert.
5898         * dwarf-index-cache.h: Revert.
5899         * dwarf-index-cache.c: Revert.
5900         * dummy-frame.c: Revert.
5901         * dtrace-probe.c: Revert.
5902         * disasm.h: Revert.
5903         * disasm.c: Revert.
5904         * disasm-selftests.c: Revert.
5905         * dictionary.c: Revert.
5906         * dicos-tdep.c: Revert.
5907         * demangle.c: Revert.
5908         * dcache.h: Revert.
5909         * dcache.c: Revert.
5910         * darwin-nat.h: Revert.
5911         * darwin-nat.c: Revert.
5912         * darwin-nat-info.c: Revert.
5913         * d-valprint.c: Revert.
5914         * d-namespace.c: Revert.
5915         * d-lang.c: Revert.
5916         * ctf.c: Revert.
5917         * csky-tdep.c: Revert.
5918         * csky-linux-tdep.c: Revert.
5919         * cris-tdep.c: Revert.
5920         * cris-linux-tdep.c: Revert.
5921         * cp-valprint.c: Revert.
5922         * cp-support.c: Revert.
5923         * cp-namespace.c: Revert.
5924         * cp-abi.c: Revert.
5925         * corelow.c: Revert.
5926         * corefile.c: Revert.
5927         * continuations.c: Revert.
5928         * completer.h: Revert.
5929         * completer.c: Revert.
5930         * complaints.c: Revert.
5931         * coffread.c: Revert.
5932         * coff-pe-read.c: Revert.
5933         * cli-out.h: Revert.
5934         * cli-out.c: Revert.
5935         * charset.c: Revert.
5936         * c-varobj.c: Revert.
5937         * c-valprint.c: Revert.
5938         * c-typeprint.c: Revert.
5939         * c-lang.c: Revert.
5940         * buildsym.c: Revert.
5941         * buildsym-legacy.c: Revert.
5942         * build-id.h: Revert.
5943         * build-id.c: Revert.
5944         * btrace.c: Revert.
5945         * bsd-uthread.c: Revert.
5946         * breakpoint.h: Revert.
5947         * breakpoint.c: Revert.
5948         * break-catch-throw.c: Revert.
5949         * break-catch-syscall.c: Revert.
5950         * break-catch-sig.c: Revert.
5951         * blockframe.c: Revert.
5952         * block.c: Revert.
5953         * bfin-tdep.c: Revert.
5954         * bfin-linux-tdep.c: Revert.
5955         * bfd-target.c: Revert.
5956         * bcache.c: Revert.
5957         * ax-general.c: Revert.
5958         * ax-gdb.h: Revert.
5959         * ax-gdb.c: Revert.
5960         * avr-tdep.c: Revert.
5961         * auxv.c: Revert.
5962         * auto-load.c: Revert.
5963         * arm-wince-tdep.c: Revert.
5964         * arm-tdep.c: Revert.
5965         * arm-symbian-tdep.c: Revert.
5966         * arm-pikeos-tdep.c: Revert.
5967         * arm-obsd-tdep.c: Revert.
5968         * arm-nbsd-tdep.c: Revert.
5969         * arm-nbsd-nat.c: Revert.
5970         * arm-linux-tdep.c: Revert.
5971         * arm-linux-nat.c: Revert.
5972         * arm-fbsd-tdep.c: Revert.
5973         * arm-fbsd-nat.c: Revert.
5974         * arm-bsd-tdep.c: Revert.
5975         * arch-utils.c: Revert.
5976         * arc-tdep.c: Revert.
5977         * arc-newlib-tdep.c: Revert.
5978         * annotate.h: Revert.
5979         * annotate.c: Revert.
5980         * amd64-windows-tdep.c: Revert.
5981         * amd64-windows-nat.c: Revert.
5982         * amd64-tdep.c: Revert.
5983         * amd64-sol2-tdep.c: Revert.
5984         * amd64-obsd-tdep.c: Revert.
5985         * amd64-obsd-nat.c: Revert.
5986         * amd64-nbsd-tdep.c: Revert.
5987         * amd64-nbsd-nat.c: Revert.
5988         * amd64-nat.c: Revert.
5989         * amd64-linux-tdep.c: Revert.
5990         * amd64-linux-nat.c: Revert.
5991         * amd64-fbsd-tdep.c: Revert.
5992         * amd64-fbsd-nat.c: Revert.
5993         * amd64-dicos-tdep.c: Revert.
5994         * amd64-darwin-tdep.c: Revert.
5995         * amd64-bsd-nat.c: Revert.
5996         * alpha-tdep.c: Revert.
5997         * alpha-obsd-tdep.c: Revert.
5998         * alpha-nbsd-tdep.c: Revert.
5999         * alpha-mdebug-tdep.c: Revert.
6000         * alpha-linux-tdep.c: Revert.
6001         * alpha-linux-nat.c: Revert.
6002         * alpha-bsd-tdep.c: Revert.
6003         * alpha-bsd-nat.c: Revert.
6004         * aix-thread.c: Revert.
6005         * agent.c: Revert.
6006         * addrmap.c: Revert.
6007         * ada-varobj.c: Revert.
6008         * ada-valprint.c: Revert.
6009         * ada-typeprint.c: Revert.
6010         * ada-tasks.c: Revert.
6011         * ada-lang.c: Revert.
6012         * aarch64-tdep.c: Revert.
6013         * aarch64-ravenscar-thread.c: Revert.
6014         * aarch64-newlib-tdep.c: Revert.
6015         * aarch64-linux-tdep.c: Revert.
6016         * aarch64-linux-nat.c: Revert.
6017         * aarch64-fbsd-tdep.c: Revert.
6018         * aarch64-fbsd-nat.c: Revert.
6019         * aarch32-linux-nat.c: Revert.
6020
6021 2019-04-05  Tom Tromey  <tom@tromey.com>
6022
6023         * ft32-tdep.c: Sort headers.
6024         * frv-tdep.c: Sort headers.
6025         * frv-linux-tdep.c: Sort headers.
6026         * frame.c: Sort headers.
6027         * frame-unwind.c: Sort headers.
6028         * frame-base.c: Sort headers.
6029         * fork-child.c: Sort headers.
6030         * findvar.c: Sort headers.
6031         * findcmd.c: Sort headers.
6032         * filesystem.c: Sort headers.
6033         * filename-seen-cache.h: Sort headers.
6034         * filename-seen-cache.c: Sort headers.
6035         * fbsd-tdep.c: Sort headers.
6036         * fbsd-nat.h: Sort headers.
6037         * fbsd-nat.c: Sort headers.
6038         * f-valprint.c: Sort headers.
6039         * f-typeprint.c: Sort headers.
6040         * f-lang.c: Sort headers.
6041         * extension.h: Sort headers.
6042         * extension.c: Sort headers.
6043         * extension-priv.h: Sort headers.
6044         * expprint.c: Sort headers.
6045         * exec.h: Sort headers.
6046         * exec.c: Sort headers.
6047         * exceptions.c: Sort headers.
6048         * event-top.c: Sort headers.
6049         * event-loop.c: Sort headers.
6050         * eval.c: Sort headers.
6051         * elfread.c: Sort headers.
6052         * dwarf2read.h: Sort headers.
6053         * dwarf2read.c: Sort headers.
6054         * dwarf2loc.c: Sort headers.
6055         * dwarf2expr.h: Sort headers.
6056         * dwarf2expr.c: Sort headers.
6057         * dwarf2-frame.c: Sort headers.
6058         * dwarf2-frame-tailcall.c: Sort headers.
6059         * dwarf-index-write.h: Sort headers.
6060         * dwarf-index-write.c: Sort headers.
6061         * dwarf-index-common.c: Sort headers.
6062         * dwarf-index-cache.h: Sort headers.
6063         * dwarf-index-cache.c: Sort headers.
6064         * dummy-frame.c: Sort headers.
6065         * dtrace-probe.c: Sort headers.
6066         * disasm.h: Sort headers.
6067         * disasm.c: Sort headers.
6068         * disasm-selftests.c: Sort headers.
6069         * dictionary.c: Sort headers.
6070         * dicos-tdep.c: Sort headers.
6071         * demangle.c: Sort headers.
6072         * dcache.h: Sort headers.
6073         * dcache.c: Sort headers.
6074         * darwin-nat.h: Sort headers.
6075         * darwin-nat.c: Sort headers.
6076         * darwin-nat-info.c: Sort headers.
6077         * d-valprint.c: Sort headers.
6078         * d-namespace.c: Sort headers.
6079         * d-lang.c: Sort headers.
6080         * ctf.c: Sort headers.
6081         * csky-tdep.c: Sort headers.
6082         * csky-linux-tdep.c: Sort headers.
6083         * cris-tdep.c: Sort headers.
6084         * cris-linux-tdep.c: Sort headers.
6085         * cp-valprint.c: Sort headers.
6086         * cp-support.c: Sort headers.
6087         * cp-namespace.c: Sort headers.
6088         * cp-abi.c: Sort headers.
6089         * corelow.c: Sort headers.
6090         * corefile.c: Sort headers.
6091         * continuations.c: Sort headers.
6092         * completer.h: Sort headers.
6093         * completer.c: Sort headers.
6094         * complaints.c: Sort headers.
6095         * coffread.c: Sort headers.
6096         * coff-pe-read.c: Sort headers.
6097         * cli-out.h: Sort headers.
6098         * cli-out.c: Sort headers.
6099         * charset.c: Sort headers.
6100         * c-varobj.c: Sort headers.
6101         * c-valprint.c: Sort headers.
6102         * c-typeprint.c: Sort headers.
6103         * c-lang.c: Sort headers.
6104         * buildsym.c: Sort headers.
6105         * buildsym-legacy.c: Sort headers.
6106         * build-id.h: Sort headers.
6107         * build-id.c: Sort headers.
6108         * btrace.c: Sort headers.
6109         * bsd-uthread.c: Sort headers.
6110         * breakpoint.h: Sort headers.
6111         * breakpoint.c: Sort headers.
6112         * break-catch-throw.c: Sort headers.
6113         * break-catch-syscall.c: Sort headers.
6114         * break-catch-sig.c: Sort headers.
6115         * blockframe.c: Sort headers.
6116         * block.c: Sort headers.
6117         * bfin-tdep.c: Sort headers.
6118         * bfin-linux-tdep.c: Sort headers.
6119         * bfd-target.c: Sort headers.
6120         * bcache.c: Sort headers.
6121         * ax-general.c: Sort headers.
6122         * ax-gdb.h: Sort headers.
6123         * ax-gdb.c: Sort headers.
6124         * avr-tdep.c: Sort headers.
6125         * auxv.c: Sort headers.
6126         * auto-load.c: Sort headers.
6127         * arm-wince-tdep.c: Sort headers.
6128         * arm-tdep.c: Sort headers.
6129         * arm-symbian-tdep.c: Sort headers.
6130         * arm-pikeos-tdep.c: Sort headers.
6131         * arm-obsd-tdep.c: Sort headers.
6132         * arm-nbsd-tdep.c: Sort headers.
6133         * arm-nbsd-nat.c: Sort headers.
6134         * arm-linux-tdep.c: Sort headers.
6135         * arm-linux-nat.c: Sort headers.
6136         * arm-fbsd-tdep.c: Sort headers.
6137         * arm-fbsd-nat.c: Sort headers.
6138         * arm-bsd-tdep.c: Sort headers.
6139         * arch-utils.c: Sort headers.
6140         * arc-tdep.c: Sort headers.
6141         * arc-newlib-tdep.c: Sort headers.
6142         * annotate.h: Sort headers.
6143         * annotate.c: Sort headers.
6144         * amd64-windows-tdep.c: Sort headers.
6145         * amd64-windows-nat.c: Sort headers.
6146         * amd64-tdep.c: Sort headers.
6147         * amd64-sol2-tdep.c: Sort headers.
6148         * amd64-obsd-tdep.c: Sort headers.
6149         * amd64-obsd-nat.c: Sort headers.
6150         * amd64-nbsd-tdep.c: Sort headers.
6151         * amd64-nbsd-nat.c: Sort headers.
6152         * amd64-nat.c: Sort headers.
6153         * amd64-linux-tdep.c: Sort headers.
6154         * amd64-linux-nat.c: Sort headers.
6155         * amd64-fbsd-tdep.c: Sort headers.
6156         * amd64-fbsd-nat.c: Sort headers.
6157         * amd64-dicos-tdep.c: Sort headers.
6158         * amd64-darwin-tdep.c: Sort headers.
6159         * amd64-bsd-nat.c: Sort headers.
6160         * alpha-tdep.c: Sort headers.
6161         * alpha-obsd-tdep.c: Sort headers.
6162         * alpha-nbsd-tdep.c: Sort headers.
6163         * alpha-mdebug-tdep.c: Sort headers.
6164         * alpha-linux-tdep.c: Sort headers.
6165         * alpha-linux-nat.c: Sort headers.
6166         * alpha-bsd-tdep.c: Sort headers.
6167         * alpha-bsd-nat.c: Sort headers.
6168         * aix-thread.c: Sort headers.
6169         * agent.c: Sort headers.
6170         * addrmap.c: Sort headers.
6171         * ada-varobj.c: Sort headers.
6172         * ada-valprint.c: Sort headers.
6173         * ada-typeprint.c: Sort headers.
6174         * ada-tasks.c: Sort headers.
6175         * ada-lang.c: Sort headers.
6176         * aarch64-tdep.c: Sort headers.
6177         * aarch64-ravenscar-thread.c: Sort headers.
6178         * aarch64-newlib-tdep.c: Sort headers.
6179         * aarch64-linux-tdep.c: Sort headers.
6180         * aarch64-linux-nat.c: Sort headers.
6181         * aarch64-fbsd-tdep.c: Sort headers.
6182         * aarch64-fbsd-nat.c: Sort headers.
6183         * aarch32-linux-nat.c: Sort headers.
6184
6185 2019-04-04  Tom Tromey  <tom@tromey.com>
6186
6187         * varobj.c (varobj_create): Update.
6188         * rust-exp.y (struct rust_parser) <update_innermost_block,
6189         lookup_symbol>: New methods.
6190         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
6191         Rename.
6192         (rust_parser::rust_lookup_type)
6193         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
6194         * printcmd.c (display_command, do_one_display): Update.
6195         * parser-defs.h (struct parser_state) <parser_state>: Add
6196         "tracker" parameter.
6197         (block_tracker): New member.
6198         (class innermost_block_tracker) <innermost_block_tracker>: Add
6199         "types" parameter.
6200         <reset>: Remove method.
6201         (innermost_block): Don't declare.
6202         (null_post_parser): Update.
6203         * parse.c (innermost_block): Remove global.
6204         (write_dollar_variable): Update.
6205         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
6206         Remove "tracker_types" parameter.
6207         (parse_expression): Add "tracker" parameter.
6208         (parse_expression_for_completion): Update.
6209         (null_post_parser): Add "tracker" parameter.
6210         * p-exp.y: Update rules.
6211         * m2-exp.y: Update rules.
6212         * language.h (struct language_defn) <la_post_parser>: Add
6213         "tracker" parameter.
6214         * go-exp.y: Update rules.
6215         * f-exp.y: Update rules.
6216         * expression.h (parse_expression, parse_exp_1): Add "tracker"
6217         parameter.
6218         * d-exp.y: Update rules.
6219         * c-exp.y: Update rules.
6220         * breakpoint.c (set_breakpoint_condition): Create an
6221         innermost_block_tracker.
6222         (watch_command_1): Likewise.
6223         * ada-lang.c (resolve): Add "tracker" parameter.
6224         (resolve_subexp): Likewise.
6225         * ada-exp.y (write_var_from_sym): Update.
6226
6227 2019-04-04  Tom Tromey  <tom@tromey.com>
6228
6229         * type-stack.h: New file.
6230         * type-stack.c: New file.
6231         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
6232         type-stack.h.
6233         (insert_into_type_stack, insert_type, push_type, push_type_int)
6234         (insert_type_address_space, pop_type, pop_type_int)
6235         (pop_typelist, pop_type_stack, append_type_stack)
6236         (push_type_stack, get_type_stack, push_typelist)
6237         (follow_type_instance_flags, follow_types): Don't declare.
6238         * parse.c (type_stack): Remove global.
6239         (parse_exp_in_context): Update.
6240         (insert_into_type_stack, insert_type, push_type, push_type_int)
6241         (insert_type_address_space, pop_type, pop_type_int)
6242         (pop_typelist, pop_type_stack, append_type_stack)
6243         (push_type_stack, get_type_stack, push_typelist)
6244         (follow_type_instance_flags, follow_types): Remove (moved to
6245         type-stack.c).
6246         * f-exp.y (type_stack): New global.
6247         Update rules.
6248         (push_kind_type, f_parse): Update.
6249         * d-exp.y (type_stack): New global.
6250         Update rules.
6251         (d_parse): Update.
6252         * c-exp.y (struct c_parse_state) <type_stack>: New member.
6253         Update rules.
6254         * Makefile.in (COMMON_SFILES): Add type-stack.c.
6255         (HFILES_NO_SRCDIR): Add type-stack.h.
6256
6257 2019-04-04  Tom Tromey  <tom@tromey.com>
6258
6259         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
6260         (rust_parser::convert_ast_to_expression, rust_parse)
6261         (rust_lex_test_completion, rust_lex_tests): Update.
6262         * parser-defs.h (struct expr_completion_state): New.
6263         (struct parser_state) <parser_state>: Add completion parameter.
6264         <mark_struct_expression, mark_completion_tag>: New methods.
6265         <parse_completion, m_completion_state>: New members.
6266         (prefixify_expression, null_post_parser): Update.
6267         (mark_struct_expression, mark_completion_tag): Don't declare.
6268         * parse.c (parse_completion, expout_last_struct)
6269         (expout_tag_completion_type, expout_completion_name): Remove
6270         globals.
6271         (parser_state::mark_struct_expression)
6272         (parser_state::mark_completion_tag): Now methods.
6273         (prefixify_expression): Add last_struct parameter.
6274         (prefixify_subexp): Likewise.
6275         (parse_exp_1): Update.
6276         (parse_exp_in_context): Add cstate parameter.  Update.
6277         (parse_expression_for_completion): Create an
6278         expr_completion_state.
6279         (null_post_parser): Add "completion" parameter.
6280         * p-exp.y: Update rules.
6281         (yylex): Update.
6282         * language.h (struct language_defn) <la_post_parser>: Add
6283         "completing" parameter.
6284         * go-exp.y: Update rules.
6285         (lex_one_token): Update.
6286         * expression.h (parse_completion): Don't declare.
6287         * d-exp.y: Update rules.
6288         (lex_one_token): Update rules.
6289         * c-exp.y: Update rules.
6290         (lex_one_token): Update.
6291         * ada-lang.c (resolve): Add "parse_completion" parameter.
6292         (resolve_subexp): Likewise.
6293         (ada_resolve_function): Likewise.
6294
6295 2019-04-04  Tom Tromey  <tom@tromey.com>
6296
6297         * parser-defs.h (struct parser_state) <start_arglist,
6298         end_arglist>: New methods.
6299         <arglist_len, m_funcall_chain>: New members.
6300         (arglist_len, start_arglist, end_arglist): Don't declare.
6301         * parse.c (arglist_len, funcall_chain): Remove global.
6302         (start_arglist, end_arglist): Remove functions.
6303         (parse_exp_in_context): Update.
6304         * p-exp.y: Update rules.
6305         * m2-exp.y: Update rules.
6306         * go-exp.y: Update rules.
6307         * f-exp.y: Update rules.
6308         * d-exp.y: Update rules.
6309         * c-exp.y: Update rules.
6310
6311 2019-04-04  Tom Tromey  <tom@tromey.com>
6312
6313         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
6314         lex_operator, push_back>: New methods.
6315         Update all rules.
6316         (rust_parser::lex_hex, lex_escape): Rename and update.
6317         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
6318         (rust_parser::lex_operator): Rename and update.
6319         (rust_parser::lex_number, rustyylex, rustyyerror)
6320         (rust_lex_test_init, rust_lex_test_sequence)
6321         (rust_lex_test_push_back, rust_lex_tests): Update.
6322         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
6323         parameter.
6324         <lexptr, prev_lexptr>: New members.
6325         (lexptr, prev_lexptr): Don't declare.
6326         * parse.c (lexptr, prev_lexptr): Remove globals.
6327         (parse_exp_in_context): Update.
6328         * p-exp.y (yylex, yyerror): Update.
6329         * m2-exp.y (parse_number, yylex, yyerror): Update.
6330         * go-exp.y (lex_one_token, yyerror): Update.
6331         * f-exp.y (match_string_literal, yylex, yyerror): Update.
6332         * d-exp.y (lex_one_token, yyerror): Update.
6333         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
6334         (lex_one_token, yyerror): Update.
6335         * ada-lex.l (YY_INPUT): Update.
6336         (rewind_to_char): Update.
6337         * ada-exp.y (yyerror): Update.
6338
6339 2019-04-04  Tom Tromey  <tom@tromey.com>
6340
6341         * rust-exp.y (rustyylex, rust_lex_tests): Update.
6342         * parser-defs.h (struct parser_state) <parser_state>: Add new
6343         parameter.
6344         <comma_terminates>: New member.
6345         (comma_terminates): Don't declare global.
6346         * parse.c (comma_terminates): Remove global.
6347         (parse_exp_in_context): Update.
6348         * p-exp.y (yylex): Update.
6349         * m2-exp.y (yylex): Update.
6350         * go-exp.y (lex_one_token): Update.
6351         * f-exp.y (yylex): Update.
6352         * d-exp.y (lex_one_token): Update.
6353         * c-exp.y (lex_one_token): Update.
6354         * ada-lex.l: Update.
6355
6356 2019-04-04  Tom Tromey  <tom@tromey.com>
6357
6358         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
6359         (rustyylex, rust_lex_test_init, rust_lex_test_one)
6360         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
6361         * parser-defs.h (paren_depth): Don't declare.
6362         * parse.c (paren_depth): Remove global.
6363         (parse_exp_in_context): Update.
6364         * p-exp.y (paren_depth): New global.
6365         (pascal_parse): Initialize it.
6366         * m2-exp.y (paren_depth): New global.
6367         (m2_parse): Initialize it.
6368         * go-exp.y (paren_depth): New global.
6369         (go_parse): Initialize it.
6370         * f-exp.y (paren_depth): New global.
6371         (f_parse): Initialize it.
6372         * d-exp.y (paren_depth): New global.
6373         (d_parse): Initialize it.
6374         * c-exp.y (paren_depth): New global.
6375         (c_parse): Initialize it.
6376         * ada-lex.l (paren_depth): New global.
6377         (lexer_init): Initialize it.
6378
6379 2019-04-04  Tom Tromey  <tom@tromey.com>
6380
6381         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
6382         (rust_parser::convert_ast_to_type)
6383         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
6384         * parser-defs.h (struct parser_state) <parser_state>: Add
6385         parameters.  Initialize new members.
6386         <expression_context_block, expression_context_pc>: New members.
6387         * parse.c (expression_context_block, expression_context_pc):
6388         Remove globals.
6389         (parse_exp_in_context): Update.
6390         * p-exp.y: Update all rules.
6391         (yylex): Update.
6392         * m2-exp.y: Update all rules.
6393         (yylex): Update.
6394         * go-exp.y (yylex): Update.
6395         * f-exp.y (yylex): Update.
6396         * d-exp.y: Update all rules.
6397         (yylex): Update.
6398         * c-exp.y: Update all rules.
6399         (lex_one_token, classify_name, yylex, c_parse): Update.
6400         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
6401
6402 2019-04-04  Tom Tromey  <tom@tromey.com>
6403
6404         * gdbarch.h, gdbarch.c: Rebuild.
6405         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
6406         * stap-probe.h:
6407         (struct stap_parse_info): Replace "parser_state" with
6408         "expr_builder".
6409         * parser-defs.h (struct expr_builder): Rename from "parser_state".
6410         (parser_state): New class.
6411         * parse.c (expr_builder): Rename.
6412         (expr_builder::release): Rename.
6413         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
6414         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
6415         (write_exp_elt_longcst, write_exp_elt_floatcst)
6416         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
6417         (write_exp_string_vector, write_exp_bitstring)
6418         (write_exp_msymbol, mark_struct_expression)
6419         (write_dollar_variable)
6420         (insert_type_address_space, increase_expout_size): Replace
6421         "parser_state" with "expr_builder".
6422         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
6423         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
6424         "parser_state" with "expr_builder".
6425
6426 2019-04-04  Tom Tromey  <tom@tromey.com>
6427
6428         * rust-exp.y: Replace "parse_language" with method call.
6429         * p-exp.y:
6430         (yylex): Replace "parse_language" with method call.
6431         * m2-exp.y:
6432         (yylex): Replace "parse_language" with method call.
6433         * go-exp.y (classify_name): Replace "parse_language" with method
6434         call.
6435         * f-exp.y (yylex): Replace "parse_language" with method call.
6436         * d-exp.y (lex_one_token): Replace "parse_language" with method
6437         call.
6438         * c-exp.y:
6439         (lex_one_token, classify_name, yylex): Replace "parse_language"
6440         with method call.
6441         * ada-exp.y (find_primitive_type, type_char)
6442         (type_system_address): Replace "parse_language" with method call.
6443
6444 2019-04-04  Tom Tromey  <tom@tromey.com>
6445
6446         * rust-exp.y: Replace "parse_gdbarch" with method call.
6447         * parse.c (write_dollar_variable, insert_type_address_space):
6448         Replace "parse_gdbarch" with method call.
6449         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
6450         call.
6451         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
6452         call.
6453         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
6454         "parse_gdbarch" with method call.
6455         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
6456         with method call.
6457         * f-exp.y (parse_type, parse_f_type, yylex): Replace
6458         "parse_gdbarch" with method call.
6459         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
6460         "parse_gdbarch" with method call.
6461         * c-exp.y (parse_type, parse_number, classify_name): Replace
6462         "parse_gdbarch" with method call.
6463         * ada-lex.l: Replace "parse_gdbarch" with method call.
6464         * ada-exp.y (parse_type, find_primitive_type, type_char)
6465         (type_system_address): Replace "parse_gdbarch" with method call.
6466
6467 2019-04-04  Tom Tromey  <tom@tromey.com>
6468
6469         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
6470         * stap-probe.c (stap_parse_argument): Update.
6471         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
6472         initial_size parameter.
6473         * rust-exp.y (rust_lex_tests): Update.
6474         * parse.c (parser_state): Update.
6475         (parse_exp_in_context): Update.
6476         * parser-defs.h (struct parser_state) <parser_state>: Remove
6477         "initial_size" parameter.
6478
6479 2019-04-04  Tom Tromey  <tom@tromey.com>
6480
6481         * parser-defs.h (increase_expout_size): Don't declare.
6482         * parse.c (increase_expout_size): Now static.
6483
6484 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
6485
6486         * gnu-nat.c (gnu_nat_target::wait): Fix
6487         target_waitstatus_to_string call.
6488
6489 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6490
6491         * eval.c (evaluate_subexp_standard): Handle internal functions
6492         during Fortran function call handling.
6493
6494 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6495
6496         * NEWS: Mention new internal functions.
6497         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
6498         (read_base_type): Use dwarf2_init_complex_target_type.
6499         * value.c (creal_internal_fn): New function.
6500         (cimag_internal_fn): New function.
6501         (_initialize_values): Register new internal functions.
6502
6503 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6504
6505         * infrun.c (stop_all_threads): If debug_infrun, always
6506         trace the wait status after wait_one, using
6507         target_waitstatus_to_string and target_pid_to_str.
6508         (handle_inferior_event): Replace various trace of
6509         wait status kind by a single trace.
6510         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
6511         wait status kind image by target_waitstatus_to_string.
6512         * target/waitstatus.c (target_waitstatus_to_string): Fix
6513         obsolete comment.
6514
6515 2019-04-01  Tom Tromey  <tromey@adacore.com>
6516
6517         PR symtab/23331:
6518         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
6519
6520 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
6521             Pedro Alves  <palves@redhat.com>
6522
6523         * top.c (quit_force): Call 'finalize_values'.
6524         * value.c (finalize_values): New function.
6525         * value.h (finalize_values): Declare.
6526
6527 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
6528
6529         * NEWS: Announce $_gdb_major and $_gdb_minor.
6530
6531         * top.c (init_gdb_version_vars): New function.
6532         (gdb_init): Call init_gdb_version_vars.
6533
6534 2019-03-29  Tom Tromey  <tromey@adacore.com>
6535
6536         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
6537         help text.  Remove dead code.
6538
6539 2019-03-29  Keith Seitz  <keiths@redhat.com>
6540
6541         From Siddhesh Poyarekar:
6542         * f-lang.h (f77_get_upperbound): Return LONGEST.
6543         (f77_get_lowerbound): Likewise.
6544         * f-typeprint.c (f_type_print_varspec_suffix): Expand
6545         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
6546         print them.
6547         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
6548         plongest to format print it.
6549         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
6550         (f77_get_upperbound): Likewise.
6551         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
6552         LOWER_BOUND to LONGEST.
6553         (f77_create_arrayprint_offset_tbl): Likewise.
6554
6555 2019-03-29  Keith Seitz  <keiths@redhat.com>
6556
6557         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
6558         %s/pulongest for TYPE_LENGTH instead of %d in format
6559         strings.
6560         * ada-typerint.c (ada_print_type): Likewise.
6561         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
6562         * compile/compile-c-support.c (generate_register_struct): Likewise.
6563         * gdbtypes.c (recursive_dump_type): Likewise.
6564         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
6565         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
6566         instead of %d in format strings.
6567         * riscv-tdep.c (riscv_type_alignment): Cast second argument
6568         to std::min to ULONGEST.
6569         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
6570         instead of %d in format strings.
6571         * tracepoint.c (info_scope_command): Likewise.
6572         * typeprint.c (print_offset_data::update)
6573         (print_offset_data::finish): Likewise.
6574         * xtensa-tdep.c (xtensa_store_return_value)
6575         (xtensa_push_dummy_call): Likewise.
6576
6577 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
6578
6579         * windows-nat.c (display_selector): Fixed format specifications
6580         for 64-bit Cygwin.
6581
6582 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6583
6584         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
6585
6586 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
6587
6588         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
6589         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
6590         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
6591         (nios2_linux_init_abi): Install it.
6592
6593 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
6594
6595         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
6596
6597 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
6598
6599         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
6600
6601 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6602             Tom Tromey  <tromey@adacore.com>
6603
6604         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
6605
6606 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
6607
6608         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
6609         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
6610         method to compute the bounds of range types. Also print "[evaluated]"
6611         if the bounds' values come from a dynamic evaluation.
6612
6613 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
6614
6615         * cp-valprint.c (cp_print_value_fields): Don't print trailing
6616         whitespace when pretty printing is on.
6617
6618 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6619
6620         * ppc-linux-nat.c: Add include.
6621
6622 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6623
6624         * NEWS: Mention AArch64 Pointer Authentication.
6625
6626 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6627
6628         * arm-linux-nat.c: Add include.
6629
6630 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
6631
6632         * source-cache.c (source_cache::get_source_lines): Re-read
6633         fullname after calling open_source_file.
6634
6635 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
6636
6637         * NEWS: Mention TLS support for FreeBSD.
6638
6639 2019-03-25  Tom Tromey  <tromey@adacore.com>
6640
6641         * minsyms.c (BUNCH_SIZE): Update comment.
6642         (~minimal_symbol_reader): Remove old comment.
6643         (compact_minimal_symbols): Update comment.
6644         (minimal_symbol_reader::install): Remove old comment.  Update
6645         other comments.
6646
6647 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
6648
6649         * s390-linux-nat.c: Add include.
6650
6651 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
6652
6653         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
6654         Call linux_get_hwcap.
6655         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
6656         Likewise.
6657         (aarch64_linux_get_hwcap): Remove function.
6658         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
6659         declaration.
6660         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
6661         linux_get_hwcap.
6662         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
6663         * linux-tdep.c (linux_get_hwcap): Add function.
6664         (linux_get_hwcap2): Likewise.
6665         * linux-tdep.h (linux_get_hwcap): Add declaration.
6666         (linux_get_hwcap2): Likewise.
6667         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
6668         (ppc_linux_get_hwcap2): Likewise.
6669         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
6670         linux_get_hwcap.
6671         (ppc_linux_nat_target::insert_watchpoint): Likewise.
6672         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
6673         (ppc_linux_nat_target::read_description): Likewise.
6674         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
6675         * s390-linux-nat.c: Likewise.
6676         * s390-linux-tdep.c (s390_core_read_description): Likewise.
6677
6678 2019-03-24  Tom Tromey  <tom@tromey.com>
6679
6680         * ada-lang.c (standard_lookup): Simplify initialization.
6681         (ada_lookup_symbol_nonlocal): Simplify return.
6682         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
6683         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
6684         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
6685         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
6686         initialization.
6687         * solib.c (solib_global_lookup): Simplify.
6688         * symtab.c (null_block_symbol): Remove.
6689         (symbol_cache_lookup): Simplify returns.
6690         (lookup_language_this): Simplify returns.
6691         (lookup_symbol_aux): Simplify return.
6692         (lookup_local_symbol): Simplify returns.
6693         (lookup_global_symbol_from_objfile): Simplify return.
6694         (lookup_symbol_in_objfile_symtabs)
6695         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
6696         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
6697         (lookup_static_symbol, lookup_global_symbol): Simplify return.
6698         * cp-namespace.c (cp_lookup_bare_symbol)
6699         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
6700         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
6701         (cp_lookup_nested_symbol): Don't use null_block_symbol.
6702         (cp_lookup_symbol_via_imports): Simplify initialization.
6703         (find_symbol_in_baseclass): Likewise.
6704         * symtab.h (null_block_symbol): Remove.
6705         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
6706         (d_lookup_nested_symbol, d_lookup_symbol_imports)
6707         (d_lookup_symbol_module): Likewise.
6708         (find_symbol_in_baseclass): Simplify initialization.
6709
6710 2019-03-24  Tom Tromey  <tom@tromey.com>
6711
6712         * expression.h: Don't include symtab.h.
6713         (struct block): Forward declare.
6714
6715 2019-03-24  Tom Tromey  <tom@tromey.com>
6716
6717         * c-exp.y (typebase): Remove casts.
6718         * gdbtypes.c (lookup_unsigned_typename, )
6719         (lookup_signed_typename): Remove cast.
6720         * eval.c (parse_to_comma_and_eval): Remove cast.
6721         * parse.c (write_dollar_variable): Remove cast.
6722         * block.h (struct block) <superblock>: Now const.
6723         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
6724         * psymtab.c (psym_map_matching_symbols): Make "block" const.
6725         (map_block): Make "block" const.
6726         * symfile.h (struct quick_symbol_functions)
6727         <map_matching_symbols>: Constify block argument to "callback".
6728         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
6729         const.
6730         (find_pc_sect_compunit_symtab): Make "b" const.
6731         (find_symbol_at_address): Likewise.
6732         (search_symbols): Likewise.
6733         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
6734         (dw2_debug_names_lookup_symbol): Likewise.
6735         (dw2_map_matching_symbols): Update.
6736         * p-valprint.c (pascal_val_print): Remove "block".
6737         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
6738         (aux_add_nonlocal_symbols): Make "block" const.
6739         (resolve_subexp): Remove cast.
6740         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
6741         const.
6742         (iterate_over_file_blocks): Likewise.
6743         * f-exp.y (%union) <bval>: Remove.
6744         * coffread.c (patch_opaque_types): Make "b" const.
6745         * spu-tdep.c (spu_catch_start): Make "block" const.
6746         * c-valprint.c (print_unpacked_pointer): Remove "block".
6747         * symmisc.c (dump_symtab_1): Make "b" const.
6748         (block_depth): Make "block" const.
6749         * d-exp.y (%union) <bval>: Remove.
6750         * cp-support.h (cp_lookup_rtti_type): Update.
6751         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
6752         * psymtab.c (psym_lookup_symbol): Make "block" const.
6753         (maintenance_check_psymtabs): Make "b" const.
6754         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
6755         (enumerate_locals, enumerate_args): Update.
6756         * python/py-symtab.c (stpy_global_block): Make "block" const.
6757         (stpy_static_block): Likewise.
6758         * inline-frame.c (block_starting_point_at): Make "new_block"
6759         const.
6760         * block.c (find_block_in_blockvector): Make return type const.
6761         (blockvector_for_pc_sect): Make "b" const.
6762         (find_block_in_blockvector): Make "b" const.
6763
6764 2019-03-23  Tom Tromey  <tom@tromey.com>
6765
6766         * varobj.c (varobj_create): Update.
6767         * symfile.c (clear_symtab_users): Don't reset innermost_block.
6768         * printcmd.c (display_command, do_one_display): Don't reset
6769         innermost_block.
6770         * parser-defs.h (enum innermost_block_tracker_type): Move to
6771         expression.h.
6772         (innermost_block): Update comment.
6773         * parse.c (parse_exp_1): Add tracker_types parameter.
6774         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
6775         tracker_types parameter.  Reset innermost_block.
6776         (parse_exp_in_context): Remove.
6777         (parse_expression_for_completion): Update.
6778         * objfiles.c (~objfile): Don't reset expression_context_block or
6779         innermost_block.
6780         * expression.h (enum innermost_block_tracker_type): Move from
6781         parser-defs.h.
6782         (parse_exp_1): Add tracker_types parameter.
6783         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
6784         reset innermost_block.
6785
6786 2019-03-23  Tom Tromey  <tom@tromey.com>
6787
6788         * objfiles.h: Include bcache.h.
6789
6790 2019-03-23  Tom Tromey  <tom@tromey.com>
6791
6792         * linespec.c (get_current_search_block): Use
6793         scoped_restore_current_language.
6794         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
6795
6796 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6797             Jiong Wang  <jiong.wang@arm.com>
6798
6799         * aarch64-linux-tdep.c
6800         (aarch64_linux_iterate_over_regset_sections): Check for pauth
6801         section.
6802         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
6803
6804 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6805             Jiong Wang  <jiong.wang@arm.com>
6806
6807         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
6808         instructions.
6809         (aarch64_analyze_prologue_test): Add PACIASP test.
6810         (aarch64_prologue_prev_register): Unmask PC value.
6811
6812 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6813             Jiong Wang  <jiong.wang@arm.com>
6814
6815         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
6816         (aarch64_dwarf2_prev_register): Unmask PC value.
6817         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
6818         (aarch64_execute_dwarf_cfa_vendor_op): Check for
6819         DW_CFA_AARCH64_negate_ra_state.
6820         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
6821
6822 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6823             Jiong Wang  <jiong.wang@arm.com>
6824
6825         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
6826         registers.
6827         (aarch64_pseudo_register_name): Likewise.
6828         (aarch64_pseudo_register_type): Likewise.
6829         (aarch64_pseudo_register_reggroup_p): Likewise.
6830         (aarch64_gdbarch_init): Add pauth registers.
6831         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
6832         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
6833         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
6834         (struct gdbarch_tdep): Add regnum for ra_state.
6835
6836 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6837             Jiong Wang  <jiong.wang@arm.com>
6838
6839         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
6840
6841 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6842             Jiong Wang  <jiong.wang@arm.com>
6843
6844         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
6845         function.
6846         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
6847         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
6848         (aarch64_gdbarch_init): Add puth registers.
6849         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
6850         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
6851         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
6852
6853 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6854             Jiong Wang  <jiong.wang@arm.com>
6855
6856         * aarch64-linux-nat.c
6857         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
6858         * aarch64-linux-tdep.c
6859         (aarch64_linux_core_read_description): Likewise.
6860         (aarch64_linux_get_hwcap): New function.
6861         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
6862         (aarch64_linux_get_hwcap): New declaration.
6863
6864 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6865             Jiong Wang  <jiong.wang@arm.com>
6866
6867         * aarch64-linux-nat.c
6868         (aarch64_linux_nat_target::read_description): Add pauth param.
6869         * aarch64-linux-tdep.c
6870         (aarch64_linux_core_read_description): Likewise.
6871         * aarch64-tdep.c (struct target_desc): Add in pauth.
6872         (aarch64_read_description): Add pauth param.
6873         (aarch64_gdbarch_init): Likewise.
6874         * aarch64-tdep.h (aarch64_read_description): Likewise.
6875         * arch/aarch64.c (aarch64_create_target_description): Likewise.
6876         * arch/aarch64.h (aarch64_create_target_description): Likewise.
6877         * features/Makefile: Add new files.
6878         * features/aarch64-pauth.c: New file.
6879         * features/aarch64-pauth.xml: New file.
6880
6881 2019-03-20  Tom Tromey  <tromey@adacore.com>
6882
6883         * infrun.c (handle_inferior_event): Rename from
6884         handle_inferior_event_1.  Create a scoped_value_mark.
6885         (handle_inferior_event): Remove.
6886
6887 2019-03-19  Tom Tromey  <tromey@adacore.com>
6888
6889         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
6890         * infrun.h (print_stop_event): Add "displays" parameter.
6891         * infrun.c (print_stop_event): Add "displays" parameter.
6892
6893 2019-03-19  Pedro Alves  <palves@redhat.com>
6894
6895         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
6896         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
6897         to -1.  Fix TABs vs spaces.
6898         (tui_ui_out::tui_ui_out): Don't initialize fields here.
6899         * tui/tui-out.h (tui_ui_out) Add intro comments.
6900         <m_line, m_start_of_line>: In-class initialize, and add describing
6901         comment.
6902
6903 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
6904
6905         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
6906         variable names.
6907         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
6908
6909 2019-03-18  Pedro Alves  <palves@redhat.com>
6910             Eli Zaretskii <eliz@gnu.org>
6911
6912         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
6913         m_line and m_start_of_line.
6914
6915 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
6916
6917         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
6918         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
6919         it returns a newline.  This fixes a regression in TU mode, whereby
6920         the next line is output on the same screen line as the user input.
6921
6922 2019-03-18  Tom Tromey  <tromey@adacore.com>
6923
6924         * minsyms.c (minimal_symbol_reader::install): Remove call to
6925         obstack_blank.
6926
6927 2019-03-18  Pedro Alves  <palves@redhat.com>
6928
6929         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
6930         New globals.
6931         (apply_style): New, factored out from ...
6932         (apply_ansi_escape): ... this.  Handle reverse video mode.
6933         (tui_set_reverse_mode): New function.
6934         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
6935         * tui/tui-winsource.c (tui_show_source_line): Use
6936         tui_set_reverse_mode instead of setting A_STANDOUT.
6937         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
6938         New setter methods.
6939
6940 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
6941
6942         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
6943         Handle tabs.
6944
6945 2019-03-18  Tom Tromey  <tromey@adacore.com>
6946
6947         * ada-lang.c (empty_array): Add "high" parameter.
6948         (ada_evaluate_subexp): Update.
6949
6950 2019-03-17  Sergei Trofimovich <siarheit@google.com>
6951
6952         * unittests/string_view-selftests.c: Define
6953         _initialize_string_view_selftests unconditionally.
6954
6955 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
6956
6957         PR gdb/24350
6958         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
6959
6960 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
6961
6962         PR gdb/24351
6963         * windows-nat.c (display_selector): Fix format specifiers.
6964
6965 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
6966
6967         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
6968         tui_refill_source_window instead of tui_refresh_win, to update the
6969         current execution line.  This fixes redisplay of the current line
6970         when stepping through the code with "next" or "step".
6971
6972 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
6973
6974         * source-cache.c (source_cache::get_source_lines): Call
6975         find_source_lines to initialize s->nlines.  This fixes vertical
6976         scrolling of TUI source window when the DOWN arrow is pressed.
6977
6978 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6979
6980         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
6981         linux-thread-db.c (_initialize_thread_db): Likewise.
6982
6983 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
6984
6985         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
6986         wclrtoeol in tui_show_source_line".  This reverts changes made in
6987         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
6988
6989 2019-03-15  Tom Tromey  <tom@tromey.com>
6990
6991         * symtab.h (struct minimal_symbol): Derive from
6992         general_symbol_info.
6993         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
6994         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
6995         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
6996         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
6997         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
6998         (MSYMBOL_SEARCH_NAME): Update.
6999         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
7000         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
7001         * minsyms.c (minimal_symbol_reader::record_full): Update.
7002
7003 2019-03-15  Tom Tromey  <tom@tromey.com>
7004
7005         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
7006
7007 2019-03-15  Tom Tromey  <tom@tromey.com>
7008
7009         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
7010         unique_xmalloc_ptr.
7011         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
7012         Update.
7013         * minsyms.c (lookup_minimal_symbol_by_pc_section)
7014         (build_minimal_symbol_hash_tables)
7015         (minimal_symbol_reader::install): Update.
7016
7017 2019-03-15  Tom Tromey  <tom@tromey.com>
7018
7019         * symtab.c (create_demangled_names_hash): Update.
7020         (symbol_set_names): Update.
7021         * objfiles.h (struct objfile_per_bfd_storage)
7022         <demangled_names_hash>: Now an htab_up.
7023         * objfiles.c (objfile_per_bfd_storage): Simplify.
7024
7025 2019-03-15  Tom Tromey  <tom@tromey.com>
7026
7027         * objfiles.h (struct objfile_per_bfd_storage): Declare
7028         destructor.
7029         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
7030         New.
7031         (get_objfile_bfd_data): Use new.  Don't initialize
7032         language_of_main.
7033         (free_objfile_per_bfd_storage): Remove.
7034         (objfile_bfd_data_free, objfile::~objfile): Use delete.
7035
7036 2019-03-15  Tom Tromey  <tom@tromey.com>
7037
7038         * symfile.c (reread_symbols): Update.
7039         * objfiles.c (objfile::objfile): Update.
7040         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
7041         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
7042         comment.
7043         (minimal_symbol_reader::install): Update.
7044         (terminate_minimal_symbol_table): Remove.
7045         * jit.c (jit_object_close_impl): Update.
7046
7047 2019-03-15  Tom Tromey  <tom@tromey.com>
7048
7049         * minsyms.c (minimal_symbol_reader::record_full): Remove some
7050         initializations.
7051
7052 2019-03-15  Tom Tromey  <tom@tromey.com>
7053
7054         * objfiles.h (struct objfile_per_bfd_storage)
7055         <demangled_hash_languages>: Now a bitset.
7056         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
7057         (lookup_minimal_symbol): Update.
7058
7059 2019-03-15  Tom Tromey  <tom@tromey.com>
7060
7061         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
7062         Don't return the symbol.
7063         * coffread.c (record_minimal_symbol): Use record_full.
7064
7065 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
7066
7067         The MS-Windows port of ncurses fails to switch to a color pair if
7068         one or both of the colors are the implicit default colors.  This
7069         change records the default colors when TUI is initialized, and
7070         then specifies them explicitly when a color pair uses the default
7071         colors.  This allows color styling in TUI mode on MS-Windows.
7072
7073         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
7074         ncurses_norm_attr.
7075         (tui_initialize_io) [__MINGW32__]: Record the default terminal
7076         colors in ncurses_norm_attr.
7077         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
7078         "none", replace it with the default color recorded in
7079         ncurses_norm_attr.
7080
7081 2019-03-14  Tom Tromey  <tromey@adacore.com>
7082
7083         * source-cache.h (class source_cache) <get_source_lines>: Return
7084         std::string.
7085         * source-cache.c (source_cache::extract_lines): Handle case where
7086         first_pos==npos.  Return std::string.
7087         (source_cache::get_source_lines): Update.
7088
7089 2019-03-14  Tom Tromey  <tromey@adacore.com>
7090
7091         * NEWS: Add item for "style sources" commands.
7092         * source-cache.c (source_cache::get_source_lines): Check
7093         source_styling.
7094         * cli/cli-style.c (source_styling): New global.
7095         (_initialize_cli_style): Add "style sources" commands.
7096         (show_style_sources): New function.
7097         * cli/cli-style.h (source_styling): Declare.
7098
7099 2019-03-14  Pedro Alves  <palves@redhat.com>
7100             Tom Tromey  <tromey@adacore.com>
7101
7102         * tui/tui-winsource.h (tui_refill_source_window): Declare.
7103         * tui/tui-winsource.c (tui_refill_source_window): New function,
7104         from...
7105         (tui_horizontal_source_scroll): ... here.  Move some logic.
7106         * cli/cli-style.c (set_style_enabled): Notify new observable.
7107         * tui/tui-hooks.c (tui_redisplay_source): New function.
7108         (tui_attach_detach_observers): Attach or detach
7109         tui_redisplay_source.
7110         * observable.h (source_styling_changed): New observable.
7111         * observable.c: Define source_styling_changed observable.
7112
7113 2019-03-13  Tom Tromey  <tromey@adacore.com>
7114
7115         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
7116         (i386_gnu_nat_target::store_registers): Update.
7117         * target-debug.h (target_debug_print_std_string): New macro.
7118         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
7119         * windows-tdep.c (display_one_tib): Update.
7120         * tui/tui-stack.c (tui_make_status_line): Update.
7121         * top.c (print_inferior_quit_action): Update.
7122         * thread.c (thr_try_catch_cmd): Update.
7123         (add_thread_with_info): Update.
7124         (thread_target_id_str): Update.
7125         (thr_try_catch_cmd): Update.
7126         (thread_command): Update.
7127         (thread_find_command): Update.
7128         * record-btrace.c (record_btrace_target::info_record)
7129         (record_btrace_resume_thread, record_btrace_target::resume)
7130         (record_btrace_cancel_resume, record_btrace_step_thread)
7131         (record_btrace_target::wait, record_btrace_target::wait)
7132         (record_btrace_target::wait, record_btrace_target::stop): Update.
7133         * progspace.c (print_program_space): Update.
7134         * process-stratum-target.c
7135         (process_stratum_target::thread_address_space): Update.
7136         * linux-fork.c (linux_fork_mourn_inferior)
7137         (detach_checkpoint_command, info_checkpoints_command)
7138         (linux_fork_context): Update.
7139         (linux_fork_detach): Update.
7140         (class scoped_switch_fork_info): Update.
7141         (delete_checkpoint_command): Update.
7142         * infrun.c (follow_fork_inferior): Update.
7143         (follow_fork_inferior): Update.
7144         (proceed_after_vfork_done): Update.
7145         (handle_vfork_child_exec_or_exit): Update.
7146         (follow_exec): Update.
7147         (displaced_step_prepare_throw): Update.
7148         (displaced_step_restore): Update.
7149         (start_step_over): Update.
7150         (resume_1): Update.
7151         (clear_proceed_status_thread): Update.
7152         (proceed): Update.
7153         (print_target_wait_results): Update.
7154         (do_target_wait): Update.
7155         (context_switch): Update.
7156         (stop_all_threads): Update.
7157         (restart_threads): Update.
7158         (finish_step_over): Update.
7159         (handle_signal_stop): Update.
7160         (switch_back_to_stepped_thread): Update.
7161         (keep_going_pass_signal): Update.
7162         (print_exited_reason): Update.
7163         (normal_stop): Update.
7164         * inferior.c (inferior_pid_to_str): Change return type.
7165         (print_selected_inferior): Update.
7166         (add_inferior): Update.
7167         (detach_inferior): Update.
7168         * dummy-frame.c (fprint_dummy_frames): Update.
7169         * dcache.c (dcache_info_1): Update.
7170         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
7171         (btrace_fetch, btrace_clear): Update.
7172         * linux-tdep.c (linux_core_pid_to_str): Change return type.
7173         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
7174         type.
7175         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
7176         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
7177         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
7178         * gdbarch.c, gdbarch.h: Rebuild.
7179         * gdbarch.sh (core_pid_to_str): Change return type.
7180         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
7181         return type.
7182         (windows_nat_target::pid_to_str): Change return type.
7183         (windows_delete_thread): Update.
7184         (windows_nat_target::attach): Update.
7185         (windows_nat_target::files_info): Update.
7186         * target-delegates.c: Rebuild.
7187         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
7188         return type.
7189         (sol_thread_target::pid_to_str): Change return type.
7190         * remote.c (class remote_target) <pid_to_str>: Change return
7191         type.
7192         (remote_target::pid_to_str): Change return type.
7193         (extended_remote_target::attach, remote_target::remote_stop_ns)
7194         (remote_target::remote_notif_remove_queued_reply)
7195         (remote_target::push_stop_reply, remote_target::disable_btrace):
7196         Update.
7197         (extended_remote_target::attach): Update.
7198         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
7199         type.
7200         (gdbsim_target::pid_to_str): Change return type.
7201         * ravenscar-thread.c (struct ravenscar_thread_target)
7202         <pid_to_str>: Change return type.
7203         (ravenscar_thread_target::pid_to_str): Change return type.
7204         * procfs.c (class procfs_target) <pid_to_str>: Change return
7205         type.
7206         (procfs_target::pid_to_str): Change return type.
7207         (procfs_target::attach): Update.
7208         (procfs_target::detach): Update.
7209         (procfs_target::fetch_registers): Update.
7210         (procfs_target::store_registers): Update.
7211         (procfs_target::wait): Update.
7212         (procfs_target::files_info): Update.
7213         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
7214         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
7215         return type.
7216         (nto_procfs_target::pid_to_str): Change return type.
7217         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
7218         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
7219         return type.
7220         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
7221         (exit_lwp): Update.
7222         (attach_proc_task_lwp_callback, get_detach_signal)
7223         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
7224         (linux_nat_target::resume, wait_lwp, stop_callback)
7225         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
7226         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
7227         (linux_nat_wait_1, resume_stopped_resumed_lwps)
7228         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
7229         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
7230         type.
7231         (inf_ptrace_target::attach): Update.
7232         (inf_ptrace_target::files_info): Update.
7233         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
7234         type.
7235         (go32_nat_target::pid_to_str): Change return type.
7236         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
7237         (gnu_nat_target::wait): Update.
7238         (gnu_nat_target::wait): Update.
7239         (gnu_nat_target::resume): Update.
7240         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
7241         (fbsd_nat_target::wait): Update.
7242         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
7243         type.
7244         (darwin_nat_target::attach): Update.
7245         * corelow.c (class core_target) <pid_to_str>: Change return type.
7246         (core_target::pid_to_str): Change return type.
7247         * target.c (normal_pid_to_str): Change return type.
7248         (default_pid_to_str): Likewise.
7249         (target_pid_to_str): Change return type.
7250         (target_translate_tls_address): Update.
7251         (target_announce_detach): Update.
7252         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
7253         return type.
7254         (bsd_uthread_target::pid_to_str): Change return type.
7255         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
7256         type.
7257         (bsd_kvm_target::pid_to_str): Change return type.
7258         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
7259         return type.
7260         (aix_thread_target::pid_to_str): Change return type.
7261         * target.h (struct target_ops) <pid_to_str>: Change return type.
7262         (target_pid_to_str, normal_pid_to_str): Likewise.
7263         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
7264         type.
7265         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
7266         type.
7267         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
7268         return type.
7269         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
7270         type.
7271         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
7272         type.
7273         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
7274         return type.
7275
7276 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
7277
7278         * NEWS: Mention that the new default MI version is 3.  Mention
7279         changes to the output of commands and events that deal with
7280         multi-location breakpoints.
7281         * breakpoint.c: Include "mi/mi-out.h".
7282         (print_one_breakpoint): Change output syntax if using MI version
7283         >= 3.
7284         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
7285         New.
7286         (mi_multi_location_breakpoint_output_fixed): New.
7287         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
7288         (mi_cmd_fix_multi_location_breakpoint_output): New.
7289         (mi_multi_location_breakpoint_output_fixed): New.
7290         * mi/mi-cmds.c (mi_cmds): Register command
7291         -fix-multi-location-breakpoint-output.
7292         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
7293         interpreter "mi".
7294
7295 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
7296
7297         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
7298         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
7299         instantiate mi_ui_out based on interpreter name.
7300         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
7301         * mi/mi-main.c (mi_load_progress): Likewise.
7302
7303 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7304
7305         * NEWS: Combine separate "New targets" sections for 8.3.
7306
7307 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7308
7309         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
7310         (ppcfbsd_init_abi): Install gdbarch
7311         "fetch_tls_load_module_address" and "get_thread_local_address"
7312         methods.
7313
7314 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7315
7316         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
7317         (riscv_fbsd_init_abi): Install gdbarch
7318         "fetch_tls_load_module_address" and "get_thread_local_address"
7319         methods.
7320
7321 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7322
7323         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
7324         (i386fbsd_init_abi): Install gdbarch
7325         "fetch_tls_load_module_address" and "get_thread_local_address"
7326         methods.
7327
7328 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7329
7330         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
7331         (amd64fbsd_init_abi): Install gdbarch
7332         "fetch_tls_load_module_address" and "get_thread_local_address"
7333         methods.
7334
7335 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7336
7337         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
7338         (struct fbsd_pspace_data): New type.
7339         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
7340         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
7341         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
7342         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
7343         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
7344
7345 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7346
7347         * gdbtypes.c (lookup_struct_elt): New function.
7348         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
7349         * gdbtypes.h (struct struct_elt): New type.
7350         (lookup_struct_elt): New prototype.
7351
7352 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7353
7354         * gdbtypes.c (lookup_struct_elt_type): Update comment and
7355         remove disabled code block.
7356
7357 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7358
7359         * gdbarch.sh (get_thread_local_address): New method.
7360         * gdbarch.h, gdbarch.c: Regenerate.
7361         * target.c (target_translate_tls_address): Use
7362         gdbarch_get_thread_local_address if present instead of
7363         target::get_thread_local_address.
7364
7365 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7366
7367         * target.h (target::get_thread_local_address): Update comment.
7368
7369 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7370
7371         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
7372         objfile->separate_debug_objfile_backlink if not NULL.
7373
7374 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7375
7376         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
7377         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
7378         (amd64bsd_store_inferior_registers): Likewise.
7379         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
7380         Enable segment base registers.
7381         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
7382         PT_GETFSBASE and PT_GETGSBASE.
7383         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
7384         PT_SETGSBASE.
7385         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
7386         segment base registers.
7387         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
7388
7389 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7390
7391         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
7392         Update calls to i386_target_description to add 'segments'
7393         parameter.
7394         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
7395         add segment base registers.
7396         * arch/i386.c (i386_create_target_description): Add 'segments'
7397         parameter to enable segment base registers.
7398         * arch/i386.h (i386_create_target_description): Likewise.
7399         * features/i386/32bit-segments.xml: New file.
7400         * features/i386/32bit-segments.c: Generate.
7401         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
7402         call to i386_target_description to add 'segments' parameter.
7403         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
7404         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
7405         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
7406         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
7407         if feature is present.
7408         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
7409         Add 'segments' parameter to call to i386_target_description.
7410         (i386_target_description): Add 'segments' parameter to enable
7411         segment base registers.
7412         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
7413         to call to i386_target_description.
7414         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
7415         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
7416         Define I386_NUM_REGS.
7417         (i386_target_description): Add 'segments' parameter to enable
7418         segment base registers.
7419
7420 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
7421
7422         PR/24325
7423         * source-cache.c: #undef open and close, to avoid unresolved
7424         externals during linking.
7425
7426 2019-03-12  Tom Tromey  <tromey@adacore.com>
7427
7428         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
7429         const.  Add initializers.
7430         (_initialize_remote): Don't initialize ptid globals.
7431
7432 2019-03-12  Pedro Alves  <palves@redhat.com>
7433
7434         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
7435
7436 2019-03-12  Pedro Alves  <palves@redhat.com>
7437
7438         * cp-name-parser.y (main): Remove unused 'len' variable.
7439
7440 2019-03-12  Tom Tromey  <tromey@adacore.com>
7441
7442         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
7443         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
7444
7445 2019-03-12  Tom Tromey  <tromey@adacore.com>
7446
7447         * linux-nat.c (iterate_over_lwps): Update.
7448         (stop_callback): Remove parameter.
7449         (stop_wait_callback, detach_callback, resume_set_callback)
7450         (select_singlestep_lwp_callback, set_ignore_sigint)
7451         (status_callback, resumed_callback, resume_clear_callback)
7452         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
7453         data parameter.
7454         (linux_nat_target::detach, linux_nat_target::resume)
7455         (linux_stop_and_wait_all_lwps, select_event_lwp)
7456         (linux_nat_filter_event, linux_nat_wait_1)
7457         (linux_nat_target::kill, linux_nat_target::stop)
7458         (linux_nat_target::stop): Update.
7459         (linux_nat_resume_callback): Change type.
7460         (resume_stopped_resumed_lwps, count_events_callback)
7461         (select_event_lwp_callback): Likewise.
7462         (linux_stop_lwp, linux_nat_stop_lwp): Update.
7463         * arm-linux-nat.c (struct update_registers_data): Remove.
7464         (update_registers_callback): Change type.
7465         (arm_linux_insert_hw_breakpoint1): Update.
7466         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
7467         parameter.
7468         (x86_linux_dr_set_addr): Update.
7469         (x86_linux_dr_set_control): Update.
7470         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
7471         (iterate_over_lwps): Use gdb::function_view.
7472         * nat/aarch64-linux-hw-point.c (struct
7473         aarch64_dr_update_callback_param): Remove.
7474         (debug_reg_change_callback): Change type.
7475         (aarch64_notify_debug_reg_change): Update.
7476         * s390-linux-nat.c (s390_refresh_per_info): Update.
7477
7478 2019-03-11  Tom Tromey  <tromey@adacore.com>
7479
7480         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
7481         redundant assignment to "this_cu".
7482
7483 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7484
7485         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
7486
7487 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7488
7489         * gdbtypes.c (rank_one_type_parm_set): New function extracted
7490         from...
7491         (rank_one_type): ... this.
7492
7493 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7494
7495         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
7496         from...
7497         (rank_one_type): ... this.
7498
7499 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7500
7501         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
7502         from...
7503         (rank_one_type): ... this.
7504
7505 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7506
7507         * gdbtypes.c (rank_one_type_parm_float): New function extracted
7508         from...
7509         (rank_one_type): ... this.
7510
7511 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7512
7513         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
7514         from...
7515         (rank_one_type): ... this.
7516
7517 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7518
7519         * gdbtypes.c (rank_one_type_parm_range): New function extracted
7520         from...
7521         (rank_one_type): ... this.
7522
7523 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7524
7525         * gdbtypes.c (rank_one_type_parm_char): New function extracted
7526         from...
7527         (rank_one_type): ... this.
7528
7529 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7530
7531         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
7532         from...
7533         (rank_one_type): ... this.
7534
7535 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7536
7537         * gdbtypes.c (rank_one_type_parm_int): New function extracted
7538         from...
7539         (rank_one_type): ... this.
7540
7541 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7542
7543         * gdbtypes.c (rank_one_type_parm_func): New function extracted
7544         from...
7545         (rank_one_type): ... this.
7546
7547 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7548
7549         * gdbtypes.c (rank_one_type_parm_array): New function extracted
7550         from...
7551         (rank_one_type): ... this.
7552
7553 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7554
7555         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
7556         from...
7557         (rank_one_type): ... this.
7558
7559 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7560
7561         * inferior.c (initialize_inferiors): Ensure 'help set/show print
7562         inferior-events' shows the example events.
7563
7564 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
7565
7566         Support styling on native MS-Windows console
7567
7568         PR/24315
7569         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
7570         on MS-Windows if $TERM is not defined.
7571
7572         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
7573
7574         * posix-hdep.c (gdb_console_fputs):
7575         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
7576         functions.
7577         * ui-file.h (gdb_console_fputs): Add prototype.
7578
7579         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
7580         back to fputs only if the former returns zero.
7581
7582 2019-03-07  Tom Tromey  <tom@tromey.com>
7583
7584         * symmisc.c (print_symbol_bcache_statistics): Update.
7585         (print_objfile_statistics): Update.
7586         * symfile.c (allocate_symtab): Update.
7587         * stabsread.c: Don't include bcache.h.
7588         * psymtab.h (struct psymbol_bcache): Don't declare.
7589         (class psymtab_storage) <psymbol_cache>: Now a bcache.
7590         (psymbol_bcache_init, psymbol_bcache_free)
7591         (psymbol_bcache_get_bcache): Don't declare.
7592         * psymtab.c (struct psymbol_bcache): Remove.
7593         (psymtab_storage::psymtab_storage): Update.
7594         (psymtab_storage::~psymtab_storage): Update.
7595         (psymbol_bcache_init, psymbol_bcache_free)
7596         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
7597         (add_psymbol_to_bcache): Update.
7598         (allocate_psymtab): Update.
7599         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
7600         macro_cache>: No longer pointers.
7601         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
7602         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
7603         * macrotab.c (macro_bcache): Update.
7604         * macroexp.c: Don't include bcache.h.
7605         * gdbtypes.c (check_types_worklist): Update.
7606         (types_deeply_equal): Remove TRY/CATCH.  Update.
7607         * elfread.c (elf_symtab_read): Update.
7608         * dwarf2read.c: Don't include bcache.h.
7609         * buildsym.c (buildsym_compunit::get_macro_table): Update.
7610         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
7611         (print_bcache_statistics, bcache_memory_used): Don't declare.
7612         (struct bcache): Move from bcache.c.  Add constructor, destructor,
7613         methods.  Rename all data members.
7614         * bcache.c (struct bcache): Move to bcache.h.
7615         (bcache::expand_hash_table): Rename from expand_hash_table.
7616         (bcache): Remove.
7617         (bcache::insert): Rename from bcache_full.
7618         (bcache::compare): Rename from bcache_compare.
7619         (bcache_xmalloc): Remove.
7620         (bcache::~bcache): Rename from bcache_xfree.
7621         (bcache::print_statistics): Rename from print_bcache_statistics.
7622         (bcache::memory_used): Rename from bcache_memory_used.
7623
7624 2019-03-07  Pedro Alves  <palves@redhat.com>
7625
7626         * infrun.c (normal_stop): Also check for
7627         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
7628
7629 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
7630
7631         * f-lang.c (value_from_host_double): Moved to...
7632         * value.c (value_from_host_double): ...here.
7633         * value.h (value_from_host_double): Declare.
7634         * guile/scm-math.c (vlscm_convert_typed_number): Use
7635         value_from_host_double.
7636         (vlscm_convert_number): Likewise.
7637         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
7638         * python/py-value.c (convert_value_from_python): Likewise.
7639
7640 2019-03-06  Tom Tromey  <tom@tromey.com>
7641
7642         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
7643
7644 2019-03-06  Tom Tromey  <tom@tromey.com>
7645
7646         * utils.h (free_current_contents): Don't declare.
7647         * utils.c (free_current_contents): Remove.
7648
7649 2019-03-06  Tom Tromey  <tom@tromey.com>
7650
7651         * top.c (quit_force): Update.
7652         * main.c (captured_command_loop): Update.
7653         * common/new-op.c (operator new): Update.
7654         * common/common-exceptions.c (struct catcher)
7655         <save_cleanup_chain>: Remove member.
7656         (exceptions_state_mc_init): Update.
7657         (exception_try_scope_entry): Return nullptr.
7658         (exception_try_scope_exit, exception_rethrow)
7659         (throw_exception_sjlj, throw_exception_cxx): Update.
7660         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
7661         (all_cleanups, do_cleanups, discard_cleanups)
7662         (discard_final_cleanups, save_cleanups, save_final_cleanups)
7663         (restore_cleanups, restore_final_cleanups): Don't declare.
7664         (do_final_cleanups): Remove parameter.
7665         * common/cleanups.c (cleanup_chain, make_cleanup)
7666         (make_cleanup_dtor, all_cleanups, do_cleanups)
7667         (discard_my_cleanups, discard_cleanups)
7668         (discard_final_cleanups, save_my_cleanups, save_cleanups)
7669         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
7670         (null_cleanup): Remove.
7671         (do_final_cleanups): Remove parameter.
7672
7673 2019-03-06  Tom Tromey  <tom@tromey.com>
7674
7675         * remote.c (remote_target::remote_parse_stop_reply): Use
7676         unique_xmalloc_ptr.
7677
7678 2019-03-06  Tom Tromey  <tom@tromey.com>
7679
7680         * stabsread.c (struct stabs_field_info): Rename from field_info.
7681         <list, fnlist>: Add initializers.
7682         <obstack>: New member.
7683         (read_member_functions, read_struct_fields, read_baseclasses):
7684         Allocate on obstack.  Don't use cleanups.
7685         (read_one_struct_field, read_member_functions, read_struct_fields)
7686         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
7687         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
7688         (read_struct_type): Update.
7689
7690 2019-03-06  Tom Tromey  <tom@tromey.com>
7691
7692         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
7693         * common/filestuff.h (make_cleanup_close): Don't declare.
7694         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
7695         Remove.
7696
7697 2019-03-06  Tom Tromey  <tom@tromey.com>
7698
7699         * solib-aix.c: Use make_scope_exit.
7700
7701 2019-03-06  Tom Tromey  <tom@tromey.com>
7702
7703         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
7704         Use make_scope_exit.
7705
7706 2019-03-06  Tom Tromey  <tom@tromey.com>
7707
7708         * solib-svr4.c (disable_probes_interface): Remove parameter.
7709         (svr4_handle_solib_event): Use make_scope_exit.
7710
7711 2019-03-06  Tom Tromey  <tom@tromey.com>
7712
7713         * remote.c (struct stop_reply_deleter): Remove.
7714         (stop_reply_up): Update.
7715         (struct stop_reply): Derive from notif_event.  Don't typedef.
7716         <regcache>: Now a std::vector.
7717         (stop_reply_xfree): Remove.
7718         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
7719         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
7720         (remote_target::discard_pending_stop_replies): Use delete.
7721         (remote_target::remote_parse_stop_reply): Update.
7722         (remote_target::process_stop_reply): Update.
7723         * remote-notif.h (struct notif_event): Add virtual destructor.
7724         Remove "dtr" member.
7725         (struct notif_client) <alloc_event>: Return a unique_ptr.
7726         (notif_event_xfree): Don't declare.
7727         (notif_event_up): New typedef.
7728         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
7729         (notif_event_xfree, do_notif_event_xfree): Remove.
7730         (remote_notif_state_xfree): Update.
7731
7732 2019-03-06  Tom Tromey  <tom@tromey.com>
7733
7734         * infrun.c (displaced_step_clear_cleanup): Now a
7735         forward_scope_exit type.
7736         (displaced_step_prepare_throw): Update.
7737         (displaced_step_fixup): Update.
7738
7739 2019-03-06  Tom Tromey  <tom@tromey.com>
7740
7741         * inferior.h (class inferior): Update comment.
7742         * gdbthread.h (class thread_info): Update comment.
7743
7744 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
7745             Tom Tromey  <tom@tromey.com>
7746
7747         * stabsread.h (struct stab_section_list): Remove.
7748         (coffstab_build_psymtabs): Update.
7749         * dbxread.c (symbuf_sections): Now a std::vector.
7750         (sect_idx): New global.
7751         (fill_symbuf): Update.
7752         (coffstab_build_psymtabs): Change type of stabsects parameter.
7753         Update.
7754         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
7755         std::vector.
7756         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
7757         (coff_locate_sections): Update.
7758         (coff_symfile_read): Remove cleanups.  Update.
7759         (init_stringtab): Add storage parameter.
7760         (free_stringtab, free_stringtab_cleanup): Remove.
7761         (init_lineno): Add storage parameter.
7762         (free_linetab, free_linetab_cleanup): Remove.
7763
7764 2019-03-06  Pedro Alves  <palves@redhat.com>
7765
7766         * linux-fork.c (fork_info::clobber_regs): Delete.
7767         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
7768         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
7769         comment.  Adjust.
7770         (scoped_switch_fork_info::scoped_switch_fork_info)
7771         (checkpoint_command, linux_fork_context): Adjust
7772         fork_save_infrun_state calls.
7773
7774 2019-03-06  Pedro Alves  <palves@redhat.com>
7775
7776         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
7777         (inf_has_multiple_threads): Return 'bool' and rewrite using
7778         inferior_info::threads().
7779
7780 2019-03-06  Pedro Alves  <palves@redhat.com>
7781
7782         * linux-fork.c: Include <list>.
7783         (fork_list): Now a std::list instance.
7784         (fork_info): Add ctor, dtor, and in-class initialize all fields.
7785         (forks_exist_p, find_last_fork): Adjust.
7786         (new_fork): Delete.
7787         (one_fork_p): New.
7788         (add_fork): Adjust.
7789         (free_fork): Delete, folded into fork_info::~fork_info().
7790         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
7791         Adjust.
7792         (init_fork_list): Delete.
7793         (linux_fork_killall, linux_fork_mourn_inferior)
7794         (linux_fork_detach, info_checkpoints_command): Adjust.
7795         (_initialize_linux_fork): No longer call init_fork_list.
7796
7797 2019-03-06  Pedro Alves  <palves@redhat.com>
7798
7799         * linux-fork.c (new_fork): New, split out of ...
7800         (add_fork): ... this.  Return void.  Move "first fork" special
7801         case from here, to ...
7802         (checkpoint_command): ... here.
7803         * linux-linux.h (add_fork): Return void.
7804
7805 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7806
7807         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
7808
7809 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7810             Chris January  <chris.january@arm.com>
7811             David Lecomber  <david.lecomber@arm.com>
7812
7813         * f-exp.y: New token, UNOP_INTRINSIC.
7814         (exp): New pattern using UNOP_INTRINSIC token.
7815         (f77_keywords): Add 'abs' keyword.
7816         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
7817         (value_from_host_double): New function.
7818         (evaluate_subexp_f): Support UNOP_ABS.
7819
7820 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7821
7822         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
7823         types.
7824
7825 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7826
7827         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
7828         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
7829         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
7830
7831 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7832
7833         * f-exp.y (convert_to_kind_type): Handle more type kinds.
7834
7835 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7836             Chris January  <chris.january@arm.com>
7837
7838         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
7839         * f-exp.y: Define 'KIND' token.
7840         (exp): New pattern for KIND expressions.
7841         (ptype): Handle types with a kind extension.
7842         (direct_abs_decl): Extend to spot kind extensions.
7843         (f77_keywords): Add 'kind' to the list.
7844         (push_kind_type): New function.
7845         (convert_to_kind_type): New function.
7846         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
7847         * parse.c (operator_length_standard): Likewise.
7848         * parser-defs.h (enum type_pieces): Add tp_kind.
7849         * std-operator.def: Add UNOP_KIND.
7850
7851 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7852
7853         * f-exp.y (f_parse): Set yydebug.
7854
7855 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7856
7857         * f-lang.c (evaluate_subexp_f): New function.
7858         (exp_descriptor_f): New global.
7859         (f_language_defn): Use exp_descriptor_f instead of
7860         exp_descriptor_standard.
7861
7862 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7863
7864         * f-exp.y (struct token): Add comments.
7865         (dot_ops): Remove uppercase versions and the end marker.
7866         (f77_keywords): Likewise.
7867         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
7868         entries in the dot_ops array are case insensitive, and use
7869         strncasecmp to compare strings.  Also some whitespace cleanup in
7870         this area.  Similar for the f77_keywords array, except entries in
7871         this list might be case sensitive.
7872
7873 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7874
7875         * f-exp.y (struct f77_boolean_val): Add comments.
7876         (boolean_values): Remove uppercase versions, and end marker.
7877         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
7878         and use strncasecmp to achieve case insensitivity.  Additionally,
7879         perform whitespace cleanup around this code.
7880
7881 2019-03-06  Tom Tromey  <tromey@adacore.com>
7882
7883         * remote-sim.c (gdbsim_target_open): Use result of
7884         gdb_argv::release.
7885
7886 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
7887         Dirk Schubert  <dirk.schubert@arm.com>
7888         Chris January  <chris.january@arm.com>
7889
7890         * eval.c (evaluate_subexp_standard): Call Fortran argument
7891         wrapping logic.
7892         * f-lang.c (struct value): A value which can be passed into a
7893         Fortran function call.
7894         (fortran_argument_convert): Wrap Fortran arguments in a pointer
7895         where appropriate.
7896         (struct type): Value ready for a Fortran function call.
7897         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
7898         is needed.
7899         * f-lang.h (fortran_argument_convert): Declaration.
7900         (fortran_preserve_arg_pointer): Declaration.
7901         * infcall.c (value_arg_coerce): Call Fortran argument logic.
7902
7903 2019-03-05  Tom Tromey  <tromey@adacore.com>
7904
7905         * python/py-prettyprint.c (print_string_repr): Remove #if.
7906         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
7907
7908 2019-03-05  Tom Tromey  <tromey@adacore.com>
7909
7910         * target.c (the_dummy_target): Move later.  Change type to
7911         "dummy_target".
7912         (initialize_targets): Don't initialize the_dummy_target.
7913
7914 2019-03-05  Tom Tromey  <tromey@adacore.com>
7915
7916         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
7917         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
7918
7919 2019-03-05  Tom Tromey  <tromey@adacore.com>
7920
7921         * windows-nat.c (windows_nat_target::attach)
7922         (windows_nat_target::detach): Don't call gdb_flush.
7923         * valprint.c (generic_val_print, val_print, val_print_string):
7924         Don't call gdb_flush.
7925         * utils.c (defaulted_query): Don't call gdb_flush.
7926         * typeprint.c (print_type_scalar): Don't call gdb_flush.
7927         * target.c (target_announce_detach): Don't call gdb_flush.
7928         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
7929         * remote.c (extended_remote_target::attach): Don't call
7930         gdb_flush.
7931         * procfs.c (procfs_target::detach): Don't call gdb_flush.
7932         * printcmd.c (do_examine): Don't call gdb_flush.
7933         (info_display_command): Don't call gdb_flush.
7934         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
7935         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
7936         * memattr.c (info_mem_command): Don't call gdb_flush.
7937         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
7938         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
7939         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
7940         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
7941         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
7942         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
7943         (gnu_nat_target::detach): Don't call gdb_flush.
7944         * f-valprint.c (f_val_print): Don't call gdb_flush.
7945         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
7946         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
7947         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
7948         gdb_flush.
7949         * c-valprint.c (c_val_print): Don't call gdb_flush.
7950         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
7951
7952 2019-03-05  Tom Tromey  <tromey@adacore.com>
7953
7954         * varobj.c (update_dynamic_varobj_children): Update.
7955         (install_default_visualizer): Use reset, not release.
7956         * value.c (set_internalvar): Update.
7957         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
7958         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
7959         ATTRIBUTE_UNUSED_RESULT.
7960
7961 2019-03-05  Tom Tromey  <tromey@adacore.com>
7962
7963         * remote.c (class scoped_remote_fd) <release>: Add
7964         ATTRIBUTE_UNUSED_RESULT.
7965
7966 2019-03-05  Tom Tromey  <tromey@adacore.com>
7967
7968         * macroexp.c (struct macro_buffer) <release>: Add
7969         ATTRIBUTE_UNUSED_RESULT.
7970
7971 2019-03-05  Tom Tromey  <tromey@adacore.com>
7972
7973         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
7974         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
7975         ATTRIBUTE_UNUSED_RESULT.
7976
7977 2019-03-05  Tom Tromey  <tromey@adacore.com>
7978
7979         * common/scoped_fd.h (class scoped_fd) <release>: Add
7980         ATTRIBUTE_UNUSED_RESULT.
7981
7982 2019-03-05  Tom Tromey  <tromey@adacore.com>
7983
7984         * parser-defs.h (struct parser_state) <release>: Add
7985         ATTRIBUTE_UNUSED_RESULT.
7986
7987 2019-03-05  Tom Tromey  <tromey@adacore.com>
7988
7989         * utils.h (class gdb_argv) <release>: Add
7990         ATTRIBUTE_UNUSED_RESULT.
7991         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
7992
7993 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
7994
7995         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
7996         for-loop range, to avoid compiler warnings.
7997
7998         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
7999         avoid compiler warnings about unused variables.
8000
8001         * NEWS: Mention end of support for native debugging on MS-Windows
8002         before XP.
8003
8004         PR gdb/24292
8005         * common/netstuff.c:
8006         * gdbserver/gdbreplay.c
8007         * gdbserver/remote-utils.c:
8008         * ser-tcp.c:
8009         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
8010         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
8011         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
8012         'getaddrinfo' and 'freeaddrinfo' were not available before
8013         Windows XP, and mingw.org's MinGW headers by default define
8014         _WIN32_WINNT to 0x500.
8015
8016 2019-03-01  Gary Benson <gbenson@redhat.com>
8017
8018         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
8019
8020 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
8021             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
8022
8023         PR gdb/8527
8024         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
8025         set_sigint_trap, clear_sigint_trap.
8026
8027 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8028
8029         * target.c (target_detach): Clear the regcache and the
8030         frame cache.
8031
8032 2019-02-27  Pedro Alves  <palves@redhat.com>
8033
8034         * utils.c (set_screen_size): When we cap the height/width sizes,
8035         tweak the corresponding command variable to show "unlimited":
8036
8037 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
8038             Pedro Alves  <palves@redhat.com>
8039
8040         * utils.c (set_screen_size): Reduce "infinite" rows and columns
8041         before calling rl_set_screen_size.
8042
8043 2019-02-27  Tom Tromey  <tromey@adacore.com>
8044
8045         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
8046         define.
8047         * python/py-value.c: Remove Python 2.4 workaround.
8048         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
8049         workaround.
8050         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
8051         Python 2.4 workaround.
8052         * python/python-internal.h: Remove Python 2.4 comment.
8053         (Py_ssize_t): Don't define.
8054         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
8055         (gdb_Py_DECREF): Remove Python 2.4 workaround.
8056         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
8057         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
8058         * python/python.c (do_start_initialization): Remove Python 2.4
8059         workaround.
8060         * python/py-prettyprint.c (class dummy_python_frame): Remove.
8061         (print_children): Remove Python 2.4 workaround.
8062         * python/py-inferior.c (buffer_procs): Remove Python 2.4
8063         workaround.
8064         (CHARBUFFERPROC_NAME): Remove.
8065         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
8066         Python 2.4 workaround.
8067
8068 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
8069
8070         * NEWS: Note minimum Python version.
8071
8072 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
8073
8074         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
8075         code from these functions.  Remove corresponding ifdefs.  Use
8076         Py_buffer_up instead of explicit calls to PyBuffer_Release.
8077         Remove gotos and target of gotos.
8078         (infpy_search_memory): Likewise.
8079
8080 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8081
8082         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
8083         (hppa_gdbarch_init): Don't register deleted functions with
8084         gdbarch.
8085
8086 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8087
8088         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
8089         (h8300_unwind_sp): Delete.
8090         (h8300_dummy_id): Delete.
8091         (h8300_gdbarch_init): Don't register deleted functions with
8092         gdbarch.
8093
8094 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8095
8096         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
8097         (ft32_unwind_pc): Delete.
8098         (ft32_unwind_sp): Delete.
8099         (ft32_gdbarch_init): Don't register deleted functions with
8100         gdbarch.
8101
8102 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8103
8104         * gdb/frv-tdep.c (frv_dummy_id): Delete.
8105         (frv_unwind_pc): Delete.
8106         (frv_unwind_sp): Delete.
8107         (frv_gdbarch_init): Don't register deleted functions with
8108         gdbarch.
8109
8110 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8111
8112         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
8113         (riscv_unwind_pc): Delete.
8114         (riscv_unwind_sp): Delete.
8115         (riscv_gdbarch_init): Don't register deleted functions with
8116         gdbarch.
8117
8118 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8119
8120         * gdb/csky-tdep.c (csky_dummy_id): Delete.
8121         (csky_unwind_pc): Delete.
8122         (csky_unwind_sp): Delete.
8123         (csky_gdbarch_init): Don't register deleted functions with
8124         gdbarch.
8125
8126 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8127
8128         * gdb/cris-tdep.c (cris_dummy_id): Delete.
8129         (cris_unwind_pc): Delete.
8130         (cris_unwind_sp): Delete.
8131         (cris_gdbarch_init): Don't register deleted functions with
8132         gdbarch.
8133
8134 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8135
8136         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
8137         (bfin_unwind_pc): Delete.
8138         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
8139
8140 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8141
8142         * gdb/arm-tdep.c (arm_dummy_id): Delete.
8143         (arm_unwind_pc): Delete.
8144         (arm_unwind_sp): Delete.
8145         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
8146
8147 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8148
8149         * gdb/arc-tdep.c (arc_dummy_id): Delete.
8150         (arc_unwind_pc): Delete.
8151         (arc_unwind_sp): Delete.
8152         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
8153
8154 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8155
8156         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
8157         (alpha_unwind_pc): Delete.
8158         (alpha_gdbarch_init): Don't register deleted functions with
8159         gdbarch.
8160
8161 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8162
8163         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
8164         (aarch64_unwind_pc): Delete.
8165         (aarch64_unwind_sp): Delete.
8166         (aarch64_gdbarch_init): Don't register deleted functions with
8167         gdbarch.
8168
8169 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8170
8171         * gdbtypes.c (type_align): Don't consider static members when
8172         computing structure alignment.
8173
8174 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8175
8176         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
8177         return 0 for other types.
8178         * arch-utils.c (default_type_align): Always return 0.
8179         * gdbarch.h: Regenerate.
8180         * gdbarch.sh (type_align): Extend comment.
8181         * gdbtypes.c (type_align): Add additional comments, always call
8182         gdbarch_type_align before applying the default rules.
8183         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
8184         generic code will then apply a suitable default.
8185         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
8186         types, return 0 for other types.
8187
8188 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
8189
8190         * NEWS: Create a new section for the next release branch.
8191         Rename the section of the current branch, now that it has
8192         been cut.
8193
8194 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
8195
8196         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
8197         * version.in: Bump version to 8.3.50.DATE-git.
8198
8199 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
8200
8201         * aix-thread.c (ptid_cmp): Remove unused variable.
8202         (get_signaled_thread): Likewise.
8203         (store_regs_user_thread): Likewise.
8204         (store_regs_kernel_thread): Likewise.
8205         (fetch_regs_kernel_thread): Remove shadowed variable.
8206
8207 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
8208
8209         * features/riscv/32bit-cpu.xml: Add register numbers.
8210         * features/riscv/32bit-fpu.c: Regenerate.
8211         * features/riscv/32bit-fpu.xml: Add register numbers.
8212         * features/riscv/64bit-cpu.xml: Add register numbers.
8213         * features/riscv/64bit-fpu.c: Regenerate.
8214         * features/riscv/64bit-fpu.xml: Add register numbers.
8215
8216 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
8217
8218         * NEWS: Mention two argument form of gdb.Value constructor.
8219         * python/py-value.c (convert_buffer_and_type_to_value): New
8220         function.
8221         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
8222         Add support for handling an optional second argument.  Call
8223         convert_buffer_and_type_to_value as appropriate.
8224         * python/python-internal.h (Py_buffer_deleter): New struct.
8225         (Py_buffer_up): New typedef.
8226
8227 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
8228
8229         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
8230         instead of releasing ownership.
8231
8232 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
8233
8234         * dwarf2read.c (open_and_init_dwp_file): Call
8235         elf_numsections instead of bfd_count_sections to initialize
8236         dwp_file->num_sections.
8237
8238 2019-02-25  Tom Tromey  <tromey@adacore.com>
8239
8240         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
8241
8242 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
8243
8244         * gcore.in: Add '--readnever' option when invoking GDB.
8245
8246 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
8247
8248         * MAINTAINERS: Update my email address.
8249
8250 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
8251
8252         * build-id.c (build_id_to_debug_bfd_1): New function.
8253         (build_id_to_debug_bfd): Look for separate debug file in
8254         sysroot.
8255
8256 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
8257
8258         * gdbarch.sh: Update the copyright year range that is placed into
8259         generated files.
8260
8261 2019-02-22  Keith Seitz  <keiths@redhat.com>
8262
8263         PR symtab/23853
8264         * linespec.c (create_sals_line_offset): Search for the default
8265         symtab's filename instead of its fullname.
8266
8267 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
8268
8269         * NEWS: Update style defaults.
8270
8271 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
8272
8273         * main.c (captured_main_1): Disable styling in batch mode.
8274
8275 2019-02-20  Tom Tromey  <tom@tromey.com>
8276
8277         * symtab.c (symtab_symbol_info): Fix typos.
8278
8279 2019-02-20  Tom Tromey  <tromey@adacore.com>
8280
8281         * findcmd.c (_initialize_mem_search): Use upper case for
8282         metasyntactic variables.
8283
8284 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
8285
8286         * aarch64-tdep.c (aarch64_add_reggroups): New function.
8287         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
8288
8289 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
8290
8291         * top.h (source_file_name): Change to std::string.
8292         * top.c (source_file_name): Likewise.
8293         (command_line_input): Adjust.
8294         * cli/cli-script.c (script_from_file): Adjust.
8295
8296 2019-02-19  Tom Tromey  <tromey@adacore.com>
8297
8298         * ravenscar-thread.c
8299         (ravenscar_thread_target::update_thread_list): Don't call
8300         ada_build_task_list.
8301         * ada-lang.h (ada_build_task_list): Don't declare.
8302         * ada-tasks.c (struct ada_tasks_inferior_data)
8303         <task_list_valid_p>: Now bool.
8304         (read_known_tasks, ada_task_list_changed)
8305         (ada_tasks_invalidate_inferior_data): Update.
8306         (read_known_tasks_array): Return bool.
8307         (read_known_tasks_list): Likewise.
8308         (read_known_tasks): Return void.
8309         (ada_build_task_list): Now static.
8310
8311 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
8312
8313         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
8314         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
8315
8316 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8317
8318         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
8319         variant for ada_tasks_pspace_data_handle and
8320         ada_tasks_inferior_data_handle.
8321         (ada_tasks_pspace_data_cleanup): New function.
8322         (ada_tasks_inferior_data_cleanup): New function.
8323
8324 2019-02-17  Tom Tromey  <tom@tromey.com>
8325
8326         * macrotab.h (macro_source_fullname): Return a std::string.
8327         * macrotab.c (macro_include, check_for_redefinition)
8328         (macro_undef, macro_lookup_definition, foreach_macro)
8329         (foreach_macro_in_scope): Update.
8330         (macro_source_fullname): Return a std::string.
8331         * macrocmd.c (show_pp_source_pos): Update.
8332
8333 2019-02-17  Tom Tromey  <tom@tromey.com>
8334
8335         * macrocmd.c (show_pp_source_pos): Style the file names.
8336
8337 2019-02-17  Tom Tromey  <tom@tromey.com>
8338
8339         PR tui/24197:
8340         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
8341
8342 2019-02-17  Tom Tromey  <tom@tromey.com>
8343
8344         * ada-lang.c (user_select_syms): Use filtered printing.
8345         * utils.c (wrap_style): New global.
8346         (desired_style): Remove.
8347         (emit_style_escape): Add stream parameter.
8348         (set_output_style, reset_terminal_style, prompt_for_continue):
8349         Update.
8350         (flush_wrap_buffer): Only flush gdb_stdout.
8351         (wrap_here): Set wrap_style.
8352         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
8353         treat escape sequences as a character.  Change when wrap buffer is
8354         flushed.
8355         (fputs_styled): Do not set the output style when the default is
8356         requested.
8357         * ui-style.h (struct ui_file_style) <is_default>: New method.
8358         * source.c (print_source_lines_base): Emit escape sequences in one
8359         piece.
8360
8361 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
8362
8363         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
8364         integers and enumeration types.
8365
8366 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
8367
8368         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
8369         instead of lookup_symbol_in_language
8370         (do_exact_match): New function.
8371         (ada_get_symbol_name_matcher): Return do_exact_match when
8372         doing a verbatim match.
8373
8374 2019-02-15  Tom Tromey  <tromey@adacore.com>
8375
8376         * ravenscar-thread.c (ravenscar_thread_target::resume)
8377         (ravenscar_thread_target::wait): Special case wildcard requests.
8378
8379 2019-02-15  Tom Tromey  <tromey@adacore.com>
8380
8381         * ravenscar-thread.c (base_ptid): Remove.
8382         (struct ravenscar_thread_target) <close>: New method.
8383         <m_base_ptid>: New member.
8384         <update_inferior_ptid, active_task, task_is_currently_active,
8385         runtime_initialized>: Declare methods.
8386         <ravenscar_thread_target>: Add constructor.
8387         (ravenscar_thread_target::task_is_currently_active)
8388         (ravenscar_thread_target::update_inferior_ptid)
8389         (ravenscar_runtime_initialized): Rename.  Now methods.
8390         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
8391         (ravenscar_thread_target::update_thread_list): Update.
8392         (ravenscar_thread_target::active_task): Now method.
8393         (ravenscar_thread_target::store_registers)
8394         (ravenscar_thread_target::prepare_to_store)
8395         (ravenscar_thread_target::prepare_to_store)
8396         (ravenscar_thread_target::mourn_inferior): Update.
8397         (ravenscar_inferior_created): Use "new" to create target.
8398         (ravenscar_thread_target::get_ada_task_ptid): Update.
8399         (_initialize_ravenscar): Don't initialize base_ptid.
8400         (ravenscar_ops): Remove global.
8401
8402 2019-02-15  Tom Tromey  <tromey@adacore.com>
8403
8404         * target.h (push_target): Declare new overload.
8405         * target.c (push_target): New overload, taking an rvalue reference.
8406         * remote.c (remote_target::open_1): Use push_target overload.
8407         * corelow.c (core_target_open): Use push_target overload.
8408
8409 2019-02-15  Tom Tromey  <tromey@adacore.com>
8410
8411         * ravenscar-thread.c (is_ravenscar_task)
8412         (ravenscar_task_is_currently_active): Return bool.
8413         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
8414         (_initialize_ravenscar): Remove "(void)".
8415         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
8416         Return bool.
8417
8418 2019-02-15  Tom Tromey  <tromey@adacore.com>
8419
8420         * ravenscar-thread.c (ravenscar_runtime_initializer)
8421         (has_ravenscar_runtime, get_running_thread_id)
8422         (ravenscar_thread_target::resume): Fix indentation.
8423
8424 2019-02-15  Tom Tromey  <tromey@adacore.com>
8425
8426         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
8427         from ravenscar_arch_ops.
8428         (sparc_ravenscar_ops::fetch_registers)
8429         (sparc_ravenscar_ops::store_registers): Now methods.
8430         (sparc_ravenscar_prepare_to_store): Remove.
8431         (sparc_ravenscar_ops): Redefine.
8432         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
8433         methods and destructor.  Remove members.
8434         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
8435         (ravenscar_thread_target::store_registers)
8436         (ravenscar_thread_target::prepare_to_store): Update.
8437         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
8438         Remove.
8439         (struct ppc_ravenscar_powerpc_ops): Derive from
8440         ravenscar_arch_ops.
8441         (ppc_ravenscar_powerpc_ops::fetch_registers)
8442         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
8443         (ppc_ravenscar_powerpc_ops): Redefine.
8444         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
8445         (ppc_ravenscar_e500_ops::fetch_registers)
8446         (ppc_ravenscar_e500_ops::store_registers): Now methods.
8447         (ppc_ravenscar_e500_ops): Redefine.
8448         * aarch64-ravenscar-thread.c
8449         (aarch64_ravenscar_generic_prepare_to_store): Remove.
8450         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
8451         (aarch64_ravenscar_fetch_registers)
8452         (aarch64_ravenscar_store_registers): Now methods.
8453         (aarch64_ravenscar_ops): Redefine.
8454
8455 2019-02-15  Tom Tromey  <tromey@adacore.com>
8456
8457         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
8458         (ravenscar_thread_target::stopped_by_hw_breakpoint)
8459         (ravenscar_thread_target::stopped_by_watchpoint)
8460         (ravenscar_thread_target::stopped_data_address)
8461         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
8462
8463 2019-02-15  Tom Tromey  <tromey@adacore.com>
8464
8465         * ravenscar-thread.c: Fix some typos.
8466
8467 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8468             Tom Tromey  <tromey@adacore.com>
8469
8470         * ada-lang.c (ada_exception_sal): Change addr_string to a
8471         std::string.
8472         (create_ada_exception_catchpoint): Update.
8473
8474 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8475             Tom Tromey  <tromey@adacore.com>
8476
8477         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
8478         (bp_location_ops): Remove.
8479         (base_breakpoint_allocate_location): Update.
8480         (free_bp_location): Update.
8481         * ada-lang.c (class ada_catchpoint_location)
8482         <ada_catchpoint_location>: Remove ops parameter.
8483         (ada_catchpoint_location_dtor): Remove.
8484         (ada_catchpoint_location_ops): Remove.
8485         (allocate_location_exception): Update.
8486         * breakpoint.h (struct bp_location_ops): Remove.
8487         (class bp_location) <bp_location>: Remove bp_location_ops
8488         parameter.
8489         <~bp_location>: Add destructor.
8490         <ops>: Remove.
8491
8492 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
8493             Pedro Alves  <palves@redhat.com>
8494
8495         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
8496         'PATH_MAX'.
8497
8498 2019-02-14  David Michael  <fedora.dm0@gmail.com>
8499             Samuel Thibault  <samuel.thibault@gnu.org>
8500             Thomas Schwinge  <thomas@codesourcery.com>
8501
8502         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
8503         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
8504
8505 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
8506
8507         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
8508         (check_empty): Use "const char *".
8509
8510         * gnu-nat.c (gnu_nat_target::detach): Instead of
8511         'detach_inferior (pid)' call
8512         'detach_inferior (find_inferior_pid (pid))'.
8513
8514         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
8515         'nat/fork-inferior.o'.
8516         * gnu-nat.c: #include "nat/fork-inferior.h".
8517
8518         * gnu-nat.c (gnu_nat_target::detach): Instead of
8519         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
8520         * gnu-nat.h: #include "inf-child.h".
8521         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
8522         'i386_gnu_nat_target::fetch_registers'.
8523         (gnu_store_registers): Rename/move to
8524         'i386_gnu_nat_target::store_registers'.
8525
8526         * config/i386/nm-i386gnu.h: Don't "#include" any files.
8527         * gnu-nat.h (mach_thread_info): New function.
8528         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
8529
8530         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
8531
8532 2019-02-14  Frederic Konrad  <konrad@adacore.com>
8533
8534         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
8535
8536 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
8537
8538         * windows-nat.c (windows_add_thread): Add new parameter
8539         "main_thread_p" with default value set to false.  Update
8540         function documentation as well as all callers.
8541         (windows_delete_thread): Likewise.
8542         (fake_create_process): Update call to windows_add_thread.
8543         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
8544         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
8545         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
8546         call to windows_delete_thread.
8547
8548 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
8549
8550         * MAINTAINERS: Add Andrew Burgess as global maintainer.
8551
8552 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8553
8554         * symfile.c (find_separate_debug_file): Use canonical path of
8555         sysroot with child_path instead of gdb_sysroot if it is valid.
8556
8557 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8558
8559         * symfile.c (find_separate_debug_file): Use child_path to
8560         determine if an object file is under a sysroot.
8561
8562 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8563
8564         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
8565         unittests/child-path-selftests.c.
8566         * common/pathstuff.c (child_path): New function.
8567         * common/pathstuff.h (child_path): New prototype.
8568         * unittests/child-path-selftests.c: New file.
8569
8570 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8571
8572         * symfile.c (find_separate_debug_file): Look for separate debug
8573         files in debug directories under the sysroot.
8574
8575 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8576
8577         * symtab.h (struct minimal_symbol data_p): New const method.
8578         (struct minimal_symbol text_p): Likewise.
8579         * symtab.c (output_source_filename): Use file name style
8580         to print file name.
8581         (print_symbol_info): Likewise.
8582         (print_msymbol_info): Use address style to print addresses.
8583         Use function name style to print executable text symbols.
8584         (expand_symtab_containing_pc): Use data_p.
8585         (find_pc_sect_compunit_symtab): Likewise.
8586
8587 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8588
8589         * breakpoint.c (describe_other_breakpoints): Use address style
8590         to print addresses.
8591         (say_where): Likewise.
8592
8593 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8594
8595         * ada-typeprint.c (print_func_type): Print function name
8596         style to print function name.
8597         * c-typeprint.c (c_print_type_1): Likewise.
8598
8599 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
8600
8601         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
8602         for execve.
8603
8604 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8605
8606         * c-exp.y (direct_abs_decl): Use emplace_back to record the
8607         type_stack.
8608
8609 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
8610
8611         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
8612         TYPE_CODE_REF types.
8613
8614 2019-02-08  Jim Wilson  <jimw@sifive.com>
8615
8616         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
8617         (riscv_linux_fregset): New.
8618         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
8619
8620 2019-02-07  Tom Tromey  <tom@tromey.com>
8621
8622         * thread.c (thread_cancel_execution_command): Update.
8623         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
8624         methods.
8625         (struct thread_fsm_ops): Remove.
8626         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
8627         (thread_fsm_should_stop, thread_fsm_return_value)
8628         (thread_fsm_set_finished, thread_fsm_finished_p)
8629         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
8630         Don't declare.
8631         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
8632         * infrun.c (clear_proceed_status_thread)
8633         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
8634         (print_stop_event): Update.
8635         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
8636         Add constructor.
8637         (step_command_fsm_ops): Remove.
8638         (new_step_command_fsm): Remove.
8639         (step_1): Update.
8640         (step_command_fsm::should_stop): Rename from
8641         step_command_fsm_should_stop.
8642         (step_command_fsm::clean_up): Rename from
8643         step_command_fsm_clean_up.
8644         (step_command_fsm::do_async_reply_reason): Rename from
8645         step_command_fsm_async_reply_reason.
8646         (struct until_next_fsm): Inherit from thread_fsm.  Add
8647         constructor.
8648         (until_next_fsm_ops): Remove.
8649         (new_until_next_fsm): Remove.
8650         (until_next_fsm::should_stop): Rename from
8651         until_next_fsm_should_stop.
8652         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
8653         (until_next_fsm::do_async_reply_reason): Rename from
8654         until_next_fsm_async_reply_reason.
8655         (struct finish_command_fsm): Inherit from thread_fsm.  Add
8656         constructor.  Change type of breakpoint.
8657         (finish_command_fsm_ops): Remove.
8658         (new_finish_command_fsm): Remove.
8659         (finish_command_fsm::should_stop): Rename from
8660         finish_command_fsm_should_stop.
8661         (finish_command_fsm::clean_up): Rename from
8662         finish_command_fsm_clean_up.
8663         (finish_command_fsm::return_value): Rename from
8664         finish_command_fsm_return_value.
8665         (finish_command_fsm::do_async_reply_reason): Rename from
8666         finish_command_fsm_async_reply_reason.
8667         (finish_command): Update.
8668         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
8669         Add constructor.
8670         (call_thread_fsm_ops): Remove.
8671         (call_thread_fsm::call_thread_fsm): Rename from
8672         new_call_thread_fsm.
8673         (call_thread_fsm::should_stop): Rename from
8674         call_thread_fsm_should_stop.
8675         (call_thread_fsm::should_notify_stop): Rename from
8676         call_thread_fsm_should_notify_stop.
8677         (run_inferior_call, call_function_by_hand_dummy): Update.
8678         * cli/cli-interp.c (should_print_stop_to_console): Update.
8679         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
8680         Add constructor.  Change type of location_breakpoint,
8681         caller_breakpoint.
8682         (until_break_fsm_ops): Remove.
8683         (new_until_break_fsm): Remove.
8684         (until_break_fsm::should_stop): Rename from
8685         until_break_fsm_should_stop.
8686         (until_break_fsm::clean_up): Rename from
8687         until_break_fsm_clean_up.
8688         (until_break_fsm::do_async_reply_reason): Rename from
8689         until_break_fsm_async_reply_reason.
8690         (until_break_command): Update.
8691         * thread-fsm.c: Remove.
8692         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
8693
8694 2019-02-07  Tom Tromey  <tom@tromey.com>
8695
8696         * yy-remap.h: Add include guard.
8697         * xtensa-tdep.h: Add include guard.
8698         * xcoffread.h: Rename include guard.
8699         * varobj-iter.h: Add include guard.
8700         * tui/tui.h: Rename include guard.
8701         * tui/tui-winsource.h: Rename include guard.
8702         * tui/tui-wingeneral.h: Rename include guard.
8703         * tui/tui-windata.h: Rename include guard.
8704         * tui/tui-win.h: Rename include guard.
8705         * tui/tui-stack.h: Rename include guard.
8706         * tui/tui-source.h: Rename include guard.
8707         * tui/tui-regs.h: Rename include guard.
8708         * tui/tui-out.h: Rename include guard.
8709         * tui/tui-layout.h: Rename include guard.
8710         * tui/tui-io.h: Rename include guard.
8711         * tui/tui-hooks.h: Rename include guard.
8712         * tui/tui-file.h: Rename include guard.
8713         * tui/tui-disasm.h: Rename include guard.
8714         * tui/tui-data.h: Rename include guard.
8715         * tui/tui-command.h: Rename include guard.
8716         * tic6x-tdep.h: Add include guard.
8717         * target/waitstatus.h: Rename include guard.
8718         * target/wait.h: Rename include guard.
8719         * target/target.h: Rename include guard.
8720         * target/resume.h: Rename include guard.
8721         * target-float.h: Rename include guard.
8722         * stabsread.h: Add include guard.
8723         * rs6000-tdep.h: Add include guard.
8724         * riscv-fbsd-tdep.h: Add include guard.
8725         * regformats/regdef.h: Rename include guard.
8726         * record.h: Rename include guard.
8727         * python/python.h: Rename include guard.
8728         * python/python-internal.h: Rename include guard.
8729         * python/py-stopevent.h: Rename include guard.
8730         * python/py-ref.h: Rename include guard.
8731         * python/py-record.h: Rename include guard.
8732         * python/py-record-full.h: Rename include guard.
8733         * python/py-record-btrace.h: Rename include guard.
8734         * python/py-instruction.h: Rename include guard.
8735         * python/py-events.h: Rename include guard.
8736         * python/py-event.h: Rename include guard.
8737         * procfs.h: Add include guard.
8738         * proc-utils.h: Add include guard.
8739         * p-lang.h: Add include guard.
8740         * or1k-tdep.h: Rename include guard.
8741         * observable.h: Rename include guard.
8742         * nto-tdep.h: Rename include guard.
8743         * nat/x86-linux.h: Rename include guard.
8744         * nat/x86-linux-dregs.h: Rename include guard.
8745         * nat/x86-gcc-cpuid.h: Add include guard.
8746         * nat/x86-dregs.h: Rename include guard.
8747         * nat/x86-cpuid.h: Rename include guard.
8748         * nat/ppc-linux.h: Rename include guard.
8749         * nat/mips-linux-watch.h: Rename include guard.
8750         * nat/linux-waitpid.h: Rename include guard.
8751         * nat/linux-ptrace.h: Rename include guard.
8752         * nat/linux-procfs.h: Rename include guard.
8753         * nat/linux-osdata.h: Rename include guard.
8754         * nat/linux-nat.h: Rename include guard.
8755         * nat/linux-namespaces.h: Rename include guard.
8756         * nat/linux-btrace.h: Rename include guard.
8757         * nat/glibc_thread_db.h: Rename include guard.
8758         * nat/gdb_thread_db.h: Rename include guard.
8759         * nat/gdb_ptrace.h: Rename include guard.
8760         * nat/fork-inferior.h: Rename include guard.
8761         * nat/amd64-linux-siginfo.h: Rename include guard.
8762         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
8763         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
8764         * nat/aarch64-linux.h: Rename include guard.
8765         * nat/aarch64-linux-hw-point.h: Rename include guard.
8766         * mn10300-tdep.h: Add include guard.
8767         * mips-linux-tdep.h: Add include guard.
8768         * mi/mi-parse.h: Rename include guard.
8769         * mi/mi-out.h: Rename include guard.
8770         * mi/mi-main.h: Rename include guard.
8771         * mi/mi-interp.h: Rename include guard.
8772         * mi/mi-getopt.h: Rename include guard.
8773         * mi/mi-console.h: Rename include guard.
8774         * mi/mi-common.h: Rename include guard.
8775         * mi/mi-cmds.h: Rename include guard.
8776         * mi/mi-cmd-break.h: Rename include guard.
8777         * m2-lang.h: Add include guard.
8778         * location.h: Rename include guard.
8779         * linux-record.h: Rename include guard.
8780         * linux-nat.h: Add include guard.
8781         * linux-fork.h: Add include guard.
8782         * i386-darwin-tdep.h: Rename include guard.
8783         * hppa-linux-offsets.h: Add include guard.
8784         * guile/guile.h: Rename include guard.
8785         * guile/guile-internal.h: Rename include guard.
8786         * gnu-nat.h: Rename include guard.
8787         * gdb-stabs.h: Rename include guard.
8788         * frv-tdep.h: Add include guard.
8789         * f-lang.h: Add include guard.
8790         * event-loop.h: Add include guard.
8791         * darwin-nat.h: Rename include guard.
8792         * cp-abi.h: Rename include guard.
8793         * config/sparc/nm-sol2.h: Rename include guard.
8794         * config/nm-nto.h: Rename include guard.
8795         * config/nm-linux.h: Add include guard.
8796         * config/i386/nm-i386gnu.h: Rename include guard.
8797         * config/djgpp/nl_types.h: Rename include guard.
8798         * config/djgpp/langinfo.h: Rename include guard.
8799         * compile/gcc-cp-plugin.h: Add include guard.
8800         * compile/gcc-c-plugin.h: Add include guard.
8801         * compile/compile.h: Rename include guard.
8802         * compile/compile-object-run.h: Rename include guard.
8803         * compile/compile-object-load.h: Rename include guard.
8804         * compile/compile-internal.h: Rename include guard.
8805         * compile/compile-cplus.h: Rename include guard.
8806         * compile/compile-c.h: Rename include guard.
8807         * common/xml-utils.h: Rename include guard.
8808         * common/x86-xstate.h: Rename include guard.
8809         * common/version.h: Rename include guard.
8810         * common/vec.h: Rename include guard.
8811         * common/tdesc.h: Rename include guard.
8812         * common/selftest.h: Rename include guard.
8813         * common/scoped_restore.h: Rename include guard.
8814         * common/scoped_mmap.h: Rename include guard.
8815         * common/scoped_fd.h: Rename include guard.
8816         * common/safe-iterator.h: Rename include guard.
8817         * common/run-time-clock.h: Rename include guard.
8818         * common/refcounted-object.h: Rename include guard.
8819         * common/queue.h: Rename include guard.
8820         * common/ptid.h: Rename include guard.
8821         * common/print-utils.h: Rename include guard.
8822         * common/preprocessor.h: Rename include guard.
8823         * common/pathstuff.h: Rename include guard.
8824         * common/observable.h: Rename include guard.
8825         * common/netstuff.h: Rename include guard.
8826         * common/job-control.h: Rename include guard.
8827         * common/host-defs.h: Rename include guard.
8828         * common/gdb_wait.h: Rename include guard.
8829         * common/gdb_vecs.h: Rename include guard.
8830         * common/gdb_unlinker.h: Rename include guard.
8831         * common/gdb_unique_ptr.h: Rename include guard.
8832         * common/gdb_tilde_expand.h: Rename include guard.
8833         * common/gdb_sys_time.h: Rename include guard.
8834         * common/gdb_string_view.h: Rename include guard.
8835         * common/gdb_splay_tree.h: Rename include guard.
8836         * common/gdb_setjmp.h: Rename include guard.
8837         * common/gdb_ref_ptr.h: Rename include guard.
8838         * common/gdb_optional.h: Rename include guard.
8839         * common/gdb_locale.h: Rename include guard.
8840         * common/gdb_assert.h: Rename include guard.
8841         * common/filtered-iterator.h: Rename include guard.
8842         * common/filestuff.h: Rename include guard.
8843         * common/fileio.h: Rename include guard.
8844         * common/environ.h: Rename include guard.
8845         * common/common-utils.h: Rename include guard.
8846         * common/common-types.h: Rename include guard.
8847         * common/common-regcache.h: Rename include guard.
8848         * common/common-inferior.h: Rename include guard.
8849         * common/common-gdbthread.h: Rename include guard.
8850         * common/common-exceptions.h: Rename include guard.
8851         * common/common-defs.h: Rename include guard.
8852         * common/common-debug.h: Rename include guard.
8853         * common/cleanups.h: Rename include guard.
8854         * common/buffer.h: Rename include guard.
8855         * common/btrace-common.h: Rename include guard.
8856         * common/break-common.h: Rename include guard.
8857         * cli/cli-utils.h: Rename include guard.
8858         * cli/cli-style.h: Rename include guard.
8859         * cli/cli-setshow.h: Rename include guard.
8860         * cli/cli-script.h: Rename include guard.
8861         * cli/cli-interp.h: Rename include guard.
8862         * cli/cli-decode.h: Rename include guard.
8863         * cli/cli-cmds.h: Rename include guard.
8864         * charset-list.h: Add include guard.
8865         * buildsym-legacy.h: Rename include guard.
8866         * bfin-tdep.h: Add include guard.
8867         * ax.h: Rename include guard.
8868         * arm-linux-tdep.h: Add include guard.
8869         * arm-fbsd-tdep.h: Add include guard.
8870         * arch/xtensa.h: Rename include guard.
8871         * arch/tic6x.h: Add include guard.
8872         * arch/i386.h: Add include guard.
8873         * arch/arm.h: Rename include guard.
8874         * arch/arm-linux.h: Rename include guard.
8875         * arch/arm-get-next-pcs.h: Rename include guard.
8876         * arch/amd64.h: Add include guard.
8877         * arch/aarch64-insn.h: Rename include guard.
8878         * arch-utils.h: Rename include guard.
8879         * annotate.h: Add include guard.
8880         * amd64-darwin-tdep.h: Rename include guard.
8881         * aarch64-linux-tdep.h: Add include guard.
8882         * aarch64-fbsd-tdep.h: Add include guard.
8883         * aarch32-linux-nat.h: Add include guard.
8884
8885 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8886
8887         * macrotab.c (macro_define_internal): New function that
8888         factorizes macro_define_object_internal and macro_define_function
8889         code.
8890         (macro_define_object_internal): Use macro_define_internal.
8891         (macro_define_function): Likewise.
8892
8893 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8894
8895         * macrocmd.c (extract_identifier): Return
8896         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
8897         callers.
8898
8899 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
8900
8901         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
8902
8903 2019-02-05  Tom Tromey  <tom@tromey.com>
8904
8905         * target.c (target_stack::unpush): Move assertion earlier.
8906
8907 2019-01-30  Tom Tromey  <tom@tromey.com>
8908
8909         PR python/23615:
8910         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
8911         (gdbpy_parse_and_eval): Likewise.
8912         * python/python-internal.h (gdbpy_allow_threads): New class.
8913
8914 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
8915
8916         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
8917         (aarch64_fbsd_fpregmap): Move earlier.
8918         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
8919         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
8920         instead of individual calls to trad_frame_set_reg_addr.
8921         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
8922         earlier.
8923         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
8924         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
8925         instead of individual calls to trad_frame_set_reg_addr.
8926
8927 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
8928
8929         * CONTRIBUTE: Replace contribution list with wiki link.
8930
8931 2019-01-25  Tom Tromey  <tom@tromey.com>
8932
8933         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
8934
8935 2019-01-25  Tom Tromey  <tom@tromey.com>
8936
8937         * xtensa-linux-nat.c: Fix common/ includes.
8938         * xml-support.h: Fix common/ includes.
8939         * xml-support.c: Fix common/ includes.
8940         * x86-linux-nat.c: Fix common/ includes.
8941         * windows-nat.c: Fix common/ includes.
8942         * varobj.h: Fix common/ includes.
8943         * varobj.c: Fix common/ includes.
8944         * value.c: Fix common/ includes.
8945         * valops.c: Fix common/ includes.
8946         * utils.c: Fix common/ includes.
8947         * unittests/xml-utils-selftests.c: Fix common/ includes.
8948         * unittests/utils-selftests.c: Fix common/ includes.
8949         * unittests/unpack-selftests.c: Fix common/ includes.
8950         * unittests/tracepoint-selftests.c: Fix common/ includes.
8951         * unittests/style-selftests.c: Fix common/ includes.
8952         * unittests/string_view-selftests.c: Fix common/ includes.
8953         * unittests/scoped_restore-selftests.c: Fix common/ includes.
8954         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
8955         * unittests/scoped_fd-selftests.c: Fix common/ includes.
8956         * unittests/rsp-low-selftests.c: Fix common/ includes.
8957         * unittests/parse-connection-spec-selftests.c: Fix common/
8958         includes.
8959         * unittests/optional-selftests.c: Fix common/ includes.
8960         * unittests/offset-type-selftests.c: Fix common/ includes.
8961         * unittests/observable-selftests.c: Fix common/ includes.
8962         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
8963         * unittests/memrange-selftests.c: Fix common/ includes.
8964         * unittests/memory-map-selftests.c: Fix common/ includes.
8965         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
8966         * unittests/function-view-selftests.c: Fix common/ includes.
8967         * unittests/environ-selftests.c: Fix common/ includes.
8968         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
8969         * unittests/common-utils-selftests.c: Fix common/ includes.
8970         * unittests/cli-utils-selftests.c: Fix common/ includes.
8971         * unittests/array-view-selftests.c: Fix common/ includes.
8972         * ui-file.c: Fix common/ includes.
8973         * tui/tui-io.c: Fix common/ includes.
8974         * tracepoint.h: Fix common/ includes.
8975         * tracepoint.c: Fix common/ includes.
8976         * tracefile-tfile.c: Fix common/ includes.
8977         * top.h: Fix common/ includes.
8978         * top.c: Fix common/ includes.
8979         * thread.c: Fix common/ includes.
8980         * target/waitstatus.h: Fix common/ includes.
8981         * target/waitstatus.c: Fix common/ includes.
8982         * target.h: Fix common/ includes.
8983         * target.c: Fix common/ includes.
8984         * target-memory.c: Fix common/ includes.
8985         * target-descriptions.c: Fix common/ includes.
8986         * symtab.h: Fix common/ includes.
8987         * symfile.c: Fix common/ includes.
8988         * stap-probe.c: Fix common/ includes.
8989         * spu-linux-nat.c: Fix common/ includes.
8990         * sparc-nat.c: Fix common/ includes.
8991         * source.c: Fix common/ includes.
8992         * solib.c: Fix common/ includes.
8993         * solib-target.c: Fix common/ includes.
8994         * ser-unix.c: Fix common/ includes.
8995         * ser-tcp.c: Fix common/ includes.
8996         * ser-pipe.c: Fix common/ includes.
8997         * ser-base.c: Fix common/ includes.
8998         * selftest-arch.c: Fix common/ includes.
8999         * s12z-tdep.c: Fix common/ includes.
9000         * rust-exp.y: Fix common/ includes.
9001         * rs6000-aix-tdep.c: Fix common/ includes.
9002         * riscv-tdep.c: Fix common/ includes.
9003         * remote.c: Fix common/ includes.
9004         * remote-notif.h: Fix common/ includes.
9005         * remote-fileio.h: Fix common/ includes.
9006         * remote-fileio.c: Fix common/ includes.
9007         * regcache.h: Fix common/ includes.
9008         * regcache.c: Fix common/ includes.
9009         * record-btrace.c: Fix common/ includes.
9010         * python/python.c: Fix common/ includes.
9011         * python/py-type.c: Fix common/ includes.
9012         * python/py-inferior.c: Fix common/ includes.
9013         * progspace.h: Fix common/ includes.
9014         * producer.c: Fix common/ includes.
9015         * procfs.c: Fix common/ includes.
9016         * proc-api.c: Fix common/ includes.
9017         * printcmd.c: Fix common/ includes.
9018         * ppc-linux-nat.c: Fix common/ includes.
9019         * parser-defs.h: Fix common/ includes.
9020         * osdata.c: Fix common/ includes.
9021         * obsd-nat.c: Fix common/ includes.
9022         * nat/x86-linux.c: Fix common/ includes.
9023         * nat/x86-linux-dregs.c: Fix common/ includes.
9024         * nat/x86-dregs.h: Fix common/ includes.
9025         * nat/x86-dregs.c: Fix common/ includes.
9026         * nat/ppc-linux.c: Fix common/ includes.
9027         * nat/mips-linux-watch.h: Fix common/ includes.
9028         * nat/mips-linux-watch.c: Fix common/ includes.
9029         * nat/linux-waitpid.c: Fix common/ includes.
9030         * nat/linux-ptrace.h: Fix common/ includes.
9031         * nat/linux-ptrace.c: Fix common/ includes.
9032         * nat/linux-procfs.c: Fix common/ includes.
9033         * nat/linux-personality.c: Fix common/ includes.
9034         * nat/linux-osdata.c: Fix common/ includes.
9035         * nat/linux-namespaces.c: Fix common/ includes.
9036         * nat/linux-btrace.h: Fix common/ includes.
9037         * nat/linux-btrace.c: Fix common/ includes.
9038         * nat/fork-inferior.c: Fix common/ includes.
9039         * nat/amd64-linux-siginfo.c: Fix common/ includes.
9040         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
9041         * nat/aarch64-linux.c: Fix common/ includes.
9042         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
9043         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
9044         * namespace.h: Fix common/ includes.
9045         * mips-linux-tdep.c: Fix common/ includes.
9046         * minsyms.c: Fix common/ includes.
9047         * mi/mi-parse.h: Fix common/ includes.
9048         * mi/mi-main.c: Fix common/ includes.
9049         * mi/mi-cmd-env.c: Fix common/ includes.
9050         * memrange.h: Fix common/ includes.
9051         * memattr.c: Fix common/ includes.
9052         * maint.h: Fix common/ includes.
9053         * maint.c: Fix common/ includes.
9054         * main.c: Fix common/ includes.
9055         * machoread.c: Fix common/ includes.
9056         * location.c: Fix common/ includes.
9057         * linux-thread-db.c: Fix common/ includes.
9058         * linux-nat.c: Fix common/ includes.
9059         * linux-fork.c: Fix common/ includes.
9060         * inline-frame.c: Fix common/ includes.
9061         * infrun.c: Fix common/ includes.
9062         * inflow.c: Fix common/ includes.
9063         * inferior.h: Fix common/ includes.
9064         * inferior.c: Fix common/ includes.
9065         * infcmd.c: Fix common/ includes.
9066         * inf-ptrace.c: Fix common/ includes.
9067         * inf-child.c: Fix common/ includes.
9068         * ia64-linux-nat.c: Fix common/ includes.
9069         * i387-tdep.c: Fix common/ includes.
9070         * i386-tdep.c: Fix common/ includes.
9071         * i386-linux-tdep.c: Fix common/ includes.
9072         * i386-linux-nat.c: Fix common/ includes.
9073         * i386-go32-tdep.c: Fix common/ includes.
9074         * i386-fbsd-tdep.c: Fix common/ includes.
9075         * i386-fbsd-nat.c: Fix common/ includes.
9076         * guile/scm-type.c: Fix common/ includes.
9077         * guile/guile.c: Fix common/ includes.
9078         * go32-nat.c: Fix common/ includes.
9079         * gnu-nat.c: Fix common/ includes.
9080         * gdbthread.h: Fix common/ includes.
9081         * gdbarch-selftests.c: Fix common/ includes.
9082         * gdb_usleep.c: Fix common/ includes.
9083         * gdb_select.h: Fix common/ includes.
9084         * gdb_bfd.c: Fix common/ includes.
9085         * gcore.c: Fix common/ includes.
9086         * fork-child.c: Fix common/ includes.
9087         * findvar.c: Fix common/ includes.
9088         * fbsd-nat.c: Fix common/ includes.
9089         * event-top.c: Fix common/ includes.
9090         * event-loop.c: Fix common/ includes.
9091         * dwarf2read.c: Fix common/ includes.
9092         * dwarf2loc.c: Fix common/ includes.
9093         * dwarf2-frame.c: Fix common/ includes.
9094         * dwarf-index-cache.c: Fix common/ includes.
9095         * dtrace-probe.c: Fix common/ includes.
9096         * disasm-selftests.c: Fix common/ includes.
9097         * defs.h: Fix common/ includes.
9098         * csky-tdep.c: Fix common/ includes.
9099         * cp-valprint.c: Fix common/ includes.
9100         * cp-support.h: Fix common/ includes.
9101         * cp-support.c: Fix common/ includes.
9102         * corelow.c: Fix common/ includes.
9103         * completer.h: Fix common/ includes.
9104         * completer.c: Fix common/ includes.
9105         * compile/compile.c: Fix common/ includes.
9106         * compile/compile-loc2c.c: Fix common/ includes.
9107         * compile/compile-cplus-types.c: Fix common/ includes.
9108         * compile/compile-cplus-symbols.c: Fix common/ includes.
9109         * command.h: Fix common/ includes.
9110         * cli/cli-dump.c: Fix common/ includes.
9111         * cli/cli-cmds.c: Fix common/ includes.
9112         * charset.c: Fix common/ includes.
9113         * build-id.c: Fix common/ includes.
9114         * btrace.h: Fix common/ includes.
9115         * btrace.c: Fix common/ includes.
9116         * breakpoint.h: Fix common/ includes.
9117         * breakpoint.c: Fix common/ includes.
9118         * ax.h:
9119         (enum agent_op): Fix common/ includes.
9120         * ax-general.c (struct aop_map): Fix common/ includes.
9121         * ax-gdb.c: Fix common/ includes.
9122         * auxv.c: Fix common/ includes.
9123         * auto-load.c: Fix common/ includes.
9124         * arm-tdep.c: Fix common/ includes.
9125         * arch/riscv.c: Fix common/ includes.
9126         * arch/ppc-linux-common.c: Fix common/ includes.
9127         * arch/i386.c: Fix common/ includes.
9128         * arch/arm.c: Fix common/ includes.
9129         * arch/arm-linux.c: Fix common/ includes.
9130         * arch/arm-get-next-pcs.c: Fix common/ includes.
9131         * arch/amd64.c: Fix common/ includes.
9132         * arch/aarch64.c: Fix common/ includes.
9133         * arch/aarch64-insn.c: Fix common/ includes.
9134         * arch-utils.c: Fix common/ includes.
9135         * amd64-windows-tdep.c: Fix common/ includes.
9136         * amd64-tdep.c: Fix common/ includes.
9137         * amd64-sol2-tdep.c: Fix common/ includes.
9138         * amd64-obsd-tdep.c: Fix common/ includes.
9139         * amd64-nbsd-tdep.c: Fix common/ includes.
9140         * amd64-linux-tdep.c: Fix common/ includes.
9141         * amd64-linux-nat.c: Fix common/ includes.
9142         * amd64-fbsd-tdep.c: Fix common/ includes.
9143         * amd64-fbsd-nat.c: Fix common/ includes.
9144         * amd64-dicos-tdep.c: Fix common/ includes.
9145         * amd64-darwin-tdep.c: Fix common/ includes.
9146         * agent.c: Fix common/ includes.
9147         * ada-lang.h: Fix common/ includes.
9148         * ada-lang.c: Fix common/ includes.
9149         * aarch64-tdep.c: Fix common/ includes.
9150
9151 2019-01-25  Tom Tromey  <tom@tromey.com>
9152
9153         * common/create-version.sh: Use common/version.h.
9154
9155 2019-01-24  Pedro Alves  <palves@redhat.com>
9156
9157         * infrun.c (signal_stop, signal_print, signal_program)
9158         (signal_catch, signal_pass): Now arrays instead of pointers.
9159         (update_signals_program_target, do_target_resume)
9160         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
9161         * linux-nat.c (linux_nat_target::pass_signals)
9162         (linux_nat_target::create_inferior, linux_nat_target::attach):
9163         Adjust.
9164         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
9165         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
9166         * procfs.c (procfs_target::pass_signals): Adjust.
9167         * record-full.c (record_full_target::resume): Adjust.
9168         * remote.c (remote_target::pass_signals)
9169         (remote_target::program_signals): Adjust.
9170         * target-debug.h (target_debug_print_signals): Now takes a
9171         gdb::array_view as parameter.  Adjust.
9172         * target.h (target_ops) <pass_signals, program_signals>: Replace
9173         pointer and length parameters with gdb::array_view.
9174         (target_pass_signals, target_program_signals): Likewise.
9175         * target-delegates.c: Regenerate.
9176
9177 2019-01-24  Pedro Alves  <palves@redhat.com>
9178
9179         * common/forward-scope-exit.h
9180         (forward_scope_exit::forward_scope_exit): Pass arguments to
9181         m_bind_function directly, instead of creating a std::bind and
9182         copying that.
9183
9184 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
9185
9186         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
9187         for static members.
9188         (pass_in_v_vfp_candidate): Likewise.
9189
9190 2019-01-23  Tom Tromey  <tom@tromey.com>
9191             Pedro Alves  <palves@redhat.com>
9192
9193         * regcache.c (class regcache_invalidator): Remove.
9194         (regcache::raw_write): Use make_scope_exit.
9195
9196 2019-01-23  Tom Tromey  <tom@tromey.com>
9197
9198         * ui-out.h (class ui_out_emit_type): Update comment.
9199
9200 2019-01-23  Tom Tromey  <tom@tromey.com>
9201
9202         * infrun.c (fetch_inferior_event): Update comment.
9203
9204 2019-01-23  Tom Tromey  <tom@tromey.com>
9205             Pedro Alves  <palves@redhat.com>
9206
9207         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
9208         parameter.
9209         (fetch_inferior_event): Use SCOPE_EXIT.
9210
9211
9212 2019-01-23  Tom Tromey  <tom@tromey.com>
9213             Pedro Alves  <palves@redhat.com>
9214
9215         * infrun.c (disable_thread_events): Delete.
9216         (stop_all_threads): Use SCOPE_EXIT.
9217
9218 2019-01-23  Tom Tromey  <tom@tromey.com>
9219             Pedro Alves  <palves@redhat.com>
9220
9221         * symfile.c: Include forward-scope-exit.h.
9222         (clear_symtab_users_cleanup): Replace forward declaration with
9223         a FORWARD_SCOPE_EXIT.
9224         (syms_from_objfile_1): Use the forward_scope_exit and
9225         gdb::optional instead of cleanup_function.
9226         (reread_symbols): Use the forward_scope_exit instead of
9227         cleanup_function.
9228         (clear_symtab_users_cleanup): Remove function.
9229
9230 2019-01-23  Tom Tromey  <tom@tromey.com>
9231             Pedro Alves  <palves@redhat.com>
9232
9233         * linux-nat.c: Include scope-exit.h.
9234         (cleanup_target_stop): Remove.
9235         (linux_nat_target::static_tracepoint_markers_by_strid): Use
9236         SCOPE_EXIT.
9237
9238 2019-01-23  Tom Tromey  <tom@tromey.com>
9239             Pedro Alves  <palves@redhat.com>
9240
9241         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
9242         (call_function_by_hand_dummy): Use SCOPE_EXIT.
9243
9244 2019-01-23  Tom Tromey  <tom@tromey.com>
9245             Andrew Burgess  <andrew.burgess@embecosm.com>
9246             Pedro Alves  <palves@redhat.com>
9247
9248         * infrun.c (fetch_inferior_event): Use scope_exit.
9249         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
9250         * top.c (execute_command): Use scope_exit.
9251         * breakpoint.c (bpstat_do_actions): Use scope_exit.
9252         * utils.c (do_bpstat_clear_actions_cleanup)
9253         (make_bpstat_clear_actions_cleanup): Remove.
9254
9255 2019-01-23  Tom Tromey  <tom@tromey.com>
9256             Pedro Alves  <palves@redhat.com>
9257
9258         * infrun.c: Include "common/scope-exit.h"
9259         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
9260         (wait_for_inferior): Use SCOPE_EXIT.
9261         (fetch_inferior_event): Use scope_exit.
9262
9263 2019-01-23  Tom Tromey  <tom@tromey.com>
9264             Pedro Alves  <palves@redhat.com>
9265
9266         * breakpoint.c (create_breakpoint): Remove cleanup.
9267
9268 2019-01-23  Tom Tromey  <tom@tromey.com>
9269             Andrew Burgess  <andrew.burgess@embecosm.com>
9270             Pedro Alves  <palves@redhat.com>
9271
9272 2019-01-23  Pedro Alves  <palves@redhat.com>
9273
9274         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
9275
9276 2019-01-23  Pedro Alves  <palves@redhat.com>
9277             Andrew Burgess  <andrew.burgess@embecosm.com>
9278
9279         * gdbthread.h: Include "common/forward-scope-exit.h".
9280         (scoped_finish_thread_state): Redefine custom class in terms of
9281         forward_scope_exit.
9282
9283 2019-01-23  Pedro Alves  <palves@redhat.com>
9284             Andrew Burgess  <andrew.burgess@embecosm.com>
9285
9286         * common/forward-scope-exit.h: New file.
9287
9288 2019-01-23  Pedro Alves  <palves@redhat.com>
9289             Andrew Burgess  <andrew.burgess@embecosm.com>
9290             Tom Tromey  <tom@tromey.com>
9291
9292         * common/scope-exit.h: New file.
9293
9294 2019-01-23  Pedro Alves  <palves@redhat.com>
9295
9296         * common/preprocessor.h (ESC): Rename to ...
9297         (ESC_PARENS): ... this.
9298         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
9299         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
9300
9301 2019-01-23  Tom Tromey  <tom@tromey.com>
9302
9303         * language.h (class scoped_switch_to_sym_language_if_auto):
9304         Initialize m_lang in both cases.
9305
9306 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
9307
9308         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
9309         with XCNEW.
9310
9311 2019-01-22  Tom Tromey  <tom@tromey.com>
9312
9313         * corelow.c: Do not include sys/file.h.
9314
9315 2019-01-22  Tom Tromey  <tom@tromey.com>
9316
9317         * tui/tui-wingeneral.h: Include gdb_curses.h.
9318
9319 2019-01-22  Tom Tromey  <tom@tromey.com>
9320
9321         * source-cache.h (class source_cache) <get_source_lines,
9322         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
9323
9324 2019-01-22  Tom Tromey  <tom@tromey.com>
9325
9326         * remote-fileio.h (struct remote_target): Declare.
9327
9328 2019-01-22  Tom Tromey  <tom@tromey.com>
9329
9330         * python/py-arch.c: Do not include py-ref.h.
9331         * python/py-bpevent.c: Do not include py-ref.h.
9332         * python/py-cmd.c: Do not include py-ref.h.
9333         * python/py-continueevent.c: Do not include py-ref.h.
9334         * python/py-event.h: Do not include py-ref.h.
9335         * python/py-evtregistry.c: Do not include py-ref.h.
9336         * python/py-finishbreakpoint.c: Do not include py-ref.h.
9337         * python/py-frame.c: Do not include py-ref.h.
9338         * python/py-framefilter.c: Do not include py-ref.h.
9339         * python/py-function.c: Do not include py-ref.h.
9340         * python/py-infevents.c: Do not include py-ref.h.
9341         * python/py-linetable.c: Do not include py-ref.h.
9342         * python/py-objfile.c: Do not include py-ref.h.
9343         * python/py-param.c: Do not include py-ref.h.
9344         * python/py-prettyprint.c: Do not include py-ref.h.
9345         * python/py-progspace.c: Do not include py-ref.h.
9346         * python/py-symbol.c: Do not include py-ref.h.
9347         * python/py-symtab.c: Do not include py-ref.h.
9348         * python/py-type.c: Do not include py-ref.h.
9349         * python/py-unwind.c: Do not include py-ref.h.
9350         * python/py-utils.c: Do not include py-ref.h.
9351         * python/py-value.c: Do not include py-ref.h.
9352         * python/py-varobj.c: Do not include py-ref.h.
9353         * python/py-xmethods.c: Do not include py-ref.h.
9354         * python/python.c: Do not include py-ref.h.
9355         * varobj.c: Do not include py-ref.h.
9356
9357 2019-01-22  Tom Tromey  <tom@tromey.com>
9358
9359         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
9360         keyword for bcache.
9361
9362 2019-01-22  Tom Tromey  <tom@tromey.com>
9363
9364         * compile/compile-cplus-types.c: Remove a comment by #include.
9365
9366 2019-01-22  Tom Tromey  <tom@tromey.com>
9367
9368         * compile/gcc-c-plugin.h: Include compile-internal.h.
9369
9370 2019-01-22  Tom Tromey  <tom@tromey.com>
9371
9372         * stabsread.c (EXTERN): Do not define.
9373         (symnum, next_symbol_text_func, processing_gcc_compilation)
9374         (within_function, global_sym_chain, global_stabs)
9375         (previous_stab_code, this_object_header_files)
9376         (n_this_object_header_files)
9377         (n_allocated_this_object_header_files): Define.
9378         * stabsread.h (EXTERN): Never define.  Use "extern".
9379
9380 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9381
9382         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
9383         history_value.
9384
9385 2019-01-21  Tom Tromey  <tom@tromey.com>
9386
9387         * ui-out.c: Fix includes.
9388         * tui/tui-source.c: Fix includes.
9389         * target.c: Fix includes.
9390         * remote.c: Fix includes.
9391         * regcache.c: Fix includes.
9392         * python/py-block.c: Fix includes.
9393         * printcmd.c: Fix includes.
9394         * or1k-tdep.c: Fix includes.
9395         * mi/mi-main.c: Fix includes.
9396         * m32r-tdep.c: Fix includes.
9397         * csky-tdep.c: Fix includes.
9398         * compile/compile-cplus-types.c: Fix includes.
9399         * cli/cli-interp.c: Fix includes.
9400
9401 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
9402
9403         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
9404         for padding.
9405
9406 2019-01-16  Tom Tromey  <tom@tromey.com>
9407
9408         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
9409         earlier.
9410         (struct objfile) <msymbols_range>: Move from top level.
9411         <msymbols>: New method.
9412         (class objfile_msymbols): Remove.
9413         * symtab.c (default_collect_symbol_completion_matches_break_on):
9414         Update.
9415         * symmisc.c (dump_msymbols): Update.
9416         * stabsread.c (scan_file_globals): Update.
9417         * objc-lang.c (info_selectors_command, info_classes_command)
9418         (find_methods): Update.
9419         * minsyms.c (find_solib_trampoline_target): Update.
9420         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
9421         * coffread.c (coff_symfile_read): Update.
9422         * ada-lang.c (ada_lookup_simple_minsym)
9423         (ada_collect_symbol_completion_matches): Update.
9424
9425 2019-01-16  Tom Tromey  <tom@tromey.com>
9426
9427         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
9428         type.  Remove no-argument constructor.
9429         <iterator::operator++>: Simplify.
9430         <begin>: Update.
9431         <end>: Use minimal_symbol_count.
9432
9433 2019-01-16  Tom Tromey  <tom@tromey.com>
9434
9435         * objfiles.h (struct objfile) <psymtabs>: New method.
9436         (class objfile_psymtabs): Remove.
9437         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
9438         typedef.
9439         <range>: New method.
9440         (require_partial_symbols): Change return type.
9441         * psymtab.c (require_partial_symbols)
9442         (psym_expand_symtabs_matching): Update.
9443         * mdebugread.c (parse_partial_symbols): Update.
9444         * dbxread.c (dbx_end_psymtab): Update.
9445
9446 2019-01-15  Tom Tromey  <tom@tromey.com>
9447
9448         * symtab.c (lookup_objfile_from_block)
9449         (lookup_symbol_in_objfile_symtabs)
9450         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
9451         (find_line_symtab, info_sources_command)
9452         (default_collect_symbol_completion_matches_break_on)
9453         (make_source_files_completion_list): Update.
9454         * symmisc.c (print_objfile_statistics, dump_objfile)
9455         (maintenance_print_symbols, maintenance_info_symtabs)
9456         (maintenance_check_symtabs, maintenance_info_line_tables):
9457         Update.
9458         * source.c (select_source_symtab)
9459         (forget_cached_source_info_for_objfile): Update.
9460         * objfiles.h (class objfile_compunits): Remove.
9461         (struct objfile) <compunits_range>: New typedef.
9462         (compunits): New method.
9463         * objfiles.c (objfile_relocate1): Update.
9464         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
9465         * maint.c (count_symtabs_and_blocks): Update.
9466         * linespec.c (iterate_over_all_matching_symtabs): Update.
9467         * cp-support.c (add_symbol_overload_list_qualified): Update.
9468         * coffread.c (coff_symtab_read): Update.
9469         * ada-lang.c (add_nonlocal_symbols)
9470         (ada_collect_symbol_completion_matches)
9471         (ada_add_global_exceptions): Update.
9472
9473 2019-01-15  Tom Tromey  <tom@tromey.com>
9474
9475         * progspace.h (program_space) <objfiles_safe_range>: New
9476         typedef.
9477         <objfiles_safe>: New method.
9478         * objfiles.h (class all_objfiles_safe): Remove.
9479         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
9480         * jit.c (jit_inferior_exit_hook): Update.
9481
9482 2019-01-17  Tom Tromey  <tom@tromey.com>
9483
9484         * progspace.h (program_space) <objfiles_range>: New typedef.
9485         <objfiles>: New method.
9486         <objfiles_head>: Rename from objfiles.
9487         (object_files): Update.
9488         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
9489         * guile/scm-pretty-print.c
9490         (ppscm_find_pretty_printer_from_objfiles): Update.
9491         * guile/scm-objfile.c (gdbscm_objfiles): Update.
9492         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
9493         Update.
9494         * python/py-progspace.c (pspy_get_objfiles): Update.
9495         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
9496         Update.
9497         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
9498         (objfpy_lookup_objfile_by_build_id): Update.
9499         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
9500         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
9501         Update.
9502         * symtab.c (iterate_over_symtabs, matching_obj_sections)
9503         (expand_symtab_containing_pc, lookup_objfile_from_block)
9504         (lookup_static_symbol, basic_lookup_transparent_type)
9505         (find_pc_sect_compunit_symtab, find_symbol_at_address)
9506         (find_line_symtab, info_sources_command)
9507         (default_collect_symbol_completion_matches_break_on)
9508         (make_source_files_completion_list, find_main_name): Update.
9509         * symmisc.c (print_symbol_bcache_statistics)
9510         (print_objfile_statistics, maintenance_print_symbols)
9511         (maintenance_print_msymbols, maintenance_print_objfiles)
9512         (maintenance_info_symtabs, maintenance_check_symtabs)
9513         (maintenance_expand_symtabs, maintenance_info_line_tables):
9514         Update.
9515         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
9516         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
9517         (map_overlay_command, unmap_overlay_command)
9518         (simple_overlay_update, expand_symtabs_matching)
9519         (map_symbol_filenames): Update.
9520         * symfile-debug.c (set_debug_symfile): Update.
9521         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
9522         Update.
9523         * source.c (select_source_symtab, forget_cached_source_info):
9524         Update.
9525         * solib.c (solib_read_symbols): Update.
9526         * solib-spu.c (append_ocl_sos): Update.
9527         * psymtab.c (maintenance_print_psymbols)
9528         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
9529         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
9530         * printcmd.c (info_symbol_command): Update.
9531         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
9532         Update.
9533         * objfiles.h (class all_objfiles): Remove.
9534         * objfiles.c (have_partial_symbols, have_full_symbols)
9535         (have_minimal_symbols, qsort_cmp, update_section_map)
9536         (shared_objfile_contains_address_p)
9537         (default_iterate_over_objfiles_in_search_order): Update.
9538         * objc-lang.c (info_selectors_command, info_classes_command)
9539         (find_methods): Update.
9540         * minsyms.c (find_solib_trampoline_target): Update.
9541         * maint.c (maintenance_info_sections)
9542         (maintenance_translate_address, count_symtabs_and_blocks):
9543         Update.
9544         * main.c (captured_main_1): Update.
9545         * linux-thread-db.c (try_thread_db_load_from_pdir)
9546         (has_libpthread): Update.
9547         * linespec.c (iterate_over_all_matching_symtabs)
9548         (search_minsyms_for_name): Update.
9549         * jit.c (jit_find_objf_with_entry_addr): Update.
9550         * hppa-tdep.c (find_unwind_entry)
9551         (hppa_lookup_stub_minimal_symbol): Update.
9552         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
9553         Update.
9554         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
9555         (elf_gnu_ifunc_resolve_by_got): Update.
9556         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
9557         * dwarf-index-write.c (save_gdb_index_command): Update.
9558         * cp-support.c (add_symbol_overload_list_qualified): Update.
9559         * breakpoint.c (create_overlay_event_breakpoint)
9560         (create_longjmp_master_breakpoint)
9561         (create_std_terminate_master_breakpoint)
9562         (create_exception_master_breakpoint): Update.
9563         * blockframe.c (find_pc_partial_function): Update.
9564         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
9565         (ada_collect_symbol_completion_matches)
9566         (ada_add_global_exceptions): Update.
9567
9568 2019-01-17  Tom Tromey  <tom@tromey.com>
9569
9570         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
9571         declare VEC.
9572         (solib_target_parse_libraries): Change return type.
9573         (library_list_start_segment, library_list_start_section)
9574         (library_list_end_library, library_list_start_library); Update.
9575         (solib_target_free_library_list): Remove.
9576         (solib_target_parse_libraries): Remove cleanup.  Change return
9577         type.
9578         (solib_target_current_sos): Update.
9579
9580 2019-01-17  Tom Tromey  <tromey@bapiya>
9581
9582         * valprint.c: Replace "the the" with "the".
9583         * symtab.c: Replace "the the" with "the".
9584         * solib.c: Replace "the the" with "the".
9585         * solib-dsbt.c: Replace "the the" with "the".
9586         * linespec.c: Replace "the the" with "the".
9587         * dwarf2loc.h: Replace "the the" with "the".
9588         * amd64-windows-tdep.c: Replace "the the" with "the".
9589         * aarch64-tdep.c: Replace "the the" with "the".
9590
9591 2019-01-16  Keith Seitz  <keiths@redhat.com>
9592
9593         PR gdb/23773
9594         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
9595         <builder>: Rename to ..
9596         <m_builder>: ... this and make private.
9597         (dwarf2_cu::get_builder): New method.  Change all users of
9598         `builder' to use this method.
9599         (dwarf2_start_symtab): Move to ...
9600         (dwarf2_cu::start_symtab): ... here.  Update all callers
9601         (setup_type_unit_groups): Move to ...
9602         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
9603         callers.
9604         (dwarf2_cu::reset_builder): New method.
9605         (process_full_compunit, process_full_type_unit): Use
9606         dwarf2_cu::reset_builder.
9607         (follow_die_offset): Record the ancestor CU if it is different
9608         from the followed DIE's CU.
9609         (follow_die_sig_1): Likewise.
9610
9611 2019-01-15  Tom Tromey  <tom@tromey.com>
9612
9613         * remote.c (class remote_state) <buf>: Now a char_vector.
9614         <buf_size>: Remove.
9615         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
9616         parameter.
9617         (remote_target::getpkt_or_notif_sane_1)
9618         (remote_target::getpkt_sane)
9619         (remote_target::getpkt_or_notif_sane): Likewise.
9620         (class remote_target) <putpkt>: New overload.
9621         (remote_target::read_frame): Change type of "buf_p".  Remove
9622         sizeof_p parameter.
9623         (packet_ok): New overload.
9624         (packet_check_result): New overload.
9625         Update all uses.
9626
9627 2019-01-14  Tom Tromey  <tom@tromey.com>
9628
9629         * remote-notif.c (handle_notification, remote_notif_ack)
9630         (remote_notif_parse): Make "buf" const.
9631         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
9632         const.
9633         (remote_notif_parse, remote_notif_ack, handle_notification):
9634         Likewise.
9635         * remote.c (remote_notif_stop_parse): Make "buf" const.
9636         (remote_target::remote_parse_stop_reply): Make "buf" const.
9637         (remote_notif_stop_ack): Make "buf" const.
9638
9639 2019-01-14  Tom Tromey  <tom@tromey.com>
9640
9641         * remote.c (remote_console_output): Make parameter const.
9642
9643 2019-01-14  Tom Tromey  <tom@tromey.com>
9644
9645         * target-debug.h (target_debug_print_signals): Constify.
9646         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
9647         * procfs.c (procfs_target::pass_signals): Update.
9648         * linux-nat.c (linux_nat_target::pass_signals): Update.
9649         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
9650         * target-delegates.c: Rebuild.
9651         * remote.c (remote_target::program_signals): Update.
9652         (remote_target::pass_signals): Update.
9653         * target.c (target_pass_signals): Constify argument.
9654         (target_program_signals): Likewise.
9655         * target.h (struct target_ops) <pass_signals, program_signals>:
9656         Constify argument.
9657         (target_pass_signals, target_program_signals): Constify argument.
9658
9659 2019-01-14  Tom Tromey  <tom@tromey.com>
9660
9661         PR tui/28819:
9662         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
9663
9664 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
9665
9666         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
9667         field.
9668         * rs6000-tdep.c: Include reggroups.h.
9669         (IS_V_ALIAS_PSEUDOREG): Define.
9670         (rs6000_register_name): Return names for the "vX" aliases.
9671         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
9672         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
9673         aliases.  Call default_register_reggroup_p for all other
9674         pseudo-registers.
9675         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
9676         New functions.
9677         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
9678         Handle "vX" aliases.
9679         (v_alias_pseudo_register_collect): New function.
9680         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
9681         (rs6000_gdbarch_init): Initialize "vX" aliases as
9682         pseudo-registers.  Restore registration of
9683         rs6000_pseudo_register_reggroup_p with
9684         set_tdesc_pseudo_register_reggroup_p.
9685
9686 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
9687
9688         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
9689         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
9690         set_gdbarch_num_pseudo_regs.
9691
9692 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9693
9694         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
9695         Remove arg prefixname, add do_set and do_show.
9696         Add member functions set_list and show_list.
9697         * cli/cli-style.c (class cli_style_option): Update accordingly.
9698         (style_set_list): Move to file scope.
9699         (style_show_list): Likewise.
9700         (set_style): Call help_list.
9701         (show_style): Call cmd_show_list.
9702         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
9703         Update to use the new macro.
9704
9705 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
9706
9707         * ada-lang.c (_initialize_ada_language): Expand the help text
9708         for the "catch exception" command.
9709
9710 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9711
9712         * symtab.c (matching_obj_sections): Initialize obj,
9713         declare it closer to its usage.
9714
9715 2019-01-10  Tom Tromey  <tom@tromey.com>
9716
9717         * thread-iter.h (inf_threads_iterator): Use next_iterator.
9718         (basic_inf_threads_range): Remove.
9719         (inf_threads_range, inf_non_exited_threads_range)
9720         (safe_inf_threads_range): Use next_adapter.
9721
9722 2019-01-10  Keith Seitz  <keiths@redhat.com>
9723
9724         PR gdb/23712
9725         PR symtab/23010
9726         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
9727         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
9728
9729 2019-01-10  Keith Seitz  <keiths@redhat.com>
9730
9731         PR gdb/23712
9732         PR symtab/23010
9733         * dictionary.c (pending_to_vector): Remove.
9734         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
9735         Remove _1 suffix, replacing functions of the same name.  Update
9736         all callers.
9737         (dict_create_hashed, dict_create_hashed_expandable)
9738         (dict_create_linear, dict_create_linear_expandable, dict_free)
9739         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
9740         Make functions static.
9741
9742 2019-01-10  Keith Seitz  <keiths@redhat.com>
9743
9744         PR gdb/23712
9745         PR symtab/23010
9746         * dictionary.h (struct dictionary): Replace declaration with
9747         multidictionary.
9748         (dict_create_hashed, dict_create_hashed_expandable)
9749         (dict_create_linear, dict_create_linear_expandable)
9750         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
9751         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
9752         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
9753         taking multidictionary argument.
9754         [ALL_DICT_SYMBOLS]: Update for multidictionary.
9755         * block.h (struct block) <dict>: Change to multidictionary
9756         and rename `multidict'.
9757         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
9758         symmisc.c: Update all dictionary references to multidictionary.
9759
9760 2019-01-10  Keith Seitz  <keiths@redhat.com>
9761
9762         PR gdb/23712
9763         PR symtab/23010
9764         * dictionary.c: Include unordered_map.
9765         (pending_to_vector): New function.
9766         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
9767         Rewrite the non-"_1" functions to take vector instead
9768         of linked list.
9769         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
9770         "new" _1 versions of the same name.
9771         (multidictionary): Define.
9772         (std::hash<enum language): New definition.
9773         (collate_pending_symbols_by_language, mdict_create_hashed)
9774         (mdict_create_hashed_expandable, mdict_create_linear)
9775         (mdict_create_linear_expandable, mdict_free)
9776         (find_language_dictionary, create_new_language_dictionary)
9777         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
9778         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
9779         (mdict_size, mdict_empty): New functions.
9780         * dictionary.h (mdict_iterator): Define.
9781
9782 2019-01-10  Pedro Alves  <palves@redhat.com>
9783
9784         * breakpoint.c (read_uploaded_action)
9785         (create_tracepoint_from_upload): Adjust to use
9786         gdb::unique_xmalloc_ptr.
9787         * ctf.c (ctf_write_uploaded_tp):
9788         (SET_ARRAY_FIELD): Use emplace_back.
9789         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
9790         * tracefile-tfile.c (tfile_write_uploaded_tp):
9791         * tracepoint.c (parse_tracepoint_definition): Adjust to use
9792         gdb::unique_xmalloc_ptr.
9793         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
9794         at_string, cond_string, cmd_strings>: Replace char pointers
9795         with gdb::unique_xmalloc_ptr.
9796
9797 2019-01-10  Pedro Alves  <palves@redhat.com>
9798
9799         * solib-target.c (library_list_start_library): Don't xstrdup name.
9800
9801 2019-01-10  Pedro Alves  <palves@redhat.com>
9802
9803         * mdebugread.c (parse_partial_symbols): Use
9804         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
9805
9806 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
9807
9808         * linux-fork.c (scoped_switch_fork_info)
9809         <~scoped_switch_fork_info>: Fix incorrect variable name.
9810
9811 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
9812
9813         * linux-fork.c (scoped_switch_fork_info)
9814         <scoped_switch_fork_info>: Make explicit.
9815         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
9816
9817 2019-01-10  Tom Tromey  <tom@tromey.com>
9818
9819         * objfiles.h (objfile::reset_psymtabs): Update.
9820         * objfiles.c (objfile::objfile): Update.
9821         * psymtab.h (psymtab_storage::obstack): Update.
9822         (psymtab_storage::m_obstack): Use gdb::optional.
9823         (class psymtab_storage): Update comment.  Remove objfile
9824         parameter.
9825         * psymtab.c (psymtab_storage::psymtab_storage): Update.
9826
9827 2019-01-10  Tom Tromey  <tom@tromey.com>
9828
9829         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
9830         <free_psymtabs>: Now private.
9831         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
9832         (allocate_psymtab): Use new method.
9833
9834 2019-01-10  Tom Tromey  <tom@tromey.com>
9835
9836         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
9837         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
9838         * mdebugread.c (parse_partial_symbols): Use
9839         allocate_dependencies.
9840         * dwarf2read.c (dwarf2_create_include_psymtab): Use
9841         allocate_dependencies.
9842         (process_psymtab_comp_unit_reader)
9843         (build_type_psymtab_dependencies): Likewise.
9844         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
9845
9846 2019-01-10  Tom Tromey  <tom@tromey.com>
9847
9848         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
9849         PSYMBOL_SET_LANGUAGE.
9850         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
9851
9852 2019-01-10  Tom Tromey  <tom@tromey.com>
9853
9854         * psymtab.h (psymtab_storage::obstack): New method.
9855         <m_obstack>: Rename from obstack; now private.
9856         * psymtab.c (psymtab_storage): Update.
9857         * dwarf2read.c (create_addrmap_from_index)
9858         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
9859         Update.
9860
9861 2019-01-10  Tom Tromey  <tom@tromey.com>
9862
9863         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
9864         * objfiles.h (objfile::reset_psymtabs): New method.
9865
9866 2019-01-10  Tom Tromey  <tom@tromey.com>
9867
9868         * symmisc.c (print_symbol_bcache_statistics): Update.
9869         (print_objfile_statistics): Update.
9870         * symfile.c (reread_symbols): Update.
9871         * psymtab.h (class psymtab_storage): New.
9872         * psymtab.c (psymtab_storage): New constructor.
9873         (~psymtab_storage): New destructor.
9874         (require_partial_symbols): Update.
9875         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
9876         (find_pc_sect_psymtab, find_pc_sect_psymbol)
9877         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
9878         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
9879         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
9880         (start_psymtab_common, end_psymtab_common)
9881         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
9882         (allocate_psymtab): Update.
9883         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
9884         Update.
9885         (dump_psymtab_addrmap, maintenance_print_psymbols)
9886         (maintenance_check_psymtabs): Update.
9887         (class objfile_psymtabs): Move to objfiles.h.
9888         * psympriv.h (discard_psymtab): Now inline.
9889         (psymtab_discarder::psymtab_discarder): Update.
9890         (psymtab_discarder::~psymtab_discarder): Update.
9891         (ALL_OBJFILE_PSYMTABS): Rewrite.
9892         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
9893         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
9894         Remove fields.
9895         <partial_symtabs>: New field.
9896         (class objfile_psymtabs): Move from psymtab.h.  Update.
9897         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
9898         psymbol_cache.
9899         (objfile::~objfile): Don't destroy psymbol_cache.
9900         * mdebugread.c (parse_partial_symbols): Update.
9901         * dwarf2read.c (create_addrmap_from_index)
9902         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
9903         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
9904         (add_partial_subprogram, dwarf2_ranges_read): Update.
9905         * dwarf-index-write.c (write_address_map)
9906         (write_one_signatured_type, recursively_write_psymbols)
9907         (class debug_names, class debug_names, write_psymtabs_to_index):
9908         Update.
9909
9910 2019-01-10  Tom Tromey  <tom@tromey.com>
9911
9912         * symtab.h (SYMBOL_SET_NAMES): Update.
9913         (symbol_set_names): Update.
9914         (MSYMBOL_SET_NAMES): Update.
9915         * symtab.c (symbol_set_names): Change argument to be an
9916         objfile_per_bfd_storage.
9917         * psymtab.c (add_psymbol_to_bcache): Update.
9918         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
9919
9920 2019-01-10  Tom Tromey  <tom@tromey.com>
9921
9922         * symtab.c (create_demangled_names_hash): Change argument to be an
9923         objfile_per_bfd_storage.
9924         (symbol_set_names): Update.
9925
9926 2019-01-10  Tom Tromey  <tom@tromey.com>
9927
9928         * xcoffread.c (xcoff_initial_scan): Unconditionally call
9929         init_psymbol_list.
9930         * psymtab.c (init_psymbol_list): Do nothing if already called.
9931         * psympriv.h (init_psymbol_list): Add comment.
9932         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
9933         init_psymbol_list.
9934         * dbxread.c (dbx_symfile_read): Unconditionally call
9935         init_psymbol_list.
9936
9937 2019-01-10  Tom Tromey  <tom@tromey.com>
9938
9939         * xcoffread.c (scan_xcoff_symtab): Update.
9940         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
9941         "where".
9942         * mdebugread.c (parse_partial_symbols)
9943         (handle_psymbol_enumerators): Update.
9944         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
9945         * dbxread.c (read_dbx_symtab): Update.
9946         * psympriv.h (psymbol_placement): New enum.
9947         (add_psymbol_to_list): Update.
9948
9949 2019-01-10  Tom Tromey  <tom@tromey.com>
9950
9951         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
9952         static_psymbols parameters.
9953         (scan_xcoff_symtab): Update.
9954         * psymtab.c (start_psymtab_common): Remove global_psymbols and
9955         static_psymbols parameters.
9956         * psympriv.h (start_psymtab_common): Update.
9957         * mdebugread.c (parse_partial_symbols): Update.
9958         * dwarf2read.c (create_partial_symtab): Update.
9959         * dbxread.c (read_dbx_symtab): Update.
9960         (start_psymtab): Remove global_psymbols and static_psymbols
9961         parameters.
9962
9963 2019-01-10  Tom Tromey  <tom@tromey.com>
9964
9965         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
9966         * psymtab.c (allocate_psymtab): Add comment.
9967         * psympriv.h (allocate_psymtab): Add comment.
9968         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
9969         initializations.
9970         * dbxread.c (dbx_end_psymtab): Remove some initializations.
9971
9972 2019-01-10  Tom Tromey  <tom@tromey.com>
9973
9974         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
9975         Don't declare.
9976         * mipsread.c: Include mdebugread.h.
9977         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
9978         Declare.
9979         * elfread.c: Include mdebugread.h.
9980
9981 2019-01-09  Tom Tromey  <tom@tromey.com>
9982
9983         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
9984         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
9985         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
9986         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
9987         (psym_lookup_symbol, psym_find_last_source_symtab)
9988         (psym_forget_cached_source_info, psym_print_stats)
9989         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
9990         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
9991         (psym_map_matching_symbols, psym_expand_symtabs_matching)
9992         (psym_find_compunit_symtab_by_address)
9993         (maintenance_print_psymbols, maintenance_info_psymtabs)
9994         (maintenance_check_psymtabs): Use ranged for.
9995         * psymtab.h (class objfile_psymtabs): New.
9996         (require_partial_symbols): Return objfile_psymtabs.
9997         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
9998
9999 2019-01-09  Tom Tromey  <tom@tromey.com>
10000
10001         * symfile.c (overlay_invalidate_all, find_pc_overlay)
10002         (find_pc_mapped_section, list_overlays_command)
10003         (map_overlay_command, unmap_overlay_command)
10004         (simple_overlay_update): Use all_objfiles.
10005         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
10006         * printcmd.c (info_symbol_command): Use all_objfiles.
10007         * objfiles.h (ALL_OBJSECTIONS): Remove.
10008         * maint.c (maintenance_translate_address): Use all_objfiles.
10009         * gcore.c (gcore_create_callback): Use all_objfiles.
10010         (objfile_find_memory_regions): Likewise.
10011
10012 2019-01-09  Tom Tromey  <tom@tromey.com>
10013
10014         * symtab.c (find_line_symtab, info_sources_command)
10015         (make_source_files_completion_list): Use objfile_compunits.
10016         * source.c (select_source_symtab): Use objfile_compunits.
10017         * objfiles.h (struct objfile): Update comment.
10018         (ALL_OBJFILES): Remove.
10019         (ALL_FILETABS): Remove.
10020         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
10021         objfile_compunits.
10022
10023 2019-01-09  Tom Tromey  <tom@tromey.com>
10024
10025         * symmisc.c (print_objfile_statistics, dump_objfile)
10026         (maintenance_print_symbols): Use compunit_filetabs.
10027         * source.c (forget_cached_source_info_for_objfile): Use
10028         compunit_filetabs.
10029         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
10030         (ALL_FILETABS): Use compunit_filetabs.
10031         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
10032         * coffread.c (coff_symtab_read): Use compunit_filetabs.
10033
10034 2019-01-09  Tom Tromey  <tom@tromey.com>
10035
10036         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
10037         (compunit_filetabs): New.
10038         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
10039         compunit_filetabs.
10040         (info_sources_command, make_source_files_completion_list): Remove
10041         declaration.
10042         * symmisc.c (print_objfile_statistics, dump_objfile)
10043         (maintenance_print_symbols): Remove declaration.
10044         (maintenance_info_symtabs): Use compunit_filetabs.
10045         (maintenance_info_line_tables): Likewise.
10046         * source.c (select_source_symtab): Change local variable name.
10047         (forget_cached_source_info_for_objfile): Remove declaration.
10048         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
10049         * objfiles.c (objfile_relocate1): Remove declaration.
10050         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
10051         declaration.
10052         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
10053         * coffread.c (coff_symtab_read): Remove declaration.
10054         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
10055         compunit_filetabs.
10056
10057 2019-01-09  Tom Tromey  <tom@tromey.com>
10058
10059         * symtab.c (lookup_objfile_from_block)
10060         (find_pc_sect_compunit_symtab, search_symbols)
10061         (default_collect_symbol_completion_matches_break_on): Use
10062         objfile_compunits.
10063         * objfiles.h (ALL_COMPUNITS): Remove.
10064         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
10065         * cp-support.c (add_symbol_overload_list_qualified): Use
10066         objfile_compunits.
10067         * ada-lang.c (ada_collect_symbol_completion_matches)
10068         (ada_add_global_exceptions): Use objfile_compunits.
10069
10070 2019-01-09  Tom Tromey  <tom@tromey.com>
10071
10072         * source.c (select_source_symtab)
10073         (forget_cached_source_info_for_objfile): Remove declaration.
10074         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
10075         declaration.
10076         * maint.c (count_symtabs_and_blocks): Remove declaration.
10077         * cp-support.c (add_symbol_overload_list_qualified): Remove
10078         declaration.
10079         * coffread.c (coff_symtab_read): Remove declaration.
10080         * symtab.c (lookup_symbol_in_objfile_symtabs)
10081         (basic_lookup_transparent_type_1): Use objfile_compunits.
10082         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
10083         (info_sources_command, search_symbols)
10084         (default_collect_symbol_completion_matches_break_on)
10085         (make_source_files_completion_list): Remove declaration.
10086         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
10087         (ada_collect_symbol_completion_matches)
10088         (ada_add_global_exceptions): Remove declaration.
10089         * linespec.c (iterate_over_all_matching_symtabs): Use
10090         objfile_compunits.
10091         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
10092         (class objfile_compunits): New.
10093         (ALL_COMPUNITS): Use objfile_compunits.
10094         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
10095         (maintenance_check_symtabs, maintenance_info_line_tables): Use
10096         objfile_compunits.
10097         * objfiles.c (objfile_relocate1): Use objfile_compunits.
10098
10099 2019-01-09  Tom Tromey  <tom@tromey.com>
10100
10101         * symtab.c (search_symbols)
10102         (default_collect_symbol_completion_matches_break_on): Use
10103         objfile_msymbols.
10104         * ada-lang.c (ada_lookup_simple_minsym)
10105         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
10106         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
10107         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
10108         objfile_msymbols.
10109         * coffread.c (coff_symfile_read): Use objfile_msymbols.
10110         * symmisc.c (dump_msymbols): Use objfile_msymbols.
10111         * objc-lang.c (find_methods): Use objfile_msymbols.
10112         (info_selectors_command, info_classes_command): Likewise.
10113         * stabsread.c (scan_file_globals): Use objfile_msymbols.
10114         * objfiles.h (class objfile_msymbols): New.
10115         (ALL_OBJFILE_MSYMBOLS): Remove.
10116         (ALL_MSYMBOLS): Remove.
10117
10118 2019-01-09  Tom Tromey  <tom@tromey.com>
10119
10120         * common/next-iterator.h (next_adapter): Add Iterator template
10121         parameter.
10122         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
10123         (class all_objfiles_safe): New.
10124         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
10125         * objfiles.c (put_objfile_before): Update comment.
10126         (add_separate_debug_objfile): Likewise.
10127         (free_all_objfiles): Use all_objfiles_safe.
10128         (objfile_purge_solibs): Likewise.
10129
10130 2019-01-09  Tom Tromey  <tom@tromey.com>
10131
10132         * symtab.c (iterate_over_symtabs, matching_obj_sections)
10133         (expand_symtab_containing_pc, lookup_static_symbol)
10134         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
10135         (find_symbol_at_address, find_line_symtab, find_main_name): Use
10136         all_objfiles.
10137         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
10138         * breakpoint.c (create_overlay_event_breakpoint)
10139         (create_longjmp_master_breakpoint)
10140         (create_std_terminate_master_breakpoint)
10141         (create_exception_master_breakpoint): Use all_objfiles.
10142         * linux-thread-db.c (try_thread_db_load_from_pdir)
10143         (has_libpthread): Use all_objfiles.
10144         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
10145         * linespec.c (iterate_over_all_matching_symtabs)
10146         (search_minsyms_for_name): Use all_objfiles.
10147         * maint.c (maintenance_info_sections): Use all_objfiles.
10148         * main.c (captured_main_1): Use all_objfiles.
10149         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
10150         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
10151         * guile/scm-pretty-print.c
10152         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
10153         * solib-spu.c (append_ocl_sos): Use all_objfiles.
10154         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
10155         (maintenance_print_msymbols): Use all_objfiles.
10156         * source.c (select_source_symtab): Use all_objfiles.
10157         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
10158         * symfile.c (remove_symbol_file_command)
10159         (expand_symtabs_matching, map_symbol_filenames): Use
10160         all_objfiles.
10161         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
10162         all_objfiles.
10163         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
10164         * objc-lang.c (find_methods): Use all_objfiles.
10165         * objfiles.c (have_partial_symbols, have_full_symbols)
10166         (have_minimal_symbols, qsort_cmp)
10167         (default_iterate_over_objfiles_in_search_order): Use
10168         all_objfiles.
10169         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
10170         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
10171         (maintenance_check_psymtabs): Use all_objfiles.
10172         (ALL_PSYMTABS): Remove.
10173         * compile/compile-object-run.c (do_module_cleanup): Use
10174         all_objfiles.
10175         * blockframe.c (find_pc_partial_function): Use all_objfiles.
10176         * cp-support.c (add_symbol_overload_list_qualified): Use
10177         all_objfiles.
10178         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
10179         Use all_objfiles.
10180         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
10181         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
10182         all_objfiles.
10183         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
10184         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
10185         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
10186         Uses all_objfiles.
10187         * solib.c (solib_read_symbols): Use all_objfiles
10188
10189 2019-01-09  Tom Tromey  <tom@tromey.com>
10190
10191         * probe.c (parse_probes_in_pspace): Use all_objfiles.
10192         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
10193         all_objfiles.
10194         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
10195         * symmisc.c (print_symbol_bcache_statistics)
10196         (print_objfile_statistics, maintenance_print_objfiles)
10197         (maintenance_info_symtabs, maintenance_check_symtabs)
10198         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
10199         all_objfiles.
10200         * source.c (forget_cached_source_info): Use all_objfiles.
10201         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
10202         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
10203         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
10204         * objfiles.c (update_section_map): Use all_objfiles.
10205         (shared_objfile_contains_address_p): Likewise.
10206         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
10207         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
10208
10209 2019-01-09  Tom Tromey  <tom@tromey.com>
10210
10211         * common/next-iterator.h: New file.
10212         * objfiles.h (class all_objfiles): New.
10213         (struct objfile_iterator): New.
10214
10215 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10216
10217         * NEWS: Move the description of the changed "frame", "select-frame",
10218          and "info frame" commands to the Changed commands section.
10219
10220 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
10221
10222         * gdbtypes.c (check_stub_method_group): Remove handling of old
10223         mangling schemes.
10224         * linespec.c (find_methods): Likewise.
10225         * stabsread.c (read_member_functions): Likewise.
10226         * valops.c (search_struct_method): Likewise.
10227         (value_struct_elt_for_reference): Likewise.
10228         * NEWS: Mention this change.
10229
10230 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
10231
10232         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
10233         print_source_lines.
10234         * source.c (print_source_lines_base): Update line number check.
10235         (print_source_lines): New function.
10236         (source_lines_range::source_lines_range): New function.
10237         * source.h (class source_lines_range): New class.
10238         (print_source_lines): New declaration.
10239
10240 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10241
10242         * linespec.c (linespec_state_destructor): Free self->canonical_names.
10243
10244 2019-01-08  Tom Tromey  <tom@tromey.com>
10245             Simon Marchi  <simon.marchi@ericsson.com>
10246
10247         PR gdb/24060
10248         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
10249         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
10250         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
10251         * f-exp.y (DOLLAR_VARIABLE): Likewise.
10252         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
10253         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
10254
10255 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10256
10257         * source.c (select_source_symtab): Move header comment to
10258         declaration in source.h.
10259         (forget_cached_source_info_for_objfile): Likewise.
10260         (forget_cached_source_info): Likewise.
10261         (identify_source_line): Likewise.
10262         * source.h (identify_source_line): Move declaration from symtab.h
10263         and add comment from source.c
10264         (print_source_lines): Likewise.
10265         (forget_cached_source_info_for_objfile): Likewise.
10266         (forget_cached_source_info): Likewise.
10267         (select_source_symtab): Likewise.
10268         (enum print_source_lines_flag): Move definition from symtab.h.
10269         * symtab.h (identify_source_line): Move declaration to source.h.
10270         (print_source_lines): Likewise.
10271         (forget_cached_source_info_for_objfile): Likewise.
10272         (forget_cached_source_info): Likewise.
10273         (select_source_symtab): Likewise.
10274         (enum print_source_lines_flag): Move definition to source.h.
10275         * tui/tui-hooks.c: Add 'source.h' include.
10276
10277 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10278
10279         * source.c (print_source_lines_base): Handle requests to print
10280         reverse line number sequences, and guard against empty lines
10281         string.
10282
10283 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10284
10285         * source.c (print_source_lines_base): Fix skip of '\r' if next
10286         character is '\n'.
10287
10288 2019-01-06  Tom Tromey  <tom@tromey.com>
10289
10290         * c-exp.y (struct c_parse_state) <macro_original_text,
10291         expansion_obstack>: New member.
10292         (macro_original_text, expansion_obstack): Remove globals.
10293         (scan_macro_expansion, scanning_macro_expansion)
10294         (finished_macro_expansion): Update.
10295         (scan_macro_cleanup): Remove.
10296         (yylex, c_parse): Update.
10297
10298 2019-01-06  Tom Tromey  <tom@tromey.com>
10299
10300         * c-exp.y (struct c_parse_state) <strings>: New member.
10301         (operator_stoken): Update.
10302
10303 2019-01-06  Tom Tromey  <tom@tromey.com>
10304
10305         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
10306         (union type_stack_elt) <typelist_val>: Now a pointer to
10307         std::vector.
10308         (type_stack_cleanup): Don't declare.
10309         (push_typelist): Update.
10310         * parse.c (pop_typelist): Return a std::vector.
10311         (push_typelist): Take a std::vector.
10312         (follow_types): Update.  Do not free args.
10313         (type_stack_cleanup): Remove.
10314         * c-exp.y (struct c_parse_state): New.
10315         (cpstate): New global.
10316         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
10317         (nonempty_typelist): Update.
10318         (func_mod): Create a new vector.
10319         (c_parse): Create a c_parse_state.
10320         (check_parameter_typelist): Do not delete params.
10321         (function_method): Update.  Do not delete type_list.
10322
10323 2019-01-06  Tom Tromey  <tom@tromey.com>
10324
10325         PR gdb/28155:
10326         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
10327         check_typedef.
10328         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
10329         (print_return_value): Likewise.
10330
10331 2019-01-05  Tom Tromey  <tom@tromey.com>
10332
10333         * contrib/cleanup_check.py: Remove.
10334         * contrib/gcc-with-excheck: Remove.
10335         * contrib/exsummary.py: Remove.
10336         * contrib/excheck.py: Remove.
10337
10338 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
10339
10340         * thread.c (delete_thread_1): Add gdb_assert that THR is not
10341         NULL. Initialize tpprev to NULL instead of assigning it
10342         to NULL on the next statement.
10343         * windows-nat.c (windows_delete_thread): Remove check for
10344         main_thread_id before printing thread exit notifications.
10345         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
10346         Remove thread ID check against main_thread_id.
10347         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
10348         windows_delete_thread.
10349         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
10350
10351 2019-01-04  Tom Tromey  <tom@tromey.com>
10352
10353         * compile/compile.c (_initialize_compile): Use upper case for
10354         metasyntactic variables.
10355         * symmisc.c (_initialize_symmisc): Use upper case for
10356         metasyntactic variables.
10357         * psymtab.c (_initialize_psymtab): Use upper case for
10358         metasyntactic variables.
10359         * demangle.c (demangle_command): Use upper case for metasyntactic
10360         variables.
10361         (_initialize_demangler): Likewise.
10362         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
10363         variables.
10364
10365 2019-01-03  Tom Tromey  <tom@tromey.com>
10366
10367         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
10368
10369 2019-01-03  Tom Tromey  <tom@tromey.com>
10370
10371         * python/py-symtab.c (salpy_str): Update.
10372         (struct salpy_sal_object) <symtab>: Now a PyObject.
10373         (salpy_dealloc): Update.
10374         (del_objfile_sal): Use gdbpy_ref.
10375
10376 2019-01-03  Tom Tromey  <tom@tromey.com>
10377
10378         * python/py-type.c (convert_field): Use new_reference.  Return
10379         gdbpy_ref.
10380         (make_fielditem): Return gdbpy_ref.
10381         (typy_fields): Update.
10382         (typy_getitem): Update.
10383         (field_name): Return gdbpy_ref.  Use new_reference.
10384         (typy_iterator_iternext): Update.
10385
10386 2019-01-03  Tom Tromey  <tom@tromey.com>
10387
10388         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
10389
10390 2019-01-03  Tom Tromey  <tom@tromey.com>
10391
10392         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
10393         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
10394         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
10395         (pspy_set_frame_filters, pspy_set_frame_unwinders)
10396         (pspy_set_type_printers): Likewise.
10397         * python/py-function.c (fnpy_init): Use gdbpy_ref.
10398         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
10399         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
10400         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
10401         (objfpy_set_type_printers): Likewise.
10402
10403 2019-01-03  Tom Tromey  <tom@tromey.com>
10404
10405         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
10406         (gdbpy_print_stack): Use gdbpy_err_fetch.
10407         * python/python-internal.h (class gdbpy_err_fetch): New class.
10408         (class gdbpy_enter) <m_error_type, m_error_value,
10409         m_error_traceback>: Remove.
10410         <m_error>: New member.
10411         (gdbpy_exception_to_string): Don't declare.
10412         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
10413         * python/py-value.c (convert_value_from_python): Use
10414         gdbpy_err_fetch.
10415         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
10416         gdbpy_exception_to_string.
10417         (gdbpy_handle_exception): Use gdbpy_err_fetch.
10418         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
10419         gdbpy_err_fetch.
10420
10421 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10422
10423         * linux-nat.c (delete_lwp_cleanup): Delete.
10424         (struct lwp_deleter): New struct.
10425         (lwp_info_up): New typedef.
10426         (linux_nat_target::follow_fork): Delete cleanup, and make use of
10427         lwp_info_up.
10428
10429 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10430
10431         * linux-fork.c (class scoped_switch_fork_info): New class.
10432         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
10433
10434 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10435
10436         * valops.c (find_overload_match): Remove use of null_cleanup, and
10437         calls to do_cleanups.
10438
10439 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10440
10441         * compile/compile-cplus-types.c
10442         (compile_cplus_instance::decl_name): Handle changes to
10443         cp_func_name.
10444         * cp-support.c (cp_func_name): Update header comment, update
10445         return type.
10446         * cp-support.h (cp_func_name): Update return type in declaration.
10447         * valops.c (find_overload_match): Move temp_func local to top
10448         level of function and change its type.  Use temp_func to hold and
10449         delete temporary string obtained from cp_func_name.
10450
10451 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10452
10453         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
10454         gdb::char_vector, remove cleanup, and update uses of `msg`.
10455
10456 2019-01-03  Jim Wilson  <jimw@sifive.com>
10457
10458         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
10459
10460 2019-01-02  Tom Tromey  <tom@tromey.com>
10461
10462         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
10463         (tdesc_parse_xml): Remove cleanups.
10464         * target-descriptions.h (make_cleanup_free_target_description):
10465         Don't declare.
10466         (target_desc_deleter): New struct.
10467         (target_desc_up): New typedef.
10468         * target-descriptions.c (target_desc_deleter::operator()): Rename
10469         from free_target_description.
10470         (make_cleanup_free_target_description): Remove.
10471
10472 2019-01-02  Tom Tromey  <tom@tromey.com>
10473
10474         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
10475         constructor, destructor.
10476         (linespec_parser): Remove typedef.
10477         (~linespec_parser): Rename from linespec_parser_delete.
10478         (linespec_lex_to_end, linespec_complete_label)
10479         (linespec_complete): Update.
10480         (decode_line_full): Remove cleanups.
10481         (decode_line_1): Update.
10482
10483 2019-01-02  Tom Tromey  <tom@tromey.com>
10484
10485         * python/python-internal.h (inferior_to_inferior_object): Change
10486         return type.
10487         * python/py-exitedevent.c (create_exited_event_object): Update.
10488         * python/py-inferior.c (inferior_to_inferior_object): Return
10489         gdbpy_ref.
10490         (python_new_inferior, python_inferior_deleted)
10491         (thread_to_thread_object, delete_thread_object)
10492         (build_inferior_list, gdbpy_selected_inferior): Update.
10493         * python/py-infthread.c (create_thread_object): Update.  Also fail
10494         if inferior_to_inferior_object fails.
10495
10496 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
10497
10498         * inferior.h (class inferior) <displaced_step_state>: New field.
10499         * infrun.h (struct displaced_step_state): Move here from
10500         infrun.c.  Initialize fields, add constructor.
10501         <inf>: Remove field.
10502         <reset>: New method.
10503         * infrun.c (struct displaced_step_inferior_state): Move to
10504         infrun.h.
10505         (displaced_step_inferior_states): Remove.
10506         (get_displaced_stepping_state): Adust.
10507         (displaced_step_in_progress_any_inferior): Adjust.
10508         (displaced_step_in_progress_thread): Adjust.
10509         (displaced_step_in_progress): Adjust.
10510         (add_displaced_stepping_state): Remove.
10511         (get_displaced_step_closure_by_addr): Adjust.
10512         (remove_displaced_stepping_state): Remove.
10513         (infrun_inferior_exit): Call displaced_step_state.reset.
10514         (use_displaced_stepping): Don't check for NULL.
10515         (displaced_step_prepare_throw): Call
10516         get_displaced_stepping_state.
10517         (displaced_step_fixup): Don't check for NULL.
10518         (prepare_for_detach): Don't check for NULL.
10519
10520 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10521
10522         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
10523          in case of call that did not complete.
10524
10525 2019-01-02  Andrey Utkin  <autkin@undo.io>
10526
10527         * symfile.c (find_separate_debug_file): Fix search of debug files for
10528         remote debuggee.
10529
10530 2019-01-02  Tom Tromey  <tom@tromey.com>
10531
10532         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
10533         indentation.
10534         * python/py-frame.c (frapy_older): Remove cast.
10535         (frapy_newer): Likewise.
10536         * python/py-breakpoint.c (local_setattro): Remove cast.
10537         * python/py-arch.c (archpy_name): Remove local variable.
10538         * python/py-type.c (gdbpy_lookup_type): Remove cast.
10539
10540 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
10541
10542         * unittests/basic_string_view/element_access/char/empty.cc:
10543         Fix year range in copyright header.
10544
10545 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
10546
10547         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
10548         Delete.
10549         <operator==>: Update with for removed field.
10550         <hash>: Likewise.
10551         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
10552         <isa_features>: ...this.
10553         <abi_features>: New field.
10554         (riscv_isa_flen): Update comment.
10555         (riscv_abi_xlen): New declaration.
10556         (riscv_abi_flen): New declaration.
10557         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
10558         isa_features.
10559         (riscv_abi_xlen): New function.
10560         (riscv_isa_flen): Update to get answer from isa_features.
10561         (riscv_abi_flen): New function.
10562         (riscv_has_fp_abi): Update to get answer from abi_features.
10563         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
10564         xlen and flen.
10565         (riscv_call_info) <xlen, flen>: Update comment.
10566         (riscv_call_arg_struct): Remove invalid assertions
10567         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
10568         is removed.
10569         (riscv_gdbarch_init): Gather isa features and abi features
10570         separately, ensure both match on the gdbarch when reusing an old
10571         gdbarch.  Relax an error check to allow 32-bit abi float to run on
10572         a target with 64-bit float hardware.
10573
10574 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10575
10576         * source.c (search_command_helper): Stop reverse search
10577         when line 1 has been searched.
10578
10579 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10580
10581         * record-full.c (record_full_base_target::close): Rewrite
10582         record_full_core_buf_list free logic.
10583
10584 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10585
10586         * break-catch-syscall.c (print_one_catch_syscall): xfree
10587         the last text.
10588
10589 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
10590
10591         * top.c (print_gdb_version): Update Copyright year in version
10592         message.
10593
10594 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
10595
10596         Update copyright year range in all GDB files.
10597
10598 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
10599
10600         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
10601
10602 For older changes see ChangeLog-2018.
10603 \f
10604 Local Variables:
10605 mode: change-log
10606 left-margin: 8
10607 fill-column: 74
10608 version-control: never
10609 coding: utf-8
10610 End:
10611