Add constructor to stap_static_probe_ops
[deliverable/binutils-gdb.git] / gdb / ChangeLog
1 2020-01-07 Tom Tromey <tromey@adacore.com>
2
3 PR build/24937:
4 * stap-probe.c (class stap_static_probe_ops): Add constructor.
5
6 2020-01-06 Andrew Burgess <andrew.burgess@embecosm.com>
7
8 * stack.c (print_frame_info): Move disassemble_next_line code
9 inside source_print block.
10
11 2020-01-01 Joel Brobecker <brobecker@adacore.com>
12
13 * gdbarch.sh: Update copyright year range of generated files.
14
15 2020-01-01 Joel Brobecker <brobecker@adacore.com>
16
17 Update copyright year range in all the GDB files automatically
18 handled by our copyright.py script.
19
20 2020-01-01 Joel Brobecker <brobecker@adacore.com>
21
22 * copyright.py: Convert to Python 3.
23
24 2020-01-01 Joel Brobecker <brobecker@adacore.com>
25
26 * copyright.py: Adapt after move of gnulib directory from gdb
27 directory to toplevel directory.
28
29 2020-01-01 Joel Brobecker <brobecker@adacore.com>
30
31 * copyright.py (main): Exit if run from the wrong directory.
32
33 2020-01-01 Joel Brobecker <brobecker@adacore.com>
34
35 * top.c (print_gdb_version): Change copyright year to 2020.
36
37 2019-12-26 Christian Biesinger <cbiesinger@google.com>
38
39 * configure: Regenerate.
40 * configure.ac: Quote variable arguments of test.
41 * gdbsupport/common.m4: Likewise.
42
43 2019-12-21 Eli Zaretskii <eliz@gnu.org>
44
45 * top.c (print_gdb_configuration): Print "--with-xxhash" or
46 "--without-xxhash" according to HAVE_LIBXXHASH.
47
48 2019-12-18 Tom Tromey <tromey@adacore.com>
49
50 PR build/25268:
51 * gdbsupport/thread-pool.c (set_thread_name): Expect "int" return
52 type on macOS. Add comment.
53
54 2019-12-18 Tom Tromey <tromey@adacore.com>
55
56 PR build/25250:
57 * ui-out.c (ui_out::vmessage): Update.
58 * ui-out.h (enum class field_kind) <FIELD_STRING, FIELD_SIGNED>:
59 Rename.
60 (string_field): Update.
61 (signed_field): Update.
62
63 2019-12-16 Simon Marchi <simon.marchi@polymtl.ca>
64
65 * jit.c (finalize_symtab): Set gdb_block_iter_tmp in loop.
66
67 2019-12-11 Joel Brobecker <brobecker@adacore.com>
68
69 * version.in: Set GDB version number to 9.0.90.DATE-git.
70
71 2019-12-11 Joel Brobecker <brobecker@adacore.com>
72
73 GDB 9.0.90 released.
74
75 2019-12-11 Joel Brobecker <brobecker@adacore.com>
76
77 * version.in: Set GDB version number to 9.0.90.
78
79 2019-12-11 Joel Brobecker <brobecker@adacore.com>
80
81 * NEWS: Change "Changes since GDB 8.3" into "Changes in GDB 9".
82
83 2019-12-11 Joel Brobecker <brobecker@adacore.com>
84
85 GDB 9 branch created (27f7b2f64062ac9e52afc60509263c2702a9ebd0):
86 * version.in: Bump version to 9.0.90.DATE-git.
87
88 2019-12-11 Tom Tromey <tromey@adacore.com>
89
90 PR build/25268:
91 * gdbsupport/thread-pool.c (set_thread_name): New function.
92 (thread_pool::set_thread_count): Don't call pthread_setname_np.
93 (thread_pool::thread_function): Call set_thread_name.
94
95 2019-12-11 Tom Tromey <tromey@adacore.com>
96
97 * fbsd-tdep.c (fbsd_core_info_proc_status): Cast result of
98 bfd_get_signed_8.
99
100 2019-12-11 Philippe Waroquiers <philippe.waroquiers@skynet.be>
101
102 * NEWS: Document -raw-values option and the related setting commands.
103 * printcmd.c (print_command_parse_format): Do not set opts->raw off,
104 only set it on when /r is given.
105 * valprint.c (value_print_option_defs): New element raw-values.
106 * Makefile.in: Add the new file.
107
108 2019-12-10 Christian Biesinger <cbiesinger@google.com>
109
110 * gdbsupport/safe-strerror.c: Supress the unused function warning
111 for select_strerror_r.
112
113 2019-12-10 Christian Biesinger <cbiesinger@google.com>
114
115 * config.in: Regenerate.
116 * configure: Regenerate.
117 * gdbsupport/agent.c (gdb_connect_sync_socket): Call
118 safe_strerror instead of strerror.
119 * gdbsupport/common.m4: Don't check for strerror.
120 * gdbsupport/safe-strerror.c: Support both the glibc version
121 of strerror_r and the XSI version.
122
123 2019-12-10 Tom Tromey <tromey@adacore.com>
124
125 * ada-typeprint.c (print_choices): Use a single "?".
126 (print_variant_part): Print "?" if the discriminant name
127 is not known.
128
129 2019-12-10 George Barrett <bob@bob131.so>
130
131 Fix scripted probe breakpoints.
132 * breakpoint.c (tracepoint_probe_breakpoint_ops): Move
133 declaration forward.
134 (breakpoint_ops_for_event_location_type)
135 (breakpoint_ops_for_event_location): Add function definitions.
136 (break_command_1, trace_command): Use
137 breakpoint_ops_for_event_location.
138 * breakpoint.h (breakpoint_ops_for_event_location): Add function
139 declarations.
140 * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Use
141 breakpoint_ops_for_event_location.
142 * python/py-breakpoint.c (bppy_init): Use
143 breakpoint_ops_for_event_location.
144
145 2019-12-09 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
146
147 * gdbtypes.c (rank_one_type): Return INCOMPATIBLE_TYPE_BADNESS
148 when ranking an lvalue argument for an rvalue parameter.
149
150 2019-12-08 Wataru Ashihara <wataash@wataash.com>
151
152 * darwin-nat.c (darwin_nat_target::create_inferior): Fix
153 template argument for scoped_restore_tmpl from bool to int.
154
155 2019-12-07 Keith Seitz <keiths@redhat.com>
156
157 * build-id.c (build_id_bfd_get): Permit bfd_core, too.
158 (build_id_to_debug_bfd): Make static, rewriting to use
159 build_id_to_bfd_suffix.
160 (build_id_to_bfd_suffix): Copy of build_id_to_debug_bfd,
161 adding `suffix' parameter. Append SUFFIX to file names
162 when searching for matching files.
163 (build_id_to_debug_bfd): Use build_id_to_bfd_suffix.
164 (build_id_to_exec_bfd): Likewise.
165 * build-id.h (build_id_to_debug_bfd): Clarify that function
166 searches for BFD of debug info file.
167 (build_id_to_exec_bfd): Declare.
168 * corelow.c: Include build-id.h.
169 (locate_exec_from_corefile_build_id): New function.
170 (core_target_open): If no executable BFD is found,
171 search for a core file BFD using build-id.
172
173 2019-12-06 Christian Biesinger <cbiesinger@google.com>
174
175 * bcache.c: Put in namespace gdb.
176 * bcache.h: Likewise.
177 * gdbtypes.c (check_types_worklist): Update.
178 (types_deeply_equal): Update.
179 * macrotab.c (struct macro_table) <bcache>: Update.
180 (new_macro_table): Update.
181 * macrotab.h (struct bcache): Put this forward declaration
182 inside namespace gdb.
183 (new_macro_table): Update.
184 * objfiles.h (struct objfile_per_bfd_storage) <filename_cache>:
185 Update.
186 <macro_cache>: Update.
187 * psymtab.h: (psymtab_storage) <psymbol_cache>: Update.
188
189 2019-12-06 Tom de Vries <tdevries@suse.de>
190
191 PR symtab/24971
192 * block.c (best_symbol, better_symbol): New function.
193 (block_lookup_symbol_primary, block_lookup_symbol): Prefer def over
194 decl.
195
196 2019-12-06 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
197
198 * gdbtypes.h: Define the REFERENCE_SEE_THROUGH_BADNESS value.
199 * gdbtypes.c (rank_one_type): Use REFERENCE_SEE_THROUGH_BADNESS
200 for ranking see-through reference cases.
201
202 2019-12-06 Philippe Waroquiers <philippe.waroquiers@skynet.be>
203 * stack.c (faas_command): Check a command is provided.
204 * thread.c (taas_command, tfaas_command): Likewise.
205
206 2019-12-05 Philippe Waroquiers <philippe.waroquiers@skynet.be>
207 * inferior.c (prune_inferiors): Only call delete_inferior,
208 Do not modify the inferior list.
209
210 2019-12-05 Simon Marchi <simon.marchi@polymtl.ca>
211
212 * c-exp.y: Update calls to lookup_typename,
213 lookup_signed_typename and lookup_unsigned_typename.
214 * c-lang.c (evaluate_subexp_c): Likewise.
215 * cp-namespace.c (cp_lookup_symbol_imports_or_template):
216 Likewise.
217 * eval.c (binop_promote): Likewise.
218 * gdbtypes.c (lookup_typename): Remove gdbarch parameter.
219 (lookup_unsigned_typename): Likewise.
220 (lookup_signed_typename): Likewise.
221 * gdbtypes.h (lookup_unsigned_typename): Likewise.
222 (lookup_signed_typename): Likewise.
223 (lookup_typename): Likewise.
224 * guile/scm-type.c (tyscm_lookup_typename): Update calls to
225 lookup_typename, lookup_signed_typename,
226 lookup_unsigned_typename.
227 * m2-exp.y: Likewise.
228 * printcmd.c (printf_wide_c_string): Likewise.
229 (ui_printf): Likewise.
230 * python/py-type.c (typy_lookup_typename): Likewise.
231 * python/py-xmethods.c (python_xmethod_worker::invoke):
232 Likewise.
233 * rust-exp.y: Likewise.
234
235 2019-12-04 Christian Biesinger <cbiesinger@google.com>
236
237 * configure.nat (obsd64): Add missing files x86-nat.o and
238 nat/x86-dregs.o.
239
240 2019-12-04 Tom Tromey <tom@tromey.com>
241
242 * valprint.c (val_print_string): Use metadata_style.
243 * go-valprint.c (print_go_string): Use metadata style.
244 * p-valprint.c (pascal_object_print_static_field): Use metadata
245 style.
246 * cp-valprint.c (cp_print_static_field): Use metadata style.
247
248 2019-12-04 Andrew Burgess <andrew.burgess@embecosm.com>
249 Chris January <chris.january@arm.com>
250
251 * f-exp.y (COMPLEX_KEYWORD, SINGLE, DOUBLE, PRECISION): New
252 tokens.
253 (typebase): New patterns for complex, single/double precision, and
254 single/double complex.
255 (f77_keywords): Change token for complex keyword, and add single,
256 double, and precision keywords.
257
258 2019-12-04 Simon Marchi <simon.marchi@polymtl.ca>
259
260 * avr-tdep.c (_initialize_avr_tdep): Improve help of command
261 "info io_registers".
262
263 2019-12-04 Simon Marchi <simon.marchi@polymtl.ca>
264
265 * regcache.c (cooked_read_test): Initialize thread list of
266 mock_inferior.
267
268 2019-12-04 Simon Marchi <simon.marchi@polymtl.ca>
269
270 * aarch64-linux-tdep.c: Remove includes.
271
272 2019-12-04 Simon Marchi <simon.marchi@polymtl.ca>
273
274 * aarch64-tdep.c: Remove includes.
275
276 2019-12-04 Simon Marchi <simon.marchi@efficios.com>
277
278 * filtered-iterator.h (filtered_iterator) <operator==,
279 operator!=>: Compare wrapped iterators, not wrapped pointers.
280 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
281 unittests/filtered_iterator-selftests.c.
282 * unittests/filtered_iterator-selftests.c: New file.
283
284 2019-12-04 Tom Tromey <tromey@adacore.com>
285
286 * gdbtypes.c (create_range_type): Inherit endianity
287 from base type.
288
289 2019-12-04 Tom Tromey <tromey@adacore.com>
290
291 * ada-lang.c (decode_constrained_packed_array)
292 (ada_value_assign, value_assign_to_component): Update.
293 * dwarf2loc.c (rw_pieced_value, access_memory)
294 (dwarf2_compile_expr_to_ax): Update.
295 * dwarf2read.c (dwarf2_add_field): Update.
296 * eval.c (evaluate_subexp_standard): Update.
297 * gdbarch.c, gdbarch.h: Rebuild.
298 * gdbarch.sh (bits_big_endian): Remove.
299 * gdbtypes.h (union field_location): Update comment.
300 * target-descriptions.c (make_gdb_type): Update.
301 * valarith.c (value_bit_index): Update.
302 * value.c (struct value) <bitpos>: Update comment.
303 (unpack_bits_as_long, modify_field): Update.
304 * value.h (value_bitpos): Update comment.
305
306 2019-12-04 Tom Tromey <tromey@adacore.com>
307
308 * gdbtypes.c (type_byte_order): Move earlier. Assert for unknown
309 endian-ness.
310
311 2019-12-04 Tom Tromey <tromey@adacore.com>
312
313 * dwarf2read.c (dwarf2_init_float_type)
314 (dwarf2_init_complex_target_type): Add byte_order parameter.
315 (read_base_type): Compute byte order earlier.
316 * gdbtypes.c (init_float_type): Add byte_order parameter.
317 * gdbtypes.h (init_float_type): Add byte_order parameter.
318
319 2019-12-04 Tom Tromey <tromey@adacore.com>
320
321 * unittests/tui-selftests.c: Conditionally include tui-winsource.h.
322
323 2019-12-04 Tom Tromey <tromey@adacore.com>
324
325 * dwarf2read.c (process_structure_scope): Initialize
326 "discr_offset".
327
328 2019-12-04 Andrew Burgess <andrew.burgess@embecosm.com>
329
330 * mi/mi-symbol-cmds.c (mi_symbol_info): Take extra parameter, and
331 add it into the search spec.
332 (parse_max_results_option): New function.
333 (mi_info_functions_or_variables): Parse -max-results flag and pass
334 it to mi_symbol_info.
335 (mi_cmd_symbol_info_modules): Likewise.
336 (mi_cmd_symbol_info_types): Likewise.
337 * symtab.c (global_symbol_searcher::add_matching_symbols): Change
338 return type to bool, change result container into a set, and don't
339 add new results if we have enough already.
340 (global_symbol_searcher::add_matching_msymbols): Change return
341 type to bool, and don't add new results if we have enough already.
342 (sort_search_symbols_remove_dups): Delete.
343 (global_symbol_searcher::search): Early exit from search loop when
344 we have enough results. Use a std::set to collect the results
345 from calling add_matching_symbols.
346 * symtab.h (global_symbol_searcher) <set_max_seach_results>: New
347 member function.
348 (global_symbol_searcher) <m_max_search_results>: New member
349 variable.
350 (global_symbol_searcher) <add_matching_symbols>: Update header
351 comment and change return type to bool.
352 (global_symbol_searcher) <add_matching_msymbols>: Update header
353 comment and change return type to bool.
354
355 2019-12-04 Andrew Burgess <andrew.burgess@embecosm.com>
356
357 * symtab.c (symbol_search::compare_search_syms): Update header
358 comment.
359 (global_symbol_searcher::is_suitable_msymbol): New function.
360 (global_symbol_searcher::expand_symtabs): New function.
361 (global_symbol_searcher::add_matching_symbols): New function.
362 (global_symbol_searcher::add_matching_msymbols): New function.
363 (global_symbol_searcher::search): Move most of the content
364 into the new functions above, and call them as needed.
365 * symtab.h (global_symbol_searcher) <expand_symtabs>: New member
366 function.
367 (global_symbol_searcher) <add_matching_symbols>: New member
368 function.
369 (global_symbol_searcher) <add_matching_msymbols>: New member
370 function.
371 (global_symbol_searcher) <is_suitable_msymbol>: New member
372 function.
373
374 2019-12-04 Andrew Burgess <andrew.burgess@embecosm.com>
375
376 * mi/mi-cmds.c (mi_cmds): Add -symbol-info-module-functions and
377 -symbol-info-module-variables entries.
378 * mi/mi-cmds.h (mi_cmd_symbol_info_module_functions): Declare.
379 (mi_cmd_symbol_info_module_variables): Declare.
380 * mi/mi-symbol-cmds.c
381 (module_symbol_search_iterator): New typedef.
382 (output_module_symbols_in_single_module_and_file): New function.
383 (output_module_symbols_in_single_module): New function.
384 (mi_info_module_functions_or_variables): New function.
385 (mi_cmd_symbol_info_module_functions): New function.
386 (mi_cmd_symbol_info_module_variables): New function.
387 * NEWS: Mention new MI command.
388
389 2019-12-03 Christian Biesinger <cbiesinger@google.com>
390
391 * bcache.c (hash): Remove.
392 (hash_continue): Remove.
393 * bcache.h (hash): Remove.
394 (hash_continue): Remove.
395 (struct bcache) <ctor>: Update.
396 * psymtab.c (psymbol_hash): Update.
397 * stabsread.c (hashname): Update.
398 * utils.h (fast_hash): Add an argument for a start value,
399 defaulting to zero.
400
401 2019-12-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
402 * symtab.c (symbol_cache_clear_slot): Move close to cleared type.
403 (destroy_block_symbol_cache): New function.
404 (symbol_cache:~symbol_cache) Call destroy_block_symbol_cache.
405 (resize_symbol_cache): Likewise.
406
407 2019-12-02 Tom Tromey <tom@tromey.com>
408
409 * unittests/tui-selftests.c (run_tests): Make conditional.
410 (_initialize_tui_selftest): Make conditional.
411
412 2019-12-02 Christian Biesinger <cbiesinger@google.com>
413
414 * aix-thread.c (debug_aix_thread): Change type to bool.
415
416 2019-12-02 Luis Machado <luis.machado@linaro.org>
417
418 * infrun.c (follow_fork_inferior): Remove outdated FIXME comment.
419
420 2019-12-01 Andrew Burgess <andrew.burgess@embecosm.com>
421
422 * dwarf2read.c (read_tag_string_type): Read the fields required to
423 make a dynamic string, and possibly create a dynamic range for the
424 string.
425 (attr_to_dynamic_prop): Setup is_reference based on the type of
426 attribute being processed.
427 * gdbtypes.c (is_dynamic_type_internal): Handle TYPE_CODE_STRING.
428 (resolve_dynamic_array): Rename to...
429 (resolve_dynamic_array_or_string): ...this, update header comment,
430 and accept TYPE_CODE_STRING.
431 (resolve_dynamic_type_internal): Handle TYPE_CODE_STRING.
432
433 2019-12-01 Andrew Burgess <andrew.burgess@embecosm.com>
434
435 * dwarf2read.c (dwarf2_per_cu_int_type): New function, takes most
436 of its implementation from...
437 (dwarf2_per_cu_addr_sized_int_type): ...here, which now just calls
438 the new function.
439
440 2019-12-01 Andrew Burgess <andrew.burgess@embecosm.com>
441
442 * dwarf2read.c (read_subrange_type): Read bit and byte stride and
443 create a range with stride where appropriate.
444 * f-valprint.c: Include 'gdbarch.h'.
445 (f77_print_array_1): Take the stride into account when walking the
446 array. Also convert the stride into addressable units.
447 * gdbtypes.c (create_range_type): Initialise the stride to
448 constant zero.
449 (create_range_type_with_stride): New function, initialise the
450 range as normal, and then setup the stride.
451 (has_static_range): Include the stride here. Also change the
452 return type to bool.
453 (create_array_type_with_stride): Consider the range stride if the
454 array isn't given its own stride.
455 (resolve_dynamic_range): Resolve the stride if needed.
456 * gdbtypes.h (struct range_bounds) <stride>: New member variable.
457 (struct range_bounds) <flag_is_byte_stride>: New member variable.
458 (TYPE_BIT_STRIDE): Define.
459 (TYPE_ARRAY_BIT_STRIDE): Define.
460 (create_range_type_with_stride): Declare.
461 * valarith.c (value_subscripted_rvalue): Take range stride into
462 account when walking the array.
463
464 2019-12-01 Tom Tromey <tom@tromey.com>
465
466 * tui/tui-win.c (tui_all_windows_info): Treat inactive TUI
467 specially.
468
469 2019-12-01 Tom Tromey <tom@tromey.com>
470
471 * tui/tui-winsource.c (tui_copy_source_line): Don't advance past
472 \0.
473 * unittests/tui-selftests.c: New file.
474 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add tui-selftests.c.
475
476 2019-12-01 Tom Tromey <tom@tromey.com>
477
478 * tui/tui.c (tui_enable): Call tui_update_variables earlier.
479
480 2019-12-01 Tom Tromey <tom@tromey.com>
481
482 * NEWS: Document new settings.
483 * tui/tui-wingeneral.c (box_win): Apply appropriate border style.
484 * tui/tui-win.c (_initialize_tui_win): Add border style
485 observers.
486 * tui/tui-io.h (tui_apply_style): Declare.
487 * tui/tui-io.c (tui_apply_style): Rename from apply_style. No
488 longer static.
489 (apply_ansi_escape, tui_set_reverse_mode): Update.
490 * cli/cli-style.h (class cli_style_option) <add_setshow_commands>:
491 Add "skip_intensity" parameter.
492 <changed>: New member.
493 <do_set_value>: Declare.
494 (tui_border_style, tui_active_border_style): Declare.
495 * cli/cli-style.c (tui_border_style, tui_active_border_style): New
496 globals.
497 (cli_style_option): Initialize "changed".
498 (cli_style_option::do_set_value): New function.
499 (cli_style_option::add_setshow_commands): Add "skip_intensity"
500 parameter. Update.
501 (STYLE_ADD_SETSHOW_COMMANDS): Add "SKIP" parameter.
502 (_initialize_cli_style): Update. Create TUI border style
503 commands.
504
505 2019-12-01 Tom Tromey <tom@tromey.com>
506
507 * tui/tui-winsource.h (tui_copy_source_line): Add "ndigits"
508 parameter.
509 * tui/tui-winsource.c (tui_copy_source_line): Add "ndigits"
510 parameter.
511 * tui/tui-win.h (compact_source): Declare.
512 * tui/tui-win.c (compact_source): New global.
513 (tui_set_compact_source, tui_show_compact_source): New functions.
514 (_initialize_tui_win): Add "compact-source" setting.
515 * tui/tui-source.c (tui_source_window::set_contents): Handle
516 compact_source setting.
517 * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
518 * NEWS: Document new setting.
519
520 2019-11-30 Tom Tromey <tom@tromey.com>
521
522 * dwarf2read.c (dwarf2_add_field): Include field offset when
523 computing variant part length.
524
525 2019-11-30 Philippe Waroquiers <philippe.waroquiers@skynet.be>
526 * NEWS: Mention define-prefix. Tell that command names can now
527 contain a . character.
528
529 2019-11-30 Philippe Waroquiers <philippe.waroquiers@skynet.be>
530
531 * command.h (valid_cmd_char_p): Declare.
532 * cli/cli-decode.c (valid_cmd_char_p): New function factorizing
533 the check of valid command char.
534 (find_command_name_length, valid_user_defined_cmd_name_p): Use
535 valid_cmd_char_p.
536 * cli/cli-script.c (validate_comname): Likewise.
537 * completer.c (gdb_completer_command_word_break_characters):
538 Do not remove . from the word break char, update comments.
539 (complete_line_internal_1): Use valid_cmd_char_p.
540 * guile/scm-cmd.c (gdbscm_parse_command_name): Likewise.
541 * python/py-cmd.c (gdbpy_parse_command_name): Likewise.
542
543 2019-11-30 Philippe Waroquiers <philippe.waroquiers@skynet.be>
544
545 * cli/cli-script.c (do_define_command): Ensure a redefined
546 prefix command is kept as a prefix command.
547 (define_prefix_command): New function.
548 (show_user_1): Report user defined prefixes.
549 (_initialize_cli_script): Create the new 'define-prefix' command.
550 Add completers for 'define' and 'document'.
551 * top.c (execute_command): If command is a user-defined prefix only
552 command, report the list of commands for this prefix command.
553
554 2019-11-29 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
555
556 * valops.c (find_oload_champ): Improve debug output.
557
558 2019-11-29 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
559
560 * valops.c (find_oload_champ): Print part of debug messages
561 before the badness vector is std::move'd.
562
563 2019-11-28 Tom Tromey <tom@tromey.com>
564
565 * value.c (creal_internal_fn): Fix comment.
566
567 2019-11-28 Tom Tromey <tom@tromey.com>
568
569 * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count,
570 flag_bound_evaluated>: Now unsigned.
571
572 2019-11-28 Tom Tromey <tom@tromey.com>
573
574 * guile/guile-internal.h (vlscm_scm_from_value_unsafe): Don't
575 declare.
576
577 2019-11-28 Mihails Strasuns <mihails.strasuns@intel.com>
578
579 * jit.c (jit_bfd_try_read_symtab): Fix printed function name in the
580 debug output.
581 * jit.c (jit_unregister_code): Add debug print to match
582 `jit_register_code`.
583
584 2019-11-27 Christian Biesinger <cbiesinger@google.com>
585
586 * NEWS: Mention the new multithreaded symbol loading.
587
588 2019-11-27 Christian Biesinger <cbiesinger@google.com>
589
590 * maint.c (n_worker_threads): Default to 0.
591 (worker_threads_disabled): New function.
592 * maint.h (worker_threads_disabled): New function.
593 * minsyms.c (minimal_symbol_reader::record_full): Call symbol_set_names
594 here if worker_threads_disabled () is true.
595 (minimal_symbol_reader::install): Skip all threading if
596 worker_threads_disabled () is true.
597
598 2019-11-27 Christian Biesinger <cbiesinger@google.com>
599
600 * minsyms.c (add_minsym_to_hash_table): Use a previously computed
601 hash code if possible.
602 (add_minsym_to_demangled_hash_table): Likewise.
603 (minimal_symbol_reader::install): Compute the hash codes for msymbol
604 on the background thread.
605 * symtab.h (struct minimal_symbol) <hash_value, demangled_hash_value>:
606 Add these fields.
607
608 2019-11-27 Christian Biesinger <cbiesinger@google.com>
609
610 * minsyms.c (minimal_symbol_reader::install): Also compute the hash
611 of the mangled name on the background thread.
612 * symtab.c (symbol_set_names): Allow passing in the hash of the
613 linkage_name.
614 * symtab.h (symbol_set_names): Likewise.
615
616 2019-11-27 Kevin Buettner <kevinb@redhat.com>
617
618 * dwarf2read.c (inherit_abstract_dies): Ensure that delayed
619 physnames are computed for inherited DIEs.
620
621 2019-11-27 Tom Tromey <tromey@adacore.com>
622
623 * dwarf2read.h (struct dwarf2_per_objfile): Remove unnecessary
624 backslashes.
625 * cp-support.c: Remove unnecessary backslashes.
626
627 2019-11-27 Christian Biesinger <cbiesinger@google.com>
628
629 * ada-exp.y (write_ambiguous_var): Replace SYMBOL_SET_LINKAGE_NAME
630 with sym->set_linkage_name.
631 * coffread.c (coff_read_enum_type): Likewise.
632 * mdebugread.c (parse_symbol): Likewise.
633 * stabsread.c (patch_block_stabs): Likewise.
634 (define_symbol): Likewise.
635 (read_enum_type): Likewise.
636 (common_block_end): Likewise.
637 * symtab.h (struct general_symbol_info) <set_linkage_name>: New
638 function.
639 (SYMBOL_SET_LINKAGE_NAME): Remove.
640 * xcoffread.c (process_xcoff_symbol): Replace SYMBOL_SET_LINKAGE_NAME
641 with sym->set_linkage_name.
642
643 2019-11-27 Andrew Burgess <andrew.burgess@embecosm.com>
644
645 * mi/mi-cmds.c (mi_cmds): Add 'symbol-info-modules' entry.
646 * mi/mi-cmds.h (mi_cmd_symbol_info_modules): Declare.
647 * mi/mi-symbol-cmds.c (mi_cmd_symbol_info_modules): New function.
648 * NEWS: Mention new MI command.
649
650 2019-11-27 Andrew Burgess <andrew.burgess@embecosm.com>
651
652 * mi/mi-cmds.c (mi_cmds): Add '-symbol-info-functions',
653 '-symbol-info-types', and '-symbol-info-variables'.
654 * mi/mi-cmds.h (mi_cmd_symbol_info_functions): Declare.
655 (mi_cmd_symbol_info_types): Declare.
656 (mi_cmd_symbol_info_variables): Declare.
657 * mi/mi-symbol-cmds.c: Add 'source.h' and 'mi-getopt.h' includes.
658 (output_debug_symbol): New function.
659 (output_nondebug_symbol): New function.
660 (mi_symbol_info): New function.
661 (mi_info_functions_or_variables): New function.
662 (mi_cmd_symbol_info_functions): New function.
663 (mi_cmd_symbol_info_types): New function.
664 (mi_cmd_symbol_info_variables): New function.
665 * NEWS: Mention new commands.
666
667 2019-11-27 Andrew Burgess <andrew.burgess@embecosm.com>
668
669 * symtab.c (symbol_to_info_string): New function, most content
670 moved from print_symbol_info, but updated to return a std::string.
671 (print_symbol_info): Update to use symbol_to_info_string and print
672 returned string.
673 * symtab.h (symbol_to_info_string): Declare new function.
674
675 2019-11-27 Andrew Burgess <andrew.burgess@embecosm.com>
676
677 * python/python.c (gdbpy_rbreak): Convert to using
678 global_symbol_searcher.
679 * symtab.c (file_matches): Convert return type to bool, change
680 file list to std::vector, update header comment.
681 (search_symbols): Rename to...
682 (global_symbol_searcher::search): ...this and update now its
683 a member function of global_symbol_searcher. Take account of the
684 changes to file_matches.
685 (symtab_symbol_info): Convert to using global_symbol_searcher.
686 (rbreak_command): Likewise.
687 (search_module_symbols): Likewise.
688 * symtab.h (enum symbol_search): Update comment.
689 (search_symbols): Remove declaration.
690 (class global_symbol_searcher): New class.
691
692 2019-11-26 Tom Tromey <tromey@adacore.com>
693
694 * cp-support.c (_initialize_cp_support): Conditionally initialize
695 gdb_demangle_attempt_core_dump.
696
697 2019-11-26 Tom Tromey <tom@tromey.com>
698
699 * python/py-function.c (fnpy_init): Update.
700 * value.h (add_internal_function): Adjust declaration.
701 * value.c (function_destroyer): Remove.
702 (do_add_internal_function): Don't set destroyer or copy name.
703 (add_internal_function): Take unique_xmalloc_ptr<char> for name.
704 Set name_allocated.
705 * python/py-cmd.c (cmdpy_destroyer): Don't free "name".
706 (cmdpy_init): Set name_allocated.
707 * cli/cli-decode.h (struct cmd_list_element) <name_allocated>: New
708 member.
709 (~cmd_list_element): Free "name" if needed.
710
711 2019-11-26 Tom Tromey <tom@tromey.com>
712
713 * value.h (add_internal_function): Add new overload. Move
714 documentation from value.h.
715 * value.c (do_add_internal_function): New function.
716 (add_internal_function): Use it. Add new overload.
717 (function_destroyer): Don't free doc.
718 * python/py-function.c (fnpy_init): Update.
719
720 2019-11-26 Tom Tromey <tom@tromey.com>
721
722 * python/py-cmd.c (cmdpy_destroyer): Don't free "doc".
723 (cmdpy_init): Set "doc_allocated".
724
725 2019-11-26 Tom Tromey <tom@tromey.com>
726
727 * gdbsupport/thread-pool.c (thread_pool::set_thread_count): Set
728 name of worker thread.
729 * gdbsupport/common.m4 (GDB_AC_COMMON): Check for
730 pthread_setname_np.
731 * configure, config.in: Rebuild.
732
733 2019-11-26 Tom Tromey <tom@tromey.com>
734
735 * python/python.c (class gdbpy_gil): New.
736 (struct gdbpy_event): Add constructor, destructor, operator().
737 (gdbpy_post_event): Use run_on_main_thread.
738 (gdbpy_initialize_events): Remove.
739 (do_start_initialization): Update.
740
741 2019-11-26 Tom Tromey <tom@tromey.com>
742
743 * NEWS: Add entry.
744 * maint.c (_initialize_maint_cmds): Add "worker-threads" maint
745 commands. Call update_thread_pool_size.
746 (update_thread_pool_size, maintenance_set_worker_threads): New
747 functions.
748 (n_worker_threads): New global.
749
750 2019-11-26 Christian Biesinger <cbiesinger@google.com>
751 Tom Tromey <tom@tromey.com>
752
753 * minsyms.c (minimal_symbol_reader::install): Use
754 parallel_for_each.
755 * gdbsupport/parallel-for.h: New file.
756 * Makefile.in (HFILES_NO_SRCDIR): Add gdbsupport/parallel-for.h.
757
758 2019-11-26 Christian Biesinger <cbiesinger@google.com>
759 Tom Tromey <tom@tromey.com>
760
761 * gdbsupport/thread-pool.h: New file.
762 * gdbsupport/thread-pool.c: New file.
763 * Makefile.in (COMMON_SFILES): Add thread-pool.c.
764 (HFILES_NO_SRCDIR): Add thread-pool.h.
765
766 2019-11-26 Tom Tromey <tom@tromey.com>
767
768 * event-top.h (thread_local_segv_handler): Declare.
769 * event-top.c (thread_local_segv_handler): New global.
770 (install_handle_sigsegv, handle_sigsegv): New functions.
771 (async_init_signals): Install SIGSEGV handler.
772 * cp-support.c (gdb_demangle_jmp_buf): Change type. Now
773 thread-local.
774 (report_failed_demangle): New function.
775 (gdb_demangle): Make core_dump_allowed atomic. Remove signal
776 handler-setting code, instead use segv_handler. Run warning code
777 on main thread.
778
779 2019-11-26 Tom Tromey <tom@tromey.com>
780
781 * run-on-main-thread.c: New file.
782 * run-on-main-thread.h: New file.
783 * unittests/main-thread-selftests.c: New file.
784 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
785 main-thread-selftests.c.
786 (HFILES_NO_SRCDIR): Add run-on-main-thread.h.
787 (COMMON_SFILES): Add run-on-main-thread.c.
788
789 2019-11-26 Tom Tromey <tom@tromey.com>
790
791 * main.c (setup_alternate_signal_stack): Remove.
792 (captured_main_1): Use gdb::alternate_signal_stack.
793 * gdbsupport/alt-stack.h: New file.
794
795 2019-11-26 Tom Tromey <tom@tromey.com>
796
797 * gdbsupport/signals-state-save-restore.c (original_signal_mask):
798 Remove comment.
799 (save_original_signals_state, restore_original_signals_state): Use
800 gdb_sigmask.
801 * linux-nat.c (block_child_signals, restore_child_signals_mask)
802 (_initialize_linux_nat): Use gdb_sigmask.
803 * guile/guile.c (_initialize_guile): Use block_signals.
804 * Makefile.in (HFILES_NO_SRCDIR): Add gdb-sigmask.h.
805 * gdbsupport/gdb-sigmask.h: New file.
806 * event-top.c (async_sigtstp_handler): Use gdb_sigmask.
807 * cp-support.c (gdb_demangle): Use gdb_sigmask.
808 * gdbsupport/common.m4 (GDB_AC_COMMON): Check for
809 pthread_sigmask.
810 * configure, config.in: Rebuild.
811 * gdbsupport/block-signals.h: New file.
812
813 2019-11-26 Tom Tromey <tom@tromey.com>
814
815 * acinclude.m4: Include ax_pthread.m4.
816 * Makefile.in (PTHREAD_CFLAGS, PTHREAD_LIBS): New variables.
817 (INTERNAL_CFLAGS_BASE): Use PTHREAD_CFLAGS.
818 (CLIBS): Use PTHREAD_LIBS.
819 (aclocal_m4_deps): Add ax_pthread.m4.
820 * config.in, configure: Rebuild.
821 * gdbsupport/common.m4 (GDB_AC_COMMON): Check for std::thread.
822
823 2019-11-26 Tom Tromey <tom@tromey.com>
824
825 * symtab.h (struct minimal_symbol) <name_set>: New member.
826 * minsyms.c (minimal_symbol_reader::record_full): Copy name.
827 Don't call symbol_set_names.
828 (minimal_symbol_reader::install): Call symbol_set_names.
829
830 2019-11-26 Philippe Waroquiers <philippe.waroquiers@skynet.be>
831
832 * python/python.c (gdbpy_enter::~gdbpy_enter): Release GIL after
833 restore_active_ext_lang, as GIL is needed for (indirectly)
834 called PyOS_InterruptOccurred.
835
836 2019-11-26 Simon Marchi <simon.marchi@efficios.com>
837
838 * sparc-nat.c (sparc_xfer_wcookie): Sync declaration with
839 definition.
840
841 2019-11-26 Simon Marchi <simon.marchi@efficios.com>
842
843 * remote-sim.c (simulator_command): Make static, remove
844 declaration.
845
846 2019-11-26 Simon Marchi <simon.marchi@efficios.com>
847
848 * unittests/array-view-selftests.c (check_ptr_size_ctor2): Make
849 static.
850 * unittests/basic_string_view/capacity/1.cc (test01): Likewise.
851 * unittests/basic_string_view/cons/char/1.cc (test01): Likewise.
852 (main): Likewise.
853 * unittests/basic_string_view/cons/char/2.cc (test03): Likewise.
854 (main): Likewise.
855 * unittests/basic_string_view/cons/char/3.cc (test05): Likewise.
856 (main): Likewise.
857 * unittests/basic_string_view/element_access/char/1.cc (test01):
858 Likewise.
859 (main): Likewise.
860 * unittests/basic_string_view/element_access/char/empty.cc (main):
861 Likewise.
862 * unittests/basic_string_view/element_access/char/front_back.cc
863 (test01): Likewise.
864 (main): Likewise.
865 * unittests/basic_string_view/inserters/char/2.cc (test05):
866 Likewise.
867 (main): Likewise.
868 * unittests/basic_string_view/modifiers/remove_prefix/char/1.cc
869 (test01): Likewise.
870 (main): Likewise.
871 * unittests/basic_string_view/modifiers/remove_suffix/char/1.cc
872 (test01): Likewise.
873 (main): Likewise.
874 * unittests/basic_string_view/modifiers/swap/char/1.cc (test01):
875 Likewise.
876 * unittests/basic_string_view/operations/compare/char/1.cc
877 (test01): Likewise.
878 (main): Likewise.
879 * unittests/basic_string_view/operations/compare/char/13650.cc
880 (test01): Likewise.
881 * unittests/basic_string_view/operations/copy/char/1.cc (test01):
882 Likewise.
883 (main): Likewise.
884 * unittests/basic_string_view/operations/data/char/1.cc (test01):
885 Likewise.
886 (main): Likewise.
887 * unittests/basic_string_view/operations/find/char/1.cc (test01):
888 Likewise.
889 (main): Likewise.
890 * unittests/basic_string_view/operations/find/char/2.cc (test02):
891 Likewise.
892 (main): Likewise.
893 * unittests/basic_string_view/operations/find/char/3.cc (test03):
894 Likewise.
895 (main): Likewise.
896 * unittests/basic_string_view/operations/find/char/4.cc (main):
897 Likewise.
898 * unittests/basic_string_view/operations/rfind/char/1.cc (test01):
899 Likewise.
900 (main): Likewise.
901 * unittests/basic_string_view/operations/rfind/char/2.cc (test02):
902 Likewise.
903 (main): Likewise.
904 * unittests/basic_string_view/operations/rfind/char/3.cc (test03):
905 Likewise.
906 (main): Likewise.
907 * unittests/basic_string_view/operations/substr/char/1.cc
908 (test01): Likewise.
909 (main): Likewise.
910 * unittests/basic_string_view/operators/char/2.cc (main):
911 Likewise.
912 * unittests/optional/assignment/1.cc (test): Likewise.
913 * unittests/optional/assignment/2.cc (test): Likewise.
914 * unittests/optional/assignment/3.cc (test): Likewise.
915 * unittests/optional/assignment/4.cc (test): Likewise.
916 * unittests/optional/assignment/5.cc (test): Likewise.
917 * unittests/optional/assignment/6.cc (test): Likewise.
918 * unittests/optional/assignment/7.cc (test): Likewise.
919 * unittests/optional/cons/copy.cc (test): Likewise.
920 * unittests/optional/cons/default.cc (test): Likewise.
921 * unittests/optional/cons/move.cc (test): Likewise.
922 * unittests/optional/cons/value.cc (test): Likewise.
923 * unittests/optional/in_place.cc (test): Likewise.
924 * unittests/optional/observers/1.cc (test): Likewise.
925 * unittests/optional/observers/2.cc (test): Likewise.
926
927 2019-11-26 Simon Marchi <simon.marchi@efficios.com>
928
929 * tui-win.h (tui_set_var_cmd): Remove.
930 * tui-win.c (tui_set_var_cmd): Make static.
931
932 2019-11-26 Simon Marchi <simon.marchi@efficios.com>
933
934 * breakpoint.h (hbreak_command_wrapper, thbreak_command_wrapper,
935 rbreak_command_wrapper): Remove.
936 * symtab.c (rbreak_command_wrapper): Remove.
937
938 2019-11-26 Simon Marchi <simon.marchi@efficios.com>
939
940 * inferior.h (info_terminal_command): Remove declaration.
941 * inflow.c (info_terminal_command): Make static.
942
943 2019-11-26 Simon Marchi <simon.marchi@efficios.com>
944
945 * inferior.c (exit_inferior_silent): Remove.
946
947 2019-11-26 Simon Marchi <simon.marchi@efficios.com>
948
949 * dictionary.c (dict_empty, mdict_empty): Remove.
950 * dictionary.c (mdict_empty): Remove.
951
952 2019-11-26 Simon Marchi <simon.marchi@efficios.com>
953
954 * arc-tdep.c (arc_insn_get_memory_base_reg): Make static.
955 (arc_insn_get_memory_offset): Likewise.
956 (arc_insn_dump): Likewise.
957 * cp-support.c (test_cp_symbol_name_matches): Likewise.
958 * csky-linux-tdep.c (csky_supply_fregset): Likewise.
959 * dictionary.c (dict_iterator_next): Likewise.
960 (dict_iter_match_first): Likewise.
961 (dict_iter_match_next): Likewise.
962 * f-lang.c (evaluate_subexp_f): Likewise.
963 * hppa-tdep.c (hppa_read_pc): Likewise.
964 * i386-tdep.c (i386_floatformat_for_type): Likewise.
965 * parse.c (write_exp_elt_msym): Likewise.
966 * ppc-linux-tdep.c (ppc_floatformat_for_type): Likewise.
967 * remote.c (remote_packet_size): Likewise.
968 (remote_notif_stop_parse): Likewise.
969 * rs6000-aix-tdep.c (aix_sighandle_frame_sniffer): Likewise.
970 * s12z-tdep.c (s12z_disassemble_info): Likewise.
971 * source.c (prepare_path_for_appending): Likewise.
972 * sparc64-linux-tdep.c
973 (sparc64_linux_handle_segmentation_fault); Likewise.
974 * stack.c (frame_selection_by_function_completer): Likewise.
975
976 2019-11-26 Simon Marchi <simon.marchi@efficios.com>
977
978 * completer.c (set_gdb_completion_word_break_characters):
979 Remove.
980
981 2019-11-26 Simon Marchi <simon.marchi@efficios.com>
982
983 * dwarf-index-write.c: Include dwarf-index-write.h.
984 * mi/mi-interp.c: Include mi/mi-interp.h.
985
986 2019-11-26 Simon Marchi <simon.marchi@efficios.com>
987
988 * aarch32-tdep.c: Include aarch32-tdep.h.
989 * aarch32-tdep.h: Forward-declare struct target_desc.
990
991 2019-11-26 Christian Biesinger <cbiesinger@google.com>
992
993 * linux-nat.c (detach_one_lwp): Call safe_strerror instead of
994 strerror.
995 * nto-procfs.c (nto_procfs_target::create_inferior): Likewise.
996 * windows-nat.c (windows_nat_target::create_inferior): Likewise.
997
998 2019-11-25 Tom de Vries <tdevries@suse.de>
999
1000 * contrib/words.sh: Add -c option.
1001
1002 2019-11-25 Christian Biesinger <cbiesinger@google.com>
1003
1004 * solib.c (solib_find_1): Change int to bool.
1005 (exec_file_find): Change int to bool.
1006 (solib_find): Change int to bool.
1007 (solib_read_symbols): Change int to bool.
1008 (solib_used): Change int to bool.
1009 (solib_add): Change int to bool.
1010 (info_sharedlibrary_command): Change int to bool.
1011 (solib_contains_address_p): Change int to bool.
1012 (solib_keep_data_in_core): Change int to bool.
1013 (in_solib_dynsym_resolve_code): Change int to bool.
1014 (reload_shared_libraries_1): Change int to bool.
1015 (gdb_sysroot_changed): Change int to bool.
1016 * solib.h (solib_read_symbols): Change int to bool.
1017 (solib_contains_address_p): Change int to bool.
1018 (solib_keep_data_in_core): Change int to bool.
1019 (in_solib_dynsym_resolve_code): Change int to bool.
1020 (libpthread_name_p): Change int to bool.
1021
1022 2019-11-25 Luis Machado <luis.machado@linaro.org>
1023
1024 * NEWS (New Commands): Mention "set debug remote-packet-max-chars".
1025 * remote.c (REMOTE_DEBUG_MAX_CHAR): Remove.
1026 (remote_packet_max_chars): New static global.
1027 (show_remote_packet_max_chars): New function.
1028 (remote_target::putpkt_binary): Adjust to use new
1029 remote_packet_max_chars option.
1030 (remote_target::getpkt_or_notif_sane_1): Likewise.
1031 (_initialize_remote): Register new remote-packet-max-chars option.
1032
1033 2019-11-24 Simon Marchi <simon.marchi@efficios.com>
1034
1035 * m68k-linux-nat.c: Include gdbarch.h.
1036
1037 2019-11-24 Tom Tromey <tom@tromey.com>
1038
1039 * symfile.c (read_symbols): Update.
1040 * psymtab.c (require_partial_symbols): Change type of "verbose" to
1041 bool.
1042 (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
1043 (psym_lookup_symbol, psym_find_last_source_symtab)
1044 (psym_forget_cached_source_info, psym_print_stats)
1045 (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
1046 (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
1047 (psym_map_matching_symbols, psym_expand_symtabs_matching)
1048 (psym_find_compunit_symtab_by_address)
1049 (maintenance_print_psymbols, maintenance_info_psymtabs)
1050 (maintenance_check_psymtabs): Update.
1051 * psymtab.h (require_partial_symbols): Change type of "verbose" to
1052 bool.
1053
1054 2019-11-22 Tom Tromey <tom@tromey.com>
1055
1056 * observable.h: Update comments.
1057
1058 2019-11-22 Tom Tromey <tromey@adacore.com>
1059
1060 * ada-tasks.c (ada_task_is_alive): Make parameter const.
1061 (print_ada_task_info): Don't try to fetch thread id if task is not
1062 alive.
1063
1064 2019-11-22 Christian Biesinger <cbiesinger@google.com>
1065
1066 * ada-exp.y: Update.
1067 * ada-lang.c (sort_choices): Update.
1068 (ada_print_symbol_signature): Update.
1069 (resolve_subexp): Update.
1070 (ada_parse_renaming): Update.
1071 (ada_read_renaming_var_value): Update.
1072 (lesseq_defined_than): Update.
1073 (remove_extra_symbols): Update.
1074 (remove_irrelevant_renamings): Update.
1075 (ada_add_block_symbols): Update.
1076 (ada_collect_symbol_completion_matches): Update.
1077 (ada_is_renaming_symbol): Update.
1078 (aggregate_assign_from_choices): Update.
1079 (ada_evaluate_subexp): Update.
1080 (ada_has_this_exception_support): Update.
1081 (ada_is_non_standard_exception_sym): Update.
1082 (ada_add_exceptions_from_frame): Update.
1083 (ada_add_global_exceptions): Update.
1084 (ada_print_subexp): Update.
1085 * ax-gdb.c (gen_var_ref): Update.
1086 (gen_maybe_namespace_elt): Update.
1087 (gen_expr_for_cast): Update.
1088 (gen_expr): Update.
1089 * block.h: Update.
1090 * blockframe.c (find_pc_partial_function): Update.
1091 * breakpoint.c (print_breakpoint_location): Update.
1092 (update_static_tracepoint): Update.
1093 * btrace.c (ftrace_print_function_name): Update.
1094 (ftrace_function_switched): Update.
1095 * buildsym.c (find_symbol_in_list): Update.
1096 * c-exp.y: Update.
1097 * c-typeprint.c (c_print_typedef): Update.
1098 (c_type_print_template_args): Update.
1099 * cli/cli-cmds.c (edit_command): Update.
1100 (list_command): Update.
1101 (print_sal_location): Update.
1102 * coffread.c (patch_opaque_types): Update.
1103 (process_coff_symbol): Update.
1104 (coff_read_enum_type): Update.
1105 * compile/compile-c-symbols.c (c_symbol_substitution_name): Update.
1106 (convert_one_symbol): Update.
1107 (hash_symname): Update.
1108 (eq_symname): Update.
1109 * compile/compile-cplus-symbols.c (convert_one_symbol): Update.
1110 * compile/compile-cplus-types.c (debug_print_scope): Update.
1111 * compile/compile-loc2c.c (do_compile_dwarf_expr_to_c): Update.
1112 * compile/compile-object-load.c (get_out_value_type): Update.
1113 * cp-namespace.c (cp_scan_for_anonymous_namespaces): Update.
1114 (search_symbol_list): Update.
1115 (cp_lookup_symbol_imports_or_template): Update.
1116 * cp-support.c (overload_list_add_symbol): Update.
1117 * ctfread.c (psymtab_to_symtab): Update.
1118 * dbxread.c (cp_set_block_scope): Update.
1119 * dictionary.c (iter_match_first_hashed): Update.
1120 (iter_match_next_hashed): Update.
1121 (insert_symbol_hashed): Update.
1122 (iter_match_next_linear): Update.
1123 * dictionary.h: Update.
1124 * dwarf2loc.c (func_get_frame_base_dwarf_block): Update.
1125 (locexpr_describe_location_piece): Update.
1126 (locexpr_describe_location_1): Update.
1127 (locexpr_generate_c_location): Update.
1128 (loclist_describe_location): Update.
1129 (loclist_generate_c_location): Update.
1130 * dwarf2read.c (dw2_debug_names_lookup_symbol): Update.
1131 (read_func_scope): Update.
1132 (process_enumeration_scope): Update.
1133 (new_symbol): Update.
1134 (dwarf2_const_value): Update.
1135 (dwarf2_symbol_mark_computed): Update.
1136 * eval.c (evaluate_funcall): Update.
1137 (evaluate_subexp_standard): Update.
1138 * expprint.c (print_subexp_standard): Update.
1139 (dump_subexp_body_standard): Update.
1140 * f-valprint.c (info_common_command_for_block): Update.
1141 * findvar.c (get_hosting_frame): Update.
1142 (default_read_var_value): Update.
1143 * go-lang.c (go_symbol_package_name): Update.
1144 * guile/scm-block.c (bkscm_print_block_smob): Update.
1145 * guile/scm-symbol.c (syscm_print_symbol_smob): Update.
1146 (gdbscm_symbol_name): Update.
1147 (gdbscm_symbol_linkage_name): Update.
1148 (gdbscm_symbol_print_name): Update.
1149 * infcall.c (get_function_name): Update.
1150 * infcmd.c (jump_command): Update.
1151 (finish_command): Update.
1152 * infrun.c (insert_exception_resume_breakpoint): Update.
1153 * linespec.c (canonicalize_linespec): Update.
1154 (create_sals_line_offset): Update.
1155 (convert_linespec_to_sals): Update.
1156 (complete_label): Update.
1157 (find_label_symbols_in_block): Update.
1158 * m2-typeprint.c (m2_print_typedef): Update.
1159 * mdebugread.c (mdebug_reg_to_regnum): Update.
1160 (parse_symbol): Update.
1161 (mylookup_symbol): Update.
1162 * mi/mi-cmd-stack.c (list_arg_or_local): Update.
1163 (list_args_or_locals): Update.
1164 * objc-lang.c (compare_selectors): Update.
1165 (info_selectors_command): Update.
1166 (compare_classes): Update.
1167 (info_classes_command): Update.
1168 (find_imps): Update.
1169 * p-typeprint.c (pascal_print_typedef): Update.
1170 * printcmd.c (build_address_symbolic): Update.
1171 (info_address_command): Update.
1172 (print_variable_and_value): Update.
1173 * python/py-framefilter.c (extract_sym): Update.
1174 (py_print_single_arg): Update.
1175 * python/py-symbol.c (sympy_str): Update.
1176 (sympy_get_name): Update.
1177 (sympy_get_linkage_name): Update.
1178 * python/python.c (gdbpy_rbreak): Update.
1179 * record-btrace.c (btrace_get_bfun_name): Update.
1180 (btrace_call_history): Update.
1181 * rust-lang.c (rust_print_typedef): Update.
1182 * solib-frv.c (frv_fdpic_find_canonical_descriptor): Update.
1183 * stabsread.c (stab_reg_to_regnum): Update.
1184 (define_symbol): Update.
1185 (read_enum_type): Update.
1186 (common_block_end): Update.
1187 (cleanup_undefined_types_1): Update.
1188 (scan_file_globals): Update.
1189 * stack.c (print_frame_arg): Update.
1190 (print_frame_args): Update.
1191 (find_frame_funname): Update.
1192 (info_frame_command_core): Update.
1193 (iterate_over_block_locals): Update.
1194 (print_block_frame_labels): Update.
1195 (do_print_variable_and_value): Update.
1196 (iterate_over_block_arg_vars): Update.
1197 (return_command): Update.
1198 * symmisc.c (dump_symtab_1): Update.
1199 (print_symbol): Update.
1200 * symtab.c (eq_symbol_entry): Update.
1201 (symbol_cache_dump): Update.
1202 (lookup_language_this): Update.
1203 (find_pc_sect_line): Update.
1204 (skip_prologue_sal): Update.
1205 (symbol_search::compare_search_syms): Update.
1206 (treg_matches_sym_type_name): Update.
1207 (search_symbols): Update.
1208 (print_symbol_info): Update.
1209 (rbreak_command): Update.
1210 (completion_list_add_symbol): Update.
1211 (find_gnu_ifunc): Update.
1212 (get_symbol_address): Update.
1213 (search_module_symbols): Update.
1214 (info_module_subcommand): Update.
1215 * symtab.h (SYMBOL_NATURAL_NAME): Remove.
1216 (SYMBOL_LINKAGE_NAME): Remove.
1217 (SYMBOL_DEMANGLED_NAME): Remove.
1218 (SYMBOL_PRINT_NAME): Remove.
1219 (SYMBOL_SEARCH_NAME): Remove.
1220 * tracepoint.c (set_traceframe_context): Update.
1221 (validate_actionline): Update.
1222 (collection_list::collect_symbol): Update.
1223 (encode_actions_1): Update.
1224 (info_scope_command): Update.
1225 (print_one_static_tracepoint_marker): Update.
1226 * typeprint.c (typedef_hash_table::add_template_parameters): Update.
1227 * valops.c (address_of_variable): Update.
1228 (find_overload_match): Update.
1229 (find_oload_champ): Update.
1230
1231 2019-11-22 Christian Biesinger <cbiesinger@google.com>
1232
1233 * ada-lang.c (ada_lookup_simple_minsym): Update.
1234 (ada_collect_symbol_completion_matches): Update.
1235 * ada-tasks.c (read_atcb): Update.
1236 * amd64-windows-tdep.c (amd64_skip_main_prologue): Update.
1237 (amd64_windows_skip_trampoline_code): Update.
1238 * arm-tdep.c (skip_prologue_function): Update.
1239 (arm_skip_stack_protector): Update.
1240 * arm-wince-tdep.c (arm_pe_skip_trampoline_code): Update.
1241 (arm_wince_skip_main_prologue): Update.
1242 * ax-gdb.c (gen_expr): Update.
1243 * block.c (call_site_for_pc): Update.
1244 * blockframe.c (find_pc_partial_function): Update.
1245 * breakpoint.c (set_breakpoint_location_function): Update.
1246 * btrace.c (ftrace_print_function_name): Update.
1247 (ftrace_function_switched): Update.
1248 * c-valprint.c (print_unpacked_pointer): Update.
1249 * coffread.c (coff_symfile_read): Update.
1250 * compile/compile-c-symbols.c (convert_symbol_bmsym): Update.
1251 * compile/compile-cplus-symbols.c (convert_symbol_bmsym): Update.
1252 * dwarf-index-write.c (write_psymbols): Update.
1253 * dwarf2loc.c (call_site_to_target_addr): Update.
1254 (func_verify_no_selftailcall): Update.
1255 (tailcall_dump): Update.
1256 (call_site_find_chain_1): Update.
1257 (dwarf_expr_reg_to_entry_parameter): Update.
1258 * elfread.c (elf_gnu_ifunc_record_cache): Update.
1259 * eval.c (evaluate_funcall): Update.
1260 (evaluate_subexp_standard): Update.
1261 (evaluate_subexp_for_sizeof): Update.
1262 * expprint.c (print_subexp_standard): Update.
1263 (dump_subexp_body_standard): Update.
1264 * frame.c (get_prev_frame_always_1): Update.
1265 * frv-tdep.c (frv_skip_main_prologue): Update.
1266 * gnu-v2-abi.c (gnuv2_value_rtti_type): Update.
1267 * gnu-v3-abi.c (gnuv3_rtti_type): Update.
1268 (gnuv3_get_typename_from_type_info): Update.
1269 (gnuv3_skip_trampoline): Update.
1270 * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
1271 * i386-tdep.c (i386_skip_main_prologue): Update.
1272 (i386_pe_skip_trampoline_code): Update.
1273 * ia64-tdep.c (ia64_convert_from_func_ptr_addr): Update.
1274 * infcall.c (get_function_name): Update.
1275 * linespec.c (minsym_found): Update.
1276 * linux-fork.c (info_checkpoints_command): Update.
1277 * m32c-tdep.c (m32c_m16c_address_to_pointer): Update.
1278 (m32c_m16c_pointer_to_address): Update.
1279 * maint.c (maintenance_translate_address): Update.
1280 * minsyms.c (add_minsym_to_hash_table): Update.
1281 (add_minsym_to_demangled_hash_table): Update.
1282 (lookup_minimal_symbol_mangled): Update.
1283 (lookup_minimal_symbol_demangled): Update.
1284 (lookup_minimal_symbol_linkage): Update.
1285 (lookup_minimal_symbol_text): Update.
1286 (lookup_minimal_symbol_by_pc_name): Update.
1287 (minimal_symbol_is_less_than): Update.
1288 (compact_minimal_symbols): Update.
1289 (build_minimal_symbol_hash_tables): Update.
1290 (find_solib_trampoline_target): Update.
1291 * mips-tdep.c (mips_stub_frame_sniffer): Update.
1292 (mips_skip_pic_trampoline_code): Update.
1293 * msp430-tdep.c (msp430_skip_trampoline_code): Update.
1294 * objc-lang.c (info_selectors_command): Update.
1295 (info_classes_command): Update.
1296 (find_methods): Update.
1297 (find_imps): Update.
1298 * p-valprint.c (pascal_val_print): Update.
1299 * ppc-linux-tdep.c (powerpc_linux_in_dynsym_resolve_code): Update.
1300 * ppc-sysv-tdep.c (convert_code_addr_to_desc_addr): Update.
1301 * printcmd.c (build_address_symbolic): Update.
1302 (info_symbol_command): Update.
1303 * psymtab.c (psymbol_name_matches): Update.
1304 (match_partial_symbol): Update.
1305 (lookup_partial_symbol): Update.
1306 (print_partial_symbols): Update.
1307 (sort_pst_symbols): Update.
1308 (maintenance_check_psymtabs): Update.
1309 * python/py-framefilter.c (py_print_frame): Update.
1310 * python/python.c (gdbpy_rbreak): Update.
1311 * record-btrace.c (btrace_get_bfun_name): Update.
1312 (btrace_call_history): Update.
1313 * rs6000-tdep.c (rs6000_skip_main_prologue): Update.
1314 (rs6000_skip_trampoline_code): Update.
1315 * sol-thread.c (info_cb): Update.
1316 * stabsread.c (scan_file_globals): Update.
1317 * stack.c (find_frame_funname): Update.
1318 (info_frame_command_core): Update.
1319 * symmisc.c (dump_msymbols): Update.
1320 * symtab.c (symbol_natural_name): Rename to..,
1321 (general_symbol_info::natural_name): ...this.
1322 (symbol_demangled_name): Rename to...
1323 (general_symbol_info::demangled_name): ...this.
1324 (symbol_search_name): Rename to...
1325 (general_symbol_info::search_name): ...this.
1326 (symbol_matches_search_name): Update.
1327 (find_pc_sect_line): Update.
1328 (skip_prologue_sal): Update.
1329 (search_symbols): Update.
1330 (print_msymbol_info): Update.
1331 (rbreak_command): Update.
1332 (completion_list_add_msymbol): Update.
1333 (completion_list_objc_symbol): Update.
1334 (get_msymbol_address): Update.
1335 * symtab.h (struct general_symbol_info): Add member functions
1336 natural_name (), linkage_name (), print_name (), demangled_name (),
1337 and search_name ().
1338 (SYMBOL_NATURAL_NAME): Update.
1339 (symbol_natural_name): Move to a member function on general_symbol_info.
1340 (SYMBOL_DEMANGLED_NAME): Update.
1341 (symbol_demangled_name): Move to a member function on
1342 general_symbol_info.
1343 (SYMBOL_SEARCH_NAME): Update.
1344 (symbol_search_name): Move to a member function on general_symbol_info.
1345 (MSYMBOL_NATURAL_NAME): Remove.
1346 (MSYMBOL_LINKAGE_NAME): Remove.
1347 (MSYMBOL_PRINT_NAME): Remove.
1348 (MSYMBOL_DEMANGLED_NAME): Remove.
1349 (MSYMBOL_SEARCH_NAME): Remove.
1350 * x86-tdep.c (x86_in_indirect_branch_thunk): Update.
1351
1352 2019-11-22 Christian Biesinger <cbiesinger@google.com>
1353
1354 * symtab.c (create_demangled_names_hash): Use per_bfd->
1355 minimal_symbol_count for computing the initial size, if greater
1356 than our default size.
1357
1358 2019-11-22 Tom de Vries <tdevries@suse.de>
1359
1360 * contrib/words.sh: Improve words extraction.
1361
1362 2019-11-22 Tom de Vries <tdevries@suse.de>
1363
1364 * contrib/words.sh: Combine sed invocations.
1365
1366 2019-11-21 Christian Biesinger <cbiesinger@google.com>
1367
1368 * Makefile.in: Update.
1369 * demangle.c: Rename to...
1370 * gdb-demangle.c: ..this.
1371 (is_cplus_marker): Change return type to bool.
1372 (_initialize_demangler): Rename to...
1373 (_initialize_gdb_demangle): ...this.
1374 * gdb-demangle.h (is_cplus_marker): Change return type to bool.
1375 * symtab.h (demangle): Remove declaration; instead include
1376 gdb-demangle.h.
1377
1378 2019-11-21 Tom Tromey <tromey@adacore.com>
1379
1380 * gdbsupport/format.c (format_pieces): Parse %I64d.
1381 * unittests/format_pieces-selftests.c (test_windows_formats): New
1382 function.
1383 (run_tests): Call it.
1384
1385 2019-11-21 Peeter Joot <peeter.joot@lzlabs.com>
1386
1387 Byte reverse display of variables with DW_END_big, DW_END_little
1388 (DW_AT_endianity) dwarf attributes if different than the native
1389 byte order.
1390 * ada-lang.c (ada_value_binop):
1391 Use type_byte_order instead of gdbarch_byte_order.
1392 * ada-valprint.c (printstr):
1393 (ada_val_print_string):
1394 * ada-lang.c (value_pointer):
1395 (ada_value_binop):
1396 Use type_byte_order instead of gdbarch_byte_order.
1397 * c-lang.c (c_get_string):
1398 Use type_byte_order instead of gdbarch_byte_order.
1399 * c-valprint.c (c_val_print_array):
1400 Use type_byte_order instead of gdbarch_byte_order.
1401 * cp-valprint.c (cp_print_class_member):
1402 Use type_byte_order instead of gdbarch_byte_order.
1403 * dwarf2loc.c (rw_pieced_value):
1404 Use type_byte_order instead of gdbarch_byte_order.
1405 * dwarf2read.c (read_base_type): Handle DW_END_big,
1406 DW_END_little
1407 * f-lang.c (f_get_encoding):
1408 Use type_byte_order instead of gdbarch_byte_order.
1409 * findvar.c (default_read_var_value):
1410 Use type_byte_order instead of gdbarch_byte_order.
1411 * gdbtypes.c (check_types_equal):
1412 Require matching TYPE_ENDIANITY_NOT_DEFAULT if set.
1413 (recursive_dump_type): Print TYPE_ENDIANITY_BIG,
1414 and TYPE_ENDIANITY_LITTLE if set.
1415 (type_byte_order): new function.
1416 * gdbtypes.h (TYPE_ENDIANITY_NOT_DEFAULT): New macro.
1417 (struct main_type) <flag_endianity_not_default>:
1418 New field.
1419 (type_byte_order): New function.
1420 * infcmd.c (default_print_one_register_info):
1421 Use type_byte_order instead of gdbarch_byte_order.
1422 * p-lang.c (pascal_printstr):
1423 Use type_byte_order instead of gdbarch_byte_order.
1424 * p-valprint.c (pascal_val_print):
1425 Use type_byte_order instead of gdbarch_byte_order.
1426 * printcmd.c (print_scalar_formatted):
1427 Use type_byte_order instead of gdbarch_byte_order.
1428 * solib-darwin.c (darwin_current_sos):
1429 Use type_byte_order instead of gdbarch_byte_order.
1430 * solib-svr4.c (solib_svr4_r_ldsomap):
1431 Use type_byte_order instead of gdbarch_byte_order.
1432 * stap-probe.c (stap_modify_semaphore):
1433 Use type_byte_order instead of gdbarch_byte_order.
1434 * target-float.c (target_float_same_format_p):
1435 Use type_byte_order instead of gdbarch_byte_order.
1436 * valarith.c (scalar_binop):
1437 (value_bit_index):
1438 Use type_byte_order instead of gdbarch_byte_order.
1439 * valops.c (value_cast):
1440 Use type_byte_order instead of gdbarch_byte_order.
1441 * valprint.c (generic_emit_char):
1442 (generic_printstr):
1443 (val_print_string):
1444 Use type_byte_order instead of gdbarch_byte_order.
1445 * value.c (unpack_long):
1446 (unpack_bits_as_long):
1447 (unpack_value_bitfield):
1448 (modify_field):
1449 (pack_long):
1450 (pack_unsigned_long):
1451 Use type_byte_order instead of gdbarch_byte_order.
1452 * findvar.c (unsigned_pointer_to_address):
1453 (signed_pointer_to_address):
1454 (unsigned_address_to_pointer):
1455 (address_to_signed_pointer):
1456 (default_read_var_value):
1457 (default_value_from_register):
1458 Use type_byte_order instead of gdbarch_byte_order.
1459 * gnu-v3-abi.c (gnuv3_make_method_ptr):
1460 Use type_byte_order instead of gdbarch_byte_order.
1461 * riscv-tdep.c (riscv_print_one_register_info):
1462 Use type_byte_order instead of gdbarch_byte_order.
1463
1464 2019-11-21 Simon Marchi <simon.marchi@polymtl.ca>
1465
1466 * top.c (current_ui_gdb_stdout_ptr): Spell out by hand.
1467 (current_ui_gdb_stdin_ptr): Likewise.
1468 (current_ui_gdb_stderr_ptr): Likewise.
1469 (current_ui_gdb_stdlog_ptr): Likewise.
1470 (current_ui_current_uiout_ptr): Likewise.
1471 (gen_ret_current_ui_field_ptr): Remove.
1472
1473 2019-11-21 Tom de Vries <tdevries@suse.de>
1474
1475 PR gdb/24956
1476 * cli/cli-script.c (execute_control_command): Only switch to
1477 INTERP_CONSOLE's ui_out when INTERP_MI is active.
1478
1479 2019-11-19 Tom Tromey <tom@tromey.com>
1480
1481 * tui/tui-win.c (tui_partial_win_by_name): Move from tui-data.c.
1482 Now static. Change type of "name".
1483 (tui_set_win_height_command): Don't copy "arg".
1484 * tui/tui-data.h (tui_partial_win_by_name): Don't declare.
1485 * tui/tui-data.c (tui_partial_win_by_name): Move to tui-win.c.
1486
1487 2019-11-19 Ali Tamur <tamur@google.com>
1488
1489 * dwarf2read.c (dw2_get_file_names_reader): Replace "if (attr)" with
1490 "if (attr != nullptr)".
1491 (dwarf2_find_base_address): Likewise.
1492 (dwarf2_build_include_psymtabs): Likewise.
1493 (read_cutu_die_from_dwo): Likewise.
1494 (read_func_scope): Likewise.
1495 (read_call_site_scope): Likewise.
1496 (dwarf2_get_pc_bounds): Likewise.
1497 (dwarf2_record_block_ranges): Likewise.
1498 (dwarf2_add_field): Likewise.
1499 (dwarf2_add_member_fn): Likewise.
1500 (read_structure_type): Likewise.
1501 (read_enumeration_type): Likewise.
1502 (read_array_type): Likewise.
1503 (read_array_order): Likewise.
1504 (read_set_type): Likewise.
1505 (read_common_block): Likewise.
1506 (read_tag_reference_type): Likewise.
1507 (read_tag_string_type): Likewise.
1508 (read_subroutine_type): Likewise.
1509 (read_base_type): Likewise.
1510 (read_subrange_type): Likewise.
1511 (new_symbol): Likewise.
1512 (prepare_one_comp_unit): Likewise.
1513
1514 2019-11-19 Tom Tromey <tromey@adacore.com>
1515
1516 * windows-nat.c (windows_nat_target::attach): Include GetLastError
1517 result in error when DebugActiveProcess fails.
1518
1519 2019-11-18 Sergio Durigan Junior <sergiodj@redhat.com>
1520 Pedro Alves <palves@redhat.com>
1521
1522 https://bugzilla.redhat.com/show_bug.cgi?id=1765117
1523 * target.c (target_stack::push): Call 'unpush' if there's a
1524 target on top of the stack.
1525
1526 2019-11-18 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1527
1528 * python/py-block.c (blpy_dealloc): Call tp_free.
1529 (blpy_block_syms_dealloc): Likewise.
1530 * python/py-finishbreakpoint.c (bpfinishpy_dealloc): Likewise.
1531 * python/py-inferior.c (infpy_dealloc): Likewise.
1532 * python/py-lazy-string.c (stpy_dealloc): Likewise.
1533 * python/py-linetable.c (ltpy_iterator_dealloc): Likewise.
1534 * python/py-symbol.c (sympy_dealloc): Likewise.
1535 * python/py-symtab.c (stpy_dealloc): Likewise.
1536 * python/py-type.c (typy_iterator_dealloc): Likewise.
1537
1538 2019-11-18 Christian Biesinger <cbiesinger@google.com>
1539
1540 * symtab.h (struct symbol) <owner>: Initialize explicitly in the
1541 constructor instead of using a class initializer.
1542
1543 2019-11-15 Christian Biesinger <cbiesinger@google.com>
1544
1545 * Makefile.in: Replace {posix,mingw}-strerror.c with safe-strerror.c.
1546 * configure: Regenerate.
1547 * configure.ac: Don't source common.host.
1548 * gdbsupport/common.host: Remove.
1549 * gdbsupport/mingw-strerror.c: Remove.
1550 * gdbsupport/posix-strerror.c: Rename to...
1551 * gdbsupport/safe-strerror.c: ...this.
1552
1553 2019-11-15 Christian Biesinger <cbiesinger@google.com>
1554
1555 * maint.c (scoped_command_stats::print_time): Use localtime_r
1556 instead of localtime (provided through gnulib if necessary).
1557 * nat/linux-osdata.c (time_from_time_t): Use ctime_r instead
1558 of ctime.
1559
1560 2019-11-15 Christian Biesinger <cbiesinger@google.com>
1561
1562 * gdbsupport/common-defs.h: Include time.h before pathmax.h to
1563 avoid compile errors.
1564
1565 2019-11-15 Christian Biesinger <cbiesinger@google.com>
1566
1567 * config.in: Regenerate.
1568 * configure: Regenerate.
1569 * gdbsupport/common.m4: No longer check for strerror_r.
1570 * gdbsupport/posix-strerror.c (safe_strerror): Always call the
1571 POSIX version of strerror_r, now that gnulib provides it if
1572 necessary.
1573
1574 2019-11-14 Christian Biesinger <cbiesinger@google.com>
1575
1576 * README (`configure' options): Update.
1577
1578 2019-11-14 Tom Tromey <tromey@adacore.com>
1579
1580 * eval.c (evaluate_subexp_standard) <BINOP_ASSIGN>: Do not pass an
1581 expected type for the RHS if the LHS is a convenience variable.
1582
1583 2019-11-14 Simon Marchi <simon.marchi@polymtl.ca>
1584
1585 * unittests/vec-utils-selftests.c (unordered_remove_tests::obj):
1586 Provide explicit default and copy constructor.
1587
1588 2019-11-14 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1589
1590 * python/py-finishbreakpoint.c (gdbpy_breakpoint_created):
1591 only call Py_INCREF (newbp) in the bppy_pending_object case.
1592
1593 2019-11-13 Tom Tromey <tromey@adacore.com>
1594
1595 PR build/25182:
1596 * psympriv.h (partial_symbol): Remove static assert.
1597 * symtab.h (general_symbol_info, symbol): Remove static assert.
1598
1599 2019-11-12 Andrew Burgess <andrew.burgess@embecosm.com>
1600
1601 * gdbsupport/format.c (format_pieces::format_pieces): Support
1602 printf 'z' size modifier.
1603 * gdbsupport/format.h (enum argclass): Add size_t_arg.
1604 * printcmd.c (ui_printf): Handle size_t_arg.
1605 * ui-out.c (ui_out::vmessage): Likewise.
1606 * unittests/format_pieces-selftests.c (test_format_int_sizes): New
1607 function.
1608 (run_tests): Call test_format_int_sizes.
1609
1610 2019-11-12 Christian Biesinger <cbiesinger@google.com>
1611
1612 * ada-exp.y (write_ambiguous_var): Update.
1613 * buildsym.c (add_symbol_to_list): Update.
1614 * dwarf2read.c (read_variable): Update.
1615 (new_symbol): Update.
1616 * jit.c (finalize_symtab): Update.
1617 * language.c (language_alloc_type_symbol): Update.
1618 * symtab.c (fixup_symbol_section): Update.
1619 (initialize_objfile_symbol_1): Move code to...
1620 (initialize_objfile_symbol): ...here. Remove now-unnecessary memset.
1621 (allocate_symbol): Update.
1622 (allocate_template_symbol): Update.
1623 (get_symbol_address): Update.
1624 * symtab.h (struct symbol): Inherit from general_symbol_info instead
1625 of having as a field, and add a constructor.
1626 (SYMBOL_VALUE): Update.
1627 (SYMBOL_VALUE_ADDRESS): Update.
1628 (SET_SYMBOL_VALUE_ADDRESS): Update.
1629 (SYMBOL_VALUE_BYTES): Update.
1630 (SYMBOL_VALUE_COMMON_BLOCK): Update.
1631 (SYMBOL_BLOCK_VALUE): Update.
1632 (SYMBOL_VALUE_CHAIN): Update.
1633 (SYMBOL_LANGUAGE): Update.
1634 (SYMBOL_SECTION): Update.
1635 (SYMBOL_OBJ_SECTION): Update.
1636 (SYMBOL_SET_LANGUAGE): Update.
1637 (SYMBOL_SET_LINKAGE_NAME): Update.
1638 (SYMBOL_SET_NAMES): Update.
1639 (SYMBOL_NATURAL_NAME): Update.
1640 (SYMBOL_LINKAGE_NAME): Update.
1641 (SYMBOL_DEMANGLED_NAME): Update.
1642 (SYMBOL_SEARCH_NAME): Update.
1643 (SYMBOL_MATCHES_SEARCH_NAME): Update.
1644 (struct symbol): Update.
1645 (struct template_symbol): Update.
1646 (struct rust_vtable_symbol): Update.
1647 * xcoffread.c (SYMBOL_DUP): Update.
1648
1649 2019-11-12 Tom Tromey <tom@tromey.com>
1650
1651 * tui/tui-layout.c (show_layout): Set current_layout.
1652 (show_source_disasm_command, show_data)
1653 (show_source_or_disasm_and_command): Don't set current_layout.
1654
1655 2019-11-12 Tom Tromey <tom@tromey.com>
1656
1657 * tui/tui-layout.c (_initialize_tui_layout): Move to end.
1658
1659 2019-11-12 Tom Tromey <tom@tromey.com>
1660
1661 * tui/tui-win.c (resize_message): New global.
1662 (show_tui_resize_message): New function.
1663 (tui_async_resize_screen): Print message if requested.
1664 (_initialize_tui_win): Add tui-resize-message setting.
1665 * NEWS: Add entry for new commands.
1666
1667 2019-11-11 Tom Tromey <tom@tromey.com>
1668
1669 * tui/tui.c (tui_initialize_readline): Add new bindable readline
1670 functions.
1671
1672 2019-11-11 Christian Biesinger <cbiesinger@google.com>
1673
1674 * nat/linux-osdata.c (user_from_uid): Use getpwuid_r.
1675
1676 2019-11-10 Andrew Burgess <andrew.burgess@embecosm.com>
1677
1678 * python/py-symbol.c (gdbpy_lookup_static_symbols): New
1679 function.
1680 * python/python-internal.h (gdbpy_lookup_static_symbols):
1681 Declare new function.
1682 * python/python.c (python_GdbMethods): Add
1683 gdb.lookup_static_symbols method.
1684 * NEWS: Mention gdb.lookup_static_symbols.
1685
1686 2019-11-10 Andrew Burgess <andrew.burgess@embecosm.com>
1687
1688 * python/py-symbol.c (gdbpy_lookup_static_symbol): Lookup in
1689 static block of current object file first. Also fix typo in
1690 header comment.
1691
1692 2019-11-10 Andrew Burgess <andrew.burgess@embecosm.com>
1693
1694 * stack.c (set_last_displayed_sal): Delete.
1695 (last_displayed_sal_valid): Delete.
1696 (last_displayed_pspace): Delete.
1697 (last_displayed_addr): Delete.
1698 (last_displayed_symtab): Delete.
1699 (last_displayed_line): Delete.
1700 (class last_displayed_symtab_info_type): New.
1701 (last_displayed_symtab_info): New static global variable.
1702 (print_frame_info): Call methods on last_displayed_symtab_info.
1703 (clear_last_displayed_sal): Update header comment, and make use of
1704 last_displayed_symtab_info.
1705 (last_displayed_sal_is_valid): Likewise.
1706 (get_last_displayed_pspace): Likewise.
1707 (get_last_displayed_addr): Likewise.
1708 (get_last_displayed_symtab): Likewise.
1709 (get_last_displayed_line): Likewise.
1710 (get_last_displayed_sal): Likewise.
1711 * stack.h (clear_last_displayed_sal): Update header comment.
1712 (last_displayed_sal_is_valid): Likewise.
1713 (get_last_displayed_pspace): Likewise.
1714 (get_last_displayed_addr): Likewise.
1715 (get_last_displayed_symtab): Likewise.
1716 (get_last_displayed_line): Likewise.
1717 (get_last_displayed_sal): Likewise.
1718
1719 2019-11-10 Andrew Burgess <andrew.burgess@embecosm.com>
1720
1721 * stack.c (frame_show_address): Convert return type to bool.
1722 * stack.h (frame_show_address): Likewise, and update header
1723 comment.
1724
1725 2019-11-10 Andrew Burgess <andrew.burgess@embecosm.com>
1726
1727 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add new file to the list.
1728 * unittests/vec-utils-selftests.c: New file.
1729 * gdbsupport/gdb_vecs.h (unordered_remove): Avoid self move assign.
1730
1731 2019-11-10 Tom Tromey <tom@tromey.com>
1732
1733 * tui/tui-wingeneral.c (tui_unhighlight_win): Use can_box.
1734 (tui_highlight_win): Likewise.
1735 (tui_win_info::check_and_display_highlight_if_needed): Likewise.
1736 * tui/tui-data.h (struct tui_win_info) <can_highlight>: Remove.
1737 * tui/tui-command.h (struct tui_cmd_window) <tui_cmd_window>:
1738 Don't set can_highlight.
1739
1740 2019-11-10 Tom Tromey <tom@tromey.com>
1741
1742 * cli/cli-style.h (class cli_style_option) <cli_style_option>:
1743 Remove unused declaration.
1744
1745 2019-11-08 Tom Tromey <tromey@adacore.com>
1746
1747 * top.c (read_command_file): Update.
1748 (command_line_input): Make return type const.
1749 * python/py-gdb-readline.c: Update.
1750 * linespec.c (decode_line_2): Update.
1751 * defs.h (command_line_input): Make return type const.
1752 * cli/cli-script.c (read_next_line): Make return type const.
1753 * ada-lang.c (get_selections): Update.
1754
1755 2019-11-06 Christian Biesinger <cbiesinger@google.com>
1756
1757 * linux-tdep.c (linux_info_proc): Use strtok_r instead of strtok.
1758 * mi/mi-main.c (output_cores): Likewise.
1759 * nat/linux-osdata.c (linux_xfer_osdata_cpus): Likewise.
1760 (linux_xfer_osdata_modules): Likewise.
1761 * remote.c (register_remote_support_xml): Likewise.
1762 * sparc64-tdep.c (adi_is_addr_mapped): Likewise.
1763 * xml-syscall.c (syscall_create_syscall_desc): Likewise.
1764
1765 2019-11-06 Tom Tromey <tom@tromey.com>
1766
1767 * tui/tui-interp.c: Don't include readline.h.
1768 * tui/tui-hooks.c: Don't include readline.h.
1769 * symmisc.c: Include tilde.h, not readline.h.
1770 * symfile.c: Include tilde.h, not readline.h.
1771 * source.c: Include tilde.h, not readline.h.
1772 * solib.c: Include tilde.h, not readline.h.
1773 * psymtab.c: Include tilde.h, not readline.h.
1774 * exec.c: Include tilde.h, not readline.h.
1775 * corelow.c: Include tilde.h, not readline.h.
1776 * cli/cli-dump.c: Include tilde.h, not readline.h.
1777 * cli/cli-cmds.c: Don't include readline.h.
1778
1779 2019-11-05 Tom Tromey <tom@tromey.com>
1780
1781 * tui/tui-disasm.c (struct tui_asm_line) <addr_size>: New member.
1782 (tui_disassemble): Set addr_size.
1783 (tui_disasm_window::set_contents): Use addr_size.
1784
1785 2019-11-05 Tom Tromey <tom@tromey.com>
1786
1787 * rust-lang.c (rust_language_defn): Update.
1788 * python/py-value.c (valpy_string): Call c_get_string.
1789 * p-lang.c (pascal_language_defn): Update.
1790 * opencl-lang.c (opencl_language_defn): Update.
1791 * objc-lang.c (objc_language_defn): Update.
1792 * m2-lang.c (m2_language_defn): Update.
1793 * language.c (unknown_language_defn, auto_language_defn): Update.
1794 (default_get_string): Remove.
1795 * guile/scm-value.c (gdbscm_value_to_string): Use c_get_string.
1796 * go-lang.c (go_language_defn): Update.
1797 * f-lang.c (f_language_defn): Update.
1798 * d-lang.c (d_language_defn): Update.
1799 * c-lang.c (c_language_defn, cplus_language_defn)
1800 (asm_language_defn, minimal_language_defn): Update.
1801 * ada-lang.c (ada_language_defn): Update.
1802 * language.h (struct language_defn) <la_get_string>: Remove.
1803 (LA_GET_STRING): Remove.
1804 (default_get_string): Don't declare.
1805
1806 2019-11-05 Tom Tromey <tom@tromey.com>
1807
1808 * tui/tui-source.h (struct tui_source_window): Inline
1809 constructor. Remove destructor.
1810 <style_changed, m_observable>: Move to superclass.
1811 * tui/tui-winsource.h (tui_copy_source_line): Declare.
1812 (struct tui_source_window_base): Move private members to end.
1813 <style_changed, m_observable>: Move from tui_source_window.
1814 * tui/tui-winsource.c (tui_copy_source_line): Move from
1815 tui-source.c. Rename from copy_source_line. Add special handling
1816 for negative line number.
1817 (tui_source_window_base::style_changed): Move from
1818 tui_source_window.
1819 (tui_source_window_base): Register observer.
1820 (~tui_source_window_base): New.
1821 * tui/tui-source.c (copy_source_line): Move to tui-winsource.c;
1822 rename.
1823 (tui_source_window::set_contents): Use tui_copy_source_line.
1824 (tui_source_window::tui_source_window): Move to tui-source.h.
1825 (tui_source_window::~tui_source_window): Remove.
1826 (tui_source_window::style_changed): Move to superclass.
1827 * tui/tui-disasm.c (tui_disassemble): Create string file with
1828 styling, when possible. Add "addr_size" parameter.
1829 (tui_disasm_window::set_contents): Use tui_copy_source_line.
1830 Don't compute maximum size.
1831 (len_without_escapes): New function
1832
1833 2019-11-05 Tom Tromey <tom@tromey.com>
1834
1835 * tui/tui-winsource.h (struct tui_source_element) <line>: Now a
1836 std::string.
1837 * tui/tui-winsource.c (tui_show_source_line): Update.
1838 * tui/tui-source.c (tui_source_window::set_contents): Update.
1839 * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
1840
1841 2019-11-05 Christian Biesinger <cbiesinger@google.com>
1842
1843 * symtab.h (gdb_static_assert): Put && operator at the beginning
1844 of the line instead of the end.
1845
1846 2019-11-04 Christian Biesinger <cbiesinger@google.com>
1847
1848 * psympriv.h: Add static_asserts for sizeof (general_symbol_info)
1849 and sizeof (symbol).
1850 * symtab.h: Add a static_assert for sizeof (partial_symbol).
1851
1852 2019-11-04 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
1853
1854 * NEWS (Changes since GDB 8.3): Document Solaris 10 removal.
1855 * configure.host: Mark *-*-solaris2.10* obsolete.
1856 * configure.tgt: Mark Solaris < 11 obsolete.
1857 * MAINTAINERS (Target Instruction Set Architectures) <sparc>:
1858 Update target triplet.
1859
1860 2019-11-01 Tom Tromey <tromey@adacore.com>
1861
1862 * utils.c (print_sys_errmsg): Simplify.
1863
1864 2019-11-01 Tom Tromey <tromey@adacore.com>
1865
1866 * gdbsupport/mingw-strerror.c (safe_strerror): Constify result.
1867
1868 2019-11-01 Christian Biesinger <cbiesinger@google.com>
1869
1870 * configure: Regenerate.
1871 * configure.ac: Remove check for strerror_r.
1872 * gdbsupport/common.m4: Check for strerror_r.
1873
1874 2019-11-01 Luis Machado <luis.machado@linaro.org>
1875
1876 PR gdb/25124
1877
1878 * arm-tdep.c (arm_per_objfile): Rename to ...
1879 (arm_per_bfd): ... this.
1880 (arm_objfile_data_key): Rename to ...
1881 (arm_bfd_data_key): ... this.
1882 (arm_find_mapping_symbol): Adjust access to new bfd_key-based
1883 data.
1884 (arm_record_special_symbol): Likewise.
1885
1886 2019-10-31 Andrew Burgess <andrew.burgess@embecosm.com>
1887
1888 * ada-typeprint.c (ada_print_typedef): Don't print newline at the
1889 end.
1890 * c-typeprint.c (c_print_typedef): Likewise.
1891 * f-typeprint.c (f_print_typedef): Likewise.
1892 * m2-typeprint.c (m2_print_typedef): Likewise.
1893 * p-typeprint.c (pascal_print_typedef): Likewise.
1894 * rust-lang.c (rust_print_typedef): Likewise.
1895 * symtab.c (print_symbol_info): Print a newline after calling
1896 typedef_print.
1897
1898 2019-10-31 Andrew Burgess <andrew.burgess@embecosm.com>
1899
1900 * symtab.c (info_module_cmdlist): New variable.
1901 (info_module_command): New function.
1902 (search_module_symbols): New function.
1903 (info_module_subcommand): New function.
1904 (struct info_modules_var_func_options): New struct.
1905 (info_modules_var_func_options_defs): New variable.
1906 (make_info_modules_var_func_options_def_group): New function.
1907 (info_module_functions_command): New function.
1908 (info_module_variables_command): New function.
1909 (info_module_var_func_command_completer): New function.
1910 (_initialize_symtab): Register new 'info module functions' and
1911 'info module variables' commands.
1912 * symtab.h (typedef symbol_search_in_module): New typedef.
1913 (search_module_symbols): Declare new function.
1914 * NEWS: Mention new commands.
1915
1916 2019-10-31 Andrew Burgess <andrew.burgess@embecosm.com>
1917
1918 * dwarf2read.c (dw2_symtab_iter_next): Handle MODULE_DOMAIN.
1919 (dw2_expand_marked_cus): Handle MODULES_DOMAIN.
1920 (dw2_debug_names_iterator::next): Handle MODULE_DOMAIN and
1921 MODULES_DOMAIN.
1922 (scan_partial_symbols): Only create partial module symbols for non
1923 declarations.
1924 * psymtab.c (recursively_search_psymtabs): Handle MODULE_DOMAIN
1925 and MODULES_DOMAIN.
1926 * symtab.c (search_domain_name): Likewise.
1927 (search_symbols): Likewise.
1928 (print_symbol_info): Likewise.
1929 (symtab_symbol_info): Likewise.
1930 (info_modules_command): New function.
1931 (_initialize_symtab): Register 'info modules' command.
1932 * symtab.h (enum search_domain): Add MODULES_DOMAIN.
1933 * NEWS: Mention new 'info modules' command.
1934
1935 2019-10-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1936
1937 * NEWS: Mention $_gdb_setting, $_gdb_setting_str, $_gdb_maint_setting
1938 and $_gdb_maint_setting_str.
1939
1940 2019-10-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1941
1942 * cli/cli-cmds.c (setting_cmd, value_from_setting)
1943 (gdb_setting_internal_fn, gdb_maint_setting_internal_fn)
1944 (str_value_from_setting, gdb_setting_str_internal_fn)
1945 (gdb_maint_setting_str_internal_fn): New functions.
1946 (_initialize_cli_cmds): Define the new convenience functions.
1947 * gdb/cli/cli-setshow.h (get_setshow_command_value_string): Constify.
1948 * gdb/cli/cli-setshow.c (get_setshow_command_value_string): Constify.
1949
1950 2019-10-31 Christian Biesinger <cbiesinger@google.com>
1951
1952 * agent.c (set_can_use_agent): When the setting is turned on,
1953 look up agent symbols if we don't have them yet.
1954 (agent_new_objfile): Don't look up agent symbols when the agent
1955 setting is off.
1956
1957 2019-10-31 Christian Biesinger <cbiesinger@google.com>
1958
1959 * config.in: Regenerate.
1960
1961 2019-10-31 Christian Biesinger <cbiesinger@google.com>
1962
1963 * configure: Regenerate.
1964 * configure.ac: Check for strerror_r.
1965 * gdbsupport/common-utils.h (safe_strerror): Change return value
1966 to const char * and document that this function is now threadsafe.
1967 * gdbsupport/posix-strerror.c (safe_strerror): Make buf
1968 thread_local and call strerror_r, if available.
1969 * utils.c (perror_string): Update.
1970 (print_sys_errmsg): Update.
1971
1972 2019-10-31 Luis Machado <luis.machado@linaro.org>
1973
1974 * arm-tdep.c (arm_exidx_data_key): Use bfd_key instead of
1975 objfile_key.
1976 (arm_exidx_new_objfile): Adjust to use objfile->obfd instead of
1977 objfile to fetch per-bfd data.
1978 (arm_find_exidx_entry): Likewise.
1979
1980 2019-10-31 Christian Biesinger <cbiesinger@google.com>
1981
1982 * gdbsupport/agent.c (debug_agent): Change type to bool.
1983 (use_agent): Likewise.
1984 (all_agent_symbols_look_up): Likewise.
1985 (agent_loaded_p): Change return value to bool.
1986 (agent_look_up_symbols): Update.
1987 (agent_capability_check): Change return value to bool.
1988 * gdbsupport/agent.h (agent_loaded_p): Likewise.
1989 (debug_agent): Change type to bool.
1990 (use_agent): Likewise.
1991 (agent_capability_check): Change return value to bool.
1992
1993 2019-10-30 Christian Biesinger <cbiesinger@google.com>
1994
1995 * minsyms.c (clear_minimal_symbol_hash_tables): New function.
1996 (build_minimal_symbol_hash_tables): Code to clear the table moved
1997 to clear_minimal_symbol_hash_tables.
1998 (minimal_symbol_reader::install): Call clear_minimal_symbol_hash_tables
1999 when needed.
2000
2001 2019-10-29 Simon Marchi <simon.marchi@polymtl.ca>
2002
2003 * infcmd.c: Remove includes.
2004 * infrun.c: Remove includes.
2005
2006 2019-10-29 Simon Marchi <simon.marchi@polymtl.ca>
2007
2008 * ada-lang.h (GROW_VECT): Move to ada-lang.c.
2009 (grow_vect): Remove declaration.
2010 (ada_type_of_array): Remove declaration.
2011 (ada_update_initial_language): Remove declaration.
2012 (ada_fold_name): Remove declaration.
2013 (ada_fill_in_ada_prototype): Remove declaration.
2014 (user_select_syms): Remove declaration.
2015 (get_selections): Remove declaration.
2016 (ada_tag_type): Remove declaration.
2017 (ada_value_tag): Remove declaration.
2018 (ada_is_others_clause): Remove declaration.
2019 (ada_in_variant): Remove declaration.
2020 (ada_value_struct_elt): Remove declaration.
2021 (ada_attribute_name): Remove declaration.
2022 (ada_system_address_type): Remove declaration.
2023 * ada-lang.c (ada_watch_location_expression): Make static.
2024 (GROW_VECT): Move here from ada-lang.h.
2025 (grow_vect): Make static.
2026 (ada_update_initial_language): Make static.
2027 (ada_fold_name): Make static.
2028 (ada_type_of_array): Make static.
2029 (encoded_ordered_before): Move up.
2030 (sort_choices): Move up.
2031 (print_signatures): Move up.
2032 (ada_print_symbol_signature): Move up.
2033 (get_selections): Move up and make static.
2034 (user_select_syms): Move up and make static.
2035 (ada_value_struct_elt): Move up and make static.
2036 (ada_tag_type): Make static.
2037 (ada_value_tag): Make static.
2038 (ada_is_others_clause): Make static.
2039 (ada_in_variant): Make static.
2040 (ada_attribute_name): Make static.
2041
2042 2019-10-29 Simon Marchi <simon.marchi@polymtl.ca>
2043
2044 * ada-lang.c: Remove includes.
2045 * ada-typeprint.c: Remove includes.
2046 * ada-valprint.c: Remove includes.
2047
2048 2019-10-29 Simon Marchi <simon.marchi@efficios.com>
2049
2050 * addrmap.c: Add static assertions of type size, moved from
2051 _initialize_addrmap.
2052 (_initialize_addrmap): Remove.
2053
2054 2019-10-29 Christian Biesinger <cbiesinger@google.com>
2055
2056 * coffread.c (record_minimal_symbol): Update.
2057 (process_coff_symbol): Update.
2058 * dbxread.c (read_dbx_symtab): Update.
2059 * dwarf2read.c (add_partial_symbol): Update.
2060 (fixup_go_packaging): Update.
2061 (load_partial_dies): Update.
2062 (new_symbol): Update.
2063 * elfread.c (record_minimal_symbol): Change signature to use
2064 gdb::string_view instead of name+len.
2065 (elf_symtab_read): Update.
2066 (elf_rel_plt_read): Update.
2067 * mdebugread.c (parse_partial_symbols): Update.
2068 (handle_psymbol_enumerators): Update.
2069 (new_symbol): Update.
2070 * minsyms.c (minimal_symbol_reader::record_full): Change signature
2071 to use gdb::string_view instead of name+len.
2072 * minsyms.h (class minimal_symbol_reader) <record_full>: Likewise.
2073 * psympriv.h (add_psymbol_to_list): Likewise.
2074 * psymtab.c (add_psymbol_to_bcache): Likewise.
2075 (add_psymbol_to_list): Likewise.
2076 * stabsread.c (define_symbol): Update.
2077 * symtab.c (symbol_set_names): Change signature to use gdb::string_view.
2078 * symtab.h (SYMBOL_SET_NAMES): Likewise.
2079 (symbol_set_names): Likewise.
2080 * xcoffread.c (scan_xcoff_symtab): Update.
2081
2082 2019-10-29 Christian Biesinger <cbiesinger@google.com>
2083
2084 * symtab.h (symbol_set_names): Document that copy_name must be
2085 set to true for non-nullterminated strings.
2086 * symtab.c (symbol_set_names): Only make a nullterminated copy of
2087 linkage_name if the entry was not found and we need to demangle.
2088
2089 2019-10-29 Christian Biesinger <cbiesinger@google.com>
2090
2091 * Makefile.in (HFILES_NO_SRCDIR): Add gdb_binary_search.h.
2092 * dwarf2-frame.c (bsearch_fde_cmp): Update.
2093 (dwarf2_frame_find_fde): Replace bsearch with gdb::binary_search.
2094 * gdbsupport/gdb_binary_search.h: New file.
2095
2096 2019-10-29 Christian Biesinger <cbiesinger@google.com>
2097
2098 * NEWS: Mention new --with-system-gdbinit-dir option.
2099 * config.in: Regenerate.
2100 * configure: Regenerate.
2101 * configure.ac: Add new option --with-system-gdbinit-dir.
2102 * extension.c (get_ext_lang_of_file): Return extension_language_gdb
2103 for a ".gdb" suffix.
2104 * main.c (get_init_files): Change system_gdbinit argument to
2105 a vector and return the files in SYSTEM_GDBINIT_DIR in
2106 addition to SYSTEM_GDBINIT.
2107 (captured_main_1): Update.
2108 (print_gdb_help): Update.
2109 * top.c (print_gdb_configuration): Also print the value of
2110 SYSTEM_GDBINIT_DIR.
2111
2112 2019-10-28 Christian Biesinger <cbiesinger@google.com>
2113
2114 * gdbsupport/common-utils.h (startswith): Add an overloaded version
2115 that takes gdb::string_view arguments.
2116
2117 2019-10-26 Tom de Vries <tdevries@suse.de>
2118
2119 * aarch64-linux-tdep.c: Fix typos in comments.
2120 * aarch64-tdep.c: Same.
2121 * ada-lang.c: Same.
2122 * amd64-nat.c: Same.
2123 * arc-tdep.c: Same.
2124 * arch/aarch64-insn.c: Same.
2125 * block.c: Same.
2126 * breakpoint.h: Same.
2127 * btrace.h: Same.
2128 * c-varobj.c: Same.
2129 * cli/cli-decode.c: Same.
2130 * cli/cli-script.c: Same.
2131 * cli/cli-utils.h: Same.
2132 * coff-pe-read.c: Same.
2133 * coffread.c: Same.
2134 * compile/compile-cplus-symbols.c: Same.
2135 * compile/compile-object-run.c: Same.
2136 * completer.c: Same.
2137 * corelow.c: Same.
2138 * cp-support.c: Same.
2139 * demangle.c: Same.
2140 * dwarf-index-write.c: Same.
2141 * dwarf2-frame.c: Same.
2142 * dwarf2-frame.h: Same.
2143 * eval.c: Same.
2144 * frame-base.h: Same.
2145 * frame.h: Same.
2146 * gdbcmd.h: Same.
2147 * gdbtypes.h: Same.
2148 * gnu-nat.c: Same.
2149 * guile/scm-objfile.c: Same.
2150 * i386-tdep.c: Same.
2151 * i386-tdep.h: Same.
2152 * infcall.c: Same.
2153 * infcall.h: Same.
2154 * linux-nat.c: Same.
2155 * m68k-tdep.c: Same.
2156 * macroexp.c: Same.
2157 * memattr.c: Same.
2158 * mi/mi-cmd-disas.c: Same.
2159 * mi/mi-getopt.h: Same.
2160 * mi/mi-main.c: Same.
2161 * minsyms.c: Same.
2162 * nat/aarch64-sve-linux-sigcontext.h: Same.
2163 * objfiles.h: Same.
2164 * ppc-linux-nat.c: Same.
2165 * ppc-linux-tdep.c: Same.
2166 * ppc-tdep.h: Same.
2167 * progspace.h: Same.
2168 * prologue-value.h: Same.
2169 * python/py-evtregistry.c: Same.
2170 * python/py-instruction.h: Same.
2171 * record-btrace.c: Same.
2172 * record-full.c: Same.
2173 * remote.c: Same.
2174 * rs6000-tdep.c: Same.
2175 * ser-tcp.c: Same.
2176 * sol-thread.c: Same.
2177 * sparc-sol2-tdep.c: Same.
2178 * sparc64-tdep.c: Same.
2179 * stabsread.c: Same.
2180 * symfile.c: Same.
2181 * symtab.h: Same.
2182 * target.c: Same.
2183 * tracepoint.c: Same.
2184 * tui/tui-data.h: Same.
2185 * tui/tui-io.c: Same.
2186 * tui/tui-win.c: Same.
2187 * tui/tui.c: Same.
2188 * unittests/rsp-low-selftests.c: Same.
2189 * user-regs.h: Same.
2190 * utils.c: Same.
2191 * utils.h: Same.
2192 * valarith.c: Same.
2193 * valops.c: Same.
2194 * valprint.c: Same.
2195 * valprint.h: Same.
2196 * value.c: Same.
2197 * value.h: Same.
2198 * varobj.c: Same.
2199 * x86-nat.h: Same.
2200 * xtensa-tdep.c: Same.
2201
2202 2019-10-25 Ali Tamur <tamur@google.com>
2203
2204 * charset.c (find_charset_names): Reflect API change.
2205
2206 2019-10-25 Christian Biesinger <cbiesinger@google.com>
2207
2208 * symtab.c (struct demangled_name_entry): Change demangled name
2209 to a unique_xmalloc_ptr<char>, now that we don't allocate it as
2210 part of the struct anymore.
2211 (symbol_set_names): No longer obstack allocate + copy the demangled
2212 name, just store the allocated name from bfd.
2213
2214 2019-10-25 Tom Tromey <tromey@adacore.com>
2215
2216 * dwarf2-frame.c (dwarf2_cie_table): Now a typedef.
2217 (bsearch_cie_cmp, add_cie): Remove.
2218 (find_cie): Reimplement.
2219 (decode_frame_entry_1, decode_frame_entry): Change type. Update.
2220 (dwarf2_build_frame_info): Update.
2221
2222 2019-10-24 H.J. Lu <hongjiu.lu@intel.com>
2223
2224 PR gdb/25126
2225 * symfile.c (reread_symbols): Call forget_cached_source_info to
2226 clear the stale source cache.
2227
2228 2019-10-24 Christian Biesinger <cbiesinger@google.com>
2229
2230 * configure: Regenerate.
2231 * configure.ac: Remove code that sets python_has_threads.
2232
2233 2019-10-24 Christian Biesinger <cbiesinger@google.com>
2234
2235 * config.in: Regenerate.
2236 * configure: Regenerate.
2237 * configure.ac: Remove the code that uses sed to get the python
2238 version and defines HAVE_LIBPYTHON2_6 / HAVE_LIBPYTHON2_7.
2239
2240 2019-10-24 Andrew Burgess <andrew.burgess@embecosm.com>
2241
2242 * python/py-progspace.c (pspy_block_for_pc): Return None for all
2243 error paths.
2244
2245 2019-10-23 Tom Tromey <tom@tromey.com>
2246
2247 * arc-tdep.c: Remove ".." from include.
2248 * frv-tdep.c: Remove ".." from include.
2249 * lm32-tdep.c: Remove ".." from include.
2250 * microblaze-tdep.c: Remove ".." from include.
2251 * or1k-tdep.h: Remove ".." from include.
2252 * s12z-tdep.c: Remove ".." from include.
2253 * Makefile.in (OPCODES_CFLAGS): Add comment.
2254 (TOP_CFLAGS): New variable.
2255 (INTERNAL_CFLAGS_BASE): Add TOP_CFLAGS.
2256
2257 2019-10-23 Tom Tromey <tom@tromey.com>
2258
2259 * Makefile.in (READLINE_DIR): Update.
2260
2261 2019-10-23 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
2262
2263 * infcall.c (call_function_by_hand_dummy): Fix the function
2264 comment. And extract out a code section into...
2265 (reserve_stack_space): ...this new function.
2266
2267 2019-10-23 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
2268
2269 * infcall.c (value_arg_coerce): Remove an unused parameter.
2270 (call_function_by_hand_dummy): Update the call to
2271 'value_arg_coerce'.
2272
2273 2019-10-23 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
2274
2275 * infcall.c (call_function_by_hand_dummy): Refactor.
2276
2277 2019-10-23 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
2278
2279 * MAINTAINERS (Write After Approval): Add Tankut Baris Aktemur.
2280
2281 2019-10-23 Tom Tromey <tom@tromey.com>
2282
2283 * configure: Rebuild.
2284 * configure.ac: Don't check for sigprocmask.
2285 * gdbsupport/common.m4 (GDB_AC_COMMON): Check for sigprocmask.
2286
2287 2019-10-23 Tom Tromey <tom@tromey.com>
2288
2289 * configure: Rebuild.
2290 * acinclude.m4: Use m4_include, not sinclude.
2291
2292 2019-10-23 Tom de Vries <tdevries@suse.de>
2293
2294 PR breakpoints/24687
2295 * symtab.c (iterate_over_some_symtabs): Apply gdb_realpath on fullname.
2296
2297 2019-10-22 Christian Biesinger <cbiesinger@google.com>
2298
2299 * symtab.c (struct demangled_name_entry) <language>: Change from
2300 bitfield to regular variable.
2301
2302 2019-10-22 Christian Biesinger <cbiesinger@google.com>
2303
2304 * symtab.c (struct demangled_name_entry): Add a constructor.
2305 (free_demangled_name_entry): New function to call the destructor
2306 for demangled_name_entry.
2307 (create_demangled_names_hash): Pass free_demangled_name_entry to
2308 htab_create_alloc.
2309 (symbol_set_names): Call placement new for demangled_name_entry.
2310 * utils.c: No longer include xxhash.h here, now that fast_hash
2311 is inlined in the header.
2312 * utils.h: Instead, include it here.
2313
2314 2019-10-22 Christian Biesinger <cbiesinger@google.com>
2315
2316 * Makefile.in: Link with libxxhash.
2317 * config.in: Regenerate.
2318 * configure: Regenerate.
2319 * configure.ac: Search for libxxhash.
2320 * utils.c (fast_hash): Use xxhash if present.
2321
2322 2019-10-22 Christian Biesinger <cbiesinger@google.com>
2323
2324 * utils.h (fast_hash): New function.
2325 * symtab.c (hash_demangled_name_entry): Call new function
2326 fast_hash.
2327
2328 2019-10-22 Christian Biesinger <cbiesinger@google.com>
2329
2330 * symtab.c (struct demangled_name_entry): Change type of mangled
2331 to gdb::string_view. Also adds a constructor that takes the
2332 mangled name.
2333 (hash_demangled_name_entry): Update.
2334 (eq_demangled_name_entry): Update.
2335 (free_demangled_name_entry): New function to call the destructor
2336 now that this is not a POD anymore.
2337 (create_demangled_names_hash): Pass free_demangled_name_entry to
2338 htab_create_alloc.
2339 (symbol_set_names): Update.
2340
2341 2019-10-21 Ali Tamur <tamu@google.com>
2342
2343 * dwarf2read.c (dir_index): Change type.
2344 (file_name_index): Likewise.
2345 (line_header::include_dir_at): Change comment and implementation on
2346 whether it is DWARF 5.
2347 (line_header::is_valid_file_index): New function.
2348 (line_header::file_name_at): Change comment and implementation on
2349 whether it is DWARF 5.
2350 (line_header::file_names): Change to private field renamed as
2351 m_file_names and introduce a new accessor method.
2352 (line_header::file_names_size): New method.
2353 (line_header::include_dirs): Change to private field and rename as
2354 m_include_dirs.
2355 (dw2_get_file_names_reader): Define local var at a smaller scope and
2356 reflect API change.
2357 (dwarf2_cu::setup_type_unit_groups): Reflect API change.
2358 (process_structure_scope): Likewise.
2359 (line_header::add_include_dir): Change message and reflect renaming.
2360 (line_header::add_file_name): Likewise.
2361 (read_formatted_entries): Handle DW_FORM_data16.
2362 (dwarf_decode_line_header): Fix line header length calculation.
2363 (psymtab_include_file_name): Change comment and API.
2364 (lnp_state_machine::m_file): Update comment and reflect type change.
2365 (lnp_state_machine::record_line): Reflect type change.
2366 (dwarf_decode_lines): Reflect API change.
2367 (file_file_name): Likewise.
2368 (file_full_name): Likewise.
2369
2370 2019-10-21 Andrew Burgess <andrew.burgess@embecosm.com>
2371
2372 * objfiles.c (sort_cmp): Ensure that !(a < a) holds true.
2373
2374 2019-10-21 Tom Tromey <tom@tromey.com>
2375
2376 * tui/tui-winsource.h (tui_exec_info_content): Remove typedef.
2377
2378 2019-10-21 Tom Tromey <tom@tromey.com>
2379
2380 * configure.ac (nm.h): Conditionally create nm.h link. Subst
2381 NM_H. Use AC_CONFIG_LINKS.
2382 * configure: Rebuild.
2383 * Makefile.in (NM_H): New variable.
2384 (generated_files): Add NM_H. Remove gcore.
2385 (nm.h, stamp-nmh): New targets.
2386
2387 2019-10-20 Tom Tromey <tom@tromey.com>
2388
2389 * objfiles.h (unlink_objfile, put_objfile_before): Don't declare.
2390 * objfiles.c (unlink_objfile): Move earlier. Now static. Remove
2391 obsolete comment.
2392 (put_objfile_before): Now static.
2393
2394 2019-10-19 Simon Marchi <simon.marchi@polymtl.ca>
2395
2396 * gdbsupport/common-utils.h (startswith): Change return type to
2397 bool.
2398
2399 2019-10-19 Christian Biesinger <cbiesinger@google.com>
2400
2401 * bcache.c (bcache::print_statistics): Use std::sort instead of qsort.
2402 * breakpoint.c (bp_locations_compare): Rename to...
2403 (bp_location_is_less_than): ...this, and change to std::sort semantics.
2404 (update_global_location_list): Use std::sort instead of qsort.
2405 * buildsym.c (compare_line_numbers): Rename to...
2406 (lte_is_less_than): ...this, and change to std::sort semantics.
2407 (buildsym_compunit::end_symtab_with_blockvector): Use std::sort
2408 instead of qsort.
2409 * disasm.c (compare_lines): Rename to...
2410 (line_is_less_than): ...this, and change to std::sort semantics.
2411 (do_mixed_source_and_assembly_deprecated): Call std::sort instead
2412 of qsort.
2413 * dwarf2-frame.c (qsort_fde_cmp): Rename to...
2414 (fde_is_less_than): ...this, and change to std::sort semantics.
2415 (dwarf2_build_frame_info): Call std::sort instead of qsort.
2416 * mdebugread.c (compare_blocks):
2417 (block_is_less_than): ...this, and change to std::sort semantics.
2418 (sort_blocks): Call std::sort instead of qsort.
2419 * objfiles.c (qsort_cmp): Rename to...
2420 (sort_cmp): ...this, and change to std::sort semantics.
2421 (update_section_map): Call std::sort instead of qsort.
2422 * remote.c (compare_pnums): Remove.
2423 (map_regcache_remote_table): Call std::sort instead of qsort.
2424 * utils.c (compare_positive_ints): Remove.
2425 * utils.h (compare_positive_ints): Remove.
2426 * xcoffread.c (compare_lte): Remove.
2427 (arrange_linetable): Call std::sort instead of qsort.
2428
2429 2019-10-19 Sergio Durigan Junior <sergiodj@redhat.com>
2430
2431 * symfile.c (init_entry_point_info): Fix typo.
2432 * i386-darwin-tdep.c (darwin_dwarf_signal_frame_p): Fix typo.
2433
2434 2019-10-18 Tom de Vries <tdevries@suse.de>
2435
2436 * aarch64-tdep.c: Fix typos in comments.
2437 * ada-lang.c: Same.
2438 * ada-tasks.c: Same.
2439 * alpha-tdep.c: Same.
2440 * alpha-tdep.h: Same.
2441 * amd64-nat.c: Same.
2442 * amd64-windows-tdep.c: Same.
2443 * arc-tdep.c: Same.
2444 * arc-tdep.h: Same.
2445 * arch-utils.c: Same.
2446 * arm-nbsd-tdep.c: Same.
2447 * arm-tdep.c: Same.
2448 * ax-gdb.c: Same.
2449 * blockframe.c: Same.
2450 * btrace.c: Same.
2451 * c-varobj.c: Same.
2452 * coff-pe-read.c: Same.
2453 * coffread.c: Same.
2454 * cris-tdep.c: Same.
2455 * darwin-nat.c: Same.
2456 * dbxread.c: Same.
2457 * dcache.c: Same.
2458 * disasm.c: Same.
2459 * dtrace-probe.c: Same.
2460 * dwarf-index-write.c: Same.
2461 * dwarf2-frame-tailcall.c: Same.
2462 * dwarf2-frame.c: Same.
2463 * dwarf2read.c: Same.
2464 * eval.c: Same.
2465 * exceptions.c: Same.
2466 * fbsd-tdep.c: Same.
2467 * findvar.c: Same.
2468 * frame.c: Same.
2469 * frv-tdep.c: Same.
2470 * gnu-v3-abi.c: Same.
2471 * go32-nat.c: Same.
2472 * h8300-tdep.c: Same.
2473 * hppa-tdep.c: Same.
2474 * i386-linux-tdep.c: Same.
2475 * i386-tdep.c: Same.
2476 * ia64-libunwind-tdep.c: Same.
2477 * ia64-tdep.c: Same.
2478 * infcmd.c: Same.
2479 * infrun.c: Same.
2480 * linespec.c: Same.
2481 * linux-nat.c: Same.
2482 * linux-thread-db.c: Same.
2483 * machoread.c: Same.
2484 * mdebugread.c: Same.
2485 * mep-tdep.c: Same.
2486 * mn10300-tdep.c: Same.
2487 * namespace.c: Same.
2488 * objfiles.c: Same.
2489 * opencl-lang.c: Same.
2490 * or1k-tdep.c: Same.
2491 * osabi.c: Same.
2492 * ppc-linux-nat.c: Same.
2493 * ppc-linux-tdep.c: Same.
2494 * ppc-sysv-tdep.c: Same.
2495 * printcmd.c: Same.
2496 * procfs.c: Same.
2497 * record-btrace.c: Same.
2498 * record-full.c: Same.
2499 * remote-fileio.c: Same.
2500 * remote.c: Same.
2501 * rs6000-tdep.c: Same.
2502 * s12z-tdep.c: Same.
2503 * score-tdep.c: Same.
2504 * ser-base.c: Same.
2505 * ser-go32.c: Same.
2506 * skip.c: Same.
2507 * sol-thread.c: Same.
2508 * solib-svr4.c: Same.
2509 * solib.c: Same.
2510 * source.c: Same.
2511 * sparc-nat.c: Same.
2512 * sparc-sol2-tdep.c: Same.
2513 * sparc-tdep.c: Same.
2514 * sparc64-tdep.c: Same.
2515 * stabsread.c: Same.
2516 * stack.c: Same.
2517 * symfile.c: Same.
2518 * symtab.c: Same.
2519 * target-descriptions.c: Same.
2520 * target-float.c: Same.
2521 * thread.c: Same.
2522 * utils.c: Same.
2523 * valops.c: Same.
2524 * valprint.c: Same.
2525 * value.c: Same.
2526 * varobj.c: Same.
2527 * windows-nat.c: Same.
2528 * xcoffread.c: Same.
2529 * xstormy16-tdep.c: Same.
2530 * xtensa-tdep.c: Same.
2531
2532 2019-10-17 Tom Tromey <tromey@adacore.com>
2533
2534 * configure: Rebuild.
2535 * configure.ac: Use AC_CONFIG_HEADERS. Create stamp-h there, not
2536 in AC_CONFIG_FILES invocation.
2537 * Makefile.in (Makefile, data-directory/Makefile, stamp-h): Use
2538 new-style config.status invocation.
2539
2540 2019-10-17 Tom de Vries <tdevries@suse.de>
2541
2542 * arm-nbsd-nat.c: Fix typos in comments.
2543 * arm-tdep.c: Same.
2544 * darwin-nat-info.c: Same.
2545 * dwarf2read.c: Same.
2546 * elfread.c: Same.
2547 * event-top.c: Same.
2548 * findvar.c: Same.
2549 * gdbtypes.c: Same.
2550 * hppa-tdep.c: Same.
2551 * i386-tdep.c: Same.
2552 * jit.c: Same.
2553 * main.c: Same.
2554 * mdebugread.c: Same.
2555 * moxie-tdep.c: Same.
2556 * nto-procfs.c: Same.
2557 * osabi.c: Same.
2558 * ppc-linux-tdep.c: Same.
2559 * remote.c: Same.
2560 * riscv-tdep.c: Same.
2561 * s390-tdep.c: Same.
2562 * sh-tdep.c: Same.
2563 * sparc-linux-tdep.c: Same.
2564 * sparc-nat.c: Same.
2565 * stack.c: Same.
2566 * target-descriptions.c: Same.
2567 * top.c: Same.
2568 * varobj.c: Same.
2569
2570 2019-10-16 Tom Tromey <tom@tromey.com>
2571
2572 * objfiles.h (struct objfile) <original_name>: Now const.
2573
2574 2019-10-16 Christian Biesinger <cbiesinger@google.com>
2575
2576 * gdbsupport/gdb_setjmp.h (SIGSETJMP): Allow passing in the value to
2577 pass on to sigsetjmp's second argument.
2578 * cp-support.c (gdb_demangle): Unblock SIGSEGV if we caught a crash.
2579
2580 2019-10-16 Keith Seitz <keiths@redhat.com>
2581
2582 PR gdb/23567
2583 * dwarf2read.c (dwarf2_per_objfile::locate_sections): Discard
2584 sections whose size is greater than the file size.
2585
2586 2019-10-16 Jim Wilson <jimw@sifive.com>
2587
2588 * riscv-tdep.c (riscv_gcc_target_options): New.
2589 (riscv_gnu_triplet_regexp): New.
2590 (riscv_gdbarch_init): Call set_gdbarch_gcc_triplet_options and
2591 set_gdbarch_gnu_triplet_regexp.
2592
2593 2019-10-16 Christian Biesinger <cbiesinger@google.com>
2594
2595 * Makefile.in: Add xml-builtin.h.
2596 * features/feature_to_c.sh: Add an include for xml-builtin.h
2597 to ensure that the compiler checks that the types match.
2598 * xml-builtin.h: New file.
2599 * xml-support.c (fetch_xml_builtin): Add missing const.
2600 * xml-support.h: Remove declaration of xml_builtins.
2601
2602 2019-10-16 Tom de Vries <tdevries@suse.de>
2603
2604 PR tdep/25096
2605 * amd64-tdep.c (amd64_classify_aggregate_field): Factor out of ...
2606 (amd64_classify_aggregate): ... here.
2607 (amd64_classify_aggregate_field): Handled fiels of nested structs
2608 recursively.
2609
2610 2019-10-16 Tom de Vries <tdevries@suse.de>
2611
2612 PR tdep/24104
2613 * amd64-tdep.c (amd64_push_arguments): Handle AMD64_NO_CLASS in loop
2614 that handles 'theclass'.
2615
2616 2019-10-15 Andrew Burgess <andrew.burgess@embecosm.com>
2617
2618 * linespec.c (decode_digits_ordinary): Update comment.
2619 * make-target-delegates: No longer need to handle VEC case.
2620 * memrange.c (normalize_mem_ranges): Update comment.
2621 * namespace.c (add_using_directive): Update comment.
2622 * objc-lang.c (uniquify_strings): Update comment.
2623 * ppc-linux-nat.c (struct thread_points): Update comment.
2624 * probe.h (find_probes_in_objfile): Update comment.
2625 * target.h (enum flash_preserve_mode): Update comment.
2626 * varobj.c (varobj_restrict_range): Update comment.
2627 * varobj.h (varobj_list_children): Update comment.
2628
2629 2019-10-15 Andrew Burgess <andrew.burgess@embecosm.com>
2630
2631 * Makefile.in: Remove references to vec.h and vec.c.
2632 * aarch64-tdep.c: No longer include vec.h.
2633 * ada-lang.c: Likewise.
2634 * ada-lang.h: Likewise.
2635 * arm-tdep.c: Likewise.
2636 * ax.h: Likewise.
2637 * breakpoint.h: Likewise.
2638 * charset.c: Likewise.
2639 * cp-support.h: Likewise.
2640 * dtrace-probe.c: Likewise.
2641 * dwarf2read.c: Likewise.
2642 * extension.h: Likewise.
2643 * gdb_bfd.c: Likewise.
2644 * gdbsupport/gdb_vecs.h: Likewise.
2645 * gdbsupport/vec.c: Remove.
2646 * gdbsupport/vec.h: Remove.
2647 * gdbthread.h: Likewise.
2648 * guile/scm-type.c: Likewise.
2649 * inline-frame.c: Likewise.
2650 * machoread.c: Likewise.
2651 * memattr.c: Likewise.
2652 * memrange.h: Likewise.
2653 * namespace.h: Likewise.
2654 * nat/linux-btrace.h: Likewise.
2655 * osdata.c: Likewise.
2656 * parser-defs.h: Likewise.
2657 * progspace.h: Likewise.
2658 * python/py-type.c: Likewise.
2659 * record-btrace.c: Likewise.
2660 * rust-exp.y: Likewise.
2661 * solib-target.c: Likewise.
2662 * stap-probe.c: Likewise.
2663 * target-descriptions.c: Likewise.
2664 * target-memory.c: Likewise.
2665 * target.h: Likewise.
2666 * varobj.c: Likewise.
2667 * varobj.h: Likewise.
2668 * xml-support.h: Likewise.
2669
2670 2019-10-15 Andrew Burgess <andrew.burgess@embecosm.com>
2671
2672 * gdb/dwarf2read.c (dwarf2_per_objfile::~dwarf2_per_objfile):
2673 Update for new std::vector based implementation.
2674 (process_psymtab_comp_unit_reader): Likewise.
2675 (scan_partial_symbols): Likewise.
2676 (recursively_compute_inclusions): Likewise.
2677 (compute_compunit_symtab_includes): Likewise.
2678 (process_imported_unit_die): Likewise.
2679 (queue_and_load_dwo_tu): Likewise.
2680 (follow_die_sig_1): Likewise.
2681 * gdb/dwarf2read.h: Remove DEF_VEC_P.
2682 (typedef dwarf2_per_cu_ptr): Remove.
2683 (struct dwarf2_per_cu_data) <imported_symtabs_empty>: New
2684 function.
2685 (struct dwarf2_per_cu_data) <imported_symtabs_push>: New function.
2686 (struct dwarf2_per_cu_data) <imported_symtabs_size>: New function.
2687 (struct dwarf2_per_cu_data) <imported_symtabs_free>: New function.
2688 (struct dwarf2_per_cu_data) <imported_symtabs>: Change to
2689 std::vector.
2690
2691 2019-10-15 Tom Tromey <tromey@adacore.com>
2692
2693 * windows-nat.c (windows_nat_target::resume): Use %x when logging
2694 TID.
2695
2696 2019-10-15 Tom Tromey <tromey@adacore.com>
2697
2698 * windows-nat.c (windows_nat_target::fetch_registers)
2699 (windows_nat_target::store_registers): Rename "pid" to "tid".
2700
2701 2019-10-15 Tom Tromey <tromey@adacore.com>
2702
2703 * gdbarch.h, gdbarch.c: Rebuild.
2704 * gdbarch.sh (gcc_target_options): Change return type to
2705 std::string.
2706 * compile/compile.c (get_args): Update.
2707 * nios2-tdep.c (nios2_gcc_target_options): Return std::string.
2708 * arm-linux-tdep.c (arm_linux_gcc_target_options): Return
2709 std::string.
2710 * aarch64-linux-tdep.c (aarch64_linux_gcc_target_options): Return
2711 std::string.
2712 * arch-utils.c (default_gcc_target_options): Return std::string.
2713 * arch-utils.h (default_gcc_target_options): Return std::string.
2714 * s390-tdep.c (s390_gcc_target_options): Return std::string.
2715
2716 2019-10-15 Christian Biesinger <cbiesinger@google.com>
2717
2718 * breakpoint.c (breakpoint_chain): Make static.
2719 * tui/tui-winsource.c: Call iterate_over_breakpoints instead
2720 of accessing breakpoint_chain.
2721
2722 2019-10-15 Christian Biesinger <cbiesinger@google.com>
2723
2724 * breakpoint.c (iterate_over_breakpoints): Change function pointer
2725 to a gdb::function_view and return value to bool.
2726 * breakpoint.h (iterate_over_breakpoints): Likewise.
2727 * dummy-frame.c (pop_dummy_frame_bpt): Update.
2728 (pop_dummy_frame): Update.
2729 * guile/scm-breakpoint.c (bpscm_build_bp_list): Update.
2730 (gdbscm_breakpoints): Update.
2731 * python/py-breakpoint.c (build_bp_list): Update.
2732 (gdbpy_breakpoints): Update.
2733 * python/py-finishbreakpoint.c (bpfinishpy_detect_out_scope_cb):
2734 Update.
2735 (bpfinishpy_handle_stop): Update.
2736 (bpfinishpy_handle_exit): Update.
2737 * solib-svr4.c (svr4_update_solib_event_breakpoint): Update.
2738 (svr4_update_solib_event_breakpoints): Update.
2739
2740 2019-10-15 Andreas Arnez <arnez@linux.ibm.com>
2741
2742 * s390-tdep.c (s390_effective_inner_type): Ignore static fields
2743 when unwrapping single-field structs.
2744
2745 2019-10-14 Simon Marchi <simon.marchi@polymtl.ca>
2746
2747 * dwarf2read.c: Remove includes.
2748
2749 2019-10-13 Simon Marchi <simon.marchi@polymtl.ca>
2750
2751 * ui-out.c (ui_out::call_do_message): Silence
2752 -Wformat-nonliteral warning.
2753
2754 2019-10-12 Simon Marchi <simon.marchi@polymtl.ca>
2755
2756 * breakpoint.c: Remove some includes: continuations.h, skip.h,
2757 mi/mi-main.h, readline/readline.h, readline/history.h. Add
2758 include: readline/tilde.h.
2759
2760 2019-10-12 Christian Biesinger <cbiesinger@google.com>
2761
2762 * remote.c (remote_target::get_trace_status): Remove declaration of
2763 trace_regblock_size.
2764
2765 2019-10-12 Christian Biesinger <cbiesinger@google.com>
2766
2767 * cli/cli-cmds.c (max_user_call_depth): Move comment to header.
2768 (show_user): Remove declaration of cmdlist.
2769 * cli/cli-cmds.h (max_user_call_depth): Declare.
2770 * cli/cli-script.c (execute_user_command): Remove declaration
2771 of max_user_call_depth.
2772
2773 2019-10-11 Jim Wilson <jimw@sifive.com>
2774
2775 * gdbsupport/print-utils.h (pulongest): Fix comment.
2776 (plongest): Likewise.
2777 (phex): Add missing comment, mention leading zeros.
2778 (phex_nz): Add mention of no leading zeros to comment.
2779
2780 * riscv-tdep.c (riscv_push_dummy_code): Change %lld to %s and use
2781 plongest instead of unsigned long long cast.
2782
2783 2019-10-10 Christian Biesinger <cbiesinger@google.com>
2784
2785 * main.c (captured_main_1): Include gdbtk.h and remove declarations
2786 for external_editor_command and gdbtk_test.
2787
2788 2019-10-10 Christian Biesinger <cbiesinger@google.com>
2789
2790 * mi/mi-cmd-var.c (varobjdebug): Remove declaration.
2791 * varobj.c (varobjdebug): Move comment to...
2792 * varobj.h (varobjdebug): ...here, and declare.
2793
2794 2019-10-09 Tom Tromey <tom@tromey.com>
2795
2796 * tui/tui-regs.c (tui_data_window::show_registers): Don't call
2797 erase_data_content.
2798
2799 2019-10-09 Tom Tromey <tom@tromey.com>
2800
2801 * tui/tui-wingeneral.h (tui_delete_win): Don't declare.
2802 * tui/tui-stack.c (tui_locator_window::rerender): Update.
2803 * tui/tui-command.c (tui_cmd_window::resize)
2804 (tui_refresh_cmd_win): Update.
2805 * tui/tui-win.c (tui_resize_all, tui_set_focus_command): Update.
2806 * tui/tui.c (tui_rl_other_window, tui_enable): Update.
2807 * tui/tui-data.c (~tui_gen_win_info): Remove.
2808 * tui/tui-layout.c (tui_gen_win_info::resize): Update.
2809 * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
2810 (tui_redisplay_readline, tui_mld_flush)
2811 (tui_mld_erase_entire_line, tui_mld_getc, tui_getc): Update.
2812 * tui/tui-regs.c (tui_data_window::delete_data_content_windows)
2813 (tui_data_window::erase_data_content)
2814 (tui_data_item_window::rerender)
2815 (tui_data_item_window::refresh_window): Update.
2816 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window)
2817 (box_win, tui_gen_win_info::make_window)
2818 (tui_gen_win_info::make_visible): Update.
2819 (tui_delete_win): Remove.
2820 * tui/tui-winsource.c
2821 (tui_source_window_base::do_erase_source_content): Update.
2822 (tui_show_source_line, tui_source_window_base::update_tab_width)
2823 (tui_source_window_base::update_exec_info): Update.
2824 * tui/tui-data.h (struct curses_deleter): New.
2825 (struct tui_gen_win_info) <handle>: Now a unique_ptr.
2826 (struct tui_gen_win_info) <~tui_gen_win_info>: Define.
2827
2828 2019-10-09 Tom Tromey <tom@tromey.com>
2829
2830 * tui/tui-wingeneral.h (struct tui_gen_win_info): Don't declare.
2831
2832 2019-10-09 Tom Tromey <tom@tromey.com>
2833
2834 * tui/tui-data.c (tui_win_is_auxiliary): Remove.
2835 * tui/tui-data.h (tui_win_is_auxiliary): Don't declare.
2836
2837 2019-10-09 Tom Tromey <tom@tromey.com>
2838
2839 * tui/tui-disasm.c (tui_get_low_disassembly_address): Compute
2840 window height directly.
2841 * tui/tui-layout.h (tui_default_win_viewport_height): Don't
2842 declare.
2843 * tui/tui-layout.c (tui_default_win_height): Remove.
2844 (tui_default_win_viewport_height): Remove.
2845
2846 2019-10-09 Tom Tromey <tom@tromey.com>
2847
2848 * tui/tui.h: Remove comments.
2849
2850 2019-10-09 Tom de Vries <tdevries@suse.de>
2851
2852 * python/lib/gdb/printer/bound_registers.py: Use
2853 '^builtin_type_bound128' as regexp argument for
2854 add_builtin_pretty_printer.
2855
2856 2019-10-09 Christian Biesinger <cbiesinger@google.com>
2857
2858 * guile/guile.c (guile_extension_script_ops): Remove forward
2859 declaration and mark as static.
2860 (guile_script_ops): Likewise.
2861 (extension_language_guile): Move further down in the file so
2862 it can reference the definitions for guile_{extension_,}script_ops.
2863
2864 2019-10-09 Andreas Arnez <arnez@linux.ibm.com>
2865
2866 * s390-tdep.c (390_process_record): Handle new arch13 instructions
2867 except SORTL, DFLTCC, and KDSA.
2868
2869 2019-10-08 Tom Tromey <tromey@adacore.com>
2870
2871 * windows-nat.c (struct windows_thread_info_struct) <sf>: Remove.
2872 (struct safe_symbol_file_add_args): Remove.
2873
2874 2019-10-08 Tom Tromey <tromey@adacore.com>
2875
2876 * windows-nat.c: Don't include buildsym-legacy.h.
2877
2878 2019-10-08 Tom Tromey <tromey@adacore.com>
2879
2880 * contrib/ari/gdb_ari.sh (%p): Allow gdb-specific %p extensions.
2881
2882 2019-10-08 Christian Biesinger <cbiesinger@google.com>
2883
2884 * gdbtypes.c (overload_debug): Move comment to header.
2885 * gdbtypes.h (overload_debug): Declare.
2886 * valops.c: Remove declaration of overload_debug, instead
2887 include gdbtypes.h.
2888
2889 2019-10-08 Christian Biesinger <cbiesinger@google.com>
2890
2891 * language.c (show_language_command): Pass lang_frame_mismatch_warn
2892 through _().
2893 (lang_frame_mismatch_warn): Make const, mark with N_(), and
2894 move comment...
2895 * language.h (lang_frame_mismatch_warn): ... here. Also add
2896 declaration.
2897 * top.c (lang_frame_mismatch_warn): Remove declaration.
2898 (check_frame_language_change): Pass lang_frame_mismatch_warn
2899 through _().
2900
2901 2019-10-07 Christian Biesinger <cbiesinger@google.com>
2902
2903 * c-lang.h (vtbl_ptr_name): Declare.
2904 * cp-valprint.c (vtbl_ptr_name): Remove "extern" now that we get
2905 it from the header.
2906 * stabsread.c (define_symbol): Remove declaration of vtbl_ptr_name.
2907
2908 2019-10-07 Christian Biesinger <cbiesinger@google.com>
2909
2910 * charset.c (your_gdb_wchar_t_is_bogus): Replace with a
2911 gdb_static_assert.
2912
2913 2019-10-07 Weimin Pan <weimin.pan@oracle.com>
2914
2915 * ../Makefile.def (dependencies): Add all-libctf to all-gdb
2916 * ../Makefile.in: Add "all-gdb: maybe-all-libctf"
2917 * ctfread.c: New file.
2918 * ctfread.h: New file.
2919 * elfread.c: Include ctfread.h.
2920 (struct elfinfo text_p): New member ctfsect.
2921 (elf_locate_sections): Mark CTF section.
2922 (elf_symfile_read): Call elfctf_build_psymtabs.
2923 * Makefile.in (LIBCTF): Add.
2924 (CLIBS): Use it.
2925 (CDEPS): Likewise.
2926 (DIST): Add ctfread.c.
2927
2928 2019-10-07 Andrew Burgess <andrew.burgess@embecosm.com>
2929
2930 * ctfread.c (struct nextfield): Renamed to ...
2931 (struct ctf_nextfield): ... this.
2932 (struct field_info): Renamed to ...
2933 (strut ctf_field_info): ... this.
2934 (attach_fields_to_type): Update for renamed structures.
2935 (ctf_add_member_cb): Likewise.
2936 (ctf_add_enum_member_cb): Likewise.
2937 (process_struct_members): Likewise.
2938 (process_enum_type): Likewise.
2939
2940 2019-10-07 Weimin Pan <weimin.pan@oracle.com>
2941
2942 * tracectf.h: Rename, was ctf.h.
2943 * tracectf.c: Rename, was ctf.c, replace ctf.h with tracectf.h.
2944 * tracefile.c: Likewise.
2945 * tracepoint.c: Remove unused include ctf.h.
2946 * mi/mi-main.c: Likewise.
2947 * Makefile.in Replace ctf.c with tracectf.c.
2948
2949 2019-10-06 Joel Brobecker <brobecker@adacore.com>
2950
2951 * version.in: Change version number to "9.0.50.DATE-git".
2952
2953 2019-10-03 Tom Tromey <tom@tromey.com>
2954
2955 PR rust/24976:
2956 * dwarf2read.c (quirk_rust_enum): Handle single-element unions.
2957
2958 2019-10-03 Andrew Burgess <andrew.burgess@embecosm.com>
2959
2960 * f-lang.c (f_language_defn): Use cp_get_symbol_name_matcher and
2961 cp_search_name_hash.
2962 * NEWS: Add entry about nested function support.
2963
2964 2019-10-03 Bernhard Heckel <bernhard.heckel@intel.com>
2965 Andrew Burgess <andrew.burgess@embecosm.com>
2966
2967 * cp-namespace.c (cp_search_static_and_baseclasses): Only search
2968 for nested static variables when searchin VAR_DOMAIN.
2969 * dwarf2read.c (add_partial_symbol): Add nested subroutines to the
2970 global scope, update comment.
2971 (add_partial_subprogram): Call add_partial_subprogram recursively
2972 for nested subroutines when processinng Fortran.
2973 (load_partial_dies): Process the child entities of a subprogram
2974 when processing Fortran.
2975 (partial_die_parent_scope): Handle building scope
2976 for Fortran nested functions.
2977 (process_die): Record that nested functions have a scope.
2978 (new_symbol): Always record Fortran subprograms on the global
2979 symbol list.
2980 (determine_prefix): How to build the prefix for Fortran
2981 subprograms.
2982
2983 2019-10-03 Andrew Burgess <andrew.burgess@embecosm.com>
2984
2985 * linux-nat.c (linux_nat_filter_event): Don't ignore SIGSTOP if we
2986 have just sent the thread a SIGSTOP and are waiting for it to
2987 arrive.
2988
2989 2019-10-03 Andrew Burgess <andrew.burgess@embecosm.com>
2990
2991 * btrace.c (btrace_add_pc): Remove whitespace before the template
2992 parameter in 'std::vector <...>'.
2993 (parse_xml_btrace_block): Likewise.
2994 (btrace_maint_decode_pt): Likewise.
2995 (btrace_maint_update_packets): Likewise.
2996 (btrace_maint_print_packets): Likewise.
2997 * btrace.h (struct btrace_maint_info): Likewise.
2998 * dwarf2read.c (struct type_unit_group): Likewise.
2999 (build_type_psymtabs_reader): Likewise.
3000 * gdbsupport/btrace-common.c (btrace_data_append): Likewise.
3001 * gdbsupport/btrace-common.h (struct btrace_data_bts): Likewise.
3002 * nat/linux-btrace.c (perf_event_read_bts): Likewise.
3003
3004 2019-10-03 Tom de Vries <tdevries@suse.de>
3005
3006 * cli/cli-style.c (_initialize_cli_style): Adding a '.' at the end of
3007 the first line of the help text for set/show style metadata.
3008
3009 2019-10-02 Tom Tromey <tromey@adacore.com>
3010
3011 * Makefile.in (COMMON_SFILES): Add common-inferior.c.
3012 * gdbsupport/common-inferior.c: New file.
3013 * infcmd.c (startup_with_shell): Don't define.
3014 * nat/fork-inferior.h (startup_with_shell): Don't declare.
3015 * gdbsupport/common-inferior.h (startup_with_shell): Declare.
3016 * inferior.h (startup_with_shell): Don't declare.
3017
3018 2019-10-02 Christian Biesinger <cbiesinger@google.com>
3019
3020 * gdbsupport/gdb_assert.h: Include errors.h.
3021 * gdbsupport/gdb_string_view.h: Include gdb_assert.h.
3022
3023 2019-10-02 Tom Tromey <tromey@adacore.com>
3024
3025 * NEWS: Add $_ada_exception entry.
3026 * ada-lang.c (struct ada_catchpoint): Add constructor.
3027 <m_kind>: New member.
3028 (allocate_location_exception, re_set_exception): Remove
3029 "ex" parameter.
3030 (should_stop_exception): Compute $_ada_exception.
3031 (check_status_exception, print_it_exception)
3032 (print_one_exception, print_mention_exception): Remove
3033 "ex" parameter.
3034 (allocate_location_catch_exception, re_set_catch_exception)
3035 (check_status_exception, print_it_catch_exception)
3036 (print_one_catch_exception, print_mention_catch_exception)
3037 (print_recreate_catch_exception)
3038 (allocate_location_catch_exception_unhandled)
3039 (re_set_catch_exception_unhandled)
3040 (check_status_exception, print_it_catch_exception_unhandled)
3041 (print_one_catch_exception_unhandled)
3042 (print_mention_catch_exception_unhandled)
3043 (print_recreate_catch_exception_unhandled)
3044 (allocate_location_catch_assert, re_set_catch_assert)
3045 (check_status_assert, print_it_catch_assert)
3046 (print_one_catch_assert, print_mention_catch_assert)
3047 (print_recreate_catch_assert)
3048 (allocate_location_catch_handlers, re_set_catch_handlers)
3049 (check_status_handlers, print_it_catch_handlers)
3050 (print_one_catch_handlers, print_mention_catch_handlers)
3051 (print_recreate_catch_handlers): Remove.
3052 (create_ada_exception_catchpoint): Update.
3053 (initialize_ada_catchpoint_ops): Update.
3054
3055 2019-10-02 Tom Tromey <tromey@adacore.com>
3056
3057 * ada-lang.c (ada_lookup_simple_minsyms): Remove.
3058 (create_excep_cond_exprs): Simplify exception string computation.
3059 (ada_exception_catchpoint_cond_string): Likewise.
3060
3061 2019-10-02 Tom Tromey <tromey@adacore.com>
3062
3063 * symmisc.c (dump_msymbols): Don't use MSYMBOL_VALUE_ADDRESS.
3064 * ada-lang.c (lesseq_defined_than): Handle
3065 LOC_STATIC.
3066 * dwarf2read.c (dwarf2_per_objfile): Add can_copy
3067 parameter.
3068 (dwarf2_has_info): Likewise.
3069 (new_symbol): Set maybe_copied on symbol when
3070 appropriate.
3071 * dwarf2read.h (dwarf2_per_objfile): Add can_copy
3072 parameter.
3073 <can_copy>: New member.
3074 * elfread.c (record_minimal_symbol): Set maybe_copied
3075 on symbol when appropriate.
3076 (elf_symfile_read): Update call to dwarf2_has_info.
3077 * minsyms.c (lookup_minimal_symbol_linkage): New
3078 function.
3079 * minsyms.h (lookup_minimal_symbol_linkage): Declare.
3080 * symtab.c (get_symbol_address, get_msymbol_address):
3081 New functions.
3082 * symtab.h (get_symbol_address, get_msymbol_address):
3083 Declare.
3084 (SYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_ADDRESS): Handle
3085 maybe_copied.
3086 (struct symbol, struct minimal_symbol) <maybe_copied>:
3087 New member.
3088
3089 2019-10-02 Tom Tromey <tromey@adacore.com>
3090
3091 * source.c (struct current_source_location): New.
3092 (current_source_key): New global.
3093 (current_source_symtab, current_source_line)
3094 (current_source_pspace): Remove.
3095 (get_source_location): New function.
3096 (get_current_source_symtab_and_line)
3097 (set_default_source_symtab_and_line)
3098 (set_current_source_symtab_and_line)
3099 (clear_current_source_symtab_and_line, select_source_symtab)
3100 (info_source_command, print_source_lines_base)
3101 (info_line_command, search_command_helper, _initialize_source):
3102 Update.
3103
3104 2019-10-02 Tom Tromey <tromey@adacore.com>
3105
3106 * source.c (select_source_symtab): Don't call
3107 decode_line_with_current_source.
3108
3109 2019-10-02 Andrew Burgess <andrew.burgess@embecosm.com>
3110
3111 * symtab.c (lookup_global_symbol): Search global block.
3112
3113 2019-10-02 Tom Tromey <tromey@adacore.com>
3114
3115 * coffread.c (process_coff_symbol): Update.
3116 * dwarf2read.c (var_decode_location, new_symbol): Update.
3117 * mdebugread.c (parse_symbol): Update.
3118 * objfiles.c (relocate_one_symbol): Update.
3119 * stabsread.c (define_symbol, fix_common_block)
3120 (scan_file_globals): Update.
3121 * symtab.h (SYMBOL_VALUE_ADDRESS): Expand to an rvalue.
3122 (SET_SYMBOL_VALUE_ADDRESS): New macro.
3123 * xcoffread.c (process_xcoff_symbol): Update.
3124
3125 2019-10-02 Andreas Arnez <arnez@linux.ibm.com>
3126
3127 * MAINTAINERS: Update my email address.
3128
3129 2019-10-02 Andrew Burgess <andrew.burgess@embecosm.com>
3130
3131 * dwarf2read.c (struct type_unit_group) <tus>: Convert to
3132 std::vector.
3133 (build_type_psymtabs_reader): Update for std::vector.
3134 (build_type_psymtab_dependencies): Likewise.
3135 * dwarf2read.h: Remove use of DEF_VEC_P.
3136 (typedef sig_type_ptr): Delete.
3137
3138 2019-10-02 Andrew Burgess <andrew.burgess@embecosm.com>
3139
3140 * btrace.c (btrace_maint_clear): Update to handle change from VEC
3141 to std::vector.
3142 (btrace_maint_decode_pt): Likewise, and move allocation of the
3143 vector outside of the loop.
3144 (btrace_maint_update_packets): Update to handle change from VEC to
3145 std::vector.
3146 (btrace_maint_print_packets): Likewise.
3147 (maint_info_btrace_cmd): Likewise.
3148 * btrace.h: Remove use of DEF_VEC_O.
3149 (typedef btrace_pt_packet_s): Delete.
3150 (struct btrace_maint_info) <packets>: Change fromm VEC to
3151 std::vector.
3152 * gdbsupport/btrace-common.h: Remove 'vec.h' include.
3153
3154 2019-10-02 Andrew Burgess <andrew.burgess@embecosm.com>
3155
3156 * btrace.c (btrace_compute_ftrace_bts): Update for std::vector,
3157 make accesses into the vector constant references.
3158 (btrace_add_pc): Update for std::vector.
3159 (btrace_stitch_bts): Likewise.
3160 (parse_xml_btrace_block): Likewise.
3161 (btrace_maint_update_packets): Likewise.
3162 (btrace_maint_print_packets): Likewise.
3163 (maint_info_btrace_cmd): Likewise.
3164 * gdbsupport/btrace-common.c (btrace_data::fini): Update for
3165 std::vector.
3166 (btrace_data::empty): Likewise.
3167 (btrace_data_append): Likewise.
3168 * gdbsupport/btrace-common.h: Remove use of DEF_VEC_O.
3169 (typedef btrace_block_s): Delete.
3170 (struct btrace_block): Add constructor.
3171 (struct btrace_data_bts) <blocks>: Change to std::vector.
3172 * nat/linux-btrace.c (perf_event_read_bts): Update for
3173 std::vector.
3174 (linux_read_bts): Likewise.
3175
3176 2019-10-01 Tom Tromey <tom@tromey.com>
3177
3178 * cli/cli-logging.c (show_logging_filename): Use styled_string.
3179
3180 2019-10-01 Tom Tromey <tom@tromey.com>
3181
3182 * stack.c (print_frame, info_frame_command_core): Use
3183 styled_string.
3184 * linux-thread-db.c (try_thread_db_load_1)
3185 (try_thread_db_load_from_pdir_1): Use styled_string.
3186 * auto-load.c (file_is_auto_load_safe, execute_script_contents)
3187 (auto_load_section_scripts, info_auto_load_local_gdbinit)
3188 (maybe_print_unsupported_script_warning)
3189 (maybe_print_script_not_found_warning): Use styled_string.
3190 * ada-lang.c (user_select_syms): Use styled_string.
3191
3192 2019-10-01 Tom Tromey <tom@tromey.com>
3193
3194 * p-lang.c (pascal_printstr): Use metadata style.
3195 * value.c (show_convenience): Use metadata style.
3196 * valprint.c (valprint_check_validity, val_print_optimized_out)
3197 (val_print_not_saved, val_print_unavailable)
3198 (val_print_invalid_address, generic_val_print, val_print)
3199 (value_check_printable, val_print_array_elements): Use metadata
3200 style.
3201 * ui-out.h (class ui_out) <field_fmt>: New overload.
3202 <do_field_fmt>: Add style parameter.
3203 * ui-out.c (ui_out::field_fmt): New overload.
3204 * typeprint.c (type_print_unknown_return_type)
3205 (val_print_not_allocated, val_print_not_associated): Use metadata
3206 style.
3207 * tui/tui-out.h (class tui_ui_out) <do_field_fmt>: Add style
3208 parameter.
3209 * tui/tui-out.c (tui_ui_out::do_field_fmt): Update.
3210 * tracepoint.c (tvariables_info_1): Use metadata style.
3211 * stack.c (print_frame_arg, print_frame_info, print_frame)
3212 (info_frame_command_core): Use metadata style.
3213 * skip.c (info_skip_command): Use metadata style.
3214 * rust-lang.c (rust_print_enum): Use metadata style.
3215 * python/py-prettyprint.c (print_stack_unless_memory_error): Use
3216 metadata style.
3217 * python/py-framefilter.c (py_print_single_arg): Use metadata
3218 style.
3219 * printcmd.c (do_one_display, print_variable_and_value): Use
3220 metadata style.
3221 * p-valprint.c (pascal_val_print)
3222 (pascal_object_print_value_fields): Use metadata style.
3223 * p-typeprint.c (pascal_type_print_base): Use metadata style.
3224 * mi/mi-out.h (class mi_ui_out) <do_field_fmt>: Add style
3225 parameter.
3226 * mi/mi-out.c (mi_ui_out::do_field_fmt): Update.
3227 * m2-valprint.c (m2_print_long_set): Use metadata style.
3228 * m2-typeprint.c (m2_print_type): Use metadata style.
3229 * infcmd.c (print_return_value_1): Use metadata style.
3230 * gnu-v3-abi.c (print_one_vtable): Use metadata style.
3231 * f-valprint.c (info_common_command_for_block): Use metadata
3232 style.
3233 * f-typeprint.c (f_type_print_base): Use metadata style.
3234 * expprint.c (print_subexp_standard): Use metadata style.
3235 * cp-valprint.c (cp_print_value_fields): Use metadata style.
3236 * cli/cli-style.h (class cli_style_option): Add constructor.
3237 (metadata_style): Declare.
3238 * cli/cli-style.c (metadata_style): New global.
3239 (_initialize_cli_style): Register metadata style.
3240 * cli-out.h (class cli_ui_out) <do_field_fmt>: Add style
3241 parameter.
3242 * cli-out.c (cli_ui_out::do_field_fmt): Update.
3243 * c-typeprint.c (c_type_print_base_struct_union)
3244 (c_type_print_base_1): Use metadata style.
3245 * breakpoint.c (watchpoint_value_print)
3246 (print_one_breakpoint_location): Use metadata style.
3247 * break-catch-syscall.c (print_one_catch_syscall): Use metadata
3248 style.
3249 * break-catch-sig.c (signal_catchpoint_print_one): Use metadata
3250 style.
3251 * ada-valprint.c (val_print_packed_array_elements, printstr)
3252 (print_field_values, ada_val_print_ref, ada_val_print): Use
3253 metadata style.
3254 * ada-typeprint.c (print_array_type, ada_print_type): Use metadata
3255 style.
3256 * ada-tasks.c (print_ada_task_info, info_task): Use metadata
3257 style.
3258 * ada-lang.c (user_select_syms): Use metadata style.
3259
3260 2019-10-01 Tom Tromey <tom@tromey.com>
3261
3262 * cli/cli-cmds.c (pwd_command): Style output.
3263
3264 2019-10-01 Pedro Alves <palves@redhat.com>
3265 Tom Tromey <tom@tromey.com>
3266
3267 * symtab.c (print_symbol_info): Use %ps.
3268 (print_msymbol_info): Use %ps.
3269 * symfile.c (symbol_file_add_with_addrs): Use %ps.
3270 * printcmd.c (print_variable_and_value): Use %ps.
3271 * macrocmd.c (show_pp_source_pos): Use %ps.
3272 * infrun.c (print_exited_reason): Use ui_out::message.
3273 * breakpoint.c (watchpoint_check, print_one_breakpoint_location)
3274 (describe_other_breakpoints): Use ui_out::message and new
3275 formats.
3276 (say_where): Use new formats.
3277 (bkpt_print_it, tracepoint_print_one_detail): Use ui_out::message
3278 and new formats.
3279
3280 2019-10-01 Pedro Alves <palves@redhat.com>
3281 Tom Tromey <tom@tromey.com>
3282
3283 * unittests/format_pieces-selftests.c: Add gdb_format parameter.
3284 (test_gdb_formats): New function.
3285 (run_tests): Call it.
3286 (test_format_specifier): Update.
3287 * utils.h (fputs_filtered): Update comment.
3288 (vfprintf_styled, vfprintf_styled_no_gdbfmt)
3289 (fputs_styled_unfiltered): Declare.
3290 * utils.c (fputs_styled_unfiltered): New function.
3291 (vfprintf_maybe_filtered): Add gdbfmt parameter.
3292 (vfprintf_filtered): Update.
3293 (vfprintf_unfiltered, vprintf_filtered): Update.
3294 (vfprintf_styled, vfprintf_styled_no_gdbfmt): New functions.
3295 * ui-out.h (enum ui_out_flag) <unfiltered_output,
3296 disallow_ui_out_field>: New constants.
3297 (enum class field_kind): New.
3298 (struct base_field_s, struct signed_field_s): New.
3299 (signed_field): New function.
3300 (struct string_field_s): New.
3301 (string_field): New function.
3302 (struct styled_string_s): New.
3303 (styled_string): New function.
3304 (class ui_out) <message>: Add comment.
3305 <vmessage, call_do_message>: New methods.
3306 <do_message>: Add style parameter.
3307 * ui-out.c (ui_out::call_do_message, ui_out::vmessage): New
3308 methods.
3309 (ui_out::message): Rewrite.
3310 * mi/mi-out.h (class mi_ui_out) <do_message>: Add style
3311 parameter.
3312 * mi/mi-out.c (mi_ui_out::do_message): Add style parameter.
3313 * gdbsupport/format.h (class format_pieces) <format_pieces>: Add
3314 gdb_extensions parameter.
3315 (class format_piece): Add parameter to constructor.
3316 (n_int_args): New field.
3317 * gdbsupport/format.c (format_pieces::format_pieces): Add
3318 gdb_extensions parameter. Handle '*'.
3319 * cli-out.h (class cli_ui_out) <do_message>: Add style parameter.
3320 * cli-out.c (cli_ui_out::do_message): Add style parameter. Call
3321 vfprintf_styled_no_gdbfmt.
3322 (cli_ui_out::do_field_string, cli_ui_out::do_spaces)
3323 (cli_ui_out::do_text, cli_ui_out::field_separator): Allow
3324 unfiltered output.
3325 * ui-style.h (struct ui_file_style) <ptr>: New method.
3326
3327 2019-10-01 Tom Tromey <tom@tromey.com>
3328
3329 * unittests/format_pieces-selftests.c: Update. Add final format.
3330 * gdbsupport/format.c (format_pieces::format_pieces): Don't add
3331 empty literal pieces.
3332
3333 2019-10-01 Tom Tromey <tom@tromey.com>
3334
3335 * ui-out.h (enum class ui_out_style_kind): Remove.
3336 (class ui_out) <field_string, field_stsream, do_field_string>:
3337 Change type of "style".
3338 * ui-out.c (ui_out::field_core_addr, ui_out::field_stream)
3339 (ui_out::field_string): Update.
3340 * tui/tui-out.h (class tui_ui_out) <do_field_string>: Change type
3341 of "style".
3342 * tui/tui-out.c (tui_ui_out::do_field_string): Update.
3343 * tracepoint.c (print_one_static_tracepoint_marker): Update.
3344 * stack.c (print_frame_arg, print_frame_info, print_frame):
3345 Update.
3346 * source.c (print_source_lines_base): Update.
3347 * solib.c (info_sharedlibrary_command): Update.
3348 * skip.c (info_skip_command): Update.
3349 * record-btrace.c (btrace_call_history_src_line)
3350 (btrace_call_history): Update.
3351 * python/py-framefilter.c (py_print_frame): Update.
3352 * mi/mi-out.h (class mi_ui_out) <do_field_string>: Change type of
3353 "style".
3354 * mi/mi-out.c (mi_ui_out::do_table_header)
3355 (mi_ui_out::do_field_signed, mi_ui_out::do_field_unsigned)
3356 (mi_ui_out::do_field_string): Update.
3357 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
3358 Update.
3359 * cli-out.h (class cli_ui_out) <do_field_string>: Change type of
3360 "style".
3361 * cli-out.c (cli_ui_out::do_table_header)
3362 (cli_ui_out::do_field_signed, cli_ui_out::do_field_unsigned)
3363 (cli_ui_out::do_field_skip, cli_ui_out::do_field_string)
3364 (cli_ui_out::do_field_fmt): Update.
3365 * breakpoint.c (print_breakpoint_location): Update.
3366 (update_static_tracepoint): Update.
3367
3368 2019-10-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
3369
3370 * main.c (relocate_gdbinit_path_maybe_in_datadir): Remove std::string
3371 conversion of gdb_datadir.
3372 (captured_main_1): Remove xstrdup when assigning to gdb_datadir,
3373 remove not needed c_str ().
3374
3375 2019-09-30 Ali Tamur <tamur@google.com>
3376
3377 * dwarf2read.c (skip_one_die): Handle DW_FORM_strx forms.
3378 (dwarf2_string_attr): Likewise.
3379
3380 2019-09-30 Ali Tamur <tamur@google.com>
3381
3382 * dwarf2read.c (process_full_comp_unit): Remove whitespace at the EOL.
3383 (process_full_type_unit): Likewise.
3384 (dump_die_shallow): Likewise.
3385 (cu_debug_loc_section): Likewise.
3386
3387 2019-09-28 Christian Biesinger <cbiesinger@google.com>
3388
3389 * minsyms.c (compare_minimal_symbols): Rename to...
3390 (minimal_symbol_is_less_than): ...this, and adjust to STL
3391 conventions (return bool, take arguments as references)
3392 (minimal_symbol_reader::install): Call std::sort instead
3393 of qsort.
3394
3395 2019-09-29 Christian Biesinger <cbiesinger@google.com>
3396
3397 * minsyms.h (msymbol_hash): Document that this is a case-insensitive
3398 hash and why.
3399 * objfiles.h (struct objfile_per_bfd_storage) <demangled_names_hash,
3400 msymbol_hash, msymbol_demangled_hash>: Improve comments.
3401
3402 2019-09-30 Simon Marchi <simon.marchi@polymtl.ca>
3403
3404 * psymtab.c (add_psymbol_to_list): Move comment to psympriv.h.
3405 * psympriv.h (add_psymbol_to_list): Move comment here and update
3406 it.
3407
3408 2019-09-29 Tom de Vries <tdevries@suse.de>
3409
3410 * contrib/cc-with-tweaks.sh (get_tmpdir): New function.
3411 Use $tmpdir/$(basename "$output_file").dwz instead of
3412 "${output_file}.dwz".
3413
3414 2019-09-28 Simon Marchi <simon.marchi@polymtl.ca>
3415
3416 PR gdb/25045
3417 * hppa-linux-nat.c: Include gdbarch.h.
3418
3419 2019-09-26 Christian Biesinger <cbiesinger@google.com>
3420
3421 * blockframe.c (find_pc_partial_function): Change return type to bool.
3422 * elfread.c (elf_gnu_ifunc_resolve_name): Likewise.
3423 * minsyms.c (in_gnu_ifunc_stub): Likewise.
3424 (stub_gnu_ifunc_resolve_name): Likewise.
3425 * symtab.c (compare_filenames_for_search): Likewise.
3426 (compare_glob_filenames_for_search): Likewise.
3427 (matching_obj_sections): Likewise.
3428 (symbol_matches_domain): Likewise.
3429 (find_line_symtab): Change out param EXACT_MATCH to bool *.
3430 (find_line_pc): Change return type to bool.
3431 (find_line_pc_range): Likewise.
3432 (producer_is_realview): Likewise.
3433 * symtab.h (symbol_matches_domain): Likewise.
3434 (find_pc_partial_function): Likewise.
3435 (find_pc_line_pc_range): Likewise.
3436 (in_gnu_ifunc_stub): Likewise.
3437 (struct gnu_ifunc_fns) <gnu_ifunc_resolve_name>: Likewise.
3438 (find_line_pc): Likewise.
3439 (find_line_pc_range): Likewise.
3440 (matching_obj_sections): Likewise.
3441 (find_line_symtab): Change out parameter to bool.
3442 (producer_is_realview): Change return type to bool.
3443 (compare_filenames_for_search): Likewise.
3444 (compare_glob_filenames_for_search): Likewise.
3445
3446 2019-09-26 Tom Tromey <tom@tromey.com>
3447
3448 * Makefile.in (COMMON_SFILES): Remove gdb_usleep.c.
3449 (HFILES_NO_SRCDIR): Remove gdb_usleep.h.
3450 * gdb_usleep.h: Remove.
3451 * gdb_usleep.c: Remove.
3452 * utils.c: Don't include gdb_usleep.h.
3453
3454 2019-09-26 Tom Tromey <tromey@adacore.com>
3455
3456 * python/py-type.c (type_to_type_object): Call check_typedef
3457 for stub types.
3458
3459 2019-09-26 Tom Tromey <tom@tromey.com>
3460
3461 * utils.h (initialize_utils): Don't declare.
3462 * top.c (gdb_init): Don't call initialize_utils.
3463 * utils.c (initialize_utils): Remove. Move contents...
3464 (_initialize_utils): ... here.
3465
3466 2019-09-25 Tom Tromey <tom@tromey.com>
3467
3468 * python/py-objfile.c (objfpy_get_build_id): Use bin2hex.
3469 * utils.h (make_hex_string): Don't declare.
3470 * utils.c (make_hex_string): Remove.
3471
3472 2019-09-24 Tom de Vries <tdevries@suse.de>
3473
3474 PR gdb/23815
3475 * amd64-linux-nat.c (amd64_linux_nat_target::fetch_registers):
3476 Initialize xstateregs before ptrace PTRACE_GETREGSET call.
3477
3478 2019-09-23 Dimitar Dimitrov <dimitar@dinux.eu>
3479
3480 * NEWS: Mention new simulator port for PRU.
3481
3482 2019-09-23 Christian Biesinger <cbiesinger@google.com>
3483
3484 * ada-exp.y (write_object_remaining): Update.
3485 * ada-lang.c (ada_decode): Return a std::string instead of a char*
3486 and eliminate the static buffer.
3487 (ada_decode_symbol): Update.
3488 (ada_la_decode): Update.
3489 (ada_sniff_from_mangled_name): Update.
3490 (is_valid_name_for_wild_match): Update.
3491 (ada_lookup_name_info::matches): Update and simplify.
3492 (name_matches_regex): Update.
3493 (ada_add_global_exceptions): Update.
3494 * ada-lang.h (ada_decode): Update signature.
3495 * ada-varobj.c (ada_varobj_describe_simple_array_child): Update.
3496 * dwarf-index-write.c (debug_names::insert): Update.
3497
3498 2019-09-21 Simon Marchi <simon.marchi@polymtl.ca>
3499
3500 * solib-svr4.c (svr4_iterate_over_objfiles_in_search_order): Fix
3501 formatting.
3502
3503 2019-09-21 Simon Marchi <simon.marchi@polymtl.ca>
3504
3505 * breakpoint.h (bp_location) <inserted, permanent, duplicate>:
3506 Change "nonzero" to "true" in documentation.
3507
3508 2019-09-20 Christian Biesinger <cbiesinger@google.com>
3509
3510 * solib-darwin.c (darwin_lookup_lib_symbol): Remove.
3511 (_initialize_darwin_solib): Don't set
3512 darwin_so_ops.lookup_lib_global_symbol.
3513 * solib-svr4.c (set_solib_svr4_fetch_link_map_offsets): Call
3514 set_gdbarch_iterate_over_objfiles_in_search_order.
3515 (elf_lookup_lib_symbol): Rename to...
3516 (svr4_iterate_over_objfiles_in_search_order): this, and update
3517 to iterate semantics.
3518 (_initialize_svr4_solib): Don't set lookup_lib_global_symbol.
3519 * solib.c (solib_global_lookup): Remove.
3520 * solist.h (struct target_so_ops): Remove lookup_lib_global_symbol.
3521 (solib_global_lookup): Remove.
3522 * symtab.c (lookup_global_or_static_symbol): Remove call to
3523 solib_global_lookup.
3524
3525 2019-09-20 Joel Brobecker <brobecker@adacore.com>
3526
3527 * NEWS: Move entries about default MI version now being
3528 version 3, and about the GDB/MI fix for multi-location
3529 breakpoints to the "since GDB 8.3" section.
3530
3531 2019-09-20 Joel Brobecker <brobecker@adacore.com>
3532
3533 GDB 8.3.1 released.
3534
3535 2019-09-20 Ulrich Weigand <uweigand@de.ibm.com>
3536
3537 * NEWS: Mention that Cell/B.E. debugging support was removed.
3538 * MAINTAINERS: Remove spu target.
3539
3540 * config/djgpp/fnchange.lst: Remove entries for removed files.
3541
3542 * Makefile.in (ALL_TARGET_OBS): Remove solib-spu.o,
3543 spu-multiarch.o, and spu-tdep.o.
3544 (HFILES_NO_SRCDIR): Remove solib-spu.h and spu-tdep.h.
3545 (ALLDEPFILES): Remove solib-spu.c, spu-linux-nat.c,
3546 spu-multiarch.c, and spu-tdep.c.
3547 * spu-linux-nat.c: Remove file.
3548 * spu-multiarch.c: Remove file.
3549 * spu-tdep.c: Remove file.
3550 * spu-tdep.h: Remove file.
3551 * solib-spu.c: Remove file.
3552 * solib-spu.h: Remove file.
3553
3554 * configure.host (powerpc64*-*-linux*): Remove Cell/B.E. support.
3555 * configure.nat (spu-linux): Remove.
3556 * configure.tgt (powerpc*-*-linux*): Remove solib-spu.o and
3557 solib-multiarch.o from gdb_target_obs.
3558 (spu*-*-*): Remove.
3559
3560 * arch/ppc-linux-common.h (struct ppc_linux_features): Remove "cell"
3561 feature flag.
3562 (ppc_linux_no_features): Update.
3563 * arch/ppc-linux-common.c (ppc_linux_match_description): Remove
3564 Cell/B.E. support.
3565 * arch/ppc-linux-tdesc.h (tdesc_powerpc_cell32l): Remove declaration.
3566 (tdesc_powerpc_cell64l): Likewise.
3567 * nat/ppc-linux.h (PPC_FEATURE_CELL): Remove.
3568 * ppc-linux-nat.c (ppc_linux_nat_target::read_description): Remove
3569 Cell/B.E. support.
3570 * ppc-linux-tdep.h: Do not include "solib-spu.h" or "spu-tdep.h".
3571 Do not include "features/rs6000/powerpc-cell32l.c" or
3572 "features/rs6000/powerpc-cell64l.c".
3573 (ppc_linux_spu_section): Remove.
3574 (ppc_linux_core_read_description): Remove Cell/B.E. support.
3575 (spe_context_objfile, spe_context_lm_addr, spe_context_offset,
3576 spe_context_cache_ptid, spe_context_cache_ptid): Remove.
3577 (ppc_linux_spe_context_lookup): Remove.
3578 (ppc_linux_spe_context_inferior_created): Remove.
3579 (ppc_linux_spe_context_solib_loaded): Remove.
3580 (ppc_linux_spe_context_solib_unloaded): Remove.
3581 (ppc_linux_spe_context): Remove.
3582 (struct ppu2spu_cache): Remove.
3583 (ppu2spu_prev_arch, ppu2spu_this_id, ppu2spu_prev_register): Remove.
3584 (struct ppu2spu_data): Remove.
3585 (ppu2spu_unwind_register, ppu2spu_sniffer, ppu2spu_dealloc_cache,
3586 ppu2spu_unwind): Remove.
3587 (ppc_linux_init_abi): Remove Cell/B.E. support.
3588 * rs6000-tdep.h (rs6000_gdbarch_init): Remove Cell/B.E. support.
3589
3590 * features/Makefile (rs6000/powerpc-cell32l-expedite): Remove.
3591 (rs6000/powerpc-cell64l-expedite): Likewise
3592 (WHICH): Remove rs6000/powerpc-cell32l and rs6000/powerpc-cell64l.
3593 (XMLTOC): Remove rs6000/powerpc-cell32l.xml and
3594 rs6000/powerpc-cell64l.xml.
3595 * features/rs6000/powerpc-cell32l.xml: Remove.
3596 * features/rs6000/powerpc-cell64l.xml: Likewise.
3597 * features/rs6000/powerpc-cell32l.c: Remove generated file.
3598 * features/rs6000/powerpc-cell64l.c: Likewise.
3599 * regformats/rs6000/powerpc-cell32l.dat: Remove generated file.
3600 * regformats/rs6000/powerpc-cell64l.dat: Likewise.
3601 * regformats/reg-spu.dat: Remove.
3602
3603 * target.h (enum target_object): Remove TARGET_OBJECT_SPU.
3604 * corelow.c (struct spuid_list): Remove.
3605 (add_to_spuid_list): Remove.
3606 (core_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
3607 * remote.c (PACKET_qXfer_spu_read, PACKET_qXfer_spu_write): Remove.
3608 (remote_protocol_features): Remove associated entries.
3609 (_initialize_remote): No longer initialize them.
3610 (remote_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
3611 * linux-nat.c (SPUFS_MAGIC): Remove.
3612 (linux_proc_xfer_spu): Remove.
3613 (spu_enumerate_spu_ids): Remove.
3614 (linux_nat_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
3615 * linux-tdep.c (-linux_spu_make_corefile_notes): Remove.
3616 (linux_make_corefile_notes): No longer call it.
3617
3618 * regcache.c (cooked_read_test): Remove bfd_arch_spu special case.
3619 (cooked_write_test): Likewise.
3620
3621 2019-09-20 Tom Tromey <tom@tromey.com>
3622
3623 * NEWS: Mention case-sensitivity of TUI commands.
3624 * tui/tui-win.c (tui_set_focus_command): Now case-sensitive.
3625 (tui_set_win_height_command, parse_scrolling_args): Likewise.
3626 * tui/tui-layout.c (tui_layout_command): Now case-sensitive.
3627
3628 2019-09-20 Tom Tromey <tom@tromey.com>
3629
3630 * tui/tui-source.c (tui_source_window::set_contents): Use
3631 make_unique_xstrdup.
3632 * tui/tui-disasm.c (tui_disasm_window::set_contents): Use
3633 make_unique_xstrdup.
3634
3635 2019-09-20 Tom Tromey <tom@tromey.com>
3636
3637 * tui/tui-data.c: Remove separator comments.
3638 * tui/tui-layout.c: Remove separator comments.
3639 * tui/tui-win.c: Remove separator comments.
3640 * tui/tui-wingeneral.c: Remove separator comments.
3641
3642 2019-09-20 Tom Tromey <tom@tromey.com>
3643
3644 * tui/tui.h (strcat_to_buf): Don't declare.
3645 * tui/tui.c (strcat_to_buf): Remove.
3646
3647 2019-09-20 Tom Tromey <tom@tromey.com>
3648
3649 * tui/tui-source.h (struct tui_source_window) <m_fullname>: Rename
3650 from "fullname".
3651 * tui/tui-source.c (tui_source_window::set_contents)
3652 (tui_source_window::location_matches_p)
3653 (tui_source_window::maybe_update): Update.
3654
3655 2019-09-20 Tom Tromey <tom@tromey.com>
3656
3657 * tui/tui-regs.h (struct tui_data_window) <get_current_group>:
3658 Update.
3659 <m_regs_content, m_regs_column_count, m_current_group>: Add "m_"
3660 prefix.
3661 * tui/tui-regs.c (tui_data_window::last_regs_line_no)
3662 (tui_data_window::line_from_reg_element_no)
3663 (tui_data_window::first_reg_element_no_inline)
3664 (tui_data_window::show_registers)
3665 (tui_data_window::show_register_group)
3666 (tui_data_window::display_registers_from)
3667 (tui_data_window::display_registers_from_line)
3668 (tui_data_window::first_data_item_displayed)
3669 (tui_data_window::delete_data_content_windows)
3670 (tui_data_window::erase_data_content)
3671 (tui_data_window::do_scroll_vertical)
3672 (tui_data_window::refresh_window)
3673 (tui_data_window::check_register_values): Update.
3674
3675 2019-09-20 Tom Tromey <tom@tromey.com>
3676
3677 * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN): Remove define.
3678 (struct tui_locator_window) <full_name, proc_name>: Now
3679 std::string.
3680 * tui/tui-stack.c (tui_locator_window::make_status_line)
3681 (tui_locator_window::set_locator_fullname)
3682 (tui_locator_window::set_locator_info): Update.
3683 * tui/tui-source.c (tui_source_window::set_contents)
3684 (tui_source_window::showing_source_p): Update.
3685
3686 2019-09-20 Tom Tromey <tom@tromey.com>
3687
3688 * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
3689 Don't call tui_locator_win_info_ptr.
3690
3691 2019-09-20 Tom Tromey <tom@tromey.com>
3692
3693 * tui/tui-win.c (tui_resize_all): Don't call refresh.
3694
3695 2019-09-20 Tom Tromey <tom@tromey.com>
3696
3697 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use 1 as
3698 height for locator.
3699 * tui/tui-stack.c (tui_locator_window::rerender): Call scrollok.
3700 * tui/tui-layout.c (show_source_disasm_command, show_data)
3701 (show_source_or_disasm_and_command): Use 1 as height for locator.
3702
3703 2019-09-20 Tom Tromey <tom@tromey.com>
3704
3705 * tui/tui.c (tui_enable): Update.
3706 * tui/tui-win.c (tui_sigwinch_handler, tui_async_resize_screen):
3707 Update.
3708 * tui/tui-data.h (tui_win_resized, tui_set_win_resized_to):
3709 Update.
3710 * tui/tui-data.c (win_resized): Now bool.
3711 (tui_win_resized): Return bool.
3712 (tui_set_win_resized_to): Accept a bool.
3713
3714 2019-09-20 Tom Tromey <tom@tromey.com>
3715
3716 * tui/tui-regs.h (struct tui_data_window) <show_register_group>:
3717 Change type of "refresh_values_only".
3718 * tui/tui-regs.c (tui_data_window::show_register_group): Change
3719 type of "refresh_values_only".
3720
3721 2019-09-20 Tom Tromey <tom@tromey.com>
3722
3723 * tui/tui-disasm.c (struct tui_asm_line) <addr_string, insn>: Now
3724 std::string.
3725 (tui_disassemble): Add "pos" parameter.
3726 (tui_disasm_window::set_contents): Simplify.
3727
3728 2019-09-20 Tom Tromey <tom@tromey.com>
3729
3730 * tui/tui-winsource.h (struct tui_source_window_base)
3731 <show_source_content>: Now private.
3732 * tui/tui-winsource.c
3733 (tui_source_window_base::show_source_content): Don't handle empty
3734 content case.
3735
3736 2019-09-20 Tom Tromey <tom@tromey.com>
3737
3738 * tui/tui-layout.c (show_source_disasm_command)
3739 (show_source_or_disasm_and_command): Don't call
3740 show_source_content.
3741
3742 2019-09-20 Tom Tromey <tom@tromey.com>
3743
3744 * tui/tui-stack.h (struct tui_locator_window) <make_status_line>:
3745 Declare.
3746 * tui/tui-stack.c (tui_locator_window::make_status_line): Rename
3747 from tui_make_status_line.
3748 (tui_locator_window::rerender): Update.
3749
3750 2019-09-20 Tom Tromey <tom@tromey.com>
3751
3752 * tui/tui-stack.c (tui_make_status_line): Return std::string.
3753 (tui_locator_window::rerender): Update.
3754
3755 2019-09-20 Tom Tromey <tom@tromey.com>
3756
3757 * tui/tui-winsource.h (struct tui_source_window_base)
3758 <~tui_source_window_base>: Don't declare.
3759 <fullname>: Remove.
3760 * tui/tui-winsource.c (~tui_source_window_base): Remove.
3761 * tui/tui-source.h (struct tui_source_window) <fullname>: New
3762 member.
3763 * tui/tui-source.c (tui_source_window::set_contents): Update.
3764 (tui_source_window::location_matches_p)
3765 (tui_source_window::maybe_update): Update.
3766
3767 2019-09-20 Tom Tromey <tom@tromey.com>
3768
3769 * tui/tui-winsource.h (~tui_source_element): Remove.
3770 (tui_source_element): Update.
3771 (struct tui_source_element) <line>: Now a unique_xmalloc_ptr.
3772 * tui/tui-winsource.c (tui_show_source_line): Update.
3773 * tui/tui-source.c (tui_source_window::set_contents): Update.
3774 * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
3775
3776 2019-09-20 Tom Tromey <tom@tromey.com>
3777
3778 * tui/tui-data.h (tui_clear_source_windows_detail): Don't
3779 declare.
3780 * tui/tui-layout.c (tui_add_win_to_layout): Don't call
3781 tui_clear_source_windows_detail.
3782 * tui/tui-winsource.h (struct tui_source_window_base)
3783 <clear_detail>: Don't declare.
3784 * tui/tui-winsource.c (tui_source_window_base::clear_detail):
3785 Remove.
3786 * tui/tui-data.c (tui_clear_source_windows_detail): Remove.
3787
3788 2019-09-20 Tom Tromey <tromey@adacore.com>
3789
3790 PR ada/24919:
3791 * block.c (contained_in): Fix final return value.
3792
3793 2019-09-20 Alan Modra <amodra@gmail.com>
3794
3795 * gdb_bfd.c (gdb_bfd_ref, gdb_bfd_unref): Use bfd_set_usrdata.
3796 * dwarf2read.c (dwarf2_read_gdb_index, dwarf2_read_debug_names),
3797 (read_indirect_string_from_dwz): Use bfd accessor.
3798 * dwarf2read.h (struct dwz_file <filename>): Likewise.
3799 * machoread.c (macho_symfile_read_all_oso): Likewise.
3800 * solib.c (solib_bfd_open): Likewise.
3801
3802 2019-09-19 Christian Biesinger <cbiesinger@google.com>
3803
3804 * eval.c: Move declaration of overload_resolution to...
3805 * value.h: ...here.
3806
3807 2019-09-19 Christian Biesinger <cbiesinger@google.com>
3808
3809 * arm-linux-nat.c: Remove extern declaration for arm_apcs_32.
3810 * arm-linux-tdep.c: Likewise.
3811 * arm-nbsd-nat.c: Likewise.
3812 * arm-tdep.h: Declare arm_apcs_32.
3813 * arm-tdep.c: Move documentation for arm_apcs_32 to arm-tdep.h.
3814
3815 2019-09-19 Christian Biesinger <cbiesinger@google.com>
3816
3817 * dwarf2loc.c: Remove extern declaration of dwarf_always_disassemble.
3818 * dwarf2read.h: Declare dwarf_always_disassemble.
3819
3820 2019-09-19 Tom de Vries <tdevries@suse.de>
3821
3822 PR gdb/25009
3823 * source-cache.c (source_cache::ensure): Catch exception thrown during
3824 construction of the highlighter.
3825
3826 2019-09-18 Alan Modra <amodra@gmail.com>
3827
3828 * aarch64-linux-tdep.c, * arm-tdep.c, * auto-load.c,
3829 * coff-pe-read.c, * coffread.c, * corelow.c, * dbxread.c,
3830 * dicos-tdep.c, * dwarf2-frame.c, * dwarf2read.c, * elfread.c,
3831 * exec.c, * fbsd-tdep.c, * gcore.c, * gdb_bfd.c, * gdb_bfd.h,
3832 * hppa-tdep.c, * i386-cygwin-tdep.c, * i386-fbsd-tdep.c,
3833 * i386-linux-tdep.c, * jit.c, * linux-tdep.c, * machoread.c,
3834 * maint.c, * mdebugread.c, * minidebug.c, * mips-linux-tdep.c,
3835 * mips-sde-tdep.c, * mips-tdep.c, * mipsread.c, * nto-tdep.c,
3836 * objfiles.c, * objfiles.h, * osabi.c, * ppc-linux-tdep.c,
3837 * ppc64-tdep.c, * record-btrace.c, * record-full.c, * remote.c,
3838 * rs6000-aix-tdep.c, * rs6000-tdep.c, * s390-linux-tdep.c,
3839 * s390-tdep.c, * solib-aix.c, * solib-dsbt.c, * solib-frv.c,
3840 * solib-spu.c, * solib-svr4.c, * solib-target.c,
3841 * spu-linux-nat.c, * spu-tdep.c, * symfile-mem.c, * symfile.c,
3842 * symmisc.c, * symtab.c, * target.c, * windows-nat.c,
3843 * xcoffread.c, * cli/cli-dump.c, * compile/compile-object-load.c,
3844 * mi/mi-interp.c: Update throughout for bfd section macro and
3845 function changes.
3846 * gcore (gcore_create_callback): Use bfd_set_section_lma.
3847 * spu-tdep.c (spu_overlay_new_objfile): Likewise.
3848
3849 2019-09-18 Tom Tromey <tom@tromey.com>
3850
3851 * NEWS: Add entry.
3852 * tui/tui.c (tui_initialize_readline): Set name of keymap. Do not
3853 call rl_initialize.
3854 (tui_enable): Do not call rl_initialize.
3855
3856 2019-09-18 Christian Groessler <chris@groessler.org>
3857
3858 * alpha-linux-nat.c: Include gdbarch.h.
3859
3860 2019-09-18 Simon Marchi <simon.marchi@polymtl.ca>
3861
3862 * ui-file.c: Include cli/cli-style.h.
3863 (term_cli_styling): Remove cli_styling declaration.
3864
3865 2019-09-18 Alan Modra <amodra@gmail.com>
3866
3867 * arm-tdep.c (arm_record_special_symbol): Update bfd_get_section
3868 to bfd_asymbol_section.
3869
3870 2019-09-18 Alan Modra <amodra@gmail.com>
3871
3872 * amd64-dicos-tdep.c (amd64_dicos_osabi_sniffer): Constify target.
3873 * i386-cygwin-tdep.c (i386_cygwin_init_abi): Likewise.
3874 * i386-dicos-tdep.c (i386_dicos_osabi_sniffer): Likewise.
3875
3876 2019-09-18 Alan Modra <amodra@gmail.com>
3877
3878 * solib-spu.c (spu_bfd_open): Use bfd_set_filename.
3879 * spu-linux-nat.c (spu_bfd_open): Likewise.
3880
3881 2019-09-18 Christian Biesinger <cbiesinger@google.com>
3882
3883 * dwarf2loc.c: Change extern declaration of dwarf_always_disassemble
3884 to bool to match definition in dwarf2read.c.
3885
3886 2019-09-17 Christian Biesinger <cbiesinger@google.com>
3887
3888 * ada-lang.c (ada_ignore_descriptive_types_p): Change to bool.
3889 (print_signatures): Likewise.
3890 (trust_pad_over_xvs): Likewise.
3891 * arch/aarch64-insn.c (aarch64_debug): Likewise.
3892 * arch/aarch64-insn.h (aarch64_debug): Likewise.
3893 * arm-linux-nat.c (arm_apcs_32): Likewise.
3894 * arm-linux-tdep.c (arm_apcs_32): Likewise.
3895 * arm-nbsd-nat.c (arm_apcs_32): Likewise.
3896 * arm-tdep.c (arm_debug): Likewise.
3897 (arm_apcs_32): Likewise.
3898 * auto-load.c (debug_auto_load): Likewise.
3899 (auto_load_gdb_scripts): Likewise.
3900 (global_auto_load): Likewise.
3901 (auto_load_local_gdbinit): Likewise.
3902 (auto_load_local_gdbinit_loaded): Likewise.
3903 * auto-load.h (global_auto_load): Likewise.
3904 (auto_load_local_gdbinit): Likewise.
3905 (auto_load_local_gdbinit_loaded): Likewise.
3906 * breakpoint.c (disconnected_dprintf): Likewise.
3907 (breakpoint_proceeded): Likewise.
3908 (automatic_hardware_breakpoints): Likewise.
3909 (always_inserted_mode): Likewise.
3910 (target_exact_watchpoints): Likewise.
3911 (_initialize_breakpoint): Update.
3912 * breakpoint.h (target_exact_watchpoints): Change to bool.
3913 * btrace.c (maint_btrace_pt_skip_pad): Likewise.
3914 * cli/cli-cmds.c (trace_commands): Likewise.
3915 * cli/cli-cmds.h (trace_commands): Likewise.
3916 * cli/cli-decode.c (add_setshow_boolean_cmd): Change int* argument
3917 to bool*.
3918 * cli/cli-logging.c (logging_overwrite): Change to bool.
3919 (logging_redirect): Likewise.
3920 (debug_redirect): Likewise.
3921 * cli/cli-option.h (option_def) <boolean>: Change return type to bool*.
3922 (struct boolean_option_def) <get_var_address_cb_>: Change return type
3923 to bool.
3924 <boolean_option_def>: Update.
3925 (struct flag_option_def): Change default type of Context to bool
3926 from int.
3927 <flag_option_def>: Change return type of var_address_cb_ to bool*.
3928 * cli/cli-setshow.c (do_set_command): Cast to bool* instead of int*.
3929 (get_setshow_command_value_string): Likewise.
3930 * cli/cli-style.c (cli_styling): Change to bool.
3931 (source_styling): Likewise.
3932 * cli/cli-style.h (source_styling): Likewise.
3933 (cli_styling): Likewise.
3934 * cli/cli-utils.h (struct qcs_flags) <quiet, cont, silent>: Change
3935 to bool.
3936 * command.h (var_types): Update comment.
3937 (add_setshow_boolean_cmd): Change int* var argument to bool*.
3938 * compile/compile-cplus-types.c (debug_compile_cplus_types): Change to
3939 bool.
3940 (debug_compile_cplus_scopes): Likewise.
3941 * compile/compile-internal.h (compile_debug): Likewise.
3942 * compile/compile.c (compile_debug): Likewise.
3943 (struct compile_options) <raw>: Likewise.
3944 * cp-support.c (catch_demangler_crashes): Likewise.
3945 * cris-tdep.c (usr_cmd_cris_version_valid): Likewise.
3946 (usr_cmd_cris_dwarf2_cfi): Likewise.
3947 * csky-tdep.c (csky_debug): Likewise.
3948 * darwin-nat.c (enable_mach_exceptions): Likewise.
3949 * dcache.c (dcache_enabled_p): Likewise.
3950 * defs.h (info_verbose): Likewise.
3951 * demangle.c (demangle): Likewise.
3952 (asm_demangle): Likewise.
3953 * dwarf-index-cache.c (debug_index_cache): Likewise.
3954 * dwarf2-frame.c (dwarf2_frame_unwinders_enabled_p): Likewise.
3955 * dwarf2-frame.h (dwarf2_frame_unwinders_enabled_p): Likewise.
3956 * dwarf2read.c (check_physname): Likewise.
3957 (use_deprecated_index_sections): Likewise.
3958 (dwarf_always_disassemble): Likewise.
3959 * eval.c (overload_resolution): Likewise.
3960 * event-top.c (set_editing_cmd_var): Likewise.
3961 (exec_done_display_p): Likewise.
3962 * event-top.h (set_editing_cmd_var): Likewise.
3963 (exec_done_display_p): Likewise.
3964 * exec.c (write_files): Likewise.
3965 * fbsd-nat.c (debug_fbsd_lwp): Likewise
3966 (debug_fbsd_nat): Likewise.
3967 * frame.h (struct frame_print_options) <print_raw_frame_arguments>:
3968 Likewise.
3969 (struct set_backtrace_options) <backtrace_past_main>: Likewise.
3970 <backtrace_past_entry> Likewise.
3971 * gdb-demangle.h (demangle): Likewise.
3972 (asm_demangle): Likewise.
3973 * gdb_bfd.c (bfd_sharing): Likewise.
3974 * gdbcore.h (write_files): Likewise.
3975 * gdbsupport/common-debug.c (show_debug_regs): Likewise.
3976 * gdbsupport/common-debug.h (show_debug_regs): Likewise.
3977 * gdbthread.h (print_thread_events): Likewise.
3978 * gdbtypes.c (opaque_type_resolution): Likewise.
3979 (strict_type_checking): Likewise.
3980 * gnu-nat.c (gnu_debug_flag): Likewise.
3981 * guile/scm-auto-load.c (auto_load_guile_scripts): Likewise.
3982 * guile/scm-param.c (pascm_variable): Add boolval.
3983 (add_setshow_generic): Update.
3984 (pascm_param_value): Update.
3985 (pascm_set_param_value_x): Update.
3986 * hppa-tdep.c (hppa_debug): Change to bool..
3987 * infcall.c (may_call_functions_p): Likewise.
3988 (coerce_float_to_double_p): Likewise.
3989 (unwind_on_signal_p): Likewise.
3990 (unwind_on_terminating_exception_p): Likewise.
3991 * infcmd.c (startup_with_shell): Likewise.
3992 * inferior.c (print_inferior_events): Likewise.
3993 * inferior.h (startup_with_shell): Likewise.
3994 (print_inferior_events): Likewise.
3995 * infrun.c (step_stop_if_no_debug): Likewise.
3996 (detach_fork): Likewise.
3997 (debug_displaced): Likewise.
3998 (disable_randomization): Likewise.
3999 (non_stop): Likewise.
4000 (non_stop_1): Likewise.
4001 (observer_mode): Likewise.
4002 (observer_mode_1): Likewise.
4003 (set_observer_mode): Update.
4004 (sched_multi): Change to bool.
4005 * infrun.h (debug_displaced): Likewise.
4006 (sched_multi): Likewise.
4007 (step_stop_if_no_debug): Likewise.
4008 (non_stop): Likewise.
4009 (disable_randomization): Likewise.
4010 * linux-tdep.c (use_coredump_filter): Likewise.
4011 (dump_excluded_mappings): Likewise.
4012 * linux-thread-db.c (auto_load_thread_db): Likewise.
4013 (check_thread_db_on_load): Likewise.
4014 * main.c (captured_main_1): Update.
4015 * maint-test-options.c (struct test_options_opts) <flag_opt, xx1_opt,
4016 xx2_opt, boolean_opt>: Change to bool.
4017 * maint-test-settings.c (maintenance_test_settings_boolean): Likewise.
4018 * maint.c (maintenance_profile_p): Likewise.
4019 (per_command_time): Likewise.
4020 (per_command_space): Likewise.
4021 (per_command_symtab): Likewise.
4022 * memattr.c (inaccessible_by_default): Likewise.
4023 * mi/mi-main.c (mi_async): Likewise.
4024 (mi_async_1): Likewise.
4025 * mips-tdep.c (mips64_transfers_32bit_regs_p): Likewise.
4026 * nat/fork-inferior.h (startup_with_shell): Likewise.
4027 * nat/linux-namespaces.c (debug_linux_namespaces): Likewise.
4028 * nat/linux-namespaces.h (debug_linux_namespaces): Likewise.
4029 * nios2-tdep.c (nios2_debug): Likewise.
4030 * or1k-tdep.c (or1k_debug): Likewise.
4031 * parse.c (parser_debug): Likewise.
4032 * parser-defs.h (parser_debug): Likewise.
4033 * printcmd.c (print_symbol_filename): Likewise.
4034 * proc-api.c (procfs_trace): Likewise.
4035 * python/py-auto-load.c (auto_load_python_scripts): Likewise.
4036 * python/py-param.c (union parmpy_variable): Add "bool boolval" field.
4037 (set_parameter_value): Update.
4038 (add_setshow_generic): Update.
4039 * python/py-value.c (copy_py_bool_obj): Change argument from int*
4040 to bool*.
4041 * python/python.c (gdbpy_parameter_value): Cast to bool* instead of
4042 int*.
4043 * ravenscar-thread.c (ravenscar_task_support): Change to bool.
4044 * record-btrace.c (record_btrace_target::store_registers): Update.
4045 * record-full.c (record_full_memory_query): Change to bool.
4046 (record_full_stop_at_limit): Likewise.
4047 * record-full.h (record_full_memory_query): Likewise.
4048 * remote-notif.c (notif_debug): Likewise.
4049 * remote-notif.h (notif_debug): Likewise.
4050 * remote.c (use_range_stepping): Likewise.
4051 (interrupt_on_connect): Likewise.
4052 (remote_break): Likewise.
4053 * ser-tcp.c (tcp_auto_retry): Likewise.
4054 * ser-unix.c (serial_hwflow): Likewise.
4055 * skip.c (debug_skip): Likewise.
4056 * solib-aix.c (solib_aix_debug): Likewise.
4057 * spu-tdep.c (spu_stop_on_load_p): Likewise.
4058 (spu_auto_flush_cache_p): Likewise.
4059 * stack.c (struct backtrace_cmd_options) <full, no_filters, hide>:
4060 Likewise.
4061 (struct info_print_options) <quiet>: Likewise.
4062 * symfile-debug.c (debug_symfile): Likewise.
4063 * symfile.c (auto_solib_add): Likewise.
4064 (separate_debug_file_debug): Likewise.
4065 * symfile.h (auto_solib_add): Likewise.
4066 (separate_debug_file_debug): Likewise.
4067 * symtab.c (basenames_may_differ): Likewise.
4068 (struct filename_partial_match_opts) <dirname, basename>: Likewise.
4069 (struct info_print_options) <quiet, exclude_minsyms>: Likewise.
4070 (struct info_types_options) <quiet>: Likewise.
4071 * symtab.h (demangle): Likewise.
4072 (basenames_may_differ): Likewise.
4073 * target-dcache.c (stack_cache_enabled_1): Likewise.
4074 (code_cache_enabled_1): Likewise.
4075 * target.c (trust_readonly): Likewise.
4076 (may_write_registers): Likewise.
4077 (may_write_memory): Likewise.
4078 (may_insert_breakpoints): Likewise.
4079 (may_insert_tracepoints): Likewise.
4080 (may_insert_fast_tracepoints): Likewise.
4081 (may_stop): Likewise.
4082 (auto_connect_native_target): Likewise.
4083 (target_stop_and_wait): Update.
4084 (target_async_permitted): Change to bool.
4085 (target_async_permitted_1): Likewise.
4086 (may_write_registers_1): Likewise.
4087 (may_write_memory_1): Likewise.
4088 (may_insert_breakpoints_1): Likewise.
4089 (may_insert_tracepoints_1): Likewise.
4090 (may_insert_fast_tracepoints_1): Likewise.
4091 (may_stop_1): Likewise.
4092 * target.h (target_async_permitted): Likewise.
4093 (may_write_registers): Likewise.
4094 (may_write_memory): Likewise.
4095 (may_insert_breakpoints): Likewise.
4096 (may_insert_tracepoints): Likewise.
4097 (may_insert_fast_tracepoints): Likewise.
4098 (may_stop): Likewise.
4099 * thread.c (struct info_threads_opts) <show_global_ids>: Likewise.
4100 (make_thread_apply_all_options_def_group): Change argument from int*
4101 to bool*.
4102 (thread_apply_all_command): Update.
4103 (print_thread_events): Change to bool.
4104 * top.c (confirm): Likewise.
4105 (command_editing_p): Likewise.
4106 (history_expansion_p): Likewise.
4107 (write_history_p): Likewise.
4108 (info_verbose): Likewise.
4109 * top.h (confirm): Likewise.
4110 (history_expansion_p): Likewise.
4111 * tracepoint.c (disconnected_tracing): Likewise.
4112 (circular_trace_buffer): Likewise.
4113 * typeprint.c (print_methods): Likewise.
4114 (print_typedefs): Likewise.
4115 * utils.c (debug_timestamp): Likewise.
4116 (sevenbit_strings): Likewise.
4117 (pagination_enabled): Likewise.
4118 * utils.h (sevenbit_strings): Likewise.
4119 (pagination_enabled): Likewise.
4120 * valops.c (overload_resolution): Likewise.
4121 * valprint.h (struct value_print_options) <prettyformat_arrays,
4122 prettyformat_structs, vtblprint, unionprint, addressprint, objectprint,
4123 stop_print_at_null, print_array_indexes, deref_ref, static_field_print,
4124 pascal_static_field_print, raw, summary, symbol_print, finish_print>:
4125 Likewise.
4126 * windows-nat.c (new_console): Likewise.
4127 (cygwin_exceptions): Likewise.
4128 (new_group): Likewise.
4129 (debug_exec): Likewise.
4130 (debug_events): Likewise.
4131 (debug_memory): Likewise.
4132 (debug_exceptions): Likewise.
4133 (useshell): Likewise.
4134 * windows-tdep.c (maint_display_all_tib): Likewise.
4135 * xml-support.c (debug_xml): Likewise.
4136
4137 2019-09-17 Mike Gulick <mgulick@mathworks.com>
4138
4139 * source.c (prepare_path_for_appending): New function.
4140 (openp): Make use of new function.
4141 (find_and_open_source): Search for the compilation directory and
4142 source file as a relative path beneath the directory search path.
4143
4144 2019-09-17 Andrew Burgess <andrew.burgess@embecosm.com>
4145
4146 * source-cache.c (source_cache::get_line_charpos): Catch
4147 exceptions and return false, this matches the behaviour documented
4148 in the header file.
4149
4150 2019-09-17 Joel Brobecker <brobecker@adacore.com>
4151
4152 * ada-tasks.c (info_task): Remove quoting of the task's name.
4153
4154 2019-09-16 Christian Biesinger <cbiesinger@google.com>
4155
4156 * symfile.c (auto_solib_add): Replace comment with a reference
4157 to the header file.
4158
4159 2019-09-14 Christian Biesinger <cbiesinger@google.com>
4160
4161 * NEWS: Mention that gdb can now be compiled with Python 3
4162 on Windows.
4163
4164 2019-09-12 Andrew Burgess <andrew.burgess@embecosm.com>
4165
4166 * maint.c (maint_print_section_data::maint_print_section_data):
4167 Force use of 'float log10 (float)' by casting the argument to
4168 float.
4169
4170 2019-09-12 Andrew Burgess <andrew.burgess@embecosm.com>
4171
4172 * maint.c: Add 'cmath' include.
4173 (struct maint_print_section_data): New structure.
4174 (print_section_index): New function.
4175 (print_bfd_section_info): Add header comment, small whitespace
4176 cleanup, and update to call new print_section_index function.
4177 (print_objfile_section_info): Likewise.
4178 (maint_obj_section_from_bfd_section): New function.
4179 (print_bfd_section_info_maybe_relocated): New function.
4180 (maintenance_info_sections): Add header comment, always use
4181 bfd_map_over_sections instead of ALL_OBJFILE_OSECTIONS.
4182
4183 2019-09-12 Andrew Burgess <andrew.burgess@embecosm.com>
4184
4185 * psymtab.c (find_pc_sect_psymtab): Move baseaddr local into more
4186 inner scope, add check that the objfile has psymtabs before
4187 checking psymtabs_addrmap.
4188 * psymtab.h (psymtab_storage) <psymtabs_addrmap>: Extend comment.
4189
4190 2019-09-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
4191
4192 * NEWS: Announce that Ada task names are now shown at more places,
4193 and between quotes (except in info task output).
4194 * gdb/ada-tasks.c (task_to_str): New function.
4195 (display_current_task_id): Call task_to_str.
4196 (task_command_1): Likewise.
4197 (print_ada_task_info): In non-mi mode, Properly align headers and data
4198 when task-id length is > 9 (9 is the default for a 32 bits CORE_ADDR).
4199
4200 2019-09-12 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
4201
4202 * procfs.c (procfs_target::wait) <PR_FAULTED>: Get signal from
4203 prstatus.pr_lwp.pr_info instead of making it up.
4204
4205 2019-09-11 Christian Biesinger <cbiesinger@google.com>
4206
4207 * auto-load.c (auto_load_expand_dir_vars): Update.
4208 * defs.h (gdb_datadir): Change to std::string.
4209 (python_libdir): Likewise.
4210 (relocate_gdb_directory): Change return type to std::string.
4211 * guile/guile.c (gdbscm_data_directory): Update.
4212 (initialize_scheme_side): Update.
4213 * jit.c (jit_reader_dir): Change to std::string.
4214 (jit_reader_load_command): Update.
4215 * main.c (gdb_datadir): Change to std::string.
4216 (python_libdir): Likewise.
4217 (set_gdb_data_directory): Update.
4218 (relocate_path): Change to return std::string.
4219 (relocate_gdb_directory): Change to return std::string.
4220 (relocate_gdbinit_path_maybe_in_datadir): Update.
4221 (captured_main_1): Update.
4222 * python/python.c (do_start_initialization): Update.
4223 * top.c (show_gdb_datadir): Update.
4224 * xml-syscall.c (xml_init_syscalls_info): Update.
4225 (init_syscalls_info): Update.
4226
4227 2019-09-11 Christian Biesinger <cbiesinger@google.com>
4228
4229 * main.c (relocate_gdbinit_path_maybe_in_datadir): Factor this code
4230 out of get_init_files.
4231 (get_init_files): Update.
4232
4233 2019-09-11 Christian Biesinger <cbiesinger@google.com>
4234
4235 * main.c (get_init_files): Change to use std::string.
4236 (captured_main_1): Update.
4237 (print_gdb_help): Update.
4238
4239 2019-09-11 Ali Tamur <tamur@google.com>
4240
4241 *gdb/target-float.c (host_float_ops<T>::to_longest): Update
4242 implementation.
4243
4244 2019-09-11 Christian Biesinger <cbiesinger@google.com>
4245
4246 * dbxread.c (read_dbx_symtab): Update.
4247 * dwarf2read.c (load_partial_dies): Update.
4248 * mdebugread.c (parse_partial_symbols): Update.
4249 (handle_psymbol_enumerators): Update.
4250 * psympriv.h (add_psymbol_to_list): Change type of copy_names to bool.
4251 * psymtab.c (add_psymbol_to_bcache): Likewise.
4252 (add_psymbol_to_list): Likewise.
4253 * symtab.c (symbol_set_names): Likewise.
4254 * symtab.h (symbol_set_names): Likewise.
4255 * xcoffread.c (scan_xcoff_symtab): Update.
4256
4257 2019-09-11 Tom Tromey <tom@tromey.com>
4258
4259 * symfile-mem.c (symbol_file_add_from_memory): Use
4260 bfd_set_filename.
4261 * solib-darwin.c (darwin_bfd_open): Use bfd_set_filename.
4262 * solib-aix.c (solib_aix_bfd_open): Use bfd_set_filename.
4263
4264 2019-09-10 Tom Tromey <tromey@adacore.com>
4265
4266 * dwarf-index-write.c (write_psymbols): Extend error message.
4267 (debug_names::insert): Add Ada code.
4268 (debug_names::write_psymbols): Remove Ada check.
4269 (debug_names) <m_string_obstack>: New member.
4270 * dwarf2read.c (gdb_index_symbol_name_matcher): Remove.
4271 (gdb_index_symbol_name_matcher::matches): Remove.
4272 (mapped_index_base::find_name_components_bounds): Add "lang"
4273 parameter.
4274 (mapped_index_base::build_name_components): Also split names
4275 according to Ada syntax.
4276 (dw2_expand_symtabs_matching_symbol): Loop over languages. Change
4277 type of "match_callback".
4278 (check_match, check_find_bounds_finds)
4279 (dw2_expand_symtabs_matching): Update.
4280 (dw2_debug_names_iterator): Add new constructor.
4281 (dw2_debug_names_map_matching_symbols): New function.
4282 (dw2_debug_names_expand_symtabs_matching): Update.
4283 (dwarf2_debug_names_functions): Use
4284 dw2_debug_names_map_matching_symbols.
4285
4286 2019-09-10 Tom Tromey <tromey@adacore.com>
4287
4288 * dwarf2read.c (dw2_get_file_names_reader): Add the
4289 CU's file name to the results.
4290
4291 2019-09-10 Tom Tromey <tromey@adacore.com>
4292
4293 * ada-lang.c (add_nonlocal_symbols): Combine calls to
4294 map_matching_symbols. Update.
4295 * dwarf2read.c (dw2_map_matching_symbols): Update.
4296 * psymtab.c (match_partial_symbol): Change type; update.
4297 (psym_map_matching_symbols): Likewise.
4298 * symfile-debug.c (debug_qf_map_matching_symbols): Change
4299 type; update.
4300 * symfile.h (struct quick_symbol_functions)
4301 <map_matching_symbols>: Change "name" to be a lookup_name_info.
4302 Remove "match".
4303
4304 2019-09-10 Tom Tromey <tromey@adacore.com>
4305
4306 * psymtab.c (map_block): Remove.
4307 (psym_map_matching_symbols): Use iterate_over_symbols_terminated.
4308 * symtab.c (iterate_over_symbols_terminated): New function.
4309 * symtab.c (iterate_over_symbols_terminated): Declare.
4310
4311 2019-09-10 Tom Tromey <tromey@adacore.com>
4312
4313 * ada-lang.c (ada_iterate_over_symbols): Return bool.
4314 * language.h (struct language_defn) <la_iterate_over_symbols>:
4315 Return bool.
4316 * symtab.c (iterate_over_symbols): Return bool.
4317 * symtab.h (iterate_over_symbols): Return bool.
4318
4319 2019-09-10 Tom Tromey <tromey@adacore.com>
4320
4321 * ada-lang.c (aux_add_nonlocal_symbols): Change type.
4322 (add_nonlocal_symbols): Update.
4323 * dwarf2read.c (dw2_map_matching_symbols): Change type.
4324 * psymtab.c (map_block, psym_map_matching_symbols): Change type.
4325 * symfile-debug.c (debug_qf_map_matching_symbols): Change type.
4326 * symfile.h (struct quick_symbol_functions) <map_matching_symbols>:
4327 Change type of "callback". Remove "data".
4328
4329
4330 2019-09-09 Ali Tamur <tamur@google.com>
4331
4332 * dwarf2read.c (comp_unit_head): Update comment.
4333 (dwarf2_dwo_name): New function declaration.
4334 (dwarf_unit_type_name): New function declaration.
4335 (read_comp_unit_head): Add support for new compilation units,
4336 DW_UT_partial, DW_UT_skeleton, DW_UT_split_compile, DW_UT_split_type.
4337 Particularly, DW_UT_skeleton and DW_UT_split_compile have dwo_id
4338 (currently named as "signature") in their header. Also clarify error
4339 messages.
4340 (lookup_dwo_id): New function. Returns the dwo id of the given
4341 compile unit.
4342 (lookup_dwo_unit): Use the new lookup_dwo_id function.
4343 (init_cutu_and_read_dies): Use the new dwarf2_dwo_name and lookup_dwo_id
4344 functions.
4345 (create_dwo_cu_reader): Use the added lookup_dwo_id function.
4346 (dwarf2_dwo_name): Get the dwo name if present.
4347 (dwarf_unit_type_name): Convert DW_UT_* types to string for diagnostic
4348 purposes.
4349
4350 2019-09-09 Tom Tromey <tom@tromey.com>
4351
4352 * tui/tui-win.c (tui_all_windows_info): Use ui_out.
4353
4354 2019-09-09 Philippe Waroquiers <philippe.waroquiers@skynet.be>
4355
4356 * python/python.c (do_start_initialization): Make progname_copy static,
4357 to avoid a leak report.
4358
4359 2019-09-08 Tom Tromey <tom@tromey.com>
4360
4361 * tui/tui-wingeneral.c (box_win): Truncate long window titles.
4362
4363 2019-09-07 Simon Marchi <simon.marchi@efficios.com>
4364
4365 * dwarf2read.c (struct dw2_symtab_iterator) <block_index>:
4366 Change type to gdb::optional<block_enum>.
4367 (dw2_symtab_iter_init): Change block_index parameter type
4368 to gdb::optional<block_enum>.
4369 (dw2_lookup_symbol): Change block_index parameter
4370 type to block_enum.c
4371 (dw2_debug_names_lookup_symbol): Likewise.
4372 * psymtab.c (psym_lookup_symbol): Likewise.
4373 * symfile-debug.c (debug_qf_lookup_symbol): Likewise.
4374 * symfile.h (struct quick_symbol_functions) <lookup_symbol>:
4375 Likewise.
4376
4377 2019-09-06 Christian Biesinger <cbiesinger@google.com>
4378
4379 * defs.h (relocate_gdb_directory): Change int to bool in
4380 signature and rename flag to relocatable.
4381 * main.c (relocate_path): Likewise.
4382 (relocate_gdb_directory): Likewise.
4383
4384 2019-09-06 Alan Modra <amodra@gmail.com>
4385
4386 * coffread.c (coff_symfile_read): Constify filename variable.
4387 * dbxread.c (dbx_symfile_init, coffstab_build_psymtabs),
4388 (elfstab_build_psymtabs, stabsect_build_psymtabs): Likewise.
4389 * gdb_bfd.c (gdb_bfd_close_or_warn): Likewise.
4390 * solib.c (reload_shared_libraries_1): Likewise.
4391 * symfile.c (reread_symbols): Likewise.
4392 * solib-aix.c (solib_aix_bfd_open): Add cast for xfree of filename.
4393 * solib-darwin.c (darwin_bfd_open): Likewise.
4394 * symfile-mem.c (symbol_file_add_from_memory): Likewise.
4395
4396 2019-09-03 Andrew Burgess <andrew.burgess@embecosm.com>
4397
4398 * psymtab.c (print_partial_symbols): Handle missing domain_enum
4399 values MODULE_DOMAIN and COMMON_BLOCK_DOMAIN.
4400
4401 2019-09-03 Tom Tromey <tromey@adacore.com>
4402
4403 * ada-valprint.c (ada_val_print_num): Don't recurse for range
4404 types.
4405 (has_negatives): Unbias a range type bound.
4406 * dwarf2read.c (read_subrange_type): Handle DW_AT_GNU_bias.
4407 * gdbtypes.c (operator==): Handle new field.
4408 (create_range_type): Add "bias" parameter.
4409 (create_static_range_type, resolve_dynamic_range): Update.
4410 * gdbtypes.h (struct range_bounds) <bias>: New member.
4411 (create_range_type): Add bias parameter.
4412 * printcmd.c (print_scalar_formatted): Unbias range types.
4413 * value.c (unpack_long): Unbias range types.
4414 (pack_long): Bias range types.
4415
4416 2019-09-02 Alan Hayward <alan.hayward@arm.com>
4417
4418 * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Check all
4419 probe arguments.
4420
4421 2019-09-02 Alan Hayward <alan.hayward@arm.com>
4422
4423 * break-catch-throw.c (fetch_probe_arguments): Use gdbarch.
4424 * dtrace-probe.c (dtrace_probe::get_argument_count): Likewise.
4425 * probe.c (probe_safe_evaluate_at_pc) (compute_probe_arg)
4426 (compile_probe_arg): Likewise.
4427 * probe.h (get_argument_count): Likewise.
4428 * solib-svr4.c (solib_event_probe_action): Likewise.
4429 * stap-probe.c (stap_probe::get_argument_count): Likewise.
4430
4431 2019-09-02 Alan Hayward <alan.hayward@arm.com>
4432
4433 * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Move
4434 code to here...
4435 (svr4_create_solib_event_breakpoints): ...from here.
4436
4437 2019-08-30 Sergio Durigan Junior <sergiodj@redhat.com>
4438
4439 * nat/fork-inferior.c (trace_start_error): Remove "\nError: "
4440 suffix from warning message.
4441
4442 2019-08-30 Tom Tromey <tom@tromey.com>
4443
4444 * tui/tui-winsource.h (struct tui_source_window_base)
4445 <refresh_all>: Don't declare.
4446 * tui/tui-winsource.c (tui_source_window_base::refresh_all):
4447 Remove.
4448 * tui/tui-win.c (tui_refresh_all_win): Don't call refresh_all or
4449 tui_show_locator_content.
4450 * tui/tui-regs.h (struct tui_data_window) <refresh_all>: Don't
4451 declare.
4452 * tui/tui-regs.c (tui_data_window::refresh_all): Remove.
4453 * tui/tui-data.h (struct tui_win_info) <refresh_all>: Don't
4454 declare.
4455
4456 2019-08-30 Tom Tromey <tom@tromey.com>
4457
4458 * tui/tui-io.c (tui_cont_sig): Don't call wrefresh.
4459
4460 2019-08-30 Tom Tromey <tom@tromey.com>
4461
4462 * tui/tui-stack.c (_initialize_tui_stack): Move later.
4463 Remove unnecessary forward declarations.
4464
4465 2019-08-30 Tom Tromey <tom@tromey.com>
4466
4467 * tui/tui-stack.c (tui_locator_window::set_locator_fullname): Call
4468 rerender.
4469 (tui_update_locator_fullname, tui_show_frame_info): Don't call
4470 tui_show_locator_content.
4471
4472 2019-08-30 Tom Tromey <tom@tromey.com>
4473
4474 * tui/tui-stack.c (tui_show_locator_content): Move lower. Rewrite.
4475 (tui_locator_window::rerender): Rewrite using body of previous
4476 tui_show_locator_content.
4477
4478 2019-08-30 Tom Tromey <tom@tromey.com>
4479
4480 * tui/tui-stack.h (struct tui_locator_window) <set_locator_info,
4481 set_locator_fullname>: New methods.
4482 * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
4483 Rename from tui_set_locator_fullname.
4484 (tui_locator_window::set_locator_info): Rename from
4485 tui_set_locator_info. Return bool.
4486 (tui_update_locator_fullname, tui_show_frame_info): Update.
4487
4488 2019-08-30 Tom Tromey <tom@tromey.com>
4489
4490 * tui/tui-layout.c (show_layout): Don't call tui_refresh_all.
4491
4492 2019-08-30 Tom Tromey <tom@tromey.com>
4493
4494 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Don't
4495 call touchwin.
4496
4497 2019-08-30 Tom Tromey <tom@tromey.com>
4498
4499 * tui/tui-wingeneral.c (box_win): Assume win_info and
4500 win_info->handle cannot be NULL.
4501
4502 2019-08-30 Tom Tromey <tom@tromey.com>
4503
4504 * tui/tui-regs.h (struct tui_data_item_window) <rerender,
4505 refresh_window>: Declare.
4506 * tui/tui-regs.c (tui_data_window::display_registers_from): Call
4507 resize.
4508 (tui_data_item_window::rerender): Rename from
4509 tui_display_register.
4510 (tui_data_item_window::refresh_window): New method.
4511 * tui/tui-layout.c (tui_gen_win_info::resize): Do nothing on
4512 no-op.
4513
4514 2019-08-30 Tom Tromey <tom@tromey.com>
4515
4516 * tui/tui-regs.h (struct tui_data_window) <regs_content,
4517 regs_column_count, current_group>: Move later. Now private.
4518 <get_current_group>: New method.
4519 * tui/tui-regs.c (tui_reg_command): Update.
4520 * tui/tui-layout.c (tui_set_layout): Update.
4521
4522 2019-08-30 Tom Tromey <tom@tromey.com>
4523
4524 * tui/tui-regs.c (tui_data_window::display_registers_from_line)
4525 (tui_data_window::rerender): Don't call
4526 check_and_display_highlight_if_needed.
4527 (tui_data_window::refresh_all): Remove call to
4528 erase_data_content.
4529
4530 2019-08-30 Tom Tromey <tom@tromey.com>
4531
4532 * tui/tui-regs.c (tui_data_window::last_regs_line_no)
4533 (tui_data_window::display_registers_from)
4534 (tui_data_window::display_reg_element_at_line)
4535 (tui_data_window::display_registers_from_line): Remove checks of
4536 "empty".
4537
4538 2019-08-30 Tom Tromey <tom@tromey.com>
4539
4540 * tui/tui-regs.h (struct tui_data_window) <display_all_data>:
4541 Don't declare.
4542 * tui/tui-regs.c (tui_data_window::show_registers): Call
4543 rerender.
4544 (tui_data_window::rerender): Rename from display_all_data.
4545 (tui_data_window::rerender): Remove old implementation.
4546
4547 2019-08-30 Tom Tromey <tom@tromey.com>
4548
4549 * tui/tui-regs.c (tui_data_window::display_all_data): Change
4550 text.
4551 * tui/tui-data.h (NO_DATA_STRING): Remove define.
4552
4553 2019-08-29 Bernhard Wodok <barto@gmx.net>
4554 Sergio Durigan Junior <sergiodj@redhat.com>
4555
4556 PR win32/24284
4557 * mingw-hdep.c (gdb_select): Handle case when 'n' is zero.
4558
4559 2019-08-28 Andrew Burgess <andrew.burgess@embecosm.com>
4560
4561 * symtab.c (search_symbols): Don't include MODULE_DOMAIN symbols
4562 when searching for types.
4563
4564 2019-08-28 Andrew Burgess <andrew.burgess@embecosm.com>
4565
4566 * f-lang.c (f_language_defn): Use f_print_typedef.
4567 * f-lang.h (f_print_typedef): Declare.
4568 * f-typeprint.c (f_print_typedef): Define.
4569
4570 2019-08-27 Christian Biesinger <cbiesinger@google.com>
4571
4572 * nat/linux-namespaces.c (mnsh_main): Initialize fd (to -1).
4573
4574 2019-08-27 Andrew Burgess <andrew.burgess@embecosm.com>
4575
4576 * cli/cli-utils.c (info_print_options_defs): Delete.
4577 (make_info_print_options_def_group): Delete.
4578 (extract_info_print_options): Delete.
4579 (info_print_command_completer): Delete.
4580 (info_print_args_help): Add extra parameter, and optionally
4581 include text about -n flag.
4582 * cli/cli-utils.h (struct info_print_options): Delete.
4583 (extract_info_print_options): Delete declaration.
4584 (info_print_command_completer): Delete declaration.
4585 (info_print_args_help): Add extra parameter, extend header
4586 comment.
4587 * python/python.c (gdbpy_rbreak): Pass additional parameter to
4588 search_symbols.
4589 * stack.c (struct info_print_options): New type.
4590 (info_print_options_defs): New file scoped variable.
4591 (make_info_print_options_def_group): New static function.
4592 (info_print_command_completer): New static function.
4593 (info_locals_command): Update to use new local functions.
4594 (info_args_command): Likewise.
4595 (_initialize_stack): Add extra parameter to calls to
4596 info_print_args_help.
4597 * symtab.c (search_symbols): Add extra parameter, use this to
4598 possibly excluse non-debug symbols.
4599 (symtab_symbol_info): Add extra parameter, which is passed on to
4600 search_symbols.
4601 (struct info_print_options): New type.
4602 (info_print_options_defs): New file scoped variable.
4603 (make_info_print_options_def_group): New static function.
4604 (info_print_command_completer): New static function.
4605 (info_variables_command): Update to use local functions, and pass
4606 extra parameter through to symtab_symbol_info.
4607 (info_functions_command): Likewise.
4608 (info_types_command): Pass additional argument through to
4609 symtab_symbol_info.
4610 (rbreak_command): Pass extra argument to search_symbols.
4611 (_initialize_symtab): Add extra arguments for calls to
4612 info_print_args_help, and update help text for 'info variables',
4613 'whereis', and 'info functions' commands.
4614 * symtab.h (search_symbols): Add extra argument to declaration.
4615 * NEWS: Mention new flags.
4616
4617 2019-08-26 Christian Biesinger <cbiesinger@google.com>
4618
4619 * symtab.c (lookup_static_symbol): Call the new function (and move
4620 it down to be next to lookup_global_symbol).
4621 (struct global_sym_lookup_data): Add block_enum member and rename to...
4622 (struct global_or_static_sym_lookup_data): ...this.
4623 (lookup_symbol_global_iterator_cb): Pass block_index instead of
4624 GLOBAL_BLOCK to lookup_symbol_in_objfile and rename to...
4625 (lookup_symbol_global_or_static_iterator_cb): ...this.
4626 (lookup_global_or_static_symbol): New function.
4627 (lookup_global_symbol): Call new function.
4628
4629 2019-08-26 Tom de Vries <tdevries@suse.de>
4630
4631 PR c++/24852
4632 * break-catch-throw.c (fetch_probe_arguments): Improve error mesage
4633 when pc_probe.prob == NULL.
4634
4635 2019-08-25 Simon Marchi <simon.marchi@efficios.com>
4636
4637 * dwarf2read.c (dw2_debug_names_iterator::next): Rename local
4638 variable symbol_linkage to symbol_linkage_.
4639
4640 2019-08-25 Simon Marchi <simon.marchi@efficios.com>
4641
4642 * dwarf2read.c (dw2_debug_names_iterator::next): Use enum to
4643 represent whether the symbol is static, dynamic, or we don't
4644 know.
4645
4646 2019-08-25 Yoshinori Sato <ysato@users.sourceforge.jp>
4647
4648 * gdb/rx-tdep.c (rx_register_names): New.
4649 (rx_register_name): Delete.
4650 (rx_psw_type): Delete.
4651 (rx_fpsw_type): Delete.
4652 (rx_register_type): Delete.
4653 (rx_gdbarch_init): Convert target-descriptions.
4654 (_initialize_rx_tdep): Add initialize_tdesc_rx.
4655 * gdb/features/Makefile: Add rx.xml.
4656 * gdb/features/rx.xml: New.
4657 * gdb/features/rx.c: Generated.
4658 * gdb/NEWS: Mention target description support.
4659
4660 2019-08-22 Christian Biesinger <cbiesinger@google.com>
4661
4662 * symtab.c (symbol_cache_lookup): Always initialize *bsc_ptr and
4663 *slot_ptr.
4664
4665 2019-08-23 Sergio Durigan Junior <sergiodj@redhat.com>
4666
4667 * configure.ac: Don't check for 'dlfcn.h' (moved to
4668 gdbsupport/common.m4).
4669 * Makefile.in (COMMON_SFILES): Move 'gdb-dlfcn.c' to
4670 'gdbsupport/'.
4671 (HFILES_NO_SRCDIR): Likewise, for 'gdb-dlfcn.h'.
4672 * compile/compile-c-support.c: Include
4673 'gdbsupport/gdb-dlfcn.h'.
4674 * gdbsupport/common.m4: Check for 'dlfcn.h'.
4675 * gdb-dlfcn.c: Move to...
4676 * gdbsupport/gdb-dlfcn.c: ... here.
4677 * gdb-dlfcn.h: Move to...
4678 * gdbsupport/gdb-dlfcn.h: ... here.
4679
4680 2019-08-23 Sandra Loosemore <sandra@codesourcery.com>
4681
4682 * nios2-tdep.c (struct reg_value): Improve comments. Make
4683 the offset field signed.
4684
4685 2019-08-22 Christian Biesinger <cbiesinger@google.com>
4686
4687 * python/lib/gdb/__init__.py (_execute_file): New function.
4688 * python/python.c (python_run_simple_file): Call gdb._execute_file
4689 on Windows.
4690
4691 2019-08-22 Andrew Burgess <andrew.burgess@embecosm.com>
4692
4693 * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
4694 all uses as this was never set to anything but a zero value.
4695
4696 2019-08-21 Bogdan Harjoc <harjoc@gmail.com>
4697
4698 * cli/cli-cmds.c (with_command_1): Error out if no arguments.
4699
4700 2019-08-21 Christian Biesinger <cbiesinger@google.com>
4701
4702 * tui/tui-data.h (tui_gen_win_info): Add an =default
4703 move constructor, required by some GCC versions.
4704
4705 2019-08-21 Jinke Fan <fanjinke51@yeah.net>
4706
4707 * go32-nat.c (go32_sysinfo): Add hygon_p.
4708
4709 2019-08-20 Tom Tromey <tom@tromey.com>
4710
4711 * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
4712 line_from_reg_element_no, first_reg_element_no_inline,
4713 display_all_data, delete_data_content_windows,
4714 erase_data_content>: Now private.
4715
4716 2019-08-20 Tom Tromey <tom@tromey.com>
4717
4718 * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
4719 (tui_unhighlight_win, tui_highlight_win)
4720 (tui_win_info::make_window): Update.
4721 * tui/tui-data.h (HILITE, NO_HILITE): Remove.
4722
4723 2019-08-20 Tom Tromey <tom@tromey.com>
4724
4725 * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
4726 (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
4727 (MAX_PID_WIDTH): Move to tui-stack.c.
4728 * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
4729 (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
4730 (MAX_PID_WIDTH): Move from tui-data.h.
4731
4732 2019-08-20 Tom Tromey <tom@tromey.com>
4733
4734 * tui/tui-wingeneral.h (tui_make_window): Don't declare.
4735 * tui/tui-wingeneral.c (box_win): Change type of win_info.
4736 (box_win): Update.
4737 (tui_gen_win_info::make_window): Rename from tui_make_window.
4738 (tui_win_info::make_window): New method.
4739 (tui_gen_win_info::make_visible): Update.
4740 * tui/tui-source.c (tui_source_window::set_contents): Update.
4741 * tui/tui-regs.c (tui_data_window::show_register_group): Update.
4742 (tui_data_window::display_registers_from): Update.
4743 * tui/tui-layout.c (tui_gen_win_info::resize): Update.
4744 * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
4745 Declare.
4746 <can_box>: Remove.
4747 <title>: Remove.
4748 (struct tui_win_info) <make_window>: Declare.
4749 <can_box>: Now virtual.
4750 <title>: New member.
4751 * tui/tui-data.c (~tui_gen_win_info): Don't free title.
4752 * tui/tui-command.c (tui_cmd_window::resize): Update.
4753
4754 2019-08-20 Tom Tromey <tom@tromey.com>
4755
4756 * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
4757 * tui/tui-regs.c (tui_data_window::show_registers): Update.
4758 (tui_data_window::check_register_values): Update.
4759
4760 2019-08-20 Tom Tromey <tom@tromey.com>
4761
4762 * tui/tui-regs.h (struct tui_data_window): Use
4763 DISABLE_COPY_AND_ASSIGN.
4764 <regs_content>: Change type, removing unique_ptr.
4765 <tui_data_window>: Add move constructor.
4766 * tui/tui-regs.c (tui_data_window::show_registers)
4767 (tui_data_window::show_register_group)
4768 (tui_data_window::display_registers_from)
4769 (tui_data_window::display_registers_from)
4770 (tui_data_window::first_data_item_displayed)
4771 (tui_data_window::delete_data_content_windows)
4772 (tui_data_window::rerender, tui_data_window::refresh_window)
4773 (tui_data_window::check_register_values): Update.
4774
4775 2019-08-20 Tom Tromey <tom@tromey.com>
4776
4777 * tui/tui-regs.h (struct tui_data_window) <show_registers,
4778 show_register_group>: Declare.
4779 (tui_show_register_group): Don't declare.
4780 * tui/tui-regs.c (tui_data_window::show_registers): Rename from
4781 tui_show_registers.
4782 (tui_data_window::show_register_group): Rename from
4783 tui_show_register_group.
4784 (tui_data_window::check_register_values, tui_reg_command):
4785 Update.
4786 * tui/tui-layout.c (tui_set_layout): Update.
4787
4788 2019-08-20 Tom Tromey <tom@tromey.com>
4789
4790 * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
4791 Declare.
4792 (tui_check_register_values): Don't declare.
4793 * tui/tui-regs.c (tui_data_window::check_register_values): Rename
4794 from tui_check_register_values.
4795 * tui/tui-hooks.c (tui_register_changed): Update.
4796
4797 2019-08-20 Tom Tromey <tom@tromey.com>
4798
4799 * tui/tui-regs.c (tui_reg_layout): Move later.
4800 (tui_show_registers): Don't enable TUI mode or change layout.
4801
4802 2019-08-20 Tom Tromey <tom@tromey.com>
4803
4804 * tui/tui-regs.h (struct tui_data_item_window)
4805 <~tui_data_item_window>: Remove.
4806 <content>: Now a unique_xmalloc_ptr.
4807 * tui/tui-regs.c (tui_register_format): Return a
4808 unique_xmalloc_ptr.
4809 (tui_get_register): Update.
4810 (~tui_data_item_window): Remove.
4811 (tui_data_window::display_registers_from, tui_display_register):
4812 Update.
4813 * tui/tui-io.h (tui_expand_tabs): Update.
4814 * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
4815 Remove "col" parameter.
4816
4817 2019-08-20 Tom Tromey <tom@tromey.com>
4818
4819 * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
4820 field.
4821 * tui/tui-regs.c (~tui_data_item_window): Update.
4822
4823 2019-08-20 Tom Tromey <tom@tromey.com>
4824
4825 * tui/tui-regs.c (tui_register_format, tui_get_register): Move
4826 earlier.
4827
4828 2019-08-20 Tom Tromey <tom@tromey.com>
4829
4830 * tui/tui-regs.c (tui_reg_command): Remove NULL check.
4831
4832 2019-08-20 Tom Tromey <tom@tromey.com>
4833
4834 * tui/tui-source.h (struct tui_source_window): Update.
4835 * tui/tui-regs.c (tui_show_registers): Update.
4836 * tui/tui-disasm.h (struct tui_disasm_window): Update.
4837 * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
4838 (NO_REGS_STRING): Remove defines.
4839
4840 2019-08-20 Conrad Meyer <cem@FreeBSD.org>
4841
4842 * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
4843 unnecessary thread walk if remote doesn't support the packet.
4844
4845 2019-08-19 Tom Tromey <tromey@adacore.com>
4846
4847 * python/py-value.c (value_has_field): Fix indentation.
4848
4849 2019-08-19 Tom Tromey <tromey@adacore.com>
4850
4851 * printcmd.c (do_one_display, info_display_command): Update.
4852 * block.h (contained_in): Return bool. Add allow_nested
4853 parameter.
4854 * block.c (contained_in): Return bool. Add allow_nested
4855 parameter.
4856
4857 2019-08-19 Tom Tromey <tom@tromey.com>
4858
4859 * configure: Rebuild.
4860 * configure.ac: Disallow the combination of -static-libstdc++ and
4861 source highlight.
4862 * source-cache.c (get_language_name): Handle rust.
4863 (source_cache::get_source_lines): Ignore highlighting exceptions.
4864
4865 2019-08-16 Tom Tromey <tom@tromey.com>
4866
4867 * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
4868 * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
4869 (struct tui_source_window_base) <make_visible, refresh_window,
4870 resize>: Remove methods.
4871 <execution_info>: Remove field.
4872 * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
4873 (tui_show_source_line, tui_source_window_base)
4874 (~tui_source_window_base): Update.
4875 (tui_source_window_base::resize)
4876 (tui_source_window_base::make_visible)
4877 (tui_source_window_base::refresh_window): Remove.
4878 (tui_source_window_base::update_exec_info): Update.
4879 * tui/tui-source.c (tui_source_window::set_contents): Update.
4880 * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
4881
4882 2019-08-16 Tom Tromey <tom@tromey.com>
4883
4884 * tui/tui-hooks.c (tui_remove_hooks): Don't set
4885 deprecated_query_hook.
4886
4887 2019-08-16 Tom Tromey <tom@tromey.com>
4888
4889 * tui/tui-winsource.c (tui_update_source_windows_with_addr)
4890 (tui_update_source_windows_with_line): Update.
4891 * tui/tui-source.h (struct tui_source_window)
4892 <show_symtab_source>: Declare.
4893 (tui_show_symtab_source): Don't declare.
4894 * tui/tui-source.c (tui_show_symtab_source): Rename from
4895 tui_show_symtab_source.
4896
4897 2019-08-16 Tom Tromey <tom@tromey.com>
4898
4899 * tui/tui-winsource.h (struct tui_source_window_base)
4900 <set_contents>: Declare.
4901 * tui/tui-winsource.c
4902 (tui_source_window_base::update_source_window_as_is): Update.
4903 * tui/tui-source.h (struct tui_source_window) <set_contents>:
4904 Declare.
4905 (tui_set_source_content): Don't declare.
4906 * tui/tui-source.c (tui_source_window::set_contents): Rename from
4907 tui_set_source_content.
4908 * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
4909 Declare.
4910 (tui_set_disassem_content): Don't declare.
4911 * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
4912 tui_set_disassem_content.
4913
4914 2019-08-16 Tom Tromey <tom@tromey.com>
4915
4916 * tui/tui-winsource.h (struct tui_source_window_base)
4917 <update_breakpoint_info>: Declare.
4918 (tui_update_breakpoint_info): Don't declare.
4919 * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
4920 (tui_update_all_breakpoint_info): Update.
4921 (tui_source_window_base::update_breakpoint_info): Rename from
4922 tui_update_breakpoint_info.
4923 (tui_source_window_base::update_exec_info): Update.
4924
4925 2019-08-16 Tom Tromey <tom@tromey.com>
4926
4927 * tui/tui-winsource.h (struct tui_source_window_base)
4928 <update_source_window>: Declare.
4929 (tui_update_source_window): Don't declare.
4930 * tui/tui-winsource.c
4931 (tui_source_window_base::update_source_window): Rename from
4932 tui_update_source_window.
4933 (tui_source_window_base::rerender): Update.
4934 * tui/tui-source.c (tui_source_window::maybe_update): Update.
4935 * tui/tui-disasm.c (tui_show_disassem)
4936 (tui_show_disassem_and_update_source)
4937 (tui_disasm_window::maybe_update): Update.
4938
4939 2019-08-16 Tom Tromey <tom@tromey.com>
4940
4941 * tui/tui-winsource.h (struct tui_source_window_base)
4942 <update_source_window_as_is>: Declare.
4943 (tui_update_source_window_as_is): Don't declare.
4944 * tui/tui-winsource.c (tui_update_source_window): Update
4945 (tui_source_window_base::update_source_window_as_is): Rename from
4946 tui_update_source_window_as_is.
4947 (tui_source_window_base::refill): Update.
4948 * tui/tui-source.c (tui_show_symtab_source): Update.
4949 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
4950 Update.
4951
4952 2019-08-16 Tom Tromey <tom@tromey.com>
4953
4954 * tui/tui-winsource.h (tui_update_source_window)
4955 (tui_update_source_window_as_is): Remove "noerror" parameter.
4956 * tui/tui-winsource.c (tui_update_source_window)
4957 (tui_update_source_window_as_is): Remove "noerror" parameter.
4958 (tui_update_source_windows_with_addr)
4959 (tui_update_source_windows_with_line)
4960 (tui_source_window_base::rerender)
4961 (tui_source_window_base::refill): Update.
4962 * tui/tui-source.h (tui_set_source_content)
4963 (tui_show_symtab_source): Remove "noerror" parameter.
4964 * tui/tui-source.c (tui_set_source_content): Remove "noerror"
4965 parameter.
4966 (tui_show_symtab_source): Likewise.
4967 (tui_source_window::maybe_update): Update.
4968 * tui/tui-disasm.c (tui_show_disassem)
4969 (tui_show_disassem_and_update_source)
4970 (tui_disasm_window::do_scroll_vertical)
4971 (tui_disasm_window::maybe_update): Update.
4972
4973 2019-08-16 Tom Tromey <tom@tromey.com>
4974
4975 * tui/tui.c (tui_is_window_visible): Update.
4976 * tui/tui-wingeneral.c (tui_make_window)
4977 (tui_gen_win_info::make_visible, tui_refresh_all): Update.
4978 * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
4979 (tui_set_focus_command, tui_all_windows_info, update_tab_width)
4980 (tui_set_win_height_command, parse_scrolling_args): Update.
4981 * tui/tui-source.c (tui_source_window::style_changed): Update.
4982 * tui/tui-regs.c (tui_show_registers)
4983 (tui_data_window::first_data_item_displayed)
4984 (tui_data_window::delete_data_content_windows)
4985 (tui_check_register_values, tui_reg_command): Update.
4986 * tui/tui-disasm.c (tui_show_disassem): Update.
4987 * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
4988 method.
4989 <is_visible>: Remove field.
4990 * tui/tui-data.c (tui_next_win, tui_prev_win)
4991 (tui_delete_invisible_windows): Update.
4992
4993 2019-08-16 Tom Tromey <tom@tromey.com>
4994
4995 * tui/tui-winsource.h (struct tui_source_window_base)
4996 <m_has_locator>: Remove.
4997 * tui/tui-layout.c (show_source_disasm_command, show_data)
4998 (show_source_or_disasm_and_command): Update.
4999
5000 2019-08-16 Alan Hayward <alan.hayward@arm.com>
5001
5002 * NEWS (Other MI changes): New subsection.
5003 * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
5004 (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
5005 * arch-utils.c (default_get_pc_address_flags): New function.
5006 * arch-utils.h (default_get_pc_address_flags): New declaration.
5007 * gdbarch.sh: Add get_pc_address_flags.
5008 * gdbarch.c: Regenerate.
5009 * gdbarch.h: Likewise.
5010 * stack.c (print_pc): New function.
5011 (print_frame_info) (print_frame): Call print_pc.
5012
5013 2019-08-16 Tom de Vries <tdevries@suse.de>
5014
5015 * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
5016 print_objfile_section_info.
5017
5018 2019-08-15 Tom Tromey <tom@tromey.com>
5019
5020 * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
5021 calling update_cmdwin_start_line.
5022 * tui/tui-winsource.h (struct tui_source_window_base)
5023 <do_make_visible_with_new_height, set_new_height>: Don't declare.
5024 <rerender>: Declare.
5025 * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
5026 Call rerender.
5027 (tui_source_window_base::set_new_height): Remove.
5028 (tui_source_window_base::rerender): Rename from
5029 do_make_visible_with_new_height.
5030 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
5031 resize method.
5032 (tui_win_info::make_invisible_and_set_new_height)
5033 (tui_win_info::make_visible_with_new_height): Remove.
5034 * tui/tui-stack.h (struct tui_locator_window) <rerender>:
5035 Declare.
5036 * tui/tui-stack.c (tui_locator_window::rerender): New method.
5037 * tui/tui-regs.h (struct tui_data_window) <set_new_height,
5038 do_make_visible_with_new_height>: Don't declare.
5039 <rerender>: Declare.
5040 * tui/tui-regs.c (tui_data_window::rerender): Rename from
5041 set_new_height.
5042 (tui_data_window::do_make_visible_with_new_height): Remove.
5043 * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
5044 call tui_show_locator_content.
5045 (tui_gen_win_info::resize): Call rerender.
5046 (show_source_or_disasm_and_command): Don't call
5047 tui_show_locator_content.
5048 * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
5049 method.
5050 (struct tui_win_info) <rerender>: Declare.
5051 <set_new_height, make_invisible_and_set_new_height,
5052 make_visible_with_new_height>: Don't declare.
5053 * tui/tui-data.c (tui_win_list::rerender): New method.
5054 * tui/tui-command.h (struct tui_cmd_window)
5055 <do_make_visible_with_new_height>: Don't declare.
5056 * tui/tui-command.c
5057 (tui_cmd_window::do_make_visible_with_new_height): Remove.
5058
5059 2019-08-15 Tom Tromey <tromey@adacore.com>
5060
5061 * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
5062 * ada-lang.c (ada_enum_name): Likewise.
5063
5064 2019-08-15 Christian Biesinger <cbiesinger@google.com>
5065
5066 * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
5067 leading underscore.
5068 (GdbOutputErrorFile): Likewise.
5069 (global scope): Adjust constructor calls to GdbOutput{,Error}File
5070 accordingly.
5071 (execute_unwinders): Rename to have a leading underscore.
5072 (auto_load_packages): Likewise.
5073 (global scope): Adjust call to auto_load_packages accordingly.
5074 (GdbSetPythonDirectory): Likewise.
5075 * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
5076 instead of execute_unwinders.
5077
5078 2019-08-15 Tom Tromey <tom@tromey.com>
5079
5080 * tui/tui-layout.c (show_layout, show_source_disasm_command)
5081 (show_data): Don't change window visibility.
5082 (tui_gen_win_info::resize): Remove special case for command
5083 window. Use wresize, when available.
5084 (show_source_or_disasm_and_command): Don't change window
5085 visibility.
5086 * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
5087 <make_visible>: New method.
5088 * tui/tui-command.c (tui_cmd_window::resize): New method.
5089
5090 2019-08-15 Tom Tromey <tom@tromey.com>
5091
5092 * tui/tui-winsource.h (struct tui_source_window_iterator): New.
5093 (struct tui_source_windows): New.
5094 * tui/tui-winsource.c (tui_display_main): Update.
5095 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
5096 (new_height_ok, parse_scrolling_args): Update.
5097 * tui/tui-layout.c (show_layout, show_data): Update.
5098 * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
5099 (tui_add_to_source_windows): Don't declare.
5100 * tui/tui-data.c (source_windows, tui_source_windows)
5101 (tui_clear_source_windows, tui_add_to_source_windows): Remove.
5102
5103 2019-08-15 Tom Tromey <tom@tromey.com>
5104
5105 * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
5106 Rename from reset.
5107 * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
5108 * tui/tui-layout.c (show_source_disasm_command, show_data):
5109 Update.
5110 (tui_gen_win_info::resize): Rename.
5111 (show_source_or_disasm_and_command): Update.
5112 * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
5113 reset.
5114
5115 2019-08-15 Tom Tromey <tom@tromey.com>
5116
5117 * tui/tui-stack.c (tui_initialize_static_data): Remove.
5118 * tui/tui-interp.c (tui_interp::init): Don't call
5119 tui_initialize_static_data.
5120 * tui/tui-data.h (tui_initialize_static_data): Don't declare.
5121
5122 2019-08-15 Tom Tromey <tom@tromey.com>
5123
5124 * tui/tui-layout.c (tui_default_win_viewport_height): Don't
5125 examine tui_win_list.
5126
5127 2019-08-15 Tom Tromey <tom@tromey.com>
5128
5129 * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
5130 * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
5131 tui_clear_source_content.
5132 (tui_clear_source_content): Remove.
5133 (tui_source_window_base::do_erase_source_content): Hoist call to
5134 content.clear().
5135 * tui/tui-stack.c (tui_show_frame_info): Don't call
5136 tui_clear_source_content.
5137
5138 2019-08-15 Tom Tromey <tom@tromey.com>
5139
5140 * tui/tui-winsource.h (struct tui_source_window_base)
5141 <do_erase_source_content>: New method.
5142 <erase_source_content>: New method.
5143 (tui_erase_source_content): Don't declare.
5144 * tui/tui-winsource.c (tui_clear_source_content): Update.
5145 (tui_source_window_base::do_erase_source_content): Rename from
5146 tui_erase_source_content.
5147 (tui_source_window_base::show_source_content): Update.
5148 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
5149 * tui/tui-source.h (struct tui_source_window)
5150 <erase_source_content>: New method.
5151 * tui/tui-disasm.h (struct tui_disasm_window)
5152 <erase_source_content>: New method.
5153
5154 2019-08-15 Tom Tromey <tom@tromey.com>
5155
5156 * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
5157 (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
5158 constructor.
5159 * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
5160 * tui/tui-source.c (tui_set_source_content): Update.
5161 * tui/tui-disasm.c (tui_set_disassem_content): Update.
5162
5163 2019-08-15 Tom Tromey <tom@tromey.com>
5164
5165 * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
5166 * tui/tui-winsource.c (tui_line_is_displayed): Move to
5167 tui-source.c.
5168 * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
5169 Declare.
5170 * tui/tui-source.c (tui_source_window::line_is_displayed): New
5171 method.
5172 (tui_source_window::maybe_update): Update.
5173
5174 2019-08-15 Tom Tromey <tom@tromey.com>
5175
5176 * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
5177 * tui/tui-winsource.c (tui_addr_is_displayed): Move to
5178 tui-disasm.c.
5179 * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
5180 Declare.
5181 * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
5182 method.
5183 (tui_disasm_window::maybe_update): Update.
5184
5185 2019-08-15 Tom Tromey <tom@tromey.com>
5186
5187 * tui/tui-winsource.h (struct tui_source_window_base)
5188 <maybe_update>: Declare.
5189 * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
5190 method.
5191 * tui/tui-source.h (struct tui_source_window) <maybe_update>:
5192 Declare.
5193 * tui/tui-source.c (tui_source_window::maybe_update): New method.
5194 * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
5195 Declare.
5196 * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
5197
5198 2019-08-15 Tom Tromey <tom@tromey.com>
5199
5200 * tui/tui-stack.c (tui_make_status_line): Use string constructor.
5201
5202 2019-08-15 Tom Tromey <tom@tromey.com>
5203
5204 * tui/tui-wingeneral.c: Include tui-stack.h.
5205 * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
5206 (struct tui_locator_window): Move from tui-data.h.
5207 * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
5208 (tui_initialize_static_data): Move from tui-data.c.
5209 * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
5210 (struct tui_locator_window): Move to tui-stack.c.
5211 * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
5212 (tui_initialize_static_data): Move to tui-stack.c.
5213
5214 2019-08-15 Tom Tromey <tom@tromey.com>
5215
5216 * tui/tui-layout.c (show_source_disasm_command)
5217 (show_source_or_disasm_and_command): Use make_visible method, not
5218 tui_make_window.
5219 * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
5220 Remove.
5221
5222 2019-08-15 Tom Tromey <tom@tromey.com>
5223
5224 * tui/tui-wingeneral.h (tui_make_window): Update.
5225 * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
5226 parameter.
5227 (tui_gen_win_info::make_visible): Update.
5228 * tui/tui-regs.c (tui_data_window::display_registers_from):
5229 Update.
5230 * tui/tui-layout.c (show_source_disasm_command)
5231 (show_source_or_disasm_and_command): Update.
5232 * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
5233 (enum tui_box): Remove.
5234 (struct tui_win_info) <can_box>: New method.
5235 * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
5236 method.
5237
5238 2019-08-15 Tom de Vries <tdevries@suse.de>
5239
5240 * linux-nat-trad.c: Include gdbarch.h.
5241
5242 2019-08-14 Alan Hayward <alan.hayward@arm.com>
5243
5244 * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
5245 register sizes.
5246
5247 2019-08-14 Tom Tromey <tromey@adacore.com>
5248
5249 * darwin-nat.c: Include gdbarch.h.
5250 * darwin-nat-info.c: Include gdbarch.h.
5251
5252 2019-08-13 Tom Tromey <tom@tromey.com>
5253
5254 * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
5255 Remove.
5256 * tui/tui-data.c (tui_initialize_static_data): Update.
5257
5258 2019-08-13 Tom Tromey <tom@tromey.com>
5259
5260 * tui/tui-winsource.h (struct tui_exec_info_window)
5261 <~tui_exec_info_window, maybe_allocate_content, get_content,
5262 m_content>: Remove.
5263 (struct tui_source_window_base) <set_exec_info_content,
5264 show_exec_info_content>: Don't declare.
5265 * tui/tui-winsource.c
5266 (tui_exec_info_window::maybe_allocate_content): Remove.
5267 (tui_source_window_base::update_exec_info): Rename from
5268 set_exec_info_content.
5269 (tui_source_window_base::show_exec_info_content)
5270 (tui_source_window_base::update_exec_info): Remove.
5271
5272 2019-08-13 Tom Tromey <tom@tromey.com>
5273
5274 * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
5275 declare.
5276 * tui/tui-winsource.c (tui_update_source_window_as_is)
5277 (tui_update_source_windows_with_addr, tui_erase_source_content):
5278 Update.
5279 (tui_clear_exec_info_content): Remove.
5280
5281 2019-08-13 Tom Tromey <tom@tromey.com>
5282
5283 * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
5284 declare.
5285 * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
5286 call tui_erase_exec_info_content.
5287 (tui_clear_exec_info_content): Rename from
5288 tui_erase_exec_info_content.
5289 (tui_clear_exec_info_content): Delete.
5290
5291 2019-08-13 Tom Tromey <tom@tromey.com>
5292
5293 * tui/tui-winsource.h (struct tui_source_window_base)
5294 <show_exec_info_content>: Declare.
5295 (tui_show_exec_info_content): Don't declare.
5296 * tui/tui-winsource.c
5297 (tui_source_window_base::show_exec_info_content): Rename from
5298 tui_show_exec_info_content.
5299 (tui_source_window_base::update_exec_info): Update.
5300
5301 2019-08-13 Tom Tromey <tom@tromey.com>
5302
5303 * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
5304 (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
5305 (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
5306 * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
5307 tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
5308 (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
5309 ... here.
5310
5311 2019-08-13 Tom Tromey <tom@tromey.com>
5312
5313 * tui/tui-winsource.h (struct tui_source_window_base)
5314 <update_exec_info>: Declare.
5315 (tui_update_exec_info): Don't declare.
5316 * tui/tui-winsource.c (tui_update_source_window_as_is)
5317 (tui_source_window_base::refresh_all)
5318 (tui_update_all_breakpoint_info): Update.
5319 (tui_source_window_base::update_exec_info): Rename from
5320 tui_update_exec_info.
5321 * tui/tui-stack.c (tui_show_frame_info): Update.
5322
5323 2019-08-13 Tom Tromey <tom@tromey.com>
5324
5325 * tui/tui-winsource.h (struct tui_source_window_base)
5326 <set_exec_info_content>: Declare.
5327 (tui_set_exec_info_content): Don't declare.
5328 * tui/tui-winsource.c
5329 (tui_source_window_base::set_exec_info_content): Rename from
5330 tui_set_exec_info_content.
5331 (tui_update_exec_info): Update.
5332
5333 2019-08-13 Tom Tromey <tom@tromey.com>
5334
5335 * tui/tui-winsource.h (struct tui_source_window_base)
5336 <show_source_content>: Declare.
5337 (tui_show_source_content): Don't declare.
5338 * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
5339 (tui_source_window_base::show_source_content): Rename from
5340 tui_show_source_content.
5341 (tui_source_window_base::refresh_all): Update.
5342 * tui/tui-layout.c (show_source_disasm_command)
5343 (show_source_or_disasm_and_command): Update.
5344
5345 2019-08-13 Tom Tromey <tom@tromey.com>
5346
5347 * tui/tui-winsource.c (tui_erase_source_content)
5348 (tui_show_source_content, tui_source_window_base::refresh_all):
5349 Update.
5350 * tui/tui-wingeneral.h
5351 (tui_check_and_display_highlight_if_needed): Don't declare.
5352 * tui/tui-wingeneral.c
5353 (tui_win_info::check_and_display_highlight_if_needed): Rename from
5354 check_and_display_highlight_if_needed.
5355 * tui/tui-win.c (tui_rehighlight_all)
5356 (tui_win_info::make_visible_with_new_height): Update.
5357 * tui/tui-regs.c (tui_data_window::display_registers_from_line)
5358 (tui_data_window::erase_data_content)
5359 (tui_data_window::display_all_data): Update.
5360 * tui/tui-data.h (struct tui_win_info)
5361 <check_and_display_highlight_if_needed>: Declare.
5362
5363 2019-08-13 Tom Tromey <tom@tromey.com>
5364
5365 * tui/tui-win.c (tui_resize_all): Call
5366 tui_delete_invisible_windows.
5367 * tui/tui-layout.c (show_layout): Call
5368 tui_delete_invisible_windows.
5369 * tui/tui-data.h (tui_delete_invisible_windows): Declare.
5370 * tui/tui-data.c (tui_delete_invisible_windows): New function.
5371
5372 2019-08-13 Tom Tromey <tom@tromey.com>
5373
5374 * tui/tui-disasm.c (tui_show_disassem): Add assertion. Don't call
5375 tui_add_win_to_layout.
5376
5377 2019-08-13 Tom Tromey <tom@tromey.com>
5378
5379 * tui/tui-layout.h (tui_default_win_height): Don't declare.
5380 * tui/tui-layout.c (tui_default_win_height): Now static.
5381
5382 2019-08-13 Tom Tromey <tom@tromey.com>
5383
5384 * tui/tui-layout.c (show_layout): Unify all layout cases into a
5385 single switch.
5386 (show_source_disasm_command, show_source_or_disasm_and_command):
5387 Don't check current layout.
5388
5389 2019-08-13 Tom Tromey <tom@tromey.com>
5390
5391 * tui/tui-wingeneral.c (make_all_visible): Remove.
5392 (tui_make_all_invisible): Simplify.
5393 * tui/tui-layout.c (tui_make_all_invisible): Move from
5394 tui-wingeneral.c; simplify.
5395 (show_layout): Hoist call to tui_make_all_invisible.
5396 (show_data): Don't call tui_make_all_invisible.
5397
5398 2019-08-13 Tom Tromey <tom@tromey.com>
5399
5400 * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
5401 * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
5402
5403 2019-08-13 Tom Tromey <tom@tromey.com>
5404
5405 * tui/tui-layout.c (current_layout, tui_current_layout): Move from
5406 tui-data.c.
5407 (show_source_disasm_command, show_data)
5408 (show_source_or_disasm_and_command): Don't use
5409 tui_set_current_layout_to.
5410 * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
5411 * tui/tui-data.c (current_layout, tui_current_layout): Move to
5412 tui-layout.c.
5413 (tui_set_current_layout_to): Remove.
5414
5415 2019-08-13 Tom Tromey <tom@tromey.com>
5416
5417 * tui/tui-layout.c (tui_set_layout): Update.
5418 * tui/tui-data.h (struct tui_layout_def): Remove.
5419 (tui_layout_def): Don't declare.
5420 * tui/tui-data.c (layout_def): Remove.
5421 (tui_layout_def): Remove.
5422
5423 2019-08-13 Tom Tromey <tom@tromey.com>
5424
5425 * tui/tui-winsource.h (struct tui_source_window_base)
5426 <clear_detail>: No longer "override".
5427 * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
5428 * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
5429 * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
5430 * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
5431 Remove.
5432 * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
5433
5434 2019-08-13 Tom Tromey <tromey@adacore.com>
5435
5436 * tracepoint.c: Don't include readline.h or history.h.
5437
5438 2019-08-12 Tom Tromey <tom@tromey.com>
5439
5440 * configure: Rebuild.
5441 * configure.ac: Check for readline 7.
5442 * NEWS: Mention readline 7 requirement.
5443 * README: Update.
5444
5445 2019-08-12 Tom Tromey <tom@tromey.com>
5446
5447 * mingw-hdep.c (gdb_select): Remove readline hack.
5448
5449 2019-08-09 Pedro Franco de Carvalho <pedromfc@linux.ibm.com>
5450
5451 * blockframe.c (find_pc_partial_function): Set *block to nullptr
5452 when the function fails.
5453
5454 2019-08-09 Andreas Arnez <arnez@linux.ibm.com>
5455
5456 * s390-tdep.c (s390_type_align): New function.
5457 (s390_gdbarch_init): Set it as type_align gdbarch method.
5458
5459 2019-08-09 Tom de Vries <tdevries@suse.de>
5460
5461 PR gdb/24591
5462 * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
5463 pc_low with relocation offset.
5464
5465 2019-08-07 Tom Tromey <tromey@adacore.com>
5466
5467 * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
5468 (print_frame_args): Update.
5469 * python/py-framefilter.c (py_print_single_arg, enumerate_args):
5470 Update.
5471 * mi/mi-cmd-stack.c (list_arg_or_local): Update.
5472 * frame.h (struct frame_arg): Add initializers.
5473 <error>: Now a unique_xmalloc_ptr.
5474
5475 2019-08-07 Alan Hayward <alan.hayward@arm.com>
5476
5477 * NEWS: Expand the Pointer Authentication entry.
5478 * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
5479 (aarch64_frame_unmask_lr): ... to this.
5480 (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
5481 Call aarch64_frame_unmask_lr.
5482 * frame.c (struct frame_info): Add "masked" variable.
5483 (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
5484 (fprint_frame): Check for masked pc.
5485 * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
5486 declarations.
5487 * python/py-framefilter.c (py_print_frame): Check for masked pc.
5488 * stack.c (print_frame): Check for masked pc.
5489
5490 2019-08-06 Tom Tromey <tom@tromey.com>
5491
5492 * stabsread.c (patch_block_stabs, read_one_struct_field)
5493 (read_enum_type): Use obstack_strndup.
5494 * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
5495 * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
5496 * dwarf2read.c (guess_full_die_structure_name)
5497 (anonymous_struct_prefix): Use obstack_strndup.
5498 * dbxread.c (cp_set_block_scope): Use obstack_strndup.
5499 * c-exp.y (yylex): Use obstack_strndup.
5500 * ada-exp.y (write_object_renaming, write_ambiguous_var)
5501 (write_var_or_type): Use obstack_strndup.
5502
5503 2019-08-06 Tom Tromey <tom@tromey.com>
5504
5505 * symfile.c (reread_symbols): Use obstack_strdup.
5506 * stabsread.c (read_type): Use obstack_strdup.
5507 * gdb_obstack.h (obstack_strdup): New overload.
5508 * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
5509 (create_dwo_unit_in_dwp_v2, build_error_marker_type)
5510 (dwarf2_canonicalize_name): Use obstack_strdup.
5511 * dbxread.c (read_dbx_symtab): Use obstack_strdup.
5512 * cp-support.c (inspect_type, replace_typedefs_qualified_name):
5513 Use obstack_strdup.
5514
5515 2019-08-06 Tom Tromey <tom@tromey.com>
5516
5517 * gdb_obstack.h (obstack_strdup): Define.
5518 * gdb_obstack.c (obstack_strdup): Don't define.
5519
5520 2019-08-06 Tom Tromey <tom@tromey.com>
5521
5522 * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
5523 obstack_strdup.
5524 * typeprint.c (typedef_hash_table::find_global_typedef): Use
5525 obstack_strdup.
5526 * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
5527 * stabsread.c (common_block_start): Use obstack_strdup.
5528 * objfiles.c (set_objfile_main_name, objfile): Use
5529 obstack_strdup.
5530 * namespace.c (add_using_directive): Use obstack_strdup.
5531 * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
5532 * jit.c (finalize_symtab): Use obstack_strdup.
5533 * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
5534 (guess_partial_die_structure_name, partial_die_info::fixup)
5535 (dwarf2_name): Use obstack_strdup.
5536 * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
5537 obstack_strdup.
5538 * c-exp.y (scan_macro_expansion): Use obstack_strdup.
5539 * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
5540 obstack_strdup.
5541 * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
5542
5543 2019-08-07 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5544
5545 * unittests/help-doc-selftests.c: New file.
5546 * Makefile.in: Add the new file.
5547
5548 2019-08-07 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5549
5550 * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
5551 * cli/cli-decode.c (print_doc_line): Likewise. It now prints
5552 the full first line, except when FOR_VALUE_PREFIX. In this case,
5553 the trailing '.' is not output, and the first character is uppercased.
5554 (print_help_for_command): Update call to print_doc_line.
5555 (print_doc_of_command): Likewise.
5556 * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
5557 * cli/cli-option.c (append_indented_doc): Do not append newline.
5558 (build_help_option): Append newline after first appended_indented_doc
5559 only if a second call is done.
5560 (build_help): Append 2 new lines before each option, except the first
5561 one.
5562 * compile/compile.c (_initialize_compile): Add new lines after
5563 %OPTIONS%, when not at the end of the help.
5564 Change help doc or code
5565 producing the help doc to respect the invariants.
5566 * maint-test-options.c (_initialize_maint_test_options): Likewise.
5567 Also removed the new line after 'Options:', as all other commands
5568 do not put an empty line between 'Options:' and the first option.
5569 * printcmd.c (_initialize_printcmd): Likewise.
5570 * stack.c (_initialize_stack): Likewise.
5571 * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
5572 incorrectly telling COMMAND is optional.
5573 * ada-lang.c (_initialize_ada_language): Change help doc or code
5574 producing the help doc to respect the invariants.
5575 * ada-tasks.c (_initialize_ada_tasks): Likewise.
5576 * breakpoint.c (_initialize_breakpoint): Likewise.
5577 * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
5578 * cli/cli-logging.c (_initialize_cli_logging): Likewise.
5579 * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
5580 * cli/cli-style.c (cli_style_option::add_setshow_commands,
5581 _initialize_cli_style): Likewise.
5582 * corelow.c (core_target_info): Likewise.
5583 * dwarf-index-cache.c (_initialize_index_cache): Likewise.
5584 * dwarf2read.c (_initialize_dwarf2_read): Likewise.
5585 * filesystem.c (_initialize_filesystem): Likewise.
5586 * frame.c (_initialize_frame): Likewise.
5587 * gnu-nat.c (add_task_commands): Likewise.
5588 * infcall.c (_initialize_infcall): Likewise.
5589 * infcmd.c (_initialize_infcmd): Likewise.
5590 * interps.c (_initialize_interpreter): Likewise.
5591 * language.c (_initialize_language): Likewise.
5592 * linux-fork.c (_initialize_linux_fork): Likewise.
5593 * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
5594 * maint.c (_initialize_maint_cmds): Likewise.
5595 * memattr.c (_initialize_mem): Likewise.
5596 * printcmd.c (_initialize_printcmd): Likewise.
5597 * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
5598 _RegEx): Likewise.
5599 * ravenscar-thread.c (_initialize_ravenscar): Likewise.
5600 * record-btrace.c (_initialize_record_btrace): Likewise.
5601 * record-full.c (_initialize_record_full): Likewise.
5602 * record.c (_initialize_record): Likewise.
5603 * regcache-dump.c (_initialize_regcache_dump): Likewise.
5604 * regcache.c (_initialize_regcache): Likewise.
5605 * remote.c (add_packet_config_cmd, init_remote_threadtests,
5606 _initialize_remote): Likewise.
5607 * ser-tcp.c (_initialize_ser_tcp): Likewise.
5608 * serial.c (_initialize_serial): Likewise.
5609 * skip.c (_initialize_step_skip): Likewise.
5610 * source.c (_initialize_source): Likewise.
5611 * stack.c (_initialize_stack): Likewise.
5612 * symfile.c (_initialize_symfile): Likewise.
5613 * symtab.c (_initialize_symtab): Likewise.
5614 * target-descriptions.c (_initialize_target_descriptions): Likewise.
5615 * top.c (init_main): Likewise.
5616 * tracefile-tfile.c (tfile_target_info): Likewise.
5617 * tracepoint.c (_initialize_tracepoint): Likewise.
5618 * tui/tui-win.c (_initialize_tui_win): Likewise.
5619 * utils.c (add_internal_problem_command): Likewise.
5620 * valprint.c (value_print_option_defs): Likewise.
5621
5622 2019-08-06 Frank Ch. Eigler <fche@redhat.com>
5623
5624 PR build/24886
5625 * configure.ac: Drop enable-libmcheck support.
5626 * configure, config.in: Rebuild.
5627 * libmcheck.m4: Remove.
5628 * acinclude.m4: Don't include it.
5629 * Makefile.in: Don't distribute it.
5630 * top.c (print_gdb_configuration): Don't mention it.
5631
5632 2019-08-06 Tom Tromey <tom@tromey.com>
5633
5634 * utils.c (set_output_style): Sometimes pass stream to
5635 emit_style_escape.
5636 * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
5637 * record-btrace.c (btrace_insn_history): Update.
5638 * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
5639 method.
5640 * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
5641 Update initializers.
5642 <m_uiout>: New field.
5643 <m_di>: Move lower.
5644 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
5645 Remove "uiout" parameter.
5646 (dump_insns): Update.
5647 * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
5648 * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
5649
5650 2019-08-06 Christian Biesinger <cbiesinger@google.com>
5651
5652 * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
5653 (error_in_psymtab_expansion): Likewise.
5654 (lookup_symbol_via_quick_fns): Likewise.
5655 (basic_lookup_transparent_type_quick): Likewise.
5656 (basic_lookup_transparent_type_1): Likewise.
5657
5658 2019-08-06 Tom Tromey <tromey@adacore.com>
5659
5660 * source.c (last_source_error): Now bool.
5661 (print_source_lines_base): Make "noprint" bool. Only open
5662 source file when last_source_visited changes.
5663
5664 2019-08-06 Tom Tromey <tromey@adacore.com>
5665
5666 * annotate.c (annotate_source_line): Use g_source_cache.
5667 * source-cache.c (source_cache::get_plain_source_lines): Change
5668 parameters. Populate m_offset_cache.
5669 (source_cache::ensure): New method.
5670 (source_cache::get_line_charpos): New method.
5671 (extract_lines): Move lower. Change parameters.
5672 (source_cache::get_source_lines): Move lower.
5673 * source-cache.h (class source_cache): Update comment.
5674 <get_line_charpos>: New method.
5675 <get_source_lines>: Update comment.
5676 <clear>: Clear m_offset_cache.
5677 <get_plain_source_lines>: Change parameters.
5678 <ensure>: New method
5679 <m_offset_cache>: New member.
5680 * source.c (forget_cached_source_info_for_objfile): Update.
5681 (info_source_command): Use g_source_cache.
5682 (find_source_lines, open_source_file_with_line_charpos): Remove.
5683 (print_source_lines_base, search_command_helper): Use g_source_cache.
5684 * source.h (open_source_file_with_line_charpos): Don't declare.
5685 * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
5686 * tui/tui-source.c (tui_source_window::do_scroll_vertical):
5687 Use g_source_cache.
5688
5689 2019-08-06 Tom Tromey <tromey@adacore.com>
5690
5691 * source-cache.c (source_cache::get_plain_source_lines):
5692 Remove "first_line" and "last_line" parameters.
5693 (source_cache::get_source_lines): Cache plain text.
5694 * source-cache.h (class source_cache)
5695 <get_plain_source_lines>: Update.
5696
5697 2019-08-06 Tom Tromey <tromey@adacore.com>
5698
5699 * source-cache.c (extract_lines): No longer a method.
5700 Changed type of parameter. Include final newline.
5701 (selftests::extract_lines_test): New function.
5702 (_initialize_source_cache): Likewise.
5703 * source-cache.h (class source_cache)
5704 <extract_lines>: Don't declare.
5705
5706 2019-08-06 Tom Tromey <tromey@adacore.com>
5707
5708 * breakpoint.c (init_breakpoint_sal): Update.
5709 (breakpoint): Update.
5710 * breakpoint.h (struct breakpoint) <filter>: Now a
5711 unique_xmalloc_ptr.
5712
5713 2019-08-05 Christian Biesinger <cbiesinger@google.com>
5714
5715 * NEWS: Mention dictionary access on blocks.
5716 * python/py-block.c (blpy_getitem): New function.
5717 (block_object_as_mapping): New struct.
5718 (block_object_type): Use new struct for tp_as_mapping field.
5719
5720 2019-08-05 Christian Biesinger <cbiesinger@google.com>
5721
5722 * objfiles.h (objfile): Add a comment describing partial symbols.
5723
5724 2019-08-05 Tom Tromey <tromey@adacore.com>
5725
5726 * compile/compile.c (_initialize_compile): Use _(), not N_().
5727 * thread.c (_initialize_thread): Use _(), not N_().
5728 * stack.c (_initialize_stack): Use _(), not N_().
5729 * printcmd.c (_initialize_printcmd): Use _(), not N_().
5730
5731 2019-08-04 Simon Marchi <simon.marchi@polymtl.ca>
5732
5733 * dwarf2read.c (struct dw2_symtab_iterator):
5734 <want_specific_block>: Remove.
5735 <block_index>: Change type to gdb::optional.
5736 (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
5737 change type of BLOCK_INDEX parameter to gdb::optional.
5738 (dw2_symtab_iter_next): Re-write in function of gdb::optional.
5739 (dw2_lookup_symbol): Don't pass argument for
5740 WANT_SPECIFIC_BLOCK.
5741 (dw2_expand_symtabs_for_function): Don't pass argument for
5742 WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
5743 (class dw2_debug_names_iterator)
5744 <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
5745 parameter, change BLOCK_INDEX type to gdb::optional.
5746 <m_want_specific_block>: Remove.
5747 <m_block_index>: Change type to gdb::optional.
5748 (dw2_debug_names_iterator::next): Change type of IS_STATIC to
5749 gdb::optional. Re-write in function of gdb::optional.
5750 (dw2_debug_names_lookup_symbol): Don't pass argument for
5751 WANT_SPECIFIC_BLOCK.
5752 (dw2_debug_names_expand_symtabs_for_function): Don't pass
5753 argument for WANT_SPECIFIC_BLOCK, pass empty optional for
5754 BLOCK_INDEX.
5755
5756 2019-08-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5757
5758 * NEWS: Mention changes to "info sources" command.
5759
5760 2019-08-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5761
5762 * symtab.c (filename_partial_match_opts): New struct type.
5763 (struct output_source_filename_data): New members
5764 regexp, c_regexp, partial_match.
5765 (output_source_filename): Use new members to decide to print file.
5766 (info_sources_option_defs): New variable.
5767 (make_info_sources_options_def_group, print_info_sources_header,
5768 info_sources_command_completer):
5769 New functions.
5770 (info_sources_command): Read new optional arguments.
5771 (_initialize_symtab): Update info sources help.
5772
5773 2019-08-02 Alexandre Oliva <oliva@adacore.com>
5774
5775 * ada-lang.c (exception_support_info_v0): Renamed from...
5776 (default_exception_support_info): ... this. Create new
5777 definition for v1.
5778 (ada_has_this_exception_support): Look up catch_handlers_sym.
5779 (ada_exception_support_info_sniffer): Try v0 after default.
5780
5781 2019-08-01 Tom Tromey <tromey@adacore.com>
5782
5783 * ia64-libunwind-tdep.h (struct libunwind_descr): Include
5784 gdbarch.h.
5785
5786 2019-08-01 Christian Biesinger <cbiesinger@google.com>
5787
5788 * s12z-tdep.c: Fix include path for s12z-opc.h.
5789
5790 2019-08-01 Alan Hayward <alan.hayward@arm.com>
5791
5792 * NEWS: Require GNU make 3.82.
5793
5794 2019-07-16 Tom Tromey <tom@tromey.com>
5795
5796 * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
5797 declare.
5798
5799 2019-07-30 Tom Tromey <tromey@adacore.com>
5800
5801 * block.c (contained_in): Remove BLOCK_FUNCTION check.
5802
5803 2019-07-30 Kevin Buettner <kevinb@redhat.com>
5804
5805 * printcmd.c (print_address_symbolic): Print negative offsets.
5806 (build_address_symbolic): Force signed arithmetic when computing
5807 offset.
5808
5809 2019-07-30 Christian Biesinger <cbiesinger@google.com>
5810
5811 PR/24474: Add a function to lookup static variables.
5812 * NEWS: Mention this new function.
5813 * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
5814 * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
5815 * python/python.c (python_GdbMethods): Add new function.
5816
5817 2019-07-29 Christian Biesinger <cbiesinger@google.com>
5818
5819 * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
5820 * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
5821 (objfpy_lookup_static_symbol): New function.
5822 (objfile_object_methods): Add new functions.
5823
5824 2019-07-29 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5825
5826 * NEWS: Mention 'set|show print frame-info'. Mention new
5827 'presence' value for 'frame-arguments'. Mention new '-frame-info'
5828 backtrace argument. Mention that python frame filtering code
5829 is now consistent with what 'backtrace' command prints.
5830
5831 2019-07-29 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5832
5833 * frame.h (enum print_what): New value 'SHORT_LOCATION', update
5834 comments.
5835 (print_frame_info_auto, print_frame_info_source_line,
5836 print_frame_info_location, print_frame_info_source_and_location,
5837 print_frame_info_location_and_address, print_frame_info_short_location):
5838 New declarations.
5839 (struct frame_print_options): New member print_frame_info.
5840 * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
5841 * stack.h (get_user_print_what_frame_info): New declaration.
5842 (frame_show_address): New declaration.
5843 * stack.c (print_frame_arguments_choices): New value 'presence'.
5844 (print_frame_info_auto, print_frame_info_source_line,
5845 print_frame_info_location, print_frame_info_source_and_location,
5846 print_frame_info_location_and_address, print_frame_info_short_location,
5847 print_frame_info_choices, print_frame_info_print_what): New definitions.
5848 (print_frame_args): Only print dots for args if print frame-arguments
5849 is 'presence'.
5850 (frame_print_option_defs): New element for "frame-info".
5851 (get_user_print_what_frame_info): New function.
5852 (frame_show_address): Make non static. Move comment to stack.h.
5853 (print_frame_info_to_print_what): New function.
5854 (print_frame_info): Update comment. Use fp_opts.print_frame_info
5855 to decide what to print.
5856 (backtrace_command_1): Handle the new print_frame_arguments_presence
5857 value.
5858 (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
5859 * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
5860 (py_print_frame): In non-mi mode, use LOCATION as default for
5861 print_what, similarly to frame information printed directly by
5862 backtrace command. Handle frame-info user option in non MI mode.
5863
5864 2019-07-27 Kevin Buettner <kevinb@redhat.com>
5865
5866 * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
5867 Add case for debugging 32-bit target on 64-bit host. Revise
5868 comment.
5869
5870 2019-07-27 Kevin Buettner <kevinb@redhat.com>
5871
5872 * infrun.c (fill_in_stop_func): Use find_pc_partial_function
5873 instead of find_function_entry_range_from_pc.
5874
5875 2019-07-27 Kevin Buettner <kevinb@redhat.com>
5876
5877 * stack.c (find_frame_funname): Remove code which preferred
5878 minsym over symtab sym in "certain pathological cases".
5879
5880 * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
5881 parameter. Change type of "do_demangle" to bool.
5882 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
5883 Pass suitable "prefer_sym_over_minsym" flag to
5884 build_address_symbolic(). Don't output "+" for negative offsets.
5885 * printcmd.c (print_address_symbolic): Update invocation of
5886 build_address_symbolic to include a "prefer_sym_over_minsym"
5887 flag.
5888 (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
5889 Restrict cases in which use of minimal symbol is preferred to that
5890 of a found symbol. Update comments.
5891
5892 * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
5893 for entry pc when entry pc is out of range for that FDE.
5894
5895 2019-07-26 Brian Callahan <bcallah@openbsd.org>
5896
5897 PR gdb/24839:
5898 * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
5899 type.
5900
5901 2019-07-25 Christian Biesinger <cbiesinger@google.com>
5902
5903 * python/py-objfile.c (add_separate_debug_file): Fix comment about
5904 this function's Python signature.
5905
5906
5907 2019-07-24 Christian Biesinger <cbiesinger@google.com>
5908
5909 * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
5910 * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
5911 * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
5912 * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
5913 * symtab.h (lookup_global_symbol_from_objfile): Likewise.
5914
5915
5916 2019-07-24 Yoshinori Sato <ysato@users.sourceforge.jp>
5917
5918 * h8300-tdep.c (h8300_register_name_common): New.
5919 h8300_register_name): Use h8300_register_name_common.
5920 (h8300s_register_name): Likewise.
5921 (h8300sx_register_name): Likewise.
5922 (h8300h_register_nam): New.
5923 (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
5924
5925
5926 2019-07-23 Srinath Parvathaneni <srinath.parvathaneni@arm.com>
5927
5928 * arm-tdep.c (arm_skip_cmse_entry): New function.
5929 (arm_is_sgstubs_section): New function.
5930 (arm_skip_stub): Add call to arm_skip_cmse_entry function.
5931
5932 2019-07-22 Tom Tromey <tom@tromey.com>
5933
5934 * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
5935 Don't self-assign.
5936
5937 2019-07-22 Andrew Burgess <andrew.burgess@embecosm.com>
5938
5939 * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
5940 type_print.
5941
5942 2019-07-22 Andrew Burgess <andrew.burgess@embecosm.com>
5943
5944 * symtab.c (search_symbols): Adjust msymbol matching type arrays
5945 so that GDB doesn't match any msymbols when searching in the
5946 TYPES_DOMAIN.
5947 (print_symbol_info): Print using typedef_print or type_print based
5948 on the type of the symbol. Add updated FIXME comment moved from...
5949 (_initialize_symtab): ... move and update FIXME comment to above.
5950
5951 2019-07-22 Andrew Burgess <andrew.burgess@embecosm.com>
5952
5953 * NEWS: Mention adding -q option to "info types".
5954 * symtab.c (struct info_types_options): New struct.
5955 (info_types_options_defs): New variable.
5956 (make_info_types_options_def_group): New function.
5957 (info_types_command): Use gdb::option framework to parse options.
5958 (info_types_command_completer): New function.
5959 (_initialize_symtab): Extend the help text on "info types" and
5960 register command completer.
5961
5962 2019-07-21 Christian Biesinger <cbiesinger@google.com>
5963
5964 * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
5965 (lookup_symbol_in_objfile): Change int to block_enum and add a
5966 gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
5967
5968 2019-07-20 Christian Biesinger <cbiesinger@google.com>
5969
5970 * MAINTAINERS (Write After Approval): Add self.
5971
5972 2019-07-19 Andrew Burgess <andrew.burgess@embecosm.com>
5973
5974 * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
5975 instruction to the dummy code region.
5976
5977 2019-07-19 Tom Tromey <tromey@adacore.com>
5978
5979 * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
5980 (ARGSUSED, PARAMS, __func__): Remove rules.
5981
5982 2019-07-19 Alan Hayward <alan.hayward@arm.com>
5983
5984 * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
5985 * features/arm/arm-with-iwmmxt.c: Remove.
5986 * features/arm/arm-with-iwmmxt.xml: Remove.
5987 * features/arm/arm-with-m-fpa-layout.c: Remove.
5988 * features/arm/arm-with-m-fpa-layout.xml: Remove.
5989 * features/arm/arm-with-m-vfp-d16.c: Remove.
5990 * features/arm/arm-with-m-vfp-d16.xml: Remove.
5991 * features/arm/arm-with-m.c: Remove.
5992 * features/arm/arm-with-m.xml: Remove.
5993 * features/arm/arm-with-neon.c: Remove.
5994 * features/arm/arm-with-neon.xml: Remove.
5995 * features/arm/arm-with-vfpv2.c: Remove.
5996 * features/arm/arm-with-vfpv2.xml: Remove.
5997 * features/arm/arm-with-vfpv3.c: Remove.
5998 * features/arm/arm-with-vfpv3.xml: Remove.
5999
6000 2019-07-19 Alan Hayward <alan.hayward@arm.com>
6001
6002 * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
6003
6004 2019-07-19 Alan Hayward <alan.hayward@arm.com>
6005
6006 * arch/aarch32.c (aarch32_create_target_description): Create
6007 target descriptions using features.
6008 * arch/arm.c (arm_create_target_description)
6009 (arm_create_mprofile_target_description): Likewise.
6010 * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
6011
6012 2019-07-19 Alan Hayward <alan.hayward@arm.com>
6013
6014 * Makefile.in: Add new files.
6015 * aarch32-tdep.c: New file.
6016 * aarch32-tdep.h: New file.
6017 * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
6018 Call aarch32_read_description.
6019 * arch/aarch32.c: New file.
6020 * arch/aarch32.h: New file.
6021 * arch/arm.c (arm_create_target_description)
6022 (arm_create_mprofile_target_description): New function.
6023 * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
6024 (arm_create_target_description)
6025 (arm_create_mprofile_target_description): New declaration.
6026 * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
6027 read_description functions.
6028 * arm-linux-nat.c (arm_linux_nat_target::read_description):
6029 Likewise.
6030 * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
6031 * arm-tdep.c (tdesc_arm_list): New variable.
6032 (arm_register_g_packet_guesses): Call create description functions.
6033 (arm_read_description) (arm_read_mprofile_description): New
6034 function.
6035 * arm-tdep.h (arm_read_description)
6036 (arm_read_mprofile_description): Add declaration.
6037 * configure.tgt: Add new files.
6038
6039 2019-07-18 Guillaume LABARTHE <guillaume.labarthe@gmail.com>
6040
6041 * top.c (new_ui_command): Open specified terminal just once.
6042
6043 2019-07-18 Tom Tromey <tromey@adacore.com>
6044
6045 * symtab.c (main_name): Constify return type.
6046 * symfile.c (set_initial_language): Update.
6047 * symtab.h (main_name): Constify return type.
6048
6049 2019-07-17 Tom Tromey <tom@tromey.com>
6050
6051 * tui/tui-winsource.c (tui_update_source_window)
6052 (tui_update_source_window_as_is)
6053 (tui_update_source_windows_with_line): Remove return.
6054 * tui/tui-disasm.c (tui_show_disassem)
6055 (tui_show_disassem_and_update_source): Remove return.
6056 * tui/tui.c (tui_reset): Remove return.
6057 * tui/tui-wingeneral.c
6058 (tui_check_and_display_highlight_if_needed): Remove return.
6059
6060 2019-07-17 Tom Tromey <tom@tromey.com>
6061
6062 * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
6063
6064 2019-07-17 Tom Tromey <tom@tromey.com>
6065
6066 * tui/tui-winsource.h (struct tui_exec_info_window)
6067 (struct tui_source_window_base): Move from tui-data.h.
6068 * tui/tui-winsource.c: Move many method definitions from
6069 elsewhere. Remove "structuring" comments.
6070 * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
6071 (tui_source_window_base::refresh_window): Move to
6072 tui-winsource.c.
6073 * tui/tui-win.c (tui_source_window_base::refresh_all)
6074 (tui_source_window_base::update_tab_width)
6075 (tui_source_window_base::set_new_height)
6076 (tui_source_window_base::do_make_visible_with_new_height): Move to
6077 tui-winsource.c.
6078 * tui/tui-source.h: Update.
6079 * tui/tui-source.c (tui_source_window_base::reset): Move to
6080 tui-winsource.c.
6081 * tui/tui-disasm.h: Update.
6082 * tui/tui-data.h (struct tui_exec_info_window): Move to
6083 tui-winsource.h.
6084 (struct tui_source_window_base): Likewise.
6085 * tui/tui-data.c (tui_source_window_base::clear_detail)
6086 (tui_source_window_base, ~tui_source_window_base): Move to
6087 tui-winsource.c.
6088
6089 2019-07-17 Tom Tromey <tom@tromey.com>
6090
6091 * tui/tui-win.c (tui_resize_all)
6092 (tui_source_window_base::update_tab_width)
6093 (tui_adjust_win_heights): Update.
6094 (tui_win_info::make_invisible_and_set_new_height): Rename from
6095 make_invisible_and_set_new_height.
6096 * tui/tui-data.h (struct tui_win_info)
6097 <make_invisible_and_set_new_height>: New method.
6098
6099 2019-07-17 Tom Tromey <tom@tromey.com>
6100
6101 * tui/tui.c: Update.
6102 * tui/tui-source.h (struct tui_source_window): Move from
6103 tui-data.h.
6104 * tui/tui-layout.c: Update.
6105 * tui/tui-disasm.c: Update.
6106 * tui/tui-data.h (struct tui_source_window): Move to
6107 tui-source.h.
6108
6109 2019-07-17 Tom Tromey <tom@tromey.com>
6110
6111 * tui/tui-disasm.h (struct tui_disasm_window): Move from
6112 tui-data.h.
6113 * tui/tui-data.h (struct tui_disasm_window): Move to
6114 tui-disasm.h.
6115
6116 2019-07-17 Tom Tromey <tom@tromey.com>
6117
6118 * tui/tui-regs.h (struct tui_data_item_window): Move from
6119 tui-data.h.
6120 * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
6121 * tui/tui-data.h (struct tui_data_item_window): Move to
6122 tui-regs.h.
6123 * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
6124
6125 2019-07-17 Tom Tromey <tom@tromey.com>
6126
6127 * tui/tui.c: Update.
6128 * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
6129 (tui_cmd_window::max_height): Move to tui-command.c.
6130 * tui/tui-layout.c: Update.
6131 * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
6132 * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
6133 tui-command.c.
6134 * tui/tui-command.h (struct tui_cmd_window): Move from
6135 tui-data.h.
6136 * tui/tui-command.c: Remove "structuring" comments.
6137 (tui_cmd_window::clear_detail)
6138 (tui_cmd_window::do_make_visible_with_new_height)
6139 (tui_cmd_window::max_height): Move from elsewhere.
6140
6141 2019-07-17 Tom Tromey <tom@tromey.com>
6142
6143 * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
6144 Now static.
6145 * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
6146 * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
6147
6148 2019-07-17 Tom Tromey <tom@tromey.com>
6149
6150 * tui/tui.c: Update.
6151 * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
6152 tui-regs.c.
6153 * tui/tui-windata.h: Remove file.
6154 * tui/tui-windata.c: Remove file.
6155 * tui/tui-win.c (tui_data_window::set_new_height)
6156 (tui_data_window::do_make_visible_with_new_height): Move to
6157 tui-regs.c.
6158 * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
6159 * tui/tui-regs.c: Remove "structuring" comments.
6160 (tui_data_window::first_data_item_displayed)
6161 (tui_data_window::delete_data_content_windows)
6162 (tui_data_window::erase_data_content)
6163 (tui_data_window::display_all_data)
6164 (tui_data_window::refresh_all)
6165 (tui_data_window::do_scroll_vertical)
6166 (tui_data_window::clear_detail, tui_data_window::set_new_height)
6167 (tui_data_window::do_make_visible_with_new_height)
6168 (tui_data_window::refresh_window): Move from elsewhere.
6169 (_initialize_tui_regs): Move to end of file.
6170 * tui/tui-layout.c: Update.
6171 * tui/tui-hooks.c: Update.
6172 * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
6173 * tui/tui-data.c (tui_data_window::clear_detail): Move to
6174 tui-regs.c.
6175 * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
6176
6177 2019-07-17 Tom Tromey <tom@tromey.com>
6178
6179 * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
6180 seen.
6181
6182 2019-07-17 Tom Tromey <tom@tromey.com>
6183
6184 * tui/tui-win.c (tui_source_window_base::set_new_height)
6185 (tui_source_window_base::do_make_visible_with_new_height): Use
6186 m_has_locator field directly.
6187 * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
6188 method.
6189 (struct tui_source_window_base) <has_locator>: Likewise.
6190
6191 2019-07-17 Tom Tromey <tom@tromey.com>
6192
6193 * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
6194 Don't declare.
6195 * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
6196 Remove.
6197 * tui/tui-win.c (tui_source_window_base::set_new_height)
6198 (tui_source_window_base::set_new_height)
6199 (make_invisible_and_set_new_height)
6200 (tui_source_window_base::do_make_visible_with_new_height)
6201 (tui_source_window_base::do_make_visible_with_new_height):
6202 Update.
6203 * tui/tui-layout.c (show_source_disasm_command, show_data)
6204 (show_source_or_disasm_and_command): Update.
6205 * tui/tui-layout.c (show_layout): Update.
6206
6207 2019-07-17 Tom Tromey <tom@tromey.com>
6208
6209 * tui/tui-layout.c (make_data_window): Remove.
6210 (show_data): Unify creation and re-initialization cases.
6211
6212 2019-07-17 Tom Tromey <tom@tromey.com>
6213
6214 * tui/tui-layout.c (make_source_window, make_disasm_window):
6215 Remove.
6216 (show_data): Unify creation and re-initialization cases.
6217
6218 2019-07-17 Tom Tromey <tom@tromey.com>
6219
6220 * tui/tui-layout.c (make_command_window): Remove.
6221 (show_source_disasm_command, show_source_or_disasm_and_command):
6222 Unify creation and re-initialization cases.
6223
6224 2019-07-17 Tom Tromey <tom@tromey.com>
6225
6226 * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
6227 creation and re-initialization cases.
6228
6229 2019-07-17 Tom Tromey <tom@tromey.com>
6230
6231 * tui/tui-regs.c (tui_get_register): Return void.
6232
6233 2019-07-17 Tom Tromey <tom@tromey.com>
6234
6235 * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
6236 Simplify.
6237
6238 2019-07-17 Tom Tromey <tom@tromey.com>
6239
6240 * tui/tui-layout.c (show_source_disasm_command): Simplify window
6241 resetting.
6242
6243 2019-07-17 Tom Tromey <tom@tromey.com>
6244
6245 * tui/tui.h (tui_set_layout_by_name): Don't declare.
6246 * tui/tui-regs.c (tui_reg_layout): New function.
6247 (tui_show_registers, tui_reg_command): Use it.
6248 * tui/tui-layout.c (LAYOUT_USAGE): Remove.
6249 (tui_layout_command): Rename from tui_set_layout_by_name. Change
6250 parameters.
6251 (tui_layout_command): Remove.
6252
6253 2019-07-17 Tom Tromey <tom@tromey.com>
6254
6255 * tui/tui-layout.h (tui/tui-layout): Return void.
6256 * tui/tui-layout.c (tui_set_layout): Return void. Add assert.
6257
6258 2019-07-17 Tom Tromey <tom@tromey.com>
6259
6260 * tui/tui-layout.c (show_source_disasm_command, show_data):
6261 Update.
6262 (reset_locator): Remove.
6263 (show_source_or_disasm_and_command): Update.
6264
6265 2019-07-17 Tom Tromey <tom@tromey.com>
6266
6267 * tui/tui-source.c (tui_source_window_base::reset): Remove
6268 win_type parameter.
6269 * tui/tui-layout.c (make_command_window, make_source_window)
6270 (make_disasm_window, make_data_window)
6271 (show_source_disasm_command, show_data, tui_gen_win_info::reset)
6272 (reset_locator, show_source_or_disasm_and_command): Update.
6273 * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
6274 win_type parameter.
6275 (struct tui_source_window_base) <reset>: Likewise.
6276
6277 2019-07-17 Tom Tromey <tom@tromey.com>
6278
6279 * tui/tui-layout.c (show_source_disasm_command): Use
6280 reset_locator.
6281 (reset_locator): New function.
6282 (init_and_make_win): Remove.
6283 (show_source_or_disasm_and_command): Use reset_locator.
6284
6285 2019-07-17 Tom Tromey <tom@tromey.com>
6286
6287 * tui/tui-winsource.c (tui_set_exec_info_content): Remove
6288 condition.
6289 * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
6290 Remove condition.
6291 * tui/tui-source.c (tui_source_window_base::reset): New method.
6292 * tui/tui-layout.c (make_command_window): Don't call
6293 init_and_make_win.
6294 (make_source_window, make_disasm_window): Don't call
6295 make_source_or_disasm_window.
6296 (make_data_window): Don't call init_and_make_win. Change calling
6297 convention.
6298 (show_source_disasm_command, show_data): Simplify.
6299 (make_source_or_disasm_window): Remove.
6300 (show_source_or_disasm_and_command): Simplify.
6301 * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
6302 (struct tui_source_window_base) <reset>: Likewise.
6303 <execution_info>: Remove initializer.
6304 * tui/tui-data.c (tui_source_window_base): Initialize
6305 execution_info.
6306
6307 2019-07-17 Tom Tromey <tom@tromey.com>
6308
6309 * tui/tui-layout.c (tui_set_layout): Remove regs_populate
6310 variable.
6311
6312 2019-07-17 Tom Tromey <tom@tromey.com>
6313
6314 * tui/tui.c (tui_rl_other_window): Update.
6315 * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
6316 superclass method first. Always iterate over regs_content.
6317 (tui_unhighlight_win, tui_highlight_win): Use refresh_window
6318 method.
6319 * tui/tui-win.c (tui_set_focus_command): Update.
6320
6321 2019-07-17 Tom Tromey <tom@tromey.com>
6322
6323 * tui/tui-win.c (tui_set_focus_command): Rename from
6324 tui_set_focus. Call tui_enable.
6325 (tui_set_focus_command): Remove.
6326
6327 2019-07-17 Tom Tromey <tom@tromey.com>
6328
6329 * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
6330 refresh_window.
6331 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
6332 touchwin.
6333 (tui_data_window::refresh_window): Call refresh_window on data
6334 items. Always call superclass refresh_window.
6335 (tui_win_info::refresh): Remove.
6336 (tui_source_window_base::refresh_window): Update.
6337 (tui_refresh_all): Update.
6338 * tui/tui-layout.c (show_source_disasm_command): Remove call to
6339 refresh_window.
6340 (show_source_or_disasm_and_command): Likewise.
6341 * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
6342 (struct tui_source_window_base) <refresh>: Likewise.
6343
6344 2019-07-17 Tom Tromey <tom@tromey.com>
6345
6346 * tui/tui-winsource.c (tui_clear_source_content)
6347 (tui_show_source_content): Update.
6348 * tui/tui-source.c (tui_source_window::showing_source_p): Check
6349 whether content is empty.
6350 * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
6351 Remove.
6352
6353 2019-07-17 Tom Tromey <tom@tromey.com>
6354
6355 * tui/tui-winsource.c (tui_erase_source_content): Clear the
6356 window's contents.
6357 * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
6358 * tui/tui-source.c (tui_set_source_content_nil): Remove.
6359
6360 2019-07-17 Tom Tromey <tom@tromey.com>
6361
6362 * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
6363 (struct tui_data_item_window): Update.
6364
6365 2019-07-17 Tom Tromey <tom@tromey.com>
6366
6367 * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
6368 (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
6369 defines.
6370
6371 2019-07-17 Tom Tromey <tom@tromey.com>
6372
6373 * tui/tui-winsource.h (tui_erase_source_content)
6374 (tui_clear_source_content): Remove "display_prompt" parameter.
6375 * tui/tui-winsource.c (tui_update_source_window_as_is)
6376 (tui_update_source_windows_with_addr): Update.
6377 (tui_clear_source_content): Remove "display_prompt" parameter.
6378 (tui_erase_source_content): Likewise. Simplify.
6379 (tui_show_source_content): Update.
6380 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
6381 * tui/tui-stack.c (tui_show_frame_info): Update.
6382 * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
6383 Remove defines.
6384
6385 2019-07-17 Tom Tromey <tom@tromey.com>
6386
6387 * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
6388 * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
6389 parameter.
6390 * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
6391 parameter.
6392
6393 2019-07-17 Tom Tromey <tom@tromey.com>
6394
6395 * tui/tui-winsource.c (tui_clear_source_content)
6396 (tui_show_source_content, tui_show_exec_info_content)
6397 (tui_clear_exec_info_content): Update.
6398 * tui/tui-stack.c (tui_show_locator_content): Update.
6399 (tui_show_frame_info): Update.
6400 * tui/tui-source.h (tui_source_window): Don't declare.
6401 * tui/tui-source.c (tui_source_window::showing_source_p): Rename
6402 from tui_source_is_displayed.
6403 * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
6404 Remove field.
6405 (struct tui_source_window_base) <content_in_use>: New field. Now
6406 bool.
6407 (struct tui_source_window) <showing_source_p>: New method.
6408 (TUI_SRC_WIN): Change cast.
6409 * tui/tui-data.c (tui_initialize_static_data): Update.
6410
6411 2019-07-17 Tom Tromey <tom@tromey.com>
6412
6413 * tui/tui-winsource.c (tui_update_breakpoint_info): Use
6414 location_matches_p.
6415 * tui/tui-source.c (tui_source_window::location_matches_p): New
6416 method.
6417 * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
6418 method.
6419 * tui/tui-data.h (struct tui_source_window_base)
6420 <location_matches_p>: New method.
6421 (struct tui_source_window, struct tui_disasm_window)
6422 <location_matches_p>: Likewise.
6423
6424 2019-07-17 Tom Tromey <tom@tromey.com>
6425
6426 * tui/tui-win.c (tui_set_win_height_command): Rename from
6427 tui_set_win_height.
6428 (tui_set_win_height_command): Remove.
6429
6430 2019-07-17 Tom Tromey <tom@tromey.com>
6431
6432 * tui/tui-source.c (tui_source_window): New constructor. Add
6433 observer.
6434 (~tui_source_window): New destructor.
6435 (tui_source_window::style_changed): New method.
6436 * tui/tui-hooks.c (tui_redisplay_source): Remove.
6437 (tui_attach_detach_observers): Update.
6438 * tui/tui-data.h (struct tui_source_window): Make constructor not
6439 inline. Add destructor.
6440 (struct tui_source_window) <style_changed>: New method.
6441 <m_observable>: New member.
6442
6443 2019-07-17 Tom Tromey <tom@tromey.com>
6444
6445 * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
6446 * tui/tui-win.c (tui_resize_all): Fix typo.
6447
6448 2019-07-17 Tom Tromey <tom@tromey.com>
6449
6450 * tui/tui-wingeneral.h (tui_refresh_all): Update.
6451 * tui/tui-wingeneral.c (make_all_visible): Use foreach.
6452 (tui_refresh_all): Remove "list" parameter. Use foreach.
6453 * tui/tui-win.c (window_name_completer): Use foreach.
6454 (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
6455 (update_tab_width): Likewise.
6456 * tui/tui-layout.c (show_layout): Update.
6457 * tui/tui-data.h (class tui_window_iterator): New.
6458 (struct all_tui_windows): New.
6459 * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
6460
6461 2019-07-17 Tom Tromey <tom@tromey.com>
6462
6463 * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
6464 parameter. Don't reference globals.
6465 (tui_reg_command): Update.
6466
6467 2019-07-17 Tom Tromey <tom@tromey.com>
6468
6469 * tui/tui-regs.c (tui_show_registers): Simplify.
6470
6471 2019-07-17 Tom Tromey <tom@tromey.com>
6472
6473 * tui/tui-regs.c (tui_show_registers): Update.
6474 (tui_show_register_group): Add win_info parameter.
6475
6476 2019-07-17 Tom Tromey <tom@tromey.com>
6477
6478 * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
6479 Rename from tui_display_reg_element_at_line.
6480 (tui_data_window::display_registers_from_line): Update.
6481 * tui/tui-data.h (struct tui_data_window)
6482 <display_reg_element_at_line>: New method.
6483
6484 2019-07-17 Tom Tromey <tom@tromey.com>
6485
6486 * tui/tui-regs.h (tui_display_registers_from)
6487 (tui_display_registers_from_line): Don't declare.
6488 * tui/tui-windata.c (tui_data_window::display_all_data)
6489 (tui_data_window::refresh_all)
6490 (tui_data_window::do_scroll_vertical): Update.
6491 * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
6492 from tui_display_registers_from.
6493 (tui_display_reg_element_at_line): Update.
6494 (tui_data_window::display_registers_from_line): Rename from
6495 tui_display_registers_from_line.
6496 * tui/tui-data.h (struct tui_data_window) <display_registers_from,
6497 display_registers_from_line>: New methods.
6498
6499 2019-07-17 Tom Tromey <tom@tromey.com>
6500
6501 * tui/tui-windata.h (tui_erase_data_content): Don't declare.
6502 * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
6503 from tui_erase_data_content.
6504 (tui_data_window::display_all_data)
6505 (tui_data_window::refresh_all)
6506 (tui_data_window::do_scroll_vertical): Update.
6507 * tui/tui-regs.c (tui_show_registers): Update.
6508 * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
6509 New method.
6510
6511 2019-07-17 Tom Tromey <tom@tromey.com>
6512
6513 * tui/tui-windata.h (tui_delete_data_content_windows): Don't
6514 declare.
6515 * tui/tui-windata.c
6516 (tui_data_window::delete_data_content_windows): Rename from
6517 tui_delete_data_content_windows.
6518 (tui_data_window::display_all_data)
6519 (tui_data_window::do_scroll_vertical): Update.
6520 * tui/tui-data.h (struct tui_data_window)
6521 <delete_data_content_windows>: New method.
6522
6523 2019-07-17 Tom Tromey <tom@tromey.com>
6524
6525 * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
6526 * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
6527
6528 2019-07-17 Tom Tromey <tom@tromey.com>
6529
6530 * tui/tui-windata.h (tui_display_all_data): Don't declare.
6531 * tui/tui-windata.c (tui_data_window::display_all_data): Rename
6532 from tui_display_all_data.
6533 * tui/tui-win.c
6534 (tui_data_window::do_make_visible_with_new_height): Update.
6535 * tui/tui-regs.c (tui_show_registers): Update.
6536 * tui/tui-layout.c (tui_set_layout): Update.
6537 * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
6538 method.
6539
6540 2019-07-17 Tom Tromey <tom@tromey.com>
6541
6542 * tui/tui-windata.h (tui_display_data_from): Don't declare.
6543 * tui/tui-windata.c (tui_display_data_from): Remove.
6544 (tui_data_window::refresh_all): Update.
6545
6546 2019-07-17 Tom Tromey <tom@tromey.com>
6547
6548 * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
6549 * tui/tui-windata.c (tui_display_data_from_line): Remove.
6550 (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
6551 tui_display_registers_from_line.
6552 * tui/tui-regs.h (tui_display_registers_from_line): Update.
6553 * tui/tui-regs.c (tui_display_registers_from_line): Remove
6554 "force_display" parameter.
6555
6556 2019-07-17 Tom Tromey <tom@tromey.com>
6557
6558 * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
6559 declare.
6560 * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
6561 Rename from tui_first_reg_element_no_inline.
6562 (tui_display_reg_element_at_line)
6563 (tui_display_registers_from_line): Update.
6564 * tui/tui-data.h (struct tui_data_window)
6565 <first_reg_element_no_inline>: New method.
6566
6567 2019-07-17 Tom Tromey <tom@tromey.com>
6568
6569 * tui/tui-windata.c (tui_display_data_from)
6570 (tui_data_window::do_scroll_vertical): Update.
6571 * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
6572 * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
6573 Rename from tui_line_from_reg_element_no.
6574 (tui_display_registers_from_line): Update.
6575 * tui/tui-data.h (struct tui_data_window)
6576 <line_from_reg_element_no>: New method.
6577
6578 2019-07-17 Tom Tromey <tom@tromey.com>
6579
6580 * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
6581 * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
6582 tui_last_regs_line_no.
6583 (tui_display_reg_element_at_line)
6584 (tui_display_registers_from_line): Update.
6585 * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
6586 method.
6587
6588 2019-07-17 Tom Tromey <tom@tromey.com>
6589
6590 PR tui/24722:
6591 * tui/tui-winsource.h (tui_update_all_breakpoint_info)
6592 (tui_update_breakpoint_info): Add "being_deleted" parameter.
6593 * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
6594 (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
6595 (tui_update_breakpoint_info): Likewise.
6596 * tui/tui-hooks.c (tui_event_create_breakpoint)
6597 (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
6598 Update.
6599
6600 2019-07-17 Tom Tromey <tom@tromey.com>
6601
6602 * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
6603
6604 2019-07-17 Tom Tromey <tom@tromey.com>
6605
6606 * tui/tui-winsource.c (tui_update_source_window_as_is)
6607 (tui_update_source_windows_with_addr): Update.
6608 * tui/tui-source.h (tui_set_source_content)
6609 (tui_show_symtab_source): Add "win_info" parameter.
6610 * tui/tui-source.c (tui_set_source_content): Add "win_info"
6611 parameter.
6612 (tui_show_symtab_source): Likewise.
6613
6614 2019-07-17 Tom Tromey <tom@tromey.com>
6615
6616 * tui/tui-wingeneral.c
6617 (tui_check_and_display_highlight_if_needed): Check can_highlight.
6618
6619 2019-07-17 Tom Tromey <tom@tromey.com>
6620
6621 * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
6622 (struct tui_cmd_window) <can_scroll>: New method.
6623 * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
6624 method.
6625
6626 2019-07-17 Tom Tromey <tromey@adacore.com>
6627
6628 * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
6629 do_field_signed>: Rename. Change type of "value".
6630 * ui-out.c (ui_out::field_signed): Rename from field_int.
6631 Change type of "value".
6632 (ui_out::field_fmt_signed): Rename from field_fmt_int. Change
6633 type of "value".
6634 * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
6635 do_field_int. Change type of "value".
6636 * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
6637 do_field_int. Change type of "value".
6638 * tracepoint.c (trace_status_mi, tfind_1)
6639 (print_one_static_tracepoint_marker): Update.
6640 * thread.c (print_thread_info_1, print_selected_thread_frame):
6641 Update.
6642 * stack.c (print_frame, print_frame_info): Update.
6643 * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
6644 Update.
6645 * source.c (print_source_lines_base): Update.
6646 * skip.c (info_skip_command): Update.
6647 * record-btrace.c (btrace_ui_out_decode_error)
6648 (btrace_call_history_src_line): Update.
6649 * python/py-framefilter.c (py_print_single_arg, py_print_frame):
6650 Update.
6651 * progspace.c (print_program_space): Update.
6652 * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
6653 * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
6654 do_field_int. Change type of "value".
6655 * mi/mi-out.c (mi_ui_out::do_table_begin)
6656 (mi_ui_out::do_table_header): Update.
6657 (mi_ui_out::do_field_signed): Rename from do_field_int. Change
6658 type of "value".
6659 * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
6660 (mi_cmd_data_list_changed_registers, output_register)
6661 (mi_cmd_data_read_memory, mi_load_progress)
6662 (mi_cmd_trace_frame_collected): Update.
6663 * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
6664 Update.
6665 * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
6666 (mi_cmd_var_delete, mi_cmd_var_info_num_children)
6667 (mi_cmd_var_list_children, varobj_update_one): Update.
6668 * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
6669 (mi_cmd_stack_list_args, list_arg_or_local): Update.
6670 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
6671 * inferior.c (print_inferior): Update.
6672 * gdb_bfd.c (print_one_bfd): Update.
6673 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
6674 Update.
6675 * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
6676 * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
6677 do_field_int. Change type of "value".
6678 * cli-out.c (cli_ui_out::do_field_signed): Rename from
6679 do_field_int. Change type of "value".
6680 * breakpoint.c (watchpoint_check, print_breakpoint_location)
6681 (print_one_breakpoint_location, print_it_catch_fork)
6682 (print_one_catch_fork, print_it_catch_vfork)
6683 (print_one_catch_vfork, print_it_catch_solib)
6684 (print_it_catch_exec, print_it_ranged_breakpoint)
6685 (print_mention_watchpoint, print_mention_masked_watchpoint)
6686 (bkpt_print_it, update_static_tracepoint): Update.
6687 * break-catch-throw.c (print_it_exception_catchpoint): Update.
6688 * break-catch-syscall.c (print_it_catch_syscall): Update.
6689 * ada-tasks.c (print_ada_task_info): Update.
6690 * ada-lang.c (print_it_exception, print_mention_exception):
6691 Update.
6692
6693 2019-07-17 Andrew Burgess <andrew.burgess@embecosm.com>
6694
6695 PR breakpoints/24541
6696 * gdbarch.c: Regenerate.
6697 * gdbarch.h: Regenerate.
6698 * gdbarch.sh: Adjust return type and parameter types for
6699 'stap_adjust_register'.
6700 (i386_stap_adjust_register): Adjust signature and return new
6701 register name.
6702 * stap-probe.c (stap_parse_register_operand): Adjust use of
6703 'gdbarch_stap_adjust_register'.
6704
6705 2019-07-17 Tom Tromey <tromey@adacore.com>
6706
6707 * s390-linux-nat.c (s390_watch_area): Remove typedef. Don't
6708 declare VEC.
6709 (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
6710 std::vector.
6711 (struct s390_process_info): Add initializers.
6712 (s390_add_process): Use new.
6713 (s390_linux_nat_target::low_forget_process): Use delete.
6714 (s390_linux_nat_target::low_new_fork)
6715 (s390_linux_nat_target::stopped_by_watchpoint)
6716 (s390_linux_nat_target::low_prepare_to_resume)
6717 (s390_linux_nat_target::insert_watchpoint)
6718 (s390_linux_nat_target::insert_hw_breakpoint)
6719 (s390_linux_nat_target::remove_watchpoint)
6720 (s390_linux_nat_target::remove_hw_breakpoint): Update.
6721
6722 2019-07-16 John Baldwin <jhb@FreeBSD.org>
6723
6724 * aarch64-fbsd-nat.c: Include regcache.h.
6725 (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
6726 argument.
6727 (aarch64_fbsd_nat_target::fetch_registers)
6728 (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
6729 variable.
6730 * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
6731
6732 2019-07-16 John Baldwin <jhb@FreeBSD.org>
6733
6734 * fbsd-nat.c: Include gdbarch.h.
6735
6736 2019-07-15 Tom Tromey <tromey@adacore.com>
6737
6738 * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
6739
6740 2019-07-15 Tom Tromey <tromey@adacore.com>
6741
6742 * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
6743 * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
6744 * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
6745 * cli-out.c (cli_ui_out::do_field_int): New method.
6746 * ui-out.c (ui_out::field_unsigned): New method.
6747 * symfile.c (generic_load): Use field_unsigned.
6748 (print_transfer_performance): Likewise.
6749 * record-btrace.c (ui_out_field_uint): Remove.
6750 (btrace_call_history_insn_range, btrace_call_history): Use
6751 field_unsigned.
6752 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
6753 field_unsigned.
6754 * ui-out.h (class ui_out) <field_unsigned>: New method.
6755 <do_field_unsigned>: Likewise.
6756
6757 2019-07-15 Tom Tromey <tromey@adacore.com>
6758
6759 * mi/mi-main.c (list_available_thread_groups): Use field_string.
6760 * mi/mi-interp.c (mi_memory_changed): Use field_string.
6761 * target.c (flash_erase_command): Use field_string.
6762 * infrun.c (print_signal_received_reason): Use field_string.
6763 * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
6764 * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
6765 field_string.
6766 * ada-tasks.c (print_ada_task_info): Use field_string.
6767
6768 2019-07-15 Tom Tromey <tromey@adacore.com>
6769
6770 * target.c (flash_erase_command): Use field_core_addr.
6771 * symfile.c (generic_load): Use field_core_addr.
6772 * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
6773 Use field_core_addr.
6774 * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
6775 field_core_addr.
6776
6777 2019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
6778
6779 * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
6780 value if its desired type is smaller than a CORE_ADDR and signed.
6781
6782 2019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
6783
6784 * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
6785 of changes to field names, and use new is_reference field to
6786 decide if a property is a reference or not.
6787 * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
6788 field.
6789 (struct dwarf2_property_baton): Update header comment, rename
6790 'referenced_type' to 'property_type' and update comments.
6791 * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
6792 default property type, store in property baton, update to take
6793 accound of renamed field.
6794 (read_func_scope): Update call to attr_to_dynamic_prop.
6795 (read_array_type): Likewise.
6796 (dwarf2_per_cu_addr_sized_int_type): New function.
6797 (read_subrange_index_type): Move type finding code to
6798 dwarf2_per_cu_addr_sized_int_type.
6799 (read_subrange_type): Update calls to attr_to_dynamic_prop.
6800 (dwarf2_per_cu_addr_type): New function.
6801 (set_die_type): Update calls to attr_to_dynamic_prop.
6802
6803 2019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
6804
6805 * dwarf2read.c (read_subrange_index_type): New function.
6806 (read_subrange_type): Move code into new function and call it.
6807 * gdbtypes.c (create_range_type): Add some asserts.
6808
6809 2019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
6810
6811 * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
6812 update return statements.
6813 * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
6814 declaration, and update comment to match.
6815 * gdbtypes.c (resolve_dynamic_array): Update call to
6816 dwarf2_evaluate_property to match new return type.
6817
6818 2019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
6819
6820 * valarith.c (value_subscripted_rvalue): Change lowerbound
6821 parameter type from int to LONGEST.
6822 * value.h (value_subscripted_rvalue): Likewise in declaration.
6823
6824 2019-07-11 Andrew Burgess <andrew.burgess@embecosm.com>
6825
6826 * cli/cli-utils.c (info_print_command_completer): New function.
6827 * cli/cli-utils.h: Add 'completer.h' include, and forward
6828 declaration for 'struct cmd_list_element'.
6829 (info_print_command_completer): Declare.
6830 * stack.c (_initialize_stack): Add completer for 'info locals' and
6831 'info args'.
6832 * symtab.c (_initialize_symtab): Add completer for 'info
6833 variables' and 'info functions'.
6834 * NEWS: Mention completion for additional info commands.
6835
6836 2019-07-11 Andrew Burgess <andrew.burgess@embecosm.com>
6837
6838 * cli/cli-utils.c (extract_info_print_args): Delete.
6839 (extract_arg_maybe_quoted): Delete.
6840 (info_print_options_defs): New variable.
6841 (make_info_print_options_def_group): New function.
6842 (extract_info_print_options): Define new function.
6843 * cli/cli-utils.h (extract_info_print_args): Delete.
6844 (struct info_print_options): New structure.
6845 (extract_info_print_options): Declare new function.
6846 * stack.c (info_locals_command): Update to use new
6847 extract_info_print_options, also add a header comment.
6848 (info_args_command): Likewise.
6849 * symtab.c (info_variables_command): Likewise.
6850 (info_functions_command): Likewise.
6851
6852 2019-07-11 Andrew Burgess <andrew.burgess@embecosm.com>
6853
6854 * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
6855 to extract string arguments.
6856 * common/common-utils.c (extract_string_maybe_quoted): New function.
6857 * common/common-utils.h (extract_string_maybe_quoted): Declare.
6858
6859 2019-07-11 Tom Tromey <tromey@adacore.com>
6860
6861 * main.c (get_init_files): Use GDBINIT, not gdbinit.
6862 * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
6863 * top.h (gdbinit): Don't declare.
6864 * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
6865 into...
6866 (_initialize_cli_cmds): ...here. Use GDBINIT, not gdbinit.
6867 * top.c (gdb_init): Don't call init_cli_cmds.
6868 (gdbinit): Remove.
6869 * cli/cli-cmds.h (init_cli_cmds): Don't declare.
6870
6871 2019-07-11 Tom Tromey <tromey@adacore.com>
6872
6873 * python/py-inferior.c (add_thread_object): Don't use thread_obj
6874 after it has been moved.
6875
6876 2019-07-10 Simon Marchi <simon.marchi@polymtl.ca>
6877
6878 * valops.c (value_must_coerce_to_target): Change return type to
6879 bool.
6880 * value.h (value_must_coerce_to_target): Likewise.
6881
6882 2019-07-10 Simon Marchi <simon.marchi@efficios.com>
6883
6884 * breakpoint.c (is_hardware_watchpoint): Remove
6885 forward-declaration.
6886 (is_masked_watchpoint): Change return type to bool.
6887 (is_tracepoint): Likewise.
6888 (is_breakpoint): Likewise.
6889 (is_hardware_watchpoint): Likewise.
6890 (is_watchpoint): Likewise.
6891 (is_no_memory_software_watchpoint): Likewise.
6892 (is_catchpoint): Likewise.
6893 (breakpoint_1): Make FILTER parameter's return type bool.
6894 is_masked_watchpoint): Change return type to bool.
6895 (save_breakpoints): Make FILTER parameter's return type bool.
6896 * breakpoint.h (is_breakpoint): Change return type to bool.
6897 (is_watchpoint): Likewise.
6898 (is_catchpoint): Likewise.
6899 (is_tracepoint): Likewise.
6900
6901 2019-07-10 Tom Tromey <tom@tromey.com>
6902
6903 * defs.h: Don't include gdbarch.h.
6904 * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
6905 alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
6906 ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
6907 cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
6908 cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
6909 compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
6910 cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
6911 dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
6912 dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
6913 dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
6914 frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
6915 go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
6916 i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
6917 linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
6918 mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
6919 objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
6920 parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
6921 record-btrace.c, record.h, regcache-dump.c, regcache.h,
6922 riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
6923 sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
6924 sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
6925 sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
6926 target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
6927 tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
6928 utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
6929 xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
6930 * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
6931
6932 2019-07-10 Tom Tromey <tromey@adacore.com>
6933
6934 * ada-lang.h (is_ada_exception_catchpoint): Declare.
6935 * breakpoint.c (init_ada_exception_breakpoint): Register as
6936 bp_catchpoint.
6937 (print_one_breakpoint_location, print_one_breakpoint): Use
6938 is_ada_exception_catchpoint.
6939 * ada-lang.c (class ada_catchpoint_location): Pass
6940 bp_loc_software_breakpoint to bp_location constructor.
6941 (is_ada_exception_catchpoint): New function.
6942
6943 2019-07-10 Tom Tromey <tromey@adacore.com>
6944
6945 * arm-tdep.c (arm_exidx_entry_s): Remove typedef. Don't define
6946 VEC.
6947 (struct arm_exidx_entry): New method operator<.
6948 (struct arm_exidx_data) <section_maps>: Change type.
6949 (arm_exidx_data_free): Remove.
6950 (arm_exidx_data_key): Change type. Move lower.
6951 (arm_exidx_new_objfile): Update.
6952 (arm_compare_exidx_entries): Remove.
6953 (arm_find_exidx_entry, _initialize_arm_tdep)
6954
6955 2019-07-10 Tom Tromey <tromey@adacore.com>
6956
6957 * solib-spu.c (ocl_program_data_key): Change type.
6958 (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
6959 Update.
6960
6961 2019-07-10 Tom Tromey <tromey@adacore.com>
6962
6963 * solib-aix.c (lm_info_aix_p): Remove typedef. Don't define VEC.
6964 (struct solib_aix_inferior_data) <library_list>: Change type.
6965 (solib_aix_inferior_data_handle): Change type.
6966 (get_solib_aix_inferior_data): Update.
6967 (solib_aix_free_library_list): Remove.
6968 (library_list_start_library): Update.
6969 (solib_aix_parse_libraries, solib_aix_get_library_list): Change
6970 return type.
6971 (solib_aix_get_library_list)
6972 (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
6973 (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
6974
6975 2019-07-10 Tom Tromey <tromey@adacore.com>
6976
6977 * solib-dsbt.c (struct dsbt_info): Add initializers.
6978 (solib_dsbt_pspace_data): Change type.
6979 (dsbt_pspace_data_cleanup): Remove.
6980 (get_dsbt_info, _initialize_dsbt_solib): Update.
6981
6982 2019-07-10 Tom Tromey <tromey@adacore.com>
6983
6984 * spu-tdep.c (spu_overlay_data): Change type.
6985 (spu_get_overlay_table, spu_overlay_new_objfile)
6986 (_initialize_spu_tdep): Update.
6987
6988 2019-07-10 Tom Tromey <tromey@adacore.com>
6989
6990 * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
6991 destructor.
6992 (dbx_objfile_data_key): Change type and declare later.
6993 (DBX_SYMFILE_INFO): Rewrite.
6994 * dbxread.c (dbx_objfile_data_key): Change type.
6995 (dbx_symfile_init): Update.
6996 (~dbx_symfile_info): Rename from dbx_free_symfile_info. Update.
6997 (coffstab_build_psymtabs, elfstab_build_psymtabs)
6998 (stabsect_build_psymtabs, _initialize_dbxread): Update.
6999
7000 2019-07-10 Tom Tromey <tromey@adacore.com>
7001
7002 * jit.c (jit_program_space_key): Change type. Move lower.
7003 (get_jit_program_space_data): Update.
7004 (jit_program_space_data_cleanup): Remove.
7005 (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
7006 Update.
7007 (struct jit_program_space_data): Add initializers.
7008
7009 2019-07-10 Tom Tromey <tromey@adacore.com>
7010
7011 * solib-darwin.c (struct darwin_info): Add initializers.
7012 (solib_darwin_pspace_data): Change type.
7013 (darwin_pspace_data_cleanup): Remove.
7014 (get_darwin_info, _initialize_darwin_solib): Update.
7015
7016 2019-07-10 Tom Tromey <tromey@adacore.com>
7017
7018 * remote-sim.c (struct sim_inferior_data): Add initializers,
7019 constructor, and destructor.
7020 (sim_inferior_data_key): Change type. Move lower.
7021 (check_for_duplicate_sim_descriptor): Update.
7022 (get_sim_inferior_data): Use new. Update.
7023 (~sim_inferior_data_cleanup): Rename from
7024 sim_inferior_data_cleanup. Simplify.
7025 (gdbsim_close_inferior, simulator_command)
7026 (sim_command_completer, _initialize_remote_sim): Update.
7027 (next_pid, INITIAL_PID): Move earlier.
7028
7029 2019-07-10 Tom Tromey <tromey@adacore.com>
7030
7031 * python/python-internal.h (create_thread_object): Return
7032 gdbpy_ref.
7033 * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
7034 * python/py-inferior.c (struct threadlist_entry): Add
7035 constructor.
7036 <thread_obj>: Now a gdbpy_ref.
7037 (thread_to_thread_object): Update.
7038 (add_thread_object): Use new.
7039 (delete_thread_object): Use delete.
7040 (infpy_threads): Update.
7041 (py_free_inferior): Update. Construct "inf_obj" after acquiring
7042 GIL.
7043
7044 2019-07-10 Tom Tromey <tromey@adacore.com>
7045
7046 * valops.c (value_cast): Specialize error message for Ada.
7047
7048 2019-07-10 Simon Marchi <simon.marchi@polymtl.ca>
7049
7050 * breakpoint.c (breakpoint_1): Update doc and parameter names.
7051
7052 2019-07-10 Simon Marchi <simon.marchi@polymtl.ca>
7053
7054 * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
7055 bpstat_should_step): Return bool, adjust comments.
7056 * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
7057 bpstat_should_step): Likewise.
7058
7059 2019-07-10 Alan Hayward <alan.hayward@arm.com>
7060
7061 * features/Makefile: Use feature target descriptions for Arm.
7062 * features/arm/arm-core.c: Generate new file.
7063 * features/arm/arm-fpa.c: Likewise.
7064 * features/arm/arm-m-profile-with-fpa.xml: Likewise.
7065 * features/arm/arm-m-profile.c: Likewise.
7066 * features/arm/arm-vfpv2.c: Likewise.
7067 * features/arm/arm-vfpv3.c: Likewise.
7068 * features/arm/xscale-iwmmxt.c: Likewise.
7069 * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
7070
7071 2019-07-10 Alan Hayward <alan.hayward@arm.com>
7072
7073 * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
7074 ptrace earlier.
7075
7076 2019-07-10 Alan Hayward <alan.hayward@arm.com>
7077
7078 * features/aarch64-pauth.c: Regenerate.
7079
7080 2019-07-09 Simon Marchi <simon.marchi@polymtl.ca>
7081
7082 * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
7083 bool.
7084 (bpstat_what): Use false instead of 0.
7085
7086 2019-07-09 Pedro Alves <palves@redhat.com>
7087
7088 * break-catch-throw.c (is_exception_catchpoint): New.
7089 * breakpoint.c (print_one_breakpoint_location): New parameter
7090 'raw_loc'. Handle it. Use
7091 is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
7092 looking at the breakpoint's type.
7093 (print_one_breakpoint): If handling "maint info breakpoints", also
7094 print locations of exception catchpoints.
7095 * breakpoint.h (is_exception_catchpoint): Declare.
7096
7097 2019-07-09 Pedro Alves <palves@redhat.com>
7098
7099 * break-catch-throw.c (print_one_exception_catchpoint): Skip the
7100 "addr" field.
7101 (allocate_location_exception_catchpoint): New.
7102 (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
7103 (initialize_throw_catchpoint_ops): Install
7104 allocate_location_exception_catchpoint as allocate_location
7105 method.
7106 * breakpoint.c (bpstat_what) <bp_catch>: Set action to
7107 BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
7108 bp_loc_other.
7109 (breakpoint_address_is_meaningful): Delete.
7110 (bl_address_is_meaningful): New.
7111 (breakpoint_locations_match): Adjust comment.
7112 (bp_location_from_bp_type): New, factored out of...
7113 (bp_location::bp_location(breakpoint *)): ... this.
7114 (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
7115 factored out of...
7116 (bp_location::bp_location(breakpoint *)): ... this. Reimplement.
7117 (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
7118 breakpoint_address_is_meaningful.
7119 (bp_locations_compare): Adjust comment.
7120 (update_global_location_list): Use bl_address_is_meaningful
7121 instead of breakpoint_address_is_meaningful.
7122 * breakpoint.h (bp_location::bp_location(breakpoint *)): New
7123 explicit.
7124 (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
7125 * python/py-breakpoint.c (bppy_get_location): No longer check
7126 whether location is null.
7127
7128 2019-07-09 Pedro Alves <palves@redhat.com>
7129
7130 PR c++/15468
7131 * breakpoint.c (print_one_breakpoint_location): Remove
7132 single-location assert.
7133
7134 2019-07-09 Tom Tromey <tom@tromey.com>
7135
7136 * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
7137 * configure: Rebuild.
7138 * configure.ac: Change common to gdbsupport.
7139 * gdbsupport: Rename from common.
7140 * acinclude.m4: Change common to gdbsupport.
7141 * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
7142 (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
7143 gdbsupport.
7144 * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
7145 amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
7146 amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
7147 amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
7148 amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
7149 arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
7150 arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
7151 arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
7152 arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
7153 auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
7154 btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
7155 charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
7156 cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
7157 coff-pe-read.c, command.h, compile/compile-c-support.c,
7158 compile/compile-c.h, compile/compile-cplus-symbols.c,
7159 compile/compile-cplus-types.c, compile/compile-cplus.h,
7160 compile/compile-loc2c.c, compile/compile.c, completer.c,
7161 completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
7162 cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
7163 darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
7164 disasm.h, dtrace-probe.c, dwarf-index-cache.c,
7165 dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
7166 dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
7167 event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
7168 features/aarch64-core.c, features/aarch64-fpu.c,
7169 features/aarch64-pauth.c, features/aarch64-sve.c,
7170 features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
7171 features/i386/32bit-core.c, features/i386/32bit-linux.c,
7172 features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
7173 features/i386/32bit-segments.c, features/i386/32bit-sse.c,
7174 features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
7175 features/i386/64bit-core.c, features/i386/64bit-linux.c,
7176 features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
7177 features/i386/64bit-segments.c, features/i386/64bit-sse.c,
7178 features/i386/x32-core.c, features/riscv/32bit-cpu.c,
7179 features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
7180 features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
7181 features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
7182 features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
7183 findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
7184 gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
7185 gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
7186 go32-nat.c, guile/guile.c, guile/scm-ports.c,
7187 guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
7188 i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
7189 i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
7190 ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
7191 inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
7192 inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
7193 inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
7194 linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
7195 macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
7196 mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
7197 mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
7198 minsyms.c, mips-linux-tdep.c, namespace.h,
7199 nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
7200 nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
7201 nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
7202 nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
7203 nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
7204 nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
7205 nat/linux-waitpid.c, nat/mips-linux-watch.c,
7206 nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
7207 nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
7208 nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
7209 obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
7210 parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
7211 procfs.c, producer.c, progspace.h, psymtab.h,
7212 python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
7213 python/py-type.c, python/python.c, record-btrace.c, record-full.c,
7214 record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
7215 remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
7216 riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
7217 selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
7218 ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
7219 source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
7220 stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
7221 symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
7222 target-memory.c, target.c, target.h, target/waitstatus.c,
7223 target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
7224 top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
7225 tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
7226 unittests/array-view-selftests.c,
7227 unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
7228 unittests/common-utils-selftests.c,
7229 unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
7230 unittests/format_pieces-selftests.c,
7231 unittests/function-view-selftests.c,
7232 unittests/lookup_name_info-selftests.c,
7233 unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
7234 unittests/mkdir-recursive-selftests.c,
7235 unittests/observable-selftests.c,
7236 unittests/offset-type-selftests.c, unittests/optional-selftests.c,
7237 unittests/parse-connection-spec-selftests.c,
7238 unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
7239 unittests/scoped_fd-selftests.c,
7240 unittests/scoped_mmap-selftests.c,
7241 unittests/scoped_restore-selftests.c,
7242 unittests/string_view-selftests.c, unittests/style-selftests.c,
7243 unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
7244 unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
7245 utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
7246 value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
7247 xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
7248 xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
7249
7250 2019-07-09 Andrew Burgess <andrew.burgess@embecosm.com>
7251
7252 * linespec.c (decode_digits_list_mode): Set explicit_line to a
7253 bool value.
7254 (decode_digits_ordinary): Set explicit_line field in sal.
7255 * symtab.c (skip_prologue_sal): Don't skip prologue for a
7256 symtab_and_line that was set on an explicit line number in
7257 assembler code. Do always update the recorded symtab and line if
7258 we do skip the prologue.
7259
7260 2019-07-09 Andrew Burgess <andrew.burgess@embecosm.com>
7261
7262 * breakpoint.c (set_breakpoint_location_function): Remove
7263 explicit_loc parameter.
7264 (momentary_breakpoint_from_master): Update call to
7265 set_breakpoint_location_function.
7266 (add_location_to_breakpoint): Likewise.
7267
7268 2019-07-09 Andrew Burgess <andrew.burgess@embecosm.com>
7269
7270 * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
7271 required features based on default bfd type when no specific bfd
7272 is present.
7273
7274 2019-07-08 Philippe Waroquiers <philippe.waroquiers@skynet.be>
7275
7276 * NEWS: Mention that GDB printf and eval commands can now print
7277 C-style and Ada-style convenience var strings without
7278 calling the inferior.
7279 * printcmd.c (printf_c_string): Locally print GDB internal var
7280 instead of transiting via the inferior.
7281 (printf_wide_c_string): Likewise.
7282
7283 2019-07-04 Alan Hayward <alan.hayward@arm.com>
7284
7285 PR breakpoints/25011
7286 * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
7287
7288 2019-07-04 Tom Tromey <tom@tromey.com>
7289
7290 PR tui/24724:
7291 * tui/tui-winsource.c (tui_clear_source_content): Update.
7292 (tui_source_window_base::set_is_exec_point_at): Fix comment.
7293 (tui_update_breakpoint_info): Update.
7294 (tui_set_exec_info_content): Update.
7295 * tui/tui-source.c (tui_set_source_content_nil): Update.
7296 * tui/tui-disasm.c (tui_set_disassem_content): Don't set
7297 has_break.
7298 * tui/tui-data.h (enum tui_bp_flag): New.
7299 (tui_bp_flags): New enum flags type.
7300 (struct tui_source_element) <break_mode>: Change type. Rename
7301 from has_break.
7302 (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
7303 (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define. Now enum
7304 constants.
7305 * tui/tui-winsource.h: Fix comment.
7306
7307 2019-07-04 Alan Hayward <alan.hayward@arm.com>
7308
7309 * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
7310 * aarch64-linux-nat.c (fetch_fpregs_from_thread)
7311 (store_fpregs_to_thread)
7312 (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
7313 * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
7314 (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
7315 (IWMMXT_REGS_SIZE): Add define.
7316 * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
7317 (fetch_vfp_regs, store_vfp_regs)
7318 (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
7319 * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
7320
7321 2019-07-04 Alan Hayward <alan.hayward@arm.com>
7322
7323 * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
7324 defines.
7325 * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
7326 * arch/arm.h (INT_REGISTER_SIZE) Rename from...
7327 (ARM_INT_REGISTER_SIZE): ...to this.
7328 (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
7329 * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
7330 (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
7331 (arm_linux_collect_gregset, supply_nwfpe_register)
7332 (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
7333 defines.
7334 * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
7335 (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
7336 * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
7337 * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
7338 (arm_return_in_memory, arm_store_return_value)
7339 (arm_get_longjmp_target, arm_register_g_packet_guesses)
7340 (arm_record_ld_st_multiple): Likewise.
7341 * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
7342 * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
7343
7344 2019-07-04 Alan Hayward <alan.hayward@arm.com>
7345
7346 * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
7347 AARCH64_DISPLACED_MODIFIED_INSNS.
7348 * aarch64-tdep.c (struct aarch64_displaced_step_data)
7349 (aarch64_displaced_step_copy_insn): Likewise.
7350 * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
7351 (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
7352 * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
7353 ARM_DISPLACED_MODIFIED_INSNS.
7354 * arm-tdep.c (arm_gdbarch_init): Likewise.
7355 * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
7356 (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
7357 (struct arm_displaced_step_closure): Use
7358 ARM_DISPLACED_MODIFIED_INSNS.
7359
7360 2019-07-04 Alan Hayward <alan.hayward@arm.com>
7361
7362 * features/Makefile: Remove unused xml files.
7363 * features/aarch64.xml: Remove.
7364 * features/i386/amd64-avx-avx512-linux.xml: Remove.
7365 * features/i386/amd64-avx-avx512.xml: Remove.
7366 * features/i386/amd64-avx-linux.xml: Remove.
7367 * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
7368 * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
7369 * features/i386/amd64-avx-mpx-linux.xml: Remove.
7370 * features/i386/amd64-avx-mpx.xml: Remove.
7371 * features/i386/amd64-avx.xml: Remove.
7372 * features/i386/amd64-linux.xml: Remove.
7373 * features/i386/amd64-mpx-linux.xml: Remove.
7374 * features/i386/amd64-mpx.xml: Remove.
7375 * features/i386/amd64.xml: Remove.
7376 * features/i386/i386-avx-avx512-linux.xml: Remove.
7377 * features/i386/i386-avx-avx512.xml: Remove.
7378 * features/i386/i386-avx-linux.xml: Remove.
7379 * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
7380 * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
7381 * features/i386/i386-avx-mpx-linux.xml: Remove.
7382 * features/i386/i386-avx-mpx.xml: Remove.
7383 * features/i386/i386-avx.xml: Remove.
7384 * features/i386/i386-linux.xml: Remove.
7385 * features/i386/i386-mmx-linux.xml: Remove.
7386 * features/i386/i386-mmx.xml: Remove.
7387 * features/i386/i386-mpx-linux.xml: Remove.
7388 * features/i386/i386-mpx.xml: Remove.
7389 * features/i386/i386.xml: Remove.
7390 * features/i386/x32-avx-avx512-linux.xml: Remove.
7391 * features/i386/x32-avx-linux.xml: Remove.
7392 * features/i386/x32-linux.xml: Remove.
7393
7394 2019-07-04 Alan Hayward <alan.hayward@arm.com>
7395
7396 * regformats/aarch64.dat: Remove.
7397 * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
7398 * regformats/i386/amd64-avx-linux.dat: Remove.
7399 * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
7400 * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
7401 * regformats/i386/amd64-linux.dat: Remove.
7402 * regformats/i386/amd64-mpx-linux.dat: Remove.
7403 * regformats/i386/amd64.dat: Remove.
7404 * regformats/i386/i386-avx-avx512-linux.dat: Remove.
7405 * regformats/i386/i386-avx-linux.dat: Remove.
7406 * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
7407 * regformats/i386/i386-avx-mpx-linux.dat: Remove.
7408 * regformats/i386/i386-linux.dat: Remove.
7409 * regformats/i386/i386-mmx-linux.dat: Remove.
7410 * regformats/i386/i386-mpx-linux.dat: Remove.
7411 * regformats/i386/i386.dat: Remove.
7412 * regformats/i386/x32-avx-avx512-linux.dat: Remove.
7413 * regformats/i386/x32-avx-linux.dat: Remove.
7414 * regformats/i386/x32-linux.dat: Remove.
7415
7416 2019-07-04 Alan Hayward <alan.hayward@arm.com>
7417
7418 * aarch64-tdep.c: Remove xml self tests.
7419 * amd64-linux-tdep.c: Likewise.
7420 * amd64-tdep.c: Likewise.
7421 * i386-linux-tdep.c: Likewise.
7422 * i386-tdep.c: Likewise.
7423
7424 2019-07-03 Pedro Alves <palves@redhat.com>
7425
7426 PR cli/24732
7427 * cli/cli-cmds.c (struct pipe_cmd_opts): New.
7428 (pipe_cmd_option_defs): New.
7429 (make_pipe_cmd_options_def_group): New.
7430 (pipe_command): Use gdb::option::process_options.
7431 (pipe_command_completer): New function.
7432 (_initialize_cli_cmds): Install completer for "pipe" command.
7433
7434 2019-07-03 Pedro Alves <palves@redhat.com>
7435
7436 * cli/cli-option.c (union option_value) <string>: New field.
7437 (struct option_def_and_value): Add ctor, move ctor, dtor and
7438 use DISABLE_COPY_AND_ASSIGN.
7439 (option_def_and_value::clear_value): New.
7440 (parse_option, save_option_value_in_ctx, get_val_type_str)
7441 (add_setshow_cmds_for_options): Handle var_string.
7442 * cli-option.h (union option_def::var_address) <string>: New
7443 field.
7444 (struct string_option_def): New.
7445 * maint-test-options.c (struct test_options_opts): Add default
7446 ctor and use DISABLE_COPY_AND_ASSIGN.
7447 <string_opt>: New field.
7448 (test_options_opts::~test_options_opts): New.
7449 (test_options_opts::dump): Also dump "-string".
7450 (test_options_option_defs): Install "string.
7451
7452 2019-07-03 Pedro Alves <palves@redhat.com>
7453
7454 * cli/cli-option.c (parse_option) <var_enum>: Don't return an
7455 option_value with a null enumeration.
7456 (complete_options): Save the option values in the context.
7457 (save_option_value_in_ctx): New, factored out from ...
7458 (process_options): ... here.
7459 * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
7460 of the function.
7461 * maint-test-options.c (test_options_opts::dump): New, factored
7462 out from ...
7463 (maintenance_test_options_command_mode): ... here.
7464 (maintenance_test_options_command_completion_result): Delete.
7465 (maintenance_test_options_command_completion_text): Update
7466 comment.
7467 (maintenance_show_test_options_completion_result): Change
7468 prototype. Just print
7469 maintenance_test_options_command_completion_text.
7470 (save_completion_result): New.
7471 (maintenance_test_options_completer_mode): Pass options context to
7472 complete_options, and then save a dump.
7473 (_initialize_maint_test_options): Use add_cmd to install "maint
7474 show test-options-completion-result".
7475
7476 2019-07-03 Pedro Alves <palves@redhat.com>
7477
7478 * NEWS (New commands): Mention "with" and "maint with".
7479 * cli/cli-cmds.c (with_command_1, with_command_completer_1)
7480 (with_command, with_command_completer): New.
7481 (pipe_command): Adjust to new repeat_previous
7482 interface.
7483 (_initialize_cli_cmds): Install the "with" command and its "w"
7484 alias.
7485 * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
7486 declarations.
7487 * cli/cli-setshow.c (parse_cli_var_uinteger)
7488 (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
7489 argument strings for all var_types.
7490 (get_setshow_command_value_string): New, factored out from ...
7491 (do_show_command): ... this.
7492 * cli/cli-setshow.h: Include <string>.
7493 (get_setshow_command_value_string): Declare.
7494 * command.h (repeat_previous): Now returns const char *. Adjust
7495 comment.
7496 * maint.c: Include "cli/cli-cmds.h".
7497 (maintenance_with_cmd, maintenance_with_cmd_completer): New.
7498 (_initialize_maint_cmds): Register the "maintenance with" command.
7499 * top.c (repeat_previous): Move bits from pipe_command here:
7500 Return the saved command line, if any; error out if there's no
7501 command to relaunch.
7502
7503 2019-07-03 Pedro Alves <palves@redhat.com>
7504
7505 * NEWS (New commands): Mention "maint set/show test-settings"
7506 instead of "maint test-settings".
7507 * maint-test-settings.c (maintenance_test_settings_list): Delete.
7508 (maintenance_test_settings_set_list): Rename to ...
7509 (maintenance_set_test_settings_list): ... this.
7510 (maintenance_test_settings_show_list): Rename to ...
7511 (maintenance_show_test_settings_list): ... this.
7512 (maintenance_test_settings_cmd): Delete.
7513 (maintenance_test_settings_set_cmd): ...
7514 (maintenance_set_test_settings_cmd): ... this.
7515 (maintenance_test_settings_show_cmd): ...
7516 (maintenance_show_test_settings_cmd): ... this.
7517 (maintenance_test_settings_show_value_cmd):
7518 (maintenance_show_test_settings_value_cmd): ... this.
7519 (_initialize_maint_test_settings): No longer install the "maint
7520 test-settings" prefix command. Rename "maint test-settings set"
7521 to "maint set test-settings", and "maint test-settings show" to
7522 "maint show test-settings". Adjust all subcommands.
7523
7524 2019-07-03 Pedro Alves <palves@redhat.com>
7525
7526 * maint-test-settings.c: Fix file's intro comment. Replace all
7527 references to "test-options" with references to "test-settings",
7528 in comments.
7529
7530 2019-07-03 Pedro Alves <palves@redhat.com>
7531
7532 * maint-test-settings.c (maintenance_test_settings_xxx)
7533 (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
7534 New.
7535 (maintenance_test_settings_enums): Use them.
7536 (maintenance_test_settings_enum): Default to
7537 maintenance_test_settings_xxx.
7538 (_initialize_maint_test_settings): Initialize
7539 MAINTENANCE_TEST_SETTINGS_FILENAME.
7540
7541 2019-07-02 Simon Marchi <simon.marchi@polymtl.ca>
7542
7543 * breakpoint.h (remove_breakpoints_inf): Change return type to
7544 void, move function documentation here.
7545 * breakpoint.c (remove_breakpoints_inf): Change return type to
7546 void, move function documentation to header.
7547
7548 2019-07-02 Pedro Alves <palves@redhat.com>
7549
7550 * NEWS (Completion improvements): Mention "info threads".
7551 * thread.c (struct info_threads_opts, info_threads_option_defs)
7552 (make_info_threads_options_def_group): New.
7553 (info_threads_command): Use gdb::option::process_options.
7554 (info_threads_command_completer): New.
7555 (_initialize_thread): Use gdb::option::build_help to build the
7556 help text for "info threads".
7557
7558 2019-07-02 Simon Marchi <simon.marchi@polymtl.ca>
7559
7560 * defs.h (generic_load): Move from here...
7561 * symfile.h (generic_load): ... to here. Rename name parameter
7562 to args.
7563 * symfile.c (generic_load): Add comment.
7564
7565 2019-07-01 Tom Tromey <tromey@adacore.com>
7566
7567 * dwarf2read.c
7568 (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
7569 declaration of without_params. Fix formatting.
7570
7571 2019-07-01 Tom Tromey <tromey@adacore.com>
7572
7573 * ada-exp.y (find_primitive_type): Update.
7574 * ada-lang.h (ada_lookup_symbol): Update.
7575 * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
7576 parameter.
7577 (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
7578
7579 2019-06-28 Sergio Durigan Junior <sergiodj@redhat.com>
7580
7581 PR breakpoints/24541
7582 * gdbarch.c: Regenerate.
7583 * gdbarch.h: Regenerate.
7584 * gdbarch.sh: Add 'stap_adjust_register'.
7585 * i386-tdep.c: Include '<unordered_set>'.
7586 (i386_stap_adjust_register): New function.
7587 (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
7588 * stap-probe.c (stap_parse_register_operand): Call
7589 'gdbarch_stap_adjust_register'.
7590
7591 2019-06-28 Sergio Durigan Junior <sergiodj@redhat.com>
7592
7593 PR python/24742
7594 https://bugzilla.redhat.com/show_bug.cgi?id=1723564
7595 * python/python.c (do_start_initialization): Use 'xmalloc'
7596 instead of 'PyMem_Malloc'.
7597
7598 2019-06-28 Tom Tromey <tromey@adacore.com>
7599
7600 * dwarf2read.c (partial_die_info::read): Prefer the linkage name
7601 for Ada.
7602
7603 2019-06-27 Tom Tromey <tromey@adacore.com>
7604
7605 * arm-tdep.c (arm_objfile_data_key): Move lower. Change type to
7606 objfile_key.
7607 (arm_find_mapping_symbol, arm_record_special_symbol)
7608 (_initialize_arm_tdep): Update.
7609 (arm_objfile_data_free): Remove.
7610
7611 2019-06-27 Tom Tromey <tromey@adacore.com>
7612
7613 * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
7614 to cp_print_static_field.
7615
7616 2019-06-26 Tom Tromey <tromey@adacore.com>
7617
7618 * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
7619 * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
7620 declare.
7621
7622 2019-06-26 Alan Hayward <alan.hayward@arm.com>
7623
7624 * features/aarch64-core.c (create_feature_aarch64_core):
7625 Regenerate.
7626 * features/aarch64-core.xml: Add cpsr flags.
7627
7628 2019-06-26 Alan Hayward <alan.hayward@arm.com>
7629
7630 * arm-tdep.c (arm_gnu_triplet_regexp): New function.
7631 (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
7632
7633 2019-06-25 Simon Marchi <simon.marchi@polymtl.ca>
7634
7635 * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
7636 field.
7637 (arm_find_mapping_symbol): Sort mapping symbol vectors on first
7638 use.
7639 (arm_record_special_symbol): Don't insert new symbol in sorted
7640 position, push it at the end.
7641
7642 2019-06-25 Simon Marchi <simon.marchi@polymtl.ca>
7643
7644 * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
7645 (arm_mapping_symbol_s): Remove.
7646 (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
7647 (arm_mapping_symbol_vec): New typedef.
7648 (struct arm_per_objfile): Add constructor.
7649 <section_maps>: Change type to
7650 std::unique_ptr<arm_mapping_symbol_vec[]>.
7651 (arm_compare_mapping_symbols): Remove.
7652 (arm_find_mapping_symbol): Adjust to section_maps type change.
7653 (arm_objfile_data_free): Call delete on arm_per_objfile.
7654 (arm_record_special_symbol): Adjust to section_maps type change.
7655 Allocate arm_per_objfile with new.
7656
7657 2019-06-25 Philippe Waroquiers <philippe.waroquiers@skynet.be>
7658
7659 * cli/cli-cmds.c (alias_command): Compare the alias prefix
7660 with the command prefix.
7661
7662 2019-06-25 Tom Tromey <tom@tromey.com>
7663
7664 * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
7665 * tui/tui-data.c (~tui_gen_win_info): Remove "if".
7666
7667 2019-06-25 Tom Tromey <tom@tromey.com>
7668
7669 * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
7670 type.
7671 * tui/tui-data.h (struct tui_gen_win_info): Make constructor
7672 protected.
7673
7674 2019-06-25 Tom Tromey <tom@tromey.com>
7675
7676 * tui/tui-winsource.c
7677 (tui_source_window_base::set_is_exec_point_at): Add check against
7678 LOA_ADDRESS.
7679
7680 2019-06-25 Tom Tromey <tom@tromey.com>
7681
7682 * tui/tui-source.c (tui_set_source_content): Don't check before
7683 xfree.
7684 * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
7685
7686 2019-06-25 Tom Tromey <tom@tromey.com>
7687
7688 * tui/tui-winsource.h (tui_update_source_window_as_is)
7689 (tui_alloc_source_buffer, tui_line_is_displayed)
7690 (tui_addr_is_displayed): Change type of win_info.
7691 * tui/tui-winsource.c (tui_update_source_window_as_is)
7692 (tui_clear_source_content, tui_show_source_line)
7693 (tui_show_source_content, tui_source_window_base::refill)
7694 (tui_source_window_base::set_is_exec_point_at)
7695 (tui_source_window_base::set_is_exec_point_at)
7696 (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
7697 (tui_alloc_source_buffer, tui_line_is_displayed)
7698 (tui_addr_is_displayed): Change type of win_info. Update.
7699 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
7700 (tui_source_window_base::do_make_visible_with_new_height):
7701 Update.
7702 * tui/tui-source.c (tui_set_source_content)
7703 (tui_set_source_content_nil)
7704 (tui_source_window::do_scroll_vertical): Update.
7705 * tui/tui-layout.c (show_layout): Update.
7706 * tui/tui-disasm.c (tui_set_disassem_content)
7707 (tui_disasm_window::do_scroll_vertical): Update.
7708 * tui/tui-data.h (tui_win_content): Remove.
7709 (struct tui_gen_win_info) <content, content_size>: Remove.
7710 (struct tui_source_element): Add initializers and destructor.
7711 (union tui_which_element, struct tui_win_element): Remove.
7712 (struct tui_source_window_base) <content>: New field.
7713 (struct tui_data_window): Remove destructor.
7714 (tui_alloc_content, tui_free_win_content)
7715 (tui_free_all_source_wins_content): Don't declare.
7716 * tui/tui-data.c (tui_initialize_static_data): Update.
7717 (init_content_element, tui_alloc_content): Remove.
7718 (~tui_gen_win_info): Update.
7719 (~tui_data_window, tui_free_all_source_wins_content)
7720 (tui_free_win_content, free_content, free_content_elements):
7721 Remove.
7722
7723 2019-06-25 Tom Tromey <tom@tromey.com>
7724
7725 * tui/tui-winsource.h (tui_clear_source_content)
7726 (tui_erase_source_content, tui_show_source_content): Change type
7727 of win_info.
7728 * tui/tui-winsource.c (tui_clear_source_content)
7729 (tui_erase_source_content, tui_show_source_content): Change type
7730 of win_info.
7731 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
7732 * tui/tui-source.h (tui_set_source_content_nil): Change type of
7733 win_info.
7734 * tui/tui-source.c (tui_set_source_content_nil): Change type of
7735 win_info.
7736 * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
7737
7738 2019-06-25 Tom Tromey <tom@tromey.com>
7739
7740 * tui/tui-winsource.c (tui_clear_source_content)
7741 (tui_source_window_base::set_is_exec_point_at): Update.
7742 * tui/tui-source.c (tui_set_source_content_nil): Update.
7743 * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
7744 a bool.
7745 * tui/tui-data.c (init_content_element): Update.
7746
7747 2019-06-25 Tom Tromey <tom@tromey.com>
7748
7749 * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
7750 * tui/tui-win.c (make_invisible_and_set_new_height): Update.
7751 * tui/tui-layout.c (init_and_make_win): Update.
7752 * tui/tui.h (enum tui_win_type): Update.
7753 * tui/tui-data.h (tui_win_is_auxiliary): Rename from
7754 tui_win_is_auxillary.
7755 * tui/tui-data.c (tui_win_is_auxiliary): Rename from
7756 tui_win_is_auxillary.
7757
7758 2019-06-25 Tom Tromey <tom@tromey.com>
7759
7760 * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
7761 * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
7762 (tui_delete_data_content_windows, tui_display_all_data)
7763 (tui_data_window::do_scroll_vertical, tui_display_data_from):
7764 Update.
7765 * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
7766 * tui/tui-regs.c (tui_last_regs_line_no)
7767 (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
7768 (tui_show_registers): Update.
7769 (tui_show_register_group): Return void. Update.
7770 (tui_display_registers_from, tui_display_reg_element_at_line)
7771 (tui_display_registers_from_line, tui_check_register_values):
7772 Update.
7773 * tui/tui-data.h (union tui_which_element) <data_window>: Remove
7774 member.
7775 (struct tui_data_window) <regs_content>: Now a std::vector.
7776 <regs_content_count>: Remove.
7777 (tui_add_content_elements, tui_free_data_content): Don't declare.
7778 * tui/tui-data.c (tui_data_window::clear_detail): Update.
7779 (init_content_element): Remove DATA_WIN case. Add assert.
7780 (tui_add_content_elements): Remove.
7781 (tui_data_window): Update.
7782 (tui_free_data_content): Remove.
7783 (free_content_elements): Remove DATA_WIN case.
7784
7785 2019-06-25 Tom Tromey <tom@tromey.com>
7786
7787 * tui/tui-data.c (tui_data_item_window): Update.
7788 * tui/tui-windata.h (tui_check_data_values): Don't declare.
7789 * tui/tui-windata.c (tui_display_all_data)
7790 (tui_display_data_from_line): Update.
7791 (tui_check_data_values): Remove.
7792 * tui/tui-regs.c (tui_show_register_group)
7793 (tui_display_reg_element_at_line): Update.
7794 * tui/tui-hooks.c (tui_register_changed)
7795 (tui_refresh_frame_and_register_information): Call
7796 tui_check_register_values.
7797 * tui/tui-data.h (struct tui_data_window) <data_content,
7798 data_content_count, data_type>: Remove.
7799 (enum tui_data_type): Remove.
7800
7801 * tui/tui-data.c (tui_data_window::clear_detail)
7802 (~tui_data_window): Update.
7803
7804 2019-06-25 Tom Tromey <tom@tromey.com>
7805
7806 * tui/tui-windata.h (tui_first_data_item_displayed): Don't
7807 declare.
7808 * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
7809 Rename from tui_first_data_item_displayed. Update.
7810 (tui_data_window::refresh_all)
7811 (tui_data_window::do_scroll_vertical): Update.
7812 * tui/tui-data.h (struct tui_data_window)
7813 <first_data_item_displayed>: Declare new method.
7814
7815 2019-06-25 Tom Tromey <tom@tromey.com>
7816
7817 * tui/tui-data.h (tui_init_generic_part): Don't declare.
7818 * tui/tui-data.c (tui_init_generic_part): Remove, moving
7819 contents...
7820 (tui_initialize_static_data): ...here.
7821
7822 2019-06-25 Tom Tromey <tom@tromey.com>
7823
7824 * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
7825 (tui_display_registers_from, tui_check_register_values): Update.
7826 (tui_display_register): Remove win_info parameter; update.
7827 (tui_get_register): Change type of parameters.
7828 * tui/tui-data.h (struct tui_data_element): Remove.
7829 (union tui_which_element) <data>: Remove.
7830 <data_window>: Change type.
7831 (struct tui_data_item_window): New.
7832 * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
7833 case. Add assert.
7834 (~tui_data_item_window): New destructor.
7835 (free_content_elements): Remove DATA_ITEM_WIN case.
7836
7837 2019-06-25 Tom Tromey <tom@tromey.com>
7838
7839 * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
7840 Remove.
7841
7842 2019-06-25 Tom Tromey <tom@tromey.com>
7843
7844 * tui/tui-data.h (struct tui_command_element): Remove.
7845 (union tui_which_element) <command>: Remove.
7846 * tui/tui-data.c (init_content_element): Remove CMD_WIN case. Add
7847 assert.
7848 (free_content_elements): Remove CMD_WIN case.
7849
7850 2019-06-25 Tom Tromey <tom@tromey.com>
7851
7852 * tui/tui-layout.c (tui_set_layout): Update.
7853 * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
7854 * tui/tui-data.c (layout_def): Update.
7855
7856 2019-06-25 Tom Tromey <tom@tromey.com>
7857
7858 * tui/tui-wingeneral.c (tui_refresh_all): Update.
7859 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
7860 (tui_source_window_base::set_new_height): Update.
7861 * tui/tui-stack.c (tui_make_status_line): Change parameter type.
7862 Update.
7863 (tui_set_locator_fullname, tui_set_locator_info)
7864 (tui_show_frame_info): Update.
7865 * tui/tui-source.c (tui_set_source_content)
7866 (tui_source_is_displayed): Update.
7867 * tui/tui-layout.c (show_source_disasm_command, show_data)
7868 (show_source_or_disasm_and_command): Update.
7869 * tui/tui-disasm.c (tui_set_disassem_content)
7870 (tui_get_begin_asm_address): Update.
7871 * tui/tui-data.h (struct tui_locator_element): Remove.
7872 (union tui_which_element) <locator>: Remove.
7873 (struct tui_locator_window): New.
7874 (tui_locator_win_info_ptr): Change return type.
7875 * tui/tui-data.c (_locator): Change type.
7876 (tui_locator_win_info_ptr): Change return type.
7877 (init_content_element): Remove LOCATOR_WIN case. Add assert.
7878 (tui_alloc_content): Add assert.
7879
7880 2019-06-25 Tom Tromey <tom@tromey.com>
7881
7882 * tui/tui-winsource.c
7883 (tui_exec_info_window::maybe_allocate_content): New method.
7884 (tui_set_exec_info_content, tui_show_exec_info_content): Update.
7885 * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
7886 (make_source_or_disasm_window): Add cast.
7887 * tui/tui-data.h (union tui_which_element) <simple_string>:
7888 Remove.
7889 (struct tui_source_info): New.
7890 (struct tui_source_window_base) <execution_info>: Change type.
7891 * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
7892 case, and add assert.
7893 (tui_alloc_content): Add assert.
7894
7895 2019-06-25 Tom Tromey <tom@tromey.com>
7896
7897 * tui/tui-data.h (tui_alloc_win_info): Don't declare.
7898 * tui/tui-layout.c (init_and_make_win): Use "new" directly.
7899 * tui/tui-data.c (tui_alloc_win_info): Remove.
7900
7901 2019-06-25 Tom Tromey <tom@tromey.com>
7902
7903 * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
7904 * tui/tui-wingeneral.c (tui_unhighlight_win): Check
7905 can_highlight.
7906
7907 2019-06-25 Tom Tromey <tom@tromey.com>
7908
7909 * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
7910 make_visible_with_new_height method.
7911 (tui_win_info::make_visible_with_new_height): New method.
7912 (tui_source_window_base::do_make_visible_with_new_height)
7913 (tui_data_window::do_make_visible_with_new_height)
7914 (tui_cmd_window::do_make_visible_with_new_height): New methods.
7915 (make_visible_with_new_height): Remove.
7916 (tui_resize_all, tui_adjust_win_heights): Use
7917 make_visible_with_new_height method.
7918 * tui/tui-data.h (struct tui_win_info)
7919 <do_make_visible_with_new_height, make_visible_with_new_height>:
7920 New methods.
7921 (struct tui_source_window_base, struct tui_data_window)
7922 (struct tui_cmd_window) <do_make_visible_with_new_height>: New
7923 methods.
7924
7925 2019-06-25 Tom Tromey <tom@tromey.com>
7926
7927 * tui/tui-win.c (tui_source_window_base::update_tab_width): New
7928 method.
7929 (update_tab_width): Call update_tab_width method.
7930 * tui/tui-data.h (struct tui_win_info)
7931 (struct tui_source_window_base) <update_tab_width>: New methods.
7932
7933 2019-06-25 Tom Tromey <tom@tromey.com>
7934
7935 * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
7936 parameter.
7937 * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
7938 parameter.
7939 (tui_gen_win_info::make_visible): Update.
7940 * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
7941 parameter.
7942 * tui/tui-data.h (enum tui_box): New enum.
7943 (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
7944
7945 2019-06-25 Tom Tromey <tom@tromey.com>
7946
7947 * tui/tui-layout.c (make_source_or_disasm_window): Always use
7948 init_and_make_win for EXEC_INFO_WIN.
7949 * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
7950 longer inline.
7951 (struct tui_win_info) <~tui_win_info>: Inline.
7952 (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
7953 Don't declare.
7954 * tui/tui-data.c (source_win, disasm_win): Remove globals.
7955 (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
7956 Remove.
7957 (tui_initialize_static_data): Update.
7958 (~tui_gen_win_info): Handle more cleanup here.
7959 (~tui_source_window_base): Delete "execution_info".
7960 (~tui_win_info): Move code to ~tui_gen_win_info; remove.
7961
7962 2019-06-25 Tom Tromey <tom@tromey.com>
7963
7964 * tui/tui-layout.c (make_command_window): Don't set
7965 can_highlight.
7966 (show_source_disasm_command): Call the reset method.
7967 (show_data): Don't set can_highlight. Call the reset method.
7968 (tui_gen_win_info::reset): Rename from init_gen_win_info
7969 (init_and_make_win): Simplify. Return tui_gen_win_info.
7970 (show_source_or_disasm_and_command): Call the reset method.
7971 * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
7972 (struct tui_cmd_window): Set can_highlight.
7973
7974 2019-06-25 Tom Tromey <tom@tromey.com>
7975
7976 * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
7977 from make_visible.
7978 (tui_make_visible, tui_make_invisible): Rewrite.
7979 (tui_win_info::make_visible): Remove.
7980 (tui_source_window_base::make_visible): Update.
7981 * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
7982 method. Moved from...
7983 (struct tui_win_info) <make_visible>: ...here.
7984
7985 2019-06-25 Tom Tromey <tom@tromey.com>
7986
7987 * tui/tui-winsource.c
7988 (tui_source_window_base::do_scroll_horizontal): Remove direction
7989 parameter.
7990 * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
7991 direction parameter.
7992 * tui/tui-win.c (tui_win_info::forward_scroll)
7993 (tui_win_info::backward_scroll, tui_win_info::left_scroll)
7994 (tui_win_info::right_scroll): Update.
7995 * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
7996 direction parameter.
7997 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
7998 direction parameter.
7999 * tui/tui-data.h (enum tui_scroll_direction): Remove.
8000 (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
8001 Remove direction parameter.
8002 (struct tui_source_window_base, struct tui_source_window)
8003 (struct tui_disasm_window, struct tui_data_window)
8004 (struct tui_cmd_window): Update.
8005
8006 2019-06-25 Tom Tromey <tom@tromey.com>
8007
8008 * tui/tui-winsource.h (tui_set_exec_info_content)
8009 (tui_show_exec_info_content, tui_erase_exec_info_content)
8010 (tui_clear_exec_info_content, tui_update_exec_info): Change
8011 argument to tui_source_window_base.
8012 * tui/tui-winsource.c (tui_set_exec_info_content)
8013 (tui_show_exec_info_content, tui_erase_exec_info_content)
8014 (tui_clear_exec_info_content, tui_update_exec_info): Change
8015 argument to tui_source_window_base.
8016
8017 2019-06-25 Tom Tromey <tom@tromey.com>
8018
8019 * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
8020 * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
8021
8022 2019-06-25 Tom Tromey <tom@tromey.com>
8023
8024 * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
8025 check.
8026
8027 2019-06-25 Tom Tromey <tom@tromey.com>
8028
8029 * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
8030 type to void.
8031 * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
8032 type to void.
8033 * tui/tui-source.c (tui_set_source_content): Update.
8034 * tui/tui-disasm.c (tui_set_disassem_content): Update.
8035
8036 2019-06-25 Tom Tromey <tom@tromey.com>
8037
8038 * tui/tui-win.c (window_name_completer, tui_set_focus)
8039 (tui_all_windows_info): Use name method.
8040 * tui/tui-data.h (struct tui_gen_win_info)
8041 (struct tui_source_window, struct tui_disasm_window)
8042 (struct tui_data_window, struct tui_cmd_window) <name>: New
8043 method.
8044 (tui_win_name): Don't declare.
8045 * tui/tui-data.c (tui_partial_win_by_name): Use name method.
8046 (tui_win_name): Remove.
8047
8048 2019-06-25 Tom Tromey <tom@tromey.com>
8049
8050 * tui/tui-winsource.h (tui_update_source_window)
8051 (tui_update_source_window_as_is): Change parameter type.
8052 * tui/tui-winsource.c (tui_update_source_window): Change win_info
8053 to be a tui_source_window_base.
8054 (tui_update_source_window_as_is): Likewise.
8055 * tui/tui-win.c (make_visible_with_new_height): Update.
8056
8057 2019-06-25 Tom Tromey <tom@tromey.com>
8058
8059 * tui/tui-winsource.c (tui_erase_source_content)
8060 (tui_show_source_content, tui_show_exec_info_content)
8061 (tui_erase_exec_info_content): Use refresh_window method.
8062 * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
8063 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
8064 from tui_refresh_win.
8065 (tui_data_window::refresh_window): New method.
8066 (tui_win_info::refresh, tui_source_window_base::refresh)
8067 (tui_refresh_all): Use refresh_window method.
8068 * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
8069 method.
8070 * tui/tui-regs.c (tui_display_register): Call refresh_window
8071 method.
8072 * tui/tui-layout.c (show_source_disasm_command)
8073 (show_source_or_disasm_and_command): Call refresh_window method.
8074 * tui/tui-data.h (struct tui_gen_win_info)
8075 (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
8076 New method.
8077
8078 2019-06-25 Tom Tromey <tom@tromey.com>
8079
8080 * tui/tui.c (tui_rl_other_window, tui_enable)
8081 (tui_is_window_visible, tui_get_command_dimension): Update.
8082 * tui/tui-winsource.c (tui_update_source_window_as_is)
8083 (tui_clear_source_content, tui_erase_source_content)
8084 (tui_show_source_line, tui_source_window_base::refill)
8085 (tui_source_window_base::do_scroll_horizontal)
8086 (tui_source_window_base::set_is_exec_point_at)
8087 (tui_update_breakpoint_info, tui_set_exec_info_content)
8088 (tui_alloc_source_buffer, tui_line_is_displayed)
8089 (tui_addr_is_displayed): Update.
8090 * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
8091 (tui_check_and_display_highlight_if_needed)
8092 (tui_win_info::make_visible, tui_win_info::refresh)
8093 (tui_refresh_all): Update.
8094 * tui/tui-windata.c (tui_first_data_item_displayed)
8095 (tui_delete_data_content_windows, tui_erase_data_content)
8096 (tui_display_all_data, tui_data_window::refresh_all)
8097 (tui_check_data_values): Update.
8098 * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
8099 (tui_set_win_focus_to, tui_win_info::forward_scroll)
8100 (tui_win_info::backward_scroll, tui_refresh_all_win)
8101 (tui_resize_all, tui_set_focus, tui_all_windows_info)
8102 (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
8103 (tui_source_window_base::set_new_height)
8104 (tui_data_window::set_new_height)
8105 (make_invisible_and_set_new_height)
8106 (make_visible_with_new_height, new_height_ok)
8107 (parse_scrolling_args): Update.
8108 * tui/tui-stack.c (tui_show_frame_info): Update.
8109 * tui/tui-source.c (tui_set_source_content)
8110 (tui_set_source_content_nil, tui_source_is_displayed)
8111 (tui_source_window::do_scroll_vertical): Update.
8112 * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
8113 (tui_display_registers_from, tui_display_reg_element_at_line)
8114 (tui_check_register_values, tui_reg_command): Update.
8115 * tui/tui-layout.c (tui_default_win_height)
8116 (show_source_disasm_command, show_data, init_and_make_win)
8117 (show_source_or_disasm_and_command): Update.
8118 * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
8119 (tui_redisplay_readline, tui_mld_flush)
8120 (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
8121 (tui_getc): Update.
8122 * tui/tui-disasm.c (tui_set_disassem_content)
8123 (tui_disasm_window::do_scroll_vertical): Update.
8124 * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
8125 Now virtual.
8126 (struct tui_win_info): Derive from tui_gen_win_info.
8127 <~tui_win_info>: Mark as override.
8128 <generic>: Remove member.
8129 * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
8130 (tui_prev_win, tui_partial_win_by_name, tui_win_info)
8131 (~tui_data_window, ~tui_win_info)
8132 (tui_free_all_source_wins_content): Update.
8133 * tui/tui-command.c (tui_refresh_cmd_win): Update.
8134
8135 2019-06-25 Tom Tromey <tom@tromey.com>
8136
8137 * tui/tui-layout.c (init_and_make_win): Use new.
8138 * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
8139 destructor, initializers.
8140 (tui_alloc_generic_win_info): Don't declare.
8141 * tui/tui-data.c (_locator): Add argument to constructor.
8142 (source_win, disasm_win): New globals.
8143 (exec_info): Remove.
8144 (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
8145 Update.
8146 (tui_alloc_generic_win_info): Remove.
8147 (init_content_element): Use new.
8148 (tui_win_info::tui_win_info): Update.
8149 (free_content_elements) <case DATA_WIN>: Use delete.
8150
8151 2019-06-25 Tom Tromey <tom@tromey.com>
8152
8153 * tui/tui-wingeneral.c (tui_refresh_win): Update.
8154 * tui/tui-windata.c (tui_first_data_item_displayed)
8155 (tui_delete_data_content_windows): Update.
8156 * tui/tui-win.c (tui_data_window::set_new_height): Update.
8157 * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
8158 (tui_display_registers_from, tui_check_register_values): Update.
8159 * tui/tui-data.h (union tui_which_element) <data_window>: Now a
8160 pointer.
8161 * tui/tui-data.c (init_content_element): Update. Allocate the new
8162 window.
8163 (tui_free_data_content): Update.
8164 (free_content_elements) <case DATA_WIN>: Free the window.
8165
8166 2019-06-25 Tom Tromey <tom@tromey.com>
8167
8168 * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
8169 Update.
8170 * tui/tui-layout.c (make_command_window)
8171 (show_source_disasm_command, show_data, init_and_make_win)
8172 (show_source_or_disasm_and_command): Update.
8173 * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
8174 method.
8175 <can_highight, is_highlighted>: Now bool.
8176 (tui_set_win_highlight): Don't declare.
8177 * tui/tui-data.c (tui_set_win_highlight): Remove.
8178
8179 2019-06-25 Tom Tromey <tom@tromey.com>
8180
8181 * tui/tui-wingeneral.c (make_visible): Remove check of window
8182 type.
8183
8184 2019-06-25 Tom Tromey <tom@tromey.com>
8185
8186 * tui/tui-win.c (tui_win_info::max_height)
8187 (tui_cmd_window::max_height): New methods.
8188 (new_height_ok): Call max_height.
8189 * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
8190 <max_height>: New method.
8191
8192 2019-06-25 Tom Tromey <tom@tromey.com>
8193
8194 * tui/tui-win.c (tui_source_window_base::set_new_height)
8195 (tui_data_window::set_new_height): New methods.
8196 (make_invisible_and_set_new_height): Call set_new_height method.
8197 * tui/tui-data.h (struct tui_win_info)
8198 (struct tui_source_window_base, struct tui_data_window)
8199 <set_new_height>: New method.
8200
8201 2019-06-25 Tom Tromey <tom@tromey.com>
8202
8203 * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
8204 * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
8205 tui_refresh_data_win.
8206 * tui/tui-win.c (tui_source_window_base::refresh_all): New
8207 method.
8208 (tui_refresh_all_win): Call the refresh_all method.
8209 (tui_set_focus): Likewise.
8210 * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
8211 (struct tui_source_window_base, struct tui_data_window) <refresh>:
8212 Likewise.
8213
8214 2019-06-25 Tom Tromey <tom@tromey.com>
8215
8216 * tui/tui-winsource.h (tui_refill_source_window)
8217 (tui_set_is_exec_point_at): Don't declare.
8218 * tui/tui-winsource.c (tui_update_source_windows_with_addr)
8219 (tui_source_window_base::refill): Rename from
8220 tui_refill_source_window.
8221 (tui_source_window_base::do_scroll_horizontal): Update.
8222 (tui_source_window_base::set_is_exec_point_at): Rename from
8223 tui_set_is_exec_point_at.
8224 (tui_update_all_breakpoint_info): Update.
8225 * tui/tui-stack.c (tui_show_frame_info): Update.
8226 * tui/tui-layout.c (show_data): Add cast.
8227 * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
8228 * tui/tui-data.h (struct tui_source_window_base) <refill,
8229 set_is_exec_point_at>: New methods.
8230 (tui_source_windows, tui_add_to_source_windows): Update types.
8231 (tui_add_to_source_windows): Remove redundant declaration.
8232 * tui/tui-data.c (source_windows): Store tui_source_window_base.
8233 (tui_source_windows): Change return type.
8234 (tui_clear_source_windows_detail): Update.
8235 (tui_add_to_source_windows): Change type of parameter.
8236 (tui_free_all_source_wins_content): Update.
8237
8238 2019-06-25 Tom Tromey <tom@tromey.com>
8239
8240 * tui/tui-wingeneral.c (tui_win_info::refresh)
8241 (tui_source_window_base::refresh): New methods.
8242 (tui_refresh_all): Call the refresh method.
8243 * tui/tui-data.h (struct tui_win_info)
8244 (struct tui_source_window_base) <refresh>: New method.
8245
8246 2019-06-25 Tom Tromey <tom@tromey.com>
8247
8248 * tui/tui.h (tui_is_window_visible): Return bool.
8249 * tui/tui.c (tui_is_window_visible): Return bool.
8250 * tui/tui-wingeneral.c (tui_make_window, make_visible)
8251 (tui_make_visible, tui_make_invisible)
8252 (tui_win_info::make_visible)
8253 (tui_source_window_base::make_visible, make_all_visible)
8254 (tui_make_all_visible, tui_make_all_invisible): Update.
8255 * tui/tui-windata.c (tui_delete_data_content_windows): Update.
8256 * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
8257 bool.
8258 (struct tui_win_info, struct tui_source_window_base)
8259 (struct tui_cmd_window) <make_visible>: Change parameter to bool.
8260 * tui/tui-data.c (tui_init_generic_part): Update.
8261
8262 2019-06-25 Tom Tromey <tom@tromey.com>
8263
8264 * tui/tui-wingeneral.c (tui_win_info::make_visible)
8265 (tui_source_window_base::make_visible): New methods.
8266 (make_all_visible): Make method call.
8267 * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
8268 (struct tui_source_window_base, struct tui_cmd_window): Override
8269 make_visible.
8270 (tui_win_is_source_type): Don't declare.
8271 * tui/tui-data.c (tui_win_is_source_type): Remove.
8272
8273 2019-06-25 Tom Tromey <tom@tromey.com>
8274
8275 * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
8276 NULL check.
8277
8278 2019-06-25 Tom Tromey <tom@tromey.com>
8279
8280 * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
8281 Inline constructor. Add initializers for members.
8282 * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
8283 constructors; now inline in class.
8284
8285 2019-06-25 Tom Tromey <tom@tromey.com>
8286
8287 * tui/tui-regs.c (tui_show_registers): Update.
8288 * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
8289 bool.
8290 * tui/tui-data.c (tui_data_window::clear_detail)
8291 (tui_data_window): Update.
8292
8293 2019-06-25 Tom Tromey <tom@tromey.com>
8294
8295 * tui/tui-windata.c (tui_display_all_data)
8296 (tui_display_data_from_line, tui_display_data_from)
8297 (tui_check_data_values, tui_data_window::do_scroll_vertical):
8298 Update.
8299 * tui/tui-regs.c (tui_last_regs_line_no)
8300 (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
8301 (tui_show_registers, tui_show_register_group)
8302 (tui_display_registers_from, tui_display_reg_element_at_line)
8303 (tui_display_registers_from_line, tui_check_register_values)
8304 (tui_reg_next, tui_reg_prev): Update.
8305 * tui/tui-layout.c (tui_set_layout, show_data): Update.
8306 * tui/tui-data.h (struct tui_data_info): Remove. Move contents to
8307 tui_data_window.
8308 (struct tui_win_info) <detail>: Remove. Add new fields from
8309 tui_data_info.
8310 (TUI_DATA_WIN): Add cast.
8311 * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
8312 (~tui_data_window): Simplify.
8313
8314 2019-06-25 Tom Tromey <tom@tromey.com>
8315
8316 * tui/tui-layout.c (show_source_disasm_command)
8317 (show_source_or_disasm_and_command): Update.
8318 * tui/tui-io.c (update_cmdwin_start_line)
8319 (tui_redisplay_readline): Update.
8320 * tui/tui-data.h (struct tui_command_info): Remove.
8321 (struct tui_win_info) <detail>: Remove command_info member.
8322 (struct tui_data_window) <start_line>: New member, from
8323 tui_command_info.
8324 (TUI_CMD_WIN): Add casts.
8325
8326 2019-06-25 Tom Tromey <tom@tromey.com>
8327
8328 * tui/tui-winsource.c (tui_update_source_window)
8329 (tui_refill_source_window)
8330 (tui_source_window_base::do_scroll_horizontal)
8331 (tui_update_breakpoint_info, tui_set_exec_info_content)
8332 (tui_show_exec_info_content, tui_erase_exec_info_content)
8333 (tui_clear_exec_info_content): Update.
8334 * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
8335 Update.
8336 * tui/tui-win.c (make_invisible_and_set_new_height)
8337 (make_visible_with_new_height): Update.
8338 * tui/tui-source.c (tui_set_source_content)
8339 (tui_show_symtab_source): Update.
8340 * tui/tui-layout.c (extract_display_start_addr)
8341 (show_source_disasm_command, show_data)
8342 (make_source_or_disasm_window)
8343 (show_source_or_disasm_and_command): Update.
8344 * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
8345 (tui_disasm_window::do_scroll_vertical): Remove shadowing
8346 "gdbarch".
8347 * tui/tui-data.h (struct tui_source_info): Remove. Move contents
8348 to tui_source_window_base.
8349 (struct tui_win_info) <detail>: Remove source_info member.
8350 (struct tui_source_window_base) <has_locator>: Inline.
8351 Move contents from tui_source_info; rename has_locator member to
8352 m_has_locator.
8353 (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
8354 * tui/tui-data.c (tui_source_window_base::has_locator): Move to
8355 header file.
8356 (tui_source_window_base::clear_detail, ~tui_source_window_base):
8357 Simplify.
8358 (tui_free_all_source_wins_content): Cast to
8359 tui_source_window_base.
8360
8361 2019-06-25 Tom Tromey <tom@tromey.com>
8362
8363 * tui/tui-win.c (make_invisible_and_set_new_height)
8364 (make_visible_with_new_height): Call has_locator method.
8365 * tui/tui-layout.c (show_source_disasm_command, show_data)
8366 (show_source_or_disasm_and_command): Update for bool change.
8367 * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
8368 (tui_win_info) <has_locator>: New method.
8369 (struct tui_source_window_base) <has_locator>: New method.
8370 (tui_win_has_locator): Don't declare.
8371 * tui/tui-data.c (tui_source_window_base::has_locator): Rename
8372 from tui_win_has_locator.
8373 (tui_source_window_base): Use false, not FALSE.
8374
8375 2019-06-25 Tom Tromey <tom@tromey.com>
8376
8377 * tui/tui-data.h (tui_clear_win_detail): Don't declare.
8378 * tui/tui-data.c (tui_clear_source_windows_detail): Call the
8379 clear_detail method directly.
8380 (tui_clear_win_detail): Remove.
8381
8382 2019-06-25 Tom Tromey <tom@tromey.com>
8383
8384 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
8385 "this", not TUI_DISASM_WIN.
8386
8387 2019-06-25 Tom Tromey <tom@tromey.com>
8388
8389 * tui/tui-winsource.h (tui_horizontal_source_scroll): Don't
8390 declare.
8391 * tui/tui-winsource.c
8392 (tui_source_window_base::do_scroll_horizontal): Rename from
8393 tui_horizontal_source_scroll.
8394 * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
8395 * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
8396 from tui_vertical_data_scroll.
8397 * tui/tui-win.h (tui_scroll): Don't declare.
8398 * tui/tui-win.c (tui_win_info::forward_scroll)
8399 (tui_win_info::backward_scroll, tui_win_info::left_scroll)
8400 (tui_win_info::right_scroll): Rename and update.
8401 (tui_scroll_forward_command, tui_scroll_backward_command)
8402 (tui_scroll_left_command, tui_scroll_right_command): Update.
8403 (tui_scroll): Remove.
8404 * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
8405 * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
8406 from tui_vertical_source_scroll.
8407 * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
8408 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
8409 from tui_vertical_disassem_scroll.
8410 * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
8411 do_scroll_horizontal>: New methods.
8412 <forward_scroll, backward_scroll, left_scroll, right_scroll>:
8413 Likewise.
8414 (struct tui_source_window_base): Add do_scroll_horizontal.
8415 (struct tui_source_window, struct tui_disasm_window): Add
8416 do_scroll_vertical.
8417 (struct tui_data_window, struct tui_cmd_window): Add
8418 do_scroll_horizontal and do_scroll_vertical.
8419 * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
8420
8421 2019-06-25 Tom Tromey <tom@tromey.com>
8422
8423 * tui/tui-data.h (struct tui_source_window_base): New struct.
8424 (struct tui_source_window): Derive from tui_source_window_base.
8425 (struct tui_disasm_window): New struct.
8426 * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
8427 from tui_source_window::clear_detail.
8428 (tui_source_window_base): Rename from tui_source_window.
8429 (~tui_source_window_base): Rename from ~tui_source_window.
8430 (tui_alloc_win_info): Create a tui_disasm_window.
8431
8432 2019-06-25 Tom Tromey <tom@tromey.com>
8433
8434 * tui/tui-data.h (struct tui_source_window)
8435 (struct tui_data_window): Declare destructors.
8436 * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
8437 destructors.
8438 (tui_win_info): Simplify.
8439
8440 2019-06-25 Tom Tromey <tom@tromey.com>
8441
8442 * tui/tui-winsource.c (tui_display_main)
8443 (tui_update_source_windows_with_addr)
8444 (tui_update_all_breakpoint_info): Update.
8445 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
8446 (new_height_ok, parse_scrolling_args): Update.
8447 * tui/tui-stack.c (tui_show_frame_info): Update.
8448 * tui/tui-data.h (struct tui_list): Remove.
8449 (tui_source_windows): Return a reference to a std::vector.
8450 * tui/tui-data.c (source_windows): Now a std::vector.
8451 (tui_source_windows): Change return type.
8452 (tui_clear_source_windows): Rewrite.
8453 (tui_clear_source_windows_detail, tui_add_to_source_windows)
8454 (tui_free_all_source_wins_content): Rewrite.
8455
8456 2019-06-25 Tom Tromey <tom@tromey.com>
8457
8458 * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
8459 (struct tui_data_window, struct tui_cmd_window): Declare
8460 clear_detail method.
8461 * tui/tui-data.c (tui_source_window::clear_detail)
8462 (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
8463 methods.
8464 (tui_clear_win_detail): Simplify.
8465
8466 2019-06-25 Tom Tromey <tom@tromey.com>
8467
8468 * tui/tui-layout.c (make_source_window, make_disasm_window)
8469 (make_source_or_disasm_window): Remove win_info_ptr parameter.
8470 Return the new window.
8471 (show_source_disasm_command, show_data)
8472 (show_source_or_disasm_and_command): Update.
8473
8474 2019-06-25 Tom Tromey <tom@tromey.com>
8475
8476 * tui/tui-layout.c (make_command_window): Remove win_info_ptr
8477 parameter. Return the new window.
8478 (show_source_disasm_command): Update and remove NULL check.
8479 (show_source_or_disasm_and_command): Update.
8480
8481 2019-06-25 Tom Tromey <tom@tromey.com>
8482
8483 * tui/tui-layout.c (init_and_make_win): Remove NULL check.
8484
8485 2019-06-25 Tom Tromey <tom@tromey.com>
8486
8487 * tui/tui-data.h (struct tui_win_info): Make constructor
8488 protected. Make destructor virtual. Add initializers.
8489 (tui_source_window, tui_data_window, tui_cmd_window): New
8490 classes.
8491 * tui/tui-data.c (tui_win_info): Rename from init_win_info. Now a
8492 constructor. Add "type" parameter.
8493 (tui_source_window, tui_data_window, tui_cmd_window): New
8494 constructors.
8495 (tui_alloc_win_info): Instantiate the appropriate subclass.
8496
8497 2019-06-25 Tom Tromey <tom@tromey.com>
8498
8499 * tui/tui-win.c (tui_resize_all): Use delete.
8500 * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
8501 destructor.
8502 (tui_free_window): Don't declare.
8503 * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
8504 Update.
8505
8506 2019-06-25 Tom Tromey <tom@tromey.com>
8507
8508 * tui/tui-data.h (struct tui_win_info): Add constructor.
8509 * tui/tui-data.c (tui_alloc_win_info): Use new.
8510 (tui_free_window): Use delete.
8511
8512 2019-06-22 Tom Tromey <tom@tromey.com>
8513
8514 * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
8515 declare.
8516 * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
8517
8518 2019-06-22 Tom Tromey <tom@tromey.com>
8519
8520 * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
8521 declare.
8522 * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
8523
8524 2019-06-22 Tom de Vries <tdevries@suse.de>
8525
8526 * dwarf2read.c (create_addrmap_from_aranges)
8527 (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
8528 instead of '%zu'.
8529
8530 2019-06-21 Simon Marchi <simon.marchi@efficios.com>
8531
8532 * dwarf2read.h (dwarf2_section_info_def): Remove.
8533 (DEF_VEC_O (dwarf2_section_info_def)): Remove.
8534 * dwarf2read.c (struct dwo_sections) <types>: Change type to
8535 std::vector<dwarf2_section_info>.
8536 (struct dwo_file) <~dwo_file>: Remove.
8537 (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
8538 types field.
8539 (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
8540 (dwarf2_read_debug_names): Likewise.
8541 (create_debug_types_hash_table): Change parameter type to
8542 array_view, adjust code accordingly.
8543 (dwarf2_locate_dwo_sections): Adjust to std::vector.
8544 (partial_die_info::fixup): Likewise.
8545 (determine_prefix): Likewise.
8546 * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
8547
8548 2019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
8549
8550 * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
8551 gdb_bfd_ref_ptr.
8552 <~dwo_file>: Remove call to gdb_bfd_unref.
8553 (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
8554 gdb_bfd_ref_ptr::get.
8555
8556 2019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
8557
8558 * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
8559 type to htab_up.
8560 * dwarf2read.c (struct dwo_file): Initialize fields.
8561 <~dwo_file>: New.
8562 (free_dwo_file): Remove, move content to ~dwo_file.
8563 (struct dwo_file_deleter): Remove.
8564 (dwo_file_up>: Remove custom deleter.
8565 (free_dwo_files): Remove.
8566 (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
8567 dwo_files.
8568 (process_skeletonless_type_units): Call unique_ptr::get.
8569 (allocate_dwo_file_hash_table): Add deleter to created hash
8570 table. Change return type to htab_up.
8571 (lookup_dwo_file_slot): Don't memset dwo_file, call
8572 unique_ptr::get.
8573 (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
8574 (create_dwo_unit_in_dwp_v2): Likewise.
8575 (open_and_init_dwo_file): Likewise.
8576 (free_dwo_file_from_slot): Remove.
8577
8578 2019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
8579
8580 * dwarf2read.h (struct dwarf2_section_info) <readin,
8581 is_virtual>: Change type to bool.
8582 * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
8583 true instead of 1.
8584
8585 2019-06-19 Tom Tromey <tom@tromey.com>
8586
8587 * tui/tui-data.h (tui_init_content_element): Don't declare.
8588
8589 2019-06-19 Tom Tromey <tom@tromey.com>
8590
8591 * tui/tui-data.h (tui_init_win_info): Don't declare.
8592
8593 2019-06-19 Tom de Vries <tdevries@suse.de>
8594
8595 * dwarf2read.h (abstract_to_concrete): Change type to
8596 std::unordered_map<sect_offset, std::vector<sect_offset>,
8597 gdb::hash_enum<sect_offset>>.
8598
8599 2019-06-19 Tom Tromey <tromey@adacore.com>
8600
8601 * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
8602 EVAL_AVOID_SIDE_EFFECTS specially.
8603
8604 2019-06-19 Tom Tromey <tromey@adacore.com>
8605
8606 * source-cache.c (highlighter): New global.
8607 (source_cache::get_source_lines): Create a highlighter on demand.
8608
8609 2019-06-18 Andrew Burgess <andrew.burgess@embecosm.com>
8610
8611 * defs.h (deprecated_interactive_hook): Delete declaration.
8612 * interps.c (clear_interpreter_hooks): Remove use of
8613 deprecated_interactive_hook.
8614 * top.c (deprecated_interactive_hook): Delete definition.
8615 * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
8616
8617 2019-06-18 Tom de Vries <tdevries@suse.de>
8618
8619 PR gdb/24515
8620 * dwarf2read.h (abstract_to_concrete): Change type from
8621 std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
8622 std::unordered_map<sect_offset, std::vector<sect_offset>>.
8623 * dwarf2read.c (read_variable): Update.
8624 (dwarf2_fetch_die_loc_sect_off): Update.
8625
8626 2019-06-17 Tom de Vries <tdevries@suse.de>
8627
8628 PR gdb/24617
8629 * common/pathstuff.c (child_path): Make sure parent_len > 0 before
8630 accessing parent[parent_len - 1].
8631
8632 2019-06-17 Paul Pluzhnikov <ppluzhnikov@google.com>
8633
8634 PR gdb/24364
8635 * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
8636 call dtrace_process_dof with NULL dof.
8637
8638 2019-06-16 Tom de Vries <tdevries@suse.de>
8639
8640 PR gdb/24445
8641 * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
8642
8643 2019-06-16 Tom Tromey <tom@tromey.com>
8644
8645 * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
8646 (make_all_visible): Use address of member.
8647
8648 2019-06-16 Tom Tromey <tom@tromey.com>
8649
8650 * tui/tui-data.c (tui_clear_win_detail, init_win_info)
8651 (tui_free_window, free_content, free_content_elements): Remove
8652 unnecessary cast.
8653 * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
8654 cast.
8655 * tui/tui-regs.c (tui_show_register_group)
8656 (tui_display_registers_from, tui_display_reg_element_at_line):
8657 Remove unnecessary cast.
8658
8659 2019-06-16 Andrew Burgess <andrew.burgess@embecosm.com>
8660
8661 * linux-nat.c (normal_mask): Delete.
8662 (_initialize_linux_nat): Don't initialise normal_mask.
8663
8664 2019-06-16 Simon Marchi <simon.marchi@polymtl.ca>
8665
8666 PR gdb/24445
8667 * dwarf-index-write.h (write_psymtabs_to_index): Add
8668 dwz_basename parameter.
8669 * dwarf-index-write.c (write_gdbindex): Move file writing to
8670 write_gdbindex_1. Change return type void.
8671 (assert_file_size): Move up, remove filename parameter.
8672 (write_gdbindex_1): New function.
8673 (write_debug_names): Change return type to void, call
8674 assert_file_size.
8675 (struct index_wip_file): New struct.
8676 (write_psymtabs_to_index): Add dwz_basename parameter. Move
8677 file logic to index_wip_file. Write index for dwz file if
8678 needed.
8679 (save_gdb_index_command): Pass basename of dwz file, if present.
8680 * dwarf-index-cache.c (index_cache::store): Obtain and pass
8681 build-id of dwz file, if present.
8682 * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
8683 (dwarf2_get_dwz_file): Likewise.
8684 * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
8685 (dwarf2_get_dwz_file): Likewise.
8686
8687 2019-06-16 Tom Tromey <tom@tromey.com>
8688
8689 * coffread.c (process_coff_symbol): Use xstrdup.
8690 * value.c (create_internalvar): Use xstrdup.
8691
8692 2019-06-16 Tom Tromey <tom@tromey.com>
8693
8694 * valops.c (value_cast, value_slice): Remove unnecessary cast.
8695 * breakpoint.c (stopin_command, stopat_command)
8696 (until_break_command, decode_location_default): Remove unnecessary
8697 cast.
8698 * utils.c (subset_compare): Remove unnecessary cast.
8699 * ada-lang.c (ada_update_initial_language): Remove unnecessary
8700 cast.
8701 * linespec.c (decode_line_with_last_displayed): Remove unnecessary
8702 cast.
8703 * infcmd.c (path_command): Remove unnecessary cast.
8704 * coffread.c (decode_type): Remove unnecessary cast.
8705 * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
8706 * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
8707 * tui/tui-stack.c (tui_show_locator_content)
8708 (tui_show_frame_info): Remove unnecessary cast.
8709 * tui/tui-win.c (tui_scroll_forward_command)
8710 (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
8711 (parse_scrolling_args): Remove unnecessary cast.
8712 * tui/tui-data.c (init_win_info, tui_del_window)
8713 (tui_free_window, tui_del_data_windows, tui_free_data_content)
8714 (free_content_elements): Remove unnecessary cast.
8715 * tui/tui-windata.c (tui_first_data_item_displayed): Remove
8716 unnecessary cast.
8717 * tui/tui-source.c (tui_set_source_content)
8718 (tui_vertical_source_scroll): Remove unnecessary cast.
8719 * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
8720 cast.
8721 * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
8722 * tui/tui-regs.c (tui_display_registers_from)
8723 (tui_display_register): Remove unnecessary cast.
8724 * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
8725 (tui_unhighlight_win, tui_highlight_win, tui_make_window)
8726 (make_visible): Remove unnecessary cast.
8727 * tui/tui-winsource.c (tui_erase_source_content)
8728 (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
8729 unnecessary cast.
8730 * ax-gdb.c (agent_command_1): Remove unnecessary cast.
8731 * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
8732 * stabsread.c (read_type, read_array_type, read_range_type):
8733 Remove unnecessary cast.
8734 * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
8735 (parse_symbol, parse_type, upgrade_type, parse_external)
8736 (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
8737 unnecessary cast.
8738 * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
8739
8740 2019-06-16 Tom Tromey <tom@tromey.com>
8741
8742 * tui/tui-data.c (tui_alloc_generic_win_info)
8743 (tui_alloc_win_info, tui_add_content_elements): Remove NULL
8744 checks.
8745
8746 2019-06-16 Bernhard Heckel <bernhard.heckel@intel.com>
8747 Andrew Burgess <andrew.burgess@embecosm.com>
8748
8749 * f-typeprint.c (f_print_type): Don't return early for not
8750 associated or not allocated types.
8751 (f_type_print_varspec_suffix): Add print_rank parameter and print
8752 ranks of array types in case they dangling.
8753 (f_type_print_base): Add print_rank parameter.
8754
8755 2019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
8756
8757 * NEWS: Mention new MI commands.
8758 * break-catch-throw.c (enum exception_event_kind): Move to
8759 breakpoint.h.
8760 (print_mention_exception_catchpoint): Output text as a single
8761 message.
8762 (catch_exception_command_1): Rename to...
8763 (catch_exception_event): ...this, make non-static, update header
8764 command, and change some parameter types.
8765 (catch_catch_command): Update for changes to
8766 catch_exception_command_1.
8767 (catch_throw_command): Likewise.
8768 (catch_rethrow_command): Likewise.
8769 * breakpoint.c (enum exception_event_kind): Delete.
8770 * breakpoint.h (enum exception_event_kind): Moved here from
8771 break-catch-throw.c.
8772 (catch_exception_event): Declare.
8773 * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
8774 (mi_cmd_catch_throw): New function.
8775 (mi_cmd_catch_rethrow): New function.
8776 (mi_cmd_catch_catch): New function.
8777 * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
8778 'catch-catch' entries.
8779 * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
8780 (mi_cmd_catch_rethrow): Declare.
8781 (mi_cmd_catch_catch): Declare.
8782
8783 2019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
8784
8785 * annotate.c (annotate_source_line): Change return type to void,
8786 update implementation to match.
8787 * annotate.h (annotate_source_line): Change return type to void,
8788 update header comment.
8789 * stack.c (print_frame_info): Don't change what frame information
8790 is printed based on whether annotations are on or not.
8791
8792 2019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
8793
8794 * annotate.c: Add 'source.h' and 'objfiles.h' includes.
8795 (annotate_source): Make static.
8796 (annotate_source_line): Moved from source.c and renamed from
8797 identify_source_line. Update the return type.
8798 * annotate.h (annotate_source): Delete declaration.
8799 (annotate_source_line): Declaration moved from source.h, and
8800 renamed from identify_source_line. Return type updated.
8801 * source.c (identify_source_line): Moved to annotate.c and renamed
8802 to annotate_source_line.
8803 (info_line_command): Remove check of annotation_level.
8804 * source.h (identify_source_line): Move declaration to annotate.h
8805 and rename to annotate_source_line.
8806 * stack.c: Add 'annotate.h' include.
8807 (print_frame_info): Remove check of annotation_level before
8808 calling annotate_source_line.
8809
8810 2019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
8811
8812 * source-cache.c (source_cache::get_plain_source_lines): Use
8813 open_source_file_with_line_charpos instead of just
8814 open_source_file, remove call to find_source_lines.
8815 (source_cache::get_source_lines): Likewise.
8816 * source.c (find_source_lines): Make static.
8817 (get_filename_and_charpos): Renamed into...
8818 (open_source_file_with_line_charpos): ..this along with changes to
8819 return a scoped_fd, and some other minor clean ups.
8820 (identify_source_line): Use open_source_file_with_line_charpos.
8821 (search_command_helper): Use open_source_file_with_line_charpos
8822 instead of just open_source_file, remove call to
8823 find_source_lines.
8824 * source.h (open_source_file_with_line_charpos): Declare new
8825 function.
8826 (find_source_lines): Delete declaration.
8827
8828 2019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
8829
8830 * source.c (get_filename_and_charpos): Remove fullname
8831 parameter.
8832 (identify_source_line): Update call to get_filename_and_charpos.
8833
8834 2019-06-14 Tom Tromey <tromey@adacore.com>
8835
8836 PR gdb/24502:
8837 * ui-style.h (skip_ansi_escape): Update comment.
8838 * ui-file.h (class no_terminal_escape_file): New class.
8839 * ui-file.c (no_terminal_escape_file::write)
8840 (no_terminal_escape_file::puts): New methods.
8841 * cli/cli-logging.c (handle_redirections): Use
8842 no_terminal_escape_file.
8843
8844 2019-06-14 Tom Tromey <tromey@adacore.com>
8845
8846 * NEWS: Move convenience variable news above Python news.
8847
8848 2019-06-14 Tom Tromey <tom@tromey.com>
8849
8850 * gnulib: Move directory to top-level.
8851 * configure.ac: Don't configure gnulib.
8852 * configure: Rebuild.
8853 * common/common-defs.h: Use new path to gnulib.
8854 * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
8855 (GNULIB_H): Remove.
8856 (INCGNU): Look in new gnulib location.
8857 (HFILES_NO_SRCDIR): Remove gnulib files.
8858 (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
8859 (generated_files): Remove GNULIB_H.
8860 ($(LIBGNU), all-lib): Remove targets.
8861 (distclean): Don't mention GNULIB_BUILDDIR.
8862 ($(GNULIB_BUILDDIR)/Makefile): Remove target.
8863
8864 2019-06-14 Tom Tromey <tromey@adacore.com>
8865
8866 * symfile.c (add_symbol_file_command): Remove obsolete comment.
8867 Warn if symbol file does not provide any symbols.
8868
8869 2019-06-14 Tom Tromey <tromey@adacore.com>
8870
8871 * source.c (find_and_open_source): Respect basenames_may_differ.
8872
8873 2019-06-14 Andrew Burgess <andrew.burgess@embecosm.com>
8874
8875 * annotate.c (annotate_breakpoints_invalid): Make use of
8876 scoped_restore_terminal_state.
8877 (annotate_frames_invalid): Likewise.
8878
8879 2019-06-14 Tom Tromey <tromey@adacore.com>
8880
8881 * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
8882 allow assignment to an internalvar.
8883
8884 2019-06-14 Tom Tromey <tromey@adacore.com>
8885
8886 * ada-lex.l: Allow "_" in attribute names.
8887
8888 2019-06-14 Tom Tromey <tromey@adacore.com>
8889
8890 PR gdb/24653:
8891 * regcache.c (registers_changed): Don't call alloca.
8892 * top.c (execute_command): Don't call alloca.
8893
8894 2019-06-13 Pedro Alves <palves@redhat.com>
8895
8896 * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
8897 'expression'. When parsing an expression, error out if there's
8898 junk after "unlimited".
8899 (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
8900 (do_set_command): Adjust calls to is_unlimited_literal.
8901
8902 2019-06-13 Pedro Alves <palves@redhat.com>
8903
8904 * compile/compile.c (make_compile_options_def_group): Add braces
8905 around array_view initializer.
8906 * thread.c (make_thread_apply_all_options_def_group)
8907 (make_thread_apply_all_options_def_group): Likewise.
8908
8909 2019-06-13 Pedro Alves <palves@redhat.com>
8910
8911 * NEWS (New commands): Mention "maint test-options
8912 require-delimiter", "maint test-options unknown-is-error", "maint
8913 test-options unknown-is-operand" and "maint show
8914 test-options-completion-result".
8915 (New command options, command completion): New section.
8916 (Completion improvements): New section.
8917 Mention that you can abbreviate "unlimited".
8918
8919 2019-06-13 Pedro Alves <palves@redhat.com>
8920
8921 * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
8922 * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
8923 * unittests/cli-utils-selftests.c (test_parse_flags)
8924 (test_parse_flags_qcs): Delete.
8925 (test_cli_utils): Don't call deleted functions.
8926
8927 2019-06-13 Pedro Alves <palves@redhat.com>
8928
8929 * thread.c: Include "cli/cli-option.h".
8930 (tp_array_compar_ascending): Global.
8931 (tp_array_compar): Delete function.
8932 (tp_array_compar_ascending, tp_array_compar_descending): New
8933 functions.
8934 (ascending_option_def, qcs_flag_option_def)
8935 (thr_qcs_flags_option_defs)
8936 (make_thread_apply_all_options_def_group)
8937 (make_thread_apply_options_def_group): New.
8938 (thread_apply_all_command): Use gdb::option::process_options.
8939 (thread_apply_command_completer)
8940 (thread_apply_all_command_completer): New.
8941 (thread_apply_command): Use gdb::option::process_options.
8942 (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
8943 with a new THREAD_APPLY_OPTION_HELP. Use gdb::option::build_help
8944 to generate help text of "thread apply". Adjust "taas"'s help.
8945 * tid-parse.c (tid_range_parser::in_thread_range): New method.
8946 * tid-parse.h (tid_range_parser::in_thread_range): New method.
8947
8948 2019-06-13 Pedro Alves <palves@redhat.com>
8949
8950 * thread.c (thread_apply_command): Check for invalid TID with
8951 isdigit instead of !isalpha.
8952
8953 2019-06-13 Pedro Alves <palves@redhat.com>
8954
8955 * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
8956 (validate_flags_qcs): New.
8957 * cli/cli-utils.h (struct qcs_flags): Change field types to int.
8958 (validate_flags_qcs): Declare.
8959 * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
8960 (make_frame_apply_options_def_group): New.
8961 (frame_apply_command_count): Process options with
8962 gdb::option::process_options.
8963 (frame_apply_completer): New.
8964 (frame_apply_level_completer, frame_apply_all_completer)
8965 (frame_apply_completer): New.
8966 (_initialize_stack): Update help of "frame apply", "frame apply
8967 level", "frame apply all" and "faas" to mention supported options
8968 and install command completers.
8969 * stack.h (frame_apply_all_completer): Declare.
8970 * thread.c: Include "stack.h".
8971 (tfaas_command): Add "--".
8972 (_initialize_thread): Update help "tfaas" to mention supported
8973 options and install command completer.
8974
8975 2019-06-13 Pedro Alves <palves@redhat.com>
8976
8977 * completer.c (complete_nested_command_line): New.
8978 (gdb_completion_word_break_characters_throw): Add assertion.
8979 * completer.h (complete_nested_command_line): Declare.
8980
8981 2019-06-13 Pedro Alves <palves@redhat.com>
8982
8983 * stack.c (parse_backtrace_qualifiers): New.
8984 (backtrace_command): Use it.
8985 (backtrace_command_completer): Complete on qualifiers.
8986
8987 2019-06-13 Pedro Alves <palves@redhat.com>
8988
8989 * frame.c: Include "cli/cli-option.h.
8990 (user_set_backtrace_options): New.
8991 (backtrace_past_main, backtrace_past_entry, backtrace_limit):
8992 Delete.
8993 (get_prev_frame): Adjust.
8994 (boolean_option_def, uinteger_option_def)
8995 (set_backtrace_option_defs): New.
8996 (_initialize_frame): Adjust and use
8997 gdb::option::add_setshow_cmds_for_options to install "set
8998 backtrace past-main" and "set backtrace past-entry".
8999 * frame.h: Include "cli/cli-option.h".
9000 (struct frame_print_options): Forward declare.
9001 (print_frame_arguments_all, print_frame_arguments_scalars)
9002 (print_frame_arguments_none): Declare.
9003 (print_entry_values): Delete declaration.
9004 (struct frame_print_options, user_frame_print_options): New.
9005 (struct set_backtrace_options): New.
9006 (set_backtrace_option_defs, user_set_backtrace_options): Declare.
9007 * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
9008 (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
9009 (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
9010 (list_args_or_locals): Add frame_print_options parameter.
9011 (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
9012 * python/py-framefilter.c (enumerate_args): Pass down
9013 USER_FRAME_PRINT_OPTIONS.
9014 * stack.c: Include "cli/cli-option.h".
9015 (print_frame_arguments_all, print_frame_arguments_scalars)
9016 (print_frame_arguments_none): Declare.
9017 (print_raw_frame_arguments, print_entry_values): Delete.
9018 (user_frame_print_options): New.
9019 (boolean_option_def, enum_option_def, frame_print_option_defs):
9020 New.
9021 (struct backtrace_cmd_options): New.
9022 (bt_flag_option_def): New.
9023 (backtrace_command_option_defs): New.
9024 (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
9025 (print_frame_arg, read_frame_arg, print_frame_args)
9026 (print_frame_info, print_frame): Add frame_print_options parameter
9027 and use it.
9028 (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
9029 (backtrace_command_1): Add frame_print_options and
9030 backtrace_cmd_options parameters and use them.
9031 (make_backtrace_options_def_group): New.
9032 (backtrace_command): Process command options with
9033 gdb::option::process_options.
9034 (backtrace_command_completer): New.
9035 (_initialize_stack): Extend "backtrace"'s help to mention
9036 supported options. Install completer for "backtrace".
9037 Install some settings commands with add_setshow_cmds_for_options.
9038
9039 2019-06-13 Pedro Alves <palves@redhat.com>
9040
9041 * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
9042 and that "set/show print raw frame-arguments" are now deprecated.
9043
9044 * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
9045 command.
9046 * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
9047 * stack.c (_initialize_stack): Install "set/show print
9048 raw-frame-arguments", and deprecate "set/show print raw
9049 frame-arguments".
9050 * valprint.c (_initialize_valprint): Deprecate "set/show print
9051 raw".
9052
9053 2019-06-13 Pedro Alves <palves@redhat.com>
9054
9055 * compile/compile.c (struct compile_options): New.
9056 (compile_flag_option_def, compile_command_option_defs)
9057 (make_compile_options_def_group): New.
9058 (compile_file_command): Handle options with
9059 gdb::option::process_options.
9060 (compile_file_command_completer): New function.
9061 (compile_code_command): Handle options with
9062 gdb::option::process_options.
9063 (compile_code_command_completer): New function.
9064 (_initialize_compiler): Install completers for "compile code" and
9065 "compile file". Mention available options in "compile code" and
9066 "compile code"'s help.
9067 * completer.c (advance_to_completion_word): New, factored out from
9068 ...
9069 (advance_to_expression_complete_word_point): ... this.
9070 (advance_to_filename_complete_word_point): New.
9071 * completer.h (advance_to_filename_complete_word_point): New
9072 declaration.
9073
9074 2019-06-13 Pedro Alves <palves@redhat.com>
9075
9076 * compile/compile.c: Include "cli/cli-option.h".
9077 (compile_print_value): Scope data pointer is now a
9078 value_print_options pointer; adjust.
9079 (compile_print_command): Process options. Scope data pointer is
9080 now a value_print_options pointer; adjust.
9081 (_initialize_compile): Update "compile print"'s help to include
9082 supported options. Install a completer for "compile print".
9083 * cp-valprint.c (show_vtblprint, show_objectprint)
9084 (show_static_field_print): Delete.
9085 (_initialize_cp_valprint): Don't install "set print
9086 static-members", "set print vtbl", "set print object" here.
9087 * printcmd.c: Include "cli/cli-option.h" and
9088 "common/gdb_optional.h".
9089 (print_command_parse_format): Rework to fill in a
9090 value_print_options instead of a format_data.
9091 (print_value): Change parameter type from format_data pointer to
9092 value_print_options reference. Adjust.
9093 (print_command_1): Process options. Adjust to pass down a
9094 value_print_options.
9095 (print_command_completer): New.
9096 (_initialize_printcmd): Install print_command_completer as
9097 handle_brkchars completer for the "print" command. Update
9098 "print"'s help to include supported options.
9099 * valprint.c: Include "cli/cli-option.h".
9100 (show_vtblprint, show_objectprint, show_static_field_print): Moved
9101 here from cp-valprint.c.
9102 (boolean_option_def, uinteger_option_def)
9103 (value_print_option_defs, make_value_print_options_def_group):
9104 New. Use gdb::option::add_setshow_cmds_for_options to install
9105 "set print elements", "set print null-stop", "set print repeats",
9106 "set print pretty", "set print union", "set print array", "set
9107 print address", "set print symbol", "set print array-indexes".
9108 * valprint.h: Include <string> and "cli/cli-option.h".
9109 (make_value_print_options_def_group): Declare.
9110 (print_value): Change parameter type from format_data pointer to
9111 value_print_options reference.
9112 (print_command_completer): Declare.
9113
9114 2019-06-13 Pedro Alves <palves@redhat.com>
9115
9116 * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
9117 (COMMON_SFILES): Add maint-test-settings.c.
9118 * cli/cli-decode.c (boolean_enums): New global, factored out from
9119 ...
9120 (add_setshow_boolean_cmd): ... here.
9121 * cli/cli-decode.h (boolean_enums): Declare.
9122 * cli/cli-option.c: New file.
9123 * cli/cli-option.h: New file.
9124 * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
9125 factored out from ...
9126 (parse_cli_boolean_value(const char *)): ... this.
9127 (is_unlimited_literal): Change parameter type to pointer to
9128 pointer. Adjust and advance ARG pointer.
9129 (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
9130 (parse_cli_var_enum): New, factored out from ...
9131 (do_set_command): ... this. Adjust.
9132 * cli/cli-setshow.h (parse_cli_boolean_value)
9133 (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
9134 (parse_cli_var_enum): Declare.
9135 * cli/cli-utils.c: Include "cli/cli-option.h".
9136 (get_ulongest): New.
9137 * cli/cli-utils.h (get_ulongest): Declare.
9138 (check_for_argument): New overloads.
9139 * maint-test-options.c: New file.
9140
9141 2019-06-13 Pedro Alves <palves@redhat.com>
9142
9143 * cli/cli-utils.c (number_or_range_parser::get_number): Do not
9144 parse a range if "-" is at the end of the string.
9145
9146 2019-06-13 Pedro Alves <palves@redhat.com>
9147
9148 * cli/cli-setshow.c (parse_auto_binary_operation)
9149 (parse_cli_boolean_value): Don't allow "o".
9150
9151 2019-06-13 Pedro Alves <palves@redhat.com>
9152
9153 * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
9154 * NEWS: Mention maint test-settings KIND.
9155 * maint-test-settings.c: New file.
9156
9157 2019-06-13 Pedro Alves <palves@redhat.com>
9158
9159 * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
9160 completer.
9161 (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
9162 "set" completers.
9163
9164 2019-06-13 Pedro Alves <palves@redhat.com>
9165
9166 * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
9167 after item.
9168
9169 2019-06-13 Pedro Alves <palves@redhat.com>
9170
9171 * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
9172
9173 2019-06-13 Pedro Alves <palves@redhat.com>
9174
9175 * ax-gdb.c (agent_command_1): Remove skip_spaces call.
9176 * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
9177 call.
9178 * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
9179 * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
9180 calls.
9181 (check_for_argument): Skip spaces after argument.
9182
9183 2019-06-13 Pedro Alves <palves@redhat.com>
9184
9185 * thread.c (thread_apply_command): Adjust TID parsing.
9186 * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
9187 detected before end of string.
9188 (tid_is_in_list): Error out if LIST is invalid.
9189
9190 2019-06-13 Pedro Alves <palves@redhat.com>
9191
9192 * completer.c (complete_line_internal_1): Rewind completion word
9193 point.
9194 (completion_tracker::advance_custom_word_point_by): Change
9195 parameter type to int.
9196 * completer.h (completion_tracker::advance_custom_word_point_by):
9197 Likewise.
9198
9199 2019-06-13 Pedro Alves <palves@redhat.com>
9200
9201 * completer.c (advance_to_completion_word): Handle delimiters.
9202
9203 2019-06-11 Bernhard Heckel <bernhard.heckel@intel.com>
9204
9205 * dwarf2read.c (add_partial_symbol): Skip nameless modules.
9206
9207 2019-06-11 Tom Tromey <tom@tromey.com>
9208
9209 * common/common-utils.c (xmalloc, xrealloc, xcalloc)
9210 (xmalloc_failed): Move to alloc.c.
9211 * alloc.c: New file.
9212 * Makefile.in (COMMON_SFILES): Add alloc.c.
9213
9214 2019-06-11 Tom Tromey <tom@tromey.com>
9215
9216 * nat/linux-waitpid.c: Don't include server.h.
9217 (linux_debug): Remove.
9218 (my_waitpid): Update.
9219
9220 2019-06-11 Tom Tromey <tromey@adacore.com>
9221
9222 * infcall.c (_initialize_infcall): Remove trailing newline from
9223 help.
9224 * user-regs.c (_initialize_user_regs): Remove trailing newline
9225 from help.
9226 * typeprint.c (_initialize_typeprint): Remove trailing newline
9227 from help.
9228 * reverse.c (_initialize_reverse): Remove trailing newlines from
9229 help.
9230 * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
9231 from help.
9232 * language.c (add_set_language_command): Remove trailing newline
9233 from help.
9234 * infcmd.c (_initialize_infcmd): Remove trailing newlines from
9235 help.
9236 * disasm.c (_initialize_disasm): Remove trailing newline from
9237 help.
9238 * top.c (init_main): Remove trailing newline from help.
9239 * interps.c (_initialize_interpreter): Remove trailing newline
9240 from help.
9241 * btrace.c (_initialize_btrace): Remove trailing newlines from
9242 help.
9243 * breakpoint.c (_initialize_breakpoint): Remove trailing newline
9244 from help.
9245 * python/python.c (_initialize_python): Remove trailing newline
9246 from help.
9247 * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
9248 help.
9249 * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
9250 from help. Reformat some text.
9251 * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
9252 from help.
9253 * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
9254 newline from help.
9255
9256 2019-06-11 Tom Tromey <tromey@adacore.com>
9257
9258 * darwin-nat.c (darwin_decode_exception_message)
9259 (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
9260
9261 2019-06-10 Andrew Burgess <andrew.burgess@embecosm.com>
9262
9263 * valops.c (value_slice): Check for not allocated or not
9264 associated values.
9265
9266 2019-06-10 Tom de Vries <tdevries@suse.de>
9267
9268 PR gdb/24618
9269 * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
9270 sure an empty slot (defined by a 32-bit zero pair) is recognized as
9271 invalid.
9272
9273 2019-06-10 Tom de Vries <tdevries@suse.de>
9274
9275 PR gdb/24611
9276 * linespec.c (linespec_lexer_lex_string): Remove incorrect
9277 "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon. Add assert.
9278
9279 2019-06-10 Tom de Vries <tdevries@suse.de>
9280
9281 PR symtab/24545
9282 * symtab.c (struct demangled_name_entry): Add language field.
9283 (symbol_set_names): Revert "[gdb/symtab] Fix language of duplicate
9284 static minimal symbol". Set and use language field.
9285
9286 2019-06-10 Tom Tromey <tromey@adacore.com>
9287
9288 * ada-lang.c (_initialize_ada_language): Update help text.
9289
9290 2019-06-10 Tom Tromey <tromey@adacore.com>
9291
9292 * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
9293 with a newline.
9294 * guile/guile.c (handle_boot_error): Don't end warning with a
9295 newline.
9296 * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
9297 warning with a newline.
9298 * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
9299 newline.
9300 (s12z_frame_cache): Likewise.
9301 * dwarf-index-cache.c (index_cache::store): Don't end warning with
9302 a newline.
9303 * solib-svr4.c (disable_probes_interface): Don't end warning with
9304 a newline.
9305 * nat/fork-inferior.c (fork_inferior): Don't end warning with a
9306 newline.
9307 * python/python.c (do_finish_initialization): Don't end warning
9308 with a newline.
9309
9310 2019-06-10 Tom Tromey <tom@tromey.com>
9311
9312 * python/py-breakpoint.c (gdbpy_breakpoint_created)
9313 (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
9314 gdbpy_enter.
9315
9316 2019-06-10 Tom Tromey <tromey@adacore.com>
9317
9318 * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
9319 data.
9320 (elf_new_init): Don't call stabsread_new_init.
9321 * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
9322 (elfstab_build_psymtabs): Likewise. Call stabsread_new_init.
9323 * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
9324
9325 2019-06-10 Tom de Vries <tdevries@suse.de>
9326
9327 PR symtab/16264
9328 PR symtab/24517
9329 * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
9330
9331 2019-06-06 Руслан Ижбулатов <lrn1986@gmail.com>
9332
9333 * source.c (find_and_open_source): Also rewrite relative file
9334 names.
9335
9336 2019-04-26 Amos Bird <amosbird@gmail.com>
9337
9338 * annotate.c (annotate_thread_exited): Add "thread-exited"
9339 annotation.
9340
9341 2019-06-06 Tom Tromey <tromey@adacore.com>
9342
9343 * maint.h (class scoped_command_stats): Use
9344 DISABLE_COPY_AND_ASSIGN.
9345 <print_time>: New method.
9346 * maint.c (scoped_command_stats, ~scoped_command_stats): Call
9347 print_time.
9348 (scoped_command_stats::print_time): New method.
9349
9350 2019-06-05 Andrew Burgess <andrew.burgess@embecosm.com>
9351
9352 * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
9353 instructions of lengths 6 or 8 bytes.
9354
9355 2019-06-04 Pedro Alves <palves@redhat.com>
9356
9357 * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
9358
9359 * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
9360 * breakpoint.c (condition_completer): Likewise.
9361 * cli/cli-dump.c (scan_expression): Likewise.
9362 * common/filestuff.c (mkdir_recursive): Likewise.
9363 * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
9364 * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
9365 (gdb_abspath): Likewise.
9366 * compile/compile-cplus-types.c
9367 (compile_cplus_instance::decl_name): Likewise.
9368 * completer.c (complete_explicit_location):
9369 (signal_completer, reg_or_group_completer_1): Likewise.
9370 * cp-support.c (cp_remove_params_if_any): Likewise.
9371 * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
9372 * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
9373 * infcmd.c (strip_bg_char): Likewise.
9374 * linespec.c (copy_token_string): Likewise.
9375 * mi/mi-main.c (output_cores): Likewise.
9376 * psymtab.c (psymtab_search_name):
9377 * symfile.c (test_set_ext_lang_command): Likewise.
9378 * target.c (target_fileio_read_stralloc): Likewise.
9379 * tui/tui-regs.c (tui_reggroup_completer): Likewise.
9380 * value.c (complete_internalvar): Likewise.
9381
9382 2019-06-04 Christian Biesinger <cbiesinger@google.com>
9383
9384 Add objfile property to gdb.Type.
9385 * NEWS: Mention Python API addition.
9386 * python/py-type.c (typy_get_objfile): New method.
9387
9388 2019-06-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9389
9390 * NEWS: Mention the new set|show style [title|highlight].
9391 Mention changes to "show style", "help" and "apropos".
9392
9393 2019-06-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9394
9395 * cli/cli-decode.h (apropos_cmd): Add verbose argument.
9396 * cli/cli-decode.c (apropos_cmd): Likewise. Use print_doc_of_command
9397 instead of print_help_for_command.
9398 (print_doc_of_command): New function.
9399 (help_list): Add 'apropos -v word' suggestion.
9400 (print_help_for_command): Style the command name using title style.
9401 * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
9402 (_initialize_cli_cmds): Describe -v in apropos_command help.
9403
9404 2019-06-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9405
9406 * cli/cli-style.h (cli_style_option): Add name in constructor,
9407 add m_name class member, add constructor with intensity,
9408 add name class function.
9409 (cli_style_option::add_setshow_commands): Remove name argument.
9410 (highlight_style, title_style): New styles.
9411 * cli/cli-style.c (do_show): New function that shows a style
9412 characteristic styling the style name with itself.
9413 (set_style_name): New function.
9414 (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
9415 Update all callers according to the changes in cli/cli-style.h.
9416 * utils.h (fputs_highlighted): New function.
9417 * utils.c (fputs_highlighted): Likewise.
9418
9419 2019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9420
9421 * NEWS: Mention new pipe command and new convenience variables.
9422
9423 2019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9424
9425 * cli/cli-cmds.c (pipe_command): New function.
9426 (_initialize_cli_cmds): Call add_com for pipe_command.
9427 Define | as an alias for pipe.
9428 (exit_status_set_internal_vars): New function.
9429 (shell_escape): Call exit_status_set_internal_vars.
9430 cli/cli-decode.c (find_command_name_length): Recognize | as
9431 a single character command.
9432
9433 2019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9434
9435 * gdbcmd.h (execute_command_to_ui_file): New declaration.
9436 top.c (execute_command_to_ui_file): New function, mostly a copy
9437 of execute_command_to_string.
9438 (execute_command_to_string): Implement by calling
9439 execute_command_to_ui_file.
9440
9441 2019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9442
9443 * top.h (saved_command_line): Remove declaration.
9444 * top.c (previous_saved_command_line, previous_repeat_arguments):
9445 New variables.
9446 (saved_command_line): Make static, define together with other
9447 'repeat variables'.
9448 (dont_repeat): Clear repeat_arguments.
9449 (repeat_previous, get_saved_command_line, save_command_line):
9450 New functions.
9451 (gdb_init): Initialize saved_command_line
9452 and previous_saved_command_line.
9453 * main.c (captured_main_1): Remove saved_command_line initialization.
9454 * event-top.c (handle_line_of_input): Update to use
9455 the new 'repeat' related functions instead of direct access to
9456 saved_command_line.
9457 * command.h (repeat_previous, get_saved_command_line,
9458 save_command_line): New declarations.
9459 (dont_repeat): Add comment.
9460
9461 2019-05-30 Tom Tromey <tromey@adacore.com>
9462
9463 * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
9464 Fix comment.
9465 (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
9466
9467 2019-05-30 Jan Vrany <jan.vrany@fit.cvut.cz>
9468
9469 PR cli/24587
9470 * completer.c (complete): Initialize variable word.
9471
9472 2019-05-29 Sergio Durigan Junior <sergiodj@redhat.com>
9473
9474 Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
9475 Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
9476 * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
9477 'body' is NULL to the outter 'if', protecting the '!is_define'
9478 situation as well.
9479
9480 2019-05-29 Tom Tromey <tromey@adacore.com>
9481
9482 * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
9483 (dwarf_unknown): New function.
9484 (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
9485 (dwarf_type_encoding_name): Use dwarf_unknown.
9486
9487 2019-05-29 Tom Tromey <tromey@adacore.com>
9488
9489 PR c++/20020:
9490 * cp-valprint.c (cp_print_value_fields): Call
9491 cp_print_static_field inside "try".
9492
9493 2019-05-29 Tom Tromey <tromey@adacore.com>
9494
9495 * inflow.c (struct terminal_info): Add default operator=.
9496 * configure: Rebuild.
9497 * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
9498 -Wdeprecated-copy-dtor, -Wredundant-move.
9499
9500 2019-05-29 Tom Tromey <tromey@adacore.com>
9501
9502 * NEWS: Add entry.
9503 * infcmd.c (print_return_value_1): Handle finish_print
9504 option.
9505 (show_print_finish): New function.
9506 (_initialize_infcmd): Add "set/show print finish" commands.
9507 * valprint.c (user_print_options): Initialize new member.
9508 * valprint.h (struct value_print_options) <finish_print>: New
9509 member.
9510
9511 2019-05-28 Tom Tromey <tromey@adacore.com>
9512
9513 * ada-lang.c (ada_remove_Xbn_suffix)
9514 (find_old_style_renaming_symbol)
9515 (parse_old_style_renaming): Remove.
9516 (ada_find_renaming_symbol): Don't call
9517 find_old_style_renaming_symbol.
9518 (ada_is_renaming_symbol): Rename from
9519 ada_find_renaming_symbol. Remove "block" parameter. Return
9520 bool. Now static.
9521 (ada_read_var_value): Update and simplify.
9522 * ada-exp.y (write_var_or_type): Remove old code.
9523
9524 2019-05-28 Alan Hayward <alan.hayward@arm.com>
9525
9526 PR gdb/25010
9527 * event-top.c: Remove include comment.
9528 * inflow.c (class scoped_ignore_sigttou): Move from here...
9529 * inflow.h (class scoped_ignore_sigttou): ...to here.
9530 * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
9531 * top.c: Remove include comment.
9532
9533 2019-05-27 Tom Tromey <tom@tromey.com>
9534
9535 * NEWS: Fix typo.
9536
9537 2019-05-22 Tom Tromey <tromey@adacore.com>
9538
9539 * target.c (target_follow_exec): Constify parameter.
9540 * target-delegates.c: Rebuild.
9541 * remote.c (remote_target::follow_exec): Constify parameter.
9542 * infrun.c (follow_exec): Constify parameter.
9543 * target.h (struct target_ops) <follow_exec>: Constify parameter.
9544 (target_follow_exec): Likewise.
9545
9546 2019-05-22 Alan Hayward <alan.hayward@arm.com>
9547
9548 * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
9549 DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
9550
9551 2019-05-22 Alan Hayward <alan.hayward@arm.com>
9552
9553 * NEWS: Add debugredirect and testsuite sections.
9554
9555 2019-05-22 Simon Cook <simon.cook@embecosm.com>
9556
9557 * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
9558 target descriptions using exclusively floating point register name
9559 aliases.
9560
9561 2019-05-21 Andrew Burgess <andrew.burgess@embecosm.com>
9562
9563 PR gdb/18644:
9564 * f-lang.c (build_fortran_types): Handle the case where
9565 gdbarch_floatformat_for_type returns a nullptr.
9566
9567 2019-05-21 Tom de Vries <tdevries@suse.de>
9568
9569 PR cli/24587
9570 * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
9571
9572 2019-05-18 Andrew Burgess <andrew.burgess@embecosm.com>
9573
9574 PR gdb/18644:
9575 * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
9576 16-byte floats.
9577 * i386-tdep.c (i386_floatformat_for_type): Use
9578 floatformats_ia64_quad for the 16-byte floating point component
9579 within a fortran 32-byte complex number.
9580
9581 2019-05-18 Andrew Burgess <andrew.burgess@embecosm.com>
9582
9583 * dwarf2read.c (struct cu_partial_die_info): Add constructor,
9584 delete default constructor.
9585 (find_partial_die): Update to return const struct.
9586 (partial_die_parent_scope): Move variable declaration into scope
9587 of its use and change its type to auto.
9588 (guess_partial_die_structure_name): Likewise.
9589 (partial_die_info::fixup): Likewise.
9590
9591 2019-05-17 Tom Tromey <tromey@adacore.com>
9592
9593 * source.c (find_and_open_source): Remove cast.
9594
9595 2019-05-17 Tom Tromey <tromey@adacore.com>
9596
9597 * annotate.c (annotate_source): Make "filename" const.
9598 * annotate.h (annotate_source): Use const.
9599
9600 2019-05-17 Alan Hayward <alan.hayward@arm.com>
9601
9602 * disasm.c (set_disassembler_options): Send errors to stderr.
9603
9604 2019-05-17 Alan Hayward <alan.hayward@arm.com>
9605
9606 * cli/cli-interp.c (struct saved_output_files): Add saved entry.
9607 (cli_interp_base::set_logging): Check debug_redirect.
9608 * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
9609 * cli/cli-logging.c (debug_redirect): Add static variable.
9610 (pop_output_files): Add default param.
9611 (handle_redirections): Print debug setting.
9612 (show_logging_command): Likewise.
9613 (_initialize_cli_logging): Add debugredirect command.
9614 * interps.c (current_interp_set_logging): Add debug_redirect
9615 parameter.
9616 * interps.h (set_logging): Add debug_redirect parameter.
9617 (current_interp_set_logging): Likewise.
9618 * mi/mi-common.h: Likewise.
9619 * mi/mi-interp.c (mi_interp::set_logging): Likewise.
9620
9621 2019-05-17 Alan Hayward <alan.hayward@arm.com>
9622 Tom Tromey <tromey@adacore.com>
9623
9624 * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
9625 directly.
9626 * cli/cli-interp.h (make_logging_output): Remove declaration.
9627 * cli/cli-logging.c (make_logging_output): Remove function.
9628 * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
9629 directly.
9630 * ui-file.c (tee_file::tee_file): Remove bools.
9631 (tee_file::~tee_file): Remove deletes.
9632 * ui-file.h (tee_file): Remove bools.
9633
9634 2019-01-28 Jan Vrany <jan.vrany@fit.cvut.cz>
9635
9636 * mi/mi-cmds.h (mi_cmd_complete): New function.
9637 * mi/mi-main.c (mi_cmd_complete): Likewise.
9638 * mi/mi-cmds.c: Define new MI command -complete.
9639 * NEWS: Mention new -complete command.
9640
9641 2019-01-24 Jan Vrany <jan.vrany@fit.cvut.cz>
9642
9643 * completer.h (complete): New function.
9644 * completer.c (complete): Likewise.
9645 * cli/cli-cmds.c: (complete_command): Update to use new complete()
9646 function defined in completer.h.
9647
9648 2019-05-17 Jan Vrany <jan.vrany@fit.cvut.cz>
9649
9650 * MAINTAINERS (Write After Approval): Add myself.
9651
9652 2019-05-17 Tom de Vries <tdevries@suse.de>
9653
9654 PR gdb/24094
9655 * dwarf2read.c (struct cu_partial_die_info): New struct.
9656 (find_partial_die): Return cu_partial_die_info.
9657 (partial_die_parent_scope, guess_partial_die_structure_name)
9658 (partial_die_info::fixup): Handle new return type of find_partial_die.
9659
9660 2019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
9661
9662 PR breakpoints/24541
9663 * stap-probe.c (stap_parse_register_operand): Make "regname" an
9664 "std::string", simplifying the algorithm.
9665
9666 2019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
9667
9668 * stap-probe.c (handle_stap_probe): Fix complaint formatting.
9669 (stap_static_probe_ops::get_probes): Likewise.
9670
9671 2019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
9672
9673 * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
9674 '-')" and "else if".
9675 (stap_parse_single_operand): Join checks for
9676 "gdbarch_stap_parse_special_token_p" and
9677 "gdbarch_stap_parse_special_token" in the same "if" statement.
9678 Invert check when verifying for operation on register
9679 displacement.
9680
9681 2019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
9682
9683 * stap-probe.c (stap_get_opcode): Update comment.
9684 (stap_get_expected_argument_type): Likewise.
9685 (handle_stap_probe): Likewise.
9686
9687 2019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
9688
9689 * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
9690 return type to 'bool'. Adjust comment. Use 'bool' when
9691 appropriate.
9692 (i386_stap_parse_special_token_three_arg_disp): Likewise.
9693 * stap-probe.c (stap_parse_argument_1): Likewise.
9694 (stap_is_operator): Likewise.
9695 (stap_is_generic_prefix): Likewise.
9696 (stap_is_register_prefix): Likewise.
9697 (stap_is_register_indirection_prefix): Likewise.
9698 (stap_is_integer_prefix): Likewise.
9699 (stap_generic_check_suffix): Likewise.
9700 (stap_check_integer_suffix): Likewise.
9701 (stap_check_register_suffix): Likewise.
9702 (stap_check_register_indirection_suffix): Likewise.
9703 (stap_parse_register_operand): Likewise.
9704 (stap_parse_single_operand): Likewise.
9705 (stap_parse_argument_1): Likewise.
9706 (stap_probe::get_argument_count): Likewise.
9707 (stap_is_operator): Likewise.
9708
9709 2019-05-16 Tom Tromey <tromey@adacore.com>
9710
9711 * darwin-nat.c (thread_info_from_private_thread_info): Add struct
9712 keyword to foreach.
9713
9714 2019-05-15 Simon Marchi <simon.marchi@efficios.com>
9715
9716 * linux-thread-db.c (try_thread_db_load_1): Change return type
9717 to bool.
9718 (try_thread_db_load): Likewise.
9719 (try_thread_db_load_from_pdir_1): Likewise.
9720 (try_thread_db_load_from_pdir): Likewise.
9721 (try_thread_db_load_from_sdir): Likewise.
9722 (try_thread_db_load_from_dir): Likewise.
9723 (thread_db_load_search): Likewise.
9724 (has_libpthread): Likewise.
9725 (thread_db_load): Likewise.
9726
9727 2019-05-15 Sergio Durigan Junior <sergiodj@redhat.com>
9728
9729 Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
9730 * dwarf2read.c (parse_macro_definition): Check whether 'body' is
9731 NULL, and complain/return if that's the case.
9732
9733 2019-05-15 John Darrington <john@darrington.wattle.id.au>
9734
9735 * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
9736 (advance, posn, abstract_read_memory): New functions.
9737 [struct mem_read_abstraction]: New struct.
9738 (s12z_frame_cache): Use opcodes API to interpret stack frame code.
9739
9740 2019-05-14 Tom Tromey <tromey@adacore.com>
9741
9742 * ada-lang.c (coerce_unspec_val_to_type): Only set address when
9743 value is not lval_memory.
9744
9745 2019-05-14 Tom Tromey <tromey@adacore.com>
9746
9747 * solib.c (info_sharedlibrary_command): Style the file name.
9748
9749 2019-05-14 Alan Hayward <alan.hayward@arm.com>
9750
9751 * aarch64-tdep.c (aarch64_vnh_type): Add half view.
9752 (aarch64_vnv_type): Likewise.
9753 * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
9754 * common/tdesc.c: Likewise.
9755 * common/tdesc.h (enum tdesc_type_kind): Likewise.
9756 * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
9757 * features/aarch64-fpu.xml: Add ieee half view.
9758 * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
9759 * gdbtypes.c (gdbtypes_post_init): Add builtin_half
9760 * gdbtypes.h (struct builtin_type): Likewise.
9761 (struct objfile_type): Likewise.
9762
9763 2019-05-12 Paul Naert <paul.naert@polymtl.ca>
9764
9765 * language.c (language_sniff_from_mangled_name): Fix "langauge"
9766 typo.
9767 * location.h (string_to_event_location): Likewise.
9768
9769 2019-05-11 Joel Brobecker <brobecker@adacore.com>
9770
9771 GDB 8.3 released.
9772
9773 2019-05-10 Simon Marchi <simon.marchi@efficios.com>
9774
9775 * breakpoint.h (fix_multi_location_breakpoint_output_globally):
9776 New variable declaration.
9777 * breakpoint.c (fix_multi_location_breakpoint_output_globally):
9778 New variable.
9779 (print_one_breakpoint): Use ui_out::test_flags and new global
9780 variable to compute use_fixed_output.
9781 * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
9782 Remove.
9783 * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
9784 (mi_multi_location_breakpoint_output_fixed): Remove.
9785 (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
9786 new variable.
9787 * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
9788 fix_multi_location_breakpoint_output flag if version >= 3.
9789 * ui-out.h (enum ui_out_flag)
9790 <fix_multi_location_breakpoint_output>: New enumerator.
9791
9792 2019-05-10 Simon Marchi <simon.marchi@efficios.com>
9793
9794 * contrib/cc-with-tweaks.sh: Validate dwz's work.
9795
9796 2019-05-10 Tom Tromey <tromey@adacore.com>
9797
9798 * ada-lang.c (catch_ada_completer): New function.
9799 (_initialize_ada_language): Use it.
9800
9801 2019-05-10 Tom Tromey <tromey@adacore.com>
9802
9803 * thread.c (print_thread_info): Make "requested_threads" const.
9804 * gdbthread.h (print_thread_info): Make "requested_threads"
9805 const.
9806 * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
9807 * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
9808
9809 2019-05-08 Tom Tromey <tom@tromey.com>
9810
9811 * gdbtypes.c (objfile_type_data): Change type.
9812 (objfile_type, _initialize_gdbtypes): Update.
9813
9814 2019-05-08 Tom Tromey <tom@tromey.com>
9815
9816 * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
9817 (dwarf2_frame_find_fde, dwarf2_build_frame_info)
9818 (_initialize_dwarf2_frame): Update.
9819
9820 2019-05-08 Tom Tromey <tom@tromey.com>
9821
9822 * objc-lang.c (objc_objfile_data): Change type.
9823 (find_methods): Update.
9824 (_initialize_objc_lang): Remove.
9825
9826 2019-05-08 Tom Tromey <tom@tromey.com>
9827
9828 * stabsread.c (rs6000_builtin_type_data): Change type.
9829 (rs6000_builtin_type, _initialize_stabsread): Update.
9830
9831 2019-05-08 Tom Tromey <tom@tromey.com>
9832
9833 * mips-tdep.c (mips_pdr_data): Remove.
9834 (_initialize_mips_tdep): Update.
9835
9836 2019-05-08 Tom Tromey <tom@tromey.com>
9837
9838 * hppa-tdep.c (hppa_objfile_priv_data): Change type.
9839 (hppa_init_objfile_priv_data, read_unwind_info)
9840 (find_unwind_entry, _initialize_hppa_tdep): Update.
9841
9842 2019-05-08 Tom Tromey <tom@tromey.com>
9843
9844 * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
9845 (elf_gnu_ifunc_record_cache): Update. Don't allocate hash table
9846 on obstack.
9847 (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
9848
9849 2019-05-08 Tom Tromey <tom@tromey.com>
9850
9851 * mdebugread.c (basic_type_data): Change type.
9852 (basic_type, _initialize_mdebugread): Update.
9853
9854 2019-05-08 Tom Tromey <tom@tromey.com>
9855
9856 * common/gdb_unique_ptr.h (struct noop_deleter): New.
9857
9858 2019-05-08 Tom Tromey <tom@tromey.com>
9859
9860 * nto-tdep.c (nto_inferior_data_reg): Change type.
9861 (nto_inferior_data): Update.
9862 (nto_inferior_data_cleanup, nto_new_inferior_data)
9863 (_initialize_nto_tdep): Remove.
9864 * nto-tdep.h (struct nto_inferior_data): Add initializers.
9865
9866 2019-05-08 Tom Tromey <tom@tromey.com>
9867
9868 * ada-lang.c (struct ada_inferior_data): Add initializers.
9869 (ada_inferior_data): Change type.
9870 (ada_inferior_data_cleanup): Remove.
9871 (get_ada_inferior_data, ada_inferior_exit)
9872 (struct ada_pspace_data): Add initializers, destructor.
9873 (ada_pspace_data_handle): Change type.
9874 (get_ada_pspace_data): Update.
9875 (ada_pspace_data_cleanup): Remove.
9876
9877 2019-05-08 Tom Tromey <tom@tromey.com>
9878
9879 * coffread.c (struct coff_symfile_info): Add initializers.
9880 (coff_objfile_data_key): Move lower. Change type.
9881 (coff_symfile_init, coff_symfile_read, _initialize_coffread):
9882 Update.
9883 (coff_free_info): Remove.
9884
9885 2019-05-08 Tom Tromey <tom@tromey.com>
9886
9887 * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
9888 (fbsd_pspace_data_handle): Move lower. Change type.
9889 (get_fbsd_pspace_data): Update.
9890 (fbsd_pspace_data_cleanup): Remove.
9891 (_initialize_fbsd_tdep): Update.
9892
9893 2019-05-08 Tom Tromey <tom@tromey.com>
9894
9895 * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
9896 (get_ada_tasks_pspace_data): Update.
9897 (ada_tasks_pspace_data_cleanup): Remove.
9898 (_initialize_tasks): Update.
9899 (ada_tasks_inferior_data_handle): Change type.
9900 (get_ada_tasks_inferior_data): Update.
9901 (ada_tasks_inferior_data_cleanup): Remove.
9902 (struct ada_tasks_pspace_data): Add initializers.
9903
9904 2019-05-08 Tom Tromey <tom@tromey.com>
9905
9906 * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
9907 * symfile-debug.c (debug_sym_get_probes): Change type.
9908 * stap-probe.c (handle_stap_probe):
9909 (stap_static_probe_ops::get_probes): Change type.
9910 * probe.h (class static_probe_ops) <get_probes>: Change type.
9911 * probe.c (class any_static_probe_ops) <get_probes>: Change type.
9912 (parse_probes_in_pspace): Update.
9913 (find_probes_in_objfile, find_probe_by_pc, collect_probes):
9914 Update.
9915 (any_static_probe_ops::get_probes): Change type.
9916 * elfread.c (elfread_data): New typedef.
9917 (probe_key): Change type.
9918 (elf_get_probes): Likewise. Update.
9919 (probe_key_free): Remove.
9920 (_initialize_elfread): Update.
9921 * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
9922 Change type.
9923 (dtrace_process_dof_probe, dtrace_process_dof)
9924 (dtrace_static_probe_ops::get_probe): Change type.
9925
9926 2019-05-08 Tom Tromey <tom@tromey.com>
9927
9928 * xcoffread.c (struct xcoff_symfile_info): Rename from
9929 coff_symfile_info. Add initializers.
9930 (xcoff_objfile_data_key): Move lower. Change type.
9931 (XCOFF_DATA): Rewrite.
9932 (xcoff_free_info): Remove.
9933 (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
9934 (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
9935 (xcoff_initial_scan): Update.
9936
9937 2019-05-08 Tom Tromey <tom@tromey.com>
9938
9939 * solib-svr4.c (struct svr4_info): Add initializers and
9940 destructor.
9941 <probes_table>: Now an htab_up.
9942 (solib_svr4_pspace_data): Change type.
9943 (free_probes_table): Simplify.
9944 (~svr4_info): Rename from svr4_pspace_data_cleanup.
9945 (get_svr4_info, probes_table_htab_remove_objfile_probes)
9946 (probes_table_remove_objfile_probes, register_solib_event_probe)
9947 (solib_event_probe_at, svr4_update_solib_event_breakpoint)
9948 (_initialize_svr4_solib): Update.
9949
9950 2019-05-08 Tom Tromey <tom@tromey.com>
9951
9952 * remote.c (remote_pspace_data): Change type.
9953 (remote_pspace_data_cleanup): Remove.
9954 (get_remote_exec_file, set_pspace_remote_exec_file)
9955 (_initialize_remote): Update.
9956
9957 2019-05-08 Tom Tromey <tom@tromey.com>
9958
9959 * breakpoint.c (breakpoint_objfile_key): Change type.
9960 (get_breakpoint_objfile_data): Update.
9961 (free_breakpoint_objfile_data): Remove.
9962 (_initialize_breakpoint): Update.
9963
9964 2019-05-08 Tom Tromey <tom@tromey.com>
9965
9966 * linux-tdep.c (struct linux_info): Add initializers.
9967 (linux_inferior_data): Move. Change type.
9968 (invalidate_linux_cache_inf): Update.
9969 (linux_inferior_data_cleanup): Remove.
9970 (get_linux_inferior_data, _initialize_linux_tdep): Update.
9971
9972 2019-05-08 Tom Tromey <tom@tromey.com>
9973
9974 * auxv.c (auxv_inferior_data): Move. Change type.
9975 (auxv_inferior_data_cleanup): Remove.
9976 (invalidate_auxv_cache_inf): Rewrite.
9977 (get_auxv_inferior_data, _initialize_auxv): Update.
9978
9979 2019-05-08 Tom Tromey <tom@tromey.com>
9980
9981 * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
9982 (symfile_debug_objfile_data_key): Change type.
9983 (symfile_debug_installed, debug_qf_has_symbols)
9984 (debug_qf_find_last_source_symtab)
9985 (debug_qf_forget_cached_source_info)
9986 (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
9987 (debug_qf_print_stats, debug_qf_dump)
9988 (debug_qf_expand_symtabs_for_function)
9989 (debug_qf_expand_all_symtabs)
9990 (debug_qf_expand_symtabs_with_fullname)
9991 (debug_qf_map_matching_symbols)
9992 (debug_qf_expand_symtabs_matching)
9993 (debug_qf_find_pc_sect_compunit_symtab)
9994 (debug_qf_map_symbol_filenames)
9995 (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
9996 (debug_sym_new_init, debug_sym_init, debug_sym_read)
9997 (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
9998 (debug_sym_read_linetable, debug_sym_relocate): Update.
9999 (symfile_debug_free_objfile): Remove.
10000 (install_symfile_debug_logging, _initialize_symfile_debug):
10001 Update.
10002
10003 2019-05-08 Tom Tromey <tom@tromey.com>
10004
10005 * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
10006 allocate_on_obstack.
10007 * dwarf2read.c (dwarf2_objfile_data_key): Change type.
10008 (get_dwarf2_per_objfile): Update.
10009 (set_dwarf2_per_objfile): Remove.
10010 (dwarf2_has_info, dwarf2_get_section_info): Update.
10011 (dwarf2_free_objfile): Remove.
10012 (_initialize_dwarf2_read): Update.
10013
10014 2019-05-08 Tom Tromey <tom@tromey.com>
10015
10016 * auto-load.c (struct auto_load_pspace_info): Add destructor and
10017 initializers.
10018 <unsupported_script_warning_printed,
10019 script_not_found_warning_printed>: Now bool.
10020 (auto_load_pspace_data): Change type.
10021 (~auto_load_pspace_info): Rename from
10022 auto_load_pspace_data_cleanup.
10023 (get_auto_load_pspace_data, init_loaded_scripts_info)
10024 (clear_section_scripts, maybe_print_unsupported_script_warning)
10025 (maybe_print_script_not_found_warning, _initialize_auto_load):
10026 Update.
10027
10028 2019-05-08 Tom Tromey <tom@tromey.com>
10029
10030 * objfiles.c (objfile_pspace_info): Add destructor and
10031 initializers.
10032 (objfiles_pspace_data): Change type.
10033 (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
10034 (get_objfile_pspace_data): Update.
10035 (objfiles_bfd_data): Change type.
10036 (get_objfile_bfd_data): Update.
10037 (objfile_bfd_data_free, _initialize_objfiles): Remove.
10038
10039 2019-05-08 Tom Tromey <tom@tromey.com>
10040
10041 * break-catch-syscall.c (catch_syscall_inferior_data): Move.
10042 Change type.
10043 (get_catch_syscall_inferior_data): Update.
10044 (catch_syscall_inferior_data_cleanup): Remove.
10045 (_initialize_break_catch_syscall): Update.
10046
10047 2019-05-08 Tom Tromey <tom@tromey.com>
10048
10049 * inflow.c (struct terminal_info): Add destructor and
10050 initializers.
10051 (inflow_inferior_data): Change type.
10052 (~terminal_info): Rename from inflow_inferior_data_cleanup.
10053 (get_inflow_inferior_data, inflow_inferior_exit)
10054 (swap_terminal_info, _initialize_inflow): Update.
10055
10056 2019-05-08 Tom Tromey <tom@tromey.com>
10057
10058 * target-dcache.c (target_dcache_cleanup): Remove.
10059 (target_dcache_aspace_key): Change type.
10060 (target_dcache_init_p, target_dcache_invalidate)
10061 (target_dcache_get, target_dcache_get_or_init)
10062 (_initialize_target_dcache): Update.
10063 * dcache.h (struct dcache_deleter): New.
10064
10065 2019-05-08 Tom Tromey <tom@tromey.com>
10066
10067 * symtab.c (struct symbol_cache): Add destructor and
10068 initializers.
10069 (symbol_cache_key): Move. Change type.
10070 (make_symbol_cache, free_symbol_cache): Remove.
10071 (get_symbol_cache): Update.
10072 (symbol_cache_cleanup): Remove.
10073 (ALL_PSPACES, symbol_cache_flush)
10074 (maintenance_print_symbol_cache)
10075 (maintenance_print_symbol_cache_statistics, _initialize_symtab):
10076 Update.
10077
10078 2019-05-08 Tom Tromey <tom@tromey.com>
10079
10080 * symtab.c (struct main_info): Add destructor and initializers.
10081 (main_progspace_key): Move. Change type.
10082 (get_main_info): Update.
10083 (main_info_cleanup): Remove.
10084 (_initialize_symtab): Update.
10085
10086 2019-05-08 Tom Tromey <tom@tromey.com>
10087
10088 * registry.h (DECLARE_REGISTRY): Define the _key class.
10089
10090 2019-05-08 Andrew Burgess <andrew.burgess@embecosm.com>
10091
10092 * NEWS: Merge two 'New commands' sections.
10093
10094 2019-05-08 Joel Brobecker <brobecker@adacore.com>
10095
10096 * ada-valprint.c (ada_val_print_gnat_array): Remove language
10097 parameter and use Ada language definition instead.
10098 (ada_val_print_ptr): Remove unused language parameter.
10099 (ada_val_print_num): Remove language parameter and use Ada language
10100 definition instead.
10101 (ada_val_print_enum, ada_val_print_flt): Remove unused language
10102 parameter.
10103 (ada_val_print_struct_union, ada_val_print_ref): Remove language
10104 parameter and use Ada language definition instead.
10105 (ada_val_print_1): Update all ada_val_print_xxx calls.
10106 Remove language parameter.
10107 (ada_val_print): Update ada_val_print_1 call.
10108
10109 2019-05-08 Tom Tromey <tromey@adacore.com>
10110
10111 * remote.c (remote_hw_watchpoint_limit)
10112 (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
10113 Now static.
10114
10115 2019-05-08 Tom Tromey <tromey@adacore.com>
10116
10117 * maint.c (_initialize_maint_cmds): Move initialization code to
10118 remote.c.
10119 (watchdog, show_watchdog): Move to remote.c.
10120 * remote.c (watchdog, show_watchdog): Move from maint.c. Make
10121 "watchdog" static.
10122 (_initialize_remote): Move initialization code from maint.c.
10123 * defs.h (watchdog): Don't declare.
10124
10125 2019-05-08 Tom Tromey <tromey@adacore.com>
10126
10127 * tui/tui-interp.c: Include main.h.
10128 * interps.c: Include main.h.
10129 * main.h (interpreter_p): Declare.
10130 * defs.h (interpreter_p): Don't declare.
10131
10132 2019-05-08 Tom Tromey <tromey@adacore.com>
10133
10134 * dwarf2loc.c: Include dwarf2read.h.
10135 * defs.h (read_unsigned_leb128): Don't declare.
10136 * dwarf2read.h (read_unsigned_leb128): Declare.
10137
10138 2019-05-08 Tom Tromey <tromey@adacore.com>
10139
10140 * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
10141 method.
10142
10143 2019-05-08 Tom Tromey <tromey@adacore.com>
10144
10145 * utils.c (fputs_maybe_filtered): Reset style after paging, even
10146 when no wrap column is set.
10147
10148 2019-05-08 Tom Tromey <tromey@adacore.com>
10149
10150 * c-lang.c (c_get_string): Handle non-C-style arrays.
10151
10152 2019-05-08 Tom Tromey <tromey@adacore.com>
10153
10154 * typeprint.c (print_offset_data::update): Print the bit offset,
10155 not the number of bits remaining.
10156
10157 2019-05-08 Tom Tromey <tromey@adacore.com>
10158
10159 * typeprint.c (print_offset_data::maybe_print_hole): Add extra
10160 padding at end of comment.
10161
10162 2019-05-08 Tom Tromey <tromey@adacore.com>
10163
10164 * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
10165 Compare main types.
10166
10167 2019-05-06 Tom Tromey <tom@tromey.com>
10168
10169 * common/scoped_mmap.c: Include common-defs.h.
10170 * common/scoped_mmap.h: Don't include config.h.
10171
10172 2019-05-04 Tom Tromey <tom@tromey.com>
10173
10174 * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
10175 (struct aarch64_call_info): Add initializers.
10176 <si>: Now a std::vector.
10177 (pass_on_stack, aarch64_push_dummy_call): Update.
10178
10179 2019-05-04 Simon Marchi <simon.marchi@efficios.com>
10180 Tom Tromey <tom@tromey.com>
10181
10182 * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
10183 (ppc_threads): Now a std::vector. Now static.
10184 (hwdebug_find_thread_points_by_tid)
10185 (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
10186 Update.
10187
10188 2019-05-04 Tom Tromey <tom@tromey.com>
10189
10190 * arc-tdep.c (arc_tdesc_init): Return bool.
10191
10192 2019-05-04 Tom Tromey <tom@tromey.com>
10193
10194 * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
10195 Use gdb_assert_not_reached.
10196
10197 2019-05-04 Tom Tromey <tom@tromey.com>
10198
10199 * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
10200 "false".
10201
10202 2019-05-04 Tom Tromey <tom@tromey.com>
10203
10204 * arc-tdep.c (arc_tdesc_init): Use bool.
10205
10206 2019-05-04 Tom Tromey <tom@tromey.com>
10207
10208 * stack.c (select_frame_for_mi): Use "false", not "FALSE".
10209
10210 2019-05-04 Tom Tromey <tom@tromey.com>
10211
10212 * cli/cli-cmds.c (valid_command_p): Return bool.
10213
10214 2019-05-04 Tom Tromey <tom@tromey.com>
10215
10216 * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
10217 * command.h (valid_user_defined_cmd_name_p): Channge return type.
10218
10219 2019-05-04 Raul Tambre <raul@tambre.ee>
10220
10221 * python/lib/gdb/prompt.py (_ExtendedPrompt)
10222 <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
10223 operator for comparison.
10224
10225 2019-05-04 Tom Tromey <tom@tromey.com>
10226
10227 * psymtab.c (psymbol_name_matches, match_partial_symbol)
10228 (lookup_partial_symbol, print_partial_symbols)
10229 (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
10230 (psymbol_compare): Update.
10231 (add_psymbol_to_bcache): Clear the entire psymbol.
10232 (maintenance_check_psymtabs): Update.
10233 * psympriv.h (struct partial_symbol): Don't derive from
10234 general_symbol_info.
10235 <obj_section, unrelocated_address, address,
10236 set_unrelocated_address>: Update.
10237 <ginfo>: New member.
10238 * dwarf-index-write.c (write_psymbols, debug_names::insert)
10239 (debug_names::write_psymbols): Update.
10240
10241 2019-05-04 Tom de Vries <tdevries@suse.de>
10242
10243 * contrib/cc-with-tweaks.sh: Support -n arg.
10244
10245 2019-05-04 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10246
10247 * corelow.c (core_target::detach): Ensure frame cache and
10248 register caches are cleared.
10249 inferior.c (exit_inferior_1): Likewise.
10250
10251 2019-05-03 Sandra Loosemore <sandra@codesourcery.com>
10252 Tom Tromey <tom@tromey.com>
10253
10254 * dictionary.c (collate_pending_symbols_by_language): Remove
10255 "struct" from foreach.
10256 * symtab.c (lookup_global_symbol_from_objfile)
10257 (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
10258 foreach.
10259 * ser-tcp.c (net_open): Remove "struct" from foreach.
10260 * objfiles.c (objfile_relocate, objfile_rebase)
10261 (objfile_has_symbols): Remove "struct" from foreach.
10262 * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
10263 from foreach.
10264 * dwarf2read.c (handle_struct_member_die): Remove "struct" from
10265 foreach.
10266 * darwin-nat.c (thread_info_from_private_thread_info): Remove
10267 "struct" from foreach.
10268 * ada-lang.c (create_excep_cond_exprs)
10269 (ada_exception_catchpoint_cond_string): Remove "struct" from
10270 foreach.
10271
10272 2019-05-03 Tom Tromey <tromey@adacore.com>
10273
10274 * ada-exp.y (convert_char_literal): Check suffix of each
10275 enumerator.
10276
10277 2019-05-03 Dilyan Palauzov <dilyan.palauzov@aegee.org>
10278
10279 PR ada/21406:
10280 * ada-exp.y (yywrap): Don't define.
10281 * ada-lex.l (%option): Add noyywrap
10282 (yywrap): Remove.
10283
10284 2019-05-03 Eli Zaretskii <eliz@gnu.org>
10285
10286 * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
10287 _WIN32_WINNT to the XP level, unless already defined to a higher
10288 level.
10289
10290 * unittests/parse-connection-spec-selftests.c:
10291 * ser-tcp.c:
10292 * common/netstuff.c [USE_WIN32API]: Remove the _WIN32_WINNT
10293 override.
10294
10295 * symfile.c (find_separate_debug_file): Remove colon from the
10296 drive spec of DOS/Windows file names of the target, so that the
10297 file name produced from DEBUGDIR and the target's directory will
10298 be valid on DOS/Windows systems.
10299
10300 2019-05-02 Andrew Burgess <andrew.burgess@embecosm.com>
10301
10302 * rust-lang.c (val_print_struct): Handle printing structures
10303 containing strings.
10304
10305 2019-05-02 Tom Tromey <tromey@adacore.com>
10306
10307 * valarith.c (_initialize_valarith): Remove.
10308
10309 2019-05-01 Tom Tromey <tromey@adacore.com>
10310
10311 * ada-lang.c (ada_value_primitive_field): Treat more fields as
10312 bitfields.
10313
10314 2019-05-01 Tom Tromey <tromey@adacore.com>
10315
10316 * ada-lang.c (ada_value_assign): Correctly compute starting offset
10317 for big-endian copies.
10318
10319 2019-04-30 Ali Tamur <tamur@google.com>
10320 * gdb/dwarf2read.c (read_3_bytes): New declaration.
10321 (read_attribute_value): Added DW_FORM_strx1-4 cases.
10322 (read_3_bytes): New function.
10323
10324 2019-04-30 Joel Brobecker <brobecker@adacore.com>
10325
10326 * windows-nat.c (main_thread_id): Delete.
10327 (handle_output_debug_string): Replace main_thread_id by
10328 current_event.dwThreadId.
10329 (fake_create_process): Likewise.
10330 (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
10331 Do not set main_thread_id.
10332 <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
10333 current_event.dwThreadId.
10334 <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
10335
10336 2019-04-30 Joel Brobecker <brobecker@adacore.com>
10337
10338 * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
10339 Use current_event.dwThreadId instead of main_thread_id.
10340
10341 2019-04-30 Tom Tromey <tromey@adacore.com>
10342
10343 * ada-lang.c (ada_lookup_simple_minsyms): New function.
10344 (create_excep_cond_exprs): Iterate over program spaces.
10345 (ada_exception_catchpoint_cond_string): Examine all minimal
10346 symbols for exception types.
10347
10348 2019-04-30 Tom Tromey <tromey@adacore.com>
10349
10350 PR c++/24470:
10351 * dwarf2read.c (process_structure_scope): Handle case where type
10352 has template parameters but no symbol was created.
10353
10354 2019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10355 Chris January <chris.january@arm.com>
10356
10357 * f-typeprint.c (f_type_print_base): Print 'allocatable' type
10358 qualifier.
10359 * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
10360
10361 2019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10362
10363 * f-typeprint.c (f_print_type): Update rules for printing
10364 whitespace.
10365 (f_type_print_varspec_suffix): Likewise.
10366
10367 2019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10368 Chris January <chris.january@arm.com>
10369
10370 * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
10371 function arguments.
10372
10373 2019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10374
10375 * f-lang.c (build_fortran_types): Change name of void type to
10376 lower case.
10377 * f-typeprint.c (f_type_print_base): Print the name of the void
10378 type, rather than a fixed string.
10379 * f-valprint.c (f_decorations): Use lower case void string.
10380
10381 2019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10382 Chris January <chris.january@arm.com>
10383
10384 * dwarf2read.c (dwarf2_init_complex_target_type): Use different
10385 types for Fortran.
10386
10387 2019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10388 Chris January <chris.january@arm.com>
10389 David Lecomber <david.lecomber@arm.com>
10390
10391 * f-exp.y (BINOP_INTRINSIC): New token.
10392 (exp): New parser rule handling BINOP_INTRINSIC.
10393 (f77_keywords): Add new builtin procedures.
10394 * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
10395 UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
10396 (operator_length_f): Handle UNOP_FORTRAN_CEILING,
10397 UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
10398 (print_unop_subexp_f): New function.
10399 (print_binop_subexp_f): New function.
10400 (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
10401 BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
10402 (dump_subexp_body_f): Likewise.
10403 (operator_check_f): Likewise.
10404 * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
10405 BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
10406
10407 2019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10408
10409 * gdb/expprint.c (dump_subexp_body_standard): Remove use of
10410 UNOP_KIND.
10411 * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
10412 * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
10413 * gdb/f-lang.c (evaluate_subexp_f): Likewise.
10414 (operator_length_f): New fuction.
10415 (print_subexp_f): New function.
10416 (op_name_f): New function.
10417 (dump_subexp_body_f): New function.
10418 (operator_check_f): New function.
10419 (exp_descriptor_f): Replace standard expression handling functions
10420 with new functions.
10421 * gdb/fortran-operator.def: New file.
10422 * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
10423 * gdb/std-operator.def: Remove UNOP_KIND.
10424
10425 2019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10426
10427 * std-operator.def: Remove unbalanced, stray double quote
10428 character.
10429
10430 2019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
10431 Chris January <chris.january@arm.com>
10432 Daniel Everett <daniel.everett@arm.com>
10433 Nick Forrington <nick.forrington@arm.com>
10434 Richard Bunt <richard.bunt@arm.com>
10435
10436 * cp-valprint.c (cp_print_value_fields): Allow an additional level
10437 of depth when printing anonymous structs or unions.
10438 * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
10439 Don't print either the top-level value, or the children if the
10440 max-depth is exceeded.
10441 (ppscm_print_children): When printing the key of a map, allow one
10442 extra level of depth.
10443 * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
10444 print either the top-level value, or the children if the max-depth
10445 is exceeded.
10446 (print_children): When printing the key of a map, allow one extra
10447 level of depth.
10448 * python/py-value.c (valpy_format_string): Add max_depth keyword.
10449 * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
10450 (user_print_options): Initialise max_depth field.
10451 (val_print_scalar_or_string_type_p): New function.
10452 (val_print): Check to see if the max depth has been reached.
10453 (val_print_check_max_depth): Define new function.
10454 (show_print_max_depth): New function.
10455 (_initialize_valprint): Add 'print max-depth' option.
10456 * valprint.h (struct value_print_options) <max_depth>: New field.
10457 (val_print_check_max_depth): Declare new function.
10458 * NEWS: Document new feature.
10459
10460 2019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
10461
10462 * ada-lang.c (ada_language_defn): Initialise new field.
10463 * c-lang.c (c_is_string_type_p): New function.
10464 (c_language_defn): Initialise new field.
10465 (cplus_language_defn): Initialise new field.
10466 (asm_language_defn): Initialise new field.
10467 (minimal_language_defn): Initialise new field.
10468 * c-lang.h (c_is_string_type_p): Declare new function.
10469 * d-lang.c (d_language_defn): Initialise new field.
10470 * f-lang.c (f_is_string_type_p): New function.
10471 (f_language_defn): Initialise new field.
10472 * go-lang.c (go_is_string_type_p): New function.
10473 (go_language_defn): Initialise new field.
10474 * language.c (default_is_string_type_p): New function.
10475 (unknown_language_defn): Initialise new field.
10476 (auto_language_defn): Initialise new field.
10477 * language.h (struct language_defn) <la_is_string_type_p>: New
10478 member variable.
10479 (default_is_string_type_p): Declare new function.
10480 * m2-lang.c (m2_language_defn): Initialise new field.
10481 * objc-lang.c (objc_language_defn): Initialise new field.
10482 * opencl-lang.c (opencl_language_defn): Initialise new field.
10483 * p-lang.c (pascal_is_string_type_p): New function.
10484 (pascal_language_defn): Initialise new field.
10485 * rust-lang.c (rust_is_string_type_p): New function.
10486 (rust_language_defn): Initialise new field.
10487
10488 2019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
10489
10490 * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
10491 New field.
10492 * ada-lang.c (ada_language_defn): Initialise new field.
10493 * c-lang.c (c_language_defn): Likewise.
10494 (cplus_language_defn): Likewise.
10495 (asm_language_defn): Likewise.
10496 (minimal_language_defn): Likewise.
10497 * d-lang.c (d_language_defn): Likewise.
10498 * f-lang.c (f_language_defn): Likewise.
10499 * go-lang.c (go_language_defn): Likewise.
10500 * language.c (unknown_language_defn): Likewise.
10501 (auto_language_defn): Likewise.
10502 * m2-lang.c (m2_language_defn): Likewise.
10503 * objc-lang.c (objc_language_defn): Likewise.
10504 * opencl-lang.c (opencl_language_defn): Likewise.
10505 * p-lang.c (pascal_language_defn): Likewise.
10506 * rust-lang.c (rust_language_defn): Likewise.
10507
10508 2019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
10509
10510 * ada-lang.c (ada_is_character_type): Change return type to bool.
10511 (ada_is_string_type): Likewise.
10512 * ada-lang.h (ada_is_character_type): Update declaration
10513 (ada_is_string_type): Likewise.
10514
10515 2019-04-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10516
10517 Support style in 'frame|thread apply'
10518
10519 * gdbcmd.h (execute_command_to_string): New term_out parameter.
10520 * record.c (record_start, record_stop): Update callers of
10521 execute_command_to_string with false.
10522 * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
10523 * ui-file.h (class ui_file): New term_out and can_emit_style_escape
10524 methods.
10525 (class string_file): New constructor with term_out parameter.
10526 Override methods term_out and can_emit_style_escape. New member
10527 term_out.
10528 (class stdio_file): Override can_emit_style_escape.
10529 (class tee_file): Override term_out and can_emit_style_escape.
10530 * utils.h (can_emit_style_escape): Remove.
10531 * utils.c (can_emit_style_escape): Likewise.
10532 Update all callers of can_emit_style_escape (SOMESTREAM) to
10533 SOMESTREAM->can_emit_style_escape.
10534 * source-cache.c (source_cache::get_source_lines): Likewise.
10535 * stack.c (frame_apply_command_count): Call execute_command_to_string
10536 passing the term_out characteristic of the current gdb_stdout.
10537 * thread.c (thr_try_catch_cmd): Likewise.
10538 * top.c (execute_command_to_string): pass term_out parameter
10539 to construct the string_file for the command output.
10540 * ui-file.c (term_cli_styling): New function (most code moved
10541 from utils.c can_emit_style_escape).
10542 (string_file::string_file, string_file::can_emit_style_escape,
10543 stdio_file::can_emit_style_escape, tee_file::term_out,
10544 tee_file::can_emit_style_escape): New functions.
10545
10546 2019-04-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10547
10548 * NEWS: Mention the new set|show may-call-functions.
10549 * infcall.c (may_call_functions_p): New variable.
10550 (show_may_call_functions_p): New function.
10551 (call_function_by_hand_dummy): Throws an error if not
10552 may-call-functions.
10553 (_initialize_infcall): Call add_setshow_boolean_cmd for
10554 may-call-functions.
10555
10556 2019-04-25 Keith Seitz <keiths@redhat.com>
10557
10558 PR c++/24367
10559 * cp-support.c (inspect_type): Don't attempt substitutions
10560 of symbol with the same name.
10561
10562 2019-04-25 Tom Tromey <tromey@adacore.com>
10563
10564 PR gdb/24475:
10565 * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
10566 static.
10567
10568 2019-04-25 Tom Tromey <tromey@adacore.com>
10569
10570 * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
10571 rvalue reference.
10572 (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
10573 (gdb_xml_parser::parse): Use std::move.
10574 * python/python-internal.h (gdbpy_convert_exception): Take a const
10575 reference.
10576 * python/py-value.c (valpy_getitem, valpy_nonzero): Use
10577 std::move.
10578 * python/py-utils.c (gdbpy_convert_exception): Take a const
10579 reference.
10580 * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
10581 Use std::move.
10582 * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
10583 Use std::move.
10584 * mi/mi-main.c (mi_print_exception): Take a const reference.
10585 * main.c (handle_command_errors): Take a const reference.
10586 * linespec.c (parse_linespec): Use std::move.
10587 * infcall.c (run_inferior_call): Use std::move.
10588 (call_function_by_hand_dummy): Use std::move.
10589 * exec.c (try_open_exec_file): Use std::move.
10590 * exceptions.h (exception_print, exception_fprintf)
10591 (exception_print_same): Update.
10592 * exceptions.c (print_exception, exception_print)
10593 (exception_fprintf, exception_print_same): Change parameters to
10594 const reference.
10595 * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
10596 * common/new-op.c: Use std::move.
10597 * common/common-exceptions.h (struct gdb_exception): Add move
10598 constructor.
10599 (struct gdb_exception_error, struct gdb_exception_quit, struct
10600 gdb_quit_bad_alloc): Change constructor to move constructor.
10601 (throw_exception): Change parameter to rvalue reference.
10602 * common/common-exceptions.c (throw_exception): Take rvalue
10603 reference.
10604 * cli/cli-interp.c (safe_execute_command): Use std::move.
10605 * breakpoint.c (insert_bp_location, location_to_sals): Use
10606 std::move.
10607
10608 2019-04-25 Tom Tromey <tromey@adacore.com>
10609
10610 * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
10611 (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
10612 * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
10613 guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
10614 guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
10615 guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
10616 guile/scm-value.c: Use unpack.
10617 * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
10618 gdbscm_gdb_exception.
10619 (gdbscm_throw_gdb_exception): Likewise.
10620 (struct gdbscm_gdb_exception): New.
10621 (unpack): New function.
10622 (gdbscm_wrap): Use unpack.
10623
10624 2019-04-25 Tom Tromey <tromey@adacore.com>
10625
10626 * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
10627 (gdb_rl_callback_handler): Use std::move.
10628 * common/common-exceptions.h (struct gdb_exception): Add move
10629 assignment operator.
10630 (throw_exception_sjlj): Change "exception" to const reference.
10631 * common/common-exceptions.c (exceptions_state_mc_catch): Update.
10632 (throw_exception_sjlj): Change "exception" to const reference.
10633
10634 2019-04-25 Tom Tromey <tromey@adacore.com>
10635
10636 * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
10637 * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
10638 * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
10639 Update.
10640 * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
10641 Update.
10642 * mi/mi-interp.c (mi_interp::exec): Update.
10643 * linespec.c (parse_linespec): Update.
10644 * infcall.c (run_inferior_call): Update.
10645 * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
10646 * guile/scm-symbol.c (gdbscm_lookup_symbol)
10647 (gdbscm_lookup_global_symbol): Update.
10648 * guile/scm-param.c (gdbscm_parameter_value): Update.
10649 * guile/scm-frame.c (gdbscm_frame_read_register)
10650 (gdbscm_frame_read_var): Update.
10651 * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
10652 * exec.c (try_open_exec_file): Update.
10653 * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
10654 (gdb_rl_callback_handler): Update.
10655 * common/common-exceptions.h (exception_none): Don't declare.
10656 * common/common-exceptions.c (exception_none): Don't define.
10657 (struct catcher) <exception>: Update.
10658 * cli/cli-interp.c (safe_execute_command): Update.
10659 * breakpoint.c (insert_bp_location, location_to_sals): Update.
10660
10661 2019-04-25 Ali Tamur <tamur@google.com>
10662
10663 * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
10664 (read_attribute_value): Likewise.
10665 (dwarf2_read_addr_index): Update comment.
10666 (read_str_index): Add DW_FORM_strx.
10667 (dwarf2_string_attr): Likewise.
10668 (dwarf2_const_value_attr): Likewise.
10669 (dump_die_shallow): Likewise.
10670 (dwarf2_fetch_constant_bytes): Likewise.
10671 (skip_form_bytes): Likewise.
10672 * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
10673
10674 2019-04-25 Sergio Durigan Junior <sergiodj@redhat.com>
10675
10676 PR corefiles/11608
10677 PR corefiles/18187
10678 * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
10679 OFFSET. Verify if current mapping contains an ELF header.
10680 (linux_find_memory_regions_full): Adjust call to
10681 dump_mapping_p.
10682
10683 2019-04-25 Sandra Loosemore <sandra@codesourcery.com>
10684 Kang Li <kanglictf@gmail.com>
10685
10686 PR gdb/21600
10687
10688 * dwarf2-frame.c (read_initial_length): Be consistent about using
10689 unsigned representation of length.
10690 (decode_frame_entry_1): Likewise. Check for wraparound of
10691 end pointer as well as buffer overflow.
10692
10693 2019-04-24 Sergio Durigan Junior <sergiodj@redhat.com>
10694
10695 * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
10696 "vq".
10697
10698 2019-04-24 Tom Tromey <tromey@adacore.com>
10699
10700 * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
10701
10702 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10703
10704 * s12z-tdep.c (s12z_unwind_pc): Delete.
10705 (s12z_unwind_sp): Delete.
10706 (s12z_gdbarch_init): Don't register deleted functions with
10707 gdbarch.
10708
10709 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10710
10711 * rl78-tdep.c (rl78_unwind_sp): Delete.
10712 (rl78_gdbarch_init): Don't register deleted function with gdbarch.
10713
10714 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10715
10716 * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
10717 (xstormy16_unwind_pc): Delete.
10718 (xstormy16_dummy_id): Delete.
10719 (xstormy16_gdbarch_init): Don't register deleted functions with
10720 gdbarch.
10721
10722 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10723
10724 * vax-tdep.c (vax_unwind_pc): Delete.
10725 (vax_gdbarch_init): Don't register deleted function with gdbarch.
10726
10727 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10728
10729 * v850-tdep.c (v850_unwind_sp): Delete.
10730 (v850_unwind_pc): Delete.
10731 (v850_dummy_id): Delete.
10732 (v850_gdbarch_init): Don't register deleted functions with
10733 gdbarch.
10734
10735 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10736
10737 * tilegx-tdep.c (tilegx_unwind_sp): Delete.
10738 (tilegx_unwind_pc): Delete.
10739 (tilegx_unwind_dummy_id): Delete.
10740 (tilegx_gdbarch_init): Don't register deleted functions with
10741 gdbarch.
10742
10743 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10744
10745 * tic6x-tdep.c (tic6x_unwind_sp): Delete.
10746 (tic6x_dummy_id): Delete.
10747 (tic6x_gdbarch_init): Don't register deleted functions with
10748 gdbarch.
10749
10750 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10751
10752 * sparc-tdep.c (sparc_unwind_pc): Delete.
10753 (sparc32_gdbarch_init): Don't register deleted function with
10754 gdbarch.
10755
10756 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10757
10758 * sh-tdep.c (sh_unwind_sp): Delete.
10759 (sh_unwind_pc): Delete.
10760 (sh_dummy_id): Delete.
10761 (sh_gdbarch_init): Don't register deleted functions with
10762 gdbarch.
10763
10764 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10765
10766 * score-tdep.c (score_unwind_sp): Delete.
10767 (score_unwind_pc): Delete.
10768 (score_dummy_id): Delete.
10769 (score_gdbarch_init): Don't register deleted functions with
10770 gdbarch.
10771
10772 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10773
10774 * rx-tdep.c (rx_unwind_pc): Delete.
10775 (rx_unwind_sp): Delete.
10776 (rx_dummy_id): Delete.
10777 (rx_gdbarch_init): Don't register deleted functions with
10778 gdbarch. Update comment.
10779
10780 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10781
10782 * rs6000-tdep.c (rs6000_unwind_pc): Delete.
10783 (rs6000_dummy_id): Delete.
10784 (rs6000_gdbarch_init): Don't register deleted functions with
10785 gdbarch.
10786
10787 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10788
10789 * or1k-tdep.c (or1k_dummy_id): Delete.
10790 (or1k_gdbarch_init): Don't register deleted function with gdbarch.
10791
10792 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10793
10794 * nios2-tdep.c (nios2_dummy_id): Delete.
10795 (nios2_unwind_sp): Delete.
10796 (nios2_gdbarch_init): Don't register deleted functions with
10797 gdbarch.
10798
10799 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10800
10801 * nds32-tdep.c (nds32_dummy_id): Delete.
10802 (nds32_unwind_pc): Delete.
10803 (nds32_unwind_sp): Delete.
10804 (nds32_gdbarch_init): Don't register deleted functions with
10805 gdbarch.
10806
10807 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10808
10809 * msp430-tdep.c (msp430_unwind_pc): Delete.
10810 (msp430_unwind_sp): Delete.
10811 (msp430_dummy_id): Delete.
10812 (msp430_gdbarch_init): Don't register deleted functions with
10813 gdbarch.
10814
10815 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10816
10817 * moxie-tdep.c (moxie_unwind_sp): Delete.
10818 (moxie_unwind_pc): Delete.
10819 (moxie_dummy_id): Delete.
10820 (moxie_gdbarch_init): Don't register deleted functions with
10821 gdbarch.
10822
10823 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10824
10825 * mn10300-tdep.c (mn10300_dummy_id): Delete.
10826 (mn10300_unwind_pc): Delete.
10827 (mn10300_unwind_sp): Delete.
10828 (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
10829 mn10300_unwind_sp.
10830 (mn10300_frame_unwind_init): Don't register deleted functions with
10831 gdbarch.
10832
10833 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10834
10835 * mep-tdep.c (mep_unwind_pc): Delete.
10836 (mep_unwind_sp): Delete.
10837 (mep_dummy_id): Delete.
10838 (mep_gdbarch_init): Don't register deleted functions with
10839 gdbarch.
10840
10841 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10842
10843 * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
10844 (m68hc11_unwind_sp): Delete.
10845 (m68hc11_gdbarch_init): Don't register deleted functions with
10846 gdbarch.
10847
10848 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10849
10850 * m32r-tdep.c (m32r_unwind_sp): Delete.
10851 (m32r_unwind_pc): Delete.
10852 (m32r_dummy_id): Delete.
10853 (m32r_gdbarch_init): Don't register deleted functions with
10854 gdbarch.
10855
10856 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10857
10858 * m32c-tdep.c (m32c_unwind_pc): Delete.
10859 (m32c_unwind_sp): Delete.
10860 (m32c_dummy_id): Delete.
10861 (m32c_gdbarch_init): Don't register deleted functions with
10862 gdbarch.
10863
10864 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10865
10866 * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
10867 (lm32_unwind_pc): Delete.
10868 (lm32_dummy_id): Delete.
10869 (lm32_gdbarch_init): Don't register deleted functions with
10870 gdbarch.
10871
10872 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10873
10874 * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
10875 (iq2000_unwind_pc): Delete.
10876 (iq2000_dummy_id): Delete.
10877 (iq2000_gdbarch_init): Don't register deleted functions with
10878 gdbarch.
10879
10880 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10881
10882 * nds32-tdep.c (nds32_type_align): Delete.
10883 (nds32_push_dummy_call): Use type_align instead.
10884
10885 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10886
10887 * arm-tdep.c (arm_type_align): Only handle vector override case.
10888 (arm_push_dummy_call): Use type_align.
10889 (arm_gdbarch_init): Register arm_type_align gdbarch function.
10890
10891 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10892
10893 * aarch64-tdep.c (aarch64_type_align): Only handle vector override
10894 case.
10895 (pass_on_stack): Use type_align.
10896 (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
10897 function.
10898
10899 2019-04-23 Tom Tromey <tromey@adacore.com>
10900
10901 * dwarf2read.c (line_header::file_name_at): Remove unused
10902 overload.
10903
10904 2019-04-23 Tom de Vries <tdevries@suse.de>
10905
10906 PR gdb/24438
10907 * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
10908 invocation.
10909
10910
10911 2019-03-27 Ali Tamur <tamur@google.com>
10912
10913 * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
10914 * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
10915 * dwarf2expr.h(dwarf_expr_context::offset): Update comment
10916 (dwarf_expr_context::get_addr_index): Likewise
10917 * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
10918 (symbol_needs_eval_context::get_addr_index): Likewise
10919 (disassemble_dwarf_expression): Add DW_OP_addrx
10920 * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
10921 (read_cutu_die_from_dwo): Update comment
10922 (skip_one_die): Add DW_FORM_addrx
10923 (read_attribute_value): Likewise
10924 (var_decode_location): Add DW_OP_addrx
10925 (dwarf2_const_value_attr): Add DW_FORM_addrx
10926 (dump_die_shallow): Likewise
10927 (dwarf2_fetch_constant_bytes): Likewise
10928 (decode_locdesc): Add DW_OP_addrx
10929 (skip_form_bytes): Add DW_FORM_addrx
10930
10931 2019-04-22 Ali Tamur <tamur@google.com>
10932
10933 * MAINTAINERS (Write After Approval): Add self.
10934
10935 2019-04-22 Simon Marchi <simon.marchi@efficios.com>
10936
10937 * solib-svr4.c (get_svr4_info): Add pspace parameter.
10938 (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
10939 (open_symbol_file_object): Likewise.
10940 (svr4_default_sos): Add info parameter.
10941 (svr4_read_so_list): Likewise.
10942 (svr4_current_sos_direct): Adjust functions calls to pass down
10943 info.
10944 (svr4_current_sos_1): Add info parameter.
10945 (svr4_current_sos): Call get_svr4_info, pass info down to
10946 svr4_current_sos_1.
10947 (svr4_fetch_objfile_link_map): Pass objfile->pspace to
10948 get_svr4_info.
10949 (svr4_in_dynsym_resolve_code): Pass current_program_space to
10950 get_svr4_info.
10951 (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
10952 to get_svr4_info.
10953 (probes_table_remove_objfile_probes): Likewise.
10954 (register_solib_event_probe): Add info parameter.
10955 (solist_update_incremental): Pass info parameter down to
10956 svr4_read_so_list.
10957 (disable_probes_interface): Add info parameter.
10958 (svr4_handle_solib_event): Pass current_program_space to
10959 get_svr4_info. Adjust disable_probes_interface cleanup.
10960 (svr4_create_probe_breakpoints): Add info parameter, pass it
10961 down to register_solib_event_probe.
10962 (svr4_create_solib_event_breakpoints): Add info parameter,
10963 pass it down to svr4_create_probe_breakpoints.
10964 (enable_break): Pass info down to
10965 svr4_create_solib_event_breakpoints.
10966 (svr4_solib_create_inferior_hook): Pass current_program_space to
10967 get_svr4_info.
10968 (svr4_clear_solib): Likewise.
10969
10970 2019-04-22 Pedro Alves <palves@redhat.com>
10971
10972 * solib-svr4.c (svr4_free_objfile_observer): New.
10973 (probe_and_action::objfile): New field.
10974 (probes_table_htab_remove_objfile_probes)
10975 (probes_table_remove_objfile_probes): New functions.
10976 (register_solib_event_probe): Add 'objfile' parameter. Store it
10977 in the new probe_and_action. Don't store the probe in 'lookup'.
10978 (svr4_create_probe_breakpoints): Pass objfile to
10979 register_solib_event_probe.
10980 (_initialize_svr4_solib): Register a free_objfile observer.
10981
10982 2019-04-19 Tom Tromey <tom@tromey.com>
10983
10984 * common/queue.h: Remove.
10985
10986 2019-04-19 Tom Tromey <tom@tromey.com>
10987
10988 * event-loop.c: Don't include "common/queue.h".
10989
10990 2019-04-19 Tom Tromey <tom@tromey.com>
10991
10992 * remote.c (remote_target): Use delete.
10993 * remote-notif.h: Include <list>, not "common/queue.h".
10994 (notif_client_p): Remove typedef.
10995 (remote_notif_state): Add constructor, destructor, initializer.
10996 <notif_queue>: Now a std::list.
10997 (remote_notif_state_xfree): Don't declare.
10998 * remote-notif.c (remote_notif_process, handle_notification)
10999 (remote_notif_state_allocate): Update.
11000 (~remote_notif_state): Rename from remote_notif_state_xfree.
11001
11002 2019-04-19 Tom Tromey <tom@tromey.com>
11003
11004 * symfile.c (reread_symbols): Update.
11005 * objfiles.c (objfile_register_static_link)
11006 (objfile_lookup_static_link): Update
11007 (~objfile) Don't delete static_links.
11008 * objfiles.h (struct objfile) <static_links>: Now an htab_up.
11009
11010 2019-04-19 Tom Tromey <tom@tromey.com>
11011
11012 * type-stack.h (struct type_stack) <insert>: Constify string.
11013 * type-stack.c (type_stack::insert): Constify string.
11014 * gdbtypes.h (lookup_template_type): Update.
11015 (address_space_name_to_int): Update.
11016 * gdbtypes.c (address_space_name_to_int): Make space_identifier
11017 const.
11018 (lookup_template_type): Make name const.
11019 * c-exp.y: Update rules.
11020 (lex_one_token, classify_name, classify_inner_name)
11021 (c_print_token): Update.
11022 * p-exp.y: Update rules.
11023 (yylex): Update.
11024 * f-exp.y: Update rules.
11025 (yylex): Update.
11026 * d-exp.y: Update rules.
11027 (lex_one_token, classify_name, classify_inner_name): Update.
11028 * parse.c (write_dollar_variable, copy_name): Return std::string.
11029 * parser-defs.h (copy_name): Change return type.
11030 * m2-exp.y: Update rules.
11031 (yylex): Update.
11032 * go-exp.y (lex_one_token): Update.
11033 Update rules.
11034 (classify_unsafe_function, classify_packaged_name)
11035 (classify_name, yylex): Update.
11036
11037 2019-04-19 Sergei Trofimovich <siarheit@google.com>
11038
11039 * configure.ac: add --enable-source-highlight switch.
11040 * configure: Regenerate.
11041 * top.c (print_gdb_version): plumb --enable-source-highlight
11042 status to "show configuration".
11043
11044 2019-04-19 Tom Tromey <tromey@adacore.com>
11045
11046 * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
11047 Check ADA_TYPE_P.
11048 (empty_record, ada_template_to_fixed_record_type_1)
11049 (template_to_static_fixed_type)
11050 (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
11051 * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
11052 * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
11053 macros.
11054
11055 2019-04-19 Ilya Yu. Malakhov <malakhov@mcst.ru>
11056
11057 PR symtab/24423:
11058 * source.c (print_source_lines_base): Advance "iter" when a
11059 control character is seen.
11060
11061 2019-04-19 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11062
11063 * inferior.h (struct infcall_suspend_state_deleter):
11064 Catch exception in destructor to avoid crash.
11065
11066 2019-04-19 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11067
11068 * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
11069 close to the add_com "shell".
11070
11071 2019-04-18 Tom Tromey <tromey@adacore.com>
11072
11073 * process-stratum-target.h (class process_stratum_target)
11074 <stratum>: Add "final".
11075
11076 2019-04-17 Tom Tromey <tromey@adacore.com>
11077
11078 * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
11079 against nullptr before use.
11080
11081 2019-04-17 Alan Hayward <alan.hayward@arm.com>
11082
11083 * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
11084
11085 2019-04-17 Jim Wilson <jimw@sifive.com>
11086 Andrew Burgess <andrew.burgess@embecosm.com>
11087
11088 * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
11089 code read might fail, assume 4-byte breakpoint in that case.
11090
11091 2019-04-15 Leszek Swirski <leszeks@google.com>
11092
11093 * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
11094 rather than a hand-rolled POD check when checking for forced MEMORY
11095 classification.
11096
11097 2019-04-15 Alan Hayward <alan.hayward@arm.com>
11098
11099 * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
11100 * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
11101 function.
11102 (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
11103 (aarch64_sve_regs_copy_from_reg_buf): Likewise.
11104 * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
11105 declaration.
11106
11107 2019-04-15 Alan Hayward <alan.hayward@arm.com>
11108
11109 * aarch64-linux-nat.c
11110 (aarch64_linux_nat_target::thread_architecture): Add override.
11111 * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
11112 each VQ.
11113
11114 2019-04-15 Alan Hayward <alan.hayward@arm.com>
11115
11116 * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
11117
11118 2019-04-13 Andrew Burgess <andrew.burgess@embecosm.com>
11119
11120 * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
11121 target types of size 96-bits, add some additional comments, and
11122 check that the builtin type we found was the correct size.
11123
11124 2019-04-12 Eli Zaretskii <eliz@gnu.org>
11125
11126 * utils.c (prompt_for_continue): Don't restore the styling at the
11127 end, as applied_style has the wrong value. This fixes styling in
11128 long lists of file names that are interrupted by the "Continue?"
11129 prompt.
11130
11131 2019-04-12 Andrew Burgess <andrew.burgess@embecosm.com>
11132
11133 * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
11134 * c-lang.c (c_language_defn): Likewise.
11135 (cplus_language_defn): Likewise.
11136 (asm_language_defn): Likewise.
11137 (minimal_language_defn): Likewise.
11138 * d-lang.c (d_language_defn): Likewise.
11139 * f-lang.c (f_language_defn): Likewise.
11140 * go-lang.c (go_language_defn): Likewise.
11141 * language.c (unknown_language_defn): Likewise.
11142 (auto_language_defn): Likewise.
11143 * language.h (struct language_defn): Remove la_magic field.
11144 (LANG_MAGIC): Delete.
11145 * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
11146 * objc-lang.c (objc_language_defn): Likewise.
11147 * opencl-lang.c (opencl_language_defn): Likewise.
11148 * p-lang.c (pascal_language_defn): Likewise.
11149 * rust-lang.c (rust_language_defn): Likewise.
11150
11151 2019-04-11 Andrew Burgess <andrew.burgess@embecosm.com>
11152
11153 * riscv-tdep.c (riscv_type_align): New function.
11154 (riscv_type_alignment): Delete.
11155 (riscv_arg_location): Use 'type_align'.
11156 (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
11157
11158 2019-04-11 Andrew Burgess <andrew.burgess@embecosm.com>
11159
11160 * gdbtypes.c (type_align): A struct with no non-static fields also
11161 has alignment of 1.
11162
11163 2019-04-11 Andrew Burgess <andrew.burgess@embecosm.com>
11164
11165 * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
11166 component to 0.
11167 (riscv_struct_info::riscv_struct_info): Initialise m_offsets
11168 member.
11169 (riscv_struct_info::analyse): New implementation using new
11170 analyse_inner member function.
11171 (riscv_struct_info::field_offset): New member function.
11172 (riscv_struct_info::m_offsets): New member variable.
11173 (riscv_struct_info::analyse_inner): New private member function,
11174 takes the old implementation of riscv_struct_info::analyse but
11175 extended to track field offsets.
11176 (riscv_call_arg_struct): Update the struct folding special cases
11177 to handle cases where empty C++ structs, which are non-zero
11178 length, are found.
11179 (riscv_arg_location): Initialise the length of each location, a
11180 non-zero length now indicates the location is in use.
11181 (riscv_push_dummy_call): Allow for the first location having a
11182 non-zero offset when setting up arguments.
11183 (riscv_return_value): Likewise, but for return values.
11184
11185 2019-04-11 Tom Tromey <tromey@adacore.com>
11186
11187 * utils.c (internal_vproblem): Make "msg" const.
11188
11189 2019-04-11 Alan Hayward <alan.hayward@arm.com>
11190
11191 * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
11192 * trad-frame.c (trad_frame_reset_saved_regs): New function.
11193 (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
11194 * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
11195
11196 2019-04-10 Kevin Buettner <kevinb@redhat.com>
11197
11198 * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
11199 function.
11200 (fill_gregset): Call amd64_linux_collect_native_gregset instead
11201 of amd64_collect_native_gregset.
11202 (amd64_linux_nat_target::store_registers): Likewise.
11203
11204 2019-04-10 Tom Tromey <tom@tromey.com>
11205
11206 * symtab.c (lookup_global_symbol_from_objfile)
11207 (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
11208 * objfiles.h (class separate_debug_iterator): New.
11209 (class separate_debug_range): New.
11210 (struct objfile) <separate_debug_objfiles>: New method.
11211 (objfile_separate_debug_iterate): Don't declare.
11212 * objfiles.c (separate_debug_iterator::operator++): Rename from
11213 objfile_separate_debug_iterate.
11214 (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
11215 iterator.
11216 * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
11217 iterator.
11218
11219 2019-04-10 Tom Tromey <tom@tromey.com>
11220
11221 * symfile.c (reread_symbols): Remove old comment.
11222 * objfiles.c (free_all_objfiles): Fix a typo.
11223
11224 2019-04-10 Tom Tromey <tom@tromey.com>
11225
11226 * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
11227 * minsyms.c (lookup_minimal_symbol): Use foreach.
11228 (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
11229 (lookup_minimal_symbol_solib_trampoline): Likewise.
11230 * symfile.c (reread_symbols): Use foreach.
11231
11232 2019-04-09 Ivan Begert <ivanbegert@gmail.com>
11233 Tom Tromey <tromey@adacore.com>
11234
11235 PR rust/24414:
11236 * rust-exp.y (rust_parser::lex_number): Use strtoulst.
11237 (rust_lex_int_test): Change "value" to be LONGEST.
11238 (rust_lex_tests): Add test for long integer literal.
11239
11240 2019-04-09 Tom Tromey <tromey@adacore.com>
11241
11242 * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
11243 to bool.
11244 (extended_remote_target::attach): Update.
11245 (remote_target::remote_notice_new_inferior): Update.
11246 (remote_target::add_current_inferior_and_thread): Update.
11247 * inferior.c (exit_inferior_1): Use "false".
11248 * corelow.c (add_to_thread_list): Make fake_pid_p bool.
11249
11250 2019-04-09 Simon Marchi <simon.marchi@efficios.com>
11251
11252 * infcmd.c (run_command_1): Pass -qualified to tbreak when using
11253 the "start" command.
11254
11255 2019-04-08 Kevin Buettner <kevinb@redhat.com>
11256
11257 * python/py-inferior.c (infpy_thread_from_thread_handle):
11258 Adjust comments to reflect renaming of thread_from_thread_handle
11259 to thread_from_handle. Adjust keywords. Fix type error message.
11260 (inferior_object_methods): Add thread_from_handle. Retain
11261 thread_from_thread_handle, but mark it as deprecated.
11262
11263 2019-04-08 Kevin Buettner <kevinb@redhat.com>
11264
11265 * gdbthread.h (find_thread_by_handle): Revise declaration.
11266 * thread.c (find_thread_by_handle): Likewise. Adjust
11267 implementation too.
11268 * python/py-inferior.c (infpy_thread_from_thread_handle): Add
11269 support for buffer objects as handles.
11270
11271 2019-04-08 Kevin Buettner <kevinb@redhat.com>
11272
11273 * python/py-infthread.c (thpy_thread_handle): New function.
11274 (thread_object_methods): Register thpy_thread_handle.
11275
11276 2019-04-08 Kevin Buettner <kevinb@redhat.com>
11277
11278 * gdbthread.h (thread_to_thread_handle): Declare.
11279 * thread.c (gdbtypes.h): Include.
11280 (thread_to_thread_handle): New function.
11281
11282 * target.h (struct target_ops): Add thread_info_to_thread_handle.
11283 (target_thread_info_to_thread_handle): Declare.
11284 * target.c (target_thread_info_to_thread_handle): New function.
11285 * target-debug.h (target_debug_print_gdb_byte_vector): Define.
11286 * target-delegates.c: Regenerate.
11287
11288 * linux-thread-db.c (class thread_db_target): Add method
11289 thread_info_to_thread_handle.
11290 (thread_db_target::thread_info_to_thread_handle): Define.
11291 * remote.c (class remote_target): Add new method
11292 thread_info_to_thread_handle.
11293 (remote_target::thread_info_to_thread_handle): Define.
11294
11295 2019-04-08 Pedro Alves <palves@redhat.com>
11296
11297 * common/common-exceptions.c (throw_exception): Don't create
11298 named object to throw; throw directly.
11299 (throw_it): Likewise. Don't initialize gdb_exception::message
11300 here, with new; pass FMT and AP to the ctor instead.
11301 * common/common-exceptions.h: Include <string>.
11302 (gdb_exception::gdb_exception(enum return_reason, enum errors,
11303 const char *, va_list)): New ctor. Use std::make_shared.
11304 (gdb_exception_error::gdb_exception_error(enum return_reason, enum
11305 errors)): Delete.
11306 (gdb_exception_error::gdb_exception_error(enum errors, const char
11307 *, va_list)): New.
11308 (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
11309 Add assertion.
11310 (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
11311 errors)): Delete.
11312 (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
11313 (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
11314 Add assertion.
11315
11316 2019-04-08 Tom Tromey <tom@tromey.com>
11317
11318 * valops.c (value_rtti_indirect_type): Replace throw_exception
11319 with throw.
11320 * tracefile-tfile.c (tfile_target_open): Replace throw_exception
11321 with throw.
11322 * thread.c (thr_try_catch_cmd): Replace throw_exception with
11323 throw.
11324 * target.c (target_translate_tls_address): Replace throw_exception
11325 with throw.
11326 * stack.c (frame_apply_command_count): Replace throw_exception
11327 with throw.
11328 * solib-spu.c (append_ocl_sos): Replace throw_exception with
11329 throw.
11330 * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
11331 with throw.
11332 * rs6000-tdep.c (rs6000_frame_cache)
11333 (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
11334 * remote.c: Replace throw_exception with throw.
11335 * record-full.c (record_full_message, record_full_wait_1)
11336 (record_full_restore): Replace throw_exception with throw.
11337 * record-btrace.c:
11338 (get_thread_current_frame_id, record_btrace_start_replaying)
11339 (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
11340 (cmd_record_btrace_start): Replace throw_exception with throw.
11341 * parse.c (parse_exp_in_context_1): Replace throw_exception with
11342 throw.
11343 * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
11344 (resume_stopped_resumed_lwps): Replace throw_exception with throw.
11345 * linespec.c:
11346 (find_linespec_symbols): Replace throw_exception with throw.
11347 * infrun.c (displaced_step_prepare, resume): Replace
11348 throw_exception with throw.
11349 * infcmd.c (post_create_inferior): Replace throw_exception with
11350 throw.
11351 * inf-loop.c (inferior_event_handler): Replace throw_exception
11352 with throw.
11353 * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
11354 (i386_sigtramp_frame_cache): Replace throw_exception with throw.
11355 * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
11356 (get_prev_frame_always, get_frame_pc_if_available)
11357 (get_frame_address_in_block_if_available, get_frame_language):
11358 Replace throw_exception with throw.
11359 * frame-unwind.c (frame_unwind_try_unwinder): Replace
11360 throw_exception with throw.
11361 * eval.c (fetch_subexp_value, evaluate_var_value)
11362 (evaluate_funcall, evaluate_subexp_standard): Replace
11363 throw_exception with throw.
11364 * dwarf2loc.c (call_site_find_chain)
11365 (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
11366 Replace throw_exception with throw.
11367 * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
11368 with throw.
11369 * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
11370 throw.
11371 * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
11372 * completer.c (complete_line_internal): Replace throw_exception
11373 with throw.
11374 * compile/compile-object-run.c (compile_object_run): Replace
11375 throw_exception with throw.
11376 * cli/cli-script.c (process_next_line): Replace throw_exception
11377 with throw.
11378 * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
11379 (btrace_enable, btrace_maint_update_pt_packets): Replace
11380 throw_exception with throw.
11381 * breakpoint.c (create_breakpoint, save_breakpoints): Replace
11382 throw_exception with throw.
11383 * break-catch-throw.c (re_set_exception_catchpoint): Replace
11384 throw_exception with throw.
11385 * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
11386 (amd64_epilogue_frame_cache): Replace throw_exception with throw.
11387 * aarch64-tdep.c (aarch64_make_prologue_cache)
11388 (aarch64_make_stub_cache): Replace throw_exception with throw.
11389
11390 2019-04-08 Tom Tromey <tom@tromey.com>
11391
11392 * common/common-exceptions.c (throw_exception): Rename from
11393 throw_exception_cxx. Remove old copy. Make argument const.
11394 (throw_it): Create and throw exception objects directly.
11395 * common/common-exceptions.h (throw_exception): Make argument
11396 const.
11397 (struct gdb_exception_error): Add constructor.
11398 (struct gdb_exception_quit): Add constructor.
11399
11400 2019-04-08 Tom Tromey <tom@tromey.com>
11401
11402 * common/common-exceptions.h (exception_rethrow): Don't declare.
11403 (TRY_SJLJ): Update comment.
11404 (TRY, CATCH, END_CATCH): Remove.
11405 * common/common-exceptions.c (exception_rethrow): Remove.
11406
11407 2019-04-08 Tom Tromey <tom@tromey.com>
11408
11409 * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
11410 Remove.
11411 (gdb_exception_error): Rename from
11412 gdb_exception_RETURN_MASK_ERROR.
11413 (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
11414 (gdb_quit_bad_alloc): Update.
11415 * aarch64-tdep.c: Update.
11416 * ada-lang.c: Update.
11417 * ada-typeprint.c: Update.
11418 * ada-valprint.c: Update.
11419 * amd64-tdep.c: Update.
11420 * arch-utils.c: Update.
11421 * break-catch-throw.c: Update.
11422 * breakpoint.c: Update.
11423 * btrace.c: Update.
11424 * c-varobj.c: Update.
11425 * cli/cli-cmds.c: Update.
11426 * cli/cli-interp.c: Update.
11427 * cli/cli-script.c: Update.
11428 * common/common-exceptions.c: Update.
11429 * common/new-op.c: Update.
11430 * common/selftest.c: Update.
11431 * compile/compile-c-symbols.c: Update.
11432 * compile/compile-cplus-symbols.c: Update.
11433 * compile/compile-object-load.c: Update.
11434 * compile/compile-object-run.c: Update.
11435 * completer.c: Update.
11436 * corelow.c: Update.
11437 * cp-abi.c: Update.
11438 * cp-support.c: Update.
11439 * cp-valprint.c: Update.
11440 * darwin-nat.c: Update.
11441 * disasm-selftests.c: Update.
11442 * dtrace-probe.c: Update.
11443 * dwarf-index-cache.c: Update.
11444 * dwarf-index-write.c: Update.
11445 * dwarf2-frame-tailcall.c: Update.
11446 * dwarf2-frame.c: Update.
11447 * dwarf2loc.c: Update.
11448 * dwarf2read.c: Update.
11449 * eval.c: Update.
11450 * event-loop.c: Update.
11451 * event-top.c: Update.
11452 * exec.c: Update.
11453 * f-valprint.c: Update.
11454 * fbsd-tdep.c: Update.
11455 * frame-unwind.c: Update.
11456 * frame.c: Update.
11457 * gdbtypes.c: Update.
11458 * gnu-v3-abi.c: Update.
11459 * guile/guile-internal.h: Update.
11460 * guile/scm-block.c: Update.
11461 * guile/scm-breakpoint.c: Update.
11462 * guile/scm-cmd.c: Update.
11463 * guile/scm-disasm.c: Update.
11464 * guile/scm-frame.c: Update.
11465 * guile/scm-lazy-string.c: Update.
11466 * guile/scm-math.c: Update.
11467 * guile/scm-param.c: Update.
11468 * guile/scm-ports.c: Update.
11469 * guile/scm-pretty-print.c: Update.
11470 * guile/scm-symbol.c: Update.
11471 * guile/scm-symtab.c: Update.
11472 * guile/scm-type.c: Update.
11473 * guile/scm-value.c: Update.
11474 * i386-linux-tdep.c: Update.
11475 * i386-tdep.c: Update.
11476 * inf-loop.c: Update.
11477 * infcall.c: Update.
11478 * infcmd.c: Update.
11479 * infrun.c: Update.
11480 * jit.c: Update.
11481 * language.c: Update.
11482 * linespec.c: Update.
11483 * linux-fork.c: Update.
11484 * linux-nat.c: Update.
11485 * linux-tdep.c: Update.
11486 * linux-thread-db.c: Update.
11487 * main.c: Update.
11488 * mi/mi-cmd-break.c: Update.
11489 * mi/mi-cmd-stack.c: Update.
11490 * mi/mi-interp.c: Update.
11491 * mi/mi-main.c: Update.
11492 * objc-lang.c: Update.
11493 * p-valprint.c: Update.
11494 * parse.c: Update.
11495 * ppc-linux-tdep.c: Update.
11496 * printcmd.c: Update.
11497 * python/py-arch.c: Update.
11498 * python/py-breakpoint.c: Update.
11499 * python/py-cmd.c: Update.
11500 * python/py-finishbreakpoint.c: Update.
11501 * python/py-frame.c: Update.
11502 * python/py-framefilter.c: Update.
11503 * python/py-gdb-readline.c: Update.
11504 * python/py-inferior.c: Update.
11505 * python/py-infthread.c: Update.
11506 * python/py-lazy-string.c: Update.
11507 * python/py-linetable.c: Update.
11508 * python/py-objfile.c: Update.
11509 * python/py-param.c: Update.
11510 * python/py-prettyprint.c: Update.
11511 * python/py-progspace.c: Update.
11512 * python/py-record-btrace.c: Update.
11513 * python/py-record.c: Update.
11514 * python/py-symbol.c: Update.
11515 * python/py-type.c: Update.
11516 * python/py-unwind.c: Update.
11517 * python/py-utils.c: Update.
11518 * python/py-value.c: Update.
11519 * python/python.c: Update.
11520 * record-btrace.c: Update.
11521 * record-full.c: Update.
11522 * remote-fileio.c: Update.
11523 * remote.c: Update.
11524 * riscv-tdep.c: Update.
11525 * rs6000-aix-tdep.c: Update.
11526 * rs6000-tdep.c: Update.
11527 * rust-exp.y: Update.
11528 * rust-lang.c: Update.
11529 * s390-tdep.c: Update.
11530 * selftest-arch.c: Update.
11531 * solib-dsbt.c: Update.
11532 * solib-frv.c: Update.
11533 * solib-spu.c: Update.
11534 * solib-svr4.c: Update.
11535 * solib.c: Update.
11536 * sparc64-linux-tdep.c: Update.
11537 * stack.c: Update.
11538 * symfile-mem.c: Update.
11539 * symmisc.c: Update.
11540 * target.c: Update.
11541 * thread.c: Update.
11542 * top.c: Update.
11543 * tracefile-tfile.c: Update.
11544 * tui/tui.c: Update.
11545 * typeprint.c: Update.
11546 * unittests/cli-utils-selftests.c: Update.
11547 * unittests/parse-connection-spec-selftests.c: Update.
11548 * valops.c: Update.
11549 * valprint.c: Update.
11550 * value.c: Update.
11551 * varobj.c: Update.
11552 * windows-nat.c: Update.
11553 * x86-linux-nat.c: Update.
11554 * xml-support.c: Update.
11555
11556 2019-04-08 Tom Tromey <tom@tromey.com>
11557
11558 * xml-support.c: Use C++ exception handling.
11559 * x86-linux-nat.c: Use C++ exception handling.
11560 * windows-nat.c: Use C++ exception handling.
11561 * varobj.c: Use C++ exception handling.
11562 * value.c: Use C++ exception handling.
11563 * valprint.c: Use C++ exception handling.
11564 * valops.c: Use C++ exception handling.
11565 * unittests/parse-connection-spec-selftests.c: Use C++ exception
11566 handling.
11567 * unittests/cli-utils-selftests.c: Use C++ exception handling.
11568 * typeprint.c: Use C++ exception handling.
11569 * tui/tui.c: Use C++ exception handling.
11570 * tracefile-tfile.c: Use C++ exception handling.
11571 * top.c: Use C++ exception handling.
11572 * thread.c: Use C++ exception handling.
11573 * target.c: Use C++ exception handling.
11574 * symmisc.c: Use C++ exception handling.
11575 * symfile-mem.c: Use C++ exception handling.
11576 * stack.c: Use C++ exception handling.
11577 * sparc64-linux-tdep.c: Use C++ exception handling.
11578 * solib.c: Use C++ exception handling.
11579 * solib-svr4.c: Use C++ exception handling.
11580 * solib-spu.c: Use C++ exception handling.
11581 * solib-frv.c: Use C++ exception handling.
11582 * solib-dsbt.c: Use C++ exception handling.
11583 * selftest-arch.c: Use C++ exception handling.
11584 * s390-tdep.c: Use C++ exception handling.
11585 * rust-lang.c: Use C++ exception handling.
11586 * rust-exp.y: Use C++ exception handling.
11587 * rs6000-tdep.c: Use C++ exception handling.
11588 * rs6000-aix-tdep.c: Use C++ exception handling.
11589 * riscv-tdep.c: Use C++ exception handling.
11590 * remote.c: Use C++ exception handling.
11591 * remote-fileio.c: Use C++ exception handling.
11592 * record-full.c: Use C++ exception handling.
11593 * record-btrace.c: Use C++ exception handling.
11594 * python/python.c: Use C++ exception handling.
11595 * python/py-value.c: Use C++ exception handling.
11596 * python/py-utils.c: Use C++ exception handling.
11597 * python/py-unwind.c: Use C++ exception handling.
11598 * python/py-type.c: Use C++ exception handling.
11599 * python/py-symbol.c: Use C++ exception handling.
11600 * python/py-record.c: Use C++ exception handling.
11601 * python/py-record-btrace.c: Use C++ exception handling.
11602 * python/py-progspace.c: Use C++ exception handling.
11603 * python/py-prettyprint.c: Use C++ exception handling.
11604 * python/py-param.c: Use C++ exception handling.
11605 * python/py-objfile.c: Use C++ exception handling.
11606 * python/py-linetable.c: Use C++ exception handling.
11607 * python/py-lazy-string.c: Use C++ exception handling.
11608 * python/py-infthread.c: Use C++ exception handling.
11609 * python/py-inferior.c: Use C++ exception handling.
11610 * python/py-gdb-readline.c: Use C++ exception handling.
11611 * python/py-framefilter.c: Use C++ exception handling.
11612 * python/py-frame.c: Use C++ exception handling.
11613 * python/py-finishbreakpoint.c: Use C++ exception handling.
11614 * python/py-cmd.c: Use C++ exception handling.
11615 * python/py-breakpoint.c: Use C++ exception handling.
11616 * python/py-arch.c: Use C++ exception handling.
11617 * printcmd.c: Use C++ exception handling.
11618 * ppc-linux-tdep.c: Use C++ exception handling.
11619 * parse.c: Use C++ exception handling.
11620 * p-valprint.c: Use C++ exception handling.
11621 * objc-lang.c: Use C++ exception handling.
11622 * mi/mi-main.c: Use C++ exception handling.
11623 * mi/mi-interp.c: Use C++ exception handling.
11624 * mi/mi-cmd-stack.c: Use C++ exception handling.
11625 * mi/mi-cmd-break.c: Use C++ exception handling.
11626 * main.c: Use C++ exception handling.
11627 * linux-thread-db.c: Use C++ exception handling.
11628 * linux-tdep.c: Use C++ exception handling.
11629 * linux-nat.c: Use C++ exception handling.
11630 * linux-fork.c: Use C++ exception handling.
11631 * linespec.c: Use C++ exception handling.
11632 * language.c: Use C++ exception handling.
11633 * jit.c: Use C++ exception handling.
11634 * infrun.c: Use C++ exception handling.
11635 * infcmd.c: Use C++ exception handling.
11636 * infcall.c: Use C++ exception handling.
11637 * inf-loop.c: Use C++ exception handling.
11638 * i386-tdep.c: Use C++ exception handling.
11639 * i386-linux-tdep.c: Use C++ exception handling.
11640 * guile/scm-value.c: Use C++ exception handling.
11641 * guile/scm-type.c: Use C++ exception handling.
11642 * guile/scm-symtab.c: Use C++ exception handling.
11643 * guile/scm-symbol.c: Use C++ exception handling.
11644 * guile/scm-pretty-print.c: Use C++ exception handling.
11645 * guile/scm-ports.c: Use C++ exception handling.
11646 * guile/scm-param.c: Use C++ exception handling.
11647 * guile/scm-math.c: Use C++ exception handling.
11648 * guile/scm-lazy-string.c: Use C++ exception handling.
11649 * guile/scm-frame.c: Use C++ exception handling.
11650 * guile/scm-disasm.c: Use C++ exception handling.
11651 * guile/scm-cmd.c: Use C++ exception handling.
11652 * guile/scm-breakpoint.c: Use C++ exception handling.
11653 * guile/scm-block.c: Use C++ exception handling.
11654 * guile/guile-internal.h: Use C++ exception handling.
11655 * gnu-v3-abi.c: Use C++ exception handling.
11656 * gdbtypes.c: Use C++ exception handling.
11657 * frame.c: Use C++ exception handling.
11658 * frame-unwind.c: Use C++ exception handling.
11659 * fbsd-tdep.c: Use C++ exception handling.
11660 * f-valprint.c: Use C++ exception handling.
11661 * exec.c: Use C++ exception handling.
11662 * event-top.c: Use C++ exception handling.
11663 * event-loop.c: Use C++ exception handling.
11664 * eval.c: Use C++ exception handling.
11665 * dwarf2read.c: Use C++ exception handling.
11666 * dwarf2loc.c: Use C++ exception handling.
11667 * dwarf2-frame.c: Use C++ exception handling.
11668 * dwarf2-frame-tailcall.c: Use C++ exception handling.
11669 * dwarf-index-write.c: Use C++ exception handling.
11670 * dwarf-index-cache.c: Use C++ exception handling.
11671 * dtrace-probe.c: Use C++ exception handling.
11672 * disasm-selftests.c: Use C++ exception handling.
11673 * darwin-nat.c: Use C++ exception handling.
11674 * cp-valprint.c: Use C++ exception handling.
11675 * cp-support.c: Use C++ exception handling.
11676 * cp-abi.c: Use C++ exception handling.
11677 * corelow.c: Use C++ exception handling.
11678 * completer.c: Use C++ exception handling.
11679 * compile/compile-object-run.c: Use C++ exception handling.
11680 * compile/compile-object-load.c: Use C++ exception handling.
11681 * compile/compile-cplus-symbols.c: Use C++ exception handling.
11682 * compile/compile-c-symbols.c: Use C++ exception handling.
11683 * common/selftest.c: Use C++ exception handling.
11684 * common/new-op.c: Use C++ exception handling.
11685 * cli/cli-script.c: Use C++ exception handling.
11686 * cli/cli-interp.c: Use C++ exception handling.
11687 * cli/cli-cmds.c: Use C++ exception handling.
11688 * c-varobj.c: Use C++ exception handling.
11689 * btrace.c: Use C++ exception handling.
11690 * breakpoint.c: Use C++ exception handling.
11691 * break-catch-throw.c: Use C++ exception handling.
11692 * arch-utils.c: Use C++ exception handling.
11693 * amd64-tdep.c: Use C++ exception handling.
11694 * ada-valprint.c: Use C++ exception handling.
11695 * ada-typeprint.c: Use C++ exception handling.
11696 * ada-lang.c: Use C++ exception handling.
11697 * aarch64-tdep.c: Use C++ exception handling.
11698
11699 2019-04-08 Tom Tromey <tom@tromey.com>
11700
11701 * xml-support.c (gdb_xml_parser::parse): Update.
11702 * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
11703 * value.c (show_convenience): Update.
11704 * unittests/cli-utils-selftests.c (test_number_or_range_parser)
11705 (test_parse_flags_qcs): Update.
11706 * thread.c (thr_try_catch_cmd): Update.
11707 * target.c (target_translate_tls_address): Update.
11708 * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
11709 (info_frame_command_core, frame_apply_command_count): Update.
11710 * rust-exp.y (rust_lex_exception_test): Update.
11711 * riscv-tdep.c (riscv_print_one_register_info): Update.
11712 * remote.c (remote_target::enable_btrace): Update.
11713 * record-btrace.c (record_btrace_enable_warn): Update.
11714 * python/py-utils.c (gdbpy_convert_exception): Update.
11715 * printcmd.c (do_one_display, print_variable_and_value): Update.
11716 * mi/mi-main.c (mi_print_exception): Update.
11717 * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
11718 * mi/mi-cmd-stack.c (list_arg_or_local): Update.
11719 * linux-nat.c (linux_nat_target::attach): Update.
11720 * linux-fork.c (class scoped_switch_fork_info): Update.
11721 * infrun.c (displaced_step_prepare): Update.
11722 * infcall.c (call_function_by_hand_dummy): Update.
11723 * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
11724 * gnu-v3-abi.c (print_one_vtable): Update.
11725 * frame.c (get_prev_frame_always): Update.
11726 * f-valprint.c (info_common_command_for_block): Update.
11727 * exec.c (try_open_exec_file): Update.
11728 * exceptions.c (print_exception, exception_print)
11729 (exception_fprintf, exception_print_same): Update.
11730 * dwarf2-frame.c (dwarf2_build_frame_info): Update.
11731 * dwarf-index-cache.c (index_cache::store)
11732 (index_cache::lookup_gdb_index): Update.
11733 * darwin-nat.c (maybe_cache_shell): Update.
11734 * cp-valprint.c (cp_print_value_fields): Update.
11735 * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
11736 (gcc_cplus_symbol_address): Update.
11737 * compile/compile-c-symbols.c (gcc_convert_symbol)
11738 (gcc_symbol_address, generate_c_for_for_one_variable): Update.
11739 * common/selftest.c: Update.
11740 * common/common-exceptions.h (struct gdb_exception) <message>: Now
11741 a std::string.
11742 (exception_try_scope_entry, exception_try_scope_exit): Don't
11743 declare.
11744 (struct exception_try_scope): Remove.
11745 (TRY): Don't use exception_try_scope.
11746 (struct gdb_exception): Add constructor, operator=.
11747 <what>: New method.
11748 (struct gdb_exception_RETURN_MASK_ALL)
11749 (struct gdb_exception_RETURN_MASK_ERROR)
11750 (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
11751 (struct gdb_quit_bad_alloc): Update.
11752 * common/common-exceptions.c (exception_none): Change
11753 initializer.
11754 (struct catcher) <state, exception>: Initialize inline.
11755 <prev>: Remove member.
11756 (current_catcher): Remove.
11757 (catchers): New global.
11758 (exceptions_state_mc_init): Simplify.
11759 (catcher_pop): Remove.
11760 (exceptions_state_mc, exceptions_state_mc_catch): Update.
11761 (try_scope_depth, exception_try_scope_entry)
11762 (exception_try_scope_exit): Remove.
11763 (throw_exception_sjlj): Update.
11764 (exception_messages, exception_messages_size): Remove.
11765 (throw_it): Simplify.
11766 (gdb_exception_sliced_copy): Remove.
11767 (throw_exception_cxx): Update.
11768 * cli/cli-script.c (script_from_file): Update.
11769 * breakpoint.c (insert_bp_location, update_breakpoint_locations):
11770 Update.
11771 * ada-valprint.c (ada_val_print): Update.
11772 * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
11773 (create_excep_cond_exprs): Update.
11774
11775 2019-04-08 Tom Tromey <tom@tromey.com>
11776
11777 * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
11778 (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
11779 (TRY, CATCH, END_CATCH): Remove some definitions.
11780 * common/common-exceptions.c: Don't use GDB_XCPT.
11781 (catcher_list_size): Remove.
11782 (throw_exception, throw_it): Simplify.
11783
11784 2019-04-05 Tom Tromey <tom@tromey.com>
11785
11786 Revert the header-sorting patch.
11787 * ft32-tdep.c: Revert.
11788 * frv-tdep.c: Revert.
11789 * frv-linux-tdep.c: Revert.
11790 * frame.c: Revert.
11791 * frame-unwind.c: Revert.
11792 * frame-base.c: Revert.
11793 * fork-child.c: Revert.
11794 * findvar.c: Revert.
11795 * findcmd.c: Revert.
11796 * filesystem.c: Revert.
11797 * filename-seen-cache.h: Revert.
11798 * filename-seen-cache.c: Revert.
11799 * fbsd-tdep.c: Revert.
11800 * fbsd-nat.h: Revert.
11801 * fbsd-nat.c: Revert.
11802 * f-valprint.c: Revert.
11803 * f-typeprint.c: Revert.
11804 * f-lang.c: Revert.
11805 * extension.h: Revert.
11806 * extension.c: Revert.
11807 * extension-priv.h: Revert.
11808 * expprint.c: Revert.
11809 * exec.h: Revert.
11810 * exec.c: Revert.
11811 * exceptions.c: Revert.
11812 * event-top.c: Revert.
11813 * event-loop.c: Revert.
11814 * eval.c: Revert.
11815 * elfread.c: Revert.
11816 * dwarf2read.h: Revert.
11817 * dwarf2read.c: Revert.
11818 * dwarf2loc.c: Revert.
11819 * dwarf2expr.h: Revert.
11820 * dwarf2expr.c: Revert.
11821 * dwarf2-frame.c: Revert.
11822 * dwarf2-frame-tailcall.c: Revert.
11823 * dwarf-index-write.h: Revert.
11824 * dwarf-index-write.c: Revert.
11825 * dwarf-index-common.c: Revert.
11826 * dwarf-index-cache.h: Revert.
11827 * dwarf-index-cache.c: Revert.
11828 * dummy-frame.c: Revert.
11829 * dtrace-probe.c: Revert.
11830 * disasm.h: Revert.
11831 * disasm.c: Revert.
11832 * disasm-selftests.c: Revert.
11833 * dictionary.c: Revert.
11834 * dicos-tdep.c: Revert.
11835 * demangle.c: Revert.
11836 * dcache.h: Revert.
11837 * dcache.c: Revert.
11838 * darwin-nat.h: Revert.
11839 * darwin-nat.c: Revert.
11840 * darwin-nat-info.c: Revert.
11841 * d-valprint.c: Revert.
11842 * d-namespace.c: Revert.
11843 * d-lang.c: Revert.
11844 * ctf.c: Revert.
11845 * csky-tdep.c: Revert.
11846 * csky-linux-tdep.c: Revert.
11847 * cris-tdep.c: Revert.
11848 * cris-linux-tdep.c: Revert.
11849 * cp-valprint.c: Revert.
11850 * cp-support.c: Revert.
11851 * cp-namespace.c: Revert.
11852 * cp-abi.c: Revert.
11853 * corelow.c: Revert.
11854 * corefile.c: Revert.
11855 * continuations.c: Revert.
11856 * completer.h: Revert.
11857 * completer.c: Revert.
11858 * complaints.c: Revert.
11859 * coffread.c: Revert.
11860 * coff-pe-read.c: Revert.
11861 * cli-out.h: Revert.
11862 * cli-out.c: Revert.
11863 * charset.c: Revert.
11864 * c-varobj.c: Revert.
11865 * c-valprint.c: Revert.
11866 * c-typeprint.c: Revert.
11867 * c-lang.c: Revert.
11868 * buildsym.c: Revert.
11869 * buildsym-legacy.c: Revert.
11870 * build-id.h: Revert.
11871 * build-id.c: Revert.
11872 * btrace.c: Revert.
11873 * bsd-uthread.c: Revert.
11874 * breakpoint.h: Revert.
11875 * breakpoint.c: Revert.
11876 * break-catch-throw.c: Revert.
11877 * break-catch-syscall.c: Revert.
11878 * break-catch-sig.c: Revert.
11879 * blockframe.c: Revert.
11880 * block.c: Revert.
11881 * bfin-tdep.c: Revert.
11882 * bfin-linux-tdep.c: Revert.
11883 * bfd-target.c: Revert.
11884 * bcache.c: Revert.
11885 * ax-general.c: Revert.
11886 * ax-gdb.h: Revert.
11887 * ax-gdb.c: Revert.
11888 * avr-tdep.c: Revert.
11889 * auxv.c: Revert.
11890 * auto-load.c: Revert.
11891 * arm-wince-tdep.c: Revert.
11892 * arm-tdep.c: Revert.
11893 * arm-symbian-tdep.c: Revert.
11894 * arm-pikeos-tdep.c: Revert.
11895 * arm-obsd-tdep.c: Revert.
11896 * arm-nbsd-tdep.c: Revert.
11897 * arm-nbsd-nat.c: Revert.
11898 * arm-linux-tdep.c: Revert.
11899 * arm-linux-nat.c: Revert.
11900 * arm-fbsd-tdep.c: Revert.
11901 * arm-fbsd-nat.c: Revert.
11902 * arm-bsd-tdep.c: Revert.
11903 * arch-utils.c: Revert.
11904 * arc-tdep.c: Revert.
11905 * arc-newlib-tdep.c: Revert.
11906 * annotate.h: Revert.
11907 * annotate.c: Revert.
11908 * amd64-windows-tdep.c: Revert.
11909 * amd64-windows-nat.c: Revert.
11910 * amd64-tdep.c: Revert.
11911 * amd64-sol2-tdep.c: Revert.
11912 * amd64-obsd-tdep.c: Revert.
11913 * amd64-obsd-nat.c: Revert.
11914 * amd64-nbsd-tdep.c: Revert.
11915 * amd64-nbsd-nat.c: Revert.
11916 * amd64-nat.c: Revert.
11917 * amd64-linux-tdep.c: Revert.
11918 * amd64-linux-nat.c: Revert.
11919 * amd64-fbsd-tdep.c: Revert.
11920 * amd64-fbsd-nat.c: Revert.
11921 * amd64-dicos-tdep.c: Revert.
11922 * amd64-darwin-tdep.c: Revert.
11923 * amd64-bsd-nat.c: Revert.
11924 * alpha-tdep.c: Revert.
11925 * alpha-obsd-tdep.c: Revert.
11926 * alpha-nbsd-tdep.c: Revert.
11927 * alpha-mdebug-tdep.c: Revert.
11928 * alpha-linux-tdep.c: Revert.
11929 * alpha-linux-nat.c: Revert.
11930 * alpha-bsd-tdep.c: Revert.
11931 * alpha-bsd-nat.c: Revert.
11932 * aix-thread.c: Revert.
11933 * agent.c: Revert.
11934 * addrmap.c: Revert.
11935 * ada-varobj.c: Revert.
11936 * ada-valprint.c: Revert.
11937 * ada-typeprint.c: Revert.
11938 * ada-tasks.c: Revert.
11939 * ada-lang.c: Revert.
11940 * aarch64-tdep.c: Revert.
11941 * aarch64-ravenscar-thread.c: Revert.
11942 * aarch64-newlib-tdep.c: Revert.
11943 * aarch64-linux-tdep.c: Revert.
11944 * aarch64-linux-nat.c: Revert.
11945 * aarch64-fbsd-tdep.c: Revert.
11946 * aarch64-fbsd-nat.c: Revert.
11947 * aarch32-linux-nat.c: Revert.
11948
11949 2019-04-05 Tom Tromey <tom@tromey.com>
11950
11951 * ft32-tdep.c: Sort headers.
11952 * frv-tdep.c: Sort headers.
11953 * frv-linux-tdep.c: Sort headers.
11954 * frame.c: Sort headers.
11955 * frame-unwind.c: Sort headers.
11956 * frame-base.c: Sort headers.
11957 * fork-child.c: Sort headers.
11958 * findvar.c: Sort headers.
11959 * findcmd.c: Sort headers.
11960 * filesystem.c: Sort headers.
11961 * filename-seen-cache.h: Sort headers.
11962 * filename-seen-cache.c: Sort headers.
11963 * fbsd-tdep.c: Sort headers.
11964 * fbsd-nat.h: Sort headers.
11965 * fbsd-nat.c: Sort headers.
11966 * f-valprint.c: Sort headers.
11967 * f-typeprint.c: Sort headers.
11968 * f-lang.c: Sort headers.
11969 * extension.h: Sort headers.
11970 * extension.c: Sort headers.
11971 * extension-priv.h: Sort headers.
11972 * expprint.c: Sort headers.
11973 * exec.h: Sort headers.
11974 * exec.c: Sort headers.
11975 * exceptions.c: Sort headers.
11976 * event-top.c: Sort headers.
11977 * event-loop.c: Sort headers.
11978 * eval.c: Sort headers.
11979 * elfread.c: Sort headers.
11980 * dwarf2read.h: Sort headers.
11981 * dwarf2read.c: Sort headers.
11982 * dwarf2loc.c: Sort headers.
11983 * dwarf2expr.h: Sort headers.
11984 * dwarf2expr.c: Sort headers.
11985 * dwarf2-frame.c: Sort headers.
11986 * dwarf2-frame-tailcall.c: Sort headers.
11987 * dwarf-index-write.h: Sort headers.
11988 * dwarf-index-write.c: Sort headers.
11989 * dwarf-index-common.c: Sort headers.
11990 * dwarf-index-cache.h: Sort headers.
11991 * dwarf-index-cache.c: Sort headers.
11992 * dummy-frame.c: Sort headers.
11993 * dtrace-probe.c: Sort headers.
11994 * disasm.h: Sort headers.
11995 * disasm.c: Sort headers.
11996 * disasm-selftests.c: Sort headers.
11997 * dictionary.c: Sort headers.
11998 * dicos-tdep.c: Sort headers.
11999 * demangle.c: Sort headers.
12000 * dcache.h: Sort headers.
12001 * dcache.c: Sort headers.
12002 * darwin-nat.h: Sort headers.
12003 * darwin-nat.c: Sort headers.
12004 * darwin-nat-info.c: Sort headers.
12005 * d-valprint.c: Sort headers.
12006 * d-namespace.c: Sort headers.
12007 * d-lang.c: Sort headers.
12008 * ctf.c: Sort headers.
12009 * csky-tdep.c: Sort headers.
12010 * csky-linux-tdep.c: Sort headers.
12011 * cris-tdep.c: Sort headers.
12012 * cris-linux-tdep.c: Sort headers.
12013 * cp-valprint.c: Sort headers.
12014 * cp-support.c: Sort headers.
12015 * cp-namespace.c: Sort headers.
12016 * cp-abi.c: Sort headers.
12017 * corelow.c: Sort headers.
12018 * corefile.c: Sort headers.
12019 * continuations.c: Sort headers.
12020 * completer.h: Sort headers.
12021 * completer.c: Sort headers.
12022 * complaints.c: Sort headers.
12023 * coffread.c: Sort headers.
12024 * coff-pe-read.c: Sort headers.
12025 * cli-out.h: Sort headers.
12026 * cli-out.c: Sort headers.
12027 * charset.c: Sort headers.
12028 * c-varobj.c: Sort headers.
12029 * c-valprint.c: Sort headers.
12030 * c-typeprint.c: Sort headers.
12031 * c-lang.c: Sort headers.
12032 * buildsym.c: Sort headers.
12033 * buildsym-legacy.c: Sort headers.
12034 * build-id.h: Sort headers.
12035 * build-id.c: Sort headers.
12036 * btrace.c: Sort headers.
12037 * bsd-uthread.c: Sort headers.
12038 * breakpoint.h: Sort headers.
12039 * breakpoint.c: Sort headers.
12040 * break-catch-throw.c: Sort headers.
12041 * break-catch-syscall.c: Sort headers.
12042 * break-catch-sig.c: Sort headers.
12043 * blockframe.c: Sort headers.
12044 * block.c: Sort headers.
12045 * bfin-tdep.c: Sort headers.
12046 * bfin-linux-tdep.c: Sort headers.
12047 * bfd-target.c: Sort headers.
12048 * bcache.c: Sort headers.
12049 * ax-general.c: Sort headers.
12050 * ax-gdb.h: Sort headers.
12051 * ax-gdb.c: Sort headers.
12052 * avr-tdep.c: Sort headers.
12053 * auxv.c: Sort headers.
12054 * auto-load.c: Sort headers.
12055 * arm-wince-tdep.c: Sort headers.
12056 * arm-tdep.c: Sort headers.
12057 * arm-symbian-tdep.c: Sort headers.
12058 * arm-pikeos-tdep.c: Sort headers.
12059 * arm-obsd-tdep.c: Sort headers.
12060 * arm-nbsd-tdep.c: Sort headers.
12061 * arm-nbsd-nat.c: Sort headers.
12062 * arm-linux-tdep.c: Sort headers.
12063 * arm-linux-nat.c: Sort headers.
12064 * arm-fbsd-tdep.c: Sort headers.
12065 * arm-fbsd-nat.c: Sort headers.
12066 * arm-bsd-tdep.c: Sort headers.
12067 * arch-utils.c: Sort headers.
12068 * arc-tdep.c: Sort headers.
12069 * arc-newlib-tdep.c: Sort headers.
12070 * annotate.h: Sort headers.
12071 * annotate.c: Sort headers.
12072 * amd64-windows-tdep.c: Sort headers.
12073 * amd64-windows-nat.c: Sort headers.
12074 * amd64-tdep.c: Sort headers.
12075 * amd64-sol2-tdep.c: Sort headers.
12076 * amd64-obsd-tdep.c: Sort headers.
12077 * amd64-obsd-nat.c: Sort headers.
12078 * amd64-nbsd-tdep.c: Sort headers.
12079 * amd64-nbsd-nat.c: Sort headers.
12080 * amd64-nat.c: Sort headers.
12081 * amd64-linux-tdep.c: Sort headers.
12082 * amd64-linux-nat.c: Sort headers.
12083 * amd64-fbsd-tdep.c: Sort headers.
12084 * amd64-fbsd-nat.c: Sort headers.
12085 * amd64-dicos-tdep.c: Sort headers.
12086 * amd64-darwin-tdep.c: Sort headers.
12087 * amd64-bsd-nat.c: Sort headers.
12088 * alpha-tdep.c: Sort headers.
12089 * alpha-obsd-tdep.c: Sort headers.
12090 * alpha-nbsd-tdep.c: Sort headers.
12091 * alpha-mdebug-tdep.c: Sort headers.
12092 * alpha-linux-tdep.c: Sort headers.
12093 * alpha-linux-nat.c: Sort headers.
12094 * alpha-bsd-tdep.c: Sort headers.
12095 * alpha-bsd-nat.c: Sort headers.
12096 * aix-thread.c: Sort headers.
12097 * agent.c: Sort headers.
12098 * addrmap.c: Sort headers.
12099 * ada-varobj.c: Sort headers.
12100 * ada-valprint.c: Sort headers.
12101 * ada-typeprint.c: Sort headers.
12102 * ada-tasks.c: Sort headers.
12103 * ada-lang.c: Sort headers.
12104 * aarch64-tdep.c: Sort headers.
12105 * aarch64-ravenscar-thread.c: Sort headers.
12106 * aarch64-newlib-tdep.c: Sort headers.
12107 * aarch64-linux-tdep.c: Sort headers.
12108 * aarch64-linux-nat.c: Sort headers.
12109 * aarch64-fbsd-tdep.c: Sort headers.
12110 * aarch64-fbsd-nat.c: Sort headers.
12111 * aarch32-linux-nat.c: Sort headers.
12112
12113 2019-04-04 Tom Tromey <tom@tromey.com>
12114
12115 * varobj.c (varobj_create): Update.
12116 * rust-exp.y (struct rust_parser) <update_innermost_block,
12117 lookup_symbol>: New methods.
12118 (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
12119 Rename.
12120 (rust_parser::rust_lookup_type)
12121 (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
12122 * printcmd.c (display_command, do_one_display): Update.
12123 * parser-defs.h (struct parser_state) <parser_state>: Add
12124 "tracker" parameter.
12125 (block_tracker): New member.
12126 (class innermost_block_tracker) <innermost_block_tracker>: Add
12127 "types" parameter.
12128 <reset>: Remove method.
12129 (innermost_block): Don't declare.
12130 (null_post_parser): Update.
12131 * parse.c (innermost_block): Remove global.
12132 (write_dollar_variable): Update.
12133 (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
12134 Remove "tracker_types" parameter.
12135 (parse_expression): Add "tracker" parameter.
12136 (parse_expression_for_completion): Update.
12137 (null_post_parser): Add "tracker" parameter.
12138 * p-exp.y: Update rules.
12139 * m2-exp.y: Update rules.
12140 * language.h (struct language_defn) <la_post_parser>: Add
12141 "tracker" parameter.
12142 * go-exp.y: Update rules.
12143 * f-exp.y: Update rules.
12144 * expression.h (parse_expression, parse_exp_1): Add "tracker"
12145 parameter.
12146 * d-exp.y: Update rules.
12147 * c-exp.y: Update rules.
12148 * breakpoint.c (set_breakpoint_condition): Create an
12149 innermost_block_tracker.
12150 (watch_command_1): Likewise.
12151 * ada-lang.c (resolve): Add "tracker" parameter.
12152 (resolve_subexp): Likewise.
12153 * ada-exp.y (write_var_from_sym): Update.
12154
12155 2019-04-04 Tom Tromey <tom@tromey.com>
12156
12157 * type-stack.h: New file.
12158 * type-stack.c: New file.
12159 * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
12160 type-stack.h.
12161 (insert_into_type_stack, insert_type, push_type, push_type_int)
12162 (insert_type_address_space, pop_type, pop_type_int)
12163 (pop_typelist, pop_type_stack, append_type_stack)
12164 (push_type_stack, get_type_stack, push_typelist)
12165 (follow_type_instance_flags, follow_types): Don't declare.
12166 * parse.c (type_stack): Remove global.
12167 (parse_exp_in_context): Update.
12168 (insert_into_type_stack, insert_type, push_type, push_type_int)
12169 (insert_type_address_space, pop_type, pop_type_int)
12170 (pop_typelist, pop_type_stack, append_type_stack)
12171 (push_type_stack, get_type_stack, push_typelist)
12172 (follow_type_instance_flags, follow_types): Remove (moved to
12173 type-stack.c).
12174 * f-exp.y (type_stack): New global.
12175 Update rules.
12176 (push_kind_type, f_parse): Update.
12177 * d-exp.y (type_stack): New global.
12178 Update rules.
12179 (d_parse): Update.
12180 * c-exp.y (struct c_parse_state) <type_stack>: New member.
12181 Update rules.
12182 * Makefile.in (COMMON_SFILES): Add type-stack.c.
12183 (HFILES_NO_SRCDIR): Add type-stack.h.
12184
12185 2019-04-04 Tom Tromey <tom@tromey.com>
12186
12187 * rust-exp.y (rust_parser::lex_identifier, rustyylex)
12188 (rust_parser::convert_ast_to_expression, rust_parse)
12189 (rust_lex_test_completion, rust_lex_tests): Update.
12190 * parser-defs.h (struct expr_completion_state): New.
12191 (struct parser_state) <parser_state>: Add completion parameter.
12192 <mark_struct_expression, mark_completion_tag>: New methods.
12193 <parse_completion, m_completion_state>: New members.
12194 (prefixify_expression, null_post_parser): Update.
12195 (mark_struct_expression, mark_completion_tag): Don't declare.
12196 * parse.c (parse_completion, expout_last_struct)
12197 (expout_tag_completion_type, expout_completion_name): Remove
12198 globals.
12199 (parser_state::mark_struct_expression)
12200 (parser_state::mark_completion_tag): Now methods.
12201 (prefixify_expression): Add last_struct parameter.
12202 (prefixify_subexp): Likewise.
12203 (parse_exp_1): Update.
12204 (parse_exp_in_context): Add cstate parameter. Update.
12205 (parse_expression_for_completion): Create an
12206 expr_completion_state.
12207 (null_post_parser): Add "completion" parameter.
12208 * p-exp.y: Update rules.
12209 (yylex): Update.
12210 * language.h (struct language_defn) <la_post_parser>: Add
12211 "completing" parameter.
12212 * go-exp.y: Update rules.
12213 (lex_one_token): Update.
12214 * expression.h (parse_completion): Don't declare.
12215 * d-exp.y: Update rules.
12216 (lex_one_token): Update rules.
12217 * c-exp.y: Update rules.
12218 (lex_one_token): Update.
12219 * ada-lang.c (resolve): Add "parse_completion" parameter.
12220 (resolve_subexp): Likewise.
12221 (ada_resolve_function): Likewise.
12222
12223 2019-04-04 Tom Tromey <tom@tromey.com>
12224
12225 * parser-defs.h (struct parser_state) <start_arglist,
12226 end_arglist>: New methods.
12227 <arglist_len, m_funcall_chain>: New members.
12228 (arglist_len, start_arglist, end_arglist): Don't declare.
12229 * parse.c (arglist_len, funcall_chain): Remove global.
12230 (start_arglist, end_arglist): Remove functions.
12231 (parse_exp_in_context): Update.
12232 * p-exp.y: Update rules.
12233 * m2-exp.y: Update rules.
12234 * go-exp.y: Update rules.
12235 * f-exp.y: Update rules.
12236 * d-exp.y: Update rules.
12237 * c-exp.y: Update rules.
12238
12239 2019-04-04 Tom Tromey <tom@tromey.com>
12240
12241 * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
12242 lex_operator, push_back>: New methods.
12243 Update all rules.
12244 (rust_parser::lex_hex, lex_escape): Rename and update.
12245 (rust_parser::lex_string, rust_parser::lex_identifier): Update.
12246 (rust_parser::lex_operator): Rename and update.
12247 (rust_parser::lex_number, rustyylex, rustyyerror)
12248 (rust_lex_test_init, rust_lex_test_sequence)
12249 (rust_lex_test_push_back, rust_lex_tests): Update.
12250 * parser-defs.h (struct parser_state) <parser_state>: Add "input"
12251 parameter.
12252 <lexptr, prev_lexptr>: New members.
12253 (lexptr, prev_lexptr): Don't declare.
12254 * parse.c (lexptr, prev_lexptr): Remove globals.
12255 (parse_exp_in_context): Update.
12256 * p-exp.y (yylex, yyerror): Update.
12257 * m2-exp.y (parse_number, yylex, yyerror): Update.
12258 * go-exp.y (lex_one_token, yyerror): Update.
12259 * f-exp.y (match_string_literal, yylex, yyerror): Update.
12260 * d-exp.y (lex_one_token, yyerror): Update.
12261 * c-exp.y (scan_macro_expansion, finished_macro_expansion)
12262 (lex_one_token, yyerror): Update.
12263 * ada-lex.l (YY_INPUT): Update.
12264 (rewind_to_char): Update.
12265 * ada-exp.y (yyerror): Update.
12266
12267 2019-04-04 Tom Tromey <tom@tromey.com>
12268
12269 * rust-exp.y (rustyylex, rust_lex_tests): Update.
12270 * parser-defs.h (struct parser_state) <parser_state>: Add new
12271 parameter.
12272 <comma_terminates>: New member.
12273 (comma_terminates): Don't declare global.
12274 * parse.c (comma_terminates): Remove global.
12275 (parse_exp_in_context): Update.
12276 * p-exp.y (yylex): Update.
12277 * m2-exp.y (yylex): Update.
12278 * go-exp.y (lex_one_token): Update.
12279 * f-exp.y (yylex): Update.
12280 * d-exp.y (lex_one_token): Update.
12281 * c-exp.y (lex_one_token): Update.
12282 * ada-lex.l: Update.
12283
12284 2019-04-04 Tom Tromey <tom@tromey.com>
12285
12286 * rust-exp.y (struct rust_parser) <paren_depth>: New member.
12287 (rustyylex, rust_lex_test_init, rust_lex_test_one)
12288 (rust_lex_test_sequence, rust_lex_test_push_back): Update.
12289 * parser-defs.h (paren_depth): Don't declare.
12290 * parse.c (paren_depth): Remove global.
12291 (parse_exp_in_context): Update.
12292 * p-exp.y (paren_depth): New global.
12293 (pascal_parse): Initialize it.
12294 * m2-exp.y (paren_depth): New global.
12295 (m2_parse): Initialize it.
12296 * go-exp.y (paren_depth): New global.
12297 (go_parse): Initialize it.
12298 * f-exp.y (paren_depth): New global.
12299 (f_parse): Initialize it.
12300 * d-exp.y (paren_depth): New global.
12301 (d_parse): Initialize it.
12302 * c-exp.y (paren_depth): New global.
12303 (c_parse): Initialize it.
12304 * ada-lex.l (paren_depth): New global.
12305 (lexer_init): Initialize it.
12306
12307 2019-04-04 Tom Tromey <tom@tromey.com>
12308
12309 * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
12310 (rust_parser::convert_ast_to_type)
12311 (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
12312 * parser-defs.h (struct parser_state) <parser_state>: Add
12313 parameters. Initialize new members.
12314 <expression_context_block, expression_context_pc>: New members.
12315 * parse.c (expression_context_block, expression_context_pc):
12316 Remove globals.
12317 (parse_exp_in_context): Update.
12318 * p-exp.y: Update all rules.
12319 (yylex): Update.
12320 * m2-exp.y: Update all rules.
12321 (yylex): Update.
12322 * go-exp.y (yylex): Update.
12323 * f-exp.y (yylex): Update.
12324 * d-exp.y: Update all rules.
12325 (yylex): Update.
12326 * c-exp.y: Update all rules.
12327 (lex_one_token, classify_name, yylex, c_parse): Update.
12328 * ada-exp.y (write_var_or_type, write_name_assoc): Update.
12329
12330 2019-04-04 Tom Tromey <tom@tromey.com>
12331
12332 * gdbarch.h, gdbarch.c: Rebuild.
12333 * gdbarch.sh (dtrace_parse_probe_argument): Change type.
12334 * stap-probe.h:
12335 (struct stap_parse_info): Replace "parser_state" with
12336 "expr_builder".
12337 * parser-defs.h (struct expr_builder): Rename from "parser_state".
12338 (parser_state): New class.
12339 * parse.c (expr_builder): Rename.
12340 (expr_builder::release): Rename.
12341 (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
12342 (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
12343 (write_exp_elt_longcst, write_exp_elt_floatcst)
12344 (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
12345 (write_exp_string_vector, write_exp_bitstring)
12346 (write_exp_msymbol, mark_struct_expression)
12347 (write_dollar_variable)
12348 (insert_type_address_space, increase_expout_size): Replace
12349 "parser_state" with "expr_builder".
12350 * dtrace-probe.c: Replace "parser_state" with "expr_builder".
12351 * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
12352 "parser_state" with "expr_builder".
12353
12354 2019-04-04 Tom Tromey <tom@tromey.com>
12355
12356 * rust-exp.y: Replace "parse_language" with method call.
12357 * p-exp.y:
12358 (yylex): Replace "parse_language" with method call.
12359 * m2-exp.y:
12360 (yylex): Replace "parse_language" with method call.
12361 * go-exp.y (classify_name): Replace "parse_language" with method
12362 call.
12363 * f-exp.y (yylex): Replace "parse_language" with method call.
12364 * d-exp.y (lex_one_token): Replace "parse_language" with method
12365 call.
12366 * c-exp.y:
12367 (lex_one_token, classify_name, yylex): Replace "parse_language"
12368 with method call.
12369 * ada-exp.y (find_primitive_type, type_char)
12370 (type_system_address): Replace "parse_language" with method call.
12371
12372 2019-04-04 Tom Tromey <tom@tromey.com>
12373
12374 * rust-exp.y: Replace "parse_gdbarch" with method call.
12375 * parse.c (write_dollar_variable, insert_type_address_space):
12376 Replace "parse_gdbarch" with method call.
12377 * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
12378 call.
12379 * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
12380 call.
12381 * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
12382 "parse_gdbarch" with method call.
12383 * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
12384 with method call.
12385 * f-exp.y (parse_type, parse_f_type, yylex): Replace
12386 "parse_gdbarch" with method call.
12387 * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
12388 "parse_gdbarch" with method call.
12389 * c-exp.y (parse_type, parse_number, classify_name): Replace
12390 "parse_gdbarch" with method call.
12391 * ada-lex.l: Replace "parse_gdbarch" with method call.
12392 * ada-exp.y (parse_type, find_primitive_type, type_char)
12393 (type_system_address): Replace "parse_gdbarch" with method call.
12394
12395 2019-04-04 Tom Tromey <tom@tromey.com>
12396
12397 * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
12398 * stap-probe.c (stap_parse_argument): Update.
12399 * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
12400 initial_size parameter.
12401 * rust-exp.y (rust_lex_tests): Update.
12402 * parse.c (parser_state): Update.
12403 (parse_exp_in_context): Update.
12404 * parser-defs.h (struct parser_state) <parser_state>: Remove
12405 "initial_size" parameter.
12406
12407 2019-04-04 Tom Tromey <tom@tromey.com>
12408
12409 * parser-defs.h (increase_expout_size): Don't declare.
12410 * parse.c (increase_expout_size): Now static.
12411
12412 2019-04-04 Thomas Schwinge <thomas@codesourcery.com>
12413
12414 * gnu-nat.c (gnu_nat_target::wait): Fix
12415 target_waitstatus_to_string call.
12416
12417 2019-04-01 Andrew Burgess <andrew.burgess@embecosm.com>
12418
12419 * eval.c (evaluate_subexp_standard): Handle internal functions
12420 during Fortran function call handling.
12421
12422 2019-04-01 Andrew Burgess <andrew.burgess@embecosm.com>
12423
12424 * NEWS: Mention new internal functions.
12425 * dwarf2read.c (dwarf2_init_complex_target_type): New function.
12426 (read_base_type): Use dwarf2_init_complex_target_type.
12427 * value.c (creal_internal_fn): New function.
12428 (cimag_internal_fn): New function.
12429 (_initialize_values): Register new internal functions.
12430
12431 2019-04-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
12432
12433 * infrun.c (stop_all_threads): If debug_infrun, always
12434 trace the wait status after wait_one, using
12435 target_waitstatus_to_string and target_pid_to_str.
12436 (handle_inferior_event): Replace various trace of
12437 wait status kind by a single trace.
12438 * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
12439 wait status kind image by target_waitstatus_to_string.
12440 * target/waitstatus.c (target_waitstatus_to_string): Fix
12441 obsolete comment.
12442
12443 2019-04-01 Tom Tromey <tromey@adacore.com>
12444
12445 PR symtab/23331:
12446 * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
12447
12448 2019-04-01 Sergio Durigan Junior <sergiodj@redhat.com>
12449 Pedro Alves <palves@redhat.com>
12450
12451 * top.c (quit_force): Call 'finalize_values'.
12452 * value.c (finalize_values): New function.
12453 * value.h (finalize_values): Declare.
12454
12455 2019-03-30 Eli Zaretskii <eliz@gnu.org>
12456
12457 * NEWS: Announce $_gdb_major and $_gdb_minor.
12458
12459 * top.c (init_gdb_version_vars): New function.
12460 (gdb_init): Call init_gdb_version_vars.
12461
12462 2019-03-29 Tom Tromey <tromey@adacore.com>
12463
12464 * printcmd.c (_initialize_printcmd): Add usage lines. Update some
12465 help text. Remove dead code.
12466
12467 2019-03-29 Keith Seitz <keiths@redhat.com>
12468
12469 From Siddhesh Poyarekar:
12470 * f-lang.h (f77_get_upperbound): Return LONGEST.
12471 (f77_get_lowerbound): Likewise.
12472 * f-typeprint.c (f_type_print_varspec_suffix): Expand
12473 UPPER_BOUND and LOWER_BOUND to LONGEST. Use plongest to format
12474 print them.
12475 (f_type_print_base): Expand UPPER_BOUND to LONGEST. Use
12476 plongest to format print it.
12477 * f-valprint.c (f77_get_lowerbound): Return LONGEST.
12478 (f77_get_upperbound): Likewise.
12479 (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
12480 LOWER_BOUND to LONGEST.
12481 (f77_create_arrayprint_offset_tbl): Likewise.
12482
12483 2019-03-29 Keith Seitz <keiths@redhat.com>
12484
12485 * ada-lang.c (ada_template_to_fixed_record_type_1): Use
12486 %s/pulongest for TYPE_LENGTH instead of %d in format
12487 strings.
12488 * ada-typerint.c (ada_print_type): Likewise.
12489 * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
12490 * compile/compile-c-support.c (generate_register_struct): Likewise.
12491 * gdbtypes.c (recursive_dump_type): Likewise.
12492 * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
12493 * m2-typeprint.c (m2_array): Use %s/pulongest for TYPE_LENGTH
12494 instead of %d in format strings.
12495 * riscv-tdep.c (riscv_type_alignment): Cast second argument
12496 to std::min to ULONGEST.
12497 * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
12498 instead of %d in format strings.
12499 * tracepoint.c (info_scope_command): Likewise.
12500 * typeprint.c (print_offset_data::update)
12501 (print_offset_data::finish): Likewise.
12502 * xtensa-tdep.c (xtensa_store_return_value)
12503 (xtensa_push_dummy_call): Likewise.
12504
12505 2019-03-28 Jon Turney <jon.turney@dronecode.org.uk>
12506
12507 * windows-nat.c (display_selector): Fixed format specifications
12508 for 64-bit Cygwin.
12509
12510 2019-03-28 Philippe Waroquiers <philippe.waroquiers@skynet.be>
12511
12512 * infrun.c (follow_exec): Call target_terminal::ours_for_output.
12513
12514 2019-03-28 Sandra Loosemore <sandra@codesourcery.com>
12515
12516 * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
12517 * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
12518 * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
12519 (nios2_linux_init_abi): Install it.
12520
12521 2019-03-28 Alan Hayward <alan.hayward@arm.com>
12522
12523 * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
12524
12525 2019-03-28 Alan Hayward <alan.hayward@arm.com>
12526
12527 * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
12528
12529 2019-03-24 Philippe Waroquiers <philippe.waroquiers@skynet.be>
12530 Tom Tromey <tromey@adacore.com>
12531
12532 * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
12533
12534 2019-03-26 Joel Brobecker <brobecker@adacore.com>
12535
12536 * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
12537 (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
12538 method to compute the bounds of range types. Also print "[evaluated]"
12539 if the bounds' values come from a dynamic evaluation.
12540
12541 2019-03-26 Andrew Burgess <andrew.burgess@embecosm.com>
12542
12543 * cp-valprint.c (cp_print_value_fields): Don't print trailing
12544 whitespace when pretty printing is on.
12545
12546 2019-03-26 Alan Hayward <alan.hayward@arm.com>
12547
12548 * ppc-linux-nat.c: Add include.
12549
12550 2019-03-26 Alan Hayward <alan.hayward@arm.com>
12551
12552 * NEWS: Mention AArch64 Pointer Authentication.
12553
12554 2019-03-26 Alan Hayward <alan.hayward@arm.com>
12555
12556 * arm-linux-nat.c: Add include.
12557
12558 2019-03-25 Simon Marchi <simon.marchi@polymtl.ca>
12559
12560 * source-cache.c (source_cache::get_source_lines): Re-read
12561 fullname after calling open_source_file.
12562
12563 2019-03-25 John Baldwin <jhb@FreeBSD.org>
12564
12565 * NEWS: Mention TLS support for FreeBSD.
12566
12567 2019-03-25 Tom Tromey <tromey@adacore.com>
12568
12569 * minsyms.c (BUNCH_SIZE): Update comment.
12570 (~minimal_symbol_reader): Remove old comment.
12571 (compact_minimal_symbols): Update comment.
12572 (minimal_symbol_reader::install): Remove old comment. Update
12573 other comments.
12574
12575 2019-03-25 Alan Hayward <alan.hayward@arm.com>
12576
12577 * s390-linux-nat.c: Add include.
12578
12579 2019-03-25 Alan Hayward <alan.hayward@arm.com>
12580
12581 * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
12582 Call linux_get_hwcap.
12583 * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
12584 Likewise.
12585 (aarch64_linux_get_hwcap): Remove function.
12586 * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
12587 declaration.
12588 * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
12589 linux_get_hwcap.
12590 * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
12591 * linux-tdep.c (linux_get_hwcap): Add function.
12592 (linux_get_hwcap2): Likewise.
12593 * linux-tdep.h (linux_get_hwcap): Add declaration.
12594 (linux_get_hwcap2): Likewise.
12595 * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
12596 (ppc_linux_get_hwcap2): Likewise.
12597 (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
12598 linux_get_hwcap.
12599 (ppc_linux_nat_target::insert_watchpoint): Likewise.
12600 (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
12601 (ppc_linux_nat_target::read_description): Likewise.
12602 * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
12603 * s390-linux-nat.c: Likewise.
12604 * s390-linux-tdep.c (s390_core_read_description): Likewise.
12605
12606 2019-03-24 Tom Tromey <tom@tromey.com>
12607
12608 * ada-lang.c (standard_lookup): Simplify initialization.
12609 (ada_lookup_symbol_nonlocal): Simplify return.
12610 * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
12611 * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
12612 * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
12613 * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
12614 initialization.
12615 * solib.c (solib_global_lookup): Simplify.
12616 * symtab.c (null_block_symbol): Remove.
12617 (symbol_cache_lookup): Simplify returns.
12618 (lookup_language_this): Simplify returns.
12619 (lookup_symbol_aux): Simplify return.
12620 (lookup_local_symbol): Simplify returns.
12621 (lookup_global_symbol_from_objfile): Simplify return.
12622 (lookup_symbol_in_objfile_symtabs)
12623 (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
12624 (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
12625 (lookup_static_symbol, lookup_global_symbol): Simplify return.
12626 * cp-namespace.c (cp_lookup_bare_symbol)
12627 (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
12628 (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
12629 (cp_lookup_nested_symbol): Don't use null_block_symbol.
12630 (cp_lookup_symbol_via_imports): Simplify initialization.
12631 (find_symbol_in_baseclass): Likewise.
12632 * symtab.h (null_block_symbol): Remove.
12633 * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
12634 (d_lookup_nested_symbol, d_lookup_symbol_imports)
12635 (d_lookup_symbol_module): Likewise.
12636 (find_symbol_in_baseclass): Simplify initialization.
12637
12638 2019-03-24 Tom Tromey <tom@tromey.com>
12639
12640 * expression.h: Don't include symtab.h.
12641 (struct block): Forward declare.
12642
12643 2019-03-24 Tom Tromey <tom@tromey.com>
12644
12645 * c-exp.y (typebase): Remove casts.
12646 * gdbtypes.c (lookup_unsigned_typename, )
12647 (lookup_signed_typename): Remove cast.
12648 * eval.c (parse_to_comma_and_eval): Remove cast.
12649 * parse.c (write_dollar_variable): Remove cast.
12650 * block.h (struct block) <superblock>: Now const.
12651 * symfile-debug.c (debug_qf_map_matching_symbols): Update.
12652 * psymtab.c (psym_map_matching_symbols): Make "block" const.
12653 (map_block): Make "block" const.
12654 * symfile.h (struct quick_symbol_functions)
12655 <map_matching_symbols>: Constify block argument to "callback".
12656 * symtab.c (basic_lookup_transparent_type_quick): Make "block"
12657 const.
12658 (find_pc_sect_compunit_symtab): Make "b" const.
12659 (find_symbol_at_address): Likewise.
12660 (search_symbols): Likewise.
12661 * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
12662 (dw2_debug_names_lookup_symbol): Likewise.
12663 (dw2_map_matching_symbols): Update.
12664 * p-valprint.c (pascal_val_print): Remove "block".
12665 * ada-lang.c (ada_add_global_exceptions): Make "b" const.
12666 (aux_add_nonlocal_symbols): Make "block" const.
12667 (resolve_subexp): Remove cast.
12668 * linespec.c (iterate_over_all_matching_symtabs): Make "block"
12669 const.
12670 (iterate_over_file_blocks): Likewise.
12671 * f-exp.y (%union) <bval>: Remove.
12672 * coffread.c (patch_opaque_types): Make "b" const.
12673 * spu-tdep.c (spu_catch_start): Make "block" const.
12674 * c-valprint.c (print_unpacked_pointer): Remove "block".
12675 * symmisc.c (dump_symtab_1): Make "b" const.
12676 (block_depth): Make "block" const.
12677 * d-exp.y (%union) <bval>: Remove.
12678 * cp-support.h (cp_lookup_rtti_type): Update.
12679 * cp-support.c (cp_lookup_rtti_type): Make "block" const.
12680 * psymtab.c (psym_lookup_symbol): Make "block" const.
12681 (maintenance_check_psymtabs): Make "b" const.
12682 * python/py-framefilter.c (extract_sym): Make "sym_block" const.
12683 (enumerate_locals, enumerate_args): Update.
12684 * python/py-symtab.c (stpy_global_block): Make "block" const.
12685 (stpy_static_block): Likewise.
12686 * inline-frame.c (block_starting_point_at): Make "new_block"
12687 const.
12688 * block.c (find_block_in_blockvector): Make return type const.
12689 (blockvector_for_pc_sect): Make "b" const.
12690 (find_block_in_blockvector): Make "b" const.
12691
12692 2019-03-23 Tom Tromey <tom@tromey.com>
12693
12694 * varobj.c (varobj_create): Update.
12695 * symfile.c (clear_symtab_users): Don't reset innermost_block.
12696 * printcmd.c (display_command, do_one_display): Don't reset
12697 innermost_block.
12698 * parser-defs.h (enum innermost_block_tracker_type): Move to
12699 expression.h.
12700 (innermost_block): Update comment.
12701 * parse.c (parse_exp_1): Add tracker_types parameter.
12702 (parse_exp_in_context): Rename from parse_exp_in_context_1. Add
12703 tracker_types parameter. Reset innermost_block.
12704 (parse_exp_in_context): Remove.
12705 (parse_expression_for_completion): Update.
12706 * objfiles.c (~objfile): Don't reset expression_context_block or
12707 innermost_block.
12708 * expression.h (enum innermost_block_tracker_type): Move from
12709 parser-defs.h.
12710 (parse_exp_1): Add tracker_types parameter.
12711 * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
12712 reset innermost_block.
12713
12714 2019-03-23 Tom Tromey <tom@tromey.com>
12715
12716 * objfiles.h: Include bcache.h.
12717
12718 2019-03-23 Tom Tromey <tom@tromey.com>
12719
12720 * linespec.c (get_current_search_block): Use
12721 scoped_restore_current_language.
12722 * symmisc.c (dump_symtab): Use scoped_restore_current_language.
12723
12724 2019-03-22 Alan Hayward <alan.hayward@arm.com>
12725 Jiong Wang <jiong.wang@arm.com>
12726
12727 * aarch64-linux-tdep.c
12728 (aarch64_linux_iterate_over_regset_sections): Check for pauth
12729 section.
12730 * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
12731
12732 2019-03-22 Alan Hayward <alan.hayward@arm.com>
12733 Jiong Wang <jiong.wang@arm.com>
12734
12735 * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
12736 instructions.
12737 (aarch64_analyze_prologue_test): Add PACIASP test.
12738 (aarch64_prologue_prev_register): Unmask PC value.
12739
12740 2019-03-22 Alan Hayward <alan.hayward@arm.com>
12741 Jiong Wang <jiong.wang@arm.com>
12742
12743 * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
12744 (aarch64_dwarf2_prev_register): Unmask PC value.
12745 (aarch64_dwarf2_frame_init_reg): Init pauth registers.
12746 (aarch64_execute_dwarf_cfa_vendor_op): Check for
12747 DW_CFA_AARCH64_negate_ra_state.
12748 (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
12749
12750 2019-03-22 Alan Hayward <alan.hayward@arm.com>
12751 Jiong Wang <jiong.wang@arm.com>
12752
12753 * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
12754 registers.
12755 (aarch64_pseudo_register_name): Likewise.
12756 (aarch64_pseudo_register_type): Likewise.
12757 (aarch64_pseudo_register_reggroup_p): Likewise.
12758 (aarch64_gdbarch_init): Add pauth registers.
12759 * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
12760 (AARCH64_DWARF_PAUTH_DMASK): Likewise.
12761 (AARCH64_DWARF_PAUTH_CMASK): Likewise.
12762 (struct gdbarch_tdep): Add regnum for ra_state.
12763
12764 2019-03-22 Alan Hayward <alan.hayward@arm.com>
12765 Jiong Wang <jiong.wang@arm.com>
12766
12767 * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
12768
12769 2019-03-22 Alan Hayward <alan.hayward@arm.com>
12770 Jiong Wang <jiong.wang@arm.com>
12771
12772 * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
12773 function.
12774 (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
12775 * aarch64-tdep.c (aarch64_cannot_store_register): New function.
12776 (aarch64_gdbarch_init): Add puth registers.
12777 * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
12778 * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
12779 (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
12780
12781 2019-03-22 Alan Hayward <alan.hayward@arm.com>
12782 Jiong Wang <jiong.wang@arm.com>
12783
12784 * aarch64-linux-nat.c
12785 (aarch64_linux_nat_target::read_description): Read PACA hwcap.
12786 * aarch64-linux-tdep.c
12787 (aarch64_linux_core_read_description): Likewise.
12788 (aarch64_linux_get_hwcap): New function.
12789 * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
12790 (aarch64_linux_get_hwcap): New declaration.
12791
12792 2019-03-22 Alan Hayward <alan.hayward@arm.com>
12793 Jiong Wang <jiong.wang@arm.com>
12794
12795 * aarch64-linux-nat.c
12796 (aarch64_linux_nat_target::read_description): Add pauth param.
12797 * aarch64-linux-tdep.c
12798 (aarch64_linux_core_read_description): Likewise.
12799 * aarch64-tdep.c (struct target_desc): Add in pauth.
12800 (aarch64_read_description): Add pauth param.
12801 (aarch64_gdbarch_init): Likewise.
12802 * aarch64-tdep.h (aarch64_read_description): Likewise.
12803 * arch/aarch64.c (aarch64_create_target_description): Likewise.
12804 * arch/aarch64.h (aarch64_create_target_description): Likewise.
12805 * features/Makefile: Add new files.
12806 * features/aarch64-pauth.c: New file.
12807 * features/aarch64-pauth.xml: New file.
12808
12809 2019-03-20 Tom Tromey <tromey@adacore.com>
12810
12811 * infrun.c (handle_inferior_event): Rename from
12812 handle_inferior_event_1. Create a scoped_value_mark.
12813 (handle_inferior_event): Remove.
12814
12815 2019-03-19 Tom Tromey <tromey@adacore.com>
12816
12817 * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
12818 * infrun.h (print_stop_event): Add "displays" parameter.
12819 * infrun.c (print_stop_event): Add "displays" parameter.
12820
12821 2019-03-19 Pedro Alves <palves@redhat.com>
12822
12823 * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
12824 (tui_ui_out::do_text): Add comments. Reset M_LINE to 0 instead of
12825 to -1. Fix TABs vs spaces.
12826 (tui_ui_out::tui_ui_out): Don't initialize fields here.
12827 * tui/tui-out.h (tui_ui_out) Add intro comments.
12828 <m_line, m_start_of_line>: In-class initialize, and add describing
12829 comment.
12830
12831 2019-03-18 Alan Hayward <alan.hayward@arm.com>
12832
12833 * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
12834 variable names.
12835 (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
12836
12837 2019-03-18 Pedro Alves <palves@redhat.com>
12838 Eli Zaretskii <eliz@gnu.org>
12839
12840 * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
12841 m_line and m_start_of_line.
12842
12843 2019-03-18 Eli Zaretskii <eliz@gnu.org>
12844
12845 * tui/tui-io.c (gdb_wgetch): Don't echo CR.
12846 (tui_getc): When gdb_wgetch returns a CR, behave the same as when
12847 it returns a newline. This fixes a regression in TU mode, whereby
12848 the next line is output on the same screen line as the user input.
12849
12850 2019-03-18 Tom Tromey <tromey@adacore.com>
12851
12852 * minsyms.c (minimal_symbol_reader::install): Remove call to
12853 obstack_blank.
12854
12855 2019-03-18 Pedro Alves <palves@redhat.com>
12856
12857 * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
12858 New globals.
12859 (apply_style): New, factored out from ...
12860 (apply_ansi_escape): ... this. Handle reverse video mode.
12861 (tui_set_reverse_mode): New function.
12862 * tui/tui-io.h (tui_set_reverse_mode): New declaration.
12863 * tui/tui-winsource.c (tui_show_source_line): Use
12864 tui_set_reverse_mode instead of setting A_STANDOUT.
12865 * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
12866 New setter methods.
12867
12868 2019-03-18 Hannes Domani <ssbssa@yahoo.de>
12869
12870 * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
12871 Handle tabs.
12872
12873 2019-03-18 Tom Tromey <tromey@adacore.com>
12874
12875 * ada-lang.c (empty_array): Add "high" parameter.
12876 (ada_evaluate_subexp): Update.
12877
12878 2019-03-17 Sergei Trofimovich <siarheit@google.com>
12879
12880 * unittests/string_view-selftests.c: Define
12881 _initialize_string_view_selftests unconditionally.
12882
12883 2019-03-17 Vladimir Martyanov <vilgeforce@gmail.com>
12884
12885 PR gdb/24350
12886 * windows-nat.c (windows_make_so): Remove unused text_vma variable.
12887
12888 2019-03-17 Vladimir Martyanov <vilgeforce@gmail.com>
12889
12890 PR gdb/24351
12891 * windows-nat.c (display_selector): Fix format specifiers.
12892
12893 2019-03-17 Eli Zaretskii <eliz@gnu.org>
12894
12895 * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
12896 tui_refill_source_window instead of tui_refresh_win, to update the
12897 current execution line. This fixes redisplay of the current line
12898 when stepping through the code with "next" or "step".
12899
12900 2019-03-16 Eli Zaretskii <eliz@gnu.org>
12901
12902 * source-cache.c (source_cache::get_source_lines): Call
12903 find_source_lines to initialize s->nlines. This fixes vertical
12904 scrolling of TUI source window when the DOWN arrow is pressed.
12905
12906 2019-03-16 Philippe Waroquiers <philippe.waroquiers@skynet.be>
12907
12908 * auto-load.c (_initialize_auto_load): Fix 'This options has'.
12909 linux-thread-db.c (_initialize_thread_db): Likewise.
12910
12911 2019-03-16 Eli Zaretskii <eliz@gnu.org>
12912
12913 * tui/tui-winsource.c (tui_show_source_line): Revert "Use
12914 wclrtoeol in tui_show_source_line". This reverts changes made in
12915 commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
12916
12917 2019-03-15 Tom Tromey <tom@tromey.com>
12918
12919 * symtab.h (struct minimal_symbol): Derive from
12920 general_symbol_info.
12921 (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
12922 (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
12923 (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
12924 (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
12925 (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
12926 (MSYMBOL_SEARCH_NAME): Update.
12927 (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
12928 * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
12929 * minsyms.c (minimal_symbol_reader::record_full): Update.
12930
12931 2019-03-15 Tom Tromey <tom@tromey.com>
12932
12933 * minsyms.c (minimal_symbol_reader::install): Use memcpy.
12934
12935 2019-03-15 Tom Tromey <tom@tromey.com>
12936
12937 * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
12938 unique_xmalloc_ptr.
12939 (objfile::msymbols_range::begin, objfile::msymbols_range::end):
12940 Update.
12941 * minsyms.c (lookup_minimal_symbol_by_pc_section)
12942 (build_minimal_symbol_hash_tables)
12943 (minimal_symbol_reader::install): Update.
12944
12945 2019-03-15 Tom Tromey <tom@tromey.com>
12946
12947 * symtab.c (create_demangled_names_hash): Update.
12948 (symbol_set_names): Update.
12949 * objfiles.h (struct objfile_per_bfd_storage)
12950 <demangled_names_hash>: Now an htab_up.
12951 * objfiles.c (objfile_per_bfd_storage): Simplify.
12952
12953 2019-03-15 Tom Tromey <tom@tromey.com>
12954
12955 * objfiles.h (struct objfile_per_bfd_storage): Declare
12956 destructor.
12957 * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
12958 New.
12959 (get_objfile_bfd_data): Use new. Don't initialize
12960 language_of_main.
12961 (free_objfile_per_bfd_storage): Remove.
12962 (objfile_bfd_data_free, objfile::~objfile): Use delete.
12963
12964 2019-03-15 Tom Tromey <tom@tromey.com>
12965
12966 * symfile.c (reread_symbols): Update.
12967 * objfiles.c (objfile::objfile): Update.
12968 * minsyms.h (terminate_minimal_symbol_table): Don't declare.
12969 * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
12970 comment.
12971 (minimal_symbol_reader::install): Update.
12972 (terminate_minimal_symbol_table): Remove.
12973 * jit.c (jit_object_close_impl): Update.
12974
12975 2019-03-15 Tom Tromey <tom@tromey.com>
12976
12977 * minsyms.c (minimal_symbol_reader::record_full): Remove some
12978 initializations.
12979
12980 2019-03-15 Tom Tromey <tom@tromey.com>
12981
12982 * objfiles.h (struct objfile_per_bfd_storage)
12983 <demangled_hash_languages>: Now a bitset.
12984 * minsyms.c (add_minsym_to_demangled_hash_table): Update.
12985 (lookup_minimal_symbol): Update.
12986
12987 2019-03-15 Tom Tromey <tom@tromey.com>
12988
12989 * minsyms.h (class minimal_symbol_reader) <record_with_info>:
12990 Don't return the symbol.
12991 * coffread.c (record_minimal_symbol): Use record_full.
12992
12993 2019-03-14 Eli Zaretskii <eliz@gnu.org>
12994
12995 The MS-Windows port of ncurses fails to switch to a color pair if
12996 one or both of the colors are the implicit default colors. This
12997 change records the default colors when TUI is initialized, and
12998 then specifies them explicitly when a color pair uses the default
12999 colors. This allows color styling in TUI mode on MS-Windows.
13000
13001 * tui/tui-io.c [__MINGW32__]: Include windows.h. Declare
13002 ncurses_norm_attr.
13003 (tui_initialize_io) [__MINGW32__]: Record the default terminal
13004 colors in ncurses_norm_attr.
13005 (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
13006 "none", replace it with the default color recorded in
13007 ncurses_norm_attr.
13008
13009 2019-03-14 Tom Tromey <tromey@adacore.com>
13010
13011 * source-cache.h (class source_cache) <get_source_lines>: Return
13012 std::string.
13013 * source-cache.c (source_cache::extract_lines): Handle case where
13014 first_pos==npos. Return std::string.
13015 (source_cache::get_source_lines): Update.
13016
13017 2019-03-14 Tom Tromey <tromey@adacore.com>
13018
13019 * NEWS: Add item for "style sources" commands.
13020 * source-cache.c (source_cache::get_source_lines): Check
13021 source_styling.
13022 * cli/cli-style.c (source_styling): New global.
13023 (_initialize_cli_style): Add "style sources" commands.
13024 (show_style_sources): New function.
13025 * cli/cli-style.h (source_styling): Declare.
13026
13027 2019-03-14 Pedro Alves <palves@redhat.com>
13028 Tom Tromey <tromey@adacore.com>
13029
13030 * tui/tui-winsource.h (tui_refill_source_window): Declare.
13031 * tui/tui-winsource.c (tui_refill_source_window): New function,
13032 from...
13033 (tui_horizontal_source_scroll): ... here. Move some logic.
13034 * cli/cli-style.c (set_style_enabled): Notify new observable.
13035 * tui/tui-hooks.c (tui_redisplay_source): New function.
13036 (tui_attach_detach_observers): Attach or detach
13037 tui_redisplay_source.
13038 * observable.h (source_styling_changed): New observable.
13039 * observable.c: Define source_styling_changed observable.
13040
13041 2019-03-13 Tom Tromey <tromey@adacore.com>
13042
13043 * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
13044 (i386_gnu_nat_target::store_registers): Update.
13045 * target-debug.h (target_debug_print_std_string): New macro.
13046 * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
13047 * windows-tdep.c (display_one_tib): Update.
13048 * tui/tui-stack.c (tui_make_status_line): Update.
13049 * top.c (print_inferior_quit_action): Update.
13050 * thread.c (thr_try_catch_cmd): Update.
13051 (add_thread_with_info): Update.
13052 (thread_target_id_str): Update.
13053 (thr_try_catch_cmd): Update.
13054 (thread_command): Update.
13055 (thread_find_command): Update.
13056 * record-btrace.c (record_btrace_target::info_record)
13057 (record_btrace_resume_thread, record_btrace_target::resume)
13058 (record_btrace_cancel_resume, record_btrace_step_thread)
13059 (record_btrace_target::wait, record_btrace_target::wait)
13060 (record_btrace_target::wait, record_btrace_target::stop): Update.
13061 * progspace.c (print_program_space): Update.
13062 * process-stratum-target.c
13063 (process_stratum_target::thread_address_space): Update.
13064 * linux-fork.c (linux_fork_mourn_inferior)
13065 (detach_checkpoint_command, info_checkpoints_command)
13066 (linux_fork_context): Update.
13067 (linux_fork_detach): Update.
13068 (class scoped_switch_fork_info): Update.
13069 (delete_checkpoint_command): Update.
13070 * infrun.c (follow_fork_inferior): Update.
13071 (follow_fork_inferior): Update.
13072 (proceed_after_vfork_done): Update.
13073 (handle_vfork_child_exec_or_exit): Update.
13074 (follow_exec): Update.
13075 (displaced_step_prepare_throw): Update.
13076 (displaced_step_restore): Update.
13077 (start_step_over): Update.
13078 (resume_1): Update.
13079 (clear_proceed_status_thread): Update.
13080 (proceed): Update.
13081 (print_target_wait_results): Update.
13082 (do_target_wait): Update.
13083 (context_switch): Update.
13084 (stop_all_threads): Update.
13085 (restart_threads): Update.
13086 (finish_step_over): Update.
13087 (handle_signal_stop): Update.
13088 (switch_back_to_stepped_thread): Update.
13089 (keep_going_pass_signal): Update.
13090 (print_exited_reason): Update.
13091 (normal_stop): Update.
13092 * inferior.c (inferior_pid_to_str): Change return type.
13093 (print_selected_inferior): Update.
13094 (add_inferior): Update.
13095 (detach_inferior): Update.
13096 * dummy-frame.c (fprint_dummy_frames): Update.
13097 * dcache.c (dcache_info_1): Update.
13098 * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
13099 (btrace_fetch, btrace_clear): Update.
13100 * linux-tdep.c (linux_core_pid_to_str): Change return type.
13101 * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
13102 type.
13103 * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
13104 * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
13105 * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
13106 * gdbarch.c, gdbarch.h: Rebuild.
13107 * gdbarch.sh (core_pid_to_str): Change return type.
13108 * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
13109 return type.
13110 (windows_nat_target::pid_to_str): Change return type.
13111 (windows_delete_thread): Update.
13112 (windows_nat_target::attach): Update.
13113 (windows_nat_target::files_info): Update.
13114 * target-delegates.c: Rebuild.
13115 * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
13116 return type.
13117 (sol_thread_target::pid_to_str): Change return type.
13118 * remote.c (class remote_target) <pid_to_str>: Change return
13119 type.
13120 (remote_target::pid_to_str): Change return type.
13121 (extended_remote_target::attach, remote_target::remote_stop_ns)
13122 (remote_target::remote_notif_remove_queued_reply)
13123 (remote_target::push_stop_reply, remote_target::disable_btrace):
13124 Update.
13125 (extended_remote_target::attach): Update.
13126 * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
13127 type.
13128 (gdbsim_target::pid_to_str): Change return type.
13129 * ravenscar-thread.c (struct ravenscar_thread_target)
13130 <pid_to_str>: Change return type.
13131 (ravenscar_thread_target::pid_to_str): Change return type.
13132 * procfs.c (class procfs_target) <pid_to_str>: Change return
13133 type.
13134 (procfs_target::pid_to_str): Change return type.
13135 (procfs_target::attach): Update.
13136 (procfs_target::detach): Update.
13137 (procfs_target::fetch_registers): Update.
13138 (procfs_target::store_registers): Update.
13139 (procfs_target::wait): Update.
13140 (procfs_target::files_info): Update.
13141 * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
13142 * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
13143 return type.
13144 (nto_procfs_target::pid_to_str): Change return type.
13145 (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
13146 * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
13147 return type.
13148 * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
13149 (exit_lwp): Update.
13150 (attach_proc_task_lwp_callback, get_detach_signal)
13151 (detach_one_lwp, resume_lwp, linux_nat_target::resume)
13152 (linux_nat_target::resume, wait_lwp, stop_callback)
13153 (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
13154 (save_stop_reason, select_event_lwp, linux_nat_filter_event)
13155 (linux_nat_wait_1, resume_stopped_resumed_lwps)
13156 (linux_nat_target::wait, linux_nat_stop_lwp): Update.
13157 * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
13158 type.
13159 (inf_ptrace_target::attach): Update.
13160 (inf_ptrace_target::files_info): Update.
13161 * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
13162 type.
13163 (go32_nat_target::pid_to_str): Change return type.
13164 * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
13165 (gnu_nat_target::wait): Update.
13166 (gnu_nat_target::wait): Update.
13167 (gnu_nat_target::resume): Update.
13168 * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
13169 (fbsd_nat_target::wait): Update.
13170 * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
13171 type.
13172 (darwin_nat_target::attach): Update.
13173 * corelow.c (class core_target) <pid_to_str>: Change return type.
13174 (core_target::pid_to_str): Change return type.
13175 * target.c (normal_pid_to_str): Change return type.
13176 (default_pid_to_str): Likewise.
13177 (target_pid_to_str): Change return type.
13178 (target_translate_tls_address): Update.
13179 (target_announce_detach): Update.
13180 * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
13181 return type.
13182 (bsd_uthread_target::pid_to_str): Change return type.
13183 * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
13184 type.
13185 (bsd_kvm_target::pid_to_str): Change return type.
13186 * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
13187 return type.
13188 (aix_thread_target::pid_to_str): Change return type.
13189 * target.h (struct target_ops) <pid_to_str>: Change return type.
13190 (target_pid_to_str, normal_pid_to_str): Likewise.
13191 * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
13192 type.
13193 * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
13194 type.
13195 * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
13196 return type.
13197 * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
13198 type.
13199 * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
13200 type.
13201 * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
13202 return type.
13203
13204 2019-03-13 Simon Marchi <simon.marchi@ericsson.com>
13205
13206 * NEWS: Mention that the new default MI version is 3. Mention
13207 changes to the output of commands and events that deal with
13208 multi-location breakpoints.
13209 * breakpoint.c: Include "mi/mi-out.h".
13210 (print_one_breakpoint): Change output syntax if using MI version
13211 >= 3.
13212 * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
13213 New.
13214 (mi_multi_location_breakpoint_output_fixed): New.
13215 * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
13216 (mi_cmd_fix_multi_location_breakpoint_output): New.
13217 (mi_multi_location_breakpoint_output_fixed): New.
13218 * mi/mi-cmds.c (mi_cmds): Register command
13219 -fix-multi-location-breakpoint-output.
13220 * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
13221 interpreter "mi".
13222
13223 2019-03-13 Simon Marchi <simon.marchi@polymtl.ca>
13224
13225 * mi/mi-out.h (mi_out_new): Change parameter to const char *.
13226 * mi/mi-out.c (mi_out_new): Change parameter to const char *,
13227 instantiate mi_ui_out based on interpreter name.
13228 * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
13229 * mi/mi-main.c (mi_load_progress): Likewise.
13230
13231 2019-03-12 John Baldwin <jhb@FreeBSD.org>
13232
13233 * NEWS: Combine separate "New targets" sections for 8.3.
13234
13235 2019-03-12 John Baldwin <jhb@FreeBSD.org>
13236
13237 * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
13238 (ppcfbsd_init_abi): Install gdbarch
13239 "fetch_tls_load_module_address" and "get_thread_local_address"
13240 methods.
13241
13242 2019-03-12 John Baldwin <jhb@FreeBSD.org>
13243
13244 * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
13245 (riscv_fbsd_init_abi): Install gdbarch
13246 "fetch_tls_load_module_address" and "get_thread_local_address"
13247 methods.
13248
13249 2019-03-12 John Baldwin <jhb@FreeBSD.org>
13250
13251 * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
13252 (i386fbsd_init_abi): Install gdbarch
13253 "fetch_tls_load_module_address" and "get_thread_local_address"
13254 methods.
13255
13256 2019-03-12 John Baldwin <jhb@FreeBSD.org>
13257
13258 * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
13259 (amd64fbsd_init_abi): Install gdbarch
13260 "fetch_tls_load_module_address" and "get_thread_local_address"
13261 methods.
13262
13263 2019-03-12 John Baldwin <jhb@FreeBSD.org>
13264
13265 * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
13266 (struct fbsd_pspace_data): New type.
13267 (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
13268 (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
13269 (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
13270 (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
13271 * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
13272
13273 2019-03-12 John Baldwin <jhb@FreeBSD.org>
13274
13275 * gdbtypes.c (lookup_struct_elt): New function.
13276 (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
13277 * gdbtypes.h (struct struct_elt): New type.
13278 (lookup_struct_elt): New prototype.
13279
13280 2019-03-12 John Baldwin <jhb@FreeBSD.org>
13281
13282 * gdbtypes.c (lookup_struct_elt_type): Update comment and
13283 remove disabled code block.
13284
13285 2019-03-12 John Baldwin <jhb@FreeBSD.org>
13286
13287 * gdbarch.sh (get_thread_local_address): New method.
13288 * gdbarch.h, gdbarch.c: Regenerate.
13289 * target.c (target_translate_tls_address): Use
13290 gdbarch_get_thread_local_address if present instead of
13291 target::get_thread_local_address.
13292
13293 2019-03-12 John Baldwin <jhb@FreeBSD.org>
13294
13295 * target.h (target::get_thread_local_address): Update comment.
13296
13297 2019-03-12 John Baldwin <jhb@FreeBSD.org>
13298
13299 * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
13300 objfile->separate_debug_objfile_backlink if not NULL.
13301
13302 2019-03-12 John Baldwin <jhb@FreeBSD.org>
13303
13304 * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
13305 tdep->fsbase_regnum instead of constants for fs_base and gs_base.
13306 (amd64bsd_store_inferior_registers): Likewise.
13307 * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
13308 Enable segment base registers.
13309 * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
13310 PT_GETFSBASE and PT_GETGSBASE.
13311 (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
13312 PT_SETGSBASE.
13313 * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
13314 segment base registers.
13315 * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
13316
13317 2019-03-12 John Baldwin <jhb@FreeBSD.org>
13318
13319 * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
13320 Update calls to i386_target_description to add 'segments'
13321 parameter.
13322 * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum. Don't
13323 add segment base registers.
13324 * arch/i386.c (i386_create_target_description): Add 'segments'
13325 parameter to enable segment base registers.
13326 * arch/i386.h (i386_create_target_description): Likewise.
13327 * features/i386/32bit-segments.xml: New file.
13328 * features/i386/32bit-segments.c: Generate.
13329 * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
13330 call to i386_target_description to add 'segments' parameter.
13331 * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
13332 * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
13333 * i386-linux-tdep.c (i386_linux_read_description): Likewise.
13334 * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
13335 if feature is present.
13336 (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
13337 Add 'segments' parameter to call to i386_target_description.
13338 (i386_target_description): Add 'segments' parameter to enable
13339 segment base registers.
13340 (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
13341 to call to i386_target_description.
13342 * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
13343 (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
13344 Define I386_NUM_REGS.
13345 (i386_target_description): Add 'segments' parameter to enable
13346 segment base registers.
13347
13348 2019-03-12 Eli Zaretskii <eliz@gnu.org>
13349
13350 PR/24325
13351 * source-cache.c: #undef open and close, to avoid unresolved
13352 externals during linking.
13353
13354 2019-03-12 Tom Tromey <tromey@adacore.com>
13355
13356 * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
13357 const. Add initializers.
13358 (_initialize_remote): Don't initialize ptid globals.
13359
13360 2019-03-12 Pedro Alves <palves@redhat.com>
13361
13362 * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
13363
13364 2019-03-12 Pedro Alves <palves@redhat.com>
13365
13366 * cp-name-parser.y (main): Remove unused 'len' variable.
13367
13368 2019-03-12 Tom Tromey <tromey@adacore.com>
13369
13370 * common/ptid.c (null_ptid, minus_one_ptid): Now const.
13371 * common/ptid.h (null_ptid, minus_one_ptid): Now const.
13372
13373 2019-03-12 Tom Tromey <tromey@adacore.com>
13374
13375 * linux-nat.c (iterate_over_lwps): Update.
13376 (stop_callback): Remove parameter.
13377 (stop_wait_callback, detach_callback, resume_set_callback)
13378 (select_singlestep_lwp_callback, set_ignore_sigint)
13379 (status_callback, resumed_callback, resume_clear_callback)
13380 (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
13381 data parameter.
13382 (linux_nat_target::detach, linux_nat_target::resume)
13383 (linux_stop_and_wait_all_lwps, select_event_lwp)
13384 (linux_nat_filter_event, linux_nat_wait_1)
13385 (linux_nat_target::kill, linux_nat_target::stop)
13386 (linux_nat_target::stop): Update.
13387 (linux_nat_resume_callback): Change type.
13388 (resume_stopped_resumed_lwps, count_events_callback)
13389 (select_event_lwp_callback): Likewise.
13390 (linux_stop_lwp, linux_nat_stop_lwp): Update.
13391 * arm-linux-nat.c (struct update_registers_data): Remove.
13392 (update_registers_callback): Change type.
13393 (arm_linux_insert_hw_breakpoint1): Update.
13394 * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
13395 parameter.
13396 (x86_linux_dr_set_addr): Update.
13397 (x86_linux_dr_set_control): Update.
13398 * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
13399 (iterate_over_lwps): Use gdb::function_view.
13400 * nat/aarch64-linux-hw-point.c (struct
13401 aarch64_dr_update_callback_param): Remove.
13402 (debug_reg_change_callback): Change type.
13403 (aarch64_notify_debug_reg_change): Update.
13404 * s390-linux-nat.c (s390_refresh_per_info): Update.
13405
13406 2019-03-11 Tom Tromey <tromey@adacore.com>
13407
13408 * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
13409 redundant assignment to "this_cu".
13410
13411 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
13412
13413 * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
13414
13415 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
13416
13417 * gdbtypes.c (rank_one_type_parm_set): New function extracted
13418 from...
13419 (rank_one_type): ... this.
13420
13421 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
13422
13423 * gdbtypes.c (rank_one_type_parm_struct): New function extracted
13424 from...
13425 (rank_one_type): ... this.
13426
13427 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
13428
13429 * gdbtypes.c (rank_one_type_parm_complex): New function extracted
13430 from...
13431 (rank_one_type): ... this.
13432
13433 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
13434
13435 * gdbtypes.c (rank_one_type_parm_float): New function extracted
13436 from...
13437 (rank_one_type): ... this.
13438
13439 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
13440
13441 * gdbtypes.c (rank_one_type_parm_bool): New function extracted
13442 from...
13443 (rank_one_type): ... this.
13444
13445 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
13446
13447 * gdbtypes.c (rank_one_type_parm_range): New function extracted
13448 from...
13449 (rank_one_type): ... this.
13450
13451 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
13452
13453 * gdbtypes.c (rank_one_type_parm_char): New function extracted
13454 from...
13455 (rank_one_type): ... this.
13456
13457 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
13458
13459 * gdbtypes.c (rank_one_type_parm_enum): New function extracted
13460 from...
13461 (rank_one_type): ... this.
13462
13463 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
13464
13465 * gdbtypes.c (rank_one_type_parm_int): New function extracted
13466 from...
13467 (rank_one_type): ... this.
13468
13469 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
13470
13471 * gdbtypes.c (rank_one_type_parm_func): New function extracted
13472 from...
13473 (rank_one_type): ... this.
13474
13475 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
13476
13477 * gdbtypes.c (rank_one_type_parm_array): New function extracted
13478 from...
13479 (rank_one_type): ... this.
13480
13481 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
13482
13483 * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
13484 from...
13485 (rank_one_type): ... this.
13486
13487 2019-02-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
13488
13489 * inferior.c (initialize_inferiors): Ensure 'help set/show print
13490 inferior-events' shows the example events.
13491
13492 2019-03-08 Eli Zaretskii <eliz@gnu.org>
13493
13494 Support styling on native MS-Windows console
13495
13496 PR/24315
13497 * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
13498 on MS-Windows if $TERM is not defined.
13499
13500 * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
13501
13502 * posix-hdep.c (gdb_console_fputs):
13503 * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
13504 functions.
13505 * ui-file.h (gdb_console_fputs): Add prototype.
13506
13507 * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
13508 back to fputs only if the former returns zero.
13509
13510 2019-03-07 Tom Tromey <tom@tromey.com>
13511
13512 * symmisc.c (print_symbol_bcache_statistics): Update.
13513 (print_objfile_statistics): Update.
13514 * symfile.c (allocate_symtab): Update.
13515 * stabsread.c: Don't include bcache.h.
13516 * psymtab.h (struct psymbol_bcache): Don't declare.
13517 (class psymtab_storage) <psymbol_cache>: Now a bcache.
13518 (psymbol_bcache_init, psymbol_bcache_free)
13519 (psymbol_bcache_get_bcache): Don't declare.
13520 * psymtab.c (struct psymbol_bcache): Remove.
13521 (psymtab_storage::psymtab_storage): Update.
13522 (psymtab_storage::~psymtab_storage): Update.
13523 (psymbol_bcache_init, psymbol_bcache_free)
13524 (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
13525 (add_psymbol_to_bcache): Update.
13526 (allocate_psymtab): Update.
13527 * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
13528 macro_cache>: No longer pointers.
13529 * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
13530 (free_objfile_per_bfd_storage): Don't call bcache_xfree.
13531 * macrotab.c (macro_bcache): Update.
13532 * macroexp.c: Don't include bcache.h.
13533 * gdbtypes.c (check_types_worklist): Update.
13534 (types_deeply_equal): Remove TRY/CATCH. Update.
13535 * elfread.c (elf_symtab_read): Update.
13536 * dwarf2read.c: Don't include bcache.h.
13537 * buildsym.c (buildsym_compunit::get_macro_table): Update.
13538 * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
13539 (print_bcache_statistics, bcache_memory_used): Don't declare.
13540 (struct bcache): Move from bcache.c. Add constructor, destructor,
13541 methods. Rename all data members.
13542 * bcache.c (struct bcache): Move to bcache.h.
13543 (bcache::expand_hash_table): Rename from expand_hash_table.
13544 (bcache): Remove.
13545 (bcache::insert): Rename from bcache_full.
13546 (bcache::compare): Rename from bcache_compare.
13547 (bcache_xmalloc): Remove.
13548 (bcache::~bcache): Rename from bcache_xfree.
13549 (bcache::print_statistics): Rename from print_bcache_statistics.
13550 (bcache::memory_used): Rename from bcache_memory_used.
13551
13552 2019-03-07 Pedro Alves <palves@redhat.com>
13553
13554 * infrun.c (normal_stop): Also check for
13555 TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
13556
13557 2019-03-07 Andrew Burgess <andrew.burgess@embecosm.com>
13558
13559 * f-lang.c (value_from_host_double): Moved to...
13560 * value.c (value_from_host_double): ...here.
13561 * value.h (value_from_host_double): Declare.
13562 * guile/scm-math.c (vlscm_convert_typed_number): Use
13563 value_from_host_double.
13564 (vlscm_convert_number): Likewise.
13565 * guile/scm-value.c (gdbscm_value_to_real): Likewise.
13566 * python/py-value.c (convert_value_from_python): Likewise.
13567
13568 2019-03-06 Tom Tromey <tom@tromey.com>
13569
13570 * gcore.c (write_gcore_file): Use SCOPE_EXIT.
13571
13572 2019-03-06 Tom Tromey <tom@tromey.com>
13573
13574 * utils.h (free_current_contents): Don't declare.
13575 * utils.c (free_current_contents): Remove.
13576
13577 2019-03-06 Tom Tromey <tom@tromey.com>
13578
13579 * top.c (quit_force): Update.
13580 * main.c (captured_command_loop): Update.
13581 * common/new-op.c (operator new): Update.
13582 * common/common-exceptions.c (struct catcher)
13583 <save_cleanup_chain>: Remove member.
13584 (exceptions_state_mc_init): Update.
13585 (exception_try_scope_entry): Return nullptr.
13586 (exception_try_scope_exit, exception_rethrow)
13587 (throw_exception_sjlj, throw_exception_cxx): Update.
13588 * common/cleanups.h (make_cleanup, make_cleanup_dtor)
13589 (all_cleanups, do_cleanups, discard_cleanups)
13590 (discard_final_cleanups, save_cleanups, save_final_cleanups)
13591 (restore_cleanups, restore_final_cleanups): Don't declare.
13592 (do_final_cleanups): Remove parameter.
13593 * common/cleanups.c (cleanup_chain, make_cleanup)
13594 (make_cleanup_dtor, all_cleanups, do_cleanups)
13595 (discard_my_cleanups, discard_cleanups)
13596 (discard_final_cleanups, save_my_cleanups, save_cleanups)
13597 (save_final_cleanups, restore_my_cleanups, restore_cleanups)
13598 (null_cleanup): Remove.
13599 (do_final_cleanups): Remove parameter.
13600
13601 2019-03-06 Tom Tromey <tom@tromey.com>
13602
13603 * remote.c (remote_target::remote_parse_stop_reply): Use
13604 unique_xmalloc_ptr.
13605
13606 2019-03-06 Tom Tromey <tom@tromey.com>
13607
13608 * stabsread.c (struct stabs_field_info): Rename from field_info.
13609 <list, fnlist>: Add initializers.
13610 <obstack>: New member.
13611 (read_member_functions, read_struct_fields, read_baseclasses):
13612 Allocate on obstack. Don't use cleanups.
13613 (read_one_struct_field, read_member_functions, read_struct_fields)
13614 (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
13615 (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
13616 (read_struct_type): Update.
13617
13618 2019-03-06 Tom Tromey <tom@tromey.com>
13619
13620 * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
13621 * common/filestuff.h (make_cleanup_close): Don't declare.
13622 * common/filestuff.c (do_close_cleanup, make_cleanup_close):
13623 Remove.
13624
13625 2019-03-06 Tom Tromey <tom@tromey.com>
13626
13627 * solib-aix.c: Use make_scope_exit.
13628
13629 2019-03-06 Tom Tromey <tom@tromey.com>
13630
13631 * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
13632 Use make_scope_exit.
13633
13634 2019-03-06 Tom Tromey <tom@tromey.com>
13635
13636 * solib-svr4.c (disable_probes_interface): Remove parameter.
13637 (svr4_handle_solib_event): Use make_scope_exit.
13638
13639 2019-03-06 Tom Tromey <tom@tromey.com>
13640
13641 * remote.c (struct stop_reply_deleter): Remove.
13642 (stop_reply_up): Update.
13643 (struct stop_reply): Derive from notif_event. Don't typedef.
13644 <regcache>: Now a std::vector.
13645 (stop_reply_xfree): Remove.
13646 (stop_reply::~stop_reply): Rename from stop_reply_dtr.
13647 (remote_notif_stop_alloc_reply): Return a unique_ptr. Use new.
13648 (remote_target::discard_pending_stop_replies): Use delete.
13649 (remote_target::remote_parse_stop_reply): Update.
13650 (remote_target::process_stop_reply): Update.
13651 * remote-notif.h (struct notif_event): Add virtual destructor.
13652 Remove "dtr" member.
13653 (struct notif_client) <alloc_event>: Return a unique_ptr.
13654 (notif_event_xfree): Don't declare.
13655 (notif_event_up): New typedef.
13656 * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
13657 (notif_event_xfree, do_notif_event_xfree): Remove.
13658 (remote_notif_state_xfree): Update.
13659
13660 2019-03-06 Tom Tromey <tom@tromey.com>
13661
13662 * infrun.c (displaced_step_clear_cleanup): Now a
13663 forward_scope_exit type.
13664 (displaced_step_prepare_throw): Update.
13665 (displaced_step_fixup): Update.
13666
13667 2019-03-06 Tom Tromey <tom@tromey.com>
13668
13669 * inferior.h (class inferior): Update comment.
13670 * gdbthread.h (class thread_info): Update comment.
13671
13672 2019-03-06 Joel Brobecker <brobecker@adacore.com>
13673 Tom Tromey <tom@tromey.com>
13674
13675 * stabsread.h (struct stab_section_list): Remove.
13676 (coffstab_build_psymtabs): Update.
13677 * dbxread.c (symbuf_sections): Now a std::vector.
13678 (sect_idx): New global.
13679 (fill_symbuf): Update.
13680 (coffstab_build_psymtabs): Change type of stabsects parameter.
13681 Update.
13682 * coffread.c (struct coff_symfile_info) <stabsects>: Now a
13683 std::vector.
13684 (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
13685 (coff_locate_sections): Update.
13686 (coff_symfile_read): Remove cleanups. Update.
13687 (init_stringtab): Add storage parameter.
13688 (free_stringtab, free_stringtab_cleanup): Remove.
13689 (init_lineno): Add storage parameter.
13690 (free_linetab, free_linetab_cleanup): Remove.
13691
13692 2019-03-06 Pedro Alves <palves@redhat.com>
13693
13694 * linux-fork.c (fork_info::clobber_regs): Delete.
13695 (fork_load_infrun_state): Remove reference to 'clobber_regs'.
13696 (fork_save_infrun_state): Remove 'clobber_regs' parameter. Update
13697 comment. Adjust.
13698 (scoped_switch_fork_info::scoped_switch_fork_info)
13699 (checkpoint_command, linux_fork_context): Adjust
13700 fork_save_infrun_state calls.
13701
13702 2019-03-06 Pedro Alves <palves@redhat.com>
13703
13704 * linux-fork.c (inf_has_multiple_thread_cb): Delete.
13705 (inf_has_multiple_threads): Return 'bool' and rewrite using
13706 inferior_info::threads().
13707
13708 2019-03-06 Pedro Alves <palves@redhat.com>
13709
13710 * linux-fork.c: Include <list>.
13711 (fork_list): Now a std::list instance.
13712 (fork_info): Add ctor, dtor, and in-class initialize all fields.
13713 (forks_exist_p, find_last_fork): Adjust.
13714 (new_fork): Delete.
13715 (one_fork_p): New.
13716 (add_fork): Adjust.
13717 (free_fork): Delete, folded into fork_info::~fork_info().
13718 (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
13719 Adjust.
13720 (init_fork_list): Delete.
13721 (linux_fork_killall, linux_fork_mourn_inferior)
13722 (linux_fork_detach, info_checkpoints_command): Adjust.
13723 (_initialize_linux_fork): No longer call init_fork_list.
13724
13725 2019-03-06 Pedro Alves <palves@redhat.com>
13726
13727 * linux-fork.c (new_fork): New, split out of ...
13728 (add_fork): ... this. Return void. Move "first fork" special
13729 case from here, to ...
13730 (checkpoint_command): ... here.
13731 * linux-linux.h (add_fork): Return void.
13732
13733 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13734
13735 * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
13736
13737 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13738 Chris January <chris.january@arm.com>
13739 David Lecomber <david.lecomber@arm.com>
13740
13741 * f-exp.y: New token, UNOP_INTRINSIC.
13742 (exp): New pattern using UNOP_INTRINSIC token.
13743 (f77_keywords): Add 'abs' keyword.
13744 * f-lang.c: Add 'target-float.h' and 'math.h' includes.
13745 (value_from_host_double): New function.
13746 (evaluate_subexp_f): Support UNOP_ABS.
13747
13748 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13749
13750 * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
13751 types.
13752
13753 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13754
13755 * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
13756 * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
13757 * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
13758
13759 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13760
13761 * f-exp.y (convert_to_kind_type): Handle more type kinds.
13762
13763 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13764 Chris January <chris.january@arm.com>
13765
13766 * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
13767 * f-exp.y: Define 'KIND' token.
13768 (exp): New pattern for KIND expressions.
13769 (ptype): Handle types with a kind extension.
13770 (direct_abs_decl): Extend to spot kind extensions.
13771 (f77_keywords): Add 'kind' to the list.
13772 (push_kind_type): New function.
13773 (convert_to_kind_type): New function.
13774 * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
13775 * parse.c (operator_length_standard): Likewise.
13776 * parser-defs.h (enum type_pieces): Add tp_kind.
13777 * std-operator.def: Add UNOP_KIND.
13778
13779 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13780
13781 * f-exp.y (f_parse): Set yydebug.
13782
13783 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13784
13785 * f-lang.c (evaluate_subexp_f): New function.
13786 (exp_descriptor_f): New global.
13787 (f_language_defn): Use exp_descriptor_f instead of
13788 exp_descriptor_standard.
13789
13790 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13791
13792 * f-exp.y (struct token): Add comments.
13793 (dot_ops): Remove uppercase versions and the end marker.
13794 (f77_keywords): Likewise.
13795 (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
13796 entries in the dot_ops array are case insensitive, and use
13797 strncasecmp to compare strings. Also some whitespace cleanup in
13798 this area. Similar for the f77_keywords array, except entries in
13799 this list might be case sensitive.
13800
13801 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13802
13803 * f-exp.y (struct f77_boolean_val): Add comments.
13804 (boolean_values): Remove uppercase versions, and end marker.
13805 (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
13806 and use strncasecmp to achieve case insensitivity. Additionally,
13807 perform whitespace cleanup around this code.
13808
13809 2019-03-06 Tom Tromey <tromey@adacore.com>
13810
13811 * remote-sim.c (gdbsim_target_open): Use result of
13812 gdb_argv::release.
13813
13814 2019-03-06 Richard Bunt <richard.bunt@arm.com>
13815 Dirk Schubert <dirk.schubert@arm.com>
13816 Chris January <chris.january@arm.com>
13817
13818 * eval.c (evaluate_subexp_standard): Call Fortran argument
13819 wrapping logic.
13820 * f-lang.c (struct value): A value which can be passed into a
13821 Fortran function call.
13822 (fortran_argument_convert): Wrap Fortran arguments in a pointer
13823 where appropriate.
13824 (struct type): Value ready for a Fortran function call.
13825 (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
13826 is needed.
13827 * f-lang.h (fortran_argument_convert): Declaration.
13828 (fortran_preserve_arg_pointer): Declaration.
13829 * infcall.c (value_arg_coerce): Call Fortran argument logic.
13830
13831 2019-03-05 Tom Tromey <tromey@adacore.com>
13832
13833 * python/py-prettyprint.c (print_string_repr): Remove #if.
13834 * python/py-utils.c (unicode_to_encoded_string): Remove #if.
13835
13836 2019-03-05 Tom Tromey <tromey@adacore.com>
13837
13838 * target.c (the_dummy_target): Move later. Change type to
13839 "dummy_target".
13840 (initialize_targets): Don't initialize the_dummy_target.
13841
13842 2019-03-05 Tom Tromey <tromey@adacore.com>
13843
13844 * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
13845 * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
13846
13847 2019-03-05 Tom Tromey <tromey@adacore.com>
13848
13849 * windows-nat.c (windows_nat_target::attach)
13850 (windows_nat_target::detach): Don't call gdb_flush.
13851 * valprint.c (generic_val_print, val_print, val_print_string):
13852 Don't call gdb_flush.
13853 * utils.c (defaulted_query): Don't call gdb_flush.
13854 * typeprint.c (print_type_scalar): Don't call gdb_flush.
13855 * target.c (target_announce_detach): Don't call gdb_flush.
13856 * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
13857 * remote.c (extended_remote_target::attach): Don't call
13858 gdb_flush.
13859 * procfs.c (procfs_target::detach): Don't call gdb_flush.
13860 * printcmd.c (do_examine): Don't call gdb_flush.
13861 (info_display_command): Don't call gdb_flush.
13862 * p-valprint.c (pascal_val_print): Don't call gdb_flush.
13863 * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
13864 * memattr.c (info_mem_command): Don't call gdb_flush.
13865 * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
13866 * m2-valprint.c (m2_val_print): Don't call gdb_flush.
13867 * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
13868 * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
13869 * hppa-tdep.c (unwind_command): Don't call gdb_flush.
13870 * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
13871 (gnu_nat_target::detach): Don't call gdb_flush.
13872 * f-valprint.c (f_val_print): Don't call gdb_flush.
13873 * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
13874 * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
13875 * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
13876 gdb_flush.
13877 * c-valprint.c (c_val_print): Don't call gdb_flush.
13878 * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
13879
13880 2019-03-05 Tom Tromey <tromey@adacore.com>
13881
13882 * varobj.c (update_dynamic_varobj_children): Update.
13883 (install_default_visualizer): Use reset, not release.
13884 * value.c (set_internalvar): Update.
13885 * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
13886 * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
13887 ATTRIBUTE_UNUSED_RESULT.
13888
13889 2019-03-05 Tom Tromey <tromey@adacore.com>
13890
13891 * remote.c (class scoped_remote_fd) <release>: Add
13892 ATTRIBUTE_UNUSED_RESULT.
13893
13894 2019-03-05 Tom Tromey <tromey@adacore.com>
13895
13896 * macroexp.c (struct macro_buffer) <release>: Add
13897 ATTRIBUTE_UNUSED_RESULT.
13898
13899 2019-03-05 Tom Tromey <tromey@adacore.com>
13900
13901 * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
13902 * common/scoped_mmap.h (class scoped_mmap) <release>: Add
13903 ATTRIBUTE_UNUSED_RESULT.
13904
13905 2019-03-05 Tom Tromey <tromey@adacore.com>
13906
13907 * common/scoped_fd.h (class scoped_fd) <release>: Add
13908 ATTRIBUTE_UNUSED_RESULT.
13909
13910 2019-03-05 Tom Tromey <tromey@adacore.com>
13911
13912 * parser-defs.h (struct parser_state) <release>: Add
13913 ATTRIBUTE_UNUSED_RESULT.
13914
13915 2019-03-05 Tom Tromey <tromey@adacore.com>
13916
13917 * utils.h (class gdb_argv) <release>: Add
13918 ATTRIBUTE_UNUSED_RESULT.
13919 * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
13920
13921 2019-03-02 Eli Zaretskii <eliz@gnu.org>
13922
13923 * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
13924 for-loop range, to avoid compiler warnings.
13925
13926 * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
13927 avoid compiler warnings about unused variables.
13928
13929 * NEWS: Mention end of support for native debugging on MS-Windows
13930 before XP.
13931
13932 PR gdb/24292
13933 * common/netstuff.c:
13934 * gdbserver/gdbreplay.c
13935 * gdbserver/remote-utils.c:
13936 * ser-tcp.c:
13937 * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
13938 Include ws2tcpip.h instead of wsiapi.h and winsock2.h. Redefine
13939 _WIN32_WINNT to 0x0501 if defined to a smaller value, as
13940 'getaddrinfo' and 'freeaddrinfo' were not available before
13941 Windows XP, and mingw.org's MinGW headers by default define
13942 _WIN32_WINNT to 0x500.
13943
13944 2019-03-01 Gary Benson <gbenson@redhat.com>
13945
13946 * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
13947
13948 2019-02-28 Brian Vandenberg <phantall@gmail.com>
13949 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
13950
13951 PR gdb/8527
13952 * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
13953 set_sigint_trap, clear_sigint_trap.
13954
13955 2019-02-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
13956
13957 * target.c (target_detach): Clear the regcache and the
13958 frame cache.
13959
13960 2019-02-27 Pedro Alves <palves@redhat.com>
13961
13962 * utils.c (set_screen_size): When we cap the height/width sizes,
13963 tweak the corresponding command variable to show "unlimited":
13964
13965 2019-02-27 Saagar Jha <saagar@saagarjha.com>
13966 Pedro Alves <palves@redhat.com>
13967
13968 * utils.c (set_screen_size): Reduce "infinite" rows and columns
13969 before calling rl_set_screen_size.
13970
13971 2019-02-27 Tom Tromey <tromey@adacore.com>
13972
13973 * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
13974 define.
13975 * python/py-value.c: Remove Python 2.4 workaround.
13976 * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
13977 workaround.
13978 * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
13979 Python 2.4 workaround.
13980 * python/python-internal.h: Remove Python 2.4 comment.
13981 (Py_ssize_t): Don't define.
13982 (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
13983 (gdb_Py_DECREF): Remove Python 2.4 workaround.
13984 (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
13985 (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
13986 * python/python.c (do_start_initialization): Remove Python 2.4
13987 workaround.
13988 * python/py-prettyprint.c (class dummy_python_frame): Remove.
13989 (print_children): Remove Python 2.4 workaround.
13990 * python/py-inferior.c (buffer_procs): Remove Python 2.4
13991 workaround.
13992 (CHARBUFFERPROC_NAME): Remove.
13993 * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
13994 Python 2.4 workaround.
13995
13996 2019-02-27 Kevin Buettner <kevinb@redhat.com>
13997
13998 * NEWS: Note minimum Python version.
13999
14000 2019-02-27 Kevin Buettner <kevinb@redhat.com>
14001
14002 * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
14003 code from these functions. Remove corresponding ifdefs. Use
14004 Py_buffer_up instead of explicit calls to PyBuffer_Release.
14005 Remove gotos and target of gotos.
14006 (infpy_search_memory): Likewise.
14007
14008 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14009
14010 * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
14011 (hppa_gdbarch_init): Don't register deleted functions with
14012 gdbarch.
14013
14014 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14015
14016 * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
14017 (h8300_unwind_sp): Delete.
14018 (h8300_dummy_id): Delete.
14019 (h8300_gdbarch_init): Don't register deleted functions with
14020 gdbarch.
14021
14022 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14023
14024 * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
14025 (ft32_unwind_pc): Delete.
14026 (ft32_unwind_sp): Delete.
14027 (ft32_gdbarch_init): Don't register deleted functions with
14028 gdbarch.
14029
14030 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14031
14032 * gdb/frv-tdep.c (frv_dummy_id): Delete.
14033 (frv_unwind_pc): Delete.
14034 (frv_unwind_sp): Delete.
14035 (frv_gdbarch_init): Don't register deleted functions with
14036 gdbarch.
14037
14038 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14039
14040 * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
14041 (riscv_unwind_pc): Delete.
14042 (riscv_unwind_sp): Delete.
14043 (riscv_gdbarch_init): Don't register deleted functions with
14044 gdbarch.
14045
14046 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14047
14048 * gdb/csky-tdep.c (csky_dummy_id): Delete.
14049 (csky_unwind_pc): Delete.
14050 (csky_unwind_sp): Delete.
14051 (csky_gdbarch_init): Don't register deleted functions with
14052 gdbarch.
14053
14054 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14055
14056 * gdb/cris-tdep.c (cris_dummy_id): Delete.
14057 (cris_unwind_pc): Delete.
14058 (cris_unwind_sp): Delete.
14059 (cris_gdbarch_init): Don't register deleted functions with
14060 gdbarch.
14061
14062 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14063
14064 * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
14065 (bfin_unwind_pc): Delete.
14066 (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
14067
14068 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14069
14070 * gdb/arm-tdep.c (arm_dummy_id): Delete.
14071 (arm_unwind_pc): Delete.
14072 (arm_unwind_sp): Delete.
14073 (arm_gdbarch_init): Don't register deleted functions with gdbarch.
14074
14075 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14076
14077 * gdb/arc-tdep.c (arc_dummy_id): Delete.
14078 (arc_unwind_pc): Delete.
14079 (arc_unwind_sp): Delete.
14080 (arc_gdbarch_init): Don't register deleted functions with gdbarch.
14081
14082 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14083
14084 * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
14085 (alpha_unwind_pc): Delete.
14086 (alpha_gdbarch_init): Don't register deleted functions with
14087 gdbarch.
14088
14089 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14090
14091 * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
14092 (aarch64_unwind_pc): Delete.
14093 (aarch64_unwind_sp): Delete.
14094 (aarch64_gdbarch_init): Don't register deleted functions with
14095 gdbarch.
14096
14097 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14098
14099 * gdbtypes.c (type_align): Don't consider static members when
14100 computing structure alignment.
14101
14102 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14103
14104 * arc-tdep.c (arc_type_align): Provide alignment for basic types,
14105 return 0 for other types.
14106 * arch-utils.c (default_type_align): Always return 0.
14107 * gdbarch.h: Regenerate.
14108 * gdbarch.sh (type_align): Extend comment.
14109 * gdbtypes.c (type_align): Add additional comments, always call
14110 gdbarch_type_align before applying the default rules.
14111 * i386-tdep.c (i386_type_align): Return 0 as the default rule,
14112 generic code will then apply a suitable default.
14113 * nios2-tdep.c (nios2_type_align): Provide alignment for basic
14114 types, return 0 for other types.
14115
14116 2019-02-27 Joel Brobecker <brobecker@adacore.com>
14117
14118 * NEWS: Create a new section for the next release branch.
14119 Rename the section of the current branch, now that it has
14120 been cut.
14121
14122 2019-02-27 Joel Brobecker <brobecker@adacore.com>
14123
14124 GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
14125 * version.in: Bump version to 8.3.50.DATE-git.
14126
14127 2019-02-26 Simon Marchi <simon.marchi@efficios.com>
14128
14129 * aix-thread.c (ptid_cmp): Remove unused variable.
14130 (get_signaled_thread): Likewise.
14131 (store_regs_user_thread): Likewise.
14132 (store_regs_kernel_thread): Likewise.
14133 (fetch_regs_kernel_thread): Remove shadowed variable.
14134
14135 2019-02-26 Andrew Burgess <andrew.burgess@embecosm.com>
14136
14137 * features/riscv/32bit-cpu.xml: Add register numbers.
14138 * features/riscv/32bit-fpu.c: Regenerate.
14139 * features/riscv/32bit-fpu.xml: Add register numbers.
14140 * features/riscv/64bit-cpu.xml: Add register numbers.
14141 * features/riscv/64bit-fpu.c: Regenerate.
14142 * features/riscv/64bit-fpu.xml: Add register numbers.
14143
14144 2019-02-26 Kevin Buettner <kevinb@redhat.com>
14145
14146 * NEWS: Mention two argument form of gdb.Value constructor.
14147 * python/py-value.c (convert_buffer_and_type_to_value): New
14148 function.
14149 (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
14150 Add support for handling an optional second argument. Call
14151 convert_buffer_and_type_to_value as appropriate.
14152 * python/python-internal.h (Py_buffer_deleter): New struct.
14153 (Py_buffer_up): New typedef.
14154
14155 2019-02-25 John Baldwin <jhb@FreeBSD.org>
14156
14157 * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
14158 instead of releasing ownership.
14159
14160 2019-02-25 Jordan Rupprecht <rupprecht@google.com>
14161
14162 * dwarf2read.c (open_and_init_dwp_file): Call
14163 elf_numsections instead of bfd_count_sections to initialize
14164 dwp_file->num_sections.
14165
14166 2019-02-25 Tom Tromey <tromey@adacore.com>
14167
14168 * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
14169
14170 2019-02-23 Sergio Durigan Junior <sergiodj@redhat.com>
14171
14172 * gcore.in: Add '--readnever' option when invoking GDB.
14173
14174 2019-02-22 Simon Marchi <simon.marchi@polymtl.ca>
14175
14176 * MAINTAINERS: Update my email address.
14177
14178 2019-02-22 Simon Marchi <simon.marchi@polymtl.ca>
14179
14180 * build-id.c (build_id_to_debug_bfd_1): New function.
14181 (build_id_to_debug_bfd): Look for separate debug file in
14182 sysroot.
14183
14184 2019-02-22 Andrew Burgess <andrew.burgess@embecosm.com>
14185
14186 * gdbarch.sh: Update the copyright year range that is placed into
14187 generated files.
14188
14189 2019-02-22 Keith Seitz <keiths@redhat.com>
14190
14191 PR symtab/23853
14192 * linespec.c (create_sals_line_offset): Search for the default
14193 symtab's filename instead of its fullname.
14194
14195 2019-02-21 Alan Hayward <alan.hayward@arm.com>
14196
14197 * NEWS: Update style defaults.
14198
14199 2019-02-21 Alan Hayward <alan.hayward@arm.com>
14200
14201 * main.c (captured_main_1): Disable styling in batch mode.
14202
14203 2019-02-20 Tom Tromey <tom@tromey.com>
14204
14205 * symtab.c (symtab_symbol_info): Fix typos.
14206
14207 2019-02-20 Tom Tromey <tromey@adacore.com>
14208
14209 * findcmd.c (_initialize_mem_search): Use upper case for
14210 metasyntactic variables.
14211
14212 2019-02-20 Alan Hayward <alan.hayward@arm.com>
14213
14214 * aarch64-tdep.c (aarch64_add_reggroups): New function.
14215 (aarch64_gdbarch_init): Call aarch64_add_reggroups.
14216
14217 2019-02-19 Simon Marchi <simon.marchi@polymtl.ca>
14218
14219 * top.h (source_file_name): Change to std::string.
14220 * top.c (source_file_name): Likewise.
14221 (command_line_input): Adjust.
14222 * cli/cli-script.c (script_from_file): Adjust.
14223
14224 2019-02-19 Tom Tromey <tromey@adacore.com>
14225
14226 * ravenscar-thread.c
14227 (ravenscar_thread_target::update_thread_list): Don't call
14228 ada_build_task_list.
14229 * ada-lang.h (ada_build_task_list): Don't declare.
14230 * ada-tasks.c (struct ada_tasks_inferior_data)
14231 <task_list_valid_p>: Now bool.
14232 (read_known_tasks, ada_task_list_changed)
14233 (ada_tasks_invalidate_inferior_data): Update.
14234 (read_known_tasks_array): Return bool.
14235 (read_known_tasks_list): Likewise.
14236 (read_known_tasks): Return void.
14237 (ada_build_task_list): Now static.
14238
14239 2019-02-18 Andrew Burgess <andrew.burgess@embecosm.com>
14240
14241 * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
14242 and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
14243
14244 2019-02-18 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14245
14246 * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
14247 variant for ada_tasks_pspace_data_handle and
14248 ada_tasks_inferior_data_handle.
14249 (ada_tasks_pspace_data_cleanup): New function.
14250 (ada_tasks_inferior_data_cleanup): New function.
14251
14252 2019-02-17 Tom Tromey <tom@tromey.com>
14253
14254 * macrotab.h (macro_source_fullname): Return a std::string.
14255 * macrotab.c (macro_include, check_for_redefinition)
14256 (macro_undef, macro_lookup_definition, foreach_macro)
14257 (foreach_macro_in_scope): Update.
14258 (macro_source_fullname): Return a std::string.
14259 * macrocmd.c (show_pp_source_pos): Update.
14260
14261 2019-02-17 Tom Tromey <tom@tromey.com>
14262
14263 * macrocmd.c (show_pp_source_pos): Style the file names.
14264
14265 2019-02-17 Tom Tromey <tom@tromey.com>
14266
14267 PR tui/24197:
14268 * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
14269
14270 2019-02-17 Tom Tromey <tom@tromey.com>
14271
14272 * ada-lang.c (user_select_syms): Use filtered printing.
14273 * utils.c (wrap_style): New global.
14274 (desired_style): Remove.
14275 (emit_style_escape): Add stream parameter.
14276 (set_output_style, reset_terminal_style, prompt_for_continue):
14277 Update.
14278 (flush_wrap_buffer): Only flush gdb_stdout.
14279 (wrap_here): Set wrap_style.
14280 (fputs_maybe_filtered): Clear the wrap buffer on exception. Don't
14281 treat escape sequences as a character. Change when wrap buffer is
14282 flushed.
14283 (fputs_styled): Do not set the output style when the default is
14284 requested.
14285 * ui-style.h (struct ui_file_style) <is_default>: New method.
14286 * source.c (print_source_lines_base): Emit escape sequences in one
14287 piece.
14288
14289 2019-02-17 Joel Brobecker <brobecker@adacore.com>
14290
14291 * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
14292 integers and enumeration types.
14293
14294 2019-02-17 Joel Brobecker <brobecker@adacore.com>
14295
14296 * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
14297 instead of lookup_symbol_in_language
14298 (do_exact_match): New function.
14299 (ada_get_symbol_name_matcher): Return do_exact_match when
14300 doing a verbatim match.
14301
14302 2019-02-15 Tom Tromey <tromey@adacore.com>
14303
14304 * ravenscar-thread.c (ravenscar_thread_target::resume)
14305 (ravenscar_thread_target::wait): Special case wildcard requests.
14306
14307 2019-02-15 Tom Tromey <tromey@adacore.com>
14308
14309 * ravenscar-thread.c (base_ptid): Remove.
14310 (struct ravenscar_thread_target) <close>: New method.
14311 <m_base_ptid>: New member.
14312 <update_inferior_ptid, active_task, task_is_currently_active,
14313 runtime_initialized>: Declare methods.
14314 <ravenscar_thread_target>: Add constructor.
14315 (ravenscar_thread_target::task_is_currently_active)
14316 (ravenscar_thread_target::update_inferior_ptid)
14317 (ravenscar_runtime_initialized): Rename. Now methods.
14318 (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
14319 (ravenscar_thread_target::update_thread_list): Update.
14320 (ravenscar_thread_target::active_task): Now method.
14321 (ravenscar_thread_target::store_registers)
14322 (ravenscar_thread_target::prepare_to_store)
14323 (ravenscar_thread_target::prepare_to_store)
14324 (ravenscar_thread_target::mourn_inferior): Update.
14325 (ravenscar_inferior_created): Use "new" to create target.
14326 (ravenscar_thread_target::get_ada_task_ptid): Update.
14327 (_initialize_ravenscar): Don't initialize base_ptid.
14328 (ravenscar_ops): Remove global.
14329
14330 2019-02-15 Tom Tromey <tromey@adacore.com>
14331
14332 * target.h (push_target): Declare new overload.
14333 * target.c (push_target): New overload, taking an rvalue reference.
14334 * remote.c (remote_target::open_1): Use push_target overload.
14335 * corelow.c (core_target_open): Use push_target overload.
14336
14337 2019-02-15 Tom Tromey <tromey@adacore.com>
14338
14339 * ravenscar-thread.c (is_ravenscar_task)
14340 (ravenscar_task_is_currently_active): Return bool.
14341 (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
14342 (_initialize_ravenscar): Remove "(void)".
14343 (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
14344 Return bool.
14345
14346 2019-02-15 Tom Tromey <tromey@adacore.com>
14347
14348 * ravenscar-thread.c (ravenscar_runtime_initializer)
14349 (has_ravenscar_runtime, get_running_thread_id)
14350 (ravenscar_thread_target::resume): Fix indentation.
14351
14352 2019-02-15 Tom Tromey <tromey@adacore.com>
14353
14354 * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
14355 from ravenscar_arch_ops.
14356 (sparc_ravenscar_ops::fetch_registers)
14357 (sparc_ravenscar_ops::store_registers): Now methods.
14358 (sparc_ravenscar_prepare_to_store): Remove.
14359 (sparc_ravenscar_ops): Redefine.
14360 * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
14361 methods and destructor. Remove members.
14362 * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
14363 (ravenscar_thread_target::store_registers)
14364 (ravenscar_thread_target::prepare_to_store): Update.
14365 * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
14366 Remove.
14367 (struct ppc_ravenscar_powerpc_ops): Derive from
14368 ravenscar_arch_ops.
14369 (ppc_ravenscar_powerpc_ops::fetch_registers)
14370 (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
14371 (ppc_ravenscar_powerpc_ops): Redefine.
14372 (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
14373 (ppc_ravenscar_e500_ops::fetch_registers)
14374 (ppc_ravenscar_e500_ops::store_registers): Now methods.
14375 (ppc_ravenscar_e500_ops): Redefine.
14376 * aarch64-ravenscar-thread.c
14377 (aarch64_ravenscar_generic_prepare_to_store): Remove.
14378 (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
14379 (aarch64_ravenscar_fetch_registers)
14380 (aarch64_ravenscar_store_registers): Now methods.
14381 (aarch64_ravenscar_ops): Redefine.
14382
14383 2019-02-15 Tom Tromey <tromey@adacore.com>
14384
14385 * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
14386 (ravenscar_thread_target::stopped_by_hw_breakpoint)
14387 (ravenscar_thread_target::stopped_by_watchpoint)
14388 (ravenscar_thread_target::stopped_data_address)
14389 (ravenscar_thread_target::core_of_thread): Use scoped_restore.
14390
14391 2019-02-15 Tom Tromey <tromey@adacore.com>
14392
14393 * ravenscar-thread.c: Fix some typos.
14394
14395 2019-02-15 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14396 Tom Tromey <tromey@adacore.com>
14397
14398 * ada-lang.c (ada_exception_sal): Change addr_string to a
14399 std::string.
14400 (create_ada_exception_catchpoint): Update.
14401
14402 2019-02-15 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14403 Tom Tromey <tromey@adacore.com>
14404
14405 * breakpoint.c (~bp_location): Rename from bp_location_dtor.
14406 (bp_location_ops): Remove.
14407 (base_breakpoint_allocate_location): Update.
14408 (free_bp_location): Update.
14409 * ada-lang.c (class ada_catchpoint_location)
14410 <ada_catchpoint_location>: Remove ops parameter.
14411 (ada_catchpoint_location_dtor): Remove.
14412 (ada_catchpoint_location_ops): Remove.
14413 (allocate_location_exception): Update.
14414 * breakpoint.h (struct bp_location_ops): Remove.
14415 (class bp_location) <bp_location>: Remove bp_location_ops
14416 parameter.
14417 <~bp_location>: Add destructor.
14418 <ops>: Remove.
14419
14420 2019-02-14 Thomas Schwinge <thomas@codesourcery.com>
14421 Pedro Alves <palves@redhat.com>
14422
14423 * remote.c (remote_target::remote_parse_stop_reply): Avoid using
14424 'PATH_MAX'.
14425
14426 2019-02-14 David Michael <fedora.dm0@gmail.com>
14427 Samuel Thibault <samuel.thibault@gnu.org>
14428 Thomas Schwinge <thomas@codesourcery.com>
14429
14430 * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
14431 (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
14432
14433 2019-02-14 Thomas Schwinge <thomas@codesourcery.com>
14434
14435 * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
14436 (check_empty): Use "const char *".
14437
14438 * gnu-nat.c (gnu_nat_target::detach): Instead of
14439 'detach_inferior (pid)' call
14440 'detach_inferior (find_inferior_pid (pid))'.
14441
14442 * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
14443 'nat/fork-inferior.o'.
14444 * gnu-nat.c: #include "nat/fork-inferior.h".
14445
14446 * gnu-nat.c (gnu_nat_target::detach): Instead of
14447 'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
14448 * gnu-nat.h: #include "inf-child.h".
14449 * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
14450 'i386_gnu_nat_target::fetch_registers'.
14451 (gnu_store_registers): Rename/move to
14452 'i386_gnu_nat_target::store_registers'.
14453
14454 * config/i386/nm-i386gnu.h: Don't "#include" any files.
14455 * gnu-nat.h (mach_thread_info): New function.
14456 * gnu-nat.c (thread_takeover_sc_cmd): Use it.
14457
14458 * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
14459
14460 2019-02-14 Frederic Konrad <konrad@adacore.com>
14461
14462 * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
14463
14464 2019-02-14 Joel Brobecker <brobecker@adacore.com>
14465
14466 * windows-nat.c (windows_add_thread): Add new parameter
14467 "main_thread_p" with default value set to false. Update
14468 function documentation as well as all callers.
14469 (windows_delete_thread): Likewise.
14470 (fake_create_process): Update call to windows_add_thread.
14471 (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
14472 <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
14473 <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
14474 call to windows_delete_thread.
14475
14476 2019-02-13 Simon Marchi <simon.marchi@ericsson.com>
14477
14478 * MAINTAINERS: Add Andrew Burgess as global maintainer.
14479
14480 2019-02-12 John Baldwin <jhb@FreeBSD.org>
14481
14482 * symfile.c (find_separate_debug_file): Use canonical path of
14483 sysroot with child_path instead of gdb_sysroot if it is valid.
14484
14485 2019-02-12 John Baldwin <jhb@FreeBSD.org>
14486
14487 * symfile.c (find_separate_debug_file): Use child_path to
14488 determine if an object file is under a sysroot.
14489
14490 2019-02-12 John Baldwin <jhb@FreeBSD.org>
14491
14492 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
14493 unittests/child-path-selftests.c.
14494 * common/pathstuff.c (child_path): New function.
14495 * common/pathstuff.h (child_path): New prototype.
14496 * unittests/child-path-selftests.c: New file.
14497
14498 2019-02-12 John Baldwin <jhb@FreeBSD.org>
14499
14500 * symfile.c (find_separate_debug_file): Look for separate debug
14501 files in debug directories under the sysroot.
14502
14503 2019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14504
14505 * symtab.h (struct minimal_symbol data_p): New const method.
14506 (struct minimal_symbol text_p): Likewise.
14507 * symtab.c (output_source_filename): Use file name style
14508 to print file name.
14509 (print_symbol_info): Likewise.
14510 (print_msymbol_info): Use address style to print addresses.
14511 Use function name style to print executable text symbols.
14512 (expand_symtab_containing_pc): Use data_p.
14513 (find_pc_sect_compunit_symtab): Likewise.
14514
14515 2019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14516
14517 * breakpoint.c (describe_other_breakpoints): Use address style
14518 to print addresses.
14519 (say_where): Likewise.
14520
14521 2019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14522
14523 * ada-typeprint.c (print_func_type): Print function name
14524 style to print function name.
14525 * c-typeprint.c (c_print_type_1): Likewise.
14526
14527 2019-02-11 Alan Hayward <alan.hayward@arm.com>
14528
14529 * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
14530 for execve.
14531
14532 2019-02-10 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14533
14534 * c-exp.y (direct_abs_decl): Use emplace_back to record the
14535 type_stack.
14536
14537 2019-02-10 Joel Brobecker <brobecker@adacore.com>
14538
14539 * ada-varobj.c (ada_value_is_changeable_p): Add handling of
14540 TYPE_CODE_REF types.
14541
14542 2019-02-08 Jim Wilson <jimw@sifive.com>
14543
14544 * riscv-linux-tdep.c (riscv_linux_fregmap): New.
14545 (riscv_linux_fregset): New.
14546 (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
14547
14548 2019-02-07 Tom Tromey <tom@tromey.com>
14549
14550 * thread.c (thread_cancel_execution_command): Update.
14551 * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
14552 methods.
14553 (struct thread_fsm_ops): Remove.
14554 (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
14555 (thread_fsm_should_stop, thread_fsm_return_value)
14556 (thread_fsm_set_finished, thread_fsm_finished_p)
14557 (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
14558 Don't declare.
14559 * mi/mi-interp.c (mi_on_normal_stop_1): Update.
14560 * infrun.c (clear_proceed_status_thread)
14561 (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
14562 (print_stop_event): Update.
14563 * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
14564 Add constructor.
14565 (step_command_fsm_ops): Remove.
14566 (new_step_command_fsm): Remove.
14567 (step_1): Update.
14568 (step_command_fsm::should_stop): Rename from
14569 step_command_fsm_should_stop.
14570 (step_command_fsm::clean_up): Rename from
14571 step_command_fsm_clean_up.
14572 (step_command_fsm::do_async_reply_reason): Rename from
14573 step_command_fsm_async_reply_reason.
14574 (struct until_next_fsm): Inherit from thread_fsm. Add
14575 constructor.
14576 (until_next_fsm_ops): Remove.
14577 (new_until_next_fsm): Remove.
14578 (until_next_fsm::should_stop): Rename from
14579 until_next_fsm_should_stop.
14580 (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
14581 (until_next_fsm::do_async_reply_reason): Rename from
14582 until_next_fsm_async_reply_reason.
14583 (struct finish_command_fsm): Inherit from thread_fsm. Add
14584 constructor. Change type of breakpoint.
14585 (finish_command_fsm_ops): Remove.
14586 (new_finish_command_fsm): Remove.
14587 (finish_command_fsm::should_stop): Rename from
14588 finish_command_fsm_should_stop.
14589 (finish_command_fsm::clean_up): Rename from
14590 finish_command_fsm_clean_up.
14591 (finish_command_fsm::return_value): Rename from
14592 finish_command_fsm_return_value.
14593 (finish_command_fsm::do_async_reply_reason): Rename from
14594 finish_command_fsm_async_reply_reason.
14595 (finish_command): Update.
14596 * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
14597 Add constructor.
14598 (call_thread_fsm_ops): Remove.
14599 (call_thread_fsm::call_thread_fsm): Rename from
14600 new_call_thread_fsm.
14601 (call_thread_fsm::should_stop): Rename from
14602 call_thread_fsm_should_stop.
14603 (call_thread_fsm::should_notify_stop): Rename from
14604 call_thread_fsm_should_notify_stop.
14605 (run_inferior_call, call_function_by_hand_dummy): Update.
14606 * cli/cli-interp.c (should_print_stop_to_console): Update.
14607 * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
14608 Add constructor. Change type of location_breakpoint,
14609 caller_breakpoint.
14610 (until_break_fsm_ops): Remove.
14611 (new_until_break_fsm): Remove.
14612 (until_break_fsm::should_stop): Rename from
14613 until_break_fsm_should_stop.
14614 (until_break_fsm::clean_up): Rename from
14615 until_break_fsm_clean_up.
14616 (until_break_fsm::do_async_reply_reason): Rename from
14617 until_break_fsm_async_reply_reason.
14618 (until_break_command): Update.
14619 * thread-fsm.c: Remove.
14620 * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
14621
14622 2019-02-07 Tom Tromey <tom@tromey.com>
14623
14624 * yy-remap.h: Add include guard.
14625 * xtensa-tdep.h: Add include guard.
14626 * xcoffread.h: Rename include guard.
14627 * varobj-iter.h: Add include guard.
14628 * tui/tui.h: Rename include guard.
14629 * tui/tui-winsource.h: Rename include guard.
14630 * tui/tui-wingeneral.h: Rename include guard.
14631 * tui/tui-windata.h: Rename include guard.
14632 * tui/tui-win.h: Rename include guard.
14633 * tui/tui-stack.h: Rename include guard.
14634 * tui/tui-source.h: Rename include guard.
14635 * tui/tui-regs.h: Rename include guard.
14636 * tui/tui-out.h: Rename include guard.
14637 * tui/tui-layout.h: Rename include guard.
14638 * tui/tui-io.h: Rename include guard.
14639 * tui/tui-hooks.h: Rename include guard.
14640 * tui/tui-file.h: Rename include guard.
14641 * tui/tui-disasm.h: Rename include guard.
14642 * tui/tui-data.h: Rename include guard.
14643 * tui/tui-command.h: Rename include guard.
14644 * tic6x-tdep.h: Add include guard.
14645 * target/waitstatus.h: Rename include guard.
14646 * target/wait.h: Rename include guard.
14647 * target/target.h: Rename include guard.
14648 * target/resume.h: Rename include guard.
14649 * target-float.h: Rename include guard.
14650 * stabsread.h: Add include guard.
14651 * rs6000-tdep.h: Add include guard.
14652 * riscv-fbsd-tdep.h: Add include guard.
14653 * regformats/regdef.h: Rename include guard.
14654 * record.h: Rename include guard.
14655 * python/python.h: Rename include guard.
14656 * python/python-internal.h: Rename include guard.
14657 * python/py-stopevent.h: Rename include guard.
14658 * python/py-ref.h: Rename include guard.
14659 * python/py-record.h: Rename include guard.
14660 * python/py-record-full.h: Rename include guard.
14661 * python/py-record-btrace.h: Rename include guard.
14662 * python/py-instruction.h: Rename include guard.
14663 * python/py-events.h: Rename include guard.
14664 * python/py-event.h: Rename include guard.
14665 * procfs.h: Add include guard.
14666 * proc-utils.h: Add include guard.
14667 * p-lang.h: Add include guard.
14668 * or1k-tdep.h: Rename include guard.
14669 * observable.h: Rename include guard.
14670 * nto-tdep.h: Rename include guard.
14671 * nat/x86-linux.h: Rename include guard.
14672 * nat/x86-linux-dregs.h: Rename include guard.
14673 * nat/x86-gcc-cpuid.h: Add include guard.
14674 * nat/x86-dregs.h: Rename include guard.
14675 * nat/x86-cpuid.h: Rename include guard.
14676 * nat/ppc-linux.h: Rename include guard.
14677 * nat/mips-linux-watch.h: Rename include guard.
14678 * nat/linux-waitpid.h: Rename include guard.
14679 * nat/linux-ptrace.h: Rename include guard.
14680 * nat/linux-procfs.h: Rename include guard.
14681 * nat/linux-osdata.h: Rename include guard.
14682 * nat/linux-nat.h: Rename include guard.
14683 * nat/linux-namespaces.h: Rename include guard.
14684 * nat/linux-btrace.h: Rename include guard.
14685 * nat/glibc_thread_db.h: Rename include guard.
14686 * nat/gdb_thread_db.h: Rename include guard.
14687 * nat/gdb_ptrace.h: Rename include guard.
14688 * nat/fork-inferior.h: Rename include guard.
14689 * nat/amd64-linux-siginfo.h: Rename include guard.
14690 * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
14691 * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
14692 * nat/aarch64-linux.h: Rename include guard.
14693 * nat/aarch64-linux-hw-point.h: Rename include guard.
14694 * mn10300-tdep.h: Add include guard.
14695 * mips-linux-tdep.h: Add include guard.
14696 * mi/mi-parse.h: Rename include guard.
14697 * mi/mi-out.h: Rename include guard.
14698 * mi/mi-main.h: Rename include guard.
14699 * mi/mi-interp.h: Rename include guard.
14700 * mi/mi-getopt.h: Rename include guard.
14701 * mi/mi-console.h: Rename include guard.
14702 * mi/mi-common.h: Rename include guard.
14703 * mi/mi-cmds.h: Rename include guard.
14704 * mi/mi-cmd-break.h: Rename include guard.
14705 * m2-lang.h: Add include guard.
14706 * location.h: Rename include guard.
14707 * linux-record.h: Rename include guard.
14708 * linux-nat.h: Add include guard.
14709 * linux-fork.h: Add include guard.
14710 * i386-darwin-tdep.h: Rename include guard.
14711 * hppa-linux-offsets.h: Add include guard.
14712 * guile/guile.h: Rename include guard.
14713 * guile/guile-internal.h: Rename include guard.
14714 * gnu-nat.h: Rename include guard.
14715 * gdb-stabs.h: Rename include guard.
14716 * frv-tdep.h: Add include guard.
14717 * f-lang.h: Add include guard.
14718 * event-loop.h: Add include guard.
14719 * darwin-nat.h: Rename include guard.
14720 * cp-abi.h: Rename include guard.
14721 * config/sparc/nm-sol2.h: Rename include guard.
14722 * config/nm-nto.h: Rename include guard.
14723 * config/nm-linux.h: Add include guard.
14724 * config/i386/nm-i386gnu.h: Rename include guard.
14725 * config/djgpp/nl_types.h: Rename include guard.
14726 * config/djgpp/langinfo.h: Rename include guard.
14727 * compile/gcc-cp-plugin.h: Add include guard.
14728 * compile/gcc-c-plugin.h: Add include guard.
14729 * compile/compile.h: Rename include guard.
14730 * compile/compile-object-run.h: Rename include guard.
14731 * compile/compile-object-load.h: Rename include guard.
14732 * compile/compile-internal.h: Rename include guard.
14733 * compile/compile-cplus.h: Rename include guard.
14734 * compile/compile-c.h: Rename include guard.
14735 * common/xml-utils.h: Rename include guard.
14736 * common/x86-xstate.h: Rename include guard.
14737 * common/version.h: Rename include guard.
14738 * common/vec.h: Rename include guard.
14739 * common/tdesc.h: Rename include guard.
14740 * common/selftest.h: Rename include guard.
14741 * common/scoped_restore.h: Rename include guard.
14742 * common/scoped_mmap.h: Rename include guard.
14743 * common/scoped_fd.h: Rename include guard.
14744 * common/safe-iterator.h: Rename include guard.
14745 * common/run-time-clock.h: Rename include guard.
14746 * common/refcounted-object.h: Rename include guard.
14747 * common/queue.h: Rename include guard.
14748 * common/ptid.h: Rename include guard.
14749 * common/print-utils.h: Rename include guard.
14750 * common/preprocessor.h: Rename include guard.
14751 * common/pathstuff.h: Rename include guard.
14752 * common/observable.h: Rename include guard.
14753 * common/netstuff.h: Rename include guard.
14754 * common/job-control.h: Rename include guard.
14755 * common/host-defs.h: Rename include guard.
14756 * common/gdb_wait.h: Rename include guard.
14757 * common/gdb_vecs.h: Rename include guard.
14758 * common/gdb_unlinker.h: Rename include guard.
14759 * common/gdb_unique_ptr.h: Rename include guard.
14760 * common/gdb_tilde_expand.h: Rename include guard.
14761 * common/gdb_sys_time.h: Rename include guard.
14762 * common/gdb_string_view.h: Rename include guard.
14763 * common/gdb_splay_tree.h: Rename include guard.
14764 * common/gdb_setjmp.h: Rename include guard.
14765 * common/gdb_ref_ptr.h: Rename include guard.
14766 * common/gdb_optional.h: Rename include guard.
14767 * common/gdb_locale.h: Rename include guard.
14768 * common/gdb_assert.h: Rename include guard.
14769 * common/filtered-iterator.h: Rename include guard.
14770 * common/filestuff.h: Rename include guard.
14771 * common/fileio.h: Rename include guard.
14772 * common/environ.h: Rename include guard.
14773 * common/common-utils.h: Rename include guard.
14774 * common/common-types.h: Rename include guard.
14775 * common/common-regcache.h: Rename include guard.
14776 * common/common-inferior.h: Rename include guard.
14777 * common/common-gdbthread.h: Rename include guard.
14778 * common/common-exceptions.h: Rename include guard.
14779 * common/common-defs.h: Rename include guard.
14780 * common/common-debug.h: Rename include guard.
14781 * common/cleanups.h: Rename include guard.
14782 * common/buffer.h: Rename include guard.
14783 * common/btrace-common.h: Rename include guard.
14784 * common/break-common.h: Rename include guard.
14785 * cli/cli-utils.h: Rename include guard.
14786 * cli/cli-style.h: Rename include guard.
14787 * cli/cli-setshow.h: Rename include guard.
14788 * cli/cli-script.h: Rename include guard.
14789 * cli/cli-interp.h: Rename include guard.
14790 * cli/cli-decode.h: Rename include guard.
14791 * cli/cli-cmds.h: Rename include guard.
14792 * charset-list.h: Add include guard.
14793 * buildsym-legacy.h: Rename include guard.
14794 * bfin-tdep.h: Add include guard.
14795 * ax.h: Rename include guard.
14796 * arm-linux-tdep.h: Add include guard.
14797 * arm-fbsd-tdep.h: Add include guard.
14798 * arch/xtensa.h: Rename include guard.
14799 * arch/tic6x.h: Add include guard.
14800 * arch/i386.h: Add include guard.
14801 * arch/arm.h: Rename include guard.
14802 * arch/arm-linux.h: Rename include guard.
14803 * arch/arm-get-next-pcs.h: Rename include guard.
14804 * arch/amd64.h: Add include guard.
14805 * arch/aarch64-insn.h: Rename include guard.
14806 * arch-utils.h: Rename include guard.
14807 * annotate.h: Add include guard.
14808 * amd64-darwin-tdep.h: Rename include guard.
14809 * aarch64-linux-tdep.h: Add include guard.
14810 * aarch64-fbsd-tdep.h: Add include guard.
14811 * aarch32-linux-nat.h: Add include guard.
14812
14813 2019-02-06 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14814
14815 * macrotab.c (macro_define_internal): New function that
14816 factorizes macro_define_object_internal and macro_define_function
14817 code.
14818 (macro_define_object_internal): Use macro_define_internal.
14819 (macro_define_function): Likewise.
14820
14821 2019-02-06 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14822
14823 * macrocmd.c (extract_identifier): Return
14824 a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
14825 callers.
14826
14827 2019-02-06 John Baldwin <jhb@FreeBSD.org>
14828
14829 * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
14830
14831 2019-02-05 Tom Tromey <tom@tromey.com>
14832
14833 * target.c (target_stack::unpush): Move assertion earlier.
14834
14835 2019-01-30 Tom Tromey <tom@tromey.com>
14836
14837 PR python/23615:
14838 * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
14839 (gdbpy_parse_and_eval): Likewise.
14840 * python/python-internal.h (gdbpy_allow_threads): New class.
14841
14842 2019-01-28 John Baldwin <jhb@FreeBSD.org>
14843
14844 * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
14845 (aarch64_fbsd_fpregmap): Move earlier.
14846 (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
14847 (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
14848 instead of individual calls to trad_frame_set_reg_addr.
14849 * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
14850 earlier.
14851 (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
14852 (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
14853 instead of individual calls to trad_frame_set_reg_addr.
14854
14855 2019-01-28 Alan Hayward <alan.hayward@arm.com>
14856
14857 * CONTRIBUTE: Replace contribution list with wiki link.
14858
14859 2019-01-25 Tom Tromey <tom@tromey.com>
14860
14861 * Makefile.in (GDB_CFLAGS): Don't add -I for common.
14862
14863 2019-01-25 Tom Tromey <tom@tromey.com>
14864
14865 * xtensa-linux-nat.c: Fix common/ includes.
14866 * xml-support.h: Fix common/ includes.
14867 * xml-support.c: Fix common/ includes.
14868 * x86-linux-nat.c: Fix common/ includes.
14869 * windows-nat.c: Fix common/ includes.
14870 * varobj.h: Fix common/ includes.
14871 * varobj.c: Fix common/ includes.
14872 * value.c: Fix common/ includes.
14873 * valops.c: Fix common/ includes.
14874 * utils.c: Fix common/ includes.
14875 * unittests/xml-utils-selftests.c: Fix common/ includes.
14876 * unittests/utils-selftests.c: Fix common/ includes.
14877 * unittests/unpack-selftests.c: Fix common/ includes.
14878 * unittests/tracepoint-selftests.c: Fix common/ includes.
14879 * unittests/style-selftests.c: Fix common/ includes.
14880 * unittests/string_view-selftests.c: Fix common/ includes.
14881 * unittests/scoped_restore-selftests.c: Fix common/ includes.
14882 * unittests/scoped_mmap-selftests.c: Fix common/ includes.
14883 * unittests/scoped_fd-selftests.c: Fix common/ includes.
14884 * unittests/rsp-low-selftests.c: Fix common/ includes.
14885 * unittests/parse-connection-spec-selftests.c: Fix common/
14886 includes.
14887 * unittests/optional-selftests.c: Fix common/ includes.
14888 * unittests/offset-type-selftests.c: Fix common/ includes.
14889 * unittests/observable-selftests.c: Fix common/ includes.
14890 * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
14891 * unittests/memrange-selftests.c: Fix common/ includes.
14892 * unittests/memory-map-selftests.c: Fix common/ includes.
14893 * unittests/lookup_name_info-selftests.c: Fix common/ includes.
14894 * unittests/function-view-selftests.c: Fix common/ includes.
14895 * unittests/environ-selftests.c: Fix common/ includes.
14896 * unittests/copy_bitwise-selftests.c: Fix common/ includes.
14897 * unittests/common-utils-selftests.c: Fix common/ includes.
14898 * unittests/cli-utils-selftests.c: Fix common/ includes.
14899 * unittests/array-view-selftests.c: Fix common/ includes.
14900 * ui-file.c: Fix common/ includes.
14901 * tui/tui-io.c: Fix common/ includes.
14902 * tracepoint.h: Fix common/ includes.
14903 * tracepoint.c: Fix common/ includes.
14904 * tracefile-tfile.c: Fix common/ includes.
14905 * top.h: Fix common/ includes.
14906 * top.c: Fix common/ includes.
14907 * thread.c: Fix common/ includes.
14908 * target/waitstatus.h: Fix common/ includes.
14909 * target/waitstatus.c: Fix common/ includes.
14910 * target.h: Fix common/ includes.
14911 * target.c: Fix common/ includes.
14912 * target-memory.c: Fix common/ includes.
14913 * target-descriptions.c: Fix common/ includes.
14914 * symtab.h: Fix common/ includes.
14915 * symfile.c: Fix common/ includes.
14916 * stap-probe.c: Fix common/ includes.
14917 * spu-linux-nat.c: Fix common/ includes.
14918 * sparc-nat.c: Fix common/ includes.
14919 * source.c: Fix common/ includes.
14920 * solib.c: Fix common/ includes.
14921 * solib-target.c: Fix common/ includes.
14922 * ser-unix.c: Fix common/ includes.
14923 * ser-tcp.c: Fix common/ includes.
14924 * ser-pipe.c: Fix common/ includes.
14925 * ser-base.c: Fix common/ includes.
14926 * selftest-arch.c: Fix common/ includes.
14927 * s12z-tdep.c: Fix common/ includes.
14928 * rust-exp.y: Fix common/ includes.
14929 * rs6000-aix-tdep.c: Fix common/ includes.
14930 * riscv-tdep.c: Fix common/ includes.
14931 * remote.c: Fix common/ includes.
14932 * remote-notif.h: Fix common/ includes.
14933 * remote-fileio.h: Fix common/ includes.
14934 * remote-fileio.c: Fix common/ includes.
14935 * regcache.h: Fix common/ includes.
14936 * regcache.c: Fix common/ includes.
14937 * record-btrace.c: Fix common/ includes.
14938 * python/python.c: Fix common/ includes.
14939 * python/py-type.c: Fix common/ includes.
14940 * python/py-inferior.c: Fix common/ includes.
14941 * progspace.h: Fix common/ includes.
14942 * producer.c: Fix common/ includes.
14943 * procfs.c: Fix common/ includes.
14944 * proc-api.c: Fix common/ includes.
14945 * printcmd.c: Fix common/ includes.
14946 * ppc-linux-nat.c: Fix common/ includes.
14947 * parser-defs.h: Fix common/ includes.
14948 * osdata.c: Fix common/ includes.
14949 * obsd-nat.c: Fix common/ includes.
14950 * nat/x86-linux.c: Fix common/ includes.
14951 * nat/x86-linux-dregs.c: Fix common/ includes.
14952 * nat/x86-dregs.h: Fix common/ includes.
14953 * nat/x86-dregs.c: Fix common/ includes.
14954 * nat/ppc-linux.c: Fix common/ includes.
14955 * nat/mips-linux-watch.h: Fix common/ includes.
14956 * nat/mips-linux-watch.c: Fix common/ includes.
14957 * nat/linux-waitpid.c: Fix common/ includes.
14958 * nat/linux-ptrace.h: Fix common/ includes.
14959 * nat/linux-ptrace.c: Fix common/ includes.
14960 * nat/linux-procfs.c: Fix common/ includes.
14961 * nat/linux-personality.c: Fix common/ includes.
14962 * nat/linux-osdata.c: Fix common/ includes.
14963 * nat/linux-namespaces.c: Fix common/ includes.
14964 * nat/linux-btrace.h: Fix common/ includes.
14965 * nat/linux-btrace.c: Fix common/ includes.
14966 * nat/fork-inferior.c: Fix common/ includes.
14967 * nat/amd64-linux-siginfo.c: Fix common/ includes.
14968 * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
14969 * nat/aarch64-linux.c: Fix common/ includes.
14970 * nat/aarch64-linux-hw-point.h: Fix common/ includes.
14971 * nat/aarch64-linux-hw-point.c: Fix common/ includes.
14972 * namespace.h: Fix common/ includes.
14973 * mips-linux-tdep.c: Fix common/ includes.
14974 * minsyms.c: Fix common/ includes.
14975 * mi/mi-parse.h: Fix common/ includes.
14976 * mi/mi-main.c: Fix common/ includes.
14977 * mi/mi-cmd-env.c: Fix common/ includes.
14978 * memrange.h: Fix common/ includes.
14979 * memattr.c: Fix common/ includes.
14980 * maint.h: Fix common/ includes.
14981 * maint.c: Fix common/ includes.
14982 * main.c: Fix common/ includes.
14983 * machoread.c: Fix common/ includes.
14984 * location.c: Fix common/ includes.
14985 * linux-thread-db.c: Fix common/ includes.
14986 * linux-nat.c: Fix common/ includes.
14987 * linux-fork.c: Fix common/ includes.
14988 * inline-frame.c: Fix common/ includes.
14989 * infrun.c: Fix common/ includes.
14990 * inflow.c: Fix common/ includes.
14991 * inferior.h: Fix common/ includes.
14992 * inferior.c: Fix common/ includes.
14993 * infcmd.c: Fix common/ includes.
14994 * inf-ptrace.c: Fix common/ includes.
14995 * inf-child.c: Fix common/ includes.
14996 * ia64-linux-nat.c: Fix common/ includes.
14997 * i387-tdep.c: Fix common/ includes.
14998 * i386-tdep.c: Fix common/ includes.
14999 * i386-linux-tdep.c: Fix common/ includes.
15000 * i386-linux-nat.c: Fix common/ includes.
15001 * i386-go32-tdep.c: Fix common/ includes.
15002 * i386-fbsd-tdep.c: Fix common/ includes.
15003 * i386-fbsd-nat.c: Fix common/ includes.
15004 * guile/scm-type.c: Fix common/ includes.
15005 * guile/guile.c: Fix common/ includes.
15006 * go32-nat.c: Fix common/ includes.
15007 * gnu-nat.c: Fix common/ includes.
15008 * gdbthread.h: Fix common/ includes.
15009 * gdbarch-selftests.c: Fix common/ includes.
15010 * gdb_usleep.c: Fix common/ includes.
15011 * gdb_select.h: Fix common/ includes.
15012 * gdb_bfd.c: Fix common/ includes.
15013 * gcore.c: Fix common/ includes.
15014 * fork-child.c: Fix common/ includes.
15015 * findvar.c: Fix common/ includes.
15016 * fbsd-nat.c: Fix common/ includes.
15017 * event-top.c: Fix common/ includes.
15018 * event-loop.c: Fix common/ includes.
15019 * dwarf2read.c: Fix common/ includes.
15020 * dwarf2loc.c: Fix common/ includes.
15021 * dwarf2-frame.c: Fix common/ includes.
15022 * dwarf-index-cache.c: Fix common/ includes.
15023 * dtrace-probe.c: Fix common/ includes.
15024 * disasm-selftests.c: Fix common/ includes.
15025 * defs.h: Fix common/ includes.
15026 * csky-tdep.c: Fix common/ includes.
15027 * cp-valprint.c: Fix common/ includes.
15028 * cp-support.h: Fix common/ includes.
15029 * cp-support.c: Fix common/ includes.
15030 * corelow.c: Fix common/ includes.
15031 * completer.h: Fix common/ includes.
15032 * completer.c: Fix common/ includes.
15033 * compile/compile.c: Fix common/ includes.
15034 * compile/compile-loc2c.c: Fix common/ includes.
15035 * compile/compile-cplus-types.c: Fix common/ includes.
15036 * compile/compile-cplus-symbols.c: Fix common/ includes.
15037 * command.h: Fix common/ includes.
15038 * cli/cli-dump.c: Fix common/ includes.
15039 * cli/cli-cmds.c: Fix common/ includes.
15040 * charset.c: Fix common/ includes.
15041 * build-id.c: Fix common/ includes.
15042 * btrace.h: Fix common/ includes.
15043 * btrace.c: Fix common/ includes.
15044 * breakpoint.h: Fix common/ includes.
15045 * breakpoint.c: Fix common/ includes.
15046 * ax.h:
15047 (enum agent_op): Fix common/ includes.
15048 * ax-general.c (struct aop_map): Fix common/ includes.
15049 * ax-gdb.c: Fix common/ includes.
15050 * auxv.c: Fix common/ includes.
15051 * auto-load.c: Fix common/ includes.
15052 * arm-tdep.c: Fix common/ includes.
15053 * arch/riscv.c: Fix common/ includes.
15054 * arch/ppc-linux-common.c: Fix common/ includes.
15055 * arch/i386.c: Fix common/ includes.
15056 * arch/arm.c: Fix common/ includes.
15057 * arch/arm-linux.c: Fix common/ includes.
15058 * arch/arm-get-next-pcs.c: Fix common/ includes.
15059 * arch/amd64.c: Fix common/ includes.
15060 * arch/aarch64.c: Fix common/ includes.
15061 * arch/aarch64-insn.c: Fix common/ includes.
15062 * arch-utils.c: Fix common/ includes.
15063 * amd64-windows-tdep.c: Fix common/ includes.
15064 * amd64-tdep.c: Fix common/ includes.
15065 * amd64-sol2-tdep.c: Fix common/ includes.
15066 * amd64-obsd-tdep.c: Fix common/ includes.
15067 * amd64-nbsd-tdep.c: Fix common/ includes.
15068 * amd64-linux-tdep.c: Fix common/ includes.
15069 * amd64-linux-nat.c: Fix common/ includes.
15070 * amd64-fbsd-tdep.c: Fix common/ includes.
15071 * amd64-fbsd-nat.c: Fix common/ includes.
15072 * amd64-dicos-tdep.c: Fix common/ includes.
15073 * amd64-darwin-tdep.c: Fix common/ includes.
15074 * agent.c: Fix common/ includes.
15075 * ada-lang.h: Fix common/ includes.
15076 * ada-lang.c: Fix common/ includes.
15077 * aarch64-tdep.c: Fix common/ includes.
15078
15079 2019-01-25 Tom Tromey <tom@tromey.com>
15080
15081 * common/create-version.sh: Use common/version.h.
15082
15083 2019-01-24 Pedro Alves <palves@redhat.com>
15084
15085 * infrun.c (signal_stop, signal_print, signal_program)
15086 (signal_catch, signal_pass): Now arrays instead of pointers.
15087 (update_signals_program_target, do_target_resume)
15088 (signal_catch_update, handle_command, _initialize_infrun): Adjust.
15089 * linux-nat.c (linux_nat_target::pass_signals)
15090 (linux_nat_target::create_inferior, linux_nat_target::attach):
15091 Adjust.
15092 * linux-nat.h (linux_nat_target::pass_signals): Adjust.
15093 * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
15094 * procfs.c (procfs_target::pass_signals): Adjust.
15095 * record-full.c (record_full_target::resume): Adjust.
15096 * remote.c (remote_target::pass_signals)
15097 (remote_target::program_signals): Adjust.
15098 * target-debug.h (target_debug_print_signals): Now takes a
15099 gdb::array_view as parameter. Adjust.
15100 * target.h (target_ops) <pass_signals, program_signals>: Replace
15101 pointer and length parameters with gdb::array_view.
15102 (target_pass_signals, target_program_signals): Likewise.
15103 * target-delegates.c: Regenerate.
15104
15105 2019-01-24 Pedro Alves <palves@redhat.com>
15106
15107 * common/forward-scope-exit.h
15108 (forward_scope_exit::forward_scope_exit): Pass arguments to
15109 m_bind_function directly, instead of creating a std::bind and
15110 copying that.
15111
15112 2019-01-24 Alan Hayward <alan.hayward@arm.com>
15113
15114 * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
15115 for static members.
15116 (pass_in_v_vfp_candidate): Likewise.
15117
15118 2019-01-23 Tom Tromey <tom@tromey.com>
15119 Pedro Alves <palves@redhat.com>
15120
15121 * regcache.c (class regcache_invalidator): Remove.
15122 (regcache::raw_write): Use make_scope_exit.
15123
15124 2019-01-23 Tom Tromey <tom@tromey.com>
15125
15126 * ui-out.h (class ui_out_emit_type): Update comment.
15127
15128 2019-01-23 Tom Tromey <tom@tromey.com>
15129
15130 * infrun.c (fetch_inferior_event): Update comment.
15131
15132 2019-01-23 Tom Tromey <tom@tromey.com>
15133 Pedro Alves <palves@redhat.com>
15134
15135 * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
15136 parameter.
15137 (fetch_inferior_event): Use SCOPE_EXIT.
15138
15139
15140 2019-01-23 Tom Tromey <tom@tromey.com>
15141 Pedro Alves <palves@redhat.com>
15142
15143 * infrun.c (disable_thread_events): Delete.
15144 (stop_all_threads): Use SCOPE_EXIT.
15145
15146 2019-01-23 Tom Tromey <tom@tromey.com>
15147 Pedro Alves <palves@redhat.com>
15148
15149 * symfile.c: Include forward-scope-exit.h.
15150 (clear_symtab_users_cleanup): Replace forward declaration with
15151 a FORWARD_SCOPE_EXIT.
15152 (syms_from_objfile_1): Use the forward_scope_exit and
15153 gdb::optional instead of cleanup_function.
15154 (reread_symbols): Use the forward_scope_exit instead of
15155 cleanup_function.
15156 (clear_symtab_users_cleanup): Remove function.
15157
15158 2019-01-23 Tom Tromey <tom@tromey.com>
15159 Pedro Alves <palves@redhat.com>
15160
15161 * linux-nat.c: Include scope-exit.h.
15162 (cleanup_target_stop): Remove.
15163 (linux_nat_target::static_tracepoint_markers_by_strid): Use
15164 SCOPE_EXIT.
15165
15166 2019-01-23 Tom Tromey <tom@tromey.com>
15167 Pedro Alves <palves@redhat.com>
15168
15169 * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
15170 (call_function_by_hand_dummy): Use SCOPE_EXIT.
15171
15172 2019-01-23 Tom Tromey <tom@tromey.com>
15173 Andrew Burgess <andrew.burgess@embecosm.com>
15174 Pedro Alves <palves@redhat.com>
15175
15176 * infrun.c (fetch_inferior_event): Use scope_exit.
15177 * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
15178 * top.c (execute_command): Use scope_exit.
15179 * breakpoint.c (bpstat_do_actions): Use scope_exit.
15180 * utils.c (do_bpstat_clear_actions_cleanup)
15181 (make_bpstat_clear_actions_cleanup): Remove.
15182
15183 2019-01-23 Tom Tromey <tom@tromey.com>
15184 Pedro Alves <palves@redhat.com>
15185
15186 * infrun.c: Include "common/scope-exit.h"
15187 (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
15188 (wait_for_inferior): Use SCOPE_EXIT.
15189 (fetch_inferior_event): Use scope_exit.
15190
15191 2019-01-23 Tom Tromey <tom@tromey.com>
15192 Pedro Alves <palves@redhat.com>
15193
15194 * breakpoint.c (create_breakpoint): Remove cleanup.
15195
15196 2019-01-23 Tom Tromey <tom@tromey.com>
15197 Andrew Burgess <andrew.burgess@embecosm.com>
15198 Pedro Alves <palves@redhat.com>
15199
15200 2019-01-23 Pedro Alves <palves@redhat.com>
15201
15202 * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
15203
15204 2019-01-23 Pedro Alves <palves@redhat.com>
15205 Andrew Burgess <andrew.burgess@embecosm.com>
15206
15207 * gdbthread.h: Include "common/forward-scope-exit.h".
15208 (scoped_finish_thread_state): Redefine custom class in terms of
15209 forward_scope_exit.
15210
15211 2019-01-23 Pedro Alves <palves@redhat.com>
15212 Andrew Burgess <andrew.burgess@embecosm.com>
15213
15214 * common/forward-scope-exit.h: New file.
15215
15216 2019-01-23 Pedro Alves <palves@redhat.com>
15217 Andrew Burgess <andrew.burgess@embecosm.com>
15218 Tom Tromey <tom@tromey.com>
15219
15220 * common/scope-exit.h: New file.
15221
15222 2019-01-23 Pedro Alves <palves@redhat.com>
15223
15224 * common/preprocessor.h (ESC): Rename to ...
15225 (ESC_PARENS): ... this.
15226 * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
15227 (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
15228
15229 2019-01-23 Tom Tromey <tom@tromey.com>
15230
15231 * language.h (class scoped_switch_to_sym_language_if_auto):
15232 Initialize m_lang in both cases.
15233
15234 2019-01-23 Alan Hayward <alan.hayward@arm.com>
15235
15236 * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
15237 with XCNEW.
15238
15239 2019-01-22 Tom Tromey <tom@tromey.com>
15240
15241 * corelow.c: Do not include sys/file.h.
15242
15243 2019-01-22 Tom Tromey <tom@tromey.com>
15244
15245 * tui/tui-wingeneral.h: Include gdb_curses.h.
15246
15247 2019-01-22 Tom Tromey <tom@tromey.com>
15248
15249 * source-cache.h (class source_cache) <get_source_lines,
15250 get_plain_source_lines, extract_lines>: Rename "lines" parameter.
15251
15252 2019-01-22 Tom Tromey <tom@tromey.com>
15253
15254 * remote-fileio.h (struct remote_target): Declare.
15255
15256 2019-01-22 Tom Tromey <tom@tromey.com>
15257
15258 * python/py-arch.c: Do not include py-ref.h.
15259 * python/py-bpevent.c: Do not include py-ref.h.
15260 * python/py-cmd.c: Do not include py-ref.h.
15261 * python/py-continueevent.c: Do not include py-ref.h.
15262 * python/py-event.h: Do not include py-ref.h.
15263 * python/py-evtregistry.c: Do not include py-ref.h.
15264 * python/py-finishbreakpoint.c: Do not include py-ref.h.
15265 * python/py-frame.c: Do not include py-ref.h.
15266 * python/py-framefilter.c: Do not include py-ref.h.
15267 * python/py-function.c: Do not include py-ref.h.
15268 * python/py-infevents.c: Do not include py-ref.h.
15269 * python/py-linetable.c: Do not include py-ref.h.
15270 * python/py-objfile.c: Do not include py-ref.h.
15271 * python/py-param.c: Do not include py-ref.h.
15272 * python/py-prettyprint.c: Do not include py-ref.h.
15273 * python/py-progspace.c: Do not include py-ref.h.
15274 * python/py-symbol.c: Do not include py-ref.h.
15275 * python/py-symtab.c: Do not include py-ref.h.
15276 * python/py-type.c: Do not include py-ref.h.
15277 * python/py-unwind.c: Do not include py-ref.h.
15278 * python/py-utils.c: Do not include py-ref.h.
15279 * python/py-value.c: Do not include py-ref.h.
15280 * python/py-varobj.c: Do not include py-ref.h.
15281 * python/py-xmethods.c: Do not include py-ref.h.
15282 * python/python.c: Do not include py-ref.h.
15283 * varobj.c: Do not include py-ref.h.
15284
15285 2019-01-22 Tom Tromey <tom@tromey.com>
15286
15287 * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
15288 keyword for bcache.
15289
15290 2019-01-22 Tom Tromey <tom@tromey.com>
15291
15292 * compile/compile-cplus-types.c: Remove a comment by #include.
15293
15294 2019-01-22 Tom Tromey <tom@tromey.com>
15295
15296 * compile/gcc-c-plugin.h: Include compile-internal.h.
15297
15298 2019-01-22 Tom Tromey <tom@tromey.com>
15299
15300 * stabsread.c (EXTERN): Do not define.
15301 (symnum, next_symbol_text_func, processing_gcc_compilation)
15302 (within_function, global_sym_chain, global_stabs)
15303 (previous_stab_code, this_object_header_files)
15304 (n_this_object_header_files)
15305 (n_allocated_this_object_header_files): Define.
15306 * stabsread.h (EXTERN): Never define. Use "extern".
15307
15308 2019-01-22 Philippe Waroquiers <philippe.waroquiers@skynet.be>
15309
15310 * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
15311 history_value.
15312
15313 2019-01-21 Tom Tromey <tom@tromey.com>
15314
15315 * ui-out.c: Fix includes.
15316 * tui/tui-source.c: Fix includes.
15317 * target.c: Fix includes.
15318 * remote.c: Fix includes.
15319 * regcache.c: Fix includes.
15320 * python/py-block.c: Fix includes.
15321 * printcmd.c: Fix includes.
15322 * or1k-tdep.c: Fix includes.
15323 * mi/mi-main.c: Fix includes.
15324 * m32r-tdep.c: Fix includes.
15325 * csky-tdep.c: Fix includes.
15326 * compile/compile-cplus-types.c: Fix includes.
15327 * cli/cli-interp.c: Fix includes.
15328
15329 2019-01-21 Alan Hayward <alan.hayward@arm.com>
15330
15331 * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
15332 for padding.
15333
15334 2019-01-16 Tom Tromey <tom@tromey.com>
15335
15336 * objfiles.h (struct minimal_symbol_iterator): Rename. Move
15337 earlier.
15338 (struct objfile) <msymbols_range>: Move from top level.
15339 <msymbols>: New method.
15340 (class objfile_msymbols): Remove.
15341 * symtab.c (default_collect_symbol_completion_matches_break_on):
15342 Update.
15343 * symmisc.c (dump_msymbols): Update.
15344 * stabsread.c (scan_file_globals): Update.
15345 * objc-lang.c (info_selectors_command, info_classes_command)
15346 (find_methods): Update.
15347 * minsyms.c (find_solib_trampoline_target): Update.
15348 * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
15349 * coffread.c (coff_symfile_read): Update.
15350 * ada-lang.c (ada_lookup_simple_minsym)
15351 (ada_collect_symbol_completion_matches): Update.
15352
15353 2019-01-16 Tom Tromey <tom@tromey.com>
15354
15355 * objfiles.h (class objfile_msymbols) <iterator>: Change argument
15356 type. Remove no-argument constructor.
15357 <iterator::operator++>: Simplify.
15358 <begin>: Update.
15359 <end>: Use minimal_symbol_count.
15360
15361 2019-01-16 Tom Tromey <tom@tromey.com>
15362
15363 * objfiles.h (struct objfile) <psymtabs>: New method.
15364 (class objfile_psymtabs): Remove.
15365 * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
15366 typedef.
15367 <range>: New method.
15368 (require_partial_symbols): Change return type.
15369 * psymtab.c (require_partial_symbols)
15370 (psym_expand_symtabs_matching): Update.
15371 * mdebugread.c (parse_partial_symbols): Update.
15372 * dbxread.c (dbx_end_psymtab): Update.
15373
15374 2019-01-15 Tom Tromey <tom@tromey.com>
15375
15376 * symtab.c (lookup_objfile_from_block)
15377 (lookup_symbol_in_objfile_symtabs)
15378 (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
15379 (find_line_symtab, info_sources_command)
15380 (default_collect_symbol_completion_matches_break_on)
15381 (make_source_files_completion_list): Update.
15382 * symmisc.c (print_objfile_statistics, dump_objfile)
15383 (maintenance_print_symbols, maintenance_info_symtabs)
15384 (maintenance_check_symtabs, maintenance_info_line_tables):
15385 Update.
15386 * source.c (select_source_symtab)
15387 (forget_cached_source_info_for_objfile): Update.
15388 * objfiles.h (class objfile_compunits): Remove.
15389 (struct objfile) <compunits_range>: New typedef.
15390 (compunits): New method.
15391 * objfiles.c (objfile_relocate1): Update.
15392 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
15393 * maint.c (count_symtabs_and_blocks): Update.
15394 * linespec.c (iterate_over_all_matching_symtabs): Update.
15395 * cp-support.c (add_symbol_overload_list_qualified): Update.
15396 * coffread.c (coff_symtab_read): Update.
15397 * ada-lang.c (add_nonlocal_symbols)
15398 (ada_collect_symbol_completion_matches)
15399 (ada_add_global_exceptions): Update.
15400
15401 2019-01-15 Tom Tromey <tom@tromey.com>
15402
15403 * progspace.h (program_space) <objfiles_safe_range>: New
15404 typedef.
15405 <objfiles_safe>: New method.
15406 * objfiles.h (class all_objfiles_safe): Remove.
15407 * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
15408 * jit.c (jit_inferior_exit_hook): Update.
15409
15410 2019-01-17 Tom Tromey <tom@tromey.com>
15411
15412 * progspace.h (program_space) <objfiles_range>: New typedef.
15413 <objfiles>: New method.
15414 <objfiles_head>: Rename from objfiles.
15415 (object_files): Update.
15416 * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
15417 * guile/scm-pretty-print.c
15418 (ppscm_find_pretty_printer_from_objfiles): Update.
15419 * guile/scm-objfile.c (gdbscm_objfiles): Update.
15420 * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
15421 Update.
15422 * python/py-progspace.c (pspy_get_objfiles): Update.
15423 * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
15424 Update.
15425 * python/py-objfile.c (objfpy_lookup_objfile_by_name)
15426 (objfpy_lookup_objfile_by_build_id): Update.
15427 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
15428 * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
15429 Update.
15430 * symtab.c (iterate_over_symtabs, matching_obj_sections)
15431 (expand_symtab_containing_pc, lookup_objfile_from_block)
15432 (lookup_static_symbol, basic_lookup_transparent_type)
15433 (find_pc_sect_compunit_symtab, find_symbol_at_address)
15434 (find_line_symtab, info_sources_command)
15435 (default_collect_symbol_completion_matches_break_on)
15436 (make_source_files_completion_list, find_main_name): Update.
15437 * symmisc.c (print_symbol_bcache_statistics)
15438 (print_objfile_statistics, maintenance_print_symbols)
15439 (maintenance_print_msymbols, maintenance_print_objfiles)
15440 (maintenance_info_symtabs, maintenance_check_symtabs)
15441 (maintenance_expand_symtabs, maintenance_info_line_tables):
15442 Update.
15443 * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
15444 (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
15445 (map_overlay_command, unmap_overlay_command)
15446 (simple_overlay_update, expand_symtabs_matching)
15447 (map_symbol_filenames): Update.
15448 * symfile-debug.c (set_debug_symfile): Update.
15449 * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
15450 Update.
15451 * source.c (select_source_symtab, forget_cached_source_info):
15452 Update.
15453 * solib.c (solib_read_symbols): Update.
15454 * solib-spu.c (append_ocl_sos): Update.
15455 * psymtab.c (maintenance_print_psymbols)
15456 (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
15457 * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
15458 * printcmd.c (info_symbol_command): Update.
15459 * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
15460 Update.
15461 * objfiles.h (class all_objfiles): Remove.
15462 * objfiles.c (have_partial_symbols, have_full_symbols)
15463 (have_minimal_symbols, qsort_cmp, update_section_map)
15464 (shared_objfile_contains_address_p)
15465 (default_iterate_over_objfiles_in_search_order): Update.
15466 * objc-lang.c (info_selectors_command, info_classes_command)
15467 (find_methods): Update.
15468 * minsyms.c (find_solib_trampoline_target): Update.
15469 * maint.c (maintenance_info_sections)
15470 (maintenance_translate_address, count_symtabs_and_blocks):
15471 Update.
15472 * main.c (captured_main_1): Update.
15473 * linux-thread-db.c (try_thread_db_load_from_pdir)
15474 (has_libpthread): Update.
15475 * linespec.c (iterate_over_all_matching_symtabs)
15476 (search_minsyms_for_name): Update.
15477 * jit.c (jit_find_objf_with_entry_addr): Update.
15478 * hppa-tdep.c (find_unwind_entry)
15479 (hppa_lookup_stub_minimal_symbol): Update.
15480 * gcore.c (gcore_create_callback, objfile_find_memory_regions):
15481 Update.
15482 * elfread.c (elf_gnu_ifunc_resolve_by_cache)
15483 (elf_gnu_ifunc_resolve_by_got): Update.
15484 * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
15485 * dwarf-index-write.c (save_gdb_index_command): Update.
15486 * cp-support.c (add_symbol_overload_list_qualified): Update.
15487 * breakpoint.c (create_overlay_event_breakpoint)
15488 (create_longjmp_master_breakpoint)
15489 (create_std_terminate_master_breakpoint)
15490 (create_exception_master_breakpoint): Update.
15491 * blockframe.c (find_pc_partial_function): Update.
15492 * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
15493 (ada_collect_symbol_completion_matches)
15494 (ada_add_global_exceptions): Update.
15495
15496 2019-01-17 Tom Tromey <tom@tromey.com>
15497
15498 * solib-target.c (lm_info_target_p): Remove typedef. Don't
15499 declare VEC.
15500 (solib_target_parse_libraries): Change return type.
15501 (library_list_start_segment, library_list_start_section)
15502 (library_list_end_library, library_list_start_library); Update.
15503 (solib_target_free_library_list): Remove.
15504 (solib_target_parse_libraries): Remove cleanup. Change return
15505 type.
15506 (solib_target_current_sos): Update.
15507
15508 2019-01-17 Tom Tromey <tromey@bapiya>
15509
15510 * valprint.c: Replace "the the" with "the".
15511 * symtab.c: Replace "the the" with "the".
15512 * solib.c: Replace "the the" with "the".
15513 * solib-dsbt.c: Replace "the the" with "the".
15514 * linespec.c: Replace "the the" with "the".
15515 * dwarf2loc.h: Replace "the the" with "the".
15516 * amd64-windows-tdep.c: Replace "the the" with "the".
15517 * aarch64-tdep.c: Replace "the the" with "the".
15518
15519 2019-01-16 Keith Seitz <keiths@redhat.com>
15520
15521 PR gdb/23773
15522 * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
15523 <builder>: Rename to ..
15524 <m_builder>: ... this and make private.
15525 (dwarf2_cu::get_builder): New method. Change all users of
15526 `builder' to use this method.
15527 (dwarf2_start_symtab): Move to ...
15528 (dwarf2_cu::start_symtab): ... here. Update all callers
15529 (setup_type_unit_groups): Move to ...
15530 (dwarf2_cu::setup_type_unit_groups): ... here. Update all
15531 callers.
15532 (dwarf2_cu::reset_builder): New method.
15533 (process_full_compunit, process_full_type_unit): Use
15534 dwarf2_cu::reset_builder.
15535 (follow_die_offset): Record the ancestor CU if it is different
15536 from the followed DIE's CU.
15537 (follow_die_sig_1): Likewise.
15538
15539 2019-01-15 Tom Tromey <tom@tromey.com>
15540
15541 * remote.c (class remote_state) <buf>: Now a char_vector.
15542 <buf_size>: Remove.
15543 (remote_target::getpkt): Change type of buf. Remove sizeof_buf
15544 parameter.
15545 (remote_target::getpkt_or_notif_sane_1)
15546 (remote_target::getpkt_sane)
15547 (remote_target::getpkt_or_notif_sane): Likewise.
15548 (class remote_target) <putpkt>: New overload.
15549 (remote_target::read_frame): Change type of "buf_p". Remove
15550 sizeof_p parameter.
15551 (packet_ok): New overload.
15552 (packet_check_result): New overload.
15553 Update all uses.
15554
15555 2019-01-14 Tom Tromey <tom@tromey.com>
15556
15557 * remote-notif.c (handle_notification, remote_notif_ack)
15558 (remote_notif_parse): Make "buf" const.
15559 * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
15560 const.
15561 (remote_notif_parse, remote_notif_ack, handle_notification):
15562 Likewise.
15563 * remote.c (remote_notif_stop_parse): Make "buf" const.
15564 (remote_target::remote_parse_stop_reply): Make "buf" const.
15565 (remote_notif_stop_ack): Make "buf" const.
15566
15567 2019-01-14 Tom Tromey <tom@tromey.com>
15568
15569 * remote.c (remote_console_output): Make parameter const.
15570
15571 2019-01-14 Tom Tromey <tom@tromey.com>
15572
15573 * target-debug.h (target_debug_print_signals): Constify.
15574 * nto-procfs.c (nto_procfs_target::pass_signals): Update.
15575 * procfs.c (procfs_target::pass_signals): Update.
15576 * linux-nat.c (linux_nat_target::pass_signals): Update.
15577 * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
15578 * target-delegates.c: Rebuild.
15579 * remote.c (remote_target::program_signals): Update.
15580 (remote_target::pass_signals): Update.
15581 * target.c (target_pass_signals): Constify argument.
15582 (target_program_signals): Likewise.
15583 * target.h (struct target_ops) <pass_signals, program_signals>:
15584 Constify argument.
15585 (target_pass_signals, target_program_signals): Constify argument.
15586
15587 2019-01-14 Tom Tromey <tom@tromey.com>
15588
15589 PR tui/28819:
15590 * tui/tui-io.c (gdb_wgetch): Print \r when needed.
15591
15592 2019-01-14 Pedro Franco de Carvalho <pedromfc@linux.ibm.com>
15593
15594 * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
15595 field.
15596 * rs6000-tdep.c: Include reggroups.h.
15597 (IS_V_ALIAS_PSEUDOREG): Define.
15598 (rs6000_register_name): Return names for the "vX" aliases.
15599 (rs6000_pseudo_register_type): Return type for the "vX" aliases.
15600 (rs6000_pseudo_register_reggroup_p): Restore. Handle "vX"
15601 aliases. Call default_register_reggroup_p for all other
15602 pseudo-registers.
15603 (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
15604 New functions.
15605 (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
15606 Handle "vX" aliases.
15607 (v_alias_pseudo_register_collect): New function.
15608 (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
15609 (rs6000_gdbarch_init): Initialize "vX" aliases as
15610 pseudo-registers. Restore registration of
15611 rs6000_pseudo_register_reggroup_p with
15612 set_tdesc_pseudo_register_reggroup_p.
15613
15614 2019-01-13 Max Filippov <jcmvbkbc@gmail.com>
15615
15616 * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
15617 tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
15618 set_gdbarch_num_pseudo_regs.
15619
15620 2019-01-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
15621
15622 * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
15623 Remove arg prefixname, add do_set and do_show.
15624 Add member functions set_list and show_list.
15625 * cli/cli-style.c (class cli_style_option): Update accordingly.
15626 (style_set_list): Move to file scope.
15627 (style_show_list): Likewise.
15628 (set_style): Call help_list.
15629 (show_style): Call cmd_show_list.
15630 (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
15631 Update to use the new macro.
15632
15633 2019-10-12 Joel Brobecker <brobecker@adacore.com>
15634
15635 * ada-lang.c (_initialize_ada_language): Expand the help text
15636 for the "catch exception" command.
15637
15638 2019-01-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
15639
15640 * symtab.c (matching_obj_sections): Initialize obj,
15641 declare it closer to its usage.
15642
15643 2019-01-10 Tom Tromey <tom@tromey.com>
15644
15645 * thread-iter.h (inf_threads_iterator): Use next_iterator.
15646 (basic_inf_threads_range): Remove.
15647 (inf_threads_range, inf_non_exited_threads_range)
15648 (safe_inf_threads_range): Use next_adapter.
15649
15650 2019-01-10 Keith Seitz <keiths@redhat.com>
15651
15652 PR gdb/23712
15653 PR symtab/23010
15654 * dwarf2read.c (dw2_add_symbol_to_list): Remove.
15655 (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
15656
15657 2019-01-10 Keith Seitz <keiths@redhat.com>
15658
15659 PR gdb/23712
15660 PR symtab/23010
15661 * dictionary.c (pending_to_vector): Remove.
15662 (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
15663 Remove _1 suffix, replacing functions of the same name. Update
15664 all callers.
15665 (dict_create_hashed, dict_create_hashed_expandable)
15666 (dict_create_linear, dict_create_linear_expandable, dict_free)
15667 (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
15668 Make functions static.
15669
15670 2019-01-10 Keith Seitz <keiths@redhat.com>
15671
15672 PR gdb/23712
15673 PR symtab/23010
15674 * dictionary.h (struct dictionary): Replace declaration with
15675 multidictionary.
15676 (dict_create_hashed, dict_create_hashed_expandable)
15677 (dict_create_linear, dict_create_linear_expandable)
15678 (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
15679 (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
15680 (dict_iter_match_next, dict_size): Rename to "mdict_" versions
15681 taking multidictionary argument.
15682 [ALL_DICT_SYMBOLS]: Update for multidictionary.
15683 * block.h (struct block) <dict>: Change to multidictionary
15684 and rename `multidict'.
15685 * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
15686 symmisc.c: Update all dictionary references to multidictionary.
15687
15688 2019-01-10 Keith Seitz <keiths@redhat.com>
15689
15690 PR gdb/23712
15691 PR symtab/23010
15692 * dictionary.c: Include unordered_map.
15693 (pending_to_vector): New function.
15694 (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
15695 Rewrite the non-"_1" functions to take vector instead
15696 of linked list.
15697 (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
15698 "new" _1 versions of the same name.
15699 (multidictionary): Define.
15700 (std::hash<enum language): New definition.
15701 (collate_pending_symbols_by_language, mdict_create_hashed)
15702 (mdict_create_hashed_expandable, mdict_create_linear)
15703 (mdict_create_linear_expandable, mdict_free)
15704 (find_language_dictionary, create_new_language_dictionary)
15705 (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
15706 (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
15707 (mdict_size, mdict_empty): New functions.
15708 * dictionary.h (mdict_iterator): Define.
15709
15710 2019-01-10 Pedro Alves <palves@redhat.com>
15711
15712 * breakpoint.c (read_uploaded_action)
15713 (create_tracepoint_from_upload): Adjust to use
15714 gdb::unique_xmalloc_ptr.
15715 * ctf.c (ctf_write_uploaded_tp):
15716 (SET_ARRAY_FIELD): Use emplace_back.
15717 (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
15718 * tracefile-tfile.c (tfile_write_uploaded_tp):
15719 * tracepoint.c (parse_tracepoint_definition): Adjust to use
15720 gdb::unique_xmalloc_ptr.
15721 * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
15722 at_string, cond_string, cmd_strings>: Replace char pointers
15723 with gdb::unique_xmalloc_ptr.
15724
15725 2019-01-10 Pedro Alves <palves@redhat.com>
15726
15727 * solib-target.c (library_list_start_library): Don't xstrdup name.
15728
15729 2019-01-10 Pedro Alves <palves@redhat.com>
15730
15731 * mdebugread.c (parse_partial_symbols): Use
15732 gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
15733
15734 2019-01-10 Andrew Burgess <andrew.burgess@embecosm.com>
15735
15736 * linux-fork.c (scoped_switch_fork_info)
15737 <~scoped_switch_fork_info>: Fix incorrect variable name.
15738
15739 2019-01-10 Andrew Burgess <andrew.burgess@embecosm.com>
15740
15741 * linux-fork.c (scoped_switch_fork_info)
15742 <scoped_switch_fork_info>: Make explicit.
15743 <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
15744
15745 2019-01-10 Tom Tromey <tom@tromey.com>
15746
15747 * objfiles.h (objfile::reset_psymtabs): Update.
15748 * objfiles.c (objfile::objfile): Update.
15749 * psymtab.h (psymtab_storage::obstack): Update.
15750 (psymtab_storage::m_obstack): Use gdb::optional.
15751 (class psymtab_storage): Update comment. Remove objfile
15752 parameter.
15753 * psymtab.c (psymtab_storage::psymtab_storage): Update.
15754
15755 2019-01-10 Tom Tromey <tom@tromey.com>
15756
15757 * psymtab.h (psymtab_storage::allocate_psymtab): New method.
15758 <free_psymtabs>: Now private.
15759 * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
15760 (allocate_psymtab): Use new method.
15761
15762 2019-01-10 Tom Tromey <tom@tromey.com>
15763
15764 * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
15765 * psymtab.h (psymtab_storage::allocate_dependencies): New method.
15766 * mdebugread.c (parse_partial_symbols): Use
15767 allocate_dependencies.
15768 * dwarf2read.c (dwarf2_create_include_psymtab): Use
15769 allocate_dependencies.
15770 (process_psymtab_comp_unit_reader)
15771 (build_type_psymtab_dependencies): Likewise.
15772 * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
15773
15774 2019-01-10 Tom Tromey <tom@tromey.com>
15775
15776 * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
15777 PSYMBOL_SET_LANGUAGE.
15778 (allocate_psymtab): Allocate psymtab on the psymtab obstack.
15779
15780 2019-01-10 Tom Tromey <tom@tromey.com>
15781
15782 * psymtab.h (psymtab_storage::obstack): New method.
15783 <m_obstack>: Rename from obstack; now private.
15784 * psymtab.c (psymtab_storage): Update.
15785 * dwarf2read.c (create_addrmap_from_index)
15786 (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
15787 Update.
15788
15789 2019-01-10 Tom Tromey <tom@tromey.com>
15790
15791 * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
15792 * objfiles.h (objfile::reset_psymtabs): New method.
15793
15794 2019-01-10 Tom Tromey <tom@tromey.com>
15795
15796 * symmisc.c (print_symbol_bcache_statistics): Update.
15797 (print_objfile_statistics): Update.
15798 * symfile.c (reread_symbols): Update.
15799 * psymtab.h (class psymtab_storage): New.
15800 * psymtab.c (psymtab_storage): New constructor.
15801 (~psymtab_storage): New destructor.
15802 (require_partial_symbols): Update.
15803 (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
15804 (find_pc_sect_psymtab, find_pc_sect_psymbol)
15805 (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
15806 (psym_dump, recursively_search_psymtabs, psym_has_symbols)
15807 (psym_find_compunit_symtab_by_address, sort_pst_symbols)
15808 (start_psymtab_common, end_psymtab_common)
15809 (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
15810 (allocate_psymtab): Update.
15811 (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
15812 Update.
15813 (dump_psymtab_addrmap, maintenance_print_psymbols)
15814 (maintenance_check_psymtabs): Update.
15815 (class objfile_psymtabs): Move to objfiles.h.
15816 * psympriv.h (discard_psymtab): Now inline.
15817 (psymtab_discarder::psymtab_discarder): Update.
15818 (psymtab_discarder::~psymtab_discarder): Update.
15819 (ALL_OBJFILE_PSYMTABS): Rewrite.
15820 * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
15821 free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
15822 Remove fields.
15823 <partial_symtabs>: New field.
15824 (class objfile_psymtabs): Move from psymtab.h. Update.
15825 * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
15826 psymbol_cache.
15827 (objfile::~objfile): Don't destroy psymbol_cache.
15828 * mdebugread.c (parse_partial_symbols): Update.
15829 * dwarf2read.c (create_addrmap_from_index)
15830 (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
15831 (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
15832 (add_partial_subprogram, dwarf2_ranges_read): Update.
15833 * dwarf-index-write.c (write_address_map)
15834 (write_one_signatured_type, recursively_write_psymbols)
15835 (class debug_names, class debug_names, write_psymtabs_to_index):
15836 Update.
15837
15838 2019-01-10 Tom Tromey <tom@tromey.com>
15839
15840 * symtab.h (SYMBOL_SET_NAMES): Update.
15841 (symbol_set_names): Update.
15842 (MSYMBOL_SET_NAMES): Update.
15843 * symtab.c (symbol_set_names): Change argument to be an
15844 objfile_per_bfd_storage.
15845 * psymtab.c (add_psymbol_to_bcache): Update.
15846 * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
15847
15848 2019-01-10 Tom Tromey <tom@tromey.com>
15849
15850 * symtab.c (create_demangled_names_hash): Change argument to be an
15851 objfile_per_bfd_storage.
15852 (symbol_set_names): Update.
15853
15854 2019-01-10 Tom Tromey <tom@tromey.com>
15855
15856 * xcoffread.c (xcoff_initial_scan): Unconditionally call
15857 init_psymbol_list.
15858 * psymtab.c (init_psymbol_list): Do nothing if already called.
15859 * psympriv.h (init_psymbol_list): Add comment.
15860 * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
15861 init_psymbol_list.
15862 * dbxread.c (dbx_symfile_read): Unconditionally call
15863 init_psymbol_list.
15864
15865 2019-01-10 Tom Tromey <tom@tromey.com>
15866
15867 * xcoffread.c (scan_xcoff_symtab): Update.
15868 * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
15869 "where".
15870 * mdebugread.c (parse_partial_symbols)
15871 (handle_psymbol_enumerators): Update.
15872 * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
15873 * dbxread.c (read_dbx_symtab): Update.
15874 * psympriv.h (psymbol_placement): New enum.
15875 (add_psymbol_to_list): Update.
15876
15877 2019-01-10 Tom Tromey <tom@tromey.com>
15878
15879 * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
15880 static_psymbols parameters.
15881 (scan_xcoff_symtab): Update.
15882 * psymtab.c (start_psymtab_common): Remove global_psymbols and
15883 static_psymbols parameters.
15884 * psympriv.h (start_psymtab_common): Update.
15885 * mdebugread.c (parse_partial_symbols): Update.
15886 * dwarf2read.c (create_partial_symtab): Update.
15887 * dbxread.c (read_dbx_symtab): Update.
15888 (start_psymtab): Remove global_psymbols and static_psymbols
15889 parameters.
15890
15891 2019-01-10 Tom Tromey <tom@tromey.com>
15892
15893 * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
15894 * psymtab.c (allocate_psymtab): Add comment.
15895 * psympriv.h (allocate_psymtab): Add comment.
15896 * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
15897 initializations.
15898 * dbxread.c (dbx_end_psymtab): Remove some initializations.
15899
15900 2019-01-10 Tom Tromey <tom@tromey.com>
15901
15902 * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
15903 Don't declare.
15904 * mipsread.c: Include mdebugread.h.
15905 * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
15906 Declare.
15907 * elfread.c: Include mdebugread.h.
15908
15909 2019-01-09 Tom Tromey <tom@tromey.com>
15910
15911 * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
15912 * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
15913 * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
15914 (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
15915 (psym_lookup_symbol, psym_find_last_source_symtab)
15916 (psym_forget_cached_source_info, psym_print_stats)
15917 (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
15918 (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
15919 (psym_map_matching_symbols, psym_expand_symtabs_matching)
15920 (psym_find_compunit_symtab_by_address)
15921 (maintenance_print_psymbols, maintenance_info_psymtabs)
15922 (maintenance_check_psymtabs): Use ranged for.
15923 * psymtab.h (class objfile_psymtabs): New.
15924 (require_partial_symbols): Return objfile_psymtabs.
15925 * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
15926
15927 2019-01-09 Tom Tromey <tom@tromey.com>
15928
15929 * symfile.c (overlay_invalidate_all, find_pc_overlay)
15930 (find_pc_mapped_section, list_overlays_command)
15931 (map_overlay_command, unmap_overlay_command)
15932 (simple_overlay_update): Use all_objfiles.
15933 * spu-tdep.c (spu_overlay_update): Use all_objfiles.
15934 * printcmd.c (info_symbol_command): Use all_objfiles.
15935 * objfiles.h (ALL_OBJSECTIONS): Remove.
15936 * maint.c (maintenance_translate_address): Use all_objfiles.
15937 * gcore.c (gcore_create_callback): Use all_objfiles.
15938 (objfile_find_memory_regions): Likewise.
15939
15940 2019-01-09 Tom Tromey <tom@tromey.com>
15941
15942 * symtab.c (find_line_symtab, info_sources_command)
15943 (make_source_files_completion_list): Use objfile_compunits.
15944 * source.c (select_source_symtab): Use objfile_compunits.
15945 * objfiles.h (struct objfile): Update comment.
15946 (ALL_OBJFILES): Remove.
15947 (ALL_FILETABS): Remove.
15948 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
15949 objfile_compunits.
15950
15951 2019-01-09 Tom Tromey <tom@tromey.com>
15952
15953 * symmisc.c (print_objfile_statistics, dump_objfile)
15954 (maintenance_print_symbols): Use compunit_filetabs.
15955 * source.c (forget_cached_source_info_for_objfile): Use
15956 compunit_filetabs.
15957 * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
15958 (ALL_FILETABS): Use compunit_filetabs.
15959 * objfiles.c (objfile_relocate1): Use compunit_filetabs.
15960 * coffread.c (coff_symtab_read): Use compunit_filetabs.
15961
15962 2019-01-09 Tom Tromey <tom@tromey.com>
15963
15964 * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
15965 (compunit_filetabs): New.
15966 * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
15967 compunit_filetabs.
15968 (info_sources_command, make_source_files_completion_list): Remove
15969 declaration.
15970 * symmisc.c (print_objfile_statistics, dump_objfile)
15971 (maintenance_print_symbols): Remove declaration.
15972 (maintenance_info_symtabs): Use compunit_filetabs.
15973 (maintenance_info_line_tables): Likewise.
15974 * source.c (select_source_symtab): Change local variable name.
15975 (forget_cached_source_info_for_objfile): Remove declaration.
15976 * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
15977 * objfiles.c (objfile_relocate1): Remove declaration.
15978 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
15979 declaration.
15980 * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
15981 * coffread.c (coff_symtab_read): Remove declaration.
15982 * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
15983 compunit_filetabs.
15984
15985 2019-01-09 Tom Tromey <tom@tromey.com>
15986
15987 * symtab.c (lookup_objfile_from_block)
15988 (find_pc_sect_compunit_symtab, search_symbols)
15989 (default_collect_symbol_completion_matches_break_on): Use
15990 objfile_compunits.
15991 * objfiles.h (ALL_COMPUNITS): Remove.
15992 * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
15993 * cp-support.c (add_symbol_overload_list_qualified): Use
15994 objfile_compunits.
15995 * ada-lang.c (ada_collect_symbol_completion_matches)
15996 (ada_add_global_exceptions): Use objfile_compunits.
15997
15998 2019-01-09 Tom Tromey <tom@tromey.com>
15999
16000 * source.c (select_source_symtab)
16001 (forget_cached_source_info_for_objfile): Remove declaration.
16002 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
16003 declaration.
16004 * maint.c (count_symtabs_and_blocks): Remove declaration.
16005 * cp-support.c (add_symbol_overload_list_qualified): Remove
16006 declaration.
16007 * coffread.c (coff_symtab_read): Remove declaration.
16008 * symtab.c (lookup_symbol_in_objfile_symtabs)
16009 (basic_lookup_transparent_type_1): Use objfile_compunits.
16010 (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
16011 (info_sources_command, search_symbols)
16012 (default_collect_symbol_completion_matches_break_on)
16013 (make_source_files_completion_list): Remove declaration.
16014 * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
16015 (ada_collect_symbol_completion_matches)
16016 (ada_add_global_exceptions): Remove declaration.
16017 * linespec.c (iterate_over_all_matching_symtabs): Use
16018 objfile_compunits.
16019 * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
16020 (class objfile_compunits): New.
16021 (ALL_COMPUNITS): Use objfile_compunits.
16022 * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
16023 (maintenance_check_symtabs, maintenance_info_line_tables): Use
16024 objfile_compunits.
16025 * objfiles.c (objfile_relocate1): Use objfile_compunits.
16026
16027 2019-01-09 Tom Tromey <tom@tromey.com>
16028
16029 * symtab.c (search_symbols)
16030 (default_collect_symbol_completion_matches_break_on): Use
16031 objfile_msymbols.
16032 * ada-lang.c (ada_lookup_simple_minsym)
16033 (ada_collect_symbol_completion_matches): Use objfile_msymbols.
16034 * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
16035 * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
16036 objfile_msymbols.
16037 * coffread.c (coff_symfile_read): Use objfile_msymbols.
16038 * symmisc.c (dump_msymbols): Use objfile_msymbols.
16039 * objc-lang.c (find_methods): Use objfile_msymbols.
16040 (info_selectors_command, info_classes_command): Likewise.
16041 * stabsread.c (scan_file_globals): Use objfile_msymbols.
16042 * objfiles.h (class objfile_msymbols): New.
16043 (ALL_OBJFILE_MSYMBOLS): Remove.
16044 (ALL_MSYMBOLS): Remove.
16045
16046 2019-01-09 Tom Tromey <tom@tromey.com>
16047
16048 * common/next-iterator.h (next_adapter): Add Iterator template
16049 parameter.
16050 * objfiles.h (ALL_OBJFILES_SAFE): Remove.
16051 (class all_objfiles_safe): New.
16052 * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
16053 * objfiles.c (put_objfile_before): Update comment.
16054 (add_separate_debug_objfile): Likewise.
16055 (free_all_objfiles): Use all_objfiles_safe.
16056 (objfile_purge_solibs): Likewise.
16057
16058 2019-01-09 Tom Tromey <tom@tromey.com>
16059
16060 * symtab.c (iterate_over_symtabs, matching_obj_sections)
16061 (expand_symtab_containing_pc, lookup_static_symbol)
16062 (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
16063 (find_symbol_at_address, find_line_symtab, find_main_name): Use
16064 all_objfiles.
16065 * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
16066 * breakpoint.c (create_overlay_event_breakpoint)
16067 (create_longjmp_master_breakpoint)
16068 (create_std_terminate_master_breakpoint)
16069 (create_exception_master_breakpoint): Use all_objfiles.
16070 * linux-thread-db.c (try_thread_db_load_from_pdir)
16071 (has_libpthread): Use all_objfiles.
16072 * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
16073 * linespec.c (iterate_over_all_matching_symtabs)
16074 (search_minsyms_for_name): Use all_objfiles.
16075 * maint.c (maintenance_info_sections): Use all_objfiles.
16076 * main.c (captured_main_1): Use all_objfiles.
16077 * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
16078 * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
16079 * guile/scm-pretty-print.c
16080 (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
16081 * solib-spu.c (append_ocl_sos): Use all_objfiles.
16082 * symmisc.c (maintenance_print_symbols): Use all_objfiles.
16083 (maintenance_print_msymbols): Use all_objfiles.
16084 * source.c (select_source_symtab): Use all_objfiles.
16085 * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
16086 * symfile.c (remove_symbol_file_command)
16087 (expand_symtabs_matching, map_symbol_filenames): Use
16088 all_objfiles.
16089 * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
16090 all_objfiles.
16091 * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
16092 * objc-lang.c (find_methods): Use all_objfiles.
16093 * objfiles.c (have_partial_symbols, have_full_symbols)
16094 (have_minimal_symbols, qsort_cmp)
16095 (default_iterate_over_objfiles_in_search_order): Use
16096 all_objfiles.
16097 * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
16098 * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
16099 (maintenance_check_psymtabs): Use all_objfiles.
16100 (ALL_PSYMTABS): Remove.
16101 * compile/compile-object-run.c (do_module_cleanup): Use
16102 all_objfiles.
16103 * blockframe.c (find_pc_partial_function): Use all_objfiles.
16104 * cp-support.c (add_symbol_overload_list_qualified): Use
16105 all_objfiles.
16106 * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
16107 Use all_objfiles.
16108 * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
16109 * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
16110 all_objfiles.
16111 * python/py-objfile.c (objfpy_lookup_objfile_by_name)
16112 (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
16113 * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
16114 Uses all_objfiles.
16115 * solib.c (solib_read_symbols): Use all_objfiles
16116
16117 2019-01-09 Tom Tromey <tom@tromey.com>
16118
16119 * probe.c (parse_probes_in_pspace): Use all_objfiles.
16120 * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
16121 all_objfiles.
16122 * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
16123 * symmisc.c (print_symbol_bcache_statistics)
16124 (print_objfile_statistics, maintenance_print_objfiles)
16125 (maintenance_info_symtabs, maintenance_check_symtabs)
16126 (maintenance_expand_symtabs, maintenance_info_line_tables): Use
16127 all_objfiles.
16128 * source.c (forget_cached_source_info): Use all_objfiles.
16129 * symfile-debug.c (set_debug_symfile): Use all_objfiles.
16130 * elfread.c (elf_gnu_ifunc_resolve_by_cache)
16131 (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
16132 * objfiles.c (update_section_map): Use all_objfiles.
16133 (shared_objfile_contains_address_p): Likewise.
16134 * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
16135 * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
16136
16137 2019-01-09 Tom Tromey <tom@tromey.com>
16138
16139 * common/next-iterator.h: New file.
16140 * objfiles.h (class all_objfiles): New.
16141 (struct objfile_iterator): New.
16142
16143 2019-01-09 Philippe Waroquiers <philippe.waroquiers@skynet.be>
16144
16145 * NEWS: Move the description of the changed "frame", "select-frame",
16146 and "info frame" commands to the Changed commands section.
16147
16148 2019-01-09 Simon Marchi <simon.marchi@ericsson.com>
16149
16150 * gdbtypes.c (check_stub_method_group): Remove handling of old
16151 mangling schemes.
16152 * linespec.c (find_methods): Likewise.
16153 * stabsread.c (read_member_functions): Likewise.
16154 * valops.c (search_struct_method): Likewise.
16155 (value_struct_elt_for_reference): Likewise.
16156 * NEWS: Mention this change.
16157
16158 2019-01-09 Andrew Burgess <andrew.burgess@embecosm.com>
16159
16160 * cli/cli-cmds.c (list_command): Pass a source_lines_range to
16161 print_source_lines.
16162 * source.c (print_source_lines_base): Update line number check.
16163 (print_source_lines): New function.
16164 (source_lines_range::source_lines_range): New function.
16165 * source.h (class source_lines_range): New class.
16166 (print_source_lines): New declaration.
16167
16168 2019-01-09 Philippe Waroquiers <philippe.waroquiers@skynet.be>
16169
16170 * linespec.c (linespec_state_destructor): Free self->canonical_names.
16171
16172 2019-01-08 Tom Tromey <tom@tromey.com>
16173 Simon Marchi <simon.marchi@ericsson.com>
16174
16175 PR gdb/24060
16176 * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
16177 * ada-lex.l (DOLLAR_VARIABLE): Likewise.
16178 * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
16179 * f-exp.y (DOLLAR_VARIABLE): Likewise.
16180 * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
16181 * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
16182
16183 2019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
16184
16185 * source.c (select_source_symtab): Move header comment to
16186 declaration in source.h.
16187 (forget_cached_source_info_for_objfile): Likewise.
16188 (forget_cached_source_info): Likewise.
16189 (identify_source_line): Likewise.
16190 * source.h (identify_source_line): Move declaration from symtab.h
16191 and add comment from source.c
16192 (print_source_lines): Likewise.
16193 (forget_cached_source_info_for_objfile): Likewise.
16194 (forget_cached_source_info): Likewise.
16195 (select_source_symtab): Likewise.
16196 (enum print_source_lines_flag): Move definition from symtab.h.
16197 * symtab.h (identify_source_line): Move declaration to source.h.
16198 (print_source_lines): Likewise.
16199 (forget_cached_source_info_for_objfile): Likewise.
16200 (forget_cached_source_info): Likewise.
16201 (select_source_symtab): Likewise.
16202 (enum print_source_lines_flag): Move definition to source.h.
16203 * tui/tui-hooks.c: Add 'source.h' include.
16204
16205 2019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
16206
16207 * source.c (print_source_lines_base): Handle requests to print
16208 reverse line number sequences, and guard against empty lines
16209 string.
16210
16211 2019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
16212
16213 * source.c (print_source_lines_base): Fix skip of '\r' if next
16214 character is '\n'.
16215
16216 2019-01-06 Tom Tromey <tom@tromey.com>
16217
16218 * c-exp.y (struct c_parse_state) <macro_original_text,
16219 expansion_obstack>: New member.
16220 (macro_original_text, expansion_obstack): Remove globals.
16221 (scan_macro_expansion, scanning_macro_expansion)
16222 (finished_macro_expansion): Update.
16223 (scan_macro_cleanup): Remove.
16224 (yylex, c_parse): Update.
16225
16226 2019-01-06 Tom Tromey <tom@tromey.com>
16227
16228 * c-exp.y (struct c_parse_state) <strings>: New member.
16229 (operator_stoken): Update.
16230
16231 2019-01-06 Tom Tromey <tom@tromey.com>
16232
16233 * parser-defs.h (type_ptr): Remove typedef. Don't declare VEC.
16234 (union type_stack_elt) <typelist_val>: Now a pointer to
16235 std::vector.
16236 (type_stack_cleanup): Don't declare.
16237 (push_typelist): Update.
16238 * parse.c (pop_typelist): Return a std::vector.
16239 (push_typelist): Take a std::vector.
16240 (follow_types): Update. Do not free args.
16241 (type_stack_cleanup): Remove.
16242 * c-exp.y (struct c_parse_state): New.
16243 (cpstate): New global.
16244 (type_aggregate_p, exp, ptr_operator, parameter_typelist)
16245 (nonempty_typelist): Update.
16246 (func_mod): Create a new vector.
16247 (c_parse): Create a c_parse_state.
16248 (check_parameter_typelist): Do not delete params.
16249 (function_method): Update. Do not delete type_list.
16250
16251 2019-01-06 Tom Tromey <tom@tromey.com>
16252
16253 PR gdb/28155:
16254 * python/py-finishbreakpoint.c (bpfinishpy_init): Use
16255 check_typedef.
16256 * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
16257 (print_return_value): Likewise.
16258
16259 2019-01-05 Tom Tromey <tom@tromey.com>
16260
16261 * contrib/cleanup_check.py: Remove.
16262 * contrib/gcc-with-excheck: Remove.
16263 * contrib/exsummary.py: Remove.
16264 * contrib/excheck.py: Remove.
16265
16266 2019-01-05 Joel Brobecker <brobecker@adacore.com>
16267
16268 * thread.c (delete_thread_1): Add gdb_assert that THR is not
16269 NULL. Initialize tpprev to NULL instead of assigning it
16270 to NULL on the next statement.
16271 * windows-nat.c (windows_delete_thread): Remove check for
16272 main_thread_id before printing thread exit notifications.
16273 (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
16274 Remove thread ID check against main_thread_id.
16275 <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
16276 windows_delete_thread.
16277 <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
16278
16279 2019-01-04 Tom Tromey <tom@tromey.com>
16280
16281 * compile/compile.c (_initialize_compile): Use upper case for
16282 metasyntactic variables.
16283 * symmisc.c (_initialize_symmisc): Use upper case for
16284 metasyntactic variables.
16285 * psymtab.c (_initialize_psymtab): Use upper case for
16286 metasyntactic variables.
16287 * demangle.c (demangle_command): Use upper case for metasyntactic
16288 variables.
16289 (_initialize_demangler): Likewise.
16290 * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
16291 variables.
16292
16293 2019-01-03 Tom Tromey <tom@tromey.com>
16294
16295 * tui/tui-source.c (tui_set_source_content): Use xstrdup.
16296
16297 2019-01-03 Tom Tromey <tom@tromey.com>
16298
16299 * python/py-symtab.c (salpy_str): Update.
16300 (struct salpy_sal_object) <symtab>: Now a PyObject.
16301 (salpy_dealloc): Update.
16302 (del_objfile_sal): Use gdbpy_ref.
16303
16304 2019-01-03 Tom Tromey <tom@tromey.com>
16305
16306 * python/py-type.c (convert_field): Use new_reference. Return
16307 gdbpy_ref.
16308 (make_fielditem): Return gdbpy_ref.
16309 (typy_fields): Update.
16310 (typy_getitem): Update.
16311 (field_name): Return gdbpy_ref. Use new_reference.
16312 (typy_iterator_iternext): Update.
16313
16314 2019-01-03 Tom Tromey <tom@tromey.com>
16315
16316 * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
16317
16318 2019-01-03 Tom Tromey <tom@tromey.com>
16319
16320 * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
16321 * python/py-type.c (typy_fields_items): Use gdbpy_ref.
16322 * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
16323 (pspy_set_frame_filters, pspy_set_frame_unwinders)
16324 (pspy_set_type_printers): Likewise.
16325 * python/py-function.c (fnpy_init): Use gdbpy_ref.
16326 * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
16327 * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
16328 (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
16329 (objfpy_set_type_printers): Likewise.
16330
16331 2019-01-03 Tom Tromey <tom@tromey.com>
16332
16333 * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
16334 (gdbpy_print_stack): Use gdbpy_err_fetch.
16335 * python/python-internal.h (class gdbpy_err_fetch): New class.
16336 (class gdbpy_enter) <m_error_type, m_error_value,
16337 m_error_traceback>: Remove.
16338 <m_error>: New member.
16339 (gdbpy_exception_to_string): Don't declare.
16340 * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
16341 * python/py-value.c (convert_value_from_python): Use
16342 gdbpy_err_fetch.
16343 * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
16344 gdbpy_exception_to_string.
16345 (gdbpy_handle_exception): Use gdbpy_err_fetch.
16346 * python/py-prettyprint.c (print_stack_unless_memory_error): Use
16347 gdbpy_err_fetch.
16348
16349 2019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
16350
16351 * linux-nat.c (delete_lwp_cleanup): Delete.
16352 (struct lwp_deleter): New struct.
16353 (lwp_info_up): New typedef.
16354 (linux_nat_target::follow_fork): Delete cleanup, and make use of
16355 lwp_info_up.
16356
16357 2019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
16358
16359 * linux-fork.c (class scoped_switch_fork_info): New class.
16360 (inferior_call_waitpid): Update to use scoped_switch_fork_info.
16361
16362 2019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
16363
16364 * valops.c (find_overload_match): Remove use of null_cleanup, and
16365 calls to do_cleanups.
16366
16367 2019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
16368
16369 * compile/compile-cplus-types.c
16370 (compile_cplus_instance::decl_name): Handle changes to
16371 cp_func_name.
16372 * cp-support.c (cp_func_name): Update header comment, update
16373 return type.
16374 * cp-support.h (cp_func_name): Update return type in declaration.
16375 * valops.c (find_overload_match): Move temp_func local to top
16376 level of function and change its type. Use temp_func to hold and
16377 delete temporary string obtained from cp_func_name.
16378
16379 2019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
16380
16381 * remote.c (remote_target::remote_check_symbols): Convert `msg` to
16382 gdb::char_vector, remove cleanup, and update uses of `msg`.
16383
16384 2019-01-03 Jim Wilson <jimw@sifive.com>
16385
16386 * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
16387
16388 2019-01-02 Tom Tromey <tom@tromey.com>
16389
16390 * xml-tdesc.c (xml_cache): Hold a target_desc_up.
16391 (tdesc_parse_xml): Remove cleanups.
16392 * target-descriptions.h (make_cleanup_free_target_description):
16393 Don't declare.
16394 (target_desc_deleter): New struct.
16395 (target_desc_up): New typedef.
16396 * target-descriptions.c (target_desc_deleter::operator()): Rename
16397 from free_target_description.
16398 (make_cleanup_free_target_description): Remove.
16399
16400 2019-01-02 Tom Tromey <tom@tromey.com>
16401
16402 * linespec.c (struct linespec_parser): Rename from ls_parser. Add
16403 constructor, destructor.
16404 (linespec_parser): Remove typedef.
16405 (~linespec_parser): Rename from linespec_parser_delete.
16406 (linespec_lex_to_end, linespec_complete_label)
16407 (linespec_complete): Update.
16408 (decode_line_full): Remove cleanups.
16409 (decode_line_1): Update.
16410
16411 2019-01-02 Tom Tromey <tom@tromey.com>
16412
16413 * python/python-internal.h (inferior_to_inferior_object): Change
16414 return type.
16415 * python/py-exitedevent.c (create_exited_event_object): Update.
16416 * python/py-inferior.c (inferior_to_inferior_object): Return
16417 gdbpy_ref.
16418 (python_new_inferior, python_inferior_deleted)
16419 (thread_to_thread_object, delete_thread_object)
16420 (build_inferior_list, gdbpy_selected_inferior): Update.
16421 * python/py-infthread.c (create_thread_object): Update. Also fail
16422 if inferior_to_inferior_object fails.
16423
16424 2019-01-02 Simon Marchi <simon.marchi@ericsson.com>
16425
16426 * inferior.h (class inferior) <displaced_step_state>: New field.
16427 * infrun.h (struct displaced_step_state): Move here from
16428 infrun.c. Initialize fields, add constructor.
16429 <inf>: Remove field.
16430 <reset>: New method.
16431 * infrun.c (struct displaced_step_inferior_state): Move to
16432 infrun.h.
16433 (displaced_step_inferior_states): Remove.
16434 (get_displaced_stepping_state): Adust.
16435 (displaced_step_in_progress_any_inferior): Adjust.
16436 (displaced_step_in_progress_thread): Adjust.
16437 (displaced_step_in_progress): Adjust.
16438 (add_displaced_stepping_state): Remove.
16439 (get_displaced_step_closure_by_addr): Adjust.
16440 (remove_displaced_stepping_state): Remove.
16441 (infrun_inferior_exit): Call displaced_step_state.reset.
16442 (use_displaced_stepping): Don't check for NULL.
16443 (displaced_step_prepare_throw): Call
16444 get_displaced_stepping_state.
16445 (displaced_step_fixup): Don't check for NULL.
16446 (prepare_for_detach): Don't check for NULL.
16447
16448 2019-01-02 Philippe Waroquiers <philippe.waroquiers@skynet.be>
16449
16450 * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
16451 in case of call that did not complete.
16452
16453 2019-01-02 Andrey Utkin <autkin@undo.io>
16454
16455 * symfile.c (find_separate_debug_file): Fix search of debug files for
16456 remote debuggee.
16457
16458 2019-01-02 Tom Tromey <tom@tromey.com>
16459
16460 * python/py-inferior.c (gdbpy_initialize_inferior): Fix
16461 indentation.
16462 * python/py-frame.c (frapy_older): Remove cast.
16463 (frapy_newer): Likewise.
16464 * python/py-breakpoint.c (local_setattro): Remove cast.
16465 * python/py-arch.c (archpy_name): Remove local variable.
16466 * python/py-type.c (gdbpy_lookup_type): Remove cast.
16467
16468 2019-01-02 Joel Brobecker <brobecker@adacore.com>
16469
16470 * unittests/basic_string_view/element_access/char/empty.cc:
16471 Fix year range in copyright header.
16472
16473 2019-01-01 Andrew Burgess <andrew.burgess@embecosm.com>
16474
16475 * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
16476 Delete.
16477 <operator==>: Update with for removed field.
16478 <hash>: Likewise.
16479 * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
16480 <isa_features>: ...this.
16481 <abi_features>: New field.
16482 (riscv_isa_flen): Update comment.
16483 (riscv_abi_xlen): New declaration.
16484 (riscv_abi_flen): New declaration.
16485 * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
16486 isa_features.
16487 (riscv_abi_xlen): New function.
16488 (riscv_isa_flen): Update to get answer from isa_features.
16489 (riscv_abi_flen): New function.
16490 (riscv_has_fp_abi): Update to get answer from abi_features.
16491 (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
16492 xlen and flen.
16493 (riscv_call_info) <xlen, flen>: Update comment.
16494 (riscv_call_arg_struct): Remove invalid assertions
16495 (riscv_features_from_gdbarch_info): Update now hw_float_abi field
16496 is removed.
16497 (riscv_gdbarch_init): Gather isa features and abi features
16498 separately, ensure both match on the gdbarch when reusing an old
16499 gdbarch. Relax an error check to allow 32-bit abi float to run on
16500 a target with 64-bit float hardware.
16501
16502 2019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
16503
16504 * source.c (search_command_helper): Stop reverse search
16505 when line 1 has been searched.
16506
16507 2019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
16508
16509 * record-full.c (record_full_base_target::close): Rewrite
16510 record_full_core_buf_list free logic.
16511
16512 2019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
16513
16514 * break-catch-syscall.c (print_one_catch_syscall): xfree
16515 the last text.
16516
16517 2019-01-01 Joel Brobecker <brobecker@adacore.com>
16518
16519 * top.c (print_gdb_version): Update Copyright year in version
16520 message.
16521
16522 2019-01-01 Joel Brobecker <brobecker@adacore.com>
16523
16524 Update copyright year range in all GDB files.
16525
16526 2019-01-01, 19 Joel Brobecker <brobecker@adacore.com>
16527
16528 * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
16529
16530 For older changes see ChangeLog-2018.
16531 \f
16532 Local Variables:
16533 mode: change-log
16534 left-margin: 8
16535 fill-column: 74
16536 version-control: never
16537 coding: utf-8
16538 End:
16539
This page took 0.352018 seconds and 5 git commands to generate.