gdb/ChangeLog

   1 2019-11-19  Ali Tamur <tamur@google.com>
   2
   3         * dwarf2read.c (dw2_get_file_names_reader): Replace "if (attr)" with
   4         "if (attr != nullptr)".
   5         (dwarf2_find_base_address): Likewise.
   6         (dwarf2_build_include_psymtabs): Likewise.
   7         (read_cutu_die_from_dwo): Likewise.
   8         (read_func_scope): Likewise.
   9         (read_call_site_scope): Likewise.
  10         (dwarf2_get_pc_bounds): Likewise.
  11         (dwarf2_record_block_ranges): Likewise.
  12         (dwarf2_add_field): Likewise.
  13         (dwarf2_add_member_fn): Likewise.
  14         (read_structure_type): Likewise.
  15         (read_enumeration_type): Likewise.
  16         (read_array_type): Likewise.
  17         (read_array_order): Likewise.
  18         (read_set_type): Likewise.
  19         (read_common_block): Likewise.
  20         (read_tag_reference_type): Likewise.
  21         (read_tag_string_type): Likewise.
  22         (read_subroutine_type): Likewise.
  23         (read_base_type): Likewise.
  24         (read_subrange_type): Likewise.
  25         (new_symbol): Likewise.
  26         (prepare_one_comp_unit): Likewise.
  27
  28 2019-11-19  Tom Tromey  <tromey@adacore.com>
  29
  30         * windows-nat.c (windows_nat_target::attach): Include GetLastError
  31         result in error when DebugActiveProcess fails.
  32
  33 2019-11-18  Sergio Durigan Junior  <sergiodj@redhat.com>
  34             Pedro Alves  <palves@redhat.com>
  35
  36         https://bugzilla.redhat.com/show_bug.cgi?id=1765117
  37         * target.c (target_stack::push): Call 'unpush' if there's a
  38         target on top of the stack.
  39
  40 2019-11-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
  41
  42         * python/py-block.c (blpy_dealloc): Call tp_free.
  43         (blpy_block_syms_dealloc): Likewise.
  44         * python/py-finishbreakpoint.c (bpfinishpy_dealloc): Likewise.
  45         * python/py-inferior.c (infpy_dealloc): Likewise.
  46         * python/py-lazy-string.c (stpy_dealloc): Likewise.
  47         * python/py-linetable.c (ltpy_iterator_dealloc): Likewise.
  48         * python/py-symbol.c (sympy_dealloc): Likewise.
  49         * python/py-symtab.c (stpy_dealloc): Likewise.
  50         * python/py-type.c (typy_iterator_dealloc): Likewise.
  51
  52 2019-11-18  Christian Biesinger  <cbiesinger@google.com>
  53
  54         * symtab.h (struct symbol) <owner>: Initialize explicitly in the
  55         constructor instead of using a class initializer.
  56
  57 2019-11-15  Christian Biesinger  <cbiesinger@google.com>
  58
  59         * Makefile.in: Replace {posix,mingw}-strerror.c with safe-strerror.c.
  60         * configure: Regenerate.
  61         * configure.ac: Don't source common.host.
  62         * gdbsupport/common.host: Remove.
  63         * gdbsupport/mingw-strerror.c: Remove.
  64         * gdbsupport/posix-strerror.c: Rename to...
  65         * gdbsupport/safe-strerror.c: ...this.
  66
  67 2019-11-15  Christian Biesinger  <cbiesinger@google.com>
  68
  69         * maint.c (scoped_command_stats::print_time): Use localtime_r
  70         instead of localtime (provided through gnulib if necessary).
  71         * nat/linux-osdata.c (time_from_time_t): Use ctime_r instead
  72         of ctime.
  73
  74 2019-11-15  Christian Biesinger  <cbiesinger@google.com>
  75
  76         * gdbsupport/common-defs.h: Include time.h before pathmax.h to
  77         avoid compile errors.
  78
  79 2019-11-15  Christian Biesinger  <cbiesinger@google.com>
  80
  81         * config.in: Regenerate.
  82         * configure: Regenerate.
  83         * gdbsupport/common.m4: No longer check for strerror_r.
  84         * gdbsupport/posix-strerror.c (safe_strerror): Always call the
  85         POSIX version of strerror_r, now that gnulib provides it if
  86         necessary.
  87
  88 2019-11-14  Christian Biesinger  <cbiesinger@google.com>
  89
  90         * README (`configure' options): Update.
  91
  92 2019-11-14  Tom Tromey  <tromey@adacore.com>
  93
  94         * eval.c (evaluate_subexp_standard) <BINOP_ASSIGN>: Do not pass an
  95         expected type for the RHS if the LHS is a convenience variable.
  96
  97 2019-11-14  Simon Marchi  <simon.marchi@polymtl.ca>
  98
  99         * unittests/vec-utils-selftests.c (unordered_remove_tests::obj):
 100         Provide explicit default and copy constructor.
 101
 102 2019-11-14  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 103
 104         * python/py-finishbreakpoint.c (gdbpy_breakpoint_created):
 105         only call Py_INCREF (newbp) in the bppy_pending_object case.
 106
 107 2019-11-13  Tom Tromey  <tromey@adacore.com>
 108
 109         PR build/25182:
 110         * psympriv.h (partial_symbol): Remove static assert.
 111         * symtab.h (general_symbol_info, symbol): Remove static assert.
 112
 113 2019-11-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 114
 115         * gdbsupport/format.c (format_pieces::format_pieces): Support
 116         printf 'z' size modifier.
 117         * gdbsupport/format.h (enum argclass): Add size_t_arg.
 118         * printcmd.c (ui_printf):  Handle size_t_arg.
 119         * ui-out.c (ui_out::vmessage): Likewise.
 120         * unittests/format_pieces-selftests.c (test_format_int_sizes): New
 121         function.
 122         (run_tests): Call test_format_int_sizes.
 123
 124 2019-11-12  Christian Biesinger  <cbiesinger@google.com>
 125
 126         * ada-exp.y (write_ambiguous_var): Update.
 127         * buildsym.c (add_symbol_to_list): Update.
 128         * dwarf2read.c (read_variable): Update.
 129         (new_symbol): Update.
 130         * jit.c (finalize_symtab): Update.
 131         * language.c (language_alloc_type_symbol): Update.
 132         * symtab.c (fixup_symbol_section): Update.
 133         (initialize_objfile_symbol_1): Move code to...
 134         (initialize_objfile_symbol): ...here. Remove now-unnecessary memset.
 135         (allocate_symbol): Update.
 136         (allocate_template_symbol): Update.
 137         (get_symbol_address): Update.
 138         * symtab.h (struct symbol): Inherit from general_symbol_info instead
 139         of having as a field, and add a constructor.
 140         (SYMBOL_VALUE): Update.
 141         (SYMBOL_VALUE_ADDRESS): Update.
 142         (SET_SYMBOL_VALUE_ADDRESS): Update.
 143         (SYMBOL_VALUE_BYTES): Update.
 144         (SYMBOL_VALUE_COMMON_BLOCK): Update.
 145         (SYMBOL_BLOCK_VALUE): Update.
 146         (SYMBOL_VALUE_CHAIN): Update.
 147         (SYMBOL_LANGUAGE): Update.
 148         (SYMBOL_SECTION): Update.
 149         (SYMBOL_OBJ_SECTION): Update.
 150         (SYMBOL_SET_LANGUAGE): Update.
 151         (SYMBOL_SET_LINKAGE_NAME): Update.
 152         (SYMBOL_SET_NAMES): Update.
 153         (SYMBOL_NATURAL_NAME): Update.
 154         (SYMBOL_LINKAGE_NAME): Update.
 155         (SYMBOL_DEMANGLED_NAME): Update.
 156         (SYMBOL_SEARCH_NAME): Update.
 157         (SYMBOL_MATCHES_SEARCH_NAME): Update.
 158         (struct symbol): Update.
 159         (struct template_symbol): Update.
 160         (struct rust_vtable_symbol): Update.
 161         * xcoffread.c (SYMBOL_DUP): Update.
 162
 163 2019-11-12  Tom Tromey  <tom@tromey.com>
 164
 165         * tui/tui-layout.c (show_layout): Set current_layout.
 166         (show_source_disasm_command, show_data)
 167         (show_source_or_disasm_and_command): Don't set current_layout.
 168
 169 2019-11-12  Tom Tromey  <tom@tromey.com>
 170
 171         * tui/tui-layout.c (_initialize_tui_layout): Move to end.
 172
 173 2019-11-12  Tom Tromey  <tom@tromey.com>
 174
 175         * tui/tui-win.c (resize_message): New global.
 176         (show_tui_resize_message): New function.
 177         (tui_async_resize_screen): Print message if requested.
 178         (_initialize_tui_win): Add tui-resize-message setting.
 179         * NEWS: Add entry for new commands.
 180
 181 2019-11-11  Tom Tromey  <tom@tromey.com>
 182
 183         * tui/tui.c (tui_initialize_readline): Add new bindable readline
 184         functions.
 185
 186 2019-11-11  Christian Biesinger  <cbiesinger@google.com>
 187
 188         * nat/linux-osdata.c (user_from_uid): Use getpwuid_r.
 189
 190 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
 191
 192         * python/py-symbol.c (gdbpy_lookup_static_symbols): New
 193         function.
 194         * python/python-internal.h (gdbpy_lookup_static_symbols):
 195         Declare new function.
 196         * python/python.c (python_GdbMethods): Add
 197         gdb.lookup_static_symbols method.
 198         * NEWS: Mention gdb.lookup_static_symbols.
 199
 200 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
 201
 202         * python/py-symbol.c (gdbpy_lookup_static_symbol): Lookup in
 203         static block of current object file first.  Also fix typo in
 204         header comment.
 205
 206 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
 207
 208         * stack.c (set_last_displayed_sal): Delete.
 209         (last_displayed_sal_valid): Delete.
 210         (last_displayed_pspace): Delete.
 211         (last_displayed_addr): Delete.
 212         (last_displayed_symtab): Delete.
 213         (last_displayed_line): Delete.
 214         (class last_displayed_symtab_info_type): New.
 215         (last_displayed_symtab_info): New static global variable.
 216         (print_frame_info): Call methods on last_displayed_symtab_info.
 217         (clear_last_displayed_sal): Update header comment, and make use of
 218         last_displayed_symtab_info.
 219         (last_displayed_sal_is_valid): Likewise.
 220         (get_last_displayed_pspace): Likewise.
 221         (get_last_displayed_addr): Likewise.
 222         (get_last_displayed_symtab): Likewise.
 223         (get_last_displayed_line): Likewise.
 224         (get_last_displayed_sal): Likewise.
 225         * stack.h (clear_last_displayed_sal): Update header comment.
 226         (last_displayed_sal_is_valid): Likewise.
 227         (get_last_displayed_pspace): Likewise.
 228         (get_last_displayed_addr): Likewise.
 229         (get_last_displayed_symtab): Likewise.
 230         (get_last_displayed_line): Likewise.
 231         (get_last_displayed_sal): Likewise.
 232
 233 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
 234
 235         * stack.c (frame_show_address): Convert return type to bool.
 236         * stack.h (frame_show_address): Likewise, and update header
 237         comment.
 238
 239 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
 240
 241         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add new file to the list.
 242         * unittests/vec-utils-selftests.c: New file.
 243         * gdbsupport/gdb_vecs.h (unordered_remove): Avoid self move assign.
 244
 245 2019-11-10  Tom Tromey  <tom@tromey.com>
 246
 247         * tui/tui-wingeneral.c (tui_unhighlight_win): Use can_box.
 248         (tui_highlight_win): Likewise.
 249         (tui_win_info::check_and_display_highlight_if_needed): Likewise.
 250         * tui/tui-data.h (struct tui_win_info) <can_highlight>: Remove.
 251         * tui/tui-command.h (struct tui_cmd_window) <tui_cmd_window>:
 252         Don't set can_highlight.
 253
 254 2019-11-10  Tom Tromey  <tom@tromey.com>
 255
 256         * cli/cli-style.h (class cli_style_option) <cli_style_option>:
 257         Remove unused declaration.
 258
 259 2019-11-08  Tom Tromey  <tromey@adacore.com>
 260
 261         * top.c (read_command_file): Update.
 262         (command_line_input): Make return type const.
 263         * python/py-gdb-readline.c: Update.
 264         * linespec.c (decode_line_2): Update.
 265         * defs.h (command_line_input): Make return type const.
 266         * cli/cli-script.c (read_next_line): Make return type const.
 267         * ada-lang.c (get_selections): Update.
 268
 269 2019-11-06  Christian Biesinger  <cbiesinger@google.com>
 270
 271         * linux-tdep.c (linux_info_proc): Use strtok_r instead of strtok.
 272         * mi/mi-main.c (output_cores): Likewise.
 273         * nat/linux-osdata.c (linux_xfer_osdata_cpus): Likewise.
 274         (linux_xfer_osdata_modules): Likewise.
 275         * remote.c (register_remote_support_xml): Likewise.
 276         * sparc64-tdep.c (adi_is_addr_mapped): Likewise.
 277         * xml-syscall.c (syscall_create_syscall_desc): Likewise.
 278
 279 2019-11-06  Tom Tromey  <tom@tromey.com>
 280
 281         * tui/tui-interp.c: Don't include readline.h.
 282         * tui/tui-hooks.c: Don't include readline.h.
 283         * symmisc.c: Include tilde.h, not readline.h.
 284         * symfile.c: Include tilde.h, not readline.h.
 285         * source.c: Include tilde.h, not readline.h.
 286         * solib.c: Include tilde.h, not readline.h.
 287         * psymtab.c: Include tilde.h, not readline.h.
 288         * exec.c: Include tilde.h, not readline.h.
 289         * corelow.c: Include tilde.h, not readline.h.
 290         * cli/cli-dump.c: Include tilde.h, not readline.h.
 291         * cli/cli-cmds.c: Don't include readline.h.
 292
 293 2019-11-05  Tom Tromey  <tom@tromey.com>
 294
 295         * tui/tui-disasm.c (struct tui_asm_line) <addr_size>: New member.
 296         (tui_disassemble): Set addr_size.
 297         (tui_disasm_window::set_contents): Use addr_size.
 298
 299 2019-11-05  Tom Tromey  <tom@tromey.com>
 300
 301         * rust-lang.c (rust_language_defn): Update.
 302         * python/py-value.c (valpy_string): Call c_get_string.
 303         * p-lang.c (pascal_language_defn): Update.
 304         * opencl-lang.c (opencl_language_defn): Update.
 305         * objc-lang.c (objc_language_defn): Update.
 306         * m2-lang.c (m2_language_defn): Update.
 307         * language.c (unknown_language_defn, auto_language_defn): Update.
 308         (default_get_string): Remove.
 309         * guile/scm-value.c (gdbscm_value_to_string): Use c_get_string.
 310         * go-lang.c (go_language_defn): Update.
 311         * f-lang.c (f_language_defn): Update.
 312         * d-lang.c (d_language_defn): Update.
 313         * c-lang.c (c_language_defn, cplus_language_defn)
 314         (asm_language_defn, minimal_language_defn): Update.
 315         * ada-lang.c (ada_language_defn): Update.
 316         * language.h (struct language_defn) <la_get_string>: Remove.
 317         (LA_GET_STRING): Remove.
 318         (default_get_string): Don't declare.
 319
 320 2019-11-05  Tom Tromey  <tom@tromey.com>
 321
 322         * tui/tui-source.h (struct tui_source_window): Inline
 323         constructor.  Remove destructor.
 324         <style_changed, m_observable>: Move to superclass.
 325         * tui/tui-winsource.h (tui_copy_source_line): Declare.
 326         (struct tui_source_window_base): Move private members to end.
 327         <style_changed, m_observable>: Move from tui_source_window.
 328         * tui/tui-winsource.c (tui_copy_source_line): Move from
 329         tui-source.c.  Rename from copy_source_line.  Add special handling
 330         for negative line number.
 331         (tui_source_window_base::style_changed): Move from
 332         tui_source_window.
 333         (tui_source_window_base): Register observer.
 334         (~tui_source_window_base): New.
 335         * tui/tui-source.c (copy_source_line): Move to tui-winsource.c;
 336         rename.
 337         (tui_source_window::set_contents): Use tui_copy_source_line.
 338         (tui_source_window::tui_source_window): Move to tui-source.h.
 339         (tui_source_window::~tui_source_window): Remove.
 340         (tui_source_window::style_changed): Move to superclass.
 341         * tui/tui-disasm.c (tui_disassemble): Create string file with
 342         styling, when possible.  Add "addr_size" parameter.
 343         (tui_disasm_window::set_contents): Use tui_copy_source_line.
 344         Don't compute maximum size.
 345         (len_without_escapes): New function
 346
 347 2019-11-05  Tom Tromey  <tom@tromey.com>
 348
 349         * tui/tui-winsource.h (struct tui_source_element) <line>: Now a
 350         std::string.
 351         * tui/tui-winsource.c (tui_show_source_line): Update.
 352         * tui/tui-source.c (tui_source_window::set_contents): Update.
 353         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
 354
 355 2019-11-05  Christian Biesinger  <cbiesinger@google.com>
 356
 357         * symtab.h (gdb_static_assert): Put && operator at the beginning
 358         of the line instead of the end.
 359
 360 2019-11-04  Christian Biesinger  <cbiesinger@google.com>
 361
 362         * psympriv.h: Add static_asserts for sizeof (general_symbol_info)
 363         and sizeof (symbol).
 364         * symtab.h: Add a static_assert for sizeof (partial_symbol).
 365
 366 2019-11-04  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
 367
 368         * NEWS (Changes since GDB 8.3): Document Solaris 10 removal.
 369         * configure.host: Mark *-*-solaris2.10* obsolete.
 370         * configure.tgt: Mark Solaris < 11 obsolete.
 371         * MAINTAINERS (Target Instruction Set Architectures) <sparc>:
 372         Update target triplet.
 373
 374 2019-11-01  Tom Tromey  <tromey@adacore.com>
 375
 376         * utils.c (print_sys_errmsg): Simplify.
 377
 378 2019-11-01  Tom Tromey  <tromey@adacore.com>
 379
 380         * gdbsupport/mingw-strerror.c (safe_strerror): Constify result.
 381
 382 2019-11-01  Christian Biesinger  <cbiesinger@google.com>
 383
 384         * configure: Regenerate.
 385         * configure.ac: Remove check for strerror_r.
 386         * gdbsupport/common.m4: Check for strerror_r.
 387
 388 2019-11-01  Luis Machado  <luis.machado@linaro.org>
 389
 390         PR gdb/25124
 391
 392         * arm-tdep.c (arm_per_objfile): Rename to ...
 393         (arm_per_bfd): ... this.
 394         (arm_objfile_data_key): Rename to ...
 395         (arm_bfd_data_key): ... this.
 396         (arm_find_mapping_symbol): Adjust access to new bfd_key-based
 397         data.
 398         (arm_record_special_symbol): Likewise.
 399
 400 2019-10-31  Andrew Burgess  <andrew.burgess@embecosm.com>
 401
 402         * ada-typeprint.c (ada_print_typedef): Don't print newline at the
 403         end.
 404         * c-typeprint.c (c_print_typedef): Likewise.
 405         * f-typeprint.c (f_print_typedef): Likewise.
 406         * m2-typeprint.c (m2_print_typedef): Likewise.
 407         * p-typeprint.c (pascal_print_typedef): Likewise.
 408         * rust-lang.c (rust_print_typedef): Likewise.
 409         * symtab.c (print_symbol_info): Print a newline after calling
 410         typedef_print.
 411
 412 2019-10-31  Andrew Burgess  <andrew.burgess@embecosm.com>
 413
 414         * symtab.c (info_module_cmdlist): New variable.
 415         (info_module_command): New function.
 416         (search_module_symbols): New function.
 417         (info_module_subcommand): New function.
 418         (struct info_modules_var_func_options): New struct.
 419         (info_modules_var_func_options_defs): New variable.
 420         (make_info_modules_var_func_options_def_group): New function.
 421         (info_module_functions_command): New function.
 422         (info_module_variables_command): New function.
 423         (info_module_var_func_command_completer): New function.
 424         (_initialize_symtab): Register new 'info module functions' and
 425         'info module variables' commands.
 426         * symtab.h (typedef symbol_search_in_module): New typedef.
 427         (search_module_symbols): Declare new function.
 428         * NEWS: Mention new commands.
 429
 430 2019-10-31  Andrew Burgess  <andrew.burgess@embecosm.com>
 431
 432         * dwarf2read.c (dw2_symtab_iter_next): Handle MODULE_DOMAIN.
 433         (dw2_expand_marked_cus): Handle MODULES_DOMAIN.
 434         (dw2_debug_names_iterator::next): Handle MODULE_DOMAIN and
 435         MODULES_DOMAIN.
 436         (scan_partial_symbols): Only create partial module symbols for non
 437         declarations.
 438         * psymtab.c (recursively_search_psymtabs): Handle MODULE_DOMAIN
 439         and MODULES_DOMAIN.
 440         * symtab.c (search_domain_name): Likewise.
 441         (search_symbols): Likewise.
 442         (print_symbol_info): Likewise.
 443         (symtab_symbol_info): Likewise.
 444         (info_modules_command): New function.
 445         (_initialize_symtab): Register 'info modules' command.
 446         * symtab.h (enum search_domain): Add MODULES_DOMAIN.
 447         * NEWS: Mention new 'info modules' command.
 448
 449 2019-10-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 450
 451         * NEWS: Mention $_gdb_setting, $_gdb_setting_str, $_gdb_maint_setting
 452         and $_gdb_maint_setting_str.
 453
 454 2019-10-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 455
 456         * cli/cli-cmds.c (setting_cmd, value_from_setting)
 457         (gdb_setting_internal_fn, gdb_maint_setting_internal_fn)
 458         (str_value_from_setting, gdb_setting_str_internal_fn)
 459         (gdb_maint_setting_str_internal_fn): New functions.
 460         (_initialize_cli_cmds): Define the new convenience functions.
 461         * gdb/cli/cli-setshow.h (get_setshow_command_value_string): Constify.
 462         * gdb/cli/cli-setshow.c (get_setshow_command_value_string): Constify.
 463
 464 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
 465
 466         * agent.c (set_can_use_agent): When the setting is turned on,
 467         look up agent symbols if we don't have them yet.
 468         (agent_new_objfile): Don't look up agent symbols when the agent
 469         setting is off.
 470
 471 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
 472
 473         * config.in: Regenerate.
 474
 475 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
 476
 477         * configure: Regenerate.
 478         * configure.ac: Check for strerror_r.
 479         * gdbsupport/common-utils.h (safe_strerror): Change return value
 480         to const char * and document that this function is now threadsafe.
 481         * gdbsupport/posix-strerror.c (safe_strerror): Make buf
 482         thread_local and call strerror_r, if available.
 483         * utils.c (perror_string): Update.
 484         (print_sys_errmsg): Update.
 485
 486 2019-10-31  Luis Machado  <luis.machado@linaro.org>
 487
 488         * arm-tdep.c (arm_exidx_data_key): Use bfd_key instead of
 489         objfile_key.
 490         (arm_exidx_new_objfile): Adjust to use objfile->obfd instead of
 491         objfile to fetch per-bfd data.
 492         (arm_find_exidx_entry): Likewise.
 493
 494 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
 495
 496         * gdbsupport/agent.c (debug_agent): Change type to bool.
 497         (use_agent): Likewise.
 498         (all_agent_symbols_look_up): Likewise.
 499         (agent_loaded_p): Change return value to bool.
 500         (agent_look_up_symbols): Update.
 501         (agent_capability_check): Change return value to bool.
 502         * gdbsupport/agent.h (agent_loaded_p): Likewise.
 503         (debug_agent): Change type to bool.
 504         (use_agent): Likewise.
 505         (agent_capability_check): Change return value to bool.
 506
 507 2019-10-30  Christian Biesinger  <cbiesinger@google.com>
 508
 509         * minsyms.c (clear_minimal_symbol_hash_tables): New function.
 510         (build_minimal_symbol_hash_tables): Code to clear the table moved
 511         to clear_minimal_symbol_hash_tables.
 512         (minimal_symbol_reader::install): Call clear_minimal_symbol_hash_tables
 513         when needed.
 514
 515 2019-10-29  Simon Marchi  <simon.marchi@polymtl.ca>
 516
 517         * infcmd.c: Remove includes.
 518         * infrun.c: Remove includes.
 519
 520 2019-10-29  Simon Marchi  <simon.marchi@polymtl.ca>
 521
 522         * ada-lang.h (GROW_VECT): Move to ada-lang.c.
 523         (grow_vect): Remove declaration.
 524         (ada_type_of_array): Remove declaration.
 525         (ada_update_initial_language): Remove declaration.
 526         (ada_fold_name): Remove declaration.
 527         (ada_fill_in_ada_prototype): Remove declaration.
 528         (user_select_syms): Remove declaration.
 529         (get_selections): Remove declaration.
 530         (ada_tag_type): Remove declaration.
 531         (ada_value_tag): Remove declaration.
 532         (ada_is_others_clause): Remove declaration.
 533         (ada_in_variant): Remove declaration.
 534         (ada_value_struct_elt): Remove declaration.
 535         (ada_attribute_name): Remove declaration.
 536         (ada_system_address_type): Remove declaration.
 537         * ada-lang.c (ada_watch_location_expression): Make static.
 538         (GROW_VECT): Move here from ada-lang.h.
 539         (grow_vect): Make static.
 540         (ada_update_initial_language): Make static.
 541         (ada_fold_name): Make static.
 542         (ada_type_of_array): Make static.
 543         (encoded_ordered_before): Move up.
 544         (sort_choices): Move up.
 545         (print_signatures): Move up.
 546         (ada_print_symbol_signature): Move up.
 547         (get_selections): Move up and make static.
 548         (user_select_syms): Move up and make static.
 549         (ada_value_struct_elt): Move up and make static.
 550         (ada_tag_type): Make static.
 551         (ada_value_tag): Make static.
 552         (ada_is_others_clause): Make static.
 553         (ada_in_variant): Make static.
 554         (ada_attribute_name): Make static.
 555
 556 2019-10-29  Simon Marchi  <simon.marchi@polymtl.ca>
 557
 558         * ada-lang.c: Remove includes.
 559         * ada-typeprint.c: Remove includes.
 560         * ada-valprint.c: Remove includes.
 561
 562 2019-10-29  Simon Marchi  <simon.marchi@efficios.com>
 563
 564         * addrmap.c: Add static assertions of type size, moved from
 565         _initialize_addrmap.
 566         (_initialize_addrmap): Remove.
 567
 568 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
 569
 570         * coffread.c (record_minimal_symbol): Update.
 571         (process_coff_symbol): Update.
 572         * dbxread.c (read_dbx_symtab): Update.
 573         * dwarf2read.c (add_partial_symbol): Update.
 574         (fixup_go_packaging): Update.
 575         (load_partial_dies): Update.
 576         (new_symbol): Update.
 577         * elfread.c (record_minimal_symbol): Change signature to use
 578         gdb::string_view instead of name+len.
 579         (elf_symtab_read): Update.
 580         (elf_rel_plt_read): Update.
 581         * mdebugread.c (parse_partial_symbols): Update.
 582         (handle_psymbol_enumerators): Update.
 583         (new_symbol): Update.
 584         * minsyms.c (minimal_symbol_reader::record_full): Change signature
 585         to use gdb::string_view instead of name+len.
 586         * minsyms.h (class minimal_symbol_reader) <record_full>: Likewise.
 587         * psympriv.h (add_psymbol_to_list): Likewise.
 588         * psymtab.c (add_psymbol_to_bcache): Likewise.
 589         (add_psymbol_to_list): Likewise.
 590         * stabsread.c (define_symbol): Update.
 591         * symtab.c (symbol_set_names): Change signature to use gdb::string_view.
 592         * symtab.h (SYMBOL_SET_NAMES): Likewise.
 593         (symbol_set_names): Likewise.
 594         * xcoffread.c (scan_xcoff_symtab): Update.
 595
 596 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
 597
 598         * symtab.h (symbol_set_names): Document that copy_name must be
 599         set to true for non-nullterminated strings.
 600         * symtab.c (symbol_set_names): Only make a nullterminated copy of
 601         linkage_name if the entry was not found and we need to demangle.
 602
 603 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
 604
 605         * Makefile.in (HFILES_NO_SRCDIR): Add gdb_binary_search.h.
 606         * dwarf2-frame.c (bsearch_fde_cmp): Update.
 607         (dwarf2_frame_find_fde): Replace bsearch with gdb::binary_search.
 608         * gdbsupport/gdb_binary_search.h: New file.
 609
 610 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
 611
 612         * NEWS: Mention new --with-system-gdbinit-dir option.
 613         * config.in: Regenerate.
 614         * configure: Regenerate.
 615         * configure.ac: Add new option --with-system-gdbinit-dir.
 616         * extension.c (get_ext_lang_of_file): Return extension_language_gdb
 617         for a ".gdb" suffix.
 618         * main.c (get_init_files): Change system_gdbinit argument to
 619         a vector and return the files in SYSTEM_GDBINIT_DIR in
 620         addition to SYSTEM_GDBINIT.
 621         (captured_main_1): Update.
 622         (print_gdb_help): Update.
 623         * top.c (print_gdb_configuration): Also print the value of
 624         SYSTEM_GDBINIT_DIR.
 625
 626 2019-10-28  Christian Biesinger  <cbiesinger@google.com>
 627
 628         * gdbsupport/common-utils.h (startswith): Add an overloaded version
 629         that takes gdb::string_view arguments.
 630
 631 2019-10-26  Tom de Vries  <tdevries@suse.de>
 632
 633         * aarch64-linux-tdep.c: Fix typos in comments.
 634         * aarch64-tdep.c: Same.
 635         * ada-lang.c: Same.
 636         * amd64-nat.c: Same.
 637         * arc-tdep.c: Same.
 638         * arch/aarch64-insn.c: Same.
 639         * block.c: Same.
 640         * breakpoint.h: Same.
 641         * btrace.h: Same.
 642         * c-varobj.c: Same.
 643         * cli/cli-decode.c: Same.
 644         * cli/cli-script.c: Same.
 645         * cli/cli-utils.h: Same.
 646         * coff-pe-read.c: Same.
 647         * coffread.c: Same.
 648         * compile/compile-cplus-symbols.c: Same.
 649         * compile/compile-object-run.c: Same.
 650         * completer.c: Same.
 651         * corelow.c: Same.
 652         * cp-support.c: Same.
 653         * demangle.c: Same.
 654         * dwarf-index-write.c: Same.
 655         * dwarf2-frame.c: Same.
 656         * dwarf2-frame.h: Same.
 657         * eval.c: Same.
 658         * frame-base.h: Same.
 659         * frame.h: Same.
 660         * gdbcmd.h: Same.
 661         * gdbtypes.h: Same.
 662         * gnu-nat.c: Same.
 663         * guile/scm-objfile.c: Same.
 664         * i386-tdep.c: Same.
 665         * i386-tdep.h: Same.
 666         * infcall.c: Same.
 667         * infcall.h: Same.
 668         * linux-nat.c: Same.
 669         * m68k-tdep.c: Same.
 670         * macroexp.c: Same.
 671         * memattr.c: Same.
 672         * mi/mi-cmd-disas.c: Same.
 673         * mi/mi-getopt.h: Same.
 674         * mi/mi-main.c: Same.
 675         * minsyms.c: Same.
 676         * nat/aarch64-sve-linux-sigcontext.h: Same.
 677         * objfiles.h: Same.
 678         * ppc-linux-nat.c: Same.
 679         * ppc-linux-tdep.c: Same.
 680         * ppc-tdep.h: Same.
 681         * progspace.h: Same.
 682         * prologue-value.h: Same.
 683         * python/py-evtregistry.c: Same.
 684         * python/py-instruction.h: Same.
 685         * record-btrace.c: Same.
 686         * record-full.c: Same.
 687         * remote.c: Same.
 688         * rs6000-tdep.c: Same.
 689         * ser-tcp.c: Same.
 690         * sol-thread.c: Same.
 691         * sparc-sol2-tdep.c: Same.
 692         * sparc64-tdep.c: Same.
 693         * stabsread.c: Same.
 694         * symfile.c: Same.
 695         * symtab.h: Same.
 696         * target.c: Same.
 697         * tracepoint.c: Same.
 698         * tui/tui-data.h: Same.
 699         * tui/tui-io.c: Same.
 700         * tui/tui-win.c: Same.
 701         * tui/tui.c: Same.
 702         * unittests/rsp-low-selftests.c: Same.
 703         * user-regs.h: Same.
 704         * utils.c: Same.
 705         * utils.h: Same.
 706         * valarith.c: Same.
 707         * valops.c: Same.
 708         * valprint.c: Same.
 709         * valprint.h: Same.
 710         * value.c: Same.
 711         * value.h: Same.
 712         * varobj.c: Same.
 713         * x86-nat.h: Same.
 714         * xtensa-tdep.c: Same.
 715
 716 2019-10-25  Ali Tamur <tamur@google.com>
 717
 718         * charset.c (find_charset_names): Reflect API change.
 719
 720 2019-10-25  Christian Biesinger  <cbiesinger@google.com>
 721
 722         * symtab.c (struct demangled_name_entry): Change demangled name
 723         to a unique_xmalloc_ptr<char>, now that we don't allocate it as
 724         part of the struct anymore.
 725         (symbol_set_names): No longer obstack allocate + copy the demangled
 726         name, just store the allocated name from bfd.
 727
 728 2019-10-25  Tom Tromey  <tromey@adacore.com>
 729
 730         * dwarf2-frame.c (dwarf2_cie_table): Now a typedef.
 731         (bsearch_cie_cmp, add_cie): Remove.
 732         (find_cie): Reimplement.
 733         (decode_frame_entry_1, decode_frame_entry): Change type.  Update.
 734         (dwarf2_build_frame_info): Update.
 735
 736 2019-10-24  H.J. Lu  <hongjiu.lu@intel.com>
 737
 738         PR gdb/25126
 739         * symfile.c (reread_symbols): Call forget_cached_source_info to
 740         clear the stale source cache.
 741
 742 2019-10-24  Christian Biesinger  <cbiesinger@google.com>
 743
 744         * configure: Regenerate.
 745         * configure.ac: Remove code that sets python_has_threads.
 746
 747 2019-10-24  Christian Biesinger  <cbiesinger@google.com>
 748
 749         * config.in: Regenerate.
 750         * configure: Regenerate.
 751         * configure.ac: Remove the code that uses sed to get the python
 752         version and defines HAVE_LIBPYTHON2_6 / HAVE_LIBPYTHON2_7.
 753
 754 2019-10-24  Andrew Burgess  <andrew.burgess@embecosm.com>
 755
 756         * python/py-progspace.c (pspy_block_for_pc): Return None for all
 757         error paths.
 758
 759 2019-10-23  Tom Tromey  <tom@tromey.com>
 760
 761         * arc-tdep.c: Remove ".." from include.
 762         * frv-tdep.c: Remove ".." from include.
 763         * lm32-tdep.c: Remove ".." from include.
 764         * microblaze-tdep.c: Remove ".." from include.
 765         * or1k-tdep.h: Remove ".." from include.
 766         * s12z-tdep.c: Remove ".." from include.
 767         * Makefile.in (OPCODES_CFLAGS): Add comment.
 768         (TOP_CFLAGS): New variable.
 769         (INTERNAL_CFLAGS_BASE): Add TOP_CFLAGS.
 770
 771 2019-10-23  Tom Tromey  <tom@tromey.com>
 772
 773         * Makefile.in (READLINE_DIR): Update.
 774
 775 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 776
 777         * infcall.c (call_function_by_hand_dummy): Fix the function
 778         comment.  And extract out a code section into...
 779         (reserve_stack_space): ...this new function.
 780
 781 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 782
 783         * infcall.c (value_arg_coerce): Remove an unused parameter.
 784         (call_function_by_hand_dummy): Update the call to
 785         'value_arg_coerce'.
 786
 787 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 788
 789         * infcall.c (call_function_by_hand_dummy): Refactor.
 790
 791 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 792
 793         * MAINTAINERS (Write After Approval): Add Tankut Baris Aktemur.
 794
 795 2019-10-23  Tom Tromey  <tom@tromey.com>
 796
 797         * configure: Rebuild.
 798         * configure.ac: Don't check for sigprocmask.
 799         * gdbsupport/common.m4 (GDB_AC_COMMON): Check for sigprocmask.
 800
 801 2019-10-23  Tom Tromey  <tom@tromey.com>
 802
 803         * configure: Rebuild.
 804         * acinclude.m4: Use m4_include, not sinclude.
 805
 806 2019-10-23  Tom de Vries  <tdevries@suse.de>
 807
 808         PR breakpoints/24687
 809         * symtab.c (iterate_over_some_symtabs): Apply gdb_realpath on fullname.
 810
 811 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
 812
 813         * symtab.c (struct demangled_name_entry) <language>: Change from
 814         bitfield to regular variable.
 815
 816 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
 817
 818         * symtab.c (struct demangled_name_entry): Add a constructor.
 819         (free_demangled_name_entry): New function to call the destructor
 820         for demangled_name_entry.
 821         (create_demangled_names_hash): Pass free_demangled_name_entry to
 822         htab_create_alloc.
 823         (symbol_set_names): Call placement new for demangled_name_entry.
 824         * utils.c: No longer include xxhash.h here, now that fast_hash
 825         is inlined in the header.
 826         * utils.h: Instead, include it here.
 827
 828 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
 829
 830         * Makefile.in: Link with libxxhash.
 831         * config.in: Regenerate.
 832         * configure: Regenerate.
 833         * configure.ac: Search for libxxhash.
 834         * utils.c (fast_hash): Use xxhash if present.
 835
 836 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
 837
 838         * utils.h (fast_hash): New function.
 839         * symtab.c (hash_demangled_name_entry): Call new function
 840         fast_hash.
 841
 842 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
 843
 844         * symtab.c (struct demangled_name_entry): Change type of mangled
 845         to gdb::string_view. Also adds a constructor that takes the
 846         mangled name.
 847         (hash_demangled_name_entry): Update.
 848         (eq_demangled_name_entry): Update.
 849         (free_demangled_name_entry): New function to call the destructor
 850         now that this is not a POD anymore.
 851         (create_demangled_names_hash): Pass free_demangled_name_entry to
 852         htab_create_alloc.
 853         (symbol_set_names): Update.
 854
 855 2019-10-21  Ali Tamur  <tamu@google.com>
 856
 857         * dwarf2read.c (dir_index): Change type.
 858         (file_name_index): Likewise.
 859         (line_header::include_dir_at): Change comment and implementation on
 860         whether it is DWARF 5.
 861         (line_header::is_valid_file_index): New function.
 862         (line_header::file_name_at): Change comment and implementation on
 863         whether it is DWARF 5.
 864         (line_header::file_names): Change to private field renamed as
 865         m_file_names and introduce a new accessor method.
 866         (line_header::file_names_size): New method.
 867         (line_header::include_dirs): Change to private field and rename as
 868         m_include_dirs.
 869         (dw2_get_file_names_reader): Define local var at a smaller scope and
 870         reflect API change.
 871         (dwarf2_cu::setup_type_unit_groups): Reflect API change.
 872         (process_structure_scope): Likewise.
 873         (line_header::add_include_dir): Change message and reflect renaming.
 874         (line_header::add_file_name): Likewise.
 875         (read_formatted_entries): Handle DW_FORM_data16.
 876         (dwarf_decode_line_header): Fix line header length calculation.
 877         (psymtab_include_file_name): Change comment and API.
 878         (lnp_state_machine::m_file): Update comment and reflect type change.
 879         (lnp_state_machine::record_line): Reflect type change.
 880         (dwarf_decode_lines): Reflect API change.
 881         (file_file_name): Likewise.
 882         (file_full_name): Likewise.
 883
 884 2019-10-21  Andrew Burgess  <andrew.burgess@embecosm.com>
 885
 886         * objfiles.c (sort_cmp): Ensure that !(a < a) holds true.
 887
 888 2019-10-21  Tom Tromey  <tom@tromey.com>
 889
 890         * tui/tui-winsource.h (tui_exec_info_content): Remove typedef.
 891
 892 2019-10-21  Tom Tromey  <tom@tromey.com>
 893
 894         * configure.ac (nm.h): Conditionally create nm.h link.  Subst
 895         NM_H.   Use AC_CONFIG_LINKS.
 896         * configure: Rebuild.
 897         * Makefile.in (NM_H): New variable.
 898         (generated_files): Add NM_H.  Remove gcore.
 899         (nm.h, stamp-nmh): New targets.
 900
 901 2019-10-20  Tom Tromey  <tom@tromey.com>
 902
 903         * objfiles.h (unlink_objfile, put_objfile_before): Don't declare.
 904         * objfiles.c (unlink_objfile): Move earlier.  Now static.  Remove
 905         obsolete comment.
 906         (put_objfile_before): Now static.
 907
 908 2019-10-19  Simon Marchi  <simon.marchi@polymtl.ca>
 909
 910         * gdbsupport/common-utils.h (startswith): Change return type to
 911         bool.
 912
 913 2019-10-19  Christian Biesinger  <cbiesinger@google.com>
 914
 915         * bcache.c (bcache::print_statistics): Use std::sort instead of qsort.
 916         * breakpoint.c (bp_locations_compare): Rename to...
 917         (bp_location_is_less_than): ...this, and change to std::sort semantics.
 918         (update_global_location_list): Use std::sort instead of qsort.
 919         * buildsym.c (compare_line_numbers): Rename to...
 920         (lte_is_less_than): ...this, and change to std::sort semantics.
 921         (buildsym_compunit::end_symtab_with_blockvector): Use std::sort
 922         instead of qsort.
 923         * disasm.c (compare_lines): Rename to...
 924         (line_is_less_than): ...this, and change to std::sort semantics.
 925         (do_mixed_source_and_assembly_deprecated): Call std::sort instead
 926         of qsort.
 927         * dwarf2-frame.c (qsort_fde_cmp): Rename to...
 928         (fde_is_less_than): ...this, and change to std::sort semantics.
 929         (dwarf2_build_frame_info): Call std::sort instead of qsort.
 930         * mdebugread.c (compare_blocks):
 931         (block_is_less_than): ...this, and change to std::sort semantics.
 932         (sort_blocks): Call std::sort instead of qsort.
 933         * objfiles.c (qsort_cmp): Rename to...
 934         (sort_cmp): ...this, and change to std::sort semantics.
 935         (update_section_map): Call std::sort instead of qsort.
 936         * remote.c (compare_pnums): Remove.
 937         (map_regcache_remote_table): Call std::sort instead of qsort.
 938         * utils.c (compare_positive_ints): Remove.
 939         * utils.h (compare_positive_ints): Remove.
 940         * xcoffread.c (compare_lte): Remove.
 941         (arrange_linetable): Call std::sort instead of qsort.
 942
 943 2019-10-19  Sergio Durigan Junior  <sergiodj@redhat.com>
 944
 945         * symfile.c (init_entry_point_info): Fix typo.
 946         * i386-darwin-tdep.c (darwin_dwarf_signal_frame_p): Fix typo.
 947
 948 2019-10-18  Tom de Vries  <tdevries@suse.de>
 949
 950         * aarch64-tdep.c: Fix typos in comments.
 951         * ada-lang.c: Same.
 952         * ada-tasks.c: Same.
 953         * alpha-tdep.c: Same.
 954         * alpha-tdep.h: Same.
 955         * amd64-nat.c: Same.
 956         * amd64-windows-tdep.c: Same.
 957         * arc-tdep.c: Same.
 958         * arc-tdep.h: Same.
 959         * arch-utils.c: Same.
 960         * arm-nbsd-tdep.c: Same.
 961         * arm-tdep.c: Same.
 962         * ax-gdb.c: Same.
 963         * blockframe.c: Same.
 964         * btrace.c: Same.
 965         * c-varobj.c: Same.
 966         * coff-pe-read.c: Same.
 967         * coffread.c: Same.
 968         * cris-tdep.c: Same.
 969         * darwin-nat.c: Same.
 970         * dbxread.c: Same.
 971         * dcache.c: Same.
 972         * disasm.c: Same.
 973         * dtrace-probe.c: Same.
 974         * dwarf-index-write.c: Same.
 975         * dwarf2-frame-tailcall.c: Same.
 976         * dwarf2-frame.c: Same.
 977         * dwarf2read.c: Same.
 978         * eval.c: Same.
 979         * exceptions.c: Same.
 980         * fbsd-tdep.c: Same.
 981         * findvar.c: Same.
 982         * frame.c: Same.
 983         * frv-tdep.c: Same.
 984         * gnu-v3-abi.c: Same.
 985         * go32-nat.c: Same.
 986         * h8300-tdep.c: Same.
 987         * hppa-tdep.c: Same.
 988         * i386-linux-tdep.c: Same.
 989         * i386-tdep.c: Same.
 990         * ia64-libunwind-tdep.c: Same.
 991         * ia64-tdep.c: Same.
 992         * infcmd.c: Same.
 993         * infrun.c: Same.
 994         * linespec.c: Same.
 995         * linux-nat.c: Same.
 996         * linux-thread-db.c: Same.
 997         * machoread.c: Same.
 998         * mdebugread.c: Same.
 999         * mep-tdep.c: Same.
1000         * mn10300-tdep.c: Same.
1001         * namespace.c: Same.
1002         * objfiles.c: Same.
1003         * opencl-lang.c: Same.
1004         * or1k-tdep.c: Same.
1005         * osabi.c: Same.
1006         * ppc-linux-nat.c: Same.
1007         * ppc-linux-tdep.c: Same.
1008         * ppc-sysv-tdep.c: Same.
1009         * printcmd.c: Same.
1010         * procfs.c: Same.
1011         * record-btrace.c: Same.
1012         * record-full.c: Same.
1013         * remote-fileio.c: Same.
1014         * remote.c: Same.
1015         * rs6000-tdep.c: Same.
1016         * s12z-tdep.c: Same.
1017         * score-tdep.c: Same.
1018         * ser-base.c: Same.
1019         * ser-go32.c: Same.
1020         * skip.c: Same.
1021         * sol-thread.c: Same.
1022         * solib-svr4.c: Same.
1023         * solib.c: Same.
1024         * source.c: Same.
1025         * sparc-nat.c: Same.
1026         * sparc-sol2-tdep.c: Same.
1027         * sparc-tdep.c: Same.
1028         * sparc64-tdep.c: Same.
1029         * stabsread.c: Same.
1030         * stack.c: Same.
1031         * symfile.c: Same.
1032         * symtab.c: Same.
1033         * target-descriptions.c: Same.
1034         * target-float.c: Same.
1035         * thread.c: Same.
1036         * utils.c: Same.
1037         * valops.c: Same.
1038         * valprint.c: Same.
1039         * value.c: Same.
1040         * varobj.c: Same.
1041         * windows-nat.c: Same.
1042         * xcoffread.c: Same.
1043         * xstormy16-tdep.c: Same.
1044         * xtensa-tdep.c: Same.
1045
1046 2019-10-17  Tom Tromey  <tromey@adacore.com>
1047
1048         * configure: Rebuild.
1049         * configure.ac: Use AC_CONFIG_HEADERS.  Create stamp-h there, not
1050         in AC_CONFIG_FILES invocation.
1051         * Makefile.in (Makefile, data-directory/Makefile, stamp-h): Use
1052         new-style config.status invocation.
1053
1054 2019-10-17  Tom de Vries  <tdevries@suse.de>
1055
1056         * arm-nbsd-nat.c: Fix typos in comments.
1057         * arm-tdep.c: Same.
1058         * darwin-nat-info.c: Same.
1059         * dwarf2read.c: Same.
1060         * elfread.c: Same.
1061         * event-top.c: Same.
1062         * findvar.c: Same.
1063         * gdbtypes.c: Same.
1064         * hppa-tdep.c: Same.
1065         * i386-tdep.c: Same.
1066         * jit.c: Same.
1067         * main.c: Same.
1068         * mdebugread.c: Same.
1069         * moxie-tdep.c: Same.
1070         * nto-procfs.c: Same.
1071         * osabi.c: Same.
1072         * ppc-linux-tdep.c: Same.
1073         * remote.c: Same.
1074         * riscv-tdep.c: Same.
1075         * s390-tdep.c: Same.
1076         * sh-tdep.c: Same.
1077         * sparc-linux-tdep.c: Same.
1078         * sparc-nat.c: Same.
1079         * stack.c: Same.
1080         * target-descriptions.c: Same.
1081         * top.c: Same.
1082         * varobj.c: Same.
1083
1084 2019-10-16  Tom Tromey  <tom@tromey.com>
1085
1086         * objfiles.h (struct objfile) <original_name>: Now const.
1087
1088 2019-10-16  Christian Biesinger  <cbiesinger@google.com>
1089
1090         * gdbsupport/gdb_setjmp.h (SIGSETJMP): Allow passing in the value to
1091         pass on to sigsetjmp's second argument.
1092         * cp-support.c (gdb_demangle): Unblock SIGSEGV if we caught a crash.
1093
1094 2019-10-16  Keith Seitz  <keiths@redhat.com>
1095
1096         PR gdb/23567
1097         * dwarf2read.c (dwarf2_per_objfile::locate_sections): Discard
1098         sections whose size is greater than the file size.
1099
1100 2019-10-16  Jim Wilson  <jimw@sifive.com>
1101
1102         * riscv-tdep.c (riscv_gcc_target_options): New.
1103         (riscv_gnu_triplet_regexp): New.
1104         (riscv_gdbarch_init): Call set_gdbarch_gcc_triplet_options and
1105         set_gdbarch_gnu_triplet_regexp.
1106
1107 2019-10-16  Christian Biesinger  <cbiesinger@google.com>
1108
1109         * Makefile.in: Add xml-builtin.h.
1110         * features/feature_to_c.sh: Add an include for xml-builtin.h
1111         to ensure that the compiler checks that the types match.
1112         * xml-builtin.h: New file.
1113         * xml-support.c (fetch_xml_builtin): Add missing const.
1114         * xml-support.h: Remove declaration of xml_builtins.
1115
1116 2019-10-16  Tom de Vries  <tdevries@suse.de>
1117
1118         PR tdep/25096
1119         * amd64-tdep.c (amd64_classify_aggregate_field): Factor out of ...
1120         (amd64_classify_aggregate): ... here.
1121         (amd64_classify_aggregate_field): Handled fiels of nested structs
1122         recursively.
1123
1124 2019-10-16  Tom de Vries  <tdevries@suse.de>
1125
1126         PR tdep/24104
1127         * amd64-tdep.c (amd64_push_arguments): Handle AMD64_NO_CLASS in loop
1128         that handles 'theclass'.
1129
1130 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1131
1132         * linespec.c (decode_digits_ordinary): Update comment.
1133         * make-target-delegates: No longer need to handle VEC case.
1134         * memrange.c (normalize_mem_ranges): Update comment.
1135         * namespace.c (add_using_directive): Update comment.
1136         * objc-lang.c (uniquify_strings): Update comment.
1137         * ppc-linux-nat.c (struct thread_points): Update comment.
1138         * probe.h (find_probes_in_objfile): Update comment.
1139         * target.h (enum flash_preserve_mode): Update comment.
1140         * varobj.c (varobj_restrict_range): Update comment.
1141         * varobj.h (varobj_list_children): Update comment.
1142
1143 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1144
1145         * Makefile.in: Remove references to vec.h and vec.c.
1146         * aarch64-tdep.c: No longer include vec.h.
1147         * ada-lang.c: Likewise.
1148         * ada-lang.h: Likewise.
1149         * arm-tdep.c: Likewise.
1150         * ax.h: Likewise.
1151         * breakpoint.h: Likewise.
1152         * charset.c: Likewise.
1153         * cp-support.h: Likewise.
1154         * dtrace-probe.c: Likewise.
1155         * dwarf2read.c: Likewise.
1156         * extension.h: Likewise.
1157         * gdb_bfd.c: Likewise.
1158         * gdbsupport/gdb_vecs.h: Likewise.
1159         * gdbsupport/vec.c: Remove.
1160         * gdbsupport/vec.h: Remove.
1161         * gdbthread.h: Likewise.
1162         * guile/scm-type.c: Likewise.
1163         * inline-frame.c: Likewise.
1164         * machoread.c: Likewise.
1165         * memattr.c: Likewise.
1166         * memrange.h: Likewise.
1167         * namespace.h: Likewise.
1168         * nat/linux-btrace.h: Likewise.
1169         * osdata.c: Likewise.
1170         * parser-defs.h: Likewise.
1171         * progspace.h: Likewise.
1172         * python/py-type.c: Likewise.
1173         * record-btrace.c: Likewise.
1174         * rust-exp.y: Likewise.
1175         * solib-target.c: Likewise.
1176         * stap-probe.c: Likewise.
1177         * target-descriptions.c: Likewise.
1178         * target-memory.c: Likewise.
1179         * target.h: Likewise.
1180         * varobj.c: Likewise.
1181         * varobj.h: Likewise.
1182         * xml-support.h: Likewise.
1183
1184 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1185
1186         * gdb/dwarf2read.c (dwarf2_per_objfile::~dwarf2_per_objfile):
1187         Update for new std::vector based implementation.
1188         (process_psymtab_comp_unit_reader): Likewise.
1189         (scan_partial_symbols): Likewise.
1190         (recursively_compute_inclusions): Likewise.
1191         (compute_compunit_symtab_includes): Likewise.
1192         (process_imported_unit_die): Likewise.
1193         (queue_and_load_dwo_tu): Likewise.
1194         (follow_die_sig_1): Likewise.
1195         * gdb/dwarf2read.h: Remove DEF_VEC_P.
1196         (typedef dwarf2_per_cu_ptr): Remove.
1197         (struct dwarf2_per_cu_data) <imported_symtabs_empty>: New
1198         function.
1199         (struct dwarf2_per_cu_data) <imported_symtabs_push>: New function.
1200         (struct dwarf2_per_cu_data) <imported_symtabs_size>: New function.
1201         (struct dwarf2_per_cu_data) <imported_symtabs_free>: New function.
1202         (struct dwarf2_per_cu_data) <imported_symtabs>: Change to
1203         std::vector.
1204
1205 2019-10-15  Tom Tromey  <tromey@adacore.com>
1206
1207         * windows-nat.c (windows_nat_target::resume): Use %x when logging
1208         TID.
1209
1210 2019-10-15  Tom Tromey  <tromey@adacore.com>
1211
1212         * windows-nat.c (windows_nat_target::fetch_registers)
1213         (windows_nat_target::store_registers): Rename "pid" to "tid".
1214
1215 2019-10-15  Tom Tromey  <tromey@adacore.com>
1216
1217         * gdbarch.h, gdbarch.c: Rebuild.
1218         * gdbarch.sh (gcc_target_options): Change return type to
1219         std::string.
1220         * compile/compile.c (get_args): Update.
1221         * nios2-tdep.c (nios2_gcc_target_options): Return std::string.
1222         * arm-linux-tdep.c (arm_linux_gcc_target_options): Return
1223         std::string.
1224         * aarch64-linux-tdep.c (aarch64_linux_gcc_target_options): Return
1225         std::string.
1226         * arch-utils.c (default_gcc_target_options): Return std::string.
1227         * arch-utils.h (default_gcc_target_options): Return std::string.
1228         * s390-tdep.c (s390_gcc_target_options): Return std::string.
1229
1230 2019-10-15  Christian Biesinger  <cbiesinger@google.com>
1231
1232         * breakpoint.c (breakpoint_chain): Make static.
1233         * tui/tui-winsource.c: Call iterate_over_breakpoints instead
1234         of accessing breakpoint_chain.
1235
1236 2019-10-15  Christian Biesinger  <cbiesinger@google.com>
1237
1238         * breakpoint.c (iterate_over_breakpoints): Change function pointer
1239         to a gdb::function_view and return value to bool.
1240         * breakpoint.h (iterate_over_breakpoints): Likewise.
1241         * dummy-frame.c (pop_dummy_frame_bpt): Update.
1242         (pop_dummy_frame): Update.
1243         * guile/scm-breakpoint.c (bpscm_build_bp_list): Update.
1244         (gdbscm_breakpoints): Update.
1245         * python/py-breakpoint.c (build_bp_list): Update.
1246         (gdbpy_breakpoints): Update.
1247         * python/py-finishbreakpoint.c (bpfinishpy_detect_out_scope_cb):
1248         Update.
1249         (bpfinishpy_handle_stop): Update.
1250         (bpfinishpy_handle_exit): Update.
1251         * solib-svr4.c (svr4_update_solib_event_breakpoint): Update.
1252         (svr4_update_solib_event_breakpoints): Update.
1253
1254 2019-10-15  Andreas Arnez  <arnez@linux.ibm.com>
1255
1256         * s390-tdep.c (s390_effective_inner_type): Ignore static fields
1257         when unwrapping single-field structs.
1258
1259 2019-10-14  Simon Marchi  <simon.marchi@polymtl.ca>
1260
1261         * dwarf2read.c: Remove includes.
1262
1263 2019-10-13  Simon Marchi  <simon.marchi@polymtl.ca>
1264
1265         * ui-out.c (ui_out::call_do_message): Silence
1266         -Wformat-nonliteral warning.
1267
1268 2019-10-12  Simon Marchi  <simon.marchi@polymtl.ca>
1269
1270         * breakpoint.c: Remove some includes: continuations.h, skip.h,
1271         mi/mi-main.h, readline/readline.h, readline/history.h.  Add
1272         include: readline/tilde.h.
1273
1274 2019-10-12  Christian Biesinger  <cbiesinger@google.com>
1275
1276         * remote.c (remote_target::get_trace_status): Remove declaration of
1277         trace_regblock_size.
1278
1279 2019-10-12  Christian Biesinger  <cbiesinger@google.com>
1280
1281         * cli/cli-cmds.c (max_user_call_depth): Move comment to header.
1282         (show_user): Remove declaration of cmdlist.
1283         * cli/cli-cmds.h (max_user_call_depth): Declare.
1284         * cli/cli-script.c (execute_user_command): Remove declaration
1285         of max_user_call_depth.
1286
1287 2019-10-11  Jim Wilson  <jimw@sifive.com>
1288
1289         * gdbsupport/print-utils.h (pulongest): Fix comment.
1290         (plongest): Likewise.
1291         (phex): Add missing comment, mention leading zeros.
1292         (phex_nz): Add mention of no leading zeros to comment.
1293
1294         * riscv-tdep.c (riscv_push_dummy_code): Change %lld to %s and use
1295         plongest instead of unsigned long long cast.
1296
1297 2019-10-10  Christian Biesinger  <cbiesinger@google.com>
1298
1299         * main.c (captured_main_1): Include gdbtk.h and remove declarations
1300         for external_editor_command and gdbtk_test.
1301
1302 2019-10-10  Christian Biesinger  <cbiesinger@google.com>
1303
1304         * mi/mi-cmd-var.c (varobjdebug): Remove declaration.
1305         * varobj.c (varobjdebug): Move comment to...
1306         * varobj.h (varobjdebug): ...here, and declare.
1307
1308 2019-10-09  Tom Tromey  <tom@tromey.com>
1309
1310         * tui/tui-regs.c (tui_data_window::show_registers): Don't call
1311         erase_data_content.
1312
1313 2019-10-09  Tom Tromey  <tom@tromey.com>
1314
1315         * tui/tui-wingeneral.h (tui_delete_win): Don't declare.
1316         * tui/tui-stack.c (tui_locator_window::rerender): Update.
1317         * tui/tui-command.c (tui_cmd_window::resize)
1318         (tui_refresh_cmd_win): Update.
1319         * tui/tui-win.c (tui_resize_all, tui_set_focus_command): Update.
1320         * tui/tui.c (tui_rl_other_window, tui_enable): Update.
1321         * tui/tui-data.c (~tui_gen_win_info): Remove.
1322         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
1323         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
1324         (tui_redisplay_readline, tui_mld_flush)
1325         (tui_mld_erase_entire_line, tui_mld_getc, tui_getc): Update.
1326         * tui/tui-regs.c (tui_data_window::delete_data_content_windows)
1327         (tui_data_window::erase_data_content)
1328         (tui_data_item_window::rerender)
1329         (tui_data_item_window::refresh_window): Update.
1330         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window)
1331         (box_win, tui_gen_win_info::make_window)
1332         (tui_gen_win_info::make_visible): Update.
1333         (tui_delete_win): Remove.
1334         * tui/tui-winsource.c
1335         (tui_source_window_base::do_erase_source_content): Update.
1336         (tui_show_source_line, tui_source_window_base::update_tab_width)
1337         (tui_source_window_base::update_exec_info): Update.
1338         * tui/tui-data.h (struct curses_deleter): New.
1339         (struct tui_gen_win_info) <handle>: Now a unique_ptr.
1340         (struct tui_gen_win_info) <~tui_gen_win_info>: Define.
1341
1342 2019-10-09  Tom Tromey  <tom@tromey.com>
1343
1344         * tui/tui-wingeneral.h (struct tui_gen_win_info): Don't declare.
1345
1346 2019-10-09  Tom Tromey  <tom@tromey.com>
1347
1348         * tui/tui-data.c (tui_win_is_auxiliary): Remove.
1349         * tui/tui-data.h (tui_win_is_auxiliary): Don't declare.
1350
1351 2019-10-09  Tom Tromey  <tom@tromey.com>
1352
1353         * tui/tui-disasm.c (tui_get_low_disassembly_address): Compute
1354         window height directly.
1355         * tui/tui-layout.h (tui_default_win_viewport_height): Don't
1356         declare.
1357         * tui/tui-layout.c (tui_default_win_height): Remove.
1358         (tui_default_win_viewport_height): Remove.
1359
1360 2019-10-09  Tom Tromey  <tom@tromey.com>
1361
1362         * tui/tui.h: Remove comments.
1363
1364 2019-10-09  Tom de Vries  <tdevries@suse.de>
1365
1366         * python/lib/gdb/printer/bound_registers.py: Use
1367         '^builtin_type_bound128' as regexp argument for
1368         add_builtin_pretty_printer.
1369
1370 2019-10-09  Christian Biesinger  <cbiesinger@google.com>
1371
1372         * guile/guile.c (guile_extension_script_ops): Remove forward
1373         declaration and mark as static.
1374         (guile_script_ops): Likewise.
1375         (extension_language_guile): Move further down in the file so
1376         it can reference the definitions for guile_{extension_,}script_ops.
1377
1378 2019-10-09  Andreas Arnez  <arnez@linux.ibm.com>
1379
1380         * s390-tdep.c (390_process_record): Handle new arch13 instructions
1381         except SORTL, DFLTCC, and KDSA.
1382
1383 2019-10-08  Tom Tromey  <tromey@adacore.com>
1384
1385         * windows-nat.c (struct windows_thread_info_struct) <sf>: Remove.
1386         (struct safe_symbol_file_add_args): Remove.
1387
1388 2019-10-08  Tom Tromey  <tromey@adacore.com>
1389
1390         * windows-nat.c: Don't include buildsym-legacy.h.
1391
1392 2019-10-08  Tom Tromey  <tromey@adacore.com>
1393
1394         * contrib/ari/gdb_ari.sh (%p): Allow gdb-specific %p extensions.
1395
1396 2019-10-08  Christian Biesinger  <cbiesinger@google.com>
1397
1398         * gdbtypes.c (overload_debug): Move comment to header.
1399         * gdbtypes.h (overload_debug): Declare.
1400         * valops.c: Remove declaration of overload_debug, instead
1401         include gdbtypes.h.
1402
1403 2019-10-08  Christian Biesinger  <cbiesinger@google.com>
1404
1405         * language.c (show_language_command): Pass lang_frame_mismatch_warn
1406         through _().
1407         (lang_frame_mismatch_warn): Make const, mark with N_(), and
1408         move comment...
1409         * language.h (lang_frame_mismatch_warn): ... here. Also add
1410         declaration.
1411         * top.c (lang_frame_mismatch_warn): Remove declaration.
1412         (check_frame_language_change): Pass lang_frame_mismatch_warn
1413         through _().
1414
1415 2019-10-07  Christian Biesinger  <cbiesinger@google.com>
1416
1417         * c-lang.h (vtbl_ptr_name): Declare.
1418         * cp-valprint.c (vtbl_ptr_name): Remove "extern" now that we get
1419         it from the header.
1420         * stabsread.c (define_symbol): Remove declaration of vtbl_ptr_name.
1421
1422 2019-10-07  Christian Biesinger  <cbiesinger@google.com>
1423
1424         * charset.c (your_gdb_wchar_t_is_bogus): Replace with a
1425         gdb_static_assert.
1426
1427 2019-10-07  Weimin Pan  <weimin.pan@oracle.com>
1428
1429         * ../Makefile.def (dependencies): Add all-libctf to all-gdb
1430         * ../Makefile.in: Add "all-gdb: maybe-all-libctf"
1431         * ctfread.c: New file.
1432         * ctfread.h: New file.
1433         * elfread.c: Include ctfread.h.
1434         (struct elfinfo text_p): New member ctfsect.
1435         (elf_locate_sections): Mark CTF section.
1436         (elf_symfile_read): Call elfctf_build_psymtabs.
1437         * Makefile.in (LIBCTF): Add.
1438         (CLIBS): Use it.
1439         (CDEPS): Likewise.
1440         (DIST): Add ctfread.c.
1441
1442 2019-10-07  Andrew Burgess  <andrew.burgess@embecosm.com>
1443
1444         * ctfread.c (struct nextfield): Renamed to ...
1445         (struct ctf_nextfield): ... this.
1446         (struct field_info): Renamed to ...
1447         (strut ctf_field_info): ... this.
1448         (attach_fields_to_type): Update for renamed structures.
1449         (ctf_add_member_cb): Likewise.
1450         (ctf_add_enum_member_cb): Likewise.
1451         (process_struct_members): Likewise.
1452         (process_enum_type): Likewise.
1453
1454 2019-10-07  Weimin Pan  <weimin.pan@oracle.com>
1455
1456         * tracectf.h: Rename, was ctf.h.
1457         * tracectf.c: Rename, was ctf.c, replace ctf.h with tracectf.h.
1458         * tracefile.c: Likewise.
1459         * tracepoint.c: Remove unused include ctf.h.
1460         * mi/mi-main.c: Likewise.
1461         * Makefile.in Replace ctf.c with tracectf.c.
1462
1463 2019-10-06  Joel Brobecker  <brobecker@adacore.com>
1464
1465         * version.in: Change version number to "9.0.50.DATE-git".
1466
1467 2019-10-03  Tom Tromey  <tom@tromey.com>
1468
1469         PR rust/24976:
1470         * dwarf2read.c (quirk_rust_enum): Handle single-element unions.
1471
1472 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1473
1474         * f-lang.c (f_language_defn): Use cp_get_symbol_name_matcher and
1475         cp_search_name_hash.
1476         * NEWS: Add entry about nested function support.
1477
1478 2019-10-03  Bernhard Heckel  <bernhard.heckel@intel.com>
1479             Andrew Burgess  <andrew.burgess@embecosm.com>
1480
1481         * cp-namespace.c (cp_search_static_and_baseclasses): Only search
1482         for nested static variables when searchin VAR_DOMAIN.
1483         * dwarf2read.c (add_partial_symbol): Add nested subroutines to the
1484         global scope, update comment.
1485         (add_partial_subprogram): Call add_partial_subprogram recursively
1486         for nested subroutines when processinng Fortran.
1487         (load_partial_dies): Process the child entities of a subprogram
1488         when processing Fortran.
1489         (partial_die_parent_scope): Handle building scope
1490         for Fortran nested functions.
1491         (process_die): Record that nested functions have a scope.
1492         (new_symbol): Always record Fortran subprograms on the global
1493         symbol list.
1494         (determine_prefix): How to build the prefix for Fortran
1495         subprograms.
1496
1497 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1498
1499         * linux-nat.c (linux_nat_filter_event): Don't ignore SIGSTOP if we
1500         have just sent the thread a SIGSTOP and are waiting for it to
1501         arrive.
1502
1503 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1504
1505         * btrace.c (btrace_add_pc): Remove whitespace before the template
1506         parameter in 'std::vector <...>'.
1507         (parse_xml_btrace_block): Likewise.
1508         (btrace_maint_decode_pt): Likewise.
1509         (btrace_maint_update_packets): Likewise.
1510         (btrace_maint_print_packets): Likewise.
1511         * btrace.h (struct btrace_maint_info): Likewise.
1512         * dwarf2read.c (struct type_unit_group): Likewise.
1513         (build_type_psymtabs_reader): Likewise.
1514         * gdbsupport/btrace-common.c (btrace_data_append): Likewise.
1515         * gdbsupport/btrace-common.h (struct btrace_data_bts): Likewise.
1516         * nat/linux-btrace.c (perf_event_read_bts): Likewise.
1517
1518 2019-10-03  Tom de Vries  <tdevries@suse.de>
1519
1520         * cli/cli-style.c (_initialize_cli_style): Adding a '.' at the end of
1521         the first line of the help text for set/show style metadata.
1522
1523 2019-10-02  Tom Tromey  <tromey@adacore.com>
1524
1525         * Makefile.in (COMMON_SFILES): Add common-inferior.c.
1526         * gdbsupport/common-inferior.c: New file.
1527         * infcmd.c (startup_with_shell): Don't define.
1528         * nat/fork-inferior.h (startup_with_shell): Don't declare.
1529         * gdbsupport/common-inferior.h (startup_with_shell): Declare.
1530         * inferior.h (startup_with_shell): Don't declare.
1531
1532 2019-10-02  Christian Biesinger  <cbiesinger@google.com>
1533
1534         * gdbsupport/gdb_assert.h: Include errors.h.
1535         * gdbsupport/gdb_string_view.h: Include gdb_assert.h.
1536
1537 2019-10-02  Tom Tromey  <tromey@adacore.com>
1538
1539         * NEWS: Add $_ada_exception entry.
1540         * ada-lang.c (struct ada_catchpoint): Add constructor.
1541         <m_kind>: New member.
1542         (allocate_location_exception, re_set_exception): Remove
1543         "ex" parameter.
1544         (should_stop_exception): Compute $_ada_exception.
1545         (check_status_exception, print_it_exception)
1546         (print_one_exception, print_mention_exception): Remove
1547         "ex" parameter.
1548         (allocate_location_catch_exception, re_set_catch_exception)
1549         (check_status_exception, print_it_catch_exception)
1550         (print_one_catch_exception, print_mention_catch_exception)
1551         (print_recreate_catch_exception)
1552         (allocate_location_catch_exception_unhandled)
1553         (re_set_catch_exception_unhandled)
1554         (check_status_exception, print_it_catch_exception_unhandled)
1555         (print_one_catch_exception_unhandled)
1556         (print_mention_catch_exception_unhandled)
1557         (print_recreate_catch_exception_unhandled)
1558         (allocate_location_catch_assert, re_set_catch_assert)
1559         (check_status_assert, print_it_catch_assert)
1560         (print_one_catch_assert, print_mention_catch_assert)
1561         (print_recreate_catch_assert)
1562         (allocate_location_catch_handlers, re_set_catch_handlers)
1563         (check_status_handlers, print_it_catch_handlers)
1564         (print_one_catch_handlers, print_mention_catch_handlers)
1565         (print_recreate_catch_handlers): Remove.
1566         (create_ada_exception_catchpoint): Update.
1567         (initialize_ada_catchpoint_ops): Update.
1568
1569 2019-10-02  Tom Tromey  <tromey@adacore.com>
1570
1571         * ada-lang.c (ada_lookup_simple_minsyms): Remove.
1572         (create_excep_cond_exprs): Simplify exception string computation.
1573         (ada_exception_catchpoint_cond_string): Likewise.
1574
1575 2019-10-02  Tom Tromey  <tromey@adacore.com>
1576
1577         * symmisc.c (dump_msymbols): Don't use MSYMBOL_VALUE_ADDRESS.
1578         * ada-lang.c (lesseq_defined_than): Handle
1579         LOC_STATIC.
1580         * dwarf2read.c (dwarf2_per_objfile): Add can_copy
1581         parameter.
1582         (dwarf2_has_info): Likewise.
1583         (new_symbol): Set maybe_copied on symbol when
1584         appropriate.
1585         * dwarf2read.h (dwarf2_per_objfile): Add can_copy
1586         parameter.
1587         <can_copy>: New member.
1588         * elfread.c (record_minimal_symbol): Set maybe_copied
1589         on symbol when appropriate.
1590         (elf_symfile_read): Update call to dwarf2_has_info.
1591         * minsyms.c (lookup_minimal_symbol_linkage): New
1592         function.
1593         * minsyms.h (lookup_minimal_symbol_linkage): Declare.
1594         * symtab.c (get_symbol_address, get_msymbol_address):
1595         New functions.
1596         * symtab.h (get_symbol_address, get_msymbol_address):
1597         Declare.
1598         (SYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_ADDRESS): Handle
1599         maybe_copied.
1600         (struct symbol, struct minimal_symbol) <maybe_copied>:
1601         New member.
1602
1603 2019-10-02  Tom Tromey  <tromey@adacore.com>
1604
1605         * source.c (struct current_source_location): New.
1606         (current_source_key): New global.
1607         (current_source_symtab, current_source_line)
1608         (current_source_pspace): Remove.
1609         (get_source_location): New function.
1610         (get_current_source_symtab_and_line)
1611         (set_default_source_symtab_and_line)
1612         (set_current_source_symtab_and_line)
1613         (clear_current_source_symtab_and_line, select_source_symtab)
1614         (info_source_command, print_source_lines_base)
1615         (info_line_command, search_command_helper, _initialize_source):
1616         Update.
1617
1618 2019-10-02  Tom Tromey  <tromey@adacore.com>
1619
1620         * source.c (select_source_symtab): Don't call
1621         decode_line_with_current_source.
1622
1623 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1624
1625         * symtab.c (lookup_global_symbol): Search global block.
1626
1627 2019-10-02  Tom Tromey  <tromey@adacore.com>
1628
1629         * coffread.c (process_coff_symbol): Update.
1630         * dwarf2read.c (var_decode_location, new_symbol): Update.
1631         * mdebugread.c (parse_symbol): Update.
1632         * objfiles.c (relocate_one_symbol): Update.
1633         * stabsread.c (define_symbol, fix_common_block)
1634         (scan_file_globals): Update.
1635         * symtab.h (SYMBOL_VALUE_ADDRESS): Expand to an rvalue.
1636         (SET_SYMBOL_VALUE_ADDRESS): New macro.
1637         * xcoffread.c (process_xcoff_symbol): Update.
1638
1639 2019-10-02  Andreas Arnez  <arnez@linux.ibm.com>
1640
1641         * MAINTAINERS: Update my email address.
1642
1643 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1644
1645         * dwarf2read.c (struct type_unit_group) <tus>: Convert to
1646         std::vector.
1647         (build_type_psymtabs_reader): Update for std::vector.
1648         (build_type_psymtab_dependencies): Likewise.
1649         * dwarf2read.h: Remove use of DEF_VEC_P.
1650         (typedef sig_type_ptr): Delete.
1651
1652 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1653
1654         * btrace.c (btrace_maint_clear): Update to handle change from VEC
1655         to std::vector.
1656         (btrace_maint_decode_pt): Likewise, and move allocation of the
1657         vector outside of the loop.
1658         (btrace_maint_update_packets): Update to handle change from VEC to
1659         std::vector.
1660         (btrace_maint_print_packets): Likewise.
1661         (maint_info_btrace_cmd): Likewise.
1662         * btrace.h: Remove use of DEF_VEC_O.
1663         (typedef btrace_pt_packet_s): Delete.
1664         (struct btrace_maint_info) <packets>: Change fromm VEC to
1665         std::vector.
1666         * gdbsupport/btrace-common.h: Remove 'vec.h' include.
1667
1668 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1669
1670         * btrace.c (btrace_compute_ftrace_bts): Update for std::vector,
1671         make accesses into the vector constant references.
1672         (btrace_add_pc): Update for std::vector.
1673         (btrace_stitch_bts): Likewise.
1674         (parse_xml_btrace_block): Likewise.
1675         (btrace_maint_update_packets): Likewise.
1676         (btrace_maint_print_packets): Likewise.
1677         (maint_info_btrace_cmd): Likewise.
1678         * gdbsupport/btrace-common.c (btrace_data::fini): Update for
1679         std::vector.
1680         (btrace_data::empty): Likewise.
1681         (btrace_data_append): Likewise.
1682         * gdbsupport/btrace-common.h: Remove use of DEF_VEC_O.
1683         (typedef btrace_block_s): Delete.
1684         (struct btrace_block): Add constructor.
1685         (struct btrace_data_bts) <blocks>: Change to std::vector.
1686         * nat/linux-btrace.c (perf_event_read_bts): Update for
1687         std::vector.
1688         (linux_read_bts): Likewise.
1689
1690 2019-10-01  Tom Tromey  <tom@tromey.com>
1691
1692         * cli/cli-logging.c (show_logging_filename): Use styled_string.
1693
1694 2019-10-01  Tom Tromey  <tom@tromey.com>
1695
1696         * stack.c (print_frame, info_frame_command_core): Use
1697         styled_string.
1698         * linux-thread-db.c (try_thread_db_load_1)
1699         (try_thread_db_load_from_pdir_1): Use styled_string.
1700         * auto-load.c (file_is_auto_load_safe, execute_script_contents)
1701         (auto_load_section_scripts, info_auto_load_local_gdbinit)
1702         (maybe_print_unsupported_script_warning)
1703         (maybe_print_script_not_found_warning): Use styled_string.
1704         * ada-lang.c (user_select_syms): Use styled_string.
1705
1706 2019-10-01  Tom Tromey  <tom@tromey.com>
1707
1708         * p-lang.c (pascal_printstr): Use metadata style.
1709         * value.c (show_convenience): Use metadata style.
1710         * valprint.c (valprint_check_validity, val_print_optimized_out)
1711         (val_print_not_saved, val_print_unavailable)
1712         (val_print_invalid_address, generic_val_print, val_print)
1713         (value_check_printable, val_print_array_elements): Use metadata
1714         style.
1715         * ui-out.h (class ui_out) <field_fmt>: New overload.
1716         <do_field_fmt>: Add style parameter.
1717         * ui-out.c (ui_out::field_fmt): New overload.
1718         * typeprint.c (type_print_unknown_return_type)
1719         (val_print_not_allocated, val_print_not_associated): Use metadata
1720         style.
1721         * tui/tui-out.h (class tui_ui_out) <do_field_fmt>: Add style
1722         parameter.
1723         * tui/tui-out.c (tui_ui_out::do_field_fmt): Update.
1724         * tracepoint.c (tvariables_info_1): Use metadata style.
1725         * stack.c (print_frame_arg, print_frame_info, print_frame)
1726         (info_frame_command_core): Use metadata style.
1727         * skip.c (info_skip_command): Use metadata style.
1728         * rust-lang.c (rust_print_enum): Use metadata style.
1729         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
1730         metadata style.
1731         * python/py-framefilter.c (py_print_single_arg): Use metadata
1732         style.
1733         * printcmd.c (do_one_display, print_variable_and_value): Use
1734         metadata style.
1735         * p-valprint.c (pascal_val_print)
1736         (pascal_object_print_value_fields): Use metadata style.
1737         * p-typeprint.c (pascal_type_print_base): Use metadata style.
1738         * mi/mi-out.h (class mi_ui_out) <do_field_fmt>: Add style
1739         parameter.
1740         * mi/mi-out.c (mi_ui_out::do_field_fmt): Update.
1741         * m2-valprint.c (m2_print_long_set): Use metadata style.
1742         * m2-typeprint.c (m2_print_type): Use metadata style.
1743         * infcmd.c (print_return_value_1): Use metadata style.
1744         * gnu-v3-abi.c (print_one_vtable): Use metadata style.
1745         * f-valprint.c (info_common_command_for_block): Use metadata
1746         style.
1747         * f-typeprint.c (f_type_print_base): Use metadata style.
1748         * expprint.c (print_subexp_standard): Use metadata style.
1749         * cp-valprint.c (cp_print_value_fields): Use metadata style.
1750         * cli/cli-style.h (class cli_style_option): Add constructor.
1751         (metadata_style): Declare.
1752         * cli/cli-style.c (metadata_style): New global.
1753         (_initialize_cli_style): Register metadata style.
1754         * cli-out.h (class cli_ui_out) <do_field_fmt>: Add style
1755         parameter.
1756         * cli-out.c (cli_ui_out::do_field_fmt): Update.
1757         * c-typeprint.c (c_type_print_base_struct_union)
1758         (c_type_print_base_1): Use metadata style.
1759         * breakpoint.c (watchpoint_value_print)
1760         (print_one_breakpoint_location): Use metadata style.
1761         * break-catch-syscall.c (print_one_catch_syscall): Use metadata
1762         style.
1763         * break-catch-sig.c (signal_catchpoint_print_one): Use metadata
1764         style.
1765         * ada-valprint.c (val_print_packed_array_elements, printstr)
1766         (print_field_values, ada_val_print_ref, ada_val_print): Use
1767         metadata style.
1768         * ada-typeprint.c (print_array_type, ada_print_type): Use metadata
1769         style.
1770         * ada-tasks.c (print_ada_task_info, info_task): Use metadata
1771         style.
1772         * ada-lang.c (user_select_syms): Use metadata style.
1773
1774 2019-10-01  Tom Tromey  <tom@tromey.com>
1775
1776         * cli/cli-cmds.c (pwd_command): Style output.
1777
1778 2019-10-01  Pedro Alves  <palves@redhat.com>
1779             Tom Tromey  <tom@tromey.com>
1780
1781         * symtab.c (print_symbol_info): Use %ps.
1782         (print_msymbol_info): Use %ps.
1783         * symfile.c (symbol_file_add_with_addrs): Use %ps.
1784         * printcmd.c (print_variable_and_value): Use %ps.
1785         * macrocmd.c (show_pp_source_pos): Use %ps.
1786         * infrun.c (print_exited_reason): Use ui_out::message.
1787         * breakpoint.c (watchpoint_check, print_one_breakpoint_location)
1788         (describe_other_breakpoints): Use ui_out::message and new
1789         formats.
1790         (say_where): Use new formats.
1791         (bkpt_print_it, tracepoint_print_one_detail): Use ui_out::message
1792         and new formats.
1793
1794 2019-10-01  Pedro Alves  <palves@redhat.com>
1795             Tom Tromey  <tom@tromey.com>
1796
1797         * unittests/format_pieces-selftests.c: Add gdb_format parameter.
1798         (test_gdb_formats): New function.
1799         (run_tests): Call it.
1800         (test_format_specifier): Update.
1801         * utils.h (fputs_filtered): Update comment.
1802         (vfprintf_styled, vfprintf_styled_no_gdbfmt)
1803         (fputs_styled_unfiltered): Declare.
1804         * utils.c (fputs_styled_unfiltered): New function.
1805         (vfprintf_maybe_filtered): Add gdbfmt parameter.
1806         (vfprintf_filtered): Update.
1807         (vfprintf_unfiltered, vprintf_filtered): Update.
1808         (vfprintf_styled, vfprintf_styled_no_gdbfmt): New functions.
1809         * ui-out.h (enum ui_out_flag) <unfiltered_output,
1810         disallow_ui_out_field>: New constants.
1811         (enum class field_kind): New.
1812         (struct base_field_s, struct signed_field_s): New.
1813         (signed_field): New function.
1814         (struct string_field_s): New.
1815         (string_field): New function.
1816         (struct styled_string_s): New.
1817         (styled_string): New function.
1818         (class ui_out) <message>: Add comment.
1819         <vmessage, call_do_message>: New methods.
1820         <do_message>: Add style parameter.
1821         * ui-out.c (ui_out::call_do_message, ui_out::vmessage): New
1822         methods.
1823         (ui_out::message): Rewrite.
1824         * mi/mi-out.h (class mi_ui_out) <do_message>: Add style
1825         parameter.
1826         * mi/mi-out.c (mi_ui_out::do_message): Add style parameter.
1827         * gdbsupport/format.h (class format_pieces) <format_pieces>: Add
1828         gdb_extensions parameter.
1829         (class format_piece): Add parameter to constructor.
1830         (n_int_args): New field.
1831         * gdbsupport/format.c (format_pieces::format_pieces): Add
1832         gdb_extensions parameter.  Handle '*'.
1833         * cli-out.h (class cli_ui_out) <do_message>: Add style parameter.
1834         * cli-out.c (cli_ui_out::do_message): Add style parameter.  Call
1835         vfprintf_styled_no_gdbfmt.
1836         (cli_ui_out::do_field_string, cli_ui_out::do_spaces)
1837         (cli_ui_out::do_text, cli_ui_out::field_separator): Allow
1838         unfiltered output.
1839         * ui-style.h (struct ui_file_style) <ptr>: New method.
1840
1841 2019-10-01  Tom Tromey  <tom@tromey.com>
1842
1843         * unittests/format_pieces-selftests.c: Update.  Add final format.
1844         * gdbsupport/format.c (format_pieces::format_pieces): Don't add
1845         empty literal pieces.
1846
1847 2019-10-01  Tom Tromey  <tom@tromey.com>
1848
1849         * ui-out.h (enum class ui_out_style_kind): Remove.
1850         (class ui_out) <field_string, field_stsream, do_field_string>:
1851         Change type of "style".
1852         * ui-out.c (ui_out::field_core_addr, ui_out::field_stream)
1853         (ui_out::field_string): Update.
1854         * tui/tui-out.h (class tui_ui_out) <do_field_string>: Change type
1855         of "style".
1856         * tui/tui-out.c (tui_ui_out::do_field_string): Update.
1857         * tracepoint.c (print_one_static_tracepoint_marker): Update.
1858         * stack.c (print_frame_arg, print_frame_info, print_frame):
1859         Update.
1860         * source.c (print_source_lines_base): Update.
1861         * solib.c (info_sharedlibrary_command): Update.
1862         * skip.c (info_skip_command): Update.
1863         * record-btrace.c (btrace_call_history_src_line)
1864         (btrace_call_history): Update.
1865         * python/py-framefilter.c (py_print_frame): Update.
1866         * mi/mi-out.h (class mi_ui_out) <do_field_string>: Change type of
1867         "style".
1868         * mi/mi-out.c (mi_ui_out::do_table_header)
1869         (mi_ui_out::do_field_signed, mi_ui_out::do_field_unsigned)
1870         (mi_ui_out::do_field_string): Update.
1871         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
1872         Update.
1873         * cli-out.h (class cli_ui_out) <do_field_string>: Change type of
1874         "style".
1875         * cli-out.c (cli_ui_out::do_table_header)
1876         (cli_ui_out::do_field_signed, cli_ui_out::do_field_unsigned)
1877         (cli_ui_out::do_field_skip, cli_ui_out::do_field_string)
1878         (cli_ui_out::do_field_fmt): Update.
1879         * breakpoint.c (print_breakpoint_location): Update.
1880         (update_static_tracepoint): Update.
1881
1882 2019-10-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1883
1884         * main.c (relocate_gdbinit_path_maybe_in_datadir): Remove std::string
1885         conversion of gdb_datadir.
1886         (captured_main_1): Remove xstrdup when assigning to gdb_datadir,
1887         remove not needed c_str ().
1888
1889 2019-09-30  Ali Tamur <tamur@google.com>
1890
1891         * dwarf2read.c (skip_one_die): Handle DW_FORM_strx forms.
1892         (dwarf2_string_attr): Likewise.
1893
1894 2019-09-30  Ali Tamur <tamur@google.com>
1895
1896         * dwarf2read.c (process_full_comp_unit): Remove whitespace at the EOL.
1897         (process_full_type_unit): Likewise.
1898         (dump_die_shallow): Likewise.
1899         (cu_debug_loc_section): Likewise.
1900
1901 2019-09-28  Christian Biesinger  <cbiesinger@google.com>
1902
1903         * minsyms.c (compare_minimal_symbols): Rename to...
1904         (minimal_symbol_is_less_than): ...this, and adjust to STL
1905         conventions (return bool, take arguments as references)
1906         (minimal_symbol_reader::install): Call std::sort instead
1907         of qsort.
1908
1909 2019-09-29  Christian Biesinger  <cbiesinger@google.com>
1910
1911         * minsyms.h (msymbol_hash): Document that this is a case-insensitive
1912         hash and why.
1913         * objfiles.h (struct objfile_per_bfd_storage) <demangled_names_hash,
1914         msymbol_hash, msymbol_demangled_hash>: Improve comments.
1915
1916 2019-09-30  Simon Marchi  <simon.marchi@polymtl.ca>
1917
1918         * psymtab.c (add_psymbol_to_list): Move comment to psympriv.h.
1919         * psympriv.h (add_psymbol_to_list): Move comment here and update
1920         it.
1921
1922 2019-09-29  Tom de Vries  <tdevries@suse.de>
1923
1924         * contrib/cc-with-tweaks.sh (get_tmpdir): New function.
1925         Use $tmpdir/$(basename "$output_file").dwz instead of
1926         "${output_file}.dwz".
1927
1928 2019-09-28  Simon Marchi  <simon.marchi@polymtl.ca>
1929
1930         PR gdb/25045
1931         * hppa-linux-nat.c: Include gdbarch.h.
1932
1933 2019-09-26  Christian Biesinger  <cbiesinger@google.com>
1934
1935         * blockframe.c (find_pc_partial_function): Change return type to bool.
1936         * elfread.c (elf_gnu_ifunc_resolve_name): Likewise.
1937         * minsyms.c (in_gnu_ifunc_stub): Likewise.
1938         (stub_gnu_ifunc_resolve_name): Likewise.
1939         * symtab.c (compare_filenames_for_search): Likewise.
1940         (compare_glob_filenames_for_search): Likewise.
1941         (matching_obj_sections): Likewise.
1942         (symbol_matches_domain): Likewise.
1943         (find_line_symtab): Change out param EXACT_MATCH to bool *.
1944         (find_line_pc): Change return type to bool.
1945         (find_line_pc_range): Likewise.
1946         (producer_is_realview): Likewise.
1947         * symtab.h (symbol_matches_domain): Likewise.
1948         (find_pc_partial_function): Likewise.
1949         (find_pc_line_pc_range): Likewise.
1950         (in_gnu_ifunc_stub): Likewise.
1951         (struct gnu_ifunc_fns) <gnu_ifunc_resolve_name>: Likewise.
1952         (find_line_pc): Likewise.
1953         (find_line_pc_range): Likewise.
1954         (matching_obj_sections): Likewise.
1955         (find_line_symtab): Change out parameter to bool.
1956         (producer_is_realview): Change return type to bool.
1957         (compare_filenames_for_search): Likewise.
1958         (compare_glob_filenames_for_search): Likewise.
1959
1960 2019-09-26  Tom Tromey  <tom@tromey.com>
1961
1962         * Makefile.in (COMMON_SFILES): Remove gdb_usleep.c.
1963         (HFILES_NO_SRCDIR): Remove gdb_usleep.h.
1964         * gdb_usleep.h: Remove.
1965         * gdb_usleep.c: Remove.
1966         * utils.c: Don't include gdb_usleep.h.
1967
1968 2019-09-26  Tom Tromey  <tromey@adacore.com>
1969
1970         * python/py-type.c (type_to_type_object): Call check_typedef
1971         for stub types.
1972
1973 2019-09-26  Tom Tromey  <tom@tromey.com>
1974
1975         * utils.h (initialize_utils): Don't declare.
1976         * top.c (gdb_init): Don't call initialize_utils.
1977         * utils.c (initialize_utils): Remove.  Move contents...
1978         (_initialize_utils): ... here.
1979
1980 2019-09-25  Tom Tromey  <tom@tromey.com>
1981
1982         * python/py-objfile.c (objfpy_get_build_id): Use bin2hex.
1983         * utils.h (make_hex_string): Don't declare.
1984         * utils.c (make_hex_string): Remove.
1985
1986 2019-09-24  Tom de Vries  <tdevries@suse.de>
1987
1988         PR gdb/23815
1989         * amd64-linux-nat.c (amd64_linux_nat_target::fetch_registers):
1990         Initialize xstateregs before ptrace PTRACE_GETREGSET call.
1991
1992 2019-09-23  Dimitar Dimitrov  <dimitar@dinux.eu>
1993
1994         * NEWS: Mention new simulator port for PRU.
1995
1996 2019-09-23  Christian Biesinger  <cbiesinger@google.com>
1997
1998         * ada-exp.y (write_object_remaining): Update.
1999         * ada-lang.c (ada_decode): Return a std::string instead of a char*
2000         and eliminate the static buffer.
2001         (ada_decode_symbol): Update.
2002         (ada_la_decode): Update.
2003         (ada_sniff_from_mangled_name): Update.
2004         (is_valid_name_for_wild_match): Update.
2005         (ada_lookup_name_info::matches): Update and simplify.
2006         (name_matches_regex): Update.
2007         (ada_add_global_exceptions): Update.
2008         * ada-lang.h (ada_decode): Update signature.
2009         * ada-varobj.c (ada_varobj_describe_simple_array_child): Update.
2010         * dwarf-index-write.c (debug_names::insert): Update.
2011
2012 2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>
2013
2014         * solib-svr4.c (svr4_iterate_over_objfiles_in_search_order): Fix
2015         formatting.
2016
2017 2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>
2018
2019         * breakpoint.h (bp_location) <inserted, permanent, duplicate>:
2020         Change "nonzero" to "true" in documentation.
2021
2022 2019-09-20  Christian Biesinger  <cbiesinger@google.com>
2023
2024         * solib-darwin.c (darwin_lookup_lib_symbol): Remove.
2025         (_initialize_darwin_solib): Don't set
2026         darwin_so_ops.lookup_lib_global_symbol.
2027         * solib-svr4.c (set_solib_svr4_fetch_link_map_offsets): Call
2028         set_gdbarch_iterate_over_objfiles_in_search_order.
2029         (elf_lookup_lib_symbol): Rename to...
2030         (svr4_iterate_over_objfiles_in_search_order): this, and update
2031         to iterate semantics.
2032         (_initialize_svr4_solib): Don't set lookup_lib_global_symbol.
2033         * solib.c (solib_global_lookup): Remove.
2034         * solist.h (struct target_so_ops): Remove lookup_lib_global_symbol.
2035         (solib_global_lookup): Remove.
2036         * symtab.c (lookup_global_or_static_symbol): Remove call to
2037         solib_global_lookup.
2038
2039 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
2040
2041         * NEWS: Move entries about default MI version now being
2042         version 3, and about the GDB/MI fix for multi-location
2043         breakpoints to the "since GDB 8.3" section.
2044
2045 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
2046
2047         GDB 8.3.1 released.
2048
2049 2019-09-20  Ulrich Weigand  <uweigand@de.ibm.com>
2050
2051         * NEWS: Mention that Cell/B.E. debugging support was removed.
2052         * MAINTAINERS: Remove spu target.
2053
2054         * config/djgpp/fnchange.lst: Remove entries for removed files.
2055
2056         * Makefile.in (ALL_TARGET_OBS): Remove solib-spu.o,
2057         spu-multiarch.o, and spu-tdep.o.
2058         (HFILES_NO_SRCDIR): Remove solib-spu.h and spu-tdep.h.
2059         (ALLDEPFILES): Remove solib-spu.c, spu-linux-nat.c,
2060         spu-multiarch.c, and spu-tdep.c.
2061         * spu-linux-nat.c: Remove file.
2062         * spu-multiarch.c: Remove file.
2063         * spu-tdep.c: Remove file.
2064         * spu-tdep.h: Remove file.
2065         * solib-spu.c: Remove file.
2066         * solib-spu.h: Remove file.
2067
2068         * configure.host (powerpc64*-*-linux*): Remove Cell/B.E. support.
2069         * configure.nat (spu-linux): Remove.
2070         * configure.tgt (powerpc*-*-linux*): Remove solib-spu.o and
2071         solib-multiarch.o from gdb_target_obs.
2072         (spu*-*-*): Remove.
2073
2074         * arch/ppc-linux-common.h (struct ppc_linux_features): Remove "cell"
2075         feature flag.
2076         (ppc_linux_no_features): Update.
2077         * arch/ppc-linux-common.c (ppc_linux_match_description): Remove
2078         Cell/B.E. support.
2079         * arch/ppc-linux-tdesc.h (tdesc_powerpc_cell32l): Remove declaration.
2080         (tdesc_powerpc_cell64l): Likewise.
2081         * nat/ppc-linux.h (PPC_FEATURE_CELL): Remove.
2082         * ppc-linux-nat.c (ppc_linux_nat_target::read_description): Remove
2083         Cell/B.E. support.
2084         * ppc-linux-tdep.h: Do not include "solib-spu.h" or "spu-tdep.h".
2085         Do not include "features/rs6000/powerpc-cell32l.c" or
2086         "features/rs6000/powerpc-cell64l.c".
2087         (ppc_linux_spu_section): Remove.
2088         (ppc_linux_core_read_description): Remove Cell/B.E. support.
2089         (spe_context_objfile, spe_context_lm_addr, spe_context_offset,
2090         spe_context_cache_ptid, spe_context_cache_ptid): Remove.
2091         (ppc_linux_spe_context_lookup): Remove.
2092         (ppc_linux_spe_context_inferior_created): Remove.
2093         (ppc_linux_spe_context_solib_loaded): Remove.
2094         (ppc_linux_spe_context_solib_unloaded): Remove.
2095         (ppc_linux_spe_context): Remove.
2096         (struct ppu2spu_cache): Remove.
2097         (ppu2spu_prev_arch, ppu2spu_this_id, ppu2spu_prev_register): Remove.
2098         (struct ppu2spu_data): Remove.
2099         (ppu2spu_unwind_register, ppu2spu_sniffer, ppu2spu_dealloc_cache,
2100         ppu2spu_unwind): Remove.
2101         (ppc_linux_init_abi): Remove Cell/B.E. support.
2102         * rs6000-tdep.h (rs6000_gdbarch_init): Remove Cell/B.E. support.
2103
2104         * features/Makefile (rs6000/powerpc-cell32l-expedite): Remove.
2105         (rs6000/powerpc-cell64l-expedite): Likewise
2106         (WHICH): Remove rs6000/powerpc-cell32l and rs6000/powerpc-cell64l.
2107         (XMLTOC): Remove rs6000/powerpc-cell32l.xml and
2108         rs6000/powerpc-cell64l.xml.
2109         * features/rs6000/powerpc-cell32l.xml: Remove.
2110         * features/rs6000/powerpc-cell64l.xml: Likewise.
2111         * features/rs6000/powerpc-cell32l.c: Remove generated file.
2112         * features/rs6000/powerpc-cell64l.c: Likewise.
2113         * regformats/rs6000/powerpc-cell32l.dat: Remove generated file.
2114         * regformats/rs6000/powerpc-cell64l.dat: Likewise.
2115         * regformats/reg-spu.dat: Remove.
2116
2117         * target.h (enum target_object): Remove TARGET_OBJECT_SPU.
2118         * corelow.c (struct spuid_list): Remove.
2119         (add_to_spuid_list): Remove.
2120         (core_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
2121         * remote.c (PACKET_qXfer_spu_read, PACKET_qXfer_spu_write): Remove.
2122         (remote_protocol_features): Remove associated entries.
2123         (_initialize_remote): No longer initialize them.
2124         (remote_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
2125         * linux-nat.c (SPUFS_MAGIC): Remove.
2126         (linux_proc_xfer_spu): Remove.
2127         (spu_enumerate_spu_ids): Remove.
2128         (linux_nat_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
2129         * linux-tdep.c (-linux_spu_make_corefile_notes): Remove.
2130         (linux_make_corefile_notes): No longer call it.
2131
2132         * regcache.c (cooked_read_test): Remove bfd_arch_spu special case.
2133         (cooked_write_test): Likewise.
2134
2135 2019-09-20  Tom Tromey  <tom@tromey.com>
2136
2137         * NEWS: Mention case-sensitivity of TUI commands.
2138         * tui/tui-win.c (tui_set_focus_command): Now case-sensitive.
2139         (tui_set_win_height_command, parse_scrolling_args): Likewise.
2140         * tui/tui-layout.c (tui_layout_command): Now case-sensitive.
2141
2142 2019-09-20  Tom Tromey  <tom@tromey.com>
2143
2144         * tui/tui-source.c (tui_source_window::set_contents): Use
2145         make_unique_xstrdup.
2146         * tui/tui-disasm.c (tui_disasm_window::set_contents): Use
2147         make_unique_xstrdup.
2148
2149 2019-09-20  Tom Tromey  <tom@tromey.com>
2150
2151         * tui/tui-data.c: Remove separator comments.
2152         * tui/tui-layout.c: Remove separator comments.
2153         * tui/tui-win.c: Remove separator comments.
2154         * tui/tui-wingeneral.c: Remove separator comments.
2155
2156 2019-09-20  Tom Tromey  <tom@tromey.com>
2157
2158         * tui/tui.h (strcat_to_buf): Don't declare.
2159         * tui/tui.c (strcat_to_buf): Remove.
2160
2161 2019-09-20  Tom Tromey  <tom@tromey.com>
2162
2163         * tui/tui-source.h (struct tui_source_window) <m_fullname>: Rename
2164         from "fullname".
2165         * tui/tui-source.c (tui_source_window::set_contents)
2166         (tui_source_window::location_matches_p)
2167         (tui_source_window::maybe_update): Update.
2168
2169 2019-09-20  Tom Tromey  <tom@tromey.com>
2170
2171         * tui/tui-regs.h (struct tui_data_window) <get_current_group>:
2172         Update.
2173         <m_regs_content, m_regs_column_count, m_current_group>: Add "m_"
2174         prefix.
2175         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
2176         (tui_data_window::line_from_reg_element_no)
2177         (tui_data_window::first_reg_element_no_inline)
2178         (tui_data_window::show_registers)
2179         (tui_data_window::show_register_group)
2180         (tui_data_window::display_registers_from)
2181         (tui_data_window::display_registers_from_line)
2182         (tui_data_window::first_data_item_displayed)
2183         (tui_data_window::delete_data_content_windows)
2184         (tui_data_window::erase_data_content)
2185         (tui_data_window::do_scroll_vertical)
2186         (tui_data_window::refresh_window)
2187         (tui_data_window::check_register_values): Update.
2188
2189 2019-09-20  Tom Tromey  <tom@tromey.com>
2190
2191         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN): Remove define.
2192         (struct tui_locator_window) <full_name, proc_name>: Now
2193         std::string.
2194         * tui/tui-stack.c (tui_locator_window::make_status_line)
2195         (tui_locator_window::set_locator_fullname)
2196         (tui_locator_window::set_locator_info): Update.
2197         * tui/tui-source.c (tui_source_window::set_contents)
2198         (tui_source_window::showing_source_p): Update.
2199
2200 2019-09-20  Tom Tromey  <tom@tromey.com>
2201
2202         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
2203         Don't call tui_locator_win_info_ptr.
2204
2205 2019-09-20  Tom Tromey  <tom@tromey.com>
2206
2207         * tui/tui-win.c (tui_resize_all): Don't call refresh.
2208
2209 2019-09-20  Tom Tromey  <tom@tromey.com>
2210
2211         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use 1 as
2212         height for locator.
2213         * tui/tui-stack.c (tui_locator_window::rerender): Call scrollok.
2214         * tui/tui-layout.c (show_source_disasm_command, show_data)
2215         (show_source_or_disasm_and_command): Use 1 as height for locator.
2216
2217 2019-09-20  Tom Tromey  <tom@tromey.com>
2218
2219         * tui/tui.c (tui_enable): Update.
2220         * tui/tui-win.c (tui_sigwinch_handler, tui_async_resize_screen):
2221         Update.
2222         * tui/tui-data.h (tui_win_resized, tui_set_win_resized_to):
2223         Update.
2224         * tui/tui-data.c (win_resized): Now bool.
2225         (tui_win_resized): Return bool.
2226         (tui_set_win_resized_to): Accept a bool.
2227
2228 2019-09-20  Tom Tromey  <tom@tromey.com>
2229
2230         * tui/tui-regs.h (struct tui_data_window) <show_register_group>:
2231         Change type of "refresh_values_only".
2232         * tui/tui-regs.c (tui_data_window::show_register_group): Change
2233         type of "refresh_values_only".
2234
2235 2019-09-20  Tom Tromey  <tom@tromey.com>
2236
2237         * tui/tui-disasm.c (struct tui_asm_line) <addr_string, insn>: Now
2238         std::string.
2239         (tui_disassemble): Add "pos" parameter.
2240         (tui_disasm_window::set_contents): Simplify.
2241
2242 2019-09-20  Tom Tromey  <tom@tromey.com>
2243
2244         * tui/tui-winsource.h (struct tui_source_window_base)
2245         <show_source_content>: Now private.
2246         * tui/tui-winsource.c
2247         (tui_source_window_base::show_source_content): Don't handle empty
2248         content case.
2249
2250 2019-09-20  Tom Tromey  <tom@tromey.com>
2251
2252         * tui/tui-layout.c (show_source_disasm_command)
2253         (show_source_or_disasm_and_command): Don't call
2254         show_source_content.
2255
2256 2019-09-20  Tom Tromey  <tom@tromey.com>
2257
2258         * tui/tui-stack.h (struct tui_locator_window) <make_status_line>:
2259         Declare.
2260         * tui/tui-stack.c (tui_locator_window::make_status_line): Rename
2261         from tui_make_status_line.
2262         (tui_locator_window::rerender): Update.
2263
2264 2019-09-20  Tom Tromey  <tom@tromey.com>
2265
2266         * tui/tui-stack.c (tui_make_status_line): Return std::string.
2267         (tui_locator_window::rerender): Update.
2268
2269 2019-09-20  Tom Tromey  <tom@tromey.com>
2270
2271         * tui/tui-winsource.h (struct tui_source_window_base)
2272         <~tui_source_window_base>: Don't declare.
2273         <fullname>: Remove.
2274         * tui/tui-winsource.c (~tui_source_window_base): Remove.
2275         * tui/tui-source.h (struct tui_source_window) <fullname>: New
2276         member.
2277         * tui/tui-source.c (tui_source_window::set_contents): Update.
2278         (tui_source_window::location_matches_p)
2279         (tui_source_window::maybe_update): Update.
2280
2281 2019-09-20  Tom Tromey  <tom@tromey.com>
2282
2283         * tui/tui-winsource.h (~tui_source_element): Remove.
2284         (tui_source_element): Update.
2285         (struct tui_source_element) <line>: Now a unique_xmalloc_ptr.
2286         * tui/tui-winsource.c (tui_show_source_line): Update.
2287         * tui/tui-source.c (tui_source_window::set_contents): Update.
2288         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
2289
2290 2019-09-20  Tom Tromey  <tom@tromey.com>
2291
2292         * tui/tui-data.h (tui_clear_source_windows_detail): Don't
2293         declare.
2294         * tui/tui-layout.c (tui_add_win_to_layout): Don't call
2295         tui_clear_source_windows_detail.
2296         * tui/tui-winsource.h (struct tui_source_window_base)
2297         <clear_detail>: Don't declare.
2298         * tui/tui-winsource.c (tui_source_window_base::clear_detail):
2299         Remove.
2300         * tui/tui-data.c (tui_clear_source_windows_detail): Remove.
2301
2302 2019-09-20  Tom Tromey  <tromey@adacore.com>
2303
2304         PR ada/24919:
2305         * block.c (contained_in): Fix final return value.
2306
2307 2019-09-20  Alan Modra  <amodra@gmail.com>
2308
2309         * gdb_bfd.c (gdb_bfd_ref, gdb_bfd_unref): Use bfd_set_usrdata.
2310         * dwarf2read.c (dwarf2_read_gdb_index, dwarf2_read_debug_names),
2311         (read_indirect_string_from_dwz): Use bfd accessor.
2312         * dwarf2read.h (struct dwz_file <filename>): Likewise.
2313         * machoread.c (macho_symfile_read_all_oso): Likewise.
2314         * solib.c (solib_bfd_open): Likewise.
2315
2316 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
2317
2318         * eval.c: Move declaration of overload_resolution to...
2319         * value.h: ...here.
2320
2321 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
2322
2323         * arm-linux-nat.c: Remove extern declaration for arm_apcs_32.
2324         * arm-linux-tdep.c: Likewise.
2325         * arm-nbsd-nat.c: Likewise.
2326         * arm-tdep.h: Declare arm_apcs_32.
2327         * arm-tdep.c: Move documentation for arm_apcs_32 to arm-tdep.h.
2328
2329 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
2330
2331         * dwarf2loc.c: Remove extern declaration of dwarf_always_disassemble.
2332         * dwarf2read.h: Declare dwarf_always_disassemble.
2333
2334 2019-09-19  Tom de Vries  <tdevries@suse.de>
2335
2336         PR gdb/25009
2337         * source-cache.c (source_cache::ensure): Catch exception thrown during
2338         construction of the highlighter.
2339
2340 2019-09-18  Alan Modra  <amodra@gmail.com>
2341
2342         * aarch64-linux-tdep.c, * arm-tdep.c, * auto-load.c,
2343         * coff-pe-read.c, * coffread.c, * corelow.c, * dbxread.c,
2344         * dicos-tdep.c, * dwarf2-frame.c, * dwarf2read.c, * elfread.c,
2345         * exec.c, * fbsd-tdep.c, * gcore.c, * gdb_bfd.c, * gdb_bfd.h,
2346         * hppa-tdep.c, * i386-cygwin-tdep.c, * i386-fbsd-tdep.c,
2347         * i386-linux-tdep.c, * jit.c, * linux-tdep.c, * machoread.c,
2348         * maint.c, * mdebugread.c, * minidebug.c, * mips-linux-tdep.c,
2349         * mips-sde-tdep.c, * mips-tdep.c, * mipsread.c, * nto-tdep.c,
2350         * objfiles.c, * objfiles.h, * osabi.c, * ppc-linux-tdep.c,
2351         * ppc64-tdep.c, * record-btrace.c, * record-full.c, * remote.c,
2352         * rs6000-aix-tdep.c, * rs6000-tdep.c, * s390-linux-tdep.c,
2353         * s390-tdep.c, * solib-aix.c, * solib-dsbt.c, * solib-frv.c,
2354         * solib-spu.c, * solib-svr4.c, * solib-target.c,
2355         * spu-linux-nat.c, * spu-tdep.c, * symfile-mem.c, * symfile.c,
2356         * symmisc.c, * symtab.c, * target.c, * windows-nat.c,
2357         * xcoffread.c, * cli/cli-dump.c, * compile/compile-object-load.c,
2358         * mi/mi-interp.c: Update throughout for bfd section macro and
2359         function changes.
2360         * gcore (gcore_create_callback): Use bfd_set_section_lma.
2361         * spu-tdep.c (spu_overlay_new_objfile): Likewise.
2362
2363 2019-09-18  Tom Tromey  <tom@tromey.com>
2364
2365         * NEWS: Add entry.
2366         * tui/tui.c (tui_initialize_readline): Set name of keymap.  Do not
2367         call rl_initialize.
2368         (tui_enable): Do not call rl_initialize.
2369
2370 2019-09-18  Christian Groessler  <chris@groessler.org>
2371
2372         * alpha-linux-nat.c: Include gdbarch.h.
2373
2374 2019-09-18  Simon Marchi  <simon.marchi@polymtl.ca>
2375
2376         * ui-file.c: Include cli/cli-style.h.
2377         (term_cli_styling): Remove cli_styling declaration.
2378
2379 2019-09-18  Alan Modra  <amodra@gmail.com>
2380
2381         * arm-tdep.c (arm_record_special_symbol): Update bfd_get_section
2382         to bfd_asymbol_section.
2383
2384 2019-09-18  Alan Modra  <amodra@gmail.com>
2385
2386         * amd64-dicos-tdep.c (amd64_dicos_osabi_sniffer): Constify target.
2387         * i386-cygwin-tdep.c (i386_cygwin_init_abi): Likewise.
2388         * i386-dicos-tdep.c (i386_dicos_osabi_sniffer): Likewise.
2389
2390 2019-09-18  Alan Modra  <amodra@gmail.com>
2391
2392         * solib-spu.c (spu_bfd_open): Use bfd_set_filename.
2393         * spu-linux-nat.c (spu_bfd_open): Likewise.
2394
2395 2019-09-18  Christian Biesinger  <cbiesinger@google.com>
2396
2397         * dwarf2loc.c: Change extern declaration of dwarf_always_disassemble
2398         to bool to match definition in dwarf2read.c.
2399
2400 2019-09-17  Christian Biesinger  <cbiesinger@google.com>
2401
2402         * ada-lang.c (ada_ignore_descriptive_types_p): Change to bool.
2403         (print_signatures): Likewise.
2404         (trust_pad_over_xvs): Likewise.
2405         * arch/aarch64-insn.c (aarch64_debug): Likewise.
2406         * arch/aarch64-insn.h (aarch64_debug): Likewise.
2407         * arm-linux-nat.c (arm_apcs_32): Likewise.
2408         * arm-linux-tdep.c (arm_apcs_32): Likewise.
2409         * arm-nbsd-nat.c (arm_apcs_32): Likewise.
2410         * arm-tdep.c (arm_debug): Likewise.
2411         (arm_apcs_32): Likewise.
2412         * auto-load.c (debug_auto_load): Likewise.
2413         (auto_load_gdb_scripts): Likewise.
2414         (global_auto_load): Likewise.
2415         (auto_load_local_gdbinit): Likewise.
2416         (auto_load_local_gdbinit_loaded): Likewise.
2417         * auto-load.h (global_auto_load): Likewise.
2418         (auto_load_local_gdbinit): Likewise.
2419         (auto_load_local_gdbinit_loaded): Likewise.
2420         * breakpoint.c (disconnected_dprintf): Likewise.
2421         (breakpoint_proceeded): Likewise.
2422         (automatic_hardware_breakpoints): Likewise.
2423         (always_inserted_mode): Likewise.
2424         (target_exact_watchpoints): Likewise.
2425         (_initialize_breakpoint): Update.
2426         * breakpoint.h (target_exact_watchpoints): Change to bool.
2427         * btrace.c (maint_btrace_pt_skip_pad): Likewise.
2428         * cli/cli-cmds.c (trace_commands): Likewise.
2429         * cli/cli-cmds.h (trace_commands): Likewise.
2430         * cli/cli-decode.c (add_setshow_boolean_cmd): Change int* argument
2431         to bool*.
2432         * cli/cli-logging.c (logging_overwrite): Change to bool.
2433         (logging_redirect): Likewise.
2434         (debug_redirect): Likewise.
2435         * cli/cli-option.h (option_def) <boolean>: Change return type to bool*.
2436         (struct boolean_option_def) <get_var_address_cb_>: Change return type
2437         to bool.
2438         <boolean_option_def>: Update.
2439         (struct flag_option_def): Change default type of Context to bool
2440         from int.
2441         <flag_option_def>: Change return type of var_address_cb_ to bool*.
2442         * cli/cli-setshow.c (do_set_command): Cast to bool* instead of int*.
2443         (get_setshow_command_value_string): Likewise.
2444         * cli/cli-style.c (cli_styling): Change to bool.
2445         (source_styling): Likewise.
2446         * cli/cli-style.h (source_styling): Likewise.
2447         (cli_styling): Likewise.
2448         * cli/cli-utils.h (struct qcs_flags) <quiet, cont, silent>: Change
2449         to bool.
2450         * command.h (var_types): Update comment.
2451         (add_setshow_boolean_cmd): Change int* var argument to bool*.
2452         * compile/compile-cplus-types.c (debug_compile_cplus_types): Change to
2453         bool.
2454         (debug_compile_cplus_scopes): Likewise.
2455         * compile/compile-internal.h (compile_debug): Likewise.
2456         * compile/compile.c (compile_debug): Likewise.
2457         (struct compile_options) <raw>: Likewise.
2458         * cp-support.c (catch_demangler_crashes): Likewise.
2459         * cris-tdep.c (usr_cmd_cris_version_valid): Likewise.
2460         (usr_cmd_cris_dwarf2_cfi): Likewise.
2461         * csky-tdep.c (csky_debug): Likewise.
2462         * darwin-nat.c (enable_mach_exceptions): Likewise.
2463         * dcache.c (dcache_enabled_p): Likewise.
2464         * defs.h (info_verbose): Likewise.
2465         * demangle.c (demangle): Likewise.
2466         (asm_demangle): Likewise.
2467         * dwarf-index-cache.c (debug_index_cache): Likewise.
2468         * dwarf2-frame.c (dwarf2_frame_unwinders_enabled_p): Likewise.
2469         * dwarf2-frame.h (dwarf2_frame_unwinders_enabled_p): Likewise.
2470         * dwarf2read.c (check_physname): Likewise.
2471         (use_deprecated_index_sections): Likewise.
2472         (dwarf_always_disassemble): Likewise.
2473         * eval.c (overload_resolution): Likewise.
2474         * event-top.c (set_editing_cmd_var): Likewise.
2475         (exec_done_display_p): Likewise.
2476         * event-top.h (set_editing_cmd_var): Likewise.
2477         (exec_done_display_p): Likewise.
2478         * exec.c (write_files): Likewise.
2479         * fbsd-nat.c (debug_fbsd_lwp): Likewise
2480         (debug_fbsd_nat): Likewise.
2481         * frame.h (struct frame_print_options) <print_raw_frame_arguments>:
2482         Likewise.
2483         (struct set_backtrace_options) <backtrace_past_main>: Likewise.
2484         <backtrace_past_entry> Likewise.
2485         * gdb-demangle.h (demangle): Likewise.
2486         (asm_demangle): Likewise.
2487         * gdb_bfd.c (bfd_sharing): Likewise.
2488         * gdbcore.h (write_files): Likewise.
2489         * gdbsupport/common-debug.c (show_debug_regs): Likewise.
2490         * gdbsupport/common-debug.h (show_debug_regs): Likewise.
2491         * gdbthread.h (print_thread_events): Likewise.
2492         * gdbtypes.c (opaque_type_resolution): Likewise.
2493         (strict_type_checking): Likewise.
2494         * gnu-nat.c (gnu_debug_flag): Likewise.
2495         * guile/scm-auto-load.c (auto_load_guile_scripts): Likewise.
2496         * guile/scm-param.c (pascm_variable): Add boolval.
2497         (add_setshow_generic): Update.
2498         (pascm_param_value): Update.
2499         (pascm_set_param_value_x): Update.
2500         * hppa-tdep.c (hppa_debug): Change to bool..
2501         * infcall.c (may_call_functions_p): Likewise.
2502         (coerce_float_to_double_p): Likewise.
2503         (unwind_on_signal_p): Likewise.
2504         (unwind_on_terminating_exception_p): Likewise.
2505         * infcmd.c (startup_with_shell): Likewise.
2506         * inferior.c (print_inferior_events): Likewise.
2507         * inferior.h (startup_with_shell): Likewise.
2508         (print_inferior_events): Likewise.
2509         * infrun.c (step_stop_if_no_debug): Likewise.
2510         (detach_fork): Likewise.
2511         (debug_displaced): Likewise.
2512         (disable_randomization): Likewise.
2513         (non_stop): Likewise.
2514         (non_stop_1): Likewise.
2515         (observer_mode): Likewise.
2516         (observer_mode_1): Likewise.
2517         (set_observer_mode): Update.
2518         (sched_multi): Change to bool.
2519         * infrun.h (debug_displaced): Likewise.
2520         (sched_multi): Likewise.
2521         (step_stop_if_no_debug): Likewise.
2522         (non_stop): Likewise.
2523         (disable_randomization): Likewise.
2524         * linux-tdep.c (use_coredump_filter): Likewise.
2525         (dump_excluded_mappings): Likewise.
2526         * linux-thread-db.c (auto_load_thread_db): Likewise.
2527         (check_thread_db_on_load): Likewise.
2528         * main.c (captured_main_1): Update.
2529         * maint-test-options.c (struct test_options_opts) <flag_opt, xx1_opt,
2530         xx2_opt, boolean_opt>: Change to bool.
2531         * maint-test-settings.c (maintenance_test_settings_boolean): Likewise.
2532         * maint.c (maintenance_profile_p): Likewise.
2533         (per_command_time): Likewise.
2534         (per_command_space): Likewise.
2535         (per_command_symtab): Likewise.
2536         * memattr.c (inaccessible_by_default): Likewise.
2537         * mi/mi-main.c (mi_async): Likewise.
2538         (mi_async_1): Likewise.
2539         * mips-tdep.c (mips64_transfers_32bit_regs_p): Likewise.
2540         * nat/fork-inferior.h (startup_with_shell): Likewise.
2541         * nat/linux-namespaces.c (debug_linux_namespaces): Likewise.
2542         * nat/linux-namespaces.h (debug_linux_namespaces): Likewise.
2543         * nios2-tdep.c (nios2_debug): Likewise.
2544         * or1k-tdep.c (or1k_debug): Likewise.
2545         * parse.c (parser_debug): Likewise.
2546         * parser-defs.h (parser_debug): Likewise.
2547         * printcmd.c (print_symbol_filename): Likewise.
2548         * proc-api.c (procfs_trace): Likewise.
2549         * python/py-auto-load.c (auto_load_python_scripts): Likewise.
2550         * python/py-param.c (union parmpy_variable): Add "bool boolval" field.
2551         (set_parameter_value): Update.
2552         (add_setshow_generic): Update.
2553         * python/py-value.c (copy_py_bool_obj): Change argument from int*
2554         to bool*.
2555         * python/python.c (gdbpy_parameter_value): Cast to bool* instead of
2556         int*.
2557         * ravenscar-thread.c (ravenscar_task_support): Change to bool.
2558         * record-btrace.c (record_btrace_target::store_registers): Update.
2559         * record-full.c (record_full_memory_query): Change to bool.
2560         (record_full_stop_at_limit): Likewise.
2561         * record-full.h (record_full_memory_query): Likewise.
2562         * remote-notif.c (notif_debug): Likewise.
2563         * remote-notif.h (notif_debug): Likewise.
2564         * remote.c (use_range_stepping): Likewise.
2565         (interrupt_on_connect): Likewise.
2566         (remote_break): Likewise.
2567         * ser-tcp.c (tcp_auto_retry): Likewise.
2568         * ser-unix.c (serial_hwflow): Likewise.
2569         * skip.c (debug_skip): Likewise.
2570         * solib-aix.c (solib_aix_debug): Likewise.
2571         * spu-tdep.c (spu_stop_on_load_p): Likewise.
2572         (spu_auto_flush_cache_p): Likewise.
2573         * stack.c (struct backtrace_cmd_options) <full, no_filters, hide>:
2574         Likewise.
2575         (struct info_print_options) <quiet>: Likewise.
2576         * symfile-debug.c (debug_symfile): Likewise.
2577         * symfile.c (auto_solib_add): Likewise.
2578         (separate_debug_file_debug): Likewise.
2579         * symfile.h (auto_solib_add): Likewise.
2580         (separate_debug_file_debug): Likewise.
2581         * symtab.c (basenames_may_differ): Likewise.
2582         (struct filename_partial_match_opts) <dirname, basename>: Likewise.
2583         (struct info_print_options) <quiet, exclude_minsyms>: Likewise.
2584         (struct info_types_options) <quiet>: Likewise.
2585         * symtab.h (demangle): Likewise.
2586         (basenames_may_differ): Likewise.
2587         * target-dcache.c (stack_cache_enabled_1): Likewise.
2588         (code_cache_enabled_1): Likewise.
2589         * target.c (trust_readonly): Likewise.
2590         (may_write_registers): Likewise.
2591         (may_write_memory): Likewise.
2592         (may_insert_breakpoints): Likewise.
2593         (may_insert_tracepoints): Likewise.
2594         (may_insert_fast_tracepoints): Likewise.
2595         (may_stop): Likewise.
2596         (auto_connect_native_target): Likewise.
2597         (target_stop_and_wait): Update.
2598         (target_async_permitted): Change to bool.
2599         (target_async_permitted_1): Likewise.
2600         (may_write_registers_1): Likewise.
2601         (may_write_memory_1): Likewise.
2602         (may_insert_breakpoints_1): Likewise.
2603         (may_insert_tracepoints_1): Likewise.
2604         (may_insert_fast_tracepoints_1): Likewise.
2605         (may_stop_1): Likewise.
2606         * target.h (target_async_permitted): Likewise.
2607         (may_write_registers): Likewise.
2608         (may_write_memory): Likewise.
2609         (may_insert_breakpoints): Likewise.
2610         (may_insert_tracepoints): Likewise.
2611         (may_insert_fast_tracepoints): Likewise.
2612         (may_stop): Likewise.
2613         * thread.c (struct info_threads_opts) <show_global_ids>: Likewise.
2614         (make_thread_apply_all_options_def_group): Change argument from int*
2615         to bool*.
2616         (thread_apply_all_command): Update.
2617         (print_thread_events): Change to bool.
2618         * top.c (confirm): Likewise.
2619         (command_editing_p): Likewise.
2620         (history_expansion_p): Likewise.
2621         (write_history_p): Likewise.
2622         (info_verbose): Likewise.
2623         * top.h (confirm): Likewise.
2624         (history_expansion_p): Likewise.
2625         * tracepoint.c (disconnected_tracing): Likewise.
2626         (circular_trace_buffer): Likewise.
2627         * typeprint.c (print_methods): Likewise.
2628         (print_typedefs): Likewise.
2629         * utils.c (debug_timestamp): Likewise.
2630         (sevenbit_strings): Likewise.
2631         (pagination_enabled): Likewise.
2632         * utils.h (sevenbit_strings): Likewise.
2633         (pagination_enabled): Likewise.
2634         * valops.c (overload_resolution): Likewise.
2635         * valprint.h (struct value_print_options) <prettyformat_arrays,
2636         prettyformat_structs, vtblprint, unionprint, addressprint, objectprint,
2637         stop_print_at_null, print_array_indexes, deref_ref, static_field_print,
2638         pascal_static_field_print, raw, summary, symbol_print, finish_print>:
2639         Likewise.
2640         * windows-nat.c (new_console): Likewise.
2641         (cygwin_exceptions): Likewise.
2642         (new_group): Likewise.
2643         (debug_exec): Likewise.
2644         (debug_events): Likewise.
2645         (debug_memory): Likewise.
2646         (debug_exceptions): Likewise.
2647         (useshell): Likewise.
2648         * windows-tdep.c (maint_display_all_tib): Likewise.
2649         * xml-support.c (debug_xml): Likewise.
2650
2651 2019-09-17  Mike Gulick  <mgulick@mathworks.com>
2652
2653         * source.c (prepare_path_for_appending): New function.
2654         (openp): Make use of new function.
2655         (find_and_open_source): Search for the compilation directory and
2656         source file as a relative path beneath the directory search path.
2657
2658 2019-09-17  Andrew Burgess  <andrew.burgess@embecosm.com>
2659
2660         * source-cache.c (source_cache::get_line_charpos): Catch
2661         exceptions and return false, this matches the behaviour documented
2662         in the header file.
2663
2664 2019-09-17  Joel Brobecker  <brobecker@adacore.com>
2665
2666         * ada-tasks.c (info_task): Remove quoting of the task's name.
2667
2668 2019-09-16  Christian Biesinger  <cbiesinger@google.com>
2669
2670         * symfile.c (auto_solib_add): Replace comment with a reference
2671         to the header file.
2672
2673 2019-09-14  Christian Biesinger  <cbiesinger@google.com>
2674
2675         * NEWS: Mention that gdb can now be compiled with Python 3
2676         on Windows.
2677
2678 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2679
2680         * maint.c (maint_print_section_data::maint_print_section_data):
2681         Force use of 'float log10 (float)' by casting the argument to
2682         float.
2683
2684 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2685
2686         * maint.c: Add 'cmath' include.
2687         (struct maint_print_section_data): New structure.
2688         (print_section_index): New function.
2689         (print_bfd_section_info): Add header comment, small whitespace
2690         cleanup, and update to call new print_section_index function.
2691         (print_objfile_section_info): Likewise.
2692         (maint_obj_section_from_bfd_section): New function.
2693         (print_bfd_section_info_maybe_relocated): New function.
2694         (maintenance_info_sections): Add header comment, always use
2695         bfd_map_over_sections instead of ALL_OBJFILE_OSECTIONS.
2696
2697 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2698
2699         * psymtab.c (find_pc_sect_psymtab): Move baseaddr local into more
2700         inner scope, add check that the objfile has psymtabs before
2701         checking psymtabs_addrmap.
2702         * psymtab.h (psymtab_storage) <psymtabs_addrmap>: Extend comment.
2703
2704 2019-09-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2705
2706         * NEWS: Announce that Ada task names are now shown at more places,
2707         and between quotes (except in info task output).
2708         * gdb/ada-tasks.c (task_to_str): New function.
2709         (display_current_task_id): Call task_to_str.
2710         (task_command_1): Likewise.
2711         (print_ada_task_info): In non-mi mode, Properly align headers and data
2712         when task-id length is > 9 (9 is the default for a 32 bits CORE_ADDR).
2713
2714 2019-09-12  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
2715
2716         * procfs.c (procfs_target::wait) <PR_FAULTED>: Get signal from
2717         prstatus.pr_lwp.pr_info instead of making it up.
2718
2719 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
2720
2721         * auto-load.c (auto_load_expand_dir_vars): Update.
2722         * defs.h (gdb_datadir): Change to std::string.
2723         (python_libdir): Likewise.
2724         (relocate_gdb_directory): Change return type to std::string.
2725         * guile/guile.c (gdbscm_data_directory): Update.
2726         (initialize_scheme_side): Update.
2727         * jit.c (jit_reader_dir): Change to std::string.
2728         (jit_reader_load_command): Update.
2729         * main.c (gdb_datadir): Change to std::string.
2730         (python_libdir): Likewise.
2731         (set_gdb_data_directory): Update.
2732         (relocate_path): Change to return std::string.
2733         (relocate_gdb_directory): Change to return std::string.
2734         (relocate_gdbinit_path_maybe_in_datadir): Update.
2735         (captured_main_1): Update.
2736         * python/python.c (do_start_initialization): Update.
2737         * top.c (show_gdb_datadir): Update.
2738         * xml-syscall.c (xml_init_syscalls_info): Update.
2739         (init_syscalls_info): Update.
2740
2741 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
2742
2743         * main.c (relocate_gdbinit_path_maybe_in_datadir): Factor this code
2744         out of get_init_files.
2745         (get_init_files): Update.
2746
2747 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
2748
2749         * main.c (get_init_files): Change to use std::string.
2750         (captured_main_1): Update.
2751         (print_gdb_help): Update.
2752
2753 2019-09-11  Ali Tamur  <tamur@google.com>
2754
2755         *gdb/target-float.c (host_float_ops<T>::to_longest): Update
2756         implementation.
2757
2758 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
2759
2760         * dbxread.c (read_dbx_symtab): Update.
2761         * dwarf2read.c (load_partial_dies): Update.
2762         * mdebugread.c (parse_partial_symbols): Update.
2763         (handle_psymbol_enumerators): Update.
2764         * psympriv.h (add_psymbol_to_list): Change type of copy_names to bool.
2765         * psymtab.c (add_psymbol_to_bcache): Likewise.
2766         (add_psymbol_to_list): Likewise.
2767         * symtab.c (symbol_set_names): Likewise.
2768         * symtab.h (symbol_set_names): Likewise.
2769         * xcoffread.c (scan_xcoff_symtab): Update.
2770
2771 2019-09-11  Tom Tromey  <tom@tromey.com>
2772
2773         * symfile-mem.c (symbol_file_add_from_memory): Use
2774         bfd_set_filename.
2775         * solib-darwin.c (darwin_bfd_open): Use bfd_set_filename.
2776         * solib-aix.c (solib_aix_bfd_open): Use bfd_set_filename.
2777
2778 2019-09-10  Tom Tromey  <tromey@adacore.com>
2779
2780         * dwarf-index-write.c (write_psymbols): Extend error message.
2781         (debug_names::insert): Add Ada code.
2782         (debug_names::write_psymbols): Remove Ada check.
2783         (debug_names) <m_string_obstack>: New member.
2784         * dwarf2read.c (gdb_index_symbol_name_matcher): Remove.
2785         (gdb_index_symbol_name_matcher::matches): Remove.
2786         (mapped_index_base::find_name_components_bounds): Add "lang"
2787         parameter.
2788         (mapped_index_base::build_name_components): Also split names
2789         according to Ada syntax.
2790         (dw2_expand_symtabs_matching_symbol): Loop over languages.  Change
2791         type of "match_callback".
2792         (check_match, check_find_bounds_finds)
2793         (dw2_expand_symtabs_matching): Update.
2794         (dw2_debug_names_iterator): Add new constructor.
2795         (dw2_debug_names_map_matching_symbols): New function.
2796         (dw2_debug_names_expand_symtabs_matching): Update.
2797         (dwarf2_debug_names_functions): Use
2798         dw2_debug_names_map_matching_symbols.
2799
2800 2019-09-10  Tom Tromey  <tromey@adacore.com>
2801
2802         * dwarf2read.c (dw2_get_file_names_reader): Add the
2803         CU's file name to the results.
2804
2805 2019-09-10  Tom Tromey  <tromey@adacore.com>
2806
2807         * ada-lang.c (add_nonlocal_symbols): Combine calls to
2808         map_matching_symbols.  Update.
2809         * dwarf2read.c (dw2_map_matching_symbols): Update.
2810         * psymtab.c (match_partial_symbol): Change type; update.
2811         (psym_map_matching_symbols): Likewise.
2812         * symfile-debug.c (debug_qf_map_matching_symbols): Change
2813         type; update.
2814         * symfile.h (struct quick_symbol_functions)
2815         <map_matching_symbols>: Change "name" to be a lookup_name_info.
2816         Remove "match".
2817
2818 2019-09-10  Tom Tromey  <tromey@adacore.com>
2819
2820         * psymtab.c (map_block): Remove.
2821         (psym_map_matching_symbols): Use iterate_over_symbols_terminated.
2822         * symtab.c (iterate_over_symbols_terminated): New function.
2823         * symtab.c (iterate_over_symbols_terminated): Declare.
2824
2825 2019-09-10  Tom Tromey  <tromey@adacore.com>
2826
2827         * ada-lang.c (ada_iterate_over_symbols): Return bool.
2828         * language.h (struct language_defn) <la_iterate_over_symbols>:
2829         Return bool.
2830         * symtab.c (iterate_over_symbols): Return bool.
2831         * symtab.h (iterate_over_symbols): Return bool.
2832
2833 2019-09-10  Tom Tromey  <tromey@adacore.com>
2834
2835         * ada-lang.c (aux_add_nonlocal_symbols): Change type.
2836         (add_nonlocal_symbols): Update.
2837         * dwarf2read.c (dw2_map_matching_symbols): Change type.
2838         * psymtab.c (map_block, psym_map_matching_symbols): Change type.
2839         * symfile-debug.c (debug_qf_map_matching_symbols): Change type.
2840         * symfile.h (struct quick_symbol_functions) <map_matching_symbols>:
2841         Change type of "callback".  Remove "data".
2842
2843
2844 2019-09-09  Ali Tamur  <tamur@google.com>
2845
2846         * dwarf2read.c (comp_unit_head): Update comment.
2847         (dwarf2_dwo_name): New function declaration.
2848         (dwarf_unit_type_name): New function declaration.
2849         (read_comp_unit_head): Add support for new compilation units,
2850         DW_UT_partial, DW_UT_skeleton, DW_UT_split_compile, DW_UT_split_type.
2851         Particularly, DW_UT_skeleton and DW_UT_split_compile have dwo_id
2852         (currently named as "signature") in their header. Also clarify error
2853         messages.
2854         (lookup_dwo_id): New function. Returns the dwo id of the given
2855         compile unit.
2856         (lookup_dwo_unit): Use the new lookup_dwo_id function.
2857         (init_cutu_and_read_dies): Use the new dwarf2_dwo_name and lookup_dwo_id
2858         functions.
2859         (create_dwo_cu_reader): Use the added lookup_dwo_id function.
2860         (dwarf2_dwo_name): Get the dwo name if present.
2861         (dwarf_unit_type_name): Convert DW_UT_* types to string for diagnostic
2862         purposes.
2863
2864 2019-09-09  Tom Tromey  <tom@tromey.com>
2865
2866         * tui/tui-win.c (tui_all_windows_info): Use ui_out.
2867
2868 2019-09-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2869
2870         * python/python.c (do_start_initialization): Make progname_copy static,
2871         to avoid a leak report.
2872
2873 2019-09-08  Tom Tromey  <tom@tromey.com>
2874
2875         * tui/tui-wingeneral.c (box_win): Truncate long window titles.
2876
2877 2019-09-07  Simon Marchi  <simon.marchi@efficios.com>
2878
2879         * dwarf2read.c (struct dw2_symtab_iterator) <block_index>:
2880         Change type to gdb::optional<block_enum>.
2881         (dw2_symtab_iter_init): Change block_index parameter type
2882         to gdb::optional<block_enum>.
2883         (dw2_lookup_symbol): Change block_index parameter
2884         type to block_enum.c
2885         (dw2_debug_names_lookup_symbol): Likewise.
2886         * psymtab.c (psym_lookup_symbol): Likewise.
2887         * symfile-debug.c (debug_qf_lookup_symbol): Likewise.
2888         * symfile.h (struct quick_symbol_functions) <lookup_symbol>:
2889         Likewise.
2890
2891 2019-09-06  Christian Biesinger  <cbiesinger@google.com>
2892
2893         * defs.h (relocate_gdb_directory): Change int to bool in
2894         signature and rename flag to relocatable.
2895         * main.c (relocate_path): Likewise.
2896         (relocate_gdb_directory): Likewise.
2897
2898 2019-09-06  Alan Modra  <amodra@gmail.com>
2899
2900         * coffread.c (coff_symfile_read): Constify filename variable.
2901         * dbxread.c (dbx_symfile_init, coffstab_build_psymtabs),
2902         (elfstab_build_psymtabs, stabsect_build_psymtabs): Likewise.
2903         * gdb_bfd.c (gdb_bfd_close_or_warn): Likewise.
2904         * solib.c (reload_shared_libraries_1): Likewise.
2905         * symfile.c (reread_symbols): Likewise.
2906         * solib-aix.c (solib_aix_bfd_open): Add cast for xfree of filename.
2907         * solib-darwin.c (darwin_bfd_open): Likewise.
2908         * symfile-mem.c (symbol_file_add_from_memory): Likewise.
2909
2910 2019-09-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2911
2912         * psymtab.c (print_partial_symbols): Handle missing domain_enum
2913         values MODULE_DOMAIN and COMMON_BLOCK_DOMAIN.
2914
2915 2019-09-03  Tom Tromey  <tromey@adacore.com>
2916
2917         * ada-valprint.c (ada_val_print_num): Don't recurse for range
2918         types.
2919         (has_negatives): Unbias a range type bound.
2920         * dwarf2read.c (read_subrange_type): Handle DW_AT_GNU_bias.
2921         * gdbtypes.c (operator==): Handle new field.
2922         (create_range_type): Add "bias" parameter.
2923         (create_static_range_type, resolve_dynamic_range): Update.
2924         * gdbtypes.h (struct range_bounds) <bias>: New member.
2925         (create_range_type): Add bias parameter.
2926         * printcmd.c (print_scalar_formatted): Unbias range types.
2927         * value.c (unpack_long): Unbias range types.
2928         (pack_long): Bias range types.
2929
2930 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
2931
2932         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Check all
2933         probe arguments.
2934
2935 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
2936
2937         * break-catch-throw.c (fetch_probe_arguments): Use gdbarch.
2938         * dtrace-probe.c (dtrace_probe::get_argument_count): Likewise.
2939         * probe.c (probe_safe_evaluate_at_pc) (compute_probe_arg)
2940         (compile_probe_arg): Likewise.
2941         * probe.h (get_argument_count): Likewise.
2942         * solib-svr4.c (solib_event_probe_action): Likewise.
2943         * stap-probe.c (stap_probe::get_argument_count): Likewise.
2944
2945 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
2946
2947         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Move
2948         code to here...
2949         (svr4_create_solib_event_breakpoints): ...from here.
2950
2951 2019-08-30  Sergio Durigan Junior  <sergiodj@redhat.com>
2952
2953         * nat/fork-inferior.c (trace_start_error): Remove "\nError: "
2954         suffix from warning message.
2955
2956 2019-08-30  Tom Tromey  <tom@tromey.com>
2957
2958         * tui/tui-winsource.h (struct tui_source_window_base)
2959         <refresh_all>: Don't declare.
2960         * tui/tui-winsource.c (tui_source_window_base::refresh_all):
2961         Remove.
2962         * tui/tui-win.c (tui_refresh_all_win): Don't call refresh_all or
2963         tui_show_locator_content.
2964         * tui/tui-regs.h (struct tui_data_window) <refresh_all>: Don't
2965         declare.
2966         * tui/tui-regs.c (tui_data_window::refresh_all): Remove.
2967         * tui/tui-data.h (struct tui_win_info) <refresh_all>: Don't
2968         declare.
2969
2970 2019-08-30  Tom Tromey  <tom@tromey.com>
2971
2972         * tui/tui-io.c (tui_cont_sig): Don't call wrefresh.
2973
2974 2019-08-30  Tom Tromey  <tom@tromey.com>
2975
2976         * tui/tui-stack.c (_initialize_tui_stack): Move later.
2977         Remove unnecessary forward declarations.
2978
2979 2019-08-30  Tom Tromey  <tom@tromey.com>
2980
2981         * tui/tui-stack.c (tui_locator_window::set_locator_fullname): Call
2982         rerender.
2983         (tui_update_locator_fullname, tui_show_frame_info): Don't call
2984         tui_show_locator_content.
2985
2986 2019-08-30  Tom Tromey  <tom@tromey.com>
2987
2988         * tui/tui-stack.c (tui_show_locator_content): Move lower.  Rewrite.
2989         (tui_locator_window::rerender): Rewrite using body of previous
2990         tui_show_locator_content.
2991
2992 2019-08-30  Tom Tromey  <tom@tromey.com>
2993
2994         * tui/tui-stack.h (struct tui_locator_window) <set_locator_info,
2995         set_locator_fullname>: New methods.
2996         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
2997         Rename from tui_set_locator_fullname.
2998         (tui_locator_window::set_locator_info): Rename from
2999         tui_set_locator_info.  Return bool.
3000         (tui_update_locator_fullname, tui_show_frame_info): Update.
3001
3002 2019-08-30  Tom Tromey  <tom@tromey.com>
3003
3004         * tui/tui-layout.c (show_layout): Don't call tui_refresh_all.
3005
3006 2019-08-30  Tom Tromey  <tom@tromey.com>
3007
3008         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Don't
3009         call touchwin.
3010
3011 2019-08-30  Tom Tromey  <tom@tromey.com>
3012
3013         * tui/tui-wingeneral.c (box_win): Assume win_info and
3014         win_info->handle cannot be NULL.
3015
3016 2019-08-30  Tom Tromey  <tom@tromey.com>
3017
3018         * tui/tui-regs.h (struct tui_data_item_window) <rerender,
3019         refresh_window>: Declare.
3020         * tui/tui-regs.c (tui_data_window::display_registers_from): Call
3021         resize.
3022         (tui_data_item_window::rerender): Rename from
3023         tui_display_register.
3024         (tui_data_item_window::refresh_window): New method.
3025         * tui/tui-layout.c (tui_gen_win_info::resize): Do nothing on
3026         no-op.
3027
3028 2019-08-30  Tom Tromey  <tom@tromey.com>
3029
3030         * tui/tui-regs.h (struct tui_data_window) <regs_content,
3031         regs_column_count, current_group>: Move later.  Now private.
3032         <get_current_group>: New method.
3033         * tui/tui-regs.c (tui_reg_command): Update.
3034         * tui/tui-layout.c (tui_set_layout): Update.
3035
3036 2019-08-30  Tom Tromey  <tom@tromey.com>
3037
3038         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
3039         (tui_data_window::rerender): Don't call
3040         check_and_display_highlight_if_needed.
3041         (tui_data_window::refresh_all): Remove call to
3042         erase_data_content.
3043
3044 2019-08-30  Tom Tromey  <tom@tromey.com>
3045
3046         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
3047         (tui_data_window::display_registers_from)
3048         (tui_data_window::display_reg_element_at_line)
3049         (tui_data_window::display_registers_from_line): Remove checks of
3050         "empty".
3051
3052 2019-08-30  Tom Tromey  <tom@tromey.com>
3053
3054         * tui/tui-regs.h (struct tui_data_window) <display_all_data>:
3055         Don't declare.
3056         * tui/tui-regs.c (tui_data_window::show_registers): Call
3057         rerender.
3058         (tui_data_window::rerender): Rename from display_all_data.
3059         (tui_data_window::rerender): Remove old implementation.
3060
3061 2019-08-30  Tom Tromey  <tom@tromey.com>
3062
3063         * tui/tui-regs.c (tui_data_window::display_all_data): Change
3064         text.
3065         * tui/tui-data.h (NO_DATA_STRING): Remove define.
3066
3067 2019-08-29  Bernhard Wodok  <barto@gmx.net>
3068             Sergio Durigan Junior  <sergiodj@redhat.com>
3069
3070         PR win32/24284
3071         * mingw-hdep.c (gdb_select): Handle case when 'n' is zero.
3072
3073 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
3074
3075         * symtab.c (search_symbols): Don't include MODULE_DOMAIN symbols
3076         when searching for types.
3077
3078 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
3079
3080         * f-lang.c (f_language_defn): Use f_print_typedef.
3081         * f-lang.h (f_print_typedef): Declare.
3082         * f-typeprint.c (f_print_typedef): Define.
3083
3084 2019-08-27  Christian Biesinger  <cbiesinger@google.com>
3085
3086         * nat/linux-namespaces.c (mnsh_main): Initialize fd (to -1).
3087
3088 2019-08-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3089
3090         * cli/cli-utils.c (info_print_options_defs): Delete.
3091         (make_info_print_options_def_group): Delete.
3092         (extract_info_print_options): Delete.
3093         (info_print_command_completer): Delete.
3094         (info_print_args_help): Add extra parameter, and optionally
3095         include text about -n flag.
3096         * cli/cli-utils.h (struct info_print_options): Delete.
3097         (extract_info_print_options): Delete declaration.
3098         (info_print_command_completer): Delete declaration.
3099         (info_print_args_help): Add extra parameter, extend header
3100         comment.
3101         * python/python.c (gdbpy_rbreak): Pass additional parameter to
3102         search_symbols.
3103         * stack.c (struct info_print_options): New type.
3104         (info_print_options_defs): New file scoped variable.
3105         (make_info_print_options_def_group): New static function.
3106         (info_print_command_completer): New static function.
3107         (info_locals_command): Update to use new local functions.
3108         (info_args_command): Likewise.
3109         (_initialize_stack): Add extra parameter to calls to
3110         info_print_args_help.
3111         * symtab.c (search_symbols): Add extra parameter, use this to
3112         possibly excluse non-debug symbols.
3113         (symtab_symbol_info): Add extra parameter, which is passed on to
3114         search_symbols.
3115         (struct info_print_options): New type.
3116         (info_print_options_defs): New file scoped variable.
3117         (make_info_print_options_def_group): New static function.
3118         (info_print_command_completer): New static function.
3119         (info_variables_command): Update to use local functions, and pass
3120         extra parameter through to symtab_symbol_info.
3121         (info_functions_command): Likewise.
3122         (info_types_command): Pass additional argument through to
3123         symtab_symbol_info.
3124         (rbreak_command): Pass extra argument to search_symbols.
3125         (_initialize_symtab): Add extra arguments for calls to
3126         info_print_args_help, and update help text for 'info variables',
3127         'whereis', and 'info functions' commands.
3128         * symtab.h (search_symbols): Add extra argument to declaration.
3129         * NEWS: Mention new flags.
3130
3131 2019-08-26  Christian Biesinger  <cbiesinger@google.com>
3132
3133         * symtab.c (lookup_static_symbol): Call the new function (and move
3134         it down to be next to lookup_global_symbol).
3135         (struct global_sym_lookup_data): Add block_enum member and rename to...
3136         (struct global_or_static_sym_lookup_data): ...this.
3137         (lookup_symbol_global_iterator_cb): Pass block_index instead of
3138         GLOBAL_BLOCK to lookup_symbol_in_objfile and rename to...
3139         (lookup_symbol_global_or_static_iterator_cb): ...this.
3140         (lookup_global_or_static_symbol): New function.
3141         (lookup_global_symbol): Call new function.
3142
3143 2019-08-26  Tom de Vries  <tdevries@suse.de>
3144
3145         PR c++/24852
3146         * break-catch-throw.c (fetch_probe_arguments): Improve error mesage
3147         when pc_probe.prob == NULL.
3148
3149 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
3150
3151         * dwarf2read.c (dw2_debug_names_iterator::next): Rename local
3152         variable symbol_linkage to symbol_linkage_.
3153
3154 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
3155
3156         * dwarf2read.c (dw2_debug_names_iterator::next): Use enum to
3157         represent whether the symbol is static, dynamic, or we don't
3158         know.
3159
3160 2019-08-25  Yoshinori Sato <ysato@users.sourceforge.jp>
3161
3162         * gdb/rx-tdep.c (rx_register_names): New.
3163         (rx_register_name): Delete.
3164         (rx_psw_type): Delete.
3165         (rx_fpsw_type): Delete.
3166         (rx_register_type): Delete.
3167         (rx_gdbarch_init): Convert target-descriptions.
3168         (_initialize_rx_tdep): Add initialize_tdesc_rx.
3169         * gdb/features/Makefile: Add rx.xml.
3170         * gdb/features/rx.xml: New.
3171         * gdb/features/rx.c: Generated.
3172         * gdb/NEWS: Mention target description support.
3173
3174 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
3175
3176         * symtab.c (symbol_cache_lookup): Always initialize *bsc_ptr and
3177         *slot_ptr.
3178
3179 2019-08-23  Sergio Durigan Junior  <sergiodj@redhat.com>
3180
3181         * configure.ac: Don't check for 'dlfcn.h' (moved to
3182         gdbsupport/common.m4).
3183         * Makefile.in (COMMON_SFILES): Move 'gdb-dlfcn.c' to
3184         'gdbsupport/'.
3185         (HFILES_NO_SRCDIR): Likewise, for 'gdb-dlfcn.h'.
3186         * compile/compile-c-support.c: Include
3187         'gdbsupport/gdb-dlfcn.h'.
3188         * gdbsupport/common.m4: Check for 'dlfcn.h'.
3189         * gdb-dlfcn.c: Move to...
3190         * gdbsupport/gdb-dlfcn.c: ... here.
3191         * gdb-dlfcn.h: Move to...
3192         * gdbsupport/gdb-dlfcn.h: ... here.
3193
3194 2019-08-23  Sandra Loosemore  <sandra@codesourcery.com>
3195
3196         * nios2-tdep.c (struct reg_value): Improve comments.  Make
3197         the offset field signed.
3198
3199 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
3200
3201         * python/lib/gdb/__init__.py (_execute_file): New function.
3202         * python/python.c (python_run_simple_file): Call gdb._execute_file
3203         on Windows.
3204
3205 2019-08-22  Andrew Burgess  <andrew.burgess@embecosm.com>
3206
3207         * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
3208         all uses as this was never set to anything but a zero value.
3209
3210 2019-08-21  Bogdan Harjoc  <harjoc@gmail.com>
3211
3212         * cli/cli-cmds.c (with_command_1): Error out if no arguments.
3213
3214 2019-08-21  Christian Biesinger  <cbiesinger@google.com>
3215
3216         * tui/tui-data.h (tui_gen_win_info): Add an =default
3217         move constructor, required by some GCC versions.
3218
3219 2019-08-21  Jinke Fan  <fanjinke51@yeah.net>
3220
3221         * go32-nat.c (go32_sysinfo): Add hygon_p.
3222
3223 2019-08-20  Tom Tromey  <tom@tromey.com>
3224
3225         * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
3226         line_from_reg_element_no, first_reg_element_no_inline,
3227         display_all_data, delete_data_content_windows,
3228         erase_data_content>: Now private.
3229
3230 2019-08-20  Tom Tromey  <tom@tromey.com>
3231
3232         * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
3233         (tui_unhighlight_win, tui_highlight_win)
3234         (tui_win_info::make_window): Update.
3235         * tui/tui-data.h (HILITE, NO_HILITE): Remove.
3236
3237 2019-08-20  Tom Tromey  <tom@tromey.com>
3238
3239         * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
3240         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
3241         (MAX_PID_WIDTH): Move to tui-stack.c.
3242         * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
3243         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
3244         (MAX_PID_WIDTH): Move from tui-data.h.
3245
3246 2019-08-20  Tom Tromey  <tom@tromey.com>
3247
3248         * tui/tui-wingeneral.h (tui_make_window): Don't declare.
3249         * tui/tui-wingeneral.c (box_win): Change type of win_info.
3250         (box_win): Update.
3251         (tui_gen_win_info::make_window): Rename from tui_make_window.
3252         (tui_win_info::make_window): New method.
3253         (tui_gen_win_info::make_visible): Update.
3254         * tui/tui-source.c (tui_source_window::set_contents): Update.
3255         * tui/tui-regs.c (tui_data_window::show_register_group): Update.
3256         (tui_data_window::display_registers_from): Update.
3257         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
3258         * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
3259         Declare.
3260         <can_box>: Remove.
3261         <title>: Remove.
3262         (struct tui_win_info) <make_window>: Declare.
3263         <can_box>: Now virtual.
3264         <title>: New member.
3265         * tui/tui-data.c (~tui_gen_win_info): Don't free title.
3266         * tui/tui-command.c (tui_cmd_window::resize): Update.
3267
3268 2019-08-20  Tom Tromey  <tom@tromey.com>
3269
3270         * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
3271         * tui/tui-regs.c (tui_data_window::show_registers): Update.
3272         (tui_data_window::check_register_values): Update.
3273
3274 2019-08-20  Tom Tromey  <tom@tromey.com>
3275
3276         * tui/tui-regs.h (struct tui_data_window): Use
3277         DISABLE_COPY_AND_ASSIGN.
3278         <regs_content>: Change type, removing unique_ptr.
3279         <tui_data_window>: Add move constructor.
3280         * tui/tui-regs.c (tui_data_window::show_registers)
3281         (tui_data_window::show_register_group)
3282         (tui_data_window::display_registers_from)
3283         (tui_data_window::display_registers_from)
3284         (tui_data_window::first_data_item_displayed)
3285         (tui_data_window::delete_data_content_windows)
3286         (tui_data_window::rerender, tui_data_window::refresh_window)
3287         (tui_data_window::check_register_values): Update.
3288
3289 2019-08-20  Tom Tromey  <tom@tromey.com>
3290
3291         * tui/tui-regs.h (struct tui_data_window) <show_registers,
3292         show_register_group>: Declare.
3293         (tui_show_register_group): Don't declare.
3294         * tui/tui-regs.c (tui_data_window::show_registers): Rename from
3295         tui_show_registers.
3296         (tui_data_window::show_register_group): Rename from
3297         tui_show_register_group.
3298         (tui_data_window::check_register_values, tui_reg_command):
3299         Update.
3300         * tui/tui-layout.c (tui_set_layout): Update.
3301
3302 2019-08-20  Tom Tromey  <tom@tromey.com>
3303
3304         * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
3305         Declare.
3306         (tui_check_register_values): Don't declare.
3307         * tui/tui-regs.c (tui_data_window::check_register_values): Rename
3308         from tui_check_register_values.
3309         * tui/tui-hooks.c (tui_register_changed): Update.
3310
3311 2019-08-20  Tom Tromey  <tom@tromey.com>
3312
3313         * tui/tui-regs.c (tui_reg_layout): Move later.
3314         (tui_show_registers): Don't enable TUI mode or change layout.
3315
3316 2019-08-20  Tom Tromey  <tom@tromey.com>
3317
3318         * tui/tui-regs.h (struct tui_data_item_window)
3319         <~tui_data_item_window>: Remove.
3320         <content>: Now a unique_xmalloc_ptr.
3321         * tui/tui-regs.c (tui_register_format): Return a
3322         unique_xmalloc_ptr.
3323         (tui_get_register): Update.
3324         (~tui_data_item_window): Remove.
3325         (tui_data_window::display_registers_from, tui_display_register):
3326         Update.
3327         * tui/tui-io.h (tui_expand_tabs): Update.
3328         * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
3329         Remove "col" parameter.
3330
3331 2019-08-20  Tom Tromey  <tom@tromey.com>
3332
3333         * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
3334         field.
3335         * tui/tui-regs.c (~tui_data_item_window): Update.
3336
3337 2019-08-20  Tom Tromey  <tom@tromey.com>
3338
3339         * tui/tui-regs.c (tui_register_format, tui_get_register): Move
3340         earlier.
3341
3342 2019-08-20  Tom Tromey  <tom@tromey.com>
3343
3344         * tui/tui-regs.c (tui_reg_command): Remove NULL check.
3345
3346 2019-08-20  Tom Tromey  <tom@tromey.com>
3347
3348         * tui/tui-source.h (struct tui_source_window): Update.
3349         * tui/tui-regs.c (tui_show_registers): Update.
3350         * tui/tui-disasm.h (struct tui_disasm_window): Update.
3351         * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
3352         (NO_REGS_STRING): Remove defines.
3353
3354 2019-08-20  Conrad Meyer  <cem@FreeBSD.org>
3355
3356         * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
3357         unnecessary thread walk if remote doesn't support the packet.
3358
3359 2019-08-19  Tom Tromey  <tromey@adacore.com>
3360
3361         * python/py-value.c (value_has_field): Fix indentation.
3362
3363 2019-08-19  Tom Tromey  <tromey@adacore.com>
3364
3365         * printcmd.c (do_one_display, info_display_command): Update.
3366         * block.h (contained_in): Return bool.  Add allow_nested
3367         parameter.
3368         * block.c (contained_in): Return bool.  Add allow_nested
3369         parameter.
3370
3371 2019-08-19  Tom Tromey  <tom@tromey.com>
3372
3373         * configure: Rebuild.
3374         * configure.ac: Disallow the combination of -static-libstdc++ and
3375         source highlight.
3376         * source-cache.c (get_language_name): Handle rust.
3377         (source_cache::get_source_lines): Ignore highlighting exceptions.
3378
3379 2019-08-16  Tom Tromey  <tom@tromey.com>
3380
3381         * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
3382         * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
3383         (struct tui_source_window_base) <make_visible, refresh_window,
3384         resize>: Remove methods.
3385         <execution_info>: Remove field.
3386         * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
3387         (tui_show_source_line, tui_source_window_base)
3388         (~tui_source_window_base): Update.
3389         (tui_source_window_base::resize)
3390         (tui_source_window_base::make_visible)
3391         (tui_source_window_base::refresh_window): Remove.
3392         (tui_source_window_base::update_exec_info): Update.
3393         * tui/tui-source.c (tui_source_window::set_contents): Update.
3394         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
3395
3396 2019-08-16  Tom Tromey  <tom@tromey.com>
3397
3398         * tui/tui-hooks.c (tui_remove_hooks): Don't set
3399         deprecated_query_hook.
3400
3401 2019-08-16  Tom Tromey  <tom@tromey.com>
3402
3403         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
3404         (tui_update_source_windows_with_line): Update.
3405         * tui/tui-source.h (struct tui_source_window)
3406         <show_symtab_source>: Declare.
3407         (tui_show_symtab_source): Don't declare.
3408         * tui/tui-source.c (tui_show_symtab_source): Rename from
3409         tui_show_symtab_source.
3410
3411 2019-08-16  Tom Tromey  <tom@tromey.com>
3412
3413         * tui/tui-winsource.h (struct tui_source_window_base)
3414         <set_contents>: Declare.
3415         * tui/tui-winsource.c
3416         (tui_source_window_base::update_source_window_as_is): Update.
3417         * tui/tui-source.h (struct tui_source_window) <set_contents>:
3418         Declare.
3419         (tui_set_source_content): Don't declare.
3420         * tui/tui-source.c (tui_source_window::set_contents): Rename from
3421         tui_set_source_content.
3422         * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
3423         Declare.
3424         (tui_set_disassem_content): Don't declare.
3425         * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
3426         tui_set_disassem_content.
3427
3428 2019-08-16  Tom Tromey  <tom@tromey.com>
3429
3430         * tui/tui-winsource.h (struct tui_source_window_base)
3431         <update_breakpoint_info>: Declare.
3432         (tui_update_breakpoint_info): Don't declare.
3433         * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
3434         (tui_update_all_breakpoint_info): Update.
3435         (tui_source_window_base::update_breakpoint_info): Rename from
3436         tui_update_breakpoint_info.
3437         (tui_source_window_base::update_exec_info): Update.
3438
3439 2019-08-16  Tom Tromey  <tom@tromey.com>
3440
3441         * tui/tui-winsource.h (struct tui_source_window_base)
3442         <update_source_window>: Declare.
3443         (tui_update_source_window): Don't declare.
3444         * tui/tui-winsource.c
3445         (tui_source_window_base::update_source_window): Rename from
3446         tui_update_source_window.
3447         (tui_source_window_base::rerender): Update.
3448         * tui/tui-source.c (tui_source_window::maybe_update): Update.
3449         * tui/tui-disasm.c (tui_show_disassem)
3450         (tui_show_disassem_and_update_source)
3451         (tui_disasm_window::maybe_update): Update.
3452
3453 2019-08-16  Tom Tromey  <tom@tromey.com>
3454
3455         * tui/tui-winsource.h (struct tui_source_window_base)
3456         <update_source_window_as_is>: Declare.
3457         (tui_update_source_window_as_is): Don't declare.
3458         * tui/tui-winsource.c (tui_update_source_window): Update
3459         (tui_source_window_base::update_source_window_as_is): Rename from
3460         tui_update_source_window_as_is.
3461         (tui_source_window_base::refill): Update.
3462         * tui/tui-source.c (tui_show_symtab_source): Update.
3463         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
3464         Update.
3465
3466 2019-08-16  Tom Tromey  <tom@tromey.com>
3467
3468         * tui/tui-winsource.h (tui_update_source_window)
3469         (tui_update_source_window_as_is): Remove "noerror" parameter.
3470         * tui/tui-winsource.c (tui_update_source_window)
3471         (tui_update_source_window_as_is): Remove "noerror" parameter.
3472         (tui_update_source_windows_with_addr)
3473         (tui_update_source_windows_with_line)
3474         (tui_source_window_base::rerender)
3475         (tui_source_window_base::refill): Update.
3476         * tui/tui-source.h (tui_set_source_content)
3477         (tui_show_symtab_source): Remove "noerror" parameter.
3478         * tui/tui-source.c (tui_set_source_content): Remove "noerror"
3479         parameter.
3480         (tui_show_symtab_source): Likewise.
3481         (tui_source_window::maybe_update): Update.
3482         * tui/tui-disasm.c (tui_show_disassem)
3483         (tui_show_disassem_and_update_source)
3484         (tui_disasm_window::do_scroll_vertical)
3485         (tui_disasm_window::maybe_update): Update.
3486
3487 2019-08-16  Tom Tromey  <tom@tromey.com>
3488
3489         * tui/tui.c (tui_is_window_visible): Update.
3490         * tui/tui-wingeneral.c (tui_make_window)
3491         (tui_gen_win_info::make_visible, tui_refresh_all): Update.
3492         * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
3493         (tui_set_focus_command, tui_all_windows_info, update_tab_width)
3494         (tui_set_win_height_command, parse_scrolling_args): Update.
3495         * tui/tui-source.c (tui_source_window::style_changed): Update.
3496         * tui/tui-regs.c (tui_show_registers)
3497         (tui_data_window::first_data_item_displayed)
3498         (tui_data_window::delete_data_content_windows)
3499         (tui_check_register_values, tui_reg_command): Update.
3500         * tui/tui-disasm.c (tui_show_disassem): Update.
3501         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
3502         method.
3503         <is_visible>: Remove field.
3504         * tui/tui-data.c (tui_next_win, tui_prev_win)
3505         (tui_delete_invisible_windows): Update.
3506
3507 2019-08-16  Tom Tromey  <tom@tromey.com>
3508
3509         * tui/tui-winsource.h (struct tui_source_window_base)
3510         <m_has_locator>: Remove.
3511         * tui/tui-layout.c (show_source_disasm_command, show_data)
3512         (show_source_or_disasm_and_command): Update.
3513
3514 2019-08-16  Alan Hayward  <alan.hayward@arm.com>
3515
3516         * NEWS (Other MI changes): New subsection.
3517         * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
3518         (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
3519         * arch-utils.c (default_get_pc_address_flags): New function.
3520         * arch-utils.h (default_get_pc_address_flags): New declaration.
3521         * gdbarch.sh: Add get_pc_address_flags.
3522         * gdbarch.c: Regenerate.
3523         * gdbarch.h: Likewise.
3524         * stack.c (print_pc): New function.
3525         (print_frame_info) (print_frame): Call print_pc.
3526
3527 2019-08-16  Tom de Vries  <tdevries@suse.de>
3528
3529         * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
3530         print_objfile_section_info.
3531
3532 2019-08-15  Tom Tromey  <tom@tromey.com>
3533
3534         * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
3535         calling update_cmdwin_start_line.
3536         * tui/tui-winsource.h (struct tui_source_window_base)
3537         <do_make_visible_with_new_height, set_new_height>: Don't declare.
3538         <rerender>: Declare.
3539         * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
3540         Call rerender.
3541         (tui_source_window_base::set_new_height): Remove.
3542         (tui_source_window_base::rerender): Rename from
3543         do_make_visible_with_new_height.
3544         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
3545         resize method.
3546         (tui_win_info::make_invisible_and_set_new_height)
3547         (tui_win_info::make_visible_with_new_height): Remove.
3548         * tui/tui-stack.h (struct tui_locator_window) <rerender>:
3549         Declare.
3550         * tui/tui-stack.c (tui_locator_window::rerender): New method.
3551         * tui/tui-regs.h (struct tui_data_window) <set_new_height,
3552         do_make_visible_with_new_height>: Don't declare.
3553         <rerender>: Declare.
3554         * tui/tui-regs.c (tui_data_window::rerender): Rename from
3555         set_new_height.
3556         (tui_data_window::do_make_visible_with_new_height): Remove.
3557         * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
3558         call tui_show_locator_content.
3559         (tui_gen_win_info::resize): Call rerender.
3560         (show_source_or_disasm_and_command): Don't call
3561         tui_show_locator_content.
3562         * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
3563         method.
3564         (struct tui_win_info) <rerender>: Declare.
3565         <set_new_height, make_invisible_and_set_new_height,
3566         make_visible_with_new_height>: Don't declare.
3567         * tui/tui-data.c (tui_win_list::rerender): New method.
3568         * tui/tui-command.h (struct tui_cmd_window)
3569         <do_make_visible_with_new_height>: Don't declare.
3570         * tui/tui-command.c
3571         (tui_cmd_window::do_make_visible_with_new_height): Remove.
3572
3573 2019-08-15  Tom Tromey  <tromey@adacore.com>
3574
3575         * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
3576         * ada-lang.c (ada_enum_name): Likewise.
3577
3578 2019-08-15  Christian Biesinger  <cbiesinger@google.com>
3579
3580         * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
3581         leading underscore.
3582         (GdbOutputErrorFile): Likewise.
3583         (global scope): Adjust constructor calls to GdbOutput{,Error}File
3584         accordingly.
3585         (execute_unwinders): Rename to have a leading underscore.
3586         (auto_load_packages): Likewise.
3587         (global scope): Adjust call to auto_load_packages accordingly.
3588         (GdbSetPythonDirectory): Likewise.
3589         * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
3590         instead of execute_unwinders.
3591
3592 2019-08-15  Tom Tromey  <tom@tromey.com>
3593
3594         * tui/tui-layout.c (show_layout, show_source_disasm_command)
3595         (show_data): Don't change window visibility.
3596         (tui_gen_win_info::resize): Remove special case for command
3597         window.  Use wresize, when available.
3598         (show_source_or_disasm_and_command): Don't change window
3599         visibility.
3600         * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
3601         <make_visible>: New method.
3602         * tui/tui-command.c (tui_cmd_window::resize): New method.
3603
3604 2019-08-15  Tom Tromey  <tom@tromey.com>
3605
3606         * tui/tui-winsource.h (struct tui_source_window_iterator): New.
3607         (struct tui_source_windows): New.
3608         * tui/tui-winsource.c (tui_display_main): Update.
3609         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
3610         (new_height_ok, parse_scrolling_args): Update.
3611         * tui/tui-layout.c (show_layout, show_data): Update.
3612         * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
3613         (tui_add_to_source_windows): Don't declare.
3614         * tui/tui-data.c (source_windows, tui_source_windows)
3615         (tui_clear_source_windows, tui_add_to_source_windows): Remove.
3616
3617 2019-08-15  Tom Tromey  <tom@tromey.com>
3618
3619         * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
3620         Rename from reset.
3621         * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
3622         * tui/tui-layout.c (show_source_disasm_command, show_data):
3623         Update.
3624         (tui_gen_win_info::resize): Rename.
3625         (show_source_or_disasm_and_command): Update.
3626         * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
3627         reset.
3628
3629 2019-08-15  Tom Tromey  <tom@tromey.com>
3630
3631         * tui/tui-stack.c (tui_initialize_static_data): Remove.
3632         * tui/tui-interp.c (tui_interp::init): Don't call
3633         tui_initialize_static_data.
3634         * tui/tui-data.h (tui_initialize_static_data): Don't declare.
3635
3636 2019-08-15  Tom Tromey  <tom@tromey.com>
3637
3638         * tui/tui-layout.c (tui_default_win_viewport_height): Don't
3639         examine tui_win_list.
3640
3641 2019-08-15  Tom Tromey  <tom@tromey.com>
3642
3643         * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
3644         * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
3645         tui_clear_source_content.
3646         (tui_clear_source_content): Remove.
3647         (tui_source_window_base::do_erase_source_content): Hoist call to
3648         content.clear().
3649         * tui/tui-stack.c (tui_show_frame_info): Don't call
3650         tui_clear_source_content.
3651
3652 2019-08-15  Tom Tromey  <tom@tromey.com>
3653
3654         * tui/tui-winsource.h (struct tui_source_window_base)
3655         <do_erase_source_content>: New method.
3656         <erase_source_content>: New method.
3657         (tui_erase_source_content): Don't declare.
3658         * tui/tui-winsource.c (tui_clear_source_content): Update.
3659         (tui_source_window_base::do_erase_source_content): Rename from
3660         tui_erase_source_content.
3661         (tui_source_window_base::show_source_content): Update.
3662         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
3663         * tui/tui-source.h (struct tui_source_window)
3664         <erase_source_content>: New method.
3665         * tui/tui-disasm.h (struct tui_disasm_window)
3666         <erase_source_content>: New method.
3667
3668 2019-08-15  Tom Tromey  <tom@tromey.com>
3669
3670         * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
3671         (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
3672         constructor.
3673         * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
3674         * tui/tui-source.c (tui_set_source_content): Update.
3675         * tui/tui-disasm.c (tui_set_disassem_content): Update.
3676
3677 2019-08-15  Tom Tromey  <tom@tromey.com>
3678
3679         * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
3680         * tui/tui-winsource.c (tui_line_is_displayed): Move to
3681         tui-source.c.
3682         * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
3683         Declare.
3684         * tui/tui-source.c (tui_source_window::line_is_displayed): New
3685         method.
3686         (tui_source_window::maybe_update): Update.
3687
3688 2019-08-15  Tom Tromey  <tom@tromey.com>
3689
3690         * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
3691         * tui/tui-winsource.c (tui_addr_is_displayed): Move to
3692         tui-disasm.c.
3693         * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
3694         Declare.
3695         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
3696         method.
3697         (tui_disasm_window::maybe_update): Update.
3698
3699 2019-08-15  Tom Tromey  <tom@tromey.com>
3700
3701         * tui/tui-winsource.h (struct tui_source_window_base)
3702         <maybe_update>: Declare.
3703         * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
3704         method.
3705         * tui/tui-source.h (struct tui_source_window) <maybe_update>:
3706         Declare.
3707         * tui/tui-source.c (tui_source_window::maybe_update): New method.
3708         * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
3709         Declare.
3710         * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
3711
3712 2019-08-15  Tom Tromey  <tom@tromey.com>
3713
3714         * tui/tui-stack.c (tui_make_status_line): Use string constructor.
3715
3716 2019-08-15  Tom Tromey  <tom@tromey.com>
3717
3718         * tui/tui-wingeneral.c: Include tui-stack.h.
3719         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
3720         (struct tui_locator_window): Move from tui-data.h.
3721         * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
3722         (tui_initialize_static_data): Move from tui-data.c.
3723         * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
3724         (struct tui_locator_window): Move to tui-stack.c.
3725         * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
3726         (tui_initialize_static_data): Move to tui-stack.c.
3727
3728 2019-08-15  Tom Tromey  <tom@tromey.com>
3729
3730         * tui/tui-layout.c (show_source_disasm_command)
3731         (show_source_or_disasm_and_command): Use make_visible method, not
3732         tui_make_window.
3733         * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
3734         Remove.
3735
3736 2019-08-15  Tom Tromey  <tom@tromey.com>
3737
3738         * tui/tui-wingeneral.h (tui_make_window): Update.
3739         * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
3740         parameter.
3741         (tui_gen_win_info::make_visible): Update.
3742         * tui/tui-regs.c (tui_data_window::display_registers_from):
3743         Update.
3744         * tui/tui-layout.c (show_source_disasm_command)
3745         (show_source_or_disasm_and_command): Update.
3746         * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
3747         (enum tui_box): Remove.
3748         (struct tui_win_info) <can_box>: New method.
3749         * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
3750         method.
3751
3752 2019-08-15  Tom de Vries  <tdevries@suse.de>
3753
3754         * linux-nat-trad.c: Include gdbarch.h.
3755
3756 2019-08-14  Alan Hayward  <alan.hayward@arm.com>
3757
3758         * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
3759         register sizes.
3760
3761 2019-08-14  Tom Tromey  <tromey@adacore.com>
3762
3763         * darwin-nat.c: Include gdbarch.h.
3764         * darwin-nat-info.c: Include gdbarch.h.
3765
3766 2019-08-13  Tom Tromey  <tom@tromey.com>
3767
3768         * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
3769         Remove.
3770         * tui/tui-data.c (tui_initialize_static_data): Update.
3771
3772 2019-08-13  Tom Tromey  <tom@tromey.com>
3773
3774         * tui/tui-winsource.h (struct tui_exec_info_window)
3775         <~tui_exec_info_window, maybe_allocate_content, get_content,
3776         m_content>: Remove.
3777         (struct tui_source_window_base) <set_exec_info_content,
3778         show_exec_info_content>: Don't declare.
3779         * tui/tui-winsource.c
3780         (tui_exec_info_window::maybe_allocate_content): Remove.
3781         (tui_source_window_base::update_exec_info): Rename from
3782         set_exec_info_content.
3783         (tui_source_window_base::show_exec_info_content)
3784         (tui_source_window_base::update_exec_info): Remove.
3785
3786 2019-08-13  Tom Tromey  <tom@tromey.com>
3787
3788         * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
3789         declare.
3790         * tui/tui-winsource.c (tui_update_source_window_as_is)
3791         (tui_update_source_windows_with_addr, tui_erase_source_content):
3792         Update.
3793         (tui_clear_exec_info_content): Remove.
3794
3795 2019-08-13  Tom Tromey  <tom@tromey.com>
3796
3797         * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
3798         declare.
3799         * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
3800         call tui_erase_exec_info_content.
3801         (tui_clear_exec_info_content): Rename from
3802         tui_erase_exec_info_content.
3803         (tui_clear_exec_info_content): Delete.
3804
3805 2019-08-13  Tom Tromey  <tom@tromey.com>
3806
3807         * tui/tui-winsource.h (struct tui_source_window_base)
3808         <show_exec_info_content>: Declare.
3809         (tui_show_exec_info_content): Don't declare.
3810         * tui/tui-winsource.c
3811         (tui_source_window_base::show_exec_info_content): Rename from
3812         tui_show_exec_info_content.
3813         (tui_source_window_base::update_exec_info): Update.
3814
3815 2019-08-13  Tom Tromey  <tom@tromey.com>
3816
3817         * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
3818         (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
3819         (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
3820         * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
3821         tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
3822         (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
3823         ... here.
3824
3825 2019-08-13  Tom Tromey  <tom@tromey.com>
3826
3827         * tui/tui-winsource.h (struct tui_source_window_base)
3828         <update_exec_info>: Declare.
3829         (tui_update_exec_info): Don't declare.
3830         * tui/tui-winsource.c (tui_update_source_window_as_is)
3831         (tui_source_window_base::refresh_all)
3832         (tui_update_all_breakpoint_info): Update.
3833         (tui_source_window_base::update_exec_info): Rename from
3834         tui_update_exec_info.
3835         * tui/tui-stack.c (tui_show_frame_info): Update.
3836
3837 2019-08-13  Tom Tromey  <tom@tromey.com>
3838
3839         * tui/tui-winsource.h (struct tui_source_window_base)
3840         <set_exec_info_content>: Declare.
3841         (tui_set_exec_info_content): Don't declare.
3842         * tui/tui-winsource.c
3843         (tui_source_window_base::set_exec_info_content): Rename from
3844         tui_set_exec_info_content.
3845         (tui_update_exec_info): Update.
3846
3847 2019-08-13  Tom Tromey  <tom@tromey.com>
3848
3849         * tui/tui-winsource.h (struct tui_source_window_base)
3850         <show_source_content>: Declare.
3851         (tui_show_source_content): Don't declare.
3852         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
3853         (tui_source_window_base::show_source_content): Rename from
3854         tui_show_source_content.
3855         (tui_source_window_base::refresh_all): Update.
3856         * tui/tui-layout.c (show_source_disasm_command)
3857         (show_source_or_disasm_and_command): Update.
3858
3859 2019-08-13  Tom Tromey  <tom@tromey.com>
3860
3861         * tui/tui-winsource.c (tui_erase_source_content)
3862         (tui_show_source_content, tui_source_window_base::refresh_all):
3863         Update.
3864         * tui/tui-wingeneral.h
3865         (tui_check_and_display_highlight_if_needed): Don't declare.
3866         * tui/tui-wingeneral.c
3867         (tui_win_info::check_and_display_highlight_if_needed): Rename from
3868         check_and_display_highlight_if_needed.
3869         * tui/tui-win.c (tui_rehighlight_all)
3870         (tui_win_info::make_visible_with_new_height): Update.
3871         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
3872         (tui_data_window::erase_data_content)
3873         (tui_data_window::display_all_data): Update.
3874         * tui/tui-data.h (struct tui_win_info)
3875         <check_and_display_highlight_if_needed>: Declare.
3876
3877 2019-08-13  Tom Tromey  <tom@tromey.com>
3878
3879         * tui/tui-win.c (tui_resize_all): Call
3880         tui_delete_invisible_windows.
3881         * tui/tui-layout.c (show_layout): Call
3882         tui_delete_invisible_windows.
3883         * tui/tui-data.h (tui_delete_invisible_windows): Declare.
3884         * tui/tui-data.c (tui_delete_invisible_windows): New function.
3885
3886 2019-08-13  Tom Tromey  <tom@tromey.com>
3887
3888         * tui/tui-disasm.c (tui_show_disassem): Add assertion.  Don't call
3889         tui_add_win_to_layout.
3890
3891 2019-08-13  Tom Tromey  <tom@tromey.com>
3892
3893         * tui/tui-layout.h (tui_default_win_height): Don't declare.
3894         * tui/tui-layout.c (tui_default_win_height): Now static.
3895
3896 2019-08-13  Tom Tromey  <tom@tromey.com>
3897
3898         * tui/tui-layout.c (show_layout): Unify all layout cases into a
3899         single switch.
3900         (show_source_disasm_command, show_source_or_disasm_and_command):
3901         Don't check current layout.
3902
3903 2019-08-13  Tom Tromey  <tom@tromey.com>
3904
3905         * tui/tui-wingeneral.c (make_all_visible): Remove.
3906         (tui_make_all_invisible): Simplify.
3907         * tui/tui-layout.c (tui_make_all_invisible): Move from
3908         tui-wingeneral.c; simplify.
3909         (show_layout): Hoist call to tui_make_all_invisible.
3910         (show_data): Don't call tui_make_all_invisible.
3911
3912 2019-08-13  Tom Tromey  <tom@tromey.com>
3913
3914         * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
3915         * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
3916
3917 2019-08-13  Tom Tromey  <tom@tromey.com>
3918
3919         * tui/tui-layout.c (current_layout, tui_current_layout): Move from
3920         tui-data.c.
3921         (show_source_disasm_command, show_data)
3922         (show_source_or_disasm_and_command): Don't use
3923         tui_set_current_layout_to.
3924         * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
3925         * tui/tui-data.c (current_layout, tui_current_layout): Move to
3926         tui-layout.c.
3927         (tui_set_current_layout_to): Remove.
3928
3929 2019-08-13  Tom Tromey  <tom@tromey.com>
3930
3931         * tui/tui-layout.c (tui_set_layout): Update.
3932         * tui/tui-data.h (struct tui_layout_def): Remove.
3933         (tui_layout_def): Don't declare.
3934         * tui/tui-data.c (layout_def): Remove.
3935         (tui_layout_def): Remove.
3936
3937 2019-08-13  Tom Tromey  <tom@tromey.com>
3938
3939         * tui/tui-winsource.h (struct tui_source_window_base)
3940         <clear_detail>: No longer "override".
3941         * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
3942         * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
3943         * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
3944         * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
3945         Remove.
3946         * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
3947
3948 2019-08-13  Tom Tromey  <tromey@adacore.com>
3949
3950         * tracepoint.c: Don't include readline.h or history.h.
3951
3952 2019-08-12  Tom Tromey  <tom@tromey.com>
3953
3954         * configure: Rebuild.
3955         * configure.ac: Check for readline 7.
3956         * NEWS: Mention readline 7 requirement.
3957         * README: Update.
3958
3959 2019-08-12  Tom Tromey  <tom@tromey.com>
3960
3961         * mingw-hdep.c (gdb_select): Remove readline hack.
3962
3963 2019-08-09  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
3964
3965         * blockframe.c (find_pc_partial_function): Set *block to nullptr
3966         when the function fails.
3967
3968 2019-08-09  Andreas Arnez  <arnez@linux.ibm.com>
3969
3970         * s390-tdep.c (s390_type_align): New function.
3971         (s390_gdbarch_init): Set it as type_align gdbarch method.
3972
3973 2019-08-09  Tom de Vries  <tdevries@suse.de>
3974
3975         PR gdb/24591
3976         * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
3977         pc_low with relocation offset.
3978
3979 2019-08-07  Tom Tromey  <tromey@adacore.com>
3980
3981         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
3982         (print_frame_args): Update.
3983         * python/py-framefilter.c (py_print_single_arg, enumerate_args):
3984         Update.
3985         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
3986         * frame.h (struct frame_arg): Add initializers.
3987         <error>: Now a unique_xmalloc_ptr.
3988
3989 2019-08-07  Alan Hayward  <alan.hayward@arm.com>
3990
3991         * NEWS: Expand the Pointer Authentication entry.
3992         * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
3993         (aarch64_frame_unmask_lr): ... to this.
3994         (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
3995         Call aarch64_frame_unmask_lr.
3996         * frame.c (struct frame_info): Add "masked" variable.
3997         (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
3998         (fprint_frame): Check for masked pc.
3999         * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
4000         declarations.
4001         * python/py-framefilter.c (py_print_frame): Check for masked pc.
4002         * stack.c (print_frame): Check for masked pc.
4003
4004 2019-08-06  Tom Tromey  <tom@tromey.com>
4005
4006         * stabsread.c (patch_block_stabs, read_one_struct_field)
4007         (read_enum_type): Use obstack_strndup.
4008         * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
4009         * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
4010         * dwarf2read.c (guess_full_die_structure_name)
4011         (anonymous_struct_prefix): Use obstack_strndup.
4012         * dbxread.c (cp_set_block_scope): Use obstack_strndup.
4013         * c-exp.y (yylex): Use obstack_strndup.
4014         * ada-exp.y (write_object_renaming, write_ambiguous_var)
4015         (write_var_or_type): Use obstack_strndup.
4016
4017 2019-08-06  Tom Tromey  <tom@tromey.com>
4018
4019         * symfile.c (reread_symbols): Use obstack_strdup.
4020         * stabsread.c (read_type): Use obstack_strdup.
4021         * gdb_obstack.h (obstack_strdup): New overload.
4022         * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
4023         (create_dwo_unit_in_dwp_v2, build_error_marker_type)
4024         (dwarf2_canonicalize_name): Use obstack_strdup.
4025         * dbxread.c (read_dbx_symtab): Use obstack_strdup.
4026         * cp-support.c (inspect_type, replace_typedefs_qualified_name):
4027         Use obstack_strdup.
4028
4029 2019-08-06  Tom Tromey  <tom@tromey.com>
4030
4031         * gdb_obstack.h (obstack_strdup): Define.
4032         * gdb_obstack.c (obstack_strdup): Don't define.
4033
4034 2019-08-06  Tom Tromey  <tom@tromey.com>
4035
4036         * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
4037         obstack_strdup.
4038         * typeprint.c (typedef_hash_table::find_global_typedef): Use
4039         obstack_strdup.
4040         * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
4041         * stabsread.c (common_block_start): Use obstack_strdup.
4042         * objfiles.c (set_objfile_main_name, objfile): Use
4043         obstack_strdup.
4044         * namespace.c (add_using_directive): Use obstack_strdup.
4045         * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
4046         * jit.c (finalize_symtab): Use obstack_strdup.
4047         * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
4048         (guess_partial_die_structure_name, partial_die_info::fixup)
4049         (dwarf2_name): Use obstack_strdup.
4050         * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
4051         obstack_strdup.
4052         * c-exp.y (scan_macro_expansion): Use obstack_strdup.
4053         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
4054         obstack_strdup.
4055         * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
4056
4057 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4058
4059         * unittests/help-doc-selftests.c: New file.
4060         * Makefile.in: Add the new file.
4061
4062 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4063
4064         * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
4065         * cli/cli-decode.c (print_doc_line): Likewise.  It now prints
4066         the full first line, except when FOR_VALUE_PREFIX.  In this case,
4067         the trailing '.' is not output, and the first character is uppercased.
4068         (print_help_for_command): Update call to print_doc_line.
4069         (print_doc_of_command): Likewise.
4070         * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
4071         * cli/cli-option.c (append_indented_doc): Do not append newline.
4072         (build_help_option): Append newline after first appended_indented_doc
4073         only if a second call is done.
4074         (build_help): Append 2 new lines before each option, except the first
4075         one.
4076         * compile/compile.c (_initialize_compile): Add new lines after
4077         %OPTIONS%, when not at the end of the help.
4078         Change help doc or code
4079         producing the help doc to respect the invariants.
4080         * maint-test-options.c (_initialize_maint_test_options): Likewise.
4081         Also removed the new line after 'Options:', as all other commands
4082         do not put an empty line between 'Options:' and the first option.
4083         * printcmd.c (_initialize_printcmd): Likewise.
4084         * stack.c (_initialize_stack): Likewise.
4085         * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
4086         incorrectly telling COMMAND is optional.
4087         * ada-lang.c (_initialize_ada_language): Change help doc or code
4088         producing the help doc to respect the invariants.
4089         * ada-tasks.c (_initialize_ada_tasks): Likewise.
4090         * breakpoint.c (_initialize_breakpoint): Likewise.
4091         * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
4092         * cli/cli-logging.c (_initialize_cli_logging): Likewise.
4093         * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
4094         * cli/cli-style.c (cli_style_option::add_setshow_commands,
4095         _initialize_cli_style): Likewise.
4096         * corelow.c (core_target_info): Likewise.
4097         * dwarf-index-cache.c (_initialize_index_cache): Likewise.
4098         * dwarf2read.c (_initialize_dwarf2_read): Likewise.
4099         * filesystem.c (_initialize_filesystem): Likewise.
4100         * frame.c (_initialize_frame): Likewise.
4101         * gnu-nat.c (add_task_commands): Likewise.
4102         * infcall.c (_initialize_infcall): Likewise.
4103         * infcmd.c (_initialize_infcmd): Likewise.
4104         * interps.c (_initialize_interpreter): Likewise.
4105         * language.c (_initialize_language): Likewise.
4106         * linux-fork.c (_initialize_linux_fork): Likewise.
4107         * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
4108         * maint.c (_initialize_maint_cmds): Likewise.
4109         * memattr.c (_initialize_mem): Likewise.
4110         * printcmd.c (_initialize_printcmd): Likewise.
4111         * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
4112         _RegEx): Likewise.
4113         * ravenscar-thread.c (_initialize_ravenscar): Likewise.
4114         * record-btrace.c (_initialize_record_btrace): Likewise.
4115         * record-full.c (_initialize_record_full): Likewise.
4116         * record.c (_initialize_record): Likewise.
4117         * regcache-dump.c (_initialize_regcache_dump): Likewise.
4118         * regcache.c (_initialize_regcache): Likewise.
4119         * remote.c (add_packet_config_cmd, init_remote_threadtests,
4120         _initialize_remote): Likewise.
4121         * ser-tcp.c (_initialize_ser_tcp): Likewise.
4122         * serial.c (_initialize_serial): Likewise.
4123         * skip.c (_initialize_step_skip): Likewise.
4124         * source.c (_initialize_source): Likewise.
4125         * stack.c (_initialize_stack): Likewise.
4126         * symfile.c (_initialize_symfile): Likewise.
4127         * symtab.c (_initialize_symtab): Likewise.
4128         * target-descriptions.c (_initialize_target_descriptions): Likewise.
4129         * top.c (init_main): Likewise.
4130         * tracefile-tfile.c (tfile_target_info): Likewise.
4131         * tracepoint.c (_initialize_tracepoint): Likewise.
4132         * tui/tui-win.c (_initialize_tui_win): Likewise.
4133         * utils.c (add_internal_problem_command): Likewise.
4134         * valprint.c (value_print_option_defs): Likewise.
4135
4136 2019-08-06  Frank Ch. Eigler  <fche@redhat.com>
4137
4138         PR build/24886
4139         * configure.ac: Drop enable-libmcheck support.
4140         * configure, config.in: Rebuild.
4141         * libmcheck.m4: Remove.
4142         * acinclude.m4: Don't include it.
4143         * Makefile.in: Don't distribute it.
4144         * top.c (print_gdb_configuration): Don't mention it.
4145
4146 2019-08-06  Tom Tromey  <tom@tromey.com>
4147
4148         * utils.c (set_output_style): Sometimes pass stream to
4149         emit_style_escape.
4150         * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
4151         * record-btrace.c (btrace_insn_history): Update.
4152         * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
4153         method.
4154         * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
4155         Update initializers.
4156         <m_uiout>: New field.
4157         <m_di>: Move lower.
4158         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
4159         Remove "uiout" parameter.
4160         (dump_insns): Update.
4161         * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
4162         * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
4163
4164 2019-08-06  Christian Biesinger  <cbiesinger@google.com>
4165
4166         * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
4167         (error_in_psymtab_expansion): Likewise.
4168         (lookup_symbol_via_quick_fns): Likewise.
4169         (basic_lookup_transparent_type_quick): Likewise.
4170         (basic_lookup_transparent_type_1): Likewise.
4171
4172 2019-08-06  Tom Tromey  <tromey@adacore.com>
4173
4174         * source.c (last_source_error): Now bool.
4175         (print_source_lines_base): Make "noprint" bool.  Only open
4176         source file when last_source_visited changes.
4177
4178 2019-08-06  Tom Tromey  <tromey@adacore.com>
4179
4180         * annotate.c (annotate_source_line): Use g_source_cache.
4181         * source-cache.c (source_cache::get_plain_source_lines): Change
4182         parameters.  Populate m_offset_cache.
4183         (source_cache::ensure): New method.
4184         (source_cache::get_line_charpos): New method.
4185         (extract_lines): Move lower.  Change parameters.
4186         (source_cache::get_source_lines): Move lower.
4187         * source-cache.h (class source_cache): Update comment.
4188         <get_line_charpos>: New method.
4189         <get_source_lines>: Update comment.
4190         <clear>: Clear m_offset_cache.
4191         <get_plain_source_lines>: Change parameters.
4192         <ensure>: New method
4193         <m_offset_cache>: New member.
4194         * source.c (forget_cached_source_info_for_objfile): Update.
4195         (info_source_command): Use g_source_cache.
4196         (find_source_lines, open_source_file_with_line_charpos): Remove.
4197         (print_source_lines_base, search_command_helper): Use g_source_cache.
4198         * source.h (open_source_file_with_line_charpos): Don't declare.
4199         * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
4200         * tui/tui-source.c (tui_source_window::do_scroll_vertical):
4201         Use g_source_cache.
4202
4203 2019-08-06  Tom Tromey  <tromey@adacore.com>
4204
4205         * source-cache.c (source_cache::get_plain_source_lines):
4206         Remove "first_line" and "last_line" parameters.
4207         (source_cache::get_source_lines): Cache plain text.
4208         * source-cache.h (class source_cache)
4209         <get_plain_source_lines>: Update.
4210
4211 2019-08-06  Tom Tromey  <tromey@adacore.com>
4212
4213         * source-cache.c (extract_lines): No longer a method.
4214         Changed type of parameter.  Include final newline.
4215         (selftests::extract_lines_test): New function.
4216         (_initialize_source_cache): Likewise.
4217         * source-cache.h (class source_cache)
4218         <extract_lines>: Don't declare.
4219
4220 2019-08-06  Tom Tromey  <tromey@adacore.com>
4221
4222         * breakpoint.c (init_breakpoint_sal): Update.
4223         (breakpoint): Update.
4224         * breakpoint.h (struct breakpoint) <filter>: Now a
4225         unique_xmalloc_ptr.
4226
4227 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
4228
4229         * NEWS: Mention dictionary access on blocks.
4230         * python/py-block.c (blpy_getitem): New function.
4231         (block_object_as_mapping): New struct.
4232         (block_object_type): Use new struct for tp_as_mapping field.
4233
4234 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
4235
4236         * objfiles.h (objfile): Add a comment describing partial symbols.
4237
4238 2019-08-05  Tom Tromey  <tromey@adacore.com>
4239
4240         * compile/compile.c (_initialize_compile): Use _(), not N_().
4241         * thread.c (_initialize_thread): Use _(), not N_().
4242         * stack.c (_initialize_stack): Use _(), not N_().
4243         * printcmd.c (_initialize_printcmd): Use _(), not N_().
4244
4245 2019-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
4246
4247         * dwarf2read.c (struct dw2_symtab_iterator):
4248         <want_specific_block>: Remove.
4249         <block_index>: Change type to gdb::optional.
4250         (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
4251         change type of BLOCK_INDEX parameter to gdb::optional.
4252         (dw2_symtab_iter_next): Re-write in function of gdb::optional.
4253         (dw2_lookup_symbol): Don't pass argument for
4254         WANT_SPECIFIC_BLOCK.
4255         (dw2_expand_symtabs_for_function): Don't pass argument for
4256         WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
4257         (class dw2_debug_names_iterator)
4258         <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
4259         parameter, change BLOCK_INDEX type to gdb::optional.
4260         <m_want_specific_block>: Remove.
4261         <m_block_index>: Change type to gdb::optional.
4262         (dw2_debug_names_iterator::next): Change type of IS_STATIC to
4263         gdb::optional.  Re-write in function of gdb::optional.
4264         (dw2_debug_names_lookup_symbol): Don't pass argument for
4265         WANT_SPECIFIC_BLOCK.
4266         (dw2_debug_names_expand_symtabs_for_function): Don't pass
4267         argument for WANT_SPECIFIC_BLOCK, pass empty optional for
4268         BLOCK_INDEX.
4269
4270 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4271
4272         * NEWS: Mention changes to "info sources" command.
4273
4274 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4275
4276         * symtab.c (filename_partial_match_opts): New struct type.
4277         (struct output_source_filename_data): New members
4278         regexp, c_regexp, partial_match.
4279         (output_source_filename): Use new members to decide to print file.
4280         (info_sources_option_defs): New variable.
4281         (make_info_sources_options_def_group, print_info_sources_header,
4282         info_sources_command_completer):
4283         New functions.
4284         (info_sources_command): Read new optional arguments.
4285         (_initialize_symtab): Update info sources help.
4286
4287 2019-08-02  Alexandre Oliva <oliva@adacore.com>
4288
4289         * ada-lang.c (exception_support_info_v0): Renamed from...
4290         (default_exception_support_info): ... this.  Create new
4291         definition for v1.
4292         (ada_has_this_exception_support): Look up catch_handlers_sym.
4293         (ada_exception_support_info_sniffer): Try v0 after default.
4294
4295 2019-08-01  Tom Tromey  <tromey@adacore.com>
4296
4297         * ia64-libunwind-tdep.h (struct libunwind_descr): Include
4298         gdbarch.h.
4299
4300 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
4301
4302         * s12z-tdep.c: Fix include path for s12z-opc.h.
4303
4304 2019-08-01  Alan Hayward  <alan.hayward@arm.com>
4305
4306         * NEWS: Require GNU make 3.82.
4307
4308 2019-07-16  Tom Tromey  <tom@tromey.com>
4309
4310         * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
4311         declare.
4312
4313 2019-07-30  Tom Tromey  <tromey@adacore.com>
4314
4315         * block.c (contained_in): Remove BLOCK_FUNCTION check.
4316
4317 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
4318
4319         * printcmd.c (print_address_symbolic): Print negative offsets.
4320         (build_address_symbolic): Force signed arithmetic when computing
4321         offset.
4322
4323 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
4324
4325         PR/24474: Add a function to lookup static variables.
4326         * NEWS: Mention this new function.
4327         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
4328         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
4329         * python/python.c (python_GdbMethods): Add new function.
4330
4331 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
4332
4333         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
4334         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
4335         (objfpy_lookup_static_symbol): New function.
4336         (objfile_object_methods): Add new functions.
4337
4338 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4339
4340         * NEWS: Mention 'set|show print frame-info'.  Mention new
4341         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
4342         backtrace argument.  Mention that python frame filtering code
4343         is now consistent with what 'backtrace' command prints.
4344
4345 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4346
4347         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
4348         comments.
4349         (print_frame_info_auto, print_frame_info_source_line,
4350         print_frame_info_location, print_frame_info_source_and_location,
4351         print_frame_info_location_and_address, print_frame_info_short_location):
4352         New declarations.
4353         (struct frame_print_options): New member print_frame_info.
4354         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
4355         * stack.h (get_user_print_what_frame_info): New declaration.
4356         (frame_show_address): New declaration.
4357         * stack.c (print_frame_arguments_choices): New value 'presence'.
4358         (print_frame_info_auto, print_frame_info_source_line,
4359         print_frame_info_location, print_frame_info_source_and_location,
4360         print_frame_info_location_and_address, print_frame_info_short_location,
4361         print_frame_info_choices, print_frame_info_print_what): New definitions.
4362         (print_frame_args): Only print dots for args if print frame-arguments
4363         is 'presence'.
4364         (frame_print_option_defs): New element for "frame-info".
4365         (get_user_print_what_frame_info): New function.
4366         (frame_show_address): Make non static.  Move comment to stack.h.
4367         (print_frame_info_to_print_what): New function.
4368         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
4369         to decide what to print.
4370         (backtrace_command_1): Handle the new print_frame_arguments_presence
4371         value.
4372         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
4373         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
4374         (py_print_frame): In non-mi mode, use LOCATION as default for
4375         print_what, similarly to frame information printed directly by
4376         backtrace command. Handle frame-info user option in non MI mode.
4377
4378 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
4379
4380         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
4381         Add case for debugging 32-bit target on 64-bit host.  Revise
4382         comment.
4383
4384 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
4385
4386         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
4387         instead of find_function_entry_range_from_pc.
4388
4389 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
4390
4391         * stack.c (find_frame_funname): Remove code which preferred
4392         minsym over symtab sym in "certain pathological cases".
4393
4394         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
4395         parameter.  Change type of "do_demangle" to bool.
4396         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
4397         Pass suitable "prefer_sym_over_minsym" flag to
4398         build_address_symbolic().  Don't output "+" for negative offsets.
4399         * printcmd.c (print_address_symbolic): Update invocation of
4400         build_address_symbolic to include a "prefer_sym_over_minsym"
4401         flag.
4402         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
4403         Restrict cases in which use of minimal symbol is preferred to that
4404         of a found symbol.  Update comments.
4405
4406         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
4407         for entry pc when entry pc is out of range for that FDE.
4408
4409 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
4410
4411         PR gdb/24839:
4412         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
4413         type.
4414
4415 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
4416
4417         * python/py-objfile.c (add_separate_debug_file): Fix comment about
4418         this function's Python signature.
4419
4420
4421 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
4422
4423         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
4424         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
4425         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
4426         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
4427         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
4428
4429
4430 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
4431
4432         * h8300-tdep.c (h8300_register_name_common): New.
4433         h8300_register_name): Use h8300_register_name_common.
4434         (h8300s_register_name): Likewise.
4435         (h8300sx_register_name): Likewise.
4436         (h8300h_register_nam): New.
4437         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
4438
4439
4440 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
4441
4442         * arm-tdep.c (arm_skip_cmse_entry): New function.
4443         (arm_is_sgstubs_section): New function.
4444         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
4445
4446 2019-07-22  Tom Tromey  <tom@tromey.com>
4447
4448         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
4449         Don't self-assign.
4450
4451 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
4452
4453         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
4454         type_print.
4455
4456 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
4457
4458         * symtab.c (search_symbols): Adjust msymbol matching type arrays
4459         so that GDB doesn't match any msymbols when searching in the
4460         TYPES_DOMAIN.
4461         (print_symbol_info): Print using typedef_print or type_print based
4462         on the type of the symbol.  Add updated FIXME comment moved from...
4463         (_initialize_symtab): ... move and update FIXME comment to above.
4464
4465 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
4466
4467         * NEWS: Mention adding -q option to "info types".
4468         * symtab.c (struct info_types_options): New struct.
4469         (info_types_options_defs): New variable.
4470         (make_info_types_options_def_group): New function.
4471         (info_types_command): Use gdb::option framework to parse options.
4472         (info_types_command_completer): New function.
4473         (_initialize_symtab): Extend the help text on "info types" and
4474         register command completer.
4475
4476 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
4477
4478         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
4479         (lookup_symbol_in_objfile): Change int to block_enum and add a
4480         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
4481
4482 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
4483
4484         * MAINTAINERS (Write After Approval): Add self.
4485
4486 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
4487
4488         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
4489         instruction to the dummy code region.
4490
4491 2019-07-19  Tom Tromey  <tromey@adacore.com>
4492
4493         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
4494         (ARGSUSED, PARAMS, __func__): Remove rules.
4495
4496 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
4497
4498         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
4499         * features/arm/arm-with-iwmmxt.c: Remove.
4500         * features/arm/arm-with-iwmmxt.xml: Remove.
4501         * features/arm/arm-with-m-fpa-layout.c: Remove.
4502         * features/arm/arm-with-m-fpa-layout.xml: Remove.
4503         * features/arm/arm-with-m-vfp-d16.c: Remove.
4504         * features/arm/arm-with-m-vfp-d16.xml: Remove.
4505         * features/arm/arm-with-m.c: Remove.
4506         * features/arm/arm-with-m.xml: Remove.
4507         * features/arm/arm-with-neon.c: Remove.
4508         * features/arm/arm-with-neon.xml: Remove.
4509         * features/arm/arm-with-vfpv2.c: Remove.
4510         * features/arm/arm-with-vfpv2.xml: Remove.
4511         * features/arm/arm-with-vfpv3.c: Remove.
4512         * features/arm/arm-with-vfpv3.xml: Remove.
4513
4514 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
4515
4516         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
4517
4518 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
4519
4520         * arch/aarch32.c (aarch32_create_target_description): Create
4521         target descriptions using features.
4522         * arch/arm.c (arm_create_target_description)
4523         (arm_create_mprofile_target_description): Likewise.
4524         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
4525
4526 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
4527
4528         * Makefile.in: Add new files.
4529         * aarch32-tdep.c: New file.
4530         * aarch32-tdep.h: New file.
4531         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
4532         Call aarch32_read_description.
4533         * arch/aarch32.c: New file.
4534         * arch/aarch32.h: New file.
4535         * arch/arm.c (arm_create_target_description)
4536         (arm_create_mprofile_target_description): New function.
4537         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
4538         (arm_create_target_description)
4539         (arm_create_mprofile_target_description): New declaration.
4540         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
4541         read_description functions.
4542         * arm-linux-nat.c (arm_linux_nat_target::read_description):
4543         Likewise.
4544         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
4545         * arm-tdep.c (tdesc_arm_list): New variable.
4546         (arm_register_g_packet_guesses): Call create description functions.
4547         (arm_read_description) (arm_read_mprofile_description): New
4548         function.
4549         * arm-tdep.h (arm_read_description)
4550         (arm_read_mprofile_description): Add declaration.
4551         * configure.tgt: Add new files.
4552
4553 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
4554
4555         * top.c (new_ui_command): Open specified terminal just once.
4556
4557 2019-07-18  Tom Tromey  <tromey@adacore.com>
4558
4559         * symtab.c (main_name): Constify return type.
4560         * symfile.c (set_initial_language): Update.
4561         * symtab.h (main_name): Constify return type.
4562
4563 2019-07-17  Tom Tromey  <tom@tromey.com>
4564
4565         * tui/tui-winsource.c (tui_update_source_window)
4566         (tui_update_source_window_as_is)
4567         (tui_update_source_windows_with_line): Remove return.
4568         * tui/tui-disasm.c (tui_show_disassem)
4569         (tui_show_disassem_and_update_source): Remove return.
4570         * tui/tui.c (tui_reset): Remove return.
4571         * tui/tui-wingeneral.c
4572         (tui_check_and_display_highlight_if_needed): Remove return.
4573
4574 2019-07-17  Tom Tromey  <tom@tromey.com>
4575
4576         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
4577
4578 2019-07-17  Tom Tromey  <tom@tromey.com>
4579
4580         * tui/tui-winsource.h (struct tui_exec_info_window)
4581         (struct tui_source_window_base): Move from tui-data.h.
4582         * tui/tui-winsource.c: Move many method definitions from
4583         elsewhere.  Remove "structuring" comments.
4584         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
4585         (tui_source_window_base::refresh_window): Move to
4586         tui-winsource.c.
4587         * tui/tui-win.c (tui_source_window_base::refresh_all)
4588         (tui_source_window_base::update_tab_width)
4589         (tui_source_window_base::set_new_height)
4590         (tui_source_window_base::do_make_visible_with_new_height): Move to
4591         tui-winsource.c.
4592         * tui/tui-source.h: Update.
4593         * tui/tui-source.c (tui_source_window_base::reset): Move to
4594         tui-winsource.c.
4595         * tui/tui-disasm.h: Update.
4596         * tui/tui-data.h (struct tui_exec_info_window): Move to
4597         tui-winsource.h.
4598         (struct tui_source_window_base): Likewise.
4599         * tui/tui-data.c (tui_source_window_base::clear_detail)
4600         (tui_source_window_base, ~tui_source_window_base): Move to
4601         tui-winsource.c.
4602
4603 2019-07-17  Tom Tromey  <tom@tromey.com>
4604
4605         * tui/tui-win.c (tui_resize_all)
4606         (tui_source_window_base::update_tab_width)
4607         (tui_adjust_win_heights): Update.
4608         (tui_win_info::make_invisible_and_set_new_height): Rename from
4609         make_invisible_and_set_new_height.
4610         * tui/tui-data.h (struct tui_win_info)
4611         <make_invisible_and_set_new_height>: New method.
4612
4613 2019-07-17  Tom Tromey  <tom@tromey.com>
4614
4615         * tui/tui.c: Update.
4616         * tui/tui-source.h (struct tui_source_window): Move from
4617         tui-data.h.
4618         * tui/tui-layout.c: Update.
4619         * tui/tui-disasm.c: Update.
4620         * tui/tui-data.h (struct tui_source_window): Move to
4621         tui-source.h.
4622
4623 2019-07-17  Tom Tromey  <tom@tromey.com>
4624
4625         * tui/tui-disasm.h (struct tui_disasm_window): Move from
4626         tui-data.h.
4627         * tui/tui-data.h (struct tui_disasm_window): Move to
4628         tui-disasm.h.
4629
4630 2019-07-17  Tom Tromey  <tom@tromey.com>
4631
4632         * tui/tui-regs.h (struct tui_data_item_window): Move from
4633         tui-data.h.
4634         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
4635         * tui/tui-data.h (struct tui_data_item_window): Move to
4636         tui-regs.h.
4637         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
4638
4639 2019-07-17  Tom Tromey  <tom@tromey.com>
4640
4641         * tui/tui.c: Update.
4642         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
4643         (tui_cmd_window::max_height): Move to tui-command.c.
4644         * tui/tui-layout.c: Update.
4645         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
4646         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
4647         tui-command.c.
4648         * tui/tui-command.h (struct tui_cmd_window): Move from
4649         tui-data.h.
4650         * tui/tui-command.c: Remove "structuring" comments.
4651         (tui_cmd_window::clear_detail)
4652         (tui_cmd_window::do_make_visible_with_new_height)
4653         (tui_cmd_window::max_height): Move from elsewhere.
4654
4655 2019-07-17  Tom Tromey  <tom@tromey.com>
4656
4657         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
4658         Now static.
4659         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
4660         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
4661
4662 2019-07-17  Tom Tromey  <tom@tromey.com>
4663
4664         * tui/tui.c: Update.
4665         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
4666         tui-regs.c.
4667         * tui/tui-windata.h: Remove file.
4668         * tui/tui-windata.c: Remove file.
4669         * tui/tui-win.c (tui_data_window::set_new_height)
4670         (tui_data_window::do_make_visible_with_new_height): Move to
4671         tui-regs.c.
4672         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
4673         * tui/tui-regs.c: Remove "structuring" comments.
4674         (tui_data_window::first_data_item_displayed)
4675         (tui_data_window::delete_data_content_windows)
4676         (tui_data_window::erase_data_content)
4677         (tui_data_window::display_all_data)
4678         (tui_data_window::refresh_all)
4679         (tui_data_window::do_scroll_vertical)
4680         (tui_data_window::clear_detail, tui_data_window::set_new_height)
4681         (tui_data_window::do_make_visible_with_new_height)
4682         (tui_data_window::refresh_window): Move from elsewhere.
4683         (_initialize_tui_regs): Move to end of file.
4684         * tui/tui-layout.c: Update.
4685         * tui/tui-hooks.c: Update.
4686         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
4687         * tui/tui-data.c (tui_data_window::clear_detail): Move to
4688         tui-regs.c.
4689         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
4690
4691 2019-07-17  Tom Tromey  <tom@tromey.com>
4692
4693         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
4694         seen.
4695
4696 2019-07-17  Tom Tromey  <tom@tromey.com>
4697
4698         * tui/tui-win.c (tui_source_window_base::set_new_height)
4699         (tui_source_window_base::do_make_visible_with_new_height): Use
4700         m_has_locator field directly.
4701         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
4702         method.
4703         (struct tui_source_window_base) <has_locator>: Likewise.
4704
4705 2019-07-17  Tom Tromey  <tom@tromey.com>
4706
4707         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
4708         Don't declare.
4709         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
4710         Remove.
4711         * tui/tui-win.c (tui_source_window_base::set_new_height)
4712         (tui_source_window_base::set_new_height)
4713         (make_invisible_and_set_new_height)
4714         (tui_source_window_base::do_make_visible_with_new_height)
4715         (tui_source_window_base::do_make_visible_with_new_height):
4716         Update.
4717         * tui/tui-layout.c (show_source_disasm_command, show_data)
4718         (show_source_or_disasm_and_command): Update.
4719         * tui/tui-layout.c (show_layout): Update.
4720
4721 2019-07-17  Tom Tromey  <tom@tromey.com>
4722
4723         * tui/tui-layout.c (make_data_window): Remove.
4724         (show_data): Unify creation and re-initialization cases.
4725
4726 2019-07-17  Tom Tromey  <tom@tromey.com>
4727
4728         * tui/tui-layout.c (make_source_window, make_disasm_window):
4729         Remove.
4730         (show_data): Unify creation and re-initialization cases.
4731
4732 2019-07-17  Tom Tromey  <tom@tromey.com>
4733
4734         * tui/tui-layout.c (make_command_window): Remove.
4735         (show_source_disasm_command, show_source_or_disasm_and_command):
4736         Unify creation and re-initialization cases.
4737
4738 2019-07-17  Tom Tromey  <tom@tromey.com>
4739
4740         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
4741         creation and re-initialization cases.
4742
4743 2019-07-17  Tom Tromey  <tom@tromey.com>
4744
4745         * tui/tui-regs.c (tui_get_register): Return void.
4746
4747 2019-07-17  Tom Tromey  <tom@tromey.com>
4748
4749         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
4750         Simplify.
4751
4752 2019-07-17  Tom Tromey  <tom@tromey.com>
4753
4754         * tui/tui-layout.c (show_source_disasm_command): Simplify window
4755         resetting.
4756
4757 2019-07-17  Tom Tromey  <tom@tromey.com>
4758
4759         * tui/tui.h (tui_set_layout_by_name): Don't declare.
4760         * tui/tui-regs.c (tui_reg_layout): New function.
4761         (tui_show_registers, tui_reg_command): Use it.
4762         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
4763         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
4764         parameters.
4765         (tui_layout_command): Remove.
4766
4767 2019-07-17  Tom Tromey  <tom@tromey.com>
4768
4769         * tui/tui-layout.h (tui/tui-layout): Return void.
4770         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
4771
4772 2019-07-17  Tom Tromey  <tom@tromey.com>
4773
4774         * tui/tui-layout.c (show_source_disasm_command, show_data):
4775         Update.
4776         (reset_locator): Remove.
4777         (show_source_or_disasm_and_command): Update.
4778
4779 2019-07-17  Tom Tromey  <tom@tromey.com>
4780
4781         * tui/tui-source.c (tui_source_window_base::reset): Remove
4782         win_type parameter.
4783         * tui/tui-layout.c (make_command_window, make_source_window)
4784         (make_disasm_window, make_data_window)
4785         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
4786         (reset_locator, show_source_or_disasm_and_command): Update.
4787         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
4788         win_type parameter.
4789         (struct tui_source_window_base) <reset>: Likewise.
4790
4791 2019-07-17  Tom Tromey  <tom@tromey.com>
4792
4793         * tui/tui-layout.c (show_source_disasm_command): Use
4794         reset_locator.
4795         (reset_locator): New function.
4796         (init_and_make_win): Remove.
4797         (show_source_or_disasm_and_command): Use reset_locator.
4798
4799 2019-07-17  Tom Tromey  <tom@tromey.com>
4800
4801         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
4802         condition.
4803         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
4804         Remove condition.
4805         * tui/tui-source.c (tui_source_window_base::reset): New method.
4806         * tui/tui-layout.c (make_command_window): Don't call
4807         init_and_make_win.
4808         (make_source_window, make_disasm_window): Don't call
4809         make_source_or_disasm_window.
4810         (make_data_window): Don't call init_and_make_win.  Change calling
4811         convention.
4812         (show_source_disasm_command, show_data): Simplify.
4813         (make_source_or_disasm_window): Remove.
4814         (show_source_or_disasm_and_command): Simplify.
4815         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
4816         (struct tui_source_window_base) <reset>: Likewise.
4817         <execution_info>: Remove initializer.
4818         * tui/tui-data.c (tui_source_window_base): Initialize
4819         execution_info.
4820
4821 2019-07-17  Tom Tromey  <tom@tromey.com>
4822
4823         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
4824         variable.
4825
4826 2019-07-17  Tom Tromey  <tom@tromey.com>
4827
4828         * tui/tui.c (tui_rl_other_window): Update.
4829         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
4830         superclass method first.  Always iterate over regs_content.
4831         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
4832         method.
4833         * tui/tui-win.c (tui_set_focus_command): Update.
4834
4835 2019-07-17  Tom Tromey  <tom@tromey.com>
4836
4837         * tui/tui-win.c (tui_set_focus_command): Rename from
4838         tui_set_focus.  Call tui_enable.
4839         (tui_set_focus_command): Remove.
4840
4841 2019-07-17  Tom Tromey  <tom@tromey.com>
4842
4843         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
4844         refresh_window.
4845         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
4846         touchwin.
4847         (tui_data_window::refresh_window): Call refresh_window on data
4848         items.  Always call superclass refresh_window.
4849         (tui_win_info::refresh): Remove.
4850         (tui_source_window_base::refresh_window): Update.
4851         (tui_refresh_all): Update.
4852         * tui/tui-layout.c (show_source_disasm_command): Remove call to
4853         refresh_window.
4854         (show_source_or_disasm_and_command): Likewise.
4855         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
4856         (struct tui_source_window_base) <refresh>: Likewise.
4857
4858 2019-07-17  Tom Tromey  <tom@tromey.com>
4859
4860         * tui/tui-winsource.c (tui_clear_source_content)
4861         (tui_show_source_content): Update.
4862         * tui/tui-source.c (tui_source_window::showing_source_p): Check
4863         whether content is empty.
4864         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
4865         Remove.
4866
4867 2019-07-17  Tom Tromey  <tom@tromey.com>
4868
4869         * tui/tui-winsource.c (tui_erase_source_content): Clear the
4870         window's contents.
4871         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
4872         * tui/tui-source.c (tui_set_source_content_nil): Remove.
4873
4874 2019-07-17  Tom Tromey  <tom@tromey.com>
4875
4876         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
4877         (struct tui_data_item_window): Update.
4878
4879 2019-07-17  Tom Tromey  <tom@tromey.com>
4880
4881         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
4882         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
4883         defines.
4884
4885 2019-07-17  Tom Tromey  <tom@tromey.com>
4886
4887         * tui/tui-winsource.h (tui_erase_source_content)
4888         (tui_clear_source_content): Remove "display_prompt" parameter.
4889         * tui/tui-winsource.c (tui_update_source_window_as_is)
4890         (tui_update_source_windows_with_addr): Update.
4891         (tui_clear_source_content): Remove "display_prompt" parameter.
4892         (tui_erase_source_content): Likewise.  Simplify.
4893         (tui_show_source_content): Update.
4894         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
4895         * tui/tui-stack.c (tui_show_frame_info): Update.
4896         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
4897         Remove defines.
4898
4899 2019-07-17  Tom Tromey  <tom@tromey.com>
4900
4901         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
4902         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
4903         parameter.
4904         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
4905         parameter.
4906
4907 2019-07-17  Tom Tromey  <tom@tromey.com>
4908
4909         * tui/tui-winsource.c (tui_clear_source_content)
4910         (tui_show_source_content, tui_show_exec_info_content)
4911         (tui_clear_exec_info_content): Update.
4912         * tui/tui-stack.c (tui_show_locator_content): Update.
4913         (tui_show_frame_info): Update.
4914         * tui/tui-source.h (tui_source_window): Don't declare.
4915         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
4916         from tui_source_is_displayed.
4917         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
4918         Remove field.
4919         (struct tui_source_window_base) <content_in_use>: New field.  Now
4920         bool.
4921         (struct tui_source_window) <showing_source_p>: New method.
4922         (TUI_SRC_WIN): Change cast.
4923         * tui/tui-data.c (tui_initialize_static_data): Update.
4924
4925 2019-07-17  Tom Tromey  <tom@tromey.com>
4926
4927         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
4928         location_matches_p.
4929         * tui/tui-source.c (tui_source_window::location_matches_p): New
4930         method.
4931         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
4932         method.
4933         * tui/tui-data.h (struct tui_source_window_base)
4934         <location_matches_p>: New method.
4935         (struct tui_source_window, struct tui_disasm_window)
4936         <location_matches_p>: Likewise.
4937
4938 2019-07-17  Tom Tromey  <tom@tromey.com>
4939
4940         * tui/tui-win.c (tui_set_win_height_command): Rename from
4941         tui_set_win_height.
4942         (tui_set_win_height_command): Remove.
4943
4944 2019-07-17  Tom Tromey  <tom@tromey.com>
4945
4946         * tui/tui-source.c (tui_source_window): New constructor.  Add
4947         observer.
4948         (~tui_source_window): New destructor.
4949         (tui_source_window::style_changed): New method.
4950         * tui/tui-hooks.c (tui_redisplay_source): Remove.
4951         (tui_attach_detach_observers): Update.
4952         * tui/tui-data.h (struct tui_source_window): Make constructor not
4953         inline.  Add destructor.
4954         (struct tui_source_window) <style_changed>: New method.
4955         <m_observable>: New member.
4956
4957 2019-07-17  Tom Tromey  <tom@tromey.com>
4958
4959         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
4960         * tui/tui-win.c (tui_resize_all): Fix typo.
4961
4962 2019-07-17  Tom Tromey  <tom@tromey.com>
4963
4964         * tui/tui-wingeneral.h (tui_refresh_all): Update.
4965         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
4966         (tui_refresh_all): Remove "list" parameter.  Use foreach.
4967         * tui/tui-win.c (window_name_completer): Use foreach.
4968         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
4969         (update_tab_width): Likewise.
4970         * tui/tui-layout.c (show_layout): Update.
4971         * tui/tui-data.h (class tui_window_iterator): New.
4972         (struct all_tui_windows): New.
4973         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
4974
4975 2019-07-17  Tom Tromey  <tom@tromey.com>
4976
4977         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
4978         parameter.  Don't reference globals.
4979         (tui_reg_command): Update.
4980
4981 2019-07-17  Tom Tromey  <tom@tromey.com>
4982
4983         * tui/tui-regs.c (tui_show_registers): Simplify.
4984
4985 2019-07-17  Tom Tromey  <tom@tromey.com>
4986
4987         * tui/tui-regs.c (tui_show_registers): Update.
4988         (tui_show_register_group): Add win_info parameter.
4989
4990 2019-07-17  Tom Tromey  <tom@tromey.com>
4991
4992         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
4993         Rename from tui_display_reg_element_at_line.
4994         (tui_data_window::display_registers_from_line): Update.
4995         * tui/tui-data.h (struct tui_data_window)
4996         <display_reg_element_at_line>: New method.
4997
4998 2019-07-17  Tom Tromey  <tom@tromey.com>
4999
5000         * tui/tui-regs.h (tui_display_registers_from)
5001         (tui_display_registers_from_line): Don't declare.
5002         * tui/tui-windata.c (tui_data_window::display_all_data)
5003         (tui_data_window::refresh_all)
5004         (tui_data_window::do_scroll_vertical): Update.
5005         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
5006         from tui_display_registers_from.
5007         (tui_display_reg_element_at_line): Update.
5008         (tui_data_window::display_registers_from_line): Rename from
5009         tui_display_registers_from_line.
5010         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
5011         display_registers_from_line>: New methods.
5012
5013 2019-07-17  Tom Tromey  <tom@tromey.com>
5014
5015         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
5016         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
5017         from tui_erase_data_content.
5018         (tui_data_window::display_all_data)
5019         (tui_data_window::refresh_all)
5020         (tui_data_window::do_scroll_vertical): Update.
5021         * tui/tui-regs.c (tui_show_registers): Update.
5022         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
5023         New method.
5024
5025 2019-07-17  Tom Tromey  <tom@tromey.com>
5026
5027         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
5028         declare.
5029         * tui/tui-windata.c
5030         (tui_data_window::delete_data_content_windows): Rename from
5031         tui_delete_data_content_windows.
5032         (tui_data_window::display_all_data)
5033         (tui_data_window::do_scroll_vertical): Update.
5034         * tui/tui-data.h (struct tui_data_window)
5035         <delete_data_content_windows>: New method.
5036
5037 2019-07-17  Tom Tromey  <tom@tromey.com>
5038
5039         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
5040         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
5041
5042 2019-07-17  Tom Tromey  <tom@tromey.com>
5043
5044         * tui/tui-windata.h (tui_display_all_data): Don't declare.
5045         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
5046         from tui_display_all_data.
5047         * tui/tui-win.c
5048         (tui_data_window::do_make_visible_with_new_height): Update.
5049         * tui/tui-regs.c (tui_show_registers): Update.
5050         * tui/tui-layout.c (tui_set_layout): Update.
5051         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
5052         method.
5053
5054 2019-07-17  Tom Tromey  <tom@tromey.com>
5055
5056         * tui/tui-windata.h (tui_display_data_from): Don't declare.
5057         * tui/tui-windata.c (tui_display_data_from): Remove.
5058         (tui_data_window::refresh_all): Update.
5059
5060 2019-07-17  Tom Tromey  <tom@tromey.com>
5061
5062         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
5063         * tui/tui-windata.c (tui_display_data_from_line): Remove.
5064         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
5065         tui_display_registers_from_line.
5066         * tui/tui-regs.h (tui_display_registers_from_line): Update.
5067         * tui/tui-regs.c (tui_display_registers_from_line): Remove
5068         "force_display" parameter.
5069
5070 2019-07-17  Tom Tromey  <tom@tromey.com>
5071
5072         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
5073         declare.
5074         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
5075         Rename from tui_first_reg_element_no_inline.
5076         (tui_display_reg_element_at_line)
5077         (tui_display_registers_from_line): Update.
5078         * tui/tui-data.h (struct tui_data_window)
5079         <first_reg_element_no_inline>: New method.
5080
5081 2019-07-17  Tom Tromey  <tom@tromey.com>
5082
5083         * tui/tui-windata.c (tui_display_data_from)
5084         (tui_data_window::do_scroll_vertical): Update.
5085         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
5086         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
5087         Rename from tui_line_from_reg_element_no.
5088         (tui_display_registers_from_line): Update.
5089         * tui/tui-data.h (struct tui_data_window)
5090         <line_from_reg_element_no>: New method.
5091
5092 2019-07-17  Tom Tromey  <tom@tromey.com>
5093
5094         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
5095         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
5096         tui_last_regs_line_no.
5097         (tui_display_reg_element_at_line)
5098         (tui_display_registers_from_line): Update.
5099         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
5100         method.
5101
5102 2019-07-17  Tom Tromey  <tom@tromey.com>
5103
5104         PR tui/24722:
5105         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
5106         (tui_update_breakpoint_info): Add "being_deleted" parameter.
5107         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
5108         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
5109         (tui_update_breakpoint_info): Likewise.
5110         * tui/tui-hooks.c (tui_event_create_breakpoint)
5111         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
5112         Update.
5113
5114 2019-07-17  Tom Tromey  <tom@tromey.com>
5115
5116         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
5117
5118 2019-07-17  Tom Tromey  <tom@tromey.com>
5119
5120         * tui/tui-winsource.c (tui_update_source_window_as_is)
5121         (tui_update_source_windows_with_addr): Update.
5122         * tui/tui-source.h (tui_set_source_content)
5123         (tui_show_symtab_source): Add "win_info" parameter.
5124         * tui/tui-source.c (tui_set_source_content): Add "win_info"
5125         parameter.
5126         (tui_show_symtab_source): Likewise.
5127
5128 2019-07-17  Tom Tromey  <tom@tromey.com>
5129
5130         * tui/tui-wingeneral.c
5131         (tui_check_and_display_highlight_if_needed): Check can_highlight.
5132
5133 2019-07-17  Tom Tromey  <tom@tromey.com>
5134
5135         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
5136         (struct tui_cmd_window) <can_scroll>: New method.
5137         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
5138         method.
5139
5140 2019-07-17  Tom Tromey  <tromey@adacore.com>
5141
5142         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
5143         do_field_signed>: Rename.  Change type of "value".
5144         * ui-out.c (ui_out::field_signed): Rename from field_int.
5145         Change type of "value".
5146         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
5147         type of "value".
5148         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
5149         do_field_int.  Change type of "value".
5150         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
5151         do_field_int.  Change type of "value".
5152         * tracepoint.c (trace_status_mi, tfind_1)
5153         (print_one_static_tracepoint_marker): Update.
5154         * thread.c (print_thread_info_1, print_selected_thread_frame):
5155         Update.
5156         * stack.c (print_frame, print_frame_info): Update.
5157         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
5158         Update.
5159         * source.c (print_source_lines_base): Update.
5160         * skip.c (info_skip_command): Update.
5161         * record-btrace.c (btrace_ui_out_decode_error)
5162         (btrace_call_history_src_line): Update.
5163         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
5164         Update.
5165         * progspace.c (print_program_space): Update.
5166         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
5167         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
5168         do_field_int.  Change type of "value".
5169         * mi/mi-out.c (mi_ui_out::do_table_begin)
5170         (mi_ui_out::do_table_header): Update.
5171         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
5172         type of "value".
5173         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
5174         (mi_cmd_data_list_changed_registers, output_register)
5175         (mi_cmd_data_read_memory, mi_load_progress)
5176         (mi_cmd_trace_frame_collected): Update.
5177         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
5178         Update.
5179         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
5180         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
5181         (mi_cmd_var_list_children, varobj_update_one): Update.
5182         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
5183         (mi_cmd_stack_list_args, list_arg_or_local): Update.
5184         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
5185         * inferior.c (print_inferior): Update.
5186         * gdb_bfd.c (print_one_bfd): Update.
5187         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
5188         Update.
5189         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
5190         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
5191         do_field_int.  Change type of "value".
5192         * cli-out.c (cli_ui_out::do_field_signed): Rename from
5193         do_field_int.  Change type of "value".
5194         * breakpoint.c (watchpoint_check, print_breakpoint_location)
5195         (print_one_breakpoint_location, print_it_catch_fork)
5196         (print_one_catch_fork, print_it_catch_vfork)
5197         (print_one_catch_vfork, print_it_catch_solib)
5198         (print_it_catch_exec, print_it_ranged_breakpoint)
5199         (print_mention_watchpoint, print_mention_masked_watchpoint)
5200         (bkpt_print_it, update_static_tracepoint): Update.
5201         * break-catch-throw.c (print_it_exception_catchpoint): Update.
5202         * break-catch-syscall.c (print_it_catch_syscall): Update.
5203         * ada-tasks.c (print_ada_task_info): Update.
5204         * ada-lang.c (print_it_exception, print_mention_exception):
5205         Update.
5206
5207 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
5208
5209         PR breakpoints/24541
5210         * gdbarch.c: Regenerate.
5211         * gdbarch.h: Regenerate.
5212         * gdbarch.sh: Adjust return type and parameter types for
5213         'stap_adjust_register'.
5214         (i386_stap_adjust_register): Adjust signature and return new
5215         register name.
5216         * stap-probe.c (stap_parse_register_operand): Adjust use of
5217         'gdbarch_stap_adjust_register'.
5218
5219 2019-07-17  Tom Tromey  <tromey@adacore.com>
5220
5221         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
5222         declare VEC.
5223         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
5224         std::vector.
5225         (struct s390_process_info): Add initializers.
5226         (s390_add_process): Use new.
5227         (s390_linux_nat_target::low_forget_process): Use delete.
5228         (s390_linux_nat_target::low_new_fork)
5229         (s390_linux_nat_target::stopped_by_watchpoint)
5230         (s390_linux_nat_target::low_prepare_to_resume)
5231         (s390_linux_nat_target::insert_watchpoint)
5232         (s390_linux_nat_target::insert_hw_breakpoint)
5233         (s390_linux_nat_target::remove_watchpoint)
5234         (s390_linux_nat_target::remove_hw_breakpoint): Update.
5235
5236 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
5237
5238         * aarch64-fbsd-nat.c: Include regcache.h.
5239         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
5240         argument.
5241         (aarch64_fbsd_nat_target::fetch_registers)
5242         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
5243         variable.
5244         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
5245
5246 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
5247
5248         * fbsd-nat.c: Include gdbarch.h.
5249
5250 2019-07-15  Tom Tromey  <tromey@adacore.com>
5251
5252         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
5253
5254 2019-07-15  Tom Tromey  <tromey@adacore.com>
5255
5256         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
5257         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
5258         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
5259         * cli-out.c (cli_ui_out::do_field_int): New method.
5260         * ui-out.c (ui_out::field_unsigned): New method.
5261         * symfile.c (generic_load): Use field_unsigned.
5262         (print_transfer_performance): Likewise.
5263         * record-btrace.c (ui_out_field_uint): Remove.
5264         (btrace_call_history_insn_range, btrace_call_history): Use
5265         field_unsigned.
5266         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
5267         field_unsigned.
5268         * ui-out.h (class ui_out) <field_unsigned>: New method.
5269         <do_field_unsigned>: Likewise.
5270
5271 2019-07-15  Tom Tromey  <tromey@adacore.com>
5272
5273         * mi/mi-main.c (list_available_thread_groups): Use field_string.
5274         * mi/mi-interp.c (mi_memory_changed): Use field_string.
5275         * target.c (flash_erase_command): Use field_string.
5276         * infrun.c (print_signal_received_reason): Use field_string.
5277         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
5278         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
5279         field_string.
5280         * ada-tasks.c (print_ada_task_info): Use field_string.
5281
5282 2019-07-15  Tom Tromey  <tromey@adacore.com>
5283
5284         * target.c (flash_erase_command): Use field_core_addr.
5285         * symfile.c (generic_load): Use field_core_addr.
5286         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
5287         Use field_core_addr.
5288         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
5289         field_core_addr.
5290
5291 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
5292
5293         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
5294         value if its desired type is smaller than a CORE_ADDR and signed.
5295
5296 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
5297
5298         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
5299         of changes to field names, and use new is_reference field to
5300         decide if a property is a reference or not.
5301         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
5302         field.
5303         (struct dwarf2_property_baton): Update header comment, rename
5304         'referenced_type' to 'property_type' and update comments.
5305         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
5306         default property type, store in property baton, update to take
5307         accound of renamed field.
5308         (read_func_scope): Update call to attr_to_dynamic_prop.
5309         (read_array_type): Likewise.
5310         (dwarf2_per_cu_addr_sized_int_type): New function.
5311         (read_subrange_index_type): Move type finding code to
5312         dwarf2_per_cu_addr_sized_int_type.
5313         (read_subrange_type): Update calls to attr_to_dynamic_prop.
5314         (dwarf2_per_cu_addr_type): New function.
5315         (set_die_type): Update calls to attr_to_dynamic_prop.
5316
5317 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
5318
5319         * dwarf2read.c (read_subrange_index_type): New function.
5320         (read_subrange_type): Move code into new function and call it.
5321         * gdbtypes.c (create_range_type): Add some asserts.
5322
5323 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
5324
5325         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
5326         update return statements.
5327         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
5328         declaration, and update comment to match.
5329         * gdbtypes.c (resolve_dynamic_array): Update call to
5330         dwarf2_evaluate_property to match new return type.
5331
5332 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
5333
5334         * valarith.c (value_subscripted_rvalue): Change lowerbound
5335         parameter type from int to LONGEST.
5336         * value.h (value_subscripted_rvalue): Likewise in declaration.
5337
5338 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5339
5340         * cli/cli-utils.c (info_print_command_completer): New function.
5341         * cli/cli-utils.h: Add 'completer.h' include, and forward
5342         declaration for 'struct cmd_list_element'.
5343         (info_print_command_completer): Declare.
5344         * stack.c (_initialize_stack): Add completer for 'info locals' and
5345         'info args'.
5346         * symtab.c (_initialize_symtab): Add completer for 'info
5347         variables' and 'info functions'.
5348         * NEWS: Mention completion for additional info commands.
5349
5350 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5351
5352         * cli/cli-utils.c (extract_info_print_args): Delete.
5353         (extract_arg_maybe_quoted): Delete.
5354         (info_print_options_defs): New variable.
5355         (make_info_print_options_def_group): New function.
5356         (extract_info_print_options): Define new function.
5357         * cli/cli-utils.h (extract_info_print_args): Delete.
5358         (struct info_print_options): New structure.
5359         (extract_info_print_options): Declare new function.
5360         * stack.c (info_locals_command): Update to use new
5361         extract_info_print_options, also add a header comment.
5362         (info_args_command): Likewise.
5363         * symtab.c (info_variables_command): Likewise.
5364         (info_functions_command): Likewise.
5365
5366 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5367
5368         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
5369         to extract string arguments.
5370         * common/common-utils.c (extract_string_maybe_quoted): New function.
5371         * common/common-utils.h (extract_string_maybe_quoted): Declare.
5372
5373 2019-07-11  Tom Tromey  <tromey@adacore.com>
5374
5375         * main.c (get_init_files): Use GDBINIT, not gdbinit.
5376         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
5377         * top.h (gdbinit): Don't declare.
5378         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
5379         into...
5380         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
5381         * top.c (gdb_init): Don't call init_cli_cmds.
5382         (gdbinit): Remove.
5383         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
5384
5385 2019-07-11  Tom Tromey  <tromey@adacore.com>
5386
5387         * python/py-inferior.c (add_thread_object): Don't use thread_obj
5388         after it has been moved.
5389
5390 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
5391
5392         * valops.c (value_must_coerce_to_target): Change return type to
5393         bool.
5394         * value.h (value_must_coerce_to_target): Likewise.
5395
5396 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
5397
5398         * breakpoint.c (is_hardware_watchpoint): Remove
5399         forward-declaration.
5400         (is_masked_watchpoint): Change return type to bool.
5401         (is_tracepoint): Likewise.
5402         (is_breakpoint): Likewise.
5403         (is_hardware_watchpoint): Likewise.
5404         (is_watchpoint): Likewise.
5405         (is_no_memory_software_watchpoint): Likewise.
5406         (is_catchpoint): Likewise.
5407         (breakpoint_1): Make FILTER parameter's return type bool.
5408         is_masked_watchpoint): Change return type to bool.
5409         (save_breakpoints): Make FILTER parameter's return type bool.
5410         * breakpoint.h (is_breakpoint): Change return type to bool.
5411         (is_watchpoint): Likewise.
5412         (is_catchpoint): Likewise.
5413         (is_tracepoint): Likewise.
5414
5415 2019-07-10  Tom Tromey  <tom@tromey.com>
5416
5417         * defs.h: Don't include gdbarch.h.
5418         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
5419         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
5420         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
5421         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
5422         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
5423         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
5424         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
5425         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
5426         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
5427         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
5428         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
5429         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
5430         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
5431         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
5432         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
5433         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
5434         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
5435         record-btrace.c, record.h, regcache-dump.c, regcache.h,
5436         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
5437         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
5438         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
5439         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
5440         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
5441         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
5442         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
5443         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
5444         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
5445
5446 2019-07-10  Tom Tromey  <tromey@adacore.com>
5447
5448         * ada-lang.h (is_ada_exception_catchpoint): Declare.
5449         * breakpoint.c (init_ada_exception_breakpoint): Register as
5450         bp_catchpoint.
5451         (print_one_breakpoint_location, print_one_breakpoint): Use
5452         is_ada_exception_catchpoint.
5453         * ada-lang.c (class ada_catchpoint_location): Pass
5454         bp_loc_software_breakpoint to bp_location constructor.
5455         (is_ada_exception_catchpoint): New function.
5456
5457 2019-07-10  Tom Tromey  <tromey@adacore.com>
5458
5459         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
5460         VEC.
5461         (struct arm_exidx_entry): New method operator<.
5462         (struct arm_exidx_data) <section_maps>: Change type.
5463         (arm_exidx_data_free): Remove.
5464         (arm_exidx_data_key): Change type.  Move lower.
5465         (arm_exidx_new_objfile): Update.
5466         (arm_compare_exidx_entries): Remove.
5467         (arm_find_exidx_entry, _initialize_arm_tdep)
5468
5469 2019-07-10  Tom Tromey  <tromey@adacore.com>
5470
5471         * solib-spu.c (ocl_program_data_key): Change type.
5472         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
5473         Update.
5474
5475 2019-07-10  Tom Tromey  <tromey@adacore.com>
5476
5477         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
5478         (struct solib_aix_inferior_data) <library_list>: Change type.
5479         (solib_aix_inferior_data_handle): Change type.
5480         (get_solib_aix_inferior_data): Update.
5481         (solib_aix_free_library_list): Remove.
5482         (library_list_start_library): Update.
5483         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
5484         return type.
5485         (solib_aix_get_library_list)
5486         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
5487         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
5488
5489 2019-07-10  Tom Tromey  <tromey@adacore.com>
5490
5491         * solib-dsbt.c (struct dsbt_info): Add initializers.
5492         (solib_dsbt_pspace_data): Change type.
5493         (dsbt_pspace_data_cleanup): Remove.
5494         (get_dsbt_info, _initialize_dsbt_solib): Update.
5495
5496 2019-07-10  Tom Tromey  <tromey@adacore.com>
5497
5498         * spu-tdep.c (spu_overlay_data): Change type.
5499         (spu_get_overlay_table, spu_overlay_new_objfile)
5500         (_initialize_spu_tdep): Update.
5501
5502 2019-07-10  Tom Tromey  <tromey@adacore.com>
5503
5504         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
5505         destructor.
5506         (dbx_objfile_data_key): Change type and declare later.
5507         (DBX_SYMFILE_INFO): Rewrite.
5508         * dbxread.c (dbx_objfile_data_key): Change type.
5509         (dbx_symfile_init): Update.
5510         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
5511         (coffstab_build_psymtabs, elfstab_build_psymtabs)
5512         (stabsect_build_psymtabs, _initialize_dbxread): Update.
5513
5514 2019-07-10  Tom Tromey  <tromey@adacore.com>
5515
5516         * jit.c (jit_program_space_key): Change type.  Move lower.
5517         (get_jit_program_space_data): Update.
5518         (jit_program_space_data_cleanup): Remove.
5519         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
5520         Update.
5521         (struct jit_program_space_data): Add initializers.
5522
5523 2019-07-10  Tom Tromey  <tromey@adacore.com>
5524
5525         * solib-darwin.c (struct darwin_info): Add initializers.
5526         (solib_darwin_pspace_data): Change type.
5527         (darwin_pspace_data_cleanup): Remove.
5528         (get_darwin_info, _initialize_darwin_solib): Update.
5529
5530 2019-07-10  Tom Tromey  <tromey@adacore.com>
5531
5532         * remote-sim.c (struct sim_inferior_data): Add initializers,
5533         constructor, and destructor.
5534         (sim_inferior_data_key): Change type.  Move lower.
5535         (check_for_duplicate_sim_descriptor): Update.
5536         (get_sim_inferior_data): Use new.  Update.
5537         (~sim_inferior_data_cleanup): Rename from
5538         sim_inferior_data_cleanup.  Simplify.
5539         (gdbsim_close_inferior, simulator_command)
5540         (sim_command_completer, _initialize_remote_sim): Update.
5541         (next_pid, INITIAL_PID): Move earlier.
5542
5543 2019-07-10  Tom Tromey  <tromey@adacore.com>
5544
5545         * python/python-internal.h (create_thread_object): Return
5546         gdbpy_ref.
5547         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
5548         * python/py-inferior.c (struct threadlist_entry): Add
5549         constructor.
5550         <thread_obj>: Now a gdbpy_ref.
5551         (thread_to_thread_object): Update.
5552         (add_thread_object): Use new.
5553         (delete_thread_object): Use delete.
5554         (infpy_threads): Update.
5555         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
5556         GIL.
5557
5558 2019-07-10  Tom Tromey  <tromey@adacore.com>
5559
5560         * valops.c (value_cast): Specialize error message for Ada.
5561
5562 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
5563
5564         * breakpoint.c (breakpoint_1): Update doc and parameter names.
5565
5566 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
5567
5568         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
5569         bpstat_should_step): Return bool, adjust comments.
5570         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
5571         bpstat_should_step): Likewise.
5572
5573 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
5574
5575         * features/Makefile: Use feature target descriptions for Arm.
5576         * features/arm/arm-core.c: Generate new file.
5577         * features/arm/arm-fpa.c: Likewise.
5578         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
5579         * features/arm/arm-m-profile.c: Likewise.
5580         * features/arm/arm-vfpv2.c: Likewise.
5581         * features/arm/arm-vfpv3.c: Likewise.
5582         * features/arm/xscale-iwmmxt.c: Likewise.
5583         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
5584
5585 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
5586
5587         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
5588         ptrace earlier.
5589
5590 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
5591
5592         * features/aarch64-pauth.c: Regenerate.
5593
5594 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
5595
5596         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
5597         bool.
5598         (bpstat_what): Use false instead of 0.
5599
5600 2019-07-09  Pedro Alves  <palves@redhat.com>
5601
5602         * break-catch-throw.c (is_exception_catchpoint): New.
5603         * breakpoint.c (print_one_breakpoint_location): New parameter
5604         'raw_loc'.  Handle it.  Use
5605         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
5606         looking at the breakpoint's type.
5607         (print_one_breakpoint): If handling "maint info breakpoints", also
5608         print locations of exception catchpoints.
5609         * breakpoint.h (is_exception_catchpoint): Declare.
5610
5611 2019-07-09  Pedro Alves  <palves@redhat.com>
5612
5613         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
5614         "addr" field.
5615         (allocate_location_exception_catchpoint): New.
5616         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
5617         (initialize_throw_catchpoint_ops): Install
5618         allocate_location_exception_catchpoint as allocate_location
5619         method.
5620         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
5621         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
5622         bp_loc_other.
5623         (breakpoint_address_is_meaningful): Delete.
5624         (bl_address_is_meaningful): New.
5625         (breakpoint_locations_match): Adjust comment.
5626         (bp_location_from_bp_type): New, factored out of...
5627         (bp_location::bp_location(breakpoint *)): ... this.
5628         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
5629         factored out of...
5630         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
5631         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
5632         breakpoint_address_is_meaningful.
5633         (bp_locations_compare): Adjust comment.
5634         (update_global_location_list): Use bl_address_is_meaningful
5635         instead of breakpoint_address_is_meaningful.
5636         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
5637         explicit.
5638         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
5639         * python/py-breakpoint.c (bppy_get_location): No longer check
5640         whether location is null.
5641
5642 2019-07-09  Pedro Alves  <palves@redhat.com>
5643
5644         PR c++/15468
5645         * breakpoint.c (print_one_breakpoint_location): Remove
5646         single-location assert.
5647
5648 2019-07-09  Tom Tromey  <tom@tromey.com>
5649
5650         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
5651         * configure: Rebuild.
5652         * configure.ac: Change common to gdbsupport.
5653         * gdbsupport: Rename from common.
5654         * acinclude.m4: Change common to gdbsupport.
5655         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
5656         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
5657         gdbsupport.
5658         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
5659         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
5660         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
5661         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
5662         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
5663         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
5664         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
5665         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
5666         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
5667         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
5668         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
5669         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
5670         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
5671         coff-pe-read.c, command.h, compile/compile-c-support.c,
5672         compile/compile-c.h, compile/compile-cplus-symbols.c,
5673         compile/compile-cplus-types.c, compile/compile-cplus.h,
5674         compile/compile-loc2c.c, compile/compile.c, completer.c,
5675         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
5676         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
5677         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
5678         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
5679         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
5680         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
5681         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
5682         features/aarch64-core.c, features/aarch64-fpu.c,
5683         features/aarch64-pauth.c, features/aarch64-sve.c,
5684         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
5685         features/i386/32bit-core.c, features/i386/32bit-linux.c,
5686         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
5687         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
5688         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
5689         features/i386/64bit-core.c, features/i386/64bit-linux.c,
5690         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
5691         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
5692         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
5693         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
5694         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
5695         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
5696         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
5697         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
5698         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
5699         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
5700         go32-nat.c, guile/guile.c, guile/scm-ports.c,
5701         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
5702         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
5703         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
5704         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
5705         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
5706         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
5707         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
5708         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
5709         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
5710         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
5711         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
5712         minsyms.c, mips-linux-tdep.c, namespace.h,
5713         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
5714         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
5715         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
5716         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
5717         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
5718         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
5719         nat/linux-waitpid.c, nat/mips-linux-watch.c,
5720         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
5721         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
5722         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
5723         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
5724         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
5725         procfs.c, producer.c, progspace.h, psymtab.h,
5726         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
5727         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
5728         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
5729         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
5730         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
5731         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
5732         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
5733         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
5734         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
5735         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
5736         target-memory.c, target.c, target.h, target/waitstatus.c,
5737         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
5738         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
5739         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
5740         unittests/array-view-selftests.c,
5741         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
5742         unittests/common-utils-selftests.c,
5743         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
5744         unittests/format_pieces-selftests.c,
5745         unittests/function-view-selftests.c,
5746         unittests/lookup_name_info-selftests.c,
5747         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
5748         unittests/mkdir-recursive-selftests.c,
5749         unittests/observable-selftests.c,
5750         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
5751         unittests/parse-connection-spec-selftests.c,
5752         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
5753         unittests/scoped_fd-selftests.c,
5754         unittests/scoped_mmap-selftests.c,
5755         unittests/scoped_restore-selftests.c,
5756         unittests/string_view-selftests.c, unittests/style-selftests.c,
5757         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
5758         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
5759         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
5760         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
5761         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
5762         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
5763
5764 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
5765
5766         * linespec.c (decode_digits_list_mode): Set explicit_line to a
5767         bool value.
5768         (decode_digits_ordinary): Set explicit_line field in sal.
5769         * symtab.c (skip_prologue_sal): Don't skip prologue for a
5770         symtab_and_line that was set on an explicit line number in
5771         assembler code.  Do always update the recorded symtab and line if
5772         we do skip the prologue.
5773
5774 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
5775
5776         * breakpoint.c (set_breakpoint_location_function): Remove
5777         explicit_loc parameter.
5778         (momentary_breakpoint_from_master): Update call to
5779         set_breakpoint_location_function.
5780         (add_location_to_breakpoint): Likewise.
5781
5782 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
5783
5784         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
5785         required features based on default bfd type when no specific bfd
5786         is present.
5787
5788 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5789
5790         * NEWS: Mention that GDB printf and eval commands can now print
5791         C-style and Ada-style convenience var strings without
5792         calling the inferior.
5793         * printcmd.c (printf_c_string): Locally print GDB internal var
5794         instead of transiting via the inferior.
5795         (printf_wide_c_string): Likewise.
5796
5797 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5798
5799         PR breakpoints/25011
5800         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
5801
5802 2019-07-04  Tom Tromey  <tom@tromey.com>
5803
5804         PR tui/24724:
5805         * tui/tui-winsource.c (tui_clear_source_content): Update.
5806         (tui_source_window_base::set_is_exec_point_at): Fix comment.
5807         (tui_update_breakpoint_info): Update.
5808         (tui_set_exec_info_content): Update.
5809         * tui/tui-source.c (tui_set_source_content_nil): Update.
5810         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
5811         has_break.
5812         * tui/tui-data.h (enum tui_bp_flag): New.
5813         (tui_bp_flags): New enum flags type.
5814         (struct tui_source_element) <break_mode>: Change type.  Rename
5815         from has_break.
5816         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
5817         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
5818         constants.
5819         * tui/tui-winsource.h: Fix comment.
5820
5821 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5822
5823         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
5824         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
5825         (store_fpregs_to_thread)
5826         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
5827         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
5828         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
5829         (IWMMXT_REGS_SIZE): Add define.
5830         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
5831         (fetch_vfp_regs, store_vfp_regs)
5832         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
5833         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
5834
5835 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5836
5837         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
5838         defines.
5839         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
5840         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
5841         (ARM_INT_REGISTER_SIZE): ...to this.
5842         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
5843         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
5844         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
5845         (arm_linux_collect_gregset, supply_nwfpe_register)
5846         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
5847         defines.
5848         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
5849         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
5850         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
5851         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
5852         (arm_return_in_memory, arm_store_return_value)
5853         (arm_get_longjmp_target, arm_register_g_packet_guesses)
5854         (arm_record_ld_st_multiple): Likewise.
5855         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
5856         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
5857
5858 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5859
5860         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
5861         AARCH64_DISPLACED_MODIFIED_INSNS.
5862         * aarch64-tdep.c (struct aarch64_displaced_step_data)
5863         (aarch64_displaced_step_copy_insn): Likewise.
5864         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
5865         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
5866         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
5867         ARM_DISPLACED_MODIFIED_INSNS.
5868         * arm-tdep.c (arm_gdbarch_init): Likewise.
5869         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
5870         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
5871         (struct arm_displaced_step_closure): Use
5872         ARM_DISPLACED_MODIFIED_INSNS.
5873
5874 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5875
5876         * features/Makefile: Remove unused xml files.
5877         * features/aarch64.xml: Remove.
5878         * features/i386/amd64-avx-avx512-linux.xml: Remove.
5879         * features/i386/amd64-avx-avx512.xml: Remove.
5880         * features/i386/amd64-avx-linux.xml: Remove.
5881         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
5882         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
5883         * features/i386/amd64-avx-mpx-linux.xml: Remove.
5884         * features/i386/amd64-avx-mpx.xml: Remove.
5885         * features/i386/amd64-avx.xml: Remove.
5886         * features/i386/amd64-linux.xml: Remove.
5887         * features/i386/amd64-mpx-linux.xml: Remove.
5888         * features/i386/amd64-mpx.xml: Remove.
5889         * features/i386/amd64.xml: Remove.
5890         * features/i386/i386-avx-avx512-linux.xml: Remove.
5891         * features/i386/i386-avx-avx512.xml: Remove.
5892         * features/i386/i386-avx-linux.xml: Remove.
5893         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
5894         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
5895         * features/i386/i386-avx-mpx-linux.xml: Remove.
5896         * features/i386/i386-avx-mpx.xml: Remove.
5897         * features/i386/i386-avx.xml: Remove.
5898         * features/i386/i386-linux.xml: Remove.
5899         * features/i386/i386-mmx-linux.xml: Remove.
5900         * features/i386/i386-mmx.xml: Remove.
5901         * features/i386/i386-mpx-linux.xml: Remove.
5902         * features/i386/i386-mpx.xml: Remove.
5903         * features/i386/i386.xml: Remove.
5904         * features/i386/x32-avx-avx512-linux.xml: Remove.
5905         * features/i386/x32-avx-linux.xml: Remove.
5906         * features/i386/x32-linux.xml: Remove.
5907
5908 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5909
5910         * regformats/aarch64.dat: Remove.
5911         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
5912         * regformats/i386/amd64-avx-linux.dat: Remove.
5913         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
5914         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
5915         * regformats/i386/amd64-linux.dat: Remove.
5916         * regformats/i386/amd64-mpx-linux.dat: Remove.
5917         * regformats/i386/amd64.dat: Remove.
5918         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
5919         * regformats/i386/i386-avx-linux.dat: Remove.
5920         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
5921         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
5922         * regformats/i386/i386-linux.dat: Remove.
5923         * regformats/i386/i386-mmx-linux.dat: Remove.
5924         * regformats/i386/i386-mpx-linux.dat: Remove.
5925         * regformats/i386/i386.dat: Remove.
5926         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
5927         * regformats/i386/x32-avx-linux.dat: Remove.
5928         * regformats/i386/x32-linux.dat: Remove.
5929
5930 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5931
5932         * aarch64-tdep.c: Remove xml self tests.
5933         * amd64-linux-tdep.c: Likewise.
5934         * amd64-tdep.c: Likewise.
5935         * i386-linux-tdep.c: Likewise.
5936         * i386-tdep.c: Likewise.
5937
5938 2019-07-03  Pedro Alves  <palves@redhat.com>
5939
5940         PR cli/24732
5941         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
5942         (pipe_cmd_option_defs): New.
5943         (make_pipe_cmd_options_def_group): New.
5944         (pipe_command): Use gdb::option::process_options.
5945         (pipe_command_completer): New function.
5946         (_initialize_cli_cmds): Install completer for "pipe" command.
5947
5948 2019-07-03  Pedro Alves  <palves@redhat.com>
5949
5950         * cli/cli-option.c (union option_value) <string>: New field.
5951         (struct option_def_and_value): Add ctor, move ctor, dtor and
5952         use DISABLE_COPY_AND_ASSIGN.
5953         (option_def_and_value::clear_value): New.
5954         (parse_option, save_option_value_in_ctx, get_val_type_str)
5955         (add_setshow_cmds_for_options): Handle var_string.
5956         * cli-option.h (union option_def::var_address) <string>: New
5957         field.
5958         (struct string_option_def): New.
5959         * maint-test-options.c (struct test_options_opts): Add default
5960         ctor and use DISABLE_COPY_AND_ASSIGN.
5961         <string_opt>: New field.
5962         (test_options_opts::~test_options_opts): New.
5963         (test_options_opts::dump): Also dump "-string".
5964         (test_options_option_defs): Install "string.
5965
5966 2019-07-03  Pedro Alves  <palves@redhat.com>
5967
5968         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
5969         option_value with a null enumeration.
5970         (complete_options): Save the option values in the context.
5971         (save_option_value_in_ctx): New, factored out from ...
5972         (process_options): ... here.
5973         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
5974         of the function.
5975         * maint-test-options.c (test_options_opts::dump): New, factored
5976         out from ...
5977         (maintenance_test_options_command_mode): ... here.
5978         (maintenance_test_options_command_completion_result): Delete.
5979         (maintenance_test_options_command_completion_text): Update
5980         comment.
5981         (maintenance_show_test_options_completion_result): Change
5982         prototype.  Just print
5983         maintenance_test_options_command_completion_text.
5984         (save_completion_result): New.
5985         (maintenance_test_options_completer_mode): Pass options context to
5986         complete_options, and then save a dump.
5987         (_initialize_maint_test_options): Use add_cmd to install "maint
5988         show test-options-completion-result".
5989
5990 2019-07-03  Pedro Alves  <palves@redhat.com>
5991
5992         * NEWS (New commands): Mention "with" and "maint with".
5993         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
5994         (with_command, with_command_completer): New.
5995         (pipe_command): Adjust to new repeat_previous
5996         interface.
5997         (_initialize_cli_cmds): Install the "with" command and its "w"
5998         alias.
5999         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
6000         declarations.
6001         * cli/cli-setshow.c (parse_cli_var_uinteger)
6002         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
6003         argument strings for all var_types.
6004         (get_setshow_command_value_string): New, factored out from ...
6005         (do_show_command): ... this.
6006         * cli/cli-setshow.h: Include <string>.
6007         (get_setshow_command_value_string): Declare.
6008         * command.h (repeat_previous): Now returns const char *.  Adjust
6009         comment.
6010         * maint.c: Include "cli/cli-cmds.h".
6011         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
6012         (_initialize_maint_cmds): Register the "maintenance with" command.
6013         * top.c (repeat_previous): Move bits from pipe_command here:
6014         Return the saved command line, if any; error out if there's no
6015         command to relaunch.
6016
6017 2019-07-03  Pedro Alves  <palves@redhat.com>
6018
6019         * NEWS (New commands): Mention "maint set/show test-settings"
6020         instead of "maint test-settings".
6021         * maint-test-settings.c (maintenance_test_settings_list): Delete.
6022         (maintenance_test_settings_set_list): Rename to ...
6023         (maintenance_set_test_settings_list): ... this.
6024         (maintenance_test_settings_show_list): Rename to  ...
6025         (maintenance_show_test_settings_list): ... this.
6026         (maintenance_test_settings_cmd): Delete.
6027         (maintenance_test_settings_set_cmd): ...
6028         (maintenance_set_test_settings_cmd): ... this.
6029         (maintenance_test_settings_show_cmd): ...
6030         (maintenance_show_test_settings_cmd): ... this.
6031         (maintenance_test_settings_show_value_cmd):
6032         (maintenance_show_test_settings_value_cmd): ... this.
6033         (_initialize_maint_test_settings): No longer install the "maint
6034         test-settings" prefix command.  Rename "maint test-settings set"
6035         to "maint set test-settings", and "maint test-settings show" to
6036         "maint show test-settings".  Adjust all subcommands.
6037
6038 2019-07-03  Pedro Alves  <palves@redhat.com>
6039
6040         * maint-test-settings.c: Fix file's intro comment.  Replace all
6041         references to "test-options" with references to "test-settings",
6042         in comments.
6043
6044 2019-07-03  Pedro Alves  <palves@redhat.com>
6045
6046         * maint-test-settings.c (maintenance_test_settings_xxx)
6047         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
6048         New.
6049         (maintenance_test_settings_enums): Use them.
6050         (maintenance_test_settings_enum): Default to
6051         maintenance_test_settings_xxx.
6052         (_initialize_maint_test_settings): Initialize
6053         MAINTENANCE_TEST_SETTINGS_FILENAME.
6054
6055 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
6056
6057         * breakpoint.h (remove_breakpoints_inf): Change return type to
6058         void, move function documentation here.
6059         * breakpoint.c (remove_breakpoints_inf): Change return type to
6060         void, move function documentation to header.
6061
6062 2019-07-02  Pedro Alves  <palves@redhat.com>
6063
6064         * NEWS (Completion improvements): Mention "info threads".
6065         * thread.c (struct info_threads_opts, info_threads_option_defs)
6066         (make_info_threads_options_def_group): New.
6067         (info_threads_command): Use gdb::option::process_options.
6068         (info_threads_command_completer): New.
6069         (_initialize_thread): Use gdb::option::build_help to build the
6070         help text for "info threads".
6071
6072 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
6073
6074         * defs.h (generic_load): Move from here...
6075         * symfile.h (generic_load): ... to here.  Rename name parameter
6076         to args.
6077         * symfile.c (generic_load): Add comment.
6078
6079 2019-07-01  Tom Tromey  <tromey@adacore.com>
6080
6081         * dwarf2read.c
6082         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
6083         declaration of without_params.  Fix formatting.
6084
6085 2019-07-01  Tom Tromey  <tromey@adacore.com>
6086
6087         * ada-exp.y (find_primitive_type): Update.
6088         * ada-lang.h (ada_lookup_symbol): Update.
6089         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
6090         parameter.
6091         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
6092
6093 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
6094
6095         PR breakpoints/24541
6096         * gdbarch.c: Regenerate.
6097         * gdbarch.h: Regenerate.
6098         * gdbarch.sh: Add 'stap_adjust_register'.
6099         * i386-tdep.c: Include '<unordered_set>'.
6100         (i386_stap_adjust_register): New function.
6101         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
6102         * stap-probe.c (stap_parse_register_operand): Call
6103         'gdbarch_stap_adjust_register'.
6104
6105 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
6106
6107         PR python/24742
6108         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
6109         * python/python.c (do_start_initialization): Use 'xmalloc'
6110         instead of 'PyMem_Malloc'.
6111
6112 2019-06-28  Tom Tromey  <tromey@adacore.com>
6113
6114         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
6115         for Ada.
6116
6117 2019-06-27  Tom Tromey  <tromey@adacore.com>
6118
6119         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
6120         objfile_key.
6121         (arm_find_mapping_symbol, arm_record_special_symbol)
6122         (_initialize_arm_tdep): Update.
6123         (arm_objfile_data_free): Remove.
6124
6125 2019-06-27  Tom Tromey  <tromey@adacore.com>
6126
6127         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
6128         to cp_print_static_field.
6129
6130 2019-06-26  Tom Tromey  <tromey@adacore.com>
6131
6132         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
6133         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
6134         declare.
6135
6136 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
6137
6138         * features/aarch64-core.c (create_feature_aarch64_core):
6139         Regenerate.
6140         * features/aarch64-core.xml: Add cpsr flags.
6141
6142 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
6143
6144         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
6145         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
6146
6147 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
6148
6149         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
6150         field.
6151         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
6152         use.
6153         (arm_record_special_symbol): Don't insert new symbol in sorted
6154         position, push it at the end.
6155
6156 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
6157
6158         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
6159         (arm_mapping_symbol_s): Remove.
6160         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
6161         (arm_mapping_symbol_vec): New typedef.
6162         (struct arm_per_objfile): Add constructor.
6163         <section_maps>: Change type to
6164         std::unique_ptr<arm_mapping_symbol_vec[]>.
6165         (arm_compare_mapping_symbols): Remove.
6166         (arm_find_mapping_symbol): Adjust to section_maps type change.
6167         (arm_objfile_data_free): Call delete on arm_per_objfile.
6168         (arm_record_special_symbol): Adjust to section_maps type change.
6169         Allocate arm_per_objfile with new.
6170
6171 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6172
6173         * cli/cli-cmds.c (alias_command): Compare the alias prefix
6174         with the command prefix.
6175
6176 2019-06-25  Tom Tromey  <tom@tromey.com>
6177
6178         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
6179         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
6180
6181 2019-06-25  Tom Tromey  <tom@tromey.com>
6182
6183         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
6184         type.
6185         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
6186         protected.
6187
6188 2019-06-25  Tom Tromey  <tom@tromey.com>
6189
6190         * tui/tui-winsource.c
6191         (tui_source_window_base::set_is_exec_point_at): Add check against
6192         LOA_ADDRESS.
6193
6194 2019-06-25  Tom Tromey  <tom@tromey.com>
6195
6196         * tui/tui-source.c (tui_set_source_content): Don't check before
6197         xfree.
6198         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
6199
6200 2019-06-25  Tom Tromey  <tom@tromey.com>
6201
6202         * tui/tui-winsource.h (tui_update_source_window_as_is)
6203         (tui_alloc_source_buffer, tui_line_is_displayed)
6204         (tui_addr_is_displayed): Change type of win_info.
6205         * tui/tui-winsource.c (tui_update_source_window_as_is)
6206         (tui_clear_source_content, tui_show_source_line)
6207         (tui_show_source_content, tui_source_window_base::refill)
6208         (tui_source_window_base::set_is_exec_point_at)
6209         (tui_source_window_base::set_is_exec_point_at)
6210         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
6211         (tui_alloc_source_buffer, tui_line_is_displayed)
6212         (tui_addr_is_displayed): Change type of win_info.  Update.
6213         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
6214         (tui_source_window_base::do_make_visible_with_new_height):
6215         Update.
6216         * tui/tui-source.c (tui_set_source_content)
6217         (tui_set_source_content_nil)
6218         (tui_source_window::do_scroll_vertical): Update.
6219         * tui/tui-layout.c (show_layout): Update.
6220         * tui/tui-disasm.c (tui_set_disassem_content)
6221         (tui_disasm_window::do_scroll_vertical): Update.
6222         * tui/tui-data.h (tui_win_content): Remove.
6223         (struct tui_gen_win_info) <content, content_size>: Remove.
6224         (struct tui_source_element): Add initializers and destructor.
6225         (union tui_which_element, struct tui_win_element): Remove.
6226         (struct tui_source_window_base) <content>: New field.
6227         (struct tui_data_window): Remove destructor.
6228         (tui_alloc_content, tui_free_win_content)
6229         (tui_free_all_source_wins_content): Don't declare.
6230         * tui/tui-data.c (tui_initialize_static_data): Update.
6231         (init_content_element, tui_alloc_content): Remove.
6232         (~tui_gen_win_info): Update.
6233         (~tui_data_window, tui_free_all_source_wins_content)
6234         (tui_free_win_content, free_content, free_content_elements):
6235         Remove.
6236
6237 2019-06-25  Tom Tromey  <tom@tromey.com>
6238
6239         * tui/tui-winsource.h (tui_clear_source_content)
6240         (tui_erase_source_content, tui_show_source_content): Change type
6241         of win_info.
6242         * tui/tui-winsource.c (tui_clear_source_content)
6243         (tui_erase_source_content, tui_show_source_content): Change type
6244         of win_info.
6245         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
6246         * tui/tui-source.h (tui_set_source_content_nil): Change type of
6247         win_info.
6248         * tui/tui-source.c (tui_set_source_content_nil): Change type of
6249         win_info.
6250         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
6251
6252 2019-06-25  Tom Tromey  <tom@tromey.com>
6253
6254         * tui/tui-winsource.c (tui_clear_source_content)
6255         (tui_source_window_base::set_is_exec_point_at): Update.
6256         * tui/tui-source.c (tui_set_source_content_nil): Update.
6257         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
6258         a bool.
6259         * tui/tui-data.c (init_content_element): Update.
6260
6261 2019-06-25  Tom Tromey  <tom@tromey.com>
6262
6263         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
6264         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
6265         * tui/tui-layout.c (init_and_make_win): Update.
6266         * tui/tui.h (enum tui_win_type): Update.
6267         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
6268         tui_win_is_auxillary.
6269         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
6270         tui_win_is_auxillary.
6271
6272 2019-06-25  Tom Tromey  <tom@tromey.com>
6273
6274         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
6275         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
6276         (tui_delete_data_content_windows, tui_display_all_data)
6277         (tui_data_window::do_scroll_vertical, tui_display_data_from):
6278         Update.
6279         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
6280         * tui/tui-regs.c (tui_last_regs_line_no)
6281         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
6282         (tui_show_registers): Update.
6283         (tui_show_register_group): Return void.  Update.
6284         (tui_display_registers_from, tui_display_reg_element_at_line)
6285         (tui_display_registers_from_line, tui_check_register_values):
6286         Update.
6287         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
6288         member.
6289         (struct tui_data_window) <regs_content>: Now a std::vector.
6290         <regs_content_count>: Remove.
6291         (tui_add_content_elements, tui_free_data_content): Don't declare.
6292         * tui/tui-data.c (tui_data_window::clear_detail): Update.
6293         (init_content_element): Remove DATA_WIN case.  Add assert.
6294         (tui_add_content_elements): Remove.
6295         (tui_data_window): Update.
6296         (tui_free_data_content): Remove.
6297         (free_content_elements): Remove DATA_WIN case.
6298
6299 2019-06-25  Tom Tromey  <tom@tromey.com>
6300
6301         * tui/tui-data.c (tui_data_item_window): Update.
6302         * tui/tui-windata.h (tui_check_data_values): Don't declare.
6303         * tui/tui-windata.c (tui_display_all_data)
6304         (tui_display_data_from_line): Update.
6305         (tui_check_data_values): Remove.
6306         * tui/tui-regs.c (tui_show_register_group)
6307         (tui_display_reg_element_at_line): Update.
6308         * tui/tui-hooks.c (tui_register_changed)
6309         (tui_refresh_frame_and_register_information): Call
6310         tui_check_register_values.
6311         * tui/tui-data.h (struct tui_data_window) <data_content,
6312         data_content_count, data_type>: Remove.
6313         (enum tui_data_type): Remove.
6314
6315         * tui/tui-data.c (tui_data_window::clear_detail)
6316         (~tui_data_window): Update.
6317
6318 2019-06-25  Tom Tromey  <tom@tromey.com>
6319
6320         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
6321         declare.
6322         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
6323         Rename from tui_first_data_item_displayed.  Update.
6324         (tui_data_window::refresh_all)
6325         (tui_data_window::do_scroll_vertical): Update.
6326         * tui/tui-data.h (struct tui_data_window)
6327         <first_data_item_displayed>: Declare new method.
6328
6329 2019-06-25  Tom Tromey  <tom@tromey.com>
6330
6331         * tui/tui-data.h (tui_init_generic_part): Don't declare.
6332         * tui/tui-data.c (tui_init_generic_part): Remove, moving
6333         contents...
6334         (tui_initialize_static_data): ...here.
6335
6336 2019-06-25  Tom Tromey  <tom@tromey.com>
6337
6338         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
6339         (tui_display_registers_from, tui_check_register_values): Update.
6340         (tui_display_register): Remove win_info parameter; update.
6341         (tui_get_register): Change type of parameters.
6342         * tui/tui-data.h (struct tui_data_element): Remove.
6343         (union tui_which_element) <data>: Remove.
6344         <data_window>: Change type.
6345         (struct tui_data_item_window): New.
6346         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
6347         case.  Add assert.
6348         (~tui_data_item_window): New destructor.
6349         (free_content_elements): Remove DATA_ITEM_WIN case.
6350
6351 2019-06-25  Tom Tromey  <tom@tromey.com>
6352
6353         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
6354         Remove.
6355
6356 2019-06-25  Tom Tromey  <tom@tromey.com>
6357
6358         * tui/tui-data.h (struct tui_command_element): Remove.
6359         (union tui_which_element) <command>: Remove.
6360         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
6361         assert.
6362         (free_content_elements): Remove CMD_WIN case.
6363
6364 2019-06-25  Tom Tromey  <tom@tromey.com>
6365
6366         * tui/tui-layout.c (tui_set_layout): Update.
6367         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
6368         * tui/tui-data.c (layout_def): Update.
6369
6370 2019-06-25  Tom Tromey  <tom@tromey.com>
6371
6372         * tui/tui-wingeneral.c (tui_refresh_all): Update.
6373         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
6374         (tui_source_window_base::set_new_height): Update.
6375         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
6376         Update.
6377         (tui_set_locator_fullname, tui_set_locator_info)
6378         (tui_show_frame_info): Update.
6379         * tui/tui-source.c (tui_set_source_content)
6380         (tui_source_is_displayed): Update.
6381         * tui/tui-layout.c (show_source_disasm_command, show_data)
6382         (show_source_or_disasm_and_command): Update.
6383         * tui/tui-disasm.c (tui_set_disassem_content)
6384         (tui_get_begin_asm_address): Update.
6385         * tui/tui-data.h (struct tui_locator_element): Remove.
6386         (union tui_which_element) <locator>: Remove.
6387         (struct tui_locator_window): New.
6388         (tui_locator_win_info_ptr): Change return type.
6389         * tui/tui-data.c (_locator): Change type.
6390         (tui_locator_win_info_ptr): Change return type.
6391         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
6392         (tui_alloc_content): Add assert.
6393
6394 2019-06-25  Tom Tromey  <tom@tromey.com>
6395
6396         * tui/tui-winsource.c
6397         (tui_exec_info_window::maybe_allocate_content): New method.
6398         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
6399         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
6400         (make_source_or_disasm_window): Add cast.
6401         * tui/tui-data.h (union tui_which_element) <simple_string>:
6402         Remove.
6403         (struct tui_source_info): New.
6404         (struct tui_source_window_base) <execution_info>: Change type.
6405         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
6406         case, and add assert.
6407         (tui_alloc_content): Add assert.
6408
6409 2019-06-25  Tom Tromey  <tom@tromey.com>
6410
6411         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
6412         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
6413         * tui/tui-data.c (tui_alloc_win_info): Remove.
6414
6415 2019-06-25  Tom Tromey  <tom@tromey.com>
6416
6417         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
6418         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
6419         can_highlight.
6420
6421 2019-06-25  Tom Tromey  <tom@tromey.com>
6422
6423         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
6424         make_visible_with_new_height method.
6425         (tui_win_info::make_visible_with_new_height): New method.
6426         (tui_source_window_base::do_make_visible_with_new_height)
6427         (tui_data_window::do_make_visible_with_new_height)
6428         (tui_cmd_window::do_make_visible_with_new_height): New methods.
6429         (make_visible_with_new_height): Remove.
6430         (tui_resize_all, tui_adjust_win_heights): Use
6431         make_visible_with_new_height method.
6432         * tui/tui-data.h (struct tui_win_info)
6433         <do_make_visible_with_new_height, make_visible_with_new_height>:
6434         New methods.
6435         (struct tui_source_window_base, struct tui_data_window)
6436         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
6437         methods.
6438
6439 2019-06-25  Tom Tromey  <tom@tromey.com>
6440
6441         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
6442         method.
6443         (update_tab_width): Call update_tab_width method.
6444         * tui/tui-data.h (struct tui_win_info)
6445         (struct tui_source_window_base) <update_tab_width>: New methods.
6446
6447 2019-06-25  Tom Tromey  <tom@tromey.com>
6448
6449         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
6450         parameter.
6451         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
6452         parameter.
6453         (tui_gen_win_info::make_visible): Update.
6454         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
6455         parameter.
6456         * tui/tui-data.h (enum tui_box): New enum.
6457         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
6458
6459 2019-06-25  Tom Tromey  <tom@tromey.com>
6460
6461         * tui/tui-layout.c (make_source_or_disasm_window): Always use
6462         init_and_make_win for EXEC_INFO_WIN.
6463         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
6464         longer inline.
6465         (struct tui_win_info) <~tui_win_info>: Inline.
6466         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
6467         Don't declare.
6468         * tui/tui-data.c (source_win, disasm_win): Remove globals.
6469         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
6470         Remove.
6471         (tui_initialize_static_data): Update.
6472         (~tui_gen_win_info): Handle more cleanup here.
6473         (~tui_source_window_base): Delete "execution_info".
6474         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
6475
6476 2019-06-25  Tom Tromey  <tom@tromey.com>
6477
6478         * tui/tui-layout.c (make_command_window): Don't set
6479         can_highlight.
6480         (show_source_disasm_command): Call the reset method.
6481         (show_data): Don't set can_highlight.  Call the reset method.
6482         (tui_gen_win_info::reset): Rename from init_gen_win_info
6483         (init_and_make_win): Simplify.  Return tui_gen_win_info.
6484         (show_source_or_disasm_and_command): Call the reset method.
6485         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
6486         (struct tui_cmd_window): Set can_highlight.
6487
6488 2019-06-25  Tom Tromey  <tom@tromey.com>
6489
6490         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
6491         from make_visible.
6492         (tui_make_visible, tui_make_invisible): Rewrite.
6493         (tui_win_info::make_visible): Remove.
6494         (tui_source_window_base::make_visible): Update.
6495         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
6496         method.  Moved from...
6497         (struct tui_win_info) <make_visible>: ...here.
6498
6499 2019-06-25  Tom Tromey  <tom@tromey.com>
6500
6501         * tui/tui-winsource.c
6502         (tui_source_window_base::do_scroll_horizontal): Remove direction
6503         parameter.
6504         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
6505         direction parameter.
6506         * tui/tui-win.c (tui_win_info::forward_scroll)
6507         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
6508         (tui_win_info::right_scroll): Update.
6509         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
6510         direction parameter.
6511         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
6512         direction parameter.
6513         * tui/tui-data.h (enum tui_scroll_direction): Remove.
6514         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
6515         Remove direction parameter.
6516         (struct tui_source_window_base, struct tui_source_window)
6517         (struct tui_disasm_window, struct tui_data_window)
6518         (struct tui_cmd_window): Update.
6519
6520 2019-06-25  Tom Tromey  <tom@tromey.com>
6521
6522         * tui/tui-winsource.h (tui_set_exec_info_content)
6523         (tui_show_exec_info_content, tui_erase_exec_info_content)
6524         (tui_clear_exec_info_content, tui_update_exec_info): Change
6525         argument to tui_source_window_base.
6526         * tui/tui-winsource.c (tui_set_exec_info_content)
6527         (tui_show_exec_info_content, tui_erase_exec_info_content)
6528         (tui_clear_exec_info_content, tui_update_exec_info): Change
6529         argument to tui_source_window_base.
6530
6531 2019-06-25  Tom Tromey  <tom@tromey.com>
6532
6533         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
6534         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
6535
6536 2019-06-25  Tom Tromey  <tom@tromey.com>
6537
6538         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
6539         check.
6540
6541 2019-06-25  Tom Tromey  <tom@tromey.com>
6542
6543         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
6544         type to void.
6545         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
6546         type to void.
6547         * tui/tui-source.c (tui_set_source_content): Update.
6548         * tui/tui-disasm.c (tui_set_disassem_content): Update.
6549
6550 2019-06-25  Tom Tromey  <tom@tromey.com>
6551
6552         * tui/tui-win.c (window_name_completer, tui_set_focus)
6553         (tui_all_windows_info): Use name method.
6554         * tui/tui-data.h (struct tui_gen_win_info)
6555         (struct tui_source_window, struct tui_disasm_window)
6556         (struct tui_data_window, struct tui_cmd_window) <name>: New
6557         method.
6558         (tui_win_name): Don't declare.
6559         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
6560         (tui_win_name): Remove.
6561
6562 2019-06-25  Tom Tromey  <tom@tromey.com>
6563
6564         * tui/tui-winsource.h (tui_update_source_window)
6565         (tui_update_source_window_as_is): Change parameter type.
6566         * tui/tui-winsource.c (tui_update_source_window): Change win_info
6567         to be a tui_source_window_base.
6568         (tui_update_source_window_as_is): Likewise.
6569         * tui/tui-win.c (make_visible_with_new_height): Update.
6570
6571 2019-06-25  Tom Tromey  <tom@tromey.com>
6572
6573         * tui/tui-winsource.c (tui_erase_source_content)
6574         (tui_show_source_content, tui_show_exec_info_content)
6575         (tui_erase_exec_info_content): Use refresh_window method.
6576         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
6577         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
6578         from tui_refresh_win.
6579         (tui_data_window::refresh_window): New method.
6580         (tui_win_info::refresh, tui_source_window_base::refresh)
6581         (tui_refresh_all): Use refresh_window method.
6582         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
6583         method.
6584         * tui/tui-regs.c (tui_display_register): Call refresh_window
6585         method.
6586         * tui/tui-layout.c (show_source_disasm_command)
6587         (show_source_or_disasm_and_command): Call refresh_window method.
6588         * tui/tui-data.h (struct tui_gen_win_info)
6589         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
6590         New method.
6591
6592 2019-06-25  Tom Tromey  <tom@tromey.com>
6593
6594         * tui/tui.c (tui_rl_other_window, tui_enable)
6595         (tui_is_window_visible, tui_get_command_dimension): Update.
6596         * tui/tui-winsource.c (tui_update_source_window_as_is)
6597         (tui_clear_source_content, tui_erase_source_content)
6598         (tui_show_source_line, tui_source_window_base::refill)
6599         (tui_source_window_base::do_scroll_horizontal)
6600         (tui_source_window_base::set_is_exec_point_at)
6601         (tui_update_breakpoint_info, tui_set_exec_info_content)
6602         (tui_alloc_source_buffer, tui_line_is_displayed)
6603         (tui_addr_is_displayed): Update.
6604         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
6605         (tui_check_and_display_highlight_if_needed)
6606         (tui_win_info::make_visible, tui_win_info::refresh)
6607         (tui_refresh_all): Update.
6608         * tui/tui-windata.c (tui_first_data_item_displayed)
6609         (tui_delete_data_content_windows, tui_erase_data_content)
6610         (tui_display_all_data, tui_data_window::refresh_all)
6611         (tui_check_data_values): Update.
6612         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
6613         (tui_set_win_focus_to, tui_win_info::forward_scroll)
6614         (tui_win_info::backward_scroll, tui_refresh_all_win)
6615         (tui_resize_all, tui_set_focus, tui_all_windows_info)
6616         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
6617         (tui_source_window_base::set_new_height)
6618         (tui_data_window::set_new_height)
6619         (make_invisible_and_set_new_height)
6620         (make_visible_with_new_height, new_height_ok)
6621         (parse_scrolling_args): Update.
6622         * tui/tui-stack.c (tui_show_frame_info): Update.
6623         * tui/tui-source.c (tui_set_source_content)
6624         (tui_set_source_content_nil, tui_source_is_displayed)
6625         (tui_source_window::do_scroll_vertical): Update.
6626         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
6627         (tui_display_registers_from, tui_display_reg_element_at_line)
6628         (tui_check_register_values, tui_reg_command): Update.
6629         * tui/tui-layout.c (tui_default_win_height)
6630         (show_source_disasm_command, show_data, init_and_make_win)
6631         (show_source_or_disasm_and_command): Update.
6632         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
6633         (tui_redisplay_readline, tui_mld_flush)
6634         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
6635         (tui_getc): Update.
6636         * tui/tui-disasm.c (tui_set_disassem_content)
6637         (tui_disasm_window::do_scroll_vertical): Update.
6638         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
6639         Now virtual.
6640         (struct tui_win_info): Derive from tui_gen_win_info.
6641         <~tui_win_info>: Mark as override.
6642         <generic>: Remove member.
6643         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
6644         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
6645         (~tui_data_window, ~tui_win_info)
6646         (tui_free_all_source_wins_content): Update.
6647         * tui/tui-command.c (tui_refresh_cmd_win): Update.
6648
6649 2019-06-25  Tom Tromey  <tom@tromey.com>
6650
6651         * tui/tui-layout.c (init_and_make_win): Use new.
6652         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
6653         destructor, initializers.
6654         (tui_alloc_generic_win_info): Don't declare.
6655         * tui/tui-data.c (_locator): Add argument to constructor.
6656         (source_win, disasm_win): New globals.
6657         (exec_info): Remove.
6658         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
6659         Update.
6660         (tui_alloc_generic_win_info): Remove.
6661         (init_content_element): Use new.
6662         (tui_win_info::tui_win_info): Update.
6663         (free_content_elements) <case DATA_WIN>: Use delete.
6664
6665 2019-06-25  Tom Tromey  <tom@tromey.com>
6666
6667         * tui/tui-wingeneral.c (tui_refresh_win): Update.
6668         * tui/tui-windata.c (tui_first_data_item_displayed)
6669         (tui_delete_data_content_windows): Update.
6670         * tui/tui-win.c (tui_data_window::set_new_height): Update.
6671         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
6672         (tui_display_registers_from, tui_check_register_values): Update.
6673         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
6674         pointer.
6675         * tui/tui-data.c (init_content_element): Update.  Allocate the new
6676         window.
6677         (tui_free_data_content): Update.
6678         (free_content_elements) <case DATA_WIN>: Free the window.
6679
6680 2019-06-25  Tom Tromey  <tom@tromey.com>
6681
6682         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
6683         Update.
6684         * tui/tui-layout.c (make_command_window)
6685         (show_source_disasm_command, show_data, init_and_make_win)
6686         (show_source_or_disasm_and_command): Update.
6687         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
6688         method.
6689         <can_highight, is_highlighted>: Now bool.
6690         (tui_set_win_highlight): Don't declare.
6691         * tui/tui-data.c (tui_set_win_highlight): Remove.
6692
6693 2019-06-25  Tom Tromey  <tom@tromey.com>
6694
6695         * tui/tui-wingeneral.c (make_visible): Remove check of window
6696         type.
6697
6698 2019-06-25  Tom Tromey  <tom@tromey.com>
6699
6700         * tui/tui-win.c (tui_win_info::max_height)
6701         (tui_cmd_window::max_height): New methods.
6702         (new_height_ok): Call max_height.
6703         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
6704         <max_height>: New method.
6705
6706 2019-06-25  Tom Tromey  <tom@tromey.com>
6707
6708         * tui/tui-win.c (tui_source_window_base::set_new_height)
6709         (tui_data_window::set_new_height): New methods.
6710         (make_invisible_and_set_new_height): Call set_new_height method.
6711         * tui/tui-data.h (struct tui_win_info)
6712         (struct tui_source_window_base, struct tui_data_window)
6713         <set_new_height>: New method.
6714
6715 2019-06-25  Tom Tromey  <tom@tromey.com>
6716
6717         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
6718         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
6719         tui_refresh_data_win.
6720         * tui/tui-win.c (tui_source_window_base::refresh_all): New
6721         method.
6722         (tui_refresh_all_win): Call the refresh_all method.
6723         (tui_set_focus): Likewise.
6724         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
6725         (struct tui_source_window_base, struct tui_data_window) <refresh>:
6726         Likewise.
6727
6728 2019-06-25  Tom Tromey  <tom@tromey.com>
6729
6730         * tui/tui-winsource.h (tui_refill_source_window)
6731         (tui_set_is_exec_point_at): Don't declare.
6732         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
6733         (tui_source_window_base::refill): Rename from
6734         tui_refill_source_window.
6735         (tui_source_window_base::do_scroll_horizontal): Update.
6736         (tui_source_window_base::set_is_exec_point_at): Rename from
6737         tui_set_is_exec_point_at.
6738         (tui_update_all_breakpoint_info): Update.
6739         * tui/tui-stack.c (tui_show_frame_info): Update.
6740         * tui/tui-layout.c (show_data): Add cast.
6741         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
6742         * tui/tui-data.h (struct tui_source_window_base) <refill,
6743         set_is_exec_point_at>: New methods.
6744         (tui_source_windows, tui_add_to_source_windows): Update types.
6745         (tui_add_to_source_windows): Remove redundant declaration.
6746         * tui/tui-data.c (source_windows): Store tui_source_window_base.
6747         (tui_source_windows): Change return type.
6748         (tui_clear_source_windows_detail): Update.
6749         (tui_add_to_source_windows): Change type of parameter.
6750         (tui_free_all_source_wins_content): Update.
6751
6752 2019-06-25  Tom Tromey  <tom@tromey.com>
6753
6754         * tui/tui-wingeneral.c (tui_win_info::refresh)
6755         (tui_source_window_base::refresh): New methods.
6756         (tui_refresh_all): Call the refresh method.
6757         * tui/tui-data.h (struct tui_win_info)
6758         (struct tui_source_window_base) <refresh>: New method.
6759
6760 2019-06-25  Tom Tromey  <tom@tromey.com>
6761
6762         * tui/tui.h (tui_is_window_visible): Return bool.
6763         * tui/tui.c (tui_is_window_visible): Return bool.
6764         * tui/tui-wingeneral.c (tui_make_window, make_visible)
6765         (tui_make_visible, tui_make_invisible)
6766         (tui_win_info::make_visible)
6767         (tui_source_window_base::make_visible, make_all_visible)
6768         (tui_make_all_visible, tui_make_all_invisible): Update.
6769         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
6770         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
6771         bool.
6772         (struct tui_win_info, struct tui_source_window_base)
6773         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
6774         * tui/tui-data.c (tui_init_generic_part): Update.
6775
6776 2019-06-25  Tom Tromey  <tom@tromey.com>
6777
6778         * tui/tui-wingeneral.c (tui_win_info::make_visible)
6779         (tui_source_window_base::make_visible): New methods.
6780         (make_all_visible): Make method call.
6781         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
6782         (struct tui_source_window_base, struct tui_cmd_window): Override
6783         make_visible.
6784         (tui_win_is_source_type): Don't declare.
6785         * tui/tui-data.c (tui_win_is_source_type): Remove.
6786
6787 2019-06-25  Tom Tromey  <tom@tromey.com>
6788
6789         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
6790         NULL check.
6791
6792 2019-06-25  Tom Tromey  <tom@tromey.com>
6793
6794         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
6795         Inline constructor.  Add initializers for members.
6796         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
6797         constructors; now inline in class.
6798
6799 2019-06-25  Tom Tromey  <tom@tromey.com>
6800
6801         * tui/tui-regs.c (tui_show_registers): Update.
6802         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
6803         bool.
6804         * tui/tui-data.c (tui_data_window::clear_detail)
6805         (tui_data_window): Update.
6806
6807 2019-06-25  Tom Tromey  <tom@tromey.com>
6808
6809         * tui/tui-windata.c (tui_display_all_data)
6810         (tui_display_data_from_line, tui_display_data_from)
6811         (tui_check_data_values, tui_data_window::do_scroll_vertical):
6812         Update.
6813         * tui/tui-regs.c (tui_last_regs_line_no)
6814         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
6815         (tui_show_registers, tui_show_register_group)
6816         (tui_display_registers_from, tui_display_reg_element_at_line)
6817         (tui_display_registers_from_line, tui_check_register_values)
6818         (tui_reg_next, tui_reg_prev): Update.
6819         * tui/tui-layout.c (tui_set_layout, show_data): Update.
6820         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
6821         tui_data_window.
6822         (struct tui_win_info) <detail>: Remove.  Add new fields from
6823         tui_data_info.
6824         (TUI_DATA_WIN): Add cast.
6825         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
6826         (~tui_data_window): Simplify.
6827
6828 2019-06-25  Tom Tromey  <tom@tromey.com>
6829
6830         * tui/tui-layout.c (show_source_disasm_command)
6831         (show_source_or_disasm_and_command): Update.
6832         * tui/tui-io.c (update_cmdwin_start_line)
6833         (tui_redisplay_readline): Update.
6834         * tui/tui-data.h (struct tui_command_info): Remove.
6835         (struct tui_win_info) <detail>: Remove command_info member.
6836         (struct tui_data_window) <start_line>: New member, from
6837         tui_command_info.
6838         (TUI_CMD_WIN): Add casts.
6839
6840 2019-06-25  Tom Tromey  <tom@tromey.com>
6841
6842         * tui/tui-winsource.c (tui_update_source_window)
6843         (tui_refill_source_window)
6844         (tui_source_window_base::do_scroll_horizontal)
6845         (tui_update_breakpoint_info, tui_set_exec_info_content)
6846         (tui_show_exec_info_content, tui_erase_exec_info_content)
6847         (tui_clear_exec_info_content): Update.
6848         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
6849         Update.
6850         * tui/tui-win.c (make_invisible_and_set_new_height)
6851         (make_visible_with_new_height): Update.
6852         * tui/tui-source.c (tui_set_source_content)
6853         (tui_show_symtab_source): Update.
6854         * tui/tui-layout.c (extract_display_start_addr)
6855         (show_source_disasm_command, show_data)
6856         (make_source_or_disasm_window)
6857         (show_source_or_disasm_and_command): Update.
6858         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
6859         (tui_disasm_window::do_scroll_vertical): Remove shadowing
6860         "gdbarch".
6861         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
6862         to tui_source_window_base.
6863         (struct tui_win_info) <detail>: Remove source_info member.
6864         (struct tui_source_window_base) <has_locator>: Inline.
6865         Move contents from tui_source_info; rename has_locator member to
6866         m_has_locator.
6867         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
6868         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
6869         header file.
6870         (tui_source_window_base::clear_detail, ~tui_source_window_base):
6871         Simplify.
6872         (tui_free_all_source_wins_content): Cast to
6873         tui_source_window_base.
6874
6875 2019-06-25  Tom Tromey  <tom@tromey.com>
6876
6877         * tui/tui-win.c (make_invisible_and_set_new_height)
6878         (make_visible_with_new_height): Call has_locator method.
6879         * tui/tui-layout.c (show_source_disasm_command, show_data)
6880         (show_source_or_disasm_and_command): Update for bool change.
6881         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
6882         (tui_win_info) <has_locator>: New method.
6883         (struct tui_source_window_base) <has_locator>: New method.
6884         (tui_win_has_locator): Don't declare.
6885         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
6886         from tui_win_has_locator.
6887         (tui_source_window_base): Use false, not FALSE.
6888
6889 2019-06-25  Tom Tromey  <tom@tromey.com>
6890
6891         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
6892         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
6893         clear_detail method directly.
6894         (tui_clear_win_detail): Remove.
6895
6896 2019-06-25  Tom Tromey  <tom@tromey.com>
6897
6898         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
6899         "this", not TUI_DISASM_WIN.
6900
6901 2019-06-25  Tom Tromey  <tom@tromey.com>
6902
6903         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
6904         declare.
6905         * tui/tui-winsource.c
6906         (tui_source_window_base::do_scroll_horizontal): Rename from
6907         tui_horizontal_source_scroll.
6908         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
6909         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
6910         from tui_vertical_data_scroll.
6911         * tui/tui-win.h (tui_scroll): Don't declare.
6912         * tui/tui-win.c (tui_win_info::forward_scroll)
6913         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
6914         (tui_win_info::right_scroll): Rename and update.
6915         (tui_scroll_forward_command, tui_scroll_backward_command)
6916         (tui_scroll_left_command, tui_scroll_right_command): Update.
6917         (tui_scroll): Remove.
6918         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
6919         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
6920         from tui_vertical_source_scroll.
6921         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
6922         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
6923         from tui_vertical_disassem_scroll.
6924         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
6925         do_scroll_horizontal>: New methods.
6926         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
6927         Likewise.
6928         (struct tui_source_window_base): Add do_scroll_horizontal.
6929         (struct tui_source_window, struct tui_disasm_window): Add
6930         do_scroll_vertical.
6931         (struct tui_data_window, struct tui_cmd_window): Add
6932         do_scroll_horizontal and do_scroll_vertical.
6933         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
6934
6935 2019-06-25  Tom Tromey  <tom@tromey.com>
6936
6937         * tui/tui-data.h (struct tui_source_window_base): New struct.
6938         (struct tui_source_window): Derive from tui_source_window_base.
6939         (struct tui_disasm_window): New struct.
6940         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
6941         from tui_source_window::clear_detail.
6942         (tui_source_window_base): Rename from tui_source_window.
6943         (~tui_source_window_base): Rename from ~tui_source_window.
6944         (tui_alloc_win_info): Create a tui_disasm_window.
6945
6946 2019-06-25  Tom Tromey  <tom@tromey.com>
6947
6948         * tui/tui-data.h (struct tui_source_window)
6949         (struct tui_data_window): Declare destructors.
6950         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
6951         destructors.
6952         (tui_win_info): Simplify.
6953
6954 2019-06-25  Tom Tromey  <tom@tromey.com>
6955
6956         * tui/tui-winsource.c (tui_display_main)
6957         (tui_update_source_windows_with_addr)
6958         (tui_update_all_breakpoint_info): Update.
6959         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
6960         (new_height_ok, parse_scrolling_args): Update.
6961         * tui/tui-stack.c (tui_show_frame_info): Update.
6962         * tui/tui-data.h (struct tui_list): Remove.
6963         (tui_source_windows): Return a reference to a std::vector.
6964         * tui/tui-data.c (source_windows): Now a std::vector.
6965         (tui_source_windows): Change return type.
6966         (tui_clear_source_windows): Rewrite.
6967         (tui_clear_source_windows_detail, tui_add_to_source_windows)
6968         (tui_free_all_source_wins_content): Rewrite.
6969
6970 2019-06-25  Tom Tromey  <tom@tromey.com>
6971
6972         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
6973         (struct tui_data_window, struct tui_cmd_window): Declare
6974         clear_detail method.
6975         * tui/tui-data.c (tui_source_window::clear_detail)
6976         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
6977         methods.
6978         (tui_clear_win_detail): Simplify.
6979
6980 2019-06-25  Tom Tromey  <tom@tromey.com>
6981
6982         * tui/tui-layout.c (make_source_window, make_disasm_window)
6983         (make_source_or_disasm_window): Remove win_info_ptr parameter.
6984         Return the new window.
6985         (show_source_disasm_command, show_data)
6986         (show_source_or_disasm_and_command): Update.
6987
6988 2019-06-25  Tom Tromey  <tom@tromey.com>
6989
6990         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
6991         parameter.  Return the new window.
6992         (show_source_disasm_command): Update and remove NULL check.
6993         (show_source_or_disasm_and_command): Update.
6994
6995 2019-06-25  Tom Tromey  <tom@tromey.com>
6996
6997         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
6998
6999 2019-06-25  Tom Tromey  <tom@tromey.com>
7000
7001         * tui/tui-data.h (struct tui_win_info): Make constructor
7002         protected.  Make destructor virtual.  Add initializers.
7003         (tui_source_window, tui_data_window, tui_cmd_window): New
7004         classes.
7005         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
7006         constructor.  Add "type" parameter.
7007         (tui_source_window, tui_data_window, tui_cmd_window): New
7008         constructors.
7009         (tui_alloc_win_info): Instantiate the appropriate subclass.
7010
7011 2019-06-25  Tom Tromey  <tom@tromey.com>
7012
7013         * tui/tui-win.c (tui_resize_all): Use delete.
7014         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
7015         destructor.
7016         (tui_free_window): Don't declare.
7017         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
7018         Update.
7019
7020 2019-06-25  Tom Tromey  <tom@tromey.com>
7021
7022         * tui/tui-data.h (struct tui_win_info): Add constructor.
7023         * tui/tui-data.c (tui_alloc_win_info): Use new.
7024         (tui_free_window): Use delete.
7025
7026 2019-06-22  Tom Tromey  <tom@tromey.com>
7027
7028         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
7029         declare.
7030         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
7031
7032 2019-06-22  Tom Tromey  <tom@tromey.com>
7033
7034         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
7035         declare.
7036         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
7037
7038 2019-06-22  Tom de Vries  <tdevries@suse.de>
7039
7040         * dwarf2read.c (create_addrmap_from_aranges)
7041         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
7042         instead of '%zu'.
7043
7044 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
7045
7046         * dwarf2read.h (dwarf2_section_info_def): Remove.
7047         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
7048         * dwarf2read.c (struct dwo_sections) <types>: Change type to
7049         std::vector<dwarf2_section_info>.
7050         (struct dwo_file) <~dwo_file>: Remove.
7051         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
7052         types field.
7053         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
7054         (dwarf2_read_debug_names): Likewise.
7055         (create_debug_types_hash_table): Change parameter type to
7056         array_view, adjust code accordingly.
7057         (dwarf2_locate_dwo_sections): Adjust to std::vector.
7058         (partial_die_info::fixup): Likewise.
7059         (determine_prefix): Likewise.
7060         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
7061
7062 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
7063
7064         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
7065         gdb_bfd_ref_ptr.
7066         <~dwo_file>: Remove call to gdb_bfd_unref.
7067         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
7068         gdb_bfd_ref_ptr::get.
7069
7070 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
7071
7072         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
7073         type to htab_up.
7074         * dwarf2read.c (struct dwo_file): Initialize fields.
7075         <~dwo_file>: New.
7076         (free_dwo_file): Remove, move content to ~dwo_file.
7077         (struct dwo_file_deleter): Remove.
7078         (dwo_file_up>: Remove custom deleter.
7079         (free_dwo_files): Remove.
7080         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
7081         dwo_files.
7082         (process_skeletonless_type_units): Call unique_ptr::get.
7083         (allocate_dwo_file_hash_table): Add deleter to created hash
7084         table.  Change return type to htab_up.
7085         (lookup_dwo_file_slot): Don't memset dwo_file, call
7086         unique_ptr::get.
7087         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
7088         (create_dwo_unit_in_dwp_v2): Likewise.
7089         (open_and_init_dwo_file): Likewise.
7090         (free_dwo_file_from_slot): Remove.
7091
7092 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
7093
7094         * dwarf2read.h (struct dwarf2_section_info) <readin,
7095         is_virtual>: Change type to bool.
7096         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
7097         true instead of 1.
7098
7099 2019-06-19  Tom Tromey  <tom@tromey.com>
7100
7101         * tui/tui-data.h (tui_init_content_element): Don't declare.
7102
7103 2019-06-19  Tom Tromey  <tom@tromey.com>
7104
7105         * tui/tui-data.h (tui_init_win_info): Don't declare.
7106
7107 2019-06-19  Tom de Vries  <tdevries@suse.de>
7108
7109         * dwarf2read.h (abstract_to_concrete): Change type to
7110         std::unordered_map<sect_offset, std::vector<sect_offset>,
7111         gdb::hash_enum<sect_offset>>.
7112
7113 2019-06-19  Tom Tromey  <tromey@adacore.com>
7114
7115         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
7116         EVAL_AVOID_SIDE_EFFECTS specially.
7117
7118 2019-06-19  Tom Tromey  <tromey@adacore.com>
7119
7120         * source-cache.c (highlighter): New global.
7121         (source_cache::get_source_lines): Create a highlighter on demand.
7122
7123 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
7124
7125         * defs.h (deprecated_interactive_hook): Delete declaration.
7126         * interps.c (clear_interpreter_hooks): Remove use of
7127         deprecated_interactive_hook.
7128         * top.c (deprecated_interactive_hook): Delete definition.
7129         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
7130
7131 2019-06-18  Tom de Vries  <tdevries@suse.de>
7132
7133         PR gdb/24515
7134         * dwarf2read.h (abstract_to_concrete): Change type from
7135         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
7136         std::unordered_map<sect_offset, std::vector<sect_offset>>.
7137         * dwarf2read.c (read_variable): Update.
7138         (dwarf2_fetch_die_loc_sect_off): Update.
7139
7140 2019-06-17  Tom de Vries  <tdevries@suse.de>
7141
7142         PR gdb/24617
7143         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
7144         accessing parent[parent_len - 1].
7145
7146 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
7147
7148         PR gdb/24364
7149         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
7150         call dtrace_process_dof with NULL dof.
7151
7152 2019-06-16  Tom de Vries  <tdevries@suse.de>
7153
7154         PR gdb/24445
7155         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
7156
7157 2019-06-16  Tom Tromey  <tom@tromey.com>
7158
7159         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
7160         (make_all_visible): Use address of member.
7161
7162 2019-06-16  Tom Tromey  <tom@tromey.com>
7163
7164         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
7165         (tui_free_window, free_content, free_content_elements): Remove
7166         unnecessary cast.
7167         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
7168         cast.
7169         * tui/tui-regs.c (tui_show_register_group)
7170         (tui_display_registers_from, tui_display_reg_element_at_line):
7171         Remove unnecessary cast.
7172
7173 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
7174
7175         * linux-nat.c (normal_mask): Delete.
7176         (_initialize_linux_nat): Don't initialise normal_mask.
7177
7178 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
7179
7180         PR gdb/24445
7181         * dwarf-index-write.h (write_psymtabs_to_index): Add
7182         dwz_basename parameter.
7183         * dwarf-index-write.c (write_gdbindex): Move file writing to
7184         write_gdbindex_1.  Change return type void.
7185         (assert_file_size): Move up, remove filename parameter.
7186         (write_gdbindex_1): New function.
7187         (write_debug_names): Change return type to void, call
7188         assert_file_size.
7189         (struct index_wip_file): New struct.
7190         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
7191         file logic to index_wip_file.  Write index for dwz file if
7192         needed.
7193         (save_gdb_index_command): Pass basename of dwz file, if present.
7194         * dwarf-index-cache.c (index_cache::store): Obtain and pass
7195         build-id of dwz file, if present.
7196         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
7197         (dwarf2_get_dwz_file): Likewise.
7198         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
7199         (dwarf2_get_dwz_file): Likewise.
7200
7201 2019-06-16  Tom Tromey  <tom@tromey.com>
7202
7203         * coffread.c (process_coff_symbol): Use xstrdup.
7204         * value.c (create_internalvar): Use xstrdup.
7205
7206 2019-06-16  Tom Tromey  <tom@tromey.com>
7207
7208         * valops.c (value_cast, value_slice): Remove unnecessary cast.
7209         * breakpoint.c (stopin_command, stopat_command)
7210         (until_break_command, decode_location_default): Remove unnecessary
7211         cast.
7212         * utils.c (subset_compare): Remove unnecessary cast.
7213         * ada-lang.c (ada_update_initial_language): Remove unnecessary
7214         cast.
7215         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
7216         cast.
7217         * infcmd.c (path_command): Remove unnecessary cast.
7218         * coffread.c (decode_type): Remove unnecessary cast.
7219         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
7220         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
7221         * tui/tui-stack.c (tui_show_locator_content)
7222         (tui_show_frame_info): Remove unnecessary cast.
7223         * tui/tui-win.c (tui_scroll_forward_command)
7224         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
7225         (parse_scrolling_args): Remove unnecessary cast.
7226         * tui/tui-data.c (init_win_info, tui_del_window)
7227         (tui_free_window, tui_del_data_windows, tui_free_data_content)
7228         (free_content_elements): Remove unnecessary cast.
7229         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
7230         unnecessary cast.
7231         * tui/tui-source.c (tui_set_source_content)
7232         (tui_vertical_source_scroll): Remove unnecessary cast.
7233         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
7234         cast.
7235         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
7236         * tui/tui-regs.c (tui_display_registers_from)
7237         (tui_display_register): Remove unnecessary cast.
7238         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
7239         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
7240         (make_visible): Remove unnecessary cast.
7241         * tui/tui-winsource.c (tui_erase_source_content)
7242         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
7243         unnecessary cast.
7244         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
7245         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
7246         * stabsread.c (read_type, read_array_type, read_range_type):
7247         Remove unnecessary cast.
7248         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
7249         (parse_symbol, parse_type, upgrade_type, parse_external)
7250         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
7251         unnecessary cast.
7252         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
7253
7254 2019-06-16  Tom Tromey  <tom@tromey.com>
7255
7256         * tui/tui-data.c (tui_alloc_generic_win_info)
7257         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
7258         checks.
7259
7260 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
7261             Andrew Burgess  <andrew.burgess@embecosm.com>
7262
7263         * f-typeprint.c (f_print_type): Don't return early for not
7264         associated or not allocated types.
7265         (f_type_print_varspec_suffix): Add print_rank parameter and print
7266         ranks of array types in case they dangling.
7267         (f_type_print_base): Add print_rank parameter.
7268
7269 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
7270
7271         * NEWS: Mention new MI commands.
7272         * break-catch-throw.c (enum exception_event_kind): Move to
7273         breakpoint.h.
7274         (print_mention_exception_catchpoint): Output text as a single
7275         message.
7276         (catch_exception_command_1): Rename to...
7277         (catch_exception_event): ...this, make non-static, update header
7278         command, and change some parameter types.
7279         (catch_catch_command): Update for changes to
7280         catch_exception_command_1.
7281         (catch_throw_command): Likewise.
7282         (catch_rethrow_command): Likewise.
7283         * breakpoint.c (enum exception_event_kind): Delete.
7284         * breakpoint.h (enum exception_event_kind): Moved here from
7285         break-catch-throw.c.
7286         (catch_exception_event): Declare.
7287         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
7288         (mi_cmd_catch_throw): New function.
7289         (mi_cmd_catch_rethrow): New function.
7290         (mi_cmd_catch_catch): New function.
7291         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
7292         'catch-catch' entries.
7293         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
7294         (mi_cmd_catch_rethrow): Declare.
7295         (mi_cmd_catch_catch): Declare.
7296
7297 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
7298
7299         * annotate.c (annotate_source_line): Change return type to void,
7300         update implementation to match.
7301         * annotate.h (annotate_source_line): Change return type to void,
7302         update header comment.
7303         * stack.c (print_frame_info): Don't change what frame information
7304         is printed based on whether annotations are on or not.
7305
7306 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
7307
7308         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
7309         (annotate_source): Make static.
7310         (annotate_source_line): Moved from source.c and renamed from
7311         identify_source_line.  Update the return type.
7312         * annotate.h (annotate_source): Delete declaration.
7313         (annotate_source_line): Declaration moved from source.h, and
7314         renamed from identify_source_line.  Return type updated.
7315         * source.c (identify_source_line): Moved to annotate.c and renamed
7316         to annotate_source_line.
7317         (info_line_command): Remove check of annotation_level.
7318         * source.h (identify_source_line): Move declaration to annotate.h
7319         and rename to annotate_source_line.
7320         * stack.c: Add 'annotate.h' include.
7321         (print_frame_info): Remove check of annotation_level before
7322         calling annotate_source_line.
7323
7324 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
7325
7326         * source-cache.c (source_cache::get_plain_source_lines): Use
7327         open_source_file_with_line_charpos instead of just
7328         open_source_file, remove call to find_source_lines.
7329         (source_cache::get_source_lines): Likewise.
7330         * source.c (find_source_lines): Make static.
7331         (get_filename_and_charpos): Renamed into...
7332         (open_source_file_with_line_charpos): ..this along with changes to
7333         return a scoped_fd, and some other minor clean ups.
7334         (identify_source_line): Use open_source_file_with_line_charpos.
7335         (search_command_helper): Use open_source_file_with_line_charpos
7336         instead of just open_source_file, remove call to
7337         find_source_lines.
7338         * source.h (open_source_file_with_line_charpos): Declare new
7339         function.
7340         (find_source_lines): Delete declaration.
7341
7342 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
7343
7344         * source.c (get_filename_and_charpos): Remove fullname
7345         parameter.
7346         (identify_source_line): Update call to get_filename_and_charpos.
7347
7348 2019-06-14  Tom Tromey  <tromey@adacore.com>
7349
7350         PR gdb/24502:
7351         * ui-style.h (skip_ansi_escape): Update comment.
7352         * ui-file.h (class no_terminal_escape_file): New class.
7353         * ui-file.c (no_terminal_escape_file::write)
7354         (no_terminal_escape_file::puts): New methods.
7355         * cli/cli-logging.c (handle_redirections): Use
7356         no_terminal_escape_file.
7357
7358 2019-06-14  Tom Tromey  <tromey@adacore.com>
7359
7360         * NEWS: Move convenience variable news above Python news.
7361
7362 2019-06-14  Tom Tromey  <tom@tromey.com>
7363
7364         * gnulib: Move directory to top-level.
7365         * configure.ac: Don't configure gnulib.
7366         * configure: Rebuild.
7367         * common/common-defs.h: Use new path to gnulib.
7368         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
7369         (GNULIB_H): Remove.
7370         (INCGNU): Look in new gnulib location.
7371         (HFILES_NO_SRCDIR): Remove gnulib files.
7372         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
7373         (generated_files): Remove GNULIB_H.
7374         ($(LIBGNU), all-lib): Remove targets.
7375         (distclean): Don't mention GNULIB_BUILDDIR.
7376         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
7377
7378 2019-06-14  Tom Tromey  <tromey@adacore.com>
7379
7380         * symfile.c (add_symbol_file_command): Remove obsolete comment.
7381         Warn if symbol file does not provide any symbols.
7382
7383 2019-06-14  Tom Tromey  <tromey@adacore.com>
7384
7385         * source.c (find_and_open_source): Respect basenames_may_differ.
7386
7387 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
7388
7389         * annotate.c (annotate_breakpoints_invalid): Make use of
7390         scoped_restore_terminal_state.
7391         (annotate_frames_invalid): Likewise.
7392
7393 2019-06-14  Tom Tromey  <tromey@adacore.com>
7394
7395         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
7396         allow assignment to an internalvar.
7397
7398 2019-06-14  Tom Tromey  <tromey@adacore.com>
7399
7400         * ada-lex.l: Allow "_" in attribute names.
7401
7402 2019-06-14  Tom Tromey  <tromey@adacore.com>
7403
7404         PR gdb/24653:
7405         * regcache.c (registers_changed): Don't call alloca.
7406         * top.c (execute_command): Don't call alloca.
7407
7408 2019-06-13  Pedro Alves  <palves@redhat.com>
7409
7410         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
7411         'expression'.  When parsing an expression, error out if there's
7412         junk after "unlimited".
7413         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
7414         (do_set_command): Adjust calls to is_unlimited_literal.
7415
7416 2019-06-13  Pedro Alves  <palves@redhat.com>
7417
7418         * compile/compile.c (make_compile_options_def_group): Add braces
7419         around array_view initializer.
7420         * thread.c (make_thread_apply_all_options_def_group)
7421         (make_thread_apply_all_options_def_group): Likewise.
7422
7423 2019-06-13  Pedro Alves  <palves@redhat.com>
7424
7425         * NEWS (New commands): Mention "maint test-options
7426         require-delimiter", "maint test-options unknown-is-error", "maint
7427         test-options unknown-is-operand" and "maint show
7428         test-options-completion-result".
7429         (New command options, command completion): New section.
7430         (Completion improvements): New section.
7431         Mention that you can abbreviate "unlimited".
7432
7433 2019-06-13  Pedro Alves  <palves@redhat.com>
7434
7435         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
7436         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
7437         * unittests/cli-utils-selftests.c (test_parse_flags)
7438         (test_parse_flags_qcs): Delete.
7439         (test_cli_utils): Don't call deleted functions.
7440
7441 2019-06-13  Pedro Alves  <palves@redhat.com>
7442
7443         * thread.c: Include "cli/cli-option.h".
7444         (tp_array_compar_ascending): Global.
7445         (tp_array_compar): Delete function.
7446         (tp_array_compar_ascending, tp_array_compar_descending): New
7447         functions.
7448         (ascending_option_def, qcs_flag_option_def)
7449         (thr_qcs_flags_option_defs)
7450         (make_thread_apply_all_options_def_group)
7451         (make_thread_apply_options_def_group): New.
7452         (thread_apply_all_command): Use gdb::option::process_options.
7453         (thread_apply_command_completer)
7454         (thread_apply_all_command_completer): New.
7455         (thread_apply_command): Use gdb::option::process_options.
7456         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
7457         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
7458         to generate help text of "thread apply".  Adjust "taas"'s help.
7459         * tid-parse.c (tid_range_parser::in_thread_range): New method.
7460         * tid-parse.h (tid_range_parser::in_thread_range): New method.
7461
7462 2019-06-13  Pedro Alves  <palves@redhat.com>
7463
7464         * thread.c (thread_apply_command): Check for invalid TID with
7465         isdigit instead of !isalpha.
7466
7467 2019-06-13  Pedro Alves  <palves@redhat.com>
7468
7469         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
7470         (validate_flags_qcs): New.
7471         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
7472         (validate_flags_qcs): Declare.
7473         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
7474         (make_frame_apply_options_def_group): New.
7475         (frame_apply_command_count): Process options with
7476         gdb::option::process_options.
7477         (frame_apply_completer): New.
7478         (frame_apply_level_completer, frame_apply_all_completer)
7479         (frame_apply_completer): New.
7480         (_initialize_stack): Update help of "frame apply", "frame apply
7481         level", "frame apply all" and "faas" to mention supported options
7482         and install command completers.
7483         * stack.h (frame_apply_all_completer): Declare.
7484         * thread.c: Include "stack.h".
7485         (tfaas_command): Add "--".
7486         (_initialize_thread): Update help "tfaas" to mention supported
7487         options and install command completer.
7488
7489 2019-06-13  Pedro Alves  <palves@redhat.com>
7490
7491         * completer.c (complete_nested_command_line): New.
7492         (gdb_completion_word_break_characters_throw): Add assertion.
7493         * completer.h (complete_nested_command_line): Declare.
7494
7495 2019-06-13  Pedro Alves  <palves@redhat.com>
7496
7497         * stack.c (parse_backtrace_qualifiers): New.
7498         (backtrace_command): Use it.
7499         (backtrace_command_completer): Complete on qualifiers.
7500
7501 2019-06-13  Pedro Alves  <palves@redhat.com>
7502
7503         * frame.c: Include "cli/cli-option.h.
7504         (user_set_backtrace_options): New.
7505         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
7506         Delete.
7507         (get_prev_frame): Adjust.
7508         (boolean_option_def, uinteger_option_def)
7509         (set_backtrace_option_defs): New.
7510         (_initialize_frame): Adjust and use
7511         gdb::option::add_setshow_cmds_for_options to install "set
7512         backtrace past-main" and "set backtrace past-entry".
7513         * frame.h: Include "cli/cli-option.h".
7514         (struct frame_print_options): Forward declare.
7515         (print_frame_arguments_all, print_frame_arguments_scalars)
7516         (print_frame_arguments_none): Declare.
7517         (print_entry_values): Delete declaration.
7518         (struct frame_print_options, user_frame_print_options): New.
7519         (struct set_backtrace_options): New.
7520         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
7521         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
7522         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
7523         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
7524         (list_args_or_locals): Add frame_print_options parameter.
7525         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
7526         * python/py-framefilter.c (enumerate_args): Pass down
7527         USER_FRAME_PRINT_OPTIONS.
7528         * stack.c: Include "cli/cli-option.h".
7529         (print_frame_arguments_all, print_frame_arguments_scalars)
7530         (print_frame_arguments_none): Declare.
7531         (print_raw_frame_arguments, print_entry_values): Delete.
7532         (user_frame_print_options): New.
7533         (boolean_option_def, enum_option_def, frame_print_option_defs):
7534         New.
7535         (struct backtrace_cmd_options): New.
7536         (bt_flag_option_def): New.
7537         (backtrace_command_option_defs): New.
7538         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
7539         (print_frame_arg, read_frame_arg, print_frame_args)
7540         (print_frame_info, print_frame): Add frame_print_options parameter
7541         and use it.
7542         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
7543         (backtrace_command_1): Add frame_print_options and
7544         backtrace_cmd_options parameters and use them.
7545         (make_backtrace_options_def_group): New.
7546         (backtrace_command): Process command options with
7547         gdb::option::process_options.
7548         (backtrace_command_completer): New.
7549         (_initialize_stack): Extend "backtrace"'s help to mention
7550         supported options.  Install completer for "backtrace".
7551         Install some settings commands with add_setshow_cmds_for_options.
7552
7553 2019-06-13  Pedro Alves  <palves@redhat.com>
7554
7555         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
7556         and that "set/show print raw frame-arguments" are now deprecated.
7557
7558         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
7559         command.
7560         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
7561         * stack.c (_initialize_stack): Install "set/show print
7562         raw-frame-arguments", and deprecate "set/show print raw
7563         frame-arguments".
7564         * valprint.c (_initialize_valprint): Deprecate "set/show print
7565         raw".
7566
7567 2019-06-13  Pedro Alves  <palves@redhat.com>
7568
7569         * compile/compile.c (struct compile_options): New.
7570         (compile_flag_option_def, compile_command_option_defs)
7571         (make_compile_options_def_group): New.
7572         (compile_file_command): Handle options with
7573         gdb::option::process_options.
7574         (compile_file_command_completer): New function.
7575         (compile_code_command): Handle options with
7576         gdb::option::process_options.
7577         (compile_code_command_completer): New function.
7578         (_initialize_compiler): Install completers for "compile code" and
7579         "compile file".  Mention available options in "compile code" and
7580         "compile code"'s help.
7581         * completer.c (advance_to_completion_word): New, factored out from
7582         ...
7583         (advance_to_expression_complete_word_point): ... this.
7584         (advance_to_filename_complete_word_point): New.
7585         * completer.h (advance_to_filename_complete_word_point): New
7586         declaration.
7587
7588 2019-06-13  Pedro Alves  <palves@redhat.com>
7589
7590         * compile/compile.c: Include "cli/cli-option.h".
7591         (compile_print_value): Scope data pointer is now a
7592         value_print_options pointer; adjust.
7593         (compile_print_command): Process options.  Scope data pointer is
7594         now a value_print_options pointer; adjust.
7595         (_initialize_compile): Update "compile print"'s help to include
7596         supported options.  Install a completer for "compile print".
7597         * cp-valprint.c (show_vtblprint, show_objectprint)
7598         (show_static_field_print): Delete.
7599         (_initialize_cp_valprint): Don't install "set print
7600         static-members", "set print vtbl", "set print object" here.
7601         * printcmd.c: Include "cli/cli-option.h" and
7602         "common/gdb_optional.h".
7603         (print_command_parse_format): Rework to fill in a
7604         value_print_options instead of a format_data.
7605         (print_value): Change parameter type from format_data pointer to
7606         value_print_options reference.  Adjust.
7607         (print_command_1): Process options.  Adjust to pass down a
7608         value_print_options.
7609         (print_command_completer): New.
7610         (_initialize_printcmd): Install print_command_completer as
7611         handle_brkchars completer for the "print" command.  Update
7612         "print"'s help to include supported options.
7613         * valprint.c: Include "cli/cli-option.h".
7614         (show_vtblprint, show_objectprint, show_static_field_print): Moved
7615         here from cp-valprint.c.
7616         (boolean_option_def, uinteger_option_def)
7617         (value_print_option_defs, make_value_print_options_def_group):
7618         New.  Use gdb::option::add_setshow_cmds_for_options to install
7619         "set print elements", "set print null-stop", "set print repeats",
7620         "set print pretty", "set print union", "set print array", "set
7621         print address", "set print symbol", "set print array-indexes".
7622         * valprint.h: Include <string> and "cli/cli-option.h".
7623         (make_value_print_options_def_group): Declare.
7624         (print_value): Change parameter type from format_data pointer to
7625         value_print_options reference.
7626         (print_command_completer): Declare.
7627
7628 2019-06-13  Pedro Alves  <palves@redhat.com>
7629
7630         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
7631         (COMMON_SFILES): Add maint-test-settings.c.
7632         * cli/cli-decode.c (boolean_enums): New global, factored out from
7633         ...
7634         (add_setshow_boolean_cmd): ... here.
7635         * cli/cli-decode.h (boolean_enums): Declare.
7636         * cli/cli-option.c: New file.
7637         * cli/cli-option.h: New file.
7638         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
7639         factored out from ...
7640         (parse_cli_boolean_value(const char *)): ... this.
7641         (is_unlimited_literal): Change parameter type to pointer to
7642         pointer.  Adjust and advance ARG pointer.
7643         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
7644         (parse_cli_var_enum): New, factored out from ...
7645         (do_set_command): ... this.  Adjust.
7646         * cli/cli-setshow.h (parse_cli_boolean_value)
7647         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
7648         (parse_cli_var_enum): Declare.
7649         * cli/cli-utils.c: Include "cli/cli-option.h".
7650         (get_ulongest): New.
7651         * cli/cli-utils.h (get_ulongest): Declare.
7652         (check_for_argument): New overloads.
7653         * maint-test-options.c: New file.
7654
7655 2019-06-13  Pedro Alves  <palves@redhat.com>
7656
7657         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
7658         parse a range if "-" is at the end of the string.
7659
7660 2019-06-13  Pedro Alves  <palves@redhat.com>
7661
7662         * cli/cli-setshow.c (parse_auto_binary_operation)
7663         (parse_cli_boolean_value): Don't allow "o".
7664
7665 2019-06-13  Pedro Alves  <palves@redhat.com>
7666
7667         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
7668         * NEWS: Mention maint test-settings KIND.
7669         * maint-test-settings.c: New file.
7670
7671 2019-06-13  Pedro Alves  <palves@redhat.com>
7672
7673         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
7674         completer.
7675         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
7676         "set" completers.
7677
7678 2019-06-13  Pedro Alves  <palves@redhat.com>
7679
7680         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
7681         after item.
7682
7683 2019-06-13  Pedro Alves  <palves@redhat.com>
7684
7685         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
7686
7687 2019-06-13  Pedro Alves <palves@redhat.com>
7688
7689         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
7690         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
7691         call.
7692         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
7693         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
7694         calls.
7695         (check_for_argument): Skip spaces after argument.
7696
7697 2019-06-13  Pedro Alves  <palves@redhat.com>
7698
7699         * thread.c (thread_apply_command): Adjust TID parsing.
7700         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
7701         detected before end of string.
7702         (tid_is_in_list): Error out if LIST is invalid.
7703
7704 2019-06-13  Pedro Alves  <palves@redhat.com>
7705
7706         * completer.c (complete_line_internal_1): Rewind completion word
7707         point.
7708         (completion_tracker::advance_custom_word_point_by): Change
7709         parameter type to int.
7710         * completer.h (completion_tracker::advance_custom_word_point_by):
7711         Likewise.
7712
7713 2019-06-13  Pedro Alves  <palves@redhat.com>
7714
7715         * completer.c (advance_to_completion_word): Handle delimiters.
7716
7717 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
7718
7719         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
7720
7721 2019-06-11  Tom Tromey  <tom@tromey.com>
7722
7723         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
7724         (xmalloc_failed): Move to alloc.c.
7725         * alloc.c: New file.
7726         * Makefile.in (COMMON_SFILES): Add alloc.c.
7727
7728 2019-06-11  Tom Tromey  <tom@tromey.com>
7729
7730         * nat/linux-waitpid.c: Don't include server.h.
7731         (linux_debug): Remove.
7732         (my_waitpid): Update.
7733
7734 2019-06-11  Tom Tromey  <tromey@adacore.com>
7735
7736         * infcall.c (_initialize_infcall): Remove trailing newline from
7737         help.
7738         * user-regs.c (_initialize_user_regs): Remove trailing newline
7739         from help.
7740         * typeprint.c (_initialize_typeprint): Remove trailing newline
7741         from help.
7742         * reverse.c (_initialize_reverse): Remove trailing newlines from
7743         help.
7744         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
7745         from help.
7746         * language.c (add_set_language_command): Remove trailing newline
7747         from help.
7748         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
7749         help.
7750         * disasm.c (_initialize_disasm): Remove trailing newline from
7751         help.
7752         * top.c (init_main): Remove trailing newline from help.
7753         * interps.c (_initialize_interpreter): Remove trailing newline
7754         from help.
7755         * btrace.c (_initialize_btrace): Remove trailing newlines from
7756         help.
7757         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
7758         from help.
7759         * python/python.c (_initialize_python): Remove trailing newline
7760         from help.
7761         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
7762         help.
7763         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
7764         from help.  Reformat some text.
7765         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
7766         from help.
7767         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
7768         newline from help.
7769
7770 2019-06-11  Tom Tromey  <tromey@adacore.com>
7771
7772         * darwin-nat.c (darwin_decode_exception_message)
7773         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
7774
7775 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
7776
7777         * valops.c (value_slice): Check for not allocated or not
7778         associated values.
7779
7780 2019-06-10  Tom de Vries  <tdevries@suse.de>
7781
7782         PR gdb/24618
7783         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
7784         sure an empty slot (defined by a 32-bit zero pair) is recognized as
7785         invalid.
7786
7787 2019-06-10  Tom de Vries  <tdevries@suse.de>
7788
7789         PR gdb/24611
7790         * linespec.c (linespec_lexer_lex_string): Remove incorrect
7791         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
7792
7793 2019-06-10  Tom de Vries  <tdevries@suse.de>
7794
7795         PR symtab/24545
7796         * symtab.c (struct demangled_name_entry): Add language field.
7797         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
7798         static minimal symbol".  Set and use language field.
7799
7800 2019-06-10  Tom Tromey  <tromey@adacore.com>
7801
7802         * ada-lang.c (_initialize_ada_language): Update help text.
7803
7804 2019-06-10  Tom Tromey  <tromey@adacore.com>
7805
7806         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
7807         with a newline.
7808         * guile/guile.c (handle_boot_error): Don't end warning with a
7809         newline.
7810         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
7811         warning with a newline.
7812         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
7813         newline.
7814         (s12z_frame_cache): Likewise.
7815         * dwarf-index-cache.c (index_cache::store): Don't end warning with
7816         a newline.
7817         * solib-svr4.c (disable_probes_interface): Don't end warning with
7818         a newline.
7819         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
7820         newline.
7821         * python/python.c (do_finish_initialization): Don't end warning
7822         with a newline.
7823
7824 2019-06-10  Tom Tromey  <tom@tromey.com>
7825
7826         * python/py-breakpoint.c (gdbpy_breakpoint_created)
7827         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
7828         gdbpy_enter.
7829
7830 2019-06-10  Tom Tromey  <tromey@adacore.com>
7831
7832         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
7833         data.
7834         (elf_new_init): Don't call stabsread_new_init.
7835         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
7836         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
7837         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
7838
7839 2019-06-10  Tom de Vries  <tdevries@suse.de>
7840
7841         PR symtab/16264
7842         PR symtab/24517
7843         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
7844
7845 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
7846
7847         * source.c (find_and_open_source): Also rewrite relative file
7848         names.
7849
7850 2019-04-26  Amos Bird  <amosbird@gmail.com>
7851
7852         * annotate.c (annotate_thread_exited): Add "thread-exited"
7853         annotation.
7854
7855 2019-06-06  Tom Tromey  <tromey@adacore.com>
7856
7857         * maint.h (class scoped_command_stats): Use
7858         DISABLE_COPY_AND_ASSIGN.
7859         <print_time>: New method.
7860         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
7861         print_time.
7862         (scoped_command_stats::print_time): New method.
7863
7864 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
7865
7866         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
7867         instructions of lengths 6 or 8 bytes.
7868
7869 2019-06-04  Pedro Alves  <palves@redhat.com>
7870
7871         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
7872
7873         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
7874         * breakpoint.c (condition_completer): Likewise.
7875         * cli/cli-dump.c (scan_expression): Likewise.
7876         * common/filestuff.c (mkdir_recursive): Likewise.
7877         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
7878         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
7879         (gdb_abspath): Likewise.
7880         * compile/compile-cplus-types.c
7881         (compile_cplus_instance::decl_name): Likewise.
7882         * completer.c (complete_explicit_location):
7883         (signal_completer, reg_or_group_completer_1): Likewise.
7884         * cp-support.c (cp_remove_params_if_any): Likewise.
7885         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
7886         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
7887         * infcmd.c (strip_bg_char): Likewise.
7888         * linespec.c (copy_token_string): Likewise.
7889         * mi/mi-main.c (output_cores): Likewise.
7890         * psymtab.c (psymtab_search_name):
7891         * symfile.c (test_set_ext_lang_command): Likewise.
7892         * target.c (target_fileio_read_stralloc): Likewise.
7893         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
7894         * value.c (complete_internalvar): Likewise.
7895
7896 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
7897
7898         Add objfile property to gdb.Type.
7899         * NEWS: Mention Python API addition.
7900         * python/py-type.c (typy_get_objfile): New method.
7901
7902 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7903
7904         * NEWS: Mention the new set|show style [title|highlight].
7905         Mention changes to "show style", "help" and "apropos".
7906
7907 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7908
7909         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
7910         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
7911         instead of print_help_for_command.
7912         (print_doc_of_command): New function.
7913         (help_list): Add 'apropos -v word' suggestion.
7914         (print_help_for_command): Style the command name using title style.
7915         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
7916         (_initialize_cli_cmds): Describe -v in apropos_command help.
7917
7918 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7919
7920         * cli/cli-style.h (cli_style_option): Add name in constructor,
7921         add m_name class member, add constructor with intensity,
7922         add name class function.
7923         (cli_style_option::add_setshow_commands): Remove name argument.
7924         (highlight_style, title_style): New styles.
7925         * cli/cli-style.c (do_show): New function that shows a style
7926         characteristic styling the style name with itself.
7927         (set_style_name): New function.
7928         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
7929         Update all callers according to the changes in cli/cli-style.h.
7930         * utils.h (fputs_highlighted): New function.
7931         * utils.c (fputs_highlighted): Likewise.
7932
7933 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7934
7935         * NEWS: Mention new pipe command and new convenience variables.
7936
7937 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7938
7939         * cli/cli-cmds.c (pipe_command): New function.
7940         (_initialize_cli_cmds): Call add_com for pipe_command.
7941         Define | as an alias for pipe.
7942         (exit_status_set_internal_vars): New function.
7943         (shell_escape): Call exit_status_set_internal_vars.
7944         cli/cli-decode.c (find_command_name_length): Recognize | as
7945         a single character command.
7946
7947 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7948
7949         * gdbcmd.h (execute_command_to_ui_file): New declaration.
7950         top.c (execute_command_to_ui_file): New function, mostly a copy
7951         of execute_command_to_string.
7952         (execute_command_to_string): Implement by calling
7953         execute_command_to_ui_file.
7954
7955 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7956
7957         * top.h (saved_command_line): Remove declaration.
7958         * top.c (previous_saved_command_line, previous_repeat_arguments):
7959         New variables.
7960         (saved_command_line): Make static, define together with other
7961         'repeat variables'.
7962         (dont_repeat): Clear repeat_arguments.
7963         (repeat_previous, get_saved_command_line, save_command_line):
7964         New functions.
7965         (gdb_init): Initialize saved_command_line
7966         and previous_saved_command_line.
7967         * main.c (captured_main_1): Remove saved_command_line initialization.
7968         * event-top.c (handle_line_of_input): Update to use
7969         the new 'repeat' related functions instead of direct access to
7970         saved_command_line.
7971         * command.h (repeat_previous, get_saved_command_line,
7972         save_command_line): New declarations.
7973         (dont_repeat): Add comment.
7974
7975 2019-05-30  Tom Tromey  <tromey@adacore.com>
7976
7977         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
7978         Fix comment.
7979         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
7980
7981 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
7982
7983         PR cli/24587
7984         * completer.c (complete): Initialize variable word.
7985
7986 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
7987
7988         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
7989         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
7990         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
7991         'body' is NULL to the outter 'if', protecting the '!is_define'
7992         situation as well.
7993
7994 2019-05-29  Tom Tromey  <tromey@adacore.com>
7995
7996         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
7997         (dwarf_unknown): New function.
7998         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
7999         (dwarf_type_encoding_name): Use dwarf_unknown.
8000
8001 2019-05-29  Tom Tromey  <tromey@adacore.com>
8002
8003         PR c++/20020:
8004         * cp-valprint.c (cp_print_value_fields): Call
8005         cp_print_static_field inside "try".
8006
8007 2019-05-29  Tom Tromey  <tromey@adacore.com>
8008
8009         * inflow.c (struct terminal_info): Add default operator=.
8010         * configure: Rebuild.
8011         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
8012         -Wdeprecated-copy-dtor, -Wredundant-move.
8013
8014 2019-05-29  Tom Tromey  <tromey@adacore.com>
8015
8016         * NEWS: Add entry.
8017         * infcmd.c (print_return_value_1): Handle finish_print
8018         option.
8019         (show_print_finish): New function.
8020         (_initialize_infcmd): Add "set/show print finish" commands.
8021         * valprint.c (user_print_options): Initialize new member.
8022         * valprint.h (struct value_print_options) <finish_print>: New
8023         member.
8024
8025 2019-05-28  Tom Tromey  <tromey@adacore.com>
8026
8027         * ada-lang.c (ada_remove_Xbn_suffix)
8028         (find_old_style_renaming_symbol)
8029         (parse_old_style_renaming): Remove.
8030         (ada_find_renaming_symbol): Don't call
8031         find_old_style_renaming_symbol.
8032         (ada_is_renaming_symbol): Rename from
8033         ada_find_renaming_symbol.  Remove "block" parameter.  Return
8034         bool.  Now static.
8035         (ada_read_var_value): Update and simplify.
8036         * ada-exp.y (write_var_or_type): Remove old code.
8037
8038 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
8039
8040         PR gdb/25010
8041         * event-top.c: Remove include comment.
8042         * inflow.c (class scoped_ignore_sigttou): Move from here...
8043         * inflow.h (class scoped_ignore_sigttou): ...to here.
8044         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
8045         * top.c:  Remove include comment.
8046
8047 2019-05-27  Tom Tromey  <tom@tromey.com>
8048
8049         * NEWS: Fix typo.
8050
8051 2019-05-22  Tom Tromey  <tromey@adacore.com>
8052
8053         * target.c (target_follow_exec): Constify parameter.
8054         * target-delegates.c: Rebuild.
8055         * remote.c (remote_target::follow_exec): Constify parameter.
8056         * infrun.c (follow_exec): Constify parameter.
8057         * target.h (struct target_ops) <follow_exec>: Constify parameter.
8058         (target_follow_exec): Likewise.
8059
8060 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
8061
8062         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
8063         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
8064
8065 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
8066
8067         * NEWS: Add debugredirect and testsuite sections.
8068
8069 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
8070
8071         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
8072         target descriptions using exclusively floating point register name
8073         aliases.
8074
8075 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
8076
8077         PR gdb/18644:
8078         * f-lang.c (build_fortran_types): Handle the case where
8079         gdbarch_floatformat_for_type returns a nullptr.
8080
8081 2019-05-21  Tom de Vries  <tdevries@suse.de>
8082
8083         PR cli/24587
8084         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
8085
8086 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
8087
8088         PR gdb/18644:
8089         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
8090         16-byte floats.
8091         * i386-tdep.c (i386_floatformat_for_type): Use
8092         floatformats_ia64_quad for the 16-byte floating point component
8093         within a fortran 32-byte complex number.
8094
8095 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
8096
8097         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
8098         delete default constructor.
8099         (find_partial_die): Update to return const struct.
8100         (partial_die_parent_scope): Move variable declaration into scope
8101         of its use and change its type to auto.
8102         (guess_partial_die_structure_name): Likewise.
8103         (partial_die_info::fixup): Likewise.
8104
8105 2019-05-17  Tom Tromey  <tromey@adacore.com>
8106
8107         * source.c (find_and_open_source): Remove cast.
8108
8109 2019-05-17  Tom Tromey  <tromey@adacore.com>
8110
8111         * annotate.c (annotate_source): Make "filename" const.
8112         * annotate.h (annotate_source): Use const.
8113
8114 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
8115
8116         * disasm.c (set_disassembler_options): Send errors to stderr.
8117
8118 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
8119
8120         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
8121         (cli_interp_base::set_logging): Check debug_redirect.
8122         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
8123         * cli/cli-logging.c (debug_redirect): Add static variable.
8124         (pop_output_files): Add default param.
8125         (handle_redirections): Print debug setting.
8126         (show_logging_command): Likewise.
8127         (_initialize_cli_logging): Add debugredirect command.
8128         * interps.c (current_interp_set_logging): Add debug_redirect
8129         parameter.
8130         * interps.h (set_logging): Add debug_redirect parameter.
8131         (current_interp_set_logging): Likewise.
8132         * mi/mi-common.h: Likewise.
8133         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
8134
8135 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
8136             Tom Tromey  <tromey@adacore.com>
8137
8138         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
8139         directly.
8140         * cli/cli-interp.h (make_logging_output): Remove declaration.
8141         * cli/cli-logging.c (make_logging_output): Remove function.
8142         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
8143         directly.
8144         * ui-file.c (tee_file::tee_file): Remove bools.
8145         (tee_file::~tee_file): Remove deletes.
8146         * ui-file.h (tee_file): Remove bools.
8147
8148 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
8149
8150         * mi/mi-cmds.h (mi_cmd_complete): New function.
8151         * mi/mi-main.c (mi_cmd_complete): Likewise.
8152         * mi/mi-cmds.c: Define new MI command -complete.
8153         * NEWS: Mention new -complete command.
8154
8155 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
8156
8157         * completer.h (complete): New function.
8158         * completer.c (complete): Likewise.
8159         * cli/cli-cmds.c: (complete_command): Update to use new complete()
8160         function defined in completer.h.
8161
8162 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
8163
8164         * MAINTAINERS (Write After Approval): Add myself.
8165
8166 2019-05-17  Tom de Vries  <tdevries@suse.de>
8167
8168         PR gdb/24094
8169         * dwarf2read.c (struct cu_partial_die_info): New struct.
8170         (find_partial_die): Return cu_partial_die_info.
8171         (partial_die_parent_scope, guess_partial_die_structure_name)
8172         (partial_die_info::fixup): Handle new return type of find_partial_die.
8173
8174 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
8175
8176         PR breakpoints/24541
8177         * stap-probe.c (stap_parse_register_operand): Make "regname" an
8178         "std::string", simplifying the algorithm.
8179
8180 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
8181
8182         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
8183         (stap_static_probe_ops::get_probes): Likewise.
8184
8185 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
8186
8187         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
8188         '-')" and "else if".
8189         (stap_parse_single_operand): Join checks for
8190         "gdbarch_stap_parse_special_token_p" and
8191         "gdbarch_stap_parse_special_token" in the same "if" statement.
8192         Invert check when verifying for operation on register
8193         displacement.
8194
8195 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
8196
8197         * stap-probe.c (stap_get_opcode): Update comment.
8198         (stap_get_expected_argument_type): Likewise.
8199         (handle_stap_probe): Likewise.
8200
8201 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
8202
8203         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
8204         return type to 'bool'.  Adjust comment.  Use 'bool' when
8205         appropriate.
8206         (i386_stap_parse_special_token_three_arg_disp): Likewise.
8207         * stap-probe.c (stap_parse_argument_1): Likewise.
8208         (stap_is_operator): Likewise.
8209         (stap_is_generic_prefix): Likewise.
8210         (stap_is_register_prefix): Likewise.
8211         (stap_is_register_indirection_prefix): Likewise.
8212         (stap_is_integer_prefix): Likewise.
8213         (stap_generic_check_suffix): Likewise.
8214         (stap_check_integer_suffix): Likewise.
8215         (stap_check_register_suffix): Likewise.
8216         (stap_check_register_indirection_suffix): Likewise.
8217         (stap_parse_register_operand): Likewise.
8218         (stap_parse_single_operand): Likewise.
8219         (stap_parse_argument_1): Likewise.
8220         (stap_probe::get_argument_count): Likewise.
8221         (stap_is_operator): Likewise.
8222
8223 2019-05-16  Tom Tromey  <tromey@adacore.com>
8224
8225         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
8226         keyword to foreach.
8227
8228 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
8229
8230         * linux-thread-db.c (try_thread_db_load_1): Change return type
8231         to bool.
8232         (try_thread_db_load): Likewise.
8233         (try_thread_db_load_from_pdir_1): Likewise.
8234         (try_thread_db_load_from_pdir): Likewise.
8235         (try_thread_db_load_from_sdir): Likewise.
8236         (try_thread_db_load_from_dir): Likewise.
8237         (thread_db_load_search): Likewise.
8238         (has_libpthread): Likewise.
8239         (thread_db_load): Likewise.
8240
8241 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
8242
8243         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
8244         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
8245         NULL, and complain/return if that's the case.
8246
8247 2019-05-15  John Darrington <john@darrington.wattle.id.au>
8248
8249         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
8250         (advance, posn, abstract_read_memory): New functions.
8251         [struct mem_read_abstraction]: New struct.
8252         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
8253
8254 2019-05-14  Tom Tromey  <tromey@adacore.com>
8255
8256         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
8257         value is not lval_memory.
8258
8259 2019-05-14  Tom Tromey  <tromey@adacore.com>
8260
8261         * solib.c (info_sharedlibrary_command): Style the file name.
8262
8263 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
8264
8265         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
8266         (aarch64_vnv_type): Likewise.
8267         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
8268         * common/tdesc.c: Likewise.
8269         * common/tdesc.h (enum tdesc_type_kind): Likewise.
8270         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
8271         * features/aarch64-fpu.xml: Add ieee half view.
8272         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
8273         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
8274         * gdbtypes.h (struct builtin_type): Likewise.
8275         (struct objfile_type): Likewise.
8276
8277 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
8278
8279         * language.c (language_sniff_from_mangled_name): Fix "langauge"
8280         typo.
8281         * location.h (string_to_event_location): Likewise.
8282
8283 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
8284
8285         GDB 8.3 released.
8286
8287 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
8288
8289         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
8290         New variable declaration.
8291         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
8292         New variable.
8293         (print_one_breakpoint): Use ui_out::test_flags and new global
8294         variable to compute use_fixed_output.
8295         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
8296         Remove.
8297         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
8298         (mi_multi_location_breakpoint_output_fixed): Remove.
8299         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
8300         new variable.
8301         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
8302         fix_multi_location_breakpoint_output flag if version >= 3.
8303         * ui-out.h (enum ui_out_flag)
8304         <fix_multi_location_breakpoint_output>: New enumerator.
8305
8306 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
8307
8308         * contrib/cc-with-tweaks.sh: Validate dwz's work.
8309
8310 2019-05-10  Tom Tromey  <tromey@adacore.com>
8311
8312         * ada-lang.c (catch_ada_completer): New function.
8313         (_initialize_ada_language): Use it.
8314
8315 2019-05-10  Tom Tromey  <tromey@adacore.com>
8316
8317         * thread.c (print_thread_info): Make "requested_threads" const.
8318         * gdbthread.h (print_thread_info): Make "requested_threads"
8319         const.
8320         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
8321         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
8322
8323 2019-05-08  Tom Tromey  <tom@tromey.com>
8324
8325         * gdbtypes.c (objfile_type_data): Change type.
8326         (objfile_type, _initialize_gdbtypes): Update.
8327
8328 2019-05-08  Tom Tromey  <tom@tromey.com>
8329
8330         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
8331         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
8332         (_initialize_dwarf2_frame): Update.
8333
8334 2019-05-08  Tom Tromey  <tom@tromey.com>
8335
8336         * objc-lang.c (objc_objfile_data): Change type.
8337         (find_methods): Update.
8338         (_initialize_objc_lang): Remove.
8339
8340 2019-05-08  Tom Tromey  <tom@tromey.com>
8341
8342         * stabsread.c (rs6000_builtin_type_data): Change type.
8343         (rs6000_builtin_type, _initialize_stabsread): Update.
8344
8345 2019-05-08  Tom Tromey  <tom@tromey.com>
8346
8347         * mips-tdep.c (mips_pdr_data): Remove.
8348         (_initialize_mips_tdep): Update.
8349
8350 2019-05-08  Tom Tromey  <tom@tromey.com>
8351
8352         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
8353         (hppa_init_objfile_priv_data, read_unwind_info)
8354         (find_unwind_entry, _initialize_hppa_tdep): Update.
8355
8356 2019-05-08  Tom Tromey  <tom@tromey.com>
8357
8358         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
8359         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
8360         on obstack.
8361         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
8362
8363 2019-05-08  Tom Tromey  <tom@tromey.com>
8364
8365         * mdebugread.c (basic_type_data): Change type.
8366         (basic_type, _initialize_mdebugread): Update.
8367
8368 2019-05-08  Tom Tromey  <tom@tromey.com>
8369
8370         * common/gdb_unique_ptr.h (struct noop_deleter): New.
8371
8372 2019-05-08  Tom Tromey  <tom@tromey.com>
8373
8374         * nto-tdep.c (nto_inferior_data_reg): Change type.
8375         (nto_inferior_data): Update.
8376         (nto_inferior_data_cleanup, nto_new_inferior_data)
8377         (_initialize_nto_tdep): Remove.
8378         * nto-tdep.h (struct nto_inferior_data): Add initializers.
8379
8380 2019-05-08  Tom Tromey  <tom@tromey.com>
8381
8382         * ada-lang.c (struct ada_inferior_data): Add initializers.
8383         (ada_inferior_data): Change type.
8384         (ada_inferior_data_cleanup): Remove.
8385         (get_ada_inferior_data, ada_inferior_exit)
8386         (struct ada_pspace_data): Add initializers, destructor.
8387         (ada_pspace_data_handle): Change type.
8388         (get_ada_pspace_data): Update.
8389         (ada_pspace_data_cleanup): Remove.
8390
8391 2019-05-08  Tom Tromey  <tom@tromey.com>
8392
8393         * coffread.c (struct coff_symfile_info): Add initializers.
8394         (coff_objfile_data_key): Move lower.  Change type.
8395         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
8396         Update.
8397         (coff_free_info): Remove.
8398
8399 2019-05-08  Tom Tromey  <tom@tromey.com>
8400
8401         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
8402         (fbsd_pspace_data_handle): Move lower.  Change type.
8403         (get_fbsd_pspace_data): Update.
8404         (fbsd_pspace_data_cleanup): Remove.
8405         (_initialize_fbsd_tdep): Update.
8406
8407 2019-05-08  Tom Tromey  <tom@tromey.com>
8408
8409         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
8410         (get_ada_tasks_pspace_data): Update.
8411         (ada_tasks_pspace_data_cleanup): Remove.
8412         (_initialize_tasks): Update.
8413         (ada_tasks_inferior_data_handle): Change type.
8414         (get_ada_tasks_inferior_data): Update.
8415         (ada_tasks_inferior_data_cleanup): Remove.
8416         (struct ada_tasks_pspace_data): Add initializers.
8417
8418 2019-05-08  Tom Tromey  <tom@tromey.com>
8419
8420         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
8421         * symfile-debug.c (debug_sym_get_probes): Change type.
8422         * stap-probe.c (handle_stap_probe):
8423         (stap_static_probe_ops::get_probes): Change type.
8424         * probe.h (class static_probe_ops) <get_probes>: Change type.
8425         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
8426         (parse_probes_in_pspace): Update.
8427         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
8428         Update.
8429         (any_static_probe_ops::get_probes): Change type.
8430         * elfread.c (elfread_data): New typedef.
8431         (probe_key): Change type.
8432         (elf_get_probes): Likewise.  Update.
8433         (probe_key_free): Remove.
8434         (_initialize_elfread): Update.
8435         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
8436         Change type.
8437         (dtrace_process_dof_probe, dtrace_process_dof)
8438         (dtrace_static_probe_ops::get_probe): Change type.
8439
8440 2019-05-08  Tom Tromey  <tom@tromey.com>
8441
8442         * xcoffread.c (struct xcoff_symfile_info): Rename from
8443         coff_symfile_info.  Add initializers.
8444         (xcoff_objfile_data_key): Move lower.  Change type.
8445         (XCOFF_DATA): Rewrite.
8446         (xcoff_free_info): Remove.
8447         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
8448         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
8449         (xcoff_initial_scan): Update.
8450
8451 2019-05-08  Tom Tromey  <tom@tromey.com>
8452
8453         * solib-svr4.c (struct svr4_info): Add initializers and
8454         destructor.
8455         <probes_table>: Now an htab_up.
8456         (solib_svr4_pspace_data): Change type.
8457         (free_probes_table): Simplify.
8458         (~svr4_info): Rename from svr4_pspace_data_cleanup.
8459         (get_svr4_info, probes_table_htab_remove_objfile_probes)
8460         (probes_table_remove_objfile_probes, register_solib_event_probe)
8461         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
8462         (_initialize_svr4_solib): Update.
8463
8464 2019-05-08  Tom Tromey  <tom@tromey.com>
8465
8466         * remote.c (remote_pspace_data): Change type.
8467         (remote_pspace_data_cleanup): Remove.
8468         (get_remote_exec_file, set_pspace_remote_exec_file)
8469         (_initialize_remote): Update.
8470
8471 2019-05-08  Tom Tromey  <tom@tromey.com>
8472
8473         * breakpoint.c (breakpoint_objfile_key): Change type.
8474         (get_breakpoint_objfile_data): Update.
8475         (free_breakpoint_objfile_data): Remove.
8476         (_initialize_breakpoint): Update.
8477
8478 2019-05-08  Tom Tromey  <tom@tromey.com>
8479
8480         * linux-tdep.c (struct linux_info): Add initializers.
8481         (linux_inferior_data): Move.  Change type.
8482         (invalidate_linux_cache_inf): Update.
8483         (linux_inferior_data_cleanup): Remove.
8484         (get_linux_inferior_data, _initialize_linux_tdep): Update.
8485
8486 2019-05-08  Tom Tromey  <tom@tromey.com>
8487
8488         * auxv.c (auxv_inferior_data): Move.  Change type.
8489         (auxv_inferior_data_cleanup): Remove.
8490         (invalidate_auxv_cache_inf): Rewrite.
8491         (get_auxv_inferior_data, _initialize_auxv): Update.
8492
8493 2019-05-08  Tom Tromey  <tom@tromey.com>
8494
8495         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
8496         (symfile_debug_objfile_data_key): Change type.
8497         (symfile_debug_installed, debug_qf_has_symbols)
8498         (debug_qf_find_last_source_symtab)
8499         (debug_qf_forget_cached_source_info)
8500         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
8501         (debug_qf_print_stats, debug_qf_dump)
8502         (debug_qf_expand_symtabs_for_function)
8503         (debug_qf_expand_all_symtabs)
8504         (debug_qf_expand_symtabs_with_fullname)
8505         (debug_qf_map_matching_symbols)
8506         (debug_qf_expand_symtabs_matching)
8507         (debug_qf_find_pc_sect_compunit_symtab)
8508         (debug_qf_map_symbol_filenames)
8509         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
8510         (debug_sym_new_init, debug_sym_init, debug_sym_read)
8511         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
8512         (debug_sym_read_linetable, debug_sym_relocate): Update.
8513         (symfile_debug_free_objfile): Remove.
8514         (install_symfile_debug_logging, _initialize_symfile_debug):
8515         Update.
8516
8517 2019-05-08  Tom Tromey  <tom@tromey.com>
8518
8519         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
8520         allocate_on_obstack.
8521         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
8522         (get_dwarf2_per_objfile): Update.
8523         (set_dwarf2_per_objfile): Remove.
8524         (dwarf2_has_info, dwarf2_get_section_info): Update.
8525         (dwarf2_free_objfile): Remove.
8526         (_initialize_dwarf2_read): Update.
8527
8528 2019-05-08  Tom Tromey  <tom@tromey.com>
8529
8530         * auto-load.c (struct auto_load_pspace_info): Add destructor and
8531         initializers.
8532         <unsupported_script_warning_printed,
8533         script_not_found_warning_printed>: Now bool.
8534         (auto_load_pspace_data): Change type.
8535         (~auto_load_pspace_info): Rename from
8536         auto_load_pspace_data_cleanup.
8537         (get_auto_load_pspace_data, init_loaded_scripts_info)
8538         (clear_section_scripts, maybe_print_unsupported_script_warning)
8539         (maybe_print_script_not_found_warning, _initialize_auto_load):
8540         Update.
8541
8542 2019-05-08  Tom Tromey  <tom@tromey.com>
8543
8544         * objfiles.c (objfile_pspace_info): Add destructor and
8545         initializers.
8546         (objfiles_pspace_data): Change type.
8547         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
8548         (get_objfile_pspace_data): Update.
8549         (objfiles_bfd_data): Change type.
8550         (get_objfile_bfd_data): Update.
8551         (objfile_bfd_data_free, _initialize_objfiles): Remove.
8552
8553 2019-05-08  Tom Tromey  <tom@tromey.com>
8554
8555         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
8556         Change type.
8557         (get_catch_syscall_inferior_data): Update.
8558         (catch_syscall_inferior_data_cleanup): Remove.
8559         (_initialize_break_catch_syscall): Update.
8560
8561 2019-05-08  Tom Tromey  <tom@tromey.com>
8562
8563         * inflow.c (struct terminal_info): Add destructor and
8564         initializers.
8565         (inflow_inferior_data): Change type.
8566         (~terminal_info): Rename from inflow_inferior_data_cleanup.
8567         (get_inflow_inferior_data, inflow_inferior_exit)
8568         (swap_terminal_info, _initialize_inflow): Update.
8569
8570 2019-05-08  Tom Tromey  <tom@tromey.com>
8571
8572         * target-dcache.c (target_dcache_cleanup): Remove.
8573         (target_dcache_aspace_key): Change type.
8574         (target_dcache_init_p, target_dcache_invalidate)
8575         (target_dcache_get, target_dcache_get_or_init)
8576         (_initialize_target_dcache): Update.
8577         * dcache.h (struct dcache_deleter): New.
8578
8579 2019-05-08  Tom Tromey  <tom@tromey.com>
8580
8581         * symtab.c (struct symbol_cache): Add destructor and
8582         initializers.
8583         (symbol_cache_key): Move.  Change type.
8584         (make_symbol_cache, free_symbol_cache): Remove.
8585         (get_symbol_cache): Update.
8586         (symbol_cache_cleanup): Remove.
8587         (ALL_PSPACES, symbol_cache_flush)
8588         (maintenance_print_symbol_cache)
8589         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
8590         Update.
8591
8592 2019-05-08  Tom Tromey  <tom@tromey.com>
8593
8594         * symtab.c (struct main_info): Add destructor and initializers.
8595         (main_progspace_key): Move.  Change type.
8596         (get_main_info): Update.
8597         (main_info_cleanup): Remove.
8598         (_initialize_symtab): Update.
8599
8600 2019-05-08  Tom Tromey  <tom@tromey.com>
8601
8602         * registry.h (DECLARE_REGISTRY): Define the _key class.
8603
8604 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
8605
8606         * NEWS: Merge two 'New commands' sections.
8607
8608 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
8609
8610         * ada-valprint.c (ada_val_print_gnat_array): Remove language
8611         parameter and use Ada language definition instead.
8612         (ada_val_print_ptr): Remove unused language parameter.
8613         (ada_val_print_num): Remove language parameter and use Ada language
8614         definition instead.
8615         (ada_val_print_enum, ada_val_print_flt): Remove unused language
8616         parameter.
8617         (ada_val_print_struct_union, ada_val_print_ref): Remove language
8618         parameter and use Ada language definition instead.
8619         (ada_val_print_1): Update all ada_val_print_xxx calls.
8620         Remove language parameter.
8621         (ada_val_print): Update ada_val_print_1 call.
8622
8623 2019-05-08  Tom Tromey  <tromey@adacore.com>
8624
8625         * remote.c (remote_hw_watchpoint_limit)
8626         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
8627         Now static.
8628
8629 2019-05-08  Tom Tromey  <tromey@adacore.com>
8630
8631         * maint.c (_initialize_maint_cmds): Move initialization code to
8632         remote.c.
8633         (watchdog, show_watchdog): Move to remote.c.
8634         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
8635         "watchdog" static.
8636         (_initialize_remote): Move initialization code from maint.c.
8637         * defs.h (watchdog): Don't declare.
8638
8639 2019-05-08  Tom Tromey  <tromey@adacore.com>
8640
8641         * tui/tui-interp.c: Include main.h.
8642         * interps.c: Include main.h.
8643         * main.h (interpreter_p): Declare.
8644         * defs.h (interpreter_p): Don't declare.
8645
8646 2019-05-08  Tom Tromey  <tromey@adacore.com>
8647
8648         * dwarf2loc.c: Include dwarf2read.h.
8649         * defs.h (read_unsigned_leb128): Don't declare.
8650         * dwarf2read.h (read_unsigned_leb128): Declare.
8651
8652 2019-05-08  Tom Tromey  <tromey@adacore.com>
8653
8654         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
8655         method.
8656
8657 2019-05-08  Tom Tromey  <tromey@adacore.com>
8658
8659         * utils.c (fputs_maybe_filtered): Reset style after paging, even
8660         when no wrap column is set.
8661
8662 2019-05-08  Tom Tromey  <tromey@adacore.com>
8663
8664         * c-lang.c (c_get_string): Handle non-C-style arrays.
8665
8666 2019-05-08  Tom Tromey  <tromey@adacore.com>
8667
8668         * typeprint.c (print_offset_data::update): Print the bit offset,
8669         not the number of bits remaining.
8670
8671 2019-05-08  Tom Tromey  <tromey@adacore.com>
8672
8673         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
8674         padding at end of comment.
8675
8676 2019-05-08  Tom Tromey  <tromey@adacore.com>
8677
8678         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
8679         Compare main types.
8680
8681 2019-05-06  Tom Tromey  <tom@tromey.com>
8682
8683         * common/scoped_mmap.c: Include common-defs.h.
8684         * common/scoped_mmap.h: Don't include config.h.
8685
8686 2019-05-04  Tom Tromey  <tom@tromey.com>
8687
8688         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
8689         (struct aarch64_call_info): Add initializers.
8690         <si>: Now a std::vector.
8691         (pass_on_stack, aarch64_push_dummy_call): Update.
8692
8693 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
8694             Tom Tromey  <tom@tromey.com>
8695
8696         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
8697         (ppc_threads): Now a std::vector.  Now static.
8698         (hwdebug_find_thread_points_by_tid)
8699         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
8700         Update.
8701
8702 2019-05-04  Tom Tromey  <tom@tromey.com>
8703
8704         * arc-tdep.c (arc_tdesc_init): Return bool.
8705
8706 2019-05-04  Tom Tromey  <tom@tromey.com>
8707
8708         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
8709         Use gdb_assert_not_reached.
8710
8711 2019-05-04  Tom Tromey  <tom@tromey.com>
8712
8713         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
8714         "false".
8715
8716 2019-05-04  Tom Tromey  <tom@tromey.com>
8717
8718         * arc-tdep.c (arc_tdesc_init): Use bool.
8719
8720 2019-05-04  Tom Tromey  <tom@tromey.com>
8721
8722         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
8723
8724 2019-05-04  Tom Tromey  <tom@tromey.com>
8725
8726         * cli/cli-cmds.c (valid_command_p): Return bool.
8727
8728 2019-05-04  Tom Tromey  <tom@tromey.com>
8729
8730         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
8731         * command.h (valid_user_defined_cmd_name_p): Channge return type.
8732
8733 2019-05-04  Raul Tambre  <raul@tambre.ee>
8734
8735         * python/lib/gdb/prompt.py (_ExtendedPrompt)
8736         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
8737         operator for comparison.
8738
8739 2019-05-04  Tom Tromey  <tom@tromey.com>
8740
8741         * psymtab.c (psymbol_name_matches, match_partial_symbol)
8742         (lookup_partial_symbol, print_partial_symbols)
8743         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
8744         (psymbol_compare): Update.
8745         (add_psymbol_to_bcache): Clear the entire psymbol.
8746         (maintenance_check_psymtabs): Update.
8747         * psympriv.h (struct partial_symbol): Don't derive from
8748         general_symbol_info.
8749         <obj_section, unrelocated_address, address,
8750         set_unrelocated_address>: Update.
8751         <ginfo>: New member.
8752         * dwarf-index-write.c (write_psymbols, debug_names::insert)
8753         (debug_names::write_psymbols): Update.
8754
8755 2019-05-04  Tom de Vries  <tdevries@suse.de>
8756
8757         * contrib/cc-with-tweaks.sh: Support -n arg.
8758
8759 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8760
8761         * corelow.c (core_target::detach): Ensure frame cache and
8762         register caches are cleared.
8763         inferior.c (exit_inferior_1): Likewise.
8764
8765 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
8766             Tom Tromey  <tom@tromey.com>
8767
8768         * dictionary.c (collate_pending_symbols_by_language): Remove
8769         "struct" from foreach.
8770         * symtab.c (lookup_global_symbol_from_objfile)
8771         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
8772         foreach.
8773         * ser-tcp.c (net_open): Remove "struct" from foreach.
8774         * objfiles.c (objfile_relocate, objfile_rebase)
8775         (objfile_has_symbols): Remove "struct" from foreach.
8776         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
8777         from foreach.
8778         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
8779         foreach.
8780         * darwin-nat.c (thread_info_from_private_thread_info): Remove
8781         "struct" from foreach.
8782         * ada-lang.c (create_excep_cond_exprs)
8783         (ada_exception_catchpoint_cond_string): Remove "struct" from
8784         foreach.
8785
8786 2019-05-03  Tom Tromey  <tromey@adacore.com>
8787
8788         * ada-exp.y (convert_char_literal): Check suffix of each
8789         enumerator.
8790
8791 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
8792
8793         PR ada/21406:
8794         * ada-exp.y (yywrap): Don't define.
8795         * ada-lex.l (%option): Add noyywrap
8796         (yywrap): Remove.
8797
8798 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
8799
8800         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
8801         _WIN32_WINNT to the XP level, unless already defined to a higher
8802         level.
8803
8804         * unittests/parse-connection-spec-selftests.c:
8805         * ser-tcp.c:
8806         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
8807         override.
8808
8809         * symfile.c (find_separate_debug_file): Remove colon from the
8810         drive spec of DOS/Windows file names of the target, so that the
8811         file name produced from DEBUGDIR and the target's directory will
8812         be valid on DOS/Windows systems.
8813
8814 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
8815
8816         * rust-lang.c (val_print_struct): Handle printing structures
8817         containing strings.
8818
8819 2019-05-02  Tom Tromey  <tromey@adacore.com>
8820
8821         * valarith.c (_initialize_valarith): Remove.
8822
8823 2019-05-01  Tom Tromey  <tromey@adacore.com>
8824
8825         * ada-lang.c (ada_value_primitive_field): Treat more fields as
8826         bitfields.
8827
8828 2019-05-01  Tom Tromey  <tromey@adacore.com>
8829
8830         * ada-lang.c (ada_value_assign): Correctly compute starting offset
8831         for big-endian copies.
8832
8833 2019-04-30  Ali Tamur  <tamur@google.com>
8834         * gdb/dwarf2read.c (read_3_bytes): New declaration.
8835         (read_attribute_value): Added DW_FORM_strx1-4 cases.
8836         (read_3_bytes): New function.
8837
8838 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
8839
8840         * windows-nat.c (main_thread_id): Delete.
8841         (handle_output_debug_string): Replace main_thread_id by
8842         current_event.dwThreadId.
8843         (fake_create_process): Likewise.
8844         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
8845         Do not set main_thread_id.
8846         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
8847         current_event.dwThreadId.
8848         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
8849
8850 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
8851
8852         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
8853         Use current_event.dwThreadId instead of main_thread_id.
8854
8855 2019-04-30  Tom Tromey  <tromey@adacore.com>
8856
8857         * ada-lang.c (ada_lookup_simple_minsyms): New function.
8858         (create_excep_cond_exprs): Iterate over program spaces.
8859         (ada_exception_catchpoint_cond_string): Examine all minimal
8860         symbols for exception types.
8861
8862 2019-04-30  Tom Tromey  <tromey@adacore.com>
8863
8864         PR c++/24470:
8865         * dwarf2read.c (process_structure_scope): Handle case where type
8866         has template parameters but no symbol was created.
8867
8868 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8869             Chris January  <chris.january@arm.com>
8870
8871         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
8872         qualifier.
8873         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
8874
8875 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8876
8877         * f-typeprint.c (f_print_type): Update rules for printing
8878         whitespace.
8879         (f_type_print_varspec_suffix): Likewise.
8880
8881 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8882             Chris January  <chris.january@arm.com>
8883
8884         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
8885         function arguments.
8886
8887 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8888
8889         * f-lang.c (build_fortran_types): Change name of void type to
8890         lower case.
8891         * f-typeprint.c (f_type_print_base): Print the name of the void
8892         type, rather than a fixed string.
8893         * f-valprint.c (f_decorations): Use lower case void string.
8894
8895 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8896             Chris January  <chris.january@arm.com>
8897
8898         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
8899         types for Fortran.
8900
8901 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8902             Chris January  <chris.january@arm.com>
8903             David Lecomber  <david.lecomber@arm.com>
8904
8905         * f-exp.y (BINOP_INTRINSIC): New token.
8906         (exp): New parser rule handling BINOP_INTRINSIC.
8907         (f77_keywords): Add new builtin procedures.
8908         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
8909         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
8910         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
8911         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
8912         (print_unop_subexp_f): New function.
8913         (print_binop_subexp_f): New function.
8914         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
8915         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
8916         (dump_subexp_body_f): Likewise.
8917         (operator_check_f): Likewise.
8918         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
8919         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
8920
8921 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8922
8923         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
8924         UNOP_KIND.
8925         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
8926         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
8927         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
8928         (operator_length_f): New fuction.
8929         (print_subexp_f): New function.
8930         (op_name_f): New function.
8931         (dump_subexp_body_f): New function.
8932         (operator_check_f): New function.
8933         (exp_descriptor_f): Replace standard expression handling functions
8934         with new functions.
8935         * gdb/fortran-operator.def: New file.
8936         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
8937         * gdb/std-operator.def: Remove UNOP_KIND.
8938
8939 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8940
8941         * std-operator.def: Remove unbalanced, stray double quote
8942         character.
8943
8944 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
8945             Chris January  <chris.january@arm.com>
8946             Daniel Everett  <daniel.everett@arm.com>
8947             Nick Forrington  <nick.forrington@arm.com>
8948             Richard Bunt  <richard.bunt@arm.com>
8949
8950         * cp-valprint.c (cp_print_value_fields): Allow an additional level
8951         of depth when printing anonymous structs or unions.
8952         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
8953         Don't print either the top-level value, or the children if the
8954         max-depth is exceeded.
8955         (ppscm_print_children): When printing the key of a map, allow one
8956         extra level of depth.
8957         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
8958         print either the top-level value, or the children if the max-depth
8959         is exceeded.
8960         (print_children): When printing the key of a map, allow one extra
8961         level of depth.
8962         * python/py-value.c (valpy_format_string): Add max_depth keyword.
8963         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
8964         (user_print_options): Initialise max_depth field.
8965         (val_print_scalar_or_string_type_p): New function.
8966         (val_print): Check to see if the max depth has been reached.
8967         (val_print_check_max_depth): Define new function.
8968         (show_print_max_depth): New function.
8969         (_initialize_valprint): Add 'print max-depth' option.
8970         * valprint.h (struct value_print_options) <max_depth>: New field.
8971         (val_print_check_max_depth): Declare new function.
8972         * NEWS: Document new feature.
8973
8974 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
8975
8976         * ada-lang.c (ada_language_defn): Initialise new field.
8977         * c-lang.c (c_is_string_type_p): New function.
8978         (c_language_defn): Initialise new field.
8979         (cplus_language_defn): Initialise new field.
8980         (asm_language_defn): Initialise new field.
8981         (minimal_language_defn): Initialise new field.
8982         * c-lang.h (c_is_string_type_p): Declare new function.
8983         * d-lang.c (d_language_defn): Initialise new field.
8984         * f-lang.c (f_is_string_type_p): New function.
8985         (f_language_defn): Initialise new field.
8986         * go-lang.c (go_is_string_type_p): New function.
8987         (go_language_defn): Initialise new field.
8988         * language.c (default_is_string_type_p): New function.
8989         (unknown_language_defn): Initialise new field.
8990         (auto_language_defn): Initialise new field.
8991         * language.h (struct language_defn) <la_is_string_type_p>: New
8992         member variable.
8993         (default_is_string_type_p): Declare new function.
8994         * m2-lang.c (m2_language_defn): Initialise new field.
8995         * objc-lang.c (objc_language_defn): Initialise new field.
8996         * opencl-lang.c (opencl_language_defn): Initialise new field.
8997         * p-lang.c (pascal_is_string_type_p): New function.
8998         (pascal_language_defn): Initialise new field.
8999         * rust-lang.c (rust_is_string_type_p): New function.
9000         (rust_language_defn): Initialise new field.
9001
9002 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
9003
9004         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
9005         New field.
9006         * ada-lang.c (ada_language_defn): Initialise new field.
9007         * c-lang.c (c_language_defn): Likewise.
9008         (cplus_language_defn): Likewise.
9009         (asm_language_defn): Likewise.
9010         (minimal_language_defn): Likewise.
9011         * d-lang.c (d_language_defn): Likewise.
9012         * f-lang.c (f_language_defn): Likewise.
9013         * go-lang.c (go_language_defn): Likewise.
9014         * language.c (unknown_language_defn): Likewise.
9015         (auto_language_defn): Likewise.
9016         * m2-lang.c (m2_language_defn): Likewise.
9017         * objc-lang.c (objc_language_defn): Likewise.
9018         * opencl-lang.c (opencl_language_defn): Likewise.
9019         * p-lang.c (pascal_language_defn): Likewise.
9020         * rust-lang.c (rust_language_defn): Likewise.
9021
9022 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
9023
9024         * ada-lang.c (ada_is_character_type): Change return type to bool.
9025         (ada_is_string_type): Likewise.
9026         * ada-lang.h (ada_is_character_type): Update declaration
9027         (ada_is_string_type): Likewise.
9028
9029 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9030
9031         Support style in 'frame|thread apply'
9032
9033         * gdbcmd.h (execute_command_to_string): New term_out parameter.
9034         * record.c (record_start, record_stop): Update callers of
9035         execute_command_to_string with false.
9036         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
9037         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
9038         methods.
9039         (class string_file): New constructor with term_out parameter.
9040         Override methods term_out and can_emit_style_escape.  New member
9041         term_out.
9042         (class stdio_file): Override can_emit_style_escape.
9043         (class tee_file): Override term_out and can_emit_style_escape.
9044         * utils.h (can_emit_style_escape): Remove.
9045         * utils.c (can_emit_style_escape): Likewise.
9046         Update all callers of can_emit_style_escape (SOMESTREAM) to
9047         SOMESTREAM->can_emit_style_escape.
9048         * source-cache.c (source_cache::get_source_lines): Likewise.
9049         * stack.c (frame_apply_command_count): Call execute_command_to_string
9050         passing the term_out characteristic of the current gdb_stdout.
9051         * thread.c (thr_try_catch_cmd): Likewise.
9052         * top.c (execute_command_to_string): pass term_out parameter
9053         to construct the string_file for the command output.
9054         * ui-file.c (term_cli_styling): New function (most code moved
9055         from utils.c can_emit_style_escape).
9056         (string_file::string_file, string_file::can_emit_style_escape,
9057         stdio_file::can_emit_style_escape, tee_file::term_out,
9058         tee_file::can_emit_style_escape): New functions.
9059
9060 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9061
9062         * NEWS: Mention the new set|show may-call-functions.
9063         * infcall.c (may_call_functions_p): New variable.
9064         (show_may_call_functions_p): New function.
9065         (call_function_by_hand_dummy): Throws an error if not
9066         may-call-functions.
9067         (_initialize_infcall): Call add_setshow_boolean_cmd for
9068         may-call-functions.
9069
9070 2019-04-25  Keith Seitz  <keiths@redhat.com>
9071
9072         PR c++/24367
9073         * cp-support.c (inspect_type): Don't attempt substitutions
9074         of symbol with the same name.
9075
9076 2019-04-25  Tom Tromey  <tromey@adacore.com>
9077
9078         PR gdb/24475:
9079         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
9080         static.
9081
9082 2019-04-25  Tom Tromey  <tromey@adacore.com>
9083
9084         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
9085         rvalue reference.
9086         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
9087         (gdb_xml_parser::parse): Use std::move.
9088         * python/python-internal.h (gdbpy_convert_exception): Take a const
9089         reference.
9090         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
9091         std::move.
9092         * python/py-utils.c (gdbpy_convert_exception): Take a const
9093         reference.
9094         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
9095         Use std::move.
9096         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
9097         Use std::move.
9098         * mi/mi-main.c (mi_print_exception): Take a const reference.
9099         * main.c (handle_command_errors): Take a const reference.
9100         * linespec.c (parse_linespec): Use std::move.
9101         * infcall.c (run_inferior_call): Use std::move.
9102         (call_function_by_hand_dummy): Use std::move.
9103         * exec.c (try_open_exec_file): Use std::move.
9104         * exceptions.h (exception_print, exception_fprintf)
9105         (exception_print_same): Update.
9106         * exceptions.c (print_exception, exception_print)
9107         (exception_fprintf, exception_print_same): Change parameters to
9108         const reference.
9109         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
9110         * common/new-op.c: Use std::move.
9111         * common/common-exceptions.h (struct gdb_exception): Add move
9112         constructor.
9113         (struct gdb_exception_error, struct gdb_exception_quit, struct
9114         gdb_quit_bad_alloc): Change constructor to move constructor.
9115         (throw_exception): Change parameter to rvalue reference.
9116         * common/common-exceptions.c (throw_exception): Take rvalue
9117         reference.
9118         * cli/cli-interp.c (safe_execute_command): Use std::move.
9119         * breakpoint.c (insert_bp_location, location_to_sals): Use
9120         std::move.
9121
9122 2019-04-25  Tom Tromey  <tromey@adacore.com>
9123
9124         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
9125         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
9126         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
9127         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
9128         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
9129         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
9130         guile/scm-value.c: Use unpack.
9131         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
9132         gdbscm_gdb_exception.
9133         (gdbscm_throw_gdb_exception): Likewise.
9134         (struct gdbscm_gdb_exception): New.
9135         (unpack): New function.
9136         (gdbscm_wrap): Use unpack.
9137
9138 2019-04-25  Tom Tromey  <tromey@adacore.com>
9139
9140         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
9141         (gdb_rl_callback_handler): Use std::move.
9142         * common/common-exceptions.h (struct gdb_exception): Add move
9143         assignment operator.
9144         (throw_exception_sjlj): Change "exception" to const reference.
9145         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
9146         (throw_exception_sjlj): Change "exception" to const reference.
9147
9148 2019-04-25  Tom Tromey  <tromey@adacore.com>
9149
9150         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
9151         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
9152         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
9153         Update.
9154         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
9155         Update.
9156         * mi/mi-interp.c (mi_interp::exec): Update.
9157         * linespec.c (parse_linespec): Update.
9158         * infcall.c (run_inferior_call): Update.
9159         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
9160         * guile/scm-symbol.c (gdbscm_lookup_symbol)
9161         (gdbscm_lookup_global_symbol): Update.
9162         * guile/scm-param.c (gdbscm_parameter_value): Update.
9163         * guile/scm-frame.c (gdbscm_frame_read_register)
9164         (gdbscm_frame_read_var): Update.
9165         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
9166         * exec.c (try_open_exec_file): Update.
9167         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
9168         (gdb_rl_callback_handler): Update.
9169         * common/common-exceptions.h (exception_none): Don't declare.
9170         * common/common-exceptions.c (exception_none): Don't define.
9171         (struct catcher) <exception>: Update.
9172         * cli/cli-interp.c (safe_execute_command): Update.
9173         * breakpoint.c (insert_bp_location, location_to_sals): Update.
9174
9175 2019-04-25  Ali Tamur  <tamur@google.com>
9176
9177         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
9178         (read_attribute_value): Likewise.
9179         (dwarf2_read_addr_index): Update comment.
9180         (read_str_index): Add DW_FORM_strx.
9181         (dwarf2_string_attr): Likewise.
9182         (dwarf2_const_value_attr): Likewise.
9183         (dump_die_shallow): Likewise.
9184         (dwarf2_fetch_constant_bytes): Likewise.
9185         (skip_form_bytes): Likewise.
9186         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
9187
9188 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
9189
9190         PR corefiles/11608
9191         PR corefiles/18187
9192         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
9193         OFFSET.  Verify if current mapping contains an ELF header.
9194         (linux_find_memory_regions_full): Adjust call to
9195         dump_mapping_p.
9196
9197 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
9198             Kang Li <kanglictf@gmail.com>
9199
9200         PR gdb/21600
9201
9202         * dwarf2-frame.c (read_initial_length): Be consistent about using
9203         unsigned representation of length.
9204         (decode_frame_entry_1): Likewise.  Check for wraparound of
9205         end pointer as well as buffer overflow.
9206
9207 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
9208
9209         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
9210         "vq".
9211
9212 2019-04-24  Tom Tromey  <tromey@adacore.com>
9213
9214         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
9215
9216 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9217
9218         * s12z-tdep.c (s12z_unwind_pc): Delete.
9219         (s12z_unwind_sp): Delete.
9220         (s12z_gdbarch_init): Don't register deleted functions with
9221         gdbarch.
9222
9223 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9224
9225         * rl78-tdep.c (rl78_unwind_sp): Delete.
9226         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
9227
9228 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9229
9230         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
9231         (xstormy16_unwind_pc): Delete.
9232         (xstormy16_dummy_id): Delete.
9233         (xstormy16_gdbarch_init): Don't register deleted functions with
9234         gdbarch.
9235
9236 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9237
9238         * vax-tdep.c (vax_unwind_pc): Delete.
9239         (vax_gdbarch_init): Don't register deleted function with gdbarch.
9240
9241 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9242
9243         * v850-tdep.c (v850_unwind_sp): Delete.
9244         (v850_unwind_pc): Delete.
9245         (v850_dummy_id): Delete.
9246         (v850_gdbarch_init): Don't register deleted functions with
9247         gdbarch.
9248
9249 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9250
9251         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
9252         (tilegx_unwind_pc): Delete.
9253         (tilegx_unwind_dummy_id): Delete.
9254         (tilegx_gdbarch_init): Don't register deleted functions with
9255         gdbarch.
9256
9257 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9258
9259         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
9260         (tic6x_dummy_id): Delete.
9261         (tic6x_gdbarch_init): Don't register deleted functions with
9262         gdbarch.
9263
9264 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9265
9266         * sparc-tdep.c (sparc_unwind_pc): Delete.
9267         (sparc32_gdbarch_init): Don't register deleted function with
9268         gdbarch.
9269
9270 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9271
9272         * sh-tdep.c (sh_unwind_sp): Delete.
9273         (sh_unwind_pc): Delete.
9274         (sh_dummy_id): Delete.
9275         (sh_gdbarch_init): Don't register deleted functions with
9276         gdbarch.
9277
9278 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9279
9280         * score-tdep.c (score_unwind_sp): Delete.
9281         (score_unwind_pc): Delete.
9282         (score_dummy_id): Delete.
9283         (score_gdbarch_init): Don't register deleted functions with
9284         gdbarch.
9285
9286 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9287
9288         * rx-tdep.c (rx_unwind_pc): Delete.
9289         (rx_unwind_sp): Delete.
9290         (rx_dummy_id): Delete.
9291         (rx_gdbarch_init): Don't register deleted functions with
9292         gdbarch.  Update comment.
9293
9294 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9295
9296         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
9297         (rs6000_dummy_id): Delete.
9298         (rs6000_gdbarch_init): Don't register deleted functions with
9299         gdbarch.
9300
9301 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9302
9303         * or1k-tdep.c (or1k_dummy_id): Delete.
9304         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
9305
9306 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9307
9308         * nios2-tdep.c (nios2_dummy_id): Delete.
9309         (nios2_unwind_sp): Delete.
9310         (nios2_gdbarch_init): Don't register deleted functions with
9311         gdbarch.
9312
9313 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9314
9315         * nds32-tdep.c (nds32_dummy_id): Delete.
9316         (nds32_unwind_pc): Delete.
9317         (nds32_unwind_sp): Delete.
9318         (nds32_gdbarch_init): Don't register deleted functions with
9319         gdbarch.
9320
9321 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9322
9323         * msp430-tdep.c (msp430_unwind_pc): Delete.
9324         (msp430_unwind_sp): Delete.
9325         (msp430_dummy_id): Delete.
9326         (msp430_gdbarch_init): Don't register deleted functions with
9327         gdbarch.
9328
9329 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9330
9331         * moxie-tdep.c (moxie_unwind_sp): Delete.
9332         (moxie_unwind_pc): Delete.
9333         (moxie_dummy_id): Delete.
9334         (moxie_gdbarch_init): Don't register deleted functions with
9335         gdbarch.
9336
9337 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9338
9339         * mn10300-tdep.c (mn10300_dummy_id): Delete.
9340         (mn10300_unwind_pc): Delete.
9341         (mn10300_unwind_sp): Delete.
9342         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
9343         mn10300_unwind_sp.
9344         (mn10300_frame_unwind_init): Don't register deleted functions with
9345         gdbarch.
9346
9347 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9348
9349         * mep-tdep.c (mep_unwind_pc): Delete.
9350         (mep_unwind_sp): Delete.
9351         (mep_dummy_id): Delete.
9352         (mep_gdbarch_init): Don't register deleted functions with
9353         gdbarch.
9354
9355 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9356
9357         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
9358         (m68hc11_unwind_sp): Delete.
9359         (m68hc11_gdbarch_init): Don't register deleted functions with
9360         gdbarch.
9361
9362 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9363
9364         * m32r-tdep.c (m32r_unwind_sp): Delete.
9365         (m32r_unwind_pc): Delete.
9366         (m32r_dummy_id): Delete.
9367         (m32r_gdbarch_init): Don't register deleted functions with
9368         gdbarch.
9369
9370 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9371
9372         * m32c-tdep.c (m32c_unwind_pc): Delete.
9373         (m32c_unwind_sp): Delete.
9374         (m32c_dummy_id): Delete.
9375         (m32c_gdbarch_init): Don't register deleted functions with
9376         gdbarch.
9377
9378 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9379
9380         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
9381         (lm32_unwind_pc): Delete.
9382         (lm32_dummy_id): Delete.
9383         (lm32_gdbarch_init): Don't register deleted functions with
9384         gdbarch.
9385
9386 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9387
9388         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
9389         (iq2000_unwind_pc): Delete.
9390         (iq2000_dummy_id): Delete.
9391         (iq2000_gdbarch_init): Don't register deleted functions with
9392         gdbarch.
9393
9394 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9395
9396         * nds32-tdep.c (nds32_type_align): Delete.
9397         (nds32_push_dummy_call): Use type_align instead.
9398
9399 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9400
9401         * arm-tdep.c (arm_type_align): Only handle vector override case.
9402         (arm_push_dummy_call): Use type_align.
9403         (arm_gdbarch_init): Register arm_type_align gdbarch function.
9404
9405 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9406
9407         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
9408         case.
9409         (pass_on_stack): Use type_align.
9410         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
9411         function.
9412
9413 2019-04-23  Tom Tromey  <tromey@adacore.com>
9414
9415         * dwarf2read.c (line_header::file_name_at): Remove unused
9416         overload.
9417
9418 2019-04-23  Tom de Vries  <tdevries@suse.de>
9419
9420         PR gdb/24438
9421         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
9422         invocation.
9423
9424
9425 2019-03-27  Ali Tamur  <tamur@google.com>
9426
9427         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
9428         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
9429         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
9430         (dwarf_expr_context::get_addr_index): Likewise
9431         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
9432         (symbol_needs_eval_context::get_addr_index): Likewise
9433         (disassemble_dwarf_expression): Add DW_OP_addrx
9434         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
9435         (read_cutu_die_from_dwo): Update comment
9436         (skip_one_die): Add DW_FORM_addrx
9437         (read_attribute_value): Likewise
9438         (var_decode_location): Add DW_OP_addrx
9439         (dwarf2_const_value_attr): Add DW_FORM_addrx
9440         (dump_die_shallow): Likewise
9441         (dwarf2_fetch_constant_bytes): Likewise
9442         (decode_locdesc): Add DW_OP_addrx
9443         (skip_form_bytes): Add DW_FORM_addrx
9444
9445 2019-04-22  Ali Tamur  <tamur@google.com>
9446
9447         * MAINTAINERS (Write After Approval): Add self.
9448
9449 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
9450
9451         * solib-svr4.c (get_svr4_info): Add pspace parameter.
9452         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
9453         (open_symbol_file_object): Likewise.
9454         (svr4_default_sos): Add info parameter.
9455         (svr4_read_so_list): Likewise.
9456         (svr4_current_sos_direct): Adjust functions calls to pass down
9457         info.
9458         (svr4_current_sos_1): Add info parameter.
9459         (svr4_current_sos): Call get_svr4_info, pass info down to
9460         svr4_current_sos_1.
9461         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
9462         get_svr4_info.
9463         (svr4_in_dynsym_resolve_code): Pass current_program_space to
9464         get_svr4_info.
9465         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
9466         to get_svr4_info.
9467         (probes_table_remove_objfile_probes): Likewise.
9468         (register_solib_event_probe): Add info parameter.
9469         (solist_update_incremental): Pass info parameter down to
9470         svr4_read_so_list.
9471         (disable_probes_interface): Add info parameter.
9472         (svr4_handle_solib_event): Pass current_program_space to
9473         get_svr4_info.  Adjust disable_probes_interface cleanup.
9474         (svr4_create_probe_breakpoints): Add info parameter, pass it
9475         down to register_solib_event_probe.
9476         (svr4_create_solib_event_breakpoints): Add info parameter,
9477         pass it down to svr4_create_probe_breakpoints.
9478         (enable_break): Pass info down to
9479         svr4_create_solib_event_breakpoints.
9480         (svr4_solib_create_inferior_hook): Pass current_program_space to
9481         get_svr4_info.
9482         (svr4_clear_solib): Likewise.
9483
9484 2019-04-22  Pedro Alves  <palves@redhat.com>
9485
9486         * solib-svr4.c (svr4_free_objfile_observer): New.
9487         (probe_and_action::objfile): New field.
9488         (probes_table_htab_remove_objfile_probes)
9489         (probes_table_remove_objfile_probes): New functions.
9490         (register_solib_event_probe): Add 'objfile' parameter.  Store it
9491         in the new probe_and_action.  Don't store the probe in 'lookup'.
9492         (svr4_create_probe_breakpoints): Pass objfile to
9493         register_solib_event_probe.
9494         (_initialize_svr4_solib): Register a free_objfile observer.
9495
9496 2019-04-19  Tom Tromey  <tom@tromey.com>
9497
9498         * common/queue.h: Remove.
9499
9500 2019-04-19  Tom Tromey  <tom@tromey.com>
9501
9502         * event-loop.c: Don't include "common/queue.h".
9503
9504 2019-04-19  Tom Tromey  <tom@tromey.com>
9505
9506         * remote.c (remote_target): Use delete.
9507         * remote-notif.h: Include <list>, not "common/queue.h".
9508         (notif_client_p): Remove typedef.
9509         (remote_notif_state): Add constructor, destructor, initializer.
9510         <notif_queue>: Now a std::list.
9511         (remote_notif_state_xfree): Don't declare.
9512         * remote-notif.c (remote_notif_process, handle_notification)
9513         (remote_notif_state_allocate): Update.
9514         (~remote_notif_state): Rename from remote_notif_state_xfree.
9515
9516 2019-04-19  Tom Tromey  <tom@tromey.com>
9517
9518         * symfile.c (reread_symbols): Update.
9519         * objfiles.c (objfile_register_static_link)
9520         (objfile_lookup_static_link): Update
9521         (~objfile) Don't delete static_links.
9522         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
9523
9524 2019-04-19  Tom Tromey  <tom@tromey.com>
9525
9526         * type-stack.h (struct type_stack) <insert>: Constify string.
9527         * type-stack.c (type_stack::insert): Constify string.
9528         * gdbtypes.h (lookup_template_type): Update.
9529         (address_space_name_to_int): Update.
9530         * gdbtypes.c (address_space_name_to_int): Make space_identifier
9531         const.
9532         (lookup_template_type): Make name const.
9533         * c-exp.y: Update rules.
9534         (lex_one_token, classify_name, classify_inner_name)
9535         (c_print_token): Update.
9536         * p-exp.y: Update rules.
9537         (yylex): Update.
9538         * f-exp.y: Update rules.
9539         (yylex): Update.
9540         * d-exp.y: Update rules.
9541         (lex_one_token, classify_name, classify_inner_name): Update.
9542         * parse.c (write_dollar_variable, copy_name): Return std::string.
9543         * parser-defs.h (copy_name): Change return type.
9544         * m2-exp.y: Update rules.
9545         (yylex): Update.
9546         * go-exp.y (lex_one_token): Update.
9547         Update rules.
9548         (classify_unsafe_function, classify_packaged_name)
9549         (classify_name, yylex): Update.
9550
9551 2019-04-19  Sergei Trofimovich <siarheit@google.com>
9552
9553         * configure.ac: add --enable-source-highlight switch.
9554         * configure: Regenerate.
9555         * top.c (print_gdb_version): plumb --enable-source-highlight
9556         status to "show configuration".
9557
9558 2019-04-19  Tom Tromey  <tromey@adacore.com>
9559
9560         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
9561         Check ADA_TYPE_P.
9562         (empty_record, ada_template_to_fixed_record_type_1)
9563         (template_to_static_fixed_type)
9564         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
9565         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
9566         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
9567         macros.
9568
9569 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
9570
9571         PR symtab/24423:
9572         * source.c (print_source_lines_base): Advance "iter" when a
9573         control character is seen.
9574
9575 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9576
9577         * inferior.h (struct infcall_suspend_state_deleter):
9578         Catch exception in destructor to avoid crash.
9579
9580 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9581
9582         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
9583         close to the add_com "shell".
9584
9585 2019-04-18  Tom Tromey  <tromey@adacore.com>
9586
9587         * process-stratum-target.h (class process_stratum_target)
9588         <stratum>: Add "final".
9589
9590 2019-04-17  Tom Tromey  <tromey@adacore.com>
9591
9592         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
9593         against nullptr before use.
9594
9595 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
9596
9597         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
9598
9599 2019-04-17  Jim Wilson  <jimw@sifive.com>
9600             Andrew Burgess  <andrew.burgess@embecosm.com>
9601
9602         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
9603         code read might fail, assume 4-byte breakpoint in that case.
9604
9605 2019-04-15  Leszek Swirski  <leszeks@google.com>
9606
9607         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
9608         rather than a hand-rolled POD check when checking for forced MEMORY
9609         classification.
9610
9611 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
9612
9613         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
9614         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
9615         function.
9616         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
9617         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
9618         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
9619         declaration.
9620
9621 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
9622
9623         * aarch64-linux-nat.c
9624         (aarch64_linux_nat_target::thread_architecture): Add override.
9625         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
9626         each VQ.
9627
9628 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
9629
9630         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
9631
9632 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
9633
9634         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
9635         target types of size 96-bits, add some additional comments, and
9636         check that the builtin type we found was the correct size.
9637
9638 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
9639
9640         * utils.c (prompt_for_continue): Don't restore the styling at the
9641         end, as applied_style has the wrong value.  This fixes styling in
9642         long lists of file names that are interrupted by the "Continue?"
9643         prompt.
9644
9645 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
9646
9647         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
9648         * c-lang.c (c_language_defn): Likewise.
9649         (cplus_language_defn): Likewise.
9650         (asm_language_defn): Likewise.
9651         (minimal_language_defn): Likewise.
9652         * d-lang.c (d_language_defn): Likewise.
9653         * f-lang.c (f_language_defn): Likewise.
9654         * go-lang.c (go_language_defn): Likewise.
9655         * language.c (unknown_language_defn): Likewise.
9656         (auto_language_defn): Likewise.
9657         * language.h (struct language_defn): Remove la_magic field.
9658         (LANG_MAGIC): Delete.
9659         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
9660         * objc-lang.c (objc_language_defn): Likewise.
9661         * opencl-lang.c (opencl_language_defn): Likewise.
9662         * p-lang.c (pascal_language_defn): Likewise.
9663         * rust-lang.c (rust_language_defn): Likewise.
9664
9665 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
9666
9667         * riscv-tdep.c (riscv_type_align): New function.
9668         (riscv_type_alignment): Delete.
9669         (riscv_arg_location): Use 'type_align'.
9670         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
9671
9672 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
9673
9674         * gdbtypes.c (type_align): A struct with no non-static fields also
9675         has alignment of 1.
9676
9677 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
9678
9679         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
9680         component to 0.
9681         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
9682         member.
9683         (riscv_struct_info::analyse): New implementation using new
9684         analyse_inner member function.
9685         (riscv_struct_info::field_offset): New member function.
9686         (riscv_struct_info::m_offsets): New member variable.
9687         (riscv_struct_info::analyse_inner): New private member function,
9688         takes the old implementation of riscv_struct_info::analyse but
9689         extended to track field offsets.
9690         (riscv_call_arg_struct): Update the struct folding special cases
9691         to handle cases where empty C++ structs, which are non-zero
9692         length, are found.
9693         (riscv_arg_location): Initialise the length of each location, a
9694         non-zero length now indicates the location is in use.
9695         (riscv_push_dummy_call): Allow for the first location having a
9696         non-zero offset when setting up arguments.
9697         (riscv_return_value): Likewise, but for return values.
9698
9699 2019-04-11  Tom Tromey  <tromey@adacore.com>
9700
9701         * utils.c (internal_vproblem): Make "msg" const.
9702
9703 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
9704
9705         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
9706         * trad-frame.c (trad_frame_reset_saved_regs): New function.
9707         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
9708         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
9709
9710 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
9711
9712         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
9713         function.
9714         (fill_gregset): Call amd64_linux_collect_native_gregset instead
9715         of amd64_collect_native_gregset.
9716         (amd64_linux_nat_target::store_registers): Likewise.
9717
9718 2019-04-10  Tom Tromey  <tom@tromey.com>
9719
9720         * symtab.c (lookup_global_symbol_from_objfile)
9721         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
9722         * objfiles.h (class separate_debug_iterator): New.
9723         (class separate_debug_range): New.
9724         (struct objfile) <separate_debug_objfiles>: New method.
9725         (objfile_separate_debug_iterate): Don't declare.
9726         * objfiles.c (separate_debug_iterator::operator++): Rename from
9727         objfile_separate_debug_iterate.
9728         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
9729         iterator.
9730         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
9731         iterator.
9732
9733 2019-04-10  Tom Tromey  <tom@tromey.com>
9734
9735         * symfile.c (reread_symbols): Remove old comment.
9736         * objfiles.c (free_all_objfiles): Fix a typo.
9737
9738 2019-04-10  Tom Tromey  <tom@tromey.com>
9739
9740         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
9741         * minsyms.c (lookup_minimal_symbol): Use foreach.
9742         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
9743         (lookup_minimal_symbol_solib_trampoline): Likewise.
9744         * symfile.c (reread_symbols): Use foreach.
9745
9746 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
9747             Tom Tromey  <tromey@adacore.com>
9748
9749         PR rust/24414:
9750         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
9751         (rust_lex_int_test): Change "value" to be LONGEST.
9752         (rust_lex_tests): Add test for long integer literal.
9753
9754 2019-04-09  Tom Tromey  <tromey@adacore.com>
9755
9756         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
9757         to bool.
9758         (extended_remote_target::attach): Update.
9759         (remote_target::remote_notice_new_inferior): Update.
9760         (remote_target::add_current_inferior_and_thread): Update.
9761         * inferior.c (exit_inferior_1): Use "false".
9762         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
9763
9764 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
9765
9766         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
9767         the "start" command.
9768
9769 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
9770
9771         * python/py-inferior.c (infpy_thread_from_thread_handle):
9772         Adjust comments to reflect renaming of thread_from_thread_handle
9773         to thread_from_handle.  Adjust keywords.  Fix type error message.
9774         (inferior_object_methods): Add thread_from_handle.  Retain
9775         thread_from_thread_handle, but mark it as deprecated.
9776
9777 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
9778
9779         * gdbthread.h (find_thread_by_handle): Revise declaration.
9780         * thread.c (find_thread_by_handle): Likewise.  Adjust
9781         implementation too.
9782         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
9783         support for buffer objects as handles.
9784
9785 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
9786
9787         * python/py-infthread.c (thpy_thread_handle): New function.
9788         (thread_object_methods): Register thpy_thread_handle.
9789
9790 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
9791
9792         * gdbthread.h (thread_to_thread_handle): Declare.
9793         * thread.c (gdbtypes.h): Include.
9794         (thread_to_thread_handle): New function.
9795
9796         * target.h (struct target_ops): Add thread_info_to_thread_handle.
9797         (target_thread_info_to_thread_handle): Declare.
9798         * target.c (target_thread_info_to_thread_handle): New function.
9799         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
9800         * target-delegates.c: Regenerate.
9801
9802         * linux-thread-db.c (class thread_db_target): Add method
9803         thread_info_to_thread_handle.
9804         (thread_db_target::thread_info_to_thread_handle): Define.
9805         * remote.c (class remote_target): Add new method
9806         thread_info_to_thread_handle.
9807         (remote_target::thread_info_to_thread_handle): Define.
9808
9809 2019-04-08  Pedro Alves  <palves@redhat.com>
9810
9811         * common/common-exceptions.c (throw_exception): Don't create
9812         named object to throw; throw directly.
9813         (throw_it): Likewise.  Don't initialize gdb_exception::message
9814         here, with new; pass FMT and AP to the ctor instead.
9815         * common/common-exceptions.h: Include <string>.
9816         (gdb_exception::gdb_exception(enum return_reason, enum errors,
9817         const char *, va_list)): New ctor.  Use std::make_shared.
9818         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
9819         errors)): Delete.
9820         (gdb_exception_error::gdb_exception_error(enum errors, const char
9821         *, va_list)): New.
9822         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
9823         Add assertion.
9824         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
9825         errors)): Delete.
9826         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
9827         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
9828         Add assertion.
9829
9830 2019-04-08  Tom Tromey  <tom@tromey.com>
9831
9832         * valops.c (value_rtti_indirect_type): Replace throw_exception
9833         with throw.
9834         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
9835         with throw.
9836         * thread.c (thr_try_catch_cmd): Replace throw_exception with
9837         throw.
9838         * target.c (target_translate_tls_address): Replace throw_exception
9839         with throw.
9840         * stack.c (frame_apply_command_count): Replace throw_exception
9841         with throw.
9842         * solib-spu.c (append_ocl_sos): Replace throw_exception with
9843         throw.
9844         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
9845         with throw.
9846         * rs6000-tdep.c (rs6000_frame_cache)
9847         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
9848         * remote.c: Replace throw_exception with throw.
9849         * record-full.c (record_full_message, record_full_wait_1)
9850         (record_full_restore): Replace throw_exception with throw.
9851         * record-btrace.c:
9852         (get_thread_current_frame_id, record_btrace_start_replaying)
9853         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
9854         (cmd_record_btrace_start): Replace throw_exception with throw.
9855         * parse.c (parse_exp_in_context_1): Replace throw_exception with
9856         throw.
9857         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
9858         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
9859         * linespec.c:
9860         (find_linespec_symbols): Replace throw_exception with throw.
9861         * infrun.c (displaced_step_prepare, resume): Replace
9862         throw_exception with throw.
9863         * infcmd.c (post_create_inferior): Replace throw_exception with
9864         throw.
9865         * inf-loop.c (inferior_event_handler): Replace throw_exception
9866         with throw.
9867         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
9868         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
9869         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
9870         (get_prev_frame_always, get_frame_pc_if_available)
9871         (get_frame_address_in_block_if_available, get_frame_language):
9872         Replace throw_exception with throw.
9873         * frame-unwind.c (frame_unwind_try_unwinder): Replace
9874         throw_exception with throw.
9875         * eval.c (fetch_subexp_value, evaluate_var_value)
9876         (evaluate_funcall, evaluate_subexp_standard): Replace
9877         throw_exception with throw.
9878         * dwarf2loc.c (call_site_find_chain)
9879         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
9880         Replace throw_exception with throw.
9881         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
9882         with throw.
9883         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
9884         throw.
9885         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
9886         * completer.c (complete_line_internal): Replace throw_exception
9887         with throw.
9888         * compile/compile-object-run.c (compile_object_run): Replace
9889         throw_exception with throw.
9890         * cli/cli-script.c (process_next_line): Replace throw_exception
9891         with throw.
9892         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
9893         (btrace_enable, btrace_maint_update_pt_packets): Replace
9894         throw_exception with throw.
9895         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
9896         throw_exception with throw.
9897         * break-catch-throw.c (re_set_exception_catchpoint): Replace
9898         throw_exception with throw.
9899         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
9900         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
9901         * aarch64-tdep.c (aarch64_make_prologue_cache)
9902         (aarch64_make_stub_cache): Replace throw_exception with throw.
9903
9904 2019-04-08  Tom Tromey  <tom@tromey.com>
9905
9906         * common/common-exceptions.c (throw_exception): Rename from
9907         throw_exception_cxx.  Remove old copy.  Make argument const.
9908         (throw_it): Create and throw exception objects directly.
9909         * common/common-exceptions.h (throw_exception): Make argument
9910         const.
9911         (struct gdb_exception_error): Add constructor.
9912         (struct gdb_exception_quit): Add constructor.
9913
9914 2019-04-08  Tom Tromey  <tom@tromey.com>
9915
9916         * common/common-exceptions.h (exception_rethrow): Don't declare.
9917         (TRY_SJLJ): Update comment.
9918         (TRY, CATCH, END_CATCH): Remove.
9919         * common/common-exceptions.c (exception_rethrow): Remove.
9920
9921 2019-04-08  Tom Tromey  <tom@tromey.com>
9922
9923         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
9924         Remove.
9925         (gdb_exception_error): Rename from
9926         gdb_exception_RETURN_MASK_ERROR.
9927         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
9928         (gdb_quit_bad_alloc): Update.
9929         * aarch64-tdep.c: Update.
9930         * ada-lang.c: Update.
9931         * ada-typeprint.c: Update.
9932         * ada-valprint.c: Update.
9933         * amd64-tdep.c: Update.
9934         * arch-utils.c: Update.
9935         * break-catch-throw.c: Update.
9936         * breakpoint.c: Update.
9937         * btrace.c: Update.
9938         * c-varobj.c: Update.
9939         * cli/cli-cmds.c: Update.
9940         * cli/cli-interp.c: Update.
9941         * cli/cli-script.c: Update.
9942         * common/common-exceptions.c: Update.
9943         * common/new-op.c: Update.
9944         * common/selftest.c: Update.
9945         * compile/compile-c-symbols.c: Update.
9946         * compile/compile-cplus-symbols.c: Update.
9947         * compile/compile-object-load.c: Update.
9948         * compile/compile-object-run.c: Update.
9949         * completer.c: Update.
9950         * corelow.c: Update.
9951         * cp-abi.c: Update.
9952         * cp-support.c: Update.
9953         * cp-valprint.c: Update.
9954         * darwin-nat.c: Update.
9955         * disasm-selftests.c: Update.
9956         * dtrace-probe.c: Update.
9957         * dwarf-index-cache.c: Update.
9958         * dwarf-index-write.c: Update.
9959         * dwarf2-frame-tailcall.c: Update.
9960         * dwarf2-frame.c: Update.
9961         * dwarf2loc.c: Update.
9962         * dwarf2read.c: Update.
9963         * eval.c: Update.
9964         * event-loop.c: Update.
9965         * event-top.c: Update.
9966         * exec.c: Update.
9967         * f-valprint.c: Update.
9968         * fbsd-tdep.c: Update.
9969         * frame-unwind.c: Update.
9970         * frame.c: Update.
9971         * gdbtypes.c: Update.
9972         * gnu-v3-abi.c: Update.
9973         * guile/guile-internal.h: Update.
9974         * guile/scm-block.c: Update.
9975         * guile/scm-breakpoint.c: Update.
9976         * guile/scm-cmd.c: Update.
9977         * guile/scm-disasm.c: Update.
9978         * guile/scm-frame.c: Update.
9979         * guile/scm-lazy-string.c: Update.
9980         * guile/scm-math.c: Update.
9981         * guile/scm-param.c: Update.
9982         * guile/scm-ports.c: Update.
9983         * guile/scm-pretty-print.c: Update.
9984         * guile/scm-symbol.c: Update.
9985         * guile/scm-symtab.c: Update.
9986         * guile/scm-type.c: Update.
9987         * guile/scm-value.c: Update.
9988         * i386-linux-tdep.c: Update.
9989         * i386-tdep.c: Update.
9990         * inf-loop.c: Update.
9991         * infcall.c: Update.
9992         * infcmd.c: Update.
9993         * infrun.c: Update.
9994         * jit.c: Update.
9995         * language.c: Update.
9996         * linespec.c: Update.
9997         * linux-fork.c: Update.
9998         * linux-nat.c: Update.
9999         * linux-tdep.c: Update.
10000         * linux-thread-db.c: Update.
10001         * main.c: Update.
10002         * mi/mi-cmd-break.c: Update.
10003         * mi/mi-cmd-stack.c: Update.
10004         * mi/mi-interp.c: Update.
10005         * mi/mi-main.c: Update.
10006         * objc-lang.c: Update.
10007         * p-valprint.c: Update.
10008         * parse.c: Update.
10009         * ppc-linux-tdep.c: Update.
10010         * printcmd.c: Update.
10011         * python/py-arch.c: Update.
10012         * python/py-breakpoint.c: Update.
10013         * python/py-cmd.c: Update.
10014         * python/py-finishbreakpoint.c: Update.
10015         * python/py-frame.c: Update.
10016         * python/py-framefilter.c: Update.
10017         * python/py-gdb-readline.c: Update.
10018         * python/py-inferior.c: Update.
10019         * python/py-infthread.c: Update.
10020         * python/py-lazy-string.c: Update.
10021         * python/py-linetable.c: Update.
10022         * python/py-objfile.c: Update.
10023         * python/py-param.c: Update.
10024         * python/py-prettyprint.c: Update.
10025         * python/py-progspace.c: Update.
10026         * python/py-record-btrace.c: Update.
10027         * python/py-record.c: Update.
10028         * python/py-symbol.c: Update.
10029         * python/py-type.c: Update.
10030         * python/py-unwind.c: Update.
10031         * python/py-utils.c: Update.
10032         * python/py-value.c: Update.
10033         * python/python.c: Update.
10034         * record-btrace.c: Update.
10035         * record-full.c: Update.
10036         * remote-fileio.c: Update.
10037         * remote.c: Update.
10038         * riscv-tdep.c: Update.
10039         * rs6000-aix-tdep.c: Update.
10040         * rs6000-tdep.c: Update.
10041         * rust-exp.y: Update.
10042         * rust-lang.c: Update.
10043         * s390-tdep.c: Update.
10044         * selftest-arch.c: Update.
10045         * solib-dsbt.c: Update.
10046         * solib-frv.c: Update.
10047         * solib-spu.c: Update.
10048         * solib-svr4.c: Update.
10049         * solib.c: Update.
10050         * sparc64-linux-tdep.c: Update.
10051         * stack.c: Update.
10052         * symfile-mem.c: Update.
10053         * symmisc.c: Update.
10054         * target.c: Update.
10055         * thread.c: Update.
10056         * top.c: Update.
10057         * tracefile-tfile.c: Update.
10058         * tui/tui.c: Update.
10059         * typeprint.c: Update.
10060         * unittests/cli-utils-selftests.c: Update.
10061         * unittests/parse-connection-spec-selftests.c: Update.
10062         * valops.c: Update.
10063         * valprint.c: Update.
10064         * value.c: Update.
10065         * varobj.c: Update.
10066         * windows-nat.c: Update.
10067         * x86-linux-nat.c: Update.
10068         * xml-support.c: Update.
10069
10070 2019-04-08  Tom Tromey  <tom@tromey.com>
10071
10072         * xml-support.c: Use C++ exception handling.
10073         * x86-linux-nat.c: Use C++ exception handling.
10074         * windows-nat.c: Use C++ exception handling.
10075         * varobj.c: Use C++ exception handling.
10076         * value.c: Use C++ exception handling.
10077         * valprint.c: Use C++ exception handling.
10078         * valops.c: Use C++ exception handling.
10079         * unittests/parse-connection-spec-selftests.c: Use C++ exception
10080         handling.
10081         * unittests/cli-utils-selftests.c: Use C++ exception handling.
10082         * typeprint.c: Use C++ exception handling.
10083         * tui/tui.c: Use C++ exception handling.
10084         * tracefile-tfile.c: Use C++ exception handling.
10085         * top.c: Use C++ exception handling.
10086         * thread.c: Use C++ exception handling.
10087         * target.c: Use C++ exception handling.
10088         * symmisc.c: Use C++ exception handling.
10089         * symfile-mem.c: Use C++ exception handling.
10090         * stack.c: Use C++ exception handling.
10091         * sparc64-linux-tdep.c: Use C++ exception handling.
10092         * solib.c: Use C++ exception handling.
10093         * solib-svr4.c: Use C++ exception handling.
10094         * solib-spu.c: Use C++ exception handling.
10095         * solib-frv.c: Use C++ exception handling.
10096         * solib-dsbt.c: Use C++ exception handling.
10097         * selftest-arch.c: Use C++ exception handling.
10098         * s390-tdep.c: Use C++ exception handling.
10099         * rust-lang.c: Use C++ exception handling.
10100         * rust-exp.y: Use C++ exception handling.
10101         * rs6000-tdep.c: Use C++ exception handling.
10102         * rs6000-aix-tdep.c: Use C++ exception handling.
10103         * riscv-tdep.c: Use C++ exception handling.
10104         * remote.c: Use C++ exception handling.
10105         * remote-fileio.c: Use C++ exception handling.
10106         * record-full.c: Use C++ exception handling.
10107         * record-btrace.c: Use C++ exception handling.
10108         * python/python.c: Use C++ exception handling.
10109         * python/py-value.c: Use C++ exception handling.
10110         * python/py-utils.c: Use C++ exception handling.
10111         * python/py-unwind.c: Use C++ exception handling.
10112         * python/py-type.c: Use C++ exception handling.
10113         * python/py-symbol.c: Use C++ exception handling.
10114         * python/py-record.c: Use C++ exception handling.
10115         * python/py-record-btrace.c: Use C++ exception handling.
10116         * python/py-progspace.c: Use C++ exception handling.
10117         * python/py-prettyprint.c: Use C++ exception handling.
10118         * python/py-param.c: Use C++ exception handling.
10119         * python/py-objfile.c: Use C++ exception handling.
10120         * python/py-linetable.c: Use C++ exception handling.
10121         * python/py-lazy-string.c: Use C++ exception handling.
10122         * python/py-infthread.c: Use C++ exception handling.
10123         * python/py-inferior.c: Use C++ exception handling.
10124         * python/py-gdb-readline.c: Use C++ exception handling.
10125         * python/py-framefilter.c: Use C++ exception handling.
10126         * python/py-frame.c: Use C++ exception handling.
10127         * python/py-finishbreakpoint.c: Use C++ exception handling.
10128         * python/py-cmd.c: Use C++ exception handling.
10129         * python/py-breakpoint.c: Use C++ exception handling.
10130         * python/py-arch.c: Use C++ exception handling.
10131         * printcmd.c: Use C++ exception handling.
10132         * ppc-linux-tdep.c: Use C++ exception handling.
10133         * parse.c: Use C++ exception handling.
10134         * p-valprint.c: Use C++ exception handling.
10135         * objc-lang.c: Use C++ exception handling.
10136         * mi/mi-main.c: Use C++ exception handling.
10137         * mi/mi-interp.c: Use C++ exception handling.
10138         * mi/mi-cmd-stack.c: Use C++ exception handling.
10139         * mi/mi-cmd-break.c: Use C++ exception handling.
10140         * main.c: Use C++ exception handling.
10141         * linux-thread-db.c: Use C++ exception handling.
10142         * linux-tdep.c: Use C++ exception handling.
10143         * linux-nat.c: Use C++ exception handling.
10144         * linux-fork.c: Use C++ exception handling.
10145         * linespec.c: Use C++ exception handling.
10146         * language.c: Use C++ exception handling.
10147         * jit.c: Use C++ exception handling.
10148         * infrun.c: Use C++ exception handling.
10149         * infcmd.c: Use C++ exception handling.
10150         * infcall.c: Use C++ exception handling.
10151         * inf-loop.c: Use C++ exception handling.
10152         * i386-tdep.c: Use C++ exception handling.
10153         * i386-linux-tdep.c: Use C++ exception handling.
10154         * guile/scm-value.c: Use C++ exception handling.
10155         * guile/scm-type.c: Use C++ exception handling.
10156         * guile/scm-symtab.c: Use C++ exception handling.
10157         * guile/scm-symbol.c: Use C++ exception handling.
10158         * guile/scm-pretty-print.c: Use C++ exception handling.
10159         * guile/scm-ports.c: Use C++ exception handling.
10160         * guile/scm-param.c: Use C++ exception handling.
10161         * guile/scm-math.c: Use C++ exception handling.
10162         * guile/scm-lazy-string.c: Use C++ exception handling.
10163         * guile/scm-frame.c: Use C++ exception handling.
10164         * guile/scm-disasm.c: Use C++ exception handling.
10165         * guile/scm-cmd.c: Use C++ exception handling.
10166         * guile/scm-breakpoint.c: Use C++ exception handling.
10167         * guile/scm-block.c: Use C++ exception handling.
10168         * guile/guile-internal.h: Use C++ exception handling.
10169         * gnu-v3-abi.c: Use C++ exception handling.
10170         * gdbtypes.c: Use C++ exception handling.
10171         * frame.c: Use C++ exception handling.
10172         * frame-unwind.c: Use C++ exception handling.
10173         * fbsd-tdep.c: Use C++ exception handling.
10174         * f-valprint.c: Use C++ exception handling.
10175         * exec.c: Use C++ exception handling.
10176         * event-top.c: Use C++ exception handling.
10177         * event-loop.c: Use C++ exception handling.
10178         * eval.c: Use C++ exception handling.
10179         * dwarf2read.c: Use C++ exception handling.
10180         * dwarf2loc.c: Use C++ exception handling.
10181         * dwarf2-frame.c: Use C++ exception handling.
10182         * dwarf2-frame-tailcall.c: Use C++ exception handling.
10183         * dwarf-index-write.c: Use C++ exception handling.
10184         * dwarf-index-cache.c: Use C++ exception handling.
10185         * dtrace-probe.c: Use C++ exception handling.
10186         * disasm-selftests.c: Use C++ exception handling.
10187         * darwin-nat.c: Use C++ exception handling.
10188         * cp-valprint.c: Use C++ exception handling.
10189         * cp-support.c: Use C++ exception handling.
10190         * cp-abi.c: Use C++ exception handling.
10191         * corelow.c: Use C++ exception handling.
10192         * completer.c: Use C++ exception handling.
10193         * compile/compile-object-run.c: Use C++ exception handling.
10194         * compile/compile-object-load.c: Use C++ exception handling.
10195         * compile/compile-cplus-symbols.c: Use C++ exception handling.
10196         * compile/compile-c-symbols.c: Use C++ exception handling.
10197         * common/selftest.c: Use C++ exception handling.
10198         * common/new-op.c: Use C++ exception handling.
10199         * cli/cli-script.c: Use C++ exception handling.
10200         * cli/cli-interp.c: Use C++ exception handling.
10201         * cli/cli-cmds.c: Use C++ exception handling.
10202         * c-varobj.c: Use C++ exception handling.
10203         * btrace.c: Use C++ exception handling.
10204         * breakpoint.c: Use C++ exception handling.
10205         * break-catch-throw.c: Use C++ exception handling.
10206         * arch-utils.c: Use C++ exception handling.
10207         * amd64-tdep.c: Use C++ exception handling.
10208         * ada-valprint.c: Use C++ exception handling.
10209         * ada-typeprint.c: Use C++ exception handling.
10210         * ada-lang.c: Use C++ exception handling.
10211         * aarch64-tdep.c: Use C++ exception handling.
10212
10213 2019-04-08  Tom Tromey  <tom@tromey.com>
10214
10215         * xml-support.c (gdb_xml_parser::parse): Update.
10216         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
10217         * value.c (show_convenience): Update.
10218         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
10219         (test_parse_flags_qcs): Update.
10220         * thread.c (thr_try_catch_cmd): Update.
10221         * target.c (target_translate_tls_address): Update.
10222         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
10223         (info_frame_command_core, frame_apply_command_count): Update.
10224         * rust-exp.y (rust_lex_exception_test): Update.
10225         * riscv-tdep.c (riscv_print_one_register_info): Update.
10226         * remote.c (remote_target::enable_btrace): Update.
10227         * record-btrace.c (record_btrace_enable_warn): Update.
10228         * python/py-utils.c (gdbpy_convert_exception): Update.
10229         * printcmd.c (do_one_display, print_variable_and_value): Update.
10230         * mi/mi-main.c (mi_print_exception): Update.
10231         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
10232         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
10233         * linux-nat.c (linux_nat_target::attach): Update.
10234         * linux-fork.c (class scoped_switch_fork_info): Update.
10235         * infrun.c (displaced_step_prepare): Update.
10236         * infcall.c (call_function_by_hand_dummy): Update.
10237         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
10238         * gnu-v3-abi.c (print_one_vtable): Update.
10239         * frame.c (get_prev_frame_always): Update.
10240         * f-valprint.c (info_common_command_for_block): Update.
10241         * exec.c (try_open_exec_file): Update.
10242         * exceptions.c (print_exception, exception_print)
10243         (exception_fprintf, exception_print_same): Update.
10244         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
10245         * dwarf-index-cache.c (index_cache::store)
10246         (index_cache::lookup_gdb_index): Update.
10247         * darwin-nat.c (maybe_cache_shell): Update.
10248         * cp-valprint.c (cp_print_value_fields): Update.
10249         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
10250         (gcc_cplus_symbol_address): Update.
10251         * compile/compile-c-symbols.c (gcc_convert_symbol)
10252         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
10253         * common/selftest.c: Update.
10254         * common/common-exceptions.h (struct gdb_exception) <message>: Now
10255         a std::string.
10256         (exception_try_scope_entry, exception_try_scope_exit): Don't
10257         declare.
10258         (struct exception_try_scope): Remove.
10259         (TRY): Don't use exception_try_scope.
10260         (struct gdb_exception): Add constructor, operator=.
10261         <what>: New method.
10262         (struct gdb_exception_RETURN_MASK_ALL)
10263         (struct gdb_exception_RETURN_MASK_ERROR)
10264         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
10265         (struct gdb_quit_bad_alloc): Update.
10266         * common/common-exceptions.c (exception_none): Change
10267         initializer.
10268         (struct catcher) <state, exception>: Initialize inline.
10269         <prev>: Remove member.
10270         (current_catcher): Remove.
10271         (catchers): New global.
10272         (exceptions_state_mc_init): Simplify.
10273         (catcher_pop): Remove.
10274         (exceptions_state_mc, exceptions_state_mc_catch): Update.
10275         (try_scope_depth, exception_try_scope_entry)
10276         (exception_try_scope_exit): Remove.
10277         (throw_exception_sjlj): Update.
10278         (exception_messages, exception_messages_size): Remove.
10279         (throw_it): Simplify.
10280         (gdb_exception_sliced_copy): Remove.
10281         (throw_exception_cxx): Update.
10282         * cli/cli-script.c (script_from_file): Update.
10283         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
10284         Update.
10285         * ada-valprint.c (ada_val_print): Update.
10286         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
10287         (create_excep_cond_exprs): Update.
10288
10289 2019-04-08  Tom Tromey  <tom@tromey.com>
10290
10291         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
10292         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
10293         (TRY, CATCH, END_CATCH): Remove some definitions.
10294         * common/common-exceptions.c: Don't use GDB_XCPT.
10295         (catcher_list_size): Remove.
10296         (throw_exception, throw_it): Simplify.
10297
10298 2019-04-05  Tom Tromey  <tom@tromey.com>
10299
10300         Revert the header-sorting patch.
10301         * ft32-tdep.c: Revert.
10302         * frv-tdep.c: Revert.
10303         * frv-linux-tdep.c: Revert.
10304         * frame.c: Revert.
10305         * frame-unwind.c: Revert.
10306         * frame-base.c: Revert.
10307         * fork-child.c: Revert.
10308         * findvar.c: Revert.
10309         * findcmd.c: Revert.
10310         * filesystem.c: Revert.
10311         * filename-seen-cache.h: Revert.
10312         * filename-seen-cache.c: Revert.
10313         * fbsd-tdep.c: Revert.
10314         * fbsd-nat.h: Revert.
10315         * fbsd-nat.c: Revert.
10316         * f-valprint.c: Revert.
10317         * f-typeprint.c: Revert.
10318         * f-lang.c: Revert.
10319         * extension.h: Revert.
10320         * extension.c: Revert.
10321         * extension-priv.h: Revert.
10322         * expprint.c: Revert.
10323         * exec.h: Revert.
10324         * exec.c: Revert.
10325         * exceptions.c: Revert.
10326         * event-top.c: Revert.
10327         * event-loop.c: Revert.
10328         * eval.c: Revert.
10329         * elfread.c: Revert.
10330         * dwarf2read.h: Revert.
10331         * dwarf2read.c: Revert.
10332         * dwarf2loc.c: Revert.
10333         * dwarf2expr.h: Revert.
10334         * dwarf2expr.c: Revert.
10335         * dwarf2-frame.c: Revert.
10336         * dwarf2-frame-tailcall.c: Revert.
10337         * dwarf-index-write.h: Revert.
10338         * dwarf-index-write.c: Revert.
10339         * dwarf-index-common.c: Revert.
10340         * dwarf-index-cache.h: Revert.
10341         * dwarf-index-cache.c: Revert.
10342         * dummy-frame.c: Revert.
10343         * dtrace-probe.c: Revert.
10344         * disasm.h: Revert.
10345         * disasm.c: Revert.
10346         * disasm-selftests.c: Revert.
10347         * dictionary.c: Revert.
10348         * dicos-tdep.c: Revert.
10349         * demangle.c: Revert.
10350         * dcache.h: Revert.
10351         * dcache.c: Revert.
10352         * darwin-nat.h: Revert.
10353         * darwin-nat.c: Revert.
10354         * darwin-nat-info.c: Revert.
10355         * d-valprint.c: Revert.
10356         * d-namespace.c: Revert.
10357         * d-lang.c: Revert.
10358         * ctf.c: Revert.
10359         * csky-tdep.c: Revert.
10360         * csky-linux-tdep.c: Revert.
10361         * cris-tdep.c: Revert.
10362         * cris-linux-tdep.c: Revert.
10363         * cp-valprint.c: Revert.
10364         * cp-support.c: Revert.
10365         * cp-namespace.c: Revert.
10366         * cp-abi.c: Revert.
10367         * corelow.c: Revert.
10368         * corefile.c: Revert.
10369         * continuations.c: Revert.
10370         * completer.h: Revert.
10371         * completer.c: Revert.
10372         * complaints.c: Revert.
10373         * coffread.c: Revert.
10374         * coff-pe-read.c: Revert.
10375         * cli-out.h: Revert.
10376         * cli-out.c: Revert.
10377         * charset.c: Revert.
10378         * c-varobj.c: Revert.
10379         * c-valprint.c: Revert.
10380         * c-typeprint.c: Revert.
10381         * c-lang.c: Revert.
10382         * buildsym.c: Revert.
10383         * buildsym-legacy.c: Revert.
10384         * build-id.h: Revert.
10385         * build-id.c: Revert.
10386         * btrace.c: Revert.
10387         * bsd-uthread.c: Revert.
10388         * breakpoint.h: Revert.
10389         * breakpoint.c: Revert.
10390         * break-catch-throw.c: Revert.
10391         * break-catch-syscall.c: Revert.
10392         * break-catch-sig.c: Revert.
10393         * blockframe.c: Revert.
10394         * block.c: Revert.
10395         * bfin-tdep.c: Revert.
10396         * bfin-linux-tdep.c: Revert.
10397         * bfd-target.c: Revert.
10398         * bcache.c: Revert.
10399         * ax-general.c: Revert.
10400         * ax-gdb.h: Revert.
10401         * ax-gdb.c: Revert.
10402         * avr-tdep.c: Revert.
10403         * auxv.c: Revert.
10404         * auto-load.c: Revert.
10405         * arm-wince-tdep.c: Revert.
10406         * arm-tdep.c: Revert.
10407         * arm-symbian-tdep.c: Revert.
10408         * arm-pikeos-tdep.c: Revert.
10409         * arm-obsd-tdep.c: Revert.
10410         * arm-nbsd-tdep.c: Revert.
10411         * arm-nbsd-nat.c: Revert.
10412         * arm-linux-tdep.c: Revert.
10413         * arm-linux-nat.c: Revert.
10414         * arm-fbsd-tdep.c: Revert.
10415         * arm-fbsd-nat.c: Revert.
10416         * arm-bsd-tdep.c: Revert.
10417         * arch-utils.c: Revert.
10418         * arc-tdep.c: Revert.
10419         * arc-newlib-tdep.c: Revert.
10420         * annotate.h: Revert.
10421         * annotate.c: Revert.
10422         * amd64-windows-tdep.c: Revert.
10423         * amd64-windows-nat.c: Revert.
10424         * amd64-tdep.c: Revert.
10425         * amd64-sol2-tdep.c: Revert.
10426         * amd64-obsd-tdep.c: Revert.
10427         * amd64-obsd-nat.c: Revert.
10428         * amd64-nbsd-tdep.c: Revert.
10429         * amd64-nbsd-nat.c: Revert.
10430         * amd64-nat.c: Revert.
10431         * amd64-linux-tdep.c: Revert.
10432         * amd64-linux-nat.c: Revert.
10433         * amd64-fbsd-tdep.c: Revert.
10434         * amd64-fbsd-nat.c: Revert.
10435         * amd64-dicos-tdep.c: Revert.
10436         * amd64-darwin-tdep.c: Revert.
10437         * amd64-bsd-nat.c: Revert.
10438         * alpha-tdep.c: Revert.
10439         * alpha-obsd-tdep.c: Revert.
10440         * alpha-nbsd-tdep.c: Revert.
10441         * alpha-mdebug-tdep.c: Revert.
10442         * alpha-linux-tdep.c: Revert.
10443         * alpha-linux-nat.c: Revert.
10444         * alpha-bsd-tdep.c: Revert.
10445         * alpha-bsd-nat.c: Revert.
10446         * aix-thread.c: Revert.
10447         * agent.c: Revert.
10448         * addrmap.c: Revert.
10449         * ada-varobj.c: Revert.
10450         * ada-valprint.c: Revert.
10451         * ada-typeprint.c: Revert.
10452         * ada-tasks.c: Revert.
10453         * ada-lang.c: Revert.
10454         * aarch64-tdep.c: Revert.
10455         * aarch64-ravenscar-thread.c: Revert.
10456         * aarch64-newlib-tdep.c: Revert.
10457         * aarch64-linux-tdep.c: Revert.
10458         * aarch64-linux-nat.c: Revert.
10459         * aarch64-fbsd-tdep.c: Revert.
10460         * aarch64-fbsd-nat.c: Revert.
10461         * aarch32-linux-nat.c: Revert.
10462
10463 2019-04-05  Tom Tromey  <tom@tromey.com>
10464
10465         * ft32-tdep.c: Sort headers.
10466         * frv-tdep.c: Sort headers.
10467         * frv-linux-tdep.c: Sort headers.
10468         * frame.c: Sort headers.
10469         * frame-unwind.c: Sort headers.
10470         * frame-base.c: Sort headers.
10471         * fork-child.c: Sort headers.
10472         * findvar.c: Sort headers.
10473         * findcmd.c: Sort headers.
10474         * filesystem.c: Sort headers.
10475         * filename-seen-cache.h: Sort headers.
10476         * filename-seen-cache.c: Sort headers.
10477         * fbsd-tdep.c: Sort headers.
10478         * fbsd-nat.h: Sort headers.
10479         * fbsd-nat.c: Sort headers.
10480         * f-valprint.c: Sort headers.
10481         * f-typeprint.c: Sort headers.
10482         * f-lang.c: Sort headers.
10483         * extension.h: Sort headers.
10484         * extension.c: Sort headers.
10485         * extension-priv.h: Sort headers.
10486         * expprint.c: Sort headers.
10487         * exec.h: Sort headers.
10488         * exec.c: Sort headers.
10489         * exceptions.c: Sort headers.
10490         * event-top.c: Sort headers.
10491         * event-loop.c: Sort headers.
10492         * eval.c: Sort headers.
10493         * elfread.c: Sort headers.
10494         * dwarf2read.h: Sort headers.
10495         * dwarf2read.c: Sort headers.
10496         * dwarf2loc.c: Sort headers.
10497         * dwarf2expr.h: Sort headers.
10498         * dwarf2expr.c: Sort headers.
10499         * dwarf2-frame.c: Sort headers.
10500         * dwarf2-frame-tailcall.c: Sort headers.
10501         * dwarf-index-write.h: Sort headers.
10502         * dwarf-index-write.c: Sort headers.
10503         * dwarf-index-common.c: Sort headers.
10504         * dwarf-index-cache.h: Sort headers.
10505         * dwarf-index-cache.c: Sort headers.
10506         * dummy-frame.c: Sort headers.
10507         * dtrace-probe.c: Sort headers.
10508         * disasm.h: Sort headers.
10509         * disasm.c: Sort headers.
10510         * disasm-selftests.c: Sort headers.
10511         * dictionary.c: Sort headers.
10512         * dicos-tdep.c: Sort headers.
10513         * demangle.c: Sort headers.
10514         * dcache.h: Sort headers.
10515         * dcache.c: Sort headers.
10516         * darwin-nat.h: Sort headers.
10517         * darwin-nat.c: Sort headers.
10518         * darwin-nat-info.c: Sort headers.
10519         * d-valprint.c: Sort headers.
10520         * d-namespace.c: Sort headers.
10521         * d-lang.c: Sort headers.
10522         * ctf.c: Sort headers.
10523         * csky-tdep.c: Sort headers.
10524         * csky-linux-tdep.c: Sort headers.
10525         * cris-tdep.c: Sort headers.
10526         * cris-linux-tdep.c: Sort headers.
10527         * cp-valprint.c: Sort headers.
10528         * cp-support.c: Sort headers.
10529         * cp-namespace.c: Sort headers.
10530         * cp-abi.c: Sort headers.
10531         * corelow.c: Sort headers.
10532         * corefile.c: Sort headers.
10533         * continuations.c: Sort headers.
10534         * completer.h: Sort headers.
10535         * completer.c: Sort headers.
10536         * complaints.c: Sort headers.
10537         * coffread.c: Sort headers.
10538         * coff-pe-read.c: Sort headers.
10539         * cli-out.h: Sort headers.
10540         * cli-out.c: Sort headers.
10541         * charset.c: Sort headers.
10542         * c-varobj.c: Sort headers.
10543         * c-valprint.c: Sort headers.
10544         * c-typeprint.c: Sort headers.
10545         * c-lang.c: Sort headers.
10546         * buildsym.c: Sort headers.
10547         * buildsym-legacy.c: Sort headers.
10548         * build-id.h: Sort headers.
10549         * build-id.c: Sort headers.
10550         * btrace.c: Sort headers.
10551         * bsd-uthread.c: Sort headers.
10552         * breakpoint.h: Sort headers.
10553         * breakpoint.c: Sort headers.
10554         * break-catch-throw.c: Sort headers.
10555         * break-catch-syscall.c: Sort headers.
10556         * break-catch-sig.c: Sort headers.
10557         * blockframe.c: Sort headers.
10558         * block.c: Sort headers.
10559         * bfin-tdep.c: Sort headers.
10560         * bfin-linux-tdep.c: Sort headers.
10561         * bfd-target.c: Sort headers.
10562         * bcache.c: Sort headers.
10563         * ax-general.c: Sort headers.
10564         * ax-gdb.h: Sort headers.
10565         * ax-gdb.c: Sort headers.
10566         * avr-tdep.c: Sort headers.
10567         * auxv.c: Sort headers.
10568         * auto-load.c: Sort headers.
10569         * arm-wince-tdep.c: Sort headers.
10570         * arm-tdep.c: Sort headers.
10571         * arm-symbian-tdep.c: Sort headers.
10572         * arm-pikeos-tdep.c: Sort headers.
10573         * arm-obsd-tdep.c: Sort headers.
10574         * arm-nbsd-tdep.c: Sort headers.
10575         * arm-nbsd-nat.c: Sort headers.
10576         * arm-linux-tdep.c: Sort headers.
10577         * arm-linux-nat.c: Sort headers.
10578         * arm-fbsd-tdep.c: Sort headers.
10579         * arm-fbsd-nat.c: Sort headers.
10580         * arm-bsd-tdep.c: Sort headers.
10581         * arch-utils.c: Sort headers.
10582         * arc-tdep.c: Sort headers.
10583         * arc-newlib-tdep.c: Sort headers.
10584         * annotate.h: Sort headers.
10585         * annotate.c: Sort headers.
10586         * amd64-windows-tdep.c: Sort headers.
10587         * amd64-windows-nat.c: Sort headers.
10588         * amd64-tdep.c: Sort headers.
10589         * amd64-sol2-tdep.c: Sort headers.
10590         * amd64-obsd-tdep.c: Sort headers.
10591         * amd64-obsd-nat.c: Sort headers.
10592         * amd64-nbsd-tdep.c: Sort headers.
10593         * amd64-nbsd-nat.c: Sort headers.
10594         * amd64-nat.c: Sort headers.
10595         * amd64-linux-tdep.c: Sort headers.
10596         * amd64-linux-nat.c: Sort headers.
10597         * amd64-fbsd-tdep.c: Sort headers.
10598         * amd64-fbsd-nat.c: Sort headers.
10599         * amd64-dicos-tdep.c: Sort headers.
10600         * amd64-darwin-tdep.c: Sort headers.
10601         * amd64-bsd-nat.c: Sort headers.
10602         * alpha-tdep.c: Sort headers.
10603         * alpha-obsd-tdep.c: Sort headers.
10604         * alpha-nbsd-tdep.c: Sort headers.
10605         * alpha-mdebug-tdep.c: Sort headers.
10606         * alpha-linux-tdep.c: Sort headers.
10607         * alpha-linux-nat.c: Sort headers.
10608         * alpha-bsd-tdep.c: Sort headers.
10609         * alpha-bsd-nat.c: Sort headers.
10610         * aix-thread.c: Sort headers.
10611         * agent.c: Sort headers.
10612         * addrmap.c: Sort headers.
10613         * ada-varobj.c: Sort headers.
10614         * ada-valprint.c: Sort headers.
10615         * ada-typeprint.c: Sort headers.
10616         * ada-tasks.c: Sort headers.
10617         * ada-lang.c: Sort headers.
10618         * aarch64-tdep.c: Sort headers.
10619         * aarch64-ravenscar-thread.c: Sort headers.
10620         * aarch64-newlib-tdep.c: Sort headers.
10621         * aarch64-linux-tdep.c: Sort headers.
10622         * aarch64-linux-nat.c: Sort headers.
10623         * aarch64-fbsd-tdep.c: Sort headers.
10624         * aarch64-fbsd-nat.c: Sort headers.
10625         * aarch32-linux-nat.c: Sort headers.
10626
10627 2019-04-04  Tom Tromey  <tom@tromey.com>
10628
10629         * varobj.c (varobj_create): Update.
10630         * rust-exp.y (struct rust_parser) <update_innermost_block,
10631         lookup_symbol>: New methods.
10632         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
10633         Rename.
10634         (rust_parser::rust_lookup_type)
10635         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
10636         * printcmd.c (display_command, do_one_display): Update.
10637         * parser-defs.h (struct parser_state) <parser_state>: Add
10638         "tracker" parameter.
10639         (block_tracker): New member.
10640         (class innermost_block_tracker) <innermost_block_tracker>: Add
10641         "types" parameter.
10642         <reset>: Remove method.
10643         (innermost_block): Don't declare.
10644         (null_post_parser): Update.
10645         * parse.c (innermost_block): Remove global.
10646         (write_dollar_variable): Update.
10647         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
10648         Remove "tracker_types" parameter.
10649         (parse_expression): Add "tracker" parameter.
10650         (parse_expression_for_completion): Update.
10651         (null_post_parser): Add "tracker" parameter.
10652         * p-exp.y: Update rules.
10653         * m2-exp.y: Update rules.
10654         * language.h (struct language_defn) <la_post_parser>: Add
10655         "tracker" parameter.
10656         * go-exp.y: Update rules.
10657         * f-exp.y: Update rules.
10658         * expression.h (parse_expression, parse_exp_1): Add "tracker"
10659         parameter.
10660         * d-exp.y: Update rules.
10661         * c-exp.y: Update rules.
10662         * breakpoint.c (set_breakpoint_condition): Create an
10663         innermost_block_tracker.
10664         (watch_command_1): Likewise.
10665         * ada-lang.c (resolve): Add "tracker" parameter.
10666         (resolve_subexp): Likewise.
10667         * ada-exp.y (write_var_from_sym): Update.
10668
10669 2019-04-04  Tom Tromey  <tom@tromey.com>
10670
10671         * type-stack.h: New file.
10672         * type-stack.c: New file.
10673         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
10674         type-stack.h.
10675         (insert_into_type_stack, insert_type, push_type, push_type_int)
10676         (insert_type_address_space, pop_type, pop_type_int)
10677         (pop_typelist, pop_type_stack, append_type_stack)
10678         (push_type_stack, get_type_stack, push_typelist)
10679         (follow_type_instance_flags, follow_types): Don't declare.
10680         * parse.c (type_stack): Remove global.
10681         (parse_exp_in_context): Update.
10682         (insert_into_type_stack, insert_type, push_type, push_type_int)
10683         (insert_type_address_space, pop_type, pop_type_int)
10684         (pop_typelist, pop_type_stack, append_type_stack)
10685         (push_type_stack, get_type_stack, push_typelist)
10686         (follow_type_instance_flags, follow_types): Remove (moved to
10687         type-stack.c).
10688         * f-exp.y (type_stack): New global.
10689         Update rules.
10690         (push_kind_type, f_parse): Update.
10691         * d-exp.y (type_stack): New global.
10692         Update rules.
10693         (d_parse): Update.
10694         * c-exp.y (struct c_parse_state) <type_stack>: New member.
10695         Update rules.
10696         * Makefile.in (COMMON_SFILES): Add type-stack.c.
10697         (HFILES_NO_SRCDIR): Add type-stack.h.
10698
10699 2019-04-04  Tom Tromey  <tom@tromey.com>
10700
10701         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
10702         (rust_parser::convert_ast_to_expression, rust_parse)
10703         (rust_lex_test_completion, rust_lex_tests): Update.
10704         * parser-defs.h (struct expr_completion_state): New.
10705         (struct parser_state) <parser_state>: Add completion parameter.
10706         <mark_struct_expression, mark_completion_tag>: New methods.
10707         <parse_completion, m_completion_state>: New members.
10708         (prefixify_expression, null_post_parser): Update.
10709         (mark_struct_expression, mark_completion_tag): Don't declare.
10710         * parse.c (parse_completion, expout_last_struct)
10711         (expout_tag_completion_type, expout_completion_name): Remove
10712         globals.
10713         (parser_state::mark_struct_expression)
10714         (parser_state::mark_completion_tag): Now methods.
10715         (prefixify_expression): Add last_struct parameter.
10716         (prefixify_subexp): Likewise.
10717         (parse_exp_1): Update.
10718         (parse_exp_in_context): Add cstate parameter.  Update.
10719         (parse_expression_for_completion): Create an
10720         expr_completion_state.
10721         (null_post_parser): Add "completion" parameter.
10722         * p-exp.y: Update rules.
10723         (yylex): Update.
10724         * language.h (struct language_defn) <la_post_parser>: Add
10725         "completing" parameter.
10726         * go-exp.y: Update rules.
10727         (lex_one_token): Update.
10728         * expression.h (parse_completion): Don't declare.
10729         * d-exp.y: Update rules.
10730         (lex_one_token): Update rules.
10731         * c-exp.y: Update rules.
10732         (lex_one_token): Update.
10733         * ada-lang.c (resolve): Add "parse_completion" parameter.
10734         (resolve_subexp): Likewise.
10735         (ada_resolve_function): Likewise.
10736
10737 2019-04-04  Tom Tromey  <tom@tromey.com>
10738
10739         * parser-defs.h (struct parser_state) <start_arglist,
10740         end_arglist>: New methods.
10741         <arglist_len, m_funcall_chain>: New members.
10742         (arglist_len, start_arglist, end_arglist): Don't declare.
10743         * parse.c (arglist_len, funcall_chain): Remove global.
10744         (start_arglist, end_arglist): Remove functions.
10745         (parse_exp_in_context): Update.
10746         * p-exp.y: Update rules.
10747         * m2-exp.y: Update rules.
10748         * go-exp.y: Update rules.
10749         * f-exp.y: Update rules.
10750         * d-exp.y: Update rules.
10751         * c-exp.y: Update rules.
10752
10753 2019-04-04  Tom Tromey  <tom@tromey.com>
10754
10755         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
10756         lex_operator, push_back>: New methods.
10757         Update all rules.
10758         (rust_parser::lex_hex, lex_escape): Rename and update.
10759         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
10760         (rust_parser::lex_operator): Rename and update.
10761         (rust_parser::lex_number, rustyylex, rustyyerror)
10762         (rust_lex_test_init, rust_lex_test_sequence)
10763         (rust_lex_test_push_back, rust_lex_tests): Update.
10764         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
10765         parameter.
10766         <lexptr, prev_lexptr>: New members.
10767         (lexptr, prev_lexptr): Don't declare.
10768         * parse.c (lexptr, prev_lexptr): Remove globals.
10769         (parse_exp_in_context): Update.
10770         * p-exp.y (yylex, yyerror): Update.
10771         * m2-exp.y (parse_number, yylex, yyerror): Update.
10772         * go-exp.y (lex_one_token, yyerror): Update.
10773         * f-exp.y (match_string_literal, yylex, yyerror): Update.
10774         * d-exp.y (lex_one_token, yyerror): Update.
10775         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
10776         (lex_one_token, yyerror): Update.
10777         * ada-lex.l (YY_INPUT): Update.
10778         (rewind_to_char): Update.
10779         * ada-exp.y (yyerror): Update.
10780
10781 2019-04-04  Tom Tromey  <tom@tromey.com>
10782
10783         * rust-exp.y (rustyylex, rust_lex_tests): Update.
10784         * parser-defs.h (struct parser_state) <parser_state>: Add new
10785         parameter.
10786         <comma_terminates>: New member.
10787         (comma_terminates): Don't declare global.
10788         * parse.c (comma_terminates): Remove global.
10789         (parse_exp_in_context): Update.
10790         * p-exp.y (yylex): Update.
10791         * m2-exp.y (yylex): Update.
10792         * go-exp.y (lex_one_token): Update.
10793         * f-exp.y (yylex): Update.
10794         * d-exp.y (lex_one_token): Update.
10795         * c-exp.y (lex_one_token): Update.
10796         * ada-lex.l: Update.
10797
10798 2019-04-04  Tom Tromey  <tom@tromey.com>
10799
10800         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
10801         (rustyylex, rust_lex_test_init, rust_lex_test_one)
10802         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
10803         * parser-defs.h (paren_depth): Don't declare.
10804         * parse.c (paren_depth): Remove global.
10805         (parse_exp_in_context): Update.
10806         * p-exp.y (paren_depth): New global.
10807         (pascal_parse): Initialize it.
10808         * m2-exp.y (paren_depth): New global.
10809         (m2_parse): Initialize it.
10810         * go-exp.y (paren_depth): New global.
10811         (go_parse): Initialize it.
10812         * f-exp.y (paren_depth): New global.
10813         (f_parse): Initialize it.
10814         * d-exp.y (paren_depth): New global.
10815         (d_parse): Initialize it.
10816         * c-exp.y (paren_depth): New global.
10817         (c_parse): Initialize it.
10818         * ada-lex.l (paren_depth): New global.
10819         (lexer_init): Initialize it.
10820
10821 2019-04-04  Tom Tromey  <tom@tromey.com>
10822
10823         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
10824         (rust_parser::convert_ast_to_type)
10825         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
10826         * parser-defs.h (struct parser_state) <parser_state>: Add
10827         parameters.  Initialize new members.
10828         <expression_context_block, expression_context_pc>: New members.
10829         * parse.c (expression_context_block, expression_context_pc):
10830         Remove globals.
10831         (parse_exp_in_context): Update.
10832         * p-exp.y: Update all rules.
10833         (yylex): Update.
10834         * m2-exp.y: Update all rules.
10835         (yylex): Update.
10836         * go-exp.y (yylex): Update.
10837         * f-exp.y (yylex): Update.
10838         * d-exp.y: Update all rules.
10839         (yylex): Update.
10840         * c-exp.y: Update all rules.
10841         (lex_one_token, classify_name, yylex, c_parse): Update.
10842         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
10843
10844 2019-04-04  Tom Tromey  <tom@tromey.com>
10845
10846         * gdbarch.h, gdbarch.c: Rebuild.
10847         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
10848         * stap-probe.h:
10849         (struct stap_parse_info): Replace "parser_state" with
10850         "expr_builder".
10851         * parser-defs.h (struct expr_builder): Rename from "parser_state".
10852         (parser_state): New class.
10853         * parse.c (expr_builder): Rename.
10854         (expr_builder::release): Rename.
10855         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
10856         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
10857         (write_exp_elt_longcst, write_exp_elt_floatcst)
10858         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
10859         (write_exp_string_vector, write_exp_bitstring)
10860         (write_exp_msymbol, mark_struct_expression)
10861         (write_dollar_variable)
10862         (insert_type_address_space, increase_expout_size): Replace
10863         "parser_state" with "expr_builder".
10864         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
10865         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
10866         "parser_state" with "expr_builder".
10867
10868 2019-04-04  Tom Tromey  <tom@tromey.com>
10869
10870         * rust-exp.y: Replace "parse_language" with method call.
10871         * p-exp.y:
10872         (yylex): Replace "parse_language" with method call.
10873         * m2-exp.y:
10874         (yylex): Replace "parse_language" with method call.
10875         * go-exp.y (classify_name): Replace "parse_language" with method
10876         call.
10877         * f-exp.y (yylex): Replace "parse_language" with method call.
10878         * d-exp.y (lex_one_token): Replace "parse_language" with method
10879         call.
10880         * c-exp.y:
10881         (lex_one_token, classify_name, yylex): Replace "parse_language"
10882         with method call.
10883         * ada-exp.y (find_primitive_type, type_char)
10884         (type_system_address): Replace "parse_language" with method call.
10885
10886 2019-04-04  Tom Tromey  <tom@tromey.com>
10887
10888         * rust-exp.y: Replace "parse_gdbarch" with method call.
10889         * parse.c (write_dollar_variable, insert_type_address_space):
10890         Replace "parse_gdbarch" with method call.
10891         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
10892         call.
10893         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
10894         call.
10895         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
10896         "parse_gdbarch" with method call.
10897         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
10898         with method call.
10899         * f-exp.y (parse_type, parse_f_type, yylex): Replace
10900         "parse_gdbarch" with method call.
10901         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
10902         "parse_gdbarch" with method call.
10903         * c-exp.y (parse_type, parse_number, classify_name): Replace
10904         "parse_gdbarch" with method call.
10905         * ada-lex.l: Replace "parse_gdbarch" with method call.
10906         * ada-exp.y (parse_type, find_primitive_type, type_char)
10907         (type_system_address): Replace "parse_gdbarch" with method call.
10908
10909 2019-04-04  Tom Tromey  <tom@tromey.com>
10910
10911         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
10912         * stap-probe.c (stap_parse_argument): Update.
10913         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
10914         initial_size parameter.
10915         * rust-exp.y (rust_lex_tests): Update.
10916         * parse.c (parser_state): Update.
10917         (parse_exp_in_context): Update.
10918         * parser-defs.h (struct parser_state) <parser_state>: Remove
10919         "initial_size" parameter.
10920
10921 2019-04-04  Tom Tromey  <tom@tromey.com>
10922
10923         * parser-defs.h (increase_expout_size): Don't declare.
10924         * parse.c (increase_expout_size): Now static.
10925
10926 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
10927
10928         * gnu-nat.c (gnu_nat_target::wait): Fix
10929         target_waitstatus_to_string call.
10930
10931 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
10932
10933         * eval.c (evaluate_subexp_standard): Handle internal functions
10934         during Fortran function call handling.
10935
10936 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
10937
10938         * NEWS: Mention new internal functions.
10939         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
10940         (read_base_type): Use dwarf2_init_complex_target_type.
10941         * value.c (creal_internal_fn): New function.
10942         (cimag_internal_fn): New function.
10943         (_initialize_values): Register new internal functions.
10944
10945 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10946
10947         * infrun.c (stop_all_threads): If debug_infrun, always
10948         trace the wait status after wait_one, using
10949         target_waitstatus_to_string and target_pid_to_str.
10950         (handle_inferior_event): Replace various trace of
10951         wait status kind by a single trace.
10952         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
10953         wait status kind image by target_waitstatus_to_string.
10954         * target/waitstatus.c (target_waitstatus_to_string): Fix
10955         obsolete comment.
10956
10957 2019-04-01  Tom Tromey  <tromey@adacore.com>
10958
10959         PR symtab/23331:
10960         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
10961
10962 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
10963             Pedro Alves  <palves@redhat.com>
10964
10965         * top.c (quit_force): Call 'finalize_values'.
10966         * value.c (finalize_values): New function.
10967         * value.h (finalize_values): Declare.
10968
10969 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
10970
10971         * NEWS: Announce $_gdb_major and $_gdb_minor.
10972
10973         * top.c (init_gdb_version_vars): New function.
10974         (gdb_init): Call init_gdb_version_vars.
10975
10976 2019-03-29  Tom Tromey  <tromey@adacore.com>
10977
10978         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
10979         help text.  Remove dead code.
10980
10981 2019-03-29  Keith Seitz  <keiths@redhat.com>
10982
10983         From Siddhesh Poyarekar:
10984         * f-lang.h (f77_get_upperbound): Return LONGEST.
10985         (f77_get_lowerbound): Likewise.
10986         * f-typeprint.c (f_type_print_varspec_suffix): Expand
10987         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
10988         print them.
10989         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
10990         plongest to format print it.
10991         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
10992         (f77_get_upperbound): Likewise.
10993         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
10994         LOWER_BOUND to LONGEST.
10995         (f77_create_arrayprint_offset_tbl): Likewise.
10996
10997 2019-03-29  Keith Seitz  <keiths@redhat.com>
10998
10999         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
11000         %s/pulongest for TYPE_LENGTH instead of %d in format
11001         strings.
11002         * ada-typerint.c (ada_print_type): Likewise.
11003         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
11004         * compile/compile-c-support.c (generate_register_struct): Likewise.
11005         * gdbtypes.c (recursive_dump_type): Likewise.
11006         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
11007         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
11008         instead of %d in format strings.
11009         * riscv-tdep.c (riscv_type_alignment): Cast second argument
11010         to std::min to ULONGEST.
11011         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
11012         instead of %d in format strings.
11013         * tracepoint.c (info_scope_command): Likewise.
11014         * typeprint.c (print_offset_data::update)
11015         (print_offset_data::finish): Likewise.
11016         * xtensa-tdep.c (xtensa_store_return_value)
11017         (xtensa_push_dummy_call): Likewise.
11018
11019 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
11020
11021         * windows-nat.c (display_selector): Fixed format specifications
11022         for 64-bit Cygwin.
11023
11024 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11025
11026         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
11027
11028 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
11029
11030         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
11031         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
11032         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
11033         (nios2_linux_init_abi): Install it.
11034
11035 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
11036
11037         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
11038
11039 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
11040
11041         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
11042
11043 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11044             Tom Tromey  <tromey@adacore.com>
11045
11046         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
11047
11048 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
11049
11050         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
11051         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
11052         method to compute the bounds of range types. Also print "[evaluated]"
11053         if the bounds' values come from a dynamic evaluation.
11054
11055 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
11056
11057         * cp-valprint.c (cp_print_value_fields): Don't print trailing
11058         whitespace when pretty printing is on.
11059
11060 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
11061
11062         * ppc-linux-nat.c: Add include.
11063
11064 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
11065
11066         * NEWS: Mention AArch64 Pointer Authentication.
11067
11068 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
11069
11070         * arm-linux-nat.c: Add include.
11071
11072 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
11073
11074         * source-cache.c (source_cache::get_source_lines): Re-read
11075         fullname after calling open_source_file.
11076
11077 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
11078
11079         * NEWS: Mention TLS support for FreeBSD.
11080
11081 2019-03-25  Tom Tromey  <tromey@adacore.com>
11082
11083         * minsyms.c (BUNCH_SIZE): Update comment.
11084         (~minimal_symbol_reader): Remove old comment.
11085         (compact_minimal_symbols): Update comment.
11086         (minimal_symbol_reader::install): Remove old comment.  Update
11087         other comments.
11088
11089 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
11090
11091         * s390-linux-nat.c: Add include.
11092
11093 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
11094
11095         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
11096         Call linux_get_hwcap.
11097         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
11098         Likewise.
11099         (aarch64_linux_get_hwcap): Remove function.
11100         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
11101         declaration.
11102         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
11103         linux_get_hwcap.
11104         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
11105         * linux-tdep.c (linux_get_hwcap): Add function.
11106         (linux_get_hwcap2): Likewise.
11107         * linux-tdep.h (linux_get_hwcap): Add declaration.
11108         (linux_get_hwcap2): Likewise.
11109         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
11110         (ppc_linux_get_hwcap2): Likewise.
11111         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
11112         linux_get_hwcap.
11113         (ppc_linux_nat_target::insert_watchpoint): Likewise.
11114         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
11115         (ppc_linux_nat_target::read_description): Likewise.
11116         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
11117         * s390-linux-nat.c: Likewise.
11118         * s390-linux-tdep.c (s390_core_read_description): Likewise.
11119
11120 2019-03-24  Tom Tromey  <tom@tromey.com>
11121
11122         * ada-lang.c (standard_lookup): Simplify initialization.
11123         (ada_lookup_symbol_nonlocal): Simplify return.
11124         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
11125         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
11126         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
11127         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
11128         initialization.
11129         * solib.c (solib_global_lookup): Simplify.
11130         * symtab.c (null_block_symbol): Remove.
11131         (symbol_cache_lookup): Simplify returns.
11132         (lookup_language_this): Simplify returns.
11133         (lookup_symbol_aux): Simplify return.
11134         (lookup_local_symbol): Simplify returns.
11135         (lookup_global_symbol_from_objfile): Simplify return.
11136         (lookup_symbol_in_objfile_symtabs)
11137         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
11138         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
11139         (lookup_static_symbol, lookup_global_symbol): Simplify return.
11140         * cp-namespace.c (cp_lookup_bare_symbol)
11141         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
11142         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
11143         (cp_lookup_nested_symbol): Don't use null_block_symbol.
11144         (cp_lookup_symbol_via_imports): Simplify initialization.
11145         (find_symbol_in_baseclass): Likewise.
11146         * symtab.h (null_block_symbol): Remove.
11147         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
11148         (d_lookup_nested_symbol, d_lookup_symbol_imports)
11149         (d_lookup_symbol_module): Likewise.
11150         (find_symbol_in_baseclass): Simplify initialization.
11151
11152 2019-03-24  Tom Tromey  <tom@tromey.com>
11153
11154         * expression.h: Don't include symtab.h.
11155         (struct block): Forward declare.
11156
11157 2019-03-24  Tom Tromey  <tom@tromey.com>
11158
11159         * c-exp.y (typebase): Remove casts.
11160         * gdbtypes.c (lookup_unsigned_typename, )
11161         (lookup_signed_typename): Remove cast.
11162         * eval.c (parse_to_comma_and_eval): Remove cast.
11163         * parse.c (write_dollar_variable): Remove cast.
11164         * block.h (struct block) <superblock>: Now const.
11165         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
11166         * psymtab.c (psym_map_matching_symbols): Make "block" const.
11167         (map_block): Make "block" const.
11168         * symfile.h (struct quick_symbol_functions)
11169         <map_matching_symbols>: Constify block argument to "callback".
11170         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
11171         const.
11172         (find_pc_sect_compunit_symtab): Make "b" const.
11173         (find_symbol_at_address): Likewise.
11174         (search_symbols): Likewise.
11175         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
11176         (dw2_debug_names_lookup_symbol): Likewise.
11177         (dw2_map_matching_symbols): Update.
11178         * p-valprint.c (pascal_val_print): Remove "block".
11179         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
11180         (aux_add_nonlocal_symbols): Make "block" const.
11181         (resolve_subexp): Remove cast.
11182         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
11183         const.
11184         (iterate_over_file_blocks): Likewise.
11185         * f-exp.y (%union) <bval>: Remove.
11186         * coffread.c (patch_opaque_types): Make "b" const.
11187         * spu-tdep.c (spu_catch_start): Make "block" const.
11188         * c-valprint.c (print_unpacked_pointer): Remove "block".
11189         * symmisc.c (dump_symtab_1): Make "b" const.
11190         (block_depth): Make "block" const.
11191         * d-exp.y (%union) <bval>: Remove.
11192         * cp-support.h (cp_lookup_rtti_type): Update.
11193         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
11194         * psymtab.c (psym_lookup_symbol): Make "block" const.
11195         (maintenance_check_psymtabs): Make "b" const.
11196         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
11197         (enumerate_locals, enumerate_args): Update.
11198         * python/py-symtab.c (stpy_global_block): Make "block" const.
11199         (stpy_static_block): Likewise.
11200         * inline-frame.c (block_starting_point_at): Make "new_block"
11201         const.
11202         * block.c (find_block_in_blockvector): Make return type const.
11203         (blockvector_for_pc_sect): Make "b" const.
11204         (find_block_in_blockvector): Make "b" const.
11205
11206 2019-03-23  Tom Tromey  <tom@tromey.com>
11207
11208         * varobj.c (varobj_create): Update.
11209         * symfile.c (clear_symtab_users): Don't reset innermost_block.
11210         * printcmd.c (display_command, do_one_display): Don't reset
11211         innermost_block.
11212         * parser-defs.h (enum innermost_block_tracker_type): Move to
11213         expression.h.
11214         (innermost_block): Update comment.
11215         * parse.c (parse_exp_1): Add tracker_types parameter.
11216         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
11217         tracker_types parameter.  Reset innermost_block.
11218         (parse_exp_in_context): Remove.
11219         (parse_expression_for_completion): Update.
11220         * objfiles.c (~objfile): Don't reset expression_context_block or
11221         innermost_block.
11222         * expression.h (enum innermost_block_tracker_type): Move from
11223         parser-defs.h.
11224         (parse_exp_1): Add tracker_types parameter.
11225         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
11226         reset innermost_block.
11227
11228 2019-03-23  Tom Tromey  <tom@tromey.com>
11229
11230         * objfiles.h: Include bcache.h.
11231
11232 2019-03-23  Tom Tromey  <tom@tromey.com>
11233
11234         * linespec.c (get_current_search_block): Use
11235         scoped_restore_current_language.
11236         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
11237
11238 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
11239             Jiong Wang  <jiong.wang@arm.com>
11240
11241         * aarch64-linux-tdep.c
11242         (aarch64_linux_iterate_over_regset_sections): Check for pauth
11243         section.
11244         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
11245
11246 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
11247             Jiong Wang  <jiong.wang@arm.com>
11248
11249         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
11250         instructions.
11251         (aarch64_analyze_prologue_test): Add PACIASP test.
11252         (aarch64_prologue_prev_register): Unmask PC value.
11253
11254 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
11255             Jiong Wang  <jiong.wang@arm.com>
11256
11257         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
11258         (aarch64_dwarf2_prev_register): Unmask PC value.
11259         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
11260         (aarch64_execute_dwarf_cfa_vendor_op): Check for
11261         DW_CFA_AARCH64_negate_ra_state.
11262         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
11263
11264 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
11265             Jiong Wang  <jiong.wang@arm.com>
11266
11267         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
11268         registers.
11269         (aarch64_pseudo_register_name): Likewise.
11270         (aarch64_pseudo_register_type): Likewise.
11271         (aarch64_pseudo_register_reggroup_p): Likewise.
11272         (aarch64_gdbarch_init): Add pauth registers.
11273         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
11274         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
11275         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
11276         (struct gdbarch_tdep): Add regnum for ra_state.
11277
11278 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
11279             Jiong Wang  <jiong.wang@arm.com>
11280
11281         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
11282
11283 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
11284             Jiong Wang  <jiong.wang@arm.com>
11285
11286         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
11287         function.
11288         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
11289         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
11290         (aarch64_gdbarch_init): Add puth registers.
11291         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
11292         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
11293         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
11294
11295 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
11296             Jiong Wang  <jiong.wang@arm.com>
11297
11298         * aarch64-linux-nat.c
11299         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
11300         * aarch64-linux-tdep.c
11301         (aarch64_linux_core_read_description): Likewise.
11302         (aarch64_linux_get_hwcap): New function.
11303         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
11304         (aarch64_linux_get_hwcap): New declaration.
11305
11306 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
11307             Jiong Wang  <jiong.wang@arm.com>
11308
11309         * aarch64-linux-nat.c
11310         (aarch64_linux_nat_target::read_description): Add pauth param.
11311         * aarch64-linux-tdep.c
11312         (aarch64_linux_core_read_description): Likewise.
11313         * aarch64-tdep.c (struct target_desc): Add in pauth.
11314         (aarch64_read_description): Add pauth param.
11315         (aarch64_gdbarch_init): Likewise.
11316         * aarch64-tdep.h (aarch64_read_description): Likewise.
11317         * arch/aarch64.c (aarch64_create_target_description): Likewise.
11318         * arch/aarch64.h (aarch64_create_target_description): Likewise.
11319         * features/Makefile: Add new files.
11320         * features/aarch64-pauth.c: New file.
11321         * features/aarch64-pauth.xml: New file.
11322
11323 2019-03-20  Tom Tromey  <tromey@adacore.com>
11324
11325         * infrun.c (handle_inferior_event): Rename from
11326         handle_inferior_event_1.  Create a scoped_value_mark.
11327         (handle_inferior_event): Remove.
11328
11329 2019-03-19  Tom Tromey  <tromey@adacore.com>
11330
11331         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
11332         * infrun.h (print_stop_event): Add "displays" parameter.
11333         * infrun.c (print_stop_event): Add "displays" parameter.
11334
11335 2019-03-19  Pedro Alves  <palves@redhat.com>
11336
11337         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
11338         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
11339         to -1.  Fix TABs vs spaces.
11340         (tui_ui_out::tui_ui_out): Don't initialize fields here.
11341         * tui/tui-out.h (tui_ui_out) Add intro comments.
11342         <m_line, m_start_of_line>: In-class initialize, and add describing
11343         comment.
11344
11345 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
11346
11347         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
11348         variable names.
11349         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
11350
11351 2019-03-18  Pedro Alves  <palves@redhat.com>
11352             Eli Zaretskii <eliz@gnu.org>
11353
11354         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
11355         m_line and m_start_of_line.
11356
11357 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
11358
11359         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
11360         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
11361         it returns a newline.  This fixes a regression in TU mode, whereby
11362         the next line is output on the same screen line as the user input.
11363
11364 2019-03-18  Tom Tromey  <tromey@adacore.com>
11365
11366         * minsyms.c (minimal_symbol_reader::install): Remove call to
11367         obstack_blank.
11368
11369 2019-03-18  Pedro Alves  <palves@redhat.com>
11370
11371         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
11372         New globals.
11373         (apply_style): New, factored out from ...
11374         (apply_ansi_escape): ... this.  Handle reverse video mode.
11375         (tui_set_reverse_mode): New function.
11376         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
11377         * tui/tui-winsource.c (tui_show_source_line): Use
11378         tui_set_reverse_mode instead of setting A_STANDOUT.
11379         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
11380         New setter methods.
11381
11382 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
11383
11384         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
11385         Handle tabs.
11386
11387 2019-03-18  Tom Tromey  <tromey@adacore.com>
11388
11389         * ada-lang.c (empty_array): Add "high" parameter.
11390         (ada_evaluate_subexp): Update.
11391
11392 2019-03-17  Sergei Trofimovich <siarheit@google.com>
11393
11394         * unittests/string_view-selftests.c: Define
11395         _initialize_string_view_selftests unconditionally.
11396
11397 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
11398
11399         PR gdb/24350
11400         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
11401
11402 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
11403
11404         PR gdb/24351
11405         * windows-nat.c (display_selector): Fix format specifiers.
11406
11407 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
11408
11409         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
11410         tui_refill_source_window instead of tui_refresh_win, to update the
11411         current execution line.  This fixes redisplay of the current line
11412         when stepping through the code with "next" or "step".
11413
11414 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
11415
11416         * source-cache.c (source_cache::get_source_lines): Call
11417         find_source_lines to initialize s->nlines.  This fixes vertical
11418         scrolling of TUI source window when the DOWN arrow is pressed.
11419
11420 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11421
11422         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
11423         linux-thread-db.c (_initialize_thread_db): Likewise.
11424
11425 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
11426
11427         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
11428         wclrtoeol in tui_show_source_line".  This reverts changes made in
11429         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
11430
11431 2019-03-15  Tom Tromey  <tom@tromey.com>
11432
11433         * symtab.h (struct minimal_symbol): Derive from
11434         general_symbol_info.
11435         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
11436         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
11437         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
11438         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
11439         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
11440         (MSYMBOL_SEARCH_NAME): Update.
11441         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
11442         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
11443         * minsyms.c (minimal_symbol_reader::record_full): Update.
11444
11445 2019-03-15  Tom Tromey  <tom@tromey.com>
11446
11447         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
11448
11449 2019-03-15  Tom Tromey  <tom@tromey.com>
11450
11451         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
11452         unique_xmalloc_ptr.
11453         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
11454         Update.
11455         * minsyms.c (lookup_minimal_symbol_by_pc_section)
11456         (build_minimal_symbol_hash_tables)
11457         (minimal_symbol_reader::install): Update.
11458
11459 2019-03-15  Tom Tromey  <tom@tromey.com>
11460
11461         * symtab.c (create_demangled_names_hash): Update.
11462         (symbol_set_names): Update.
11463         * objfiles.h (struct objfile_per_bfd_storage)
11464         <demangled_names_hash>: Now an htab_up.
11465         * objfiles.c (objfile_per_bfd_storage): Simplify.
11466
11467 2019-03-15  Tom Tromey  <tom@tromey.com>
11468
11469         * objfiles.h (struct objfile_per_bfd_storage): Declare
11470         destructor.
11471         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
11472         New.
11473         (get_objfile_bfd_data): Use new.  Don't initialize
11474         language_of_main.
11475         (free_objfile_per_bfd_storage): Remove.
11476         (objfile_bfd_data_free, objfile::~objfile): Use delete.
11477
11478 2019-03-15  Tom Tromey  <tom@tromey.com>
11479
11480         * symfile.c (reread_symbols): Update.
11481         * objfiles.c (objfile::objfile): Update.
11482         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
11483         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
11484         comment.
11485         (minimal_symbol_reader::install): Update.
11486         (terminate_minimal_symbol_table): Remove.
11487         * jit.c (jit_object_close_impl): Update.
11488
11489 2019-03-15  Tom Tromey  <tom@tromey.com>
11490
11491         * minsyms.c (minimal_symbol_reader::record_full): Remove some
11492         initializations.
11493
11494 2019-03-15  Tom Tromey  <tom@tromey.com>
11495
11496         * objfiles.h (struct objfile_per_bfd_storage)
11497         <demangled_hash_languages>: Now a bitset.
11498         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
11499         (lookup_minimal_symbol): Update.
11500
11501 2019-03-15  Tom Tromey  <tom@tromey.com>
11502
11503         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
11504         Don't return the symbol.
11505         * coffread.c (record_minimal_symbol): Use record_full.
11506
11507 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
11508
11509         The MS-Windows port of ncurses fails to switch to a color pair if
11510         one or both of the colors are the implicit default colors.  This
11511         change records the default colors when TUI is initialized, and
11512         then specifies them explicitly when a color pair uses the default
11513         colors.  This allows color styling in TUI mode on MS-Windows.
11514
11515         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
11516         ncurses_norm_attr.
11517         (tui_initialize_io) [__MINGW32__]: Record the default terminal
11518         colors in ncurses_norm_attr.
11519         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
11520         "none", replace it with the default color recorded in
11521         ncurses_norm_attr.
11522
11523 2019-03-14  Tom Tromey  <tromey@adacore.com>
11524
11525         * source-cache.h (class source_cache) <get_source_lines>: Return
11526         std::string.
11527         * source-cache.c (source_cache::extract_lines): Handle case where
11528         first_pos==npos.  Return std::string.
11529         (source_cache::get_source_lines): Update.
11530
11531 2019-03-14  Tom Tromey  <tromey@adacore.com>
11532
11533         * NEWS: Add item for "style sources" commands.
11534         * source-cache.c (source_cache::get_source_lines): Check
11535         source_styling.
11536         * cli/cli-style.c (source_styling): New global.
11537         (_initialize_cli_style): Add "style sources" commands.
11538         (show_style_sources): New function.
11539         * cli/cli-style.h (source_styling): Declare.
11540
11541 2019-03-14  Pedro Alves  <palves@redhat.com>
11542             Tom Tromey  <tromey@adacore.com>
11543
11544         * tui/tui-winsource.h (tui_refill_source_window): Declare.
11545         * tui/tui-winsource.c (tui_refill_source_window): New function,
11546         from...
11547         (tui_horizontal_source_scroll): ... here.  Move some logic.
11548         * cli/cli-style.c (set_style_enabled): Notify new observable.
11549         * tui/tui-hooks.c (tui_redisplay_source): New function.
11550         (tui_attach_detach_observers): Attach or detach
11551         tui_redisplay_source.
11552         * observable.h (source_styling_changed): New observable.
11553         * observable.c: Define source_styling_changed observable.
11554
11555 2019-03-13  Tom Tromey  <tromey@adacore.com>
11556
11557         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
11558         (i386_gnu_nat_target::store_registers): Update.
11559         * target-debug.h (target_debug_print_std_string): New macro.
11560         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
11561         * windows-tdep.c (display_one_tib): Update.
11562         * tui/tui-stack.c (tui_make_status_line): Update.
11563         * top.c (print_inferior_quit_action): Update.
11564         * thread.c (thr_try_catch_cmd): Update.
11565         (add_thread_with_info): Update.
11566         (thread_target_id_str): Update.
11567         (thr_try_catch_cmd): Update.
11568         (thread_command): Update.
11569         (thread_find_command): Update.
11570         * record-btrace.c (record_btrace_target::info_record)
11571         (record_btrace_resume_thread, record_btrace_target::resume)
11572         (record_btrace_cancel_resume, record_btrace_step_thread)
11573         (record_btrace_target::wait, record_btrace_target::wait)
11574         (record_btrace_target::wait, record_btrace_target::stop): Update.
11575         * progspace.c (print_program_space): Update.
11576         * process-stratum-target.c
11577         (process_stratum_target::thread_address_space): Update.
11578         * linux-fork.c (linux_fork_mourn_inferior)
11579         (detach_checkpoint_command, info_checkpoints_command)
11580         (linux_fork_context): Update.
11581         (linux_fork_detach): Update.
11582         (class scoped_switch_fork_info): Update.
11583         (delete_checkpoint_command): Update.
11584         * infrun.c (follow_fork_inferior): Update.
11585         (follow_fork_inferior): Update.
11586         (proceed_after_vfork_done): Update.
11587         (handle_vfork_child_exec_or_exit): Update.
11588         (follow_exec): Update.
11589         (displaced_step_prepare_throw): Update.
11590         (displaced_step_restore): Update.
11591         (start_step_over): Update.
11592         (resume_1): Update.
11593         (clear_proceed_status_thread): Update.
11594         (proceed): Update.
11595         (print_target_wait_results): Update.
11596         (do_target_wait): Update.
11597         (context_switch): Update.
11598         (stop_all_threads): Update.
11599         (restart_threads): Update.
11600         (finish_step_over): Update.
11601         (handle_signal_stop): Update.
11602         (switch_back_to_stepped_thread): Update.
11603         (keep_going_pass_signal): Update.
11604         (print_exited_reason): Update.
11605         (normal_stop): Update.
11606         * inferior.c (inferior_pid_to_str): Change return type.
11607         (print_selected_inferior): Update.
11608         (add_inferior): Update.
11609         (detach_inferior): Update.
11610         * dummy-frame.c (fprint_dummy_frames): Update.
11611         * dcache.c (dcache_info_1): Update.
11612         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
11613         (btrace_fetch, btrace_clear): Update.
11614         * linux-tdep.c (linux_core_pid_to_str): Change return type.
11615         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
11616         type.
11617         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
11618         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
11619         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
11620         * gdbarch.c, gdbarch.h: Rebuild.
11621         * gdbarch.sh (core_pid_to_str): Change return type.
11622         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
11623         return type.
11624         (windows_nat_target::pid_to_str): Change return type.
11625         (windows_delete_thread): Update.
11626         (windows_nat_target::attach): Update.
11627         (windows_nat_target::files_info): Update.
11628         * target-delegates.c: Rebuild.
11629         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
11630         return type.
11631         (sol_thread_target::pid_to_str): Change return type.
11632         * remote.c (class remote_target) <pid_to_str>: Change return
11633         type.
11634         (remote_target::pid_to_str): Change return type.
11635         (extended_remote_target::attach, remote_target::remote_stop_ns)
11636         (remote_target::remote_notif_remove_queued_reply)
11637         (remote_target::push_stop_reply, remote_target::disable_btrace):
11638         Update.
11639         (extended_remote_target::attach): Update.
11640         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
11641         type.
11642         (gdbsim_target::pid_to_str): Change return type.
11643         * ravenscar-thread.c (struct ravenscar_thread_target)
11644         <pid_to_str>: Change return type.
11645         (ravenscar_thread_target::pid_to_str): Change return type.
11646         * procfs.c (class procfs_target) <pid_to_str>: Change return
11647         type.
11648         (procfs_target::pid_to_str): Change return type.
11649         (procfs_target::attach): Update.
11650         (procfs_target::detach): Update.
11651         (procfs_target::fetch_registers): Update.
11652         (procfs_target::store_registers): Update.
11653         (procfs_target::wait): Update.
11654         (procfs_target::files_info): Update.
11655         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
11656         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
11657         return type.
11658         (nto_procfs_target::pid_to_str): Change return type.
11659         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
11660         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
11661         return type.
11662         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
11663         (exit_lwp): Update.
11664         (attach_proc_task_lwp_callback, get_detach_signal)
11665         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
11666         (linux_nat_target::resume, wait_lwp, stop_callback)
11667         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
11668         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
11669         (linux_nat_wait_1, resume_stopped_resumed_lwps)
11670         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
11671         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
11672         type.
11673         (inf_ptrace_target::attach): Update.
11674         (inf_ptrace_target::files_info): Update.
11675         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
11676         type.
11677         (go32_nat_target::pid_to_str): Change return type.
11678         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
11679         (gnu_nat_target::wait): Update.
11680         (gnu_nat_target::wait): Update.
11681         (gnu_nat_target::resume): Update.
11682         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
11683         (fbsd_nat_target::wait): Update.
11684         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
11685         type.
11686         (darwin_nat_target::attach): Update.
11687         * corelow.c (class core_target) <pid_to_str>: Change return type.
11688         (core_target::pid_to_str): Change return type.
11689         * target.c (normal_pid_to_str): Change return type.
11690         (default_pid_to_str): Likewise.
11691         (target_pid_to_str): Change return type.
11692         (target_translate_tls_address): Update.
11693         (target_announce_detach): Update.
11694         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
11695         return type.
11696         (bsd_uthread_target::pid_to_str): Change return type.
11697         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
11698         type.
11699         (bsd_kvm_target::pid_to_str): Change return type.
11700         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
11701         return type.
11702         (aix_thread_target::pid_to_str): Change return type.
11703         * target.h (struct target_ops) <pid_to_str>: Change return type.
11704         (target_pid_to_str, normal_pid_to_str): Likewise.
11705         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
11706         type.
11707         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
11708         type.
11709         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
11710         return type.
11711         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
11712         type.
11713         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
11714         type.
11715         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
11716         return type.
11717
11718 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
11719
11720         * NEWS: Mention that the new default MI version is 3.  Mention
11721         changes to the output of commands and events that deal with
11722         multi-location breakpoints.
11723         * breakpoint.c: Include "mi/mi-out.h".
11724         (print_one_breakpoint): Change output syntax if using MI version
11725         >= 3.
11726         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
11727         New.
11728         (mi_multi_location_breakpoint_output_fixed): New.
11729         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
11730         (mi_cmd_fix_multi_location_breakpoint_output): New.
11731         (mi_multi_location_breakpoint_output_fixed): New.
11732         * mi/mi-cmds.c (mi_cmds): Register command
11733         -fix-multi-location-breakpoint-output.
11734         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
11735         interpreter "mi".
11736
11737 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
11738
11739         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
11740         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
11741         instantiate mi_ui_out based on interpreter name.
11742         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
11743         * mi/mi-main.c (mi_load_progress): Likewise.
11744
11745 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11746
11747         * NEWS: Combine separate "New targets" sections for 8.3.
11748
11749 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11750
11751         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
11752         (ppcfbsd_init_abi): Install gdbarch
11753         "fetch_tls_load_module_address" and "get_thread_local_address"
11754         methods.
11755
11756 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11757
11758         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
11759         (riscv_fbsd_init_abi): Install gdbarch
11760         "fetch_tls_load_module_address" and "get_thread_local_address"
11761         methods.
11762
11763 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11764
11765         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
11766         (i386fbsd_init_abi): Install gdbarch
11767         "fetch_tls_load_module_address" and "get_thread_local_address"
11768         methods.
11769
11770 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11771
11772         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
11773         (amd64fbsd_init_abi): Install gdbarch
11774         "fetch_tls_load_module_address" and "get_thread_local_address"
11775         methods.
11776
11777 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11778
11779         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
11780         (struct fbsd_pspace_data): New type.
11781         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
11782         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
11783         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
11784         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
11785         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
11786
11787 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11788
11789         * gdbtypes.c (lookup_struct_elt): New function.
11790         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
11791         * gdbtypes.h (struct struct_elt): New type.
11792         (lookup_struct_elt): New prototype.
11793
11794 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11795
11796         * gdbtypes.c (lookup_struct_elt_type): Update comment and
11797         remove disabled code block.
11798
11799 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11800
11801         * gdbarch.sh (get_thread_local_address): New method.
11802         * gdbarch.h, gdbarch.c: Regenerate.
11803         * target.c (target_translate_tls_address): Use
11804         gdbarch_get_thread_local_address if present instead of
11805         target::get_thread_local_address.
11806
11807 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11808
11809         * target.h (target::get_thread_local_address): Update comment.
11810
11811 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11812
11813         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
11814         objfile->separate_debug_objfile_backlink if not NULL.
11815
11816 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11817
11818         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
11819         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
11820         (amd64bsd_store_inferior_registers): Likewise.
11821         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
11822         Enable segment base registers.
11823         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
11824         PT_GETFSBASE and PT_GETGSBASE.
11825         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
11826         PT_SETGSBASE.
11827         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
11828         segment base registers.
11829         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
11830
11831 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11832
11833         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
11834         Update calls to i386_target_description to add 'segments'
11835         parameter.
11836         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
11837         add segment base registers.
11838         * arch/i386.c (i386_create_target_description): Add 'segments'
11839         parameter to enable segment base registers.
11840         * arch/i386.h (i386_create_target_description): Likewise.
11841         * features/i386/32bit-segments.xml: New file.
11842         * features/i386/32bit-segments.c: Generate.
11843         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
11844         call to i386_target_description to add 'segments' parameter.
11845         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
11846         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
11847         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
11848         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
11849         if feature is present.
11850         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
11851         Add 'segments' parameter to call to i386_target_description.
11852         (i386_target_description): Add 'segments' parameter to enable
11853         segment base registers.
11854         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
11855         to call to i386_target_description.
11856         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
11857         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
11858         Define I386_NUM_REGS.
11859         (i386_target_description): Add 'segments' parameter to enable
11860         segment base registers.
11861
11862 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
11863
11864         PR/24325
11865         * source-cache.c: #undef open and close, to avoid unresolved
11866         externals during linking.
11867
11868 2019-03-12  Tom Tromey  <tromey@adacore.com>
11869
11870         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
11871         const.  Add initializers.
11872         (_initialize_remote): Don't initialize ptid globals.
11873
11874 2019-03-12  Pedro Alves  <palves@redhat.com>
11875
11876         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
11877
11878 2019-03-12  Pedro Alves  <palves@redhat.com>
11879
11880         * cp-name-parser.y (main): Remove unused 'len' variable.
11881
11882 2019-03-12  Tom Tromey  <tromey@adacore.com>
11883
11884         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
11885         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
11886
11887 2019-03-12  Tom Tromey  <tromey@adacore.com>
11888
11889         * linux-nat.c (iterate_over_lwps): Update.
11890         (stop_callback): Remove parameter.
11891         (stop_wait_callback, detach_callback, resume_set_callback)
11892         (select_singlestep_lwp_callback, set_ignore_sigint)
11893         (status_callback, resumed_callback, resume_clear_callback)
11894         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
11895         data parameter.
11896         (linux_nat_target::detach, linux_nat_target::resume)
11897         (linux_stop_and_wait_all_lwps, select_event_lwp)
11898         (linux_nat_filter_event, linux_nat_wait_1)
11899         (linux_nat_target::kill, linux_nat_target::stop)
11900         (linux_nat_target::stop): Update.
11901         (linux_nat_resume_callback): Change type.
11902         (resume_stopped_resumed_lwps, count_events_callback)
11903         (select_event_lwp_callback): Likewise.
11904         (linux_stop_lwp, linux_nat_stop_lwp): Update.
11905         * arm-linux-nat.c (struct update_registers_data): Remove.
11906         (update_registers_callback): Change type.
11907         (arm_linux_insert_hw_breakpoint1): Update.
11908         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
11909         parameter.
11910         (x86_linux_dr_set_addr): Update.
11911         (x86_linux_dr_set_control): Update.
11912         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
11913         (iterate_over_lwps): Use gdb::function_view.
11914         * nat/aarch64-linux-hw-point.c (struct
11915         aarch64_dr_update_callback_param): Remove.
11916         (debug_reg_change_callback): Change type.
11917         (aarch64_notify_debug_reg_change): Update.
11918         * s390-linux-nat.c (s390_refresh_per_info): Update.
11919
11920 2019-03-11  Tom Tromey  <tromey@adacore.com>
11921
11922         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
11923         redundant assignment to "this_cu".
11924
11925 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11926
11927         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
11928
11929 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11930
11931         * gdbtypes.c (rank_one_type_parm_set): New function extracted
11932         from...
11933         (rank_one_type): ... this.
11934
11935 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11936
11937         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
11938         from...
11939         (rank_one_type): ... this.
11940
11941 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11942
11943         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
11944         from...
11945         (rank_one_type): ... this.
11946
11947 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11948
11949         * gdbtypes.c (rank_one_type_parm_float): New function extracted
11950         from...
11951         (rank_one_type): ... this.
11952
11953 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11954
11955         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
11956         from...
11957         (rank_one_type): ... this.
11958
11959 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11960
11961         * gdbtypes.c (rank_one_type_parm_range): New function extracted
11962         from...
11963         (rank_one_type): ... this.
11964
11965 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11966
11967         * gdbtypes.c (rank_one_type_parm_char): New function extracted
11968         from...
11969         (rank_one_type): ... this.
11970
11971 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11972
11973         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
11974         from...
11975         (rank_one_type): ... this.
11976
11977 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11978
11979         * gdbtypes.c (rank_one_type_parm_int): New function extracted
11980         from...
11981         (rank_one_type): ... this.
11982
11983 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11984
11985         * gdbtypes.c (rank_one_type_parm_func): New function extracted
11986         from...
11987         (rank_one_type): ... this.
11988
11989 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11990
11991         * gdbtypes.c (rank_one_type_parm_array): New function extracted
11992         from...
11993         (rank_one_type): ... this.
11994
11995 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11996
11997         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
11998         from...
11999         (rank_one_type): ... this.
12000
12001 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12002
12003         * inferior.c (initialize_inferiors): Ensure 'help set/show print
12004         inferior-events' shows the example events.
12005
12006 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
12007
12008         Support styling on native MS-Windows console
12009
12010         PR/24315
12011         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
12012         on MS-Windows if $TERM is not defined.
12013
12014         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
12015
12016         * posix-hdep.c (gdb_console_fputs):
12017         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
12018         functions.
12019         * ui-file.h (gdb_console_fputs): Add prototype.
12020
12021         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
12022         back to fputs only if the former returns zero.
12023
12024 2019-03-07  Tom Tromey  <tom@tromey.com>
12025
12026         * symmisc.c (print_symbol_bcache_statistics): Update.
12027         (print_objfile_statistics): Update.
12028         * symfile.c (allocate_symtab): Update.
12029         * stabsread.c: Don't include bcache.h.
12030         * psymtab.h (struct psymbol_bcache): Don't declare.
12031         (class psymtab_storage) <psymbol_cache>: Now a bcache.
12032         (psymbol_bcache_init, psymbol_bcache_free)
12033         (psymbol_bcache_get_bcache): Don't declare.
12034         * psymtab.c (struct psymbol_bcache): Remove.
12035         (psymtab_storage::psymtab_storage): Update.
12036         (psymtab_storage::~psymtab_storage): Update.
12037         (psymbol_bcache_init, psymbol_bcache_free)
12038         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
12039         (add_psymbol_to_bcache): Update.
12040         (allocate_psymtab): Update.
12041         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
12042         macro_cache>: No longer pointers.
12043         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
12044         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
12045         * macrotab.c (macro_bcache): Update.
12046         * macroexp.c: Don't include bcache.h.
12047         * gdbtypes.c (check_types_worklist): Update.
12048         (types_deeply_equal): Remove TRY/CATCH.  Update.
12049         * elfread.c (elf_symtab_read): Update.
12050         * dwarf2read.c: Don't include bcache.h.
12051         * buildsym.c (buildsym_compunit::get_macro_table): Update.
12052         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
12053         (print_bcache_statistics, bcache_memory_used): Don't declare.
12054         (struct bcache): Move from bcache.c.  Add constructor, destructor,
12055         methods.  Rename all data members.
12056         * bcache.c (struct bcache): Move to bcache.h.
12057         (bcache::expand_hash_table): Rename from expand_hash_table.
12058         (bcache): Remove.
12059         (bcache::insert): Rename from bcache_full.
12060         (bcache::compare): Rename from bcache_compare.
12061         (bcache_xmalloc): Remove.
12062         (bcache::~bcache): Rename from bcache_xfree.
12063         (bcache::print_statistics): Rename from print_bcache_statistics.
12064         (bcache::memory_used): Rename from bcache_memory_used.
12065
12066 2019-03-07  Pedro Alves  <palves@redhat.com>
12067
12068         * infrun.c (normal_stop): Also check for
12069         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
12070
12071 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
12072
12073         * f-lang.c (value_from_host_double): Moved to...
12074         * value.c (value_from_host_double): ...here.
12075         * value.h (value_from_host_double): Declare.
12076         * guile/scm-math.c (vlscm_convert_typed_number): Use
12077         value_from_host_double.
12078         (vlscm_convert_number): Likewise.
12079         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
12080         * python/py-value.c (convert_value_from_python): Likewise.
12081
12082 2019-03-06  Tom Tromey  <tom@tromey.com>
12083
12084         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
12085
12086 2019-03-06  Tom Tromey  <tom@tromey.com>
12087
12088         * utils.h (free_current_contents): Don't declare.
12089         * utils.c (free_current_contents): Remove.
12090
12091 2019-03-06  Tom Tromey  <tom@tromey.com>
12092
12093         * top.c (quit_force): Update.
12094         * main.c (captured_command_loop): Update.
12095         * common/new-op.c (operator new): Update.
12096         * common/common-exceptions.c (struct catcher)
12097         <save_cleanup_chain>: Remove member.
12098         (exceptions_state_mc_init): Update.
12099         (exception_try_scope_entry): Return nullptr.
12100         (exception_try_scope_exit, exception_rethrow)
12101         (throw_exception_sjlj, throw_exception_cxx): Update.
12102         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
12103         (all_cleanups, do_cleanups, discard_cleanups)
12104         (discard_final_cleanups, save_cleanups, save_final_cleanups)
12105         (restore_cleanups, restore_final_cleanups): Don't declare.
12106         (do_final_cleanups): Remove parameter.
12107         * common/cleanups.c (cleanup_chain, make_cleanup)
12108         (make_cleanup_dtor, all_cleanups, do_cleanups)
12109         (discard_my_cleanups, discard_cleanups)
12110         (discard_final_cleanups, save_my_cleanups, save_cleanups)
12111         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
12112         (null_cleanup): Remove.
12113         (do_final_cleanups): Remove parameter.
12114
12115 2019-03-06  Tom Tromey  <tom@tromey.com>
12116
12117         * remote.c (remote_target::remote_parse_stop_reply): Use
12118         unique_xmalloc_ptr.
12119
12120 2019-03-06  Tom Tromey  <tom@tromey.com>
12121
12122         * stabsread.c (struct stabs_field_info): Rename from field_info.
12123         <list, fnlist>: Add initializers.
12124         <obstack>: New member.
12125         (read_member_functions, read_struct_fields, read_baseclasses):
12126         Allocate on obstack.  Don't use cleanups.
12127         (read_one_struct_field, read_member_functions, read_struct_fields)
12128         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
12129         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
12130         (read_struct_type): Update.
12131
12132 2019-03-06  Tom Tromey  <tom@tromey.com>
12133
12134         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
12135         * common/filestuff.h (make_cleanup_close): Don't declare.
12136         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
12137         Remove.
12138
12139 2019-03-06  Tom Tromey  <tom@tromey.com>
12140
12141         * solib-aix.c: Use make_scope_exit.
12142
12143 2019-03-06  Tom Tromey  <tom@tromey.com>
12144
12145         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
12146         Use make_scope_exit.
12147
12148 2019-03-06  Tom Tromey  <tom@tromey.com>
12149
12150         * solib-svr4.c (disable_probes_interface): Remove parameter.
12151         (svr4_handle_solib_event): Use make_scope_exit.
12152
12153 2019-03-06  Tom Tromey  <tom@tromey.com>
12154
12155         * remote.c (struct stop_reply_deleter): Remove.
12156         (stop_reply_up): Update.
12157         (struct stop_reply): Derive from notif_event.  Don't typedef.
12158         <regcache>: Now a std::vector.
12159         (stop_reply_xfree): Remove.
12160         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
12161         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
12162         (remote_target::discard_pending_stop_replies): Use delete.
12163         (remote_target::remote_parse_stop_reply): Update.
12164         (remote_target::process_stop_reply): Update.
12165         * remote-notif.h (struct notif_event): Add virtual destructor.
12166         Remove "dtr" member.
12167         (struct notif_client) <alloc_event>: Return a unique_ptr.
12168         (notif_event_xfree): Don't declare.
12169         (notif_event_up): New typedef.
12170         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
12171         (notif_event_xfree, do_notif_event_xfree): Remove.
12172         (remote_notif_state_xfree): Update.
12173
12174 2019-03-06  Tom Tromey  <tom@tromey.com>
12175
12176         * infrun.c (displaced_step_clear_cleanup): Now a
12177         forward_scope_exit type.
12178         (displaced_step_prepare_throw): Update.
12179         (displaced_step_fixup): Update.
12180
12181 2019-03-06  Tom Tromey  <tom@tromey.com>
12182
12183         * inferior.h (class inferior): Update comment.
12184         * gdbthread.h (class thread_info): Update comment.
12185
12186 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
12187             Tom Tromey  <tom@tromey.com>
12188
12189         * stabsread.h (struct stab_section_list): Remove.
12190         (coffstab_build_psymtabs): Update.
12191         * dbxread.c (symbuf_sections): Now a std::vector.
12192         (sect_idx): New global.
12193         (fill_symbuf): Update.
12194         (coffstab_build_psymtabs): Change type of stabsects parameter.
12195         Update.
12196         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
12197         std::vector.
12198         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
12199         (coff_locate_sections): Update.
12200         (coff_symfile_read): Remove cleanups.  Update.
12201         (init_stringtab): Add storage parameter.
12202         (free_stringtab, free_stringtab_cleanup): Remove.
12203         (init_lineno): Add storage parameter.
12204         (free_linetab, free_linetab_cleanup): Remove.
12205
12206 2019-03-06  Pedro Alves  <palves@redhat.com>
12207
12208         * linux-fork.c (fork_info::clobber_regs): Delete.
12209         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
12210         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
12211         comment.  Adjust.
12212         (scoped_switch_fork_info::scoped_switch_fork_info)
12213         (checkpoint_command, linux_fork_context): Adjust
12214         fork_save_infrun_state calls.
12215
12216 2019-03-06  Pedro Alves  <palves@redhat.com>
12217
12218         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
12219         (inf_has_multiple_threads): Return 'bool' and rewrite using
12220         inferior_info::threads().
12221
12222 2019-03-06  Pedro Alves  <palves@redhat.com>
12223
12224         * linux-fork.c: Include <list>.
12225         (fork_list): Now a std::list instance.
12226         (fork_info): Add ctor, dtor, and in-class initialize all fields.
12227         (forks_exist_p, find_last_fork): Adjust.
12228         (new_fork): Delete.
12229         (one_fork_p): New.
12230         (add_fork): Adjust.
12231         (free_fork): Delete, folded into fork_info::~fork_info().
12232         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
12233         Adjust.
12234         (init_fork_list): Delete.
12235         (linux_fork_killall, linux_fork_mourn_inferior)
12236         (linux_fork_detach, info_checkpoints_command): Adjust.
12237         (_initialize_linux_fork): No longer call init_fork_list.
12238
12239 2019-03-06  Pedro Alves  <palves@redhat.com>
12240
12241         * linux-fork.c (new_fork): New, split out of ...
12242         (add_fork): ... this.  Return void.  Move "first fork" special
12243         case from here, to ...
12244         (checkpoint_command): ... here.
12245         * linux-linux.h (add_fork): Return void.
12246
12247 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
12248
12249         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
12250
12251 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
12252             Chris January  <chris.january@arm.com>
12253             David Lecomber  <david.lecomber@arm.com>
12254
12255         * f-exp.y: New token, UNOP_INTRINSIC.
12256         (exp): New pattern using UNOP_INTRINSIC token.
12257         (f77_keywords): Add 'abs' keyword.
12258         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
12259         (value_from_host_double): New function.
12260         (evaluate_subexp_f): Support UNOP_ABS.
12261
12262 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
12263
12264         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
12265         types.
12266
12267 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
12268
12269         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
12270         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
12271         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
12272
12273 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
12274
12275         * f-exp.y (convert_to_kind_type): Handle more type kinds.
12276
12277 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
12278             Chris January  <chris.january@arm.com>
12279
12280         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
12281         * f-exp.y: Define 'KIND' token.
12282         (exp): New pattern for KIND expressions.
12283         (ptype): Handle types with a kind extension.
12284         (direct_abs_decl): Extend to spot kind extensions.
12285         (f77_keywords): Add 'kind' to the list.
12286         (push_kind_type): New function.
12287         (convert_to_kind_type): New function.
12288         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
12289         * parse.c (operator_length_standard): Likewise.
12290         * parser-defs.h (enum type_pieces): Add tp_kind.
12291         * std-operator.def: Add UNOP_KIND.
12292
12293 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
12294
12295         * f-exp.y (f_parse): Set yydebug.
12296
12297 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
12298
12299         * f-lang.c (evaluate_subexp_f): New function.
12300         (exp_descriptor_f): New global.
12301         (f_language_defn): Use exp_descriptor_f instead of
12302         exp_descriptor_standard.
12303
12304 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
12305
12306         * f-exp.y (struct token): Add comments.
12307         (dot_ops): Remove uppercase versions and the end marker.
12308         (f77_keywords): Likewise.
12309         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
12310         entries in the dot_ops array are case insensitive, and use
12311         strncasecmp to compare strings.  Also some whitespace cleanup in
12312         this area.  Similar for the f77_keywords array, except entries in
12313         this list might be case sensitive.
12314
12315 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
12316
12317         * f-exp.y (struct f77_boolean_val): Add comments.
12318         (boolean_values): Remove uppercase versions, and end marker.
12319         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
12320         and use strncasecmp to achieve case insensitivity.  Additionally,
12321         perform whitespace cleanup around this code.
12322
12323 2019-03-06  Tom Tromey  <tromey@adacore.com>
12324
12325         * remote-sim.c (gdbsim_target_open): Use result of
12326         gdb_argv::release.
12327
12328 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
12329         Dirk Schubert  <dirk.schubert@arm.com>
12330         Chris January  <chris.january@arm.com>
12331
12332         * eval.c (evaluate_subexp_standard): Call Fortran argument
12333         wrapping logic.
12334         * f-lang.c (struct value): A value which can be passed into a
12335         Fortran function call.
12336         (fortran_argument_convert): Wrap Fortran arguments in a pointer
12337         where appropriate.
12338         (struct type): Value ready for a Fortran function call.
12339         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
12340         is needed.
12341         * f-lang.h (fortran_argument_convert): Declaration.
12342         (fortran_preserve_arg_pointer): Declaration.
12343         * infcall.c (value_arg_coerce): Call Fortran argument logic.
12344
12345 2019-03-05  Tom Tromey  <tromey@adacore.com>
12346
12347         * python/py-prettyprint.c (print_string_repr): Remove #if.
12348         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
12349
12350 2019-03-05  Tom Tromey  <tromey@adacore.com>
12351
12352         * target.c (the_dummy_target): Move later.  Change type to
12353         "dummy_target".
12354         (initialize_targets): Don't initialize the_dummy_target.
12355
12356 2019-03-05  Tom Tromey  <tromey@adacore.com>
12357
12358         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
12359         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
12360
12361 2019-03-05  Tom Tromey  <tromey@adacore.com>
12362
12363         * windows-nat.c (windows_nat_target::attach)
12364         (windows_nat_target::detach): Don't call gdb_flush.
12365         * valprint.c (generic_val_print, val_print, val_print_string):
12366         Don't call gdb_flush.
12367         * utils.c (defaulted_query): Don't call gdb_flush.
12368         * typeprint.c (print_type_scalar): Don't call gdb_flush.
12369         * target.c (target_announce_detach): Don't call gdb_flush.
12370         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
12371         * remote.c (extended_remote_target::attach): Don't call
12372         gdb_flush.
12373         * procfs.c (procfs_target::detach): Don't call gdb_flush.
12374         * printcmd.c (do_examine): Don't call gdb_flush.
12375         (info_display_command): Don't call gdb_flush.
12376         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
12377         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
12378         * memattr.c (info_mem_command): Don't call gdb_flush.
12379         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
12380         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
12381         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
12382         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
12383         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
12384         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
12385         (gnu_nat_target::detach): Don't call gdb_flush.
12386         * f-valprint.c (f_val_print): Don't call gdb_flush.
12387         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
12388         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
12389         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
12390         gdb_flush.
12391         * c-valprint.c (c_val_print): Don't call gdb_flush.
12392         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
12393
12394 2019-03-05  Tom Tromey  <tromey@adacore.com>
12395
12396         * varobj.c (update_dynamic_varobj_children): Update.
12397         (install_default_visualizer): Use reset, not release.
12398         * value.c (set_internalvar): Update.
12399         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
12400         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
12401         ATTRIBUTE_UNUSED_RESULT.
12402
12403 2019-03-05  Tom Tromey  <tromey@adacore.com>
12404
12405         * remote.c (class scoped_remote_fd) <release>: Add
12406         ATTRIBUTE_UNUSED_RESULT.
12407
12408 2019-03-05  Tom Tromey  <tromey@adacore.com>
12409
12410         * macroexp.c (struct macro_buffer) <release>: Add
12411         ATTRIBUTE_UNUSED_RESULT.
12412
12413 2019-03-05  Tom Tromey  <tromey@adacore.com>
12414
12415         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
12416         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
12417         ATTRIBUTE_UNUSED_RESULT.
12418
12419 2019-03-05  Tom Tromey  <tromey@adacore.com>
12420
12421         * common/scoped_fd.h (class scoped_fd) <release>: Add
12422         ATTRIBUTE_UNUSED_RESULT.
12423
12424 2019-03-05  Tom Tromey  <tromey@adacore.com>
12425
12426         * parser-defs.h (struct parser_state) <release>: Add
12427         ATTRIBUTE_UNUSED_RESULT.
12428
12429 2019-03-05  Tom Tromey  <tromey@adacore.com>
12430
12431         * utils.h (class gdb_argv) <release>: Add
12432         ATTRIBUTE_UNUSED_RESULT.
12433         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
12434
12435 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
12436
12437         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
12438         for-loop range, to avoid compiler warnings.
12439
12440         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
12441         avoid compiler warnings about unused variables.
12442
12443         * NEWS: Mention end of support for native debugging on MS-Windows
12444         before XP.
12445
12446         PR gdb/24292
12447         * common/netstuff.c:
12448         * gdbserver/gdbreplay.c
12449         * gdbserver/remote-utils.c:
12450         * ser-tcp.c:
12451         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
12452         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
12453         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
12454         'getaddrinfo' and 'freeaddrinfo' were not available before
12455         Windows XP, and mingw.org's MinGW headers by default define
12456         _WIN32_WINNT to 0x500.
12457
12458 2019-03-01  Gary Benson <gbenson@redhat.com>
12459
12460         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
12461
12462 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
12463             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
12464
12465         PR gdb/8527
12466         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
12467         set_sigint_trap, clear_sigint_trap.
12468
12469 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12470
12471         * target.c (target_detach): Clear the regcache and the
12472         frame cache.
12473
12474 2019-02-27  Pedro Alves  <palves@redhat.com>
12475
12476         * utils.c (set_screen_size): When we cap the height/width sizes,
12477         tweak the corresponding command variable to show "unlimited":
12478
12479 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
12480             Pedro Alves  <palves@redhat.com>
12481
12482         * utils.c (set_screen_size): Reduce "infinite" rows and columns
12483         before calling rl_set_screen_size.
12484
12485 2019-02-27  Tom Tromey  <tromey@adacore.com>
12486
12487         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
12488         define.
12489         * python/py-value.c: Remove Python 2.4 workaround.
12490         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
12491         workaround.
12492         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
12493         Python 2.4 workaround.
12494         * python/python-internal.h: Remove Python 2.4 comment.
12495         (Py_ssize_t): Don't define.
12496         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
12497         (gdb_Py_DECREF): Remove Python 2.4 workaround.
12498         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
12499         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
12500         * python/python.c (do_start_initialization): Remove Python 2.4
12501         workaround.
12502         * python/py-prettyprint.c (class dummy_python_frame): Remove.
12503         (print_children): Remove Python 2.4 workaround.
12504         * python/py-inferior.c (buffer_procs): Remove Python 2.4
12505         workaround.
12506         (CHARBUFFERPROC_NAME): Remove.
12507         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
12508         Python 2.4 workaround.
12509
12510 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
12511
12512         * NEWS: Note minimum Python version.
12513
12514 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
12515
12516         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
12517         code from these functions.  Remove corresponding ifdefs.  Use
12518         Py_buffer_up instead of explicit calls to PyBuffer_Release.
12519         Remove gotos and target of gotos.
12520         (infpy_search_memory): Likewise.
12521
12522 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12523
12524         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
12525         (hppa_gdbarch_init): Don't register deleted functions with
12526         gdbarch.
12527
12528 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12529
12530         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
12531         (h8300_unwind_sp): Delete.
12532         (h8300_dummy_id): Delete.
12533         (h8300_gdbarch_init): Don't register deleted functions with
12534         gdbarch.
12535
12536 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12537
12538         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
12539         (ft32_unwind_pc): Delete.
12540         (ft32_unwind_sp): Delete.
12541         (ft32_gdbarch_init): Don't register deleted functions with
12542         gdbarch.
12543
12544 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12545
12546         * gdb/frv-tdep.c (frv_dummy_id): Delete.
12547         (frv_unwind_pc): Delete.
12548         (frv_unwind_sp): Delete.
12549         (frv_gdbarch_init): Don't register deleted functions with
12550         gdbarch.
12551
12552 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12553
12554         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
12555         (riscv_unwind_pc): Delete.
12556         (riscv_unwind_sp): Delete.
12557         (riscv_gdbarch_init): Don't register deleted functions with
12558         gdbarch.
12559
12560 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12561
12562         * gdb/csky-tdep.c (csky_dummy_id): Delete.
12563         (csky_unwind_pc): Delete.
12564         (csky_unwind_sp): Delete.
12565         (csky_gdbarch_init): Don't register deleted functions with
12566         gdbarch.
12567
12568 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12569
12570         * gdb/cris-tdep.c (cris_dummy_id): Delete.
12571         (cris_unwind_pc): Delete.
12572         (cris_unwind_sp): Delete.
12573         (cris_gdbarch_init): Don't register deleted functions with
12574         gdbarch.
12575
12576 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12577
12578         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
12579         (bfin_unwind_pc): Delete.
12580         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
12581
12582 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12583
12584         * gdb/arm-tdep.c (arm_dummy_id): Delete.
12585         (arm_unwind_pc): Delete.
12586         (arm_unwind_sp): Delete.
12587         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
12588
12589 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12590
12591         * gdb/arc-tdep.c (arc_dummy_id): Delete.
12592         (arc_unwind_pc): Delete.
12593         (arc_unwind_sp): Delete.
12594         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
12595
12596 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12597
12598         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
12599         (alpha_unwind_pc): Delete.
12600         (alpha_gdbarch_init): Don't register deleted functions with
12601         gdbarch.
12602
12603 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12604
12605         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
12606         (aarch64_unwind_pc): Delete.
12607         (aarch64_unwind_sp): Delete.
12608         (aarch64_gdbarch_init): Don't register deleted functions with
12609         gdbarch.
12610
12611 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12612
12613         * gdbtypes.c (type_align): Don't consider static members when
12614         computing structure alignment.
12615
12616 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12617
12618         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
12619         return 0 for other types.
12620         * arch-utils.c (default_type_align): Always return 0.
12621         * gdbarch.h: Regenerate.
12622         * gdbarch.sh (type_align): Extend comment.
12623         * gdbtypes.c (type_align): Add additional comments, always call
12624         gdbarch_type_align before applying the default rules.
12625         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
12626         generic code will then apply a suitable default.
12627         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
12628         types, return 0 for other types.
12629
12630 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
12631
12632         * NEWS: Create a new section for the next release branch.
12633         Rename the section of the current branch, now that it has
12634         been cut.
12635
12636 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
12637
12638         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
12639         * version.in: Bump version to 8.3.50.DATE-git.
12640
12641 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
12642
12643         * aix-thread.c (ptid_cmp): Remove unused variable.
12644         (get_signaled_thread): Likewise.
12645         (store_regs_user_thread): Likewise.
12646         (store_regs_kernel_thread): Likewise.
12647         (fetch_regs_kernel_thread): Remove shadowed variable.
12648
12649 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
12650
12651         * features/riscv/32bit-cpu.xml: Add register numbers.
12652         * features/riscv/32bit-fpu.c: Regenerate.
12653         * features/riscv/32bit-fpu.xml: Add register numbers.
12654         * features/riscv/64bit-cpu.xml: Add register numbers.
12655         * features/riscv/64bit-fpu.c: Regenerate.
12656         * features/riscv/64bit-fpu.xml: Add register numbers.
12657
12658 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
12659
12660         * NEWS: Mention two argument form of gdb.Value constructor.
12661         * python/py-value.c (convert_buffer_and_type_to_value): New
12662         function.
12663         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
12664         Add support for handling an optional second argument.  Call
12665         convert_buffer_and_type_to_value as appropriate.
12666         * python/python-internal.h (Py_buffer_deleter): New struct.
12667         (Py_buffer_up): New typedef.
12668
12669 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
12670
12671         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
12672         instead of releasing ownership.
12673
12674 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
12675
12676         * dwarf2read.c (open_and_init_dwp_file): Call
12677         elf_numsections instead of bfd_count_sections to initialize
12678         dwp_file->num_sections.
12679
12680 2019-02-25  Tom Tromey  <tromey@adacore.com>
12681
12682         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
12683
12684 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
12685
12686         * gcore.in: Add '--readnever' option when invoking GDB.
12687
12688 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
12689
12690         * MAINTAINERS: Update my email address.
12691
12692 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
12693
12694         * build-id.c (build_id_to_debug_bfd_1): New function.
12695         (build_id_to_debug_bfd): Look for separate debug file in
12696         sysroot.
12697
12698 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
12699
12700         * gdbarch.sh: Update the copyright year range that is placed into
12701         generated files.
12702
12703 2019-02-22  Keith Seitz  <keiths@redhat.com>
12704
12705         PR symtab/23853
12706         * linespec.c (create_sals_line_offset): Search for the default
12707         symtab's filename instead of its fullname.
12708
12709 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
12710
12711         * NEWS: Update style defaults.
12712
12713 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
12714
12715         * main.c (captured_main_1): Disable styling in batch mode.
12716
12717 2019-02-20  Tom Tromey  <tom@tromey.com>
12718
12719         * symtab.c (symtab_symbol_info): Fix typos.
12720
12721 2019-02-20  Tom Tromey  <tromey@adacore.com>
12722
12723         * findcmd.c (_initialize_mem_search): Use upper case for
12724         metasyntactic variables.
12725
12726 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
12727
12728         * aarch64-tdep.c (aarch64_add_reggroups): New function.
12729         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
12730
12731 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
12732
12733         * top.h (source_file_name): Change to std::string.
12734         * top.c (source_file_name): Likewise.
12735         (command_line_input): Adjust.
12736         * cli/cli-script.c (script_from_file): Adjust.
12737
12738 2019-02-19  Tom Tromey  <tromey@adacore.com>
12739
12740         * ravenscar-thread.c
12741         (ravenscar_thread_target::update_thread_list): Don't call
12742         ada_build_task_list.
12743         * ada-lang.h (ada_build_task_list): Don't declare.
12744         * ada-tasks.c (struct ada_tasks_inferior_data)
12745         <task_list_valid_p>: Now bool.
12746         (read_known_tasks, ada_task_list_changed)
12747         (ada_tasks_invalidate_inferior_data): Update.
12748         (read_known_tasks_array): Return bool.
12749         (read_known_tasks_list): Likewise.
12750         (read_known_tasks): Return void.
12751         (ada_build_task_list): Now static.
12752
12753 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
12754
12755         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
12756         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
12757
12758 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12759
12760         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
12761         variant for ada_tasks_pspace_data_handle and
12762         ada_tasks_inferior_data_handle.
12763         (ada_tasks_pspace_data_cleanup): New function.
12764         (ada_tasks_inferior_data_cleanup): New function.
12765
12766 2019-02-17  Tom Tromey  <tom@tromey.com>
12767
12768         * macrotab.h (macro_source_fullname): Return a std::string.
12769         * macrotab.c (macro_include, check_for_redefinition)
12770         (macro_undef, macro_lookup_definition, foreach_macro)
12771         (foreach_macro_in_scope): Update.
12772         (macro_source_fullname): Return a std::string.
12773         * macrocmd.c (show_pp_source_pos): Update.
12774
12775 2019-02-17  Tom Tromey  <tom@tromey.com>
12776
12777         * macrocmd.c (show_pp_source_pos): Style the file names.
12778
12779 2019-02-17  Tom Tromey  <tom@tromey.com>
12780
12781         PR tui/24197:
12782         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
12783
12784 2019-02-17  Tom Tromey  <tom@tromey.com>
12785
12786         * ada-lang.c (user_select_syms): Use filtered printing.
12787         * utils.c (wrap_style): New global.
12788         (desired_style): Remove.
12789         (emit_style_escape): Add stream parameter.
12790         (set_output_style, reset_terminal_style, prompt_for_continue):
12791         Update.
12792         (flush_wrap_buffer): Only flush gdb_stdout.
12793         (wrap_here): Set wrap_style.
12794         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
12795         treat escape sequences as a character.  Change when wrap buffer is
12796         flushed.
12797         (fputs_styled): Do not set the output style when the default is
12798         requested.
12799         * ui-style.h (struct ui_file_style) <is_default>: New method.
12800         * source.c (print_source_lines_base): Emit escape sequences in one
12801         piece.
12802
12803 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
12804
12805         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
12806         integers and enumeration types.
12807
12808 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
12809
12810         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
12811         instead of lookup_symbol_in_language
12812         (do_exact_match): New function.
12813         (ada_get_symbol_name_matcher): Return do_exact_match when
12814         doing a verbatim match.
12815
12816 2019-02-15  Tom Tromey  <tromey@adacore.com>
12817
12818         * ravenscar-thread.c (ravenscar_thread_target::resume)
12819         (ravenscar_thread_target::wait): Special case wildcard requests.
12820
12821 2019-02-15  Tom Tromey  <tromey@adacore.com>
12822
12823         * ravenscar-thread.c (base_ptid): Remove.
12824         (struct ravenscar_thread_target) <close>: New method.
12825         <m_base_ptid>: New member.
12826         <update_inferior_ptid, active_task, task_is_currently_active,
12827         runtime_initialized>: Declare methods.
12828         <ravenscar_thread_target>: Add constructor.
12829         (ravenscar_thread_target::task_is_currently_active)
12830         (ravenscar_thread_target::update_inferior_ptid)
12831         (ravenscar_runtime_initialized): Rename.  Now methods.
12832         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
12833         (ravenscar_thread_target::update_thread_list): Update.
12834         (ravenscar_thread_target::active_task): Now method.
12835         (ravenscar_thread_target::store_registers)
12836         (ravenscar_thread_target::prepare_to_store)
12837         (ravenscar_thread_target::prepare_to_store)
12838         (ravenscar_thread_target::mourn_inferior): Update.
12839         (ravenscar_inferior_created): Use "new" to create target.
12840         (ravenscar_thread_target::get_ada_task_ptid): Update.
12841         (_initialize_ravenscar): Don't initialize base_ptid.
12842         (ravenscar_ops): Remove global.
12843
12844 2019-02-15  Tom Tromey  <tromey@adacore.com>
12845
12846         * target.h (push_target): Declare new overload.
12847         * target.c (push_target): New overload, taking an rvalue reference.
12848         * remote.c (remote_target::open_1): Use push_target overload.
12849         * corelow.c (core_target_open): Use push_target overload.
12850
12851 2019-02-15  Tom Tromey  <tromey@adacore.com>
12852
12853         * ravenscar-thread.c (is_ravenscar_task)
12854         (ravenscar_task_is_currently_active): Return bool.
12855         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
12856         (_initialize_ravenscar): Remove "(void)".
12857         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
12858         Return bool.
12859
12860 2019-02-15  Tom Tromey  <tromey@adacore.com>
12861
12862         * ravenscar-thread.c (ravenscar_runtime_initializer)
12863         (has_ravenscar_runtime, get_running_thread_id)
12864         (ravenscar_thread_target::resume): Fix indentation.
12865
12866 2019-02-15  Tom Tromey  <tromey@adacore.com>
12867
12868         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
12869         from ravenscar_arch_ops.
12870         (sparc_ravenscar_ops::fetch_registers)
12871         (sparc_ravenscar_ops::store_registers): Now methods.
12872         (sparc_ravenscar_prepare_to_store): Remove.
12873         (sparc_ravenscar_ops): Redefine.
12874         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
12875         methods and destructor.  Remove members.
12876         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
12877         (ravenscar_thread_target::store_registers)
12878         (ravenscar_thread_target::prepare_to_store): Update.
12879         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
12880         Remove.
12881         (struct ppc_ravenscar_powerpc_ops): Derive from
12882         ravenscar_arch_ops.
12883         (ppc_ravenscar_powerpc_ops::fetch_registers)
12884         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
12885         (ppc_ravenscar_powerpc_ops): Redefine.
12886         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
12887         (ppc_ravenscar_e500_ops::fetch_registers)
12888         (ppc_ravenscar_e500_ops::store_registers): Now methods.
12889         (ppc_ravenscar_e500_ops): Redefine.
12890         * aarch64-ravenscar-thread.c
12891         (aarch64_ravenscar_generic_prepare_to_store): Remove.
12892         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
12893         (aarch64_ravenscar_fetch_registers)
12894         (aarch64_ravenscar_store_registers): Now methods.
12895         (aarch64_ravenscar_ops): Redefine.
12896
12897 2019-02-15  Tom Tromey  <tromey@adacore.com>
12898
12899         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
12900         (ravenscar_thread_target::stopped_by_hw_breakpoint)
12901         (ravenscar_thread_target::stopped_by_watchpoint)
12902         (ravenscar_thread_target::stopped_data_address)
12903         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
12904
12905 2019-02-15  Tom Tromey  <tromey@adacore.com>
12906
12907         * ravenscar-thread.c: Fix some typos.
12908
12909 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12910             Tom Tromey  <tromey@adacore.com>
12911
12912         * ada-lang.c (ada_exception_sal): Change addr_string to a
12913         std::string.
12914         (create_ada_exception_catchpoint): Update.
12915
12916 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12917             Tom Tromey  <tromey@adacore.com>
12918
12919         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
12920         (bp_location_ops): Remove.
12921         (base_breakpoint_allocate_location): Update.
12922         (free_bp_location): Update.
12923         * ada-lang.c (class ada_catchpoint_location)
12924         <ada_catchpoint_location>: Remove ops parameter.
12925         (ada_catchpoint_location_dtor): Remove.
12926         (ada_catchpoint_location_ops): Remove.
12927         (allocate_location_exception): Update.
12928         * breakpoint.h (struct bp_location_ops): Remove.
12929         (class bp_location) <bp_location>: Remove bp_location_ops
12930         parameter.
12931         <~bp_location>: Add destructor.
12932         <ops>: Remove.
12933
12934 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
12935             Pedro Alves  <palves@redhat.com>
12936
12937         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
12938         'PATH_MAX'.
12939
12940 2019-02-14  David Michael  <fedora.dm0@gmail.com>
12941             Samuel Thibault  <samuel.thibault@gnu.org>
12942             Thomas Schwinge  <thomas@codesourcery.com>
12943
12944         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
12945         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
12946
12947 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
12948
12949         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
12950         (check_empty): Use "const char *".
12951
12952         * gnu-nat.c (gnu_nat_target::detach): Instead of
12953         'detach_inferior (pid)' call
12954         'detach_inferior (find_inferior_pid (pid))'.
12955
12956         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
12957         'nat/fork-inferior.o'.
12958         * gnu-nat.c: #include "nat/fork-inferior.h".
12959
12960         * gnu-nat.c (gnu_nat_target::detach): Instead of
12961         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
12962         * gnu-nat.h: #include "inf-child.h".
12963         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
12964         'i386_gnu_nat_target::fetch_registers'.
12965         (gnu_store_registers): Rename/move to
12966         'i386_gnu_nat_target::store_registers'.
12967
12968         * config/i386/nm-i386gnu.h: Don't "#include" any files.
12969         * gnu-nat.h (mach_thread_info): New function.
12970         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
12971
12972         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
12973
12974 2019-02-14  Frederic Konrad  <konrad@adacore.com>
12975
12976         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
12977
12978 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
12979
12980         * windows-nat.c (windows_add_thread): Add new parameter
12981         "main_thread_p" with default value set to false.  Update
12982         function documentation as well as all callers.
12983         (windows_delete_thread): Likewise.
12984         (fake_create_process): Update call to windows_add_thread.
12985         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
12986         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
12987         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
12988         call to windows_delete_thread.
12989
12990 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
12991
12992         * MAINTAINERS: Add Andrew Burgess as global maintainer.
12993
12994 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
12995
12996         * symfile.c (find_separate_debug_file): Use canonical path of
12997         sysroot with child_path instead of gdb_sysroot if it is valid.
12998
12999 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
13000
13001         * symfile.c (find_separate_debug_file): Use child_path to
13002         determine if an object file is under a sysroot.
13003
13004 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
13005
13006         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
13007         unittests/child-path-selftests.c.
13008         * common/pathstuff.c (child_path): New function.
13009         * common/pathstuff.h (child_path): New prototype.
13010         * unittests/child-path-selftests.c: New file.
13011
13012 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
13013
13014         * symfile.c (find_separate_debug_file): Look for separate debug
13015         files in debug directories under the sysroot.
13016
13017 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13018
13019         * symtab.h (struct minimal_symbol data_p): New const method.
13020         (struct minimal_symbol text_p): Likewise.
13021         * symtab.c (output_source_filename): Use file name style
13022         to print file name.
13023         (print_symbol_info): Likewise.
13024         (print_msymbol_info): Use address style to print addresses.
13025         Use function name style to print executable text symbols.
13026         (expand_symtab_containing_pc): Use data_p.
13027         (find_pc_sect_compunit_symtab): Likewise.
13028
13029 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13030
13031         * breakpoint.c (describe_other_breakpoints): Use address style
13032         to print addresses.
13033         (say_where): Likewise.
13034
13035 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13036
13037         * ada-typeprint.c (print_func_type): Print function name
13038         style to print function name.
13039         * c-typeprint.c (c_print_type_1): Likewise.
13040
13041 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
13042
13043         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
13044         for execve.
13045
13046 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13047
13048         * c-exp.y (direct_abs_decl): Use emplace_back to record the
13049         type_stack.
13050
13051 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
13052
13053         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
13054         TYPE_CODE_REF types.
13055
13056 2019-02-08  Jim Wilson  <jimw@sifive.com>
13057
13058         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
13059         (riscv_linux_fregset): New.
13060         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
13061
13062 2019-02-07  Tom Tromey  <tom@tromey.com>
13063
13064         * thread.c (thread_cancel_execution_command): Update.
13065         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
13066         methods.
13067         (struct thread_fsm_ops): Remove.
13068         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
13069         (thread_fsm_should_stop, thread_fsm_return_value)
13070         (thread_fsm_set_finished, thread_fsm_finished_p)
13071         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
13072         Don't declare.
13073         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
13074         * infrun.c (clear_proceed_status_thread)
13075         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
13076         (print_stop_event): Update.
13077         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
13078         Add constructor.
13079         (step_command_fsm_ops): Remove.
13080         (new_step_command_fsm): Remove.
13081         (step_1): Update.
13082         (step_command_fsm::should_stop): Rename from
13083         step_command_fsm_should_stop.
13084         (step_command_fsm::clean_up): Rename from
13085         step_command_fsm_clean_up.
13086         (step_command_fsm::do_async_reply_reason): Rename from
13087         step_command_fsm_async_reply_reason.
13088         (struct until_next_fsm): Inherit from thread_fsm.  Add
13089         constructor.
13090         (until_next_fsm_ops): Remove.
13091         (new_until_next_fsm): Remove.
13092         (until_next_fsm::should_stop): Rename from
13093         until_next_fsm_should_stop.
13094         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
13095         (until_next_fsm::do_async_reply_reason): Rename from
13096         until_next_fsm_async_reply_reason.
13097         (struct finish_command_fsm): Inherit from thread_fsm.  Add
13098         constructor.  Change type of breakpoint.
13099         (finish_command_fsm_ops): Remove.
13100         (new_finish_command_fsm): Remove.
13101         (finish_command_fsm::should_stop): Rename from
13102         finish_command_fsm_should_stop.
13103         (finish_command_fsm::clean_up): Rename from
13104         finish_command_fsm_clean_up.
13105         (finish_command_fsm::return_value): Rename from
13106         finish_command_fsm_return_value.
13107         (finish_command_fsm::do_async_reply_reason): Rename from
13108         finish_command_fsm_async_reply_reason.
13109         (finish_command): Update.
13110         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
13111         Add constructor.
13112         (call_thread_fsm_ops): Remove.
13113         (call_thread_fsm::call_thread_fsm): Rename from
13114         new_call_thread_fsm.
13115         (call_thread_fsm::should_stop): Rename from
13116         call_thread_fsm_should_stop.
13117         (call_thread_fsm::should_notify_stop): Rename from
13118         call_thread_fsm_should_notify_stop.
13119         (run_inferior_call, call_function_by_hand_dummy): Update.
13120         * cli/cli-interp.c (should_print_stop_to_console): Update.
13121         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
13122         Add constructor.  Change type of location_breakpoint,
13123         caller_breakpoint.
13124         (until_break_fsm_ops): Remove.
13125         (new_until_break_fsm): Remove.
13126         (until_break_fsm::should_stop): Rename from
13127         until_break_fsm_should_stop.
13128         (until_break_fsm::clean_up): Rename from
13129         until_break_fsm_clean_up.
13130         (until_break_fsm::do_async_reply_reason): Rename from
13131         until_break_fsm_async_reply_reason.
13132         (until_break_command): Update.
13133         * thread-fsm.c: Remove.
13134         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
13135
13136 2019-02-07  Tom Tromey  <tom@tromey.com>
13137
13138         * yy-remap.h: Add include guard.
13139         * xtensa-tdep.h: Add include guard.
13140         * xcoffread.h: Rename include guard.
13141         * varobj-iter.h: Add include guard.
13142         * tui/tui.h: Rename include guard.
13143         * tui/tui-winsource.h: Rename include guard.
13144         * tui/tui-wingeneral.h: Rename include guard.
13145         * tui/tui-windata.h: Rename include guard.
13146         * tui/tui-win.h: Rename include guard.
13147         * tui/tui-stack.h: Rename include guard.
13148         * tui/tui-source.h: Rename include guard.
13149         * tui/tui-regs.h: Rename include guard.
13150         * tui/tui-out.h: Rename include guard.
13151         * tui/tui-layout.h: Rename include guard.
13152         * tui/tui-io.h: Rename include guard.
13153         * tui/tui-hooks.h: Rename include guard.
13154         * tui/tui-file.h: Rename include guard.
13155         * tui/tui-disasm.h: Rename include guard.
13156         * tui/tui-data.h: Rename include guard.
13157         * tui/tui-command.h: Rename include guard.
13158         * tic6x-tdep.h: Add include guard.
13159         * target/waitstatus.h: Rename include guard.
13160         * target/wait.h: Rename include guard.
13161         * target/target.h: Rename include guard.
13162         * target/resume.h: Rename include guard.
13163         * target-float.h: Rename include guard.
13164         * stabsread.h: Add include guard.
13165         * rs6000-tdep.h: Add include guard.
13166         * riscv-fbsd-tdep.h: Add include guard.
13167         * regformats/regdef.h: Rename include guard.
13168         * record.h: Rename include guard.
13169         * python/python.h: Rename include guard.
13170         * python/python-internal.h: Rename include guard.
13171         * python/py-stopevent.h: Rename include guard.
13172         * python/py-ref.h: Rename include guard.
13173         * python/py-record.h: Rename include guard.
13174         * python/py-record-full.h: Rename include guard.
13175         * python/py-record-btrace.h: Rename include guard.
13176         * python/py-instruction.h: Rename include guard.
13177         * python/py-events.h: Rename include guard.
13178         * python/py-event.h: Rename include guard.
13179         * procfs.h: Add include guard.
13180         * proc-utils.h: Add include guard.
13181         * p-lang.h: Add include guard.
13182         * or1k-tdep.h: Rename include guard.
13183         * observable.h: Rename include guard.
13184         * nto-tdep.h: Rename include guard.
13185         * nat/x86-linux.h: Rename include guard.
13186         * nat/x86-linux-dregs.h: Rename include guard.
13187         * nat/x86-gcc-cpuid.h: Add include guard.
13188         * nat/x86-dregs.h: Rename include guard.
13189         * nat/x86-cpuid.h: Rename include guard.
13190         * nat/ppc-linux.h: Rename include guard.
13191         * nat/mips-linux-watch.h: Rename include guard.
13192         * nat/linux-waitpid.h: Rename include guard.
13193         * nat/linux-ptrace.h: Rename include guard.
13194         * nat/linux-procfs.h: Rename include guard.
13195         * nat/linux-osdata.h: Rename include guard.
13196         * nat/linux-nat.h: Rename include guard.
13197         * nat/linux-namespaces.h: Rename include guard.
13198         * nat/linux-btrace.h: Rename include guard.
13199         * nat/glibc_thread_db.h: Rename include guard.
13200         * nat/gdb_thread_db.h: Rename include guard.
13201         * nat/gdb_ptrace.h: Rename include guard.
13202         * nat/fork-inferior.h: Rename include guard.
13203         * nat/amd64-linux-siginfo.h: Rename include guard.
13204         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
13205         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
13206         * nat/aarch64-linux.h: Rename include guard.
13207         * nat/aarch64-linux-hw-point.h: Rename include guard.
13208         * mn10300-tdep.h: Add include guard.
13209         * mips-linux-tdep.h: Add include guard.
13210         * mi/mi-parse.h: Rename include guard.
13211         * mi/mi-out.h: Rename include guard.
13212         * mi/mi-main.h: Rename include guard.
13213         * mi/mi-interp.h: Rename include guard.
13214         * mi/mi-getopt.h: Rename include guard.
13215         * mi/mi-console.h: Rename include guard.
13216         * mi/mi-common.h: Rename include guard.
13217         * mi/mi-cmds.h: Rename include guard.
13218         * mi/mi-cmd-break.h: Rename include guard.
13219         * m2-lang.h: Add include guard.
13220         * location.h: Rename include guard.
13221         * linux-record.h: Rename include guard.
13222         * linux-nat.h: Add include guard.
13223         * linux-fork.h: Add include guard.
13224         * i386-darwin-tdep.h: Rename include guard.
13225         * hppa-linux-offsets.h: Add include guard.
13226         * guile/guile.h: Rename include guard.
13227         * guile/guile-internal.h: Rename include guard.
13228         * gnu-nat.h: Rename include guard.
13229         * gdb-stabs.h: Rename include guard.
13230         * frv-tdep.h: Add include guard.
13231         * f-lang.h: Add include guard.
13232         * event-loop.h: Add include guard.
13233         * darwin-nat.h: Rename include guard.
13234         * cp-abi.h: Rename include guard.
13235         * config/sparc/nm-sol2.h: Rename include guard.
13236         * config/nm-nto.h: Rename include guard.
13237         * config/nm-linux.h: Add include guard.
13238         * config/i386/nm-i386gnu.h: Rename include guard.
13239         * config/djgpp/nl_types.h: Rename include guard.
13240         * config/djgpp/langinfo.h: Rename include guard.
13241         * compile/gcc-cp-plugin.h: Add include guard.
13242         * compile/gcc-c-plugin.h: Add include guard.
13243         * compile/compile.h: Rename include guard.
13244         * compile/compile-object-run.h: Rename include guard.
13245         * compile/compile-object-load.h: Rename include guard.
13246         * compile/compile-internal.h: Rename include guard.
13247         * compile/compile-cplus.h: Rename include guard.
13248         * compile/compile-c.h: Rename include guard.
13249         * common/xml-utils.h: Rename include guard.
13250         * common/x86-xstate.h: Rename include guard.
13251         * common/version.h: Rename include guard.
13252         * common/vec.h: Rename include guard.
13253         * common/tdesc.h: Rename include guard.
13254         * common/selftest.h: Rename include guard.
13255         * common/scoped_restore.h: Rename include guard.
13256         * common/scoped_mmap.h: Rename include guard.
13257         * common/scoped_fd.h: Rename include guard.
13258         * common/safe-iterator.h: Rename include guard.
13259         * common/run-time-clock.h: Rename include guard.
13260         * common/refcounted-object.h: Rename include guard.
13261         * common/queue.h: Rename include guard.
13262         * common/ptid.h: Rename include guard.
13263         * common/print-utils.h: Rename include guard.
13264         * common/preprocessor.h: Rename include guard.
13265         * common/pathstuff.h: Rename include guard.
13266         * common/observable.h: Rename include guard.
13267         * common/netstuff.h: Rename include guard.
13268         * common/job-control.h: Rename include guard.
13269         * common/host-defs.h: Rename include guard.
13270         * common/gdb_wait.h: Rename include guard.
13271         * common/gdb_vecs.h: Rename include guard.
13272         * common/gdb_unlinker.h: Rename include guard.
13273         * common/gdb_unique_ptr.h: Rename include guard.
13274         * common/gdb_tilde_expand.h: Rename include guard.
13275         * common/gdb_sys_time.h: Rename include guard.
13276         * common/gdb_string_view.h: Rename include guard.
13277         * common/gdb_splay_tree.h: Rename include guard.
13278         * common/gdb_setjmp.h: Rename include guard.
13279         * common/gdb_ref_ptr.h: Rename include guard.
13280         * common/gdb_optional.h: Rename include guard.
13281         * common/gdb_locale.h: Rename include guard.
13282         * common/gdb_assert.h: Rename include guard.
13283         * common/filtered-iterator.h: Rename include guard.
13284         * common/filestuff.h: Rename include guard.
13285         * common/fileio.h: Rename include guard.
13286         * common/environ.h: Rename include guard.
13287         * common/common-utils.h: Rename include guard.
13288         * common/common-types.h: Rename include guard.
13289         * common/common-regcache.h: Rename include guard.
13290         * common/common-inferior.h: Rename include guard.
13291         * common/common-gdbthread.h: Rename include guard.
13292         * common/common-exceptions.h: Rename include guard.
13293         * common/common-defs.h: Rename include guard.
13294         * common/common-debug.h: Rename include guard.
13295         * common/cleanups.h: Rename include guard.
13296         * common/buffer.h: Rename include guard.
13297         * common/btrace-common.h: Rename include guard.
13298         * common/break-common.h: Rename include guard.
13299         * cli/cli-utils.h: Rename include guard.
13300         * cli/cli-style.h: Rename include guard.
13301         * cli/cli-setshow.h: Rename include guard.
13302         * cli/cli-script.h: Rename include guard.
13303         * cli/cli-interp.h: Rename include guard.
13304         * cli/cli-decode.h: Rename include guard.
13305         * cli/cli-cmds.h: Rename include guard.
13306         * charset-list.h: Add include guard.
13307         * buildsym-legacy.h: Rename include guard.
13308         * bfin-tdep.h: Add include guard.
13309         * ax.h: Rename include guard.
13310         * arm-linux-tdep.h: Add include guard.
13311         * arm-fbsd-tdep.h: Add include guard.
13312         * arch/xtensa.h: Rename include guard.
13313         * arch/tic6x.h: Add include guard.
13314         * arch/i386.h: Add include guard.
13315         * arch/arm.h: Rename include guard.
13316         * arch/arm-linux.h: Rename include guard.
13317         * arch/arm-get-next-pcs.h: Rename include guard.
13318         * arch/amd64.h: Add include guard.
13319         * arch/aarch64-insn.h: Rename include guard.
13320         * arch-utils.h: Rename include guard.
13321         * annotate.h: Add include guard.
13322         * amd64-darwin-tdep.h: Rename include guard.
13323         * aarch64-linux-tdep.h: Add include guard.
13324         * aarch64-fbsd-tdep.h: Add include guard.
13325         * aarch32-linux-nat.h: Add include guard.
13326
13327 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13328
13329         * macrotab.c (macro_define_internal): New function that
13330         factorizes macro_define_object_internal and macro_define_function
13331         code.
13332         (macro_define_object_internal): Use macro_define_internal.
13333         (macro_define_function): Likewise.
13334
13335 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13336
13337         * macrocmd.c (extract_identifier): Return
13338         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
13339         callers.
13340
13341 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
13342
13343         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
13344
13345 2019-02-05  Tom Tromey  <tom@tromey.com>
13346
13347         * target.c (target_stack::unpush): Move assertion earlier.
13348
13349 2019-01-30  Tom Tromey  <tom@tromey.com>
13350
13351         PR python/23615:
13352         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
13353         (gdbpy_parse_and_eval): Likewise.
13354         * python/python-internal.h (gdbpy_allow_threads): New class.
13355
13356 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
13357
13358         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
13359         (aarch64_fbsd_fpregmap): Move earlier.
13360         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
13361         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
13362         instead of individual calls to trad_frame_set_reg_addr.
13363         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
13364         earlier.
13365         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
13366         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
13367         instead of individual calls to trad_frame_set_reg_addr.
13368
13369 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
13370
13371         * CONTRIBUTE: Replace contribution list with wiki link.
13372
13373 2019-01-25  Tom Tromey  <tom@tromey.com>
13374
13375         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
13376
13377 2019-01-25  Tom Tromey  <tom@tromey.com>
13378
13379         * xtensa-linux-nat.c: Fix common/ includes.
13380         * xml-support.h: Fix common/ includes.
13381         * xml-support.c: Fix common/ includes.
13382         * x86-linux-nat.c: Fix common/ includes.
13383         * windows-nat.c: Fix common/ includes.
13384         * varobj.h: Fix common/ includes.
13385         * varobj.c: Fix common/ includes.
13386         * value.c: Fix common/ includes.
13387         * valops.c: Fix common/ includes.
13388         * utils.c: Fix common/ includes.
13389         * unittests/xml-utils-selftests.c: Fix common/ includes.
13390         * unittests/utils-selftests.c: Fix common/ includes.
13391         * unittests/unpack-selftests.c: Fix common/ includes.
13392         * unittests/tracepoint-selftests.c: Fix common/ includes.
13393         * unittests/style-selftests.c: Fix common/ includes.
13394         * unittests/string_view-selftests.c: Fix common/ includes.
13395         * unittests/scoped_restore-selftests.c: Fix common/ includes.
13396         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
13397         * unittests/scoped_fd-selftests.c: Fix common/ includes.
13398         * unittests/rsp-low-selftests.c: Fix common/ includes.
13399         * unittests/parse-connection-spec-selftests.c: Fix common/
13400         includes.
13401         * unittests/optional-selftests.c: Fix common/ includes.
13402         * unittests/offset-type-selftests.c: Fix common/ includes.
13403         * unittests/observable-selftests.c: Fix common/ includes.
13404         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
13405         * unittests/memrange-selftests.c: Fix common/ includes.
13406         * unittests/memory-map-selftests.c: Fix common/ includes.
13407         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
13408         * unittests/function-view-selftests.c: Fix common/ includes.
13409         * unittests/environ-selftests.c: Fix common/ includes.
13410         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
13411         * unittests/common-utils-selftests.c: Fix common/ includes.
13412         * unittests/cli-utils-selftests.c: Fix common/ includes.
13413         * unittests/array-view-selftests.c: Fix common/ includes.
13414         * ui-file.c: Fix common/ includes.
13415         * tui/tui-io.c: Fix common/ includes.
13416         * tracepoint.h: Fix common/ includes.
13417         * tracepoint.c: Fix common/ includes.
13418         * tracefile-tfile.c: Fix common/ includes.
13419         * top.h: Fix common/ includes.
13420         * top.c: Fix common/ includes.
13421         * thread.c: Fix common/ includes.
13422         * target/waitstatus.h: Fix common/ includes.
13423         * target/waitstatus.c: Fix common/ includes.
13424         * target.h: Fix common/ includes.
13425         * target.c: Fix common/ includes.
13426         * target-memory.c: Fix common/ includes.
13427         * target-descriptions.c: Fix common/ includes.
13428         * symtab.h: Fix common/ includes.
13429         * symfile.c: Fix common/ includes.
13430         * stap-probe.c: Fix common/ includes.
13431         * spu-linux-nat.c: Fix common/ includes.
13432         * sparc-nat.c: Fix common/ includes.
13433         * source.c: Fix common/ includes.
13434         * solib.c: Fix common/ includes.
13435         * solib-target.c: Fix common/ includes.
13436         * ser-unix.c: Fix common/ includes.
13437         * ser-tcp.c: Fix common/ includes.
13438         * ser-pipe.c: Fix common/ includes.
13439         * ser-base.c: Fix common/ includes.
13440         * selftest-arch.c: Fix common/ includes.
13441         * s12z-tdep.c: Fix common/ includes.
13442         * rust-exp.y: Fix common/ includes.
13443         * rs6000-aix-tdep.c: Fix common/ includes.
13444         * riscv-tdep.c: Fix common/ includes.
13445         * remote.c: Fix common/ includes.
13446         * remote-notif.h: Fix common/ includes.
13447         * remote-fileio.h: Fix common/ includes.
13448         * remote-fileio.c: Fix common/ includes.
13449         * regcache.h: Fix common/ includes.
13450         * regcache.c: Fix common/ includes.
13451         * record-btrace.c: Fix common/ includes.
13452         * python/python.c: Fix common/ includes.
13453         * python/py-type.c: Fix common/ includes.
13454         * python/py-inferior.c: Fix common/ includes.
13455         * progspace.h: Fix common/ includes.
13456         * producer.c: Fix common/ includes.
13457         * procfs.c: Fix common/ includes.
13458         * proc-api.c: Fix common/ includes.
13459         * printcmd.c: Fix common/ includes.
13460         * ppc-linux-nat.c: Fix common/ includes.
13461         * parser-defs.h: Fix common/ includes.
13462         * osdata.c: Fix common/ includes.
13463         * obsd-nat.c: Fix common/ includes.
13464         * nat/x86-linux.c: Fix common/ includes.
13465         * nat/x86-linux-dregs.c: Fix common/ includes.
13466         * nat/x86-dregs.h: Fix common/ includes.
13467         * nat/x86-dregs.c: Fix common/ includes.
13468         * nat/ppc-linux.c: Fix common/ includes.
13469         * nat/mips-linux-watch.h: Fix common/ includes.
13470         * nat/mips-linux-watch.c: Fix common/ includes.
13471         * nat/linux-waitpid.c: Fix common/ includes.
13472         * nat/linux-ptrace.h: Fix common/ includes.
13473         * nat/linux-ptrace.c: Fix common/ includes.
13474         * nat/linux-procfs.c: Fix common/ includes.
13475         * nat/linux-personality.c: Fix common/ includes.
13476         * nat/linux-osdata.c: Fix common/ includes.
13477         * nat/linux-namespaces.c: Fix common/ includes.
13478         * nat/linux-btrace.h: Fix common/ includes.
13479         * nat/linux-btrace.c: Fix common/ includes.
13480         * nat/fork-inferior.c: Fix common/ includes.
13481         * nat/amd64-linux-siginfo.c: Fix common/ includes.
13482         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
13483         * nat/aarch64-linux.c: Fix common/ includes.
13484         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
13485         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
13486         * namespace.h: Fix common/ includes.
13487         * mips-linux-tdep.c: Fix common/ includes.
13488         * minsyms.c: Fix common/ includes.
13489         * mi/mi-parse.h: Fix common/ includes.
13490         * mi/mi-main.c: Fix common/ includes.
13491         * mi/mi-cmd-env.c: Fix common/ includes.
13492         * memrange.h: Fix common/ includes.
13493         * memattr.c: Fix common/ includes.
13494         * maint.h: Fix common/ includes.
13495         * maint.c: Fix common/ includes.
13496         * main.c: Fix common/ includes.
13497         * machoread.c: Fix common/ includes.
13498         * location.c: Fix common/ includes.
13499         * linux-thread-db.c: Fix common/ includes.
13500         * linux-nat.c: Fix common/ includes.
13501         * linux-fork.c: Fix common/ includes.
13502         * inline-frame.c: Fix common/ includes.
13503         * infrun.c: Fix common/ includes.
13504         * inflow.c: Fix common/ includes.
13505         * inferior.h: Fix common/ includes.
13506         * inferior.c: Fix common/ includes.
13507         * infcmd.c: Fix common/ includes.
13508         * inf-ptrace.c: Fix common/ includes.
13509         * inf-child.c: Fix common/ includes.
13510         * ia64-linux-nat.c: Fix common/ includes.
13511         * i387-tdep.c: Fix common/ includes.
13512         * i386-tdep.c: Fix common/ includes.
13513         * i386-linux-tdep.c: Fix common/ includes.
13514         * i386-linux-nat.c: Fix common/ includes.
13515         * i386-go32-tdep.c: Fix common/ includes.
13516         * i386-fbsd-tdep.c: Fix common/ includes.
13517         * i386-fbsd-nat.c: Fix common/ includes.
13518         * guile/scm-type.c: Fix common/ includes.
13519         * guile/guile.c: Fix common/ includes.
13520         * go32-nat.c: Fix common/ includes.
13521         * gnu-nat.c: Fix common/ includes.
13522         * gdbthread.h: Fix common/ includes.
13523         * gdbarch-selftests.c: Fix common/ includes.
13524         * gdb_usleep.c: Fix common/ includes.
13525         * gdb_select.h: Fix common/ includes.
13526         * gdb_bfd.c: Fix common/ includes.
13527         * gcore.c: Fix common/ includes.
13528         * fork-child.c: Fix common/ includes.
13529         * findvar.c: Fix common/ includes.
13530         * fbsd-nat.c: Fix common/ includes.
13531         * event-top.c: Fix common/ includes.
13532         * event-loop.c: Fix common/ includes.
13533         * dwarf2read.c: Fix common/ includes.
13534         * dwarf2loc.c: Fix common/ includes.
13535         * dwarf2-frame.c: Fix common/ includes.
13536         * dwarf-index-cache.c: Fix common/ includes.
13537         * dtrace-probe.c: Fix common/ includes.
13538         * disasm-selftests.c: Fix common/ includes.
13539         * defs.h: Fix common/ includes.
13540         * csky-tdep.c: Fix common/ includes.
13541         * cp-valprint.c: Fix common/ includes.
13542         * cp-support.h: Fix common/ includes.
13543         * cp-support.c: Fix common/ includes.
13544         * corelow.c: Fix common/ includes.
13545         * completer.h: Fix common/ includes.
13546         * completer.c: Fix common/ includes.
13547         * compile/compile.c: Fix common/ includes.
13548         * compile/compile-loc2c.c: Fix common/ includes.
13549         * compile/compile-cplus-types.c: Fix common/ includes.
13550         * compile/compile-cplus-symbols.c: Fix common/ includes.
13551         * command.h: Fix common/ includes.
13552         * cli/cli-dump.c: Fix common/ includes.
13553         * cli/cli-cmds.c: Fix common/ includes.
13554         * charset.c: Fix common/ includes.
13555         * build-id.c: Fix common/ includes.
13556         * btrace.h: Fix common/ includes.
13557         * btrace.c: Fix common/ includes.
13558         * breakpoint.h: Fix common/ includes.
13559         * breakpoint.c: Fix common/ includes.
13560         * ax.h:
13561         (enum agent_op): Fix common/ includes.
13562         * ax-general.c (struct aop_map): Fix common/ includes.
13563         * ax-gdb.c: Fix common/ includes.
13564         * auxv.c: Fix common/ includes.
13565         * auto-load.c: Fix common/ includes.
13566         * arm-tdep.c: Fix common/ includes.
13567         * arch/riscv.c: Fix common/ includes.
13568         * arch/ppc-linux-common.c: Fix common/ includes.
13569         * arch/i386.c: Fix common/ includes.
13570         * arch/arm.c: Fix common/ includes.
13571         * arch/arm-linux.c: Fix common/ includes.
13572         * arch/arm-get-next-pcs.c: Fix common/ includes.
13573         * arch/amd64.c: Fix common/ includes.
13574         * arch/aarch64.c: Fix common/ includes.
13575         * arch/aarch64-insn.c: Fix common/ includes.
13576         * arch-utils.c: Fix common/ includes.
13577         * amd64-windows-tdep.c: Fix common/ includes.
13578         * amd64-tdep.c: Fix common/ includes.
13579         * amd64-sol2-tdep.c: Fix common/ includes.
13580         * amd64-obsd-tdep.c: Fix common/ includes.
13581         * amd64-nbsd-tdep.c: Fix common/ includes.
13582         * amd64-linux-tdep.c: Fix common/ includes.
13583         * amd64-linux-nat.c: Fix common/ includes.
13584         * amd64-fbsd-tdep.c: Fix common/ includes.
13585         * amd64-fbsd-nat.c: Fix common/ includes.
13586         * amd64-dicos-tdep.c: Fix common/ includes.
13587         * amd64-darwin-tdep.c: Fix common/ includes.
13588         * agent.c: Fix common/ includes.
13589         * ada-lang.h: Fix common/ includes.
13590         * ada-lang.c: Fix common/ includes.
13591         * aarch64-tdep.c: Fix common/ includes.
13592
13593 2019-01-25  Tom Tromey  <tom@tromey.com>
13594
13595         * common/create-version.sh: Use common/version.h.
13596
13597 2019-01-24  Pedro Alves  <palves@redhat.com>
13598
13599         * infrun.c (signal_stop, signal_print, signal_program)
13600         (signal_catch, signal_pass): Now arrays instead of pointers.
13601         (update_signals_program_target, do_target_resume)
13602         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
13603         * linux-nat.c (linux_nat_target::pass_signals)
13604         (linux_nat_target::create_inferior, linux_nat_target::attach):
13605         Adjust.
13606         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
13607         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
13608         * procfs.c (procfs_target::pass_signals): Adjust.
13609         * record-full.c (record_full_target::resume): Adjust.
13610         * remote.c (remote_target::pass_signals)
13611         (remote_target::program_signals): Adjust.
13612         * target-debug.h (target_debug_print_signals): Now takes a
13613         gdb::array_view as parameter.  Adjust.
13614         * target.h (target_ops) <pass_signals, program_signals>: Replace
13615         pointer and length parameters with gdb::array_view.
13616         (target_pass_signals, target_program_signals): Likewise.
13617         * target-delegates.c: Regenerate.
13618
13619 2019-01-24  Pedro Alves  <palves@redhat.com>
13620
13621         * common/forward-scope-exit.h
13622         (forward_scope_exit::forward_scope_exit): Pass arguments to
13623         m_bind_function directly, instead of creating a std::bind and
13624         copying that.
13625
13626 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
13627
13628         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
13629         for static members.
13630         (pass_in_v_vfp_candidate): Likewise.
13631
13632 2019-01-23  Tom Tromey  <tom@tromey.com>
13633             Pedro Alves  <palves@redhat.com>
13634
13635         * regcache.c (class regcache_invalidator): Remove.
13636         (regcache::raw_write): Use make_scope_exit.
13637
13638 2019-01-23  Tom Tromey  <tom@tromey.com>
13639
13640         * ui-out.h (class ui_out_emit_type): Update comment.
13641
13642 2019-01-23  Tom Tromey  <tom@tromey.com>
13643
13644         * infrun.c (fetch_inferior_event): Update comment.
13645
13646 2019-01-23  Tom Tromey  <tom@tromey.com>
13647             Pedro Alves  <palves@redhat.com>
13648
13649         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
13650         parameter.
13651         (fetch_inferior_event): Use SCOPE_EXIT.
13652
13653
13654 2019-01-23  Tom Tromey  <tom@tromey.com>
13655             Pedro Alves  <palves@redhat.com>
13656
13657         * infrun.c (disable_thread_events): Delete.
13658         (stop_all_threads): Use SCOPE_EXIT.
13659
13660 2019-01-23  Tom Tromey  <tom@tromey.com>
13661             Pedro Alves  <palves@redhat.com>
13662
13663         * symfile.c: Include forward-scope-exit.h.
13664         (clear_symtab_users_cleanup): Replace forward declaration with
13665         a FORWARD_SCOPE_EXIT.
13666         (syms_from_objfile_1): Use the forward_scope_exit and
13667         gdb::optional instead of cleanup_function.
13668         (reread_symbols): Use the forward_scope_exit instead of
13669         cleanup_function.
13670         (clear_symtab_users_cleanup): Remove function.
13671
13672 2019-01-23  Tom Tromey  <tom@tromey.com>
13673             Pedro Alves  <palves@redhat.com>
13674
13675         * linux-nat.c: Include scope-exit.h.
13676         (cleanup_target_stop): Remove.
13677         (linux_nat_target::static_tracepoint_markers_by_strid): Use
13678         SCOPE_EXIT.
13679
13680 2019-01-23  Tom Tromey  <tom@tromey.com>
13681             Pedro Alves  <palves@redhat.com>
13682
13683         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
13684         (call_function_by_hand_dummy): Use SCOPE_EXIT.
13685
13686 2019-01-23  Tom Tromey  <tom@tromey.com>
13687             Andrew Burgess  <andrew.burgess@embecosm.com>
13688             Pedro Alves  <palves@redhat.com>
13689
13690         * infrun.c (fetch_inferior_event): Use scope_exit.
13691         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
13692         * top.c (execute_command): Use scope_exit.
13693         * breakpoint.c (bpstat_do_actions): Use scope_exit.
13694         * utils.c (do_bpstat_clear_actions_cleanup)
13695         (make_bpstat_clear_actions_cleanup): Remove.
13696
13697 2019-01-23  Tom Tromey  <tom@tromey.com>
13698             Pedro Alves  <palves@redhat.com>
13699
13700         * infrun.c: Include "common/scope-exit.h"
13701         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
13702         (wait_for_inferior): Use SCOPE_EXIT.
13703         (fetch_inferior_event): Use scope_exit.
13704
13705 2019-01-23  Tom Tromey  <tom@tromey.com>
13706             Pedro Alves  <palves@redhat.com>
13707
13708         * breakpoint.c (create_breakpoint): Remove cleanup.
13709
13710 2019-01-23  Tom Tromey  <tom@tromey.com>
13711             Andrew Burgess  <andrew.burgess@embecosm.com>
13712             Pedro Alves  <palves@redhat.com>
13713
13714 2019-01-23  Pedro Alves  <palves@redhat.com>
13715
13716         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
13717
13718 2019-01-23  Pedro Alves  <palves@redhat.com>
13719             Andrew Burgess  <andrew.burgess@embecosm.com>
13720
13721         * gdbthread.h: Include "common/forward-scope-exit.h".
13722         (scoped_finish_thread_state): Redefine custom class in terms of
13723         forward_scope_exit.
13724
13725 2019-01-23  Pedro Alves  <palves@redhat.com>
13726             Andrew Burgess  <andrew.burgess@embecosm.com>
13727
13728         * common/forward-scope-exit.h: New file.
13729
13730 2019-01-23  Pedro Alves  <palves@redhat.com>
13731             Andrew Burgess  <andrew.burgess@embecosm.com>
13732             Tom Tromey  <tom@tromey.com>
13733
13734         * common/scope-exit.h: New file.
13735
13736 2019-01-23  Pedro Alves  <palves@redhat.com>
13737
13738         * common/preprocessor.h (ESC): Rename to ...
13739         (ESC_PARENS): ... this.
13740         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
13741         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
13742
13743 2019-01-23  Tom Tromey  <tom@tromey.com>
13744
13745         * language.h (class scoped_switch_to_sym_language_if_auto):
13746         Initialize m_lang in both cases.
13747
13748 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
13749
13750         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
13751         with XCNEW.
13752
13753 2019-01-22  Tom Tromey  <tom@tromey.com>
13754
13755         * corelow.c: Do not include sys/file.h.
13756
13757 2019-01-22  Tom Tromey  <tom@tromey.com>
13758
13759         * tui/tui-wingeneral.h: Include gdb_curses.h.
13760
13761 2019-01-22  Tom Tromey  <tom@tromey.com>
13762
13763         * source-cache.h (class source_cache) <get_source_lines,
13764         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
13765
13766 2019-01-22  Tom Tromey  <tom@tromey.com>
13767
13768         * remote-fileio.h (struct remote_target): Declare.
13769
13770 2019-01-22  Tom Tromey  <tom@tromey.com>
13771
13772         * python/py-arch.c: Do not include py-ref.h.
13773         * python/py-bpevent.c: Do not include py-ref.h.
13774         * python/py-cmd.c: Do not include py-ref.h.
13775         * python/py-continueevent.c: Do not include py-ref.h.
13776         * python/py-event.h: Do not include py-ref.h.
13777         * python/py-evtregistry.c: Do not include py-ref.h.
13778         * python/py-finishbreakpoint.c: Do not include py-ref.h.
13779         * python/py-frame.c: Do not include py-ref.h.
13780         * python/py-framefilter.c: Do not include py-ref.h.
13781         * python/py-function.c: Do not include py-ref.h.
13782         * python/py-infevents.c: Do not include py-ref.h.
13783         * python/py-linetable.c: Do not include py-ref.h.
13784         * python/py-objfile.c: Do not include py-ref.h.
13785         * python/py-param.c: Do not include py-ref.h.
13786         * python/py-prettyprint.c: Do not include py-ref.h.
13787         * python/py-progspace.c: Do not include py-ref.h.
13788         * python/py-symbol.c: Do not include py-ref.h.
13789         * python/py-symtab.c: Do not include py-ref.h.
13790         * python/py-type.c: Do not include py-ref.h.
13791         * python/py-unwind.c: Do not include py-ref.h.
13792         * python/py-utils.c: Do not include py-ref.h.
13793         * python/py-value.c: Do not include py-ref.h.
13794         * python/py-varobj.c: Do not include py-ref.h.
13795         * python/py-xmethods.c: Do not include py-ref.h.
13796         * python/python.c: Do not include py-ref.h.
13797         * varobj.c: Do not include py-ref.h.
13798
13799 2019-01-22  Tom Tromey  <tom@tromey.com>
13800
13801         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
13802         keyword for bcache.
13803
13804 2019-01-22  Tom Tromey  <tom@tromey.com>
13805
13806         * compile/compile-cplus-types.c: Remove a comment by #include.
13807
13808 2019-01-22  Tom Tromey  <tom@tromey.com>
13809
13810         * compile/gcc-c-plugin.h: Include compile-internal.h.
13811
13812 2019-01-22  Tom Tromey  <tom@tromey.com>
13813
13814         * stabsread.c (EXTERN): Do not define.
13815         (symnum, next_symbol_text_func, processing_gcc_compilation)
13816         (within_function, global_sym_chain, global_stabs)
13817         (previous_stab_code, this_object_header_files)
13818         (n_this_object_header_files)
13819         (n_allocated_this_object_header_files): Define.
13820         * stabsread.h (EXTERN): Never define.  Use "extern".
13821
13822 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13823
13824         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
13825         history_value.
13826
13827 2019-01-21  Tom Tromey  <tom@tromey.com>
13828
13829         * ui-out.c: Fix includes.
13830         * tui/tui-source.c: Fix includes.
13831         * target.c: Fix includes.
13832         * remote.c: Fix includes.
13833         * regcache.c: Fix includes.
13834         * python/py-block.c: Fix includes.
13835         * printcmd.c: Fix includes.
13836         * or1k-tdep.c: Fix includes.
13837         * mi/mi-main.c: Fix includes.
13838         * m32r-tdep.c: Fix includes.
13839         * csky-tdep.c: Fix includes.
13840         * compile/compile-cplus-types.c: Fix includes.
13841         * cli/cli-interp.c: Fix includes.
13842
13843 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
13844
13845         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
13846         for padding.
13847
13848 2019-01-16  Tom Tromey  <tom@tromey.com>
13849
13850         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
13851         earlier.
13852         (struct objfile) <msymbols_range>: Move from top level.
13853         <msymbols>: New method.
13854         (class objfile_msymbols): Remove.
13855         * symtab.c (default_collect_symbol_completion_matches_break_on):
13856         Update.
13857         * symmisc.c (dump_msymbols): Update.
13858         * stabsread.c (scan_file_globals): Update.
13859         * objc-lang.c (info_selectors_command, info_classes_command)
13860         (find_methods): Update.
13861         * minsyms.c (find_solib_trampoline_target): Update.
13862         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
13863         * coffread.c (coff_symfile_read): Update.
13864         * ada-lang.c (ada_lookup_simple_minsym)
13865         (ada_collect_symbol_completion_matches): Update.
13866
13867 2019-01-16  Tom Tromey  <tom@tromey.com>
13868
13869         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
13870         type.  Remove no-argument constructor.
13871         <iterator::operator++>: Simplify.
13872         <begin>: Update.
13873         <end>: Use minimal_symbol_count.
13874
13875 2019-01-16  Tom Tromey  <tom@tromey.com>
13876
13877         * objfiles.h (struct objfile) <psymtabs>: New method.
13878         (class objfile_psymtabs): Remove.
13879         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
13880         typedef.
13881         <range>: New method.
13882         (require_partial_symbols): Change return type.
13883         * psymtab.c (require_partial_symbols)
13884         (psym_expand_symtabs_matching): Update.
13885         * mdebugread.c (parse_partial_symbols): Update.
13886         * dbxread.c (dbx_end_psymtab): Update.
13887
13888 2019-01-15  Tom Tromey  <tom@tromey.com>
13889
13890         * symtab.c (lookup_objfile_from_block)
13891         (lookup_symbol_in_objfile_symtabs)
13892         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
13893         (find_line_symtab, info_sources_command)
13894         (default_collect_symbol_completion_matches_break_on)
13895         (make_source_files_completion_list): Update.
13896         * symmisc.c (print_objfile_statistics, dump_objfile)
13897         (maintenance_print_symbols, maintenance_info_symtabs)
13898         (maintenance_check_symtabs, maintenance_info_line_tables):
13899         Update.
13900         * source.c (select_source_symtab)
13901         (forget_cached_source_info_for_objfile): Update.
13902         * objfiles.h (class objfile_compunits): Remove.
13903         (struct objfile) <compunits_range>: New typedef.
13904         (compunits): New method.
13905         * objfiles.c (objfile_relocate1): Update.
13906         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
13907         * maint.c (count_symtabs_and_blocks): Update.
13908         * linespec.c (iterate_over_all_matching_symtabs): Update.
13909         * cp-support.c (add_symbol_overload_list_qualified): Update.
13910         * coffread.c (coff_symtab_read): Update.
13911         * ada-lang.c (add_nonlocal_symbols)
13912         (ada_collect_symbol_completion_matches)
13913         (ada_add_global_exceptions): Update.
13914
13915 2019-01-15  Tom Tromey  <tom@tromey.com>
13916
13917         * progspace.h (program_space) <objfiles_safe_range>: New
13918         typedef.
13919         <objfiles_safe>: New method.
13920         * objfiles.h (class all_objfiles_safe): Remove.
13921         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
13922         * jit.c (jit_inferior_exit_hook): Update.
13923
13924 2019-01-17  Tom Tromey  <tom@tromey.com>
13925
13926         * progspace.h (program_space) <objfiles_range>: New typedef.
13927         <objfiles>: New method.
13928         <objfiles_head>: Rename from objfiles.
13929         (object_files): Update.
13930         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
13931         * guile/scm-pretty-print.c
13932         (ppscm_find_pretty_printer_from_objfiles): Update.
13933         * guile/scm-objfile.c (gdbscm_objfiles): Update.
13934         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
13935         Update.
13936         * python/py-progspace.c (pspy_get_objfiles): Update.
13937         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
13938         Update.
13939         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
13940         (objfpy_lookup_objfile_by_build_id): Update.
13941         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
13942         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
13943         Update.
13944         * symtab.c (iterate_over_symtabs, matching_obj_sections)
13945         (expand_symtab_containing_pc, lookup_objfile_from_block)
13946         (lookup_static_symbol, basic_lookup_transparent_type)
13947         (find_pc_sect_compunit_symtab, find_symbol_at_address)
13948         (find_line_symtab, info_sources_command)
13949         (default_collect_symbol_completion_matches_break_on)
13950         (make_source_files_completion_list, find_main_name): Update.
13951         * symmisc.c (print_symbol_bcache_statistics)
13952         (print_objfile_statistics, maintenance_print_symbols)
13953         (maintenance_print_msymbols, maintenance_print_objfiles)
13954         (maintenance_info_symtabs, maintenance_check_symtabs)
13955         (maintenance_expand_symtabs, maintenance_info_line_tables):
13956         Update.
13957         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
13958         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
13959         (map_overlay_command, unmap_overlay_command)
13960         (simple_overlay_update, expand_symtabs_matching)
13961         (map_symbol_filenames): Update.
13962         * symfile-debug.c (set_debug_symfile): Update.
13963         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
13964         Update.
13965         * source.c (select_source_symtab, forget_cached_source_info):
13966         Update.
13967         * solib.c (solib_read_symbols): Update.
13968         * solib-spu.c (append_ocl_sos): Update.
13969         * psymtab.c (maintenance_print_psymbols)
13970         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
13971         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
13972         * printcmd.c (info_symbol_command): Update.
13973         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
13974         Update.
13975         * objfiles.h (class all_objfiles): Remove.
13976         * objfiles.c (have_partial_symbols, have_full_symbols)
13977         (have_minimal_symbols, qsort_cmp, update_section_map)
13978         (shared_objfile_contains_address_p)
13979         (default_iterate_over_objfiles_in_search_order): Update.
13980         * objc-lang.c (info_selectors_command, info_classes_command)
13981         (find_methods): Update.
13982         * minsyms.c (find_solib_trampoline_target): Update.
13983         * maint.c (maintenance_info_sections)
13984         (maintenance_translate_address, count_symtabs_and_blocks):
13985         Update.
13986         * main.c (captured_main_1): Update.
13987         * linux-thread-db.c (try_thread_db_load_from_pdir)
13988         (has_libpthread): Update.
13989         * linespec.c (iterate_over_all_matching_symtabs)
13990         (search_minsyms_for_name): Update.
13991         * jit.c (jit_find_objf_with_entry_addr): Update.
13992         * hppa-tdep.c (find_unwind_entry)
13993         (hppa_lookup_stub_minimal_symbol): Update.
13994         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
13995         Update.
13996         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
13997         (elf_gnu_ifunc_resolve_by_got): Update.
13998         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
13999         * dwarf-index-write.c (save_gdb_index_command): Update.
14000         * cp-support.c (add_symbol_overload_list_qualified): Update.
14001         * breakpoint.c (create_overlay_event_breakpoint)
14002         (create_longjmp_master_breakpoint)
14003         (create_std_terminate_master_breakpoint)
14004         (create_exception_master_breakpoint): Update.
14005         * blockframe.c (find_pc_partial_function): Update.
14006         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
14007         (ada_collect_symbol_completion_matches)
14008         (ada_add_global_exceptions): Update.
14009
14010 2019-01-17  Tom Tromey  <tom@tromey.com>
14011
14012         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
14013         declare VEC.
14014         (solib_target_parse_libraries): Change return type.
14015         (library_list_start_segment, library_list_start_section)
14016         (library_list_end_library, library_list_start_library); Update.
14017         (solib_target_free_library_list): Remove.
14018         (solib_target_parse_libraries): Remove cleanup.  Change return
14019         type.
14020         (solib_target_current_sos): Update.
14021
14022 2019-01-17  Tom Tromey  <tromey@bapiya>
14023
14024         * valprint.c: Replace "the the" with "the".
14025         * symtab.c: Replace "the the" with "the".
14026         * solib.c: Replace "the the" with "the".
14027         * solib-dsbt.c: Replace "the the" with "the".
14028         * linespec.c: Replace "the the" with "the".
14029         * dwarf2loc.h: Replace "the the" with "the".
14030         * amd64-windows-tdep.c: Replace "the the" with "the".
14031         * aarch64-tdep.c: Replace "the the" with "the".
14032
14033 2019-01-16  Keith Seitz  <keiths@redhat.com>
14034
14035         PR gdb/23773
14036         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
14037         <builder>: Rename to ..
14038         <m_builder>: ... this and make private.
14039         (dwarf2_cu::get_builder): New method.  Change all users of
14040         `builder' to use this method.
14041         (dwarf2_start_symtab): Move to ...
14042         (dwarf2_cu::start_symtab): ... here.  Update all callers
14043         (setup_type_unit_groups): Move to ...
14044         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
14045         callers.
14046         (dwarf2_cu::reset_builder): New method.
14047         (process_full_compunit, process_full_type_unit): Use
14048         dwarf2_cu::reset_builder.
14049         (follow_die_offset): Record the ancestor CU if it is different
14050         from the followed DIE's CU.
14051         (follow_die_sig_1): Likewise.
14052
14053 2019-01-15  Tom Tromey  <tom@tromey.com>
14054
14055         * remote.c (class remote_state) <buf>: Now a char_vector.
14056         <buf_size>: Remove.
14057         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
14058         parameter.
14059         (remote_target::getpkt_or_notif_sane_1)
14060         (remote_target::getpkt_sane)
14061         (remote_target::getpkt_or_notif_sane): Likewise.
14062         (class remote_target) <putpkt>: New overload.
14063         (remote_target::read_frame): Change type of "buf_p".  Remove
14064         sizeof_p parameter.
14065         (packet_ok): New overload.
14066         (packet_check_result): New overload.
14067         Update all uses.
14068
14069 2019-01-14  Tom Tromey  <tom@tromey.com>
14070
14071         * remote-notif.c (handle_notification, remote_notif_ack)
14072         (remote_notif_parse): Make "buf" const.
14073         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
14074         const.
14075         (remote_notif_parse, remote_notif_ack, handle_notification):
14076         Likewise.
14077         * remote.c (remote_notif_stop_parse): Make "buf" const.
14078         (remote_target::remote_parse_stop_reply): Make "buf" const.
14079         (remote_notif_stop_ack): Make "buf" const.
14080
14081 2019-01-14  Tom Tromey  <tom@tromey.com>
14082
14083         * remote.c (remote_console_output): Make parameter const.
14084
14085 2019-01-14  Tom Tromey  <tom@tromey.com>
14086
14087         * target-debug.h (target_debug_print_signals): Constify.
14088         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
14089         * procfs.c (procfs_target::pass_signals): Update.
14090         * linux-nat.c (linux_nat_target::pass_signals): Update.
14091         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
14092         * target-delegates.c: Rebuild.
14093         * remote.c (remote_target::program_signals): Update.
14094         (remote_target::pass_signals): Update.
14095         * target.c (target_pass_signals): Constify argument.
14096         (target_program_signals): Likewise.
14097         * target.h (struct target_ops) <pass_signals, program_signals>:
14098         Constify argument.
14099         (target_pass_signals, target_program_signals): Constify argument.
14100
14101 2019-01-14  Tom Tromey  <tom@tromey.com>
14102
14103         PR tui/28819:
14104         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
14105
14106 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
14107
14108         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
14109         field.
14110         * rs6000-tdep.c: Include reggroups.h.
14111         (IS_V_ALIAS_PSEUDOREG): Define.
14112         (rs6000_register_name): Return names for the "vX" aliases.
14113         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
14114         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
14115         aliases.  Call default_register_reggroup_p for all other
14116         pseudo-registers.
14117         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
14118         New functions.
14119         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
14120         Handle "vX" aliases.
14121         (v_alias_pseudo_register_collect): New function.
14122         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
14123         (rs6000_gdbarch_init): Initialize "vX" aliases as
14124         pseudo-registers.  Restore registration of
14125         rs6000_pseudo_register_reggroup_p with
14126         set_tdesc_pseudo_register_reggroup_p.
14127
14128 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
14129
14130         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
14131         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
14132         set_gdbarch_num_pseudo_regs.
14133
14134 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14135
14136         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
14137         Remove arg prefixname, add do_set and do_show.
14138         Add member functions set_list and show_list.
14139         * cli/cli-style.c (class cli_style_option): Update accordingly.
14140         (style_set_list): Move to file scope.
14141         (style_show_list): Likewise.
14142         (set_style): Call help_list.
14143         (show_style): Call cmd_show_list.
14144         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
14145         Update to use the new macro.
14146
14147 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
14148
14149         * ada-lang.c (_initialize_ada_language): Expand the help text
14150         for the "catch exception" command.
14151
14152 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14153
14154         * symtab.c (matching_obj_sections): Initialize obj,
14155         declare it closer to its usage.
14156
14157 2019-01-10  Tom Tromey  <tom@tromey.com>
14158
14159         * thread-iter.h (inf_threads_iterator): Use next_iterator.
14160         (basic_inf_threads_range): Remove.
14161         (inf_threads_range, inf_non_exited_threads_range)
14162         (safe_inf_threads_range): Use next_adapter.
14163
14164 2019-01-10  Keith Seitz  <keiths@redhat.com>
14165
14166         PR gdb/23712
14167         PR symtab/23010
14168         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
14169         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
14170
14171 2019-01-10  Keith Seitz  <keiths@redhat.com>
14172
14173         PR gdb/23712
14174         PR symtab/23010
14175         * dictionary.c (pending_to_vector): Remove.
14176         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
14177         Remove _1 suffix, replacing functions of the same name.  Update
14178         all callers.
14179         (dict_create_hashed, dict_create_hashed_expandable)
14180         (dict_create_linear, dict_create_linear_expandable, dict_free)
14181         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
14182         Make functions static.
14183
14184 2019-01-10  Keith Seitz  <keiths@redhat.com>
14185
14186         PR gdb/23712
14187         PR symtab/23010
14188         * dictionary.h (struct dictionary): Replace declaration with
14189         multidictionary.
14190         (dict_create_hashed, dict_create_hashed_expandable)
14191         (dict_create_linear, dict_create_linear_expandable)
14192         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
14193         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
14194         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
14195         taking multidictionary argument.
14196         [ALL_DICT_SYMBOLS]: Update for multidictionary.
14197         * block.h (struct block) <dict>: Change to multidictionary
14198         and rename `multidict'.
14199         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
14200         symmisc.c: Update all dictionary references to multidictionary.
14201
14202 2019-01-10  Keith Seitz  <keiths@redhat.com>
14203
14204         PR gdb/23712
14205         PR symtab/23010
14206         * dictionary.c: Include unordered_map.
14207         (pending_to_vector): New function.
14208         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
14209         Rewrite the non-"_1" functions to take vector instead
14210         of linked list.
14211         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
14212         "new" _1 versions of the same name.
14213         (multidictionary): Define.
14214         (std::hash<enum language): New definition.
14215         (collate_pending_symbols_by_language, mdict_create_hashed)
14216         (mdict_create_hashed_expandable, mdict_create_linear)
14217         (mdict_create_linear_expandable, mdict_free)
14218         (find_language_dictionary, create_new_language_dictionary)
14219         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
14220         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
14221         (mdict_size, mdict_empty): New functions.
14222         * dictionary.h (mdict_iterator): Define.
14223
14224 2019-01-10  Pedro Alves  <palves@redhat.com>
14225
14226         * breakpoint.c (read_uploaded_action)
14227         (create_tracepoint_from_upload): Adjust to use
14228         gdb::unique_xmalloc_ptr.
14229         * ctf.c (ctf_write_uploaded_tp):
14230         (SET_ARRAY_FIELD): Use emplace_back.
14231         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
14232         * tracefile-tfile.c (tfile_write_uploaded_tp):
14233         * tracepoint.c (parse_tracepoint_definition): Adjust to use
14234         gdb::unique_xmalloc_ptr.
14235         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
14236         at_string, cond_string, cmd_strings>: Replace char pointers
14237         with gdb::unique_xmalloc_ptr.
14238
14239 2019-01-10  Pedro Alves  <palves@redhat.com>
14240
14241         * solib-target.c (library_list_start_library): Don't xstrdup name.
14242
14243 2019-01-10  Pedro Alves  <palves@redhat.com>
14244
14245         * mdebugread.c (parse_partial_symbols): Use
14246         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
14247
14248 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
14249
14250         * linux-fork.c (scoped_switch_fork_info)
14251         <~scoped_switch_fork_info>: Fix incorrect variable name.
14252
14253 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
14254
14255         * linux-fork.c (scoped_switch_fork_info)
14256         <scoped_switch_fork_info>: Make explicit.
14257         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
14258
14259 2019-01-10  Tom Tromey  <tom@tromey.com>
14260
14261         * objfiles.h (objfile::reset_psymtabs): Update.
14262         * objfiles.c (objfile::objfile): Update.
14263         * psymtab.h (psymtab_storage::obstack): Update.
14264         (psymtab_storage::m_obstack): Use gdb::optional.
14265         (class psymtab_storage): Update comment.  Remove objfile
14266         parameter.
14267         * psymtab.c (psymtab_storage::psymtab_storage): Update.
14268
14269 2019-01-10  Tom Tromey  <tom@tromey.com>
14270
14271         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
14272         <free_psymtabs>: Now private.
14273         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
14274         (allocate_psymtab): Use new method.
14275
14276 2019-01-10  Tom Tromey  <tom@tromey.com>
14277
14278         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
14279         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
14280         * mdebugread.c (parse_partial_symbols): Use
14281         allocate_dependencies.
14282         * dwarf2read.c (dwarf2_create_include_psymtab): Use
14283         allocate_dependencies.
14284         (process_psymtab_comp_unit_reader)
14285         (build_type_psymtab_dependencies): Likewise.
14286         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
14287
14288 2019-01-10  Tom Tromey  <tom@tromey.com>
14289
14290         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
14291         PSYMBOL_SET_LANGUAGE.
14292         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
14293
14294 2019-01-10  Tom Tromey  <tom@tromey.com>
14295
14296         * psymtab.h (psymtab_storage::obstack): New method.
14297         <m_obstack>: Rename from obstack; now private.
14298         * psymtab.c (psymtab_storage): Update.
14299         * dwarf2read.c (create_addrmap_from_index)
14300         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
14301         Update.
14302
14303 2019-01-10  Tom Tromey  <tom@tromey.com>
14304
14305         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
14306         * objfiles.h (objfile::reset_psymtabs): New method.
14307
14308 2019-01-10  Tom Tromey  <tom@tromey.com>
14309
14310         * symmisc.c (print_symbol_bcache_statistics): Update.
14311         (print_objfile_statistics): Update.
14312         * symfile.c (reread_symbols): Update.
14313         * psymtab.h (class psymtab_storage): New.
14314         * psymtab.c (psymtab_storage): New constructor.
14315         (~psymtab_storage): New destructor.
14316         (require_partial_symbols): Update.
14317         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
14318         (find_pc_sect_psymtab, find_pc_sect_psymbol)
14319         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
14320         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
14321         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
14322         (start_psymtab_common, end_psymtab_common)
14323         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
14324         (allocate_psymtab): Update.
14325         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
14326         Update.
14327         (dump_psymtab_addrmap, maintenance_print_psymbols)
14328         (maintenance_check_psymtabs): Update.
14329         (class objfile_psymtabs): Move to objfiles.h.
14330         * psympriv.h (discard_psymtab): Now inline.
14331         (psymtab_discarder::psymtab_discarder): Update.
14332         (psymtab_discarder::~psymtab_discarder): Update.
14333         (ALL_OBJFILE_PSYMTABS): Rewrite.
14334         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
14335         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
14336         Remove fields.
14337         <partial_symtabs>: New field.
14338         (class objfile_psymtabs): Move from psymtab.h.  Update.
14339         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
14340         psymbol_cache.
14341         (objfile::~objfile): Don't destroy psymbol_cache.
14342         * mdebugread.c (parse_partial_symbols): Update.
14343         * dwarf2read.c (create_addrmap_from_index)
14344         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
14345         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
14346         (add_partial_subprogram, dwarf2_ranges_read): Update.
14347         * dwarf-index-write.c (write_address_map)
14348         (write_one_signatured_type, recursively_write_psymbols)
14349         (class debug_names, class debug_names, write_psymtabs_to_index):
14350         Update.
14351
14352 2019-01-10  Tom Tromey  <tom@tromey.com>
14353
14354         * symtab.h (SYMBOL_SET_NAMES): Update.
14355         (symbol_set_names): Update.
14356         (MSYMBOL_SET_NAMES): Update.
14357         * symtab.c (symbol_set_names): Change argument to be an
14358         objfile_per_bfd_storage.
14359         * psymtab.c (add_psymbol_to_bcache): Update.
14360         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
14361
14362 2019-01-10  Tom Tromey  <tom@tromey.com>
14363
14364         * symtab.c (create_demangled_names_hash): Change argument to be an
14365         objfile_per_bfd_storage.
14366         (symbol_set_names): Update.
14367
14368 2019-01-10  Tom Tromey  <tom@tromey.com>
14369
14370         * xcoffread.c (xcoff_initial_scan): Unconditionally call
14371         init_psymbol_list.
14372         * psymtab.c (init_psymbol_list): Do nothing if already called.
14373         * psympriv.h (init_psymbol_list): Add comment.
14374         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
14375         init_psymbol_list.
14376         * dbxread.c (dbx_symfile_read): Unconditionally call
14377         init_psymbol_list.
14378
14379 2019-01-10  Tom Tromey  <tom@tromey.com>
14380
14381         * xcoffread.c (scan_xcoff_symtab): Update.
14382         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
14383         "where".
14384         * mdebugread.c (parse_partial_symbols)
14385         (handle_psymbol_enumerators): Update.
14386         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
14387         * dbxread.c (read_dbx_symtab): Update.
14388         * psympriv.h (psymbol_placement): New enum.
14389         (add_psymbol_to_list): Update.
14390
14391 2019-01-10  Tom Tromey  <tom@tromey.com>
14392
14393         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
14394         static_psymbols parameters.
14395         (scan_xcoff_symtab): Update.
14396         * psymtab.c (start_psymtab_common): Remove global_psymbols and
14397         static_psymbols parameters.
14398         * psympriv.h (start_psymtab_common): Update.
14399         * mdebugread.c (parse_partial_symbols): Update.
14400         * dwarf2read.c (create_partial_symtab): Update.
14401         * dbxread.c (read_dbx_symtab): Update.
14402         (start_psymtab): Remove global_psymbols and static_psymbols
14403         parameters.
14404
14405 2019-01-10  Tom Tromey  <tom@tromey.com>
14406
14407         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
14408         * psymtab.c (allocate_psymtab): Add comment.
14409         * psympriv.h (allocate_psymtab): Add comment.
14410         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
14411         initializations.
14412         * dbxread.c (dbx_end_psymtab): Remove some initializations.
14413
14414 2019-01-10  Tom Tromey  <tom@tromey.com>
14415
14416         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
14417         Don't declare.
14418         * mipsread.c: Include mdebugread.h.
14419         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
14420         Declare.
14421         * elfread.c: Include mdebugread.h.
14422
14423 2019-01-09  Tom Tromey  <tom@tromey.com>
14424
14425         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
14426         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
14427         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
14428         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
14429         (psym_lookup_symbol, psym_find_last_source_symtab)
14430         (psym_forget_cached_source_info, psym_print_stats)
14431         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
14432         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
14433         (psym_map_matching_symbols, psym_expand_symtabs_matching)
14434         (psym_find_compunit_symtab_by_address)
14435         (maintenance_print_psymbols, maintenance_info_psymtabs)
14436         (maintenance_check_psymtabs): Use ranged for.
14437         * psymtab.h (class objfile_psymtabs): New.
14438         (require_partial_symbols): Return objfile_psymtabs.
14439         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
14440
14441 2019-01-09  Tom Tromey  <tom@tromey.com>
14442
14443         * symfile.c (overlay_invalidate_all, find_pc_overlay)
14444         (find_pc_mapped_section, list_overlays_command)
14445         (map_overlay_command, unmap_overlay_command)
14446         (simple_overlay_update): Use all_objfiles.
14447         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
14448         * printcmd.c (info_symbol_command): Use all_objfiles.
14449         * objfiles.h (ALL_OBJSECTIONS): Remove.
14450         * maint.c (maintenance_translate_address): Use all_objfiles.
14451         * gcore.c (gcore_create_callback): Use all_objfiles.
14452         (objfile_find_memory_regions): Likewise.
14453
14454 2019-01-09  Tom Tromey  <tom@tromey.com>
14455
14456         * symtab.c (find_line_symtab, info_sources_command)
14457         (make_source_files_completion_list): Use objfile_compunits.
14458         * source.c (select_source_symtab): Use objfile_compunits.
14459         * objfiles.h (struct objfile): Update comment.
14460         (ALL_OBJFILES): Remove.
14461         (ALL_FILETABS): Remove.
14462         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
14463         objfile_compunits.
14464
14465 2019-01-09  Tom Tromey  <tom@tromey.com>
14466
14467         * symmisc.c (print_objfile_statistics, dump_objfile)
14468         (maintenance_print_symbols): Use compunit_filetabs.
14469         * source.c (forget_cached_source_info_for_objfile): Use
14470         compunit_filetabs.
14471         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
14472         (ALL_FILETABS): Use compunit_filetabs.
14473         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
14474         * coffread.c (coff_symtab_read): Use compunit_filetabs.
14475
14476 2019-01-09  Tom Tromey  <tom@tromey.com>
14477
14478         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
14479         (compunit_filetabs): New.
14480         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
14481         compunit_filetabs.
14482         (info_sources_command, make_source_files_completion_list): Remove
14483         declaration.
14484         * symmisc.c (print_objfile_statistics, dump_objfile)
14485         (maintenance_print_symbols): Remove declaration.
14486         (maintenance_info_symtabs): Use compunit_filetabs.
14487         (maintenance_info_line_tables): Likewise.
14488         * source.c (select_source_symtab): Change local variable name.
14489         (forget_cached_source_info_for_objfile): Remove declaration.
14490         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
14491         * objfiles.c (objfile_relocate1): Remove declaration.
14492         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
14493         declaration.
14494         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
14495         * coffread.c (coff_symtab_read): Remove declaration.
14496         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
14497         compunit_filetabs.
14498
14499 2019-01-09  Tom Tromey  <tom@tromey.com>
14500
14501         * symtab.c (lookup_objfile_from_block)
14502         (find_pc_sect_compunit_symtab, search_symbols)
14503         (default_collect_symbol_completion_matches_break_on): Use
14504         objfile_compunits.
14505         * objfiles.h (ALL_COMPUNITS): Remove.
14506         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
14507         * cp-support.c (add_symbol_overload_list_qualified): Use
14508         objfile_compunits.
14509         * ada-lang.c (ada_collect_symbol_completion_matches)
14510         (ada_add_global_exceptions): Use objfile_compunits.
14511
14512 2019-01-09  Tom Tromey  <tom@tromey.com>
14513
14514         * source.c (select_source_symtab)
14515         (forget_cached_source_info_for_objfile): Remove declaration.
14516         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
14517         declaration.
14518         * maint.c (count_symtabs_and_blocks): Remove declaration.
14519         * cp-support.c (add_symbol_overload_list_qualified): Remove
14520         declaration.
14521         * coffread.c (coff_symtab_read): Remove declaration.
14522         * symtab.c (lookup_symbol_in_objfile_symtabs)
14523         (basic_lookup_transparent_type_1): Use objfile_compunits.
14524         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
14525         (info_sources_command, search_symbols)
14526         (default_collect_symbol_completion_matches_break_on)
14527         (make_source_files_completion_list): Remove declaration.
14528         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
14529         (ada_collect_symbol_completion_matches)
14530         (ada_add_global_exceptions): Remove declaration.
14531         * linespec.c (iterate_over_all_matching_symtabs): Use
14532         objfile_compunits.
14533         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
14534         (class objfile_compunits): New.
14535         (ALL_COMPUNITS): Use objfile_compunits.
14536         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
14537         (maintenance_check_symtabs, maintenance_info_line_tables): Use
14538         objfile_compunits.
14539         * objfiles.c (objfile_relocate1): Use objfile_compunits.
14540
14541 2019-01-09  Tom Tromey  <tom@tromey.com>
14542
14543         * symtab.c (search_symbols)
14544         (default_collect_symbol_completion_matches_break_on): Use
14545         objfile_msymbols.
14546         * ada-lang.c (ada_lookup_simple_minsym)
14547         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
14548         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
14549         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
14550         objfile_msymbols.
14551         * coffread.c (coff_symfile_read): Use objfile_msymbols.
14552         * symmisc.c (dump_msymbols): Use objfile_msymbols.
14553         * objc-lang.c (find_methods): Use objfile_msymbols.
14554         (info_selectors_command, info_classes_command): Likewise.
14555         * stabsread.c (scan_file_globals): Use objfile_msymbols.
14556         * objfiles.h (class objfile_msymbols): New.
14557         (ALL_OBJFILE_MSYMBOLS): Remove.
14558         (ALL_MSYMBOLS): Remove.
14559
14560 2019-01-09  Tom Tromey  <tom@tromey.com>
14561
14562         * common/next-iterator.h (next_adapter): Add Iterator template
14563         parameter.
14564         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
14565         (class all_objfiles_safe): New.
14566         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
14567         * objfiles.c (put_objfile_before): Update comment.
14568         (add_separate_debug_objfile): Likewise.
14569         (free_all_objfiles): Use all_objfiles_safe.
14570         (objfile_purge_solibs): Likewise.
14571
14572 2019-01-09  Tom Tromey  <tom@tromey.com>
14573
14574         * symtab.c (iterate_over_symtabs, matching_obj_sections)
14575         (expand_symtab_containing_pc, lookup_static_symbol)
14576         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
14577         (find_symbol_at_address, find_line_symtab, find_main_name): Use
14578         all_objfiles.
14579         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
14580         * breakpoint.c (create_overlay_event_breakpoint)
14581         (create_longjmp_master_breakpoint)
14582         (create_std_terminate_master_breakpoint)
14583         (create_exception_master_breakpoint): Use all_objfiles.
14584         * linux-thread-db.c (try_thread_db_load_from_pdir)
14585         (has_libpthread): Use all_objfiles.
14586         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
14587         * linespec.c (iterate_over_all_matching_symtabs)
14588         (search_minsyms_for_name): Use all_objfiles.
14589         * maint.c (maintenance_info_sections): Use all_objfiles.
14590         * main.c (captured_main_1): Use all_objfiles.
14591         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
14592         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
14593         * guile/scm-pretty-print.c
14594         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
14595         * solib-spu.c (append_ocl_sos): Use all_objfiles.
14596         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
14597         (maintenance_print_msymbols): Use all_objfiles.
14598         * source.c (select_source_symtab): Use all_objfiles.
14599         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
14600         * symfile.c (remove_symbol_file_command)
14601         (expand_symtabs_matching, map_symbol_filenames): Use
14602         all_objfiles.
14603         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
14604         all_objfiles.
14605         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
14606         * objc-lang.c (find_methods): Use all_objfiles.
14607         * objfiles.c (have_partial_symbols, have_full_symbols)
14608         (have_minimal_symbols, qsort_cmp)
14609         (default_iterate_over_objfiles_in_search_order): Use
14610         all_objfiles.
14611         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
14612         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
14613         (maintenance_check_psymtabs): Use all_objfiles.
14614         (ALL_PSYMTABS): Remove.
14615         * compile/compile-object-run.c (do_module_cleanup): Use
14616         all_objfiles.
14617         * blockframe.c (find_pc_partial_function): Use all_objfiles.
14618         * cp-support.c (add_symbol_overload_list_qualified): Use
14619         all_objfiles.
14620         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
14621         Use all_objfiles.
14622         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
14623         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
14624         all_objfiles.
14625         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
14626         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
14627         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
14628         Uses all_objfiles.
14629         * solib.c (solib_read_symbols): Use all_objfiles
14630
14631 2019-01-09  Tom Tromey  <tom@tromey.com>
14632
14633         * probe.c (parse_probes_in_pspace): Use all_objfiles.
14634         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
14635         all_objfiles.
14636         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
14637         * symmisc.c (print_symbol_bcache_statistics)
14638         (print_objfile_statistics, maintenance_print_objfiles)
14639         (maintenance_info_symtabs, maintenance_check_symtabs)
14640         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
14641         all_objfiles.
14642         * source.c (forget_cached_source_info): Use all_objfiles.
14643         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
14644         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
14645         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
14646         * objfiles.c (update_section_map): Use all_objfiles.
14647         (shared_objfile_contains_address_p): Likewise.
14648         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
14649         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
14650
14651 2019-01-09  Tom Tromey  <tom@tromey.com>
14652
14653         * common/next-iterator.h: New file.
14654         * objfiles.h (class all_objfiles): New.
14655         (struct objfile_iterator): New.
14656
14657 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14658
14659         * NEWS: Move the description of the changed "frame", "select-frame",
14660          and "info frame" commands to the Changed commands section.
14661
14662 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
14663
14664         * gdbtypes.c (check_stub_method_group): Remove handling of old
14665         mangling schemes.
14666         * linespec.c (find_methods): Likewise.
14667         * stabsread.c (read_member_functions): Likewise.
14668         * valops.c (search_struct_method): Likewise.
14669         (value_struct_elt_for_reference): Likewise.
14670         * NEWS: Mention this change.
14671
14672 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
14673
14674         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
14675         print_source_lines.
14676         * source.c (print_source_lines_base): Update line number check.
14677         (print_source_lines): New function.
14678         (source_lines_range::source_lines_range): New function.
14679         * source.h (class source_lines_range): New class.
14680         (print_source_lines): New declaration.
14681
14682 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14683
14684         * linespec.c (linespec_state_destructor): Free self->canonical_names.
14685
14686 2019-01-08  Tom Tromey  <tom@tromey.com>
14687             Simon Marchi  <simon.marchi@ericsson.com>
14688
14689         PR gdb/24060
14690         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
14691         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
14692         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
14693         * f-exp.y (DOLLAR_VARIABLE): Likewise.
14694         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
14695         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
14696
14697 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
14698
14699         * source.c (select_source_symtab): Move header comment to
14700         declaration in source.h.
14701         (forget_cached_source_info_for_objfile): Likewise.
14702         (forget_cached_source_info): Likewise.
14703         (identify_source_line): Likewise.
14704         * source.h (identify_source_line): Move declaration from symtab.h
14705         and add comment from source.c
14706         (print_source_lines): Likewise.
14707         (forget_cached_source_info_for_objfile): Likewise.
14708         (forget_cached_source_info): Likewise.
14709         (select_source_symtab): Likewise.
14710         (enum print_source_lines_flag): Move definition from symtab.h.
14711         * symtab.h (identify_source_line): Move declaration to source.h.
14712         (print_source_lines): Likewise.
14713         (forget_cached_source_info_for_objfile): Likewise.
14714         (forget_cached_source_info): Likewise.
14715         (select_source_symtab): Likewise.
14716         (enum print_source_lines_flag): Move definition to source.h.
14717         * tui/tui-hooks.c: Add 'source.h' include.
14718
14719 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
14720
14721         * source.c (print_source_lines_base): Handle requests to print
14722         reverse line number sequences, and guard against empty lines
14723         string.
14724
14725 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
14726
14727         * source.c (print_source_lines_base): Fix skip of '\r' if next
14728         character is '\n'.
14729
14730 2019-01-06  Tom Tromey  <tom@tromey.com>
14731
14732         * c-exp.y (struct c_parse_state) <macro_original_text,
14733         expansion_obstack>: New member.
14734         (macro_original_text, expansion_obstack): Remove globals.
14735         (scan_macro_expansion, scanning_macro_expansion)
14736         (finished_macro_expansion): Update.
14737         (scan_macro_cleanup): Remove.
14738         (yylex, c_parse): Update.
14739
14740 2019-01-06  Tom Tromey  <tom@tromey.com>
14741
14742         * c-exp.y (struct c_parse_state) <strings>: New member.
14743         (operator_stoken): Update.
14744
14745 2019-01-06  Tom Tromey  <tom@tromey.com>
14746
14747         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
14748         (union type_stack_elt) <typelist_val>: Now a pointer to
14749         std::vector.
14750         (type_stack_cleanup): Don't declare.
14751         (push_typelist): Update.
14752         * parse.c (pop_typelist): Return a std::vector.
14753         (push_typelist): Take a std::vector.
14754         (follow_types): Update.  Do not free args.
14755         (type_stack_cleanup): Remove.
14756         * c-exp.y (struct c_parse_state): New.
14757         (cpstate): New global.
14758         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
14759         (nonempty_typelist): Update.
14760         (func_mod): Create a new vector.
14761         (c_parse): Create a c_parse_state.
14762         (check_parameter_typelist): Do not delete params.
14763         (function_method): Update.  Do not delete type_list.
14764
14765 2019-01-06  Tom Tromey  <tom@tromey.com>
14766
14767         PR gdb/28155:
14768         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
14769         check_typedef.
14770         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
14771         (print_return_value): Likewise.
14772
14773 2019-01-05  Tom Tromey  <tom@tromey.com>
14774
14775         * contrib/cleanup_check.py: Remove.
14776         * contrib/gcc-with-excheck: Remove.
14777         * contrib/exsummary.py: Remove.
14778         * contrib/excheck.py: Remove.
14779
14780 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
14781
14782         * thread.c (delete_thread_1): Add gdb_assert that THR is not
14783         NULL. Initialize tpprev to NULL instead of assigning it
14784         to NULL on the next statement.
14785         * windows-nat.c (windows_delete_thread): Remove check for
14786         main_thread_id before printing thread exit notifications.
14787         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
14788         Remove thread ID check against main_thread_id.
14789         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
14790         windows_delete_thread.
14791         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
14792
14793 2019-01-04  Tom Tromey  <tom@tromey.com>
14794
14795         * compile/compile.c (_initialize_compile): Use upper case for
14796         metasyntactic variables.
14797         * symmisc.c (_initialize_symmisc): Use upper case for
14798         metasyntactic variables.
14799         * psymtab.c (_initialize_psymtab): Use upper case for
14800         metasyntactic variables.
14801         * demangle.c (demangle_command): Use upper case for metasyntactic
14802         variables.
14803         (_initialize_demangler): Likewise.
14804         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
14805         variables.
14806
14807 2019-01-03  Tom Tromey  <tom@tromey.com>
14808
14809         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
14810
14811 2019-01-03  Tom Tromey  <tom@tromey.com>
14812
14813         * python/py-symtab.c (salpy_str): Update.
14814         (struct salpy_sal_object) <symtab>: Now a PyObject.
14815         (salpy_dealloc): Update.
14816         (del_objfile_sal): Use gdbpy_ref.
14817
14818 2019-01-03  Tom Tromey  <tom@tromey.com>
14819
14820         * python/py-type.c (convert_field): Use new_reference.  Return
14821         gdbpy_ref.
14822         (make_fielditem): Return gdbpy_ref.
14823         (typy_fields): Update.
14824         (typy_getitem): Update.
14825         (field_name): Return gdbpy_ref.  Use new_reference.
14826         (typy_iterator_iternext): Update.
14827
14828 2019-01-03  Tom Tromey  <tom@tromey.com>
14829
14830         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
14831
14832 2019-01-03  Tom Tromey  <tom@tromey.com>
14833
14834         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
14835         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
14836         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
14837         (pspy_set_frame_filters, pspy_set_frame_unwinders)
14838         (pspy_set_type_printers): Likewise.
14839         * python/py-function.c (fnpy_init): Use gdbpy_ref.
14840         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
14841         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
14842         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
14843         (objfpy_set_type_printers): Likewise.
14844
14845 2019-01-03  Tom Tromey  <tom@tromey.com>
14846
14847         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
14848         (gdbpy_print_stack): Use gdbpy_err_fetch.
14849         * python/python-internal.h (class gdbpy_err_fetch): New class.
14850         (class gdbpy_enter) <m_error_type, m_error_value,
14851         m_error_traceback>: Remove.
14852         <m_error>: New member.
14853         (gdbpy_exception_to_string): Don't declare.
14854         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
14855         * python/py-value.c (convert_value_from_python): Use
14856         gdbpy_err_fetch.
14857         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
14858         gdbpy_exception_to_string.
14859         (gdbpy_handle_exception): Use gdbpy_err_fetch.
14860         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
14861         gdbpy_err_fetch.
14862
14863 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
14864
14865         * linux-nat.c (delete_lwp_cleanup): Delete.
14866         (struct lwp_deleter): New struct.
14867         (lwp_info_up): New typedef.
14868         (linux_nat_target::follow_fork): Delete cleanup, and make use of
14869         lwp_info_up.
14870
14871 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
14872
14873         * linux-fork.c (class scoped_switch_fork_info): New class.
14874         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
14875
14876 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
14877
14878         * valops.c (find_overload_match): Remove use of null_cleanup, and
14879         calls to do_cleanups.
14880
14881 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
14882
14883         * compile/compile-cplus-types.c
14884         (compile_cplus_instance::decl_name): Handle changes to
14885         cp_func_name.
14886         * cp-support.c (cp_func_name): Update header comment, update
14887         return type.
14888         * cp-support.h (cp_func_name): Update return type in declaration.
14889         * valops.c (find_overload_match): Move temp_func local to top
14890         level of function and change its type.  Use temp_func to hold and
14891         delete temporary string obtained from cp_func_name.
14892
14893 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
14894
14895         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
14896         gdb::char_vector, remove cleanup, and update uses of `msg`.
14897
14898 2019-01-03  Jim Wilson  <jimw@sifive.com>
14899
14900         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
14901
14902 2019-01-02  Tom Tromey  <tom@tromey.com>
14903
14904         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
14905         (tdesc_parse_xml): Remove cleanups.
14906         * target-descriptions.h (make_cleanup_free_target_description):
14907         Don't declare.
14908         (target_desc_deleter): New struct.
14909         (target_desc_up): New typedef.
14910         * target-descriptions.c (target_desc_deleter::operator()): Rename
14911         from free_target_description.
14912         (make_cleanup_free_target_description): Remove.
14913
14914 2019-01-02  Tom Tromey  <tom@tromey.com>
14915
14916         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
14917         constructor, destructor.
14918         (linespec_parser): Remove typedef.
14919         (~linespec_parser): Rename from linespec_parser_delete.
14920         (linespec_lex_to_end, linespec_complete_label)
14921         (linespec_complete): Update.
14922         (decode_line_full): Remove cleanups.
14923         (decode_line_1): Update.
14924
14925 2019-01-02  Tom Tromey  <tom@tromey.com>
14926
14927         * python/python-internal.h (inferior_to_inferior_object): Change
14928         return type.
14929         * python/py-exitedevent.c (create_exited_event_object): Update.
14930         * python/py-inferior.c (inferior_to_inferior_object): Return
14931         gdbpy_ref.
14932         (python_new_inferior, python_inferior_deleted)
14933         (thread_to_thread_object, delete_thread_object)
14934         (build_inferior_list, gdbpy_selected_inferior): Update.
14935         * python/py-infthread.c (create_thread_object): Update.  Also fail
14936         if inferior_to_inferior_object fails.
14937
14938 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
14939
14940         * inferior.h (class inferior) <displaced_step_state>: New field.
14941         * infrun.h (struct displaced_step_state): Move here from
14942         infrun.c.  Initialize fields, add constructor.
14943         <inf>: Remove field.
14944         <reset>: New method.
14945         * infrun.c (struct displaced_step_inferior_state): Move to
14946         infrun.h.
14947         (displaced_step_inferior_states): Remove.
14948         (get_displaced_stepping_state): Adust.
14949         (displaced_step_in_progress_any_inferior): Adjust.
14950         (displaced_step_in_progress_thread): Adjust.
14951         (displaced_step_in_progress): Adjust.
14952         (add_displaced_stepping_state): Remove.
14953         (get_displaced_step_closure_by_addr): Adjust.
14954         (remove_displaced_stepping_state): Remove.
14955         (infrun_inferior_exit): Call displaced_step_state.reset.
14956         (use_displaced_stepping): Don't check for NULL.
14957         (displaced_step_prepare_throw): Call
14958         get_displaced_stepping_state.
14959         (displaced_step_fixup): Don't check for NULL.
14960         (prepare_for_detach): Don't check for NULL.
14961
14962 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14963
14964         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
14965          in case of call that did not complete.
14966
14967 2019-01-02  Andrey Utkin  <autkin@undo.io>
14968
14969         * symfile.c (find_separate_debug_file): Fix search of debug files for
14970         remote debuggee.
14971
14972 2019-01-02  Tom Tromey  <tom@tromey.com>
14973
14974         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
14975         indentation.
14976         * python/py-frame.c (frapy_older): Remove cast.
14977         (frapy_newer): Likewise.
14978         * python/py-breakpoint.c (local_setattro): Remove cast.
14979         * python/py-arch.c (archpy_name): Remove local variable.
14980         * python/py-type.c (gdbpy_lookup_type): Remove cast.
14981
14982 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
14983
14984         * unittests/basic_string_view/element_access/char/empty.cc:
14985         Fix year range in copyright header.
14986
14987 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
14988
14989         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
14990         Delete.
14991         <operator==>: Update with for removed field.
14992         <hash>: Likewise.
14993         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
14994         <isa_features>: ...this.
14995         <abi_features>: New field.
14996         (riscv_isa_flen): Update comment.
14997         (riscv_abi_xlen): New declaration.
14998         (riscv_abi_flen): New declaration.
14999         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
15000         isa_features.
15001         (riscv_abi_xlen): New function.
15002         (riscv_isa_flen): Update to get answer from isa_features.
15003         (riscv_abi_flen): New function.
15004         (riscv_has_fp_abi): Update to get answer from abi_features.
15005         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
15006         xlen and flen.
15007         (riscv_call_info) <xlen, flen>: Update comment.
15008         (riscv_call_arg_struct): Remove invalid assertions
15009         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
15010         is removed.
15011         (riscv_gdbarch_init): Gather isa features and abi features
15012         separately, ensure both match on the gdbarch when reusing an old
15013         gdbarch.  Relax an error check to allow 32-bit abi float to run on
15014         a target with 64-bit float hardware.
15015
15016 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
15017
15018         * source.c (search_command_helper): Stop reverse search
15019         when line 1 has been searched.
15020
15021 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
15022
15023         * record-full.c (record_full_base_target::close): Rewrite
15024         record_full_core_buf_list free logic.
15025
15026 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
15027
15028         * break-catch-syscall.c (print_one_catch_syscall): xfree
15029         the last text.
15030
15031 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
15032
15033         * top.c (print_gdb_version): Update Copyright year in version
15034         message.
15035
15036 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
15037
15038         Update copyright year range in all GDB files.
15039
15040 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
15041
15042         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
15043
15044 For older changes see ChangeLog-2018.
15045 \f
15046 Local Variables:
15047 mode: change-log
15048 left-margin: 8
15049 fill-column: 74
15050 version-control: never
15051 coding: utf-8
15052 End:
15053