gdb/ChangeLog

   1 2019-11-18  Sergio Durigan Junior  <sergiodj@redhat.com>
   2             Pedro Alves  <palves@redhat.com>
   3
   4         https://bugzilla.redhat.com/show_bug.cgi?id=1765117
   5         * target.c (target_stack::push): Call 'unpush' if there's a
   6         target on top of the stack.
   7
   8 2019-11-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
   9
  10         * python/py-block.c (blpy_dealloc): Call tp_free.
  11         (blpy_block_syms_dealloc): Likewise.
  12         * python/py-finishbreakpoint.c (bpfinishpy_dealloc): Likewise.
  13         * python/py-inferior.c (infpy_dealloc): Likewise.
  14         * python/py-lazy-string.c (stpy_dealloc): Likewise.
  15         * python/py-linetable.c (ltpy_iterator_dealloc): Likewise.
  16         * python/py-symbol.c (sympy_dealloc): Likewise.
  17         * python/py-symtab.c (stpy_dealloc): Likewise.
  18         * python/py-type.c (typy_iterator_dealloc): Likewise.
  19
  20 2019-11-18  Christian Biesinger  <cbiesinger@google.com>
  21
  22         * symtab.h (struct symbol) <owner>: Initialize explicitly in the
  23         constructor instead of using a class initializer.
  24
  25 2019-11-15  Christian Biesinger  <cbiesinger@google.com>
  26
  27         * Makefile.in: Replace {posix,mingw}-strerror.c with safe-strerror.c.
  28         * configure: Regenerate.
  29         * configure.ac: Don't source common.host.
  30         * gdbsupport/common.host: Remove.
  31         * gdbsupport/mingw-strerror.c: Remove.
  32         * gdbsupport/posix-strerror.c: Rename to...
  33         * gdbsupport/safe-strerror.c: ...this.
  34
  35 2019-11-15  Christian Biesinger  <cbiesinger@google.com>
  36
  37         * maint.c (scoped_command_stats::print_time): Use localtime_r
  38         instead of localtime (provided through gnulib if necessary).
  39         * nat/linux-osdata.c (time_from_time_t): Use ctime_r instead
  40         of ctime.
  41
  42 2019-11-15  Christian Biesinger  <cbiesinger@google.com>
  43
  44         * gdbsupport/common-defs.h: Include time.h before pathmax.h to
  45         avoid compile errors.
  46
  47 2019-11-15  Christian Biesinger  <cbiesinger@google.com>
  48
  49         * config.in: Regenerate.
  50         * configure: Regenerate.
  51         * gdbsupport/common.m4: No longer check for strerror_r.
  52         * gdbsupport/posix-strerror.c (safe_strerror): Always call the
  53         POSIX version of strerror_r, now that gnulib provides it if
  54         necessary.
  55
  56 2019-11-14  Christian Biesinger  <cbiesinger@google.com>
  57
  58         * README (`configure' options): Update.
  59
  60 2019-11-14  Tom Tromey  <tromey@adacore.com>
  61
  62         * eval.c (evaluate_subexp_standard) <BINOP_ASSIGN>: Do not pass an
  63         expected type for the RHS if the LHS is a convenience variable.
  64
  65 2019-11-14  Simon Marchi  <simon.marchi@polymtl.ca>
  66
  67         * unittests/vec-utils-selftests.c (unordered_remove_tests::obj):
  68         Provide explicit default and copy constructor.
  69
  70 2019-11-14  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
  71
  72         * python/py-finishbreakpoint.c (gdbpy_breakpoint_created):
  73         only call Py_INCREF (newbp) in the bppy_pending_object case.
  74
  75 2019-11-13  Tom Tromey  <tromey@adacore.com>
  76
  77         PR build/25182:
  78         * psympriv.h (partial_symbol): Remove static assert.
  79         * symtab.h (general_symbol_info, symbol): Remove static assert.
  80
  81 2019-11-12  Andrew Burgess  <andrew.burgess@embecosm.com>
  82
  83         * gdbsupport/format.c (format_pieces::format_pieces): Support
  84         printf 'z' size modifier.
  85         * gdbsupport/format.h (enum argclass): Add size_t_arg.
  86         * printcmd.c (ui_printf):  Handle size_t_arg.
  87         * ui-out.c (ui_out::vmessage): Likewise.
  88         * unittests/format_pieces-selftests.c (test_format_int_sizes): New
  89         function.
  90         (run_tests): Call test_format_int_sizes.
  91
  92 2019-11-12  Christian Biesinger  <cbiesinger@google.com>
  93
  94         * ada-exp.y (write_ambiguous_var): Update.
  95         * buildsym.c (add_symbol_to_list): Update.
  96         * dwarf2read.c (read_variable): Update.
  97         (new_symbol): Update.
  98         * jit.c (finalize_symtab): Update.
  99         * language.c (language_alloc_type_symbol): Update.
 100         * symtab.c (fixup_symbol_section): Update.
 101         (initialize_objfile_symbol_1): Move code to...
 102         (initialize_objfile_symbol): ...here. Remove now-unnecessary memset.
 103         (allocate_symbol): Update.
 104         (allocate_template_symbol): Update.
 105         (get_symbol_address): Update.
 106         * symtab.h (struct symbol): Inherit from general_symbol_info instead
 107         of having as a field, and add a constructor.
 108         (SYMBOL_VALUE): Update.
 109         (SYMBOL_VALUE_ADDRESS): Update.
 110         (SET_SYMBOL_VALUE_ADDRESS): Update.
 111         (SYMBOL_VALUE_BYTES): Update.
 112         (SYMBOL_VALUE_COMMON_BLOCK): Update.
 113         (SYMBOL_BLOCK_VALUE): Update.
 114         (SYMBOL_VALUE_CHAIN): Update.
 115         (SYMBOL_LANGUAGE): Update.
 116         (SYMBOL_SECTION): Update.
 117         (SYMBOL_OBJ_SECTION): Update.
 118         (SYMBOL_SET_LANGUAGE): Update.
 119         (SYMBOL_SET_LINKAGE_NAME): Update.
 120         (SYMBOL_SET_NAMES): Update.
 121         (SYMBOL_NATURAL_NAME): Update.
 122         (SYMBOL_LINKAGE_NAME): Update.
 123         (SYMBOL_DEMANGLED_NAME): Update.
 124         (SYMBOL_SEARCH_NAME): Update.
 125         (SYMBOL_MATCHES_SEARCH_NAME): Update.
 126         (struct symbol): Update.
 127         (struct template_symbol): Update.
 128         (struct rust_vtable_symbol): Update.
 129         * xcoffread.c (SYMBOL_DUP): Update.
 130
 131 2019-11-12  Tom Tromey  <tom@tromey.com>
 132
 133         * tui/tui-layout.c (show_layout): Set current_layout.
 134         (show_source_disasm_command, show_data)
 135         (show_source_or_disasm_and_command): Don't set current_layout.
 136
 137 2019-11-12  Tom Tromey  <tom@tromey.com>
 138
 139         * tui/tui-layout.c (_initialize_tui_layout): Move to end.
 140
 141 2019-11-12  Tom Tromey  <tom@tromey.com>
 142
 143         * tui/tui-win.c (resize_message): New global.
 144         (show_tui_resize_message): New function.
 145         (tui_async_resize_screen): Print message if requested.
 146         (_initialize_tui_win): Add tui-resize-message setting.
 147         * NEWS: Add entry for new commands.
 148
 149 2019-11-11  Tom Tromey  <tom@tromey.com>
 150
 151         * tui/tui.c (tui_initialize_readline): Add new bindable readline
 152         functions.
 153
 154 2019-11-11  Christian Biesinger  <cbiesinger@google.com>
 155
 156         * nat/linux-osdata.c (user_from_uid): Use getpwuid_r.
 157
 158 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
 159
 160         * python/py-symbol.c (gdbpy_lookup_static_symbols): New
 161         function.
 162         * python/python-internal.h (gdbpy_lookup_static_symbols):
 163         Declare new function.
 164         * python/python.c (python_GdbMethods): Add
 165         gdb.lookup_static_symbols method.
 166         * NEWS: Mention gdb.lookup_static_symbols.
 167
 168 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
 169
 170         * python/py-symbol.c (gdbpy_lookup_static_symbol): Lookup in
 171         static block of current object file first.  Also fix typo in
 172         header comment.
 173
 174 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
 175
 176         * stack.c (set_last_displayed_sal): Delete.
 177         (last_displayed_sal_valid): Delete.
 178         (last_displayed_pspace): Delete.
 179         (last_displayed_addr): Delete.
 180         (last_displayed_symtab): Delete.
 181         (last_displayed_line): Delete.
 182         (class last_displayed_symtab_info_type): New.
 183         (last_displayed_symtab_info): New static global variable.
 184         (print_frame_info): Call methods on last_displayed_symtab_info.
 185         (clear_last_displayed_sal): Update header comment, and make use of
 186         last_displayed_symtab_info.
 187         (last_displayed_sal_is_valid): Likewise.
 188         (get_last_displayed_pspace): Likewise.
 189         (get_last_displayed_addr): Likewise.
 190         (get_last_displayed_symtab): Likewise.
 191         (get_last_displayed_line): Likewise.
 192         (get_last_displayed_sal): Likewise.
 193         * stack.h (clear_last_displayed_sal): Update header comment.
 194         (last_displayed_sal_is_valid): Likewise.
 195         (get_last_displayed_pspace): Likewise.
 196         (get_last_displayed_addr): Likewise.
 197         (get_last_displayed_symtab): Likewise.
 198         (get_last_displayed_line): Likewise.
 199         (get_last_displayed_sal): Likewise.
 200
 201 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
 202
 203         * stack.c (frame_show_address): Convert return type to bool.
 204         * stack.h (frame_show_address): Likewise, and update header
 205         comment.
 206
 207 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
 208
 209         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add new file to the list.
 210         * unittests/vec-utils-selftests.c: New file.
 211         * gdbsupport/gdb_vecs.h (unordered_remove): Avoid self move assign.
 212
 213 2019-11-10  Tom Tromey  <tom@tromey.com>
 214
 215         * tui/tui-wingeneral.c (tui_unhighlight_win): Use can_box.
 216         (tui_highlight_win): Likewise.
 217         (tui_win_info::check_and_display_highlight_if_needed): Likewise.
 218         * tui/tui-data.h (struct tui_win_info) <can_highlight>: Remove.
 219         * tui/tui-command.h (struct tui_cmd_window) <tui_cmd_window>:
 220         Don't set can_highlight.
 221
 222 2019-11-10  Tom Tromey  <tom@tromey.com>
 223
 224         * cli/cli-style.h (class cli_style_option) <cli_style_option>:
 225         Remove unused declaration.
 226
 227 2019-11-08  Tom Tromey  <tromey@adacore.com>
 228
 229         * top.c (read_command_file): Update.
 230         (command_line_input): Make return type const.
 231         * python/py-gdb-readline.c: Update.
 232         * linespec.c (decode_line_2): Update.
 233         * defs.h (command_line_input): Make return type const.
 234         * cli/cli-script.c (read_next_line): Make return type const.
 235         * ada-lang.c (get_selections): Update.
 236
 237 2019-11-06  Christian Biesinger  <cbiesinger@google.com>
 238
 239         * linux-tdep.c (linux_info_proc): Use strtok_r instead of strtok.
 240         * mi/mi-main.c (output_cores): Likewise.
 241         * nat/linux-osdata.c (linux_xfer_osdata_cpus): Likewise.
 242         (linux_xfer_osdata_modules): Likewise.
 243         * remote.c (register_remote_support_xml): Likewise.
 244         * sparc64-tdep.c (adi_is_addr_mapped): Likewise.
 245         * xml-syscall.c (syscall_create_syscall_desc): Likewise.
 246
 247 2019-11-06  Tom Tromey  <tom@tromey.com>
 248
 249         * tui/tui-interp.c: Don't include readline.h.
 250         * tui/tui-hooks.c: Don't include readline.h.
 251         * symmisc.c: Include tilde.h, not readline.h.
 252         * symfile.c: Include tilde.h, not readline.h.
 253         * source.c: Include tilde.h, not readline.h.
 254         * solib.c: Include tilde.h, not readline.h.
 255         * psymtab.c: Include tilde.h, not readline.h.
 256         * exec.c: Include tilde.h, not readline.h.
 257         * corelow.c: Include tilde.h, not readline.h.
 258         * cli/cli-dump.c: Include tilde.h, not readline.h.
 259         * cli/cli-cmds.c: Don't include readline.h.
 260
 261 2019-11-05  Tom Tromey  <tom@tromey.com>
 262
 263         * tui/tui-disasm.c (struct tui_asm_line) <addr_size>: New member.
 264         (tui_disassemble): Set addr_size.
 265         (tui_disasm_window::set_contents): Use addr_size.
 266
 267 2019-11-05  Tom Tromey  <tom@tromey.com>
 268
 269         * rust-lang.c (rust_language_defn): Update.
 270         * python/py-value.c (valpy_string): Call c_get_string.
 271         * p-lang.c (pascal_language_defn): Update.
 272         * opencl-lang.c (opencl_language_defn): Update.
 273         * objc-lang.c (objc_language_defn): Update.
 274         * m2-lang.c (m2_language_defn): Update.
 275         * language.c (unknown_language_defn, auto_language_defn): Update.
 276         (default_get_string): Remove.
 277         * guile/scm-value.c (gdbscm_value_to_string): Use c_get_string.
 278         * go-lang.c (go_language_defn): Update.
 279         * f-lang.c (f_language_defn): Update.
 280         * d-lang.c (d_language_defn): Update.
 281         * c-lang.c (c_language_defn, cplus_language_defn)
 282         (asm_language_defn, minimal_language_defn): Update.
 283         * ada-lang.c (ada_language_defn): Update.
 284         * language.h (struct language_defn) <la_get_string>: Remove.
 285         (LA_GET_STRING): Remove.
 286         (default_get_string): Don't declare.
 287
 288 2019-11-05  Tom Tromey  <tom@tromey.com>
 289
 290         * tui/tui-source.h (struct tui_source_window): Inline
 291         constructor.  Remove destructor.
 292         <style_changed, m_observable>: Move to superclass.
 293         * tui/tui-winsource.h (tui_copy_source_line): Declare.
 294         (struct tui_source_window_base): Move private members to end.
 295         <style_changed, m_observable>: Move from tui_source_window.
 296         * tui/tui-winsource.c (tui_copy_source_line): Move from
 297         tui-source.c.  Rename from copy_source_line.  Add special handling
 298         for negative line number.
 299         (tui_source_window_base::style_changed): Move from
 300         tui_source_window.
 301         (tui_source_window_base): Register observer.
 302         (~tui_source_window_base): New.
 303         * tui/tui-source.c (copy_source_line): Move to tui-winsource.c;
 304         rename.
 305         (tui_source_window::set_contents): Use tui_copy_source_line.
 306         (tui_source_window::tui_source_window): Move to tui-source.h.
 307         (tui_source_window::~tui_source_window): Remove.
 308         (tui_source_window::style_changed): Move to superclass.
 309         * tui/tui-disasm.c (tui_disassemble): Create string file with
 310         styling, when possible.  Add "addr_size" parameter.
 311         (tui_disasm_window::set_contents): Use tui_copy_source_line.
 312         Don't compute maximum size.
 313         (len_without_escapes): New function
 314
 315 2019-11-05  Tom Tromey  <tom@tromey.com>
 316
 317         * tui/tui-winsource.h (struct tui_source_element) <line>: Now a
 318         std::string.
 319         * tui/tui-winsource.c (tui_show_source_line): Update.
 320         * tui/tui-source.c (tui_source_window::set_contents): Update.
 321         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
 322
 323 2019-11-05  Christian Biesinger  <cbiesinger@google.com>
 324
 325         * symtab.h (gdb_static_assert): Put && operator at the beginning
 326         of the line instead of the end.
 327
 328 2019-11-04  Christian Biesinger  <cbiesinger@google.com>
 329
 330         * psympriv.h: Add static_asserts for sizeof (general_symbol_info)
 331         and sizeof (symbol).
 332         * symtab.h: Add a static_assert for sizeof (partial_symbol).
 333
 334 2019-11-04  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
 335
 336         * NEWS (Changes since GDB 8.3): Document Solaris 10 removal.
 337         * configure.host: Mark *-*-solaris2.10* obsolete.
 338         * configure.tgt: Mark Solaris < 11 obsolete.
 339         * MAINTAINERS (Target Instruction Set Architectures) <sparc>:
 340         Update target triplet.
 341
 342 2019-11-01  Tom Tromey  <tromey@adacore.com>
 343
 344         * utils.c (print_sys_errmsg): Simplify.
 345
 346 2019-11-01  Tom Tromey  <tromey@adacore.com>
 347
 348         * gdbsupport/mingw-strerror.c (safe_strerror): Constify result.
 349
 350 2019-11-01  Christian Biesinger  <cbiesinger@google.com>
 351
 352         * configure: Regenerate.
 353         * configure.ac: Remove check for strerror_r.
 354         * gdbsupport/common.m4: Check for strerror_r.
 355
 356 2019-11-01  Luis Machado  <luis.machado@linaro.org>
 357
 358         PR gdb/25124
 359
 360         * arm-tdep.c (arm_per_objfile): Rename to ...
 361         (arm_per_bfd): ... this.
 362         (arm_objfile_data_key): Rename to ...
 363         (arm_bfd_data_key): ... this.
 364         (arm_find_mapping_symbol): Adjust access to new bfd_key-based
 365         data.
 366         (arm_record_special_symbol): Likewise.
 367
 368 2019-10-31  Andrew Burgess  <andrew.burgess@embecosm.com>
 369
 370         * ada-typeprint.c (ada_print_typedef): Don't print newline at the
 371         end.
 372         * c-typeprint.c (c_print_typedef): Likewise.
 373         * f-typeprint.c (f_print_typedef): Likewise.
 374         * m2-typeprint.c (m2_print_typedef): Likewise.
 375         * p-typeprint.c (pascal_print_typedef): Likewise.
 376         * rust-lang.c (rust_print_typedef): Likewise.
 377         * symtab.c (print_symbol_info): Print a newline after calling
 378         typedef_print.
 379
 380 2019-10-31  Andrew Burgess  <andrew.burgess@embecosm.com>
 381
 382         * symtab.c (info_module_cmdlist): New variable.
 383         (info_module_command): New function.
 384         (search_module_symbols): New function.
 385         (info_module_subcommand): New function.
 386         (struct info_modules_var_func_options): New struct.
 387         (info_modules_var_func_options_defs): New variable.
 388         (make_info_modules_var_func_options_def_group): New function.
 389         (info_module_functions_command): New function.
 390         (info_module_variables_command): New function.
 391         (info_module_var_func_command_completer): New function.
 392         (_initialize_symtab): Register new 'info module functions' and
 393         'info module variables' commands.
 394         * symtab.h (typedef symbol_search_in_module): New typedef.
 395         (search_module_symbols): Declare new function.
 396         * NEWS: Mention new commands.
 397
 398 2019-10-31  Andrew Burgess  <andrew.burgess@embecosm.com>
 399
 400         * dwarf2read.c (dw2_symtab_iter_next): Handle MODULE_DOMAIN.
 401         (dw2_expand_marked_cus): Handle MODULES_DOMAIN.
 402         (dw2_debug_names_iterator::next): Handle MODULE_DOMAIN and
 403         MODULES_DOMAIN.
 404         (scan_partial_symbols): Only create partial module symbols for non
 405         declarations.
 406         * psymtab.c (recursively_search_psymtabs): Handle MODULE_DOMAIN
 407         and MODULES_DOMAIN.
 408         * symtab.c (search_domain_name): Likewise.
 409         (search_symbols): Likewise.
 410         (print_symbol_info): Likewise.
 411         (symtab_symbol_info): Likewise.
 412         (info_modules_command): New function.
 413         (_initialize_symtab): Register 'info modules' command.
 414         * symtab.h (enum search_domain): Add MODULES_DOMAIN.
 415         * NEWS: Mention new 'info modules' command.
 416
 417 2019-10-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 418
 419         * NEWS: Mention $_gdb_setting, $_gdb_setting_str, $_gdb_maint_setting
 420         and $_gdb_maint_setting_str.
 421
 422 2019-10-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 423
 424         * cli/cli-cmds.c (setting_cmd, value_from_setting)
 425         (gdb_setting_internal_fn, gdb_maint_setting_internal_fn)
 426         (str_value_from_setting, gdb_setting_str_internal_fn)
 427         (gdb_maint_setting_str_internal_fn): New functions.
 428         (_initialize_cli_cmds): Define the new convenience functions.
 429         * gdb/cli/cli-setshow.h (get_setshow_command_value_string): Constify.
 430         * gdb/cli/cli-setshow.c (get_setshow_command_value_string): Constify.
 431
 432 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
 433
 434         * agent.c (set_can_use_agent): When the setting is turned on,
 435         look up agent symbols if we don't have them yet.
 436         (agent_new_objfile): Don't look up agent symbols when the agent
 437         setting is off.
 438
 439 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
 440
 441         * config.in: Regenerate.
 442
 443 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
 444
 445         * configure: Regenerate.
 446         * configure.ac: Check for strerror_r.
 447         * gdbsupport/common-utils.h (safe_strerror): Change return value
 448         to const char * and document that this function is now threadsafe.
 449         * gdbsupport/posix-strerror.c (safe_strerror): Make buf
 450         thread_local and call strerror_r, if available.
 451         * utils.c (perror_string): Update.
 452         (print_sys_errmsg): Update.
 453
 454 2019-10-31  Luis Machado  <luis.machado@linaro.org>
 455
 456         * arm-tdep.c (arm_exidx_data_key): Use bfd_key instead of
 457         objfile_key.
 458         (arm_exidx_new_objfile): Adjust to use objfile->obfd instead of
 459         objfile to fetch per-bfd data.
 460         (arm_find_exidx_entry): Likewise.
 461
 462 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
 463
 464         * gdbsupport/agent.c (debug_agent): Change type to bool.
 465         (use_agent): Likewise.
 466         (all_agent_symbols_look_up): Likewise.
 467         (agent_loaded_p): Change return value to bool.
 468         (agent_look_up_symbols): Update.
 469         (agent_capability_check): Change return value to bool.
 470         * gdbsupport/agent.h (agent_loaded_p): Likewise.
 471         (debug_agent): Change type to bool.
 472         (use_agent): Likewise.
 473         (agent_capability_check): Change return value to bool.
 474
 475 2019-10-30  Christian Biesinger  <cbiesinger@google.com>
 476
 477         * minsyms.c (clear_minimal_symbol_hash_tables): New function.
 478         (build_minimal_symbol_hash_tables): Code to clear the table moved
 479         to clear_minimal_symbol_hash_tables.
 480         (minimal_symbol_reader::install): Call clear_minimal_symbol_hash_tables
 481         when needed.
 482
 483 2019-10-29  Simon Marchi  <simon.marchi@polymtl.ca>
 484
 485         * infcmd.c: Remove includes.
 486         * infrun.c: Remove includes.
 487
 488 2019-10-29  Simon Marchi  <simon.marchi@polymtl.ca>
 489
 490         * ada-lang.h (GROW_VECT): Move to ada-lang.c.
 491         (grow_vect): Remove declaration.
 492         (ada_type_of_array): Remove declaration.
 493         (ada_update_initial_language): Remove declaration.
 494         (ada_fold_name): Remove declaration.
 495         (ada_fill_in_ada_prototype): Remove declaration.
 496         (user_select_syms): Remove declaration.
 497         (get_selections): Remove declaration.
 498         (ada_tag_type): Remove declaration.
 499         (ada_value_tag): Remove declaration.
 500         (ada_is_others_clause): Remove declaration.
 501         (ada_in_variant): Remove declaration.
 502         (ada_value_struct_elt): Remove declaration.
 503         (ada_attribute_name): Remove declaration.
 504         (ada_system_address_type): Remove declaration.
 505         * ada-lang.c (ada_watch_location_expression): Make static.
 506         (GROW_VECT): Move here from ada-lang.h.
 507         (grow_vect): Make static.
 508         (ada_update_initial_language): Make static.
 509         (ada_fold_name): Make static.
 510         (ada_type_of_array): Make static.
 511         (encoded_ordered_before): Move up.
 512         (sort_choices): Move up.
 513         (print_signatures): Move up.
 514         (ada_print_symbol_signature): Move up.
 515         (get_selections): Move up and make static.
 516         (user_select_syms): Move up and make static.
 517         (ada_value_struct_elt): Move up and make static.
 518         (ada_tag_type): Make static.
 519         (ada_value_tag): Make static.
 520         (ada_is_others_clause): Make static.
 521         (ada_in_variant): Make static.
 522         (ada_attribute_name): Make static.
 523
 524 2019-10-29  Simon Marchi  <simon.marchi@polymtl.ca>
 525
 526         * ada-lang.c: Remove includes.
 527         * ada-typeprint.c: Remove includes.
 528         * ada-valprint.c: Remove includes.
 529
 530 2019-10-29  Simon Marchi  <simon.marchi@efficios.com>
 531
 532         * addrmap.c: Add static assertions of type size, moved from
 533         _initialize_addrmap.
 534         (_initialize_addrmap): Remove.
 535
 536 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
 537
 538         * coffread.c (record_minimal_symbol): Update.
 539         (process_coff_symbol): Update.
 540         * dbxread.c (read_dbx_symtab): Update.
 541         * dwarf2read.c (add_partial_symbol): Update.
 542         (fixup_go_packaging): Update.
 543         (load_partial_dies): Update.
 544         (new_symbol): Update.
 545         * elfread.c (record_minimal_symbol): Change signature to use
 546         gdb::string_view instead of name+len.
 547         (elf_symtab_read): Update.
 548         (elf_rel_plt_read): Update.
 549         * mdebugread.c (parse_partial_symbols): Update.
 550         (handle_psymbol_enumerators): Update.
 551         (new_symbol): Update.
 552         * minsyms.c (minimal_symbol_reader::record_full): Change signature
 553         to use gdb::string_view instead of name+len.
 554         * minsyms.h (class minimal_symbol_reader) <record_full>: Likewise.
 555         * psympriv.h (add_psymbol_to_list): Likewise.
 556         * psymtab.c (add_psymbol_to_bcache): Likewise.
 557         (add_psymbol_to_list): Likewise.
 558         * stabsread.c (define_symbol): Update.
 559         * symtab.c (symbol_set_names): Change signature to use gdb::string_view.
 560         * symtab.h (SYMBOL_SET_NAMES): Likewise.
 561         (symbol_set_names): Likewise.
 562         * xcoffread.c (scan_xcoff_symtab): Update.
 563
 564 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
 565
 566         * symtab.h (symbol_set_names): Document that copy_name must be
 567         set to true for non-nullterminated strings.
 568         * symtab.c (symbol_set_names): Only make a nullterminated copy of
 569         linkage_name if the entry was not found and we need to demangle.
 570
 571 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
 572
 573         * Makefile.in (HFILES_NO_SRCDIR): Add gdb_binary_search.h.
 574         * dwarf2-frame.c (bsearch_fde_cmp): Update.
 575         (dwarf2_frame_find_fde): Replace bsearch with gdb::binary_search.
 576         * gdbsupport/gdb_binary_search.h: New file.
 577
 578 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
 579
 580         * NEWS: Mention new --with-system-gdbinit-dir option.
 581         * config.in: Regenerate.
 582         * configure: Regenerate.
 583         * configure.ac: Add new option --with-system-gdbinit-dir.
 584         * extension.c (get_ext_lang_of_file): Return extension_language_gdb
 585         for a ".gdb" suffix.
 586         * main.c (get_init_files): Change system_gdbinit argument to
 587         a vector and return the files in SYSTEM_GDBINIT_DIR in
 588         addition to SYSTEM_GDBINIT.
 589         (captured_main_1): Update.
 590         (print_gdb_help): Update.
 591         * top.c (print_gdb_configuration): Also print the value of
 592         SYSTEM_GDBINIT_DIR.
 593
 594 2019-10-28  Christian Biesinger  <cbiesinger@google.com>
 595
 596         * gdbsupport/common-utils.h (startswith): Add an overloaded version
 597         that takes gdb::string_view arguments.
 598
 599 2019-10-26  Tom de Vries  <tdevries@suse.de>
 600
 601         * aarch64-linux-tdep.c: Fix typos in comments.
 602         * aarch64-tdep.c: Same.
 603         * ada-lang.c: Same.
 604         * amd64-nat.c: Same.
 605         * arc-tdep.c: Same.
 606         * arch/aarch64-insn.c: Same.
 607         * block.c: Same.
 608         * breakpoint.h: Same.
 609         * btrace.h: Same.
 610         * c-varobj.c: Same.
 611         * cli/cli-decode.c: Same.
 612         * cli/cli-script.c: Same.
 613         * cli/cli-utils.h: Same.
 614         * coff-pe-read.c: Same.
 615         * coffread.c: Same.
 616         * compile/compile-cplus-symbols.c: Same.
 617         * compile/compile-object-run.c: Same.
 618         * completer.c: Same.
 619         * corelow.c: Same.
 620         * cp-support.c: Same.
 621         * demangle.c: Same.
 622         * dwarf-index-write.c: Same.
 623         * dwarf2-frame.c: Same.
 624         * dwarf2-frame.h: Same.
 625         * eval.c: Same.
 626         * frame-base.h: Same.
 627         * frame.h: Same.
 628         * gdbcmd.h: Same.
 629         * gdbtypes.h: Same.
 630         * gnu-nat.c: Same.
 631         * guile/scm-objfile.c: Same.
 632         * i386-tdep.c: Same.
 633         * i386-tdep.h: Same.
 634         * infcall.c: Same.
 635         * infcall.h: Same.
 636         * linux-nat.c: Same.
 637         * m68k-tdep.c: Same.
 638         * macroexp.c: Same.
 639         * memattr.c: Same.
 640         * mi/mi-cmd-disas.c: Same.
 641         * mi/mi-getopt.h: Same.
 642         * mi/mi-main.c: Same.
 643         * minsyms.c: Same.
 644         * nat/aarch64-sve-linux-sigcontext.h: Same.
 645         * objfiles.h: Same.
 646         * ppc-linux-nat.c: Same.
 647         * ppc-linux-tdep.c: Same.
 648         * ppc-tdep.h: Same.
 649         * progspace.h: Same.
 650         * prologue-value.h: Same.
 651         * python/py-evtregistry.c: Same.
 652         * python/py-instruction.h: Same.
 653         * record-btrace.c: Same.
 654         * record-full.c: Same.
 655         * remote.c: Same.
 656         * rs6000-tdep.c: Same.
 657         * ser-tcp.c: Same.
 658         * sol-thread.c: Same.
 659         * sparc-sol2-tdep.c: Same.
 660         * sparc64-tdep.c: Same.
 661         * stabsread.c: Same.
 662         * symfile.c: Same.
 663         * symtab.h: Same.
 664         * target.c: Same.
 665         * tracepoint.c: Same.
 666         * tui/tui-data.h: Same.
 667         * tui/tui-io.c: Same.
 668         * tui/tui-win.c: Same.
 669         * tui/tui.c: Same.
 670         * unittests/rsp-low-selftests.c: Same.
 671         * user-regs.h: Same.
 672         * utils.c: Same.
 673         * utils.h: Same.
 674         * valarith.c: Same.
 675         * valops.c: Same.
 676         * valprint.c: Same.
 677         * valprint.h: Same.
 678         * value.c: Same.
 679         * value.h: Same.
 680         * varobj.c: Same.
 681         * x86-nat.h: Same.
 682         * xtensa-tdep.c: Same.
 683
 684 2019-10-25  Ali Tamur <tamur@google.com>
 685
 686         * charset.c (find_charset_names): Reflect API change.
 687
 688 2019-10-25  Christian Biesinger  <cbiesinger@google.com>
 689
 690         * symtab.c (struct demangled_name_entry): Change demangled name
 691         to a unique_xmalloc_ptr<char>, now that we don't allocate it as
 692         part of the struct anymore.
 693         (symbol_set_names): No longer obstack allocate + copy the demangled
 694         name, just store the allocated name from bfd.
 695
 696 2019-10-25  Tom Tromey  <tromey@adacore.com>
 697
 698         * dwarf2-frame.c (dwarf2_cie_table): Now a typedef.
 699         (bsearch_cie_cmp, add_cie): Remove.
 700         (find_cie): Reimplement.
 701         (decode_frame_entry_1, decode_frame_entry): Change type.  Update.
 702         (dwarf2_build_frame_info): Update.
 703
 704 2019-10-24  H.J. Lu  <hongjiu.lu@intel.com>
 705
 706         PR gdb/25126
 707         * symfile.c (reread_symbols): Call forget_cached_source_info to
 708         clear the stale source cache.
 709
 710 2019-10-24  Christian Biesinger  <cbiesinger@google.com>
 711
 712         * configure: Regenerate.
 713         * configure.ac: Remove code that sets python_has_threads.
 714
 715 2019-10-24  Christian Biesinger  <cbiesinger@google.com>
 716
 717         * config.in: Regenerate.
 718         * configure: Regenerate.
 719         * configure.ac: Remove the code that uses sed to get the python
 720         version and defines HAVE_LIBPYTHON2_6 / HAVE_LIBPYTHON2_7.
 721
 722 2019-10-24  Andrew Burgess  <andrew.burgess@embecosm.com>
 723
 724         * python/py-progspace.c (pspy_block_for_pc): Return None for all
 725         error paths.
 726
 727 2019-10-23  Tom Tromey  <tom@tromey.com>
 728
 729         * arc-tdep.c: Remove ".." from include.
 730         * frv-tdep.c: Remove ".." from include.
 731         * lm32-tdep.c: Remove ".." from include.
 732         * microblaze-tdep.c: Remove ".." from include.
 733         * or1k-tdep.h: Remove ".." from include.
 734         * s12z-tdep.c: Remove ".." from include.
 735         * Makefile.in (OPCODES_CFLAGS): Add comment.
 736         (TOP_CFLAGS): New variable.
 737         (INTERNAL_CFLAGS_BASE): Add TOP_CFLAGS.
 738
 739 2019-10-23  Tom Tromey  <tom@tromey.com>
 740
 741         * Makefile.in (READLINE_DIR): Update.
 742
 743 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 744
 745         * infcall.c (call_function_by_hand_dummy): Fix the function
 746         comment.  And extract out a code section into...
 747         (reserve_stack_space): ...this new function.
 748
 749 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 750
 751         * infcall.c (value_arg_coerce): Remove an unused parameter.
 752         (call_function_by_hand_dummy): Update the call to
 753         'value_arg_coerce'.
 754
 755 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 756
 757         * infcall.c (call_function_by_hand_dummy): Refactor.
 758
 759 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 760
 761         * MAINTAINERS (Write After Approval): Add Tankut Baris Aktemur.
 762
 763 2019-10-23  Tom Tromey  <tom@tromey.com>
 764
 765         * configure: Rebuild.
 766         * configure.ac: Don't check for sigprocmask.
 767         * gdbsupport/common.m4 (GDB_AC_COMMON): Check for sigprocmask.
 768
 769 2019-10-23  Tom Tromey  <tom@tromey.com>
 770
 771         * configure: Rebuild.
 772         * acinclude.m4: Use m4_include, not sinclude.
 773
 774 2019-10-23  Tom de Vries  <tdevries@suse.de>
 775
 776         PR breakpoints/24687
 777         * symtab.c (iterate_over_some_symtabs): Apply gdb_realpath on fullname.
 778
 779 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
 780
 781         * symtab.c (struct demangled_name_entry) <language>: Change from
 782         bitfield to regular variable.
 783
 784 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
 785
 786         * symtab.c (struct demangled_name_entry): Add a constructor.
 787         (free_demangled_name_entry): New function to call the destructor
 788         for demangled_name_entry.
 789         (create_demangled_names_hash): Pass free_demangled_name_entry to
 790         htab_create_alloc.
 791         (symbol_set_names): Call placement new for demangled_name_entry.
 792         * utils.c: No longer include xxhash.h here, now that fast_hash
 793         is inlined in the header.
 794         * utils.h: Instead, include it here.
 795
 796 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
 797
 798         * Makefile.in: Link with libxxhash.
 799         * config.in: Regenerate.
 800         * configure: Regenerate.
 801         * configure.ac: Search for libxxhash.
 802         * utils.c (fast_hash): Use xxhash if present.
 803
 804 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
 805
 806         * utils.h (fast_hash): New function.
 807         * symtab.c (hash_demangled_name_entry): Call new function
 808         fast_hash.
 809
 810 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
 811
 812         * symtab.c (struct demangled_name_entry): Change type of mangled
 813         to gdb::string_view. Also adds a constructor that takes the
 814         mangled name.
 815         (hash_demangled_name_entry): Update.
 816         (eq_demangled_name_entry): Update.
 817         (free_demangled_name_entry): New function to call the destructor
 818         now that this is not a POD anymore.
 819         (create_demangled_names_hash): Pass free_demangled_name_entry to
 820         htab_create_alloc.
 821         (symbol_set_names): Update.
 822
 823 2019-10-21  Ali Tamur  <tamu@google.com>
 824
 825         * dwarf2read.c (dir_index): Change type.
 826         (file_name_index): Likewise.
 827         (line_header::include_dir_at): Change comment and implementation on
 828         whether it is DWARF 5.
 829         (line_header::is_valid_file_index): New function.
 830         (line_header::file_name_at): Change comment and implementation on
 831         whether it is DWARF 5.
 832         (line_header::file_names): Change to private field renamed as
 833         m_file_names and introduce a new accessor method.
 834         (line_header::file_names_size): New method.
 835         (line_header::include_dirs): Change to private field and rename as
 836         m_include_dirs.
 837         (dw2_get_file_names_reader): Define local var at a smaller scope and
 838         reflect API change.
 839         (dwarf2_cu::setup_type_unit_groups): Reflect API change.
 840         (process_structure_scope): Likewise.
 841         (line_header::add_include_dir): Change message and reflect renaming.
 842         (line_header::add_file_name): Likewise.
 843         (read_formatted_entries): Handle DW_FORM_data16.
 844         (dwarf_decode_line_header): Fix line header length calculation.
 845         (psymtab_include_file_name): Change comment and API.
 846         (lnp_state_machine::m_file): Update comment and reflect type change.
 847         (lnp_state_machine::record_line): Reflect type change.
 848         (dwarf_decode_lines): Reflect API change.
 849         (file_file_name): Likewise.
 850         (file_full_name): Likewise.
 851
 852 2019-10-21  Andrew Burgess  <andrew.burgess@embecosm.com>
 853
 854         * objfiles.c (sort_cmp): Ensure that !(a < a) holds true.
 855
 856 2019-10-21  Tom Tromey  <tom@tromey.com>
 857
 858         * tui/tui-winsource.h (tui_exec_info_content): Remove typedef.
 859
 860 2019-10-21  Tom Tromey  <tom@tromey.com>
 861
 862         * configure.ac (nm.h): Conditionally create nm.h link.  Subst
 863         NM_H.   Use AC_CONFIG_LINKS.
 864         * configure: Rebuild.
 865         * Makefile.in (NM_H): New variable.
 866         (generated_files): Add NM_H.  Remove gcore.
 867         (nm.h, stamp-nmh): New targets.
 868
 869 2019-10-20  Tom Tromey  <tom@tromey.com>
 870
 871         * objfiles.h (unlink_objfile, put_objfile_before): Don't declare.
 872         * objfiles.c (unlink_objfile): Move earlier.  Now static.  Remove
 873         obsolete comment.
 874         (put_objfile_before): Now static.
 875
 876 2019-10-19  Simon Marchi  <simon.marchi@polymtl.ca>
 877
 878         * gdbsupport/common-utils.h (startswith): Change return type to
 879         bool.
 880
 881 2019-10-19  Christian Biesinger  <cbiesinger@google.com>
 882
 883         * bcache.c (bcache::print_statistics): Use std::sort instead of qsort.
 884         * breakpoint.c (bp_locations_compare): Rename to...
 885         (bp_location_is_less_than): ...this, and change to std::sort semantics.
 886         (update_global_location_list): Use std::sort instead of qsort.
 887         * buildsym.c (compare_line_numbers): Rename to...
 888         (lte_is_less_than): ...this, and change to std::sort semantics.
 889         (buildsym_compunit::end_symtab_with_blockvector): Use std::sort
 890         instead of qsort.
 891         * disasm.c (compare_lines): Rename to...
 892         (line_is_less_than): ...this, and change to std::sort semantics.
 893         (do_mixed_source_and_assembly_deprecated): Call std::sort instead
 894         of qsort.
 895         * dwarf2-frame.c (qsort_fde_cmp): Rename to...
 896         (fde_is_less_than): ...this, and change to std::sort semantics.
 897         (dwarf2_build_frame_info): Call std::sort instead of qsort.
 898         * mdebugread.c (compare_blocks):
 899         (block_is_less_than): ...this, and change to std::sort semantics.
 900         (sort_blocks): Call std::sort instead of qsort.
 901         * objfiles.c (qsort_cmp): Rename to...
 902         (sort_cmp): ...this, and change to std::sort semantics.
 903         (update_section_map): Call std::sort instead of qsort.
 904         * remote.c (compare_pnums): Remove.
 905         (map_regcache_remote_table): Call std::sort instead of qsort.
 906         * utils.c (compare_positive_ints): Remove.
 907         * utils.h (compare_positive_ints): Remove.
 908         * xcoffread.c (compare_lte): Remove.
 909         (arrange_linetable): Call std::sort instead of qsort.
 910
 911 2019-10-19  Sergio Durigan Junior  <sergiodj@redhat.com>
 912
 913         * symfile.c (init_entry_point_info): Fix typo.
 914         * i386-darwin-tdep.c (darwin_dwarf_signal_frame_p): Fix typo.
 915
 916 2019-10-18  Tom de Vries  <tdevries@suse.de>
 917
 918         * aarch64-tdep.c: Fix typos in comments.
 919         * ada-lang.c: Same.
 920         * ada-tasks.c: Same.
 921         * alpha-tdep.c: Same.
 922         * alpha-tdep.h: Same.
 923         * amd64-nat.c: Same.
 924         * amd64-windows-tdep.c: Same.
 925         * arc-tdep.c: Same.
 926         * arc-tdep.h: Same.
 927         * arch-utils.c: Same.
 928         * arm-nbsd-tdep.c: Same.
 929         * arm-tdep.c: Same.
 930         * ax-gdb.c: Same.
 931         * blockframe.c: Same.
 932         * btrace.c: Same.
 933         * c-varobj.c: Same.
 934         * coff-pe-read.c: Same.
 935         * coffread.c: Same.
 936         * cris-tdep.c: Same.
 937         * darwin-nat.c: Same.
 938         * dbxread.c: Same.
 939         * dcache.c: Same.
 940         * disasm.c: Same.
 941         * dtrace-probe.c: Same.
 942         * dwarf-index-write.c: Same.
 943         * dwarf2-frame-tailcall.c: Same.
 944         * dwarf2-frame.c: Same.
 945         * dwarf2read.c: Same.
 946         * eval.c: Same.
 947         * exceptions.c: Same.
 948         * fbsd-tdep.c: Same.
 949         * findvar.c: Same.
 950         * frame.c: Same.
 951         * frv-tdep.c: Same.
 952         * gnu-v3-abi.c: Same.
 953         * go32-nat.c: Same.
 954         * h8300-tdep.c: Same.
 955         * hppa-tdep.c: Same.
 956         * i386-linux-tdep.c: Same.
 957         * i386-tdep.c: Same.
 958         * ia64-libunwind-tdep.c: Same.
 959         * ia64-tdep.c: Same.
 960         * infcmd.c: Same.
 961         * infrun.c: Same.
 962         * linespec.c: Same.
 963         * linux-nat.c: Same.
 964         * linux-thread-db.c: Same.
 965         * machoread.c: Same.
 966         * mdebugread.c: Same.
 967         * mep-tdep.c: Same.
 968         * mn10300-tdep.c: Same.
 969         * namespace.c: Same.
 970         * objfiles.c: Same.
 971         * opencl-lang.c: Same.
 972         * or1k-tdep.c: Same.
 973         * osabi.c: Same.
 974         * ppc-linux-nat.c: Same.
 975         * ppc-linux-tdep.c: Same.
 976         * ppc-sysv-tdep.c: Same.
 977         * printcmd.c: Same.
 978         * procfs.c: Same.
 979         * record-btrace.c: Same.
 980         * record-full.c: Same.
 981         * remote-fileio.c: Same.
 982         * remote.c: Same.
 983         * rs6000-tdep.c: Same.
 984         * s12z-tdep.c: Same.
 985         * score-tdep.c: Same.
 986         * ser-base.c: Same.
 987         * ser-go32.c: Same.
 988         * skip.c: Same.
 989         * sol-thread.c: Same.
 990         * solib-svr4.c: Same.
 991         * solib.c: Same.
 992         * source.c: Same.
 993         * sparc-nat.c: Same.
 994         * sparc-sol2-tdep.c: Same.
 995         * sparc-tdep.c: Same.
 996         * sparc64-tdep.c: Same.
 997         * stabsread.c: Same.
 998         * stack.c: Same.
 999         * symfile.c: Same.
1000         * symtab.c: Same.
1001         * target-descriptions.c: Same.
1002         * target-float.c: Same.
1003         * thread.c: Same.
1004         * utils.c: Same.
1005         * valops.c: Same.
1006         * valprint.c: Same.
1007         * value.c: Same.
1008         * varobj.c: Same.
1009         * windows-nat.c: Same.
1010         * xcoffread.c: Same.
1011         * xstormy16-tdep.c: Same.
1012         * xtensa-tdep.c: Same.
1013
1014 2019-10-17  Tom Tromey  <tromey@adacore.com>
1015
1016         * configure: Rebuild.
1017         * configure.ac: Use AC_CONFIG_HEADERS.  Create stamp-h there, not
1018         in AC_CONFIG_FILES invocation.
1019         * Makefile.in (Makefile, data-directory/Makefile, stamp-h): Use
1020         new-style config.status invocation.
1021
1022 2019-10-17  Tom de Vries  <tdevries@suse.de>
1023
1024         * arm-nbsd-nat.c: Fix typos in comments.
1025         * arm-tdep.c: Same.
1026         * darwin-nat-info.c: Same.
1027         * dwarf2read.c: Same.
1028         * elfread.c: Same.
1029         * event-top.c: Same.
1030         * findvar.c: Same.
1031         * gdbtypes.c: Same.
1032         * hppa-tdep.c: Same.
1033         * i386-tdep.c: Same.
1034         * jit.c: Same.
1035         * main.c: Same.
1036         * mdebugread.c: Same.
1037         * moxie-tdep.c: Same.
1038         * nto-procfs.c: Same.
1039         * osabi.c: Same.
1040         * ppc-linux-tdep.c: Same.
1041         * remote.c: Same.
1042         * riscv-tdep.c: Same.
1043         * s390-tdep.c: Same.
1044         * sh-tdep.c: Same.
1045         * sparc-linux-tdep.c: Same.
1046         * sparc-nat.c: Same.
1047         * stack.c: Same.
1048         * target-descriptions.c: Same.
1049         * top.c: Same.
1050         * varobj.c: Same.
1051
1052 2019-10-16  Tom Tromey  <tom@tromey.com>
1053
1054         * objfiles.h (struct objfile) <original_name>: Now const.
1055
1056 2019-10-16  Christian Biesinger  <cbiesinger@google.com>
1057
1058         * gdbsupport/gdb_setjmp.h (SIGSETJMP): Allow passing in the value to
1059         pass on to sigsetjmp's second argument.
1060         * cp-support.c (gdb_demangle): Unblock SIGSEGV if we caught a crash.
1061
1062 2019-10-16  Keith Seitz  <keiths@redhat.com>
1063
1064         PR gdb/23567
1065         * dwarf2read.c (dwarf2_per_objfile::locate_sections): Discard
1066         sections whose size is greater than the file size.
1067
1068 2019-10-16  Jim Wilson  <jimw@sifive.com>
1069
1070         * riscv-tdep.c (riscv_gcc_target_options): New.
1071         (riscv_gnu_triplet_regexp): New.
1072         (riscv_gdbarch_init): Call set_gdbarch_gcc_triplet_options and
1073         set_gdbarch_gnu_triplet_regexp.
1074
1075 2019-10-16  Christian Biesinger  <cbiesinger@google.com>
1076
1077         * Makefile.in: Add xml-builtin.h.
1078         * features/feature_to_c.sh: Add an include for xml-builtin.h
1079         to ensure that the compiler checks that the types match.
1080         * xml-builtin.h: New file.
1081         * xml-support.c (fetch_xml_builtin): Add missing const.
1082         * xml-support.h: Remove declaration of xml_builtins.
1083
1084 2019-10-16  Tom de Vries  <tdevries@suse.de>
1085
1086         PR tdep/25096
1087         * amd64-tdep.c (amd64_classify_aggregate_field): Factor out of ...
1088         (amd64_classify_aggregate): ... here.
1089         (amd64_classify_aggregate_field): Handled fiels of nested structs
1090         recursively.
1091
1092 2019-10-16  Tom de Vries  <tdevries@suse.de>
1093
1094         PR tdep/24104
1095         * amd64-tdep.c (amd64_push_arguments): Handle AMD64_NO_CLASS in loop
1096         that handles 'theclass'.
1097
1098 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1099
1100         * linespec.c (decode_digits_ordinary): Update comment.
1101         * make-target-delegates: No longer need to handle VEC case.
1102         * memrange.c (normalize_mem_ranges): Update comment.
1103         * namespace.c (add_using_directive): Update comment.
1104         * objc-lang.c (uniquify_strings): Update comment.
1105         * ppc-linux-nat.c (struct thread_points): Update comment.
1106         * probe.h (find_probes_in_objfile): Update comment.
1107         * target.h (enum flash_preserve_mode): Update comment.
1108         * varobj.c (varobj_restrict_range): Update comment.
1109         * varobj.h (varobj_list_children): Update comment.
1110
1111 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1112
1113         * Makefile.in: Remove references to vec.h and vec.c.
1114         * aarch64-tdep.c: No longer include vec.h.
1115         * ada-lang.c: Likewise.
1116         * ada-lang.h: Likewise.
1117         * arm-tdep.c: Likewise.
1118         * ax.h: Likewise.
1119         * breakpoint.h: Likewise.
1120         * charset.c: Likewise.
1121         * cp-support.h: Likewise.
1122         * dtrace-probe.c: Likewise.
1123         * dwarf2read.c: Likewise.
1124         * extension.h: Likewise.
1125         * gdb_bfd.c: Likewise.
1126         * gdbsupport/gdb_vecs.h: Likewise.
1127         * gdbsupport/vec.c: Remove.
1128         * gdbsupport/vec.h: Remove.
1129         * gdbthread.h: Likewise.
1130         * guile/scm-type.c: Likewise.
1131         * inline-frame.c: Likewise.
1132         * machoread.c: Likewise.
1133         * memattr.c: Likewise.
1134         * memrange.h: Likewise.
1135         * namespace.h: Likewise.
1136         * nat/linux-btrace.h: Likewise.
1137         * osdata.c: Likewise.
1138         * parser-defs.h: Likewise.
1139         * progspace.h: Likewise.
1140         * python/py-type.c: Likewise.
1141         * record-btrace.c: Likewise.
1142         * rust-exp.y: Likewise.
1143         * solib-target.c: Likewise.
1144         * stap-probe.c: Likewise.
1145         * target-descriptions.c: Likewise.
1146         * target-memory.c: Likewise.
1147         * target.h: Likewise.
1148         * varobj.c: Likewise.
1149         * varobj.h: Likewise.
1150         * xml-support.h: Likewise.
1151
1152 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1153
1154         * gdb/dwarf2read.c (dwarf2_per_objfile::~dwarf2_per_objfile):
1155         Update for new std::vector based implementation.
1156         (process_psymtab_comp_unit_reader): Likewise.
1157         (scan_partial_symbols): Likewise.
1158         (recursively_compute_inclusions): Likewise.
1159         (compute_compunit_symtab_includes): Likewise.
1160         (process_imported_unit_die): Likewise.
1161         (queue_and_load_dwo_tu): Likewise.
1162         (follow_die_sig_1): Likewise.
1163         * gdb/dwarf2read.h: Remove DEF_VEC_P.
1164         (typedef dwarf2_per_cu_ptr): Remove.
1165         (struct dwarf2_per_cu_data) <imported_symtabs_empty>: New
1166         function.
1167         (struct dwarf2_per_cu_data) <imported_symtabs_push>: New function.
1168         (struct dwarf2_per_cu_data) <imported_symtabs_size>: New function.
1169         (struct dwarf2_per_cu_data) <imported_symtabs_free>: New function.
1170         (struct dwarf2_per_cu_data) <imported_symtabs>: Change to
1171         std::vector.
1172
1173 2019-10-15  Tom Tromey  <tromey@adacore.com>
1174
1175         * windows-nat.c (windows_nat_target::resume): Use %x when logging
1176         TID.
1177
1178 2019-10-15  Tom Tromey  <tromey@adacore.com>
1179
1180         * windows-nat.c (windows_nat_target::fetch_registers)
1181         (windows_nat_target::store_registers): Rename "pid" to "tid".
1182
1183 2019-10-15  Tom Tromey  <tromey@adacore.com>
1184
1185         * gdbarch.h, gdbarch.c: Rebuild.
1186         * gdbarch.sh (gcc_target_options): Change return type to
1187         std::string.
1188         * compile/compile.c (get_args): Update.
1189         * nios2-tdep.c (nios2_gcc_target_options): Return std::string.
1190         * arm-linux-tdep.c (arm_linux_gcc_target_options): Return
1191         std::string.
1192         * aarch64-linux-tdep.c (aarch64_linux_gcc_target_options): Return
1193         std::string.
1194         * arch-utils.c (default_gcc_target_options): Return std::string.
1195         * arch-utils.h (default_gcc_target_options): Return std::string.
1196         * s390-tdep.c (s390_gcc_target_options): Return std::string.
1197
1198 2019-10-15  Christian Biesinger  <cbiesinger@google.com>
1199
1200         * breakpoint.c (breakpoint_chain): Make static.
1201         * tui/tui-winsource.c: Call iterate_over_breakpoints instead
1202         of accessing breakpoint_chain.
1203
1204 2019-10-15  Christian Biesinger  <cbiesinger@google.com>
1205
1206         * breakpoint.c (iterate_over_breakpoints): Change function pointer
1207         to a gdb::function_view and return value to bool.
1208         * breakpoint.h (iterate_over_breakpoints): Likewise.
1209         * dummy-frame.c (pop_dummy_frame_bpt): Update.
1210         (pop_dummy_frame): Update.
1211         * guile/scm-breakpoint.c (bpscm_build_bp_list): Update.
1212         (gdbscm_breakpoints): Update.
1213         * python/py-breakpoint.c (build_bp_list): Update.
1214         (gdbpy_breakpoints): Update.
1215         * python/py-finishbreakpoint.c (bpfinishpy_detect_out_scope_cb):
1216         Update.
1217         (bpfinishpy_handle_stop): Update.
1218         (bpfinishpy_handle_exit): Update.
1219         * solib-svr4.c (svr4_update_solib_event_breakpoint): Update.
1220         (svr4_update_solib_event_breakpoints): Update.
1221
1222 2019-10-15  Andreas Arnez  <arnez@linux.ibm.com>
1223
1224         * s390-tdep.c (s390_effective_inner_type): Ignore static fields
1225         when unwrapping single-field structs.
1226
1227 2019-10-14  Simon Marchi  <simon.marchi@polymtl.ca>
1228
1229         * dwarf2read.c: Remove includes.
1230
1231 2019-10-13  Simon Marchi  <simon.marchi@polymtl.ca>
1232
1233         * ui-out.c (ui_out::call_do_message): Silence
1234         -Wformat-nonliteral warning.
1235
1236 2019-10-12  Simon Marchi  <simon.marchi@polymtl.ca>
1237
1238         * breakpoint.c: Remove some includes: continuations.h, skip.h,
1239         mi/mi-main.h, readline/readline.h, readline/history.h.  Add
1240         include: readline/tilde.h.
1241
1242 2019-10-12  Christian Biesinger  <cbiesinger@google.com>
1243
1244         * remote.c (remote_target::get_trace_status): Remove declaration of
1245         trace_regblock_size.
1246
1247 2019-10-12  Christian Biesinger  <cbiesinger@google.com>
1248
1249         * cli/cli-cmds.c (max_user_call_depth): Move comment to header.
1250         (show_user): Remove declaration of cmdlist.
1251         * cli/cli-cmds.h (max_user_call_depth): Declare.
1252         * cli/cli-script.c (execute_user_command): Remove declaration
1253         of max_user_call_depth.
1254
1255 2019-10-11  Jim Wilson  <jimw@sifive.com>
1256
1257         * gdbsupport/print-utils.h (pulongest): Fix comment.
1258         (plongest): Likewise.
1259         (phex): Add missing comment, mention leading zeros.
1260         (phex_nz): Add mention of no leading zeros to comment.
1261
1262         * riscv-tdep.c (riscv_push_dummy_code): Change %lld to %s and use
1263         plongest instead of unsigned long long cast.
1264
1265 2019-10-10  Christian Biesinger  <cbiesinger@google.com>
1266
1267         * main.c (captured_main_1): Include gdbtk.h and remove declarations
1268         for external_editor_command and gdbtk_test.
1269
1270 2019-10-10  Christian Biesinger  <cbiesinger@google.com>
1271
1272         * mi/mi-cmd-var.c (varobjdebug): Remove declaration.
1273         * varobj.c (varobjdebug): Move comment to...
1274         * varobj.h (varobjdebug): ...here, and declare.
1275
1276 2019-10-09  Tom Tromey  <tom@tromey.com>
1277
1278         * tui/tui-regs.c (tui_data_window::show_registers): Don't call
1279         erase_data_content.
1280
1281 2019-10-09  Tom Tromey  <tom@tromey.com>
1282
1283         * tui/tui-wingeneral.h (tui_delete_win): Don't declare.
1284         * tui/tui-stack.c (tui_locator_window::rerender): Update.
1285         * tui/tui-command.c (tui_cmd_window::resize)
1286         (tui_refresh_cmd_win): Update.
1287         * tui/tui-win.c (tui_resize_all, tui_set_focus_command): Update.
1288         * tui/tui.c (tui_rl_other_window, tui_enable): Update.
1289         * tui/tui-data.c (~tui_gen_win_info): Remove.
1290         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
1291         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
1292         (tui_redisplay_readline, tui_mld_flush)
1293         (tui_mld_erase_entire_line, tui_mld_getc, tui_getc): Update.
1294         * tui/tui-regs.c (tui_data_window::delete_data_content_windows)
1295         (tui_data_window::erase_data_content)
1296         (tui_data_item_window::rerender)
1297         (tui_data_item_window::refresh_window): Update.
1298         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window)
1299         (box_win, tui_gen_win_info::make_window)
1300         (tui_gen_win_info::make_visible): Update.
1301         (tui_delete_win): Remove.
1302         * tui/tui-winsource.c
1303         (tui_source_window_base::do_erase_source_content): Update.
1304         (tui_show_source_line, tui_source_window_base::update_tab_width)
1305         (tui_source_window_base::update_exec_info): Update.
1306         * tui/tui-data.h (struct curses_deleter): New.
1307         (struct tui_gen_win_info) <handle>: Now a unique_ptr.
1308         (struct tui_gen_win_info) <~tui_gen_win_info>: Define.
1309
1310 2019-10-09  Tom Tromey  <tom@tromey.com>
1311
1312         * tui/tui-wingeneral.h (struct tui_gen_win_info): Don't declare.
1313
1314 2019-10-09  Tom Tromey  <tom@tromey.com>
1315
1316         * tui/tui-data.c (tui_win_is_auxiliary): Remove.
1317         * tui/tui-data.h (tui_win_is_auxiliary): Don't declare.
1318
1319 2019-10-09  Tom Tromey  <tom@tromey.com>
1320
1321         * tui/tui-disasm.c (tui_get_low_disassembly_address): Compute
1322         window height directly.
1323         * tui/tui-layout.h (tui_default_win_viewport_height): Don't
1324         declare.
1325         * tui/tui-layout.c (tui_default_win_height): Remove.
1326         (tui_default_win_viewport_height): Remove.
1327
1328 2019-10-09  Tom Tromey  <tom@tromey.com>
1329
1330         * tui/tui.h: Remove comments.
1331
1332 2019-10-09  Tom de Vries  <tdevries@suse.de>
1333
1334         * python/lib/gdb/printer/bound_registers.py: Use
1335         '^builtin_type_bound128' as regexp argument for
1336         add_builtin_pretty_printer.
1337
1338 2019-10-09  Christian Biesinger  <cbiesinger@google.com>
1339
1340         * guile/guile.c (guile_extension_script_ops): Remove forward
1341         declaration and mark as static.
1342         (guile_script_ops): Likewise.
1343         (extension_language_guile): Move further down in the file so
1344         it can reference the definitions for guile_{extension_,}script_ops.
1345
1346 2019-10-09  Andreas Arnez  <arnez@linux.ibm.com>
1347
1348         * s390-tdep.c (390_process_record): Handle new arch13 instructions
1349         except SORTL, DFLTCC, and KDSA.
1350
1351 2019-10-08  Tom Tromey  <tromey@adacore.com>
1352
1353         * windows-nat.c (struct windows_thread_info_struct) <sf>: Remove.
1354         (struct safe_symbol_file_add_args): Remove.
1355
1356 2019-10-08  Tom Tromey  <tromey@adacore.com>
1357
1358         * windows-nat.c: Don't include buildsym-legacy.h.
1359
1360 2019-10-08  Tom Tromey  <tromey@adacore.com>
1361
1362         * contrib/ari/gdb_ari.sh (%p): Allow gdb-specific %p extensions.
1363
1364 2019-10-08  Christian Biesinger  <cbiesinger@google.com>
1365
1366         * gdbtypes.c (overload_debug): Move comment to header.
1367         * gdbtypes.h (overload_debug): Declare.
1368         * valops.c: Remove declaration of overload_debug, instead
1369         include gdbtypes.h.
1370
1371 2019-10-08  Christian Biesinger  <cbiesinger@google.com>
1372
1373         * language.c (show_language_command): Pass lang_frame_mismatch_warn
1374         through _().
1375         (lang_frame_mismatch_warn): Make const, mark with N_(), and
1376         move comment...
1377         * language.h (lang_frame_mismatch_warn): ... here. Also add
1378         declaration.
1379         * top.c (lang_frame_mismatch_warn): Remove declaration.
1380         (check_frame_language_change): Pass lang_frame_mismatch_warn
1381         through _().
1382
1383 2019-10-07  Christian Biesinger  <cbiesinger@google.com>
1384
1385         * c-lang.h (vtbl_ptr_name): Declare.
1386         * cp-valprint.c (vtbl_ptr_name): Remove "extern" now that we get
1387         it from the header.
1388         * stabsread.c (define_symbol): Remove declaration of vtbl_ptr_name.
1389
1390 2019-10-07  Christian Biesinger  <cbiesinger@google.com>
1391
1392         * charset.c (your_gdb_wchar_t_is_bogus): Replace with a
1393         gdb_static_assert.
1394
1395 2019-10-07  Weimin Pan  <weimin.pan@oracle.com>
1396
1397         * ../Makefile.def (dependencies): Add all-libctf to all-gdb
1398         * ../Makefile.in: Add "all-gdb: maybe-all-libctf"
1399         * ctfread.c: New file.
1400         * ctfread.h: New file.
1401         * elfread.c: Include ctfread.h.
1402         (struct elfinfo text_p): New member ctfsect.
1403         (elf_locate_sections): Mark CTF section.
1404         (elf_symfile_read): Call elfctf_build_psymtabs.
1405         * Makefile.in (LIBCTF): Add.
1406         (CLIBS): Use it.
1407         (CDEPS): Likewise.
1408         (DIST): Add ctfread.c.
1409
1410 2019-10-07  Andrew Burgess  <andrew.burgess@embecosm.com>
1411
1412         * ctfread.c (struct nextfield): Renamed to ...
1413         (struct ctf_nextfield): ... this.
1414         (struct field_info): Renamed to ...
1415         (strut ctf_field_info): ... this.
1416         (attach_fields_to_type): Update for renamed structures.
1417         (ctf_add_member_cb): Likewise.
1418         (ctf_add_enum_member_cb): Likewise.
1419         (process_struct_members): Likewise.
1420         (process_enum_type): Likewise.
1421
1422 2019-10-07  Weimin Pan  <weimin.pan@oracle.com>
1423
1424         * tracectf.h: Rename, was ctf.h.
1425         * tracectf.c: Rename, was ctf.c, replace ctf.h with tracectf.h.
1426         * tracefile.c: Likewise.
1427         * tracepoint.c: Remove unused include ctf.h.
1428         * mi/mi-main.c: Likewise.
1429         * Makefile.in Replace ctf.c with tracectf.c.
1430
1431 2019-10-06  Joel Brobecker  <brobecker@adacore.com>
1432
1433         * version.in: Change version number to "9.0.50.DATE-git".
1434
1435 2019-10-03  Tom Tromey  <tom@tromey.com>
1436
1437         PR rust/24976:
1438         * dwarf2read.c (quirk_rust_enum): Handle single-element unions.
1439
1440 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1441
1442         * f-lang.c (f_language_defn): Use cp_get_symbol_name_matcher and
1443         cp_search_name_hash.
1444         * NEWS: Add entry about nested function support.
1445
1446 2019-10-03  Bernhard Heckel  <bernhard.heckel@intel.com>
1447             Andrew Burgess  <andrew.burgess@embecosm.com>
1448
1449         * cp-namespace.c (cp_search_static_and_baseclasses): Only search
1450         for nested static variables when searchin VAR_DOMAIN.
1451         * dwarf2read.c (add_partial_symbol): Add nested subroutines to the
1452         global scope, update comment.
1453         (add_partial_subprogram): Call add_partial_subprogram recursively
1454         for nested subroutines when processinng Fortran.
1455         (load_partial_dies): Process the child entities of a subprogram
1456         when processing Fortran.
1457         (partial_die_parent_scope): Handle building scope
1458         for Fortran nested functions.
1459         (process_die): Record that nested functions have a scope.
1460         (new_symbol): Always record Fortran subprograms on the global
1461         symbol list.
1462         (determine_prefix): How to build the prefix for Fortran
1463         subprograms.
1464
1465 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1466
1467         * linux-nat.c (linux_nat_filter_event): Don't ignore SIGSTOP if we
1468         have just sent the thread a SIGSTOP and are waiting for it to
1469         arrive.
1470
1471 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1472
1473         * btrace.c (btrace_add_pc): Remove whitespace before the template
1474         parameter in 'std::vector <...>'.
1475         (parse_xml_btrace_block): Likewise.
1476         (btrace_maint_decode_pt): Likewise.
1477         (btrace_maint_update_packets): Likewise.
1478         (btrace_maint_print_packets): Likewise.
1479         * btrace.h (struct btrace_maint_info): Likewise.
1480         * dwarf2read.c (struct type_unit_group): Likewise.
1481         (build_type_psymtabs_reader): Likewise.
1482         * gdbsupport/btrace-common.c (btrace_data_append): Likewise.
1483         * gdbsupport/btrace-common.h (struct btrace_data_bts): Likewise.
1484         * nat/linux-btrace.c (perf_event_read_bts): Likewise.
1485
1486 2019-10-03  Tom de Vries  <tdevries@suse.de>
1487
1488         * cli/cli-style.c (_initialize_cli_style): Adding a '.' at the end of
1489         the first line of the help text for set/show style metadata.
1490
1491 2019-10-02  Tom Tromey  <tromey@adacore.com>
1492
1493         * Makefile.in (COMMON_SFILES): Add common-inferior.c.
1494         * gdbsupport/common-inferior.c: New file.
1495         * infcmd.c (startup_with_shell): Don't define.
1496         * nat/fork-inferior.h (startup_with_shell): Don't declare.
1497         * gdbsupport/common-inferior.h (startup_with_shell): Declare.
1498         * inferior.h (startup_with_shell): Don't declare.
1499
1500 2019-10-02  Christian Biesinger  <cbiesinger@google.com>
1501
1502         * gdbsupport/gdb_assert.h: Include errors.h.
1503         * gdbsupport/gdb_string_view.h: Include gdb_assert.h.
1504
1505 2019-10-02  Tom Tromey  <tromey@adacore.com>
1506
1507         * NEWS: Add $_ada_exception entry.
1508         * ada-lang.c (struct ada_catchpoint): Add constructor.
1509         <m_kind>: New member.
1510         (allocate_location_exception, re_set_exception): Remove
1511         "ex" parameter.
1512         (should_stop_exception): Compute $_ada_exception.
1513         (check_status_exception, print_it_exception)
1514         (print_one_exception, print_mention_exception): Remove
1515         "ex" parameter.
1516         (allocate_location_catch_exception, re_set_catch_exception)
1517         (check_status_exception, print_it_catch_exception)
1518         (print_one_catch_exception, print_mention_catch_exception)
1519         (print_recreate_catch_exception)
1520         (allocate_location_catch_exception_unhandled)
1521         (re_set_catch_exception_unhandled)
1522         (check_status_exception, print_it_catch_exception_unhandled)
1523         (print_one_catch_exception_unhandled)
1524         (print_mention_catch_exception_unhandled)
1525         (print_recreate_catch_exception_unhandled)
1526         (allocate_location_catch_assert, re_set_catch_assert)
1527         (check_status_assert, print_it_catch_assert)
1528         (print_one_catch_assert, print_mention_catch_assert)
1529         (print_recreate_catch_assert)
1530         (allocate_location_catch_handlers, re_set_catch_handlers)
1531         (check_status_handlers, print_it_catch_handlers)
1532         (print_one_catch_handlers, print_mention_catch_handlers)
1533         (print_recreate_catch_handlers): Remove.
1534         (create_ada_exception_catchpoint): Update.
1535         (initialize_ada_catchpoint_ops): Update.
1536
1537 2019-10-02  Tom Tromey  <tromey@adacore.com>
1538
1539         * ada-lang.c (ada_lookup_simple_minsyms): Remove.
1540         (create_excep_cond_exprs): Simplify exception string computation.
1541         (ada_exception_catchpoint_cond_string): Likewise.
1542
1543 2019-10-02  Tom Tromey  <tromey@adacore.com>
1544
1545         * symmisc.c (dump_msymbols): Don't use MSYMBOL_VALUE_ADDRESS.
1546         * ada-lang.c (lesseq_defined_than): Handle
1547         LOC_STATIC.
1548         * dwarf2read.c (dwarf2_per_objfile): Add can_copy
1549         parameter.
1550         (dwarf2_has_info): Likewise.
1551         (new_symbol): Set maybe_copied on symbol when
1552         appropriate.
1553         * dwarf2read.h (dwarf2_per_objfile): Add can_copy
1554         parameter.
1555         <can_copy>: New member.
1556         * elfread.c (record_minimal_symbol): Set maybe_copied
1557         on symbol when appropriate.
1558         (elf_symfile_read): Update call to dwarf2_has_info.
1559         * minsyms.c (lookup_minimal_symbol_linkage): New
1560         function.
1561         * minsyms.h (lookup_minimal_symbol_linkage): Declare.
1562         * symtab.c (get_symbol_address, get_msymbol_address):
1563         New functions.
1564         * symtab.h (get_symbol_address, get_msymbol_address):
1565         Declare.
1566         (SYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_ADDRESS): Handle
1567         maybe_copied.
1568         (struct symbol, struct minimal_symbol) <maybe_copied>:
1569         New member.
1570
1571 2019-10-02  Tom Tromey  <tromey@adacore.com>
1572
1573         * source.c (struct current_source_location): New.
1574         (current_source_key): New global.
1575         (current_source_symtab, current_source_line)
1576         (current_source_pspace): Remove.
1577         (get_source_location): New function.
1578         (get_current_source_symtab_and_line)
1579         (set_default_source_symtab_and_line)
1580         (set_current_source_symtab_and_line)
1581         (clear_current_source_symtab_and_line, select_source_symtab)
1582         (info_source_command, print_source_lines_base)
1583         (info_line_command, search_command_helper, _initialize_source):
1584         Update.
1585
1586 2019-10-02  Tom Tromey  <tromey@adacore.com>
1587
1588         * source.c (select_source_symtab): Don't call
1589         decode_line_with_current_source.
1590
1591 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1592
1593         * symtab.c (lookup_global_symbol): Search global block.
1594
1595 2019-10-02  Tom Tromey  <tromey@adacore.com>
1596
1597         * coffread.c (process_coff_symbol): Update.
1598         * dwarf2read.c (var_decode_location, new_symbol): Update.
1599         * mdebugread.c (parse_symbol): Update.
1600         * objfiles.c (relocate_one_symbol): Update.
1601         * stabsread.c (define_symbol, fix_common_block)
1602         (scan_file_globals): Update.
1603         * symtab.h (SYMBOL_VALUE_ADDRESS): Expand to an rvalue.
1604         (SET_SYMBOL_VALUE_ADDRESS): New macro.
1605         * xcoffread.c (process_xcoff_symbol): Update.
1606
1607 2019-10-02  Andreas Arnez  <arnez@linux.ibm.com>
1608
1609         * MAINTAINERS: Update my email address.
1610
1611 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1612
1613         * dwarf2read.c (struct type_unit_group) <tus>: Convert to
1614         std::vector.
1615         (build_type_psymtabs_reader): Update for std::vector.
1616         (build_type_psymtab_dependencies): Likewise.
1617         * dwarf2read.h: Remove use of DEF_VEC_P.
1618         (typedef sig_type_ptr): Delete.
1619
1620 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1621
1622         * btrace.c (btrace_maint_clear): Update to handle change from VEC
1623         to std::vector.
1624         (btrace_maint_decode_pt): Likewise, and move allocation of the
1625         vector outside of the loop.
1626         (btrace_maint_update_packets): Update to handle change from VEC to
1627         std::vector.
1628         (btrace_maint_print_packets): Likewise.
1629         (maint_info_btrace_cmd): Likewise.
1630         * btrace.h: Remove use of DEF_VEC_O.
1631         (typedef btrace_pt_packet_s): Delete.
1632         (struct btrace_maint_info) <packets>: Change fromm VEC to
1633         std::vector.
1634         * gdbsupport/btrace-common.h: Remove 'vec.h' include.
1635
1636 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1637
1638         * btrace.c (btrace_compute_ftrace_bts): Update for std::vector,
1639         make accesses into the vector constant references.
1640         (btrace_add_pc): Update for std::vector.
1641         (btrace_stitch_bts): Likewise.
1642         (parse_xml_btrace_block): Likewise.
1643         (btrace_maint_update_packets): Likewise.
1644         (btrace_maint_print_packets): Likewise.
1645         (maint_info_btrace_cmd): Likewise.
1646         * gdbsupport/btrace-common.c (btrace_data::fini): Update for
1647         std::vector.
1648         (btrace_data::empty): Likewise.
1649         (btrace_data_append): Likewise.
1650         * gdbsupport/btrace-common.h: Remove use of DEF_VEC_O.
1651         (typedef btrace_block_s): Delete.
1652         (struct btrace_block): Add constructor.
1653         (struct btrace_data_bts) <blocks>: Change to std::vector.
1654         * nat/linux-btrace.c (perf_event_read_bts): Update for
1655         std::vector.
1656         (linux_read_bts): Likewise.
1657
1658 2019-10-01  Tom Tromey  <tom@tromey.com>
1659
1660         * cli/cli-logging.c (show_logging_filename): Use styled_string.
1661
1662 2019-10-01  Tom Tromey  <tom@tromey.com>
1663
1664         * stack.c (print_frame, info_frame_command_core): Use
1665         styled_string.
1666         * linux-thread-db.c (try_thread_db_load_1)
1667         (try_thread_db_load_from_pdir_1): Use styled_string.
1668         * auto-load.c (file_is_auto_load_safe, execute_script_contents)
1669         (auto_load_section_scripts, info_auto_load_local_gdbinit)
1670         (maybe_print_unsupported_script_warning)
1671         (maybe_print_script_not_found_warning): Use styled_string.
1672         * ada-lang.c (user_select_syms): Use styled_string.
1673
1674 2019-10-01  Tom Tromey  <tom@tromey.com>
1675
1676         * p-lang.c (pascal_printstr): Use metadata style.
1677         * value.c (show_convenience): Use metadata style.
1678         * valprint.c (valprint_check_validity, val_print_optimized_out)
1679         (val_print_not_saved, val_print_unavailable)
1680         (val_print_invalid_address, generic_val_print, val_print)
1681         (value_check_printable, val_print_array_elements): Use metadata
1682         style.
1683         * ui-out.h (class ui_out) <field_fmt>: New overload.
1684         <do_field_fmt>: Add style parameter.
1685         * ui-out.c (ui_out::field_fmt): New overload.
1686         * typeprint.c (type_print_unknown_return_type)
1687         (val_print_not_allocated, val_print_not_associated): Use metadata
1688         style.
1689         * tui/tui-out.h (class tui_ui_out) <do_field_fmt>: Add style
1690         parameter.
1691         * tui/tui-out.c (tui_ui_out::do_field_fmt): Update.
1692         * tracepoint.c (tvariables_info_1): Use metadata style.
1693         * stack.c (print_frame_arg, print_frame_info, print_frame)
1694         (info_frame_command_core): Use metadata style.
1695         * skip.c (info_skip_command): Use metadata style.
1696         * rust-lang.c (rust_print_enum): Use metadata style.
1697         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
1698         metadata style.
1699         * python/py-framefilter.c (py_print_single_arg): Use metadata
1700         style.
1701         * printcmd.c (do_one_display, print_variable_and_value): Use
1702         metadata style.
1703         * p-valprint.c (pascal_val_print)
1704         (pascal_object_print_value_fields): Use metadata style.
1705         * p-typeprint.c (pascal_type_print_base): Use metadata style.
1706         * mi/mi-out.h (class mi_ui_out) <do_field_fmt>: Add style
1707         parameter.
1708         * mi/mi-out.c (mi_ui_out::do_field_fmt): Update.
1709         * m2-valprint.c (m2_print_long_set): Use metadata style.
1710         * m2-typeprint.c (m2_print_type): Use metadata style.
1711         * infcmd.c (print_return_value_1): Use metadata style.
1712         * gnu-v3-abi.c (print_one_vtable): Use metadata style.
1713         * f-valprint.c (info_common_command_for_block): Use metadata
1714         style.
1715         * f-typeprint.c (f_type_print_base): Use metadata style.
1716         * expprint.c (print_subexp_standard): Use metadata style.
1717         * cp-valprint.c (cp_print_value_fields): Use metadata style.
1718         * cli/cli-style.h (class cli_style_option): Add constructor.
1719         (metadata_style): Declare.
1720         * cli/cli-style.c (metadata_style): New global.
1721         (_initialize_cli_style): Register metadata style.
1722         * cli-out.h (class cli_ui_out) <do_field_fmt>: Add style
1723         parameter.
1724         * cli-out.c (cli_ui_out::do_field_fmt): Update.
1725         * c-typeprint.c (c_type_print_base_struct_union)
1726         (c_type_print_base_1): Use metadata style.
1727         * breakpoint.c (watchpoint_value_print)
1728         (print_one_breakpoint_location): Use metadata style.
1729         * break-catch-syscall.c (print_one_catch_syscall): Use metadata
1730         style.
1731         * break-catch-sig.c (signal_catchpoint_print_one): Use metadata
1732         style.
1733         * ada-valprint.c (val_print_packed_array_elements, printstr)
1734         (print_field_values, ada_val_print_ref, ada_val_print): Use
1735         metadata style.
1736         * ada-typeprint.c (print_array_type, ada_print_type): Use metadata
1737         style.
1738         * ada-tasks.c (print_ada_task_info, info_task): Use metadata
1739         style.
1740         * ada-lang.c (user_select_syms): Use metadata style.
1741
1742 2019-10-01  Tom Tromey  <tom@tromey.com>
1743
1744         * cli/cli-cmds.c (pwd_command): Style output.
1745
1746 2019-10-01  Pedro Alves  <palves@redhat.com>
1747             Tom Tromey  <tom@tromey.com>
1748
1749         * symtab.c (print_symbol_info): Use %ps.
1750         (print_msymbol_info): Use %ps.
1751         * symfile.c (symbol_file_add_with_addrs): Use %ps.
1752         * printcmd.c (print_variable_and_value): Use %ps.
1753         * macrocmd.c (show_pp_source_pos): Use %ps.
1754         * infrun.c (print_exited_reason): Use ui_out::message.
1755         * breakpoint.c (watchpoint_check, print_one_breakpoint_location)
1756         (describe_other_breakpoints): Use ui_out::message and new
1757         formats.
1758         (say_where): Use new formats.
1759         (bkpt_print_it, tracepoint_print_one_detail): Use ui_out::message
1760         and new formats.
1761
1762 2019-10-01  Pedro Alves  <palves@redhat.com>
1763             Tom Tromey  <tom@tromey.com>
1764
1765         * unittests/format_pieces-selftests.c: Add gdb_format parameter.
1766         (test_gdb_formats): New function.
1767         (run_tests): Call it.
1768         (test_format_specifier): Update.
1769         * utils.h (fputs_filtered): Update comment.
1770         (vfprintf_styled, vfprintf_styled_no_gdbfmt)
1771         (fputs_styled_unfiltered): Declare.
1772         * utils.c (fputs_styled_unfiltered): New function.
1773         (vfprintf_maybe_filtered): Add gdbfmt parameter.
1774         (vfprintf_filtered): Update.
1775         (vfprintf_unfiltered, vprintf_filtered): Update.
1776         (vfprintf_styled, vfprintf_styled_no_gdbfmt): New functions.
1777         * ui-out.h (enum ui_out_flag) <unfiltered_output,
1778         disallow_ui_out_field>: New constants.
1779         (enum class field_kind): New.
1780         (struct base_field_s, struct signed_field_s): New.
1781         (signed_field): New function.
1782         (struct string_field_s): New.
1783         (string_field): New function.
1784         (struct styled_string_s): New.
1785         (styled_string): New function.
1786         (class ui_out) <message>: Add comment.
1787         <vmessage, call_do_message>: New methods.
1788         <do_message>: Add style parameter.
1789         * ui-out.c (ui_out::call_do_message, ui_out::vmessage): New
1790         methods.
1791         (ui_out::message): Rewrite.
1792         * mi/mi-out.h (class mi_ui_out) <do_message>: Add style
1793         parameter.
1794         * mi/mi-out.c (mi_ui_out::do_message): Add style parameter.
1795         * gdbsupport/format.h (class format_pieces) <format_pieces>: Add
1796         gdb_extensions parameter.
1797         (class format_piece): Add parameter to constructor.
1798         (n_int_args): New field.
1799         * gdbsupport/format.c (format_pieces::format_pieces): Add
1800         gdb_extensions parameter.  Handle '*'.
1801         * cli-out.h (class cli_ui_out) <do_message>: Add style parameter.
1802         * cli-out.c (cli_ui_out::do_message): Add style parameter.  Call
1803         vfprintf_styled_no_gdbfmt.
1804         (cli_ui_out::do_field_string, cli_ui_out::do_spaces)
1805         (cli_ui_out::do_text, cli_ui_out::field_separator): Allow
1806         unfiltered output.
1807         * ui-style.h (struct ui_file_style) <ptr>: New method.
1808
1809 2019-10-01  Tom Tromey  <tom@tromey.com>
1810
1811         * unittests/format_pieces-selftests.c: Update.  Add final format.
1812         * gdbsupport/format.c (format_pieces::format_pieces): Don't add
1813         empty literal pieces.
1814
1815 2019-10-01  Tom Tromey  <tom@tromey.com>
1816
1817         * ui-out.h (enum class ui_out_style_kind): Remove.
1818         (class ui_out) <field_string, field_stsream, do_field_string>:
1819         Change type of "style".
1820         * ui-out.c (ui_out::field_core_addr, ui_out::field_stream)
1821         (ui_out::field_string): Update.
1822         * tui/tui-out.h (class tui_ui_out) <do_field_string>: Change type
1823         of "style".
1824         * tui/tui-out.c (tui_ui_out::do_field_string): Update.
1825         * tracepoint.c (print_one_static_tracepoint_marker): Update.
1826         * stack.c (print_frame_arg, print_frame_info, print_frame):
1827         Update.
1828         * source.c (print_source_lines_base): Update.
1829         * solib.c (info_sharedlibrary_command): Update.
1830         * skip.c (info_skip_command): Update.
1831         * record-btrace.c (btrace_call_history_src_line)
1832         (btrace_call_history): Update.
1833         * python/py-framefilter.c (py_print_frame): Update.
1834         * mi/mi-out.h (class mi_ui_out) <do_field_string>: Change type of
1835         "style".
1836         * mi/mi-out.c (mi_ui_out::do_table_header)
1837         (mi_ui_out::do_field_signed, mi_ui_out::do_field_unsigned)
1838         (mi_ui_out::do_field_string): Update.
1839         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
1840         Update.
1841         * cli-out.h (class cli_ui_out) <do_field_string>: Change type of
1842         "style".
1843         * cli-out.c (cli_ui_out::do_table_header)
1844         (cli_ui_out::do_field_signed, cli_ui_out::do_field_unsigned)
1845         (cli_ui_out::do_field_skip, cli_ui_out::do_field_string)
1846         (cli_ui_out::do_field_fmt): Update.
1847         * breakpoint.c (print_breakpoint_location): Update.
1848         (update_static_tracepoint): Update.
1849
1850 2019-10-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1851
1852         * main.c (relocate_gdbinit_path_maybe_in_datadir): Remove std::string
1853         conversion of gdb_datadir.
1854         (captured_main_1): Remove xstrdup when assigning to gdb_datadir,
1855         remove not needed c_str ().
1856
1857 2019-09-30  Ali Tamur <tamur@google.com>
1858
1859         * dwarf2read.c (skip_one_die): Handle DW_FORM_strx forms.
1860         (dwarf2_string_attr): Likewise.
1861
1862 2019-09-30  Ali Tamur <tamur@google.com>
1863
1864         * dwarf2read.c (process_full_comp_unit): Remove whitespace at the EOL.
1865         (process_full_type_unit): Likewise.
1866         (dump_die_shallow): Likewise.
1867         (cu_debug_loc_section): Likewise.
1868
1869 2019-09-28  Christian Biesinger  <cbiesinger@google.com>
1870
1871         * minsyms.c (compare_minimal_symbols): Rename to...
1872         (minimal_symbol_is_less_than): ...this, and adjust to STL
1873         conventions (return bool, take arguments as references)
1874         (minimal_symbol_reader::install): Call std::sort instead
1875         of qsort.
1876
1877 2019-09-29  Christian Biesinger  <cbiesinger@google.com>
1878
1879         * minsyms.h (msymbol_hash): Document that this is a case-insensitive
1880         hash and why.
1881         * objfiles.h (struct objfile_per_bfd_storage) <demangled_names_hash,
1882         msymbol_hash, msymbol_demangled_hash>: Improve comments.
1883
1884 2019-09-30  Simon Marchi  <simon.marchi@polymtl.ca>
1885
1886         * psymtab.c (add_psymbol_to_list): Move comment to psympriv.h.
1887         * psympriv.h (add_psymbol_to_list): Move comment here and update
1888         it.
1889
1890 2019-09-29  Tom de Vries  <tdevries@suse.de>
1891
1892         * contrib/cc-with-tweaks.sh (get_tmpdir): New function.
1893         Use $tmpdir/$(basename "$output_file").dwz instead of
1894         "${output_file}.dwz".
1895
1896 2019-09-28  Simon Marchi  <simon.marchi@polymtl.ca>
1897
1898         PR gdb/25045
1899         * hppa-linux-nat.c: Include gdbarch.h.
1900
1901 2019-09-26  Christian Biesinger  <cbiesinger@google.com>
1902
1903         * blockframe.c (find_pc_partial_function): Change return type to bool.
1904         * elfread.c (elf_gnu_ifunc_resolve_name): Likewise.
1905         * minsyms.c (in_gnu_ifunc_stub): Likewise.
1906         (stub_gnu_ifunc_resolve_name): Likewise.
1907         * symtab.c (compare_filenames_for_search): Likewise.
1908         (compare_glob_filenames_for_search): Likewise.
1909         (matching_obj_sections): Likewise.
1910         (symbol_matches_domain): Likewise.
1911         (find_line_symtab): Change out param EXACT_MATCH to bool *.
1912         (find_line_pc): Change return type to bool.
1913         (find_line_pc_range): Likewise.
1914         (producer_is_realview): Likewise.
1915         * symtab.h (symbol_matches_domain): Likewise.
1916         (find_pc_partial_function): Likewise.
1917         (find_pc_line_pc_range): Likewise.
1918         (in_gnu_ifunc_stub): Likewise.
1919         (struct gnu_ifunc_fns) <gnu_ifunc_resolve_name>: Likewise.
1920         (find_line_pc): Likewise.
1921         (find_line_pc_range): Likewise.
1922         (matching_obj_sections): Likewise.
1923         (find_line_symtab): Change out parameter to bool.
1924         (producer_is_realview): Change return type to bool.
1925         (compare_filenames_for_search): Likewise.
1926         (compare_glob_filenames_for_search): Likewise.
1927
1928 2019-09-26  Tom Tromey  <tom@tromey.com>
1929
1930         * Makefile.in (COMMON_SFILES): Remove gdb_usleep.c.
1931         (HFILES_NO_SRCDIR): Remove gdb_usleep.h.
1932         * gdb_usleep.h: Remove.
1933         * gdb_usleep.c: Remove.
1934         * utils.c: Don't include gdb_usleep.h.
1935
1936 2019-09-26  Tom Tromey  <tromey@adacore.com>
1937
1938         * python/py-type.c (type_to_type_object): Call check_typedef
1939         for stub types.
1940
1941 2019-09-26  Tom Tromey  <tom@tromey.com>
1942
1943         * utils.h (initialize_utils): Don't declare.
1944         * top.c (gdb_init): Don't call initialize_utils.
1945         * utils.c (initialize_utils): Remove.  Move contents...
1946         (_initialize_utils): ... here.
1947
1948 2019-09-25  Tom Tromey  <tom@tromey.com>
1949
1950         * python/py-objfile.c (objfpy_get_build_id): Use bin2hex.
1951         * utils.h (make_hex_string): Don't declare.
1952         * utils.c (make_hex_string): Remove.
1953
1954 2019-09-24  Tom de Vries  <tdevries@suse.de>
1955
1956         PR gdb/23815
1957         * amd64-linux-nat.c (amd64_linux_nat_target::fetch_registers):
1958         Initialize xstateregs before ptrace PTRACE_GETREGSET call.
1959
1960 2019-09-23  Dimitar Dimitrov  <dimitar@dinux.eu>
1961
1962         * NEWS: Mention new simulator port for PRU.
1963
1964 2019-09-23  Christian Biesinger  <cbiesinger@google.com>
1965
1966         * ada-exp.y (write_object_remaining): Update.
1967         * ada-lang.c (ada_decode): Return a std::string instead of a char*
1968         and eliminate the static buffer.
1969         (ada_decode_symbol): Update.
1970         (ada_la_decode): Update.
1971         (ada_sniff_from_mangled_name): Update.
1972         (is_valid_name_for_wild_match): Update.
1973         (ada_lookup_name_info::matches): Update and simplify.
1974         (name_matches_regex): Update.
1975         (ada_add_global_exceptions): Update.
1976         * ada-lang.h (ada_decode): Update signature.
1977         * ada-varobj.c (ada_varobj_describe_simple_array_child): Update.
1978         * dwarf-index-write.c (debug_names::insert): Update.
1979
1980 2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>
1981
1982         * solib-svr4.c (svr4_iterate_over_objfiles_in_search_order): Fix
1983         formatting.
1984
1985 2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>
1986
1987         * breakpoint.h (bp_location) <inserted, permanent, duplicate>:
1988         Change "nonzero" to "true" in documentation.
1989
1990 2019-09-20  Christian Biesinger  <cbiesinger@google.com>
1991
1992         * solib-darwin.c (darwin_lookup_lib_symbol): Remove.
1993         (_initialize_darwin_solib): Don't set
1994         darwin_so_ops.lookup_lib_global_symbol.
1995         * solib-svr4.c (set_solib_svr4_fetch_link_map_offsets): Call
1996         set_gdbarch_iterate_over_objfiles_in_search_order.
1997         (elf_lookup_lib_symbol): Rename to...
1998         (svr4_iterate_over_objfiles_in_search_order): this, and update
1999         to iterate semantics.
2000         (_initialize_svr4_solib): Don't set lookup_lib_global_symbol.
2001         * solib.c (solib_global_lookup): Remove.
2002         * solist.h (struct target_so_ops): Remove lookup_lib_global_symbol.
2003         (solib_global_lookup): Remove.
2004         * symtab.c (lookup_global_or_static_symbol): Remove call to
2005         solib_global_lookup.
2006
2007 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
2008
2009         * NEWS: Move entries about default MI version now being
2010         version 3, and about the GDB/MI fix for multi-location
2011         breakpoints to the "since GDB 8.3" section.
2012
2013 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
2014
2015         GDB 8.3.1 released.
2016
2017 2019-09-20  Ulrich Weigand  <uweigand@de.ibm.com>
2018
2019         * NEWS: Mention that Cell/B.E. debugging support was removed.
2020         * MAINTAINERS: Remove spu target.
2021
2022         * config/djgpp/fnchange.lst: Remove entries for removed files.
2023
2024         * Makefile.in (ALL_TARGET_OBS): Remove solib-spu.o,
2025         spu-multiarch.o, and spu-tdep.o.
2026         (HFILES_NO_SRCDIR): Remove solib-spu.h and spu-tdep.h.
2027         (ALLDEPFILES): Remove solib-spu.c, spu-linux-nat.c,
2028         spu-multiarch.c, and spu-tdep.c.
2029         * spu-linux-nat.c: Remove file.
2030         * spu-multiarch.c: Remove file.
2031         * spu-tdep.c: Remove file.
2032         * spu-tdep.h: Remove file.
2033         * solib-spu.c: Remove file.
2034         * solib-spu.h: Remove file.
2035
2036         * configure.host (powerpc64*-*-linux*): Remove Cell/B.E. support.
2037         * configure.nat (spu-linux): Remove.
2038         * configure.tgt (powerpc*-*-linux*): Remove solib-spu.o and
2039         solib-multiarch.o from gdb_target_obs.
2040         (spu*-*-*): Remove.
2041
2042         * arch/ppc-linux-common.h (struct ppc_linux_features): Remove "cell"
2043         feature flag.
2044         (ppc_linux_no_features): Update.
2045         * arch/ppc-linux-common.c (ppc_linux_match_description): Remove
2046         Cell/B.E. support.
2047         * arch/ppc-linux-tdesc.h (tdesc_powerpc_cell32l): Remove declaration.
2048         (tdesc_powerpc_cell64l): Likewise.
2049         * nat/ppc-linux.h (PPC_FEATURE_CELL): Remove.
2050         * ppc-linux-nat.c (ppc_linux_nat_target::read_description): Remove
2051         Cell/B.E. support.
2052         * ppc-linux-tdep.h: Do not include "solib-spu.h" or "spu-tdep.h".
2053         Do not include "features/rs6000/powerpc-cell32l.c" or
2054         "features/rs6000/powerpc-cell64l.c".
2055         (ppc_linux_spu_section): Remove.
2056         (ppc_linux_core_read_description): Remove Cell/B.E. support.
2057         (spe_context_objfile, spe_context_lm_addr, spe_context_offset,
2058         spe_context_cache_ptid, spe_context_cache_ptid): Remove.
2059         (ppc_linux_spe_context_lookup): Remove.
2060         (ppc_linux_spe_context_inferior_created): Remove.
2061         (ppc_linux_spe_context_solib_loaded): Remove.
2062         (ppc_linux_spe_context_solib_unloaded): Remove.
2063         (ppc_linux_spe_context): Remove.
2064         (struct ppu2spu_cache): Remove.
2065         (ppu2spu_prev_arch, ppu2spu_this_id, ppu2spu_prev_register): Remove.
2066         (struct ppu2spu_data): Remove.
2067         (ppu2spu_unwind_register, ppu2spu_sniffer, ppu2spu_dealloc_cache,
2068         ppu2spu_unwind): Remove.
2069         (ppc_linux_init_abi): Remove Cell/B.E. support.
2070         * rs6000-tdep.h (rs6000_gdbarch_init): Remove Cell/B.E. support.
2071
2072         * features/Makefile (rs6000/powerpc-cell32l-expedite): Remove.
2073         (rs6000/powerpc-cell64l-expedite): Likewise
2074         (WHICH): Remove rs6000/powerpc-cell32l and rs6000/powerpc-cell64l.
2075         (XMLTOC): Remove rs6000/powerpc-cell32l.xml and
2076         rs6000/powerpc-cell64l.xml.
2077         * features/rs6000/powerpc-cell32l.xml: Remove.
2078         * features/rs6000/powerpc-cell64l.xml: Likewise.
2079         * features/rs6000/powerpc-cell32l.c: Remove generated file.
2080         * features/rs6000/powerpc-cell64l.c: Likewise.
2081         * regformats/rs6000/powerpc-cell32l.dat: Remove generated file.
2082         * regformats/rs6000/powerpc-cell64l.dat: Likewise.
2083         * regformats/reg-spu.dat: Remove.
2084
2085         * target.h (enum target_object): Remove TARGET_OBJECT_SPU.
2086         * corelow.c (struct spuid_list): Remove.
2087         (add_to_spuid_list): Remove.
2088         (core_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
2089         * remote.c (PACKET_qXfer_spu_read, PACKET_qXfer_spu_write): Remove.
2090         (remote_protocol_features): Remove associated entries.
2091         (_initialize_remote): No longer initialize them.
2092         (remote_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
2093         * linux-nat.c (SPUFS_MAGIC): Remove.
2094         (linux_proc_xfer_spu): Remove.
2095         (spu_enumerate_spu_ids): Remove.
2096         (linux_nat_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
2097         * linux-tdep.c (-linux_spu_make_corefile_notes): Remove.
2098         (linux_make_corefile_notes): No longer call it.
2099
2100         * regcache.c (cooked_read_test): Remove bfd_arch_spu special case.
2101         (cooked_write_test): Likewise.
2102
2103 2019-09-20  Tom Tromey  <tom@tromey.com>
2104
2105         * NEWS: Mention case-sensitivity of TUI commands.
2106         * tui/tui-win.c (tui_set_focus_command): Now case-sensitive.
2107         (tui_set_win_height_command, parse_scrolling_args): Likewise.
2108         * tui/tui-layout.c (tui_layout_command): Now case-sensitive.
2109
2110 2019-09-20  Tom Tromey  <tom@tromey.com>
2111
2112         * tui/tui-source.c (tui_source_window::set_contents): Use
2113         make_unique_xstrdup.
2114         * tui/tui-disasm.c (tui_disasm_window::set_contents): Use
2115         make_unique_xstrdup.
2116
2117 2019-09-20  Tom Tromey  <tom@tromey.com>
2118
2119         * tui/tui-data.c: Remove separator comments.
2120         * tui/tui-layout.c: Remove separator comments.
2121         * tui/tui-win.c: Remove separator comments.
2122         * tui/tui-wingeneral.c: Remove separator comments.
2123
2124 2019-09-20  Tom Tromey  <tom@tromey.com>
2125
2126         * tui/tui.h (strcat_to_buf): Don't declare.
2127         * tui/tui.c (strcat_to_buf): Remove.
2128
2129 2019-09-20  Tom Tromey  <tom@tromey.com>
2130
2131         * tui/tui-source.h (struct tui_source_window) <m_fullname>: Rename
2132         from "fullname".
2133         * tui/tui-source.c (tui_source_window::set_contents)
2134         (tui_source_window::location_matches_p)
2135         (tui_source_window::maybe_update): Update.
2136
2137 2019-09-20  Tom Tromey  <tom@tromey.com>
2138
2139         * tui/tui-regs.h (struct tui_data_window) <get_current_group>:
2140         Update.
2141         <m_regs_content, m_regs_column_count, m_current_group>: Add "m_"
2142         prefix.
2143         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
2144         (tui_data_window::line_from_reg_element_no)
2145         (tui_data_window::first_reg_element_no_inline)
2146         (tui_data_window::show_registers)
2147         (tui_data_window::show_register_group)
2148         (tui_data_window::display_registers_from)
2149         (tui_data_window::display_registers_from_line)
2150         (tui_data_window::first_data_item_displayed)
2151         (tui_data_window::delete_data_content_windows)
2152         (tui_data_window::erase_data_content)
2153         (tui_data_window::do_scroll_vertical)
2154         (tui_data_window::refresh_window)
2155         (tui_data_window::check_register_values): Update.
2156
2157 2019-09-20  Tom Tromey  <tom@tromey.com>
2158
2159         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN): Remove define.
2160         (struct tui_locator_window) <full_name, proc_name>: Now
2161         std::string.
2162         * tui/tui-stack.c (tui_locator_window::make_status_line)
2163         (tui_locator_window::set_locator_fullname)
2164         (tui_locator_window::set_locator_info): Update.
2165         * tui/tui-source.c (tui_source_window::set_contents)
2166         (tui_source_window::showing_source_p): Update.
2167
2168 2019-09-20  Tom Tromey  <tom@tromey.com>
2169
2170         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
2171         Don't call tui_locator_win_info_ptr.
2172
2173 2019-09-20  Tom Tromey  <tom@tromey.com>
2174
2175         * tui/tui-win.c (tui_resize_all): Don't call refresh.
2176
2177 2019-09-20  Tom Tromey  <tom@tromey.com>
2178
2179         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use 1 as
2180         height for locator.
2181         * tui/tui-stack.c (tui_locator_window::rerender): Call scrollok.
2182         * tui/tui-layout.c (show_source_disasm_command, show_data)
2183         (show_source_or_disasm_and_command): Use 1 as height for locator.
2184
2185 2019-09-20  Tom Tromey  <tom@tromey.com>
2186
2187         * tui/tui.c (tui_enable): Update.
2188         * tui/tui-win.c (tui_sigwinch_handler, tui_async_resize_screen):
2189         Update.
2190         * tui/tui-data.h (tui_win_resized, tui_set_win_resized_to):
2191         Update.
2192         * tui/tui-data.c (win_resized): Now bool.
2193         (tui_win_resized): Return bool.
2194         (tui_set_win_resized_to): Accept a bool.
2195
2196 2019-09-20  Tom Tromey  <tom@tromey.com>
2197
2198         * tui/tui-regs.h (struct tui_data_window) <show_register_group>:
2199         Change type of "refresh_values_only".
2200         * tui/tui-regs.c (tui_data_window::show_register_group): Change
2201         type of "refresh_values_only".
2202
2203 2019-09-20  Tom Tromey  <tom@tromey.com>
2204
2205         * tui/tui-disasm.c (struct tui_asm_line) <addr_string, insn>: Now
2206         std::string.
2207         (tui_disassemble): Add "pos" parameter.
2208         (tui_disasm_window::set_contents): Simplify.
2209
2210 2019-09-20  Tom Tromey  <tom@tromey.com>
2211
2212         * tui/tui-winsource.h (struct tui_source_window_base)
2213         <show_source_content>: Now private.
2214         * tui/tui-winsource.c
2215         (tui_source_window_base::show_source_content): Don't handle empty
2216         content case.
2217
2218 2019-09-20  Tom Tromey  <tom@tromey.com>
2219
2220         * tui/tui-layout.c (show_source_disasm_command)
2221         (show_source_or_disasm_and_command): Don't call
2222         show_source_content.
2223
2224 2019-09-20  Tom Tromey  <tom@tromey.com>
2225
2226         * tui/tui-stack.h (struct tui_locator_window) <make_status_line>:
2227         Declare.
2228         * tui/tui-stack.c (tui_locator_window::make_status_line): Rename
2229         from tui_make_status_line.
2230         (tui_locator_window::rerender): Update.
2231
2232 2019-09-20  Tom Tromey  <tom@tromey.com>
2233
2234         * tui/tui-stack.c (tui_make_status_line): Return std::string.
2235         (tui_locator_window::rerender): Update.
2236
2237 2019-09-20  Tom Tromey  <tom@tromey.com>
2238
2239         * tui/tui-winsource.h (struct tui_source_window_base)
2240         <~tui_source_window_base>: Don't declare.
2241         <fullname>: Remove.
2242         * tui/tui-winsource.c (~tui_source_window_base): Remove.
2243         * tui/tui-source.h (struct tui_source_window) <fullname>: New
2244         member.
2245         * tui/tui-source.c (tui_source_window::set_contents): Update.
2246         (tui_source_window::location_matches_p)
2247         (tui_source_window::maybe_update): Update.
2248
2249 2019-09-20  Tom Tromey  <tom@tromey.com>
2250
2251         * tui/tui-winsource.h (~tui_source_element): Remove.
2252         (tui_source_element): Update.
2253         (struct tui_source_element) <line>: Now a unique_xmalloc_ptr.
2254         * tui/tui-winsource.c (tui_show_source_line): Update.
2255         * tui/tui-source.c (tui_source_window::set_contents): Update.
2256         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
2257
2258 2019-09-20  Tom Tromey  <tom@tromey.com>
2259
2260         * tui/tui-data.h (tui_clear_source_windows_detail): Don't
2261         declare.
2262         * tui/tui-layout.c (tui_add_win_to_layout): Don't call
2263         tui_clear_source_windows_detail.
2264         * tui/tui-winsource.h (struct tui_source_window_base)
2265         <clear_detail>: Don't declare.
2266         * tui/tui-winsource.c (tui_source_window_base::clear_detail):
2267         Remove.
2268         * tui/tui-data.c (tui_clear_source_windows_detail): Remove.
2269
2270 2019-09-20  Tom Tromey  <tromey@adacore.com>
2271
2272         PR ada/24919:
2273         * block.c (contained_in): Fix final return value.
2274
2275 2019-09-20  Alan Modra  <amodra@gmail.com>
2276
2277         * gdb_bfd.c (gdb_bfd_ref, gdb_bfd_unref): Use bfd_set_usrdata.
2278         * dwarf2read.c (dwarf2_read_gdb_index, dwarf2_read_debug_names),
2279         (read_indirect_string_from_dwz): Use bfd accessor.
2280         * dwarf2read.h (struct dwz_file <filename>): Likewise.
2281         * machoread.c (macho_symfile_read_all_oso): Likewise.
2282         * solib.c (solib_bfd_open): Likewise.
2283
2284 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
2285
2286         * eval.c: Move declaration of overload_resolution to...
2287         * value.h: ...here.
2288
2289 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
2290
2291         * arm-linux-nat.c: Remove extern declaration for arm_apcs_32.
2292         * arm-linux-tdep.c: Likewise.
2293         * arm-nbsd-nat.c: Likewise.
2294         * arm-tdep.h: Declare arm_apcs_32.
2295         * arm-tdep.c: Move documentation for arm_apcs_32 to arm-tdep.h.
2296
2297 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
2298
2299         * dwarf2loc.c: Remove extern declaration of dwarf_always_disassemble.
2300         * dwarf2read.h: Declare dwarf_always_disassemble.
2301
2302 2019-09-19  Tom de Vries  <tdevries@suse.de>
2303
2304         PR gdb/25009
2305         * source-cache.c (source_cache::ensure): Catch exception thrown during
2306         construction of the highlighter.
2307
2308 2019-09-18  Alan Modra  <amodra@gmail.com>
2309
2310         * aarch64-linux-tdep.c, * arm-tdep.c, * auto-load.c,
2311         * coff-pe-read.c, * coffread.c, * corelow.c, * dbxread.c,
2312         * dicos-tdep.c, * dwarf2-frame.c, * dwarf2read.c, * elfread.c,
2313         * exec.c, * fbsd-tdep.c, * gcore.c, * gdb_bfd.c, * gdb_bfd.h,
2314         * hppa-tdep.c, * i386-cygwin-tdep.c, * i386-fbsd-tdep.c,
2315         * i386-linux-tdep.c, * jit.c, * linux-tdep.c, * machoread.c,
2316         * maint.c, * mdebugread.c, * minidebug.c, * mips-linux-tdep.c,
2317         * mips-sde-tdep.c, * mips-tdep.c, * mipsread.c, * nto-tdep.c,
2318         * objfiles.c, * objfiles.h, * osabi.c, * ppc-linux-tdep.c,
2319         * ppc64-tdep.c, * record-btrace.c, * record-full.c, * remote.c,
2320         * rs6000-aix-tdep.c, * rs6000-tdep.c, * s390-linux-tdep.c,
2321         * s390-tdep.c, * solib-aix.c, * solib-dsbt.c, * solib-frv.c,
2322         * solib-spu.c, * solib-svr4.c, * solib-target.c,
2323         * spu-linux-nat.c, * spu-tdep.c, * symfile-mem.c, * symfile.c,
2324         * symmisc.c, * symtab.c, * target.c, * windows-nat.c,
2325         * xcoffread.c, * cli/cli-dump.c, * compile/compile-object-load.c,
2326         * mi/mi-interp.c: Update throughout for bfd section macro and
2327         function changes.
2328         * gcore (gcore_create_callback): Use bfd_set_section_lma.
2329         * spu-tdep.c (spu_overlay_new_objfile): Likewise.
2330
2331 2019-09-18  Tom Tromey  <tom@tromey.com>
2332
2333         * NEWS: Add entry.
2334         * tui/tui.c (tui_initialize_readline): Set name of keymap.  Do not
2335         call rl_initialize.
2336         (tui_enable): Do not call rl_initialize.
2337
2338 2019-09-18  Christian Groessler  <chris@groessler.org>
2339
2340         * alpha-linux-nat.c: Include gdbarch.h.
2341
2342 2019-09-18  Simon Marchi  <simon.marchi@polymtl.ca>
2343
2344         * ui-file.c: Include cli/cli-style.h.
2345         (term_cli_styling): Remove cli_styling declaration.
2346
2347 2019-09-18  Alan Modra  <amodra@gmail.com>
2348
2349         * arm-tdep.c (arm_record_special_symbol): Update bfd_get_section
2350         to bfd_asymbol_section.
2351
2352 2019-09-18  Alan Modra  <amodra@gmail.com>
2353
2354         * amd64-dicos-tdep.c (amd64_dicos_osabi_sniffer): Constify target.
2355         * i386-cygwin-tdep.c (i386_cygwin_init_abi): Likewise.
2356         * i386-dicos-tdep.c (i386_dicos_osabi_sniffer): Likewise.
2357
2358 2019-09-18  Alan Modra  <amodra@gmail.com>
2359
2360         * solib-spu.c (spu_bfd_open): Use bfd_set_filename.
2361         * spu-linux-nat.c (spu_bfd_open): Likewise.
2362
2363 2019-09-18  Christian Biesinger  <cbiesinger@google.com>
2364
2365         * dwarf2loc.c: Change extern declaration of dwarf_always_disassemble
2366         to bool to match definition in dwarf2read.c.
2367
2368 2019-09-17  Christian Biesinger  <cbiesinger@google.com>
2369
2370         * ada-lang.c (ada_ignore_descriptive_types_p): Change to bool.
2371         (print_signatures): Likewise.
2372         (trust_pad_over_xvs): Likewise.
2373         * arch/aarch64-insn.c (aarch64_debug): Likewise.
2374         * arch/aarch64-insn.h (aarch64_debug): Likewise.
2375         * arm-linux-nat.c (arm_apcs_32): Likewise.
2376         * arm-linux-tdep.c (arm_apcs_32): Likewise.
2377         * arm-nbsd-nat.c (arm_apcs_32): Likewise.
2378         * arm-tdep.c (arm_debug): Likewise.
2379         (arm_apcs_32): Likewise.
2380         * auto-load.c (debug_auto_load): Likewise.
2381         (auto_load_gdb_scripts): Likewise.
2382         (global_auto_load): Likewise.
2383         (auto_load_local_gdbinit): Likewise.
2384         (auto_load_local_gdbinit_loaded): Likewise.
2385         * auto-load.h (global_auto_load): Likewise.
2386         (auto_load_local_gdbinit): Likewise.
2387         (auto_load_local_gdbinit_loaded): Likewise.
2388         * breakpoint.c (disconnected_dprintf): Likewise.
2389         (breakpoint_proceeded): Likewise.
2390         (automatic_hardware_breakpoints): Likewise.
2391         (always_inserted_mode): Likewise.
2392         (target_exact_watchpoints): Likewise.
2393         (_initialize_breakpoint): Update.
2394         * breakpoint.h (target_exact_watchpoints): Change to bool.
2395         * btrace.c (maint_btrace_pt_skip_pad): Likewise.
2396         * cli/cli-cmds.c (trace_commands): Likewise.
2397         * cli/cli-cmds.h (trace_commands): Likewise.
2398         * cli/cli-decode.c (add_setshow_boolean_cmd): Change int* argument
2399         to bool*.
2400         * cli/cli-logging.c (logging_overwrite): Change to bool.
2401         (logging_redirect): Likewise.
2402         (debug_redirect): Likewise.
2403         * cli/cli-option.h (option_def) <boolean>: Change return type to bool*.
2404         (struct boolean_option_def) <get_var_address_cb_>: Change return type
2405         to bool.
2406         <boolean_option_def>: Update.
2407         (struct flag_option_def): Change default type of Context to bool
2408         from int.
2409         <flag_option_def>: Change return type of var_address_cb_ to bool*.
2410         * cli/cli-setshow.c (do_set_command): Cast to bool* instead of int*.
2411         (get_setshow_command_value_string): Likewise.
2412         * cli/cli-style.c (cli_styling): Change to bool.
2413         (source_styling): Likewise.
2414         * cli/cli-style.h (source_styling): Likewise.
2415         (cli_styling): Likewise.
2416         * cli/cli-utils.h (struct qcs_flags) <quiet, cont, silent>: Change
2417         to bool.
2418         * command.h (var_types): Update comment.
2419         (add_setshow_boolean_cmd): Change int* var argument to bool*.
2420         * compile/compile-cplus-types.c (debug_compile_cplus_types): Change to
2421         bool.
2422         (debug_compile_cplus_scopes): Likewise.
2423         * compile/compile-internal.h (compile_debug): Likewise.
2424         * compile/compile.c (compile_debug): Likewise.
2425         (struct compile_options) <raw>: Likewise.
2426         * cp-support.c (catch_demangler_crashes): Likewise.
2427         * cris-tdep.c (usr_cmd_cris_version_valid): Likewise.
2428         (usr_cmd_cris_dwarf2_cfi): Likewise.
2429         * csky-tdep.c (csky_debug): Likewise.
2430         * darwin-nat.c (enable_mach_exceptions): Likewise.
2431         * dcache.c (dcache_enabled_p): Likewise.
2432         * defs.h (info_verbose): Likewise.
2433         * demangle.c (demangle): Likewise.
2434         (asm_demangle): Likewise.
2435         * dwarf-index-cache.c (debug_index_cache): Likewise.
2436         * dwarf2-frame.c (dwarf2_frame_unwinders_enabled_p): Likewise.
2437         * dwarf2-frame.h (dwarf2_frame_unwinders_enabled_p): Likewise.
2438         * dwarf2read.c (check_physname): Likewise.
2439         (use_deprecated_index_sections): Likewise.
2440         (dwarf_always_disassemble): Likewise.
2441         * eval.c (overload_resolution): Likewise.
2442         * event-top.c (set_editing_cmd_var): Likewise.
2443         (exec_done_display_p): Likewise.
2444         * event-top.h (set_editing_cmd_var): Likewise.
2445         (exec_done_display_p): Likewise.
2446         * exec.c (write_files): Likewise.
2447         * fbsd-nat.c (debug_fbsd_lwp): Likewise
2448         (debug_fbsd_nat): Likewise.
2449         * frame.h (struct frame_print_options) <print_raw_frame_arguments>:
2450         Likewise.
2451         (struct set_backtrace_options) <backtrace_past_main>: Likewise.
2452         <backtrace_past_entry> Likewise.
2453         * gdb-demangle.h (demangle): Likewise.
2454         (asm_demangle): Likewise.
2455         * gdb_bfd.c (bfd_sharing): Likewise.
2456         * gdbcore.h (write_files): Likewise.
2457         * gdbsupport/common-debug.c (show_debug_regs): Likewise.
2458         * gdbsupport/common-debug.h (show_debug_regs): Likewise.
2459         * gdbthread.h (print_thread_events): Likewise.
2460         * gdbtypes.c (opaque_type_resolution): Likewise.
2461         (strict_type_checking): Likewise.
2462         * gnu-nat.c (gnu_debug_flag): Likewise.
2463         * guile/scm-auto-load.c (auto_load_guile_scripts): Likewise.
2464         * guile/scm-param.c (pascm_variable): Add boolval.
2465         (add_setshow_generic): Update.
2466         (pascm_param_value): Update.
2467         (pascm_set_param_value_x): Update.
2468         * hppa-tdep.c (hppa_debug): Change to bool..
2469         * infcall.c (may_call_functions_p): Likewise.
2470         (coerce_float_to_double_p): Likewise.
2471         (unwind_on_signal_p): Likewise.
2472         (unwind_on_terminating_exception_p): Likewise.
2473         * infcmd.c (startup_with_shell): Likewise.
2474         * inferior.c (print_inferior_events): Likewise.
2475         * inferior.h (startup_with_shell): Likewise.
2476         (print_inferior_events): Likewise.
2477         * infrun.c (step_stop_if_no_debug): Likewise.
2478         (detach_fork): Likewise.
2479         (debug_displaced): Likewise.
2480         (disable_randomization): Likewise.
2481         (non_stop): Likewise.
2482         (non_stop_1): Likewise.
2483         (observer_mode): Likewise.
2484         (observer_mode_1): Likewise.
2485         (set_observer_mode): Update.
2486         (sched_multi): Change to bool.
2487         * infrun.h (debug_displaced): Likewise.
2488         (sched_multi): Likewise.
2489         (step_stop_if_no_debug): Likewise.
2490         (non_stop): Likewise.
2491         (disable_randomization): Likewise.
2492         * linux-tdep.c (use_coredump_filter): Likewise.
2493         (dump_excluded_mappings): Likewise.
2494         * linux-thread-db.c (auto_load_thread_db): Likewise.
2495         (check_thread_db_on_load): Likewise.
2496         * main.c (captured_main_1): Update.
2497         * maint-test-options.c (struct test_options_opts) <flag_opt, xx1_opt,
2498         xx2_opt, boolean_opt>: Change to bool.
2499         * maint-test-settings.c (maintenance_test_settings_boolean): Likewise.
2500         * maint.c (maintenance_profile_p): Likewise.
2501         (per_command_time): Likewise.
2502         (per_command_space): Likewise.
2503         (per_command_symtab): Likewise.
2504         * memattr.c (inaccessible_by_default): Likewise.
2505         * mi/mi-main.c (mi_async): Likewise.
2506         (mi_async_1): Likewise.
2507         * mips-tdep.c (mips64_transfers_32bit_regs_p): Likewise.
2508         * nat/fork-inferior.h (startup_with_shell): Likewise.
2509         * nat/linux-namespaces.c (debug_linux_namespaces): Likewise.
2510         * nat/linux-namespaces.h (debug_linux_namespaces): Likewise.
2511         * nios2-tdep.c (nios2_debug): Likewise.
2512         * or1k-tdep.c (or1k_debug): Likewise.
2513         * parse.c (parser_debug): Likewise.
2514         * parser-defs.h (parser_debug): Likewise.
2515         * printcmd.c (print_symbol_filename): Likewise.
2516         * proc-api.c (procfs_trace): Likewise.
2517         * python/py-auto-load.c (auto_load_python_scripts): Likewise.
2518         * python/py-param.c (union parmpy_variable): Add "bool boolval" field.
2519         (set_parameter_value): Update.
2520         (add_setshow_generic): Update.
2521         * python/py-value.c (copy_py_bool_obj): Change argument from int*
2522         to bool*.
2523         * python/python.c (gdbpy_parameter_value): Cast to bool* instead of
2524         int*.
2525         * ravenscar-thread.c (ravenscar_task_support): Change to bool.
2526         * record-btrace.c (record_btrace_target::store_registers): Update.
2527         * record-full.c (record_full_memory_query): Change to bool.
2528         (record_full_stop_at_limit): Likewise.
2529         * record-full.h (record_full_memory_query): Likewise.
2530         * remote-notif.c (notif_debug): Likewise.
2531         * remote-notif.h (notif_debug): Likewise.
2532         * remote.c (use_range_stepping): Likewise.
2533         (interrupt_on_connect): Likewise.
2534         (remote_break): Likewise.
2535         * ser-tcp.c (tcp_auto_retry): Likewise.
2536         * ser-unix.c (serial_hwflow): Likewise.
2537         * skip.c (debug_skip): Likewise.
2538         * solib-aix.c (solib_aix_debug): Likewise.
2539         * spu-tdep.c (spu_stop_on_load_p): Likewise.
2540         (spu_auto_flush_cache_p): Likewise.
2541         * stack.c (struct backtrace_cmd_options) <full, no_filters, hide>:
2542         Likewise.
2543         (struct info_print_options) <quiet>: Likewise.
2544         * symfile-debug.c (debug_symfile): Likewise.
2545         * symfile.c (auto_solib_add): Likewise.
2546         (separate_debug_file_debug): Likewise.
2547         * symfile.h (auto_solib_add): Likewise.
2548         (separate_debug_file_debug): Likewise.
2549         * symtab.c (basenames_may_differ): Likewise.
2550         (struct filename_partial_match_opts) <dirname, basename>: Likewise.
2551         (struct info_print_options) <quiet, exclude_minsyms>: Likewise.
2552         (struct info_types_options) <quiet>: Likewise.
2553         * symtab.h (demangle): Likewise.
2554         (basenames_may_differ): Likewise.
2555         * target-dcache.c (stack_cache_enabled_1): Likewise.
2556         (code_cache_enabled_1): Likewise.
2557         * target.c (trust_readonly): Likewise.
2558         (may_write_registers): Likewise.
2559         (may_write_memory): Likewise.
2560         (may_insert_breakpoints): Likewise.
2561         (may_insert_tracepoints): Likewise.
2562         (may_insert_fast_tracepoints): Likewise.
2563         (may_stop): Likewise.
2564         (auto_connect_native_target): Likewise.
2565         (target_stop_and_wait): Update.
2566         (target_async_permitted): Change to bool.
2567         (target_async_permitted_1): Likewise.
2568         (may_write_registers_1): Likewise.
2569         (may_write_memory_1): Likewise.
2570         (may_insert_breakpoints_1): Likewise.
2571         (may_insert_tracepoints_1): Likewise.
2572         (may_insert_fast_tracepoints_1): Likewise.
2573         (may_stop_1): Likewise.
2574         * target.h (target_async_permitted): Likewise.
2575         (may_write_registers): Likewise.
2576         (may_write_memory): Likewise.
2577         (may_insert_breakpoints): Likewise.
2578         (may_insert_tracepoints): Likewise.
2579         (may_insert_fast_tracepoints): Likewise.
2580         (may_stop): Likewise.
2581         * thread.c (struct info_threads_opts) <show_global_ids>: Likewise.
2582         (make_thread_apply_all_options_def_group): Change argument from int*
2583         to bool*.
2584         (thread_apply_all_command): Update.
2585         (print_thread_events): Change to bool.
2586         * top.c (confirm): Likewise.
2587         (command_editing_p): Likewise.
2588         (history_expansion_p): Likewise.
2589         (write_history_p): Likewise.
2590         (info_verbose): Likewise.
2591         * top.h (confirm): Likewise.
2592         (history_expansion_p): Likewise.
2593         * tracepoint.c (disconnected_tracing): Likewise.
2594         (circular_trace_buffer): Likewise.
2595         * typeprint.c (print_methods): Likewise.
2596         (print_typedefs): Likewise.
2597         * utils.c (debug_timestamp): Likewise.
2598         (sevenbit_strings): Likewise.
2599         (pagination_enabled): Likewise.
2600         * utils.h (sevenbit_strings): Likewise.
2601         (pagination_enabled): Likewise.
2602         * valops.c (overload_resolution): Likewise.
2603         * valprint.h (struct value_print_options) <prettyformat_arrays,
2604         prettyformat_structs, vtblprint, unionprint, addressprint, objectprint,
2605         stop_print_at_null, print_array_indexes, deref_ref, static_field_print,
2606         pascal_static_field_print, raw, summary, symbol_print, finish_print>:
2607         Likewise.
2608         * windows-nat.c (new_console): Likewise.
2609         (cygwin_exceptions): Likewise.
2610         (new_group): Likewise.
2611         (debug_exec): Likewise.
2612         (debug_events): Likewise.
2613         (debug_memory): Likewise.
2614         (debug_exceptions): Likewise.
2615         (useshell): Likewise.
2616         * windows-tdep.c (maint_display_all_tib): Likewise.
2617         * xml-support.c (debug_xml): Likewise.
2618
2619 2019-09-17  Mike Gulick  <mgulick@mathworks.com>
2620
2621         * source.c (prepare_path_for_appending): New function.
2622         (openp): Make use of new function.
2623         (find_and_open_source): Search for the compilation directory and
2624         source file as a relative path beneath the directory search path.
2625
2626 2019-09-17  Andrew Burgess  <andrew.burgess@embecosm.com>
2627
2628         * source-cache.c (source_cache::get_line_charpos): Catch
2629         exceptions and return false, this matches the behaviour documented
2630         in the header file.
2631
2632 2019-09-17  Joel Brobecker  <brobecker@adacore.com>
2633
2634         * ada-tasks.c (info_task): Remove quoting of the task's name.
2635
2636 2019-09-16  Christian Biesinger  <cbiesinger@google.com>
2637
2638         * symfile.c (auto_solib_add): Replace comment with a reference
2639         to the header file.
2640
2641 2019-09-14  Christian Biesinger  <cbiesinger@google.com>
2642
2643         * NEWS: Mention that gdb can now be compiled with Python 3
2644         on Windows.
2645
2646 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2647
2648         * maint.c (maint_print_section_data::maint_print_section_data):
2649         Force use of 'float log10 (float)' by casting the argument to
2650         float.
2651
2652 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2653
2654         * maint.c: Add 'cmath' include.
2655         (struct maint_print_section_data): New structure.
2656         (print_section_index): New function.
2657         (print_bfd_section_info): Add header comment, small whitespace
2658         cleanup, and update to call new print_section_index function.
2659         (print_objfile_section_info): Likewise.
2660         (maint_obj_section_from_bfd_section): New function.
2661         (print_bfd_section_info_maybe_relocated): New function.
2662         (maintenance_info_sections): Add header comment, always use
2663         bfd_map_over_sections instead of ALL_OBJFILE_OSECTIONS.
2664
2665 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2666
2667         * psymtab.c (find_pc_sect_psymtab): Move baseaddr local into more
2668         inner scope, add check that the objfile has psymtabs before
2669         checking psymtabs_addrmap.
2670         * psymtab.h (psymtab_storage) <psymtabs_addrmap>: Extend comment.
2671
2672 2019-09-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2673
2674         * NEWS: Announce that Ada task names are now shown at more places,
2675         and between quotes (except in info task output).
2676         * gdb/ada-tasks.c (task_to_str): New function.
2677         (display_current_task_id): Call task_to_str.
2678         (task_command_1): Likewise.
2679         (print_ada_task_info): In non-mi mode, Properly align headers and data
2680         when task-id length is > 9 (9 is the default for a 32 bits CORE_ADDR).
2681
2682 2019-09-12  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
2683
2684         * procfs.c (procfs_target::wait) <PR_FAULTED>: Get signal from
2685         prstatus.pr_lwp.pr_info instead of making it up.
2686
2687 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
2688
2689         * auto-load.c (auto_load_expand_dir_vars): Update.
2690         * defs.h (gdb_datadir): Change to std::string.
2691         (python_libdir): Likewise.
2692         (relocate_gdb_directory): Change return type to std::string.
2693         * guile/guile.c (gdbscm_data_directory): Update.
2694         (initialize_scheme_side): Update.
2695         * jit.c (jit_reader_dir): Change to std::string.
2696         (jit_reader_load_command): Update.
2697         * main.c (gdb_datadir): Change to std::string.
2698         (python_libdir): Likewise.
2699         (set_gdb_data_directory): Update.
2700         (relocate_path): Change to return std::string.
2701         (relocate_gdb_directory): Change to return std::string.
2702         (relocate_gdbinit_path_maybe_in_datadir): Update.
2703         (captured_main_1): Update.
2704         * python/python.c (do_start_initialization): Update.
2705         * top.c (show_gdb_datadir): Update.
2706         * xml-syscall.c (xml_init_syscalls_info): Update.
2707         (init_syscalls_info): Update.
2708
2709 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
2710
2711         * main.c (relocate_gdbinit_path_maybe_in_datadir): Factor this code
2712         out of get_init_files.
2713         (get_init_files): Update.
2714
2715 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
2716
2717         * main.c (get_init_files): Change to use std::string.
2718         (captured_main_1): Update.
2719         (print_gdb_help): Update.
2720
2721 2019-09-11  Ali Tamur  <tamur@google.com>
2722
2723         *gdb/target-float.c (host_float_ops<T>::to_longest): Update
2724         implementation.
2725
2726 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
2727
2728         * dbxread.c (read_dbx_symtab): Update.
2729         * dwarf2read.c (load_partial_dies): Update.
2730         * mdebugread.c (parse_partial_symbols): Update.
2731         (handle_psymbol_enumerators): Update.
2732         * psympriv.h (add_psymbol_to_list): Change type of copy_names to bool.
2733         * psymtab.c (add_psymbol_to_bcache): Likewise.
2734         (add_psymbol_to_list): Likewise.
2735         * symtab.c (symbol_set_names): Likewise.
2736         * symtab.h (symbol_set_names): Likewise.
2737         * xcoffread.c (scan_xcoff_symtab): Update.
2738
2739 2019-09-11  Tom Tromey  <tom@tromey.com>
2740
2741         * symfile-mem.c (symbol_file_add_from_memory): Use
2742         bfd_set_filename.
2743         * solib-darwin.c (darwin_bfd_open): Use bfd_set_filename.
2744         * solib-aix.c (solib_aix_bfd_open): Use bfd_set_filename.
2745
2746 2019-09-10  Tom Tromey  <tromey@adacore.com>
2747
2748         * dwarf-index-write.c (write_psymbols): Extend error message.
2749         (debug_names::insert): Add Ada code.
2750         (debug_names::write_psymbols): Remove Ada check.
2751         (debug_names) <m_string_obstack>: New member.
2752         * dwarf2read.c (gdb_index_symbol_name_matcher): Remove.
2753         (gdb_index_symbol_name_matcher::matches): Remove.
2754         (mapped_index_base::find_name_components_bounds): Add "lang"
2755         parameter.
2756         (mapped_index_base::build_name_components): Also split names
2757         according to Ada syntax.
2758         (dw2_expand_symtabs_matching_symbol): Loop over languages.  Change
2759         type of "match_callback".
2760         (check_match, check_find_bounds_finds)
2761         (dw2_expand_symtabs_matching): Update.
2762         (dw2_debug_names_iterator): Add new constructor.
2763         (dw2_debug_names_map_matching_symbols): New function.
2764         (dw2_debug_names_expand_symtabs_matching): Update.
2765         (dwarf2_debug_names_functions): Use
2766         dw2_debug_names_map_matching_symbols.
2767
2768 2019-09-10  Tom Tromey  <tromey@adacore.com>
2769
2770         * dwarf2read.c (dw2_get_file_names_reader): Add the
2771         CU's file name to the results.
2772
2773 2019-09-10  Tom Tromey  <tromey@adacore.com>
2774
2775         * ada-lang.c (add_nonlocal_symbols): Combine calls to
2776         map_matching_symbols.  Update.
2777         * dwarf2read.c (dw2_map_matching_symbols): Update.
2778         * psymtab.c (match_partial_symbol): Change type; update.
2779         (psym_map_matching_symbols): Likewise.
2780         * symfile-debug.c (debug_qf_map_matching_symbols): Change
2781         type; update.
2782         * symfile.h (struct quick_symbol_functions)
2783         <map_matching_symbols>: Change "name" to be a lookup_name_info.
2784         Remove "match".
2785
2786 2019-09-10  Tom Tromey  <tromey@adacore.com>
2787
2788         * psymtab.c (map_block): Remove.
2789         (psym_map_matching_symbols): Use iterate_over_symbols_terminated.
2790         * symtab.c (iterate_over_symbols_terminated): New function.
2791         * symtab.c (iterate_over_symbols_terminated): Declare.
2792
2793 2019-09-10  Tom Tromey  <tromey@adacore.com>
2794
2795         * ada-lang.c (ada_iterate_over_symbols): Return bool.
2796         * language.h (struct language_defn) <la_iterate_over_symbols>:
2797         Return bool.
2798         * symtab.c (iterate_over_symbols): Return bool.
2799         * symtab.h (iterate_over_symbols): Return bool.
2800
2801 2019-09-10  Tom Tromey  <tromey@adacore.com>
2802
2803         * ada-lang.c (aux_add_nonlocal_symbols): Change type.
2804         (add_nonlocal_symbols): Update.
2805         * dwarf2read.c (dw2_map_matching_symbols): Change type.
2806         * psymtab.c (map_block, psym_map_matching_symbols): Change type.
2807         * symfile-debug.c (debug_qf_map_matching_symbols): Change type.
2808         * symfile.h (struct quick_symbol_functions) <map_matching_symbols>:
2809         Change type of "callback".  Remove "data".
2810
2811
2812 2019-09-09  Ali Tamur  <tamur@google.com>
2813
2814         * dwarf2read.c (comp_unit_head): Update comment.
2815         (dwarf2_dwo_name): New function declaration.
2816         (dwarf_unit_type_name): New function declaration.
2817         (read_comp_unit_head): Add support for new compilation units,
2818         DW_UT_partial, DW_UT_skeleton, DW_UT_split_compile, DW_UT_split_type.
2819         Particularly, DW_UT_skeleton and DW_UT_split_compile have dwo_id
2820         (currently named as "signature") in their header. Also clarify error
2821         messages.
2822         (lookup_dwo_id): New function. Returns the dwo id of the given
2823         compile unit.
2824         (lookup_dwo_unit): Use the new lookup_dwo_id function.
2825         (init_cutu_and_read_dies): Use the new dwarf2_dwo_name and lookup_dwo_id
2826         functions.
2827         (create_dwo_cu_reader): Use the added lookup_dwo_id function.
2828         (dwarf2_dwo_name): Get the dwo name if present.
2829         (dwarf_unit_type_name): Convert DW_UT_* types to string for diagnostic
2830         purposes.
2831
2832 2019-09-09  Tom Tromey  <tom@tromey.com>
2833
2834         * tui/tui-win.c (tui_all_windows_info): Use ui_out.
2835
2836 2019-09-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2837
2838         * python/python.c (do_start_initialization): Make progname_copy static,
2839         to avoid a leak report.
2840
2841 2019-09-08  Tom Tromey  <tom@tromey.com>
2842
2843         * tui/tui-wingeneral.c (box_win): Truncate long window titles.
2844
2845 2019-09-07  Simon Marchi  <simon.marchi@efficios.com>
2846
2847         * dwarf2read.c (struct dw2_symtab_iterator) <block_index>:
2848         Change type to gdb::optional<block_enum>.
2849         (dw2_symtab_iter_init): Change block_index parameter type
2850         to gdb::optional<block_enum>.
2851         (dw2_lookup_symbol): Change block_index parameter
2852         type to block_enum.c
2853         (dw2_debug_names_lookup_symbol): Likewise.
2854         * psymtab.c (psym_lookup_symbol): Likewise.
2855         * symfile-debug.c (debug_qf_lookup_symbol): Likewise.
2856         * symfile.h (struct quick_symbol_functions) <lookup_symbol>:
2857         Likewise.
2858
2859 2019-09-06  Christian Biesinger  <cbiesinger@google.com>
2860
2861         * defs.h (relocate_gdb_directory): Change int to bool in
2862         signature and rename flag to relocatable.
2863         * main.c (relocate_path): Likewise.
2864         (relocate_gdb_directory): Likewise.
2865
2866 2019-09-06  Alan Modra  <amodra@gmail.com>
2867
2868         * coffread.c (coff_symfile_read): Constify filename variable.
2869         * dbxread.c (dbx_symfile_init, coffstab_build_psymtabs),
2870         (elfstab_build_psymtabs, stabsect_build_psymtabs): Likewise.
2871         * gdb_bfd.c (gdb_bfd_close_or_warn): Likewise.
2872         * solib.c (reload_shared_libraries_1): Likewise.
2873         * symfile.c (reread_symbols): Likewise.
2874         * solib-aix.c (solib_aix_bfd_open): Add cast for xfree of filename.
2875         * solib-darwin.c (darwin_bfd_open): Likewise.
2876         * symfile-mem.c (symbol_file_add_from_memory): Likewise.
2877
2878 2019-09-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2879
2880         * psymtab.c (print_partial_symbols): Handle missing domain_enum
2881         values MODULE_DOMAIN and COMMON_BLOCK_DOMAIN.
2882
2883 2019-09-03  Tom Tromey  <tromey@adacore.com>
2884
2885         * ada-valprint.c (ada_val_print_num): Don't recurse for range
2886         types.
2887         (has_negatives): Unbias a range type bound.
2888         * dwarf2read.c (read_subrange_type): Handle DW_AT_GNU_bias.
2889         * gdbtypes.c (operator==): Handle new field.
2890         (create_range_type): Add "bias" parameter.
2891         (create_static_range_type, resolve_dynamic_range): Update.
2892         * gdbtypes.h (struct range_bounds) <bias>: New member.
2893         (create_range_type): Add bias parameter.
2894         * printcmd.c (print_scalar_formatted): Unbias range types.
2895         * value.c (unpack_long): Unbias range types.
2896         (pack_long): Bias range types.
2897
2898 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
2899
2900         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Check all
2901         probe arguments.
2902
2903 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
2904
2905         * break-catch-throw.c (fetch_probe_arguments): Use gdbarch.
2906         * dtrace-probe.c (dtrace_probe::get_argument_count): Likewise.
2907         * probe.c (probe_safe_evaluate_at_pc) (compute_probe_arg)
2908         (compile_probe_arg): Likewise.
2909         * probe.h (get_argument_count): Likewise.
2910         * solib-svr4.c (solib_event_probe_action): Likewise.
2911         * stap-probe.c (stap_probe::get_argument_count): Likewise.
2912
2913 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
2914
2915         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Move
2916         code to here...
2917         (svr4_create_solib_event_breakpoints): ...from here.
2918
2919 2019-08-30  Sergio Durigan Junior  <sergiodj@redhat.com>
2920
2921         * nat/fork-inferior.c (trace_start_error): Remove "\nError: "
2922         suffix from warning message.
2923
2924 2019-08-30  Tom Tromey  <tom@tromey.com>
2925
2926         * tui/tui-winsource.h (struct tui_source_window_base)
2927         <refresh_all>: Don't declare.
2928         * tui/tui-winsource.c (tui_source_window_base::refresh_all):
2929         Remove.
2930         * tui/tui-win.c (tui_refresh_all_win): Don't call refresh_all or
2931         tui_show_locator_content.
2932         * tui/tui-regs.h (struct tui_data_window) <refresh_all>: Don't
2933         declare.
2934         * tui/tui-regs.c (tui_data_window::refresh_all): Remove.
2935         * tui/tui-data.h (struct tui_win_info) <refresh_all>: Don't
2936         declare.
2937
2938 2019-08-30  Tom Tromey  <tom@tromey.com>
2939
2940         * tui/tui-io.c (tui_cont_sig): Don't call wrefresh.
2941
2942 2019-08-30  Tom Tromey  <tom@tromey.com>
2943
2944         * tui/tui-stack.c (_initialize_tui_stack): Move later.
2945         Remove unnecessary forward declarations.
2946
2947 2019-08-30  Tom Tromey  <tom@tromey.com>
2948
2949         * tui/tui-stack.c (tui_locator_window::set_locator_fullname): Call
2950         rerender.
2951         (tui_update_locator_fullname, tui_show_frame_info): Don't call
2952         tui_show_locator_content.
2953
2954 2019-08-30  Tom Tromey  <tom@tromey.com>
2955
2956         * tui/tui-stack.c (tui_show_locator_content): Move lower.  Rewrite.
2957         (tui_locator_window::rerender): Rewrite using body of previous
2958         tui_show_locator_content.
2959
2960 2019-08-30  Tom Tromey  <tom@tromey.com>
2961
2962         * tui/tui-stack.h (struct tui_locator_window) <set_locator_info,
2963         set_locator_fullname>: New methods.
2964         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
2965         Rename from tui_set_locator_fullname.
2966         (tui_locator_window::set_locator_info): Rename from
2967         tui_set_locator_info.  Return bool.
2968         (tui_update_locator_fullname, tui_show_frame_info): Update.
2969
2970 2019-08-30  Tom Tromey  <tom@tromey.com>
2971
2972         * tui/tui-layout.c (show_layout): Don't call tui_refresh_all.
2973
2974 2019-08-30  Tom Tromey  <tom@tromey.com>
2975
2976         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Don't
2977         call touchwin.
2978
2979 2019-08-30  Tom Tromey  <tom@tromey.com>
2980
2981         * tui/tui-wingeneral.c (box_win): Assume win_info and
2982         win_info->handle cannot be NULL.
2983
2984 2019-08-30  Tom Tromey  <tom@tromey.com>
2985
2986         * tui/tui-regs.h (struct tui_data_item_window) <rerender,
2987         refresh_window>: Declare.
2988         * tui/tui-regs.c (tui_data_window::display_registers_from): Call
2989         resize.
2990         (tui_data_item_window::rerender): Rename from
2991         tui_display_register.
2992         (tui_data_item_window::refresh_window): New method.
2993         * tui/tui-layout.c (tui_gen_win_info::resize): Do nothing on
2994         no-op.
2995
2996 2019-08-30  Tom Tromey  <tom@tromey.com>
2997
2998         * tui/tui-regs.h (struct tui_data_window) <regs_content,
2999         regs_column_count, current_group>: Move later.  Now private.
3000         <get_current_group>: New method.
3001         * tui/tui-regs.c (tui_reg_command): Update.
3002         * tui/tui-layout.c (tui_set_layout): Update.
3003
3004 2019-08-30  Tom Tromey  <tom@tromey.com>
3005
3006         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
3007         (tui_data_window::rerender): Don't call
3008         check_and_display_highlight_if_needed.
3009         (tui_data_window::refresh_all): Remove call to
3010         erase_data_content.
3011
3012 2019-08-30  Tom Tromey  <tom@tromey.com>
3013
3014         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
3015         (tui_data_window::display_registers_from)
3016         (tui_data_window::display_reg_element_at_line)
3017         (tui_data_window::display_registers_from_line): Remove checks of
3018         "empty".
3019
3020 2019-08-30  Tom Tromey  <tom@tromey.com>
3021
3022         * tui/tui-regs.h (struct tui_data_window) <display_all_data>:
3023         Don't declare.
3024         * tui/tui-regs.c (tui_data_window::show_registers): Call
3025         rerender.
3026         (tui_data_window::rerender): Rename from display_all_data.
3027         (tui_data_window::rerender): Remove old implementation.
3028
3029 2019-08-30  Tom Tromey  <tom@tromey.com>
3030
3031         * tui/tui-regs.c (tui_data_window::display_all_data): Change
3032         text.
3033         * tui/tui-data.h (NO_DATA_STRING): Remove define.
3034
3035 2019-08-29  Bernhard Wodok  <barto@gmx.net>
3036             Sergio Durigan Junior  <sergiodj@redhat.com>
3037
3038         PR win32/24284
3039         * mingw-hdep.c (gdb_select): Handle case when 'n' is zero.
3040
3041 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
3042
3043         * symtab.c (search_symbols): Don't include MODULE_DOMAIN symbols
3044         when searching for types.
3045
3046 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
3047
3048         * f-lang.c (f_language_defn): Use f_print_typedef.
3049         * f-lang.h (f_print_typedef): Declare.
3050         * f-typeprint.c (f_print_typedef): Define.
3051
3052 2019-08-27  Christian Biesinger  <cbiesinger@google.com>
3053
3054         * nat/linux-namespaces.c (mnsh_main): Initialize fd (to -1).
3055
3056 2019-08-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3057
3058         * cli/cli-utils.c (info_print_options_defs): Delete.
3059         (make_info_print_options_def_group): Delete.
3060         (extract_info_print_options): Delete.
3061         (info_print_command_completer): Delete.
3062         (info_print_args_help): Add extra parameter, and optionally
3063         include text about -n flag.
3064         * cli/cli-utils.h (struct info_print_options): Delete.
3065         (extract_info_print_options): Delete declaration.
3066         (info_print_command_completer): Delete declaration.
3067         (info_print_args_help): Add extra parameter, extend header
3068         comment.
3069         * python/python.c (gdbpy_rbreak): Pass additional parameter to
3070         search_symbols.
3071         * stack.c (struct info_print_options): New type.
3072         (info_print_options_defs): New file scoped variable.
3073         (make_info_print_options_def_group): New static function.
3074         (info_print_command_completer): New static function.
3075         (info_locals_command): Update to use new local functions.
3076         (info_args_command): Likewise.
3077         (_initialize_stack): Add extra parameter to calls to
3078         info_print_args_help.
3079         * symtab.c (search_symbols): Add extra parameter, use this to
3080         possibly excluse non-debug symbols.
3081         (symtab_symbol_info): Add extra parameter, which is passed on to
3082         search_symbols.
3083         (struct info_print_options): New type.
3084         (info_print_options_defs): New file scoped variable.
3085         (make_info_print_options_def_group): New static function.
3086         (info_print_command_completer): New static function.
3087         (info_variables_command): Update to use local functions, and pass
3088         extra parameter through to symtab_symbol_info.
3089         (info_functions_command): Likewise.
3090         (info_types_command): Pass additional argument through to
3091         symtab_symbol_info.
3092         (rbreak_command): Pass extra argument to search_symbols.
3093         (_initialize_symtab): Add extra arguments for calls to
3094         info_print_args_help, and update help text for 'info variables',
3095         'whereis', and 'info functions' commands.
3096         * symtab.h (search_symbols): Add extra argument to declaration.
3097         * NEWS: Mention new flags.
3098
3099 2019-08-26  Christian Biesinger  <cbiesinger@google.com>
3100
3101         * symtab.c (lookup_static_symbol): Call the new function (and move
3102         it down to be next to lookup_global_symbol).
3103         (struct global_sym_lookup_data): Add block_enum member and rename to...
3104         (struct global_or_static_sym_lookup_data): ...this.
3105         (lookup_symbol_global_iterator_cb): Pass block_index instead of
3106         GLOBAL_BLOCK to lookup_symbol_in_objfile and rename to...
3107         (lookup_symbol_global_or_static_iterator_cb): ...this.
3108         (lookup_global_or_static_symbol): New function.
3109         (lookup_global_symbol): Call new function.
3110
3111 2019-08-26  Tom de Vries  <tdevries@suse.de>
3112
3113         PR c++/24852
3114         * break-catch-throw.c (fetch_probe_arguments): Improve error mesage
3115         when pc_probe.prob == NULL.
3116
3117 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
3118
3119         * dwarf2read.c (dw2_debug_names_iterator::next): Rename local
3120         variable symbol_linkage to symbol_linkage_.
3121
3122 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
3123
3124         * dwarf2read.c (dw2_debug_names_iterator::next): Use enum to
3125         represent whether the symbol is static, dynamic, or we don't
3126         know.
3127
3128 2019-08-25  Yoshinori Sato <ysato@users.sourceforge.jp>
3129
3130         * gdb/rx-tdep.c (rx_register_names): New.
3131         (rx_register_name): Delete.
3132         (rx_psw_type): Delete.
3133         (rx_fpsw_type): Delete.
3134         (rx_register_type): Delete.
3135         (rx_gdbarch_init): Convert target-descriptions.
3136         (_initialize_rx_tdep): Add initialize_tdesc_rx.
3137         * gdb/features/Makefile: Add rx.xml.
3138         * gdb/features/rx.xml: New.
3139         * gdb/features/rx.c: Generated.
3140         * gdb/NEWS: Mention target description support.
3141
3142 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
3143
3144         * symtab.c (symbol_cache_lookup): Always initialize *bsc_ptr and
3145         *slot_ptr.
3146
3147 2019-08-23  Sergio Durigan Junior  <sergiodj@redhat.com>
3148
3149         * configure.ac: Don't check for 'dlfcn.h' (moved to
3150         gdbsupport/common.m4).
3151         * Makefile.in (COMMON_SFILES): Move 'gdb-dlfcn.c' to
3152         'gdbsupport/'.
3153         (HFILES_NO_SRCDIR): Likewise, for 'gdb-dlfcn.h'.
3154         * compile/compile-c-support.c: Include
3155         'gdbsupport/gdb-dlfcn.h'.
3156         * gdbsupport/common.m4: Check for 'dlfcn.h'.
3157         * gdb-dlfcn.c: Move to...
3158         * gdbsupport/gdb-dlfcn.c: ... here.
3159         * gdb-dlfcn.h: Move to...
3160         * gdbsupport/gdb-dlfcn.h: ... here.
3161
3162 2019-08-23  Sandra Loosemore  <sandra@codesourcery.com>
3163
3164         * nios2-tdep.c (struct reg_value): Improve comments.  Make
3165         the offset field signed.
3166
3167 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
3168
3169         * python/lib/gdb/__init__.py (_execute_file): New function.
3170         * python/python.c (python_run_simple_file): Call gdb._execute_file
3171         on Windows.
3172
3173 2019-08-22  Andrew Burgess  <andrew.burgess@embecosm.com>
3174
3175         * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
3176         all uses as this was never set to anything but a zero value.
3177
3178 2019-08-21  Bogdan Harjoc  <harjoc@gmail.com>
3179
3180         * cli/cli-cmds.c (with_command_1): Error out if no arguments.
3181
3182 2019-08-21  Christian Biesinger  <cbiesinger@google.com>
3183
3184         * tui/tui-data.h (tui_gen_win_info): Add an =default
3185         move constructor, required by some GCC versions.
3186
3187 2019-08-21  Jinke Fan  <fanjinke51@yeah.net>
3188
3189         * go32-nat.c (go32_sysinfo): Add hygon_p.
3190
3191 2019-08-20  Tom Tromey  <tom@tromey.com>
3192
3193         * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
3194         line_from_reg_element_no, first_reg_element_no_inline,
3195         display_all_data, delete_data_content_windows,
3196         erase_data_content>: Now private.
3197
3198 2019-08-20  Tom Tromey  <tom@tromey.com>
3199
3200         * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
3201         (tui_unhighlight_win, tui_highlight_win)
3202         (tui_win_info::make_window): Update.
3203         * tui/tui-data.h (HILITE, NO_HILITE): Remove.
3204
3205 2019-08-20  Tom Tromey  <tom@tromey.com>
3206
3207         * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
3208         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
3209         (MAX_PID_WIDTH): Move to tui-stack.c.
3210         * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
3211         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
3212         (MAX_PID_WIDTH): Move from tui-data.h.
3213
3214 2019-08-20  Tom Tromey  <tom@tromey.com>
3215
3216         * tui/tui-wingeneral.h (tui_make_window): Don't declare.
3217         * tui/tui-wingeneral.c (box_win): Change type of win_info.
3218         (box_win): Update.
3219         (tui_gen_win_info::make_window): Rename from tui_make_window.
3220         (tui_win_info::make_window): New method.
3221         (tui_gen_win_info::make_visible): Update.
3222         * tui/tui-source.c (tui_source_window::set_contents): Update.
3223         * tui/tui-regs.c (tui_data_window::show_register_group): Update.
3224         (tui_data_window::display_registers_from): Update.
3225         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
3226         * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
3227         Declare.
3228         <can_box>: Remove.
3229         <title>: Remove.
3230         (struct tui_win_info) <make_window>: Declare.
3231         <can_box>: Now virtual.
3232         <title>: New member.
3233         * tui/tui-data.c (~tui_gen_win_info): Don't free title.
3234         * tui/tui-command.c (tui_cmd_window::resize): Update.
3235
3236 2019-08-20  Tom Tromey  <tom@tromey.com>
3237
3238         * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
3239         * tui/tui-regs.c (tui_data_window::show_registers): Update.
3240         (tui_data_window::check_register_values): Update.
3241
3242 2019-08-20  Tom Tromey  <tom@tromey.com>
3243
3244         * tui/tui-regs.h (struct tui_data_window): Use
3245         DISABLE_COPY_AND_ASSIGN.
3246         <regs_content>: Change type, removing unique_ptr.
3247         <tui_data_window>: Add move constructor.
3248         * tui/tui-regs.c (tui_data_window::show_registers)
3249         (tui_data_window::show_register_group)
3250         (tui_data_window::display_registers_from)
3251         (tui_data_window::display_registers_from)
3252         (tui_data_window::first_data_item_displayed)
3253         (tui_data_window::delete_data_content_windows)
3254         (tui_data_window::rerender, tui_data_window::refresh_window)
3255         (tui_data_window::check_register_values): Update.
3256
3257 2019-08-20  Tom Tromey  <tom@tromey.com>
3258
3259         * tui/tui-regs.h (struct tui_data_window) <show_registers,
3260         show_register_group>: Declare.
3261         (tui_show_register_group): Don't declare.
3262         * tui/tui-regs.c (tui_data_window::show_registers): Rename from
3263         tui_show_registers.
3264         (tui_data_window::show_register_group): Rename from
3265         tui_show_register_group.
3266         (tui_data_window::check_register_values, tui_reg_command):
3267         Update.
3268         * tui/tui-layout.c (tui_set_layout): Update.
3269
3270 2019-08-20  Tom Tromey  <tom@tromey.com>
3271
3272         * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
3273         Declare.
3274         (tui_check_register_values): Don't declare.
3275         * tui/tui-regs.c (tui_data_window::check_register_values): Rename
3276         from tui_check_register_values.
3277         * tui/tui-hooks.c (tui_register_changed): Update.
3278
3279 2019-08-20  Tom Tromey  <tom@tromey.com>
3280
3281         * tui/tui-regs.c (tui_reg_layout): Move later.
3282         (tui_show_registers): Don't enable TUI mode or change layout.
3283
3284 2019-08-20  Tom Tromey  <tom@tromey.com>
3285
3286         * tui/tui-regs.h (struct tui_data_item_window)
3287         <~tui_data_item_window>: Remove.
3288         <content>: Now a unique_xmalloc_ptr.
3289         * tui/tui-regs.c (tui_register_format): Return a
3290         unique_xmalloc_ptr.
3291         (tui_get_register): Update.
3292         (~tui_data_item_window): Remove.
3293         (tui_data_window::display_registers_from, tui_display_register):
3294         Update.
3295         * tui/tui-io.h (tui_expand_tabs): Update.
3296         * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
3297         Remove "col" parameter.
3298
3299 2019-08-20  Tom Tromey  <tom@tromey.com>
3300
3301         * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
3302         field.
3303         * tui/tui-regs.c (~tui_data_item_window): Update.
3304
3305 2019-08-20  Tom Tromey  <tom@tromey.com>
3306
3307         * tui/tui-regs.c (tui_register_format, tui_get_register): Move
3308         earlier.
3309
3310 2019-08-20  Tom Tromey  <tom@tromey.com>
3311
3312         * tui/tui-regs.c (tui_reg_command): Remove NULL check.
3313
3314 2019-08-20  Tom Tromey  <tom@tromey.com>
3315
3316         * tui/tui-source.h (struct tui_source_window): Update.
3317         * tui/tui-regs.c (tui_show_registers): Update.
3318         * tui/tui-disasm.h (struct tui_disasm_window): Update.
3319         * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
3320         (NO_REGS_STRING): Remove defines.
3321
3322 2019-08-20  Conrad Meyer  <cem@FreeBSD.org>
3323
3324         * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
3325         unnecessary thread walk if remote doesn't support the packet.
3326
3327 2019-08-19  Tom Tromey  <tromey@adacore.com>
3328
3329         * python/py-value.c (value_has_field): Fix indentation.
3330
3331 2019-08-19  Tom Tromey  <tromey@adacore.com>
3332
3333         * printcmd.c (do_one_display, info_display_command): Update.
3334         * block.h (contained_in): Return bool.  Add allow_nested
3335         parameter.
3336         * block.c (contained_in): Return bool.  Add allow_nested
3337         parameter.
3338
3339 2019-08-19  Tom Tromey  <tom@tromey.com>
3340
3341         * configure: Rebuild.
3342         * configure.ac: Disallow the combination of -static-libstdc++ and
3343         source highlight.
3344         * source-cache.c (get_language_name): Handle rust.
3345         (source_cache::get_source_lines): Ignore highlighting exceptions.
3346
3347 2019-08-16  Tom Tromey  <tom@tromey.com>
3348
3349         * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
3350         * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
3351         (struct tui_source_window_base) <make_visible, refresh_window,
3352         resize>: Remove methods.
3353         <execution_info>: Remove field.
3354         * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
3355         (tui_show_source_line, tui_source_window_base)
3356         (~tui_source_window_base): Update.
3357         (tui_source_window_base::resize)
3358         (tui_source_window_base::make_visible)
3359         (tui_source_window_base::refresh_window): Remove.
3360         (tui_source_window_base::update_exec_info): Update.
3361         * tui/tui-source.c (tui_source_window::set_contents): Update.
3362         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
3363
3364 2019-08-16  Tom Tromey  <tom@tromey.com>
3365
3366         * tui/tui-hooks.c (tui_remove_hooks): Don't set
3367         deprecated_query_hook.
3368
3369 2019-08-16  Tom Tromey  <tom@tromey.com>
3370
3371         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
3372         (tui_update_source_windows_with_line): Update.
3373         * tui/tui-source.h (struct tui_source_window)
3374         <show_symtab_source>: Declare.
3375         (tui_show_symtab_source): Don't declare.
3376         * tui/tui-source.c (tui_show_symtab_source): Rename from
3377         tui_show_symtab_source.
3378
3379 2019-08-16  Tom Tromey  <tom@tromey.com>
3380
3381         * tui/tui-winsource.h (struct tui_source_window_base)
3382         <set_contents>: Declare.
3383         * tui/tui-winsource.c
3384         (tui_source_window_base::update_source_window_as_is): Update.
3385         * tui/tui-source.h (struct tui_source_window) <set_contents>:
3386         Declare.
3387         (tui_set_source_content): Don't declare.
3388         * tui/tui-source.c (tui_source_window::set_contents): Rename from
3389         tui_set_source_content.
3390         * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
3391         Declare.
3392         (tui_set_disassem_content): Don't declare.
3393         * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
3394         tui_set_disassem_content.
3395
3396 2019-08-16  Tom Tromey  <tom@tromey.com>
3397
3398         * tui/tui-winsource.h (struct tui_source_window_base)
3399         <update_breakpoint_info>: Declare.
3400         (tui_update_breakpoint_info): Don't declare.
3401         * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
3402         (tui_update_all_breakpoint_info): Update.
3403         (tui_source_window_base::update_breakpoint_info): Rename from
3404         tui_update_breakpoint_info.
3405         (tui_source_window_base::update_exec_info): Update.
3406
3407 2019-08-16  Tom Tromey  <tom@tromey.com>
3408
3409         * tui/tui-winsource.h (struct tui_source_window_base)
3410         <update_source_window>: Declare.
3411         (tui_update_source_window): Don't declare.
3412         * tui/tui-winsource.c
3413         (tui_source_window_base::update_source_window): Rename from
3414         tui_update_source_window.
3415         (tui_source_window_base::rerender): Update.
3416         * tui/tui-source.c (tui_source_window::maybe_update): Update.
3417         * tui/tui-disasm.c (tui_show_disassem)
3418         (tui_show_disassem_and_update_source)
3419         (tui_disasm_window::maybe_update): Update.
3420
3421 2019-08-16  Tom Tromey  <tom@tromey.com>
3422
3423         * tui/tui-winsource.h (struct tui_source_window_base)
3424         <update_source_window_as_is>: Declare.
3425         (tui_update_source_window_as_is): Don't declare.
3426         * tui/tui-winsource.c (tui_update_source_window): Update
3427         (tui_source_window_base::update_source_window_as_is): Rename from
3428         tui_update_source_window_as_is.
3429         (tui_source_window_base::refill): Update.
3430         * tui/tui-source.c (tui_show_symtab_source): Update.
3431         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
3432         Update.
3433
3434 2019-08-16  Tom Tromey  <tom@tromey.com>
3435
3436         * tui/tui-winsource.h (tui_update_source_window)
3437         (tui_update_source_window_as_is): Remove "noerror" parameter.
3438         * tui/tui-winsource.c (tui_update_source_window)
3439         (tui_update_source_window_as_is): Remove "noerror" parameter.
3440         (tui_update_source_windows_with_addr)
3441         (tui_update_source_windows_with_line)
3442         (tui_source_window_base::rerender)
3443         (tui_source_window_base::refill): Update.
3444         * tui/tui-source.h (tui_set_source_content)
3445         (tui_show_symtab_source): Remove "noerror" parameter.
3446         * tui/tui-source.c (tui_set_source_content): Remove "noerror"
3447         parameter.
3448         (tui_show_symtab_source): Likewise.
3449         (tui_source_window::maybe_update): Update.
3450         * tui/tui-disasm.c (tui_show_disassem)
3451         (tui_show_disassem_and_update_source)
3452         (tui_disasm_window::do_scroll_vertical)
3453         (tui_disasm_window::maybe_update): Update.
3454
3455 2019-08-16  Tom Tromey  <tom@tromey.com>
3456
3457         * tui/tui.c (tui_is_window_visible): Update.
3458         * tui/tui-wingeneral.c (tui_make_window)
3459         (tui_gen_win_info::make_visible, tui_refresh_all): Update.
3460         * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
3461         (tui_set_focus_command, tui_all_windows_info, update_tab_width)
3462         (tui_set_win_height_command, parse_scrolling_args): Update.
3463         * tui/tui-source.c (tui_source_window::style_changed): Update.
3464         * tui/tui-regs.c (tui_show_registers)
3465         (tui_data_window::first_data_item_displayed)
3466         (tui_data_window::delete_data_content_windows)
3467         (tui_check_register_values, tui_reg_command): Update.
3468         * tui/tui-disasm.c (tui_show_disassem): Update.
3469         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
3470         method.
3471         <is_visible>: Remove field.
3472         * tui/tui-data.c (tui_next_win, tui_prev_win)
3473         (tui_delete_invisible_windows): Update.
3474
3475 2019-08-16  Tom Tromey  <tom@tromey.com>
3476
3477         * tui/tui-winsource.h (struct tui_source_window_base)
3478         <m_has_locator>: Remove.
3479         * tui/tui-layout.c (show_source_disasm_command, show_data)
3480         (show_source_or_disasm_and_command): Update.
3481
3482 2019-08-16  Alan Hayward  <alan.hayward@arm.com>
3483
3484         * NEWS (Other MI changes): New subsection.
3485         * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
3486         (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
3487         * arch-utils.c (default_get_pc_address_flags): New function.
3488         * arch-utils.h (default_get_pc_address_flags): New declaration.
3489         * gdbarch.sh: Add get_pc_address_flags.
3490         * gdbarch.c: Regenerate.
3491         * gdbarch.h: Likewise.
3492         * stack.c (print_pc): New function.
3493         (print_frame_info) (print_frame): Call print_pc.
3494
3495 2019-08-16  Tom de Vries  <tdevries@suse.de>
3496
3497         * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
3498         print_objfile_section_info.
3499
3500 2019-08-15  Tom Tromey  <tom@tromey.com>
3501
3502         * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
3503         calling update_cmdwin_start_line.
3504         * tui/tui-winsource.h (struct tui_source_window_base)
3505         <do_make_visible_with_new_height, set_new_height>: Don't declare.
3506         <rerender>: Declare.
3507         * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
3508         Call rerender.
3509         (tui_source_window_base::set_new_height): Remove.
3510         (tui_source_window_base::rerender): Rename from
3511         do_make_visible_with_new_height.
3512         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
3513         resize method.
3514         (tui_win_info::make_invisible_and_set_new_height)
3515         (tui_win_info::make_visible_with_new_height): Remove.
3516         * tui/tui-stack.h (struct tui_locator_window) <rerender>:
3517         Declare.
3518         * tui/tui-stack.c (tui_locator_window::rerender): New method.
3519         * tui/tui-regs.h (struct tui_data_window) <set_new_height,
3520         do_make_visible_with_new_height>: Don't declare.
3521         <rerender>: Declare.
3522         * tui/tui-regs.c (tui_data_window::rerender): Rename from
3523         set_new_height.
3524         (tui_data_window::do_make_visible_with_new_height): Remove.
3525         * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
3526         call tui_show_locator_content.
3527         (tui_gen_win_info::resize): Call rerender.
3528         (show_source_or_disasm_and_command): Don't call
3529         tui_show_locator_content.
3530         * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
3531         method.
3532         (struct tui_win_info) <rerender>: Declare.
3533         <set_new_height, make_invisible_and_set_new_height,
3534         make_visible_with_new_height>: Don't declare.
3535         * tui/tui-data.c (tui_win_list::rerender): New method.
3536         * tui/tui-command.h (struct tui_cmd_window)
3537         <do_make_visible_with_new_height>: Don't declare.
3538         * tui/tui-command.c
3539         (tui_cmd_window::do_make_visible_with_new_height): Remove.
3540
3541 2019-08-15  Tom Tromey  <tromey@adacore.com>
3542
3543         * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
3544         * ada-lang.c (ada_enum_name): Likewise.
3545
3546 2019-08-15  Christian Biesinger  <cbiesinger@google.com>
3547
3548         * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
3549         leading underscore.
3550         (GdbOutputErrorFile): Likewise.
3551         (global scope): Adjust constructor calls to GdbOutput{,Error}File
3552         accordingly.
3553         (execute_unwinders): Rename to have a leading underscore.
3554         (auto_load_packages): Likewise.
3555         (global scope): Adjust call to auto_load_packages accordingly.
3556         (GdbSetPythonDirectory): Likewise.
3557         * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
3558         instead of execute_unwinders.
3559
3560 2019-08-15  Tom Tromey  <tom@tromey.com>
3561
3562         * tui/tui-layout.c (show_layout, show_source_disasm_command)
3563         (show_data): Don't change window visibility.
3564         (tui_gen_win_info::resize): Remove special case for command
3565         window.  Use wresize, when available.
3566         (show_source_or_disasm_and_command): Don't change window
3567         visibility.
3568         * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
3569         <make_visible>: New method.
3570         * tui/tui-command.c (tui_cmd_window::resize): New method.
3571
3572 2019-08-15  Tom Tromey  <tom@tromey.com>
3573
3574         * tui/tui-winsource.h (struct tui_source_window_iterator): New.
3575         (struct tui_source_windows): New.
3576         * tui/tui-winsource.c (tui_display_main): Update.
3577         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
3578         (new_height_ok, parse_scrolling_args): Update.
3579         * tui/tui-layout.c (show_layout, show_data): Update.
3580         * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
3581         (tui_add_to_source_windows): Don't declare.
3582         * tui/tui-data.c (source_windows, tui_source_windows)
3583         (tui_clear_source_windows, tui_add_to_source_windows): Remove.
3584
3585 2019-08-15  Tom Tromey  <tom@tromey.com>
3586
3587         * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
3588         Rename from reset.
3589         * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
3590         * tui/tui-layout.c (show_source_disasm_command, show_data):
3591         Update.
3592         (tui_gen_win_info::resize): Rename.
3593         (show_source_or_disasm_and_command): Update.
3594         * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
3595         reset.
3596
3597 2019-08-15  Tom Tromey  <tom@tromey.com>
3598
3599         * tui/tui-stack.c (tui_initialize_static_data): Remove.
3600         * tui/tui-interp.c (tui_interp::init): Don't call
3601         tui_initialize_static_data.
3602         * tui/tui-data.h (tui_initialize_static_data): Don't declare.
3603
3604 2019-08-15  Tom Tromey  <tom@tromey.com>
3605
3606         * tui/tui-layout.c (tui_default_win_viewport_height): Don't
3607         examine tui_win_list.
3608
3609 2019-08-15  Tom Tromey  <tom@tromey.com>
3610
3611         * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
3612         * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
3613         tui_clear_source_content.
3614         (tui_clear_source_content): Remove.
3615         (tui_source_window_base::do_erase_source_content): Hoist call to
3616         content.clear().
3617         * tui/tui-stack.c (tui_show_frame_info): Don't call
3618         tui_clear_source_content.
3619
3620 2019-08-15  Tom Tromey  <tom@tromey.com>
3621
3622         * tui/tui-winsource.h (struct tui_source_window_base)
3623         <do_erase_source_content>: New method.
3624         <erase_source_content>: New method.
3625         (tui_erase_source_content): Don't declare.
3626         * tui/tui-winsource.c (tui_clear_source_content): Update.
3627         (tui_source_window_base::do_erase_source_content): Rename from
3628         tui_erase_source_content.
3629         (tui_source_window_base::show_source_content): Update.
3630         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
3631         * tui/tui-source.h (struct tui_source_window)
3632         <erase_source_content>: New method.
3633         * tui/tui-disasm.h (struct tui_disasm_window)
3634         <erase_source_content>: New method.
3635
3636 2019-08-15  Tom Tromey  <tom@tromey.com>
3637
3638         * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
3639         (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
3640         constructor.
3641         * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
3642         * tui/tui-source.c (tui_set_source_content): Update.
3643         * tui/tui-disasm.c (tui_set_disassem_content): Update.
3644
3645 2019-08-15  Tom Tromey  <tom@tromey.com>
3646
3647         * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
3648         * tui/tui-winsource.c (tui_line_is_displayed): Move to
3649         tui-source.c.
3650         * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
3651         Declare.
3652         * tui/tui-source.c (tui_source_window::line_is_displayed): New
3653         method.
3654         (tui_source_window::maybe_update): Update.
3655
3656 2019-08-15  Tom Tromey  <tom@tromey.com>
3657
3658         * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
3659         * tui/tui-winsource.c (tui_addr_is_displayed): Move to
3660         tui-disasm.c.
3661         * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
3662         Declare.
3663         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
3664         method.
3665         (tui_disasm_window::maybe_update): Update.
3666
3667 2019-08-15  Tom Tromey  <tom@tromey.com>
3668
3669         * tui/tui-winsource.h (struct tui_source_window_base)
3670         <maybe_update>: Declare.
3671         * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
3672         method.
3673         * tui/tui-source.h (struct tui_source_window) <maybe_update>:
3674         Declare.
3675         * tui/tui-source.c (tui_source_window::maybe_update): New method.
3676         * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
3677         Declare.
3678         * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
3679
3680 2019-08-15  Tom Tromey  <tom@tromey.com>
3681
3682         * tui/tui-stack.c (tui_make_status_line): Use string constructor.
3683
3684 2019-08-15  Tom Tromey  <tom@tromey.com>
3685
3686         * tui/tui-wingeneral.c: Include tui-stack.h.
3687         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
3688         (struct tui_locator_window): Move from tui-data.h.
3689         * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
3690         (tui_initialize_static_data): Move from tui-data.c.
3691         * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
3692         (struct tui_locator_window): Move to tui-stack.c.
3693         * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
3694         (tui_initialize_static_data): Move to tui-stack.c.
3695
3696 2019-08-15  Tom Tromey  <tom@tromey.com>
3697
3698         * tui/tui-layout.c (show_source_disasm_command)
3699         (show_source_or_disasm_and_command): Use make_visible method, not
3700         tui_make_window.
3701         * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
3702         Remove.
3703
3704 2019-08-15  Tom Tromey  <tom@tromey.com>
3705
3706         * tui/tui-wingeneral.h (tui_make_window): Update.
3707         * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
3708         parameter.
3709         (tui_gen_win_info::make_visible): Update.
3710         * tui/tui-regs.c (tui_data_window::display_registers_from):
3711         Update.
3712         * tui/tui-layout.c (show_source_disasm_command)
3713         (show_source_or_disasm_and_command): Update.
3714         * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
3715         (enum tui_box): Remove.
3716         (struct tui_win_info) <can_box>: New method.
3717         * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
3718         method.
3719
3720 2019-08-15  Tom de Vries  <tdevries@suse.de>
3721
3722         * linux-nat-trad.c: Include gdbarch.h.
3723
3724 2019-08-14  Alan Hayward  <alan.hayward@arm.com>
3725
3726         * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
3727         register sizes.
3728
3729 2019-08-14  Tom Tromey  <tromey@adacore.com>
3730
3731         * darwin-nat.c: Include gdbarch.h.
3732         * darwin-nat-info.c: Include gdbarch.h.
3733
3734 2019-08-13  Tom Tromey  <tom@tromey.com>
3735
3736         * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
3737         Remove.
3738         * tui/tui-data.c (tui_initialize_static_data): Update.
3739
3740 2019-08-13  Tom Tromey  <tom@tromey.com>
3741
3742         * tui/tui-winsource.h (struct tui_exec_info_window)
3743         <~tui_exec_info_window, maybe_allocate_content, get_content,
3744         m_content>: Remove.
3745         (struct tui_source_window_base) <set_exec_info_content,
3746         show_exec_info_content>: Don't declare.
3747         * tui/tui-winsource.c
3748         (tui_exec_info_window::maybe_allocate_content): Remove.
3749         (tui_source_window_base::update_exec_info): Rename from
3750         set_exec_info_content.
3751         (tui_source_window_base::show_exec_info_content)
3752         (tui_source_window_base::update_exec_info): Remove.
3753
3754 2019-08-13  Tom Tromey  <tom@tromey.com>
3755
3756         * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
3757         declare.
3758         * tui/tui-winsource.c (tui_update_source_window_as_is)
3759         (tui_update_source_windows_with_addr, tui_erase_source_content):
3760         Update.
3761         (tui_clear_exec_info_content): Remove.
3762
3763 2019-08-13  Tom Tromey  <tom@tromey.com>
3764
3765         * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
3766         declare.
3767         * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
3768         call tui_erase_exec_info_content.
3769         (tui_clear_exec_info_content): Rename from
3770         tui_erase_exec_info_content.
3771         (tui_clear_exec_info_content): Delete.
3772
3773 2019-08-13  Tom Tromey  <tom@tromey.com>
3774
3775         * tui/tui-winsource.h (struct tui_source_window_base)
3776         <show_exec_info_content>: Declare.
3777         (tui_show_exec_info_content): Don't declare.
3778         * tui/tui-winsource.c
3779         (tui_source_window_base::show_exec_info_content): Rename from
3780         tui_show_exec_info_content.
3781         (tui_source_window_base::update_exec_info): Update.
3782
3783 2019-08-13  Tom Tromey  <tom@tromey.com>
3784
3785         * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
3786         (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
3787         (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
3788         * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
3789         tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
3790         (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
3791         ... here.
3792
3793 2019-08-13  Tom Tromey  <tom@tromey.com>
3794
3795         * tui/tui-winsource.h (struct tui_source_window_base)
3796         <update_exec_info>: Declare.
3797         (tui_update_exec_info): Don't declare.
3798         * tui/tui-winsource.c (tui_update_source_window_as_is)
3799         (tui_source_window_base::refresh_all)
3800         (tui_update_all_breakpoint_info): Update.
3801         (tui_source_window_base::update_exec_info): Rename from
3802         tui_update_exec_info.
3803         * tui/tui-stack.c (tui_show_frame_info): Update.
3804
3805 2019-08-13  Tom Tromey  <tom@tromey.com>
3806
3807         * tui/tui-winsource.h (struct tui_source_window_base)
3808         <set_exec_info_content>: Declare.
3809         (tui_set_exec_info_content): Don't declare.
3810         * tui/tui-winsource.c
3811         (tui_source_window_base::set_exec_info_content): Rename from
3812         tui_set_exec_info_content.
3813         (tui_update_exec_info): Update.
3814
3815 2019-08-13  Tom Tromey  <tom@tromey.com>
3816
3817         * tui/tui-winsource.h (struct tui_source_window_base)
3818         <show_source_content>: Declare.
3819         (tui_show_source_content): Don't declare.
3820         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
3821         (tui_source_window_base::show_source_content): Rename from
3822         tui_show_source_content.
3823         (tui_source_window_base::refresh_all): Update.
3824         * tui/tui-layout.c (show_source_disasm_command)
3825         (show_source_or_disasm_and_command): Update.
3826
3827 2019-08-13  Tom Tromey  <tom@tromey.com>
3828
3829         * tui/tui-winsource.c (tui_erase_source_content)
3830         (tui_show_source_content, tui_source_window_base::refresh_all):
3831         Update.
3832         * tui/tui-wingeneral.h
3833         (tui_check_and_display_highlight_if_needed): Don't declare.
3834         * tui/tui-wingeneral.c
3835         (tui_win_info::check_and_display_highlight_if_needed): Rename from
3836         check_and_display_highlight_if_needed.
3837         * tui/tui-win.c (tui_rehighlight_all)
3838         (tui_win_info::make_visible_with_new_height): Update.
3839         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
3840         (tui_data_window::erase_data_content)
3841         (tui_data_window::display_all_data): Update.
3842         * tui/tui-data.h (struct tui_win_info)
3843         <check_and_display_highlight_if_needed>: Declare.
3844
3845 2019-08-13  Tom Tromey  <tom@tromey.com>
3846
3847         * tui/tui-win.c (tui_resize_all): Call
3848         tui_delete_invisible_windows.
3849         * tui/tui-layout.c (show_layout): Call
3850         tui_delete_invisible_windows.
3851         * tui/tui-data.h (tui_delete_invisible_windows): Declare.
3852         * tui/tui-data.c (tui_delete_invisible_windows): New function.
3853
3854 2019-08-13  Tom Tromey  <tom@tromey.com>
3855
3856         * tui/tui-disasm.c (tui_show_disassem): Add assertion.  Don't call
3857         tui_add_win_to_layout.
3858
3859 2019-08-13  Tom Tromey  <tom@tromey.com>
3860
3861         * tui/tui-layout.h (tui_default_win_height): Don't declare.
3862         * tui/tui-layout.c (tui_default_win_height): Now static.
3863
3864 2019-08-13  Tom Tromey  <tom@tromey.com>
3865
3866         * tui/tui-layout.c (show_layout): Unify all layout cases into a
3867         single switch.
3868         (show_source_disasm_command, show_source_or_disasm_and_command):
3869         Don't check current layout.
3870
3871 2019-08-13  Tom Tromey  <tom@tromey.com>
3872
3873         * tui/tui-wingeneral.c (make_all_visible): Remove.
3874         (tui_make_all_invisible): Simplify.
3875         * tui/tui-layout.c (tui_make_all_invisible): Move from
3876         tui-wingeneral.c; simplify.
3877         (show_layout): Hoist call to tui_make_all_invisible.
3878         (show_data): Don't call tui_make_all_invisible.
3879
3880 2019-08-13  Tom Tromey  <tom@tromey.com>
3881
3882         * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
3883         * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
3884
3885 2019-08-13  Tom Tromey  <tom@tromey.com>
3886
3887         * tui/tui-layout.c (current_layout, tui_current_layout): Move from
3888         tui-data.c.
3889         (show_source_disasm_command, show_data)
3890         (show_source_or_disasm_and_command): Don't use
3891         tui_set_current_layout_to.
3892         * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
3893         * tui/tui-data.c (current_layout, tui_current_layout): Move to
3894         tui-layout.c.
3895         (tui_set_current_layout_to): Remove.
3896
3897 2019-08-13  Tom Tromey  <tom@tromey.com>
3898
3899         * tui/tui-layout.c (tui_set_layout): Update.
3900         * tui/tui-data.h (struct tui_layout_def): Remove.
3901         (tui_layout_def): Don't declare.
3902         * tui/tui-data.c (layout_def): Remove.
3903         (tui_layout_def): Remove.
3904
3905 2019-08-13  Tom Tromey  <tom@tromey.com>
3906
3907         * tui/tui-winsource.h (struct tui_source_window_base)
3908         <clear_detail>: No longer "override".
3909         * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
3910         * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
3911         * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
3912         * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
3913         Remove.
3914         * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
3915
3916 2019-08-13  Tom Tromey  <tromey@adacore.com>
3917
3918         * tracepoint.c: Don't include readline.h or history.h.
3919
3920 2019-08-12  Tom Tromey  <tom@tromey.com>
3921
3922         * configure: Rebuild.
3923         * configure.ac: Check for readline 7.
3924         * NEWS: Mention readline 7 requirement.
3925         * README: Update.
3926
3927 2019-08-12  Tom Tromey  <tom@tromey.com>
3928
3929         * mingw-hdep.c (gdb_select): Remove readline hack.
3930
3931 2019-08-09  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
3932
3933         * blockframe.c (find_pc_partial_function): Set *block to nullptr
3934         when the function fails.
3935
3936 2019-08-09  Andreas Arnez  <arnez@linux.ibm.com>
3937
3938         * s390-tdep.c (s390_type_align): New function.
3939         (s390_gdbarch_init): Set it as type_align gdbarch method.
3940
3941 2019-08-09  Tom de Vries  <tdevries@suse.de>
3942
3943         PR gdb/24591
3944         * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
3945         pc_low with relocation offset.
3946
3947 2019-08-07  Tom Tromey  <tromey@adacore.com>
3948
3949         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
3950         (print_frame_args): Update.
3951         * python/py-framefilter.c (py_print_single_arg, enumerate_args):
3952         Update.
3953         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
3954         * frame.h (struct frame_arg): Add initializers.
3955         <error>: Now a unique_xmalloc_ptr.
3956
3957 2019-08-07  Alan Hayward  <alan.hayward@arm.com>
3958
3959         * NEWS: Expand the Pointer Authentication entry.
3960         * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
3961         (aarch64_frame_unmask_lr): ... to this.
3962         (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
3963         Call aarch64_frame_unmask_lr.
3964         * frame.c (struct frame_info): Add "masked" variable.
3965         (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
3966         (fprint_frame): Check for masked pc.
3967         * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
3968         declarations.
3969         * python/py-framefilter.c (py_print_frame): Check for masked pc.
3970         * stack.c (print_frame): Check for masked pc.
3971
3972 2019-08-06  Tom Tromey  <tom@tromey.com>
3973
3974         * stabsread.c (patch_block_stabs, read_one_struct_field)
3975         (read_enum_type): Use obstack_strndup.
3976         * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
3977         * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
3978         * dwarf2read.c (guess_full_die_structure_name)
3979         (anonymous_struct_prefix): Use obstack_strndup.
3980         * dbxread.c (cp_set_block_scope): Use obstack_strndup.
3981         * c-exp.y (yylex): Use obstack_strndup.
3982         * ada-exp.y (write_object_renaming, write_ambiguous_var)
3983         (write_var_or_type): Use obstack_strndup.
3984
3985 2019-08-06  Tom Tromey  <tom@tromey.com>
3986
3987         * symfile.c (reread_symbols): Use obstack_strdup.
3988         * stabsread.c (read_type): Use obstack_strdup.
3989         * gdb_obstack.h (obstack_strdup): New overload.
3990         * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
3991         (create_dwo_unit_in_dwp_v2, build_error_marker_type)
3992         (dwarf2_canonicalize_name): Use obstack_strdup.
3993         * dbxread.c (read_dbx_symtab): Use obstack_strdup.
3994         * cp-support.c (inspect_type, replace_typedefs_qualified_name):
3995         Use obstack_strdup.
3996
3997 2019-08-06  Tom Tromey  <tom@tromey.com>
3998
3999         * gdb_obstack.h (obstack_strdup): Define.
4000         * gdb_obstack.c (obstack_strdup): Don't define.
4001
4002 2019-08-06  Tom Tromey  <tom@tromey.com>
4003
4004         * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
4005         obstack_strdup.
4006         * typeprint.c (typedef_hash_table::find_global_typedef): Use
4007         obstack_strdup.
4008         * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
4009         * stabsread.c (common_block_start): Use obstack_strdup.
4010         * objfiles.c (set_objfile_main_name, objfile): Use
4011         obstack_strdup.
4012         * namespace.c (add_using_directive): Use obstack_strdup.
4013         * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
4014         * jit.c (finalize_symtab): Use obstack_strdup.
4015         * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
4016         (guess_partial_die_structure_name, partial_die_info::fixup)
4017         (dwarf2_name): Use obstack_strdup.
4018         * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
4019         obstack_strdup.
4020         * c-exp.y (scan_macro_expansion): Use obstack_strdup.
4021         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
4022         obstack_strdup.
4023         * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
4024
4025 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4026
4027         * unittests/help-doc-selftests.c: New file.
4028         * Makefile.in: Add the new file.
4029
4030 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4031
4032         * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
4033         * cli/cli-decode.c (print_doc_line): Likewise.  It now prints
4034         the full first line, except when FOR_VALUE_PREFIX.  In this case,
4035         the trailing '.' is not output, and the first character is uppercased.
4036         (print_help_for_command): Update call to print_doc_line.
4037         (print_doc_of_command): Likewise.
4038         * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
4039         * cli/cli-option.c (append_indented_doc): Do not append newline.
4040         (build_help_option): Append newline after first appended_indented_doc
4041         only if a second call is done.
4042         (build_help): Append 2 new lines before each option, except the first
4043         one.
4044         * compile/compile.c (_initialize_compile): Add new lines after
4045         %OPTIONS%, when not at the end of the help.
4046         Change help doc or code
4047         producing the help doc to respect the invariants.
4048         * maint-test-options.c (_initialize_maint_test_options): Likewise.
4049         Also removed the new line after 'Options:', as all other commands
4050         do not put an empty line between 'Options:' and the first option.
4051         * printcmd.c (_initialize_printcmd): Likewise.
4052         * stack.c (_initialize_stack): Likewise.
4053         * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
4054         incorrectly telling COMMAND is optional.
4055         * ada-lang.c (_initialize_ada_language): Change help doc or code
4056         producing the help doc to respect the invariants.
4057         * ada-tasks.c (_initialize_ada_tasks): Likewise.
4058         * breakpoint.c (_initialize_breakpoint): Likewise.
4059         * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
4060         * cli/cli-logging.c (_initialize_cli_logging): Likewise.
4061         * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
4062         * cli/cli-style.c (cli_style_option::add_setshow_commands,
4063         _initialize_cli_style): Likewise.
4064         * corelow.c (core_target_info): Likewise.
4065         * dwarf-index-cache.c (_initialize_index_cache): Likewise.
4066         * dwarf2read.c (_initialize_dwarf2_read): Likewise.
4067         * filesystem.c (_initialize_filesystem): Likewise.
4068         * frame.c (_initialize_frame): Likewise.
4069         * gnu-nat.c (add_task_commands): Likewise.
4070         * infcall.c (_initialize_infcall): Likewise.
4071         * infcmd.c (_initialize_infcmd): Likewise.
4072         * interps.c (_initialize_interpreter): Likewise.
4073         * language.c (_initialize_language): Likewise.
4074         * linux-fork.c (_initialize_linux_fork): Likewise.
4075         * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
4076         * maint.c (_initialize_maint_cmds): Likewise.
4077         * memattr.c (_initialize_mem): Likewise.
4078         * printcmd.c (_initialize_printcmd): Likewise.
4079         * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
4080         _RegEx): Likewise.
4081         * ravenscar-thread.c (_initialize_ravenscar): Likewise.
4082         * record-btrace.c (_initialize_record_btrace): Likewise.
4083         * record-full.c (_initialize_record_full): Likewise.
4084         * record.c (_initialize_record): Likewise.
4085         * regcache-dump.c (_initialize_regcache_dump): Likewise.
4086         * regcache.c (_initialize_regcache): Likewise.
4087         * remote.c (add_packet_config_cmd, init_remote_threadtests,
4088         _initialize_remote): Likewise.
4089         * ser-tcp.c (_initialize_ser_tcp): Likewise.
4090         * serial.c (_initialize_serial): Likewise.
4091         * skip.c (_initialize_step_skip): Likewise.
4092         * source.c (_initialize_source): Likewise.
4093         * stack.c (_initialize_stack): Likewise.
4094         * symfile.c (_initialize_symfile): Likewise.
4095         * symtab.c (_initialize_symtab): Likewise.
4096         * target-descriptions.c (_initialize_target_descriptions): Likewise.
4097         * top.c (init_main): Likewise.
4098         * tracefile-tfile.c (tfile_target_info): Likewise.
4099         * tracepoint.c (_initialize_tracepoint): Likewise.
4100         * tui/tui-win.c (_initialize_tui_win): Likewise.
4101         * utils.c (add_internal_problem_command): Likewise.
4102         * valprint.c (value_print_option_defs): Likewise.
4103
4104 2019-08-06  Frank Ch. Eigler  <fche@redhat.com>
4105
4106         PR build/24886
4107         * configure.ac: Drop enable-libmcheck support.
4108         * configure, config.in: Rebuild.
4109         * libmcheck.m4: Remove.
4110         * acinclude.m4: Don't include it.
4111         * Makefile.in: Don't distribute it.
4112         * top.c (print_gdb_configuration): Don't mention it.
4113
4114 2019-08-06  Tom Tromey  <tom@tromey.com>
4115
4116         * utils.c (set_output_style): Sometimes pass stream to
4117         emit_style_escape.
4118         * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
4119         * record-btrace.c (btrace_insn_history): Update.
4120         * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
4121         method.
4122         * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
4123         Update initializers.
4124         <m_uiout>: New field.
4125         <m_di>: Move lower.
4126         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
4127         Remove "uiout" parameter.
4128         (dump_insns): Update.
4129         * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
4130         * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
4131
4132 2019-08-06  Christian Biesinger  <cbiesinger@google.com>
4133
4134         * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
4135         (error_in_psymtab_expansion): Likewise.
4136         (lookup_symbol_via_quick_fns): Likewise.
4137         (basic_lookup_transparent_type_quick): Likewise.
4138         (basic_lookup_transparent_type_1): Likewise.
4139
4140 2019-08-06  Tom Tromey  <tromey@adacore.com>
4141
4142         * source.c (last_source_error): Now bool.
4143         (print_source_lines_base): Make "noprint" bool.  Only open
4144         source file when last_source_visited changes.
4145
4146 2019-08-06  Tom Tromey  <tromey@adacore.com>
4147
4148         * annotate.c (annotate_source_line): Use g_source_cache.
4149         * source-cache.c (source_cache::get_plain_source_lines): Change
4150         parameters.  Populate m_offset_cache.
4151         (source_cache::ensure): New method.
4152         (source_cache::get_line_charpos): New method.
4153         (extract_lines): Move lower.  Change parameters.
4154         (source_cache::get_source_lines): Move lower.
4155         * source-cache.h (class source_cache): Update comment.
4156         <get_line_charpos>: New method.
4157         <get_source_lines>: Update comment.
4158         <clear>: Clear m_offset_cache.
4159         <get_plain_source_lines>: Change parameters.
4160         <ensure>: New method
4161         <m_offset_cache>: New member.
4162         * source.c (forget_cached_source_info_for_objfile): Update.
4163         (info_source_command): Use g_source_cache.
4164         (find_source_lines, open_source_file_with_line_charpos): Remove.
4165         (print_source_lines_base, search_command_helper): Use g_source_cache.
4166         * source.h (open_source_file_with_line_charpos): Don't declare.
4167         * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
4168         * tui/tui-source.c (tui_source_window::do_scroll_vertical):
4169         Use g_source_cache.
4170
4171 2019-08-06  Tom Tromey  <tromey@adacore.com>
4172
4173         * source-cache.c (source_cache::get_plain_source_lines):
4174         Remove "first_line" and "last_line" parameters.
4175         (source_cache::get_source_lines): Cache plain text.
4176         * source-cache.h (class source_cache)
4177         <get_plain_source_lines>: Update.
4178
4179 2019-08-06  Tom Tromey  <tromey@adacore.com>
4180
4181         * source-cache.c (extract_lines): No longer a method.
4182         Changed type of parameter.  Include final newline.
4183         (selftests::extract_lines_test): New function.
4184         (_initialize_source_cache): Likewise.
4185         * source-cache.h (class source_cache)
4186         <extract_lines>: Don't declare.
4187
4188 2019-08-06  Tom Tromey  <tromey@adacore.com>
4189
4190         * breakpoint.c (init_breakpoint_sal): Update.
4191         (breakpoint): Update.
4192         * breakpoint.h (struct breakpoint) <filter>: Now a
4193         unique_xmalloc_ptr.
4194
4195 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
4196
4197         * NEWS: Mention dictionary access on blocks.
4198         * python/py-block.c (blpy_getitem): New function.
4199         (block_object_as_mapping): New struct.
4200         (block_object_type): Use new struct for tp_as_mapping field.
4201
4202 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
4203
4204         * objfiles.h (objfile): Add a comment describing partial symbols.
4205
4206 2019-08-05  Tom Tromey  <tromey@adacore.com>
4207
4208         * compile/compile.c (_initialize_compile): Use _(), not N_().
4209         * thread.c (_initialize_thread): Use _(), not N_().
4210         * stack.c (_initialize_stack): Use _(), not N_().
4211         * printcmd.c (_initialize_printcmd): Use _(), not N_().
4212
4213 2019-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
4214
4215         * dwarf2read.c (struct dw2_symtab_iterator):
4216         <want_specific_block>: Remove.
4217         <block_index>: Change type to gdb::optional.
4218         (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
4219         change type of BLOCK_INDEX parameter to gdb::optional.
4220         (dw2_symtab_iter_next): Re-write in function of gdb::optional.
4221         (dw2_lookup_symbol): Don't pass argument for
4222         WANT_SPECIFIC_BLOCK.
4223         (dw2_expand_symtabs_for_function): Don't pass argument for
4224         WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
4225         (class dw2_debug_names_iterator)
4226         <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
4227         parameter, change BLOCK_INDEX type to gdb::optional.
4228         <m_want_specific_block>: Remove.
4229         <m_block_index>: Change type to gdb::optional.
4230         (dw2_debug_names_iterator::next): Change type of IS_STATIC to
4231         gdb::optional.  Re-write in function of gdb::optional.
4232         (dw2_debug_names_lookup_symbol): Don't pass argument for
4233         WANT_SPECIFIC_BLOCK.
4234         (dw2_debug_names_expand_symtabs_for_function): Don't pass
4235         argument for WANT_SPECIFIC_BLOCK, pass empty optional for
4236         BLOCK_INDEX.
4237
4238 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4239
4240         * NEWS: Mention changes to "info sources" command.
4241
4242 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4243
4244         * symtab.c (filename_partial_match_opts): New struct type.
4245         (struct output_source_filename_data): New members
4246         regexp, c_regexp, partial_match.
4247         (output_source_filename): Use new members to decide to print file.
4248         (info_sources_option_defs): New variable.
4249         (make_info_sources_options_def_group, print_info_sources_header,
4250         info_sources_command_completer):
4251         New functions.
4252         (info_sources_command): Read new optional arguments.
4253         (_initialize_symtab): Update info sources help.
4254
4255 2019-08-02  Alexandre Oliva <oliva@adacore.com>
4256
4257         * ada-lang.c (exception_support_info_v0): Renamed from...
4258         (default_exception_support_info): ... this.  Create new
4259         definition for v1.
4260         (ada_has_this_exception_support): Look up catch_handlers_sym.
4261         (ada_exception_support_info_sniffer): Try v0 after default.
4262
4263 2019-08-01  Tom Tromey  <tromey@adacore.com>
4264
4265         * ia64-libunwind-tdep.h (struct libunwind_descr): Include
4266         gdbarch.h.
4267
4268 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
4269
4270         * s12z-tdep.c: Fix include path for s12z-opc.h.
4271
4272 2019-08-01  Alan Hayward  <alan.hayward@arm.com>
4273
4274         * NEWS: Require GNU make 3.82.
4275
4276 2019-07-16  Tom Tromey  <tom@tromey.com>
4277
4278         * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
4279         declare.
4280
4281 2019-07-30  Tom Tromey  <tromey@adacore.com>
4282
4283         * block.c (contained_in): Remove BLOCK_FUNCTION check.
4284
4285 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
4286
4287         * printcmd.c (print_address_symbolic): Print negative offsets.
4288         (build_address_symbolic): Force signed arithmetic when computing
4289         offset.
4290
4291 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
4292
4293         PR/24474: Add a function to lookup static variables.
4294         * NEWS: Mention this new function.
4295         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
4296         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
4297         * python/python.c (python_GdbMethods): Add new function.
4298
4299 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
4300
4301         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
4302         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
4303         (objfpy_lookup_static_symbol): New function.
4304         (objfile_object_methods): Add new functions.
4305
4306 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4307
4308         * NEWS: Mention 'set|show print frame-info'.  Mention new
4309         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
4310         backtrace argument.  Mention that python frame filtering code
4311         is now consistent with what 'backtrace' command prints.
4312
4313 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4314
4315         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
4316         comments.
4317         (print_frame_info_auto, print_frame_info_source_line,
4318         print_frame_info_location, print_frame_info_source_and_location,
4319         print_frame_info_location_and_address, print_frame_info_short_location):
4320         New declarations.
4321         (struct frame_print_options): New member print_frame_info.
4322         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
4323         * stack.h (get_user_print_what_frame_info): New declaration.
4324         (frame_show_address): New declaration.
4325         * stack.c (print_frame_arguments_choices): New value 'presence'.
4326         (print_frame_info_auto, print_frame_info_source_line,
4327         print_frame_info_location, print_frame_info_source_and_location,
4328         print_frame_info_location_and_address, print_frame_info_short_location,
4329         print_frame_info_choices, print_frame_info_print_what): New definitions.
4330         (print_frame_args): Only print dots for args if print frame-arguments
4331         is 'presence'.
4332         (frame_print_option_defs): New element for "frame-info".
4333         (get_user_print_what_frame_info): New function.
4334         (frame_show_address): Make non static.  Move comment to stack.h.
4335         (print_frame_info_to_print_what): New function.
4336         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
4337         to decide what to print.
4338         (backtrace_command_1): Handle the new print_frame_arguments_presence
4339         value.
4340         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
4341         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
4342         (py_print_frame): In non-mi mode, use LOCATION as default for
4343         print_what, similarly to frame information printed directly by
4344         backtrace command. Handle frame-info user option in non MI mode.
4345
4346 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
4347
4348         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
4349         Add case for debugging 32-bit target on 64-bit host.  Revise
4350         comment.
4351
4352 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
4353
4354         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
4355         instead of find_function_entry_range_from_pc.
4356
4357 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
4358
4359         * stack.c (find_frame_funname): Remove code which preferred
4360         minsym over symtab sym in "certain pathological cases".
4361
4362         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
4363         parameter.  Change type of "do_demangle" to bool.
4364         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
4365         Pass suitable "prefer_sym_over_minsym" flag to
4366         build_address_symbolic().  Don't output "+" for negative offsets.
4367         * printcmd.c (print_address_symbolic): Update invocation of
4368         build_address_symbolic to include a "prefer_sym_over_minsym"
4369         flag.
4370         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
4371         Restrict cases in which use of minimal symbol is preferred to that
4372         of a found symbol.  Update comments.
4373
4374         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
4375         for entry pc when entry pc is out of range for that FDE.
4376
4377 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
4378
4379         PR gdb/24839:
4380         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
4381         type.
4382
4383 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
4384
4385         * python/py-objfile.c (add_separate_debug_file): Fix comment about
4386         this function's Python signature.
4387
4388
4389 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
4390
4391         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
4392         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
4393         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
4394         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
4395         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
4396
4397
4398 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
4399
4400         * h8300-tdep.c (h8300_register_name_common): New.
4401         h8300_register_name): Use h8300_register_name_common.
4402         (h8300s_register_name): Likewise.
4403         (h8300sx_register_name): Likewise.
4404         (h8300h_register_nam): New.
4405         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
4406
4407
4408 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
4409
4410         * arm-tdep.c (arm_skip_cmse_entry): New function.
4411         (arm_is_sgstubs_section): New function.
4412         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
4413
4414 2019-07-22  Tom Tromey  <tom@tromey.com>
4415
4416         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
4417         Don't self-assign.
4418
4419 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
4420
4421         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
4422         type_print.
4423
4424 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
4425
4426         * symtab.c (search_symbols): Adjust msymbol matching type arrays
4427         so that GDB doesn't match any msymbols when searching in the
4428         TYPES_DOMAIN.
4429         (print_symbol_info): Print using typedef_print or type_print based
4430         on the type of the symbol.  Add updated FIXME comment moved from...
4431         (_initialize_symtab): ... move and update FIXME comment to above.
4432
4433 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
4434
4435         * NEWS: Mention adding -q option to "info types".
4436         * symtab.c (struct info_types_options): New struct.
4437         (info_types_options_defs): New variable.
4438         (make_info_types_options_def_group): New function.
4439         (info_types_command): Use gdb::option framework to parse options.
4440         (info_types_command_completer): New function.
4441         (_initialize_symtab): Extend the help text on "info types" and
4442         register command completer.
4443
4444 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
4445
4446         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
4447         (lookup_symbol_in_objfile): Change int to block_enum and add a
4448         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
4449
4450 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
4451
4452         * MAINTAINERS (Write After Approval): Add self.
4453
4454 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
4455
4456         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
4457         instruction to the dummy code region.
4458
4459 2019-07-19  Tom Tromey  <tromey@adacore.com>
4460
4461         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
4462         (ARGSUSED, PARAMS, __func__): Remove rules.
4463
4464 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
4465
4466         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
4467         * features/arm/arm-with-iwmmxt.c: Remove.
4468         * features/arm/arm-with-iwmmxt.xml: Remove.
4469         * features/arm/arm-with-m-fpa-layout.c: Remove.
4470         * features/arm/arm-with-m-fpa-layout.xml: Remove.
4471         * features/arm/arm-with-m-vfp-d16.c: Remove.
4472         * features/arm/arm-with-m-vfp-d16.xml: Remove.
4473         * features/arm/arm-with-m.c: Remove.
4474         * features/arm/arm-with-m.xml: Remove.
4475         * features/arm/arm-with-neon.c: Remove.
4476         * features/arm/arm-with-neon.xml: Remove.
4477         * features/arm/arm-with-vfpv2.c: Remove.
4478         * features/arm/arm-with-vfpv2.xml: Remove.
4479         * features/arm/arm-with-vfpv3.c: Remove.
4480         * features/arm/arm-with-vfpv3.xml: Remove.
4481
4482 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
4483
4484         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
4485
4486 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
4487
4488         * arch/aarch32.c (aarch32_create_target_description): Create
4489         target descriptions using features.
4490         * arch/arm.c (arm_create_target_description)
4491         (arm_create_mprofile_target_description): Likewise.
4492         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
4493
4494 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
4495
4496         * Makefile.in: Add new files.
4497         * aarch32-tdep.c: New file.
4498         * aarch32-tdep.h: New file.
4499         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
4500         Call aarch32_read_description.
4501         * arch/aarch32.c: New file.
4502         * arch/aarch32.h: New file.
4503         * arch/arm.c (arm_create_target_description)
4504         (arm_create_mprofile_target_description): New function.
4505         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
4506         (arm_create_target_description)
4507         (arm_create_mprofile_target_description): New declaration.
4508         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
4509         read_description functions.
4510         * arm-linux-nat.c (arm_linux_nat_target::read_description):
4511         Likewise.
4512         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
4513         * arm-tdep.c (tdesc_arm_list): New variable.
4514         (arm_register_g_packet_guesses): Call create description functions.
4515         (arm_read_description) (arm_read_mprofile_description): New
4516         function.
4517         * arm-tdep.h (arm_read_description)
4518         (arm_read_mprofile_description): Add declaration.
4519         * configure.tgt: Add new files.
4520
4521 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
4522
4523         * top.c (new_ui_command): Open specified terminal just once.
4524
4525 2019-07-18  Tom Tromey  <tromey@adacore.com>
4526
4527         * symtab.c (main_name): Constify return type.
4528         * symfile.c (set_initial_language): Update.
4529         * symtab.h (main_name): Constify return type.
4530
4531 2019-07-17  Tom Tromey  <tom@tromey.com>
4532
4533         * tui/tui-winsource.c (tui_update_source_window)
4534         (tui_update_source_window_as_is)
4535         (tui_update_source_windows_with_line): Remove return.
4536         * tui/tui-disasm.c (tui_show_disassem)
4537         (tui_show_disassem_and_update_source): Remove return.
4538         * tui/tui.c (tui_reset): Remove return.
4539         * tui/tui-wingeneral.c
4540         (tui_check_and_display_highlight_if_needed): Remove return.
4541
4542 2019-07-17  Tom Tromey  <tom@tromey.com>
4543
4544         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
4545
4546 2019-07-17  Tom Tromey  <tom@tromey.com>
4547
4548         * tui/tui-winsource.h (struct tui_exec_info_window)
4549         (struct tui_source_window_base): Move from tui-data.h.
4550         * tui/tui-winsource.c: Move many method definitions from
4551         elsewhere.  Remove "structuring" comments.
4552         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
4553         (tui_source_window_base::refresh_window): Move to
4554         tui-winsource.c.
4555         * tui/tui-win.c (tui_source_window_base::refresh_all)
4556         (tui_source_window_base::update_tab_width)
4557         (tui_source_window_base::set_new_height)
4558         (tui_source_window_base::do_make_visible_with_new_height): Move to
4559         tui-winsource.c.
4560         * tui/tui-source.h: Update.
4561         * tui/tui-source.c (tui_source_window_base::reset): Move to
4562         tui-winsource.c.
4563         * tui/tui-disasm.h: Update.
4564         * tui/tui-data.h (struct tui_exec_info_window): Move to
4565         tui-winsource.h.
4566         (struct tui_source_window_base): Likewise.
4567         * tui/tui-data.c (tui_source_window_base::clear_detail)
4568         (tui_source_window_base, ~tui_source_window_base): Move to
4569         tui-winsource.c.
4570
4571 2019-07-17  Tom Tromey  <tom@tromey.com>
4572
4573         * tui/tui-win.c (tui_resize_all)
4574         (tui_source_window_base::update_tab_width)
4575         (tui_adjust_win_heights): Update.
4576         (tui_win_info::make_invisible_and_set_new_height): Rename from
4577         make_invisible_and_set_new_height.
4578         * tui/tui-data.h (struct tui_win_info)
4579         <make_invisible_and_set_new_height>: New method.
4580
4581 2019-07-17  Tom Tromey  <tom@tromey.com>
4582
4583         * tui/tui.c: Update.
4584         * tui/tui-source.h (struct tui_source_window): Move from
4585         tui-data.h.
4586         * tui/tui-layout.c: Update.
4587         * tui/tui-disasm.c: Update.
4588         * tui/tui-data.h (struct tui_source_window): Move to
4589         tui-source.h.
4590
4591 2019-07-17  Tom Tromey  <tom@tromey.com>
4592
4593         * tui/tui-disasm.h (struct tui_disasm_window): Move from
4594         tui-data.h.
4595         * tui/tui-data.h (struct tui_disasm_window): Move to
4596         tui-disasm.h.
4597
4598 2019-07-17  Tom Tromey  <tom@tromey.com>
4599
4600         * tui/tui-regs.h (struct tui_data_item_window): Move from
4601         tui-data.h.
4602         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
4603         * tui/tui-data.h (struct tui_data_item_window): Move to
4604         tui-regs.h.
4605         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
4606
4607 2019-07-17  Tom Tromey  <tom@tromey.com>
4608
4609         * tui/tui.c: Update.
4610         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
4611         (tui_cmd_window::max_height): Move to tui-command.c.
4612         * tui/tui-layout.c: Update.
4613         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
4614         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
4615         tui-command.c.
4616         * tui/tui-command.h (struct tui_cmd_window): Move from
4617         tui-data.h.
4618         * tui/tui-command.c: Remove "structuring" comments.
4619         (tui_cmd_window::clear_detail)
4620         (tui_cmd_window::do_make_visible_with_new_height)
4621         (tui_cmd_window::max_height): Move from elsewhere.
4622
4623 2019-07-17  Tom Tromey  <tom@tromey.com>
4624
4625         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
4626         Now static.
4627         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
4628         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
4629
4630 2019-07-17  Tom Tromey  <tom@tromey.com>
4631
4632         * tui/tui.c: Update.
4633         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
4634         tui-regs.c.
4635         * tui/tui-windata.h: Remove file.
4636         * tui/tui-windata.c: Remove file.
4637         * tui/tui-win.c (tui_data_window::set_new_height)
4638         (tui_data_window::do_make_visible_with_new_height): Move to
4639         tui-regs.c.
4640         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
4641         * tui/tui-regs.c: Remove "structuring" comments.
4642         (tui_data_window::first_data_item_displayed)
4643         (tui_data_window::delete_data_content_windows)
4644         (tui_data_window::erase_data_content)
4645         (tui_data_window::display_all_data)
4646         (tui_data_window::refresh_all)
4647         (tui_data_window::do_scroll_vertical)
4648         (tui_data_window::clear_detail, tui_data_window::set_new_height)
4649         (tui_data_window::do_make_visible_with_new_height)
4650         (tui_data_window::refresh_window): Move from elsewhere.
4651         (_initialize_tui_regs): Move to end of file.
4652         * tui/tui-layout.c: Update.
4653         * tui/tui-hooks.c: Update.
4654         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
4655         * tui/tui-data.c (tui_data_window::clear_detail): Move to
4656         tui-regs.c.
4657         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
4658
4659 2019-07-17  Tom Tromey  <tom@tromey.com>
4660
4661         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
4662         seen.
4663
4664 2019-07-17  Tom Tromey  <tom@tromey.com>
4665
4666         * tui/tui-win.c (tui_source_window_base::set_new_height)
4667         (tui_source_window_base::do_make_visible_with_new_height): Use
4668         m_has_locator field directly.
4669         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
4670         method.
4671         (struct tui_source_window_base) <has_locator>: Likewise.
4672
4673 2019-07-17  Tom Tromey  <tom@tromey.com>
4674
4675         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
4676         Don't declare.
4677         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
4678         Remove.
4679         * tui/tui-win.c (tui_source_window_base::set_new_height)
4680         (tui_source_window_base::set_new_height)
4681         (make_invisible_and_set_new_height)
4682         (tui_source_window_base::do_make_visible_with_new_height)
4683         (tui_source_window_base::do_make_visible_with_new_height):
4684         Update.
4685         * tui/tui-layout.c (show_source_disasm_command, show_data)
4686         (show_source_or_disasm_and_command): Update.
4687         * tui/tui-layout.c (show_layout): Update.
4688
4689 2019-07-17  Tom Tromey  <tom@tromey.com>
4690
4691         * tui/tui-layout.c (make_data_window): Remove.
4692         (show_data): Unify creation and re-initialization cases.
4693
4694 2019-07-17  Tom Tromey  <tom@tromey.com>
4695
4696         * tui/tui-layout.c (make_source_window, make_disasm_window):
4697         Remove.
4698         (show_data): Unify creation and re-initialization cases.
4699
4700 2019-07-17  Tom Tromey  <tom@tromey.com>
4701
4702         * tui/tui-layout.c (make_command_window): Remove.
4703         (show_source_disasm_command, show_source_or_disasm_and_command):
4704         Unify creation and re-initialization cases.
4705
4706 2019-07-17  Tom Tromey  <tom@tromey.com>
4707
4708         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
4709         creation and re-initialization cases.
4710
4711 2019-07-17  Tom Tromey  <tom@tromey.com>
4712
4713         * tui/tui-regs.c (tui_get_register): Return void.
4714
4715 2019-07-17  Tom Tromey  <tom@tromey.com>
4716
4717         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
4718         Simplify.
4719
4720 2019-07-17  Tom Tromey  <tom@tromey.com>
4721
4722         * tui/tui-layout.c (show_source_disasm_command): Simplify window
4723         resetting.
4724
4725 2019-07-17  Tom Tromey  <tom@tromey.com>
4726
4727         * tui/tui.h (tui_set_layout_by_name): Don't declare.
4728         * tui/tui-regs.c (tui_reg_layout): New function.
4729         (tui_show_registers, tui_reg_command): Use it.
4730         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
4731         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
4732         parameters.
4733         (tui_layout_command): Remove.
4734
4735 2019-07-17  Tom Tromey  <tom@tromey.com>
4736
4737         * tui/tui-layout.h (tui/tui-layout): Return void.
4738         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
4739
4740 2019-07-17  Tom Tromey  <tom@tromey.com>
4741
4742         * tui/tui-layout.c (show_source_disasm_command, show_data):
4743         Update.
4744         (reset_locator): Remove.
4745         (show_source_or_disasm_and_command): Update.
4746
4747 2019-07-17  Tom Tromey  <tom@tromey.com>
4748
4749         * tui/tui-source.c (tui_source_window_base::reset): Remove
4750         win_type parameter.
4751         * tui/tui-layout.c (make_command_window, make_source_window)
4752         (make_disasm_window, make_data_window)
4753         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
4754         (reset_locator, show_source_or_disasm_and_command): Update.
4755         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
4756         win_type parameter.
4757         (struct tui_source_window_base) <reset>: Likewise.
4758
4759 2019-07-17  Tom Tromey  <tom@tromey.com>
4760
4761         * tui/tui-layout.c (show_source_disasm_command): Use
4762         reset_locator.
4763         (reset_locator): New function.
4764         (init_and_make_win): Remove.
4765         (show_source_or_disasm_and_command): Use reset_locator.
4766
4767 2019-07-17  Tom Tromey  <tom@tromey.com>
4768
4769         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
4770         condition.
4771         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
4772         Remove condition.
4773         * tui/tui-source.c (tui_source_window_base::reset): New method.
4774         * tui/tui-layout.c (make_command_window): Don't call
4775         init_and_make_win.
4776         (make_source_window, make_disasm_window): Don't call
4777         make_source_or_disasm_window.
4778         (make_data_window): Don't call init_and_make_win.  Change calling
4779         convention.
4780         (show_source_disasm_command, show_data): Simplify.
4781         (make_source_or_disasm_window): Remove.
4782         (show_source_or_disasm_and_command): Simplify.
4783         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
4784         (struct tui_source_window_base) <reset>: Likewise.
4785         <execution_info>: Remove initializer.
4786         * tui/tui-data.c (tui_source_window_base): Initialize
4787         execution_info.
4788
4789 2019-07-17  Tom Tromey  <tom@tromey.com>
4790
4791         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
4792         variable.
4793
4794 2019-07-17  Tom Tromey  <tom@tromey.com>
4795
4796         * tui/tui.c (tui_rl_other_window): Update.
4797         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
4798         superclass method first.  Always iterate over regs_content.
4799         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
4800         method.
4801         * tui/tui-win.c (tui_set_focus_command): Update.
4802
4803 2019-07-17  Tom Tromey  <tom@tromey.com>
4804
4805         * tui/tui-win.c (tui_set_focus_command): Rename from
4806         tui_set_focus.  Call tui_enable.
4807         (tui_set_focus_command): Remove.
4808
4809 2019-07-17  Tom Tromey  <tom@tromey.com>
4810
4811         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
4812         refresh_window.
4813         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
4814         touchwin.
4815         (tui_data_window::refresh_window): Call refresh_window on data
4816         items.  Always call superclass refresh_window.
4817         (tui_win_info::refresh): Remove.
4818         (tui_source_window_base::refresh_window): Update.
4819         (tui_refresh_all): Update.
4820         * tui/tui-layout.c (show_source_disasm_command): Remove call to
4821         refresh_window.
4822         (show_source_or_disasm_and_command): Likewise.
4823         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
4824         (struct tui_source_window_base) <refresh>: Likewise.
4825
4826 2019-07-17  Tom Tromey  <tom@tromey.com>
4827
4828         * tui/tui-winsource.c (tui_clear_source_content)
4829         (tui_show_source_content): Update.
4830         * tui/tui-source.c (tui_source_window::showing_source_p): Check
4831         whether content is empty.
4832         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
4833         Remove.
4834
4835 2019-07-17  Tom Tromey  <tom@tromey.com>
4836
4837         * tui/tui-winsource.c (tui_erase_source_content): Clear the
4838         window's contents.
4839         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
4840         * tui/tui-source.c (tui_set_source_content_nil): Remove.
4841
4842 2019-07-17  Tom Tromey  <tom@tromey.com>
4843
4844         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
4845         (struct tui_data_item_window): Update.
4846
4847 2019-07-17  Tom Tromey  <tom@tromey.com>
4848
4849         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
4850         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
4851         defines.
4852
4853 2019-07-17  Tom Tromey  <tom@tromey.com>
4854
4855         * tui/tui-winsource.h (tui_erase_source_content)
4856         (tui_clear_source_content): Remove "display_prompt" parameter.
4857         * tui/tui-winsource.c (tui_update_source_window_as_is)
4858         (tui_update_source_windows_with_addr): Update.
4859         (tui_clear_source_content): Remove "display_prompt" parameter.
4860         (tui_erase_source_content): Likewise.  Simplify.
4861         (tui_show_source_content): Update.
4862         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
4863         * tui/tui-stack.c (tui_show_frame_info): Update.
4864         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
4865         Remove defines.
4866
4867 2019-07-17  Tom Tromey  <tom@tromey.com>
4868
4869         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
4870         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
4871         parameter.
4872         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
4873         parameter.
4874
4875 2019-07-17  Tom Tromey  <tom@tromey.com>
4876
4877         * tui/tui-winsource.c (tui_clear_source_content)
4878         (tui_show_source_content, tui_show_exec_info_content)
4879         (tui_clear_exec_info_content): Update.
4880         * tui/tui-stack.c (tui_show_locator_content): Update.
4881         (tui_show_frame_info): Update.
4882         * tui/tui-source.h (tui_source_window): Don't declare.
4883         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
4884         from tui_source_is_displayed.
4885         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
4886         Remove field.
4887         (struct tui_source_window_base) <content_in_use>: New field.  Now
4888         bool.
4889         (struct tui_source_window) <showing_source_p>: New method.
4890         (TUI_SRC_WIN): Change cast.
4891         * tui/tui-data.c (tui_initialize_static_data): Update.
4892
4893 2019-07-17  Tom Tromey  <tom@tromey.com>
4894
4895         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
4896         location_matches_p.
4897         * tui/tui-source.c (tui_source_window::location_matches_p): New
4898         method.
4899         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
4900         method.
4901         * tui/tui-data.h (struct tui_source_window_base)
4902         <location_matches_p>: New method.
4903         (struct tui_source_window, struct tui_disasm_window)
4904         <location_matches_p>: Likewise.
4905
4906 2019-07-17  Tom Tromey  <tom@tromey.com>
4907
4908         * tui/tui-win.c (tui_set_win_height_command): Rename from
4909         tui_set_win_height.
4910         (tui_set_win_height_command): Remove.
4911
4912 2019-07-17  Tom Tromey  <tom@tromey.com>
4913
4914         * tui/tui-source.c (tui_source_window): New constructor.  Add
4915         observer.
4916         (~tui_source_window): New destructor.
4917         (tui_source_window::style_changed): New method.
4918         * tui/tui-hooks.c (tui_redisplay_source): Remove.
4919         (tui_attach_detach_observers): Update.
4920         * tui/tui-data.h (struct tui_source_window): Make constructor not
4921         inline.  Add destructor.
4922         (struct tui_source_window) <style_changed>: New method.
4923         <m_observable>: New member.
4924
4925 2019-07-17  Tom Tromey  <tom@tromey.com>
4926
4927         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
4928         * tui/tui-win.c (tui_resize_all): Fix typo.
4929
4930 2019-07-17  Tom Tromey  <tom@tromey.com>
4931
4932         * tui/tui-wingeneral.h (tui_refresh_all): Update.
4933         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
4934         (tui_refresh_all): Remove "list" parameter.  Use foreach.
4935         * tui/tui-win.c (window_name_completer): Use foreach.
4936         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
4937         (update_tab_width): Likewise.
4938         * tui/tui-layout.c (show_layout): Update.
4939         * tui/tui-data.h (class tui_window_iterator): New.
4940         (struct all_tui_windows): New.
4941         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
4942
4943 2019-07-17  Tom Tromey  <tom@tromey.com>
4944
4945         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
4946         parameter.  Don't reference globals.
4947         (tui_reg_command): Update.
4948
4949 2019-07-17  Tom Tromey  <tom@tromey.com>
4950
4951         * tui/tui-regs.c (tui_show_registers): Simplify.
4952
4953 2019-07-17  Tom Tromey  <tom@tromey.com>
4954
4955         * tui/tui-regs.c (tui_show_registers): Update.
4956         (tui_show_register_group): Add win_info parameter.
4957
4958 2019-07-17  Tom Tromey  <tom@tromey.com>
4959
4960         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
4961         Rename from tui_display_reg_element_at_line.
4962         (tui_data_window::display_registers_from_line): Update.
4963         * tui/tui-data.h (struct tui_data_window)
4964         <display_reg_element_at_line>: New method.
4965
4966 2019-07-17  Tom Tromey  <tom@tromey.com>
4967
4968         * tui/tui-regs.h (tui_display_registers_from)
4969         (tui_display_registers_from_line): Don't declare.
4970         * tui/tui-windata.c (tui_data_window::display_all_data)
4971         (tui_data_window::refresh_all)
4972         (tui_data_window::do_scroll_vertical): Update.
4973         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
4974         from tui_display_registers_from.
4975         (tui_display_reg_element_at_line): Update.
4976         (tui_data_window::display_registers_from_line): Rename from
4977         tui_display_registers_from_line.
4978         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
4979         display_registers_from_line>: New methods.
4980
4981 2019-07-17  Tom Tromey  <tom@tromey.com>
4982
4983         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
4984         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
4985         from tui_erase_data_content.
4986         (tui_data_window::display_all_data)
4987         (tui_data_window::refresh_all)
4988         (tui_data_window::do_scroll_vertical): Update.
4989         * tui/tui-regs.c (tui_show_registers): Update.
4990         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
4991         New method.
4992
4993 2019-07-17  Tom Tromey  <tom@tromey.com>
4994
4995         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
4996         declare.
4997         * tui/tui-windata.c
4998         (tui_data_window::delete_data_content_windows): Rename from
4999         tui_delete_data_content_windows.
5000         (tui_data_window::display_all_data)
5001         (tui_data_window::do_scroll_vertical): Update.
5002         * tui/tui-data.h (struct tui_data_window)
5003         <delete_data_content_windows>: New method.
5004
5005 2019-07-17  Tom Tromey  <tom@tromey.com>
5006
5007         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
5008         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
5009
5010 2019-07-17  Tom Tromey  <tom@tromey.com>
5011
5012         * tui/tui-windata.h (tui_display_all_data): Don't declare.
5013         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
5014         from tui_display_all_data.
5015         * tui/tui-win.c
5016         (tui_data_window::do_make_visible_with_new_height): Update.
5017         * tui/tui-regs.c (tui_show_registers): Update.
5018         * tui/tui-layout.c (tui_set_layout): Update.
5019         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
5020         method.
5021
5022 2019-07-17  Tom Tromey  <tom@tromey.com>
5023
5024         * tui/tui-windata.h (tui_display_data_from): Don't declare.
5025         * tui/tui-windata.c (tui_display_data_from): Remove.
5026         (tui_data_window::refresh_all): Update.
5027
5028 2019-07-17  Tom Tromey  <tom@tromey.com>
5029
5030         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
5031         * tui/tui-windata.c (tui_display_data_from_line): Remove.
5032         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
5033         tui_display_registers_from_line.
5034         * tui/tui-regs.h (tui_display_registers_from_line): Update.
5035         * tui/tui-regs.c (tui_display_registers_from_line): Remove
5036         "force_display" parameter.
5037
5038 2019-07-17  Tom Tromey  <tom@tromey.com>
5039
5040         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
5041         declare.
5042         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
5043         Rename from tui_first_reg_element_no_inline.
5044         (tui_display_reg_element_at_line)
5045         (tui_display_registers_from_line): Update.
5046         * tui/tui-data.h (struct tui_data_window)
5047         <first_reg_element_no_inline>: New method.
5048
5049 2019-07-17  Tom Tromey  <tom@tromey.com>
5050
5051         * tui/tui-windata.c (tui_display_data_from)
5052         (tui_data_window::do_scroll_vertical): Update.
5053         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
5054         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
5055         Rename from tui_line_from_reg_element_no.
5056         (tui_display_registers_from_line): Update.
5057         * tui/tui-data.h (struct tui_data_window)
5058         <line_from_reg_element_no>: New method.
5059
5060 2019-07-17  Tom Tromey  <tom@tromey.com>
5061
5062         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
5063         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
5064         tui_last_regs_line_no.
5065         (tui_display_reg_element_at_line)
5066         (tui_display_registers_from_line): Update.
5067         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
5068         method.
5069
5070 2019-07-17  Tom Tromey  <tom@tromey.com>
5071
5072         PR tui/24722:
5073         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
5074         (tui_update_breakpoint_info): Add "being_deleted" parameter.
5075         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
5076         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
5077         (tui_update_breakpoint_info): Likewise.
5078         * tui/tui-hooks.c (tui_event_create_breakpoint)
5079         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
5080         Update.
5081
5082 2019-07-17  Tom Tromey  <tom@tromey.com>
5083
5084         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
5085
5086 2019-07-17  Tom Tromey  <tom@tromey.com>
5087
5088         * tui/tui-winsource.c (tui_update_source_window_as_is)
5089         (tui_update_source_windows_with_addr): Update.
5090         * tui/tui-source.h (tui_set_source_content)
5091         (tui_show_symtab_source): Add "win_info" parameter.
5092         * tui/tui-source.c (tui_set_source_content): Add "win_info"
5093         parameter.
5094         (tui_show_symtab_source): Likewise.
5095
5096 2019-07-17  Tom Tromey  <tom@tromey.com>
5097
5098         * tui/tui-wingeneral.c
5099         (tui_check_and_display_highlight_if_needed): Check can_highlight.
5100
5101 2019-07-17  Tom Tromey  <tom@tromey.com>
5102
5103         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
5104         (struct tui_cmd_window) <can_scroll>: New method.
5105         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
5106         method.
5107
5108 2019-07-17  Tom Tromey  <tromey@adacore.com>
5109
5110         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
5111         do_field_signed>: Rename.  Change type of "value".
5112         * ui-out.c (ui_out::field_signed): Rename from field_int.
5113         Change type of "value".
5114         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
5115         type of "value".
5116         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
5117         do_field_int.  Change type of "value".
5118         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
5119         do_field_int.  Change type of "value".
5120         * tracepoint.c (trace_status_mi, tfind_1)
5121         (print_one_static_tracepoint_marker): Update.
5122         * thread.c (print_thread_info_1, print_selected_thread_frame):
5123         Update.
5124         * stack.c (print_frame, print_frame_info): Update.
5125         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
5126         Update.
5127         * source.c (print_source_lines_base): Update.
5128         * skip.c (info_skip_command): Update.
5129         * record-btrace.c (btrace_ui_out_decode_error)
5130         (btrace_call_history_src_line): Update.
5131         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
5132         Update.
5133         * progspace.c (print_program_space): Update.
5134         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
5135         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
5136         do_field_int.  Change type of "value".
5137         * mi/mi-out.c (mi_ui_out::do_table_begin)
5138         (mi_ui_out::do_table_header): Update.
5139         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
5140         type of "value".
5141         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
5142         (mi_cmd_data_list_changed_registers, output_register)
5143         (mi_cmd_data_read_memory, mi_load_progress)
5144         (mi_cmd_trace_frame_collected): Update.
5145         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
5146         Update.
5147         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
5148         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
5149         (mi_cmd_var_list_children, varobj_update_one): Update.
5150         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
5151         (mi_cmd_stack_list_args, list_arg_or_local): Update.
5152         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
5153         * inferior.c (print_inferior): Update.
5154         * gdb_bfd.c (print_one_bfd): Update.
5155         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
5156         Update.
5157         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
5158         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
5159         do_field_int.  Change type of "value".
5160         * cli-out.c (cli_ui_out::do_field_signed): Rename from
5161         do_field_int.  Change type of "value".
5162         * breakpoint.c (watchpoint_check, print_breakpoint_location)
5163         (print_one_breakpoint_location, print_it_catch_fork)
5164         (print_one_catch_fork, print_it_catch_vfork)
5165         (print_one_catch_vfork, print_it_catch_solib)
5166         (print_it_catch_exec, print_it_ranged_breakpoint)
5167         (print_mention_watchpoint, print_mention_masked_watchpoint)
5168         (bkpt_print_it, update_static_tracepoint): Update.
5169         * break-catch-throw.c (print_it_exception_catchpoint): Update.
5170         * break-catch-syscall.c (print_it_catch_syscall): Update.
5171         * ada-tasks.c (print_ada_task_info): Update.
5172         * ada-lang.c (print_it_exception, print_mention_exception):
5173         Update.
5174
5175 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
5176
5177         PR breakpoints/24541
5178         * gdbarch.c: Regenerate.
5179         * gdbarch.h: Regenerate.
5180         * gdbarch.sh: Adjust return type and parameter types for
5181         'stap_adjust_register'.
5182         (i386_stap_adjust_register): Adjust signature and return new
5183         register name.
5184         * stap-probe.c (stap_parse_register_operand): Adjust use of
5185         'gdbarch_stap_adjust_register'.
5186
5187 2019-07-17  Tom Tromey  <tromey@adacore.com>
5188
5189         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
5190         declare VEC.
5191         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
5192         std::vector.
5193         (struct s390_process_info): Add initializers.
5194         (s390_add_process): Use new.
5195         (s390_linux_nat_target::low_forget_process): Use delete.
5196         (s390_linux_nat_target::low_new_fork)
5197         (s390_linux_nat_target::stopped_by_watchpoint)
5198         (s390_linux_nat_target::low_prepare_to_resume)
5199         (s390_linux_nat_target::insert_watchpoint)
5200         (s390_linux_nat_target::insert_hw_breakpoint)
5201         (s390_linux_nat_target::remove_watchpoint)
5202         (s390_linux_nat_target::remove_hw_breakpoint): Update.
5203
5204 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
5205
5206         * aarch64-fbsd-nat.c: Include regcache.h.
5207         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
5208         argument.
5209         (aarch64_fbsd_nat_target::fetch_registers)
5210         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
5211         variable.
5212         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
5213
5214 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
5215
5216         * fbsd-nat.c: Include gdbarch.h.
5217
5218 2019-07-15  Tom Tromey  <tromey@adacore.com>
5219
5220         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
5221
5222 2019-07-15  Tom Tromey  <tromey@adacore.com>
5223
5224         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
5225         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
5226         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
5227         * cli-out.c (cli_ui_out::do_field_int): New method.
5228         * ui-out.c (ui_out::field_unsigned): New method.
5229         * symfile.c (generic_load): Use field_unsigned.
5230         (print_transfer_performance): Likewise.
5231         * record-btrace.c (ui_out_field_uint): Remove.
5232         (btrace_call_history_insn_range, btrace_call_history): Use
5233         field_unsigned.
5234         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
5235         field_unsigned.
5236         * ui-out.h (class ui_out) <field_unsigned>: New method.
5237         <do_field_unsigned>: Likewise.
5238
5239 2019-07-15  Tom Tromey  <tromey@adacore.com>
5240
5241         * mi/mi-main.c (list_available_thread_groups): Use field_string.
5242         * mi/mi-interp.c (mi_memory_changed): Use field_string.
5243         * target.c (flash_erase_command): Use field_string.
5244         * infrun.c (print_signal_received_reason): Use field_string.
5245         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
5246         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
5247         field_string.
5248         * ada-tasks.c (print_ada_task_info): Use field_string.
5249
5250 2019-07-15  Tom Tromey  <tromey@adacore.com>
5251
5252         * target.c (flash_erase_command): Use field_core_addr.
5253         * symfile.c (generic_load): Use field_core_addr.
5254         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
5255         Use field_core_addr.
5256         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
5257         field_core_addr.
5258
5259 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
5260
5261         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
5262         value if its desired type is smaller than a CORE_ADDR and signed.
5263
5264 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
5265
5266         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
5267         of changes to field names, and use new is_reference field to
5268         decide if a property is a reference or not.
5269         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
5270         field.
5271         (struct dwarf2_property_baton): Update header comment, rename
5272         'referenced_type' to 'property_type' and update comments.
5273         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
5274         default property type, store in property baton, update to take
5275         accound of renamed field.
5276         (read_func_scope): Update call to attr_to_dynamic_prop.
5277         (read_array_type): Likewise.
5278         (dwarf2_per_cu_addr_sized_int_type): New function.
5279         (read_subrange_index_type): Move type finding code to
5280         dwarf2_per_cu_addr_sized_int_type.
5281         (read_subrange_type): Update calls to attr_to_dynamic_prop.
5282         (dwarf2_per_cu_addr_type): New function.
5283         (set_die_type): Update calls to attr_to_dynamic_prop.
5284
5285 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
5286
5287         * dwarf2read.c (read_subrange_index_type): New function.
5288         (read_subrange_type): Move code into new function and call it.
5289         * gdbtypes.c (create_range_type): Add some asserts.
5290
5291 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
5292
5293         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
5294         update return statements.
5295         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
5296         declaration, and update comment to match.
5297         * gdbtypes.c (resolve_dynamic_array): Update call to
5298         dwarf2_evaluate_property to match new return type.
5299
5300 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
5301
5302         * valarith.c (value_subscripted_rvalue): Change lowerbound
5303         parameter type from int to LONGEST.
5304         * value.h (value_subscripted_rvalue): Likewise in declaration.
5305
5306 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5307
5308         * cli/cli-utils.c (info_print_command_completer): New function.
5309         * cli/cli-utils.h: Add 'completer.h' include, and forward
5310         declaration for 'struct cmd_list_element'.
5311         (info_print_command_completer): Declare.
5312         * stack.c (_initialize_stack): Add completer for 'info locals' and
5313         'info args'.
5314         * symtab.c (_initialize_symtab): Add completer for 'info
5315         variables' and 'info functions'.
5316         * NEWS: Mention completion for additional info commands.
5317
5318 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5319
5320         * cli/cli-utils.c (extract_info_print_args): Delete.
5321         (extract_arg_maybe_quoted): Delete.
5322         (info_print_options_defs): New variable.
5323         (make_info_print_options_def_group): New function.
5324         (extract_info_print_options): Define new function.
5325         * cli/cli-utils.h (extract_info_print_args): Delete.
5326         (struct info_print_options): New structure.
5327         (extract_info_print_options): Declare new function.
5328         * stack.c (info_locals_command): Update to use new
5329         extract_info_print_options, also add a header comment.
5330         (info_args_command): Likewise.
5331         * symtab.c (info_variables_command): Likewise.
5332         (info_functions_command): Likewise.
5333
5334 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5335
5336         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
5337         to extract string arguments.
5338         * common/common-utils.c (extract_string_maybe_quoted): New function.
5339         * common/common-utils.h (extract_string_maybe_quoted): Declare.
5340
5341 2019-07-11  Tom Tromey  <tromey@adacore.com>
5342
5343         * main.c (get_init_files): Use GDBINIT, not gdbinit.
5344         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
5345         * top.h (gdbinit): Don't declare.
5346         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
5347         into...
5348         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
5349         * top.c (gdb_init): Don't call init_cli_cmds.
5350         (gdbinit): Remove.
5351         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
5352
5353 2019-07-11  Tom Tromey  <tromey@adacore.com>
5354
5355         * python/py-inferior.c (add_thread_object): Don't use thread_obj
5356         after it has been moved.
5357
5358 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
5359
5360         * valops.c (value_must_coerce_to_target): Change return type to
5361         bool.
5362         * value.h (value_must_coerce_to_target): Likewise.
5363
5364 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
5365
5366         * breakpoint.c (is_hardware_watchpoint): Remove
5367         forward-declaration.
5368         (is_masked_watchpoint): Change return type to bool.
5369         (is_tracepoint): Likewise.
5370         (is_breakpoint): Likewise.
5371         (is_hardware_watchpoint): Likewise.
5372         (is_watchpoint): Likewise.
5373         (is_no_memory_software_watchpoint): Likewise.
5374         (is_catchpoint): Likewise.
5375         (breakpoint_1): Make FILTER parameter's return type bool.
5376         is_masked_watchpoint): Change return type to bool.
5377         (save_breakpoints): Make FILTER parameter's return type bool.
5378         * breakpoint.h (is_breakpoint): Change return type to bool.
5379         (is_watchpoint): Likewise.
5380         (is_catchpoint): Likewise.
5381         (is_tracepoint): Likewise.
5382
5383 2019-07-10  Tom Tromey  <tom@tromey.com>
5384
5385         * defs.h: Don't include gdbarch.h.
5386         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
5387         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
5388         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
5389         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
5390         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
5391         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
5392         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
5393         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
5394         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
5395         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
5396         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
5397         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
5398         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
5399         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
5400         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
5401         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
5402         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
5403         record-btrace.c, record.h, regcache-dump.c, regcache.h,
5404         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
5405         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
5406         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
5407         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
5408         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
5409         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
5410         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
5411         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
5412         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
5413
5414 2019-07-10  Tom Tromey  <tromey@adacore.com>
5415
5416         * ada-lang.h (is_ada_exception_catchpoint): Declare.
5417         * breakpoint.c (init_ada_exception_breakpoint): Register as
5418         bp_catchpoint.
5419         (print_one_breakpoint_location, print_one_breakpoint): Use
5420         is_ada_exception_catchpoint.
5421         * ada-lang.c (class ada_catchpoint_location): Pass
5422         bp_loc_software_breakpoint to bp_location constructor.
5423         (is_ada_exception_catchpoint): New function.
5424
5425 2019-07-10  Tom Tromey  <tromey@adacore.com>
5426
5427         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
5428         VEC.
5429         (struct arm_exidx_entry): New method operator<.
5430         (struct arm_exidx_data) <section_maps>: Change type.
5431         (arm_exidx_data_free): Remove.
5432         (arm_exidx_data_key): Change type.  Move lower.
5433         (arm_exidx_new_objfile): Update.
5434         (arm_compare_exidx_entries): Remove.
5435         (arm_find_exidx_entry, _initialize_arm_tdep)
5436
5437 2019-07-10  Tom Tromey  <tromey@adacore.com>
5438
5439         * solib-spu.c (ocl_program_data_key): Change type.
5440         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
5441         Update.
5442
5443 2019-07-10  Tom Tromey  <tromey@adacore.com>
5444
5445         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
5446         (struct solib_aix_inferior_data) <library_list>: Change type.
5447         (solib_aix_inferior_data_handle): Change type.
5448         (get_solib_aix_inferior_data): Update.
5449         (solib_aix_free_library_list): Remove.
5450         (library_list_start_library): Update.
5451         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
5452         return type.
5453         (solib_aix_get_library_list)
5454         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
5455         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
5456
5457 2019-07-10  Tom Tromey  <tromey@adacore.com>
5458
5459         * solib-dsbt.c (struct dsbt_info): Add initializers.
5460         (solib_dsbt_pspace_data): Change type.
5461         (dsbt_pspace_data_cleanup): Remove.
5462         (get_dsbt_info, _initialize_dsbt_solib): Update.
5463
5464 2019-07-10  Tom Tromey  <tromey@adacore.com>
5465
5466         * spu-tdep.c (spu_overlay_data): Change type.
5467         (spu_get_overlay_table, spu_overlay_new_objfile)
5468         (_initialize_spu_tdep): Update.
5469
5470 2019-07-10  Tom Tromey  <tromey@adacore.com>
5471
5472         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
5473         destructor.
5474         (dbx_objfile_data_key): Change type and declare later.
5475         (DBX_SYMFILE_INFO): Rewrite.
5476         * dbxread.c (dbx_objfile_data_key): Change type.
5477         (dbx_symfile_init): Update.
5478         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
5479         (coffstab_build_psymtabs, elfstab_build_psymtabs)
5480         (stabsect_build_psymtabs, _initialize_dbxread): Update.
5481
5482 2019-07-10  Tom Tromey  <tromey@adacore.com>
5483
5484         * jit.c (jit_program_space_key): Change type.  Move lower.
5485         (get_jit_program_space_data): Update.
5486         (jit_program_space_data_cleanup): Remove.
5487         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
5488         Update.
5489         (struct jit_program_space_data): Add initializers.
5490
5491 2019-07-10  Tom Tromey  <tromey@adacore.com>
5492
5493         * solib-darwin.c (struct darwin_info): Add initializers.
5494         (solib_darwin_pspace_data): Change type.
5495         (darwin_pspace_data_cleanup): Remove.
5496         (get_darwin_info, _initialize_darwin_solib): Update.
5497
5498 2019-07-10  Tom Tromey  <tromey@adacore.com>
5499
5500         * remote-sim.c (struct sim_inferior_data): Add initializers,
5501         constructor, and destructor.
5502         (sim_inferior_data_key): Change type.  Move lower.
5503         (check_for_duplicate_sim_descriptor): Update.
5504         (get_sim_inferior_data): Use new.  Update.
5505         (~sim_inferior_data_cleanup): Rename from
5506         sim_inferior_data_cleanup.  Simplify.
5507         (gdbsim_close_inferior, simulator_command)
5508         (sim_command_completer, _initialize_remote_sim): Update.
5509         (next_pid, INITIAL_PID): Move earlier.
5510
5511 2019-07-10  Tom Tromey  <tromey@adacore.com>
5512
5513         * python/python-internal.h (create_thread_object): Return
5514         gdbpy_ref.
5515         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
5516         * python/py-inferior.c (struct threadlist_entry): Add
5517         constructor.
5518         <thread_obj>: Now a gdbpy_ref.
5519         (thread_to_thread_object): Update.
5520         (add_thread_object): Use new.
5521         (delete_thread_object): Use delete.
5522         (infpy_threads): Update.
5523         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
5524         GIL.
5525
5526 2019-07-10  Tom Tromey  <tromey@adacore.com>
5527
5528         * valops.c (value_cast): Specialize error message for Ada.
5529
5530 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
5531
5532         * breakpoint.c (breakpoint_1): Update doc and parameter names.
5533
5534 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
5535
5536         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
5537         bpstat_should_step): Return bool, adjust comments.
5538         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
5539         bpstat_should_step): Likewise.
5540
5541 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
5542
5543         * features/Makefile: Use feature target descriptions for Arm.
5544         * features/arm/arm-core.c: Generate new file.
5545         * features/arm/arm-fpa.c: Likewise.
5546         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
5547         * features/arm/arm-m-profile.c: Likewise.
5548         * features/arm/arm-vfpv2.c: Likewise.
5549         * features/arm/arm-vfpv3.c: Likewise.
5550         * features/arm/xscale-iwmmxt.c: Likewise.
5551         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
5552
5553 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
5554
5555         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
5556         ptrace earlier.
5557
5558 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
5559
5560         * features/aarch64-pauth.c: Regenerate.
5561
5562 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
5563
5564         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
5565         bool.
5566         (bpstat_what): Use false instead of 0.
5567
5568 2019-07-09  Pedro Alves  <palves@redhat.com>
5569
5570         * break-catch-throw.c (is_exception_catchpoint): New.
5571         * breakpoint.c (print_one_breakpoint_location): New parameter
5572         'raw_loc'.  Handle it.  Use
5573         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
5574         looking at the breakpoint's type.
5575         (print_one_breakpoint): If handling "maint info breakpoints", also
5576         print locations of exception catchpoints.
5577         * breakpoint.h (is_exception_catchpoint): Declare.
5578
5579 2019-07-09  Pedro Alves  <palves@redhat.com>
5580
5581         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
5582         "addr" field.
5583         (allocate_location_exception_catchpoint): New.
5584         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
5585         (initialize_throw_catchpoint_ops): Install
5586         allocate_location_exception_catchpoint as allocate_location
5587         method.
5588         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
5589         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
5590         bp_loc_other.
5591         (breakpoint_address_is_meaningful): Delete.
5592         (bl_address_is_meaningful): New.
5593         (breakpoint_locations_match): Adjust comment.
5594         (bp_location_from_bp_type): New, factored out of...
5595         (bp_location::bp_location(breakpoint *)): ... this.
5596         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
5597         factored out of...
5598         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
5599         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
5600         breakpoint_address_is_meaningful.
5601         (bp_locations_compare): Adjust comment.
5602         (update_global_location_list): Use bl_address_is_meaningful
5603         instead of breakpoint_address_is_meaningful.
5604         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
5605         explicit.
5606         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
5607         * python/py-breakpoint.c (bppy_get_location): No longer check
5608         whether location is null.
5609
5610 2019-07-09  Pedro Alves  <palves@redhat.com>
5611
5612         PR c++/15468
5613         * breakpoint.c (print_one_breakpoint_location): Remove
5614         single-location assert.
5615
5616 2019-07-09  Tom Tromey  <tom@tromey.com>
5617
5618         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
5619         * configure: Rebuild.
5620         * configure.ac: Change common to gdbsupport.
5621         * gdbsupport: Rename from common.
5622         * acinclude.m4: Change common to gdbsupport.
5623         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
5624         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
5625         gdbsupport.
5626         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
5627         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
5628         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
5629         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
5630         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
5631         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
5632         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
5633         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
5634         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
5635         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
5636         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
5637         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
5638         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
5639         coff-pe-read.c, command.h, compile/compile-c-support.c,
5640         compile/compile-c.h, compile/compile-cplus-symbols.c,
5641         compile/compile-cplus-types.c, compile/compile-cplus.h,
5642         compile/compile-loc2c.c, compile/compile.c, completer.c,
5643         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
5644         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
5645         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
5646         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
5647         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
5648         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
5649         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
5650         features/aarch64-core.c, features/aarch64-fpu.c,
5651         features/aarch64-pauth.c, features/aarch64-sve.c,
5652         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
5653         features/i386/32bit-core.c, features/i386/32bit-linux.c,
5654         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
5655         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
5656         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
5657         features/i386/64bit-core.c, features/i386/64bit-linux.c,
5658         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
5659         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
5660         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
5661         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
5662         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
5663         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
5664         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
5665         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
5666         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
5667         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
5668         go32-nat.c, guile/guile.c, guile/scm-ports.c,
5669         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
5670         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
5671         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
5672         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
5673         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
5674         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
5675         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
5676         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
5677         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
5678         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
5679         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
5680         minsyms.c, mips-linux-tdep.c, namespace.h,
5681         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
5682         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
5683         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
5684         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
5685         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
5686         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
5687         nat/linux-waitpid.c, nat/mips-linux-watch.c,
5688         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
5689         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
5690         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
5691         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
5692         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
5693         procfs.c, producer.c, progspace.h, psymtab.h,
5694         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
5695         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
5696         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
5697         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
5698         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
5699         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
5700         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
5701         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
5702         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
5703         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
5704         target-memory.c, target.c, target.h, target/waitstatus.c,
5705         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
5706         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
5707         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
5708         unittests/array-view-selftests.c,
5709         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
5710         unittests/common-utils-selftests.c,
5711         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
5712         unittests/format_pieces-selftests.c,
5713         unittests/function-view-selftests.c,
5714         unittests/lookup_name_info-selftests.c,
5715         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
5716         unittests/mkdir-recursive-selftests.c,
5717         unittests/observable-selftests.c,
5718         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
5719         unittests/parse-connection-spec-selftests.c,
5720         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
5721         unittests/scoped_fd-selftests.c,
5722         unittests/scoped_mmap-selftests.c,
5723         unittests/scoped_restore-selftests.c,
5724         unittests/string_view-selftests.c, unittests/style-selftests.c,
5725         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
5726         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
5727         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
5728         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
5729         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
5730         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
5731
5732 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
5733
5734         * linespec.c (decode_digits_list_mode): Set explicit_line to a
5735         bool value.
5736         (decode_digits_ordinary): Set explicit_line field in sal.
5737         * symtab.c (skip_prologue_sal): Don't skip prologue for a
5738         symtab_and_line that was set on an explicit line number in
5739         assembler code.  Do always update the recorded symtab and line if
5740         we do skip the prologue.
5741
5742 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
5743
5744         * breakpoint.c (set_breakpoint_location_function): Remove
5745         explicit_loc parameter.
5746         (momentary_breakpoint_from_master): Update call to
5747         set_breakpoint_location_function.
5748         (add_location_to_breakpoint): Likewise.
5749
5750 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
5751
5752         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
5753         required features based on default bfd type when no specific bfd
5754         is present.
5755
5756 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5757
5758         * NEWS: Mention that GDB printf and eval commands can now print
5759         C-style and Ada-style convenience var strings without
5760         calling the inferior.
5761         * printcmd.c (printf_c_string): Locally print GDB internal var
5762         instead of transiting via the inferior.
5763         (printf_wide_c_string): Likewise.
5764
5765 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5766
5767         PR breakpoints/25011
5768         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
5769
5770 2019-07-04  Tom Tromey  <tom@tromey.com>
5771
5772         PR tui/24724:
5773         * tui/tui-winsource.c (tui_clear_source_content): Update.
5774         (tui_source_window_base::set_is_exec_point_at): Fix comment.
5775         (tui_update_breakpoint_info): Update.
5776         (tui_set_exec_info_content): Update.
5777         * tui/tui-source.c (tui_set_source_content_nil): Update.
5778         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
5779         has_break.
5780         * tui/tui-data.h (enum tui_bp_flag): New.
5781         (tui_bp_flags): New enum flags type.
5782         (struct tui_source_element) <break_mode>: Change type.  Rename
5783         from has_break.
5784         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
5785         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
5786         constants.
5787         * tui/tui-winsource.h: Fix comment.
5788
5789 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5790
5791         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
5792         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
5793         (store_fpregs_to_thread)
5794         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
5795         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
5796         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
5797         (IWMMXT_REGS_SIZE): Add define.
5798         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
5799         (fetch_vfp_regs, store_vfp_regs)
5800         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
5801         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
5802
5803 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5804
5805         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
5806         defines.
5807         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
5808         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
5809         (ARM_INT_REGISTER_SIZE): ...to this.
5810         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
5811         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
5812         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
5813         (arm_linux_collect_gregset, supply_nwfpe_register)
5814         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
5815         defines.
5816         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
5817         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
5818         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
5819         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
5820         (arm_return_in_memory, arm_store_return_value)
5821         (arm_get_longjmp_target, arm_register_g_packet_guesses)
5822         (arm_record_ld_st_multiple): Likewise.
5823         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
5824         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
5825
5826 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5827
5828         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
5829         AARCH64_DISPLACED_MODIFIED_INSNS.
5830         * aarch64-tdep.c (struct aarch64_displaced_step_data)
5831         (aarch64_displaced_step_copy_insn): Likewise.
5832         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
5833         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
5834         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
5835         ARM_DISPLACED_MODIFIED_INSNS.
5836         * arm-tdep.c (arm_gdbarch_init): Likewise.
5837         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
5838         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
5839         (struct arm_displaced_step_closure): Use
5840         ARM_DISPLACED_MODIFIED_INSNS.
5841
5842 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5843
5844         * features/Makefile: Remove unused xml files.
5845         * features/aarch64.xml: Remove.
5846         * features/i386/amd64-avx-avx512-linux.xml: Remove.
5847         * features/i386/amd64-avx-avx512.xml: Remove.
5848         * features/i386/amd64-avx-linux.xml: Remove.
5849         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
5850         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
5851         * features/i386/amd64-avx-mpx-linux.xml: Remove.
5852         * features/i386/amd64-avx-mpx.xml: Remove.
5853         * features/i386/amd64-avx.xml: Remove.
5854         * features/i386/amd64-linux.xml: Remove.
5855         * features/i386/amd64-mpx-linux.xml: Remove.
5856         * features/i386/amd64-mpx.xml: Remove.
5857         * features/i386/amd64.xml: Remove.
5858         * features/i386/i386-avx-avx512-linux.xml: Remove.
5859         * features/i386/i386-avx-avx512.xml: Remove.
5860         * features/i386/i386-avx-linux.xml: Remove.
5861         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
5862         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
5863         * features/i386/i386-avx-mpx-linux.xml: Remove.
5864         * features/i386/i386-avx-mpx.xml: Remove.
5865         * features/i386/i386-avx.xml: Remove.
5866         * features/i386/i386-linux.xml: Remove.
5867         * features/i386/i386-mmx-linux.xml: Remove.
5868         * features/i386/i386-mmx.xml: Remove.
5869         * features/i386/i386-mpx-linux.xml: Remove.
5870         * features/i386/i386-mpx.xml: Remove.
5871         * features/i386/i386.xml: Remove.
5872         * features/i386/x32-avx-avx512-linux.xml: Remove.
5873         * features/i386/x32-avx-linux.xml: Remove.
5874         * features/i386/x32-linux.xml: Remove.
5875
5876 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5877
5878         * regformats/aarch64.dat: Remove.
5879         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
5880         * regformats/i386/amd64-avx-linux.dat: Remove.
5881         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
5882         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
5883         * regformats/i386/amd64-linux.dat: Remove.
5884         * regformats/i386/amd64-mpx-linux.dat: Remove.
5885         * regformats/i386/amd64.dat: Remove.
5886         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
5887         * regformats/i386/i386-avx-linux.dat: Remove.
5888         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
5889         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
5890         * regformats/i386/i386-linux.dat: Remove.
5891         * regformats/i386/i386-mmx-linux.dat: Remove.
5892         * regformats/i386/i386-mpx-linux.dat: Remove.
5893         * regformats/i386/i386.dat: Remove.
5894         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
5895         * regformats/i386/x32-avx-linux.dat: Remove.
5896         * regformats/i386/x32-linux.dat: Remove.
5897
5898 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5899
5900         * aarch64-tdep.c: Remove xml self tests.
5901         * amd64-linux-tdep.c: Likewise.
5902         * amd64-tdep.c: Likewise.
5903         * i386-linux-tdep.c: Likewise.
5904         * i386-tdep.c: Likewise.
5905
5906 2019-07-03  Pedro Alves  <palves@redhat.com>
5907
5908         PR cli/24732
5909         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
5910         (pipe_cmd_option_defs): New.
5911         (make_pipe_cmd_options_def_group): New.
5912         (pipe_command): Use gdb::option::process_options.
5913         (pipe_command_completer): New function.
5914         (_initialize_cli_cmds): Install completer for "pipe" command.
5915
5916 2019-07-03  Pedro Alves  <palves@redhat.com>
5917
5918         * cli/cli-option.c (union option_value) <string>: New field.
5919         (struct option_def_and_value): Add ctor, move ctor, dtor and
5920         use DISABLE_COPY_AND_ASSIGN.
5921         (option_def_and_value::clear_value): New.
5922         (parse_option, save_option_value_in_ctx, get_val_type_str)
5923         (add_setshow_cmds_for_options): Handle var_string.
5924         * cli-option.h (union option_def::var_address) <string>: New
5925         field.
5926         (struct string_option_def): New.
5927         * maint-test-options.c (struct test_options_opts): Add default
5928         ctor and use DISABLE_COPY_AND_ASSIGN.
5929         <string_opt>: New field.
5930         (test_options_opts::~test_options_opts): New.
5931         (test_options_opts::dump): Also dump "-string".
5932         (test_options_option_defs): Install "string.
5933
5934 2019-07-03  Pedro Alves  <palves@redhat.com>
5935
5936         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
5937         option_value with a null enumeration.
5938         (complete_options): Save the option values in the context.
5939         (save_option_value_in_ctx): New, factored out from ...
5940         (process_options): ... here.
5941         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
5942         of the function.
5943         * maint-test-options.c (test_options_opts::dump): New, factored
5944         out from ...
5945         (maintenance_test_options_command_mode): ... here.
5946         (maintenance_test_options_command_completion_result): Delete.
5947         (maintenance_test_options_command_completion_text): Update
5948         comment.
5949         (maintenance_show_test_options_completion_result): Change
5950         prototype.  Just print
5951         maintenance_test_options_command_completion_text.
5952         (save_completion_result): New.
5953         (maintenance_test_options_completer_mode): Pass options context to
5954         complete_options, and then save a dump.
5955         (_initialize_maint_test_options): Use add_cmd to install "maint
5956         show test-options-completion-result".
5957
5958 2019-07-03  Pedro Alves  <palves@redhat.com>
5959
5960         * NEWS (New commands): Mention "with" and "maint with".
5961         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
5962         (with_command, with_command_completer): New.
5963         (pipe_command): Adjust to new repeat_previous
5964         interface.
5965         (_initialize_cli_cmds): Install the "with" command and its "w"
5966         alias.
5967         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
5968         declarations.
5969         * cli/cli-setshow.c (parse_cli_var_uinteger)
5970         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
5971         argument strings for all var_types.
5972         (get_setshow_command_value_string): New, factored out from ...
5973         (do_show_command): ... this.
5974         * cli/cli-setshow.h: Include <string>.
5975         (get_setshow_command_value_string): Declare.
5976         * command.h (repeat_previous): Now returns const char *.  Adjust
5977         comment.
5978         * maint.c: Include "cli/cli-cmds.h".
5979         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
5980         (_initialize_maint_cmds): Register the "maintenance with" command.
5981         * top.c (repeat_previous): Move bits from pipe_command here:
5982         Return the saved command line, if any; error out if there's no
5983         command to relaunch.
5984
5985 2019-07-03  Pedro Alves  <palves@redhat.com>
5986
5987         * NEWS (New commands): Mention "maint set/show test-settings"
5988         instead of "maint test-settings".
5989         * maint-test-settings.c (maintenance_test_settings_list): Delete.
5990         (maintenance_test_settings_set_list): Rename to ...
5991         (maintenance_set_test_settings_list): ... this.
5992         (maintenance_test_settings_show_list): Rename to  ...
5993         (maintenance_show_test_settings_list): ... this.
5994         (maintenance_test_settings_cmd): Delete.
5995         (maintenance_test_settings_set_cmd): ...
5996         (maintenance_set_test_settings_cmd): ... this.
5997         (maintenance_test_settings_show_cmd): ...
5998         (maintenance_show_test_settings_cmd): ... this.
5999         (maintenance_test_settings_show_value_cmd):
6000         (maintenance_show_test_settings_value_cmd): ... this.
6001         (_initialize_maint_test_settings): No longer install the "maint
6002         test-settings" prefix command.  Rename "maint test-settings set"
6003         to "maint set test-settings", and "maint test-settings show" to
6004         "maint show test-settings".  Adjust all subcommands.
6005
6006 2019-07-03  Pedro Alves  <palves@redhat.com>
6007
6008         * maint-test-settings.c: Fix file's intro comment.  Replace all
6009         references to "test-options" with references to "test-settings",
6010         in comments.
6011
6012 2019-07-03  Pedro Alves  <palves@redhat.com>
6013
6014         * maint-test-settings.c (maintenance_test_settings_xxx)
6015         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
6016         New.
6017         (maintenance_test_settings_enums): Use them.
6018         (maintenance_test_settings_enum): Default to
6019         maintenance_test_settings_xxx.
6020         (_initialize_maint_test_settings): Initialize
6021         MAINTENANCE_TEST_SETTINGS_FILENAME.
6022
6023 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
6024
6025         * breakpoint.h (remove_breakpoints_inf): Change return type to
6026         void, move function documentation here.
6027         * breakpoint.c (remove_breakpoints_inf): Change return type to
6028         void, move function documentation to header.
6029
6030 2019-07-02  Pedro Alves  <palves@redhat.com>
6031
6032         * NEWS (Completion improvements): Mention "info threads".
6033         * thread.c (struct info_threads_opts, info_threads_option_defs)
6034         (make_info_threads_options_def_group): New.
6035         (info_threads_command): Use gdb::option::process_options.
6036         (info_threads_command_completer): New.
6037         (_initialize_thread): Use gdb::option::build_help to build the
6038         help text for "info threads".
6039
6040 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
6041
6042         * defs.h (generic_load): Move from here...
6043         * symfile.h (generic_load): ... to here.  Rename name parameter
6044         to args.
6045         * symfile.c (generic_load): Add comment.
6046
6047 2019-07-01  Tom Tromey  <tromey@adacore.com>
6048
6049         * dwarf2read.c
6050         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
6051         declaration of without_params.  Fix formatting.
6052
6053 2019-07-01  Tom Tromey  <tromey@adacore.com>
6054
6055         * ada-exp.y (find_primitive_type): Update.
6056         * ada-lang.h (ada_lookup_symbol): Update.
6057         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
6058         parameter.
6059         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
6060
6061 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
6062
6063         PR breakpoints/24541
6064         * gdbarch.c: Regenerate.
6065         * gdbarch.h: Regenerate.
6066         * gdbarch.sh: Add 'stap_adjust_register'.
6067         * i386-tdep.c: Include '<unordered_set>'.
6068         (i386_stap_adjust_register): New function.
6069         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
6070         * stap-probe.c (stap_parse_register_operand): Call
6071         'gdbarch_stap_adjust_register'.
6072
6073 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
6074
6075         PR python/24742
6076         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
6077         * python/python.c (do_start_initialization): Use 'xmalloc'
6078         instead of 'PyMem_Malloc'.
6079
6080 2019-06-28  Tom Tromey  <tromey@adacore.com>
6081
6082         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
6083         for Ada.
6084
6085 2019-06-27  Tom Tromey  <tromey@adacore.com>
6086
6087         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
6088         objfile_key.
6089         (arm_find_mapping_symbol, arm_record_special_symbol)
6090         (_initialize_arm_tdep): Update.
6091         (arm_objfile_data_free): Remove.
6092
6093 2019-06-27  Tom Tromey  <tromey@adacore.com>
6094
6095         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
6096         to cp_print_static_field.
6097
6098 2019-06-26  Tom Tromey  <tromey@adacore.com>
6099
6100         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
6101         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
6102         declare.
6103
6104 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
6105
6106         * features/aarch64-core.c (create_feature_aarch64_core):
6107         Regenerate.
6108         * features/aarch64-core.xml: Add cpsr flags.
6109
6110 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
6111
6112         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
6113         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
6114
6115 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
6116
6117         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
6118         field.
6119         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
6120         use.
6121         (arm_record_special_symbol): Don't insert new symbol in sorted
6122         position, push it at the end.
6123
6124 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
6125
6126         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
6127         (arm_mapping_symbol_s): Remove.
6128         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
6129         (arm_mapping_symbol_vec): New typedef.
6130         (struct arm_per_objfile): Add constructor.
6131         <section_maps>: Change type to
6132         std::unique_ptr<arm_mapping_symbol_vec[]>.
6133         (arm_compare_mapping_symbols): Remove.
6134         (arm_find_mapping_symbol): Adjust to section_maps type change.
6135         (arm_objfile_data_free): Call delete on arm_per_objfile.
6136         (arm_record_special_symbol): Adjust to section_maps type change.
6137         Allocate arm_per_objfile with new.
6138
6139 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6140
6141         * cli/cli-cmds.c (alias_command): Compare the alias prefix
6142         with the command prefix.
6143
6144 2019-06-25  Tom Tromey  <tom@tromey.com>
6145
6146         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
6147         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
6148
6149 2019-06-25  Tom Tromey  <tom@tromey.com>
6150
6151         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
6152         type.
6153         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
6154         protected.
6155
6156 2019-06-25  Tom Tromey  <tom@tromey.com>
6157
6158         * tui/tui-winsource.c
6159         (tui_source_window_base::set_is_exec_point_at): Add check against
6160         LOA_ADDRESS.
6161
6162 2019-06-25  Tom Tromey  <tom@tromey.com>
6163
6164         * tui/tui-source.c (tui_set_source_content): Don't check before
6165         xfree.
6166         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
6167
6168 2019-06-25  Tom Tromey  <tom@tromey.com>
6169
6170         * tui/tui-winsource.h (tui_update_source_window_as_is)
6171         (tui_alloc_source_buffer, tui_line_is_displayed)
6172         (tui_addr_is_displayed): Change type of win_info.
6173         * tui/tui-winsource.c (tui_update_source_window_as_is)
6174         (tui_clear_source_content, tui_show_source_line)
6175         (tui_show_source_content, tui_source_window_base::refill)
6176         (tui_source_window_base::set_is_exec_point_at)
6177         (tui_source_window_base::set_is_exec_point_at)
6178         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
6179         (tui_alloc_source_buffer, tui_line_is_displayed)
6180         (tui_addr_is_displayed): Change type of win_info.  Update.
6181         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
6182         (tui_source_window_base::do_make_visible_with_new_height):
6183         Update.
6184         * tui/tui-source.c (tui_set_source_content)
6185         (tui_set_source_content_nil)
6186         (tui_source_window::do_scroll_vertical): Update.
6187         * tui/tui-layout.c (show_layout): Update.
6188         * tui/tui-disasm.c (tui_set_disassem_content)
6189         (tui_disasm_window::do_scroll_vertical): Update.
6190         * tui/tui-data.h (tui_win_content): Remove.
6191         (struct tui_gen_win_info) <content, content_size>: Remove.
6192         (struct tui_source_element): Add initializers and destructor.
6193         (union tui_which_element, struct tui_win_element): Remove.
6194         (struct tui_source_window_base) <content>: New field.
6195         (struct tui_data_window): Remove destructor.
6196         (tui_alloc_content, tui_free_win_content)
6197         (tui_free_all_source_wins_content): Don't declare.
6198         * tui/tui-data.c (tui_initialize_static_data): Update.
6199         (init_content_element, tui_alloc_content): Remove.
6200         (~tui_gen_win_info): Update.
6201         (~tui_data_window, tui_free_all_source_wins_content)
6202         (tui_free_win_content, free_content, free_content_elements):
6203         Remove.
6204
6205 2019-06-25  Tom Tromey  <tom@tromey.com>
6206
6207         * tui/tui-winsource.h (tui_clear_source_content)
6208         (tui_erase_source_content, tui_show_source_content): Change type
6209         of win_info.
6210         * tui/tui-winsource.c (tui_clear_source_content)
6211         (tui_erase_source_content, tui_show_source_content): Change type
6212         of win_info.
6213         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
6214         * tui/tui-source.h (tui_set_source_content_nil): Change type of
6215         win_info.
6216         * tui/tui-source.c (tui_set_source_content_nil): Change type of
6217         win_info.
6218         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
6219
6220 2019-06-25  Tom Tromey  <tom@tromey.com>
6221
6222         * tui/tui-winsource.c (tui_clear_source_content)
6223         (tui_source_window_base::set_is_exec_point_at): Update.
6224         * tui/tui-source.c (tui_set_source_content_nil): Update.
6225         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
6226         a bool.
6227         * tui/tui-data.c (init_content_element): Update.
6228
6229 2019-06-25  Tom Tromey  <tom@tromey.com>
6230
6231         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
6232         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
6233         * tui/tui-layout.c (init_and_make_win): Update.
6234         * tui/tui.h (enum tui_win_type): Update.
6235         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
6236         tui_win_is_auxillary.
6237         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
6238         tui_win_is_auxillary.
6239
6240 2019-06-25  Tom Tromey  <tom@tromey.com>
6241
6242         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
6243         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
6244         (tui_delete_data_content_windows, tui_display_all_data)
6245         (tui_data_window::do_scroll_vertical, tui_display_data_from):
6246         Update.
6247         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
6248         * tui/tui-regs.c (tui_last_regs_line_no)
6249         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
6250         (tui_show_registers): Update.
6251         (tui_show_register_group): Return void.  Update.
6252         (tui_display_registers_from, tui_display_reg_element_at_line)
6253         (tui_display_registers_from_line, tui_check_register_values):
6254         Update.
6255         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
6256         member.
6257         (struct tui_data_window) <regs_content>: Now a std::vector.
6258         <regs_content_count>: Remove.
6259         (tui_add_content_elements, tui_free_data_content): Don't declare.
6260         * tui/tui-data.c (tui_data_window::clear_detail): Update.
6261         (init_content_element): Remove DATA_WIN case.  Add assert.
6262         (tui_add_content_elements): Remove.
6263         (tui_data_window): Update.
6264         (tui_free_data_content): Remove.
6265         (free_content_elements): Remove DATA_WIN case.
6266
6267 2019-06-25  Tom Tromey  <tom@tromey.com>
6268
6269         * tui/tui-data.c (tui_data_item_window): Update.
6270         * tui/tui-windata.h (tui_check_data_values): Don't declare.
6271         * tui/tui-windata.c (tui_display_all_data)
6272         (tui_display_data_from_line): Update.
6273         (tui_check_data_values): Remove.
6274         * tui/tui-regs.c (tui_show_register_group)
6275         (tui_display_reg_element_at_line): Update.
6276         * tui/tui-hooks.c (tui_register_changed)
6277         (tui_refresh_frame_and_register_information): Call
6278         tui_check_register_values.
6279         * tui/tui-data.h (struct tui_data_window) <data_content,
6280         data_content_count, data_type>: Remove.
6281         (enum tui_data_type): Remove.
6282
6283         * tui/tui-data.c (tui_data_window::clear_detail)
6284         (~tui_data_window): Update.
6285
6286 2019-06-25  Tom Tromey  <tom@tromey.com>
6287
6288         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
6289         declare.
6290         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
6291         Rename from tui_first_data_item_displayed.  Update.
6292         (tui_data_window::refresh_all)
6293         (tui_data_window::do_scroll_vertical): Update.
6294         * tui/tui-data.h (struct tui_data_window)
6295         <first_data_item_displayed>: Declare new method.
6296
6297 2019-06-25  Tom Tromey  <tom@tromey.com>
6298
6299         * tui/tui-data.h (tui_init_generic_part): Don't declare.
6300         * tui/tui-data.c (tui_init_generic_part): Remove, moving
6301         contents...
6302         (tui_initialize_static_data): ...here.
6303
6304 2019-06-25  Tom Tromey  <tom@tromey.com>
6305
6306         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
6307         (tui_display_registers_from, tui_check_register_values): Update.
6308         (tui_display_register): Remove win_info parameter; update.
6309         (tui_get_register): Change type of parameters.
6310         * tui/tui-data.h (struct tui_data_element): Remove.
6311         (union tui_which_element) <data>: Remove.
6312         <data_window>: Change type.
6313         (struct tui_data_item_window): New.
6314         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
6315         case.  Add assert.
6316         (~tui_data_item_window): New destructor.
6317         (free_content_elements): Remove DATA_ITEM_WIN case.
6318
6319 2019-06-25  Tom Tromey  <tom@tromey.com>
6320
6321         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
6322         Remove.
6323
6324 2019-06-25  Tom Tromey  <tom@tromey.com>
6325
6326         * tui/tui-data.h (struct tui_command_element): Remove.
6327         (union tui_which_element) <command>: Remove.
6328         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
6329         assert.
6330         (free_content_elements): Remove CMD_WIN case.
6331
6332 2019-06-25  Tom Tromey  <tom@tromey.com>
6333
6334         * tui/tui-layout.c (tui_set_layout): Update.
6335         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
6336         * tui/tui-data.c (layout_def): Update.
6337
6338 2019-06-25  Tom Tromey  <tom@tromey.com>
6339
6340         * tui/tui-wingeneral.c (tui_refresh_all): Update.
6341         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
6342         (tui_source_window_base::set_new_height): Update.
6343         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
6344         Update.
6345         (tui_set_locator_fullname, tui_set_locator_info)
6346         (tui_show_frame_info): Update.
6347         * tui/tui-source.c (tui_set_source_content)
6348         (tui_source_is_displayed): Update.
6349         * tui/tui-layout.c (show_source_disasm_command, show_data)
6350         (show_source_or_disasm_and_command): Update.
6351         * tui/tui-disasm.c (tui_set_disassem_content)
6352         (tui_get_begin_asm_address): Update.
6353         * tui/tui-data.h (struct tui_locator_element): Remove.
6354         (union tui_which_element) <locator>: Remove.
6355         (struct tui_locator_window): New.
6356         (tui_locator_win_info_ptr): Change return type.
6357         * tui/tui-data.c (_locator): Change type.
6358         (tui_locator_win_info_ptr): Change return type.
6359         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
6360         (tui_alloc_content): Add assert.
6361
6362 2019-06-25  Tom Tromey  <tom@tromey.com>
6363
6364         * tui/tui-winsource.c
6365         (tui_exec_info_window::maybe_allocate_content): New method.
6366         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
6367         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
6368         (make_source_or_disasm_window): Add cast.
6369         * tui/tui-data.h (union tui_which_element) <simple_string>:
6370         Remove.
6371         (struct tui_source_info): New.
6372         (struct tui_source_window_base) <execution_info>: Change type.
6373         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
6374         case, and add assert.
6375         (tui_alloc_content): Add assert.
6376
6377 2019-06-25  Tom Tromey  <tom@tromey.com>
6378
6379         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
6380         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
6381         * tui/tui-data.c (tui_alloc_win_info): Remove.
6382
6383 2019-06-25  Tom Tromey  <tom@tromey.com>
6384
6385         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
6386         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
6387         can_highlight.
6388
6389 2019-06-25  Tom Tromey  <tom@tromey.com>
6390
6391         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
6392         make_visible_with_new_height method.
6393         (tui_win_info::make_visible_with_new_height): New method.
6394         (tui_source_window_base::do_make_visible_with_new_height)
6395         (tui_data_window::do_make_visible_with_new_height)
6396         (tui_cmd_window::do_make_visible_with_new_height): New methods.
6397         (make_visible_with_new_height): Remove.
6398         (tui_resize_all, tui_adjust_win_heights): Use
6399         make_visible_with_new_height method.
6400         * tui/tui-data.h (struct tui_win_info)
6401         <do_make_visible_with_new_height, make_visible_with_new_height>:
6402         New methods.
6403         (struct tui_source_window_base, struct tui_data_window)
6404         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
6405         methods.
6406
6407 2019-06-25  Tom Tromey  <tom@tromey.com>
6408
6409         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
6410         method.
6411         (update_tab_width): Call update_tab_width method.
6412         * tui/tui-data.h (struct tui_win_info)
6413         (struct tui_source_window_base) <update_tab_width>: New methods.
6414
6415 2019-06-25  Tom Tromey  <tom@tromey.com>
6416
6417         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
6418         parameter.
6419         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
6420         parameter.
6421         (tui_gen_win_info::make_visible): Update.
6422         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
6423         parameter.
6424         * tui/tui-data.h (enum tui_box): New enum.
6425         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
6426
6427 2019-06-25  Tom Tromey  <tom@tromey.com>
6428
6429         * tui/tui-layout.c (make_source_or_disasm_window): Always use
6430         init_and_make_win for EXEC_INFO_WIN.
6431         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
6432         longer inline.
6433         (struct tui_win_info) <~tui_win_info>: Inline.
6434         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
6435         Don't declare.
6436         * tui/tui-data.c (source_win, disasm_win): Remove globals.
6437         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
6438         Remove.
6439         (tui_initialize_static_data): Update.
6440         (~tui_gen_win_info): Handle more cleanup here.
6441         (~tui_source_window_base): Delete "execution_info".
6442         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
6443
6444 2019-06-25  Tom Tromey  <tom@tromey.com>
6445
6446         * tui/tui-layout.c (make_command_window): Don't set
6447         can_highlight.
6448         (show_source_disasm_command): Call the reset method.
6449         (show_data): Don't set can_highlight.  Call the reset method.
6450         (tui_gen_win_info::reset): Rename from init_gen_win_info
6451         (init_and_make_win): Simplify.  Return tui_gen_win_info.
6452         (show_source_or_disasm_and_command): Call the reset method.
6453         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
6454         (struct tui_cmd_window): Set can_highlight.
6455
6456 2019-06-25  Tom Tromey  <tom@tromey.com>
6457
6458         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
6459         from make_visible.
6460         (tui_make_visible, tui_make_invisible): Rewrite.
6461         (tui_win_info::make_visible): Remove.
6462         (tui_source_window_base::make_visible): Update.
6463         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
6464         method.  Moved from...
6465         (struct tui_win_info) <make_visible>: ...here.
6466
6467 2019-06-25  Tom Tromey  <tom@tromey.com>
6468
6469         * tui/tui-winsource.c
6470         (tui_source_window_base::do_scroll_horizontal): Remove direction
6471         parameter.
6472         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
6473         direction parameter.
6474         * tui/tui-win.c (tui_win_info::forward_scroll)
6475         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
6476         (tui_win_info::right_scroll): Update.
6477         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
6478         direction parameter.
6479         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
6480         direction parameter.
6481         * tui/tui-data.h (enum tui_scroll_direction): Remove.
6482         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
6483         Remove direction parameter.
6484         (struct tui_source_window_base, struct tui_source_window)
6485         (struct tui_disasm_window, struct tui_data_window)
6486         (struct tui_cmd_window): Update.
6487
6488 2019-06-25  Tom Tromey  <tom@tromey.com>
6489
6490         * tui/tui-winsource.h (tui_set_exec_info_content)
6491         (tui_show_exec_info_content, tui_erase_exec_info_content)
6492         (tui_clear_exec_info_content, tui_update_exec_info): Change
6493         argument to tui_source_window_base.
6494         * tui/tui-winsource.c (tui_set_exec_info_content)
6495         (tui_show_exec_info_content, tui_erase_exec_info_content)
6496         (tui_clear_exec_info_content, tui_update_exec_info): Change
6497         argument to tui_source_window_base.
6498
6499 2019-06-25  Tom Tromey  <tom@tromey.com>
6500
6501         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
6502         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
6503
6504 2019-06-25  Tom Tromey  <tom@tromey.com>
6505
6506         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
6507         check.
6508
6509 2019-06-25  Tom Tromey  <tom@tromey.com>
6510
6511         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
6512         type to void.
6513         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
6514         type to void.
6515         * tui/tui-source.c (tui_set_source_content): Update.
6516         * tui/tui-disasm.c (tui_set_disassem_content): Update.
6517
6518 2019-06-25  Tom Tromey  <tom@tromey.com>
6519
6520         * tui/tui-win.c (window_name_completer, tui_set_focus)
6521         (tui_all_windows_info): Use name method.
6522         * tui/tui-data.h (struct tui_gen_win_info)
6523         (struct tui_source_window, struct tui_disasm_window)
6524         (struct tui_data_window, struct tui_cmd_window) <name>: New
6525         method.
6526         (tui_win_name): Don't declare.
6527         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
6528         (tui_win_name): Remove.
6529
6530 2019-06-25  Tom Tromey  <tom@tromey.com>
6531
6532         * tui/tui-winsource.h (tui_update_source_window)
6533         (tui_update_source_window_as_is): Change parameter type.
6534         * tui/tui-winsource.c (tui_update_source_window): Change win_info
6535         to be a tui_source_window_base.
6536         (tui_update_source_window_as_is): Likewise.
6537         * tui/tui-win.c (make_visible_with_new_height): Update.
6538
6539 2019-06-25  Tom Tromey  <tom@tromey.com>
6540
6541         * tui/tui-winsource.c (tui_erase_source_content)
6542         (tui_show_source_content, tui_show_exec_info_content)
6543         (tui_erase_exec_info_content): Use refresh_window method.
6544         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
6545         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
6546         from tui_refresh_win.
6547         (tui_data_window::refresh_window): New method.
6548         (tui_win_info::refresh, tui_source_window_base::refresh)
6549         (tui_refresh_all): Use refresh_window method.
6550         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
6551         method.
6552         * tui/tui-regs.c (tui_display_register): Call refresh_window
6553         method.
6554         * tui/tui-layout.c (show_source_disasm_command)
6555         (show_source_or_disasm_and_command): Call refresh_window method.
6556         * tui/tui-data.h (struct tui_gen_win_info)
6557         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
6558         New method.
6559
6560 2019-06-25  Tom Tromey  <tom@tromey.com>
6561
6562         * tui/tui.c (tui_rl_other_window, tui_enable)
6563         (tui_is_window_visible, tui_get_command_dimension): Update.
6564         * tui/tui-winsource.c (tui_update_source_window_as_is)
6565         (tui_clear_source_content, tui_erase_source_content)
6566         (tui_show_source_line, tui_source_window_base::refill)
6567         (tui_source_window_base::do_scroll_horizontal)
6568         (tui_source_window_base::set_is_exec_point_at)
6569         (tui_update_breakpoint_info, tui_set_exec_info_content)
6570         (tui_alloc_source_buffer, tui_line_is_displayed)
6571         (tui_addr_is_displayed): Update.
6572         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
6573         (tui_check_and_display_highlight_if_needed)
6574         (tui_win_info::make_visible, tui_win_info::refresh)
6575         (tui_refresh_all): Update.
6576         * tui/tui-windata.c (tui_first_data_item_displayed)
6577         (tui_delete_data_content_windows, tui_erase_data_content)
6578         (tui_display_all_data, tui_data_window::refresh_all)
6579         (tui_check_data_values): Update.
6580         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
6581         (tui_set_win_focus_to, tui_win_info::forward_scroll)
6582         (tui_win_info::backward_scroll, tui_refresh_all_win)
6583         (tui_resize_all, tui_set_focus, tui_all_windows_info)
6584         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
6585         (tui_source_window_base::set_new_height)
6586         (tui_data_window::set_new_height)
6587         (make_invisible_and_set_new_height)
6588         (make_visible_with_new_height, new_height_ok)
6589         (parse_scrolling_args): Update.
6590         * tui/tui-stack.c (tui_show_frame_info): Update.
6591         * tui/tui-source.c (tui_set_source_content)
6592         (tui_set_source_content_nil, tui_source_is_displayed)
6593         (tui_source_window::do_scroll_vertical): Update.
6594         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
6595         (tui_display_registers_from, tui_display_reg_element_at_line)
6596         (tui_check_register_values, tui_reg_command): Update.
6597         * tui/tui-layout.c (tui_default_win_height)
6598         (show_source_disasm_command, show_data, init_and_make_win)
6599         (show_source_or_disasm_and_command): Update.
6600         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
6601         (tui_redisplay_readline, tui_mld_flush)
6602         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
6603         (tui_getc): Update.
6604         * tui/tui-disasm.c (tui_set_disassem_content)
6605         (tui_disasm_window::do_scroll_vertical): Update.
6606         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
6607         Now virtual.
6608         (struct tui_win_info): Derive from tui_gen_win_info.
6609         <~tui_win_info>: Mark as override.
6610         <generic>: Remove member.
6611         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
6612         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
6613         (~tui_data_window, ~tui_win_info)
6614         (tui_free_all_source_wins_content): Update.
6615         * tui/tui-command.c (tui_refresh_cmd_win): Update.
6616
6617 2019-06-25  Tom Tromey  <tom@tromey.com>
6618
6619         * tui/tui-layout.c (init_and_make_win): Use new.
6620         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
6621         destructor, initializers.
6622         (tui_alloc_generic_win_info): Don't declare.
6623         * tui/tui-data.c (_locator): Add argument to constructor.
6624         (source_win, disasm_win): New globals.
6625         (exec_info): Remove.
6626         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
6627         Update.
6628         (tui_alloc_generic_win_info): Remove.
6629         (init_content_element): Use new.
6630         (tui_win_info::tui_win_info): Update.
6631         (free_content_elements) <case DATA_WIN>: Use delete.
6632
6633 2019-06-25  Tom Tromey  <tom@tromey.com>
6634
6635         * tui/tui-wingeneral.c (tui_refresh_win): Update.
6636         * tui/tui-windata.c (tui_first_data_item_displayed)
6637         (tui_delete_data_content_windows): Update.
6638         * tui/tui-win.c (tui_data_window::set_new_height): Update.
6639         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
6640         (tui_display_registers_from, tui_check_register_values): Update.
6641         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
6642         pointer.
6643         * tui/tui-data.c (init_content_element): Update.  Allocate the new
6644         window.
6645         (tui_free_data_content): Update.
6646         (free_content_elements) <case DATA_WIN>: Free the window.
6647
6648 2019-06-25  Tom Tromey  <tom@tromey.com>
6649
6650         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
6651         Update.
6652         * tui/tui-layout.c (make_command_window)
6653         (show_source_disasm_command, show_data, init_and_make_win)
6654         (show_source_or_disasm_and_command): Update.
6655         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
6656         method.
6657         <can_highight, is_highlighted>: Now bool.
6658         (tui_set_win_highlight): Don't declare.
6659         * tui/tui-data.c (tui_set_win_highlight): Remove.
6660
6661 2019-06-25  Tom Tromey  <tom@tromey.com>
6662
6663         * tui/tui-wingeneral.c (make_visible): Remove check of window
6664         type.
6665
6666 2019-06-25  Tom Tromey  <tom@tromey.com>
6667
6668         * tui/tui-win.c (tui_win_info::max_height)
6669         (tui_cmd_window::max_height): New methods.
6670         (new_height_ok): Call max_height.
6671         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
6672         <max_height>: New method.
6673
6674 2019-06-25  Tom Tromey  <tom@tromey.com>
6675
6676         * tui/tui-win.c (tui_source_window_base::set_new_height)
6677         (tui_data_window::set_new_height): New methods.
6678         (make_invisible_and_set_new_height): Call set_new_height method.
6679         * tui/tui-data.h (struct tui_win_info)
6680         (struct tui_source_window_base, struct tui_data_window)
6681         <set_new_height>: New method.
6682
6683 2019-06-25  Tom Tromey  <tom@tromey.com>
6684
6685         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
6686         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
6687         tui_refresh_data_win.
6688         * tui/tui-win.c (tui_source_window_base::refresh_all): New
6689         method.
6690         (tui_refresh_all_win): Call the refresh_all method.
6691         (tui_set_focus): Likewise.
6692         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
6693         (struct tui_source_window_base, struct tui_data_window) <refresh>:
6694         Likewise.
6695
6696 2019-06-25  Tom Tromey  <tom@tromey.com>
6697
6698         * tui/tui-winsource.h (tui_refill_source_window)
6699         (tui_set_is_exec_point_at): Don't declare.
6700         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
6701         (tui_source_window_base::refill): Rename from
6702         tui_refill_source_window.
6703         (tui_source_window_base::do_scroll_horizontal): Update.
6704         (tui_source_window_base::set_is_exec_point_at): Rename from
6705         tui_set_is_exec_point_at.
6706         (tui_update_all_breakpoint_info): Update.
6707         * tui/tui-stack.c (tui_show_frame_info): Update.
6708         * tui/tui-layout.c (show_data): Add cast.
6709         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
6710         * tui/tui-data.h (struct tui_source_window_base) <refill,
6711         set_is_exec_point_at>: New methods.
6712         (tui_source_windows, tui_add_to_source_windows): Update types.
6713         (tui_add_to_source_windows): Remove redundant declaration.
6714         * tui/tui-data.c (source_windows): Store tui_source_window_base.
6715         (tui_source_windows): Change return type.
6716         (tui_clear_source_windows_detail): Update.
6717         (tui_add_to_source_windows): Change type of parameter.
6718         (tui_free_all_source_wins_content): Update.
6719
6720 2019-06-25  Tom Tromey  <tom@tromey.com>
6721
6722         * tui/tui-wingeneral.c (tui_win_info::refresh)
6723         (tui_source_window_base::refresh): New methods.
6724         (tui_refresh_all): Call the refresh method.
6725         * tui/tui-data.h (struct tui_win_info)
6726         (struct tui_source_window_base) <refresh>: New method.
6727
6728 2019-06-25  Tom Tromey  <tom@tromey.com>
6729
6730         * tui/tui.h (tui_is_window_visible): Return bool.
6731         * tui/tui.c (tui_is_window_visible): Return bool.
6732         * tui/tui-wingeneral.c (tui_make_window, make_visible)
6733         (tui_make_visible, tui_make_invisible)
6734         (tui_win_info::make_visible)
6735         (tui_source_window_base::make_visible, make_all_visible)
6736         (tui_make_all_visible, tui_make_all_invisible): Update.
6737         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
6738         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
6739         bool.
6740         (struct tui_win_info, struct tui_source_window_base)
6741         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
6742         * tui/tui-data.c (tui_init_generic_part): Update.
6743
6744 2019-06-25  Tom Tromey  <tom@tromey.com>
6745
6746         * tui/tui-wingeneral.c (tui_win_info::make_visible)
6747         (tui_source_window_base::make_visible): New methods.
6748         (make_all_visible): Make method call.
6749         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
6750         (struct tui_source_window_base, struct tui_cmd_window): Override
6751         make_visible.
6752         (tui_win_is_source_type): Don't declare.
6753         * tui/tui-data.c (tui_win_is_source_type): Remove.
6754
6755 2019-06-25  Tom Tromey  <tom@tromey.com>
6756
6757         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
6758         NULL check.
6759
6760 2019-06-25  Tom Tromey  <tom@tromey.com>
6761
6762         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
6763         Inline constructor.  Add initializers for members.
6764         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
6765         constructors; now inline in class.
6766
6767 2019-06-25  Tom Tromey  <tom@tromey.com>
6768
6769         * tui/tui-regs.c (tui_show_registers): Update.
6770         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
6771         bool.
6772         * tui/tui-data.c (tui_data_window::clear_detail)
6773         (tui_data_window): Update.
6774
6775 2019-06-25  Tom Tromey  <tom@tromey.com>
6776
6777         * tui/tui-windata.c (tui_display_all_data)
6778         (tui_display_data_from_line, tui_display_data_from)
6779         (tui_check_data_values, tui_data_window::do_scroll_vertical):
6780         Update.
6781         * tui/tui-regs.c (tui_last_regs_line_no)
6782         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
6783         (tui_show_registers, tui_show_register_group)
6784         (tui_display_registers_from, tui_display_reg_element_at_line)
6785         (tui_display_registers_from_line, tui_check_register_values)
6786         (tui_reg_next, tui_reg_prev): Update.
6787         * tui/tui-layout.c (tui_set_layout, show_data): Update.
6788         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
6789         tui_data_window.
6790         (struct tui_win_info) <detail>: Remove.  Add new fields from
6791         tui_data_info.
6792         (TUI_DATA_WIN): Add cast.
6793         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
6794         (~tui_data_window): Simplify.
6795
6796 2019-06-25  Tom Tromey  <tom@tromey.com>
6797
6798         * tui/tui-layout.c (show_source_disasm_command)
6799         (show_source_or_disasm_and_command): Update.
6800         * tui/tui-io.c (update_cmdwin_start_line)
6801         (tui_redisplay_readline): Update.
6802         * tui/tui-data.h (struct tui_command_info): Remove.
6803         (struct tui_win_info) <detail>: Remove command_info member.
6804         (struct tui_data_window) <start_line>: New member, from
6805         tui_command_info.
6806         (TUI_CMD_WIN): Add casts.
6807
6808 2019-06-25  Tom Tromey  <tom@tromey.com>
6809
6810         * tui/tui-winsource.c (tui_update_source_window)
6811         (tui_refill_source_window)
6812         (tui_source_window_base::do_scroll_horizontal)
6813         (tui_update_breakpoint_info, tui_set_exec_info_content)
6814         (tui_show_exec_info_content, tui_erase_exec_info_content)
6815         (tui_clear_exec_info_content): Update.
6816         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
6817         Update.
6818         * tui/tui-win.c (make_invisible_and_set_new_height)
6819         (make_visible_with_new_height): Update.
6820         * tui/tui-source.c (tui_set_source_content)
6821         (tui_show_symtab_source): Update.
6822         * tui/tui-layout.c (extract_display_start_addr)
6823         (show_source_disasm_command, show_data)
6824         (make_source_or_disasm_window)
6825         (show_source_or_disasm_and_command): Update.
6826         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
6827         (tui_disasm_window::do_scroll_vertical): Remove shadowing
6828         "gdbarch".
6829         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
6830         to tui_source_window_base.
6831         (struct tui_win_info) <detail>: Remove source_info member.
6832         (struct tui_source_window_base) <has_locator>: Inline.
6833         Move contents from tui_source_info; rename has_locator member to
6834         m_has_locator.
6835         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
6836         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
6837         header file.
6838         (tui_source_window_base::clear_detail, ~tui_source_window_base):
6839         Simplify.
6840         (tui_free_all_source_wins_content): Cast to
6841         tui_source_window_base.
6842
6843 2019-06-25  Tom Tromey  <tom@tromey.com>
6844
6845         * tui/tui-win.c (make_invisible_and_set_new_height)
6846         (make_visible_with_new_height): Call has_locator method.
6847         * tui/tui-layout.c (show_source_disasm_command, show_data)
6848         (show_source_or_disasm_and_command): Update for bool change.
6849         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
6850         (tui_win_info) <has_locator>: New method.
6851         (struct tui_source_window_base) <has_locator>: New method.
6852         (tui_win_has_locator): Don't declare.
6853         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
6854         from tui_win_has_locator.
6855         (tui_source_window_base): Use false, not FALSE.
6856
6857 2019-06-25  Tom Tromey  <tom@tromey.com>
6858
6859         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
6860         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
6861         clear_detail method directly.
6862         (tui_clear_win_detail): Remove.
6863
6864 2019-06-25  Tom Tromey  <tom@tromey.com>
6865
6866         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
6867         "this", not TUI_DISASM_WIN.
6868
6869 2019-06-25  Tom Tromey  <tom@tromey.com>
6870
6871         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
6872         declare.
6873         * tui/tui-winsource.c
6874         (tui_source_window_base::do_scroll_horizontal): Rename from
6875         tui_horizontal_source_scroll.
6876         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
6877         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
6878         from tui_vertical_data_scroll.
6879         * tui/tui-win.h (tui_scroll): Don't declare.
6880         * tui/tui-win.c (tui_win_info::forward_scroll)
6881         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
6882         (tui_win_info::right_scroll): Rename and update.
6883         (tui_scroll_forward_command, tui_scroll_backward_command)
6884         (tui_scroll_left_command, tui_scroll_right_command): Update.
6885         (tui_scroll): Remove.
6886         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
6887         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
6888         from tui_vertical_source_scroll.
6889         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
6890         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
6891         from tui_vertical_disassem_scroll.
6892         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
6893         do_scroll_horizontal>: New methods.
6894         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
6895         Likewise.
6896         (struct tui_source_window_base): Add do_scroll_horizontal.
6897         (struct tui_source_window, struct tui_disasm_window): Add
6898         do_scroll_vertical.
6899         (struct tui_data_window, struct tui_cmd_window): Add
6900         do_scroll_horizontal and do_scroll_vertical.
6901         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
6902
6903 2019-06-25  Tom Tromey  <tom@tromey.com>
6904
6905         * tui/tui-data.h (struct tui_source_window_base): New struct.
6906         (struct tui_source_window): Derive from tui_source_window_base.
6907         (struct tui_disasm_window): New struct.
6908         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
6909         from tui_source_window::clear_detail.
6910         (tui_source_window_base): Rename from tui_source_window.
6911         (~tui_source_window_base): Rename from ~tui_source_window.
6912         (tui_alloc_win_info): Create a tui_disasm_window.
6913
6914 2019-06-25  Tom Tromey  <tom@tromey.com>
6915
6916         * tui/tui-data.h (struct tui_source_window)
6917         (struct tui_data_window): Declare destructors.
6918         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
6919         destructors.
6920         (tui_win_info): Simplify.
6921
6922 2019-06-25  Tom Tromey  <tom@tromey.com>
6923
6924         * tui/tui-winsource.c (tui_display_main)
6925         (tui_update_source_windows_with_addr)
6926         (tui_update_all_breakpoint_info): Update.
6927         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
6928         (new_height_ok, parse_scrolling_args): Update.
6929         * tui/tui-stack.c (tui_show_frame_info): Update.
6930         * tui/tui-data.h (struct tui_list): Remove.
6931         (tui_source_windows): Return a reference to a std::vector.
6932         * tui/tui-data.c (source_windows): Now a std::vector.
6933         (tui_source_windows): Change return type.
6934         (tui_clear_source_windows): Rewrite.
6935         (tui_clear_source_windows_detail, tui_add_to_source_windows)
6936         (tui_free_all_source_wins_content): Rewrite.
6937
6938 2019-06-25  Tom Tromey  <tom@tromey.com>
6939
6940         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
6941         (struct tui_data_window, struct tui_cmd_window): Declare
6942         clear_detail method.
6943         * tui/tui-data.c (tui_source_window::clear_detail)
6944         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
6945         methods.
6946         (tui_clear_win_detail): Simplify.
6947
6948 2019-06-25  Tom Tromey  <tom@tromey.com>
6949
6950         * tui/tui-layout.c (make_source_window, make_disasm_window)
6951         (make_source_or_disasm_window): Remove win_info_ptr parameter.
6952         Return the new window.
6953         (show_source_disasm_command, show_data)
6954         (show_source_or_disasm_and_command): Update.
6955
6956 2019-06-25  Tom Tromey  <tom@tromey.com>
6957
6958         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
6959         parameter.  Return the new window.
6960         (show_source_disasm_command): Update and remove NULL check.
6961         (show_source_or_disasm_and_command): Update.
6962
6963 2019-06-25  Tom Tromey  <tom@tromey.com>
6964
6965         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
6966
6967 2019-06-25  Tom Tromey  <tom@tromey.com>
6968
6969         * tui/tui-data.h (struct tui_win_info): Make constructor
6970         protected.  Make destructor virtual.  Add initializers.
6971         (tui_source_window, tui_data_window, tui_cmd_window): New
6972         classes.
6973         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
6974         constructor.  Add "type" parameter.
6975         (tui_source_window, tui_data_window, tui_cmd_window): New
6976         constructors.
6977         (tui_alloc_win_info): Instantiate the appropriate subclass.
6978
6979 2019-06-25  Tom Tromey  <tom@tromey.com>
6980
6981         * tui/tui-win.c (tui_resize_all): Use delete.
6982         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
6983         destructor.
6984         (tui_free_window): Don't declare.
6985         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
6986         Update.
6987
6988 2019-06-25  Tom Tromey  <tom@tromey.com>
6989
6990         * tui/tui-data.h (struct tui_win_info): Add constructor.
6991         * tui/tui-data.c (tui_alloc_win_info): Use new.
6992         (tui_free_window): Use delete.
6993
6994 2019-06-22  Tom Tromey  <tom@tromey.com>
6995
6996         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
6997         declare.
6998         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
6999
7000 2019-06-22  Tom Tromey  <tom@tromey.com>
7001
7002         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
7003         declare.
7004         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
7005
7006 2019-06-22  Tom de Vries  <tdevries@suse.de>
7007
7008         * dwarf2read.c (create_addrmap_from_aranges)
7009         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
7010         instead of '%zu'.
7011
7012 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
7013
7014         * dwarf2read.h (dwarf2_section_info_def): Remove.
7015         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
7016         * dwarf2read.c (struct dwo_sections) <types>: Change type to
7017         std::vector<dwarf2_section_info>.
7018         (struct dwo_file) <~dwo_file>: Remove.
7019         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
7020         types field.
7021         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
7022         (dwarf2_read_debug_names): Likewise.
7023         (create_debug_types_hash_table): Change parameter type to
7024         array_view, adjust code accordingly.
7025         (dwarf2_locate_dwo_sections): Adjust to std::vector.
7026         (partial_die_info::fixup): Likewise.
7027         (determine_prefix): Likewise.
7028         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
7029
7030 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
7031
7032         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
7033         gdb_bfd_ref_ptr.
7034         <~dwo_file>: Remove call to gdb_bfd_unref.
7035         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
7036         gdb_bfd_ref_ptr::get.
7037
7038 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
7039
7040         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
7041         type to htab_up.
7042         * dwarf2read.c (struct dwo_file): Initialize fields.
7043         <~dwo_file>: New.
7044         (free_dwo_file): Remove, move content to ~dwo_file.
7045         (struct dwo_file_deleter): Remove.
7046         (dwo_file_up>: Remove custom deleter.
7047         (free_dwo_files): Remove.
7048         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
7049         dwo_files.
7050         (process_skeletonless_type_units): Call unique_ptr::get.
7051         (allocate_dwo_file_hash_table): Add deleter to created hash
7052         table.  Change return type to htab_up.
7053         (lookup_dwo_file_slot): Don't memset dwo_file, call
7054         unique_ptr::get.
7055         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
7056         (create_dwo_unit_in_dwp_v2): Likewise.
7057         (open_and_init_dwo_file): Likewise.
7058         (free_dwo_file_from_slot): Remove.
7059
7060 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
7061
7062         * dwarf2read.h (struct dwarf2_section_info) <readin,
7063         is_virtual>: Change type to bool.
7064         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
7065         true instead of 1.
7066
7067 2019-06-19  Tom Tromey  <tom@tromey.com>
7068
7069         * tui/tui-data.h (tui_init_content_element): Don't declare.
7070
7071 2019-06-19  Tom Tromey  <tom@tromey.com>
7072
7073         * tui/tui-data.h (tui_init_win_info): Don't declare.
7074
7075 2019-06-19  Tom de Vries  <tdevries@suse.de>
7076
7077         * dwarf2read.h (abstract_to_concrete): Change type to
7078         std::unordered_map<sect_offset, std::vector<sect_offset>,
7079         gdb::hash_enum<sect_offset>>.
7080
7081 2019-06-19  Tom Tromey  <tromey@adacore.com>
7082
7083         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
7084         EVAL_AVOID_SIDE_EFFECTS specially.
7085
7086 2019-06-19  Tom Tromey  <tromey@adacore.com>
7087
7088         * source-cache.c (highlighter): New global.
7089         (source_cache::get_source_lines): Create a highlighter on demand.
7090
7091 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
7092
7093         * defs.h (deprecated_interactive_hook): Delete declaration.
7094         * interps.c (clear_interpreter_hooks): Remove use of
7095         deprecated_interactive_hook.
7096         * top.c (deprecated_interactive_hook): Delete definition.
7097         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
7098
7099 2019-06-18  Tom de Vries  <tdevries@suse.de>
7100
7101         PR gdb/24515
7102         * dwarf2read.h (abstract_to_concrete): Change type from
7103         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
7104         std::unordered_map<sect_offset, std::vector<sect_offset>>.
7105         * dwarf2read.c (read_variable): Update.
7106         (dwarf2_fetch_die_loc_sect_off): Update.
7107
7108 2019-06-17  Tom de Vries  <tdevries@suse.de>
7109
7110         PR gdb/24617
7111         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
7112         accessing parent[parent_len - 1].
7113
7114 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
7115
7116         PR gdb/24364
7117         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
7118         call dtrace_process_dof with NULL dof.
7119
7120 2019-06-16  Tom de Vries  <tdevries@suse.de>
7121
7122         PR gdb/24445
7123         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
7124
7125 2019-06-16  Tom Tromey  <tom@tromey.com>
7126
7127         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
7128         (make_all_visible): Use address of member.
7129
7130 2019-06-16  Tom Tromey  <tom@tromey.com>
7131
7132         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
7133         (tui_free_window, free_content, free_content_elements): Remove
7134         unnecessary cast.
7135         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
7136         cast.
7137         * tui/tui-regs.c (tui_show_register_group)
7138         (tui_display_registers_from, tui_display_reg_element_at_line):
7139         Remove unnecessary cast.
7140
7141 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
7142
7143         * linux-nat.c (normal_mask): Delete.
7144         (_initialize_linux_nat): Don't initialise normal_mask.
7145
7146 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
7147
7148         PR gdb/24445
7149         * dwarf-index-write.h (write_psymtabs_to_index): Add
7150         dwz_basename parameter.
7151         * dwarf-index-write.c (write_gdbindex): Move file writing to
7152         write_gdbindex_1.  Change return type void.
7153         (assert_file_size): Move up, remove filename parameter.
7154         (write_gdbindex_1): New function.
7155         (write_debug_names): Change return type to void, call
7156         assert_file_size.
7157         (struct index_wip_file): New struct.
7158         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
7159         file logic to index_wip_file.  Write index for dwz file if
7160         needed.
7161         (save_gdb_index_command): Pass basename of dwz file, if present.
7162         * dwarf-index-cache.c (index_cache::store): Obtain and pass
7163         build-id of dwz file, if present.
7164         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
7165         (dwarf2_get_dwz_file): Likewise.
7166         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
7167         (dwarf2_get_dwz_file): Likewise.
7168
7169 2019-06-16  Tom Tromey  <tom@tromey.com>
7170
7171         * coffread.c (process_coff_symbol): Use xstrdup.
7172         * value.c (create_internalvar): Use xstrdup.
7173
7174 2019-06-16  Tom Tromey  <tom@tromey.com>
7175
7176         * valops.c (value_cast, value_slice): Remove unnecessary cast.
7177         * breakpoint.c (stopin_command, stopat_command)
7178         (until_break_command, decode_location_default): Remove unnecessary
7179         cast.
7180         * utils.c (subset_compare): Remove unnecessary cast.
7181         * ada-lang.c (ada_update_initial_language): Remove unnecessary
7182         cast.
7183         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
7184         cast.
7185         * infcmd.c (path_command): Remove unnecessary cast.
7186         * coffread.c (decode_type): Remove unnecessary cast.
7187         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
7188         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
7189         * tui/tui-stack.c (tui_show_locator_content)
7190         (tui_show_frame_info): Remove unnecessary cast.
7191         * tui/tui-win.c (tui_scroll_forward_command)
7192         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
7193         (parse_scrolling_args): Remove unnecessary cast.
7194         * tui/tui-data.c (init_win_info, tui_del_window)
7195         (tui_free_window, tui_del_data_windows, tui_free_data_content)
7196         (free_content_elements): Remove unnecessary cast.
7197         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
7198         unnecessary cast.
7199         * tui/tui-source.c (tui_set_source_content)
7200         (tui_vertical_source_scroll): Remove unnecessary cast.
7201         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
7202         cast.
7203         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
7204         * tui/tui-regs.c (tui_display_registers_from)
7205         (tui_display_register): Remove unnecessary cast.
7206         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
7207         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
7208         (make_visible): Remove unnecessary cast.
7209         * tui/tui-winsource.c (tui_erase_source_content)
7210         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
7211         unnecessary cast.
7212         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
7213         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
7214         * stabsread.c (read_type, read_array_type, read_range_type):
7215         Remove unnecessary cast.
7216         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
7217         (parse_symbol, parse_type, upgrade_type, parse_external)
7218         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
7219         unnecessary cast.
7220         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
7221
7222 2019-06-16  Tom Tromey  <tom@tromey.com>
7223
7224         * tui/tui-data.c (tui_alloc_generic_win_info)
7225         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
7226         checks.
7227
7228 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
7229             Andrew Burgess  <andrew.burgess@embecosm.com>
7230
7231         * f-typeprint.c (f_print_type): Don't return early for not
7232         associated or not allocated types.
7233         (f_type_print_varspec_suffix): Add print_rank parameter and print
7234         ranks of array types in case they dangling.
7235         (f_type_print_base): Add print_rank parameter.
7236
7237 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
7238
7239         * NEWS: Mention new MI commands.
7240         * break-catch-throw.c (enum exception_event_kind): Move to
7241         breakpoint.h.
7242         (print_mention_exception_catchpoint): Output text as a single
7243         message.
7244         (catch_exception_command_1): Rename to...
7245         (catch_exception_event): ...this, make non-static, update header
7246         command, and change some parameter types.
7247         (catch_catch_command): Update for changes to
7248         catch_exception_command_1.
7249         (catch_throw_command): Likewise.
7250         (catch_rethrow_command): Likewise.
7251         * breakpoint.c (enum exception_event_kind): Delete.
7252         * breakpoint.h (enum exception_event_kind): Moved here from
7253         break-catch-throw.c.
7254         (catch_exception_event): Declare.
7255         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
7256         (mi_cmd_catch_throw): New function.
7257         (mi_cmd_catch_rethrow): New function.
7258         (mi_cmd_catch_catch): New function.
7259         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
7260         'catch-catch' entries.
7261         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
7262         (mi_cmd_catch_rethrow): Declare.
7263         (mi_cmd_catch_catch): Declare.
7264
7265 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
7266
7267         * annotate.c (annotate_source_line): Change return type to void,
7268         update implementation to match.
7269         * annotate.h (annotate_source_line): Change return type to void,
7270         update header comment.
7271         * stack.c (print_frame_info): Don't change what frame information
7272         is printed based on whether annotations are on or not.
7273
7274 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
7275
7276         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
7277         (annotate_source): Make static.
7278         (annotate_source_line): Moved from source.c and renamed from
7279         identify_source_line.  Update the return type.
7280         * annotate.h (annotate_source): Delete declaration.
7281         (annotate_source_line): Declaration moved from source.h, and
7282         renamed from identify_source_line.  Return type updated.
7283         * source.c (identify_source_line): Moved to annotate.c and renamed
7284         to annotate_source_line.
7285         (info_line_command): Remove check of annotation_level.
7286         * source.h (identify_source_line): Move declaration to annotate.h
7287         and rename to annotate_source_line.
7288         * stack.c: Add 'annotate.h' include.
7289         (print_frame_info): Remove check of annotation_level before
7290         calling annotate_source_line.
7291
7292 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
7293
7294         * source-cache.c (source_cache::get_plain_source_lines): Use
7295         open_source_file_with_line_charpos instead of just
7296         open_source_file, remove call to find_source_lines.
7297         (source_cache::get_source_lines): Likewise.
7298         * source.c (find_source_lines): Make static.
7299         (get_filename_and_charpos): Renamed into...
7300         (open_source_file_with_line_charpos): ..this along with changes to
7301         return a scoped_fd, and some other minor clean ups.
7302         (identify_source_line): Use open_source_file_with_line_charpos.
7303         (search_command_helper): Use open_source_file_with_line_charpos
7304         instead of just open_source_file, remove call to
7305         find_source_lines.
7306         * source.h (open_source_file_with_line_charpos): Declare new
7307         function.
7308         (find_source_lines): Delete declaration.
7309
7310 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
7311
7312         * source.c (get_filename_and_charpos): Remove fullname
7313         parameter.
7314         (identify_source_line): Update call to get_filename_and_charpos.
7315
7316 2019-06-14  Tom Tromey  <tromey@adacore.com>
7317
7318         PR gdb/24502:
7319         * ui-style.h (skip_ansi_escape): Update comment.
7320         * ui-file.h (class no_terminal_escape_file): New class.
7321         * ui-file.c (no_terminal_escape_file::write)
7322         (no_terminal_escape_file::puts): New methods.
7323         * cli/cli-logging.c (handle_redirections): Use
7324         no_terminal_escape_file.
7325
7326 2019-06-14  Tom Tromey  <tromey@adacore.com>
7327
7328         * NEWS: Move convenience variable news above Python news.
7329
7330 2019-06-14  Tom Tromey  <tom@tromey.com>
7331
7332         * gnulib: Move directory to top-level.
7333         * configure.ac: Don't configure gnulib.
7334         * configure: Rebuild.
7335         * common/common-defs.h: Use new path to gnulib.
7336         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
7337         (GNULIB_H): Remove.
7338         (INCGNU): Look in new gnulib location.
7339         (HFILES_NO_SRCDIR): Remove gnulib files.
7340         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
7341         (generated_files): Remove GNULIB_H.
7342         ($(LIBGNU), all-lib): Remove targets.
7343         (distclean): Don't mention GNULIB_BUILDDIR.
7344         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
7345
7346 2019-06-14  Tom Tromey  <tromey@adacore.com>
7347
7348         * symfile.c (add_symbol_file_command): Remove obsolete comment.
7349         Warn if symbol file does not provide any symbols.
7350
7351 2019-06-14  Tom Tromey  <tromey@adacore.com>
7352
7353         * source.c (find_and_open_source): Respect basenames_may_differ.
7354
7355 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
7356
7357         * annotate.c (annotate_breakpoints_invalid): Make use of
7358         scoped_restore_terminal_state.
7359         (annotate_frames_invalid): Likewise.
7360
7361 2019-06-14  Tom Tromey  <tromey@adacore.com>
7362
7363         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
7364         allow assignment to an internalvar.
7365
7366 2019-06-14  Tom Tromey  <tromey@adacore.com>
7367
7368         * ada-lex.l: Allow "_" in attribute names.
7369
7370 2019-06-14  Tom Tromey  <tromey@adacore.com>
7371
7372         PR gdb/24653:
7373         * regcache.c (registers_changed): Don't call alloca.
7374         * top.c (execute_command): Don't call alloca.
7375
7376 2019-06-13  Pedro Alves  <palves@redhat.com>
7377
7378         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
7379         'expression'.  When parsing an expression, error out if there's
7380         junk after "unlimited".
7381         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
7382         (do_set_command): Adjust calls to is_unlimited_literal.
7383
7384 2019-06-13  Pedro Alves  <palves@redhat.com>
7385
7386         * compile/compile.c (make_compile_options_def_group): Add braces
7387         around array_view initializer.
7388         * thread.c (make_thread_apply_all_options_def_group)
7389         (make_thread_apply_all_options_def_group): Likewise.
7390
7391 2019-06-13  Pedro Alves  <palves@redhat.com>
7392
7393         * NEWS (New commands): Mention "maint test-options
7394         require-delimiter", "maint test-options unknown-is-error", "maint
7395         test-options unknown-is-operand" and "maint show
7396         test-options-completion-result".
7397         (New command options, command completion): New section.
7398         (Completion improvements): New section.
7399         Mention that you can abbreviate "unlimited".
7400
7401 2019-06-13  Pedro Alves  <palves@redhat.com>
7402
7403         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
7404         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
7405         * unittests/cli-utils-selftests.c (test_parse_flags)
7406         (test_parse_flags_qcs): Delete.
7407         (test_cli_utils): Don't call deleted functions.
7408
7409 2019-06-13  Pedro Alves  <palves@redhat.com>
7410
7411         * thread.c: Include "cli/cli-option.h".
7412         (tp_array_compar_ascending): Global.
7413         (tp_array_compar): Delete function.
7414         (tp_array_compar_ascending, tp_array_compar_descending): New
7415         functions.
7416         (ascending_option_def, qcs_flag_option_def)
7417         (thr_qcs_flags_option_defs)
7418         (make_thread_apply_all_options_def_group)
7419         (make_thread_apply_options_def_group): New.
7420         (thread_apply_all_command): Use gdb::option::process_options.
7421         (thread_apply_command_completer)
7422         (thread_apply_all_command_completer): New.
7423         (thread_apply_command): Use gdb::option::process_options.
7424         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
7425         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
7426         to generate help text of "thread apply".  Adjust "taas"'s help.
7427         * tid-parse.c (tid_range_parser::in_thread_range): New method.
7428         * tid-parse.h (tid_range_parser::in_thread_range): New method.
7429
7430 2019-06-13  Pedro Alves  <palves@redhat.com>
7431
7432         * thread.c (thread_apply_command): Check for invalid TID with
7433         isdigit instead of !isalpha.
7434
7435 2019-06-13  Pedro Alves  <palves@redhat.com>
7436
7437         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
7438         (validate_flags_qcs): New.
7439         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
7440         (validate_flags_qcs): Declare.
7441         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
7442         (make_frame_apply_options_def_group): New.
7443         (frame_apply_command_count): Process options with
7444         gdb::option::process_options.
7445         (frame_apply_completer): New.
7446         (frame_apply_level_completer, frame_apply_all_completer)
7447         (frame_apply_completer): New.
7448         (_initialize_stack): Update help of "frame apply", "frame apply
7449         level", "frame apply all" and "faas" to mention supported options
7450         and install command completers.
7451         * stack.h (frame_apply_all_completer): Declare.
7452         * thread.c: Include "stack.h".
7453         (tfaas_command): Add "--".
7454         (_initialize_thread): Update help "tfaas" to mention supported
7455         options and install command completer.
7456
7457 2019-06-13  Pedro Alves  <palves@redhat.com>
7458
7459         * completer.c (complete_nested_command_line): New.
7460         (gdb_completion_word_break_characters_throw): Add assertion.
7461         * completer.h (complete_nested_command_line): Declare.
7462
7463 2019-06-13  Pedro Alves  <palves@redhat.com>
7464
7465         * stack.c (parse_backtrace_qualifiers): New.
7466         (backtrace_command): Use it.
7467         (backtrace_command_completer): Complete on qualifiers.
7468
7469 2019-06-13  Pedro Alves  <palves@redhat.com>
7470
7471         * frame.c: Include "cli/cli-option.h.
7472         (user_set_backtrace_options): New.
7473         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
7474         Delete.
7475         (get_prev_frame): Adjust.
7476         (boolean_option_def, uinteger_option_def)
7477         (set_backtrace_option_defs): New.
7478         (_initialize_frame): Adjust and use
7479         gdb::option::add_setshow_cmds_for_options to install "set
7480         backtrace past-main" and "set backtrace past-entry".
7481         * frame.h: Include "cli/cli-option.h".
7482         (struct frame_print_options): Forward declare.
7483         (print_frame_arguments_all, print_frame_arguments_scalars)
7484         (print_frame_arguments_none): Declare.
7485         (print_entry_values): Delete declaration.
7486         (struct frame_print_options, user_frame_print_options): New.
7487         (struct set_backtrace_options): New.
7488         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
7489         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
7490         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
7491         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
7492         (list_args_or_locals): Add frame_print_options parameter.
7493         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
7494         * python/py-framefilter.c (enumerate_args): Pass down
7495         USER_FRAME_PRINT_OPTIONS.
7496         * stack.c: Include "cli/cli-option.h".
7497         (print_frame_arguments_all, print_frame_arguments_scalars)
7498         (print_frame_arguments_none): Declare.
7499         (print_raw_frame_arguments, print_entry_values): Delete.
7500         (user_frame_print_options): New.
7501         (boolean_option_def, enum_option_def, frame_print_option_defs):
7502         New.
7503         (struct backtrace_cmd_options): New.
7504         (bt_flag_option_def): New.
7505         (backtrace_command_option_defs): New.
7506         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
7507         (print_frame_arg, read_frame_arg, print_frame_args)
7508         (print_frame_info, print_frame): Add frame_print_options parameter
7509         and use it.
7510         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
7511         (backtrace_command_1): Add frame_print_options and
7512         backtrace_cmd_options parameters and use them.
7513         (make_backtrace_options_def_group): New.
7514         (backtrace_command): Process command options with
7515         gdb::option::process_options.
7516         (backtrace_command_completer): New.
7517         (_initialize_stack): Extend "backtrace"'s help to mention
7518         supported options.  Install completer for "backtrace".
7519         Install some settings commands with add_setshow_cmds_for_options.
7520
7521 2019-06-13  Pedro Alves  <palves@redhat.com>
7522
7523         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
7524         and that "set/show print raw frame-arguments" are now deprecated.
7525
7526         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
7527         command.
7528         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
7529         * stack.c (_initialize_stack): Install "set/show print
7530         raw-frame-arguments", and deprecate "set/show print raw
7531         frame-arguments".
7532         * valprint.c (_initialize_valprint): Deprecate "set/show print
7533         raw".
7534
7535 2019-06-13  Pedro Alves  <palves@redhat.com>
7536
7537         * compile/compile.c (struct compile_options): New.
7538         (compile_flag_option_def, compile_command_option_defs)
7539         (make_compile_options_def_group): New.
7540         (compile_file_command): Handle options with
7541         gdb::option::process_options.
7542         (compile_file_command_completer): New function.
7543         (compile_code_command): Handle options with
7544         gdb::option::process_options.
7545         (compile_code_command_completer): New function.
7546         (_initialize_compiler): Install completers for "compile code" and
7547         "compile file".  Mention available options in "compile code" and
7548         "compile code"'s help.
7549         * completer.c (advance_to_completion_word): New, factored out from
7550         ...
7551         (advance_to_expression_complete_word_point): ... this.
7552         (advance_to_filename_complete_word_point): New.
7553         * completer.h (advance_to_filename_complete_word_point): New
7554         declaration.
7555
7556 2019-06-13  Pedro Alves  <palves@redhat.com>
7557
7558         * compile/compile.c: Include "cli/cli-option.h".
7559         (compile_print_value): Scope data pointer is now a
7560         value_print_options pointer; adjust.
7561         (compile_print_command): Process options.  Scope data pointer is
7562         now a value_print_options pointer; adjust.
7563         (_initialize_compile): Update "compile print"'s help to include
7564         supported options.  Install a completer for "compile print".
7565         * cp-valprint.c (show_vtblprint, show_objectprint)
7566         (show_static_field_print): Delete.
7567         (_initialize_cp_valprint): Don't install "set print
7568         static-members", "set print vtbl", "set print object" here.
7569         * printcmd.c: Include "cli/cli-option.h" and
7570         "common/gdb_optional.h".
7571         (print_command_parse_format): Rework to fill in a
7572         value_print_options instead of a format_data.
7573         (print_value): Change parameter type from format_data pointer to
7574         value_print_options reference.  Adjust.
7575         (print_command_1): Process options.  Adjust to pass down a
7576         value_print_options.
7577         (print_command_completer): New.
7578         (_initialize_printcmd): Install print_command_completer as
7579         handle_brkchars completer for the "print" command.  Update
7580         "print"'s help to include supported options.
7581         * valprint.c: Include "cli/cli-option.h".
7582         (show_vtblprint, show_objectprint, show_static_field_print): Moved
7583         here from cp-valprint.c.
7584         (boolean_option_def, uinteger_option_def)
7585         (value_print_option_defs, make_value_print_options_def_group):
7586         New.  Use gdb::option::add_setshow_cmds_for_options to install
7587         "set print elements", "set print null-stop", "set print repeats",
7588         "set print pretty", "set print union", "set print array", "set
7589         print address", "set print symbol", "set print array-indexes".
7590         * valprint.h: Include <string> and "cli/cli-option.h".
7591         (make_value_print_options_def_group): Declare.
7592         (print_value): Change parameter type from format_data pointer to
7593         value_print_options reference.
7594         (print_command_completer): Declare.
7595
7596 2019-06-13  Pedro Alves  <palves@redhat.com>
7597
7598         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
7599         (COMMON_SFILES): Add maint-test-settings.c.
7600         * cli/cli-decode.c (boolean_enums): New global, factored out from
7601         ...
7602         (add_setshow_boolean_cmd): ... here.
7603         * cli/cli-decode.h (boolean_enums): Declare.
7604         * cli/cli-option.c: New file.
7605         * cli/cli-option.h: New file.
7606         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
7607         factored out from ...
7608         (parse_cli_boolean_value(const char *)): ... this.
7609         (is_unlimited_literal): Change parameter type to pointer to
7610         pointer.  Adjust and advance ARG pointer.
7611         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
7612         (parse_cli_var_enum): New, factored out from ...
7613         (do_set_command): ... this.  Adjust.
7614         * cli/cli-setshow.h (parse_cli_boolean_value)
7615         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
7616         (parse_cli_var_enum): Declare.
7617         * cli/cli-utils.c: Include "cli/cli-option.h".
7618         (get_ulongest): New.
7619         * cli/cli-utils.h (get_ulongest): Declare.
7620         (check_for_argument): New overloads.
7621         * maint-test-options.c: New file.
7622
7623 2019-06-13  Pedro Alves  <palves@redhat.com>
7624
7625         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
7626         parse a range if "-" is at the end of the string.
7627
7628 2019-06-13  Pedro Alves  <palves@redhat.com>
7629
7630         * cli/cli-setshow.c (parse_auto_binary_operation)
7631         (parse_cli_boolean_value): Don't allow "o".
7632
7633 2019-06-13  Pedro Alves  <palves@redhat.com>
7634
7635         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
7636         * NEWS: Mention maint test-settings KIND.
7637         * maint-test-settings.c: New file.
7638
7639 2019-06-13  Pedro Alves  <palves@redhat.com>
7640
7641         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
7642         completer.
7643         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
7644         "set" completers.
7645
7646 2019-06-13  Pedro Alves  <palves@redhat.com>
7647
7648         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
7649         after item.
7650
7651 2019-06-13  Pedro Alves  <palves@redhat.com>
7652
7653         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
7654
7655 2019-06-13  Pedro Alves <palves@redhat.com>
7656
7657         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
7658         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
7659         call.
7660         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
7661         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
7662         calls.
7663         (check_for_argument): Skip spaces after argument.
7664
7665 2019-06-13  Pedro Alves  <palves@redhat.com>
7666
7667         * thread.c (thread_apply_command): Adjust TID parsing.
7668         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
7669         detected before end of string.
7670         (tid_is_in_list): Error out if LIST is invalid.
7671
7672 2019-06-13  Pedro Alves  <palves@redhat.com>
7673
7674         * completer.c (complete_line_internal_1): Rewind completion word
7675         point.
7676         (completion_tracker::advance_custom_word_point_by): Change
7677         parameter type to int.
7678         * completer.h (completion_tracker::advance_custom_word_point_by):
7679         Likewise.
7680
7681 2019-06-13  Pedro Alves  <palves@redhat.com>
7682
7683         * completer.c (advance_to_completion_word): Handle delimiters.
7684
7685 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
7686
7687         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
7688
7689 2019-06-11  Tom Tromey  <tom@tromey.com>
7690
7691         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
7692         (xmalloc_failed): Move to alloc.c.
7693         * alloc.c: New file.
7694         * Makefile.in (COMMON_SFILES): Add alloc.c.
7695
7696 2019-06-11  Tom Tromey  <tom@tromey.com>
7697
7698         * nat/linux-waitpid.c: Don't include server.h.
7699         (linux_debug): Remove.
7700         (my_waitpid): Update.
7701
7702 2019-06-11  Tom Tromey  <tromey@adacore.com>
7703
7704         * infcall.c (_initialize_infcall): Remove trailing newline from
7705         help.
7706         * user-regs.c (_initialize_user_regs): Remove trailing newline
7707         from help.
7708         * typeprint.c (_initialize_typeprint): Remove trailing newline
7709         from help.
7710         * reverse.c (_initialize_reverse): Remove trailing newlines from
7711         help.
7712         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
7713         from help.
7714         * language.c (add_set_language_command): Remove trailing newline
7715         from help.
7716         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
7717         help.
7718         * disasm.c (_initialize_disasm): Remove trailing newline from
7719         help.
7720         * top.c (init_main): Remove trailing newline from help.
7721         * interps.c (_initialize_interpreter): Remove trailing newline
7722         from help.
7723         * btrace.c (_initialize_btrace): Remove trailing newlines from
7724         help.
7725         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
7726         from help.
7727         * python/python.c (_initialize_python): Remove trailing newline
7728         from help.
7729         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
7730         help.
7731         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
7732         from help.  Reformat some text.
7733         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
7734         from help.
7735         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
7736         newline from help.
7737
7738 2019-06-11  Tom Tromey  <tromey@adacore.com>
7739
7740         * darwin-nat.c (darwin_decode_exception_message)
7741         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
7742
7743 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
7744
7745         * valops.c (value_slice): Check for not allocated or not
7746         associated values.
7747
7748 2019-06-10  Tom de Vries  <tdevries@suse.de>
7749
7750         PR gdb/24618
7751         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
7752         sure an empty slot (defined by a 32-bit zero pair) is recognized as
7753         invalid.
7754
7755 2019-06-10  Tom de Vries  <tdevries@suse.de>
7756
7757         PR gdb/24611
7758         * linespec.c (linespec_lexer_lex_string): Remove incorrect
7759         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
7760
7761 2019-06-10  Tom de Vries  <tdevries@suse.de>
7762
7763         PR symtab/24545
7764         * symtab.c (struct demangled_name_entry): Add language field.
7765         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
7766         static minimal symbol".  Set and use language field.
7767
7768 2019-06-10  Tom Tromey  <tromey@adacore.com>
7769
7770         * ada-lang.c (_initialize_ada_language): Update help text.
7771
7772 2019-06-10  Tom Tromey  <tromey@adacore.com>
7773
7774         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
7775         with a newline.
7776         * guile/guile.c (handle_boot_error): Don't end warning with a
7777         newline.
7778         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
7779         warning with a newline.
7780         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
7781         newline.
7782         (s12z_frame_cache): Likewise.
7783         * dwarf-index-cache.c (index_cache::store): Don't end warning with
7784         a newline.
7785         * solib-svr4.c (disable_probes_interface): Don't end warning with
7786         a newline.
7787         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
7788         newline.
7789         * python/python.c (do_finish_initialization): Don't end warning
7790         with a newline.
7791
7792 2019-06-10  Tom Tromey  <tom@tromey.com>
7793
7794         * python/py-breakpoint.c (gdbpy_breakpoint_created)
7795         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
7796         gdbpy_enter.
7797
7798 2019-06-10  Tom Tromey  <tromey@adacore.com>
7799
7800         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
7801         data.
7802         (elf_new_init): Don't call stabsread_new_init.
7803         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
7804         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
7805         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
7806
7807 2019-06-10  Tom de Vries  <tdevries@suse.de>
7808
7809         PR symtab/16264
7810         PR symtab/24517
7811         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
7812
7813 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
7814
7815         * source.c (find_and_open_source): Also rewrite relative file
7816         names.
7817
7818 2019-04-26  Amos Bird  <amosbird@gmail.com>
7819
7820         * annotate.c (annotate_thread_exited): Add "thread-exited"
7821         annotation.
7822
7823 2019-06-06  Tom Tromey  <tromey@adacore.com>
7824
7825         * maint.h (class scoped_command_stats): Use
7826         DISABLE_COPY_AND_ASSIGN.
7827         <print_time>: New method.
7828         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
7829         print_time.
7830         (scoped_command_stats::print_time): New method.
7831
7832 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
7833
7834         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
7835         instructions of lengths 6 or 8 bytes.
7836
7837 2019-06-04  Pedro Alves  <palves@redhat.com>
7838
7839         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
7840
7841         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
7842         * breakpoint.c (condition_completer): Likewise.
7843         * cli/cli-dump.c (scan_expression): Likewise.
7844         * common/filestuff.c (mkdir_recursive): Likewise.
7845         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
7846         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
7847         (gdb_abspath): Likewise.
7848         * compile/compile-cplus-types.c
7849         (compile_cplus_instance::decl_name): Likewise.
7850         * completer.c (complete_explicit_location):
7851         (signal_completer, reg_or_group_completer_1): Likewise.
7852         * cp-support.c (cp_remove_params_if_any): Likewise.
7853         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
7854         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
7855         * infcmd.c (strip_bg_char): Likewise.
7856         * linespec.c (copy_token_string): Likewise.
7857         * mi/mi-main.c (output_cores): Likewise.
7858         * psymtab.c (psymtab_search_name):
7859         * symfile.c (test_set_ext_lang_command): Likewise.
7860         * target.c (target_fileio_read_stralloc): Likewise.
7861         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
7862         * value.c (complete_internalvar): Likewise.
7863
7864 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
7865
7866         Add objfile property to gdb.Type.
7867         * NEWS: Mention Python API addition.
7868         * python/py-type.c (typy_get_objfile): New method.
7869
7870 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7871
7872         * NEWS: Mention the new set|show style [title|highlight].
7873         Mention changes to "show style", "help" and "apropos".
7874
7875 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7876
7877         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
7878         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
7879         instead of print_help_for_command.
7880         (print_doc_of_command): New function.
7881         (help_list): Add 'apropos -v word' suggestion.
7882         (print_help_for_command): Style the command name using title style.
7883         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
7884         (_initialize_cli_cmds): Describe -v in apropos_command help.
7885
7886 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7887
7888         * cli/cli-style.h (cli_style_option): Add name in constructor,
7889         add m_name class member, add constructor with intensity,
7890         add name class function.
7891         (cli_style_option::add_setshow_commands): Remove name argument.
7892         (highlight_style, title_style): New styles.
7893         * cli/cli-style.c (do_show): New function that shows a style
7894         characteristic styling the style name with itself.
7895         (set_style_name): New function.
7896         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
7897         Update all callers according to the changes in cli/cli-style.h.
7898         * utils.h (fputs_highlighted): New function.
7899         * utils.c (fputs_highlighted): Likewise.
7900
7901 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7902
7903         * NEWS: Mention new pipe command and new convenience variables.
7904
7905 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7906
7907         * cli/cli-cmds.c (pipe_command): New function.
7908         (_initialize_cli_cmds): Call add_com for pipe_command.
7909         Define | as an alias for pipe.
7910         (exit_status_set_internal_vars): New function.
7911         (shell_escape): Call exit_status_set_internal_vars.
7912         cli/cli-decode.c (find_command_name_length): Recognize | as
7913         a single character command.
7914
7915 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7916
7917         * gdbcmd.h (execute_command_to_ui_file): New declaration.
7918         top.c (execute_command_to_ui_file): New function, mostly a copy
7919         of execute_command_to_string.
7920         (execute_command_to_string): Implement by calling
7921         execute_command_to_ui_file.
7922
7923 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7924
7925         * top.h (saved_command_line): Remove declaration.
7926         * top.c (previous_saved_command_line, previous_repeat_arguments):
7927         New variables.
7928         (saved_command_line): Make static, define together with other
7929         'repeat variables'.
7930         (dont_repeat): Clear repeat_arguments.
7931         (repeat_previous, get_saved_command_line, save_command_line):
7932         New functions.
7933         (gdb_init): Initialize saved_command_line
7934         and previous_saved_command_line.
7935         * main.c (captured_main_1): Remove saved_command_line initialization.
7936         * event-top.c (handle_line_of_input): Update to use
7937         the new 'repeat' related functions instead of direct access to
7938         saved_command_line.
7939         * command.h (repeat_previous, get_saved_command_line,
7940         save_command_line): New declarations.
7941         (dont_repeat): Add comment.
7942
7943 2019-05-30  Tom Tromey  <tromey@adacore.com>
7944
7945         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
7946         Fix comment.
7947         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
7948
7949 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
7950
7951         PR cli/24587
7952         * completer.c (complete): Initialize variable word.
7953
7954 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
7955
7956         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
7957         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
7958         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
7959         'body' is NULL to the outter 'if', protecting the '!is_define'
7960         situation as well.
7961
7962 2019-05-29  Tom Tromey  <tromey@adacore.com>
7963
7964         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
7965         (dwarf_unknown): New function.
7966         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
7967         (dwarf_type_encoding_name): Use dwarf_unknown.
7968
7969 2019-05-29  Tom Tromey  <tromey@adacore.com>
7970
7971         PR c++/20020:
7972         * cp-valprint.c (cp_print_value_fields): Call
7973         cp_print_static_field inside "try".
7974
7975 2019-05-29  Tom Tromey  <tromey@adacore.com>
7976
7977         * inflow.c (struct terminal_info): Add default operator=.
7978         * configure: Rebuild.
7979         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
7980         -Wdeprecated-copy-dtor, -Wredundant-move.
7981
7982 2019-05-29  Tom Tromey  <tromey@adacore.com>
7983
7984         * NEWS: Add entry.
7985         * infcmd.c (print_return_value_1): Handle finish_print
7986         option.
7987         (show_print_finish): New function.
7988         (_initialize_infcmd): Add "set/show print finish" commands.
7989         * valprint.c (user_print_options): Initialize new member.
7990         * valprint.h (struct value_print_options) <finish_print>: New
7991         member.
7992
7993 2019-05-28  Tom Tromey  <tromey@adacore.com>
7994
7995         * ada-lang.c (ada_remove_Xbn_suffix)
7996         (find_old_style_renaming_symbol)
7997         (parse_old_style_renaming): Remove.
7998         (ada_find_renaming_symbol): Don't call
7999         find_old_style_renaming_symbol.
8000         (ada_is_renaming_symbol): Rename from
8001         ada_find_renaming_symbol.  Remove "block" parameter.  Return
8002         bool.  Now static.
8003         (ada_read_var_value): Update and simplify.
8004         * ada-exp.y (write_var_or_type): Remove old code.
8005
8006 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
8007
8008         PR gdb/25010
8009         * event-top.c: Remove include comment.
8010         * inflow.c (class scoped_ignore_sigttou): Move from here...
8011         * inflow.h (class scoped_ignore_sigttou): ...to here.
8012         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
8013         * top.c:  Remove include comment.
8014
8015 2019-05-27  Tom Tromey  <tom@tromey.com>
8016
8017         * NEWS: Fix typo.
8018
8019 2019-05-22  Tom Tromey  <tromey@adacore.com>
8020
8021         * target.c (target_follow_exec): Constify parameter.
8022         * target-delegates.c: Rebuild.
8023         * remote.c (remote_target::follow_exec): Constify parameter.
8024         * infrun.c (follow_exec): Constify parameter.
8025         * target.h (struct target_ops) <follow_exec>: Constify parameter.
8026         (target_follow_exec): Likewise.
8027
8028 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
8029
8030         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
8031         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
8032
8033 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
8034
8035         * NEWS: Add debugredirect and testsuite sections.
8036
8037 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
8038
8039         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
8040         target descriptions using exclusively floating point register name
8041         aliases.
8042
8043 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
8044
8045         PR gdb/18644:
8046         * f-lang.c (build_fortran_types): Handle the case where
8047         gdbarch_floatformat_for_type returns a nullptr.
8048
8049 2019-05-21  Tom de Vries  <tdevries@suse.de>
8050
8051         PR cli/24587
8052         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
8053
8054 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
8055
8056         PR gdb/18644:
8057         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
8058         16-byte floats.
8059         * i386-tdep.c (i386_floatformat_for_type): Use
8060         floatformats_ia64_quad for the 16-byte floating point component
8061         within a fortran 32-byte complex number.
8062
8063 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
8064
8065         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
8066         delete default constructor.
8067         (find_partial_die): Update to return const struct.
8068         (partial_die_parent_scope): Move variable declaration into scope
8069         of its use and change its type to auto.
8070         (guess_partial_die_structure_name): Likewise.
8071         (partial_die_info::fixup): Likewise.
8072
8073 2019-05-17  Tom Tromey  <tromey@adacore.com>
8074
8075         * source.c (find_and_open_source): Remove cast.
8076
8077 2019-05-17  Tom Tromey  <tromey@adacore.com>
8078
8079         * annotate.c (annotate_source): Make "filename" const.
8080         * annotate.h (annotate_source): Use const.
8081
8082 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
8083
8084         * disasm.c (set_disassembler_options): Send errors to stderr.
8085
8086 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
8087
8088         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
8089         (cli_interp_base::set_logging): Check debug_redirect.
8090         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
8091         * cli/cli-logging.c (debug_redirect): Add static variable.
8092         (pop_output_files): Add default param.
8093         (handle_redirections): Print debug setting.
8094         (show_logging_command): Likewise.
8095         (_initialize_cli_logging): Add debugredirect command.
8096         * interps.c (current_interp_set_logging): Add debug_redirect
8097         parameter.
8098         * interps.h (set_logging): Add debug_redirect parameter.
8099         (current_interp_set_logging): Likewise.
8100         * mi/mi-common.h: Likewise.
8101         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
8102
8103 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
8104             Tom Tromey  <tromey@adacore.com>
8105
8106         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
8107         directly.
8108         * cli/cli-interp.h (make_logging_output): Remove declaration.
8109         * cli/cli-logging.c (make_logging_output): Remove function.
8110         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
8111         directly.
8112         * ui-file.c (tee_file::tee_file): Remove bools.
8113         (tee_file::~tee_file): Remove deletes.
8114         * ui-file.h (tee_file): Remove bools.
8115
8116 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
8117
8118         * mi/mi-cmds.h (mi_cmd_complete): New function.
8119         * mi/mi-main.c (mi_cmd_complete): Likewise.
8120         * mi/mi-cmds.c: Define new MI command -complete.
8121         * NEWS: Mention new -complete command.
8122
8123 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
8124
8125         * completer.h (complete): New function.
8126         * completer.c (complete): Likewise.
8127         * cli/cli-cmds.c: (complete_command): Update to use new complete()
8128         function defined in completer.h.
8129
8130 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
8131
8132         * MAINTAINERS (Write After Approval): Add myself.
8133
8134 2019-05-17  Tom de Vries  <tdevries@suse.de>
8135
8136         PR gdb/24094
8137         * dwarf2read.c (struct cu_partial_die_info): New struct.
8138         (find_partial_die): Return cu_partial_die_info.
8139         (partial_die_parent_scope, guess_partial_die_structure_name)
8140         (partial_die_info::fixup): Handle new return type of find_partial_die.
8141
8142 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
8143
8144         PR breakpoints/24541
8145         * stap-probe.c (stap_parse_register_operand): Make "regname" an
8146         "std::string", simplifying the algorithm.
8147
8148 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
8149
8150         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
8151         (stap_static_probe_ops::get_probes): Likewise.
8152
8153 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
8154
8155         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
8156         '-')" and "else if".
8157         (stap_parse_single_operand): Join checks for
8158         "gdbarch_stap_parse_special_token_p" and
8159         "gdbarch_stap_parse_special_token" in the same "if" statement.
8160         Invert check when verifying for operation on register
8161         displacement.
8162
8163 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
8164
8165         * stap-probe.c (stap_get_opcode): Update comment.
8166         (stap_get_expected_argument_type): Likewise.
8167         (handle_stap_probe): Likewise.
8168
8169 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
8170
8171         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
8172         return type to 'bool'.  Adjust comment.  Use 'bool' when
8173         appropriate.
8174         (i386_stap_parse_special_token_three_arg_disp): Likewise.
8175         * stap-probe.c (stap_parse_argument_1): Likewise.
8176         (stap_is_operator): Likewise.
8177         (stap_is_generic_prefix): Likewise.
8178         (stap_is_register_prefix): Likewise.
8179         (stap_is_register_indirection_prefix): Likewise.
8180         (stap_is_integer_prefix): Likewise.
8181         (stap_generic_check_suffix): Likewise.
8182         (stap_check_integer_suffix): Likewise.
8183         (stap_check_register_suffix): Likewise.
8184         (stap_check_register_indirection_suffix): Likewise.
8185         (stap_parse_register_operand): Likewise.
8186         (stap_parse_single_operand): Likewise.
8187         (stap_parse_argument_1): Likewise.
8188         (stap_probe::get_argument_count): Likewise.
8189         (stap_is_operator): Likewise.
8190
8191 2019-05-16  Tom Tromey  <tromey@adacore.com>
8192
8193         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
8194         keyword to foreach.
8195
8196 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
8197
8198         * linux-thread-db.c (try_thread_db_load_1): Change return type
8199         to bool.
8200         (try_thread_db_load): Likewise.
8201         (try_thread_db_load_from_pdir_1): Likewise.
8202         (try_thread_db_load_from_pdir): Likewise.
8203         (try_thread_db_load_from_sdir): Likewise.
8204         (try_thread_db_load_from_dir): Likewise.
8205         (thread_db_load_search): Likewise.
8206         (has_libpthread): Likewise.
8207         (thread_db_load): Likewise.
8208
8209 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
8210
8211         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
8212         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
8213         NULL, and complain/return if that's the case.
8214
8215 2019-05-15  John Darrington <john@darrington.wattle.id.au>
8216
8217         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
8218         (advance, posn, abstract_read_memory): New functions.
8219         [struct mem_read_abstraction]: New struct.
8220         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
8221
8222 2019-05-14  Tom Tromey  <tromey@adacore.com>
8223
8224         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
8225         value is not lval_memory.
8226
8227 2019-05-14  Tom Tromey  <tromey@adacore.com>
8228
8229         * solib.c (info_sharedlibrary_command): Style the file name.
8230
8231 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
8232
8233         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
8234         (aarch64_vnv_type): Likewise.
8235         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
8236         * common/tdesc.c: Likewise.
8237         * common/tdesc.h (enum tdesc_type_kind): Likewise.
8238         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
8239         * features/aarch64-fpu.xml: Add ieee half view.
8240         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
8241         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
8242         * gdbtypes.h (struct builtin_type): Likewise.
8243         (struct objfile_type): Likewise.
8244
8245 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
8246
8247         * language.c (language_sniff_from_mangled_name): Fix "langauge"
8248         typo.
8249         * location.h (string_to_event_location): Likewise.
8250
8251 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
8252
8253         GDB 8.3 released.
8254
8255 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
8256
8257         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
8258         New variable declaration.
8259         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
8260         New variable.
8261         (print_one_breakpoint): Use ui_out::test_flags and new global
8262         variable to compute use_fixed_output.
8263         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
8264         Remove.
8265         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
8266         (mi_multi_location_breakpoint_output_fixed): Remove.
8267         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
8268         new variable.
8269         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
8270         fix_multi_location_breakpoint_output flag if version >= 3.
8271         * ui-out.h (enum ui_out_flag)
8272         <fix_multi_location_breakpoint_output>: New enumerator.
8273
8274 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
8275
8276         * contrib/cc-with-tweaks.sh: Validate dwz's work.
8277
8278 2019-05-10  Tom Tromey  <tromey@adacore.com>
8279
8280         * ada-lang.c (catch_ada_completer): New function.
8281         (_initialize_ada_language): Use it.
8282
8283 2019-05-10  Tom Tromey  <tromey@adacore.com>
8284
8285         * thread.c (print_thread_info): Make "requested_threads" const.
8286         * gdbthread.h (print_thread_info): Make "requested_threads"
8287         const.
8288         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
8289         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
8290
8291 2019-05-08  Tom Tromey  <tom@tromey.com>
8292
8293         * gdbtypes.c (objfile_type_data): Change type.
8294         (objfile_type, _initialize_gdbtypes): Update.
8295
8296 2019-05-08  Tom Tromey  <tom@tromey.com>
8297
8298         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
8299         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
8300         (_initialize_dwarf2_frame): Update.
8301
8302 2019-05-08  Tom Tromey  <tom@tromey.com>
8303
8304         * objc-lang.c (objc_objfile_data): Change type.
8305         (find_methods): Update.
8306         (_initialize_objc_lang): Remove.
8307
8308 2019-05-08  Tom Tromey  <tom@tromey.com>
8309
8310         * stabsread.c (rs6000_builtin_type_data): Change type.
8311         (rs6000_builtin_type, _initialize_stabsread): Update.
8312
8313 2019-05-08  Tom Tromey  <tom@tromey.com>
8314
8315         * mips-tdep.c (mips_pdr_data): Remove.
8316         (_initialize_mips_tdep): Update.
8317
8318 2019-05-08  Tom Tromey  <tom@tromey.com>
8319
8320         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
8321         (hppa_init_objfile_priv_data, read_unwind_info)
8322         (find_unwind_entry, _initialize_hppa_tdep): Update.
8323
8324 2019-05-08  Tom Tromey  <tom@tromey.com>
8325
8326         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
8327         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
8328         on obstack.
8329         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
8330
8331 2019-05-08  Tom Tromey  <tom@tromey.com>
8332
8333         * mdebugread.c (basic_type_data): Change type.
8334         (basic_type, _initialize_mdebugread): Update.
8335
8336 2019-05-08  Tom Tromey  <tom@tromey.com>
8337
8338         * common/gdb_unique_ptr.h (struct noop_deleter): New.
8339
8340 2019-05-08  Tom Tromey  <tom@tromey.com>
8341
8342         * nto-tdep.c (nto_inferior_data_reg): Change type.
8343         (nto_inferior_data): Update.
8344         (nto_inferior_data_cleanup, nto_new_inferior_data)
8345         (_initialize_nto_tdep): Remove.
8346         * nto-tdep.h (struct nto_inferior_data): Add initializers.
8347
8348 2019-05-08  Tom Tromey  <tom@tromey.com>
8349
8350         * ada-lang.c (struct ada_inferior_data): Add initializers.
8351         (ada_inferior_data): Change type.
8352         (ada_inferior_data_cleanup): Remove.
8353         (get_ada_inferior_data, ada_inferior_exit)
8354         (struct ada_pspace_data): Add initializers, destructor.
8355         (ada_pspace_data_handle): Change type.
8356         (get_ada_pspace_data): Update.
8357         (ada_pspace_data_cleanup): Remove.
8358
8359 2019-05-08  Tom Tromey  <tom@tromey.com>
8360
8361         * coffread.c (struct coff_symfile_info): Add initializers.
8362         (coff_objfile_data_key): Move lower.  Change type.
8363         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
8364         Update.
8365         (coff_free_info): Remove.
8366
8367 2019-05-08  Tom Tromey  <tom@tromey.com>
8368
8369         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
8370         (fbsd_pspace_data_handle): Move lower.  Change type.
8371         (get_fbsd_pspace_data): Update.
8372         (fbsd_pspace_data_cleanup): Remove.
8373         (_initialize_fbsd_tdep): Update.
8374
8375 2019-05-08  Tom Tromey  <tom@tromey.com>
8376
8377         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
8378         (get_ada_tasks_pspace_data): Update.
8379         (ada_tasks_pspace_data_cleanup): Remove.
8380         (_initialize_tasks): Update.
8381         (ada_tasks_inferior_data_handle): Change type.
8382         (get_ada_tasks_inferior_data): Update.
8383         (ada_tasks_inferior_data_cleanup): Remove.
8384         (struct ada_tasks_pspace_data): Add initializers.
8385
8386 2019-05-08  Tom Tromey  <tom@tromey.com>
8387
8388         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
8389         * symfile-debug.c (debug_sym_get_probes): Change type.
8390         * stap-probe.c (handle_stap_probe):
8391         (stap_static_probe_ops::get_probes): Change type.
8392         * probe.h (class static_probe_ops) <get_probes>: Change type.
8393         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
8394         (parse_probes_in_pspace): Update.
8395         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
8396         Update.
8397         (any_static_probe_ops::get_probes): Change type.
8398         * elfread.c (elfread_data): New typedef.
8399         (probe_key): Change type.
8400         (elf_get_probes): Likewise.  Update.
8401         (probe_key_free): Remove.
8402         (_initialize_elfread): Update.
8403         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
8404         Change type.
8405         (dtrace_process_dof_probe, dtrace_process_dof)
8406         (dtrace_static_probe_ops::get_probe): Change type.
8407
8408 2019-05-08  Tom Tromey  <tom@tromey.com>
8409
8410         * xcoffread.c (struct xcoff_symfile_info): Rename from
8411         coff_symfile_info.  Add initializers.
8412         (xcoff_objfile_data_key): Move lower.  Change type.
8413         (XCOFF_DATA): Rewrite.
8414         (xcoff_free_info): Remove.
8415         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
8416         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
8417         (xcoff_initial_scan): Update.
8418
8419 2019-05-08  Tom Tromey  <tom@tromey.com>
8420
8421         * solib-svr4.c (struct svr4_info): Add initializers and
8422         destructor.
8423         <probes_table>: Now an htab_up.
8424         (solib_svr4_pspace_data): Change type.
8425         (free_probes_table): Simplify.
8426         (~svr4_info): Rename from svr4_pspace_data_cleanup.
8427         (get_svr4_info, probes_table_htab_remove_objfile_probes)
8428         (probes_table_remove_objfile_probes, register_solib_event_probe)
8429         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
8430         (_initialize_svr4_solib): Update.
8431
8432 2019-05-08  Tom Tromey  <tom@tromey.com>
8433
8434         * remote.c (remote_pspace_data): Change type.
8435         (remote_pspace_data_cleanup): Remove.
8436         (get_remote_exec_file, set_pspace_remote_exec_file)
8437         (_initialize_remote): Update.
8438
8439 2019-05-08  Tom Tromey  <tom@tromey.com>
8440
8441         * breakpoint.c (breakpoint_objfile_key): Change type.
8442         (get_breakpoint_objfile_data): Update.
8443         (free_breakpoint_objfile_data): Remove.
8444         (_initialize_breakpoint): Update.
8445
8446 2019-05-08  Tom Tromey  <tom@tromey.com>
8447
8448         * linux-tdep.c (struct linux_info): Add initializers.
8449         (linux_inferior_data): Move.  Change type.
8450         (invalidate_linux_cache_inf): Update.
8451         (linux_inferior_data_cleanup): Remove.
8452         (get_linux_inferior_data, _initialize_linux_tdep): Update.
8453
8454 2019-05-08  Tom Tromey  <tom@tromey.com>
8455
8456         * auxv.c (auxv_inferior_data): Move.  Change type.
8457         (auxv_inferior_data_cleanup): Remove.
8458         (invalidate_auxv_cache_inf): Rewrite.
8459         (get_auxv_inferior_data, _initialize_auxv): Update.
8460
8461 2019-05-08  Tom Tromey  <tom@tromey.com>
8462
8463         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
8464         (symfile_debug_objfile_data_key): Change type.
8465         (symfile_debug_installed, debug_qf_has_symbols)
8466         (debug_qf_find_last_source_symtab)
8467         (debug_qf_forget_cached_source_info)
8468         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
8469         (debug_qf_print_stats, debug_qf_dump)
8470         (debug_qf_expand_symtabs_for_function)
8471         (debug_qf_expand_all_symtabs)
8472         (debug_qf_expand_symtabs_with_fullname)
8473         (debug_qf_map_matching_symbols)
8474         (debug_qf_expand_symtabs_matching)
8475         (debug_qf_find_pc_sect_compunit_symtab)
8476         (debug_qf_map_symbol_filenames)
8477         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
8478         (debug_sym_new_init, debug_sym_init, debug_sym_read)
8479         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
8480         (debug_sym_read_linetable, debug_sym_relocate): Update.
8481         (symfile_debug_free_objfile): Remove.
8482         (install_symfile_debug_logging, _initialize_symfile_debug):
8483         Update.
8484
8485 2019-05-08  Tom Tromey  <tom@tromey.com>
8486
8487         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
8488         allocate_on_obstack.
8489         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
8490         (get_dwarf2_per_objfile): Update.
8491         (set_dwarf2_per_objfile): Remove.
8492         (dwarf2_has_info, dwarf2_get_section_info): Update.
8493         (dwarf2_free_objfile): Remove.
8494         (_initialize_dwarf2_read): Update.
8495
8496 2019-05-08  Tom Tromey  <tom@tromey.com>
8497
8498         * auto-load.c (struct auto_load_pspace_info): Add destructor and
8499         initializers.
8500         <unsupported_script_warning_printed,
8501         script_not_found_warning_printed>: Now bool.
8502         (auto_load_pspace_data): Change type.
8503         (~auto_load_pspace_info): Rename from
8504         auto_load_pspace_data_cleanup.
8505         (get_auto_load_pspace_data, init_loaded_scripts_info)
8506         (clear_section_scripts, maybe_print_unsupported_script_warning)
8507         (maybe_print_script_not_found_warning, _initialize_auto_load):
8508         Update.
8509
8510 2019-05-08  Tom Tromey  <tom@tromey.com>
8511
8512         * objfiles.c (objfile_pspace_info): Add destructor and
8513         initializers.
8514         (objfiles_pspace_data): Change type.
8515         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
8516         (get_objfile_pspace_data): Update.
8517         (objfiles_bfd_data): Change type.
8518         (get_objfile_bfd_data): Update.
8519         (objfile_bfd_data_free, _initialize_objfiles): Remove.
8520
8521 2019-05-08  Tom Tromey  <tom@tromey.com>
8522
8523         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
8524         Change type.
8525         (get_catch_syscall_inferior_data): Update.
8526         (catch_syscall_inferior_data_cleanup): Remove.
8527         (_initialize_break_catch_syscall): Update.
8528
8529 2019-05-08  Tom Tromey  <tom@tromey.com>
8530
8531         * inflow.c (struct terminal_info): Add destructor and
8532         initializers.
8533         (inflow_inferior_data): Change type.
8534         (~terminal_info): Rename from inflow_inferior_data_cleanup.
8535         (get_inflow_inferior_data, inflow_inferior_exit)
8536         (swap_terminal_info, _initialize_inflow): Update.
8537
8538 2019-05-08  Tom Tromey  <tom@tromey.com>
8539
8540         * target-dcache.c (target_dcache_cleanup): Remove.
8541         (target_dcache_aspace_key): Change type.
8542         (target_dcache_init_p, target_dcache_invalidate)
8543         (target_dcache_get, target_dcache_get_or_init)
8544         (_initialize_target_dcache): Update.
8545         * dcache.h (struct dcache_deleter): New.
8546
8547 2019-05-08  Tom Tromey  <tom@tromey.com>
8548
8549         * symtab.c (struct symbol_cache): Add destructor and
8550         initializers.
8551         (symbol_cache_key): Move.  Change type.
8552         (make_symbol_cache, free_symbol_cache): Remove.
8553         (get_symbol_cache): Update.
8554         (symbol_cache_cleanup): Remove.
8555         (ALL_PSPACES, symbol_cache_flush)
8556         (maintenance_print_symbol_cache)
8557         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
8558         Update.
8559
8560 2019-05-08  Tom Tromey  <tom@tromey.com>
8561
8562         * symtab.c (struct main_info): Add destructor and initializers.
8563         (main_progspace_key): Move.  Change type.
8564         (get_main_info): Update.
8565         (main_info_cleanup): Remove.
8566         (_initialize_symtab): Update.
8567
8568 2019-05-08  Tom Tromey  <tom@tromey.com>
8569
8570         * registry.h (DECLARE_REGISTRY): Define the _key class.
8571
8572 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
8573
8574         * NEWS: Merge two 'New commands' sections.
8575
8576 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
8577
8578         * ada-valprint.c (ada_val_print_gnat_array): Remove language
8579         parameter and use Ada language definition instead.
8580         (ada_val_print_ptr): Remove unused language parameter.
8581         (ada_val_print_num): Remove language parameter and use Ada language
8582         definition instead.
8583         (ada_val_print_enum, ada_val_print_flt): Remove unused language
8584         parameter.
8585         (ada_val_print_struct_union, ada_val_print_ref): Remove language
8586         parameter and use Ada language definition instead.
8587         (ada_val_print_1): Update all ada_val_print_xxx calls.
8588         Remove language parameter.
8589         (ada_val_print): Update ada_val_print_1 call.
8590
8591 2019-05-08  Tom Tromey  <tromey@adacore.com>
8592
8593         * remote.c (remote_hw_watchpoint_limit)
8594         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
8595         Now static.
8596
8597 2019-05-08  Tom Tromey  <tromey@adacore.com>
8598
8599         * maint.c (_initialize_maint_cmds): Move initialization code to
8600         remote.c.
8601         (watchdog, show_watchdog): Move to remote.c.
8602         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
8603         "watchdog" static.
8604         (_initialize_remote): Move initialization code from maint.c.
8605         * defs.h (watchdog): Don't declare.
8606
8607 2019-05-08  Tom Tromey  <tromey@adacore.com>
8608
8609         * tui/tui-interp.c: Include main.h.
8610         * interps.c: Include main.h.
8611         * main.h (interpreter_p): Declare.
8612         * defs.h (interpreter_p): Don't declare.
8613
8614 2019-05-08  Tom Tromey  <tromey@adacore.com>
8615
8616         * dwarf2loc.c: Include dwarf2read.h.
8617         * defs.h (read_unsigned_leb128): Don't declare.
8618         * dwarf2read.h (read_unsigned_leb128): Declare.
8619
8620 2019-05-08  Tom Tromey  <tromey@adacore.com>
8621
8622         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
8623         method.
8624
8625 2019-05-08  Tom Tromey  <tromey@adacore.com>
8626
8627         * utils.c (fputs_maybe_filtered): Reset style after paging, even
8628         when no wrap column is set.
8629
8630 2019-05-08  Tom Tromey  <tromey@adacore.com>
8631
8632         * c-lang.c (c_get_string): Handle non-C-style arrays.
8633
8634 2019-05-08  Tom Tromey  <tromey@adacore.com>
8635
8636         * typeprint.c (print_offset_data::update): Print the bit offset,
8637         not the number of bits remaining.
8638
8639 2019-05-08  Tom Tromey  <tromey@adacore.com>
8640
8641         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
8642         padding at end of comment.
8643
8644 2019-05-08  Tom Tromey  <tromey@adacore.com>
8645
8646         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
8647         Compare main types.
8648
8649 2019-05-06  Tom Tromey  <tom@tromey.com>
8650
8651         * common/scoped_mmap.c: Include common-defs.h.
8652         * common/scoped_mmap.h: Don't include config.h.
8653
8654 2019-05-04  Tom Tromey  <tom@tromey.com>
8655
8656         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
8657         (struct aarch64_call_info): Add initializers.
8658         <si>: Now a std::vector.
8659         (pass_on_stack, aarch64_push_dummy_call): Update.
8660
8661 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
8662             Tom Tromey  <tom@tromey.com>
8663
8664         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
8665         (ppc_threads): Now a std::vector.  Now static.
8666         (hwdebug_find_thread_points_by_tid)
8667         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
8668         Update.
8669
8670 2019-05-04  Tom Tromey  <tom@tromey.com>
8671
8672         * arc-tdep.c (arc_tdesc_init): Return bool.
8673
8674 2019-05-04  Tom Tromey  <tom@tromey.com>
8675
8676         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
8677         Use gdb_assert_not_reached.
8678
8679 2019-05-04  Tom Tromey  <tom@tromey.com>
8680
8681         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
8682         "false".
8683
8684 2019-05-04  Tom Tromey  <tom@tromey.com>
8685
8686         * arc-tdep.c (arc_tdesc_init): Use bool.
8687
8688 2019-05-04  Tom Tromey  <tom@tromey.com>
8689
8690         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
8691
8692 2019-05-04  Tom Tromey  <tom@tromey.com>
8693
8694         * cli/cli-cmds.c (valid_command_p): Return bool.
8695
8696 2019-05-04  Tom Tromey  <tom@tromey.com>
8697
8698         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
8699         * command.h (valid_user_defined_cmd_name_p): Channge return type.
8700
8701 2019-05-04  Raul Tambre  <raul@tambre.ee>
8702
8703         * python/lib/gdb/prompt.py (_ExtendedPrompt)
8704         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
8705         operator for comparison.
8706
8707 2019-05-04  Tom Tromey  <tom@tromey.com>
8708
8709         * psymtab.c (psymbol_name_matches, match_partial_symbol)
8710         (lookup_partial_symbol, print_partial_symbols)
8711         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
8712         (psymbol_compare): Update.
8713         (add_psymbol_to_bcache): Clear the entire psymbol.
8714         (maintenance_check_psymtabs): Update.
8715         * psympriv.h (struct partial_symbol): Don't derive from
8716         general_symbol_info.
8717         <obj_section, unrelocated_address, address,
8718         set_unrelocated_address>: Update.
8719         <ginfo>: New member.
8720         * dwarf-index-write.c (write_psymbols, debug_names::insert)
8721         (debug_names::write_psymbols): Update.
8722
8723 2019-05-04  Tom de Vries  <tdevries@suse.de>
8724
8725         * contrib/cc-with-tweaks.sh: Support -n arg.
8726
8727 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8728
8729         * corelow.c (core_target::detach): Ensure frame cache and
8730         register caches are cleared.
8731         inferior.c (exit_inferior_1): Likewise.
8732
8733 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
8734             Tom Tromey  <tom@tromey.com>
8735
8736         * dictionary.c (collate_pending_symbols_by_language): Remove
8737         "struct" from foreach.
8738         * symtab.c (lookup_global_symbol_from_objfile)
8739         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
8740         foreach.
8741         * ser-tcp.c (net_open): Remove "struct" from foreach.
8742         * objfiles.c (objfile_relocate, objfile_rebase)
8743         (objfile_has_symbols): Remove "struct" from foreach.
8744         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
8745         from foreach.
8746         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
8747         foreach.
8748         * darwin-nat.c (thread_info_from_private_thread_info): Remove
8749         "struct" from foreach.
8750         * ada-lang.c (create_excep_cond_exprs)
8751         (ada_exception_catchpoint_cond_string): Remove "struct" from
8752         foreach.
8753
8754 2019-05-03  Tom Tromey  <tromey@adacore.com>
8755
8756         * ada-exp.y (convert_char_literal): Check suffix of each
8757         enumerator.
8758
8759 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
8760
8761         PR ada/21406:
8762         * ada-exp.y (yywrap): Don't define.
8763         * ada-lex.l (%option): Add noyywrap
8764         (yywrap): Remove.
8765
8766 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
8767
8768         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
8769         _WIN32_WINNT to the XP level, unless already defined to a higher
8770         level.
8771
8772         * unittests/parse-connection-spec-selftests.c:
8773         * ser-tcp.c:
8774         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
8775         override.
8776
8777         * symfile.c (find_separate_debug_file): Remove colon from the
8778         drive spec of DOS/Windows file names of the target, so that the
8779         file name produced from DEBUGDIR and the target's directory will
8780         be valid on DOS/Windows systems.
8781
8782 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
8783
8784         * rust-lang.c (val_print_struct): Handle printing structures
8785         containing strings.
8786
8787 2019-05-02  Tom Tromey  <tromey@adacore.com>
8788
8789         * valarith.c (_initialize_valarith): Remove.
8790
8791 2019-05-01  Tom Tromey  <tromey@adacore.com>
8792
8793         * ada-lang.c (ada_value_primitive_field): Treat more fields as
8794         bitfields.
8795
8796 2019-05-01  Tom Tromey  <tromey@adacore.com>
8797
8798         * ada-lang.c (ada_value_assign): Correctly compute starting offset
8799         for big-endian copies.
8800
8801 2019-04-30  Ali Tamur  <tamur@google.com>
8802         * gdb/dwarf2read.c (read_3_bytes): New declaration.
8803         (read_attribute_value): Added DW_FORM_strx1-4 cases.
8804         (read_3_bytes): New function.
8805
8806 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
8807
8808         * windows-nat.c (main_thread_id): Delete.
8809         (handle_output_debug_string): Replace main_thread_id by
8810         current_event.dwThreadId.
8811         (fake_create_process): Likewise.
8812         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
8813         Do not set main_thread_id.
8814         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
8815         current_event.dwThreadId.
8816         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
8817
8818 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
8819
8820         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
8821         Use current_event.dwThreadId instead of main_thread_id.
8822
8823 2019-04-30  Tom Tromey  <tromey@adacore.com>
8824
8825         * ada-lang.c (ada_lookup_simple_minsyms): New function.
8826         (create_excep_cond_exprs): Iterate over program spaces.
8827         (ada_exception_catchpoint_cond_string): Examine all minimal
8828         symbols for exception types.
8829
8830 2019-04-30  Tom Tromey  <tromey@adacore.com>
8831
8832         PR c++/24470:
8833         * dwarf2read.c (process_structure_scope): Handle case where type
8834         has template parameters but no symbol was created.
8835
8836 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8837             Chris January  <chris.january@arm.com>
8838
8839         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
8840         qualifier.
8841         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
8842
8843 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8844
8845         * f-typeprint.c (f_print_type): Update rules for printing
8846         whitespace.
8847         (f_type_print_varspec_suffix): Likewise.
8848
8849 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8850             Chris January  <chris.january@arm.com>
8851
8852         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
8853         function arguments.
8854
8855 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8856
8857         * f-lang.c (build_fortran_types): Change name of void type to
8858         lower case.
8859         * f-typeprint.c (f_type_print_base): Print the name of the void
8860         type, rather than a fixed string.
8861         * f-valprint.c (f_decorations): Use lower case void string.
8862
8863 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8864             Chris January  <chris.january@arm.com>
8865
8866         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
8867         types for Fortran.
8868
8869 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8870             Chris January  <chris.january@arm.com>
8871             David Lecomber  <david.lecomber@arm.com>
8872
8873         * f-exp.y (BINOP_INTRINSIC): New token.
8874         (exp): New parser rule handling BINOP_INTRINSIC.
8875         (f77_keywords): Add new builtin procedures.
8876         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
8877         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
8878         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
8879         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
8880         (print_unop_subexp_f): New function.
8881         (print_binop_subexp_f): New function.
8882         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
8883         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
8884         (dump_subexp_body_f): Likewise.
8885         (operator_check_f): Likewise.
8886         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
8887         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
8888
8889 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8890
8891         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
8892         UNOP_KIND.
8893         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
8894         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
8895         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
8896         (operator_length_f): New fuction.
8897         (print_subexp_f): New function.
8898         (op_name_f): New function.
8899         (dump_subexp_body_f): New function.
8900         (operator_check_f): New function.
8901         (exp_descriptor_f): Replace standard expression handling functions
8902         with new functions.
8903         * gdb/fortran-operator.def: New file.
8904         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
8905         * gdb/std-operator.def: Remove UNOP_KIND.
8906
8907 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8908
8909         * std-operator.def: Remove unbalanced, stray double quote
8910         character.
8911
8912 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
8913             Chris January  <chris.january@arm.com>
8914             Daniel Everett  <daniel.everett@arm.com>
8915             Nick Forrington  <nick.forrington@arm.com>
8916             Richard Bunt  <richard.bunt@arm.com>
8917
8918         * cp-valprint.c (cp_print_value_fields): Allow an additional level
8919         of depth when printing anonymous structs or unions.
8920         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
8921         Don't print either the top-level value, or the children if the
8922         max-depth is exceeded.
8923         (ppscm_print_children): When printing the key of a map, allow one
8924         extra level of depth.
8925         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
8926         print either the top-level value, or the children if the max-depth
8927         is exceeded.
8928         (print_children): When printing the key of a map, allow one extra
8929         level of depth.
8930         * python/py-value.c (valpy_format_string): Add max_depth keyword.
8931         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
8932         (user_print_options): Initialise max_depth field.
8933         (val_print_scalar_or_string_type_p): New function.
8934         (val_print): Check to see if the max depth has been reached.
8935         (val_print_check_max_depth): Define new function.
8936         (show_print_max_depth): New function.
8937         (_initialize_valprint): Add 'print max-depth' option.
8938         * valprint.h (struct value_print_options) <max_depth>: New field.
8939         (val_print_check_max_depth): Declare new function.
8940         * NEWS: Document new feature.
8941
8942 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
8943
8944         * ada-lang.c (ada_language_defn): Initialise new field.
8945         * c-lang.c (c_is_string_type_p): New function.
8946         (c_language_defn): Initialise new field.
8947         (cplus_language_defn): Initialise new field.
8948         (asm_language_defn): Initialise new field.
8949         (minimal_language_defn): Initialise new field.
8950         * c-lang.h (c_is_string_type_p): Declare new function.
8951         * d-lang.c (d_language_defn): Initialise new field.
8952         * f-lang.c (f_is_string_type_p): New function.
8953         (f_language_defn): Initialise new field.
8954         * go-lang.c (go_is_string_type_p): New function.
8955         (go_language_defn): Initialise new field.
8956         * language.c (default_is_string_type_p): New function.
8957         (unknown_language_defn): Initialise new field.
8958         (auto_language_defn): Initialise new field.
8959         * language.h (struct language_defn) <la_is_string_type_p>: New
8960         member variable.
8961         (default_is_string_type_p): Declare new function.
8962         * m2-lang.c (m2_language_defn): Initialise new field.
8963         * objc-lang.c (objc_language_defn): Initialise new field.
8964         * opencl-lang.c (opencl_language_defn): Initialise new field.
8965         * p-lang.c (pascal_is_string_type_p): New function.
8966         (pascal_language_defn): Initialise new field.
8967         * rust-lang.c (rust_is_string_type_p): New function.
8968         (rust_language_defn): Initialise new field.
8969
8970 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
8971
8972         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
8973         New field.
8974         * ada-lang.c (ada_language_defn): Initialise new field.
8975         * c-lang.c (c_language_defn): Likewise.
8976         (cplus_language_defn): Likewise.
8977         (asm_language_defn): Likewise.
8978         (minimal_language_defn): Likewise.
8979         * d-lang.c (d_language_defn): Likewise.
8980         * f-lang.c (f_language_defn): Likewise.
8981         * go-lang.c (go_language_defn): Likewise.
8982         * language.c (unknown_language_defn): Likewise.
8983         (auto_language_defn): Likewise.
8984         * m2-lang.c (m2_language_defn): Likewise.
8985         * objc-lang.c (objc_language_defn): Likewise.
8986         * opencl-lang.c (opencl_language_defn): Likewise.
8987         * p-lang.c (pascal_language_defn): Likewise.
8988         * rust-lang.c (rust_language_defn): Likewise.
8989
8990 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
8991
8992         * ada-lang.c (ada_is_character_type): Change return type to bool.
8993         (ada_is_string_type): Likewise.
8994         * ada-lang.h (ada_is_character_type): Update declaration
8995         (ada_is_string_type): Likewise.
8996
8997 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8998
8999         Support style in 'frame|thread apply'
9000
9001         * gdbcmd.h (execute_command_to_string): New term_out parameter.
9002         * record.c (record_start, record_stop): Update callers of
9003         execute_command_to_string with false.
9004         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
9005         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
9006         methods.
9007         (class string_file): New constructor with term_out parameter.
9008         Override methods term_out and can_emit_style_escape.  New member
9009         term_out.
9010         (class stdio_file): Override can_emit_style_escape.
9011         (class tee_file): Override term_out and can_emit_style_escape.
9012         * utils.h (can_emit_style_escape): Remove.
9013         * utils.c (can_emit_style_escape): Likewise.
9014         Update all callers of can_emit_style_escape (SOMESTREAM) to
9015         SOMESTREAM->can_emit_style_escape.
9016         * source-cache.c (source_cache::get_source_lines): Likewise.
9017         * stack.c (frame_apply_command_count): Call execute_command_to_string
9018         passing the term_out characteristic of the current gdb_stdout.
9019         * thread.c (thr_try_catch_cmd): Likewise.
9020         * top.c (execute_command_to_string): pass term_out parameter
9021         to construct the string_file for the command output.
9022         * ui-file.c (term_cli_styling): New function (most code moved
9023         from utils.c can_emit_style_escape).
9024         (string_file::string_file, string_file::can_emit_style_escape,
9025         stdio_file::can_emit_style_escape, tee_file::term_out,
9026         tee_file::can_emit_style_escape): New functions.
9027
9028 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9029
9030         * NEWS: Mention the new set|show may-call-functions.
9031         * infcall.c (may_call_functions_p): New variable.
9032         (show_may_call_functions_p): New function.
9033         (call_function_by_hand_dummy): Throws an error if not
9034         may-call-functions.
9035         (_initialize_infcall): Call add_setshow_boolean_cmd for
9036         may-call-functions.
9037
9038 2019-04-25  Keith Seitz  <keiths@redhat.com>
9039
9040         PR c++/24367
9041         * cp-support.c (inspect_type): Don't attempt substitutions
9042         of symbol with the same name.
9043
9044 2019-04-25  Tom Tromey  <tromey@adacore.com>
9045
9046         PR gdb/24475:
9047         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
9048         static.
9049
9050 2019-04-25  Tom Tromey  <tromey@adacore.com>
9051
9052         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
9053         rvalue reference.
9054         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
9055         (gdb_xml_parser::parse): Use std::move.
9056         * python/python-internal.h (gdbpy_convert_exception): Take a const
9057         reference.
9058         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
9059         std::move.
9060         * python/py-utils.c (gdbpy_convert_exception): Take a const
9061         reference.
9062         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
9063         Use std::move.
9064         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
9065         Use std::move.
9066         * mi/mi-main.c (mi_print_exception): Take a const reference.
9067         * main.c (handle_command_errors): Take a const reference.
9068         * linespec.c (parse_linespec): Use std::move.
9069         * infcall.c (run_inferior_call): Use std::move.
9070         (call_function_by_hand_dummy): Use std::move.
9071         * exec.c (try_open_exec_file): Use std::move.
9072         * exceptions.h (exception_print, exception_fprintf)
9073         (exception_print_same): Update.
9074         * exceptions.c (print_exception, exception_print)
9075         (exception_fprintf, exception_print_same): Change parameters to
9076         const reference.
9077         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
9078         * common/new-op.c: Use std::move.
9079         * common/common-exceptions.h (struct gdb_exception): Add move
9080         constructor.
9081         (struct gdb_exception_error, struct gdb_exception_quit, struct
9082         gdb_quit_bad_alloc): Change constructor to move constructor.
9083         (throw_exception): Change parameter to rvalue reference.
9084         * common/common-exceptions.c (throw_exception): Take rvalue
9085         reference.
9086         * cli/cli-interp.c (safe_execute_command): Use std::move.
9087         * breakpoint.c (insert_bp_location, location_to_sals): Use
9088         std::move.
9089
9090 2019-04-25  Tom Tromey  <tromey@adacore.com>
9091
9092         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
9093         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
9094         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
9095         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
9096         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
9097         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
9098         guile/scm-value.c: Use unpack.
9099         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
9100         gdbscm_gdb_exception.
9101         (gdbscm_throw_gdb_exception): Likewise.
9102         (struct gdbscm_gdb_exception): New.
9103         (unpack): New function.
9104         (gdbscm_wrap): Use unpack.
9105
9106 2019-04-25  Tom Tromey  <tromey@adacore.com>
9107
9108         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
9109         (gdb_rl_callback_handler): Use std::move.
9110         * common/common-exceptions.h (struct gdb_exception): Add move
9111         assignment operator.
9112         (throw_exception_sjlj): Change "exception" to const reference.
9113         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
9114         (throw_exception_sjlj): Change "exception" to const reference.
9115
9116 2019-04-25  Tom Tromey  <tromey@adacore.com>
9117
9118         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
9119         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
9120         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
9121         Update.
9122         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
9123         Update.
9124         * mi/mi-interp.c (mi_interp::exec): Update.
9125         * linespec.c (parse_linespec): Update.
9126         * infcall.c (run_inferior_call): Update.
9127         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
9128         * guile/scm-symbol.c (gdbscm_lookup_symbol)
9129         (gdbscm_lookup_global_symbol): Update.
9130         * guile/scm-param.c (gdbscm_parameter_value): Update.
9131         * guile/scm-frame.c (gdbscm_frame_read_register)
9132         (gdbscm_frame_read_var): Update.
9133         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
9134         * exec.c (try_open_exec_file): Update.
9135         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
9136         (gdb_rl_callback_handler): Update.
9137         * common/common-exceptions.h (exception_none): Don't declare.
9138         * common/common-exceptions.c (exception_none): Don't define.
9139         (struct catcher) <exception>: Update.
9140         * cli/cli-interp.c (safe_execute_command): Update.
9141         * breakpoint.c (insert_bp_location, location_to_sals): Update.
9142
9143 2019-04-25  Ali Tamur  <tamur@google.com>
9144
9145         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
9146         (read_attribute_value): Likewise.
9147         (dwarf2_read_addr_index): Update comment.
9148         (read_str_index): Add DW_FORM_strx.
9149         (dwarf2_string_attr): Likewise.
9150         (dwarf2_const_value_attr): Likewise.
9151         (dump_die_shallow): Likewise.
9152         (dwarf2_fetch_constant_bytes): Likewise.
9153         (skip_form_bytes): Likewise.
9154         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
9155
9156 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
9157
9158         PR corefiles/11608
9159         PR corefiles/18187
9160         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
9161         OFFSET.  Verify if current mapping contains an ELF header.
9162         (linux_find_memory_regions_full): Adjust call to
9163         dump_mapping_p.
9164
9165 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
9166             Kang Li <kanglictf@gmail.com>
9167
9168         PR gdb/21600
9169
9170         * dwarf2-frame.c (read_initial_length): Be consistent about using
9171         unsigned representation of length.
9172         (decode_frame_entry_1): Likewise.  Check for wraparound of
9173         end pointer as well as buffer overflow.
9174
9175 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
9176
9177         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
9178         "vq".
9179
9180 2019-04-24  Tom Tromey  <tromey@adacore.com>
9181
9182         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
9183
9184 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9185
9186         * s12z-tdep.c (s12z_unwind_pc): Delete.
9187         (s12z_unwind_sp): Delete.
9188         (s12z_gdbarch_init): Don't register deleted functions with
9189         gdbarch.
9190
9191 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9192
9193         * rl78-tdep.c (rl78_unwind_sp): Delete.
9194         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
9195
9196 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9197
9198         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
9199         (xstormy16_unwind_pc): Delete.
9200         (xstormy16_dummy_id): Delete.
9201         (xstormy16_gdbarch_init): Don't register deleted functions with
9202         gdbarch.
9203
9204 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9205
9206         * vax-tdep.c (vax_unwind_pc): Delete.
9207         (vax_gdbarch_init): Don't register deleted function with gdbarch.
9208
9209 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9210
9211         * v850-tdep.c (v850_unwind_sp): Delete.
9212         (v850_unwind_pc): Delete.
9213         (v850_dummy_id): Delete.
9214         (v850_gdbarch_init): Don't register deleted functions with
9215         gdbarch.
9216
9217 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9218
9219         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
9220         (tilegx_unwind_pc): Delete.
9221         (tilegx_unwind_dummy_id): Delete.
9222         (tilegx_gdbarch_init): Don't register deleted functions with
9223         gdbarch.
9224
9225 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9226
9227         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
9228         (tic6x_dummy_id): Delete.
9229         (tic6x_gdbarch_init): Don't register deleted functions with
9230         gdbarch.
9231
9232 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9233
9234         * sparc-tdep.c (sparc_unwind_pc): Delete.
9235         (sparc32_gdbarch_init): Don't register deleted function with
9236         gdbarch.
9237
9238 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9239
9240         * sh-tdep.c (sh_unwind_sp): Delete.
9241         (sh_unwind_pc): Delete.
9242         (sh_dummy_id): Delete.
9243         (sh_gdbarch_init): Don't register deleted functions with
9244         gdbarch.
9245
9246 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9247
9248         * score-tdep.c (score_unwind_sp): Delete.
9249         (score_unwind_pc): Delete.
9250         (score_dummy_id): Delete.
9251         (score_gdbarch_init): Don't register deleted functions with
9252         gdbarch.
9253
9254 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9255
9256         * rx-tdep.c (rx_unwind_pc): Delete.
9257         (rx_unwind_sp): Delete.
9258         (rx_dummy_id): Delete.
9259         (rx_gdbarch_init): Don't register deleted functions with
9260         gdbarch.  Update comment.
9261
9262 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9263
9264         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
9265         (rs6000_dummy_id): Delete.
9266         (rs6000_gdbarch_init): Don't register deleted functions with
9267         gdbarch.
9268
9269 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9270
9271         * or1k-tdep.c (or1k_dummy_id): Delete.
9272         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
9273
9274 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9275
9276         * nios2-tdep.c (nios2_dummy_id): Delete.
9277         (nios2_unwind_sp): Delete.
9278         (nios2_gdbarch_init): Don't register deleted functions with
9279         gdbarch.
9280
9281 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9282
9283         * nds32-tdep.c (nds32_dummy_id): Delete.
9284         (nds32_unwind_pc): Delete.
9285         (nds32_unwind_sp): Delete.
9286         (nds32_gdbarch_init): Don't register deleted functions with
9287         gdbarch.
9288
9289 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9290
9291         * msp430-tdep.c (msp430_unwind_pc): Delete.
9292         (msp430_unwind_sp): Delete.
9293         (msp430_dummy_id): Delete.
9294         (msp430_gdbarch_init): Don't register deleted functions with
9295         gdbarch.
9296
9297 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9298
9299         * moxie-tdep.c (moxie_unwind_sp): Delete.
9300         (moxie_unwind_pc): Delete.
9301         (moxie_dummy_id): Delete.
9302         (moxie_gdbarch_init): Don't register deleted functions with
9303         gdbarch.
9304
9305 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9306
9307         * mn10300-tdep.c (mn10300_dummy_id): Delete.
9308         (mn10300_unwind_pc): Delete.
9309         (mn10300_unwind_sp): Delete.
9310         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
9311         mn10300_unwind_sp.
9312         (mn10300_frame_unwind_init): Don't register deleted functions with
9313         gdbarch.
9314
9315 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9316
9317         * mep-tdep.c (mep_unwind_pc): Delete.
9318         (mep_unwind_sp): Delete.
9319         (mep_dummy_id): Delete.
9320         (mep_gdbarch_init): Don't register deleted functions with
9321         gdbarch.
9322
9323 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9324
9325         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
9326         (m68hc11_unwind_sp): Delete.
9327         (m68hc11_gdbarch_init): Don't register deleted functions with
9328         gdbarch.
9329
9330 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9331
9332         * m32r-tdep.c (m32r_unwind_sp): Delete.
9333         (m32r_unwind_pc): Delete.
9334         (m32r_dummy_id): Delete.
9335         (m32r_gdbarch_init): Don't register deleted functions with
9336         gdbarch.
9337
9338 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9339
9340         * m32c-tdep.c (m32c_unwind_pc): Delete.
9341         (m32c_unwind_sp): Delete.
9342         (m32c_dummy_id): Delete.
9343         (m32c_gdbarch_init): Don't register deleted functions with
9344         gdbarch.
9345
9346 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9347
9348         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
9349         (lm32_unwind_pc): Delete.
9350         (lm32_dummy_id): Delete.
9351         (lm32_gdbarch_init): Don't register deleted functions with
9352         gdbarch.
9353
9354 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9355
9356         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
9357         (iq2000_unwind_pc): Delete.
9358         (iq2000_dummy_id): Delete.
9359         (iq2000_gdbarch_init): Don't register deleted functions with
9360         gdbarch.
9361
9362 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9363
9364         * nds32-tdep.c (nds32_type_align): Delete.
9365         (nds32_push_dummy_call): Use type_align instead.
9366
9367 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9368
9369         * arm-tdep.c (arm_type_align): Only handle vector override case.
9370         (arm_push_dummy_call): Use type_align.
9371         (arm_gdbarch_init): Register arm_type_align gdbarch function.
9372
9373 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9374
9375         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
9376         case.
9377         (pass_on_stack): Use type_align.
9378         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
9379         function.
9380
9381 2019-04-23  Tom Tromey  <tromey@adacore.com>
9382
9383         * dwarf2read.c (line_header::file_name_at): Remove unused
9384         overload.
9385
9386 2019-04-23  Tom de Vries  <tdevries@suse.de>
9387
9388         PR gdb/24438
9389         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
9390         invocation.
9391
9392
9393 2019-03-27  Ali Tamur  <tamur@google.com>
9394
9395         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
9396         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
9397         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
9398         (dwarf_expr_context::get_addr_index): Likewise
9399         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
9400         (symbol_needs_eval_context::get_addr_index): Likewise
9401         (disassemble_dwarf_expression): Add DW_OP_addrx
9402         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
9403         (read_cutu_die_from_dwo): Update comment
9404         (skip_one_die): Add DW_FORM_addrx
9405         (read_attribute_value): Likewise
9406         (var_decode_location): Add DW_OP_addrx
9407         (dwarf2_const_value_attr): Add DW_FORM_addrx
9408         (dump_die_shallow): Likewise
9409         (dwarf2_fetch_constant_bytes): Likewise
9410         (decode_locdesc): Add DW_OP_addrx
9411         (skip_form_bytes): Add DW_FORM_addrx
9412
9413 2019-04-22  Ali Tamur  <tamur@google.com>
9414
9415         * MAINTAINERS (Write After Approval): Add self.
9416
9417 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
9418
9419         * solib-svr4.c (get_svr4_info): Add pspace parameter.
9420         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
9421         (open_symbol_file_object): Likewise.
9422         (svr4_default_sos): Add info parameter.
9423         (svr4_read_so_list): Likewise.
9424         (svr4_current_sos_direct): Adjust functions calls to pass down
9425         info.
9426         (svr4_current_sos_1): Add info parameter.
9427         (svr4_current_sos): Call get_svr4_info, pass info down to
9428         svr4_current_sos_1.
9429         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
9430         get_svr4_info.
9431         (svr4_in_dynsym_resolve_code): Pass current_program_space to
9432         get_svr4_info.
9433         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
9434         to get_svr4_info.
9435         (probes_table_remove_objfile_probes): Likewise.
9436         (register_solib_event_probe): Add info parameter.
9437         (solist_update_incremental): Pass info parameter down to
9438         svr4_read_so_list.
9439         (disable_probes_interface): Add info parameter.
9440         (svr4_handle_solib_event): Pass current_program_space to
9441         get_svr4_info.  Adjust disable_probes_interface cleanup.
9442         (svr4_create_probe_breakpoints): Add info parameter, pass it
9443         down to register_solib_event_probe.
9444         (svr4_create_solib_event_breakpoints): Add info parameter,
9445         pass it down to svr4_create_probe_breakpoints.
9446         (enable_break): Pass info down to
9447         svr4_create_solib_event_breakpoints.
9448         (svr4_solib_create_inferior_hook): Pass current_program_space to
9449         get_svr4_info.
9450         (svr4_clear_solib): Likewise.
9451
9452 2019-04-22  Pedro Alves  <palves@redhat.com>
9453
9454         * solib-svr4.c (svr4_free_objfile_observer): New.
9455         (probe_and_action::objfile): New field.
9456         (probes_table_htab_remove_objfile_probes)
9457         (probes_table_remove_objfile_probes): New functions.
9458         (register_solib_event_probe): Add 'objfile' parameter.  Store it
9459         in the new probe_and_action.  Don't store the probe in 'lookup'.
9460         (svr4_create_probe_breakpoints): Pass objfile to
9461         register_solib_event_probe.
9462         (_initialize_svr4_solib): Register a free_objfile observer.
9463
9464 2019-04-19  Tom Tromey  <tom@tromey.com>
9465
9466         * common/queue.h: Remove.
9467
9468 2019-04-19  Tom Tromey  <tom@tromey.com>
9469
9470         * event-loop.c: Don't include "common/queue.h".
9471
9472 2019-04-19  Tom Tromey  <tom@tromey.com>
9473
9474         * remote.c (remote_target): Use delete.
9475         * remote-notif.h: Include <list>, not "common/queue.h".
9476         (notif_client_p): Remove typedef.
9477         (remote_notif_state): Add constructor, destructor, initializer.
9478         <notif_queue>: Now a std::list.
9479         (remote_notif_state_xfree): Don't declare.
9480         * remote-notif.c (remote_notif_process, handle_notification)
9481         (remote_notif_state_allocate): Update.
9482         (~remote_notif_state): Rename from remote_notif_state_xfree.
9483
9484 2019-04-19  Tom Tromey  <tom@tromey.com>
9485
9486         * symfile.c (reread_symbols): Update.
9487         * objfiles.c (objfile_register_static_link)
9488         (objfile_lookup_static_link): Update
9489         (~objfile) Don't delete static_links.
9490         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
9491
9492 2019-04-19  Tom Tromey  <tom@tromey.com>
9493
9494         * type-stack.h (struct type_stack) <insert>: Constify string.
9495         * type-stack.c (type_stack::insert): Constify string.
9496         * gdbtypes.h (lookup_template_type): Update.
9497         (address_space_name_to_int): Update.
9498         * gdbtypes.c (address_space_name_to_int): Make space_identifier
9499         const.
9500         (lookup_template_type): Make name const.
9501         * c-exp.y: Update rules.
9502         (lex_one_token, classify_name, classify_inner_name)
9503         (c_print_token): Update.
9504         * p-exp.y: Update rules.
9505         (yylex): Update.
9506         * f-exp.y: Update rules.
9507         (yylex): Update.
9508         * d-exp.y: Update rules.
9509         (lex_one_token, classify_name, classify_inner_name): Update.
9510         * parse.c (write_dollar_variable, copy_name): Return std::string.
9511         * parser-defs.h (copy_name): Change return type.
9512         * m2-exp.y: Update rules.
9513         (yylex): Update.
9514         * go-exp.y (lex_one_token): Update.
9515         Update rules.
9516         (classify_unsafe_function, classify_packaged_name)
9517         (classify_name, yylex): Update.
9518
9519 2019-04-19  Sergei Trofimovich <siarheit@google.com>
9520
9521         * configure.ac: add --enable-source-highlight switch.
9522         * configure: Regenerate.
9523         * top.c (print_gdb_version): plumb --enable-source-highlight
9524         status to "show configuration".
9525
9526 2019-04-19  Tom Tromey  <tromey@adacore.com>
9527
9528         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
9529         Check ADA_TYPE_P.
9530         (empty_record, ada_template_to_fixed_record_type_1)
9531         (template_to_static_fixed_type)
9532         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
9533         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
9534         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
9535         macros.
9536
9537 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
9538
9539         PR symtab/24423:
9540         * source.c (print_source_lines_base): Advance "iter" when a
9541         control character is seen.
9542
9543 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9544
9545         * inferior.h (struct infcall_suspend_state_deleter):
9546         Catch exception in destructor to avoid crash.
9547
9548 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9549
9550         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
9551         close to the add_com "shell".
9552
9553 2019-04-18  Tom Tromey  <tromey@adacore.com>
9554
9555         * process-stratum-target.h (class process_stratum_target)
9556         <stratum>: Add "final".
9557
9558 2019-04-17  Tom Tromey  <tromey@adacore.com>
9559
9560         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
9561         against nullptr before use.
9562
9563 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
9564
9565         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
9566
9567 2019-04-17  Jim Wilson  <jimw@sifive.com>
9568             Andrew Burgess  <andrew.burgess@embecosm.com>
9569
9570         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
9571         code read might fail, assume 4-byte breakpoint in that case.
9572
9573 2019-04-15  Leszek Swirski  <leszeks@google.com>
9574
9575         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
9576         rather than a hand-rolled POD check when checking for forced MEMORY
9577         classification.
9578
9579 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
9580
9581         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
9582         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
9583         function.
9584         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
9585         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
9586         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
9587         declaration.
9588
9589 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
9590
9591         * aarch64-linux-nat.c
9592         (aarch64_linux_nat_target::thread_architecture): Add override.
9593         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
9594         each VQ.
9595
9596 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
9597
9598         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
9599
9600 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
9601
9602         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
9603         target types of size 96-bits, add some additional comments, and
9604         check that the builtin type we found was the correct size.
9605
9606 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
9607
9608         * utils.c (prompt_for_continue): Don't restore the styling at the
9609         end, as applied_style has the wrong value.  This fixes styling in
9610         long lists of file names that are interrupted by the "Continue?"
9611         prompt.
9612
9613 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
9614
9615         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
9616         * c-lang.c (c_language_defn): Likewise.
9617         (cplus_language_defn): Likewise.
9618         (asm_language_defn): Likewise.
9619         (minimal_language_defn): Likewise.
9620         * d-lang.c (d_language_defn): Likewise.
9621         * f-lang.c (f_language_defn): Likewise.
9622         * go-lang.c (go_language_defn): Likewise.
9623         * language.c (unknown_language_defn): Likewise.
9624         (auto_language_defn): Likewise.
9625         * language.h (struct language_defn): Remove la_magic field.
9626         (LANG_MAGIC): Delete.
9627         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
9628         * objc-lang.c (objc_language_defn): Likewise.
9629         * opencl-lang.c (opencl_language_defn): Likewise.
9630         * p-lang.c (pascal_language_defn): Likewise.
9631         * rust-lang.c (rust_language_defn): Likewise.
9632
9633 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
9634
9635         * riscv-tdep.c (riscv_type_align): New function.
9636         (riscv_type_alignment): Delete.
9637         (riscv_arg_location): Use 'type_align'.
9638         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
9639
9640 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
9641
9642         * gdbtypes.c (type_align): A struct with no non-static fields also
9643         has alignment of 1.
9644
9645 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
9646
9647         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
9648         component to 0.
9649         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
9650         member.
9651         (riscv_struct_info::analyse): New implementation using new
9652         analyse_inner member function.
9653         (riscv_struct_info::field_offset): New member function.
9654         (riscv_struct_info::m_offsets): New member variable.
9655         (riscv_struct_info::analyse_inner): New private member function,
9656         takes the old implementation of riscv_struct_info::analyse but
9657         extended to track field offsets.
9658         (riscv_call_arg_struct): Update the struct folding special cases
9659         to handle cases where empty C++ structs, which are non-zero
9660         length, are found.
9661         (riscv_arg_location): Initialise the length of each location, a
9662         non-zero length now indicates the location is in use.
9663         (riscv_push_dummy_call): Allow for the first location having a
9664         non-zero offset when setting up arguments.
9665         (riscv_return_value): Likewise, but for return values.
9666
9667 2019-04-11  Tom Tromey  <tromey@adacore.com>
9668
9669         * utils.c (internal_vproblem): Make "msg" const.
9670
9671 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
9672
9673         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
9674         * trad-frame.c (trad_frame_reset_saved_regs): New function.
9675         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
9676         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
9677
9678 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
9679
9680         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
9681         function.
9682         (fill_gregset): Call amd64_linux_collect_native_gregset instead
9683         of amd64_collect_native_gregset.
9684         (amd64_linux_nat_target::store_registers): Likewise.
9685
9686 2019-04-10  Tom Tromey  <tom@tromey.com>
9687
9688         * symtab.c (lookup_global_symbol_from_objfile)
9689         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
9690         * objfiles.h (class separate_debug_iterator): New.
9691         (class separate_debug_range): New.
9692         (struct objfile) <separate_debug_objfiles>: New method.
9693         (objfile_separate_debug_iterate): Don't declare.
9694         * objfiles.c (separate_debug_iterator::operator++): Rename from
9695         objfile_separate_debug_iterate.
9696         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
9697         iterator.
9698         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
9699         iterator.
9700
9701 2019-04-10  Tom Tromey  <tom@tromey.com>
9702
9703         * symfile.c (reread_symbols): Remove old comment.
9704         * objfiles.c (free_all_objfiles): Fix a typo.
9705
9706 2019-04-10  Tom Tromey  <tom@tromey.com>
9707
9708         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
9709         * minsyms.c (lookup_minimal_symbol): Use foreach.
9710         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
9711         (lookup_minimal_symbol_solib_trampoline): Likewise.
9712         * symfile.c (reread_symbols): Use foreach.
9713
9714 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
9715             Tom Tromey  <tromey@adacore.com>
9716
9717         PR rust/24414:
9718         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
9719         (rust_lex_int_test): Change "value" to be LONGEST.
9720         (rust_lex_tests): Add test for long integer literal.
9721
9722 2019-04-09  Tom Tromey  <tromey@adacore.com>
9723
9724         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
9725         to bool.
9726         (extended_remote_target::attach): Update.
9727         (remote_target::remote_notice_new_inferior): Update.
9728         (remote_target::add_current_inferior_and_thread): Update.
9729         * inferior.c (exit_inferior_1): Use "false".
9730         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
9731
9732 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
9733
9734         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
9735         the "start" command.
9736
9737 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
9738
9739         * python/py-inferior.c (infpy_thread_from_thread_handle):
9740         Adjust comments to reflect renaming of thread_from_thread_handle
9741         to thread_from_handle.  Adjust keywords.  Fix type error message.
9742         (inferior_object_methods): Add thread_from_handle.  Retain
9743         thread_from_thread_handle, but mark it as deprecated.
9744
9745 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
9746
9747         * gdbthread.h (find_thread_by_handle): Revise declaration.
9748         * thread.c (find_thread_by_handle): Likewise.  Adjust
9749         implementation too.
9750         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
9751         support for buffer objects as handles.
9752
9753 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
9754
9755         * python/py-infthread.c (thpy_thread_handle): New function.
9756         (thread_object_methods): Register thpy_thread_handle.
9757
9758 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
9759
9760         * gdbthread.h (thread_to_thread_handle): Declare.
9761         * thread.c (gdbtypes.h): Include.
9762         (thread_to_thread_handle): New function.
9763
9764         * target.h (struct target_ops): Add thread_info_to_thread_handle.
9765         (target_thread_info_to_thread_handle): Declare.
9766         * target.c (target_thread_info_to_thread_handle): New function.
9767         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
9768         * target-delegates.c: Regenerate.
9769
9770         * linux-thread-db.c (class thread_db_target): Add method
9771         thread_info_to_thread_handle.
9772         (thread_db_target::thread_info_to_thread_handle): Define.
9773         * remote.c (class remote_target): Add new method
9774         thread_info_to_thread_handle.
9775         (remote_target::thread_info_to_thread_handle): Define.
9776
9777 2019-04-08  Pedro Alves  <palves@redhat.com>
9778
9779         * common/common-exceptions.c (throw_exception): Don't create
9780         named object to throw; throw directly.
9781         (throw_it): Likewise.  Don't initialize gdb_exception::message
9782         here, with new; pass FMT and AP to the ctor instead.
9783         * common/common-exceptions.h: Include <string>.
9784         (gdb_exception::gdb_exception(enum return_reason, enum errors,
9785         const char *, va_list)): New ctor.  Use std::make_shared.
9786         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
9787         errors)): Delete.
9788         (gdb_exception_error::gdb_exception_error(enum errors, const char
9789         *, va_list)): New.
9790         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
9791         Add assertion.
9792         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
9793         errors)): Delete.
9794         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
9795         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
9796         Add assertion.
9797
9798 2019-04-08  Tom Tromey  <tom@tromey.com>
9799
9800         * valops.c (value_rtti_indirect_type): Replace throw_exception
9801         with throw.
9802         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
9803         with throw.
9804         * thread.c (thr_try_catch_cmd): Replace throw_exception with
9805         throw.
9806         * target.c (target_translate_tls_address): Replace throw_exception
9807         with throw.
9808         * stack.c (frame_apply_command_count): Replace throw_exception
9809         with throw.
9810         * solib-spu.c (append_ocl_sos): Replace throw_exception with
9811         throw.
9812         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
9813         with throw.
9814         * rs6000-tdep.c (rs6000_frame_cache)
9815         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
9816         * remote.c: Replace throw_exception with throw.
9817         * record-full.c (record_full_message, record_full_wait_1)
9818         (record_full_restore): Replace throw_exception with throw.
9819         * record-btrace.c:
9820         (get_thread_current_frame_id, record_btrace_start_replaying)
9821         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
9822         (cmd_record_btrace_start): Replace throw_exception with throw.
9823         * parse.c (parse_exp_in_context_1): Replace throw_exception with
9824         throw.
9825         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
9826         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
9827         * linespec.c:
9828         (find_linespec_symbols): Replace throw_exception with throw.
9829         * infrun.c (displaced_step_prepare, resume): Replace
9830         throw_exception with throw.
9831         * infcmd.c (post_create_inferior): Replace throw_exception with
9832         throw.
9833         * inf-loop.c (inferior_event_handler): Replace throw_exception
9834         with throw.
9835         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
9836         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
9837         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
9838         (get_prev_frame_always, get_frame_pc_if_available)
9839         (get_frame_address_in_block_if_available, get_frame_language):
9840         Replace throw_exception with throw.
9841         * frame-unwind.c (frame_unwind_try_unwinder): Replace
9842         throw_exception with throw.
9843         * eval.c (fetch_subexp_value, evaluate_var_value)
9844         (evaluate_funcall, evaluate_subexp_standard): Replace
9845         throw_exception with throw.
9846         * dwarf2loc.c (call_site_find_chain)
9847         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
9848         Replace throw_exception with throw.
9849         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
9850         with throw.
9851         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
9852         throw.
9853         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
9854         * completer.c (complete_line_internal): Replace throw_exception
9855         with throw.
9856         * compile/compile-object-run.c (compile_object_run): Replace
9857         throw_exception with throw.
9858         * cli/cli-script.c (process_next_line): Replace throw_exception
9859         with throw.
9860         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
9861         (btrace_enable, btrace_maint_update_pt_packets): Replace
9862         throw_exception with throw.
9863         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
9864         throw_exception with throw.
9865         * break-catch-throw.c (re_set_exception_catchpoint): Replace
9866         throw_exception with throw.
9867         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
9868         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
9869         * aarch64-tdep.c (aarch64_make_prologue_cache)
9870         (aarch64_make_stub_cache): Replace throw_exception with throw.
9871
9872 2019-04-08  Tom Tromey  <tom@tromey.com>
9873
9874         * common/common-exceptions.c (throw_exception): Rename from
9875         throw_exception_cxx.  Remove old copy.  Make argument const.
9876         (throw_it): Create and throw exception objects directly.
9877         * common/common-exceptions.h (throw_exception): Make argument
9878         const.
9879         (struct gdb_exception_error): Add constructor.
9880         (struct gdb_exception_quit): Add constructor.
9881
9882 2019-04-08  Tom Tromey  <tom@tromey.com>
9883
9884         * common/common-exceptions.h (exception_rethrow): Don't declare.
9885         (TRY_SJLJ): Update comment.
9886         (TRY, CATCH, END_CATCH): Remove.
9887         * common/common-exceptions.c (exception_rethrow): Remove.
9888
9889 2019-04-08  Tom Tromey  <tom@tromey.com>
9890
9891         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
9892         Remove.
9893         (gdb_exception_error): Rename from
9894         gdb_exception_RETURN_MASK_ERROR.
9895         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
9896         (gdb_quit_bad_alloc): Update.
9897         * aarch64-tdep.c: Update.
9898         * ada-lang.c: Update.
9899         * ada-typeprint.c: Update.
9900         * ada-valprint.c: Update.
9901         * amd64-tdep.c: Update.
9902         * arch-utils.c: Update.
9903         * break-catch-throw.c: Update.
9904         * breakpoint.c: Update.
9905         * btrace.c: Update.
9906         * c-varobj.c: Update.
9907         * cli/cli-cmds.c: Update.
9908         * cli/cli-interp.c: Update.
9909         * cli/cli-script.c: Update.
9910         * common/common-exceptions.c: Update.
9911         * common/new-op.c: Update.
9912         * common/selftest.c: Update.
9913         * compile/compile-c-symbols.c: Update.
9914         * compile/compile-cplus-symbols.c: Update.
9915         * compile/compile-object-load.c: Update.
9916         * compile/compile-object-run.c: Update.
9917         * completer.c: Update.
9918         * corelow.c: Update.
9919         * cp-abi.c: Update.
9920         * cp-support.c: Update.
9921         * cp-valprint.c: Update.
9922         * darwin-nat.c: Update.
9923         * disasm-selftests.c: Update.
9924         * dtrace-probe.c: Update.
9925         * dwarf-index-cache.c: Update.
9926         * dwarf-index-write.c: Update.
9927         * dwarf2-frame-tailcall.c: Update.
9928         * dwarf2-frame.c: Update.
9929         * dwarf2loc.c: Update.
9930         * dwarf2read.c: Update.
9931         * eval.c: Update.
9932         * event-loop.c: Update.
9933         * event-top.c: Update.
9934         * exec.c: Update.
9935         * f-valprint.c: Update.
9936         * fbsd-tdep.c: Update.
9937         * frame-unwind.c: Update.
9938         * frame.c: Update.
9939         * gdbtypes.c: Update.
9940         * gnu-v3-abi.c: Update.
9941         * guile/guile-internal.h: Update.
9942         * guile/scm-block.c: Update.
9943         * guile/scm-breakpoint.c: Update.
9944         * guile/scm-cmd.c: Update.
9945         * guile/scm-disasm.c: Update.
9946         * guile/scm-frame.c: Update.
9947         * guile/scm-lazy-string.c: Update.
9948         * guile/scm-math.c: Update.
9949         * guile/scm-param.c: Update.
9950         * guile/scm-ports.c: Update.
9951         * guile/scm-pretty-print.c: Update.
9952         * guile/scm-symbol.c: Update.
9953         * guile/scm-symtab.c: Update.
9954         * guile/scm-type.c: Update.
9955         * guile/scm-value.c: Update.
9956         * i386-linux-tdep.c: Update.
9957         * i386-tdep.c: Update.
9958         * inf-loop.c: Update.
9959         * infcall.c: Update.
9960         * infcmd.c: Update.
9961         * infrun.c: Update.
9962         * jit.c: Update.
9963         * language.c: Update.
9964         * linespec.c: Update.
9965         * linux-fork.c: Update.
9966         * linux-nat.c: Update.
9967         * linux-tdep.c: Update.
9968         * linux-thread-db.c: Update.
9969         * main.c: Update.
9970         * mi/mi-cmd-break.c: Update.
9971         * mi/mi-cmd-stack.c: Update.
9972         * mi/mi-interp.c: Update.
9973         * mi/mi-main.c: Update.
9974         * objc-lang.c: Update.
9975         * p-valprint.c: Update.
9976         * parse.c: Update.
9977         * ppc-linux-tdep.c: Update.
9978         * printcmd.c: Update.
9979         * python/py-arch.c: Update.
9980         * python/py-breakpoint.c: Update.
9981         * python/py-cmd.c: Update.
9982         * python/py-finishbreakpoint.c: Update.
9983         * python/py-frame.c: Update.
9984         * python/py-framefilter.c: Update.
9985         * python/py-gdb-readline.c: Update.
9986         * python/py-inferior.c: Update.
9987         * python/py-infthread.c: Update.
9988         * python/py-lazy-string.c: Update.
9989         * python/py-linetable.c: Update.
9990         * python/py-objfile.c: Update.
9991         * python/py-param.c: Update.
9992         * python/py-prettyprint.c: Update.
9993         * python/py-progspace.c: Update.
9994         * python/py-record-btrace.c: Update.
9995         * python/py-record.c: Update.
9996         * python/py-symbol.c: Update.
9997         * python/py-type.c: Update.
9998         * python/py-unwind.c: Update.
9999         * python/py-utils.c: Update.
10000         * python/py-value.c: Update.
10001         * python/python.c: Update.
10002         * record-btrace.c: Update.
10003         * record-full.c: Update.
10004         * remote-fileio.c: Update.
10005         * remote.c: Update.
10006         * riscv-tdep.c: Update.
10007         * rs6000-aix-tdep.c: Update.
10008         * rs6000-tdep.c: Update.
10009         * rust-exp.y: Update.
10010         * rust-lang.c: Update.
10011         * s390-tdep.c: Update.
10012         * selftest-arch.c: Update.
10013         * solib-dsbt.c: Update.
10014         * solib-frv.c: Update.
10015         * solib-spu.c: Update.
10016         * solib-svr4.c: Update.
10017         * solib.c: Update.
10018         * sparc64-linux-tdep.c: Update.
10019         * stack.c: Update.
10020         * symfile-mem.c: Update.
10021         * symmisc.c: Update.
10022         * target.c: Update.
10023         * thread.c: Update.
10024         * top.c: Update.
10025         * tracefile-tfile.c: Update.
10026         * tui/tui.c: Update.
10027         * typeprint.c: Update.
10028         * unittests/cli-utils-selftests.c: Update.
10029         * unittests/parse-connection-spec-selftests.c: Update.
10030         * valops.c: Update.
10031         * valprint.c: Update.
10032         * value.c: Update.
10033         * varobj.c: Update.
10034         * windows-nat.c: Update.
10035         * x86-linux-nat.c: Update.
10036         * xml-support.c: Update.
10037
10038 2019-04-08  Tom Tromey  <tom@tromey.com>
10039
10040         * xml-support.c: Use C++ exception handling.
10041         * x86-linux-nat.c: Use C++ exception handling.
10042         * windows-nat.c: Use C++ exception handling.
10043         * varobj.c: Use C++ exception handling.
10044         * value.c: Use C++ exception handling.
10045         * valprint.c: Use C++ exception handling.
10046         * valops.c: Use C++ exception handling.
10047         * unittests/parse-connection-spec-selftests.c: Use C++ exception
10048         handling.
10049         * unittests/cli-utils-selftests.c: Use C++ exception handling.
10050         * typeprint.c: Use C++ exception handling.
10051         * tui/tui.c: Use C++ exception handling.
10052         * tracefile-tfile.c: Use C++ exception handling.
10053         * top.c: Use C++ exception handling.
10054         * thread.c: Use C++ exception handling.
10055         * target.c: Use C++ exception handling.
10056         * symmisc.c: Use C++ exception handling.
10057         * symfile-mem.c: Use C++ exception handling.
10058         * stack.c: Use C++ exception handling.
10059         * sparc64-linux-tdep.c: Use C++ exception handling.
10060         * solib.c: Use C++ exception handling.
10061         * solib-svr4.c: Use C++ exception handling.
10062         * solib-spu.c: Use C++ exception handling.
10063         * solib-frv.c: Use C++ exception handling.
10064         * solib-dsbt.c: Use C++ exception handling.
10065         * selftest-arch.c: Use C++ exception handling.
10066         * s390-tdep.c: Use C++ exception handling.
10067         * rust-lang.c: Use C++ exception handling.
10068         * rust-exp.y: Use C++ exception handling.
10069         * rs6000-tdep.c: Use C++ exception handling.
10070         * rs6000-aix-tdep.c: Use C++ exception handling.
10071         * riscv-tdep.c: Use C++ exception handling.
10072         * remote.c: Use C++ exception handling.
10073         * remote-fileio.c: Use C++ exception handling.
10074         * record-full.c: Use C++ exception handling.
10075         * record-btrace.c: Use C++ exception handling.
10076         * python/python.c: Use C++ exception handling.
10077         * python/py-value.c: Use C++ exception handling.
10078         * python/py-utils.c: Use C++ exception handling.
10079         * python/py-unwind.c: Use C++ exception handling.
10080         * python/py-type.c: Use C++ exception handling.
10081         * python/py-symbol.c: Use C++ exception handling.
10082         * python/py-record.c: Use C++ exception handling.
10083         * python/py-record-btrace.c: Use C++ exception handling.
10084         * python/py-progspace.c: Use C++ exception handling.
10085         * python/py-prettyprint.c: Use C++ exception handling.
10086         * python/py-param.c: Use C++ exception handling.
10087         * python/py-objfile.c: Use C++ exception handling.
10088         * python/py-linetable.c: Use C++ exception handling.
10089         * python/py-lazy-string.c: Use C++ exception handling.
10090         * python/py-infthread.c: Use C++ exception handling.
10091         * python/py-inferior.c: Use C++ exception handling.
10092         * python/py-gdb-readline.c: Use C++ exception handling.
10093         * python/py-framefilter.c: Use C++ exception handling.
10094         * python/py-frame.c: Use C++ exception handling.
10095         * python/py-finishbreakpoint.c: Use C++ exception handling.
10096         * python/py-cmd.c: Use C++ exception handling.
10097         * python/py-breakpoint.c: Use C++ exception handling.
10098         * python/py-arch.c: Use C++ exception handling.
10099         * printcmd.c: Use C++ exception handling.
10100         * ppc-linux-tdep.c: Use C++ exception handling.
10101         * parse.c: Use C++ exception handling.
10102         * p-valprint.c: Use C++ exception handling.
10103         * objc-lang.c: Use C++ exception handling.
10104         * mi/mi-main.c: Use C++ exception handling.
10105         * mi/mi-interp.c: Use C++ exception handling.
10106         * mi/mi-cmd-stack.c: Use C++ exception handling.
10107         * mi/mi-cmd-break.c: Use C++ exception handling.
10108         * main.c: Use C++ exception handling.
10109         * linux-thread-db.c: Use C++ exception handling.
10110         * linux-tdep.c: Use C++ exception handling.
10111         * linux-nat.c: Use C++ exception handling.
10112         * linux-fork.c: Use C++ exception handling.
10113         * linespec.c: Use C++ exception handling.
10114         * language.c: Use C++ exception handling.
10115         * jit.c: Use C++ exception handling.
10116         * infrun.c: Use C++ exception handling.
10117         * infcmd.c: Use C++ exception handling.
10118         * infcall.c: Use C++ exception handling.
10119         * inf-loop.c: Use C++ exception handling.
10120         * i386-tdep.c: Use C++ exception handling.
10121         * i386-linux-tdep.c: Use C++ exception handling.
10122         * guile/scm-value.c: Use C++ exception handling.
10123         * guile/scm-type.c: Use C++ exception handling.
10124         * guile/scm-symtab.c: Use C++ exception handling.
10125         * guile/scm-symbol.c: Use C++ exception handling.
10126         * guile/scm-pretty-print.c: Use C++ exception handling.
10127         * guile/scm-ports.c: Use C++ exception handling.
10128         * guile/scm-param.c: Use C++ exception handling.
10129         * guile/scm-math.c: Use C++ exception handling.
10130         * guile/scm-lazy-string.c: Use C++ exception handling.
10131         * guile/scm-frame.c: Use C++ exception handling.
10132         * guile/scm-disasm.c: Use C++ exception handling.
10133         * guile/scm-cmd.c: Use C++ exception handling.
10134         * guile/scm-breakpoint.c: Use C++ exception handling.
10135         * guile/scm-block.c: Use C++ exception handling.
10136         * guile/guile-internal.h: Use C++ exception handling.
10137         * gnu-v3-abi.c: Use C++ exception handling.
10138         * gdbtypes.c: Use C++ exception handling.
10139         * frame.c: Use C++ exception handling.
10140         * frame-unwind.c: Use C++ exception handling.
10141         * fbsd-tdep.c: Use C++ exception handling.
10142         * f-valprint.c: Use C++ exception handling.
10143         * exec.c: Use C++ exception handling.
10144         * event-top.c: Use C++ exception handling.
10145         * event-loop.c: Use C++ exception handling.
10146         * eval.c: Use C++ exception handling.
10147         * dwarf2read.c: Use C++ exception handling.
10148         * dwarf2loc.c: Use C++ exception handling.
10149         * dwarf2-frame.c: Use C++ exception handling.
10150         * dwarf2-frame-tailcall.c: Use C++ exception handling.
10151         * dwarf-index-write.c: Use C++ exception handling.
10152         * dwarf-index-cache.c: Use C++ exception handling.
10153         * dtrace-probe.c: Use C++ exception handling.
10154         * disasm-selftests.c: Use C++ exception handling.
10155         * darwin-nat.c: Use C++ exception handling.
10156         * cp-valprint.c: Use C++ exception handling.
10157         * cp-support.c: Use C++ exception handling.
10158         * cp-abi.c: Use C++ exception handling.
10159         * corelow.c: Use C++ exception handling.
10160         * completer.c: Use C++ exception handling.
10161         * compile/compile-object-run.c: Use C++ exception handling.
10162         * compile/compile-object-load.c: Use C++ exception handling.
10163         * compile/compile-cplus-symbols.c: Use C++ exception handling.
10164         * compile/compile-c-symbols.c: Use C++ exception handling.
10165         * common/selftest.c: Use C++ exception handling.
10166         * common/new-op.c: Use C++ exception handling.
10167         * cli/cli-script.c: Use C++ exception handling.
10168         * cli/cli-interp.c: Use C++ exception handling.
10169         * cli/cli-cmds.c: Use C++ exception handling.
10170         * c-varobj.c: Use C++ exception handling.
10171         * btrace.c: Use C++ exception handling.
10172         * breakpoint.c: Use C++ exception handling.
10173         * break-catch-throw.c: Use C++ exception handling.
10174         * arch-utils.c: Use C++ exception handling.
10175         * amd64-tdep.c: Use C++ exception handling.
10176         * ada-valprint.c: Use C++ exception handling.
10177         * ada-typeprint.c: Use C++ exception handling.
10178         * ada-lang.c: Use C++ exception handling.
10179         * aarch64-tdep.c: Use C++ exception handling.
10180
10181 2019-04-08  Tom Tromey  <tom@tromey.com>
10182
10183         * xml-support.c (gdb_xml_parser::parse): Update.
10184         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
10185         * value.c (show_convenience): Update.
10186         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
10187         (test_parse_flags_qcs): Update.
10188         * thread.c (thr_try_catch_cmd): Update.
10189         * target.c (target_translate_tls_address): Update.
10190         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
10191         (info_frame_command_core, frame_apply_command_count): Update.
10192         * rust-exp.y (rust_lex_exception_test): Update.
10193         * riscv-tdep.c (riscv_print_one_register_info): Update.
10194         * remote.c (remote_target::enable_btrace): Update.
10195         * record-btrace.c (record_btrace_enable_warn): Update.
10196         * python/py-utils.c (gdbpy_convert_exception): Update.
10197         * printcmd.c (do_one_display, print_variable_and_value): Update.
10198         * mi/mi-main.c (mi_print_exception): Update.
10199         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
10200         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
10201         * linux-nat.c (linux_nat_target::attach): Update.
10202         * linux-fork.c (class scoped_switch_fork_info): Update.
10203         * infrun.c (displaced_step_prepare): Update.
10204         * infcall.c (call_function_by_hand_dummy): Update.
10205         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
10206         * gnu-v3-abi.c (print_one_vtable): Update.
10207         * frame.c (get_prev_frame_always): Update.
10208         * f-valprint.c (info_common_command_for_block): Update.
10209         * exec.c (try_open_exec_file): Update.
10210         * exceptions.c (print_exception, exception_print)
10211         (exception_fprintf, exception_print_same): Update.
10212         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
10213         * dwarf-index-cache.c (index_cache::store)
10214         (index_cache::lookup_gdb_index): Update.
10215         * darwin-nat.c (maybe_cache_shell): Update.
10216         * cp-valprint.c (cp_print_value_fields): Update.
10217         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
10218         (gcc_cplus_symbol_address): Update.
10219         * compile/compile-c-symbols.c (gcc_convert_symbol)
10220         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
10221         * common/selftest.c: Update.
10222         * common/common-exceptions.h (struct gdb_exception) <message>: Now
10223         a std::string.
10224         (exception_try_scope_entry, exception_try_scope_exit): Don't
10225         declare.
10226         (struct exception_try_scope): Remove.
10227         (TRY): Don't use exception_try_scope.
10228         (struct gdb_exception): Add constructor, operator=.
10229         <what>: New method.
10230         (struct gdb_exception_RETURN_MASK_ALL)
10231         (struct gdb_exception_RETURN_MASK_ERROR)
10232         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
10233         (struct gdb_quit_bad_alloc): Update.
10234         * common/common-exceptions.c (exception_none): Change
10235         initializer.
10236         (struct catcher) <state, exception>: Initialize inline.
10237         <prev>: Remove member.
10238         (current_catcher): Remove.
10239         (catchers): New global.
10240         (exceptions_state_mc_init): Simplify.
10241         (catcher_pop): Remove.
10242         (exceptions_state_mc, exceptions_state_mc_catch): Update.
10243         (try_scope_depth, exception_try_scope_entry)
10244         (exception_try_scope_exit): Remove.
10245         (throw_exception_sjlj): Update.
10246         (exception_messages, exception_messages_size): Remove.
10247         (throw_it): Simplify.
10248         (gdb_exception_sliced_copy): Remove.
10249         (throw_exception_cxx): Update.
10250         * cli/cli-script.c (script_from_file): Update.
10251         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
10252         Update.
10253         * ada-valprint.c (ada_val_print): Update.
10254         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
10255         (create_excep_cond_exprs): Update.
10256
10257 2019-04-08  Tom Tromey  <tom@tromey.com>
10258
10259         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
10260         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
10261         (TRY, CATCH, END_CATCH): Remove some definitions.
10262         * common/common-exceptions.c: Don't use GDB_XCPT.
10263         (catcher_list_size): Remove.
10264         (throw_exception, throw_it): Simplify.
10265
10266 2019-04-05  Tom Tromey  <tom@tromey.com>
10267
10268         Revert the header-sorting patch.
10269         * ft32-tdep.c: Revert.
10270         * frv-tdep.c: Revert.
10271         * frv-linux-tdep.c: Revert.
10272         * frame.c: Revert.
10273         * frame-unwind.c: Revert.
10274         * frame-base.c: Revert.
10275         * fork-child.c: Revert.
10276         * findvar.c: Revert.
10277         * findcmd.c: Revert.
10278         * filesystem.c: Revert.
10279         * filename-seen-cache.h: Revert.
10280         * filename-seen-cache.c: Revert.
10281         * fbsd-tdep.c: Revert.
10282         * fbsd-nat.h: Revert.
10283         * fbsd-nat.c: Revert.
10284         * f-valprint.c: Revert.
10285         * f-typeprint.c: Revert.
10286         * f-lang.c: Revert.
10287         * extension.h: Revert.
10288         * extension.c: Revert.
10289         * extension-priv.h: Revert.
10290         * expprint.c: Revert.
10291         * exec.h: Revert.
10292         * exec.c: Revert.
10293         * exceptions.c: Revert.
10294         * event-top.c: Revert.
10295         * event-loop.c: Revert.
10296         * eval.c: Revert.
10297         * elfread.c: Revert.
10298         * dwarf2read.h: Revert.
10299         * dwarf2read.c: Revert.
10300         * dwarf2loc.c: Revert.
10301         * dwarf2expr.h: Revert.
10302         * dwarf2expr.c: Revert.
10303         * dwarf2-frame.c: Revert.
10304         * dwarf2-frame-tailcall.c: Revert.
10305         * dwarf-index-write.h: Revert.
10306         * dwarf-index-write.c: Revert.
10307         * dwarf-index-common.c: Revert.
10308         * dwarf-index-cache.h: Revert.
10309         * dwarf-index-cache.c: Revert.
10310         * dummy-frame.c: Revert.
10311         * dtrace-probe.c: Revert.
10312         * disasm.h: Revert.
10313         * disasm.c: Revert.
10314         * disasm-selftests.c: Revert.
10315         * dictionary.c: Revert.
10316         * dicos-tdep.c: Revert.
10317         * demangle.c: Revert.
10318         * dcache.h: Revert.
10319         * dcache.c: Revert.
10320         * darwin-nat.h: Revert.
10321         * darwin-nat.c: Revert.
10322         * darwin-nat-info.c: Revert.
10323         * d-valprint.c: Revert.
10324         * d-namespace.c: Revert.
10325         * d-lang.c: Revert.
10326         * ctf.c: Revert.
10327         * csky-tdep.c: Revert.
10328         * csky-linux-tdep.c: Revert.
10329         * cris-tdep.c: Revert.
10330         * cris-linux-tdep.c: Revert.
10331         * cp-valprint.c: Revert.
10332         * cp-support.c: Revert.
10333         * cp-namespace.c: Revert.
10334         * cp-abi.c: Revert.
10335         * corelow.c: Revert.
10336         * corefile.c: Revert.
10337         * continuations.c: Revert.
10338         * completer.h: Revert.
10339         * completer.c: Revert.
10340         * complaints.c: Revert.
10341         * coffread.c: Revert.
10342         * coff-pe-read.c: Revert.
10343         * cli-out.h: Revert.
10344         * cli-out.c: Revert.
10345         * charset.c: Revert.
10346         * c-varobj.c: Revert.
10347         * c-valprint.c: Revert.
10348         * c-typeprint.c: Revert.
10349         * c-lang.c: Revert.
10350         * buildsym.c: Revert.
10351         * buildsym-legacy.c: Revert.
10352         * build-id.h: Revert.
10353         * build-id.c: Revert.
10354         * btrace.c: Revert.
10355         * bsd-uthread.c: Revert.
10356         * breakpoint.h: Revert.
10357         * breakpoint.c: Revert.
10358         * break-catch-throw.c: Revert.
10359         * break-catch-syscall.c: Revert.
10360         * break-catch-sig.c: Revert.
10361         * blockframe.c: Revert.
10362         * block.c: Revert.
10363         * bfin-tdep.c: Revert.
10364         * bfin-linux-tdep.c: Revert.
10365         * bfd-target.c: Revert.
10366         * bcache.c: Revert.
10367         * ax-general.c: Revert.
10368         * ax-gdb.h: Revert.
10369         * ax-gdb.c: Revert.
10370         * avr-tdep.c: Revert.
10371         * auxv.c: Revert.
10372         * auto-load.c: Revert.
10373         * arm-wince-tdep.c: Revert.
10374         * arm-tdep.c: Revert.
10375         * arm-symbian-tdep.c: Revert.
10376         * arm-pikeos-tdep.c: Revert.
10377         * arm-obsd-tdep.c: Revert.
10378         * arm-nbsd-tdep.c: Revert.
10379         * arm-nbsd-nat.c: Revert.
10380         * arm-linux-tdep.c: Revert.
10381         * arm-linux-nat.c: Revert.
10382         * arm-fbsd-tdep.c: Revert.
10383         * arm-fbsd-nat.c: Revert.
10384         * arm-bsd-tdep.c: Revert.
10385         * arch-utils.c: Revert.
10386         * arc-tdep.c: Revert.
10387         * arc-newlib-tdep.c: Revert.
10388         * annotate.h: Revert.
10389         * annotate.c: Revert.
10390         * amd64-windows-tdep.c: Revert.
10391         * amd64-windows-nat.c: Revert.
10392         * amd64-tdep.c: Revert.
10393         * amd64-sol2-tdep.c: Revert.
10394         * amd64-obsd-tdep.c: Revert.
10395         * amd64-obsd-nat.c: Revert.
10396         * amd64-nbsd-tdep.c: Revert.
10397         * amd64-nbsd-nat.c: Revert.
10398         * amd64-nat.c: Revert.
10399         * amd64-linux-tdep.c: Revert.
10400         * amd64-linux-nat.c: Revert.
10401         * amd64-fbsd-tdep.c: Revert.
10402         * amd64-fbsd-nat.c: Revert.
10403         * amd64-dicos-tdep.c: Revert.
10404         * amd64-darwin-tdep.c: Revert.
10405         * amd64-bsd-nat.c: Revert.
10406         * alpha-tdep.c: Revert.
10407         * alpha-obsd-tdep.c: Revert.
10408         * alpha-nbsd-tdep.c: Revert.
10409         * alpha-mdebug-tdep.c: Revert.
10410         * alpha-linux-tdep.c: Revert.
10411         * alpha-linux-nat.c: Revert.
10412         * alpha-bsd-tdep.c: Revert.
10413         * alpha-bsd-nat.c: Revert.
10414         * aix-thread.c: Revert.
10415         * agent.c: Revert.
10416         * addrmap.c: Revert.
10417         * ada-varobj.c: Revert.
10418         * ada-valprint.c: Revert.
10419         * ada-typeprint.c: Revert.
10420         * ada-tasks.c: Revert.
10421         * ada-lang.c: Revert.
10422         * aarch64-tdep.c: Revert.
10423         * aarch64-ravenscar-thread.c: Revert.
10424         * aarch64-newlib-tdep.c: Revert.
10425         * aarch64-linux-tdep.c: Revert.
10426         * aarch64-linux-nat.c: Revert.
10427         * aarch64-fbsd-tdep.c: Revert.
10428         * aarch64-fbsd-nat.c: Revert.
10429         * aarch32-linux-nat.c: Revert.
10430
10431 2019-04-05  Tom Tromey  <tom@tromey.com>
10432
10433         * ft32-tdep.c: Sort headers.
10434         * frv-tdep.c: Sort headers.
10435         * frv-linux-tdep.c: Sort headers.
10436         * frame.c: Sort headers.
10437         * frame-unwind.c: Sort headers.
10438         * frame-base.c: Sort headers.
10439         * fork-child.c: Sort headers.
10440         * findvar.c: Sort headers.
10441         * findcmd.c: Sort headers.
10442         * filesystem.c: Sort headers.
10443         * filename-seen-cache.h: Sort headers.
10444         * filename-seen-cache.c: Sort headers.
10445         * fbsd-tdep.c: Sort headers.
10446         * fbsd-nat.h: Sort headers.
10447         * fbsd-nat.c: Sort headers.
10448         * f-valprint.c: Sort headers.
10449         * f-typeprint.c: Sort headers.
10450         * f-lang.c: Sort headers.
10451         * extension.h: Sort headers.
10452         * extension.c: Sort headers.
10453         * extension-priv.h: Sort headers.
10454         * expprint.c: Sort headers.
10455         * exec.h: Sort headers.
10456         * exec.c: Sort headers.
10457         * exceptions.c: Sort headers.
10458         * event-top.c: Sort headers.
10459         * event-loop.c: Sort headers.
10460         * eval.c: Sort headers.
10461         * elfread.c: Sort headers.
10462         * dwarf2read.h: Sort headers.
10463         * dwarf2read.c: Sort headers.
10464         * dwarf2loc.c: Sort headers.
10465         * dwarf2expr.h: Sort headers.
10466         * dwarf2expr.c: Sort headers.
10467         * dwarf2-frame.c: Sort headers.
10468         * dwarf2-frame-tailcall.c: Sort headers.
10469         * dwarf-index-write.h: Sort headers.
10470         * dwarf-index-write.c: Sort headers.
10471         * dwarf-index-common.c: Sort headers.
10472         * dwarf-index-cache.h: Sort headers.
10473         * dwarf-index-cache.c: Sort headers.
10474         * dummy-frame.c: Sort headers.
10475         * dtrace-probe.c: Sort headers.
10476         * disasm.h: Sort headers.
10477         * disasm.c: Sort headers.
10478         * disasm-selftests.c: Sort headers.
10479         * dictionary.c: Sort headers.
10480         * dicos-tdep.c: Sort headers.
10481         * demangle.c: Sort headers.
10482         * dcache.h: Sort headers.
10483         * dcache.c: Sort headers.
10484         * darwin-nat.h: Sort headers.
10485         * darwin-nat.c: Sort headers.
10486         * darwin-nat-info.c: Sort headers.
10487         * d-valprint.c: Sort headers.
10488         * d-namespace.c: Sort headers.
10489         * d-lang.c: Sort headers.
10490         * ctf.c: Sort headers.
10491         * csky-tdep.c: Sort headers.
10492         * csky-linux-tdep.c: Sort headers.
10493         * cris-tdep.c: Sort headers.
10494         * cris-linux-tdep.c: Sort headers.
10495         * cp-valprint.c: Sort headers.
10496         * cp-support.c: Sort headers.
10497         * cp-namespace.c: Sort headers.
10498         * cp-abi.c: Sort headers.
10499         * corelow.c: Sort headers.
10500         * corefile.c: Sort headers.
10501         * continuations.c: Sort headers.
10502         * completer.h: Sort headers.
10503         * completer.c: Sort headers.
10504         * complaints.c: Sort headers.
10505         * coffread.c: Sort headers.
10506         * coff-pe-read.c: Sort headers.
10507         * cli-out.h: Sort headers.
10508         * cli-out.c: Sort headers.
10509         * charset.c: Sort headers.
10510         * c-varobj.c: Sort headers.
10511         * c-valprint.c: Sort headers.
10512         * c-typeprint.c: Sort headers.
10513         * c-lang.c: Sort headers.
10514         * buildsym.c: Sort headers.
10515         * buildsym-legacy.c: Sort headers.
10516         * build-id.h: Sort headers.
10517         * build-id.c: Sort headers.
10518         * btrace.c: Sort headers.
10519         * bsd-uthread.c: Sort headers.
10520         * breakpoint.h: Sort headers.
10521         * breakpoint.c: Sort headers.
10522         * break-catch-throw.c: Sort headers.
10523         * break-catch-syscall.c: Sort headers.
10524         * break-catch-sig.c: Sort headers.
10525         * blockframe.c: Sort headers.
10526         * block.c: Sort headers.
10527         * bfin-tdep.c: Sort headers.
10528         * bfin-linux-tdep.c: Sort headers.
10529         * bfd-target.c: Sort headers.
10530         * bcache.c: Sort headers.
10531         * ax-general.c: Sort headers.
10532         * ax-gdb.h: Sort headers.
10533         * ax-gdb.c: Sort headers.
10534         * avr-tdep.c: Sort headers.
10535         * auxv.c: Sort headers.
10536         * auto-load.c: Sort headers.
10537         * arm-wince-tdep.c: Sort headers.
10538         * arm-tdep.c: Sort headers.
10539         * arm-symbian-tdep.c: Sort headers.
10540         * arm-pikeos-tdep.c: Sort headers.
10541         * arm-obsd-tdep.c: Sort headers.
10542         * arm-nbsd-tdep.c: Sort headers.
10543         * arm-nbsd-nat.c: Sort headers.
10544         * arm-linux-tdep.c: Sort headers.
10545         * arm-linux-nat.c: Sort headers.
10546         * arm-fbsd-tdep.c: Sort headers.
10547         * arm-fbsd-nat.c: Sort headers.
10548         * arm-bsd-tdep.c: Sort headers.
10549         * arch-utils.c: Sort headers.
10550         * arc-tdep.c: Sort headers.
10551         * arc-newlib-tdep.c: Sort headers.
10552         * annotate.h: Sort headers.
10553         * annotate.c: Sort headers.
10554         * amd64-windows-tdep.c: Sort headers.
10555         * amd64-windows-nat.c: Sort headers.
10556         * amd64-tdep.c: Sort headers.
10557         * amd64-sol2-tdep.c: Sort headers.
10558         * amd64-obsd-tdep.c: Sort headers.
10559         * amd64-obsd-nat.c: Sort headers.
10560         * amd64-nbsd-tdep.c: Sort headers.
10561         * amd64-nbsd-nat.c: Sort headers.
10562         * amd64-nat.c: Sort headers.
10563         * amd64-linux-tdep.c: Sort headers.
10564         * amd64-linux-nat.c: Sort headers.
10565         * amd64-fbsd-tdep.c: Sort headers.
10566         * amd64-fbsd-nat.c: Sort headers.
10567         * amd64-dicos-tdep.c: Sort headers.
10568         * amd64-darwin-tdep.c: Sort headers.
10569         * amd64-bsd-nat.c: Sort headers.
10570         * alpha-tdep.c: Sort headers.
10571         * alpha-obsd-tdep.c: Sort headers.
10572         * alpha-nbsd-tdep.c: Sort headers.
10573         * alpha-mdebug-tdep.c: Sort headers.
10574         * alpha-linux-tdep.c: Sort headers.
10575         * alpha-linux-nat.c: Sort headers.
10576         * alpha-bsd-tdep.c: Sort headers.
10577         * alpha-bsd-nat.c: Sort headers.
10578         * aix-thread.c: Sort headers.
10579         * agent.c: Sort headers.
10580         * addrmap.c: Sort headers.
10581         * ada-varobj.c: Sort headers.
10582         * ada-valprint.c: Sort headers.
10583         * ada-typeprint.c: Sort headers.
10584         * ada-tasks.c: Sort headers.
10585         * ada-lang.c: Sort headers.
10586         * aarch64-tdep.c: Sort headers.
10587         * aarch64-ravenscar-thread.c: Sort headers.
10588         * aarch64-newlib-tdep.c: Sort headers.
10589         * aarch64-linux-tdep.c: Sort headers.
10590         * aarch64-linux-nat.c: Sort headers.
10591         * aarch64-fbsd-tdep.c: Sort headers.
10592         * aarch64-fbsd-nat.c: Sort headers.
10593         * aarch32-linux-nat.c: Sort headers.
10594
10595 2019-04-04  Tom Tromey  <tom@tromey.com>
10596
10597         * varobj.c (varobj_create): Update.
10598         * rust-exp.y (struct rust_parser) <update_innermost_block,
10599         lookup_symbol>: New methods.
10600         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
10601         Rename.
10602         (rust_parser::rust_lookup_type)
10603         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
10604         * printcmd.c (display_command, do_one_display): Update.
10605         * parser-defs.h (struct parser_state) <parser_state>: Add
10606         "tracker" parameter.
10607         (block_tracker): New member.
10608         (class innermost_block_tracker) <innermost_block_tracker>: Add
10609         "types" parameter.
10610         <reset>: Remove method.
10611         (innermost_block): Don't declare.
10612         (null_post_parser): Update.
10613         * parse.c (innermost_block): Remove global.
10614         (write_dollar_variable): Update.
10615         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
10616         Remove "tracker_types" parameter.
10617         (parse_expression): Add "tracker" parameter.
10618         (parse_expression_for_completion): Update.
10619         (null_post_parser): Add "tracker" parameter.
10620         * p-exp.y: Update rules.
10621         * m2-exp.y: Update rules.
10622         * language.h (struct language_defn) <la_post_parser>: Add
10623         "tracker" parameter.
10624         * go-exp.y: Update rules.
10625         * f-exp.y: Update rules.
10626         * expression.h (parse_expression, parse_exp_1): Add "tracker"
10627         parameter.
10628         * d-exp.y: Update rules.
10629         * c-exp.y: Update rules.
10630         * breakpoint.c (set_breakpoint_condition): Create an
10631         innermost_block_tracker.
10632         (watch_command_1): Likewise.
10633         * ada-lang.c (resolve): Add "tracker" parameter.
10634         (resolve_subexp): Likewise.
10635         * ada-exp.y (write_var_from_sym): Update.
10636
10637 2019-04-04  Tom Tromey  <tom@tromey.com>
10638
10639         * type-stack.h: New file.
10640         * type-stack.c: New file.
10641         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
10642         type-stack.h.
10643         (insert_into_type_stack, insert_type, push_type, push_type_int)
10644         (insert_type_address_space, pop_type, pop_type_int)
10645         (pop_typelist, pop_type_stack, append_type_stack)
10646         (push_type_stack, get_type_stack, push_typelist)
10647         (follow_type_instance_flags, follow_types): Don't declare.
10648         * parse.c (type_stack): Remove global.
10649         (parse_exp_in_context): Update.
10650         (insert_into_type_stack, insert_type, push_type, push_type_int)
10651         (insert_type_address_space, pop_type, pop_type_int)
10652         (pop_typelist, pop_type_stack, append_type_stack)
10653         (push_type_stack, get_type_stack, push_typelist)
10654         (follow_type_instance_flags, follow_types): Remove (moved to
10655         type-stack.c).
10656         * f-exp.y (type_stack): New global.
10657         Update rules.
10658         (push_kind_type, f_parse): Update.
10659         * d-exp.y (type_stack): New global.
10660         Update rules.
10661         (d_parse): Update.
10662         * c-exp.y (struct c_parse_state) <type_stack>: New member.
10663         Update rules.
10664         * Makefile.in (COMMON_SFILES): Add type-stack.c.
10665         (HFILES_NO_SRCDIR): Add type-stack.h.
10666
10667 2019-04-04  Tom Tromey  <tom@tromey.com>
10668
10669         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
10670         (rust_parser::convert_ast_to_expression, rust_parse)
10671         (rust_lex_test_completion, rust_lex_tests): Update.
10672         * parser-defs.h (struct expr_completion_state): New.
10673         (struct parser_state) <parser_state>: Add completion parameter.
10674         <mark_struct_expression, mark_completion_tag>: New methods.
10675         <parse_completion, m_completion_state>: New members.
10676         (prefixify_expression, null_post_parser): Update.
10677         (mark_struct_expression, mark_completion_tag): Don't declare.
10678         * parse.c (parse_completion, expout_last_struct)
10679         (expout_tag_completion_type, expout_completion_name): Remove
10680         globals.
10681         (parser_state::mark_struct_expression)
10682         (parser_state::mark_completion_tag): Now methods.
10683         (prefixify_expression): Add last_struct parameter.
10684         (prefixify_subexp): Likewise.
10685         (parse_exp_1): Update.
10686         (parse_exp_in_context): Add cstate parameter.  Update.
10687         (parse_expression_for_completion): Create an
10688         expr_completion_state.
10689         (null_post_parser): Add "completion" parameter.
10690         * p-exp.y: Update rules.
10691         (yylex): Update.
10692         * language.h (struct language_defn) <la_post_parser>: Add
10693         "completing" parameter.
10694         * go-exp.y: Update rules.
10695         (lex_one_token): Update.
10696         * expression.h (parse_completion): Don't declare.
10697         * d-exp.y: Update rules.
10698         (lex_one_token): Update rules.
10699         * c-exp.y: Update rules.
10700         (lex_one_token): Update.
10701         * ada-lang.c (resolve): Add "parse_completion" parameter.
10702         (resolve_subexp): Likewise.
10703         (ada_resolve_function): Likewise.
10704
10705 2019-04-04  Tom Tromey  <tom@tromey.com>
10706
10707         * parser-defs.h (struct parser_state) <start_arglist,
10708         end_arglist>: New methods.
10709         <arglist_len, m_funcall_chain>: New members.
10710         (arglist_len, start_arglist, end_arglist): Don't declare.
10711         * parse.c (arglist_len, funcall_chain): Remove global.
10712         (start_arglist, end_arglist): Remove functions.
10713         (parse_exp_in_context): Update.
10714         * p-exp.y: Update rules.
10715         * m2-exp.y: Update rules.
10716         * go-exp.y: Update rules.
10717         * f-exp.y: Update rules.
10718         * d-exp.y: Update rules.
10719         * c-exp.y: Update rules.
10720
10721 2019-04-04  Tom Tromey  <tom@tromey.com>
10722
10723         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
10724         lex_operator, push_back>: New methods.
10725         Update all rules.
10726         (rust_parser::lex_hex, lex_escape): Rename and update.
10727         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
10728         (rust_parser::lex_operator): Rename and update.
10729         (rust_parser::lex_number, rustyylex, rustyyerror)
10730         (rust_lex_test_init, rust_lex_test_sequence)
10731         (rust_lex_test_push_back, rust_lex_tests): Update.
10732         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
10733         parameter.
10734         <lexptr, prev_lexptr>: New members.
10735         (lexptr, prev_lexptr): Don't declare.
10736         * parse.c (lexptr, prev_lexptr): Remove globals.
10737         (parse_exp_in_context): Update.
10738         * p-exp.y (yylex, yyerror): Update.
10739         * m2-exp.y (parse_number, yylex, yyerror): Update.
10740         * go-exp.y (lex_one_token, yyerror): Update.
10741         * f-exp.y (match_string_literal, yylex, yyerror): Update.
10742         * d-exp.y (lex_one_token, yyerror): Update.
10743         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
10744         (lex_one_token, yyerror): Update.
10745         * ada-lex.l (YY_INPUT): Update.
10746         (rewind_to_char): Update.
10747         * ada-exp.y (yyerror): Update.
10748
10749 2019-04-04  Tom Tromey  <tom@tromey.com>
10750
10751         * rust-exp.y (rustyylex, rust_lex_tests): Update.
10752         * parser-defs.h (struct parser_state) <parser_state>: Add new
10753         parameter.
10754         <comma_terminates>: New member.
10755         (comma_terminates): Don't declare global.
10756         * parse.c (comma_terminates): Remove global.
10757         (parse_exp_in_context): Update.
10758         * p-exp.y (yylex): Update.
10759         * m2-exp.y (yylex): Update.
10760         * go-exp.y (lex_one_token): Update.
10761         * f-exp.y (yylex): Update.
10762         * d-exp.y (lex_one_token): Update.
10763         * c-exp.y (lex_one_token): Update.
10764         * ada-lex.l: Update.
10765
10766 2019-04-04  Tom Tromey  <tom@tromey.com>
10767
10768         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
10769         (rustyylex, rust_lex_test_init, rust_lex_test_one)
10770         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
10771         * parser-defs.h (paren_depth): Don't declare.
10772         * parse.c (paren_depth): Remove global.
10773         (parse_exp_in_context): Update.
10774         * p-exp.y (paren_depth): New global.
10775         (pascal_parse): Initialize it.
10776         * m2-exp.y (paren_depth): New global.
10777         (m2_parse): Initialize it.
10778         * go-exp.y (paren_depth): New global.
10779         (go_parse): Initialize it.
10780         * f-exp.y (paren_depth): New global.
10781         (f_parse): Initialize it.
10782         * d-exp.y (paren_depth): New global.
10783         (d_parse): Initialize it.
10784         * c-exp.y (paren_depth): New global.
10785         (c_parse): Initialize it.
10786         * ada-lex.l (paren_depth): New global.
10787         (lexer_init): Initialize it.
10788
10789 2019-04-04  Tom Tromey  <tom@tromey.com>
10790
10791         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
10792         (rust_parser::convert_ast_to_type)
10793         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
10794         * parser-defs.h (struct parser_state) <parser_state>: Add
10795         parameters.  Initialize new members.
10796         <expression_context_block, expression_context_pc>: New members.
10797         * parse.c (expression_context_block, expression_context_pc):
10798         Remove globals.
10799         (parse_exp_in_context): Update.
10800         * p-exp.y: Update all rules.
10801         (yylex): Update.
10802         * m2-exp.y: Update all rules.
10803         (yylex): Update.
10804         * go-exp.y (yylex): Update.
10805         * f-exp.y (yylex): Update.
10806         * d-exp.y: Update all rules.
10807         (yylex): Update.
10808         * c-exp.y: Update all rules.
10809         (lex_one_token, classify_name, yylex, c_parse): Update.
10810         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
10811
10812 2019-04-04  Tom Tromey  <tom@tromey.com>
10813
10814         * gdbarch.h, gdbarch.c: Rebuild.
10815         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
10816         * stap-probe.h:
10817         (struct stap_parse_info): Replace "parser_state" with
10818         "expr_builder".
10819         * parser-defs.h (struct expr_builder): Rename from "parser_state".
10820         (parser_state): New class.
10821         * parse.c (expr_builder): Rename.
10822         (expr_builder::release): Rename.
10823         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
10824         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
10825         (write_exp_elt_longcst, write_exp_elt_floatcst)
10826         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
10827         (write_exp_string_vector, write_exp_bitstring)
10828         (write_exp_msymbol, mark_struct_expression)
10829         (write_dollar_variable)
10830         (insert_type_address_space, increase_expout_size): Replace
10831         "parser_state" with "expr_builder".
10832         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
10833         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
10834         "parser_state" with "expr_builder".
10835
10836 2019-04-04  Tom Tromey  <tom@tromey.com>
10837
10838         * rust-exp.y: Replace "parse_language" with method call.
10839         * p-exp.y:
10840         (yylex): Replace "parse_language" with method call.
10841         * m2-exp.y:
10842         (yylex): Replace "parse_language" with method call.
10843         * go-exp.y (classify_name): Replace "parse_language" with method
10844         call.
10845         * f-exp.y (yylex): Replace "parse_language" with method call.
10846         * d-exp.y (lex_one_token): Replace "parse_language" with method
10847         call.
10848         * c-exp.y:
10849         (lex_one_token, classify_name, yylex): Replace "parse_language"
10850         with method call.
10851         * ada-exp.y (find_primitive_type, type_char)
10852         (type_system_address): Replace "parse_language" with method call.
10853
10854 2019-04-04  Tom Tromey  <tom@tromey.com>
10855
10856         * rust-exp.y: Replace "parse_gdbarch" with method call.
10857         * parse.c (write_dollar_variable, insert_type_address_space):
10858         Replace "parse_gdbarch" with method call.
10859         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
10860         call.
10861         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
10862         call.
10863         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
10864         "parse_gdbarch" with method call.
10865         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
10866         with method call.
10867         * f-exp.y (parse_type, parse_f_type, yylex): Replace
10868         "parse_gdbarch" with method call.
10869         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
10870         "parse_gdbarch" with method call.
10871         * c-exp.y (parse_type, parse_number, classify_name): Replace
10872         "parse_gdbarch" with method call.
10873         * ada-lex.l: Replace "parse_gdbarch" with method call.
10874         * ada-exp.y (parse_type, find_primitive_type, type_char)
10875         (type_system_address): Replace "parse_gdbarch" with method call.
10876
10877 2019-04-04  Tom Tromey  <tom@tromey.com>
10878
10879         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
10880         * stap-probe.c (stap_parse_argument): Update.
10881         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
10882         initial_size parameter.
10883         * rust-exp.y (rust_lex_tests): Update.
10884         * parse.c (parser_state): Update.
10885         (parse_exp_in_context): Update.
10886         * parser-defs.h (struct parser_state) <parser_state>: Remove
10887         "initial_size" parameter.
10888
10889 2019-04-04  Tom Tromey  <tom@tromey.com>
10890
10891         * parser-defs.h (increase_expout_size): Don't declare.
10892         * parse.c (increase_expout_size): Now static.
10893
10894 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
10895
10896         * gnu-nat.c (gnu_nat_target::wait): Fix
10897         target_waitstatus_to_string call.
10898
10899 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
10900
10901         * eval.c (evaluate_subexp_standard): Handle internal functions
10902         during Fortran function call handling.
10903
10904 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
10905
10906         * NEWS: Mention new internal functions.
10907         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
10908         (read_base_type): Use dwarf2_init_complex_target_type.
10909         * value.c (creal_internal_fn): New function.
10910         (cimag_internal_fn): New function.
10911         (_initialize_values): Register new internal functions.
10912
10913 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10914
10915         * infrun.c (stop_all_threads): If debug_infrun, always
10916         trace the wait status after wait_one, using
10917         target_waitstatus_to_string and target_pid_to_str.
10918         (handle_inferior_event): Replace various trace of
10919         wait status kind by a single trace.
10920         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
10921         wait status kind image by target_waitstatus_to_string.
10922         * target/waitstatus.c (target_waitstatus_to_string): Fix
10923         obsolete comment.
10924
10925 2019-04-01  Tom Tromey  <tromey@adacore.com>
10926
10927         PR symtab/23331:
10928         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
10929
10930 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
10931             Pedro Alves  <palves@redhat.com>
10932
10933         * top.c (quit_force): Call 'finalize_values'.
10934         * value.c (finalize_values): New function.
10935         * value.h (finalize_values): Declare.
10936
10937 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
10938
10939         * NEWS: Announce $_gdb_major and $_gdb_minor.
10940
10941         * top.c (init_gdb_version_vars): New function.
10942         (gdb_init): Call init_gdb_version_vars.
10943
10944 2019-03-29  Tom Tromey  <tromey@adacore.com>
10945
10946         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
10947         help text.  Remove dead code.
10948
10949 2019-03-29  Keith Seitz  <keiths@redhat.com>
10950
10951         From Siddhesh Poyarekar:
10952         * f-lang.h (f77_get_upperbound): Return LONGEST.
10953         (f77_get_lowerbound): Likewise.
10954         * f-typeprint.c (f_type_print_varspec_suffix): Expand
10955         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
10956         print them.
10957         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
10958         plongest to format print it.
10959         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
10960         (f77_get_upperbound): Likewise.
10961         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
10962         LOWER_BOUND to LONGEST.
10963         (f77_create_arrayprint_offset_tbl): Likewise.
10964
10965 2019-03-29  Keith Seitz  <keiths@redhat.com>
10966
10967         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
10968         %s/pulongest for TYPE_LENGTH instead of %d in format
10969         strings.
10970         * ada-typerint.c (ada_print_type): Likewise.
10971         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
10972         * compile/compile-c-support.c (generate_register_struct): Likewise.
10973         * gdbtypes.c (recursive_dump_type): Likewise.
10974         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
10975         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
10976         instead of %d in format strings.
10977         * riscv-tdep.c (riscv_type_alignment): Cast second argument
10978         to std::min to ULONGEST.
10979         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
10980         instead of %d in format strings.
10981         * tracepoint.c (info_scope_command): Likewise.
10982         * typeprint.c (print_offset_data::update)
10983         (print_offset_data::finish): Likewise.
10984         * xtensa-tdep.c (xtensa_store_return_value)
10985         (xtensa_push_dummy_call): Likewise.
10986
10987 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
10988
10989         * windows-nat.c (display_selector): Fixed format specifications
10990         for 64-bit Cygwin.
10991
10992 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10993
10994         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
10995
10996 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
10997
10998         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
10999         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
11000         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
11001         (nios2_linux_init_abi): Install it.
11002
11003 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
11004
11005         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
11006
11007 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
11008
11009         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
11010
11011 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11012             Tom Tromey  <tromey@adacore.com>
11013
11014         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
11015
11016 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
11017
11018         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
11019         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
11020         method to compute the bounds of range types. Also print "[evaluated]"
11021         if the bounds' values come from a dynamic evaluation.
11022
11023 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
11024
11025         * cp-valprint.c (cp_print_value_fields): Don't print trailing
11026         whitespace when pretty printing is on.
11027
11028 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
11029
11030         * ppc-linux-nat.c: Add include.
11031
11032 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
11033
11034         * NEWS: Mention AArch64 Pointer Authentication.
11035
11036 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
11037
11038         * arm-linux-nat.c: Add include.
11039
11040 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
11041
11042         * source-cache.c (source_cache::get_source_lines): Re-read
11043         fullname after calling open_source_file.
11044
11045 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
11046
11047         * NEWS: Mention TLS support for FreeBSD.
11048
11049 2019-03-25  Tom Tromey  <tromey@adacore.com>
11050
11051         * minsyms.c (BUNCH_SIZE): Update comment.
11052         (~minimal_symbol_reader): Remove old comment.
11053         (compact_minimal_symbols): Update comment.
11054         (minimal_symbol_reader::install): Remove old comment.  Update
11055         other comments.
11056
11057 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
11058
11059         * s390-linux-nat.c: Add include.
11060
11061 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
11062
11063         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
11064         Call linux_get_hwcap.
11065         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
11066         Likewise.
11067         (aarch64_linux_get_hwcap): Remove function.
11068         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
11069         declaration.
11070         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
11071         linux_get_hwcap.
11072         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
11073         * linux-tdep.c (linux_get_hwcap): Add function.
11074         (linux_get_hwcap2): Likewise.
11075         * linux-tdep.h (linux_get_hwcap): Add declaration.
11076         (linux_get_hwcap2): Likewise.
11077         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
11078         (ppc_linux_get_hwcap2): Likewise.
11079         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
11080         linux_get_hwcap.
11081         (ppc_linux_nat_target::insert_watchpoint): Likewise.
11082         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
11083         (ppc_linux_nat_target::read_description): Likewise.
11084         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
11085         * s390-linux-nat.c: Likewise.
11086         * s390-linux-tdep.c (s390_core_read_description): Likewise.
11087
11088 2019-03-24  Tom Tromey  <tom@tromey.com>
11089
11090         * ada-lang.c (standard_lookup): Simplify initialization.
11091         (ada_lookup_symbol_nonlocal): Simplify return.
11092         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
11093         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
11094         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
11095         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
11096         initialization.
11097         * solib.c (solib_global_lookup): Simplify.
11098         * symtab.c (null_block_symbol): Remove.
11099         (symbol_cache_lookup): Simplify returns.
11100         (lookup_language_this): Simplify returns.
11101         (lookup_symbol_aux): Simplify return.
11102         (lookup_local_symbol): Simplify returns.
11103         (lookup_global_symbol_from_objfile): Simplify return.
11104         (lookup_symbol_in_objfile_symtabs)
11105         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
11106         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
11107         (lookup_static_symbol, lookup_global_symbol): Simplify return.
11108         * cp-namespace.c (cp_lookup_bare_symbol)
11109         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
11110         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
11111         (cp_lookup_nested_symbol): Don't use null_block_symbol.
11112         (cp_lookup_symbol_via_imports): Simplify initialization.
11113         (find_symbol_in_baseclass): Likewise.
11114         * symtab.h (null_block_symbol): Remove.
11115         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
11116         (d_lookup_nested_symbol, d_lookup_symbol_imports)
11117         (d_lookup_symbol_module): Likewise.
11118         (find_symbol_in_baseclass): Simplify initialization.
11119
11120 2019-03-24  Tom Tromey  <tom@tromey.com>
11121
11122         * expression.h: Don't include symtab.h.
11123         (struct block): Forward declare.
11124
11125 2019-03-24  Tom Tromey  <tom@tromey.com>
11126
11127         * c-exp.y (typebase): Remove casts.
11128         * gdbtypes.c (lookup_unsigned_typename, )
11129         (lookup_signed_typename): Remove cast.
11130         * eval.c (parse_to_comma_and_eval): Remove cast.
11131         * parse.c (write_dollar_variable): Remove cast.
11132         * block.h (struct block) <superblock>: Now const.
11133         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
11134         * psymtab.c (psym_map_matching_symbols): Make "block" const.
11135         (map_block): Make "block" const.
11136         * symfile.h (struct quick_symbol_functions)
11137         <map_matching_symbols>: Constify block argument to "callback".
11138         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
11139         const.
11140         (find_pc_sect_compunit_symtab): Make "b" const.
11141         (find_symbol_at_address): Likewise.
11142         (search_symbols): Likewise.
11143         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
11144         (dw2_debug_names_lookup_symbol): Likewise.
11145         (dw2_map_matching_symbols): Update.
11146         * p-valprint.c (pascal_val_print): Remove "block".
11147         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
11148         (aux_add_nonlocal_symbols): Make "block" const.
11149         (resolve_subexp): Remove cast.
11150         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
11151         const.
11152         (iterate_over_file_blocks): Likewise.
11153         * f-exp.y (%union) <bval>: Remove.
11154         * coffread.c (patch_opaque_types): Make "b" const.
11155         * spu-tdep.c (spu_catch_start): Make "block" const.
11156         * c-valprint.c (print_unpacked_pointer): Remove "block".
11157         * symmisc.c (dump_symtab_1): Make "b" const.
11158         (block_depth): Make "block" const.
11159         * d-exp.y (%union) <bval>: Remove.
11160         * cp-support.h (cp_lookup_rtti_type): Update.
11161         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
11162         * psymtab.c (psym_lookup_symbol): Make "block" const.
11163         (maintenance_check_psymtabs): Make "b" const.
11164         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
11165         (enumerate_locals, enumerate_args): Update.
11166         * python/py-symtab.c (stpy_global_block): Make "block" const.
11167         (stpy_static_block): Likewise.
11168         * inline-frame.c (block_starting_point_at): Make "new_block"
11169         const.
11170         * block.c (find_block_in_blockvector): Make return type const.
11171         (blockvector_for_pc_sect): Make "b" const.
11172         (find_block_in_blockvector): Make "b" const.
11173
11174 2019-03-23  Tom Tromey  <tom@tromey.com>
11175
11176         * varobj.c (varobj_create): Update.
11177         * symfile.c (clear_symtab_users): Don't reset innermost_block.
11178         * printcmd.c (display_command, do_one_display): Don't reset
11179         innermost_block.
11180         * parser-defs.h (enum innermost_block_tracker_type): Move to
11181         expression.h.
11182         (innermost_block): Update comment.
11183         * parse.c (parse_exp_1): Add tracker_types parameter.
11184         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
11185         tracker_types parameter.  Reset innermost_block.
11186         (parse_exp_in_context): Remove.
11187         (parse_expression_for_completion): Update.
11188         * objfiles.c (~objfile): Don't reset expression_context_block or
11189         innermost_block.
11190         * expression.h (enum innermost_block_tracker_type): Move from
11191         parser-defs.h.
11192         (parse_exp_1): Add tracker_types parameter.
11193         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
11194         reset innermost_block.
11195
11196 2019-03-23  Tom Tromey  <tom@tromey.com>
11197
11198         * objfiles.h: Include bcache.h.
11199
11200 2019-03-23  Tom Tromey  <tom@tromey.com>
11201
11202         * linespec.c (get_current_search_block): Use
11203         scoped_restore_current_language.
11204         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
11205
11206 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
11207             Jiong Wang  <jiong.wang@arm.com>
11208
11209         * aarch64-linux-tdep.c
11210         (aarch64_linux_iterate_over_regset_sections): Check for pauth
11211         section.
11212         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
11213
11214 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
11215             Jiong Wang  <jiong.wang@arm.com>
11216
11217         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
11218         instructions.
11219         (aarch64_analyze_prologue_test): Add PACIASP test.
11220         (aarch64_prologue_prev_register): Unmask PC value.
11221
11222 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
11223             Jiong Wang  <jiong.wang@arm.com>
11224
11225         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
11226         (aarch64_dwarf2_prev_register): Unmask PC value.
11227         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
11228         (aarch64_execute_dwarf_cfa_vendor_op): Check for
11229         DW_CFA_AARCH64_negate_ra_state.
11230         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
11231
11232 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
11233             Jiong Wang  <jiong.wang@arm.com>
11234
11235         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
11236         registers.
11237         (aarch64_pseudo_register_name): Likewise.
11238         (aarch64_pseudo_register_type): Likewise.
11239         (aarch64_pseudo_register_reggroup_p): Likewise.
11240         (aarch64_gdbarch_init): Add pauth registers.
11241         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
11242         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
11243         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
11244         (struct gdbarch_tdep): Add regnum for ra_state.
11245
11246 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
11247             Jiong Wang  <jiong.wang@arm.com>
11248
11249         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
11250
11251 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
11252             Jiong Wang  <jiong.wang@arm.com>
11253
11254         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
11255         function.
11256         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
11257         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
11258         (aarch64_gdbarch_init): Add puth registers.
11259         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
11260         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
11261         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
11262
11263 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
11264             Jiong Wang  <jiong.wang@arm.com>
11265
11266         * aarch64-linux-nat.c
11267         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
11268         * aarch64-linux-tdep.c
11269         (aarch64_linux_core_read_description): Likewise.
11270         (aarch64_linux_get_hwcap): New function.
11271         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
11272         (aarch64_linux_get_hwcap): New declaration.
11273
11274 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
11275             Jiong Wang  <jiong.wang@arm.com>
11276
11277         * aarch64-linux-nat.c
11278         (aarch64_linux_nat_target::read_description): Add pauth param.
11279         * aarch64-linux-tdep.c
11280         (aarch64_linux_core_read_description): Likewise.
11281         * aarch64-tdep.c (struct target_desc): Add in pauth.
11282         (aarch64_read_description): Add pauth param.
11283         (aarch64_gdbarch_init): Likewise.
11284         * aarch64-tdep.h (aarch64_read_description): Likewise.
11285         * arch/aarch64.c (aarch64_create_target_description): Likewise.
11286         * arch/aarch64.h (aarch64_create_target_description): Likewise.
11287         * features/Makefile: Add new files.
11288         * features/aarch64-pauth.c: New file.
11289         * features/aarch64-pauth.xml: New file.
11290
11291 2019-03-20  Tom Tromey  <tromey@adacore.com>
11292
11293         * infrun.c (handle_inferior_event): Rename from
11294         handle_inferior_event_1.  Create a scoped_value_mark.
11295         (handle_inferior_event): Remove.
11296
11297 2019-03-19  Tom Tromey  <tromey@adacore.com>
11298
11299         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
11300         * infrun.h (print_stop_event): Add "displays" parameter.
11301         * infrun.c (print_stop_event): Add "displays" parameter.
11302
11303 2019-03-19  Pedro Alves  <palves@redhat.com>
11304
11305         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
11306         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
11307         to -1.  Fix TABs vs spaces.
11308         (tui_ui_out::tui_ui_out): Don't initialize fields here.
11309         * tui/tui-out.h (tui_ui_out) Add intro comments.
11310         <m_line, m_start_of_line>: In-class initialize, and add describing
11311         comment.
11312
11313 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
11314
11315         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
11316         variable names.
11317         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
11318
11319 2019-03-18  Pedro Alves  <palves@redhat.com>
11320             Eli Zaretskii <eliz@gnu.org>
11321
11322         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
11323         m_line and m_start_of_line.
11324
11325 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
11326
11327         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
11328         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
11329         it returns a newline.  This fixes a regression in TU mode, whereby
11330         the next line is output on the same screen line as the user input.
11331
11332 2019-03-18  Tom Tromey  <tromey@adacore.com>
11333
11334         * minsyms.c (minimal_symbol_reader::install): Remove call to
11335         obstack_blank.
11336
11337 2019-03-18  Pedro Alves  <palves@redhat.com>
11338
11339         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
11340         New globals.
11341         (apply_style): New, factored out from ...
11342         (apply_ansi_escape): ... this.  Handle reverse video mode.
11343         (tui_set_reverse_mode): New function.
11344         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
11345         * tui/tui-winsource.c (tui_show_source_line): Use
11346         tui_set_reverse_mode instead of setting A_STANDOUT.
11347         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
11348         New setter methods.
11349
11350 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
11351
11352         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
11353         Handle tabs.
11354
11355 2019-03-18  Tom Tromey  <tromey@adacore.com>
11356
11357         * ada-lang.c (empty_array): Add "high" parameter.
11358         (ada_evaluate_subexp): Update.
11359
11360 2019-03-17  Sergei Trofimovich <siarheit@google.com>
11361
11362         * unittests/string_view-selftests.c: Define
11363         _initialize_string_view_selftests unconditionally.
11364
11365 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
11366
11367         PR gdb/24350
11368         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
11369
11370 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
11371
11372         PR gdb/24351
11373         * windows-nat.c (display_selector): Fix format specifiers.
11374
11375 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
11376
11377         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
11378         tui_refill_source_window instead of tui_refresh_win, to update the
11379         current execution line.  This fixes redisplay of the current line
11380         when stepping through the code with "next" or "step".
11381
11382 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
11383
11384         * source-cache.c (source_cache::get_source_lines): Call
11385         find_source_lines to initialize s->nlines.  This fixes vertical
11386         scrolling of TUI source window when the DOWN arrow is pressed.
11387
11388 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11389
11390         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
11391         linux-thread-db.c (_initialize_thread_db): Likewise.
11392
11393 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
11394
11395         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
11396         wclrtoeol in tui_show_source_line".  This reverts changes made in
11397         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
11398
11399 2019-03-15  Tom Tromey  <tom@tromey.com>
11400
11401         * symtab.h (struct minimal_symbol): Derive from
11402         general_symbol_info.
11403         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
11404         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
11405         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
11406         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
11407         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
11408         (MSYMBOL_SEARCH_NAME): Update.
11409         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
11410         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
11411         * minsyms.c (minimal_symbol_reader::record_full): Update.
11412
11413 2019-03-15  Tom Tromey  <tom@tromey.com>
11414
11415         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
11416
11417 2019-03-15  Tom Tromey  <tom@tromey.com>
11418
11419         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
11420         unique_xmalloc_ptr.
11421         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
11422         Update.
11423         * minsyms.c (lookup_minimal_symbol_by_pc_section)
11424         (build_minimal_symbol_hash_tables)
11425         (minimal_symbol_reader::install): Update.
11426
11427 2019-03-15  Tom Tromey  <tom@tromey.com>
11428
11429         * symtab.c (create_demangled_names_hash): Update.
11430         (symbol_set_names): Update.
11431         * objfiles.h (struct objfile_per_bfd_storage)
11432         <demangled_names_hash>: Now an htab_up.
11433         * objfiles.c (objfile_per_bfd_storage): Simplify.
11434
11435 2019-03-15  Tom Tromey  <tom@tromey.com>
11436
11437         * objfiles.h (struct objfile_per_bfd_storage): Declare
11438         destructor.
11439         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
11440         New.
11441         (get_objfile_bfd_data): Use new.  Don't initialize
11442         language_of_main.
11443         (free_objfile_per_bfd_storage): Remove.
11444         (objfile_bfd_data_free, objfile::~objfile): Use delete.
11445
11446 2019-03-15  Tom Tromey  <tom@tromey.com>
11447
11448         * symfile.c (reread_symbols): Update.
11449         * objfiles.c (objfile::objfile): Update.
11450         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
11451         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
11452         comment.
11453         (minimal_symbol_reader::install): Update.
11454         (terminate_minimal_symbol_table): Remove.
11455         * jit.c (jit_object_close_impl): Update.
11456
11457 2019-03-15  Tom Tromey  <tom@tromey.com>
11458
11459         * minsyms.c (minimal_symbol_reader::record_full): Remove some
11460         initializations.
11461
11462 2019-03-15  Tom Tromey  <tom@tromey.com>
11463
11464         * objfiles.h (struct objfile_per_bfd_storage)
11465         <demangled_hash_languages>: Now a bitset.
11466         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
11467         (lookup_minimal_symbol): Update.
11468
11469 2019-03-15  Tom Tromey  <tom@tromey.com>
11470
11471         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
11472         Don't return the symbol.
11473         * coffread.c (record_minimal_symbol): Use record_full.
11474
11475 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
11476
11477         The MS-Windows port of ncurses fails to switch to a color pair if
11478         one or both of the colors are the implicit default colors.  This
11479         change records the default colors when TUI is initialized, and
11480         then specifies them explicitly when a color pair uses the default
11481         colors.  This allows color styling in TUI mode on MS-Windows.
11482
11483         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
11484         ncurses_norm_attr.
11485         (tui_initialize_io) [__MINGW32__]: Record the default terminal
11486         colors in ncurses_norm_attr.
11487         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
11488         "none", replace it with the default color recorded in
11489         ncurses_norm_attr.
11490
11491 2019-03-14  Tom Tromey  <tromey@adacore.com>
11492
11493         * source-cache.h (class source_cache) <get_source_lines>: Return
11494         std::string.
11495         * source-cache.c (source_cache::extract_lines): Handle case where
11496         first_pos==npos.  Return std::string.
11497         (source_cache::get_source_lines): Update.
11498
11499 2019-03-14  Tom Tromey  <tromey@adacore.com>
11500
11501         * NEWS: Add item for "style sources" commands.
11502         * source-cache.c (source_cache::get_source_lines): Check
11503         source_styling.
11504         * cli/cli-style.c (source_styling): New global.
11505         (_initialize_cli_style): Add "style sources" commands.
11506         (show_style_sources): New function.
11507         * cli/cli-style.h (source_styling): Declare.
11508
11509 2019-03-14  Pedro Alves  <palves@redhat.com>
11510             Tom Tromey  <tromey@adacore.com>
11511
11512         * tui/tui-winsource.h (tui_refill_source_window): Declare.
11513         * tui/tui-winsource.c (tui_refill_source_window): New function,
11514         from...
11515         (tui_horizontal_source_scroll): ... here.  Move some logic.
11516         * cli/cli-style.c (set_style_enabled): Notify new observable.
11517         * tui/tui-hooks.c (tui_redisplay_source): New function.
11518         (tui_attach_detach_observers): Attach or detach
11519         tui_redisplay_source.
11520         * observable.h (source_styling_changed): New observable.
11521         * observable.c: Define source_styling_changed observable.
11522
11523 2019-03-13  Tom Tromey  <tromey@adacore.com>
11524
11525         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
11526         (i386_gnu_nat_target::store_registers): Update.
11527         * target-debug.h (target_debug_print_std_string): New macro.
11528         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
11529         * windows-tdep.c (display_one_tib): Update.
11530         * tui/tui-stack.c (tui_make_status_line): Update.
11531         * top.c (print_inferior_quit_action): Update.
11532         * thread.c (thr_try_catch_cmd): Update.
11533         (add_thread_with_info): Update.
11534         (thread_target_id_str): Update.
11535         (thr_try_catch_cmd): Update.
11536         (thread_command): Update.
11537         (thread_find_command): Update.
11538         * record-btrace.c (record_btrace_target::info_record)
11539         (record_btrace_resume_thread, record_btrace_target::resume)
11540         (record_btrace_cancel_resume, record_btrace_step_thread)
11541         (record_btrace_target::wait, record_btrace_target::wait)
11542         (record_btrace_target::wait, record_btrace_target::stop): Update.
11543         * progspace.c (print_program_space): Update.
11544         * process-stratum-target.c
11545         (process_stratum_target::thread_address_space): Update.
11546         * linux-fork.c (linux_fork_mourn_inferior)
11547         (detach_checkpoint_command, info_checkpoints_command)
11548         (linux_fork_context): Update.
11549         (linux_fork_detach): Update.
11550         (class scoped_switch_fork_info): Update.
11551         (delete_checkpoint_command): Update.
11552         * infrun.c (follow_fork_inferior): Update.
11553         (follow_fork_inferior): Update.
11554         (proceed_after_vfork_done): Update.
11555         (handle_vfork_child_exec_or_exit): Update.
11556         (follow_exec): Update.
11557         (displaced_step_prepare_throw): Update.
11558         (displaced_step_restore): Update.
11559         (start_step_over): Update.
11560         (resume_1): Update.
11561         (clear_proceed_status_thread): Update.
11562         (proceed): Update.
11563         (print_target_wait_results): Update.
11564         (do_target_wait): Update.
11565         (context_switch): Update.
11566         (stop_all_threads): Update.
11567         (restart_threads): Update.
11568         (finish_step_over): Update.
11569         (handle_signal_stop): Update.
11570         (switch_back_to_stepped_thread): Update.
11571         (keep_going_pass_signal): Update.
11572         (print_exited_reason): Update.
11573         (normal_stop): Update.
11574         * inferior.c (inferior_pid_to_str): Change return type.
11575         (print_selected_inferior): Update.
11576         (add_inferior): Update.
11577         (detach_inferior): Update.
11578         * dummy-frame.c (fprint_dummy_frames): Update.
11579         * dcache.c (dcache_info_1): Update.
11580         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
11581         (btrace_fetch, btrace_clear): Update.
11582         * linux-tdep.c (linux_core_pid_to_str): Change return type.
11583         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
11584         type.
11585         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
11586         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
11587         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
11588         * gdbarch.c, gdbarch.h: Rebuild.
11589         * gdbarch.sh (core_pid_to_str): Change return type.
11590         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
11591         return type.
11592         (windows_nat_target::pid_to_str): Change return type.
11593         (windows_delete_thread): Update.
11594         (windows_nat_target::attach): Update.
11595         (windows_nat_target::files_info): Update.
11596         * target-delegates.c: Rebuild.
11597         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
11598         return type.
11599         (sol_thread_target::pid_to_str): Change return type.
11600         * remote.c (class remote_target) <pid_to_str>: Change return
11601         type.
11602         (remote_target::pid_to_str): Change return type.
11603         (extended_remote_target::attach, remote_target::remote_stop_ns)
11604         (remote_target::remote_notif_remove_queued_reply)
11605         (remote_target::push_stop_reply, remote_target::disable_btrace):
11606         Update.
11607         (extended_remote_target::attach): Update.
11608         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
11609         type.
11610         (gdbsim_target::pid_to_str): Change return type.
11611         * ravenscar-thread.c (struct ravenscar_thread_target)
11612         <pid_to_str>: Change return type.
11613         (ravenscar_thread_target::pid_to_str): Change return type.
11614         * procfs.c (class procfs_target) <pid_to_str>: Change return
11615         type.
11616         (procfs_target::pid_to_str): Change return type.
11617         (procfs_target::attach): Update.
11618         (procfs_target::detach): Update.
11619         (procfs_target::fetch_registers): Update.
11620         (procfs_target::store_registers): Update.
11621         (procfs_target::wait): Update.
11622         (procfs_target::files_info): Update.
11623         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
11624         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
11625         return type.
11626         (nto_procfs_target::pid_to_str): Change return type.
11627         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
11628         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
11629         return type.
11630         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
11631         (exit_lwp): Update.
11632         (attach_proc_task_lwp_callback, get_detach_signal)
11633         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
11634         (linux_nat_target::resume, wait_lwp, stop_callback)
11635         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
11636         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
11637         (linux_nat_wait_1, resume_stopped_resumed_lwps)
11638         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
11639         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
11640         type.
11641         (inf_ptrace_target::attach): Update.
11642         (inf_ptrace_target::files_info): Update.
11643         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
11644         type.
11645         (go32_nat_target::pid_to_str): Change return type.
11646         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
11647         (gnu_nat_target::wait): Update.
11648         (gnu_nat_target::wait): Update.
11649         (gnu_nat_target::resume): Update.
11650         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
11651         (fbsd_nat_target::wait): Update.
11652         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
11653         type.
11654         (darwin_nat_target::attach): Update.
11655         * corelow.c (class core_target) <pid_to_str>: Change return type.
11656         (core_target::pid_to_str): Change return type.
11657         * target.c (normal_pid_to_str): Change return type.
11658         (default_pid_to_str): Likewise.
11659         (target_pid_to_str): Change return type.
11660         (target_translate_tls_address): Update.
11661         (target_announce_detach): Update.
11662         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
11663         return type.
11664         (bsd_uthread_target::pid_to_str): Change return type.
11665         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
11666         type.
11667         (bsd_kvm_target::pid_to_str): Change return type.
11668         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
11669         return type.
11670         (aix_thread_target::pid_to_str): Change return type.
11671         * target.h (struct target_ops) <pid_to_str>: Change return type.
11672         (target_pid_to_str, normal_pid_to_str): Likewise.
11673         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
11674         type.
11675         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
11676         type.
11677         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
11678         return type.
11679         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
11680         type.
11681         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
11682         type.
11683         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
11684         return type.
11685
11686 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
11687
11688         * NEWS: Mention that the new default MI version is 3.  Mention
11689         changes to the output of commands and events that deal with
11690         multi-location breakpoints.
11691         * breakpoint.c: Include "mi/mi-out.h".
11692         (print_one_breakpoint): Change output syntax if using MI version
11693         >= 3.
11694         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
11695         New.
11696         (mi_multi_location_breakpoint_output_fixed): New.
11697         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
11698         (mi_cmd_fix_multi_location_breakpoint_output): New.
11699         (mi_multi_location_breakpoint_output_fixed): New.
11700         * mi/mi-cmds.c (mi_cmds): Register command
11701         -fix-multi-location-breakpoint-output.
11702         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
11703         interpreter "mi".
11704
11705 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
11706
11707         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
11708         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
11709         instantiate mi_ui_out based on interpreter name.
11710         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
11711         * mi/mi-main.c (mi_load_progress): Likewise.
11712
11713 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11714
11715         * NEWS: Combine separate "New targets" sections for 8.3.
11716
11717 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11718
11719         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
11720         (ppcfbsd_init_abi): Install gdbarch
11721         "fetch_tls_load_module_address" and "get_thread_local_address"
11722         methods.
11723
11724 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11725
11726         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
11727         (riscv_fbsd_init_abi): Install gdbarch
11728         "fetch_tls_load_module_address" and "get_thread_local_address"
11729         methods.
11730
11731 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11732
11733         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
11734         (i386fbsd_init_abi): Install gdbarch
11735         "fetch_tls_load_module_address" and "get_thread_local_address"
11736         methods.
11737
11738 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11739
11740         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
11741         (amd64fbsd_init_abi): Install gdbarch
11742         "fetch_tls_load_module_address" and "get_thread_local_address"
11743         methods.
11744
11745 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11746
11747         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
11748         (struct fbsd_pspace_data): New type.
11749         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
11750         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
11751         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
11752         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
11753         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
11754
11755 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11756
11757         * gdbtypes.c (lookup_struct_elt): New function.
11758         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
11759         * gdbtypes.h (struct struct_elt): New type.
11760         (lookup_struct_elt): New prototype.
11761
11762 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11763
11764         * gdbtypes.c (lookup_struct_elt_type): Update comment and
11765         remove disabled code block.
11766
11767 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11768
11769         * gdbarch.sh (get_thread_local_address): New method.
11770         * gdbarch.h, gdbarch.c: Regenerate.
11771         * target.c (target_translate_tls_address): Use
11772         gdbarch_get_thread_local_address if present instead of
11773         target::get_thread_local_address.
11774
11775 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11776
11777         * target.h (target::get_thread_local_address): Update comment.
11778
11779 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11780
11781         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
11782         objfile->separate_debug_objfile_backlink if not NULL.
11783
11784 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11785
11786         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
11787         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
11788         (amd64bsd_store_inferior_registers): Likewise.
11789         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
11790         Enable segment base registers.
11791         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
11792         PT_GETFSBASE and PT_GETGSBASE.
11793         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
11794         PT_SETGSBASE.
11795         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
11796         segment base registers.
11797         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
11798
11799 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11800
11801         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
11802         Update calls to i386_target_description to add 'segments'
11803         parameter.
11804         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
11805         add segment base registers.
11806         * arch/i386.c (i386_create_target_description): Add 'segments'
11807         parameter to enable segment base registers.
11808         * arch/i386.h (i386_create_target_description): Likewise.
11809         * features/i386/32bit-segments.xml: New file.
11810         * features/i386/32bit-segments.c: Generate.
11811         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
11812         call to i386_target_description to add 'segments' parameter.
11813         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
11814         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
11815         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
11816         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
11817         if feature is present.
11818         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
11819         Add 'segments' parameter to call to i386_target_description.
11820         (i386_target_description): Add 'segments' parameter to enable
11821         segment base registers.
11822         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
11823         to call to i386_target_description.
11824         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
11825         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
11826         Define I386_NUM_REGS.
11827         (i386_target_description): Add 'segments' parameter to enable
11828         segment base registers.
11829
11830 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
11831
11832         PR/24325
11833         * source-cache.c: #undef open and close, to avoid unresolved
11834         externals during linking.
11835
11836 2019-03-12  Tom Tromey  <tromey@adacore.com>
11837
11838         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
11839         const.  Add initializers.
11840         (_initialize_remote): Don't initialize ptid globals.
11841
11842 2019-03-12  Pedro Alves  <palves@redhat.com>
11843
11844         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
11845
11846 2019-03-12  Pedro Alves  <palves@redhat.com>
11847
11848         * cp-name-parser.y (main): Remove unused 'len' variable.
11849
11850 2019-03-12  Tom Tromey  <tromey@adacore.com>
11851
11852         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
11853         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
11854
11855 2019-03-12  Tom Tromey  <tromey@adacore.com>
11856
11857         * linux-nat.c (iterate_over_lwps): Update.
11858         (stop_callback): Remove parameter.
11859         (stop_wait_callback, detach_callback, resume_set_callback)
11860         (select_singlestep_lwp_callback, set_ignore_sigint)
11861         (status_callback, resumed_callback, resume_clear_callback)
11862         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
11863         data parameter.
11864         (linux_nat_target::detach, linux_nat_target::resume)
11865         (linux_stop_and_wait_all_lwps, select_event_lwp)
11866         (linux_nat_filter_event, linux_nat_wait_1)
11867         (linux_nat_target::kill, linux_nat_target::stop)
11868         (linux_nat_target::stop): Update.
11869         (linux_nat_resume_callback): Change type.
11870         (resume_stopped_resumed_lwps, count_events_callback)
11871         (select_event_lwp_callback): Likewise.
11872         (linux_stop_lwp, linux_nat_stop_lwp): Update.
11873         * arm-linux-nat.c (struct update_registers_data): Remove.
11874         (update_registers_callback): Change type.
11875         (arm_linux_insert_hw_breakpoint1): Update.
11876         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
11877         parameter.
11878         (x86_linux_dr_set_addr): Update.
11879         (x86_linux_dr_set_control): Update.
11880         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
11881         (iterate_over_lwps): Use gdb::function_view.
11882         * nat/aarch64-linux-hw-point.c (struct
11883         aarch64_dr_update_callback_param): Remove.
11884         (debug_reg_change_callback): Change type.
11885         (aarch64_notify_debug_reg_change): Update.
11886         * s390-linux-nat.c (s390_refresh_per_info): Update.
11887
11888 2019-03-11  Tom Tromey  <tromey@adacore.com>
11889
11890         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
11891         redundant assignment to "this_cu".
11892
11893 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11894
11895         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
11896
11897 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11898
11899         * gdbtypes.c (rank_one_type_parm_set): New function extracted
11900         from...
11901         (rank_one_type): ... this.
11902
11903 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11904
11905         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
11906         from...
11907         (rank_one_type): ... this.
11908
11909 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11910
11911         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
11912         from...
11913         (rank_one_type): ... this.
11914
11915 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11916
11917         * gdbtypes.c (rank_one_type_parm_float): New function extracted
11918         from...
11919         (rank_one_type): ... this.
11920
11921 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11922
11923         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
11924         from...
11925         (rank_one_type): ... this.
11926
11927 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11928
11929         * gdbtypes.c (rank_one_type_parm_range): New function extracted
11930         from...
11931         (rank_one_type): ... this.
11932
11933 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11934
11935         * gdbtypes.c (rank_one_type_parm_char): New function extracted
11936         from...
11937         (rank_one_type): ... this.
11938
11939 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11940
11941         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
11942         from...
11943         (rank_one_type): ... this.
11944
11945 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11946
11947         * gdbtypes.c (rank_one_type_parm_int): New function extracted
11948         from...
11949         (rank_one_type): ... this.
11950
11951 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11952
11953         * gdbtypes.c (rank_one_type_parm_func): New function extracted
11954         from...
11955         (rank_one_type): ... this.
11956
11957 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11958
11959         * gdbtypes.c (rank_one_type_parm_array): New function extracted
11960         from...
11961         (rank_one_type): ... this.
11962
11963 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11964
11965         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
11966         from...
11967         (rank_one_type): ... this.
11968
11969 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11970
11971         * inferior.c (initialize_inferiors): Ensure 'help set/show print
11972         inferior-events' shows the example events.
11973
11974 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
11975
11976         Support styling on native MS-Windows console
11977
11978         PR/24315
11979         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
11980         on MS-Windows if $TERM is not defined.
11981
11982         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
11983
11984         * posix-hdep.c (gdb_console_fputs):
11985         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
11986         functions.
11987         * ui-file.h (gdb_console_fputs): Add prototype.
11988
11989         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
11990         back to fputs only if the former returns zero.
11991
11992 2019-03-07  Tom Tromey  <tom@tromey.com>
11993
11994         * symmisc.c (print_symbol_bcache_statistics): Update.
11995         (print_objfile_statistics): Update.
11996         * symfile.c (allocate_symtab): Update.
11997         * stabsread.c: Don't include bcache.h.
11998         * psymtab.h (struct psymbol_bcache): Don't declare.
11999         (class psymtab_storage) <psymbol_cache>: Now a bcache.
12000         (psymbol_bcache_init, psymbol_bcache_free)
12001         (psymbol_bcache_get_bcache): Don't declare.
12002         * psymtab.c (struct psymbol_bcache): Remove.
12003         (psymtab_storage::psymtab_storage): Update.
12004         (psymtab_storage::~psymtab_storage): Update.
12005         (psymbol_bcache_init, psymbol_bcache_free)
12006         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
12007         (add_psymbol_to_bcache): Update.
12008         (allocate_psymtab): Update.
12009         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
12010         macro_cache>: No longer pointers.
12011         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
12012         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
12013         * macrotab.c (macro_bcache): Update.
12014         * macroexp.c: Don't include bcache.h.
12015         * gdbtypes.c (check_types_worklist): Update.
12016         (types_deeply_equal): Remove TRY/CATCH.  Update.
12017         * elfread.c (elf_symtab_read): Update.
12018         * dwarf2read.c: Don't include bcache.h.
12019         * buildsym.c (buildsym_compunit::get_macro_table): Update.
12020         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
12021         (print_bcache_statistics, bcache_memory_used): Don't declare.
12022         (struct bcache): Move from bcache.c.  Add constructor, destructor,
12023         methods.  Rename all data members.
12024         * bcache.c (struct bcache): Move to bcache.h.
12025         (bcache::expand_hash_table): Rename from expand_hash_table.
12026         (bcache): Remove.
12027         (bcache::insert): Rename from bcache_full.
12028         (bcache::compare): Rename from bcache_compare.
12029         (bcache_xmalloc): Remove.
12030         (bcache::~bcache): Rename from bcache_xfree.
12031         (bcache::print_statistics): Rename from print_bcache_statistics.
12032         (bcache::memory_used): Rename from bcache_memory_used.
12033
12034 2019-03-07  Pedro Alves  <palves@redhat.com>
12035
12036         * infrun.c (normal_stop): Also check for
12037         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
12038
12039 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
12040
12041         * f-lang.c (value_from_host_double): Moved to...
12042         * value.c (value_from_host_double): ...here.
12043         * value.h (value_from_host_double): Declare.
12044         * guile/scm-math.c (vlscm_convert_typed_number): Use
12045         value_from_host_double.
12046         (vlscm_convert_number): Likewise.
12047         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
12048         * python/py-value.c (convert_value_from_python): Likewise.
12049
12050 2019-03-06  Tom Tromey  <tom@tromey.com>
12051
12052         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
12053
12054 2019-03-06  Tom Tromey  <tom@tromey.com>
12055
12056         * utils.h (free_current_contents): Don't declare.
12057         * utils.c (free_current_contents): Remove.
12058
12059 2019-03-06  Tom Tromey  <tom@tromey.com>
12060
12061         * top.c (quit_force): Update.
12062         * main.c (captured_command_loop): Update.
12063         * common/new-op.c (operator new): Update.
12064         * common/common-exceptions.c (struct catcher)
12065         <save_cleanup_chain>: Remove member.
12066         (exceptions_state_mc_init): Update.
12067         (exception_try_scope_entry): Return nullptr.
12068         (exception_try_scope_exit, exception_rethrow)
12069         (throw_exception_sjlj, throw_exception_cxx): Update.
12070         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
12071         (all_cleanups, do_cleanups, discard_cleanups)
12072         (discard_final_cleanups, save_cleanups, save_final_cleanups)
12073         (restore_cleanups, restore_final_cleanups): Don't declare.
12074         (do_final_cleanups): Remove parameter.
12075         * common/cleanups.c (cleanup_chain, make_cleanup)
12076         (make_cleanup_dtor, all_cleanups, do_cleanups)
12077         (discard_my_cleanups, discard_cleanups)
12078         (discard_final_cleanups, save_my_cleanups, save_cleanups)
12079         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
12080         (null_cleanup): Remove.
12081         (do_final_cleanups): Remove parameter.
12082
12083 2019-03-06  Tom Tromey  <tom@tromey.com>
12084
12085         * remote.c (remote_target::remote_parse_stop_reply): Use
12086         unique_xmalloc_ptr.
12087
12088 2019-03-06  Tom Tromey  <tom@tromey.com>
12089
12090         * stabsread.c (struct stabs_field_info): Rename from field_info.
12091         <list, fnlist>: Add initializers.
12092         <obstack>: New member.
12093         (read_member_functions, read_struct_fields, read_baseclasses):
12094         Allocate on obstack.  Don't use cleanups.
12095         (read_one_struct_field, read_member_functions, read_struct_fields)
12096         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
12097         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
12098         (read_struct_type): Update.
12099
12100 2019-03-06  Tom Tromey  <tom@tromey.com>
12101
12102         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
12103         * common/filestuff.h (make_cleanup_close): Don't declare.
12104         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
12105         Remove.
12106
12107 2019-03-06  Tom Tromey  <tom@tromey.com>
12108
12109         * solib-aix.c: Use make_scope_exit.
12110
12111 2019-03-06  Tom Tromey  <tom@tromey.com>
12112
12113         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
12114         Use make_scope_exit.
12115
12116 2019-03-06  Tom Tromey  <tom@tromey.com>
12117
12118         * solib-svr4.c (disable_probes_interface): Remove parameter.
12119         (svr4_handle_solib_event): Use make_scope_exit.
12120
12121 2019-03-06  Tom Tromey  <tom@tromey.com>
12122
12123         * remote.c (struct stop_reply_deleter): Remove.
12124         (stop_reply_up): Update.
12125         (struct stop_reply): Derive from notif_event.  Don't typedef.
12126         <regcache>: Now a std::vector.
12127         (stop_reply_xfree): Remove.
12128         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
12129         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
12130         (remote_target::discard_pending_stop_replies): Use delete.
12131         (remote_target::remote_parse_stop_reply): Update.
12132         (remote_target::process_stop_reply): Update.
12133         * remote-notif.h (struct notif_event): Add virtual destructor.
12134         Remove "dtr" member.
12135         (struct notif_client) <alloc_event>: Return a unique_ptr.
12136         (notif_event_xfree): Don't declare.
12137         (notif_event_up): New typedef.
12138         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
12139         (notif_event_xfree, do_notif_event_xfree): Remove.
12140         (remote_notif_state_xfree): Update.
12141
12142 2019-03-06  Tom Tromey  <tom@tromey.com>
12143
12144         * infrun.c (displaced_step_clear_cleanup): Now a
12145         forward_scope_exit type.
12146         (displaced_step_prepare_throw): Update.
12147         (displaced_step_fixup): Update.
12148
12149 2019-03-06  Tom Tromey  <tom@tromey.com>
12150
12151         * inferior.h (class inferior): Update comment.
12152         * gdbthread.h (class thread_info): Update comment.
12153
12154 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
12155             Tom Tromey  <tom@tromey.com>
12156
12157         * stabsread.h (struct stab_section_list): Remove.
12158         (coffstab_build_psymtabs): Update.
12159         * dbxread.c (symbuf_sections): Now a std::vector.
12160         (sect_idx): New global.
12161         (fill_symbuf): Update.
12162         (coffstab_build_psymtabs): Change type of stabsects parameter.
12163         Update.
12164         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
12165         std::vector.
12166         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
12167         (coff_locate_sections): Update.
12168         (coff_symfile_read): Remove cleanups.  Update.
12169         (init_stringtab): Add storage parameter.
12170         (free_stringtab, free_stringtab_cleanup): Remove.
12171         (init_lineno): Add storage parameter.
12172         (free_linetab, free_linetab_cleanup): Remove.
12173
12174 2019-03-06  Pedro Alves  <palves@redhat.com>
12175
12176         * linux-fork.c (fork_info::clobber_regs): Delete.
12177         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
12178         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
12179         comment.  Adjust.
12180         (scoped_switch_fork_info::scoped_switch_fork_info)
12181         (checkpoint_command, linux_fork_context): Adjust
12182         fork_save_infrun_state calls.
12183
12184 2019-03-06  Pedro Alves  <palves@redhat.com>
12185
12186         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
12187         (inf_has_multiple_threads): Return 'bool' and rewrite using
12188         inferior_info::threads().
12189
12190 2019-03-06  Pedro Alves  <palves@redhat.com>
12191
12192         * linux-fork.c: Include <list>.
12193         (fork_list): Now a std::list instance.
12194         (fork_info): Add ctor, dtor, and in-class initialize all fields.
12195         (forks_exist_p, find_last_fork): Adjust.
12196         (new_fork): Delete.
12197         (one_fork_p): New.
12198         (add_fork): Adjust.
12199         (free_fork): Delete, folded into fork_info::~fork_info().
12200         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
12201         Adjust.
12202         (init_fork_list): Delete.
12203         (linux_fork_killall, linux_fork_mourn_inferior)
12204         (linux_fork_detach, info_checkpoints_command): Adjust.
12205         (_initialize_linux_fork): No longer call init_fork_list.
12206
12207 2019-03-06  Pedro Alves  <palves@redhat.com>
12208
12209         * linux-fork.c (new_fork): New, split out of ...
12210         (add_fork): ... this.  Return void.  Move "first fork" special
12211         case from here, to ...
12212         (checkpoint_command): ... here.
12213         * linux-linux.h (add_fork): Return void.
12214
12215 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
12216
12217         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
12218
12219 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
12220             Chris January  <chris.january@arm.com>
12221             David Lecomber  <david.lecomber@arm.com>
12222
12223         * f-exp.y: New token, UNOP_INTRINSIC.
12224         (exp): New pattern using UNOP_INTRINSIC token.
12225         (f77_keywords): Add 'abs' keyword.
12226         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
12227         (value_from_host_double): New function.
12228         (evaluate_subexp_f): Support UNOP_ABS.
12229
12230 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
12231
12232         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
12233         types.
12234
12235 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
12236
12237         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
12238         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
12239         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
12240
12241 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
12242
12243         * f-exp.y (convert_to_kind_type): Handle more type kinds.
12244
12245 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
12246             Chris January  <chris.january@arm.com>
12247
12248         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
12249         * f-exp.y: Define 'KIND' token.
12250         (exp): New pattern for KIND expressions.
12251         (ptype): Handle types with a kind extension.
12252         (direct_abs_decl): Extend to spot kind extensions.
12253         (f77_keywords): Add 'kind' to the list.
12254         (push_kind_type): New function.
12255         (convert_to_kind_type): New function.
12256         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
12257         * parse.c (operator_length_standard): Likewise.
12258         * parser-defs.h (enum type_pieces): Add tp_kind.
12259         * std-operator.def: Add UNOP_KIND.
12260
12261 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
12262
12263         * f-exp.y (f_parse): Set yydebug.
12264
12265 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
12266
12267         * f-lang.c (evaluate_subexp_f): New function.
12268         (exp_descriptor_f): New global.
12269         (f_language_defn): Use exp_descriptor_f instead of
12270         exp_descriptor_standard.
12271
12272 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
12273
12274         * f-exp.y (struct token): Add comments.
12275         (dot_ops): Remove uppercase versions and the end marker.
12276         (f77_keywords): Likewise.
12277         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
12278         entries in the dot_ops array are case insensitive, and use
12279         strncasecmp to compare strings.  Also some whitespace cleanup in
12280         this area.  Similar for the f77_keywords array, except entries in
12281         this list might be case sensitive.
12282
12283 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
12284
12285         * f-exp.y (struct f77_boolean_val): Add comments.
12286         (boolean_values): Remove uppercase versions, and end marker.
12287         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
12288         and use strncasecmp to achieve case insensitivity.  Additionally,
12289         perform whitespace cleanup around this code.
12290
12291 2019-03-06  Tom Tromey  <tromey@adacore.com>
12292
12293         * remote-sim.c (gdbsim_target_open): Use result of
12294         gdb_argv::release.
12295
12296 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
12297         Dirk Schubert  <dirk.schubert@arm.com>
12298         Chris January  <chris.january@arm.com>
12299
12300         * eval.c (evaluate_subexp_standard): Call Fortran argument
12301         wrapping logic.
12302         * f-lang.c (struct value): A value which can be passed into a
12303         Fortran function call.
12304         (fortran_argument_convert): Wrap Fortran arguments in a pointer
12305         where appropriate.
12306         (struct type): Value ready for a Fortran function call.
12307         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
12308         is needed.
12309         * f-lang.h (fortran_argument_convert): Declaration.
12310         (fortran_preserve_arg_pointer): Declaration.
12311         * infcall.c (value_arg_coerce): Call Fortran argument logic.
12312
12313 2019-03-05  Tom Tromey  <tromey@adacore.com>
12314
12315         * python/py-prettyprint.c (print_string_repr): Remove #if.
12316         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
12317
12318 2019-03-05  Tom Tromey  <tromey@adacore.com>
12319
12320         * target.c (the_dummy_target): Move later.  Change type to
12321         "dummy_target".
12322         (initialize_targets): Don't initialize the_dummy_target.
12323
12324 2019-03-05  Tom Tromey  <tromey@adacore.com>
12325
12326         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
12327         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
12328
12329 2019-03-05  Tom Tromey  <tromey@adacore.com>
12330
12331         * windows-nat.c (windows_nat_target::attach)
12332         (windows_nat_target::detach): Don't call gdb_flush.
12333         * valprint.c (generic_val_print, val_print, val_print_string):
12334         Don't call gdb_flush.
12335         * utils.c (defaulted_query): Don't call gdb_flush.
12336         * typeprint.c (print_type_scalar): Don't call gdb_flush.
12337         * target.c (target_announce_detach): Don't call gdb_flush.
12338         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
12339         * remote.c (extended_remote_target::attach): Don't call
12340         gdb_flush.
12341         * procfs.c (procfs_target::detach): Don't call gdb_flush.
12342         * printcmd.c (do_examine): Don't call gdb_flush.
12343         (info_display_command): Don't call gdb_flush.
12344         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
12345         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
12346         * memattr.c (info_mem_command): Don't call gdb_flush.
12347         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
12348         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
12349         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
12350         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
12351         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
12352         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
12353         (gnu_nat_target::detach): Don't call gdb_flush.
12354         * f-valprint.c (f_val_print): Don't call gdb_flush.
12355         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
12356         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
12357         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
12358         gdb_flush.
12359         * c-valprint.c (c_val_print): Don't call gdb_flush.
12360         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
12361
12362 2019-03-05  Tom Tromey  <tromey@adacore.com>
12363
12364         * varobj.c (update_dynamic_varobj_children): Update.
12365         (install_default_visualizer): Use reset, not release.
12366         * value.c (set_internalvar): Update.
12367         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
12368         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
12369         ATTRIBUTE_UNUSED_RESULT.
12370
12371 2019-03-05  Tom Tromey  <tromey@adacore.com>
12372
12373         * remote.c (class scoped_remote_fd) <release>: Add
12374         ATTRIBUTE_UNUSED_RESULT.
12375
12376 2019-03-05  Tom Tromey  <tromey@adacore.com>
12377
12378         * macroexp.c (struct macro_buffer) <release>: Add
12379         ATTRIBUTE_UNUSED_RESULT.
12380
12381 2019-03-05  Tom Tromey  <tromey@adacore.com>
12382
12383         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
12384         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
12385         ATTRIBUTE_UNUSED_RESULT.
12386
12387 2019-03-05  Tom Tromey  <tromey@adacore.com>
12388
12389         * common/scoped_fd.h (class scoped_fd) <release>: Add
12390         ATTRIBUTE_UNUSED_RESULT.
12391
12392 2019-03-05  Tom Tromey  <tromey@adacore.com>
12393
12394         * parser-defs.h (struct parser_state) <release>: Add
12395         ATTRIBUTE_UNUSED_RESULT.
12396
12397 2019-03-05  Tom Tromey  <tromey@adacore.com>
12398
12399         * utils.h (class gdb_argv) <release>: Add
12400         ATTRIBUTE_UNUSED_RESULT.
12401         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
12402
12403 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
12404
12405         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
12406         for-loop range, to avoid compiler warnings.
12407
12408         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
12409         avoid compiler warnings about unused variables.
12410
12411         * NEWS: Mention end of support for native debugging on MS-Windows
12412         before XP.
12413
12414         PR gdb/24292
12415         * common/netstuff.c:
12416         * gdbserver/gdbreplay.c
12417         * gdbserver/remote-utils.c:
12418         * ser-tcp.c:
12419         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
12420         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
12421         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
12422         'getaddrinfo' and 'freeaddrinfo' were not available before
12423         Windows XP, and mingw.org's MinGW headers by default define
12424         _WIN32_WINNT to 0x500.
12425
12426 2019-03-01  Gary Benson <gbenson@redhat.com>
12427
12428         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
12429
12430 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
12431             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
12432
12433         PR gdb/8527
12434         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
12435         set_sigint_trap, clear_sigint_trap.
12436
12437 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12438
12439         * target.c (target_detach): Clear the regcache and the
12440         frame cache.
12441
12442 2019-02-27  Pedro Alves  <palves@redhat.com>
12443
12444         * utils.c (set_screen_size): When we cap the height/width sizes,
12445         tweak the corresponding command variable to show "unlimited":
12446
12447 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
12448             Pedro Alves  <palves@redhat.com>
12449
12450         * utils.c (set_screen_size): Reduce "infinite" rows and columns
12451         before calling rl_set_screen_size.
12452
12453 2019-02-27  Tom Tromey  <tromey@adacore.com>
12454
12455         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
12456         define.
12457         * python/py-value.c: Remove Python 2.4 workaround.
12458         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
12459         workaround.
12460         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
12461         Python 2.4 workaround.
12462         * python/python-internal.h: Remove Python 2.4 comment.
12463         (Py_ssize_t): Don't define.
12464         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
12465         (gdb_Py_DECREF): Remove Python 2.4 workaround.
12466         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
12467         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
12468         * python/python.c (do_start_initialization): Remove Python 2.4
12469         workaround.
12470         * python/py-prettyprint.c (class dummy_python_frame): Remove.
12471         (print_children): Remove Python 2.4 workaround.
12472         * python/py-inferior.c (buffer_procs): Remove Python 2.4
12473         workaround.
12474         (CHARBUFFERPROC_NAME): Remove.
12475         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
12476         Python 2.4 workaround.
12477
12478 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
12479
12480         * NEWS: Note minimum Python version.
12481
12482 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
12483
12484         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
12485         code from these functions.  Remove corresponding ifdefs.  Use
12486         Py_buffer_up instead of explicit calls to PyBuffer_Release.
12487         Remove gotos and target of gotos.
12488         (infpy_search_memory): Likewise.
12489
12490 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12491
12492         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
12493         (hppa_gdbarch_init): Don't register deleted functions with
12494         gdbarch.
12495
12496 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12497
12498         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
12499         (h8300_unwind_sp): Delete.
12500         (h8300_dummy_id): Delete.
12501         (h8300_gdbarch_init): Don't register deleted functions with
12502         gdbarch.
12503
12504 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12505
12506         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
12507         (ft32_unwind_pc): Delete.
12508         (ft32_unwind_sp): Delete.
12509         (ft32_gdbarch_init): Don't register deleted functions with
12510         gdbarch.
12511
12512 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12513
12514         * gdb/frv-tdep.c (frv_dummy_id): Delete.
12515         (frv_unwind_pc): Delete.
12516         (frv_unwind_sp): Delete.
12517         (frv_gdbarch_init): Don't register deleted functions with
12518         gdbarch.
12519
12520 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12521
12522         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
12523         (riscv_unwind_pc): Delete.
12524         (riscv_unwind_sp): Delete.
12525         (riscv_gdbarch_init): Don't register deleted functions with
12526         gdbarch.
12527
12528 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12529
12530         * gdb/csky-tdep.c (csky_dummy_id): Delete.
12531         (csky_unwind_pc): Delete.
12532         (csky_unwind_sp): Delete.
12533         (csky_gdbarch_init): Don't register deleted functions with
12534         gdbarch.
12535
12536 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12537
12538         * gdb/cris-tdep.c (cris_dummy_id): Delete.
12539         (cris_unwind_pc): Delete.
12540         (cris_unwind_sp): Delete.
12541         (cris_gdbarch_init): Don't register deleted functions with
12542         gdbarch.
12543
12544 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12545
12546         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
12547         (bfin_unwind_pc): Delete.
12548         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
12549
12550 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12551
12552         * gdb/arm-tdep.c (arm_dummy_id): Delete.
12553         (arm_unwind_pc): Delete.
12554         (arm_unwind_sp): Delete.
12555         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
12556
12557 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12558
12559         * gdb/arc-tdep.c (arc_dummy_id): Delete.
12560         (arc_unwind_pc): Delete.
12561         (arc_unwind_sp): Delete.
12562         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
12563
12564 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12565
12566         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
12567         (alpha_unwind_pc): Delete.
12568         (alpha_gdbarch_init): Don't register deleted functions with
12569         gdbarch.
12570
12571 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12572
12573         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
12574         (aarch64_unwind_pc): Delete.
12575         (aarch64_unwind_sp): Delete.
12576         (aarch64_gdbarch_init): Don't register deleted functions with
12577         gdbarch.
12578
12579 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12580
12581         * gdbtypes.c (type_align): Don't consider static members when
12582         computing structure alignment.
12583
12584 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12585
12586         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
12587         return 0 for other types.
12588         * arch-utils.c (default_type_align): Always return 0.
12589         * gdbarch.h: Regenerate.
12590         * gdbarch.sh (type_align): Extend comment.
12591         * gdbtypes.c (type_align): Add additional comments, always call
12592         gdbarch_type_align before applying the default rules.
12593         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
12594         generic code will then apply a suitable default.
12595         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
12596         types, return 0 for other types.
12597
12598 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
12599
12600         * NEWS: Create a new section for the next release branch.
12601         Rename the section of the current branch, now that it has
12602         been cut.
12603
12604 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
12605
12606         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
12607         * version.in: Bump version to 8.3.50.DATE-git.
12608
12609 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
12610
12611         * aix-thread.c (ptid_cmp): Remove unused variable.
12612         (get_signaled_thread): Likewise.
12613         (store_regs_user_thread): Likewise.
12614         (store_regs_kernel_thread): Likewise.
12615         (fetch_regs_kernel_thread): Remove shadowed variable.
12616
12617 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
12618
12619         * features/riscv/32bit-cpu.xml: Add register numbers.
12620         * features/riscv/32bit-fpu.c: Regenerate.
12621         * features/riscv/32bit-fpu.xml: Add register numbers.
12622         * features/riscv/64bit-cpu.xml: Add register numbers.
12623         * features/riscv/64bit-fpu.c: Regenerate.
12624         * features/riscv/64bit-fpu.xml: Add register numbers.
12625
12626 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
12627
12628         * NEWS: Mention two argument form of gdb.Value constructor.
12629         * python/py-value.c (convert_buffer_and_type_to_value): New
12630         function.
12631         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
12632         Add support for handling an optional second argument.  Call
12633         convert_buffer_and_type_to_value as appropriate.
12634         * python/python-internal.h (Py_buffer_deleter): New struct.
12635         (Py_buffer_up): New typedef.
12636
12637 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
12638
12639         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
12640         instead of releasing ownership.
12641
12642 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
12643
12644         * dwarf2read.c (open_and_init_dwp_file): Call
12645         elf_numsections instead of bfd_count_sections to initialize
12646         dwp_file->num_sections.
12647
12648 2019-02-25  Tom Tromey  <tromey@adacore.com>
12649
12650         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
12651
12652 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
12653
12654         * gcore.in: Add '--readnever' option when invoking GDB.
12655
12656 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
12657
12658         * MAINTAINERS: Update my email address.
12659
12660 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
12661
12662         * build-id.c (build_id_to_debug_bfd_1): New function.
12663         (build_id_to_debug_bfd): Look for separate debug file in
12664         sysroot.
12665
12666 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
12667
12668         * gdbarch.sh: Update the copyright year range that is placed into
12669         generated files.
12670
12671 2019-02-22  Keith Seitz  <keiths@redhat.com>
12672
12673         PR symtab/23853
12674         * linespec.c (create_sals_line_offset): Search for the default
12675         symtab's filename instead of its fullname.
12676
12677 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
12678
12679         * NEWS: Update style defaults.
12680
12681 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
12682
12683         * main.c (captured_main_1): Disable styling in batch mode.
12684
12685 2019-02-20  Tom Tromey  <tom@tromey.com>
12686
12687         * symtab.c (symtab_symbol_info): Fix typos.
12688
12689 2019-02-20  Tom Tromey  <tromey@adacore.com>
12690
12691         * findcmd.c (_initialize_mem_search): Use upper case for
12692         metasyntactic variables.
12693
12694 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
12695
12696         * aarch64-tdep.c (aarch64_add_reggroups): New function.
12697         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
12698
12699 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
12700
12701         * top.h (source_file_name): Change to std::string.
12702         * top.c (source_file_name): Likewise.
12703         (command_line_input): Adjust.
12704         * cli/cli-script.c (script_from_file): Adjust.
12705
12706 2019-02-19  Tom Tromey  <tromey@adacore.com>
12707
12708         * ravenscar-thread.c
12709         (ravenscar_thread_target::update_thread_list): Don't call
12710         ada_build_task_list.
12711         * ada-lang.h (ada_build_task_list): Don't declare.
12712         * ada-tasks.c (struct ada_tasks_inferior_data)
12713         <task_list_valid_p>: Now bool.
12714         (read_known_tasks, ada_task_list_changed)
12715         (ada_tasks_invalidate_inferior_data): Update.
12716         (read_known_tasks_array): Return bool.
12717         (read_known_tasks_list): Likewise.
12718         (read_known_tasks): Return void.
12719         (ada_build_task_list): Now static.
12720
12721 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
12722
12723         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
12724         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
12725
12726 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12727
12728         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
12729         variant for ada_tasks_pspace_data_handle and
12730         ada_tasks_inferior_data_handle.
12731         (ada_tasks_pspace_data_cleanup): New function.
12732         (ada_tasks_inferior_data_cleanup): New function.
12733
12734 2019-02-17  Tom Tromey  <tom@tromey.com>
12735
12736         * macrotab.h (macro_source_fullname): Return a std::string.
12737         * macrotab.c (macro_include, check_for_redefinition)
12738         (macro_undef, macro_lookup_definition, foreach_macro)
12739         (foreach_macro_in_scope): Update.
12740         (macro_source_fullname): Return a std::string.
12741         * macrocmd.c (show_pp_source_pos): Update.
12742
12743 2019-02-17  Tom Tromey  <tom@tromey.com>
12744
12745         * macrocmd.c (show_pp_source_pos): Style the file names.
12746
12747 2019-02-17  Tom Tromey  <tom@tromey.com>
12748
12749         PR tui/24197:
12750         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
12751
12752 2019-02-17  Tom Tromey  <tom@tromey.com>
12753
12754         * ada-lang.c (user_select_syms): Use filtered printing.
12755         * utils.c (wrap_style): New global.
12756         (desired_style): Remove.
12757         (emit_style_escape): Add stream parameter.
12758         (set_output_style, reset_terminal_style, prompt_for_continue):
12759         Update.
12760         (flush_wrap_buffer): Only flush gdb_stdout.
12761         (wrap_here): Set wrap_style.
12762         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
12763         treat escape sequences as a character.  Change when wrap buffer is
12764         flushed.
12765         (fputs_styled): Do not set the output style when the default is
12766         requested.
12767         * ui-style.h (struct ui_file_style) <is_default>: New method.
12768         * source.c (print_source_lines_base): Emit escape sequences in one
12769         piece.
12770
12771 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
12772
12773         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
12774         integers and enumeration types.
12775
12776 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
12777
12778         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
12779         instead of lookup_symbol_in_language
12780         (do_exact_match): New function.
12781         (ada_get_symbol_name_matcher): Return do_exact_match when
12782         doing a verbatim match.
12783
12784 2019-02-15  Tom Tromey  <tromey@adacore.com>
12785
12786         * ravenscar-thread.c (ravenscar_thread_target::resume)
12787         (ravenscar_thread_target::wait): Special case wildcard requests.
12788
12789 2019-02-15  Tom Tromey  <tromey@adacore.com>
12790
12791         * ravenscar-thread.c (base_ptid): Remove.
12792         (struct ravenscar_thread_target) <close>: New method.
12793         <m_base_ptid>: New member.
12794         <update_inferior_ptid, active_task, task_is_currently_active,
12795         runtime_initialized>: Declare methods.
12796         <ravenscar_thread_target>: Add constructor.
12797         (ravenscar_thread_target::task_is_currently_active)
12798         (ravenscar_thread_target::update_inferior_ptid)
12799         (ravenscar_runtime_initialized): Rename.  Now methods.
12800         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
12801         (ravenscar_thread_target::update_thread_list): Update.
12802         (ravenscar_thread_target::active_task): Now method.
12803         (ravenscar_thread_target::store_registers)
12804         (ravenscar_thread_target::prepare_to_store)
12805         (ravenscar_thread_target::prepare_to_store)
12806         (ravenscar_thread_target::mourn_inferior): Update.
12807         (ravenscar_inferior_created): Use "new" to create target.
12808         (ravenscar_thread_target::get_ada_task_ptid): Update.
12809         (_initialize_ravenscar): Don't initialize base_ptid.
12810         (ravenscar_ops): Remove global.
12811
12812 2019-02-15  Tom Tromey  <tromey@adacore.com>
12813
12814         * target.h (push_target): Declare new overload.
12815         * target.c (push_target): New overload, taking an rvalue reference.
12816         * remote.c (remote_target::open_1): Use push_target overload.
12817         * corelow.c (core_target_open): Use push_target overload.
12818
12819 2019-02-15  Tom Tromey  <tromey@adacore.com>
12820
12821         * ravenscar-thread.c (is_ravenscar_task)
12822         (ravenscar_task_is_currently_active): Return bool.
12823         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
12824         (_initialize_ravenscar): Remove "(void)".
12825         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
12826         Return bool.
12827
12828 2019-02-15  Tom Tromey  <tromey@adacore.com>
12829
12830         * ravenscar-thread.c (ravenscar_runtime_initializer)
12831         (has_ravenscar_runtime, get_running_thread_id)
12832         (ravenscar_thread_target::resume): Fix indentation.
12833
12834 2019-02-15  Tom Tromey  <tromey@adacore.com>
12835
12836         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
12837         from ravenscar_arch_ops.
12838         (sparc_ravenscar_ops::fetch_registers)
12839         (sparc_ravenscar_ops::store_registers): Now methods.
12840         (sparc_ravenscar_prepare_to_store): Remove.
12841         (sparc_ravenscar_ops): Redefine.
12842         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
12843         methods and destructor.  Remove members.
12844         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
12845         (ravenscar_thread_target::store_registers)
12846         (ravenscar_thread_target::prepare_to_store): Update.
12847         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
12848         Remove.
12849         (struct ppc_ravenscar_powerpc_ops): Derive from
12850         ravenscar_arch_ops.
12851         (ppc_ravenscar_powerpc_ops::fetch_registers)
12852         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
12853         (ppc_ravenscar_powerpc_ops): Redefine.
12854         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
12855         (ppc_ravenscar_e500_ops::fetch_registers)
12856         (ppc_ravenscar_e500_ops::store_registers): Now methods.
12857         (ppc_ravenscar_e500_ops): Redefine.
12858         * aarch64-ravenscar-thread.c
12859         (aarch64_ravenscar_generic_prepare_to_store): Remove.
12860         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
12861         (aarch64_ravenscar_fetch_registers)
12862         (aarch64_ravenscar_store_registers): Now methods.
12863         (aarch64_ravenscar_ops): Redefine.
12864
12865 2019-02-15  Tom Tromey  <tromey@adacore.com>
12866
12867         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
12868         (ravenscar_thread_target::stopped_by_hw_breakpoint)
12869         (ravenscar_thread_target::stopped_by_watchpoint)
12870         (ravenscar_thread_target::stopped_data_address)
12871         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
12872
12873 2019-02-15  Tom Tromey  <tromey@adacore.com>
12874
12875         * ravenscar-thread.c: Fix some typos.
12876
12877 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12878             Tom Tromey  <tromey@adacore.com>
12879
12880         * ada-lang.c (ada_exception_sal): Change addr_string to a
12881         std::string.
12882         (create_ada_exception_catchpoint): Update.
12883
12884 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12885             Tom Tromey  <tromey@adacore.com>
12886
12887         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
12888         (bp_location_ops): Remove.
12889         (base_breakpoint_allocate_location): Update.
12890         (free_bp_location): Update.
12891         * ada-lang.c (class ada_catchpoint_location)
12892         <ada_catchpoint_location>: Remove ops parameter.
12893         (ada_catchpoint_location_dtor): Remove.
12894         (ada_catchpoint_location_ops): Remove.
12895         (allocate_location_exception): Update.
12896         * breakpoint.h (struct bp_location_ops): Remove.
12897         (class bp_location) <bp_location>: Remove bp_location_ops
12898         parameter.
12899         <~bp_location>: Add destructor.
12900         <ops>: Remove.
12901
12902 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
12903             Pedro Alves  <palves@redhat.com>
12904
12905         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
12906         'PATH_MAX'.
12907
12908 2019-02-14  David Michael  <fedora.dm0@gmail.com>
12909             Samuel Thibault  <samuel.thibault@gnu.org>
12910             Thomas Schwinge  <thomas@codesourcery.com>
12911
12912         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
12913         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
12914
12915 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
12916
12917         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
12918         (check_empty): Use "const char *".
12919
12920         * gnu-nat.c (gnu_nat_target::detach): Instead of
12921         'detach_inferior (pid)' call
12922         'detach_inferior (find_inferior_pid (pid))'.
12923
12924         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
12925         'nat/fork-inferior.o'.
12926         * gnu-nat.c: #include "nat/fork-inferior.h".
12927
12928         * gnu-nat.c (gnu_nat_target::detach): Instead of
12929         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
12930         * gnu-nat.h: #include "inf-child.h".
12931         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
12932         'i386_gnu_nat_target::fetch_registers'.
12933         (gnu_store_registers): Rename/move to
12934         'i386_gnu_nat_target::store_registers'.
12935
12936         * config/i386/nm-i386gnu.h: Don't "#include" any files.
12937         * gnu-nat.h (mach_thread_info): New function.
12938         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
12939
12940         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
12941
12942 2019-02-14  Frederic Konrad  <konrad@adacore.com>
12943
12944         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
12945
12946 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
12947
12948         * windows-nat.c (windows_add_thread): Add new parameter
12949         "main_thread_p" with default value set to false.  Update
12950         function documentation as well as all callers.
12951         (windows_delete_thread): Likewise.
12952         (fake_create_process): Update call to windows_add_thread.
12953         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
12954         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
12955         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
12956         call to windows_delete_thread.
12957
12958 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
12959
12960         * MAINTAINERS: Add Andrew Burgess as global maintainer.
12961
12962 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
12963
12964         * symfile.c (find_separate_debug_file): Use canonical path of
12965         sysroot with child_path instead of gdb_sysroot if it is valid.
12966
12967 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
12968
12969         * symfile.c (find_separate_debug_file): Use child_path to
12970         determine if an object file is under a sysroot.
12971
12972 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
12973
12974         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
12975         unittests/child-path-selftests.c.
12976         * common/pathstuff.c (child_path): New function.
12977         * common/pathstuff.h (child_path): New prototype.
12978         * unittests/child-path-selftests.c: New file.
12979
12980 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
12981
12982         * symfile.c (find_separate_debug_file): Look for separate debug
12983         files in debug directories under the sysroot.
12984
12985 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12986
12987         * symtab.h (struct minimal_symbol data_p): New const method.
12988         (struct minimal_symbol text_p): Likewise.
12989         * symtab.c (output_source_filename): Use file name style
12990         to print file name.
12991         (print_symbol_info): Likewise.
12992         (print_msymbol_info): Use address style to print addresses.
12993         Use function name style to print executable text symbols.
12994         (expand_symtab_containing_pc): Use data_p.
12995         (find_pc_sect_compunit_symtab): Likewise.
12996
12997 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12998
12999         * breakpoint.c (describe_other_breakpoints): Use address style
13000         to print addresses.
13001         (say_where): Likewise.
13002
13003 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13004
13005         * ada-typeprint.c (print_func_type): Print function name
13006         style to print function name.
13007         * c-typeprint.c (c_print_type_1): Likewise.
13008
13009 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
13010
13011         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
13012         for execve.
13013
13014 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13015
13016         * c-exp.y (direct_abs_decl): Use emplace_back to record the
13017         type_stack.
13018
13019 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
13020
13021         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
13022         TYPE_CODE_REF types.
13023
13024 2019-02-08  Jim Wilson  <jimw@sifive.com>
13025
13026         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
13027         (riscv_linux_fregset): New.
13028         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
13029
13030 2019-02-07  Tom Tromey  <tom@tromey.com>
13031
13032         * thread.c (thread_cancel_execution_command): Update.
13033         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
13034         methods.
13035         (struct thread_fsm_ops): Remove.
13036         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
13037         (thread_fsm_should_stop, thread_fsm_return_value)
13038         (thread_fsm_set_finished, thread_fsm_finished_p)
13039         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
13040         Don't declare.
13041         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
13042         * infrun.c (clear_proceed_status_thread)
13043         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
13044         (print_stop_event): Update.
13045         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
13046         Add constructor.
13047         (step_command_fsm_ops): Remove.
13048         (new_step_command_fsm): Remove.
13049         (step_1): Update.
13050         (step_command_fsm::should_stop): Rename from
13051         step_command_fsm_should_stop.
13052         (step_command_fsm::clean_up): Rename from
13053         step_command_fsm_clean_up.
13054         (step_command_fsm::do_async_reply_reason): Rename from
13055         step_command_fsm_async_reply_reason.
13056         (struct until_next_fsm): Inherit from thread_fsm.  Add
13057         constructor.
13058         (until_next_fsm_ops): Remove.
13059         (new_until_next_fsm): Remove.
13060         (until_next_fsm::should_stop): Rename from
13061         until_next_fsm_should_stop.
13062         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
13063         (until_next_fsm::do_async_reply_reason): Rename from
13064         until_next_fsm_async_reply_reason.
13065         (struct finish_command_fsm): Inherit from thread_fsm.  Add
13066         constructor.  Change type of breakpoint.
13067         (finish_command_fsm_ops): Remove.
13068         (new_finish_command_fsm): Remove.
13069         (finish_command_fsm::should_stop): Rename from
13070         finish_command_fsm_should_stop.
13071         (finish_command_fsm::clean_up): Rename from
13072         finish_command_fsm_clean_up.
13073         (finish_command_fsm::return_value): Rename from
13074         finish_command_fsm_return_value.
13075         (finish_command_fsm::do_async_reply_reason): Rename from
13076         finish_command_fsm_async_reply_reason.
13077         (finish_command): Update.
13078         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
13079         Add constructor.
13080         (call_thread_fsm_ops): Remove.
13081         (call_thread_fsm::call_thread_fsm): Rename from
13082         new_call_thread_fsm.
13083         (call_thread_fsm::should_stop): Rename from
13084         call_thread_fsm_should_stop.
13085         (call_thread_fsm::should_notify_stop): Rename from
13086         call_thread_fsm_should_notify_stop.
13087         (run_inferior_call, call_function_by_hand_dummy): Update.
13088         * cli/cli-interp.c (should_print_stop_to_console): Update.
13089         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
13090         Add constructor.  Change type of location_breakpoint,
13091         caller_breakpoint.
13092         (until_break_fsm_ops): Remove.
13093         (new_until_break_fsm): Remove.
13094         (until_break_fsm::should_stop): Rename from
13095         until_break_fsm_should_stop.
13096         (until_break_fsm::clean_up): Rename from
13097         until_break_fsm_clean_up.
13098         (until_break_fsm::do_async_reply_reason): Rename from
13099         until_break_fsm_async_reply_reason.
13100         (until_break_command): Update.
13101         * thread-fsm.c: Remove.
13102         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
13103
13104 2019-02-07  Tom Tromey  <tom@tromey.com>
13105
13106         * yy-remap.h: Add include guard.
13107         * xtensa-tdep.h: Add include guard.
13108         * xcoffread.h: Rename include guard.
13109         * varobj-iter.h: Add include guard.
13110         * tui/tui.h: Rename include guard.
13111         * tui/tui-winsource.h: Rename include guard.
13112         * tui/tui-wingeneral.h: Rename include guard.
13113         * tui/tui-windata.h: Rename include guard.
13114         * tui/tui-win.h: Rename include guard.
13115         * tui/tui-stack.h: Rename include guard.
13116         * tui/tui-source.h: Rename include guard.
13117         * tui/tui-regs.h: Rename include guard.
13118         * tui/tui-out.h: Rename include guard.
13119         * tui/tui-layout.h: Rename include guard.
13120         * tui/tui-io.h: Rename include guard.
13121         * tui/tui-hooks.h: Rename include guard.
13122         * tui/tui-file.h: Rename include guard.
13123         * tui/tui-disasm.h: Rename include guard.
13124         * tui/tui-data.h: Rename include guard.
13125         * tui/tui-command.h: Rename include guard.
13126         * tic6x-tdep.h: Add include guard.
13127         * target/waitstatus.h: Rename include guard.
13128         * target/wait.h: Rename include guard.
13129         * target/target.h: Rename include guard.
13130         * target/resume.h: Rename include guard.
13131         * target-float.h: Rename include guard.
13132         * stabsread.h: Add include guard.
13133         * rs6000-tdep.h: Add include guard.
13134         * riscv-fbsd-tdep.h: Add include guard.
13135         * regformats/regdef.h: Rename include guard.
13136         * record.h: Rename include guard.
13137         * python/python.h: Rename include guard.
13138         * python/python-internal.h: Rename include guard.
13139         * python/py-stopevent.h: Rename include guard.
13140         * python/py-ref.h: Rename include guard.
13141         * python/py-record.h: Rename include guard.
13142         * python/py-record-full.h: Rename include guard.
13143         * python/py-record-btrace.h: Rename include guard.
13144         * python/py-instruction.h: Rename include guard.
13145         * python/py-events.h: Rename include guard.
13146         * python/py-event.h: Rename include guard.
13147         * procfs.h: Add include guard.
13148         * proc-utils.h: Add include guard.
13149         * p-lang.h: Add include guard.
13150         * or1k-tdep.h: Rename include guard.
13151         * observable.h: Rename include guard.
13152         * nto-tdep.h: Rename include guard.
13153         * nat/x86-linux.h: Rename include guard.
13154         * nat/x86-linux-dregs.h: Rename include guard.
13155         * nat/x86-gcc-cpuid.h: Add include guard.
13156         * nat/x86-dregs.h: Rename include guard.
13157         * nat/x86-cpuid.h: Rename include guard.
13158         * nat/ppc-linux.h: Rename include guard.
13159         * nat/mips-linux-watch.h: Rename include guard.
13160         * nat/linux-waitpid.h: Rename include guard.
13161         * nat/linux-ptrace.h: Rename include guard.
13162         * nat/linux-procfs.h: Rename include guard.
13163         * nat/linux-osdata.h: Rename include guard.
13164         * nat/linux-nat.h: Rename include guard.
13165         * nat/linux-namespaces.h: Rename include guard.
13166         * nat/linux-btrace.h: Rename include guard.
13167         * nat/glibc_thread_db.h: Rename include guard.
13168         * nat/gdb_thread_db.h: Rename include guard.
13169         * nat/gdb_ptrace.h: Rename include guard.
13170         * nat/fork-inferior.h: Rename include guard.
13171         * nat/amd64-linux-siginfo.h: Rename include guard.
13172         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
13173         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
13174         * nat/aarch64-linux.h: Rename include guard.
13175         * nat/aarch64-linux-hw-point.h: Rename include guard.
13176         * mn10300-tdep.h: Add include guard.
13177         * mips-linux-tdep.h: Add include guard.
13178         * mi/mi-parse.h: Rename include guard.
13179         * mi/mi-out.h: Rename include guard.
13180         * mi/mi-main.h: Rename include guard.
13181         * mi/mi-interp.h: Rename include guard.
13182         * mi/mi-getopt.h: Rename include guard.
13183         * mi/mi-console.h: Rename include guard.
13184         * mi/mi-common.h: Rename include guard.
13185         * mi/mi-cmds.h: Rename include guard.
13186         * mi/mi-cmd-break.h: Rename include guard.
13187         * m2-lang.h: Add include guard.
13188         * location.h: Rename include guard.
13189         * linux-record.h: Rename include guard.
13190         * linux-nat.h: Add include guard.
13191         * linux-fork.h: Add include guard.
13192         * i386-darwin-tdep.h: Rename include guard.
13193         * hppa-linux-offsets.h: Add include guard.
13194         * guile/guile.h: Rename include guard.
13195         * guile/guile-internal.h: Rename include guard.
13196         * gnu-nat.h: Rename include guard.
13197         * gdb-stabs.h: Rename include guard.
13198         * frv-tdep.h: Add include guard.
13199         * f-lang.h: Add include guard.
13200         * event-loop.h: Add include guard.
13201         * darwin-nat.h: Rename include guard.
13202         * cp-abi.h: Rename include guard.
13203         * config/sparc/nm-sol2.h: Rename include guard.
13204         * config/nm-nto.h: Rename include guard.
13205         * config/nm-linux.h: Add include guard.
13206         * config/i386/nm-i386gnu.h: Rename include guard.
13207         * config/djgpp/nl_types.h: Rename include guard.
13208         * config/djgpp/langinfo.h: Rename include guard.
13209         * compile/gcc-cp-plugin.h: Add include guard.
13210         * compile/gcc-c-plugin.h: Add include guard.
13211         * compile/compile.h: Rename include guard.
13212         * compile/compile-object-run.h: Rename include guard.
13213         * compile/compile-object-load.h: Rename include guard.
13214         * compile/compile-internal.h: Rename include guard.
13215         * compile/compile-cplus.h: Rename include guard.
13216         * compile/compile-c.h: Rename include guard.
13217         * common/xml-utils.h: Rename include guard.
13218         * common/x86-xstate.h: Rename include guard.
13219         * common/version.h: Rename include guard.
13220         * common/vec.h: Rename include guard.
13221         * common/tdesc.h: Rename include guard.
13222         * common/selftest.h: Rename include guard.
13223         * common/scoped_restore.h: Rename include guard.
13224         * common/scoped_mmap.h: Rename include guard.
13225         * common/scoped_fd.h: Rename include guard.
13226         * common/safe-iterator.h: Rename include guard.
13227         * common/run-time-clock.h: Rename include guard.
13228         * common/refcounted-object.h: Rename include guard.
13229         * common/queue.h: Rename include guard.
13230         * common/ptid.h: Rename include guard.
13231         * common/print-utils.h: Rename include guard.
13232         * common/preprocessor.h: Rename include guard.
13233         * common/pathstuff.h: Rename include guard.
13234         * common/observable.h: Rename include guard.
13235         * common/netstuff.h: Rename include guard.
13236         * common/job-control.h: Rename include guard.
13237         * common/host-defs.h: Rename include guard.
13238         * common/gdb_wait.h: Rename include guard.
13239         * common/gdb_vecs.h: Rename include guard.
13240         * common/gdb_unlinker.h: Rename include guard.
13241         * common/gdb_unique_ptr.h: Rename include guard.
13242         * common/gdb_tilde_expand.h: Rename include guard.
13243         * common/gdb_sys_time.h: Rename include guard.
13244         * common/gdb_string_view.h: Rename include guard.
13245         * common/gdb_splay_tree.h: Rename include guard.
13246         * common/gdb_setjmp.h: Rename include guard.
13247         * common/gdb_ref_ptr.h: Rename include guard.
13248         * common/gdb_optional.h: Rename include guard.
13249         * common/gdb_locale.h: Rename include guard.
13250         * common/gdb_assert.h: Rename include guard.
13251         * common/filtered-iterator.h: Rename include guard.
13252         * common/filestuff.h: Rename include guard.
13253         * common/fileio.h: Rename include guard.
13254         * common/environ.h: Rename include guard.
13255         * common/common-utils.h: Rename include guard.
13256         * common/common-types.h: Rename include guard.
13257         * common/common-regcache.h: Rename include guard.
13258         * common/common-inferior.h: Rename include guard.
13259         * common/common-gdbthread.h: Rename include guard.
13260         * common/common-exceptions.h: Rename include guard.
13261         * common/common-defs.h: Rename include guard.
13262         * common/common-debug.h: Rename include guard.
13263         * common/cleanups.h: Rename include guard.
13264         * common/buffer.h: Rename include guard.
13265         * common/btrace-common.h: Rename include guard.
13266         * common/break-common.h: Rename include guard.
13267         * cli/cli-utils.h: Rename include guard.
13268         * cli/cli-style.h: Rename include guard.
13269         * cli/cli-setshow.h: Rename include guard.
13270         * cli/cli-script.h: Rename include guard.
13271         * cli/cli-interp.h: Rename include guard.
13272         * cli/cli-decode.h: Rename include guard.
13273         * cli/cli-cmds.h: Rename include guard.
13274         * charset-list.h: Add include guard.
13275         * buildsym-legacy.h: Rename include guard.
13276         * bfin-tdep.h: Add include guard.
13277         * ax.h: Rename include guard.
13278         * arm-linux-tdep.h: Add include guard.
13279         * arm-fbsd-tdep.h: Add include guard.
13280         * arch/xtensa.h: Rename include guard.
13281         * arch/tic6x.h: Add include guard.
13282         * arch/i386.h: Add include guard.
13283         * arch/arm.h: Rename include guard.
13284         * arch/arm-linux.h: Rename include guard.
13285         * arch/arm-get-next-pcs.h: Rename include guard.
13286         * arch/amd64.h: Add include guard.
13287         * arch/aarch64-insn.h: Rename include guard.
13288         * arch-utils.h: Rename include guard.
13289         * annotate.h: Add include guard.
13290         * amd64-darwin-tdep.h: Rename include guard.
13291         * aarch64-linux-tdep.h: Add include guard.
13292         * aarch64-fbsd-tdep.h: Add include guard.
13293         * aarch32-linux-nat.h: Add include guard.
13294
13295 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13296
13297         * macrotab.c (macro_define_internal): New function that
13298         factorizes macro_define_object_internal and macro_define_function
13299         code.
13300         (macro_define_object_internal): Use macro_define_internal.
13301         (macro_define_function): Likewise.
13302
13303 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13304
13305         * macrocmd.c (extract_identifier): Return
13306         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
13307         callers.
13308
13309 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
13310
13311         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
13312
13313 2019-02-05  Tom Tromey  <tom@tromey.com>
13314
13315         * target.c (target_stack::unpush): Move assertion earlier.
13316
13317 2019-01-30  Tom Tromey  <tom@tromey.com>
13318
13319         PR python/23615:
13320         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
13321         (gdbpy_parse_and_eval): Likewise.
13322         * python/python-internal.h (gdbpy_allow_threads): New class.
13323
13324 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
13325
13326         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
13327         (aarch64_fbsd_fpregmap): Move earlier.
13328         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
13329         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
13330         instead of individual calls to trad_frame_set_reg_addr.
13331         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
13332         earlier.
13333         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
13334         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
13335         instead of individual calls to trad_frame_set_reg_addr.
13336
13337 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
13338
13339         * CONTRIBUTE: Replace contribution list with wiki link.
13340
13341 2019-01-25  Tom Tromey  <tom@tromey.com>
13342
13343         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
13344
13345 2019-01-25  Tom Tromey  <tom@tromey.com>
13346
13347         * xtensa-linux-nat.c: Fix common/ includes.
13348         * xml-support.h: Fix common/ includes.
13349         * xml-support.c: Fix common/ includes.
13350         * x86-linux-nat.c: Fix common/ includes.
13351         * windows-nat.c: Fix common/ includes.
13352         * varobj.h: Fix common/ includes.
13353         * varobj.c: Fix common/ includes.
13354         * value.c: Fix common/ includes.
13355         * valops.c: Fix common/ includes.
13356         * utils.c: Fix common/ includes.
13357         * unittests/xml-utils-selftests.c: Fix common/ includes.
13358         * unittests/utils-selftests.c: Fix common/ includes.
13359         * unittests/unpack-selftests.c: Fix common/ includes.
13360         * unittests/tracepoint-selftests.c: Fix common/ includes.
13361         * unittests/style-selftests.c: Fix common/ includes.
13362         * unittests/string_view-selftests.c: Fix common/ includes.
13363         * unittests/scoped_restore-selftests.c: Fix common/ includes.
13364         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
13365         * unittests/scoped_fd-selftests.c: Fix common/ includes.
13366         * unittests/rsp-low-selftests.c: Fix common/ includes.
13367         * unittests/parse-connection-spec-selftests.c: Fix common/
13368         includes.
13369         * unittests/optional-selftests.c: Fix common/ includes.
13370         * unittests/offset-type-selftests.c: Fix common/ includes.
13371         * unittests/observable-selftests.c: Fix common/ includes.
13372         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
13373         * unittests/memrange-selftests.c: Fix common/ includes.
13374         * unittests/memory-map-selftests.c: Fix common/ includes.
13375         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
13376         * unittests/function-view-selftests.c: Fix common/ includes.
13377         * unittests/environ-selftests.c: Fix common/ includes.
13378         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
13379         * unittests/common-utils-selftests.c: Fix common/ includes.
13380         * unittests/cli-utils-selftests.c: Fix common/ includes.
13381         * unittests/array-view-selftests.c: Fix common/ includes.
13382         * ui-file.c: Fix common/ includes.
13383         * tui/tui-io.c: Fix common/ includes.
13384         * tracepoint.h: Fix common/ includes.
13385         * tracepoint.c: Fix common/ includes.
13386         * tracefile-tfile.c: Fix common/ includes.
13387         * top.h: Fix common/ includes.
13388         * top.c: Fix common/ includes.
13389         * thread.c: Fix common/ includes.
13390         * target/waitstatus.h: Fix common/ includes.
13391         * target/waitstatus.c: Fix common/ includes.
13392         * target.h: Fix common/ includes.
13393         * target.c: Fix common/ includes.
13394         * target-memory.c: Fix common/ includes.
13395         * target-descriptions.c: Fix common/ includes.
13396         * symtab.h: Fix common/ includes.
13397         * symfile.c: Fix common/ includes.
13398         * stap-probe.c: Fix common/ includes.
13399         * spu-linux-nat.c: Fix common/ includes.
13400         * sparc-nat.c: Fix common/ includes.
13401         * source.c: Fix common/ includes.
13402         * solib.c: Fix common/ includes.
13403         * solib-target.c: Fix common/ includes.
13404         * ser-unix.c: Fix common/ includes.
13405         * ser-tcp.c: Fix common/ includes.
13406         * ser-pipe.c: Fix common/ includes.
13407         * ser-base.c: Fix common/ includes.
13408         * selftest-arch.c: Fix common/ includes.
13409         * s12z-tdep.c: Fix common/ includes.
13410         * rust-exp.y: Fix common/ includes.
13411         * rs6000-aix-tdep.c: Fix common/ includes.
13412         * riscv-tdep.c: Fix common/ includes.
13413         * remote.c: Fix common/ includes.
13414         * remote-notif.h: Fix common/ includes.
13415         * remote-fileio.h: Fix common/ includes.
13416         * remote-fileio.c: Fix common/ includes.
13417         * regcache.h: Fix common/ includes.
13418         * regcache.c: Fix common/ includes.
13419         * record-btrace.c: Fix common/ includes.
13420         * python/python.c: Fix common/ includes.
13421         * python/py-type.c: Fix common/ includes.
13422         * python/py-inferior.c: Fix common/ includes.
13423         * progspace.h: Fix common/ includes.
13424         * producer.c: Fix common/ includes.
13425         * procfs.c: Fix common/ includes.
13426         * proc-api.c: Fix common/ includes.
13427         * printcmd.c: Fix common/ includes.
13428         * ppc-linux-nat.c: Fix common/ includes.
13429         * parser-defs.h: Fix common/ includes.
13430         * osdata.c: Fix common/ includes.
13431         * obsd-nat.c: Fix common/ includes.
13432         * nat/x86-linux.c: Fix common/ includes.
13433         * nat/x86-linux-dregs.c: Fix common/ includes.
13434         * nat/x86-dregs.h: Fix common/ includes.
13435         * nat/x86-dregs.c: Fix common/ includes.
13436         * nat/ppc-linux.c: Fix common/ includes.
13437         * nat/mips-linux-watch.h: Fix common/ includes.
13438         * nat/mips-linux-watch.c: Fix common/ includes.
13439         * nat/linux-waitpid.c: Fix common/ includes.
13440         * nat/linux-ptrace.h: Fix common/ includes.
13441         * nat/linux-ptrace.c: Fix common/ includes.
13442         * nat/linux-procfs.c: Fix common/ includes.
13443         * nat/linux-personality.c: Fix common/ includes.
13444         * nat/linux-osdata.c: Fix common/ includes.
13445         * nat/linux-namespaces.c: Fix common/ includes.
13446         * nat/linux-btrace.h: Fix common/ includes.
13447         * nat/linux-btrace.c: Fix common/ includes.
13448         * nat/fork-inferior.c: Fix common/ includes.
13449         * nat/amd64-linux-siginfo.c: Fix common/ includes.
13450         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
13451         * nat/aarch64-linux.c: Fix common/ includes.
13452         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
13453         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
13454         * namespace.h: Fix common/ includes.
13455         * mips-linux-tdep.c: Fix common/ includes.
13456         * minsyms.c: Fix common/ includes.
13457         * mi/mi-parse.h: Fix common/ includes.
13458         * mi/mi-main.c: Fix common/ includes.
13459         * mi/mi-cmd-env.c: Fix common/ includes.
13460         * memrange.h: Fix common/ includes.
13461         * memattr.c: Fix common/ includes.
13462         * maint.h: Fix common/ includes.
13463         * maint.c: Fix common/ includes.
13464         * main.c: Fix common/ includes.
13465         * machoread.c: Fix common/ includes.
13466         * location.c: Fix common/ includes.
13467         * linux-thread-db.c: Fix common/ includes.
13468         * linux-nat.c: Fix common/ includes.
13469         * linux-fork.c: Fix common/ includes.
13470         * inline-frame.c: Fix common/ includes.
13471         * infrun.c: Fix common/ includes.
13472         * inflow.c: Fix common/ includes.
13473         * inferior.h: Fix common/ includes.
13474         * inferior.c: Fix common/ includes.
13475         * infcmd.c: Fix common/ includes.
13476         * inf-ptrace.c: Fix common/ includes.
13477         * inf-child.c: Fix common/ includes.
13478         * ia64-linux-nat.c: Fix common/ includes.
13479         * i387-tdep.c: Fix common/ includes.
13480         * i386-tdep.c: Fix common/ includes.
13481         * i386-linux-tdep.c: Fix common/ includes.
13482         * i386-linux-nat.c: Fix common/ includes.
13483         * i386-go32-tdep.c: Fix common/ includes.
13484         * i386-fbsd-tdep.c: Fix common/ includes.
13485         * i386-fbsd-nat.c: Fix common/ includes.
13486         * guile/scm-type.c: Fix common/ includes.
13487         * guile/guile.c: Fix common/ includes.
13488         * go32-nat.c: Fix common/ includes.
13489         * gnu-nat.c: Fix common/ includes.
13490         * gdbthread.h: Fix common/ includes.
13491         * gdbarch-selftests.c: Fix common/ includes.
13492         * gdb_usleep.c: Fix common/ includes.
13493         * gdb_select.h: Fix common/ includes.
13494         * gdb_bfd.c: Fix common/ includes.
13495         * gcore.c: Fix common/ includes.
13496         * fork-child.c: Fix common/ includes.
13497         * findvar.c: Fix common/ includes.
13498         * fbsd-nat.c: Fix common/ includes.
13499         * event-top.c: Fix common/ includes.
13500         * event-loop.c: Fix common/ includes.
13501         * dwarf2read.c: Fix common/ includes.
13502         * dwarf2loc.c: Fix common/ includes.
13503         * dwarf2-frame.c: Fix common/ includes.
13504         * dwarf-index-cache.c: Fix common/ includes.
13505         * dtrace-probe.c: Fix common/ includes.
13506         * disasm-selftests.c: Fix common/ includes.
13507         * defs.h: Fix common/ includes.
13508         * csky-tdep.c: Fix common/ includes.
13509         * cp-valprint.c: Fix common/ includes.
13510         * cp-support.h: Fix common/ includes.
13511         * cp-support.c: Fix common/ includes.
13512         * corelow.c: Fix common/ includes.
13513         * completer.h: Fix common/ includes.
13514         * completer.c: Fix common/ includes.
13515         * compile/compile.c: Fix common/ includes.
13516         * compile/compile-loc2c.c: Fix common/ includes.
13517         * compile/compile-cplus-types.c: Fix common/ includes.
13518         * compile/compile-cplus-symbols.c: Fix common/ includes.
13519         * command.h: Fix common/ includes.
13520         * cli/cli-dump.c: Fix common/ includes.
13521         * cli/cli-cmds.c: Fix common/ includes.
13522         * charset.c: Fix common/ includes.
13523         * build-id.c: Fix common/ includes.
13524         * btrace.h: Fix common/ includes.
13525         * btrace.c: Fix common/ includes.
13526         * breakpoint.h: Fix common/ includes.
13527         * breakpoint.c: Fix common/ includes.
13528         * ax.h:
13529         (enum agent_op): Fix common/ includes.
13530         * ax-general.c (struct aop_map): Fix common/ includes.
13531         * ax-gdb.c: Fix common/ includes.
13532         * auxv.c: Fix common/ includes.
13533         * auto-load.c: Fix common/ includes.
13534         * arm-tdep.c: Fix common/ includes.
13535         * arch/riscv.c: Fix common/ includes.
13536         * arch/ppc-linux-common.c: Fix common/ includes.
13537         * arch/i386.c: Fix common/ includes.
13538         * arch/arm.c: Fix common/ includes.
13539         * arch/arm-linux.c: Fix common/ includes.
13540         * arch/arm-get-next-pcs.c: Fix common/ includes.
13541         * arch/amd64.c: Fix common/ includes.
13542         * arch/aarch64.c: Fix common/ includes.
13543         * arch/aarch64-insn.c: Fix common/ includes.
13544         * arch-utils.c: Fix common/ includes.
13545         * amd64-windows-tdep.c: Fix common/ includes.
13546         * amd64-tdep.c: Fix common/ includes.
13547         * amd64-sol2-tdep.c: Fix common/ includes.
13548         * amd64-obsd-tdep.c: Fix common/ includes.
13549         * amd64-nbsd-tdep.c: Fix common/ includes.
13550         * amd64-linux-tdep.c: Fix common/ includes.
13551         * amd64-linux-nat.c: Fix common/ includes.
13552         * amd64-fbsd-tdep.c: Fix common/ includes.
13553         * amd64-fbsd-nat.c: Fix common/ includes.
13554         * amd64-dicos-tdep.c: Fix common/ includes.
13555         * amd64-darwin-tdep.c: Fix common/ includes.
13556         * agent.c: Fix common/ includes.
13557         * ada-lang.h: Fix common/ includes.
13558         * ada-lang.c: Fix common/ includes.
13559         * aarch64-tdep.c: Fix common/ includes.
13560
13561 2019-01-25  Tom Tromey  <tom@tromey.com>
13562
13563         * common/create-version.sh: Use common/version.h.
13564
13565 2019-01-24  Pedro Alves  <palves@redhat.com>
13566
13567         * infrun.c (signal_stop, signal_print, signal_program)
13568         (signal_catch, signal_pass): Now arrays instead of pointers.
13569         (update_signals_program_target, do_target_resume)
13570         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
13571         * linux-nat.c (linux_nat_target::pass_signals)
13572         (linux_nat_target::create_inferior, linux_nat_target::attach):
13573         Adjust.
13574         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
13575         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
13576         * procfs.c (procfs_target::pass_signals): Adjust.
13577         * record-full.c (record_full_target::resume): Adjust.
13578         * remote.c (remote_target::pass_signals)
13579         (remote_target::program_signals): Adjust.
13580         * target-debug.h (target_debug_print_signals): Now takes a
13581         gdb::array_view as parameter.  Adjust.
13582         * target.h (target_ops) <pass_signals, program_signals>: Replace
13583         pointer and length parameters with gdb::array_view.
13584         (target_pass_signals, target_program_signals): Likewise.
13585         * target-delegates.c: Regenerate.
13586
13587 2019-01-24  Pedro Alves  <palves@redhat.com>
13588
13589         * common/forward-scope-exit.h
13590         (forward_scope_exit::forward_scope_exit): Pass arguments to
13591         m_bind_function directly, instead of creating a std::bind and
13592         copying that.
13593
13594 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
13595
13596         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
13597         for static members.
13598         (pass_in_v_vfp_candidate): Likewise.
13599
13600 2019-01-23  Tom Tromey  <tom@tromey.com>
13601             Pedro Alves  <palves@redhat.com>
13602
13603         * regcache.c (class regcache_invalidator): Remove.
13604         (regcache::raw_write): Use make_scope_exit.
13605
13606 2019-01-23  Tom Tromey  <tom@tromey.com>
13607
13608         * ui-out.h (class ui_out_emit_type): Update comment.
13609
13610 2019-01-23  Tom Tromey  <tom@tromey.com>
13611
13612         * infrun.c (fetch_inferior_event): Update comment.
13613
13614 2019-01-23  Tom Tromey  <tom@tromey.com>
13615             Pedro Alves  <palves@redhat.com>
13616
13617         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
13618         parameter.
13619         (fetch_inferior_event): Use SCOPE_EXIT.
13620
13621
13622 2019-01-23  Tom Tromey  <tom@tromey.com>
13623             Pedro Alves  <palves@redhat.com>
13624
13625         * infrun.c (disable_thread_events): Delete.
13626         (stop_all_threads): Use SCOPE_EXIT.
13627
13628 2019-01-23  Tom Tromey  <tom@tromey.com>
13629             Pedro Alves  <palves@redhat.com>
13630
13631         * symfile.c: Include forward-scope-exit.h.
13632         (clear_symtab_users_cleanup): Replace forward declaration with
13633         a FORWARD_SCOPE_EXIT.
13634         (syms_from_objfile_1): Use the forward_scope_exit and
13635         gdb::optional instead of cleanup_function.
13636         (reread_symbols): Use the forward_scope_exit instead of
13637         cleanup_function.
13638         (clear_symtab_users_cleanup): Remove function.
13639
13640 2019-01-23  Tom Tromey  <tom@tromey.com>
13641             Pedro Alves  <palves@redhat.com>
13642
13643         * linux-nat.c: Include scope-exit.h.
13644         (cleanup_target_stop): Remove.
13645         (linux_nat_target::static_tracepoint_markers_by_strid): Use
13646         SCOPE_EXIT.
13647
13648 2019-01-23  Tom Tromey  <tom@tromey.com>
13649             Pedro Alves  <palves@redhat.com>
13650
13651         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
13652         (call_function_by_hand_dummy): Use SCOPE_EXIT.
13653
13654 2019-01-23  Tom Tromey  <tom@tromey.com>
13655             Andrew Burgess  <andrew.burgess@embecosm.com>
13656             Pedro Alves  <palves@redhat.com>
13657
13658         * infrun.c (fetch_inferior_event): Use scope_exit.
13659         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
13660         * top.c (execute_command): Use scope_exit.
13661         * breakpoint.c (bpstat_do_actions): Use scope_exit.
13662         * utils.c (do_bpstat_clear_actions_cleanup)
13663         (make_bpstat_clear_actions_cleanup): Remove.
13664
13665 2019-01-23  Tom Tromey  <tom@tromey.com>
13666             Pedro Alves  <palves@redhat.com>
13667
13668         * infrun.c: Include "common/scope-exit.h"
13669         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
13670         (wait_for_inferior): Use SCOPE_EXIT.
13671         (fetch_inferior_event): Use scope_exit.
13672
13673 2019-01-23  Tom Tromey  <tom@tromey.com>
13674             Pedro Alves  <palves@redhat.com>
13675
13676         * breakpoint.c (create_breakpoint): Remove cleanup.
13677
13678 2019-01-23  Tom Tromey  <tom@tromey.com>
13679             Andrew Burgess  <andrew.burgess@embecosm.com>
13680             Pedro Alves  <palves@redhat.com>
13681
13682 2019-01-23  Pedro Alves  <palves@redhat.com>
13683
13684         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
13685
13686 2019-01-23  Pedro Alves  <palves@redhat.com>
13687             Andrew Burgess  <andrew.burgess@embecosm.com>
13688
13689         * gdbthread.h: Include "common/forward-scope-exit.h".
13690         (scoped_finish_thread_state): Redefine custom class in terms of
13691         forward_scope_exit.
13692
13693 2019-01-23  Pedro Alves  <palves@redhat.com>
13694             Andrew Burgess  <andrew.burgess@embecosm.com>
13695
13696         * common/forward-scope-exit.h: New file.
13697
13698 2019-01-23  Pedro Alves  <palves@redhat.com>
13699             Andrew Burgess  <andrew.burgess@embecosm.com>
13700             Tom Tromey  <tom@tromey.com>
13701
13702         * common/scope-exit.h: New file.
13703
13704 2019-01-23  Pedro Alves  <palves@redhat.com>
13705
13706         * common/preprocessor.h (ESC): Rename to ...
13707         (ESC_PARENS): ... this.
13708         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
13709         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
13710
13711 2019-01-23  Tom Tromey  <tom@tromey.com>
13712
13713         * language.h (class scoped_switch_to_sym_language_if_auto):
13714         Initialize m_lang in both cases.
13715
13716 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
13717
13718         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
13719         with XCNEW.
13720
13721 2019-01-22  Tom Tromey  <tom@tromey.com>
13722
13723         * corelow.c: Do not include sys/file.h.
13724
13725 2019-01-22  Tom Tromey  <tom@tromey.com>
13726
13727         * tui/tui-wingeneral.h: Include gdb_curses.h.
13728
13729 2019-01-22  Tom Tromey  <tom@tromey.com>
13730
13731         * source-cache.h (class source_cache) <get_source_lines,
13732         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
13733
13734 2019-01-22  Tom Tromey  <tom@tromey.com>
13735
13736         * remote-fileio.h (struct remote_target): Declare.
13737
13738 2019-01-22  Tom Tromey  <tom@tromey.com>
13739
13740         * python/py-arch.c: Do not include py-ref.h.
13741         * python/py-bpevent.c: Do not include py-ref.h.
13742         * python/py-cmd.c: Do not include py-ref.h.
13743         * python/py-continueevent.c: Do not include py-ref.h.
13744         * python/py-event.h: Do not include py-ref.h.
13745         * python/py-evtregistry.c: Do not include py-ref.h.
13746         * python/py-finishbreakpoint.c: Do not include py-ref.h.
13747         * python/py-frame.c: Do not include py-ref.h.
13748         * python/py-framefilter.c: Do not include py-ref.h.
13749         * python/py-function.c: Do not include py-ref.h.
13750         * python/py-infevents.c: Do not include py-ref.h.
13751         * python/py-linetable.c: Do not include py-ref.h.
13752         * python/py-objfile.c: Do not include py-ref.h.
13753         * python/py-param.c: Do not include py-ref.h.
13754         * python/py-prettyprint.c: Do not include py-ref.h.
13755         * python/py-progspace.c: Do not include py-ref.h.
13756         * python/py-symbol.c: Do not include py-ref.h.
13757         * python/py-symtab.c: Do not include py-ref.h.
13758         * python/py-type.c: Do not include py-ref.h.
13759         * python/py-unwind.c: Do not include py-ref.h.
13760         * python/py-utils.c: Do not include py-ref.h.
13761         * python/py-value.c: Do not include py-ref.h.
13762         * python/py-varobj.c: Do not include py-ref.h.
13763         * python/py-xmethods.c: Do not include py-ref.h.
13764         * python/python.c: Do not include py-ref.h.
13765         * varobj.c: Do not include py-ref.h.
13766
13767 2019-01-22  Tom Tromey  <tom@tromey.com>
13768
13769         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
13770         keyword for bcache.
13771
13772 2019-01-22  Tom Tromey  <tom@tromey.com>
13773
13774         * compile/compile-cplus-types.c: Remove a comment by #include.
13775
13776 2019-01-22  Tom Tromey  <tom@tromey.com>
13777
13778         * compile/gcc-c-plugin.h: Include compile-internal.h.
13779
13780 2019-01-22  Tom Tromey  <tom@tromey.com>
13781
13782         * stabsread.c (EXTERN): Do not define.
13783         (symnum, next_symbol_text_func, processing_gcc_compilation)
13784         (within_function, global_sym_chain, global_stabs)
13785         (previous_stab_code, this_object_header_files)
13786         (n_this_object_header_files)
13787         (n_allocated_this_object_header_files): Define.
13788         * stabsread.h (EXTERN): Never define.  Use "extern".
13789
13790 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13791
13792         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
13793         history_value.
13794
13795 2019-01-21  Tom Tromey  <tom@tromey.com>
13796
13797         * ui-out.c: Fix includes.
13798         * tui/tui-source.c: Fix includes.
13799         * target.c: Fix includes.
13800         * remote.c: Fix includes.
13801         * regcache.c: Fix includes.
13802         * python/py-block.c: Fix includes.
13803         * printcmd.c: Fix includes.
13804         * or1k-tdep.c: Fix includes.
13805         * mi/mi-main.c: Fix includes.
13806         * m32r-tdep.c: Fix includes.
13807         * csky-tdep.c: Fix includes.
13808         * compile/compile-cplus-types.c: Fix includes.
13809         * cli/cli-interp.c: Fix includes.
13810
13811 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
13812
13813         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
13814         for padding.
13815
13816 2019-01-16  Tom Tromey  <tom@tromey.com>
13817
13818         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
13819         earlier.
13820         (struct objfile) <msymbols_range>: Move from top level.
13821         <msymbols>: New method.
13822         (class objfile_msymbols): Remove.
13823         * symtab.c (default_collect_symbol_completion_matches_break_on):
13824         Update.
13825         * symmisc.c (dump_msymbols): Update.
13826         * stabsread.c (scan_file_globals): Update.
13827         * objc-lang.c (info_selectors_command, info_classes_command)
13828         (find_methods): Update.
13829         * minsyms.c (find_solib_trampoline_target): Update.
13830         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
13831         * coffread.c (coff_symfile_read): Update.
13832         * ada-lang.c (ada_lookup_simple_minsym)
13833         (ada_collect_symbol_completion_matches): Update.
13834
13835 2019-01-16  Tom Tromey  <tom@tromey.com>
13836
13837         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
13838         type.  Remove no-argument constructor.
13839         <iterator::operator++>: Simplify.
13840         <begin>: Update.
13841         <end>: Use minimal_symbol_count.
13842
13843 2019-01-16  Tom Tromey  <tom@tromey.com>
13844
13845         * objfiles.h (struct objfile) <psymtabs>: New method.
13846         (class objfile_psymtabs): Remove.
13847         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
13848         typedef.
13849         <range>: New method.
13850         (require_partial_symbols): Change return type.
13851         * psymtab.c (require_partial_symbols)
13852         (psym_expand_symtabs_matching): Update.
13853         * mdebugread.c (parse_partial_symbols): Update.
13854         * dbxread.c (dbx_end_psymtab): Update.
13855
13856 2019-01-15  Tom Tromey  <tom@tromey.com>
13857
13858         * symtab.c (lookup_objfile_from_block)
13859         (lookup_symbol_in_objfile_symtabs)
13860         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
13861         (find_line_symtab, info_sources_command)
13862         (default_collect_symbol_completion_matches_break_on)
13863         (make_source_files_completion_list): Update.
13864         * symmisc.c (print_objfile_statistics, dump_objfile)
13865         (maintenance_print_symbols, maintenance_info_symtabs)
13866         (maintenance_check_symtabs, maintenance_info_line_tables):
13867         Update.
13868         * source.c (select_source_symtab)
13869         (forget_cached_source_info_for_objfile): Update.
13870         * objfiles.h (class objfile_compunits): Remove.
13871         (struct objfile) <compunits_range>: New typedef.
13872         (compunits): New method.
13873         * objfiles.c (objfile_relocate1): Update.
13874         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
13875         * maint.c (count_symtabs_and_blocks): Update.
13876         * linespec.c (iterate_over_all_matching_symtabs): Update.
13877         * cp-support.c (add_symbol_overload_list_qualified): Update.
13878         * coffread.c (coff_symtab_read): Update.
13879         * ada-lang.c (add_nonlocal_symbols)
13880         (ada_collect_symbol_completion_matches)
13881         (ada_add_global_exceptions): Update.
13882
13883 2019-01-15  Tom Tromey  <tom@tromey.com>
13884
13885         * progspace.h (program_space) <objfiles_safe_range>: New
13886         typedef.
13887         <objfiles_safe>: New method.
13888         * objfiles.h (class all_objfiles_safe): Remove.
13889         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
13890         * jit.c (jit_inferior_exit_hook): Update.
13891
13892 2019-01-17  Tom Tromey  <tom@tromey.com>
13893
13894         * progspace.h (program_space) <objfiles_range>: New typedef.
13895         <objfiles>: New method.
13896         <objfiles_head>: Rename from objfiles.
13897         (object_files): Update.
13898         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
13899         * guile/scm-pretty-print.c
13900         (ppscm_find_pretty_printer_from_objfiles): Update.
13901         * guile/scm-objfile.c (gdbscm_objfiles): Update.
13902         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
13903         Update.
13904         * python/py-progspace.c (pspy_get_objfiles): Update.
13905         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
13906         Update.
13907         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
13908         (objfpy_lookup_objfile_by_build_id): Update.
13909         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
13910         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
13911         Update.
13912         * symtab.c (iterate_over_symtabs, matching_obj_sections)
13913         (expand_symtab_containing_pc, lookup_objfile_from_block)
13914         (lookup_static_symbol, basic_lookup_transparent_type)
13915         (find_pc_sect_compunit_symtab, find_symbol_at_address)
13916         (find_line_symtab, info_sources_command)
13917         (default_collect_symbol_completion_matches_break_on)
13918         (make_source_files_completion_list, find_main_name): Update.
13919         * symmisc.c (print_symbol_bcache_statistics)
13920         (print_objfile_statistics, maintenance_print_symbols)
13921         (maintenance_print_msymbols, maintenance_print_objfiles)
13922         (maintenance_info_symtabs, maintenance_check_symtabs)
13923         (maintenance_expand_symtabs, maintenance_info_line_tables):
13924         Update.
13925         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
13926         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
13927         (map_overlay_command, unmap_overlay_command)
13928         (simple_overlay_update, expand_symtabs_matching)
13929         (map_symbol_filenames): Update.
13930         * symfile-debug.c (set_debug_symfile): Update.
13931         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
13932         Update.
13933         * source.c (select_source_symtab, forget_cached_source_info):
13934         Update.
13935         * solib.c (solib_read_symbols): Update.
13936         * solib-spu.c (append_ocl_sos): Update.
13937         * psymtab.c (maintenance_print_psymbols)
13938         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
13939         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
13940         * printcmd.c (info_symbol_command): Update.
13941         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
13942         Update.
13943         * objfiles.h (class all_objfiles): Remove.
13944         * objfiles.c (have_partial_symbols, have_full_symbols)
13945         (have_minimal_symbols, qsort_cmp, update_section_map)
13946         (shared_objfile_contains_address_p)
13947         (default_iterate_over_objfiles_in_search_order): Update.
13948         * objc-lang.c (info_selectors_command, info_classes_command)
13949         (find_methods): Update.
13950         * minsyms.c (find_solib_trampoline_target): Update.
13951         * maint.c (maintenance_info_sections)
13952         (maintenance_translate_address, count_symtabs_and_blocks):
13953         Update.
13954         * main.c (captured_main_1): Update.
13955         * linux-thread-db.c (try_thread_db_load_from_pdir)
13956         (has_libpthread): Update.
13957         * linespec.c (iterate_over_all_matching_symtabs)
13958         (search_minsyms_for_name): Update.
13959         * jit.c (jit_find_objf_with_entry_addr): Update.
13960         * hppa-tdep.c (find_unwind_entry)
13961         (hppa_lookup_stub_minimal_symbol): Update.
13962         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
13963         Update.
13964         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
13965         (elf_gnu_ifunc_resolve_by_got): Update.
13966         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
13967         * dwarf-index-write.c (save_gdb_index_command): Update.
13968         * cp-support.c (add_symbol_overload_list_qualified): Update.
13969         * breakpoint.c (create_overlay_event_breakpoint)
13970         (create_longjmp_master_breakpoint)
13971         (create_std_terminate_master_breakpoint)
13972         (create_exception_master_breakpoint): Update.
13973         * blockframe.c (find_pc_partial_function): Update.
13974         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
13975         (ada_collect_symbol_completion_matches)
13976         (ada_add_global_exceptions): Update.
13977
13978 2019-01-17  Tom Tromey  <tom@tromey.com>
13979
13980         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
13981         declare VEC.
13982         (solib_target_parse_libraries): Change return type.
13983         (library_list_start_segment, library_list_start_section)
13984         (library_list_end_library, library_list_start_library); Update.
13985         (solib_target_free_library_list): Remove.
13986         (solib_target_parse_libraries): Remove cleanup.  Change return
13987         type.
13988         (solib_target_current_sos): Update.
13989
13990 2019-01-17  Tom Tromey  <tromey@bapiya>
13991
13992         * valprint.c: Replace "the the" with "the".
13993         * symtab.c: Replace "the the" with "the".
13994         * solib.c: Replace "the the" with "the".
13995         * solib-dsbt.c: Replace "the the" with "the".
13996         * linespec.c: Replace "the the" with "the".
13997         * dwarf2loc.h: Replace "the the" with "the".
13998         * amd64-windows-tdep.c: Replace "the the" with "the".
13999         * aarch64-tdep.c: Replace "the the" with "the".
14000
14001 2019-01-16  Keith Seitz  <keiths@redhat.com>
14002
14003         PR gdb/23773
14004         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
14005         <builder>: Rename to ..
14006         <m_builder>: ... this and make private.
14007         (dwarf2_cu::get_builder): New method.  Change all users of
14008         `builder' to use this method.
14009         (dwarf2_start_symtab): Move to ...
14010         (dwarf2_cu::start_symtab): ... here.  Update all callers
14011         (setup_type_unit_groups): Move to ...
14012         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
14013         callers.
14014         (dwarf2_cu::reset_builder): New method.
14015         (process_full_compunit, process_full_type_unit): Use
14016         dwarf2_cu::reset_builder.
14017         (follow_die_offset): Record the ancestor CU if it is different
14018         from the followed DIE's CU.
14019         (follow_die_sig_1): Likewise.
14020
14021 2019-01-15  Tom Tromey  <tom@tromey.com>
14022
14023         * remote.c (class remote_state) <buf>: Now a char_vector.
14024         <buf_size>: Remove.
14025         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
14026         parameter.
14027         (remote_target::getpkt_or_notif_sane_1)
14028         (remote_target::getpkt_sane)
14029         (remote_target::getpkt_or_notif_sane): Likewise.
14030         (class remote_target) <putpkt>: New overload.
14031         (remote_target::read_frame): Change type of "buf_p".  Remove
14032         sizeof_p parameter.
14033         (packet_ok): New overload.
14034         (packet_check_result): New overload.
14035         Update all uses.
14036
14037 2019-01-14  Tom Tromey  <tom@tromey.com>
14038
14039         * remote-notif.c (handle_notification, remote_notif_ack)
14040         (remote_notif_parse): Make "buf" const.
14041         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
14042         const.
14043         (remote_notif_parse, remote_notif_ack, handle_notification):
14044         Likewise.
14045         * remote.c (remote_notif_stop_parse): Make "buf" const.
14046         (remote_target::remote_parse_stop_reply): Make "buf" const.
14047         (remote_notif_stop_ack): Make "buf" const.
14048
14049 2019-01-14  Tom Tromey  <tom@tromey.com>
14050
14051         * remote.c (remote_console_output): Make parameter const.
14052
14053 2019-01-14  Tom Tromey  <tom@tromey.com>
14054
14055         * target-debug.h (target_debug_print_signals): Constify.
14056         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
14057         * procfs.c (procfs_target::pass_signals): Update.
14058         * linux-nat.c (linux_nat_target::pass_signals): Update.
14059         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
14060         * target-delegates.c: Rebuild.
14061         * remote.c (remote_target::program_signals): Update.
14062         (remote_target::pass_signals): Update.
14063         * target.c (target_pass_signals): Constify argument.
14064         (target_program_signals): Likewise.
14065         * target.h (struct target_ops) <pass_signals, program_signals>:
14066         Constify argument.
14067         (target_pass_signals, target_program_signals): Constify argument.
14068
14069 2019-01-14  Tom Tromey  <tom@tromey.com>
14070
14071         PR tui/28819:
14072         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
14073
14074 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
14075
14076         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
14077         field.
14078         * rs6000-tdep.c: Include reggroups.h.
14079         (IS_V_ALIAS_PSEUDOREG): Define.
14080         (rs6000_register_name): Return names for the "vX" aliases.
14081         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
14082         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
14083         aliases.  Call default_register_reggroup_p for all other
14084         pseudo-registers.
14085         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
14086         New functions.
14087         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
14088         Handle "vX" aliases.
14089         (v_alias_pseudo_register_collect): New function.
14090         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
14091         (rs6000_gdbarch_init): Initialize "vX" aliases as
14092         pseudo-registers.  Restore registration of
14093         rs6000_pseudo_register_reggroup_p with
14094         set_tdesc_pseudo_register_reggroup_p.
14095
14096 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
14097
14098         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
14099         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
14100         set_gdbarch_num_pseudo_regs.
14101
14102 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14103
14104         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
14105         Remove arg prefixname, add do_set and do_show.
14106         Add member functions set_list and show_list.
14107         * cli/cli-style.c (class cli_style_option): Update accordingly.
14108         (style_set_list): Move to file scope.
14109         (style_show_list): Likewise.
14110         (set_style): Call help_list.
14111         (show_style): Call cmd_show_list.
14112         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
14113         Update to use the new macro.
14114
14115 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
14116
14117         * ada-lang.c (_initialize_ada_language): Expand the help text
14118         for the "catch exception" command.
14119
14120 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14121
14122         * symtab.c (matching_obj_sections): Initialize obj,
14123         declare it closer to its usage.
14124
14125 2019-01-10  Tom Tromey  <tom@tromey.com>
14126
14127         * thread-iter.h (inf_threads_iterator): Use next_iterator.
14128         (basic_inf_threads_range): Remove.
14129         (inf_threads_range, inf_non_exited_threads_range)
14130         (safe_inf_threads_range): Use next_adapter.
14131
14132 2019-01-10  Keith Seitz  <keiths@redhat.com>
14133
14134         PR gdb/23712
14135         PR symtab/23010
14136         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
14137         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
14138
14139 2019-01-10  Keith Seitz  <keiths@redhat.com>
14140
14141         PR gdb/23712
14142         PR symtab/23010
14143         * dictionary.c (pending_to_vector): Remove.
14144         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
14145         Remove _1 suffix, replacing functions of the same name.  Update
14146         all callers.
14147         (dict_create_hashed, dict_create_hashed_expandable)
14148         (dict_create_linear, dict_create_linear_expandable, dict_free)
14149         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
14150         Make functions static.
14151
14152 2019-01-10  Keith Seitz  <keiths@redhat.com>
14153
14154         PR gdb/23712
14155         PR symtab/23010
14156         * dictionary.h (struct dictionary): Replace declaration with
14157         multidictionary.
14158         (dict_create_hashed, dict_create_hashed_expandable)
14159         (dict_create_linear, dict_create_linear_expandable)
14160         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
14161         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
14162         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
14163         taking multidictionary argument.
14164         [ALL_DICT_SYMBOLS]: Update for multidictionary.
14165         * block.h (struct block) <dict>: Change to multidictionary
14166         and rename `multidict'.
14167         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
14168         symmisc.c: Update all dictionary references to multidictionary.
14169
14170 2019-01-10  Keith Seitz  <keiths@redhat.com>
14171
14172         PR gdb/23712
14173         PR symtab/23010
14174         * dictionary.c: Include unordered_map.
14175         (pending_to_vector): New function.
14176         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
14177         Rewrite the non-"_1" functions to take vector instead
14178         of linked list.
14179         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
14180         "new" _1 versions of the same name.
14181         (multidictionary): Define.
14182         (std::hash<enum language): New definition.
14183         (collate_pending_symbols_by_language, mdict_create_hashed)
14184         (mdict_create_hashed_expandable, mdict_create_linear)
14185         (mdict_create_linear_expandable, mdict_free)
14186         (find_language_dictionary, create_new_language_dictionary)
14187         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
14188         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
14189         (mdict_size, mdict_empty): New functions.
14190         * dictionary.h (mdict_iterator): Define.
14191
14192 2019-01-10  Pedro Alves  <palves@redhat.com>
14193
14194         * breakpoint.c (read_uploaded_action)
14195         (create_tracepoint_from_upload): Adjust to use
14196         gdb::unique_xmalloc_ptr.
14197         * ctf.c (ctf_write_uploaded_tp):
14198         (SET_ARRAY_FIELD): Use emplace_back.
14199         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
14200         * tracefile-tfile.c (tfile_write_uploaded_tp):
14201         * tracepoint.c (parse_tracepoint_definition): Adjust to use
14202         gdb::unique_xmalloc_ptr.
14203         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
14204         at_string, cond_string, cmd_strings>: Replace char pointers
14205         with gdb::unique_xmalloc_ptr.
14206
14207 2019-01-10  Pedro Alves  <palves@redhat.com>
14208
14209         * solib-target.c (library_list_start_library): Don't xstrdup name.
14210
14211 2019-01-10  Pedro Alves  <palves@redhat.com>
14212
14213         * mdebugread.c (parse_partial_symbols): Use
14214         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
14215
14216 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
14217
14218         * linux-fork.c (scoped_switch_fork_info)
14219         <~scoped_switch_fork_info>: Fix incorrect variable name.
14220
14221 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
14222
14223         * linux-fork.c (scoped_switch_fork_info)
14224         <scoped_switch_fork_info>: Make explicit.
14225         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
14226
14227 2019-01-10  Tom Tromey  <tom@tromey.com>
14228
14229         * objfiles.h (objfile::reset_psymtabs): Update.
14230         * objfiles.c (objfile::objfile): Update.
14231         * psymtab.h (psymtab_storage::obstack): Update.
14232         (psymtab_storage::m_obstack): Use gdb::optional.
14233         (class psymtab_storage): Update comment.  Remove objfile
14234         parameter.
14235         * psymtab.c (psymtab_storage::psymtab_storage): Update.
14236
14237 2019-01-10  Tom Tromey  <tom@tromey.com>
14238
14239         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
14240         <free_psymtabs>: Now private.
14241         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
14242         (allocate_psymtab): Use new method.
14243
14244 2019-01-10  Tom Tromey  <tom@tromey.com>
14245
14246         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
14247         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
14248         * mdebugread.c (parse_partial_symbols): Use
14249         allocate_dependencies.
14250         * dwarf2read.c (dwarf2_create_include_psymtab): Use
14251         allocate_dependencies.
14252         (process_psymtab_comp_unit_reader)
14253         (build_type_psymtab_dependencies): Likewise.
14254         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
14255
14256 2019-01-10  Tom Tromey  <tom@tromey.com>
14257
14258         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
14259         PSYMBOL_SET_LANGUAGE.
14260         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
14261
14262 2019-01-10  Tom Tromey  <tom@tromey.com>
14263
14264         * psymtab.h (psymtab_storage::obstack): New method.
14265         <m_obstack>: Rename from obstack; now private.
14266         * psymtab.c (psymtab_storage): Update.
14267         * dwarf2read.c (create_addrmap_from_index)
14268         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
14269         Update.
14270
14271 2019-01-10  Tom Tromey  <tom@tromey.com>
14272
14273         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
14274         * objfiles.h (objfile::reset_psymtabs): New method.
14275
14276 2019-01-10  Tom Tromey  <tom@tromey.com>
14277
14278         * symmisc.c (print_symbol_bcache_statistics): Update.
14279         (print_objfile_statistics): Update.
14280         * symfile.c (reread_symbols): Update.
14281         * psymtab.h (class psymtab_storage): New.
14282         * psymtab.c (psymtab_storage): New constructor.
14283         (~psymtab_storage): New destructor.
14284         (require_partial_symbols): Update.
14285         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
14286         (find_pc_sect_psymtab, find_pc_sect_psymbol)
14287         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
14288         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
14289         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
14290         (start_psymtab_common, end_psymtab_common)
14291         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
14292         (allocate_psymtab): Update.
14293         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
14294         Update.
14295         (dump_psymtab_addrmap, maintenance_print_psymbols)
14296         (maintenance_check_psymtabs): Update.
14297         (class objfile_psymtabs): Move to objfiles.h.
14298         * psympriv.h (discard_psymtab): Now inline.
14299         (psymtab_discarder::psymtab_discarder): Update.
14300         (psymtab_discarder::~psymtab_discarder): Update.
14301         (ALL_OBJFILE_PSYMTABS): Rewrite.
14302         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
14303         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
14304         Remove fields.
14305         <partial_symtabs>: New field.
14306         (class objfile_psymtabs): Move from psymtab.h.  Update.
14307         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
14308         psymbol_cache.
14309         (objfile::~objfile): Don't destroy psymbol_cache.
14310         * mdebugread.c (parse_partial_symbols): Update.
14311         * dwarf2read.c (create_addrmap_from_index)
14312         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
14313         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
14314         (add_partial_subprogram, dwarf2_ranges_read): Update.
14315         * dwarf-index-write.c (write_address_map)
14316         (write_one_signatured_type, recursively_write_psymbols)
14317         (class debug_names, class debug_names, write_psymtabs_to_index):
14318         Update.
14319
14320 2019-01-10  Tom Tromey  <tom@tromey.com>
14321
14322         * symtab.h (SYMBOL_SET_NAMES): Update.
14323         (symbol_set_names): Update.
14324         (MSYMBOL_SET_NAMES): Update.
14325         * symtab.c (symbol_set_names): Change argument to be an
14326         objfile_per_bfd_storage.
14327         * psymtab.c (add_psymbol_to_bcache): Update.
14328         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
14329
14330 2019-01-10  Tom Tromey  <tom@tromey.com>
14331
14332         * symtab.c (create_demangled_names_hash): Change argument to be an
14333         objfile_per_bfd_storage.
14334         (symbol_set_names): Update.
14335
14336 2019-01-10  Tom Tromey  <tom@tromey.com>
14337
14338         * xcoffread.c (xcoff_initial_scan): Unconditionally call
14339         init_psymbol_list.
14340         * psymtab.c (init_psymbol_list): Do nothing if already called.
14341         * psympriv.h (init_psymbol_list): Add comment.
14342         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
14343         init_psymbol_list.
14344         * dbxread.c (dbx_symfile_read): Unconditionally call
14345         init_psymbol_list.
14346
14347 2019-01-10  Tom Tromey  <tom@tromey.com>
14348
14349         * xcoffread.c (scan_xcoff_symtab): Update.
14350         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
14351         "where".
14352         * mdebugread.c (parse_partial_symbols)
14353         (handle_psymbol_enumerators): Update.
14354         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
14355         * dbxread.c (read_dbx_symtab): Update.
14356         * psympriv.h (psymbol_placement): New enum.
14357         (add_psymbol_to_list): Update.
14358
14359 2019-01-10  Tom Tromey  <tom@tromey.com>
14360
14361         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
14362         static_psymbols parameters.
14363         (scan_xcoff_symtab): Update.
14364         * psymtab.c (start_psymtab_common): Remove global_psymbols and
14365         static_psymbols parameters.
14366         * psympriv.h (start_psymtab_common): Update.
14367         * mdebugread.c (parse_partial_symbols): Update.
14368         * dwarf2read.c (create_partial_symtab): Update.
14369         * dbxread.c (read_dbx_symtab): Update.
14370         (start_psymtab): Remove global_psymbols and static_psymbols
14371         parameters.
14372
14373 2019-01-10  Tom Tromey  <tom@tromey.com>
14374
14375         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
14376         * psymtab.c (allocate_psymtab): Add comment.
14377         * psympriv.h (allocate_psymtab): Add comment.
14378         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
14379         initializations.
14380         * dbxread.c (dbx_end_psymtab): Remove some initializations.
14381
14382 2019-01-10  Tom Tromey  <tom@tromey.com>
14383
14384         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
14385         Don't declare.
14386         * mipsread.c: Include mdebugread.h.
14387         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
14388         Declare.
14389         * elfread.c: Include mdebugread.h.
14390
14391 2019-01-09  Tom Tromey  <tom@tromey.com>
14392
14393         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
14394         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
14395         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
14396         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
14397         (psym_lookup_symbol, psym_find_last_source_symtab)
14398         (psym_forget_cached_source_info, psym_print_stats)
14399         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
14400         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
14401         (psym_map_matching_symbols, psym_expand_symtabs_matching)
14402         (psym_find_compunit_symtab_by_address)
14403         (maintenance_print_psymbols, maintenance_info_psymtabs)
14404         (maintenance_check_psymtabs): Use ranged for.
14405         * psymtab.h (class objfile_psymtabs): New.
14406         (require_partial_symbols): Return objfile_psymtabs.
14407         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
14408
14409 2019-01-09  Tom Tromey  <tom@tromey.com>
14410
14411         * symfile.c (overlay_invalidate_all, find_pc_overlay)
14412         (find_pc_mapped_section, list_overlays_command)
14413         (map_overlay_command, unmap_overlay_command)
14414         (simple_overlay_update): Use all_objfiles.
14415         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
14416         * printcmd.c (info_symbol_command): Use all_objfiles.
14417         * objfiles.h (ALL_OBJSECTIONS): Remove.
14418         * maint.c (maintenance_translate_address): Use all_objfiles.
14419         * gcore.c (gcore_create_callback): Use all_objfiles.
14420         (objfile_find_memory_regions): Likewise.
14421
14422 2019-01-09  Tom Tromey  <tom@tromey.com>
14423
14424         * symtab.c (find_line_symtab, info_sources_command)
14425         (make_source_files_completion_list): Use objfile_compunits.
14426         * source.c (select_source_symtab): Use objfile_compunits.
14427         * objfiles.h (struct objfile): Update comment.
14428         (ALL_OBJFILES): Remove.
14429         (ALL_FILETABS): Remove.
14430         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
14431         objfile_compunits.
14432
14433 2019-01-09  Tom Tromey  <tom@tromey.com>
14434
14435         * symmisc.c (print_objfile_statistics, dump_objfile)
14436         (maintenance_print_symbols): Use compunit_filetabs.
14437         * source.c (forget_cached_source_info_for_objfile): Use
14438         compunit_filetabs.
14439         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
14440         (ALL_FILETABS): Use compunit_filetabs.
14441         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
14442         * coffread.c (coff_symtab_read): Use compunit_filetabs.
14443
14444 2019-01-09  Tom Tromey  <tom@tromey.com>
14445
14446         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
14447         (compunit_filetabs): New.
14448         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
14449         compunit_filetabs.
14450         (info_sources_command, make_source_files_completion_list): Remove
14451         declaration.
14452         * symmisc.c (print_objfile_statistics, dump_objfile)
14453         (maintenance_print_symbols): Remove declaration.
14454         (maintenance_info_symtabs): Use compunit_filetabs.
14455         (maintenance_info_line_tables): Likewise.
14456         * source.c (select_source_symtab): Change local variable name.
14457         (forget_cached_source_info_for_objfile): Remove declaration.
14458         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
14459         * objfiles.c (objfile_relocate1): Remove declaration.
14460         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
14461         declaration.
14462         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
14463         * coffread.c (coff_symtab_read): Remove declaration.
14464         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
14465         compunit_filetabs.
14466
14467 2019-01-09  Tom Tromey  <tom@tromey.com>
14468
14469         * symtab.c (lookup_objfile_from_block)
14470         (find_pc_sect_compunit_symtab, search_symbols)
14471         (default_collect_symbol_completion_matches_break_on): Use
14472         objfile_compunits.
14473         * objfiles.h (ALL_COMPUNITS): Remove.
14474         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
14475         * cp-support.c (add_symbol_overload_list_qualified): Use
14476         objfile_compunits.
14477         * ada-lang.c (ada_collect_symbol_completion_matches)
14478         (ada_add_global_exceptions): Use objfile_compunits.
14479
14480 2019-01-09  Tom Tromey  <tom@tromey.com>
14481
14482         * source.c (select_source_symtab)
14483         (forget_cached_source_info_for_objfile): Remove declaration.
14484         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
14485         declaration.
14486         * maint.c (count_symtabs_and_blocks): Remove declaration.
14487         * cp-support.c (add_symbol_overload_list_qualified): Remove
14488         declaration.
14489         * coffread.c (coff_symtab_read): Remove declaration.
14490         * symtab.c (lookup_symbol_in_objfile_symtabs)
14491         (basic_lookup_transparent_type_1): Use objfile_compunits.
14492         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
14493         (info_sources_command, search_symbols)
14494         (default_collect_symbol_completion_matches_break_on)
14495         (make_source_files_completion_list): Remove declaration.
14496         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
14497         (ada_collect_symbol_completion_matches)
14498         (ada_add_global_exceptions): Remove declaration.
14499         * linespec.c (iterate_over_all_matching_symtabs): Use
14500         objfile_compunits.
14501         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
14502         (class objfile_compunits): New.
14503         (ALL_COMPUNITS): Use objfile_compunits.
14504         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
14505         (maintenance_check_symtabs, maintenance_info_line_tables): Use
14506         objfile_compunits.
14507         * objfiles.c (objfile_relocate1): Use objfile_compunits.
14508
14509 2019-01-09  Tom Tromey  <tom@tromey.com>
14510
14511         * symtab.c (search_symbols)
14512         (default_collect_symbol_completion_matches_break_on): Use
14513         objfile_msymbols.
14514         * ada-lang.c (ada_lookup_simple_minsym)
14515         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
14516         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
14517         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
14518         objfile_msymbols.
14519         * coffread.c (coff_symfile_read): Use objfile_msymbols.
14520         * symmisc.c (dump_msymbols): Use objfile_msymbols.
14521         * objc-lang.c (find_methods): Use objfile_msymbols.
14522         (info_selectors_command, info_classes_command): Likewise.
14523         * stabsread.c (scan_file_globals): Use objfile_msymbols.
14524         * objfiles.h (class objfile_msymbols): New.
14525         (ALL_OBJFILE_MSYMBOLS): Remove.
14526         (ALL_MSYMBOLS): Remove.
14527
14528 2019-01-09  Tom Tromey  <tom@tromey.com>
14529
14530         * common/next-iterator.h (next_adapter): Add Iterator template
14531         parameter.
14532         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
14533         (class all_objfiles_safe): New.
14534         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
14535         * objfiles.c (put_objfile_before): Update comment.
14536         (add_separate_debug_objfile): Likewise.
14537         (free_all_objfiles): Use all_objfiles_safe.
14538         (objfile_purge_solibs): Likewise.
14539
14540 2019-01-09  Tom Tromey  <tom@tromey.com>
14541
14542         * symtab.c (iterate_over_symtabs, matching_obj_sections)
14543         (expand_symtab_containing_pc, lookup_static_symbol)
14544         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
14545         (find_symbol_at_address, find_line_symtab, find_main_name): Use
14546         all_objfiles.
14547         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
14548         * breakpoint.c (create_overlay_event_breakpoint)
14549         (create_longjmp_master_breakpoint)
14550         (create_std_terminate_master_breakpoint)
14551         (create_exception_master_breakpoint): Use all_objfiles.
14552         * linux-thread-db.c (try_thread_db_load_from_pdir)
14553         (has_libpthread): Use all_objfiles.
14554         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
14555         * linespec.c (iterate_over_all_matching_symtabs)
14556         (search_minsyms_for_name): Use all_objfiles.
14557         * maint.c (maintenance_info_sections): Use all_objfiles.
14558         * main.c (captured_main_1): Use all_objfiles.
14559         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
14560         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
14561         * guile/scm-pretty-print.c
14562         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
14563         * solib-spu.c (append_ocl_sos): Use all_objfiles.
14564         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
14565         (maintenance_print_msymbols): Use all_objfiles.
14566         * source.c (select_source_symtab): Use all_objfiles.
14567         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
14568         * symfile.c (remove_symbol_file_command)
14569         (expand_symtabs_matching, map_symbol_filenames): Use
14570         all_objfiles.
14571         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
14572         all_objfiles.
14573         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
14574         * objc-lang.c (find_methods): Use all_objfiles.
14575         * objfiles.c (have_partial_symbols, have_full_symbols)
14576         (have_minimal_symbols, qsort_cmp)
14577         (default_iterate_over_objfiles_in_search_order): Use
14578         all_objfiles.
14579         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
14580         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
14581         (maintenance_check_psymtabs): Use all_objfiles.
14582         (ALL_PSYMTABS): Remove.
14583         * compile/compile-object-run.c (do_module_cleanup): Use
14584         all_objfiles.
14585         * blockframe.c (find_pc_partial_function): Use all_objfiles.
14586         * cp-support.c (add_symbol_overload_list_qualified): Use
14587         all_objfiles.
14588         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
14589         Use all_objfiles.
14590         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
14591         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
14592         all_objfiles.
14593         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
14594         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
14595         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
14596         Uses all_objfiles.
14597         * solib.c (solib_read_symbols): Use all_objfiles
14598
14599 2019-01-09  Tom Tromey  <tom@tromey.com>
14600
14601         * probe.c (parse_probes_in_pspace): Use all_objfiles.
14602         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
14603         all_objfiles.
14604         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
14605         * symmisc.c (print_symbol_bcache_statistics)
14606         (print_objfile_statistics, maintenance_print_objfiles)
14607         (maintenance_info_symtabs, maintenance_check_symtabs)
14608         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
14609         all_objfiles.
14610         * source.c (forget_cached_source_info): Use all_objfiles.
14611         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
14612         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
14613         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
14614         * objfiles.c (update_section_map): Use all_objfiles.
14615         (shared_objfile_contains_address_p): Likewise.
14616         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
14617         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
14618
14619 2019-01-09  Tom Tromey  <tom@tromey.com>
14620
14621         * common/next-iterator.h: New file.
14622         * objfiles.h (class all_objfiles): New.
14623         (struct objfile_iterator): New.
14624
14625 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14626
14627         * NEWS: Move the description of the changed "frame", "select-frame",
14628          and "info frame" commands to the Changed commands section.
14629
14630 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
14631
14632         * gdbtypes.c (check_stub_method_group): Remove handling of old
14633         mangling schemes.
14634         * linespec.c (find_methods): Likewise.
14635         * stabsread.c (read_member_functions): Likewise.
14636         * valops.c (search_struct_method): Likewise.
14637         (value_struct_elt_for_reference): Likewise.
14638         * NEWS: Mention this change.
14639
14640 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
14641
14642         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
14643         print_source_lines.
14644         * source.c (print_source_lines_base): Update line number check.
14645         (print_source_lines): New function.
14646         (source_lines_range::source_lines_range): New function.
14647         * source.h (class source_lines_range): New class.
14648         (print_source_lines): New declaration.
14649
14650 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14651
14652         * linespec.c (linespec_state_destructor): Free self->canonical_names.
14653
14654 2019-01-08  Tom Tromey  <tom@tromey.com>
14655             Simon Marchi  <simon.marchi@ericsson.com>
14656
14657         PR gdb/24060
14658         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
14659         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
14660         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
14661         * f-exp.y (DOLLAR_VARIABLE): Likewise.
14662         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
14663         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
14664
14665 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
14666
14667         * source.c (select_source_symtab): Move header comment to
14668         declaration in source.h.
14669         (forget_cached_source_info_for_objfile): Likewise.
14670         (forget_cached_source_info): Likewise.
14671         (identify_source_line): Likewise.
14672         * source.h (identify_source_line): Move declaration from symtab.h
14673         and add comment from source.c
14674         (print_source_lines): Likewise.
14675         (forget_cached_source_info_for_objfile): Likewise.
14676         (forget_cached_source_info): Likewise.
14677         (select_source_symtab): Likewise.
14678         (enum print_source_lines_flag): Move definition from symtab.h.
14679         * symtab.h (identify_source_line): Move declaration to source.h.
14680         (print_source_lines): Likewise.
14681         (forget_cached_source_info_for_objfile): Likewise.
14682         (forget_cached_source_info): Likewise.
14683         (select_source_symtab): Likewise.
14684         (enum print_source_lines_flag): Move definition to source.h.
14685         * tui/tui-hooks.c: Add 'source.h' include.
14686
14687 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
14688
14689         * source.c (print_source_lines_base): Handle requests to print
14690         reverse line number sequences, and guard against empty lines
14691         string.
14692
14693 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
14694
14695         * source.c (print_source_lines_base): Fix skip of '\r' if next
14696         character is '\n'.
14697
14698 2019-01-06  Tom Tromey  <tom@tromey.com>
14699
14700         * c-exp.y (struct c_parse_state) <macro_original_text,
14701         expansion_obstack>: New member.
14702         (macro_original_text, expansion_obstack): Remove globals.
14703         (scan_macro_expansion, scanning_macro_expansion)
14704         (finished_macro_expansion): Update.
14705         (scan_macro_cleanup): Remove.
14706         (yylex, c_parse): Update.
14707
14708 2019-01-06  Tom Tromey  <tom@tromey.com>
14709
14710         * c-exp.y (struct c_parse_state) <strings>: New member.
14711         (operator_stoken): Update.
14712
14713 2019-01-06  Tom Tromey  <tom@tromey.com>
14714
14715         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
14716         (union type_stack_elt) <typelist_val>: Now a pointer to
14717         std::vector.
14718         (type_stack_cleanup): Don't declare.
14719         (push_typelist): Update.
14720         * parse.c (pop_typelist): Return a std::vector.
14721         (push_typelist): Take a std::vector.
14722         (follow_types): Update.  Do not free args.
14723         (type_stack_cleanup): Remove.
14724         * c-exp.y (struct c_parse_state): New.
14725         (cpstate): New global.
14726         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
14727         (nonempty_typelist): Update.
14728         (func_mod): Create a new vector.
14729         (c_parse): Create a c_parse_state.
14730         (check_parameter_typelist): Do not delete params.
14731         (function_method): Update.  Do not delete type_list.
14732
14733 2019-01-06  Tom Tromey  <tom@tromey.com>
14734
14735         PR gdb/28155:
14736         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
14737         check_typedef.
14738         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
14739         (print_return_value): Likewise.
14740
14741 2019-01-05  Tom Tromey  <tom@tromey.com>
14742
14743         * contrib/cleanup_check.py: Remove.
14744         * contrib/gcc-with-excheck: Remove.
14745         * contrib/exsummary.py: Remove.
14746         * contrib/excheck.py: Remove.
14747
14748 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
14749
14750         * thread.c (delete_thread_1): Add gdb_assert that THR is not
14751         NULL. Initialize tpprev to NULL instead of assigning it
14752         to NULL on the next statement.
14753         * windows-nat.c (windows_delete_thread): Remove check for
14754         main_thread_id before printing thread exit notifications.
14755         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
14756         Remove thread ID check against main_thread_id.
14757         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
14758         windows_delete_thread.
14759         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
14760
14761 2019-01-04  Tom Tromey  <tom@tromey.com>
14762
14763         * compile/compile.c (_initialize_compile): Use upper case for
14764         metasyntactic variables.
14765         * symmisc.c (_initialize_symmisc): Use upper case for
14766         metasyntactic variables.
14767         * psymtab.c (_initialize_psymtab): Use upper case for
14768         metasyntactic variables.
14769         * demangle.c (demangle_command): Use upper case for metasyntactic
14770         variables.
14771         (_initialize_demangler): Likewise.
14772         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
14773         variables.
14774
14775 2019-01-03  Tom Tromey  <tom@tromey.com>
14776
14777         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
14778
14779 2019-01-03  Tom Tromey  <tom@tromey.com>
14780
14781         * python/py-symtab.c (salpy_str): Update.
14782         (struct salpy_sal_object) <symtab>: Now a PyObject.
14783         (salpy_dealloc): Update.
14784         (del_objfile_sal): Use gdbpy_ref.
14785
14786 2019-01-03  Tom Tromey  <tom@tromey.com>
14787
14788         * python/py-type.c (convert_field): Use new_reference.  Return
14789         gdbpy_ref.
14790         (make_fielditem): Return gdbpy_ref.
14791         (typy_fields): Update.
14792         (typy_getitem): Update.
14793         (field_name): Return gdbpy_ref.  Use new_reference.
14794         (typy_iterator_iternext): Update.
14795
14796 2019-01-03  Tom Tromey  <tom@tromey.com>
14797
14798         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
14799
14800 2019-01-03  Tom Tromey  <tom@tromey.com>
14801
14802         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
14803         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
14804         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
14805         (pspy_set_frame_filters, pspy_set_frame_unwinders)
14806         (pspy_set_type_printers): Likewise.
14807         * python/py-function.c (fnpy_init): Use gdbpy_ref.
14808         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
14809         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
14810         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
14811         (objfpy_set_type_printers): Likewise.
14812
14813 2019-01-03  Tom Tromey  <tom@tromey.com>
14814
14815         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
14816         (gdbpy_print_stack): Use gdbpy_err_fetch.
14817         * python/python-internal.h (class gdbpy_err_fetch): New class.
14818         (class gdbpy_enter) <m_error_type, m_error_value,
14819         m_error_traceback>: Remove.
14820         <m_error>: New member.
14821         (gdbpy_exception_to_string): Don't declare.
14822         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
14823         * python/py-value.c (convert_value_from_python): Use
14824         gdbpy_err_fetch.
14825         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
14826         gdbpy_exception_to_string.
14827         (gdbpy_handle_exception): Use gdbpy_err_fetch.
14828         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
14829         gdbpy_err_fetch.
14830
14831 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
14832
14833         * linux-nat.c (delete_lwp_cleanup): Delete.
14834         (struct lwp_deleter): New struct.
14835         (lwp_info_up): New typedef.
14836         (linux_nat_target::follow_fork): Delete cleanup, and make use of
14837         lwp_info_up.
14838
14839 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
14840
14841         * linux-fork.c (class scoped_switch_fork_info): New class.
14842         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
14843
14844 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
14845
14846         * valops.c (find_overload_match): Remove use of null_cleanup, and
14847         calls to do_cleanups.
14848
14849 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
14850
14851         * compile/compile-cplus-types.c
14852         (compile_cplus_instance::decl_name): Handle changes to
14853         cp_func_name.
14854         * cp-support.c (cp_func_name): Update header comment, update
14855         return type.
14856         * cp-support.h (cp_func_name): Update return type in declaration.
14857         * valops.c (find_overload_match): Move temp_func local to top
14858         level of function and change its type.  Use temp_func to hold and
14859         delete temporary string obtained from cp_func_name.
14860
14861 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
14862
14863         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
14864         gdb::char_vector, remove cleanup, and update uses of `msg`.
14865
14866 2019-01-03  Jim Wilson  <jimw@sifive.com>
14867
14868         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
14869
14870 2019-01-02  Tom Tromey  <tom@tromey.com>
14871
14872         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
14873         (tdesc_parse_xml): Remove cleanups.
14874         * target-descriptions.h (make_cleanup_free_target_description):
14875         Don't declare.
14876         (target_desc_deleter): New struct.
14877         (target_desc_up): New typedef.
14878         * target-descriptions.c (target_desc_deleter::operator()): Rename
14879         from free_target_description.
14880         (make_cleanup_free_target_description): Remove.
14881
14882 2019-01-02  Tom Tromey  <tom@tromey.com>
14883
14884         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
14885         constructor, destructor.
14886         (linespec_parser): Remove typedef.
14887         (~linespec_parser): Rename from linespec_parser_delete.
14888         (linespec_lex_to_end, linespec_complete_label)
14889         (linespec_complete): Update.
14890         (decode_line_full): Remove cleanups.
14891         (decode_line_1): Update.
14892
14893 2019-01-02  Tom Tromey  <tom@tromey.com>
14894
14895         * python/python-internal.h (inferior_to_inferior_object): Change
14896         return type.
14897         * python/py-exitedevent.c (create_exited_event_object): Update.
14898         * python/py-inferior.c (inferior_to_inferior_object): Return
14899         gdbpy_ref.
14900         (python_new_inferior, python_inferior_deleted)
14901         (thread_to_thread_object, delete_thread_object)
14902         (build_inferior_list, gdbpy_selected_inferior): Update.
14903         * python/py-infthread.c (create_thread_object): Update.  Also fail
14904         if inferior_to_inferior_object fails.
14905
14906 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
14907
14908         * inferior.h (class inferior) <displaced_step_state>: New field.
14909         * infrun.h (struct displaced_step_state): Move here from
14910         infrun.c.  Initialize fields, add constructor.
14911         <inf>: Remove field.
14912         <reset>: New method.
14913         * infrun.c (struct displaced_step_inferior_state): Move to
14914         infrun.h.
14915         (displaced_step_inferior_states): Remove.
14916         (get_displaced_stepping_state): Adust.
14917         (displaced_step_in_progress_any_inferior): Adjust.
14918         (displaced_step_in_progress_thread): Adjust.
14919         (displaced_step_in_progress): Adjust.
14920         (add_displaced_stepping_state): Remove.
14921         (get_displaced_step_closure_by_addr): Adjust.
14922         (remove_displaced_stepping_state): Remove.
14923         (infrun_inferior_exit): Call displaced_step_state.reset.
14924         (use_displaced_stepping): Don't check for NULL.
14925         (displaced_step_prepare_throw): Call
14926         get_displaced_stepping_state.
14927         (displaced_step_fixup): Don't check for NULL.
14928         (prepare_for_detach): Don't check for NULL.
14929
14930 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14931
14932         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
14933          in case of call that did not complete.
14934
14935 2019-01-02  Andrey Utkin  <autkin@undo.io>
14936
14937         * symfile.c (find_separate_debug_file): Fix search of debug files for
14938         remote debuggee.
14939
14940 2019-01-02  Tom Tromey  <tom@tromey.com>
14941
14942         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
14943         indentation.
14944         * python/py-frame.c (frapy_older): Remove cast.
14945         (frapy_newer): Likewise.
14946         * python/py-breakpoint.c (local_setattro): Remove cast.
14947         * python/py-arch.c (archpy_name): Remove local variable.
14948         * python/py-type.c (gdbpy_lookup_type): Remove cast.
14949
14950 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
14951
14952         * unittests/basic_string_view/element_access/char/empty.cc:
14953         Fix year range in copyright header.
14954
14955 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
14956
14957         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
14958         Delete.
14959         <operator==>: Update with for removed field.
14960         <hash>: Likewise.
14961         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
14962         <isa_features>: ...this.
14963         <abi_features>: New field.
14964         (riscv_isa_flen): Update comment.
14965         (riscv_abi_xlen): New declaration.
14966         (riscv_abi_flen): New declaration.
14967         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
14968         isa_features.
14969         (riscv_abi_xlen): New function.
14970         (riscv_isa_flen): Update to get answer from isa_features.
14971         (riscv_abi_flen): New function.
14972         (riscv_has_fp_abi): Update to get answer from abi_features.
14973         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
14974         xlen and flen.
14975         (riscv_call_info) <xlen, flen>: Update comment.
14976         (riscv_call_arg_struct): Remove invalid assertions
14977         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
14978         is removed.
14979         (riscv_gdbarch_init): Gather isa features and abi features
14980         separately, ensure both match on the gdbarch when reusing an old
14981         gdbarch.  Relax an error check to allow 32-bit abi float to run on
14982         a target with 64-bit float hardware.
14983
14984 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14985
14986         * source.c (search_command_helper): Stop reverse search
14987         when line 1 has been searched.
14988
14989 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14990
14991         * record-full.c (record_full_base_target::close): Rewrite
14992         record_full_core_buf_list free logic.
14993
14994 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14995
14996         * break-catch-syscall.c (print_one_catch_syscall): xfree
14997         the last text.
14998
14999 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
15000
15001         * top.c (print_gdb_version): Update Copyright year in version
15002         message.
15003
15004 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
15005
15006         Update copyright year range in all GDB files.
15007
15008 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
15009
15010         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
15011
15012 For older changes see ChangeLog-2018.
15013 \f
15014 Local Variables:
15015 mode: change-log
15016 left-margin: 8
15017 fill-column: 74
15018 version-control: never
15019 coding: utf-8
15020 End:
15021