gdb/ChangeLog

   1 2019-11-14  Simon Marchi  <simon.marchi@polymtl.ca>
   2
   3         * unittests/vec-utils-selftests.c (unordered_remove_tests::obj):
   4         Provide explicit default and copy constructor.
   5
   6 2019-11-14  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
   7
   8         * python/py-finishbreakpoint.c (gdbpy_breakpoint_created):
   9         only call Py_INCREF (newbp) in the bppy_pending_object case.
  10
  11 2019-11-13  Tom Tromey  <tromey@adacore.com>
  12
  13         PR build/25182:
  14         * psympriv.h (partial_symbol): Remove static assert.
  15         * symtab.h (general_symbol_info, symbol): Remove static assert.
  16
  17 2019-11-12  Andrew Burgess  <andrew.burgess@embecosm.com>
  18
  19         * gdbsupport/format.c (format_pieces::format_pieces): Support
  20         printf 'z' size modifier.
  21         * gdbsupport/format.h (enum argclass): Add size_t_arg.
  22         * printcmd.c (ui_printf):  Handle size_t_arg.
  23         * ui-out.c (ui_out::vmessage): Likewise.
  24         * unittests/format_pieces-selftests.c (test_format_int_sizes): New
  25         function.
  26         (run_tests): Call test_format_int_sizes.
  27
  28 2019-11-12  Christian Biesinger  <cbiesinger@google.com>
  29
  30         * ada-exp.y (write_ambiguous_var): Update.
  31         * buildsym.c (add_symbol_to_list): Update.
  32         * dwarf2read.c (read_variable): Update.
  33         (new_symbol): Update.
  34         * jit.c (finalize_symtab): Update.
  35         * language.c (language_alloc_type_symbol): Update.
  36         * symtab.c (fixup_symbol_section): Update.
  37         (initialize_objfile_symbol_1): Move code to...
  38         (initialize_objfile_symbol): ...here. Remove now-unnecessary memset.
  39         (allocate_symbol): Update.
  40         (allocate_template_symbol): Update.
  41         (get_symbol_address): Update.
  42         * symtab.h (struct symbol): Inherit from general_symbol_info instead
  43         of having as a field, and add a constructor.
  44         (SYMBOL_VALUE): Update.
  45         (SYMBOL_VALUE_ADDRESS): Update.
  46         (SET_SYMBOL_VALUE_ADDRESS): Update.
  47         (SYMBOL_VALUE_BYTES): Update.
  48         (SYMBOL_VALUE_COMMON_BLOCK): Update.
  49         (SYMBOL_BLOCK_VALUE): Update.
  50         (SYMBOL_VALUE_CHAIN): Update.
  51         (SYMBOL_LANGUAGE): Update.
  52         (SYMBOL_SECTION): Update.
  53         (SYMBOL_OBJ_SECTION): Update.
  54         (SYMBOL_SET_LANGUAGE): Update.
  55         (SYMBOL_SET_LINKAGE_NAME): Update.
  56         (SYMBOL_SET_NAMES): Update.
  57         (SYMBOL_NATURAL_NAME): Update.
  58         (SYMBOL_LINKAGE_NAME): Update.
  59         (SYMBOL_DEMANGLED_NAME): Update.
  60         (SYMBOL_SEARCH_NAME): Update.
  61         (SYMBOL_MATCHES_SEARCH_NAME): Update.
  62         (struct symbol): Update.
  63         (struct template_symbol): Update.
  64         (struct rust_vtable_symbol): Update.
  65         * xcoffread.c (SYMBOL_DUP): Update.
  66
  67 2019-11-12  Tom Tromey  <tom@tromey.com>
  68
  69         * tui/tui-layout.c (show_layout): Set current_layout.
  70         (show_source_disasm_command, show_data)
  71         (show_source_or_disasm_and_command): Don't set current_layout.
  72
  73 2019-11-12  Tom Tromey  <tom@tromey.com>
  74
  75         * tui/tui-layout.c (_initialize_tui_layout): Move to end.
  76
  77 2019-11-12  Tom Tromey  <tom@tromey.com>
  78
  79         * tui/tui-win.c (resize_message): New global.
  80         (show_tui_resize_message): New function.
  81         (tui_async_resize_screen): Print message if requested.
  82         (_initialize_tui_win): Add tui-resize-message setting.
  83         * NEWS: Add entry for new commands.
  84
  85 2019-11-11  Tom Tromey  <tom@tromey.com>
  86
  87         * tui/tui.c (tui_initialize_readline): Add new bindable readline
  88         functions.
  89
  90 2019-11-11  Christian Biesinger  <cbiesinger@google.com>
  91
  92         * nat/linux-osdata.c (user_from_uid): Use getpwuid_r.
  93
  94 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
  95
  96         * python/py-symbol.c (gdbpy_lookup_static_symbols): New
  97         function.
  98         * python/python-internal.h (gdbpy_lookup_static_symbols):
  99         Declare new function.
 100         * python/python.c (python_GdbMethods): Add
 101         gdb.lookup_static_symbols method.
 102         * NEWS: Mention gdb.lookup_static_symbols.
 103
 104 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
 105
 106         * python/py-symbol.c (gdbpy_lookup_static_symbol): Lookup in
 107         static block of current object file first.  Also fix typo in
 108         header comment.
 109
 110 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
 111
 112         * stack.c (set_last_displayed_sal): Delete.
 113         (last_displayed_sal_valid): Delete.
 114         (last_displayed_pspace): Delete.
 115         (last_displayed_addr): Delete.
 116         (last_displayed_symtab): Delete.
 117         (last_displayed_line): Delete.
 118         (class last_displayed_symtab_info_type): New.
 119         (last_displayed_symtab_info): New static global variable.
 120         (print_frame_info): Call methods on last_displayed_symtab_info.
 121         (clear_last_displayed_sal): Update header comment, and make use of
 122         last_displayed_symtab_info.
 123         (last_displayed_sal_is_valid): Likewise.
 124         (get_last_displayed_pspace): Likewise.
 125         (get_last_displayed_addr): Likewise.
 126         (get_last_displayed_symtab): Likewise.
 127         (get_last_displayed_line): Likewise.
 128         (get_last_displayed_sal): Likewise.
 129         * stack.h (clear_last_displayed_sal): Update header comment.
 130         (last_displayed_sal_is_valid): Likewise.
 131         (get_last_displayed_pspace): Likewise.
 132         (get_last_displayed_addr): Likewise.
 133         (get_last_displayed_symtab): Likewise.
 134         (get_last_displayed_line): Likewise.
 135         (get_last_displayed_sal): Likewise.
 136
 137 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
 138
 139         * stack.c (frame_show_address): Convert return type to bool.
 140         * stack.h (frame_show_address): Likewise, and update header
 141         comment.
 142
 143 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
 144
 145         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add new file to the list.
 146         * unittests/vec-utils-selftests.c: New file.
 147         * gdbsupport/gdb_vecs.h (unordered_remove): Avoid self move assign.
 148
 149 2019-11-10  Tom Tromey  <tom@tromey.com>
 150
 151         * tui/tui-wingeneral.c (tui_unhighlight_win): Use can_box.
 152         (tui_highlight_win): Likewise.
 153         (tui_win_info::check_and_display_highlight_if_needed): Likewise.
 154         * tui/tui-data.h (struct tui_win_info) <can_highlight>: Remove.
 155         * tui/tui-command.h (struct tui_cmd_window) <tui_cmd_window>:
 156         Don't set can_highlight.
 157
 158 2019-11-10  Tom Tromey  <tom@tromey.com>
 159
 160         * cli/cli-style.h (class cli_style_option) <cli_style_option>:
 161         Remove unused declaration.
 162
 163 2019-11-08  Tom Tromey  <tromey@adacore.com>
 164
 165         * top.c (read_command_file): Update.
 166         (command_line_input): Make return type const.
 167         * python/py-gdb-readline.c: Update.
 168         * linespec.c (decode_line_2): Update.
 169         * defs.h (command_line_input): Make return type const.
 170         * cli/cli-script.c (read_next_line): Make return type const.
 171         * ada-lang.c (get_selections): Update.
 172
 173 2019-11-06  Christian Biesinger  <cbiesinger@google.com>
 174
 175         * linux-tdep.c (linux_info_proc): Use strtok_r instead of strtok.
 176         * mi/mi-main.c (output_cores): Likewise.
 177         * nat/linux-osdata.c (linux_xfer_osdata_cpus): Likewise.
 178         (linux_xfer_osdata_modules): Likewise.
 179         * remote.c (register_remote_support_xml): Likewise.
 180         * sparc64-tdep.c (adi_is_addr_mapped): Likewise.
 181         * xml-syscall.c (syscall_create_syscall_desc): Likewise.
 182
 183 2019-11-06  Tom Tromey  <tom@tromey.com>
 184
 185         * tui/tui-interp.c: Don't include readline.h.
 186         * tui/tui-hooks.c: Don't include readline.h.
 187         * symmisc.c: Include tilde.h, not readline.h.
 188         * symfile.c: Include tilde.h, not readline.h.
 189         * source.c: Include tilde.h, not readline.h.
 190         * solib.c: Include tilde.h, not readline.h.
 191         * psymtab.c: Include tilde.h, not readline.h.
 192         * exec.c: Include tilde.h, not readline.h.
 193         * corelow.c: Include tilde.h, not readline.h.
 194         * cli/cli-dump.c: Include tilde.h, not readline.h.
 195         * cli/cli-cmds.c: Don't include readline.h.
 196
 197 2019-11-05  Tom Tromey  <tom@tromey.com>
 198
 199         * tui/tui-disasm.c (struct tui_asm_line) <addr_size>: New member.
 200         (tui_disassemble): Set addr_size.
 201         (tui_disasm_window::set_contents): Use addr_size.
 202
 203 2019-11-05  Tom Tromey  <tom@tromey.com>
 204
 205         * rust-lang.c (rust_language_defn): Update.
 206         * python/py-value.c (valpy_string): Call c_get_string.
 207         * p-lang.c (pascal_language_defn): Update.
 208         * opencl-lang.c (opencl_language_defn): Update.
 209         * objc-lang.c (objc_language_defn): Update.
 210         * m2-lang.c (m2_language_defn): Update.
 211         * language.c (unknown_language_defn, auto_language_defn): Update.
 212         (default_get_string): Remove.
 213         * guile/scm-value.c (gdbscm_value_to_string): Use c_get_string.
 214         * go-lang.c (go_language_defn): Update.
 215         * f-lang.c (f_language_defn): Update.
 216         * d-lang.c (d_language_defn): Update.
 217         * c-lang.c (c_language_defn, cplus_language_defn)
 218         (asm_language_defn, minimal_language_defn): Update.
 219         * ada-lang.c (ada_language_defn): Update.
 220         * language.h (struct language_defn) <la_get_string>: Remove.
 221         (LA_GET_STRING): Remove.
 222         (default_get_string): Don't declare.
 223
 224 2019-11-05  Tom Tromey  <tom@tromey.com>
 225
 226         * tui/tui-source.h (struct tui_source_window): Inline
 227         constructor.  Remove destructor.
 228         <style_changed, m_observable>: Move to superclass.
 229         * tui/tui-winsource.h (tui_copy_source_line): Declare.
 230         (struct tui_source_window_base): Move private members to end.
 231         <style_changed, m_observable>: Move from tui_source_window.
 232         * tui/tui-winsource.c (tui_copy_source_line): Move from
 233         tui-source.c.  Rename from copy_source_line.  Add special handling
 234         for negative line number.
 235         (tui_source_window_base::style_changed): Move from
 236         tui_source_window.
 237         (tui_source_window_base): Register observer.
 238         (~tui_source_window_base): New.
 239         * tui/tui-source.c (copy_source_line): Move to tui-winsource.c;
 240         rename.
 241         (tui_source_window::set_contents): Use tui_copy_source_line.
 242         (tui_source_window::tui_source_window): Move to tui-source.h.
 243         (tui_source_window::~tui_source_window): Remove.
 244         (tui_source_window::style_changed): Move to superclass.
 245         * tui/tui-disasm.c (tui_disassemble): Create string file with
 246         styling, when possible.  Add "addr_size" parameter.
 247         (tui_disasm_window::set_contents): Use tui_copy_source_line.
 248         Don't compute maximum size.
 249         (len_without_escapes): New function
 250
 251 2019-11-05  Tom Tromey  <tom@tromey.com>
 252
 253         * tui/tui-winsource.h (struct tui_source_element) <line>: Now a
 254         std::string.
 255         * tui/tui-winsource.c (tui_show_source_line): Update.
 256         * tui/tui-source.c (tui_source_window::set_contents): Update.
 257         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
 258
 259 2019-11-05  Christian Biesinger  <cbiesinger@google.com>
 260
 261         * symtab.h (gdb_static_assert): Put && operator at the beginning
 262         of the line instead of the end.
 263
 264 2019-11-04  Christian Biesinger  <cbiesinger@google.com>
 265
 266         * psympriv.h: Add static_asserts for sizeof (general_symbol_info)
 267         and sizeof (symbol).
 268         * symtab.h: Add a static_assert for sizeof (partial_symbol).
 269
 270 2019-11-04  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
 271
 272         * NEWS (Changes since GDB 8.3): Document Solaris 10 removal.
 273         * configure.host: Mark *-*-solaris2.10* obsolete.
 274         * configure.tgt: Mark Solaris < 11 obsolete.
 275         * MAINTAINERS (Target Instruction Set Architectures) <sparc>:
 276         Update target triplet.
 277
 278 2019-11-01  Tom Tromey  <tromey@adacore.com>
 279
 280         * utils.c (print_sys_errmsg): Simplify.
 281
 282 2019-11-01  Tom Tromey  <tromey@adacore.com>
 283
 284         * gdbsupport/mingw-strerror.c (safe_strerror): Constify result.
 285
 286 2019-11-01  Christian Biesinger  <cbiesinger@google.com>
 287
 288         * configure: Regenerate.
 289         * configure.ac: Remove check for strerror_r.
 290         * gdbsupport/common.m4: Check for strerror_r.
 291
 292 2019-11-01  Luis Machado  <luis.machado@linaro.org>
 293
 294         PR gdb/25124
 295
 296         * arm-tdep.c (arm_per_objfile): Rename to ...
 297         (arm_per_bfd): ... this.
 298         (arm_objfile_data_key): Rename to ...
 299         (arm_bfd_data_key): ... this.
 300         (arm_find_mapping_symbol): Adjust access to new bfd_key-based
 301         data.
 302         (arm_record_special_symbol): Likewise.
 303
 304 2019-10-31  Andrew Burgess  <andrew.burgess@embecosm.com>
 305
 306         * ada-typeprint.c (ada_print_typedef): Don't print newline at the
 307         end.
 308         * c-typeprint.c (c_print_typedef): Likewise.
 309         * f-typeprint.c (f_print_typedef): Likewise.
 310         * m2-typeprint.c (m2_print_typedef): Likewise.
 311         * p-typeprint.c (pascal_print_typedef): Likewise.
 312         * rust-lang.c (rust_print_typedef): Likewise.
 313         * symtab.c (print_symbol_info): Print a newline after calling
 314         typedef_print.
 315
 316 2019-10-31  Andrew Burgess  <andrew.burgess@embecosm.com>
 317
 318         * symtab.c (info_module_cmdlist): New variable.
 319         (info_module_command): New function.
 320         (search_module_symbols): New function.
 321         (info_module_subcommand): New function.
 322         (struct info_modules_var_func_options): New struct.
 323         (info_modules_var_func_options_defs): New variable.
 324         (make_info_modules_var_func_options_def_group): New function.
 325         (info_module_functions_command): New function.
 326         (info_module_variables_command): New function.
 327         (info_module_var_func_command_completer): New function.
 328         (_initialize_symtab): Register new 'info module functions' and
 329         'info module variables' commands.
 330         * symtab.h (typedef symbol_search_in_module): New typedef.
 331         (search_module_symbols): Declare new function.
 332         * NEWS: Mention new commands.
 333
 334 2019-10-31  Andrew Burgess  <andrew.burgess@embecosm.com>
 335
 336         * dwarf2read.c (dw2_symtab_iter_next): Handle MODULE_DOMAIN.
 337         (dw2_expand_marked_cus): Handle MODULES_DOMAIN.
 338         (dw2_debug_names_iterator::next): Handle MODULE_DOMAIN and
 339         MODULES_DOMAIN.
 340         (scan_partial_symbols): Only create partial module symbols for non
 341         declarations.
 342         * psymtab.c (recursively_search_psymtabs): Handle MODULE_DOMAIN
 343         and MODULES_DOMAIN.
 344         * symtab.c (search_domain_name): Likewise.
 345         (search_symbols): Likewise.
 346         (print_symbol_info): Likewise.
 347         (symtab_symbol_info): Likewise.
 348         (info_modules_command): New function.
 349         (_initialize_symtab): Register 'info modules' command.
 350         * symtab.h (enum search_domain): Add MODULES_DOMAIN.
 351         * NEWS: Mention new 'info modules' command.
 352
 353 2019-10-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 354
 355         * NEWS: Mention $_gdb_setting, $_gdb_setting_str, $_gdb_maint_setting
 356         and $_gdb_maint_setting_str.
 357
 358 2019-10-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 359
 360         * cli/cli-cmds.c (setting_cmd, value_from_setting)
 361         (gdb_setting_internal_fn, gdb_maint_setting_internal_fn)
 362         (str_value_from_setting, gdb_setting_str_internal_fn)
 363         (gdb_maint_setting_str_internal_fn): New functions.
 364         (_initialize_cli_cmds): Define the new convenience functions.
 365         * gdb/cli/cli-setshow.h (get_setshow_command_value_string): Constify.
 366         * gdb/cli/cli-setshow.c (get_setshow_command_value_string): Constify.
 367
 368 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
 369
 370         * agent.c (set_can_use_agent): When the setting is turned on,
 371         look up agent symbols if we don't have them yet.
 372         (agent_new_objfile): Don't look up agent symbols when the agent
 373         setting is off.
 374
 375 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
 376
 377         * config.in: Regenerate.
 378
 379 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
 380
 381         * configure: Regenerate.
 382         * configure.ac: Check for strerror_r.
 383         * gdbsupport/common-utils.h (safe_strerror): Change return value
 384         to const char * and document that this function is now threadsafe.
 385         * gdbsupport/posix-strerror.c (safe_strerror): Make buf
 386         thread_local and call strerror_r, if available.
 387         * utils.c (perror_string): Update.
 388         (print_sys_errmsg): Update.
 389
 390 2019-10-31  Luis Machado  <luis.machado@linaro.org>
 391
 392         * arm-tdep.c (arm_exidx_data_key): Use bfd_key instead of
 393         objfile_key.
 394         (arm_exidx_new_objfile): Adjust to use objfile->obfd instead of
 395         objfile to fetch per-bfd data.
 396         (arm_find_exidx_entry): Likewise.
 397
 398 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
 399
 400         * gdbsupport/agent.c (debug_agent): Change type to bool.
 401         (use_agent): Likewise.
 402         (all_agent_symbols_look_up): Likewise.
 403         (agent_loaded_p): Change return value to bool.
 404         (agent_look_up_symbols): Update.
 405         (agent_capability_check): Change return value to bool.
 406         * gdbsupport/agent.h (agent_loaded_p): Likewise.
 407         (debug_agent): Change type to bool.
 408         (use_agent): Likewise.
 409         (agent_capability_check): Change return value to bool.
 410
 411 2019-10-30  Christian Biesinger  <cbiesinger@google.com>
 412
 413         * minsyms.c (clear_minimal_symbol_hash_tables): New function.
 414         (build_minimal_symbol_hash_tables): Code to clear the table moved
 415         to clear_minimal_symbol_hash_tables.
 416         (minimal_symbol_reader::install): Call clear_minimal_symbol_hash_tables
 417         when needed.
 418
 419 2019-10-29  Simon Marchi  <simon.marchi@polymtl.ca>
 420
 421         * infcmd.c: Remove includes.
 422         * infrun.c: Remove includes.
 423
 424 2019-10-29  Simon Marchi  <simon.marchi@polymtl.ca>
 425
 426         * ada-lang.h (GROW_VECT): Move to ada-lang.c.
 427         (grow_vect): Remove declaration.
 428         (ada_type_of_array): Remove declaration.
 429         (ada_update_initial_language): Remove declaration.
 430         (ada_fold_name): Remove declaration.
 431         (ada_fill_in_ada_prototype): Remove declaration.
 432         (user_select_syms): Remove declaration.
 433         (get_selections): Remove declaration.
 434         (ada_tag_type): Remove declaration.
 435         (ada_value_tag): Remove declaration.
 436         (ada_is_others_clause): Remove declaration.
 437         (ada_in_variant): Remove declaration.
 438         (ada_value_struct_elt): Remove declaration.
 439         (ada_attribute_name): Remove declaration.
 440         (ada_system_address_type): Remove declaration.
 441         * ada-lang.c (ada_watch_location_expression): Make static.
 442         (GROW_VECT): Move here from ada-lang.h.
 443         (grow_vect): Make static.
 444         (ada_update_initial_language): Make static.
 445         (ada_fold_name): Make static.
 446         (ada_type_of_array): Make static.
 447         (encoded_ordered_before): Move up.
 448         (sort_choices): Move up.
 449         (print_signatures): Move up.
 450         (ada_print_symbol_signature): Move up.
 451         (get_selections): Move up and make static.
 452         (user_select_syms): Move up and make static.
 453         (ada_value_struct_elt): Move up and make static.
 454         (ada_tag_type): Make static.
 455         (ada_value_tag): Make static.
 456         (ada_is_others_clause): Make static.
 457         (ada_in_variant): Make static.
 458         (ada_attribute_name): Make static.
 459
 460 2019-10-29  Simon Marchi  <simon.marchi@polymtl.ca>
 461
 462         * ada-lang.c: Remove includes.
 463         * ada-typeprint.c: Remove includes.
 464         * ada-valprint.c: Remove includes.
 465
 466 2019-10-29  Simon Marchi  <simon.marchi@efficios.com>
 467
 468         * addrmap.c: Add static assertions of type size, moved from
 469         _initialize_addrmap.
 470         (_initialize_addrmap): Remove.
 471
 472 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
 473
 474         * coffread.c (record_minimal_symbol): Update.
 475         (process_coff_symbol): Update.
 476         * dbxread.c (read_dbx_symtab): Update.
 477         * dwarf2read.c (add_partial_symbol): Update.
 478         (fixup_go_packaging): Update.
 479         (load_partial_dies): Update.
 480         (new_symbol): Update.
 481         * elfread.c (record_minimal_symbol): Change signature to use
 482         gdb::string_view instead of name+len.
 483         (elf_symtab_read): Update.
 484         (elf_rel_plt_read): Update.
 485         * mdebugread.c (parse_partial_symbols): Update.
 486         (handle_psymbol_enumerators): Update.
 487         (new_symbol): Update.
 488         * minsyms.c (minimal_symbol_reader::record_full): Change signature
 489         to use gdb::string_view instead of name+len.
 490         * minsyms.h (class minimal_symbol_reader) <record_full>: Likewise.
 491         * psympriv.h (add_psymbol_to_list): Likewise.
 492         * psymtab.c (add_psymbol_to_bcache): Likewise.
 493         (add_psymbol_to_list): Likewise.
 494         * stabsread.c (define_symbol): Update.
 495         * symtab.c (symbol_set_names): Change signature to use gdb::string_view.
 496         * symtab.h (SYMBOL_SET_NAMES): Likewise.
 497         (symbol_set_names): Likewise.
 498         * xcoffread.c (scan_xcoff_symtab): Update.
 499
 500 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
 501
 502         * symtab.h (symbol_set_names): Document that copy_name must be
 503         set to true for non-nullterminated strings.
 504         * symtab.c (symbol_set_names): Only make a nullterminated copy of
 505         linkage_name if the entry was not found and we need to demangle.
 506
 507 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
 508
 509         * Makefile.in (HFILES_NO_SRCDIR): Add gdb_binary_search.h.
 510         * dwarf2-frame.c (bsearch_fde_cmp): Update.
 511         (dwarf2_frame_find_fde): Replace bsearch with gdb::binary_search.
 512         * gdbsupport/gdb_binary_search.h: New file.
 513
 514 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
 515
 516         * NEWS: Mention new --with-system-gdbinit-dir option.
 517         * config.in: Regenerate.
 518         * configure: Regenerate.
 519         * configure.ac: Add new option --with-system-gdbinit-dir.
 520         * extension.c (get_ext_lang_of_file): Return extension_language_gdb
 521         for a ".gdb" suffix.
 522         * main.c (get_init_files): Change system_gdbinit argument to
 523         a vector and return the files in SYSTEM_GDBINIT_DIR in
 524         addition to SYSTEM_GDBINIT.
 525         (captured_main_1): Update.
 526         (print_gdb_help): Update.
 527         * top.c (print_gdb_configuration): Also print the value of
 528         SYSTEM_GDBINIT_DIR.
 529
 530 2019-10-28  Christian Biesinger  <cbiesinger@google.com>
 531
 532         * gdbsupport/common-utils.h (startswith): Add an overloaded version
 533         that takes gdb::string_view arguments.
 534
 535 2019-10-26  Tom de Vries  <tdevries@suse.de>
 536
 537         * aarch64-linux-tdep.c: Fix typos in comments.
 538         * aarch64-tdep.c: Same.
 539         * ada-lang.c: Same.
 540         * amd64-nat.c: Same.
 541         * arc-tdep.c: Same.
 542         * arch/aarch64-insn.c: Same.
 543         * block.c: Same.
 544         * breakpoint.h: Same.
 545         * btrace.h: Same.
 546         * c-varobj.c: Same.
 547         * cli/cli-decode.c: Same.
 548         * cli/cli-script.c: Same.
 549         * cli/cli-utils.h: Same.
 550         * coff-pe-read.c: Same.
 551         * coffread.c: Same.
 552         * compile/compile-cplus-symbols.c: Same.
 553         * compile/compile-object-run.c: Same.
 554         * completer.c: Same.
 555         * corelow.c: Same.
 556         * cp-support.c: Same.
 557         * demangle.c: Same.
 558         * dwarf-index-write.c: Same.
 559         * dwarf2-frame.c: Same.
 560         * dwarf2-frame.h: Same.
 561         * eval.c: Same.
 562         * frame-base.h: Same.
 563         * frame.h: Same.
 564         * gdbcmd.h: Same.
 565         * gdbtypes.h: Same.
 566         * gnu-nat.c: Same.
 567         * guile/scm-objfile.c: Same.
 568         * i386-tdep.c: Same.
 569         * i386-tdep.h: Same.
 570         * infcall.c: Same.
 571         * infcall.h: Same.
 572         * linux-nat.c: Same.
 573         * m68k-tdep.c: Same.
 574         * macroexp.c: Same.
 575         * memattr.c: Same.
 576         * mi/mi-cmd-disas.c: Same.
 577         * mi/mi-getopt.h: Same.
 578         * mi/mi-main.c: Same.
 579         * minsyms.c: Same.
 580         * nat/aarch64-sve-linux-sigcontext.h: Same.
 581         * objfiles.h: Same.
 582         * ppc-linux-nat.c: Same.
 583         * ppc-linux-tdep.c: Same.
 584         * ppc-tdep.h: Same.
 585         * progspace.h: Same.
 586         * prologue-value.h: Same.
 587         * python/py-evtregistry.c: Same.
 588         * python/py-instruction.h: Same.
 589         * record-btrace.c: Same.
 590         * record-full.c: Same.
 591         * remote.c: Same.
 592         * rs6000-tdep.c: Same.
 593         * ser-tcp.c: Same.
 594         * sol-thread.c: Same.
 595         * sparc-sol2-tdep.c: Same.
 596         * sparc64-tdep.c: Same.
 597         * stabsread.c: Same.
 598         * symfile.c: Same.
 599         * symtab.h: Same.
 600         * target.c: Same.
 601         * tracepoint.c: Same.
 602         * tui/tui-data.h: Same.
 603         * tui/tui-io.c: Same.
 604         * tui/tui-win.c: Same.
 605         * tui/tui.c: Same.
 606         * unittests/rsp-low-selftests.c: Same.
 607         * user-regs.h: Same.
 608         * utils.c: Same.
 609         * utils.h: Same.
 610         * valarith.c: Same.
 611         * valops.c: Same.
 612         * valprint.c: Same.
 613         * valprint.h: Same.
 614         * value.c: Same.
 615         * value.h: Same.
 616         * varobj.c: Same.
 617         * x86-nat.h: Same.
 618         * xtensa-tdep.c: Same.
 619
 620 2019-10-25  Ali Tamur <tamur@google.com>
 621
 622         * charset.c (find_charset_names): Reflect API change.
 623
 624 2019-10-25  Christian Biesinger  <cbiesinger@google.com>
 625
 626         * symtab.c (struct demangled_name_entry): Change demangled name
 627         to a unique_xmalloc_ptr<char>, now that we don't allocate it as
 628         part of the struct anymore.
 629         (symbol_set_names): No longer obstack allocate + copy the demangled
 630         name, just store the allocated name from bfd.
 631
 632 2019-10-25  Tom Tromey  <tromey@adacore.com>
 633
 634         * dwarf2-frame.c (dwarf2_cie_table): Now a typedef.
 635         (bsearch_cie_cmp, add_cie): Remove.
 636         (find_cie): Reimplement.
 637         (decode_frame_entry_1, decode_frame_entry): Change type.  Update.
 638         (dwarf2_build_frame_info): Update.
 639
 640 2019-10-24  H.J. Lu  <hongjiu.lu@intel.com>
 641
 642         PR gdb/25126
 643         * symfile.c (reread_symbols): Call forget_cached_source_info to
 644         clear the stale source cache.
 645
 646 2019-10-24  Christian Biesinger  <cbiesinger@google.com>
 647
 648         * configure: Regenerate.
 649         * configure.ac: Remove code that sets python_has_threads.
 650
 651 2019-10-24  Christian Biesinger  <cbiesinger@google.com>
 652
 653         * config.in: Regenerate.
 654         * configure: Regenerate.
 655         * configure.ac: Remove the code that uses sed to get the python
 656         version and defines HAVE_LIBPYTHON2_6 / HAVE_LIBPYTHON2_7.
 657
 658 2019-10-24  Andrew Burgess  <andrew.burgess@embecosm.com>
 659
 660         * python/py-progspace.c (pspy_block_for_pc): Return None for all
 661         error paths.
 662
 663 2019-10-23  Tom Tromey  <tom@tromey.com>
 664
 665         * arc-tdep.c: Remove ".." from include.
 666         * frv-tdep.c: Remove ".." from include.
 667         * lm32-tdep.c: Remove ".." from include.
 668         * microblaze-tdep.c: Remove ".." from include.
 669         * or1k-tdep.h: Remove ".." from include.
 670         * s12z-tdep.c: Remove ".." from include.
 671         * Makefile.in (OPCODES_CFLAGS): Add comment.
 672         (TOP_CFLAGS): New variable.
 673         (INTERNAL_CFLAGS_BASE): Add TOP_CFLAGS.
 674
 675 2019-10-23  Tom Tromey  <tom@tromey.com>
 676
 677         * Makefile.in (READLINE_DIR): Update.
 678
 679 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 680
 681         * infcall.c (call_function_by_hand_dummy): Fix the function
 682         comment.  And extract out a code section into...
 683         (reserve_stack_space): ...this new function.
 684
 685 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 686
 687         * infcall.c (value_arg_coerce): Remove an unused parameter.
 688         (call_function_by_hand_dummy): Update the call to
 689         'value_arg_coerce'.
 690
 691 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 692
 693         * infcall.c (call_function_by_hand_dummy): Refactor.
 694
 695 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 696
 697         * MAINTAINERS (Write After Approval): Add Tankut Baris Aktemur.
 698
 699 2019-10-23  Tom Tromey  <tom@tromey.com>
 700
 701         * configure: Rebuild.
 702         * configure.ac: Don't check for sigprocmask.
 703         * gdbsupport/common.m4 (GDB_AC_COMMON): Check for sigprocmask.
 704
 705 2019-10-23  Tom Tromey  <tom@tromey.com>
 706
 707         * configure: Rebuild.
 708         * acinclude.m4: Use m4_include, not sinclude.
 709
 710 2019-10-23  Tom de Vries  <tdevries@suse.de>
 711
 712         PR breakpoints/24687
 713         * symtab.c (iterate_over_some_symtabs): Apply gdb_realpath on fullname.
 714
 715 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
 716
 717         * symtab.c (struct demangled_name_entry) <language>: Change from
 718         bitfield to regular variable.
 719
 720 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
 721
 722         * symtab.c (struct demangled_name_entry): Add a constructor.
 723         (free_demangled_name_entry): New function to call the destructor
 724         for demangled_name_entry.
 725         (create_demangled_names_hash): Pass free_demangled_name_entry to
 726         htab_create_alloc.
 727         (symbol_set_names): Call placement new for demangled_name_entry.
 728         * utils.c: No longer include xxhash.h here, now that fast_hash
 729         is inlined in the header.
 730         * utils.h: Instead, include it here.
 731
 732 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
 733
 734         * Makefile.in: Link with libxxhash.
 735         * config.in: Regenerate.
 736         * configure: Regenerate.
 737         * configure.ac: Search for libxxhash.
 738         * utils.c (fast_hash): Use xxhash if present.
 739
 740 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
 741
 742         * utils.h (fast_hash): New function.
 743         * symtab.c (hash_demangled_name_entry): Call new function
 744         fast_hash.
 745
 746 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
 747
 748         * symtab.c (struct demangled_name_entry): Change type of mangled
 749         to gdb::string_view. Also adds a constructor that takes the
 750         mangled name.
 751         (hash_demangled_name_entry): Update.
 752         (eq_demangled_name_entry): Update.
 753         (free_demangled_name_entry): New function to call the destructor
 754         now that this is not a POD anymore.
 755         (create_demangled_names_hash): Pass free_demangled_name_entry to
 756         htab_create_alloc.
 757         (symbol_set_names): Update.
 758
 759 2019-10-21  Ali Tamur  <tamu@google.com>
 760
 761         * dwarf2read.c (dir_index): Change type.
 762         (file_name_index): Likewise.
 763         (line_header::include_dir_at): Change comment and implementation on
 764         whether it is DWARF 5.
 765         (line_header::is_valid_file_index): New function.
 766         (line_header::file_name_at): Change comment and implementation on
 767         whether it is DWARF 5.
 768         (line_header::file_names): Change to private field renamed as
 769         m_file_names and introduce a new accessor method.
 770         (line_header::file_names_size): New method.
 771         (line_header::include_dirs): Change to private field and rename as
 772         m_include_dirs.
 773         (dw2_get_file_names_reader): Define local var at a smaller scope and
 774         reflect API change.
 775         (dwarf2_cu::setup_type_unit_groups): Reflect API change.
 776         (process_structure_scope): Likewise.
 777         (line_header::add_include_dir): Change message and reflect renaming.
 778         (line_header::add_file_name): Likewise.
 779         (read_formatted_entries): Handle DW_FORM_data16.
 780         (dwarf_decode_line_header): Fix line header length calculation.
 781         (psymtab_include_file_name): Change comment and API.
 782         (lnp_state_machine::m_file): Update comment and reflect type change.
 783         (lnp_state_machine::record_line): Reflect type change.
 784         (dwarf_decode_lines): Reflect API change.
 785         (file_file_name): Likewise.
 786         (file_full_name): Likewise.
 787
 788 2019-10-21  Andrew Burgess  <andrew.burgess@embecosm.com>
 789
 790         * objfiles.c (sort_cmp): Ensure that !(a < a) holds true.
 791
 792 2019-10-21  Tom Tromey  <tom@tromey.com>
 793
 794         * tui/tui-winsource.h (tui_exec_info_content): Remove typedef.
 795
 796 2019-10-21  Tom Tromey  <tom@tromey.com>
 797
 798         * configure.ac (nm.h): Conditionally create nm.h link.  Subst
 799         NM_H.   Use AC_CONFIG_LINKS.
 800         * configure: Rebuild.
 801         * Makefile.in (NM_H): New variable.
 802         (generated_files): Add NM_H.  Remove gcore.
 803         (nm.h, stamp-nmh): New targets.
 804
 805 2019-10-20  Tom Tromey  <tom@tromey.com>
 806
 807         * objfiles.h (unlink_objfile, put_objfile_before): Don't declare.
 808         * objfiles.c (unlink_objfile): Move earlier.  Now static.  Remove
 809         obsolete comment.
 810         (put_objfile_before): Now static.
 811
 812 2019-10-19  Simon Marchi  <simon.marchi@polymtl.ca>
 813
 814         * gdbsupport/common-utils.h (startswith): Change return type to
 815         bool.
 816
 817 2019-10-19  Christian Biesinger  <cbiesinger@google.com>
 818
 819         * bcache.c (bcache::print_statistics): Use std::sort instead of qsort.
 820         * breakpoint.c (bp_locations_compare): Rename to...
 821         (bp_location_is_less_than): ...this, and change to std::sort semantics.
 822         (update_global_location_list): Use std::sort instead of qsort.
 823         * buildsym.c (compare_line_numbers): Rename to...
 824         (lte_is_less_than): ...this, and change to std::sort semantics.
 825         (buildsym_compunit::end_symtab_with_blockvector): Use std::sort
 826         instead of qsort.
 827         * disasm.c (compare_lines): Rename to...
 828         (line_is_less_than): ...this, and change to std::sort semantics.
 829         (do_mixed_source_and_assembly_deprecated): Call std::sort instead
 830         of qsort.
 831         * dwarf2-frame.c (qsort_fde_cmp): Rename to...
 832         (fde_is_less_than): ...this, and change to std::sort semantics.
 833         (dwarf2_build_frame_info): Call std::sort instead of qsort.
 834         * mdebugread.c (compare_blocks):
 835         (block_is_less_than): ...this, and change to std::sort semantics.
 836         (sort_blocks): Call std::sort instead of qsort.
 837         * objfiles.c (qsort_cmp): Rename to...
 838         (sort_cmp): ...this, and change to std::sort semantics.
 839         (update_section_map): Call std::sort instead of qsort.
 840         * remote.c (compare_pnums): Remove.
 841         (map_regcache_remote_table): Call std::sort instead of qsort.
 842         * utils.c (compare_positive_ints): Remove.
 843         * utils.h (compare_positive_ints): Remove.
 844         * xcoffread.c (compare_lte): Remove.
 845         (arrange_linetable): Call std::sort instead of qsort.
 846
 847 2019-10-19  Sergio Durigan Junior  <sergiodj@redhat.com>
 848
 849         * symfile.c (init_entry_point_info): Fix typo.
 850         * i386-darwin-tdep.c (darwin_dwarf_signal_frame_p): Fix typo.
 851
 852 2019-10-18  Tom de Vries  <tdevries@suse.de>
 853
 854         * aarch64-tdep.c: Fix typos in comments.
 855         * ada-lang.c: Same.
 856         * ada-tasks.c: Same.
 857         * alpha-tdep.c: Same.
 858         * alpha-tdep.h: Same.
 859         * amd64-nat.c: Same.
 860         * amd64-windows-tdep.c: Same.
 861         * arc-tdep.c: Same.
 862         * arc-tdep.h: Same.
 863         * arch-utils.c: Same.
 864         * arm-nbsd-tdep.c: Same.
 865         * arm-tdep.c: Same.
 866         * ax-gdb.c: Same.
 867         * blockframe.c: Same.
 868         * btrace.c: Same.
 869         * c-varobj.c: Same.
 870         * coff-pe-read.c: Same.
 871         * coffread.c: Same.
 872         * cris-tdep.c: Same.
 873         * darwin-nat.c: Same.
 874         * dbxread.c: Same.
 875         * dcache.c: Same.
 876         * disasm.c: Same.
 877         * dtrace-probe.c: Same.
 878         * dwarf-index-write.c: Same.
 879         * dwarf2-frame-tailcall.c: Same.
 880         * dwarf2-frame.c: Same.
 881         * dwarf2read.c: Same.
 882         * eval.c: Same.
 883         * exceptions.c: Same.
 884         * fbsd-tdep.c: Same.
 885         * findvar.c: Same.
 886         * frame.c: Same.
 887         * frv-tdep.c: Same.
 888         * gnu-v3-abi.c: Same.
 889         * go32-nat.c: Same.
 890         * h8300-tdep.c: Same.
 891         * hppa-tdep.c: Same.
 892         * i386-linux-tdep.c: Same.
 893         * i386-tdep.c: Same.
 894         * ia64-libunwind-tdep.c: Same.
 895         * ia64-tdep.c: Same.
 896         * infcmd.c: Same.
 897         * infrun.c: Same.
 898         * linespec.c: Same.
 899         * linux-nat.c: Same.
 900         * linux-thread-db.c: Same.
 901         * machoread.c: Same.
 902         * mdebugread.c: Same.
 903         * mep-tdep.c: Same.
 904         * mn10300-tdep.c: Same.
 905         * namespace.c: Same.
 906         * objfiles.c: Same.
 907         * opencl-lang.c: Same.
 908         * or1k-tdep.c: Same.
 909         * osabi.c: Same.
 910         * ppc-linux-nat.c: Same.
 911         * ppc-linux-tdep.c: Same.
 912         * ppc-sysv-tdep.c: Same.
 913         * printcmd.c: Same.
 914         * procfs.c: Same.
 915         * record-btrace.c: Same.
 916         * record-full.c: Same.
 917         * remote-fileio.c: Same.
 918         * remote.c: Same.
 919         * rs6000-tdep.c: Same.
 920         * s12z-tdep.c: Same.
 921         * score-tdep.c: Same.
 922         * ser-base.c: Same.
 923         * ser-go32.c: Same.
 924         * skip.c: Same.
 925         * sol-thread.c: Same.
 926         * solib-svr4.c: Same.
 927         * solib.c: Same.
 928         * source.c: Same.
 929         * sparc-nat.c: Same.
 930         * sparc-sol2-tdep.c: Same.
 931         * sparc-tdep.c: Same.
 932         * sparc64-tdep.c: Same.
 933         * stabsread.c: Same.
 934         * stack.c: Same.
 935         * symfile.c: Same.
 936         * symtab.c: Same.
 937         * target-descriptions.c: Same.
 938         * target-float.c: Same.
 939         * thread.c: Same.
 940         * utils.c: Same.
 941         * valops.c: Same.
 942         * valprint.c: Same.
 943         * value.c: Same.
 944         * varobj.c: Same.
 945         * windows-nat.c: Same.
 946         * xcoffread.c: Same.
 947         * xstormy16-tdep.c: Same.
 948         * xtensa-tdep.c: Same.
 949
 950 2019-10-17  Tom Tromey  <tromey@adacore.com>
 951
 952         * configure: Rebuild.
 953         * configure.ac: Use AC_CONFIG_HEADERS.  Create stamp-h there, not
 954         in AC_CONFIG_FILES invocation.
 955         * Makefile.in (Makefile, data-directory/Makefile, stamp-h): Use
 956         new-style config.status invocation.
 957
 958 2019-10-17  Tom de Vries  <tdevries@suse.de>
 959
 960         * arm-nbsd-nat.c: Fix typos in comments.
 961         * arm-tdep.c: Same.
 962         * darwin-nat-info.c: Same.
 963         * dwarf2read.c: Same.
 964         * elfread.c: Same.
 965         * event-top.c: Same.
 966         * findvar.c: Same.
 967         * gdbtypes.c: Same.
 968         * hppa-tdep.c: Same.
 969         * i386-tdep.c: Same.
 970         * jit.c: Same.
 971         * main.c: Same.
 972         * mdebugread.c: Same.
 973         * moxie-tdep.c: Same.
 974         * nto-procfs.c: Same.
 975         * osabi.c: Same.
 976         * ppc-linux-tdep.c: Same.
 977         * remote.c: Same.
 978         * riscv-tdep.c: Same.
 979         * s390-tdep.c: Same.
 980         * sh-tdep.c: Same.
 981         * sparc-linux-tdep.c: Same.
 982         * sparc-nat.c: Same.
 983         * stack.c: Same.
 984         * target-descriptions.c: Same.
 985         * top.c: Same.
 986         * varobj.c: Same.
 987
 988 2019-10-16  Tom Tromey  <tom@tromey.com>
 989
 990         * objfiles.h (struct objfile) <original_name>: Now const.
 991
 992 2019-10-16  Christian Biesinger  <cbiesinger@google.com>
 993
 994         * gdbsupport/gdb_setjmp.h (SIGSETJMP): Allow passing in the value to
 995         pass on to sigsetjmp's second argument.
 996         * cp-support.c (gdb_demangle): Unblock SIGSEGV if we caught a crash.
 997
 998 2019-10-16  Keith Seitz  <keiths@redhat.com>
 999
1000         PR gdb/23567
1001         * dwarf2read.c (dwarf2_per_objfile::locate_sections): Discard
1002         sections whose size is greater than the file size.
1003
1004 2019-10-16  Jim Wilson  <jimw@sifive.com>
1005
1006         * riscv-tdep.c (riscv_gcc_target_options): New.
1007         (riscv_gnu_triplet_regexp): New.
1008         (riscv_gdbarch_init): Call set_gdbarch_gcc_triplet_options and
1009         set_gdbarch_gnu_triplet_regexp.
1010
1011 2019-10-16  Christian Biesinger  <cbiesinger@google.com>
1012
1013         * Makefile.in: Add xml-builtin.h.
1014         * features/feature_to_c.sh: Add an include for xml-builtin.h
1015         to ensure that the compiler checks that the types match.
1016         * xml-builtin.h: New file.
1017         * xml-support.c (fetch_xml_builtin): Add missing const.
1018         * xml-support.h: Remove declaration of xml_builtins.
1019
1020 2019-10-16  Tom de Vries  <tdevries@suse.de>
1021
1022         PR tdep/25096
1023         * amd64-tdep.c (amd64_classify_aggregate_field): Factor out of ...
1024         (amd64_classify_aggregate): ... here.
1025         (amd64_classify_aggregate_field): Handled fiels of nested structs
1026         recursively.
1027
1028 2019-10-16  Tom de Vries  <tdevries@suse.de>
1029
1030         PR tdep/24104
1031         * amd64-tdep.c (amd64_push_arguments): Handle AMD64_NO_CLASS in loop
1032         that handles 'theclass'.
1033
1034 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1035
1036         * linespec.c (decode_digits_ordinary): Update comment.
1037         * make-target-delegates: No longer need to handle VEC case.
1038         * memrange.c (normalize_mem_ranges): Update comment.
1039         * namespace.c (add_using_directive): Update comment.
1040         * objc-lang.c (uniquify_strings): Update comment.
1041         * ppc-linux-nat.c (struct thread_points): Update comment.
1042         * probe.h (find_probes_in_objfile): Update comment.
1043         * target.h (enum flash_preserve_mode): Update comment.
1044         * varobj.c (varobj_restrict_range): Update comment.
1045         * varobj.h (varobj_list_children): Update comment.
1046
1047 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1048
1049         * Makefile.in: Remove references to vec.h and vec.c.
1050         * aarch64-tdep.c: No longer include vec.h.
1051         * ada-lang.c: Likewise.
1052         * ada-lang.h: Likewise.
1053         * arm-tdep.c: Likewise.
1054         * ax.h: Likewise.
1055         * breakpoint.h: Likewise.
1056         * charset.c: Likewise.
1057         * cp-support.h: Likewise.
1058         * dtrace-probe.c: Likewise.
1059         * dwarf2read.c: Likewise.
1060         * extension.h: Likewise.
1061         * gdb_bfd.c: Likewise.
1062         * gdbsupport/gdb_vecs.h: Likewise.
1063         * gdbsupport/vec.c: Remove.
1064         * gdbsupport/vec.h: Remove.
1065         * gdbthread.h: Likewise.
1066         * guile/scm-type.c: Likewise.
1067         * inline-frame.c: Likewise.
1068         * machoread.c: Likewise.
1069         * memattr.c: Likewise.
1070         * memrange.h: Likewise.
1071         * namespace.h: Likewise.
1072         * nat/linux-btrace.h: Likewise.
1073         * osdata.c: Likewise.
1074         * parser-defs.h: Likewise.
1075         * progspace.h: Likewise.
1076         * python/py-type.c: Likewise.
1077         * record-btrace.c: Likewise.
1078         * rust-exp.y: Likewise.
1079         * solib-target.c: Likewise.
1080         * stap-probe.c: Likewise.
1081         * target-descriptions.c: Likewise.
1082         * target-memory.c: Likewise.
1083         * target.h: Likewise.
1084         * varobj.c: Likewise.
1085         * varobj.h: Likewise.
1086         * xml-support.h: Likewise.
1087
1088 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1089
1090         * gdb/dwarf2read.c (dwarf2_per_objfile::~dwarf2_per_objfile):
1091         Update for new std::vector based implementation.
1092         (process_psymtab_comp_unit_reader): Likewise.
1093         (scan_partial_symbols): Likewise.
1094         (recursively_compute_inclusions): Likewise.
1095         (compute_compunit_symtab_includes): Likewise.
1096         (process_imported_unit_die): Likewise.
1097         (queue_and_load_dwo_tu): Likewise.
1098         (follow_die_sig_1): Likewise.
1099         * gdb/dwarf2read.h: Remove DEF_VEC_P.
1100         (typedef dwarf2_per_cu_ptr): Remove.
1101         (struct dwarf2_per_cu_data) <imported_symtabs_empty>: New
1102         function.
1103         (struct dwarf2_per_cu_data) <imported_symtabs_push>: New function.
1104         (struct dwarf2_per_cu_data) <imported_symtabs_size>: New function.
1105         (struct dwarf2_per_cu_data) <imported_symtabs_free>: New function.
1106         (struct dwarf2_per_cu_data) <imported_symtabs>: Change to
1107         std::vector.
1108
1109 2019-10-15  Tom Tromey  <tromey@adacore.com>
1110
1111         * windows-nat.c (windows_nat_target::resume): Use %x when logging
1112         TID.
1113
1114 2019-10-15  Tom Tromey  <tromey@adacore.com>
1115
1116         * windows-nat.c (windows_nat_target::fetch_registers)
1117         (windows_nat_target::store_registers): Rename "pid" to "tid".
1118
1119 2019-10-15  Tom Tromey  <tromey@adacore.com>
1120
1121         * gdbarch.h, gdbarch.c: Rebuild.
1122         * gdbarch.sh (gcc_target_options): Change return type to
1123         std::string.
1124         * compile/compile.c (get_args): Update.
1125         * nios2-tdep.c (nios2_gcc_target_options): Return std::string.
1126         * arm-linux-tdep.c (arm_linux_gcc_target_options): Return
1127         std::string.
1128         * aarch64-linux-tdep.c (aarch64_linux_gcc_target_options): Return
1129         std::string.
1130         * arch-utils.c (default_gcc_target_options): Return std::string.
1131         * arch-utils.h (default_gcc_target_options): Return std::string.
1132         * s390-tdep.c (s390_gcc_target_options): Return std::string.
1133
1134 2019-10-15  Christian Biesinger  <cbiesinger@google.com>
1135
1136         * breakpoint.c (breakpoint_chain): Make static.
1137         * tui/tui-winsource.c: Call iterate_over_breakpoints instead
1138         of accessing breakpoint_chain.
1139
1140 2019-10-15  Christian Biesinger  <cbiesinger@google.com>
1141
1142         * breakpoint.c (iterate_over_breakpoints): Change function pointer
1143         to a gdb::function_view and return value to bool.
1144         * breakpoint.h (iterate_over_breakpoints): Likewise.
1145         * dummy-frame.c (pop_dummy_frame_bpt): Update.
1146         (pop_dummy_frame): Update.
1147         * guile/scm-breakpoint.c (bpscm_build_bp_list): Update.
1148         (gdbscm_breakpoints): Update.
1149         * python/py-breakpoint.c (build_bp_list): Update.
1150         (gdbpy_breakpoints): Update.
1151         * python/py-finishbreakpoint.c (bpfinishpy_detect_out_scope_cb):
1152         Update.
1153         (bpfinishpy_handle_stop): Update.
1154         (bpfinishpy_handle_exit): Update.
1155         * solib-svr4.c (svr4_update_solib_event_breakpoint): Update.
1156         (svr4_update_solib_event_breakpoints): Update.
1157
1158 2019-10-15  Andreas Arnez  <arnez@linux.ibm.com>
1159
1160         * s390-tdep.c (s390_effective_inner_type): Ignore static fields
1161         when unwrapping single-field structs.
1162
1163 2019-10-14  Simon Marchi  <simon.marchi@polymtl.ca>
1164
1165         * dwarf2read.c: Remove includes.
1166
1167 2019-10-13  Simon Marchi  <simon.marchi@polymtl.ca>
1168
1169         * ui-out.c (ui_out::call_do_message): Silence
1170         -Wformat-nonliteral warning.
1171
1172 2019-10-12  Simon Marchi  <simon.marchi@polymtl.ca>
1173
1174         * breakpoint.c: Remove some includes: continuations.h, skip.h,
1175         mi/mi-main.h, readline/readline.h, readline/history.h.  Add
1176         include: readline/tilde.h.
1177
1178 2019-10-12  Christian Biesinger  <cbiesinger@google.com>
1179
1180         * remote.c (remote_target::get_trace_status): Remove declaration of
1181         trace_regblock_size.
1182
1183 2019-10-12  Christian Biesinger  <cbiesinger@google.com>
1184
1185         * cli/cli-cmds.c (max_user_call_depth): Move comment to header.
1186         (show_user): Remove declaration of cmdlist.
1187         * cli/cli-cmds.h (max_user_call_depth): Declare.
1188         * cli/cli-script.c (execute_user_command): Remove declaration
1189         of max_user_call_depth.
1190
1191 2019-10-11  Jim Wilson  <jimw@sifive.com>
1192
1193         * gdbsupport/print-utils.h (pulongest): Fix comment.
1194         (plongest): Likewise.
1195         (phex): Add missing comment, mention leading zeros.
1196         (phex_nz): Add mention of no leading zeros to comment.
1197
1198         * riscv-tdep.c (riscv_push_dummy_code): Change %lld to %s and use
1199         plongest instead of unsigned long long cast.
1200
1201 2019-10-10  Christian Biesinger  <cbiesinger@google.com>
1202
1203         * main.c (captured_main_1): Include gdbtk.h and remove declarations
1204         for external_editor_command and gdbtk_test.
1205
1206 2019-10-10  Christian Biesinger  <cbiesinger@google.com>
1207
1208         * mi/mi-cmd-var.c (varobjdebug): Remove declaration.
1209         * varobj.c (varobjdebug): Move comment to...
1210         * varobj.h (varobjdebug): ...here, and declare.
1211
1212 2019-10-09  Tom Tromey  <tom@tromey.com>
1213
1214         * tui/tui-regs.c (tui_data_window::show_registers): Don't call
1215         erase_data_content.
1216
1217 2019-10-09  Tom Tromey  <tom@tromey.com>
1218
1219         * tui/tui-wingeneral.h (tui_delete_win): Don't declare.
1220         * tui/tui-stack.c (tui_locator_window::rerender): Update.
1221         * tui/tui-command.c (tui_cmd_window::resize)
1222         (tui_refresh_cmd_win): Update.
1223         * tui/tui-win.c (tui_resize_all, tui_set_focus_command): Update.
1224         * tui/tui.c (tui_rl_other_window, tui_enable): Update.
1225         * tui/tui-data.c (~tui_gen_win_info): Remove.
1226         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
1227         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
1228         (tui_redisplay_readline, tui_mld_flush)
1229         (tui_mld_erase_entire_line, tui_mld_getc, tui_getc): Update.
1230         * tui/tui-regs.c (tui_data_window::delete_data_content_windows)
1231         (tui_data_window::erase_data_content)
1232         (tui_data_item_window::rerender)
1233         (tui_data_item_window::refresh_window): Update.
1234         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window)
1235         (box_win, tui_gen_win_info::make_window)
1236         (tui_gen_win_info::make_visible): Update.
1237         (tui_delete_win): Remove.
1238         * tui/tui-winsource.c
1239         (tui_source_window_base::do_erase_source_content): Update.
1240         (tui_show_source_line, tui_source_window_base::update_tab_width)
1241         (tui_source_window_base::update_exec_info): Update.
1242         * tui/tui-data.h (struct curses_deleter): New.
1243         (struct tui_gen_win_info) <handle>: Now a unique_ptr.
1244         (struct tui_gen_win_info) <~tui_gen_win_info>: Define.
1245
1246 2019-10-09  Tom Tromey  <tom@tromey.com>
1247
1248         * tui/tui-wingeneral.h (struct tui_gen_win_info): Don't declare.
1249
1250 2019-10-09  Tom Tromey  <tom@tromey.com>
1251
1252         * tui/tui-data.c (tui_win_is_auxiliary): Remove.
1253         * tui/tui-data.h (tui_win_is_auxiliary): Don't declare.
1254
1255 2019-10-09  Tom Tromey  <tom@tromey.com>
1256
1257         * tui/tui-disasm.c (tui_get_low_disassembly_address): Compute
1258         window height directly.
1259         * tui/tui-layout.h (tui_default_win_viewport_height): Don't
1260         declare.
1261         * tui/tui-layout.c (tui_default_win_height): Remove.
1262         (tui_default_win_viewport_height): Remove.
1263
1264 2019-10-09  Tom Tromey  <tom@tromey.com>
1265
1266         * tui/tui.h: Remove comments.
1267
1268 2019-10-09  Tom de Vries  <tdevries@suse.de>
1269
1270         * python/lib/gdb/printer/bound_registers.py: Use
1271         '^builtin_type_bound128' as regexp argument for
1272         add_builtin_pretty_printer.
1273
1274 2019-10-09  Christian Biesinger  <cbiesinger@google.com>
1275
1276         * guile/guile.c (guile_extension_script_ops): Remove forward
1277         declaration and mark as static.
1278         (guile_script_ops): Likewise.
1279         (extension_language_guile): Move further down in the file so
1280         it can reference the definitions for guile_{extension_,}script_ops.
1281
1282 2019-10-09  Andreas Arnez  <arnez@linux.ibm.com>
1283
1284         * s390-tdep.c (390_process_record): Handle new arch13 instructions
1285         except SORTL, DFLTCC, and KDSA.
1286
1287 2019-10-08  Tom Tromey  <tromey@adacore.com>
1288
1289         * windows-nat.c (struct windows_thread_info_struct) <sf>: Remove.
1290         (struct safe_symbol_file_add_args): Remove.
1291
1292 2019-10-08  Tom Tromey  <tromey@adacore.com>
1293
1294         * windows-nat.c: Don't include buildsym-legacy.h.
1295
1296 2019-10-08  Tom Tromey  <tromey@adacore.com>
1297
1298         * contrib/ari/gdb_ari.sh (%p): Allow gdb-specific %p extensions.
1299
1300 2019-10-08  Christian Biesinger  <cbiesinger@google.com>
1301
1302         * gdbtypes.c (overload_debug): Move comment to header.
1303         * gdbtypes.h (overload_debug): Declare.
1304         * valops.c: Remove declaration of overload_debug, instead
1305         include gdbtypes.h.
1306
1307 2019-10-08  Christian Biesinger  <cbiesinger@google.com>
1308
1309         * language.c (show_language_command): Pass lang_frame_mismatch_warn
1310         through _().
1311         (lang_frame_mismatch_warn): Make const, mark with N_(), and
1312         move comment...
1313         * language.h (lang_frame_mismatch_warn): ... here. Also add
1314         declaration.
1315         * top.c (lang_frame_mismatch_warn): Remove declaration.
1316         (check_frame_language_change): Pass lang_frame_mismatch_warn
1317         through _().
1318
1319 2019-10-07  Christian Biesinger  <cbiesinger@google.com>
1320
1321         * c-lang.h (vtbl_ptr_name): Declare.
1322         * cp-valprint.c (vtbl_ptr_name): Remove "extern" now that we get
1323         it from the header.
1324         * stabsread.c (define_symbol): Remove declaration of vtbl_ptr_name.
1325
1326 2019-10-07  Christian Biesinger  <cbiesinger@google.com>
1327
1328         * charset.c (your_gdb_wchar_t_is_bogus): Replace with a
1329         gdb_static_assert.
1330
1331 2019-10-07  Weimin Pan  <weimin.pan@oracle.com>
1332
1333         * ../Makefile.def (dependencies): Add all-libctf to all-gdb
1334         * ../Makefile.in: Add "all-gdb: maybe-all-libctf"
1335         * ctfread.c: New file.
1336         * ctfread.h: New file.
1337         * elfread.c: Include ctfread.h.
1338         (struct elfinfo text_p): New member ctfsect.
1339         (elf_locate_sections): Mark CTF section.
1340         (elf_symfile_read): Call elfctf_build_psymtabs.
1341         * Makefile.in (LIBCTF): Add.
1342         (CLIBS): Use it.
1343         (CDEPS): Likewise.
1344         (DIST): Add ctfread.c.
1345
1346 2019-10-07  Andrew Burgess  <andrew.burgess@embecosm.com>
1347
1348         * ctfread.c (struct nextfield): Renamed to ...
1349         (struct ctf_nextfield): ... this.
1350         (struct field_info): Renamed to ...
1351         (strut ctf_field_info): ... this.
1352         (attach_fields_to_type): Update for renamed structures.
1353         (ctf_add_member_cb): Likewise.
1354         (ctf_add_enum_member_cb): Likewise.
1355         (process_struct_members): Likewise.
1356         (process_enum_type): Likewise.
1357
1358 2019-10-07  Weimin Pan  <weimin.pan@oracle.com>
1359
1360         * tracectf.h: Rename, was ctf.h.
1361         * tracectf.c: Rename, was ctf.c, replace ctf.h with tracectf.h.
1362         * tracefile.c: Likewise.
1363         * tracepoint.c: Remove unused include ctf.h.
1364         * mi/mi-main.c: Likewise.
1365         * Makefile.in Replace ctf.c with tracectf.c.
1366
1367 2019-10-06  Joel Brobecker  <brobecker@adacore.com>
1368
1369         * version.in: Change version number to "9.0.50.DATE-git".
1370
1371 2019-10-03  Tom Tromey  <tom@tromey.com>
1372
1373         PR rust/24976:
1374         * dwarf2read.c (quirk_rust_enum): Handle single-element unions.
1375
1376 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1377
1378         * f-lang.c (f_language_defn): Use cp_get_symbol_name_matcher and
1379         cp_search_name_hash.
1380         * NEWS: Add entry about nested function support.
1381
1382 2019-10-03  Bernhard Heckel  <bernhard.heckel@intel.com>
1383             Andrew Burgess  <andrew.burgess@embecosm.com>
1384
1385         * cp-namespace.c (cp_search_static_and_baseclasses): Only search
1386         for nested static variables when searchin VAR_DOMAIN.
1387         * dwarf2read.c (add_partial_symbol): Add nested subroutines to the
1388         global scope, update comment.
1389         (add_partial_subprogram): Call add_partial_subprogram recursively
1390         for nested subroutines when processinng Fortran.
1391         (load_partial_dies): Process the child entities of a subprogram
1392         when processing Fortran.
1393         (partial_die_parent_scope): Handle building scope
1394         for Fortran nested functions.
1395         (process_die): Record that nested functions have a scope.
1396         (new_symbol): Always record Fortran subprograms on the global
1397         symbol list.
1398         (determine_prefix): How to build the prefix for Fortran
1399         subprograms.
1400
1401 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1402
1403         * linux-nat.c (linux_nat_filter_event): Don't ignore SIGSTOP if we
1404         have just sent the thread a SIGSTOP and are waiting for it to
1405         arrive.
1406
1407 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1408
1409         * btrace.c (btrace_add_pc): Remove whitespace before the template
1410         parameter in 'std::vector <...>'.
1411         (parse_xml_btrace_block): Likewise.
1412         (btrace_maint_decode_pt): Likewise.
1413         (btrace_maint_update_packets): Likewise.
1414         (btrace_maint_print_packets): Likewise.
1415         * btrace.h (struct btrace_maint_info): Likewise.
1416         * dwarf2read.c (struct type_unit_group): Likewise.
1417         (build_type_psymtabs_reader): Likewise.
1418         * gdbsupport/btrace-common.c (btrace_data_append): Likewise.
1419         * gdbsupport/btrace-common.h (struct btrace_data_bts): Likewise.
1420         * nat/linux-btrace.c (perf_event_read_bts): Likewise.
1421
1422 2019-10-03  Tom de Vries  <tdevries@suse.de>
1423
1424         * cli/cli-style.c (_initialize_cli_style): Adding a '.' at the end of
1425         the first line of the help text for set/show style metadata.
1426
1427 2019-10-02  Tom Tromey  <tromey@adacore.com>
1428
1429         * Makefile.in (COMMON_SFILES): Add common-inferior.c.
1430         * gdbsupport/common-inferior.c: New file.
1431         * infcmd.c (startup_with_shell): Don't define.
1432         * nat/fork-inferior.h (startup_with_shell): Don't declare.
1433         * gdbsupport/common-inferior.h (startup_with_shell): Declare.
1434         * inferior.h (startup_with_shell): Don't declare.
1435
1436 2019-10-02  Christian Biesinger  <cbiesinger@google.com>
1437
1438         * gdbsupport/gdb_assert.h: Include errors.h.
1439         * gdbsupport/gdb_string_view.h: Include gdb_assert.h.
1440
1441 2019-10-02  Tom Tromey  <tromey@adacore.com>
1442
1443         * NEWS: Add $_ada_exception entry.
1444         * ada-lang.c (struct ada_catchpoint): Add constructor.
1445         <m_kind>: New member.
1446         (allocate_location_exception, re_set_exception): Remove
1447         "ex" parameter.
1448         (should_stop_exception): Compute $_ada_exception.
1449         (check_status_exception, print_it_exception)
1450         (print_one_exception, print_mention_exception): Remove
1451         "ex" parameter.
1452         (allocate_location_catch_exception, re_set_catch_exception)
1453         (check_status_exception, print_it_catch_exception)
1454         (print_one_catch_exception, print_mention_catch_exception)
1455         (print_recreate_catch_exception)
1456         (allocate_location_catch_exception_unhandled)
1457         (re_set_catch_exception_unhandled)
1458         (check_status_exception, print_it_catch_exception_unhandled)
1459         (print_one_catch_exception_unhandled)
1460         (print_mention_catch_exception_unhandled)
1461         (print_recreate_catch_exception_unhandled)
1462         (allocate_location_catch_assert, re_set_catch_assert)
1463         (check_status_assert, print_it_catch_assert)
1464         (print_one_catch_assert, print_mention_catch_assert)
1465         (print_recreate_catch_assert)
1466         (allocate_location_catch_handlers, re_set_catch_handlers)
1467         (check_status_handlers, print_it_catch_handlers)
1468         (print_one_catch_handlers, print_mention_catch_handlers)
1469         (print_recreate_catch_handlers): Remove.
1470         (create_ada_exception_catchpoint): Update.
1471         (initialize_ada_catchpoint_ops): Update.
1472
1473 2019-10-02  Tom Tromey  <tromey@adacore.com>
1474
1475         * ada-lang.c (ada_lookup_simple_minsyms): Remove.
1476         (create_excep_cond_exprs): Simplify exception string computation.
1477         (ada_exception_catchpoint_cond_string): Likewise.
1478
1479 2019-10-02  Tom Tromey  <tromey@adacore.com>
1480
1481         * symmisc.c (dump_msymbols): Don't use MSYMBOL_VALUE_ADDRESS.
1482         * ada-lang.c (lesseq_defined_than): Handle
1483         LOC_STATIC.
1484         * dwarf2read.c (dwarf2_per_objfile): Add can_copy
1485         parameter.
1486         (dwarf2_has_info): Likewise.
1487         (new_symbol): Set maybe_copied on symbol when
1488         appropriate.
1489         * dwarf2read.h (dwarf2_per_objfile): Add can_copy
1490         parameter.
1491         <can_copy>: New member.
1492         * elfread.c (record_minimal_symbol): Set maybe_copied
1493         on symbol when appropriate.
1494         (elf_symfile_read): Update call to dwarf2_has_info.
1495         * minsyms.c (lookup_minimal_symbol_linkage): New
1496         function.
1497         * minsyms.h (lookup_minimal_symbol_linkage): Declare.
1498         * symtab.c (get_symbol_address, get_msymbol_address):
1499         New functions.
1500         * symtab.h (get_symbol_address, get_msymbol_address):
1501         Declare.
1502         (SYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_ADDRESS): Handle
1503         maybe_copied.
1504         (struct symbol, struct minimal_symbol) <maybe_copied>:
1505         New member.
1506
1507 2019-10-02  Tom Tromey  <tromey@adacore.com>
1508
1509         * source.c (struct current_source_location): New.
1510         (current_source_key): New global.
1511         (current_source_symtab, current_source_line)
1512         (current_source_pspace): Remove.
1513         (get_source_location): New function.
1514         (get_current_source_symtab_and_line)
1515         (set_default_source_symtab_and_line)
1516         (set_current_source_symtab_and_line)
1517         (clear_current_source_symtab_and_line, select_source_symtab)
1518         (info_source_command, print_source_lines_base)
1519         (info_line_command, search_command_helper, _initialize_source):
1520         Update.
1521
1522 2019-10-02  Tom Tromey  <tromey@adacore.com>
1523
1524         * source.c (select_source_symtab): Don't call
1525         decode_line_with_current_source.
1526
1527 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1528
1529         * symtab.c (lookup_global_symbol): Search global block.
1530
1531 2019-10-02  Tom Tromey  <tromey@adacore.com>
1532
1533         * coffread.c (process_coff_symbol): Update.
1534         * dwarf2read.c (var_decode_location, new_symbol): Update.
1535         * mdebugread.c (parse_symbol): Update.
1536         * objfiles.c (relocate_one_symbol): Update.
1537         * stabsread.c (define_symbol, fix_common_block)
1538         (scan_file_globals): Update.
1539         * symtab.h (SYMBOL_VALUE_ADDRESS): Expand to an rvalue.
1540         (SET_SYMBOL_VALUE_ADDRESS): New macro.
1541         * xcoffread.c (process_xcoff_symbol): Update.
1542
1543 2019-10-02  Andreas Arnez  <arnez@linux.ibm.com>
1544
1545         * MAINTAINERS: Update my email address.
1546
1547 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1548
1549         * dwarf2read.c (struct type_unit_group) <tus>: Convert to
1550         std::vector.
1551         (build_type_psymtabs_reader): Update for std::vector.
1552         (build_type_psymtab_dependencies): Likewise.
1553         * dwarf2read.h: Remove use of DEF_VEC_P.
1554         (typedef sig_type_ptr): Delete.
1555
1556 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1557
1558         * btrace.c (btrace_maint_clear): Update to handle change from VEC
1559         to std::vector.
1560         (btrace_maint_decode_pt): Likewise, and move allocation of the
1561         vector outside of the loop.
1562         (btrace_maint_update_packets): Update to handle change from VEC to
1563         std::vector.
1564         (btrace_maint_print_packets): Likewise.
1565         (maint_info_btrace_cmd): Likewise.
1566         * btrace.h: Remove use of DEF_VEC_O.
1567         (typedef btrace_pt_packet_s): Delete.
1568         (struct btrace_maint_info) <packets>: Change fromm VEC to
1569         std::vector.
1570         * gdbsupport/btrace-common.h: Remove 'vec.h' include.
1571
1572 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1573
1574         * btrace.c (btrace_compute_ftrace_bts): Update for std::vector,
1575         make accesses into the vector constant references.
1576         (btrace_add_pc): Update for std::vector.
1577         (btrace_stitch_bts): Likewise.
1578         (parse_xml_btrace_block): Likewise.
1579         (btrace_maint_update_packets): Likewise.
1580         (btrace_maint_print_packets): Likewise.
1581         (maint_info_btrace_cmd): Likewise.
1582         * gdbsupport/btrace-common.c (btrace_data::fini): Update for
1583         std::vector.
1584         (btrace_data::empty): Likewise.
1585         (btrace_data_append): Likewise.
1586         * gdbsupport/btrace-common.h: Remove use of DEF_VEC_O.
1587         (typedef btrace_block_s): Delete.
1588         (struct btrace_block): Add constructor.
1589         (struct btrace_data_bts) <blocks>: Change to std::vector.
1590         * nat/linux-btrace.c (perf_event_read_bts): Update for
1591         std::vector.
1592         (linux_read_bts): Likewise.
1593
1594 2019-10-01  Tom Tromey  <tom@tromey.com>
1595
1596         * cli/cli-logging.c (show_logging_filename): Use styled_string.
1597
1598 2019-10-01  Tom Tromey  <tom@tromey.com>
1599
1600         * stack.c (print_frame, info_frame_command_core): Use
1601         styled_string.
1602         * linux-thread-db.c (try_thread_db_load_1)
1603         (try_thread_db_load_from_pdir_1): Use styled_string.
1604         * auto-load.c (file_is_auto_load_safe, execute_script_contents)
1605         (auto_load_section_scripts, info_auto_load_local_gdbinit)
1606         (maybe_print_unsupported_script_warning)
1607         (maybe_print_script_not_found_warning): Use styled_string.
1608         * ada-lang.c (user_select_syms): Use styled_string.
1609
1610 2019-10-01  Tom Tromey  <tom@tromey.com>
1611
1612         * p-lang.c (pascal_printstr): Use metadata style.
1613         * value.c (show_convenience): Use metadata style.
1614         * valprint.c (valprint_check_validity, val_print_optimized_out)
1615         (val_print_not_saved, val_print_unavailable)
1616         (val_print_invalid_address, generic_val_print, val_print)
1617         (value_check_printable, val_print_array_elements): Use metadata
1618         style.
1619         * ui-out.h (class ui_out) <field_fmt>: New overload.
1620         <do_field_fmt>: Add style parameter.
1621         * ui-out.c (ui_out::field_fmt): New overload.
1622         * typeprint.c (type_print_unknown_return_type)
1623         (val_print_not_allocated, val_print_not_associated): Use metadata
1624         style.
1625         * tui/tui-out.h (class tui_ui_out) <do_field_fmt>: Add style
1626         parameter.
1627         * tui/tui-out.c (tui_ui_out::do_field_fmt): Update.
1628         * tracepoint.c (tvariables_info_1): Use metadata style.
1629         * stack.c (print_frame_arg, print_frame_info, print_frame)
1630         (info_frame_command_core): Use metadata style.
1631         * skip.c (info_skip_command): Use metadata style.
1632         * rust-lang.c (rust_print_enum): Use metadata style.
1633         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
1634         metadata style.
1635         * python/py-framefilter.c (py_print_single_arg): Use metadata
1636         style.
1637         * printcmd.c (do_one_display, print_variable_and_value): Use
1638         metadata style.
1639         * p-valprint.c (pascal_val_print)
1640         (pascal_object_print_value_fields): Use metadata style.
1641         * p-typeprint.c (pascal_type_print_base): Use metadata style.
1642         * mi/mi-out.h (class mi_ui_out) <do_field_fmt>: Add style
1643         parameter.
1644         * mi/mi-out.c (mi_ui_out::do_field_fmt): Update.
1645         * m2-valprint.c (m2_print_long_set): Use metadata style.
1646         * m2-typeprint.c (m2_print_type): Use metadata style.
1647         * infcmd.c (print_return_value_1): Use metadata style.
1648         * gnu-v3-abi.c (print_one_vtable): Use metadata style.
1649         * f-valprint.c (info_common_command_for_block): Use metadata
1650         style.
1651         * f-typeprint.c (f_type_print_base): Use metadata style.
1652         * expprint.c (print_subexp_standard): Use metadata style.
1653         * cp-valprint.c (cp_print_value_fields): Use metadata style.
1654         * cli/cli-style.h (class cli_style_option): Add constructor.
1655         (metadata_style): Declare.
1656         * cli/cli-style.c (metadata_style): New global.
1657         (_initialize_cli_style): Register metadata style.
1658         * cli-out.h (class cli_ui_out) <do_field_fmt>: Add style
1659         parameter.
1660         * cli-out.c (cli_ui_out::do_field_fmt): Update.
1661         * c-typeprint.c (c_type_print_base_struct_union)
1662         (c_type_print_base_1): Use metadata style.
1663         * breakpoint.c (watchpoint_value_print)
1664         (print_one_breakpoint_location): Use metadata style.
1665         * break-catch-syscall.c (print_one_catch_syscall): Use metadata
1666         style.
1667         * break-catch-sig.c (signal_catchpoint_print_one): Use metadata
1668         style.
1669         * ada-valprint.c (val_print_packed_array_elements, printstr)
1670         (print_field_values, ada_val_print_ref, ada_val_print): Use
1671         metadata style.
1672         * ada-typeprint.c (print_array_type, ada_print_type): Use metadata
1673         style.
1674         * ada-tasks.c (print_ada_task_info, info_task): Use metadata
1675         style.
1676         * ada-lang.c (user_select_syms): Use metadata style.
1677
1678 2019-10-01  Tom Tromey  <tom@tromey.com>
1679
1680         * cli/cli-cmds.c (pwd_command): Style output.
1681
1682 2019-10-01  Pedro Alves  <palves@redhat.com>
1683             Tom Tromey  <tom@tromey.com>
1684
1685         * symtab.c (print_symbol_info): Use %ps.
1686         (print_msymbol_info): Use %ps.
1687         * symfile.c (symbol_file_add_with_addrs): Use %ps.
1688         * printcmd.c (print_variable_and_value): Use %ps.
1689         * macrocmd.c (show_pp_source_pos): Use %ps.
1690         * infrun.c (print_exited_reason): Use ui_out::message.
1691         * breakpoint.c (watchpoint_check, print_one_breakpoint_location)
1692         (describe_other_breakpoints): Use ui_out::message and new
1693         formats.
1694         (say_where): Use new formats.
1695         (bkpt_print_it, tracepoint_print_one_detail): Use ui_out::message
1696         and new formats.
1697
1698 2019-10-01  Pedro Alves  <palves@redhat.com>
1699             Tom Tromey  <tom@tromey.com>
1700
1701         * unittests/format_pieces-selftests.c: Add gdb_format parameter.
1702         (test_gdb_formats): New function.
1703         (run_tests): Call it.
1704         (test_format_specifier): Update.
1705         * utils.h (fputs_filtered): Update comment.
1706         (vfprintf_styled, vfprintf_styled_no_gdbfmt)
1707         (fputs_styled_unfiltered): Declare.
1708         * utils.c (fputs_styled_unfiltered): New function.
1709         (vfprintf_maybe_filtered): Add gdbfmt parameter.
1710         (vfprintf_filtered): Update.
1711         (vfprintf_unfiltered, vprintf_filtered): Update.
1712         (vfprintf_styled, vfprintf_styled_no_gdbfmt): New functions.
1713         * ui-out.h (enum ui_out_flag) <unfiltered_output,
1714         disallow_ui_out_field>: New constants.
1715         (enum class field_kind): New.
1716         (struct base_field_s, struct signed_field_s): New.
1717         (signed_field): New function.
1718         (struct string_field_s): New.
1719         (string_field): New function.
1720         (struct styled_string_s): New.
1721         (styled_string): New function.
1722         (class ui_out) <message>: Add comment.
1723         <vmessage, call_do_message>: New methods.
1724         <do_message>: Add style parameter.
1725         * ui-out.c (ui_out::call_do_message, ui_out::vmessage): New
1726         methods.
1727         (ui_out::message): Rewrite.
1728         * mi/mi-out.h (class mi_ui_out) <do_message>: Add style
1729         parameter.
1730         * mi/mi-out.c (mi_ui_out::do_message): Add style parameter.
1731         * gdbsupport/format.h (class format_pieces) <format_pieces>: Add
1732         gdb_extensions parameter.
1733         (class format_piece): Add parameter to constructor.
1734         (n_int_args): New field.
1735         * gdbsupport/format.c (format_pieces::format_pieces): Add
1736         gdb_extensions parameter.  Handle '*'.
1737         * cli-out.h (class cli_ui_out) <do_message>: Add style parameter.
1738         * cli-out.c (cli_ui_out::do_message): Add style parameter.  Call
1739         vfprintf_styled_no_gdbfmt.
1740         (cli_ui_out::do_field_string, cli_ui_out::do_spaces)
1741         (cli_ui_out::do_text, cli_ui_out::field_separator): Allow
1742         unfiltered output.
1743         * ui-style.h (struct ui_file_style) <ptr>: New method.
1744
1745 2019-10-01  Tom Tromey  <tom@tromey.com>
1746
1747         * unittests/format_pieces-selftests.c: Update.  Add final format.
1748         * gdbsupport/format.c (format_pieces::format_pieces): Don't add
1749         empty literal pieces.
1750
1751 2019-10-01  Tom Tromey  <tom@tromey.com>
1752
1753         * ui-out.h (enum class ui_out_style_kind): Remove.
1754         (class ui_out) <field_string, field_stsream, do_field_string>:
1755         Change type of "style".
1756         * ui-out.c (ui_out::field_core_addr, ui_out::field_stream)
1757         (ui_out::field_string): Update.
1758         * tui/tui-out.h (class tui_ui_out) <do_field_string>: Change type
1759         of "style".
1760         * tui/tui-out.c (tui_ui_out::do_field_string): Update.
1761         * tracepoint.c (print_one_static_tracepoint_marker): Update.
1762         * stack.c (print_frame_arg, print_frame_info, print_frame):
1763         Update.
1764         * source.c (print_source_lines_base): Update.
1765         * solib.c (info_sharedlibrary_command): Update.
1766         * skip.c (info_skip_command): Update.
1767         * record-btrace.c (btrace_call_history_src_line)
1768         (btrace_call_history): Update.
1769         * python/py-framefilter.c (py_print_frame): Update.
1770         * mi/mi-out.h (class mi_ui_out) <do_field_string>: Change type of
1771         "style".
1772         * mi/mi-out.c (mi_ui_out::do_table_header)
1773         (mi_ui_out::do_field_signed, mi_ui_out::do_field_unsigned)
1774         (mi_ui_out::do_field_string): Update.
1775         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
1776         Update.
1777         * cli-out.h (class cli_ui_out) <do_field_string>: Change type of
1778         "style".
1779         * cli-out.c (cli_ui_out::do_table_header)
1780         (cli_ui_out::do_field_signed, cli_ui_out::do_field_unsigned)
1781         (cli_ui_out::do_field_skip, cli_ui_out::do_field_string)
1782         (cli_ui_out::do_field_fmt): Update.
1783         * breakpoint.c (print_breakpoint_location): Update.
1784         (update_static_tracepoint): Update.
1785
1786 2019-10-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1787
1788         * main.c (relocate_gdbinit_path_maybe_in_datadir): Remove std::string
1789         conversion of gdb_datadir.
1790         (captured_main_1): Remove xstrdup when assigning to gdb_datadir,
1791         remove not needed c_str ().
1792
1793 2019-09-30  Ali Tamur <tamur@google.com>
1794
1795         * dwarf2read.c (skip_one_die): Handle DW_FORM_strx forms.
1796         (dwarf2_string_attr): Likewise.
1797
1798 2019-09-30  Ali Tamur <tamur@google.com>
1799
1800         * dwarf2read.c (process_full_comp_unit): Remove whitespace at the EOL.
1801         (process_full_type_unit): Likewise.
1802         (dump_die_shallow): Likewise.
1803         (cu_debug_loc_section): Likewise.
1804
1805 2019-09-28  Christian Biesinger  <cbiesinger@google.com>
1806
1807         * minsyms.c (compare_minimal_symbols): Rename to...
1808         (minimal_symbol_is_less_than): ...this, and adjust to STL
1809         conventions (return bool, take arguments as references)
1810         (minimal_symbol_reader::install): Call std::sort instead
1811         of qsort.
1812
1813 2019-09-29  Christian Biesinger  <cbiesinger@google.com>
1814
1815         * minsyms.h (msymbol_hash): Document that this is a case-insensitive
1816         hash and why.
1817         * objfiles.h (struct objfile_per_bfd_storage) <demangled_names_hash,
1818         msymbol_hash, msymbol_demangled_hash>: Improve comments.
1819
1820 2019-09-30  Simon Marchi  <simon.marchi@polymtl.ca>
1821
1822         * psymtab.c (add_psymbol_to_list): Move comment to psympriv.h.
1823         * psympriv.h (add_psymbol_to_list): Move comment here and update
1824         it.
1825
1826 2019-09-29  Tom de Vries  <tdevries@suse.de>
1827
1828         * contrib/cc-with-tweaks.sh (get_tmpdir): New function.
1829         Use $tmpdir/$(basename "$output_file").dwz instead of
1830         "${output_file}.dwz".
1831
1832 2019-09-28  Simon Marchi  <simon.marchi@polymtl.ca>
1833
1834         PR gdb/25045
1835         * hppa-linux-nat.c: Include gdbarch.h.
1836
1837 2019-09-26  Christian Biesinger  <cbiesinger@google.com>
1838
1839         * blockframe.c (find_pc_partial_function): Change return type to bool.
1840         * elfread.c (elf_gnu_ifunc_resolve_name): Likewise.
1841         * minsyms.c (in_gnu_ifunc_stub): Likewise.
1842         (stub_gnu_ifunc_resolve_name): Likewise.
1843         * symtab.c (compare_filenames_for_search): Likewise.
1844         (compare_glob_filenames_for_search): Likewise.
1845         (matching_obj_sections): Likewise.
1846         (symbol_matches_domain): Likewise.
1847         (find_line_symtab): Change out param EXACT_MATCH to bool *.
1848         (find_line_pc): Change return type to bool.
1849         (find_line_pc_range): Likewise.
1850         (producer_is_realview): Likewise.
1851         * symtab.h (symbol_matches_domain): Likewise.
1852         (find_pc_partial_function): Likewise.
1853         (find_pc_line_pc_range): Likewise.
1854         (in_gnu_ifunc_stub): Likewise.
1855         (struct gnu_ifunc_fns) <gnu_ifunc_resolve_name>: Likewise.
1856         (find_line_pc): Likewise.
1857         (find_line_pc_range): Likewise.
1858         (matching_obj_sections): Likewise.
1859         (find_line_symtab): Change out parameter to bool.
1860         (producer_is_realview): Change return type to bool.
1861         (compare_filenames_for_search): Likewise.
1862         (compare_glob_filenames_for_search): Likewise.
1863
1864 2019-09-26  Tom Tromey  <tom@tromey.com>
1865
1866         * Makefile.in (COMMON_SFILES): Remove gdb_usleep.c.
1867         (HFILES_NO_SRCDIR): Remove gdb_usleep.h.
1868         * gdb_usleep.h: Remove.
1869         * gdb_usleep.c: Remove.
1870         * utils.c: Don't include gdb_usleep.h.
1871
1872 2019-09-26  Tom Tromey  <tromey@adacore.com>
1873
1874         * python/py-type.c (type_to_type_object): Call check_typedef
1875         for stub types.
1876
1877 2019-09-26  Tom Tromey  <tom@tromey.com>
1878
1879         * utils.h (initialize_utils): Don't declare.
1880         * top.c (gdb_init): Don't call initialize_utils.
1881         * utils.c (initialize_utils): Remove.  Move contents...
1882         (_initialize_utils): ... here.
1883
1884 2019-09-25  Tom Tromey  <tom@tromey.com>
1885
1886         * python/py-objfile.c (objfpy_get_build_id): Use bin2hex.
1887         * utils.h (make_hex_string): Don't declare.
1888         * utils.c (make_hex_string): Remove.
1889
1890 2019-09-24  Tom de Vries  <tdevries@suse.de>
1891
1892         PR gdb/23815
1893         * amd64-linux-nat.c (amd64_linux_nat_target::fetch_registers):
1894         Initialize xstateregs before ptrace PTRACE_GETREGSET call.
1895
1896 2019-09-23  Dimitar Dimitrov  <dimitar@dinux.eu>
1897
1898         * NEWS: Mention new simulator port for PRU.
1899
1900 2019-09-23  Christian Biesinger  <cbiesinger@google.com>
1901
1902         * ada-exp.y (write_object_remaining): Update.
1903         * ada-lang.c (ada_decode): Return a std::string instead of a char*
1904         and eliminate the static buffer.
1905         (ada_decode_symbol): Update.
1906         (ada_la_decode): Update.
1907         (ada_sniff_from_mangled_name): Update.
1908         (is_valid_name_for_wild_match): Update.
1909         (ada_lookup_name_info::matches): Update and simplify.
1910         (name_matches_regex): Update.
1911         (ada_add_global_exceptions): Update.
1912         * ada-lang.h (ada_decode): Update signature.
1913         * ada-varobj.c (ada_varobj_describe_simple_array_child): Update.
1914         * dwarf-index-write.c (debug_names::insert): Update.
1915
1916 2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>
1917
1918         * solib-svr4.c (svr4_iterate_over_objfiles_in_search_order): Fix
1919         formatting.
1920
1921 2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>
1922
1923         * breakpoint.h (bp_location) <inserted, permanent, duplicate>:
1924         Change "nonzero" to "true" in documentation.
1925
1926 2019-09-20  Christian Biesinger  <cbiesinger@google.com>
1927
1928         * solib-darwin.c (darwin_lookup_lib_symbol): Remove.
1929         (_initialize_darwin_solib): Don't set
1930         darwin_so_ops.lookup_lib_global_symbol.
1931         * solib-svr4.c (set_solib_svr4_fetch_link_map_offsets): Call
1932         set_gdbarch_iterate_over_objfiles_in_search_order.
1933         (elf_lookup_lib_symbol): Rename to...
1934         (svr4_iterate_over_objfiles_in_search_order): this, and update
1935         to iterate semantics.
1936         (_initialize_svr4_solib): Don't set lookup_lib_global_symbol.
1937         * solib.c (solib_global_lookup): Remove.
1938         * solist.h (struct target_so_ops): Remove lookup_lib_global_symbol.
1939         (solib_global_lookup): Remove.
1940         * symtab.c (lookup_global_or_static_symbol): Remove call to
1941         solib_global_lookup.
1942
1943 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
1944
1945         * NEWS: Move entries about default MI version now being
1946         version 3, and about the GDB/MI fix for multi-location
1947         breakpoints to the "since GDB 8.3" section.
1948
1949 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
1950
1951         GDB 8.3.1 released.
1952
1953 2019-09-20  Ulrich Weigand  <uweigand@de.ibm.com>
1954
1955         * NEWS: Mention that Cell/B.E. debugging support was removed.
1956         * MAINTAINERS: Remove spu target.
1957
1958         * config/djgpp/fnchange.lst: Remove entries for removed files.
1959
1960         * Makefile.in (ALL_TARGET_OBS): Remove solib-spu.o,
1961         spu-multiarch.o, and spu-tdep.o.
1962         (HFILES_NO_SRCDIR): Remove solib-spu.h and spu-tdep.h.
1963         (ALLDEPFILES): Remove solib-spu.c, spu-linux-nat.c,
1964         spu-multiarch.c, and spu-tdep.c.
1965         * spu-linux-nat.c: Remove file.
1966         * spu-multiarch.c: Remove file.
1967         * spu-tdep.c: Remove file.
1968         * spu-tdep.h: Remove file.
1969         * solib-spu.c: Remove file.
1970         * solib-spu.h: Remove file.
1971
1972         * configure.host (powerpc64*-*-linux*): Remove Cell/B.E. support.
1973         * configure.nat (spu-linux): Remove.
1974         * configure.tgt (powerpc*-*-linux*): Remove solib-spu.o and
1975         solib-multiarch.o from gdb_target_obs.
1976         (spu*-*-*): Remove.
1977
1978         * arch/ppc-linux-common.h (struct ppc_linux_features): Remove "cell"
1979         feature flag.
1980         (ppc_linux_no_features): Update.
1981         * arch/ppc-linux-common.c (ppc_linux_match_description): Remove
1982         Cell/B.E. support.
1983         * arch/ppc-linux-tdesc.h (tdesc_powerpc_cell32l): Remove declaration.
1984         (tdesc_powerpc_cell64l): Likewise.
1985         * nat/ppc-linux.h (PPC_FEATURE_CELL): Remove.
1986         * ppc-linux-nat.c (ppc_linux_nat_target::read_description): Remove
1987         Cell/B.E. support.
1988         * ppc-linux-tdep.h: Do not include "solib-spu.h" or "spu-tdep.h".
1989         Do not include "features/rs6000/powerpc-cell32l.c" or
1990         "features/rs6000/powerpc-cell64l.c".
1991         (ppc_linux_spu_section): Remove.
1992         (ppc_linux_core_read_description): Remove Cell/B.E. support.
1993         (spe_context_objfile, spe_context_lm_addr, spe_context_offset,
1994         spe_context_cache_ptid, spe_context_cache_ptid): Remove.
1995         (ppc_linux_spe_context_lookup): Remove.
1996         (ppc_linux_spe_context_inferior_created): Remove.
1997         (ppc_linux_spe_context_solib_loaded): Remove.
1998         (ppc_linux_spe_context_solib_unloaded): Remove.
1999         (ppc_linux_spe_context): Remove.
2000         (struct ppu2spu_cache): Remove.
2001         (ppu2spu_prev_arch, ppu2spu_this_id, ppu2spu_prev_register): Remove.
2002         (struct ppu2spu_data): Remove.
2003         (ppu2spu_unwind_register, ppu2spu_sniffer, ppu2spu_dealloc_cache,
2004         ppu2spu_unwind): Remove.
2005         (ppc_linux_init_abi): Remove Cell/B.E. support.
2006         * rs6000-tdep.h (rs6000_gdbarch_init): Remove Cell/B.E. support.
2007
2008         * features/Makefile (rs6000/powerpc-cell32l-expedite): Remove.
2009         (rs6000/powerpc-cell64l-expedite): Likewise
2010         (WHICH): Remove rs6000/powerpc-cell32l and rs6000/powerpc-cell64l.
2011         (XMLTOC): Remove rs6000/powerpc-cell32l.xml and
2012         rs6000/powerpc-cell64l.xml.
2013         * features/rs6000/powerpc-cell32l.xml: Remove.
2014         * features/rs6000/powerpc-cell64l.xml: Likewise.
2015         * features/rs6000/powerpc-cell32l.c: Remove generated file.
2016         * features/rs6000/powerpc-cell64l.c: Likewise.
2017         * regformats/rs6000/powerpc-cell32l.dat: Remove generated file.
2018         * regformats/rs6000/powerpc-cell64l.dat: Likewise.
2019         * regformats/reg-spu.dat: Remove.
2020
2021         * target.h (enum target_object): Remove TARGET_OBJECT_SPU.
2022         * corelow.c (struct spuid_list): Remove.
2023         (add_to_spuid_list): Remove.
2024         (core_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
2025         * remote.c (PACKET_qXfer_spu_read, PACKET_qXfer_spu_write): Remove.
2026         (remote_protocol_features): Remove associated entries.
2027         (_initialize_remote): No longer initialize them.
2028         (remote_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
2029         * linux-nat.c (SPUFS_MAGIC): Remove.
2030         (linux_proc_xfer_spu): Remove.
2031         (spu_enumerate_spu_ids): Remove.
2032         (linux_nat_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
2033         * linux-tdep.c (-linux_spu_make_corefile_notes): Remove.
2034         (linux_make_corefile_notes): No longer call it.
2035
2036         * regcache.c (cooked_read_test): Remove bfd_arch_spu special case.
2037         (cooked_write_test): Likewise.
2038
2039 2019-09-20  Tom Tromey  <tom@tromey.com>
2040
2041         * NEWS: Mention case-sensitivity of TUI commands.
2042         * tui/tui-win.c (tui_set_focus_command): Now case-sensitive.
2043         (tui_set_win_height_command, parse_scrolling_args): Likewise.
2044         * tui/tui-layout.c (tui_layout_command): Now case-sensitive.
2045
2046 2019-09-20  Tom Tromey  <tom@tromey.com>
2047
2048         * tui/tui-source.c (tui_source_window::set_contents): Use
2049         make_unique_xstrdup.
2050         * tui/tui-disasm.c (tui_disasm_window::set_contents): Use
2051         make_unique_xstrdup.
2052
2053 2019-09-20  Tom Tromey  <tom@tromey.com>
2054
2055         * tui/tui-data.c: Remove separator comments.
2056         * tui/tui-layout.c: Remove separator comments.
2057         * tui/tui-win.c: Remove separator comments.
2058         * tui/tui-wingeneral.c: Remove separator comments.
2059
2060 2019-09-20  Tom Tromey  <tom@tromey.com>
2061
2062         * tui/tui.h (strcat_to_buf): Don't declare.
2063         * tui/tui.c (strcat_to_buf): Remove.
2064
2065 2019-09-20  Tom Tromey  <tom@tromey.com>
2066
2067         * tui/tui-source.h (struct tui_source_window) <m_fullname>: Rename
2068         from "fullname".
2069         * tui/tui-source.c (tui_source_window::set_contents)
2070         (tui_source_window::location_matches_p)
2071         (tui_source_window::maybe_update): Update.
2072
2073 2019-09-20  Tom Tromey  <tom@tromey.com>
2074
2075         * tui/tui-regs.h (struct tui_data_window) <get_current_group>:
2076         Update.
2077         <m_regs_content, m_regs_column_count, m_current_group>: Add "m_"
2078         prefix.
2079         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
2080         (tui_data_window::line_from_reg_element_no)
2081         (tui_data_window::first_reg_element_no_inline)
2082         (tui_data_window::show_registers)
2083         (tui_data_window::show_register_group)
2084         (tui_data_window::display_registers_from)
2085         (tui_data_window::display_registers_from_line)
2086         (tui_data_window::first_data_item_displayed)
2087         (tui_data_window::delete_data_content_windows)
2088         (tui_data_window::erase_data_content)
2089         (tui_data_window::do_scroll_vertical)
2090         (tui_data_window::refresh_window)
2091         (tui_data_window::check_register_values): Update.
2092
2093 2019-09-20  Tom Tromey  <tom@tromey.com>
2094
2095         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN): Remove define.
2096         (struct tui_locator_window) <full_name, proc_name>: Now
2097         std::string.
2098         * tui/tui-stack.c (tui_locator_window::make_status_line)
2099         (tui_locator_window::set_locator_fullname)
2100         (tui_locator_window::set_locator_info): Update.
2101         * tui/tui-source.c (tui_source_window::set_contents)
2102         (tui_source_window::showing_source_p): Update.
2103
2104 2019-09-20  Tom Tromey  <tom@tromey.com>
2105
2106         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
2107         Don't call tui_locator_win_info_ptr.
2108
2109 2019-09-20  Tom Tromey  <tom@tromey.com>
2110
2111         * tui/tui-win.c (tui_resize_all): Don't call refresh.
2112
2113 2019-09-20  Tom Tromey  <tom@tromey.com>
2114
2115         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use 1 as
2116         height for locator.
2117         * tui/tui-stack.c (tui_locator_window::rerender): Call scrollok.
2118         * tui/tui-layout.c (show_source_disasm_command, show_data)
2119         (show_source_or_disasm_and_command): Use 1 as height for locator.
2120
2121 2019-09-20  Tom Tromey  <tom@tromey.com>
2122
2123         * tui/tui.c (tui_enable): Update.
2124         * tui/tui-win.c (tui_sigwinch_handler, tui_async_resize_screen):
2125         Update.
2126         * tui/tui-data.h (tui_win_resized, tui_set_win_resized_to):
2127         Update.
2128         * tui/tui-data.c (win_resized): Now bool.
2129         (tui_win_resized): Return bool.
2130         (tui_set_win_resized_to): Accept a bool.
2131
2132 2019-09-20  Tom Tromey  <tom@tromey.com>
2133
2134         * tui/tui-regs.h (struct tui_data_window) <show_register_group>:
2135         Change type of "refresh_values_only".
2136         * tui/tui-regs.c (tui_data_window::show_register_group): Change
2137         type of "refresh_values_only".
2138
2139 2019-09-20  Tom Tromey  <tom@tromey.com>
2140
2141         * tui/tui-disasm.c (struct tui_asm_line) <addr_string, insn>: Now
2142         std::string.
2143         (tui_disassemble): Add "pos" parameter.
2144         (tui_disasm_window::set_contents): Simplify.
2145
2146 2019-09-20  Tom Tromey  <tom@tromey.com>
2147
2148         * tui/tui-winsource.h (struct tui_source_window_base)
2149         <show_source_content>: Now private.
2150         * tui/tui-winsource.c
2151         (tui_source_window_base::show_source_content): Don't handle empty
2152         content case.
2153
2154 2019-09-20  Tom Tromey  <tom@tromey.com>
2155
2156         * tui/tui-layout.c (show_source_disasm_command)
2157         (show_source_or_disasm_and_command): Don't call
2158         show_source_content.
2159
2160 2019-09-20  Tom Tromey  <tom@tromey.com>
2161
2162         * tui/tui-stack.h (struct tui_locator_window) <make_status_line>:
2163         Declare.
2164         * tui/tui-stack.c (tui_locator_window::make_status_line): Rename
2165         from tui_make_status_line.
2166         (tui_locator_window::rerender): Update.
2167
2168 2019-09-20  Tom Tromey  <tom@tromey.com>
2169
2170         * tui/tui-stack.c (tui_make_status_line): Return std::string.
2171         (tui_locator_window::rerender): Update.
2172
2173 2019-09-20  Tom Tromey  <tom@tromey.com>
2174
2175         * tui/tui-winsource.h (struct tui_source_window_base)
2176         <~tui_source_window_base>: Don't declare.
2177         <fullname>: Remove.
2178         * tui/tui-winsource.c (~tui_source_window_base): Remove.
2179         * tui/tui-source.h (struct tui_source_window) <fullname>: New
2180         member.
2181         * tui/tui-source.c (tui_source_window::set_contents): Update.
2182         (tui_source_window::location_matches_p)
2183         (tui_source_window::maybe_update): Update.
2184
2185 2019-09-20  Tom Tromey  <tom@tromey.com>
2186
2187         * tui/tui-winsource.h (~tui_source_element): Remove.
2188         (tui_source_element): Update.
2189         (struct tui_source_element) <line>: Now a unique_xmalloc_ptr.
2190         * tui/tui-winsource.c (tui_show_source_line): Update.
2191         * tui/tui-source.c (tui_source_window::set_contents): Update.
2192         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
2193
2194 2019-09-20  Tom Tromey  <tom@tromey.com>
2195
2196         * tui/tui-data.h (tui_clear_source_windows_detail): Don't
2197         declare.
2198         * tui/tui-layout.c (tui_add_win_to_layout): Don't call
2199         tui_clear_source_windows_detail.
2200         * tui/tui-winsource.h (struct tui_source_window_base)
2201         <clear_detail>: Don't declare.
2202         * tui/tui-winsource.c (tui_source_window_base::clear_detail):
2203         Remove.
2204         * tui/tui-data.c (tui_clear_source_windows_detail): Remove.
2205
2206 2019-09-20  Tom Tromey  <tromey@adacore.com>
2207
2208         PR ada/24919:
2209         * block.c (contained_in): Fix final return value.
2210
2211 2019-09-20  Alan Modra  <amodra@gmail.com>
2212
2213         * gdb_bfd.c (gdb_bfd_ref, gdb_bfd_unref): Use bfd_set_usrdata.
2214         * dwarf2read.c (dwarf2_read_gdb_index, dwarf2_read_debug_names),
2215         (read_indirect_string_from_dwz): Use bfd accessor.
2216         * dwarf2read.h (struct dwz_file <filename>): Likewise.
2217         * machoread.c (macho_symfile_read_all_oso): Likewise.
2218         * solib.c (solib_bfd_open): Likewise.
2219
2220 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
2221
2222         * eval.c: Move declaration of overload_resolution to...
2223         * value.h: ...here.
2224
2225 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
2226
2227         * arm-linux-nat.c: Remove extern declaration for arm_apcs_32.
2228         * arm-linux-tdep.c: Likewise.
2229         * arm-nbsd-nat.c: Likewise.
2230         * arm-tdep.h: Declare arm_apcs_32.
2231         * arm-tdep.c: Move documentation for arm_apcs_32 to arm-tdep.h.
2232
2233 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
2234
2235         * dwarf2loc.c: Remove extern declaration of dwarf_always_disassemble.
2236         * dwarf2read.h: Declare dwarf_always_disassemble.
2237
2238 2019-09-19  Tom de Vries  <tdevries@suse.de>
2239
2240         PR gdb/25009
2241         * source-cache.c (source_cache::ensure): Catch exception thrown during
2242         construction of the highlighter.
2243
2244 2019-09-18  Alan Modra  <amodra@gmail.com>
2245
2246         * aarch64-linux-tdep.c, * arm-tdep.c, * auto-load.c,
2247         * coff-pe-read.c, * coffread.c, * corelow.c, * dbxread.c,
2248         * dicos-tdep.c, * dwarf2-frame.c, * dwarf2read.c, * elfread.c,
2249         * exec.c, * fbsd-tdep.c, * gcore.c, * gdb_bfd.c, * gdb_bfd.h,
2250         * hppa-tdep.c, * i386-cygwin-tdep.c, * i386-fbsd-tdep.c,
2251         * i386-linux-tdep.c, * jit.c, * linux-tdep.c, * machoread.c,
2252         * maint.c, * mdebugread.c, * minidebug.c, * mips-linux-tdep.c,
2253         * mips-sde-tdep.c, * mips-tdep.c, * mipsread.c, * nto-tdep.c,
2254         * objfiles.c, * objfiles.h, * osabi.c, * ppc-linux-tdep.c,
2255         * ppc64-tdep.c, * record-btrace.c, * record-full.c, * remote.c,
2256         * rs6000-aix-tdep.c, * rs6000-tdep.c, * s390-linux-tdep.c,
2257         * s390-tdep.c, * solib-aix.c, * solib-dsbt.c, * solib-frv.c,
2258         * solib-spu.c, * solib-svr4.c, * solib-target.c,
2259         * spu-linux-nat.c, * spu-tdep.c, * symfile-mem.c, * symfile.c,
2260         * symmisc.c, * symtab.c, * target.c, * windows-nat.c,
2261         * xcoffread.c, * cli/cli-dump.c, * compile/compile-object-load.c,
2262         * mi/mi-interp.c: Update throughout for bfd section macro and
2263         function changes.
2264         * gcore (gcore_create_callback): Use bfd_set_section_lma.
2265         * spu-tdep.c (spu_overlay_new_objfile): Likewise.
2266
2267 2019-09-18  Tom Tromey  <tom@tromey.com>
2268
2269         * NEWS: Add entry.
2270         * tui/tui.c (tui_initialize_readline): Set name of keymap.  Do not
2271         call rl_initialize.
2272         (tui_enable): Do not call rl_initialize.
2273
2274 2019-09-18  Christian Groessler  <chris@groessler.org>
2275
2276         * alpha-linux-nat.c: Include gdbarch.h.
2277
2278 2019-09-18  Simon Marchi  <simon.marchi@polymtl.ca>
2279
2280         * ui-file.c: Include cli/cli-style.h.
2281         (term_cli_styling): Remove cli_styling declaration.
2282
2283 2019-09-18  Alan Modra  <amodra@gmail.com>
2284
2285         * arm-tdep.c (arm_record_special_symbol): Update bfd_get_section
2286         to bfd_asymbol_section.
2287
2288 2019-09-18  Alan Modra  <amodra@gmail.com>
2289
2290         * amd64-dicos-tdep.c (amd64_dicos_osabi_sniffer): Constify target.
2291         * i386-cygwin-tdep.c (i386_cygwin_init_abi): Likewise.
2292         * i386-dicos-tdep.c (i386_dicos_osabi_sniffer): Likewise.
2293
2294 2019-09-18  Alan Modra  <amodra@gmail.com>
2295
2296         * solib-spu.c (spu_bfd_open): Use bfd_set_filename.
2297         * spu-linux-nat.c (spu_bfd_open): Likewise.
2298
2299 2019-09-18  Christian Biesinger  <cbiesinger@google.com>
2300
2301         * dwarf2loc.c: Change extern declaration of dwarf_always_disassemble
2302         to bool to match definition in dwarf2read.c.
2303
2304 2019-09-17  Christian Biesinger  <cbiesinger@google.com>
2305
2306         * ada-lang.c (ada_ignore_descriptive_types_p): Change to bool.
2307         (print_signatures): Likewise.
2308         (trust_pad_over_xvs): Likewise.
2309         * arch/aarch64-insn.c (aarch64_debug): Likewise.
2310         * arch/aarch64-insn.h (aarch64_debug): Likewise.
2311         * arm-linux-nat.c (arm_apcs_32): Likewise.
2312         * arm-linux-tdep.c (arm_apcs_32): Likewise.
2313         * arm-nbsd-nat.c (arm_apcs_32): Likewise.
2314         * arm-tdep.c (arm_debug): Likewise.
2315         (arm_apcs_32): Likewise.
2316         * auto-load.c (debug_auto_load): Likewise.
2317         (auto_load_gdb_scripts): Likewise.
2318         (global_auto_load): Likewise.
2319         (auto_load_local_gdbinit): Likewise.
2320         (auto_load_local_gdbinit_loaded): Likewise.
2321         * auto-load.h (global_auto_load): Likewise.
2322         (auto_load_local_gdbinit): Likewise.
2323         (auto_load_local_gdbinit_loaded): Likewise.
2324         * breakpoint.c (disconnected_dprintf): Likewise.
2325         (breakpoint_proceeded): Likewise.
2326         (automatic_hardware_breakpoints): Likewise.
2327         (always_inserted_mode): Likewise.
2328         (target_exact_watchpoints): Likewise.
2329         (_initialize_breakpoint): Update.
2330         * breakpoint.h (target_exact_watchpoints): Change to bool.
2331         * btrace.c (maint_btrace_pt_skip_pad): Likewise.
2332         * cli/cli-cmds.c (trace_commands): Likewise.
2333         * cli/cli-cmds.h (trace_commands): Likewise.
2334         * cli/cli-decode.c (add_setshow_boolean_cmd): Change int* argument
2335         to bool*.
2336         * cli/cli-logging.c (logging_overwrite): Change to bool.
2337         (logging_redirect): Likewise.
2338         (debug_redirect): Likewise.
2339         * cli/cli-option.h (option_def) <boolean>: Change return type to bool*.
2340         (struct boolean_option_def) <get_var_address_cb_>: Change return type
2341         to bool.
2342         <boolean_option_def>: Update.
2343         (struct flag_option_def): Change default type of Context to bool
2344         from int.
2345         <flag_option_def>: Change return type of var_address_cb_ to bool*.
2346         * cli/cli-setshow.c (do_set_command): Cast to bool* instead of int*.
2347         (get_setshow_command_value_string): Likewise.
2348         * cli/cli-style.c (cli_styling): Change to bool.
2349         (source_styling): Likewise.
2350         * cli/cli-style.h (source_styling): Likewise.
2351         (cli_styling): Likewise.
2352         * cli/cli-utils.h (struct qcs_flags) <quiet, cont, silent>: Change
2353         to bool.
2354         * command.h (var_types): Update comment.
2355         (add_setshow_boolean_cmd): Change int* var argument to bool*.
2356         * compile/compile-cplus-types.c (debug_compile_cplus_types): Change to
2357         bool.
2358         (debug_compile_cplus_scopes): Likewise.
2359         * compile/compile-internal.h (compile_debug): Likewise.
2360         * compile/compile.c (compile_debug): Likewise.
2361         (struct compile_options) <raw>: Likewise.
2362         * cp-support.c (catch_demangler_crashes): Likewise.
2363         * cris-tdep.c (usr_cmd_cris_version_valid): Likewise.
2364         (usr_cmd_cris_dwarf2_cfi): Likewise.
2365         * csky-tdep.c (csky_debug): Likewise.
2366         * darwin-nat.c (enable_mach_exceptions): Likewise.
2367         * dcache.c (dcache_enabled_p): Likewise.
2368         * defs.h (info_verbose): Likewise.
2369         * demangle.c (demangle): Likewise.
2370         (asm_demangle): Likewise.
2371         * dwarf-index-cache.c (debug_index_cache): Likewise.
2372         * dwarf2-frame.c (dwarf2_frame_unwinders_enabled_p): Likewise.
2373         * dwarf2-frame.h (dwarf2_frame_unwinders_enabled_p): Likewise.
2374         * dwarf2read.c (check_physname): Likewise.
2375         (use_deprecated_index_sections): Likewise.
2376         (dwarf_always_disassemble): Likewise.
2377         * eval.c (overload_resolution): Likewise.
2378         * event-top.c (set_editing_cmd_var): Likewise.
2379         (exec_done_display_p): Likewise.
2380         * event-top.h (set_editing_cmd_var): Likewise.
2381         (exec_done_display_p): Likewise.
2382         * exec.c (write_files): Likewise.
2383         * fbsd-nat.c (debug_fbsd_lwp): Likewise
2384         (debug_fbsd_nat): Likewise.
2385         * frame.h (struct frame_print_options) <print_raw_frame_arguments>:
2386         Likewise.
2387         (struct set_backtrace_options) <backtrace_past_main>: Likewise.
2388         <backtrace_past_entry> Likewise.
2389         * gdb-demangle.h (demangle): Likewise.
2390         (asm_demangle): Likewise.
2391         * gdb_bfd.c (bfd_sharing): Likewise.
2392         * gdbcore.h (write_files): Likewise.
2393         * gdbsupport/common-debug.c (show_debug_regs): Likewise.
2394         * gdbsupport/common-debug.h (show_debug_regs): Likewise.
2395         * gdbthread.h (print_thread_events): Likewise.
2396         * gdbtypes.c (opaque_type_resolution): Likewise.
2397         (strict_type_checking): Likewise.
2398         * gnu-nat.c (gnu_debug_flag): Likewise.
2399         * guile/scm-auto-load.c (auto_load_guile_scripts): Likewise.
2400         * guile/scm-param.c (pascm_variable): Add boolval.
2401         (add_setshow_generic): Update.
2402         (pascm_param_value): Update.
2403         (pascm_set_param_value_x): Update.
2404         * hppa-tdep.c (hppa_debug): Change to bool..
2405         * infcall.c (may_call_functions_p): Likewise.
2406         (coerce_float_to_double_p): Likewise.
2407         (unwind_on_signal_p): Likewise.
2408         (unwind_on_terminating_exception_p): Likewise.
2409         * infcmd.c (startup_with_shell): Likewise.
2410         * inferior.c (print_inferior_events): Likewise.
2411         * inferior.h (startup_with_shell): Likewise.
2412         (print_inferior_events): Likewise.
2413         * infrun.c (step_stop_if_no_debug): Likewise.
2414         (detach_fork): Likewise.
2415         (debug_displaced): Likewise.
2416         (disable_randomization): Likewise.
2417         (non_stop): Likewise.
2418         (non_stop_1): Likewise.
2419         (observer_mode): Likewise.
2420         (observer_mode_1): Likewise.
2421         (set_observer_mode): Update.
2422         (sched_multi): Change to bool.
2423         * infrun.h (debug_displaced): Likewise.
2424         (sched_multi): Likewise.
2425         (step_stop_if_no_debug): Likewise.
2426         (non_stop): Likewise.
2427         (disable_randomization): Likewise.
2428         * linux-tdep.c (use_coredump_filter): Likewise.
2429         (dump_excluded_mappings): Likewise.
2430         * linux-thread-db.c (auto_load_thread_db): Likewise.
2431         (check_thread_db_on_load): Likewise.
2432         * main.c (captured_main_1): Update.
2433         * maint-test-options.c (struct test_options_opts) <flag_opt, xx1_opt,
2434         xx2_opt, boolean_opt>: Change to bool.
2435         * maint-test-settings.c (maintenance_test_settings_boolean): Likewise.
2436         * maint.c (maintenance_profile_p): Likewise.
2437         (per_command_time): Likewise.
2438         (per_command_space): Likewise.
2439         (per_command_symtab): Likewise.
2440         * memattr.c (inaccessible_by_default): Likewise.
2441         * mi/mi-main.c (mi_async): Likewise.
2442         (mi_async_1): Likewise.
2443         * mips-tdep.c (mips64_transfers_32bit_regs_p): Likewise.
2444         * nat/fork-inferior.h (startup_with_shell): Likewise.
2445         * nat/linux-namespaces.c (debug_linux_namespaces): Likewise.
2446         * nat/linux-namespaces.h (debug_linux_namespaces): Likewise.
2447         * nios2-tdep.c (nios2_debug): Likewise.
2448         * or1k-tdep.c (or1k_debug): Likewise.
2449         * parse.c (parser_debug): Likewise.
2450         * parser-defs.h (parser_debug): Likewise.
2451         * printcmd.c (print_symbol_filename): Likewise.
2452         * proc-api.c (procfs_trace): Likewise.
2453         * python/py-auto-load.c (auto_load_python_scripts): Likewise.
2454         * python/py-param.c (union parmpy_variable): Add "bool boolval" field.
2455         (set_parameter_value): Update.
2456         (add_setshow_generic): Update.
2457         * python/py-value.c (copy_py_bool_obj): Change argument from int*
2458         to bool*.
2459         * python/python.c (gdbpy_parameter_value): Cast to bool* instead of
2460         int*.
2461         * ravenscar-thread.c (ravenscar_task_support): Change to bool.
2462         * record-btrace.c (record_btrace_target::store_registers): Update.
2463         * record-full.c (record_full_memory_query): Change to bool.
2464         (record_full_stop_at_limit): Likewise.
2465         * record-full.h (record_full_memory_query): Likewise.
2466         * remote-notif.c (notif_debug): Likewise.
2467         * remote-notif.h (notif_debug): Likewise.
2468         * remote.c (use_range_stepping): Likewise.
2469         (interrupt_on_connect): Likewise.
2470         (remote_break): Likewise.
2471         * ser-tcp.c (tcp_auto_retry): Likewise.
2472         * ser-unix.c (serial_hwflow): Likewise.
2473         * skip.c (debug_skip): Likewise.
2474         * solib-aix.c (solib_aix_debug): Likewise.
2475         * spu-tdep.c (spu_stop_on_load_p): Likewise.
2476         (spu_auto_flush_cache_p): Likewise.
2477         * stack.c (struct backtrace_cmd_options) <full, no_filters, hide>:
2478         Likewise.
2479         (struct info_print_options) <quiet>: Likewise.
2480         * symfile-debug.c (debug_symfile): Likewise.
2481         * symfile.c (auto_solib_add): Likewise.
2482         (separate_debug_file_debug): Likewise.
2483         * symfile.h (auto_solib_add): Likewise.
2484         (separate_debug_file_debug): Likewise.
2485         * symtab.c (basenames_may_differ): Likewise.
2486         (struct filename_partial_match_opts) <dirname, basename>: Likewise.
2487         (struct info_print_options) <quiet, exclude_minsyms>: Likewise.
2488         (struct info_types_options) <quiet>: Likewise.
2489         * symtab.h (demangle): Likewise.
2490         (basenames_may_differ): Likewise.
2491         * target-dcache.c (stack_cache_enabled_1): Likewise.
2492         (code_cache_enabled_1): Likewise.
2493         * target.c (trust_readonly): Likewise.
2494         (may_write_registers): Likewise.
2495         (may_write_memory): Likewise.
2496         (may_insert_breakpoints): Likewise.
2497         (may_insert_tracepoints): Likewise.
2498         (may_insert_fast_tracepoints): Likewise.
2499         (may_stop): Likewise.
2500         (auto_connect_native_target): Likewise.
2501         (target_stop_and_wait): Update.
2502         (target_async_permitted): Change to bool.
2503         (target_async_permitted_1): Likewise.
2504         (may_write_registers_1): Likewise.
2505         (may_write_memory_1): Likewise.
2506         (may_insert_breakpoints_1): Likewise.
2507         (may_insert_tracepoints_1): Likewise.
2508         (may_insert_fast_tracepoints_1): Likewise.
2509         (may_stop_1): Likewise.
2510         * target.h (target_async_permitted): Likewise.
2511         (may_write_registers): Likewise.
2512         (may_write_memory): Likewise.
2513         (may_insert_breakpoints): Likewise.
2514         (may_insert_tracepoints): Likewise.
2515         (may_insert_fast_tracepoints): Likewise.
2516         (may_stop): Likewise.
2517         * thread.c (struct info_threads_opts) <show_global_ids>: Likewise.
2518         (make_thread_apply_all_options_def_group): Change argument from int*
2519         to bool*.
2520         (thread_apply_all_command): Update.
2521         (print_thread_events): Change to bool.
2522         * top.c (confirm): Likewise.
2523         (command_editing_p): Likewise.
2524         (history_expansion_p): Likewise.
2525         (write_history_p): Likewise.
2526         (info_verbose): Likewise.
2527         * top.h (confirm): Likewise.
2528         (history_expansion_p): Likewise.
2529         * tracepoint.c (disconnected_tracing): Likewise.
2530         (circular_trace_buffer): Likewise.
2531         * typeprint.c (print_methods): Likewise.
2532         (print_typedefs): Likewise.
2533         * utils.c (debug_timestamp): Likewise.
2534         (sevenbit_strings): Likewise.
2535         (pagination_enabled): Likewise.
2536         * utils.h (sevenbit_strings): Likewise.
2537         (pagination_enabled): Likewise.
2538         * valops.c (overload_resolution): Likewise.
2539         * valprint.h (struct value_print_options) <prettyformat_arrays,
2540         prettyformat_structs, vtblprint, unionprint, addressprint, objectprint,
2541         stop_print_at_null, print_array_indexes, deref_ref, static_field_print,
2542         pascal_static_field_print, raw, summary, symbol_print, finish_print>:
2543         Likewise.
2544         * windows-nat.c (new_console): Likewise.
2545         (cygwin_exceptions): Likewise.
2546         (new_group): Likewise.
2547         (debug_exec): Likewise.
2548         (debug_events): Likewise.
2549         (debug_memory): Likewise.
2550         (debug_exceptions): Likewise.
2551         (useshell): Likewise.
2552         * windows-tdep.c (maint_display_all_tib): Likewise.
2553         * xml-support.c (debug_xml): Likewise.
2554
2555 2019-09-17  Mike Gulick  <mgulick@mathworks.com>
2556
2557         * source.c (prepare_path_for_appending): New function.
2558         (openp): Make use of new function.
2559         (find_and_open_source): Search for the compilation directory and
2560         source file as a relative path beneath the directory search path.
2561
2562 2019-09-17  Andrew Burgess  <andrew.burgess@embecosm.com>
2563
2564         * source-cache.c (source_cache::get_line_charpos): Catch
2565         exceptions and return false, this matches the behaviour documented
2566         in the header file.
2567
2568 2019-09-17  Joel Brobecker  <brobecker@adacore.com>
2569
2570         * ada-tasks.c (info_task): Remove quoting of the task's name.
2571
2572 2019-09-16  Christian Biesinger  <cbiesinger@google.com>
2573
2574         * symfile.c (auto_solib_add): Replace comment with a reference
2575         to the header file.
2576
2577 2019-09-14  Christian Biesinger  <cbiesinger@google.com>
2578
2579         * NEWS: Mention that gdb can now be compiled with Python 3
2580         on Windows.
2581
2582 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2583
2584         * maint.c (maint_print_section_data::maint_print_section_data):
2585         Force use of 'float log10 (float)' by casting the argument to
2586         float.
2587
2588 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2589
2590         * maint.c: Add 'cmath' include.
2591         (struct maint_print_section_data): New structure.
2592         (print_section_index): New function.
2593         (print_bfd_section_info): Add header comment, small whitespace
2594         cleanup, and update to call new print_section_index function.
2595         (print_objfile_section_info): Likewise.
2596         (maint_obj_section_from_bfd_section): New function.
2597         (print_bfd_section_info_maybe_relocated): New function.
2598         (maintenance_info_sections): Add header comment, always use
2599         bfd_map_over_sections instead of ALL_OBJFILE_OSECTIONS.
2600
2601 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2602
2603         * psymtab.c (find_pc_sect_psymtab): Move baseaddr local into more
2604         inner scope, add check that the objfile has psymtabs before
2605         checking psymtabs_addrmap.
2606         * psymtab.h (psymtab_storage) <psymtabs_addrmap>: Extend comment.
2607
2608 2019-09-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2609
2610         * NEWS: Announce that Ada task names are now shown at more places,
2611         and between quotes (except in info task output).
2612         * gdb/ada-tasks.c (task_to_str): New function.
2613         (display_current_task_id): Call task_to_str.
2614         (task_command_1): Likewise.
2615         (print_ada_task_info): In non-mi mode, Properly align headers and data
2616         when task-id length is > 9 (9 is the default for a 32 bits CORE_ADDR).
2617
2618 2019-09-12  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
2619
2620         * procfs.c (procfs_target::wait) <PR_FAULTED>: Get signal from
2621         prstatus.pr_lwp.pr_info instead of making it up.
2622
2623 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
2624
2625         * auto-load.c (auto_load_expand_dir_vars): Update.
2626         * defs.h (gdb_datadir): Change to std::string.
2627         (python_libdir): Likewise.
2628         (relocate_gdb_directory): Change return type to std::string.
2629         * guile/guile.c (gdbscm_data_directory): Update.
2630         (initialize_scheme_side): Update.
2631         * jit.c (jit_reader_dir): Change to std::string.
2632         (jit_reader_load_command): Update.
2633         * main.c (gdb_datadir): Change to std::string.
2634         (python_libdir): Likewise.
2635         (set_gdb_data_directory): Update.
2636         (relocate_path): Change to return std::string.
2637         (relocate_gdb_directory): Change to return std::string.
2638         (relocate_gdbinit_path_maybe_in_datadir): Update.
2639         (captured_main_1): Update.
2640         * python/python.c (do_start_initialization): Update.
2641         * top.c (show_gdb_datadir): Update.
2642         * xml-syscall.c (xml_init_syscalls_info): Update.
2643         (init_syscalls_info): Update.
2644
2645 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
2646
2647         * main.c (relocate_gdbinit_path_maybe_in_datadir): Factor this code
2648         out of get_init_files.
2649         (get_init_files): Update.
2650
2651 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
2652
2653         * main.c (get_init_files): Change to use std::string.
2654         (captured_main_1): Update.
2655         (print_gdb_help): Update.
2656
2657 2019-09-11  Ali Tamur  <tamur@google.com>
2658
2659         *gdb/target-float.c (host_float_ops<T>::to_longest): Update
2660         implementation.
2661
2662 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
2663
2664         * dbxread.c (read_dbx_symtab): Update.
2665         * dwarf2read.c (load_partial_dies): Update.
2666         * mdebugread.c (parse_partial_symbols): Update.
2667         (handle_psymbol_enumerators): Update.
2668         * psympriv.h (add_psymbol_to_list): Change type of copy_names to bool.
2669         * psymtab.c (add_psymbol_to_bcache): Likewise.
2670         (add_psymbol_to_list): Likewise.
2671         * symtab.c (symbol_set_names): Likewise.
2672         * symtab.h (symbol_set_names): Likewise.
2673         * xcoffread.c (scan_xcoff_symtab): Update.
2674
2675 2019-09-11  Tom Tromey  <tom@tromey.com>
2676
2677         * symfile-mem.c (symbol_file_add_from_memory): Use
2678         bfd_set_filename.
2679         * solib-darwin.c (darwin_bfd_open): Use bfd_set_filename.
2680         * solib-aix.c (solib_aix_bfd_open): Use bfd_set_filename.
2681
2682 2019-09-10  Tom Tromey  <tromey@adacore.com>
2683
2684         * dwarf-index-write.c (write_psymbols): Extend error message.
2685         (debug_names::insert): Add Ada code.
2686         (debug_names::write_psymbols): Remove Ada check.
2687         (debug_names) <m_string_obstack>: New member.
2688         * dwarf2read.c (gdb_index_symbol_name_matcher): Remove.
2689         (gdb_index_symbol_name_matcher::matches): Remove.
2690         (mapped_index_base::find_name_components_bounds): Add "lang"
2691         parameter.
2692         (mapped_index_base::build_name_components): Also split names
2693         according to Ada syntax.
2694         (dw2_expand_symtabs_matching_symbol): Loop over languages.  Change
2695         type of "match_callback".
2696         (check_match, check_find_bounds_finds)
2697         (dw2_expand_symtabs_matching): Update.
2698         (dw2_debug_names_iterator): Add new constructor.
2699         (dw2_debug_names_map_matching_symbols): New function.
2700         (dw2_debug_names_expand_symtabs_matching): Update.
2701         (dwarf2_debug_names_functions): Use
2702         dw2_debug_names_map_matching_symbols.
2703
2704 2019-09-10  Tom Tromey  <tromey@adacore.com>
2705
2706         * dwarf2read.c (dw2_get_file_names_reader): Add the
2707         CU's file name to the results.
2708
2709 2019-09-10  Tom Tromey  <tromey@adacore.com>
2710
2711         * ada-lang.c (add_nonlocal_symbols): Combine calls to
2712         map_matching_symbols.  Update.
2713         * dwarf2read.c (dw2_map_matching_symbols): Update.
2714         * psymtab.c (match_partial_symbol): Change type; update.
2715         (psym_map_matching_symbols): Likewise.
2716         * symfile-debug.c (debug_qf_map_matching_symbols): Change
2717         type; update.
2718         * symfile.h (struct quick_symbol_functions)
2719         <map_matching_symbols>: Change "name" to be a lookup_name_info.
2720         Remove "match".
2721
2722 2019-09-10  Tom Tromey  <tromey@adacore.com>
2723
2724         * psymtab.c (map_block): Remove.
2725         (psym_map_matching_symbols): Use iterate_over_symbols_terminated.
2726         * symtab.c (iterate_over_symbols_terminated): New function.
2727         * symtab.c (iterate_over_symbols_terminated): Declare.
2728
2729 2019-09-10  Tom Tromey  <tromey@adacore.com>
2730
2731         * ada-lang.c (ada_iterate_over_symbols): Return bool.
2732         * language.h (struct language_defn) <la_iterate_over_symbols>:
2733         Return bool.
2734         * symtab.c (iterate_over_symbols): Return bool.
2735         * symtab.h (iterate_over_symbols): Return bool.
2736
2737 2019-09-10  Tom Tromey  <tromey@adacore.com>
2738
2739         * ada-lang.c (aux_add_nonlocal_symbols): Change type.
2740         (add_nonlocal_symbols): Update.
2741         * dwarf2read.c (dw2_map_matching_symbols): Change type.
2742         * psymtab.c (map_block, psym_map_matching_symbols): Change type.
2743         * symfile-debug.c (debug_qf_map_matching_symbols): Change type.
2744         * symfile.h (struct quick_symbol_functions) <map_matching_symbols>:
2745         Change type of "callback".  Remove "data".
2746
2747
2748 2019-09-09  Ali Tamur  <tamur@google.com>
2749
2750         * dwarf2read.c (comp_unit_head): Update comment.
2751         (dwarf2_dwo_name): New function declaration.
2752         (dwarf_unit_type_name): New function declaration.
2753         (read_comp_unit_head): Add support for new compilation units,
2754         DW_UT_partial, DW_UT_skeleton, DW_UT_split_compile, DW_UT_split_type.
2755         Particularly, DW_UT_skeleton and DW_UT_split_compile have dwo_id
2756         (currently named as "signature") in their header. Also clarify error
2757         messages.
2758         (lookup_dwo_id): New function. Returns the dwo id of the given
2759         compile unit.
2760         (lookup_dwo_unit): Use the new lookup_dwo_id function.
2761         (init_cutu_and_read_dies): Use the new dwarf2_dwo_name and lookup_dwo_id
2762         functions.
2763         (create_dwo_cu_reader): Use the added lookup_dwo_id function.
2764         (dwarf2_dwo_name): Get the dwo name if present.
2765         (dwarf_unit_type_name): Convert DW_UT_* types to string for diagnostic
2766         purposes.
2767
2768 2019-09-09  Tom Tromey  <tom@tromey.com>
2769
2770         * tui/tui-win.c (tui_all_windows_info): Use ui_out.
2771
2772 2019-09-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2773
2774         * python/python.c (do_start_initialization): Make progname_copy static,
2775         to avoid a leak report.
2776
2777 2019-09-08  Tom Tromey  <tom@tromey.com>
2778
2779         * tui/tui-wingeneral.c (box_win): Truncate long window titles.
2780
2781 2019-09-07  Simon Marchi  <simon.marchi@efficios.com>
2782
2783         * dwarf2read.c (struct dw2_symtab_iterator) <block_index>:
2784         Change type to gdb::optional<block_enum>.
2785         (dw2_symtab_iter_init): Change block_index parameter type
2786         to gdb::optional<block_enum>.
2787         (dw2_lookup_symbol): Change block_index parameter
2788         type to block_enum.c
2789         (dw2_debug_names_lookup_symbol): Likewise.
2790         * psymtab.c (psym_lookup_symbol): Likewise.
2791         * symfile-debug.c (debug_qf_lookup_symbol): Likewise.
2792         * symfile.h (struct quick_symbol_functions) <lookup_symbol>:
2793         Likewise.
2794
2795 2019-09-06  Christian Biesinger  <cbiesinger@google.com>
2796
2797         * defs.h (relocate_gdb_directory): Change int to bool in
2798         signature and rename flag to relocatable.
2799         * main.c (relocate_path): Likewise.
2800         (relocate_gdb_directory): Likewise.
2801
2802 2019-09-06  Alan Modra  <amodra@gmail.com>
2803
2804         * coffread.c (coff_symfile_read): Constify filename variable.
2805         * dbxread.c (dbx_symfile_init, coffstab_build_psymtabs),
2806         (elfstab_build_psymtabs, stabsect_build_psymtabs): Likewise.
2807         * gdb_bfd.c (gdb_bfd_close_or_warn): Likewise.
2808         * solib.c (reload_shared_libraries_1): Likewise.
2809         * symfile.c (reread_symbols): Likewise.
2810         * solib-aix.c (solib_aix_bfd_open): Add cast for xfree of filename.
2811         * solib-darwin.c (darwin_bfd_open): Likewise.
2812         * symfile-mem.c (symbol_file_add_from_memory): Likewise.
2813
2814 2019-09-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2815
2816         * psymtab.c (print_partial_symbols): Handle missing domain_enum
2817         values MODULE_DOMAIN and COMMON_BLOCK_DOMAIN.
2818
2819 2019-09-03  Tom Tromey  <tromey@adacore.com>
2820
2821         * ada-valprint.c (ada_val_print_num): Don't recurse for range
2822         types.
2823         (has_negatives): Unbias a range type bound.
2824         * dwarf2read.c (read_subrange_type): Handle DW_AT_GNU_bias.
2825         * gdbtypes.c (operator==): Handle new field.
2826         (create_range_type): Add "bias" parameter.
2827         (create_static_range_type, resolve_dynamic_range): Update.
2828         * gdbtypes.h (struct range_bounds) <bias>: New member.
2829         (create_range_type): Add bias parameter.
2830         * printcmd.c (print_scalar_formatted): Unbias range types.
2831         * value.c (unpack_long): Unbias range types.
2832         (pack_long): Bias range types.
2833
2834 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
2835
2836         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Check all
2837         probe arguments.
2838
2839 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
2840
2841         * break-catch-throw.c (fetch_probe_arguments): Use gdbarch.
2842         * dtrace-probe.c (dtrace_probe::get_argument_count): Likewise.
2843         * probe.c (probe_safe_evaluate_at_pc) (compute_probe_arg)
2844         (compile_probe_arg): Likewise.
2845         * probe.h (get_argument_count): Likewise.
2846         * solib-svr4.c (solib_event_probe_action): Likewise.
2847         * stap-probe.c (stap_probe::get_argument_count): Likewise.
2848
2849 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
2850
2851         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Move
2852         code to here...
2853         (svr4_create_solib_event_breakpoints): ...from here.
2854
2855 2019-08-30  Sergio Durigan Junior  <sergiodj@redhat.com>
2856
2857         * nat/fork-inferior.c (trace_start_error): Remove "\nError: "
2858         suffix from warning message.
2859
2860 2019-08-30  Tom Tromey  <tom@tromey.com>
2861
2862         * tui/tui-winsource.h (struct tui_source_window_base)
2863         <refresh_all>: Don't declare.
2864         * tui/tui-winsource.c (tui_source_window_base::refresh_all):
2865         Remove.
2866         * tui/tui-win.c (tui_refresh_all_win): Don't call refresh_all or
2867         tui_show_locator_content.
2868         * tui/tui-regs.h (struct tui_data_window) <refresh_all>: Don't
2869         declare.
2870         * tui/tui-regs.c (tui_data_window::refresh_all): Remove.
2871         * tui/tui-data.h (struct tui_win_info) <refresh_all>: Don't
2872         declare.
2873
2874 2019-08-30  Tom Tromey  <tom@tromey.com>
2875
2876         * tui/tui-io.c (tui_cont_sig): Don't call wrefresh.
2877
2878 2019-08-30  Tom Tromey  <tom@tromey.com>
2879
2880         * tui/tui-stack.c (_initialize_tui_stack): Move later.
2881         Remove unnecessary forward declarations.
2882
2883 2019-08-30  Tom Tromey  <tom@tromey.com>
2884
2885         * tui/tui-stack.c (tui_locator_window::set_locator_fullname): Call
2886         rerender.
2887         (tui_update_locator_fullname, tui_show_frame_info): Don't call
2888         tui_show_locator_content.
2889
2890 2019-08-30  Tom Tromey  <tom@tromey.com>
2891
2892         * tui/tui-stack.c (tui_show_locator_content): Move lower.  Rewrite.
2893         (tui_locator_window::rerender): Rewrite using body of previous
2894         tui_show_locator_content.
2895
2896 2019-08-30  Tom Tromey  <tom@tromey.com>
2897
2898         * tui/tui-stack.h (struct tui_locator_window) <set_locator_info,
2899         set_locator_fullname>: New methods.
2900         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
2901         Rename from tui_set_locator_fullname.
2902         (tui_locator_window::set_locator_info): Rename from
2903         tui_set_locator_info.  Return bool.
2904         (tui_update_locator_fullname, tui_show_frame_info): Update.
2905
2906 2019-08-30  Tom Tromey  <tom@tromey.com>
2907
2908         * tui/tui-layout.c (show_layout): Don't call tui_refresh_all.
2909
2910 2019-08-30  Tom Tromey  <tom@tromey.com>
2911
2912         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Don't
2913         call touchwin.
2914
2915 2019-08-30  Tom Tromey  <tom@tromey.com>
2916
2917         * tui/tui-wingeneral.c (box_win): Assume win_info and
2918         win_info->handle cannot be NULL.
2919
2920 2019-08-30  Tom Tromey  <tom@tromey.com>
2921
2922         * tui/tui-regs.h (struct tui_data_item_window) <rerender,
2923         refresh_window>: Declare.
2924         * tui/tui-regs.c (tui_data_window::display_registers_from): Call
2925         resize.
2926         (tui_data_item_window::rerender): Rename from
2927         tui_display_register.
2928         (tui_data_item_window::refresh_window): New method.
2929         * tui/tui-layout.c (tui_gen_win_info::resize): Do nothing on
2930         no-op.
2931
2932 2019-08-30  Tom Tromey  <tom@tromey.com>
2933
2934         * tui/tui-regs.h (struct tui_data_window) <regs_content,
2935         regs_column_count, current_group>: Move later.  Now private.
2936         <get_current_group>: New method.
2937         * tui/tui-regs.c (tui_reg_command): Update.
2938         * tui/tui-layout.c (tui_set_layout): Update.
2939
2940 2019-08-30  Tom Tromey  <tom@tromey.com>
2941
2942         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
2943         (tui_data_window::rerender): Don't call
2944         check_and_display_highlight_if_needed.
2945         (tui_data_window::refresh_all): Remove call to
2946         erase_data_content.
2947
2948 2019-08-30  Tom Tromey  <tom@tromey.com>
2949
2950         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
2951         (tui_data_window::display_registers_from)
2952         (tui_data_window::display_reg_element_at_line)
2953         (tui_data_window::display_registers_from_line): Remove checks of
2954         "empty".
2955
2956 2019-08-30  Tom Tromey  <tom@tromey.com>
2957
2958         * tui/tui-regs.h (struct tui_data_window) <display_all_data>:
2959         Don't declare.
2960         * tui/tui-regs.c (tui_data_window::show_registers): Call
2961         rerender.
2962         (tui_data_window::rerender): Rename from display_all_data.
2963         (tui_data_window::rerender): Remove old implementation.
2964
2965 2019-08-30  Tom Tromey  <tom@tromey.com>
2966
2967         * tui/tui-regs.c (tui_data_window::display_all_data): Change
2968         text.
2969         * tui/tui-data.h (NO_DATA_STRING): Remove define.
2970
2971 2019-08-29  Bernhard Wodok  <barto@gmx.net>
2972             Sergio Durigan Junior  <sergiodj@redhat.com>
2973
2974         PR win32/24284
2975         * mingw-hdep.c (gdb_select): Handle case when 'n' is zero.
2976
2977 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
2978
2979         * symtab.c (search_symbols): Don't include MODULE_DOMAIN symbols
2980         when searching for types.
2981
2982 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
2983
2984         * f-lang.c (f_language_defn): Use f_print_typedef.
2985         * f-lang.h (f_print_typedef): Declare.
2986         * f-typeprint.c (f_print_typedef): Define.
2987
2988 2019-08-27  Christian Biesinger  <cbiesinger@google.com>
2989
2990         * nat/linux-namespaces.c (mnsh_main): Initialize fd (to -1).
2991
2992 2019-08-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2993
2994         * cli/cli-utils.c (info_print_options_defs): Delete.
2995         (make_info_print_options_def_group): Delete.
2996         (extract_info_print_options): Delete.
2997         (info_print_command_completer): Delete.
2998         (info_print_args_help): Add extra parameter, and optionally
2999         include text about -n flag.
3000         * cli/cli-utils.h (struct info_print_options): Delete.
3001         (extract_info_print_options): Delete declaration.
3002         (info_print_command_completer): Delete declaration.
3003         (info_print_args_help): Add extra parameter, extend header
3004         comment.
3005         * python/python.c (gdbpy_rbreak): Pass additional parameter to
3006         search_symbols.
3007         * stack.c (struct info_print_options): New type.
3008         (info_print_options_defs): New file scoped variable.
3009         (make_info_print_options_def_group): New static function.
3010         (info_print_command_completer): New static function.
3011         (info_locals_command): Update to use new local functions.
3012         (info_args_command): Likewise.
3013         (_initialize_stack): Add extra parameter to calls to
3014         info_print_args_help.
3015         * symtab.c (search_symbols): Add extra parameter, use this to
3016         possibly excluse non-debug symbols.
3017         (symtab_symbol_info): Add extra parameter, which is passed on to
3018         search_symbols.
3019         (struct info_print_options): New type.
3020         (info_print_options_defs): New file scoped variable.
3021         (make_info_print_options_def_group): New static function.
3022         (info_print_command_completer): New static function.
3023         (info_variables_command): Update to use local functions, and pass
3024         extra parameter through to symtab_symbol_info.
3025         (info_functions_command): Likewise.
3026         (info_types_command): Pass additional argument through to
3027         symtab_symbol_info.
3028         (rbreak_command): Pass extra argument to search_symbols.
3029         (_initialize_symtab): Add extra arguments for calls to
3030         info_print_args_help, and update help text for 'info variables',
3031         'whereis', and 'info functions' commands.
3032         * symtab.h (search_symbols): Add extra argument to declaration.
3033         * NEWS: Mention new flags.
3034
3035 2019-08-26  Christian Biesinger  <cbiesinger@google.com>
3036
3037         * symtab.c (lookup_static_symbol): Call the new function (and move
3038         it down to be next to lookup_global_symbol).
3039         (struct global_sym_lookup_data): Add block_enum member and rename to...
3040         (struct global_or_static_sym_lookup_data): ...this.
3041         (lookup_symbol_global_iterator_cb): Pass block_index instead of
3042         GLOBAL_BLOCK to lookup_symbol_in_objfile and rename to...
3043         (lookup_symbol_global_or_static_iterator_cb): ...this.
3044         (lookup_global_or_static_symbol): New function.
3045         (lookup_global_symbol): Call new function.
3046
3047 2019-08-26  Tom de Vries  <tdevries@suse.de>
3048
3049         PR c++/24852
3050         * break-catch-throw.c (fetch_probe_arguments): Improve error mesage
3051         when pc_probe.prob == NULL.
3052
3053 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
3054
3055         * dwarf2read.c (dw2_debug_names_iterator::next): Rename local
3056         variable symbol_linkage to symbol_linkage_.
3057
3058 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
3059
3060         * dwarf2read.c (dw2_debug_names_iterator::next): Use enum to
3061         represent whether the symbol is static, dynamic, or we don't
3062         know.
3063
3064 2019-08-25  Yoshinori Sato <ysato@users.sourceforge.jp>
3065
3066         * gdb/rx-tdep.c (rx_register_names): New.
3067         (rx_register_name): Delete.
3068         (rx_psw_type): Delete.
3069         (rx_fpsw_type): Delete.
3070         (rx_register_type): Delete.
3071         (rx_gdbarch_init): Convert target-descriptions.
3072         (_initialize_rx_tdep): Add initialize_tdesc_rx.
3073         * gdb/features/Makefile: Add rx.xml.
3074         * gdb/features/rx.xml: New.
3075         * gdb/features/rx.c: Generated.
3076         * gdb/NEWS: Mention target description support.
3077
3078 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
3079
3080         * symtab.c (symbol_cache_lookup): Always initialize *bsc_ptr and
3081         *slot_ptr.
3082
3083 2019-08-23  Sergio Durigan Junior  <sergiodj@redhat.com>
3084
3085         * configure.ac: Don't check for 'dlfcn.h' (moved to
3086         gdbsupport/common.m4).
3087         * Makefile.in (COMMON_SFILES): Move 'gdb-dlfcn.c' to
3088         'gdbsupport/'.
3089         (HFILES_NO_SRCDIR): Likewise, for 'gdb-dlfcn.h'.
3090         * compile/compile-c-support.c: Include
3091         'gdbsupport/gdb-dlfcn.h'.
3092         * gdbsupport/common.m4: Check for 'dlfcn.h'.
3093         * gdb-dlfcn.c: Move to...
3094         * gdbsupport/gdb-dlfcn.c: ... here.
3095         * gdb-dlfcn.h: Move to...
3096         * gdbsupport/gdb-dlfcn.h: ... here.
3097
3098 2019-08-23  Sandra Loosemore  <sandra@codesourcery.com>
3099
3100         * nios2-tdep.c (struct reg_value): Improve comments.  Make
3101         the offset field signed.
3102
3103 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
3104
3105         * python/lib/gdb/__init__.py (_execute_file): New function.
3106         * python/python.c (python_run_simple_file): Call gdb._execute_file
3107         on Windows.
3108
3109 2019-08-22  Andrew Burgess  <andrew.burgess@embecosm.com>
3110
3111         * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
3112         all uses as this was never set to anything but a zero value.
3113
3114 2019-08-21  Bogdan Harjoc  <harjoc@gmail.com>
3115
3116         * cli/cli-cmds.c (with_command_1): Error out if no arguments.
3117
3118 2019-08-21  Christian Biesinger  <cbiesinger@google.com>
3119
3120         * tui/tui-data.h (tui_gen_win_info): Add an =default
3121         move constructor, required by some GCC versions.
3122
3123 2019-08-21  Jinke Fan  <fanjinke51@yeah.net>
3124
3125         * go32-nat.c (go32_sysinfo): Add hygon_p.
3126
3127 2019-08-20  Tom Tromey  <tom@tromey.com>
3128
3129         * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
3130         line_from_reg_element_no, first_reg_element_no_inline,
3131         display_all_data, delete_data_content_windows,
3132         erase_data_content>: Now private.
3133
3134 2019-08-20  Tom Tromey  <tom@tromey.com>
3135
3136         * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
3137         (tui_unhighlight_win, tui_highlight_win)
3138         (tui_win_info::make_window): Update.
3139         * tui/tui-data.h (HILITE, NO_HILITE): Remove.
3140
3141 2019-08-20  Tom Tromey  <tom@tromey.com>
3142
3143         * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
3144         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
3145         (MAX_PID_WIDTH): Move to tui-stack.c.
3146         * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
3147         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
3148         (MAX_PID_WIDTH): Move from tui-data.h.
3149
3150 2019-08-20  Tom Tromey  <tom@tromey.com>
3151
3152         * tui/tui-wingeneral.h (tui_make_window): Don't declare.
3153         * tui/tui-wingeneral.c (box_win): Change type of win_info.
3154         (box_win): Update.
3155         (tui_gen_win_info::make_window): Rename from tui_make_window.
3156         (tui_win_info::make_window): New method.
3157         (tui_gen_win_info::make_visible): Update.
3158         * tui/tui-source.c (tui_source_window::set_contents): Update.
3159         * tui/tui-regs.c (tui_data_window::show_register_group): Update.
3160         (tui_data_window::display_registers_from): Update.
3161         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
3162         * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
3163         Declare.
3164         <can_box>: Remove.
3165         <title>: Remove.
3166         (struct tui_win_info) <make_window>: Declare.
3167         <can_box>: Now virtual.
3168         <title>: New member.
3169         * tui/tui-data.c (~tui_gen_win_info): Don't free title.
3170         * tui/tui-command.c (tui_cmd_window::resize): Update.
3171
3172 2019-08-20  Tom Tromey  <tom@tromey.com>
3173
3174         * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
3175         * tui/tui-regs.c (tui_data_window::show_registers): Update.
3176         (tui_data_window::check_register_values): Update.
3177
3178 2019-08-20  Tom Tromey  <tom@tromey.com>
3179
3180         * tui/tui-regs.h (struct tui_data_window): Use
3181         DISABLE_COPY_AND_ASSIGN.
3182         <regs_content>: Change type, removing unique_ptr.
3183         <tui_data_window>: Add move constructor.
3184         * tui/tui-regs.c (tui_data_window::show_registers)
3185         (tui_data_window::show_register_group)
3186         (tui_data_window::display_registers_from)
3187         (tui_data_window::display_registers_from)
3188         (tui_data_window::first_data_item_displayed)
3189         (tui_data_window::delete_data_content_windows)
3190         (tui_data_window::rerender, tui_data_window::refresh_window)
3191         (tui_data_window::check_register_values): Update.
3192
3193 2019-08-20  Tom Tromey  <tom@tromey.com>
3194
3195         * tui/tui-regs.h (struct tui_data_window) <show_registers,
3196         show_register_group>: Declare.
3197         (tui_show_register_group): Don't declare.
3198         * tui/tui-regs.c (tui_data_window::show_registers): Rename from
3199         tui_show_registers.
3200         (tui_data_window::show_register_group): Rename from
3201         tui_show_register_group.
3202         (tui_data_window::check_register_values, tui_reg_command):
3203         Update.
3204         * tui/tui-layout.c (tui_set_layout): Update.
3205
3206 2019-08-20  Tom Tromey  <tom@tromey.com>
3207
3208         * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
3209         Declare.
3210         (tui_check_register_values): Don't declare.
3211         * tui/tui-regs.c (tui_data_window::check_register_values): Rename
3212         from tui_check_register_values.
3213         * tui/tui-hooks.c (tui_register_changed): Update.
3214
3215 2019-08-20  Tom Tromey  <tom@tromey.com>
3216
3217         * tui/tui-regs.c (tui_reg_layout): Move later.
3218         (tui_show_registers): Don't enable TUI mode or change layout.
3219
3220 2019-08-20  Tom Tromey  <tom@tromey.com>
3221
3222         * tui/tui-regs.h (struct tui_data_item_window)
3223         <~tui_data_item_window>: Remove.
3224         <content>: Now a unique_xmalloc_ptr.
3225         * tui/tui-regs.c (tui_register_format): Return a
3226         unique_xmalloc_ptr.
3227         (tui_get_register): Update.
3228         (~tui_data_item_window): Remove.
3229         (tui_data_window::display_registers_from, tui_display_register):
3230         Update.
3231         * tui/tui-io.h (tui_expand_tabs): Update.
3232         * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
3233         Remove "col" parameter.
3234
3235 2019-08-20  Tom Tromey  <tom@tromey.com>
3236
3237         * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
3238         field.
3239         * tui/tui-regs.c (~tui_data_item_window): Update.
3240
3241 2019-08-20  Tom Tromey  <tom@tromey.com>
3242
3243         * tui/tui-regs.c (tui_register_format, tui_get_register): Move
3244         earlier.
3245
3246 2019-08-20  Tom Tromey  <tom@tromey.com>
3247
3248         * tui/tui-regs.c (tui_reg_command): Remove NULL check.
3249
3250 2019-08-20  Tom Tromey  <tom@tromey.com>
3251
3252         * tui/tui-source.h (struct tui_source_window): Update.
3253         * tui/tui-regs.c (tui_show_registers): Update.
3254         * tui/tui-disasm.h (struct tui_disasm_window): Update.
3255         * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
3256         (NO_REGS_STRING): Remove defines.
3257
3258 2019-08-20  Conrad Meyer  <cem@FreeBSD.org>
3259
3260         * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
3261         unnecessary thread walk if remote doesn't support the packet.
3262
3263 2019-08-19  Tom Tromey  <tromey@adacore.com>
3264
3265         * python/py-value.c (value_has_field): Fix indentation.
3266
3267 2019-08-19  Tom Tromey  <tromey@adacore.com>
3268
3269         * printcmd.c (do_one_display, info_display_command): Update.
3270         * block.h (contained_in): Return bool.  Add allow_nested
3271         parameter.
3272         * block.c (contained_in): Return bool.  Add allow_nested
3273         parameter.
3274
3275 2019-08-19  Tom Tromey  <tom@tromey.com>
3276
3277         * configure: Rebuild.
3278         * configure.ac: Disallow the combination of -static-libstdc++ and
3279         source highlight.
3280         * source-cache.c (get_language_name): Handle rust.
3281         (source_cache::get_source_lines): Ignore highlighting exceptions.
3282
3283 2019-08-16  Tom Tromey  <tom@tromey.com>
3284
3285         * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
3286         * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
3287         (struct tui_source_window_base) <make_visible, refresh_window,
3288         resize>: Remove methods.
3289         <execution_info>: Remove field.
3290         * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
3291         (tui_show_source_line, tui_source_window_base)
3292         (~tui_source_window_base): Update.
3293         (tui_source_window_base::resize)
3294         (tui_source_window_base::make_visible)
3295         (tui_source_window_base::refresh_window): Remove.
3296         (tui_source_window_base::update_exec_info): Update.
3297         * tui/tui-source.c (tui_source_window::set_contents): Update.
3298         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
3299
3300 2019-08-16  Tom Tromey  <tom@tromey.com>
3301
3302         * tui/tui-hooks.c (tui_remove_hooks): Don't set
3303         deprecated_query_hook.
3304
3305 2019-08-16  Tom Tromey  <tom@tromey.com>
3306
3307         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
3308         (tui_update_source_windows_with_line): Update.
3309         * tui/tui-source.h (struct tui_source_window)
3310         <show_symtab_source>: Declare.
3311         (tui_show_symtab_source): Don't declare.
3312         * tui/tui-source.c (tui_show_symtab_source): Rename from
3313         tui_show_symtab_source.
3314
3315 2019-08-16  Tom Tromey  <tom@tromey.com>
3316
3317         * tui/tui-winsource.h (struct tui_source_window_base)
3318         <set_contents>: Declare.
3319         * tui/tui-winsource.c
3320         (tui_source_window_base::update_source_window_as_is): Update.
3321         * tui/tui-source.h (struct tui_source_window) <set_contents>:
3322         Declare.
3323         (tui_set_source_content): Don't declare.
3324         * tui/tui-source.c (tui_source_window::set_contents): Rename from
3325         tui_set_source_content.
3326         * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
3327         Declare.
3328         (tui_set_disassem_content): Don't declare.
3329         * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
3330         tui_set_disassem_content.
3331
3332 2019-08-16  Tom Tromey  <tom@tromey.com>
3333
3334         * tui/tui-winsource.h (struct tui_source_window_base)
3335         <update_breakpoint_info>: Declare.
3336         (tui_update_breakpoint_info): Don't declare.
3337         * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
3338         (tui_update_all_breakpoint_info): Update.
3339         (tui_source_window_base::update_breakpoint_info): Rename from
3340         tui_update_breakpoint_info.
3341         (tui_source_window_base::update_exec_info): Update.
3342
3343 2019-08-16  Tom Tromey  <tom@tromey.com>
3344
3345         * tui/tui-winsource.h (struct tui_source_window_base)
3346         <update_source_window>: Declare.
3347         (tui_update_source_window): Don't declare.
3348         * tui/tui-winsource.c
3349         (tui_source_window_base::update_source_window): Rename from
3350         tui_update_source_window.
3351         (tui_source_window_base::rerender): Update.
3352         * tui/tui-source.c (tui_source_window::maybe_update): Update.
3353         * tui/tui-disasm.c (tui_show_disassem)
3354         (tui_show_disassem_and_update_source)
3355         (tui_disasm_window::maybe_update): Update.
3356
3357 2019-08-16  Tom Tromey  <tom@tromey.com>
3358
3359         * tui/tui-winsource.h (struct tui_source_window_base)
3360         <update_source_window_as_is>: Declare.
3361         (tui_update_source_window_as_is): Don't declare.
3362         * tui/tui-winsource.c (tui_update_source_window): Update
3363         (tui_source_window_base::update_source_window_as_is): Rename from
3364         tui_update_source_window_as_is.
3365         (tui_source_window_base::refill): Update.
3366         * tui/tui-source.c (tui_show_symtab_source): Update.
3367         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
3368         Update.
3369
3370 2019-08-16  Tom Tromey  <tom@tromey.com>
3371
3372         * tui/tui-winsource.h (tui_update_source_window)
3373         (tui_update_source_window_as_is): Remove "noerror" parameter.
3374         * tui/tui-winsource.c (tui_update_source_window)
3375         (tui_update_source_window_as_is): Remove "noerror" parameter.
3376         (tui_update_source_windows_with_addr)
3377         (tui_update_source_windows_with_line)
3378         (tui_source_window_base::rerender)
3379         (tui_source_window_base::refill): Update.
3380         * tui/tui-source.h (tui_set_source_content)
3381         (tui_show_symtab_source): Remove "noerror" parameter.
3382         * tui/tui-source.c (tui_set_source_content): Remove "noerror"
3383         parameter.
3384         (tui_show_symtab_source): Likewise.
3385         (tui_source_window::maybe_update): Update.
3386         * tui/tui-disasm.c (tui_show_disassem)
3387         (tui_show_disassem_and_update_source)
3388         (tui_disasm_window::do_scroll_vertical)
3389         (tui_disasm_window::maybe_update): Update.
3390
3391 2019-08-16  Tom Tromey  <tom@tromey.com>
3392
3393         * tui/tui.c (tui_is_window_visible): Update.
3394         * tui/tui-wingeneral.c (tui_make_window)
3395         (tui_gen_win_info::make_visible, tui_refresh_all): Update.
3396         * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
3397         (tui_set_focus_command, tui_all_windows_info, update_tab_width)
3398         (tui_set_win_height_command, parse_scrolling_args): Update.
3399         * tui/tui-source.c (tui_source_window::style_changed): Update.
3400         * tui/tui-regs.c (tui_show_registers)
3401         (tui_data_window::first_data_item_displayed)
3402         (tui_data_window::delete_data_content_windows)
3403         (tui_check_register_values, tui_reg_command): Update.
3404         * tui/tui-disasm.c (tui_show_disassem): Update.
3405         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
3406         method.
3407         <is_visible>: Remove field.
3408         * tui/tui-data.c (tui_next_win, tui_prev_win)
3409         (tui_delete_invisible_windows): Update.
3410
3411 2019-08-16  Tom Tromey  <tom@tromey.com>
3412
3413         * tui/tui-winsource.h (struct tui_source_window_base)
3414         <m_has_locator>: Remove.
3415         * tui/tui-layout.c (show_source_disasm_command, show_data)
3416         (show_source_or_disasm_and_command): Update.
3417
3418 2019-08-16  Alan Hayward  <alan.hayward@arm.com>
3419
3420         * NEWS (Other MI changes): New subsection.
3421         * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
3422         (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
3423         * arch-utils.c (default_get_pc_address_flags): New function.
3424         * arch-utils.h (default_get_pc_address_flags): New declaration.
3425         * gdbarch.sh: Add get_pc_address_flags.
3426         * gdbarch.c: Regenerate.
3427         * gdbarch.h: Likewise.
3428         * stack.c (print_pc): New function.
3429         (print_frame_info) (print_frame): Call print_pc.
3430
3431 2019-08-16  Tom de Vries  <tdevries@suse.de>
3432
3433         * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
3434         print_objfile_section_info.
3435
3436 2019-08-15  Tom Tromey  <tom@tromey.com>
3437
3438         * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
3439         calling update_cmdwin_start_line.
3440         * tui/tui-winsource.h (struct tui_source_window_base)
3441         <do_make_visible_with_new_height, set_new_height>: Don't declare.
3442         <rerender>: Declare.
3443         * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
3444         Call rerender.
3445         (tui_source_window_base::set_new_height): Remove.
3446         (tui_source_window_base::rerender): Rename from
3447         do_make_visible_with_new_height.
3448         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
3449         resize method.
3450         (tui_win_info::make_invisible_and_set_new_height)
3451         (tui_win_info::make_visible_with_new_height): Remove.
3452         * tui/tui-stack.h (struct tui_locator_window) <rerender>:
3453         Declare.
3454         * tui/tui-stack.c (tui_locator_window::rerender): New method.
3455         * tui/tui-regs.h (struct tui_data_window) <set_new_height,
3456         do_make_visible_with_new_height>: Don't declare.
3457         <rerender>: Declare.
3458         * tui/tui-regs.c (tui_data_window::rerender): Rename from
3459         set_new_height.
3460         (tui_data_window::do_make_visible_with_new_height): Remove.
3461         * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
3462         call tui_show_locator_content.
3463         (tui_gen_win_info::resize): Call rerender.
3464         (show_source_or_disasm_and_command): Don't call
3465         tui_show_locator_content.
3466         * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
3467         method.
3468         (struct tui_win_info) <rerender>: Declare.
3469         <set_new_height, make_invisible_and_set_new_height,
3470         make_visible_with_new_height>: Don't declare.
3471         * tui/tui-data.c (tui_win_list::rerender): New method.
3472         * tui/tui-command.h (struct tui_cmd_window)
3473         <do_make_visible_with_new_height>: Don't declare.
3474         * tui/tui-command.c
3475         (tui_cmd_window::do_make_visible_with_new_height): Remove.
3476
3477 2019-08-15  Tom Tromey  <tromey@adacore.com>
3478
3479         * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
3480         * ada-lang.c (ada_enum_name): Likewise.
3481
3482 2019-08-15  Christian Biesinger  <cbiesinger@google.com>
3483
3484         * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
3485         leading underscore.
3486         (GdbOutputErrorFile): Likewise.
3487         (global scope): Adjust constructor calls to GdbOutput{,Error}File
3488         accordingly.
3489         (execute_unwinders): Rename to have a leading underscore.
3490         (auto_load_packages): Likewise.
3491         (global scope): Adjust call to auto_load_packages accordingly.
3492         (GdbSetPythonDirectory): Likewise.
3493         * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
3494         instead of execute_unwinders.
3495
3496 2019-08-15  Tom Tromey  <tom@tromey.com>
3497
3498         * tui/tui-layout.c (show_layout, show_source_disasm_command)
3499         (show_data): Don't change window visibility.
3500         (tui_gen_win_info::resize): Remove special case for command
3501         window.  Use wresize, when available.
3502         (show_source_or_disasm_and_command): Don't change window
3503         visibility.
3504         * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
3505         <make_visible>: New method.
3506         * tui/tui-command.c (tui_cmd_window::resize): New method.
3507
3508 2019-08-15  Tom Tromey  <tom@tromey.com>
3509
3510         * tui/tui-winsource.h (struct tui_source_window_iterator): New.
3511         (struct tui_source_windows): New.
3512         * tui/tui-winsource.c (tui_display_main): Update.
3513         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
3514         (new_height_ok, parse_scrolling_args): Update.
3515         * tui/tui-layout.c (show_layout, show_data): Update.
3516         * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
3517         (tui_add_to_source_windows): Don't declare.
3518         * tui/tui-data.c (source_windows, tui_source_windows)
3519         (tui_clear_source_windows, tui_add_to_source_windows): Remove.
3520
3521 2019-08-15  Tom Tromey  <tom@tromey.com>
3522
3523         * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
3524         Rename from reset.
3525         * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
3526         * tui/tui-layout.c (show_source_disasm_command, show_data):
3527         Update.
3528         (tui_gen_win_info::resize): Rename.
3529         (show_source_or_disasm_and_command): Update.
3530         * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
3531         reset.
3532
3533 2019-08-15  Tom Tromey  <tom@tromey.com>
3534
3535         * tui/tui-stack.c (tui_initialize_static_data): Remove.
3536         * tui/tui-interp.c (tui_interp::init): Don't call
3537         tui_initialize_static_data.
3538         * tui/tui-data.h (tui_initialize_static_data): Don't declare.
3539
3540 2019-08-15  Tom Tromey  <tom@tromey.com>
3541
3542         * tui/tui-layout.c (tui_default_win_viewport_height): Don't
3543         examine tui_win_list.
3544
3545 2019-08-15  Tom Tromey  <tom@tromey.com>
3546
3547         * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
3548         * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
3549         tui_clear_source_content.
3550         (tui_clear_source_content): Remove.
3551         (tui_source_window_base::do_erase_source_content): Hoist call to
3552         content.clear().
3553         * tui/tui-stack.c (tui_show_frame_info): Don't call
3554         tui_clear_source_content.
3555
3556 2019-08-15  Tom Tromey  <tom@tromey.com>
3557
3558         * tui/tui-winsource.h (struct tui_source_window_base)
3559         <do_erase_source_content>: New method.
3560         <erase_source_content>: New method.
3561         (tui_erase_source_content): Don't declare.
3562         * tui/tui-winsource.c (tui_clear_source_content): Update.
3563         (tui_source_window_base::do_erase_source_content): Rename from
3564         tui_erase_source_content.
3565         (tui_source_window_base::show_source_content): Update.
3566         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
3567         * tui/tui-source.h (struct tui_source_window)
3568         <erase_source_content>: New method.
3569         * tui/tui-disasm.h (struct tui_disasm_window)
3570         <erase_source_content>: New method.
3571
3572 2019-08-15  Tom Tromey  <tom@tromey.com>
3573
3574         * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
3575         (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
3576         constructor.
3577         * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
3578         * tui/tui-source.c (tui_set_source_content): Update.
3579         * tui/tui-disasm.c (tui_set_disassem_content): Update.
3580
3581 2019-08-15  Tom Tromey  <tom@tromey.com>
3582
3583         * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
3584         * tui/tui-winsource.c (tui_line_is_displayed): Move to
3585         tui-source.c.
3586         * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
3587         Declare.
3588         * tui/tui-source.c (tui_source_window::line_is_displayed): New
3589         method.
3590         (tui_source_window::maybe_update): Update.
3591
3592 2019-08-15  Tom Tromey  <tom@tromey.com>
3593
3594         * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
3595         * tui/tui-winsource.c (tui_addr_is_displayed): Move to
3596         tui-disasm.c.
3597         * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
3598         Declare.
3599         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
3600         method.
3601         (tui_disasm_window::maybe_update): Update.
3602
3603 2019-08-15  Tom Tromey  <tom@tromey.com>
3604
3605         * tui/tui-winsource.h (struct tui_source_window_base)
3606         <maybe_update>: Declare.
3607         * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
3608         method.
3609         * tui/tui-source.h (struct tui_source_window) <maybe_update>:
3610         Declare.
3611         * tui/tui-source.c (tui_source_window::maybe_update): New method.
3612         * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
3613         Declare.
3614         * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
3615
3616 2019-08-15  Tom Tromey  <tom@tromey.com>
3617
3618         * tui/tui-stack.c (tui_make_status_line): Use string constructor.
3619
3620 2019-08-15  Tom Tromey  <tom@tromey.com>
3621
3622         * tui/tui-wingeneral.c: Include tui-stack.h.
3623         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
3624         (struct tui_locator_window): Move from tui-data.h.
3625         * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
3626         (tui_initialize_static_data): Move from tui-data.c.
3627         * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
3628         (struct tui_locator_window): Move to tui-stack.c.
3629         * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
3630         (tui_initialize_static_data): Move to tui-stack.c.
3631
3632 2019-08-15  Tom Tromey  <tom@tromey.com>
3633
3634         * tui/tui-layout.c (show_source_disasm_command)
3635         (show_source_or_disasm_and_command): Use make_visible method, not
3636         tui_make_window.
3637         * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
3638         Remove.
3639
3640 2019-08-15  Tom Tromey  <tom@tromey.com>
3641
3642         * tui/tui-wingeneral.h (tui_make_window): Update.
3643         * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
3644         parameter.
3645         (tui_gen_win_info::make_visible): Update.
3646         * tui/tui-regs.c (tui_data_window::display_registers_from):
3647         Update.
3648         * tui/tui-layout.c (show_source_disasm_command)
3649         (show_source_or_disasm_and_command): Update.
3650         * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
3651         (enum tui_box): Remove.
3652         (struct tui_win_info) <can_box>: New method.
3653         * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
3654         method.
3655
3656 2019-08-15  Tom de Vries  <tdevries@suse.de>
3657
3658         * linux-nat-trad.c: Include gdbarch.h.
3659
3660 2019-08-14  Alan Hayward  <alan.hayward@arm.com>
3661
3662         * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
3663         register sizes.
3664
3665 2019-08-14  Tom Tromey  <tromey@adacore.com>
3666
3667         * darwin-nat.c: Include gdbarch.h.
3668         * darwin-nat-info.c: Include gdbarch.h.
3669
3670 2019-08-13  Tom Tromey  <tom@tromey.com>
3671
3672         * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
3673         Remove.
3674         * tui/tui-data.c (tui_initialize_static_data): Update.
3675
3676 2019-08-13  Tom Tromey  <tom@tromey.com>
3677
3678         * tui/tui-winsource.h (struct tui_exec_info_window)
3679         <~tui_exec_info_window, maybe_allocate_content, get_content,
3680         m_content>: Remove.
3681         (struct tui_source_window_base) <set_exec_info_content,
3682         show_exec_info_content>: Don't declare.
3683         * tui/tui-winsource.c
3684         (tui_exec_info_window::maybe_allocate_content): Remove.
3685         (tui_source_window_base::update_exec_info): Rename from
3686         set_exec_info_content.
3687         (tui_source_window_base::show_exec_info_content)
3688         (tui_source_window_base::update_exec_info): Remove.
3689
3690 2019-08-13  Tom Tromey  <tom@tromey.com>
3691
3692         * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
3693         declare.
3694         * tui/tui-winsource.c (tui_update_source_window_as_is)
3695         (tui_update_source_windows_with_addr, tui_erase_source_content):
3696         Update.
3697         (tui_clear_exec_info_content): Remove.
3698
3699 2019-08-13  Tom Tromey  <tom@tromey.com>
3700
3701         * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
3702         declare.
3703         * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
3704         call tui_erase_exec_info_content.
3705         (tui_clear_exec_info_content): Rename from
3706         tui_erase_exec_info_content.
3707         (tui_clear_exec_info_content): Delete.
3708
3709 2019-08-13  Tom Tromey  <tom@tromey.com>
3710
3711         * tui/tui-winsource.h (struct tui_source_window_base)
3712         <show_exec_info_content>: Declare.
3713         (tui_show_exec_info_content): Don't declare.
3714         * tui/tui-winsource.c
3715         (tui_source_window_base::show_exec_info_content): Rename from
3716         tui_show_exec_info_content.
3717         (tui_source_window_base::update_exec_info): Update.
3718
3719 2019-08-13  Tom Tromey  <tom@tromey.com>
3720
3721         * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
3722         (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
3723         (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
3724         * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
3725         tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
3726         (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
3727         ... here.
3728
3729 2019-08-13  Tom Tromey  <tom@tromey.com>
3730
3731         * tui/tui-winsource.h (struct tui_source_window_base)
3732         <update_exec_info>: Declare.
3733         (tui_update_exec_info): Don't declare.
3734         * tui/tui-winsource.c (tui_update_source_window_as_is)
3735         (tui_source_window_base::refresh_all)
3736         (tui_update_all_breakpoint_info): Update.
3737         (tui_source_window_base::update_exec_info): Rename from
3738         tui_update_exec_info.
3739         * tui/tui-stack.c (tui_show_frame_info): Update.
3740
3741 2019-08-13  Tom Tromey  <tom@tromey.com>
3742
3743         * tui/tui-winsource.h (struct tui_source_window_base)
3744         <set_exec_info_content>: Declare.
3745         (tui_set_exec_info_content): Don't declare.
3746         * tui/tui-winsource.c
3747         (tui_source_window_base::set_exec_info_content): Rename from
3748         tui_set_exec_info_content.
3749         (tui_update_exec_info): Update.
3750
3751 2019-08-13  Tom Tromey  <tom@tromey.com>
3752
3753         * tui/tui-winsource.h (struct tui_source_window_base)
3754         <show_source_content>: Declare.
3755         (tui_show_source_content): Don't declare.
3756         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
3757         (tui_source_window_base::show_source_content): Rename from
3758         tui_show_source_content.
3759         (tui_source_window_base::refresh_all): Update.
3760         * tui/tui-layout.c (show_source_disasm_command)
3761         (show_source_or_disasm_and_command): Update.
3762
3763 2019-08-13  Tom Tromey  <tom@tromey.com>
3764
3765         * tui/tui-winsource.c (tui_erase_source_content)
3766         (tui_show_source_content, tui_source_window_base::refresh_all):
3767         Update.
3768         * tui/tui-wingeneral.h
3769         (tui_check_and_display_highlight_if_needed): Don't declare.
3770         * tui/tui-wingeneral.c
3771         (tui_win_info::check_and_display_highlight_if_needed): Rename from
3772         check_and_display_highlight_if_needed.
3773         * tui/tui-win.c (tui_rehighlight_all)
3774         (tui_win_info::make_visible_with_new_height): Update.
3775         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
3776         (tui_data_window::erase_data_content)
3777         (tui_data_window::display_all_data): Update.
3778         * tui/tui-data.h (struct tui_win_info)
3779         <check_and_display_highlight_if_needed>: Declare.
3780
3781 2019-08-13  Tom Tromey  <tom@tromey.com>
3782
3783         * tui/tui-win.c (tui_resize_all): Call
3784         tui_delete_invisible_windows.
3785         * tui/tui-layout.c (show_layout): Call
3786         tui_delete_invisible_windows.
3787         * tui/tui-data.h (tui_delete_invisible_windows): Declare.
3788         * tui/tui-data.c (tui_delete_invisible_windows): New function.
3789
3790 2019-08-13  Tom Tromey  <tom@tromey.com>
3791
3792         * tui/tui-disasm.c (tui_show_disassem): Add assertion.  Don't call
3793         tui_add_win_to_layout.
3794
3795 2019-08-13  Tom Tromey  <tom@tromey.com>
3796
3797         * tui/tui-layout.h (tui_default_win_height): Don't declare.
3798         * tui/tui-layout.c (tui_default_win_height): Now static.
3799
3800 2019-08-13  Tom Tromey  <tom@tromey.com>
3801
3802         * tui/tui-layout.c (show_layout): Unify all layout cases into a
3803         single switch.
3804         (show_source_disasm_command, show_source_or_disasm_and_command):
3805         Don't check current layout.
3806
3807 2019-08-13  Tom Tromey  <tom@tromey.com>
3808
3809         * tui/tui-wingeneral.c (make_all_visible): Remove.
3810         (tui_make_all_invisible): Simplify.
3811         * tui/tui-layout.c (tui_make_all_invisible): Move from
3812         tui-wingeneral.c; simplify.
3813         (show_layout): Hoist call to tui_make_all_invisible.
3814         (show_data): Don't call tui_make_all_invisible.
3815
3816 2019-08-13  Tom Tromey  <tom@tromey.com>
3817
3818         * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
3819         * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
3820
3821 2019-08-13  Tom Tromey  <tom@tromey.com>
3822
3823         * tui/tui-layout.c (current_layout, tui_current_layout): Move from
3824         tui-data.c.
3825         (show_source_disasm_command, show_data)
3826         (show_source_or_disasm_and_command): Don't use
3827         tui_set_current_layout_to.
3828         * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
3829         * tui/tui-data.c (current_layout, tui_current_layout): Move to
3830         tui-layout.c.
3831         (tui_set_current_layout_to): Remove.
3832
3833 2019-08-13  Tom Tromey  <tom@tromey.com>
3834
3835         * tui/tui-layout.c (tui_set_layout): Update.
3836         * tui/tui-data.h (struct tui_layout_def): Remove.
3837         (tui_layout_def): Don't declare.
3838         * tui/tui-data.c (layout_def): Remove.
3839         (tui_layout_def): Remove.
3840
3841 2019-08-13  Tom Tromey  <tom@tromey.com>
3842
3843         * tui/tui-winsource.h (struct tui_source_window_base)
3844         <clear_detail>: No longer "override".
3845         * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
3846         * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
3847         * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
3848         * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
3849         Remove.
3850         * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
3851
3852 2019-08-13  Tom Tromey  <tromey@adacore.com>
3853
3854         * tracepoint.c: Don't include readline.h or history.h.
3855
3856 2019-08-12  Tom Tromey  <tom@tromey.com>
3857
3858         * configure: Rebuild.
3859         * configure.ac: Check for readline 7.
3860         * NEWS: Mention readline 7 requirement.
3861         * README: Update.
3862
3863 2019-08-12  Tom Tromey  <tom@tromey.com>
3864
3865         * mingw-hdep.c (gdb_select): Remove readline hack.
3866
3867 2019-08-09  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
3868
3869         * blockframe.c (find_pc_partial_function): Set *block to nullptr
3870         when the function fails.
3871
3872 2019-08-09  Andreas Arnez  <arnez@linux.ibm.com>
3873
3874         * s390-tdep.c (s390_type_align): New function.
3875         (s390_gdbarch_init): Set it as type_align gdbarch method.
3876
3877 2019-08-09  Tom de Vries  <tdevries@suse.de>
3878
3879         PR gdb/24591
3880         * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
3881         pc_low with relocation offset.
3882
3883 2019-08-07  Tom Tromey  <tromey@adacore.com>
3884
3885         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
3886         (print_frame_args): Update.
3887         * python/py-framefilter.c (py_print_single_arg, enumerate_args):
3888         Update.
3889         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
3890         * frame.h (struct frame_arg): Add initializers.
3891         <error>: Now a unique_xmalloc_ptr.
3892
3893 2019-08-07  Alan Hayward  <alan.hayward@arm.com>
3894
3895         * NEWS: Expand the Pointer Authentication entry.
3896         * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
3897         (aarch64_frame_unmask_lr): ... to this.
3898         (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
3899         Call aarch64_frame_unmask_lr.
3900         * frame.c (struct frame_info): Add "masked" variable.
3901         (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
3902         (fprint_frame): Check for masked pc.
3903         * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
3904         declarations.
3905         * python/py-framefilter.c (py_print_frame): Check for masked pc.
3906         * stack.c (print_frame): Check for masked pc.
3907
3908 2019-08-06  Tom Tromey  <tom@tromey.com>
3909
3910         * stabsread.c (patch_block_stabs, read_one_struct_field)
3911         (read_enum_type): Use obstack_strndup.
3912         * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
3913         * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
3914         * dwarf2read.c (guess_full_die_structure_name)
3915         (anonymous_struct_prefix): Use obstack_strndup.
3916         * dbxread.c (cp_set_block_scope): Use obstack_strndup.
3917         * c-exp.y (yylex): Use obstack_strndup.
3918         * ada-exp.y (write_object_renaming, write_ambiguous_var)
3919         (write_var_or_type): Use obstack_strndup.
3920
3921 2019-08-06  Tom Tromey  <tom@tromey.com>
3922
3923         * symfile.c (reread_symbols): Use obstack_strdup.
3924         * stabsread.c (read_type): Use obstack_strdup.
3925         * gdb_obstack.h (obstack_strdup): New overload.
3926         * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
3927         (create_dwo_unit_in_dwp_v2, build_error_marker_type)
3928         (dwarf2_canonicalize_name): Use obstack_strdup.
3929         * dbxread.c (read_dbx_symtab): Use obstack_strdup.
3930         * cp-support.c (inspect_type, replace_typedefs_qualified_name):
3931         Use obstack_strdup.
3932
3933 2019-08-06  Tom Tromey  <tom@tromey.com>
3934
3935         * gdb_obstack.h (obstack_strdup): Define.
3936         * gdb_obstack.c (obstack_strdup): Don't define.
3937
3938 2019-08-06  Tom Tromey  <tom@tromey.com>
3939
3940         * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
3941         obstack_strdup.
3942         * typeprint.c (typedef_hash_table::find_global_typedef): Use
3943         obstack_strdup.
3944         * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
3945         * stabsread.c (common_block_start): Use obstack_strdup.
3946         * objfiles.c (set_objfile_main_name, objfile): Use
3947         obstack_strdup.
3948         * namespace.c (add_using_directive): Use obstack_strdup.
3949         * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
3950         * jit.c (finalize_symtab): Use obstack_strdup.
3951         * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
3952         (guess_partial_die_structure_name, partial_die_info::fixup)
3953         (dwarf2_name): Use obstack_strdup.
3954         * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
3955         obstack_strdup.
3956         * c-exp.y (scan_macro_expansion): Use obstack_strdup.
3957         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
3958         obstack_strdup.
3959         * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
3960
3961 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3962
3963         * unittests/help-doc-selftests.c: New file.
3964         * Makefile.in: Add the new file.
3965
3966 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3967
3968         * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
3969         * cli/cli-decode.c (print_doc_line): Likewise.  It now prints
3970         the full first line, except when FOR_VALUE_PREFIX.  In this case,
3971         the trailing '.' is not output, and the first character is uppercased.
3972         (print_help_for_command): Update call to print_doc_line.
3973         (print_doc_of_command): Likewise.
3974         * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
3975         * cli/cli-option.c (append_indented_doc): Do not append newline.
3976         (build_help_option): Append newline after first appended_indented_doc
3977         only if a second call is done.
3978         (build_help): Append 2 new lines before each option, except the first
3979         one.
3980         * compile/compile.c (_initialize_compile): Add new lines after
3981         %OPTIONS%, when not at the end of the help.
3982         Change help doc or code
3983         producing the help doc to respect the invariants.
3984         * maint-test-options.c (_initialize_maint_test_options): Likewise.
3985         Also removed the new line after 'Options:', as all other commands
3986         do not put an empty line between 'Options:' and the first option.
3987         * printcmd.c (_initialize_printcmd): Likewise.
3988         * stack.c (_initialize_stack): Likewise.
3989         * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
3990         incorrectly telling COMMAND is optional.
3991         * ada-lang.c (_initialize_ada_language): Change help doc or code
3992         producing the help doc to respect the invariants.
3993         * ada-tasks.c (_initialize_ada_tasks): Likewise.
3994         * breakpoint.c (_initialize_breakpoint): Likewise.
3995         * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
3996         * cli/cli-logging.c (_initialize_cli_logging): Likewise.
3997         * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
3998         * cli/cli-style.c (cli_style_option::add_setshow_commands,
3999         _initialize_cli_style): Likewise.
4000         * corelow.c (core_target_info): Likewise.
4001         * dwarf-index-cache.c (_initialize_index_cache): Likewise.
4002         * dwarf2read.c (_initialize_dwarf2_read): Likewise.
4003         * filesystem.c (_initialize_filesystem): Likewise.
4004         * frame.c (_initialize_frame): Likewise.
4005         * gnu-nat.c (add_task_commands): Likewise.
4006         * infcall.c (_initialize_infcall): Likewise.
4007         * infcmd.c (_initialize_infcmd): Likewise.
4008         * interps.c (_initialize_interpreter): Likewise.
4009         * language.c (_initialize_language): Likewise.
4010         * linux-fork.c (_initialize_linux_fork): Likewise.
4011         * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
4012         * maint.c (_initialize_maint_cmds): Likewise.
4013         * memattr.c (_initialize_mem): Likewise.
4014         * printcmd.c (_initialize_printcmd): Likewise.
4015         * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
4016         _RegEx): Likewise.
4017         * ravenscar-thread.c (_initialize_ravenscar): Likewise.
4018         * record-btrace.c (_initialize_record_btrace): Likewise.
4019         * record-full.c (_initialize_record_full): Likewise.
4020         * record.c (_initialize_record): Likewise.
4021         * regcache-dump.c (_initialize_regcache_dump): Likewise.
4022         * regcache.c (_initialize_regcache): Likewise.
4023         * remote.c (add_packet_config_cmd, init_remote_threadtests,
4024         _initialize_remote): Likewise.
4025         * ser-tcp.c (_initialize_ser_tcp): Likewise.
4026         * serial.c (_initialize_serial): Likewise.
4027         * skip.c (_initialize_step_skip): Likewise.
4028         * source.c (_initialize_source): Likewise.
4029         * stack.c (_initialize_stack): Likewise.
4030         * symfile.c (_initialize_symfile): Likewise.
4031         * symtab.c (_initialize_symtab): Likewise.
4032         * target-descriptions.c (_initialize_target_descriptions): Likewise.
4033         * top.c (init_main): Likewise.
4034         * tracefile-tfile.c (tfile_target_info): Likewise.
4035         * tracepoint.c (_initialize_tracepoint): Likewise.
4036         * tui/tui-win.c (_initialize_tui_win): Likewise.
4037         * utils.c (add_internal_problem_command): Likewise.
4038         * valprint.c (value_print_option_defs): Likewise.
4039
4040 2019-08-06  Frank Ch. Eigler  <fche@redhat.com>
4041
4042         PR build/24886
4043         * configure.ac: Drop enable-libmcheck support.
4044         * configure, config.in: Rebuild.
4045         * libmcheck.m4: Remove.
4046         * acinclude.m4: Don't include it.
4047         * Makefile.in: Don't distribute it.
4048         * top.c (print_gdb_configuration): Don't mention it.
4049
4050 2019-08-06  Tom Tromey  <tom@tromey.com>
4051
4052         * utils.c (set_output_style): Sometimes pass stream to
4053         emit_style_escape.
4054         * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
4055         * record-btrace.c (btrace_insn_history): Update.
4056         * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
4057         method.
4058         * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
4059         Update initializers.
4060         <m_uiout>: New field.
4061         <m_di>: Move lower.
4062         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
4063         Remove "uiout" parameter.
4064         (dump_insns): Update.
4065         * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
4066         * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
4067
4068 2019-08-06  Christian Biesinger  <cbiesinger@google.com>
4069
4070         * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
4071         (error_in_psymtab_expansion): Likewise.
4072         (lookup_symbol_via_quick_fns): Likewise.
4073         (basic_lookup_transparent_type_quick): Likewise.
4074         (basic_lookup_transparent_type_1): Likewise.
4075
4076 2019-08-06  Tom Tromey  <tromey@adacore.com>
4077
4078         * source.c (last_source_error): Now bool.
4079         (print_source_lines_base): Make "noprint" bool.  Only open
4080         source file when last_source_visited changes.
4081
4082 2019-08-06  Tom Tromey  <tromey@adacore.com>
4083
4084         * annotate.c (annotate_source_line): Use g_source_cache.
4085         * source-cache.c (source_cache::get_plain_source_lines): Change
4086         parameters.  Populate m_offset_cache.
4087         (source_cache::ensure): New method.
4088         (source_cache::get_line_charpos): New method.
4089         (extract_lines): Move lower.  Change parameters.
4090         (source_cache::get_source_lines): Move lower.
4091         * source-cache.h (class source_cache): Update comment.
4092         <get_line_charpos>: New method.
4093         <get_source_lines>: Update comment.
4094         <clear>: Clear m_offset_cache.
4095         <get_plain_source_lines>: Change parameters.
4096         <ensure>: New method
4097         <m_offset_cache>: New member.
4098         * source.c (forget_cached_source_info_for_objfile): Update.
4099         (info_source_command): Use g_source_cache.
4100         (find_source_lines, open_source_file_with_line_charpos): Remove.
4101         (print_source_lines_base, search_command_helper): Use g_source_cache.
4102         * source.h (open_source_file_with_line_charpos): Don't declare.
4103         * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
4104         * tui/tui-source.c (tui_source_window::do_scroll_vertical):
4105         Use g_source_cache.
4106
4107 2019-08-06  Tom Tromey  <tromey@adacore.com>
4108
4109         * source-cache.c (source_cache::get_plain_source_lines):
4110         Remove "first_line" and "last_line" parameters.
4111         (source_cache::get_source_lines): Cache plain text.
4112         * source-cache.h (class source_cache)
4113         <get_plain_source_lines>: Update.
4114
4115 2019-08-06  Tom Tromey  <tromey@adacore.com>
4116
4117         * source-cache.c (extract_lines): No longer a method.
4118         Changed type of parameter.  Include final newline.
4119         (selftests::extract_lines_test): New function.
4120         (_initialize_source_cache): Likewise.
4121         * source-cache.h (class source_cache)
4122         <extract_lines>: Don't declare.
4123
4124 2019-08-06  Tom Tromey  <tromey@adacore.com>
4125
4126         * breakpoint.c (init_breakpoint_sal): Update.
4127         (breakpoint): Update.
4128         * breakpoint.h (struct breakpoint) <filter>: Now a
4129         unique_xmalloc_ptr.
4130
4131 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
4132
4133         * NEWS: Mention dictionary access on blocks.
4134         * python/py-block.c (blpy_getitem): New function.
4135         (block_object_as_mapping): New struct.
4136         (block_object_type): Use new struct for tp_as_mapping field.
4137
4138 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
4139
4140         * objfiles.h (objfile): Add a comment describing partial symbols.
4141
4142 2019-08-05  Tom Tromey  <tromey@adacore.com>
4143
4144         * compile/compile.c (_initialize_compile): Use _(), not N_().
4145         * thread.c (_initialize_thread): Use _(), not N_().
4146         * stack.c (_initialize_stack): Use _(), not N_().
4147         * printcmd.c (_initialize_printcmd): Use _(), not N_().
4148
4149 2019-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
4150
4151         * dwarf2read.c (struct dw2_symtab_iterator):
4152         <want_specific_block>: Remove.
4153         <block_index>: Change type to gdb::optional.
4154         (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
4155         change type of BLOCK_INDEX parameter to gdb::optional.
4156         (dw2_symtab_iter_next): Re-write in function of gdb::optional.
4157         (dw2_lookup_symbol): Don't pass argument for
4158         WANT_SPECIFIC_BLOCK.
4159         (dw2_expand_symtabs_for_function): Don't pass argument for
4160         WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
4161         (class dw2_debug_names_iterator)
4162         <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
4163         parameter, change BLOCK_INDEX type to gdb::optional.
4164         <m_want_specific_block>: Remove.
4165         <m_block_index>: Change type to gdb::optional.
4166         (dw2_debug_names_iterator::next): Change type of IS_STATIC to
4167         gdb::optional.  Re-write in function of gdb::optional.
4168         (dw2_debug_names_lookup_symbol): Don't pass argument for
4169         WANT_SPECIFIC_BLOCK.
4170         (dw2_debug_names_expand_symtabs_for_function): Don't pass
4171         argument for WANT_SPECIFIC_BLOCK, pass empty optional for
4172         BLOCK_INDEX.
4173
4174 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4175
4176         * NEWS: Mention changes to "info sources" command.
4177
4178 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4179
4180         * symtab.c (filename_partial_match_opts): New struct type.
4181         (struct output_source_filename_data): New members
4182         regexp, c_regexp, partial_match.
4183         (output_source_filename): Use new members to decide to print file.
4184         (info_sources_option_defs): New variable.
4185         (make_info_sources_options_def_group, print_info_sources_header,
4186         info_sources_command_completer):
4187         New functions.
4188         (info_sources_command): Read new optional arguments.
4189         (_initialize_symtab): Update info sources help.
4190
4191 2019-08-02  Alexandre Oliva <oliva@adacore.com>
4192
4193         * ada-lang.c (exception_support_info_v0): Renamed from...
4194         (default_exception_support_info): ... this.  Create new
4195         definition for v1.
4196         (ada_has_this_exception_support): Look up catch_handlers_sym.
4197         (ada_exception_support_info_sniffer): Try v0 after default.
4198
4199 2019-08-01  Tom Tromey  <tromey@adacore.com>
4200
4201         * ia64-libunwind-tdep.h (struct libunwind_descr): Include
4202         gdbarch.h.
4203
4204 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
4205
4206         * s12z-tdep.c: Fix include path for s12z-opc.h.
4207
4208 2019-08-01  Alan Hayward  <alan.hayward@arm.com>
4209
4210         * NEWS: Require GNU make 3.82.
4211
4212 2019-07-16  Tom Tromey  <tom@tromey.com>
4213
4214         * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
4215         declare.
4216
4217 2019-07-30  Tom Tromey  <tromey@adacore.com>
4218
4219         * block.c (contained_in): Remove BLOCK_FUNCTION check.
4220
4221 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
4222
4223         * printcmd.c (print_address_symbolic): Print negative offsets.
4224         (build_address_symbolic): Force signed arithmetic when computing
4225         offset.
4226
4227 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
4228
4229         PR/24474: Add a function to lookup static variables.
4230         * NEWS: Mention this new function.
4231         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
4232         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
4233         * python/python.c (python_GdbMethods): Add new function.
4234
4235 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
4236
4237         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
4238         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
4239         (objfpy_lookup_static_symbol): New function.
4240         (objfile_object_methods): Add new functions.
4241
4242 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4243
4244         * NEWS: Mention 'set|show print frame-info'.  Mention new
4245         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
4246         backtrace argument.  Mention that python frame filtering code
4247         is now consistent with what 'backtrace' command prints.
4248
4249 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4250
4251         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
4252         comments.
4253         (print_frame_info_auto, print_frame_info_source_line,
4254         print_frame_info_location, print_frame_info_source_and_location,
4255         print_frame_info_location_and_address, print_frame_info_short_location):
4256         New declarations.
4257         (struct frame_print_options): New member print_frame_info.
4258         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
4259         * stack.h (get_user_print_what_frame_info): New declaration.
4260         (frame_show_address): New declaration.
4261         * stack.c (print_frame_arguments_choices): New value 'presence'.
4262         (print_frame_info_auto, print_frame_info_source_line,
4263         print_frame_info_location, print_frame_info_source_and_location,
4264         print_frame_info_location_and_address, print_frame_info_short_location,
4265         print_frame_info_choices, print_frame_info_print_what): New definitions.
4266         (print_frame_args): Only print dots for args if print frame-arguments
4267         is 'presence'.
4268         (frame_print_option_defs): New element for "frame-info".
4269         (get_user_print_what_frame_info): New function.
4270         (frame_show_address): Make non static.  Move comment to stack.h.
4271         (print_frame_info_to_print_what): New function.
4272         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
4273         to decide what to print.
4274         (backtrace_command_1): Handle the new print_frame_arguments_presence
4275         value.
4276         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
4277         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
4278         (py_print_frame): In non-mi mode, use LOCATION as default for
4279         print_what, similarly to frame information printed directly by
4280         backtrace command. Handle frame-info user option in non MI mode.
4281
4282 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
4283
4284         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
4285         Add case for debugging 32-bit target on 64-bit host.  Revise
4286         comment.
4287
4288 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
4289
4290         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
4291         instead of find_function_entry_range_from_pc.
4292
4293 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
4294
4295         * stack.c (find_frame_funname): Remove code which preferred
4296         minsym over symtab sym in "certain pathological cases".
4297
4298         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
4299         parameter.  Change type of "do_demangle" to bool.
4300         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
4301         Pass suitable "prefer_sym_over_minsym" flag to
4302         build_address_symbolic().  Don't output "+" for negative offsets.
4303         * printcmd.c (print_address_symbolic): Update invocation of
4304         build_address_symbolic to include a "prefer_sym_over_minsym"
4305         flag.
4306         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
4307         Restrict cases in which use of minimal symbol is preferred to that
4308         of a found symbol.  Update comments.
4309
4310         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
4311         for entry pc when entry pc is out of range for that FDE.
4312
4313 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
4314
4315         PR gdb/24839:
4316         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
4317         type.
4318
4319 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
4320
4321         * python/py-objfile.c (add_separate_debug_file): Fix comment about
4322         this function's Python signature.
4323
4324
4325 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
4326
4327         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
4328         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
4329         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
4330         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
4331         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
4332
4333
4334 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
4335
4336         * h8300-tdep.c (h8300_register_name_common): New.
4337         h8300_register_name): Use h8300_register_name_common.
4338         (h8300s_register_name): Likewise.
4339         (h8300sx_register_name): Likewise.
4340         (h8300h_register_nam): New.
4341         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
4342
4343
4344 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
4345
4346         * arm-tdep.c (arm_skip_cmse_entry): New function.
4347         (arm_is_sgstubs_section): New function.
4348         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
4349
4350 2019-07-22  Tom Tromey  <tom@tromey.com>
4351
4352         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
4353         Don't self-assign.
4354
4355 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
4356
4357         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
4358         type_print.
4359
4360 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
4361
4362         * symtab.c (search_symbols): Adjust msymbol matching type arrays
4363         so that GDB doesn't match any msymbols when searching in the
4364         TYPES_DOMAIN.
4365         (print_symbol_info): Print using typedef_print or type_print based
4366         on the type of the symbol.  Add updated FIXME comment moved from...
4367         (_initialize_symtab): ... move and update FIXME comment to above.
4368
4369 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
4370
4371         * NEWS: Mention adding -q option to "info types".
4372         * symtab.c (struct info_types_options): New struct.
4373         (info_types_options_defs): New variable.
4374         (make_info_types_options_def_group): New function.
4375         (info_types_command): Use gdb::option framework to parse options.
4376         (info_types_command_completer): New function.
4377         (_initialize_symtab): Extend the help text on "info types" and
4378         register command completer.
4379
4380 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
4381
4382         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
4383         (lookup_symbol_in_objfile): Change int to block_enum and add a
4384         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
4385
4386 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
4387
4388         * MAINTAINERS (Write After Approval): Add self.
4389
4390 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
4391
4392         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
4393         instruction to the dummy code region.
4394
4395 2019-07-19  Tom Tromey  <tromey@adacore.com>
4396
4397         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
4398         (ARGSUSED, PARAMS, __func__): Remove rules.
4399
4400 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
4401
4402         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
4403         * features/arm/arm-with-iwmmxt.c: Remove.
4404         * features/arm/arm-with-iwmmxt.xml: Remove.
4405         * features/arm/arm-with-m-fpa-layout.c: Remove.
4406         * features/arm/arm-with-m-fpa-layout.xml: Remove.
4407         * features/arm/arm-with-m-vfp-d16.c: Remove.
4408         * features/arm/arm-with-m-vfp-d16.xml: Remove.
4409         * features/arm/arm-with-m.c: Remove.
4410         * features/arm/arm-with-m.xml: Remove.
4411         * features/arm/arm-with-neon.c: Remove.
4412         * features/arm/arm-with-neon.xml: Remove.
4413         * features/arm/arm-with-vfpv2.c: Remove.
4414         * features/arm/arm-with-vfpv2.xml: Remove.
4415         * features/arm/arm-with-vfpv3.c: Remove.
4416         * features/arm/arm-with-vfpv3.xml: Remove.
4417
4418 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
4419
4420         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
4421
4422 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
4423
4424         * arch/aarch32.c (aarch32_create_target_description): Create
4425         target descriptions using features.
4426         * arch/arm.c (arm_create_target_description)
4427         (arm_create_mprofile_target_description): Likewise.
4428         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
4429
4430 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
4431
4432         * Makefile.in: Add new files.
4433         * aarch32-tdep.c: New file.
4434         * aarch32-tdep.h: New file.
4435         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
4436         Call aarch32_read_description.
4437         * arch/aarch32.c: New file.
4438         * arch/aarch32.h: New file.
4439         * arch/arm.c (arm_create_target_description)
4440         (arm_create_mprofile_target_description): New function.
4441         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
4442         (arm_create_target_description)
4443         (arm_create_mprofile_target_description): New declaration.
4444         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
4445         read_description functions.
4446         * arm-linux-nat.c (arm_linux_nat_target::read_description):
4447         Likewise.
4448         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
4449         * arm-tdep.c (tdesc_arm_list): New variable.
4450         (arm_register_g_packet_guesses): Call create description functions.
4451         (arm_read_description) (arm_read_mprofile_description): New
4452         function.
4453         * arm-tdep.h (arm_read_description)
4454         (arm_read_mprofile_description): Add declaration.
4455         * configure.tgt: Add new files.
4456
4457 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
4458
4459         * top.c (new_ui_command): Open specified terminal just once.
4460
4461 2019-07-18  Tom Tromey  <tromey@adacore.com>
4462
4463         * symtab.c (main_name): Constify return type.
4464         * symfile.c (set_initial_language): Update.
4465         * symtab.h (main_name): Constify return type.
4466
4467 2019-07-17  Tom Tromey  <tom@tromey.com>
4468
4469         * tui/tui-winsource.c (tui_update_source_window)
4470         (tui_update_source_window_as_is)
4471         (tui_update_source_windows_with_line): Remove return.
4472         * tui/tui-disasm.c (tui_show_disassem)
4473         (tui_show_disassem_and_update_source): Remove return.
4474         * tui/tui.c (tui_reset): Remove return.
4475         * tui/tui-wingeneral.c
4476         (tui_check_and_display_highlight_if_needed): Remove return.
4477
4478 2019-07-17  Tom Tromey  <tom@tromey.com>
4479
4480         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
4481
4482 2019-07-17  Tom Tromey  <tom@tromey.com>
4483
4484         * tui/tui-winsource.h (struct tui_exec_info_window)
4485         (struct tui_source_window_base): Move from tui-data.h.
4486         * tui/tui-winsource.c: Move many method definitions from
4487         elsewhere.  Remove "structuring" comments.
4488         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
4489         (tui_source_window_base::refresh_window): Move to
4490         tui-winsource.c.
4491         * tui/tui-win.c (tui_source_window_base::refresh_all)
4492         (tui_source_window_base::update_tab_width)
4493         (tui_source_window_base::set_new_height)
4494         (tui_source_window_base::do_make_visible_with_new_height): Move to
4495         tui-winsource.c.
4496         * tui/tui-source.h: Update.
4497         * tui/tui-source.c (tui_source_window_base::reset): Move to
4498         tui-winsource.c.
4499         * tui/tui-disasm.h: Update.
4500         * tui/tui-data.h (struct tui_exec_info_window): Move to
4501         tui-winsource.h.
4502         (struct tui_source_window_base): Likewise.
4503         * tui/tui-data.c (tui_source_window_base::clear_detail)
4504         (tui_source_window_base, ~tui_source_window_base): Move to
4505         tui-winsource.c.
4506
4507 2019-07-17  Tom Tromey  <tom@tromey.com>
4508
4509         * tui/tui-win.c (tui_resize_all)
4510         (tui_source_window_base::update_tab_width)
4511         (tui_adjust_win_heights): Update.
4512         (tui_win_info::make_invisible_and_set_new_height): Rename from
4513         make_invisible_and_set_new_height.
4514         * tui/tui-data.h (struct tui_win_info)
4515         <make_invisible_and_set_new_height>: New method.
4516
4517 2019-07-17  Tom Tromey  <tom@tromey.com>
4518
4519         * tui/tui.c: Update.
4520         * tui/tui-source.h (struct tui_source_window): Move from
4521         tui-data.h.
4522         * tui/tui-layout.c: Update.
4523         * tui/tui-disasm.c: Update.
4524         * tui/tui-data.h (struct tui_source_window): Move to
4525         tui-source.h.
4526
4527 2019-07-17  Tom Tromey  <tom@tromey.com>
4528
4529         * tui/tui-disasm.h (struct tui_disasm_window): Move from
4530         tui-data.h.
4531         * tui/tui-data.h (struct tui_disasm_window): Move to
4532         tui-disasm.h.
4533
4534 2019-07-17  Tom Tromey  <tom@tromey.com>
4535
4536         * tui/tui-regs.h (struct tui_data_item_window): Move from
4537         tui-data.h.
4538         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
4539         * tui/tui-data.h (struct tui_data_item_window): Move to
4540         tui-regs.h.
4541         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
4542
4543 2019-07-17  Tom Tromey  <tom@tromey.com>
4544
4545         * tui/tui.c: Update.
4546         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
4547         (tui_cmd_window::max_height): Move to tui-command.c.
4548         * tui/tui-layout.c: Update.
4549         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
4550         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
4551         tui-command.c.
4552         * tui/tui-command.h (struct tui_cmd_window): Move from
4553         tui-data.h.
4554         * tui/tui-command.c: Remove "structuring" comments.
4555         (tui_cmd_window::clear_detail)
4556         (tui_cmd_window::do_make_visible_with_new_height)
4557         (tui_cmd_window::max_height): Move from elsewhere.
4558
4559 2019-07-17  Tom Tromey  <tom@tromey.com>
4560
4561         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
4562         Now static.
4563         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
4564         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
4565
4566 2019-07-17  Tom Tromey  <tom@tromey.com>
4567
4568         * tui/tui.c: Update.
4569         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
4570         tui-regs.c.
4571         * tui/tui-windata.h: Remove file.
4572         * tui/tui-windata.c: Remove file.
4573         * tui/tui-win.c (tui_data_window::set_new_height)
4574         (tui_data_window::do_make_visible_with_new_height): Move to
4575         tui-regs.c.
4576         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
4577         * tui/tui-regs.c: Remove "structuring" comments.
4578         (tui_data_window::first_data_item_displayed)
4579         (tui_data_window::delete_data_content_windows)
4580         (tui_data_window::erase_data_content)
4581         (tui_data_window::display_all_data)
4582         (tui_data_window::refresh_all)
4583         (tui_data_window::do_scroll_vertical)
4584         (tui_data_window::clear_detail, tui_data_window::set_new_height)
4585         (tui_data_window::do_make_visible_with_new_height)
4586         (tui_data_window::refresh_window): Move from elsewhere.
4587         (_initialize_tui_regs): Move to end of file.
4588         * tui/tui-layout.c: Update.
4589         * tui/tui-hooks.c: Update.
4590         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
4591         * tui/tui-data.c (tui_data_window::clear_detail): Move to
4592         tui-regs.c.
4593         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
4594
4595 2019-07-17  Tom Tromey  <tom@tromey.com>
4596
4597         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
4598         seen.
4599
4600 2019-07-17  Tom Tromey  <tom@tromey.com>
4601
4602         * tui/tui-win.c (tui_source_window_base::set_new_height)
4603         (tui_source_window_base::do_make_visible_with_new_height): Use
4604         m_has_locator field directly.
4605         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
4606         method.
4607         (struct tui_source_window_base) <has_locator>: Likewise.
4608
4609 2019-07-17  Tom Tromey  <tom@tromey.com>
4610
4611         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
4612         Don't declare.
4613         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
4614         Remove.
4615         * tui/tui-win.c (tui_source_window_base::set_new_height)
4616         (tui_source_window_base::set_new_height)
4617         (make_invisible_and_set_new_height)
4618         (tui_source_window_base::do_make_visible_with_new_height)
4619         (tui_source_window_base::do_make_visible_with_new_height):
4620         Update.
4621         * tui/tui-layout.c (show_source_disasm_command, show_data)
4622         (show_source_or_disasm_and_command): Update.
4623         * tui/tui-layout.c (show_layout): Update.
4624
4625 2019-07-17  Tom Tromey  <tom@tromey.com>
4626
4627         * tui/tui-layout.c (make_data_window): Remove.
4628         (show_data): Unify creation and re-initialization cases.
4629
4630 2019-07-17  Tom Tromey  <tom@tromey.com>
4631
4632         * tui/tui-layout.c (make_source_window, make_disasm_window):
4633         Remove.
4634         (show_data): Unify creation and re-initialization cases.
4635
4636 2019-07-17  Tom Tromey  <tom@tromey.com>
4637
4638         * tui/tui-layout.c (make_command_window): Remove.
4639         (show_source_disasm_command, show_source_or_disasm_and_command):
4640         Unify creation and re-initialization cases.
4641
4642 2019-07-17  Tom Tromey  <tom@tromey.com>
4643
4644         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
4645         creation and re-initialization cases.
4646
4647 2019-07-17  Tom Tromey  <tom@tromey.com>
4648
4649         * tui/tui-regs.c (tui_get_register): Return void.
4650
4651 2019-07-17  Tom Tromey  <tom@tromey.com>
4652
4653         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
4654         Simplify.
4655
4656 2019-07-17  Tom Tromey  <tom@tromey.com>
4657
4658         * tui/tui-layout.c (show_source_disasm_command): Simplify window
4659         resetting.
4660
4661 2019-07-17  Tom Tromey  <tom@tromey.com>
4662
4663         * tui/tui.h (tui_set_layout_by_name): Don't declare.
4664         * tui/tui-regs.c (tui_reg_layout): New function.
4665         (tui_show_registers, tui_reg_command): Use it.
4666         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
4667         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
4668         parameters.
4669         (tui_layout_command): Remove.
4670
4671 2019-07-17  Tom Tromey  <tom@tromey.com>
4672
4673         * tui/tui-layout.h (tui/tui-layout): Return void.
4674         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
4675
4676 2019-07-17  Tom Tromey  <tom@tromey.com>
4677
4678         * tui/tui-layout.c (show_source_disasm_command, show_data):
4679         Update.
4680         (reset_locator): Remove.
4681         (show_source_or_disasm_and_command): Update.
4682
4683 2019-07-17  Tom Tromey  <tom@tromey.com>
4684
4685         * tui/tui-source.c (tui_source_window_base::reset): Remove
4686         win_type parameter.
4687         * tui/tui-layout.c (make_command_window, make_source_window)
4688         (make_disasm_window, make_data_window)
4689         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
4690         (reset_locator, show_source_or_disasm_and_command): Update.
4691         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
4692         win_type parameter.
4693         (struct tui_source_window_base) <reset>: Likewise.
4694
4695 2019-07-17  Tom Tromey  <tom@tromey.com>
4696
4697         * tui/tui-layout.c (show_source_disasm_command): Use
4698         reset_locator.
4699         (reset_locator): New function.
4700         (init_and_make_win): Remove.
4701         (show_source_or_disasm_and_command): Use reset_locator.
4702
4703 2019-07-17  Tom Tromey  <tom@tromey.com>
4704
4705         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
4706         condition.
4707         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
4708         Remove condition.
4709         * tui/tui-source.c (tui_source_window_base::reset): New method.
4710         * tui/tui-layout.c (make_command_window): Don't call
4711         init_and_make_win.
4712         (make_source_window, make_disasm_window): Don't call
4713         make_source_or_disasm_window.
4714         (make_data_window): Don't call init_and_make_win.  Change calling
4715         convention.
4716         (show_source_disasm_command, show_data): Simplify.
4717         (make_source_or_disasm_window): Remove.
4718         (show_source_or_disasm_and_command): Simplify.
4719         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
4720         (struct tui_source_window_base) <reset>: Likewise.
4721         <execution_info>: Remove initializer.
4722         * tui/tui-data.c (tui_source_window_base): Initialize
4723         execution_info.
4724
4725 2019-07-17  Tom Tromey  <tom@tromey.com>
4726
4727         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
4728         variable.
4729
4730 2019-07-17  Tom Tromey  <tom@tromey.com>
4731
4732         * tui/tui.c (tui_rl_other_window): Update.
4733         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
4734         superclass method first.  Always iterate over regs_content.
4735         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
4736         method.
4737         * tui/tui-win.c (tui_set_focus_command): Update.
4738
4739 2019-07-17  Tom Tromey  <tom@tromey.com>
4740
4741         * tui/tui-win.c (tui_set_focus_command): Rename from
4742         tui_set_focus.  Call tui_enable.
4743         (tui_set_focus_command): Remove.
4744
4745 2019-07-17  Tom Tromey  <tom@tromey.com>
4746
4747         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
4748         refresh_window.
4749         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
4750         touchwin.
4751         (tui_data_window::refresh_window): Call refresh_window on data
4752         items.  Always call superclass refresh_window.
4753         (tui_win_info::refresh): Remove.
4754         (tui_source_window_base::refresh_window): Update.
4755         (tui_refresh_all): Update.
4756         * tui/tui-layout.c (show_source_disasm_command): Remove call to
4757         refresh_window.
4758         (show_source_or_disasm_and_command): Likewise.
4759         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
4760         (struct tui_source_window_base) <refresh>: Likewise.
4761
4762 2019-07-17  Tom Tromey  <tom@tromey.com>
4763
4764         * tui/tui-winsource.c (tui_clear_source_content)
4765         (tui_show_source_content): Update.
4766         * tui/tui-source.c (tui_source_window::showing_source_p): Check
4767         whether content is empty.
4768         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
4769         Remove.
4770
4771 2019-07-17  Tom Tromey  <tom@tromey.com>
4772
4773         * tui/tui-winsource.c (tui_erase_source_content): Clear the
4774         window's contents.
4775         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
4776         * tui/tui-source.c (tui_set_source_content_nil): Remove.
4777
4778 2019-07-17  Tom Tromey  <tom@tromey.com>
4779
4780         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
4781         (struct tui_data_item_window): Update.
4782
4783 2019-07-17  Tom Tromey  <tom@tromey.com>
4784
4785         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
4786         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
4787         defines.
4788
4789 2019-07-17  Tom Tromey  <tom@tromey.com>
4790
4791         * tui/tui-winsource.h (tui_erase_source_content)
4792         (tui_clear_source_content): Remove "display_prompt" parameter.
4793         * tui/tui-winsource.c (tui_update_source_window_as_is)
4794         (tui_update_source_windows_with_addr): Update.
4795         (tui_clear_source_content): Remove "display_prompt" parameter.
4796         (tui_erase_source_content): Likewise.  Simplify.
4797         (tui_show_source_content): Update.
4798         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
4799         * tui/tui-stack.c (tui_show_frame_info): Update.
4800         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
4801         Remove defines.
4802
4803 2019-07-17  Tom Tromey  <tom@tromey.com>
4804
4805         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
4806         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
4807         parameter.
4808         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
4809         parameter.
4810
4811 2019-07-17  Tom Tromey  <tom@tromey.com>
4812
4813         * tui/tui-winsource.c (tui_clear_source_content)
4814         (tui_show_source_content, tui_show_exec_info_content)
4815         (tui_clear_exec_info_content): Update.
4816         * tui/tui-stack.c (tui_show_locator_content): Update.
4817         (tui_show_frame_info): Update.
4818         * tui/tui-source.h (tui_source_window): Don't declare.
4819         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
4820         from tui_source_is_displayed.
4821         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
4822         Remove field.
4823         (struct tui_source_window_base) <content_in_use>: New field.  Now
4824         bool.
4825         (struct tui_source_window) <showing_source_p>: New method.
4826         (TUI_SRC_WIN): Change cast.
4827         * tui/tui-data.c (tui_initialize_static_data): Update.
4828
4829 2019-07-17  Tom Tromey  <tom@tromey.com>
4830
4831         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
4832         location_matches_p.
4833         * tui/tui-source.c (tui_source_window::location_matches_p): New
4834         method.
4835         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
4836         method.
4837         * tui/tui-data.h (struct tui_source_window_base)
4838         <location_matches_p>: New method.
4839         (struct tui_source_window, struct tui_disasm_window)
4840         <location_matches_p>: Likewise.
4841
4842 2019-07-17  Tom Tromey  <tom@tromey.com>
4843
4844         * tui/tui-win.c (tui_set_win_height_command): Rename from
4845         tui_set_win_height.
4846         (tui_set_win_height_command): Remove.
4847
4848 2019-07-17  Tom Tromey  <tom@tromey.com>
4849
4850         * tui/tui-source.c (tui_source_window): New constructor.  Add
4851         observer.
4852         (~tui_source_window): New destructor.
4853         (tui_source_window::style_changed): New method.
4854         * tui/tui-hooks.c (tui_redisplay_source): Remove.
4855         (tui_attach_detach_observers): Update.
4856         * tui/tui-data.h (struct tui_source_window): Make constructor not
4857         inline.  Add destructor.
4858         (struct tui_source_window) <style_changed>: New method.
4859         <m_observable>: New member.
4860
4861 2019-07-17  Tom Tromey  <tom@tromey.com>
4862
4863         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
4864         * tui/tui-win.c (tui_resize_all): Fix typo.
4865
4866 2019-07-17  Tom Tromey  <tom@tromey.com>
4867
4868         * tui/tui-wingeneral.h (tui_refresh_all): Update.
4869         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
4870         (tui_refresh_all): Remove "list" parameter.  Use foreach.
4871         * tui/tui-win.c (window_name_completer): Use foreach.
4872         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
4873         (update_tab_width): Likewise.
4874         * tui/tui-layout.c (show_layout): Update.
4875         * tui/tui-data.h (class tui_window_iterator): New.
4876         (struct all_tui_windows): New.
4877         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
4878
4879 2019-07-17  Tom Tromey  <tom@tromey.com>
4880
4881         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
4882         parameter.  Don't reference globals.
4883         (tui_reg_command): Update.
4884
4885 2019-07-17  Tom Tromey  <tom@tromey.com>
4886
4887         * tui/tui-regs.c (tui_show_registers): Simplify.
4888
4889 2019-07-17  Tom Tromey  <tom@tromey.com>
4890
4891         * tui/tui-regs.c (tui_show_registers): Update.
4892         (tui_show_register_group): Add win_info parameter.
4893
4894 2019-07-17  Tom Tromey  <tom@tromey.com>
4895
4896         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
4897         Rename from tui_display_reg_element_at_line.
4898         (tui_data_window::display_registers_from_line): Update.
4899         * tui/tui-data.h (struct tui_data_window)
4900         <display_reg_element_at_line>: New method.
4901
4902 2019-07-17  Tom Tromey  <tom@tromey.com>
4903
4904         * tui/tui-regs.h (tui_display_registers_from)
4905         (tui_display_registers_from_line): Don't declare.
4906         * tui/tui-windata.c (tui_data_window::display_all_data)
4907         (tui_data_window::refresh_all)
4908         (tui_data_window::do_scroll_vertical): Update.
4909         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
4910         from tui_display_registers_from.
4911         (tui_display_reg_element_at_line): Update.
4912         (tui_data_window::display_registers_from_line): Rename from
4913         tui_display_registers_from_line.
4914         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
4915         display_registers_from_line>: New methods.
4916
4917 2019-07-17  Tom Tromey  <tom@tromey.com>
4918
4919         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
4920         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
4921         from tui_erase_data_content.
4922         (tui_data_window::display_all_data)
4923         (tui_data_window::refresh_all)
4924         (tui_data_window::do_scroll_vertical): Update.
4925         * tui/tui-regs.c (tui_show_registers): Update.
4926         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
4927         New method.
4928
4929 2019-07-17  Tom Tromey  <tom@tromey.com>
4930
4931         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
4932         declare.
4933         * tui/tui-windata.c
4934         (tui_data_window::delete_data_content_windows): Rename from
4935         tui_delete_data_content_windows.
4936         (tui_data_window::display_all_data)
4937         (tui_data_window::do_scroll_vertical): Update.
4938         * tui/tui-data.h (struct tui_data_window)
4939         <delete_data_content_windows>: New method.
4940
4941 2019-07-17  Tom Tromey  <tom@tromey.com>
4942
4943         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
4944         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
4945
4946 2019-07-17  Tom Tromey  <tom@tromey.com>
4947
4948         * tui/tui-windata.h (tui_display_all_data): Don't declare.
4949         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
4950         from tui_display_all_data.
4951         * tui/tui-win.c
4952         (tui_data_window::do_make_visible_with_new_height): Update.
4953         * tui/tui-regs.c (tui_show_registers): Update.
4954         * tui/tui-layout.c (tui_set_layout): Update.
4955         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
4956         method.
4957
4958 2019-07-17  Tom Tromey  <tom@tromey.com>
4959
4960         * tui/tui-windata.h (tui_display_data_from): Don't declare.
4961         * tui/tui-windata.c (tui_display_data_from): Remove.
4962         (tui_data_window::refresh_all): Update.
4963
4964 2019-07-17  Tom Tromey  <tom@tromey.com>
4965
4966         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
4967         * tui/tui-windata.c (tui_display_data_from_line): Remove.
4968         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
4969         tui_display_registers_from_line.
4970         * tui/tui-regs.h (tui_display_registers_from_line): Update.
4971         * tui/tui-regs.c (tui_display_registers_from_line): Remove
4972         "force_display" parameter.
4973
4974 2019-07-17  Tom Tromey  <tom@tromey.com>
4975
4976         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
4977         declare.
4978         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
4979         Rename from tui_first_reg_element_no_inline.
4980         (tui_display_reg_element_at_line)
4981         (tui_display_registers_from_line): Update.
4982         * tui/tui-data.h (struct tui_data_window)
4983         <first_reg_element_no_inline>: New method.
4984
4985 2019-07-17  Tom Tromey  <tom@tromey.com>
4986
4987         * tui/tui-windata.c (tui_display_data_from)
4988         (tui_data_window::do_scroll_vertical): Update.
4989         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
4990         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
4991         Rename from tui_line_from_reg_element_no.
4992         (tui_display_registers_from_line): Update.
4993         * tui/tui-data.h (struct tui_data_window)
4994         <line_from_reg_element_no>: New method.
4995
4996 2019-07-17  Tom Tromey  <tom@tromey.com>
4997
4998         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
4999         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
5000         tui_last_regs_line_no.
5001         (tui_display_reg_element_at_line)
5002         (tui_display_registers_from_line): Update.
5003         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
5004         method.
5005
5006 2019-07-17  Tom Tromey  <tom@tromey.com>
5007
5008         PR tui/24722:
5009         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
5010         (tui_update_breakpoint_info): Add "being_deleted" parameter.
5011         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
5012         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
5013         (tui_update_breakpoint_info): Likewise.
5014         * tui/tui-hooks.c (tui_event_create_breakpoint)
5015         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
5016         Update.
5017
5018 2019-07-17  Tom Tromey  <tom@tromey.com>
5019
5020         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
5021
5022 2019-07-17  Tom Tromey  <tom@tromey.com>
5023
5024         * tui/tui-winsource.c (tui_update_source_window_as_is)
5025         (tui_update_source_windows_with_addr): Update.
5026         * tui/tui-source.h (tui_set_source_content)
5027         (tui_show_symtab_source): Add "win_info" parameter.
5028         * tui/tui-source.c (tui_set_source_content): Add "win_info"
5029         parameter.
5030         (tui_show_symtab_source): Likewise.
5031
5032 2019-07-17  Tom Tromey  <tom@tromey.com>
5033
5034         * tui/tui-wingeneral.c
5035         (tui_check_and_display_highlight_if_needed): Check can_highlight.
5036
5037 2019-07-17  Tom Tromey  <tom@tromey.com>
5038
5039         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
5040         (struct tui_cmd_window) <can_scroll>: New method.
5041         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
5042         method.
5043
5044 2019-07-17  Tom Tromey  <tromey@adacore.com>
5045
5046         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
5047         do_field_signed>: Rename.  Change type of "value".
5048         * ui-out.c (ui_out::field_signed): Rename from field_int.
5049         Change type of "value".
5050         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
5051         type of "value".
5052         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
5053         do_field_int.  Change type of "value".
5054         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
5055         do_field_int.  Change type of "value".
5056         * tracepoint.c (trace_status_mi, tfind_1)
5057         (print_one_static_tracepoint_marker): Update.
5058         * thread.c (print_thread_info_1, print_selected_thread_frame):
5059         Update.
5060         * stack.c (print_frame, print_frame_info): Update.
5061         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
5062         Update.
5063         * source.c (print_source_lines_base): Update.
5064         * skip.c (info_skip_command): Update.
5065         * record-btrace.c (btrace_ui_out_decode_error)
5066         (btrace_call_history_src_line): Update.
5067         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
5068         Update.
5069         * progspace.c (print_program_space): Update.
5070         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
5071         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
5072         do_field_int.  Change type of "value".
5073         * mi/mi-out.c (mi_ui_out::do_table_begin)
5074         (mi_ui_out::do_table_header): Update.
5075         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
5076         type of "value".
5077         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
5078         (mi_cmd_data_list_changed_registers, output_register)
5079         (mi_cmd_data_read_memory, mi_load_progress)
5080         (mi_cmd_trace_frame_collected): Update.
5081         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
5082         Update.
5083         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
5084         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
5085         (mi_cmd_var_list_children, varobj_update_one): Update.
5086         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
5087         (mi_cmd_stack_list_args, list_arg_or_local): Update.
5088         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
5089         * inferior.c (print_inferior): Update.
5090         * gdb_bfd.c (print_one_bfd): Update.
5091         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
5092         Update.
5093         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
5094         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
5095         do_field_int.  Change type of "value".
5096         * cli-out.c (cli_ui_out::do_field_signed): Rename from
5097         do_field_int.  Change type of "value".
5098         * breakpoint.c (watchpoint_check, print_breakpoint_location)
5099         (print_one_breakpoint_location, print_it_catch_fork)
5100         (print_one_catch_fork, print_it_catch_vfork)
5101         (print_one_catch_vfork, print_it_catch_solib)
5102         (print_it_catch_exec, print_it_ranged_breakpoint)
5103         (print_mention_watchpoint, print_mention_masked_watchpoint)
5104         (bkpt_print_it, update_static_tracepoint): Update.
5105         * break-catch-throw.c (print_it_exception_catchpoint): Update.
5106         * break-catch-syscall.c (print_it_catch_syscall): Update.
5107         * ada-tasks.c (print_ada_task_info): Update.
5108         * ada-lang.c (print_it_exception, print_mention_exception):
5109         Update.
5110
5111 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
5112
5113         PR breakpoints/24541
5114         * gdbarch.c: Regenerate.
5115         * gdbarch.h: Regenerate.
5116         * gdbarch.sh: Adjust return type and parameter types for
5117         'stap_adjust_register'.
5118         (i386_stap_adjust_register): Adjust signature and return new
5119         register name.
5120         * stap-probe.c (stap_parse_register_operand): Adjust use of
5121         'gdbarch_stap_adjust_register'.
5122
5123 2019-07-17  Tom Tromey  <tromey@adacore.com>
5124
5125         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
5126         declare VEC.
5127         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
5128         std::vector.
5129         (struct s390_process_info): Add initializers.
5130         (s390_add_process): Use new.
5131         (s390_linux_nat_target::low_forget_process): Use delete.
5132         (s390_linux_nat_target::low_new_fork)
5133         (s390_linux_nat_target::stopped_by_watchpoint)
5134         (s390_linux_nat_target::low_prepare_to_resume)
5135         (s390_linux_nat_target::insert_watchpoint)
5136         (s390_linux_nat_target::insert_hw_breakpoint)
5137         (s390_linux_nat_target::remove_watchpoint)
5138         (s390_linux_nat_target::remove_hw_breakpoint): Update.
5139
5140 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
5141
5142         * aarch64-fbsd-nat.c: Include regcache.h.
5143         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
5144         argument.
5145         (aarch64_fbsd_nat_target::fetch_registers)
5146         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
5147         variable.
5148         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
5149
5150 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
5151
5152         * fbsd-nat.c: Include gdbarch.h.
5153
5154 2019-07-15  Tom Tromey  <tromey@adacore.com>
5155
5156         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
5157
5158 2019-07-15  Tom Tromey  <tromey@adacore.com>
5159
5160         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
5161         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
5162         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
5163         * cli-out.c (cli_ui_out::do_field_int): New method.
5164         * ui-out.c (ui_out::field_unsigned): New method.
5165         * symfile.c (generic_load): Use field_unsigned.
5166         (print_transfer_performance): Likewise.
5167         * record-btrace.c (ui_out_field_uint): Remove.
5168         (btrace_call_history_insn_range, btrace_call_history): Use
5169         field_unsigned.
5170         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
5171         field_unsigned.
5172         * ui-out.h (class ui_out) <field_unsigned>: New method.
5173         <do_field_unsigned>: Likewise.
5174
5175 2019-07-15  Tom Tromey  <tromey@adacore.com>
5176
5177         * mi/mi-main.c (list_available_thread_groups): Use field_string.
5178         * mi/mi-interp.c (mi_memory_changed): Use field_string.
5179         * target.c (flash_erase_command): Use field_string.
5180         * infrun.c (print_signal_received_reason): Use field_string.
5181         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
5182         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
5183         field_string.
5184         * ada-tasks.c (print_ada_task_info): Use field_string.
5185
5186 2019-07-15  Tom Tromey  <tromey@adacore.com>
5187
5188         * target.c (flash_erase_command): Use field_core_addr.
5189         * symfile.c (generic_load): Use field_core_addr.
5190         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
5191         Use field_core_addr.
5192         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
5193         field_core_addr.
5194
5195 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
5196
5197         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
5198         value if its desired type is smaller than a CORE_ADDR and signed.
5199
5200 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
5201
5202         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
5203         of changes to field names, and use new is_reference field to
5204         decide if a property is a reference or not.
5205         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
5206         field.
5207         (struct dwarf2_property_baton): Update header comment, rename
5208         'referenced_type' to 'property_type' and update comments.
5209         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
5210         default property type, store in property baton, update to take
5211         accound of renamed field.
5212         (read_func_scope): Update call to attr_to_dynamic_prop.
5213         (read_array_type): Likewise.
5214         (dwarf2_per_cu_addr_sized_int_type): New function.
5215         (read_subrange_index_type): Move type finding code to
5216         dwarf2_per_cu_addr_sized_int_type.
5217         (read_subrange_type): Update calls to attr_to_dynamic_prop.
5218         (dwarf2_per_cu_addr_type): New function.
5219         (set_die_type): Update calls to attr_to_dynamic_prop.
5220
5221 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
5222
5223         * dwarf2read.c (read_subrange_index_type): New function.
5224         (read_subrange_type): Move code into new function and call it.
5225         * gdbtypes.c (create_range_type): Add some asserts.
5226
5227 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
5228
5229         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
5230         update return statements.
5231         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
5232         declaration, and update comment to match.
5233         * gdbtypes.c (resolve_dynamic_array): Update call to
5234         dwarf2_evaluate_property to match new return type.
5235
5236 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
5237
5238         * valarith.c (value_subscripted_rvalue): Change lowerbound
5239         parameter type from int to LONGEST.
5240         * value.h (value_subscripted_rvalue): Likewise in declaration.
5241
5242 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5243
5244         * cli/cli-utils.c (info_print_command_completer): New function.
5245         * cli/cli-utils.h: Add 'completer.h' include, and forward
5246         declaration for 'struct cmd_list_element'.
5247         (info_print_command_completer): Declare.
5248         * stack.c (_initialize_stack): Add completer for 'info locals' and
5249         'info args'.
5250         * symtab.c (_initialize_symtab): Add completer for 'info
5251         variables' and 'info functions'.
5252         * NEWS: Mention completion for additional info commands.
5253
5254 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5255
5256         * cli/cli-utils.c (extract_info_print_args): Delete.
5257         (extract_arg_maybe_quoted): Delete.
5258         (info_print_options_defs): New variable.
5259         (make_info_print_options_def_group): New function.
5260         (extract_info_print_options): Define new function.
5261         * cli/cli-utils.h (extract_info_print_args): Delete.
5262         (struct info_print_options): New structure.
5263         (extract_info_print_options): Declare new function.
5264         * stack.c (info_locals_command): Update to use new
5265         extract_info_print_options, also add a header comment.
5266         (info_args_command): Likewise.
5267         * symtab.c (info_variables_command): Likewise.
5268         (info_functions_command): Likewise.
5269
5270 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5271
5272         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
5273         to extract string arguments.
5274         * common/common-utils.c (extract_string_maybe_quoted): New function.
5275         * common/common-utils.h (extract_string_maybe_quoted): Declare.
5276
5277 2019-07-11  Tom Tromey  <tromey@adacore.com>
5278
5279         * main.c (get_init_files): Use GDBINIT, not gdbinit.
5280         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
5281         * top.h (gdbinit): Don't declare.
5282         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
5283         into...
5284         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
5285         * top.c (gdb_init): Don't call init_cli_cmds.
5286         (gdbinit): Remove.
5287         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
5288
5289 2019-07-11  Tom Tromey  <tromey@adacore.com>
5290
5291         * python/py-inferior.c (add_thread_object): Don't use thread_obj
5292         after it has been moved.
5293
5294 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
5295
5296         * valops.c (value_must_coerce_to_target): Change return type to
5297         bool.
5298         * value.h (value_must_coerce_to_target): Likewise.
5299
5300 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
5301
5302         * breakpoint.c (is_hardware_watchpoint): Remove
5303         forward-declaration.
5304         (is_masked_watchpoint): Change return type to bool.
5305         (is_tracepoint): Likewise.
5306         (is_breakpoint): Likewise.
5307         (is_hardware_watchpoint): Likewise.
5308         (is_watchpoint): Likewise.
5309         (is_no_memory_software_watchpoint): Likewise.
5310         (is_catchpoint): Likewise.
5311         (breakpoint_1): Make FILTER parameter's return type bool.
5312         is_masked_watchpoint): Change return type to bool.
5313         (save_breakpoints): Make FILTER parameter's return type bool.
5314         * breakpoint.h (is_breakpoint): Change return type to bool.
5315         (is_watchpoint): Likewise.
5316         (is_catchpoint): Likewise.
5317         (is_tracepoint): Likewise.
5318
5319 2019-07-10  Tom Tromey  <tom@tromey.com>
5320
5321         * defs.h: Don't include gdbarch.h.
5322         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
5323         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
5324         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
5325         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
5326         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
5327         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
5328         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
5329         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
5330         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
5331         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
5332         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
5333         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
5334         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
5335         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
5336         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
5337         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
5338         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
5339         record-btrace.c, record.h, regcache-dump.c, regcache.h,
5340         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
5341         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
5342         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
5343         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
5344         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
5345         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
5346         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
5347         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
5348         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
5349
5350 2019-07-10  Tom Tromey  <tromey@adacore.com>
5351
5352         * ada-lang.h (is_ada_exception_catchpoint): Declare.
5353         * breakpoint.c (init_ada_exception_breakpoint): Register as
5354         bp_catchpoint.
5355         (print_one_breakpoint_location, print_one_breakpoint): Use
5356         is_ada_exception_catchpoint.
5357         * ada-lang.c (class ada_catchpoint_location): Pass
5358         bp_loc_software_breakpoint to bp_location constructor.
5359         (is_ada_exception_catchpoint): New function.
5360
5361 2019-07-10  Tom Tromey  <tromey@adacore.com>
5362
5363         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
5364         VEC.
5365         (struct arm_exidx_entry): New method operator<.
5366         (struct arm_exidx_data) <section_maps>: Change type.
5367         (arm_exidx_data_free): Remove.
5368         (arm_exidx_data_key): Change type.  Move lower.
5369         (arm_exidx_new_objfile): Update.
5370         (arm_compare_exidx_entries): Remove.
5371         (arm_find_exidx_entry, _initialize_arm_tdep)
5372
5373 2019-07-10  Tom Tromey  <tromey@adacore.com>
5374
5375         * solib-spu.c (ocl_program_data_key): Change type.
5376         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
5377         Update.
5378
5379 2019-07-10  Tom Tromey  <tromey@adacore.com>
5380
5381         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
5382         (struct solib_aix_inferior_data) <library_list>: Change type.
5383         (solib_aix_inferior_data_handle): Change type.
5384         (get_solib_aix_inferior_data): Update.
5385         (solib_aix_free_library_list): Remove.
5386         (library_list_start_library): Update.
5387         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
5388         return type.
5389         (solib_aix_get_library_list)
5390         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
5391         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
5392
5393 2019-07-10  Tom Tromey  <tromey@adacore.com>
5394
5395         * solib-dsbt.c (struct dsbt_info): Add initializers.
5396         (solib_dsbt_pspace_data): Change type.
5397         (dsbt_pspace_data_cleanup): Remove.
5398         (get_dsbt_info, _initialize_dsbt_solib): Update.
5399
5400 2019-07-10  Tom Tromey  <tromey@adacore.com>
5401
5402         * spu-tdep.c (spu_overlay_data): Change type.
5403         (spu_get_overlay_table, spu_overlay_new_objfile)
5404         (_initialize_spu_tdep): Update.
5405
5406 2019-07-10  Tom Tromey  <tromey@adacore.com>
5407
5408         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
5409         destructor.
5410         (dbx_objfile_data_key): Change type and declare later.
5411         (DBX_SYMFILE_INFO): Rewrite.
5412         * dbxread.c (dbx_objfile_data_key): Change type.
5413         (dbx_symfile_init): Update.
5414         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
5415         (coffstab_build_psymtabs, elfstab_build_psymtabs)
5416         (stabsect_build_psymtabs, _initialize_dbxread): Update.
5417
5418 2019-07-10  Tom Tromey  <tromey@adacore.com>
5419
5420         * jit.c (jit_program_space_key): Change type.  Move lower.
5421         (get_jit_program_space_data): Update.
5422         (jit_program_space_data_cleanup): Remove.
5423         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
5424         Update.
5425         (struct jit_program_space_data): Add initializers.
5426
5427 2019-07-10  Tom Tromey  <tromey@adacore.com>
5428
5429         * solib-darwin.c (struct darwin_info): Add initializers.
5430         (solib_darwin_pspace_data): Change type.
5431         (darwin_pspace_data_cleanup): Remove.
5432         (get_darwin_info, _initialize_darwin_solib): Update.
5433
5434 2019-07-10  Tom Tromey  <tromey@adacore.com>
5435
5436         * remote-sim.c (struct sim_inferior_data): Add initializers,
5437         constructor, and destructor.
5438         (sim_inferior_data_key): Change type.  Move lower.
5439         (check_for_duplicate_sim_descriptor): Update.
5440         (get_sim_inferior_data): Use new.  Update.
5441         (~sim_inferior_data_cleanup): Rename from
5442         sim_inferior_data_cleanup.  Simplify.
5443         (gdbsim_close_inferior, simulator_command)
5444         (sim_command_completer, _initialize_remote_sim): Update.
5445         (next_pid, INITIAL_PID): Move earlier.
5446
5447 2019-07-10  Tom Tromey  <tromey@adacore.com>
5448
5449         * python/python-internal.h (create_thread_object): Return
5450         gdbpy_ref.
5451         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
5452         * python/py-inferior.c (struct threadlist_entry): Add
5453         constructor.
5454         <thread_obj>: Now a gdbpy_ref.
5455         (thread_to_thread_object): Update.
5456         (add_thread_object): Use new.
5457         (delete_thread_object): Use delete.
5458         (infpy_threads): Update.
5459         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
5460         GIL.
5461
5462 2019-07-10  Tom Tromey  <tromey@adacore.com>
5463
5464         * valops.c (value_cast): Specialize error message for Ada.
5465
5466 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
5467
5468         * breakpoint.c (breakpoint_1): Update doc and parameter names.
5469
5470 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
5471
5472         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
5473         bpstat_should_step): Return bool, adjust comments.
5474         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
5475         bpstat_should_step): Likewise.
5476
5477 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
5478
5479         * features/Makefile: Use feature target descriptions for Arm.
5480         * features/arm/arm-core.c: Generate new file.
5481         * features/arm/arm-fpa.c: Likewise.
5482         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
5483         * features/arm/arm-m-profile.c: Likewise.
5484         * features/arm/arm-vfpv2.c: Likewise.
5485         * features/arm/arm-vfpv3.c: Likewise.
5486         * features/arm/xscale-iwmmxt.c: Likewise.
5487         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
5488
5489 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
5490
5491         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
5492         ptrace earlier.
5493
5494 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
5495
5496         * features/aarch64-pauth.c: Regenerate.
5497
5498 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
5499
5500         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
5501         bool.
5502         (bpstat_what): Use false instead of 0.
5503
5504 2019-07-09  Pedro Alves  <palves@redhat.com>
5505
5506         * break-catch-throw.c (is_exception_catchpoint): New.
5507         * breakpoint.c (print_one_breakpoint_location): New parameter
5508         'raw_loc'.  Handle it.  Use
5509         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
5510         looking at the breakpoint's type.
5511         (print_one_breakpoint): If handling "maint info breakpoints", also
5512         print locations of exception catchpoints.
5513         * breakpoint.h (is_exception_catchpoint): Declare.
5514
5515 2019-07-09  Pedro Alves  <palves@redhat.com>
5516
5517         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
5518         "addr" field.
5519         (allocate_location_exception_catchpoint): New.
5520         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
5521         (initialize_throw_catchpoint_ops): Install
5522         allocate_location_exception_catchpoint as allocate_location
5523         method.
5524         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
5525         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
5526         bp_loc_other.
5527         (breakpoint_address_is_meaningful): Delete.
5528         (bl_address_is_meaningful): New.
5529         (breakpoint_locations_match): Adjust comment.
5530         (bp_location_from_bp_type): New, factored out of...
5531         (bp_location::bp_location(breakpoint *)): ... this.
5532         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
5533         factored out of...
5534         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
5535         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
5536         breakpoint_address_is_meaningful.
5537         (bp_locations_compare): Adjust comment.
5538         (update_global_location_list): Use bl_address_is_meaningful
5539         instead of breakpoint_address_is_meaningful.
5540         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
5541         explicit.
5542         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
5543         * python/py-breakpoint.c (bppy_get_location): No longer check
5544         whether location is null.
5545
5546 2019-07-09  Pedro Alves  <palves@redhat.com>
5547
5548         PR c++/15468
5549         * breakpoint.c (print_one_breakpoint_location): Remove
5550         single-location assert.
5551
5552 2019-07-09  Tom Tromey  <tom@tromey.com>
5553
5554         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
5555         * configure: Rebuild.
5556         * configure.ac: Change common to gdbsupport.
5557         * gdbsupport: Rename from common.
5558         * acinclude.m4: Change common to gdbsupport.
5559         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
5560         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
5561         gdbsupport.
5562         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
5563         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
5564         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
5565         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
5566         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
5567         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
5568         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
5569         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
5570         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
5571         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
5572         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
5573         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
5574         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
5575         coff-pe-read.c, command.h, compile/compile-c-support.c,
5576         compile/compile-c.h, compile/compile-cplus-symbols.c,
5577         compile/compile-cplus-types.c, compile/compile-cplus.h,
5578         compile/compile-loc2c.c, compile/compile.c, completer.c,
5579         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
5580         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
5581         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
5582         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
5583         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
5584         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
5585         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
5586         features/aarch64-core.c, features/aarch64-fpu.c,
5587         features/aarch64-pauth.c, features/aarch64-sve.c,
5588         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
5589         features/i386/32bit-core.c, features/i386/32bit-linux.c,
5590         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
5591         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
5592         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
5593         features/i386/64bit-core.c, features/i386/64bit-linux.c,
5594         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
5595         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
5596         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
5597         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
5598         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
5599         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
5600         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
5601         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
5602         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
5603         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
5604         go32-nat.c, guile/guile.c, guile/scm-ports.c,
5605         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
5606         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
5607         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
5608         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
5609         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
5610         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
5611         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
5612         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
5613         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
5614         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
5615         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
5616         minsyms.c, mips-linux-tdep.c, namespace.h,
5617         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
5618         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
5619         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
5620         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
5621         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
5622         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
5623         nat/linux-waitpid.c, nat/mips-linux-watch.c,
5624         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
5625         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
5626         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
5627         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
5628         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
5629         procfs.c, producer.c, progspace.h, psymtab.h,
5630         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
5631         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
5632         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
5633         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
5634         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
5635         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
5636         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
5637         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
5638         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
5639         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
5640         target-memory.c, target.c, target.h, target/waitstatus.c,
5641         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
5642         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
5643         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
5644         unittests/array-view-selftests.c,
5645         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
5646         unittests/common-utils-selftests.c,
5647         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
5648         unittests/format_pieces-selftests.c,
5649         unittests/function-view-selftests.c,
5650         unittests/lookup_name_info-selftests.c,
5651         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
5652         unittests/mkdir-recursive-selftests.c,
5653         unittests/observable-selftests.c,
5654         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
5655         unittests/parse-connection-spec-selftests.c,
5656         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
5657         unittests/scoped_fd-selftests.c,
5658         unittests/scoped_mmap-selftests.c,
5659         unittests/scoped_restore-selftests.c,
5660         unittests/string_view-selftests.c, unittests/style-selftests.c,
5661         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
5662         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
5663         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
5664         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
5665         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
5666         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
5667
5668 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
5669
5670         * linespec.c (decode_digits_list_mode): Set explicit_line to a
5671         bool value.
5672         (decode_digits_ordinary): Set explicit_line field in sal.
5673         * symtab.c (skip_prologue_sal): Don't skip prologue for a
5674         symtab_and_line that was set on an explicit line number in
5675         assembler code.  Do always update the recorded symtab and line if
5676         we do skip the prologue.
5677
5678 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
5679
5680         * breakpoint.c (set_breakpoint_location_function): Remove
5681         explicit_loc parameter.
5682         (momentary_breakpoint_from_master): Update call to
5683         set_breakpoint_location_function.
5684         (add_location_to_breakpoint): Likewise.
5685
5686 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
5687
5688         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
5689         required features based on default bfd type when no specific bfd
5690         is present.
5691
5692 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5693
5694         * NEWS: Mention that GDB printf and eval commands can now print
5695         C-style and Ada-style convenience var strings without
5696         calling the inferior.
5697         * printcmd.c (printf_c_string): Locally print GDB internal var
5698         instead of transiting via the inferior.
5699         (printf_wide_c_string): Likewise.
5700
5701 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5702
5703         PR breakpoints/25011
5704         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
5705
5706 2019-07-04  Tom Tromey  <tom@tromey.com>
5707
5708         PR tui/24724:
5709         * tui/tui-winsource.c (tui_clear_source_content): Update.
5710         (tui_source_window_base::set_is_exec_point_at): Fix comment.
5711         (tui_update_breakpoint_info): Update.
5712         (tui_set_exec_info_content): Update.
5713         * tui/tui-source.c (tui_set_source_content_nil): Update.
5714         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
5715         has_break.
5716         * tui/tui-data.h (enum tui_bp_flag): New.
5717         (tui_bp_flags): New enum flags type.
5718         (struct tui_source_element) <break_mode>: Change type.  Rename
5719         from has_break.
5720         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
5721         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
5722         constants.
5723         * tui/tui-winsource.h: Fix comment.
5724
5725 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5726
5727         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
5728         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
5729         (store_fpregs_to_thread)
5730         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
5731         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
5732         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
5733         (IWMMXT_REGS_SIZE): Add define.
5734         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
5735         (fetch_vfp_regs, store_vfp_regs)
5736         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
5737         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
5738
5739 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5740
5741         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
5742         defines.
5743         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
5744         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
5745         (ARM_INT_REGISTER_SIZE): ...to this.
5746         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
5747         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
5748         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
5749         (arm_linux_collect_gregset, supply_nwfpe_register)
5750         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
5751         defines.
5752         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
5753         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
5754         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
5755         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
5756         (arm_return_in_memory, arm_store_return_value)
5757         (arm_get_longjmp_target, arm_register_g_packet_guesses)
5758         (arm_record_ld_st_multiple): Likewise.
5759         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
5760         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
5761
5762 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5763
5764         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
5765         AARCH64_DISPLACED_MODIFIED_INSNS.
5766         * aarch64-tdep.c (struct aarch64_displaced_step_data)
5767         (aarch64_displaced_step_copy_insn): Likewise.
5768         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
5769         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
5770         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
5771         ARM_DISPLACED_MODIFIED_INSNS.
5772         * arm-tdep.c (arm_gdbarch_init): Likewise.
5773         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
5774         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
5775         (struct arm_displaced_step_closure): Use
5776         ARM_DISPLACED_MODIFIED_INSNS.
5777
5778 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5779
5780         * features/Makefile: Remove unused xml files.
5781         * features/aarch64.xml: Remove.
5782         * features/i386/amd64-avx-avx512-linux.xml: Remove.
5783         * features/i386/amd64-avx-avx512.xml: Remove.
5784         * features/i386/amd64-avx-linux.xml: Remove.
5785         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
5786         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
5787         * features/i386/amd64-avx-mpx-linux.xml: Remove.
5788         * features/i386/amd64-avx-mpx.xml: Remove.
5789         * features/i386/amd64-avx.xml: Remove.
5790         * features/i386/amd64-linux.xml: Remove.
5791         * features/i386/amd64-mpx-linux.xml: Remove.
5792         * features/i386/amd64-mpx.xml: Remove.
5793         * features/i386/amd64.xml: Remove.
5794         * features/i386/i386-avx-avx512-linux.xml: Remove.
5795         * features/i386/i386-avx-avx512.xml: Remove.
5796         * features/i386/i386-avx-linux.xml: Remove.
5797         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
5798         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
5799         * features/i386/i386-avx-mpx-linux.xml: Remove.
5800         * features/i386/i386-avx-mpx.xml: Remove.
5801         * features/i386/i386-avx.xml: Remove.
5802         * features/i386/i386-linux.xml: Remove.
5803         * features/i386/i386-mmx-linux.xml: Remove.
5804         * features/i386/i386-mmx.xml: Remove.
5805         * features/i386/i386-mpx-linux.xml: Remove.
5806         * features/i386/i386-mpx.xml: Remove.
5807         * features/i386/i386.xml: Remove.
5808         * features/i386/x32-avx-avx512-linux.xml: Remove.
5809         * features/i386/x32-avx-linux.xml: Remove.
5810         * features/i386/x32-linux.xml: Remove.
5811
5812 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5813
5814         * regformats/aarch64.dat: Remove.
5815         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
5816         * regformats/i386/amd64-avx-linux.dat: Remove.
5817         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
5818         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
5819         * regformats/i386/amd64-linux.dat: Remove.
5820         * regformats/i386/amd64-mpx-linux.dat: Remove.
5821         * regformats/i386/amd64.dat: Remove.
5822         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
5823         * regformats/i386/i386-avx-linux.dat: Remove.
5824         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
5825         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
5826         * regformats/i386/i386-linux.dat: Remove.
5827         * regformats/i386/i386-mmx-linux.dat: Remove.
5828         * regformats/i386/i386-mpx-linux.dat: Remove.
5829         * regformats/i386/i386.dat: Remove.
5830         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
5831         * regformats/i386/x32-avx-linux.dat: Remove.
5832         * regformats/i386/x32-linux.dat: Remove.
5833
5834 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5835
5836         * aarch64-tdep.c: Remove xml self tests.
5837         * amd64-linux-tdep.c: Likewise.
5838         * amd64-tdep.c: Likewise.
5839         * i386-linux-tdep.c: Likewise.
5840         * i386-tdep.c: Likewise.
5841
5842 2019-07-03  Pedro Alves  <palves@redhat.com>
5843
5844         PR cli/24732
5845         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
5846         (pipe_cmd_option_defs): New.
5847         (make_pipe_cmd_options_def_group): New.
5848         (pipe_command): Use gdb::option::process_options.
5849         (pipe_command_completer): New function.
5850         (_initialize_cli_cmds): Install completer for "pipe" command.
5851
5852 2019-07-03  Pedro Alves  <palves@redhat.com>
5853
5854         * cli/cli-option.c (union option_value) <string>: New field.
5855         (struct option_def_and_value): Add ctor, move ctor, dtor and
5856         use DISABLE_COPY_AND_ASSIGN.
5857         (option_def_and_value::clear_value): New.
5858         (parse_option, save_option_value_in_ctx, get_val_type_str)
5859         (add_setshow_cmds_for_options): Handle var_string.
5860         * cli-option.h (union option_def::var_address) <string>: New
5861         field.
5862         (struct string_option_def): New.
5863         * maint-test-options.c (struct test_options_opts): Add default
5864         ctor and use DISABLE_COPY_AND_ASSIGN.
5865         <string_opt>: New field.
5866         (test_options_opts::~test_options_opts): New.
5867         (test_options_opts::dump): Also dump "-string".
5868         (test_options_option_defs): Install "string.
5869
5870 2019-07-03  Pedro Alves  <palves@redhat.com>
5871
5872         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
5873         option_value with a null enumeration.
5874         (complete_options): Save the option values in the context.
5875         (save_option_value_in_ctx): New, factored out from ...
5876         (process_options): ... here.
5877         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
5878         of the function.
5879         * maint-test-options.c (test_options_opts::dump): New, factored
5880         out from ...
5881         (maintenance_test_options_command_mode): ... here.
5882         (maintenance_test_options_command_completion_result): Delete.
5883         (maintenance_test_options_command_completion_text): Update
5884         comment.
5885         (maintenance_show_test_options_completion_result): Change
5886         prototype.  Just print
5887         maintenance_test_options_command_completion_text.
5888         (save_completion_result): New.
5889         (maintenance_test_options_completer_mode): Pass options context to
5890         complete_options, and then save a dump.
5891         (_initialize_maint_test_options): Use add_cmd to install "maint
5892         show test-options-completion-result".
5893
5894 2019-07-03  Pedro Alves  <palves@redhat.com>
5895
5896         * NEWS (New commands): Mention "with" and "maint with".
5897         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
5898         (with_command, with_command_completer): New.
5899         (pipe_command): Adjust to new repeat_previous
5900         interface.
5901         (_initialize_cli_cmds): Install the "with" command and its "w"
5902         alias.
5903         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
5904         declarations.
5905         * cli/cli-setshow.c (parse_cli_var_uinteger)
5906         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
5907         argument strings for all var_types.
5908         (get_setshow_command_value_string): New, factored out from ...
5909         (do_show_command): ... this.
5910         * cli/cli-setshow.h: Include <string>.
5911         (get_setshow_command_value_string): Declare.
5912         * command.h (repeat_previous): Now returns const char *.  Adjust
5913         comment.
5914         * maint.c: Include "cli/cli-cmds.h".
5915         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
5916         (_initialize_maint_cmds): Register the "maintenance with" command.
5917         * top.c (repeat_previous): Move bits from pipe_command here:
5918         Return the saved command line, if any; error out if there's no
5919         command to relaunch.
5920
5921 2019-07-03  Pedro Alves  <palves@redhat.com>
5922
5923         * NEWS (New commands): Mention "maint set/show test-settings"
5924         instead of "maint test-settings".
5925         * maint-test-settings.c (maintenance_test_settings_list): Delete.
5926         (maintenance_test_settings_set_list): Rename to ...
5927         (maintenance_set_test_settings_list): ... this.
5928         (maintenance_test_settings_show_list): Rename to  ...
5929         (maintenance_show_test_settings_list): ... this.
5930         (maintenance_test_settings_cmd): Delete.
5931         (maintenance_test_settings_set_cmd): ...
5932         (maintenance_set_test_settings_cmd): ... this.
5933         (maintenance_test_settings_show_cmd): ...
5934         (maintenance_show_test_settings_cmd): ... this.
5935         (maintenance_test_settings_show_value_cmd):
5936         (maintenance_show_test_settings_value_cmd): ... this.
5937         (_initialize_maint_test_settings): No longer install the "maint
5938         test-settings" prefix command.  Rename "maint test-settings set"
5939         to "maint set test-settings", and "maint test-settings show" to
5940         "maint show test-settings".  Adjust all subcommands.
5941
5942 2019-07-03  Pedro Alves  <palves@redhat.com>
5943
5944         * maint-test-settings.c: Fix file's intro comment.  Replace all
5945         references to "test-options" with references to "test-settings",
5946         in comments.
5947
5948 2019-07-03  Pedro Alves  <palves@redhat.com>
5949
5950         * maint-test-settings.c (maintenance_test_settings_xxx)
5951         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
5952         New.
5953         (maintenance_test_settings_enums): Use them.
5954         (maintenance_test_settings_enum): Default to
5955         maintenance_test_settings_xxx.
5956         (_initialize_maint_test_settings): Initialize
5957         MAINTENANCE_TEST_SETTINGS_FILENAME.
5958
5959 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
5960
5961         * breakpoint.h (remove_breakpoints_inf): Change return type to
5962         void, move function documentation here.
5963         * breakpoint.c (remove_breakpoints_inf): Change return type to
5964         void, move function documentation to header.
5965
5966 2019-07-02  Pedro Alves  <palves@redhat.com>
5967
5968         * NEWS (Completion improvements): Mention "info threads".
5969         * thread.c (struct info_threads_opts, info_threads_option_defs)
5970         (make_info_threads_options_def_group): New.
5971         (info_threads_command): Use gdb::option::process_options.
5972         (info_threads_command_completer): New.
5973         (_initialize_thread): Use gdb::option::build_help to build the
5974         help text for "info threads".
5975
5976 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
5977
5978         * defs.h (generic_load): Move from here...
5979         * symfile.h (generic_load): ... to here.  Rename name parameter
5980         to args.
5981         * symfile.c (generic_load): Add comment.
5982
5983 2019-07-01  Tom Tromey  <tromey@adacore.com>
5984
5985         * dwarf2read.c
5986         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
5987         declaration of without_params.  Fix formatting.
5988
5989 2019-07-01  Tom Tromey  <tromey@adacore.com>
5990
5991         * ada-exp.y (find_primitive_type): Update.
5992         * ada-lang.h (ada_lookup_symbol): Update.
5993         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
5994         parameter.
5995         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
5996
5997 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
5998
5999         PR breakpoints/24541
6000         * gdbarch.c: Regenerate.
6001         * gdbarch.h: Regenerate.
6002         * gdbarch.sh: Add 'stap_adjust_register'.
6003         * i386-tdep.c: Include '<unordered_set>'.
6004         (i386_stap_adjust_register): New function.
6005         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
6006         * stap-probe.c (stap_parse_register_operand): Call
6007         'gdbarch_stap_adjust_register'.
6008
6009 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
6010
6011         PR python/24742
6012         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
6013         * python/python.c (do_start_initialization): Use 'xmalloc'
6014         instead of 'PyMem_Malloc'.
6015
6016 2019-06-28  Tom Tromey  <tromey@adacore.com>
6017
6018         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
6019         for Ada.
6020
6021 2019-06-27  Tom Tromey  <tromey@adacore.com>
6022
6023         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
6024         objfile_key.
6025         (arm_find_mapping_symbol, arm_record_special_symbol)
6026         (_initialize_arm_tdep): Update.
6027         (arm_objfile_data_free): Remove.
6028
6029 2019-06-27  Tom Tromey  <tromey@adacore.com>
6030
6031         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
6032         to cp_print_static_field.
6033
6034 2019-06-26  Tom Tromey  <tromey@adacore.com>
6035
6036         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
6037         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
6038         declare.
6039
6040 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
6041
6042         * features/aarch64-core.c (create_feature_aarch64_core):
6043         Regenerate.
6044         * features/aarch64-core.xml: Add cpsr flags.
6045
6046 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
6047
6048         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
6049         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
6050
6051 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
6052
6053         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
6054         field.
6055         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
6056         use.
6057         (arm_record_special_symbol): Don't insert new symbol in sorted
6058         position, push it at the end.
6059
6060 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
6061
6062         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
6063         (arm_mapping_symbol_s): Remove.
6064         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
6065         (arm_mapping_symbol_vec): New typedef.
6066         (struct arm_per_objfile): Add constructor.
6067         <section_maps>: Change type to
6068         std::unique_ptr<arm_mapping_symbol_vec[]>.
6069         (arm_compare_mapping_symbols): Remove.
6070         (arm_find_mapping_symbol): Adjust to section_maps type change.
6071         (arm_objfile_data_free): Call delete on arm_per_objfile.
6072         (arm_record_special_symbol): Adjust to section_maps type change.
6073         Allocate arm_per_objfile with new.
6074
6075 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6076
6077         * cli/cli-cmds.c (alias_command): Compare the alias prefix
6078         with the command prefix.
6079
6080 2019-06-25  Tom Tromey  <tom@tromey.com>
6081
6082         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
6083         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
6084
6085 2019-06-25  Tom Tromey  <tom@tromey.com>
6086
6087         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
6088         type.
6089         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
6090         protected.
6091
6092 2019-06-25  Tom Tromey  <tom@tromey.com>
6093
6094         * tui/tui-winsource.c
6095         (tui_source_window_base::set_is_exec_point_at): Add check against
6096         LOA_ADDRESS.
6097
6098 2019-06-25  Tom Tromey  <tom@tromey.com>
6099
6100         * tui/tui-source.c (tui_set_source_content): Don't check before
6101         xfree.
6102         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
6103
6104 2019-06-25  Tom Tromey  <tom@tromey.com>
6105
6106         * tui/tui-winsource.h (tui_update_source_window_as_is)
6107         (tui_alloc_source_buffer, tui_line_is_displayed)
6108         (tui_addr_is_displayed): Change type of win_info.
6109         * tui/tui-winsource.c (tui_update_source_window_as_is)
6110         (tui_clear_source_content, tui_show_source_line)
6111         (tui_show_source_content, tui_source_window_base::refill)
6112         (tui_source_window_base::set_is_exec_point_at)
6113         (tui_source_window_base::set_is_exec_point_at)
6114         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
6115         (tui_alloc_source_buffer, tui_line_is_displayed)
6116         (tui_addr_is_displayed): Change type of win_info.  Update.
6117         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
6118         (tui_source_window_base::do_make_visible_with_new_height):
6119         Update.
6120         * tui/tui-source.c (tui_set_source_content)
6121         (tui_set_source_content_nil)
6122         (tui_source_window::do_scroll_vertical): Update.
6123         * tui/tui-layout.c (show_layout): Update.
6124         * tui/tui-disasm.c (tui_set_disassem_content)
6125         (tui_disasm_window::do_scroll_vertical): Update.
6126         * tui/tui-data.h (tui_win_content): Remove.
6127         (struct tui_gen_win_info) <content, content_size>: Remove.
6128         (struct tui_source_element): Add initializers and destructor.
6129         (union tui_which_element, struct tui_win_element): Remove.
6130         (struct tui_source_window_base) <content>: New field.
6131         (struct tui_data_window): Remove destructor.
6132         (tui_alloc_content, tui_free_win_content)
6133         (tui_free_all_source_wins_content): Don't declare.
6134         * tui/tui-data.c (tui_initialize_static_data): Update.
6135         (init_content_element, tui_alloc_content): Remove.
6136         (~tui_gen_win_info): Update.
6137         (~tui_data_window, tui_free_all_source_wins_content)
6138         (tui_free_win_content, free_content, free_content_elements):
6139         Remove.
6140
6141 2019-06-25  Tom Tromey  <tom@tromey.com>
6142
6143         * tui/tui-winsource.h (tui_clear_source_content)
6144         (tui_erase_source_content, tui_show_source_content): Change type
6145         of win_info.
6146         * tui/tui-winsource.c (tui_clear_source_content)
6147         (tui_erase_source_content, tui_show_source_content): Change type
6148         of win_info.
6149         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
6150         * tui/tui-source.h (tui_set_source_content_nil): Change type of
6151         win_info.
6152         * tui/tui-source.c (tui_set_source_content_nil): Change type of
6153         win_info.
6154         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
6155
6156 2019-06-25  Tom Tromey  <tom@tromey.com>
6157
6158         * tui/tui-winsource.c (tui_clear_source_content)
6159         (tui_source_window_base::set_is_exec_point_at): Update.
6160         * tui/tui-source.c (tui_set_source_content_nil): Update.
6161         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
6162         a bool.
6163         * tui/tui-data.c (init_content_element): Update.
6164
6165 2019-06-25  Tom Tromey  <tom@tromey.com>
6166
6167         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
6168         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
6169         * tui/tui-layout.c (init_and_make_win): Update.
6170         * tui/tui.h (enum tui_win_type): Update.
6171         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
6172         tui_win_is_auxillary.
6173         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
6174         tui_win_is_auxillary.
6175
6176 2019-06-25  Tom Tromey  <tom@tromey.com>
6177
6178         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
6179         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
6180         (tui_delete_data_content_windows, tui_display_all_data)
6181         (tui_data_window::do_scroll_vertical, tui_display_data_from):
6182         Update.
6183         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
6184         * tui/tui-regs.c (tui_last_regs_line_no)
6185         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
6186         (tui_show_registers): Update.
6187         (tui_show_register_group): Return void.  Update.
6188         (tui_display_registers_from, tui_display_reg_element_at_line)
6189         (tui_display_registers_from_line, tui_check_register_values):
6190         Update.
6191         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
6192         member.
6193         (struct tui_data_window) <regs_content>: Now a std::vector.
6194         <regs_content_count>: Remove.
6195         (tui_add_content_elements, tui_free_data_content): Don't declare.
6196         * tui/tui-data.c (tui_data_window::clear_detail): Update.
6197         (init_content_element): Remove DATA_WIN case.  Add assert.
6198         (tui_add_content_elements): Remove.
6199         (tui_data_window): Update.
6200         (tui_free_data_content): Remove.
6201         (free_content_elements): Remove DATA_WIN case.
6202
6203 2019-06-25  Tom Tromey  <tom@tromey.com>
6204
6205         * tui/tui-data.c (tui_data_item_window): Update.
6206         * tui/tui-windata.h (tui_check_data_values): Don't declare.
6207         * tui/tui-windata.c (tui_display_all_data)
6208         (tui_display_data_from_line): Update.
6209         (tui_check_data_values): Remove.
6210         * tui/tui-regs.c (tui_show_register_group)
6211         (tui_display_reg_element_at_line): Update.
6212         * tui/tui-hooks.c (tui_register_changed)
6213         (tui_refresh_frame_and_register_information): Call
6214         tui_check_register_values.
6215         * tui/tui-data.h (struct tui_data_window) <data_content,
6216         data_content_count, data_type>: Remove.
6217         (enum tui_data_type): Remove.
6218
6219         * tui/tui-data.c (tui_data_window::clear_detail)
6220         (~tui_data_window): Update.
6221
6222 2019-06-25  Tom Tromey  <tom@tromey.com>
6223
6224         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
6225         declare.
6226         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
6227         Rename from tui_first_data_item_displayed.  Update.
6228         (tui_data_window::refresh_all)
6229         (tui_data_window::do_scroll_vertical): Update.
6230         * tui/tui-data.h (struct tui_data_window)
6231         <first_data_item_displayed>: Declare new method.
6232
6233 2019-06-25  Tom Tromey  <tom@tromey.com>
6234
6235         * tui/tui-data.h (tui_init_generic_part): Don't declare.
6236         * tui/tui-data.c (tui_init_generic_part): Remove, moving
6237         contents...
6238         (tui_initialize_static_data): ...here.
6239
6240 2019-06-25  Tom Tromey  <tom@tromey.com>
6241
6242         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
6243         (tui_display_registers_from, tui_check_register_values): Update.
6244         (tui_display_register): Remove win_info parameter; update.
6245         (tui_get_register): Change type of parameters.
6246         * tui/tui-data.h (struct tui_data_element): Remove.
6247         (union tui_which_element) <data>: Remove.
6248         <data_window>: Change type.
6249         (struct tui_data_item_window): New.
6250         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
6251         case.  Add assert.
6252         (~tui_data_item_window): New destructor.
6253         (free_content_elements): Remove DATA_ITEM_WIN case.
6254
6255 2019-06-25  Tom Tromey  <tom@tromey.com>
6256
6257         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
6258         Remove.
6259
6260 2019-06-25  Tom Tromey  <tom@tromey.com>
6261
6262         * tui/tui-data.h (struct tui_command_element): Remove.
6263         (union tui_which_element) <command>: Remove.
6264         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
6265         assert.
6266         (free_content_elements): Remove CMD_WIN case.
6267
6268 2019-06-25  Tom Tromey  <tom@tromey.com>
6269
6270         * tui/tui-layout.c (tui_set_layout): Update.
6271         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
6272         * tui/tui-data.c (layout_def): Update.
6273
6274 2019-06-25  Tom Tromey  <tom@tromey.com>
6275
6276         * tui/tui-wingeneral.c (tui_refresh_all): Update.
6277         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
6278         (tui_source_window_base::set_new_height): Update.
6279         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
6280         Update.
6281         (tui_set_locator_fullname, tui_set_locator_info)
6282         (tui_show_frame_info): Update.
6283         * tui/tui-source.c (tui_set_source_content)
6284         (tui_source_is_displayed): Update.
6285         * tui/tui-layout.c (show_source_disasm_command, show_data)
6286         (show_source_or_disasm_and_command): Update.
6287         * tui/tui-disasm.c (tui_set_disassem_content)
6288         (tui_get_begin_asm_address): Update.
6289         * tui/tui-data.h (struct tui_locator_element): Remove.
6290         (union tui_which_element) <locator>: Remove.
6291         (struct tui_locator_window): New.
6292         (tui_locator_win_info_ptr): Change return type.
6293         * tui/tui-data.c (_locator): Change type.
6294         (tui_locator_win_info_ptr): Change return type.
6295         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
6296         (tui_alloc_content): Add assert.
6297
6298 2019-06-25  Tom Tromey  <tom@tromey.com>
6299
6300         * tui/tui-winsource.c
6301         (tui_exec_info_window::maybe_allocate_content): New method.
6302         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
6303         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
6304         (make_source_or_disasm_window): Add cast.
6305         * tui/tui-data.h (union tui_which_element) <simple_string>:
6306         Remove.
6307         (struct tui_source_info): New.
6308         (struct tui_source_window_base) <execution_info>: Change type.
6309         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
6310         case, and add assert.
6311         (tui_alloc_content): Add assert.
6312
6313 2019-06-25  Tom Tromey  <tom@tromey.com>
6314
6315         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
6316         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
6317         * tui/tui-data.c (tui_alloc_win_info): Remove.
6318
6319 2019-06-25  Tom Tromey  <tom@tromey.com>
6320
6321         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
6322         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
6323         can_highlight.
6324
6325 2019-06-25  Tom Tromey  <tom@tromey.com>
6326
6327         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
6328         make_visible_with_new_height method.
6329         (tui_win_info::make_visible_with_new_height): New method.
6330         (tui_source_window_base::do_make_visible_with_new_height)
6331         (tui_data_window::do_make_visible_with_new_height)
6332         (tui_cmd_window::do_make_visible_with_new_height): New methods.
6333         (make_visible_with_new_height): Remove.
6334         (tui_resize_all, tui_adjust_win_heights): Use
6335         make_visible_with_new_height method.
6336         * tui/tui-data.h (struct tui_win_info)
6337         <do_make_visible_with_new_height, make_visible_with_new_height>:
6338         New methods.
6339         (struct tui_source_window_base, struct tui_data_window)
6340         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
6341         methods.
6342
6343 2019-06-25  Tom Tromey  <tom@tromey.com>
6344
6345         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
6346         method.
6347         (update_tab_width): Call update_tab_width method.
6348         * tui/tui-data.h (struct tui_win_info)
6349         (struct tui_source_window_base) <update_tab_width>: New methods.
6350
6351 2019-06-25  Tom Tromey  <tom@tromey.com>
6352
6353         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
6354         parameter.
6355         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
6356         parameter.
6357         (tui_gen_win_info::make_visible): Update.
6358         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
6359         parameter.
6360         * tui/tui-data.h (enum tui_box): New enum.
6361         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
6362
6363 2019-06-25  Tom Tromey  <tom@tromey.com>
6364
6365         * tui/tui-layout.c (make_source_or_disasm_window): Always use
6366         init_and_make_win for EXEC_INFO_WIN.
6367         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
6368         longer inline.
6369         (struct tui_win_info) <~tui_win_info>: Inline.
6370         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
6371         Don't declare.
6372         * tui/tui-data.c (source_win, disasm_win): Remove globals.
6373         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
6374         Remove.
6375         (tui_initialize_static_data): Update.
6376         (~tui_gen_win_info): Handle more cleanup here.
6377         (~tui_source_window_base): Delete "execution_info".
6378         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
6379
6380 2019-06-25  Tom Tromey  <tom@tromey.com>
6381
6382         * tui/tui-layout.c (make_command_window): Don't set
6383         can_highlight.
6384         (show_source_disasm_command): Call the reset method.
6385         (show_data): Don't set can_highlight.  Call the reset method.
6386         (tui_gen_win_info::reset): Rename from init_gen_win_info
6387         (init_and_make_win): Simplify.  Return tui_gen_win_info.
6388         (show_source_or_disasm_and_command): Call the reset method.
6389         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
6390         (struct tui_cmd_window): Set can_highlight.
6391
6392 2019-06-25  Tom Tromey  <tom@tromey.com>
6393
6394         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
6395         from make_visible.
6396         (tui_make_visible, tui_make_invisible): Rewrite.
6397         (tui_win_info::make_visible): Remove.
6398         (tui_source_window_base::make_visible): Update.
6399         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
6400         method.  Moved from...
6401         (struct tui_win_info) <make_visible>: ...here.
6402
6403 2019-06-25  Tom Tromey  <tom@tromey.com>
6404
6405         * tui/tui-winsource.c
6406         (tui_source_window_base::do_scroll_horizontal): Remove direction
6407         parameter.
6408         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
6409         direction parameter.
6410         * tui/tui-win.c (tui_win_info::forward_scroll)
6411         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
6412         (tui_win_info::right_scroll): Update.
6413         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
6414         direction parameter.
6415         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
6416         direction parameter.
6417         * tui/tui-data.h (enum tui_scroll_direction): Remove.
6418         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
6419         Remove direction parameter.
6420         (struct tui_source_window_base, struct tui_source_window)
6421         (struct tui_disasm_window, struct tui_data_window)
6422         (struct tui_cmd_window): Update.
6423
6424 2019-06-25  Tom Tromey  <tom@tromey.com>
6425
6426         * tui/tui-winsource.h (tui_set_exec_info_content)
6427         (tui_show_exec_info_content, tui_erase_exec_info_content)
6428         (tui_clear_exec_info_content, tui_update_exec_info): Change
6429         argument to tui_source_window_base.
6430         * tui/tui-winsource.c (tui_set_exec_info_content)
6431         (tui_show_exec_info_content, tui_erase_exec_info_content)
6432         (tui_clear_exec_info_content, tui_update_exec_info): Change
6433         argument to tui_source_window_base.
6434
6435 2019-06-25  Tom Tromey  <tom@tromey.com>
6436
6437         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
6438         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
6439
6440 2019-06-25  Tom Tromey  <tom@tromey.com>
6441
6442         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
6443         check.
6444
6445 2019-06-25  Tom Tromey  <tom@tromey.com>
6446
6447         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
6448         type to void.
6449         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
6450         type to void.
6451         * tui/tui-source.c (tui_set_source_content): Update.
6452         * tui/tui-disasm.c (tui_set_disassem_content): Update.
6453
6454 2019-06-25  Tom Tromey  <tom@tromey.com>
6455
6456         * tui/tui-win.c (window_name_completer, tui_set_focus)
6457         (tui_all_windows_info): Use name method.
6458         * tui/tui-data.h (struct tui_gen_win_info)
6459         (struct tui_source_window, struct tui_disasm_window)
6460         (struct tui_data_window, struct tui_cmd_window) <name>: New
6461         method.
6462         (tui_win_name): Don't declare.
6463         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
6464         (tui_win_name): Remove.
6465
6466 2019-06-25  Tom Tromey  <tom@tromey.com>
6467
6468         * tui/tui-winsource.h (tui_update_source_window)
6469         (tui_update_source_window_as_is): Change parameter type.
6470         * tui/tui-winsource.c (tui_update_source_window): Change win_info
6471         to be a tui_source_window_base.
6472         (tui_update_source_window_as_is): Likewise.
6473         * tui/tui-win.c (make_visible_with_new_height): Update.
6474
6475 2019-06-25  Tom Tromey  <tom@tromey.com>
6476
6477         * tui/tui-winsource.c (tui_erase_source_content)
6478         (tui_show_source_content, tui_show_exec_info_content)
6479         (tui_erase_exec_info_content): Use refresh_window method.
6480         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
6481         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
6482         from tui_refresh_win.
6483         (tui_data_window::refresh_window): New method.
6484         (tui_win_info::refresh, tui_source_window_base::refresh)
6485         (tui_refresh_all): Use refresh_window method.
6486         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
6487         method.
6488         * tui/tui-regs.c (tui_display_register): Call refresh_window
6489         method.
6490         * tui/tui-layout.c (show_source_disasm_command)
6491         (show_source_or_disasm_and_command): Call refresh_window method.
6492         * tui/tui-data.h (struct tui_gen_win_info)
6493         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
6494         New method.
6495
6496 2019-06-25  Tom Tromey  <tom@tromey.com>
6497
6498         * tui/tui.c (tui_rl_other_window, tui_enable)
6499         (tui_is_window_visible, tui_get_command_dimension): Update.
6500         * tui/tui-winsource.c (tui_update_source_window_as_is)
6501         (tui_clear_source_content, tui_erase_source_content)
6502         (tui_show_source_line, tui_source_window_base::refill)
6503         (tui_source_window_base::do_scroll_horizontal)
6504         (tui_source_window_base::set_is_exec_point_at)
6505         (tui_update_breakpoint_info, tui_set_exec_info_content)
6506         (tui_alloc_source_buffer, tui_line_is_displayed)
6507         (tui_addr_is_displayed): Update.
6508         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
6509         (tui_check_and_display_highlight_if_needed)
6510         (tui_win_info::make_visible, tui_win_info::refresh)
6511         (tui_refresh_all): Update.
6512         * tui/tui-windata.c (tui_first_data_item_displayed)
6513         (tui_delete_data_content_windows, tui_erase_data_content)
6514         (tui_display_all_data, tui_data_window::refresh_all)
6515         (tui_check_data_values): Update.
6516         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
6517         (tui_set_win_focus_to, tui_win_info::forward_scroll)
6518         (tui_win_info::backward_scroll, tui_refresh_all_win)
6519         (tui_resize_all, tui_set_focus, tui_all_windows_info)
6520         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
6521         (tui_source_window_base::set_new_height)
6522         (tui_data_window::set_new_height)
6523         (make_invisible_and_set_new_height)
6524         (make_visible_with_new_height, new_height_ok)
6525         (parse_scrolling_args): Update.
6526         * tui/tui-stack.c (tui_show_frame_info): Update.
6527         * tui/tui-source.c (tui_set_source_content)
6528         (tui_set_source_content_nil, tui_source_is_displayed)
6529         (tui_source_window::do_scroll_vertical): Update.
6530         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
6531         (tui_display_registers_from, tui_display_reg_element_at_line)
6532         (tui_check_register_values, tui_reg_command): Update.
6533         * tui/tui-layout.c (tui_default_win_height)
6534         (show_source_disasm_command, show_data, init_and_make_win)
6535         (show_source_or_disasm_and_command): Update.
6536         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
6537         (tui_redisplay_readline, tui_mld_flush)
6538         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
6539         (tui_getc): Update.
6540         * tui/tui-disasm.c (tui_set_disassem_content)
6541         (tui_disasm_window::do_scroll_vertical): Update.
6542         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
6543         Now virtual.
6544         (struct tui_win_info): Derive from tui_gen_win_info.
6545         <~tui_win_info>: Mark as override.
6546         <generic>: Remove member.
6547         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
6548         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
6549         (~tui_data_window, ~tui_win_info)
6550         (tui_free_all_source_wins_content): Update.
6551         * tui/tui-command.c (tui_refresh_cmd_win): Update.
6552
6553 2019-06-25  Tom Tromey  <tom@tromey.com>
6554
6555         * tui/tui-layout.c (init_and_make_win): Use new.
6556         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
6557         destructor, initializers.
6558         (tui_alloc_generic_win_info): Don't declare.
6559         * tui/tui-data.c (_locator): Add argument to constructor.
6560         (source_win, disasm_win): New globals.
6561         (exec_info): Remove.
6562         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
6563         Update.
6564         (tui_alloc_generic_win_info): Remove.
6565         (init_content_element): Use new.
6566         (tui_win_info::tui_win_info): Update.
6567         (free_content_elements) <case DATA_WIN>: Use delete.
6568
6569 2019-06-25  Tom Tromey  <tom@tromey.com>
6570
6571         * tui/tui-wingeneral.c (tui_refresh_win): Update.
6572         * tui/tui-windata.c (tui_first_data_item_displayed)
6573         (tui_delete_data_content_windows): Update.
6574         * tui/tui-win.c (tui_data_window::set_new_height): Update.
6575         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
6576         (tui_display_registers_from, tui_check_register_values): Update.
6577         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
6578         pointer.
6579         * tui/tui-data.c (init_content_element): Update.  Allocate the new
6580         window.
6581         (tui_free_data_content): Update.
6582         (free_content_elements) <case DATA_WIN>: Free the window.
6583
6584 2019-06-25  Tom Tromey  <tom@tromey.com>
6585
6586         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
6587         Update.
6588         * tui/tui-layout.c (make_command_window)
6589         (show_source_disasm_command, show_data, init_and_make_win)
6590         (show_source_or_disasm_and_command): Update.
6591         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
6592         method.
6593         <can_highight, is_highlighted>: Now bool.
6594         (tui_set_win_highlight): Don't declare.
6595         * tui/tui-data.c (tui_set_win_highlight): Remove.
6596
6597 2019-06-25  Tom Tromey  <tom@tromey.com>
6598
6599         * tui/tui-wingeneral.c (make_visible): Remove check of window
6600         type.
6601
6602 2019-06-25  Tom Tromey  <tom@tromey.com>
6603
6604         * tui/tui-win.c (tui_win_info::max_height)
6605         (tui_cmd_window::max_height): New methods.
6606         (new_height_ok): Call max_height.
6607         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
6608         <max_height>: New method.
6609
6610 2019-06-25  Tom Tromey  <tom@tromey.com>
6611
6612         * tui/tui-win.c (tui_source_window_base::set_new_height)
6613         (tui_data_window::set_new_height): New methods.
6614         (make_invisible_and_set_new_height): Call set_new_height method.
6615         * tui/tui-data.h (struct tui_win_info)
6616         (struct tui_source_window_base, struct tui_data_window)
6617         <set_new_height>: New method.
6618
6619 2019-06-25  Tom Tromey  <tom@tromey.com>
6620
6621         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
6622         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
6623         tui_refresh_data_win.
6624         * tui/tui-win.c (tui_source_window_base::refresh_all): New
6625         method.
6626         (tui_refresh_all_win): Call the refresh_all method.
6627         (tui_set_focus): Likewise.
6628         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
6629         (struct tui_source_window_base, struct tui_data_window) <refresh>:
6630         Likewise.
6631
6632 2019-06-25  Tom Tromey  <tom@tromey.com>
6633
6634         * tui/tui-winsource.h (tui_refill_source_window)
6635         (tui_set_is_exec_point_at): Don't declare.
6636         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
6637         (tui_source_window_base::refill): Rename from
6638         tui_refill_source_window.
6639         (tui_source_window_base::do_scroll_horizontal): Update.
6640         (tui_source_window_base::set_is_exec_point_at): Rename from
6641         tui_set_is_exec_point_at.
6642         (tui_update_all_breakpoint_info): Update.
6643         * tui/tui-stack.c (tui_show_frame_info): Update.
6644         * tui/tui-layout.c (show_data): Add cast.
6645         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
6646         * tui/tui-data.h (struct tui_source_window_base) <refill,
6647         set_is_exec_point_at>: New methods.
6648         (tui_source_windows, tui_add_to_source_windows): Update types.
6649         (tui_add_to_source_windows): Remove redundant declaration.
6650         * tui/tui-data.c (source_windows): Store tui_source_window_base.
6651         (tui_source_windows): Change return type.
6652         (tui_clear_source_windows_detail): Update.
6653         (tui_add_to_source_windows): Change type of parameter.
6654         (tui_free_all_source_wins_content): Update.
6655
6656 2019-06-25  Tom Tromey  <tom@tromey.com>
6657
6658         * tui/tui-wingeneral.c (tui_win_info::refresh)
6659         (tui_source_window_base::refresh): New methods.
6660         (tui_refresh_all): Call the refresh method.
6661         * tui/tui-data.h (struct tui_win_info)
6662         (struct tui_source_window_base) <refresh>: New method.
6663
6664 2019-06-25  Tom Tromey  <tom@tromey.com>
6665
6666         * tui/tui.h (tui_is_window_visible): Return bool.
6667         * tui/tui.c (tui_is_window_visible): Return bool.
6668         * tui/tui-wingeneral.c (tui_make_window, make_visible)
6669         (tui_make_visible, tui_make_invisible)
6670         (tui_win_info::make_visible)
6671         (tui_source_window_base::make_visible, make_all_visible)
6672         (tui_make_all_visible, tui_make_all_invisible): Update.
6673         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
6674         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
6675         bool.
6676         (struct tui_win_info, struct tui_source_window_base)
6677         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
6678         * tui/tui-data.c (tui_init_generic_part): Update.
6679
6680 2019-06-25  Tom Tromey  <tom@tromey.com>
6681
6682         * tui/tui-wingeneral.c (tui_win_info::make_visible)
6683         (tui_source_window_base::make_visible): New methods.
6684         (make_all_visible): Make method call.
6685         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
6686         (struct tui_source_window_base, struct tui_cmd_window): Override
6687         make_visible.
6688         (tui_win_is_source_type): Don't declare.
6689         * tui/tui-data.c (tui_win_is_source_type): Remove.
6690
6691 2019-06-25  Tom Tromey  <tom@tromey.com>
6692
6693         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
6694         NULL check.
6695
6696 2019-06-25  Tom Tromey  <tom@tromey.com>
6697
6698         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
6699         Inline constructor.  Add initializers for members.
6700         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
6701         constructors; now inline in class.
6702
6703 2019-06-25  Tom Tromey  <tom@tromey.com>
6704
6705         * tui/tui-regs.c (tui_show_registers): Update.
6706         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
6707         bool.
6708         * tui/tui-data.c (tui_data_window::clear_detail)
6709         (tui_data_window): Update.
6710
6711 2019-06-25  Tom Tromey  <tom@tromey.com>
6712
6713         * tui/tui-windata.c (tui_display_all_data)
6714         (tui_display_data_from_line, tui_display_data_from)
6715         (tui_check_data_values, tui_data_window::do_scroll_vertical):
6716         Update.
6717         * tui/tui-regs.c (tui_last_regs_line_no)
6718         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
6719         (tui_show_registers, tui_show_register_group)
6720         (tui_display_registers_from, tui_display_reg_element_at_line)
6721         (tui_display_registers_from_line, tui_check_register_values)
6722         (tui_reg_next, tui_reg_prev): Update.
6723         * tui/tui-layout.c (tui_set_layout, show_data): Update.
6724         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
6725         tui_data_window.
6726         (struct tui_win_info) <detail>: Remove.  Add new fields from
6727         tui_data_info.
6728         (TUI_DATA_WIN): Add cast.
6729         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
6730         (~tui_data_window): Simplify.
6731
6732 2019-06-25  Tom Tromey  <tom@tromey.com>
6733
6734         * tui/tui-layout.c (show_source_disasm_command)
6735         (show_source_or_disasm_and_command): Update.
6736         * tui/tui-io.c (update_cmdwin_start_line)
6737         (tui_redisplay_readline): Update.
6738         * tui/tui-data.h (struct tui_command_info): Remove.
6739         (struct tui_win_info) <detail>: Remove command_info member.
6740         (struct tui_data_window) <start_line>: New member, from
6741         tui_command_info.
6742         (TUI_CMD_WIN): Add casts.
6743
6744 2019-06-25  Tom Tromey  <tom@tromey.com>
6745
6746         * tui/tui-winsource.c (tui_update_source_window)
6747         (tui_refill_source_window)
6748         (tui_source_window_base::do_scroll_horizontal)
6749         (tui_update_breakpoint_info, tui_set_exec_info_content)
6750         (tui_show_exec_info_content, tui_erase_exec_info_content)
6751         (tui_clear_exec_info_content): Update.
6752         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
6753         Update.
6754         * tui/tui-win.c (make_invisible_and_set_new_height)
6755         (make_visible_with_new_height): Update.
6756         * tui/tui-source.c (tui_set_source_content)
6757         (tui_show_symtab_source): Update.
6758         * tui/tui-layout.c (extract_display_start_addr)
6759         (show_source_disasm_command, show_data)
6760         (make_source_or_disasm_window)
6761         (show_source_or_disasm_and_command): Update.
6762         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
6763         (tui_disasm_window::do_scroll_vertical): Remove shadowing
6764         "gdbarch".
6765         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
6766         to tui_source_window_base.
6767         (struct tui_win_info) <detail>: Remove source_info member.
6768         (struct tui_source_window_base) <has_locator>: Inline.
6769         Move contents from tui_source_info; rename has_locator member to
6770         m_has_locator.
6771         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
6772         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
6773         header file.
6774         (tui_source_window_base::clear_detail, ~tui_source_window_base):
6775         Simplify.
6776         (tui_free_all_source_wins_content): Cast to
6777         tui_source_window_base.
6778
6779 2019-06-25  Tom Tromey  <tom@tromey.com>
6780
6781         * tui/tui-win.c (make_invisible_and_set_new_height)
6782         (make_visible_with_new_height): Call has_locator method.
6783         * tui/tui-layout.c (show_source_disasm_command, show_data)
6784         (show_source_or_disasm_and_command): Update for bool change.
6785         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
6786         (tui_win_info) <has_locator>: New method.
6787         (struct tui_source_window_base) <has_locator>: New method.
6788         (tui_win_has_locator): Don't declare.
6789         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
6790         from tui_win_has_locator.
6791         (tui_source_window_base): Use false, not FALSE.
6792
6793 2019-06-25  Tom Tromey  <tom@tromey.com>
6794
6795         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
6796         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
6797         clear_detail method directly.
6798         (tui_clear_win_detail): Remove.
6799
6800 2019-06-25  Tom Tromey  <tom@tromey.com>
6801
6802         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
6803         "this", not TUI_DISASM_WIN.
6804
6805 2019-06-25  Tom Tromey  <tom@tromey.com>
6806
6807         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
6808         declare.
6809         * tui/tui-winsource.c
6810         (tui_source_window_base::do_scroll_horizontal): Rename from
6811         tui_horizontal_source_scroll.
6812         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
6813         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
6814         from tui_vertical_data_scroll.
6815         * tui/tui-win.h (tui_scroll): Don't declare.
6816         * tui/tui-win.c (tui_win_info::forward_scroll)
6817         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
6818         (tui_win_info::right_scroll): Rename and update.
6819         (tui_scroll_forward_command, tui_scroll_backward_command)
6820         (tui_scroll_left_command, tui_scroll_right_command): Update.
6821         (tui_scroll): Remove.
6822         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
6823         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
6824         from tui_vertical_source_scroll.
6825         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
6826         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
6827         from tui_vertical_disassem_scroll.
6828         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
6829         do_scroll_horizontal>: New methods.
6830         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
6831         Likewise.
6832         (struct tui_source_window_base): Add do_scroll_horizontal.
6833         (struct tui_source_window, struct tui_disasm_window): Add
6834         do_scroll_vertical.
6835         (struct tui_data_window, struct tui_cmd_window): Add
6836         do_scroll_horizontal and do_scroll_vertical.
6837         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
6838
6839 2019-06-25  Tom Tromey  <tom@tromey.com>
6840
6841         * tui/tui-data.h (struct tui_source_window_base): New struct.
6842         (struct tui_source_window): Derive from tui_source_window_base.
6843         (struct tui_disasm_window): New struct.
6844         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
6845         from tui_source_window::clear_detail.
6846         (tui_source_window_base): Rename from tui_source_window.
6847         (~tui_source_window_base): Rename from ~tui_source_window.
6848         (tui_alloc_win_info): Create a tui_disasm_window.
6849
6850 2019-06-25  Tom Tromey  <tom@tromey.com>
6851
6852         * tui/tui-data.h (struct tui_source_window)
6853         (struct tui_data_window): Declare destructors.
6854         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
6855         destructors.
6856         (tui_win_info): Simplify.
6857
6858 2019-06-25  Tom Tromey  <tom@tromey.com>
6859
6860         * tui/tui-winsource.c (tui_display_main)
6861         (tui_update_source_windows_with_addr)
6862         (tui_update_all_breakpoint_info): Update.
6863         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
6864         (new_height_ok, parse_scrolling_args): Update.
6865         * tui/tui-stack.c (tui_show_frame_info): Update.
6866         * tui/tui-data.h (struct tui_list): Remove.
6867         (tui_source_windows): Return a reference to a std::vector.
6868         * tui/tui-data.c (source_windows): Now a std::vector.
6869         (tui_source_windows): Change return type.
6870         (tui_clear_source_windows): Rewrite.
6871         (tui_clear_source_windows_detail, tui_add_to_source_windows)
6872         (tui_free_all_source_wins_content): Rewrite.
6873
6874 2019-06-25  Tom Tromey  <tom@tromey.com>
6875
6876         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
6877         (struct tui_data_window, struct tui_cmd_window): Declare
6878         clear_detail method.
6879         * tui/tui-data.c (tui_source_window::clear_detail)
6880         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
6881         methods.
6882         (tui_clear_win_detail): Simplify.
6883
6884 2019-06-25  Tom Tromey  <tom@tromey.com>
6885
6886         * tui/tui-layout.c (make_source_window, make_disasm_window)
6887         (make_source_or_disasm_window): Remove win_info_ptr parameter.
6888         Return the new window.
6889         (show_source_disasm_command, show_data)
6890         (show_source_or_disasm_and_command): Update.
6891
6892 2019-06-25  Tom Tromey  <tom@tromey.com>
6893
6894         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
6895         parameter.  Return the new window.
6896         (show_source_disasm_command): Update and remove NULL check.
6897         (show_source_or_disasm_and_command): Update.
6898
6899 2019-06-25  Tom Tromey  <tom@tromey.com>
6900
6901         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
6902
6903 2019-06-25  Tom Tromey  <tom@tromey.com>
6904
6905         * tui/tui-data.h (struct tui_win_info): Make constructor
6906         protected.  Make destructor virtual.  Add initializers.
6907         (tui_source_window, tui_data_window, tui_cmd_window): New
6908         classes.
6909         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
6910         constructor.  Add "type" parameter.
6911         (tui_source_window, tui_data_window, tui_cmd_window): New
6912         constructors.
6913         (tui_alloc_win_info): Instantiate the appropriate subclass.
6914
6915 2019-06-25  Tom Tromey  <tom@tromey.com>
6916
6917         * tui/tui-win.c (tui_resize_all): Use delete.
6918         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
6919         destructor.
6920         (tui_free_window): Don't declare.
6921         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
6922         Update.
6923
6924 2019-06-25  Tom Tromey  <tom@tromey.com>
6925
6926         * tui/tui-data.h (struct tui_win_info): Add constructor.
6927         * tui/tui-data.c (tui_alloc_win_info): Use new.
6928         (tui_free_window): Use delete.
6929
6930 2019-06-22  Tom Tromey  <tom@tromey.com>
6931
6932         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
6933         declare.
6934         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
6935
6936 2019-06-22  Tom Tromey  <tom@tromey.com>
6937
6938         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
6939         declare.
6940         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
6941
6942 2019-06-22  Tom de Vries  <tdevries@suse.de>
6943
6944         * dwarf2read.c (create_addrmap_from_aranges)
6945         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
6946         instead of '%zu'.
6947
6948 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
6949
6950         * dwarf2read.h (dwarf2_section_info_def): Remove.
6951         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
6952         * dwarf2read.c (struct dwo_sections) <types>: Change type to
6953         std::vector<dwarf2_section_info>.
6954         (struct dwo_file) <~dwo_file>: Remove.
6955         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
6956         types field.
6957         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
6958         (dwarf2_read_debug_names): Likewise.
6959         (create_debug_types_hash_table): Change parameter type to
6960         array_view, adjust code accordingly.
6961         (dwarf2_locate_dwo_sections): Adjust to std::vector.
6962         (partial_die_info::fixup): Likewise.
6963         (determine_prefix): Likewise.
6964         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
6965
6966 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
6967
6968         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
6969         gdb_bfd_ref_ptr.
6970         <~dwo_file>: Remove call to gdb_bfd_unref.
6971         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
6972         gdb_bfd_ref_ptr::get.
6973
6974 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
6975
6976         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
6977         type to htab_up.
6978         * dwarf2read.c (struct dwo_file): Initialize fields.
6979         <~dwo_file>: New.
6980         (free_dwo_file): Remove, move content to ~dwo_file.
6981         (struct dwo_file_deleter): Remove.
6982         (dwo_file_up>: Remove custom deleter.
6983         (free_dwo_files): Remove.
6984         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
6985         dwo_files.
6986         (process_skeletonless_type_units): Call unique_ptr::get.
6987         (allocate_dwo_file_hash_table): Add deleter to created hash
6988         table.  Change return type to htab_up.
6989         (lookup_dwo_file_slot): Don't memset dwo_file, call
6990         unique_ptr::get.
6991         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
6992         (create_dwo_unit_in_dwp_v2): Likewise.
6993         (open_and_init_dwo_file): Likewise.
6994         (free_dwo_file_from_slot): Remove.
6995
6996 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
6997
6998         * dwarf2read.h (struct dwarf2_section_info) <readin,
6999         is_virtual>: Change type to bool.
7000         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
7001         true instead of 1.
7002
7003 2019-06-19  Tom Tromey  <tom@tromey.com>
7004
7005         * tui/tui-data.h (tui_init_content_element): Don't declare.
7006
7007 2019-06-19  Tom Tromey  <tom@tromey.com>
7008
7009         * tui/tui-data.h (tui_init_win_info): Don't declare.
7010
7011 2019-06-19  Tom de Vries  <tdevries@suse.de>
7012
7013         * dwarf2read.h (abstract_to_concrete): Change type to
7014         std::unordered_map<sect_offset, std::vector<sect_offset>,
7015         gdb::hash_enum<sect_offset>>.
7016
7017 2019-06-19  Tom Tromey  <tromey@adacore.com>
7018
7019         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
7020         EVAL_AVOID_SIDE_EFFECTS specially.
7021
7022 2019-06-19  Tom Tromey  <tromey@adacore.com>
7023
7024         * source-cache.c (highlighter): New global.
7025         (source_cache::get_source_lines): Create a highlighter on demand.
7026
7027 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
7028
7029         * defs.h (deprecated_interactive_hook): Delete declaration.
7030         * interps.c (clear_interpreter_hooks): Remove use of
7031         deprecated_interactive_hook.
7032         * top.c (deprecated_interactive_hook): Delete definition.
7033         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
7034
7035 2019-06-18  Tom de Vries  <tdevries@suse.de>
7036
7037         PR gdb/24515
7038         * dwarf2read.h (abstract_to_concrete): Change type from
7039         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
7040         std::unordered_map<sect_offset, std::vector<sect_offset>>.
7041         * dwarf2read.c (read_variable): Update.
7042         (dwarf2_fetch_die_loc_sect_off): Update.
7043
7044 2019-06-17  Tom de Vries  <tdevries@suse.de>
7045
7046         PR gdb/24617
7047         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
7048         accessing parent[parent_len - 1].
7049
7050 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
7051
7052         PR gdb/24364
7053         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
7054         call dtrace_process_dof with NULL dof.
7055
7056 2019-06-16  Tom de Vries  <tdevries@suse.de>
7057
7058         PR gdb/24445
7059         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
7060
7061 2019-06-16  Tom Tromey  <tom@tromey.com>
7062
7063         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
7064         (make_all_visible): Use address of member.
7065
7066 2019-06-16  Tom Tromey  <tom@tromey.com>
7067
7068         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
7069         (tui_free_window, free_content, free_content_elements): Remove
7070         unnecessary cast.
7071         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
7072         cast.
7073         * tui/tui-regs.c (tui_show_register_group)
7074         (tui_display_registers_from, tui_display_reg_element_at_line):
7075         Remove unnecessary cast.
7076
7077 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
7078
7079         * linux-nat.c (normal_mask): Delete.
7080         (_initialize_linux_nat): Don't initialise normal_mask.
7081
7082 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
7083
7084         PR gdb/24445
7085         * dwarf-index-write.h (write_psymtabs_to_index): Add
7086         dwz_basename parameter.
7087         * dwarf-index-write.c (write_gdbindex): Move file writing to
7088         write_gdbindex_1.  Change return type void.
7089         (assert_file_size): Move up, remove filename parameter.
7090         (write_gdbindex_1): New function.
7091         (write_debug_names): Change return type to void, call
7092         assert_file_size.
7093         (struct index_wip_file): New struct.
7094         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
7095         file logic to index_wip_file.  Write index for dwz file if
7096         needed.
7097         (save_gdb_index_command): Pass basename of dwz file, if present.
7098         * dwarf-index-cache.c (index_cache::store): Obtain and pass
7099         build-id of dwz file, if present.
7100         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
7101         (dwarf2_get_dwz_file): Likewise.
7102         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
7103         (dwarf2_get_dwz_file): Likewise.
7104
7105 2019-06-16  Tom Tromey  <tom@tromey.com>
7106
7107         * coffread.c (process_coff_symbol): Use xstrdup.
7108         * value.c (create_internalvar): Use xstrdup.
7109
7110 2019-06-16  Tom Tromey  <tom@tromey.com>
7111
7112         * valops.c (value_cast, value_slice): Remove unnecessary cast.
7113         * breakpoint.c (stopin_command, stopat_command)
7114         (until_break_command, decode_location_default): Remove unnecessary
7115         cast.
7116         * utils.c (subset_compare): Remove unnecessary cast.
7117         * ada-lang.c (ada_update_initial_language): Remove unnecessary
7118         cast.
7119         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
7120         cast.
7121         * infcmd.c (path_command): Remove unnecessary cast.
7122         * coffread.c (decode_type): Remove unnecessary cast.
7123         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
7124         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
7125         * tui/tui-stack.c (tui_show_locator_content)
7126         (tui_show_frame_info): Remove unnecessary cast.
7127         * tui/tui-win.c (tui_scroll_forward_command)
7128         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
7129         (parse_scrolling_args): Remove unnecessary cast.
7130         * tui/tui-data.c (init_win_info, tui_del_window)
7131         (tui_free_window, tui_del_data_windows, tui_free_data_content)
7132         (free_content_elements): Remove unnecessary cast.
7133         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
7134         unnecessary cast.
7135         * tui/tui-source.c (tui_set_source_content)
7136         (tui_vertical_source_scroll): Remove unnecessary cast.
7137         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
7138         cast.
7139         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
7140         * tui/tui-regs.c (tui_display_registers_from)
7141         (tui_display_register): Remove unnecessary cast.
7142         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
7143         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
7144         (make_visible): Remove unnecessary cast.
7145         * tui/tui-winsource.c (tui_erase_source_content)
7146         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
7147         unnecessary cast.
7148         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
7149         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
7150         * stabsread.c (read_type, read_array_type, read_range_type):
7151         Remove unnecessary cast.
7152         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
7153         (parse_symbol, parse_type, upgrade_type, parse_external)
7154         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
7155         unnecessary cast.
7156         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
7157
7158 2019-06-16  Tom Tromey  <tom@tromey.com>
7159
7160         * tui/tui-data.c (tui_alloc_generic_win_info)
7161         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
7162         checks.
7163
7164 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
7165             Andrew Burgess  <andrew.burgess@embecosm.com>
7166
7167         * f-typeprint.c (f_print_type): Don't return early for not
7168         associated or not allocated types.
7169         (f_type_print_varspec_suffix): Add print_rank parameter and print
7170         ranks of array types in case they dangling.
7171         (f_type_print_base): Add print_rank parameter.
7172
7173 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
7174
7175         * NEWS: Mention new MI commands.
7176         * break-catch-throw.c (enum exception_event_kind): Move to
7177         breakpoint.h.
7178         (print_mention_exception_catchpoint): Output text as a single
7179         message.
7180         (catch_exception_command_1): Rename to...
7181         (catch_exception_event): ...this, make non-static, update header
7182         command, and change some parameter types.
7183         (catch_catch_command): Update for changes to
7184         catch_exception_command_1.
7185         (catch_throw_command): Likewise.
7186         (catch_rethrow_command): Likewise.
7187         * breakpoint.c (enum exception_event_kind): Delete.
7188         * breakpoint.h (enum exception_event_kind): Moved here from
7189         break-catch-throw.c.
7190         (catch_exception_event): Declare.
7191         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
7192         (mi_cmd_catch_throw): New function.
7193         (mi_cmd_catch_rethrow): New function.
7194         (mi_cmd_catch_catch): New function.
7195         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
7196         'catch-catch' entries.
7197         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
7198         (mi_cmd_catch_rethrow): Declare.
7199         (mi_cmd_catch_catch): Declare.
7200
7201 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
7202
7203         * annotate.c (annotate_source_line): Change return type to void,
7204         update implementation to match.
7205         * annotate.h (annotate_source_line): Change return type to void,
7206         update header comment.
7207         * stack.c (print_frame_info): Don't change what frame information
7208         is printed based on whether annotations are on or not.
7209
7210 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
7211
7212         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
7213         (annotate_source): Make static.
7214         (annotate_source_line): Moved from source.c and renamed from
7215         identify_source_line.  Update the return type.
7216         * annotate.h (annotate_source): Delete declaration.
7217         (annotate_source_line): Declaration moved from source.h, and
7218         renamed from identify_source_line.  Return type updated.
7219         * source.c (identify_source_line): Moved to annotate.c and renamed
7220         to annotate_source_line.
7221         (info_line_command): Remove check of annotation_level.
7222         * source.h (identify_source_line): Move declaration to annotate.h
7223         and rename to annotate_source_line.
7224         * stack.c: Add 'annotate.h' include.
7225         (print_frame_info): Remove check of annotation_level before
7226         calling annotate_source_line.
7227
7228 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
7229
7230         * source-cache.c (source_cache::get_plain_source_lines): Use
7231         open_source_file_with_line_charpos instead of just
7232         open_source_file, remove call to find_source_lines.
7233         (source_cache::get_source_lines): Likewise.
7234         * source.c (find_source_lines): Make static.
7235         (get_filename_and_charpos): Renamed into...
7236         (open_source_file_with_line_charpos): ..this along with changes to
7237         return a scoped_fd, and some other minor clean ups.
7238         (identify_source_line): Use open_source_file_with_line_charpos.
7239         (search_command_helper): Use open_source_file_with_line_charpos
7240         instead of just open_source_file, remove call to
7241         find_source_lines.
7242         * source.h (open_source_file_with_line_charpos): Declare new
7243         function.
7244         (find_source_lines): Delete declaration.
7245
7246 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
7247
7248         * source.c (get_filename_and_charpos): Remove fullname
7249         parameter.
7250         (identify_source_line): Update call to get_filename_and_charpos.
7251
7252 2019-06-14  Tom Tromey  <tromey@adacore.com>
7253
7254         PR gdb/24502:
7255         * ui-style.h (skip_ansi_escape): Update comment.
7256         * ui-file.h (class no_terminal_escape_file): New class.
7257         * ui-file.c (no_terminal_escape_file::write)
7258         (no_terminal_escape_file::puts): New methods.
7259         * cli/cli-logging.c (handle_redirections): Use
7260         no_terminal_escape_file.
7261
7262 2019-06-14  Tom Tromey  <tromey@adacore.com>
7263
7264         * NEWS: Move convenience variable news above Python news.
7265
7266 2019-06-14  Tom Tromey  <tom@tromey.com>
7267
7268         * gnulib: Move directory to top-level.
7269         * configure.ac: Don't configure gnulib.
7270         * configure: Rebuild.
7271         * common/common-defs.h: Use new path to gnulib.
7272         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
7273         (GNULIB_H): Remove.
7274         (INCGNU): Look in new gnulib location.
7275         (HFILES_NO_SRCDIR): Remove gnulib files.
7276         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
7277         (generated_files): Remove GNULIB_H.
7278         ($(LIBGNU), all-lib): Remove targets.
7279         (distclean): Don't mention GNULIB_BUILDDIR.
7280         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
7281
7282 2019-06-14  Tom Tromey  <tromey@adacore.com>
7283
7284         * symfile.c (add_symbol_file_command): Remove obsolete comment.
7285         Warn if symbol file does not provide any symbols.
7286
7287 2019-06-14  Tom Tromey  <tromey@adacore.com>
7288
7289         * source.c (find_and_open_source): Respect basenames_may_differ.
7290
7291 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
7292
7293         * annotate.c (annotate_breakpoints_invalid): Make use of
7294         scoped_restore_terminal_state.
7295         (annotate_frames_invalid): Likewise.
7296
7297 2019-06-14  Tom Tromey  <tromey@adacore.com>
7298
7299         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
7300         allow assignment to an internalvar.
7301
7302 2019-06-14  Tom Tromey  <tromey@adacore.com>
7303
7304         * ada-lex.l: Allow "_" in attribute names.
7305
7306 2019-06-14  Tom Tromey  <tromey@adacore.com>
7307
7308         PR gdb/24653:
7309         * regcache.c (registers_changed): Don't call alloca.
7310         * top.c (execute_command): Don't call alloca.
7311
7312 2019-06-13  Pedro Alves  <palves@redhat.com>
7313
7314         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
7315         'expression'.  When parsing an expression, error out if there's
7316         junk after "unlimited".
7317         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
7318         (do_set_command): Adjust calls to is_unlimited_literal.
7319
7320 2019-06-13  Pedro Alves  <palves@redhat.com>
7321
7322         * compile/compile.c (make_compile_options_def_group): Add braces
7323         around array_view initializer.
7324         * thread.c (make_thread_apply_all_options_def_group)
7325         (make_thread_apply_all_options_def_group): Likewise.
7326
7327 2019-06-13  Pedro Alves  <palves@redhat.com>
7328
7329         * NEWS (New commands): Mention "maint test-options
7330         require-delimiter", "maint test-options unknown-is-error", "maint
7331         test-options unknown-is-operand" and "maint show
7332         test-options-completion-result".
7333         (New command options, command completion): New section.
7334         (Completion improvements): New section.
7335         Mention that you can abbreviate "unlimited".
7336
7337 2019-06-13  Pedro Alves  <palves@redhat.com>
7338
7339         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
7340         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
7341         * unittests/cli-utils-selftests.c (test_parse_flags)
7342         (test_parse_flags_qcs): Delete.
7343         (test_cli_utils): Don't call deleted functions.
7344
7345 2019-06-13  Pedro Alves  <palves@redhat.com>
7346
7347         * thread.c: Include "cli/cli-option.h".
7348         (tp_array_compar_ascending): Global.
7349         (tp_array_compar): Delete function.
7350         (tp_array_compar_ascending, tp_array_compar_descending): New
7351         functions.
7352         (ascending_option_def, qcs_flag_option_def)
7353         (thr_qcs_flags_option_defs)
7354         (make_thread_apply_all_options_def_group)
7355         (make_thread_apply_options_def_group): New.
7356         (thread_apply_all_command): Use gdb::option::process_options.
7357         (thread_apply_command_completer)
7358         (thread_apply_all_command_completer): New.
7359         (thread_apply_command): Use gdb::option::process_options.
7360         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
7361         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
7362         to generate help text of "thread apply".  Adjust "taas"'s help.
7363         * tid-parse.c (tid_range_parser::in_thread_range): New method.
7364         * tid-parse.h (tid_range_parser::in_thread_range): New method.
7365
7366 2019-06-13  Pedro Alves  <palves@redhat.com>
7367
7368         * thread.c (thread_apply_command): Check for invalid TID with
7369         isdigit instead of !isalpha.
7370
7371 2019-06-13  Pedro Alves  <palves@redhat.com>
7372
7373         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
7374         (validate_flags_qcs): New.
7375         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
7376         (validate_flags_qcs): Declare.
7377         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
7378         (make_frame_apply_options_def_group): New.
7379         (frame_apply_command_count): Process options with
7380         gdb::option::process_options.
7381         (frame_apply_completer): New.
7382         (frame_apply_level_completer, frame_apply_all_completer)
7383         (frame_apply_completer): New.
7384         (_initialize_stack): Update help of "frame apply", "frame apply
7385         level", "frame apply all" and "faas" to mention supported options
7386         and install command completers.
7387         * stack.h (frame_apply_all_completer): Declare.
7388         * thread.c: Include "stack.h".
7389         (tfaas_command): Add "--".
7390         (_initialize_thread): Update help "tfaas" to mention supported
7391         options and install command completer.
7392
7393 2019-06-13  Pedro Alves  <palves@redhat.com>
7394
7395         * completer.c (complete_nested_command_line): New.
7396         (gdb_completion_word_break_characters_throw): Add assertion.
7397         * completer.h (complete_nested_command_line): Declare.
7398
7399 2019-06-13  Pedro Alves  <palves@redhat.com>
7400
7401         * stack.c (parse_backtrace_qualifiers): New.
7402         (backtrace_command): Use it.
7403         (backtrace_command_completer): Complete on qualifiers.
7404
7405 2019-06-13  Pedro Alves  <palves@redhat.com>
7406
7407         * frame.c: Include "cli/cli-option.h.
7408         (user_set_backtrace_options): New.
7409         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
7410         Delete.
7411         (get_prev_frame): Adjust.
7412         (boolean_option_def, uinteger_option_def)
7413         (set_backtrace_option_defs): New.
7414         (_initialize_frame): Adjust and use
7415         gdb::option::add_setshow_cmds_for_options to install "set
7416         backtrace past-main" and "set backtrace past-entry".
7417         * frame.h: Include "cli/cli-option.h".
7418         (struct frame_print_options): Forward declare.
7419         (print_frame_arguments_all, print_frame_arguments_scalars)
7420         (print_frame_arguments_none): Declare.
7421         (print_entry_values): Delete declaration.
7422         (struct frame_print_options, user_frame_print_options): New.
7423         (struct set_backtrace_options): New.
7424         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
7425         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
7426         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
7427         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
7428         (list_args_or_locals): Add frame_print_options parameter.
7429         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
7430         * python/py-framefilter.c (enumerate_args): Pass down
7431         USER_FRAME_PRINT_OPTIONS.
7432         * stack.c: Include "cli/cli-option.h".
7433         (print_frame_arguments_all, print_frame_arguments_scalars)
7434         (print_frame_arguments_none): Declare.
7435         (print_raw_frame_arguments, print_entry_values): Delete.
7436         (user_frame_print_options): New.
7437         (boolean_option_def, enum_option_def, frame_print_option_defs):
7438         New.
7439         (struct backtrace_cmd_options): New.
7440         (bt_flag_option_def): New.
7441         (backtrace_command_option_defs): New.
7442         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
7443         (print_frame_arg, read_frame_arg, print_frame_args)
7444         (print_frame_info, print_frame): Add frame_print_options parameter
7445         and use it.
7446         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
7447         (backtrace_command_1): Add frame_print_options and
7448         backtrace_cmd_options parameters and use them.
7449         (make_backtrace_options_def_group): New.
7450         (backtrace_command): Process command options with
7451         gdb::option::process_options.
7452         (backtrace_command_completer): New.
7453         (_initialize_stack): Extend "backtrace"'s help to mention
7454         supported options.  Install completer for "backtrace".
7455         Install some settings commands with add_setshow_cmds_for_options.
7456
7457 2019-06-13  Pedro Alves  <palves@redhat.com>
7458
7459         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
7460         and that "set/show print raw frame-arguments" are now deprecated.
7461
7462         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
7463         command.
7464         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
7465         * stack.c (_initialize_stack): Install "set/show print
7466         raw-frame-arguments", and deprecate "set/show print raw
7467         frame-arguments".
7468         * valprint.c (_initialize_valprint): Deprecate "set/show print
7469         raw".
7470
7471 2019-06-13  Pedro Alves  <palves@redhat.com>
7472
7473         * compile/compile.c (struct compile_options): New.
7474         (compile_flag_option_def, compile_command_option_defs)
7475         (make_compile_options_def_group): New.
7476         (compile_file_command): Handle options with
7477         gdb::option::process_options.
7478         (compile_file_command_completer): New function.
7479         (compile_code_command): Handle options with
7480         gdb::option::process_options.
7481         (compile_code_command_completer): New function.
7482         (_initialize_compiler): Install completers for "compile code" and
7483         "compile file".  Mention available options in "compile code" and
7484         "compile code"'s help.
7485         * completer.c (advance_to_completion_word): New, factored out from
7486         ...
7487         (advance_to_expression_complete_word_point): ... this.
7488         (advance_to_filename_complete_word_point): New.
7489         * completer.h (advance_to_filename_complete_word_point): New
7490         declaration.
7491
7492 2019-06-13  Pedro Alves  <palves@redhat.com>
7493
7494         * compile/compile.c: Include "cli/cli-option.h".
7495         (compile_print_value): Scope data pointer is now a
7496         value_print_options pointer; adjust.
7497         (compile_print_command): Process options.  Scope data pointer is
7498         now a value_print_options pointer; adjust.
7499         (_initialize_compile): Update "compile print"'s help to include
7500         supported options.  Install a completer for "compile print".
7501         * cp-valprint.c (show_vtblprint, show_objectprint)
7502         (show_static_field_print): Delete.
7503         (_initialize_cp_valprint): Don't install "set print
7504         static-members", "set print vtbl", "set print object" here.
7505         * printcmd.c: Include "cli/cli-option.h" and
7506         "common/gdb_optional.h".
7507         (print_command_parse_format): Rework to fill in a
7508         value_print_options instead of a format_data.
7509         (print_value): Change parameter type from format_data pointer to
7510         value_print_options reference.  Adjust.
7511         (print_command_1): Process options.  Adjust to pass down a
7512         value_print_options.
7513         (print_command_completer): New.
7514         (_initialize_printcmd): Install print_command_completer as
7515         handle_brkchars completer for the "print" command.  Update
7516         "print"'s help to include supported options.
7517         * valprint.c: Include "cli/cli-option.h".
7518         (show_vtblprint, show_objectprint, show_static_field_print): Moved
7519         here from cp-valprint.c.
7520         (boolean_option_def, uinteger_option_def)
7521         (value_print_option_defs, make_value_print_options_def_group):
7522         New.  Use gdb::option::add_setshow_cmds_for_options to install
7523         "set print elements", "set print null-stop", "set print repeats",
7524         "set print pretty", "set print union", "set print array", "set
7525         print address", "set print symbol", "set print array-indexes".
7526         * valprint.h: Include <string> and "cli/cli-option.h".
7527         (make_value_print_options_def_group): Declare.
7528         (print_value): Change parameter type from format_data pointer to
7529         value_print_options reference.
7530         (print_command_completer): Declare.
7531
7532 2019-06-13  Pedro Alves  <palves@redhat.com>
7533
7534         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
7535         (COMMON_SFILES): Add maint-test-settings.c.
7536         * cli/cli-decode.c (boolean_enums): New global, factored out from
7537         ...
7538         (add_setshow_boolean_cmd): ... here.
7539         * cli/cli-decode.h (boolean_enums): Declare.
7540         * cli/cli-option.c: New file.
7541         * cli/cli-option.h: New file.
7542         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
7543         factored out from ...
7544         (parse_cli_boolean_value(const char *)): ... this.
7545         (is_unlimited_literal): Change parameter type to pointer to
7546         pointer.  Adjust and advance ARG pointer.
7547         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
7548         (parse_cli_var_enum): New, factored out from ...
7549         (do_set_command): ... this.  Adjust.
7550         * cli/cli-setshow.h (parse_cli_boolean_value)
7551         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
7552         (parse_cli_var_enum): Declare.
7553         * cli/cli-utils.c: Include "cli/cli-option.h".
7554         (get_ulongest): New.
7555         * cli/cli-utils.h (get_ulongest): Declare.
7556         (check_for_argument): New overloads.
7557         * maint-test-options.c: New file.
7558
7559 2019-06-13  Pedro Alves  <palves@redhat.com>
7560
7561         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
7562         parse a range if "-" is at the end of the string.
7563
7564 2019-06-13  Pedro Alves  <palves@redhat.com>
7565
7566         * cli/cli-setshow.c (parse_auto_binary_operation)
7567         (parse_cli_boolean_value): Don't allow "o".
7568
7569 2019-06-13  Pedro Alves  <palves@redhat.com>
7570
7571         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
7572         * NEWS: Mention maint test-settings KIND.
7573         * maint-test-settings.c: New file.
7574
7575 2019-06-13  Pedro Alves  <palves@redhat.com>
7576
7577         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
7578         completer.
7579         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
7580         "set" completers.
7581
7582 2019-06-13  Pedro Alves  <palves@redhat.com>
7583
7584         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
7585         after item.
7586
7587 2019-06-13  Pedro Alves  <palves@redhat.com>
7588
7589         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
7590
7591 2019-06-13  Pedro Alves <palves@redhat.com>
7592
7593         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
7594         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
7595         call.
7596         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
7597         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
7598         calls.
7599         (check_for_argument): Skip spaces after argument.
7600
7601 2019-06-13  Pedro Alves  <palves@redhat.com>
7602
7603         * thread.c (thread_apply_command): Adjust TID parsing.
7604         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
7605         detected before end of string.
7606         (tid_is_in_list): Error out if LIST is invalid.
7607
7608 2019-06-13  Pedro Alves  <palves@redhat.com>
7609
7610         * completer.c (complete_line_internal_1): Rewind completion word
7611         point.
7612         (completion_tracker::advance_custom_word_point_by): Change
7613         parameter type to int.
7614         * completer.h (completion_tracker::advance_custom_word_point_by):
7615         Likewise.
7616
7617 2019-06-13  Pedro Alves  <palves@redhat.com>
7618
7619         * completer.c (advance_to_completion_word): Handle delimiters.
7620
7621 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
7622
7623         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
7624
7625 2019-06-11  Tom Tromey  <tom@tromey.com>
7626
7627         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
7628         (xmalloc_failed): Move to alloc.c.
7629         * alloc.c: New file.
7630         * Makefile.in (COMMON_SFILES): Add alloc.c.
7631
7632 2019-06-11  Tom Tromey  <tom@tromey.com>
7633
7634         * nat/linux-waitpid.c: Don't include server.h.
7635         (linux_debug): Remove.
7636         (my_waitpid): Update.
7637
7638 2019-06-11  Tom Tromey  <tromey@adacore.com>
7639
7640         * infcall.c (_initialize_infcall): Remove trailing newline from
7641         help.
7642         * user-regs.c (_initialize_user_regs): Remove trailing newline
7643         from help.
7644         * typeprint.c (_initialize_typeprint): Remove trailing newline
7645         from help.
7646         * reverse.c (_initialize_reverse): Remove trailing newlines from
7647         help.
7648         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
7649         from help.
7650         * language.c (add_set_language_command): Remove trailing newline
7651         from help.
7652         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
7653         help.
7654         * disasm.c (_initialize_disasm): Remove trailing newline from
7655         help.
7656         * top.c (init_main): Remove trailing newline from help.
7657         * interps.c (_initialize_interpreter): Remove trailing newline
7658         from help.
7659         * btrace.c (_initialize_btrace): Remove trailing newlines from
7660         help.
7661         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
7662         from help.
7663         * python/python.c (_initialize_python): Remove trailing newline
7664         from help.
7665         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
7666         help.
7667         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
7668         from help.  Reformat some text.
7669         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
7670         from help.
7671         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
7672         newline from help.
7673
7674 2019-06-11  Tom Tromey  <tromey@adacore.com>
7675
7676         * darwin-nat.c (darwin_decode_exception_message)
7677         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
7678
7679 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
7680
7681         * valops.c (value_slice): Check for not allocated or not
7682         associated values.
7683
7684 2019-06-10  Tom de Vries  <tdevries@suse.de>
7685
7686         PR gdb/24618
7687         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
7688         sure an empty slot (defined by a 32-bit zero pair) is recognized as
7689         invalid.
7690
7691 2019-06-10  Tom de Vries  <tdevries@suse.de>
7692
7693         PR gdb/24611
7694         * linespec.c (linespec_lexer_lex_string): Remove incorrect
7695         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
7696
7697 2019-06-10  Tom de Vries  <tdevries@suse.de>
7698
7699         PR symtab/24545
7700         * symtab.c (struct demangled_name_entry): Add language field.
7701         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
7702         static minimal symbol".  Set and use language field.
7703
7704 2019-06-10  Tom Tromey  <tromey@adacore.com>
7705
7706         * ada-lang.c (_initialize_ada_language): Update help text.
7707
7708 2019-06-10  Tom Tromey  <tromey@adacore.com>
7709
7710         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
7711         with a newline.
7712         * guile/guile.c (handle_boot_error): Don't end warning with a
7713         newline.
7714         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
7715         warning with a newline.
7716         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
7717         newline.
7718         (s12z_frame_cache): Likewise.
7719         * dwarf-index-cache.c (index_cache::store): Don't end warning with
7720         a newline.
7721         * solib-svr4.c (disable_probes_interface): Don't end warning with
7722         a newline.
7723         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
7724         newline.
7725         * python/python.c (do_finish_initialization): Don't end warning
7726         with a newline.
7727
7728 2019-06-10  Tom Tromey  <tom@tromey.com>
7729
7730         * python/py-breakpoint.c (gdbpy_breakpoint_created)
7731         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
7732         gdbpy_enter.
7733
7734 2019-06-10  Tom Tromey  <tromey@adacore.com>
7735
7736         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
7737         data.
7738         (elf_new_init): Don't call stabsread_new_init.
7739         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
7740         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
7741         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
7742
7743 2019-06-10  Tom de Vries  <tdevries@suse.de>
7744
7745         PR symtab/16264
7746         PR symtab/24517
7747         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
7748
7749 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
7750
7751         * source.c (find_and_open_source): Also rewrite relative file
7752         names.
7753
7754 2019-04-26  Amos Bird  <amosbird@gmail.com>
7755
7756         * annotate.c (annotate_thread_exited): Add "thread-exited"
7757         annotation.
7758
7759 2019-06-06  Tom Tromey  <tromey@adacore.com>
7760
7761         * maint.h (class scoped_command_stats): Use
7762         DISABLE_COPY_AND_ASSIGN.
7763         <print_time>: New method.
7764         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
7765         print_time.
7766         (scoped_command_stats::print_time): New method.
7767
7768 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
7769
7770         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
7771         instructions of lengths 6 or 8 bytes.
7772
7773 2019-06-04  Pedro Alves  <palves@redhat.com>
7774
7775         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
7776
7777         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
7778         * breakpoint.c (condition_completer): Likewise.
7779         * cli/cli-dump.c (scan_expression): Likewise.
7780         * common/filestuff.c (mkdir_recursive): Likewise.
7781         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
7782         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
7783         (gdb_abspath): Likewise.
7784         * compile/compile-cplus-types.c
7785         (compile_cplus_instance::decl_name): Likewise.
7786         * completer.c (complete_explicit_location):
7787         (signal_completer, reg_or_group_completer_1): Likewise.
7788         * cp-support.c (cp_remove_params_if_any): Likewise.
7789         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
7790         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
7791         * infcmd.c (strip_bg_char): Likewise.
7792         * linespec.c (copy_token_string): Likewise.
7793         * mi/mi-main.c (output_cores): Likewise.
7794         * psymtab.c (psymtab_search_name):
7795         * symfile.c (test_set_ext_lang_command): Likewise.
7796         * target.c (target_fileio_read_stralloc): Likewise.
7797         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
7798         * value.c (complete_internalvar): Likewise.
7799
7800 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
7801
7802         Add objfile property to gdb.Type.
7803         * NEWS: Mention Python API addition.
7804         * python/py-type.c (typy_get_objfile): New method.
7805
7806 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7807
7808         * NEWS: Mention the new set|show style [title|highlight].
7809         Mention changes to "show style", "help" and "apropos".
7810
7811 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7812
7813         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
7814         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
7815         instead of print_help_for_command.
7816         (print_doc_of_command): New function.
7817         (help_list): Add 'apropos -v word' suggestion.
7818         (print_help_for_command): Style the command name using title style.
7819         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
7820         (_initialize_cli_cmds): Describe -v in apropos_command help.
7821
7822 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7823
7824         * cli/cli-style.h (cli_style_option): Add name in constructor,
7825         add m_name class member, add constructor with intensity,
7826         add name class function.
7827         (cli_style_option::add_setshow_commands): Remove name argument.
7828         (highlight_style, title_style): New styles.
7829         * cli/cli-style.c (do_show): New function that shows a style
7830         characteristic styling the style name with itself.
7831         (set_style_name): New function.
7832         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
7833         Update all callers according to the changes in cli/cli-style.h.
7834         * utils.h (fputs_highlighted): New function.
7835         * utils.c (fputs_highlighted): Likewise.
7836
7837 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7838
7839         * NEWS: Mention new pipe command and new convenience variables.
7840
7841 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7842
7843         * cli/cli-cmds.c (pipe_command): New function.
7844         (_initialize_cli_cmds): Call add_com for pipe_command.
7845         Define | as an alias for pipe.
7846         (exit_status_set_internal_vars): New function.
7847         (shell_escape): Call exit_status_set_internal_vars.
7848         cli/cli-decode.c (find_command_name_length): Recognize | as
7849         a single character command.
7850
7851 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7852
7853         * gdbcmd.h (execute_command_to_ui_file): New declaration.
7854         top.c (execute_command_to_ui_file): New function, mostly a copy
7855         of execute_command_to_string.
7856         (execute_command_to_string): Implement by calling
7857         execute_command_to_ui_file.
7858
7859 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7860
7861         * top.h (saved_command_line): Remove declaration.
7862         * top.c (previous_saved_command_line, previous_repeat_arguments):
7863         New variables.
7864         (saved_command_line): Make static, define together with other
7865         'repeat variables'.
7866         (dont_repeat): Clear repeat_arguments.
7867         (repeat_previous, get_saved_command_line, save_command_line):
7868         New functions.
7869         (gdb_init): Initialize saved_command_line
7870         and previous_saved_command_line.
7871         * main.c (captured_main_1): Remove saved_command_line initialization.
7872         * event-top.c (handle_line_of_input): Update to use
7873         the new 'repeat' related functions instead of direct access to
7874         saved_command_line.
7875         * command.h (repeat_previous, get_saved_command_line,
7876         save_command_line): New declarations.
7877         (dont_repeat): Add comment.
7878
7879 2019-05-30  Tom Tromey  <tromey@adacore.com>
7880
7881         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
7882         Fix comment.
7883         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
7884
7885 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
7886
7887         PR cli/24587
7888         * completer.c (complete): Initialize variable word.
7889
7890 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
7891
7892         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
7893         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
7894         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
7895         'body' is NULL to the outter 'if', protecting the '!is_define'
7896         situation as well.
7897
7898 2019-05-29  Tom Tromey  <tromey@adacore.com>
7899
7900         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
7901         (dwarf_unknown): New function.
7902         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
7903         (dwarf_type_encoding_name): Use dwarf_unknown.
7904
7905 2019-05-29  Tom Tromey  <tromey@adacore.com>
7906
7907         PR c++/20020:
7908         * cp-valprint.c (cp_print_value_fields): Call
7909         cp_print_static_field inside "try".
7910
7911 2019-05-29  Tom Tromey  <tromey@adacore.com>
7912
7913         * inflow.c (struct terminal_info): Add default operator=.
7914         * configure: Rebuild.
7915         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
7916         -Wdeprecated-copy-dtor, -Wredundant-move.
7917
7918 2019-05-29  Tom Tromey  <tromey@adacore.com>
7919
7920         * NEWS: Add entry.
7921         * infcmd.c (print_return_value_1): Handle finish_print
7922         option.
7923         (show_print_finish): New function.
7924         (_initialize_infcmd): Add "set/show print finish" commands.
7925         * valprint.c (user_print_options): Initialize new member.
7926         * valprint.h (struct value_print_options) <finish_print>: New
7927         member.
7928
7929 2019-05-28  Tom Tromey  <tromey@adacore.com>
7930
7931         * ada-lang.c (ada_remove_Xbn_suffix)
7932         (find_old_style_renaming_symbol)
7933         (parse_old_style_renaming): Remove.
7934         (ada_find_renaming_symbol): Don't call
7935         find_old_style_renaming_symbol.
7936         (ada_is_renaming_symbol): Rename from
7937         ada_find_renaming_symbol.  Remove "block" parameter.  Return
7938         bool.  Now static.
7939         (ada_read_var_value): Update and simplify.
7940         * ada-exp.y (write_var_or_type): Remove old code.
7941
7942 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
7943
7944         PR gdb/25010
7945         * event-top.c: Remove include comment.
7946         * inflow.c (class scoped_ignore_sigttou): Move from here...
7947         * inflow.h (class scoped_ignore_sigttou): ...to here.
7948         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
7949         * top.c:  Remove include comment.
7950
7951 2019-05-27  Tom Tromey  <tom@tromey.com>
7952
7953         * NEWS: Fix typo.
7954
7955 2019-05-22  Tom Tromey  <tromey@adacore.com>
7956
7957         * target.c (target_follow_exec): Constify parameter.
7958         * target-delegates.c: Rebuild.
7959         * remote.c (remote_target::follow_exec): Constify parameter.
7960         * infrun.c (follow_exec): Constify parameter.
7961         * target.h (struct target_ops) <follow_exec>: Constify parameter.
7962         (target_follow_exec): Likewise.
7963
7964 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
7965
7966         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
7967         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
7968
7969 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
7970
7971         * NEWS: Add debugredirect and testsuite sections.
7972
7973 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
7974
7975         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
7976         target descriptions using exclusively floating point register name
7977         aliases.
7978
7979 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
7980
7981         PR gdb/18644:
7982         * f-lang.c (build_fortran_types): Handle the case where
7983         gdbarch_floatformat_for_type returns a nullptr.
7984
7985 2019-05-21  Tom de Vries  <tdevries@suse.de>
7986
7987         PR cli/24587
7988         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
7989
7990 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
7991
7992         PR gdb/18644:
7993         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
7994         16-byte floats.
7995         * i386-tdep.c (i386_floatformat_for_type): Use
7996         floatformats_ia64_quad for the 16-byte floating point component
7997         within a fortran 32-byte complex number.
7998
7999 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
8000
8001         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
8002         delete default constructor.
8003         (find_partial_die): Update to return const struct.
8004         (partial_die_parent_scope): Move variable declaration into scope
8005         of its use and change its type to auto.
8006         (guess_partial_die_structure_name): Likewise.
8007         (partial_die_info::fixup): Likewise.
8008
8009 2019-05-17  Tom Tromey  <tromey@adacore.com>
8010
8011         * source.c (find_and_open_source): Remove cast.
8012
8013 2019-05-17  Tom Tromey  <tromey@adacore.com>
8014
8015         * annotate.c (annotate_source): Make "filename" const.
8016         * annotate.h (annotate_source): Use const.
8017
8018 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
8019
8020         * disasm.c (set_disassembler_options): Send errors to stderr.
8021
8022 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
8023
8024         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
8025         (cli_interp_base::set_logging): Check debug_redirect.
8026         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
8027         * cli/cli-logging.c (debug_redirect): Add static variable.
8028         (pop_output_files): Add default param.
8029         (handle_redirections): Print debug setting.
8030         (show_logging_command): Likewise.
8031         (_initialize_cli_logging): Add debugredirect command.
8032         * interps.c (current_interp_set_logging): Add debug_redirect
8033         parameter.
8034         * interps.h (set_logging): Add debug_redirect parameter.
8035         (current_interp_set_logging): Likewise.
8036         * mi/mi-common.h: Likewise.
8037         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
8038
8039 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
8040             Tom Tromey  <tromey@adacore.com>
8041
8042         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
8043         directly.
8044         * cli/cli-interp.h (make_logging_output): Remove declaration.
8045         * cli/cli-logging.c (make_logging_output): Remove function.
8046         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
8047         directly.
8048         * ui-file.c (tee_file::tee_file): Remove bools.
8049         (tee_file::~tee_file): Remove deletes.
8050         * ui-file.h (tee_file): Remove bools.
8051
8052 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
8053
8054         * mi/mi-cmds.h (mi_cmd_complete): New function.
8055         * mi/mi-main.c (mi_cmd_complete): Likewise.
8056         * mi/mi-cmds.c: Define new MI command -complete.
8057         * NEWS: Mention new -complete command.
8058
8059 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
8060
8061         * completer.h (complete): New function.
8062         * completer.c (complete): Likewise.
8063         * cli/cli-cmds.c: (complete_command): Update to use new complete()
8064         function defined in completer.h.
8065
8066 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
8067
8068         * MAINTAINERS (Write After Approval): Add myself.
8069
8070 2019-05-17  Tom de Vries  <tdevries@suse.de>
8071
8072         PR gdb/24094
8073         * dwarf2read.c (struct cu_partial_die_info): New struct.
8074         (find_partial_die): Return cu_partial_die_info.
8075         (partial_die_parent_scope, guess_partial_die_structure_name)
8076         (partial_die_info::fixup): Handle new return type of find_partial_die.
8077
8078 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
8079
8080         PR breakpoints/24541
8081         * stap-probe.c (stap_parse_register_operand): Make "regname" an
8082         "std::string", simplifying the algorithm.
8083
8084 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
8085
8086         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
8087         (stap_static_probe_ops::get_probes): Likewise.
8088
8089 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
8090
8091         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
8092         '-')" and "else if".
8093         (stap_parse_single_operand): Join checks for
8094         "gdbarch_stap_parse_special_token_p" and
8095         "gdbarch_stap_parse_special_token" in the same "if" statement.
8096         Invert check when verifying for operation on register
8097         displacement.
8098
8099 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
8100
8101         * stap-probe.c (stap_get_opcode): Update comment.
8102         (stap_get_expected_argument_type): Likewise.
8103         (handle_stap_probe): Likewise.
8104
8105 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
8106
8107         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
8108         return type to 'bool'.  Adjust comment.  Use 'bool' when
8109         appropriate.
8110         (i386_stap_parse_special_token_three_arg_disp): Likewise.
8111         * stap-probe.c (stap_parse_argument_1): Likewise.
8112         (stap_is_operator): Likewise.
8113         (stap_is_generic_prefix): Likewise.
8114         (stap_is_register_prefix): Likewise.
8115         (stap_is_register_indirection_prefix): Likewise.
8116         (stap_is_integer_prefix): Likewise.
8117         (stap_generic_check_suffix): Likewise.
8118         (stap_check_integer_suffix): Likewise.
8119         (stap_check_register_suffix): Likewise.
8120         (stap_check_register_indirection_suffix): Likewise.
8121         (stap_parse_register_operand): Likewise.
8122         (stap_parse_single_operand): Likewise.
8123         (stap_parse_argument_1): Likewise.
8124         (stap_probe::get_argument_count): Likewise.
8125         (stap_is_operator): Likewise.
8126
8127 2019-05-16  Tom Tromey  <tromey@adacore.com>
8128
8129         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
8130         keyword to foreach.
8131
8132 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
8133
8134         * linux-thread-db.c (try_thread_db_load_1): Change return type
8135         to bool.
8136         (try_thread_db_load): Likewise.
8137         (try_thread_db_load_from_pdir_1): Likewise.
8138         (try_thread_db_load_from_pdir): Likewise.
8139         (try_thread_db_load_from_sdir): Likewise.
8140         (try_thread_db_load_from_dir): Likewise.
8141         (thread_db_load_search): Likewise.
8142         (has_libpthread): Likewise.
8143         (thread_db_load): Likewise.
8144
8145 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
8146
8147         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
8148         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
8149         NULL, and complain/return if that's the case.
8150
8151 2019-05-15  John Darrington <john@darrington.wattle.id.au>
8152
8153         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
8154         (advance, posn, abstract_read_memory): New functions.
8155         [struct mem_read_abstraction]: New struct.
8156         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
8157
8158 2019-05-14  Tom Tromey  <tromey@adacore.com>
8159
8160         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
8161         value is not lval_memory.
8162
8163 2019-05-14  Tom Tromey  <tromey@adacore.com>
8164
8165         * solib.c (info_sharedlibrary_command): Style the file name.
8166
8167 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
8168
8169         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
8170         (aarch64_vnv_type): Likewise.
8171         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
8172         * common/tdesc.c: Likewise.
8173         * common/tdesc.h (enum tdesc_type_kind): Likewise.
8174         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
8175         * features/aarch64-fpu.xml: Add ieee half view.
8176         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
8177         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
8178         * gdbtypes.h (struct builtin_type): Likewise.
8179         (struct objfile_type): Likewise.
8180
8181 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
8182
8183         * language.c (language_sniff_from_mangled_name): Fix "langauge"
8184         typo.
8185         * location.h (string_to_event_location): Likewise.
8186
8187 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
8188
8189         GDB 8.3 released.
8190
8191 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
8192
8193         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
8194         New variable declaration.
8195         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
8196         New variable.
8197         (print_one_breakpoint): Use ui_out::test_flags and new global
8198         variable to compute use_fixed_output.
8199         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
8200         Remove.
8201         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
8202         (mi_multi_location_breakpoint_output_fixed): Remove.
8203         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
8204         new variable.
8205         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
8206         fix_multi_location_breakpoint_output flag if version >= 3.
8207         * ui-out.h (enum ui_out_flag)
8208         <fix_multi_location_breakpoint_output>: New enumerator.
8209
8210 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
8211
8212         * contrib/cc-with-tweaks.sh: Validate dwz's work.
8213
8214 2019-05-10  Tom Tromey  <tromey@adacore.com>
8215
8216         * ada-lang.c (catch_ada_completer): New function.
8217         (_initialize_ada_language): Use it.
8218
8219 2019-05-10  Tom Tromey  <tromey@adacore.com>
8220
8221         * thread.c (print_thread_info): Make "requested_threads" const.
8222         * gdbthread.h (print_thread_info): Make "requested_threads"
8223         const.
8224         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
8225         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
8226
8227 2019-05-08  Tom Tromey  <tom@tromey.com>
8228
8229         * gdbtypes.c (objfile_type_data): Change type.
8230         (objfile_type, _initialize_gdbtypes): Update.
8231
8232 2019-05-08  Tom Tromey  <tom@tromey.com>
8233
8234         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
8235         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
8236         (_initialize_dwarf2_frame): Update.
8237
8238 2019-05-08  Tom Tromey  <tom@tromey.com>
8239
8240         * objc-lang.c (objc_objfile_data): Change type.
8241         (find_methods): Update.
8242         (_initialize_objc_lang): Remove.
8243
8244 2019-05-08  Tom Tromey  <tom@tromey.com>
8245
8246         * stabsread.c (rs6000_builtin_type_data): Change type.
8247         (rs6000_builtin_type, _initialize_stabsread): Update.
8248
8249 2019-05-08  Tom Tromey  <tom@tromey.com>
8250
8251         * mips-tdep.c (mips_pdr_data): Remove.
8252         (_initialize_mips_tdep): Update.
8253
8254 2019-05-08  Tom Tromey  <tom@tromey.com>
8255
8256         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
8257         (hppa_init_objfile_priv_data, read_unwind_info)
8258         (find_unwind_entry, _initialize_hppa_tdep): Update.
8259
8260 2019-05-08  Tom Tromey  <tom@tromey.com>
8261
8262         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
8263         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
8264         on obstack.
8265         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
8266
8267 2019-05-08  Tom Tromey  <tom@tromey.com>
8268
8269         * mdebugread.c (basic_type_data): Change type.
8270         (basic_type, _initialize_mdebugread): Update.
8271
8272 2019-05-08  Tom Tromey  <tom@tromey.com>
8273
8274         * common/gdb_unique_ptr.h (struct noop_deleter): New.
8275
8276 2019-05-08  Tom Tromey  <tom@tromey.com>
8277
8278         * nto-tdep.c (nto_inferior_data_reg): Change type.
8279         (nto_inferior_data): Update.
8280         (nto_inferior_data_cleanup, nto_new_inferior_data)
8281         (_initialize_nto_tdep): Remove.
8282         * nto-tdep.h (struct nto_inferior_data): Add initializers.
8283
8284 2019-05-08  Tom Tromey  <tom@tromey.com>
8285
8286         * ada-lang.c (struct ada_inferior_data): Add initializers.
8287         (ada_inferior_data): Change type.
8288         (ada_inferior_data_cleanup): Remove.
8289         (get_ada_inferior_data, ada_inferior_exit)
8290         (struct ada_pspace_data): Add initializers, destructor.
8291         (ada_pspace_data_handle): Change type.
8292         (get_ada_pspace_data): Update.
8293         (ada_pspace_data_cleanup): Remove.
8294
8295 2019-05-08  Tom Tromey  <tom@tromey.com>
8296
8297         * coffread.c (struct coff_symfile_info): Add initializers.
8298         (coff_objfile_data_key): Move lower.  Change type.
8299         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
8300         Update.
8301         (coff_free_info): Remove.
8302
8303 2019-05-08  Tom Tromey  <tom@tromey.com>
8304
8305         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
8306         (fbsd_pspace_data_handle): Move lower.  Change type.
8307         (get_fbsd_pspace_data): Update.
8308         (fbsd_pspace_data_cleanup): Remove.
8309         (_initialize_fbsd_tdep): Update.
8310
8311 2019-05-08  Tom Tromey  <tom@tromey.com>
8312
8313         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
8314         (get_ada_tasks_pspace_data): Update.
8315         (ada_tasks_pspace_data_cleanup): Remove.
8316         (_initialize_tasks): Update.
8317         (ada_tasks_inferior_data_handle): Change type.
8318         (get_ada_tasks_inferior_data): Update.
8319         (ada_tasks_inferior_data_cleanup): Remove.
8320         (struct ada_tasks_pspace_data): Add initializers.
8321
8322 2019-05-08  Tom Tromey  <tom@tromey.com>
8323
8324         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
8325         * symfile-debug.c (debug_sym_get_probes): Change type.
8326         * stap-probe.c (handle_stap_probe):
8327         (stap_static_probe_ops::get_probes): Change type.
8328         * probe.h (class static_probe_ops) <get_probes>: Change type.
8329         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
8330         (parse_probes_in_pspace): Update.
8331         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
8332         Update.
8333         (any_static_probe_ops::get_probes): Change type.
8334         * elfread.c (elfread_data): New typedef.
8335         (probe_key): Change type.
8336         (elf_get_probes): Likewise.  Update.
8337         (probe_key_free): Remove.
8338         (_initialize_elfread): Update.
8339         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
8340         Change type.
8341         (dtrace_process_dof_probe, dtrace_process_dof)
8342         (dtrace_static_probe_ops::get_probe): Change type.
8343
8344 2019-05-08  Tom Tromey  <tom@tromey.com>
8345
8346         * xcoffread.c (struct xcoff_symfile_info): Rename from
8347         coff_symfile_info.  Add initializers.
8348         (xcoff_objfile_data_key): Move lower.  Change type.
8349         (XCOFF_DATA): Rewrite.
8350         (xcoff_free_info): Remove.
8351         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
8352         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
8353         (xcoff_initial_scan): Update.
8354
8355 2019-05-08  Tom Tromey  <tom@tromey.com>
8356
8357         * solib-svr4.c (struct svr4_info): Add initializers and
8358         destructor.
8359         <probes_table>: Now an htab_up.
8360         (solib_svr4_pspace_data): Change type.
8361         (free_probes_table): Simplify.
8362         (~svr4_info): Rename from svr4_pspace_data_cleanup.
8363         (get_svr4_info, probes_table_htab_remove_objfile_probes)
8364         (probes_table_remove_objfile_probes, register_solib_event_probe)
8365         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
8366         (_initialize_svr4_solib): Update.
8367
8368 2019-05-08  Tom Tromey  <tom@tromey.com>
8369
8370         * remote.c (remote_pspace_data): Change type.
8371         (remote_pspace_data_cleanup): Remove.
8372         (get_remote_exec_file, set_pspace_remote_exec_file)
8373         (_initialize_remote): Update.
8374
8375 2019-05-08  Tom Tromey  <tom@tromey.com>
8376
8377         * breakpoint.c (breakpoint_objfile_key): Change type.
8378         (get_breakpoint_objfile_data): Update.
8379         (free_breakpoint_objfile_data): Remove.
8380         (_initialize_breakpoint): Update.
8381
8382 2019-05-08  Tom Tromey  <tom@tromey.com>
8383
8384         * linux-tdep.c (struct linux_info): Add initializers.
8385         (linux_inferior_data): Move.  Change type.
8386         (invalidate_linux_cache_inf): Update.
8387         (linux_inferior_data_cleanup): Remove.
8388         (get_linux_inferior_data, _initialize_linux_tdep): Update.
8389
8390 2019-05-08  Tom Tromey  <tom@tromey.com>
8391
8392         * auxv.c (auxv_inferior_data): Move.  Change type.
8393         (auxv_inferior_data_cleanup): Remove.
8394         (invalidate_auxv_cache_inf): Rewrite.
8395         (get_auxv_inferior_data, _initialize_auxv): Update.
8396
8397 2019-05-08  Tom Tromey  <tom@tromey.com>
8398
8399         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
8400         (symfile_debug_objfile_data_key): Change type.
8401         (symfile_debug_installed, debug_qf_has_symbols)
8402         (debug_qf_find_last_source_symtab)
8403         (debug_qf_forget_cached_source_info)
8404         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
8405         (debug_qf_print_stats, debug_qf_dump)
8406         (debug_qf_expand_symtabs_for_function)
8407         (debug_qf_expand_all_symtabs)
8408         (debug_qf_expand_symtabs_with_fullname)
8409         (debug_qf_map_matching_symbols)
8410         (debug_qf_expand_symtabs_matching)
8411         (debug_qf_find_pc_sect_compunit_symtab)
8412         (debug_qf_map_symbol_filenames)
8413         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
8414         (debug_sym_new_init, debug_sym_init, debug_sym_read)
8415         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
8416         (debug_sym_read_linetable, debug_sym_relocate): Update.
8417         (symfile_debug_free_objfile): Remove.
8418         (install_symfile_debug_logging, _initialize_symfile_debug):
8419         Update.
8420
8421 2019-05-08  Tom Tromey  <tom@tromey.com>
8422
8423         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
8424         allocate_on_obstack.
8425         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
8426         (get_dwarf2_per_objfile): Update.
8427         (set_dwarf2_per_objfile): Remove.
8428         (dwarf2_has_info, dwarf2_get_section_info): Update.
8429         (dwarf2_free_objfile): Remove.
8430         (_initialize_dwarf2_read): Update.
8431
8432 2019-05-08  Tom Tromey  <tom@tromey.com>
8433
8434         * auto-load.c (struct auto_load_pspace_info): Add destructor and
8435         initializers.
8436         <unsupported_script_warning_printed,
8437         script_not_found_warning_printed>: Now bool.
8438         (auto_load_pspace_data): Change type.
8439         (~auto_load_pspace_info): Rename from
8440         auto_load_pspace_data_cleanup.
8441         (get_auto_load_pspace_data, init_loaded_scripts_info)
8442         (clear_section_scripts, maybe_print_unsupported_script_warning)
8443         (maybe_print_script_not_found_warning, _initialize_auto_load):
8444         Update.
8445
8446 2019-05-08  Tom Tromey  <tom@tromey.com>
8447
8448         * objfiles.c (objfile_pspace_info): Add destructor and
8449         initializers.
8450         (objfiles_pspace_data): Change type.
8451         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
8452         (get_objfile_pspace_data): Update.
8453         (objfiles_bfd_data): Change type.
8454         (get_objfile_bfd_data): Update.
8455         (objfile_bfd_data_free, _initialize_objfiles): Remove.
8456
8457 2019-05-08  Tom Tromey  <tom@tromey.com>
8458
8459         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
8460         Change type.
8461         (get_catch_syscall_inferior_data): Update.
8462         (catch_syscall_inferior_data_cleanup): Remove.
8463         (_initialize_break_catch_syscall): Update.
8464
8465 2019-05-08  Tom Tromey  <tom@tromey.com>
8466
8467         * inflow.c (struct terminal_info): Add destructor and
8468         initializers.
8469         (inflow_inferior_data): Change type.
8470         (~terminal_info): Rename from inflow_inferior_data_cleanup.
8471         (get_inflow_inferior_data, inflow_inferior_exit)
8472         (swap_terminal_info, _initialize_inflow): Update.
8473
8474 2019-05-08  Tom Tromey  <tom@tromey.com>
8475
8476         * target-dcache.c (target_dcache_cleanup): Remove.
8477         (target_dcache_aspace_key): Change type.
8478         (target_dcache_init_p, target_dcache_invalidate)
8479         (target_dcache_get, target_dcache_get_or_init)
8480         (_initialize_target_dcache): Update.
8481         * dcache.h (struct dcache_deleter): New.
8482
8483 2019-05-08  Tom Tromey  <tom@tromey.com>
8484
8485         * symtab.c (struct symbol_cache): Add destructor and
8486         initializers.
8487         (symbol_cache_key): Move.  Change type.
8488         (make_symbol_cache, free_symbol_cache): Remove.
8489         (get_symbol_cache): Update.
8490         (symbol_cache_cleanup): Remove.
8491         (ALL_PSPACES, symbol_cache_flush)
8492         (maintenance_print_symbol_cache)
8493         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
8494         Update.
8495
8496 2019-05-08  Tom Tromey  <tom@tromey.com>
8497
8498         * symtab.c (struct main_info): Add destructor and initializers.
8499         (main_progspace_key): Move.  Change type.
8500         (get_main_info): Update.
8501         (main_info_cleanup): Remove.
8502         (_initialize_symtab): Update.
8503
8504 2019-05-08  Tom Tromey  <tom@tromey.com>
8505
8506         * registry.h (DECLARE_REGISTRY): Define the _key class.
8507
8508 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
8509
8510         * NEWS: Merge two 'New commands' sections.
8511
8512 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
8513
8514         * ada-valprint.c (ada_val_print_gnat_array): Remove language
8515         parameter and use Ada language definition instead.
8516         (ada_val_print_ptr): Remove unused language parameter.
8517         (ada_val_print_num): Remove language parameter and use Ada language
8518         definition instead.
8519         (ada_val_print_enum, ada_val_print_flt): Remove unused language
8520         parameter.
8521         (ada_val_print_struct_union, ada_val_print_ref): Remove language
8522         parameter and use Ada language definition instead.
8523         (ada_val_print_1): Update all ada_val_print_xxx calls.
8524         Remove language parameter.
8525         (ada_val_print): Update ada_val_print_1 call.
8526
8527 2019-05-08  Tom Tromey  <tromey@adacore.com>
8528
8529         * remote.c (remote_hw_watchpoint_limit)
8530         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
8531         Now static.
8532
8533 2019-05-08  Tom Tromey  <tromey@adacore.com>
8534
8535         * maint.c (_initialize_maint_cmds): Move initialization code to
8536         remote.c.
8537         (watchdog, show_watchdog): Move to remote.c.
8538         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
8539         "watchdog" static.
8540         (_initialize_remote): Move initialization code from maint.c.
8541         * defs.h (watchdog): Don't declare.
8542
8543 2019-05-08  Tom Tromey  <tromey@adacore.com>
8544
8545         * tui/tui-interp.c: Include main.h.
8546         * interps.c: Include main.h.
8547         * main.h (interpreter_p): Declare.
8548         * defs.h (interpreter_p): Don't declare.
8549
8550 2019-05-08  Tom Tromey  <tromey@adacore.com>
8551
8552         * dwarf2loc.c: Include dwarf2read.h.
8553         * defs.h (read_unsigned_leb128): Don't declare.
8554         * dwarf2read.h (read_unsigned_leb128): Declare.
8555
8556 2019-05-08  Tom Tromey  <tromey@adacore.com>
8557
8558         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
8559         method.
8560
8561 2019-05-08  Tom Tromey  <tromey@adacore.com>
8562
8563         * utils.c (fputs_maybe_filtered): Reset style after paging, even
8564         when no wrap column is set.
8565
8566 2019-05-08  Tom Tromey  <tromey@adacore.com>
8567
8568         * c-lang.c (c_get_string): Handle non-C-style arrays.
8569
8570 2019-05-08  Tom Tromey  <tromey@adacore.com>
8571
8572         * typeprint.c (print_offset_data::update): Print the bit offset,
8573         not the number of bits remaining.
8574
8575 2019-05-08  Tom Tromey  <tromey@adacore.com>
8576
8577         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
8578         padding at end of comment.
8579
8580 2019-05-08  Tom Tromey  <tromey@adacore.com>
8581
8582         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
8583         Compare main types.
8584
8585 2019-05-06  Tom Tromey  <tom@tromey.com>
8586
8587         * common/scoped_mmap.c: Include common-defs.h.
8588         * common/scoped_mmap.h: Don't include config.h.
8589
8590 2019-05-04  Tom Tromey  <tom@tromey.com>
8591
8592         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
8593         (struct aarch64_call_info): Add initializers.
8594         <si>: Now a std::vector.
8595         (pass_on_stack, aarch64_push_dummy_call): Update.
8596
8597 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
8598             Tom Tromey  <tom@tromey.com>
8599
8600         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
8601         (ppc_threads): Now a std::vector.  Now static.
8602         (hwdebug_find_thread_points_by_tid)
8603         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
8604         Update.
8605
8606 2019-05-04  Tom Tromey  <tom@tromey.com>
8607
8608         * arc-tdep.c (arc_tdesc_init): Return bool.
8609
8610 2019-05-04  Tom Tromey  <tom@tromey.com>
8611
8612         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
8613         Use gdb_assert_not_reached.
8614
8615 2019-05-04  Tom Tromey  <tom@tromey.com>
8616
8617         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
8618         "false".
8619
8620 2019-05-04  Tom Tromey  <tom@tromey.com>
8621
8622         * arc-tdep.c (arc_tdesc_init): Use bool.
8623
8624 2019-05-04  Tom Tromey  <tom@tromey.com>
8625
8626         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
8627
8628 2019-05-04  Tom Tromey  <tom@tromey.com>
8629
8630         * cli/cli-cmds.c (valid_command_p): Return bool.
8631
8632 2019-05-04  Tom Tromey  <tom@tromey.com>
8633
8634         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
8635         * command.h (valid_user_defined_cmd_name_p): Channge return type.
8636
8637 2019-05-04  Raul Tambre  <raul@tambre.ee>
8638
8639         * python/lib/gdb/prompt.py (_ExtendedPrompt)
8640         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
8641         operator for comparison.
8642
8643 2019-05-04  Tom Tromey  <tom@tromey.com>
8644
8645         * psymtab.c (psymbol_name_matches, match_partial_symbol)
8646         (lookup_partial_symbol, print_partial_symbols)
8647         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
8648         (psymbol_compare): Update.
8649         (add_psymbol_to_bcache): Clear the entire psymbol.
8650         (maintenance_check_psymtabs): Update.
8651         * psympriv.h (struct partial_symbol): Don't derive from
8652         general_symbol_info.
8653         <obj_section, unrelocated_address, address,
8654         set_unrelocated_address>: Update.
8655         <ginfo>: New member.
8656         * dwarf-index-write.c (write_psymbols, debug_names::insert)
8657         (debug_names::write_psymbols): Update.
8658
8659 2019-05-04  Tom de Vries  <tdevries@suse.de>
8660
8661         * contrib/cc-with-tweaks.sh: Support -n arg.
8662
8663 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8664
8665         * corelow.c (core_target::detach): Ensure frame cache and
8666         register caches are cleared.
8667         inferior.c (exit_inferior_1): Likewise.
8668
8669 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
8670             Tom Tromey  <tom@tromey.com>
8671
8672         * dictionary.c (collate_pending_symbols_by_language): Remove
8673         "struct" from foreach.
8674         * symtab.c (lookup_global_symbol_from_objfile)
8675         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
8676         foreach.
8677         * ser-tcp.c (net_open): Remove "struct" from foreach.
8678         * objfiles.c (objfile_relocate, objfile_rebase)
8679         (objfile_has_symbols): Remove "struct" from foreach.
8680         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
8681         from foreach.
8682         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
8683         foreach.
8684         * darwin-nat.c (thread_info_from_private_thread_info): Remove
8685         "struct" from foreach.
8686         * ada-lang.c (create_excep_cond_exprs)
8687         (ada_exception_catchpoint_cond_string): Remove "struct" from
8688         foreach.
8689
8690 2019-05-03  Tom Tromey  <tromey@adacore.com>
8691
8692         * ada-exp.y (convert_char_literal): Check suffix of each
8693         enumerator.
8694
8695 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
8696
8697         PR ada/21406:
8698         * ada-exp.y (yywrap): Don't define.
8699         * ada-lex.l (%option): Add noyywrap
8700         (yywrap): Remove.
8701
8702 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
8703
8704         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
8705         _WIN32_WINNT to the XP level, unless already defined to a higher
8706         level.
8707
8708         * unittests/parse-connection-spec-selftests.c:
8709         * ser-tcp.c:
8710         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
8711         override.
8712
8713         * symfile.c (find_separate_debug_file): Remove colon from the
8714         drive spec of DOS/Windows file names of the target, so that the
8715         file name produced from DEBUGDIR and the target's directory will
8716         be valid on DOS/Windows systems.
8717
8718 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
8719
8720         * rust-lang.c (val_print_struct): Handle printing structures
8721         containing strings.
8722
8723 2019-05-02  Tom Tromey  <tromey@adacore.com>
8724
8725         * valarith.c (_initialize_valarith): Remove.
8726
8727 2019-05-01  Tom Tromey  <tromey@adacore.com>
8728
8729         * ada-lang.c (ada_value_primitive_field): Treat more fields as
8730         bitfields.
8731
8732 2019-05-01  Tom Tromey  <tromey@adacore.com>
8733
8734         * ada-lang.c (ada_value_assign): Correctly compute starting offset
8735         for big-endian copies.
8736
8737 2019-04-30  Ali Tamur  <tamur@google.com>
8738         * gdb/dwarf2read.c (read_3_bytes): New declaration.
8739         (read_attribute_value): Added DW_FORM_strx1-4 cases.
8740         (read_3_bytes): New function.
8741
8742 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
8743
8744         * windows-nat.c (main_thread_id): Delete.
8745         (handle_output_debug_string): Replace main_thread_id by
8746         current_event.dwThreadId.
8747         (fake_create_process): Likewise.
8748         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
8749         Do not set main_thread_id.
8750         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
8751         current_event.dwThreadId.
8752         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
8753
8754 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
8755
8756         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
8757         Use current_event.dwThreadId instead of main_thread_id.
8758
8759 2019-04-30  Tom Tromey  <tromey@adacore.com>
8760
8761         * ada-lang.c (ada_lookup_simple_minsyms): New function.
8762         (create_excep_cond_exprs): Iterate over program spaces.
8763         (ada_exception_catchpoint_cond_string): Examine all minimal
8764         symbols for exception types.
8765
8766 2019-04-30  Tom Tromey  <tromey@adacore.com>
8767
8768         PR c++/24470:
8769         * dwarf2read.c (process_structure_scope): Handle case where type
8770         has template parameters but no symbol was created.
8771
8772 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8773             Chris January  <chris.january@arm.com>
8774
8775         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
8776         qualifier.
8777         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
8778
8779 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8780
8781         * f-typeprint.c (f_print_type): Update rules for printing
8782         whitespace.
8783         (f_type_print_varspec_suffix): Likewise.
8784
8785 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8786             Chris January  <chris.january@arm.com>
8787
8788         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
8789         function arguments.
8790
8791 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8792
8793         * f-lang.c (build_fortran_types): Change name of void type to
8794         lower case.
8795         * f-typeprint.c (f_type_print_base): Print the name of the void
8796         type, rather than a fixed string.
8797         * f-valprint.c (f_decorations): Use lower case void string.
8798
8799 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8800             Chris January  <chris.january@arm.com>
8801
8802         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
8803         types for Fortran.
8804
8805 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8806             Chris January  <chris.january@arm.com>
8807             David Lecomber  <david.lecomber@arm.com>
8808
8809         * f-exp.y (BINOP_INTRINSIC): New token.
8810         (exp): New parser rule handling BINOP_INTRINSIC.
8811         (f77_keywords): Add new builtin procedures.
8812         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
8813         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
8814         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
8815         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
8816         (print_unop_subexp_f): New function.
8817         (print_binop_subexp_f): New function.
8818         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
8819         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
8820         (dump_subexp_body_f): Likewise.
8821         (operator_check_f): Likewise.
8822         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
8823         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
8824
8825 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8826
8827         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
8828         UNOP_KIND.
8829         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
8830         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
8831         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
8832         (operator_length_f): New fuction.
8833         (print_subexp_f): New function.
8834         (op_name_f): New function.
8835         (dump_subexp_body_f): New function.
8836         (operator_check_f): New function.
8837         (exp_descriptor_f): Replace standard expression handling functions
8838         with new functions.
8839         * gdb/fortran-operator.def: New file.
8840         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
8841         * gdb/std-operator.def: Remove UNOP_KIND.
8842
8843 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8844
8845         * std-operator.def: Remove unbalanced, stray double quote
8846         character.
8847
8848 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
8849             Chris January  <chris.january@arm.com>
8850             Daniel Everett  <daniel.everett@arm.com>
8851             Nick Forrington  <nick.forrington@arm.com>
8852             Richard Bunt  <richard.bunt@arm.com>
8853
8854         * cp-valprint.c (cp_print_value_fields): Allow an additional level
8855         of depth when printing anonymous structs or unions.
8856         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
8857         Don't print either the top-level value, or the children if the
8858         max-depth is exceeded.
8859         (ppscm_print_children): When printing the key of a map, allow one
8860         extra level of depth.
8861         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
8862         print either the top-level value, or the children if the max-depth
8863         is exceeded.
8864         (print_children): When printing the key of a map, allow one extra
8865         level of depth.
8866         * python/py-value.c (valpy_format_string): Add max_depth keyword.
8867         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
8868         (user_print_options): Initialise max_depth field.
8869         (val_print_scalar_or_string_type_p): New function.
8870         (val_print): Check to see if the max depth has been reached.
8871         (val_print_check_max_depth): Define new function.
8872         (show_print_max_depth): New function.
8873         (_initialize_valprint): Add 'print max-depth' option.
8874         * valprint.h (struct value_print_options) <max_depth>: New field.
8875         (val_print_check_max_depth): Declare new function.
8876         * NEWS: Document new feature.
8877
8878 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
8879
8880         * ada-lang.c (ada_language_defn): Initialise new field.
8881         * c-lang.c (c_is_string_type_p): New function.
8882         (c_language_defn): Initialise new field.
8883         (cplus_language_defn): Initialise new field.
8884         (asm_language_defn): Initialise new field.
8885         (minimal_language_defn): Initialise new field.
8886         * c-lang.h (c_is_string_type_p): Declare new function.
8887         * d-lang.c (d_language_defn): Initialise new field.
8888         * f-lang.c (f_is_string_type_p): New function.
8889         (f_language_defn): Initialise new field.
8890         * go-lang.c (go_is_string_type_p): New function.
8891         (go_language_defn): Initialise new field.
8892         * language.c (default_is_string_type_p): New function.
8893         (unknown_language_defn): Initialise new field.
8894         (auto_language_defn): Initialise new field.
8895         * language.h (struct language_defn) <la_is_string_type_p>: New
8896         member variable.
8897         (default_is_string_type_p): Declare new function.
8898         * m2-lang.c (m2_language_defn): Initialise new field.
8899         * objc-lang.c (objc_language_defn): Initialise new field.
8900         * opencl-lang.c (opencl_language_defn): Initialise new field.
8901         * p-lang.c (pascal_is_string_type_p): New function.
8902         (pascal_language_defn): Initialise new field.
8903         * rust-lang.c (rust_is_string_type_p): New function.
8904         (rust_language_defn): Initialise new field.
8905
8906 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
8907
8908         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
8909         New field.
8910         * ada-lang.c (ada_language_defn): Initialise new field.
8911         * c-lang.c (c_language_defn): Likewise.
8912         (cplus_language_defn): Likewise.
8913         (asm_language_defn): Likewise.
8914         (minimal_language_defn): Likewise.
8915         * d-lang.c (d_language_defn): Likewise.
8916         * f-lang.c (f_language_defn): Likewise.
8917         * go-lang.c (go_language_defn): Likewise.
8918         * language.c (unknown_language_defn): Likewise.
8919         (auto_language_defn): Likewise.
8920         * m2-lang.c (m2_language_defn): Likewise.
8921         * objc-lang.c (objc_language_defn): Likewise.
8922         * opencl-lang.c (opencl_language_defn): Likewise.
8923         * p-lang.c (pascal_language_defn): Likewise.
8924         * rust-lang.c (rust_language_defn): Likewise.
8925
8926 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
8927
8928         * ada-lang.c (ada_is_character_type): Change return type to bool.
8929         (ada_is_string_type): Likewise.
8930         * ada-lang.h (ada_is_character_type): Update declaration
8931         (ada_is_string_type): Likewise.
8932
8933 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8934
8935         Support style in 'frame|thread apply'
8936
8937         * gdbcmd.h (execute_command_to_string): New term_out parameter.
8938         * record.c (record_start, record_stop): Update callers of
8939         execute_command_to_string with false.
8940         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
8941         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
8942         methods.
8943         (class string_file): New constructor with term_out parameter.
8944         Override methods term_out and can_emit_style_escape.  New member
8945         term_out.
8946         (class stdio_file): Override can_emit_style_escape.
8947         (class tee_file): Override term_out and can_emit_style_escape.
8948         * utils.h (can_emit_style_escape): Remove.
8949         * utils.c (can_emit_style_escape): Likewise.
8950         Update all callers of can_emit_style_escape (SOMESTREAM) to
8951         SOMESTREAM->can_emit_style_escape.
8952         * source-cache.c (source_cache::get_source_lines): Likewise.
8953         * stack.c (frame_apply_command_count): Call execute_command_to_string
8954         passing the term_out characteristic of the current gdb_stdout.
8955         * thread.c (thr_try_catch_cmd): Likewise.
8956         * top.c (execute_command_to_string): pass term_out parameter
8957         to construct the string_file for the command output.
8958         * ui-file.c (term_cli_styling): New function (most code moved
8959         from utils.c can_emit_style_escape).
8960         (string_file::string_file, string_file::can_emit_style_escape,
8961         stdio_file::can_emit_style_escape, tee_file::term_out,
8962         tee_file::can_emit_style_escape): New functions.
8963
8964 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8965
8966         * NEWS: Mention the new set|show may-call-functions.
8967         * infcall.c (may_call_functions_p): New variable.
8968         (show_may_call_functions_p): New function.
8969         (call_function_by_hand_dummy): Throws an error if not
8970         may-call-functions.
8971         (_initialize_infcall): Call add_setshow_boolean_cmd for
8972         may-call-functions.
8973
8974 2019-04-25  Keith Seitz  <keiths@redhat.com>
8975
8976         PR c++/24367
8977         * cp-support.c (inspect_type): Don't attempt substitutions
8978         of symbol with the same name.
8979
8980 2019-04-25  Tom Tromey  <tromey@adacore.com>
8981
8982         PR gdb/24475:
8983         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
8984         static.
8985
8986 2019-04-25  Tom Tromey  <tromey@adacore.com>
8987
8988         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
8989         rvalue reference.
8990         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
8991         (gdb_xml_parser::parse): Use std::move.
8992         * python/python-internal.h (gdbpy_convert_exception): Take a const
8993         reference.
8994         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
8995         std::move.
8996         * python/py-utils.c (gdbpy_convert_exception): Take a const
8997         reference.
8998         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
8999         Use std::move.
9000         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
9001         Use std::move.
9002         * mi/mi-main.c (mi_print_exception): Take a const reference.
9003         * main.c (handle_command_errors): Take a const reference.
9004         * linespec.c (parse_linespec): Use std::move.
9005         * infcall.c (run_inferior_call): Use std::move.
9006         (call_function_by_hand_dummy): Use std::move.
9007         * exec.c (try_open_exec_file): Use std::move.
9008         * exceptions.h (exception_print, exception_fprintf)
9009         (exception_print_same): Update.
9010         * exceptions.c (print_exception, exception_print)
9011         (exception_fprintf, exception_print_same): Change parameters to
9012         const reference.
9013         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
9014         * common/new-op.c: Use std::move.
9015         * common/common-exceptions.h (struct gdb_exception): Add move
9016         constructor.
9017         (struct gdb_exception_error, struct gdb_exception_quit, struct
9018         gdb_quit_bad_alloc): Change constructor to move constructor.
9019         (throw_exception): Change parameter to rvalue reference.
9020         * common/common-exceptions.c (throw_exception): Take rvalue
9021         reference.
9022         * cli/cli-interp.c (safe_execute_command): Use std::move.
9023         * breakpoint.c (insert_bp_location, location_to_sals): Use
9024         std::move.
9025
9026 2019-04-25  Tom Tromey  <tromey@adacore.com>
9027
9028         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
9029         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
9030         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
9031         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
9032         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
9033         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
9034         guile/scm-value.c: Use unpack.
9035         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
9036         gdbscm_gdb_exception.
9037         (gdbscm_throw_gdb_exception): Likewise.
9038         (struct gdbscm_gdb_exception): New.
9039         (unpack): New function.
9040         (gdbscm_wrap): Use unpack.
9041
9042 2019-04-25  Tom Tromey  <tromey@adacore.com>
9043
9044         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
9045         (gdb_rl_callback_handler): Use std::move.
9046         * common/common-exceptions.h (struct gdb_exception): Add move
9047         assignment operator.
9048         (throw_exception_sjlj): Change "exception" to const reference.
9049         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
9050         (throw_exception_sjlj): Change "exception" to const reference.
9051
9052 2019-04-25  Tom Tromey  <tromey@adacore.com>
9053
9054         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
9055         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
9056         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
9057         Update.
9058         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
9059         Update.
9060         * mi/mi-interp.c (mi_interp::exec): Update.
9061         * linespec.c (parse_linespec): Update.
9062         * infcall.c (run_inferior_call): Update.
9063         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
9064         * guile/scm-symbol.c (gdbscm_lookup_symbol)
9065         (gdbscm_lookup_global_symbol): Update.
9066         * guile/scm-param.c (gdbscm_parameter_value): Update.
9067         * guile/scm-frame.c (gdbscm_frame_read_register)
9068         (gdbscm_frame_read_var): Update.
9069         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
9070         * exec.c (try_open_exec_file): Update.
9071         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
9072         (gdb_rl_callback_handler): Update.
9073         * common/common-exceptions.h (exception_none): Don't declare.
9074         * common/common-exceptions.c (exception_none): Don't define.
9075         (struct catcher) <exception>: Update.
9076         * cli/cli-interp.c (safe_execute_command): Update.
9077         * breakpoint.c (insert_bp_location, location_to_sals): Update.
9078
9079 2019-04-25  Ali Tamur  <tamur@google.com>
9080
9081         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
9082         (read_attribute_value): Likewise.
9083         (dwarf2_read_addr_index): Update comment.
9084         (read_str_index): Add DW_FORM_strx.
9085         (dwarf2_string_attr): Likewise.
9086         (dwarf2_const_value_attr): Likewise.
9087         (dump_die_shallow): Likewise.
9088         (dwarf2_fetch_constant_bytes): Likewise.
9089         (skip_form_bytes): Likewise.
9090         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
9091
9092 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
9093
9094         PR corefiles/11608
9095         PR corefiles/18187
9096         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
9097         OFFSET.  Verify if current mapping contains an ELF header.
9098         (linux_find_memory_regions_full): Adjust call to
9099         dump_mapping_p.
9100
9101 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
9102             Kang Li <kanglictf@gmail.com>
9103
9104         PR gdb/21600
9105
9106         * dwarf2-frame.c (read_initial_length): Be consistent about using
9107         unsigned representation of length.
9108         (decode_frame_entry_1): Likewise.  Check for wraparound of
9109         end pointer as well as buffer overflow.
9110
9111 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
9112
9113         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
9114         "vq".
9115
9116 2019-04-24  Tom Tromey  <tromey@adacore.com>
9117
9118         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
9119
9120 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9121
9122         * s12z-tdep.c (s12z_unwind_pc): Delete.
9123         (s12z_unwind_sp): Delete.
9124         (s12z_gdbarch_init): Don't register deleted functions with
9125         gdbarch.
9126
9127 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9128
9129         * rl78-tdep.c (rl78_unwind_sp): Delete.
9130         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
9131
9132 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9133
9134         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
9135         (xstormy16_unwind_pc): Delete.
9136         (xstormy16_dummy_id): Delete.
9137         (xstormy16_gdbarch_init): Don't register deleted functions with
9138         gdbarch.
9139
9140 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9141
9142         * vax-tdep.c (vax_unwind_pc): Delete.
9143         (vax_gdbarch_init): Don't register deleted function with gdbarch.
9144
9145 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9146
9147         * v850-tdep.c (v850_unwind_sp): Delete.
9148         (v850_unwind_pc): Delete.
9149         (v850_dummy_id): Delete.
9150         (v850_gdbarch_init): Don't register deleted functions with
9151         gdbarch.
9152
9153 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9154
9155         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
9156         (tilegx_unwind_pc): Delete.
9157         (tilegx_unwind_dummy_id): Delete.
9158         (tilegx_gdbarch_init): Don't register deleted functions with
9159         gdbarch.
9160
9161 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9162
9163         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
9164         (tic6x_dummy_id): Delete.
9165         (tic6x_gdbarch_init): Don't register deleted functions with
9166         gdbarch.
9167
9168 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9169
9170         * sparc-tdep.c (sparc_unwind_pc): Delete.
9171         (sparc32_gdbarch_init): Don't register deleted function with
9172         gdbarch.
9173
9174 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9175
9176         * sh-tdep.c (sh_unwind_sp): Delete.
9177         (sh_unwind_pc): Delete.
9178         (sh_dummy_id): Delete.
9179         (sh_gdbarch_init): Don't register deleted functions with
9180         gdbarch.
9181
9182 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9183
9184         * score-tdep.c (score_unwind_sp): Delete.
9185         (score_unwind_pc): Delete.
9186         (score_dummy_id): Delete.
9187         (score_gdbarch_init): Don't register deleted functions with
9188         gdbarch.
9189
9190 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9191
9192         * rx-tdep.c (rx_unwind_pc): Delete.
9193         (rx_unwind_sp): Delete.
9194         (rx_dummy_id): Delete.
9195         (rx_gdbarch_init): Don't register deleted functions with
9196         gdbarch.  Update comment.
9197
9198 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9199
9200         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
9201         (rs6000_dummy_id): Delete.
9202         (rs6000_gdbarch_init): Don't register deleted functions with
9203         gdbarch.
9204
9205 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9206
9207         * or1k-tdep.c (or1k_dummy_id): Delete.
9208         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
9209
9210 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9211
9212         * nios2-tdep.c (nios2_dummy_id): Delete.
9213         (nios2_unwind_sp): Delete.
9214         (nios2_gdbarch_init): Don't register deleted functions with
9215         gdbarch.
9216
9217 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9218
9219         * nds32-tdep.c (nds32_dummy_id): Delete.
9220         (nds32_unwind_pc): Delete.
9221         (nds32_unwind_sp): Delete.
9222         (nds32_gdbarch_init): Don't register deleted functions with
9223         gdbarch.
9224
9225 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9226
9227         * msp430-tdep.c (msp430_unwind_pc): Delete.
9228         (msp430_unwind_sp): Delete.
9229         (msp430_dummy_id): Delete.
9230         (msp430_gdbarch_init): Don't register deleted functions with
9231         gdbarch.
9232
9233 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9234
9235         * moxie-tdep.c (moxie_unwind_sp): Delete.
9236         (moxie_unwind_pc): Delete.
9237         (moxie_dummy_id): Delete.
9238         (moxie_gdbarch_init): Don't register deleted functions with
9239         gdbarch.
9240
9241 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9242
9243         * mn10300-tdep.c (mn10300_dummy_id): Delete.
9244         (mn10300_unwind_pc): Delete.
9245         (mn10300_unwind_sp): Delete.
9246         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
9247         mn10300_unwind_sp.
9248         (mn10300_frame_unwind_init): Don't register deleted functions with
9249         gdbarch.
9250
9251 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9252
9253         * mep-tdep.c (mep_unwind_pc): Delete.
9254         (mep_unwind_sp): Delete.
9255         (mep_dummy_id): Delete.
9256         (mep_gdbarch_init): Don't register deleted functions with
9257         gdbarch.
9258
9259 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9260
9261         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
9262         (m68hc11_unwind_sp): Delete.
9263         (m68hc11_gdbarch_init): Don't register deleted functions with
9264         gdbarch.
9265
9266 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9267
9268         * m32r-tdep.c (m32r_unwind_sp): Delete.
9269         (m32r_unwind_pc): Delete.
9270         (m32r_dummy_id): Delete.
9271         (m32r_gdbarch_init): Don't register deleted functions with
9272         gdbarch.
9273
9274 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9275
9276         * m32c-tdep.c (m32c_unwind_pc): Delete.
9277         (m32c_unwind_sp): Delete.
9278         (m32c_dummy_id): Delete.
9279         (m32c_gdbarch_init): Don't register deleted functions with
9280         gdbarch.
9281
9282 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9283
9284         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
9285         (lm32_unwind_pc): Delete.
9286         (lm32_dummy_id): Delete.
9287         (lm32_gdbarch_init): Don't register deleted functions with
9288         gdbarch.
9289
9290 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9291
9292         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
9293         (iq2000_unwind_pc): Delete.
9294         (iq2000_dummy_id): Delete.
9295         (iq2000_gdbarch_init): Don't register deleted functions with
9296         gdbarch.
9297
9298 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9299
9300         * nds32-tdep.c (nds32_type_align): Delete.
9301         (nds32_push_dummy_call): Use type_align instead.
9302
9303 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9304
9305         * arm-tdep.c (arm_type_align): Only handle vector override case.
9306         (arm_push_dummy_call): Use type_align.
9307         (arm_gdbarch_init): Register arm_type_align gdbarch function.
9308
9309 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9310
9311         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
9312         case.
9313         (pass_on_stack): Use type_align.
9314         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
9315         function.
9316
9317 2019-04-23  Tom Tromey  <tromey@adacore.com>
9318
9319         * dwarf2read.c (line_header::file_name_at): Remove unused
9320         overload.
9321
9322 2019-04-23  Tom de Vries  <tdevries@suse.de>
9323
9324         PR gdb/24438
9325         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
9326         invocation.
9327
9328
9329 2019-03-27  Ali Tamur  <tamur@google.com>
9330
9331         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
9332         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
9333         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
9334         (dwarf_expr_context::get_addr_index): Likewise
9335         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
9336         (symbol_needs_eval_context::get_addr_index): Likewise
9337         (disassemble_dwarf_expression): Add DW_OP_addrx
9338         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
9339         (read_cutu_die_from_dwo): Update comment
9340         (skip_one_die): Add DW_FORM_addrx
9341         (read_attribute_value): Likewise
9342         (var_decode_location): Add DW_OP_addrx
9343         (dwarf2_const_value_attr): Add DW_FORM_addrx
9344         (dump_die_shallow): Likewise
9345         (dwarf2_fetch_constant_bytes): Likewise
9346         (decode_locdesc): Add DW_OP_addrx
9347         (skip_form_bytes): Add DW_FORM_addrx
9348
9349 2019-04-22  Ali Tamur  <tamur@google.com>
9350
9351         * MAINTAINERS (Write After Approval): Add self.
9352
9353 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
9354
9355         * solib-svr4.c (get_svr4_info): Add pspace parameter.
9356         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
9357         (open_symbol_file_object): Likewise.
9358         (svr4_default_sos): Add info parameter.
9359         (svr4_read_so_list): Likewise.
9360         (svr4_current_sos_direct): Adjust functions calls to pass down
9361         info.
9362         (svr4_current_sos_1): Add info parameter.
9363         (svr4_current_sos): Call get_svr4_info, pass info down to
9364         svr4_current_sos_1.
9365         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
9366         get_svr4_info.
9367         (svr4_in_dynsym_resolve_code): Pass current_program_space to
9368         get_svr4_info.
9369         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
9370         to get_svr4_info.
9371         (probes_table_remove_objfile_probes): Likewise.
9372         (register_solib_event_probe): Add info parameter.
9373         (solist_update_incremental): Pass info parameter down to
9374         svr4_read_so_list.
9375         (disable_probes_interface): Add info parameter.
9376         (svr4_handle_solib_event): Pass current_program_space to
9377         get_svr4_info.  Adjust disable_probes_interface cleanup.
9378         (svr4_create_probe_breakpoints): Add info parameter, pass it
9379         down to register_solib_event_probe.
9380         (svr4_create_solib_event_breakpoints): Add info parameter,
9381         pass it down to svr4_create_probe_breakpoints.
9382         (enable_break): Pass info down to
9383         svr4_create_solib_event_breakpoints.
9384         (svr4_solib_create_inferior_hook): Pass current_program_space to
9385         get_svr4_info.
9386         (svr4_clear_solib): Likewise.
9387
9388 2019-04-22  Pedro Alves  <palves@redhat.com>
9389
9390         * solib-svr4.c (svr4_free_objfile_observer): New.
9391         (probe_and_action::objfile): New field.
9392         (probes_table_htab_remove_objfile_probes)
9393         (probes_table_remove_objfile_probes): New functions.
9394         (register_solib_event_probe): Add 'objfile' parameter.  Store it
9395         in the new probe_and_action.  Don't store the probe in 'lookup'.
9396         (svr4_create_probe_breakpoints): Pass objfile to
9397         register_solib_event_probe.
9398         (_initialize_svr4_solib): Register a free_objfile observer.
9399
9400 2019-04-19  Tom Tromey  <tom@tromey.com>
9401
9402         * common/queue.h: Remove.
9403
9404 2019-04-19  Tom Tromey  <tom@tromey.com>
9405
9406         * event-loop.c: Don't include "common/queue.h".
9407
9408 2019-04-19  Tom Tromey  <tom@tromey.com>
9409
9410         * remote.c (remote_target): Use delete.
9411         * remote-notif.h: Include <list>, not "common/queue.h".
9412         (notif_client_p): Remove typedef.
9413         (remote_notif_state): Add constructor, destructor, initializer.
9414         <notif_queue>: Now a std::list.
9415         (remote_notif_state_xfree): Don't declare.
9416         * remote-notif.c (remote_notif_process, handle_notification)
9417         (remote_notif_state_allocate): Update.
9418         (~remote_notif_state): Rename from remote_notif_state_xfree.
9419
9420 2019-04-19  Tom Tromey  <tom@tromey.com>
9421
9422         * symfile.c (reread_symbols): Update.
9423         * objfiles.c (objfile_register_static_link)
9424         (objfile_lookup_static_link): Update
9425         (~objfile) Don't delete static_links.
9426         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
9427
9428 2019-04-19  Tom Tromey  <tom@tromey.com>
9429
9430         * type-stack.h (struct type_stack) <insert>: Constify string.
9431         * type-stack.c (type_stack::insert): Constify string.
9432         * gdbtypes.h (lookup_template_type): Update.
9433         (address_space_name_to_int): Update.
9434         * gdbtypes.c (address_space_name_to_int): Make space_identifier
9435         const.
9436         (lookup_template_type): Make name const.
9437         * c-exp.y: Update rules.
9438         (lex_one_token, classify_name, classify_inner_name)
9439         (c_print_token): Update.
9440         * p-exp.y: Update rules.
9441         (yylex): Update.
9442         * f-exp.y: Update rules.
9443         (yylex): Update.
9444         * d-exp.y: Update rules.
9445         (lex_one_token, classify_name, classify_inner_name): Update.
9446         * parse.c (write_dollar_variable, copy_name): Return std::string.
9447         * parser-defs.h (copy_name): Change return type.
9448         * m2-exp.y: Update rules.
9449         (yylex): Update.
9450         * go-exp.y (lex_one_token): Update.
9451         Update rules.
9452         (classify_unsafe_function, classify_packaged_name)
9453         (classify_name, yylex): Update.
9454
9455 2019-04-19  Sergei Trofimovich <siarheit@google.com>
9456
9457         * configure.ac: add --enable-source-highlight switch.
9458         * configure: Regenerate.
9459         * top.c (print_gdb_version): plumb --enable-source-highlight
9460         status to "show configuration".
9461
9462 2019-04-19  Tom Tromey  <tromey@adacore.com>
9463
9464         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
9465         Check ADA_TYPE_P.
9466         (empty_record, ada_template_to_fixed_record_type_1)
9467         (template_to_static_fixed_type)
9468         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
9469         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
9470         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
9471         macros.
9472
9473 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
9474
9475         PR symtab/24423:
9476         * source.c (print_source_lines_base): Advance "iter" when a
9477         control character is seen.
9478
9479 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9480
9481         * inferior.h (struct infcall_suspend_state_deleter):
9482         Catch exception in destructor to avoid crash.
9483
9484 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9485
9486         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
9487         close to the add_com "shell".
9488
9489 2019-04-18  Tom Tromey  <tromey@adacore.com>
9490
9491         * process-stratum-target.h (class process_stratum_target)
9492         <stratum>: Add "final".
9493
9494 2019-04-17  Tom Tromey  <tromey@adacore.com>
9495
9496         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
9497         against nullptr before use.
9498
9499 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
9500
9501         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
9502
9503 2019-04-17  Jim Wilson  <jimw@sifive.com>
9504             Andrew Burgess  <andrew.burgess@embecosm.com>
9505
9506         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
9507         code read might fail, assume 4-byte breakpoint in that case.
9508
9509 2019-04-15  Leszek Swirski  <leszeks@google.com>
9510
9511         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
9512         rather than a hand-rolled POD check when checking for forced MEMORY
9513         classification.
9514
9515 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
9516
9517         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
9518         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
9519         function.
9520         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
9521         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
9522         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
9523         declaration.
9524
9525 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
9526
9527         * aarch64-linux-nat.c
9528         (aarch64_linux_nat_target::thread_architecture): Add override.
9529         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
9530         each VQ.
9531
9532 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
9533
9534         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
9535
9536 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
9537
9538         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
9539         target types of size 96-bits, add some additional comments, and
9540         check that the builtin type we found was the correct size.
9541
9542 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
9543
9544         * utils.c (prompt_for_continue): Don't restore the styling at the
9545         end, as applied_style has the wrong value.  This fixes styling in
9546         long lists of file names that are interrupted by the "Continue?"
9547         prompt.
9548
9549 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
9550
9551         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
9552         * c-lang.c (c_language_defn): Likewise.
9553         (cplus_language_defn): Likewise.
9554         (asm_language_defn): Likewise.
9555         (minimal_language_defn): Likewise.
9556         * d-lang.c (d_language_defn): Likewise.
9557         * f-lang.c (f_language_defn): Likewise.
9558         * go-lang.c (go_language_defn): Likewise.
9559         * language.c (unknown_language_defn): Likewise.
9560         (auto_language_defn): Likewise.
9561         * language.h (struct language_defn): Remove la_magic field.
9562         (LANG_MAGIC): Delete.
9563         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
9564         * objc-lang.c (objc_language_defn): Likewise.
9565         * opencl-lang.c (opencl_language_defn): Likewise.
9566         * p-lang.c (pascal_language_defn): Likewise.
9567         * rust-lang.c (rust_language_defn): Likewise.
9568
9569 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
9570
9571         * riscv-tdep.c (riscv_type_align): New function.
9572         (riscv_type_alignment): Delete.
9573         (riscv_arg_location): Use 'type_align'.
9574         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
9575
9576 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
9577
9578         * gdbtypes.c (type_align): A struct with no non-static fields also
9579         has alignment of 1.
9580
9581 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
9582
9583         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
9584         component to 0.
9585         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
9586         member.
9587         (riscv_struct_info::analyse): New implementation using new
9588         analyse_inner member function.
9589         (riscv_struct_info::field_offset): New member function.
9590         (riscv_struct_info::m_offsets): New member variable.
9591         (riscv_struct_info::analyse_inner): New private member function,
9592         takes the old implementation of riscv_struct_info::analyse but
9593         extended to track field offsets.
9594         (riscv_call_arg_struct): Update the struct folding special cases
9595         to handle cases where empty C++ structs, which are non-zero
9596         length, are found.
9597         (riscv_arg_location): Initialise the length of each location, a
9598         non-zero length now indicates the location is in use.
9599         (riscv_push_dummy_call): Allow for the first location having a
9600         non-zero offset when setting up arguments.
9601         (riscv_return_value): Likewise, but for return values.
9602
9603 2019-04-11  Tom Tromey  <tromey@adacore.com>
9604
9605         * utils.c (internal_vproblem): Make "msg" const.
9606
9607 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
9608
9609         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
9610         * trad-frame.c (trad_frame_reset_saved_regs): New function.
9611         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
9612         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
9613
9614 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
9615
9616         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
9617         function.
9618         (fill_gregset): Call amd64_linux_collect_native_gregset instead
9619         of amd64_collect_native_gregset.
9620         (amd64_linux_nat_target::store_registers): Likewise.
9621
9622 2019-04-10  Tom Tromey  <tom@tromey.com>
9623
9624         * symtab.c (lookup_global_symbol_from_objfile)
9625         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
9626         * objfiles.h (class separate_debug_iterator): New.
9627         (class separate_debug_range): New.
9628         (struct objfile) <separate_debug_objfiles>: New method.
9629         (objfile_separate_debug_iterate): Don't declare.
9630         * objfiles.c (separate_debug_iterator::operator++): Rename from
9631         objfile_separate_debug_iterate.
9632         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
9633         iterator.
9634         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
9635         iterator.
9636
9637 2019-04-10  Tom Tromey  <tom@tromey.com>
9638
9639         * symfile.c (reread_symbols): Remove old comment.
9640         * objfiles.c (free_all_objfiles): Fix a typo.
9641
9642 2019-04-10  Tom Tromey  <tom@tromey.com>
9643
9644         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
9645         * minsyms.c (lookup_minimal_symbol): Use foreach.
9646         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
9647         (lookup_minimal_symbol_solib_trampoline): Likewise.
9648         * symfile.c (reread_symbols): Use foreach.
9649
9650 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
9651             Tom Tromey  <tromey@adacore.com>
9652
9653         PR rust/24414:
9654         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
9655         (rust_lex_int_test): Change "value" to be LONGEST.
9656         (rust_lex_tests): Add test for long integer literal.
9657
9658 2019-04-09  Tom Tromey  <tromey@adacore.com>
9659
9660         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
9661         to bool.
9662         (extended_remote_target::attach): Update.
9663         (remote_target::remote_notice_new_inferior): Update.
9664         (remote_target::add_current_inferior_and_thread): Update.
9665         * inferior.c (exit_inferior_1): Use "false".
9666         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
9667
9668 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
9669
9670         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
9671         the "start" command.
9672
9673 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
9674
9675         * python/py-inferior.c (infpy_thread_from_thread_handle):
9676         Adjust comments to reflect renaming of thread_from_thread_handle
9677         to thread_from_handle.  Adjust keywords.  Fix type error message.
9678         (inferior_object_methods): Add thread_from_handle.  Retain
9679         thread_from_thread_handle, but mark it as deprecated.
9680
9681 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
9682
9683         * gdbthread.h (find_thread_by_handle): Revise declaration.
9684         * thread.c (find_thread_by_handle): Likewise.  Adjust
9685         implementation too.
9686         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
9687         support for buffer objects as handles.
9688
9689 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
9690
9691         * python/py-infthread.c (thpy_thread_handle): New function.
9692         (thread_object_methods): Register thpy_thread_handle.
9693
9694 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
9695
9696         * gdbthread.h (thread_to_thread_handle): Declare.
9697         * thread.c (gdbtypes.h): Include.
9698         (thread_to_thread_handle): New function.
9699
9700         * target.h (struct target_ops): Add thread_info_to_thread_handle.
9701         (target_thread_info_to_thread_handle): Declare.
9702         * target.c (target_thread_info_to_thread_handle): New function.
9703         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
9704         * target-delegates.c: Regenerate.
9705
9706         * linux-thread-db.c (class thread_db_target): Add method
9707         thread_info_to_thread_handle.
9708         (thread_db_target::thread_info_to_thread_handle): Define.
9709         * remote.c (class remote_target): Add new method
9710         thread_info_to_thread_handle.
9711         (remote_target::thread_info_to_thread_handle): Define.
9712
9713 2019-04-08  Pedro Alves  <palves@redhat.com>
9714
9715         * common/common-exceptions.c (throw_exception): Don't create
9716         named object to throw; throw directly.
9717         (throw_it): Likewise.  Don't initialize gdb_exception::message
9718         here, with new; pass FMT and AP to the ctor instead.
9719         * common/common-exceptions.h: Include <string>.
9720         (gdb_exception::gdb_exception(enum return_reason, enum errors,
9721         const char *, va_list)): New ctor.  Use std::make_shared.
9722         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
9723         errors)): Delete.
9724         (gdb_exception_error::gdb_exception_error(enum errors, const char
9725         *, va_list)): New.
9726         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
9727         Add assertion.
9728         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
9729         errors)): Delete.
9730         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
9731         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
9732         Add assertion.
9733
9734 2019-04-08  Tom Tromey  <tom@tromey.com>
9735
9736         * valops.c (value_rtti_indirect_type): Replace throw_exception
9737         with throw.
9738         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
9739         with throw.
9740         * thread.c (thr_try_catch_cmd): Replace throw_exception with
9741         throw.
9742         * target.c (target_translate_tls_address): Replace throw_exception
9743         with throw.
9744         * stack.c (frame_apply_command_count): Replace throw_exception
9745         with throw.
9746         * solib-spu.c (append_ocl_sos): Replace throw_exception with
9747         throw.
9748         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
9749         with throw.
9750         * rs6000-tdep.c (rs6000_frame_cache)
9751         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
9752         * remote.c: Replace throw_exception with throw.
9753         * record-full.c (record_full_message, record_full_wait_1)
9754         (record_full_restore): Replace throw_exception with throw.
9755         * record-btrace.c:
9756         (get_thread_current_frame_id, record_btrace_start_replaying)
9757         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
9758         (cmd_record_btrace_start): Replace throw_exception with throw.
9759         * parse.c (parse_exp_in_context_1): Replace throw_exception with
9760         throw.
9761         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
9762         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
9763         * linespec.c:
9764         (find_linespec_symbols): Replace throw_exception with throw.
9765         * infrun.c (displaced_step_prepare, resume): Replace
9766         throw_exception with throw.
9767         * infcmd.c (post_create_inferior): Replace throw_exception with
9768         throw.
9769         * inf-loop.c (inferior_event_handler): Replace throw_exception
9770         with throw.
9771         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
9772         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
9773         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
9774         (get_prev_frame_always, get_frame_pc_if_available)
9775         (get_frame_address_in_block_if_available, get_frame_language):
9776         Replace throw_exception with throw.
9777         * frame-unwind.c (frame_unwind_try_unwinder): Replace
9778         throw_exception with throw.
9779         * eval.c (fetch_subexp_value, evaluate_var_value)
9780         (evaluate_funcall, evaluate_subexp_standard): Replace
9781         throw_exception with throw.
9782         * dwarf2loc.c (call_site_find_chain)
9783         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
9784         Replace throw_exception with throw.
9785         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
9786         with throw.
9787         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
9788         throw.
9789         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
9790         * completer.c (complete_line_internal): Replace throw_exception
9791         with throw.
9792         * compile/compile-object-run.c (compile_object_run): Replace
9793         throw_exception with throw.
9794         * cli/cli-script.c (process_next_line): Replace throw_exception
9795         with throw.
9796         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
9797         (btrace_enable, btrace_maint_update_pt_packets): Replace
9798         throw_exception with throw.
9799         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
9800         throw_exception with throw.
9801         * break-catch-throw.c (re_set_exception_catchpoint): Replace
9802         throw_exception with throw.
9803         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
9804         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
9805         * aarch64-tdep.c (aarch64_make_prologue_cache)
9806         (aarch64_make_stub_cache): Replace throw_exception with throw.
9807
9808 2019-04-08  Tom Tromey  <tom@tromey.com>
9809
9810         * common/common-exceptions.c (throw_exception): Rename from
9811         throw_exception_cxx.  Remove old copy.  Make argument const.
9812         (throw_it): Create and throw exception objects directly.
9813         * common/common-exceptions.h (throw_exception): Make argument
9814         const.
9815         (struct gdb_exception_error): Add constructor.
9816         (struct gdb_exception_quit): Add constructor.
9817
9818 2019-04-08  Tom Tromey  <tom@tromey.com>
9819
9820         * common/common-exceptions.h (exception_rethrow): Don't declare.
9821         (TRY_SJLJ): Update comment.
9822         (TRY, CATCH, END_CATCH): Remove.
9823         * common/common-exceptions.c (exception_rethrow): Remove.
9824
9825 2019-04-08  Tom Tromey  <tom@tromey.com>
9826
9827         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
9828         Remove.
9829         (gdb_exception_error): Rename from
9830         gdb_exception_RETURN_MASK_ERROR.
9831         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
9832         (gdb_quit_bad_alloc): Update.
9833         * aarch64-tdep.c: Update.
9834         * ada-lang.c: Update.
9835         * ada-typeprint.c: Update.
9836         * ada-valprint.c: Update.
9837         * amd64-tdep.c: Update.
9838         * arch-utils.c: Update.
9839         * break-catch-throw.c: Update.
9840         * breakpoint.c: Update.
9841         * btrace.c: Update.
9842         * c-varobj.c: Update.
9843         * cli/cli-cmds.c: Update.
9844         * cli/cli-interp.c: Update.
9845         * cli/cli-script.c: Update.
9846         * common/common-exceptions.c: Update.
9847         * common/new-op.c: Update.
9848         * common/selftest.c: Update.
9849         * compile/compile-c-symbols.c: Update.
9850         * compile/compile-cplus-symbols.c: Update.
9851         * compile/compile-object-load.c: Update.
9852         * compile/compile-object-run.c: Update.
9853         * completer.c: Update.
9854         * corelow.c: Update.
9855         * cp-abi.c: Update.
9856         * cp-support.c: Update.
9857         * cp-valprint.c: Update.
9858         * darwin-nat.c: Update.
9859         * disasm-selftests.c: Update.
9860         * dtrace-probe.c: Update.
9861         * dwarf-index-cache.c: Update.
9862         * dwarf-index-write.c: Update.
9863         * dwarf2-frame-tailcall.c: Update.
9864         * dwarf2-frame.c: Update.
9865         * dwarf2loc.c: Update.
9866         * dwarf2read.c: Update.
9867         * eval.c: Update.
9868         * event-loop.c: Update.
9869         * event-top.c: Update.
9870         * exec.c: Update.
9871         * f-valprint.c: Update.
9872         * fbsd-tdep.c: Update.
9873         * frame-unwind.c: Update.
9874         * frame.c: Update.
9875         * gdbtypes.c: Update.
9876         * gnu-v3-abi.c: Update.
9877         * guile/guile-internal.h: Update.
9878         * guile/scm-block.c: Update.
9879         * guile/scm-breakpoint.c: Update.
9880         * guile/scm-cmd.c: Update.
9881         * guile/scm-disasm.c: Update.
9882         * guile/scm-frame.c: Update.
9883         * guile/scm-lazy-string.c: Update.
9884         * guile/scm-math.c: Update.
9885         * guile/scm-param.c: Update.
9886         * guile/scm-ports.c: Update.
9887         * guile/scm-pretty-print.c: Update.
9888         * guile/scm-symbol.c: Update.
9889         * guile/scm-symtab.c: Update.
9890         * guile/scm-type.c: Update.
9891         * guile/scm-value.c: Update.
9892         * i386-linux-tdep.c: Update.
9893         * i386-tdep.c: Update.
9894         * inf-loop.c: Update.
9895         * infcall.c: Update.
9896         * infcmd.c: Update.
9897         * infrun.c: Update.
9898         * jit.c: Update.
9899         * language.c: Update.
9900         * linespec.c: Update.
9901         * linux-fork.c: Update.
9902         * linux-nat.c: Update.
9903         * linux-tdep.c: Update.
9904         * linux-thread-db.c: Update.
9905         * main.c: Update.
9906         * mi/mi-cmd-break.c: Update.
9907         * mi/mi-cmd-stack.c: Update.
9908         * mi/mi-interp.c: Update.
9909         * mi/mi-main.c: Update.
9910         * objc-lang.c: Update.
9911         * p-valprint.c: Update.
9912         * parse.c: Update.
9913         * ppc-linux-tdep.c: Update.
9914         * printcmd.c: Update.
9915         * python/py-arch.c: Update.
9916         * python/py-breakpoint.c: Update.
9917         * python/py-cmd.c: Update.
9918         * python/py-finishbreakpoint.c: Update.
9919         * python/py-frame.c: Update.
9920         * python/py-framefilter.c: Update.
9921         * python/py-gdb-readline.c: Update.
9922         * python/py-inferior.c: Update.
9923         * python/py-infthread.c: Update.
9924         * python/py-lazy-string.c: Update.
9925         * python/py-linetable.c: Update.
9926         * python/py-objfile.c: Update.
9927         * python/py-param.c: Update.
9928         * python/py-prettyprint.c: Update.
9929         * python/py-progspace.c: Update.
9930         * python/py-record-btrace.c: Update.
9931         * python/py-record.c: Update.
9932         * python/py-symbol.c: Update.
9933         * python/py-type.c: Update.
9934         * python/py-unwind.c: Update.
9935         * python/py-utils.c: Update.
9936         * python/py-value.c: Update.
9937         * python/python.c: Update.
9938         * record-btrace.c: Update.
9939         * record-full.c: Update.
9940         * remote-fileio.c: Update.
9941         * remote.c: Update.
9942         * riscv-tdep.c: Update.
9943         * rs6000-aix-tdep.c: Update.
9944         * rs6000-tdep.c: Update.
9945         * rust-exp.y: Update.
9946         * rust-lang.c: Update.
9947         * s390-tdep.c: Update.
9948         * selftest-arch.c: Update.
9949         * solib-dsbt.c: Update.
9950         * solib-frv.c: Update.
9951         * solib-spu.c: Update.
9952         * solib-svr4.c: Update.
9953         * solib.c: Update.
9954         * sparc64-linux-tdep.c: Update.
9955         * stack.c: Update.
9956         * symfile-mem.c: Update.
9957         * symmisc.c: Update.
9958         * target.c: Update.
9959         * thread.c: Update.
9960         * top.c: Update.
9961         * tracefile-tfile.c: Update.
9962         * tui/tui.c: Update.
9963         * typeprint.c: Update.
9964         * unittests/cli-utils-selftests.c: Update.
9965         * unittests/parse-connection-spec-selftests.c: Update.
9966         * valops.c: Update.
9967         * valprint.c: Update.
9968         * value.c: Update.
9969         * varobj.c: Update.
9970         * windows-nat.c: Update.
9971         * x86-linux-nat.c: Update.
9972         * xml-support.c: Update.
9973
9974 2019-04-08  Tom Tromey  <tom@tromey.com>
9975
9976         * xml-support.c: Use C++ exception handling.
9977         * x86-linux-nat.c: Use C++ exception handling.
9978         * windows-nat.c: Use C++ exception handling.
9979         * varobj.c: Use C++ exception handling.
9980         * value.c: Use C++ exception handling.
9981         * valprint.c: Use C++ exception handling.
9982         * valops.c: Use C++ exception handling.
9983         * unittests/parse-connection-spec-selftests.c: Use C++ exception
9984         handling.
9985         * unittests/cli-utils-selftests.c: Use C++ exception handling.
9986         * typeprint.c: Use C++ exception handling.
9987         * tui/tui.c: Use C++ exception handling.
9988         * tracefile-tfile.c: Use C++ exception handling.
9989         * top.c: Use C++ exception handling.
9990         * thread.c: Use C++ exception handling.
9991         * target.c: Use C++ exception handling.
9992         * symmisc.c: Use C++ exception handling.
9993         * symfile-mem.c: Use C++ exception handling.
9994         * stack.c: Use C++ exception handling.
9995         * sparc64-linux-tdep.c: Use C++ exception handling.
9996         * solib.c: Use C++ exception handling.
9997         * solib-svr4.c: Use C++ exception handling.
9998         * solib-spu.c: Use C++ exception handling.
9999         * solib-frv.c: Use C++ exception handling.
10000         * solib-dsbt.c: Use C++ exception handling.
10001         * selftest-arch.c: Use C++ exception handling.
10002         * s390-tdep.c: Use C++ exception handling.
10003         * rust-lang.c: Use C++ exception handling.
10004         * rust-exp.y: Use C++ exception handling.
10005         * rs6000-tdep.c: Use C++ exception handling.
10006         * rs6000-aix-tdep.c: Use C++ exception handling.
10007         * riscv-tdep.c: Use C++ exception handling.
10008         * remote.c: Use C++ exception handling.
10009         * remote-fileio.c: Use C++ exception handling.
10010         * record-full.c: Use C++ exception handling.
10011         * record-btrace.c: Use C++ exception handling.
10012         * python/python.c: Use C++ exception handling.
10013         * python/py-value.c: Use C++ exception handling.
10014         * python/py-utils.c: Use C++ exception handling.
10015         * python/py-unwind.c: Use C++ exception handling.
10016         * python/py-type.c: Use C++ exception handling.
10017         * python/py-symbol.c: Use C++ exception handling.
10018         * python/py-record.c: Use C++ exception handling.
10019         * python/py-record-btrace.c: Use C++ exception handling.
10020         * python/py-progspace.c: Use C++ exception handling.
10021         * python/py-prettyprint.c: Use C++ exception handling.
10022         * python/py-param.c: Use C++ exception handling.
10023         * python/py-objfile.c: Use C++ exception handling.
10024         * python/py-linetable.c: Use C++ exception handling.
10025         * python/py-lazy-string.c: Use C++ exception handling.
10026         * python/py-infthread.c: Use C++ exception handling.
10027         * python/py-inferior.c: Use C++ exception handling.
10028         * python/py-gdb-readline.c: Use C++ exception handling.
10029         * python/py-framefilter.c: Use C++ exception handling.
10030         * python/py-frame.c: Use C++ exception handling.
10031         * python/py-finishbreakpoint.c: Use C++ exception handling.
10032         * python/py-cmd.c: Use C++ exception handling.
10033         * python/py-breakpoint.c: Use C++ exception handling.
10034         * python/py-arch.c: Use C++ exception handling.
10035         * printcmd.c: Use C++ exception handling.
10036         * ppc-linux-tdep.c: Use C++ exception handling.
10037         * parse.c: Use C++ exception handling.
10038         * p-valprint.c: Use C++ exception handling.
10039         * objc-lang.c: Use C++ exception handling.
10040         * mi/mi-main.c: Use C++ exception handling.
10041         * mi/mi-interp.c: Use C++ exception handling.
10042         * mi/mi-cmd-stack.c: Use C++ exception handling.
10043         * mi/mi-cmd-break.c: Use C++ exception handling.
10044         * main.c: Use C++ exception handling.
10045         * linux-thread-db.c: Use C++ exception handling.
10046         * linux-tdep.c: Use C++ exception handling.
10047         * linux-nat.c: Use C++ exception handling.
10048         * linux-fork.c: Use C++ exception handling.
10049         * linespec.c: Use C++ exception handling.
10050         * language.c: Use C++ exception handling.
10051         * jit.c: Use C++ exception handling.
10052         * infrun.c: Use C++ exception handling.
10053         * infcmd.c: Use C++ exception handling.
10054         * infcall.c: Use C++ exception handling.
10055         * inf-loop.c: Use C++ exception handling.
10056         * i386-tdep.c: Use C++ exception handling.
10057         * i386-linux-tdep.c: Use C++ exception handling.
10058         * guile/scm-value.c: Use C++ exception handling.
10059         * guile/scm-type.c: Use C++ exception handling.
10060         * guile/scm-symtab.c: Use C++ exception handling.
10061         * guile/scm-symbol.c: Use C++ exception handling.
10062         * guile/scm-pretty-print.c: Use C++ exception handling.
10063         * guile/scm-ports.c: Use C++ exception handling.
10064         * guile/scm-param.c: Use C++ exception handling.
10065         * guile/scm-math.c: Use C++ exception handling.
10066         * guile/scm-lazy-string.c: Use C++ exception handling.
10067         * guile/scm-frame.c: Use C++ exception handling.
10068         * guile/scm-disasm.c: Use C++ exception handling.
10069         * guile/scm-cmd.c: Use C++ exception handling.
10070         * guile/scm-breakpoint.c: Use C++ exception handling.
10071         * guile/scm-block.c: Use C++ exception handling.
10072         * guile/guile-internal.h: Use C++ exception handling.
10073         * gnu-v3-abi.c: Use C++ exception handling.
10074         * gdbtypes.c: Use C++ exception handling.
10075         * frame.c: Use C++ exception handling.
10076         * frame-unwind.c: Use C++ exception handling.
10077         * fbsd-tdep.c: Use C++ exception handling.
10078         * f-valprint.c: Use C++ exception handling.
10079         * exec.c: Use C++ exception handling.
10080         * event-top.c: Use C++ exception handling.
10081         * event-loop.c: Use C++ exception handling.
10082         * eval.c: Use C++ exception handling.
10083         * dwarf2read.c: Use C++ exception handling.
10084         * dwarf2loc.c: Use C++ exception handling.
10085         * dwarf2-frame.c: Use C++ exception handling.
10086         * dwarf2-frame-tailcall.c: Use C++ exception handling.
10087         * dwarf-index-write.c: Use C++ exception handling.
10088         * dwarf-index-cache.c: Use C++ exception handling.
10089         * dtrace-probe.c: Use C++ exception handling.
10090         * disasm-selftests.c: Use C++ exception handling.
10091         * darwin-nat.c: Use C++ exception handling.
10092         * cp-valprint.c: Use C++ exception handling.
10093         * cp-support.c: Use C++ exception handling.
10094         * cp-abi.c: Use C++ exception handling.
10095         * corelow.c: Use C++ exception handling.
10096         * completer.c: Use C++ exception handling.
10097         * compile/compile-object-run.c: Use C++ exception handling.
10098         * compile/compile-object-load.c: Use C++ exception handling.
10099         * compile/compile-cplus-symbols.c: Use C++ exception handling.
10100         * compile/compile-c-symbols.c: Use C++ exception handling.
10101         * common/selftest.c: Use C++ exception handling.
10102         * common/new-op.c: Use C++ exception handling.
10103         * cli/cli-script.c: Use C++ exception handling.
10104         * cli/cli-interp.c: Use C++ exception handling.
10105         * cli/cli-cmds.c: Use C++ exception handling.
10106         * c-varobj.c: Use C++ exception handling.
10107         * btrace.c: Use C++ exception handling.
10108         * breakpoint.c: Use C++ exception handling.
10109         * break-catch-throw.c: Use C++ exception handling.
10110         * arch-utils.c: Use C++ exception handling.
10111         * amd64-tdep.c: Use C++ exception handling.
10112         * ada-valprint.c: Use C++ exception handling.
10113         * ada-typeprint.c: Use C++ exception handling.
10114         * ada-lang.c: Use C++ exception handling.
10115         * aarch64-tdep.c: Use C++ exception handling.
10116
10117 2019-04-08  Tom Tromey  <tom@tromey.com>
10118
10119         * xml-support.c (gdb_xml_parser::parse): Update.
10120         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
10121         * value.c (show_convenience): Update.
10122         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
10123         (test_parse_flags_qcs): Update.
10124         * thread.c (thr_try_catch_cmd): Update.
10125         * target.c (target_translate_tls_address): Update.
10126         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
10127         (info_frame_command_core, frame_apply_command_count): Update.
10128         * rust-exp.y (rust_lex_exception_test): Update.
10129         * riscv-tdep.c (riscv_print_one_register_info): Update.
10130         * remote.c (remote_target::enable_btrace): Update.
10131         * record-btrace.c (record_btrace_enable_warn): Update.
10132         * python/py-utils.c (gdbpy_convert_exception): Update.
10133         * printcmd.c (do_one_display, print_variable_and_value): Update.
10134         * mi/mi-main.c (mi_print_exception): Update.
10135         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
10136         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
10137         * linux-nat.c (linux_nat_target::attach): Update.
10138         * linux-fork.c (class scoped_switch_fork_info): Update.
10139         * infrun.c (displaced_step_prepare): Update.
10140         * infcall.c (call_function_by_hand_dummy): Update.
10141         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
10142         * gnu-v3-abi.c (print_one_vtable): Update.
10143         * frame.c (get_prev_frame_always): Update.
10144         * f-valprint.c (info_common_command_for_block): Update.
10145         * exec.c (try_open_exec_file): Update.
10146         * exceptions.c (print_exception, exception_print)
10147         (exception_fprintf, exception_print_same): Update.
10148         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
10149         * dwarf-index-cache.c (index_cache::store)
10150         (index_cache::lookup_gdb_index): Update.
10151         * darwin-nat.c (maybe_cache_shell): Update.
10152         * cp-valprint.c (cp_print_value_fields): Update.
10153         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
10154         (gcc_cplus_symbol_address): Update.
10155         * compile/compile-c-symbols.c (gcc_convert_symbol)
10156         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
10157         * common/selftest.c: Update.
10158         * common/common-exceptions.h (struct gdb_exception) <message>: Now
10159         a std::string.
10160         (exception_try_scope_entry, exception_try_scope_exit): Don't
10161         declare.
10162         (struct exception_try_scope): Remove.
10163         (TRY): Don't use exception_try_scope.
10164         (struct gdb_exception): Add constructor, operator=.
10165         <what>: New method.
10166         (struct gdb_exception_RETURN_MASK_ALL)
10167         (struct gdb_exception_RETURN_MASK_ERROR)
10168         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
10169         (struct gdb_quit_bad_alloc): Update.
10170         * common/common-exceptions.c (exception_none): Change
10171         initializer.
10172         (struct catcher) <state, exception>: Initialize inline.
10173         <prev>: Remove member.
10174         (current_catcher): Remove.
10175         (catchers): New global.
10176         (exceptions_state_mc_init): Simplify.
10177         (catcher_pop): Remove.
10178         (exceptions_state_mc, exceptions_state_mc_catch): Update.
10179         (try_scope_depth, exception_try_scope_entry)
10180         (exception_try_scope_exit): Remove.
10181         (throw_exception_sjlj): Update.
10182         (exception_messages, exception_messages_size): Remove.
10183         (throw_it): Simplify.
10184         (gdb_exception_sliced_copy): Remove.
10185         (throw_exception_cxx): Update.
10186         * cli/cli-script.c (script_from_file): Update.
10187         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
10188         Update.
10189         * ada-valprint.c (ada_val_print): Update.
10190         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
10191         (create_excep_cond_exprs): Update.
10192
10193 2019-04-08  Tom Tromey  <tom@tromey.com>
10194
10195         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
10196         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
10197         (TRY, CATCH, END_CATCH): Remove some definitions.
10198         * common/common-exceptions.c: Don't use GDB_XCPT.
10199         (catcher_list_size): Remove.
10200         (throw_exception, throw_it): Simplify.
10201
10202 2019-04-05  Tom Tromey  <tom@tromey.com>
10203
10204         Revert the header-sorting patch.
10205         * ft32-tdep.c: Revert.
10206         * frv-tdep.c: Revert.
10207         * frv-linux-tdep.c: Revert.
10208         * frame.c: Revert.
10209         * frame-unwind.c: Revert.
10210         * frame-base.c: Revert.
10211         * fork-child.c: Revert.
10212         * findvar.c: Revert.
10213         * findcmd.c: Revert.
10214         * filesystem.c: Revert.
10215         * filename-seen-cache.h: Revert.
10216         * filename-seen-cache.c: Revert.
10217         * fbsd-tdep.c: Revert.
10218         * fbsd-nat.h: Revert.
10219         * fbsd-nat.c: Revert.
10220         * f-valprint.c: Revert.
10221         * f-typeprint.c: Revert.
10222         * f-lang.c: Revert.
10223         * extension.h: Revert.
10224         * extension.c: Revert.
10225         * extension-priv.h: Revert.
10226         * expprint.c: Revert.
10227         * exec.h: Revert.
10228         * exec.c: Revert.
10229         * exceptions.c: Revert.
10230         * event-top.c: Revert.
10231         * event-loop.c: Revert.
10232         * eval.c: Revert.
10233         * elfread.c: Revert.
10234         * dwarf2read.h: Revert.
10235         * dwarf2read.c: Revert.
10236         * dwarf2loc.c: Revert.
10237         * dwarf2expr.h: Revert.
10238         * dwarf2expr.c: Revert.
10239         * dwarf2-frame.c: Revert.
10240         * dwarf2-frame-tailcall.c: Revert.
10241         * dwarf-index-write.h: Revert.
10242         * dwarf-index-write.c: Revert.
10243         * dwarf-index-common.c: Revert.
10244         * dwarf-index-cache.h: Revert.
10245         * dwarf-index-cache.c: Revert.
10246         * dummy-frame.c: Revert.
10247         * dtrace-probe.c: Revert.
10248         * disasm.h: Revert.
10249         * disasm.c: Revert.
10250         * disasm-selftests.c: Revert.
10251         * dictionary.c: Revert.
10252         * dicos-tdep.c: Revert.
10253         * demangle.c: Revert.
10254         * dcache.h: Revert.
10255         * dcache.c: Revert.
10256         * darwin-nat.h: Revert.
10257         * darwin-nat.c: Revert.
10258         * darwin-nat-info.c: Revert.
10259         * d-valprint.c: Revert.
10260         * d-namespace.c: Revert.
10261         * d-lang.c: Revert.
10262         * ctf.c: Revert.
10263         * csky-tdep.c: Revert.
10264         * csky-linux-tdep.c: Revert.
10265         * cris-tdep.c: Revert.
10266         * cris-linux-tdep.c: Revert.
10267         * cp-valprint.c: Revert.
10268         * cp-support.c: Revert.
10269         * cp-namespace.c: Revert.
10270         * cp-abi.c: Revert.
10271         * corelow.c: Revert.
10272         * corefile.c: Revert.
10273         * continuations.c: Revert.
10274         * completer.h: Revert.
10275         * completer.c: Revert.
10276         * complaints.c: Revert.
10277         * coffread.c: Revert.
10278         * coff-pe-read.c: Revert.
10279         * cli-out.h: Revert.
10280         * cli-out.c: Revert.
10281         * charset.c: Revert.
10282         * c-varobj.c: Revert.
10283         * c-valprint.c: Revert.
10284         * c-typeprint.c: Revert.
10285         * c-lang.c: Revert.
10286         * buildsym.c: Revert.
10287         * buildsym-legacy.c: Revert.
10288         * build-id.h: Revert.
10289         * build-id.c: Revert.
10290         * btrace.c: Revert.
10291         * bsd-uthread.c: Revert.
10292         * breakpoint.h: Revert.
10293         * breakpoint.c: Revert.
10294         * break-catch-throw.c: Revert.
10295         * break-catch-syscall.c: Revert.
10296         * break-catch-sig.c: Revert.
10297         * blockframe.c: Revert.
10298         * block.c: Revert.
10299         * bfin-tdep.c: Revert.
10300         * bfin-linux-tdep.c: Revert.
10301         * bfd-target.c: Revert.
10302         * bcache.c: Revert.
10303         * ax-general.c: Revert.
10304         * ax-gdb.h: Revert.
10305         * ax-gdb.c: Revert.
10306         * avr-tdep.c: Revert.
10307         * auxv.c: Revert.
10308         * auto-load.c: Revert.
10309         * arm-wince-tdep.c: Revert.
10310         * arm-tdep.c: Revert.
10311         * arm-symbian-tdep.c: Revert.
10312         * arm-pikeos-tdep.c: Revert.
10313         * arm-obsd-tdep.c: Revert.
10314         * arm-nbsd-tdep.c: Revert.
10315         * arm-nbsd-nat.c: Revert.
10316         * arm-linux-tdep.c: Revert.
10317         * arm-linux-nat.c: Revert.
10318         * arm-fbsd-tdep.c: Revert.
10319         * arm-fbsd-nat.c: Revert.
10320         * arm-bsd-tdep.c: Revert.
10321         * arch-utils.c: Revert.
10322         * arc-tdep.c: Revert.
10323         * arc-newlib-tdep.c: Revert.
10324         * annotate.h: Revert.
10325         * annotate.c: Revert.
10326         * amd64-windows-tdep.c: Revert.
10327         * amd64-windows-nat.c: Revert.
10328         * amd64-tdep.c: Revert.
10329         * amd64-sol2-tdep.c: Revert.
10330         * amd64-obsd-tdep.c: Revert.
10331         * amd64-obsd-nat.c: Revert.
10332         * amd64-nbsd-tdep.c: Revert.
10333         * amd64-nbsd-nat.c: Revert.
10334         * amd64-nat.c: Revert.
10335         * amd64-linux-tdep.c: Revert.
10336         * amd64-linux-nat.c: Revert.
10337         * amd64-fbsd-tdep.c: Revert.
10338         * amd64-fbsd-nat.c: Revert.
10339         * amd64-dicos-tdep.c: Revert.
10340         * amd64-darwin-tdep.c: Revert.
10341         * amd64-bsd-nat.c: Revert.
10342         * alpha-tdep.c: Revert.
10343         * alpha-obsd-tdep.c: Revert.
10344         * alpha-nbsd-tdep.c: Revert.
10345         * alpha-mdebug-tdep.c: Revert.
10346         * alpha-linux-tdep.c: Revert.
10347         * alpha-linux-nat.c: Revert.
10348         * alpha-bsd-tdep.c: Revert.
10349         * alpha-bsd-nat.c: Revert.
10350         * aix-thread.c: Revert.
10351         * agent.c: Revert.
10352         * addrmap.c: Revert.
10353         * ada-varobj.c: Revert.
10354         * ada-valprint.c: Revert.
10355         * ada-typeprint.c: Revert.
10356         * ada-tasks.c: Revert.
10357         * ada-lang.c: Revert.
10358         * aarch64-tdep.c: Revert.
10359         * aarch64-ravenscar-thread.c: Revert.
10360         * aarch64-newlib-tdep.c: Revert.
10361         * aarch64-linux-tdep.c: Revert.
10362         * aarch64-linux-nat.c: Revert.
10363         * aarch64-fbsd-tdep.c: Revert.
10364         * aarch64-fbsd-nat.c: Revert.
10365         * aarch32-linux-nat.c: Revert.
10366
10367 2019-04-05  Tom Tromey  <tom@tromey.com>
10368
10369         * ft32-tdep.c: Sort headers.
10370         * frv-tdep.c: Sort headers.
10371         * frv-linux-tdep.c: Sort headers.
10372         * frame.c: Sort headers.
10373         * frame-unwind.c: Sort headers.
10374         * frame-base.c: Sort headers.
10375         * fork-child.c: Sort headers.
10376         * findvar.c: Sort headers.
10377         * findcmd.c: Sort headers.
10378         * filesystem.c: Sort headers.
10379         * filename-seen-cache.h: Sort headers.
10380         * filename-seen-cache.c: Sort headers.
10381         * fbsd-tdep.c: Sort headers.
10382         * fbsd-nat.h: Sort headers.
10383         * fbsd-nat.c: Sort headers.
10384         * f-valprint.c: Sort headers.
10385         * f-typeprint.c: Sort headers.
10386         * f-lang.c: Sort headers.
10387         * extension.h: Sort headers.
10388         * extension.c: Sort headers.
10389         * extension-priv.h: Sort headers.
10390         * expprint.c: Sort headers.
10391         * exec.h: Sort headers.
10392         * exec.c: Sort headers.
10393         * exceptions.c: Sort headers.
10394         * event-top.c: Sort headers.
10395         * event-loop.c: Sort headers.
10396         * eval.c: Sort headers.
10397         * elfread.c: Sort headers.
10398         * dwarf2read.h: Sort headers.
10399         * dwarf2read.c: Sort headers.
10400         * dwarf2loc.c: Sort headers.
10401         * dwarf2expr.h: Sort headers.
10402         * dwarf2expr.c: Sort headers.
10403         * dwarf2-frame.c: Sort headers.
10404         * dwarf2-frame-tailcall.c: Sort headers.
10405         * dwarf-index-write.h: Sort headers.
10406         * dwarf-index-write.c: Sort headers.
10407         * dwarf-index-common.c: Sort headers.
10408         * dwarf-index-cache.h: Sort headers.
10409         * dwarf-index-cache.c: Sort headers.
10410         * dummy-frame.c: Sort headers.
10411         * dtrace-probe.c: Sort headers.
10412         * disasm.h: Sort headers.
10413         * disasm.c: Sort headers.
10414         * disasm-selftests.c: Sort headers.
10415         * dictionary.c: Sort headers.
10416         * dicos-tdep.c: Sort headers.
10417         * demangle.c: Sort headers.
10418         * dcache.h: Sort headers.
10419         * dcache.c: Sort headers.
10420         * darwin-nat.h: Sort headers.
10421         * darwin-nat.c: Sort headers.
10422         * darwin-nat-info.c: Sort headers.
10423         * d-valprint.c: Sort headers.
10424         * d-namespace.c: Sort headers.
10425         * d-lang.c: Sort headers.
10426         * ctf.c: Sort headers.
10427         * csky-tdep.c: Sort headers.
10428         * csky-linux-tdep.c: Sort headers.
10429         * cris-tdep.c: Sort headers.
10430         * cris-linux-tdep.c: Sort headers.
10431         * cp-valprint.c: Sort headers.
10432         * cp-support.c: Sort headers.
10433         * cp-namespace.c: Sort headers.
10434         * cp-abi.c: Sort headers.
10435         * corelow.c: Sort headers.
10436         * corefile.c: Sort headers.
10437         * continuations.c: Sort headers.
10438         * completer.h: Sort headers.
10439         * completer.c: Sort headers.
10440         * complaints.c: Sort headers.
10441         * coffread.c: Sort headers.
10442         * coff-pe-read.c: Sort headers.
10443         * cli-out.h: Sort headers.
10444         * cli-out.c: Sort headers.
10445         * charset.c: Sort headers.
10446         * c-varobj.c: Sort headers.
10447         * c-valprint.c: Sort headers.
10448         * c-typeprint.c: Sort headers.
10449         * c-lang.c: Sort headers.
10450         * buildsym.c: Sort headers.
10451         * buildsym-legacy.c: Sort headers.
10452         * build-id.h: Sort headers.
10453         * build-id.c: Sort headers.
10454         * btrace.c: Sort headers.
10455         * bsd-uthread.c: Sort headers.
10456         * breakpoint.h: Sort headers.
10457         * breakpoint.c: Sort headers.
10458         * break-catch-throw.c: Sort headers.
10459         * break-catch-syscall.c: Sort headers.
10460         * break-catch-sig.c: Sort headers.
10461         * blockframe.c: Sort headers.
10462         * block.c: Sort headers.
10463         * bfin-tdep.c: Sort headers.
10464         * bfin-linux-tdep.c: Sort headers.
10465         * bfd-target.c: Sort headers.
10466         * bcache.c: Sort headers.
10467         * ax-general.c: Sort headers.
10468         * ax-gdb.h: Sort headers.
10469         * ax-gdb.c: Sort headers.
10470         * avr-tdep.c: Sort headers.
10471         * auxv.c: Sort headers.
10472         * auto-load.c: Sort headers.
10473         * arm-wince-tdep.c: Sort headers.
10474         * arm-tdep.c: Sort headers.
10475         * arm-symbian-tdep.c: Sort headers.
10476         * arm-pikeos-tdep.c: Sort headers.
10477         * arm-obsd-tdep.c: Sort headers.
10478         * arm-nbsd-tdep.c: Sort headers.
10479         * arm-nbsd-nat.c: Sort headers.
10480         * arm-linux-tdep.c: Sort headers.
10481         * arm-linux-nat.c: Sort headers.
10482         * arm-fbsd-tdep.c: Sort headers.
10483         * arm-fbsd-nat.c: Sort headers.
10484         * arm-bsd-tdep.c: Sort headers.
10485         * arch-utils.c: Sort headers.
10486         * arc-tdep.c: Sort headers.
10487         * arc-newlib-tdep.c: Sort headers.
10488         * annotate.h: Sort headers.
10489         * annotate.c: Sort headers.
10490         * amd64-windows-tdep.c: Sort headers.
10491         * amd64-windows-nat.c: Sort headers.
10492         * amd64-tdep.c: Sort headers.
10493         * amd64-sol2-tdep.c: Sort headers.
10494         * amd64-obsd-tdep.c: Sort headers.
10495         * amd64-obsd-nat.c: Sort headers.
10496         * amd64-nbsd-tdep.c: Sort headers.
10497         * amd64-nbsd-nat.c: Sort headers.
10498         * amd64-nat.c: Sort headers.
10499         * amd64-linux-tdep.c: Sort headers.
10500         * amd64-linux-nat.c: Sort headers.
10501         * amd64-fbsd-tdep.c: Sort headers.
10502         * amd64-fbsd-nat.c: Sort headers.
10503         * amd64-dicos-tdep.c: Sort headers.
10504         * amd64-darwin-tdep.c: Sort headers.
10505         * amd64-bsd-nat.c: Sort headers.
10506         * alpha-tdep.c: Sort headers.
10507         * alpha-obsd-tdep.c: Sort headers.
10508         * alpha-nbsd-tdep.c: Sort headers.
10509         * alpha-mdebug-tdep.c: Sort headers.
10510         * alpha-linux-tdep.c: Sort headers.
10511         * alpha-linux-nat.c: Sort headers.
10512         * alpha-bsd-tdep.c: Sort headers.
10513         * alpha-bsd-nat.c: Sort headers.
10514         * aix-thread.c: Sort headers.
10515         * agent.c: Sort headers.
10516         * addrmap.c: Sort headers.
10517         * ada-varobj.c: Sort headers.
10518         * ada-valprint.c: Sort headers.
10519         * ada-typeprint.c: Sort headers.
10520         * ada-tasks.c: Sort headers.
10521         * ada-lang.c: Sort headers.
10522         * aarch64-tdep.c: Sort headers.
10523         * aarch64-ravenscar-thread.c: Sort headers.
10524         * aarch64-newlib-tdep.c: Sort headers.
10525         * aarch64-linux-tdep.c: Sort headers.
10526         * aarch64-linux-nat.c: Sort headers.
10527         * aarch64-fbsd-tdep.c: Sort headers.
10528         * aarch64-fbsd-nat.c: Sort headers.
10529         * aarch32-linux-nat.c: Sort headers.
10530
10531 2019-04-04  Tom Tromey  <tom@tromey.com>
10532
10533         * varobj.c (varobj_create): Update.
10534         * rust-exp.y (struct rust_parser) <update_innermost_block,
10535         lookup_symbol>: New methods.
10536         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
10537         Rename.
10538         (rust_parser::rust_lookup_type)
10539         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
10540         * printcmd.c (display_command, do_one_display): Update.
10541         * parser-defs.h (struct parser_state) <parser_state>: Add
10542         "tracker" parameter.
10543         (block_tracker): New member.
10544         (class innermost_block_tracker) <innermost_block_tracker>: Add
10545         "types" parameter.
10546         <reset>: Remove method.
10547         (innermost_block): Don't declare.
10548         (null_post_parser): Update.
10549         * parse.c (innermost_block): Remove global.
10550         (write_dollar_variable): Update.
10551         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
10552         Remove "tracker_types" parameter.
10553         (parse_expression): Add "tracker" parameter.
10554         (parse_expression_for_completion): Update.
10555         (null_post_parser): Add "tracker" parameter.
10556         * p-exp.y: Update rules.
10557         * m2-exp.y: Update rules.
10558         * language.h (struct language_defn) <la_post_parser>: Add
10559         "tracker" parameter.
10560         * go-exp.y: Update rules.
10561         * f-exp.y: Update rules.
10562         * expression.h (parse_expression, parse_exp_1): Add "tracker"
10563         parameter.
10564         * d-exp.y: Update rules.
10565         * c-exp.y: Update rules.
10566         * breakpoint.c (set_breakpoint_condition): Create an
10567         innermost_block_tracker.
10568         (watch_command_1): Likewise.
10569         * ada-lang.c (resolve): Add "tracker" parameter.
10570         (resolve_subexp): Likewise.
10571         * ada-exp.y (write_var_from_sym): Update.
10572
10573 2019-04-04  Tom Tromey  <tom@tromey.com>
10574
10575         * type-stack.h: New file.
10576         * type-stack.c: New file.
10577         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
10578         type-stack.h.
10579         (insert_into_type_stack, insert_type, push_type, push_type_int)
10580         (insert_type_address_space, pop_type, pop_type_int)
10581         (pop_typelist, pop_type_stack, append_type_stack)
10582         (push_type_stack, get_type_stack, push_typelist)
10583         (follow_type_instance_flags, follow_types): Don't declare.
10584         * parse.c (type_stack): Remove global.
10585         (parse_exp_in_context): Update.
10586         (insert_into_type_stack, insert_type, push_type, push_type_int)
10587         (insert_type_address_space, pop_type, pop_type_int)
10588         (pop_typelist, pop_type_stack, append_type_stack)
10589         (push_type_stack, get_type_stack, push_typelist)
10590         (follow_type_instance_flags, follow_types): Remove (moved to
10591         type-stack.c).
10592         * f-exp.y (type_stack): New global.
10593         Update rules.
10594         (push_kind_type, f_parse): Update.
10595         * d-exp.y (type_stack): New global.
10596         Update rules.
10597         (d_parse): Update.
10598         * c-exp.y (struct c_parse_state) <type_stack>: New member.
10599         Update rules.
10600         * Makefile.in (COMMON_SFILES): Add type-stack.c.
10601         (HFILES_NO_SRCDIR): Add type-stack.h.
10602
10603 2019-04-04  Tom Tromey  <tom@tromey.com>
10604
10605         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
10606         (rust_parser::convert_ast_to_expression, rust_parse)
10607         (rust_lex_test_completion, rust_lex_tests): Update.
10608         * parser-defs.h (struct expr_completion_state): New.
10609         (struct parser_state) <parser_state>: Add completion parameter.
10610         <mark_struct_expression, mark_completion_tag>: New methods.
10611         <parse_completion, m_completion_state>: New members.
10612         (prefixify_expression, null_post_parser): Update.
10613         (mark_struct_expression, mark_completion_tag): Don't declare.
10614         * parse.c (parse_completion, expout_last_struct)
10615         (expout_tag_completion_type, expout_completion_name): Remove
10616         globals.
10617         (parser_state::mark_struct_expression)
10618         (parser_state::mark_completion_tag): Now methods.
10619         (prefixify_expression): Add last_struct parameter.
10620         (prefixify_subexp): Likewise.
10621         (parse_exp_1): Update.
10622         (parse_exp_in_context): Add cstate parameter.  Update.
10623         (parse_expression_for_completion): Create an
10624         expr_completion_state.
10625         (null_post_parser): Add "completion" parameter.
10626         * p-exp.y: Update rules.
10627         (yylex): Update.
10628         * language.h (struct language_defn) <la_post_parser>: Add
10629         "completing" parameter.
10630         * go-exp.y: Update rules.
10631         (lex_one_token): Update.
10632         * expression.h (parse_completion): Don't declare.
10633         * d-exp.y: Update rules.
10634         (lex_one_token): Update rules.
10635         * c-exp.y: Update rules.
10636         (lex_one_token): Update.
10637         * ada-lang.c (resolve): Add "parse_completion" parameter.
10638         (resolve_subexp): Likewise.
10639         (ada_resolve_function): Likewise.
10640
10641 2019-04-04  Tom Tromey  <tom@tromey.com>
10642
10643         * parser-defs.h (struct parser_state) <start_arglist,
10644         end_arglist>: New methods.
10645         <arglist_len, m_funcall_chain>: New members.
10646         (arglist_len, start_arglist, end_arglist): Don't declare.
10647         * parse.c (arglist_len, funcall_chain): Remove global.
10648         (start_arglist, end_arglist): Remove functions.
10649         (parse_exp_in_context): Update.
10650         * p-exp.y: Update rules.
10651         * m2-exp.y: Update rules.
10652         * go-exp.y: Update rules.
10653         * f-exp.y: Update rules.
10654         * d-exp.y: Update rules.
10655         * c-exp.y: Update rules.
10656
10657 2019-04-04  Tom Tromey  <tom@tromey.com>
10658
10659         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
10660         lex_operator, push_back>: New methods.
10661         Update all rules.
10662         (rust_parser::lex_hex, lex_escape): Rename and update.
10663         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
10664         (rust_parser::lex_operator): Rename and update.
10665         (rust_parser::lex_number, rustyylex, rustyyerror)
10666         (rust_lex_test_init, rust_lex_test_sequence)
10667         (rust_lex_test_push_back, rust_lex_tests): Update.
10668         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
10669         parameter.
10670         <lexptr, prev_lexptr>: New members.
10671         (lexptr, prev_lexptr): Don't declare.
10672         * parse.c (lexptr, prev_lexptr): Remove globals.
10673         (parse_exp_in_context): Update.
10674         * p-exp.y (yylex, yyerror): Update.
10675         * m2-exp.y (parse_number, yylex, yyerror): Update.
10676         * go-exp.y (lex_one_token, yyerror): Update.
10677         * f-exp.y (match_string_literal, yylex, yyerror): Update.
10678         * d-exp.y (lex_one_token, yyerror): Update.
10679         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
10680         (lex_one_token, yyerror): Update.
10681         * ada-lex.l (YY_INPUT): Update.
10682         (rewind_to_char): Update.
10683         * ada-exp.y (yyerror): Update.
10684
10685 2019-04-04  Tom Tromey  <tom@tromey.com>
10686
10687         * rust-exp.y (rustyylex, rust_lex_tests): Update.
10688         * parser-defs.h (struct parser_state) <parser_state>: Add new
10689         parameter.
10690         <comma_terminates>: New member.
10691         (comma_terminates): Don't declare global.
10692         * parse.c (comma_terminates): Remove global.
10693         (parse_exp_in_context): Update.
10694         * p-exp.y (yylex): Update.
10695         * m2-exp.y (yylex): Update.
10696         * go-exp.y (lex_one_token): Update.
10697         * f-exp.y (yylex): Update.
10698         * d-exp.y (lex_one_token): Update.
10699         * c-exp.y (lex_one_token): Update.
10700         * ada-lex.l: Update.
10701
10702 2019-04-04  Tom Tromey  <tom@tromey.com>
10703
10704         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
10705         (rustyylex, rust_lex_test_init, rust_lex_test_one)
10706         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
10707         * parser-defs.h (paren_depth): Don't declare.
10708         * parse.c (paren_depth): Remove global.
10709         (parse_exp_in_context): Update.
10710         * p-exp.y (paren_depth): New global.
10711         (pascal_parse): Initialize it.
10712         * m2-exp.y (paren_depth): New global.
10713         (m2_parse): Initialize it.
10714         * go-exp.y (paren_depth): New global.
10715         (go_parse): Initialize it.
10716         * f-exp.y (paren_depth): New global.
10717         (f_parse): Initialize it.
10718         * d-exp.y (paren_depth): New global.
10719         (d_parse): Initialize it.
10720         * c-exp.y (paren_depth): New global.
10721         (c_parse): Initialize it.
10722         * ada-lex.l (paren_depth): New global.
10723         (lexer_init): Initialize it.
10724
10725 2019-04-04  Tom Tromey  <tom@tromey.com>
10726
10727         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
10728         (rust_parser::convert_ast_to_type)
10729         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
10730         * parser-defs.h (struct parser_state) <parser_state>: Add
10731         parameters.  Initialize new members.
10732         <expression_context_block, expression_context_pc>: New members.
10733         * parse.c (expression_context_block, expression_context_pc):
10734         Remove globals.
10735         (parse_exp_in_context): Update.
10736         * p-exp.y: Update all rules.
10737         (yylex): Update.
10738         * m2-exp.y: Update all rules.
10739         (yylex): Update.
10740         * go-exp.y (yylex): Update.
10741         * f-exp.y (yylex): Update.
10742         * d-exp.y: Update all rules.
10743         (yylex): Update.
10744         * c-exp.y: Update all rules.
10745         (lex_one_token, classify_name, yylex, c_parse): Update.
10746         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
10747
10748 2019-04-04  Tom Tromey  <tom@tromey.com>
10749
10750         * gdbarch.h, gdbarch.c: Rebuild.
10751         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
10752         * stap-probe.h:
10753         (struct stap_parse_info): Replace "parser_state" with
10754         "expr_builder".
10755         * parser-defs.h (struct expr_builder): Rename from "parser_state".
10756         (parser_state): New class.
10757         * parse.c (expr_builder): Rename.
10758         (expr_builder::release): Rename.
10759         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
10760         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
10761         (write_exp_elt_longcst, write_exp_elt_floatcst)
10762         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
10763         (write_exp_string_vector, write_exp_bitstring)
10764         (write_exp_msymbol, mark_struct_expression)
10765         (write_dollar_variable)
10766         (insert_type_address_space, increase_expout_size): Replace
10767         "parser_state" with "expr_builder".
10768         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
10769         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
10770         "parser_state" with "expr_builder".
10771
10772 2019-04-04  Tom Tromey  <tom@tromey.com>
10773
10774         * rust-exp.y: Replace "parse_language" with method call.
10775         * p-exp.y:
10776         (yylex): Replace "parse_language" with method call.
10777         * m2-exp.y:
10778         (yylex): Replace "parse_language" with method call.
10779         * go-exp.y (classify_name): Replace "parse_language" with method
10780         call.
10781         * f-exp.y (yylex): Replace "parse_language" with method call.
10782         * d-exp.y (lex_one_token): Replace "parse_language" with method
10783         call.
10784         * c-exp.y:
10785         (lex_one_token, classify_name, yylex): Replace "parse_language"
10786         with method call.
10787         * ada-exp.y (find_primitive_type, type_char)
10788         (type_system_address): Replace "parse_language" with method call.
10789
10790 2019-04-04  Tom Tromey  <tom@tromey.com>
10791
10792         * rust-exp.y: Replace "parse_gdbarch" with method call.
10793         * parse.c (write_dollar_variable, insert_type_address_space):
10794         Replace "parse_gdbarch" with method call.
10795         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
10796         call.
10797         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
10798         call.
10799         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
10800         "parse_gdbarch" with method call.
10801         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
10802         with method call.
10803         * f-exp.y (parse_type, parse_f_type, yylex): Replace
10804         "parse_gdbarch" with method call.
10805         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
10806         "parse_gdbarch" with method call.
10807         * c-exp.y (parse_type, parse_number, classify_name): Replace
10808         "parse_gdbarch" with method call.
10809         * ada-lex.l: Replace "parse_gdbarch" with method call.
10810         * ada-exp.y (parse_type, find_primitive_type, type_char)
10811         (type_system_address): Replace "parse_gdbarch" with method call.
10812
10813 2019-04-04  Tom Tromey  <tom@tromey.com>
10814
10815         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
10816         * stap-probe.c (stap_parse_argument): Update.
10817         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
10818         initial_size parameter.
10819         * rust-exp.y (rust_lex_tests): Update.
10820         * parse.c (parser_state): Update.
10821         (parse_exp_in_context): Update.
10822         * parser-defs.h (struct parser_state) <parser_state>: Remove
10823         "initial_size" parameter.
10824
10825 2019-04-04  Tom Tromey  <tom@tromey.com>
10826
10827         * parser-defs.h (increase_expout_size): Don't declare.
10828         * parse.c (increase_expout_size): Now static.
10829
10830 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
10831
10832         * gnu-nat.c (gnu_nat_target::wait): Fix
10833         target_waitstatus_to_string call.
10834
10835 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
10836
10837         * eval.c (evaluate_subexp_standard): Handle internal functions
10838         during Fortran function call handling.
10839
10840 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
10841
10842         * NEWS: Mention new internal functions.
10843         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
10844         (read_base_type): Use dwarf2_init_complex_target_type.
10845         * value.c (creal_internal_fn): New function.
10846         (cimag_internal_fn): New function.
10847         (_initialize_values): Register new internal functions.
10848
10849 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10850
10851         * infrun.c (stop_all_threads): If debug_infrun, always
10852         trace the wait status after wait_one, using
10853         target_waitstatus_to_string and target_pid_to_str.
10854         (handle_inferior_event): Replace various trace of
10855         wait status kind by a single trace.
10856         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
10857         wait status kind image by target_waitstatus_to_string.
10858         * target/waitstatus.c (target_waitstatus_to_string): Fix
10859         obsolete comment.
10860
10861 2019-04-01  Tom Tromey  <tromey@adacore.com>
10862
10863         PR symtab/23331:
10864         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
10865
10866 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
10867             Pedro Alves  <palves@redhat.com>
10868
10869         * top.c (quit_force): Call 'finalize_values'.
10870         * value.c (finalize_values): New function.
10871         * value.h (finalize_values): Declare.
10872
10873 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
10874
10875         * NEWS: Announce $_gdb_major and $_gdb_minor.
10876
10877         * top.c (init_gdb_version_vars): New function.
10878         (gdb_init): Call init_gdb_version_vars.
10879
10880 2019-03-29  Tom Tromey  <tromey@adacore.com>
10881
10882         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
10883         help text.  Remove dead code.
10884
10885 2019-03-29  Keith Seitz  <keiths@redhat.com>
10886
10887         From Siddhesh Poyarekar:
10888         * f-lang.h (f77_get_upperbound): Return LONGEST.
10889         (f77_get_lowerbound): Likewise.
10890         * f-typeprint.c (f_type_print_varspec_suffix): Expand
10891         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
10892         print them.
10893         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
10894         plongest to format print it.
10895         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
10896         (f77_get_upperbound): Likewise.
10897         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
10898         LOWER_BOUND to LONGEST.
10899         (f77_create_arrayprint_offset_tbl): Likewise.
10900
10901 2019-03-29  Keith Seitz  <keiths@redhat.com>
10902
10903         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
10904         %s/pulongest for TYPE_LENGTH instead of %d in format
10905         strings.
10906         * ada-typerint.c (ada_print_type): Likewise.
10907         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
10908         * compile/compile-c-support.c (generate_register_struct): Likewise.
10909         * gdbtypes.c (recursive_dump_type): Likewise.
10910         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
10911         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
10912         instead of %d in format strings.
10913         * riscv-tdep.c (riscv_type_alignment): Cast second argument
10914         to std::min to ULONGEST.
10915         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
10916         instead of %d in format strings.
10917         * tracepoint.c (info_scope_command): Likewise.
10918         * typeprint.c (print_offset_data::update)
10919         (print_offset_data::finish): Likewise.
10920         * xtensa-tdep.c (xtensa_store_return_value)
10921         (xtensa_push_dummy_call): Likewise.
10922
10923 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
10924
10925         * windows-nat.c (display_selector): Fixed format specifications
10926         for 64-bit Cygwin.
10927
10928 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10929
10930         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
10931
10932 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
10933
10934         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
10935         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
10936         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
10937         (nios2_linux_init_abi): Install it.
10938
10939 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
10940
10941         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
10942
10943 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
10944
10945         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
10946
10947 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10948             Tom Tromey  <tromey@adacore.com>
10949
10950         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
10951
10952 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
10953
10954         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
10955         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
10956         method to compute the bounds of range types. Also print "[evaluated]"
10957         if the bounds' values come from a dynamic evaluation.
10958
10959 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
10960
10961         * cp-valprint.c (cp_print_value_fields): Don't print trailing
10962         whitespace when pretty printing is on.
10963
10964 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
10965
10966         * ppc-linux-nat.c: Add include.
10967
10968 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
10969
10970         * NEWS: Mention AArch64 Pointer Authentication.
10971
10972 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
10973
10974         * arm-linux-nat.c: Add include.
10975
10976 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
10977
10978         * source-cache.c (source_cache::get_source_lines): Re-read
10979         fullname after calling open_source_file.
10980
10981 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
10982
10983         * NEWS: Mention TLS support for FreeBSD.
10984
10985 2019-03-25  Tom Tromey  <tromey@adacore.com>
10986
10987         * minsyms.c (BUNCH_SIZE): Update comment.
10988         (~minimal_symbol_reader): Remove old comment.
10989         (compact_minimal_symbols): Update comment.
10990         (minimal_symbol_reader::install): Remove old comment.  Update
10991         other comments.
10992
10993 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
10994
10995         * s390-linux-nat.c: Add include.
10996
10997 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
10998
10999         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
11000         Call linux_get_hwcap.
11001         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
11002         Likewise.
11003         (aarch64_linux_get_hwcap): Remove function.
11004         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
11005         declaration.
11006         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
11007         linux_get_hwcap.
11008         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
11009         * linux-tdep.c (linux_get_hwcap): Add function.
11010         (linux_get_hwcap2): Likewise.
11011         * linux-tdep.h (linux_get_hwcap): Add declaration.
11012         (linux_get_hwcap2): Likewise.
11013         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
11014         (ppc_linux_get_hwcap2): Likewise.
11015         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
11016         linux_get_hwcap.
11017         (ppc_linux_nat_target::insert_watchpoint): Likewise.
11018         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
11019         (ppc_linux_nat_target::read_description): Likewise.
11020         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
11021         * s390-linux-nat.c: Likewise.
11022         * s390-linux-tdep.c (s390_core_read_description): Likewise.
11023
11024 2019-03-24  Tom Tromey  <tom@tromey.com>
11025
11026         * ada-lang.c (standard_lookup): Simplify initialization.
11027         (ada_lookup_symbol_nonlocal): Simplify return.
11028         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
11029         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
11030         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
11031         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
11032         initialization.
11033         * solib.c (solib_global_lookup): Simplify.
11034         * symtab.c (null_block_symbol): Remove.
11035         (symbol_cache_lookup): Simplify returns.
11036         (lookup_language_this): Simplify returns.
11037         (lookup_symbol_aux): Simplify return.
11038         (lookup_local_symbol): Simplify returns.
11039         (lookup_global_symbol_from_objfile): Simplify return.
11040         (lookup_symbol_in_objfile_symtabs)
11041         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
11042         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
11043         (lookup_static_symbol, lookup_global_symbol): Simplify return.
11044         * cp-namespace.c (cp_lookup_bare_symbol)
11045         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
11046         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
11047         (cp_lookup_nested_symbol): Don't use null_block_symbol.
11048         (cp_lookup_symbol_via_imports): Simplify initialization.
11049         (find_symbol_in_baseclass): Likewise.
11050         * symtab.h (null_block_symbol): Remove.
11051         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
11052         (d_lookup_nested_symbol, d_lookup_symbol_imports)
11053         (d_lookup_symbol_module): Likewise.
11054         (find_symbol_in_baseclass): Simplify initialization.
11055
11056 2019-03-24  Tom Tromey  <tom@tromey.com>
11057
11058         * expression.h: Don't include symtab.h.
11059         (struct block): Forward declare.
11060
11061 2019-03-24  Tom Tromey  <tom@tromey.com>
11062
11063         * c-exp.y (typebase): Remove casts.
11064         * gdbtypes.c (lookup_unsigned_typename, )
11065         (lookup_signed_typename): Remove cast.
11066         * eval.c (parse_to_comma_and_eval): Remove cast.
11067         * parse.c (write_dollar_variable): Remove cast.
11068         * block.h (struct block) <superblock>: Now const.
11069         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
11070         * psymtab.c (psym_map_matching_symbols): Make "block" const.
11071         (map_block): Make "block" const.
11072         * symfile.h (struct quick_symbol_functions)
11073         <map_matching_symbols>: Constify block argument to "callback".
11074         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
11075         const.
11076         (find_pc_sect_compunit_symtab): Make "b" const.
11077         (find_symbol_at_address): Likewise.
11078         (search_symbols): Likewise.
11079         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
11080         (dw2_debug_names_lookup_symbol): Likewise.
11081         (dw2_map_matching_symbols): Update.
11082         * p-valprint.c (pascal_val_print): Remove "block".
11083         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
11084         (aux_add_nonlocal_symbols): Make "block" const.
11085         (resolve_subexp): Remove cast.
11086         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
11087         const.
11088         (iterate_over_file_blocks): Likewise.
11089         * f-exp.y (%union) <bval>: Remove.
11090         * coffread.c (patch_opaque_types): Make "b" const.
11091         * spu-tdep.c (spu_catch_start): Make "block" const.
11092         * c-valprint.c (print_unpacked_pointer): Remove "block".
11093         * symmisc.c (dump_symtab_1): Make "b" const.
11094         (block_depth): Make "block" const.
11095         * d-exp.y (%union) <bval>: Remove.
11096         * cp-support.h (cp_lookup_rtti_type): Update.
11097         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
11098         * psymtab.c (psym_lookup_symbol): Make "block" const.
11099         (maintenance_check_psymtabs): Make "b" const.
11100         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
11101         (enumerate_locals, enumerate_args): Update.
11102         * python/py-symtab.c (stpy_global_block): Make "block" const.
11103         (stpy_static_block): Likewise.
11104         * inline-frame.c (block_starting_point_at): Make "new_block"
11105         const.
11106         * block.c (find_block_in_blockvector): Make return type const.
11107         (blockvector_for_pc_sect): Make "b" const.
11108         (find_block_in_blockvector): Make "b" const.
11109
11110 2019-03-23  Tom Tromey  <tom@tromey.com>
11111
11112         * varobj.c (varobj_create): Update.
11113         * symfile.c (clear_symtab_users): Don't reset innermost_block.
11114         * printcmd.c (display_command, do_one_display): Don't reset
11115         innermost_block.
11116         * parser-defs.h (enum innermost_block_tracker_type): Move to
11117         expression.h.
11118         (innermost_block): Update comment.
11119         * parse.c (parse_exp_1): Add tracker_types parameter.
11120         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
11121         tracker_types parameter.  Reset innermost_block.
11122         (parse_exp_in_context): Remove.
11123         (parse_expression_for_completion): Update.
11124         * objfiles.c (~objfile): Don't reset expression_context_block or
11125         innermost_block.
11126         * expression.h (enum innermost_block_tracker_type): Move from
11127         parser-defs.h.
11128         (parse_exp_1): Add tracker_types parameter.
11129         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
11130         reset innermost_block.
11131
11132 2019-03-23  Tom Tromey  <tom@tromey.com>
11133
11134         * objfiles.h: Include bcache.h.
11135
11136 2019-03-23  Tom Tromey  <tom@tromey.com>
11137
11138         * linespec.c (get_current_search_block): Use
11139         scoped_restore_current_language.
11140         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
11141
11142 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
11143             Jiong Wang  <jiong.wang@arm.com>
11144
11145         * aarch64-linux-tdep.c
11146         (aarch64_linux_iterate_over_regset_sections): Check for pauth
11147         section.
11148         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
11149
11150 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
11151             Jiong Wang  <jiong.wang@arm.com>
11152
11153         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
11154         instructions.
11155         (aarch64_analyze_prologue_test): Add PACIASP test.
11156         (aarch64_prologue_prev_register): Unmask PC value.
11157
11158 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
11159             Jiong Wang  <jiong.wang@arm.com>
11160
11161         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
11162         (aarch64_dwarf2_prev_register): Unmask PC value.
11163         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
11164         (aarch64_execute_dwarf_cfa_vendor_op): Check for
11165         DW_CFA_AARCH64_negate_ra_state.
11166         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
11167
11168 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
11169             Jiong Wang  <jiong.wang@arm.com>
11170
11171         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
11172         registers.
11173         (aarch64_pseudo_register_name): Likewise.
11174         (aarch64_pseudo_register_type): Likewise.
11175         (aarch64_pseudo_register_reggroup_p): Likewise.
11176         (aarch64_gdbarch_init): Add pauth registers.
11177         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
11178         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
11179         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
11180         (struct gdbarch_tdep): Add regnum for ra_state.
11181
11182 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
11183             Jiong Wang  <jiong.wang@arm.com>
11184
11185         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
11186
11187 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
11188             Jiong Wang  <jiong.wang@arm.com>
11189
11190         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
11191         function.
11192         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
11193         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
11194         (aarch64_gdbarch_init): Add puth registers.
11195         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
11196         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
11197         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
11198
11199 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
11200             Jiong Wang  <jiong.wang@arm.com>
11201
11202         * aarch64-linux-nat.c
11203         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
11204         * aarch64-linux-tdep.c
11205         (aarch64_linux_core_read_description): Likewise.
11206         (aarch64_linux_get_hwcap): New function.
11207         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
11208         (aarch64_linux_get_hwcap): New declaration.
11209
11210 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
11211             Jiong Wang  <jiong.wang@arm.com>
11212
11213         * aarch64-linux-nat.c
11214         (aarch64_linux_nat_target::read_description): Add pauth param.
11215         * aarch64-linux-tdep.c
11216         (aarch64_linux_core_read_description): Likewise.
11217         * aarch64-tdep.c (struct target_desc): Add in pauth.
11218         (aarch64_read_description): Add pauth param.
11219         (aarch64_gdbarch_init): Likewise.
11220         * aarch64-tdep.h (aarch64_read_description): Likewise.
11221         * arch/aarch64.c (aarch64_create_target_description): Likewise.
11222         * arch/aarch64.h (aarch64_create_target_description): Likewise.
11223         * features/Makefile: Add new files.
11224         * features/aarch64-pauth.c: New file.
11225         * features/aarch64-pauth.xml: New file.
11226
11227 2019-03-20  Tom Tromey  <tromey@adacore.com>
11228
11229         * infrun.c (handle_inferior_event): Rename from
11230         handle_inferior_event_1.  Create a scoped_value_mark.
11231         (handle_inferior_event): Remove.
11232
11233 2019-03-19  Tom Tromey  <tromey@adacore.com>
11234
11235         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
11236         * infrun.h (print_stop_event): Add "displays" parameter.
11237         * infrun.c (print_stop_event): Add "displays" parameter.
11238
11239 2019-03-19  Pedro Alves  <palves@redhat.com>
11240
11241         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
11242         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
11243         to -1.  Fix TABs vs spaces.
11244         (tui_ui_out::tui_ui_out): Don't initialize fields here.
11245         * tui/tui-out.h (tui_ui_out) Add intro comments.
11246         <m_line, m_start_of_line>: In-class initialize, and add describing
11247         comment.
11248
11249 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
11250
11251         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
11252         variable names.
11253         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
11254
11255 2019-03-18  Pedro Alves  <palves@redhat.com>
11256             Eli Zaretskii <eliz@gnu.org>
11257
11258         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
11259         m_line and m_start_of_line.
11260
11261 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
11262
11263         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
11264         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
11265         it returns a newline.  This fixes a regression in TU mode, whereby
11266         the next line is output on the same screen line as the user input.
11267
11268 2019-03-18  Tom Tromey  <tromey@adacore.com>
11269
11270         * minsyms.c (minimal_symbol_reader::install): Remove call to
11271         obstack_blank.
11272
11273 2019-03-18  Pedro Alves  <palves@redhat.com>
11274
11275         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
11276         New globals.
11277         (apply_style): New, factored out from ...
11278         (apply_ansi_escape): ... this.  Handle reverse video mode.
11279         (tui_set_reverse_mode): New function.
11280         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
11281         * tui/tui-winsource.c (tui_show_source_line): Use
11282         tui_set_reverse_mode instead of setting A_STANDOUT.
11283         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
11284         New setter methods.
11285
11286 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
11287
11288         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
11289         Handle tabs.
11290
11291 2019-03-18  Tom Tromey  <tromey@adacore.com>
11292
11293         * ada-lang.c (empty_array): Add "high" parameter.
11294         (ada_evaluate_subexp): Update.
11295
11296 2019-03-17  Sergei Trofimovich <siarheit@google.com>
11297
11298         * unittests/string_view-selftests.c: Define
11299         _initialize_string_view_selftests unconditionally.
11300
11301 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
11302
11303         PR gdb/24350
11304         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
11305
11306 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
11307
11308         PR gdb/24351
11309         * windows-nat.c (display_selector): Fix format specifiers.
11310
11311 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
11312
11313         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
11314         tui_refill_source_window instead of tui_refresh_win, to update the
11315         current execution line.  This fixes redisplay of the current line
11316         when stepping through the code with "next" or "step".
11317
11318 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
11319
11320         * source-cache.c (source_cache::get_source_lines): Call
11321         find_source_lines to initialize s->nlines.  This fixes vertical
11322         scrolling of TUI source window when the DOWN arrow is pressed.
11323
11324 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11325
11326         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
11327         linux-thread-db.c (_initialize_thread_db): Likewise.
11328
11329 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
11330
11331         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
11332         wclrtoeol in tui_show_source_line".  This reverts changes made in
11333         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
11334
11335 2019-03-15  Tom Tromey  <tom@tromey.com>
11336
11337         * symtab.h (struct minimal_symbol): Derive from
11338         general_symbol_info.
11339         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
11340         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
11341         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
11342         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
11343         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
11344         (MSYMBOL_SEARCH_NAME): Update.
11345         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
11346         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
11347         * minsyms.c (minimal_symbol_reader::record_full): Update.
11348
11349 2019-03-15  Tom Tromey  <tom@tromey.com>
11350
11351         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
11352
11353 2019-03-15  Tom Tromey  <tom@tromey.com>
11354
11355         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
11356         unique_xmalloc_ptr.
11357         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
11358         Update.
11359         * minsyms.c (lookup_minimal_symbol_by_pc_section)
11360         (build_minimal_symbol_hash_tables)
11361         (minimal_symbol_reader::install): Update.
11362
11363 2019-03-15  Tom Tromey  <tom@tromey.com>
11364
11365         * symtab.c (create_demangled_names_hash): Update.
11366         (symbol_set_names): Update.
11367         * objfiles.h (struct objfile_per_bfd_storage)
11368         <demangled_names_hash>: Now an htab_up.
11369         * objfiles.c (objfile_per_bfd_storage): Simplify.
11370
11371 2019-03-15  Tom Tromey  <tom@tromey.com>
11372
11373         * objfiles.h (struct objfile_per_bfd_storage): Declare
11374         destructor.
11375         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
11376         New.
11377         (get_objfile_bfd_data): Use new.  Don't initialize
11378         language_of_main.
11379         (free_objfile_per_bfd_storage): Remove.
11380         (objfile_bfd_data_free, objfile::~objfile): Use delete.
11381
11382 2019-03-15  Tom Tromey  <tom@tromey.com>
11383
11384         * symfile.c (reread_symbols): Update.
11385         * objfiles.c (objfile::objfile): Update.
11386         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
11387         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
11388         comment.
11389         (minimal_symbol_reader::install): Update.
11390         (terminate_minimal_symbol_table): Remove.
11391         * jit.c (jit_object_close_impl): Update.
11392
11393 2019-03-15  Tom Tromey  <tom@tromey.com>
11394
11395         * minsyms.c (minimal_symbol_reader::record_full): Remove some
11396         initializations.
11397
11398 2019-03-15  Tom Tromey  <tom@tromey.com>
11399
11400         * objfiles.h (struct objfile_per_bfd_storage)
11401         <demangled_hash_languages>: Now a bitset.
11402         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
11403         (lookup_minimal_symbol): Update.
11404
11405 2019-03-15  Tom Tromey  <tom@tromey.com>
11406
11407         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
11408         Don't return the symbol.
11409         * coffread.c (record_minimal_symbol): Use record_full.
11410
11411 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
11412
11413         The MS-Windows port of ncurses fails to switch to a color pair if
11414         one or both of the colors are the implicit default colors.  This
11415         change records the default colors when TUI is initialized, and
11416         then specifies them explicitly when a color pair uses the default
11417         colors.  This allows color styling in TUI mode on MS-Windows.
11418
11419         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
11420         ncurses_norm_attr.
11421         (tui_initialize_io) [__MINGW32__]: Record the default terminal
11422         colors in ncurses_norm_attr.
11423         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
11424         "none", replace it with the default color recorded in
11425         ncurses_norm_attr.
11426
11427 2019-03-14  Tom Tromey  <tromey@adacore.com>
11428
11429         * source-cache.h (class source_cache) <get_source_lines>: Return
11430         std::string.
11431         * source-cache.c (source_cache::extract_lines): Handle case where
11432         first_pos==npos.  Return std::string.
11433         (source_cache::get_source_lines): Update.
11434
11435 2019-03-14  Tom Tromey  <tromey@adacore.com>
11436
11437         * NEWS: Add item for "style sources" commands.
11438         * source-cache.c (source_cache::get_source_lines): Check
11439         source_styling.
11440         * cli/cli-style.c (source_styling): New global.
11441         (_initialize_cli_style): Add "style sources" commands.
11442         (show_style_sources): New function.
11443         * cli/cli-style.h (source_styling): Declare.
11444
11445 2019-03-14  Pedro Alves  <palves@redhat.com>
11446             Tom Tromey  <tromey@adacore.com>
11447
11448         * tui/tui-winsource.h (tui_refill_source_window): Declare.
11449         * tui/tui-winsource.c (tui_refill_source_window): New function,
11450         from...
11451         (tui_horizontal_source_scroll): ... here.  Move some logic.
11452         * cli/cli-style.c (set_style_enabled): Notify new observable.
11453         * tui/tui-hooks.c (tui_redisplay_source): New function.
11454         (tui_attach_detach_observers): Attach or detach
11455         tui_redisplay_source.
11456         * observable.h (source_styling_changed): New observable.
11457         * observable.c: Define source_styling_changed observable.
11458
11459 2019-03-13  Tom Tromey  <tromey@adacore.com>
11460
11461         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
11462         (i386_gnu_nat_target::store_registers): Update.
11463         * target-debug.h (target_debug_print_std_string): New macro.
11464         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
11465         * windows-tdep.c (display_one_tib): Update.
11466         * tui/tui-stack.c (tui_make_status_line): Update.
11467         * top.c (print_inferior_quit_action): Update.
11468         * thread.c (thr_try_catch_cmd): Update.
11469         (add_thread_with_info): Update.
11470         (thread_target_id_str): Update.
11471         (thr_try_catch_cmd): Update.
11472         (thread_command): Update.
11473         (thread_find_command): Update.
11474         * record-btrace.c (record_btrace_target::info_record)
11475         (record_btrace_resume_thread, record_btrace_target::resume)
11476         (record_btrace_cancel_resume, record_btrace_step_thread)
11477         (record_btrace_target::wait, record_btrace_target::wait)
11478         (record_btrace_target::wait, record_btrace_target::stop): Update.
11479         * progspace.c (print_program_space): Update.
11480         * process-stratum-target.c
11481         (process_stratum_target::thread_address_space): Update.
11482         * linux-fork.c (linux_fork_mourn_inferior)
11483         (detach_checkpoint_command, info_checkpoints_command)
11484         (linux_fork_context): Update.
11485         (linux_fork_detach): Update.
11486         (class scoped_switch_fork_info): Update.
11487         (delete_checkpoint_command): Update.
11488         * infrun.c (follow_fork_inferior): Update.
11489         (follow_fork_inferior): Update.
11490         (proceed_after_vfork_done): Update.
11491         (handle_vfork_child_exec_or_exit): Update.
11492         (follow_exec): Update.
11493         (displaced_step_prepare_throw): Update.
11494         (displaced_step_restore): Update.
11495         (start_step_over): Update.
11496         (resume_1): Update.
11497         (clear_proceed_status_thread): Update.
11498         (proceed): Update.
11499         (print_target_wait_results): Update.
11500         (do_target_wait): Update.
11501         (context_switch): Update.
11502         (stop_all_threads): Update.
11503         (restart_threads): Update.
11504         (finish_step_over): Update.
11505         (handle_signal_stop): Update.
11506         (switch_back_to_stepped_thread): Update.
11507         (keep_going_pass_signal): Update.
11508         (print_exited_reason): Update.
11509         (normal_stop): Update.
11510         * inferior.c (inferior_pid_to_str): Change return type.
11511         (print_selected_inferior): Update.
11512         (add_inferior): Update.
11513         (detach_inferior): Update.
11514         * dummy-frame.c (fprint_dummy_frames): Update.
11515         * dcache.c (dcache_info_1): Update.
11516         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
11517         (btrace_fetch, btrace_clear): Update.
11518         * linux-tdep.c (linux_core_pid_to_str): Change return type.
11519         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
11520         type.
11521         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
11522         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
11523         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
11524         * gdbarch.c, gdbarch.h: Rebuild.
11525         * gdbarch.sh (core_pid_to_str): Change return type.
11526         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
11527         return type.
11528         (windows_nat_target::pid_to_str): Change return type.
11529         (windows_delete_thread): Update.
11530         (windows_nat_target::attach): Update.
11531         (windows_nat_target::files_info): Update.
11532         * target-delegates.c: Rebuild.
11533         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
11534         return type.
11535         (sol_thread_target::pid_to_str): Change return type.
11536         * remote.c (class remote_target) <pid_to_str>: Change return
11537         type.
11538         (remote_target::pid_to_str): Change return type.
11539         (extended_remote_target::attach, remote_target::remote_stop_ns)
11540         (remote_target::remote_notif_remove_queued_reply)
11541         (remote_target::push_stop_reply, remote_target::disable_btrace):
11542         Update.
11543         (extended_remote_target::attach): Update.
11544         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
11545         type.
11546         (gdbsim_target::pid_to_str): Change return type.
11547         * ravenscar-thread.c (struct ravenscar_thread_target)
11548         <pid_to_str>: Change return type.
11549         (ravenscar_thread_target::pid_to_str): Change return type.
11550         * procfs.c (class procfs_target) <pid_to_str>: Change return
11551         type.
11552         (procfs_target::pid_to_str): Change return type.
11553         (procfs_target::attach): Update.
11554         (procfs_target::detach): Update.
11555         (procfs_target::fetch_registers): Update.
11556         (procfs_target::store_registers): Update.
11557         (procfs_target::wait): Update.
11558         (procfs_target::files_info): Update.
11559         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
11560         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
11561         return type.
11562         (nto_procfs_target::pid_to_str): Change return type.
11563         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
11564         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
11565         return type.
11566         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
11567         (exit_lwp): Update.
11568         (attach_proc_task_lwp_callback, get_detach_signal)
11569         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
11570         (linux_nat_target::resume, wait_lwp, stop_callback)
11571         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
11572         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
11573         (linux_nat_wait_1, resume_stopped_resumed_lwps)
11574         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
11575         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
11576         type.
11577         (inf_ptrace_target::attach): Update.
11578         (inf_ptrace_target::files_info): Update.
11579         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
11580         type.
11581         (go32_nat_target::pid_to_str): Change return type.
11582         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
11583         (gnu_nat_target::wait): Update.
11584         (gnu_nat_target::wait): Update.
11585         (gnu_nat_target::resume): Update.
11586         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
11587         (fbsd_nat_target::wait): Update.
11588         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
11589         type.
11590         (darwin_nat_target::attach): Update.
11591         * corelow.c (class core_target) <pid_to_str>: Change return type.
11592         (core_target::pid_to_str): Change return type.
11593         * target.c (normal_pid_to_str): Change return type.
11594         (default_pid_to_str): Likewise.
11595         (target_pid_to_str): Change return type.
11596         (target_translate_tls_address): Update.
11597         (target_announce_detach): Update.
11598         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
11599         return type.
11600         (bsd_uthread_target::pid_to_str): Change return type.
11601         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
11602         type.
11603         (bsd_kvm_target::pid_to_str): Change return type.
11604         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
11605         return type.
11606         (aix_thread_target::pid_to_str): Change return type.
11607         * target.h (struct target_ops) <pid_to_str>: Change return type.
11608         (target_pid_to_str, normal_pid_to_str): Likewise.
11609         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
11610         type.
11611         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
11612         type.
11613         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
11614         return type.
11615         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
11616         type.
11617         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
11618         type.
11619         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
11620         return type.
11621
11622 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
11623
11624         * NEWS: Mention that the new default MI version is 3.  Mention
11625         changes to the output of commands and events that deal with
11626         multi-location breakpoints.
11627         * breakpoint.c: Include "mi/mi-out.h".
11628         (print_one_breakpoint): Change output syntax if using MI version
11629         >= 3.
11630         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
11631         New.
11632         (mi_multi_location_breakpoint_output_fixed): New.
11633         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
11634         (mi_cmd_fix_multi_location_breakpoint_output): New.
11635         (mi_multi_location_breakpoint_output_fixed): New.
11636         * mi/mi-cmds.c (mi_cmds): Register command
11637         -fix-multi-location-breakpoint-output.
11638         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
11639         interpreter "mi".
11640
11641 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
11642
11643         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
11644         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
11645         instantiate mi_ui_out based on interpreter name.
11646         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
11647         * mi/mi-main.c (mi_load_progress): Likewise.
11648
11649 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11650
11651         * NEWS: Combine separate "New targets" sections for 8.3.
11652
11653 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11654
11655         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
11656         (ppcfbsd_init_abi): Install gdbarch
11657         "fetch_tls_load_module_address" and "get_thread_local_address"
11658         methods.
11659
11660 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11661
11662         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
11663         (riscv_fbsd_init_abi): Install gdbarch
11664         "fetch_tls_load_module_address" and "get_thread_local_address"
11665         methods.
11666
11667 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11668
11669         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
11670         (i386fbsd_init_abi): Install gdbarch
11671         "fetch_tls_load_module_address" and "get_thread_local_address"
11672         methods.
11673
11674 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11675
11676         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
11677         (amd64fbsd_init_abi): Install gdbarch
11678         "fetch_tls_load_module_address" and "get_thread_local_address"
11679         methods.
11680
11681 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11682
11683         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
11684         (struct fbsd_pspace_data): New type.
11685         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
11686         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
11687         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
11688         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
11689         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
11690
11691 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11692
11693         * gdbtypes.c (lookup_struct_elt): New function.
11694         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
11695         * gdbtypes.h (struct struct_elt): New type.
11696         (lookup_struct_elt): New prototype.
11697
11698 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11699
11700         * gdbtypes.c (lookup_struct_elt_type): Update comment and
11701         remove disabled code block.
11702
11703 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11704
11705         * gdbarch.sh (get_thread_local_address): New method.
11706         * gdbarch.h, gdbarch.c: Regenerate.
11707         * target.c (target_translate_tls_address): Use
11708         gdbarch_get_thread_local_address if present instead of
11709         target::get_thread_local_address.
11710
11711 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11712
11713         * target.h (target::get_thread_local_address): Update comment.
11714
11715 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11716
11717         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
11718         objfile->separate_debug_objfile_backlink if not NULL.
11719
11720 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11721
11722         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
11723         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
11724         (amd64bsd_store_inferior_registers): Likewise.
11725         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
11726         Enable segment base registers.
11727         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
11728         PT_GETFSBASE and PT_GETGSBASE.
11729         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
11730         PT_SETGSBASE.
11731         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
11732         segment base registers.
11733         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
11734
11735 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11736
11737         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
11738         Update calls to i386_target_description to add 'segments'
11739         parameter.
11740         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
11741         add segment base registers.
11742         * arch/i386.c (i386_create_target_description): Add 'segments'
11743         parameter to enable segment base registers.
11744         * arch/i386.h (i386_create_target_description): Likewise.
11745         * features/i386/32bit-segments.xml: New file.
11746         * features/i386/32bit-segments.c: Generate.
11747         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
11748         call to i386_target_description to add 'segments' parameter.
11749         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
11750         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
11751         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
11752         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
11753         if feature is present.
11754         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
11755         Add 'segments' parameter to call to i386_target_description.
11756         (i386_target_description): Add 'segments' parameter to enable
11757         segment base registers.
11758         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
11759         to call to i386_target_description.
11760         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
11761         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
11762         Define I386_NUM_REGS.
11763         (i386_target_description): Add 'segments' parameter to enable
11764         segment base registers.
11765
11766 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
11767
11768         PR/24325
11769         * source-cache.c: #undef open and close, to avoid unresolved
11770         externals during linking.
11771
11772 2019-03-12  Tom Tromey  <tromey@adacore.com>
11773
11774         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
11775         const.  Add initializers.
11776         (_initialize_remote): Don't initialize ptid globals.
11777
11778 2019-03-12  Pedro Alves  <palves@redhat.com>
11779
11780         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
11781
11782 2019-03-12  Pedro Alves  <palves@redhat.com>
11783
11784         * cp-name-parser.y (main): Remove unused 'len' variable.
11785
11786 2019-03-12  Tom Tromey  <tromey@adacore.com>
11787
11788         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
11789         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
11790
11791 2019-03-12  Tom Tromey  <tromey@adacore.com>
11792
11793         * linux-nat.c (iterate_over_lwps): Update.
11794         (stop_callback): Remove parameter.
11795         (stop_wait_callback, detach_callback, resume_set_callback)
11796         (select_singlestep_lwp_callback, set_ignore_sigint)
11797         (status_callback, resumed_callback, resume_clear_callback)
11798         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
11799         data parameter.
11800         (linux_nat_target::detach, linux_nat_target::resume)
11801         (linux_stop_and_wait_all_lwps, select_event_lwp)
11802         (linux_nat_filter_event, linux_nat_wait_1)
11803         (linux_nat_target::kill, linux_nat_target::stop)
11804         (linux_nat_target::stop): Update.
11805         (linux_nat_resume_callback): Change type.
11806         (resume_stopped_resumed_lwps, count_events_callback)
11807         (select_event_lwp_callback): Likewise.
11808         (linux_stop_lwp, linux_nat_stop_lwp): Update.
11809         * arm-linux-nat.c (struct update_registers_data): Remove.
11810         (update_registers_callback): Change type.
11811         (arm_linux_insert_hw_breakpoint1): Update.
11812         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
11813         parameter.
11814         (x86_linux_dr_set_addr): Update.
11815         (x86_linux_dr_set_control): Update.
11816         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
11817         (iterate_over_lwps): Use gdb::function_view.
11818         * nat/aarch64-linux-hw-point.c (struct
11819         aarch64_dr_update_callback_param): Remove.
11820         (debug_reg_change_callback): Change type.
11821         (aarch64_notify_debug_reg_change): Update.
11822         * s390-linux-nat.c (s390_refresh_per_info): Update.
11823
11824 2019-03-11  Tom Tromey  <tromey@adacore.com>
11825
11826         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
11827         redundant assignment to "this_cu".
11828
11829 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11830
11831         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
11832
11833 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11834
11835         * gdbtypes.c (rank_one_type_parm_set): New function extracted
11836         from...
11837         (rank_one_type): ... this.
11838
11839 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11840
11841         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
11842         from...
11843         (rank_one_type): ... this.
11844
11845 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11846
11847         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
11848         from...
11849         (rank_one_type): ... this.
11850
11851 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11852
11853         * gdbtypes.c (rank_one_type_parm_float): New function extracted
11854         from...
11855         (rank_one_type): ... this.
11856
11857 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11858
11859         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
11860         from...
11861         (rank_one_type): ... this.
11862
11863 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11864
11865         * gdbtypes.c (rank_one_type_parm_range): New function extracted
11866         from...
11867         (rank_one_type): ... this.
11868
11869 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11870
11871         * gdbtypes.c (rank_one_type_parm_char): New function extracted
11872         from...
11873         (rank_one_type): ... this.
11874
11875 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11876
11877         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
11878         from...
11879         (rank_one_type): ... this.
11880
11881 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11882
11883         * gdbtypes.c (rank_one_type_parm_int): New function extracted
11884         from...
11885         (rank_one_type): ... this.
11886
11887 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11888
11889         * gdbtypes.c (rank_one_type_parm_func): New function extracted
11890         from...
11891         (rank_one_type): ... this.
11892
11893 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11894
11895         * gdbtypes.c (rank_one_type_parm_array): New function extracted
11896         from...
11897         (rank_one_type): ... this.
11898
11899 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11900
11901         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
11902         from...
11903         (rank_one_type): ... this.
11904
11905 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11906
11907         * inferior.c (initialize_inferiors): Ensure 'help set/show print
11908         inferior-events' shows the example events.
11909
11910 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
11911
11912         Support styling on native MS-Windows console
11913
11914         PR/24315
11915         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
11916         on MS-Windows if $TERM is not defined.
11917
11918         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
11919
11920         * posix-hdep.c (gdb_console_fputs):
11921         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
11922         functions.
11923         * ui-file.h (gdb_console_fputs): Add prototype.
11924
11925         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
11926         back to fputs only if the former returns zero.
11927
11928 2019-03-07  Tom Tromey  <tom@tromey.com>
11929
11930         * symmisc.c (print_symbol_bcache_statistics): Update.
11931         (print_objfile_statistics): Update.
11932         * symfile.c (allocate_symtab): Update.
11933         * stabsread.c: Don't include bcache.h.
11934         * psymtab.h (struct psymbol_bcache): Don't declare.
11935         (class psymtab_storage) <psymbol_cache>: Now a bcache.
11936         (psymbol_bcache_init, psymbol_bcache_free)
11937         (psymbol_bcache_get_bcache): Don't declare.
11938         * psymtab.c (struct psymbol_bcache): Remove.
11939         (psymtab_storage::psymtab_storage): Update.
11940         (psymtab_storage::~psymtab_storage): Update.
11941         (psymbol_bcache_init, psymbol_bcache_free)
11942         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
11943         (add_psymbol_to_bcache): Update.
11944         (allocate_psymtab): Update.
11945         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
11946         macro_cache>: No longer pointers.
11947         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
11948         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
11949         * macrotab.c (macro_bcache): Update.
11950         * macroexp.c: Don't include bcache.h.
11951         * gdbtypes.c (check_types_worklist): Update.
11952         (types_deeply_equal): Remove TRY/CATCH.  Update.
11953         * elfread.c (elf_symtab_read): Update.
11954         * dwarf2read.c: Don't include bcache.h.
11955         * buildsym.c (buildsym_compunit::get_macro_table): Update.
11956         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
11957         (print_bcache_statistics, bcache_memory_used): Don't declare.
11958         (struct bcache): Move from bcache.c.  Add constructor, destructor,
11959         methods.  Rename all data members.
11960         * bcache.c (struct bcache): Move to bcache.h.
11961         (bcache::expand_hash_table): Rename from expand_hash_table.
11962         (bcache): Remove.
11963         (bcache::insert): Rename from bcache_full.
11964         (bcache::compare): Rename from bcache_compare.
11965         (bcache_xmalloc): Remove.
11966         (bcache::~bcache): Rename from bcache_xfree.
11967         (bcache::print_statistics): Rename from print_bcache_statistics.
11968         (bcache::memory_used): Rename from bcache_memory_used.
11969
11970 2019-03-07  Pedro Alves  <palves@redhat.com>
11971
11972         * infrun.c (normal_stop): Also check for
11973         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
11974
11975 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
11976
11977         * f-lang.c (value_from_host_double): Moved to...
11978         * value.c (value_from_host_double): ...here.
11979         * value.h (value_from_host_double): Declare.
11980         * guile/scm-math.c (vlscm_convert_typed_number): Use
11981         value_from_host_double.
11982         (vlscm_convert_number): Likewise.
11983         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
11984         * python/py-value.c (convert_value_from_python): Likewise.
11985
11986 2019-03-06  Tom Tromey  <tom@tromey.com>
11987
11988         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
11989
11990 2019-03-06  Tom Tromey  <tom@tromey.com>
11991
11992         * utils.h (free_current_contents): Don't declare.
11993         * utils.c (free_current_contents): Remove.
11994
11995 2019-03-06  Tom Tromey  <tom@tromey.com>
11996
11997         * top.c (quit_force): Update.
11998         * main.c (captured_command_loop): Update.
11999         * common/new-op.c (operator new): Update.
12000         * common/common-exceptions.c (struct catcher)
12001         <save_cleanup_chain>: Remove member.
12002         (exceptions_state_mc_init): Update.
12003         (exception_try_scope_entry): Return nullptr.
12004         (exception_try_scope_exit, exception_rethrow)
12005         (throw_exception_sjlj, throw_exception_cxx): Update.
12006         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
12007         (all_cleanups, do_cleanups, discard_cleanups)
12008         (discard_final_cleanups, save_cleanups, save_final_cleanups)
12009         (restore_cleanups, restore_final_cleanups): Don't declare.
12010         (do_final_cleanups): Remove parameter.
12011         * common/cleanups.c (cleanup_chain, make_cleanup)
12012         (make_cleanup_dtor, all_cleanups, do_cleanups)
12013         (discard_my_cleanups, discard_cleanups)
12014         (discard_final_cleanups, save_my_cleanups, save_cleanups)
12015         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
12016         (null_cleanup): Remove.
12017         (do_final_cleanups): Remove parameter.
12018
12019 2019-03-06  Tom Tromey  <tom@tromey.com>
12020
12021         * remote.c (remote_target::remote_parse_stop_reply): Use
12022         unique_xmalloc_ptr.
12023
12024 2019-03-06  Tom Tromey  <tom@tromey.com>
12025
12026         * stabsread.c (struct stabs_field_info): Rename from field_info.
12027         <list, fnlist>: Add initializers.
12028         <obstack>: New member.
12029         (read_member_functions, read_struct_fields, read_baseclasses):
12030         Allocate on obstack.  Don't use cleanups.
12031         (read_one_struct_field, read_member_functions, read_struct_fields)
12032         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
12033         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
12034         (read_struct_type): Update.
12035
12036 2019-03-06  Tom Tromey  <tom@tromey.com>
12037
12038         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
12039         * common/filestuff.h (make_cleanup_close): Don't declare.
12040         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
12041         Remove.
12042
12043 2019-03-06  Tom Tromey  <tom@tromey.com>
12044
12045         * solib-aix.c: Use make_scope_exit.
12046
12047 2019-03-06  Tom Tromey  <tom@tromey.com>
12048
12049         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
12050         Use make_scope_exit.
12051
12052 2019-03-06  Tom Tromey  <tom@tromey.com>
12053
12054         * solib-svr4.c (disable_probes_interface): Remove parameter.
12055         (svr4_handle_solib_event): Use make_scope_exit.
12056
12057 2019-03-06  Tom Tromey  <tom@tromey.com>
12058
12059         * remote.c (struct stop_reply_deleter): Remove.
12060         (stop_reply_up): Update.
12061         (struct stop_reply): Derive from notif_event.  Don't typedef.
12062         <regcache>: Now a std::vector.
12063         (stop_reply_xfree): Remove.
12064         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
12065         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
12066         (remote_target::discard_pending_stop_replies): Use delete.
12067         (remote_target::remote_parse_stop_reply): Update.
12068         (remote_target::process_stop_reply): Update.
12069         * remote-notif.h (struct notif_event): Add virtual destructor.
12070         Remove "dtr" member.
12071         (struct notif_client) <alloc_event>: Return a unique_ptr.
12072         (notif_event_xfree): Don't declare.
12073         (notif_event_up): New typedef.
12074         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
12075         (notif_event_xfree, do_notif_event_xfree): Remove.
12076         (remote_notif_state_xfree): Update.
12077
12078 2019-03-06  Tom Tromey  <tom@tromey.com>
12079
12080         * infrun.c (displaced_step_clear_cleanup): Now a
12081         forward_scope_exit type.
12082         (displaced_step_prepare_throw): Update.
12083         (displaced_step_fixup): Update.
12084
12085 2019-03-06  Tom Tromey  <tom@tromey.com>
12086
12087         * inferior.h (class inferior): Update comment.
12088         * gdbthread.h (class thread_info): Update comment.
12089
12090 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
12091             Tom Tromey  <tom@tromey.com>
12092
12093         * stabsread.h (struct stab_section_list): Remove.
12094         (coffstab_build_psymtabs): Update.
12095         * dbxread.c (symbuf_sections): Now a std::vector.
12096         (sect_idx): New global.
12097         (fill_symbuf): Update.
12098         (coffstab_build_psymtabs): Change type of stabsects parameter.
12099         Update.
12100         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
12101         std::vector.
12102         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
12103         (coff_locate_sections): Update.
12104         (coff_symfile_read): Remove cleanups.  Update.
12105         (init_stringtab): Add storage parameter.
12106         (free_stringtab, free_stringtab_cleanup): Remove.
12107         (init_lineno): Add storage parameter.
12108         (free_linetab, free_linetab_cleanup): Remove.
12109
12110 2019-03-06  Pedro Alves  <palves@redhat.com>
12111
12112         * linux-fork.c (fork_info::clobber_regs): Delete.
12113         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
12114         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
12115         comment.  Adjust.
12116         (scoped_switch_fork_info::scoped_switch_fork_info)
12117         (checkpoint_command, linux_fork_context): Adjust
12118         fork_save_infrun_state calls.
12119
12120 2019-03-06  Pedro Alves  <palves@redhat.com>
12121
12122         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
12123         (inf_has_multiple_threads): Return 'bool' and rewrite using
12124         inferior_info::threads().
12125
12126 2019-03-06  Pedro Alves  <palves@redhat.com>
12127
12128         * linux-fork.c: Include <list>.
12129         (fork_list): Now a std::list instance.
12130         (fork_info): Add ctor, dtor, and in-class initialize all fields.
12131         (forks_exist_p, find_last_fork): Adjust.
12132         (new_fork): Delete.
12133         (one_fork_p): New.
12134         (add_fork): Adjust.
12135         (free_fork): Delete, folded into fork_info::~fork_info().
12136         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
12137         Adjust.
12138         (init_fork_list): Delete.
12139         (linux_fork_killall, linux_fork_mourn_inferior)
12140         (linux_fork_detach, info_checkpoints_command): Adjust.
12141         (_initialize_linux_fork): No longer call init_fork_list.
12142
12143 2019-03-06  Pedro Alves  <palves@redhat.com>
12144
12145         * linux-fork.c (new_fork): New, split out of ...
12146         (add_fork): ... this.  Return void.  Move "first fork" special
12147         case from here, to ...
12148         (checkpoint_command): ... here.
12149         * linux-linux.h (add_fork): Return void.
12150
12151 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
12152
12153         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
12154
12155 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
12156             Chris January  <chris.january@arm.com>
12157             David Lecomber  <david.lecomber@arm.com>
12158
12159         * f-exp.y: New token, UNOP_INTRINSIC.
12160         (exp): New pattern using UNOP_INTRINSIC token.
12161         (f77_keywords): Add 'abs' keyword.
12162         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
12163         (value_from_host_double): New function.
12164         (evaluate_subexp_f): Support UNOP_ABS.
12165
12166 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
12167
12168         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
12169         types.
12170
12171 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
12172
12173         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
12174         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
12175         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
12176
12177 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
12178
12179         * f-exp.y (convert_to_kind_type): Handle more type kinds.
12180
12181 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
12182             Chris January  <chris.january@arm.com>
12183
12184         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
12185         * f-exp.y: Define 'KIND' token.
12186         (exp): New pattern for KIND expressions.
12187         (ptype): Handle types with a kind extension.
12188         (direct_abs_decl): Extend to spot kind extensions.
12189         (f77_keywords): Add 'kind' to the list.
12190         (push_kind_type): New function.
12191         (convert_to_kind_type): New function.
12192         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
12193         * parse.c (operator_length_standard): Likewise.
12194         * parser-defs.h (enum type_pieces): Add tp_kind.
12195         * std-operator.def: Add UNOP_KIND.
12196
12197 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
12198
12199         * f-exp.y (f_parse): Set yydebug.
12200
12201 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
12202
12203         * f-lang.c (evaluate_subexp_f): New function.
12204         (exp_descriptor_f): New global.
12205         (f_language_defn): Use exp_descriptor_f instead of
12206         exp_descriptor_standard.
12207
12208 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
12209
12210         * f-exp.y (struct token): Add comments.
12211         (dot_ops): Remove uppercase versions and the end marker.
12212         (f77_keywords): Likewise.
12213         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
12214         entries in the dot_ops array are case insensitive, and use
12215         strncasecmp to compare strings.  Also some whitespace cleanup in
12216         this area.  Similar for the f77_keywords array, except entries in
12217         this list might be case sensitive.
12218
12219 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
12220
12221         * f-exp.y (struct f77_boolean_val): Add comments.
12222         (boolean_values): Remove uppercase versions, and end marker.
12223         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
12224         and use strncasecmp to achieve case insensitivity.  Additionally,
12225         perform whitespace cleanup around this code.
12226
12227 2019-03-06  Tom Tromey  <tromey@adacore.com>
12228
12229         * remote-sim.c (gdbsim_target_open): Use result of
12230         gdb_argv::release.
12231
12232 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
12233         Dirk Schubert  <dirk.schubert@arm.com>
12234         Chris January  <chris.january@arm.com>
12235
12236         * eval.c (evaluate_subexp_standard): Call Fortran argument
12237         wrapping logic.
12238         * f-lang.c (struct value): A value which can be passed into a
12239         Fortran function call.
12240         (fortran_argument_convert): Wrap Fortran arguments in a pointer
12241         where appropriate.
12242         (struct type): Value ready for a Fortran function call.
12243         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
12244         is needed.
12245         * f-lang.h (fortran_argument_convert): Declaration.
12246         (fortran_preserve_arg_pointer): Declaration.
12247         * infcall.c (value_arg_coerce): Call Fortran argument logic.
12248
12249 2019-03-05  Tom Tromey  <tromey@adacore.com>
12250
12251         * python/py-prettyprint.c (print_string_repr): Remove #if.
12252         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
12253
12254 2019-03-05  Tom Tromey  <tromey@adacore.com>
12255
12256         * target.c (the_dummy_target): Move later.  Change type to
12257         "dummy_target".
12258         (initialize_targets): Don't initialize the_dummy_target.
12259
12260 2019-03-05  Tom Tromey  <tromey@adacore.com>
12261
12262         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
12263         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
12264
12265 2019-03-05  Tom Tromey  <tromey@adacore.com>
12266
12267         * windows-nat.c (windows_nat_target::attach)
12268         (windows_nat_target::detach): Don't call gdb_flush.
12269         * valprint.c (generic_val_print, val_print, val_print_string):
12270         Don't call gdb_flush.
12271         * utils.c (defaulted_query): Don't call gdb_flush.
12272         * typeprint.c (print_type_scalar): Don't call gdb_flush.
12273         * target.c (target_announce_detach): Don't call gdb_flush.
12274         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
12275         * remote.c (extended_remote_target::attach): Don't call
12276         gdb_flush.
12277         * procfs.c (procfs_target::detach): Don't call gdb_flush.
12278         * printcmd.c (do_examine): Don't call gdb_flush.
12279         (info_display_command): Don't call gdb_flush.
12280         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
12281         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
12282         * memattr.c (info_mem_command): Don't call gdb_flush.
12283         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
12284         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
12285         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
12286         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
12287         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
12288         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
12289         (gnu_nat_target::detach): Don't call gdb_flush.
12290         * f-valprint.c (f_val_print): Don't call gdb_flush.
12291         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
12292         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
12293         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
12294         gdb_flush.
12295         * c-valprint.c (c_val_print): Don't call gdb_flush.
12296         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
12297
12298 2019-03-05  Tom Tromey  <tromey@adacore.com>
12299
12300         * varobj.c (update_dynamic_varobj_children): Update.
12301         (install_default_visualizer): Use reset, not release.
12302         * value.c (set_internalvar): Update.
12303         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
12304         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
12305         ATTRIBUTE_UNUSED_RESULT.
12306
12307 2019-03-05  Tom Tromey  <tromey@adacore.com>
12308
12309         * remote.c (class scoped_remote_fd) <release>: Add
12310         ATTRIBUTE_UNUSED_RESULT.
12311
12312 2019-03-05  Tom Tromey  <tromey@adacore.com>
12313
12314         * macroexp.c (struct macro_buffer) <release>: Add
12315         ATTRIBUTE_UNUSED_RESULT.
12316
12317 2019-03-05  Tom Tromey  <tromey@adacore.com>
12318
12319         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
12320         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
12321         ATTRIBUTE_UNUSED_RESULT.
12322
12323 2019-03-05  Tom Tromey  <tromey@adacore.com>
12324
12325         * common/scoped_fd.h (class scoped_fd) <release>: Add
12326         ATTRIBUTE_UNUSED_RESULT.
12327
12328 2019-03-05  Tom Tromey  <tromey@adacore.com>
12329
12330         * parser-defs.h (struct parser_state) <release>: Add
12331         ATTRIBUTE_UNUSED_RESULT.
12332
12333 2019-03-05  Tom Tromey  <tromey@adacore.com>
12334
12335         * utils.h (class gdb_argv) <release>: Add
12336         ATTRIBUTE_UNUSED_RESULT.
12337         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
12338
12339 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
12340
12341         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
12342         for-loop range, to avoid compiler warnings.
12343
12344         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
12345         avoid compiler warnings about unused variables.
12346
12347         * NEWS: Mention end of support for native debugging on MS-Windows
12348         before XP.
12349
12350         PR gdb/24292
12351         * common/netstuff.c:
12352         * gdbserver/gdbreplay.c
12353         * gdbserver/remote-utils.c:
12354         * ser-tcp.c:
12355         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
12356         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
12357         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
12358         'getaddrinfo' and 'freeaddrinfo' were not available before
12359         Windows XP, and mingw.org's MinGW headers by default define
12360         _WIN32_WINNT to 0x500.
12361
12362 2019-03-01  Gary Benson <gbenson@redhat.com>
12363
12364         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
12365
12366 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
12367             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
12368
12369         PR gdb/8527
12370         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
12371         set_sigint_trap, clear_sigint_trap.
12372
12373 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12374
12375         * target.c (target_detach): Clear the regcache and the
12376         frame cache.
12377
12378 2019-02-27  Pedro Alves  <palves@redhat.com>
12379
12380         * utils.c (set_screen_size): When we cap the height/width sizes,
12381         tweak the corresponding command variable to show "unlimited":
12382
12383 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
12384             Pedro Alves  <palves@redhat.com>
12385
12386         * utils.c (set_screen_size): Reduce "infinite" rows and columns
12387         before calling rl_set_screen_size.
12388
12389 2019-02-27  Tom Tromey  <tromey@adacore.com>
12390
12391         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
12392         define.
12393         * python/py-value.c: Remove Python 2.4 workaround.
12394         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
12395         workaround.
12396         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
12397         Python 2.4 workaround.
12398         * python/python-internal.h: Remove Python 2.4 comment.
12399         (Py_ssize_t): Don't define.
12400         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
12401         (gdb_Py_DECREF): Remove Python 2.4 workaround.
12402         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
12403         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
12404         * python/python.c (do_start_initialization): Remove Python 2.4
12405         workaround.
12406         * python/py-prettyprint.c (class dummy_python_frame): Remove.
12407         (print_children): Remove Python 2.4 workaround.
12408         * python/py-inferior.c (buffer_procs): Remove Python 2.4
12409         workaround.
12410         (CHARBUFFERPROC_NAME): Remove.
12411         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
12412         Python 2.4 workaround.
12413
12414 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
12415
12416         * NEWS: Note minimum Python version.
12417
12418 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
12419
12420         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
12421         code from these functions.  Remove corresponding ifdefs.  Use
12422         Py_buffer_up instead of explicit calls to PyBuffer_Release.
12423         Remove gotos and target of gotos.
12424         (infpy_search_memory): Likewise.
12425
12426 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12427
12428         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
12429         (hppa_gdbarch_init): Don't register deleted functions with
12430         gdbarch.
12431
12432 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12433
12434         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
12435         (h8300_unwind_sp): Delete.
12436         (h8300_dummy_id): Delete.
12437         (h8300_gdbarch_init): Don't register deleted functions with
12438         gdbarch.
12439
12440 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12441
12442         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
12443         (ft32_unwind_pc): Delete.
12444         (ft32_unwind_sp): Delete.
12445         (ft32_gdbarch_init): Don't register deleted functions with
12446         gdbarch.
12447
12448 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12449
12450         * gdb/frv-tdep.c (frv_dummy_id): Delete.
12451         (frv_unwind_pc): Delete.
12452         (frv_unwind_sp): Delete.
12453         (frv_gdbarch_init): Don't register deleted functions with
12454         gdbarch.
12455
12456 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12457
12458         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
12459         (riscv_unwind_pc): Delete.
12460         (riscv_unwind_sp): Delete.
12461         (riscv_gdbarch_init): Don't register deleted functions with
12462         gdbarch.
12463
12464 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12465
12466         * gdb/csky-tdep.c (csky_dummy_id): Delete.
12467         (csky_unwind_pc): Delete.
12468         (csky_unwind_sp): Delete.
12469         (csky_gdbarch_init): Don't register deleted functions with
12470         gdbarch.
12471
12472 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12473
12474         * gdb/cris-tdep.c (cris_dummy_id): Delete.
12475         (cris_unwind_pc): Delete.
12476         (cris_unwind_sp): Delete.
12477         (cris_gdbarch_init): Don't register deleted functions with
12478         gdbarch.
12479
12480 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12481
12482         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
12483         (bfin_unwind_pc): Delete.
12484         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
12485
12486 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12487
12488         * gdb/arm-tdep.c (arm_dummy_id): Delete.
12489         (arm_unwind_pc): Delete.
12490         (arm_unwind_sp): Delete.
12491         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
12492
12493 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12494
12495         * gdb/arc-tdep.c (arc_dummy_id): Delete.
12496         (arc_unwind_pc): Delete.
12497         (arc_unwind_sp): Delete.
12498         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
12499
12500 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12501
12502         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
12503         (alpha_unwind_pc): Delete.
12504         (alpha_gdbarch_init): Don't register deleted functions with
12505         gdbarch.
12506
12507 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12508
12509         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
12510         (aarch64_unwind_pc): Delete.
12511         (aarch64_unwind_sp): Delete.
12512         (aarch64_gdbarch_init): Don't register deleted functions with
12513         gdbarch.
12514
12515 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12516
12517         * gdbtypes.c (type_align): Don't consider static members when
12518         computing structure alignment.
12519
12520 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12521
12522         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
12523         return 0 for other types.
12524         * arch-utils.c (default_type_align): Always return 0.
12525         * gdbarch.h: Regenerate.
12526         * gdbarch.sh (type_align): Extend comment.
12527         * gdbtypes.c (type_align): Add additional comments, always call
12528         gdbarch_type_align before applying the default rules.
12529         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
12530         generic code will then apply a suitable default.
12531         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
12532         types, return 0 for other types.
12533
12534 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
12535
12536         * NEWS: Create a new section for the next release branch.
12537         Rename the section of the current branch, now that it has
12538         been cut.
12539
12540 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
12541
12542         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
12543         * version.in: Bump version to 8.3.50.DATE-git.
12544
12545 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
12546
12547         * aix-thread.c (ptid_cmp): Remove unused variable.
12548         (get_signaled_thread): Likewise.
12549         (store_regs_user_thread): Likewise.
12550         (store_regs_kernel_thread): Likewise.
12551         (fetch_regs_kernel_thread): Remove shadowed variable.
12552
12553 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
12554
12555         * features/riscv/32bit-cpu.xml: Add register numbers.
12556         * features/riscv/32bit-fpu.c: Regenerate.
12557         * features/riscv/32bit-fpu.xml: Add register numbers.
12558         * features/riscv/64bit-cpu.xml: Add register numbers.
12559         * features/riscv/64bit-fpu.c: Regenerate.
12560         * features/riscv/64bit-fpu.xml: Add register numbers.
12561
12562 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
12563
12564         * NEWS: Mention two argument form of gdb.Value constructor.
12565         * python/py-value.c (convert_buffer_and_type_to_value): New
12566         function.
12567         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
12568         Add support for handling an optional second argument.  Call
12569         convert_buffer_and_type_to_value as appropriate.
12570         * python/python-internal.h (Py_buffer_deleter): New struct.
12571         (Py_buffer_up): New typedef.
12572
12573 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
12574
12575         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
12576         instead of releasing ownership.
12577
12578 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
12579
12580         * dwarf2read.c (open_and_init_dwp_file): Call
12581         elf_numsections instead of bfd_count_sections to initialize
12582         dwp_file->num_sections.
12583
12584 2019-02-25  Tom Tromey  <tromey@adacore.com>
12585
12586         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
12587
12588 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
12589
12590         * gcore.in: Add '--readnever' option when invoking GDB.
12591
12592 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
12593
12594         * MAINTAINERS: Update my email address.
12595
12596 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
12597
12598         * build-id.c (build_id_to_debug_bfd_1): New function.
12599         (build_id_to_debug_bfd): Look for separate debug file in
12600         sysroot.
12601
12602 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
12603
12604         * gdbarch.sh: Update the copyright year range that is placed into
12605         generated files.
12606
12607 2019-02-22  Keith Seitz  <keiths@redhat.com>
12608
12609         PR symtab/23853
12610         * linespec.c (create_sals_line_offset): Search for the default
12611         symtab's filename instead of its fullname.
12612
12613 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
12614
12615         * NEWS: Update style defaults.
12616
12617 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
12618
12619         * main.c (captured_main_1): Disable styling in batch mode.
12620
12621 2019-02-20  Tom Tromey  <tom@tromey.com>
12622
12623         * symtab.c (symtab_symbol_info): Fix typos.
12624
12625 2019-02-20  Tom Tromey  <tromey@adacore.com>
12626
12627         * findcmd.c (_initialize_mem_search): Use upper case for
12628         metasyntactic variables.
12629
12630 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
12631
12632         * aarch64-tdep.c (aarch64_add_reggroups): New function.
12633         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
12634
12635 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
12636
12637         * top.h (source_file_name): Change to std::string.
12638         * top.c (source_file_name): Likewise.
12639         (command_line_input): Adjust.
12640         * cli/cli-script.c (script_from_file): Adjust.
12641
12642 2019-02-19  Tom Tromey  <tromey@adacore.com>
12643
12644         * ravenscar-thread.c
12645         (ravenscar_thread_target::update_thread_list): Don't call
12646         ada_build_task_list.
12647         * ada-lang.h (ada_build_task_list): Don't declare.
12648         * ada-tasks.c (struct ada_tasks_inferior_data)
12649         <task_list_valid_p>: Now bool.
12650         (read_known_tasks, ada_task_list_changed)
12651         (ada_tasks_invalidate_inferior_data): Update.
12652         (read_known_tasks_array): Return bool.
12653         (read_known_tasks_list): Likewise.
12654         (read_known_tasks): Return void.
12655         (ada_build_task_list): Now static.
12656
12657 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
12658
12659         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
12660         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
12661
12662 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12663
12664         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
12665         variant for ada_tasks_pspace_data_handle and
12666         ada_tasks_inferior_data_handle.
12667         (ada_tasks_pspace_data_cleanup): New function.
12668         (ada_tasks_inferior_data_cleanup): New function.
12669
12670 2019-02-17  Tom Tromey  <tom@tromey.com>
12671
12672         * macrotab.h (macro_source_fullname): Return a std::string.
12673         * macrotab.c (macro_include, check_for_redefinition)
12674         (macro_undef, macro_lookup_definition, foreach_macro)
12675         (foreach_macro_in_scope): Update.
12676         (macro_source_fullname): Return a std::string.
12677         * macrocmd.c (show_pp_source_pos): Update.
12678
12679 2019-02-17  Tom Tromey  <tom@tromey.com>
12680
12681         * macrocmd.c (show_pp_source_pos): Style the file names.
12682
12683 2019-02-17  Tom Tromey  <tom@tromey.com>
12684
12685         PR tui/24197:
12686         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
12687
12688 2019-02-17  Tom Tromey  <tom@tromey.com>
12689
12690         * ada-lang.c (user_select_syms): Use filtered printing.
12691         * utils.c (wrap_style): New global.
12692         (desired_style): Remove.
12693         (emit_style_escape): Add stream parameter.
12694         (set_output_style, reset_terminal_style, prompt_for_continue):
12695         Update.
12696         (flush_wrap_buffer): Only flush gdb_stdout.
12697         (wrap_here): Set wrap_style.
12698         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
12699         treat escape sequences as a character.  Change when wrap buffer is
12700         flushed.
12701         (fputs_styled): Do not set the output style when the default is
12702         requested.
12703         * ui-style.h (struct ui_file_style) <is_default>: New method.
12704         * source.c (print_source_lines_base): Emit escape sequences in one
12705         piece.
12706
12707 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
12708
12709         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
12710         integers and enumeration types.
12711
12712 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
12713
12714         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
12715         instead of lookup_symbol_in_language
12716         (do_exact_match): New function.
12717         (ada_get_symbol_name_matcher): Return do_exact_match when
12718         doing a verbatim match.
12719
12720 2019-02-15  Tom Tromey  <tromey@adacore.com>
12721
12722         * ravenscar-thread.c (ravenscar_thread_target::resume)
12723         (ravenscar_thread_target::wait): Special case wildcard requests.
12724
12725 2019-02-15  Tom Tromey  <tromey@adacore.com>
12726
12727         * ravenscar-thread.c (base_ptid): Remove.
12728         (struct ravenscar_thread_target) <close>: New method.
12729         <m_base_ptid>: New member.
12730         <update_inferior_ptid, active_task, task_is_currently_active,
12731         runtime_initialized>: Declare methods.
12732         <ravenscar_thread_target>: Add constructor.
12733         (ravenscar_thread_target::task_is_currently_active)
12734         (ravenscar_thread_target::update_inferior_ptid)
12735         (ravenscar_runtime_initialized): Rename.  Now methods.
12736         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
12737         (ravenscar_thread_target::update_thread_list): Update.
12738         (ravenscar_thread_target::active_task): Now method.
12739         (ravenscar_thread_target::store_registers)
12740         (ravenscar_thread_target::prepare_to_store)
12741         (ravenscar_thread_target::prepare_to_store)
12742         (ravenscar_thread_target::mourn_inferior): Update.
12743         (ravenscar_inferior_created): Use "new" to create target.
12744         (ravenscar_thread_target::get_ada_task_ptid): Update.
12745         (_initialize_ravenscar): Don't initialize base_ptid.
12746         (ravenscar_ops): Remove global.
12747
12748 2019-02-15  Tom Tromey  <tromey@adacore.com>
12749
12750         * target.h (push_target): Declare new overload.
12751         * target.c (push_target): New overload, taking an rvalue reference.
12752         * remote.c (remote_target::open_1): Use push_target overload.
12753         * corelow.c (core_target_open): Use push_target overload.
12754
12755 2019-02-15  Tom Tromey  <tromey@adacore.com>
12756
12757         * ravenscar-thread.c (is_ravenscar_task)
12758         (ravenscar_task_is_currently_active): Return bool.
12759         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
12760         (_initialize_ravenscar): Remove "(void)".
12761         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
12762         Return bool.
12763
12764 2019-02-15  Tom Tromey  <tromey@adacore.com>
12765
12766         * ravenscar-thread.c (ravenscar_runtime_initializer)
12767         (has_ravenscar_runtime, get_running_thread_id)
12768         (ravenscar_thread_target::resume): Fix indentation.
12769
12770 2019-02-15  Tom Tromey  <tromey@adacore.com>
12771
12772         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
12773         from ravenscar_arch_ops.
12774         (sparc_ravenscar_ops::fetch_registers)
12775         (sparc_ravenscar_ops::store_registers): Now methods.
12776         (sparc_ravenscar_prepare_to_store): Remove.
12777         (sparc_ravenscar_ops): Redefine.
12778         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
12779         methods and destructor.  Remove members.
12780         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
12781         (ravenscar_thread_target::store_registers)
12782         (ravenscar_thread_target::prepare_to_store): Update.
12783         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
12784         Remove.
12785         (struct ppc_ravenscar_powerpc_ops): Derive from
12786         ravenscar_arch_ops.
12787         (ppc_ravenscar_powerpc_ops::fetch_registers)
12788         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
12789         (ppc_ravenscar_powerpc_ops): Redefine.
12790         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
12791         (ppc_ravenscar_e500_ops::fetch_registers)
12792         (ppc_ravenscar_e500_ops::store_registers): Now methods.
12793         (ppc_ravenscar_e500_ops): Redefine.
12794         * aarch64-ravenscar-thread.c
12795         (aarch64_ravenscar_generic_prepare_to_store): Remove.
12796         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
12797         (aarch64_ravenscar_fetch_registers)
12798         (aarch64_ravenscar_store_registers): Now methods.
12799         (aarch64_ravenscar_ops): Redefine.
12800
12801 2019-02-15  Tom Tromey  <tromey@adacore.com>
12802
12803         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
12804         (ravenscar_thread_target::stopped_by_hw_breakpoint)
12805         (ravenscar_thread_target::stopped_by_watchpoint)
12806         (ravenscar_thread_target::stopped_data_address)
12807         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
12808
12809 2019-02-15  Tom Tromey  <tromey@adacore.com>
12810
12811         * ravenscar-thread.c: Fix some typos.
12812
12813 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12814             Tom Tromey  <tromey@adacore.com>
12815
12816         * ada-lang.c (ada_exception_sal): Change addr_string to a
12817         std::string.
12818         (create_ada_exception_catchpoint): Update.
12819
12820 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12821             Tom Tromey  <tromey@adacore.com>
12822
12823         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
12824         (bp_location_ops): Remove.
12825         (base_breakpoint_allocate_location): Update.
12826         (free_bp_location): Update.
12827         * ada-lang.c (class ada_catchpoint_location)
12828         <ada_catchpoint_location>: Remove ops parameter.
12829         (ada_catchpoint_location_dtor): Remove.
12830         (ada_catchpoint_location_ops): Remove.
12831         (allocate_location_exception): Update.
12832         * breakpoint.h (struct bp_location_ops): Remove.
12833         (class bp_location) <bp_location>: Remove bp_location_ops
12834         parameter.
12835         <~bp_location>: Add destructor.
12836         <ops>: Remove.
12837
12838 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
12839             Pedro Alves  <palves@redhat.com>
12840
12841         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
12842         'PATH_MAX'.
12843
12844 2019-02-14  David Michael  <fedora.dm0@gmail.com>
12845             Samuel Thibault  <samuel.thibault@gnu.org>
12846             Thomas Schwinge  <thomas@codesourcery.com>
12847
12848         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
12849         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
12850
12851 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
12852
12853         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
12854         (check_empty): Use "const char *".
12855
12856         * gnu-nat.c (gnu_nat_target::detach): Instead of
12857         'detach_inferior (pid)' call
12858         'detach_inferior (find_inferior_pid (pid))'.
12859
12860         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
12861         'nat/fork-inferior.o'.
12862         * gnu-nat.c: #include "nat/fork-inferior.h".
12863
12864         * gnu-nat.c (gnu_nat_target::detach): Instead of
12865         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
12866         * gnu-nat.h: #include "inf-child.h".
12867         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
12868         'i386_gnu_nat_target::fetch_registers'.
12869         (gnu_store_registers): Rename/move to
12870         'i386_gnu_nat_target::store_registers'.
12871
12872         * config/i386/nm-i386gnu.h: Don't "#include" any files.
12873         * gnu-nat.h (mach_thread_info): New function.
12874         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
12875
12876         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
12877
12878 2019-02-14  Frederic Konrad  <konrad@adacore.com>
12879
12880         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
12881
12882 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
12883
12884         * windows-nat.c (windows_add_thread): Add new parameter
12885         "main_thread_p" with default value set to false.  Update
12886         function documentation as well as all callers.
12887         (windows_delete_thread): Likewise.
12888         (fake_create_process): Update call to windows_add_thread.
12889         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
12890         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
12891         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
12892         call to windows_delete_thread.
12893
12894 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
12895
12896         * MAINTAINERS: Add Andrew Burgess as global maintainer.
12897
12898 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
12899
12900         * symfile.c (find_separate_debug_file): Use canonical path of
12901         sysroot with child_path instead of gdb_sysroot if it is valid.
12902
12903 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
12904
12905         * symfile.c (find_separate_debug_file): Use child_path to
12906         determine if an object file is under a sysroot.
12907
12908 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
12909
12910         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
12911         unittests/child-path-selftests.c.
12912         * common/pathstuff.c (child_path): New function.
12913         * common/pathstuff.h (child_path): New prototype.
12914         * unittests/child-path-selftests.c: New file.
12915
12916 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
12917
12918         * symfile.c (find_separate_debug_file): Look for separate debug
12919         files in debug directories under the sysroot.
12920
12921 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12922
12923         * symtab.h (struct minimal_symbol data_p): New const method.
12924         (struct minimal_symbol text_p): Likewise.
12925         * symtab.c (output_source_filename): Use file name style
12926         to print file name.
12927         (print_symbol_info): Likewise.
12928         (print_msymbol_info): Use address style to print addresses.
12929         Use function name style to print executable text symbols.
12930         (expand_symtab_containing_pc): Use data_p.
12931         (find_pc_sect_compunit_symtab): Likewise.
12932
12933 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12934
12935         * breakpoint.c (describe_other_breakpoints): Use address style
12936         to print addresses.
12937         (say_where): Likewise.
12938
12939 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12940
12941         * ada-typeprint.c (print_func_type): Print function name
12942         style to print function name.
12943         * c-typeprint.c (c_print_type_1): Likewise.
12944
12945 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
12946
12947         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
12948         for execve.
12949
12950 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12951
12952         * c-exp.y (direct_abs_decl): Use emplace_back to record the
12953         type_stack.
12954
12955 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
12956
12957         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
12958         TYPE_CODE_REF types.
12959
12960 2019-02-08  Jim Wilson  <jimw@sifive.com>
12961
12962         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
12963         (riscv_linux_fregset): New.
12964         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
12965
12966 2019-02-07  Tom Tromey  <tom@tromey.com>
12967
12968         * thread.c (thread_cancel_execution_command): Update.
12969         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
12970         methods.
12971         (struct thread_fsm_ops): Remove.
12972         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
12973         (thread_fsm_should_stop, thread_fsm_return_value)
12974         (thread_fsm_set_finished, thread_fsm_finished_p)
12975         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
12976         Don't declare.
12977         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
12978         * infrun.c (clear_proceed_status_thread)
12979         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
12980         (print_stop_event): Update.
12981         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
12982         Add constructor.
12983         (step_command_fsm_ops): Remove.
12984         (new_step_command_fsm): Remove.
12985         (step_1): Update.
12986         (step_command_fsm::should_stop): Rename from
12987         step_command_fsm_should_stop.
12988         (step_command_fsm::clean_up): Rename from
12989         step_command_fsm_clean_up.
12990         (step_command_fsm::do_async_reply_reason): Rename from
12991         step_command_fsm_async_reply_reason.
12992         (struct until_next_fsm): Inherit from thread_fsm.  Add
12993         constructor.
12994         (until_next_fsm_ops): Remove.
12995         (new_until_next_fsm): Remove.
12996         (until_next_fsm::should_stop): Rename from
12997         until_next_fsm_should_stop.
12998         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
12999         (until_next_fsm::do_async_reply_reason): Rename from
13000         until_next_fsm_async_reply_reason.
13001         (struct finish_command_fsm): Inherit from thread_fsm.  Add
13002         constructor.  Change type of breakpoint.
13003         (finish_command_fsm_ops): Remove.
13004         (new_finish_command_fsm): Remove.
13005         (finish_command_fsm::should_stop): Rename from
13006         finish_command_fsm_should_stop.
13007         (finish_command_fsm::clean_up): Rename from
13008         finish_command_fsm_clean_up.
13009         (finish_command_fsm::return_value): Rename from
13010         finish_command_fsm_return_value.
13011         (finish_command_fsm::do_async_reply_reason): Rename from
13012         finish_command_fsm_async_reply_reason.
13013         (finish_command): Update.
13014         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
13015         Add constructor.
13016         (call_thread_fsm_ops): Remove.
13017         (call_thread_fsm::call_thread_fsm): Rename from
13018         new_call_thread_fsm.
13019         (call_thread_fsm::should_stop): Rename from
13020         call_thread_fsm_should_stop.
13021         (call_thread_fsm::should_notify_stop): Rename from
13022         call_thread_fsm_should_notify_stop.
13023         (run_inferior_call, call_function_by_hand_dummy): Update.
13024         * cli/cli-interp.c (should_print_stop_to_console): Update.
13025         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
13026         Add constructor.  Change type of location_breakpoint,
13027         caller_breakpoint.
13028         (until_break_fsm_ops): Remove.
13029         (new_until_break_fsm): Remove.
13030         (until_break_fsm::should_stop): Rename from
13031         until_break_fsm_should_stop.
13032         (until_break_fsm::clean_up): Rename from
13033         until_break_fsm_clean_up.
13034         (until_break_fsm::do_async_reply_reason): Rename from
13035         until_break_fsm_async_reply_reason.
13036         (until_break_command): Update.
13037         * thread-fsm.c: Remove.
13038         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
13039
13040 2019-02-07  Tom Tromey  <tom@tromey.com>
13041
13042         * yy-remap.h: Add include guard.
13043         * xtensa-tdep.h: Add include guard.
13044         * xcoffread.h: Rename include guard.
13045         * varobj-iter.h: Add include guard.
13046         * tui/tui.h: Rename include guard.
13047         * tui/tui-winsource.h: Rename include guard.
13048         * tui/tui-wingeneral.h: Rename include guard.
13049         * tui/tui-windata.h: Rename include guard.
13050         * tui/tui-win.h: Rename include guard.
13051         * tui/tui-stack.h: Rename include guard.
13052         * tui/tui-source.h: Rename include guard.
13053         * tui/tui-regs.h: Rename include guard.
13054         * tui/tui-out.h: Rename include guard.
13055         * tui/tui-layout.h: Rename include guard.
13056         * tui/tui-io.h: Rename include guard.
13057         * tui/tui-hooks.h: Rename include guard.
13058         * tui/tui-file.h: Rename include guard.
13059         * tui/tui-disasm.h: Rename include guard.
13060         * tui/tui-data.h: Rename include guard.
13061         * tui/tui-command.h: Rename include guard.
13062         * tic6x-tdep.h: Add include guard.
13063         * target/waitstatus.h: Rename include guard.
13064         * target/wait.h: Rename include guard.
13065         * target/target.h: Rename include guard.
13066         * target/resume.h: Rename include guard.
13067         * target-float.h: Rename include guard.
13068         * stabsread.h: Add include guard.
13069         * rs6000-tdep.h: Add include guard.
13070         * riscv-fbsd-tdep.h: Add include guard.
13071         * regformats/regdef.h: Rename include guard.
13072         * record.h: Rename include guard.
13073         * python/python.h: Rename include guard.
13074         * python/python-internal.h: Rename include guard.
13075         * python/py-stopevent.h: Rename include guard.
13076         * python/py-ref.h: Rename include guard.
13077         * python/py-record.h: Rename include guard.
13078         * python/py-record-full.h: Rename include guard.
13079         * python/py-record-btrace.h: Rename include guard.
13080         * python/py-instruction.h: Rename include guard.
13081         * python/py-events.h: Rename include guard.
13082         * python/py-event.h: Rename include guard.
13083         * procfs.h: Add include guard.
13084         * proc-utils.h: Add include guard.
13085         * p-lang.h: Add include guard.
13086         * or1k-tdep.h: Rename include guard.
13087         * observable.h: Rename include guard.
13088         * nto-tdep.h: Rename include guard.
13089         * nat/x86-linux.h: Rename include guard.
13090         * nat/x86-linux-dregs.h: Rename include guard.
13091         * nat/x86-gcc-cpuid.h: Add include guard.
13092         * nat/x86-dregs.h: Rename include guard.
13093         * nat/x86-cpuid.h: Rename include guard.
13094         * nat/ppc-linux.h: Rename include guard.
13095         * nat/mips-linux-watch.h: Rename include guard.
13096         * nat/linux-waitpid.h: Rename include guard.
13097         * nat/linux-ptrace.h: Rename include guard.
13098         * nat/linux-procfs.h: Rename include guard.
13099         * nat/linux-osdata.h: Rename include guard.
13100         * nat/linux-nat.h: Rename include guard.
13101         * nat/linux-namespaces.h: Rename include guard.
13102         * nat/linux-btrace.h: Rename include guard.
13103         * nat/glibc_thread_db.h: Rename include guard.
13104         * nat/gdb_thread_db.h: Rename include guard.
13105         * nat/gdb_ptrace.h: Rename include guard.
13106         * nat/fork-inferior.h: Rename include guard.
13107         * nat/amd64-linux-siginfo.h: Rename include guard.
13108         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
13109         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
13110         * nat/aarch64-linux.h: Rename include guard.
13111         * nat/aarch64-linux-hw-point.h: Rename include guard.
13112         * mn10300-tdep.h: Add include guard.
13113         * mips-linux-tdep.h: Add include guard.
13114         * mi/mi-parse.h: Rename include guard.
13115         * mi/mi-out.h: Rename include guard.
13116         * mi/mi-main.h: Rename include guard.
13117         * mi/mi-interp.h: Rename include guard.
13118         * mi/mi-getopt.h: Rename include guard.
13119         * mi/mi-console.h: Rename include guard.
13120         * mi/mi-common.h: Rename include guard.
13121         * mi/mi-cmds.h: Rename include guard.
13122         * mi/mi-cmd-break.h: Rename include guard.
13123         * m2-lang.h: Add include guard.
13124         * location.h: Rename include guard.
13125         * linux-record.h: Rename include guard.
13126         * linux-nat.h: Add include guard.
13127         * linux-fork.h: Add include guard.
13128         * i386-darwin-tdep.h: Rename include guard.
13129         * hppa-linux-offsets.h: Add include guard.
13130         * guile/guile.h: Rename include guard.
13131         * guile/guile-internal.h: Rename include guard.
13132         * gnu-nat.h: Rename include guard.
13133         * gdb-stabs.h: Rename include guard.
13134         * frv-tdep.h: Add include guard.
13135         * f-lang.h: Add include guard.
13136         * event-loop.h: Add include guard.
13137         * darwin-nat.h: Rename include guard.
13138         * cp-abi.h: Rename include guard.
13139         * config/sparc/nm-sol2.h: Rename include guard.
13140         * config/nm-nto.h: Rename include guard.
13141         * config/nm-linux.h: Add include guard.
13142         * config/i386/nm-i386gnu.h: Rename include guard.
13143         * config/djgpp/nl_types.h: Rename include guard.
13144         * config/djgpp/langinfo.h: Rename include guard.
13145         * compile/gcc-cp-plugin.h: Add include guard.
13146         * compile/gcc-c-plugin.h: Add include guard.
13147         * compile/compile.h: Rename include guard.
13148         * compile/compile-object-run.h: Rename include guard.
13149         * compile/compile-object-load.h: Rename include guard.
13150         * compile/compile-internal.h: Rename include guard.
13151         * compile/compile-cplus.h: Rename include guard.
13152         * compile/compile-c.h: Rename include guard.
13153         * common/xml-utils.h: Rename include guard.
13154         * common/x86-xstate.h: Rename include guard.
13155         * common/version.h: Rename include guard.
13156         * common/vec.h: Rename include guard.
13157         * common/tdesc.h: Rename include guard.
13158         * common/selftest.h: Rename include guard.
13159         * common/scoped_restore.h: Rename include guard.
13160         * common/scoped_mmap.h: Rename include guard.
13161         * common/scoped_fd.h: Rename include guard.
13162         * common/safe-iterator.h: Rename include guard.
13163         * common/run-time-clock.h: Rename include guard.
13164         * common/refcounted-object.h: Rename include guard.
13165         * common/queue.h: Rename include guard.
13166         * common/ptid.h: Rename include guard.
13167         * common/print-utils.h: Rename include guard.
13168         * common/preprocessor.h: Rename include guard.
13169         * common/pathstuff.h: Rename include guard.
13170         * common/observable.h: Rename include guard.
13171         * common/netstuff.h: Rename include guard.
13172         * common/job-control.h: Rename include guard.
13173         * common/host-defs.h: Rename include guard.
13174         * common/gdb_wait.h: Rename include guard.
13175         * common/gdb_vecs.h: Rename include guard.
13176         * common/gdb_unlinker.h: Rename include guard.
13177         * common/gdb_unique_ptr.h: Rename include guard.
13178         * common/gdb_tilde_expand.h: Rename include guard.
13179         * common/gdb_sys_time.h: Rename include guard.
13180         * common/gdb_string_view.h: Rename include guard.
13181         * common/gdb_splay_tree.h: Rename include guard.
13182         * common/gdb_setjmp.h: Rename include guard.
13183         * common/gdb_ref_ptr.h: Rename include guard.
13184         * common/gdb_optional.h: Rename include guard.
13185         * common/gdb_locale.h: Rename include guard.
13186         * common/gdb_assert.h: Rename include guard.
13187         * common/filtered-iterator.h: Rename include guard.
13188         * common/filestuff.h: Rename include guard.
13189         * common/fileio.h: Rename include guard.
13190         * common/environ.h: Rename include guard.
13191         * common/common-utils.h: Rename include guard.
13192         * common/common-types.h: Rename include guard.
13193         * common/common-regcache.h: Rename include guard.
13194         * common/common-inferior.h: Rename include guard.
13195         * common/common-gdbthread.h: Rename include guard.
13196         * common/common-exceptions.h: Rename include guard.
13197         * common/common-defs.h: Rename include guard.
13198         * common/common-debug.h: Rename include guard.
13199         * common/cleanups.h: Rename include guard.
13200         * common/buffer.h: Rename include guard.
13201         * common/btrace-common.h: Rename include guard.
13202         * common/break-common.h: Rename include guard.
13203         * cli/cli-utils.h: Rename include guard.
13204         * cli/cli-style.h: Rename include guard.
13205         * cli/cli-setshow.h: Rename include guard.
13206         * cli/cli-script.h: Rename include guard.
13207         * cli/cli-interp.h: Rename include guard.
13208         * cli/cli-decode.h: Rename include guard.
13209         * cli/cli-cmds.h: Rename include guard.
13210         * charset-list.h: Add include guard.
13211         * buildsym-legacy.h: Rename include guard.
13212         * bfin-tdep.h: Add include guard.
13213         * ax.h: Rename include guard.
13214         * arm-linux-tdep.h: Add include guard.
13215         * arm-fbsd-tdep.h: Add include guard.
13216         * arch/xtensa.h: Rename include guard.
13217         * arch/tic6x.h: Add include guard.
13218         * arch/i386.h: Add include guard.
13219         * arch/arm.h: Rename include guard.
13220         * arch/arm-linux.h: Rename include guard.
13221         * arch/arm-get-next-pcs.h: Rename include guard.
13222         * arch/amd64.h: Add include guard.
13223         * arch/aarch64-insn.h: Rename include guard.
13224         * arch-utils.h: Rename include guard.
13225         * annotate.h: Add include guard.
13226         * amd64-darwin-tdep.h: Rename include guard.
13227         * aarch64-linux-tdep.h: Add include guard.
13228         * aarch64-fbsd-tdep.h: Add include guard.
13229         * aarch32-linux-nat.h: Add include guard.
13230
13231 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13232
13233         * macrotab.c (macro_define_internal): New function that
13234         factorizes macro_define_object_internal and macro_define_function
13235         code.
13236         (macro_define_object_internal): Use macro_define_internal.
13237         (macro_define_function): Likewise.
13238
13239 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13240
13241         * macrocmd.c (extract_identifier): Return
13242         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
13243         callers.
13244
13245 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
13246
13247         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
13248
13249 2019-02-05  Tom Tromey  <tom@tromey.com>
13250
13251         * target.c (target_stack::unpush): Move assertion earlier.
13252
13253 2019-01-30  Tom Tromey  <tom@tromey.com>
13254
13255         PR python/23615:
13256         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
13257         (gdbpy_parse_and_eval): Likewise.
13258         * python/python-internal.h (gdbpy_allow_threads): New class.
13259
13260 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
13261
13262         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
13263         (aarch64_fbsd_fpregmap): Move earlier.
13264         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
13265         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
13266         instead of individual calls to trad_frame_set_reg_addr.
13267         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
13268         earlier.
13269         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
13270         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
13271         instead of individual calls to trad_frame_set_reg_addr.
13272
13273 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
13274
13275         * CONTRIBUTE: Replace contribution list with wiki link.
13276
13277 2019-01-25  Tom Tromey  <tom@tromey.com>
13278
13279         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
13280
13281 2019-01-25  Tom Tromey  <tom@tromey.com>
13282
13283         * xtensa-linux-nat.c: Fix common/ includes.
13284         * xml-support.h: Fix common/ includes.
13285         * xml-support.c: Fix common/ includes.
13286         * x86-linux-nat.c: Fix common/ includes.
13287         * windows-nat.c: Fix common/ includes.
13288         * varobj.h: Fix common/ includes.
13289         * varobj.c: Fix common/ includes.
13290         * value.c: Fix common/ includes.
13291         * valops.c: Fix common/ includes.
13292         * utils.c: Fix common/ includes.
13293         * unittests/xml-utils-selftests.c: Fix common/ includes.
13294         * unittests/utils-selftests.c: Fix common/ includes.
13295         * unittests/unpack-selftests.c: Fix common/ includes.
13296         * unittests/tracepoint-selftests.c: Fix common/ includes.
13297         * unittests/style-selftests.c: Fix common/ includes.
13298         * unittests/string_view-selftests.c: Fix common/ includes.
13299         * unittests/scoped_restore-selftests.c: Fix common/ includes.
13300         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
13301         * unittests/scoped_fd-selftests.c: Fix common/ includes.
13302         * unittests/rsp-low-selftests.c: Fix common/ includes.
13303         * unittests/parse-connection-spec-selftests.c: Fix common/
13304         includes.
13305         * unittests/optional-selftests.c: Fix common/ includes.
13306         * unittests/offset-type-selftests.c: Fix common/ includes.
13307         * unittests/observable-selftests.c: Fix common/ includes.
13308         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
13309         * unittests/memrange-selftests.c: Fix common/ includes.
13310         * unittests/memory-map-selftests.c: Fix common/ includes.
13311         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
13312         * unittests/function-view-selftests.c: Fix common/ includes.
13313         * unittests/environ-selftests.c: Fix common/ includes.
13314         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
13315         * unittests/common-utils-selftests.c: Fix common/ includes.
13316         * unittests/cli-utils-selftests.c: Fix common/ includes.
13317         * unittests/array-view-selftests.c: Fix common/ includes.
13318         * ui-file.c: Fix common/ includes.
13319         * tui/tui-io.c: Fix common/ includes.
13320         * tracepoint.h: Fix common/ includes.
13321         * tracepoint.c: Fix common/ includes.
13322         * tracefile-tfile.c: Fix common/ includes.
13323         * top.h: Fix common/ includes.
13324         * top.c: Fix common/ includes.
13325         * thread.c: Fix common/ includes.
13326         * target/waitstatus.h: Fix common/ includes.
13327         * target/waitstatus.c: Fix common/ includes.
13328         * target.h: Fix common/ includes.
13329         * target.c: Fix common/ includes.
13330         * target-memory.c: Fix common/ includes.
13331         * target-descriptions.c: Fix common/ includes.
13332         * symtab.h: Fix common/ includes.
13333         * symfile.c: Fix common/ includes.
13334         * stap-probe.c: Fix common/ includes.
13335         * spu-linux-nat.c: Fix common/ includes.
13336         * sparc-nat.c: Fix common/ includes.
13337         * source.c: Fix common/ includes.
13338         * solib.c: Fix common/ includes.
13339         * solib-target.c: Fix common/ includes.
13340         * ser-unix.c: Fix common/ includes.
13341         * ser-tcp.c: Fix common/ includes.
13342         * ser-pipe.c: Fix common/ includes.
13343         * ser-base.c: Fix common/ includes.
13344         * selftest-arch.c: Fix common/ includes.
13345         * s12z-tdep.c: Fix common/ includes.
13346         * rust-exp.y: Fix common/ includes.
13347         * rs6000-aix-tdep.c: Fix common/ includes.
13348         * riscv-tdep.c: Fix common/ includes.
13349         * remote.c: Fix common/ includes.
13350         * remote-notif.h: Fix common/ includes.
13351         * remote-fileio.h: Fix common/ includes.
13352         * remote-fileio.c: Fix common/ includes.
13353         * regcache.h: Fix common/ includes.
13354         * regcache.c: Fix common/ includes.
13355         * record-btrace.c: Fix common/ includes.
13356         * python/python.c: Fix common/ includes.
13357         * python/py-type.c: Fix common/ includes.
13358         * python/py-inferior.c: Fix common/ includes.
13359         * progspace.h: Fix common/ includes.
13360         * producer.c: Fix common/ includes.
13361         * procfs.c: Fix common/ includes.
13362         * proc-api.c: Fix common/ includes.
13363         * printcmd.c: Fix common/ includes.
13364         * ppc-linux-nat.c: Fix common/ includes.
13365         * parser-defs.h: Fix common/ includes.
13366         * osdata.c: Fix common/ includes.
13367         * obsd-nat.c: Fix common/ includes.
13368         * nat/x86-linux.c: Fix common/ includes.
13369         * nat/x86-linux-dregs.c: Fix common/ includes.
13370         * nat/x86-dregs.h: Fix common/ includes.
13371         * nat/x86-dregs.c: Fix common/ includes.
13372         * nat/ppc-linux.c: Fix common/ includes.
13373         * nat/mips-linux-watch.h: Fix common/ includes.
13374         * nat/mips-linux-watch.c: Fix common/ includes.
13375         * nat/linux-waitpid.c: Fix common/ includes.
13376         * nat/linux-ptrace.h: Fix common/ includes.
13377         * nat/linux-ptrace.c: Fix common/ includes.
13378         * nat/linux-procfs.c: Fix common/ includes.
13379         * nat/linux-personality.c: Fix common/ includes.
13380         * nat/linux-osdata.c: Fix common/ includes.
13381         * nat/linux-namespaces.c: Fix common/ includes.
13382         * nat/linux-btrace.h: Fix common/ includes.
13383         * nat/linux-btrace.c: Fix common/ includes.
13384         * nat/fork-inferior.c: Fix common/ includes.
13385         * nat/amd64-linux-siginfo.c: Fix common/ includes.
13386         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
13387         * nat/aarch64-linux.c: Fix common/ includes.
13388         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
13389         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
13390         * namespace.h: Fix common/ includes.
13391         * mips-linux-tdep.c: Fix common/ includes.
13392         * minsyms.c: Fix common/ includes.
13393         * mi/mi-parse.h: Fix common/ includes.
13394         * mi/mi-main.c: Fix common/ includes.
13395         * mi/mi-cmd-env.c: Fix common/ includes.
13396         * memrange.h: Fix common/ includes.
13397         * memattr.c: Fix common/ includes.
13398         * maint.h: Fix common/ includes.
13399         * maint.c: Fix common/ includes.
13400         * main.c: Fix common/ includes.
13401         * machoread.c: Fix common/ includes.
13402         * location.c: Fix common/ includes.
13403         * linux-thread-db.c: Fix common/ includes.
13404         * linux-nat.c: Fix common/ includes.
13405         * linux-fork.c: Fix common/ includes.
13406         * inline-frame.c: Fix common/ includes.
13407         * infrun.c: Fix common/ includes.
13408         * inflow.c: Fix common/ includes.
13409         * inferior.h: Fix common/ includes.
13410         * inferior.c: Fix common/ includes.
13411         * infcmd.c: Fix common/ includes.
13412         * inf-ptrace.c: Fix common/ includes.
13413         * inf-child.c: Fix common/ includes.
13414         * ia64-linux-nat.c: Fix common/ includes.
13415         * i387-tdep.c: Fix common/ includes.
13416         * i386-tdep.c: Fix common/ includes.
13417         * i386-linux-tdep.c: Fix common/ includes.
13418         * i386-linux-nat.c: Fix common/ includes.
13419         * i386-go32-tdep.c: Fix common/ includes.
13420         * i386-fbsd-tdep.c: Fix common/ includes.
13421         * i386-fbsd-nat.c: Fix common/ includes.
13422         * guile/scm-type.c: Fix common/ includes.
13423         * guile/guile.c: Fix common/ includes.
13424         * go32-nat.c: Fix common/ includes.
13425         * gnu-nat.c: Fix common/ includes.
13426         * gdbthread.h: Fix common/ includes.
13427         * gdbarch-selftests.c: Fix common/ includes.
13428         * gdb_usleep.c: Fix common/ includes.
13429         * gdb_select.h: Fix common/ includes.
13430         * gdb_bfd.c: Fix common/ includes.
13431         * gcore.c: Fix common/ includes.
13432         * fork-child.c: Fix common/ includes.
13433         * findvar.c: Fix common/ includes.
13434         * fbsd-nat.c: Fix common/ includes.
13435         * event-top.c: Fix common/ includes.
13436         * event-loop.c: Fix common/ includes.
13437         * dwarf2read.c: Fix common/ includes.
13438         * dwarf2loc.c: Fix common/ includes.
13439         * dwarf2-frame.c: Fix common/ includes.
13440         * dwarf-index-cache.c: Fix common/ includes.
13441         * dtrace-probe.c: Fix common/ includes.
13442         * disasm-selftests.c: Fix common/ includes.
13443         * defs.h: Fix common/ includes.
13444         * csky-tdep.c: Fix common/ includes.
13445         * cp-valprint.c: Fix common/ includes.
13446         * cp-support.h: Fix common/ includes.
13447         * cp-support.c: Fix common/ includes.
13448         * corelow.c: Fix common/ includes.
13449         * completer.h: Fix common/ includes.
13450         * completer.c: Fix common/ includes.
13451         * compile/compile.c: Fix common/ includes.
13452         * compile/compile-loc2c.c: Fix common/ includes.
13453         * compile/compile-cplus-types.c: Fix common/ includes.
13454         * compile/compile-cplus-symbols.c: Fix common/ includes.
13455         * command.h: Fix common/ includes.
13456         * cli/cli-dump.c: Fix common/ includes.
13457         * cli/cli-cmds.c: Fix common/ includes.
13458         * charset.c: Fix common/ includes.
13459         * build-id.c: Fix common/ includes.
13460         * btrace.h: Fix common/ includes.
13461         * btrace.c: Fix common/ includes.
13462         * breakpoint.h: Fix common/ includes.
13463         * breakpoint.c: Fix common/ includes.
13464         * ax.h:
13465         (enum agent_op): Fix common/ includes.
13466         * ax-general.c (struct aop_map): Fix common/ includes.
13467         * ax-gdb.c: Fix common/ includes.
13468         * auxv.c: Fix common/ includes.
13469         * auto-load.c: Fix common/ includes.
13470         * arm-tdep.c: Fix common/ includes.
13471         * arch/riscv.c: Fix common/ includes.
13472         * arch/ppc-linux-common.c: Fix common/ includes.
13473         * arch/i386.c: Fix common/ includes.
13474         * arch/arm.c: Fix common/ includes.
13475         * arch/arm-linux.c: Fix common/ includes.
13476         * arch/arm-get-next-pcs.c: Fix common/ includes.
13477         * arch/amd64.c: Fix common/ includes.
13478         * arch/aarch64.c: Fix common/ includes.
13479         * arch/aarch64-insn.c: Fix common/ includes.
13480         * arch-utils.c: Fix common/ includes.
13481         * amd64-windows-tdep.c: Fix common/ includes.
13482         * amd64-tdep.c: Fix common/ includes.
13483         * amd64-sol2-tdep.c: Fix common/ includes.
13484         * amd64-obsd-tdep.c: Fix common/ includes.
13485         * amd64-nbsd-tdep.c: Fix common/ includes.
13486         * amd64-linux-tdep.c: Fix common/ includes.
13487         * amd64-linux-nat.c: Fix common/ includes.
13488         * amd64-fbsd-tdep.c: Fix common/ includes.
13489         * amd64-fbsd-nat.c: Fix common/ includes.
13490         * amd64-dicos-tdep.c: Fix common/ includes.
13491         * amd64-darwin-tdep.c: Fix common/ includes.
13492         * agent.c: Fix common/ includes.
13493         * ada-lang.h: Fix common/ includes.
13494         * ada-lang.c: Fix common/ includes.
13495         * aarch64-tdep.c: Fix common/ includes.
13496
13497 2019-01-25  Tom Tromey  <tom@tromey.com>
13498
13499         * common/create-version.sh: Use common/version.h.
13500
13501 2019-01-24  Pedro Alves  <palves@redhat.com>
13502
13503         * infrun.c (signal_stop, signal_print, signal_program)
13504         (signal_catch, signal_pass): Now arrays instead of pointers.
13505         (update_signals_program_target, do_target_resume)
13506         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
13507         * linux-nat.c (linux_nat_target::pass_signals)
13508         (linux_nat_target::create_inferior, linux_nat_target::attach):
13509         Adjust.
13510         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
13511         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
13512         * procfs.c (procfs_target::pass_signals): Adjust.
13513         * record-full.c (record_full_target::resume): Adjust.
13514         * remote.c (remote_target::pass_signals)
13515         (remote_target::program_signals): Adjust.
13516         * target-debug.h (target_debug_print_signals): Now takes a
13517         gdb::array_view as parameter.  Adjust.
13518         * target.h (target_ops) <pass_signals, program_signals>: Replace
13519         pointer and length parameters with gdb::array_view.
13520         (target_pass_signals, target_program_signals): Likewise.
13521         * target-delegates.c: Regenerate.
13522
13523 2019-01-24  Pedro Alves  <palves@redhat.com>
13524
13525         * common/forward-scope-exit.h
13526         (forward_scope_exit::forward_scope_exit): Pass arguments to
13527         m_bind_function directly, instead of creating a std::bind and
13528         copying that.
13529
13530 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
13531
13532         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
13533         for static members.
13534         (pass_in_v_vfp_candidate): Likewise.
13535
13536 2019-01-23  Tom Tromey  <tom@tromey.com>
13537             Pedro Alves  <palves@redhat.com>
13538
13539         * regcache.c (class regcache_invalidator): Remove.
13540         (regcache::raw_write): Use make_scope_exit.
13541
13542 2019-01-23  Tom Tromey  <tom@tromey.com>
13543
13544         * ui-out.h (class ui_out_emit_type): Update comment.
13545
13546 2019-01-23  Tom Tromey  <tom@tromey.com>
13547
13548         * infrun.c (fetch_inferior_event): Update comment.
13549
13550 2019-01-23  Tom Tromey  <tom@tromey.com>
13551             Pedro Alves  <palves@redhat.com>
13552
13553         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
13554         parameter.
13555         (fetch_inferior_event): Use SCOPE_EXIT.
13556
13557
13558 2019-01-23  Tom Tromey  <tom@tromey.com>
13559             Pedro Alves  <palves@redhat.com>
13560
13561         * infrun.c (disable_thread_events): Delete.
13562         (stop_all_threads): Use SCOPE_EXIT.
13563
13564 2019-01-23  Tom Tromey  <tom@tromey.com>
13565             Pedro Alves  <palves@redhat.com>
13566
13567         * symfile.c: Include forward-scope-exit.h.
13568         (clear_symtab_users_cleanup): Replace forward declaration with
13569         a FORWARD_SCOPE_EXIT.
13570         (syms_from_objfile_1): Use the forward_scope_exit and
13571         gdb::optional instead of cleanup_function.
13572         (reread_symbols): Use the forward_scope_exit instead of
13573         cleanup_function.
13574         (clear_symtab_users_cleanup): Remove function.
13575
13576 2019-01-23  Tom Tromey  <tom@tromey.com>
13577             Pedro Alves  <palves@redhat.com>
13578
13579         * linux-nat.c: Include scope-exit.h.
13580         (cleanup_target_stop): Remove.
13581         (linux_nat_target::static_tracepoint_markers_by_strid): Use
13582         SCOPE_EXIT.
13583
13584 2019-01-23  Tom Tromey  <tom@tromey.com>
13585             Pedro Alves  <palves@redhat.com>
13586
13587         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
13588         (call_function_by_hand_dummy): Use SCOPE_EXIT.
13589
13590 2019-01-23  Tom Tromey  <tom@tromey.com>
13591             Andrew Burgess  <andrew.burgess@embecosm.com>
13592             Pedro Alves  <palves@redhat.com>
13593
13594         * infrun.c (fetch_inferior_event): Use scope_exit.
13595         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
13596         * top.c (execute_command): Use scope_exit.
13597         * breakpoint.c (bpstat_do_actions): Use scope_exit.
13598         * utils.c (do_bpstat_clear_actions_cleanup)
13599         (make_bpstat_clear_actions_cleanup): Remove.
13600
13601 2019-01-23  Tom Tromey  <tom@tromey.com>
13602             Pedro Alves  <palves@redhat.com>
13603
13604         * infrun.c: Include "common/scope-exit.h"
13605         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
13606         (wait_for_inferior): Use SCOPE_EXIT.
13607         (fetch_inferior_event): Use scope_exit.
13608
13609 2019-01-23  Tom Tromey  <tom@tromey.com>
13610             Pedro Alves  <palves@redhat.com>
13611
13612         * breakpoint.c (create_breakpoint): Remove cleanup.
13613
13614 2019-01-23  Tom Tromey  <tom@tromey.com>
13615             Andrew Burgess  <andrew.burgess@embecosm.com>
13616             Pedro Alves  <palves@redhat.com>
13617
13618 2019-01-23  Pedro Alves  <palves@redhat.com>
13619
13620         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
13621
13622 2019-01-23  Pedro Alves  <palves@redhat.com>
13623             Andrew Burgess  <andrew.burgess@embecosm.com>
13624
13625         * gdbthread.h: Include "common/forward-scope-exit.h".
13626         (scoped_finish_thread_state): Redefine custom class in terms of
13627         forward_scope_exit.
13628
13629 2019-01-23  Pedro Alves  <palves@redhat.com>
13630             Andrew Burgess  <andrew.burgess@embecosm.com>
13631
13632         * common/forward-scope-exit.h: New file.
13633
13634 2019-01-23  Pedro Alves  <palves@redhat.com>
13635             Andrew Burgess  <andrew.burgess@embecosm.com>
13636             Tom Tromey  <tom@tromey.com>
13637
13638         * common/scope-exit.h: New file.
13639
13640 2019-01-23  Pedro Alves  <palves@redhat.com>
13641
13642         * common/preprocessor.h (ESC): Rename to ...
13643         (ESC_PARENS): ... this.
13644         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
13645         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
13646
13647 2019-01-23  Tom Tromey  <tom@tromey.com>
13648
13649         * language.h (class scoped_switch_to_sym_language_if_auto):
13650         Initialize m_lang in both cases.
13651
13652 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
13653
13654         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
13655         with XCNEW.
13656
13657 2019-01-22  Tom Tromey  <tom@tromey.com>
13658
13659         * corelow.c: Do not include sys/file.h.
13660
13661 2019-01-22  Tom Tromey  <tom@tromey.com>
13662
13663         * tui/tui-wingeneral.h: Include gdb_curses.h.
13664
13665 2019-01-22  Tom Tromey  <tom@tromey.com>
13666
13667         * source-cache.h (class source_cache) <get_source_lines,
13668         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
13669
13670 2019-01-22  Tom Tromey  <tom@tromey.com>
13671
13672         * remote-fileio.h (struct remote_target): Declare.
13673
13674 2019-01-22  Tom Tromey  <tom@tromey.com>
13675
13676         * python/py-arch.c: Do not include py-ref.h.
13677         * python/py-bpevent.c: Do not include py-ref.h.
13678         * python/py-cmd.c: Do not include py-ref.h.
13679         * python/py-continueevent.c: Do not include py-ref.h.
13680         * python/py-event.h: Do not include py-ref.h.
13681         * python/py-evtregistry.c: Do not include py-ref.h.
13682         * python/py-finishbreakpoint.c: Do not include py-ref.h.
13683         * python/py-frame.c: Do not include py-ref.h.
13684         * python/py-framefilter.c: Do not include py-ref.h.
13685         * python/py-function.c: Do not include py-ref.h.
13686         * python/py-infevents.c: Do not include py-ref.h.
13687         * python/py-linetable.c: Do not include py-ref.h.
13688         * python/py-objfile.c: Do not include py-ref.h.
13689         * python/py-param.c: Do not include py-ref.h.
13690         * python/py-prettyprint.c: Do not include py-ref.h.
13691         * python/py-progspace.c: Do not include py-ref.h.
13692         * python/py-symbol.c: Do not include py-ref.h.
13693         * python/py-symtab.c: Do not include py-ref.h.
13694         * python/py-type.c: Do not include py-ref.h.
13695         * python/py-unwind.c: Do not include py-ref.h.
13696         * python/py-utils.c: Do not include py-ref.h.
13697         * python/py-value.c: Do not include py-ref.h.
13698         * python/py-varobj.c: Do not include py-ref.h.
13699         * python/py-xmethods.c: Do not include py-ref.h.
13700         * python/python.c: Do not include py-ref.h.
13701         * varobj.c: Do not include py-ref.h.
13702
13703 2019-01-22  Tom Tromey  <tom@tromey.com>
13704
13705         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
13706         keyword for bcache.
13707
13708 2019-01-22  Tom Tromey  <tom@tromey.com>
13709
13710         * compile/compile-cplus-types.c: Remove a comment by #include.
13711
13712 2019-01-22  Tom Tromey  <tom@tromey.com>
13713
13714         * compile/gcc-c-plugin.h: Include compile-internal.h.
13715
13716 2019-01-22  Tom Tromey  <tom@tromey.com>
13717
13718         * stabsread.c (EXTERN): Do not define.
13719         (symnum, next_symbol_text_func, processing_gcc_compilation)
13720         (within_function, global_sym_chain, global_stabs)
13721         (previous_stab_code, this_object_header_files)
13722         (n_this_object_header_files)
13723         (n_allocated_this_object_header_files): Define.
13724         * stabsread.h (EXTERN): Never define.  Use "extern".
13725
13726 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13727
13728         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
13729         history_value.
13730
13731 2019-01-21  Tom Tromey  <tom@tromey.com>
13732
13733         * ui-out.c: Fix includes.
13734         * tui/tui-source.c: Fix includes.
13735         * target.c: Fix includes.
13736         * remote.c: Fix includes.
13737         * regcache.c: Fix includes.
13738         * python/py-block.c: Fix includes.
13739         * printcmd.c: Fix includes.
13740         * or1k-tdep.c: Fix includes.
13741         * mi/mi-main.c: Fix includes.
13742         * m32r-tdep.c: Fix includes.
13743         * csky-tdep.c: Fix includes.
13744         * compile/compile-cplus-types.c: Fix includes.
13745         * cli/cli-interp.c: Fix includes.
13746
13747 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
13748
13749         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
13750         for padding.
13751
13752 2019-01-16  Tom Tromey  <tom@tromey.com>
13753
13754         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
13755         earlier.
13756         (struct objfile) <msymbols_range>: Move from top level.
13757         <msymbols>: New method.
13758         (class objfile_msymbols): Remove.
13759         * symtab.c (default_collect_symbol_completion_matches_break_on):
13760         Update.
13761         * symmisc.c (dump_msymbols): Update.
13762         * stabsread.c (scan_file_globals): Update.
13763         * objc-lang.c (info_selectors_command, info_classes_command)
13764         (find_methods): Update.
13765         * minsyms.c (find_solib_trampoline_target): Update.
13766         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
13767         * coffread.c (coff_symfile_read): Update.
13768         * ada-lang.c (ada_lookup_simple_minsym)
13769         (ada_collect_symbol_completion_matches): Update.
13770
13771 2019-01-16  Tom Tromey  <tom@tromey.com>
13772
13773         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
13774         type.  Remove no-argument constructor.
13775         <iterator::operator++>: Simplify.
13776         <begin>: Update.
13777         <end>: Use minimal_symbol_count.
13778
13779 2019-01-16  Tom Tromey  <tom@tromey.com>
13780
13781         * objfiles.h (struct objfile) <psymtabs>: New method.
13782         (class objfile_psymtabs): Remove.
13783         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
13784         typedef.
13785         <range>: New method.
13786         (require_partial_symbols): Change return type.
13787         * psymtab.c (require_partial_symbols)
13788         (psym_expand_symtabs_matching): Update.
13789         * mdebugread.c (parse_partial_symbols): Update.
13790         * dbxread.c (dbx_end_psymtab): Update.
13791
13792 2019-01-15  Tom Tromey  <tom@tromey.com>
13793
13794         * symtab.c (lookup_objfile_from_block)
13795         (lookup_symbol_in_objfile_symtabs)
13796         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
13797         (find_line_symtab, info_sources_command)
13798         (default_collect_symbol_completion_matches_break_on)
13799         (make_source_files_completion_list): Update.
13800         * symmisc.c (print_objfile_statistics, dump_objfile)
13801         (maintenance_print_symbols, maintenance_info_symtabs)
13802         (maintenance_check_symtabs, maintenance_info_line_tables):
13803         Update.
13804         * source.c (select_source_symtab)
13805         (forget_cached_source_info_for_objfile): Update.
13806         * objfiles.h (class objfile_compunits): Remove.
13807         (struct objfile) <compunits_range>: New typedef.
13808         (compunits): New method.
13809         * objfiles.c (objfile_relocate1): Update.
13810         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
13811         * maint.c (count_symtabs_and_blocks): Update.
13812         * linespec.c (iterate_over_all_matching_symtabs): Update.
13813         * cp-support.c (add_symbol_overload_list_qualified): Update.
13814         * coffread.c (coff_symtab_read): Update.
13815         * ada-lang.c (add_nonlocal_symbols)
13816         (ada_collect_symbol_completion_matches)
13817         (ada_add_global_exceptions): Update.
13818
13819 2019-01-15  Tom Tromey  <tom@tromey.com>
13820
13821         * progspace.h (program_space) <objfiles_safe_range>: New
13822         typedef.
13823         <objfiles_safe>: New method.
13824         * objfiles.h (class all_objfiles_safe): Remove.
13825         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
13826         * jit.c (jit_inferior_exit_hook): Update.
13827
13828 2019-01-17  Tom Tromey  <tom@tromey.com>
13829
13830         * progspace.h (program_space) <objfiles_range>: New typedef.
13831         <objfiles>: New method.
13832         <objfiles_head>: Rename from objfiles.
13833         (object_files): Update.
13834         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
13835         * guile/scm-pretty-print.c
13836         (ppscm_find_pretty_printer_from_objfiles): Update.
13837         * guile/scm-objfile.c (gdbscm_objfiles): Update.
13838         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
13839         Update.
13840         * python/py-progspace.c (pspy_get_objfiles): Update.
13841         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
13842         Update.
13843         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
13844         (objfpy_lookup_objfile_by_build_id): Update.
13845         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
13846         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
13847         Update.
13848         * symtab.c (iterate_over_symtabs, matching_obj_sections)
13849         (expand_symtab_containing_pc, lookup_objfile_from_block)
13850         (lookup_static_symbol, basic_lookup_transparent_type)
13851         (find_pc_sect_compunit_symtab, find_symbol_at_address)
13852         (find_line_symtab, info_sources_command)
13853         (default_collect_symbol_completion_matches_break_on)
13854         (make_source_files_completion_list, find_main_name): Update.
13855         * symmisc.c (print_symbol_bcache_statistics)
13856         (print_objfile_statistics, maintenance_print_symbols)
13857         (maintenance_print_msymbols, maintenance_print_objfiles)
13858         (maintenance_info_symtabs, maintenance_check_symtabs)
13859         (maintenance_expand_symtabs, maintenance_info_line_tables):
13860         Update.
13861         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
13862         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
13863         (map_overlay_command, unmap_overlay_command)
13864         (simple_overlay_update, expand_symtabs_matching)
13865         (map_symbol_filenames): Update.
13866         * symfile-debug.c (set_debug_symfile): Update.
13867         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
13868         Update.
13869         * source.c (select_source_symtab, forget_cached_source_info):
13870         Update.
13871         * solib.c (solib_read_symbols): Update.
13872         * solib-spu.c (append_ocl_sos): Update.
13873         * psymtab.c (maintenance_print_psymbols)
13874         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
13875         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
13876         * printcmd.c (info_symbol_command): Update.
13877         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
13878         Update.
13879         * objfiles.h (class all_objfiles): Remove.
13880         * objfiles.c (have_partial_symbols, have_full_symbols)
13881         (have_minimal_symbols, qsort_cmp, update_section_map)
13882         (shared_objfile_contains_address_p)
13883         (default_iterate_over_objfiles_in_search_order): Update.
13884         * objc-lang.c (info_selectors_command, info_classes_command)
13885         (find_methods): Update.
13886         * minsyms.c (find_solib_trampoline_target): Update.
13887         * maint.c (maintenance_info_sections)
13888         (maintenance_translate_address, count_symtabs_and_blocks):
13889         Update.
13890         * main.c (captured_main_1): Update.
13891         * linux-thread-db.c (try_thread_db_load_from_pdir)
13892         (has_libpthread): Update.
13893         * linespec.c (iterate_over_all_matching_symtabs)
13894         (search_minsyms_for_name): Update.
13895         * jit.c (jit_find_objf_with_entry_addr): Update.
13896         * hppa-tdep.c (find_unwind_entry)
13897         (hppa_lookup_stub_minimal_symbol): Update.
13898         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
13899         Update.
13900         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
13901         (elf_gnu_ifunc_resolve_by_got): Update.
13902         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
13903         * dwarf-index-write.c (save_gdb_index_command): Update.
13904         * cp-support.c (add_symbol_overload_list_qualified): Update.
13905         * breakpoint.c (create_overlay_event_breakpoint)
13906         (create_longjmp_master_breakpoint)
13907         (create_std_terminate_master_breakpoint)
13908         (create_exception_master_breakpoint): Update.
13909         * blockframe.c (find_pc_partial_function): Update.
13910         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
13911         (ada_collect_symbol_completion_matches)
13912         (ada_add_global_exceptions): Update.
13913
13914 2019-01-17  Tom Tromey  <tom@tromey.com>
13915
13916         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
13917         declare VEC.
13918         (solib_target_parse_libraries): Change return type.
13919         (library_list_start_segment, library_list_start_section)
13920         (library_list_end_library, library_list_start_library); Update.
13921         (solib_target_free_library_list): Remove.
13922         (solib_target_parse_libraries): Remove cleanup.  Change return
13923         type.
13924         (solib_target_current_sos): Update.
13925
13926 2019-01-17  Tom Tromey  <tromey@bapiya>
13927
13928         * valprint.c: Replace "the the" with "the".
13929         * symtab.c: Replace "the the" with "the".
13930         * solib.c: Replace "the the" with "the".
13931         * solib-dsbt.c: Replace "the the" with "the".
13932         * linespec.c: Replace "the the" with "the".
13933         * dwarf2loc.h: Replace "the the" with "the".
13934         * amd64-windows-tdep.c: Replace "the the" with "the".
13935         * aarch64-tdep.c: Replace "the the" with "the".
13936
13937 2019-01-16  Keith Seitz  <keiths@redhat.com>
13938
13939         PR gdb/23773
13940         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
13941         <builder>: Rename to ..
13942         <m_builder>: ... this and make private.
13943         (dwarf2_cu::get_builder): New method.  Change all users of
13944         `builder' to use this method.
13945         (dwarf2_start_symtab): Move to ...
13946         (dwarf2_cu::start_symtab): ... here.  Update all callers
13947         (setup_type_unit_groups): Move to ...
13948         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
13949         callers.
13950         (dwarf2_cu::reset_builder): New method.
13951         (process_full_compunit, process_full_type_unit): Use
13952         dwarf2_cu::reset_builder.
13953         (follow_die_offset): Record the ancestor CU if it is different
13954         from the followed DIE's CU.
13955         (follow_die_sig_1): Likewise.
13956
13957 2019-01-15  Tom Tromey  <tom@tromey.com>
13958
13959         * remote.c (class remote_state) <buf>: Now a char_vector.
13960         <buf_size>: Remove.
13961         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
13962         parameter.
13963         (remote_target::getpkt_or_notif_sane_1)
13964         (remote_target::getpkt_sane)
13965         (remote_target::getpkt_or_notif_sane): Likewise.
13966         (class remote_target) <putpkt>: New overload.
13967         (remote_target::read_frame): Change type of "buf_p".  Remove
13968         sizeof_p parameter.
13969         (packet_ok): New overload.
13970         (packet_check_result): New overload.
13971         Update all uses.
13972
13973 2019-01-14  Tom Tromey  <tom@tromey.com>
13974
13975         * remote-notif.c (handle_notification, remote_notif_ack)
13976         (remote_notif_parse): Make "buf" const.
13977         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
13978         const.
13979         (remote_notif_parse, remote_notif_ack, handle_notification):
13980         Likewise.
13981         * remote.c (remote_notif_stop_parse): Make "buf" const.
13982         (remote_target::remote_parse_stop_reply): Make "buf" const.
13983         (remote_notif_stop_ack): Make "buf" const.
13984
13985 2019-01-14  Tom Tromey  <tom@tromey.com>
13986
13987         * remote.c (remote_console_output): Make parameter const.
13988
13989 2019-01-14  Tom Tromey  <tom@tromey.com>
13990
13991         * target-debug.h (target_debug_print_signals): Constify.
13992         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
13993         * procfs.c (procfs_target::pass_signals): Update.
13994         * linux-nat.c (linux_nat_target::pass_signals): Update.
13995         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
13996         * target-delegates.c: Rebuild.
13997         * remote.c (remote_target::program_signals): Update.
13998         (remote_target::pass_signals): Update.
13999         * target.c (target_pass_signals): Constify argument.
14000         (target_program_signals): Likewise.
14001         * target.h (struct target_ops) <pass_signals, program_signals>:
14002         Constify argument.
14003         (target_pass_signals, target_program_signals): Constify argument.
14004
14005 2019-01-14  Tom Tromey  <tom@tromey.com>
14006
14007         PR tui/28819:
14008         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
14009
14010 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
14011
14012         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
14013         field.
14014         * rs6000-tdep.c: Include reggroups.h.
14015         (IS_V_ALIAS_PSEUDOREG): Define.
14016         (rs6000_register_name): Return names for the "vX" aliases.
14017         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
14018         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
14019         aliases.  Call default_register_reggroup_p for all other
14020         pseudo-registers.
14021         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
14022         New functions.
14023         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
14024         Handle "vX" aliases.
14025         (v_alias_pseudo_register_collect): New function.
14026         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
14027         (rs6000_gdbarch_init): Initialize "vX" aliases as
14028         pseudo-registers.  Restore registration of
14029         rs6000_pseudo_register_reggroup_p with
14030         set_tdesc_pseudo_register_reggroup_p.
14031
14032 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
14033
14034         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
14035         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
14036         set_gdbarch_num_pseudo_regs.
14037
14038 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14039
14040         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
14041         Remove arg prefixname, add do_set and do_show.
14042         Add member functions set_list and show_list.
14043         * cli/cli-style.c (class cli_style_option): Update accordingly.
14044         (style_set_list): Move to file scope.
14045         (style_show_list): Likewise.
14046         (set_style): Call help_list.
14047         (show_style): Call cmd_show_list.
14048         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
14049         Update to use the new macro.
14050
14051 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
14052
14053         * ada-lang.c (_initialize_ada_language): Expand the help text
14054         for the "catch exception" command.
14055
14056 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14057
14058         * symtab.c (matching_obj_sections): Initialize obj,
14059         declare it closer to its usage.
14060
14061 2019-01-10  Tom Tromey  <tom@tromey.com>
14062
14063         * thread-iter.h (inf_threads_iterator): Use next_iterator.
14064         (basic_inf_threads_range): Remove.
14065         (inf_threads_range, inf_non_exited_threads_range)
14066         (safe_inf_threads_range): Use next_adapter.
14067
14068 2019-01-10  Keith Seitz  <keiths@redhat.com>
14069
14070         PR gdb/23712
14071         PR symtab/23010
14072         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
14073         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
14074
14075 2019-01-10  Keith Seitz  <keiths@redhat.com>
14076
14077         PR gdb/23712
14078         PR symtab/23010
14079         * dictionary.c (pending_to_vector): Remove.
14080         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
14081         Remove _1 suffix, replacing functions of the same name.  Update
14082         all callers.
14083         (dict_create_hashed, dict_create_hashed_expandable)
14084         (dict_create_linear, dict_create_linear_expandable, dict_free)
14085         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
14086         Make functions static.
14087
14088 2019-01-10  Keith Seitz  <keiths@redhat.com>
14089
14090         PR gdb/23712
14091         PR symtab/23010
14092         * dictionary.h (struct dictionary): Replace declaration with
14093         multidictionary.
14094         (dict_create_hashed, dict_create_hashed_expandable)
14095         (dict_create_linear, dict_create_linear_expandable)
14096         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
14097         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
14098         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
14099         taking multidictionary argument.
14100         [ALL_DICT_SYMBOLS]: Update for multidictionary.
14101         * block.h (struct block) <dict>: Change to multidictionary
14102         and rename `multidict'.
14103         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
14104         symmisc.c: Update all dictionary references to multidictionary.
14105
14106 2019-01-10  Keith Seitz  <keiths@redhat.com>
14107
14108         PR gdb/23712
14109         PR symtab/23010
14110         * dictionary.c: Include unordered_map.
14111         (pending_to_vector): New function.
14112         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
14113         Rewrite the non-"_1" functions to take vector instead
14114         of linked list.
14115         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
14116         "new" _1 versions of the same name.
14117         (multidictionary): Define.
14118         (std::hash<enum language): New definition.
14119         (collate_pending_symbols_by_language, mdict_create_hashed)
14120         (mdict_create_hashed_expandable, mdict_create_linear)
14121         (mdict_create_linear_expandable, mdict_free)
14122         (find_language_dictionary, create_new_language_dictionary)
14123         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
14124         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
14125         (mdict_size, mdict_empty): New functions.
14126         * dictionary.h (mdict_iterator): Define.
14127
14128 2019-01-10  Pedro Alves  <palves@redhat.com>
14129
14130         * breakpoint.c (read_uploaded_action)
14131         (create_tracepoint_from_upload): Adjust to use
14132         gdb::unique_xmalloc_ptr.
14133         * ctf.c (ctf_write_uploaded_tp):
14134         (SET_ARRAY_FIELD): Use emplace_back.
14135         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
14136         * tracefile-tfile.c (tfile_write_uploaded_tp):
14137         * tracepoint.c (parse_tracepoint_definition): Adjust to use
14138         gdb::unique_xmalloc_ptr.
14139         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
14140         at_string, cond_string, cmd_strings>: Replace char pointers
14141         with gdb::unique_xmalloc_ptr.
14142
14143 2019-01-10  Pedro Alves  <palves@redhat.com>
14144
14145         * solib-target.c (library_list_start_library): Don't xstrdup name.
14146
14147 2019-01-10  Pedro Alves  <palves@redhat.com>
14148
14149         * mdebugread.c (parse_partial_symbols): Use
14150         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
14151
14152 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
14153
14154         * linux-fork.c (scoped_switch_fork_info)
14155         <~scoped_switch_fork_info>: Fix incorrect variable name.
14156
14157 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
14158
14159         * linux-fork.c (scoped_switch_fork_info)
14160         <scoped_switch_fork_info>: Make explicit.
14161         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
14162
14163 2019-01-10  Tom Tromey  <tom@tromey.com>
14164
14165         * objfiles.h (objfile::reset_psymtabs): Update.
14166         * objfiles.c (objfile::objfile): Update.
14167         * psymtab.h (psymtab_storage::obstack): Update.
14168         (psymtab_storage::m_obstack): Use gdb::optional.
14169         (class psymtab_storage): Update comment.  Remove objfile
14170         parameter.
14171         * psymtab.c (psymtab_storage::psymtab_storage): Update.
14172
14173 2019-01-10  Tom Tromey  <tom@tromey.com>
14174
14175         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
14176         <free_psymtabs>: Now private.
14177         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
14178         (allocate_psymtab): Use new method.
14179
14180 2019-01-10  Tom Tromey  <tom@tromey.com>
14181
14182         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
14183         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
14184         * mdebugread.c (parse_partial_symbols): Use
14185         allocate_dependencies.
14186         * dwarf2read.c (dwarf2_create_include_psymtab): Use
14187         allocate_dependencies.
14188         (process_psymtab_comp_unit_reader)
14189         (build_type_psymtab_dependencies): Likewise.
14190         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
14191
14192 2019-01-10  Tom Tromey  <tom@tromey.com>
14193
14194         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
14195         PSYMBOL_SET_LANGUAGE.
14196         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
14197
14198 2019-01-10  Tom Tromey  <tom@tromey.com>
14199
14200         * psymtab.h (psymtab_storage::obstack): New method.
14201         <m_obstack>: Rename from obstack; now private.
14202         * psymtab.c (psymtab_storage): Update.
14203         * dwarf2read.c (create_addrmap_from_index)
14204         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
14205         Update.
14206
14207 2019-01-10  Tom Tromey  <tom@tromey.com>
14208
14209         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
14210         * objfiles.h (objfile::reset_psymtabs): New method.
14211
14212 2019-01-10  Tom Tromey  <tom@tromey.com>
14213
14214         * symmisc.c (print_symbol_bcache_statistics): Update.
14215         (print_objfile_statistics): Update.
14216         * symfile.c (reread_symbols): Update.
14217         * psymtab.h (class psymtab_storage): New.
14218         * psymtab.c (psymtab_storage): New constructor.
14219         (~psymtab_storage): New destructor.
14220         (require_partial_symbols): Update.
14221         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
14222         (find_pc_sect_psymtab, find_pc_sect_psymbol)
14223         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
14224         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
14225         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
14226         (start_psymtab_common, end_psymtab_common)
14227         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
14228         (allocate_psymtab): Update.
14229         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
14230         Update.
14231         (dump_psymtab_addrmap, maintenance_print_psymbols)
14232         (maintenance_check_psymtabs): Update.
14233         (class objfile_psymtabs): Move to objfiles.h.
14234         * psympriv.h (discard_psymtab): Now inline.
14235         (psymtab_discarder::psymtab_discarder): Update.
14236         (psymtab_discarder::~psymtab_discarder): Update.
14237         (ALL_OBJFILE_PSYMTABS): Rewrite.
14238         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
14239         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
14240         Remove fields.
14241         <partial_symtabs>: New field.
14242         (class objfile_psymtabs): Move from psymtab.h.  Update.
14243         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
14244         psymbol_cache.
14245         (objfile::~objfile): Don't destroy psymbol_cache.
14246         * mdebugread.c (parse_partial_symbols): Update.
14247         * dwarf2read.c (create_addrmap_from_index)
14248         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
14249         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
14250         (add_partial_subprogram, dwarf2_ranges_read): Update.
14251         * dwarf-index-write.c (write_address_map)
14252         (write_one_signatured_type, recursively_write_psymbols)
14253         (class debug_names, class debug_names, write_psymtabs_to_index):
14254         Update.
14255
14256 2019-01-10  Tom Tromey  <tom@tromey.com>
14257
14258         * symtab.h (SYMBOL_SET_NAMES): Update.
14259         (symbol_set_names): Update.
14260         (MSYMBOL_SET_NAMES): Update.
14261         * symtab.c (symbol_set_names): Change argument to be an
14262         objfile_per_bfd_storage.
14263         * psymtab.c (add_psymbol_to_bcache): Update.
14264         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
14265
14266 2019-01-10  Tom Tromey  <tom@tromey.com>
14267
14268         * symtab.c (create_demangled_names_hash): Change argument to be an
14269         objfile_per_bfd_storage.
14270         (symbol_set_names): Update.
14271
14272 2019-01-10  Tom Tromey  <tom@tromey.com>
14273
14274         * xcoffread.c (xcoff_initial_scan): Unconditionally call
14275         init_psymbol_list.
14276         * psymtab.c (init_psymbol_list): Do nothing if already called.
14277         * psympriv.h (init_psymbol_list): Add comment.
14278         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
14279         init_psymbol_list.
14280         * dbxread.c (dbx_symfile_read): Unconditionally call
14281         init_psymbol_list.
14282
14283 2019-01-10  Tom Tromey  <tom@tromey.com>
14284
14285         * xcoffread.c (scan_xcoff_symtab): Update.
14286         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
14287         "where".
14288         * mdebugread.c (parse_partial_symbols)
14289         (handle_psymbol_enumerators): Update.
14290         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
14291         * dbxread.c (read_dbx_symtab): Update.
14292         * psympriv.h (psymbol_placement): New enum.
14293         (add_psymbol_to_list): Update.
14294
14295 2019-01-10  Tom Tromey  <tom@tromey.com>
14296
14297         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
14298         static_psymbols parameters.
14299         (scan_xcoff_symtab): Update.
14300         * psymtab.c (start_psymtab_common): Remove global_psymbols and
14301         static_psymbols parameters.
14302         * psympriv.h (start_psymtab_common): Update.
14303         * mdebugread.c (parse_partial_symbols): Update.
14304         * dwarf2read.c (create_partial_symtab): Update.
14305         * dbxread.c (read_dbx_symtab): Update.
14306         (start_psymtab): Remove global_psymbols and static_psymbols
14307         parameters.
14308
14309 2019-01-10  Tom Tromey  <tom@tromey.com>
14310
14311         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
14312         * psymtab.c (allocate_psymtab): Add comment.
14313         * psympriv.h (allocate_psymtab): Add comment.
14314         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
14315         initializations.
14316         * dbxread.c (dbx_end_psymtab): Remove some initializations.
14317
14318 2019-01-10  Tom Tromey  <tom@tromey.com>
14319
14320         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
14321         Don't declare.
14322         * mipsread.c: Include mdebugread.h.
14323         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
14324         Declare.
14325         * elfread.c: Include mdebugread.h.
14326
14327 2019-01-09  Tom Tromey  <tom@tromey.com>
14328
14329         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
14330         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
14331         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
14332         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
14333         (psym_lookup_symbol, psym_find_last_source_symtab)
14334         (psym_forget_cached_source_info, psym_print_stats)
14335         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
14336         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
14337         (psym_map_matching_symbols, psym_expand_symtabs_matching)
14338         (psym_find_compunit_symtab_by_address)
14339         (maintenance_print_psymbols, maintenance_info_psymtabs)
14340         (maintenance_check_psymtabs): Use ranged for.
14341         * psymtab.h (class objfile_psymtabs): New.
14342         (require_partial_symbols): Return objfile_psymtabs.
14343         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
14344
14345 2019-01-09  Tom Tromey  <tom@tromey.com>
14346
14347         * symfile.c (overlay_invalidate_all, find_pc_overlay)
14348         (find_pc_mapped_section, list_overlays_command)
14349         (map_overlay_command, unmap_overlay_command)
14350         (simple_overlay_update): Use all_objfiles.
14351         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
14352         * printcmd.c (info_symbol_command): Use all_objfiles.
14353         * objfiles.h (ALL_OBJSECTIONS): Remove.
14354         * maint.c (maintenance_translate_address): Use all_objfiles.
14355         * gcore.c (gcore_create_callback): Use all_objfiles.
14356         (objfile_find_memory_regions): Likewise.
14357
14358 2019-01-09  Tom Tromey  <tom@tromey.com>
14359
14360         * symtab.c (find_line_symtab, info_sources_command)
14361         (make_source_files_completion_list): Use objfile_compunits.
14362         * source.c (select_source_symtab): Use objfile_compunits.
14363         * objfiles.h (struct objfile): Update comment.
14364         (ALL_OBJFILES): Remove.
14365         (ALL_FILETABS): Remove.
14366         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
14367         objfile_compunits.
14368
14369 2019-01-09  Tom Tromey  <tom@tromey.com>
14370
14371         * symmisc.c (print_objfile_statistics, dump_objfile)
14372         (maintenance_print_symbols): Use compunit_filetabs.
14373         * source.c (forget_cached_source_info_for_objfile): Use
14374         compunit_filetabs.
14375         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
14376         (ALL_FILETABS): Use compunit_filetabs.
14377         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
14378         * coffread.c (coff_symtab_read): Use compunit_filetabs.
14379
14380 2019-01-09  Tom Tromey  <tom@tromey.com>
14381
14382         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
14383         (compunit_filetabs): New.
14384         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
14385         compunit_filetabs.
14386         (info_sources_command, make_source_files_completion_list): Remove
14387         declaration.
14388         * symmisc.c (print_objfile_statistics, dump_objfile)
14389         (maintenance_print_symbols): Remove declaration.
14390         (maintenance_info_symtabs): Use compunit_filetabs.
14391         (maintenance_info_line_tables): Likewise.
14392         * source.c (select_source_symtab): Change local variable name.
14393         (forget_cached_source_info_for_objfile): Remove declaration.
14394         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
14395         * objfiles.c (objfile_relocate1): Remove declaration.
14396         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
14397         declaration.
14398         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
14399         * coffread.c (coff_symtab_read): Remove declaration.
14400         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
14401         compunit_filetabs.
14402
14403 2019-01-09  Tom Tromey  <tom@tromey.com>
14404
14405         * symtab.c (lookup_objfile_from_block)
14406         (find_pc_sect_compunit_symtab, search_symbols)
14407         (default_collect_symbol_completion_matches_break_on): Use
14408         objfile_compunits.
14409         * objfiles.h (ALL_COMPUNITS): Remove.
14410         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
14411         * cp-support.c (add_symbol_overload_list_qualified): Use
14412         objfile_compunits.
14413         * ada-lang.c (ada_collect_symbol_completion_matches)
14414         (ada_add_global_exceptions): Use objfile_compunits.
14415
14416 2019-01-09  Tom Tromey  <tom@tromey.com>
14417
14418         * source.c (select_source_symtab)
14419         (forget_cached_source_info_for_objfile): Remove declaration.
14420         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
14421         declaration.
14422         * maint.c (count_symtabs_and_blocks): Remove declaration.
14423         * cp-support.c (add_symbol_overload_list_qualified): Remove
14424         declaration.
14425         * coffread.c (coff_symtab_read): Remove declaration.
14426         * symtab.c (lookup_symbol_in_objfile_symtabs)
14427         (basic_lookup_transparent_type_1): Use objfile_compunits.
14428         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
14429         (info_sources_command, search_symbols)
14430         (default_collect_symbol_completion_matches_break_on)
14431         (make_source_files_completion_list): Remove declaration.
14432         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
14433         (ada_collect_symbol_completion_matches)
14434         (ada_add_global_exceptions): Remove declaration.
14435         * linespec.c (iterate_over_all_matching_symtabs): Use
14436         objfile_compunits.
14437         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
14438         (class objfile_compunits): New.
14439         (ALL_COMPUNITS): Use objfile_compunits.
14440         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
14441         (maintenance_check_symtabs, maintenance_info_line_tables): Use
14442         objfile_compunits.
14443         * objfiles.c (objfile_relocate1): Use objfile_compunits.
14444
14445 2019-01-09  Tom Tromey  <tom@tromey.com>
14446
14447         * symtab.c (search_symbols)
14448         (default_collect_symbol_completion_matches_break_on): Use
14449         objfile_msymbols.
14450         * ada-lang.c (ada_lookup_simple_minsym)
14451         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
14452         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
14453         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
14454         objfile_msymbols.
14455         * coffread.c (coff_symfile_read): Use objfile_msymbols.
14456         * symmisc.c (dump_msymbols): Use objfile_msymbols.
14457         * objc-lang.c (find_methods): Use objfile_msymbols.
14458         (info_selectors_command, info_classes_command): Likewise.
14459         * stabsread.c (scan_file_globals): Use objfile_msymbols.
14460         * objfiles.h (class objfile_msymbols): New.
14461         (ALL_OBJFILE_MSYMBOLS): Remove.
14462         (ALL_MSYMBOLS): Remove.
14463
14464 2019-01-09  Tom Tromey  <tom@tromey.com>
14465
14466         * common/next-iterator.h (next_adapter): Add Iterator template
14467         parameter.
14468         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
14469         (class all_objfiles_safe): New.
14470         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
14471         * objfiles.c (put_objfile_before): Update comment.
14472         (add_separate_debug_objfile): Likewise.
14473         (free_all_objfiles): Use all_objfiles_safe.
14474         (objfile_purge_solibs): Likewise.
14475
14476 2019-01-09  Tom Tromey  <tom@tromey.com>
14477
14478         * symtab.c (iterate_over_symtabs, matching_obj_sections)
14479         (expand_symtab_containing_pc, lookup_static_symbol)
14480         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
14481         (find_symbol_at_address, find_line_symtab, find_main_name): Use
14482         all_objfiles.
14483         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
14484         * breakpoint.c (create_overlay_event_breakpoint)
14485         (create_longjmp_master_breakpoint)
14486         (create_std_terminate_master_breakpoint)
14487         (create_exception_master_breakpoint): Use all_objfiles.
14488         * linux-thread-db.c (try_thread_db_load_from_pdir)
14489         (has_libpthread): Use all_objfiles.
14490         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
14491         * linespec.c (iterate_over_all_matching_symtabs)
14492         (search_minsyms_for_name): Use all_objfiles.
14493         * maint.c (maintenance_info_sections): Use all_objfiles.
14494         * main.c (captured_main_1): Use all_objfiles.
14495         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
14496         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
14497         * guile/scm-pretty-print.c
14498         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
14499         * solib-spu.c (append_ocl_sos): Use all_objfiles.
14500         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
14501         (maintenance_print_msymbols): Use all_objfiles.
14502         * source.c (select_source_symtab): Use all_objfiles.
14503         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
14504         * symfile.c (remove_symbol_file_command)
14505         (expand_symtabs_matching, map_symbol_filenames): Use
14506         all_objfiles.
14507         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
14508         all_objfiles.
14509         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
14510         * objc-lang.c (find_methods): Use all_objfiles.
14511         * objfiles.c (have_partial_symbols, have_full_symbols)
14512         (have_minimal_symbols, qsort_cmp)
14513         (default_iterate_over_objfiles_in_search_order): Use
14514         all_objfiles.
14515         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
14516         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
14517         (maintenance_check_psymtabs): Use all_objfiles.
14518         (ALL_PSYMTABS): Remove.
14519         * compile/compile-object-run.c (do_module_cleanup): Use
14520         all_objfiles.
14521         * blockframe.c (find_pc_partial_function): Use all_objfiles.
14522         * cp-support.c (add_symbol_overload_list_qualified): Use
14523         all_objfiles.
14524         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
14525         Use all_objfiles.
14526         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
14527         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
14528         all_objfiles.
14529         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
14530         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
14531         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
14532         Uses all_objfiles.
14533         * solib.c (solib_read_symbols): Use all_objfiles
14534
14535 2019-01-09  Tom Tromey  <tom@tromey.com>
14536
14537         * probe.c (parse_probes_in_pspace): Use all_objfiles.
14538         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
14539         all_objfiles.
14540         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
14541         * symmisc.c (print_symbol_bcache_statistics)
14542         (print_objfile_statistics, maintenance_print_objfiles)
14543         (maintenance_info_symtabs, maintenance_check_symtabs)
14544         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
14545         all_objfiles.
14546         * source.c (forget_cached_source_info): Use all_objfiles.
14547         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
14548         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
14549         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
14550         * objfiles.c (update_section_map): Use all_objfiles.
14551         (shared_objfile_contains_address_p): Likewise.
14552         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
14553         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
14554
14555 2019-01-09  Tom Tromey  <tom@tromey.com>
14556
14557         * common/next-iterator.h: New file.
14558         * objfiles.h (class all_objfiles): New.
14559         (struct objfile_iterator): New.
14560
14561 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14562
14563         * NEWS: Move the description of the changed "frame", "select-frame",
14564          and "info frame" commands to the Changed commands section.
14565
14566 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
14567
14568         * gdbtypes.c (check_stub_method_group): Remove handling of old
14569         mangling schemes.
14570         * linespec.c (find_methods): Likewise.
14571         * stabsread.c (read_member_functions): Likewise.
14572         * valops.c (search_struct_method): Likewise.
14573         (value_struct_elt_for_reference): Likewise.
14574         * NEWS: Mention this change.
14575
14576 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
14577
14578         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
14579         print_source_lines.
14580         * source.c (print_source_lines_base): Update line number check.
14581         (print_source_lines): New function.
14582         (source_lines_range::source_lines_range): New function.
14583         * source.h (class source_lines_range): New class.
14584         (print_source_lines): New declaration.
14585
14586 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14587
14588         * linespec.c (linespec_state_destructor): Free self->canonical_names.
14589
14590 2019-01-08  Tom Tromey  <tom@tromey.com>
14591             Simon Marchi  <simon.marchi@ericsson.com>
14592
14593         PR gdb/24060
14594         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
14595         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
14596         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
14597         * f-exp.y (DOLLAR_VARIABLE): Likewise.
14598         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
14599         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
14600
14601 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
14602
14603         * source.c (select_source_symtab): Move header comment to
14604         declaration in source.h.
14605         (forget_cached_source_info_for_objfile): Likewise.
14606         (forget_cached_source_info): Likewise.
14607         (identify_source_line): Likewise.
14608         * source.h (identify_source_line): Move declaration from symtab.h
14609         and add comment from source.c
14610         (print_source_lines): Likewise.
14611         (forget_cached_source_info_for_objfile): Likewise.
14612         (forget_cached_source_info): Likewise.
14613         (select_source_symtab): Likewise.
14614         (enum print_source_lines_flag): Move definition from symtab.h.
14615         * symtab.h (identify_source_line): Move declaration to source.h.
14616         (print_source_lines): Likewise.
14617         (forget_cached_source_info_for_objfile): Likewise.
14618         (forget_cached_source_info): Likewise.
14619         (select_source_symtab): Likewise.
14620         (enum print_source_lines_flag): Move definition to source.h.
14621         * tui/tui-hooks.c: Add 'source.h' include.
14622
14623 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
14624
14625         * source.c (print_source_lines_base): Handle requests to print
14626         reverse line number sequences, and guard against empty lines
14627         string.
14628
14629 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
14630
14631         * source.c (print_source_lines_base): Fix skip of '\r' if next
14632         character is '\n'.
14633
14634 2019-01-06  Tom Tromey  <tom@tromey.com>
14635
14636         * c-exp.y (struct c_parse_state) <macro_original_text,
14637         expansion_obstack>: New member.
14638         (macro_original_text, expansion_obstack): Remove globals.
14639         (scan_macro_expansion, scanning_macro_expansion)
14640         (finished_macro_expansion): Update.
14641         (scan_macro_cleanup): Remove.
14642         (yylex, c_parse): Update.
14643
14644 2019-01-06  Tom Tromey  <tom@tromey.com>
14645
14646         * c-exp.y (struct c_parse_state) <strings>: New member.
14647         (operator_stoken): Update.
14648
14649 2019-01-06  Tom Tromey  <tom@tromey.com>
14650
14651         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
14652         (union type_stack_elt) <typelist_val>: Now a pointer to
14653         std::vector.
14654         (type_stack_cleanup): Don't declare.
14655         (push_typelist): Update.
14656         * parse.c (pop_typelist): Return a std::vector.
14657         (push_typelist): Take a std::vector.
14658         (follow_types): Update.  Do not free args.
14659         (type_stack_cleanup): Remove.
14660         * c-exp.y (struct c_parse_state): New.
14661         (cpstate): New global.
14662         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
14663         (nonempty_typelist): Update.
14664         (func_mod): Create a new vector.
14665         (c_parse): Create a c_parse_state.
14666         (check_parameter_typelist): Do not delete params.
14667         (function_method): Update.  Do not delete type_list.
14668
14669 2019-01-06  Tom Tromey  <tom@tromey.com>
14670
14671         PR gdb/28155:
14672         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
14673         check_typedef.
14674         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
14675         (print_return_value): Likewise.
14676
14677 2019-01-05  Tom Tromey  <tom@tromey.com>
14678
14679         * contrib/cleanup_check.py: Remove.
14680         * contrib/gcc-with-excheck: Remove.
14681         * contrib/exsummary.py: Remove.
14682         * contrib/excheck.py: Remove.
14683
14684 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
14685
14686         * thread.c (delete_thread_1): Add gdb_assert that THR is not
14687         NULL. Initialize tpprev to NULL instead of assigning it
14688         to NULL on the next statement.
14689         * windows-nat.c (windows_delete_thread): Remove check for
14690         main_thread_id before printing thread exit notifications.
14691         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
14692         Remove thread ID check against main_thread_id.
14693         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
14694         windows_delete_thread.
14695         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
14696
14697 2019-01-04  Tom Tromey  <tom@tromey.com>
14698
14699         * compile/compile.c (_initialize_compile): Use upper case for
14700         metasyntactic variables.
14701         * symmisc.c (_initialize_symmisc): Use upper case for
14702         metasyntactic variables.
14703         * psymtab.c (_initialize_psymtab): Use upper case for
14704         metasyntactic variables.
14705         * demangle.c (demangle_command): Use upper case for metasyntactic
14706         variables.
14707         (_initialize_demangler): Likewise.
14708         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
14709         variables.
14710
14711 2019-01-03  Tom Tromey  <tom@tromey.com>
14712
14713         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
14714
14715 2019-01-03  Tom Tromey  <tom@tromey.com>
14716
14717         * python/py-symtab.c (salpy_str): Update.
14718         (struct salpy_sal_object) <symtab>: Now a PyObject.
14719         (salpy_dealloc): Update.
14720         (del_objfile_sal): Use gdbpy_ref.
14721
14722 2019-01-03  Tom Tromey  <tom@tromey.com>
14723
14724         * python/py-type.c (convert_field): Use new_reference.  Return
14725         gdbpy_ref.
14726         (make_fielditem): Return gdbpy_ref.
14727         (typy_fields): Update.
14728         (typy_getitem): Update.
14729         (field_name): Return gdbpy_ref.  Use new_reference.
14730         (typy_iterator_iternext): Update.
14731
14732 2019-01-03  Tom Tromey  <tom@tromey.com>
14733
14734         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
14735
14736 2019-01-03  Tom Tromey  <tom@tromey.com>
14737
14738         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
14739         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
14740         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
14741         (pspy_set_frame_filters, pspy_set_frame_unwinders)
14742         (pspy_set_type_printers): Likewise.
14743         * python/py-function.c (fnpy_init): Use gdbpy_ref.
14744         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
14745         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
14746         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
14747         (objfpy_set_type_printers): Likewise.
14748
14749 2019-01-03  Tom Tromey  <tom@tromey.com>
14750
14751         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
14752         (gdbpy_print_stack): Use gdbpy_err_fetch.
14753         * python/python-internal.h (class gdbpy_err_fetch): New class.
14754         (class gdbpy_enter) <m_error_type, m_error_value,
14755         m_error_traceback>: Remove.
14756         <m_error>: New member.
14757         (gdbpy_exception_to_string): Don't declare.
14758         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
14759         * python/py-value.c (convert_value_from_python): Use
14760         gdbpy_err_fetch.
14761         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
14762         gdbpy_exception_to_string.
14763         (gdbpy_handle_exception): Use gdbpy_err_fetch.
14764         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
14765         gdbpy_err_fetch.
14766
14767 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
14768
14769         * linux-nat.c (delete_lwp_cleanup): Delete.
14770         (struct lwp_deleter): New struct.
14771         (lwp_info_up): New typedef.
14772         (linux_nat_target::follow_fork): Delete cleanup, and make use of
14773         lwp_info_up.
14774
14775 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
14776
14777         * linux-fork.c (class scoped_switch_fork_info): New class.
14778         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
14779
14780 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
14781
14782         * valops.c (find_overload_match): Remove use of null_cleanup, and
14783         calls to do_cleanups.
14784
14785 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
14786
14787         * compile/compile-cplus-types.c
14788         (compile_cplus_instance::decl_name): Handle changes to
14789         cp_func_name.
14790         * cp-support.c (cp_func_name): Update header comment, update
14791         return type.
14792         * cp-support.h (cp_func_name): Update return type in declaration.
14793         * valops.c (find_overload_match): Move temp_func local to top
14794         level of function and change its type.  Use temp_func to hold and
14795         delete temporary string obtained from cp_func_name.
14796
14797 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
14798
14799         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
14800         gdb::char_vector, remove cleanup, and update uses of `msg`.
14801
14802 2019-01-03  Jim Wilson  <jimw@sifive.com>
14803
14804         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
14805
14806 2019-01-02  Tom Tromey  <tom@tromey.com>
14807
14808         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
14809         (tdesc_parse_xml): Remove cleanups.
14810         * target-descriptions.h (make_cleanup_free_target_description):
14811         Don't declare.
14812         (target_desc_deleter): New struct.
14813         (target_desc_up): New typedef.
14814         * target-descriptions.c (target_desc_deleter::operator()): Rename
14815         from free_target_description.
14816         (make_cleanup_free_target_description): Remove.
14817
14818 2019-01-02  Tom Tromey  <tom@tromey.com>
14819
14820         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
14821         constructor, destructor.
14822         (linespec_parser): Remove typedef.
14823         (~linespec_parser): Rename from linespec_parser_delete.
14824         (linespec_lex_to_end, linespec_complete_label)
14825         (linespec_complete): Update.
14826         (decode_line_full): Remove cleanups.
14827         (decode_line_1): Update.
14828
14829 2019-01-02  Tom Tromey  <tom@tromey.com>
14830
14831         * python/python-internal.h (inferior_to_inferior_object): Change
14832         return type.
14833         * python/py-exitedevent.c (create_exited_event_object): Update.
14834         * python/py-inferior.c (inferior_to_inferior_object): Return
14835         gdbpy_ref.
14836         (python_new_inferior, python_inferior_deleted)
14837         (thread_to_thread_object, delete_thread_object)
14838         (build_inferior_list, gdbpy_selected_inferior): Update.
14839         * python/py-infthread.c (create_thread_object): Update.  Also fail
14840         if inferior_to_inferior_object fails.
14841
14842 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
14843
14844         * inferior.h (class inferior) <displaced_step_state>: New field.
14845         * infrun.h (struct displaced_step_state): Move here from
14846         infrun.c.  Initialize fields, add constructor.
14847         <inf>: Remove field.
14848         <reset>: New method.
14849         * infrun.c (struct displaced_step_inferior_state): Move to
14850         infrun.h.
14851         (displaced_step_inferior_states): Remove.
14852         (get_displaced_stepping_state): Adust.
14853         (displaced_step_in_progress_any_inferior): Adjust.
14854         (displaced_step_in_progress_thread): Adjust.
14855         (displaced_step_in_progress): Adjust.
14856         (add_displaced_stepping_state): Remove.
14857         (get_displaced_step_closure_by_addr): Adjust.
14858         (remove_displaced_stepping_state): Remove.
14859         (infrun_inferior_exit): Call displaced_step_state.reset.
14860         (use_displaced_stepping): Don't check for NULL.
14861         (displaced_step_prepare_throw): Call
14862         get_displaced_stepping_state.
14863         (displaced_step_fixup): Don't check for NULL.
14864         (prepare_for_detach): Don't check for NULL.
14865
14866 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14867
14868         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
14869          in case of call that did not complete.
14870
14871 2019-01-02  Andrey Utkin  <autkin@undo.io>
14872
14873         * symfile.c (find_separate_debug_file): Fix search of debug files for
14874         remote debuggee.
14875
14876 2019-01-02  Tom Tromey  <tom@tromey.com>
14877
14878         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
14879         indentation.
14880         * python/py-frame.c (frapy_older): Remove cast.
14881         (frapy_newer): Likewise.
14882         * python/py-breakpoint.c (local_setattro): Remove cast.
14883         * python/py-arch.c (archpy_name): Remove local variable.
14884         * python/py-type.c (gdbpy_lookup_type): Remove cast.
14885
14886 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
14887
14888         * unittests/basic_string_view/element_access/char/empty.cc:
14889         Fix year range in copyright header.
14890
14891 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
14892
14893         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
14894         Delete.
14895         <operator==>: Update with for removed field.
14896         <hash>: Likewise.
14897         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
14898         <isa_features>: ...this.
14899         <abi_features>: New field.
14900         (riscv_isa_flen): Update comment.
14901         (riscv_abi_xlen): New declaration.
14902         (riscv_abi_flen): New declaration.
14903         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
14904         isa_features.
14905         (riscv_abi_xlen): New function.
14906         (riscv_isa_flen): Update to get answer from isa_features.
14907         (riscv_abi_flen): New function.
14908         (riscv_has_fp_abi): Update to get answer from abi_features.
14909         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
14910         xlen and flen.
14911         (riscv_call_info) <xlen, flen>: Update comment.
14912         (riscv_call_arg_struct): Remove invalid assertions
14913         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
14914         is removed.
14915         (riscv_gdbarch_init): Gather isa features and abi features
14916         separately, ensure both match on the gdbarch when reusing an old
14917         gdbarch.  Relax an error check to allow 32-bit abi float to run on
14918         a target with 64-bit float hardware.
14919
14920 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14921
14922         * source.c (search_command_helper): Stop reverse search
14923         when line 1 has been searched.
14924
14925 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14926
14927         * record-full.c (record_full_base_target::close): Rewrite
14928         record_full_core_buf_list free logic.
14929
14930 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14931
14932         * break-catch-syscall.c (print_one_catch_syscall): xfree
14933         the last text.
14934
14935 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
14936
14937         * top.c (print_gdb_version): Update Copyright year in version
14938         message.
14939
14940 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
14941
14942         Update copyright year range in all GDB files.
14943
14944 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
14945
14946         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
14947
14948 For older changes see ChangeLog-2018.
14949 \f
14950 Local Variables:
14951 mode: change-log
14952 left-margin: 8
14953 fill-column: 74
14954 version-control: never
14955 coding: utf-8
14956 End:
14957