gdb/ChangeLog

   1 2019-11-15  Christian Biesinger  <cbiesinger@google.com>
   2
   3         * maint.c (scoped_command_stats::print_time): Use localtime_r
   4         instead of localtime (provided through gnulib if necessary).
   5         * nat/linux-osdata.c (time_from_time_t): Use ctime_r instead
   6         of ctime.
   7
   8 2019-11-15  Christian Biesinger  <cbiesinger@google.com>
   9
  10         * gdbsupport/common-defs.h: Include time.h before pathmax.h to
  11         avoid compile errors.
  12
  13 2019-11-15  Christian Biesinger  <cbiesinger@google.com>
  14
  15         * config.in: Regenerate.
  16         * configure: Regenerate.
  17         * gdbsupport/common.m4: No longer check for strerror_r.
  18         * gdbsupport/posix-strerror.c (safe_strerror): Always call the
  19         POSIX version of strerror_r, now that gnulib provides it if
  20         necessary.
  21
  22 2019-11-14  Christian Biesinger  <cbiesinger@google.com>
  23
  24         * README (`configure' options): Update.
  25
  26 2019-11-14  Tom Tromey  <tromey@adacore.com>
  27
  28         * eval.c (evaluate_subexp_standard) <BINOP_ASSIGN>: Do not pass an
  29         expected type for the RHS if the LHS is a convenience variable.
  30
  31 2019-11-14  Simon Marchi  <simon.marchi@polymtl.ca>
  32
  33         * unittests/vec-utils-selftests.c (unordered_remove_tests::obj):
  34         Provide explicit default and copy constructor.
  35
  36 2019-11-14  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
  37
  38         * python/py-finishbreakpoint.c (gdbpy_breakpoint_created):
  39         only call Py_INCREF (newbp) in the bppy_pending_object case.
  40
  41 2019-11-13  Tom Tromey  <tromey@adacore.com>
  42
  43         PR build/25182:
  44         * psympriv.h (partial_symbol): Remove static assert.
  45         * symtab.h (general_symbol_info, symbol): Remove static assert.
  46
  47 2019-11-12  Andrew Burgess  <andrew.burgess@embecosm.com>
  48
  49         * gdbsupport/format.c (format_pieces::format_pieces): Support
  50         printf 'z' size modifier.
  51         * gdbsupport/format.h (enum argclass): Add size_t_arg.
  52         * printcmd.c (ui_printf):  Handle size_t_arg.
  53         * ui-out.c (ui_out::vmessage): Likewise.
  54         * unittests/format_pieces-selftests.c (test_format_int_sizes): New
  55         function.
  56         (run_tests): Call test_format_int_sizes.
  57
  58 2019-11-12  Christian Biesinger  <cbiesinger@google.com>
  59
  60         * ada-exp.y (write_ambiguous_var): Update.
  61         * buildsym.c (add_symbol_to_list): Update.
  62         * dwarf2read.c (read_variable): Update.
  63         (new_symbol): Update.
  64         * jit.c (finalize_symtab): Update.
  65         * language.c (language_alloc_type_symbol): Update.
  66         * symtab.c (fixup_symbol_section): Update.
  67         (initialize_objfile_symbol_1): Move code to...
  68         (initialize_objfile_symbol): ...here. Remove now-unnecessary memset.
  69         (allocate_symbol): Update.
  70         (allocate_template_symbol): Update.
  71         (get_symbol_address): Update.
  72         * symtab.h (struct symbol): Inherit from general_symbol_info instead
  73         of having as a field, and add a constructor.
  74         (SYMBOL_VALUE): Update.
  75         (SYMBOL_VALUE_ADDRESS): Update.
  76         (SET_SYMBOL_VALUE_ADDRESS): Update.
  77         (SYMBOL_VALUE_BYTES): Update.
  78         (SYMBOL_VALUE_COMMON_BLOCK): Update.
  79         (SYMBOL_BLOCK_VALUE): Update.
  80         (SYMBOL_VALUE_CHAIN): Update.
  81         (SYMBOL_LANGUAGE): Update.
  82         (SYMBOL_SECTION): Update.
  83         (SYMBOL_OBJ_SECTION): Update.
  84         (SYMBOL_SET_LANGUAGE): Update.
  85         (SYMBOL_SET_LINKAGE_NAME): Update.
  86         (SYMBOL_SET_NAMES): Update.
  87         (SYMBOL_NATURAL_NAME): Update.
  88         (SYMBOL_LINKAGE_NAME): Update.
  89         (SYMBOL_DEMANGLED_NAME): Update.
  90         (SYMBOL_SEARCH_NAME): Update.
  91         (SYMBOL_MATCHES_SEARCH_NAME): Update.
  92         (struct symbol): Update.
  93         (struct template_symbol): Update.
  94         (struct rust_vtable_symbol): Update.
  95         * xcoffread.c (SYMBOL_DUP): Update.
  96
  97 2019-11-12  Tom Tromey  <tom@tromey.com>
  98
  99         * tui/tui-layout.c (show_layout): Set current_layout.
 100         (show_source_disasm_command, show_data)
 101         (show_source_or_disasm_and_command): Don't set current_layout.
 102
 103 2019-11-12  Tom Tromey  <tom@tromey.com>
 104
 105         * tui/tui-layout.c (_initialize_tui_layout): Move to end.
 106
 107 2019-11-12  Tom Tromey  <tom@tromey.com>
 108
 109         * tui/tui-win.c (resize_message): New global.
 110         (show_tui_resize_message): New function.
 111         (tui_async_resize_screen): Print message if requested.
 112         (_initialize_tui_win): Add tui-resize-message setting.
 113         * NEWS: Add entry for new commands.
 114
 115 2019-11-11  Tom Tromey  <tom@tromey.com>
 116
 117         * tui/tui.c (tui_initialize_readline): Add new bindable readline
 118         functions.
 119
 120 2019-11-11  Christian Biesinger  <cbiesinger@google.com>
 121
 122         * nat/linux-osdata.c (user_from_uid): Use getpwuid_r.
 123
 124 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
 125
 126         * python/py-symbol.c (gdbpy_lookup_static_symbols): New
 127         function.
 128         * python/python-internal.h (gdbpy_lookup_static_symbols):
 129         Declare new function.
 130         * python/python.c (python_GdbMethods): Add
 131         gdb.lookup_static_symbols method.
 132         * NEWS: Mention gdb.lookup_static_symbols.
 133
 134 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
 135
 136         * python/py-symbol.c (gdbpy_lookup_static_symbol): Lookup in
 137         static block of current object file first.  Also fix typo in
 138         header comment.
 139
 140 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
 141
 142         * stack.c (set_last_displayed_sal): Delete.
 143         (last_displayed_sal_valid): Delete.
 144         (last_displayed_pspace): Delete.
 145         (last_displayed_addr): Delete.
 146         (last_displayed_symtab): Delete.
 147         (last_displayed_line): Delete.
 148         (class last_displayed_symtab_info_type): New.
 149         (last_displayed_symtab_info): New static global variable.
 150         (print_frame_info): Call methods on last_displayed_symtab_info.
 151         (clear_last_displayed_sal): Update header comment, and make use of
 152         last_displayed_symtab_info.
 153         (last_displayed_sal_is_valid): Likewise.
 154         (get_last_displayed_pspace): Likewise.
 155         (get_last_displayed_addr): Likewise.
 156         (get_last_displayed_symtab): Likewise.
 157         (get_last_displayed_line): Likewise.
 158         (get_last_displayed_sal): Likewise.
 159         * stack.h (clear_last_displayed_sal): Update header comment.
 160         (last_displayed_sal_is_valid): Likewise.
 161         (get_last_displayed_pspace): Likewise.
 162         (get_last_displayed_addr): Likewise.
 163         (get_last_displayed_symtab): Likewise.
 164         (get_last_displayed_line): Likewise.
 165         (get_last_displayed_sal): Likewise.
 166
 167 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
 168
 169         * stack.c (frame_show_address): Convert return type to bool.
 170         * stack.h (frame_show_address): Likewise, and update header
 171         comment.
 172
 173 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
 174
 175         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add new file to the list.
 176         * unittests/vec-utils-selftests.c: New file.
 177         * gdbsupport/gdb_vecs.h (unordered_remove): Avoid self move assign.
 178
 179 2019-11-10  Tom Tromey  <tom@tromey.com>
 180
 181         * tui/tui-wingeneral.c (tui_unhighlight_win): Use can_box.
 182         (tui_highlight_win): Likewise.
 183         (tui_win_info::check_and_display_highlight_if_needed): Likewise.
 184         * tui/tui-data.h (struct tui_win_info) <can_highlight>: Remove.
 185         * tui/tui-command.h (struct tui_cmd_window) <tui_cmd_window>:
 186         Don't set can_highlight.
 187
 188 2019-11-10  Tom Tromey  <tom@tromey.com>
 189
 190         * cli/cli-style.h (class cli_style_option) <cli_style_option>:
 191         Remove unused declaration.
 192
 193 2019-11-08  Tom Tromey  <tromey@adacore.com>
 194
 195         * top.c (read_command_file): Update.
 196         (command_line_input): Make return type const.
 197         * python/py-gdb-readline.c: Update.
 198         * linespec.c (decode_line_2): Update.
 199         * defs.h (command_line_input): Make return type const.
 200         * cli/cli-script.c (read_next_line): Make return type const.
 201         * ada-lang.c (get_selections): Update.
 202
 203 2019-11-06  Christian Biesinger  <cbiesinger@google.com>
 204
 205         * linux-tdep.c (linux_info_proc): Use strtok_r instead of strtok.
 206         * mi/mi-main.c (output_cores): Likewise.
 207         * nat/linux-osdata.c (linux_xfer_osdata_cpus): Likewise.
 208         (linux_xfer_osdata_modules): Likewise.
 209         * remote.c (register_remote_support_xml): Likewise.
 210         * sparc64-tdep.c (adi_is_addr_mapped): Likewise.
 211         * xml-syscall.c (syscall_create_syscall_desc): Likewise.
 212
 213 2019-11-06  Tom Tromey  <tom@tromey.com>
 214
 215         * tui/tui-interp.c: Don't include readline.h.
 216         * tui/tui-hooks.c: Don't include readline.h.
 217         * symmisc.c: Include tilde.h, not readline.h.
 218         * symfile.c: Include tilde.h, not readline.h.
 219         * source.c: Include tilde.h, not readline.h.
 220         * solib.c: Include tilde.h, not readline.h.
 221         * psymtab.c: Include tilde.h, not readline.h.
 222         * exec.c: Include tilde.h, not readline.h.
 223         * corelow.c: Include tilde.h, not readline.h.
 224         * cli/cli-dump.c: Include tilde.h, not readline.h.
 225         * cli/cli-cmds.c: Don't include readline.h.
 226
 227 2019-11-05  Tom Tromey  <tom@tromey.com>
 228
 229         * tui/tui-disasm.c (struct tui_asm_line) <addr_size>: New member.
 230         (tui_disassemble): Set addr_size.
 231         (tui_disasm_window::set_contents): Use addr_size.
 232
 233 2019-11-05  Tom Tromey  <tom@tromey.com>
 234
 235         * rust-lang.c (rust_language_defn): Update.
 236         * python/py-value.c (valpy_string): Call c_get_string.
 237         * p-lang.c (pascal_language_defn): Update.
 238         * opencl-lang.c (opencl_language_defn): Update.
 239         * objc-lang.c (objc_language_defn): Update.
 240         * m2-lang.c (m2_language_defn): Update.
 241         * language.c (unknown_language_defn, auto_language_defn): Update.
 242         (default_get_string): Remove.
 243         * guile/scm-value.c (gdbscm_value_to_string): Use c_get_string.
 244         * go-lang.c (go_language_defn): Update.
 245         * f-lang.c (f_language_defn): Update.
 246         * d-lang.c (d_language_defn): Update.
 247         * c-lang.c (c_language_defn, cplus_language_defn)
 248         (asm_language_defn, minimal_language_defn): Update.
 249         * ada-lang.c (ada_language_defn): Update.
 250         * language.h (struct language_defn) <la_get_string>: Remove.
 251         (LA_GET_STRING): Remove.
 252         (default_get_string): Don't declare.
 253
 254 2019-11-05  Tom Tromey  <tom@tromey.com>
 255
 256         * tui/tui-source.h (struct tui_source_window): Inline
 257         constructor.  Remove destructor.
 258         <style_changed, m_observable>: Move to superclass.
 259         * tui/tui-winsource.h (tui_copy_source_line): Declare.
 260         (struct tui_source_window_base): Move private members to end.
 261         <style_changed, m_observable>: Move from tui_source_window.
 262         * tui/tui-winsource.c (tui_copy_source_line): Move from
 263         tui-source.c.  Rename from copy_source_line.  Add special handling
 264         for negative line number.
 265         (tui_source_window_base::style_changed): Move from
 266         tui_source_window.
 267         (tui_source_window_base): Register observer.
 268         (~tui_source_window_base): New.
 269         * tui/tui-source.c (copy_source_line): Move to tui-winsource.c;
 270         rename.
 271         (tui_source_window::set_contents): Use tui_copy_source_line.
 272         (tui_source_window::tui_source_window): Move to tui-source.h.
 273         (tui_source_window::~tui_source_window): Remove.
 274         (tui_source_window::style_changed): Move to superclass.
 275         * tui/tui-disasm.c (tui_disassemble): Create string file with
 276         styling, when possible.  Add "addr_size" parameter.
 277         (tui_disasm_window::set_contents): Use tui_copy_source_line.
 278         Don't compute maximum size.
 279         (len_without_escapes): New function
 280
 281 2019-11-05  Tom Tromey  <tom@tromey.com>
 282
 283         * tui/tui-winsource.h (struct tui_source_element) <line>: Now a
 284         std::string.
 285         * tui/tui-winsource.c (tui_show_source_line): Update.
 286         * tui/tui-source.c (tui_source_window::set_contents): Update.
 287         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
 288
 289 2019-11-05  Christian Biesinger  <cbiesinger@google.com>
 290
 291         * symtab.h (gdb_static_assert): Put && operator at the beginning
 292         of the line instead of the end.
 293
 294 2019-11-04  Christian Biesinger  <cbiesinger@google.com>
 295
 296         * psympriv.h: Add static_asserts for sizeof (general_symbol_info)
 297         and sizeof (symbol).
 298         * symtab.h: Add a static_assert for sizeof (partial_symbol).
 299
 300 2019-11-04  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
 301
 302         * NEWS (Changes since GDB 8.3): Document Solaris 10 removal.
 303         * configure.host: Mark *-*-solaris2.10* obsolete.
 304         * configure.tgt: Mark Solaris < 11 obsolete.
 305         * MAINTAINERS (Target Instruction Set Architectures) <sparc>:
 306         Update target triplet.
 307
 308 2019-11-01  Tom Tromey  <tromey@adacore.com>
 309
 310         * utils.c (print_sys_errmsg): Simplify.
 311
 312 2019-11-01  Tom Tromey  <tromey@adacore.com>
 313
 314         * gdbsupport/mingw-strerror.c (safe_strerror): Constify result.
 315
 316 2019-11-01  Christian Biesinger  <cbiesinger@google.com>
 317
 318         * configure: Regenerate.
 319         * configure.ac: Remove check for strerror_r.
 320         * gdbsupport/common.m4: Check for strerror_r.
 321
 322 2019-11-01  Luis Machado  <luis.machado@linaro.org>
 323
 324         PR gdb/25124
 325
 326         * arm-tdep.c (arm_per_objfile): Rename to ...
 327         (arm_per_bfd): ... this.
 328         (arm_objfile_data_key): Rename to ...
 329         (arm_bfd_data_key): ... this.
 330         (arm_find_mapping_symbol): Adjust access to new bfd_key-based
 331         data.
 332         (arm_record_special_symbol): Likewise.
 333
 334 2019-10-31  Andrew Burgess  <andrew.burgess@embecosm.com>
 335
 336         * ada-typeprint.c (ada_print_typedef): Don't print newline at the
 337         end.
 338         * c-typeprint.c (c_print_typedef): Likewise.
 339         * f-typeprint.c (f_print_typedef): Likewise.
 340         * m2-typeprint.c (m2_print_typedef): Likewise.
 341         * p-typeprint.c (pascal_print_typedef): Likewise.
 342         * rust-lang.c (rust_print_typedef): Likewise.
 343         * symtab.c (print_symbol_info): Print a newline after calling
 344         typedef_print.
 345
 346 2019-10-31  Andrew Burgess  <andrew.burgess@embecosm.com>
 347
 348         * symtab.c (info_module_cmdlist): New variable.
 349         (info_module_command): New function.
 350         (search_module_symbols): New function.
 351         (info_module_subcommand): New function.
 352         (struct info_modules_var_func_options): New struct.
 353         (info_modules_var_func_options_defs): New variable.
 354         (make_info_modules_var_func_options_def_group): New function.
 355         (info_module_functions_command): New function.
 356         (info_module_variables_command): New function.
 357         (info_module_var_func_command_completer): New function.
 358         (_initialize_symtab): Register new 'info module functions' and
 359         'info module variables' commands.
 360         * symtab.h (typedef symbol_search_in_module): New typedef.
 361         (search_module_symbols): Declare new function.
 362         * NEWS: Mention new commands.
 363
 364 2019-10-31  Andrew Burgess  <andrew.burgess@embecosm.com>
 365
 366         * dwarf2read.c (dw2_symtab_iter_next): Handle MODULE_DOMAIN.
 367         (dw2_expand_marked_cus): Handle MODULES_DOMAIN.
 368         (dw2_debug_names_iterator::next): Handle MODULE_DOMAIN and
 369         MODULES_DOMAIN.
 370         (scan_partial_symbols): Only create partial module symbols for non
 371         declarations.
 372         * psymtab.c (recursively_search_psymtabs): Handle MODULE_DOMAIN
 373         and MODULES_DOMAIN.
 374         * symtab.c (search_domain_name): Likewise.
 375         (search_symbols): Likewise.
 376         (print_symbol_info): Likewise.
 377         (symtab_symbol_info): Likewise.
 378         (info_modules_command): New function.
 379         (_initialize_symtab): Register 'info modules' command.
 380         * symtab.h (enum search_domain): Add MODULES_DOMAIN.
 381         * NEWS: Mention new 'info modules' command.
 382
 383 2019-10-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 384
 385         * NEWS: Mention $_gdb_setting, $_gdb_setting_str, $_gdb_maint_setting
 386         and $_gdb_maint_setting_str.
 387
 388 2019-10-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 389
 390         * cli/cli-cmds.c (setting_cmd, value_from_setting)
 391         (gdb_setting_internal_fn, gdb_maint_setting_internal_fn)
 392         (str_value_from_setting, gdb_setting_str_internal_fn)
 393         (gdb_maint_setting_str_internal_fn): New functions.
 394         (_initialize_cli_cmds): Define the new convenience functions.
 395         * gdb/cli/cli-setshow.h (get_setshow_command_value_string): Constify.
 396         * gdb/cli/cli-setshow.c (get_setshow_command_value_string): Constify.
 397
 398 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
 399
 400         * agent.c (set_can_use_agent): When the setting is turned on,
 401         look up agent symbols if we don't have them yet.
 402         (agent_new_objfile): Don't look up agent symbols when the agent
 403         setting is off.
 404
 405 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
 406
 407         * config.in: Regenerate.
 408
 409 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
 410
 411         * configure: Regenerate.
 412         * configure.ac: Check for strerror_r.
 413         * gdbsupport/common-utils.h (safe_strerror): Change return value
 414         to const char * and document that this function is now threadsafe.
 415         * gdbsupport/posix-strerror.c (safe_strerror): Make buf
 416         thread_local and call strerror_r, if available.
 417         * utils.c (perror_string): Update.
 418         (print_sys_errmsg): Update.
 419
 420 2019-10-31  Luis Machado  <luis.machado@linaro.org>
 421
 422         * arm-tdep.c (arm_exidx_data_key): Use bfd_key instead of
 423         objfile_key.
 424         (arm_exidx_new_objfile): Adjust to use objfile->obfd instead of
 425         objfile to fetch per-bfd data.
 426         (arm_find_exidx_entry): Likewise.
 427
 428 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
 429
 430         * gdbsupport/agent.c (debug_agent): Change type to bool.
 431         (use_agent): Likewise.
 432         (all_agent_symbols_look_up): Likewise.
 433         (agent_loaded_p): Change return value to bool.
 434         (agent_look_up_symbols): Update.
 435         (agent_capability_check): Change return value to bool.
 436         * gdbsupport/agent.h (agent_loaded_p): Likewise.
 437         (debug_agent): Change type to bool.
 438         (use_agent): Likewise.
 439         (agent_capability_check): Change return value to bool.
 440
 441 2019-10-30  Christian Biesinger  <cbiesinger@google.com>
 442
 443         * minsyms.c (clear_minimal_symbol_hash_tables): New function.
 444         (build_minimal_symbol_hash_tables): Code to clear the table moved
 445         to clear_minimal_symbol_hash_tables.
 446         (minimal_symbol_reader::install): Call clear_minimal_symbol_hash_tables
 447         when needed.
 448
 449 2019-10-29  Simon Marchi  <simon.marchi@polymtl.ca>
 450
 451         * infcmd.c: Remove includes.
 452         * infrun.c: Remove includes.
 453
 454 2019-10-29  Simon Marchi  <simon.marchi@polymtl.ca>
 455
 456         * ada-lang.h (GROW_VECT): Move to ada-lang.c.
 457         (grow_vect): Remove declaration.
 458         (ada_type_of_array): Remove declaration.
 459         (ada_update_initial_language): Remove declaration.
 460         (ada_fold_name): Remove declaration.
 461         (ada_fill_in_ada_prototype): Remove declaration.
 462         (user_select_syms): Remove declaration.
 463         (get_selections): Remove declaration.
 464         (ada_tag_type): Remove declaration.
 465         (ada_value_tag): Remove declaration.
 466         (ada_is_others_clause): Remove declaration.
 467         (ada_in_variant): Remove declaration.
 468         (ada_value_struct_elt): Remove declaration.
 469         (ada_attribute_name): Remove declaration.
 470         (ada_system_address_type): Remove declaration.
 471         * ada-lang.c (ada_watch_location_expression): Make static.
 472         (GROW_VECT): Move here from ada-lang.h.
 473         (grow_vect): Make static.
 474         (ada_update_initial_language): Make static.
 475         (ada_fold_name): Make static.
 476         (ada_type_of_array): Make static.
 477         (encoded_ordered_before): Move up.
 478         (sort_choices): Move up.
 479         (print_signatures): Move up.
 480         (ada_print_symbol_signature): Move up.
 481         (get_selections): Move up and make static.
 482         (user_select_syms): Move up and make static.
 483         (ada_value_struct_elt): Move up and make static.
 484         (ada_tag_type): Make static.
 485         (ada_value_tag): Make static.
 486         (ada_is_others_clause): Make static.
 487         (ada_in_variant): Make static.
 488         (ada_attribute_name): Make static.
 489
 490 2019-10-29  Simon Marchi  <simon.marchi@polymtl.ca>
 491
 492         * ada-lang.c: Remove includes.
 493         * ada-typeprint.c: Remove includes.
 494         * ada-valprint.c: Remove includes.
 495
 496 2019-10-29  Simon Marchi  <simon.marchi@efficios.com>
 497
 498         * addrmap.c: Add static assertions of type size, moved from
 499         _initialize_addrmap.
 500         (_initialize_addrmap): Remove.
 501
 502 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
 503
 504         * coffread.c (record_minimal_symbol): Update.
 505         (process_coff_symbol): Update.
 506         * dbxread.c (read_dbx_symtab): Update.
 507         * dwarf2read.c (add_partial_symbol): Update.
 508         (fixup_go_packaging): Update.
 509         (load_partial_dies): Update.
 510         (new_symbol): Update.
 511         * elfread.c (record_minimal_symbol): Change signature to use
 512         gdb::string_view instead of name+len.
 513         (elf_symtab_read): Update.
 514         (elf_rel_plt_read): Update.
 515         * mdebugread.c (parse_partial_symbols): Update.
 516         (handle_psymbol_enumerators): Update.
 517         (new_symbol): Update.
 518         * minsyms.c (minimal_symbol_reader::record_full): Change signature
 519         to use gdb::string_view instead of name+len.
 520         * minsyms.h (class minimal_symbol_reader) <record_full>: Likewise.
 521         * psympriv.h (add_psymbol_to_list): Likewise.
 522         * psymtab.c (add_psymbol_to_bcache): Likewise.
 523         (add_psymbol_to_list): Likewise.
 524         * stabsread.c (define_symbol): Update.
 525         * symtab.c (symbol_set_names): Change signature to use gdb::string_view.
 526         * symtab.h (SYMBOL_SET_NAMES): Likewise.
 527         (symbol_set_names): Likewise.
 528         * xcoffread.c (scan_xcoff_symtab): Update.
 529
 530 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
 531
 532         * symtab.h (symbol_set_names): Document that copy_name must be
 533         set to true for non-nullterminated strings.
 534         * symtab.c (symbol_set_names): Only make a nullterminated copy of
 535         linkage_name if the entry was not found and we need to demangle.
 536
 537 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
 538
 539         * Makefile.in (HFILES_NO_SRCDIR): Add gdb_binary_search.h.
 540         * dwarf2-frame.c (bsearch_fde_cmp): Update.
 541         (dwarf2_frame_find_fde): Replace bsearch with gdb::binary_search.
 542         * gdbsupport/gdb_binary_search.h: New file.
 543
 544 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
 545
 546         * NEWS: Mention new --with-system-gdbinit-dir option.
 547         * config.in: Regenerate.
 548         * configure: Regenerate.
 549         * configure.ac: Add new option --with-system-gdbinit-dir.
 550         * extension.c (get_ext_lang_of_file): Return extension_language_gdb
 551         for a ".gdb" suffix.
 552         * main.c (get_init_files): Change system_gdbinit argument to
 553         a vector and return the files in SYSTEM_GDBINIT_DIR in
 554         addition to SYSTEM_GDBINIT.
 555         (captured_main_1): Update.
 556         (print_gdb_help): Update.
 557         * top.c (print_gdb_configuration): Also print the value of
 558         SYSTEM_GDBINIT_DIR.
 559
 560 2019-10-28  Christian Biesinger  <cbiesinger@google.com>
 561
 562         * gdbsupport/common-utils.h (startswith): Add an overloaded version
 563         that takes gdb::string_view arguments.
 564
 565 2019-10-26  Tom de Vries  <tdevries@suse.de>
 566
 567         * aarch64-linux-tdep.c: Fix typos in comments.
 568         * aarch64-tdep.c: Same.
 569         * ada-lang.c: Same.
 570         * amd64-nat.c: Same.
 571         * arc-tdep.c: Same.
 572         * arch/aarch64-insn.c: Same.
 573         * block.c: Same.
 574         * breakpoint.h: Same.
 575         * btrace.h: Same.
 576         * c-varobj.c: Same.
 577         * cli/cli-decode.c: Same.
 578         * cli/cli-script.c: Same.
 579         * cli/cli-utils.h: Same.
 580         * coff-pe-read.c: Same.
 581         * coffread.c: Same.
 582         * compile/compile-cplus-symbols.c: Same.
 583         * compile/compile-object-run.c: Same.
 584         * completer.c: Same.
 585         * corelow.c: Same.
 586         * cp-support.c: Same.
 587         * demangle.c: Same.
 588         * dwarf-index-write.c: Same.
 589         * dwarf2-frame.c: Same.
 590         * dwarf2-frame.h: Same.
 591         * eval.c: Same.
 592         * frame-base.h: Same.
 593         * frame.h: Same.
 594         * gdbcmd.h: Same.
 595         * gdbtypes.h: Same.
 596         * gnu-nat.c: Same.
 597         * guile/scm-objfile.c: Same.
 598         * i386-tdep.c: Same.
 599         * i386-tdep.h: Same.
 600         * infcall.c: Same.
 601         * infcall.h: Same.
 602         * linux-nat.c: Same.
 603         * m68k-tdep.c: Same.
 604         * macroexp.c: Same.
 605         * memattr.c: Same.
 606         * mi/mi-cmd-disas.c: Same.
 607         * mi/mi-getopt.h: Same.
 608         * mi/mi-main.c: Same.
 609         * minsyms.c: Same.
 610         * nat/aarch64-sve-linux-sigcontext.h: Same.
 611         * objfiles.h: Same.
 612         * ppc-linux-nat.c: Same.
 613         * ppc-linux-tdep.c: Same.
 614         * ppc-tdep.h: Same.
 615         * progspace.h: Same.
 616         * prologue-value.h: Same.
 617         * python/py-evtregistry.c: Same.
 618         * python/py-instruction.h: Same.
 619         * record-btrace.c: Same.
 620         * record-full.c: Same.
 621         * remote.c: Same.
 622         * rs6000-tdep.c: Same.
 623         * ser-tcp.c: Same.
 624         * sol-thread.c: Same.
 625         * sparc-sol2-tdep.c: Same.
 626         * sparc64-tdep.c: Same.
 627         * stabsread.c: Same.
 628         * symfile.c: Same.
 629         * symtab.h: Same.
 630         * target.c: Same.
 631         * tracepoint.c: Same.
 632         * tui/tui-data.h: Same.
 633         * tui/tui-io.c: Same.
 634         * tui/tui-win.c: Same.
 635         * tui/tui.c: Same.
 636         * unittests/rsp-low-selftests.c: Same.
 637         * user-regs.h: Same.
 638         * utils.c: Same.
 639         * utils.h: Same.
 640         * valarith.c: Same.
 641         * valops.c: Same.
 642         * valprint.c: Same.
 643         * valprint.h: Same.
 644         * value.c: Same.
 645         * value.h: Same.
 646         * varobj.c: Same.
 647         * x86-nat.h: Same.
 648         * xtensa-tdep.c: Same.
 649
 650 2019-10-25  Ali Tamur <tamur@google.com>
 651
 652         * charset.c (find_charset_names): Reflect API change.
 653
 654 2019-10-25  Christian Biesinger  <cbiesinger@google.com>
 655
 656         * symtab.c (struct demangled_name_entry): Change demangled name
 657         to a unique_xmalloc_ptr<char>, now that we don't allocate it as
 658         part of the struct anymore.
 659         (symbol_set_names): No longer obstack allocate + copy the demangled
 660         name, just store the allocated name from bfd.
 661
 662 2019-10-25  Tom Tromey  <tromey@adacore.com>
 663
 664         * dwarf2-frame.c (dwarf2_cie_table): Now a typedef.
 665         (bsearch_cie_cmp, add_cie): Remove.
 666         (find_cie): Reimplement.
 667         (decode_frame_entry_1, decode_frame_entry): Change type.  Update.
 668         (dwarf2_build_frame_info): Update.
 669
 670 2019-10-24  H.J. Lu  <hongjiu.lu@intel.com>
 671
 672         PR gdb/25126
 673         * symfile.c (reread_symbols): Call forget_cached_source_info to
 674         clear the stale source cache.
 675
 676 2019-10-24  Christian Biesinger  <cbiesinger@google.com>
 677
 678         * configure: Regenerate.
 679         * configure.ac: Remove code that sets python_has_threads.
 680
 681 2019-10-24  Christian Biesinger  <cbiesinger@google.com>
 682
 683         * config.in: Regenerate.
 684         * configure: Regenerate.
 685         * configure.ac: Remove the code that uses sed to get the python
 686         version and defines HAVE_LIBPYTHON2_6 / HAVE_LIBPYTHON2_7.
 687
 688 2019-10-24  Andrew Burgess  <andrew.burgess@embecosm.com>
 689
 690         * python/py-progspace.c (pspy_block_for_pc): Return None for all
 691         error paths.
 692
 693 2019-10-23  Tom Tromey  <tom@tromey.com>
 694
 695         * arc-tdep.c: Remove ".." from include.
 696         * frv-tdep.c: Remove ".." from include.
 697         * lm32-tdep.c: Remove ".." from include.
 698         * microblaze-tdep.c: Remove ".." from include.
 699         * or1k-tdep.h: Remove ".." from include.
 700         * s12z-tdep.c: Remove ".." from include.
 701         * Makefile.in (OPCODES_CFLAGS): Add comment.
 702         (TOP_CFLAGS): New variable.
 703         (INTERNAL_CFLAGS_BASE): Add TOP_CFLAGS.
 704
 705 2019-10-23  Tom Tromey  <tom@tromey.com>
 706
 707         * Makefile.in (READLINE_DIR): Update.
 708
 709 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 710
 711         * infcall.c (call_function_by_hand_dummy): Fix the function
 712         comment.  And extract out a code section into...
 713         (reserve_stack_space): ...this new function.
 714
 715 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 716
 717         * infcall.c (value_arg_coerce): Remove an unused parameter.
 718         (call_function_by_hand_dummy): Update the call to
 719         'value_arg_coerce'.
 720
 721 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 722
 723         * infcall.c (call_function_by_hand_dummy): Refactor.
 724
 725 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 726
 727         * MAINTAINERS (Write After Approval): Add Tankut Baris Aktemur.
 728
 729 2019-10-23  Tom Tromey  <tom@tromey.com>
 730
 731         * configure: Rebuild.
 732         * configure.ac: Don't check for sigprocmask.
 733         * gdbsupport/common.m4 (GDB_AC_COMMON): Check for sigprocmask.
 734
 735 2019-10-23  Tom Tromey  <tom@tromey.com>
 736
 737         * configure: Rebuild.
 738         * acinclude.m4: Use m4_include, not sinclude.
 739
 740 2019-10-23  Tom de Vries  <tdevries@suse.de>
 741
 742         PR breakpoints/24687
 743         * symtab.c (iterate_over_some_symtabs): Apply gdb_realpath on fullname.
 744
 745 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
 746
 747         * symtab.c (struct demangled_name_entry) <language>: Change from
 748         bitfield to regular variable.
 749
 750 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
 751
 752         * symtab.c (struct demangled_name_entry): Add a constructor.
 753         (free_demangled_name_entry): New function to call the destructor
 754         for demangled_name_entry.
 755         (create_demangled_names_hash): Pass free_demangled_name_entry to
 756         htab_create_alloc.
 757         (symbol_set_names): Call placement new for demangled_name_entry.
 758         * utils.c: No longer include xxhash.h here, now that fast_hash
 759         is inlined in the header.
 760         * utils.h: Instead, include it here.
 761
 762 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
 763
 764         * Makefile.in: Link with libxxhash.
 765         * config.in: Regenerate.
 766         * configure: Regenerate.
 767         * configure.ac: Search for libxxhash.
 768         * utils.c (fast_hash): Use xxhash if present.
 769
 770 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
 771
 772         * utils.h (fast_hash): New function.
 773         * symtab.c (hash_demangled_name_entry): Call new function
 774         fast_hash.
 775
 776 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
 777
 778         * symtab.c (struct demangled_name_entry): Change type of mangled
 779         to gdb::string_view. Also adds a constructor that takes the
 780         mangled name.
 781         (hash_demangled_name_entry): Update.
 782         (eq_demangled_name_entry): Update.
 783         (free_demangled_name_entry): New function to call the destructor
 784         now that this is not a POD anymore.
 785         (create_demangled_names_hash): Pass free_demangled_name_entry to
 786         htab_create_alloc.
 787         (symbol_set_names): Update.
 788
 789 2019-10-21  Ali Tamur  <tamu@google.com>
 790
 791         * dwarf2read.c (dir_index): Change type.
 792         (file_name_index): Likewise.
 793         (line_header::include_dir_at): Change comment and implementation on
 794         whether it is DWARF 5.
 795         (line_header::is_valid_file_index): New function.
 796         (line_header::file_name_at): Change comment and implementation on
 797         whether it is DWARF 5.
 798         (line_header::file_names): Change to private field renamed as
 799         m_file_names and introduce a new accessor method.
 800         (line_header::file_names_size): New method.
 801         (line_header::include_dirs): Change to private field and rename as
 802         m_include_dirs.
 803         (dw2_get_file_names_reader): Define local var at a smaller scope and
 804         reflect API change.
 805         (dwarf2_cu::setup_type_unit_groups): Reflect API change.
 806         (process_structure_scope): Likewise.
 807         (line_header::add_include_dir): Change message and reflect renaming.
 808         (line_header::add_file_name): Likewise.
 809         (read_formatted_entries): Handle DW_FORM_data16.
 810         (dwarf_decode_line_header): Fix line header length calculation.
 811         (psymtab_include_file_name): Change comment and API.
 812         (lnp_state_machine::m_file): Update comment and reflect type change.
 813         (lnp_state_machine::record_line): Reflect type change.
 814         (dwarf_decode_lines): Reflect API change.
 815         (file_file_name): Likewise.
 816         (file_full_name): Likewise.
 817
 818 2019-10-21  Andrew Burgess  <andrew.burgess@embecosm.com>
 819
 820         * objfiles.c (sort_cmp): Ensure that !(a < a) holds true.
 821
 822 2019-10-21  Tom Tromey  <tom@tromey.com>
 823
 824         * tui/tui-winsource.h (tui_exec_info_content): Remove typedef.
 825
 826 2019-10-21  Tom Tromey  <tom@tromey.com>
 827
 828         * configure.ac (nm.h): Conditionally create nm.h link.  Subst
 829         NM_H.   Use AC_CONFIG_LINKS.
 830         * configure: Rebuild.
 831         * Makefile.in (NM_H): New variable.
 832         (generated_files): Add NM_H.  Remove gcore.
 833         (nm.h, stamp-nmh): New targets.
 834
 835 2019-10-20  Tom Tromey  <tom@tromey.com>
 836
 837         * objfiles.h (unlink_objfile, put_objfile_before): Don't declare.
 838         * objfiles.c (unlink_objfile): Move earlier.  Now static.  Remove
 839         obsolete comment.
 840         (put_objfile_before): Now static.
 841
 842 2019-10-19  Simon Marchi  <simon.marchi@polymtl.ca>
 843
 844         * gdbsupport/common-utils.h (startswith): Change return type to
 845         bool.
 846
 847 2019-10-19  Christian Biesinger  <cbiesinger@google.com>
 848
 849         * bcache.c (bcache::print_statistics): Use std::sort instead of qsort.
 850         * breakpoint.c (bp_locations_compare): Rename to...
 851         (bp_location_is_less_than): ...this, and change to std::sort semantics.
 852         (update_global_location_list): Use std::sort instead of qsort.
 853         * buildsym.c (compare_line_numbers): Rename to...
 854         (lte_is_less_than): ...this, and change to std::sort semantics.
 855         (buildsym_compunit::end_symtab_with_blockvector): Use std::sort
 856         instead of qsort.
 857         * disasm.c (compare_lines): Rename to...
 858         (line_is_less_than): ...this, and change to std::sort semantics.
 859         (do_mixed_source_and_assembly_deprecated): Call std::sort instead
 860         of qsort.
 861         * dwarf2-frame.c (qsort_fde_cmp): Rename to...
 862         (fde_is_less_than): ...this, and change to std::sort semantics.
 863         (dwarf2_build_frame_info): Call std::sort instead of qsort.
 864         * mdebugread.c (compare_blocks):
 865         (block_is_less_than): ...this, and change to std::sort semantics.
 866         (sort_blocks): Call std::sort instead of qsort.
 867         * objfiles.c (qsort_cmp): Rename to...
 868         (sort_cmp): ...this, and change to std::sort semantics.
 869         (update_section_map): Call std::sort instead of qsort.
 870         * remote.c (compare_pnums): Remove.
 871         (map_regcache_remote_table): Call std::sort instead of qsort.
 872         * utils.c (compare_positive_ints): Remove.
 873         * utils.h (compare_positive_ints): Remove.
 874         * xcoffread.c (compare_lte): Remove.
 875         (arrange_linetable): Call std::sort instead of qsort.
 876
 877 2019-10-19  Sergio Durigan Junior  <sergiodj@redhat.com>
 878
 879         * symfile.c (init_entry_point_info): Fix typo.
 880         * i386-darwin-tdep.c (darwin_dwarf_signal_frame_p): Fix typo.
 881
 882 2019-10-18  Tom de Vries  <tdevries@suse.de>
 883
 884         * aarch64-tdep.c: Fix typos in comments.
 885         * ada-lang.c: Same.
 886         * ada-tasks.c: Same.
 887         * alpha-tdep.c: Same.
 888         * alpha-tdep.h: Same.
 889         * amd64-nat.c: Same.
 890         * amd64-windows-tdep.c: Same.
 891         * arc-tdep.c: Same.
 892         * arc-tdep.h: Same.
 893         * arch-utils.c: Same.
 894         * arm-nbsd-tdep.c: Same.
 895         * arm-tdep.c: Same.
 896         * ax-gdb.c: Same.
 897         * blockframe.c: Same.
 898         * btrace.c: Same.
 899         * c-varobj.c: Same.
 900         * coff-pe-read.c: Same.
 901         * coffread.c: Same.
 902         * cris-tdep.c: Same.
 903         * darwin-nat.c: Same.
 904         * dbxread.c: Same.
 905         * dcache.c: Same.
 906         * disasm.c: Same.
 907         * dtrace-probe.c: Same.
 908         * dwarf-index-write.c: Same.
 909         * dwarf2-frame-tailcall.c: Same.
 910         * dwarf2-frame.c: Same.
 911         * dwarf2read.c: Same.
 912         * eval.c: Same.
 913         * exceptions.c: Same.
 914         * fbsd-tdep.c: Same.
 915         * findvar.c: Same.
 916         * frame.c: Same.
 917         * frv-tdep.c: Same.
 918         * gnu-v3-abi.c: Same.
 919         * go32-nat.c: Same.
 920         * h8300-tdep.c: Same.
 921         * hppa-tdep.c: Same.
 922         * i386-linux-tdep.c: Same.
 923         * i386-tdep.c: Same.
 924         * ia64-libunwind-tdep.c: Same.
 925         * ia64-tdep.c: Same.
 926         * infcmd.c: Same.
 927         * infrun.c: Same.
 928         * linespec.c: Same.
 929         * linux-nat.c: Same.
 930         * linux-thread-db.c: Same.
 931         * machoread.c: Same.
 932         * mdebugread.c: Same.
 933         * mep-tdep.c: Same.
 934         * mn10300-tdep.c: Same.
 935         * namespace.c: Same.
 936         * objfiles.c: Same.
 937         * opencl-lang.c: Same.
 938         * or1k-tdep.c: Same.
 939         * osabi.c: Same.
 940         * ppc-linux-nat.c: Same.
 941         * ppc-linux-tdep.c: Same.
 942         * ppc-sysv-tdep.c: Same.
 943         * printcmd.c: Same.
 944         * procfs.c: Same.
 945         * record-btrace.c: Same.
 946         * record-full.c: Same.
 947         * remote-fileio.c: Same.
 948         * remote.c: Same.
 949         * rs6000-tdep.c: Same.
 950         * s12z-tdep.c: Same.
 951         * score-tdep.c: Same.
 952         * ser-base.c: Same.
 953         * ser-go32.c: Same.
 954         * skip.c: Same.
 955         * sol-thread.c: Same.
 956         * solib-svr4.c: Same.
 957         * solib.c: Same.
 958         * source.c: Same.
 959         * sparc-nat.c: Same.
 960         * sparc-sol2-tdep.c: Same.
 961         * sparc-tdep.c: Same.
 962         * sparc64-tdep.c: Same.
 963         * stabsread.c: Same.
 964         * stack.c: Same.
 965         * symfile.c: Same.
 966         * symtab.c: Same.
 967         * target-descriptions.c: Same.
 968         * target-float.c: Same.
 969         * thread.c: Same.
 970         * utils.c: Same.
 971         * valops.c: Same.
 972         * valprint.c: Same.
 973         * value.c: Same.
 974         * varobj.c: Same.
 975         * windows-nat.c: Same.
 976         * xcoffread.c: Same.
 977         * xstormy16-tdep.c: Same.
 978         * xtensa-tdep.c: Same.
 979
 980 2019-10-17  Tom Tromey  <tromey@adacore.com>
 981
 982         * configure: Rebuild.
 983         * configure.ac: Use AC_CONFIG_HEADERS.  Create stamp-h there, not
 984         in AC_CONFIG_FILES invocation.
 985         * Makefile.in (Makefile, data-directory/Makefile, stamp-h): Use
 986         new-style config.status invocation.
 987
 988 2019-10-17  Tom de Vries  <tdevries@suse.de>
 989
 990         * arm-nbsd-nat.c: Fix typos in comments.
 991         * arm-tdep.c: Same.
 992         * darwin-nat-info.c: Same.
 993         * dwarf2read.c: Same.
 994         * elfread.c: Same.
 995         * event-top.c: Same.
 996         * findvar.c: Same.
 997         * gdbtypes.c: Same.
 998         * hppa-tdep.c: Same.
 999         * i386-tdep.c: Same.
1000         * jit.c: Same.
1001         * main.c: Same.
1002         * mdebugread.c: Same.
1003         * moxie-tdep.c: Same.
1004         * nto-procfs.c: Same.
1005         * osabi.c: Same.
1006         * ppc-linux-tdep.c: Same.
1007         * remote.c: Same.
1008         * riscv-tdep.c: Same.
1009         * s390-tdep.c: Same.
1010         * sh-tdep.c: Same.
1011         * sparc-linux-tdep.c: Same.
1012         * sparc-nat.c: Same.
1013         * stack.c: Same.
1014         * target-descriptions.c: Same.
1015         * top.c: Same.
1016         * varobj.c: Same.
1017
1018 2019-10-16  Tom Tromey  <tom@tromey.com>
1019
1020         * objfiles.h (struct objfile) <original_name>: Now const.
1021
1022 2019-10-16  Christian Biesinger  <cbiesinger@google.com>
1023
1024         * gdbsupport/gdb_setjmp.h (SIGSETJMP): Allow passing in the value to
1025         pass on to sigsetjmp's second argument.
1026         * cp-support.c (gdb_demangle): Unblock SIGSEGV if we caught a crash.
1027
1028 2019-10-16  Keith Seitz  <keiths@redhat.com>
1029
1030         PR gdb/23567
1031         * dwarf2read.c (dwarf2_per_objfile::locate_sections): Discard
1032         sections whose size is greater than the file size.
1033
1034 2019-10-16  Jim Wilson  <jimw@sifive.com>
1035
1036         * riscv-tdep.c (riscv_gcc_target_options): New.
1037         (riscv_gnu_triplet_regexp): New.
1038         (riscv_gdbarch_init): Call set_gdbarch_gcc_triplet_options and
1039         set_gdbarch_gnu_triplet_regexp.
1040
1041 2019-10-16  Christian Biesinger  <cbiesinger@google.com>
1042
1043         * Makefile.in: Add xml-builtin.h.
1044         * features/feature_to_c.sh: Add an include for xml-builtin.h
1045         to ensure that the compiler checks that the types match.
1046         * xml-builtin.h: New file.
1047         * xml-support.c (fetch_xml_builtin): Add missing const.
1048         * xml-support.h: Remove declaration of xml_builtins.
1049
1050 2019-10-16  Tom de Vries  <tdevries@suse.de>
1051
1052         PR tdep/25096
1053         * amd64-tdep.c (amd64_classify_aggregate_field): Factor out of ...
1054         (amd64_classify_aggregate): ... here.
1055         (amd64_classify_aggregate_field): Handled fiels of nested structs
1056         recursively.
1057
1058 2019-10-16  Tom de Vries  <tdevries@suse.de>
1059
1060         PR tdep/24104
1061         * amd64-tdep.c (amd64_push_arguments): Handle AMD64_NO_CLASS in loop
1062         that handles 'theclass'.
1063
1064 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1065
1066         * linespec.c (decode_digits_ordinary): Update comment.
1067         * make-target-delegates: No longer need to handle VEC case.
1068         * memrange.c (normalize_mem_ranges): Update comment.
1069         * namespace.c (add_using_directive): Update comment.
1070         * objc-lang.c (uniquify_strings): Update comment.
1071         * ppc-linux-nat.c (struct thread_points): Update comment.
1072         * probe.h (find_probes_in_objfile): Update comment.
1073         * target.h (enum flash_preserve_mode): Update comment.
1074         * varobj.c (varobj_restrict_range): Update comment.
1075         * varobj.h (varobj_list_children): Update comment.
1076
1077 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1078
1079         * Makefile.in: Remove references to vec.h and vec.c.
1080         * aarch64-tdep.c: No longer include vec.h.
1081         * ada-lang.c: Likewise.
1082         * ada-lang.h: Likewise.
1083         * arm-tdep.c: Likewise.
1084         * ax.h: Likewise.
1085         * breakpoint.h: Likewise.
1086         * charset.c: Likewise.
1087         * cp-support.h: Likewise.
1088         * dtrace-probe.c: Likewise.
1089         * dwarf2read.c: Likewise.
1090         * extension.h: Likewise.
1091         * gdb_bfd.c: Likewise.
1092         * gdbsupport/gdb_vecs.h: Likewise.
1093         * gdbsupport/vec.c: Remove.
1094         * gdbsupport/vec.h: Remove.
1095         * gdbthread.h: Likewise.
1096         * guile/scm-type.c: Likewise.
1097         * inline-frame.c: Likewise.
1098         * machoread.c: Likewise.
1099         * memattr.c: Likewise.
1100         * memrange.h: Likewise.
1101         * namespace.h: Likewise.
1102         * nat/linux-btrace.h: Likewise.
1103         * osdata.c: Likewise.
1104         * parser-defs.h: Likewise.
1105         * progspace.h: Likewise.
1106         * python/py-type.c: Likewise.
1107         * record-btrace.c: Likewise.
1108         * rust-exp.y: Likewise.
1109         * solib-target.c: Likewise.
1110         * stap-probe.c: Likewise.
1111         * target-descriptions.c: Likewise.
1112         * target-memory.c: Likewise.
1113         * target.h: Likewise.
1114         * varobj.c: Likewise.
1115         * varobj.h: Likewise.
1116         * xml-support.h: Likewise.
1117
1118 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1119
1120         * gdb/dwarf2read.c (dwarf2_per_objfile::~dwarf2_per_objfile):
1121         Update for new std::vector based implementation.
1122         (process_psymtab_comp_unit_reader): Likewise.
1123         (scan_partial_symbols): Likewise.
1124         (recursively_compute_inclusions): Likewise.
1125         (compute_compunit_symtab_includes): Likewise.
1126         (process_imported_unit_die): Likewise.
1127         (queue_and_load_dwo_tu): Likewise.
1128         (follow_die_sig_1): Likewise.
1129         * gdb/dwarf2read.h: Remove DEF_VEC_P.
1130         (typedef dwarf2_per_cu_ptr): Remove.
1131         (struct dwarf2_per_cu_data) <imported_symtabs_empty>: New
1132         function.
1133         (struct dwarf2_per_cu_data) <imported_symtabs_push>: New function.
1134         (struct dwarf2_per_cu_data) <imported_symtabs_size>: New function.
1135         (struct dwarf2_per_cu_data) <imported_symtabs_free>: New function.
1136         (struct dwarf2_per_cu_data) <imported_symtabs>: Change to
1137         std::vector.
1138
1139 2019-10-15  Tom Tromey  <tromey@adacore.com>
1140
1141         * windows-nat.c (windows_nat_target::resume): Use %x when logging
1142         TID.
1143
1144 2019-10-15  Tom Tromey  <tromey@adacore.com>
1145
1146         * windows-nat.c (windows_nat_target::fetch_registers)
1147         (windows_nat_target::store_registers): Rename "pid" to "tid".
1148
1149 2019-10-15  Tom Tromey  <tromey@adacore.com>
1150
1151         * gdbarch.h, gdbarch.c: Rebuild.
1152         * gdbarch.sh (gcc_target_options): Change return type to
1153         std::string.
1154         * compile/compile.c (get_args): Update.
1155         * nios2-tdep.c (nios2_gcc_target_options): Return std::string.
1156         * arm-linux-tdep.c (arm_linux_gcc_target_options): Return
1157         std::string.
1158         * aarch64-linux-tdep.c (aarch64_linux_gcc_target_options): Return
1159         std::string.
1160         * arch-utils.c (default_gcc_target_options): Return std::string.
1161         * arch-utils.h (default_gcc_target_options): Return std::string.
1162         * s390-tdep.c (s390_gcc_target_options): Return std::string.
1163
1164 2019-10-15  Christian Biesinger  <cbiesinger@google.com>
1165
1166         * breakpoint.c (breakpoint_chain): Make static.
1167         * tui/tui-winsource.c: Call iterate_over_breakpoints instead
1168         of accessing breakpoint_chain.
1169
1170 2019-10-15  Christian Biesinger  <cbiesinger@google.com>
1171
1172         * breakpoint.c (iterate_over_breakpoints): Change function pointer
1173         to a gdb::function_view and return value to bool.
1174         * breakpoint.h (iterate_over_breakpoints): Likewise.
1175         * dummy-frame.c (pop_dummy_frame_bpt): Update.
1176         (pop_dummy_frame): Update.
1177         * guile/scm-breakpoint.c (bpscm_build_bp_list): Update.
1178         (gdbscm_breakpoints): Update.
1179         * python/py-breakpoint.c (build_bp_list): Update.
1180         (gdbpy_breakpoints): Update.
1181         * python/py-finishbreakpoint.c (bpfinishpy_detect_out_scope_cb):
1182         Update.
1183         (bpfinishpy_handle_stop): Update.
1184         (bpfinishpy_handle_exit): Update.
1185         * solib-svr4.c (svr4_update_solib_event_breakpoint): Update.
1186         (svr4_update_solib_event_breakpoints): Update.
1187
1188 2019-10-15  Andreas Arnez  <arnez@linux.ibm.com>
1189
1190         * s390-tdep.c (s390_effective_inner_type): Ignore static fields
1191         when unwrapping single-field structs.
1192
1193 2019-10-14  Simon Marchi  <simon.marchi@polymtl.ca>
1194
1195         * dwarf2read.c: Remove includes.
1196
1197 2019-10-13  Simon Marchi  <simon.marchi@polymtl.ca>
1198
1199         * ui-out.c (ui_out::call_do_message): Silence
1200         -Wformat-nonliteral warning.
1201
1202 2019-10-12  Simon Marchi  <simon.marchi@polymtl.ca>
1203
1204         * breakpoint.c: Remove some includes: continuations.h, skip.h,
1205         mi/mi-main.h, readline/readline.h, readline/history.h.  Add
1206         include: readline/tilde.h.
1207
1208 2019-10-12  Christian Biesinger  <cbiesinger@google.com>
1209
1210         * remote.c (remote_target::get_trace_status): Remove declaration of
1211         trace_regblock_size.
1212
1213 2019-10-12  Christian Biesinger  <cbiesinger@google.com>
1214
1215         * cli/cli-cmds.c (max_user_call_depth): Move comment to header.
1216         (show_user): Remove declaration of cmdlist.
1217         * cli/cli-cmds.h (max_user_call_depth): Declare.
1218         * cli/cli-script.c (execute_user_command): Remove declaration
1219         of max_user_call_depth.
1220
1221 2019-10-11  Jim Wilson  <jimw@sifive.com>
1222
1223         * gdbsupport/print-utils.h (pulongest): Fix comment.
1224         (plongest): Likewise.
1225         (phex): Add missing comment, mention leading zeros.
1226         (phex_nz): Add mention of no leading zeros to comment.
1227
1228         * riscv-tdep.c (riscv_push_dummy_code): Change %lld to %s and use
1229         plongest instead of unsigned long long cast.
1230
1231 2019-10-10  Christian Biesinger  <cbiesinger@google.com>
1232
1233         * main.c (captured_main_1): Include gdbtk.h and remove declarations
1234         for external_editor_command and gdbtk_test.
1235
1236 2019-10-10  Christian Biesinger  <cbiesinger@google.com>
1237
1238         * mi/mi-cmd-var.c (varobjdebug): Remove declaration.
1239         * varobj.c (varobjdebug): Move comment to...
1240         * varobj.h (varobjdebug): ...here, and declare.
1241
1242 2019-10-09  Tom Tromey  <tom@tromey.com>
1243
1244         * tui/tui-regs.c (tui_data_window::show_registers): Don't call
1245         erase_data_content.
1246
1247 2019-10-09  Tom Tromey  <tom@tromey.com>
1248
1249         * tui/tui-wingeneral.h (tui_delete_win): Don't declare.
1250         * tui/tui-stack.c (tui_locator_window::rerender): Update.
1251         * tui/tui-command.c (tui_cmd_window::resize)
1252         (tui_refresh_cmd_win): Update.
1253         * tui/tui-win.c (tui_resize_all, tui_set_focus_command): Update.
1254         * tui/tui.c (tui_rl_other_window, tui_enable): Update.
1255         * tui/tui-data.c (~tui_gen_win_info): Remove.
1256         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
1257         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
1258         (tui_redisplay_readline, tui_mld_flush)
1259         (tui_mld_erase_entire_line, tui_mld_getc, tui_getc): Update.
1260         * tui/tui-regs.c (tui_data_window::delete_data_content_windows)
1261         (tui_data_window::erase_data_content)
1262         (tui_data_item_window::rerender)
1263         (tui_data_item_window::refresh_window): Update.
1264         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window)
1265         (box_win, tui_gen_win_info::make_window)
1266         (tui_gen_win_info::make_visible): Update.
1267         (tui_delete_win): Remove.
1268         * tui/tui-winsource.c
1269         (tui_source_window_base::do_erase_source_content): Update.
1270         (tui_show_source_line, tui_source_window_base::update_tab_width)
1271         (tui_source_window_base::update_exec_info): Update.
1272         * tui/tui-data.h (struct curses_deleter): New.
1273         (struct tui_gen_win_info) <handle>: Now a unique_ptr.
1274         (struct tui_gen_win_info) <~tui_gen_win_info>: Define.
1275
1276 2019-10-09  Tom Tromey  <tom@tromey.com>
1277
1278         * tui/tui-wingeneral.h (struct tui_gen_win_info): Don't declare.
1279
1280 2019-10-09  Tom Tromey  <tom@tromey.com>
1281
1282         * tui/tui-data.c (tui_win_is_auxiliary): Remove.
1283         * tui/tui-data.h (tui_win_is_auxiliary): Don't declare.
1284
1285 2019-10-09  Tom Tromey  <tom@tromey.com>
1286
1287         * tui/tui-disasm.c (tui_get_low_disassembly_address): Compute
1288         window height directly.
1289         * tui/tui-layout.h (tui_default_win_viewport_height): Don't
1290         declare.
1291         * tui/tui-layout.c (tui_default_win_height): Remove.
1292         (tui_default_win_viewport_height): Remove.
1293
1294 2019-10-09  Tom Tromey  <tom@tromey.com>
1295
1296         * tui/tui.h: Remove comments.
1297
1298 2019-10-09  Tom de Vries  <tdevries@suse.de>
1299
1300         * python/lib/gdb/printer/bound_registers.py: Use
1301         '^builtin_type_bound128' as regexp argument for
1302         add_builtin_pretty_printer.
1303
1304 2019-10-09  Christian Biesinger  <cbiesinger@google.com>
1305
1306         * guile/guile.c (guile_extension_script_ops): Remove forward
1307         declaration and mark as static.
1308         (guile_script_ops): Likewise.
1309         (extension_language_guile): Move further down in the file so
1310         it can reference the definitions for guile_{extension_,}script_ops.
1311
1312 2019-10-09  Andreas Arnez  <arnez@linux.ibm.com>
1313
1314         * s390-tdep.c (390_process_record): Handle new arch13 instructions
1315         except SORTL, DFLTCC, and KDSA.
1316
1317 2019-10-08  Tom Tromey  <tromey@adacore.com>
1318
1319         * windows-nat.c (struct windows_thread_info_struct) <sf>: Remove.
1320         (struct safe_symbol_file_add_args): Remove.
1321
1322 2019-10-08  Tom Tromey  <tromey@adacore.com>
1323
1324         * windows-nat.c: Don't include buildsym-legacy.h.
1325
1326 2019-10-08  Tom Tromey  <tromey@adacore.com>
1327
1328         * contrib/ari/gdb_ari.sh (%p): Allow gdb-specific %p extensions.
1329
1330 2019-10-08  Christian Biesinger  <cbiesinger@google.com>
1331
1332         * gdbtypes.c (overload_debug): Move comment to header.
1333         * gdbtypes.h (overload_debug): Declare.
1334         * valops.c: Remove declaration of overload_debug, instead
1335         include gdbtypes.h.
1336
1337 2019-10-08  Christian Biesinger  <cbiesinger@google.com>
1338
1339         * language.c (show_language_command): Pass lang_frame_mismatch_warn
1340         through _().
1341         (lang_frame_mismatch_warn): Make const, mark with N_(), and
1342         move comment...
1343         * language.h (lang_frame_mismatch_warn): ... here. Also add
1344         declaration.
1345         * top.c (lang_frame_mismatch_warn): Remove declaration.
1346         (check_frame_language_change): Pass lang_frame_mismatch_warn
1347         through _().
1348
1349 2019-10-07  Christian Biesinger  <cbiesinger@google.com>
1350
1351         * c-lang.h (vtbl_ptr_name): Declare.
1352         * cp-valprint.c (vtbl_ptr_name): Remove "extern" now that we get
1353         it from the header.
1354         * stabsread.c (define_symbol): Remove declaration of vtbl_ptr_name.
1355
1356 2019-10-07  Christian Biesinger  <cbiesinger@google.com>
1357
1358         * charset.c (your_gdb_wchar_t_is_bogus): Replace with a
1359         gdb_static_assert.
1360
1361 2019-10-07  Weimin Pan  <weimin.pan@oracle.com>
1362
1363         * ../Makefile.def (dependencies): Add all-libctf to all-gdb
1364         * ../Makefile.in: Add "all-gdb: maybe-all-libctf"
1365         * ctfread.c: New file.
1366         * ctfread.h: New file.
1367         * elfread.c: Include ctfread.h.
1368         (struct elfinfo text_p): New member ctfsect.
1369         (elf_locate_sections): Mark CTF section.
1370         (elf_symfile_read): Call elfctf_build_psymtabs.
1371         * Makefile.in (LIBCTF): Add.
1372         (CLIBS): Use it.
1373         (CDEPS): Likewise.
1374         (DIST): Add ctfread.c.
1375
1376 2019-10-07  Andrew Burgess  <andrew.burgess@embecosm.com>
1377
1378         * ctfread.c (struct nextfield): Renamed to ...
1379         (struct ctf_nextfield): ... this.
1380         (struct field_info): Renamed to ...
1381         (strut ctf_field_info): ... this.
1382         (attach_fields_to_type): Update for renamed structures.
1383         (ctf_add_member_cb): Likewise.
1384         (ctf_add_enum_member_cb): Likewise.
1385         (process_struct_members): Likewise.
1386         (process_enum_type): Likewise.
1387
1388 2019-10-07  Weimin Pan  <weimin.pan@oracle.com>
1389
1390         * tracectf.h: Rename, was ctf.h.
1391         * tracectf.c: Rename, was ctf.c, replace ctf.h with tracectf.h.
1392         * tracefile.c: Likewise.
1393         * tracepoint.c: Remove unused include ctf.h.
1394         * mi/mi-main.c: Likewise.
1395         * Makefile.in Replace ctf.c with tracectf.c.
1396
1397 2019-10-06  Joel Brobecker  <brobecker@adacore.com>
1398
1399         * version.in: Change version number to "9.0.50.DATE-git".
1400
1401 2019-10-03  Tom Tromey  <tom@tromey.com>
1402
1403         PR rust/24976:
1404         * dwarf2read.c (quirk_rust_enum): Handle single-element unions.
1405
1406 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1407
1408         * f-lang.c (f_language_defn): Use cp_get_symbol_name_matcher and
1409         cp_search_name_hash.
1410         * NEWS: Add entry about nested function support.
1411
1412 2019-10-03  Bernhard Heckel  <bernhard.heckel@intel.com>
1413             Andrew Burgess  <andrew.burgess@embecosm.com>
1414
1415         * cp-namespace.c (cp_search_static_and_baseclasses): Only search
1416         for nested static variables when searchin VAR_DOMAIN.
1417         * dwarf2read.c (add_partial_symbol): Add nested subroutines to the
1418         global scope, update comment.
1419         (add_partial_subprogram): Call add_partial_subprogram recursively
1420         for nested subroutines when processinng Fortran.
1421         (load_partial_dies): Process the child entities of a subprogram
1422         when processing Fortran.
1423         (partial_die_parent_scope): Handle building scope
1424         for Fortran nested functions.
1425         (process_die): Record that nested functions have a scope.
1426         (new_symbol): Always record Fortran subprograms on the global
1427         symbol list.
1428         (determine_prefix): How to build the prefix for Fortran
1429         subprograms.
1430
1431 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1432
1433         * linux-nat.c (linux_nat_filter_event): Don't ignore SIGSTOP if we
1434         have just sent the thread a SIGSTOP and are waiting for it to
1435         arrive.
1436
1437 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1438
1439         * btrace.c (btrace_add_pc): Remove whitespace before the template
1440         parameter in 'std::vector <...>'.
1441         (parse_xml_btrace_block): Likewise.
1442         (btrace_maint_decode_pt): Likewise.
1443         (btrace_maint_update_packets): Likewise.
1444         (btrace_maint_print_packets): Likewise.
1445         * btrace.h (struct btrace_maint_info): Likewise.
1446         * dwarf2read.c (struct type_unit_group): Likewise.
1447         (build_type_psymtabs_reader): Likewise.
1448         * gdbsupport/btrace-common.c (btrace_data_append): Likewise.
1449         * gdbsupport/btrace-common.h (struct btrace_data_bts): Likewise.
1450         * nat/linux-btrace.c (perf_event_read_bts): Likewise.
1451
1452 2019-10-03  Tom de Vries  <tdevries@suse.de>
1453
1454         * cli/cli-style.c (_initialize_cli_style): Adding a '.' at the end of
1455         the first line of the help text for set/show style metadata.
1456
1457 2019-10-02  Tom Tromey  <tromey@adacore.com>
1458
1459         * Makefile.in (COMMON_SFILES): Add common-inferior.c.
1460         * gdbsupport/common-inferior.c: New file.
1461         * infcmd.c (startup_with_shell): Don't define.
1462         * nat/fork-inferior.h (startup_with_shell): Don't declare.
1463         * gdbsupport/common-inferior.h (startup_with_shell): Declare.
1464         * inferior.h (startup_with_shell): Don't declare.
1465
1466 2019-10-02  Christian Biesinger  <cbiesinger@google.com>
1467
1468         * gdbsupport/gdb_assert.h: Include errors.h.
1469         * gdbsupport/gdb_string_view.h: Include gdb_assert.h.
1470
1471 2019-10-02  Tom Tromey  <tromey@adacore.com>
1472
1473         * NEWS: Add $_ada_exception entry.
1474         * ada-lang.c (struct ada_catchpoint): Add constructor.
1475         <m_kind>: New member.
1476         (allocate_location_exception, re_set_exception): Remove
1477         "ex" parameter.
1478         (should_stop_exception): Compute $_ada_exception.
1479         (check_status_exception, print_it_exception)
1480         (print_one_exception, print_mention_exception): Remove
1481         "ex" parameter.
1482         (allocate_location_catch_exception, re_set_catch_exception)
1483         (check_status_exception, print_it_catch_exception)
1484         (print_one_catch_exception, print_mention_catch_exception)
1485         (print_recreate_catch_exception)
1486         (allocate_location_catch_exception_unhandled)
1487         (re_set_catch_exception_unhandled)
1488         (check_status_exception, print_it_catch_exception_unhandled)
1489         (print_one_catch_exception_unhandled)
1490         (print_mention_catch_exception_unhandled)
1491         (print_recreate_catch_exception_unhandled)
1492         (allocate_location_catch_assert, re_set_catch_assert)
1493         (check_status_assert, print_it_catch_assert)
1494         (print_one_catch_assert, print_mention_catch_assert)
1495         (print_recreate_catch_assert)
1496         (allocate_location_catch_handlers, re_set_catch_handlers)
1497         (check_status_handlers, print_it_catch_handlers)
1498         (print_one_catch_handlers, print_mention_catch_handlers)
1499         (print_recreate_catch_handlers): Remove.
1500         (create_ada_exception_catchpoint): Update.
1501         (initialize_ada_catchpoint_ops): Update.
1502
1503 2019-10-02  Tom Tromey  <tromey@adacore.com>
1504
1505         * ada-lang.c (ada_lookup_simple_minsyms): Remove.
1506         (create_excep_cond_exprs): Simplify exception string computation.
1507         (ada_exception_catchpoint_cond_string): Likewise.
1508
1509 2019-10-02  Tom Tromey  <tromey@adacore.com>
1510
1511         * symmisc.c (dump_msymbols): Don't use MSYMBOL_VALUE_ADDRESS.
1512         * ada-lang.c (lesseq_defined_than): Handle
1513         LOC_STATIC.
1514         * dwarf2read.c (dwarf2_per_objfile): Add can_copy
1515         parameter.
1516         (dwarf2_has_info): Likewise.
1517         (new_symbol): Set maybe_copied on symbol when
1518         appropriate.
1519         * dwarf2read.h (dwarf2_per_objfile): Add can_copy
1520         parameter.
1521         <can_copy>: New member.
1522         * elfread.c (record_minimal_symbol): Set maybe_copied
1523         on symbol when appropriate.
1524         (elf_symfile_read): Update call to dwarf2_has_info.
1525         * minsyms.c (lookup_minimal_symbol_linkage): New
1526         function.
1527         * minsyms.h (lookup_minimal_symbol_linkage): Declare.
1528         * symtab.c (get_symbol_address, get_msymbol_address):
1529         New functions.
1530         * symtab.h (get_symbol_address, get_msymbol_address):
1531         Declare.
1532         (SYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_ADDRESS): Handle
1533         maybe_copied.
1534         (struct symbol, struct minimal_symbol) <maybe_copied>:
1535         New member.
1536
1537 2019-10-02  Tom Tromey  <tromey@adacore.com>
1538
1539         * source.c (struct current_source_location): New.
1540         (current_source_key): New global.
1541         (current_source_symtab, current_source_line)
1542         (current_source_pspace): Remove.
1543         (get_source_location): New function.
1544         (get_current_source_symtab_and_line)
1545         (set_default_source_symtab_and_line)
1546         (set_current_source_symtab_and_line)
1547         (clear_current_source_symtab_and_line, select_source_symtab)
1548         (info_source_command, print_source_lines_base)
1549         (info_line_command, search_command_helper, _initialize_source):
1550         Update.
1551
1552 2019-10-02  Tom Tromey  <tromey@adacore.com>
1553
1554         * source.c (select_source_symtab): Don't call
1555         decode_line_with_current_source.
1556
1557 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1558
1559         * symtab.c (lookup_global_symbol): Search global block.
1560
1561 2019-10-02  Tom Tromey  <tromey@adacore.com>
1562
1563         * coffread.c (process_coff_symbol): Update.
1564         * dwarf2read.c (var_decode_location, new_symbol): Update.
1565         * mdebugread.c (parse_symbol): Update.
1566         * objfiles.c (relocate_one_symbol): Update.
1567         * stabsread.c (define_symbol, fix_common_block)
1568         (scan_file_globals): Update.
1569         * symtab.h (SYMBOL_VALUE_ADDRESS): Expand to an rvalue.
1570         (SET_SYMBOL_VALUE_ADDRESS): New macro.
1571         * xcoffread.c (process_xcoff_symbol): Update.
1572
1573 2019-10-02  Andreas Arnez  <arnez@linux.ibm.com>
1574
1575         * MAINTAINERS: Update my email address.
1576
1577 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1578
1579         * dwarf2read.c (struct type_unit_group) <tus>: Convert to
1580         std::vector.
1581         (build_type_psymtabs_reader): Update for std::vector.
1582         (build_type_psymtab_dependencies): Likewise.
1583         * dwarf2read.h: Remove use of DEF_VEC_P.
1584         (typedef sig_type_ptr): Delete.
1585
1586 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1587
1588         * btrace.c (btrace_maint_clear): Update to handle change from VEC
1589         to std::vector.
1590         (btrace_maint_decode_pt): Likewise, and move allocation of the
1591         vector outside of the loop.
1592         (btrace_maint_update_packets): Update to handle change from VEC to
1593         std::vector.
1594         (btrace_maint_print_packets): Likewise.
1595         (maint_info_btrace_cmd): Likewise.
1596         * btrace.h: Remove use of DEF_VEC_O.
1597         (typedef btrace_pt_packet_s): Delete.
1598         (struct btrace_maint_info) <packets>: Change fromm VEC to
1599         std::vector.
1600         * gdbsupport/btrace-common.h: Remove 'vec.h' include.
1601
1602 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1603
1604         * btrace.c (btrace_compute_ftrace_bts): Update for std::vector,
1605         make accesses into the vector constant references.
1606         (btrace_add_pc): Update for std::vector.
1607         (btrace_stitch_bts): Likewise.
1608         (parse_xml_btrace_block): Likewise.
1609         (btrace_maint_update_packets): Likewise.
1610         (btrace_maint_print_packets): Likewise.
1611         (maint_info_btrace_cmd): Likewise.
1612         * gdbsupport/btrace-common.c (btrace_data::fini): Update for
1613         std::vector.
1614         (btrace_data::empty): Likewise.
1615         (btrace_data_append): Likewise.
1616         * gdbsupport/btrace-common.h: Remove use of DEF_VEC_O.
1617         (typedef btrace_block_s): Delete.
1618         (struct btrace_block): Add constructor.
1619         (struct btrace_data_bts) <blocks>: Change to std::vector.
1620         * nat/linux-btrace.c (perf_event_read_bts): Update for
1621         std::vector.
1622         (linux_read_bts): Likewise.
1623
1624 2019-10-01  Tom Tromey  <tom@tromey.com>
1625
1626         * cli/cli-logging.c (show_logging_filename): Use styled_string.
1627
1628 2019-10-01  Tom Tromey  <tom@tromey.com>
1629
1630         * stack.c (print_frame, info_frame_command_core): Use
1631         styled_string.
1632         * linux-thread-db.c (try_thread_db_load_1)
1633         (try_thread_db_load_from_pdir_1): Use styled_string.
1634         * auto-load.c (file_is_auto_load_safe, execute_script_contents)
1635         (auto_load_section_scripts, info_auto_load_local_gdbinit)
1636         (maybe_print_unsupported_script_warning)
1637         (maybe_print_script_not_found_warning): Use styled_string.
1638         * ada-lang.c (user_select_syms): Use styled_string.
1639
1640 2019-10-01  Tom Tromey  <tom@tromey.com>
1641
1642         * p-lang.c (pascal_printstr): Use metadata style.
1643         * value.c (show_convenience): Use metadata style.
1644         * valprint.c (valprint_check_validity, val_print_optimized_out)
1645         (val_print_not_saved, val_print_unavailable)
1646         (val_print_invalid_address, generic_val_print, val_print)
1647         (value_check_printable, val_print_array_elements): Use metadata
1648         style.
1649         * ui-out.h (class ui_out) <field_fmt>: New overload.
1650         <do_field_fmt>: Add style parameter.
1651         * ui-out.c (ui_out::field_fmt): New overload.
1652         * typeprint.c (type_print_unknown_return_type)
1653         (val_print_not_allocated, val_print_not_associated): Use metadata
1654         style.
1655         * tui/tui-out.h (class tui_ui_out) <do_field_fmt>: Add style
1656         parameter.
1657         * tui/tui-out.c (tui_ui_out::do_field_fmt): Update.
1658         * tracepoint.c (tvariables_info_1): Use metadata style.
1659         * stack.c (print_frame_arg, print_frame_info, print_frame)
1660         (info_frame_command_core): Use metadata style.
1661         * skip.c (info_skip_command): Use metadata style.
1662         * rust-lang.c (rust_print_enum): Use metadata style.
1663         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
1664         metadata style.
1665         * python/py-framefilter.c (py_print_single_arg): Use metadata
1666         style.
1667         * printcmd.c (do_one_display, print_variable_and_value): Use
1668         metadata style.
1669         * p-valprint.c (pascal_val_print)
1670         (pascal_object_print_value_fields): Use metadata style.
1671         * p-typeprint.c (pascal_type_print_base): Use metadata style.
1672         * mi/mi-out.h (class mi_ui_out) <do_field_fmt>: Add style
1673         parameter.
1674         * mi/mi-out.c (mi_ui_out::do_field_fmt): Update.
1675         * m2-valprint.c (m2_print_long_set): Use metadata style.
1676         * m2-typeprint.c (m2_print_type): Use metadata style.
1677         * infcmd.c (print_return_value_1): Use metadata style.
1678         * gnu-v3-abi.c (print_one_vtable): Use metadata style.
1679         * f-valprint.c (info_common_command_for_block): Use metadata
1680         style.
1681         * f-typeprint.c (f_type_print_base): Use metadata style.
1682         * expprint.c (print_subexp_standard): Use metadata style.
1683         * cp-valprint.c (cp_print_value_fields): Use metadata style.
1684         * cli/cli-style.h (class cli_style_option): Add constructor.
1685         (metadata_style): Declare.
1686         * cli/cli-style.c (metadata_style): New global.
1687         (_initialize_cli_style): Register metadata style.
1688         * cli-out.h (class cli_ui_out) <do_field_fmt>: Add style
1689         parameter.
1690         * cli-out.c (cli_ui_out::do_field_fmt): Update.
1691         * c-typeprint.c (c_type_print_base_struct_union)
1692         (c_type_print_base_1): Use metadata style.
1693         * breakpoint.c (watchpoint_value_print)
1694         (print_one_breakpoint_location): Use metadata style.
1695         * break-catch-syscall.c (print_one_catch_syscall): Use metadata
1696         style.
1697         * break-catch-sig.c (signal_catchpoint_print_one): Use metadata
1698         style.
1699         * ada-valprint.c (val_print_packed_array_elements, printstr)
1700         (print_field_values, ada_val_print_ref, ada_val_print): Use
1701         metadata style.
1702         * ada-typeprint.c (print_array_type, ada_print_type): Use metadata
1703         style.
1704         * ada-tasks.c (print_ada_task_info, info_task): Use metadata
1705         style.
1706         * ada-lang.c (user_select_syms): Use metadata style.
1707
1708 2019-10-01  Tom Tromey  <tom@tromey.com>
1709
1710         * cli/cli-cmds.c (pwd_command): Style output.
1711
1712 2019-10-01  Pedro Alves  <palves@redhat.com>
1713             Tom Tromey  <tom@tromey.com>
1714
1715         * symtab.c (print_symbol_info): Use %ps.
1716         (print_msymbol_info): Use %ps.
1717         * symfile.c (symbol_file_add_with_addrs): Use %ps.
1718         * printcmd.c (print_variable_and_value): Use %ps.
1719         * macrocmd.c (show_pp_source_pos): Use %ps.
1720         * infrun.c (print_exited_reason): Use ui_out::message.
1721         * breakpoint.c (watchpoint_check, print_one_breakpoint_location)
1722         (describe_other_breakpoints): Use ui_out::message and new
1723         formats.
1724         (say_where): Use new formats.
1725         (bkpt_print_it, tracepoint_print_one_detail): Use ui_out::message
1726         and new formats.
1727
1728 2019-10-01  Pedro Alves  <palves@redhat.com>
1729             Tom Tromey  <tom@tromey.com>
1730
1731         * unittests/format_pieces-selftests.c: Add gdb_format parameter.
1732         (test_gdb_formats): New function.
1733         (run_tests): Call it.
1734         (test_format_specifier): Update.
1735         * utils.h (fputs_filtered): Update comment.
1736         (vfprintf_styled, vfprintf_styled_no_gdbfmt)
1737         (fputs_styled_unfiltered): Declare.
1738         * utils.c (fputs_styled_unfiltered): New function.
1739         (vfprintf_maybe_filtered): Add gdbfmt parameter.
1740         (vfprintf_filtered): Update.
1741         (vfprintf_unfiltered, vprintf_filtered): Update.
1742         (vfprintf_styled, vfprintf_styled_no_gdbfmt): New functions.
1743         * ui-out.h (enum ui_out_flag) <unfiltered_output,
1744         disallow_ui_out_field>: New constants.
1745         (enum class field_kind): New.
1746         (struct base_field_s, struct signed_field_s): New.
1747         (signed_field): New function.
1748         (struct string_field_s): New.
1749         (string_field): New function.
1750         (struct styled_string_s): New.
1751         (styled_string): New function.
1752         (class ui_out) <message>: Add comment.
1753         <vmessage, call_do_message>: New methods.
1754         <do_message>: Add style parameter.
1755         * ui-out.c (ui_out::call_do_message, ui_out::vmessage): New
1756         methods.
1757         (ui_out::message): Rewrite.
1758         * mi/mi-out.h (class mi_ui_out) <do_message>: Add style
1759         parameter.
1760         * mi/mi-out.c (mi_ui_out::do_message): Add style parameter.
1761         * gdbsupport/format.h (class format_pieces) <format_pieces>: Add
1762         gdb_extensions parameter.
1763         (class format_piece): Add parameter to constructor.
1764         (n_int_args): New field.
1765         * gdbsupport/format.c (format_pieces::format_pieces): Add
1766         gdb_extensions parameter.  Handle '*'.
1767         * cli-out.h (class cli_ui_out) <do_message>: Add style parameter.
1768         * cli-out.c (cli_ui_out::do_message): Add style parameter.  Call
1769         vfprintf_styled_no_gdbfmt.
1770         (cli_ui_out::do_field_string, cli_ui_out::do_spaces)
1771         (cli_ui_out::do_text, cli_ui_out::field_separator): Allow
1772         unfiltered output.
1773         * ui-style.h (struct ui_file_style) <ptr>: New method.
1774
1775 2019-10-01  Tom Tromey  <tom@tromey.com>
1776
1777         * unittests/format_pieces-selftests.c: Update.  Add final format.
1778         * gdbsupport/format.c (format_pieces::format_pieces): Don't add
1779         empty literal pieces.
1780
1781 2019-10-01  Tom Tromey  <tom@tromey.com>
1782
1783         * ui-out.h (enum class ui_out_style_kind): Remove.
1784         (class ui_out) <field_string, field_stsream, do_field_string>:
1785         Change type of "style".
1786         * ui-out.c (ui_out::field_core_addr, ui_out::field_stream)
1787         (ui_out::field_string): Update.
1788         * tui/tui-out.h (class tui_ui_out) <do_field_string>: Change type
1789         of "style".
1790         * tui/tui-out.c (tui_ui_out::do_field_string): Update.
1791         * tracepoint.c (print_one_static_tracepoint_marker): Update.
1792         * stack.c (print_frame_arg, print_frame_info, print_frame):
1793         Update.
1794         * source.c (print_source_lines_base): Update.
1795         * solib.c (info_sharedlibrary_command): Update.
1796         * skip.c (info_skip_command): Update.
1797         * record-btrace.c (btrace_call_history_src_line)
1798         (btrace_call_history): Update.
1799         * python/py-framefilter.c (py_print_frame): Update.
1800         * mi/mi-out.h (class mi_ui_out) <do_field_string>: Change type of
1801         "style".
1802         * mi/mi-out.c (mi_ui_out::do_table_header)
1803         (mi_ui_out::do_field_signed, mi_ui_out::do_field_unsigned)
1804         (mi_ui_out::do_field_string): Update.
1805         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
1806         Update.
1807         * cli-out.h (class cli_ui_out) <do_field_string>: Change type of
1808         "style".
1809         * cli-out.c (cli_ui_out::do_table_header)
1810         (cli_ui_out::do_field_signed, cli_ui_out::do_field_unsigned)
1811         (cli_ui_out::do_field_skip, cli_ui_out::do_field_string)
1812         (cli_ui_out::do_field_fmt): Update.
1813         * breakpoint.c (print_breakpoint_location): Update.
1814         (update_static_tracepoint): Update.
1815
1816 2019-10-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1817
1818         * main.c (relocate_gdbinit_path_maybe_in_datadir): Remove std::string
1819         conversion of gdb_datadir.
1820         (captured_main_1): Remove xstrdup when assigning to gdb_datadir,
1821         remove not needed c_str ().
1822
1823 2019-09-30  Ali Tamur <tamur@google.com>
1824
1825         * dwarf2read.c (skip_one_die): Handle DW_FORM_strx forms.
1826         (dwarf2_string_attr): Likewise.
1827
1828 2019-09-30  Ali Tamur <tamur@google.com>
1829
1830         * dwarf2read.c (process_full_comp_unit): Remove whitespace at the EOL.
1831         (process_full_type_unit): Likewise.
1832         (dump_die_shallow): Likewise.
1833         (cu_debug_loc_section): Likewise.
1834
1835 2019-09-28  Christian Biesinger  <cbiesinger@google.com>
1836
1837         * minsyms.c (compare_minimal_symbols): Rename to...
1838         (minimal_symbol_is_less_than): ...this, and adjust to STL
1839         conventions (return bool, take arguments as references)
1840         (minimal_symbol_reader::install): Call std::sort instead
1841         of qsort.
1842
1843 2019-09-29  Christian Biesinger  <cbiesinger@google.com>
1844
1845         * minsyms.h (msymbol_hash): Document that this is a case-insensitive
1846         hash and why.
1847         * objfiles.h (struct objfile_per_bfd_storage) <demangled_names_hash,
1848         msymbol_hash, msymbol_demangled_hash>: Improve comments.
1849
1850 2019-09-30  Simon Marchi  <simon.marchi@polymtl.ca>
1851
1852         * psymtab.c (add_psymbol_to_list): Move comment to psympriv.h.
1853         * psympriv.h (add_psymbol_to_list): Move comment here and update
1854         it.
1855
1856 2019-09-29  Tom de Vries  <tdevries@suse.de>
1857
1858         * contrib/cc-with-tweaks.sh (get_tmpdir): New function.
1859         Use $tmpdir/$(basename "$output_file").dwz instead of
1860         "${output_file}.dwz".
1861
1862 2019-09-28  Simon Marchi  <simon.marchi@polymtl.ca>
1863
1864         PR gdb/25045
1865         * hppa-linux-nat.c: Include gdbarch.h.
1866
1867 2019-09-26  Christian Biesinger  <cbiesinger@google.com>
1868
1869         * blockframe.c (find_pc_partial_function): Change return type to bool.
1870         * elfread.c (elf_gnu_ifunc_resolve_name): Likewise.
1871         * minsyms.c (in_gnu_ifunc_stub): Likewise.
1872         (stub_gnu_ifunc_resolve_name): Likewise.
1873         * symtab.c (compare_filenames_for_search): Likewise.
1874         (compare_glob_filenames_for_search): Likewise.
1875         (matching_obj_sections): Likewise.
1876         (symbol_matches_domain): Likewise.
1877         (find_line_symtab): Change out param EXACT_MATCH to bool *.
1878         (find_line_pc): Change return type to bool.
1879         (find_line_pc_range): Likewise.
1880         (producer_is_realview): Likewise.
1881         * symtab.h (symbol_matches_domain): Likewise.
1882         (find_pc_partial_function): Likewise.
1883         (find_pc_line_pc_range): Likewise.
1884         (in_gnu_ifunc_stub): Likewise.
1885         (struct gnu_ifunc_fns) <gnu_ifunc_resolve_name>: Likewise.
1886         (find_line_pc): Likewise.
1887         (find_line_pc_range): Likewise.
1888         (matching_obj_sections): Likewise.
1889         (find_line_symtab): Change out parameter to bool.
1890         (producer_is_realview): Change return type to bool.
1891         (compare_filenames_for_search): Likewise.
1892         (compare_glob_filenames_for_search): Likewise.
1893
1894 2019-09-26  Tom Tromey  <tom@tromey.com>
1895
1896         * Makefile.in (COMMON_SFILES): Remove gdb_usleep.c.
1897         (HFILES_NO_SRCDIR): Remove gdb_usleep.h.
1898         * gdb_usleep.h: Remove.
1899         * gdb_usleep.c: Remove.
1900         * utils.c: Don't include gdb_usleep.h.
1901
1902 2019-09-26  Tom Tromey  <tromey@adacore.com>
1903
1904         * python/py-type.c (type_to_type_object): Call check_typedef
1905         for stub types.
1906
1907 2019-09-26  Tom Tromey  <tom@tromey.com>
1908
1909         * utils.h (initialize_utils): Don't declare.
1910         * top.c (gdb_init): Don't call initialize_utils.
1911         * utils.c (initialize_utils): Remove.  Move contents...
1912         (_initialize_utils): ... here.
1913
1914 2019-09-25  Tom Tromey  <tom@tromey.com>
1915
1916         * python/py-objfile.c (objfpy_get_build_id): Use bin2hex.
1917         * utils.h (make_hex_string): Don't declare.
1918         * utils.c (make_hex_string): Remove.
1919
1920 2019-09-24  Tom de Vries  <tdevries@suse.de>
1921
1922         PR gdb/23815
1923         * amd64-linux-nat.c (amd64_linux_nat_target::fetch_registers):
1924         Initialize xstateregs before ptrace PTRACE_GETREGSET call.
1925
1926 2019-09-23  Dimitar Dimitrov  <dimitar@dinux.eu>
1927
1928         * NEWS: Mention new simulator port for PRU.
1929
1930 2019-09-23  Christian Biesinger  <cbiesinger@google.com>
1931
1932         * ada-exp.y (write_object_remaining): Update.
1933         * ada-lang.c (ada_decode): Return a std::string instead of a char*
1934         and eliminate the static buffer.
1935         (ada_decode_symbol): Update.
1936         (ada_la_decode): Update.
1937         (ada_sniff_from_mangled_name): Update.
1938         (is_valid_name_for_wild_match): Update.
1939         (ada_lookup_name_info::matches): Update and simplify.
1940         (name_matches_regex): Update.
1941         (ada_add_global_exceptions): Update.
1942         * ada-lang.h (ada_decode): Update signature.
1943         * ada-varobj.c (ada_varobj_describe_simple_array_child): Update.
1944         * dwarf-index-write.c (debug_names::insert): Update.
1945
1946 2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>
1947
1948         * solib-svr4.c (svr4_iterate_over_objfiles_in_search_order): Fix
1949         formatting.
1950
1951 2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>
1952
1953         * breakpoint.h (bp_location) <inserted, permanent, duplicate>:
1954         Change "nonzero" to "true" in documentation.
1955
1956 2019-09-20  Christian Biesinger  <cbiesinger@google.com>
1957
1958         * solib-darwin.c (darwin_lookup_lib_symbol): Remove.
1959         (_initialize_darwin_solib): Don't set
1960         darwin_so_ops.lookup_lib_global_symbol.
1961         * solib-svr4.c (set_solib_svr4_fetch_link_map_offsets): Call
1962         set_gdbarch_iterate_over_objfiles_in_search_order.
1963         (elf_lookup_lib_symbol): Rename to...
1964         (svr4_iterate_over_objfiles_in_search_order): this, and update
1965         to iterate semantics.
1966         (_initialize_svr4_solib): Don't set lookup_lib_global_symbol.
1967         * solib.c (solib_global_lookup): Remove.
1968         * solist.h (struct target_so_ops): Remove lookup_lib_global_symbol.
1969         (solib_global_lookup): Remove.
1970         * symtab.c (lookup_global_or_static_symbol): Remove call to
1971         solib_global_lookup.
1972
1973 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
1974
1975         * NEWS: Move entries about default MI version now being
1976         version 3, and about the GDB/MI fix for multi-location
1977         breakpoints to the "since GDB 8.3" section.
1978
1979 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
1980
1981         GDB 8.3.1 released.
1982
1983 2019-09-20  Ulrich Weigand  <uweigand@de.ibm.com>
1984
1985         * NEWS: Mention that Cell/B.E. debugging support was removed.
1986         * MAINTAINERS: Remove spu target.
1987
1988         * config/djgpp/fnchange.lst: Remove entries for removed files.
1989
1990         * Makefile.in (ALL_TARGET_OBS): Remove solib-spu.o,
1991         spu-multiarch.o, and spu-tdep.o.
1992         (HFILES_NO_SRCDIR): Remove solib-spu.h and spu-tdep.h.
1993         (ALLDEPFILES): Remove solib-spu.c, spu-linux-nat.c,
1994         spu-multiarch.c, and spu-tdep.c.
1995         * spu-linux-nat.c: Remove file.
1996         * spu-multiarch.c: Remove file.
1997         * spu-tdep.c: Remove file.
1998         * spu-tdep.h: Remove file.
1999         * solib-spu.c: Remove file.
2000         * solib-spu.h: Remove file.
2001
2002         * configure.host (powerpc64*-*-linux*): Remove Cell/B.E. support.
2003         * configure.nat (spu-linux): Remove.
2004         * configure.tgt (powerpc*-*-linux*): Remove solib-spu.o and
2005         solib-multiarch.o from gdb_target_obs.
2006         (spu*-*-*): Remove.
2007
2008         * arch/ppc-linux-common.h (struct ppc_linux_features): Remove "cell"
2009         feature flag.
2010         (ppc_linux_no_features): Update.
2011         * arch/ppc-linux-common.c (ppc_linux_match_description): Remove
2012         Cell/B.E. support.
2013         * arch/ppc-linux-tdesc.h (tdesc_powerpc_cell32l): Remove declaration.
2014         (tdesc_powerpc_cell64l): Likewise.
2015         * nat/ppc-linux.h (PPC_FEATURE_CELL): Remove.
2016         * ppc-linux-nat.c (ppc_linux_nat_target::read_description): Remove
2017         Cell/B.E. support.
2018         * ppc-linux-tdep.h: Do not include "solib-spu.h" or "spu-tdep.h".
2019         Do not include "features/rs6000/powerpc-cell32l.c" or
2020         "features/rs6000/powerpc-cell64l.c".
2021         (ppc_linux_spu_section): Remove.
2022         (ppc_linux_core_read_description): Remove Cell/B.E. support.
2023         (spe_context_objfile, spe_context_lm_addr, spe_context_offset,
2024         spe_context_cache_ptid, spe_context_cache_ptid): Remove.
2025         (ppc_linux_spe_context_lookup): Remove.
2026         (ppc_linux_spe_context_inferior_created): Remove.
2027         (ppc_linux_spe_context_solib_loaded): Remove.
2028         (ppc_linux_spe_context_solib_unloaded): Remove.
2029         (ppc_linux_spe_context): Remove.
2030         (struct ppu2spu_cache): Remove.
2031         (ppu2spu_prev_arch, ppu2spu_this_id, ppu2spu_prev_register): Remove.
2032         (struct ppu2spu_data): Remove.
2033         (ppu2spu_unwind_register, ppu2spu_sniffer, ppu2spu_dealloc_cache,
2034         ppu2spu_unwind): Remove.
2035         (ppc_linux_init_abi): Remove Cell/B.E. support.
2036         * rs6000-tdep.h (rs6000_gdbarch_init): Remove Cell/B.E. support.
2037
2038         * features/Makefile (rs6000/powerpc-cell32l-expedite): Remove.
2039         (rs6000/powerpc-cell64l-expedite): Likewise
2040         (WHICH): Remove rs6000/powerpc-cell32l and rs6000/powerpc-cell64l.
2041         (XMLTOC): Remove rs6000/powerpc-cell32l.xml and
2042         rs6000/powerpc-cell64l.xml.
2043         * features/rs6000/powerpc-cell32l.xml: Remove.
2044         * features/rs6000/powerpc-cell64l.xml: Likewise.
2045         * features/rs6000/powerpc-cell32l.c: Remove generated file.
2046         * features/rs6000/powerpc-cell64l.c: Likewise.
2047         * regformats/rs6000/powerpc-cell32l.dat: Remove generated file.
2048         * regformats/rs6000/powerpc-cell64l.dat: Likewise.
2049         * regformats/reg-spu.dat: Remove.
2050
2051         * target.h (enum target_object): Remove TARGET_OBJECT_SPU.
2052         * corelow.c (struct spuid_list): Remove.
2053         (add_to_spuid_list): Remove.
2054         (core_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
2055         * remote.c (PACKET_qXfer_spu_read, PACKET_qXfer_spu_write): Remove.
2056         (remote_protocol_features): Remove associated entries.
2057         (_initialize_remote): No longer initialize them.
2058         (remote_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
2059         * linux-nat.c (SPUFS_MAGIC): Remove.
2060         (linux_proc_xfer_spu): Remove.
2061         (spu_enumerate_spu_ids): Remove.
2062         (linux_nat_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
2063         * linux-tdep.c (-linux_spu_make_corefile_notes): Remove.
2064         (linux_make_corefile_notes): No longer call it.
2065
2066         * regcache.c (cooked_read_test): Remove bfd_arch_spu special case.
2067         (cooked_write_test): Likewise.
2068
2069 2019-09-20  Tom Tromey  <tom@tromey.com>
2070
2071         * NEWS: Mention case-sensitivity of TUI commands.
2072         * tui/tui-win.c (tui_set_focus_command): Now case-sensitive.
2073         (tui_set_win_height_command, parse_scrolling_args): Likewise.
2074         * tui/tui-layout.c (tui_layout_command): Now case-sensitive.
2075
2076 2019-09-20  Tom Tromey  <tom@tromey.com>
2077
2078         * tui/tui-source.c (tui_source_window::set_contents): Use
2079         make_unique_xstrdup.
2080         * tui/tui-disasm.c (tui_disasm_window::set_contents): Use
2081         make_unique_xstrdup.
2082
2083 2019-09-20  Tom Tromey  <tom@tromey.com>
2084
2085         * tui/tui-data.c: Remove separator comments.
2086         * tui/tui-layout.c: Remove separator comments.
2087         * tui/tui-win.c: Remove separator comments.
2088         * tui/tui-wingeneral.c: Remove separator comments.
2089
2090 2019-09-20  Tom Tromey  <tom@tromey.com>
2091
2092         * tui/tui.h (strcat_to_buf): Don't declare.
2093         * tui/tui.c (strcat_to_buf): Remove.
2094
2095 2019-09-20  Tom Tromey  <tom@tromey.com>
2096
2097         * tui/tui-source.h (struct tui_source_window) <m_fullname>: Rename
2098         from "fullname".
2099         * tui/tui-source.c (tui_source_window::set_contents)
2100         (tui_source_window::location_matches_p)
2101         (tui_source_window::maybe_update): Update.
2102
2103 2019-09-20  Tom Tromey  <tom@tromey.com>
2104
2105         * tui/tui-regs.h (struct tui_data_window) <get_current_group>:
2106         Update.
2107         <m_regs_content, m_regs_column_count, m_current_group>: Add "m_"
2108         prefix.
2109         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
2110         (tui_data_window::line_from_reg_element_no)
2111         (tui_data_window::first_reg_element_no_inline)
2112         (tui_data_window::show_registers)
2113         (tui_data_window::show_register_group)
2114         (tui_data_window::display_registers_from)
2115         (tui_data_window::display_registers_from_line)
2116         (tui_data_window::first_data_item_displayed)
2117         (tui_data_window::delete_data_content_windows)
2118         (tui_data_window::erase_data_content)
2119         (tui_data_window::do_scroll_vertical)
2120         (tui_data_window::refresh_window)
2121         (tui_data_window::check_register_values): Update.
2122
2123 2019-09-20  Tom Tromey  <tom@tromey.com>
2124
2125         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN): Remove define.
2126         (struct tui_locator_window) <full_name, proc_name>: Now
2127         std::string.
2128         * tui/tui-stack.c (tui_locator_window::make_status_line)
2129         (tui_locator_window::set_locator_fullname)
2130         (tui_locator_window::set_locator_info): Update.
2131         * tui/tui-source.c (tui_source_window::set_contents)
2132         (tui_source_window::showing_source_p): Update.
2133
2134 2019-09-20  Tom Tromey  <tom@tromey.com>
2135
2136         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
2137         Don't call tui_locator_win_info_ptr.
2138
2139 2019-09-20  Tom Tromey  <tom@tromey.com>
2140
2141         * tui/tui-win.c (tui_resize_all): Don't call refresh.
2142
2143 2019-09-20  Tom Tromey  <tom@tromey.com>
2144
2145         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use 1 as
2146         height for locator.
2147         * tui/tui-stack.c (tui_locator_window::rerender): Call scrollok.
2148         * tui/tui-layout.c (show_source_disasm_command, show_data)
2149         (show_source_or_disasm_and_command): Use 1 as height for locator.
2150
2151 2019-09-20  Tom Tromey  <tom@tromey.com>
2152
2153         * tui/tui.c (tui_enable): Update.
2154         * tui/tui-win.c (tui_sigwinch_handler, tui_async_resize_screen):
2155         Update.
2156         * tui/tui-data.h (tui_win_resized, tui_set_win_resized_to):
2157         Update.
2158         * tui/tui-data.c (win_resized): Now bool.
2159         (tui_win_resized): Return bool.
2160         (tui_set_win_resized_to): Accept a bool.
2161
2162 2019-09-20  Tom Tromey  <tom@tromey.com>
2163
2164         * tui/tui-regs.h (struct tui_data_window) <show_register_group>:
2165         Change type of "refresh_values_only".
2166         * tui/tui-regs.c (tui_data_window::show_register_group): Change
2167         type of "refresh_values_only".
2168
2169 2019-09-20  Tom Tromey  <tom@tromey.com>
2170
2171         * tui/tui-disasm.c (struct tui_asm_line) <addr_string, insn>: Now
2172         std::string.
2173         (tui_disassemble): Add "pos" parameter.
2174         (tui_disasm_window::set_contents): Simplify.
2175
2176 2019-09-20  Tom Tromey  <tom@tromey.com>
2177
2178         * tui/tui-winsource.h (struct tui_source_window_base)
2179         <show_source_content>: Now private.
2180         * tui/tui-winsource.c
2181         (tui_source_window_base::show_source_content): Don't handle empty
2182         content case.
2183
2184 2019-09-20  Tom Tromey  <tom@tromey.com>
2185
2186         * tui/tui-layout.c (show_source_disasm_command)
2187         (show_source_or_disasm_and_command): Don't call
2188         show_source_content.
2189
2190 2019-09-20  Tom Tromey  <tom@tromey.com>
2191
2192         * tui/tui-stack.h (struct tui_locator_window) <make_status_line>:
2193         Declare.
2194         * tui/tui-stack.c (tui_locator_window::make_status_line): Rename
2195         from tui_make_status_line.
2196         (tui_locator_window::rerender): Update.
2197
2198 2019-09-20  Tom Tromey  <tom@tromey.com>
2199
2200         * tui/tui-stack.c (tui_make_status_line): Return std::string.
2201         (tui_locator_window::rerender): Update.
2202
2203 2019-09-20  Tom Tromey  <tom@tromey.com>
2204
2205         * tui/tui-winsource.h (struct tui_source_window_base)
2206         <~tui_source_window_base>: Don't declare.
2207         <fullname>: Remove.
2208         * tui/tui-winsource.c (~tui_source_window_base): Remove.
2209         * tui/tui-source.h (struct tui_source_window) <fullname>: New
2210         member.
2211         * tui/tui-source.c (tui_source_window::set_contents): Update.
2212         (tui_source_window::location_matches_p)
2213         (tui_source_window::maybe_update): Update.
2214
2215 2019-09-20  Tom Tromey  <tom@tromey.com>
2216
2217         * tui/tui-winsource.h (~tui_source_element): Remove.
2218         (tui_source_element): Update.
2219         (struct tui_source_element) <line>: Now a unique_xmalloc_ptr.
2220         * tui/tui-winsource.c (tui_show_source_line): Update.
2221         * tui/tui-source.c (tui_source_window::set_contents): Update.
2222         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
2223
2224 2019-09-20  Tom Tromey  <tom@tromey.com>
2225
2226         * tui/tui-data.h (tui_clear_source_windows_detail): Don't
2227         declare.
2228         * tui/tui-layout.c (tui_add_win_to_layout): Don't call
2229         tui_clear_source_windows_detail.
2230         * tui/tui-winsource.h (struct tui_source_window_base)
2231         <clear_detail>: Don't declare.
2232         * tui/tui-winsource.c (tui_source_window_base::clear_detail):
2233         Remove.
2234         * tui/tui-data.c (tui_clear_source_windows_detail): Remove.
2235
2236 2019-09-20  Tom Tromey  <tromey@adacore.com>
2237
2238         PR ada/24919:
2239         * block.c (contained_in): Fix final return value.
2240
2241 2019-09-20  Alan Modra  <amodra@gmail.com>
2242
2243         * gdb_bfd.c (gdb_bfd_ref, gdb_bfd_unref): Use bfd_set_usrdata.
2244         * dwarf2read.c (dwarf2_read_gdb_index, dwarf2_read_debug_names),
2245         (read_indirect_string_from_dwz): Use bfd accessor.
2246         * dwarf2read.h (struct dwz_file <filename>): Likewise.
2247         * machoread.c (macho_symfile_read_all_oso): Likewise.
2248         * solib.c (solib_bfd_open): Likewise.
2249
2250 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
2251
2252         * eval.c: Move declaration of overload_resolution to...
2253         * value.h: ...here.
2254
2255 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
2256
2257         * arm-linux-nat.c: Remove extern declaration for arm_apcs_32.
2258         * arm-linux-tdep.c: Likewise.
2259         * arm-nbsd-nat.c: Likewise.
2260         * arm-tdep.h: Declare arm_apcs_32.
2261         * arm-tdep.c: Move documentation for arm_apcs_32 to arm-tdep.h.
2262
2263 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
2264
2265         * dwarf2loc.c: Remove extern declaration of dwarf_always_disassemble.
2266         * dwarf2read.h: Declare dwarf_always_disassemble.
2267
2268 2019-09-19  Tom de Vries  <tdevries@suse.de>
2269
2270         PR gdb/25009
2271         * source-cache.c (source_cache::ensure): Catch exception thrown during
2272         construction of the highlighter.
2273
2274 2019-09-18  Alan Modra  <amodra@gmail.com>
2275
2276         * aarch64-linux-tdep.c, * arm-tdep.c, * auto-load.c,
2277         * coff-pe-read.c, * coffread.c, * corelow.c, * dbxread.c,
2278         * dicos-tdep.c, * dwarf2-frame.c, * dwarf2read.c, * elfread.c,
2279         * exec.c, * fbsd-tdep.c, * gcore.c, * gdb_bfd.c, * gdb_bfd.h,
2280         * hppa-tdep.c, * i386-cygwin-tdep.c, * i386-fbsd-tdep.c,
2281         * i386-linux-tdep.c, * jit.c, * linux-tdep.c, * machoread.c,
2282         * maint.c, * mdebugread.c, * minidebug.c, * mips-linux-tdep.c,
2283         * mips-sde-tdep.c, * mips-tdep.c, * mipsread.c, * nto-tdep.c,
2284         * objfiles.c, * objfiles.h, * osabi.c, * ppc-linux-tdep.c,
2285         * ppc64-tdep.c, * record-btrace.c, * record-full.c, * remote.c,
2286         * rs6000-aix-tdep.c, * rs6000-tdep.c, * s390-linux-tdep.c,
2287         * s390-tdep.c, * solib-aix.c, * solib-dsbt.c, * solib-frv.c,
2288         * solib-spu.c, * solib-svr4.c, * solib-target.c,
2289         * spu-linux-nat.c, * spu-tdep.c, * symfile-mem.c, * symfile.c,
2290         * symmisc.c, * symtab.c, * target.c, * windows-nat.c,
2291         * xcoffread.c, * cli/cli-dump.c, * compile/compile-object-load.c,
2292         * mi/mi-interp.c: Update throughout for bfd section macro and
2293         function changes.
2294         * gcore (gcore_create_callback): Use bfd_set_section_lma.
2295         * spu-tdep.c (spu_overlay_new_objfile): Likewise.
2296
2297 2019-09-18  Tom Tromey  <tom@tromey.com>
2298
2299         * NEWS: Add entry.
2300         * tui/tui.c (tui_initialize_readline): Set name of keymap.  Do not
2301         call rl_initialize.
2302         (tui_enable): Do not call rl_initialize.
2303
2304 2019-09-18  Christian Groessler  <chris@groessler.org>
2305
2306         * alpha-linux-nat.c: Include gdbarch.h.
2307
2308 2019-09-18  Simon Marchi  <simon.marchi@polymtl.ca>
2309
2310         * ui-file.c: Include cli/cli-style.h.
2311         (term_cli_styling): Remove cli_styling declaration.
2312
2313 2019-09-18  Alan Modra  <amodra@gmail.com>
2314
2315         * arm-tdep.c (arm_record_special_symbol): Update bfd_get_section
2316         to bfd_asymbol_section.
2317
2318 2019-09-18  Alan Modra  <amodra@gmail.com>
2319
2320         * amd64-dicos-tdep.c (amd64_dicos_osabi_sniffer): Constify target.
2321         * i386-cygwin-tdep.c (i386_cygwin_init_abi): Likewise.
2322         * i386-dicos-tdep.c (i386_dicos_osabi_sniffer): Likewise.
2323
2324 2019-09-18  Alan Modra  <amodra@gmail.com>
2325
2326         * solib-spu.c (spu_bfd_open): Use bfd_set_filename.
2327         * spu-linux-nat.c (spu_bfd_open): Likewise.
2328
2329 2019-09-18  Christian Biesinger  <cbiesinger@google.com>
2330
2331         * dwarf2loc.c: Change extern declaration of dwarf_always_disassemble
2332         to bool to match definition in dwarf2read.c.
2333
2334 2019-09-17  Christian Biesinger  <cbiesinger@google.com>
2335
2336         * ada-lang.c (ada_ignore_descriptive_types_p): Change to bool.
2337         (print_signatures): Likewise.
2338         (trust_pad_over_xvs): Likewise.
2339         * arch/aarch64-insn.c (aarch64_debug): Likewise.
2340         * arch/aarch64-insn.h (aarch64_debug): Likewise.
2341         * arm-linux-nat.c (arm_apcs_32): Likewise.
2342         * arm-linux-tdep.c (arm_apcs_32): Likewise.
2343         * arm-nbsd-nat.c (arm_apcs_32): Likewise.
2344         * arm-tdep.c (arm_debug): Likewise.
2345         (arm_apcs_32): Likewise.
2346         * auto-load.c (debug_auto_load): Likewise.
2347         (auto_load_gdb_scripts): Likewise.
2348         (global_auto_load): Likewise.
2349         (auto_load_local_gdbinit): Likewise.
2350         (auto_load_local_gdbinit_loaded): Likewise.
2351         * auto-load.h (global_auto_load): Likewise.
2352         (auto_load_local_gdbinit): Likewise.
2353         (auto_load_local_gdbinit_loaded): Likewise.
2354         * breakpoint.c (disconnected_dprintf): Likewise.
2355         (breakpoint_proceeded): Likewise.
2356         (automatic_hardware_breakpoints): Likewise.
2357         (always_inserted_mode): Likewise.
2358         (target_exact_watchpoints): Likewise.
2359         (_initialize_breakpoint): Update.
2360         * breakpoint.h (target_exact_watchpoints): Change to bool.
2361         * btrace.c (maint_btrace_pt_skip_pad): Likewise.
2362         * cli/cli-cmds.c (trace_commands): Likewise.
2363         * cli/cli-cmds.h (trace_commands): Likewise.
2364         * cli/cli-decode.c (add_setshow_boolean_cmd): Change int* argument
2365         to bool*.
2366         * cli/cli-logging.c (logging_overwrite): Change to bool.
2367         (logging_redirect): Likewise.
2368         (debug_redirect): Likewise.
2369         * cli/cli-option.h (option_def) <boolean>: Change return type to bool*.
2370         (struct boolean_option_def) <get_var_address_cb_>: Change return type
2371         to bool.
2372         <boolean_option_def>: Update.
2373         (struct flag_option_def): Change default type of Context to bool
2374         from int.
2375         <flag_option_def>: Change return type of var_address_cb_ to bool*.
2376         * cli/cli-setshow.c (do_set_command): Cast to bool* instead of int*.
2377         (get_setshow_command_value_string): Likewise.
2378         * cli/cli-style.c (cli_styling): Change to bool.
2379         (source_styling): Likewise.
2380         * cli/cli-style.h (source_styling): Likewise.
2381         (cli_styling): Likewise.
2382         * cli/cli-utils.h (struct qcs_flags) <quiet, cont, silent>: Change
2383         to bool.
2384         * command.h (var_types): Update comment.
2385         (add_setshow_boolean_cmd): Change int* var argument to bool*.
2386         * compile/compile-cplus-types.c (debug_compile_cplus_types): Change to
2387         bool.
2388         (debug_compile_cplus_scopes): Likewise.
2389         * compile/compile-internal.h (compile_debug): Likewise.
2390         * compile/compile.c (compile_debug): Likewise.
2391         (struct compile_options) <raw>: Likewise.
2392         * cp-support.c (catch_demangler_crashes): Likewise.
2393         * cris-tdep.c (usr_cmd_cris_version_valid): Likewise.
2394         (usr_cmd_cris_dwarf2_cfi): Likewise.
2395         * csky-tdep.c (csky_debug): Likewise.
2396         * darwin-nat.c (enable_mach_exceptions): Likewise.
2397         * dcache.c (dcache_enabled_p): Likewise.
2398         * defs.h (info_verbose): Likewise.
2399         * demangle.c (demangle): Likewise.
2400         (asm_demangle): Likewise.
2401         * dwarf-index-cache.c (debug_index_cache): Likewise.
2402         * dwarf2-frame.c (dwarf2_frame_unwinders_enabled_p): Likewise.
2403         * dwarf2-frame.h (dwarf2_frame_unwinders_enabled_p): Likewise.
2404         * dwarf2read.c (check_physname): Likewise.
2405         (use_deprecated_index_sections): Likewise.
2406         (dwarf_always_disassemble): Likewise.
2407         * eval.c (overload_resolution): Likewise.
2408         * event-top.c (set_editing_cmd_var): Likewise.
2409         (exec_done_display_p): Likewise.
2410         * event-top.h (set_editing_cmd_var): Likewise.
2411         (exec_done_display_p): Likewise.
2412         * exec.c (write_files): Likewise.
2413         * fbsd-nat.c (debug_fbsd_lwp): Likewise
2414         (debug_fbsd_nat): Likewise.
2415         * frame.h (struct frame_print_options) <print_raw_frame_arguments>:
2416         Likewise.
2417         (struct set_backtrace_options) <backtrace_past_main>: Likewise.
2418         <backtrace_past_entry> Likewise.
2419         * gdb-demangle.h (demangle): Likewise.
2420         (asm_demangle): Likewise.
2421         * gdb_bfd.c (bfd_sharing): Likewise.
2422         * gdbcore.h (write_files): Likewise.
2423         * gdbsupport/common-debug.c (show_debug_regs): Likewise.
2424         * gdbsupport/common-debug.h (show_debug_regs): Likewise.
2425         * gdbthread.h (print_thread_events): Likewise.
2426         * gdbtypes.c (opaque_type_resolution): Likewise.
2427         (strict_type_checking): Likewise.
2428         * gnu-nat.c (gnu_debug_flag): Likewise.
2429         * guile/scm-auto-load.c (auto_load_guile_scripts): Likewise.
2430         * guile/scm-param.c (pascm_variable): Add boolval.
2431         (add_setshow_generic): Update.
2432         (pascm_param_value): Update.
2433         (pascm_set_param_value_x): Update.
2434         * hppa-tdep.c (hppa_debug): Change to bool..
2435         * infcall.c (may_call_functions_p): Likewise.
2436         (coerce_float_to_double_p): Likewise.
2437         (unwind_on_signal_p): Likewise.
2438         (unwind_on_terminating_exception_p): Likewise.
2439         * infcmd.c (startup_with_shell): Likewise.
2440         * inferior.c (print_inferior_events): Likewise.
2441         * inferior.h (startup_with_shell): Likewise.
2442         (print_inferior_events): Likewise.
2443         * infrun.c (step_stop_if_no_debug): Likewise.
2444         (detach_fork): Likewise.
2445         (debug_displaced): Likewise.
2446         (disable_randomization): Likewise.
2447         (non_stop): Likewise.
2448         (non_stop_1): Likewise.
2449         (observer_mode): Likewise.
2450         (observer_mode_1): Likewise.
2451         (set_observer_mode): Update.
2452         (sched_multi): Change to bool.
2453         * infrun.h (debug_displaced): Likewise.
2454         (sched_multi): Likewise.
2455         (step_stop_if_no_debug): Likewise.
2456         (non_stop): Likewise.
2457         (disable_randomization): Likewise.
2458         * linux-tdep.c (use_coredump_filter): Likewise.
2459         (dump_excluded_mappings): Likewise.
2460         * linux-thread-db.c (auto_load_thread_db): Likewise.
2461         (check_thread_db_on_load): Likewise.
2462         * main.c (captured_main_1): Update.
2463         * maint-test-options.c (struct test_options_opts) <flag_opt, xx1_opt,
2464         xx2_opt, boolean_opt>: Change to bool.
2465         * maint-test-settings.c (maintenance_test_settings_boolean): Likewise.
2466         * maint.c (maintenance_profile_p): Likewise.
2467         (per_command_time): Likewise.
2468         (per_command_space): Likewise.
2469         (per_command_symtab): Likewise.
2470         * memattr.c (inaccessible_by_default): Likewise.
2471         * mi/mi-main.c (mi_async): Likewise.
2472         (mi_async_1): Likewise.
2473         * mips-tdep.c (mips64_transfers_32bit_regs_p): Likewise.
2474         * nat/fork-inferior.h (startup_with_shell): Likewise.
2475         * nat/linux-namespaces.c (debug_linux_namespaces): Likewise.
2476         * nat/linux-namespaces.h (debug_linux_namespaces): Likewise.
2477         * nios2-tdep.c (nios2_debug): Likewise.
2478         * or1k-tdep.c (or1k_debug): Likewise.
2479         * parse.c (parser_debug): Likewise.
2480         * parser-defs.h (parser_debug): Likewise.
2481         * printcmd.c (print_symbol_filename): Likewise.
2482         * proc-api.c (procfs_trace): Likewise.
2483         * python/py-auto-load.c (auto_load_python_scripts): Likewise.
2484         * python/py-param.c (union parmpy_variable): Add "bool boolval" field.
2485         (set_parameter_value): Update.
2486         (add_setshow_generic): Update.
2487         * python/py-value.c (copy_py_bool_obj): Change argument from int*
2488         to bool*.
2489         * python/python.c (gdbpy_parameter_value): Cast to bool* instead of
2490         int*.
2491         * ravenscar-thread.c (ravenscar_task_support): Change to bool.
2492         * record-btrace.c (record_btrace_target::store_registers): Update.
2493         * record-full.c (record_full_memory_query): Change to bool.
2494         (record_full_stop_at_limit): Likewise.
2495         * record-full.h (record_full_memory_query): Likewise.
2496         * remote-notif.c (notif_debug): Likewise.
2497         * remote-notif.h (notif_debug): Likewise.
2498         * remote.c (use_range_stepping): Likewise.
2499         (interrupt_on_connect): Likewise.
2500         (remote_break): Likewise.
2501         * ser-tcp.c (tcp_auto_retry): Likewise.
2502         * ser-unix.c (serial_hwflow): Likewise.
2503         * skip.c (debug_skip): Likewise.
2504         * solib-aix.c (solib_aix_debug): Likewise.
2505         * spu-tdep.c (spu_stop_on_load_p): Likewise.
2506         (spu_auto_flush_cache_p): Likewise.
2507         * stack.c (struct backtrace_cmd_options) <full, no_filters, hide>:
2508         Likewise.
2509         (struct info_print_options) <quiet>: Likewise.
2510         * symfile-debug.c (debug_symfile): Likewise.
2511         * symfile.c (auto_solib_add): Likewise.
2512         (separate_debug_file_debug): Likewise.
2513         * symfile.h (auto_solib_add): Likewise.
2514         (separate_debug_file_debug): Likewise.
2515         * symtab.c (basenames_may_differ): Likewise.
2516         (struct filename_partial_match_opts) <dirname, basename>: Likewise.
2517         (struct info_print_options) <quiet, exclude_minsyms>: Likewise.
2518         (struct info_types_options) <quiet>: Likewise.
2519         * symtab.h (demangle): Likewise.
2520         (basenames_may_differ): Likewise.
2521         * target-dcache.c (stack_cache_enabled_1): Likewise.
2522         (code_cache_enabled_1): Likewise.
2523         * target.c (trust_readonly): Likewise.
2524         (may_write_registers): Likewise.
2525         (may_write_memory): Likewise.
2526         (may_insert_breakpoints): Likewise.
2527         (may_insert_tracepoints): Likewise.
2528         (may_insert_fast_tracepoints): Likewise.
2529         (may_stop): Likewise.
2530         (auto_connect_native_target): Likewise.
2531         (target_stop_and_wait): Update.
2532         (target_async_permitted): Change to bool.
2533         (target_async_permitted_1): Likewise.
2534         (may_write_registers_1): Likewise.
2535         (may_write_memory_1): Likewise.
2536         (may_insert_breakpoints_1): Likewise.
2537         (may_insert_tracepoints_1): Likewise.
2538         (may_insert_fast_tracepoints_1): Likewise.
2539         (may_stop_1): Likewise.
2540         * target.h (target_async_permitted): Likewise.
2541         (may_write_registers): Likewise.
2542         (may_write_memory): Likewise.
2543         (may_insert_breakpoints): Likewise.
2544         (may_insert_tracepoints): Likewise.
2545         (may_insert_fast_tracepoints): Likewise.
2546         (may_stop): Likewise.
2547         * thread.c (struct info_threads_opts) <show_global_ids>: Likewise.
2548         (make_thread_apply_all_options_def_group): Change argument from int*
2549         to bool*.
2550         (thread_apply_all_command): Update.
2551         (print_thread_events): Change to bool.
2552         * top.c (confirm): Likewise.
2553         (command_editing_p): Likewise.
2554         (history_expansion_p): Likewise.
2555         (write_history_p): Likewise.
2556         (info_verbose): Likewise.
2557         * top.h (confirm): Likewise.
2558         (history_expansion_p): Likewise.
2559         * tracepoint.c (disconnected_tracing): Likewise.
2560         (circular_trace_buffer): Likewise.
2561         * typeprint.c (print_methods): Likewise.
2562         (print_typedefs): Likewise.
2563         * utils.c (debug_timestamp): Likewise.
2564         (sevenbit_strings): Likewise.
2565         (pagination_enabled): Likewise.
2566         * utils.h (sevenbit_strings): Likewise.
2567         (pagination_enabled): Likewise.
2568         * valops.c (overload_resolution): Likewise.
2569         * valprint.h (struct value_print_options) <prettyformat_arrays,
2570         prettyformat_structs, vtblprint, unionprint, addressprint, objectprint,
2571         stop_print_at_null, print_array_indexes, deref_ref, static_field_print,
2572         pascal_static_field_print, raw, summary, symbol_print, finish_print>:
2573         Likewise.
2574         * windows-nat.c (new_console): Likewise.
2575         (cygwin_exceptions): Likewise.
2576         (new_group): Likewise.
2577         (debug_exec): Likewise.
2578         (debug_events): Likewise.
2579         (debug_memory): Likewise.
2580         (debug_exceptions): Likewise.
2581         (useshell): Likewise.
2582         * windows-tdep.c (maint_display_all_tib): Likewise.
2583         * xml-support.c (debug_xml): Likewise.
2584
2585 2019-09-17  Mike Gulick  <mgulick@mathworks.com>
2586
2587         * source.c (prepare_path_for_appending): New function.
2588         (openp): Make use of new function.
2589         (find_and_open_source): Search for the compilation directory and
2590         source file as a relative path beneath the directory search path.
2591
2592 2019-09-17  Andrew Burgess  <andrew.burgess@embecosm.com>
2593
2594         * source-cache.c (source_cache::get_line_charpos): Catch
2595         exceptions and return false, this matches the behaviour documented
2596         in the header file.
2597
2598 2019-09-17  Joel Brobecker  <brobecker@adacore.com>
2599
2600         * ada-tasks.c (info_task): Remove quoting of the task's name.
2601
2602 2019-09-16  Christian Biesinger  <cbiesinger@google.com>
2603
2604         * symfile.c (auto_solib_add): Replace comment with a reference
2605         to the header file.
2606
2607 2019-09-14  Christian Biesinger  <cbiesinger@google.com>
2608
2609         * NEWS: Mention that gdb can now be compiled with Python 3
2610         on Windows.
2611
2612 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2613
2614         * maint.c (maint_print_section_data::maint_print_section_data):
2615         Force use of 'float log10 (float)' by casting the argument to
2616         float.
2617
2618 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2619
2620         * maint.c: Add 'cmath' include.
2621         (struct maint_print_section_data): New structure.
2622         (print_section_index): New function.
2623         (print_bfd_section_info): Add header comment, small whitespace
2624         cleanup, and update to call new print_section_index function.
2625         (print_objfile_section_info): Likewise.
2626         (maint_obj_section_from_bfd_section): New function.
2627         (print_bfd_section_info_maybe_relocated): New function.
2628         (maintenance_info_sections): Add header comment, always use
2629         bfd_map_over_sections instead of ALL_OBJFILE_OSECTIONS.
2630
2631 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2632
2633         * psymtab.c (find_pc_sect_psymtab): Move baseaddr local into more
2634         inner scope, add check that the objfile has psymtabs before
2635         checking psymtabs_addrmap.
2636         * psymtab.h (psymtab_storage) <psymtabs_addrmap>: Extend comment.
2637
2638 2019-09-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2639
2640         * NEWS: Announce that Ada task names are now shown at more places,
2641         and between quotes (except in info task output).
2642         * gdb/ada-tasks.c (task_to_str): New function.
2643         (display_current_task_id): Call task_to_str.
2644         (task_command_1): Likewise.
2645         (print_ada_task_info): In non-mi mode, Properly align headers and data
2646         when task-id length is > 9 (9 is the default for a 32 bits CORE_ADDR).
2647
2648 2019-09-12  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
2649
2650         * procfs.c (procfs_target::wait) <PR_FAULTED>: Get signal from
2651         prstatus.pr_lwp.pr_info instead of making it up.
2652
2653 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
2654
2655         * auto-load.c (auto_load_expand_dir_vars): Update.
2656         * defs.h (gdb_datadir): Change to std::string.
2657         (python_libdir): Likewise.
2658         (relocate_gdb_directory): Change return type to std::string.
2659         * guile/guile.c (gdbscm_data_directory): Update.
2660         (initialize_scheme_side): Update.
2661         * jit.c (jit_reader_dir): Change to std::string.
2662         (jit_reader_load_command): Update.
2663         * main.c (gdb_datadir): Change to std::string.
2664         (python_libdir): Likewise.
2665         (set_gdb_data_directory): Update.
2666         (relocate_path): Change to return std::string.
2667         (relocate_gdb_directory): Change to return std::string.
2668         (relocate_gdbinit_path_maybe_in_datadir): Update.
2669         (captured_main_1): Update.
2670         * python/python.c (do_start_initialization): Update.
2671         * top.c (show_gdb_datadir): Update.
2672         * xml-syscall.c (xml_init_syscalls_info): Update.
2673         (init_syscalls_info): Update.
2674
2675 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
2676
2677         * main.c (relocate_gdbinit_path_maybe_in_datadir): Factor this code
2678         out of get_init_files.
2679         (get_init_files): Update.
2680
2681 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
2682
2683         * main.c (get_init_files): Change to use std::string.
2684         (captured_main_1): Update.
2685         (print_gdb_help): Update.
2686
2687 2019-09-11  Ali Tamur  <tamur@google.com>
2688
2689         *gdb/target-float.c (host_float_ops<T>::to_longest): Update
2690         implementation.
2691
2692 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
2693
2694         * dbxread.c (read_dbx_symtab): Update.
2695         * dwarf2read.c (load_partial_dies): Update.
2696         * mdebugread.c (parse_partial_symbols): Update.
2697         (handle_psymbol_enumerators): Update.
2698         * psympriv.h (add_psymbol_to_list): Change type of copy_names to bool.
2699         * psymtab.c (add_psymbol_to_bcache): Likewise.
2700         (add_psymbol_to_list): Likewise.
2701         * symtab.c (symbol_set_names): Likewise.
2702         * symtab.h (symbol_set_names): Likewise.
2703         * xcoffread.c (scan_xcoff_symtab): Update.
2704
2705 2019-09-11  Tom Tromey  <tom@tromey.com>
2706
2707         * symfile-mem.c (symbol_file_add_from_memory): Use
2708         bfd_set_filename.
2709         * solib-darwin.c (darwin_bfd_open): Use bfd_set_filename.
2710         * solib-aix.c (solib_aix_bfd_open): Use bfd_set_filename.
2711
2712 2019-09-10  Tom Tromey  <tromey@adacore.com>
2713
2714         * dwarf-index-write.c (write_psymbols): Extend error message.
2715         (debug_names::insert): Add Ada code.
2716         (debug_names::write_psymbols): Remove Ada check.
2717         (debug_names) <m_string_obstack>: New member.
2718         * dwarf2read.c (gdb_index_symbol_name_matcher): Remove.
2719         (gdb_index_symbol_name_matcher::matches): Remove.
2720         (mapped_index_base::find_name_components_bounds): Add "lang"
2721         parameter.
2722         (mapped_index_base::build_name_components): Also split names
2723         according to Ada syntax.
2724         (dw2_expand_symtabs_matching_symbol): Loop over languages.  Change
2725         type of "match_callback".
2726         (check_match, check_find_bounds_finds)
2727         (dw2_expand_symtabs_matching): Update.
2728         (dw2_debug_names_iterator): Add new constructor.
2729         (dw2_debug_names_map_matching_symbols): New function.
2730         (dw2_debug_names_expand_symtabs_matching): Update.
2731         (dwarf2_debug_names_functions): Use
2732         dw2_debug_names_map_matching_symbols.
2733
2734 2019-09-10  Tom Tromey  <tromey@adacore.com>
2735
2736         * dwarf2read.c (dw2_get_file_names_reader): Add the
2737         CU's file name to the results.
2738
2739 2019-09-10  Tom Tromey  <tromey@adacore.com>
2740
2741         * ada-lang.c (add_nonlocal_symbols): Combine calls to
2742         map_matching_symbols.  Update.
2743         * dwarf2read.c (dw2_map_matching_symbols): Update.
2744         * psymtab.c (match_partial_symbol): Change type; update.
2745         (psym_map_matching_symbols): Likewise.
2746         * symfile-debug.c (debug_qf_map_matching_symbols): Change
2747         type; update.
2748         * symfile.h (struct quick_symbol_functions)
2749         <map_matching_symbols>: Change "name" to be a lookup_name_info.
2750         Remove "match".
2751
2752 2019-09-10  Tom Tromey  <tromey@adacore.com>
2753
2754         * psymtab.c (map_block): Remove.
2755         (psym_map_matching_symbols): Use iterate_over_symbols_terminated.
2756         * symtab.c (iterate_over_symbols_terminated): New function.
2757         * symtab.c (iterate_over_symbols_terminated): Declare.
2758
2759 2019-09-10  Tom Tromey  <tromey@adacore.com>
2760
2761         * ada-lang.c (ada_iterate_over_symbols): Return bool.
2762         * language.h (struct language_defn) <la_iterate_over_symbols>:
2763         Return bool.
2764         * symtab.c (iterate_over_symbols): Return bool.
2765         * symtab.h (iterate_over_symbols): Return bool.
2766
2767 2019-09-10  Tom Tromey  <tromey@adacore.com>
2768
2769         * ada-lang.c (aux_add_nonlocal_symbols): Change type.
2770         (add_nonlocal_symbols): Update.
2771         * dwarf2read.c (dw2_map_matching_symbols): Change type.
2772         * psymtab.c (map_block, psym_map_matching_symbols): Change type.
2773         * symfile-debug.c (debug_qf_map_matching_symbols): Change type.
2774         * symfile.h (struct quick_symbol_functions) <map_matching_symbols>:
2775         Change type of "callback".  Remove "data".
2776
2777
2778 2019-09-09  Ali Tamur  <tamur@google.com>
2779
2780         * dwarf2read.c (comp_unit_head): Update comment.
2781         (dwarf2_dwo_name): New function declaration.
2782         (dwarf_unit_type_name): New function declaration.
2783         (read_comp_unit_head): Add support for new compilation units,
2784         DW_UT_partial, DW_UT_skeleton, DW_UT_split_compile, DW_UT_split_type.
2785         Particularly, DW_UT_skeleton and DW_UT_split_compile have dwo_id
2786         (currently named as "signature") in their header. Also clarify error
2787         messages.
2788         (lookup_dwo_id): New function. Returns the dwo id of the given
2789         compile unit.
2790         (lookup_dwo_unit): Use the new lookup_dwo_id function.
2791         (init_cutu_and_read_dies): Use the new dwarf2_dwo_name and lookup_dwo_id
2792         functions.
2793         (create_dwo_cu_reader): Use the added lookup_dwo_id function.
2794         (dwarf2_dwo_name): Get the dwo name if present.
2795         (dwarf_unit_type_name): Convert DW_UT_* types to string for diagnostic
2796         purposes.
2797
2798 2019-09-09  Tom Tromey  <tom@tromey.com>
2799
2800         * tui/tui-win.c (tui_all_windows_info): Use ui_out.
2801
2802 2019-09-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2803
2804         * python/python.c (do_start_initialization): Make progname_copy static,
2805         to avoid a leak report.
2806
2807 2019-09-08  Tom Tromey  <tom@tromey.com>
2808
2809         * tui/tui-wingeneral.c (box_win): Truncate long window titles.
2810
2811 2019-09-07  Simon Marchi  <simon.marchi@efficios.com>
2812
2813         * dwarf2read.c (struct dw2_symtab_iterator) <block_index>:
2814         Change type to gdb::optional<block_enum>.
2815         (dw2_symtab_iter_init): Change block_index parameter type
2816         to gdb::optional<block_enum>.
2817         (dw2_lookup_symbol): Change block_index parameter
2818         type to block_enum.c
2819         (dw2_debug_names_lookup_symbol): Likewise.
2820         * psymtab.c (psym_lookup_symbol): Likewise.
2821         * symfile-debug.c (debug_qf_lookup_symbol): Likewise.
2822         * symfile.h (struct quick_symbol_functions) <lookup_symbol>:
2823         Likewise.
2824
2825 2019-09-06  Christian Biesinger  <cbiesinger@google.com>
2826
2827         * defs.h (relocate_gdb_directory): Change int to bool in
2828         signature and rename flag to relocatable.
2829         * main.c (relocate_path): Likewise.
2830         (relocate_gdb_directory): Likewise.
2831
2832 2019-09-06  Alan Modra  <amodra@gmail.com>
2833
2834         * coffread.c (coff_symfile_read): Constify filename variable.
2835         * dbxread.c (dbx_symfile_init, coffstab_build_psymtabs),
2836         (elfstab_build_psymtabs, stabsect_build_psymtabs): Likewise.
2837         * gdb_bfd.c (gdb_bfd_close_or_warn): Likewise.
2838         * solib.c (reload_shared_libraries_1): Likewise.
2839         * symfile.c (reread_symbols): Likewise.
2840         * solib-aix.c (solib_aix_bfd_open): Add cast for xfree of filename.
2841         * solib-darwin.c (darwin_bfd_open): Likewise.
2842         * symfile-mem.c (symbol_file_add_from_memory): Likewise.
2843
2844 2019-09-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2845
2846         * psymtab.c (print_partial_symbols): Handle missing domain_enum
2847         values MODULE_DOMAIN and COMMON_BLOCK_DOMAIN.
2848
2849 2019-09-03  Tom Tromey  <tromey@adacore.com>
2850
2851         * ada-valprint.c (ada_val_print_num): Don't recurse for range
2852         types.
2853         (has_negatives): Unbias a range type bound.
2854         * dwarf2read.c (read_subrange_type): Handle DW_AT_GNU_bias.
2855         * gdbtypes.c (operator==): Handle new field.
2856         (create_range_type): Add "bias" parameter.
2857         (create_static_range_type, resolve_dynamic_range): Update.
2858         * gdbtypes.h (struct range_bounds) <bias>: New member.
2859         (create_range_type): Add bias parameter.
2860         * printcmd.c (print_scalar_formatted): Unbias range types.
2861         * value.c (unpack_long): Unbias range types.
2862         (pack_long): Bias range types.
2863
2864 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
2865
2866         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Check all
2867         probe arguments.
2868
2869 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
2870
2871         * break-catch-throw.c (fetch_probe_arguments): Use gdbarch.
2872         * dtrace-probe.c (dtrace_probe::get_argument_count): Likewise.
2873         * probe.c (probe_safe_evaluate_at_pc) (compute_probe_arg)
2874         (compile_probe_arg): Likewise.
2875         * probe.h (get_argument_count): Likewise.
2876         * solib-svr4.c (solib_event_probe_action): Likewise.
2877         * stap-probe.c (stap_probe::get_argument_count): Likewise.
2878
2879 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
2880
2881         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Move
2882         code to here...
2883         (svr4_create_solib_event_breakpoints): ...from here.
2884
2885 2019-08-30  Sergio Durigan Junior  <sergiodj@redhat.com>
2886
2887         * nat/fork-inferior.c (trace_start_error): Remove "\nError: "
2888         suffix from warning message.
2889
2890 2019-08-30  Tom Tromey  <tom@tromey.com>
2891
2892         * tui/tui-winsource.h (struct tui_source_window_base)
2893         <refresh_all>: Don't declare.
2894         * tui/tui-winsource.c (tui_source_window_base::refresh_all):
2895         Remove.
2896         * tui/tui-win.c (tui_refresh_all_win): Don't call refresh_all or
2897         tui_show_locator_content.
2898         * tui/tui-regs.h (struct tui_data_window) <refresh_all>: Don't
2899         declare.
2900         * tui/tui-regs.c (tui_data_window::refresh_all): Remove.
2901         * tui/tui-data.h (struct tui_win_info) <refresh_all>: Don't
2902         declare.
2903
2904 2019-08-30  Tom Tromey  <tom@tromey.com>
2905
2906         * tui/tui-io.c (tui_cont_sig): Don't call wrefresh.
2907
2908 2019-08-30  Tom Tromey  <tom@tromey.com>
2909
2910         * tui/tui-stack.c (_initialize_tui_stack): Move later.
2911         Remove unnecessary forward declarations.
2912
2913 2019-08-30  Tom Tromey  <tom@tromey.com>
2914
2915         * tui/tui-stack.c (tui_locator_window::set_locator_fullname): Call
2916         rerender.
2917         (tui_update_locator_fullname, tui_show_frame_info): Don't call
2918         tui_show_locator_content.
2919
2920 2019-08-30  Tom Tromey  <tom@tromey.com>
2921
2922         * tui/tui-stack.c (tui_show_locator_content): Move lower.  Rewrite.
2923         (tui_locator_window::rerender): Rewrite using body of previous
2924         tui_show_locator_content.
2925
2926 2019-08-30  Tom Tromey  <tom@tromey.com>
2927
2928         * tui/tui-stack.h (struct tui_locator_window) <set_locator_info,
2929         set_locator_fullname>: New methods.
2930         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
2931         Rename from tui_set_locator_fullname.
2932         (tui_locator_window::set_locator_info): Rename from
2933         tui_set_locator_info.  Return bool.
2934         (tui_update_locator_fullname, tui_show_frame_info): Update.
2935
2936 2019-08-30  Tom Tromey  <tom@tromey.com>
2937
2938         * tui/tui-layout.c (show_layout): Don't call tui_refresh_all.
2939
2940 2019-08-30  Tom Tromey  <tom@tromey.com>
2941
2942         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Don't
2943         call touchwin.
2944
2945 2019-08-30  Tom Tromey  <tom@tromey.com>
2946
2947         * tui/tui-wingeneral.c (box_win): Assume win_info and
2948         win_info->handle cannot be NULL.
2949
2950 2019-08-30  Tom Tromey  <tom@tromey.com>
2951
2952         * tui/tui-regs.h (struct tui_data_item_window) <rerender,
2953         refresh_window>: Declare.
2954         * tui/tui-regs.c (tui_data_window::display_registers_from): Call
2955         resize.
2956         (tui_data_item_window::rerender): Rename from
2957         tui_display_register.
2958         (tui_data_item_window::refresh_window): New method.
2959         * tui/tui-layout.c (tui_gen_win_info::resize): Do nothing on
2960         no-op.
2961
2962 2019-08-30  Tom Tromey  <tom@tromey.com>
2963
2964         * tui/tui-regs.h (struct tui_data_window) <regs_content,
2965         regs_column_count, current_group>: Move later.  Now private.
2966         <get_current_group>: New method.
2967         * tui/tui-regs.c (tui_reg_command): Update.
2968         * tui/tui-layout.c (tui_set_layout): Update.
2969
2970 2019-08-30  Tom Tromey  <tom@tromey.com>
2971
2972         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
2973         (tui_data_window::rerender): Don't call
2974         check_and_display_highlight_if_needed.
2975         (tui_data_window::refresh_all): Remove call to
2976         erase_data_content.
2977
2978 2019-08-30  Tom Tromey  <tom@tromey.com>
2979
2980         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
2981         (tui_data_window::display_registers_from)
2982         (tui_data_window::display_reg_element_at_line)
2983         (tui_data_window::display_registers_from_line): Remove checks of
2984         "empty".
2985
2986 2019-08-30  Tom Tromey  <tom@tromey.com>
2987
2988         * tui/tui-regs.h (struct tui_data_window) <display_all_data>:
2989         Don't declare.
2990         * tui/tui-regs.c (tui_data_window::show_registers): Call
2991         rerender.
2992         (tui_data_window::rerender): Rename from display_all_data.
2993         (tui_data_window::rerender): Remove old implementation.
2994
2995 2019-08-30  Tom Tromey  <tom@tromey.com>
2996
2997         * tui/tui-regs.c (tui_data_window::display_all_data): Change
2998         text.
2999         * tui/tui-data.h (NO_DATA_STRING): Remove define.
3000
3001 2019-08-29  Bernhard Wodok  <barto@gmx.net>
3002             Sergio Durigan Junior  <sergiodj@redhat.com>
3003
3004         PR win32/24284
3005         * mingw-hdep.c (gdb_select): Handle case when 'n' is zero.
3006
3007 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
3008
3009         * symtab.c (search_symbols): Don't include MODULE_DOMAIN symbols
3010         when searching for types.
3011
3012 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
3013
3014         * f-lang.c (f_language_defn): Use f_print_typedef.
3015         * f-lang.h (f_print_typedef): Declare.
3016         * f-typeprint.c (f_print_typedef): Define.
3017
3018 2019-08-27  Christian Biesinger  <cbiesinger@google.com>
3019
3020         * nat/linux-namespaces.c (mnsh_main): Initialize fd (to -1).
3021
3022 2019-08-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3023
3024         * cli/cli-utils.c (info_print_options_defs): Delete.
3025         (make_info_print_options_def_group): Delete.
3026         (extract_info_print_options): Delete.
3027         (info_print_command_completer): Delete.
3028         (info_print_args_help): Add extra parameter, and optionally
3029         include text about -n flag.
3030         * cli/cli-utils.h (struct info_print_options): Delete.
3031         (extract_info_print_options): Delete declaration.
3032         (info_print_command_completer): Delete declaration.
3033         (info_print_args_help): Add extra parameter, extend header
3034         comment.
3035         * python/python.c (gdbpy_rbreak): Pass additional parameter to
3036         search_symbols.
3037         * stack.c (struct info_print_options): New type.
3038         (info_print_options_defs): New file scoped variable.
3039         (make_info_print_options_def_group): New static function.
3040         (info_print_command_completer): New static function.
3041         (info_locals_command): Update to use new local functions.
3042         (info_args_command): Likewise.
3043         (_initialize_stack): Add extra parameter to calls to
3044         info_print_args_help.
3045         * symtab.c (search_symbols): Add extra parameter, use this to
3046         possibly excluse non-debug symbols.
3047         (symtab_symbol_info): Add extra parameter, which is passed on to
3048         search_symbols.
3049         (struct info_print_options): New type.
3050         (info_print_options_defs): New file scoped variable.
3051         (make_info_print_options_def_group): New static function.
3052         (info_print_command_completer): New static function.
3053         (info_variables_command): Update to use local functions, and pass
3054         extra parameter through to symtab_symbol_info.
3055         (info_functions_command): Likewise.
3056         (info_types_command): Pass additional argument through to
3057         symtab_symbol_info.
3058         (rbreak_command): Pass extra argument to search_symbols.
3059         (_initialize_symtab): Add extra arguments for calls to
3060         info_print_args_help, and update help text for 'info variables',
3061         'whereis', and 'info functions' commands.
3062         * symtab.h (search_symbols): Add extra argument to declaration.
3063         * NEWS: Mention new flags.
3064
3065 2019-08-26  Christian Biesinger  <cbiesinger@google.com>
3066
3067         * symtab.c (lookup_static_symbol): Call the new function (and move
3068         it down to be next to lookup_global_symbol).
3069         (struct global_sym_lookup_data): Add block_enum member and rename to...
3070         (struct global_or_static_sym_lookup_data): ...this.
3071         (lookup_symbol_global_iterator_cb): Pass block_index instead of
3072         GLOBAL_BLOCK to lookup_symbol_in_objfile and rename to...
3073         (lookup_symbol_global_or_static_iterator_cb): ...this.
3074         (lookup_global_or_static_symbol): New function.
3075         (lookup_global_symbol): Call new function.
3076
3077 2019-08-26  Tom de Vries  <tdevries@suse.de>
3078
3079         PR c++/24852
3080         * break-catch-throw.c (fetch_probe_arguments): Improve error mesage
3081         when pc_probe.prob == NULL.
3082
3083 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
3084
3085         * dwarf2read.c (dw2_debug_names_iterator::next): Rename local
3086         variable symbol_linkage to symbol_linkage_.
3087
3088 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
3089
3090         * dwarf2read.c (dw2_debug_names_iterator::next): Use enum to
3091         represent whether the symbol is static, dynamic, or we don't
3092         know.
3093
3094 2019-08-25  Yoshinori Sato <ysato@users.sourceforge.jp>
3095
3096         * gdb/rx-tdep.c (rx_register_names): New.
3097         (rx_register_name): Delete.
3098         (rx_psw_type): Delete.
3099         (rx_fpsw_type): Delete.
3100         (rx_register_type): Delete.
3101         (rx_gdbarch_init): Convert target-descriptions.
3102         (_initialize_rx_tdep): Add initialize_tdesc_rx.
3103         * gdb/features/Makefile: Add rx.xml.
3104         * gdb/features/rx.xml: New.
3105         * gdb/features/rx.c: Generated.
3106         * gdb/NEWS: Mention target description support.
3107
3108 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
3109
3110         * symtab.c (symbol_cache_lookup): Always initialize *bsc_ptr and
3111         *slot_ptr.
3112
3113 2019-08-23  Sergio Durigan Junior  <sergiodj@redhat.com>
3114
3115         * configure.ac: Don't check for 'dlfcn.h' (moved to
3116         gdbsupport/common.m4).
3117         * Makefile.in (COMMON_SFILES): Move 'gdb-dlfcn.c' to
3118         'gdbsupport/'.
3119         (HFILES_NO_SRCDIR): Likewise, for 'gdb-dlfcn.h'.
3120         * compile/compile-c-support.c: Include
3121         'gdbsupport/gdb-dlfcn.h'.
3122         * gdbsupport/common.m4: Check for 'dlfcn.h'.
3123         * gdb-dlfcn.c: Move to...
3124         * gdbsupport/gdb-dlfcn.c: ... here.
3125         * gdb-dlfcn.h: Move to...
3126         * gdbsupport/gdb-dlfcn.h: ... here.
3127
3128 2019-08-23  Sandra Loosemore  <sandra@codesourcery.com>
3129
3130         * nios2-tdep.c (struct reg_value): Improve comments.  Make
3131         the offset field signed.
3132
3133 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
3134
3135         * python/lib/gdb/__init__.py (_execute_file): New function.
3136         * python/python.c (python_run_simple_file): Call gdb._execute_file
3137         on Windows.
3138
3139 2019-08-22  Andrew Burgess  <andrew.burgess@embecosm.com>
3140
3141         * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
3142         all uses as this was never set to anything but a zero value.
3143
3144 2019-08-21  Bogdan Harjoc  <harjoc@gmail.com>
3145
3146         * cli/cli-cmds.c (with_command_1): Error out if no arguments.
3147
3148 2019-08-21  Christian Biesinger  <cbiesinger@google.com>
3149
3150         * tui/tui-data.h (tui_gen_win_info): Add an =default
3151         move constructor, required by some GCC versions.
3152
3153 2019-08-21  Jinke Fan  <fanjinke51@yeah.net>
3154
3155         * go32-nat.c (go32_sysinfo): Add hygon_p.
3156
3157 2019-08-20  Tom Tromey  <tom@tromey.com>
3158
3159         * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
3160         line_from_reg_element_no, first_reg_element_no_inline,
3161         display_all_data, delete_data_content_windows,
3162         erase_data_content>: Now private.
3163
3164 2019-08-20  Tom Tromey  <tom@tromey.com>
3165
3166         * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
3167         (tui_unhighlight_win, tui_highlight_win)
3168         (tui_win_info::make_window): Update.
3169         * tui/tui-data.h (HILITE, NO_HILITE): Remove.
3170
3171 2019-08-20  Tom Tromey  <tom@tromey.com>
3172
3173         * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
3174         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
3175         (MAX_PID_WIDTH): Move to tui-stack.c.
3176         * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
3177         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
3178         (MAX_PID_WIDTH): Move from tui-data.h.
3179
3180 2019-08-20  Tom Tromey  <tom@tromey.com>
3181
3182         * tui/tui-wingeneral.h (tui_make_window): Don't declare.
3183         * tui/tui-wingeneral.c (box_win): Change type of win_info.
3184         (box_win): Update.
3185         (tui_gen_win_info::make_window): Rename from tui_make_window.
3186         (tui_win_info::make_window): New method.
3187         (tui_gen_win_info::make_visible): Update.
3188         * tui/tui-source.c (tui_source_window::set_contents): Update.
3189         * tui/tui-regs.c (tui_data_window::show_register_group): Update.
3190         (tui_data_window::display_registers_from): Update.
3191         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
3192         * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
3193         Declare.
3194         <can_box>: Remove.
3195         <title>: Remove.
3196         (struct tui_win_info) <make_window>: Declare.
3197         <can_box>: Now virtual.
3198         <title>: New member.
3199         * tui/tui-data.c (~tui_gen_win_info): Don't free title.
3200         * tui/tui-command.c (tui_cmd_window::resize): Update.
3201
3202 2019-08-20  Tom Tromey  <tom@tromey.com>
3203
3204         * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
3205         * tui/tui-regs.c (tui_data_window::show_registers): Update.
3206         (tui_data_window::check_register_values): Update.
3207
3208 2019-08-20  Tom Tromey  <tom@tromey.com>
3209
3210         * tui/tui-regs.h (struct tui_data_window): Use
3211         DISABLE_COPY_AND_ASSIGN.
3212         <regs_content>: Change type, removing unique_ptr.
3213         <tui_data_window>: Add move constructor.
3214         * tui/tui-regs.c (tui_data_window::show_registers)
3215         (tui_data_window::show_register_group)
3216         (tui_data_window::display_registers_from)
3217         (tui_data_window::display_registers_from)
3218         (tui_data_window::first_data_item_displayed)
3219         (tui_data_window::delete_data_content_windows)
3220         (tui_data_window::rerender, tui_data_window::refresh_window)
3221         (tui_data_window::check_register_values): Update.
3222
3223 2019-08-20  Tom Tromey  <tom@tromey.com>
3224
3225         * tui/tui-regs.h (struct tui_data_window) <show_registers,
3226         show_register_group>: Declare.
3227         (tui_show_register_group): Don't declare.
3228         * tui/tui-regs.c (tui_data_window::show_registers): Rename from
3229         tui_show_registers.
3230         (tui_data_window::show_register_group): Rename from
3231         tui_show_register_group.
3232         (tui_data_window::check_register_values, tui_reg_command):
3233         Update.
3234         * tui/tui-layout.c (tui_set_layout): Update.
3235
3236 2019-08-20  Tom Tromey  <tom@tromey.com>
3237
3238         * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
3239         Declare.
3240         (tui_check_register_values): Don't declare.
3241         * tui/tui-regs.c (tui_data_window::check_register_values): Rename
3242         from tui_check_register_values.
3243         * tui/tui-hooks.c (tui_register_changed): Update.
3244
3245 2019-08-20  Tom Tromey  <tom@tromey.com>
3246
3247         * tui/tui-regs.c (tui_reg_layout): Move later.
3248         (tui_show_registers): Don't enable TUI mode or change layout.
3249
3250 2019-08-20  Tom Tromey  <tom@tromey.com>
3251
3252         * tui/tui-regs.h (struct tui_data_item_window)
3253         <~tui_data_item_window>: Remove.
3254         <content>: Now a unique_xmalloc_ptr.
3255         * tui/tui-regs.c (tui_register_format): Return a
3256         unique_xmalloc_ptr.
3257         (tui_get_register): Update.
3258         (~tui_data_item_window): Remove.
3259         (tui_data_window::display_registers_from, tui_display_register):
3260         Update.
3261         * tui/tui-io.h (tui_expand_tabs): Update.
3262         * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
3263         Remove "col" parameter.
3264
3265 2019-08-20  Tom Tromey  <tom@tromey.com>
3266
3267         * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
3268         field.
3269         * tui/tui-regs.c (~tui_data_item_window): Update.
3270
3271 2019-08-20  Tom Tromey  <tom@tromey.com>
3272
3273         * tui/tui-regs.c (tui_register_format, tui_get_register): Move
3274         earlier.
3275
3276 2019-08-20  Tom Tromey  <tom@tromey.com>
3277
3278         * tui/tui-regs.c (tui_reg_command): Remove NULL check.
3279
3280 2019-08-20  Tom Tromey  <tom@tromey.com>
3281
3282         * tui/tui-source.h (struct tui_source_window): Update.
3283         * tui/tui-regs.c (tui_show_registers): Update.
3284         * tui/tui-disasm.h (struct tui_disasm_window): Update.
3285         * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
3286         (NO_REGS_STRING): Remove defines.
3287
3288 2019-08-20  Conrad Meyer  <cem@FreeBSD.org>
3289
3290         * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
3291         unnecessary thread walk if remote doesn't support the packet.
3292
3293 2019-08-19  Tom Tromey  <tromey@adacore.com>
3294
3295         * python/py-value.c (value_has_field): Fix indentation.
3296
3297 2019-08-19  Tom Tromey  <tromey@adacore.com>
3298
3299         * printcmd.c (do_one_display, info_display_command): Update.
3300         * block.h (contained_in): Return bool.  Add allow_nested
3301         parameter.
3302         * block.c (contained_in): Return bool.  Add allow_nested
3303         parameter.
3304
3305 2019-08-19  Tom Tromey  <tom@tromey.com>
3306
3307         * configure: Rebuild.
3308         * configure.ac: Disallow the combination of -static-libstdc++ and
3309         source highlight.
3310         * source-cache.c (get_language_name): Handle rust.
3311         (source_cache::get_source_lines): Ignore highlighting exceptions.
3312
3313 2019-08-16  Tom Tromey  <tom@tromey.com>
3314
3315         * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
3316         * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
3317         (struct tui_source_window_base) <make_visible, refresh_window,
3318         resize>: Remove methods.
3319         <execution_info>: Remove field.
3320         * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
3321         (tui_show_source_line, tui_source_window_base)
3322         (~tui_source_window_base): Update.
3323         (tui_source_window_base::resize)
3324         (tui_source_window_base::make_visible)
3325         (tui_source_window_base::refresh_window): Remove.
3326         (tui_source_window_base::update_exec_info): Update.
3327         * tui/tui-source.c (tui_source_window::set_contents): Update.
3328         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
3329
3330 2019-08-16  Tom Tromey  <tom@tromey.com>
3331
3332         * tui/tui-hooks.c (tui_remove_hooks): Don't set
3333         deprecated_query_hook.
3334
3335 2019-08-16  Tom Tromey  <tom@tromey.com>
3336
3337         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
3338         (tui_update_source_windows_with_line): Update.
3339         * tui/tui-source.h (struct tui_source_window)
3340         <show_symtab_source>: Declare.
3341         (tui_show_symtab_source): Don't declare.
3342         * tui/tui-source.c (tui_show_symtab_source): Rename from
3343         tui_show_symtab_source.
3344
3345 2019-08-16  Tom Tromey  <tom@tromey.com>
3346
3347         * tui/tui-winsource.h (struct tui_source_window_base)
3348         <set_contents>: Declare.
3349         * tui/tui-winsource.c
3350         (tui_source_window_base::update_source_window_as_is): Update.
3351         * tui/tui-source.h (struct tui_source_window) <set_contents>:
3352         Declare.
3353         (tui_set_source_content): Don't declare.
3354         * tui/tui-source.c (tui_source_window::set_contents): Rename from
3355         tui_set_source_content.
3356         * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
3357         Declare.
3358         (tui_set_disassem_content): Don't declare.
3359         * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
3360         tui_set_disassem_content.
3361
3362 2019-08-16  Tom Tromey  <tom@tromey.com>
3363
3364         * tui/tui-winsource.h (struct tui_source_window_base)
3365         <update_breakpoint_info>: Declare.
3366         (tui_update_breakpoint_info): Don't declare.
3367         * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
3368         (tui_update_all_breakpoint_info): Update.
3369         (tui_source_window_base::update_breakpoint_info): Rename from
3370         tui_update_breakpoint_info.
3371         (tui_source_window_base::update_exec_info): Update.
3372
3373 2019-08-16  Tom Tromey  <tom@tromey.com>
3374
3375         * tui/tui-winsource.h (struct tui_source_window_base)
3376         <update_source_window>: Declare.
3377         (tui_update_source_window): Don't declare.
3378         * tui/tui-winsource.c
3379         (tui_source_window_base::update_source_window): Rename from
3380         tui_update_source_window.
3381         (tui_source_window_base::rerender): Update.
3382         * tui/tui-source.c (tui_source_window::maybe_update): Update.
3383         * tui/tui-disasm.c (tui_show_disassem)
3384         (tui_show_disassem_and_update_source)
3385         (tui_disasm_window::maybe_update): Update.
3386
3387 2019-08-16  Tom Tromey  <tom@tromey.com>
3388
3389         * tui/tui-winsource.h (struct tui_source_window_base)
3390         <update_source_window_as_is>: Declare.
3391         (tui_update_source_window_as_is): Don't declare.
3392         * tui/tui-winsource.c (tui_update_source_window): Update
3393         (tui_source_window_base::update_source_window_as_is): Rename from
3394         tui_update_source_window_as_is.
3395         (tui_source_window_base::refill): Update.
3396         * tui/tui-source.c (tui_show_symtab_source): Update.
3397         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
3398         Update.
3399
3400 2019-08-16  Tom Tromey  <tom@tromey.com>
3401
3402         * tui/tui-winsource.h (tui_update_source_window)
3403         (tui_update_source_window_as_is): Remove "noerror" parameter.
3404         * tui/tui-winsource.c (tui_update_source_window)
3405         (tui_update_source_window_as_is): Remove "noerror" parameter.
3406         (tui_update_source_windows_with_addr)
3407         (tui_update_source_windows_with_line)
3408         (tui_source_window_base::rerender)
3409         (tui_source_window_base::refill): Update.
3410         * tui/tui-source.h (tui_set_source_content)
3411         (tui_show_symtab_source): Remove "noerror" parameter.
3412         * tui/tui-source.c (tui_set_source_content): Remove "noerror"
3413         parameter.
3414         (tui_show_symtab_source): Likewise.
3415         (tui_source_window::maybe_update): Update.
3416         * tui/tui-disasm.c (tui_show_disassem)
3417         (tui_show_disassem_and_update_source)
3418         (tui_disasm_window::do_scroll_vertical)
3419         (tui_disasm_window::maybe_update): Update.
3420
3421 2019-08-16  Tom Tromey  <tom@tromey.com>
3422
3423         * tui/tui.c (tui_is_window_visible): Update.
3424         * tui/tui-wingeneral.c (tui_make_window)
3425         (tui_gen_win_info::make_visible, tui_refresh_all): Update.
3426         * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
3427         (tui_set_focus_command, tui_all_windows_info, update_tab_width)
3428         (tui_set_win_height_command, parse_scrolling_args): Update.
3429         * tui/tui-source.c (tui_source_window::style_changed): Update.
3430         * tui/tui-regs.c (tui_show_registers)
3431         (tui_data_window::first_data_item_displayed)
3432         (tui_data_window::delete_data_content_windows)
3433         (tui_check_register_values, tui_reg_command): Update.
3434         * tui/tui-disasm.c (tui_show_disassem): Update.
3435         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
3436         method.
3437         <is_visible>: Remove field.
3438         * tui/tui-data.c (tui_next_win, tui_prev_win)
3439         (tui_delete_invisible_windows): Update.
3440
3441 2019-08-16  Tom Tromey  <tom@tromey.com>
3442
3443         * tui/tui-winsource.h (struct tui_source_window_base)
3444         <m_has_locator>: Remove.
3445         * tui/tui-layout.c (show_source_disasm_command, show_data)
3446         (show_source_or_disasm_and_command): Update.
3447
3448 2019-08-16  Alan Hayward  <alan.hayward@arm.com>
3449
3450         * NEWS (Other MI changes): New subsection.
3451         * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
3452         (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
3453         * arch-utils.c (default_get_pc_address_flags): New function.
3454         * arch-utils.h (default_get_pc_address_flags): New declaration.
3455         * gdbarch.sh: Add get_pc_address_flags.
3456         * gdbarch.c: Regenerate.
3457         * gdbarch.h: Likewise.
3458         * stack.c (print_pc): New function.
3459         (print_frame_info) (print_frame): Call print_pc.
3460
3461 2019-08-16  Tom de Vries  <tdevries@suse.de>
3462
3463         * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
3464         print_objfile_section_info.
3465
3466 2019-08-15  Tom Tromey  <tom@tromey.com>
3467
3468         * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
3469         calling update_cmdwin_start_line.
3470         * tui/tui-winsource.h (struct tui_source_window_base)
3471         <do_make_visible_with_new_height, set_new_height>: Don't declare.
3472         <rerender>: Declare.
3473         * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
3474         Call rerender.
3475         (tui_source_window_base::set_new_height): Remove.
3476         (tui_source_window_base::rerender): Rename from
3477         do_make_visible_with_new_height.
3478         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
3479         resize method.
3480         (tui_win_info::make_invisible_and_set_new_height)
3481         (tui_win_info::make_visible_with_new_height): Remove.
3482         * tui/tui-stack.h (struct tui_locator_window) <rerender>:
3483         Declare.
3484         * tui/tui-stack.c (tui_locator_window::rerender): New method.
3485         * tui/tui-regs.h (struct tui_data_window) <set_new_height,
3486         do_make_visible_with_new_height>: Don't declare.
3487         <rerender>: Declare.
3488         * tui/tui-regs.c (tui_data_window::rerender): Rename from
3489         set_new_height.
3490         (tui_data_window::do_make_visible_with_new_height): Remove.
3491         * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
3492         call tui_show_locator_content.
3493         (tui_gen_win_info::resize): Call rerender.
3494         (show_source_or_disasm_and_command): Don't call
3495         tui_show_locator_content.
3496         * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
3497         method.
3498         (struct tui_win_info) <rerender>: Declare.
3499         <set_new_height, make_invisible_and_set_new_height,
3500         make_visible_with_new_height>: Don't declare.
3501         * tui/tui-data.c (tui_win_list::rerender): New method.
3502         * tui/tui-command.h (struct tui_cmd_window)
3503         <do_make_visible_with_new_height>: Don't declare.
3504         * tui/tui-command.c
3505         (tui_cmd_window::do_make_visible_with_new_height): Remove.
3506
3507 2019-08-15  Tom Tromey  <tromey@adacore.com>
3508
3509         * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
3510         * ada-lang.c (ada_enum_name): Likewise.
3511
3512 2019-08-15  Christian Biesinger  <cbiesinger@google.com>
3513
3514         * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
3515         leading underscore.
3516         (GdbOutputErrorFile): Likewise.
3517         (global scope): Adjust constructor calls to GdbOutput{,Error}File
3518         accordingly.
3519         (execute_unwinders): Rename to have a leading underscore.
3520         (auto_load_packages): Likewise.
3521         (global scope): Adjust call to auto_load_packages accordingly.
3522         (GdbSetPythonDirectory): Likewise.
3523         * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
3524         instead of execute_unwinders.
3525
3526 2019-08-15  Tom Tromey  <tom@tromey.com>
3527
3528         * tui/tui-layout.c (show_layout, show_source_disasm_command)
3529         (show_data): Don't change window visibility.
3530         (tui_gen_win_info::resize): Remove special case for command
3531         window.  Use wresize, when available.
3532         (show_source_or_disasm_and_command): Don't change window
3533         visibility.
3534         * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
3535         <make_visible>: New method.
3536         * tui/tui-command.c (tui_cmd_window::resize): New method.
3537
3538 2019-08-15  Tom Tromey  <tom@tromey.com>
3539
3540         * tui/tui-winsource.h (struct tui_source_window_iterator): New.
3541         (struct tui_source_windows): New.
3542         * tui/tui-winsource.c (tui_display_main): Update.
3543         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
3544         (new_height_ok, parse_scrolling_args): Update.
3545         * tui/tui-layout.c (show_layout, show_data): Update.
3546         * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
3547         (tui_add_to_source_windows): Don't declare.
3548         * tui/tui-data.c (source_windows, tui_source_windows)
3549         (tui_clear_source_windows, tui_add_to_source_windows): Remove.
3550
3551 2019-08-15  Tom Tromey  <tom@tromey.com>
3552
3553         * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
3554         Rename from reset.
3555         * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
3556         * tui/tui-layout.c (show_source_disasm_command, show_data):
3557         Update.
3558         (tui_gen_win_info::resize): Rename.
3559         (show_source_or_disasm_and_command): Update.
3560         * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
3561         reset.
3562
3563 2019-08-15  Tom Tromey  <tom@tromey.com>
3564
3565         * tui/tui-stack.c (tui_initialize_static_data): Remove.
3566         * tui/tui-interp.c (tui_interp::init): Don't call
3567         tui_initialize_static_data.
3568         * tui/tui-data.h (tui_initialize_static_data): Don't declare.
3569
3570 2019-08-15  Tom Tromey  <tom@tromey.com>
3571
3572         * tui/tui-layout.c (tui_default_win_viewport_height): Don't
3573         examine tui_win_list.
3574
3575 2019-08-15  Tom Tromey  <tom@tromey.com>
3576
3577         * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
3578         * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
3579         tui_clear_source_content.
3580         (tui_clear_source_content): Remove.
3581         (tui_source_window_base::do_erase_source_content): Hoist call to
3582         content.clear().
3583         * tui/tui-stack.c (tui_show_frame_info): Don't call
3584         tui_clear_source_content.
3585
3586 2019-08-15  Tom Tromey  <tom@tromey.com>
3587
3588         * tui/tui-winsource.h (struct tui_source_window_base)
3589         <do_erase_source_content>: New method.
3590         <erase_source_content>: New method.
3591         (tui_erase_source_content): Don't declare.
3592         * tui/tui-winsource.c (tui_clear_source_content): Update.
3593         (tui_source_window_base::do_erase_source_content): Rename from
3594         tui_erase_source_content.
3595         (tui_source_window_base::show_source_content): Update.
3596         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
3597         * tui/tui-source.h (struct tui_source_window)
3598         <erase_source_content>: New method.
3599         * tui/tui-disasm.h (struct tui_disasm_window)
3600         <erase_source_content>: New method.
3601
3602 2019-08-15  Tom Tromey  <tom@tromey.com>
3603
3604         * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
3605         (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
3606         constructor.
3607         * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
3608         * tui/tui-source.c (tui_set_source_content): Update.
3609         * tui/tui-disasm.c (tui_set_disassem_content): Update.
3610
3611 2019-08-15  Tom Tromey  <tom@tromey.com>
3612
3613         * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
3614         * tui/tui-winsource.c (tui_line_is_displayed): Move to
3615         tui-source.c.
3616         * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
3617         Declare.
3618         * tui/tui-source.c (tui_source_window::line_is_displayed): New
3619         method.
3620         (tui_source_window::maybe_update): Update.
3621
3622 2019-08-15  Tom Tromey  <tom@tromey.com>
3623
3624         * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
3625         * tui/tui-winsource.c (tui_addr_is_displayed): Move to
3626         tui-disasm.c.
3627         * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
3628         Declare.
3629         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
3630         method.
3631         (tui_disasm_window::maybe_update): Update.
3632
3633 2019-08-15  Tom Tromey  <tom@tromey.com>
3634
3635         * tui/tui-winsource.h (struct tui_source_window_base)
3636         <maybe_update>: Declare.
3637         * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
3638         method.
3639         * tui/tui-source.h (struct tui_source_window) <maybe_update>:
3640         Declare.
3641         * tui/tui-source.c (tui_source_window::maybe_update): New method.
3642         * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
3643         Declare.
3644         * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
3645
3646 2019-08-15  Tom Tromey  <tom@tromey.com>
3647
3648         * tui/tui-stack.c (tui_make_status_line): Use string constructor.
3649
3650 2019-08-15  Tom Tromey  <tom@tromey.com>
3651
3652         * tui/tui-wingeneral.c: Include tui-stack.h.
3653         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
3654         (struct tui_locator_window): Move from tui-data.h.
3655         * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
3656         (tui_initialize_static_data): Move from tui-data.c.
3657         * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
3658         (struct tui_locator_window): Move to tui-stack.c.
3659         * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
3660         (tui_initialize_static_data): Move to tui-stack.c.
3661
3662 2019-08-15  Tom Tromey  <tom@tromey.com>
3663
3664         * tui/tui-layout.c (show_source_disasm_command)
3665         (show_source_or_disasm_and_command): Use make_visible method, not
3666         tui_make_window.
3667         * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
3668         Remove.
3669
3670 2019-08-15  Tom Tromey  <tom@tromey.com>
3671
3672         * tui/tui-wingeneral.h (tui_make_window): Update.
3673         * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
3674         parameter.
3675         (tui_gen_win_info::make_visible): Update.
3676         * tui/tui-regs.c (tui_data_window::display_registers_from):
3677         Update.
3678         * tui/tui-layout.c (show_source_disasm_command)
3679         (show_source_or_disasm_and_command): Update.
3680         * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
3681         (enum tui_box): Remove.
3682         (struct tui_win_info) <can_box>: New method.
3683         * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
3684         method.
3685
3686 2019-08-15  Tom de Vries  <tdevries@suse.de>
3687
3688         * linux-nat-trad.c: Include gdbarch.h.
3689
3690 2019-08-14  Alan Hayward  <alan.hayward@arm.com>
3691
3692         * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
3693         register sizes.
3694
3695 2019-08-14  Tom Tromey  <tromey@adacore.com>
3696
3697         * darwin-nat.c: Include gdbarch.h.
3698         * darwin-nat-info.c: Include gdbarch.h.
3699
3700 2019-08-13  Tom Tromey  <tom@tromey.com>
3701
3702         * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
3703         Remove.
3704         * tui/tui-data.c (tui_initialize_static_data): Update.
3705
3706 2019-08-13  Tom Tromey  <tom@tromey.com>
3707
3708         * tui/tui-winsource.h (struct tui_exec_info_window)
3709         <~tui_exec_info_window, maybe_allocate_content, get_content,
3710         m_content>: Remove.
3711         (struct tui_source_window_base) <set_exec_info_content,
3712         show_exec_info_content>: Don't declare.
3713         * tui/tui-winsource.c
3714         (tui_exec_info_window::maybe_allocate_content): Remove.
3715         (tui_source_window_base::update_exec_info): Rename from
3716         set_exec_info_content.
3717         (tui_source_window_base::show_exec_info_content)
3718         (tui_source_window_base::update_exec_info): Remove.
3719
3720 2019-08-13  Tom Tromey  <tom@tromey.com>
3721
3722         * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
3723         declare.
3724         * tui/tui-winsource.c (tui_update_source_window_as_is)
3725         (tui_update_source_windows_with_addr, tui_erase_source_content):
3726         Update.
3727         (tui_clear_exec_info_content): Remove.
3728
3729 2019-08-13  Tom Tromey  <tom@tromey.com>
3730
3731         * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
3732         declare.
3733         * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
3734         call tui_erase_exec_info_content.
3735         (tui_clear_exec_info_content): Rename from
3736         tui_erase_exec_info_content.
3737         (tui_clear_exec_info_content): Delete.
3738
3739 2019-08-13  Tom Tromey  <tom@tromey.com>
3740
3741         * tui/tui-winsource.h (struct tui_source_window_base)
3742         <show_exec_info_content>: Declare.
3743         (tui_show_exec_info_content): Don't declare.
3744         * tui/tui-winsource.c
3745         (tui_source_window_base::show_exec_info_content): Rename from
3746         tui_show_exec_info_content.
3747         (tui_source_window_base::update_exec_info): Update.
3748
3749 2019-08-13  Tom Tromey  <tom@tromey.com>
3750
3751         * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
3752         (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
3753         (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
3754         * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
3755         tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
3756         (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
3757         ... here.
3758
3759 2019-08-13  Tom Tromey  <tom@tromey.com>
3760
3761         * tui/tui-winsource.h (struct tui_source_window_base)
3762         <update_exec_info>: Declare.
3763         (tui_update_exec_info): Don't declare.
3764         * tui/tui-winsource.c (tui_update_source_window_as_is)
3765         (tui_source_window_base::refresh_all)
3766         (tui_update_all_breakpoint_info): Update.
3767         (tui_source_window_base::update_exec_info): Rename from
3768         tui_update_exec_info.
3769         * tui/tui-stack.c (tui_show_frame_info): Update.
3770
3771 2019-08-13  Tom Tromey  <tom@tromey.com>
3772
3773         * tui/tui-winsource.h (struct tui_source_window_base)
3774         <set_exec_info_content>: Declare.
3775         (tui_set_exec_info_content): Don't declare.
3776         * tui/tui-winsource.c
3777         (tui_source_window_base::set_exec_info_content): Rename from
3778         tui_set_exec_info_content.
3779         (tui_update_exec_info): Update.
3780
3781 2019-08-13  Tom Tromey  <tom@tromey.com>
3782
3783         * tui/tui-winsource.h (struct tui_source_window_base)
3784         <show_source_content>: Declare.
3785         (tui_show_source_content): Don't declare.
3786         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
3787         (tui_source_window_base::show_source_content): Rename from
3788         tui_show_source_content.
3789         (tui_source_window_base::refresh_all): Update.
3790         * tui/tui-layout.c (show_source_disasm_command)
3791         (show_source_or_disasm_and_command): Update.
3792
3793 2019-08-13  Tom Tromey  <tom@tromey.com>
3794
3795         * tui/tui-winsource.c (tui_erase_source_content)
3796         (tui_show_source_content, tui_source_window_base::refresh_all):
3797         Update.
3798         * tui/tui-wingeneral.h
3799         (tui_check_and_display_highlight_if_needed): Don't declare.
3800         * tui/tui-wingeneral.c
3801         (tui_win_info::check_and_display_highlight_if_needed): Rename from
3802         check_and_display_highlight_if_needed.
3803         * tui/tui-win.c (tui_rehighlight_all)
3804         (tui_win_info::make_visible_with_new_height): Update.
3805         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
3806         (tui_data_window::erase_data_content)
3807         (tui_data_window::display_all_data): Update.
3808         * tui/tui-data.h (struct tui_win_info)
3809         <check_and_display_highlight_if_needed>: Declare.
3810
3811 2019-08-13  Tom Tromey  <tom@tromey.com>
3812
3813         * tui/tui-win.c (tui_resize_all): Call
3814         tui_delete_invisible_windows.
3815         * tui/tui-layout.c (show_layout): Call
3816         tui_delete_invisible_windows.
3817         * tui/tui-data.h (tui_delete_invisible_windows): Declare.
3818         * tui/tui-data.c (tui_delete_invisible_windows): New function.
3819
3820 2019-08-13  Tom Tromey  <tom@tromey.com>
3821
3822         * tui/tui-disasm.c (tui_show_disassem): Add assertion.  Don't call
3823         tui_add_win_to_layout.
3824
3825 2019-08-13  Tom Tromey  <tom@tromey.com>
3826
3827         * tui/tui-layout.h (tui_default_win_height): Don't declare.
3828         * tui/tui-layout.c (tui_default_win_height): Now static.
3829
3830 2019-08-13  Tom Tromey  <tom@tromey.com>
3831
3832         * tui/tui-layout.c (show_layout): Unify all layout cases into a
3833         single switch.
3834         (show_source_disasm_command, show_source_or_disasm_and_command):
3835         Don't check current layout.
3836
3837 2019-08-13  Tom Tromey  <tom@tromey.com>
3838
3839         * tui/tui-wingeneral.c (make_all_visible): Remove.
3840         (tui_make_all_invisible): Simplify.
3841         * tui/tui-layout.c (tui_make_all_invisible): Move from
3842         tui-wingeneral.c; simplify.
3843         (show_layout): Hoist call to tui_make_all_invisible.
3844         (show_data): Don't call tui_make_all_invisible.
3845
3846 2019-08-13  Tom Tromey  <tom@tromey.com>
3847
3848         * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
3849         * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
3850
3851 2019-08-13  Tom Tromey  <tom@tromey.com>
3852
3853         * tui/tui-layout.c (current_layout, tui_current_layout): Move from
3854         tui-data.c.
3855         (show_source_disasm_command, show_data)
3856         (show_source_or_disasm_and_command): Don't use
3857         tui_set_current_layout_to.
3858         * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
3859         * tui/tui-data.c (current_layout, tui_current_layout): Move to
3860         tui-layout.c.
3861         (tui_set_current_layout_to): Remove.
3862
3863 2019-08-13  Tom Tromey  <tom@tromey.com>
3864
3865         * tui/tui-layout.c (tui_set_layout): Update.
3866         * tui/tui-data.h (struct tui_layout_def): Remove.
3867         (tui_layout_def): Don't declare.
3868         * tui/tui-data.c (layout_def): Remove.
3869         (tui_layout_def): Remove.
3870
3871 2019-08-13  Tom Tromey  <tom@tromey.com>
3872
3873         * tui/tui-winsource.h (struct tui_source_window_base)
3874         <clear_detail>: No longer "override".
3875         * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
3876         * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
3877         * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
3878         * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
3879         Remove.
3880         * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
3881
3882 2019-08-13  Tom Tromey  <tromey@adacore.com>
3883
3884         * tracepoint.c: Don't include readline.h or history.h.
3885
3886 2019-08-12  Tom Tromey  <tom@tromey.com>
3887
3888         * configure: Rebuild.
3889         * configure.ac: Check for readline 7.
3890         * NEWS: Mention readline 7 requirement.
3891         * README: Update.
3892
3893 2019-08-12  Tom Tromey  <tom@tromey.com>
3894
3895         * mingw-hdep.c (gdb_select): Remove readline hack.
3896
3897 2019-08-09  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
3898
3899         * blockframe.c (find_pc_partial_function): Set *block to nullptr
3900         when the function fails.
3901
3902 2019-08-09  Andreas Arnez  <arnez@linux.ibm.com>
3903
3904         * s390-tdep.c (s390_type_align): New function.
3905         (s390_gdbarch_init): Set it as type_align gdbarch method.
3906
3907 2019-08-09  Tom de Vries  <tdevries@suse.de>
3908
3909         PR gdb/24591
3910         * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
3911         pc_low with relocation offset.
3912
3913 2019-08-07  Tom Tromey  <tromey@adacore.com>
3914
3915         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
3916         (print_frame_args): Update.
3917         * python/py-framefilter.c (py_print_single_arg, enumerate_args):
3918         Update.
3919         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
3920         * frame.h (struct frame_arg): Add initializers.
3921         <error>: Now a unique_xmalloc_ptr.
3922
3923 2019-08-07  Alan Hayward  <alan.hayward@arm.com>
3924
3925         * NEWS: Expand the Pointer Authentication entry.
3926         * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
3927         (aarch64_frame_unmask_lr): ... to this.
3928         (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
3929         Call aarch64_frame_unmask_lr.
3930         * frame.c (struct frame_info): Add "masked" variable.
3931         (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
3932         (fprint_frame): Check for masked pc.
3933         * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
3934         declarations.
3935         * python/py-framefilter.c (py_print_frame): Check for masked pc.
3936         * stack.c (print_frame): Check for masked pc.
3937
3938 2019-08-06  Tom Tromey  <tom@tromey.com>
3939
3940         * stabsread.c (patch_block_stabs, read_one_struct_field)
3941         (read_enum_type): Use obstack_strndup.
3942         * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
3943         * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
3944         * dwarf2read.c (guess_full_die_structure_name)
3945         (anonymous_struct_prefix): Use obstack_strndup.
3946         * dbxread.c (cp_set_block_scope): Use obstack_strndup.
3947         * c-exp.y (yylex): Use obstack_strndup.
3948         * ada-exp.y (write_object_renaming, write_ambiguous_var)
3949         (write_var_or_type): Use obstack_strndup.
3950
3951 2019-08-06  Tom Tromey  <tom@tromey.com>
3952
3953         * symfile.c (reread_symbols): Use obstack_strdup.
3954         * stabsread.c (read_type): Use obstack_strdup.
3955         * gdb_obstack.h (obstack_strdup): New overload.
3956         * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
3957         (create_dwo_unit_in_dwp_v2, build_error_marker_type)
3958         (dwarf2_canonicalize_name): Use obstack_strdup.
3959         * dbxread.c (read_dbx_symtab): Use obstack_strdup.
3960         * cp-support.c (inspect_type, replace_typedefs_qualified_name):
3961         Use obstack_strdup.
3962
3963 2019-08-06  Tom Tromey  <tom@tromey.com>
3964
3965         * gdb_obstack.h (obstack_strdup): Define.
3966         * gdb_obstack.c (obstack_strdup): Don't define.
3967
3968 2019-08-06  Tom Tromey  <tom@tromey.com>
3969
3970         * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
3971         obstack_strdup.
3972         * typeprint.c (typedef_hash_table::find_global_typedef): Use
3973         obstack_strdup.
3974         * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
3975         * stabsread.c (common_block_start): Use obstack_strdup.
3976         * objfiles.c (set_objfile_main_name, objfile): Use
3977         obstack_strdup.
3978         * namespace.c (add_using_directive): Use obstack_strdup.
3979         * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
3980         * jit.c (finalize_symtab): Use obstack_strdup.
3981         * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
3982         (guess_partial_die_structure_name, partial_die_info::fixup)
3983         (dwarf2_name): Use obstack_strdup.
3984         * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
3985         obstack_strdup.
3986         * c-exp.y (scan_macro_expansion): Use obstack_strdup.
3987         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
3988         obstack_strdup.
3989         * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
3990
3991 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3992
3993         * unittests/help-doc-selftests.c: New file.
3994         * Makefile.in: Add the new file.
3995
3996 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3997
3998         * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
3999         * cli/cli-decode.c (print_doc_line): Likewise.  It now prints
4000         the full first line, except when FOR_VALUE_PREFIX.  In this case,
4001         the trailing '.' is not output, and the first character is uppercased.
4002         (print_help_for_command): Update call to print_doc_line.
4003         (print_doc_of_command): Likewise.
4004         * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
4005         * cli/cli-option.c (append_indented_doc): Do not append newline.
4006         (build_help_option): Append newline after first appended_indented_doc
4007         only if a second call is done.
4008         (build_help): Append 2 new lines before each option, except the first
4009         one.
4010         * compile/compile.c (_initialize_compile): Add new lines after
4011         %OPTIONS%, when not at the end of the help.
4012         Change help doc or code
4013         producing the help doc to respect the invariants.
4014         * maint-test-options.c (_initialize_maint_test_options): Likewise.
4015         Also removed the new line after 'Options:', as all other commands
4016         do not put an empty line between 'Options:' and the first option.
4017         * printcmd.c (_initialize_printcmd): Likewise.
4018         * stack.c (_initialize_stack): Likewise.
4019         * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
4020         incorrectly telling COMMAND is optional.
4021         * ada-lang.c (_initialize_ada_language): Change help doc or code
4022         producing the help doc to respect the invariants.
4023         * ada-tasks.c (_initialize_ada_tasks): Likewise.
4024         * breakpoint.c (_initialize_breakpoint): Likewise.
4025         * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
4026         * cli/cli-logging.c (_initialize_cli_logging): Likewise.
4027         * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
4028         * cli/cli-style.c (cli_style_option::add_setshow_commands,
4029         _initialize_cli_style): Likewise.
4030         * corelow.c (core_target_info): Likewise.
4031         * dwarf-index-cache.c (_initialize_index_cache): Likewise.
4032         * dwarf2read.c (_initialize_dwarf2_read): Likewise.
4033         * filesystem.c (_initialize_filesystem): Likewise.
4034         * frame.c (_initialize_frame): Likewise.
4035         * gnu-nat.c (add_task_commands): Likewise.
4036         * infcall.c (_initialize_infcall): Likewise.
4037         * infcmd.c (_initialize_infcmd): Likewise.
4038         * interps.c (_initialize_interpreter): Likewise.
4039         * language.c (_initialize_language): Likewise.
4040         * linux-fork.c (_initialize_linux_fork): Likewise.
4041         * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
4042         * maint.c (_initialize_maint_cmds): Likewise.
4043         * memattr.c (_initialize_mem): Likewise.
4044         * printcmd.c (_initialize_printcmd): Likewise.
4045         * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
4046         _RegEx): Likewise.
4047         * ravenscar-thread.c (_initialize_ravenscar): Likewise.
4048         * record-btrace.c (_initialize_record_btrace): Likewise.
4049         * record-full.c (_initialize_record_full): Likewise.
4050         * record.c (_initialize_record): Likewise.
4051         * regcache-dump.c (_initialize_regcache_dump): Likewise.
4052         * regcache.c (_initialize_regcache): Likewise.
4053         * remote.c (add_packet_config_cmd, init_remote_threadtests,
4054         _initialize_remote): Likewise.
4055         * ser-tcp.c (_initialize_ser_tcp): Likewise.
4056         * serial.c (_initialize_serial): Likewise.
4057         * skip.c (_initialize_step_skip): Likewise.
4058         * source.c (_initialize_source): Likewise.
4059         * stack.c (_initialize_stack): Likewise.
4060         * symfile.c (_initialize_symfile): Likewise.
4061         * symtab.c (_initialize_symtab): Likewise.
4062         * target-descriptions.c (_initialize_target_descriptions): Likewise.
4063         * top.c (init_main): Likewise.
4064         * tracefile-tfile.c (tfile_target_info): Likewise.
4065         * tracepoint.c (_initialize_tracepoint): Likewise.
4066         * tui/tui-win.c (_initialize_tui_win): Likewise.
4067         * utils.c (add_internal_problem_command): Likewise.
4068         * valprint.c (value_print_option_defs): Likewise.
4069
4070 2019-08-06  Frank Ch. Eigler  <fche@redhat.com>
4071
4072         PR build/24886
4073         * configure.ac: Drop enable-libmcheck support.
4074         * configure, config.in: Rebuild.
4075         * libmcheck.m4: Remove.
4076         * acinclude.m4: Don't include it.
4077         * Makefile.in: Don't distribute it.
4078         * top.c (print_gdb_configuration): Don't mention it.
4079
4080 2019-08-06  Tom Tromey  <tom@tromey.com>
4081
4082         * utils.c (set_output_style): Sometimes pass stream to
4083         emit_style_escape.
4084         * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
4085         * record-btrace.c (btrace_insn_history): Update.
4086         * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
4087         method.
4088         * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
4089         Update initializers.
4090         <m_uiout>: New field.
4091         <m_di>: Move lower.
4092         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
4093         Remove "uiout" parameter.
4094         (dump_insns): Update.
4095         * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
4096         * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
4097
4098 2019-08-06  Christian Biesinger  <cbiesinger@google.com>
4099
4100         * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
4101         (error_in_psymtab_expansion): Likewise.
4102         (lookup_symbol_via_quick_fns): Likewise.
4103         (basic_lookup_transparent_type_quick): Likewise.
4104         (basic_lookup_transparent_type_1): Likewise.
4105
4106 2019-08-06  Tom Tromey  <tromey@adacore.com>
4107
4108         * source.c (last_source_error): Now bool.
4109         (print_source_lines_base): Make "noprint" bool.  Only open
4110         source file when last_source_visited changes.
4111
4112 2019-08-06  Tom Tromey  <tromey@adacore.com>
4113
4114         * annotate.c (annotate_source_line): Use g_source_cache.
4115         * source-cache.c (source_cache::get_plain_source_lines): Change
4116         parameters.  Populate m_offset_cache.
4117         (source_cache::ensure): New method.
4118         (source_cache::get_line_charpos): New method.
4119         (extract_lines): Move lower.  Change parameters.
4120         (source_cache::get_source_lines): Move lower.
4121         * source-cache.h (class source_cache): Update comment.
4122         <get_line_charpos>: New method.
4123         <get_source_lines>: Update comment.
4124         <clear>: Clear m_offset_cache.
4125         <get_plain_source_lines>: Change parameters.
4126         <ensure>: New method
4127         <m_offset_cache>: New member.
4128         * source.c (forget_cached_source_info_for_objfile): Update.
4129         (info_source_command): Use g_source_cache.
4130         (find_source_lines, open_source_file_with_line_charpos): Remove.
4131         (print_source_lines_base, search_command_helper): Use g_source_cache.
4132         * source.h (open_source_file_with_line_charpos): Don't declare.
4133         * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
4134         * tui/tui-source.c (tui_source_window::do_scroll_vertical):
4135         Use g_source_cache.
4136
4137 2019-08-06  Tom Tromey  <tromey@adacore.com>
4138
4139         * source-cache.c (source_cache::get_plain_source_lines):
4140         Remove "first_line" and "last_line" parameters.
4141         (source_cache::get_source_lines): Cache plain text.
4142         * source-cache.h (class source_cache)
4143         <get_plain_source_lines>: Update.
4144
4145 2019-08-06  Tom Tromey  <tromey@adacore.com>
4146
4147         * source-cache.c (extract_lines): No longer a method.
4148         Changed type of parameter.  Include final newline.
4149         (selftests::extract_lines_test): New function.
4150         (_initialize_source_cache): Likewise.
4151         * source-cache.h (class source_cache)
4152         <extract_lines>: Don't declare.
4153
4154 2019-08-06  Tom Tromey  <tromey@adacore.com>
4155
4156         * breakpoint.c (init_breakpoint_sal): Update.
4157         (breakpoint): Update.
4158         * breakpoint.h (struct breakpoint) <filter>: Now a
4159         unique_xmalloc_ptr.
4160
4161 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
4162
4163         * NEWS: Mention dictionary access on blocks.
4164         * python/py-block.c (blpy_getitem): New function.
4165         (block_object_as_mapping): New struct.
4166         (block_object_type): Use new struct for tp_as_mapping field.
4167
4168 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
4169
4170         * objfiles.h (objfile): Add a comment describing partial symbols.
4171
4172 2019-08-05  Tom Tromey  <tromey@adacore.com>
4173
4174         * compile/compile.c (_initialize_compile): Use _(), not N_().
4175         * thread.c (_initialize_thread): Use _(), not N_().
4176         * stack.c (_initialize_stack): Use _(), not N_().
4177         * printcmd.c (_initialize_printcmd): Use _(), not N_().
4178
4179 2019-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
4180
4181         * dwarf2read.c (struct dw2_symtab_iterator):
4182         <want_specific_block>: Remove.
4183         <block_index>: Change type to gdb::optional.
4184         (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
4185         change type of BLOCK_INDEX parameter to gdb::optional.
4186         (dw2_symtab_iter_next): Re-write in function of gdb::optional.
4187         (dw2_lookup_symbol): Don't pass argument for
4188         WANT_SPECIFIC_BLOCK.
4189         (dw2_expand_symtabs_for_function): Don't pass argument for
4190         WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
4191         (class dw2_debug_names_iterator)
4192         <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
4193         parameter, change BLOCK_INDEX type to gdb::optional.
4194         <m_want_specific_block>: Remove.
4195         <m_block_index>: Change type to gdb::optional.
4196         (dw2_debug_names_iterator::next): Change type of IS_STATIC to
4197         gdb::optional.  Re-write in function of gdb::optional.
4198         (dw2_debug_names_lookup_symbol): Don't pass argument for
4199         WANT_SPECIFIC_BLOCK.
4200         (dw2_debug_names_expand_symtabs_for_function): Don't pass
4201         argument for WANT_SPECIFIC_BLOCK, pass empty optional for
4202         BLOCK_INDEX.
4203
4204 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4205
4206         * NEWS: Mention changes to "info sources" command.
4207
4208 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4209
4210         * symtab.c (filename_partial_match_opts): New struct type.
4211         (struct output_source_filename_data): New members
4212         regexp, c_regexp, partial_match.
4213         (output_source_filename): Use new members to decide to print file.
4214         (info_sources_option_defs): New variable.
4215         (make_info_sources_options_def_group, print_info_sources_header,
4216         info_sources_command_completer):
4217         New functions.
4218         (info_sources_command): Read new optional arguments.
4219         (_initialize_symtab): Update info sources help.
4220
4221 2019-08-02  Alexandre Oliva <oliva@adacore.com>
4222
4223         * ada-lang.c (exception_support_info_v0): Renamed from...
4224         (default_exception_support_info): ... this.  Create new
4225         definition for v1.
4226         (ada_has_this_exception_support): Look up catch_handlers_sym.
4227         (ada_exception_support_info_sniffer): Try v0 after default.
4228
4229 2019-08-01  Tom Tromey  <tromey@adacore.com>
4230
4231         * ia64-libunwind-tdep.h (struct libunwind_descr): Include
4232         gdbarch.h.
4233
4234 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
4235
4236         * s12z-tdep.c: Fix include path for s12z-opc.h.
4237
4238 2019-08-01  Alan Hayward  <alan.hayward@arm.com>
4239
4240         * NEWS: Require GNU make 3.82.
4241
4242 2019-07-16  Tom Tromey  <tom@tromey.com>
4243
4244         * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
4245         declare.
4246
4247 2019-07-30  Tom Tromey  <tromey@adacore.com>
4248
4249         * block.c (contained_in): Remove BLOCK_FUNCTION check.
4250
4251 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
4252
4253         * printcmd.c (print_address_symbolic): Print negative offsets.
4254         (build_address_symbolic): Force signed arithmetic when computing
4255         offset.
4256
4257 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
4258
4259         PR/24474: Add a function to lookup static variables.
4260         * NEWS: Mention this new function.
4261         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
4262         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
4263         * python/python.c (python_GdbMethods): Add new function.
4264
4265 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
4266
4267         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
4268         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
4269         (objfpy_lookup_static_symbol): New function.
4270         (objfile_object_methods): Add new functions.
4271
4272 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4273
4274         * NEWS: Mention 'set|show print frame-info'.  Mention new
4275         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
4276         backtrace argument.  Mention that python frame filtering code
4277         is now consistent with what 'backtrace' command prints.
4278
4279 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4280
4281         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
4282         comments.
4283         (print_frame_info_auto, print_frame_info_source_line,
4284         print_frame_info_location, print_frame_info_source_and_location,
4285         print_frame_info_location_and_address, print_frame_info_short_location):
4286         New declarations.
4287         (struct frame_print_options): New member print_frame_info.
4288         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
4289         * stack.h (get_user_print_what_frame_info): New declaration.
4290         (frame_show_address): New declaration.
4291         * stack.c (print_frame_arguments_choices): New value 'presence'.
4292         (print_frame_info_auto, print_frame_info_source_line,
4293         print_frame_info_location, print_frame_info_source_and_location,
4294         print_frame_info_location_and_address, print_frame_info_short_location,
4295         print_frame_info_choices, print_frame_info_print_what): New definitions.
4296         (print_frame_args): Only print dots for args if print frame-arguments
4297         is 'presence'.
4298         (frame_print_option_defs): New element for "frame-info".
4299         (get_user_print_what_frame_info): New function.
4300         (frame_show_address): Make non static.  Move comment to stack.h.
4301         (print_frame_info_to_print_what): New function.
4302         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
4303         to decide what to print.
4304         (backtrace_command_1): Handle the new print_frame_arguments_presence
4305         value.
4306         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
4307         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
4308         (py_print_frame): In non-mi mode, use LOCATION as default for
4309         print_what, similarly to frame information printed directly by
4310         backtrace command. Handle frame-info user option in non MI mode.
4311
4312 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
4313
4314         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
4315         Add case for debugging 32-bit target on 64-bit host.  Revise
4316         comment.
4317
4318 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
4319
4320         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
4321         instead of find_function_entry_range_from_pc.
4322
4323 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
4324
4325         * stack.c (find_frame_funname): Remove code which preferred
4326         minsym over symtab sym in "certain pathological cases".
4327
4328         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
4329         parameter.  Change type of "do_demangle" to bool.
4330         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
4331         Pass suitable "prefer_sym_over_minsym" flag to
4332         build_address_symbolic().  Don't output "+" for negative offsets.
4333         * printcmd.c (print_address_symbolic): Update invocation of
4334         build_address_symbolic to include a "prefer_sym_over_minsym"
4335         flag.
4336         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
4337         Restrict cases in which use of minimal symbol is preferred to that
4338         of a found symbol.  Update comments.
4339
4340         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
4341         for entry pc when entry pc is out of range for that FDE.
4342
4343 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
4344
4345         PR gdb/24839:
4346         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
4347         type.
4348
4349 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
4350
4351         * python/py-objfile.c (add_separate_debug_file): Fix comment about
4352         this function's Python signature.
4353
4354
4355 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
4356
4357         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
4358         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
4359         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
4360         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
4361         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
4362
4363
4364 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
4365
4366         * h8300-tdep.c (h8300_register_name_common): New.
4367         h8300_register_name): Use h8300_register_name_common.
4368         (h8300s_register_name): Likewise.
4369         (h8300sx_register_name): Likewise.
4370         (h8300h_register_nam): New.
4371         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
4372
4373
4374 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
4375
4376         * arm-tdep.c (arm_skip_cmse_entry): New function.
4377         (arm_is_sgstubs_section): New function.
4378         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
4379
4380 2019-07-22  Tom Tromey  <tom@tromey.com>
4381
4382         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
4383         Don't self-assign.
4384
4385 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
4386
4387         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
4388         type_print.
4389
4390 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
4391
4392         * symtab.c (search_symbols): Adjust msymbol matching type arrays
4393         so that GDB doesn't match any msymbols when searching in the
4394         TYPES_DOMAIN.
4395         (print_symbol_info): Print using typedef_print or type_print based
4396         on the type of the symbol.  Add updated FIXME comment moved from...
4397         (_initialize_symtab): ... move and update FIXME comment to above.
4398
4399 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
4400
4401         * NEWS: Mention adding -q option to "info types".
4402         * symtab.c (struct info_types_options): New struct.
4403         (info_types_options_defs): New variable.
4404         (make_info_types_options_def_group): New function.
4405         (info_types_command): Use gdb::option framework to parse options.
4406         (info_types_command_completer): New function.
4407         (_initialize_symtab): Extend the help text on "info types" and
4408         register command completer.
4409
4410 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
4411
4412         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
4413         (lookup_symbol_in_objfile): Change int to block_enum and add a
4414         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
4415
4416 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
4417
4418         * MAINTAINERS (Write After Approval): Add self.
4419
4420 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
4421
4422         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
4423         instruction to the dummy code region.
4424
4425 2019-07-19  Tom Tromey  <tromey@adacore.com>
4426
4427         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
4428         (ARGSUSED, PARAMS, __func__): Remove rules.
4429
4430 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
4431
4432         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
4433         * features/arm/arm-with-iwmmxt.c: Remove.
4434         * features/arm/arm-with-iwmmxt.xml: Remove.
4435         * features/arm/arm-with-m-fpa-layout.c: Remove.
4436         * features/arm/arm-with-m-fpa-layout.xml: Remove.
4437         * features/arm/arm-with-m-vfp-d16.c: Remove.
4438         * features/arm/arm-with-m-vfp-d16.xml: Remove.
4439         * features/arm/arm-with-m.c: Remove.
4440         * features/arm/arm-with-m.xml: Remove.
4441         * features/arm/arm-with-neon.c: Remove.
4442         * features/arm/arm-with-neon.xml: Remove.
4443         * features/arm/arm-with-vfpv2.c: Remove.
4444         * features/arm/arm-with-vfpv2.xml: Remove.
4445         * features/arm/arm-with-vfpv3.c: Remove.
4446         * features/arm/arm-with-vfpv3.xml: Remove.
4447
4448 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
4449
4450         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
4451
4452 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
4453
4454         * arch/aarch32.c (aarch32_create_target_description): Create
4455         target descriptions using features.
4456         * arch/arm.c (arm_create_target_description)
4457         (arm_create_mprofile_target_description): Likewise.
4458         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
4459
4460 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
4461
4462         * Makefile.in: Add new files.
4463         * aarch32-tdep.c: New file.
4464         * aarch32-tdep.h: New file.
4465         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
4466         Call aarch32_read_description.
4467         * arch/aarch32.c: New file.
4468         * arch/aarch32.h: New file.
4469         * arch/arm.c (arm_create_target_description)
4470         (arm_create_mprofile_target_description): New function.
4471         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
4472         (arm_create_target_description)
4473         (arm_create_mprofile_target_description): New declaration.
4474         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
4475         read_description functions.
4476         * arm-linux-nat.c (arm_linux_nat_target::read_description):
4477         Likewise.
4478         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
4479         * arm-tdep.c (tdesc_arm_list): New variable.
4480         (arm_register_g_packet_guesses): Call create description functions.
4481         (arm_read_description) (arm_read_mprofile_description): New
4482         function.
4483         * arm-tdep.h (arm_read_description)
4484         (arm_read_mprofile_description): Add declaration.
4485         * configure.tgt: Add new files.
4486
4487 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
4488
4489         * top.c (new_ui_command): Open specified terminal just once.
4490
4491 2019-07-18  Tom Tromey  <tromey@adacore.com>
4492
4493         * symtab.c (main_name): Constify return type.
4494         * symfile.c (set_initial_language): Update.
4495         * symtab.h (main_name): Constify return type.
4496
4497 2019-07-17  Tom Tromey  <tom@tromey.com>
4498
4499         * tui/tui-winsource.c (tui_update_source_window)
4500         (tui_update_source_window_as_is)
4501         (tui_update_source_windows_with_line): Remove return.
4502         * tui/tui-disasm.c (tui_show_disassem)
4503         (tui_show_disassem_and_update_source): Remove return.
4504         * tui/tui.c (tui_reset): Remove return.
4505         * tui/tui-wingeneral.c
4506         (tui_check_and_display_highlight_if_needed): Remove return.
4507
4508 2019-07-17  Tom Tromey  <tom@tromey.com>
4509
4510         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
4511
4512 2019-07-17  Tom Tromey  <tom@tromey.com>
4513
4514         * tui/tui-winsource.h (struct tui_exec_info_window)
4515         (struct tui_source_window_base): Move from tui-data.h.
4516         * tui/tui-winsource.c: Move many method definitions from
4517         elsewhere.  Remove "structuring" comments.
4518         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
4519         (tui_source_window_base::refresh_window): Move to
4520         tui-winsource.c.
4521         * tui/tui-win.c (tui_source_window_base::refresh_all)
4522         (tui_source_window_base::update_tab_width)
4523         (tui_source_window_base::set_new_height)
4524         (tui_source_window_base::do_make_visible_with_new_height): Move to
4525         tui-winsource.c.
4526         * tui/tui-source.h: Update.
4527         * tui/tui-source.c (tui_source_window_base::reset): Move to
4528         tui-winsource.c.
4529         * tui/tui-disasm.h: Update.
4530         * tui/tui-data.h (struct tui_exec_info_window): Move to
4531         tui-winsource.h.
4532         (struct tui_source_window_base): Likewise.
4533         * tui/tui-data.c (tui_source_window_base::clear_detail)
4534         (tui_source_window_base, ~tui_source_window_base): Move to
4535         tui-winsource.c.
4536
4537 2019-07-17  Tom Tromey  <tom@tromey.com>
4538
4539         * tui/tui-win.c (tui_resize_all)
4540         (tui_source_window_base::update_tab_width)
4541         (tui_adjust_win_heights): Update.
4542         (tui_win_info::make_invisible_and_set_new_height): Rename from
4543         make_invisible_and_set_new_height.
4544         * tui/tui-data.h (struct tui_win_info)
4545         <make_invisible_and_set_new_height>: New method.
4546
4547 2019-07-17  Tom Tromey  <tom@tromey.com>
4548
4549         * tui/tui.c: Update.
4550         * tui/tui-source.h (struct tui_source_window): Move from
4551         tui-data.h.
4552         * tui/tui-layout.c: Update.
4553         * tui/tui-disasm.c: Update.
4554         * tui/tui-data.h (struct tui_source_window): Move to
4555         tui-source.h.
4556
4557 2019-07-17  Tom Tromey  <tom@tromey.com>
4558
4559         * tui/tui-disasm.h (struct tui_disasm_window): Move from
4560         tui-data.h.
4561         * tui/tui-data.h (struct tui_disasm_window): Move to
4562         tui-disasm.h.
4563
4564 2019-07-17  Tom Tromey  <tom@tromey.com>
4565
4566         * tui/tui-regs.h (struct tui_data_item_window): Move from
4567         tui-data.h.
4568         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
4569         * tui/tui-data.h (struct tui_data_item_window): Move to
4570         tui-regs.h.
4571         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
4572
4573 2019-07-17  Tom Tromey  <tom@tromey.com>
4574
4575         * tui/tui.c: Update.
4576         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
4577         (tui_cmd_window::max_height): Move to tui-command.c.
4578         * tui/tui-layout.c: Update.
4579         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
4580         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
4581         tui-command.c.
4582         * tui/tui-command.h (struct tui_cmd_window): Move from
4583         tui-data.h.
4584         * tui/tui-command.c: Remove "structuring" comments.
4585         (tui_cmd_window::clear_detail)
4586         (tui_cmd_window::do_make_visible_with_new_height)
4587         (tui_cmd_window::max_height): Move from elsewhere.
4588
4589 2019-07-17  Tom Tromey  <tom@tromey.com>
4590
4591         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
4592         Now static.
4593         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
4594         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
4595
4596 2019-07-17  Tom Tromey  <tom@tromey.com>
4597
4598         * tui/tui.c: Update.
4599         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
4600         tui-regs.c.
4601         * tui/tui-windata.h: Remove file.
4602         * tui/tui-windata.c: Remove file.
4603         * tui/tui-win.c (tui_data_window::set_new_height)
4604         (tui_data_window::do_make_visible_with_new_height): Move to
4605         tui-regs.c.
4606         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
4607         * tui/tui-regs.c: Remove "structuring" comments.
4608         (tui_data_window::first_data_item_displayed)
4609         (tui_data_window::delete_data_content_windows)
4610         (tui_data_window::erase_data_content)
4611         (tui_data_window::display_all_data)
4612         (tui_data_window::refresh_all)
4613         (tui_data_window::do_scroll_vertical)
4614         (tui_data_window::clear_detail, tui_data_window::set_new_height)
4615         (tui_data_window::do_make_visible_with_new_height)
4616         (tui_data_window::refresh_window): Move from elsewhere.
4617         (_initialize_tui_regs): Move to end of file.
4618         * tui/tui-layout.c: Update.
4619         * tui/tui-hooks.c: Update.
4620         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
4621         * tui/tui-data.c (tui_data_window::clear_detail): Move to
4622         tui-regs.c.
4623         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
4624
4625 2019-07-17  Tom Tromey  <tom@tromey.com>
4626
4627         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
4628         seen.
4629
4630 2019-07-17  Tom Tromey  <tom@tromey.com>
4631
4632         * tui/tui-win.c (tui_source_window_base::set_new_height)
4633         (tui_source_window_base::do_make_visible_with_new_height): Use
4634         m_has_locator field directly.
4635         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
4636         method.
4637         (struct tui_source_window_base) <has_locator>: Likewise.
4638
4639 2019-07-17  Tom Tromey  <tom@tromey.com>
4640
4641         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
4642         Don't declare.
4643         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
4644         Remove.
4645         * tui/tui-win.c (tui_source_window_base::set_new_height)
4646         (tui_source_window_base::set_new_height)
4647         (make_invisible_and_set_new_height)
4648         (tui_source_window_base::do_make_visible_with_new_height)
4649         (tui_source_window_base::do_make_visible_with_new_height):
4650         Update.
4651         * tui/tui-layout.c (show_source_disasm_command, show_data)
4652         (show_source_or_disasm_and_command): Update.
4653         * tui/tui-layout.c (show_layout): Update.
4654
4655 2019-07-17  Tom Tromey  <tom@tromey.com>
4656
4657         * tui/tui-layout.c (make_data_window): Remove.
4658         (show_data): Unify creation and re-initialization cases.
4659
4660 2019-07-17  Tom Tromey  <tom@tromey.com>
4661
4662         * tui/tui-layout.c (make_source_window, make_disasm_window):
4663         Remove.
4664         (show_data): Unify creation and re-initialization cases.
4665
4666 2019-07-17  Tom Tromey  <tom@tromey.com>
4667
4668         * tui/tui-layout.c (make_command_window): Remove.
4669         (show_source_disasm_command, show_source_or_disasm_and_command):
4670         Unify creation and re-initialization cases.
4671
4672 2019-07-17  Tom Tromey  <tom@tromey.com>
4673
4674         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
4675         creation and re-initialization cases.
4676
4677 2019-07-17  Tom Tromey  <tom@tromey.com>
4678
4679         * tui/tui-regs.c (tui_get_register): Return void.
4680
4681 2019-07-17  Tom Tromey  <tom@tromey.com>
4682
4683         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
4684         Simplify.
4685
4686 2019-07-17  Tom Tromey  <tom@tromey.com>
4687
4688         * tui/tui-layout.c (show_source_disasm_command): Simplify window
4689         resetting.
4690
4691 2019-07-17  Tom Tromey  <tom@tromey.com>
4692
4693         * tui/tui.h (tui_set_layout_by_name): Don't declare.
4694         * tui/tui-regs.c (tui_reg_layout): New function.
4695         (tui_show_registers, tui_reg_command): Use it.
4696         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
4697         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
4698         parameters.
4699         (tui_layout_command): Remove.
4700
4701 2019-07-17  Tom Tromey  <tom@tromey.com>
4702
4703         * tui/tui-layout.h (tui/tui-layout): Return void.
4704         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
4705
4706 2019-07-17  Tom Tromey  <tom@tromey.com>
4707
4708         * tui/tui-layout.c (show_source_disasm_command, show_data):
4709         Update.
4710         (reset_locator): Remove.
4711         (show_source_or_disasm_and_command): Update.
4712
4713 2019-07-17  Tom Tromey  <tom@tromey.com>
4714
4715         * tui/tui-source.c (tui_source_window_base::reset): Remove
4716         win_type parameter.
4717         * tui/tui-layout.c (make_command_window, make_source_window)
4718         (make_disasm_window, make_data_window)
4719         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
4720         (reset_locator, show_source_or_disasm_and_command): Update.
4721         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
4722         win_type parameter.
4723         (struct tui_source_window_base) <reset>: Likewise.
4724
4725 2019-07-17  Tom Tromey  <tom@tromey.com>
4726
4727         * tui/tui-layout.c (show_source_disasm_command): Use
4728         reset_locator.
4729         (reset_locator): New function.
4730         (init_and_make_win): Remove.
4731         (show_source_or_disasm_and_command): Use reset_locator.
4732
4733 2019-07-17  Tom Tromey  <tom@tromey.com>
4734
4735         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
4736         condition.
4737         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
4738         Remove condition.
4739         * tui/tui-source.c (tui_source_window_base::reset): New method.
4740         * tui/tui-layout.c (make_command_window): Don't call
4741         init_and_make_win.
4742         (make_source_window, make_disasm_window): Don't call
4743         make_source_or_disasm_window.
4744         (make_data_window): Don't call init_and_make_win.  Change calling
4745         convention.
4746         (show_source_disasm_command, show_data): Simplify.
4747         (make_source_or_disasm_window): Remove.
4748         (show_source_or_disasm_and_command): Simplify.
4749         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
4750         (struct tui_source_window_base) <reset>: Likewise.
4751         <execution_info>: Remove initializer.
4752         * tui/tui-data.c (tui_source_window_base): Initialize
4753         execution_info.
4754
4755 2019-07-17  Tom Tromey  <tom@tromey.com>
4756
4757         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
4758         variable.
4759
4760 2019-07-17  Tom Tromey  <tom@tromey.com>
4761
4762         * tui/tui.c (tui_rl_other_window): Update.
4763         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
4764         superclass method first.  Always iterate over regs_content.
4765         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
4766         method.
4767         * tui/tui-win.c (tui_set_focus_command): Update.
4768
4769 2019-07-17  Tom Tromey  <tom@tromey.com>
4770
4771         * tui/tui-win.c (tui_set_focus_command): Rename from
4772         tui_set_focus.  Call tui_enable.
4773         (tui_set_focus_command): Remove.
4774
4775 2019-07-17  Tom Tromey  <tom@tromey.com>
4776
4777         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
4778         refresh_window.
4779         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
4780         touchwin.
4781         (tui_data_window::refresh_window): Call refresh_window on data
4782         items.  Always call superclass refresh_window.
4783         (tui_win_info::refresh): Remove.
4784         (tui_source_window_base::refresh_window): Update.
4785         (tui_refresh_all): Update.
4786         * tui/tui-layout.c (show_source_disasm_command): Remove call to
4787         refresh_window.
4788         (show_source_or_disasm_and_command): Likewise.
4789         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
4790         (struct tui_source_window_base) <refresh>: Likewise.
4791
4792 2019-07-17  Tom Tromey  <tom@tromey.com>
4793
4794         * tui/tui-winsource.c (tui_clear_source_content)
4795         (tui_show_source_content): Update.
4796         * tui/tui-source.c (tui_source_window::showing_source_p): Check
4797         whether content is empty.
4798         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
4799         Remove.
4800
4801 2019-07-17  Tom Tromey  <tom@tromey.com>
4802
4803         * tui/tui-winsource.c (tui_erase_source_content): Clear the
4804         window's contents.
4805         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
4806         * tui/tui-source.c (tui_set_source_content_nil): Remove.
4807
4808 2019-07-17  Tom Tromey  <tom@tromey.com>
4809
4810         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
4811         (struct tui_data_item_window): Update.
4812
4813 2019-07-17  Tom Tromey  <tom@tromey.com>
4814
4815         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
4816         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
4817         defines.
4818
4819 2019-07-17  Tom Tromey  <tom@tromey.com>
4820
4821         * tui/tui-winsource.h (tui_erase_source_content)
4822         (tui_clear_source_content): Remove "display_prompt" parameter.
4823         * tui/tui-winsource.c (tui_update_source_window_as_is)
4824         (tui_update_source_windows_with_addr): Update.
4825         (tui_clear_source_content): Remove "display_prompt" parameter.
4826         (tui_erase_source_content): Likewise.  Simplify.
4827         (tui_show_source_content): Update.
4828         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
4829         * tui/tui-stack.c (tui_show_frame_info): Update.
4830         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
4831         Remove defines.
4832
4833 2019-07-17  Tom Tromey  <tom@tromey.com>
4834
4835         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
4836         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
4837         parameter.
4838         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
4839         parameter.
4840
4841 2019-07-17  Tom Tromey  <tom@tromey.com>
4842
4843         * tui/tui-winsource.c (tui_clear_source_content)
4844         (tui_show_source_content, tui_show_exec_info_content)
4845         (tui_clear_exec_info_content): Update.
4846         * tui/tui-stack.c (tui_show_locator_content): Update.
4847         (tui_show_frame_info): Update.
4848         * tui/tui-source.h (tui_source_window): Don't declare.
4849         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
4850         from tui_source_is_displayed.
4851         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
4852         Remove field.
4853         (struct tui_source_window_base) <content_in_use>: New field.  Now
4854         bool.
4855         (struct tui_source_window) <showing_source_p>: New method.
4856         (TUI_SRC_WIN): Change cast.
4857         * tui/tui-data.c (tui_initialize_static_data): Update.
4858
4859 2019-07-17  Tom Tromey  <tom@tromey.com>
4860
4861         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
4862         location_matches_p.
4863         * tui/tui-source.c (tui_source_window::location_matches_p): New
4864         method.
4865         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
4866         method.
4867         * tui/tui-data.h (struct tui_source_window_base)
4868         <location_matches_p>: New method.
4869         (struct tui_source_window, struct tui_disasm_window)
4870         <location_matches_p>: Likewise.
4871
4872 2019-07-17  Tom Tromey  <tom@tromey.com>
4873
4874         * tui/tui-win.c (tui_set_win_height_command): Rename from
4875         tui_set_win_height.
4876         (tui_set_win_height_command): Remove.
4877
4878 2019-07-17  Tom Tromey  <tom@tromey.com>
4879
4880         * tui/tui-source.c (tui_source_window): New constructor.  Add
4881         observer.
4882         (~tui_source_window): New destructor.
4883         (tui_source_window::style_changed): New method.
4884         * tui/tui-hooks.c (tui_redisplay_source): Remove.
4885         (tui_attach_detach_observers): Update.
4886         * tui/tui-data.h (struct tui_source_window): Make constructor not
4887         inline.  Add destructor.
4888         (struct tui_source_window) <style_changed>: New method.
4889         <m_observable>: New member.
4890
4891 2019-07-17  Tom Tromey  <tom@tromey.com>
4892
4893         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
4894         * tui/tui-win.c (tui_resize_all): Fix typo.
4895
4896 2019-07-17  Tom Tromey  <tom@tromey.com>
4897
4898         * tui/tui-wingeneral.h (tui_refresh_all): Update.
4899         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
4900         (tui_refresh_all): Remove "list" parameter.  Use foreach.
4901         * tui/tui-win.c (window_name_completer): Use foreach.
4902         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
4903         (update_tab_width): Likewise.
4904         * tui/tui-layout.c (show_layout): Update.
4905         * tui/tui-data.h (class tui_window_iterator): New.
4906         (struct all_tui_windows): New.
4907         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
4908
4909 2019-07-17  Tom Tromey  <tom@tromey.com>
4910
4911         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
4912         parameter.  Don't reference globals.
4913         (tui_reg_command): Update.
4914
4915 2019-07-17  Tom Tromey  <tom@tromey.com>
4916
4917         * tui/tui-regs.c (tui_show_registers): Simplify.
4918
4919 2019-07-17  Tom Tromey  <tom@tromey.com>
4920
4921         * tui/tui-regs.c (tui_show_registers): Update.
4922         (tui_show_register_group): Add win_info parameter.
4923
4924 2019-07-17  Tom Tromey  <tom@tromey.com>
4925
4926         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
4927         Rename from tui_display_reg_element_at_line.
4928         (tui_data_window::display_registers_from_line): Update.
4929         * tui/tui-data.h (struct tui_data_window)
4930         <display_reg_element_at_line>: New method.
4931
4932 2019-07-17  Tom Tromey  <tom@tromey.com>
4933
4934         * tui/tui-regs.h (tui_display_registers_from)
4935         (tui_display_registers_from_line): Don't declare.
4936         * tui/tui-windata.c (tui_data_window::display_all_data)
4937         (tui_data_window::refresh_all)
4938         (tui_data_window::do_scroll_vertical): Update.
4939         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
4940         from tui_display_registers_from.
4941         (tui_display_reg_element_at_line): Update.
4942         (tui_data_window::display_registers_from_line): Rename from
4943         tui_display_registers_from_line.
4944         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
4945         display_registers_from_line>: New methods.
4946
4947 2019-07-17  Tom Tromey  <tom@tromey.com>
4948
4949         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
4950         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
4951         from tui_erase_data_content.
4952         (tui_data_window::display_all_data)
4953         (tui_data_window::refresh_all)
4954         (tui_data_window::do_scroll_vertical): Update.
4955         * tui/tui-regs.c (tui_show_registers): Update.
4956         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
4957         New method.
4958
4959 2019-07-17  Tom Tromey  <tom@tromey.com>
4960
4961         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
4962         declare.
4963         * tui/tui-windata.c
4964         (tui_data_window::delete_data_content_windows): Rename from
4965         tui_delete_data_content_windows.
4966         (tui_data_window::display_all_data)
4967         (tui_data_window::do_scroll_vertical): Update.
4968         * tui/tui-data.h (struct tui_data_window)
4969         <delete_data_content_windows>: New method.
4970
4971 2019-07-17  Tom Tromey  <tom@tromey.com>
4972
4973         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
4974         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
4975
4976 2019-07-17  Tom Tromey  <tom@tromey.com>
4977
4978         * tui/tui-windata.h (tui_display_all_data): Don't declare.
4979         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
4980         from tui_display_all_data.
4981         * tui/tui-win.c
4982         (tui_data_window::do_make_visible_with_new_height): Update.
4983         * tui/tui-regs.c (tui_show_registers): Update.
4984         * tui/tui-layout.c (tui_set_layout): Update.
4985         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
4986         method.
4987
4988 2019-07-17  Tom Tromey  <tom@tromey.com>
4989
4990         * tui/tui-windata.h (tui_display_data_from): Don't declare.
4991         * tui/tui-windata.c (tui_display_data_from): Remove.
4992         (tui_data_window::refresh_all): Update.
4993
4994 2019-07-17  Tom Tromey  <tom@tromey.com>
4995
4996         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
4997         * tui/tui-windata.c (tui_display_data_from_line): Remove.
4998         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
4999         tui_display_registers_from_line.
5000         * tui/tui-regs.h (tui_display_registers_from_line): Update.
5001         * tui/tui-regs.c (tui_display_registers_from_line): Remove
5002         "force_display" parameter.
5003
5004 2019-07-17  Tom Tromey  <tom@tromey.com>
5005
5006         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
5007         declare.
5008         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
5009         Rename from tui_first_reg_element_no_inline.
5010         (tui_display_reg_element_at_line)
5011         (tui_display_registers_from_line): Update.
5012         * tui/tui-data.h (struct tui_data_window)
5013         <first_reg_element_no_inline>: New method.
5014
5015 2019-07-17  Tom Tromey  <tom@tromey.com>
5016
5017         * tui/tui-windata.c (tui_display_data_from)
5018         (tui_data_window::do_scroll_vertical): Update.
5019         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
5020         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
5021         Rename from tui_line_from_reg_element_no.
5022         (tui_display_registers_from_line): Update.
5023         * tui/tui-data.h (struct tui_data_window)
5024         <line_from_reg_element_no>: New method.
5025
5026 2019-07-17  Tom Tromey  <tom@tromey.com>
5027
5028         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
5029         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
5030         tui_last_regs_line_no.
5031         (tui_display_reg_element_at_line)
5032         (tui_display_registers_from_line): Update.
5033         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
5034         method.
5035
5036 2019-07-17  Tom Tromey  <tom@tromey.com>
5037
5038         PR tui/24722:
5039         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
5040         (tui_update_breakpoint_info): Add "being_deleted" parameter.
5041         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
5042         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
5043         (tui_update_breakpoint_info): Likewise.
5044         * tui/tui-hooks.c (tui_event_create_breakpoint)
5045         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
5046         Update.
5047
5048 2019-07-17  Tom Tromey  <tom@tromey.com>
5049
5050         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
5051
5052 2019-07-17  Tom Tromey  <tom@tromey.com>
5053
5054         * tui/tui-winsource.c (tui_update_source_window_as_is)
5055         (tui_update_source_windows_with_addr): Update.
5056         * tui/tui-source.h (tui_set_source_content)
5057         (tui_show_symtab_source): Add "win_info" parameter.
5058         * tui/tui-source.c (tui_set_source_content): Add "win_info"
5059         parameter.
5060         (tui_show_symtab_source): Likewise.
5061
5062 2019-07-17  Tom Tromey  <tom@tromey.com>
5063
5064         * tui/tui-wingeneral.c
5065         (tui_check_and_display_highlight_if_needed): Check can_highlight.
5066
5067 2019-07-17  Tom Tromey  <tom@tromey.com>
5068
5069         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
5070         (struct tui_cmd_window) <can_scroll>: New method.
5071         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
5072         method.
5073
5074 2019-07-17  Tom Tromey  <tromey@adacore.com>
5075
5076         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
5077         do_field_signed>: Rename.  Change type of "value".
5078         * ui-out.c (ui_out::field_signed): Rename from field_int.
5079         Change type of "value".
5080         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
5081         type of "value".
5082         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
5083         do_field_int.  Change type of "value".
5084         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
5085         do_field_int.  Change type of "value".
5086         * tracepoint.c (trace_status_mi, tfind_1)
5087         (print_one_static_tracepoint_marker): Update.
5088         * thread.c (print_thread_info_1, print_selected_thread_frame):
5089         Update.
5090         * stack.c (print_frame, print_frame_info): Update.
5091         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
5092         Update.
5093         * source.c (print_source_lines_base): Update.
5094         * skip.c (info_skip_command): Update.
5095         * record-btrace.c (btrace_ui_out_decode_error)
5096         (btrace_call_history_src_line): Update.
5097         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
5098         Update.
5099         * progspace.c (print_program_space): Update.
5100         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
5101         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
5102         do_field_int.  Change type of "value".
5103         * mi/mi-out.c (mi_ui_out::do_table_begin)
5104         (mi_ui_out::do_table_header): Update.
5105         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
5106         type of "value".
5107         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
5108         (mi_cmd_data_list_changed_registers, output_register)
5109         (mi_cmd_data_read_memory, mi_load_progress)
5110         (mi_cmd_trace_frame_collected): Update.
5111         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
5112         Update.
5113         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
5114         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
5115         (mi_cmd_var_list_children, varobj_update_one): Update.
5116         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
5117         (mi_cmd_stack_list_args, list_arg_or_local): Update.
5118         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
5119         * inferior.c (print_inferior): Update.
5120         * gdb_bfd.c (print_one_bfd): Update.
5121         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
5122         Update.
5123         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
5124         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
5125         do_field_int.  Change type of "value".
5126         * cli-out.c (cli_ui_out::do_field_signed): Rename from
5127         do_field_int.  Change type of "value".
5128         * breakpoint.c (watchpoint_check, print_breakpoint_location)
5129         (print_one_breakpoint_location, print_it_catch_fork)
5130         (print_one_catch_fork, print_it_catch_vfork)
5131         (print_one_catch_vfork, print_it_catch_solib)
5132         (print_it_catch_exec, print_it_ranged_breakpoint)
5133         (print_mention_watchpoint, print_mention_masked_watchpoint)
5134         (bkpt_print_it, update_static_tracepoint): Update.
5135         * break-catch-throw.c (print_it_exception_catchpoint): Update.
5136         * break-catch-syscall.c (print_it_catch_syscall): Update.
5137         * ada-tasks.c (print_ada_task_info): Update.
5138         * ada-lang.c (print_it_exception, print_mention_exception):
5139         Update.
5140
5141 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
5142
5143         PR breakpoints/24541
5144         * gdbarch.c: Regenerate.
5145         * gdbarch.h: Regenerate.
5146         * gdbarch.sh: Adjust return type and parameter types for
5147         'stap_adjust_register'.
5148         (i386_stap_adjust_register): Adjust signature and return new
5149         register name.
5150         * stap-probe.c (stap_parse_register_operand): Adjust use of
5151         'gdbarch_stap_adjust_register'.
5152
5153 2019-07-17  Tom Tromey  <tromey@adacore.com>
5154
5155         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
5156         declare VEC.
5157         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
5158         std::vector.
5159         (struct s390_process_info): Add initializers.
5160         (s390_add_process): Use new.
5161         (s390_linux_nat_target::low_forget_process): Use delete.
5162         (s390_linux_nat_target::low_new_fork)
5163         (s390_linux_nat_target::stopped_by_watchpoint)
5164         (s390_linux_nat_target::low_prepare_to_resume)
5165         (s390_linux_nat_target::insert_watchpoint)
5166         (s390_linux_nat_target::insert_hw_breakpoint)
5167         (s390_linux_nat_target::remove_watchpoint)
5168         (s390_linux_nat_target::remove_hw_breakpoint): Update.
5169
5170 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
5171
5172         * aarch64-fbsd-nat.c: Include regcache.h.
5173         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
5174         argument.
5175         (aarch64_fbsd_nat_target::fetch_registers)
5176         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
5177         variable.
5178         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
5179
5180 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
5181
5182         * fbsd-nat.c: Include gdbarch.h.
5183
5184 2019-07-15  Tom Tromey  <tromey@adacore.com>
5185
5186         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
5187
5188 2019-07-15  Tom Tromey  <tromey@adacore.com>
5189
5190         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
5191         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
5192         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
5193         * cli-out.c (cli_ui_out::do_field_int): New method.
5194         * ui-out.c (ui_out::field_unsigned): New method.
5195         * symfile.c (generic_load): Use field_unsigned.
5196         (print_transfer_performance): Likewise.
5197         * record-btrace.c (ui_out_field_uint): Remove.
5198         (btrace_call_history_insn_range, btrace_call_history): Use
5199         field_unsigned.
5200         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
5201         field_unsigned.
5202         * ui-out.h (class ui_out) <field_unsigned>: New method.
5203         <do_field_unsigned>: Likewise.
5204
5205 2019-07-15  Tom Tromey  <tromey@adacore.com>
5206
5207         * mi/mi-main.c (list_available_thread_groups): Use field_string.
5208         * mi/mi-interp.c (mi_memory_changed): Use field_string.
5209         * target.c (flash_erase_command): Use field_string.
5210         * infrun.c (print_signal_received_reason): Use field_string.
5211         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
5212         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
5213         field_string.
5214         * ada-tasks.c (print_ada_task_info): Use field_string.
5215
5216 2019-07-15  Tom Tromey  <tromey@adacore.com>
5217
5218         * target.c (flash_erase_command): Use field_core_addr.
5219         * symfile.c (generic_load): Use field_core_addr.
5220         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
5221         Use field_core_addr.
5222         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
5223         field_core_addr.
5224
5225 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
5226
5227         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
5228         value if its desired type is smaller than a CORE_ADDR and signed.
5229
5230 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
5231
5232         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
5233         of changes to field names, and use new is_reference field to
5234         decide if a property is a reference or not.
5235         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
5236         field.
5237         (struct dwarf2_property_baton): Update header comment, rename
5238         'referenced_type' to 'property_type' and update comments.
5239         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
5240         default property type, store in property baton, update to take
5241         accound of renamed field.
5242         (read_func_scope): Update call to attr_to_dynamic_prop.
5243         (read_array_type): Likewise.
5244         (dwarf2_per_cu_addr_sized_int_type): New function.
5245         (read_subrange_index_type): Move type finding code to
5246         dwarf2_per_cu_addr_sized_int_type.
5247         (read_subrange_type): Update calls to attr_to_dynamic_prop.
5248         (dwarf2_per_cu_addr_type): New function.
5249         (set_die_type): Update calls to attr_to_dynamic_prop.
5250
5251 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
5252
5253         * dwarf2read.c (read_subrange_index_type): New function.
5254         (read_subrange_type): Move code into new function and call it.
5255         * gdbtypes.c (create_range_type): Add some asserts.
5256
5257 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
5258
5259         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
5260         update return statements.
5261         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
5262         declaration, and update comment to match.
5263         * gdbtypes.c (resolve_dynamic_array): Update call to
5264         dwarf2_evaluate_property to match new return type.
5265
5266 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
5267
5268         * valarith.c (value_subscripted_rvalue): Change lowerbound
5269         parameter type from int to LONGEST.
5270         * value.h (value_subscripted_rvalue): Likewise in declaration.
5271
5272 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5273
5274         * cli/cli-utils.c (info_print_command_completer): New function.
5275         * cli/cli-utils.h: Add 'completer.h' include, and forward
5276         declaration for 'struct cmd_list_element'.
5277         (info_print_command_completer): Declare.
5278         * stack.c (_initialize_stack): Add completer for 'info locals' and
5279         'info args'.
5280         * symtab.c (_initialize_symtab): Add completer for 'info
5281         variables' and 'info functions'.
5282         * NEWS: Mention completion for additional info commands.
5283
5284 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5285
5286         * cli/cli-utils.c (extract_info_print_args): Delete.
5287         (extract_arg_maybe_quoted): Delete.
5288         (info_print_options_defs): New variable.
5289         (make_info_print_options_def_group): New function.
5290         (extract_info_print_options): Define new function.
5291         * cli/cli-utils.h (extract_info_print_args): Delete.
5292         (struct info_print_options): New structure.
5293         (extract_info_print_options): Declare new function.
5294         * stack.c (info_locals_command): Update to use new
5295         extract_info_print_options, also add a header comment.
5296         (info_args_command): Likewise.
5297         * symtab.c (info_variables_command): Likewise.
5298         (info_functions_command): Likewise.
5299
5300 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5301
5302         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
5303         to extract string arguments.
5304         * common/common-utils.c (extract_string_maybe_quoted): New function.
5305         * common/common-utils.h (extract_string_maybe_quoted): Declare.
5306
5307 2019-07-11  Tom Tromey  <tromey@adacore.com>
5308
5309         * main.c (get_init_files): Use GDBINIT, not gdbinit.
5310         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
5311         * top.h (gdbinit): Don't declare.
5312         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
5313         into...
5314         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
5315         * top.c (gdb_init): Don't call init_cli_cmds.
5316         (gdbinit): Remove.
5317         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
5318
5319 2019-07-11  Tom Tromey  <tromey@adacore.com>
5320
5321         * python/py-inferior.c (add_thread_object): Don't use thread_obj
5322         after it has been moved.
5323
5324 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
5325
5326         * valops.c (value_must_coerce_to_target): Change return type to
5327         bool.
5328         * value.h (value_must_coerce_to_target): Likewise.
5329
5330 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
5331
5332         * breakpoint.c (is_hardware_watchpoint): Remove
5333         forward-declaration.
5334         (is_masked_watchpoint): Change return type to bool.
5335         (is_tracepoint): Likewise.
5336         (is_breakpoint): Likewise.
5337         (is_hardware_watchpoint): Likewise.
5338         (is_watchpoint): Likewise.
5339         (is_no_memory_software_watchpoint): Likewise.
5340         (is_catchpoint): Likewise.
5341         (breakpoint_1): Make FILTER parameter's return type bool.
5342         is_masked_watchpoint): Change return type to bool.
5343         (save_breakpoints): Make FILTER parameter's return type bool.
5344         * breakpoint.h (is_breakpoint): Change return type to bool.
5345         (is_watchpoint): Likewise.
5346         (is_catchpoint): Likewise.
5347         (is_tracepoint): Likewise.
5348
5349 2019-07-10  Tom Tromey  <tom@tromey.com>
5350
5351         * defs.h: Don't include gdbarch.h.
5352         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
5353         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
5354         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
5355         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
5356         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
5357         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
5358         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
5359         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
5360         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
5361         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
5362         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
5363         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
5364         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
5365         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
5366         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
5367         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
5368         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
5369         record-btrace.c, record.h, regcache-dump.c, regcache.h,
5370         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
5371         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
5372         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
5373         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
5374         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
5375         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
5376         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
5377         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
5378         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
5379
5380 2019-07-10  Tom Tromey  <tromey@adacore.com>
5381
5382         * ada-lang.h (is_ada_exception_catchpoint): Declare.
5383         * breakpoint.c (init_ada_exception_breakpoint): Register as
5384         bp_catchpoint.
5385         (print_one_breakpoint_location, print_one_breakpoint): Use
5386         is_ada_exception_catchpoint.
5387         * ada-lang.c (class ada_catchpoint_location): Pass
5388         bp_loc_software_breakpoint to bp_location constructor.
5389         (is_ada_exception_catchpoint): New function.
5390
5391 2019-07-10  Tom Tromey  <tromey@adacore.com>
5392
5393         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
5394         VEC.
5395         (struct arm_exidx_entry): New method operator<.
5396         (struct arm_exidx_data) <section_maps>: Change type.
5397         (arm_exidx_data_free): Remove.
5398         (arm_exidx_data_key): Change type.  Move lower.
5399         (arm_exidx_new_objfile): Update.
5400         (arm_compare_exidx_entries): Remove.
5401         (arm_find_exidx_entry, _initialize_arm_tdep)
5402
5403 2019-07-10  Tom Tromey  <tromey@adacore.com>
5404
5405         * solib-spu.c (ocl_program_data_key): Change type.
5406         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
5407         Update.
5408
5409 2019-07-10  Tom Tromey  <tromey@adacore.com>
5410
5411         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
5412         (struct solib_aix_inferior_data) <library_list>: Change type.
5413         (solib_aix_inferior_data_handle): Change type.
5414         (get_solib_aix_inferior_data): Update.
5415         (solib_aix_free_library_list): Remove.
5416         (library_list_start_library): Update.
5417         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
5418         return type.
5419         (solib_aix_get_library_list)
5420         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
5421         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
5422
5423 2019-07-10  Tom Tromey  <tromey@adacore.com>
5424
5425         * solib-dsbt.c (struct dsbt_info): Add initializers.
5426         (solib_dsbt_pspace_data): Change type.
5427         (dsbt_pspace_data_cleanup): Remove.
5428         (get_dsbt_info, _initialize_dsbt_solib): Update.
5429
5430 2019-07-10  Tom Tromey  <tromey@adacore.com>
5431
5432         * spu-tdep.c (spu_overlay_data): Change type.
5433         (spu_get_overlay_table, spu_overlay_new_objfile)
5434         (_initialize_spu_tdep): Update.
5435
5436 2019-07-10  Tom Tromey  <tromey@adacore.com>
5437
5438         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
5439         destructor.
5440         (dbx_objfile_data_key): Change type and declare later.
5441         (DBX_SYMFILE_INFO): Rewrite.
5442         * dbxread.c (dbx_objfile_data_key): Change type.
5443         (dbx_symfile_init): Update.
5444         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
5445         (coffstab_build_psymtabs, elfstab_build_psymtabs)
5446         (stabsect_build_psymtabs, _initialize_dbxread): Update.
5447
5448 2019-07-10  Tom Tromey  <tromey@adacore.com>
5449
5450         * jit.c (jit_program_space_key): Change type.  Move lower.
5451         (get_jit_program_space_data): Update.
5452         (jit_program_space_data_cleanup): Remove.
5453         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
5454         Update.
5455         (struct jit_program_space_data): Add initializers.
5456
5457 2019-07-10  Tom Tromey  <tromey@adacore.com>
5458
5459         * solib-darwin.c (struct darwin_info): Add initializers.
5460         (solib_darwin_pspace_data): Change type.
5461         (darwin_pspace_data_cleanup): Remove.
5462         (get_darwin_info, _initialize_darwin_solib): Update.
5463
5464 2019-07-10  Tom Tromey  <tromey@adacore.com>
5465
5466         * remote-sim.c (struct sim_inferior_data): Add initializers,
5467         constructor, and destructor.
5468         (sim_inferior_data_key): Change type.  Move lower.
5469         (check_for_duplicate_sim_descriptor): Update.
5470         (get_sim_inferior_data): Use new.  Update.
5471         (~sim_inferior_data_cleanup): Rename from
5472         sim_inferior_data_cleanup.  Simplify.
5473         (gdbsim_close_inferior, simulator_command)
5474         (sim_command_completer, _initialize_remote_sim): Update.
5475         (next_pid, INITIAL_PID): Move earlier.
5476
5477 2019-07-10  Tom Tromey  <tromey@adacore.com>
5478
5479         * python/python-internal.h (create_thread_object): Return
5480         gdbpy_ref.
5481         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
5482         * python/py-inferior.c (struct threadlist_entry): Add
5483         constructor.
5484         <thread_obj>: Now a gdbpy_ref.
5485         (thread_to_thread_object): Update.
5486         (add_thread_object): Use new.
5487         (delete_thread_object): Use delete.
5488         (infpy_threads): Update.
5489         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
5490         GIL.
5491
5492 2019-07-10  Tom Tromey  <tromey@adacore.com>
5493
5494         * valops.c (value_cast): Specialize error message for Ada.
5495
5496 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
5497
5498         * breakpoint.c (breakpoint_1): Update doc and parameter names.
5499
5500 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
5501
5502         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
5503         bpstat_should_step): Return bool, adjust comments.
5504         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
5505         bpstat_should_step): Likewise.
5506
5507 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
5508
5509         * features/Makefile: Use feature target descriptions for Arm.
5510         * features/arm/arm-core.c: Generate new file.
5511         * features/arm/arm-fpa.c: Likewise.
5512         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
5513         * features/arm/arm-m-profile.c: Likewise.
5514         * features/arm/arm-vfpv2.c: Likewise.
5515         * features/arm/arm-vfpv3.c: Likewise.
5516         * features/arm/xscale-iwmmxt.c: Likewise.
5517         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
5518
5519 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
5520
5521         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
5522         ptrace earlier.
5523
5524 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
5525
5526         * features/aarch64-pauth.c: Regenerate.
5527
5528 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
5529
5530         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
5531         bool.
5532         (bpstat_what): Use false instead of 0.
5533
5534 2019-07-09  Pedro Alves  <palves@redhat.com>
5535
5536         * break-catch-throw.c (is_exception_catchpoint): New.
5537         * breakpoint.c (print_one_breakpoint_location): New parameter
5538         'raw_loc'.  Handle it.  Use
5539         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
5540         looking at the breakpoint's type.
5541         (print_one_breakpoint): If handling "maint info breakpoints", also
5542         print locations of exception catchpoints.
5543         * breakpoint.h (is_exception_catchpoint): Declare.
5544
5545 2019-07-09  Pedro Alves  <palves@redhat.com>
5546
5547         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
5548         "addr" field.
5549         (allocate_location_exception_catchpoint): New.
5550         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
5551         (initialize_throw_catchpoint_ops): Install
5552         allocate_location_exception_catchpoint as allocate_location
5553         method.
5554         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
5555         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
5556         bp_loc_other.
5557         (breakpoint_address_is_meaningful): Delete.
5558         (bl_address_is_meaningful): New.
5559         (breakpoint_locations_match): Adjust comment.
5560         (bp_location_from_bp_type): New, factored out of...
5561         (bp_location::bp_location(breakpoint *)): ... this.
5562         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
5563         factored out of...
5564         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
5565         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
5566         breakpoint_address_is_meaningful.
5567         (bp_locations_compare): Adjust comment.
5568         (update_global_location_list): Use bl_address_is_meaningful
5569         instead of breakpoint_address_is_meaningful.
5570         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
5571         explicit.
5572         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
5573         * python/py-breakpoint.c (bppy_get_location): No longer check
5574         whether location is null.
5575
5576 2019-07-09  Pedro Alves  <palves@redhat.com>
5577
5578         PR c++/15468
5579         * breakpoint.c (print_one_breakpoint_location): Remove
5580         single-location assert.
5581
5582 2019-07-09  Tom Tromey  <tom@tromey.com>
5583
5584         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
5585         * configure: Rebuild.
5586         * configure.ac: Change common to gdbsupport.
5587         * gdbsupport: Rename from common.
5588         * acinclude.m4: Change common to gdbsupport.
5589         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
5590         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
5591         gdbsupport.
5592         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
5593         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
5594         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
5595         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
5596         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
5597         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
5598         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
5599         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
5600         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
5601         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
5602         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
5603         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
5604         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
5605         coff-pe-read.c, command.h, compile/compile-c-support.c,
5606         compile/compile-c.h, compile/compile-cplus-symbols.c,
5607         compile/compile-cplus-types.c, compile/compile-cplus.h,
5608         compile/compile-loc2c.c, compile/compile.c, completer.c,
5609         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
5610         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
5611         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
5612         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
5613         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
5614         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
5615         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
5616         features/aarch64-core.c, features/aarch64-fpu.c,
5617         features/aarch64-pauth.c, features/aarch64-sve.c,
5618         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
5619         features/i386/32bit-core.c, features/i386/32bit-linux.c,
5620         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
5621         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
5622         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
5623         features/i386/64bit-core.c, features/i386/64bit-linux.c,
5624         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
5625         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
5626         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
5627         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
5628         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
5629         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
5630         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
5631         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
5632         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
5633         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
5634         go32-nat.c, guile/guile.c, guile/scm-ports.c,
5635         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
5636         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
5637         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
5638         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
5639         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
5640         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
5641         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
5642         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
5643         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
5644         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
5645         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
5646         minsyms.c, mips-linux-tdep.c, namespace.h,
5647         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
5648         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
5649         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
5650         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
5651         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
5652         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
5653         nat/linux-waitpid.c, nat/mips-linux-watch.c,
5654         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
5655         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
5656         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
5657         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
5658         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
5659         procfs.c, producer.c, progspace.h, psymtab.h,
5660         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
5661         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
5662         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
5663         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
5664         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
5665         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
5666         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
5667         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
5668         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
5669         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
5670         target-memory.c, target.c, target.h, target/waitstatus.c,
5671         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
5672         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
5673         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
5674         unittests/array-view-selftests.c,
5675         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
5676         unittests/common-utils-selftests.c,
5677         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
5678         unittests/format_pieces-selftests.c,
5679         unittests/function-view-selftests.c,
5680         unittests/lookup_name_info-selftests.c,
5681         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
5682         unittests/mkdir-recursive-selftests.c,
5683         unittests/observable-selftests.c,
5684         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
5685         unittests/parse-connection-spec-selftests.c,
5686         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
5687         unittests/scoped_fd-selftests.c,
5688         unittests/scoped_mmap-selftests.c,
5689         unittests/scoped_restore-selftests.c,
5690         unittests/string_view-selftests.c, unittests/style-selftests.c,
5691         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
5692         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
5693         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
5694         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
5695         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
5696         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
5697
5698 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
5699
5700         * linespec.c (decode_digits_list_mode): Set explicit_line to a
5701         bool value.
5702         (decode_digits_ordinary): Set explicit_line field in sal.
5703         * symtab.c (skip_prologue_sal): Don't skip prologue for a
5704         symtab_and_line that was set on an explicit line number in
5705         assembler code.  Do always update the recorded symtab and line if
5706         we do skip the prologue.
5707
5708 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
5709
5710         * breakpoint.c (set_breakpoint_location_function): Remove
5711         explicit_loc parameter.
5712         (momentary_breakpoint_from_master): Update call to
5713         set_breakpoint_location_function.
5714         (add_location_to_breakpoint): Likewise.
5715
5716 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
5717
5718         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
5719         required features based on default bfd type when no specific bfd
5720         is present.
5721
5722 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5723
5724         * NEWS: Mention that GDB printf and eval commands can now print
5725         C-style and Ada-style convenience var strings without
5726         calling the inferior.
5727         * printcmd.c (printf_c_string): Locally print GDB internal var
5728         instead of transiting via the inferior.
5729         (printf_wide_c_string): Likewise.
5730
5731 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5732
5733         PR breakpoints/25011
5734         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
5735
5736 2019-07-04  Tom Tromey  <tom@tromey.com>
5737
5738         PR tui/24724:
5739         * tui/tui-winsource.c (tui_clear_source_content): Update.
5740         (tui_source_window_base::set_is_exec_point_at): Fix comment.
5741         (tui_update_breakpoint_info): Update.
5742         (tui_set_exec_info_content): Update.
5743         * tui/tui-source.c (tui_set_source_content_nil): Update.
5744         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
5745         has_break.
5746         * tui/tui-data.h (enum tui_bp_flag): New.
5747         (tui_bp_flags): New enum flags type.
5748         (struct tui_source_element) <break_mode>: Change type.  Rename
5749         from has_break.
5750         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
5751         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
5752         constants.
5753         * tui/tui-winsource.h: Fix comment.
5754
5755 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5756
5757         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
5758         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
5759         (store_fpregs_to_thread)
5760         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
5761         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
5762         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
5763         (IWMMXT_REGS_SIZE): Add define.
5764         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
5765         (fetch_vfp_regs, store_vfp_regs)
5766         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
5767         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
5768
5769 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5770
5771         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
5772         defines.
5773         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
5774         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
5775         (ARM_INT_REGISTER_SIZE): ...to this.
5776         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
5777         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
5778         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
5779         (arm_linux_collect_gregset, supply_nwfpe_register)
5780         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
5781         defines.
5782         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
5783         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
5784         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
5785         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
5786         (arm_return_in_memory, arm_store_return_value)
5787         (arm_get_longjmp_target, arm_register_g_packet_guesses)
5788         (arm_record_ld_st_multiple): Likewise.
5789         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
5790         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
5791
5792 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5793
5794         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
5795         AARCH64_DISPLACED_MODIFIED_INSNS.
5796         * aarch64-tdep.c (struct aarch64_displaced_step_data)
5797         (aarch64_displaced_step_copy_insn): Likewise.
5798         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
5799         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
5800         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
5801         ARM_DISPLACED_MODIFIED_INSNS.
5802         * arm-tdep.c (arm_gdbarch_init): Likewise.
5803         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
5804         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
5805         (struct arm_displaced_step_closure): Use
5806         ARM_DISPLACED_MODIFIED_INSNS.
5807
5808 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5809
5810         * features/Makefile: Remove unused xml files.
5811         * features/aarch64.xml: Remove.
5812         * features/i386/amd64-avx-avx512-linux.xml: Remove.
5813         * features/i386/amd64-avx-avx512.xml: Remove.
5814         * features/i386/amd64-avx-linux.xml: Remove.
5815         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
5816         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
5817         * features/i386/amd64-avx-mpx-linux.xml: Remove.
5818         * features/i386/amd64-avx-mpx.xml: Remove.
5819         * features/i386/amd64-avx.xml: Remove.
5820         * features/i386/amd64-linux.xml: Remove.
5821         * features/i386/amd64-mpx-linux.xml: Remove.
5822         * features/i386/amd64-mpx.xml: Remove.
5823         * features/i386/amd64.xml: Remove.
5824         * features/i386/i386-avx-avx512-linux.xml: Remove.
5825         * features/i386/i386-avx-avx512.xml: Remove.
5826         * features/i386/i386-avx-linux.xml: Remove.
5827         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
5828         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
5829         * features/i386/i386-avx-mpx-linux.xml: Remove.
5830         * features/i386/i386-avx-mpx.xml: Remove.
5831         * features/i386/i386-avx.xml: Remove.
5832         * features/i386/i386-linux.xml: Remove.
5833         * features/i386/i386-mmx-linux.xml: Remove.
5834         * features/i386/i386-mmx.xml: Remove.
5835         * features/i386/i386-mpx-linux.xml: Remove.
5836         * features/i386/i386-mpx.xml: Remove.
5837         * features/i386/i386.xml: Remove.
5838         * features/i386/x32-avx-avx512-linux.xml: Remove.
5839         * features/i386/x32-avx-linux.xml: Remove.
5840         * features/i386/x32-linux.xml: Remove.
5841
5842 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5843
5844         * regformats/aarch64.dat: Remove.
5845         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
5846         * regformats/i386/amd64-avx-linux.dat: Remove.
5847         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
5848         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
5849         * regformats/i386/amd64-linux.dat: Remove.
5850         * regformats/i386/amd64-mpx-linux.dat: Remove.
5851         * regformats/i386/amd64.dat: Remove.
5852         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
5853         * regformats/i386/i386-avx-linux.dat: Remove.
5854         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
5855         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
5856         * regformats/i386/i386-linux.dat: Remove.
5857         * regformats/i386/i386-mmx-linux.dat: Remove.
5858         * regformats/i386/i386-mpx-linux.dat: Remove.
5859         * regformats/i386/i386.dat: Remove.
5860         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
5861         * regformats/i386/x32-avx-linux.dat: Remove.
5862         * regformats/i386/x32-linux.dat: Remove.
5863
5864 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5865
5866         * aarch64-tdep.c: Remove xml self tests.
5867         * amd64-linux-tdep.c: Likewise.
5868         * amd64-tdep.c: Likewise.
5869         * i386-linux-tdep.c: Likewise.
5870         * i386-tdep.c: Likewise.
5871
5872 2019-07-03  Pedro Alves  <palves@redhat.com>
5873
5874         PR cli/24732
5875         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
5876         (pipe_cmd_option_defs): New.
5877         (make_pipe_cmd_options_def_group): New.
5878         (pipe_command): Use gdb::option::process_options.
5879         (pipe_command_completer): New function.
5880         (_initialize_cli_cmds): Install completer for "pipe" command.
5881
5882 2019-07-03  Pedro Alves  <palves@redhat.com>
5883
5884         * cli/cli-option.c (union option_value) <string>: New field.
5885         (struct option_def_and_value): Add ctor, move ctor, dtor and
5886         use DISABLE_COPY_AND_ASSIGN.
5887         (option_def_and_value::clear_value): New.
5888         (parse_option, save_option_value_in_ctx, get_val_type_str)
5889         (add_setshow_cmds_for_options): Handle var_string.
5890         * cli-option.h (union option_def::var_address) <string>: New
5891         field.
5892         (struct string_option_def): New.
5893         * maint-test-options.c (struct test_options_opts): Add default
5894         ctor and use DISABLE_COPY_AND_ASSIGN.
5895         <string_opt>: New field.
5896         (test_options_opts::~test_options_opts): New.
5897         (test_options_opts::dump): Also dump "-string".
5898         (test_options_option_defs): Install "string.
5899
5900 2019-07-03  Pedro Alves  <palves@redhat.com>
5901
5902         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
5903         option_value with a null enumeration.
5904         (complete_options): Save the option values in the context.
5905         (save_option_value_in_ctx): New, factored out from ...
5906         (process_options): ... here.
5907         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
5908         of the function.
5909         * maint-test-options.c (test_options_opts::dump): New, factored
5910         out from ...
5911         (maintenance_test_options_command_mode): ... here.
5912         (maintenance_test_options_command_completion_result): Delete.
5913         (maintenance_test_options_command_completion_text): Update
5914         comment.
5915         (maintenance_show_test_options_completion_result): Change
5916         prototype.  Just print
5917         maintenance_test_options_command_completion_text.
5918         (save_completion_result): New.
5919         (maintenance_test_options_completer_mode): Pass options context to
5920         complete_options, and then save a dump.
5921         (_initialize_maint_test_options): Use add_cmd to install "maint
5922         show test-options-completion-result".
5923
5924 2019-07-03  Pedro Alves  <palves@redhat.com>
5925
5926         * NEWS (New commands): Mention "with" and "maint with".
5927         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
5928         (with_command, with_command_completer): New.
5929         (pipe_command): Adjust to new repeat_previous
5930         interface.
5931         (_initialize_cli_cmds): Install the "with" command and its "w"
5932         alias.
5933         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
5934         declarations.
5935         * cli/cli-setshow.c (parse_cli_var_uinteger)
5936         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
5937         argument strings for all var_types.
5938         (get_setshow_command_value_string): New, factored out from ...
5939         (do_show_command): ... this.
5940         * cli/cli-setshow.h: Include <string>.
5941         (get_setshow_command_value_string): Declare.
5942         * command.h (repeat_previous): Now returns const char *.  Adjust
5943         comment.
5944         * maint.c: Include "cli/cli-cmds.h".
5945         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
5946         (_initialize_maint_cmds): Register the "maintenance with" command.
5947         * top.c (repeat_previous): Move bits from pipe_command here:
5948         Return the saved command line, if any; error out if there's no
5949         command to relaunch.
5950
5951 2019-07-03  Pedro Alves  <palves@redhat.com>
5952
5953         * NEWS (New commands): Mention "maint set/show test-settings"
5954         instead of "maint test-settings".
5955         * maint-test-settings.c (maintenance_test_settings_list): Delete.
5956         (maintenance_test_settings_set_list): Rename to ...
5957         (maintenance_set_test_settings_list): ... this.
5958         (maintenance_test_settings_show_list): Rename to  ...
5959         (maintenance_show_test_settings_list): ... this.
5960         (maintenance_test_settings_cmd): Delete.
5961         (maintenance_test_settings_set_cmd): ...
5962         (maintenance_set_test_settings_cmd): ... this.
5963         (maintenance_test_settings_show_cmd): ...
5964         (maintenance_show_test_settings_cmd): ... this.
5965         (maintenance_test_settings_show_value_cmd):
5966         (maintenance_show_test_settings_value_cmd): ... this.
5967         (_initialize_maint_test_settings): No longer install the "maint
5968         test-settings" prefix command.  Rename "maint test-settings set"
5969         to "maint set test-settings", and "maint test-settings show" to
5970         "maint show test-settings".  Adjust all subcommands.
5971
5972 2019-07-03  Pedro Alves  <palves@redhat.com>
5973
5974         * maint-test-settings.c: Fix file's intro comment.  Replace all
5975         references to "test-options" with references to "test-settings",
5976         in comments.
5977
5978 2019-07-03  Pedro Alves  <palves@redhat.com>
5979
5980         * maint-test-settings.c (maintenance_test_settings_xxx)
5981         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
5982         New.
5983         (maintenance_test_settings_enums): Use them.
5984         (maintenance_test_settings_enum): Default to
5985         maintenance_test_settings_xxx.
5986         (_initialize_maint_test_settings): Initialize
5987         MAINTENANCE_TEST_SETTINGS_FILENAME.
5988
5989 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
5990
5991         * breakpoint.h (remove_breakpoints_inf): Change return type to
5992         void, move function documentation here.
5993         * breakpoint.c (remove_breakpoints_inf): Change return type to
5994         void, move function documentation to header.
5995
5996 2019-07-02  Pedro Alves  <palves@redhat.com>
5997
5998         * NEWS (Completion improvements): Mention "info threads".
5999         * thread.c (struct info_threads_opts, info_threads_option_defs)
6000         (make_info_threads_options_def_group): New.
6001         (info_threads_command): Use gdb::option::process_options.
6002         (info_threads_command_completer): New.
6003         (_initialize_thread): Use gdb::option::build_help to build the
6004         help text for "info threads".
6005
6006 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
6007
6008         * defs.h (generic_load): Move from here...
6009         * symfile.h (generic_load): ... to here.  Rename name parameter
6010         to args.
6011         * symfile.c (generic_load): Add comment.
6012
6013 2019-07-01  Tom Tromey  <tromey@adacore.com>
6014
6015         * dwarf2read.c
6016         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
6017         declaration of without_params.  Fix formatting.
6018
6019 2019-07-01  Tom Tromey  <tromey@adacore.com>
6020
6021         * ada-exp.y (find_primitive_type): Update.
6022         * ada-lang.h (ada_lookup_symbol): Update.
6023         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
6024         parameter.
6025         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
6026
6027 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
6028
6029         PR breakpoints/24541
6030         * gdbarch.c: Regenerate.
6031         * gdbarch.h: Regenerate.
6032         * gdbarch.sh: Add 'stap_adjust_register'.
6033         * i386-tdep.c: Include '<unordered_set>'.
6034         (i386_stap_adjust_register): New function.
6035         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
6036         * stap-probe.c (stap_parse_register_operand): Call
6037         'gdbarch_stap_adjust_register'.
6038
6039 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
6040
6041         PR python/24742
6042         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
6043         * python/python.c (do_start_initialization): Use 'xmalloc'
6044         instead of 'PyMem_Malloc'.
6045
6046 2019-06-28  Tom Tromey  <tromey@adacore.com>
6047
6048         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
6049         for Ada.
6050
6051 2019-06-27  Tom Tromey  <tromey@adacore.com>
6052
6053         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
6054         objfile_key.
6055         (arm_find_mapping_symbol, arm_record_special_symbol)
6056         (_initialize_arm_tdep): Update.
6057         (arm_objfile_data_free): Remove.
6058
6059 2019-06-27  Tom Tromey  <tromey@adacore.com>
6060
6061         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
6062         to cp_print_static_field.
6063
6064 2019-06-26  Tom Tromey  <tromey@adacore.com>
6065
6066         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
6067         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
6068         declare.
6069
6070 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
6071
6072         * features/aarch64-core.c (create_feature_aarch64_core):
6073         Regenerate.
6074         * features/aarch64-core.xml: Add cpsr flags.
6075
6076 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
6077
6078         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
6079         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
6080
6081 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
6082
6083         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
6084         field.
6085         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
6086         use.
6087         (arm_record_special_symbol): Don't insert new symbol in sorted
6088         position, push it at the end.
6089
6090 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
6091
6092         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
6093         (arm_mapping_symbol_s): Remove.
6094         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
6095         (arm_mapping_symbol_vec): New typedef.
6096         (struct arm_per_objfile): Add constructor.
6097         <section_maps>: Change type to
6098         std::unique_ptr<arm_mapping_symbol_vec[]>.
6099         (arm_compare_mapping_symbols): Remove.
6100         (arm_find_mapping_symbol): Adjust to section_maps type change.
6101         (arm_objfile_data_free): Call delete on arm_per_objfile.
6102         (arm_record_special_symbol): Adjust to section_maps type change.
6103         Allocate arm_per_objfile with new.
6104
6105 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6106
6107         * cli/cli-cmds.c (alias_command): Compare the alias prefix
6108         with the command prefix.
6109
6110 2019-06-25  Tom Tromey  <tom@tromey.com>
6111
6112         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
6113         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
6114
6115 2019-06-25  Tom Tromey  <tom@tromey.com>
6116
6117         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
6118         type.
6119         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
6120         protected.
6121
6122 2019-06-25  Tom Tromey  <tom@tromey.com>
6123
6124         * tui/tui-winsource.c
6125         (tui_source_window_base::set_is_exec_point_at): Add check against
6126         LOA_ADDRESS.
6127
6128 2019-06-25  Tom Tromey  <tom@tromey.com>
6129
6130         * tui/tui-source.c (tui_set_source_content): Don't check before
6131         xfree.
6132         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
6133
6134 2019-06-25  Tom Tromey  <tom@tromey.com>
6135
6136         * tui/tui-winsource.h (tui_update_source_window_as_is)
6137         (tui_alloc_source_buffer, tui_line_is_displayed)
6138         (tui_addr_is_displayed): Change type of win_info.
6139         * tui/tui-winsource.c (tui_update_source_window_as_is)
6140         (tui_clear_source_content, tui_show_source_line)
6141         (tui_show_source_content, tui_source_window_base::refill)
6142         (tui_source_window_base::set_is_exec_point_at)
6143         (tui_source_window_base::set_is_exec_point_at)
6144         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
6145         (tui_alloc_source_buffer, tui_line_is_displayed)
6146         (tui_addr_is_displayed): Change type of win_info.  Update.
6147         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
6148         (tui_source_window_base::do_make_visible_with_new_height):
6149         Update.
6150         * tui/tui-source.c (tui_set_source_content)
6151         (tui_set_source_content_nil)
6152         (tui_source_window::do_scroll_vertical): Update.
6153         * tui/tui-layout.c (show_layout): Update.
6154         * tui/tui-disasm.c (tui_set_disassem_content)
6155         (tui_disasm_window::do_scroll_vertical): Update.
6156         * tui/tui-data.h (tui_win_content): Remove.
6157         (struct tui_gen_win_info) <content, content_size>: Remove.
6158         (struct tui_source_element): Add initializers and destructor.
6159         (union tui_which_element, struct tui_win_element): Remove.
6160         (struct tui_source_window_base) <content>: New field.
6161         (struct tui_data_window): Remove destructor.
6162         (tui_alloc_content, tui_free_win_content)
6163         (tui_free_all_source_wins_content): Don't declare.
6164         * tui/tui-data.c (tui_initialize_static_data): Update.
6165         (init_content_element, tui_alloc_content): Remove.
6166         (~tui_gen_win_info): Update.
6167         (~tui_data_window, tui_free_all_source_wins_content)
6168         (tui_free_win_content, free_content, free_content_elements):
6169         Remove.
6170
6171 2019-06-25  Tom Tromey  <tom@tromey.com>
6172
6173         * tui/tui-winsource.h (tui_clear_source_content)
6174         (tui_erase_source_content, tui_show_source_content): Change type
6175         of win_info.
6176         * tui/tui-winsource.c (tui_clear_source_content)
6177         (tui_erase_source_content, tui_show_source_content): Change type
6178         of win_info.
6179         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
6180         * tui/tui-source.h (tui_set_source_content_nil): Change type of
6181         win_info.
6182         * tui/tui-source.c (tui_set_source_content_nil): Change type of
6183         win_info.
6184         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
6185
6186 2019-06-25  Tom Tromey  <tom@tromey.com>
6187
6188         * tui/tui-winsource.c (tui_clear_source_content)
6189         (tui_source_window_base::set_is_exec_point_at): Update.
6190         * tui/tui-source.c (tui_set_source_content_nil): Update.
6191         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
6192         a bool.
6193         * tui/tui-data.c (init_content_element): Update.
6194
6195 2019-06-25  Tom Tromey  <tom@tromey.com>
6196
6197         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
6198         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
6199         * tui/tui-layout.c (init_and_make_win): Update.
6200         * tui/tui.h (enum tui_win_type): Update.
6201         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
6202         tui_win_is_auxillary.
6203         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
6204         tui_win_is_auxillary.
6205
6206 2019-06-25  Tom Tromey  <tom@tromey.com>
6207
6208         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
6209         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
6210         (tui_delete_data_content_windows, tui_display_all_data)
6211         (tui_data_window::do_scroll_vertical, tui_display_data_from):
6212         Update.
6213         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
6214         * tui/tui-regs.c (tui_last_regs_line_no)
6215         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
6216         (tui_show_registers): Update.
6217         (tui_show_register_group): Return void.  Update.
6218         (tui_display_registers_from, tui_display_reg_element_at_line)
6219         (tui_display_registers_from_line, tui_check_register_values):
6220         Update.
6221         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
6222         member.
6223         (struct tui_data_window) <regs_content>: Now a std::vector.
6224         <regs_content_count>: Remove.
6225         (tui_add_content_elements, tui_free_data_content): Don't declare.
6226         * tui/tui-data.c (tui_data_window::clear_detail): Update.
6227         (init_content_element): Remove DATA_WIN case.  Add assert.
6228         (tui_add_content_elements): Remove.
6229         (tui_data_window): Update.
6230         (tui_free_data_content): Remove.
6231         (free_content_elements): Remove DATA_WIN case.
6232
6233 2019-06-25  Tom Tromey  <tom@tromey.com>
6234
6235         * tui/tui-data.c (tui_data_item_window): Update.
6236         * tui/tui-windata.h (tui_check_data_values): Don't declare.
6237         * tui/tui-windata.c (tui_display_all_data)
6238         (tui_display_data_from_line): Update.
6239         (tui_check_data_values): Remove.
6240         * tui/tui-regs.c (tui_show_register_group)
6241         (tui_display_reg_element_at_line): Update.
6242         * tui/tui-hooks.c (tui_register_changed)
6243         (tui_refresh_frame_and_register_information): Call
6244         tui_check_register_values.
6245         * tui/tui-data.h (struct tui_data_window) <data_content,
6246         data_content_count, data_type>: Remove.
6247         (enum tui_data_type): Remove.
6248
6249         * tui/tui-data.c (tui_data_window::clear_detail)
6250         (~tui_data_window): Update.
6251
6252 2019-06-25  Tom Tromey  <tom@tromey.com>
6253
6254         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
6255         declare.
6256         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
6257         Rename from tui_first_data_item_displayed.  Update.
6258         (tui_data_window::refresh_all)
6259         (tui_data_window::do_scroll_vertical): Update.
6260         * tui/tui-data.h (struct tui_data_window)
6261         <first_data_item_displayed>: Declare new method.
6262
6263 2019-06-25  Tom Tromey  <tom@tromey.com>
6264
6265         * tui/tui-data.h (tui_init_generic_part): Don't declare.
6266         * tui/tui-data.c (tui_init_generic_part): Remove, moving
6267         contents...
6268         (tui_initialize_static_data): ...here.
6269
6270 2019-06-25  Tom Tromey  <tom@tromey.com>
6271
6272         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
6273         (tui_display_registers_from, tui_check_register_values): Update.
6274         (tui_display_register): Remove win_info parameter; update.
6275         (tui_get_register): Change type of parameters.
6276         * tui/tui-data.h (struct tui_data_element): Remove.
6277         (union tui_which_element) <data>: Remove.
6278         <data_window>: Change type.
6279         (struct tui_data_item_window): New.
6280         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
6281         case.  Add assert.
6282         (~tui_data_item_window): New destructor.
6283         (free_content_elements): Remove DATA_ITEM_WIN case.
6284
6285 2019-06-25  Tom Tromey  <tom@tromey.com>
6286
6287         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
6288         Remove.
6289
6290 2019-06-25  Tom Tromey  <tom@tromey.com>
6291
6292         * tui/tui-data.h (struct tui_command_element): Remove.
6293         (union tui_which_element) <command>: Remove.
6294         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
6295         assert.
6296         (free_content_elements): Remove CMD_WIN case.
6297
6298 2019-06-25  Tom Tromey  <tom@tromey.com>
6299
6300         * tui/tui-layout.c (tui_set_layout): Update.
6301         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
6302         * tui/tui-data.c (layout_def): Update.
6303
6304 2019-06-25  Tom Tromey  <tom@tromey.com>
6305
6306         * tui/tui-wingeneral.c (tui_refresh_all): Update.
6307         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
6308         (tui_source_window_base::set_new_height): Update.
6309         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
6310         Update.
6311         (tui_set_locator_fullname, tui_set_locator_info)
6312         (tui_show_frame_info): Update.
6313         * tui/tui-source.c (tui_set_source_content)
6314         (tui_source_is_displayed): Update.
6315         * tui/tui-layout.c (show_source_disasm_command, show_data)
6316         (show_source_or_disasm_and_command): Update.
6317         * tui/tui-disasm.c (tui_set_disassem_content)
6318         (tui_get_begin_asm_address): Update.
6319         * tui/tui-data.h (struct tui_locator_element): Remove.
6320         (union tui_which_element) <locator>: Remove.
6321         (struct tui_locator_window): New.
6322         (tui_locator_win_info_ptr): Change return type.
6323         * tui/tui-data.c (_locator): Change type.
6324         (tui_locator_win_info_ptr): Change return type.
6325         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
6326         (tui_alloc_content): Add assert.
6327
6328 2019-06-25  Tom Tromey  <tom@tromey.com>
6329
6330         * tui/tui-winsource.c
6331         (tui_exec_info_window::maybe_allocate_content): New method.
6332         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
6333         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
6334         (make_source_or_disasm_window): Add cast.
6335         * tui/tui-data.h (union tui_which_element) <simple_string>:
6336         Remove.
6337         (struct tui_source_info): New.
6338         (struct tui_source_window_base) <execution_info>: Change type.
6339         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
6340         case, and add assert.
6341         (tui_alloc_content): Add assert.
6342
6343 2019-06-25  Tom Tromey  <tom@tromey.com>
6344
6345         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
6346         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
6347         * tui/tui-data.c (tui_alloc_win_info): Remove.
6348
6349 2019-06-25  Tom Tromey  <tom@tromey.com>
6350
6351         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
6352         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
6353         can_highlight.
6354
6355 2019-06-25  Tom Tromey  <tom@tromey.com>
6356
6357         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
6358         make_visible_with_new_height method.
6359         (tui_win_info::make_visible_with_new_height): New method.
6360         (tui_source_window_base::do_make_visible_with_new_height)
6361         (tui_data_window::do_make_visible_with_new_height)
6362         (tui_cmd_window::do_make_visible_with_new_height): New methods.
6363         (make_visible_with_new_height): Remove.
6364         (tui_resize_all, tui_adjust_win_heights): Use
6365         make_visible_with_new_height method.
6366         * tui/tui-data.h (struct tui_win_info)
6367         <do_make_visible_with_new_height, make_visible_with_new_height>:
6368         New methods.
6369         (struct tui_source_window_base, struct tui_data_window)
6370         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
6371         methods.
6372
6373 2019-06-25  Tom Tromey  <tom@tromey.com>
6374
6375         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
6376         method.
6377         (update_tab_width): Call update_tab_width method.
6378         * tui/tui-data.h (struct tui_win_info)
6379         (struct tui_source_window_base) <update_tab_width>: New methods.
6380
6381 2019-06-25  Tom Tromey  <tom@tromey.com>
6382
6383         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
6384         parameter.
6385         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
6386         parameter.
6387         (tui_gen_win_info::make_visible): Update.
6388         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
6389         parameter.
6390         * tui/tui-data.h (enum tui_box): New enum.
6391         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
6392
6393 2019-06-25  Tom Tromey  <tom@tromey.com>
6394
6395         * tui/tui-layout.c (make_source_or_disasm_window): Always use
6396         init_and_make_win for EXEC_INFO_WIN.
6397         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
6398         longer inline.
6399         (struct tui_win_info) <~tui_win_info>: Inline.
6400         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
6401         Don't declare.
6402         * tui/tui-data.c (source_win, disasm_win): Remove globals.
6403         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
6404         Remove.
6405         (tui_initialize_static_data): Update.
6406         (~tui_gen_win_info): Handle more cleanup here.
6407         (~tui_source_window_base): Delete "execution_info".
6408         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
6409
6410 2019-06-25  Tom Tromey  <tom@tromey.com>
6411
6412         * tui/tui-layout.c (make_command_window): Don't set
6413         can_highlight.
6414         (show_source_disasm_command): Call the reset method.
6415         (show_data): Don't set can_highlight.  Call the reset method.
6416         (tui_gen_win_info::reset): Rename from init_gen_win_info
6417         (init_and_make_win): Simplify.  Return tui_gen_win_info.
6418         (show_source_or_disasm_and_command): Call the reset method.
6419         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
6420         (struct tui_cmd_window): Set can_highlight.
6421
6422 2019-06-25  Tom Tromey  <tom@tromey.com>
6423
6424         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
6425         from make_visible.
6426         (tui_make_visible, tui_make_invisible): Rewrite.
6427         (tui_win_info::make_visible): Remove.
6428         (tui_source_window_base::make_visible): Update.
6429         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
6430         method.  Moved from...
6431         (struct tui_win_info) <make_visible>: ...here.
6432
6433 2019-06-25  Tom Tromey  <tom@tromey.com>
6434
6435         * tui/tui-winsource.c
6436         (tui_source_window_base::do_scroll_horizontal): Remove direction
6437         parameter.
6438         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
6439         direction parameter.
6440         * tui/tui-win.c (tui_win_info::forward_scroll)
6441         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
6442         (tui_win_info::right_scroll): Update.
6443         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
6444         direction parameter.
6445         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
6446         direction parameter.
6447         * tui/tui-data.h (enum tui_scroll_direction): Remove.
6448         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
6449         Remove direction parameter.
6450         (struct tui_source_window_base, struct tui_source_window)
6451         (struct tui_disasm_window, struct tui_data_window)
6452         (struct tui_cmd_window): Update.
6453
6454 2019-06-25  Tom Tromey  <tom@tromey.com>
6455
6456         * tui/tui-winsource.h (tui_set_exec_info_content)
6457         (tui_show_exec_info_content, tui_erase_exec_info_content)
6458         (tui_clear_exec_info_content, tui_update_exec_info): Change
6459         argument to tui_source_window_base.
6460         * tui/tui-winsource.c (tui_set_exec_info_content)
6461         (tui_show_exec_info_content, tui_erase_exec_info_content)
6462         (tui_clear_exec_info_content, tui_update_exec_info): Change
6463         argument to tui_source_window_base.
6464
6465 2019-06-25  Tom Tromey  <tom@tromey.com>
6466
6467         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
6468         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
6469
6470 2019-06-25  Tom Tromey  <tom@tromey.com>
6471
6472         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
6473         check.
6474
6475 2019-06-25  Tom Tromey  <tom@tromey.com>
6476
6477         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
6478         type to void.
6479         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
6480         type to void.
6481         * tui/tui-source.c (tui_set_source_content): Update.
6482         * tui/tui-disasm.c (tui_set_disassem_content): Update.
6483
6484 2019-06-25  Tom Tromey  <tom@tromey.com>
6485
6486         * tui/tui-win.c (window_name_completer, tui_set_focus)
6487         (tui_all_windows_info): Use name method.
6488         * tui/tui-data.h (struct tui_gen_win_info)
6489         (struct tui_source_window, struct tui_disasm_window)
6490         (struct tui_data_window, struct tui_cmd_window) <name>: New
6491         method.
6492         (tui_win_name): Don't declare.
6493         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
6494         (tui_win_name): Remove.
6495
6496 2019-06-25  Tom Tromey  <tom@tromey.com>
6497
6498         * tui/tui-winsource.h (tui_update_source_window)
6499         (tui_update_source_window_as_is): Change parameter type.
6500         * tui/tui-winsource.c (tui_update_source_window): Change win_info
6501         to be a tui_source_window_base.
6502         (tui_update_source_window_as_is): Likewise.
6503         * tui/tui-win.c (make_visible_with_new_height): Update.
6504
6505 2019-06-25  Tom Tromey  <tom@tromey.com>
6506
6507         * tui/tui-winsource.c (tui_erase_source_content)
6508         (tui_show_source_content, tui_show_exec_info_content)
6509         (tui_erase_exec_info_content): Use refresh_window method.
6510         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
6511         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
6512         from tui_refresh_win.
6513         (tui_data_window::refresh_window): New method.
6514         (tui_win_info::refresh, tui_source_window_base::refresh)
6515         (tui_refresh_all): Use refresh_window method.
6516         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
6517         method.
6518         * tui/tui-regs.c (tui_display_register): Call refresh_window
6519         method.
6520         * tui/tui-layout.c (show_source_disasm_command)
6521         (show_source_or_disasm_and_command): Call refresh_window method.
6522         * tui/tui-data.h (struct tui_gen_win_info)
6523         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
6524         New method.
6525
6526 2019-06-25  Tom Tromey  <tom@tromey.com>
6527
6528         * tui/tui.c (tui_rl_other_window, tui_enable)
6529         (tui_is_window_visible, tui_get_command_dimension): Update.
6530         * tui/tui-winsource.c (tui_update_source_window_as_is)
6531         (tui_clear_source_content, tui_erase_source_content)
6532         (tui_show_source_line, tui_source_window_base::refill)
6533         (tui_source_window_base::do_scroll_horizontal)
6534         (tui_source_window_base::set_is_exec_point_at)
6535         (tui_update_breakpoint_info, tui_set_exec_info_content)
6536         (tui_alloc_source_buffer, tui_line_is_displayed)
6537         (tui_addr_is_displayed): Update.
6538         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
6539         (tui_check_and_display_highlight_if_needed)
6540         (tui_win_info::make_visible, tui_win_info::refresh)
6541         (tui_refresh_all): Update.
6542         * tui/tui-windata.c (tui_first_data_item_displayed)
6543         (tui_delete_data_content_windows, tui_erase_data_content)
6544         (tui_display_all_data, tui_data_window::refresh_all)
6545         (tui_check_data_values): Update.
6546         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
6547         (tui_set_win_focus_to, tui_win_info::forward_scroll)
6548         (tui_win_info::backward_scroll, tui_refresh_all_win)
6549         (tui_resize_all, tui_set_focus, tui_all_windows_info)
6550         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
6551         (tui_source_window_base::set_new_height)
6552         (tui_data_window::set_new_height)
6553         (make_invisible_and_set_new_height)
6554         (make_visible_with_new_height, new_height_ok)
6555         (parse_scrolling_args): Update.
6556         * tui/tui-stack.c (tui_show_frame_info): Update.
6557         * tui/tui-source.c (tui_set_source_content)
6558         (tui_set_source_content_nil, tui_source_is_displayed)
6559         (tui_source_window::do_scroll_vertical): Update.
6560         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
6561         (tui_display_registers_from, tui_display_reg_element_at_line)
6562         (tui_check_register_values, tui_reg_command): Update.
6563         * tui/tui-layout.c (tui_default_win_height)
6564         (show_source_disasm_command, show_data, init_and_make_win)
6565         (show_source_or_disasm_and_command): Update.
6566         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
6567         (tui_redisplay_readline, tui_mld_flush)
6568         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
6569         (tui_getc): Update.
6570         * tui/tui-disasm.c (tui_set_disassem_content)
6571         (tui_disasm_window::do_scroll_vertical): Update.
6572         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
6573         Now virtual.
6574         (struct tui_win_info): Derive from tui_gen_win_info.
6575         <~tui_win_info>: Mark as override.
6576         <generic>: Remove member.
6577         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
6578         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
6579         (~tui_data_window, ~tui_win_info)
6580         (tui_free_all_source_wins_content): Update.
6581         * tui/tui-command.c (tui_refresh_cmd_win): Update.
6582
6583 2019-06-25  Tom Tromey  <tom@tromey.com>
6584
6585         * tui/tui-layout.c (init_and_make_win): Use new.
6586         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
6587         destructor, initializers.
6588         (tui_alloc_generic_win_info): Don't declare.
6589         * tui/tui-data.c (_locator): Add argument to constructor.
6590         (source_win, disasm_win): New globals.
6591         (exec_info): Remove.
6592         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
6593         Update.
6594         (tui_alloc_generic_win_info): Remove.
6595         (init_content_element): Use new.
6596         (tui_win_info::tui_win_info): Update.
6597         (free_content_elements) <case DATA_WIN>: Use delete.
6598
6599 2019-06-25  Tom Tromey  <tom@tromey.com>
6600
6601         * tui/tui-wingeneral.c (tui_refresh_win): Update.
6602         * tui/tui-windata.c (tui_first_data_item_displayed)
6603         (tui_delete_data_content_windows): Update.
6604         * tui/tui-win.c (tui_data_window::set_new_height): Update.
6605         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
6606         (tui_display_registers_from, tui_check_register_values): Update.
6607         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
6608         pointer.
6609         * tui/tui-data.c (init_content_element): Update.  Allocate the new
6610         window.
6611         (tui_free_data_content): Update.
6612         (free_content_elements) <case DATA_WIN>: Free the window.
6613
6614 2019-06-25  Tom Tromey  <tom@tromey.com>
6615
6616         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
6617         Update.
6618         * tui/tui-layout.c (make_command_window)
6619         (show_source_disasm_command, show_data, init_and_make_win)
6620         (show_source_or_disasm_and_command): Update.
6621         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
6622         method.
6623         <can_highight, is_highlighted>: Now bool.
6624         (tui_set_win_highlight): Don't declare.
6625         * tui/tui-data.c (tui_set_win_highlight): Remove.
6626
6627 2019-06-25  Tom Tromey  <tom@tromey.com>
6628
6629         * tui/tui-wingeneral.c (make_visible): Remove check of window
6630         type.
6631
6632 2019-06-25  Tom Tromey  <tom@tromey.com>
6633
6634         * tui/tui-win.c (tui_win_info::max_height)
6635         (tui_cmd_window::max_height): New methods.
6636         (new_height_ok): Call max_height.
6637         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
6638         <max_height>: New method.
6639
6640 2019-06-25  Tom Tromey  <tom@tromey.com>
6641
6642         * tui/tui-win.c (tui_source_window_base::set_new_height)
6643         (tui_data_window::set_new_height): New methods.
6644         (make_invisible_and_set_new_height): Call set_new_height method.
6645         * tui/tui-data.h (struct tui_win_info)
6646         (struct tui_source_window_base, struct tui_data_window)
6647         <set_new_height>: New method.
6648
6649 2019-06-25  Tom Tromey  <tom@tromey.com>
6650
6651         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
6652         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
6653         tui_refresh_data_win.
6654         * tui/tui-win.c (tui_source_window_base::refresh_all): New
6655         method.
6656         (tui_refresh_all_win): Call the refresh_all method.
6657         (tui_set_focus): Likewise.
6658         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
6659         (struct tui_source_window_base, struct tui_data_window) <refresh>:
6660         Likewise.
6661
6662 2019-06-25  Tom Tromey  <tom@tromey.com>
6663
6664         * tui/tui-winsource.h (tui_refill_source_window)
6665         (tui_set_is_exec_point_at): Don't declare.
6666         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
6667         (tui_source_window_base::refill): Rename from
6668         tui_refill_source_window.
6669         (tui_source_window_base::do_scroll_horizontal): Update.
6670         (tui_source_window_base::set_is_exec_point_at): Rename from
6671         tui_set_is_exec_point_at.
6672         (tui_update_all_breakpoint_info): Update.
6673         * tui/tui-stack.c (tui_show_frame_info): Update.
6674         * tui/tui-layout.c (show_data): Add cast.
6675         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
6676         * tui/tui-data.h (struct tui_source_window_base) <refill,
6677         set_is_exec_point_at>: New methods.
6678         (tui_source_windows, tui_add_to_source_windows): Update types.
6679         (tui_add_to_source_windows): Remove redundant declaration.
6680         * tui/tui-data.c (source_windows): Store tui_source_window_base.
6681         (tui_source_windows): Change return type.
6682         (tui_clear_source_windows_detail): Update.
6683         (tui_add_to_source_windows): Change type of parameter.
6684         (tui_free_all_source_wins_content): Update.
6685
6686 2019-06-25  Tom Tromey  <tom@tromey.com>
6687
6688         * tui/tui-wingeneral.c (tui_win_info::refresh)
6689         (tui_source_window_base::refresh): New methods.
6690         (tui_refresh_all): Call the refresh method.
6691         * tui/tui-data.h (struct tui_win_info)
6692         (struct tui_source_window_base) <refresh>: New method.
6693
6694 2019-06-25  Tom Tromey  <tom@tromey.com>
6695
6696         * tui/tui.h (tui_is_window_visible): Return bool.
6697         * tui/tui.c (tui_is_window_visible): Return bool.
6698         * tui/tui-wingeneral.c (tui_make_window, make_visible)
6699         (tui_make_visible, tui_make_invisible)
6700         (tui_win_info::make_visible)
6701         (tui_source_window_base::make_visible, make_all_visible)
6702         (tui_make_all_visible, tui_make_all_invisible): Update.
6703         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
6704         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
6705         bool.
6706         (struct tui_win_info, struct tui_source_window_base)
6707         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
6708         * tui/tui-data.c (tui_init_generic_part): Update.
6709
6710 2019-06-25  Tom Tromey  <tom@tromey.com>
6711
6712         * tui/tui-wingeneral.c (tui_win_info::make_visible)
6713         (tui_source_window_base::make_visible): New methods.
6714         (make_all_visible): Make method call.
6715         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
6716         (struct tui_source_window_base, struct tui_cmd_window): Override
6717         make_visible.
6718         (tui_win_is_source_type): Don't declare.
6719         * tui/tui-data.c (tui_win_is_source_type): Remove.
6720
6721 2019-06-25  Tom Tromey  <tom@tromey.com>
6722
6723         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
6724         NULL check.
6725
6726 2019-06-25  Tom Tromey  <tom@tromey.com>
6727
6728         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
6729         Inline constructor.  Add initializers for members.
6730         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
6731         constructors; now inline in class.
6732
6733 2019-06-25  Tom Tromey  <tom@tromey.com>
6734
6735         * tui/tui-regs.c (tui_show_registers): Update.
6736         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
6737         bool.
6738         * tui/tui-data.c (tui_data_window::clear_detail)
6739         (tui_data_window): Update.
6740
6741 2019-06-25  Tom Tromey  <tom@tromey.com>
6742
6743         * tui/tui-windata.c (tui_display_all_data)
6744         (tui_display_data_from_line, tui_display_data_from)
6745         (tui_check_data_values, tui_data_window::do_scroll_vertical):
6746         Update.
6747         * tui/tui-regs.c (tui_last_regs_line_no)
6748         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
6749         (tui_show_registers, tui_show_register_group)
6750         (tui_display_registers_from, tui_display_reg_element_at_line)
6751         (tui_display_registers_from_line, tui_check_register_values)
6752         (tui_reg_next, tui_reg_prev): Update.
6753         * tui/tui-layout.c (tui_set_layout, show_data): Update.
6754         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
6755         tui_data_window.
6756         (struct tui_win_info) <detail>: Remove.  Add new fields from
6757         tui_data_info.
6758         (TUI_DATA_WIN): Add cast.
6759         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
6760         (~tui_data_window): Simplify.
6761
6762 2019-06-25  Tom Tromey  <tom@tromey.com>
6763
6764         * tui/tui-layout.c (show_source_disasm_command)
6765         (show_source_or_disasm_and_command): Update.
6766         * tui/tui-io.c (update_cmdwin_start_line)
6767         (tui_redisplay_readline): Update.
6768         * tui/tui-data.h (struct tui_command_info): Remove.
6769         (struct tui_win_info) <detail>: Remove command_info member.
6770         (struct tui_data_window) <start_line>: New member, from
6771         tui_command_info.
6772         (TUI_CMD_WIN): Add casts.
6773
6774 2019-06-25  Tom Tromey  <tom@tromey.com>
6775
6776         * tui/tui-winsource.c (tui_update_source_window)
6777         (tui_refill_source_window)
6778         (tui_source_window_base::do_scroll_horizontal)
6779         (tui_update_breakpoint_info, tui_set_exec_info_content)
6780         (tui_show_exec_info_content, tui_erase_exec_info_content)
6781         (tui_clear_exec_info_content): Update.
6782         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
6783         Update.
6784         * tui/tui-win.c (make_invisible_and_set_new_height)
6785         (make_visible_with_new_height): Update.
6786         * tui/tui-source.c (tui_set_source_content)
6787         (tui_show_symtab_source): Update.
6788         * tui/tui-layout.c (extract_display_start_addr)
6789         (show_source_disasm_command, show_data)
6790         (make_source_or_disasm_window)
6791         (show_source_or_disasm_and_command): Update.
6792         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
6793         (tui_disasm_window::do_scroll_vertical): Remove shadowing
6794         "gdbarch".
6795         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
6796         to tui_source_window_base.
6797         (struct tui_win_info) <detail>: Remove source_info member.
6798         (struct tui_source_window_base) <has_locator>: Inline.
6799         Move contents from tui_source_info; rename has_locator member to
6800         m_has_locator.
6801         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
6802         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
6803         header file.
6804         (tui_source_window_base::clear_detail, ~tui_source_window_base):
6805         Simplify.
6806         (tui_free_all_source_wins_content): Cast to
6807         tui_source_window_base.
6808
6809 2019-06-25  Tom Tromey  <tom@tromey.com>
6810
6811         * tui/tui-win.c (make_invisible_and_set_new_height)
6812         (make_visible_with_new_height): Call has_locator method.
6813         * tui/tui-layout.c (show_source_disasm_command, show_data)
6814         (show_source_or_disasm_and_command): Update for bool change.
6815         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
6816         (tui_win_info) <has_locator>: New method.
6817         (struct tui_source_window_base) <has_locator>: New method.
6818         (tui_win_has_locator): Don't declare.
6819         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
6820         from tui_win_has_locator.
6821         (tui_source_window_base): Use false, not FALSE.
6822
6823 2019-06-25  Tom Tromey  <tom@tromey.com>
6824
6825         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
6826         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
6827         clear_detail method directly.
6828         (tui_clear_win_detail): Remove.
6829
6830 2019-06-25  Tom Tromey  <tom@tromey.com>
6831
6832         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
6833         "this", not TUI_DISASM_WIN.
6834
6835 2019-06-25  Tom Tromey  <tom@tromey.com>
6836
6837         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
6838         declare.
6839         * tui/tui-winsource.c
6840         (tui_source_window_base::do_scroll_horizontal): Rename from
6841         tui_horizontal_source_scroll.
6842         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
6843         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
6844         from tui_vertical_data_scroll.
6845         * tui/tui-win.h (tui_scroll): Don't declare.
6846         * tui/tui-win.c (tui_win_info::forward_scroll)
6847         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
6848         (tui_win_info::right_scroll): Rename and update.
6849         (tui_scroll_forward_command, tui_scroll_backward_command)
6850         (tui_scroll_left_command, tui_scroll_right_command): Update.
6851         (tui_scroll): Remove.
6852         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
6853         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
6854         from tui_vertical_source_scroll.
6855         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
6856         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
6857         from tui_vertical_disassem_scroll.
6858         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
6859         do_scroll_horizontal>: New methods.
6860         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
6861         Likewise.
6862         (struct tui_source_window_base): Add do_scroll_horizontal.
6863         (struct tui_source_window, struct tui_disasm_window): Add
6864         do_scroll_vertical.
6865         (struct tui_data_window, struct tui_cmd_window): Add
6866         do_scroll_horizontal and do_scroll_vertical.
6867         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
6868
6869 2019-06-25  Tom Tromey  <tom@tromey.com>
6870
6871         * tui/tui-data.h (struct tui_source_window_base): New struct.
6872         (struct tui_source_window): Derive from tui_source_window_base.
6873         (struct tui_disasm_window): New struct.
6874         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
6875         from tui_source_window::clear_detail.
6876         (tui_source_window_base): Rename from tui_source_window.
6877         (~tui_source_window_base): Rename from ~tui_source_window.
6878         (tui_alloc_win_info): Create a tui_disasm_window.
6879
6880 2019-06-25  Tom Tromey  <tom@tromey.com>
6881
6882         * tui/tui-data.h (struct tui_source_window)
6883         (struct tui_data_window): Declare destructors.
6884         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
6885         destructors.
6886         (tui_win_info): Simplify.
6887
6888 2019-06-25  Tom Tromey  <tom@tromey.com>
6889
6890         * tui/tui-winsource.c (tui_display_main)
6891         (tui_update_source_windows_with_addr)
6892         (tui_update_all_breakpoint_info): Update.
6893         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
6894         (new_height_ok, parse_scrolling_args): Update.
6895         * tui/tui-stack.c (tui_show_frame_info): Update.
6896         * tui/tui-data.h (struct tui_list): Remove.
6897         (tui_source_windows): Return a reference to a std::vector.
6898         * tui/tui-data.c (source_windows): Now a std::vector.
6899         (tui_source_windows): Change return type.
6900         (tui_clear_source_windows): Rewrite.
6901         (tui_clear_source_windows_detail, tui_add_to_source_windows)
6902         (tui_free_all_source_wins_content): Rewrite.
6903
6904 2019-06-25  Tom Tromey  <tom@tromey.com>
6905
6906         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
6907         (struct tui_data_window, struct tui_cmd_window): Declare
6908         clear_detail method.
6909         * tui/tui-data.c (tui_source_window::clear_detail)
6910         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
6911         methods.
6912         (tui_clear_win_detail): Simplify.
6913
6914 2019-06-25  Tom Tromey  <tom@tromey.com>
6915
6916         * tui/tui-layout.c (make_source_window, make_disasm_window)
6917         (make_source_or_disasm_window): Remove win_info_ptr parameter.
6918         Return the new window.
6919         (show_source_disasm_command, show_data)
6920         (show_source_or_disasm_and_command): Update.
6921
6922 2019-06-25  Tom Tromey  <tom@tromey.com>
6923
6924         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
6925         parameter.  Return the new window.
6926         (show_source_disasm_command): Update and remove NULL check.
6927         (show_source_or_disasm_and_command): Update.
6928
6929 2019-06-25  Tom Tromey  <tom@tromey.com>
6930
6931         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
6932
6933 2019-06-25  Tom Tromey  <tom@tromey.com>
6934
6935         * tui/tui-data.h (struct tui_win_info): Make constructor
6936         protected.  Make destructor virtual.  Add initializers.
6937         (tui_source_window, tui_data_window, tui_cmd_window): New
6938         classes.
6939         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
6940         constructor.  Add "type" parameter.
6941         (tui_source_window, tui_data_window, tui_cmd_window): New
6942         constructors.
6943         (tui_alloc_win_info): Instantiate the appropriate subclass.
6944
6945 2019-06-25  Tom Tromey  <tom@tromey.com>
6946
6947         * tui/tui-win.c (tui_resize_all): Use delete.
6948         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
6949         destructor.
6950         (tui_free_window): Don't declare.
6951         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
6952         Update.
6953
6954 2019-06-25  Tom Tromey  <tom@tromey.com>
6955
6956         * tui/tui-data.h (struct tui_win_info): Add constructor.
6957         * tui/tui-data.c (tui_alloc_win_info): Use new.
6958         (tui_free_window): Use delete.
6959
6960 2019-06-22  Tom Tromey  <tom@tromey.com>
6961
6962         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
6963         declare.
6964         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
6965
6966 2019-06-22  Tom Tromey  <tom@tromey.com>
6967
6968         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
6969         declare.
6970         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
6971
6972 2019-06-22  Tom de Vries  <tdevries@suse.de>
6973
6974         * dwarf2read.c (create_addrmap_from_aranges)
6975         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
6976         instead of '%zu'.
6977
6978 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
6979
6980         * dwarf2read.h (dwarf2_section_info_def): Remove.
6981         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
6982         * dwarf2read.c (struct dwo_sections) <types>: Change type to
6983         std::vector<dwarf2_section_info>.
6984         (struct dwo_file) <~dwo_file>: Remove.
6985         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
6986         types field.
6987         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
6988         (dwarf2_read_debug_names): Likewise.
6989         (create_debug_types_hash_table): Change parameter type to
6990         array_view, adjust code accordingly.
6991         (dwarf2_locate_dwo_sections): Adjust to std::vector.
6992         (partial_die_info::fixup): Likewise.
6993         (determine_prefix): Likewise.
6994         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
6995
6996 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
6997
6998         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
6999         gdb_bfd_ref_ptr.
7000         <~dwo_file>: Remove call to gdb_bfd_unref.
7001         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
7002         gdb_bfd_ref_ptr::get.
7003
7004 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
7005
7006         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
7007         type to htab_up.
7008         * dwarf2read.c (struct dwo_file): Initialize fields.
7009         <~dwo_file>: New.
7010         (free_dwo_file): Remove, move content to ~dwo_file.
7011         (struct dwo_file_deleter): Remove.
7012         (dwo_file_up>: Remove custom deleter.
7013         (free_dwo_files): Remove.
7014         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
7015         dwo_files.
7016         (process_skeletonless_type_units): Call unique_ptr::get.
7017         (allocate_dwo_file_hash_table): Add deleter to created hash
7018         table.  Change return type to htab_up.
7019         (lookup_dwo_file_slot): Don't memset dwo_file, call
7020         unique_ptr::get.
7021         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
7022         (create_dwo_unit_in_dwp_v2): Likewise.
7023         (open_and_init_dwo_file): Likewise.
7024         (free_dwo_file_from_slot): Remove.
7025
7026 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
7027
7028         * dwarf2read.h (struct dwarf2_section_info) <readin,
7029         is_virtual>: Change type to bool.
7030         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
7031         true instead of 1.
7032
7033 2019-06-19  Tom Tromey  <tom@tromey.com>
7034
7035         * tui/tui-data.h (tui_init_content_element): Don't declare.
7036
7037 2019-06-19  Tom Tromey  <tom@tromey.com>
7038
7039         * tui/tui-data.h (tui_init_win_info): Don't declare.
7040
7041 2019-06-19  Tom de Vries  <tdevries@suse.de>
7042
7043         * dwarf2read.h (abstract_to_concrete): Change type to
7044         std::unordered_map<sect_offset, std::vector<sect_offset>,
7045         gdb::hash_enum<sect_offset>>.
7046
7047 2019-06-19  Tom Tromey  <tromey@adacore.com>
7048
7049         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
7050         EVAL_AVOID_SIDE_EFFECTS specially.
7051
7052 2019-06-19  Tom Tromey  <tromey@adacore.com>
7053
7054         * source-cache.c (highlighter): New global.
7055         (source_cache::get_source_lines): Create a highlighter on demand.
7056
7057 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
7058
7059         * defs.h (deprecated_interactive_hook): Delete declaration.
7060         * interps.c (clear_interpreter_hooks): Remove use of
7061         deprecated_interactive_hook.
7062         * top.c (deprecated_interactive_hook): Delete definition.
7063         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
7064
7065 2019-06-18  Tom de Vries  <tdevries@suse.de>
7066
7067         PR gdb/24515
7068         * dwarf2read.h (abstract_to_concrete): Change type from
7069         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
7070         std::unordered_map<sect_offset, std::vector<sect_offset>>.
7071         * dwarf2read.c (read_variable): Update.
7072         (dwarf2_fetch_die_loc_sect_off): Update.
7073
7074 2019-06-17  Tom de Vries  <tdevries@suse.de>
7075
7076         PR gdb/24617
7077         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
7078         accessing parent[parent_len - 1].
7079
7080 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
7081
7082         PR gdb/24364
7083         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
7084         call dtrace_process_dof with NULL dof.
7085
7086 2019-06-16  Tom de Vries  <tdevries@suse.de>
7087
7088         PR gdb/24445
7089         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
7090
7091 2019-06-16  Tom Tromey  <tom@tromey.com>
7092
7093         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
7094         (make_all_visible): Use address of member.
7095
7096 2019-06-16  Tom Tromey  <tom@tromey.com>
7097
7098         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
7099         (tui_free_window, free_content, free_content_elements): Remove
7100         unnecessary cast.
7101         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
7102         cast.
7103         * tui/tui-regs.c (tui_show_register_group)
7104         (tui_display_registers_from, tui_display_reg_element_at_line):
7105         Remove unnecessary cast.
7106
7107 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
7108
7109         * linux-nat.c (normal_mask): Delete.
7110         (_initialize_linux_nat): Don't initialise normal_mask.
7111
7112 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
7113
7114         PR gdb/24445
7115         * dwarf-index-write.h (write_psymtabs_to_index): Add
7116         dwz_basename parameter.
7117         * dwarf-index-write.c (write_gdbindex): Move file writing to
7118         write_gdbindex_1.  Change return type void.
7119         (assert_file_size): Move up, remove filename parameter.
7120         (write_gdbindex_1): New function.
7121         (write_debug_names): Change return type to void, call
7122         assert_file_size.
7123         (struct index_wip_file): New struct.
7124         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
7125         file logic to index_wip_file.  Write index for dwz file if
7126         needed.
7127         (save_gdb_index_command): Pass basename of dwz file, if present.
7128         * dwarf-index-cache.c (index_cache::store): Obtain and pass
7129         build-id of dwz file, if present.
7130         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
7131         (dwarf2_get_dwz_file): Likewise.
7132         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
7133         (dwarf2_get_dwz_file): Likewise.
7134
7135 2019-06-16  Tom Tromey  <tom@tromey.com>
7136
7137         * coffread.c (process_coff_symbol): Use xstrdup.
7138         * value.c (create_internalvar): Use xstrdup.
7139
7140 2019-06-16  Tom Tromey  <tom@tromey.com>
7141
7142         * valops.c (value_cast, value_slice): Remove unnecessary cast.
7143         * breakpoint.c (stopin_command, stopat_command)
7144         (until_break_command, decode_location_default): Remove unnecessary
7145         cast.
7146         * utils.c (subset_compare): Remove unnecessary cast.
7147         * ada-lang.c (ada_update_initial_language): Remove unnecessary
7148         cast.
7149         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
7150         cast.
7151         * infcmd.c (path_command): Remove unnecessary cast.
7152         * coffread.c (decode_type): Remove unnecessary cast.
7153         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
7154         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
7155         * tui/tui-stack.c (tui_show_locator_content)
7156         (tui_show_frame_info): Remove unnecessary cast.
7157         * tui/tui-win.c (tui_scroll_forward_command)
7158         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
7159         (parse_scrolling_args): Remove unnecessary cast.
7160         * tui/tui-data.c (init_win_info, tui_del_window)
7161         (tui_free_window, tui_del_data_windows, tui_free_data_content)
7162         (free_content_elements): Remove unnecessary cast.
7163         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
7164         unnecessary cast.
7165         * tui/tui-source.c (tui_set_source_content)
7166         (tui_vertical_source_scroll): Remove unnecessary cast.
7167         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
7168         cast.
7169         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
7170         * tui/tui-regs.c (tui_display_registers_from)
7171         (tui_display_register): Remove unnecessary cast.
7172         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
7173         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
7174         (make_visible): Remove unnecessary cast.
7175         * tui/tui-winsource.c (tui_erase_source_content)
7176         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
7177         unnecessary cast.
7178         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
7179         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
7180         * stabsread.c (read_type, read_array_type, read_range_type):
7181         Remove unnecessary cast.
7182         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
7183         (parse_symbol, parse_type, upgrade_type, parse_external)
7184         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
7185         unnecessary cast.
7186         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
7187
7188 2019-06-16  Tom Tromey  <tom@tromey.com>
7189
7190         * tui/tui-data.c (tui_alloc_generic_win_info)
7191         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
7192         checks.
7193
7194 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
7195             Andrew Burgess  <andrew.burgess@embecosm.com>
7196
7197         * f-typeprint.c (f_print_type): Don't return early for not
7198         associated or not allocated types.
7199         (f_type_print_varspec_suffix): Add print_rank parameter and print
7200         ranks of array types in case they dangling.
7201         (f_type_print_base): Add print_rank parameter.
7202
7203 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
7204
7205         * NEWS: Mention new MI commands.
7206         * break-catch-throw.c (enum exception_event_kind): Move to
7207         breakpoint.h.
7208         (print_mention_exception_catchpoint): Output text as a single
7209         message.
7210         (catch_exception_command_1): Rename to...
7211         (catch_exception_event): ...this, make non-static, update header
7212         command, and change some parameter types.
7213         (catch_catch_command): Update for changes to
7214         catch_exception_command_1.
7215         (catch_throw_command): Likewise.
7216         (catch_rethrow_command): Likewise.
7217         * breakpoint.c (enum exception_event_kind): Delete.
7218         * breakpoint.h (enum exception_event_kind): Moved here from
7219         break-catch-throw.c.
7220         (catch_exception_event): Declare.
7221         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
7222         (mi_cmd_catch_throw): New function.
7223         (mi_cmd_catch_rethrow): New function.
7224         (mi_cmd_catch_catch): New function.
7225         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
7226         'catch-catch' entries.
7227         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
7228         (mi_cmd_catch_rethrow): Declare.
7229         (mi_cmd_catch_catch): Declare.
7230
7231 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
7232
7233         * annotate.c (annotate_source_line): Change return type to void,
7234         update implementation to match.
7235         * annotate.h (annotate_source_line): Change return type to void,
7236         update header comment.
7237         * stack.c (print_frame_info): Don't change what frame information
7238         is printed based on whether annotations are on or not.
7239
7240 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
7241
7242         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
7243         (annotate_source): Make static.
7244         (annotate_source_line): Moved from source.c and renamed from
7245         identify_source_line.  Update the return type.
7246         * annotate.h (annotate_source): Delete declaration.
7247         (annotate_source_line): Declaration moved from source.h, and
7248         renamed from identify_source_line.  Return type updated.
7249         * source.c (identify_source_line): Moved to annotate.c and renamed
7250         to annotate_source_line.
7251         (info_line_command): Remove check of annotation_level.
7252         * source.h (identify_source_line): Move declaration to annotate.h
7253         and rename to annotate_source_line.
7254         * stack.c: Add 'annotate.h' include.
7255         (print_frame_info): Remove check of annotation_level before
7256         calling annotate_source_line.
7257
7258 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
7259
7260         * source-cache.c (source_cache::get_plain_source_lines): Use
7261         open_source_file_with_line_charpos instead of just
7262         open_source_file, remove call to find_source_lines.
7263         (source_cache::get_source_lines): Likewise.
7264         * source.c (find_source_lines): Make static.
7265         (get_filename_and_charpos): Renamed into...
7266         (open_source_file_with_line_charpos): ..this along with changes to
7267         return a scoped_fd, and some other minor clean ups.
7268         (identify_source_line): Use open_source_file_with_line_charpos.
7269         (search_command_helper): Use open_source_file_with_line_charpos
7270         instead of just open_source_file, remove call to
7271         find_source_lines.
7272         * source.h (open_source_file_with_line_charpos): Declare new
7273         function.
7274         (find_source_lines): Delete declaration.
7275
7276 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
7277
7278         * source.c (get_filename_and_charpos): Remove fullname
7279         parameter.
7280         (identify_source_line): Update call to get_filename_and_charpos.
7281
7282 2019-06-14  Tom Tromey  <tromey@adacore.com>
7283
7284         PR gdb/24502:
7285         * ui-style.h (skip_ansi_escape): Update comment.
7286         * ui-file.h (class no_terminal_escape_file): New class.
7287         * ui-file.c (no_terminal_escape_file::write)
7288         (no_terminal_escape_file::puts): New methods.
7289         * cli/cli-logging.c (handle_redirections): Use
7290         no_terminal_escape_file.
7291
7292 2019-06-14  Tom Tromey  <tromey@adacore.com>
7293
7294         * NEWS: Move convenience variable news above Python news.
7295
7296 2019-06-14  Tom Tromey  <tom@tromey.com>
7297
7298         * gnulib: Move directory to top-level.
7299         * configure.ac: Don't configure gnulib.
7300         * configure: Rebuild.
7301         * common/common-defs.h: Use new path to gnulib.
7302         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
7303         (GNULIB_H): Remove.
7304         (INCGNU): Look in new gnulib location.
7305         (HFILES_NO_SRCDIR): Remove gnulib files.
7306         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
7307         (generated_files): Remove GNULIB_H.
7308         ($(LIBGNU), all-lib): Remove targets.
7309         (distclean): Don't mention GNULIB_BUILDDIR.
7310         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
7311
7312 2019-06-14  Tom Tromey  <tromey@adacore.com>
7313
7314         * symfile.c (add_symbol_file_command): Remove obsolete comment.
7315         Warn if symbol file does not provide any symbols.
7316
7317 2019-06-14  Tom Tromey  <tromey@adacore.com>
7318
7319         * source.c (find_and_open_source): Respect basenames_may_differ.
7320
7321 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
7322
7323         * annotate.c (annotate_breakpoints_invalid): Make use of
7324         scoped_restore_terminal_state.
7325         (annotate_frames_invalid): Likewise.
7326
7327 2019-06-14  Tom Tromey  <tromey@adacore.com>
7328
7329         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
7330         allow assignment to an internalvar.
7331
7332 2019-06-14  Tom Tromey  <tromey@adacore.com>
7333
7334         * ada-lex.l: Allow "_" in attribute names.
7335
7336 2019-06-14  Tom Tromey  <tromey@adacore.com>
7337
7338         PR gdb/24653:
7339         * regcache.c (registers_changed): Don't call alloca.
7340         * top.c (execute_command): Don't call alloca.
7341
7342 2019-06-13  Pedro Alves  <palves@redhat.com>
7343
7344         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
7345         'expression'.  When parsing an expression, error out if there's
7346         junk after "unlimited".
7347         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
7348         (do_set_command): Adjust calls to is_unlimited_literal.
7349
7350 2019-06-13  Pedro Alves  <palves@redhat.com>
7351
7352         * compile/compile.c (make_compile_options_def_group): Add braces
7353         around array_view initializer.
7354         * thread.c (make_thread_apply_all_options_def_group)
7355         (make_thread_apply_all_options_def_group): Likewise.
7356
7357 2019-06-13  Pedro Alves  <palves@redhat.com>
7358
7359         * NEWS (New commands): Mention "maint test-options
7360         require-delimiter", "maint test-options unknown-is-error", "maint
7361         test-options unknown-is-operand" and "maint show
7362         test-options-completion-result".
7363         (New command options, command completion): New section.
7364         (Completion improvements): New section.
7365         Mention that you can abbreviate "unlimited".
7366
7367 2019-06-13  Pedro Alves  <palves@redhat.com>
7368
7369         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
7370         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
7371         * unittests/cli-utils-selftests.c (test_parse_flags)
7372         (test_parse_flags_qcs): Delete.
7373         (test_cli_utils): Don't call deleted functions.
7374
7375 2019-06-13  Pedro Alves  <palves@redhat.com>
7376
7377         * thread.c: Include "cli/cli-option.h".
7378         (tp_array_compar_ascending): Global.
7379         (tp_array_compar): Delete function.
7380         (tp_array_compar_ascending, tp_array_compar_descending): New
7381         functions.
7382         (ascending_option_def, qcs_flag_option_def)
7383         (thr_qcs_flags_option_defs)
7384         (make_thread_apply_all_options_def_group)
7385         (make_thread_apply_options_def_group): New.
7386         (thread_apply_all_command): Use gdb::option::process_options.
7387         (thread_apply_command_completer)
7388         (thread_apply_all_command_completer): New.
7389         (thread_apply_command): Use gdb::option::process_options.
7390         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
7391         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
7392         to generate help text of "thread apply".  Adjust "taas"'s help.
7393         * tid-parse.c (tid_range_parser::in_thread_range): New method.
7394         * tid-parse.h (tid_range_parser::in_thread_range): New method.
7395
7396 2019-06-13  Pedro Alves  <palves@redhat.com>
7397
7398         * thread.c (thread_apply_command): Check for invalid TID with
7399         isdigit instead of !isalpha.
7400
7401 2019-06-13  Pedro Alves  <palves@redhat.com>
7402
7403         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
7404         (validate_flags_qcs): New.
7405         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
7406         (validate_flags_qcs): Declare.
7407         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
7408         (make_frame_apply_options_def_group): New.
7409         (frame_apply_command_count): Process options with
7410         gdb::option::process_options.
7411         (frame_apply_completer): New.
7412         (frame_apply_level_completer, frame_apply_all_completer)
7413         (frame_apply_completer): New.
7414         (_initialize_stack): Update help of "frame apply", "frame apply
7415         level", "frame apply all" and "faas" to mention supported options
7416         and install command completers.
7417         * stack.h (frame_apply_all_completer): Declare.
7418         * thread.c: Include "stack.h".
7419         (tfaas_command): Add "--".
7420         (_initialize_thread): Update help "tfaas" to mention supported
7421         options and install command completer.
7422
7423 2019-06-13  Pedro Alves  <palves@redhat.com>
7424
7425         * completer.c (complete_nested_command_line): New.
7426         (gdb_completion_word_break_characters_throw): Add assertion.
7427         * completer.h (complete_nested_command_line): Declare.
7428
7429 2019-06-13  Pedro Alves  <palves@redhat.com>
7430
7431         * stack.c (parse_backtrace_qualifiers): New.
7432         (backtrace_command): Use it.
7433         (backtrace_command_completer): Complete on qualifiers.
7434
7435 2019-06-13  Pedro Alves  <palves@redhat.com>
7436
7437         * frame.c: Include "cli/cli-option.h.
7438         (user_set_backtrace_options): New.
7439         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
7440         Delete.
7441         (get_prev_frame): Adjust.
7442         (boolean_option_def, uinteger_option_def)
7443         (set_backtrace_option_defs): New.
7444         (_initialize_frame): Adjust and use
7445         gdb::option::add_setshow_cmds_for_options to install "set
7446         backtrace past-main" and "set backtrace past-entry".
7447         * frame.h: Include "cli/cli-option.h".
7448         (struct frame_print_options): Forward declare.
7449         (print_frame_arguments_all, print_frame_arguments_scalars)
7450         (print_frame_arguments_none): Declare.
7451         (print_entry_values): Delete declaration.
7452         (struct frame_print_options, user_frame_print_options): New.
7453         (struct set_backtrace_options): New.
7454         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
7455         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
7456         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
7457         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
7458         (list_args_or_locals): Add frame_print_options parameter.
7459         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
7460         * python/py-framefilter.c (enumerate_args): Pass down
7461         USER_FRAME_PRINT_OPTIONS.
7462         * stack.c: Include "cli/cli-option.h".
7463         (print_frame_arguments_all, print_frame_arguments_scalars)
7464         (print_frame_arguments_none): Declare.
7465         (print_raw_frame_arguments, print_entry_values): Delete.
7466         (user_frame_print_options): New.
7467         (boolean_option_def, enum_option_def, frame_print_option_defs):
7468         New.
7469         (struct backtrace_cmd_options): New.
7470         (bt_flag_option_def): New.
7471         (backtrace_command_option_defs): New.
7472         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
7473         (print_frame_arg, read_frame_arg, print_frame_args)
7474         (print_frame_info, print_frame): Add frame_print_options parameter
7475         and use it.
7476         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
7477         (backtrace_command_1): Add frame_print_options and
7478         backtrace_cmd_options parameters and use them.
7479         (make_backtrace_options_def_group): New.
7480         (backtrace_command): Process command options with
7481         gdb::option::process_options.
7482         (backtrace_command_completer): New.
7483         (_initialize_stack): Extend "backtrace"'s help to mention
7484         supported options.  Install completer for "backtrace".
7485         Install some settings commands with add_setshow_cmds_for_options.
7486
7487 2019-06-13  Pedro Alves  <palves@redhat.com>
7488
7489         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
7490         and that "set/show print raw frame-arguments" are now deprecated.
7491
7492         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
7493         command.
7494         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
7495         * stack.c (_initialize_stack): Install "set/show print
7496         raw-frame-arguments", and deprecate "set/show print raw
7497         frame-arguments".
7498         * valprint.c (_initialize_valprint): Deprecate "set/show print
7499         raw".
7500
7501 2019-06-13  Pedro Alves  <palves@redhat.com>
7502
7503         * compile/compile.c (struct compile_options): New.
7504         (compile_flag_option_def, compile_command_option_defs)
7505         (make_compile_options_def_group): New.
7506         (compile_file_command): Handle options with
7507         gdb::option::process_options.
7508         (compile_file_command_completer): New function.
7509         (compile_code_command): Handle options with
7510         gdb::option::process_options.
7511         (compile_code_command_completer): New function.
7512         (_initialize_compiler): Install completers for "compile code" and
7513         "compile file".  Mention available options in "compile code" and
7514         "compile code"'s help.
7515         * completer.c (advance_to_completion_word): New, factored out from
7516         ...
7517         (advance_to_expression_complete_word_point): ... this.
7518         (advance_to_filename_complete_word_point): New.
7519         * completer.h (advance_to_filename_complete_word_point): New
7520         declaration.
7521
7522 2019-06-13  Pedro Alves  <palves@redhat.com>
7523
7524         * compile/compile.c: Include "cli/cli-option.h".
7525         (compile_print_value): Scope data pointer is now a
7526         value_print_options pointer; adjust.
7527         (compile_print_command): Process options.  Scope data pointer is
7528         now a value_print_options pointer; adjust.
7529         (_initialize_compile): Update "compile print"'s help to include
7530         supported options.  Install a completer for "compile print".
7531         * cp-valprint.c (show_vtblprint, show_objectprint)
7532         (show_static_field_print): Delete.
7533         (_initialize_cp_valprint): Don't install "set print
7534         static-members", "set print vtbl", "set print object" here.
7535         * printcmd.c: Include "cli/cli-option.h" and
7536         "common/gdb_optional.h".
7537         (print_command_parse_format): Rework to fill in a
7538         value_print_options instead of a format_data.
7539         (print_value): Change parameter type from format_data pointer to
7540         value_print_options reference.  Adjust.
7541         (print_command_1): Process options.  Adjust to pass down a
7542         value_print_options.
7543         (print_command_completer): New.
7544         (_initialize_printcmd): Install print_command_completer as
7545         handle_brkchars completer for the "print" command.  Update
7546         "print"'s help to include supported options.
7547         * valprint.c: Include "cli/cli-option.h".
7548         (show_vtblprint, show_objectprint, show_static_field_print): Moved
7549         here from cp-valprint.c.
7550         (boolean_option_def, uinteger_option_def)
7551         (value_print_option_defs, make_value_print_options_def_group):
7552         New.  Use gdb::option::add_setshow_cmds_for_options to install
7553         "set print elements", "set print null-stop", "set print repeats",
7554         "set print pretty", "set print union", "set print array", "set
7555         print address", "set print symbol", "set print array-indexes".
7556         * valprint.h: Include <string> and "cli/cli-option.h".
7557         (make_value_print_options_def_group): Declare.
7558         (print_value): Change parameter type from format_data pointer to
7559         value_print_options reference.
7560         (print_command_completer): Declare.
7561
7562 2019-06-13  Pedro Alves  <palves@redhat.com>
7563
7564         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
7565         (COMMON_SFILES): Add maint-test-settings.c.
7566         * cli/cli-decode.c (boolean_enums): New global, factored out from
7567         ...
7568         (add_setshow_boolean_cmd): ... here.
7569         * cli/cli-decode.h (boolean_enums): Declare.
7570         * cli/cli-option.c: New file.
7571         * cli/cli-option.h: New file.
7572         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
7573         factored out from ...
7574         (parse_cli_boolean_value(const char *)): ... this.
7575         (is_unlimited_literal): Change parameter type to pointer to
7576         pointer.  Adjust and advance ARG pointer.
7577         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
7578         (parse_cli_var_enum): New, factored out from ...
7579         (do_set_command): ... this.  Adjust.
7580         * cli/cli-setshow.h (parse_cli_boolean_value)
7581         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
7582         (parse_cli_var_enum): Declare.
7583         * cli/cli-utils.c: Include "cli/cli-option.h".
7584         (get_ulongest): New.
7585         * cli/cli-utils.h (get_ulongest): Declare.
7586         (check_for_argument): New overloads.
7587         * maint-test-options.c: New file.
7588
7589 2019-06-13  Pedro Alves  <palves@redhat.com>
7590
7591         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
7592         parse a range if "-" is at the end of the string.
7593
7594 2019-06-13  Pedro Alves  <palves@redhat.com>
7595
7596         * cli/cli-setshow.c (parse_auto_binary_operation)
7597         (parse_cli_boolean_value): Don't allow "o".
7598
7599 2019-06-13  Pedro Alves  <palves@redhat.com>
7600
7601         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
7602         * NEWS: Mention maint test-settings KIND.
7603         * maint-test-settings.c: New file.
7604
7605 2019-06-13  Pedro Alves  <palves@redhat.com>
7606
7607         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
7608         completer.
7609         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
7610         "set" completers.
7611
7612 2019-06-13  Pedro Alves  <palves@redhat.com>
7613
7614         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
7615         after item.
7616
7617 2019-06-13  Pedro Alves  <palves@redhat.com>
7618
7619         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
7620
7621 2019-06-13  Pedro Alves <palves@redhat.com>
7622
7623         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
7624         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
7625         call.
7626         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
7627         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
7628         calls.
7629         (check_for_argument): Skip spaces after argument.
7630
7631 2019-06-13  Pedro Alves  <palves@redhat.com>
7632
7633         * thread.c (thread_apply_command): Adjust TID parsing.
7634         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
7635         detected before end of string.
7636         (tid_is_in_list): Error out if LIST is invalid.
7637
7638 2019-06-13  Pedro Alves  <palves@redhat.com>
7639
7640         * completer.c (complete_line_internal_1): Rewind completion word
7641         point.
7642         (completion_tracker::advance_custom_word_point_by): Change
7643         parameter type to int.
7644         * completer.h (completion_tracker::advance_custom_word_point_by):
7645         Likewise.
7646
7647 2019-06-13  Pedro Alves  <palves@redhat.com>
7648
7649         * completer.c (advance_to_completion_word): Handle delimiters.
7650
7651 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
7652
7653         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
7654
7655 2019-06-11  Tom Tromey  <tom@tromey.com>
7656
7657         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
7658         (xmalloc_failed): Move to alloc.c.
7659         * alloc.c: New file.
7660         * Makefile.in (COMMON_SFILES): Add alloc.c.
7661
7662 2019-06-11  Tom Tromey  <tom@tromey.com>
7663
7664         * nat/linux-waitpid.c: Don't include server.h.
7665         (linux_debug): Remove.
7666         (my_waitpid): Update.
7667
7668 2019-06-11  Tom Tromey  <tromey@adacore.com>
7669
7670         * infcall.c (_initialize_infcall): Remove trailing newline from
7671         help.
7672         * user-regs.c (_initialize_user_regs): Remove trailing newline
7673         from help.
7674         * typeprint.c (_initialize_typeprint): Remove trailing newline
7675         from help.
7676         * reverse.c (_initialize_reverse): Remove trailing newlines from
7677         help.
7678         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
7679         from help.
7680         * language.c (add_set_language_command): Remove trailing newline
7681         from help.
7682         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
7683         help.
7684         * disasm.c (_initialize_disasm): Remove trailing newline from
7685         help.
7686         * top.c (init_main): Remove trailing newline from help.
7687         * interps.c (_initialize_interpreter): Remove trailing newline
7688         from help.
7689         * btrace.c (_initialize_btrace): Remove trailing newlines from
7690         help.
7691         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
7692         from help.
7693         * python/python.c (_initialize_python): Remove trailing newline
7694         from help.
7695         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
7696         help.
7697         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
7698         from help.  Reformat some text.
7699         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
7700         from help.
7701         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
7702         newline from help.
7703
7704 2019-06-11  Tom Tromey  <tromey@adacore.com>
7705
7706         * darwin-nat.c (darwin_decode_exception_message)
7707         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
7708
7709 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
7710
7711         * valops.c (value_slice): Check for not allocated or not
7712         associated values.
7713
7714 2019-06-10  Tom de Vries  <tdevries@suse.de>
7715
7716         PR gdb/24618
7717         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
7718         sure an empty slot (defined by a 32-bit zero pair) is recognized as
7719         invalid.
7720
7721 2019-06-10  Tom de Vries  <tdevries@suse.de>
7722
7723         PR gdb/24611
7724         * linespec.c (linespec_lexer_lex_string): Remove incorrect
7725         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
7726
7727 2019-06-10  Tom de Vries  <tdevries@suse.de>
7728
7729         PR symtab/24545
7730         * symtab.c (struct demangled_name_entry): Add language field.
7731         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
7732         static minimal symbol".  Set and use language field.
7733
7734 2019-06-10  Tom Tromey  <tromey@adacore.com>
7735
7736         * ada-lang.c (_initialize_ada_language): Update help text.
7737
7738 2019-06-10  Tom Tromey  <tromey@adacore.com>
7739
7740         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
7741         with a newline.
7742         * guile/guile.c (handle_boot_error): Don't end warning with a
7743         newline.
7744         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
7745         warning with a newline.
7746         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
7747         newline.
7748         (s12z_frame_cache): Likewise.
7749         * dwarf-index-cache.c (index_cache::store): Don't end warning with
7750         a newline.
7751         * solib-svr4.c (disable_probes_interface): Don't end warning with
7752         a newline.
7753         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
7754         newline.
7755         * python/python.c (do_finish_initialization): Don't end warning
7756         with a newline.
7757
7758 2019-06-10  Tom Tromey  <tom@tromey.com>
7759
7760         * python/py-breakpoint.c (gdbpy_breakpoint_created)
7761         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
7762         gdbpy_enter.
7763
7764 2019-06-10  Tom Tromey  <tromey@adacore.com>
7765
7766         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
7767         data.
7768         (elf_new_init): Don't call stabsread_new_init.
7769         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
7770         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
7771         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
7772
7773 2019-06-10  Tom de Vries  <tdevries@suse.de>
7774
7775         PR symtab/16264
7776         PR symtab/24517
7777         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
7778
7779 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
7780
7781         * source.c (find_and_open_source): Also rewrite relative file
7782         names.
7783
7784 2019-04-26  Amos Bird  <amosbird@gmail.com>
7785
7786         * annotate.c (annotate_thread_exited): Add "thread-exited"
7787         annotation.
7788
7789 2019-06-06  Tom Tromey  <tromey@adacore.com>
7790
7791         * maint.h (class scoped_command_stats): Use
7792         DISABLE_COPY_AND_ASSIGN.
7793         <print_time>: New method.
7794         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
7795         print_time.
7796         (scoped_command_stats::print_time): New method.
7797
7798 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
7799
7800         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
7801         instructions of lengths 6 or 8 bytes.
7802
7803 2019-06-04  Pedro Alves  <palves@redhat.com>
7804
7805         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
7806
7807         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
7808         * breakpoint.c (condition_completer): Likewise.
7809         * cli/cli-dump.c (scan_expression): Likewise.
7810         * common/filestuff.c (mkdir_recursive): Likewise.
7811         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
7812         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
7813         (gdb_abspath): Likewise.
7814         * compile/compile-cplus-types.c
7815         (compile_cplus_instance::decl_name): Likewise.
7816         * completer.c (complete_explicit_location):
7817         (signal_completer, reg_or_group_completer_1): Likewise.
7818         * cp-support.c (cp_remove_params_if_any): Likewise.
7819         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
7820         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
7821         * infcmd.c (strip_bg_char): Likewise.
7822         * linespec.c (copy_token_string): Likewise.
7823         * mi/mi-main.c (output_cores): Likewise.
7824         * psymtab.c (psymtab_search_name):
7825         * symfile.c (test_set_ext_lang_command): Likewise.
7826         * target.c (target_fileio_read_stralloc): Likewise.
7827         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
7828         * value.c (complete_internalvar): Likewise.
7829
7830 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
7831
7832         Add objfile property to gdb.Type.
7833         * NEWS: Mention Python API addition.
7834         * python/py-type.c (typy_get_objfile): New method.
7835
7836 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7837
7838         * NEWS: Mention the new set|show style [title|highlight].
7839         Mention changes to "show style", "help" and "apropos".
7840
7841 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7842
7843         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
7844         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
7845         instead of print_help_for_command.
7846         (print_doc_of_command): New function.
7847         (help_list): Add 'apropos -v word' suggestion.
7848         (print_help_for_command): Style the command name using title style.
7849         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
7850         (_initialize_cli_cmds): Describe -v in apropos_command help.
7851
7852 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7853
7854         * cli/cli-style.h (cli_style_option): Add name in constructor,
7855         add m_name class member, add constructor with intensity,
7856         add name class function.
7857         (cli_style_option::add_setshow_commands): Remove name argument.
7858         (highlight_style, title_style): New styles.
7859         * cli/cli-style.c (do_show): New function that shows a style
7860         characteristic styling the style name with itself.
7861         (set_style_name): New function.
7862         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
7863         Update all callers according to the changes in cli/cli-style.h.
7864         * utils.h (fputs_highlighted): New function.
7865         * utils.c (fputs_highlighted): Likewise.
7866
7867 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7868
7869         * NEWS: Mention new pipe command and new convenience variables.
7870
7871 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7872
7873         * cli/cli-cmds.c (pipe_command): New function.
7874         (_initialize_cli_cmds): Call add_com for pipe_command.
7875         Define | as an alias for pipe.
7876         (exit_status_set_internal_vars): New function.
7877         (shell_escape): Call exit_status_set_internal_vars.
7878         cli/cli-decode.c (find_command_name_length): Recognize | as
7879         a single character command.
7880
7881 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7882
7883         * gdbcmd.h (execute_command_to_ui_file): New declaration.
7884         top.c (execute_command_to_ui_file): New function, mostly a copy
7885         of execute_command_to_string.
7886         (execute_command_to_string): Implement by calling
7887         execute_command_to_ui_file.
7888
7889 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7890
7891         * top.h (saved_command_line): Remove declaration.
7892         * top.c (previous_saved_command_line, previous_repeat_arguments):
7893         New variables.
7894         (saved_command_line): Make static, define together with other
7895         'repeat variables'.
7896         (dont_repeat): Clear repeat_arguments.
7897         (repeat_previous, get_saved_command_line, save_command_line):
7898         New functions.
7899         (gdb_init): Initialize saved_command_line
7900         and previous_saved_command_line.
7901         * main.c (captured_main_1): Remove saved_command_line initialization.
7902         * event-top.c (handle_line_of_input): Update to use
7903         the new 'repeat' related functions instead of direct access to
7904         saved_command_line.
7905         * command.h (repeat_previous, get_saved_command_line,
7906         save_command_line): New declarations.
7907         (dont_repeat): Add comment.
7908
7909 2019-05-30  Tom Tromey  <tromey@adacore.com>
7910
7911         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
7912         Fix comment.
7913         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
7914
7915 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
7916
7917         PR cli/24587
7918         * completer.c (complete): Initialize variable word.
7919
7920 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
7921
7922         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
7923         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
7924         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
7925         'body' is NULL to the outter 'if', protecting the '!is_define'
7926         situation as well.
7927
7928 2019-05-29  Tom Tromey  <tromey@adacore.com>
7929
7930         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
7931         (dwarf_unknown): New function.
7932         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
7933         (dwarf_type_encoding_name): Use dwarf_unknown.
7934
7935 2019-05-29  Tom Tromey  <tromey@adacore.com>
7936
7937         PR c++/20020:
7938         * cp-valprint.c (cp_print_value_fields): Call
7939         cp_print_static_field inside "try".
7940
7941 2019-05-29  Tom Tromey  <tromey@adacore.com>
7942
7943         * inflow.c (struct terminal_info): Add default operator=.
7944         * configure: Rebuild.
7945         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
7946         -Wdeprecated-copy-dtor, -Wredundant-move.
7947
7948 2019-05-29  Tom Tromey  <tromey@adacore.com>
7949
7950         * NEWS: Add entry.
7951         * infcmd.c (print_return_value_1): Handle finish_print
7952         option.
7953         (show_print_finish): New function.
7954         (_initialize_infcmd): Add "set/show print finish" commands.
7955         * valprint.c (user_print_options): Initialize new member.
7956         * valprint.h (struct value_print_options) <finish_print>: New
7957         member.
7958
7959 2019-05-28  Tom Tromey  <tromey@adacore.com>
7960
7961         * ada-lang.c (ada_remove_Xbn_suffix)
7962         (find_old_style_renaming_symbol)
7963         (parse_old_style_renaming): Remove.
7964         (ada_find_renaming_symbol): Don't call
7965         find_old_style_renaming_symbol.
7966         (ada_is_renaming_symbol): Rename from
7967         ada_find_renaming_symbol.  Remove "block" parameter.  Return
7968         bool.  Now static.
7969         (ada_read_var_value): Update and simplify.
7970         * ada-exp.y (write_var_or_type): Remove old code.
7971
7972 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
7973
7974         PR gdb/25010
7975         * event-top.c: Remove include comment.
7976         * inflow.c (class scoped_ignore_sigttou): Move from here...
7977         * inflow.h (class scoped_ignore_sigttou): ...to here.
7978         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
7979         * top.c:  Remove include comment.
7980
7981 2019-05-27  Tom Tromey  <tom@tromey.com>
7982
7983         * NEWS: Fix typo.
7984
7985 2019-05-22  Tom Tromey  <tromey@adacore.com>
7986
7987         * target.c (target_follow_exec): Constify parameter.
7988         * target-delegates.c: Rebuild.
7989         * remote.c (remote_target::follow_exec): Constify parameter.
7990         * infrun.c (follow_exec): Constify parameter.
7991         * target.h (struct target_ops) <follow_exec>: Constify parameter.
7992         (target_follow_exec): Likewise.
7993
7994 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
7995
7996         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
7997         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
7998
7999 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
8000
8001         * NEWS: Add debugredirect and testsuite sections.
8002
8003 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
8004
8005         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
8006         target descriptions using exclusively floating point register name
8007         aliases.
8008
8009 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
8010
8011         PR gdb/18644:
8012         * f-lang.c (build_fortran_types): Handle the case where
8013         gdbarch_floatformat_for_type returns a nullptr.
8014
8015 2019-05-21  Tom de Vries  <tdevries@suse.de>
8016
8017         PR cli/24587
8018         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
8019
8020 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
8021
8022         PR gdb/18644:
8023         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
8024         16-byte floats.
8025         * i386-tdep.c (i386_floatformat_for_type): Use
8026         floatformats_ia64_quad for the 16-byte floating point component
8027         within a fortran 32-byte complex number.
8028
8029 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
8030
8031         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
8032         delete default constructor.
8033         (find_partial_die): Update to return const struct.
8034         (partial_die_parent_scope): Move variable declaration into scope
8035         of its use and change its type to auto.
8036         (guess_partial_die_structure_name): Likewise.
8037         (partial_die_info::fixup): Likewise.
8038
8039 2019-05-17  Tom Tromey  <tromey@adacore.com>
8040
8041         * source.c (find_and_open_source): Remove cast.
8042
8043 2019-05-17  Tom Tromey  <tromey@adacore.com>
8044
8045         * annotate.c (annotate_source): Make "filename" const.
8046         * annotate.h (annotate_source): Use const.
8047
8048 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
8049
8050         * disasm.c (set_disassembler_options): Send errors to stderr.
8051
8052 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
8053
8054         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
8055         (cli_interp_base::set_logging): Check debug_redirect.
8056         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
8057         * cli/cli-logging.c (debug_redirect): Add static variable.
8058         (pop_output_files): Add default param.
8059         (handle_redirections): Print debug setting.
8060         (show_logging_command): Likewise.
8061         (_initialize_cli_logging): Add debugredirect command.
8062         * interps.c (current_interp_set_logging): Add debug_redirect
8063         parameter.
8064         * interps.h (set_logging): Add debug_redirect parameter.
8065         (current_interp_set_logging): Likewise.
8066         * mi/mi-common.h: Likewise.
8067         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
8068
8069 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
8070             Tom Tromey  <tromey@adacore.com>
8071
8072         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
8073         directly.
8074         * cli/cli-interp.h (make_logging_output): Remove declaration.
8075         * cli/cli-logging.c (make_logging_output): Remove function.
8076         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
8077         directly.
8078         * ui-file.c (tee_file::tee_file): Remove bools.
8079         (tee_file::~tee_file): Remove deletes.
8080         * ui-file.h (tee_file): Remove bools.
8081
8082 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
8083
8084         * mi/mi-cmds.h (mi_cmd_complete): New function.
8085         * mi/mi-main.c (mi_cmd_complete): Likewise.
8086         * mi/mi-cmds.c: Define new MI command -complete.
8087         * NEWS: Mention new -complete command.
8088
8089 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
8090
8091         * completer.h (complete): New function.
8092         * completer.c (complete): Likewise.
8093         * cli/cli-cmds.c: (complete_command): Update to use new complete()
8094         function defined in completer.h.
8095
8096 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
8097
8098         * MAINTAINERS (Write After Approval): Add myself.
8099
8100 2019-05-17  Tom de Vries  <tdevries@suse.de>
8101
8102         PR gdb/24094
8103         * dwarf2read.c (struct cu_partial_die_info): New struct.
8104         (find_partial_die): Return cu_partial_die_info.
8105         (partial_die_parent_scope, guess_partial_die_structure_name)
8106         (partial_die_info::fixup): Handle new return type of find_partial_die.
8107
8108 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
8109
8110         PR breakpoints/24541
8111         * stap-probe.c (stap_parse_register_operand): Make "regname" an
8112         "std::string", simplifying the algorithm.
8113
8114 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
8115
8116         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
8117         (stap_static_probe_ops::get_probes): Likewise.
8118
8119 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
8120
8121         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
8122         '-')" and "else if".
8123         (stap_parse_single_operand): Join checks for
8124         "gdbarch_stap_parse_special_token_p" and
8125         "gdbarch_stap_parse_special_token" in the same "if" statement.
8126         Invert check when verifying for operation on register
8127         displacement.
8128
8129 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
8130
8131         * stap-probe.c (stap_get_opcode): Update comment.
8132         (stap_get_expected_argument_type): Likewise.
8133         (handle_stap_probe): Likewise.
8134
8135 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
8136
8137         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
8138         return type to 'bool'.  Adjust comment.  Use 'bool' when
8139         appropriate.
8140         (i386_stap_parse_special_token_three_arg_disp): Likewise.
8141         * stap-probe.c (stap_parse_argument_1): Likewise.
8142         (stap_is_operator): Likewise.
8143         (stap_is_generic_prefix): Likewise.
8144         (stap_is_register_prefix): Likewise.
8145         (stap_is_register_indirection_prefix): Likewise.
8146         (stap_is_integer_prefix): Likewise.
8147         (stap_generic_check_suffix): Likewise.
8148         (stap_check_integer_suffix): Likewise.
8149         (stap_check_register_suffix): Likewise.
8150         (stap_check_register_indirection_suffix): Likewise.
8151         (stap_parse_register_operand): Likewise.
8152         (stap_parse_single_operand): Likewise.
8153         (stap_parse_argument_1): Likewise.
8154         (stap_probe::get_argument_count): Likewise.
8155         (stap_is_operator): Likewise.
8156
8157 2019-05-16  Tom Tromey  <tromey@adacore.com>
8158
8159         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
8160         keyword to foreach.
8161
8162 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
8163
8164         * linux-thread-db.c (try_thread_db_load_1): Change return type
8165         to bool.
8166         (try_thread_db_load): Likewise.
8167         (try_thread_db_load_from_pdir_1): Likewise.
8168         (try_thread_db_load_from_pdir): Likewise.
8169         (try_thread_db_load_from_sdir): Likewise.
8170         (try_thread_db_load_from_dir): Likewise.
8171         (thread_db_load_search): Likewise.
8172         (has_libpthread): Likewise.
8173         (thread_db_load): Likewise.
8174
8175 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
8176
8177         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
8178         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
8179         NULL, and complain/return if that's the case.
8180
8181 2019-05-15  John Darrington <john@darrington.wattle.id.au>
8182
8183         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
8184         (advance, posn, abstract_read_memory): New functions.
8185         [struct mem_read_abstraction]: New struct.
8186         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
8187
8188 2019-05-14  Tom Tromey  <tromey@adacore.com>
8189
8190         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
8191         value is not lval_memory.
8192
8193 2019-05-14  Tom Tromey  <tromey@adacore.com>
8194
8195         * solib.c (info_sharedlibrary_command): Style the file name.
8196
8197 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
8198
8199         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
8200         (aarch64_vnv_type): Likewise.
8201         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
8202         * common/tdesc.c: Likewise.
8203         * common/tdesc.h (enum tdesc_type_kind): Likewise.
8204         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
8205         * features/aarch64-fpu.xml: Add ieee half view.
8206         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
8207         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
8208         * gdbtypes.h (struct builtin_type): Likewise.
8209         (struct objfile_type): Likewise.
8210
8211 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
8212
8213         * language.c (language_sniff_from_mangled_name): Fix "langauge"
8214         typo.
8215         * location.h (string_to_event_location): Likewise.
8216
8217 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
8218
8219         GDB 8.3 released.
8220
8221 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
8222
8223         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
8224         New variable declaration.
8225         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
8226         New variable.
8227         (print_one_breakpoint): Use ui_out::test_flags and new global
8228         variable to compute use_fixed_output.
8229         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
8230         Remove.
8231         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
8232         (mi_multi_location_breakpoint_output_fixed): Remove.
8233         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
8234         new variable.
8235         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
8236         fix_multi_location_breakpoint_output flag if version >= 3.
8237         * ui-out.h (enum ui_out_flag)
8238         <fix_multi_location_breakpoint_output>: New enumerator.
8239
8240 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
8241
8242         * contrib/cc-with-tweaks.sh: Validate dwz's work.
8243
8244 2019-05-10  Tom Tromey  <tromey@adacore.com>
8245
8246         * ada-lang.c (catch_ada_completer): New function.
8247         (_initialize_ada_language): Use it.
8248
8249 2019-05-10  Tom Tromey  <tromey@adacore.com>
8250
8251         * thread.c (print_thread_info): Make "requested_threads" const.
8252         * gdbthread.h (print_thread_info): Make "requested_threads"
8253         const.
8254         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
8255         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
8256
8257 2019-05-08  Tom Tromey  <tom@tromey.com>
8258
8259         * gdbtypes.c (objfile_type_data): Change type.
8260         (objfile_type, _initialize_gdbtypes): Update.
8261
8262 2019-05-08  Tom Tromey  <tom@tromey.com>
8263
8264         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
8265         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
8266         (_initialize_dwarf2_frame): Update.
8267
8268 2019-05-08  Tom Tromey  <tom@tromey.com>
8269
8270         * objc-lang.c (objc_objfile_data): Change type.
8271         (find_methods): Update.
8272         (_initialize_objc_lang): Remove.
8273
8274 2019-05-08  Tom Tromey  <tom@tromey.com>
8275
8276         * stabsread.c (rs6000_builtin_type_data): Change type.
8277         (rs6000_builtin_type, _initialize_stabsread): Update.
8278
8279 2019-05-08  Tom Tromey  <tom@tromey.com>
8280
8281         * mips-tdep.c (mips_pdr_data): Remove.
8282         (_initialize_mips_tdep): Update.
8283
8284 2019-05-08  Tom Tromey  <tom@tromey.com>
8285
8286         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
8287         (hppa_init_objfile_priv_data, read_unwind_info)
8288         (find_unwind_entry, _initialize_hppa_tdep): Update.
8289
8290 2019-05-08  Tom Tromey  <tom@tromey.com>
8291
8292         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
8293         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
8294         on obstack.
8295         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
8296
8297 2019-05-08  Tom Tromey  <tom@tromey.com>
8298
8299         * mdebugread.c (basic_type_data): Change type.
8300         (basic_type, _initialize_mdebugread): Update.
8301
8302 2019-05-08  Tom Tromey  <tom@tromey.com>
8303
8304         * common/gdb_unique_ptr.h (struct noop_deleter): New.
8305
8306 2019-05-08  Tom Tromey  <tom@tromey.com>
8307
8308         * nto-tdep.c (nto_inferior_data_reg): Change type.
8309         (nto_inferior_data): Update.
8310         (nto_inferior_data_cleanup, nto_new_inferior_data)
8311         (_initialize_nto_tdep): Remove.
8312         * nto-tdep.h (struct nto_inferior_data): Add initializers.
8313
8314 2019-05-08  Tom Tromey  <tom@tromey.com>
8315
8316         * ada-lang.c (struct ada_inferior_data): Add initializers.
8317         (ada_inferior_data): Change type.
8318         (ada_inferior_data_cleanup): Remove.
8319         (get_ada_inferior_data, ada_inferior_exit)
8320         (struct ada_pspace_data): Add initializers, destructor.
8321         (ada_pspace_data_handle): Change type.
8322         (get_ada_pspace_data): Update.
8323         (ada_pspace_data_cleanup): Remove.
8324
8325 2019-05-08  Tom Tromey  <tom@tromey.com>
8326
8327         * coffread.c (struct coff_symfile_info): Add initializers.
8328         (coff_objfile_data_key): Move lower.  Change type.
8329         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
8330         Update.
8331         (coff_free_info): Remove.
8332
8333 2019-05-08  Tom Tromey  <tom@tromey.com>
8334
8335         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
8336         (fbsd_pspace_data_handle): Move lower.  Change type.
8337         (get_fbsd_pspace_data): Update.
8338         (fbsd_pspace_data_cleanup): Remove.
8339         (_initialize_fbsd_tdep): Update.
8340
8341 2019-05-08  Tom Tromey  <tom@tromey.com>
8342
8343         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
8344         (get_ada_tasks_pspace_data): Update.
8345         (ada_tasks_pspace_data_cleanup): Remove.
8346         (_initialize_tasks): Update.
8347         (ada_tasks_inferior_data_handle): Change type.
8348         (get_ada_tasks_inferior_data): Update.
8349         (ada_tasks_inferior_data_cleanup): Remove.
8350         (struct ada_tasks_pspace_data): Add initializers.
8351
8352 2019-05-08  Tom Tromey  <tom@tromey.com>
8353
8354         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
8355         * symfile-debug.c (debug_sym_get_probes): Change type.
8356         * stap-probe.c (handle_stap_probe):
8357         (stap_static_probe_ops::get_probes): Change type.
8358         * probe.h (class static_probe_ops) <get_probes>: Change type.
8359         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
8360         (parse_probes_in_pspace): Update.
8361         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
8362         Update.
8363         (any_static_probe_ops::get_probes): Change type.
8364         * elfread.c (elfread_data): New typedef.
8365         (probe_key): Change type.
8366         (elf_get_probes): Likewise.  Update.
8367         (probe_key_free): Remove.
8368         (_initialize_elfread): Update.
8369         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
8370         Change type.
8371         (dtrace_process_dof_probe, dtrace_process_dof)
8372         (dtrace_static_probe_ops::get_probe): Change type.
8373
8374 2019-05-08  Tom Tromey  <tom@tromey.com>
8375
8376         * xcoffread.c (struct xcoff_symfile_info): Rename from
8377         coff_symfile_info.  Add initializers.
8378         (xcoff_objfile_data_key): Move lower.  Change type.
8379         (XCOFF_DATA): Rewrite.
8380         (xcoff_free_info): Remove.
8381         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
8382         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
8383         (xcoff_initial_scan): Update.
8384
8385 2019-05-08  Tom Tromey  <tom@tromey.com>
8386
8387         * solib-svr4.c (struct svr4_info): Add initializers and
8388         destructor.
8389         <probes_table>: Now an htab_up.
8390         (solib_svr4_pspace_data): Change type.
8391         (free_probes_table): Simplify.
8392         (~svr4_info): Rename from svr4_pspace_data_cleanup.
8393         (get_svr4_info, probes_table_htab_remove_objfile_probes)
8394         (probes_table_remove_objfile_probes, register_solib_event_probe)
8395         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
8396         (_initialize_svr4_solib): Update.
8397
8398 2019-05-08  Tom Tromey  <tom@tromey.com>
8399
8400         * remote.c (remote_pspace_data): Change type.
8401         (remote_pspace_data_cleanup): Remove.
8402         (get_remote_exec_file, set_pspace_remote_exec_file)
8403         (_initialize_remote): Update.
8404
8405 2019-05-08  Tom Tromey  <tom@tromey.com>
8406
8407         * breakpoint.c (breakpoint_objfile_key): Change type.
8408         (get_breakpoint_objfile_data): Update.
8409         (free_breakpoint_objfile_data): Remove.
8410         (_initialize_breakpoint): Update.
8411
8412 2019-05-08  Tom Tromey  <tom@tromey.com>
8413
8414         * linux-tdep.c (struct linux_info): Add initializers.
8415         (linux_inferior_data): Move.  Change type.
8416         (invalidate_linux_cache_inf): Update.
8417         (linux_inferior_data_cleanup): Remove.
8418         (get_linux_inferior_data, _initialize_linux_tdep): Update.
8419
8420 2019-05-08  Tom Tromey  <tom@tromey.com>
8421
8422         * auxv.c (auxv_inferior_data): Move.  Change type.
8423         (auxv_inferior_data_cleanup): Remove.
8424         (invalidate_auxv_cache_inf): Rewrite.
8425         (get_auxv_inferior_data, _initialize_auxv): Update.
8426
8427 2019-05-08  Tom Tromey  <tom@tromey.com>
8428
8429         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
8430         (symfile_debug_objfile_data_key): Change type.
8431         (symfile_debug_installed, debug_qf_has_symbols)
8432         (debug_qf_find_last_source_symtab)
8433         (debug_qf_forget_cached_source_info)
8434         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
8435         (debug_qf_print_stats, debug_qf_dump)
8436         (debug_qf_expand_symtabs_for_function)
8437         (debug_qf_expand_all_symtabs)
8438         (debug_qf_expand_symtabs_with_fullname)
8439         (debug_qf_map_matching_symbols)
8440         (debug_qf_expand_symtabs_matching)
8441         (debug_qf_find_pc_sect_compunit_symtab)
8442         (debug_qf_map_symbol_filenames)
8443         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
8444         (debug_sym_new_init, debug_sym_init, debug_sym_read)
8445         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
8446         (debug_sym_read_linetable, debug_sym_relocate): Update.
8447         (symfile_debug_free_objfile): Remove.
8448         (install_symfile_debug_logging, _initialize_symfile_debug):
8449         Update.
8450
8451 2019-05-08  Tom Tromey  <tom@tromey.com>
8452
8453         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
8454         allocate_on_obstack.
8455         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
8456         (get_dwarf2_per_objfile): Update.
8457         (set_dwarf2_per_objfile): Remove.
8458         (dwarf2_has_info, dwarf2_get_section_info): Update.
8459         (dwarf2_free_objfile): Remove.
8460         (_initialize_dwarf2_read): Update.
8461
8462 2019-05-08  Tom Tromey  <tom@tromey.com>
8463
8464         * auto-load.c (struct auto_load_pspace_info): Add destructor and
8465         initializers.
8466         <unsupported_script_warning_printed,
8467         script_not_found_warning_printed>: Now bool.
8468         (auto_load_pspace_data): Change type.
8469         (~auto_load_pspace_info): Rename from
8470         auto_load_pspace_data_cleanup.
8471         (get_auto_load_pspace_data, init_loaded_scripts_info)
8472         (clear_section_scripts, maybe_print_unsupported_script_warning)
8473         (maybe_print_script_not_found_warning, _initialize_auto_load):
8474         Update.
8475
8476 2019-05-08  Tom Tromey  <tom@tromey.com>
8477
8478         * objfiles.c (objfile_pspace_info): Add destructor and
8479         initializers.
8480         (objfiles_pspace_data): Change type.
8481         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
8482         (get_objfile_pspace_data): Update.
8483         (objfiles_bfd_data): Change type.
8484         (get_objfile_bfd_data): Update.
8485         (objfile_bfd_data_free, _initialize_objfiles): Remove.
8486
8487 2019-05-08  Tom Tromey  <tom@tromey.com>
8488
8489         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
8490         Change type.
8491         (get_catch_syscall_inferior_data): Update.
8492         (catch_syscall_inferior_data_cleanup): Remove.
8493         (_initialize_break_catch_syscall): Update.
8494
8495 2019-05-08  Tom Tromey  <tom@tromey.com>
8496
8497         * inflow.c (struct terminal_info): Add destructor and
8498         initializers.
8499         (inflow_inferior_data): Change type.
8500         (~terminal_info): Rename from inflow_inferior_data_cleanup.
8501         (get_inflow_inferior_data, inflow_inferior_exit)
8502         (swap_terminal_info, _initialize_inflow): Update.
8503
8504 2019-05-08  Tom Tromey  <tom@tromey.com>
8505
8506         * target-dcache.c (target_dcache_cleanup): Remove.
8507         (target_dcache_aspace_key): Change type.
8508         (target_dcache_init_p, target_dcache_invalidate)
8509         (target_dcache_get, target_dcache_get_or_init)
8510         (_initialize_target_dcache): Update.
8511         * dcache.h (struct dcache_deleter): New.
8512
8513 2019-05-08  Tom Tromey  <tom@tromey.com>
8514
8515         * symtab.c (struct symbol_cache): Add destructor and
8516         initializers.
8517         (symbol_cache_key): Move.  Change type.
8518         (make_symbol_cache, free_symbol_cache): Remove.
8519         (get_symbol_cache): Update.
8520         (symbol_cache_cleanup): Remove.
8521         (ALL_PSPACES, symbol_cache_flush)
8522         (maintenance_print_symbol_cache)
8523         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
8524         Update.
8525
8526 2019-05-08  Tom Tromey  <tom@tromey.com>
8527
8528         * symtab.c (struct main_info): Add destructor and initializers.
8529         (main_progspace_key): Move.  Change type.
8530         (get_main_info): Update.
8531         (main_info_cleanup): Remove.
8532         (_initialize_symtab): Update.
8533
8534 2019-05-08  Tom Tromey  <tom@tromey.com>
8535
8536         * registry.h (DECLARE_REGISTRY): Define the _key class.
8537
8538 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
8539
8540         * NEWS: Merge two 'New commands' sections.
8541
8542 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
8543
8544         * ada-valprint.c (ada_val_print_gnat_array): Remove language
8545         parameter and use Ada language definition instead.
8546         (ada_val_print_ptr): Remove unused language parameter.
8547         (ada_val_print_num): Remove language parameter and use Ada language
8548         definition instead.
8549         (ada_val_print_enum, ada_val_print_flt): Remove unused language
8550         parameter.
8551         (ada_val_print_struct_union, ada_val_print_ref): Remove language
8552         parameter and use Ada language definition instead.
8553         (ada_val_print_1): Update all ada_val_print_xxx calls.
8554         Remove language parameter.
8555         (ada_val_print): Update ada_val_print_1 call.
8556
8557 2019-05-08  Tom Tromey  <tromey@adacore.com>
8558
8559         * remote.c (remote_hw_watchpoint_limit)
8560         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
8561         Now static.
8562
8563 2019-05-08  Tom Tromey  <tromey@adacore.com>
8564
8565         * maint.c (_initialize_maint_cmds): Move initialization code to
8566         remote.c.
8567         (watchdog, show_watchdog): Move to remote.c.
8568         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
8569         "watchdog" static.
8570         (_initialize_remote): Move initialization code from maint.c.
8571         * defs.h (watchdog): Don't declare.
8572
8573 2019-05-08  Tom Tromey  <tromey@adacore.com>
8574
8575         * tui/tui-interp.c: Include main.h.
8576         * interps.c: Include main.h.
8577         * main.h (interpreter_p): Declare.
8578         * defs.h (interpreter_p): Don't declare.
8579
8580 2019-05-08  Tom Tromey  <tromey@adacore.com>
8581
8582         * dwarf2loc.c: Include dwarf2read.h.
8583         * defs.h (read_unsigned_leb128): Don't declare.
8584         * dwarf2read.h (read_unsigned_leb128): Declare.
8585
8586 2019-05-08  Tom Tromey  <tromey@adacore.com>
8587
8588         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
8589         method.
8590
8591 2019-05-08  Tom Tromey  <tromey@adacore.com>
8592
8593         * utils.c (fputs_maybe_filtered): Reset style after paging, even
8594         when no wrap column is set.
8595
8596 2019-05-08  Tom Tromey  <tromey@adacore.com>
8597
8598         * c-lang.c (c_get_string): Handle non-C-style arrays.
8599
8600 2019-05-08  Tom Tromey  <tromey@adacore.com>
8601
8602         * typeprint.c (print_offset_data::update): Print the bit offset,
8603         not the number of bits remaining.
8604
8605 2019-05-08  Tom Tromey  <tromey@adacore.com>
8606
8607         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
8608         padding at end of comment.
8609
8610 2019-05-08  Tom Tromey  <tromey@adacore.com>
8611
8612         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
8613         Compare main types.
8614
8615 2019-05-06  Tom Tromey  <tom@tromey.com>
8616
8617         * common/scoped_mmap.c: Include common-defs.h.
8618         * common/scoped_mmap.h: Don't include config.h.
8619
8620 2019-05-04  Tom Tromey  <tom@tromey.com>
8621
8622         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
8623         (struct aarch64_call_info): Add initializers.
8624         <si>: Now a std::vector.
8625         (pass_on_stack, aarch64_push_dummy_call): Update.
8626
8627 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
8628             Tom Tromey  <tom@tromey.com>
8629
8630         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
8631         (ppc_threads): Now a std::vector.  Now static.
8632         (hwdebug_find_thread_points_by_tid)
8633         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
8634         Update.
8635
8636 2019-05-04  Tom Tromey  <tom@tromey.com>
8637
8638         * arc-tdep.c (arc_tdesc_init): Return bool.
8639
8640 2019-05-04  Tom Tromey  <tom@tromey.com>
8641
8642         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
8643         Use gdb_assert_not_reached.
8644
8645 2019-05-04  Tom Tromey  <tom@tromey.com>
8646
8647         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
8648         "false".
8649
8650 2019-05-04  Tom Tromey  <tom@tromey.com>
8651
8652         * arc-tdep.c (arc_tdesc_init): Use bool.
8653
8654 2019-05-04  Tom Tromey  <tom@tromey.com>
8655
8656         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
8657
8658 2019-05-04  Tom Tromey  <tom@tromey.com>
8659
8660         * cli/cli-cmds.c (valid_command_p): Return bool.
8661
8662 2019-05-04  Tom Tromey  <tom@tromey.com>
8663
8664         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
8665         * command.h (valid_user_defined_cmd_name_p): Channge return type.
8666
8667 2019-05-04  Raul Tambre  <raul@tambre.ee>
8668
8669         * python/lib/gdb/prompt.py (_ExtendedPrompt)
8670         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
8671         operator for comparison.
8672
8673 2019-05-04  Tom Tromey  <tom@tromey.com>
8674
8675         * psymtab.c (psymbol_name_matches, match_partial_symbol)
8676         (lookup_partial_symbol, print_partial_symbols)
8677         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
8678         (psymbol_compare): Update.
8679         (add_psymbol_to_bcache): Clear the entire psymbol.
8680         (maintenance_check_psymtabs): Update.
8681         * psympriv.h (struct partial_symbol): Don't derive from
8682         general_symbol_info.
8683         <obj_section, unrelocated_address, address,
8684         set_unrelocated_address>: Update.
8685         <ginfo>: New member.
8686         * dwarf-index-write.c (write_psymbols, debug_names::insert)
8687         (debug_names::write_psymbols): Update.
8688
8689 2019-05-04  Tom de Vries  <tdevries@suse.de>
8690
8691         * contrib/cc-with-tweaks.sh: Support -n arg.
8692
8693 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8694
8695         * corelow.c (core_target::detach): Ensure frame cache and
8696         register caches are cleared.
8697         inferior.c (exit_inferior_1): Likewise.
8698
8699 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
8700             Tom Tromey  <tom@tromey.com>
8701
8702         * dictionary.c (collate_pending_symbols_by_language): Remove
8703         "struct" from foreach.
8704         * symtab.c (lookup_global_symbol_from_objfile)
8705         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
8706         foreach.
8707         * ser-tcp.c (net_open): Remove "struct" from foreach.
8708         * objfiles.c (objfile_relocate, objfile_rebase)
8709         (objfile_has_symbols): Remove "struct" from foreach.
8710         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
8711         from foreach.
8712         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
8713         foreach.
8714         * darwin-nat.c (thread_info_from_private_thread_info): Remove
8715         "struct" from foreach.
8716         * ada-lang.c (create_excep_cond_exprs)
8717         (ada_exception_catchpoint_cond_string): Remove "struct" from
8718         foreach.
8719
8720 2019-05-03  Tom Tromey  <tromey@adacore.com>
8721
8722         * ada-exp.y (convert_char_literal): Check suffix of each
8723         enumerator.
8724
8725 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
8726
8727         PR ada/21406:
8728         * ada-exp.y (yywrap): Don't define.
8729         * ada-lex.l (%option): Add noyywrap
8730         (yywrap): Remove.
8731
8732 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
8733
8734         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
8735         _WIN32_WINNT to the XP level, unless already defined to a higher
8736         level.
8737
8738         * unittests/parse-connection-spec-selftests.c:
8739         * ser-tcp.c:
8740         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
8741         override.
8742
8743         * symfile.c (find_separate_debug_file): Remove colon from the
8744         drive spec of DOS/Windows file names of the target, so that the
8745         file name produced from DEBUGDIR and the target's directory will
8746         be valid on DOS/Windows systems.
8747
8748 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
8749
8750         * rust-lang.c (val_print_struct): Handle printing structures
8751         containing strings.
8752
8753 2019-05-02  Tom Tromey  <tromey@adacore.com>
8754
8755         * valarith.c (_initialize_valarith): Remove.
8756
8757 2019-05-01  Tom Tromey  <tromey@adacore.com>
8758
8759         * ada-lang.c (ada_value_primitive_field): Treat more fields as
8760         bitfields.
8761
8762 2019-05-01  Tom Tromey  <tromey@adacore.com>
8763
8764         * ada-lang.c (ada_value_assign): Correctly compute starting offset
8765         for big-endian copies.
8766
8767 2019-04-30  Ali Tamur  <tamur@google.com>
8768         * gdb/dwarf2read.c (read_3_bytes): New declaration.
8769         (read_attribute_value): Added DW_FORM_strx1-4 cases.
8770         (read_3_bytes): New function.
8771
8772 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
8773
8774         * windows-nat.c (main_thread_id): Delete.
8775         (handle_output_debug_string): Replace main_thread_id by
8776         current_event.dwThreadId.
8777         (fake_create_process): Likewise.
8778         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
8779         Do not set main_thread_id.
8780         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
8781         current_event.dwThreadId.
8782         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
8783
8784 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
8785
8786         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
8787         Use current_event.dwThreadId instead of main_thread_id.
8788
8789 2019-04-30  Tom Tromey  <tromey@adacore.com>
8790
8791         * ada-lang.c (ada_lookup_simple_minsyms): New function.
8792         (create_excep_cond_exprs): Iterate over program spaces.
8793         (ada_exception_catchpoint_cond_string): Examine all minimal
8794         symbols for exception types.
8795
8796 2019-04-30  Tom Tromey  <tromey@adacore.com>
8797
8798         PR c++/24470:
8799         * dwarf2read.c (process_structure_scope): Handle case where type
8800         has template parameters but no symbol was created.
8801
8802 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8803             Chris January  <chris.january@arm.com>
8804
8805         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
8806         qualifier.
8807         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
8808
8809 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8810
8811         * f-typeprint.c (f_print_type): Update rules for printing
8812         whitespace.
8813         (f_type_print_varspec_suffix): Likewise.
8814
8815 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8816             Chris January  <chris.january@arm.com>
8817
8818         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
8819         function arguments.
8820
8821 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8822
8823         * f-lang.c (build_fortran_types): Change name of void type to
8824         lower case.
8825         * f-typeprint.c (f_type_print_base): Print the name of the void
8826         type, rather than a fixed string.
8827         * f-valprint.c (f_decorations): Use lower case void string.
8828
8829 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8830             Chris January  <chris.january@arm.com>
8831
8832         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
8833         types for Fortran.
8834
8835 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8836             Chris January  <chris.january@arm.com>
8837             David Lecomber  <david.lecomber@arm.com>
8838
8839         * f-exp.y (BINOP_INTRINSIC): New token.
8840         (exp): New parser rule handling BINOP_INTRINSIC.
8841         (f77_keywords): Add new builtin procedures.
8842         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
8843         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
8844         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
8845         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
8846         (print_unop_subexp_f): New function.
8847         (print_binop_subexp_f): New function.
8848         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
8849         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
8850         (dump_subexp_body_f): Likewise.
8851         (operator_check_f): Likewise.
8852         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
8853         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
8854
8855 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8856
8857         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
8858         UNOP_KIND.
8859         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
8860         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
8861         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
8862         (operator_length_f): New fuction.
8863         (print_subexp_f): New function.
8864         (op_name_f): New function.
8865         (dump_subexp_body_f): New function.
8866         (operator_check_f): New function.
8867         (exp_descriptor_f): Replace standard expression handling functions
8868         with new functions.
8869         * gdb/fortran-operator.def: New file.
8870         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
8871         * gdb/std-operator.def: Remove UNOP_KIND.
8872
8873 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8874
8875         * std-operator.def: Remove unbalanced, stray double quote
8876         character.
8877
8878 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
8879             Chris January  <chris.january@arm.com>
8880             Daniel Everett  <daniel.everett@arm.com>
8881             Nick Forrington  <nick.forrington@arm.com>
8882             Richard Bunt  <richard.bunt@arm.com>
8883
8884         * cp-valprint.c (cp_print_value_fields): Allow an additional level
8885         of depth when printing anonymous structs or unions.
8886         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
8887         Don't print either the top-level value, or the children if the
8888         max-depth is exceeded.
8889         (ppscm_print_children): When printing the key of a map, allow one
8890         extra level of depth.
8891         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
8892         print either the top-level value, or the children if the max-depth
8893         is exceeded.
8894         (print_children): When printing the key of a map, allow one extra
8895         level of depth.
8896         * python/py-value.c (valpy_format_string): Add max_depth keyword.
8897         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
8898         (user_print_options): Initialise max_depth field.
8899         (val_print_scalar_or_string_type_p): New function.
8900         (val_print): Check to see if the max depth has been reached.
8901         (val_print_check_max_depth): Define new function.
8902         (show_print_max_depth): New function.
8903         (_initialize_valprint): Add 'print max-depth' option.
8904         * valprint.h (struct value_print_options) <max_depth>: New field.
8905         (val_print_check_max_depth): Declare new function.
8906         * NEWS: Document new feature.
8907
8908 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
8909
8910         * ada-lang.c (ada_language_defn): Initialise new field.
8911         * c-lang.c (c_is_string_type_p): New function.
8912         (c_language_defn): Initialise new field.
8913         (cplus_language_defn): Initialise new field.
8914         (asm_language_defn): Initialise new field.
8915         (minimal_language_defn): Initialise new field.
8916         * c-lang.h (c_is_string_type_p): Declare new function.
8917         * d-lang.c (d_language_defn): Initialise new field.
8918         * f-lang.c (f_is_string_type_p): New function.
8919         (f_language_defn): Initialise new field.
8920         * go-lang.c (go_is_string_type_p): New function.
8921         (go_language_defn): Initialise new field.
8922         * language.c (default_is_string_type_p): New function.
8923         (unknown_language_defn): Initialise new field.
8924         (auto_language_defn): Initialise new field.
8925         * language.h (struct language_defn) <la_is_string_type_p>: New
8926         member variable.
8927         (default_is_string_type_p): Declare new function.
8928         * m2-lang.c (m2_language_defn): Initialise new field.
8929         * objc-lang.c (objc_language_defn): Initialise new field.
8930         * opencl-lang.c (opencl_language_defn): Initialise new field.
8931         * p-lang.c (pascal_is_string_type_p): New function.
8932         (pascal_language_defn): Initialise new field.
8933         * rust-lang.c (rust_is_string_type_p): New function.
8934         (rust_language_defn): Initialise new field.
8935
8936 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
8937
8938         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
8939         New field.
8940         * ada-lang.c (ada_language_defn): Initialise new field.
8941         * c-lang.c (c_language_defn): Likewise.
8942         (cplus_language_defn): Likewise.
8943         (asm_language_defn): Likewise.
8944         (minimal_language_defn): Likewise.
8945         * d-lang.c (d_language_defn): Likewise.
8946         * f-lang.c (f_language_defn): Likewise.
8947         * go-lang.c (go_language_defn): Likewise.
8948         * language.c (unknown_language_defn): Likewise.
8949         (auto_language_defn): Likewise.
8950         * m2-lang.c (m2_language_defn): Likewise.
8951         * objc-lang.c (objc_language_defn): Likewise.
8952         * opencl-lang.c (opencl_language_defn): Likewise.
8953         * p-lang.c (pascal_language_defn): Likewise.
8954         * rust-lang.c (rust_language_defn): Likewise.
8955
8956 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
8957
8958         * ada-lang.c (ada_is_character_type): Change return type to bool.
8959         (ada_is_string_type): Likewise.
8960         * ada-lang.h (ada_is_character_type): Update declaration
8961         (ada_is_string_type): Likewise.
8962
8963 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8964
8965         Support style in 'frame|thread apply'
8966
8967         * gdbcmd.h (execute_command_to_string): New term_out parameter.
8968         * record.c (record_start, record_stop): Update callers of
8969         execute_command_to_string with false.
8970         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
8971         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
8972         methods.
8973         (class string_file): New constructor with term_out parameter.
8974         Override methods term_out and can_emit_style_escape.  New member
8975         term_out.
8976         (class stdio_file): Override can_emit_style_escape.
8977         (class tee_file): Override term_out and can_emit_style_escape.
8978         * utils.h (can_emit_style_escape): Remove.
8979         * utils.c (can_emit_style_escape): Likewise.
8980         Update all callers of can_emit_style_escape (SOMESTREAM) to
8981         SOMESTREAM->can_emit_style_escape.
8982         * source-cache.c (source_cache::get_source_lines): Likewise.
8983         * stack.c (frame_apply_command_count): Call execute_command_to_string
8984         passing the term_out characteristic of the current gdb_stdout.
8985         * thread.c (thr_try_catch_cmd): Likewise.
8986         * top.c (execute_command_to_string): pass term_out parameter
8987         to construct the string_file for the command output.
8988         * ui-file.c (term_cli_styling): New function (most code moved
8989         from utils.c can_emit_style_escape).
8990         (string_file::string_file, string_file::can_emit_style_escape,
8991         stdio_file::can_emit_style_escape, tee_file::term_out,
8992         tee_file::can_emit_style_escape): New functions.
8993
8994 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8995
8996         * NEWS: Mention the new set|show may-call-functions.
8997         * infcall.c (may_call_functions_p): New variable.
8998         (show_may_call_functions_p): New function.
8999         (call_function_by_hand_dummy): Throws an error if not
9000         may-call-functions.
9001         (_initialize_infcall): Call add_setshow_boolean_cmd for
9002         may-call-functions.
9003
9004 2019-04-25  Keith Seitz  <keiths@redhat.com>
9005
9006         PR c++/24367
9007         * cp-support.c (inspect_type): Don't attempt substitutions
9008         of symbol with the same name.
9009
9010 2019-04-25  Tom Tromey  <tromey@adacore.com>
9011
9012         PR gdb/24475:
9013         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
9014         static.
9015
9016 2019-04-25  Tom Tromey  <tromey@adacore.com>
9017
9018         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
9019         rvalue reference.
9020         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
9021         (gdb_xml_parser::parse): Use std::move.
9022         * python/python-internal.h (gdbpy_convert_exception): Take a const
9023         reference.
9024         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
9025         std::move.
9026         * python/py-utils.c (gdbpy_convert_exception): Take a const
9027         reference.
9028         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
9029         Use std::move.
9030         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
9031         Use std::move.
9032         * mi/mi-main.c (mi_print_exception): Take a const reference.
9033         * main.c (handle_command_errors): Take a const reference.
9034         * linespec.c (parse_linespec): Use std::move.
9035         * infcall.c (run_inferior_call): Use std::move.
9036         (call_function_by_hand_dummy): Use std::move.
9037         * exec.c (try_open_exec_file): Use std::move.
9038         * exceptions.h (exception_print, exception_fprintf)
9039         (exception_print_same): Update.
9040         * exceptions.c (print_exception, exception_print)
9041         (exception_fprintf, exception_print_same): Change parameters to
9042         const reference.
9043         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
9044         * common/new-op.c: Use std::move.
9045         * common/common-exceptions.h (struct gdb_exception): Add move
9046         constructor.
9047         (struct gdb_exception_error, struct gdb_exception_quit, struct
9048         gdb_quit_bad_alloc): Change constructor to move constructor.
9049         (throw_exception): Change parameter to rvalue reference.
9050         * common/common-exceptions.c (throw_exception): Take rvalue
9051         reference.
9052         * cli/cli-interp.c (safe_execute_command): Use std::move.
9053         * breakpoint.c (insert_bp_location, location_to_sals): Use
9054         std::move.
9055
9056 2019-04-25  Tom Tromey  <tromey@adacore.com>
9057
9058         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
9059         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
9060         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
9061         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
9062         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
9063         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
9064         guile/scm-value.c: Use unpack.
9065         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
9066         gdbscm_gdb_exception.
9067         (gdbscm_throw_gdb_exception): Likewise.
9068         (struct gdbscm_gdb_exception): New.
9069         (unpack): New function.
9070         (gdbscm_wrap): Use unpack.
9071
9072 2019-04-25  Tom Tromey  <tromey@adacore.com>
9073
9074         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
9075         (gdb_rl_callback_handler): Use std::move.
9076         * common/common-exceptions.h (struct gdb_exception): Add move
9077         assignment operator.
9078         (throw_exception_sjlj): Change "exception" to const reference.
9079         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
9080         (throw_exception_sjlj): Change "exception" to const reference.
9081
9082 2019-04-25  Tom Tromey  <tromey@adacore.com>
9083
9084         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
9085         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
9086         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
9087         Update.
9088         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
9089         Update.
9090         * mi/mi-interp.c (mi_interp::exec): Update.
9091         * linespec.c (parse_linespec): Update.
9092         * infcall.c (run_inferior_call): Update.
9093         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
9094         * guile/scm-symbol.c (gdbscm_lookup_symbol)
9095         (gdbscm_lookup_global_symbol): Update.
9096         * guile/scm-param.c (gdbscm_parameter_value): Update.
9097         * guile/scm-frame.c (gdbscm_frame_read_register)
9098         (gdbscm_frame_read_var): Update.
9099         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
9100         * exec.c (try_open_exec_file): Update.
9101         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
9102         (gdb_rl_callback_handler): Update.
9103         * common/common-exceptions.h (exception_none): Don't declare.
9104         * common/common-exceptions.c (exception_none): Don't define.
9105         (struct catcher) <exception>: Update.
9106         * cli/cli-interp.c (safe_execute_command): Update.
9107         * breakpoint.c (insert_bp_location, location_to_sals): Update.
9108
9109 2019-04-25  Ali Tamur  <tamur@google.com>
9110
9111         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
9112         (read_attribute_value): Likewise.
9113         (dwarf2_read_addr_index): Update comment.
9114         (read_str_index): Add DW_FORM_strx.
9115         (dwarf2_string_attr): Likewise.
9116         (dwarf2_const_value_attr): Likewise.
9117         (dump_die_shallow): Likewise.
9118         (dwarf2_fetch_constant_bytes): Likewise.
9119         (skip_form_bytes): Likewise.
9120         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
9121
9122 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
9123
9124         PR corefiles/11608
9125         PR corefiles/18187
9126         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
9127         OFFSET.  Verify if current mapping contains an ELF header.
9128         (linux_find_memory_regions_full): Adjust call to
9129         dump_mapping_p.
9130
9131 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
9132             Kang Li <kanglictf@gmail.com>
9133
9134         PR gdb/21600
9135
9136         * dwarf2-frame.c (read_initial_length): Be consistent about using
9137         unsigned representation of length.
9138         (decode_frame_entry_1): Likewise.  Check for wraparound of
9139         end pointer as well as buffer overflow.
9140
9141 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
9142
9143         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
9144         "vq".
9145
9146 2019-04-24  Tom Tromey  <tromey@adacore.com>
9147
9148         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
9149
9150 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9151
9152         * s12z-tdep.c (s12z_unwind_pc): Delete.
9153         (s12z_unwind_sp): Delete.
9154         (s12z_gdbarch_init): Don't register deleted functions with
9155         gdbarch.
9156
9157 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9158
9159         * rl78-tdep.c (rl78_unwind_sp): Delete.
9160         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
9161
9162 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9163
9164         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
9165         (xstormy16_unwind_pc): Delete.
9166         (xstormy16_dummy_id): Delete.
9167         (xstormy16_gdbarch_init): Don't register deleted functions with
9168         gdbarch.
9169
9170 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9171
9172         * vax-tdep.c (vax_unwind_pc): Delete.
9173         (vax_gdbarch_init): Don't register deleted function with gdbarch.
9174
9175 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9176
9177         * v850-tdep.c (v850_unwind_sp): Delete.
9178         (v850_unwind_pc): Delete.
9179         (v850_dummy_id): Delete.
9180         (v850_gdbarch_init): Don't register deleted functions with
9181         gdbarch.
9182
9183 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9184
9185         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
9186         (tilegx_unwind_pc): Delete.
9187         (tilegx_unwind_dummy_id): Delete.
9188         (tilegx_gdbarch_init): Don't register deleted functions with
9189         gdbarch.
9190
9191 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9192
9193         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
9194         (tic6x_dummy_id): Delete.
9195         (tic6x_gdbarch_init): Don't register deleted functions with
9196         gdbarch.
9197
9198 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9199
9200         * sparc-tdep.c (sparc_unwind_pc): Delete.
9201         (sparc32_gdbarch_init): Don't register deleted function with
9202         gdbarch.
9203
9204 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9205
9206         * sh-tdep.c (sh_unwind_sp): Delete.
9207         (sh_unwind_pc): Delete.
9208         (sh_dummy_id): Delete.
9209         (sh_gdbarch_init): Don't register deleted functions with
9210         gdbarch.
9211
9212 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9213
9214         * score-tdep.c (score_unwind_sp): Delete.
9215         (score_unwind_pc): Delete.
9216         (score_dummy_id): Delete.
9217         (score_gdbarch_init): Don't register deleted functions with
9218         gdbarch.
9219
9220 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9221
9222         * rx-tdep.c (rx_unwind_pc): Delete.
9223         (rx_unwind_sp): Delete.
9224         (rx_dummy_id): Delete.
9225         (rx_gdbarch_init): Don't register deleted functions with
9226         gdbarch.  Update comment.
9227
9228 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9229
9230         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
9231         (rs6000_dummy_id): Delete.
9232         (rs6000_gdbarch_init): Don't register deleted functions with
9233         gdbarch.
9234
9235 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9236
9237         * or1k-tdep.c (or1k_dummy_id): Delete.
9238         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
9239
9240 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9241
9242         * nios2-tdep.c (nios2_dummy_id): Delete.
9243         (nios2_unwind_sp): Delete.
9244         (nios2_gdbarch_init): Don't register deleted functions with
9245         gdbarch.
9246
9247 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9248
9249         * nds32-tdep.c (nds32_dummy_id): Delete.
9250         (nds32_unwind_pc): Delete.
9251         (nds32_unwind_sp): Delete.
9252         (nds32_gdbarch_init): Don't register deleted functions with
9253         gdbarch.
9254
9255 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9256
9257         * msp430-tdep.c (msp430_unwind_pc): Delete.
9258         (msp430_unwind_sp): Delete.
9259         (msp430_dummy_id): Delete.
9260         (msp430_gdbarch_init): Don't register deleted functions with
9261         gdbarch.
9262
9263 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9264
9265         * moxie-tdep.c (moxie_unwind_sp): Delete.
9266         (moxie_unwind_pc): Delete.
9267         (moxie_dummy_id): Delete.
9268         (moxie_gdbarch_init): Don't register deleted functions with
9269         gdbarch.
9270
9271 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9272
9273         * mn10300-tdep.c (mn10300_dummy_id): Delete.
9274         (mn10300_unwind_pc): Delete.
9275         (mn10300_unwind_sp): Delete.
9276         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
9277         mn10300_unwind_sp.
9278         (mn10300_frame_unwind_init): Don't register deleted functions with
9279         gdbarch.
9280
9281 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9282
9283         * mep-tdep.c (mep_unwind_pc): Delete.
9284         (mep_unwind_sp): Delete.
9285         (mep_dummy_id): Delete.
9286         (mep_gdbarch_init): Don't register deleted functions with
9287         gdbarch.
9288
9289 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9290
9291         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
9292         (m68hc11_unwind_sp): Delete.
9293         (m68hc11_gdbarch_init): Don't register deleted functions with
9294         gdbarch.
9295
9296 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9297
9298         * m32r-tdep.c (m32r_unwind_sp): Delete.
9299         (m32r_unwind_pc): Delete.
9300         (m32r_dummy_id): Delete.
9301         (m32r_gdbarch_init): Don't register deleted functions with
9302         gdbarch.
9303
9304 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9305
9306         * m32c-tdep.c (m32c_unwind_pc): Delete.
9307         (m32c_unwind_sp): Delete.
9308         (m32c_dummy_id): Delete.
9309         (m32c_gdbarch_init): Don't register deleted functions with
9310         gdbarch.
9311
9312 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9313
9314         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
9315         (lm32_unwind_pc): Delete.
9316         (lm32_dummy_id): Delete.
9317         (lm32_gdbarch_init): Don't register deleted functions with
9318         gdbarch.
9319
9320 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9321
9322         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
9323         (iq2000_unwind_pc): Delete.
9324         (iq2000_dummy_id): Delete.
9325         (iq2000_gdbarch_init): Don't register deleted functions with
9326         gdbarch.
9327
9328 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9329
9330         * nds32-tdep.c (nds32_type_align): Delete.
9331         (nds32_push_dummy_call): Use type_align instead.
9332
9333 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9334
9335         * arm-tdep.c (arm_type_align): Only handle vector override case.
9336         (arm_push_dummy_call): Use type_align.
9337         (arm_gdbarch_init): Register arm_type_align gdbarch function.
9338
9339 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9340
9341         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
9342         case.
9343         (pass_on_stack): Use type_align.
9344         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
9345         function.
9346
9347 2019-04-23  Tom Tromey  <tromey@adacore.com>
9348
9349         * dwarf2read.c (line_header::file_name_at): Remove unused
9350         overload.
9351
9352 2019-04-23  Tom de Vries  <tdevries@suse.de>
9353
9354         PR gdb/24438
9355         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
9356         invocation.
9357
9358
9359 2019-03-27  Ali Tamur  <tamur@google.com>
9360
9361         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
9362         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
9363         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
9364         (dwarf_expr_context::get_addr_index): Likewise
9365         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
9366         (symbol_needs_eval_context::get_addr_index): Likewise
9367         (disassemble_dwarf_expression): Add DW_OP_addrx
9368         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
9369         (read_cutu_die_from_dwo): Update comment
9370         (skip_one_die): Add DW_FORM_addrx
9371         (read_attribute_value): Likewise
9372         (var_decode_location): Add DW_OP_addrx
9373         (dwarf2_const_value_attr): Add DW_FORM_addrx
9374         (dump_die_shallow): Likewise
9375         (dwarf2_fetch_constant_bytes): Likewise
9376         (decode_locdesc): Add DW_OP_addrx
9377         (skip_form_bytes): Add DW_FORM_addrx
9378
9379 2019-04-22  Ali Tamur  <tamur@google.com>
9380
9381         * MAINTAINERS (Write After Approval): Add self.
9382
9383 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
9384
9385         * solib-svr4.c (get_svr4_info): Add pspace parameter.
9386         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
9387         (open_symbol_file_object): Likewise.
9388         (svr4_default_sos): Add info parameter.
9389         (svr4_read_so_list): Likewise.
9390         (svr4_current_sos_direct): Adjust functions calls to pass down
9391         info.
9392         (svr4_current_sos_1): Add info parameter.
9393         (svr4_current_sos): Call get_svr4_info, pass info down to
9394         svr4_current_sos_1.
9395         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
9396         get_svr4_info.
9397         (svr4_in_dynsym_resolve_code): Pass current_program_space to
9398         get_svr4_info.
9399         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
9400         to get_svr4_info.
9401         (probes_table_remove_objfile_probes): Likewise.
9402         (register_solib_event_probe): Add info parameter.
9403         (solist_update_incremental): Pass info parameter down to
9404         svr4_read_so_list.
9405         (disable_probes_interface): Add info parameter.
9406         (svr4_handle_solib_event): Pass current_program_space to
9407         get_svr4_info.  Adjust disable_probes_interface cleanup.
9408         (svr4_create_probe_breakpoints): Add info parameter, pass it
9409         down to register_solib_event_probe.
9410         (svr4_create_solib_event_breakpoints): Add info parameter,
9411         pass it down to svr4_create_probe_breakpoints.
9412         (enable_break): Pass info down to
9413         svr4_create_solib_event_breakpoints.
9414         (svr4_solib_create_inferior_hook): Pass current_program_space to
9415         get_svr4_info.
9416         (svr4_clear_solib): Likewise.
9417
9418 2019-04-22  Pedro Alves  <palves@redhat.com>
9419
9420         * solib-svr4.c (svr4_free_objfile_observer): New.
9421         (probe_and_action::objfile): New field.
9422         (probes_table_htab_remove_objfile_probes)
9423         (probes_table_remove_objfile_probes): New functions.
9424         (register_solib_event_probe): Add 'objfile' parameter.  Store it
9425         in the new probe_and_action.  Don't store the probe in 'lookup'.
9426         (svr4_create_probe_breakpoints): Pass objfile to
9427         register_solib_event_probe.
9428         (_initialize_svr4_solib): Register a free_objfile observer.
9429
9430 2019-04-19  Tom Tromey  <tom@tromey.com>
9431
9432         * common/queue.h: Remove.
9433
9434 2019-04-19  Tom Tromey  <tom@tromey.com>
9435
9436         * event-loop.c: Don't include "common/queue.h".
9437
9438 2019-04-19  Tom Tromey  <tom@tromey.com>
9439
9440         * remote.c (remote_target): Use delete.
9441         * remote-notif.h: Include <list>, not "common/queue.h".
9442         (notif_client_p): Remove typedef.
9443         (remote_notif_state): Add constructor, destructor, initializer.
9444         <notif_queue>: Now a std::list.
9445         (remote_notif_state_xfree): Don't declare.
9446         * remote-notif.c (remote_notif_process, handle_notification)
9447         (remote_notif_state_allocate): Update.
9448         (~remote_notif_state): Rename from remote_notif_state_xfree.
9449
9450 2019-04-19  Tom Tromey  <tom@tromey.com>
9451
9452         * symfile.c (reread_symbols): Update.
9453         * objfiles.c (objfile_register_static_link)
9454         (objfile_lookup_static_link): Update
9455         (~objfile) Don't delete static_links.
9456         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
9457
9458 2019-04-19  Tom Tromey  <tom@tromey.com>
9459
9460         * type-stack.h (struct type_stack) <insert>: Constify string.
9461         * type-stack.c (type_stack::insert): Constify string.
9462         * gdbtypes.h (lookup_template_type): Update.
9463         (address_space_name_to_int): Update.
9464         * gdbtypes.c (address_space_name_to_int): Make space_identifier
9465         const.
9466         (lookup_template_type): Make name const.
9467         * c-exp.y: Update rules.
9468         (lex_one_token, classify_name, classify_inner_name)
9469         (c_print_token): Update.
9470         * p-exp.y: Update rules.
9471         (yylex): Update.
9472         * f-exp.y: Update rules.
9473         (yylex): Update.
9474         * d-exp.y: Update rules.
9475         (lex_one_token, classify_name, classify_inner_name): Update.
9476         * parse.c (write_dollar_variable, copy_name): Return std::string.
9477         * parser-defs.h (copy_name): Change return type.
9478         * m2-exp.y: Update rules.
9479         (yylex): Update.
9480         * go-exp.y (lex_one_token): Update.
9481         Update rules.
9482         (classify_unsafe_function, classify_packaged_name)
9483         (classify_name, yylex): Update.
9484
9485 2019-04-19  Sergei Trofimovich <siarheit@google.com>
9486
9487         * configure.ac: add --enable-source-highlight switch.
9488         * configure: Regenerate.
9489         * top.c (print_gdb_version): plumb --enable-source-highlight
9490         status to "show configuration".
9491
9492 2019-04-19  Tom Tromey  <tromey@adacore.com>
9493
9494         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
9495         Check ADA_TYPE_P.
9496         (empty_record, ada_template_to_fixed_record_type_1)
9497         (template_to_static_fixed_type)
9498         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
9499         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
9500         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
9501         macros.
9502
9503 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
9504
9505         PR symtab/24423:
9506         * source.c (print_source_lines_base): Advance "iter" when a
9507         control character is seen.
9508
9509 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9510
9511         * inferior.h (struct infcall_suspend_state_deleter):
9512         Catch exception in destructor to avoid crash.
9513
9514 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9515
9516         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
9517         close to the add_com "shell".
9518
9519 2019-04-18  Tom Tromey  <tromey@adacore.com>
9520
9521         * process-stratum-target.h (class process_stratum_target)
9522         <stratum>: Add "final".
9523
9524 2019-04-17  Tom Tromey  <tromey@adacore.com>
9525
9526         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
9527         against nullptr before use.
9528
9529 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
9530
9531         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
9532
9533 2019-04-17  Jim Wilson  <jimw@sifive.com>
9534             Andrew Burgess  <andrew.burgess@embecosm.com>
9535
9536         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
9537         code read might fail, assume 4-byte breakpoint in that case.
9538
9539 2019-04-15  Leszek Swirski  <leszeks@google.com>
9540
9541         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
9542         rather than a hand-rolled POD check when checking for forced MEMORY
9543         classification.
9544
9545 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
9546
9547         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
9548         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
9549         function.
9550         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
9551         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
9552         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
9553         declaration.
9554
9555 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
9556
9557         * aarch64-linux-nat.c
9558         (aarch64_linux_nat_target::thread_architecture): Add override.
9559         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
9560         each VQ.
9561
9562 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
9563
9564         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
9565
9566 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
9567
9568         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
9569         target types of size 96-bits, add some additional comments, and
9570         check that the builtin type we found was the correct size.
9571
9572 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
9573
9574         * utils.c (prompt_for_continue): Don't restore the styling at the
9575         end, as applied_style has the wrong value.  This fixes styling in
9576         long lists of file names that are interrupted by the "Continue?"
9577         prompt.
9578
9579 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
9580
9581         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
9582         * c-lang.c (c_language_defn): Likewise.
9583         (cplus_language_defn): Likewise.
9584         (asm_language_defn): Likewise.
9585         (minimal_language_defn): Likewise.
9586         * d-lang.c (d_language_defn): Likewise.
9587         * f-lang.c (f_language_defn): Likewise.
9588         * go-lang.c (go_language_defn): Likewise.
9589         * language.c (unknown_language_defn): Likewise.
9590         (auto_language_defn): Likewise.
9591         * language.h (struct language_defn): Remove la_magic field.
9592         (LANG_MAGIC): Delete.
9593         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
9594         * objc-lang.c (objc_language_defn): Likewise.
9595         * opencl-lang.c (opencl_language_defn): Likewise.
9596         * p-lang.c (pascal_language_defn): Likewise.
9597         * rust-lang.c (rust_language_defn): Likewise.
9598
9599 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
9600
9601         * riscv-tdep.c (riscv_type_align): New function.
9602         (riscv_type_alignment): Delete.
9603         (riscv_arg_location): Use 'type_align'.
9604         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
9605
9606 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
9607
9608         * gdbtypes.c (type_align): A struct with no non-static fields also
9609         has alignment of 1.
9610
9611 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
9612
9613         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
9614         component to 0.
9615         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
9616         member.
9617         (riscv_struct_info::analyse): New implementation using new
9618         analyse_inner member function.
9619         (riscv_struct_info::field_offset): New member function.
9620         (riscv_struct_info::m_offsets): New member variable.
9621         (riscv_struct_info::analyse_inner): New private member function,
9622         takes the old implementation of riscv_struct_info::analyse but
9623         extended to track field offsets.
9624         (riscv_call_arg_struct): Update the struct folding special cases
9625         to handle cases where empty C++ structs, which are non-zero
9626         length, are found.
9627         (riscv_arg_location): Initialise the length of each location, a
9628         non-zero length now indicates the location is in use.
9629         (riscv_push_dummy_call): Allow for the first location having a
9630         non-zero offset when setting up arguments.
9631         (riscv_return_value): Likewise, but for return values.
9632
9633 2019-04-11  Tom Tromey  <tromey@adacore.com>
9634
9635         * utils.c (internal_vproblem): Make "msg" const.
9636
9637 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
9638
9639         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
9640         * trad-frame.c (trad_frame_reset_saved_regs): New function.
9641         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
9642         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
9643
9644 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
9645
9646         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
9647         function.
9648         (fill_gregset): Call amd64_linux_collect_native_gregset instead
9649         of amd64_collect_native_gregset.
9650         (amd64_linux_nat_target::store_registers): Likewise.
9651
9652 2019-04-10  Tom Tromey  <tom@tromey.com>
9653
9654         * symtab.c (lookup_global_symbol_from_objfile)
9655         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
9656         * objfiles.h (class separate_debug_iterator): New.
9657         (class separate_debug_range): New.
9658         (struct objfile) <separate_debug_objfiles>: New method.
9659         (objfile_separate_debug_iterate): Don't declare.
9660         * objfiles.c (separate_debug_iterator::operator++): Rename from
9661         objfile_separate_debug_iterate.
9662         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
9663         iterator.
9664         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
9665         iterator.
9666
9667 2019-04-10  Tom Tromey  <tom@tromey.com>
9668
9669         * symfile.c (reread_symbols): Remove old comment.
9670         * objfiles.c (free_all_objfiles): Fix a typo.
9671
9672 2019-04-10  Tom Tromey  <tom@tromey.com>
9673
9674         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
9675         * minsyms.c (lookup_minimal_symbol): Use foreach.
9676         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
9677         (lookup_minimal_symbol_solib_trampoline): Likewise.
9678         * symfile.c (reread_symbols): Use foreach.
9679
9680 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
9681             Tom Tromey  <tromey@adacore.com>
9682
9683         PR rust/24414:
9684         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
9685         (rust_lex_int_test): Change "value" to be LONGEST.
9686         (rust_lex_tests): Add test for long integer literal.
9687
9688 2019-04-09  Tom Tromey  <tromey@adacore.com>
9689
9690         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
9691         to bool.
9692         (extended_remote_target::attach): Update.
9693         (remote_target::remote_notice_new_inferior): Update.
9694         (remote_target::add_current_inferior_and_thread): Update.
9695         * inferior.c (exit_inferior_1): Use "false".
9696         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
9697
9698 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
9699
9700         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
9701         the "start" command.
9702
9703 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
9704
9705         * python/py-inferior.c (infpy_thread_from_thread_handle):
9706         Adjust comments to reflect renaming of thread_from_thread_handle
9707         to thread_from_handle.  Adjust keywords.  Fix type error message.
9708         (inferior_object_methods): Add thread_from_handle.  Retain
9709         thread_from_thread_handle, but mark it as deprecated.
9710
9711 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
9712
9713         * gdbthread.h (find_thread_by_handle): Revise declaration.
9714         * thread.c (find_thread_by_handle): Likewise.  Adjust
9715         implementation too.
9716         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
9717         support for buffer objects as handles.
9718
9719 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
9720
9721         * python/py-infthread.c (thpy_thread_handle): New function.
9722         (thread_object_methods): Register thpy_thread_handle.
9723
9724 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
9725
9726         * gdbthread.h (thread_to_thread_handle): Declare.
9727         * thread.c (gdbtypes.h): Include.
9728         (thread_to_thread_handle): New function.
9729
9730         * target.h (struct target_ops): Add thread_info_to_thread_handle.
9731         (target_thread_info_to_thread_handle): Declare.
9732         * target.c (target_thread_info_to_thread_handle): New function.
9733         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
9734         * target-delegates.c: Regenerate.
9735
9736         * linux-thread-db.c (class thread_db_target): Add method
9737         thread_info_to_thread_handle.
9738         (thread_db_target::thread_info_to_thread_handle): Define.
9739         * remote.c (class remote_target): Add new method
9740         thread_info_to_thread_handle.
9741         (remote_target::thread_info_to_thread_handle): Define.
9742
9743 2019-04-08  Pedro Alves  <palves@redhat.com>
9744
9745         * common/common-exceptions.c (throw_exception): Don't create
9746         named object to throw; throw directly.
9747         (throw_it): Likewise.  Don't initialize gdb_exception::message
9748         here, with new; pass FMT and AP to the ctor instead.
9749         * common/common-exceptions.h: Include <string>.
9750         (gdb_exception::gdb_exception(enum return_reason, enum errors,
9751         const char *, va_list)): New ctor.  Use std::make_shared.
9752         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
9753         errors)): Delete.
9754         (gdb_exception_error::gdb_exception_error(enum errors, const char
9755         *, va_list)): New.
9756         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
9757         Add assertion.
9758         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
9759         errors)): Delete.
9760         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
9761         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
9762         Add assertion.
9763
9764 2019-04-08  Tom Tromey  <tom@tromey.com>
9765
9766         * valops.c (value_rtti_indirect_type): Replace throw_exception
9767         with throw.
9768         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
9769         with throw.
9770         * thread.c (thr_try_catch_cmd): Replace throw_exception with
9771         throw.
9772         * target.c (target_translate_tls_address): Replace throw_exception
9773         with throw.
9774         * stack.c (frame_apply_command_count): Replace throw_exception
9775         with throw.
9776         * solib-spu.c (append_ocl_sos): Replace throw_exception with
9777         throw.
9778         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
9779         with throw.
9780         * rs6000-tdep.c (rs6000_frame_cache)
9781         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
9782         * remote.c: Replace throw_exception with throw.
9783         * record-full.c (record_full_message, record_full_wait_1)
9784         (record_full_restore): Replace throw_exception with throw.
9785         * record-btrace.c:
9786         (get_thread_current_frame_id, record_btrace_start_replaying)
9787         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
9788         (cmd_record_btrace_start): Replace throw_exception with throw.
9789         * parse.c (parse_exp_in_context_1): Replace throw_exception with
9790         throw.
9791         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
9792         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
9793         * linespec.c:
9794         (find_linespec_symbols): Replace throw_exception with throw.
9795         * infrun.c (displaced_step_prepare, resume): Replace
9796         throw_exception with throw.
9797         * infcmd.c (post_create_inferior): Replace throw_exception with
9798         throw.
9799         * inf-loop.c (inferior_event_handler): Replace throw_exception
9800         with throw.
9801         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
9802         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
9803         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
9804         (get_prev_frame_always, get_frame_pc_if_available)
9805         (get_frame_address_in_block_if_available, get_frame_language):
9806         Replace throw_exception with throw.
9807         * frame-unwind.c (frame_unwind_try_unwinder): Replace
9808         throw_exception with throw.
9809         * eval.c (fetch_subexp_value, evaluate_var_value)
9810         (evaluate_funcall, evaluate_subexp_standard): Replace
9811         throw_exception with throw.
9812         * dwarf2loc.c (call_site_find_chain)
9813         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
9814         Replace throw_exception with throw.
9815         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
9816         with throw.
9817         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
9818         throw.
9819         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
9820         * completer.c (complete_line_internal): Replace throw_exception
9821         with throw.
9822         * compile/compile-object-run.c (compile_object_run): Replace
9823         throw_exception with throw.
9824         * cli/cli-script.c (process_next_line): Replace throw_exception
9825         with throw.
9826         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
9827         (btrace_enable, btrace_maint_update_pt_packets): Replace
9828         throw_exception with throw.
9829         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
9830         throw_exception with throw.
9831         * break-catch-throw.c (re_set_exception_catchpoint): Replace
9832         throw_exception with throw.
9833         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
9834         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
9835         * aarch64-tdep.c (aarch64_make_prologue_cache)
9836         (aarch64_make_stub_cache): Replace throw_exception with throw.
9837
9838 2019-04-08  Tom Tromey  <tom@tromey.com>
9839
9840         * common/common-exceptions.c (throw_exception): Rename from
9841         throw_exception_cxx.  Remove old copy.  Make argument const.
9842         (throw_it): Create and throw exception objects directly.
9843         * common/common-exceptions.h (throw_exception): Make argument
9844         const.
9845         (struct gdb_exception_error): Add constructor.
9846         (struct gdb_exception_quit): Add constructor.
9847
9848 2019-04-08  Tom Tromey  <tom@tromey.com>
9849
9850         * common/common-exceptions.h (exception_rethrow): Don't declare.
9851         (TRY_SJLJ): Update comment.
9852         (TRY, CATCH, END_CATCH): Remove.
9853         * common/common-exceptions.c (exception_rethrow): Remove.
9854
9855 2019-04-08  Tom Tromey  <tom@tromey.com>
9856
9857         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
9858         Remove.
9859         (gdb_exception_error): Rename from
9860         gdb_exception_RETURN_MASK_ERROR.
9861         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
9862         (gdb_quit_bad_alloc): Update.
9863         * aarch64-tdep.c: Update.
9864         * ada-lang.c: Update.
9865         * ada-typeprint.c: Update.
9866         * ada-valprint.c: Update.
9867         * amd64-tdep.c: Update.
9868         * arch-utils.c: Update.
9869         * break-catch-throw.c: Update.
9870         * breakpoint.c: Update.
9871         * btrace.c: Update.
9872         * c-varobj.c: Update.
9873         * cli/cli-cmds.c: Update.
9874         * cli/cli-interp.c: Update.
9875         * cli/cli-script.c: Update.
9876         * common/common-exceptions.c: Update.
9877         * common/new-op.c: Update.
9878         * common/selftest.c: Update.
9879         * compile/compile-c-symbols.c: Update.
9880         * compile/compile-cplus-symbols.c: Update.
9881         * compile/compile-object-load.c: Update.
9882         * compile/compile-object-run.c: Update.
9883         * completer.c: Update.
9884         * corelow.c: Update.
9885         * cp-abi.c: Update.
9886         * cp-support.c: Update.
9887         * cp-valprint.c: Update.
9888         * darwin-nat.c: Update.
9889         * disasm-selftests.c: Update.
9890         * dtrace-probe.c: Update.
9891         * dwarf-index-cache.c: Update.
9892         * dwarf-index-write.c: Update.
9893         * dwarf2-frame-tailcall.c: Update.
9894         * dwarf2-frame.c: Update.
9895         * dwarf2loc.c: Update.
9896         * dwarf2read.c: Update.
9897         * eval.c: Update.
9898         * event-loop.c: Update.
9899         * event-top.c: Update.
9900         * exec.c: Update.
9901         * f-valprint.c: Update.
9902         * fbsd-tdep.c: Update.
9903         * frame-unwind.c: Update.
9904         * frame.c: Update.
9905         * gdbtypes.c: Update.
9906         * gnu-v3-abi.c: Update.
9907         * guile/guile-internal.h: Update.
9908         * guile/scm-block.c: Update.
9909         * guile/scm-breakpoint.c: Update.
9910         * guile/scm-cmd.c: Update.
9911         * guile/scm-disasm.c: Update.
9912         * guile/scm-frame.c: Update.
9913         * guile/scm-lazy-string.c: Update.
9914         * guile/scm-math.c: Update.
9915         * guile/scm-param.c: Update.
9916         * guile/scm-ports.c: Update.
9917         * guile/scm-pretty-print.c: Update.
9918         * guile/scm-symbol.c: Update.
9919         * guile/scm-symtab.c: Update.
9920         * guile/scm-type.c: Update.
9921         * guile/scm-value.c: Update.
9922         * i386-linux-tdep.c: Update.
9923         * i386-tdep.c: Update.
9924         * inf-loop.c: Update.
9925         * infcall.c: Update.
9926         * infcmd.c: Update.
9927         * infrun.c: Update.
9928         * jit.c: Update.
9929         * language.c: Update.
9930         * linespec.c: Update.
9931         * linux-fork.c: Update.
9932         * linux-nat.c: Update.
9933         * linux-tdep.c: Update.
9934         * linux-thread-db.c: Update.
9935         * main.c: Update.
9936         * mi/mi-cmd-break.c: Update.
9937         * mi/mi-cmd-stack.c: Update.
9938         * mi/mi-interp.c: Update.
9939         * mi/mi-main.c: Update.
9940         * objc-lang.c: Update.
9941         * p-valprint.c: Update.
9942         * parse.c: Update.
9943         * ppc-linux-tdep.c: Update.
9944         * printcmd.c: Update.
9945         * python/py-arch.c: Update.
9946         * python/py-breakpoint.c: Update.
9947         * python/py-cmd.c: Update.
9948         * python/py-finishbreakpoint.c: Update.
9949         * python/py-frame.c: Update.
9950         * python/py-framefilter.c: Update.
9951         * python/py-gdb-readline.c: Update.
9952         * python/py-inferior.c: Update.
9953         * python/py-infthread.c: Update.
9954         * python/py-lazy-string.c: Update.
9955         * python/py-linetable.c: Update.
9956         * python/py-objfile.c: Update.
9957         * python/py-param.c: Update.
9958         * python/py-prettyprint.c: Update.
9959         * python/py-progspace.c: Update.
9960         * python/py-record-btrace.c: Update.
9961         * python/py-record.c: Update.
9962         * python/py-symbol.c: Update.
9963         * python/py-type.c: Update.
9964         * python/py-unwind.c: Update.
9965         * python/py-utils.c: Update.
9966         * python/py-value.c: Update.
9967         * python/python.c: Update.
9968         * record-btrace.c: Update.
9969         * record-full.c: Update.
9970         * remote-fileio.c: Update.
9971         * remote.c: Update.
9972         * riscv-tdep.c: Update.
9973         * rs6000-aix-tdep.c: Update.
9974         * rs6000-tdep.c: Update.
9975         * rust-exp.y: Update.
9976         * rust-lang.c: Update.
9977         * s390-tdep.c: Update.
9978         * selftest-arch.c: Update.
9979         * solib-dsbt.c: Update.
9980         * solib-frv.c: Update.
9981         * solib-spu.c: Update.
9982         * solib-svr4.c: Update.
9983         * solib.c: Update.
9984         * sparc64-linux-tdep.c: Update.
9985         * stack.c: Update.
9986         * symfile-mem.c: Update.
9987         * symmisc.c: Update.
9988         * target.c: Update.
9989         * thread.c: Update.
9990         * top.c: Update.
9991         * tracefile-tfile.c: Update.
9992         * tui/tui.c: Update.
9993         * typeprint.c: Update.
9994         * unittests/cli-utils-selftests.c: Update.
9995         * unittests/parse-connection-spec-selftests.c: Update.
9996         * valops.c: Update.
9997         * valprint.c: Update.
9998         * value.c: Update.
9999         * varobj.c: Update.
10000         * windows-nat.c: Update.
10001         * x86-linux-nat.c: Update.
10002         * xml-support.c: Update.
10003
10004 2019-04-08  Tom Tromey  <tom@tromey.com>
10005
10006         * xml-support.c: Use C++ exception handling.
10007         * x86-linux-nat.c: Use C++ exception handling.
10008         * windows-nat.c: Use C++ exception handling.
10009         * varobj.c: Use C++ exception handling.
10010         * value.c: Use C++ exception handling.
10011         * valprint.c: Use C++ exception handling.
10012         * valops.c: Use C++ exception handling.
10013         * unittests/parse-connection-spec-selftests.c: Use C++ exception
10014         handling.
10015         * unittests/cli-utils-selftests.c: Use C++ exception handling.
10016         * typeprint.c: Use C++ exception handling.
10017         * tui/tui.c: Use C++ exception handling.
10018         * tracefile-tfile.c: Use C++ exception handling.
10019         * top.c: Use C++ exception handling.
10020         * thread.c: Use C++ exception handling.
10021         * target.c: Use C++ exception handling.
10022         * symmisc.c: Use C++ exception handling.
10023         * symfile-mem.c: Use C++ exception handling.
10024         * stack.c: Use C++ exception handling.
10025         * sparc64-linux-tdep.c: Use C++ exception handling.
10026         * solib.c: Use C++ exception handling.
10027         * solib-svr4.c: Use C++ exception handling.
10028         * solib-spu.c: Use C++ exception handling.
10029         * solib-frv.c: Use C++ exception handling.
10030         * solib-dsbt.c: Use C++ exception handling.
10031         * selftest-arch.c: Use C++ exception handling.
10032         * s390-tdep.c: Use C++ exception handling.
10033         * rust-lang.c: Use C++ exception handling.
10034         * rust-exp.y: Use C++ exception handling.
10035         * rs6000-tdep.c: Use C++ exception handling.
10036         * rs6000-aix-tdep.c: Use C++ exception handling.
10037         * riscv-tdep.c: Use C++ exception handling.
10038         * remote.c: Use C++ exception handling.
10039         * remote-fileio.c: Use C++ exception handling.
10040         * record-full.c: Use C++ exception handling.
10041         * record-btrace.c: Use C++ exception handling.
10042         * python/python.c: Use C++ exception handling.
10043         * python/py-value.c: Use C++ exception handling.
10044         * python/py-utils.c: Use C++ exception handling.
10045         * python/py-unwind.c: Use C++ exception handling.
10046         * python/py-type.c: Use C++ exception handling.
10047         * python/py-symbol.c: Use C++ exception handling.
10048         * python/py-record.c: Use C++ exception handling.
10049         * python/py-record-btrace.c: Use C++ exception handling.
10050         * python/py-progspace.c: Use C++ exception handling.
10051         * python/py-prettyprint.c: Use C++ exception handling.
10052         * python/py-param.c: Use C++ exception handling.
10053         * python/py-objfile.c: Use C++ exception handling.
10054         * python/py-linetable.c: Use C++ exception handling.
10055         * python/py-lazy-string.c: Use C++ exception handling.
10056         * python/py-infthread.c: Use C++ exception handling.
10057         * python/py-inferior.c: Use C++ exception handling.
10058         * python/py-gdb-readline.c: Use C++ exception handling.
10059         * python/py-framefilter.c: Use C++ exception handling.
10060         * python/py-frame.c: Use C++ exception handling.
10061         * python/py-finishbreakpoint.c: Use C++ exception handling.
10062         * python/py-cmd.c: Use C++ exception handling.
10063         * python/py-breakpoint.c: Use C++ exception handling.
10064         * python/py-arch.c: Use C++ exception handling.
10065         * printcmd.c: Use C++ exception handling.
10066         * ppc-linux-tdep.c: Use C++ exception handling.
10067         * parse.c: Use C++ exception handling.
10068         * p-valprint.c: Use C++ exception handling.
10069         * objc-lang.c: Use C++ exception handling.
10070         * mi/mi-main.c: Use C++ exception handling.
10071         * mi/mi-interp.c: Use C++ exception handling.
10072         * mi/mi-cmd-stack.c: Use C++ exception handling.
10073         * mi/mi-cmd-break.c: Use C++ exception handling.
10074         * main.c: Use C++ exception handling.
10075         * linux-thread-db.c: Use C++ exception handling.
10076         * linux-tdep.c: Use C++ exception handling.
10077         * linux-nat.c: Use C++ exception handling.
10078         * linux-fork.c: Use C++ exception handling.
10079         * linespec.c: Use C++ exception handling.
10080         * language.c: Use C++ exception handling.
10081         * jit.c: Use C++ exception handling.
10082         * infrun.c: Use C++ exception handling.
10083         * infcmd.c: Use C++ exception handling.
10084         * infcall.c: Use C++ exception handling.
10085         * inf-loop.c: Use C++ exception handling.
10086         * i386-tdep.c: Use C++ exception handling.
10087         * i386-linux-tdep.c: Use C++ exception handling.
10088         * guile/scm-value.c: Use C++ exception handling.
10089         * guile/scm-type.c: Use C++ exception handling.
10090         * guile/scm-symtab.c: Use C++ exception handling.
10091         * guile/scm-symbol.c: Use C++ exception handling.
10092         * guile/scm-pretty-print.c: Use C++ exception handling.
10093         * guile/scm-ports.c: Use C++ exception handling.
10094         * guile/scm-param.c: Use C++ exception handling.
10095         * guile/scm-math.c: Use C++ exception handling.
10096         * guile/scm-lazy-string.c: Use C++ exception handling.
10097         * guile/scm-frame.c: Use C++ exception handling.
10098         * guile/scm-disasm.c: Use C++ exception handling.
10099         * guile/scm-cmd.c: Use C++ exception handling.
10100         * guile/scm-breakpoint.c: Use C++ exception handling.
10101         * guile/scm-block.c: Use C++ exception handling.
10102         * guile/guile-internal.h: Use C++ exception handling.
10103         * gnu-v3-abi.c: Use C++ exception handling.
10104         * gdbtypes.c: Use C++ exception handling.
10105         * frame.c: Use C++ exception handling.
10106         * frame-unwind.c: Use C++ exception handling.
10107         * fbsd-tdep.c: Use C++ exception handling.
10108         * f-valprint.c: Use C++ exception handling.
10109         * exec.c: Use C++ exception handling.
10110         * event-top.c: Use C++ exception handling.
10111         * event-loop.c: Use C++ exception handling.
10112         * eval.c: Use C++ exception handling.
10113         * dwarf2read.c: Use C++ exception handling.
10114         * dwarf2loc.c: Use C++ exception handling.
10115         * dwarf2-frame.c: Use C++ exception handling.
10116         * dwarf2-frame-tailcall.c: Use C++ exception handling.
10117         * dwarf-index-write.c: Use C++ exception handling.
10118         * dwarf-index-cache.c: Use C++ exception handling.
10119         * dtrace-probe.c: Use C++ exception handling.
10120         * disasm-selftests.c: Use C++ exception handling.
10121         * darwin-nat.c: Use C++ exception handling.
10122         * cp-valprint.c: Use C++ exception handling.
10123         * cp-support.c: Use C++ exception handling.
10124         * cp-abi.c: Use C++ exception handling.
10125         * corelow.c: Use C++ exception handling.
10126         * completer.c: Use C++ exception handling.
10127         * compile/compile-object-run.c: Use C++ exception handling.
10128         * compile/compile-object-load.c: Use C++ exception handling.
10129         * compile/compile-cplus-symbols.c: Use C++ exception handling.
10130         * compile/compile-c-symbols.c: Use C++ exception handling.
10131         * common/selftest.c: Use C++ exception handling.
10132         * common/new-op.c: Use C++ exception handling.
10133         * cli/cli-script.c: Use C++ exception handling.
10134         * cli/cli-interp.c: Use C++ exception handling.
10135         * cli/cli-cmds.c: Use C++ exception handling.
10136         * c-varobj.c: Use C++ exception handling.
10137         * btrace.c: Use C++ exception handling.
10138         * breakpoint.c: Use C++ exception handling.
10139         * break-catch-throw.c: Use C++ exception handling.
10140         * arch-utils.c: Use C++ exception handling.
10141         * amd64-tdep.c: Use C++ exception handling.
10142         * ada-valprint.c: Use C++ exception handling.
10143         * ada-typeprint.c: Use C++ exception handling.
10144         * ada-lang.c: Use C++ exception handling.
10145         * aarch64-tdep.c: Use C++ exception handling.
10146
10147 2019-04-08  Tom Tromey  <tom@tromey.com>
10148
10149         * xml-support.c (gdb_xml_parser::parse): Update.
10150         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
10151         * value.c (show_convenience): Update.
10152         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
10153         (test_parse_flags_qcs): Update.
10154         * thread.c (thr_try_catch_cmd): Update.
10155         * target.c (target_translate_tls_address): Update.
10156         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
10157         (info_frame_command_core, frame_apply_command_count): Update.
10158         * rust-exp.y (rust_lex_exception_test): Update.
10159         * riscv-tdep.c (riscv_print_one_register_info): Update.
10160         * remote.c (remote_target::enable_btrace): Update.
10161         * record-btrace.c (record_btrace_enable_warn): Update.
10162         * python/py-utils.c (gdbpy_convert_exception): Update.
10163         * printcmd.c (do_one_display, print_variable_and_value): Update.
10164         * mi/mi-main.c (mi_print_exception): Update.
10165         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
10166         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
10167         * linux-nat.c (linux_nat_target::attach): Update.
10168         * linux-fork.c (class scoped_switch_fork_info): Update.
10169         * infrun.c (displaced_step_prepare): Update.
10170         * infcall.c (call_function_by_hand_dummy): Update.
10171         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
10172         * gnu-v3-abi.c (print_one_vtable): Update.
10173         * frame.c (get_prev_frame_always): Update.
10174         * f-valprint.c (info_common_command_for_block): Update.
10175         * exec.c (try_open_exec_file): Update.
10176         * exceptions.c (print_exception, exception_print)
10177         (exception_fprintf, exception_print_same): Update.
10178         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
10179         * dwarf-index-cache.c (index_cache::store)
10180         (index_cache::lookup_gdb_index): Update.
10181         * darwin-nat.c (maybe_cache_shell): Update.
10182         * cp-valprint.c (cp_print_value_fields): Update.
10183         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
10184         (gcc_cplus_symbol_address): Update.
10185         * compile/compile-c-symbols.c (gcc_convert_symbol)
10186         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
10187         * common/selftest.c: Update.
10188         * common/common-exceptions.h (struct gdb_exception) <message>: Now
10189         a std::string.
10190         (exception_try_scope_entry, exception_try_scope_exit): Don't
10191         declare.
10192         (struct exception_try_scope): Remove.
10193         (TRY): Don't use exception_try_scope.
10194         (struct gdb_exception): Add constructor, operator=.
10195         <what>: New method.
10196         (struct gdb_exception_RETURN_MASK_ALL)
10197         (struct gdb_exception_RETURN_MASK_ERROR)
10198         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
10199         (struct gdb_quit_bad_alloc): Update.
10200         * common/common-exceptions.c (exception_none): Change
10201         initializer.
10202         (struct catcher) <state, exception>: Initialize inline.
10203         <prev>: Remove member.
10204         (current_catcher): Remove.
10205         (catchers): New global.
10206         (exceptions_state_mc_init): Simplify.
10207         (catcher_pop): Remove.
10208         (exceptions_state_mc, exceptions_state_mc_catch): Update.
10209         (try_scope_depth, exception_try_scope_entry)
10210         (exception_try_scope_exit): Remove.
10211         (throw_exception_sjlj): Update.
10212         (exception_messages, exception_messages_size): Remove.
10213         (throw_it): Simplify.
10214         (gdb_exception_sliced_copy): Remove.
10215         (throw_exception_cxx): Update.
10216         * cli/cli-script.c (script_from_file): Update.
10217         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
10218         Update.
10219         * ada-valprint.c (ada_val_print): Update.
10220         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
10221         (create_excep_cond_exprs): Update.
10222
10223 2019-04-08  Tom Tromey  <tom@tromey.com>
10224
10225         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
10226         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
10227         (TRY, CATCH, END_CATCH): Remove some definitions.
10228         * common/common-exceptions.c: Don't use GDB_XCPT.
10229         (catcher_list_size): Remove.
10230         (throw_exception, throw_it): Simplify.
10231
10232 2019-04-05  Tom Tromey  <tom@tromey.com>
10233
10234         Revert the header-sorting patch.
10235         * ft32-tdep.c: Revert.
10236         * frv-tdep.c: Revert.
10237         * frv-linux-tdep.c: Revert.
10238         * frame.c: Revert.
10239         * frame-unwind.c: Revert.
10240         * frame-base.c: Revert.
10241         * fork-child.c: Revert.
10242         * findvar.c: Revert.
10243         * findcmd.c: Revert.
10244         * filesystem.c: Revert.
10245         * filename-seen-cache.h: Revert.
10246         * filename-seen-cache.c: Revert.
10247         * fbsd-tdep.c: Revert.
10248         * fbsd-nat.h: Revert.
10249         * fbsd-nat.c: Revert.
10250         * f-valprint.c: Revert.
10251         * f-typeprint.c: Revert.
10252         * f-lang.c: Revert.
10253         * extension.h: Revert.
10254         * extension.c: Revert.
10255         * extension-priv.h: Revert.
10256         * expprint.c: Revert.
10257         * exec.h: Revert.
10258         * exec.c: Revert.
10259         * exceptions.c: Revert.
10260         * event-top.c: Revert.
10261         * event-loop.c: Revert.
10262         * eval.c: Revert.
10263         * elfread.c: Revert.
10264         * dwarf2read.h: Revert.
10265         * dwarf2read.c: Revert.
10266         * dwarf2loc.c: Revert.
10267         * dwarf2expr.h: Revert.
10268         * dwarf2expr.c: Revert.
10269         * dwarf2-frame.c: Revert.
10270         * dwarf2-frame-tailcall.c: Revert.
10271         * dwarf-index-write.h: Revert.
10272         * dwarf-index-write.c: Revert.
10273         * dwarf-index-common.c: Revert.
10274         * dwarf-index-cache.h: Revert.
10275         * dwarf-index-cache.c: Revert.
10276         * dummy-frame.c: Revert.
10277         * dtrace-probe.c: Revert.
10278         * disasm.h: Revert.
10279         * disasm.c: Revert.
10280         * disasm-selftests.c: Revert.
10281         * dictionary.c: Revert.
10282         * dicos-tdep.c: Revert.
10283         * demangle.c: Revert.
10284         * dcache.h: Revert.
10285         * dcache.c: Revert.
10286         * darwin-nat.h: Revert.
10287         * darwin-nat.c: Revert.
10288         * darwin-nat-info.c: Revert.
10289         * d-valprint.c: Revert.
10290         * d-namespace.c: Revert.
10291         * d-lang.c: Revert.
10292         * ctf.c: Revert.
10293         * csky-tdep.c: Revert.
10294         * csky-linux-tdep.c: Revert.
10295         * cris-tdep.c: Revert.
10296         * cris-linux-tdep.c: Revert.
10297         * cp-valprint.c: Revert.
10298         * cp-support.c: Revert.
10299         * cp-namespace.c: Revert.
10300         * cp-abi.c: Revert.
10301         * corelow.c: Revert.
10302         * corefile.c: Revert.
10303         * continuations.c: Revert.
10304         * completer.h: Revert.
10305         * completer.c: Revert.
10306         * complaints.c: Revert.
10307         * coffread.c: Revert.
10308         * coff-pe-read.c: Revert.
10309         * cli-out.h: Revert.
10310         * cli-out.c: Revert.
10311         * charset.c: Revert.
10312         * c-varobj.c: Revert.
10313         * c-valprint.c: Revert.
10314         * c-typeprint.c: Revert.
10315         * c-lang.c: Revert.
10316         * buildsym.c: Revert.
10317         * buildsym-legacy.c: Revert.
10318         * build-id.h: Revert.
10319         * build-id.c: Revert.
10320         * btrace.c: Revert.
10321         * bsd-uthread.c: Revert.
10322         * breakpoint.h: Revert.
10323         * breakpoint.c: Revert.
10324         * break-catch-throw.c: Revert.
10325         * break-catch-syscall.c: Revert.
10326         * break-catch-sig.c: Revert.
10327         * blockframe.c: Revert.
10328         * block.c: Revert.
10329         * bfin-tdep.c: Revert.
10330         * bfin-linux-tdep.c: Revert.
10331         * bfd-target.c: Revert.
10332         * bcache.c: Revert.
10333         * ax-general.c: Revert.
10334         * ax-gdb.h: Revert.
10335         * ax-gdb.c: Revert.
10336         * avr-tdep.c: Revert.
10337         * auxv.c: Revert.
10338         * auto-load.c: Revert.
10339         * arm-wince-tdep.c: Revert.
10340         * arm-tdep.c: Revert.
10341         * arm-symbian-tdep.c: Revert.
10342         * arm-pikeos-tdep.c: Revert.
10343         * arm-obsd-tdep.c: Revert.
10344         * arm-nbsd-tdep.c: Revert.
10345         * arm-nbsd-nat.c: Revert.
10346         * arm-linux-tdep.c: Revert.
10347         * arm-linux-nat.c: Revert.
10348         * arm-fbsd-tdep.c: Revert.
10349         * arm-fbsd-nat.c: Revert.
10350         * arm-bsd-tdep.c: Revert.
10351         * arch-utils.c: Revert.
10352         * arc-tdep.c: Revert.
10353         * arc-newlib-tdep.c: Revert.
10354         * annotate.h: Revert.
10355         * annotate.c: Revert.
10356         * amd64-windows-tdep.c: Revert.
10357         * amd64-windows-nat.c: Revert.
10358         * amd64-tdep.c: Revert.
10359         * amd64-sol2-tdep.c: Revert.
10360         * amd64-obsd-tdep.c: Revert.
10361         * amd64-obsd-nat.c: Revert.
10362         * amd64-nbsd-tdep.c: Revert.
10363         * amd64-nbsd-nat.c: Revert.
10364         * amd64-nat.c: Revert.
10365         * amd64-linux-tdep.c: Revert.
10366         * amd64-linux-nat.c: Revert.
10367         * amd64-fbsd-tdep.c: Revert.
10368         * amd64-fbsd-nat.c: Revert.
10369         * amd64-dicos-tdep.c: Revert.
10370         * amd64-darwin-tdep.c: Revert.
10371         * amd64-bsd-nat.c: Revert.
10372         * alpha-tdep.c: Revert.
10373         * alpha-obsd-tdep.c: Revert.
10374         * alpha-nbsd-tdep.c: Revert.
10375         * alpha-mdebug-tdep.c: Revert.
10376         * alpha-linux-tdep.c: Revert.
10377         * alpha-linux-nat.c: Revert.
10378         * alpha-bsd-tdep.c: Revert.
10379         * alpha-bsd-nat.c: Revert.
10380         * aix-thread.c: Revert.
10381         * agent.c: Revert.
10382         * addrmap.c: Revert.
10383         * ada-varobj.c: Revert.
10384         * ada-valprint.c: Revert.
10385         * ada-typeprint.c: Revert.
10386         * ada-tasks.c: Revert.
10387         * ada-lang.c: Revert.
10388         * aarch64-tdep.c: Revert.
10389         * aarch64-ravenscar-thread.c: Revert.
10390         * aarch64-newlib-tdep.c: Revert.
10391         * aarch64-linux-tdep.c: Revert.
10392         * aarch64-linux-nat.c: Revert.
10393         * aarch64-fbsd-tdep.c: Revert.
10394         * aarch64-fbsd-nat.c: Revert.
10395         * aarch32-linux-nat.c: Revert.
10396
10397 2019-04-05  Tom Tromey  <tom@tromey.com>
10398
10399         * ft32-tdep.c: Sort headers.
10400         * frv-tdep.c: Sort headers.
10401         * frv-linux-tdep.c: Sort headers.
10402         * frame.c: Sort headers.
10403         * frame-unwind.c: Sort headers.
10404         * frame-base.c: Sort headers.
10405         * fork-child.c: Sort headers.
10406         * findvar.c: Sort headers.
10407         * findcmd.c: Sort headers.
10408         * filesystem.c: Sort headers.
10409         * filename-seen-cache.h: Sort headers.
10410         * filename-seen-cache.c: Sort headers.
10411         * fbsd-tdep.c: Sort headers.
10412         * fbsd-nat.h: Sort headers.
10413         * fbsd-nat.c: Sort headers.
10414         * f-valprint.c: Sort headers.
10415         * f-typeprint.c: Sort headers.
10416         * f-lang.c: Sort headers.
10417         * extension.h: Sort headers.
10418         * extension.c: Sort headers.
10419         * extension-priv.h: Sort headers.
10420         * expprint.c: Sort headers.
10421         * exec.h: Sort headers.
10422         * exec.c: Sort headers.
10423         * exceptions.c: Sort headers.
10424         * event-top.c: Sort headers.
10425         * event-loop.c: Sort headers.
10426         * eval.c: Sort headers.
10427         * elfread.c: Sort headers.
10428         * dwarf2read.h: Sort headers.
10429         * dwarf2read.c: Sort headers.
10430         * dwarf2loc.c: Sort headers.
10431         * dwarf2expr.h: Sort headers.
10432         * dwarf2expr.c: Sort headers.
10433         * dwarf2-frame.c: Sort headers.
10434         * dwarf2-frame-tailcall.c: Sort headers.
10435         * dwarf-index-write.h: Sort headers.
10436         * dwarf-index-write.c: Sort headers.
10437         * dwarf-index-common.c: Sort headers.
10438         * dwarf-index-cache.h: Sort headers.
10439         * dwarf-index-cache.c: Sort headers.
10440         * dummy-frame.c: Sort headers.
10441         * dtrace-probe.c: Sort headers.
10442         * disasm.h: Sort headers.
10443         * disasm.c: Sort headers.
10444         * disasm-selftests.c: Sort headers.
10445         * dictionary.c: Sort headers.
10446         * dicos-tdep.c: Sort headers.
10447         * demangle.c: Sort headers.
10448         * dcache.h: Sort headers.
10449         * dcache.c: Sort headers.
10450         * darwin-nat.h: Sort headers.
10451         * darwin-nat.c: Sort headers.
10452         * darwin-nat-info.c: Sort headers.
10453         * d-valprint.c: Sort headers.
10454         * d-namespace.c: Sort headers.
10455         * d-lang.c: Sort headers.
10456         * ctf.c: Sort headers.
10457         * csky-tdep.c: Sort headers.
10458         * csky-linux-tdep.c: Sort headers.
10459         * cris-tdep.c: Sort headers.
10460         * cris-linux-tdep.c: Sort headers.
10461         * cp-valprint.c: Sort headers.
10462         * cp-support.c: Sort headers.
10463         * cp-namespace.c: Sort headers.
10464         * cp-abi.c: Sort headers.
10465         * corelow.c: Sort headers.
10466         * corefile.c: Sort headers.
10467         * continuations.c: Sort headers.
10468         * completer.h: Sort headers.
10469         * completer.c: Sort headers.
10470         * complaints.c: Sort headers.
10471         * coffread.c: Sort headers.
10472         * coff-pe-read.c: Sort headers.
10473         * cli-out.h: Sort headers.
10474         * cli-out.c: Sort headers.
10475         * charset.c: Sort headers.
10476         * c-varobj.c: Sort headers.
10477         * c-valprint.c: Sort headers.
10478         * c-typeprint.c: Sort headers.
10479         * c-lang.c: Sort headers.
10480         * buildsym.c: Sort headers.
10481         * buildsym-legacy.c: Sort headers.
10482         * build-id.h: Sort headers.
10483         * build-id.c: Sort headers.
10484         * btrace.c: Sort headers.
10485         * bsd-uthread.c: Sort headers.
10486         * breakpoint.h: Sort headers.
10487         * breakpoint.c: Sort headers.
10488         * break-catch-throw.c: Sort headers.
10489         * break-catch-syscall.c: Sort headers.
10490         * break-catch-sig.c: Sort headers.
10491         * blockframe.c: Sort headers.
10492         * block.c: Sort headers.
10493         * bfin-tdep.c: Sort headers.
10494         * bfin-linux-tdep.c: Sort headers.
10495         * bfd-target.c: Sort headers.
10496         * bcache.c: Sort headers.
10497         * ax-general.c: Sort headers.
10498         * ax-gdb.h: Sort headers.
10499         * ax-gdb.c: Sort headers.
10500         * avr-tdep.c: Sort headers.
10501         * auxv.c: Sort headers.
10502         * auto-load.c: Sort headers.
10503         * arm-wince-tdep.c: Sort headers.
10504         * arm-tdep.c: Sort headers.
10505         * arm-symbian-tdep.c: Sort headers.
10506         * arm-pikeos-tdep.c: Sort headers.
10507         * arm-obsd-tdep.c: Sort headers.
10508         * arm-nbsd-tdep.c: Sort headers.
10509         * arm-nbsd-nat.c: Sort headers.
10510         * arm-linux-tdep.c: Sort headers.
10511         * arm-linux-nat.c: Sort headers.
10512         * arm-fbsd-tdep.c: Sort headers.
10513         * arm-fbsd-nat.c: Sort headers.
10514         * arm-bsd-tdep.c: Sort headers.
10515         * arch-utils.c: Sort headers.
10516         * arc-tdep.c: Sort headers.
10517         * arc-newlib-tdep.c: Sort headers.
10518         * annotate.h: Sort headers.
10519         * annotate.c: Sort headers.
10520         * amd64-windows-tdep.c: Sort headers.
10521         * amd64-windows-nat.c: Sort headers.
10522         * amd64-tdep.c: Sort headers.
10523         * amd64-sol2-tdep.c: Sort headers.
10524         * amd64-obsd-tdep.c: Sort headers.
10525         * amd64-obsd-nat.c: Sort headers.
10526         * amd64-nbsd-tdep.c: Sort headers.
10527         * amd64-nbsd-nat.c: Sort headers.
10528         * amd64-nat.c: Sort headers.
10529         * amd64-linux-tdep.c: Sort headers.
10530         * amd64-linux-nat.c: Sort headers.
10531         * amd64-fbsd-tdep.c: Sort headers.
10532         * amd64-fbsd-nat.c: Sort headers.
10533         * amd64-dicos-tdep.c: Sort headers.
10534         * amd64-darwin-tdep.c: Sort headers.
10535         * amd64-bsd-nat.c: Sort headers.
10536         * alpha-tdep.c: Sort headers.
10537         * alpha-obsd-tdep.c: Sort headers.
10538         * alpha-nbsd-tdep.c: Sort headers.
10539         * alpha-mdebug-tdep.c: Sort headers.
10540         * alpha-linux-tdep.c: Sort headers.
10541         * alpha-linux-nat.c: Sort headers.
10542         * alpha-bsd-tdep.c: Sort headers.
10543         * alpha-bsd-nat.c: Sort headers.
10544         * aix-thread.c: Sort headers.
10545         * agent.c: Sort headers.
10546         * addrmap.c: Sort headers.
10547         * ada-varobj.c: Sort headers.
10548         * ada-valprint.c: Sort headers.
10549         * ada-typeprint.c: Sort headers.
10550         * ada-tasks.c: Sort headers.
10551         * ada-lang.c: Sort headers.
10552         * aarch64-tdep.c: Sort headers.
10553         * aarch64-ravenscar-thread.c: Sort headers.
10554         * aarch64-newlib-tdep.c: Sort headers.
10555         * aarch64-linux-tdep.c: Sort headers.
10556         * aarch64-linux-nat.c: Sort headers.
10557         * aarch64-fbsd-tdep.c: Sort headers.
10558         * aarch64-fbsd-nat.c: Sort headers.
10559         * aarch32-linux-nat.c: Sort headers.
10560
10561 2019-04-04  Tom Tromey  <tom@tromey.com>
10562
10563         * varobj.c (varobj_create): Update.
10564         * rust-exp.y (struct rust_parser) <update_innermost_block,
10565         lookup_symbol>: New methods.
10566         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
10567         Rename.
10568         (rust_parser::rust_lookup_type)
10569         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
10570         * printcmd.c (display_command, do_one_display): Update.
10571         * parser-defs.h (struct parser_state) <parser_state>: Add
10572         "tracker" parameter.
10573         (block_tracker): New member.
10574         (class innermost_block_tracker) <innermost_block_tracker>: Add
10575         "types" parameter.
10576         <reset>: Remove method.
10577         (innermost_block): Don't declare.
10578         (null_post_parser): Update.
10579         * parse.c (innermost_block): Remove global.
10580         (write_dollar_variable): Update.
10581         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
10582         Remove "tracker_types" parameter.
10583         (parse_expression): Add "tracker" parameter.
10584         (parse_expression_for_completion): Update.
10585         (null_post_parser): Add "tracker" parameter.
10586         * p-exp.y: Update rules.
10587         * m2-exp.y: Update rules.
10588         * language.h (struct language_defn) <la_post_parser>: Add
10589         "tracker" parameter.
10590         * go-exp.y: Update rules.
10591         * f-exp.y: Update rules.
10592         * expression.h (parse_expression, parse_exp_1): Add "tracker"
10593         parameter.
10594         * d-exp.y: Update rules.
10595         * c-exp.y: Update rules.
10596         * breakpoint.c (set_breakpoint_condition): Create an
10597         innermost_block_tracker.
10598         (watch_command_1): Likewise.
10599         * ada-lang.c (resolve): Add "tracker" parameter.
10600         (resolve_subexp): Likewise.
10601         * ada-exp.y (write_var_from_sym): Update.
10602
10603 2019-04-04  Tom Tromey  <tom@tromey.com>
10604
10605         * type-stack.h: New file.
10606         * type-stack.c: New file.
10607         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
10608         type-stack.h.
10609         (insert_into_type_stack, insert_type, push_type, push_type_int)
10610         (insert_type_address_space, pop_type, pop_type_int)
10611         (pop_typelist, pop_type_stack, append_type_stack)
10612         (push_type_stack, get_type_stack, push_typelist)
10613         (follow_type_instance_flags, follow_types): Don't declare.
10614         * parse.c (type_stack): Remove global.
10615         (parse_exp_in_context): Update.
10616         (insert_into_type_stack, insert_type, push_type, push_type_int)
10617         (insert_type_address_space, pop_type, pop_type_int)
10618         (pop_typelist, pop_type_stack, append_type_stack)
10619         (push_type_stack, get_type_stack, push_typelist)
10620         (follow_type_instance_flags, follow_types): Remove (moved to
10621         type-stack.c).
10622         * f-exp.y (type_stack): New global.
10623         Update rules.
10624         (push_kind_type, f_parse): Update.
10625         * d-exp.y (type_stack): New global.
10626         Update rules.
10627         (d_parse): Update.
10628         * c-exp.y (struct c_parse_state) <type_stack>: New member.
10629         Update rules.
10630         * Makefile.in (COMMON_SFILES): Add type-stack.c.
10631         (HFILES_NO_SRCDIR): Add type-stack.h.
10632
10633 2019-04-04  Tom Tromey  <tom@tromey.com>
10634
10635         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
10636         (rust_parser::convert_ast_to_expression, rust_parse)
10637         (rust_lex_test_completion, rust_lex_tests): Update.
10638         * parser-defs.h (struct expr_completion_state): New.
10639         (struct parser_state) <parser_state>: Add completion parameter.
10640         <mark_struct_expression, mark_completion_tag>: New methods.
10641         <parse_completion, m_completion_state>: New members.
10642         (prefixify_expression, null_post_parser): Update.
10643         (mark_struct_expression, mark_completion_tag): Don't declare.
10644         * parse.c (parse_completion, expout_last_struct)
10645         (expout_tag_completion_type, expout_completion_name): Remove
10646         globals.
10647         (parser_state::mark_struct_expression)
10648         (parser_state::mark_completion_tag): Now methods.
10649         (prefixify_expression): Add last_struct parameter.
10650         (prefixify_subexp): Likewise.
10651         (parse_exp_1): Update.
10652         (parse_exp_in_context): Add cstate parameter.  Update.
10653         (parse_expression_for_completion): Create an
10654         expr_completion_state.
10655         (null_post_parser): Add "completion" parameter.
10656         * p-exp.y: Update rules.
10657         (yylex): Update.
10658         * language.h (struct language_defn) <la_post_parser>: Add
10659         "completing" parameter.
10660         * go-exp.y: Update rules.
10661         (lex_one_token): Update.
10662         * expression.h (parse_completion): Don't declare.
10663         * d-exp.y: Update rules.
10664         (lex_one_token): Update rules.
10665         * c-exp.y: Update rules.
10666         (lex_one_token): Update.
10667         * ada-lang.c (resolve): Add "parse_completion" parameter.
10668         (resolve_subexp): Likewise.
10669         (ada_resolve_function): Likewise.
10670
10671 2019-04-04  Tom Tromey  <tom@tromey.com>
10672
10673         * parser-defs.h (struct parser_state) <start_arglist,
10674         end_arglist>: New methods.
10675         <arglist_len, m_funcall_chain>: New members.
10676         (arglist_len, start_arglist, end_arglist): Don't declare.
10677         * parse.c (arglist_len, funcall_chain): Remove global.
10678         (start_arglist, end_arglist): Remove functions.
10679         (parse_exp_in_context): Update.
10680         * p-exp.y: Update rules.
10681         * m2-exp.y: Update rules.
10682         * go-exp.y: Update rules.
10683         * f-exp.y: Update rules.
10684         * d-exp.y: Update rules.
10685         * c-exp.y: Update rules.
10686
10687 2019-04-04  Tom Tromey  <tom@tromey.com>
10688
10689         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
10690         lex_operator, push_back>: New methods.
10691         Update all rules.
10692         (rust_parser::lex_hex, lex_escape): Rename and update.
10693         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
10694         (rust_parser::lex_operator): Rename and update.
10695         (rust_parser::lex_number, rustyylex, rustyyerror)
10696         (rust_lex_test_init, rust_lex_test_sequence)
10697         (rust_lex_test_push_back, rust_lex_tests): Update.
10698         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
10699         parameter.
10700         <lexptr, prev_lexptr>: New members.
10701         (lexptr, prev_lexptr): Don't declare.
10702         * parse.c (lexptr, prev_lexptr): Remove globals.
10703         (parse_exp_in_context): Update.
10704         * p-exp.y (yylex, yyerror): Update.
10705         * m2-exp.y (parse_number, yylex, yyerror): Update.
10706         * go-exp.y (lex_one_token, yyerror): Update.
10707         * f-exp.y (match_string_literal, yylex, yyerror): Update.
10708         * d-exp.y (lex_one_token, yyerror): Update.
10709         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
10710         (lex_one_token, yyerror): Update.
10711         * ada-lex.l (YY_INPUT): Update.
10712         (rewind_to_char): Update.
10713         * ada-exp.y (yyerror): Update.
10714
10715 2019-04-04  Tom Tromey  <tom@tromey.com>
10716
10717         * rust-exp.y (rustyylex, rust_lex_tests): Update.
10718         * parser-defs.h (struct parser_state) <parser_state>: Add new
10719         parameter.
10720         <comma_terminates>: New member.
10721         (comma_terminates): Don't declare global.
10722         * parse.c (comma_terminates): Remove global.
10723         (parse_exp_in_context): Update.
10724         * p-exp.y (yylex): Update.
10725         * m2-exp.y (yylex): Update.
10726         * go-exp.y (lex_one_token): Update.
10727         * f-exp.y (yylex): Update.
10728         * d-exp.y (lex_one_token): Update.
10729         * c-exp.y (lex_one_token): Update.
10730         * ada-lex.l: Update.
10731
10732 2019-04-04  Tom Tromey  <tom@tromey.com>
10733
10734         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
10735         (rustyylex, rust_lex_test_init, rust_lex_test_one)
10736         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
10737         * parser-defs.h (paren_depth): Don't declare.
10738         * parse.c (paren_depth): Remove global.
10739         (parse_exp_in_context): Update.
10740         * p-exp.y (paren_depth): New global.
10741         (pascal_parse): Initialize it.
10742         * m2-exp.y (paren_depth): New global.
10743         (m2_parse): Initialize it.
10744         * go-exp.y (paren_depth): New global.
10745         (go_parse): Initialize it.
10746         * f-exp.y (paren_depth): New global.
10747         (f_parse): Initialize it.
10748         * d-exp.y (paren_depth): New global.
10749         (d_parse): Initialize it.
10750         * c-exp.y (paren_depth): New global.
10751         (c_parse): Initialize it.
10752         * ada-lex.l (paren_depth): New global.
10753         (lexer_init): Initialize it.
10754
10755 2019-04-04  Tom Tromey  <tom@tromey.com>
10756
10757         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
10758         (rust_parser::convert_ast_to_type)
10759         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
10760         * parser-defs.h (struct parser_state) <parser_state>: Add
10761         parameters.  Initialize new members.
10762         <expression_context_block, expression_context_pc>: New members.
10763         * parse.c (expression_context_block, expression_context_pc):
10764         Remove globals.
10765         (parse_exp_in_context): Update.
10766         * p-exp.y: Update all rules.
10767         (yylex): Update.
10768         * m2-exp.y: Update all rules.
10769         (yylex): Update.
10770         * go-exp.y (yylex): Update.
10771         * f-exp.y (yylex): Update.
10772         * d-exp.y: Update all rules.
10773         (yylex): Update.
10774         * c-exp.y: Update all rules.
10775         (lex_one_token, classify_name, yylex, c_parse): Update.
10776         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
10777
10778 2019-04-04  Tom Tromey  <tom@tromey.com>
10779
10780         * gdbarch.h, gdbarch.c: Rebuild.
10781         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
10782         * stap-probe.h:
10783         (struct stap_parse_info): Replace "parser_state" with
10784         "expr_builder".
10785         * parser-defs.h (struct expr_builder): Rename from "parser_state".
10786         (parser_state): New class.
10787         * parse.c (expr_builder): Rename.
10788         (expr_builder::release): Rename.
10789         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
10790         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
10791         (write_exp_elt_longcst, write_exp_elt_floatcst)
10792         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
10793         (write_exp_string_vector, write_exp_bitstring)
10794         (write_exp_msymbol, mark_struct_expression)
10795         (write_dollar_variable)
10796         (insert_type_address_space, increase_expout_size): Replace
10797         "parser_state" with "expr_builder".
10798         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
10799         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
10800         "parser_state" with "expr_builder".
10801
10802 2019-04-04  Tom Tromey  <tom@tromey.com>
10803
10804         * rust-exp.y: Replace "parse_language" with method call.
10805         * p-exp.y:
10806         (yylex): Replace "parse_language" with method call.
10807         * m2-exp.y:
10808         (yylex): Replace "parse_language" with method call.
10809         * go-exp.y (classify_name): Replace "parse_language" with method
10810         call.
10811         * f-exp.y (yylex): Replace "parse_language" with method call.
10812         * d-exp.y (lex_one_token): Replace "parse_language" with method
10813         call.
10814         * c-exp.y:
10815         (lex_one_token, classify_name, yylex): Replace "parse_language"
10816         with method call.
10817         * ada-exp.y (find_primitive_type, type_char)
10818         (type_system_address): Replace "parse_language" with method call.
10819
10820 2019-04-04  Tom Tromey  <tom@tromey.com>
10821
10822         * rust-exp.y: Replace "parse_gdbarch" with method call.
10823         * parse.c (write_dollar_variable, insert_type_address_space):
10824         Replace "parse_gdbarch" with method call.
10825         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
10826         call.
10827         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
10828         call.
10829         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
10830         "parse_gdbarch" with method call.
10831         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
10832         with method call.
10833         * f-exp.y (parse_type, parse_f_type, yylex): Replace
10834         "parse_gdbarch" with method call.
10835         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
10836         "parse_gdbarch" with method call.
10837         * c-exp.y (parse_type, parse_number, classify_name): Replace
10838         "parse_gdbarch" with method call.
10839         * ada-lex.l: Replace "parse_gdbarch" with method call.
10840         * ada-exp.y (parse_type, find_primitive_type, type_char)
10841         (type_system_address): Replace "parse_gdbarch" with method call.
10842
10843 2019-04-04  Tom Tromey  <tom@tromey.com>
10844
10845         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
10846         * stap-probe.c (stap_parse_argument): Update.
10847         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
10848         initial_size parameter.
10849         * rust-exp.y (rust_lex_tests): Update.
10850         * parse.c (parser_state): Update.
10851         (parse_exp_in_context): Update.
10852         * parser-defs.h (struct parser_state) <parser_state>: Remove
10853         "initial_size" parameter.
10854
10855 2019-04-04  Tom Tromey  <tom@tromey.com>
10856
10857         * parser-defs.h (increase_expout_size): Don't declare.
10858         * parse.c (increase_expout_size): Now static.
10859
10860 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
10861
10862         * gnu-nat.c (gnu_nat_target::wait): Fix
10863         target_waitstatus_to_string call.
10864
10865 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
10866
10867         * eval.c (evaluate_subexp_standard): Handle internal functions
10868         during Fortran function call handling.
10869
10870 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
10871
10872         * NEWS: Mention new internal functions.
10873         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
10874         (read_base_type): Use dwarf2_init_complex_target_type.
10875         * value.c (creal_internal_fn): New function.
10876         (cimag_internal_fn): New function.
10877         (_initialize_values): Register new internal functions.
10878
10879 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10880
10881         * infrun.c (stop_all_threads): If debug_infrun, always
10882         trace the wait status after wait_one, using
10883         target_waitstatus_to_string and target_pid_to_str.
10884         (handle_inferior_event): Replace various trace of
10885         wait status kind by a single trace.
10886         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
10887         wait status kind image by target_waitstatus_to_string.
10888         * target/waitstatus.c (target_waitstatus_to_string): Fix
10889         obsolete comment.
10890
10891 2019-04-01  Tom Tromey  <tromey@adacore.com>
10892
10893         PR symtab/23331:
10894         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
10895
10896 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
10897             Pedro Alves  <palves@redhat.com>
10898
10899         * top.c (quit_force): Call 'finalize_values'.
10900         * value.c (finalize_values): New function.
10901         * value.h (finalize_values): Declare.
10902
10903 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
10904
10905         * NEWS: Announce $_gdb_major and $_gdb_minor.
10906
10907         * top.c (init_gdb_version_vars): New function.
10908         (gdb_init): Call init_gdb_version_vars.
10909
10910 2019-03-29  Tom Tromey  <tromey@adacore.com>
10911
10912         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
10913         help text.  Remove dead code.
10914
10915 2019-03-29  Keith Seitz  <keiths@redhat.com>
10916
10917         From Siddhesh Poyarekar:
10918         * f-lang.h (f77_get_upperbound): Return LONGEST.
10919         (f77_get_lowerbound): Likewise.
10920         * f-typeprint.c (f_type_print_varspec_suffix): Expand
10921         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
10922         print them.
10923         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
10924         plongest to format print it.
10925         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
10926         (f77_get_upperbound): Likewise.
10927         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
10928         LOWER_BOUND to LONGEST.
10929         (f77_create_arrayprint_offset_tbl): Likewise.
10930
10931 2019-03-29  Keith Seitz  <keiths@redhat.com>
10932
10933         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
10934         %s/pulongest for TYPE_LENGTH instead of %d in format
10935         strings.
10936         * ada-typerint.c (ada_print_type): Likewise.
10937         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
10938         * compile/compile-c-support.c (generate_register_struct): Likewise.
10939         * gdbtypes.c (recursive_dump_type): Likewise.
10940         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
10941         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
10942         instead of %d in format strings.
10943         * riscv-tdep.c (riscv_type_alignment): Cast second argument
10944         to std::min to ULONGEST.
10945         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
10946         instead of %d in format strings.
10947         * tracepoint.c (info_scope_command): Likewise.
10948         * typeprint.c (print_offset_data::update)
10949         (print_offset_data::finish): Likewise.
10950         * xtensa-tdep.c (xtensa_store_return_value)
10951         (xtensa_push_dummy_call): Likewise.
10952
10953 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
10954
10955         * windows-nat.c (display_selector): Fixed format specifications
10956         for 64-bit Cygwin.
10957
10958 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10959
10960         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
10961
10962 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
10963
10964         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
10965         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
10966         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
10967         (nios2_linux_init_abi): Install it.
10968
10969 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
10970
10971         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
10972
10973 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
10974
10975         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
10976
10977 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10978             Tom Tromey  <tromey@adacore.com>
10979
10980         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
10981
10982 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
10983
10984         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
10985         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
10986         method to compute the bounds of range types. Also print "[evaluated]"
10987         if the bounds' values come from a dynamic evaluation.
10988
10989 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
10990
10991         * cp-valprint.c (cp_print_value_fields): Don't print trailing
10992         whitespace when pretty printing is on.
10993
10994 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
10995
10996         * ppc-linux-nat.c: Add include.
10997
10998 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
10999
11000         * NEWS: Mention AArch64 Pointer Authentication.
11001
11002 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
11003
11004         * arm-linux-nat.c: Add include.
11005
11006 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
11007
11008         * source-cache.c (source_cache::get_source_lines): Re-read
11009         fullname after calling open_source_file.
11010
11011 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
11012
11013         * NEWS: Mention TLS support for FreeBSD.
11014
11015 2019-03-25  Tom Tromey  <tromey@adacore.com>
11016
11017         * minsyms.c (BUNCH_SIZE): Update comment.
11018         (~minimal_symbol_reader): Remove old comment.
11019         (compact_minimal_symbols): Update comment.
11020         (minimal_symbol_reader::install): Remove old comment.  Update
11021         other comments.
11022
11023 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
11024
11025         * s390-linux-nat.c: Add include.
11026
11027 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
11028
11029         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
11030         Call linux_get_hwcap.
11031         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
11032         Likewise.
11033         (aarch64_linux_get_hwcap): Remove function.
11034         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
11035         declaration.
11036         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
11037         linux_get_hwcap.
11038         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
11039         * linux-tdep.c (linux_get_hwcap): Add function.
11040         (linux_get_hwcap2): Likewise.
11041         * linux-tdep.h (linux_get_hwcap): Add declaration.
11042         (linux_get_hwcap2): Likewise.
11043         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
11044         (ppc_linux_get_hwcap2): Likewise.
11045         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
11046         linux_get_hwcap.
11047         (ppc_linux_nat_target::insert_watchpoint): Likewise.
11048         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
11049         (ppc_linux_nat_target::read_description): Likewise.
11050         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
11051         * s390-linux-nat.c: Likewise.
11052         * s390-linux-tdep.c (s390_core_read_description): Likewise.
11053
11054 2019-03-24  Tom Tromey  <tom@tromey.com>
11055
11056         * ada-lang.c (standard_lookup): Simplify initialization.
11057         (ada_lookup_symbol_nonlocal): Simplify return.
11058         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
11059         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
11060         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
11061         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
11062         initialization.
11063         * solib.c (solib_global_lookup): Simplify.
11064         * symtab.c (null_block_symbol): Remove.
11065         (symbol_cache_lookup): Simplify returns.
11066         (lookup_language_this): Simplify returns.
11067         (lookup_symbol_aux): Simplify return.
11068         (lookup_local_symbol): Simplify returns.
11069         (lookup_global_symbol_from_objfile): Simplify return.
11070         (lookup_symbol_in_objfile_symtabs)
11071         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
11072         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
11073         (lookup_static_symbol, lookup_global_symbol): Simplify return.
11074         * cp-namespace.c (cp_lookup_bare_symbol)
11075         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
11076         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
11077         (cp_lookup_nested_symbol): Don't use null_block_symbol.
11078         (cp_lookup_symbol_via_imports): Simplify initialization.
11079         (find_symbol_in_baseclass): Likewise.
11080         * symtab.h (null_block_symbol): Remove.
11081         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
11082         (d_lookup_nested_symbol, d_lookup_symbol_imports)
11083         (d_lookup_symbol_module): Likewise.
11084         (find_symbol_in_baseclass): Simplify initialization.
11085
11086 2019-03-24  Tom Tromey  <tom@tromey.com>
11087
11088         * expression.h: Don't include symtab.h.
11089         (struct block): Forward declare.
11090
11091 2019-03-24  Tom Tromey  <tom@tromey.com>
11092
11093         * c-exp.y (typebase): Remove casts.
11094         * gdbtypes.c (lookup_unsigned_typename, )
11095         (lookup_signed_typename): Remove cast.
11096         * eval.c (parse_to_comma_and_eval): Remove cast.
11097         * parse.c (write_dollar_variable): Remove cast.
11098         * block.h (struct block) <superblock>: Now const.
11099         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
11100         * psymtab.c (psym_map_matching_symbols): Make "block" const.
11101         (map_block): Make "block" const.
11102         * symfile.h (struct quick_symbol_functions)
11103         <map_matching_symbols>: Constify block argument to "callback".
11104         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
11105         const.
11106         (find_pc_sect_compunit_symtab): Make "b" const.
11107         (find_symbol_at_address): Likewise.
11108         (search_symbols): Likewise.
11109         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
11110         (dw2_debug_names_lookup_symbol): Likewise.
11111         (dw2_map_matching_symbols): Update.
11112         * p-valprint.c (pascal_val_print): Remove "block".
11113         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
11114         (aux_add_nonlocal_symbols): Make "block" const.
11115         (resolve_subexp): Remove cast.
11116         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
11117         const.
11118         (iterate_over_file_blocks): Likewise.
11119         * f-exp.y (%union) <bval>: Remove.
11120         * coffread.c (patch_opaque_types): Make "b" const.
11121         * spu-tdep.c (spu_catch_start): Make "block" const.
11122         * c-valprint.c (print_unpacked_pointer): Remove "block".
11123         * symmisc.c (dump_symtab_1): Make "b" const.
11124         (block_depth): Make "block" const.
11125         * d-exp.y (%union) <bval>: Remove.
11126         * cp-support.h (cp_lookup_rtti_type): Update.
11127         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
11128         * psymtab.c (psym_lookup_symbol): Make "block" const.
11129         (maintenance_check_psymtabs): Make "b" const.
11130         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
11131         (enumerate_locals, enumerate_args): Update.
11132         * python/py-symtab.c (stpy_global_block): Make "block" const.
11133         (stpy_static_block): Likewise.
11134         * inline-frame.c (block_starting_point_at): Make "new_block"
11135         const.
11136         * block.c (find_block_in_blockvector): Make return type const.
11137         (blockvector_for_pc_sect): Make "b" const.
11138         (find_block_in_blockvector): Make "b" const.
11139
11140 2019-03-23  Tom Tromey  <tom@tromey.com>
11141
11142         * varobj.c (varobj_create): Update.
11143         * symfile.c (clear_symtab_users): Don't reset innermost_block.
11144         * printcmd.c (display_command, do_one_display): Don't reset
11145         innermost_block.
11146         * parser-defs.h (enum innermost_block_tracker_type): Move to
11147         expression.h.
11148         (innermost_block): Update comment.
11149         * parse.c (parse_exp_1): Add tracker_types parameter.
11150         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
11151         tracker_types parameter.  Reset innermost_block.
11152         (parse_exp_in_context): Remove.
11153         (parse_expression_for_completion): Update.
11154         * objfiles.c (~objfile): Don't reset expression_context_block or
11155         innermost_block.
11156         * expression.h (enum innermost_block_tracker_type): Move from
11157         parser-defs.h.
11158         (parse_exp_1): Add tracker_types parameter.
11159         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
11160         reset innermost_block.
11161
11162 2019-03-23  Tom Tromey  <tom@tromey.com>
11163
11164         * objfiles.h: Include bcache.h.
11165
11166 2019-03-23  Tom Tromey  <tom@tromey.com>
11167
11168         * linespec.c (get_current_search_block): Use
11169         scoped_restore_current_language.
11170         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
11171
11172 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
11173             Jiong Wang  <jiong.wang@arm.com>
11174
11175         * aarch64-linux-tdep.c
11176         (aarch64_linux_iterate_over_regset_sections): Check for pauth
11177         section.
11178         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
11179
11180 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
11181             Jiong Wang  <jiong.wang@arm.com>
11182
11183         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
11184         instructions.
11185         (aarch64_analyze_prologue_test): Add PACIASP test.
11186         (aarch64_prologue_prev_register): Unmask PC value.
11187
11188 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
11189             Jiong Wang  <jiong.wang@arm.com>
11190
11191         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
11192         (aarch64_dwarf2_prev_register): Unmask PC value.
11193         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
11194         (aarch64_execute_dwarf_cfa_vendor_op): Check for
11195         DW_CFA_AARCH64_negate_ra_state.
11196         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
11197
11198 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
11199             Jiong Wang  <jiong.wang@arm.com>
11200
11201         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
11202         registers.
11203         (aarch64_pseudo_register_name): Likewise.
11204         (aarch64_pseudo_register_type): Likewise.
11205         (aarch64_pseudo_register_reggroup_p): Likewise.
11206         (aarch64_gdbarch_init): Add pauth registers.
11207         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
11208         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
11209         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
11210         (struct gdbarch_tdep): Add regnum for ra_state.
11211
11212 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
11213             Jiong Wang  <jiong.wang@arm.com>
11214
11215         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
11216
11217 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
11218             Jiong Wang  <jiong.wang@arm.com>
11219
11220         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
11221         function.
11222         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
11223         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
11224         (aarch64_gdbarch_init): Add puth registers.
11225         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
11226         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
11227         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
11228
11229 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
11230             Jiong Wang  <jiong.wang@arm.com>
11231
11232         * aarch64-linux-nat.c
11233         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
11234         * aarch64-linux-tdep.c
11235         (aarch64_linux_core_read_description): Likewise.
11236         (aarch64_linux_get_hwcap): New function.
11237         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
11238         (aarch64_linux_get_hwcap): New declaration.
11239
11240 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
11241             Jiong Wang  <jiong.wang@arm.com>
11242
11243         * aarch64-linux-nat.c
11244         (aarch64_linux_nat_target::read_description): Add pauth param.
11245         * aarch64-linux-tdep.c
11246         (aarch64_linux_core_read_description): Likewise.
11247         * aarch64-tdep.c (struct target_desc): Add in pauth.
11248         (aarch64_read_description): Add pauth param.
11249         (aarch64_gdbarch_init): Likewise.
11250         * aarch64-tdep.h (aarch64_read_description): Likewise.
11251         * arch/aarch64.c (aarch64_create_target_description): Likewise.
11252         * arch/aarch64.h (aarch64_create_target_description): Likewise.
11253         * features/Makefile: Add new files.
11254         * features/aarch64-pauth.c: New file.
11255         * features/aarch64-pauth.xml: New file.
11256
11257 2019-03-20  Tom Tromey  <tromey@adacore.com>
11258
11259         * infrun.c (handle_inferior_event): Rename from
11260         handle_inferior_event_1.  Create a scoped_value_mark.
11261         (handle_inferior_event): Remove.
11262
11263 2019-03-19  Tom Tromey  <tromey@adacore.com>
11264
11265         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
11266         * infrun.h (print_stop_event): Add "displays" parameter.
11267         * infrun.c (print_stop_event): Add "displays" parameter.
11268
11269 2019-03-19  Pedro Alves  <palves@redhat.com>
11270
11271         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
11272         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
11273         to -1.  Fix TABs vs spaces.
11274         (tui_ui_out::tui_ui_out): Don't initialize fields here.
11275         * tui/tui-out.h (tui_ui_out) Add intro comments.
11276         <m_line, m_start_of_line>: In-class initialize, and add describing
11277         comment.
11278
11279 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
11280
11281         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
11282         variable names.
11283         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
11284
11285 2019-03-18  Pedro Alves  <palves@redhat.com>
11286             Eli Zaretskii <eliz@gnu.org>
11287
11288         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
11289         m_line and m_start_of_line.
11290
11291 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
11292
11293         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
11294         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
11295         it returns a newline.  This fixes a regression in TU mode, whereby
11296         the next line is output on the same screen line as the user input.
11297
11298 2019-03-18  Tom Tromey  <tromey@adacore.com>
11299
11300         * minsyms.c (minimal_symbol_reader::install): Remove call to
11301         obstack_blank.
11302
11303 2019-03-18  Pedro Alves  <palves@redhat.com>
11304
11305         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
11306         New globals.
11307         (apply_style): New, factored out from ...
11308         (apply_ansi_escape): ... this.  Handle reverse video mode.
11309         (tui_set_reverse_mode): New function.
11310         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
11311         * tui/tui-winsource.c (tui_show_source_line): Use
11312         tui_set_reverse_mode instead of setting A_STANDOUT.
11313         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
11314         New setter methods.
11315
11316 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
11317
11318         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
11319         Handle tabs.
11320
11321 2019-03-18  Tom Tromey  <tromey@adacore.com>
11322
11323         * ada-lang.c (empty_array): Add "high" parameter.
11324         (ada_evaluate_subexp): Update.
11325
11326 2019-03-17  Sergei Trofimovich <siarheit@google.com>
11327
11328         * unittests/string_view-selftests.c: Define
11329         _initialize_string_view_selftests unconditionally.
11330
11331 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
11332
11333         PR gdb/24350
11334         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
11335
11336 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
11337
11338         PR gdb/24351
11339         * windows-nat.c (display_selector): Fix format specifiers.
11340
11341 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
11342
11343         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
11344         tui_refill_source_window instead of tui_refresh_win, to update the
11345         current execution line.  This fixes redisplay of the current line
11346         when stepping through the code with "next" or "step".
11347
11348 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
11349
11350         * source-cache.c (source_cache::get_source_lines): Call
11351         find_source_lines to initialize s->nlines.  This fixes vertical
11352         scrolling of TUI source window when the DOWN arrow is pressed.
11353
11354 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11355
11356         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
11357         linux-thread-db.c (_initialize_thread_db): Likewise.
11358
11359 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
11360
11361         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
11362         wclrtoeol in tui_show_source_line".  This reverts changes made in
11363         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
11364
11365 2019-03-15  Tom Tromey  <tom@tromey.com>
11366
11367         * symtab.h (struct minimal_symbol): Derive from
11368         general_symbol_info.
11369         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
11370         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
11371         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
11372         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
11373         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
11374         (MSYMBOL_SEARCH_NAME): Update.
11375         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
11376         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
11377         * minsyms.c (minimal_symbol_reader::record_full): Update.
11378
11379 2019-03-15  Tom Tromey  <tom@tromey.com>
11380
11381         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
11382
11383 2019-03-15  Tom Tromey  <tom@tromey.com>
11384
11385         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
11386         unique_xmalloc_ptr.
11387         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
11388         Update.
11389         * minsyms.c (lookup_minimal_symbol_by_pc_section)
11390         (build_minimal_symbol_hash_tables)
11391         (minimal_symbol_reader::install): Update.
11392
11393 2019-03-15  Tom Tromey  <tom@tromey.com>
11394
11395         * symtab.c (create_demangled_names_hash): Update.
11396         (symbol_set_names): Update.
11397         * objfiles.h (struct objfile_per_bfd_storage)
11398         <demangled_names_hash>: Now an htab_up.
11399         * objfiles.c (objfile_per_bfd_storage): Simplify.
11400
11401 2019-03-15  Tom Tromey  <tom@tromey.com>
11402
11403         * objfiles.h (struct objfile_per_bfd_storage): Declare
11404         destructor.
11405         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
11406         New.
11407         (get_objfile_bfd_data): Use new.  Don't initialize
11408         language_of_main.
11409         (free_objfile_per_bfd_storage): Remove.
11410         (objfile_bfd_data_free, objfile::~objfile): Use delete.
11411
11412 2019-03-15  Tom Tromey  <tom@tromey.com>
11413
11414         * symfile.c (reread_symbols): Update.
11415         * objfiles.c (objfile::objfile): Update.
11416         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
11417         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
11418         comment.
11419         (minimal_symbol_reader::install): Update.
11420         (terminate_minimal_symbol_table): Remove.
11421         * jit.c (jit_object_close_impl): Update.
11422
11423 2019-03-15  Tom Tromey  <tom@tromey.com>
11424
11425         * minsyms.c (minimal_symbol_reader::record_full): Remove some
11426         initializations.
11427
11428 2019-03-15  Tom Tromey  <tom@tromey.com>
11429
11430         * objfiles.h (struct objfile_per_bfd_storage)
11431         <demangled_hash_languages>: Now a bitset.
11432         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
11433         (lookup_minimal_symbol): Update.
11434
11435 2019-03-15  Tom Tromey  <tom@tromey.com>
11436
11437         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
11438         Don't return the symbol.
11439         * coffread.c (record_minimal_symbol): Use record_full.
11440
11441 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
11442
11443         The MS-Windows port of ncurses fails to switch to a color pair if
11444         one or both of the colors are the implicit default colors.  This
11445         change records the default colors when TUI is initialized, and
11446         then specifies them explicitly when a color pair uses the default
11447         colors.  This allows color styling in TUI mode on MS-Windows.
11448
11449         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
11450         ncurses_norm_attr.
11451         (tui_initialize_io) [__MINGW32__]: Record the default terminal
11452         colors in ncurses_norm_attr.
11453         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
11454         "none", replace it with the default color recorded in
11455         ncurses_norm_attr.
11456
11457 2019-03-14  Tom Tromey  <tromey@adacore.com>
11458
11459         * source-cache.h (class source_cache) <get_source_lines>: Return
11460         std::string.
11461         * source-cache.c (source_cache::extract_lines): Handle case where
11462         first_pos==npos.  Return std::string.
11463         (source_cache::get_source_lines): Update.
11464
11465 2019-03-14  Tom Tromey  <tromey@adacore.com>
11466
11467         * NEWS: Add item for "style sources" commands.
11468         * source-cache.c (source_cache::get_source_lines): Check
11469         source_styling.
11470         * cli/cli-style.c (source_styling): New global.
11471         (_initialize_cli_style): Add "style sources" commands.
11472         (show_style_sources): New function.
11473         * cli/cli-style.h (source_styling): Declare.
11474
11475 2019-03-14  Pedro Alves  <palves@redhat.com>
11476             Tom Tromey  <tromey@adacore.com>
11477
11478         * tui/tui-winsource.h (tui_refill_source_window): Declare.
11479         * tui/tui-winsource.c (tui_refill_source_window): New function,
11480         from...
11481         (tui_horizontal_source_scroll): ... here.  Move some logic.
11482         * cli/cli-style.c (set_style_enabled): Notify new observable.
11483         * tui/tui-hooks.c (tui_redisplay_source): New function.
11484         (tui_attach_detach_observers): Attach or detach
11485         tui_redisplay_source.
11486         * observable.h (source_styling_changed): New observable.
11487         * observable.c: Define source_styling_changed observable.
11488
11489 2019-03-13  Tom Tromey  <tromey@adacore.com>
11490
11491         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
11492         (i386_gnu_nat_target::store_registers): Update.
11493         * target-debug.h (target_debug_print_std_string): New macro.
11494         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
11495         * windows-tdep.c (display_one_tib): Update.
11496         * tui/tui-stack.c (tui_make_status_line): Update.
11497         * top.c (print_inferior_quit_action): Update.
11498         * thread.c (thr_try_catch_cmd): Update.
11499         (add_thread_with_info): Update.
11500         (thread_target_id_str): Update.
11501         (thr_try_catch_cmd): Update.
11502         (thread_command): Update.
11503         (thread_find_command): Update.
11504         * record-btrace.c (record_btrace_target::info_record)
11505         (record_btrace_resume_thread, record_btrace_target::resume)
11506         (record_btrace_cancel_resume, record_btrace_step_thread)
11507         (record_btrace_target::wait, record_btrace_target::wait)
11508         (record_btrace_target::wait, record_btrace_target::stop): Update.
11509         * progspace.c (print_program_space): Update.
11510         * process-stratum-target.c
11511         (process_stratum_target::thread_address_space): Update.
11512         * linux-fork.c (linux_fork_mourn_inferior)
11513         (detach_checkpoint_command, info_checkpoints_command)
11514         (linux_fork_context): Update.
11515         (linux_fork_detach): Update.
11516         (class scoped_switch_fork_info): Update.
11517         (delete_checkpoint_command): Update.
11518         * infrun.c (follow_fork_inferior): Update.
11519         (follow_fork_inferior): Update.
11520         (proceed_after_vfork_done): Update.
11521         (handle_vfork_child_exec_or_exit): Update.
11522         (follow_exec): Update.
11523         (displaced_step_prepare_throw): Update.
11524         (displaced_step_restore): Update.
11525         (start_step_over): Update.
11526         (resume_1): Update.
11527         (clear_proceed_status_thread): Update.
11528         (proceed): Update.
11529         (print_target_wait_results): Update.
11530         (do_target_wait): Update.
11531         (context_switch): Update.
11532         (stop_all_threads): Update.
11533         (restart_threads): Update.
11534         (finish_step_over): Update.
11535         (handle_signal_stop): Update.
11536         (switch_back_to_stepped_thread): Update.
11537         (keep_going_pass_signal): Update.
11538         (print_exited_reason): Update.
11539         (normal_stop): Update.
11540         * inferior.c (inferior_pid_to_str): Change return type.
11541         (print_selected_inferior): Update.
11542         (add_inferior): Update.
11543         (detach_inferior): Update.
11544         * dummy-frame.c (fprint_dummy_frames): Update.
11545         * dcache.c (dcache_info_1): Update.
11546         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
11547         (btrace_fetch, btrace_clear): Update.
11548         * linux-tdep.c (linux_core_pid_to_str): Change return type.
11549         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
11550         type.
11551         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
11552         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
11553         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
11554         * gdbarch.c, gdbarch.h: Rebuild.
11555         * gdbarch.sh (core_pid_to_str): Change return type.
11556         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
11557         return type.
11558         (windows_nat_target::pid_to_str): Change return type.
11559         (windows_delete_thread): Update.
11560         (windows_nat_target::attach): Update.
11561         (windows_nat_target::files_info): Update.
11562         * target-delegates.c: Rebuild.
11563         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
11564         return type.
11565         (sol_thread_target::pid_to_str): Change return type.
11566         * remote.c (class remote_target) <pid_to_str>: Change return
11567         type.
11568         (remote_target::pid_to_str): Change return type.
11569         (extended_remote_target::attach, remote_target::remote_stop_ns)
11570         (remote_target::remote_notif_remove_queued_reply)
11571         (remote_target::push_stop_reply, remote_target::disable_btrace):
11572         Update.
11573         (extended_remote_target::attach): Update.
11574         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
11575         type.
11576         (gdbsim_target::pid_to_str): Change return type.
11577         * ravenscar-thread.c (struct ravenscar_thread_target)
11578         <pid_to_str>: Change return type.
11579         (ravenscar_thread_target::pid_to_str): Change return type.
11580         * procfs.c (class procfs_target) <pid_to_str>: Change return
11581         type.
11582         (procfs_target::pid_to_str): Change return type.
11583         (procfs_target::attach): Update.
11584         (procfs_target::detach): Update.
11585         (procfs_target::fetch_registers): Update.
11586         (procfs_target::store_registers): Update.
11587         (procfs_target::wait): Update.
11588         (procfs_target::files_info): Update.
11589         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
11590         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
11591         return type.
11592         (nto_procfs_target::pid_to_str): Change return type.
11593         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
11594         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
11595         return type.
11596         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
11597         (exit_lwp): Update.
11598         (attach_proc_task_lwp_callback, get_detach_signal)
11599         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
11600         (linux_nat_target::resume, wait_lwp, stop_callback)
11601         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
11602         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
11603         (linux_nat_wait_1, resume_stopped_resumed_lwps)
11604         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
11605         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
11606         type.
11607         (inf_ptrace_target::attach): Update.
11608         (inf_ptrace_target::files_info): Update.
11609         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
11610         type.
11611         (go32_nat_target::pid_to_str): Change return type.
11612         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
11613         (gnu_nat_target::wait): Update.
11614         (gnu_nat_target::wait): Update.
11615         (gnu_nat_target::resume): Update.
11616         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
11617         (fbsd_nat_target::wait): Update.
11618         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
11619         type.
11620         (darwin_nat_target::attach): Update.
11621         * corelow.c (class core_target) <pid_to_str>: Change return type.
11622         (core_target::pid_to_str): Change return type.
11623         * target.c (normal_pid_to_str): Change return type.
11624         (default_pid_to_str): Likewise.
11625         (target_pid_to_str): Change return type.
11626         (target_translate_tls_address): Update.
11627         (target_announce_detach): Update.
11628         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
11629         return type.
11630         (bsd_uthread_target::pid_to_str): Change return type.
11631         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
11632         type.
11633         (bsd_kvm_target::pid_to_str): Change return type.
11634         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
11635         return type.
11636         (aix_thread_target::pid_to_str): Change return type.
11637         * target.h (struct target_ops) <pid_to_str>: Change return type.
11638         (target_pid_to_str, normal_pid_to_str): Likewise.
11639         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
11640         type.
11641         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
11642         type.
11643         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
11644         return type.
11645         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
11646         type.
11647         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
11648         type.
11649         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
11650         return type.
11651
11652 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
11653
11654         * NEWS: Mention that the new default MI version is 3.  Mention
11655         changes to the output of commands and events that deal with
11656         multi-location breakpoints.
11657         * breakpoint.c: Include "mi/mi-out.h".
11658         (print_one_breakpoint): Change output syntax if using MI version
11659         >= 3.
11660         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
11661         New.
11662         (mi_multi_location_breakpoint_output_fixed): New.
11663         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
11664         (mi_cmd_fix_multi_location_breakpoint_output): New.
11665         (mi_multi_location_breakpoint_output_fixed): New.
11666         * mi/mi-cmds.c (mi_cmds): Register command
11667         -fix-multi-location-breakpoint-output.
11668         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
11669         interpreter "mi".
11670
11671 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
11672
11673         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
11674         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
11675         instantiate mi_ui_out based on interpreter name.
11676         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
11677         * mi/mi-main.c (mi_load_progress): Likewise.
11678
11679 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11680
11681         * NEWS: Combine separate "New targets" sections for 8.3.
11682
11683 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11684
11685         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
11686         (ppcfbsd_init_abi): Install gdbarch
11687         "fetch_tls_load_module_address" and "get_thread_local_address"
11688         methods.
11689
11690 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11691
11692         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
11693         (riscv_fbsd_init_abi): Install gdbarch
11694         "fetch_tls_load_module_address" and "get_thread_local_address"
11695         methods.
11696
11697 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11698
11699         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
11700         (i386fbsd_init_abi): Install gdbarch
11701         "fetch_tls_load_module_address" and "get_thread_local_address"
11702         methods.
11703
11704 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11705
11706         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
11707         (amd64fbsd_init_abi): Install gdbarch
11708         "fetch_tls_load_module_address" and "get_thread_local_address"
11709         methods.
11710
11711 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11712
11713         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
11714         (struct fbsd_pspace_data): New type.
11715         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
11716         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
11717         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
11718         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
11719         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
11720
11721 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11722
11723         * gdbtypes.c (lookup_struct_elt): New function.
11724         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
11725         * gdbtypes.h (struct struct_elt): New type.
11726         (lookup_struct_elt): New prototype.
11727
11728 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11729
11730         * gdbtypes.c (lookup_struct_elt_type): Update comment and
11731         remove disabled code block.
11732
11733 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11734
11735         * gdbarch.sh (get_thread_local_address): New method.
11736         * gdbarch.h, gdbarch.c: Regenerate.
11737         * target.c (target_translate_tls_address): Use
11738         gdbarch_get_thread_local_address if present instead of
11739         target::get_thread_local_address.
11740
11741 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11742
11743         * target.h (target::get_thread_local_address): Update comment.
11744
11745 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11746
11747         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
11748         objfile->separate_debug_objfile_backlink if not NULL.
11749
11750 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11751
11752         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
11753         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
11754         (amd64bsd_store_inferior_registers): Likewise.
11755         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
11756         Enable segment base registers.
11757         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
11758         PT_GETFSBASE and PT_GETGSBASE.
11759         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
11760         PT_SETGSBASE.
11761         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
11762         segment base registers.
11763         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
11764
11765 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11766
11767         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
11768         Update calls to i386_target_description to add 'segments'
11769         parameter.
11770         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
11771         add segment base registers.
11772         * arch/i386.c (i386_create_target_description): Add 'segments'
11773         parameter to enable segment base registers.
11774         * arch/i386.h (i386_create_target_description): Likewise.
11775         * features/i386/32bit-segments.xml: New file.
11776         * features/i386/32bit-segments.c: Generate.
11777         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
11778         call to i386_target_description to add 'segments' parameter.
11779         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
11780         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
11781         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
11782         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
11783         if feature is present.
11784         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
11785         Add 'segments' parameter to call to i386_target_description.
11786         (i386_target_description): Add 'segments' parameter to enable
11787         segment base registers.
11788         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
11789         to call to i386_target_description.
11790         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
11791         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
11792         Define I386_NUM_REGS.
11793         (i386_target_description): Add 'segments' parameter to enable
11794         segment base registers.
11795
11796 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
11797
11798         PR/24325
11799         * source-cache.c: #undef open and close, to avoid unresolved
11800         externals during linking.
11801
11802 2019-03-12  Tom Tromey  <tromey@adacore.com>
11803
11804         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
11805         const.  Add initializers.
11806         (_initialize_remote): Don't initialize ptid globals.
11807
11808 2019-03-12  Pedro Alves  <palves@redhat.com>
11809
11810         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
11811
11812 2019-03-12  Pedro Alves  <palves@redhat.com>
11813
11814         * cp-name-parser.y (main): Remove unused 'len' variable.
11815
11816 2019-03-12  Tom Tromey  <tromey@adacore.com>
11817
11818         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
11819         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
11820
11821 2019-03-12  Tom Tromey  <tromey@adacore.com>
11822
11823         * linux-nat.c (iterate_over_lwps): Update.
11824         (stop_callback): Remove parameter.
11825         (stop_wait_callback, detach_callback, resume_set_callback)
11826         (select_singlestep_lwp_callback, set_ignore_sigint)
11827         (status_callback, resumed_callback, resume_clear_callback)
11828         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
11829         data parameter.
11830         (linux_nat_target::detach, linux_nat_target::resume)
11831         (linux_stop_and_wait_all_lwps, select_event_lwp)
11832         (linux_nat_filter_event, linux_nat_wait_1)
11833         (linux_nat_target::kill, linux_nat_target::stop)
11834         (linux_nat_target::stop): Update.
11835         (linux_nat_resume_callback): Change type.
11836         (resume_stopped_resumed_lwps, count_events_callback)
11837         (select_event_lwp_callback): Likewise.
11838         (linux_stop_lwp, linux_nat_stop_lwp): Update.
11839         * arm-linux-nat.c (struct update_registers_data): Remove.
11840         (update_registers_callback): Change type.
11841         (arm_linux_insert_hw_breakpoint1): Update.
11842         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
11843         parameter.
11844         (x86_linux_dr_set_addr): Update.
11845         (x86_linux_dr_set_control): Update.
11846         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
11847         (iterate_over_lwps): Use gdb::function_view.
11848         * nat/aarch64-linux-hw-point.c (struct
11849         aarch64_dr_update_callback_param): Remove.
11850         (debug_reg_change_callback): Change type.
11851         (aarch64_notify_debug_reg_change): Update.
11852         * s390-linux-nat.c (s390_refresh_per_info): Update.
11853
11854 2019-03-11  Tom Tromey  <tromey@adacore.com>
11855
11856         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
11857         redundant assignment to "this_cu".
11858
11859 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11860
11861         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
11862
11863 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11864
11865         * gdbtypes.c (rank_one_type_parm_set): New function extracted
11866         from...
11867         (rank_one_type): ... this.
11868
11869 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11870
11871         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
11872         from...
11873         (rank_one_type): ... this.
11874
11875 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11876
11877         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
11878         from...
11879         (rank_one_type): ... this.
11880
11881 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11882
11883         * gdbtypes.c (rank_one_type_parm_float): New function extracted
11884         from...
11885         (rank_one_type): ... this.
11886
11887 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11888
11889         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
11890         from...
11891         (rank_one_type): ... this.
11892
11893 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11894
11895         * gdbtypes.c (rank_one_type_parm_range): New function extracted
11896         from...
11897         (rank_one_type): ... this.
11898
11899 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11900
11901         * gdbtypes.c (rank_one_type_parm_char): New function extracted
11902         from...
11903         (rank_one_type): ... this.
11904
11905 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11906
11907         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
11908         from...
11909         (rank_one_type): ... this.
11910
11911 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11912
11913         * gdbtypes.c (rank_one_type_parm_int): New function extracted
11914         from...
11915         (rank_one_type): ... this.
11916
11917 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11918
11919         * gdbtypes.c (rank_one_type_parm_func): New function extracted
11920         from...
11921         (rank_one_type): ... this.
11922
11923 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11924
11925         * gdbtypes.c (rank_one_type_parm_array): New function extracted
11926         from...
11927         (rank_one_type): ... this.
11928
11929 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11930
11931         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
11932         from...
11933         (rank_one_type): ... this.
11934
11935 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11936
11937         * inferior.c (initialize_inferiors): Ensure 'help set/show print
11938         inferior-events' shows the example events.
11939
11940 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
11941
11942         Support styling on native MS-Windows console
11943
11944         PR/24315
11945         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
11946         on MS-Windows if $TERM is not defined.
11947
11948         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
11949
11950         * posix-hdep.c (gdb_console_fputs):
11951         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
11952         functions.
11953         * ui-file.h (gdb_console_fputs): Add prototype.
11954
11955         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
11956         back to fputs only if the former returns zero.
11957
11958 2019-03-07  Tom Tromey  <tom@tromey.com>
11959
11960         * symmisc.c (print_symbol_bcache_statistics): Update.
11961         (print_objfile_statistics): Update.
11962         * symfile.c (allocate_symtab): Update.
11963         * stabsread.c: Don't include bcache.h.
11964         * psymtab.h (struct psymbol_bcache): Don't declare.
11965         (class psymtab_storage) <psymbol_cache>: Now a bcache.
11966         (psymbol_bcache_init, psymbol_bcache_free)
11967         (psymbol_bcache_get_bcache): Don't declare.
11968         * psymtab.c (struct psymbol_bcache): Remove.
11969         (psymtab_storage::psymtab_storage): Update.
11970         (psymtab_storage::~psymtab_storage): Update.
11971         (psymbol_bcache_init, psymbol_bcache_free)
11972         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
11973         (add_psymbol_to_bcache): Update.
11974         (allocate_psymtab): Update.
11975         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
11976         macro_cache>: No longer pointers.
11977         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
11978         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
11979         * macrotab.c (macro_bcache): Update.
11980         * macroexp.c: Don't include bcache.h.
11981         * gdbtypes.c (check_types_worklist): Update.
11982         (types_deeply_equal): Remove TRY/CATCH.  Update.
11983         * elfread.c (elf_symtab_read): Update.
11984         * dwarf2read.c: Don't include bcache.h.
11985         * buildsym.c (buildsym_compunit::get_macro_table): Update.
11986         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
11987         (print_bcache_statistics, bcache_memory_used): Don't declare.
11988         (struct bcache): Move from bcache.c.  Add constructor, destructor,
11989         methods.  Rename all data members.
11990         * bcache.c (struct bcache): Move to bcache.h.
11991         (bcache::expand_hash_table): Rename from expand_hash_table.
11992         (bcache): Remove.
11993         (bcache::insert): Rename from bcache_full.
11994         (bcache::compare): Rename from bcache_compare.
11995         (bcache_xmalloc): Remove.
11996         (bcache::~bcache): Rename from bcache_xfree.
11997         (bcache::print_statistics): Rename from print_bcache_statistics.
11998         (bcache::memory_used): Rename from bcache_memory_used.
11999
12000 2019-03-07  Pedro Alves  <palves@redhat.com>
12001
12002         * infrun.c (normal_stop): Also check for
12003         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
12004
12005 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
12006
12007         * f-lang.c (value_from_host_double): Moved to...
12008         * value.c (value_from_host_double): ...here.
12009         * value.h (value_from_host_double): Declare.
12010         * guile/scm-math.c (vlscm_convert_typed_number): Use
12011         value_from_host_double.
12012         (vlscm_convert_number): Likewise.
12013         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
12014         * python/py-value.c (convert_value_from_python): Likewise.
12015
12016 2019-03-06  Tom Tromey  <tom@tromey.com>
12017
12018         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
12019
12020 2019-03-06  Tom Tromey  <tom@tromey.com>
12021
12022         * utils.h (free_current_contents): Don't declare.
12023         * utils.c (free_current_contents): Remove.
12024
12025 2019-03-06  Tom Tromey  <tom@tromey.com>
12026
12027         * top.c (quit_force): Update.
12028         * main.c (captured_command_loop): Update.
12029         * common/new-op.c (operator new): Update.
12030         * common/common-exceptions.c (struct catcher)
12031         <save_cleanup_chain>: Remove member.
12032         (exceptions_state_mc_init): Update.
12033         (exception_try_scope_entry): Return nullptr.
12034         (exception_try_scope_exit, exception_rethrow)
12035         (throw_exception_sjlj, throw_exception_cxx): Update.
12036         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
12037         (all_cleanups, do_cleanups, discard_cleanups)
12038         (discard_final_cleanups, save_cleanups, save_final_cleanups)
12039         (restore_cleanups, restore_final_cleanups): Don't declare.
12040         (do_final_cleanups): Remove parameter.
12041         * common/cleanups.c (cleanup_chain, make_cleanup)
12042         (make_cleanup_dtor, all_cleanups, do_cleanups)
12043         (discard_my_cleanups, discard_cleanups)
12044         (discard_final_cleanups, save_my_cleanups, save_cleanups)
12045         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
12046         (null_cleanup): Remove.
12047         (do_final_cleanups): Remove parameter.
12048
12049 2019-03-06  Tom Tromey  <tom@tromey.com>
12050
12051         * remote.c (remote_target::remote_parse_stop_reply): Use
12052         unique_xmalloc_ptr.
12053
12054 2019-03-06  Tom Tromey  <tom@tromey.com>
12055
12056         * stabsread.c (struct stabs_field_info): Rename from field_info.
12057         <list, fnlist>: Add initializers.
12058         <obstack>: New member.
12059         (read_member_functions, read_struct_fields, read_baseclasses):
12060         Allocate on obstack.  Don't use cleanups.
12061         (read_one_struct_field, read_member_functions, read_struct_fields)
12062         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
12063         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
12064         (read_struct_type): Update.
12065
12066 2019-03-06  Tom Tromey  <tom@tromey.com>
12067
12068         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
12069         * common/filestuff.h (make_cleanup_close): Don't declare.
12070         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
12071         Remove.
12072
12073 2019-03-06  Tom Tromey  <tom@tromey.com>
12074
12075         * solib-aix.c: Use make_scope_exit.
12076
12077 2019-03-06  Tom Tromey  <tom@tromey.com>
12078
12079         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
12080         Use make_scope_exit.
12081
12082 2019-03-06  Tom Tromey  <tom@tromey.com>
12083
12084         * solib-svr4.c (disable_probes_interface): Remove parameter.
12085         (svr4_handle_solib_event): Use make_scope_exit.
12086
12087 2019-03-06  Tom Tromey  <tom@tromey.com>
12088
12089         * remote.c (struct stop_reply_deleter): Remove.
12090         (stop_reply_up): Update.
12091         (struct stop_reply): Derive from notif_event.  Don't typedef.
12092         <regcache>: Now a std::vector.
12093         (stop_reply_xfree): Remove.
12094         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
12095         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
12096         (remote_target::discard_pending_stop_replies): Use delete.
12097         (remote_target::remote_parse_stop_reply): Update.
12098         (remote_target::process_stop_reply): Update.
12099         * remote-notif.h (struct notif_event): Add virtual destructor.
12100         Remove "dtr" member.
12101         (struct notif_client) <alloc_event>: Return a unique_ptr.
12102         (notif_event_xfree): Don't declare.
12103         (notif_event_up): New typedef.
12104         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
12105         (notif_event_xfree, do_notif_event_xfree): Remove.
12106         (remote_notif_state_xfree): Update.
12107
12108 2019-03-06  Tom Tromey  <tom@tromey.com>
12109
12110         * infrun.c (displaced_step_clear_cleanup): Now a
12111         forward_scope_exit type.
12112         (displaced_step_prepare_throw): Update.
12113         (displaced_step_fixup): Update.
12114
12115 2019-03-06  Tom Tromey  <tom@tromey.com>
12116
12117         * inferior.h (class inferior): Update comment.
12118         * gdbthread.h (class thread_info): Update comment.
12119
12120 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
12121             Tom Tromey  <tom@tromey.com>
12122
12123         * stabsread.h (struct stab_section_list): Remove.
12124         (coffstab_build_psymtabs): Update.
12125         * dbxread.c (symbuf_sections): Now a std::vector.
12126         (sect_idx): New global.
12127         (fill_symbuf): Update.
12128         (coffstab_build_psymtabs): Change type of stabsects parameter.
12129         Update.
12130         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
12131         std::vector.
12132         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
12133         (coff_locate_sections): Update.
12134         (coff_symfile_read): Remove cleanups.  Update.
12135         (init_stringtab): Add storage parameter.
12136         (free_stringtab, free_stringtab_cleanup): Remove.
12137         (init_lineno): Add storage parameter.
12138         (free_linetab, free_linetab_cleanup): Remove.
12139
12140 2019-03-06  Pedro Alves  <palves@redhat.com>
12141
12142         * linux-fork.c (fork_info::clobber_regs): Delete.
12143         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
12144         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
12145         comment.  Adjust.
12146         (scoped_switch_fork_info::scoped_switch_fork_info)
12147         (checkpoint_command, linux_fork_context): Adjust
12148         fork_save_infrun_state calls.
12149
12150 2019-03-06  Pedro Alves  <palves@redhat.com>
12151
12152         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
12153         (inf_has_multiple_threads): Return 'bool' and rewrite using
12154         inferior_info::threads().
12155
12156 2019-03-06  Pedro Alves  <palves@redhat.com>
12157
12158         * linux-fork.c: Include <list>.
12159         (fork_list): Now a std::list instance.
12160         (fork_info): Add ctor, dtor, and in-class initialize all fields.
12161         (forks_exist_p, find_last_fork): Adjust.
12162         (new_fork): Delete.
12163         (one_fork_p): New.
12164         (add_fork): Adjust.
12165         (free_fork): Delete, folded into fork_info::~fork_info().
12166         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
12167         Adjust.
12168         (init_fork_list): Delete.
12169         (linux_fork_killall, linux_fork_mourn_inferior)
12170         (linux_fork_detach, info_checkpoints_command): Adjust.
12171         (_initialize_linux_fork): No longer call init_fork_list.
12172
12173 2019-03-06  Pedro Alves  <palves@redhat.com>
12174
12175         * linux-fork.c (new_fork): New, split out of ...
12176         (add_fork): ... this.  Return void.  Move "first fork" special
12177         case from here, to ...
12178         (checkpoint_command): ... here.
12179         * linux-linux.h (add_fork): Return void.
12180
12181 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
12182
12183         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
12184
12185 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
12186             Chris January  <chris.january@arm.com>
12187             David Lecomber  <david.lecomber@arm.com>
12188
12189         * f-exp.y: New token, UNOP_INTRINSIC.
12190         (exp): New pattern using UNOP_INTRINSIC token.
12191         (f77_keywords): Add 'abs' keyword.
12192         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
12193         (value_from_host_double): New function.
12194         (evaluate_subexp_f): Support UNOP_ABS.
12195
12196 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
12197
12198         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
12199         types.
12200
12201 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
12202
12203         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
12204         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
12205         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
12206
12207 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
12208
12209         * f-exp.y (convert_to_kind_type): Handle more type kinds.
12210
12211 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
12212             Chris January  <chris.january@arm.com>
12213
12214         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
12215         * f-exp.y: Define 'KIND' token.
12216         (exp): New pattern for KIND expressions.
12217         (ptype): Handle types with a kind extension.
12218         (direct_abs_decl): Extend to spot kind extensions.
12219         (f77_keywords): Add 'kind' to the list.
12220         (push_kind_type): New function.
12221         (convert_to_kind_type): New function.
12222         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
12223         * parse.c (operator_length_standard): Likewise.
12224         * parser-defs.h (enum type_pieces): Add tp_kind.
12225         * std-operator.def: Add UNOP_KIND.
12226
12227 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
12228
12229         * f-exp.y (f_parse): Set yydebug.
12230
12231 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
12232
12233         * f-lang.c (evaluate_subexp_f): New function.
12234         (exp_descriptor_f): New global.
12235         (f_language_defn): Use exp_descriptor_f instead of
12236         exp_descriptor_standard.
12237
12238 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
12239
12240         * f-exp.y (struct token): Add comments.
12241         (dot_ops): Remove uppercase versions and the end marker.
12242         (f77_keywords): Likewise.
12243         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
12244         entries in the dot_ops array are case insensitive, and use
12245         strncasecmp to compare strings.  Also some whitespace cleanup in
12246         this area.  Similar for the f77_keywords array, except entries in
12247         this list might be case sensitive.
12248
12249 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
12250
12251         * f-exp.y (struct f77_boolean_val): Add comments.
12252         (boolean_values): Remove uppercase versions, and end marker.
12253         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
12254         and use strncasecmp to achieve case insensitivity.  Additionally,
12255         perform whitespace cleanup around this code.
12256
12257 2019-03-06  Tom Tromey  <tromey@adacore.com>
12258
12259         * remote-sim.c (gdbsim_target_open): Use result of
12260         gdb_argv::release.
12261
12262 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
12263         Dirk Schubert  <dirk.schubert@arm.com>
12264         Chris January  <chris.january@arm.com>
12265
12266         * eval.c (evaluate_subexp_standard): Call Fortran argument
12267         wrapping logic.
12268         * f-lang.c (struct value): A value which can be passed into a
12269         Fortran function call.
12270         (fortran_argument_convert): Wrap Fortran arguments in a pointer
12271         where appropriate.
12272         (struct type): Value ready for a Fortran function call.
12273         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
12274         is needed.
12275         * f-lang.h (fortran_argument_convert): Declaration.
12276         (fortran_preserve_arg_pointer): Declaration.
12277         * infcall.c (value_arg_coerce): Call Fortran argument logic.
12278
12279 2019-03-05  Tom Tromey  <tromey@adacore.com>
12280
12281         * python/py-prettyprint.c (print_string_repr): Remove #if.
12282         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
12283
12284 2019-03-05  Tom Tromey  <tromey@adacore.com>
12285
12286         * target.c (the_dummy_target): Move later.  Change type to
12287         "dummy_target".
12288         (initialize_targets): Don't initialize the_dummy_target.
12289
12290 2019-03-05  Tom Tromey  <tromey@adacore.com>
12291
12292         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
12293         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
12294
12295 2019-03-05  Tom Tromey  <tromey@adacore.com>
12296
12297         * windows-nat.c (windows_nat_target::attach)
12298         (windows_nat_target::detach): Don't call gdb_flush.
12299         * valprint.c (generic_val_print, val_print, val_print_string):
12300         Don't call gdb_flush.
12301         * utils.c (defaulted_query): Don't call gdb_flush.
12302         * typeprint.c (print_type_scalar): Don't call gdb_flush.
12303         * target.c (target_announce_detach): Don't call gdb_flush.
12304         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
12305         * remote.c (extended_remote_target::attach): Don't call
12306         gdb_flush.
12307         * procfs.c (procfs_target::detach): Don't call gdb_flush.
12308         * printcmd.c (do_examine): Don't call gdb_flush.
12309         (info_display_command): Don't call gdb_flush.
12310         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
12311         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
12312         * memattr.c (info_mem_command): Don't call gdb_flush.
12313         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
12314         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
12315         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
12316         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
12317         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
12318         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
12319         (gnu_nat_target::detach): Don't call gdb_flush.
12320         * f-valprint.c (f_val_print): Don't call gdb_flush.
12321         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
12322         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
12323         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
12324         gdb_flush.
12325         * c-valprint.c (c_val_print): Don't call gdb_flush.
12326         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
12327
12328 2019-03-05  Tom Tromey  <tromey@adacore.com>
12329
12330         * varobj.c (update_dynamic_varobj_children): Update.
12331         (install_default_visualizer): Use reset, not release.
12332         * value.c (set_internalvar): Update.
12333         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
12334         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
12335         ATTRIBUTE_UNUSED_RESULT.
12336
12337 2019-03-05  Tom Tromey  <tromey@adacore.com>
12338
12339         * remote.c (class scoped_remote_fd) <release>: Add
12340         ATTRIBUTE_UNUSED_RESULT.
12341
12342 2019-03-05  Tom Tromey  <tromey@adacore.com>
12343
12344         * macroexp.c (struct macro_buffer) <release>: Add
12345         ATTRIBUTE_UNUSED_RESULT.
12346
12347 2019-03-05  Tom Tromey  <tromey@adacore.com>
12348
12349         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
12350         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
12351         ATTRIBUTE_UNUSED_RESULT.
12352
12353 2019-03-05  Tom Tromey  <tromey@adacore.com>
12354
12355         * common/scoped_fd.h (class scoped_fd) <release>: Add
12356         ATTRIBUTE_UNUSED_RESULT.
12357
12358 2019-03-05  Tom Tromey  <tromey@adacore.com>
12359
12360         * parser-defs.h (struct parser_state) <release>: Add
12361         ATTRIBUTE_UNUSED_RESULT.
12362
12363 2019-03-05  Tom Tromey  <tromey@adacore.com>
12364
12365         * utils.h (class gdb_argv) <release>: Add
12366         ATTRIBUTE_UNUSED_RESULT.
12367         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
12368
12369 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
12370
12371         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
12372         for-loop range, to avoid compiler warnings.
12373
12374         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
12375         avoid compiler warnings about unused variables.
12376
12377         * NEWS: Mention end of support for native debugging on MS-Windows
12378         before XP.
12379
12380         PR gdb/24292
12381         * common/netstuff.c:
12382         * gdbserver/gdbreplay.c
12383         * gdbserver/remote-utils.c:
12384         * ser-tcp.c:
12385         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
12386         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
12387         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
12388         'getaddrinfo' and 'freeaddrinfo' were not available before
12389         Windows XP, and mingw.org's MinGW headers by default define
12390         _WIN32_WINNT to 0x500.
12391
12392 2019-03-01  Gary Benson <gbenson@redhat.com>
12393
12394         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
12395
12396 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
12397             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
12398
12399         PR gdb/8527
12400         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
12401         set_sigint_trap, clear_sigint_trap.
12402
12403 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12404
12405         * target.c (target_detach): Clear the regcache and the
12406         frame cache.
12407
12408 2019-02-27  Pedro Alves  <palves@redhat.com>
12409
12410         * utils.c (set_screen_size): When we cap the height/width sizes,
12411         tweak the corresponding command variable to show "unlimited":
12412
12413 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
12414             Pedro Alves  <palves@redhat.com>
12415
12416         * utils.c (set_screen_size): Reduce "infinite" rows and columns
12417         before calling rl_set_screen_size.
12418
12419 2019-02-27  Tom Tromey  <tromey@adacore.com>
12420
12421         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
12422         define.
12423         * python/py-value.c: Remove Python 2.4 workaround.
12424         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
12425         workaround.
12426         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
12427         Python 2.4 workaround.
12428         * python/python-internal.h: Remove Python 2.4 comment.
12429         (Py_ssize_t): Don't define.
12430         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
12431         (gdb_Py_DECREF): Remove Python 2.4 workaround.
12432         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
12433         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
12434         * python/python.c (do_start_initialization): Remove Python 2.4
12435         workaround.
12436         * python/py-prettyprint.c (class dummy_python_frame): Remove.
12437         (print_children): Remove Python 2.4 workaround.
12438         * python/py-inferior.c (buffer_procs): Remove Python 2.4
12439         workaround.
12440         (CHARBUFFERPROC_NAME): Remove.
12441         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
12442         Python 2.4 workaround.
12443
12444 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
12445
12446         * NEWS: Note minimum Python version.
12447
12448 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
12449
12450         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
12451         code from these functions.  Remove corresponding ifdefs.  Use
12452         Py_buffer_up instead of explicit calls to PyBuffer_Release.
12453         Remove gotos and target of gotos.
12454         (infpy_search_memory): Likewise.
12455
12456 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12457
12458         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
12459         (hppa_gdbarch_init): Don't register deleted functions with
12460         gdbarch.
12461
12462 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12463
12464         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
12465         (h8300_unwind_sp): Delete.
12466         (h8300_dummy_id): Delete.
12467         (h8300_gdbarch_init): Don't register deleted functions with
12468         gdbarch.
12469
12470 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12471
12472         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
12473         (ft32_unwind_pc): Delete.
12474         (ft32_unwind_sp): Delete.
12475         (ft32_gdbarch_init): Don't register deleted functions with
12476         gdbarch.
12477
12478 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12479
12480         * gdb/frv-tdep.c (frv_dummy_id): Delete.
12481         (frv_unwind_pc): Delete.
12482         (frv_unwind_sp): Delete.
12483         (frv_gdbarch_init): Don't register deleted functions with
12484         gdbarch.
12485
12486 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12487
12488         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
12489         (riscv_unwind_pc): Delete.
12490         (riscv_unwind_sp): Delete.
12491         (riscv_gdbarch_init): Don't register deleted functions with
12492         gdbarch.
12493
12494 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12495
12496         * gdb/csky-tdep.c (csky_dummy_id): Delete.
12497         (csky_unwind_pc): Delete.
12498         (csky_unwind_sp): Delete.
12499         (csky_gdbarch_init): Don't register deleted functions with
12500         gdbarch.
12501
12502 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12503
12504         * gdb/cris-tdep.c (cris_dummy_id): Delete.
12505         (cris_unwind_pc): Delete.
12506         (cris_unwind_sp): Delete.
12507         (cris_gdbarch_init): Don't register deleted functions with
12508         gdbarch.
12509
12510 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12511
12512         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
12513         (bfin_unwind_pc): Delete.
12514         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
12515
12516 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12517
12518         * gdb/arm-tdep.c (arm_dummy_id): Delete.
12519         (arm_unwind_pc): Delete.
12520         (arm_unwind_sp): Delete.
12521         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
12522
12523 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12524
12525         * gdb/arc-tdep.c (arc_dummy_id): Delete.
12526         (arc_unwind_pc): Delete.
12527         (arc_unwind_sp): Delete.
12528         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
12529
12530 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12531
12532         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
12533         (alpha_unwind_pc): Delete.
12534         (alpha_gdbarch_init): Don't register deleted functions with
12535         gdbarch.
12536
12537 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12538
12539         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
12540         (aarch64_unwind_pc): Delete.
12541         (aarch64_unwind_sp): Delete.
12542         (aarch64_gdbarch_init): Don't register deleted functions with
12543         gdbarch.
12544
12545 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12546
12547         * gdbtypes.c (type_align): Don't consider static members when
12548         computing structure alignment.
12549
12550 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12551
12552         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
12553         return 0 for other types.
12554         * arch-utils.c (default_type_align): Always return 0.
12555         * gdbarch.h: Regenerate.
12556         * gdbarch.sh (type_align): Extend comment.
12557         * gdbtypes.c (type_align): Add additional comments, always call
12558         gdbarch_type_align before applying the default rules.
12559         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
12560         generic code will then apply a suitable default.
12561         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
12562         types, return 0 for other types.
12563
12564 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
12565
12566         * NEWS: Create a new section for the next release branch.
12567         Rename the section of the current branch, now that it has
12568         been cut.
12569
12570 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
12571
12572         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
12573         * version.in: Bump version to 8.3.50.DATE-git.
12574
12575 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
12576
12577         * aix-thread.c (ptid_cmp): Remove unused variable.
12578         (get_signaled_thread): Likewise.
12579         (store_regs_user_thread): Likewise.
12580         (store_regs_kernel_thread): Likewise.
12581         (fetch_regs_kernel_thread): Remove shadowed variable.
12582
12583 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
12584
12585         * features/riscv/32bit-cpu.xml: Add register numbers.
12586         * features/riscv/32bit-fpu.c: Regenerate.
12587         * features/riscv/32bit-fpu.xml: Add register numbers.
12588         * features/riscv/64bit-cpu.xml: Add register numbers.
12589         * features/riscv/64bit-fpu.c: Regenerate.
12590         * features/riscv/64bit-fpu.xml: Add register numbers.
12591
12592 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
12593
12594         * NEWS: Mention two argument form of gdb.Value constructor.
12595         * python/py-value.c (convert_buffer_and_type_to_value): New
12596         function.
12597         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
12598         Add support for handling an optional second argument.  Call
12599         convert_buffer_and_type_to_value as appropriate.
12600         * python/python-internal.h (Py_buffer_deleter): New struct.
12601         (Py_buffer_up): New typedef.
12602
12603 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
12604
12605         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
12606         instead of releasing ownership.
12607
12608 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
12609
12610         * dwarf2read.c (open_and_init_dwp_file): Call
12611         elf_numsections instead of bfd_count_sections to initialize
12612         dwp_file->num_sections.
12613
12614 2019-02-25  Tom Tromey  <tromey@adacore.com>
12615
12616         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
12617
12618 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
12619
12620         * gcore.in: Add '--readnever' option when invoking GDB.
12621
12622 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
12623
12624         * MAINTAINERS: Update my email address.
12625
12626 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
12627
12628         * build-id.c (build_id_to_debug_bfd_1): New function.
12629         (build_id_to_debug_bfd): Look for separate debug file in
12630         sysroot.
12631
12632 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
12633
12634         * gdbarch.sh: Update the copyright year range that is placed into
12635         generated files.
12636
12637 2019-02-22  Keith Seitz  <keiths@redhat.com>
12638
12639         PR symtab/23853
12640         * linespec.c (create_sals_line_offset): Search for the default
12641         symtab's filename instead of its fullname.
12642
12643 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
12644
12645         * NEWS: Update style defaults.
12646
12647 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
12648
12649         * main.c (captured_main_1): Disable styling in batch mode.
12650
12651 2019-02-20  Tom Tromey  <tom@tromey.com>
12652
12653         * symtab.c (symtab_symbol_info): Fix typos.
12654
12655 2019-02-20  Tom Tromey  <tromey@adacore.com>
12656
12657         * findcmd.c (_initialize_mem_search): Use upper case for
12658         metasyntactic variables.
12659
12660 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
12661
12662         * aarch64-tdep.c (aarch64_add_reggroups): New function.
12663         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
12664
12665 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
12666
12667         * top.h (source_file_name): Change to std::string.
12668         * top.c (source_file_name): Likewise.
12669         (command_line_input): Adjust.
12670         * cli/cli-script.c (script_from_file): Adjust.
12671
12672 2019-02-19  Tom Tromey  <tromey@adacore.com>
12673
12674         * ravenscar-thread.c
12675         (ravenscar_thread_target::update_thread_list): Don't call
12676         ada_build_task_list.
12677         * ada-lang.h (ada_build_task_list): Don't declare.
12678         * ada-tasks.c (struct ada_tasks_inferior_data)
12679         <task_list_valid_p>: Now bool.
12680         (read_known_tasks, ada_task_list_changed)
12681         (ada_tasks_invalidate_inferior_data): Update.
12682         (read_known_tasks_array): Return bool.
12683         (read_known_tasks_list): Likewise.
12684         (read_known_tasks): Return void.
12685         (ada_build_task_list): Now static.
12686
12687 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
12688
12689         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
12690         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
12691
12692 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12693
12694         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
12695         variant for ada_tasks_pspace_data_handle and
12696         ada_tasks_inferior_data_handle.
12697         (ada_tasks_pspace_data_cleanup): New function.
12698         (ada_tasks_inferior_data_cleanup): New function.
12699
12700 2019-02-17  Tom Tromey  <tom@tromey.com>
12701
12702         * macrotab.h (macro_source_fullname): Return a std::string.
12703         * macrotab.c (macro_include, check_for_redefinition)
12704         (macro_undef, macro_lookup_definition, foreach_macro)
12705         (foreach_macro_in_scope): Update.
12706         (macro_source_fullname): Return a std::string.
12707         * macrocmd.c (show_pp_source_pos): Update.
12708
12709 2019-02-17  Tom Tromey  <tom@tromey.com>
12710
12711         * macrocmd.c (show_pp_source_pos): Style the file names.
12712
12713 2019-02-17  Tom Tromey  <tom@tromey.com>
12714
12715         PR tui/24197:
12716         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
12717
12718 2019-02-17  Tom Tromey  <tom@tromey.com>
12719
12720         * ada-lang.c (user_select_syms): Use filtered printing.
12721         * utils.c (wrap_style): New global.
12722         (desired_style): Remove.
12723         (emit_style_escape): Add stream parameter.
12724         (set_output_style, reset_terminal_style, prompt_for_continue):
12725         Update.
12726         (flush_wrap_buffer): Only flush gdb_stdout.
12727         (wrap_here): Set wrap_style.
12728         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
12729         treat escape sequences as a character.  Change when wrap buffer is
12730         flushed.
12731         (fputs_styled): Do not set the output style when the default is
12732         requested.
12733         * ui-style.h (struct ui_file_style) <is_default>: New method.
12734         * source.c (print_source_lines_base): Emit escape sequences in one
12735         piece.
12736
12737 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
12738
12739         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
12740         integers and enumeration types.
12741
12742 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
12743
12744         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
12745         instead of lookup_symbol_in_language
12746         (do_exact_match): New function.
12747         (ada_get_symbol_name_matcher): Return do_exact_match when
12748         doing a verbatim match.
12749
12750 2019-02-15  Tom Tromey  <tromey@adacore.com>
12751
12752         * ravenscar-thread.c (ravenscar_thread_target::resume)
12753         (ravenscar_thread_target::wait): Special case wildcard requests.
12754
12755 2019-02-15  Tom Tromey  <tromey@adacore.com>
12756
12757         * ravenscar-thread.c (base_ptid): Remove.
12758         (struct ravenscar_thread_target) <close>: New method.
12759         <m_base_ptid>: New member.
12760         <update_inferior_ptid, active_task, task_is_currently_active,
12761         runtime_initialized>: Declare methods.
12762         <ravenscar_thread_target>: Add constructor.
12763         (ravenscar_thread_target::task_is_currently_active)
12764         (ravenscar_thread_target::update_inferior_ptid)
12765         (ravenscar_runtime_initialized): Rename.  Now methods.
12766         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
12767         (ravenscar_thread_target::update_thread_list): Update.
12768         (ravenscar_thread_target::active_task): Now method.
12769         (ravenscar_thread_target::store_registers)
12770         (ravenscar_thread_target::prepare_to_store)
12771         (ravenscar_thread_target::prepare_to_store)
12772         (ravenscar_thread_target::mourn_inferior): Update.
12773         (ravenscar_inferior_created): Use "new" to create target.
12774         (ravenscar_thread_target::get_ada_task_ptid): Update.
12775         (_initialize_ravenscar): Don't initialize base_ptid.
12776         (ravenscar_ops): Remove global.
12777
12778 2019-02-15  Tom Tromey  <tromey@adacore.com>
12779
12780         * target.h (push_target): Declare new overload.
12781         * target.c (push_target): New overload, taking an rvalue reference.
12782         * remote.c (remote_target::open_1): Use push_target overload.
12783         * corelow.c (core_target_open): Use push_target overload.
12784
12785 2019-02-15  Tom Tromey  <tromey@adacore.com>
12786
12787         * ravenscar-thread.c (is_ravenscar_task)
12788         (ravenscar_task_is_currently_active): Return bool.
12789         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
12790         (_initialize_ravenscar): Remove "(void)".
12791         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
12792         Return bool.
12793
12794 2019-02-15  Tom Tromey  <tromey@adacore.com>
12795
12796         * ravenscar-thread.c (ravenscar_runtime_initializer)
12797         (has_ravenscar_runtime, get_running_thread_id)
12798         (ravenscar_thread_target::resume): Fix indentation.
12799
12800 2019-02-15  Tom Tromey  <tromey@adacore.com>
12801
12802         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
12803         from ravenscar_arch_ops.
12804         (sparc_ravenscar_ops::fetch_registers)
12805         (sparc_ravenscar_ops::store_registers): Now methods.
12806         (sparc_ravenscar_prepare_to_store): Remove.
12807         (sparc_ravenscar_ops): Redefine.
12808         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
12809         methods and destructor.  Remove members.
12810         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
12811         (ravenscar_thread_target::store_registers)
12812         (ravenscar_thread_target::prepare_to_store): Update.
12813         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
12814         Remove.
12815         (struct ppc_ravenscar_powerpc_ops): Derive from
12816         ravenscar_arch_ops.
12817         (ppc_ravenscar_powerpc_ops::fetch_registers)
12818         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
12819         (ppc_ravenscar_powerpc_ops): Redefine.
12820         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
12821         (ppc_ravenscar_e500_ops::fetch_registers)
12822         (ppc_ravenscar_e500_ops::store_registers): Now methods.
12823         (ppc_ravenscar_e500_ops): Redefine.
12824         * aarch64-ravenscar-thread.c
12825         (aarch64_ravenscar_generic_prepare_to_store): Remove.
12826         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
12827         (aarch64_ravenscar_fetch_registers)
12828         (aarch64_ravenscar_store_registers): Now methods.
12829         (aarch64_ravenscar_ops): Redefine.
12830
12831 2019-02-15  Tom Tromey  <tromey@adacore.com>
12832
12833         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
12834         (ravenscar_thread_target::stopped_by_hw_breakpoint)
12835         (ravenscar_thread_target::stopped_by_watchpoint)
12836         (ravenscar_thread_target::stopped_data_address)
12837         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
12838
12839 2019-02-15  Tom Tromey  <tromey@adacore.com>
12840
12841         * ravenscar-thread.c: Fix some typos.
12842
12843 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12844             Tom Tromey  <tromey@adacore.com>
12845
12846         * ada-lang.c (ada_exception_sal): Change addr_string to a
12847         std::string.
12848         (create_ada_exception_catchpoint): Update.
12849
12850 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12851             Tom Tromey  <tromey@adacore.com>
12852
12853         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
12854         (bp_location_ops): Remove.
12855         (base_breakpoint_allocate_location): Update.
12856         (free_bp_location): Update.
12857         * ada-lang.c (class ada_catchpoint_location)
12858         <ada_catchpoint_location>: Remove ops parameter.
12859         (ada_catchpoint_location_dtor): Remove.
12860         (ada_catchpoint_location_ops): Remove.
12861         (allocate_location_exception): Update.
12862         * breakpoint.h (struct bp_location_ops): Remove.
12863         (class bp_location) <bp_location>: Remove bp_location_ops
12864         parameter.
12865         <~bp_location>: Add destructor.
12866         <ops>: Remove.
12867
12868 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
12869             Pedro Alves  <palves@redhat.com>
12870
12871         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
12872         'PATH_MAX'.
12873
12874 2019-02-14  David Michael  <fedora.dm0@gmail.com>
12875             Samuel Thibault  <samuel.thibault@gnu.org>
12876             Thomas Schwinge  <thomas@codesourcery.com>
12877
12878         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
12879         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
12880
12881 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
12882
12883         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
12884         (check_empty): Use "const char *".
12885
12886         * gnu-nat.c (gnu_nat_target::detach): Instead of
12887         'detach_inferior (pid)' call
12888         'detach_inferior (find_inferior_pid (pid))'.
12889
12890         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
12891         'nat/fork-inferior.o'.
12892         * gnu-nat.c: #include "nat/fork-inferior.h".
12893
12894         * gnu-nat.c (gnu_nat_target::detach): Instead of
12895         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
12896         * gnu-nat.h: #include "inf-child.h".
12897         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
12898         'i386_gnu_nat_target::fetch_registers'.
12899         (gnu_store_registers): Rename/move to
12900         'i386_gnu_nat_target::store_registers'.
12901
12902         * config/i386/nm-i386gnu.h: Don't "#include" any files.
12903         * gnu-nat.h (mach_thread_info): New function.
12904         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
12905
12906         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
12907
12908 2019-02-14  Frederic Konrad  <konrad@adacore.com>
12909
12910         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
12911
12912 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
12913
12914         * windows-nat.c (windows_add_thread): Add new parameter
12915         "main_thread_p" with default value set to false.  Update
12916         function documentation as well as all callers.
12917         (windows_delete_thread): Likewise.
12918         (fake_create_process): Update call to windows_add_thread.
12919         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
12920         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
12921         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
12922         call to windows_delete_thread.
12923
12924 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
12925
12926         * MAINTAINERS: Add Andrew Burgess as global maintainer.
12927
12928 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
12929
12930         * symfile.c (find_separate_debug_file): Use canonical path of
12931         sysroot with child_path instead of gdb_sysroot if it is valid.
12932
12933 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
12934
12935         * symfile.c (find_separate_debug_file): Use child_path to
12936         determine if an object file is under a sysroot.
12937
12938 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
12939
12940         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
12941         unittests/child-path-selftests.c.
12942         * common/pathstuff.c (child_path): New function.
12943         * common/pathstuff.h (child_path): New prototype.
12944         * unittests/child-path-selftests.c: New file.
12945
12946 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
12947
12948         * symfile.c (find_separate_debug_file): Look for separate debug
12949         files in debug directories under the sysroot.
12950
12951 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12952
12953         * symtab.h (struct minimal_symbol data_p): New const method.
12954         (struct minimal_symbol text_p): Likewise.
12955         * symtab.c (output_source_filename): Use file name style
12956         to print file name.
12957         (print_symbol_info): Likewise.
12958         (print_msymbol_info): Use address style to print addresses.
12959         Use function name style to print executable text symbols.
12960         (expand_symtab_containing_pc): Use data_p.
12961         (find_pc_sect_compunit_symtab): Likewise.
12962
12963 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12964
12965         * breakpoint.c (describe_other_breakpoints): Use address style
12966         to print addresses.
12967         (say_where): Likewise.
12968
12969 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12970
12971         * ada-typeprint.c (print_func_type): Print function name
12972         style to print function name.
12973         * c-typeprint.c (c_print_type_1): Likewise.
12974
12975 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
12976
12977         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
12978         for execve.
12979
12980 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12981
12982         * c-exp.y (direct_abs_decl): Use emplace_back to record the
12983         type_stack.
12984
12985 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
12986
12987         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
12988         TYPE_CODE_REF types.
12989
12990 2019-02-08  Jim Wilson  <jimw@sifive.com>
12991
12992         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
12993         (riscv_linux_fregset): New.
12994         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
12995
12996 2019-02-07  Tom Tromey  <tom@tromey.com>
12997
12998         * thread.c (thread_cancel_execution_command): Update.
12999         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
13000         methods.
13001         (struct thread_fsm_ops): Remove.
13002         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
13003         (thread_fsm_should_stop, thread_fsm_return_value)
13004         (thread_fsm_set_finished, thread_fsm_finished_p)
13005         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
13006         Don't declare.
13007         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
13008         * infrun.c (clear_proceed_status_thread)
13009         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
13010         (print_stop_event): Update.
13011         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
13012         Add constructor.
13013         (step_command_fsm_ops): Remove.
13014         (new_step_command_fsm): Remove.
13015         (step_1): Update.
13016         (step_command_fsm::should_stop): Rename from
13017         step_command_fsm_should_stop.
13018         (step_command_fsm::clean_up): Rename from
13019         step_command_fsm_clean_up.
13020         (step_command_fsm::do_async_reply_reason): Rename from
13021         step_command_fsm_async_reply_reason.
13022         (struct until_next_fsm): Inherit from thread_fsm.  Add
13023         constructor.
13024         (until_next_fsm_ops): Remove.
13025         (new_until_next_fsm): Remove.
13026         (until_next_fsm::should_stop): Rename from
13027         until_next_fsm_should_stop.
13028         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
13029         (until_next_fsm::do_async_reply_reason): Rename from
13030         until_next_fsm_async_reply_reason.
13031         (struct finish_command_fsm): Inherit from thread_fsm.  Add
13032         constructor.  Change type of breakpoint.
13033         (finish_command_fsm_ops): Remove.
13034         (new_finish_command_fsm): Remove.
13035         (finish_command_fsm::should_stop): Rename from
13036         finish_command_fsm_should_stop.
13037         (finish_command_fsm::clean_up): Rename from
13038         finish_command_fsm_clean_up.
13039         (finish_command_fsm::return_value): Rename from
13040         finish_command_fsm_return_value.
13041         (finish_command_fsm::do_async_reply_reason): Rename from
13042         finish_command_fsm_async_reply_reason.
13043         (finish_command): Update.
13044         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
13045         Add constructor.
13046         (call_thread_fsm_ops): Remove.
13047         (call_thread_fsm::call_thread_fsm): Rename from
13048         new_call_thread_fsm.
13049         (call_thread_fsm::should_stop): Rename from
13050         call_thread_fsm_should_stop.
13051         (call_thread_fsm::should_notify_stop): Rename from
13052         call_thread_fsm_should_notify_stop.
13053         (run_inferior_call, call_function_by_hand_dummy): Update.
13054         * cli/cli-interp.c (should_print_stop_to_console): Update.
13055         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
13056         Add constructor.  Change type of location_breakpoint,
13057         caller_breakpoint.
13058         (until_break_fsm_ops): Remove.
13059         (new_until_break_fsm): Remove.
13060         (until_break_fsm::should_stop): Rename from
13061         until_break_fsm_should_stop.
13062         (until_break_fsm::clean_up): Rename from
13063         until_break_fsm_clean_up.
13064         (until_break_fsm::do_async_reply_reason): Rename from
13065         until_break_fsm_async_reply_reason.
13066         (until_break_command): Update.
13067         * thread-fsm.c: Remove.
13068         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
13069
13070 2019-02-07  Tom Tromey  <tom@tromey.com>
13071
13072         * yy-remap.h: Add include guard.
13073         * xtensa-tdep.h: Add include guard.
13074         * xcoffread.h: Rename include guard.
13075         * varobj-iter.h: Add include guard.
13076         * tui/tui.h: Rename include guard.
13077         * tui/tui-winsource.h: Rename include guard.
13078         * tui/tui-wingeneral.h: Rename include guard.
13079         * tui/tui-windata.h: Rename include guard.
13080         * tui/tui-win.h: Rename include guard.
13081         * tui/tui-stack.h: Rename include guard.
13082         * tui/tui-source.h: Rename include guard.
13083         * tui/tui-regs.h: Rename include guard.
13084         * tui/tui-out.h: Rename include guard.
13085         * tui/tui-layout.h: Rename include guard.
13086         * tui/tui-io.h: Rename include guard.
13087         * tui/tui-hooks.h: Rename include guard.
13088         * tui/tui-file.h: Rename include guard.
13089         * tui/tui-disasm.h: Rename include guard.
13090         * tui/tui-data.h: Rename include guard.
13091         * tui/tui-command.h: Rename include guard.
13092         * tic6x-tdep.h: Add include guard.
13093         * target/waitstatus.h: Rename include guard.
13094         * target/wait.h: Rename include guard.
13095         * target/target.h: Rename include guard.
13096         * target/resume.h: Rename include guard.
13097         * target-float.h: Rename include guard.
13098         * stabsread.h: Add include guard.
13099         * rs6000-tdep.h: Add include guard.
13100         * riscv-fbsd-tdep.h: Add include guard.
13101         * regformats/regdef.h: Rename include guard.
13102         * record.h: Rename include guard.
13103         * python/python.h: Rename include guard.
13104         * python/python-internal.h: Rename include guard.
13105         * python/py-stopevent.h: Rename include guard.
13106         * python/py-ref.h: Rename include guard.
13107         * python/py-record.h: Rename include guard.
13108         * python/py-record-full.h: Rename include guard.
13109         * python/py-record-btrace.h: Rename include guard.
13110         * python/py-instruction.h: Rename include guard.
13111         * python/py-events.h: Rename include guard.
13112         * python/py-event.h: Rename include guard.
13113         * procfs.h: Add include guard.
13114         * proc-utils.h: Add include guard.
13115         * p-lang.h: Add include guard.
13116         * or1k-tdep.h: Rename include guard.
13117         * observable.h: Rename include guard.
13118         * nto-tdep.h: Rename include guard.
13119         * nat/x86-linux.h: Rename include guard.
13120         * nat/x86-linux-dregs.h: Rename include guard.
13121         * nat/x86-gcc-cpuid.h: Add include guard.
13122         * nat/x86-dregs.h: Rename include guard.
13123         * nat/x86-cpuid.h: Rename include guard.
13124         * nat/ppc-linux.h: Rename include guard.
13125         * nat/mips-linux-watch.h: Rename include guard.
13126         * nat/linux-waitpid.h: Rename include guard.
13127         * nat/linux-ptrace.h: Rename include guard.
13128         * nat/linux-procfs.h: Rename include guard.
13129         * nat/linux-osdata.h: Rename include guard.
13130         * nat/linux-nat.h: Rename include guard.
13131         * nat/linux-namespaces.h: Rename include guard.
13132         * nat/linux-btrace.h: Rename include guard.
13133         * nat/glibc_thread_db.h: Rename include guard.
13134         * nat/gdb_thread_db.h: Rename include guard.
13135         * nat/gdb_ptrace.h: Rename include guard.
13136         * nat/fork-inferior.h: Rename include guard.
13137         * nat/amd64-linux-siginfo.h: Rename include guard.
13138         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
13139         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
13140         * nat/aarch64-linux.h: Rename include guard.
13141         * nat/aarch64-linux-hw-point.h: Rename include guard.
13142         * mn10300-tdep.h: Add include guard.
13143         * mips-linux-tdep.h: Add include guard.
13144         * mi/mi-parse.h: Rename include guard.
13145         * mi/mi-out.h: Rename include guard.
13146         * mi/mi-main.h: Rename include guard.
13147         * mi/mi-interp.h: Rename include guard.
13148         * mi/mi-getopt.h: Rename include guard.
13149         * mi/mi-console.h: Rename include guard.
13150         * mi/mi-common.h: Rename include guard.
13151         * mi/mi-cmds.h: Rename include guard.
13152         * mi/mi-cmd-break.h: Rename include guard.
13153         * m2-lang.h: Add include guard.
13154         * location.h: Rename include guard.
13155         * linux-record.h: Rename include guard.
13156         * linux-nat.h: Add include guard.
13157         * linux-fork.h: Add include guard.
13158         * i386-darwin-tdep.h: Rename include guard.
13159         * hppa-linux-offsets.h: Add include guard.
13160         * guile/guile.h: Rename include guard.
13161         * guile/guile-internal.h: Rename include guard.
13162         * gnu-nat.h: Rename include guard.
13163         * gdb-stabs.h: Rename include guard.
13164         * frv-tdep.h: Add include guard.
13165         * f-lang.h: Add include guard.
13166         * event-loop.h: Add include guard.
13167         * darwin-nat.h: Rename include guard.
13168         * cp-abi.h: Rename include guard.
13169         * config/sparc/nm-sol2.h: Rename include guard.
13170         * config/nm-nto.h: Rename include guard.
13171         * config/nm-linux.h: Add include guard.
13172         * config/i386/nm-i386gnu.h: Rename include guard.
13173         * config/djgpp/nl_types.h: Rename include guard.
13174         * config/djgpp/langinfo.h: Rename include guard.
13175         * compile/gcc-cp-plugin.h: Add include guard.
13176         * compile/gcc-c-plugin.h: Add include guard.
13177         * compile/compile.h: Rename include guard.
13178         * compile/compile-object-run.h: Rename include guard.
13179         * compile/compile-object-load.h: Rename include guard.
13180         * compile/compile-internal.h: Rename include guard.
13181         * compile/compile-cplus.h: Rename include guard.
13182         * compile/compile-c.h: Rename include guard.
13183         * common/xml-utils.h: Rename include guard.
13184         * common/x86-xstate.h: Rename include guard.
13185         * common/version.h: Rename include guard.
13186         * common/vec.h: Rename include guard.
13187         * common/tdesc.h: Rename include guard.
13188         * common/selftest.h: Rename include guard.
13189         * common/scoped_restore.h: Rename include guard.
13190         * common/scoped_mmap.h: Rename include guard.
13191         * common/scoped_fd.h: Rename include guard.
13192         * common/safe-iterator.h: Rename include guard.
13193         * common/run-time-clock.h: Rename include guard.
13194         * common/refcounted-object.h: Rename include guard.
13195         * common/queue.h: Rename include guard.
13196         * common/ptid.h: Rename include guard.
13197         * common/print-utils.h: Rename include guard.
13198         * common/preprocessor.h: Rename include guard.
13199         * common/pathstuff.h: Rename include guard.
13200         * common/observable.h: Rename include guard.
13201         * common/netstuff.h: Rename include guard.
13202         * common/job-control.h: Rename include guard.
13203         * common/host-defs.h: Rename include guard.
13204         * common/gdb_wait.h: Rename include guard.
13205         * common/gdb_vecs.h: Rename include guard.
13206         * common/gdb_unlinker.h: Rename include guard.
13207         * common/gdb_unique_ptr.h: Rename include guard.
13208         * common/gdb_tilde_expand.h: Rename include guard.
13209         * common/gdb_sys_time.h: Rename include guard.
13210         * common/gdb_string_view.h: Rename include guard.
13211         * common/gdb_splay_tree.h: Rename include guard.
13212         * common/gdb_setjmp.h: Rename include guard.
13213         * common/gdb_ref_ptr.h: Rename include guard.
13214         * common/gdb_optional.h: Rename include guard.
13215         * common/gdb_locale.h: Rename include guard.
13216         * common/gdb_assert.h: Rename include guard.
13217         * common/filtered-iterator.h: Rename include guard.
13218         * common/filestuff.h: Rename include guard.
13219         * common/fileio.h: Rename include guard.
13220         * common/environ.h: Rename include guard.
13221         * common/common-utils.h: Rename include guard.
13222         * common/common-types.h: Rename include guard.
13223         * common/common-regcache.h: Rename include guard.
13224         * common/common-inferior.h: Rename include guard.
13225         * common/common-gdbthread.h: Rename include guard.
13226         * common/common-exceptions.h: Rename include guard.
13227         * common/common-defs.h: Rename include guard.
13228         * common/common-debug.h: Rename include guard.
13229         * common/cleanups.h: Rename include guard.
13230         * common/buffer.h: Rename include guard.
13231         * common/btrace-common.h: Rename include guard.
13232         * common/break-common.h: Rename include guard.
13233         * cli/cli-utils.h: Rename include guard.
13234         * cli/cli-style.h: Rename include guard.
13235         * cli/cli-setshow.h: Rename include guard.
13236         * cli/cli-script.h: Rename include guard.
13237         * cli/cli-interp.h: Rename include guard.
13238         * cli/cli-decode.h: Rename include guard.
13239         * cli/cli-cmds.h: Rename include guard.
13240         * charset-list.h: Add include guard.
13241         * buildsym-legacy.h: Rename include guard.
13242         * bfin-tdep.h: Add include guard.
13243         * ax.h: Rename include guard.
13244         * arm-linux-tdep.h: Add include guard.
13245         * arm-fbsd-tdep.h: Add include guard.
13246         * arch/xtensa.h: Rename include guard.
13247         * arch/tic6x.h: Add include guard.
13248         * arch/i386.h: Add include guard.
13249         * arch/arm.h: Rename include guard.
13250         * arch/arm-linux.h: Rename include guard.
13251         * arch/arm-get-next-pcs.h: Rename include guard.
13252         * arch/amd64.h: Add include guard.
13253         * arch/aarch64-insn.h: Rename include guard.
13254         * arch-utils.h: Rename include guard.
13255         * annotate.h: Add include guard.
13256         * amd64-darwin-tdep.h: Rename include guard.
13257         * aarch64-linux-tdep.h: Add include guard.
13258         * aarch64-fbsd-tdep.h: Add include guard.
13259         * aarch32-linux-nat.h: Add include guard.
13260
13261 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13262
13263         * macrotab.c (macro_define_internal): New function that
13264         factorizes macro_define_object_internal and macro_define_function
13265         code.
13266         (macro_define_object_internal): Use macro_define_internal.
13267         (macro_define_function): Likewise.
13268
13269 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13270
13271         * macrocmd.c (extract_identifier): Return
13272         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
13273         callers.
13274
13275 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
13276
13277         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
13278
13279 2019-02-05  Tom Tromey  <tom@tromey.com>
13280
13281         * target.c (target_stack::unpush): Move assertion earlier.
13282
13283 2019-01-30  Tom Tromey  <tom@tromey.com>
13284
13285         PR python/23615:
13286         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
13287         (gdbpy_parse_and_eval): Likewise.
13288         * python/python-internal.h (gdbpy_allow_threads): New class.
13289
13290 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
13291
13292         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
13293         (aarch64_fbsd_fpregmap): Move earlier.
13294         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
13295         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
13296         instead of individual calls to trad_frame_set_reg_addr.
13297         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
13298         earlier.
13299         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
13300         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
13301         instead of individual calls to trad_frame_set_reg_addr.
13302
13303 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
13304
13305         * CONTRIBUTE: Replace contribution list with wiki link.
13306
13307 2019-01-25  Tom Tromey  <tom@tromey.com>
13308
13309         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
13310
13311 2019-01-25  Tom Tromey  <tom@tromey.com>
13312
13313         * xtensa-linux-nat.c: Fix common/ includes.
13314         * xml-support.h: Fix common/ includes.
13315         * xml-support.c: Fix common/ includes.
13316         * x86-linux-nat.c: Fix common/ includes.
13317         * windows-nat.c: Fix common/ includes.
13318         * varobj.h: Fix common/ includes.
13319         * varobj.c: Fix common/ includes.
13320         * value.c: Fix common/ includes.
13321         * valops.c: Fix common/ includes.
13322         * utils.c: Fix common/ includes.
13323         * unittests/xml-utils-selftests.c: Fix common/ includes.
13324         * unittests/utils-selftests.c: Fix common/ includes.
13325         * unittests/unpack-selftests.c: Fix common/ includes.
13326         * unittests/tracepoint-selftests.c: Fix common/ includes.
13327         * unittests/style-selftests.c: Fix common/ includes.
13328         * unittests/string_view-selftests.c: Fix common/ includes.
13329         * unittests/scoped_restore-selftests.c: Fix common/ includes.
13330         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
13331         * unittests/scoped_fd-selftests.c: Fix common/ includes.
13332         * unittests/rsp-low-selftests.c: Fix common/ includes.
13333         * unittests/parse-connection-spec-selftests.c: Fix common/
13334         includes.
13335         * unittests/optional-selftests.c: Fix common/ includes.
13336         * unittests/offset-type-selftests.c: Fix common/ includes.
13337         * unittests/observable-selftests.c: Fix common/ includes.
13338         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
13339         * unittests/memrange-selftests.c: Fix common/ includes.
13340         * unittests/memory-map-selftests.c: Fix common/ includes.
13341         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
13342         * unittests/function-view-selftests.c: Fix common/ includes.
13343         * unittests/environ-selftests.c: Fix common/ includes.
13344         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
13345         * unittests/common-utils-selftests.c: Fix common/ includes.
13346         * unittests/cli-utils-selftests.c: Fix common/ includes.
13347         * unittests/array-view-selftests.c: Fix common/ includes.
13348         * ui-file.c: Fix common/ includes.
13349         * tui/tui-io.c: Fix common/ includes.
13350         * tracepoint.h: Fix common/ includes.
13351         * tracepoint.c: Fix common/ includes.
13352         * tracefile-tfile.c: Fix common/ includes.
13353         * top.h: Fix common/ includes.
13354         * top.c: Fix common/ includes.
13355         * thread.c: Fix common/ includes.
13356         * target/waitstatus.h: Fix common/ includes.
13357         * target/waitstatus.c: Fix common/ includes.
13358         * target.h: Fix common/ includes.
13359         * target.c: Fix common/ includes.
13360         * target-memory.c: Fix common/ includes.
13361         * target-descriptions.c: Fix common/ includes.
13362         * symtab.h: Fix common/ includes.
13363         * symfile.c: Fix common/ includes.
13364         * stap-probe.c: Fix common/ includes.
13365         * spu-linux-nat.c: Fix common/ includes.
13366         * sparc-nat.c: Fix common/ includes.
13367         * source.c: Fix common/ includes.
13368         * solib.c: Fix common/ includes.
13369         * solib-target.c: Fix common/ includes.
13370         * ser-unix.c: Fix common/ includes.
13371         * ser-tcp.c: Fix common/ includes.
13372         * ser-pipe.c: Fix common/ includes.
13373         * ser-base.c: Fix common/ includes.
13374         * selftest-arch.c: Fix common/ includes.
13375         * s12z-tdep.c: Fix common/ includes.
13376         * rust-exp.y: Fix common/ includes.
13377         * rs6000-aix-tdep.c: Fix common/ includes.
13378         * riscv-tdep.c: Fix common/ includes.
13379         * remote.c: Fix common/ includes.
13380         * remote-notif.h: Fix common/ includes.
13381         * remote-fileio.h: Fix common/ includes.
13382         * remote-fileio.c: Fix common/ includes.
13383         * regcache.h: Fix common/ includes.
13384         * regcache.c: Fix common/ includes.
13385         * record-btrace.c: Fix common/ includes.
13386         * python/python.c: Fix common/ includes.
13387         * python/py-type.c: Fix common/ includes.
13388         * python/py-inferior.c: Fix common/ includes.
13389         * progspace.h: Fix common/ includes.
13390         * producer.c: Fix common/ includes.
13391         * procfs.c: Fix common/ includes.
13392         * proc-api.c: Fix common/ includes.
13393         * printcmd.c: Fix common/ includes.
13394         * ppc-linux-nat.c: Fix common/ includes.
13395         * parser-defs.h: Fix common/ includes.
13396         * osdata.c: Fix common/ includes.
13397         * obsd-nat.c: Fix common/ includes.
13398         * nat/x86-linux.c: Fix common/ includes.
13399         * nat/x86-linux-dregs.c: Fix common/ includes.
13400         * nat/x86-dregs.h: Fix common/ includes.
13401         * nat/x86-dregs.c: Fix common/ includes.
13402         * nat/ppc-linux.c: Fix common/ includes.
13403         * nat/mips-linux-watch.h: Fix common/ includes.
13404         * nat/mips-linux-watch.c: Fix common/ includes.
13405         * nat/linux-waitpid.c: Fix common/ includes.
13406         * nat/linux-ptrace.h: Fix common/ includes.
13407         * nat/linux-ptrace.c: Fix common/ includes.
13408         * nat/linux-procfs.c: Fix common/ includes.
13409         * nat/linux-personality.c: Fix common/ includes.
13410         * nat/linux-osdata.c: Fix common/ includes.
13411         * nat/linux-namespaces.c: Fix common/ includes.
13412         * nat/linux-btrace.h: Fix common/ includes.
13413         * nat/linux-btrace.c: Fix common/ includes.
13414         * nat/fork-inferior.c: Fix common/ includes.
13415         * nat/amd64-linux-siginfo.c: Fix common/ includes.
13416         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
13417         * nat/aarch64-linux.c: Fix common/ includes.
13418         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
13419         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
13420         * namespace.h: Fix common/ includes.
13421         * mips-linux-tdep.c: Fix common/ includes.
13422         * minsyms.c: Fix common/ includes.
13423         * mi/mi-parse.h: Fix common/ includes.
13424         * mi/mi-main.c: Fix common/ includes.
13425         * mi/mi-cmd-env.c: Fix common/ includes.
13426         * memrange.h: Fix common/ includes.
13427         * memattr.c: Fix common/ includes.
13428         * maint.h: Fix common/ includes.
13429         * maint.c: Fix common/ includes.
13430         * main.c: Fix common/ includes.
13431         * machoread.c: Fix common/ includes.
13432         * location.c: Fix common/ includes.
13433         * linux-thread-db.c: Fix common/ includes.
13434         * linux-nat.c: Fix common/ includes.
13435         * linux-fork.c: Fix common/ includes.
13436         * inline-frame.c: Fix common/ includes.
13437         * infrun.c: Fix common/ includes.
13438         * inflow.c: Fix common/ includes.
13439         * inferior.h: Fix common/ includes.
13440         * inferior.c: Fix common/ includes.
13441         * infcmd.c: Fix common/ includes.
13442         * inf-ptrace.c: Fix common/ includes.
13443         * inf-child.c: Fix common/ includes.
13444         * ia64-linux-nat.c: Fix common/ includes.
13445         * i387-tdep.c: Fix common/ includes.
13446         * i386-tdep.c: Fix common/ includes.
13447         * i386-linux-tdep.c: Fix common/ includes.
13448         * i386-linux-nat.c: Fix common/ includes.
13449         * i386-go32-tdep.c: Fix common/ includes.
13450         * i386-fbsd-tdep.c: Fix common/ includes.
13451         * i386-fbsd-nat.c: Fix common/ includes.
13452         * guile/scm-type.c: Fix common/ includes.
13453         * guile/guile.c: Fix common/ includes.
13454         * go32-nat.c: Fix common/ includes.
13455         * gnu-nat.c: Fix common/ includes.
13456         * gdbthread.h: Fix common/ includes.
13457         * gdbarch-selftests.c: Fix common/ includes.
13458         * gdb_usleep.c: Fix common/ includes.
13459         * gdb_select.h: Fix common/ includes.
13460         * gdb_bfd.c: Fix common/ includes.
13461         * gcore.c: Fix common/ includes.
13462         * fork-child.c: Fix common/ includes.
13463         * findvar.c: Fix common/ includes.
13464         * fbsd-nat.c: Fix common/ includes.
13465         * event-top.c: Fix common/ includes.
13466         * event-loop.c: Fix common/ includes.
13467         * dwarf2read.c: Fix common/ includes.
13468         * dwarf2loc.c: Fix common/ includes.
13469         * dwarf2-frame.c: Fix common/ includes.
13470         * dwarf-index-cache.c: Fix common/ includes.
13471         * dtrace-probe.c: Fix common/ includes.
13472         * disasm-selftests.c: Fix common/ includes.
13473         * defs.h: Fix common/ includes.
13474         * csky-tdep.c: Fix common/ includes.
13475         * cp-valprint.c: Fix common/ includes.
13476         * cp-support.h: Fix common/ includes.
13477         * cp-support.c: Fix common/ includes.
13478         * corelow.c: Fix common/ includes.
13479         * completer.h: Fix common/ includes.
13480         * completer.c: Fix common/ includes.
13481         * compile/compile.c: Fix common/ includes.
13482         * compile/compile-loc2c.c: Fix common/ includes.
13483         * compile/compile-cplus-types.c: Fix common/ includes.
13484         * compile/compile-cplus-symbols.c: Fix common/ includes.
13485         * command.h: Fix common/ includes.
13486         * cli/cli-dump.c: Fix common/ includes.
13487         * cli/cli-cmds.c: Fix common/ includes.
13488         * charset.c: Fix common/ includes.
13489         * build-id.c: Fix common/ includes.
13490         * btrace.h: Fix common/ includes.
13491         * btrace.c: Fix common/ includes.
13492         * breakpoint.h: Fix common/ includes.
13493         * breakpoint.c: Fix common/ includes.
13494         * ax.h:
13495         (enum agent_op): Fix common/ includes.
13496         * ax-general.c (struct aop_map): Fix common/ includes.
13497         * ax-gdb.c: Fix common/ includes.
13498         * auxv.c: Fix common/ includes.
13499         * auto-load.c: Fix common/ includes.
13500         * arm-tdep.c: Fix common/ includes.
13501         * arch/riscv.c: Fix common/ includes.
13502         * arch/ppc-linux-common.c: Fix common/ includes.
13503         * arch/i386.c: Fix common/ includes.
13504         * arch/arm.c: Fix common/ includes.
13505         * arch/arm-linux.c: Fix common/ includes.
13506         * arch/arm-get-next-pcs.c: Fix common/ includes.
13507         * arch/amd64.c: Fix common/ includes.
13508         * arch/aarch64.c: Fix common/ includes.
13509         * arch/aarch64-insn.c: Fix common/ includes.
13510         * arch-utils.c: Fix common/ includes.
13511         * amd64-windows-tdep.c: Fix common/ includes.
13512         * amd64-tdep.c: Fix common/ includes.
13513         * amd64-sol2-tdep.c: Fix common/ includes.
13514         * amd64-obsd-tdep.c: Fix common/ includes.
13515         * amd64-nbsd-tdep.c: Fix common/ includes.
13516         * amd64-linux-tdep.c: Fix common/ includes.
13517         * amd64-linux-nat.c: Fix common/ includes.
13518         * amd64-fbsd-tdep.c: Fix common/ includes.
13519         * amd64-fbsd-nat.c: Fix common/ includes.
13520         * amd64-dicos-tdep.c: Fix common/ includes.
13521         * amd64-darwin-tdep.c: Fix common/ includes.
13522         * agent.c: Fix common/ includes.
13523         * ada-lang.h: Fix common/ includes.
13524         * ada-lang.c: Fix common/ includes.
13525         * aarch64-tdep.c: Fix common/ includes.
13526
13527 2019-01-25  Tom Tromey  <tom@tromey.com>
13528
13529         * common/create-version.sh: Use common/version.h.
13530
13531 2019-01-24  Pedro Alves  <palves@redhat.com>
13532
13533         * infrun.c (signal_stop, signal_print, signal_program)
13534         (signal_catch, signal_pass): Now arrays instead of pointers.
13535         (update_signals_program_target, do_target_resume)
13536         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
13537         * linux-nat.c (linux_nat_target::pass_signals)
13538         (linux_nat_target::create_inferior, linux_nat_target::attach):
13539         Adjust.
13540         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
13541         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
13542         * procfs.c (procfs_target::pass_signals): Adjust.
13543         * record-full.c (record_full_target::resume): Adjust.
13544         * remote.c (remote_target::pass_signals)
13545         (remote_target::program_signals): Adjust.
13546         * target-debug.h (target_debug_print_signals): Now takes a
13547         gdb::array_view as parameter.  Adjust.
13548         * target.h (target_ops) <pass_signals, program_signals>: Replace
13549         pointer and length parameters with gdb::array_view.
13550         (target_pass_signals, target_program_signals): Likewise.
13551         * target-delegates.c: Regenerate.
13552
13553 2019-01-24  Pedro Alves  <palves@redhat.com>
13554
13555         * common/forward-scope-exit.h
13556         (forward_scope_exit::forward_scope_exit): Pass arguments to
13557         m_bind_function directly, instead of creating a std::bind and
13558         copying that.
13559
13560 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
13561
13562         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
13563         for static members.
13564         (pass_in_v_vfp_candidate): Likewise.
13565
13566 2019-01-23  Tom Tromey  <tom@tromey.com>
13567             Pedro Alves  <palves@redhat.com>
13568
13569         * regcache.c (class regcache_invalidator): Remove.
13570         (regcache::raw_write): Use make_scope_exit.
13571
13572 2019-01-23  Tom Tromey  <tom@tromey.com>
13573
13574         * ui-out.h (class ui_out_emit_type): Update comment.
13575
13576 2019-01-23  Tom Tromey  <tom@tromey.com>
13577
13578         * infrun.c (fetch_inferior_event): Update comment.
13579
13580 2019-01-23  Tom Tromey  <tom@tromey.com>
13581             Pedro Alves  <palves@redhat.com>
13582
13583         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
13584         parameter.
13585         (fetch_inferior_event): Use SCOPE_EXIT.
13586
13587
13588 2019-01-23  Tom Tromey  <tom@tromey.com>
13589             Pedro Alves  <palves@redhat.com>
13590
13591         * infrun.c (disable_thread_events): Delete.
13592         (stop_all_threads): Use SCOPE_EXIT.
13593
13594 2019-01-23  Tom Tromey  <tom@tromey.com>
13595             Pedro Alves  <palves@redhat.com>
13596
13597         * symfile.c: Include forward-scope-exit.h.
13598         (clear_symtab_users_cleanup): Replace forward declaration with
13599         a FORWARD_SCOPE_EXIT.
13600         (syms_from_objfile_1): Use the forward_scope_exit and
13601         gdb::optional instead of cleanup_function.
13602         (reread_symbols): Use the forward_scope_exit instead of
13603         cleanup_function.
13604         (clear_symtab_users_cleanup): Remove function.
13605
13606 2019-01-23  Tom Tromey  <tom@tromey.com>
13607             Pedro Alves  <palves@redhat.com>
13608
13609         * linux-nat.c: Include scope-exit.h.
13610         (cleanup_target_stop): Remove.
13611         (linux_nat_target::static_tracepoint_markers_by_strid): Use
13612         SCOPE_EXIT.
13613
13614 2019-01-23  Tom Tromey  <tom@tromey.com>
13615             Pedro Alves  <palves@redhat.com>
13616
13617         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
13618         (call_function_by_hand_dummy): Use SCOPE_EXIT.
13619
13620 2019-01-23  Tom Tromey  <tom@tromey.com>
13621             Andrew Burgess  <andrew.burgess@embecosm.com>
13622             Pedro Alves  <palves@redhat.com>
13623
13624         * infrun.c (fetch_inferior_event): Use scope_exit.
13625         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
13626         * top.c (execute_command): Use scope_exit.
13627         * breakpoint.c (bpstat_do_actions): Use scope_exit.
13628         * utils.c (do_bpstat_clear_actions_cleanup)
13629         (make_bpstat_clear_actions_cleanup): Remove.
13630
13631 2019-01-23  Tom Tromey  <tom@tromey.com>
13632             Pedro Alves  <palves@redhat.com>
13633
13634         * infrun.c: Include "common/scope-exit.h"
13635         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
13636         (wait_for_inferior): Use SCOPE_EXIT.
13637         (fetch_inferior_event): Use scope_exit.
13638
13639 2019-01-23  Tom Tromey  <tom@tromey.com>
13640             Pedro Alves  <palves@redhat.com>
13641
13642         * breakpoint.c (create_breakpoint): Remove cleanup.
13643
13644 2019-01-23  Tom Tromey  <tom@tromey.com>
13645             Andrew Burgess  <andrew.burgess@embecosm.com>
13646             Pedro Alves  <palves@redhat.com>
13647
13648 2019-01-23  Pedro Alves  <palves@redhat.com>
13649
13650         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
13651
13652 2019-01-23  Pedro Alves  <palves@redhat.com>
13653             Andrew Burgess  <andrew.burgess@embecosm.com>
13654
13655         * gdbthread.h: Include "common/forward-scope-exit.h".
13656         (scoped_finish_thread_state): Redefine custom class in terms of
13657         forward_scope_exit.
13658
13659 2019-01-23  Pedro Alves  <palves@redhat.com>
13660             Andrew Burgess  <andrew.burgess@embecosm.com>
13661
13662         * common/forward-scope-exit.h: New file.
13663
13664 2019-01-23  Pedro Alves  <palves@redhat.com>
13665             Andrew Burgess  <andrew.burgess@embecosm.com>
13666             Tom Tromey  <tom@tromey.com>
13667
13668         * common/scope-exit.h: New file.
13669
13670 2019-01-23  Pedro Alves  <palves@redhat.com>
13671
13672         * common/preprocessor.h (ESC): Rename to ...
13673         (ESC_PARENS): ... this.
13674         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
13675         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
13676
13677 2019-01-23  Tom Tromey  <tom@tromey.com>
13678
13679         * language.h (class scoped_switch_to_sym_language_if_auto):
13680         Initialize m_lang in both cases.
13681
13682 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
13683
13684         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
13685         with XCNEW.
13686
13687 2019-01-22  Tom Tromey  <tom@tromey.com>
13688
13689         * corelow.c: Do not include sys/file.h.
13690
13691 2019-01-22  Tom Tromey  <tom@tromey.com>
13692
13693         * tui/tui-wingeneral.h: Include gdb_curses.h.
13694
13695 2019-01-22  Tom Tromey  <tom@tromey.com>
13696
13697         * source-cache.h (class source_cache) <get_source_lines,
13698         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
13699
13700 2019-01-22  Tom Tromey  <tom@tromey.com>
13701
13702         * remote-fileio.h (struct remote_target): Declare.
13703
13704 2019-01-22  Tom Tromey  <tom@tromey.com>
13705
13706         * python/py-arch.c: Do not include py-ref.h.
13707         * python/py-bpevent.c: Do not include py-ref.h.
13708         * python/py-cmd.c: Do not include py-ref.h.
13709         * python/py-continueevent.c: Do not include py-ref.h.
13710         * python/py-event.h: Do not include py-ref.h.
13711         * python/py-evtregistry.c: Do not include py-ref.h.
13712         * python/py-finishbreakpoint.c: Do not include py-ref.h.
13713         * python/py-frame.c: Do not include py-ref.h.
13714         * python/py-framefilter.c: Do not include py-ref.h.
13715         * python/py-function.c: Do not include py-ref.h.
13716         * python/py-infevents.c: Do not include py-ref.h.
13717         * python/py-linetable.c: Do not include py-ref.h.
13718         * python/py-objfile.c: Do not include py-ref.h.
13719         * python/py-param.c: Do not include py-ref.h.
13720         * python/py-prettyprint.c: Do not include py-ref.h.
13721         * python/py-progspace.c: Do not include py-ref.h.
13722         * python/py-symbol.c: Do not include py-ref.h.
13723         * python/py-symtab.c: Do not include py-ref.h.
13724         * python/py-type.c: Do not include py-ref.h.
13725         * python/py-unwind.c: Do not include py-ref.h.
13726         * python/py-utils.c: Do not include py-ref.h.
13727         * python/py-value.c: Do not include py-ref.h.
13728         * python/py-varobj.c: Do not include py-ref.h.
13729         * python/py-xmethods.c: Do not include py-ref.h.
13730         * python/python.c: Do not include py-ref.h.
13731         * varobj.c: Do not include py-ref.h.
13732
13733 2019-01-22  Tom Tromey  <tom@tromey.com>
13734
13735         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
13736         keyword for bcache.
13737
13738 2019-01-22  Tom Tromey  <tom@tromey.com>
13739
13740         * compile/compile-cplus-types.c: Remove a comment by #include.
13741
13742 2019-01-22  Tom Tromey  <tom@tromey.com>
13743
13744         * compile/gcc-c-plugin.h: Include compile-internal.h.
13745
13746 2019-01-22  Tom Tromey  <tom@tromey.com>
13747
13748         * stabsread.c (EXTERN): Do not define.
13749         (symnum, next_symbol_text_func, processing_gcc_compilation)
13750         (within_function, global_sym_chain, global_stabs)
13751         (previous_stab_code, this_object_header_files)
13752         (n_this_object_header_files)
13753         (n_allocated_this_object_header_files): Define.
13754         * stabsread.h (EXTERN): Never define.  Use "extern".
13755
13756 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13757
13758         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
13759         history_value.
13760
13761 2019-01-21  Tom Tromey  <tom@tromey.com>
13762
13763         * ui-out.c: Fix includes.
13764         * tui/tui-source.c: Fix includes.
13765         * target.c: Fix includes.
13766         * remote.c: Fix includes.
13767         * regcache.c: Fix includes.
13768         * python/py-block.c: Fix includes.
13769         * printcmd.c: Fix includes.
13770         * or1k-tdep.c: Fix includes.
13771         * mi/mi-main.c: Fix includes.
13772         * m32r-tdep.c: Fix includes.
13773         * csky-tdep.c: Fix includes.
13774         * compile/compile-cplus-types.c: Fix includes.
13775         * cli/cli-interp.c: Fix includes.
13776
13777 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
13778
13779         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
13780         for padding.
13781
13782 2019-01-16  Tom Tromey  <tom@tromey.com>
13783
13784         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
13785         earlier.
13786         (struct objfile) <msymbols_range>: Move from top level.
13787         <msymbols>: New method.
13788         (class objfile_msymbols): Remove.
13789         * symtab.c (default_collect_symbol_completion_matches_break_on):
13790         Update.
13791         * symmisc.c (dump_msymbols): Update.
13792         * stabsread.c (scan_file_globals): Update.
13793         * objc-lang.c (info_selectors_command, info_classes_command)
13794         (find_methods): Update.
13795         * minsyms.c (find_solib_trampoline_target): Update.
13796         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
13797         * coffread.c (coff_symfile_read): Update.
13798         * ada-lang.c (ada_lookup_simple_minsym)
13799         (ada_collect_symbol_completion_matches): Update.
13800
13801 2019-01-16  Tom Tromey  <tom@tromey.com>
13802
13803         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
13804         type.  Remove no-argument constructor.
13805         <iterator::operator++>: Simplify.
13806         <begin>: Update.
13807         <end>: Use minimal_symbol_count.
13808
13809 2019-01-16  Tom Tromey  <tom@tromey.com>
13810
13811         * objfiles.h (struct objfile) <psymtabs>: New method.
13812         (class objfile_psymtabs): Remove.
13813         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
13814         typedef.
13815         <range>: New method.
13816         (require_partial_symbols): Change return type.
13817         * psymtab.c (require_partial_symbols)
13818         (psym_expand_symtabs_matching): Update.
13819         * mdebugread.c (parse_partial_symbols): Update.
13820         * dbxread.c (dbx_end_psymtab): Update.
13821
13822 2019-01-15  Tom Tromey  <tom@tromey.com>
13823
13824         * symtab.c (lookup_objfile_from_block)
13825         (lookup_symbol_in_objfile_symtabs)
13826         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
13827         (find_line_symtab, info_sources_command)
13828         (default_collect_symbol_completion_matches_break_on)
13829         (make_source_files_completion_list): Update.
13830         * symmisc.c (print_objfile_statistics, dump_objfile)
13831         (maintenance_print_symbols, maintenance_info_symtabs)
13832         (maintenance_check_symtabs, maintenance_info_line_tables):
13833         Update.
13834         * source.c (select_source_symtab)
13835         (forget_cached_source_info_for_objfile): Update.
13836         * objfiles.h (class objfile_compunits): Remove.
13837         (struct objfile) <compunits_range>: New typedef.
13838         (compunits): New method.
13839         * objfiles.c (objfile_relocate1): Update.
13840         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
13841         * maint.c (count_symtabs_and_blocks): Update.
13842         * linespec.c (iterate_over_all_matching_symtabs): Update.
13843         * cp-support.c (add_symbol_overload_list_qualified): Update.
13844         * coffread.c (coff_symtab_read): Update.
13845         * ada-lang.c (add_nonlocal_symbols)
13846         (ada_collect_symbol_completion_matches)
13847         (ada_add_global_exceptions): Update.
13848
13849 2019-01-15  Tom Tromey  <tom@tromey.com>
13850
13851         * progspace.h (program_space) <objfiles_safe_range>: New
13852         typedef.
13853         <objfiles_safe>: New method.
13854         * objfiles.h (class all_objfiles_safe): Remove.
13855         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
13856         * jit.c (jit_inferior_exit_hook): Update.
13857
13858 2019-01-17  Tom Tromey  <tom@tromey.com>
13859
13860         * progspace.h (program_space) <objfiles_range>: New typedef.
13861         <objfiles>: New method.
13862         <objfiles_head>: Rename from objfiles.
13863         (object_files): Update.
13864         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
13865         * guile/scm-pretty-print.c
13866         (ppscm_find_pretty_printer_from_objfiles): Update.
13867         * guile/scm-objfile.c (gdbscm_objfiles): Update.
13868         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
13869         Update.
13870         * python/py-progspace.c (pspy_get_objfiles): Update.
13871         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
13872         Update.
13873         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
13874         (objfpy_lookup_objfile_by_build_id): Update.
13875         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
13876         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
13877         Update.
13878         * symtab.c (iterate_over_symtabs, matching_obj_sections)
13879         (expand_symtab_containing_pc, lookup_objfile_from_block)
13880         (lookup_static_symbol, basic_lookup_transparent_type)
13881         (find_pc_sect_compunit_symtab, find_symbol_at_address)
13882         (find_line_symtab, info_sources_command)
13883         (default_collect_symbol_completion_matches_break_on)
13884         (make_source_files_completion_list, find_main_name): Update.
13885         * symmisc.c (print_symbol_bcache_statistics)
13886         (print_objfile_statistics, maintenance_print_symbols)
13887         (maintenance_print_msymbols, maintenance_print_objfiles)
13888         (maintenance_info_symtabs, maintenance_check_symtabs)
13889         (maintenance_expand_symtabs, maintenance_info_line_tables):
13890         Update.
13891         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
13892         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
13893         (map_overlay_command, unmap_overlay_command)
13894         (simple_overlay_update, expand_symtabs_matching)
13895         (map_symbol_filenames): Update.
13896         * symfile-debug.c (set_debug_symfile): Update.
13897         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
13898         Update.
13899         * source.c (select_source_symtab, forget_cached_source_info):
13900         Update.
13901         * solib.c (solib_read_symbols): Update.
13902         * solib-spu.c (append_ocl_sos): Update.
13903         * psymtab.c (maintenance_print_psymbols)
13904         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
13905         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
13906         * printcmd.c (info_symbol_command): Update.
13907         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
13908         Update.
13909         * objfiles.h (class all_objfiles): Remove.
13910         * objfiles.c (have_partial_symbols, have_full_symbols)
13911         (have_minimal_symbols, qsort_cmp, update_section_map)
13912         (shared_objfile_contains_address_p)
13913         (default_iterate_over_objfiles_in_search_order): Update.
13914         * objc-lang.c (info_selectors_command, info_classes_command)
13915         (find_methods): Update.
13916         * minsyms.c (find_solib_trampoline_target): Update.
13917         * maint.c (maintenance_info_sections)
13918         (maintenance_translate_address, count_symtabs_and_blocks):
13919         Update.
13920         * main.c (captured_main_1): Update.
13921         * linux-thread-db.c (try_thread_db_load_from_pdir)
13922         (has_libpthread): Update.
13923         * linespec.c (iterate_over_all_matching_symtabs)
13924         (search_minsyms_for_name): Update.
13925         * jit.c (jit_find_objf_with_entry_addr): Update.
13926         * hppa-tdep.c (find_unwind_entry)
13927         (hppa_lookup_stub_minimal_symbol): Update.
13928         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
13929         Update.
13930         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
13931         (elf_gnu_ifunc_resolve_by_got): Update.
13932         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
13933         * dwarf-index-write.c (save_gdb_index_command): Update.
13934         * cp-support.c (add_symbol_overload_list_qualified): Update.
13935         * breakpoint.c (create_overlay_event_breakpoint)
13936         (create_longjmp_master_breakpoint)
13937         (create_std_terminate_master_breakpoint)
13938         (create_exception_master_breakpoint): Update.
13939         * blockframe.c (find_pc_partial_function): Update.
13940         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
13941         (ada_collect_symbol_completion_matches)
13942         (ada_add_global_exceptions): Update.
13943
13944 2019-01-17  Tom Tromey  <tom@tromey.com>
13945
13946         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
13947         declare VEC.
13948         (solib_target_parse_libraries): Change return type.
13949         (library_list_start_segment, library_list_start_section)
13950         (library_list_end_library, library_list_start_library); Update.
13951         (solib_target_free_library_list): Remove.
13952         (solib_target_parse_libraries): Remove cleanup.  Change return
13953         type.
13954         (solib_target_current_sos): Update.
13955
13956 2019-01-17  Tom Tromey  <tromey@bapiya>
13957
13958         * valprint.c: Replace "the the" with "the".
13959         * symtab.c: Replace "the the" with "the".
13960         * solib.c: Replace "the the" with "the".
13961         * solib-dsbt.c: Replace "the the" with "the".
13962         * linespec.c: Replace "the the" with "the".
13963         * dwarf2loc.h: Replace "the the" with "the".
13964         * amd64-windows-tdep.c: Replace "the the" with "the".
13965         * aarch64-tdep.c: Replace "the the" with "the".
13966
13967 2019-01-16  Keith Seitz  <keiths@redhat.com>
13968
13969         PR gdb/23773
13970         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
13971         <builder>: Rename to ..
13972         <m_builder>: ... this and make private.
13973         (dwarf2_cu::get_builder): New method.  Change all users of
13974         `builder' to use this method.
13975         (dwarf2_start_symtab): Move to ...
13976         (dwarf2_cu::start_symtab): ... here.  Update all callers
13977         (setup_type_unit_groups): Move to ...
13978         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
13979         callers.
13980         (dwarf2_cu::reset_builder): New method.
13981         (process_full_compunit, process_full_type_unit): Use
13982         dwarf2_cu::reset_builder.
13983         (follow_die_offset): Record the ancestor CU if it is different
13984         from the followed DIE's CU.
13985         (follow_die_sig_1): Likewise.
13986
13987 2019-01-15  Tom Tromey  <tom@tromey.com>
13988
13989         * remote.c (class remote_state) <buf>: Now a char_vector.
13990         <buf_size>: Remove.
13991         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
13992         parameter.
13993         (remote_target::getpkt_or_notif_sane_1)
13994         (remote_target::getpkt_sane)
13995         (remote_target::getpkt_or_notif_sane): Likewise.
13996         (class remote_target) <putpkt>: New overload.
13997         (remote_target::read_frame): Change type of "buf_p".  Remove
13998         sizeof_p parameter.
13999         (packet_ok): New overload.
14000         (packet_check_result): New overload.
14001         Update all uses.
14002
14003 2019-01-14  Tom Tromey  <tom@tromey.com>
14004
14005         * remote-notif.c (handle_notification, remote_notif_ack)
14006         (remote_notif_parse): Make "buf" const.
14007         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
14008         const.
14009         (remote_notif_parse, remote_notif_ack, handle_notification):
14010         Likewise.
14011         * remote.c (remote_notif_stop_parse): Make "buf" const.
14012         (remote_target::remote_parse_stop_reply): Make "buf" const.
14013         (remote_notif_stop_ack): Make "buf" const.
14014
14015 2019-01-14  Tom Tromey  <tom@tromey.com>
14016
14017         * remote.c (remote_console_output): Make parameter const.
14018
14019 2019-01-14  Tom Tromey  <tom@tromey.com>
14020
14021         * target-debug.h (target_debug_print_signals): Constify.
14022         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
14023         * procfs.c (procfs_target::pass_signals): Update.
14024         * linux-nat.c (linux_nat_target::pass_signals): Update.
14025         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
14026         * target-delegates.c: Rebuild.
14027         * remote.c (remote_target::program_signals): Update.
14028         (remote_target::pass_signals): Update.
14029         * target.c (target_pass_signals): Constify argument.
14030         (target_program_signals): Likewise.
14031         * target.h (struct target_ops) <pass_signals, program_signals>:
14032         Constify argument.
14033         (target_pass_signals, target_program_signals): Constify argument.
14034
14035 2019-01-14  Tom Tromey  <tom@tromey.com>
14036
14037         PR tui/28819:
14038         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
14039
14040 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
14041
14042         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
14043         field.
14044         * rs6000-tdep.c: Include reggroups.h.
14045         (IS_V_ALIAS_PSEUDOREG): Define.
14046         (rs6000_register_name): Return names for the "vX" aliases.
14047         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
14048         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
14049         aliases.  Call default_register_reggroup_p for all other
14050         pseudo-registers.
14051         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
14052         New functions.
14053         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
14054         Handle "vX" aliases.
14055         (v_alias_pseudo_register_collect): New function.
14056         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
14057         (rs6000_gdbarch_init): Initialize "vX" aliases as
14058         pseudo-registers.  Restore registration of
14059         rs6000_pseudo_register_reggroup_p with
14060         set_tdesc_pseudo_register_reggroup_p.
14061
14062 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
14063
14064         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
14065         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
14066         set_gdbarch_num_pseudo_regs.
14067
14068 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14069
14070         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
14071         Remove arg prefixname, add do_set and do_show.
14072         Add member functions set_list and show_list.
14073         * cli/cli-style.c (class cli_style_option): Update accordingly.
14074         (style_set_list): Move to file scope.
14075         (style_show_list): Likewise.
14076         (set_style): Call help_list.
14077         (show_style): Call cmd_show_list.
14078         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
14079         Update to use the new macro.
14080
14081 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
14082
14083         * ada-lang.c (_initialize_ada_language): Expand the help text
14084         for the "catch exception" command.
14085
14086 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14087
14088         * symtab.c (matching_obj_sections): Initialize obj,
14089         declare it closer to its usage.
14090
14091 2019-01-10  Tom Tromey  <tom@tromey.com>
14092
14093         * thread-iter.h (inf_threads_iterator): Use next_iterator.
14094         (basic_inf_threads_range): Remove.
14095         (inf_threads_range, inf_non_exited_threads_range)
14096         (safe_inf_threads_range): Use next_adapter.
14097
14098 2019-01-10  Keith Seitz  <keiths@redhat.com>
14099
14100         PR gdb/23712
14101         PR symtab/23010
14102         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
14103         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
14104
14105 2019-01-10  Keith Seitz  <keiths@redhat.com>
14106
14107         PR gdb/23712
14108         PR symtab/23010
14109         * dictionary.c (pending_to_vector): Remove.
14110         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
14111         Remove _1 suffix, replacing functions of the same name.  Update
14112         all callers.
14113         (dict_create_hashed, dict_create_hashed_expandable)
14114         (dict_create_linear, dict_create_linear_expandable, dict_free)
14115         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
14116         Make functions static.
14117
14118 2019-01-10  Keith Seitz  <keiths@redhat.com>
14119
14120         PR gdb/23712
14121         PR symtab/23010
14122         * dictionary.h (struct dictionary): Replace declaration with
14123         multidictionary.
14124         (dict_create_hashed, dict_create_hashed_expandable)
14125         (dict_create_linear, dict_create_linear_expandable)
14126         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
14127         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
14128         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
14129         taking multidictionary argument.
14130         [ALL_DICT_SYMBOLS]: Update for multidictionary.
14131         * block.h (struct block) <dict>: Change to multidictionary
14132         and rename `multidict'.
14133         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
14134         symmisc.c: Update all dictionary references to multidictionary.
14135
14136 2019-01-10  Keith Seitz  <keiths@redhat.com>
14137
14138         PR gdb/23712
14139         PR symtab/23010
14140         * dictionary.c: Include unordered_map.
14141         (pending_to_vector): New function.
14142         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
14143         Rewrite the non-"_1" functions to take vector instead
14144         of linked list.
14145         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
14146         "new" _1 versions of the same name.
14147         (multidictionary): Define.
14148         (std::hash<enum language): New definition.
14149         (collate_pending_symbols_by_language, mdict_create_hashed)
14150         (mdict_create_hashed_expandable, mdict_create_linear)
14151         (mdict_create_linear_expandable, mdict_free)
14152         (find_language_dictionary, create_new_language_dictionary)
14153         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
14154         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
14155         (mdict_size, mdict_empty): New functions.
14156         * dictionary.h (mdict_iterator): Define.
14157
14158 2019-01-10  Pedro Alves  <palves@redhat.com>
14159
14160         * breakpoint.c (read_uploaded_action)
14161         (create_tracepoint_from_upload): Adjust to use
14162         gdb::unique_xmalloc_ptr.
14163         * ctf.c (ctf_write_uploaded_tp):
14164         (SET_ARRAY_FIELD): Use emplace_back.
14165         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
14166         * tracefile-tfile.c (tfile_write_uploaded_tp):
14167         * tracepoint.c (parse_tracepoint_definition): Adjust to use
14168         gdb::unique_xmalloc_ptr.
14169         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
14170         at_string, cond_string, cmd_strings>: Replace char pointers
14171         with gdb::unique_xmalloc_ptr.
14172
14173 2019-01-10  Pedro Alves  <palves@redhat.com>
14174
14175         * solib-target.c (library_list_start_library): Don't xstrdup name.
14176
14177 2019-01-10  Pedro Alves  <palves@redhat.com>
14178
14179         * mdebugread.c (parse_partial_symbols): Use
14180         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
14181
14182 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
14183
14184         * linux-fork.c (scoped_switch_fork_info)
14185         <~scoped_switch_fork_info>: Fix incorrect variable name.
14186
14187 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
14188
14189         * linux-fork.c (scoped_switch_fork_info)
14190         <scoped_switch_fork_info>: Make explicit.
14191         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
14192
14193 2019-01-10  Tom Tromey  <tom@tromey.com>
14194
14195         * objfiles.h (objfile::reset_psymtabs): Update.
14196         * objfiles.c (objfile::objfile): Update.
14197         * psymtab.h (psymtab_storage::obstack): Update.
14198         (psymtab_storage::m_obstack): Use gdb::optional.
14199         (class psymtab_storage): Update comment.  Remove objfile
14200         parameter.
14201         * psymtab.c (psymtab_storage::psymtab_storage): Update.
14202
14203 2019-01-10  Tom Tromey  <tom@tromey.com>
14204
14205         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
14206         <free_psymtabs>: Now private.
14207         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
14208         (allocate_psymtab): Use new method.
14209
14210 2019-01-10  Tom Tromey  <tom@tromey.com>
14211
14212         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
14213         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
14214         * mdebugread.c (parse_partial_symbols): Use
14215         allocate_dependencies.
14216         * dwarf2read.c (dwarf2_create_include_psymtab): Use
14217         allocate_dependencies.
14218         (process_psymtab_comp_unit_reader)
14219         (build_type_psymtab_dependencies): Likewise.
14220         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
14221
14222 2019-01-10  Tom Tromey  <tom@tromey.com>
14223
14224         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
14225         PSYMBOL_SET_LANGUAGE.
14226         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
14227
14228 2019-01-10  Tom Tromey  <tom@tromey.com>
14229
14230         * psymtab.h (psymtab_storage::obstack): New method.
14231         <m_obstack>: Rename from obstack; now private.
14232         * psymtab.c (psymtab_storage): Update.
14233         * dwarf2read.c (create_addrmap_from_index)
14234         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
14235         Update.
14236
14237 2019-01-10  Tom Tromey  <tom@tromey.com>
14238
14239         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
14240         * objfiles.h (objfile::reset_psymtabs): New method.
14241
14242 2019-01-10  Tom Tromey  <tom@tromey.com>
14243
14244         * symmisc.c (print_symbol_bcache_statistics): Update.
14245         (print_objfile_statistics): Update.
14246         * symfile.c (reread_symbols): Update.
14247         * psymtab.h (class psymtab_storage): New.
14248         * psymtab.c (psymtab_storage): New constructor.
14249         (~psymtab_storage): New destructor.
14250         (require_partial_symbols): Update.
14251         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
14252         (find_pc_sect_psymtab, find_pc_sect_psymbol)
14253         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
14254         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
14255         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
14256         (start_psymtab_common, end_psymtab_common)
14257         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
14258         (allocate_psymtab): Update.
14259         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
14260         Update.
14261         (dump_psymtab_addrmap, maintenance_print_psymbols)
14262         (maintenance_check_psymtabs): Update.
14263         (class objfile_psymtabs): Move to objfiles.h.
14264         * psympriv.h (discard_psymtab): Now inline.
14265         (psymtab_discarder::psymtab_discarder): Update.
14266         (psymtab_discarder::~psymtab_discarder): Update.
14267         (ALL_OBJFILE_PSYMTABS): Rewrite.
14268         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
14269         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
14270         Remove fields.
14271         <partial_symtabs>: New field.
14272         (class objfile_psymtabs): Move from psymtab.h.  Update.
14273         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
14274         psymbol_cache.
14275         (objfile::~objfile): Don't destroy psymbol_cache.
14276         * mdebugread.c (parse_partial_symbols): Update.
14277         * dwarf2read.c (create_addrmap_from_index)
14278         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
14279         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
14280         (add_partial_subprogram, dwarf2_ranges_read): Update.
14281         * dwarf-index-write.c (write_address_map)
14282         (write_one_signatured_type, recursively_write_psymbols)
14283         (class debug_names, class debug_names, write_psymtabs_to_index):
14284         Update.
14285
14286 2019-01-10  Tom Tromey  <tom@tromey.com>
14287
14288         * symtab.h (SYMBOL_SET_NAMES): Update.
14289         (symbol_set_names): Update.
14290         (MSYMBOL_SET_NAMES): Update.
14291         * symtab.c (symbol_set_names): Change argument to be an
14292         objfile_per_bfd_storage.
14293         * psymtab.c (add_psymbol_to_bcache): Update.
14294         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
14295
14296 2019-01-10  Tom Tromey  <tom@tromey.com>
14297
14298         * symtab.c (create_demangled_names_hash): Change argument to be an
14299         objfile_per_bfd_storage.
14300         (symbol_set_names): Update.
14301
14302 2019-01-10  Tom Tromey  <tom@tromey.com>
14303
14304         * xcoffread.c (xcoff_initial_scan): Unconditionally call
14305         init_psymbol_list.
14306         * psymtab.c (init_psymbol_list): Do nothing if already called.
14307         * psympriv.h (init_psymbol_list): Add comment.
14308         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
14309         init_psymbol_list.
14310         * dbxread.c (dbx_symfile_read): Unconditionally call
14311         init_psymbol_list.
14312
14313 2019-01-10  Tom Tromey  <tom@tromey.com>
14314
14315         * xcoffread.c (scan_xcoff_symtab): Update.
14316         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
14317         "where".
14318         * mdebugread.c (parse_partial_symbols)
14319         (handle_psymbol_enumerators): Update.
14320         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
14321         * dbxread.c (read_dbx_symtab): Update.
14322         * psympriv.h (psymbol_placement): New enum.
14323         (add_psymbol_to_list): Update.
14324
14325 2019-01-10  Tom Tromey  <tom@tromey.com>
14326
14327         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
14328         static_psymbols parameters.
14329         (scan_xcoff_symtab): Update.
14330         * psymtab.c (start_psymtab_common): Remove global_psymbols and
14331         static_psymbols parameters.
14332         * psympriv.h (start_psymtab_common): Update.
14333         * mdebugread.c (parse_partial_symbols): Update.
14334         * dwarf2read.c (create_partial_symtab): Update.
14335         * dbxread.c (read_dbx_symtab): Update.
14336         (start_psymtab): Remove global_psymbols and static_psymbols
14337         parameters.
14338
14339 2019-01-10  Tom Tromey  <tom@tromey.com>
14340
14341         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
14342         * psymtab.c (allocate_psymtab): Add comment.
14343         * psympriv.h (allocate_psymtab): Add comment.
14344         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
14345         initializations.
14346         * dbxread.c (dbx_end_psymtab): Remove some initializations.
14347
14348 2019-01-10  Tom Tromey  <tom@tromey.com>
14349
14350         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
14351         Don't declare.
14352         * mipsread.c: Include mdebugread.h.
14353         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
14354         Declare.
14355         * elfread.c: Include mdebugread.h.
14356
14357 2019-01-09  Tom Tromey  <tom@tromey.com>
14358
14359         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
14360         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
14361         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
14362         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
14363         (psym_lookup_symbol, psym_find_last_source_symtab)
14364         (psym_forget_cached_source_info, psym_print_stats)
14365         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
14366         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
14367         (psym_map_matching_symbols, psym_expand_symtabs_matching)
14368         (psym_find_compunit_symtab_by_address)
14369         (maintenance_print_psymbols, maintenance_info_psymtabs)
14370         (maintenance_check_psymtabs): Use ranged for.
14371         * psymtab.h (class objfile_psymtabs): New.
14372         (require_partial_symbols): Return objfile_psymtabs.
14373         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
14374
14375 2019-01-09  Tom Tromey  <tom@tromey.com>
14376
14377         * symfile.c (overlay_invalidate_all, find_pc_overlay)
14378         (find_pc_mapped_section, list_overlays_command)
14379         (map_overlay_command, unmap_overlay_command)
14380         (simple_overlay_update): Use all_objfiles.
14381         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
14382         * printcmd.c (info_symbol_command): Use all_objfiles.
14383         * objfiles.h (ALL_OBJSECTIONS): Remove.
14384         * maint.c (maintenance_translate_address): Use all_objfiles.
14385         * gcore.c (gcore_create_callback): Use all_objfiles.
14386         (objfile_find_memory_regions): Likewise.
14387
14388 2019-01-09  Tom Tromey  <tom@tromey.com>
14389
14390         * symtab.c (find_line_symtab, info_sources_command)
14391         (make_source_files_completion_list): Use objfile_compunits.
14392         * source.c (select_source_symtab): Use objfile_compunits.
14393         * objfiles.h (struct objfile): Update comment.
14394         (ALL_OBJFILES): Remove.
14395         (ALL_FILETABS): Remove.
14396         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
14397         objfile_compunits.
14398
14399 2019-01-09  Tom Tromey  <tom@tromey.com>
14400
14401         * symmisc.c (print_objfile_statistics, dump_objfile)
14402         (maintenance_print_symbols): Use compunit_filetabs.
14403         * source.c (forget_cached_source_info_for_objfile): Use
14404         compunit_filetabs.
14405         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
14406         (ALL_FILETABS): Use compunit_filetabs.
14407         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
14408         * coffread.c (coff_symtab_read): Use compunit_filetabs.
14409
14410 2019-01-09  Tom Tromey  <tom@tromey.com>
14411
14412         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
14413         (compunit_filetabs): New.
14414         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
14415         compunit_filetabs.
14416         (info_sources_command, make_source_files_completion_list): Remove
14417         declaration.
14418         * symmisc.c (print_objfile_statistics, dump_objfile)
14419         (maintenance_print_symbols): Remove declaration.
14420         (maintenance_info_symtabs): Use compunit_filetabs.
14421         (maintenance_info_line_tables): Likewise.
14422         * source.c (select_source_symtab): Change local variable name.
14423         (forget_cached_source_info_for_objfile): Remove declaration.
14424         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
14425         * objfiles.c (objfile_relocate1): Remove declaration.
14426         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
14427         declaration.
14428         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
14429         * coffread.c (coff_symtab_read): Remove declaration.
14430         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
14431         compunit_filetabs.
14432
14433 2019-01-09  Tom Tromey  <tom@tromey.com>
14434
14435         * symtab.c (lookup_objfile_from_block)
14436         (find_pc_sect_compunit_symtab, search_symbols)
14437         (default_collect_symbol_completion_matches_break_on): Use
14438         objfile_compunits.
14439         * objfiles.h (ALL_COMPUNITS): Remove.
14440         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
14441         * cp-support.c (add_symbol_overload_list_qualified): Use
14442         objfile_compunits.
14443         * ada-lang.c (ada_collect_symbol_completion_matches)
14444         (ada_add_global_exceptions): Use objfile_compunits.
14445
14446 2019-01-09  Tom Tromey  <tom@tromey.com>
14447
14448         * source.c (select_source_symtab)
14449         (forget_cached_source_info_for_objfile): Remove declaration.
14450         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
14451         declaration.
14452         * maint.c (count_symtabs_and_blocks): Remove declaration.
14453         * cp-support.c (add_symbol_overload_list_qualified): Remove
14454         declaration.
14455         * coffread.c (coff_symtab_read): Remove declaration.
14456         * symtab.c (lookup_symbol_in_objfile_symtabs)
14457         (basic_lookup_transparent_type_1): Use objfile_compunits.
14458         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
14459         (info_sources_command, search_symbols)
14460         (default_collect_symbol_completion_matches_break_on)
14461         (make_source_files_completion_list): Remove declaration.
14462         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
14463         (ada_collect_symbol_completion_matches)
14464         (ada_add_global_exceptions): Remove declaration.
14465         * linespec.c (iterate_over_all_matching_symtabs): Use
14466         objfile_compunits.
14467         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
14468         (class objfile_compunits): New.
14469         (ALL_COMPUNITS): Use objfile_compunits.
14470         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
14471         (maintenance_check_symtabs, maintenance_info_line_tables): Use
14472         objfile_compunits.
14473         * objfiles.c (objfile_relocate1): Use objfile_compunits.
14474
14475 2019-01-09  Tom Tromey  <tom@tromey.com>
14476
14477         * symtab.c (search_symbols)
14478         (default_collect_symbol_completion_matches_break_on): Use
14479         objfile_msymbols.
14480         * ada-lang.c (ada_lookup_simple_minsym)
14481         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
14482         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
14483         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
14484         objfile_msymbols.
14485         * coffread.c (coff_symfile_read): Use objfile_msymbols.
14486         * symmisc.c (dump_msymbols): Use objfile_msymbols.
14487         * objc-lang.c (find_methods): Use objfile_msymbols.
14488         (info_selectors_command, info_classes_command): Likewise.
14489         * stabsread.c (scan_file_globals): Use objfile_msymbols.
14490         * objfiles.h (class objfile_msymbols): New.
14491         (ALL_OBJFILE_MSYMBOLS): Remove.
14492         (ALL_MSYMBOLS): Remove.
14493
14494 2019-01-09  Tom Tromey  <tom@tromey.com>
14495
14496         * common/next-iterator.h (next_adapter): Add Iterator template
14497         parameter.
14498         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
14499         (class all_objfiles_safe): New.
14500         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
14501         * objfiles.c (put_objfile_before): Update comment.
14502         (add_separate_debug_objfile): Likewise.
14503         (free_all_objfiles): Use all_objfiles_safe.
14504         (objfile_purge_solibs): Likewise.
14505
14506 2019-01-09  Tom Tromey  <tom@tromey.com>
14507
14508         * symtab.c (iterate_over_symtabs, matching_obj_sections)
14509         (expand_symtab_containing_pc, lookup_static_symbol)
14510         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
14511         (find_symbol_at_address, find_line_symtab, find_main_name): Use
14512         all_objfiles.
14513         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
14514         * breakpoint.c (create_overlay_event_breakpoint)
14515         (create_longjmp_master_breakpoint)
14516         (create_std_terminate_master_breakpoint)
14517         (create_exception_master_breakpoint): Use all_objfiles.
14518         * linux-thread-db.c (try_thread_db_load_from_pdir)
14519         (has_libpthread): Use all_objfiles.
14520         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
14521         * linespec.c (iterate_over_all_matching_symtabs)
14522         (search_minsyms_for_name): Use all_objfiles.
14523         * maint.c (maintenance_info_sections): Use all_objfiles.
14524         * main.c (captured_main_1): Use all_objfiles.
14525         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
14526         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
14527         * guile/scm-pretty-print.c
14528         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
14529         * solib-spu.c (append_ocl_sos): Use all_objfiles.
14530         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
14531         (maintenance_print_msymbols): Use all_objfiles.
14532         * source.c (select_source_symtab): Use all_objfiles.
14533         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
14534         * symfile.c (remove_symbol_file_command)
14535         (expand_symtabs_matching, map_symbol_filenames): Use
14536         all_objfiles.
14537         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
14538         all_objfiles.
14539         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
14540         * objc-lang.c (find_methods): Use all_objfiles.
14541         * objfiles.c (have_partial_symbols, have_full_symbols)
14542         (have_minimal_symbols, qsort_cmp)
14543         (default_iterate_over_objfiles_in_search_order): Use
14544         all_objfiles.
14545         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
14546         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
14547         (maintenance_check_psymtabs): Use all_objfiles.
14548         (ALL_PSYMTABS): Remove.
14549         * compile/compile-object-run.c (do_module_cleanup): Use
14550         all_objfiles.
14551         * blockframe.c (find_pc_partial_function): Use all_objfiles.
14552         * cp-support.c (add_symbol_overload_list_qualified): Use
14553         all_objfiles.
14554         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
14555         Use all_objfiles.
14556         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
14557         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
14558         all_objfiles.
14559         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
14560         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
14561         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
14562         Uses all_objfiles.
14563         * solib.c (solib_read_symbols): Use all_objfiles
14564
14565 2019-01-09  Tom Tromey  <tom@tromey.com>
14566
14567         * probe.c (parse_probes_in_pspace): Use all_objfiles.
14568         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
14569         all_objfiles.
14570         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
14571         * symmisc.c (print_symbol_bcache_statistics)
14572         (print_objfile_statistics, maintenance_print_objfiles)
14573         (maintenance_info_symtabs, maintenance_check_symtabs)
14574         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
14575         all_objfiles.
14576         * source.c (forget_cached_source_info): Use all_objfiles.
14577         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
14578         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
14579         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
14580         * objfiles.c (update_section_map): Use all_objfiles.
14581         (shared_objfile_contains_address_p): Likewise.
14582         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
14583         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
14584
14585 2019-01-09  Tom Tromey  <tom@tromey.com>
14586
14587         * common/next-iterator.h: New file.
14588         * objfiles.h (class all_objfiles): New.
14589         (struct objfile_iterator): New.
14590
14591 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14592
14593         * NEWS: Move the description of the changed "frame", "select-frame",
14594          and "info frame" commands to the Changed commands section.
14595
14596 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
14597
14598         * gdbtypes.c (check_stub_method_group): Remove handling of old
14599         mangling schemes.
14600         * linespec.c (find_methods): Likewise.
14601         * stabsread.c (read_member_functions): Likewise.
14602         * valops.c (search_struct_method): Likewise.
14603         (value_struct_elt_for_reference): Likewise.
14604         * NEWS: Mention this change.
14605
14606 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
14607
14608         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
14609         print_source_lines.
14610         * source.c (print_source_lines_base): Update line number check.
14611         (print_source_lines): New function.
14612         (source_lines_range::source_lines_range): New function.
14613         * source.h (class source_lines_range): New class.
14614         (print_source_lines): New declaration.
14615
14616 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14617
14618         * linespec.c (linespec_state_destructor): Free self->canonical_names.
14619
14620 2019-01-08  Tom Tromey  <tom@tromey.com>
14621             Simon Marchi  <simon.marchi@ericsson.com>
14622
14623         PR gdb/24060
14624         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
14625         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
14626         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
14627         * f-exp.y (DOLLAR_VARIABLE): Likewise.
14628         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
14629         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
14630
14631 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
14632
14633         * source.c (select_source_symtab): Move header comment to
14634         declaration in source.h.
14635         (forget_cached_source_info_for_objfile): Likewise.
14636         (forget_cached_source_info): Likewise.
14637         (identify_source_line): Likewise.
14638         * source.h (identify_source_line): Move declaration from symtab.h
14639         and add comment from source.c
14640         (print_source_lines): Likewise.
14641         (forget_cached_source_info_for_objfile): Likewise.
14642         (forget_cached_source_info): Likewise.
14643         (select_source_symtab): Likewise.
14644         (enum print_source_lines_flag): Move definition from symtab.h.
14645         * symtab.h (identify_source_line): Move declaration to source.h.
14646         (print_source_lines): Likewise.
14647         (forget_cached_source_info_for_objfile): Likewise.
14648         (forget_cached_source_info): Likewise.
14649         (select_source_symtab): Likewise.
14650         (enum print_source_lines_flag): Move definition to source.h.
14651         * tui/tui-hooks.c: Add 'source.h' include.
14652
14653 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
14654
14655         * source.c (print_source_lines_base): Handle requests to print
14656         reverse line number sequences, and guard against empty lines
14657         string.
14658
14659 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
14660
14661         * source.c (print_source_lines_base): Fix skip of '\r' if next
14662         character is '\n'.
14663
14664 2019-01-06  Tom Tromey  <tom@tromey.com>
14665
14666         * c-exp.y (struct c_parse_state) <macro_original_text,
14667         expansion_obstack>: New member.
14668         (macro_original_text, expansion_obstack): Remove globals.
14669         (scan_macro_expansion, scanning_macro_expansion)
14670         (finished_macro_expansion): Update.
14671         (scan_macro_cleanup): Remove.
14672         (yylex, c_parse): Update.
14673
14674 2019-01-06  Tom Tromey  <tom@tromey.com>
14675
14676         * c-exp.y (struct c_parse_state) <strings>: New member.
14677         (operator_stoken): Update.
14678
14679 2019-01-06  Tom Tromey  <tom@tromey.com>
14680
14681         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
14682         (union type_stack_elt) <typelist_val>: Now a pointer to
14683         std::vector.
14684         (type_stack_cleanup): Don't declare.
14685         (push_typelist): Update.
14686         * parse.c (pop_typelist): Return a std::vector.
14687         (push_typelist): Take a std::vector.
14688         (follow_types): Update.  Do not free args.
14689         (type_stack_cleanup): Remove.
14690         * c-exp.y (struct c_parse_state): New.
14691         (cpstate): New global.
14692         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
14693         (nonempty_typelist): Update.
14694         (func_mod): Create a new vector.
14695         (c_parse): Create a c_parse_state.
14696         (check_parameter_typelist): Do not delete params.
14697         (function_method): Update.  Do not delete type_list.
14698
14699 2019-01-06  Tom Tromey  <tom@tromey.com>
14700
14701         PR gdb/28155:
14702         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
14703         check_typedef.
14704         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
14705         (print_return_value): Likewise.
14706
14707 2019-01-05  Tom Tromey  <tom@tromey.com>
14708
14709         * contrib/cleanup_check.py: Remove.
14710         * contrib/gcc-with-excheck: Remove.
14711         * contrib/exsummary.py: Remove.
14712         * contrib/excheck.py: Remove.
14713
14714 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
14715
14716         * thread.c (delete_thread_1): Add gdb_assert that THR is not
14717         NULL. Initialize tpprev to NULL instead of assigning it
14718         to NULL on the next statement.
14719         * windows-nat.c (windows_delete_thread): Remove check for
14720         main_thread_id before printing thread exit notifications.
14721         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
14722         Remove thread ID check against main_thread_id.
14723         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
14724         windows_delete_thread.
14725         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
14726
14727 2019-01-04  Tom Tromey  <tom@tromey.com>
14728
14729         * compile/compile.c (_initialize_compile): Use upper case for
14730         metasyntactic variables.
14731         * symmisc.c (_initialize_symmisc): Use upper case for
14732         metasyntactic variables.
14733         * psymtab.c (_initialize_psymtab): Use upper case for
14734         metasyntactic variables.
14735         * demangle.c (demangle_command): Use upper case for metasyntactic
14736         variables.
14737         (_initialize_demangler): Likewise.
14738         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
14739         variables.
14740
14741 2019-01-03  Tom Tromey  <tom@tromey.com>
14742
14743         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
14744
14745 2019-01-03  Tom Tromey  <tom@tromey.com>
14746
14747         * python/py-symtab.c (salpy_str): Update.
14748         (struct salpy_sal_object) <symtab>: Now a PyObject.
14749         (salpy_dealloc): Update.
14750         (del_objfile_sal): Use gdbpy_ref.
14751
14752 2019-01-03  Tom Tromey  <tom@tromey.com>
14753
14754         * python/py-type.c (convert_field): Use new_reference.  Return
14755         gdbpy_ref.
14756         (make_fielditem): Return gdbpy_ref.
14757         (typy_fields): Update.
14758         (typy_getitem): Update.
14759         (field_name): Return gdbpy_ref.  Use new_reference.
14760         (typy_iterator_iternext): Update.
14761
14762 2019-01-03  Tom Tromey  <tom@tromey.com>
14763
14764         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
14765
14766 2019-01-03  Tom Tromey  <tom@tromey.com>
14767
14768         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
14769         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
14770         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
14771         (pspy_set_frame_filters, pspy_set_frame_unwinders)
14772         (pspy_set_type_printers): Likewise.
14773         * python/py-function.c (fnpy_init): Use gdbpy_ref.
14774         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
14775         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
14776         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
14777         (objfpy_set_type_printers): Likewise.
14778
14779 2019-01-03  Tom Tromey  <tom@tromey.com>
14780
14781         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
14782         (gdbpy_print_stack): Use gdbpy_err_fetch.
14783         * python/python-internal.h (class gdbpy_err_fetch): New class.
14784         (class gdbpy_enter) <m_error_type, m_error_value,
14785         m_error_traceback>: Remove.
14786         <m_error>: New member.
14787         (gdbpy_exception_to_string): Don't declare.
14788         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
14789         * python/py-value.c (convert_value_from_python): Use
14790         gdbpy_err_fetch.
14791         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
14792         gdbpy_exception_to_string.
14793         (gdbpy_handle_exception): Use gdbpy_err_fetch.
14794         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
14795         gdbpy_err_fetch.
14796
14797 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
14798
14799         * linux-nat.c (delete_lwp_cleanup): Delete.
14800         (struct lwp_deleter): New struct.
14801         (lwp_info_up): New typedef.
14802         (linux_nat_target::follow_fork): Delete cleanup, and make use of
14803         lwp_info_up.
14804
14805 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
14806
14807         * linux-fork.c (class scoped_switch_fork_info): New class.
14808         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
14809
14810 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
14811
14812         * valops.c (find_overload_match): Remove use of null_cleanup, and
14813         calls to do_cleanups.
14814
14815 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
14816
14817         * compile/compile-cplus-types.c
14818         (compile_cplus_instance::decl_name): Handle changes to
14819         cp_func_name.
14820         * cp-support.c (cp_func_name): Update header comment, update
14821         return type.
14822         * cp-support.h (cp_func_name): Update return type in declaration.
14823         * valops.c (find_overload_match): Move temp_func local to top
14824         level of function and change its type.  Use temp_func to hold and
14825         delete temporary string obtained from cp_func_name.
14826
14827 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
14828
14829         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
14830         gdb::char_vector, remove cleanup, and update uses of `msg`.
14831
14832 2019-01-03  Jim Wilson  <jimw@sifive.com>
14833
14834         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
14835
14836 2019-01-02  Tom Tromey  <tom@tromey.com>
14837
14838         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
14839         (tdesc_parse_xml): Remove cleanups.
14840         * target-descriptions.h (make_cleanup_free_target_description):
14841         Don't declare.
14842         (target_desc_deleter): New struct.
14843         (target_desc_up): New typedef.
14844         * target-descriptions.c (target_desc_deleter::operator()): Rename
14845         from free_target_description.
14846         (make_cleanup_free_target_description): Remove.
14847
14848 2019-01-02  Tom Tromey  <tom@tromey.com>
14849
14850         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
14851         constructor, destructor.
14852         (linespec_parser): Remove typedef.
14853         (~linespec_parser): Rename from linespec_parser_delete.
14854         (linespec_lex_to_end, linespec_complete_label)
14855         (linespec_complete): Update.
14856         (decode_line_full): Remove cleanups.
14857         (decode_line_1): Update.
14858
14859 2019-01-02  Tom Tromey  <tom@tromey.com>
14860
14861         * python/python-internal.h (inferior_to_inferior_object): Change
14862         return type.
14863         * python/py-exitedevent.c (create_exited_event_object): Update.
14864         * python/py-inferior.c (inferior_to_inferior_object): Return
14865         gdbpy_ref.
14866         (python_new_inferior, python_inferior_deleted)
14867         (thread_to_thread_object, delete_thread_object)
14868         (build_inferior_list, gdbpy_selected_inferior): Update.
14869         * python/py-infthread.c (create_thread_object): Update.  Also fail
14870         if inferior_to_inferior_object fails.
14871
14872 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
14873
14874         * inferior.h (class inferior) <displaced_step_state>: New field.
14875         * infrun.h (struct displaced_step_state): Move here from
14876         infrun.c.  Initialize fields, add constructor.
14877         <inf>: Remove field.
14878         <reset>: New method.
14879         * infrun.c (struct displaced_step_inferior_state): Move to
14880         infrun.h.
14881         (displaced_step_inferior_states): Remove.
14882         (get_displaced_stepping_state): Adust.
14883         (displaced_step_in_progress_any_inferior): Adjust.
14884         (displaced_step_in_progress_thread): Adjust.
14885         (displaced_step_in_progress): Adjust.
14886         (add_displaced_stepping_state): Remove.
14887         (get_displaced_step_closure_by_addr): Adjust.
14888         (remove_displaced_stepping_state): Remove.
14889         (infrun_inferior_exit): Call displaced_step_state.reset.
14890         (use_displaced_stepping): Don't check for NULL.
14891         (displaced_step_prepare_throw): Call
14892         get_displaced_stepping_state.
14893         (displaced_step_fixup): Don't check for NULL.
14894         (prepare_for_detach): Don't check for NULL.
14895
14896 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14897
14898         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
14899          in case of call that did not complete.
14900
14901 2019-01-02  Andrey Utkin  <autkin@undo.io>
14902
14903         * symfile.c (find_separate_debug_file): Fix search of debug files for
14904         remote debuggee.
14905
14906 2019-01-02  Tom Tromey  <tom@tromey.com>
14907
14908         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
14909         indentation.
14910         * python/py-frame.c (frapy_older): Remove cast.
14911         (frapy_newer): Likewise.
14912         * python/py-breakpoint.c (local_setattro): Remove cast.
14913         * python/py-arch.c (archpy_name): Remove local variable.
14914         * python/py-type.c (gdbpy_lookup_type): Remove cast.
14915
14916 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
14917
14918         * unittests/basic_string_view/element_access/char/empty.cc:
14919         Fix year range in copyright header.
14920
14921 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
14922
14923         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
14924         Delete.
14925         <operator==>: Update with for removed field.
14926         <hash>: Likewise.
14927         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
14928         <isa_features>: ...this.
14929         <abi_features>: New field.
14930         (riscv_isa_flen): Update comment.
14931         (riscv_abi_xlen): New declaration.
14932         (riscv_abi_flen): New declaration.
14933         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
14934         isa_features.
14935         (riscv_abi_xlen): New function.
14936         (riscv_isa_flen): Update to get answer from isa_features.
14937         (riscv_abi_flen): New function.
14938         (riscv_has_fp_abi): Update to get answer from abi_features.
14939         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
14940         xlen and flen.
14941         (riscv_call_info) <xlen, flen>: Update comment.
14942         (riscv_call_arg_struct): Remove invalid assertions
14943         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
14944         is removed.
14945         (riscv_gdbarch_init): Gather isa features and abi features
14946         separately, ensure both match on the gdbarch when reusing an old
14947         gdbarch.  Relax an error check to allow 32-bit abi float to run on
14948         a target with 64-bit float hardware.
14949
14950 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14951
14952         * source.c (search_command_helper): Stop reverse search
14953         when line 1 has been searched.
14954
14955 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14956
14957         * record-full.c (record_full_base_target::close): Rewrite
14958         record_full_core_buf_list free logic.
14959
14960 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14961
14962         * break-catch-syscall.c (print_one_catch_syscall): xfree
14963         the last text.
14964
14965 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
14966
14967         * top.c (print_gdb_version): Update Copyright year in version
14968         message.
14969
14970 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
14971
14972         Update copyright year range in all GDB files.
14973
14974 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
14975
14976         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
14977
14978 For older changes see ChangeLog-2018.
14979 \f
14980 Local Variables:
14981 mode: change-log
14982 left-margin: 8
14983 fill-column: 74
14984 version-control: never
14985 coding: utf-8
14986 End:
14987