gdb/ChangeLog

   1 2019-11-15  Christian Biesinger  <cbiesinger@google.com>
   2
   3         * config.in: Regenerate.
   4         * configure: Regenerate.
   5         * gdbsupport/common.m4: No longer check for strerror_r.
   6         * gdbsupport/posix-strerror.c (safe_strerror): Always call the
   7         POSIX version of strerror_r, now that gnulib provides it if
   8         necessary.
   9
  10 2019-11-14  Christian Biesinger  <cbiesinger@google.com>
  11
  12         * README (`configure' options): Update.
  13
  14 2019-11-14  Tom Tromey  <tromey@adacore.com>
  15
  16         * eval.c (evaluate_subexp_standard) <BINOP_ASSIGN>: Do not pass an
  17         expected type for the RHS if the LHS is a convenience variable.
  18
  19 2019-11-14  Simon Marchi  <simon.marchi@polymtl.ca>
  20
  21         * unittests/vec-utils-selftests.c (unordered_remove_tests::obj):
  22         Provide explicit default and copy constructor.
  23
  24 2019-11-14  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
  25
  26         * python/py-finishbreakpoint.c (gdbpy_breakpoint_created):
  27         only call Py_INCREF (newbp) in the bppy_pending_object case.
  28
  29 2019-11-13  Tom Tromey  <tromey@adacore.com>
  30
  31         PR build/25182:
  32         * psympriv.h (partial_symbol): Remove static assert.
  33         * symtab.h (general_symbol_info, symbol): Remove static assert.
  34
  35 2019-11-12  Andrew Burgess  <andrew.burgess@embecosm.com>
  36
  37         * gdbsupport/format.c (format_pieces::format_pieces): Support
  38         printf 'z' size modifier.
  39         * gdbsupport/format.h (enum argclass): Add size_t_arg.
  40         * printcmd.c (ui_printf):  Handle size_t_arg.
  41         * ui-out.c (ui_out::vmessage): Likewise.
  42         * unittests/format_pieces-selftests.c (test_format_int_sizes): New
  43         function.
  44         (run_tests): Call test_format_int_sizes.
  45
  46 2019-11-12  Christian Biesinger  <cbiesinger@google.com>
  47
  48         * ada-exp.y (write_ambiguous_var): Update.
  49         * buildsym.c (add_symbol_to_list): Update.
  50         * dwarf2read.c (read_variable): Update.
  51         (new_symbol): Update.
  52         * jit.c (finalize_symtab): Update.
  53         * language.c (language_alloc_type_symbol): Update.
  54         * symtab.c (fixup_symbol_section): Update.
  55         (initialize_objfile_symbol_1): Move code to...
  56         (initialize_objfile_symbol): ...here. Remove now-unnecessary memset.
  57         (allocate_symbol): Update.
  58         (allocate_template_symbol): Update.
  59         (get_symbol_address): Update.
  60         * symtab.h (struct symbol): Inherit from general_symbol_info instead
  61         of having as a field, and add a constructor.
  62         (SYMBOL_VALUE): Update.
  63         (SYMBOL_VALUE_ADDRESS): Update.
  64         (SET_SYMBOL_VALUE_ADDRESS): Update.
  65         (SYMBOL_VALUE_BYTES): Update.
  66         (SYMBOL_VALUE_COMMON_BLOCK): Update.
  67         (SYMBOL_BLOCK_VALUE): Update.
  68         (SYMBOL_VALUE_CHAIN): Update.
  69         (SYMBOL_LANGUAGE): Update.
  70         (SYMBOL_SECTION): Update.
  71         (SYMBOL_OBJ_SECTION): Update.
  72         (SYMBOL_SET_LANGUAGE): Update.
  73         (SYMBOL_SET_LINKAGE_NAME): Update.
  74         (SYMBOL_SET_NAMES): Update.
  75         (SYMBOL_NATURAL_NAME): Update.
  76         (SYMBOL_LINKAGE_NAME): Update.
  77         (SYMBOL_DEMANGLED_NAME): Update.
  78         (SYMBOL_SEARCH_NAME): Update.
  79         (SYMBOL_MATCHES_SEARCH_NAME): Update.
  80         (struct symbol): Update.
  81         (struct template_symbol): Update.
  82         (struct rust_vtable_symbol): Update.
  83         * xcoffread.c (SYMBOL_DUP): Update.
  84
  85 2019-11-12  Tom Tromey  <tom@tromey.com>
  86
  87         * tui/tui-layout.c (show_layout): Set current_layout.
  88         (show_source_disasm_command, show_data)
  89         (show_source_or_disasm_and_command): Don't set current_layout.
  90
  91 2019-11-12  Tom Tromey  <tom@tromey.com>
  92
  93         * tui/tui-layout.c (_initialize_tui_layout): Move to end.
  94
  95 2019-11-12  Tom Tromey  <tom@tromey.com>
  96
  97         * tui/tui-win.c (resize_message): New global.
  98         (show_tui_resize_message): New function.
  99         (tui_async_resize_screen): Print message if requested.
 100         (_initialize_tui_win): Add tui-resize-message setting.
 101         * NEWS: Add entry for new commands.
 102
 103 2019-11-11  Tom Tromey  <tom@tromey.com>
 104
 105         * tui/tui.c (tui_initialize_readline): Add new bindable readline
 106         functions.
 107
 108 2019-11-11  Christian Biesinger  <cbiesinger@google.com>
 109
 110         * nat/linux-osdata.c (user_from_uid): Use getpwuid_r.
 111
 112 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
 113
 114         * python/py-symbol.c (gdbpy_lookup_static_symbols): New
 115         function.
 116         * python/python-internal.h (gdbpy_lookup_static_symbols):
 117         Declare new function.
 118         * python/python.c (python_GdbMethods): Add
 119         gdb.lookup_static_symbols method.
 120         * NEWS: Mention gdb.lookup_static_symbols.
 121
 122 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
 123
 124         * python/py-symbol.c (gdbpy_lookup_static_symbol): Lookup in
 125         static block of current object file first.  Also fix typo in
 126         header comment.
 127
 128 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
 129
 130         * stack.c (set_last_displayed_sal): Delete.
 131         (last_displayed_sal_valid): Delete.
 132         (last_displayed_pspace): Delete.
 133         (last_displayed_addr): Delete.
 134         (last_displayed_symtab): Delete.
 135         (last_displayed_line): Delete.
 136         (class last_displayed_symtab_info_type): New.
 137         (last_displayed_symtab_info): New static global variable.
 138         (print_frame_info): Call methods on last_displayed_symtab_info.
 139         (clear_last_displayed_sal): Update header comment, and make use of
 140         last_displayed_symtab_info.
 141         (last_displayed_sal_is_valid): Likewise.
 142         (get_last_displayed_pspace): Likewise.
 143         (get_last_displayed_addr): Likewise.
 144         (get_last_displayed_symtab): Likewise.
 145         (get_last_displayed_line): Likewise.
 146         (get_last_displayed_sal): Likewise.
 147         * stack.h (clear_last_displayed_sal): Update header comment.
 148         (last_displayed_sal_is_valid): Likewise.
 149         (get_last_displayed_pspace): Likewise.
 150         (get_last_displayed_addr): Likewise.
 151         (get_last_displayed_symtab): Likewise.
 152         (get_last_displayed_line): Likewise.
 153         (get_last_displayed_sal): Likewise.
 154
 155 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
 156
 157         * stack.c (frame_show_address): Convert return type to bool.
 158         * stack.h (frame_show_address): Likewise, and update header
 159         comment.
 160
 161 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
 162
 163         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add new file to the list.
 164         * unittests/vec-utils-selftests.c: New file.
 165         * gdbsupport/gdb_vecs.h (unordered_remove): Avoid self move assign.
 166
 167 2019-11-10  Tom Tromey  <tom@tromey.com>
 168
 169         * tui/tui-wingeneral.c (tui_unhighlight_win): Use can_box.
 170         (tui_highlight_win): Likewise.
 171         (tui_win_info::check_and_display_highlight_if_needed): Likewise.
 172         * tui/tui-data.h (struct tui_win_info) <can_highlight>: Remove.
 173         * tui/tui-command.h (struct tui_cmd_window) <tui_cmd_window>:
 174         Don't set can_highlight.
 175
 176 2019-11-10  Tom Tromey  <tom@tromey.com>
 177
 178         * cli/cli-style.h (class cli_style_option) <cli_style_option>:
 179         Remove unused declaration.
 180
 181 2019-11-08  Tom Tromey  <tromey@adacore.com>
 182
 183         * top.c (read_command_file): Update.
 184         (command_line_input): Make return type const.
 185         * python/py-gdb-readline.c: Update.
 186         * linespec.c (decode_line_2): Update.
 187         * defs.h (command_line_input): Make return type const.
 188         * cli/cli-script.c (read_next_line): Make return type const.
 189         * ada-lang.c (get_selections): Update.
 190
 191 2019-11-06  Christian Biesinger  <cbiesinger@google.com>
 192
 193         * linux-tdep.c (linux_info_proc): Use strtok_r instead of strtok.
 194         * mi/mi-main.c (output_cores): Likewise.
 195         * nat/linux-osdata.c (linux_xfer_osdata_cpus): Likewise.
 196         (linux_xfer_osdata_modules): Likewise.
 197         * remote.c (register_remote_support_xml): Likewise.
 198         * sparc64-tdep.c (adi_is_addr_mapped): Likewise.
 199         * xml-syscall.c (syscall_create_syscall_desc): Likewise.
 200
 201 2019-11-06  Tom Tromey  <tom@tromey.com>
 202
 203         * tui/tui-interp.c: Don't include readline.h.
 204         * tui/tui-hooks.c: Don't include readline.h.
 205         * symmisc.c: Include tilde.h, not readline.h.
 206         * symfile.c: Include tilde.h, not readline.h.
 207         * source.c: Include tilde.h, not readline.h.
 208         * solib.c: Include tilde.h, not readline.h.
 209         * psymtab.c: Include tilde.h, not readline.h.
 210         * exec.c: Include tilde.h, not readline.h.
 211         * corelow.c: Include tilde.h, not readline.h.
 212         * cli/cli-dump.c: Include tilde.h, not readline.h.
 213         * cli/cli-cmds.c: Don't include readline.h.
 214
 215 2019-11-05  Tom Tromey  <tom@tromey.com>
 216
 217         * tui/tui-disasm.c (struct tui_asm_line) <addr_size>: New member.
 218         (tui_disassemble): Set addr_size.
 219         (tui_disasm_window::set_contents): Use addr_size.
 220
 221 2019-11-05  Tom Tromey  <tom@tromey.com>
 222
 223         * rust-lang.c (rust_language_defn): Update.
 224         * python/py-value.c (valpy_string): Call c_get_string.
 225         * p-lang.c (pascal_language_defn): Update.
 226         * opencl-lang.c (opencl_language_defn): Update.
 227         * objc-lang.c (objc_language_defn): Update.
 228         * m2-lang.c (m2_language_defn): Update.
 229         * language.c (unknown_language_defn, auto_language_defn): Update.
 230         (default_get_string): Remove.
 231         * guile/scm-value.c (gdbscm_value_to_string): Use c_get_string.
 232         * go-lang.c (go_language_defn): Update.
 233         * f-lang.c (f_language_defn): Update.
 234         * d-lang.c (d_language_defn): Update.
 235         * c-lang.c (c_language_defn, cplus_language_defn)
 236         (asm_language_defn, minimal_language_defn): Update.
 237         * ada-lang.c (ada_language_defn): Update.
 238         * language.h (struct language_defn) <la_get_string>: Remove.
 239         (LA_GET_STRING): Remove.
 240         (default_get_string): Don't declare.
 241
 242 2019-11-05  Tom Tromey  <tom@tromey.com>
 243
 244         * tui/tui-source.h (struct tui_source_window): Inline
 245         constructor.  Remove destructor.
 246         <style_changed, m_observable>: Move to superclass.
 247         * tui/tui-winsource.h (tui_copy_source_line): Declare.
 248         (struct tui_source_window_base): Move private members to end.
 249         <style_changed, m_observable>: Move from tui_source_window.
 250         * tui/tui-winsource.c (tui_copy_source_line): Move from
 251         tui-source.c.  Rename from copy_source_line.  Add special handling
 252         for negative line number.
 253         (tui_source_window_base::style_changed): Move from
 254         tui_source_window.
 255         (tui_source_window_base): Register observer.
 256         (~tui_source_window_base): New.
 257         * tui/tui-source.c (copy_source_line): Move to tui-winsource.c;
 258         rename.
 259         (tui_source_window::set_contents): Use tui_copy_source_line.
 260         (tui_source_window::tui_source_window): Move to tui-source.h.
 261         (tui_source_window::~tui_source_window): Remove.
 262         (tui_source_window::style_changed): Move to superclass.
 263         * tui/tui-disasm.c (tui_disassemble): Create string file with
 264         styling, when possible.  Add "addr_size" parameter.
 265         (tui_disasm_window::set_contents): Use tui_copy_source_line.
 266         Don't compute maximum size.
 267         (len_without_escapes): New function
 268
 269 2019-11-05  Tom Tromey  <tom@tromey.com>
 270
 271         * tui/tui-winsource.h (struct tui_source_element) <line>: Now a
 272         std::string.
 273         * tui/tui-winsource.c (tui_show_source_line): Update.
 274         * tui/tui-source.c (tui_source_window::set_contents): Update.
 275         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
 276
 277 2019-11-05  Christian Biesinger  <cbiesinger@google.com>
 278
 279         * symtab.h (gdb_static_assert): Put && operator at the beginning
 280         of the line instead of the end.
 281
 282 2019-11-04  Christian Biesinger  <cbiesinger@google.com>
 283
 284         * psympriv.h: Add static_asserts for sizeof (general_symbol_info)
 285         and sizeof (symbol).
 286         * symtab.h: Add a static_assert for sizeof (partial_symbol).
 287
 288 2019-11-04  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
 289
 290         * NEWS (Changes since GDB 8.3): Document Solaris 10 removal.
 291         * configure.host: Mark *-*-solaris2.10* obsolete.
 292         * configure.tgt: Mark Solaris < 11 obsolete.
 293         * MAINTAINERS (Target Instruction Set Architectures) <sparc>:
 294         Update target triplet.
 295
 296 2019-11-01  Tom Tromey  <tromey@adacore.com>
 297
 298         * utils.c (print_sys_errmsg): Simplify.
 299
 300 2019-11-01  Tom Tromey  <tromey@adacore.com>
 301
 302         * gdbsupport/mingw-strerror.c (safe_strerror): Constify result.
 303
 304 2019-11-01  Christian Biesinger  <cbiesinger@google.com>
 305
 306         * configure: Regenerate.
 307         * configure.ac: Remove check for strerror_r.
 308         * gdbsupport/common.m4: Check for strerror_r.
 309
 310 2019-11-01  Luis Machado  <luis.machado@linaro.org>
 311
 312         PR gdb/25124
 313
 314         * arm-tdep.c (arm_per_objfile): Rename to ...
 315         (arm_per_bfd): ... this.
 316         (arm_objfile_data_key): Rename to ...
 317         (arm_bfd_data_key): ... this.
 318         (arm_find_mapping_symbol): Adjust access to new bfd_key-based
 319         data.
 320         (arm_record_special_symbol): Likewise.
 321
 322 2019-10-31  Andrew Burgess  <andrew.burgess@embecosm.com>
 323
 324         * ada-typeprint.c (ada_print_typedef): Don't print newline at the
 325         end.
 326         * c-typeprint.c (c_print_typedef): Likewise.
 327         * f-typeprint.c (f_print_typedef): Likewise.
 328         * m2-typeprint.c (m2_print_typedef): Likewise.
 329         * p-typeprint.c (pascal_print_typedef): Likewise.
 330         * rust-lang.c (rust_print_typedef): Likewise.
 331         * symtab.c (print_symbol_info): Print a newline after calling
 332         typedef_print.
 333
 334 2019-10-31  Andrew Burgess  <andrew.burgess@embecosm.com>
 335
 336         * symtab.c (info_module_cmdlist): New variable.
 337         (info_module_command): New function.
 338         (search_module_symbols): New function.
 339         (info_module_subcommand): New function.
 340         (struct info_modules_var_func_options): New struct.
 341         (info_modules_var_func_options_defs): New variable.
 342         (make_info_modules_var_func_options_def_group): New function.
 343         (info_module_functions_command): New function.
 344         (info_module_variables_command): New function.
 345         (info_module_var_func_command_completer): New function.
 346         (_initialize_symtab): Register new 'info module functions' and
 347         'info module variables' commands.
 348         * symtab.h (typedef symbol_search_in_module): New typedef.
 349         (search_module_symbols): Declare new function.
 350         * NEWS: Mention new commands.
 351
 352 2019-10-31  Andrew Burgess  <andrew.burgess@embecosm.com>
 353
 354         * dwarf2read.c (dw2_symtab_iter_next): Handle MODULE_DOMAIN.
 355         (dw2_expand_marked_cus): Handle MODULES_DOMAIN.
 356         (dw2_debug_names_iterator::next): Handle MODULE_DOMAIN and
 357         MODULES_DOMAIN.
 358         (scan_partial_symbols): Only create partial module symbols for non
 359         declarations.
 360         * psymtab.c (recursively_search_psymtabs): Handle MODULE_DOMAIN
 361         and MODULES_DOMAIN.
 362         * symtab.c (search_domain_name): Likewise.
 363         (search_symbols): Likewise.
 364         (print_symbol_info): Likewise.
 365         (symtab_symbol_info): Likewise.
 366         (info_modules_command): New function.
 367         (_initialize_symtab): Register 'info modules' command.
 368         * symtab.h (enum search_domain): Add MODULES_DOMAIN.
 369         * NEWS: Mention new 'info modules' command.
 370
 371 2019-10-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 372
 373         * NEWS: Mention $_gdb_setting, $_gdb_setting_str, $_gdb_maint_setting
 374         and $_gdb_maint_setting_str.
 375
 376 2019-10-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 377
 378         * cli/cli-cmds.c (setting_cmd, value_from_setting)
 379         (gdb_setting_internal_fn, gdb_maint_setting_internal_fn)
 380         (str_value_from_setting, gdb_setting_str_internal_fn)
 381         (gdb_maint_setting_str_internal_fn): New functions.
 382         (_initialize_cli_cmds): Define the new convenience functions.
 383         * gdb/cli/cli-setshow.h (get_setshow_command_value_string): Constify.
 384         * gdb/cli/cli-setshow.c (get_setshow_command_value_string): Constify.
 385
 386 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
 387
 388         * agent.c (set_can_use_agent): When the setting is turned on,
 389         look up agent symbols if we don't have them yet.
 390         (agent_new_objfile): Don't look up agent symbols when the agent
 391         setting is off.
 392
 393 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
 394
 395         * config.in: Regenerate.
 396
 397 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
 398
 399         * configure: Regenerate.
 400         * configure.ac: Check for strerror_r.
 401         * gdbsupport/common-utils.h (safe_strerror): Change return value
 402         to const char * and document that this function is now threadsafe.
 403         * gdbsupport/posix-strerror.c (safe_strerror): Make buf
 404         thread_local and call strerror_r, if available.
 405         * utils.c (perror_string): Update.
 406         (print_sys_errmsg): Update.
 407
 408 2019-10-31  Luis Machado  <luis.machado@linaro.org>
 409
 410         * arm-tdep.c (arm_exidx_data_key): Use bfd_key instead of
 411         objfile_key.
 412         (arm_exidx_new_objfile): Adjust to use objfile->obfd instead of
 413         objfile to fetch per-bfd data.
 414         (arm_find_exidx_entry): Likewise.
 415
 416 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
 417
 418         * gdbsupport/agent.c (debug_agent): Change type to bool.
 419         (use_agent): Likewise.
 420         (all_agent_symbols_look_up): Likewise.
 421         (agent_loaded_p): Change return value to bool.
 422         (agent_look_up_symbols): Update.
 423         (agent_capability_check): Change return value to bool.
 424         * gdbsupport/agent.h (agent_loaded_p): Likewise.
 425         (debug_agent): Change type to bool.
 426         (use_agent): Likewise.
 427         (agent_capability_check): Change return value to bool.
 428
 429 2019-10-30  Christian Biesinger  <cbiesinger@google.com>
 430
 431         * minsyms.c (clear_minimal_symbol_hash_tables): New function.
 432         (build_minimal_symbol_hash_tables): Code to clear the table moved
 433         to clear_minimal_symbol_hash_tables.
 434         (minimal_symbol_reader::install): Call clear_minimal_symbol_hash_tables
 435         when needed.
 436
 437 2019-10-29  Simon Marchi  <simon.marchi@polymtl.ca>
 438
 439         * infcmd.c: Remove includes.
 440         * infrun.c: Remove includes.
 441
 442 2019-10-29  Simon Marchi  <simon.marchi@polymtl.ca>
 443
 444         * ada-lang.h (GROW_VECT): Move to ada-lang.c.
 445         (grow_vect): Remove declaration.
 446         (ada_type_of_array): Remove declaration.
 447         (ada_update_initial_language): Remove declaration.
 448         (ada_fold_name): Remove declaration.
 449         (ada_fill_in_ada_prototype): Remove declaration.
 450         (user_select_syms): Remove declaration.
 451         (get_selections): Remove declaration.
 452         (ada_tag_type): Remove declaration.
 453         (ada_value_tag): Remove declaration.
 454         (ada_is_others_clause): Remove declaration.
 455         (ada_in_variant): Remove declaration.
 456         (ada_value_struct_elt): Remove declaration.
 457         (ada_attribute_name): Remove declaration.
 458         (ada_system_address_type): Remove declaration.
 459         * ada-lang.c (ada_watch_location_expression): Make static.
 460         (GROW_VECT): Move here from ada-lang.h.
 461         (grow_vect): Make static.
 462         (ada_update_initial_language): Make static.
 463         (ada_fold_name): Make static.
 464         (ada_type_of_array): Make static.
 465         (encoded_ordered_before): Move up.
 466         (sort_choices): Move up.
 467         (print_signatures): Move up.
 468         (ada_print_symbol_signature): Move up.
 469         (get_selections): Move up and make static.
 470         (user_select_syms): Move up and make static.
 471         (ada_value_struct_elt): Move up and make static.
 472         (ada_tag_type): Make static.
 473         (ada_value_tag): Make static.
 474         (ada_is_others_clause): Make static.
 475         (ada_in_variant): Make static.
 476         (ada_attribute_name): Make static.
 477
 478 2019-10-29  Simon Marchi  <simon.marchi@polymtl.ca>
 479
 480         * ada-lang.c: Remove includes.
 481         * ada-typeprint.c: Remove includes.
 482         * ada-valprint.c: Remove includes.
 483
 484 2019-10-29  Simon Marchi  <simon.marchi@efficios.com>
 485
 486         * addrmap.c: Add static assertions of type size, moved from
 487         _initialize_addrmap.
 488         (_initialize_addrmap): Remove.
 489
 490 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
 491
 492         * coffread.c (record_minimal_symbol): Update.
 493         (process_coff_symbol): Update.
 494         * dbxread.c (read_dbx_symtab): Update.
 495         * dwarf2read.c (add_partial_symbol): Update.
 496         (fixup_go_packaging): Update.
 497         (load_partial_dies): Update.
 498         (new_symbol): Update.
 499         * elfread.c (record_minimal_symbol): Change signature to use
 500         gdb::string_view instead of name+len.
 501         (elf_symtab_read): Update.
 502         (elf_rel_plt_read): Update.
 503         * mdebugread.c (parse_partial_symbols): Update.
 504         (handle_psymbol_enumerators): Update.
 505         (new_symbol): Update.
 506         * minsyms.c (minimal_symbol_reader::record_full): Change signature
 507         to use gdb::string_view instead of name+len.
 508         * minsyms.h (class minimal_symbol_reader) <record_full>: Likewise.
 509         * psympriv.h (add_psymbol_to_list): Likewise.
 510         * psymtab.c (add_psymbol_to_bcache): Likewise.
 511         (add_psymbol_to_list): Likewise.
 512         * stabsread.c (define_symbol): Update.
 513         * symtab.c (symbol_set_names): Change signature to use gdb::string_view.
 514         * symtab.h (SYMBOL_SET_NAMES): Likewise.
 515         (symbol_set_names): Likewise.
 516         * xcoffread.c (scan_xcoff_symtab): Update.
 517
 518 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
 519
 520         * symtab.h (symbol_set_names): Document that copy_name must be
 521         set to true for non-nullterminated strings.
 522         * symtab.c (symbol_set_names): Only make a nullterminated copy of
 523         linkage_name if the entry was not found and we need to demangle.
 524
 525 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
 526
 527         * Makefile.in (HFILES_NO_SRCDIR): Add gdb_binary_search.h.
 528         * dwarf2-frame.c (bsearch_fde_cmp): Update.
 529         (dwarf2_frame_find_fde): Replace bsearch with gdb::binary_search.
 530         * gdbsupport/gdb_binary_search.h: New file.
 531
 532 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
 533
 534         * NEWS: Mention new --with-system-gdbinit-dir option.
 535         * config.in: Regenerate.
 536         * configure: Regenerate.
 537         * configure.ac: Add new option --with-system-gdbinit-dir.
 538         * extension.c (get_ext_lang_of_file): Return extension_language_gdb
 539         for a ".gdb" suffix.
 540         * main.c (get_init_files): Change system_gdbinit argument to
 541         a vector and return the files in SYSTEM_GDBINIT_DIR in
 542         addition to SYSTEM_GDBINIT.
 543         (captured_main_1): Update.
 544         (print_gdb_help): Update.
 545         * top.c (print_gdb_configuration): Also print the value of
 546         SYSTEM_GDBINIT_DIR.
 547
 548 2019-10-28  Christian Biesinger  <cbiesinger@google.com>
 549
 550         * gdbsupport/common-utils.h (startswith): Add an overloaded version
 551         that takes gdb::string_view arguments.
 552
 553 2019-10-26  Tom de Vries  <tdevries@suse.de>
 554
 555         * aarch64-linux-tdep.c: Fix typos in comments.
 556         * aarch64-tdep.c: Same.
 557         * ada-lang.c: Same.
 558         * amd64-nat.c: Same.
 559         * arc-tdep.c: Same.
 560         * arch/aarch64-insn.c: Same.
 561         * block.c: Same.
 562         * breakpoint.h: Same.
 563         * btrace.h: Same.
 564         * c-varobj.c: Same.
 565         * cli/cli-decode.c: Same.
 566         * cli/cli-script.c: Same.
 567         * cli/cli-utils.h: Same.
 568         * coff-pe-read.c: Same.
 569         * coffread.c: Same.
 570         * compile/compile-cplus-symbols.c: Same.
 571         * compile/compile-object-run.c: Same.
 572         * completer.c: Same.
 573         * corelow.c: Same.
 574         * cp-support.c: Same.
 575         * demangle.c: Same.
 576         * dwarf-index-write.c: Same.
 577         * dwarf2-frame.c: Same.
 578         * dwarf2-frame.h: Same.
 579         * eval.c: Same.
 580         * frame-base.h: Same.
 581         * frame.h: Same.
 582         * gdbcmd.h: Same.
 583         * gdbtypes.h: Same.
 584         * gnu-nat.c: Same.
 585         * guile/scm-objfile.c: Same.
 586         * i386-tdep.c: Same.
 587         * i386-tdep.h: Same.
 588         * infcall.c: Same.
 589         * infcall.h: Same.
 590         * linux-nat.c: Same.
 591         * m68k-tdep.c: Same.
 592         * macroexp.c: Same.
 593         * memattr.c: Same.
 594         * mi/mi-cmd-disas.c: Same.
 595         * mi/mi-getopt.h: Same.
 596         * mi/mi-main.c: Same.
 597         * minsyms.c: Same.
 598         * nat/aarch64-sve-linux-sigcontext.h: Same.
 599         * objfiles.h: Same.
 600         * ppc-linux-nat.c: Same.
 601         * ppc-linux-tdep.c: Same.
 602         * ppc-tdep.h: Same.
 603         * progspace.h: Same.
 604         * prologue-value.h: Same.
 605         * python/py-evtregistry.c: Same.
 606         * python/py-instruction.h: Same.
 607         * record-btrace.c: Same.
 608         * record-full.c: Same.
 609         * remote.c: Same.
 610         * rs6000-tdep.c: Same.
 611         * ser-tcp.c: Same.
 612         * sol-thread.c: Same.
 613         * sparc-sol2-tdep.c: Same.
 614         * sparc64-tdep.c: Same.
 615         * stabsread.c: Same.
 616         * symfile.c: Same.
 617         * symtab.h: Same.
 618         * target.c: Same.
 619         * tracepoint.c: Same.
 620         * tui/tui-data.h: Same.
 621         * tui/tui-io.c: Same.
 622         * tui/tui-win.c: Same.
 623         * tui/tui.c: Same.
 624         * unittests/rsp-low-selftests.c: Same.
 625         * user-regs.h: Same.
 626         * utils.c: Same.
 627         * utils.h: Same.
 628         * valarith.c: Same.
 629         * valops.c: Same.
 630         * valprint.c: Same.
 631         * valprint.h: Same.
 632         * value.c: Same.
 633         * value.h: Same.
 634         * varobj.c: Same.
 635         * x86-nat.h: Same.
 636         * xtensa-tdep.c: Same.
 637
 638 2019-10-25  Ali Tamur <tamur@google.com>
 639
 640         * charset.c (find_charset_names): Reflect API change.
 641
 642 2019-10-25  Christian Biesinger  <cbiesinger@google.com>
 643
 644         * symtab.c (struct demangled_name_entry): Change demangled name
 645         to a unique_xmalloc_ptr<char>, now that we don't allocate it as
 646         part of the struct anymore.
 647         (symbol_set_names): No longer obstack allocate + copy the demangled
 648         name, just store the allocated name from bfd.
 649
 650 2019-10-25  Tom Tromey  <tromey@adacore.com>
 651
 652         * dwarf2-frame.c (dwarf2_cie_table): Now a typedef.
 653         (bsearch_cie_cmp, add_cie): Remove.
 654         (find_cie): Reimplement.
 655         (decode_frame_entry_1, decode_frame_entry): Change type.  Update.
 656         (dwarf2_build_frame_info): Update.
 657
 658 2019-10-24  H.J. Lu  <hongjiu.lu@intel.com>
 659
 660         PR gdb/25126
 661         * symfile.c (reread_symbols): Call forget_cached_source_info to
 662         clear the stale source cache.
 663
 664 2019-10-24  Christian Biesinger  <cbiesinger@google.com>
 665
 666         * configure: Regenerate.
 667         * configure.ac: Remove code that sets python_has_threads.
 668
 669 2019-10-24  Christian Biesinger  <cbiesinger@google.com>
 670
 671         * config.in: Regenerate.
 672         * configure: Regenerate.
 673         * configure.ac: Remove the code that uses sed to get the python
 674         version and defines HAVE_LIBPYTHON2_6 / HAVE_LIBPYTHON2_7.
 675
 676 2019-10-24  Andrew Burgess  <andrew.burgess@embecosm.com>
 677
 678         * python/py-progspace.c (pspy_block_for_pc): Return None for all
 679         error paths.
 680
 681 2019-10-23  Tom Tromey  <tom@tromey.com>
 682
 683         * arc-tdep.c: Remove ".." from include.
 684         * frv-tdep.c: Remove ".." from include.
 685         * lm32-tdep.c: Remove ".." from include.
 686         * microblaze-tdep.c: Remove ".." from include.
 687         * or1k-tdep.h: Remove ".." from include.
 688         * s12z-tdep.c: Remove ".." from include.
 689         * Makefile.in (OPCODES_CFLAGS): Add comment.
 690         (TOP_CFLAGS): New variable.
 691         (INTERNAL_CFLAGS_BASE): Add TOP_CFLAGS.
 692
 693 2019-10-23  Tom Tromey  <tom@tromey.com>
 694
 695         * Makefile.in (READLINE_DIR): Update.
 696
 697 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 698
 699         * infcall.c (call_function_by_hand_dummy): Fix the function
 700         comment.  And extract out a code section into...
 701         (reserve_stack_space): ...this new function.
 702
 703 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 704
 705         * infcall.c (value_arg_coerce): Remove an unused parameter.
 706         (call_function_by_hand_dummy): Update the call to
 707         'value_arg_coerce'.
 708
 709 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 710
 711         * infcall.c (call_function_by_hand_dummy): Refactor.
 712
 713 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 714
 715         * MAINTAINERS (Write After Approval): Add Tankut Baris Aktemur.
 716
 717 2019-10-23  Tom Tromey  <tom@tromey.com>
 718
 719         * configure: Rebuild.
 720         * configure.ac: Don't check for sigprocmask.
 721         * gdbsupport/common.m4 (GDB_AC_COMMON): Check for sigprocmask.
 722
 723 2019-10-23  Tom Tromey  <tom@tromey.com>
 724
 725         * configure: Rebuild.
 726         * acinclude.m4: Use m4_include, not sinclude.
 727
 728 2019-10-23  Tom de Vries  <tdevries@suse.de>
 729
 730         PR breakpoints/24687
 731         * symtab.c (iterate_over_some_symtabs): Apply gdb_realpath on fullname.
 732
 733 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
 734
 735         * symtab.c (struct demangled_name_entry) <language>: Change from
 736         bitfield to regular variable.
 737
 738 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
 739
 740         * symtab.c (struct demangled_name_entry): Add a constructor.
 741         (free_demangled_name_entry): New function to call the destructor
 742         for demangled_name_entry.
 743         (create_demangled_names_hash): Pass free_demangled_name_entry to
 744         htab_create_alloc.
 745         (symbol_set_names): Call placement new for demangled_name_entry.
 746         * utils.c: No longer include xxhash.h here, now that fast_hash
 747         is inlined in the header.
 748         * utils.h: Instead, include it here.
 749
 750 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
 751
 752         * Makefile.in: Link with libxxhash.
 753         * config.in: Regenerate.
 754         * configure: Regenerate.
 755         * configure.ac: Search for libxxhash.
 756         * utils.c (fast_hash): Use xxhash if present.
 757
 758 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
 759
 760         * utils.h (fast_hash): New function.
 761         * symtab.c (hash_demangled_name_entry): Call new function
 762         fast_hash.
 763
 764 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
 765
 766         * symtab.c (struct demangled_name_entry): Change type of mangled
 767         to gdb::string_view. Also adds a constructor that takes the
 768         mangled name.
 769         (hash_demangled_name_entry): Update.
 770         (eq_demangled_name_entry): Update.
 771         (free_demangled_name_entry): New function to call the destructor
 772         now that this is not a POD anymore.
 773         (create_demangled_names_hash): Pass free_demangled_name_entry to
 774         htab_create_alloc.
 775         (symbol_set_names): Update.
 776
 777 2019-10-21  Ali Tamur  <tamu@google.com>
 778
 779         * dwarf2read.c (dir_index): Change type.
 780         (file_name_index): Likewise.
 781         (line_header::include_dir_at): Change comment and implementation on
 782         whether it is DWARF 5.
 783         (line_header::is_valid_file_index): New function.
 784         (line_header::file_name_at): Change comment and implementation on
 785         whether it is DWARF 5.
 786         (line_header::file_names): Change to private field renamed as
 787         m_file_names and introduce a new accessor method.
 788         (line_header::file_names_size): New method.
 789         (line_header::include_dirs): Change to private field and rename as
 790         m_include_dirs.
 791         (dw2_get_file_names_reader): Define local var at a smaller scope and
 792         reflect API change.
 793         (dwarf2_cu::setup_type_unit_groups): Reflect API change.
 794         (process_structure_scope): Likewise.
 795         (line_header::add_include_dir): Change message and reflect renaming.
 796         (line_header::add_file_name): Likewise.
 797         (read_formatted_entries): Handle DW_FORM_data16.
 798         (dwarf_decode_line_header): Fix line header length calculation.
 799         (psymtab_include_file_name): Change comment and API.
 800         (lnp_state_machine::m_file): Update comment and reflect type change.
 801         (lnp_state_machine::record_line): Reflect type change.
 802         (dwarf_decode_lines): Reflect API change.
 803         (file_file_name): Likewise.
 804         (file_full_name): Likewise.
 805
 806 2019-10-21  Andrew Burgess  <andrew.burgess@embecosm.com>
 807
 808         * objfiles.c (sort_cmp): Ensure that !(a < a) holds true.
 809
 810 2019-10-21  Tom Tromey  <tom@tromey.com>
 811
 812         * tui/tui-winsource.h (tui_exec_info_content): Remove typedef.
 813
 814 2019-10-21  Tom Tromey  <tom@tromey.com>
 815
 816         * configure.ac (nm.h): Conditionally create nm.h link.  Subst
 817         NM_H.   Use AC_CONFIG_LINKS.
 818         * configure: Rebuild.
 819         * Makefile.in (NM_H): New variable.
 820         (generated_files): Add NM_H.  Remove gcore.
 821         (nm.h, stamp-nmh): New targets.
 822
 823 2019-10-20  Tom Tromey  <tom@tromey.com>
 824
 825         * objfiles.h (unlink_objfile, put_objfile_before): Don't declare.
 826         * objfiles.c (unlink_objfile): Move earlier.  Now static.  Remove
 827         obsolete comment.
 828         (put_objfile_before): Now static.
 829
 830 2019-10-19  Simon Marchi  <simon.marchi@polymtl.ca>
 831
 832         * gdbsupport/common-utils.h (startswith): Change return type to
 833         bool.
 834
 835 2019-10-19  Christian Biesinger  <cbiesinger@google.com>
 836
 837         * bcache.c (bcache::print_statistics): Use std::sort instead of qsort.
 838         * breakpoint.c (bp_locations_compare): Rename to...
 839         (bp_location_is_less_than): ...this, and change to std::sort semantics.
 840         (update_global_location_list): Use std::sort instead of qsort.
 841         * buildsym.c (compare_line_numbers): Rename to...
 842         (lte_is_less_than): ...this, and change to std::sort semantics.
 843         (buildsym_compunit::end_symtab_with_blockvector): Use std::sort
 844         instead of qsort.
 845         * disasm.c (compare_lines): Rename to...
 846         (line_is_less_than): ...this, and change to std::sort semantics.
 847         (do_mixed_source_and_assembly_deprecated): Call std::sort instead
 848         of qsort.
 849         * dwarf2-frame.c (qsort_fde_cmp): Rename to...
 850         (fde_is_less_than): ...this, and change to std::sort semantics.
 851         (dwarf2_build_frame_info): Call std::sort instead of qsort.
 852         * mdebugread.c (compare_blocks):
 853         (block_is_less_than): ...this, and change to std::sort semantics.
 854         (sort_blocks): Call std::sort instead of qsort.
 855         * objfiles.c (qsort_cmp): Rename to...
 856         (sort_cmp): ...this, and change to std::sort semantics.
 857         (update_section_map): Call std::sort instead of qsort.
 858         * remote.c (compare_pnums): Remove.
 859         (map_regcache_remote_table): Call std::sort instead of qsort.
 860         * utils.c (compare_positive_ints): Remove.
 861         * utils.h (compare_positive_ints): Remove.
 862         * xcoffread.c (compare_lte): Remove.
 863         (arrange_linetable): Call std::sort instead of qsort.
 864
 865 2019-10-19  Sergio Durigan Junior  <sergiodj@redhat.com>
 866
 867         * symfile.c (init_entry_point_info): Fix typo.
 868         * i386-darwin-tdep.c (darwin_dwarf_signal_frame_p): Fix typo.
 869
 870 2019-10-18  Tom de Vries  <tdevries@suse.de>
 871
 872         * aarch64-tdep.c: Fix typos in comments.
 873         * ada-lang.c: Same.
 874         * ada-tasks.c: Same.
 875         * alpha-tdep.c: Same.
 876         * alpha-tdep.h: Same.
 877         * amd64-nat.c: Same.
 878         * amd64-windows-tdep.c: Same.
 879         * arc-tdep.c: Same.
 880         * arc-tdep.h: Same.
 881         * arch-utils.c: Same.
 882         * arm-nbsd-tdep.c: Same.
 883         * arm-tdep.c: Same.
 884         * ax-gdb.c: Same.
 885         * blockframe.c: Same.
 886         * btrace.c: Same.
 887         * c-varobj.c: Same.
 888         * coff-pe-read.c: Same.
 889         * coffread.c: Same.
 890         * cris-tdep.c: Same.
 891         * darwin-nat.c: Same.
 892         * dbxread.c: Same.
 893         * dcache.c: Same.
 894         * disasm.c: Same.
 895         * dtrace-probe.c: Same.
 896         * dwarf-index-write.c: Same.
 897         * dwarf2-frame-tailcall.c: Same.
 898         * dwarf2-frame.c: Same.
 899         * dwarf2read.c: Same.
 900         * eval.c: Same.
 901         * exceptions.c: Same.
 902         * fbsd-tdep.c: Same.
 903         * findvar.c: Same.
 904         * frame.c: Same.
 905         * frv-tdep.c: Same.
 906         * gnu-v3-abi.c: Same.
 907         * go32-nat.c: Same.
 908         * h8300-tdep.c: Same.
 909         * hppa-tdep.c: Same.
 910         * i386-linux-tdep.c: Same.
 911         * i386-tdep.c: Same.
 912         * ia64-libunwind-tdep.c: Same.
 913         * ia64-tdep.c: Same.
 914         * infcmd.c: Same.
 915         * infrun.c: Same.
 916         * linespec.c: Same.
 917         * linux-nat.c: Same.
 918         * linux-thread-db.c: Same.
 919         * machoread.c: Same.
 920         * mdebugread.c: Same.
 921         * mep-tdep.c: Same.
 922         * mn10300-tdep.c: Same.
 923         * namespace.c: Same.
 924         * objfiles.c: Same.
 925         * opencl-lang.c: Same.
 926         * or1k-tdep.c: Same.
 927         * osabi.c: Same.
 928         * ppc-linux-nat.c: Same.
 929         * ppc-linux-tdep.c: Same.
 930         * ppc-sysv-tdep.c: Same.
 931         * printcmd.c: Same.
 932         * procfs.c: Same.
 933         * record-btrace.c: Same.
 934         * record-full.c: Same.
 935         * remote-fileio.c: Same.
 936         * remote.c: Same.
 937         * rs6000-tdep.c: Same.
 938         * s12z-tdep.c: Same.
 939         * score-tdep.c: Same.
 940         * ser-base.c: Same.
 941         * ser-go32.c: Same.
 942         * skip.c: Same.
 943         * sol-thread.c: Same.
 944         * solib-svr4.c: Same.
 945         * solib.c: Same.
 946         * source.c: Same.
 947         * sparc-nat.c: Same.
 948         * sparc-sol2-tdep.c: Same.
 949         * sparc-tdep.c: Same.
 950         * sparc64-tdep.c: Same.
 951         * stabsread.c: Same.
 952         * stack.c: Same.
 953         * symfile.c: Same.
 954         * symtab.c: Same.
 955         * target-descriptions.c: Same.
 956         * target-float.c: Same.
 957         * thread.c: Same.
 958         * utils.c: Same.
 959         * valops.c: Same.
 960         * valprint.c: Same.
 961         * value.c: Same.
 962         * varobj.c: Same.
 963         * windows-nat.c: Same.
 964         * xcoffread.c: Same.
 965         * xstormy16-tdep.c: Same.
 966         * xtensa-tdep.c: Same.
 967
 968 2019-10-17  Tom Tromey  <tromey@adacore.com>
 969
 970         * configure: Rebuild.
 971         * configure.ac: Use AC_CONFIG_HEADERS.  Create stamp-h there, not
 972         in AC_CONFIG_FILES invocation.
 973         * Makefile.in (Makefile, data-directory/Makefile, stamp-h): Use
 974         new-style config.status invocation.
 975
 976 2019-10-17  Tom de Vries  <tdevries@suse.de>
 977
 978         * arm-nbsd-nat.c: Fix typos in comments.
 979         * arm-tdep.c: Same.
 980         * darwin-nat-info.c: Same.
 981         * dwarf2read.c: Same.
 982         * elfread.c: Same.
 983         * event-top.c: Same.
 984         * findvar.c: Same.
 985         * gdbtypes.c: Same.
 986         * hppa-tdep.c: Same.
 987         * i386-tdep.c: Same.
 988         * jit.c: Same.
 989         * main.c: Same.
 990         * mdebugread.c: Same.
 991         * moxie-tdep.c: Same.
 992         * nto-procfs.c: Same.
 993         * osabi.c: Same.
 994         * ppc-linux-tdep.c: Same.
 995         * remote.c: Same.
 996         * riscv-tdep.c: Same.
 997         * s390-tdep.c: Same.
 998         * sh-tdep.c: Same.
 999         * sparc-linux-tdep.c: Same.
1000         * sparc-nat.c: Same.
1001         * stack.c: Same.
1002         * target-descriptions.c: Same.
1003         * top.c: Same.
1004         * varobj.c: Same.
1005
1006 2019-10-16  Tom Tromey  <tom@tromey.com>
1007
1008         * objfiles.h (struct objfile) <original_name>: Now const.
1009
1010 2019-10-16  Christian Biesinger  <cbiesinger@google.com>
1011
1012         * gdbsupport/gdb_setjmp.h (SIGSETJMP): Allow passing in the value to
1013         pass on to sigsetjmp's second argument.
1014         * cp-support.c (gdb_demangle): Unblock SIGSEGV if we caught a crash.
1015
1016 2019-10-16  Keith Seitz  <keiths@redhat.com>
1017
1018         PR gdb/23567
1019         * dwarf2read.c (dwarf2_per_objfile::locate_sections): Discard
1020         sections whose size is greater than the file size.
1021
1022 2019-10-16  Jim Wilson  <jimw@sifive.com>
1023
1024         * riscv-tdep.c (riscv_gcc_target_options): New.
1025         (riscv_gnu_triplet_regexp): New.
1026         (riscv_gdbarch_init): Call set_gdbarch_gcc_triplet_options and
1027         set_gdbarch_gnu_triplet_regexp.
1028
1029 2019-10-16  Christian Biesinger  <cbiesinger@google.com>
1030
1031         * Makefile.in: Add xml-builtin.h.
1032         * features/feature_to_c.sh: Add an include for xml-builtin.h
1033         to ensure that the compiler checks that the types match.
1034         * xml-builtin.h: New file.
1035         * xml-support.c (fetch_xml_builtin): Add missing const.
1036         * xml-support.h: Remove declaration of xml_builtins.
1037
1038 2019-10-16  Tom de Vries  <tdevries@suse.de>
1039
1040         PR tdep/25096
1041         * amd64-tdep.c (amd64_classify_aggregate_field): Factor out of ...
1042         (amd64_classify_aggregate): ... here.
1043         (amd64_classify_aggregate_field): Handled fiels of nested structs
1044         recursively.
1045
1046 2019-10-16  Tom de Vries  <tdevries@suse.de>
1047
1048         PR tdep/24104
1049         * amd64-tdep.c (amd64_push_arguments): Handle AMD64_NO_CLASS in loop
1050         that handles 'theclass'.
1051
1052 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1053
1054         * linespec.c (decode_digits_ordinary): Update comment.
1055         * make-target-delegates: No longer need to handle VEC case.
1056         * memrange.c (normalize_mem_ranges): Update comment.
1057         * namespace.c (add_using_directive): Update comment.
1058         * objc-lang.c (uniquify_strings): Update comment.
1059         * ppc-linux-nat.c (struct thread_points): Update comment.
1060         * probe.h (find_probes_in_objfile): Update comment.
1061         * target.h (enum flash_preserve_mode): Update comment.
1062         * varobj.c (varobj_restrict_range): Update comment.
1063         * varobj.h (varobj_list_children): Update comment.
1064
1065 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1066
1067         * Makefile.in: Remove references to vec.h and vec.c.
1068         * aarch64-tdep.c: No longer include vec.h.
1069         * ada-lang.c: Likewise.
1070         * ada-lang.h: Likewise.
1071         * arm-tdep.c: Likewise.
1072         * ax.h: Likewise.
1073         * breakpoint.h: Likewise.
1074         * charset.c: Likewise.
1075         * cp-support.h: Likewise.
1076         * dtrace-probe.c: Likewise.
1077         * dwarf2read.c: Likewise.
1078         * extension.h: Likewise.
1079         * gdb_bfd.c: Likewise.
1080         * gdbsupport/gdb_vecs.h: Likewise.
1081         * gdbsupport/vec.c: Remove.
1082         * gdbsupport/vec.h: Remove.
1083         * gdbthread.h: Likewise.
1084         * guile/scm-type.c: Likewise.
1085         * inline-frame.c: Likewise.
1086         * machoread.c: Likewise.
1087         * memattr.c: Likewise.
1088         * memrange.h: Likewise.
1089         * namespace.h: Likewise.
1090         * nat/linux-btrace.h: Likewise.
1091         * osdata.c: Likewise.
1092         * parser-defs.h: Likewise.
1093         * progspace.h: Likewise.
1094         * python/py-type.c: Likewise.
1095         * record-btrace.c: Likewise.
1096         * rust-exp.y: Likewise.
1097         * solib-target.c: Likewise.
1098         * stap-probe.c: Likewise.
1099         * target-descriptions.c: Likewise.
1100         * target-memory.c: Likewise.
1101         * target.h: Likewise.
1102         * varobj.c: Likewise.
1103         * varobj.h: Likewise.
1104         * xml-support.h: Likewise.
1105
1106 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1107
1108         * gdb/dwarf2read.c (dwarf2_per_objfile::~dwarf2_per_objfile):
1109         Update for new std::vector based implementation.
1110         (process_psymtab_comp_unit_reader): Likewise.
1111         (scan_partial_symbols): Likewise.
1112         (recursively_compute_inclusions): Likewise.
1113         (compute_compunit_symtab_includes): Likewise.
1114         (process_imported_unit_die): Likewise.
1115         (queue_and_load_dwo_tu): Likewise.
1116         (follow_die_sig_1): Likewise.
1117         * gdb/dwarf2read.h: Remove DEF_VEC_P.
1118         (typedef dwarf2_per_cu_ptr): Remove.
1119         (struct dwarf2_per_cu_data) <imported_symtabs_empty>: New
1120         function.
1121         (struct dwarf2_per_cu_data) <imported_symtabs_push>: New function.
1122         (struct dwarf2_per_cu_data) <imported_symtabs_size>: New function.
1123         (struct dwarf2_per_cu_data) <imported_symtabs_free>: New function.
1124         (struct dwarf2_per_cu_data) <imported_symtabs>: Change to
1125         std::vector.
1126
1127 2019-10-15  Tom Tromey  <tromey@adacore.com>
1128
1129         * windows-nat.c (windows_nat_target::resume): Use %x when logging
1130         TID.
1131
1132 2019-10-15  Tom Tromey  <tromey@adacore.com>
1133
1134         * windows-nat.c (windows_nat_target::fetch_registers)
1135         (windows_nat_target::store_registers): Rename "pid" to "tid".
1136
1137 2019-10-15  Tom Tromey  <tromey@adacore.com>
1138
1139         * gdbarch.h, gdbarch.c: Rebuild.
1140         * gdbarch.sh (gcc_target_options): Change return type to
1141         std::string.
1142         * compile/compile.c (get_args): Update.
1143         * nios2-tdep.c (nios2_gcc_target_options): Return std::string.
1144         * arm-linux-tdep.c (arm_linux_gcc_target_options): Return
1145         std::string.
1146         * aarch64-linux-tdep.c (aarch64_linux_gcc_target_options): Return
1147         std::string.
1148         * arch-utils.c (default_gcc_target_options): Return std::string.
1149         * arch-utils.h (default_gcc_target_options): Return std::string.
1150         * s390-tdep.c (s390_gcc_target_options): Return std::string.
1151
1152 2019-10-15  Christian Biesinger  <cbiesinger@google.com>
1153
1154         * breakpoint.c (breakpoint_chain): Make static.
1155         * tui/tui-winsource.c: Call iterate_over_breakpoints instead
1156         of accessing breakpoint_chain.
1157
1158 2019-10-15  Christian Biesinger  <cbiesinger@google.com>
1159
1160         * breakpoint.c (iterate_over_breakpoints): Change function pointer
1161         to a gdb::function_view and return value to bool.
1162         * breakpoint.h (iterate_over_breakpoints): Likewise.
1163         * dummy-frame.c (pop_dummy_frame_bpt): Update.
1164         (pop_dummy_frame): Update.
1165         * guile/scm-breakpoint.c (bpscm_build_bp_list): Update.
1166         (gdbscm_breakpoints): Update.
1167         * python/py-breakpoint.c (build_bp_list): Update.
1168         (gdbpy_breakpoints): Update.
1169         * python/py-finishbreakpoint.c (bpfinishpy_detect_out_scope_cb):
1170         Update.
1171         (bpfinishpy_handle_stop): Update.
1172         (bpfinishpy_handle_exit): Update.
1173         * solib-svr4.c (svr4_update_solib_event_breakpoint): Update.
1174         (svr4_update_solib_event_breakpoints): Update.
1175
1176 2019-10-15  Andreas Arnez  <arnez@linux.ibm.com>
1177
1178         * s390-tdep.c (s390_effective_inner_type): Ignore static fields
1179         when unwrapping single-field structs.
1180
1181 2019-10-14  Simon Marchi  <simon.marchi@polymtl.ca>
1182
1183         * dwarf2read.c: Remove includes.
1184
1185 2019-10-13  Simon Marchi  <simon.marchi@polymtl.ca>
1186
1187         * ui-out.c (ui_out::call_do_message): Silence
1188         -Wformat-nonliteral warning.
1189
1190 2019-10-12  Simon Marchi  <simon.marchi@polymtl.ca>
1191
1192         * breakpoint.c: Remove some includes: continuations.h, skip.h,
1193         mi/mi-main.h, readline/readline.h, readline/history.h.  Add
1194         include: readline/tilde.h.
1195
1196 2019-10-12  Christian Biesinger  <cbiesinger@google.com>
1197
1198         * remote.c (remote_target::get_trace_status): Remove declaration of
1199         trace_regblock_size.
1200
1201 2019-10-12  Christian Biesinger  <cbiesinger@google.com>
1202
1203         * cli/cli-cmds.c (max_user_call_depth): Move comment to header.
1204         (show_user): Remove declaration of cmdlist.
1205         * cli/cli-cmds.h (max_user_call_depth): Declare.
1206         * cli/cli-script.c (execute_user_command): Remove declaration
1207         of max_user_call_depth.
1208
1209 2019-10-11  Jim Wilson  <jimw@sifive.com>
1210
1211         * gdbsupport/print-utils.h (pulongest): Fix comment.
1212         (plongest): Likewise.
1213         (phex): Add missing comment, mention leading zeros.
1214         (phex_nz): Add mention of no leading zeros to comment.
1215
1216         * riscv-tdep.c (riscv_push_dummy_code): Change %lld to %s and use
1217         plongest instead of unsigned long long cast.
1218
1219 2019-10-10  Christian Biesinger  <cbiesinger@google.com>
1220
1221         * main.c (captured_main_1): Include gdbtk.h and remove declarations
1222         for external_editor_command and gdbtk_test.
1223
1224 2019-10-10  Christian Biesinger  <cbiesinger@google.com>
1225
1226         * mi/mi-cmd-var.c (varobjdebug): Remove declaration.
1227         * varobj.c (varobjdebug): Move comment to...
1228         * varobj.h (varobjdebug): ...here, and declare.
1229
1230 2019-10-09  Tom Tromey  <tom@tromey.com>
1231
1232         * tui/tui-regs.c (tui_data_window::show_registers): Don't call
1233         erase_data_content.
1234
1235 2019-10-09  Tom Tromey  <tom@tromey.com>
1236
1237         * tui/tui-wingeneral.h (tui_delete_win): Don't declare.
1238         * tui/tui-stack.c (tui_locator_window::rerender): Update.
1239         * tui/tui-command.c (tui_cmd_window::resize)
1240         (tui_refresh_cmd_win): Update.
1241         * tui/tui-win.c (tui_resize_all, tui_set_focus_command): Update.
1242         * tui/tui.c (tui_rl_other_window, tui_enable): Update.
1243         * tui/tui-data.c (~tui_gen_win_info): Remove.
1244         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
1245         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
1246         (tui_redisplay_readline, tui_mld_flush)
1247         (tui_mld_erase_entire_line, tui_mld_getc, tui_getc): Update.
1248         * tui/tui-regs.c (tui_data_window::delete_data_content_windows)
1249         (tui_data_window::erase_data_content)
1250         (tui_data_item_window::rerender)
1251         (tui_data_item_window::refresh_window): Update.
1252         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window)
1253         (box_win, tui_gen_win_info::make_window)
1254         (tui_gen_win_info::make_visible): Update.
1255         (tui_delete_win): Remove.
1256         * tui/tui-winsource.c
1257         (tui_source_window_base::do_erase_source_content): Update.
1258         (tui_show_source_line, tui_source_window_base::update_tab_width)
1259         (tui_source_window_base::update_exec_info): Update.
1260         * tui/tui-data.h (struct curses_deleter): New.
1261         (struct tui_gen_win_info) <handle>: Now a unique_ptr.
1262         (struct tui_gen_win_info) <~tui_gen_win_info>: Define.
1263
1264 2019-10-09  Tom Tromey  <tom@tromey.com>
1265
1266         * tui/tui-wingeneral.h (struct tui_gen_win_info): Don't declare.
1267
1268 2019-10-09  Tom Tromey  <tom@tromey.com>
1269
1270         * tui/tui-data.c (tui_win_is_auxiliary): Remove.
1271         * tui/tui-data.h (tui_win_is_auxiliary): Don't declare.
1272
1273 2019-10-09  Tom Tromey  <tom@tromey.com>
1274
1275         * tui/tui-disasm.c (tui_get_low_disassembly_address): Compute
1276         window height directly.
1277         * tui/tui-layout.h (tui_default_win_viewport_height): Don't
1278         declare.
1279         * tui/tui-layout.c (tui_default_win_height): Remove.
1280         (tui_default_win_viewport_height): Remove.
1281
1282 2019-10-09  Tom Tromey  <tom@tromey.com>
1283
1284         * tui/tui.h: Remove comments.
1285
1286 2019-10-09  Tom de Vries  <tdevries@suse.de>
1287
1288         * python/lib/gdb/printer/bound_registers.py: Use
1289         '^builtin_type_bound128' as regexp argument for
1290         add_builtin_pretty_printer.
1291
1292 2019-10-09  Christian Biesinger  <cbiesinger@google.com>
1293
1294         * guile/guile.c (guile_extension_script_ops): Remove forward
1295         declaration and mark as static.
1296         (guile_script_ops): Likewise.
1297         (extension_language_guile): Move further down in the file so
1298         it can reference the definitions for guile_{extension_,}script_ops.
1299
1300 2019-10-09  Andreas Arnez  <arnez@linux.ibm.com>
1301
1302         * s390-tdep.c (390_process_record): Handle new arch13 instructions
1303         except SORTL, DFLTCC, and KDSA.
1304
1305 2019-10-08  Tom Tromey  <tromey@adacore.com>
1306
1307         * windows-nat.c (struct windows_thread_info_struct) <sf>: Remove.
1308         (struct safe_symbol_file_add_args): Remove.
1309
1310 2019-10-08  Tom Tromey  <tromey@adacore.com>
1311
1312         * windows-nat.c: Don't include buildsym-legacy.h.
1313
1314 2019-10-08  Tom Tromey  <tromey@adacore.com>
1315
1316         * contrib/ari/gdb_ari.sh (%p): Allow gdb-specific %p extensions.
1317
1318 2019-10-08  Christian Biesinger  <cbiesinger@google.com>
1319
1320         * gdbtypes.c (overload_debug): Move comment to header.
1321         * gdbtypes.h (overload_debug): Declare.
1322         * valops.c: Remove declaration of overload_debug, instead
1323         include gdbtypes.h.
1324
1325 2019-10-08  Christian Biesinger  <cbiesinger@google.com>
1326
1327         * language.c (show_language_command): Pass lang_frame_mismatch_warn
1328         through _().
1329         (lang_frame_mismatch_warn): Make const, mark with N_(), and
1330         move comment...
1331         * language.h (lang_frame_mismatch_warn): ... here. Also add
1332         declaration.
1333         * top.c (lang_frame_mismatch_warn): Remove declaration.
1334         (check_frame_language_change): Pass lang_frame_mismatch_warn
1335         through _().
1336
1337 2019-10-07  Christian Biesinger  <cbiesinger@google.com>
1338
1339         * c-lang.h (vtbl_ptr_name): Declare.
1340         * cp-valprint.c (vtbl_ptr_name): Remove "extern" now that we get
1341         it from the header.
1342         * stabsread.c (define_symbol): Remove declaration of vtbl_ptr_name.
1343
1344 2019-10-07  Christian Biesinger  <cbiesinger@google.com>
1345
1346         * charset.c (your_gdb_wchar_t_is_bogus): Replace with a
1347         gdb_static_assert.
1348
1349 2019-10-07  Weimin Pan  <weimin.pan@oracle.com>
1350
1351         * ../Makefile.def (dependencies): Add all-libctf to all-gdb
1352         * ../Makefile.in: Add "all-gdb: maybe-all-libctf"
1353         * ctfread.c: New file.
1354         * ctfread.h: New file.
1355         * elfread.c: Include ctfread.h.
1356         (struct elfinfo text_p): New member ctfsect.
1357         (elf_locate_sections): Mark CTF section.
1358         (elf_symfile_read): Call elfctf_build_psymtabs.
1359         * Makefile.in (LIBCTF): Add.
1360         (CLIBS): Use it.
1361         (CDEPS): Likewise.
1362         (DIST): Add ctfread.c.
1363
1364 2019-10-07  Andrew Burgess  <andrew.burgess@embecosm.com>
1365
1366         * ctfread.c (struct nextfield): Renamed to ...
1367         (struct ctf_nextfield): ... this.
1368         (struct field_info): Renamed to ...
1369         (strut ctf_field_info): ... this.
1370         (attach_fields_to_type): Update for renamed structures.
1371         (ctf_add_member_cb): Likewise.
1372         (ctf_add_enum_member_cb): Likewise.
1373         (process_struct_members): Likewise.
1374         (process_enum_type): Likewise.
1375
1376 2019-10-07  Weimin Pan  <weimin.pan@oracle.com>
1377
1378         * tracectf.h: Rename, was ctf.h.
1379         * tracectf.c: Rename, was ctf.c, replace ctf.h with tracectf.h.
1380         * tracefile.c: Likewise.
1381         * tracepoint.c: Remove unused include ctf.h.
1382         * mi/mi-main.c: Likewise.
1383         * Makefile.in Replace ctf.c with tracectf.c.
1384
1385 2019-10-06  Joel Brobecker  <brobecker@adacore.com>
1386
1387         * version.in: Change version number to "9.0.50.DATE-git".
1388
1389 2019-10-03  Tom Tromey  <tom@tromey.com>
1390
1391         PR rust/24976:
1392         * dwarf2read.c (quirk_rust_enum): Handle single-element unions.
1393
1394 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1395
1396         * f-lang.c (f_language_defn): Use cp_get_symbol_name_matcher and
1397         cp_search_name_hash.
1398         * NEWS: Add entry about nested function support.
1399
1400 2019-10-03  Bernhard Heckel  <bernhard.heckel@intel.com>
1401             Andrew Burgess  <andrew.burgess@embecosm.com>
1402
1403         * cp-namespace.c (cp_search_static_and_baseclasses): Only search
1404         for nested static variables when searchin VAR_DOMAIN.
1405         * dwarf2read.c (add_partial_symbol): Add nested subroutines to the
1406         global scope, update comment.
1407         (add_partial_subprogram): Call add_partial_subprogram recursively
1408         for nested subroutines when processinng Fortran.
1409         (load_partial_dies): Process the child entities of a subprogram
1410         when processing Fortran.
1411         (partial_die_parent_scope): Handle building scope
1412         for Fortran nested functions.
1413         (process_die): Record that nested functions have a scope.
1414         (new_symbol): Always record Fortran subprograms on the global
1415         symbol list.
1416         (determine_prefix): How to build the prefix for Fortran
1417         subprograms.
1418
1419 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1420
1421         * linux-nat.c (linux_nat_filter_event): Don't ignore SIGSTOP if we
1422         have just sent the thread a SIGSTOP and are waiting for it to
1423         arrive.
1424
1425 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1426
1427         * btrace.c (btrace_add_pc): Remove whitespace before the template
1428         parameter in 'std::vector <...>'.
1429         (parse_xml_btrace_block): Likewise.
1430         (btrace_maint_decode_pt): Likewise.
1431         (btrace_maint_update_packets): Likewise.
1432         (btrace_maint_print_packets): Likewise.
1433         * btrace.h (struct btrace_maint_info): Likewise.
1434         * dwarf2read.c (struct type_unit_group): Likewise.
1435         (build_type_psymtabs_reader): Likewise.
1436         * gdbsupport/btrace-common.c (btrace_data_append): Likewise.
1437         * gdbsupport/btrace-common.h (struct btrace_data_bts): Likewise.
1438         * nat/linux-btrace.c (perf_event_read_bts): Likewise.
1439
1440 2019-10-03  Tom de Vries  <tdevries@suse.de>
1441
1442         * cli/cli-style.c (_initialize_cli_style): Adding a '.' at the end of
1443         the first line of the help text for set/show style metadata.
1444
1445 2019-10-02  Tom Tromey  <tromey@adacore.com>
1446
1447         * Makefile.in (COMMON_SFILES): Add common-inferior.c.
1448         * gdbsupport/common-inferior.c: New file.
1449         * infcmd.c (startup_with_shell): Don't define.
1450         * nat/fork-inferior.h (startup_with_shell): Don't declare.
1451         * gdbsupport/common-inferior.h (startup_with_shell): Declare.
1452         * inferior.h (startup_with_shell): Don't declare.
1453
1454 2019-10-02  Christian Biesinger  <cbiesinger@google.com>
1455
1456         * gdbsupport/gdb_assert.h: Include errors.h.
1457         * gdbsupport/gdb_string_view.h: Include gdb_assert.h.
1458
1459 2019-10-02  Tom Tromey  <tromey@adacore.com>
1460
1461         * NEWS: Add $_ada_exception entry.
1462         * ada-lang.c (struct ada_catchpoint): Add constructor.
1463         <m_kind>: New member.
1464         (allocate_location_exception, re_set_exception): Remove
1465         "ex" parameter.
1466         (should_stop_exception): Compute $_ada_exception.
1467         (check_status_exception, print_it_exception)
1468         (print_one_exception, print_mention_exception): Remove
1469         "ex" parameter.
1470         (allocate_location_catch_exception, re_set_catch_exception)
1471         (check_status_exception, print_it_catch_exception)
1472         (print_one_catch_exception, print_mention_catch_exception)
1473         (print_recreate_catch_exception)
1474         (allocate_location_catch_exception_unhandled)
1475         (re_set_catch_exception_unhandled)
1476         (check_status_exception, print_it_catch_exception_unhandled)
1477         (print_one_catch_exception_unhandled)
1478         (print_mention_catch_exception_unhandled)
1479         (print_recreate_catch_exception_unhandled)
1480         (allocate_location_catch_assert, re_set_catch_assert)
1481         (check_status_assert, print_it_catch_assert)
1482         (print_one_catch_assert, print_mention_catch_assert)
1483         (print_recreate_catch_assert)
1484         (allocate_location_catch_handlers, re_set_catch_handlers)
1485         (check_status_handlers, print_it_catch_handlers)
1486         (print_one_catch_handlers, print_mention_catch_handlers)
1487         (print_recreate_catch_handlers): Remove.
1488         (create_ada_exception_catchpoint): Update.
1489         (initialize_ada_catchpoint_ops): Update.
1490
1491 2019-10-02  Tom Tromey  <tromey@adacore.com>
1492
1493         * ada-lang.c (ada_lookup_simple_minsyms): Remove.
1494         (create_excep_cond_exprs): Simplify exception string computation.
1495         (ada_exception_catchpoint_cond_string): Likewise.
1496
1497 2019-10-02  Tom Tromey  <tromey@adacore.com>
1498
1499         * symmisc.c (dump_msymbols): Don't use MSYMBOL_VALUE_ADDRESS.
1500         * ada-lang.c (lesseq_defined_than): Handle
1501         LOC_STATIC.
1502         * dwarf2read.c (dwarf2_per_objfile): Add can_copy
1503         parameter.
1504         (dwarf2_has_info): Likewise.
1505         (new_symbol): Set maybe_copied on symbol when
1506         appropriate.
1507         * dwarf2read.h (dwarf2_per_objfile): Add can_copy
1508         parameter.
1509         <can_copy>: New member.
1510         * elfread.c (record_minimal_symbol): Set maybe_copied
1511         on symbol when appropriate.
1512         (elf_symfile_read): Update call to dwarf2_has_info.
1513         * minsyms.c (lookup_minimal_symbol_linkage): New
1514         function.
1515         * minsyms.h (lookup_minimal_symbol_linkage): Declare.
1516         * symtab.c (get_symbol_address, get_msymbol_address):
1517         New functions.
1518         * symtab.h (get_symbol_address, get_msymbol_address):
1519         Declare.
1520         (SYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_ADDRESS): Handle
1521         maybe_copied.
1522         (struct symbol, struct minimal_symbol) <maybe_copied>:
1523         New member.
1524
1525 2019-10-02  Tom Tromey  <tromey@adacore.com>
1526
1527         * source.c (struct current_source_location): New.
1528         (current_source_key): New global.
1529         (current_source_symtab, current_source_line)
1530         (current_source_pspace): Remove.
1531         (get_source_location): New function.
1532         (get_current_source_symtab_and_line)
1533         (set_default_source_symtab_and_line)
1534         (set_current_source_symtab_and_line)
1535         (clear_current_source_symtab_and_line, select_source_symtab)
1536         (info_source_command, print_source_lines_base)
1537         (info_line_command, search_command_helper, _initialize_source):
1538         Update.
1539
1540 2019-10-02  Tom Tromey  <tromey@adacore.com>
1541
1542         * source.c (select_source_symtab): Don't call
1543         decode_line_with_current_source.
1544
1545 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1546
1547         * symtab.c (lookup_global_symbol): Search global block.
1548
1549 2019-10-02  Tom Tromey  <tromey@adacore.com>
1550
1551         * coffread.c (process_coff_symbol): Update.
1552         * dwarf2read.c (var_decode_location, new_symbol): Update.
1553         * mdebugread.c (parse_symbol): Update.
1554         * objfiles.c (relocate_one_symbol): Update.
1555         * stabsread.c (define_symbol, fix_common_block)
1556         (scan_file_globals): Update.
1557         * symtab.h (SYMBOL_VALUE_ADDRESS): Expand to an rvalue.
1558         (SET_SYMBOL_VALUE_ADDRESS): New macro.
1559         * xcoffread.c (process_xcoff_symbol): Update.
1560
1561 2019-10-02  Andreas Arnez  <arnez@linux.ibm.com>
1562
1563         * MAINTAINERS: Update my email address.
1564
1565 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1566
1567         * dwarf2read.c (struct type_unit_group) <tus>: Convert to
1568         std::vector.
1569         (build_type_psymtabs_reader): Update for std::vector.
1570         (build_type_psymtab_dependencies): Likewise.
1571         * dwarf2read.h: Remove use of DEF_VEC_P.
1572         (typedef sig_type_ptr): Delete.
1573
1574 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1575
1576         * btrace.c (btrace_maint_clear): Update to handle change from VEC
1577         to std::vector.
1578         (btrace_maint_decode_pt): Likewise, and move allocation of the
1579         vector outside of the loop.
1580         (btrace_maint_update_packets): Update to handle change from VEC to
1581         std::vector.
1582         (btrace_maint_print_packets): Likewise.
1583         (maint_info_btrace_cmd): Likewise.
1584         * btrace.h: Remove use of DEF_VEC_O.
1585         (typedef btrace_pt_packet_s): Delete.
1586         (struct btrace_maint_info) <packets>: Change fromm VEC to
1587         std::vector.
1588         * gdbsupport/btrace-common.h: Remove 'vec.h' include.
1589
1590 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1591
1592         * btrace.c (btrace_compute_ftrace_bts): Update for std::vector,
1593         make accesses into the vector constant references.
1594         (btrace_add_pc): Update for std::vector.
1595         (btrace_stitch_bts): Likewise.
1596         (parse_xml_btrace_block): Likewise.
1597         (btrace_maint_update_packets): Likewise.
1598         (btrace_maint_print_packets): Likewise.
1599         (maint_info_btrace_cmd): Likewise.
1600         * gdbsupport/btrace-common.c (btrace_data::fini): Update for
1601         std::vector.
1602         (btrace_data::empty): Likewise.
1603         (btrace_data_append): Likewise.
1604         * gdbsupport/btrace-common.h: Remove use of DEF_VEC_O.
1605         (typedef btrace_block_s): Delete.
1606         (struct btrace_block): Add constructor.
1607         (struct btrace_data_bts) <blocks>: Change to std::vector.
1608         * nat/linux-btrace.c (perf_event_read_bts): Update for
1609         std::vector.
1610         (linux_read_bts): Likewise.
1611
1612 2019-10-01  Tom Tromey  <tom@tromey.com>
1613
1614         * cli/cli-logging.c (show_logging_filename): Use styled_string.
1615
1616 2019-10-01  Tom Tromey  <tom@tromey.com>
1617
1618         * stack.c (print_frame, info_frame_command_core): Use
1619         styled_string.
1620         * linux-thread-db.c (try_thread_db_load_1)
1621         (try_thread_db_load_from_pdir_1): Use styled_string.
1622         * auto-load.c (file_is_auto_load_safe, execute_script_contents)
1623         (auto_load_section_scripts, info_auto_load_local_gdbinit)
1624         (maybe_print_unsupported_script_warning)
1625         (maybe_print_script_not_found_warning): Use styled_string.
1626         * ada-lang.c (user_select_syms): Use styled_string.
1627
1628 2019-10-01  Tom Tromey  <tom@tromey.com>
1629
1630         * p-lang.c (pascal_printstr): Use metadata style.
1631         * value.c (show_convenience): Use metadata style.
1632         * valprint.c (valprint_check_validity, val_print_optimized_out)
1633         (val_print_not_saved, val_print_unavailable)
1634         (val_print_invalid_address, generic_val_print, val_print)
1635         (value_check_printable, val_print_array_elements): Use metadata
1636         style.
1637         * ui-out.h (class ui_out) <field_fmt>: New overload.
1638         <do_field_fmt>: Add style parameter.
1639         * ui-out.c (ui_out::field_fmt): New overload.
1640         * typeprint.c (type_print_unknown_return_type)
1641         (val_print_not_allocated, val_print_not_associated): Use metadata
1642         style.
1643         * tui/tui-out.h (class tui_ui_out) <do_field_fmt>: Add style
1644         parameter.
1645         * tui/tui-out.c (tui_ui_out::do_field_fmt): Update.
1646         * tracepoint.c (tvariables_info_1): Use metadata style.
1647         * stack.c (print_frame_arg, print_frame_info, print_frame)
1648         (info_frame_command_core): Use metadata style.
1649         * skip.c (info_skip_command): Use metadata style.
1650         * rust-lang.c (rust_print_enum): Use metadata style.
1651         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
1652         metadata style.
1653         * python/py-framefilter.c (py_print_single_arg): Use metadata
1654         style.
1655         * printcmd.c (do_one_display, print_variable_and_value): Use
1656         metadata style.
1657         * p-valprint.c (pascal_val_print)
1658         (pascal_object_print_value_fields): Use metadata style.
1659         * p-typeprint.c (pascal_type_print_base): Use metadata style.
1660         * mi/mi-out.h (class mi_ui_out) <do_field_fmt>: Add style
1661         parameter.
1662         * mi/mi-out.c (mi_ui_out::do_field_fmt): Update.
1663         * m2-valprint.c (m2_print_long_set): Use metadata style.
1664         * m2-typeprint.c (m2_print_type): Use metadata style.
1665         * infcmd.c (print_return_value_1): Use metadata style.
1666         * gnu-v3-abi.c (print_one_vtable): Use metadata style.
1667         * f-valprint.c (info_common_command_for_block): Use metadata
1668         style.
1669         * f-typeprint.c (f_type_print_base): Use metadata style.
1670         * expprint.c (print_subexp_standard): Use metadata style.
1671         * cp-valprint.c (cp_print_value_fields): Use metadata style.
1672         * cli/cli-style.h (class cli_style_option): Add constructor.
1673         (metadata_style): Declare.
1674         * cli/cli-style.c (metadata_style): New global.
1675         (_initialize_cli_style): Register metadata style.
1676         * cli-out.h (class cli_ui_out) <do_field_fmt>: Add style
1677         parameter.
1678         * cli-out.c (cli_ui_out::do_field_fmt): Update.
1679         * c-typeprint.c (c_type_print_base_struct_union)
1680         (c_type_print_base_1): Use metadata style.
1681         * breakpoint.c (watchpoint_value_print)
1682         (print_one_breakpoint_location): Use metadata style.
1683         * break-catch-syscall.c (print_one_catch_syscall): Use metadata
1684         style.
1685         * break-catch-sig.c (signal_catchpoint_print_one): Use metadata
1686         style.
1687         * ada-valprint.c (val_print_packed_array_elements, printstr)
1688         (print_field_values, ada_val_print_ref, ada_val_print): Use
1689         metadata style.
1690         * ada-typeprint.c (print_array_type, ada_print_type): Use metadata
1691         style.
1692         * ada-tasks.c (print_ada_task_info, info_task): Use metadata
1693         style.
1694         * ada-lang.c (user_select_syms): Use metadata style.
1695
1696 2019-10-01  Tom Tromey  <tom@tromey.com>
1697
1698         * cli/cli-cmds.c (pwd_command): Style output.
1699
1700 2019-10-01  Pedro Alves  <palves@redhat.com>
1701             Tom Tromey  <tom@tromey.com>
1702
1703         * symtab.c (print_symbol_info): Use %ps.
1704         (print_msymbol_info): Use %ps.
1705         * symfile.c (symbol_file_add_with_addrs): Use %ps.
1706         * printcmd.c (print_variable_and_value): Use %ps.
1707         * macrocmd.c (show_pp_source_pos): Use %ps.
1708         * infrun.c (print_exited_reason): Use ui_out::message.
1709         * breakpoint.c (watchpoint_check, print_one_breakpoint_location)
1710         (describe_other_breakpoints): Use ui_out::message and new
1711         formats.
1712         (say_where): Use new formats.
1713         (bkpt_print_it, tracepoint_print_one_detail): Use ui_out::message
1714         and new formats.
1715
1716 2019-10-01  Pedro Alves  <palves@redhat.com>
1717             Tom Tromey  <tom@tromey.com>
1718
1719         * unittests/format_pieces-selftests.c: Add gdb_format parameter.
1720         (test_gdb_formats): New function.
1721         (run_tests): Call it.
1722         (test_format_specifier): Update.
1723         * utils.h (fputs_filtered): Update comment.
1724         (vfprintf_styled, vfprintf_styled_no_gdbfmt)
1725         (fputs_styled_unfiltered): Declare.
1726         * utils.c (fputs_styled_unfiltered): New function.
1727         (vfprintf_maybe_filtered): Add gdbfmt parameter.
1728         (vfprintf_filtered): Update.
1729         (vfprintf_unfiltered, vprintf_filtered): Update.
1730         (vfprintf_styled, vfprintf_styled_no_gdbfmt): New functions.
1731         * ui-out.h (enum ui_out_flag) <unfiltered_output,
1732         disallow_ui_out_field>: New constants.
1733         (enum class field_kind): New.
1734         (struct base_field_s, struct signed_field_s): New.
1735         (signed_field): New function.
1736         (struct string_field_s): New.
1737         (string_field): New function.
1738         (struct styled_string_s): New.
1739         (styled_string): New function.
1740         (class ui_out) <message>: Add comment.
1741         <vmessage, call_do_message>: New methods.
1742         <do_message>: Add style parameter.
1743         * ui-out.c (ui_out::call_do_message, ui_out::vmessage): New
1744         methods.
1745         (ui_out::message): Rewrite.
1746         * mi/mi-out.h (class mi_ui_out) <do_message>: Add style
1747         parameter.
1748         * mi/mi-out.c (mi_ui_out::do_message): Add style parameter.
1749         * gdbsupport/format.h (class format_pieces) <format_pieces>: Add
1750         gdb_extensions parameter.
1751         (class format_piece): Add parameter to constructor.
1752         (n_int_args): New field.
1753         * gdbsupport/format.c (format_pieces::format_pieces): Add
1754         gdb_extensions parameter.  Handle '*'.
1755         * cli-out.h (class cli_ui_out) <do_message>: Add style parameter.
1756         * cli-out.c (cli_ui_out::do_message): Add style parameter.  Call
1757         vfprintf_styled_no_gdbfmt.
1758         (cli_ui_out::do_field_string, cli_ui_out::do_spaces)
1759         (cli_ui_out::do_text, cli_ui_out::field_separator): Allow
1760         unfiltered output.
1761         * ui-style.h (struct ui_file_style) <ptr>: New method.
1762
1763 2019-10-01  Tom Tromey  <tom@tromey.com>
1764
1765         * unittests/format_pieces-selftests.c: Update.  Add final format.
1766         * gdbsupport/format.c (format_pieces::format_pieces): Don't add
1767         empty literal pieces.
1768
1769 2019-10-01  Tom Tromey  <tom@tromey.com>
1770
1771         * ui-out.h (enum class ui_out_style_kind): Remove.
1772         (class ui_out) <field_string, field_stsream, do_field_string>:
1773         Change type of "style".
1774         * ui-out.c (ui_out::field_core_addr, ui_out::field_stream)
1775         (ui_out::field_string): Update.
1776         * tui/tui-out.h (class tui_ui_out) <do_field_string>: Change type
1777         of "style".
1778         * tui/tui-out.c (tui_ui_out::do_field_string): Update.
1779         * tracepoint.c (print_one_static_tracepoint_marker): Update.
1780         * stack.c (print_frame_arg, print_frame_info, print_frame):
1781         Update.
1782         * source.c (print_source_lines_base): Update.
1783         * solib.c (info_sharedlibrary_command): Update.
1784         * skip.c (info_skip_command): Update.
1785         * record-btrace.c (btrace_call_history_src_line)
1786         (btrace_call_history): Update.
1787         * python/py-framefilter.c (py_print_frame): Update.
1788         * mi/mi-out.h (class mi_ui_out) <do_field_string>: Change type of
1789         "style".
1790         * mi/mi-out.c (mi_ui_out::do_table_header)
1791         (mi_ui_out::do_field_signed, mi_ui_out::do_field_unsigned)
1792         (mi_ui_out::do_field_string): Update.
1793         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
1794         Update.
1795         * cli-out.h (class cli_ui_out) <do_field_string>: Change type of
1796         "style".
1797         * cli-out.c (cli_ui_out::do_table_header)
1798         (cli_ui_out::do_field_signed, cli_ui_out::do_field_unsigned)
1799         (cli_ui_out::do_field_skip, cli_ui_out::do_field_string)
1800         (cli_ui_out::do_field_fmt): Update.
1801         * breakpoint.c (print_breakpoint_location): Update.
1802         (update_static_tracepoint): Update.
1803
1804 2019-10-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1805
1806         * main.c (relocate_gdbinit_path_maybe_in_datadir): Remove std::string
1807         conversion of gdb_datadir.
1808         (captured_main_1): Remove xstrdup when assigning to gdb_datadir,
1809         remove not needed c_str ().
1810
1811 2019-09-30  Ali Tamur <tamur@google.com>
1812
1813         * dwarf2read.c (skip_one_die): Handle DW_FORM_strx forms.
1814         (dwarf2_string_attr): Likewise.
1815
1816 2019-09-30  Ali Tamur <tamur@google.com>
1817
1818         * dwarf2read.c (process_full_comp_unit): Remove whitespace at the EOL.
1819         (process_full_type_unit): Likewise.
1820         (dump_die_shallow): Likewise.
1821         (cu_debug_loc_section): Likewise.
1822
1823 2019-09-28  Christian Biesinger  <cbiesinger@google.com>
1824
1825         * minsyms.c (compare_minimal_symbols): Rename to...
1826         (minimal_symbol_is_less_than): ...this, and adjust to STL
1827         conventions (return bool, take arguments as references)
1828         (minimal_symbol_reader::install): Call std::sort instead
1829         of qsort.
1830
1831 2019-09-29  Christian Biesinger  <cbiesinger@google.com>
1832
1833         * minsyms.h (msymbol_hash): Document that this is a case-insensitive
1834         hash and why.
1835         * objfiles.h (struct objfile_per_bfd_storage) <demangled_names_hash,
1836         msymbol_hash, msymbol_demangled_hash>: Improve comments.
1837
1838 2019-09-30  Simon Marchi  <simon.marchi@polymtl.ca>
1839
1840         * psymtab.c (add_psymbol_to_list): Move comment to psympriv.h.
1841         * psympriv.h (add_psymbol_to_list): Move comment here and update
1842         it.
1843
1844 2019-09-29  Tom de Vries  <tdevries@suse.de>
1845
1846         * contrib/cc-with-tweaks.sh (get_tmpdir): New function.
1847         Use $tmpdir/$(basename "$output_file").dwz instead of
1848         "${output_file}.dwz".
1849
1850 2019-09-28  Simon Marchi  <simon.marchi@polymtl.ca>
1851
1852         PR gdb/25045
1853         * hppa-linux-nat.c: Include gdbarch.h.
1854
1855 2019-09-26  Christian Biesinger  <cbiesinger@google.com>
1856
1857         * blockframe.c (find_pc_partial_function): Change return type to bool.
1858         * elfread.c (elf_gnu_ifunc_resolve_name): Likewise.
1859         * minsyms.c (in_gnu_ifunc_stub): Likewise.
1860         (stub_gnu_ifunc_resolve_name): Likewise.
1861         * symtab.c (compare_filenames_for_search): Likewise.
1862         (compare_glob_filenames_for_search): Likewise.
1863         (matching_obj_sections): Likewise.
1864         (symbol_matches_domain): Likewise.
1865         (find_line_symtab): Change out param EXACT_MATCH to bool *.
1866         (find_line_pc): Change return type to bool.
1867         (find_line_pc_range): Likewise.
1868         (producer_is_realview): Likewise.
1869         * symtab.h (symbol_matches_domain): Likewise.
1870         (find_pc_partial_function): Likewise.
1871         (find_pc_line_pc_range): Likewise.
1872         (in_gnu_ifunc_stub): Likewise.
1873         (struct gnu_ifunc_fns) <gnu_ifunc_resolve_name>: Likewise.
1874         (find_line_pc): Likewise.
1875         (find_line_pc_range): Likewise.
1876         (matching_obj_sections): Likewise.
1877         (find_line_symtab): Change out parameter to bool.
1878         (producer_is_realview): Change return type to bool.
1879         (compare_filenames_for_search): Likewise.
1880         (compare_glob_filenames_for_search): Likewise.
1881
1882 2019-09-26  Tom Tromey  <tom@tromey.com>
1883
1884         * Makefile.in (COMMON_SFILES): Remove gdb_usleep.c.
1885         (HFILES_NO_SRCDIR): Remove gdb_usleep.h.
1886         * gdb_usleep.h: Remove.
1887         * gdb_usleep.c: Remove.
1888         * utils.c: Don't include gdb_usleep.h.
1889
1890 2019-09-26  Tom Tromey  <tromey@adacore.com>
1891
1892         * python/py-type.c (type_to_type_object): Call check_typedef
1893         for stub types.
1894
1895 2019-09-26  Tom Tromey  <tom@tromey.com>
1896
1897         * utils.h (initialize_utils): Don't declare.
1898         * top.c (gdb_init): Don't call initialize_utils.
1899         * utils.c (initialize_utils): Remove.  Move contents...
1900         (_initialize_utils): ... here.
1901
1902 2019-09-25  Tom Tromey  <tom@tromey.com>
1903
1904         * python/py-objfile.c (objfpy_get_build_id): Use bin2hex.
1905         * utils.h (make_hex_string): Don't declare.
1906         * utils.c (make_hex_string): Remove.
1907
1908 2019-09-24  Tom de Vries  <tdevries@suse.de>
1909
1910         PR gdb/23815
1911         * amd64-linux-nat.c (amd64_linux_nat_target::fetch_registers):
1912         Initialize xstateregs before ptrace PTRACE_GETREGSET call.
1913
1914 2019-09-23  Dimitar Dimitrov  <dimitar@dinux.eu>
1915
1916         * NEWS: Mention new simulator port for PRU.
1917
1918 2019-09-23  Christian Biesinger  <cbiesinger@google.com>
1919
1920         * ada-exp.y (write_object_remaining): Update.
1921         * ada-lang.c (ada_decode): Return a std::string instead of a char*
1922         and eliminate the static buffer.
1923         (ada_decode_symbol): Update.
1924         (ada_la_decode): Update.
1925         (ada_sniff_from_mangled_name): Update.
1926         (is_valid_name_for_wild_match): Update.
1927         (ada_lookup_name_info::matches): Update and simplify.
1928         (name_matches_regex): Update.
1929         (ada_add_global_exceptions): Update.
1930         * ada-lang.h (ada_decode): Update signature.
1931         * ada-varobj.c (ada_varobj_describe_simple_array_child): Update.
1932         * dwarf-index-write.c (debug_names::insert): Update.
1933
1934 2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>
1935
1936         * solib-svr4.c (svr4_iterate_over_objfiles_in_search_order): Fix
1937         formatting.
1938
1939 2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>
1940
1941         * breakpoint.h (bp_location) <inserted, permanent, duplicate>:
1942         Change "nonzero" to "true" in documentation.
1943
1944 2019-09-20  Christian Biesinger  <cbiesinger@google.com>
1945
1946         * solib-darwin.c (darwin_lookup_lib_symbol): Remove.
1947         (_initialize_darwin_solib): Don't set
1948         darwin_so_ops.lookup_lib_global_symbol.
1949         * solib-svr4.c (set_solib_svr4_fetch_link_map_offsets): Call
1950         set_gdbarch_iterate_over_objfiles_in_search_order.
1951         (elf_lookup_lib_symbol): Rename to...
1952         (svr4_iterate_over_objfiles_in_search_order): this, and update
1953         to iterate semantics.
1954         (_initialize_svr4_solib): Don't set lookup_lib_global_symbol.
1955         * solib.c (solib_global_lookup): Remove.
1956         * solist.h (struct target_so_ops): Remove lookup_lib_global_symbol.
1957         (solib_global_lookup): Remove.
1958         * symtab.c (lookup_global_or_static_symbol): Remove call to
1959         solib_global_lookup.
1960
1961 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
1962
1963         * NEWS: Move entries about default MI version now being
1964         version 3, and about the GDB/MI fix for multi-location
1965         breakpoints to the "since GDB 8.3" section.
1966
1967 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
1968
1969         GDB 8.3.1 released.
1970
1971 2019-09-20  Ulrich Weigand  <uweigand@de.ibm.com>
1972
1973         * NEWS: Mention that Cell/B.E. debugging support was removed.
1974         * MAINTAINERS: Remove spu target.
1975
1976         * config/djgpp/fnchange.lst: Remove entries for removed files.
1977
1978         * Makefile.in (ALL_TARGET_OBS): Remove solib-spu.o,
1979         spu-multiarch.o, and spu-tdep.o.
1980         (HFILES_NO_SRCDIR): Remove solib-spu.h and spu-tdep.h.
1981         (ALLDEPFILES): Remove solib-spu.c, spu-linux-nat.c,
1982         spu-multiarch.c, and spu-tdep.c.
1983         * spu-linux-nat.c: Remove file.
1984         * spu-multiarch.c: Remove file.
1985         * spu-tdep.c: Remove file.
1986         * spu-tdep.h: Remove file.
1987         * solib-spu.c: Remove file.
1988         * solib-spu.h: Remove file.
1989
1990         * configure.host (powerpc64*-*-linux*): Remove Cell/B.E. support.
1991         * configure.nat (spu-linux): Remove.
1992         * configure.tgt (powerpc*-*-linux*): Remove solib-spu.o and
1993         solib-multiarch.o from gdb_target_obs.
1994         (spu*-*-*): Remove.
1995
1996         * arch/ppc-linux-common.h (struct ppc_linux_features): Remove "cell"
1997         feature flag.
1998         (ppc_linux_no_features): Update.
1999         * arch/ppc-linux-common.c (ppc_linux_match_description): Remove
2000         Cell/B.E. support.
2001         * arch/ppc-linux-tdesc.h (tdesc_powerpc_cell32l): Remove declaration.
2002         (tdesc_powerpc_cell64l): Likewise.
2003         * nat/ppc-linux.h (PPC_FEATURE_CELL): Remove.
2004         * ppc-linux-nat.c (ppc_linux_nat_target::read_description): Remove
2005         Cell/B.E. support.
2006         * ppc-linux-tdep.h: Do not include "solib-spu.h" or "spu-tdep.h".
2007         Do not include "features/rs6000/powerpc-cell32l.c" or
2008         "features/rs6000/powerpc-cell64l.c".
2009         (ppc_linux_spu_section): Remove.
2010         (ppc_linux_core_read_description): Remove Cell/B.E. support.
2011         (spe_context_objfile, spe_context_lm_addr, spe_context_offset,
2012         spe_context_cache_ptid, spe_context_cache_ptid): Remove.
2013         (ppc_linux_spe_context_lookup): Remove.
2014         (ppc_linux_spe_context_inferior_created): Remove.
2015         (ppc_linux_spe_context_solib_loaded): Remove.
2016         (ppc_linux_spe_context_solib_unloaded): Remove.
2017         (ppc_linux_spe_context): Remove.
2018         (struct ppu2spu_cache): Remove.
2019         (ppu2spu_prev_arch, ppu2spu_this_id, ppu2spu_prev_register): Remove.
2020         (struct ppu2spu_data): Remove.
2021         (ppu2spu_unwind_register, ppu2spu_sniffer, ppu2spu_dealloc_cache,
2022         ppu2spu_unwind): Remove.
2023         (ppc_linux_init_abi): Remove Cell/B.E. support.
2024         * rs6000-tdep.h (rs6000_gdbarch_init): Remove Cell/B.E. support.
2025
2026         * features/Makefile (rs6000/powerpc-cell32l-expedite): Remove.
2027         (rs6000/powerpc-cell64l-expedite): Likewise
2028         (WHICH): Remove rs6000/powerpc-cell32l and rs6000/powerpc-cell64l.
2029         (XMLTOC): Remove rs6000/powerpc-cell32l.xml and
2030         rs6000/powerpc-cell64l.xml.
2031         * features/rs6000/powerpc-cell32l.xml: Remove.
2032         * features/rs6000/powerpc-cell64l.xml: Likewise.
2033         * features/rs6000/powerpc-cell32l.c: Remove generated file.
2034         * features/rs6000/powerpc-cell64l.c: Likewise.
2035         * regformats/rs6000/powerpc-cell32l.dat: Remove generated file.
2036         * regformats/rs6000/powerpc-cell64l.dat: Likewise.
2037         * regformats/reg-spu.dat: Remove.
2038
2039         * target.h (enum target_object): Remove TARGET_OBJECT_SPU.
2040         * corelow.c (struct spuid_list): Remove.
2041         (add_to_spuid_list): Remove.
2042         (core_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
2043         * remote.c (PACKET_qXfer_spu_read, PACKET_qXfer_spu_write): Remove.
2044         (remote_protocol_features): Remove associated entries.
2045         (_initialize_remote): No longer initialize them.
2046         (remote_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
2047         * linux-nat.c (SPUFS_MAGIC): Remove.
2048         (linux_proc_xfer_spu): Remove.
2049         (spu_enumerate_spu_ids): Remove.
2050         (linux_nat_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
2051         * linux-tdep.c (-linux_spu_make_corefile_notes): Remove.
2052         (linux_make_corefile_notes): No longer call it.
2053
2054         * regcache.c (cooked_read_test): Remove bfd_arch_spu special case.
2055         (cooked_write_test): Likewise.
2056
2057 2019-09-20  Tom Tromey  <tom@tromey.com>
2058
2059         * NEWS: Mention case-sensitivity of TUI commands.
2060         * tui/tui-win.c (tui_set_focus_command): Now case-sensitive.
2061         (tui_set_win_height_command, parse_scrolling_args): Likewise.
2062         * tui/tui-layout.c (tui_layout_command): Now case-sensitive.
2063
2064 2019-09-20  Tom Tromey  <tom@tromey.com>
2065
2066         * tui/tui-source.c (tui_source_window::set_contents): Use
2067         make_unique_xstrdup.
2068         * tui/tui-disasm.c (tui_disasm_window::set_contents): Use
2069         make_unique_xstrdup.
2070
2071 2019-09-20  Tom Tromey  <tom@tromey.com>
2072
2073         * tui/tui-data.c: Remove separator comments.
2074         * tui/tui-layout.c: Remove separator comments.
2075         * tui/tui-win.c: Remove separator comments.
2076         * tui/tui-wingeneral.c: Remove separator comments.
2077
2078 2019-09-20  Tom Tromey  <tom@tromey.com>
2079
2080         * tui/tui.h (strcat_to_buf): Don't declare.
2081         * tui/tui.c (strcat_to_buf): Remove.
2082
2083 2019-09-20  Tom Tromey  <tom@tromey.com>
2084
2085         * tui/tui-source.h (struct tui_source_window) <m_fullname>: Rename
2086         from "fullname".
2087         * tui/tui-source.c (tui_source_window::set_contents)
2088         (tui_source_window::location_matches_p)
2089         (tui_source_window::maybe_update): Update.
2090
2091 2019-09-20  Tom Tromey  <tom@tromey.com>
2092
2093         * tui/tui-regs.h (struct tui_data_window) <get_current_group>:
2094         Update.
2095         <m_regs_content, m_regs_column_count, m_current_group>: Add "m_"
2096         prefix.
2097         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
2098         (tui_data_window::line_from_reg_element_no)
2099         (tui_data_window::first_reg_element_no_inline)
2100         (tui_data_window::show_registers)
2101         (tui_data_window::show_register_group)
2102         (tui_data_window::display_registers_from)
2103         (tui_data_window::display_registers_from_line)
2104         (tui_data_window::first_data_item_displayed)
2105         (tui_data_window::delete_data_content_windows)
2106         (tui_data_window::erase_data_content)
2107         (tui_data_window::do_scroll_vertical)
2108         (tui_data_window::refresh_window)
2109         (tui_data_window::check_register_values): Update.
2110
2111 2019-09-20  Tom Tromey  <tom@tromey.com>
2112
2113         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN): Remove define.
2114         (struct tui_locator_window) <full_name, proc_name>: Now
2115         std::string.
2116         * tui/tui-stack.c (tui_locator_window::make_status_line)
2117         (tui_locator_window::set_locator_fullname)
2118         (tui_locator_window::set_locator_info): Update.
2119         * tui/tui-source.c (tui_source_window::set_contents)
2120         (tui_source_window::showing_source_p): Update.
2121
2122 2019-09-20  Tom Tromey  <tom@tromey.com>
2123
2124         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
2125         Don't call tui_locator_win_info_ptr.
2126
2127 2019-09-20  Tom Tromey  <tom@tromey.com>
2128
2129         * tui/tui-win.c (tui_resize_all): Don't call refresh.
2130
2131 2019-09-20  Tom Tromey  <tom@tromey.com>
2132
2133         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use 1 as
2134         height for locator.
2135         * tui/tui-stack.c (tui_locator_window::rerender): Call scrollok.
2136         * tui/tui-layout.c (show_source_disasm_command, show_data)
2137         (show_source_or_disasm_and_command): Use 1 as height for locator.
2138
2139 2019-09-20  Tom Tromey  <tom@tromey.com>
2140
2141         * tui/tui.c (tui_enable): Update.
2142         * tui/tui-win.c (tui_sigwinch_handler, tui_async_resize_screen):
2143         Update.
2144         * tui/tui-data.h (tui_win_resized, tui_set_win_resized_to):
2145         Update.
2146         * tui/tui-data.c (win_resized): Now bool.
2147         (tui_win_resized): Return bool.
2148         (tui_set_win_resized_to): Accept a bool.
2149
2150 2019-09-20  Tom Tromey  <tom@tromey.com>
2151
2152         * tui/tui-regs.h (struct tui_data_window) <show_register_group>:
2153         Change type of "refresh_values_only".
2154         * tui/tui-regs.c (tui_data_window::show_register_group): Change
2155         type of "refresh_values_only".
2156
2157 2019-09-20  Tom Tromey  <tom@tromey.com>
2158
2159         * tui/tui-disasm.c (struct tui_asm_line) <addr_string, insn>: Now
2160         std::string.
2161         (tui_disassemble): Add "pos" parameter.
2162         (tui_disasm_window::set_contents): Simplify.
2163
2164 2019-09-20  Tom Tromey  <tom@tromey.com>
2165
2166         * tui/tui-winsource.h (struct tui_source_window_base)
2167         <show_source_content>: Now private.
2168         * tui/tui-winsource.c
2169         (tui_source_window_base::show_source_content): Don't handle empty
2170         content case.
2171
2172 2019-09-20  Tom Tromey  <tom@tromey.com>
2173
2174         * tui/tui-layout.c (show_source_disasm_command)
2175         (show_source_or_disasm_and_command): Don't call
2176         show_source_content.
2177
2178 2019-09-20  Tom Tromey  <tom@tromey.com>
2179
2180         * tui/tui-stack.h (struct tui_locator_window) <make_status_line>:
2181         Declare.
2182         * tui/tui-stack.c (tui_locator_window::make_status_line): Rename
2183         from tui_make_status_line.
2184         (tui_locator_window::rerender): Update.
2185
2186 2019-09-20  Tom Tromey  <tom@tromey.com>
2187
2188         * tui/tui-stack.c (tui_make_status_line): Return std::string.
2189         (tui_locator_window::rerender): Update.
2190
2191 2019-09-20  Tom Tromey  <tom@tromey.com>
2192
2193         * tui/tui-winsource.h (struct tui_source_window_base)
2194         <~tui_source_window_base>: Don't declare.
2195         <fullname>: Remove.
2196         * tui/tui-winsource.c (~tui_source_window_base): Remove.
2197         * tui/tui-source.h (struct tui_source_window) <fullname>: New
2198         member.
2199         * tui/tui-source.c (tui_source_window::set_contents): Update.
2200         (tui_source_window::location_matches_p)
2201         (tui_source_window::maybe_update): Update.
2202
2203 2019-09-20  Tom Tromey  <tom@tromey.com>
2204
2205         * tui/tui-winsource.h (~tui_source_element): Remove.
2206         (tui_source_element): Update.
2207         (struct tui_source_element) <line>: Now a unique_xmalloc_ptr.
2208         * tui/tui-winsource.c (tui_show_source_line): Update.
2209         * tui/tui-source.c (tui_source_window::set_contents): Update.
2210         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
2211
2212 2019-09-20  Tom Tromey  <tom@tromey.com>
2213
2214         * tui/tui-data.h (tui_clear_source_windows_detail): Don't
2215         declare.
2216         * tui/tui-layout.c (tui_add_win_to_layout): Don't call
2217         tui_clear_source_windows_detail.
2218         * tui/tui-winsource.h (struct tui_source_window_base)
2219         <clear_detail>: Don't declare.
2220         * tui/tui-winsource.c (tui_source_window_base::clear_detail):
2221         Remove.
2222         * tui/tui-data.c (tui_clear_source_windows_detail): Remove.
2223
2224 2019-09-20  Tom Tromey  <tromey@adacore.com>
2225
2226         PR ada/24919:
2227         * block.c (contained_in): Fix final return value.
2228
2229 2019-09-20  Alan Modra  <amodra@gmail.com>
2230
2231         * gdb_bfd.c (gdb_bfd_ref, gdb_bfd_unref): Use bfd_set_usrdata.
2232         * dwarf2read.c (dwarf2_read_gdb_index, dwarf2_read_debug_names),
2233         (read_indirect_string_from_dwz): Use bfd accessor.
2234         * dwarf2read.h (struct dwz_file <filename>): Likewise.
2235         * machoread.c (macho_symfile_read_all_oso): Likewise.
2236         * solib.c (solib_bfd_open): Likewise.
2237
2238 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
2239
2240         * eval.c: Move declaration of overload_resolution to...
2241         * value.h: ...here.
2242
2243 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
2244
2245         * arm-linux-nat.c: Remove extern declaration for arm_apcs_32.
2246         * arm-linux-tdep.c: Likewise.
2247         * arm-nbsd-nat.c: Likewise.
2248         * arm-tdep.h: Declare arm_apcs_32.
2249         * arm-tdep.c: Move documentation for arm_apcs_32 to arm-tdep.h.
2250
2251 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
2252
2253         * dwarf2loc.c: Remove extern declaration of dwarf_always_disassemble.
2254         * dwarf2read.h: Declare dwarf_always_disassemble.
2255
2256 2019-09-19  Tom de Vries  <tdevries@suse.de>
2257
2258         PR gdb/25009
2259         * source-cache.c (source_cache::ensure): Catch exception thrown during
2260         construction of the highlighter.
2261
2262 2019-09-18  Alan Modra  <amodra@gmail.com>
2263
2264         * aarch64-linux-tdep.c, * arm-tdep.c, * auto-load.c,
2265         * coff-pe-read.c, * coffread.c, * corelow.c, * dbxread.c,
2266         * dicos-tdep.c, * dwarf2-frame.c, * dwarf2read.c, * elfread.c,
2267         * exec.c, * fbsd-tdep.c, * gcore.c, * gdb_bfd.c, * gdb_bfd.h,
2268         * hppa-tdep.c, * i386-cygwin-tdep.c, * i386-fbsd-tdep.c,
2269         * i386-linux-tdep.c, * jit.c, * linux-tdep.c, * machoread.c,
2270         * maint.c, * mdebugread.c, * minidebug.c, * mips-linux-tdep.c,
2271         * mips-sde-tdep.c, * mips-tdep.c, * mipsread.c, * nto-tdep.c,
2272         * objfiles.c, * objfiles.h, * osabi.c, * ppc-linux-tdep.c,
2273         * ppc64-tdep.c, * record-btrace.c, * record-full.c, * remote.c,
2274         * rs6000-aix-tdep.c, * rs6000-tdep.c, * s390-linux-tdep.c,
2275         * s390-tdep.c, * solib-aix.c, * solib-dsbt.c, * solib-frv.c,
2276         * solib-spu.c, * solib-svr4.c, * solib-target.c,
2277         * spu-linux-nat.c, * spu-tdep.c, * symfile-mem.c, * symfile.c,
2278         * symmisc.c, * symtab.c, * target.c, * windows-nat.c,
2279         * xcoffread.c, * cli/cli-dump.c, * compile/compile-object-load.c,
2280         * mi/mi-interp.c: Update throughout for bfd section macro and
2281         function changes.
2282         * gcore (gcore_create_callback): Use bfd_set_section_lma.
2283         * spu-tdep.c (spu_overlay_new_objfile): Likewise.
2284
2285 2019-09-18  Tom Tromey  <tom@tromey.com>
2286
2287         * NEWS: Add entry.
2288         * tui/tui.c (tui_initialize_readline): Set name of keymap.  Do not
2289         call rl_initialize.
2290         (tui_enable): Do not call rl_initialize.
2291
2292 2019-09-18  Christian Groessler  <chris@groessler.org>
2293
2294         * alpha-linux-nat.c: Include gdbarch.h.
2295
2296 2019-09-18  Simon Marchi  <simon.marchi@polymtl.ca>
2297
2298         * ui-file.c: Include cli/cli-style.h.
2299         (term_cli_styling): Remove cli_styling declaration.
2300
2301 2019-09-18  Alan Modra  <amodra@gmail.com>
2302
2303         * arm-tdep.c (arm_record_special_symbol): Update bfd_get_section
2304         to bfd_asymbol_section.
2305
2306 2019-09-18  Alan Modra  <amodra@gmail.com>
2307
2308         * amd64-dicos-tdep.c (amd64_dicos_osabi_sniffer): Constify target.
2309         * i386-cygwin-tdep.c (i386_cygwin_init_abi): Likewise.
2310         * i386-dicos-tdep.c (i386_dicos_osabi_sniffer): Likewise.
2311
2312 2019-09-18  Alan Modra  <amodra@gmail.com>
2313
2314         * solib-spu.c (spu_bfd_open): Use bfd_set_filename.
2315         * spu-linux-nat.c (spu_bfd_open): Likewise.
2316
2317 2019-09-18  Christian Biesinger  <cbiesinger@google.com>
2318
2319         * dwarf2loc.c: Change extern declaration of dwarf_always_disassemble
2320         to bool to match definition in dwarf2read.c.
2321
2322 2019-09-17  Christian Biesinger  <cbiesinger@google.com>
2323
2324         * ada-lang.c (ada_ignore_descriptive_types_p): Change to bool.
2325         (print_signatures): Likewise.
2326         (trust_pad_over_xvs): Likewise.
2327         * arch/aarch64-insn.c (aarch64_debug): Likewise.
2328         * arch/aarch64-insn.h (aarch64_debug): Likewise.
2329         * arm-linux-nat.c (arm_apcs_32): Likewise.
2330         * arm-linux-tdep.c (arm_apcs_32): Likewise.
2331         * arm-nbsd-nat.c (arm_apcs_32): Likewise.
2332         * arm-tdep.c (arm_debug): Likewise.
2333         (arm_apcs_32): Likewise.
2334         * auto-load.c (debug_auto_load): Likewise.
2335         (auto_load_gdb_scripts): Likewise.
2336         (global_auto_load): Likewise.
2337         (auto_load_local_gdbinit): Likewise.
2338         (auto_load_local_gdbinit_loaded): Likewise.
2339         * auto-load.h (global_auto_load): Likewise.
2340         (auto_load_local_gdbinit): Likewise.
2341         (auto_load_local_gdbinit_loaded): Likewise.
2342         * breakpoint.c (disconnected_dprintf): Likewise.
2343         (breakpoint_proceeded): Likewise.
2344         (automatic_hardware_breakpoints): Likewise.
2345         (always_inserted_mode): Likewise.
2346         (target_exact_watchpoints): Likewise.
2347         (_initialize_breakpoint): Update.
2348         * breakpoint.h (target_exact_watchpoints): Change to bool.
2349         * btrace.c (maint_btrace_pt_skip_pad): Likewise.
2350         * cli/cli-cmds.c (trace_commands): Likewise.
2351         * cli/cli-cmds.h (trace_commands): Likewise.
2352         * cli/cli-decode.c (add_setshow_boolean_cmd): Change int* argument
2353         to bool*.
2354         * cli/cli-logging.c (logging_overwrite): Change to bool.
2355         (logging_redirect): Likewise.
2356         (debug_redirect): Likewise.
2357         * cli/cli-option.h (option_def) <boolean>: Change return type to bool*.
2358         (struct boolean_option_def) <get_var_address_cb_>: Change return type
2359         to bool.
2360         <boolean_option_def>: Update.
2361         (struct flag_option_def): Change default type of Context to bool
2362         from int.
2363         <flag_option_def>: Change return type of var_address_cb_ to bool*.
2364         * cli/cli-setshow.c (do_set_command): Cast to bool* instead of int*.
2365         (get_setshow_command_value_string): Likewise.
2366         * cli/cli-style.c (cli_styling): Change to bool.
2367         (source_styling): Likewise.
2368         * cli/cli-style.h (source_styling): Likewise.
2369         (cli_styling): Likewise.
2370         * cli/cli-utils.h (struct qcs_flags) <quiet, cont, silent>: Change
2371         to bool.
2372         * command.h (var_types): Update comment.
2373         (add_setshow_boolean_cmd): Change int* var argument to bool*.
2374         * compile/compile-cplus-types.c (debug_compile_cplus_types): Change to
2375         bool.
2376         (debug_compile_cplus_scopes): Likewise.
2377         * compile/compile-internal.h (compile_debug): Likewise.
2378         * compile/compile.c (compile_debug): Likewise.
2379         (struct compile_options) <raw>: Likewise.
2380         * cp-support.c (catch_demangler_crashes): Likewise.
2381         * cris-tdep.c (usr_cmd_cris_version_valid): Likewise.
2382         (usr_cmd_cris_dwarf2_cfi): Likewise.
2383         * csky-tdep.c (csky_debug): Likewise.
2384         * darwin-nat.c (enable_mach_exceptions): Likewise.
2385         * dcache.c (dcache_enabled_p): Likewise.
2386         * defs.h (info_verbose): Likewise.
2387         * demangle.c (demangle): Likewise.
2388         (asm_demangle): Likewise.
2389         * dwarf-index-cache.c (debug_index_cache): Likewise.
2390         * dwarf2-frame.c (dwarf2_frame_unwinders_enabled_p): Likewise.
2391         * dwarf2-frame.h (dwarf2_frame_unwinders_enabled_p): Likewise.
2392         * dwarf2read.c (check_physname): Likewise.
2393         (use_deprecated_index_sections): Likewise.
2394         (dwarf_always_disassemble): Likewise.
2395         * eval.c (overload_resolution): Likewise.
2396         * event-top.c (set_editing_cmd_var): Likewise.
2397         (exec_done_display_p): Likewise.
2398         * event-top.h (set_editing_cmd_var): Likewise.
2399         (exec_done_display_p): Likewise.
2400         * exec.c (write_files): Likewise.
2401         * fbsd-nat.c (debug_fbsd_lwp): Likewise
2402         (debug_fbsd_nat): Likewise.
2403         * frame.h (struct frame_print_options) <print_raw_frame_arguments>:
2404         Likewise.
2405         (struct set_backtrace_options) <backtrace_past_main>: Likewise.
2406         <backtrace_past_entry> Likewise.
2407         * gdb-demangle.h (demangle): Likewise.
2408         (asm_demangle): Likewise.
2409         * gdb_bfd.c (bfd_sharing): Likewise.
2410         * gdbcore.h (write_files): Likewise.
2411         * gdbsupport/common-debug.c (show_debug_regs): Likewise.
2412         * gdbsupport/common-debug.h (show_debug_regs): Likewise.
2413         * gdbthread.h (print_thread_events): Likewise.
2414         * gdbtypes.c (opaque_type_resolution): Likewise.
2415         (strict_type_checking): Likewise.
2416         * gnu-nat.c (gnu_debug_flag): Likewise.
2417         * guile/scm-auto-load.c (auto_load_guile_scripts): Likewise.
2418         * guile/scm-param.c (pascm_variable): Add boolval.
2419         (add_setshow_generic): Update.
2420         (pascm_param_value): Update.
2421         (pascm_set_param_value_x): Update.
2422         * hppa-tdep.c (hppa_debug): Change to bool..
2423         * infcall.c (may_call_functions_p): Likewise.
2424         (coerce_float_to_double_p): Likewise.
2425         (unwind_on_signal_p): Likewise.
2426         (unwind_on_terminating_exception_p): Likewise.
2427         * infcmd.c (startup_with_shell): Likewise.
2428         * inferior.c (print_inferior_events): Likewise.
2429         * inferior.h (startup_with_shell): Likewise.
2430         (print_inferior_events): Likewise.
2431         * infrun.c (step_stop_if_no_debug): Likewise.
2432         (detach_fork): Likewise.
2433         (debug_displaced): Likewise.
2434         (disable_randomization): Likewise.
2435         (non_stop): Likewise.
2436         (non_stop_1): Likewise.
2437         (observer_mode): Likewise.
2438         (observer_mode_1): Likewise.
2439         (set_observer_mode): Update.
2440         (sched_multi): Change to bool.
2441         * infrun.h (debug_displaced): Likewise.
2442         (sched_multi): Likewise.
2443         (step_stop_if_no_debug): Likewise.
2444         (non_stop): Likewise.
2445         (disable_randomization): Likewise.
2446         * linux-tdep.c (use_coredump_filter): Likewise.
2447         (dump_excluded_mappings): Likewise.
2448         * linux-thread-db.c (auto_load_thread_db): Likewise.
2449         (check_thread_db_on_load): Likewise.
2450         * main.c (captured_main_1): Update.
2451         * maint-test-options.c (struct test_options_opts) <flag_opt, xx1_opt,
2452         xx2_opt, boolean_opt>: Change to bool.
2453         * maint-test-settings.c (maintenance_test_settings_boolean): Likewise.
2454         * maint.c (maintenance_profile_p): Likewise.
2455         (per_command_time): Likewise.
2456         (per_command_space): Likewise.
2457         (per_command_symtab): Likewise.
2458         * memattr.c (inaccessible_by_default): Likewise.
2459         * mi/mi-main.c (mi_async): Likewise.
2460         (mi_async_1): Likewise.
2461         * mips-tdep.c (mips64_transfers_32bit_regs_p): Likewise.
2462         * nat/fork-inferior.h (startup_with_shell): Likewise.
2463         * nat/linux-namespaces.c (debug_linux_namespaces): Likewise.
2464         * nat/linux-namespaces.h (debug_linux_namespaces): Likewise.
2465         * nios2-tdep.c (nios2_debug): Likewise.
2466         * or1k-tdep.c (or1k_debug): Likewise.
2467         * parse.c (parser_debug): Likewise.
2468         * parser-defs.h (parser_debug): Likewise.
2469         * printcmd.c (print_symbol_filename): Likewise.
2470         * proc-api.c (procfs_trace): Likewise.
2471         * python/py-auto-load.c (auto_load_python_scripts): Likewise.
2472         * python/py-param.c (union parmpy_variable): Add "bool boolval" field.
2473         (set_parameter_value): Update.
2474         (add_setshow_generic): Update.
2475         * python/py-value.c (copy_py_bool_obj): Change argument from int*
2476         to bool*.
2477         * python/python.c (gdbpy_parameter_value): Cast to bool* instead of
2478         int*.
2479         * ravenscar-thread.c (ravenscar_task_support): Change to bool.
2480         * record-btrace.c (record_btrace_target::store_registers): Update.
2481         * record-full.c (record_full_memory_query): Change to bool.
2482         (record_full_stop_at_limit): Likewise.
2483         * record-full.h (record_full_memory_query): Likewise.
2484         * remote-notif.c (notif_debug): Likewise.
2485         * remote-notif.h (notif_debug): Likewise.
2486         * remote.c (use_range_stepping): Likewise.
2487         (interrupt_on_connect): Likewise.
2488         (remote_break): Likewise.
2489         * ser-tcp.c (tcp_auto_retry): Likewise.
2490         * ser-unix.c (serial_hwflow): Likewise.
2491         * skip.c (debug_skip): Likewise.
2492         * solib-aix.c (solib_aix_debug): Likewise.
2493         * spu-tdep.c (spu_stop_on_load_p): Likewise.
2494         (spu_auto_flush_cache_p): Likewise.
2495         * stack.c (struct backtrace_cmd_options) <full, no_filters, hide>:
2496         Likewise.
2497         (struct info_print_options) <quiet>: Likewise.
2498         * symfile-debug.c (debug_symfile): Likewise.
2499         * symfile.c (auto_solib_add): Likewise.
2500         (separate_debug_file_debug): Likewise.
2501         * symfile.h (auto_solib_add): Likewise.
2502         (separate_debug_file_debug): Likewise.
2503         * symtab.c (basenames_may_differ): Likewise.
2504         (struct filename_partial_match_opts) <dirname, basename>: Likewise.
2505         (struct info_print_options) <quiet, exclude_minsyms>: Likewise.
2506         (struct info_types_options) <quiet>: Likewise.
2507         * symtab.h (demangle): Likewise.
2508         (basenames_may_differ): Likewise.
2509         * target-dcache.c (stack_cache_enabled_1): Likewise.
2510         (code_cache_enabled_1): Likewise.
2511         * target.c (trust_readonly): Likewise.
2512         (may_write_registers): Likewise.
2513         (may_write_memory): Likewise.
2514         (may_insert_breakpoints): Likewise.
2515         (may_insert_tracepoints): Likewise.
2516         (may_insert_fast_tracepoints): Likewise.
2517         (may_stop): Likewise.
2518         (auto_connect_native_target): Likewise.
2519         (target_stop_and_wait): Update.
2520         (target_async_permitted): Change to bool.
2521         (target_async_permitted_1): Likewise.
2522         (may_write_registers_1): Likewise.
2523         (may_write_memory_1): Likewise.
2524         (may_insert_breakpoints_1): Likewise.
2525         (may_insert_tracepoints_1): Likewise.
2526         (may_insert_fast_tracepoints_1): Likewise.
2527         (may_stop_1): Likewise.
2528         * target.h (target_async_permitted): Likewise.
2529         (may_write_registers): Likewise.
2530         (may_write_memory): Likewise.
2531         (may_insert_breakpoints): Likewise.
2532         (may_insert_tracepoints): Likewise.
2533         (may_insert_fast_tracepoints): Likewise.
2534         (may_stop): Likewise.
2535         * thread.c (struct info_threads_opts) <show_global_ids>: Likewise.
2536         (make_thread_apply_all_options_def_group): Change argument from int*
2537         to bool*.
2538         (thread_apply_all_command): Update.
2539         (print_thread_events): Change to bool.
2540         * top.c (confirm): Likewise.
2541         (command_editing_p): Likewise.
2542         (history_expansion_p): Likewise.
2543         (write_history_p): Likewise.
2544         (info_verbose): Likewise.
2545         * top.h (confirm): Likewise.
2546         (history_expansion_p): Likewise.
2547         * tracepoint.c (disconnected_tracing): Likewise.
2548         (circular_trace_buffer): Likewise.
2549         * typeprint.c (print_methods): Likewise.
2550         (print_typedefs): Likewise.
2551         * utils.c (debug_timestamp): Likewise.
2552         (sevenbit_strings): Likewise.
2553         (pagination_enabled): Likewise.
2554         * utils.h (sevenbit_strings): Likewise.
2555         (pagination_enabled): Likewise.
2556         * valops.c (overload_resolution): Likewise.
2557         * valprint.h (struct value_print_options) <prettyformat_arrays,
2558         prettyformat_structs, vtblprint, unionprint, addressprint, objectprint,
2559         stop_print_at_null, print_array_indexes, deref_ref, static_field_print,
2560         pascal_static_field_print, raw, summary, symbol_print, finish_print>:
2561         Likewise.
2562         * windows-nat.c (new_console): Likewise.
2563         (cygwin_exceptions): Likewise.
2564         (new_group): Likewise.
2565         (debug_exec): Likewise.
2566         (debug_events): Likewise.
2567         (debug_memory): Likewise.
2568         (debug_exceptions): Likewise.
2569         (useshell): Likewise.
2570         * windows-tdep.c (maint_display_all_tib): Likewise.
2571         * xml-support.c (debug_xml): Likewise.
2572
2573 2019-09-17  Mike Gulick  <mgulick@mathworks.com>
2574
2575         * source.c (prepare_path_for_appending): New function.
2576         (openp): Make use of new function.
2577         (find_and_open_source): Search for the compilation directory and
2578         source file as a relative path beneath the directory search path.
2579
2580 2019-09-17  Andrew Burgess  <andrew.burgess@embecosm.com>
2581
2582         * source-cache.c (source_cache::get_line_charpos): Catch
2583         exceptions and return false, this matches the behaviour documented
2584         in the header file.
2585
2586 2019-09-17  Joel Brobecker  <brobecker@adacore.com>
2587
2588         * ada-tasks.c (info_task): Remove quoting of the task's name.
2589
2590 2019-09-16  Christian Biesinger  <cbiesinger@google.com>
2591
2592         * symfile.c (auto_solib_add): Replace comment with a reference
2593         to the header file.
2594
2595 2019-09-14  Christian Biesinger  <cbiesinger@google.com>
2596
2597         * NEWS: Mention that gdb can now be compiled with Python 3
2598         on Windows.
2599
2600 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2601
2602         * maint.c (maint_print_section_data::maint_print_section_data):
2603         Force use of 'float log10 (float)' by casting the argument to
2604         float.
2605
2606 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2607
2608         * maint.c: Add 'cmath' include.
2609         (struct maint_print_section_data): New structure.
2610         (print_section_index): New function.
2611         (print_bfd_section_info): Add header comment, small whitespace
2612         cleanup, and update to call new print_section_index function.
2613         (print_objfile_section_info): Likewise.
2614         (maint_obj_section_from_bfd_section): New function.
2615         (print_bfd_section_info_maybe_relocated): New function.
2616         (maintenance_info_sections): Add header comment, always use
2617         bfd_map_over_sections instead of ALL_OBJFILE_OSECTIONS.
2618
2619 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2620
2621         * psymtab.c (find_pc_sect_psymtab): Move baseaddr local into more
2622         inner scope, add check that the objfile has psymtabs before
2623         checking psymtabs_addrmap.
2624         * psymtab.h (psymtab_storage) <psymtabs_addrmap>: Extend comment.
2625
2626 2019-09-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2627
2628         * NEWS: Announce that Ada task names are now shown at more places,
2629         and between quotes (except in info task output).
2630         * gdb/ada-tasks.c (task_to_str): New function.
2631         (display_current_task_id): Call task_to_str.
2632         (task_command_1): Likewise.
2633         (print_ada_task_info): In non-mi mode, Properly align headers and data
2634         when task-id length is > 9 (9 is the default for a 32 bits CORE_ADDR).
2635
2636 2019-09-12  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
2637
2638         * procfs.c (procfs_target::wait) <PR_FAULTED>: Get signal from
2639         prstatus.pr_lwp.pr_info instead of making it up.
2640
2641 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
2642
2643         * auto-load.c (auto_load_expand_dir_vars): Update.
2644         * defs.h (gdb_datadir): Change to std::string.
2645         (python_libdir): Likewise.
2646         (relocate_gdb_directory): Change return type to std::string.
2647         * guile/guile.c (gdbscm_data_directory): Update.
2648         (initialize_scheme_side): Update.
2649         * jit.c (jit_reader_dir): Change to std::string.
2650         (jit_reader_load_command): Update.
2651         * main.c (gdb_datadir): Change to std::string.
2652         (python_libdir): Likewise.
2653         (set_gdb_data_directory): Update.
2654         (relocate_path): Change to return std::string.
2655         (relocate_gdb_directory): Change to return std::string.
2656         (relocate_gdbinit_path_maybe_in_datadir): Update.
2657         (captured_main_1): Update.
2658         * python/python.c (do_start_initialization): Update.
2659         * top.c (show_gdb_datadir): Update.
2660         * xml-syscall.c (xml_init_syscalls_info): Update.
2661         (init_syscalls_info): Update.
2662
2663 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
2664
2665         * main.c (relocate_gdbinit_path_maybe_in_datadir): Factor this code
2666         out of get_init_files.
2667         (get_init_files): Update.
2668
2669 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
2670
2671         * main.c (get_init_files): Change to use std::string.
2672         (captured_main_1): Update.
2673         (print_gdb_help): Update.
2674
2675 2019-09-11  Ali Tamur  <tamur@google.com>
2676
2677         *gdb/target-float.c (host_float_ops<T>::to_longest): Update
2678         implementation.
2679
2680 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
2681
2682         * dbxread.c (read_dbx_symtab): Update.
2683         * dwarf2read.c (load_partial_dies): Update.
2684         * mdebugread.c (parse_partial_symbols): Update.
2685         (handle_psymbol_enumerators): Update.
2686         * psympriv.h (add_psymbol_to_list): Change type of copy_names to bool.
2687         * psymtab.c (add_psymbol_to_bcache): Likewise.
2688         (add_psymbol_to_list): Likewise.
2689         * symtab.c (symbol_set_names): Likewise.
2690         * symtab.h (symbol_set_names): Likewise.
2691         * xcoffread.c (scan_xcoff_symtab): Update.
2692
2693 2019-09-11  Tom Tromey  <tom@tromey.com>
2694
2695         * symfile-mem.c (symbol_file_add_from_memory): Use
2696         bfd_set_filename.
2697         * solib-darwin.c (darwin_bfd_open): Use bfd_set_filename.
2698         * solib-aix.c (solib_aix_bfd_open): Use bfd_set_filename.
2699
2700 2019-09-10  Tom Tromey  <tromey@adacore.com>
2701
2702         * dwarf-index-write.c (write_psymbols): Extend error message.
2703         (debug_names::insert): Add Ada code.
2704         (debug_names::write_psymbols): Remove Ada check.
2705         (debug_names) <m_string_obstack>: New member.
2706         * dwarf2read.c (gdb_index_symbol_name_matcher): Remove.
2707         (gdb_index_symbol_name_matcher::matches): Remove.
2708         (mapped_index_base::find_name_components_bounds): Add "lang"
2709         parameter.
2710         (mapped_index_base::build_name_components): Also split names
2711         according to Ada syntax.
2712         (dw2_expand_symtabs_matching_symbol): Loop over languages.  Change
2713         type of "match_callback".
2714         (check_match, check_find_bounds_finds)
2715         (dw2_expand_symtabs_matching): Update.
2716         (dw2_debug_names_iterator): Add new constructor.
2717         (dw2_debug_names_map_matching_symbols): New function.
2718         (dw2_debug_names_expand_symtabs_matching): Update.
2719         (dwarf2_debug_names_functions): Use
2720         dw2_debug_names_map_matching_symbols.
2721
2722 2019-09-10  Tom Tromey  <tromey@adacore.com>
2723
2724         * dwarf2read.c (dw2_get_file_names_reader): Add the
2725         CU's file name to the results.
2726
2727 2019-09-10  Tom Tromey  <tromey@adacore.com>
2728
2729         * ada-lang.c (add_nonlocal_symbols): Combine calls to
2730         map_matching_symbols.  Update.
2731         * dwarf2read.c (dw2_map_matching_symbols): Update.
2732         * psymtab.c (match_partial_symbol): Change type; update.
2733         (psym_map_matching_symbols): Likewise.
2734         * symfile-debug.c (debug_qf_map_matching_symbols): Change
2735         type; update.
2736         * symfile.h (struct quick_symbol_functions)
2737         <map_matching_symbols>: Change "name" to be a lookup_name_info.
2738         Remove "match".
2739
2740 2019-09-10  Tom Tromey  <tromey@adacore.com>
2741
2742         * psymtab.c (map_block): Remove.
2743         (psym_map_matching_symbols): Use iterate_over_symbols_terminated.
2744         * symtab.c (iterate_over_symbols_terminated): New function.
2745         * symtab.c (iterate_over_symbols_terminated): Declare.
2746
2747 2019-09-10  Tom Tromey  <tromey@adacore.com>
2748
2749         * ada-lang.c (ada_iterate_over_symbols): Return bool.
2750         * language.h (struct language_defn) <la_iterate_over_symbols>:
2751         Return bool.
2752         * symtab.c (iterate_over_symbols): Return bool.
2753         * symtab.h (iterate_over_symbols): Return bool.
2754
2755 2019-09-10  Tom Tromey  <tromey@adacore.com>
2756
2757         * ada-lang.c (aux_add_nonlocal_symbols): Change type.
2758         (add_nonlocal_symbols): Update.
2759         * dwarf2read.c (dw2_map_matching_symbols): Change type.
2760         * psymtab.c (map_block, psym_map_matching_symbols): Change type.
2761         * symfile-debug.c (debug_qf_map_matching_symbols): Change type.
2762         * symfile.h (struct quick_symbol_functions) <map_matching_symbols>:
2763         Change type of "callback".  Remove "data".
2764
2765
2766 2019-09-09  Ali Tamur  <tamur@google.com>
2767
2768         * dwarf2read.c (comp_unit_head): Update comment.
2769         (dwarf2_dwo_name): New function declaration.
2770         (dwarf_unit_type_name): New function declaration.
2771         (read_comp_unit_head): Add support for new compilation units,
2772         DW_UT_partial, DW_UT_skeleton, DW_UT_split_compile, DW_UT_split_type.
2773         Particularly, DW_UT_skeleton and DW_UT_split_compile have dwo_id
2774         (currently named as "signature") in their header. Also clarify error
2775         messages.
2776         (lookup_dwo_id): New function. Returns the dwo id of the given
2777         compile unit.
2778         (lookup_dwo_unit): Use the new lookup_dwo_id function.
2779         (init_cutu_and_read_dies): Use the new dwarf2_dwo_name and lookup_dwo_id
2780         functions.
2781         (create_dwo_cu_reader): Use the added lookup_dwo_id function.
2782         (dwarf2_dwo_name): Get the dwo name if present.
2783         (dwarf_unit_type_name): Convert DW_UT_* types to string for diagnostic
2784         purposes.
2785
2786 2019-09-09  Tom Tromey  <tom@tromey.com>
2787
2788         * tui/tui-win.c (tui_all_windows_info): Use ui_out.
2789
2790 2019-09-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2791
2792         * python/python.c (do_start_initialization): Make progname_copy static,
2793         to avoid a leak report.
2794
2795 2019-09-08  Tom Tromey  <tom@tromey.com>
2796
2797         * tui/tui-wingeneral.c (box_win): Truncate long window titles.
2798
2799 2019-09-07  Simon Marchi  <simon.marchi@efficios.com>
2800
2801         * dwarf2read.c (struct dw2_symtab_iterator) <block_index>:
2802         Change type to gdb::optional<block_enum>.
2803         (dw2_symtab_iter_init): Change block_index parameter type
2804         to gdb::optional<block_enum>.
2805         (dw2_lookup_symbol): Change block_index parameter
2806         type to block_enum.c
2807         (dw2_debug_names_lookup_symbol): Likewise.
2808         * psymtab.c (psym_lookup_symbol): Likewise.
2809         * symfile-debug.c (debug_qf_lookup_symbol): Likewise.
2810         * symfile.h (struct quick_symbol_functions) <lookup_symbol>:
2811         Likewise.
2812
2813 2019-09-06  Christian Biesinger  <cbiesinger@google.com>
2814
2815         * defs.h (relocate_gdb_directory): Change int to bool in
2816         signature and rename flag to relocatable.
2817         * main.c (relocate_path): Likewise.
2818         (relocate_gdb_directory): Likewise.
2819
2820 2019-09-06  Alan Modra  <amodra@gmail.com>
2821
2822         * coffread.c (coff_symfile_read): Constify filename variable.
2823         * dbxread.c (dbx_symfile_init, coffstab_build_psymtabs),
2824         (elfstab_build_psymtabs, stabsect_build_psymtabs): Likewise.
2825         * gdb_bfd.c (gdb_bfd_close_or_warn): Likewise.
2826         * solib.c (reload_shared_libraries_1): Likewise.
2827         * symfile.c (reread_symbols): Likewise.
2828         * solib-aix.c (solib_aix_bfd_open): Add cast for xfree of filename.
2829         * solib-darwin.c (darwin_bfd_open): Likewise.
2830         * symfile-mem.c (symbol_file_add_from_memory): Likewise.
2831
2832 2019-09-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2833
2834         * psymtab.c (print_partial_symbols): Handle missing domain_enum
2835         values MODULE_DOMAIN and COMMON_BLOCK_DOMAIN.
2836
2837 2019-09-03  Tom Tromey  <tromey@adacore.com>
2838
2839         * ada-valprint.c (ada_val_print_num): Don't recurse for range
2840         types.
2841         (has_negatives): Unbias a range type bound.
2842         * dwarf2read.c (read_subrange_type): Handle DW_AT_GNU_bias.
2843         * gdbtypes.c (operator==): Handle new field.
2844         (create_range_type): Add "bias" parameter.
2845         (create_static_range_type, resolve_dynamic_range): Update.
2846         * gdbtypes.h (struct range_bounds) <bias>: New member.
2847         (create_range_type): Add bias parameter.
2848         * printcmd.c (print_scalar_formatted): Unbias range types.
2849         * value.c (unpack_long): Unbias range types.
2850         (pack_long): Bias range types.
2851
2852 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
2853
2854         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Check all
2855         probe arguments.
2856
2857 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
2858
2859         * break-catch-throw.c (fetch_probe_arguments): Use gdbarch.
2860         * dtrace-probe.c (dtrace_probe::get_argument_count): Likewise.
2861         * probe.c (probe_safe_evaluate_at_pc) (compute_probe_arg)
2862         (compile_probe_arg): Likewise.
2863         * probe.h (get_argument_count): Likewise.
2864         * solib-svr4.c (solib_event_probe_action): Likewise.
2865         * stap-probe.c (stap_probe::get_argument_count): Likewise.
2866
2867 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
2868
2869         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Move
2870         code to here...
2871         (svr4_create_solib_event_breakpoints): ...from here.
2872
2873 2019-08-30  Sergio Durigan Junior  <sergiodj@redhat.com>
2874
2875         * nat/fork-inferior.c (trace_start_error): Remove "\nError: "
2876         suffix from warning message.
2877
2878 2019-08-30  Tom Tromey  <tom@tromey.com>
2879
2880         * tui/tui-winsource.h (struct tui_source_window_base)
2881         <refresh_all>: Don't declare.
2882         * tui/tui-winsource.c (tui_source_window_base::refresh_all):
2883         Remove.
2884         * tui/tui-win.c (tui_refresh_all_win): Don't call refresh_all or
2885         tui_show_locator_content.
2886         * tui/tui-regs.h (struct tui_data_window) <refresh_all>: Don't
2887         declare.
2888         * tui/tui-regs.c (tui_data_window::refresh_all): Remove.
2889         * tui/tui-data.h (struct tui_win_info) <refresh_all>: Don't
2890         declare.
2891
2892 2019-08-30  Tom Tromey  <tom@tromey.com>
2893
2894         * tui/tui-io.c (tui_cont_sig): Don't call wrefresh.
2895
2896 2019-08-30  Tom Tromey  <tom@tromey.com>
2897
2898         * tui/tui-stack.c (_initialize_tui_stack): Move later.
2899         Remove unnecessary forward declarations.
2900
2901 2019-08-30  Tom Tromey  <tom@tromey.com>
2902
2903         * tui/tui-stack.c (tui_locator_window::set_locator_fullname): Call
2904         rerender.
2905         (tui_update_locator_fullname, tui_show_frame_info): Don't call
2906         tui_show_locator_content.
2907
2908 2019-08-30  Tom Tromey  <tom@tromey.com>
2909
2910         * tui/tui-stack.c (tui_show_locator_content): Move lower.  Rewrite.
2911         (tui_locator_window::rerender): Rewrite using body of previous
2912         tui_show_locator_content.
2913
2914 2019-08-30  Tom Tromey  <tom@tromey.com>
2915
2916         * tui/tui-stack.h (struct tui_locator_window) <set_locator_info,
2917         set_locator_fullname>: New methods.
2918         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
2919         Rename from tui_set_locator_fullname.
2920         (tui_locator_window::set_locator_info): Rename from
2921         tui_set_locator_info.  Return bool.
2922         (tui_update_locator_fullname, tui_show_frame_info): Update.
2923
2924 2019-08-30  Tom Tromey  <tom@tromey.com>
2925
2926         * tui/tui-layout.c (show_layout): Don't call tui_refresh_all.
2927
2928 2019-08-30  Tom Tromey  <tom@tromey.com>
2929
2930         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Don't
2931         call touchwin.
2932
2933 2019-08-30  Tom Tromey  <tom@tromey.com>
2934
2935         * tui/tui-wingeneral.c (box_win): Assume win_info and
2936         win_info->handle cannot be NULL.
2937
2938 2019-08-30  Tom Tromey  <tom@tromey.com>
2939
2940         * tui/tui-regs.h (struct tui_data_item_window) <rerender,
2941         refresh_window>: Declare.
2942         * tui/tui-regs.c (tui_data_window::display_registers_from): Call
2943         resize.
2944         (tui_data_item_window::rerender): Rename from
2945         tui_display_register.
2946         (tui_data_item_window::refresh_window): New method.
2947         * tui/tui-layout.c (tui_gen_win_info::resize): Do nothing on
2948         no-op.
2949
2950 2019-08-30  Tom Tromey  <tom@tromey.com>
2951
2952         * tui/tui-regs.h (struct tui_data_window) <regs_content,
2953         regs_column_count, current_group>: Move later.  Now private.
2954         <get_current_group>: New method.
2955         * tui/tui-regs.c (tui_reg_command): Update.
2956         * tui/tui-layout.c (tui_set_layout): Update.
2957
2958 2019-08-30  Tom Tromey  <tom@tromey.com>
2959
2960         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
2961         (tui_data_window::rerender): Don't call
2962         check_and_display_highlight_if_needed.
2963         (tui_data_window::refresh_all): Remove call to
2964         erase_data_content.
2965
2966 2019-08-30  Tom Tromey  <tom@tromey.com>
2967
2968         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
2969         (tui_data_window::display_registers_from)
2970         (tui_data_window::display_reg_element_at_line)
2971         (tui_data_window::display_registers_from_line): Remove checks of
2972         "empty".
2973
2974 2019-08-30  Tom Tromey  <tom@tromey.com>
2975
2976         * tui/tui-regs.h (struct tui_data_window) <display_all_data>:
2977         Don't declare.
2978         * tui/tui-regs.c (tui_data_window::show_registers): Call
2979         rerender.
2980         (tui_data_window::rerender): Rename from display_all_data.
2981         (tui_data_window::rerender): Remove old implementation.
2982
2983 2019-08-30  Tom Tromey  <tom@tromey.com>
2984
2985         * tui/tui-regs.c (tui_data_window::display_all_data): Change
2986         text.
2987         * tui/tui-data.h (NO_DATA_STRING): Remove define.
2988
2989 2019-08-29  Bernhard Wodok  <barto@gmx.net>
2990             Sergio Durigan Junior  <sergiodj@redhat.com>
2991
2992         PR win32/24284
2993         * mingw-hdep.c (gdb_select): Handle case when 'n' is zero.
2994
2995 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
2996
2997         * symtab.c (search_symbols): Don't include MODULE_DOMAIN symbols
2998         when searching for types.
2999
3000 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
3001
3002         * f-lang.c (f_language_defn): Use f_print_typedef.
3003         * f-lang.h (f_print_typedef): Declare.
3004         * f-typeprint.c (f_print_typedef): Define.
3005
3006 2019-08-27  Christian Biesinger  <cbiesinger@google.com>
3007
3008         * nat/linux-namespaces.c (mnsh_main): Initialize fd (to -1).
3009
3010 2019-08-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3011
3012         * cli/cli-utils.c (info_print_options_defs): Delete.
3013         (make_info_print_options_def_group): Delete.
3014         (extract_info_print_options): Delete.
3015         (info_print_command_completer): Delete.
3016         (info_print_args_help): Add extra parameter, and optionally
3017         include text about -n flag.
3018         * cli/cli-utils.h (struct info_print_options): Delete.
3019         (extract_info_print_options): Delete declaration.
3020         (info_print_command_completer): Delete declaration.
3021         (info_print_args_help): Add extra parameter, extend header
3022         comment.
3023         * python/python.c (gdbpy_rbreak): Pass additional parameter to
3024         search_symbols.
3025         * stack.c (struct info_print_options): New type.
3026         (info_print_options_defs): New file scoped variable.
3027         (make_info_print_options_def_group): New static function.
3028         (info_print_command_completer): New static function.
3029         (info_locals_command): Update to use new local functions.
3030         (info_args_command): Likewise.
3031         (_initialize_stack): Add extra parameter to calls to
3032         info_print_args_help.
3033         * symtab.c (search_symbols): Add extra parameter, use this to
3034         possibly excluse non-debug symbols.
3035         (symtab_symbol_info): Add extra parameter, which is passed on to
3036         search_symbols.
3037         (struct info_print_options): New type.
3038         (info_print_options_defs): New file scoped variable.
3039         (make_info_print_options_def_group): New static function.
3040         (info_print_command_completer): New static function.
3041         (info_variables_command): Update to use local functions, and pass
3042         extra parameter through to symtab_symbol_info.
3043         (info_functions_command): Likewise.
3044         (info_types_command): Pass additional argument through to
3045         symtab_symbol_info.
3046         (rbreak_command): Pass extra argument to search_symbols.
3047         (_initialize_symtab): Add extra arguments for calls to
3048         info_print_args_help, and update help text for 'info variables',
3049         'whereis', and 'info functions' commands.
3050         * symtab.h (search_symbols): Add extra argument to declaration.
3051         * NEWS: Mention new flags.
3052
3053 2019-08-26  Christian Biesinger  <cbiesinger@google.com>
3054
3055         * symtab.c (lookup_static_symbol): Call the new function (and move
3056         it down to be next to lookup_global_symbol).
3057         (struct global_sym_lookup_data): Add block_enum member and rename to...
3058         (struct global_or_static_sym_lookup_data): ...this.
3059         (lookup_symbol_global_iterator_cb): Pass block_index instead of
3060         GLOBAL_BLOCK to lookup_symbol_in_objfile and rename to...
3061         (lookup_symbol_global_or_static_iterator_cb): ...this.
3062         (lookup_global_or_static_symbol): New function.
3063         (lookup_global_symbol): Call new function.
3064
3065 2019-08-26  Tom de Vries  <tdevries@suse.de>
3066
3067         PR c++/24852
3068         * break-catch-throw.c (fetch_probe_arguments): Improve error mesage
3069         when pc_probe.prob == NULL.
3070
3071 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
3072
3073         * dwarf2read.c (dw2_debug_names_iterator::next): Rename local
3074         variable symbol_linkage to symbol_linkage_.
3075
3076 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
3077
3078         * dwarf2read.c (dw2_debug_names_iterator::next): Use enum to
3079         represent whether the symbol is static, dynamic, or we don't
3080         know.
3081
3082 2019-08-25  Yoshinori Sato <ysato@users.sourceforge.jp>
3083
3084         * gdb/rx-tdep.c (rx_register_names): New.
3085         (rx_register_name): Delete.
3086         (rx_psw_type): Delete.
3087         (rx_fpsw_type): Delete.
3088         (rx_register_type): Delete.
3089         (rx_gdbarch_init): Convert target-descriptions.
3090         (_initialize_rx_tdep): Add initialize_tdesc_rx.
3091         * gdb/features/Makefile: Add rx.xml.
3092         * gdb/features/rx.xml: New.
3093         * gdb/features/rx.c: Generated.
3094         * gdb/NEWS: Mention target description support.
3095
3096 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
3097
3098         * symtab.c (symbol_cache_lookup): Always initialize *bsc_ptr and
3099         *slot_ptr.
3100
3101 2019-08-23  Sergio Durigan Junior  <sergiodj@redhat.com>
3102
3103         * configure.ac: Don't check for 'dlfcn.h' (moved to
3104         gdbsupport/common.m4).
3105         * Makefile.in (COMMON_SFILES): Move 'gdb-dlfcn.c' to
3106         'gdbsupport/'.
3107         (HFILES_NO_SRCDIR): Likewise, for 'gdb-dlfcn.h'.
3108         * compile/compile-c-support.c: Include
3109         'gdbsupport/gdb-dlfcn.h'.
3110         * gdbsupport/common.m4: Check for 'dlfcn.h'.
3111         * gdb-dlfcn.c: Move to...
3112         * gdbsupport/gdb-dlfcn.c: ... here.
3113         * gdb-dlfcn.h: Move to...
3114         * gdbsupport/gdb-dlfcn.h: ... here.
3115
3116 2019-08-23  Sandra Loosemore  <sandra@codesourcery.com>
3117
3118         * nios2-tdep.c (struct reg_value): Improve comments.  Make
3119         the offset field signed.
3120
3121 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
3122
3123         * python/lib/gdb/__init__.py (_execute_file): New function.
3124         * python/python.c (python_run_simple_file): Call gdb._execute_file
3125         on Windows.
3126
3127 2019-08-22  Andrew Burgess  <andrew.burgess@embecosm.com>
3128
3129         * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
3130         all uses as this was never set to anything but a zero value.
3131
3132 2019-08-21  Bogdan Harjoc  <harjoc@gmail.com>
3133
3134         * cli/cli-cmds.c (with_command_1): Error out if no arguments.
3135
3136 2019-08-21  Christian Biesinger  <cbiesinger@google.com>
3137
3138         * tui/tui-data.h (tui_gen_win_info): Add an =default
3139         move constructor, required by some GCC versions.
3140
3141 2019-08-21  Jinke Fan  <fanjinke51@yeah.net>
3142
3143         * go32-nat.c (go32_sysinfo): Add hygon_p.
3144
3145 2019-08-20  Tom Tromey  <tom@tromey.com>
3146
3147         * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
3148         line_from_reg_element_no, first_reg_element_no_inline,
3149         display_all_data, delete_data_content_windows,
3150         erase_data_content>: Now private.
3151
3152 2019-08-20  Tom Tromey  <tom@tromey.com>
3153
3154         * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
3155         (tui_unhighlight_win, tui_highlight_win)
3156         (tui_win_info::make_window): Update.
3157         * tui/tui-data.h (HILITE, NO_HILITE): Remove.
3158
3159 2019-08-20  Tom Tromey  <tom@tromey.com>
3160
3161         * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
3162         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
3163         (MAX_PID_WIDTH): Move to tui-stack.c.
3164         * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
3165         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
3166         (MAX_PID_WIDTH): Move from tui-data.h.
3167
3168 2019-08-20  Tom Tromey  <tom@tromey.com>
3169
3170         * tui/tui-wingeneral.h (tui_make_window): Don't declare.
3171         * tui/tui-wingeneral.c (box_win): Change type of win_info.
3172         (box_win): Update.
3173         (tui_gen_win_info::make_window): Rename from tui_make_window.
3174         (tui_win_info::make_window): New method.
3175         (tui_gen_win_info::make_visible): Update.
3176         * tui/tui-source.c (tui_source_window::set_contents): Update.
3177         * tui/tui-regs.c (tui_data_window::show_register_group): Update.
3178         (tui_data_window::display_registers_from): Update.
3179         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
3180         * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
3181         Declare.
3182         <can_box>: Remove.
3183         <title>: Remove.
3184         (struct tui_win_info) <make_window>: Declare.
3185         <can_box>: Now virtual.
3186         <title>: New member.
3187         * tui/tui-data.c (~tui_gen_win_info): Don't free title.
3188         * tui/tui-command.c (tui_cmd_window::resize): Update.
3189
3190 2019-08-20  Tom Tromey  <tom@tromey.com>
3191
3192         * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
3193         * tui/tui-regs.c (tui_data_window::show_registers): Update.
3194         (tui_data_window::check_register_values): Update.
3195
3196 2019-08-20  Tom Tromey  <tom@tromey.com>
3197
3198         * tui/tui-regs.h (struct tui_data_window): Use
3199         DISABLE_COPY_AND_ASSIGN.
3200         <regs_content>: Change type, removing unique_ptr.
3201         <tui_data_window>: Add move constructor.
3202         * tui/tui-regs.c (tui_data_window::show_registers)
3203         (tui_data_window::show_register_group)
3204         (tui_data_window::display_registers_from)
3205         (tui_data_window::display_registers_from)
3206         (tui_data_window::first_data_item_displayed)
3207         (tui_data_window::delete_data_content_windows)
3208         (tui_data_window::rerender, tui_data_window::refresh_window)
3209         (tui_data_window::check_register_values): Update.
3210
3211 2019-08-20  Tom Tromey  <tom@tromey.com>
3212
3213         * tui/tui-regs.h (struct tui_data_window) <show_registers,
3214         show_register_group>: Declare.
3215         (tui_show_register_group): Don't declare.
3216         * tui/tui-regs.c (tui_data_window::show_registers): Rename from
3217         tui_show_registers.
3218         (tui_data_window::show_register_group): Rename from
3219         tui_show_register_group.
3220         (tui_data_window::check_register_values, tui_reg_command):
3221         Update.
3222         * tui/tui-layout.c (tui_set_layout): Update.
3223
3224 2019-08-20  Tom Tromey  <tom@tromey.com>
3225
3226         * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
3227         Declare.
3228         (tui_check_register_values): Don't declare.
3229         * tui/tui-regs.c (tui_data_window::check_register_values): Rename
3230         from tui_check_register_values.
3231         * tui/tui-hooks.c (tui_register_changed): Update.
3232
3233 2019-08-20  Tom Tromey  <tom@tromey.com>
3234
3235         * tui/tui-regs.c (tui_reg_layout): Move later.
3236         (tui_show_registers): Don't enable TUI mode or change layout.
3237
3238 2019-08-20  Tom Tromey  <tom@tromey.com>
3239
3240         * tui/tui-regs.h (struct tui_data_item_window)
3241         <~tui_data_item_window>: Remove.
3242         <content>: Now a unique_xmalloc_ptr.
3243         * tui/tui-regs.c (tui_register_format): Return a
3244         unique_xmalloc_ptr.
3245         (tui_get_register): Update.
3246         (~tui_data_item_window): Remove.
3247         (tui_data_window::display_registers_from, tui_display_register):
3248         Update.
3249         * tui/tui-io.h (tui_expand_tabs): Update.
3250         * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
3251         Remove "col" parameter.
3252
3253 2019-08-20  Tom Tromey  <tom@tromey.com>
3254
3255         * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
3256         field.
3257         * tui/tui-regs.c (~tui_data_item_window): Update.
3258
3259 2019-08-20  Tom Tromey  <tom@tromey.com>
3260
3261         * tui/tui-regs.c (tui_register_format, tui_get_register): Move
3262         earlier.
3263
3264 2019-08-20  Tom Tromey  <tom@tromey.com>
3265
3266         * tui/tui-regs.c (tui_reg_command): Remove NULL check.
3267
3268 2019-08-20  Tom Tromey  <tom@tromey.com>
3269
3270         * tui/tui-source.h (struct tui_source_window): Update.
3271         * tui/tui-regs.c (tui_show_registers): Update.
3272         * tui/tui-disasm.h (struct tui_disasm_window): Update.
3273         * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
3274         (NO_REGS_STRING): Remove defines.
3275
3276 2019-08-20  Conrad Meyer  <cem@FreeBSD.org>
3277
3278         * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
3279         unnecessary thread walk if remote doesn't support the packet.
3280
3281 2019-08-19  Tom Tromey  <tromey@adacore.com>
3282
3283         * python/py-value.c (value_has_field): Fix indentation.
3284
3285 2019-08-19  Tom Tromey  <tromey@adacore.com>
3286
3287         * printcmd.c (do_one_display, info_display_command): Update.
3288         * block.h (contained_in): Return bool.  Add allow_nested
3289         parameter.
3290         * block.c (contained_in): Return bool.  Add allow_nested
3291         parameter.
3292
3293 2019-08-19  Tom Tromey  <tom@tromey.com>
3294
3295         * configure: Rebuild.
3296         * configure.ac: Disallow the combination of -static-libstdc++ and
3297         source highlight.
3298         * source-cache.c (get_language_name): Handle rust.
3299         (source_cache::get_source_lines): Ignore highlighting exceptions.
3300
3301 2019-08-16  Tom Tromey  <tom@tromey.com>
3302
3303         * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
3304         * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
3305         (struct tui_source_window_base) <make_visible, refresh_window,
3306         resize>: Remove methods.
3307         <execution_info>: Remove field.
3308         * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
3309         (tui_show_source_line, tui_source_window_base)
3310         (~tui_source_window_base): Update.
3311         (tui_source_window_base::resize)
3312         (tui_source_window_base::make_visible)
3313         (tui_source_window_base::refresh_window): Remove.
3314         (tui_source_window_base::update_exec_info): Update.
3315         * tui/tui-source.c (tui_source_window::set_contents): Update.
3316         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
3317
3318 2019-08-16  Tom Tromey  <tom@tromey.com>
3319
3320         * tui/tui-hooks.c (tui_remove_hooks): Don't set
3321         deprecated_query_hook.
3322
3323 2019-08-16  Tom Tromey  <tom@tromey.com>
3324
3325         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
3326         (tui_update_source_windows_with_line): Update.
3327         * tui/tui-source.h (struct tui_source_window)
3328         <show_symtab_source>: Declare.
3329         (tui_show_symtab_source): Don't declare.
3330         * tui/tui-source.c (tui_show_symtab_source): Rename from
3331         tui_show_symtab_source.
3332
3333 2019-08-16  Tom Tromey  <tom@tromey.com>
3334
3335         * tui/tui-winsource.h (struct tui_source_window_base)
3336         <set_contents>: Declare.
3337         * tui/tui-winsource.c
3338         (tui_source_window_base::update_source_window_as_is): Update.
3339         * tui/tui-source.h (struct tui_source_window) <set_contents>:
3340         Declare.
3341         (tui_set_source_content): Don't declare.
3342         * tui/tui-source.c (tui_source_window::set_contents): Rename from
3343         tui_set_source_content.
3344         * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
3345         Declare.
3346         (tui_set_disassem_content): Don't declare.
3347         * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
3348         tui_set_disassem_content.
3349
3350 2019-08-16  Tom Tromey  <tom@tromey.com>
3351
3352         * tui/tui-winsource.h (struct tui_source_window_base)
3353         <update_breakpoint_info>: Declare.
3354         (tui_update_breakpoint_info): Don't declare.
3355         * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
3356         (tui_update_all_breakpoint_info): Update.
3357         (tui_source_window_base::update_breakpoint_info): Rename from
3358         tui_update_breakpoint_info.
3359         (tui_source_window_base::update_exec_info): Update.
3360
3361 2019-08-16  Tom Tromey  <tom@tromey.com>
3362
3363         * tui/tui-winsource.h (struct tui_source_window_base)
3364         <update_source_window>: Declare.
3365         (tui_update_source_window): Don't declare.
3366         * tui/tui-winsource.c
3367         (tui_source_window_base::update_source_window): Rename from
3368         tui_update_source_window.
3369         (tui_source_window_base::rerender): Update.
3370         * tui/tui-source.c (tui_source_window::maybe_update): Update.
3371         * tui/tui-disasm.c (tui_show_disassem)
3372         (tui_show_disassem_and_update_source)
3373         (tui_disasm_window::maybe_update): Update.
3374
3375 2019-08-16  Tom Tromey  <tom@tromey.com>
3376
3377         * tui/tui-winsource.h (struct tui_source_window_base)
3378         <update_source_window_as_is>: Declare.
3379         (tui_update_source_window_as_is): Don't declare.
3380         * tui/tui-winsource.c (tui_update_source_window): Update
3381         (tui_source_window_base::update_source_window_as_is): Rename from
3382         tui_update_source_window_as_is.
3383         (tui_source_window_base::refill): Update.
3384         * tui/tui-source.c (tui_show_symtab_source): Update.
3385         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
3386         Update.
3387
3388 2019-08-16  Tom Tromey  <tom@tromey.com>
3389
3390         * tui/tui-winsource.h (tui_update_source_window)
3391         (tui_update_source_window_as_is): Remove "noerror" parameter.
3392         * tui/tui-winsource.c (tui_update_source_window)
3393         (tui_update_source_window_as_is): Remove "noerror" parameter.
3394         (tui_update_source_windows_with_addr)
3395         (tui_update_source_windows_with_line)
3396         (tui_source_window_base::rerender)
3397         (tui_source_window_base::refill): Update.
3398         * tui/tui-source.h (tui_set_source_content)
3399         (tui_show_symtab_source): Remove "noerror" parameter.
3400         * tui/tui-source.c (tui_set_source_content): Remove "noerror"
3401         parameter.
3402         (tui_show_symtab_source): Likewise.
3403         (tui_source_window::maybe_update): Update.
3404         * tui/tui-disasm.c (tui_show_disassem)
3405         (tui_show_disassem_and_update_source)
3406         (tui_disasm_window::do_scroll_vertical)
3407         (tui_disasm_window::maybe_update): Update.
3408
3409 2019-08-16  Tom Tromey  <tom@tromey.com>
3410
3411         * tui/tui.c (tui_is_window_visible): Update.
3412         * tui/tui-wingeneral.c (tui_make_window)
3413         (tui_gen_win_info::make_visible, tui_refresh_all): Update.
3414         * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
3415         (tui_set_focus_command, tui_all_windows_info, update_tab_width)
3416         (tui_set_win_height_command, parse_scrolling_args): Update.
3417         * tui/tui-source.c (tui_source_window::style_changed): Update.
3418         * tui/tui-regs.c (tui_show_registers)
3419         (tui_data_window::first_data_item_displayed)
3420         (tui_data_window::delete_data_content_windows)
3421         (tui_check_register_values, tui_reg_command): Update.
3422         * tui/tui-disasm.c (tui_show_disassem): Update.
3423         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
3424         method.
3425         <is_visible>: Remove field.
3426         * tui/tui-data.c (tui_next_win, tui_prev_win)
3427         (tui_delete_invisible_windows): Update.
3428
3429 2019-08-16  Tom Tromey  <tom@tromey.com>
3430
3431         * tui/tui-winsource.h (struct tui_source_window_base)
3432         <m_has_locator>: Remove.
3433         * tui/tui-layout.c (show_source_disasm_command, show_data)
3434         (show_source_or_disasm_and_command): Update.
3435
3436 2019-08-16  Alan Hayward  <alan.hayward@arm.com>
3437
3438         * NEWS (Other MI changes): New subsection.
3439         * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
3440         (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
3441         * arch-utils.c (default_get_pc_address_flags): New function.
3442         * arch-utils.h (default_get_pc_address_flags): New declaration.
3443         * gdbarch.sh: Add get_pc_address_flags.
3444         * gdbarch.c: Regenerate.
3445         * gdbarch.h: Likewise.
3446         * stack.c (print_pc): New function.
3447         (print_frame_info) (print_frame): Call print_pc.
3448
3449 2019-08-16  Tom de Vries  <tdevries@suse.de>
3450
3451         * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
3452         print_objfile_section_info.
3453
3454 2019-08-15  Tom Tromey  <tom@tromey.com>
3455
3456         * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
3457         calling update_cmdwin_start_line.
3458         * tui/tui-winsource.h (struct tui_source_window_base)
3459         <do_make_visible_with_new_height, set_new_height>: Don't declare.
3460         <rerender>: Declare.
3461         * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
3462         Call rerender.
3463         (tui_source_window_base::set_new_height): Remove.
3464         (tui_source_window_base::rerender): Rename from
3465         do_make_visible_with_new_height.
3466         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
3467         resize method.
3468         (tui_win_info::make_invisible_and_set_new_height)
3469         (tui_win_info::make_visible_with_new_height): Remove.
3470         * tui/tui-stack.h (struct tui_locator_window) <rerender>:
3471         Declare.
3472         * tui/tui-stack.c (tui_locator_window::rerender): New method.
3473         * tui/tui-regs.h (struct tui_data_window) <set_new_height,
3474         do_make_visible_with_new_height>: Don't declare.
3475         <rerender>: Declare.
3476         * tui/tui-regs.c (tui_data_window::rerender): Rename from
3477         set_new_height.
3478         (tui_data_window::do_make_visible_with_new_height): Remove.
3479         * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
3480         call tui_show_locator_content.
3481         (tui_gen_win_info::resize): Call rerender.
3482         (show_source_or_disasm_and_command): Don't call
3483         tui_show_locator_content.
3484         * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
3485         method.
3486         (struct tui_win_info) <rerender>: Declare.
3487         <set_new_height, make_invisible_and_set_new_height,
3488         make_visible_with_new_height>: Don't declare.
3489         * tui/tui-data.c (tui_win_list::rerender): New method.
3490         * tui/tui-command.h (struct tui_cmd_window)
3491         <do_make_visible_with_new_height>: Don't declare.
3492         * tui/tui-command.c
3493         (tui_cmd_window::do_make_visible_with_new_height): Remove.
3494
3495 2019-08-15  Tom Tromey  <tromey@adacore.com>
3496
3497         * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
3498         * ada-lang.c (ada_enum_name): Likewise.
3499
3500 2019-08-15  Christian Biesinger  <cbiesinger@google.com>
3501
3502         * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
3503         leading underscore.
3504         (GdbOutputErrorFile): Likewise.
3505         (global scope): Adjust constructor calls to GdbOutput{,Error}File
3506         accordingly.
3507         (execute_unwinders): Rename to have a leading underscore.
3508         (auto_load_packages): Likewise.
3509         (global scope): Adjust call to auto_load_packages accordingly.
3510         (GdbSetPythonDirectory): Likewise.
3511         * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
3512         instead of execute_unwinders.
3513
3514 2019-08-15  Tom Tromey  <tom@tromey.com>
3515
3516         * tui/tui-layout.c (show_layout, show_source_disasm_command)
3517         (show_data): Don't change window visibility.
3518         (tui_gen_win_info::resize): Remove special case for command
3519         window.  Use wresize, when available.
3520         (show_source_or_disasm_and_command): Don't change window
3521         visibility.
3522         * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
3523         <make_visible>: New method.
3524         * tui/tui-command.c (tui_cmd_window::resize): New method.
3525
3526 2019-08-15  Tom Tromey  <tom@tromey.com>
3527
3528         * tui/tui-winsource.h (struct tui_source_window_iterator): New.
3529         (struct tui_source_windows): New.
3530         * tui/tui-winsource.c (tui_display_main): Update.
3531         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
3532         (new_height_ok, parse_scrolling_args): Update.
3533         * tui/tui-layout.c (show_layout, show_data): Update.
3534         * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
3535         (tui_add_to_source_windows): Don't declare.
3536         * tui/tui-data.c (source_windows, tui_source_windows)
3537         (tui_clear_source_windows, tui_add_to_source_windows): Remove.
3538
3539 2019-08-15  Tom Tromey  <tom@tromey.com>
3540
3541         * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
3542         Rename from reset.
3543         * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
3544         * tui/tui-layout.c (show_source_disasm_command, show_data):
3545         Update.
3546         (tui_gen_win_info::resize): Rename.
3547         (show_source_or_disasm_and_command): Update.
3548         * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
3549         reset.
3550
3551 2019-08-15  Tom Tromey  <tom@tromey.com>
3552
3553         * tui/tui-stack.c (tui_initialize_static_data): Remove.
3554         * tui/tui-interp.c (tui_interp::init): Don't call
3555         tui_initialize_static_data.
3556         * tui/tui-data.h (tui_initialize_static_data): Don't declare.
3557
3558 2019-08-15  Tom Tromey  <tom@tromey.com>
3559
3560         * tui/tui-layout.c (tui_default_win_viewport_height): Don't
3561         examine tui_win_list.
3562
3563 2019-08-15  Tom Tromey  <tom@tromey.com>
3564
3565         * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
3566         * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
3567         tui_clear_source_content.
3568         (tui_clear_source_content): Remove.
3569         (tui_source_window_base::do_erase_source_content): Hoist call to
3570         content.clear().
3571         * tui/tui-stack.c (tui_show_frame_info): Don't call
3572         tui_clear_source_content.
3573
3574 2019-08-15  Tom Tromey  <tom@tromey.com>
3575
3576         * tui/tui-winsource.h (struct tui_source_window_base)
3577         <do_erase_source_content>: New method.
3578         <erase_source_content>: New method.
3579         (tui_erase_source_content): Don't declare.
3580         * tui/tui-winsource.c (tui_clear_source_content): Update.
3581         (tui_source_window_base::do_erase_source_content): Rename from
3582         tui_erase_source_content.
3583         (tui_source_window_base::show_source_content): Update.
3584         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
3585         * tui/tui-source.h (struct tui_source_window)
3586         <erase_source_content>: New method.
3587         * tui/tui-disasm.h (struct tui_disasm_window)
3588         <erase_source_content>: New method.
3589
3590 2019-08-15  Tom Tromey  <tom@tromey.com>
3591
3592         * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
3593         (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
3594         constructor.
3595         * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
3596         * tui/tui-source.c (tui_set_source_content): Update.
3597         * tui/tui-disasm.c (tui_set_disassem_content): Update.
3598
3599 2019-08-15  Tom Tromey  <tom@tromey.com>
3600
3601         * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
3602         * tui/tui-winsource.c (tui_line_is_displayed): Move to
3603         tui-source.c.
3604         * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
3605         Declare.
3606         * tui/tui-source.c (tui_source_window::line_is_displayed): New
3607         method.
3608         (tui_source_window::maybe_update): Update.
3609
3610 2019-08-15  Tom Tromey  <tom@tromey.com>
3611
3612         * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
3613         * tui/tui-winsource.c (tui_addr_is_displayed): Move to
3614         tui-disasm.c.
3615         * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
3616         Declare.
3617         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
3618         method.
3619         (tui_disasm_window::maybe_update): Update.
3620
3621 2019-08-15  Tom Tromey  <tom@tromey.com>
3622
3623         * tui/tui-winsource.h (struct tui_source_window_base)
3624         <maybe_update>: Declare.
3625         * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
3626         method.
3627         * tui/tui-source.h (struct tui_source_window) <maybe_update>:
3628         Declare.
3629         * tui/tui-source.c (tui_source_window::maybe_update): New method.
3630         * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
3631         Declare.
3632         * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
3633
3634 2019-08-15  Tom Tromey  <tom@tromey.com>
3635
3636         * tui/tui-stack.c (tui_make_status_line): Use string constructor.
3637
3638 2019-08-15  Tom Tromey  <tom@tromey.com>
3639
3640         * tui/tui-wingeneral.c: Include tui-stack.h.
3641         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
3642         (struct tui_locator_window): Move from tui-data.h.
3643         * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
3644         (tui_initialize_static_data): Move from tui-data.c.
3645         * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
3646         (struct tui_locator_window): Move to tui-stack.c.
3647         * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
3648         (tui_initialize_static_data): Move to tui-stack.c.
3649
3650 2019-08-15  Tom Tromey  <tom@tromey.com>
3651
3652         * tui/tui-layout.c (show_source_disasm_command)
3653         (show_source_or_disasm_and_command): Use make_visible method, not
3654         tui_make_window.
3655         * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
3656         Remove.
3657
3658 2019-08-15  Tom Tromey  <tom@tromey.com>
3659
3660         * tui/tui-wingeneral.h (tui_make_window): Update.
3661         * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
3662         parameter.
3663         (tui_gen_win_info::make_visible): Update.
3664         * tui/tui-regs.c (tui_data_window::display_registers_from):
3665         Update.
3666         * tui/tui-layout.c (show_source_disasm_command)
3667         (show_source_or_disasm_and_command): Update.
3668         * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
3669         (enum tui_box): Remove.
3670         (struct tui_win_info) <can_box>: New method.
3671         * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
3672         method.
3673
3674 2019-08-15  Tom de Vries  <tdevries@suse.de>
3675
3676         * linux-nat-trad.c: Include gdbarch.h.
3677
3678 2019-08-14  Alan Hayward  <alan.hayward@arm.com>
3679
3680         * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
3681         register sizes.
3682
3683 2019-08-14  Tom Tromey  <tromey@adacore.com>
3684
3685         * darwin-nat.c: Include gdbarch.h.
3686         * darwin-nat-info.c: Include gdbarch.h.
3687
3688 2019-08-13  Tom Tromey  <tom@tromey.com>
3689
3690         * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
3691         Remove.
3692         * tui/tui-data.c (tui_initialize_static_data): Update.
3693
3694 2019-08-13  Tom Tromey  <tom@tromey.com>
3695
3696         * tui/tui-winsource.h (struct tui_exec_info_window)
3697         <~tui_exec_info_window, maybe_allocate_content, get_content,
3698         m_content>: Remove.
3699         (struct tui_source_window_base) <set_exec_info_content,
3700         show_exec_info_content>: Don't declare.
3701         * tui/tui-winsource.c
3702         (tui_exec_info_window::maybe_allocate_content): Remove.
3703         (tui_source_window_base::update_exec_info): Rename from
3704         set_exec_info_content.
3705         (tui_source_window_base::show_exec_info_content)
3706         (tui_source_window_base::update_exec_info): Remove.
3707
3708 2019-08-13  Tom Tromey  <tom@tromey.com>
3709
3710         * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
3711         declare.
3712         * tui/tui-winsource.c (tui_update_source_window_as_is)
3713         (tui_update_source_windows_with_addr, tui_erase_source_content):
3714         Update.
3715         (tui_clear_exec_info_content): Remove.
3716
3717 2019-08-13  Tom Tromey  <tom@tromey.com>
3718
3719         * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
3720         declare.
3721         * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
3722         call tui_erase_exec_info_content.
3723         (tui_clear_exec_info_content): Rename from
3724         tui_erase_exec_info_content.
3725         (tui_clear_exec_info_content): Delete.
3726
3727 2019-08-13  Tom Tromey  <tom@tromey.com>
3728
3729         * tui/tui-winsource.h (struct tui_source_window_base)
3730         <show_exec_info_content>: Declare.
3731         (tui_show_exec_info_content): Don't declare.
3732         * tui/tui-winsource.c
3733         (tui_source_window_base::show_exec_info_content): Rename from
3734         tui_show_exec_info_content.
3735         (tui_source_window_base::update_exec_info): Update.
3736
3737 2019-08-13  Tom Tromey  <tom@tromey.com>
3738
3739         * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
3740         (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
3741         (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
3742         * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
3743         tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
3744         (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
3745         ... here.
3746
3747 2019-08-13  Tom Tromey  <tom@tromey.com>
3748
3749         * tui/tui-winsource.h (struct tui_source_window_base)
3750         <update_exec_info>: Declare.
3751         (tui_update_exec_info): Don't declare.
3752         * tui/tui-winsource.c (tui_update_source_window_as_is)
3753         (tui_source_window_base::refresh_all)
3754         (tui_update_all_breakpoint_info): Update.
3755         (tui_source_window_base::update_exec_info): Rename from
3756         tui_update_exec_info.
3757         * tui/tui-stack.c (tui_show_frame_info): Update.
3758
3759 2019-08-13  Tom Tromey  <tom@tromey.com>
3760
3761         * tui/tui-winsource.h (struct tui_source_window_base)
3762         <set_exec_info_content>: Declare.
3763         (tui_set_exec_info_content): Don't declare.
3764         * tui/tui-winsource.c
3765         (tui_source_window_base::set_exec_info_content): Rename from
3766         tui_set_exec_info_content.
3767         (tui_update_exec_info): Update.
3768
3769 2019-08-13  Tom Tromey  <tom@tromey.com>
3770
3771         * tui/tui-winsource.h (struct tui_source_window_base)
3772         <show_source_content>: Declare.
3773         (tui_show_source_content): Don't declare.
3774         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
3775         (tui_source_window_base::show_source_content): Rename from
3776         tui_show_source_content.
3777         (tui_source_window_base::refresh_all): Update.
3778         * tui/tui-layout.c (show_source_disasm_command)
3779         (show_source_or_disasm_and_command): Update.
3780
3781 2019-08-13  Tom Tromey  <tom@tromey.com>
3782
3783         * tui/tui-winsource.c (tui_erase_source_content)
3784         (tui_show_source_content, tui_source_window_base::refresh_all):
3785         Update.
3786         * tui/tui-wingeneral.h
3787         (tui_check_and_display_highlight_if_needed): Don't declare.
3788         * tui/tui-wingeneral.c
3789         (tui_win_info::check_and_display_highlight_if_needed): Rename from
3790         check_and_display_highlight_if_needed.
3791         * tui/tui-win.c (tui_rehighlight_all)
3792         (tui_win_info::make_visible_with_new_height): Update.
3793         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
3794         (tui_data_window::erase_data_content)
3795         (tui_data_window::display_all_data): Update.
3796         * tui/tui-data.h (struct tui_win_info)
3797         <check_and_display_highlight_if_needed>: Declare.
3798
3799 2019-08-13  Tom Tromey  <tom@tromey.com>
3800
3801         * tui/tui-win.c (tui_resize_all): Call
3802         tui_delete_invisible_windows.
3803         * tui/tui-layout.c (show_layout): Call
3804         tui_delete_invisible_windows.
3805         * tui/tui-data.h (tui_delete_invisible_windows): Declare.
3806         * tui/tui-data.c (tui_delete_invisible_windows): New function.
3807
3808 2019-08-13  Tom Tromey  <tom@tromey.com>
3809
3810         * tui/tui-disasm.c (tui_show_disassem): Add assertion.  Don't call
3811         tui_add_win_to_layout.
3812
3813 2019-08-13  Tom Tromey  <tom@tromey.com>
3814
3815         * tui/tui-layout.h (tui_default_win_height): Don't declare.
3816         * tui/tui-layout.c (tui_default_win_height): Now static.
3817
3818 2019-08-13  Tom Tromey  <tom@tromey.com>
3819
3820         * tui/tui-layout.c (show_layout): Unify all layout cases into a
3821         single switch.
3822         (show_source_disasm_command, show_source_or_disasm_and_command):
3823         Don't check current layout.
3824
3825 2019-08-13  Tom Tromey  <tom@tromey.com>
3826
3827         * tui/tui-wingeneral.c (make_all_visible): Remove.
3828         (tui_make_all_invisible): Simplify.
3829         * tui/tui-layout.c (tui_make_all_invisible): Move from
3830         tui-wingeneral.c; simplify.
3831         (show_layout): Hoist call to tui_make_all_invisible.
3832         (show_data): Don't call tui_make_all_invisible.
3833
3834 2019-08-13  Tom Tromey  <tom@tromey.com>
3835
3836         * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
3837         * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
3838
3839 2019-08-13  Tom Tromey  <tom@tromey.com>
3840
3841         * tui/tui-layout.c (current_layout, tui_current_layout): Move from
3842         tui-data.c.
3843         (show_source_disasm_command, show_data)
3844         (show_source_or_disasm_and_command): Don't use
3845         tui_set_current_layout_to.
3846         * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
3847         * tui/tui-data.c (current_layout, tui_current_layout): Move to
3848         tui-layout.c.
3849         (tui_set_current_layout_to): Remove.
3850
3851 2019-08-13  Tom Tromey  <tom@tromey.com>
3852
3853         * tui/tui-layout.c (tui_set_layout): Update.
3854         * tui/tui-data.h (struct tui_layout_def): Remove.
3855         (tui_layout_def): Don't declare.
3856         * tui/tui-data.c (layout_def): Remove.
3857         (tui_layout_def): Remove.
3858
3859 2019-08-13  Tom Tromey  <tom@tromey.com>
3860
3861         * tui/tui-winsource.h (struct tui_source_window_base)
3862         <clear_detail>: No longer "override".
3863         * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
3864         * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
3865         * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
3866         * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
3867         Remove.
3868         * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
3869
3870 2019-08-13  Tom Tromey  <tromey@adacore.com>
3871
3872         * tracepoint.c: Don't include readline.h or history.h.
3873
3874 2019-08-12  Tom Tromey  <tom@tromey.com>
3875
3876         * configure: Rebuild.
3877         * configure.ac: Check for readline 7.
3878         * NEWS: Mention readline 7 requirement.
3879         * README: Update.
3880
3881 2019-08-12  Tom Tromey  <tom@tromey.com>
3882
3883         * mingw-hdep.c (gdb_select): Remove readline hack.
3884
3885 2019-08-09  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
3886
3887         * blockframe.c (find_pc_partial_function): Set *block to nullptr
3888         when the function fails.
3889
3890 2019-08-09  Andreas Arnez  <arnez@linux.ibm.com>
3891
3892         * s390-tdep.c (s390_type_align): New function.
3893         (s390_gdbarch_init): Set it as type_align gdbarch method.
3894
3895 2019-08-09  Tom de Vries  <tdevries@suse.de>
3896
3897         PR gdb/24591
3898         * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
3899         pc_low with relocation offset.
3900
3901 2019-08-07  Tom Tromey  <tromey@adacore.com>
3902
3903         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
3904         (print_frame_args): Update.
3905         * python/py-framefilter.c (py_print_single_arg, enumerate_args):
3906         Update.
3907         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
3908         * frame.h (struct frame_arg): Add initializers.
3909         <error>: Now a unique_xmalloc_ptr.
3910
3911 2019-08-07  Alan Hayward  <alan.hayward@arm.com>
3912
3913         * NEWS: Expand the Pointer Authentication entry.
3914         * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
3915         (aarch64_frame_unmask_lr): ... to this.
3916         (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
3917         Call aarch64_frame_unmask_lr.
3918         * frame.c (struct frame_info): Add "masked" variable.
3919         (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
3920         (fprint_frame): Check for masked pc.
3921         * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
3922         declarations.
3923         * python/py-framefilter.c (py_print_frame): Check for masked pc.
3924         * stack.c (print_frame): Check for masked pc.
3925
3926 2019-08-06  Tom Tromey  <tom@tromey.com>
3927
3928         * stabsread.c (patch_block_stabs, read_one_struct_field)
3929         (read_enum_type): Use obstack_strndup.
3930         * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
3931         * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
3932         * dwarf2read.c (guess_full_die_structure_name)
3933         (anonymous_struct_prefix): Use obstack_strndup.
3934         * dbxread.c (cp_set_block_scope): Use obstack_strndup.
3935         * c-exp.y (yylex): Use obstack_strndup.
3936         * ada-exp.y (write_object_renaming, write_ambiguous_var)
3937         (write_var_or_type): Use obstack_strndup.
3938
3939 2019-08-06  Tom Tromey  <tom@tromey.com>
3940
3941         * symfile.c (reread_symbols): Use obstack_strdup.
3942         * stabsread.c (read_type): Use obstack_strdup.
3943         * gdb_obstack.h (obstack_strdup): New overload.
3944         * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
3945         (create_dwo_unit_in_dwp_v2, build_error_marker_type)
3946         (dwarf2_canonicalize_name): Use obstack_strdup.
3947         * dbxread.c (read_dbx_symtab): Use obstack_strdup.
3948         * cp-support.c (inspect_type, replace_typedefs_qualified_name):
3949         Use obstack_strdup.
3950
3951 2019-08-06  Tom Tromey  <tom@tromey.com>
3952
3953         * gdb_obstack.h (obstack_strdup): Define.
3954         * gdb_obstack.c (obstack_strdup): Don't define.
3955
3956 2019-08-06  Tom Tromey  <tom@tromey.com>
3957
3958         * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
3959         obstack_strdup.
3960         * typeprint.c (typedef_hash_table::find_global_typedef): Use
3961         obstack_strdup.
3962         * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
3963         * stabsread.c (common_block_start): Use obstack_strdup.
3964         * objfiles.c (set_objfile_main_name, objfile): Use
3965         obstack_strdup.
3966         * namespace.c (add_using_directive): Use obstack_strdup.
3967         * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
3968         * jit.c (finalize_symtab): Use obstack_strdup.
3969         * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
3970         (guess_partial_die_structure_name, partial_die_info::fixup)
3971         (dwarf2_name): Use obstack_strdup.
3972         * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
3973         obstack_strdup.
3974         * c-exp.y (scan_macro_expansion): Use obstack_strdup.
3975         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
3976         obstack_strdup.
3977         * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
3978
3979 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3980
3981         * unittests/help-doc-selftests.c: New file.
3982         * Makefile.in: Add the new file.
3983
3984 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3985
3986         * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
3987         * cli/cli-decode.c (print_doc_line): Likewise.  It now prints
3988         the full first line, except when FOR_VALUE_PREFIX.  In this case,
3989         the trailing '.' is not output, and the first character is uppercased.
3990         (print_help_for_command): Update call to print_doc_line.
3991         (print_doc_of_command): Likewise.
3992         * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
3993         * cli/cli-option.c (append_indented_doc): Do not append newline.
3994         (build_help_option): Append newline after first appended_indented_doc
3995         only if a second call is done.
3996         (build_help): Append 2 new lines before each option, except the first
3997         one.
3998         * compile/compile.c (_initialize_compile): Add new lines after
3999         %OPTIONS%, when not at the end of the help.
4000         Change help doc or code
4001         producing the help doc to respect the invariants.
4002         * maint-test-options.c (_initialize_maint_test_options): Likewise.
4003         Also removed the new line after 'Options:', as all other commands
4004         do not put an empty line between 'Options:' and the first option.
4005         * printcmd.c (_initialize_printcmd): Likewise.
4006         * stack.c (_initialize_stack): Likewise.
4007         * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
4008         incorrectly telling COMMAND is optional.
4009         * ada-lang.c (_initialize_ada_language): Change help doc or code
4010         producing the help doc to respect the invariants.
4011         * ada-tasks.c (_initialize_ada_tasks): Likewise.
4012         * breakpoint.c (_initialize_breakpoint): Likewise.
4013         * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
4014         * cli/cli-logging.c (_initialize_cli_logging): Likewise.
4015         * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
4016         * cli/cli-style.c (cli_style_option::add_setshow_commands,
4017         _initialize_cli_style): Likewise.
4018         * corelow.c (core_target_info): Likewise.
4019         * dwarf-index-cache.c (_initialize_index_cache): Likewise.
4020         * dwarf2read.c (_initialize_dwarf2_read): Likewise.
4021         * filesystem.c (_initialize_filesystem): Likewise.
4022         * frame.c (_initialize_frame): Likewise.
4023         * gnu-nat.c (add_task_commands): Likewise.
4024         * infcall.c (_initialize_infcall): Likewise.
4025         * infcmd.c (_initialize_infcmd): Likewise.
4026         * interps.c (_initialize_interpreter): Likewise.
4027         * language.c (_initialize_language): Likewise.
4028         * linux-fork.c (_initialize_linux_fork): Likewise.
4029         * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
4030         * maint.c (_initialize_maint_cmds): Likewise.
4031         * memattr.c (_initialize_mem): Likewise.
4032         * printcmd.c (_initialize_printcmd): Likewise.
4033         * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
4034         _RegEx): Likewise.
4035         * ravenscar-thread.c (_initialize_ravenscar): Likewise.
4036         * record-btrace.c (_initialize_record_btrace): Likewise.
4037         * record-full.c (_initialize_record_full): Likewise.
4038         * record.c (_initialize_record): Likewise.
4039         * regcache-dump.c (_initialize_regcache_dump): Likewise.
4040         * regcache.c (_initialize_regcache): Likewise.
4041         * remote.c (add_packet_config_cmd, init_remote_threadtests,
4042         _initialize_remote): Likewise.
4043         * ser-tcp.c (_initialize_ser_tcp): Likewise.
4044         * serial.c (_initialize_serial): Likewise.
4045         * skip.c (_initialize_step_skip): Likewise.
4046         * source.c (_initialize_source): Likewise.
4047         * stack.c (_initialize_stack): Likewise.
4048         * symfile.c (_initialize_symfile): Likewise.
4049         * symtab.c (_initialize_symtab): Likewise.
4050         * target-descriptions.c (_initialize_target_descriptions): Likewise.
4051         * top.c (init_main): Likewise.
4052         * tracefile-tfile.c (tfile_target_info): Likewise.
4053         * tracepoint.c (_initialize_tracepoint): Likewise.
4054         * tui/tui-win.c (_initialize_tui_win): Likewise.
4055         * utils.c (add_internal_problem_command): Likewise.
4056         * valprint.c (value_print_option_defs): Likewise.
4057
4058 2019-08-06  Frank Ch. Eigler  <fche@redhat.com>
4059
4060         PR build/24886
4061         * configure.ac: Drop enable-libmcheck support.
4062         * configure, config.in: Rebuild.
4063         * libmcheck.m4: Remove.
4064         * acinclude.m4: Don't include it.
4065         * Makefile.in: Don't distribute it.
4066         * top.c (print_gdb_configuration): Don't mention it.
4067
4068 2019-08-06  Tom Tromey  <tom@tromey.com>
4069
4070         * utils.c (set_output_style): Sometimes pass stream to
4071         emit_style_escape.
4072         * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
4073         * record-btrace.c (btrace_insn_history): Update.
4074         * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
4075         method.
4076         * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
4077         Update initializers.
4078         <m_uiout>: New field.
4079         <m_di>: Move lower.
4080         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
4081         Remove "uiout" parameter.
4082         (dump_insns): Update.
4083         * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
4084         * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
4085
4086 2019-08-06  Christian Biesinger  <cbiesinger@google.com>
4087
4088         * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
4089         (error_in_psymtab_expansion): Likewise.
4090         (lookup_symbol_via_quick_fns): Likewise.
4091         (basic_lookup_transparent_type_quick): Likewise.
4092         (basic_lookup_transparent_type_1): Likewise.
4093
4094 2019-08-06  Tom Tromey  <tromey@adacore.com>
4095
4096         * source.c (last_source_error): Now bool.
4097         (print_source_lines_base): Make "noprint" bool.  Only open
4098         source file when last_source_visited changes.
4099
4100 2019-08-06  Tom Tromey  <tromey@adacore.com>
4101
4102         * annotate.c (annotate_source_line): Use g_source_cache.
4103         * source-cache.c (source_cache::get_plain_source_lines): Change
4104         parameters.  Populate m_offset_cache.
4105         (source_cache::ensure): New method.
4106         (source_cache::get_line_charpos): New method.
4107         (extract_lines): Move lower.  Change parameters.
4108         (source_cache::get_source_lines): Move lower.
4109         * source-cache.h (class source_cache): Update comment.
4110         <get_line_charpos>: New method.
4111         <get_source_lines>: Update comment.
4112         <clear>: Clear m_offset_cache.
4113         <get_plain_source_lines>: Change parameters.
4114         <ensure>: New method
4115         <m_offset_cache>: New member.
4116         * source.c (forget_cached_source_info_for_objfile): Update.
4117         (info_source_command): Use g_source_cache.
4118         (find_source_lines, open_source_file_with_line_charpos): Remove.
4119         (print_source_lines_base, search_command_helper): Use g_source_cache.
4120         * source.h (open_source_file_with_line_charpos): Don't declare.
4121         * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
4122         * tui/tui-source.c (tui_source_window::do_scroll_vertical):
4123         Use g_source_cache.
4124
4125 2019-08-06  Tom Tromey  <tromey@adacore.com>
4126
4127         * source-cache.c (source_cache::get_plain_source_lines):
4128         Remove "first_line" and "last_line" parameters.
4129         (source_cache::get_source_lines): Cache plain text.
4130         * source-cache.h (class source_cache)
4131         <get_plain_source_lines>: Update.
4132
4133 2019-08-06  Tom Tromey  <tromey@adacore.com>
4134
4135         * source-cache.c (extract_lines): No longer a method.
4136         Changed type of parameter.  Include final newline.
4137         (selftests::extract_lines_test): New function.
4138         (_initialize_source_cache): Likewise.
4139         * source-cache.h (class source_cache)
4140         <extract_lines>: Don't declare.
4141
4142 2019-08-06  Tom Tromey  <tromey@adacore.com>
4143
4144         * breakpoint.c (init_breakpoint_sal): Update.
4145         (breakpoint): Update.
4146         * breakpoint.h (struct breakpoint) <filter>: Now a
4147         unique_xmalloc_ptr.
4148
4149 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
4150
4151         * NEWS: Mention dictionary access on blocks.
4152         * python/py-block.c (blpy_getitem): New function.
4153         (block_object_as_mapping): New struct.
4154         (block_object_type): Use new struct for tp_as_mapping field.
4155
4156 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
4157
4158         * objfiles.h (objfile): Add a comment describing partial symbols.
4159
4160 2019-08-05  Tom Tromey  <tromey@adacore.com>
4161
4162         * compile/compile.c (_initialize_compile): Use _(), not N_().
4163         * thread.c (_initialize_thread): Use _(), not N_().
4164         * stack.c (_initialize_stack): Use _(), not N_().
4165         * printcmd.c (_initialize_printcmd): Use _(), not N_().
4166
4167 2019-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
4168
4169         * dwarf2read.c (struct dw2_symtab_iterator):
4170         <want_specific_block>: Remove.
4171         <block_index>: Change type to gdb::optional.
4172         (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
4173         change type of BLOCK_INDEX parameter to gdb::optional.
4174         (dw2_symtab_iter_next): Re-write in function of gdb::optional.
4175         (dw2_lookup_symbol): Don't pass argument for
4176         WANT_SPECIFIC_BLOCK.
4177         (dw2_expand_symtabs_for_function): Don't pass argument for
4178         WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
4179         (class dw2_debug_names_iterator)
4180         <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
4181         parameter, change BLOCK_INDEX type to gdb::optional.
4182         <m_want_specific_block>: Remove.
4183         <m_block_index>: Change type to gdb::optional.
4184         (dw2_debug_names_iterator::next): Change type of IS_STATIC to
4185         gdb::optional.  Re-write in function of gdb::optional.
4186         (dw2_debug_names_lookup_symbol): Don't pass argument for
4187         WANT_SPECIFIC_BLOCK.
4188         (dw2_debug_names_expand_symtabs_for_function): Don't pass
4189         argument for WANT_SPECIFIC_BLOCK, pass empty optional for
4190         BLOCK_INDEX.
4191
4192 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4193
4194         * NEWS: Mention changes to "info sources" command.
4195
4196 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4197
4198         * symtab.c (filename_partial_match_opts): New struct type.
4199         (struct output_source_filename_data): New members
4200         regexp, c_regexp, partial_match.
4201         (output_source_filename): Use new members to decide to print file.
4202         (info_sources_option_defs): New variable.
4203         (make_info_sources_options_def_group, print_info_sources_header,
4204         info_sources_command_completer):
4205         New functions.
4206         (info_sources_command): Read new optional arguments.
4207         (_initialize_symtab): Update info sources help.
4208
4209 2019-08-02  Alexandre Oliva <oliva@adacore.com>
4210
4211         * ada-lang.c (exception_support_info_v0): Renamed from...
4212         (default_exception_support_info): ... this.  Create new
4213         definition for v1.
4214         (ada_has_this_exception_support): Look up catch_handlers_sym.
4215         (ada_exception_support_info_sniffer): Try v0 after default.
4216
4217 2019-08-01  Tom Tromey  <tromey@adacore.com>
4218
4219         * ia64-libunwind-tdep.h (struct libunwind_descr): Include
4220         gdbarch.h.
4221
4222 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
4223
4224         * s12z-tdep.c: Fix include path for s12z-opc.h.
4225
4226 2019-08-01  Alan Hayward  <alan.hayward@arm.com>
4227
4228         * NEWS: Require GNU make 3.82.
4229
4230 2019-07-16  Tom Tromey  <tom@tromey.com>
4231
4232         * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
4233         declare.
4234
4235 2019-07-30  Tom Tromey  <tromey@adacore.com>
4236
4237         * block.c (contained_in): Remove BLOCK_FUNCTION check.
4238
4239 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
4240
4241         * printcmd.c (print_address_symbolic): Print negative offsets.
4242         (build_address_symbolic): Force signed arithmetic when computing
4243         offset.
4244
4245 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
4246
4247         PR/24474: Add a function to lookup static variables.
4248         * NEWS: Mention this new function.
4249         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
4250         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
4251         * python/python.c (python_GdbMethods): Add new function.
4252
4253 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
4254
4255         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
4256         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
4257         (objfpy_lookup_static_symbol): New function.
4258         (objfile_object_methods): Add new functions.
4259
4260 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4261
4262         * NEWS: Mention 'set|show print frame-info'.  Mention new
4263         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
4264         backtrace argument.  Mention that python frame filtering code
4265         is now consistent with what 'backtrace' command prints.
4266
4267 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4268
4269         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
4270         comments.
4271         (print_frame_info_auto, print_frame_info_source_line,
4272         print_frame_info_location, print_frame_info_source_and_location,
4273         print_frame_info_location_and_address, print_frame_info_short_location):
4274         New declarations.
4275         (struct frame_print_options): New member print_frame_info.
4276         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
4277         * stack.h (get_user_print_what_frame_info): New declaration.
4278         (frame_show_address): New declaration.
4279         * stack.c (print_frame_arguments_choices): New value 'presence'.
4280         (print_frame_info_auto, print_frame_info_source_line,
4281         print_frame_info_location, print_frame_info_source_and_location,
4282         print_frame_info_location_and_address, print_frame_info_short_location,
4283         print_frame_info_choices, print_frame_info_print_what): New definitions.
4284         (print_frame_args): Only print dots for args if print frame-arguments
4285         is 'presence'.
4286         (frame_print_option_defs): New element for "frame-info".
4287         (get_user_print_what_frame_info): New function.
4288         (frame_show_address): Make non static.  Move comment to stack.h.
4289         (print_frame_info_to_print_what): New function.
4290         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
4291         to decide what to print.
4292         (backtrace_command_1): Handle the new print_frame_arguments_presence
4293         value.
4294         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
4295         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
4296         (py_print_frame): In non-mi mode, use LOCATION as default for
4297         print_what, similarly to frame information printed directly by
4298         backtrace command. Handle frame-info user option in non MI mode.
4299
4300 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
4301
4302         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
4303         Add case for debugging 32-bit target on 64-bit host.  Revise
4304         comment.
4305
4306 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
4307
4308         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
4309         instead of find_function_entry_range_from_pc.
4310
4311 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
4312
4313         * stack.c (find_frame_funname): Remove code which preferred
4314         minsym over symtab sym in "certain pathological cases".
4315
4316         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
4317         parameter.  Change type of "do_demangle" to bool.
4318         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
4319         Pass suitable "prefer_sym_over_minsym" flag to
4320         build_address_symbolic().  Don't output "+" for negative offsets.
4321         * printcmd.c (print_address_symbolic): Update invocation of
4322         build_address_symbolic to include a "prefer_sym_over_minsym"
4323         flag.
4324         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
4325         Restrict cases in which use of minimal symbol is preferred to that
4326         of a found symbol.  Update comments.
4327
4328         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
4329         for entry pc when entry pc is out of range for that FDE.
4330
4331 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
4332
4333         PR gdb/24839:
4334         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
4335         type.
4336
4337 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
4338
4339         * python/py-objfile.c (add_separate_debug_file): Fix comment about
4340         this function's Python signature.
4341
4342
4343 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
4344
4345         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
4346         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
4347         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
4348         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
4349         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
4350
4351
4352 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
4353
4354         * h8300-tdep.c (h8300_register_name_common): New.
4355         h8300_register_name): Use h8300_register_name_common.
4356         (h8300s_register_name): Likewise.
4357         (h8300sx_register_name): Likewise.
4358         (h8300h_register_nam): New.
4359         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
4360
4361
4362 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
4363
4364         * arm-tdep.c (arm_skip_cmse_entry): New function.
4365         (arm_is_sgstubs_section): New function.
4366         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
4367
4368 2019-07-22  Tom Tromey  <tom@tromey.com>
4369
4370         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
4371         Don't self-assign.
4372
4373 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
4374
4375         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
4376         type_print.
4377
4378 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
4379
4380         * symtab.c (search_symbols): Adjust msymbol matching type arrays
4381         so that GDB doesn't match any msymbols when searching in the
4382         TYPES_DOMAIN.
4383         (print_symbol_info): Print using typedef_print or type_print based
4384         on the type of the symbol.  Add updated FIXME comment moved from...
4385         (_initialize_symtab): ... move and update FIXME comment to above.
4386
4387 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
4388
4389         * NEWS: Mention adding -q option to "info types".
4390         * symtab.c (struct info_types_options): New struct.
4391         (info_types_options_defs): New variable.
4392         (make_info_types_options_def_group): New function.
4393         (info_types_command): Use gdb::option framework to parse options.
4394         (info_types_command_completer): New function.
4395         (_initialize_symtab): Extend the help text on "info types" and
4396         register command completer.
4397
4398 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
4399
4400         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
4401         (lookup_symbol_in_objfile): Change int to block_enum and add a
4402         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
4403
4404 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
4405
4406         * MAINTAINERS (Write After Approval): Add self.
4407
4408 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
4409
4410         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
4411         instruction to the dummy code region.
4412
4413 2019-07-19  Tom Tromey  <tromey@adacore.com>
4414
4415         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
4416         (ARGSUSED, PARAMS, __func__): Remove rules.
4417
4418 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
4419
4420         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
4421         * features/arm/arm-with-iwmmxt.c: Remove.
4422         * features/arm/arm-with-iwmmxt.xml: Remove.
4423         * features/arm/arm-with-m-fpa-layout.c: Remove.
4424         * features/arm/arm-with-m-fpa-layout.xml: Remove.
4425         * features/arm/arm-with-m-vfp-d16.c: Remove.
4426         * features/arm/arm-with-m-vfp-d16.xml: Remove.
4427         * features/arm/arm-with-m.c: Remove.
4428         * features/arm/arm-with-m.xml: Remove.
4429         * features/arm/arm-with-neon.c: Remove.
4430         * features/arm/arm-with-neon.xml: Remove.
4431         * features/arm/arm-with-vfpv2.c: Remove.
4432         * features/arm/arm-with-vfpv2.xml: Remove.
4433         * features/arm/arm-with-vfpv3.c: Remove.
4434         * features/arm/arm-with-vfpv3.xml: Remove.
4435
4436 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
4437
4438         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
4439
4440 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
4441
4442         * arch/aarch32.c (aarch32_create_target_description): Create
4443         target descriptions using features.
4444         * arch/arm.c (arm_create_target_description)
4445         (arm_create_mprofile_target_description): Likewise.
4446         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
4447
4448 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
4449
4450         * Makefile.in: Add new files.
4451         * aarch32-tdep.c: New file.
4452         * aarch32-tdep.h: New file.
4453         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
4454         Call aarch32_read_description.
4455         * arch/aarch32.c: New file.
4456         * arch/aarch32.h: New file.
4457         * arch/arm.c (arm_create_target_description)
4458         (arm_create_mprofile_target_description): New function.
4459         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
4460         (arm_create_target_description)
4461         (arm_create_mprofile_target_description): New declaration.
4462         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
4463         read_description functions.
4464         * arm-linux-nat.c (arm_linux_nat_target::read_description):
4465         Likewise.
4466         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
4467         * arm-tdep.c (tdesc_arm_list): New variable.
4468         (arm_register_g_packet_guesses): Call create description functions.
4469         (arm_read_description) (arm_read_mprofile_description): New
4470         function.
4471         * arm-tdep.h (arm_read_description)
4472         (arm_read_mprofile_description): Add declaration.
4473         * configure.tgt: Add new files.
4474
4475 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
4476
4477         * top.c (new_ui_command): Open specified terminal just once.
4478
4479 2019-07-18  Tom Tromey  <tromey@adacore.com>
4480
4481         * symtab.c (main_name): Constify return type.
4482         * symfile.c (set_initial_language): Update.
4483         * symtab.h (main_name): Constify return type.
4484
4485 2019-07-17  Tom Tromey  <tom@tromey.com>
4486
4487         * tui/tui-winsource.c (tui_update_source_window)
4488         (tui_update_source_window_as_is)
4489         (tui_update_source_windows_with_line): Remove return.
4490         * tui/tui-disasm.c (tui_show_disassem)
4491         (tui_show_disassem_and_update_source): Remove return.
4492         * tui/tui.c (tui_reset): Remove return.
4493         * tui/tui-wingeneral.c
4494         (tui_check_and_display_highlight_if_needed): Remove return.
4495
4496 2019-07-17  Tom Tromey  <tom@tromey.com>
4497
4498         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
4499
4500 2019-07-17  Tom Tromey  <tom@tromey.com>
4501
4502         * tui/tui-winsource.h (struct tui_exec_info_window)
4503         (struct tui_source_window_base): Move from tui-data.h.
4504         * tui/tui-winsource.c: Move many method definitions from
4505         elsewhere.  Remove "structuring" comments.
4506         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
4507         (tui_source_window_base::refresh_window): Move to
4508         tui-winsource.c.
4509         * tui/tui-win.c (tui_source_window_base::refresh_all)
4510         (tui_source_window_base::update_tab_width)
4511         (tui_source_window_base::set_new_height)
4512         (tui_source_window_base::do_make_visible_with_new_height): Move to
4513         tui-winsource.c.
4514         * tui/tui-source.h: Update.
4515         * tui/tui-source.c (tui_source_window_base::reset): Move to
4516         tui-winsource.c.
4517         * tui/tui-disasm.h: Update.
4518         * tui/tui-data.h (struct tui_exec_info_window): Move to
4519         tui-winsource.h.
4520         (struct tui_source_window_base): Likewise.
4521         * tui/tui-data.c (tui_source_window_base::clear_detail)
4522         (tui_source_window_base, ~tui_source_window_base): Move to
4523         tui-winsource.c.
4524
4525 2019-07-17  Tom Tromey  <tom@tromey.com>
4526
4527         * tui/tui-win.c (tui_resize_all)
4528         (tui_source_window_base::update_tab_width)
4529         (tui_adjust_win_heights): Update.
4530         (tui_win_info::make_invisible_and_set_new_height): Rename from
4531         make_invisible_and_set_new_height.
4532         * tui/tui-data.h (struct tui_win_info)
4533         <make_invisible_and_set_new_height>: New method.
4534
4535 2019-07-17  Tom Tromey  <tom@tromey.com>
4536
4537         * tui/tui.c: Update.
4538         * tui/tui-source.h (struct tui_source_window): Move from
4539         tui-data.h.
4540         * tui/tui-layout.c: Update.
4541         * tui/tui-disasm.c: Update.
4542         * tui/tui-data.h (struct tui_source_window): Move to
4543         tui-source.h.
4544
4545 2019-07-17  Tom Tromey  <tom@tromey.com>
4546
4547         * tui/tui-disasm.h (struct tui_disasm_window): Move from
4548         tui-data.h.
4549         * tui/tui-data.h (struct tui_disasm_window): Move to
4550         tui-disasm.h.
4551
4552 2019-07-17  Tom Tromey  <tom@tromey.com>
4553
4554         * tui/tui-regs.h (struct tui_data_item_window): Move from
4555         tui-data.h.
4556         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
4557         * tui/tui-data.h (struct tui_data_item_window): Move to
4558         tui-regs.h.
4559         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
4560
4561 2019-07-17  Tom Tromey  <tom@tromey.com>
4562
4563         * tui/tui.c: Update.
4564         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
4565         (tui_cmd_window::max_height): Move to tui-command.c.
4566         * tui/tui-layout.c: Update.
4567         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
4568         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
4569         tui-command.c.
4570         * tui/tui-command.h (struct tui_cmd_window): Move from
4571         tui-data.h.
4572         * tui/tui-command.c: Remove "structuring" comments.
4573         (tui_cmd_window::clear_detail)
4574         (tui_cmd_window::do_make_visible_with_new_height)
4575         (tui_cmd_window::max_height): Move from elsewhere.
4576
4577 2019-07-17  Tom Tromey  <tom@tromey.com>
4578
4579         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
4580         Now static.
4581         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
4582         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
4583
4584 2019-07-17  Tom Tromey  <tom@tromey.com>
4585
4586         * tui/tui.c: Update.
4587         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
4588         tui-regs.c.
4589         * tui/tui-windata.h: Remove file.
4590         * tui/tui-windata.c: Remove file.
4591         * tui/tui-win.c (tui_data_window::set_new_height)
4592         (tui_data_window::do_make_visible_with_new_height): Move to
4593         tui-regs.c.
4594         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
4595         * tui/tui-regs.c: Remove "structuring" comments.
4596         (tui_data_window::first_data_item_displayed)
4597         (tui_data_window::delete_data_content_windows)
4598         (tui_data_window::erase_data_content)
4599         (tui_data_window::display_all_data)
4600         (tui_data_window::refresh_all)
4601         (tui_data_window::do_scroll_vertical)
4602         (tui_data_window::clear_detail, tui_data_window::set_new_height)
4603         (tui_data_window::do_make_visible_with_new_height)
4604         (tui_data_window::refresh_window): Move from elsewhere.
4605         (_initialize_tui_regs): Move to end of file.
4606         * tui/tui-layout.c: Update.
4607         * tui/tui-hooks.c: Update.
4608         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
4609         * tui/tui-data.c (tui_data_window::clear_detail): Move to
4610         tui-regs.c.
4611         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
4612
4613 2019-07-17  Tom Tromey  <tom@tromey.com>
4614
4615         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
4616         seen.
4617
4618 2019-07-17  Tom Tromey  <tom@tromey.com>
4619
4620         * tui/tui-win.c (tui_source_window_base::set_new_height)
4621         (tui_source_window_base::do_make_visible_with_new_height): Use
4622         m_has_locator field directly.
4623         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
4624         method.
4625         (struct tui_source_window_base) <has_locator>: Likewise.
4626
4627 2019-07-17  Tom Tromey  <tom@tromey.com>
4628
4629         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
4630         Don't declare.
4631         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
4632         Remove.
4633         * tui/tui-win.c (tui_source_window_base::set_new_height)
4634         (tui_source_window_base::set_new_height)
4635         (make_invisible_and_set_new_height)
4636         (tui_source_window_base::do_make_visible_with_new_height)
4637         (tui_source_window_base::do_make_visible_with_new_height):
4638         Update.
4639         * tui/tui-layout.c (show_source_disasm_command, show_data)
4640         (show_source_or_disasm_and_command): Update.
4641         * tui/tui-layout.c (show_layout): Update.
4642
4643 2019-07-17  Tom Tromey  <tom@tromey.com>
4644
4645         * tui/tui-layout.c (make_data_window): Remove.
4646         (show_data): Unify creation and re-initialization cases.
4647
4648 2019-07-17  Tom Tromey  <tom@tromey.com>
4649
4650         * tui/tui-layout.c (make_source_window, make_disasm_window):
4651         Remove.
4652         (show_data): Unify creation and re-initialization cases.
4653
4654 2019-07-17  Tom Tromey  <tom@tromey.com>
4655
4656         * tui/tui-layout.c (make_command_window): Remove.
4657         (show_source_disasm_command, show_source_or_disasm_and_command):
4658         Unify creation and re-initialization cases.
4659
4660 2019-07-17  Tom Tromey  <tom@tromey.com>
4661
4662         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
4663         creation and re-initialization cases.
4664
4665 2019-07-17  Tom Tromey  <tom@tromey.com>
4666
4667         * tui/tui-regs.c (tui_get_register): Return void.
4668
4669 2019-07-17  Tom Tromey  <tom@tromey.com>
4670
4671         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
4672         Simplify.
4673
4674 2019-07-17  Tom Tromey  <tom@tromey.com>
4675
4676         * tui/tui-layout.c (show_source_disasm_command): Simplify window
4677         resetting.
4678
4679 2019-07-17  Tom Tromey  <tom@tromey.com>
4680
4681         * tui/tui.h (tui_set_layout_by_name): Don't declare.
4682         * tui/tui-regs.c (tui_reg_layout): New function.
4683         (tui_show_registers, tui_reg_command): Use it.
4684         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
4685         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
4686         parameters.
4687         (tui_layout_command): Remove.
4688
4689 2019-07-17  Tom Tromey  <tom@tromey.com>
4690
4691         * tui/tui-layout.h (tui/tui-layout): Return void.
4692         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
4693
4694 2019-07-17  Tom Tromey  <tom@tromey.com>
4695
4696         * tui/tui-layout.c (show_source_disasm_command, show_data):
4697         Update.
4698         (reset_locator): Remove.
4699         (show_source_or_disasm_and_command): Update.
4700
4701 2019-07-17  Tom Tromey  <tom@tromey.com>
4702
4703         * tui/tui-source.c (tui_source_window_base::reset): Remove
4704         win_type parameter.
4705         * tui/tui-layout.c (make_command_window, make_source_window)
4706         (make_disasm_window, make_data_window)
4707         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
4708         (reset_locator, show_source_or_disasm_and_command): Update.
4709         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
4710         win_type parameter.
4711         (struct tui_source_window_base) <reset>: Likewise.
4712
4713 2019-07-17  Tom Tromey  <tom@tromey.com>
4714
4715         * tui/tui-layout.c (show_source_disasm_command): Use
4716         reset_locator.
4717         (reset_locator): New function.
4718         (init_and_make_win): Remove.
4719         (show_source_or_disasm_and_command): Use reset_locator.
4720
4721 2019-07-17  Tom Tromey  <tom@tromey.com>
4722
4723         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
4724         condition.
4725         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
4726         Remove condition.
4727         * tui/tui-source.c (tui_source_window_base::reset): New method.
4728         * tui/tui-layout.c (make_command_window): Don't call
4729         init_and_make_win.
4730         (make_source_window, make_disasm_window): Don't call
4731         make_source_or_disasm_window.
4732         (make_data_window): Don't call init_and_make_win.  Change calling
4733         convention.
4734         (show_source_disasm_command, show_data): Simplify.
4735         (make_source_or_disasm_window): Remove.
4736         (show_source_or_disasm_and_command): Simplify.
4737         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
4738         (struct tui_source_window_base) <reset>: Likewise.
4739         <execution_info>: Remove initializer.
4740         * tui/tui-data.c (tui_source_window_base): Initialize
4741         execution_info.
4742
4743 2019-07-17  Tom Tromey  <tom@tromey.com>
4744
4745         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
4746         variable.
4747
4748 2019-07-17  Tom Tromey  <tom@tromey.com>
4749
4750         * tui/tui.c (tui_rl_other_window): Update.
4751         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
4752         superclass method first.  Always iterate over regs_content.
4753         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
4754         method.
4755         * tui/tui-win.c (tui_set_focus_command): Update.
4756
4757 2019-07-17  Tom Tromey  <tom@tromey.com>
4758
4759         * tui/tui-win.c (tui_set_focus_command): Rename from
4760         tui_set_focus.  Call tui_enable.
4761         (tui_set_focus_command): Remove.
4762
4763 2019-07-17  Tom Tromey  <tom@tromey.com>
4764
4765         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
4766         refresh_window.
4767         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
4768         touchwin.
4769         (tui_data_window::refresh_window): Call refresh_window on data
4770         items.  Always call superclass refresh_window.
4771         (tui_win_info::refresh): Remove.
4772         (tui_source_window_base::refresh_window): Update.
4773         (tui_refresh_all): Update.
4774         * tui/tui-layout.c (show_source_disasm_command): Remove call to
4775         refresh_window.
4776         (show_source_or_disasm_and_command): Likewise.
4777         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
4778         (struct tui_source_window_base) <refresh>: Likewise.
4779
4780 2019-07-17  Tom Tromey  <tom@tromey.com>
4781
4782         * tui/tui-winsource.c (tui_clear_source_content)
4783         (tui_show_source_content): Update.
4784         * tui/tui-source.c (tui_source_window::showing_source_p): Check
4785         whether content is empty.
4786         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
4787         Remove.
4788
4789 2019-07-17  Tom Tromey  <tom@tromey.com>
4790
4791         * tui/tui-winsource.c (tui_erase_source_content): Clear the
4792         window's contents.
4793         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
4794         * tui/tui-source.c (tui_set_source_content_nil): Remove.
4795
4796 2019-07-17  Tom Tromey  <tom@tromey.com>
4797
4798         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
4799         (struct tui_data_item_window): Update.
4800
4801 2019-07-17  Tom Tromey  <tom@tromey.com>
4802
4803         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
4804         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
4805         defines.
4806
4807 2019-07-17  Tom Tromey  <tom@tromey.com>
4808
4809         * tui/tui-winsource.h (tui_erase_source_content)
4810         (tui_clear_source_content): Remove "display_prompt" parameter.
4811         * tui/tui-winsource.c (tui_update_source_window_as_is)
4812         (tui_update_source_windows_with_addr): Update.
4813         (tui_clear_source_content): Remove "display_prompt" parameter.
4814         (tui_erase_source_content): Likewise.  Simplify.
4815         (tui_show_source_content): Update.
4816         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
4817         * tui/tui-stack.c (tui_show_frame_info): Update.
4818         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
4819         Remove defines.
4820
4821 2019-07-17  Tom Tromey  <tom@tromey.com>
4822
4823         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
4824         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
4825         parameter.
4826         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
4827         parameter.
4828
4829 2019-07-17  Tom Tromey  <tom@tromey.com>
4830
4831         * tui/tui-winsource.c (tui_clear_source_content)
4832         (tui_show_source_content, tui_show_exec_info_content)
4833         (tui_clear_exec_info_content): Update.
4834         * tui/tui-stack.c (tui_show_locator_content): Update.
4835         (tui_show_frame_info): Update.
4836         * tui/tui-source.h (tui_source_window): Don't declare.
4837         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
4838         from tui_source_is_displayed.
4839         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
4840         Remove field.
4841         (struct tui_source_window_base) <content_in_use>: New field.  Now
4842         bool.
4843         (struct tui_source_window) <showing_source_p>: New method.
4844         (TUI_SRC_WIN): Change cast.
4845         * tui/tui-data.c (tui_initialize_static_data): Update.
4846
4847 2019-07-17  Tom Tromey  <tom@tromey.com>
4848
4849         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
4850         location_matches_p.
4851         * tui/tui-source.c (tui_source_window::location_matches_p): New
4852         method.
4853         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
4854         method.
4855         * tui/tui-data.h (struct tui_source_window_base)
4856         <location_matches_p>: New method.
4857         (struct tui_source_window, struct tui_disasm_window)
4858         <location_matches_p>: Likewise.
4859
4860 2019-07-17  Tom Tromey  <tom@tromey.com>
4861
4862         * tui/tui-win.c (tui_set_win_height_command): Rename from
4863         tui_set_win_height.
4864         (tui_set_win_height_command): Remove.
4865
4866 2019-07-17  Tom Tromey  <tom@tromey.com>
4867
4868         * tui/tui-source.c (tui_source_window): New constructor.  Add
4869         observer.
4870         (~tui_source_window): New destructor.
4871         (tui_source_window::style_changed): New method.
4872         * tui/tui-hooks.c (tui_redisplay_source): Remove.
4873         (tui_attach_detach_observers): Update.
4874         * tui/tui-data.h (struct tui_source_window): Make constructor not
4875         inline.  Add destructor.
4876         (struct tui_source_window) <style_changed>: New method.
4877         <m_observable>: New member.
4878
4879 2019-07-17  Tom Tromey  <tom@tromey.com>
4880
4881         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
4882         * tui/tui-win.c (tui_resize_all): Fix typo.
4883
4884 2019-07-17  Tom Tromey  <tom@tromey.com>
4885
4886         * tui/tui-wingeneral.h (tui_refresh_all): Update.
4887         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
4888         (tui_refresh_all): Remove "list" parameter.  Use foreach.
4889         * tui/tui-win.c (window_name_completer): Use foreach.
4890         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
4891         (update_tab_width): Likewise.
4892         * tui/tui-layout.c (show_layout): Update.
4893         * tui/tui-data.h (class tui_window_iterator): New.
4894         (struct all_tui_windows): New.
4895         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
4896
4897 2019-07-17  Tom Tromey  <tom@tromey.com>
4898
4899         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
4900         parameter.  Don't reference globals.
4901         (tui_reg_command): Update.
4902
4903 2019-07-17  Tom Tromey  <tom@tromey.com>
4904
4905         * tui/tui-regs.c (tui_show_registers): Simplify.
4906
4907 2019-07-17  Tom Tromey  <tom@tromey.com>
4908
4909         * tui/tui-regs.c (tui_show_registers): Update.
4910         (tui_show_register_group): Add win_info parameter.
4911
4912 2019-07-17  Tom Tromey  <tom@tromey.com>
4913
4914         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
4915         Rename from tui_display_reg_element_at_line.
4916         (tui_data_window::display_registers_from_line): Update.
4917         * tui/tui-data.h (struct tui_data_window)
4918         <display_reg_element_at_line>: New method.
4919
4920 2019-07-17  Tom Tromey  <tom@tromey.com>
4921
4922         * tui/tui-regs.h (tui_display_registers_from)
4923         (tui_display_registers_from_line): Don't declare.
4924         * tui/tui-windata.c (tui_data_window::display_all_data)
4925         (tui_data_window::refresh_all)
4926         (tui_data_window::do_scroll_vertical): Update.
4927         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
4928         from tui_display_registers_from.
4929         (tui_display_reg_element_at_line): Update.
4930         (tui_data_window::display_registers_from_line): Rename from
4931         tui_display_registers_from_line.
4932         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
4933         display_registers_from_line>: New methods.
4934
4935 2019-07-17  Tom Tromey  <tom@tromey.com>
4936
4937         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
4938         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
4939         from tui_erase_data_content.
4940         (tui_data_window::display_all_data)
4941         (tui_data_window::refresh_all)
4942         (tui_data_window::do_scroll_vertical): Update.
4943         * tui/tui-regs.c (tui_show_registers): Update.
4944         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
4945         New method.
4946
4947 2019-07-17  Tom Tromey  <tom@tromey.com>
4948
4949         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
4950         declare.
4951         * tui/tui-windata.c
4952         (tui_data_window::delete_data_content_windows): Rename from
4953         tui_delete_data_content_windows.
4954         (tui_data_window::display_all_data)
4955         (tui_data_window::do_scroll_vertical): Update.
4956         * tui/tui-data.h (struct tui_data_window)
4957         <delete_data_content_windows>: New method.
4958
4959 2019-07-17  Tom Tromey  <tom@tromey.com>
4960
4961         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
4962         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
4963
4964 2019-07-17  Tom Tromey  <tom@tromey.com>
4965
4966         * tui/tui-windata.h (tui_display_all_data): Don't declare.
4967         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
4968         from tui_display_all_data.
4969         * tui/tui-win.c
4970         (tui_data_window::do_make_visible_with_new_height): Update.
4971         * tui/tui-regs.c (tui_show_registers): Update.
4972         * tui/tui-layout.c (tui_set_layout): Update.
4973         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
4974         method.
4975
4976 2019-07-17  Tom Tromey  <tom@tromey.com>
4977
4978         * tui/tui-windata.h (tui_display_data_from): Don't declare.
4979         * tui/tui-windata.c (tui_display_data_from): Remove.
4980         (tui_data_window::refresh_all): Update.
4981
4982 2019-07-17  Tom Tromey  <tom@tromey.com>
4983
4984         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
4985         * tui/tui-windata.c (tui_display_data_from_line): Remove.
4986         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
4987         tui_display_registers_from_line.
4988         * tui/tui-regs.h (tui_display_registers_from_line): Update.
4989         * tui/tui-regs.c (tui_display_registers_from_line): Remove
4990         "force_display" parameter.
4991
4992 2019-07-17  Tom Tromey  <tom@tromey.com>
4993
4994         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
4995         declare.
4996         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
4997         Rename from tui_first_reg_element_no_inline.
4998         (tui_display_reg_element_at_line)
4999         (tui_display_registers_from_line): Update.
5000         * tui/tui-data.h (struct tui_data_window)
5001         <first_reg_element_no_inline>: New method.
5002
5003 2019-07-17  Tom Tromey  <tom@tromey.com>
5004
5005         * tui/tui-windata.c (tui_display_data_from)
5006         (tui_data_window::do_scroll_vertical): Update.
5007         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
5008         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
5009         Rename from tui_line_from_reg_element_no.
5010         (tui_display_registers_from_line): Update.
5011         * tui/tui-data.h (struct tui_data_window)
5012         <line_from_reg_element_no>: New method.
5013
5014 2019-07-17  Tom Tromey  <tom@tromey.com>
5015
5016         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
5017         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
5018         tui_last_regs_line_no.
5019         (tui_display_reg_element_at_line)
5020         (tui_display_registers_from_line): Update.
5021         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
5022         method.
5023
5024 2019-07-17  Tom Tromey  <tom@tromey.com>
5025
5026         PR tui/24722:
5027         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
5028         (tui_update_breakpoint_info): Add "being_deleted" parameter.
5029         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
5030         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
5031         (tui_update_breakpoint_info): Likewise.
5032         * tui/tui-hooks.c (tui_event_create_breakpoint)
5033         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
5034         Update.
5035
5036 2019-07-17  Tom Tromey  <tom@tromey.com>
5037
5038         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
5039
5040 2019-07-17  Tom Tromey  <tom@tromey.com>
5041
5042         * tui/tui-winsource.c (tui_update_source_window_as_is)
5043         (tui_update_source_windows_with_addr): Update.
5044         * tui/tui-source.h (tui_set_source_content)
5045         (tui_show_symtab_source): Add "win_info" parameter.
5046         * tui/tui-source.c (tui_set_source_content): Add "win_info"
5047         parameter.
5048         (tui_show_symtab_source): Likewise.
5049
5050 2019-07-17  Tom Tromey  <tom@tromey.com>
5051
5052         * tui/tui-wingeneral.c
5053         (tui_check_and_display_highlight_if_needed): Check can_highlight.
5054
5055 2019-07-17  Tom Tromey  <tom@tromey.com>
5056
5057         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
5058         (struct tui_cmd_window) <can_scroll>: New method.
5059         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
5060         method.
5061
5062 2019-07-17  Tom Tromey  <tromey@adacore.com>
5063
5064         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
5065         do_field_signed>: Rename.  Change type of "value".
5066         * ui-out.c (ui_out::field_signed): Rename from field_int.
5067         Change type of "value".
5068         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
5069         type of "value".
5070         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
5071         do_field_int.  Change type of "value".
5072         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
5073         do_field_int.  Change type of "value".
5074         * tracepoint.c (trace_status_mi, tfind_1)
5075         (print_one_static_tracepoint_marker): Update.
5076         * thread.c (print_thread_info_1, print_selected_thread_frame):
5077         Update.
5078         * stack.c (print_frame, print_frame_info): Update.
5079         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
5080         Update.
5081         * source.c (print_source_lines_base): Update.
5082         * skip.c (info_skip_command): Update.
5083         * record-btrace.c (btrace_ui_out_decode_error)
5084         (btrace_call_history_src_line): Update.
5085         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
5086         Update.
5087         * progspace.c (print_program_space): Update.
5088         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
5089         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
5090         do_field_int.  Change type of "value".
5091         * mi/mi-out.c (mi_ui_out::do_table_begin)
5092         (mi_ui_out::do_table_header): Update.
5093         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
5094         type of "value".
5095         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
5096         (mi_cmd_data_list_changed_registers, output_register)
5097         (mi_cmd_data_read_memory, mi_load_progress)
5098         (mi_cmd_trace_frame_collected): Update.
5099         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
5100         Update.
5101         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
5102         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
5103         (mi_cmd_var_list_children, varobj_update_one): Update.
5104         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
5105         (mi_cmd_stack_list_args, list_arg_or_local): Update.
5106         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
5107         * inferior.c (print_inferior): Update.
5108         * gdb_bfd.c (print_one_bfd): Update.
5109         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
5110         Update.
5111         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
5112         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
5113         do_field_int.  Change type of "value".
5114         * cli-out.c (cli_ui_out::do_field_signed): Rename from
5115         do_field_int.  Change type of "value".
5116         * breakpoint.c (watchpoint_check, print_breakpoint_location)
5117         (print_one_breakpoint_location, print_it_catch_fork)
5118         (print_one_catch_fork, print_it_catch_vfork)
5119         (print_one_catch_vfork, print_it_catch_solib)
5120         (print_it_catch_exec, print_it_ranged_breakpoint)
5121         (print_mention_watchpoint, print_mention_masked_watchpoint)
5122         (bkpt_print_it, update_static_tracepoint): Update.
5123         * break-catch-throw.c (print_it_exception_catchpoint): Update.
5124         * break-catch-syscall.c (print_it_catch_syscall): Update.
5125         * ada-tasks.c (print_ada_task_info): Update.
5126         * ada-lang.c (print_it_exception, print_mention_exception):
5127         Update.
5128
5129 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
5130
5131         PR breakpoints/24541
5132         * gdbarch.c: Regenerate.
5133         * gdbarch.h: Regenerate.
5134         * gdbarch.sh: Adjust return type and parameter types for
5135         'stap_adjust_register'.
5136         (i386_stap_adjust_register): Adjust signature and return new
5137         register name.
5138         * stap-probe.c (stap_parse_register_operand): Adjust use of
5139         'gdbarch_stap_adjust_register'.
5140
5141 2019-07-17  Tom Tromey  <tromey@adacore.com>
5142
5143         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
5144         declare VEC.
5145         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
5146         std::vector.
5147         (struct s390_process_info): Add initializers.
5148         (s390_add_process): Use new.
5149         (s390_linux_nat_target::low_forget_process): Use delete.
5150         (s390_linux_nat_target::low_new_fork)
5151         (s390_linux_nat_target::stopped_by_watchpoint)
5152         (s390_linux_nat_target::low_prepare_to_resume)
5153         (s390_linux_nat_target::insert_watchpoint)
5154         (s390_linux_nat_target::insert_hw_breakpoint)
5155         (s390_linux_nat_target::remove_watchpoint)
5156         (s390_linux_nat_target::remove_hw_breakpoint): Update.
5157
5158 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
5159
5160         * aarch64-fbsd-nat.c: Include regcache.h.
5161         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
5162         argument.
5163         (aarch64_fbsd_nat_target::fetch_registers)
5164         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
5165         variable.
5166         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
5167
5168 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
5169
5170         * fbsd-nat.c: Include gdbarch.h.
5171
5172 2019-07-15  Tom Tromey  <tromey@adacore.com>
5173
5174         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
5175
5176 2019-07-15  Tom Tromey  <tromey@adacore.com>
5177
5178         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
5179         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
5180         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
5181         * cli-out.c (cli_ui_out::do_field_int): New method.
5182         * ui-out.c (ui_out::field_unsigned): New method.
5183         * symfile.c (generic_load): Use field_unsigned.
5184         (print_transfer_performance): Likewise.
5185         * record-btrace.c (ui_out_field_uint): Remove.
5186         (btrace_call_history_insn_range, btrace_call_history): Use
5187         field_unsigned.
5188         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
5189         field_unsigned.
5190         * ui-out.h (class ui_out) <field_unsigned>: New method.
5191         <do_field_unsigned>: Likewise.
5192
5193 2019-07-15  Tom Tromey  <tromey@adacore.com>
5194
5195         * mi/mi-main.c (list_available_thread_groups): Use field_string.
5196         * mi/mi-interp.c (mi_memory_changed): Use field_string.
5197         * target.c (flash_erase_command): Use field_string.
5198         * infrun.c (print_signal_received_reason): Use field_string.
5199         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
5200         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
5201         field_string.
5202         * ada-tasks.c (print_ada_task_info): Use field_string.
5203
5204 2019-07-15  Tom Tromey  <tromey@adacore.com>
5205
5206         * target.c (flash_erase_command): Use field_core_addr.
5207         * symfile.c (generic_load): Use field_core_addr.
5208         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
5209         Use field_core_addr.
5210         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
5211         field_core_addr.
5212
5213 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
5214
5215         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
5216         value if its desired type is smaller than a CORE_ADDR and signed.
5217
5218 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
5219
5220         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
5221         of changes to field names, and use new is_reference field to
5222         decide if a property is a reference or not.
5223         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
5224         field.
5225         (struct dwarf2_property_baton): Update header comment, rename
5226         'referenced_type' to 'property_type' and update comments.
5227         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
5228         default property type, store in property baton, update to take
5229         accound of renamed field.
5230         (read_func_scope): Update call to attr_to_dynamic_prop.
5231         (read_array_type): Likewise.
5232         (dwarf2_per_cu_addr_sized_int_type): New function.
5233         (read_subrange_index_type): Move type finding code to
5234         dwarf2_per_cu_addr_sized_int_type.
5235         (read_subrange_type): Update calls to attr_to_dynamic_prop.
5236         (dwarf2_per_cu_addr_type): New function.
5237         (set_die_type): Update calls to attr_to_dynamic_prop.
5238
5239 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
5240
5241         * dwarf2read.c (read_subrange_index_type): New function.
5242         (read_subrange_type): Move code into new function and call it.
5243         * gdbtypes.c (create_range_type): Add some asserts.
5244
5245 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
5246
5247         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
5248         update return statements.
5249         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
5250         declaration, and update comment to match.
5251         * gdbtypes.c (resolve_dynamic_array): Update call to
5252         dwarf2_evaluate_property to match new return type.
5253
5254 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
5255
5256         * valarith.c (value_subscripted_rvalue): Change lowerbound
5257         parameter type from int to LONGEST.
5258         * value.h (value_subscripted_rvalue): Likewise in declaration.
5259
5260 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5261
5262         * cli/cli-utils.c (info_print_command_completer): New function.
5263         * cli/cli-utils.h: Add 'completer.h' include, and forward
5264         declaration for 'struct cmd_list_element'.
5265         (info_print_command_completer): Declare.
5266         * stack.c (_initialize_stack): Add completer for 'info locals' and
5267         'info args'.
5268         * symtab.c (_initialize_symtab): Add completer for 'info
5269         variables' and 'info functions'.
5270         * NEWS: Mention completion for additional info commands.
5271
5272 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5273
5274         * cli/cli-utils.c (extract_info_print_args): Delete.
5275         (extract_arg_maybe_quoted): Delete.
5276         (info_print_options_defs): New variable.
5277         (make_info_print_options_def_group): New function.
5278         (extract_info_print_options): Define new function.
5279         * cli/cli-utils.h (extract_info_print_args): Delete.
5280         (struct info_print_options): New structure.
5281         (extract_info_print_options): Declare new function.
5282         * stack.c (info_locals_command): Update to use new
5283         extract_info_print_options, also add a header comment.
5284         (info_args_command): Likewise.
5285         * symtab.c (info_variables_command): Likewise.
5286         (info_functions_command): Likewise.
5287
5288 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5289
5290         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
5291         to extract string arguments.
5292         * common/common-utils.c (extract_string_maybe_quoted): New function.
5293         * common/common-utils.h (extract_string_maybe_quoted): Declare.
5294
5295 2019-07-11  Tom Tromey  <tromey@adacore.com>
5296
5297         * main.c (get_init_files): Use GDBINIT, not gdbinit.
5298         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
5299         * top.h (gdbinit): Don't declare.
5300         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
5301         into...
5302         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
5303         * top.c (gdb_init): Don't call init_cli_cmds.
5304         (gdbinit): Remove.
5305         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
5306
5307 2019-07-11  Tom Tromey  <tromey@adacore.com>
5308
5309         * python/py-inferior.c (add_thread_object): Don't use thread_obj
5310         after it has been moved.
5311
5312 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
5313
5314         * valops.c (value_must_coerce_to_target): Change return type to
5315         bool.
5316         * value.h (value_must_coerce_to_target): Likewise.
5317
5318 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
5319
5320         * breakpoint.c (is_hardware_watchpoint): Remove
5321         forward-declaration.
5322         (is_masked_watchpoint): Change return type to bool.
5323         (is_tracepoint): Likewise.
5324         (is_breakpoint): Likewise.
5325         (is_hardware_watchpoint): Likewise.
5326         (is_watchpoint): Likewise.
5327         (is_no_memory_software_watchpoint): Likewise.
5328         (is_catchpoint): Likewise.
5329         (breakpoint_1): Make FILTER parameter's return type bool.
5330         is_masked_watchpoint): Change return type to bool.
5331         (save_breakpoints): Make FILTER parameter's return type bool.
5332         * breakpoint.h (is_breakpoint): Change return type to bool.
5333         (is_watchpoint): Likewise.
5334         (is_catchpoint): Likewise.
5335         (is_tracepoint): Likewise.
5336
5337 2019-07-10  Tom Tromey  <tom@tromey.com>
5338
5339         * defs.h: Don't include gdbarch.h.
5340         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
5341         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
5342         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
5343         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
5344         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
5345         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
5346         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
5347         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
5348         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
5349         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
5350         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
5351         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
5352         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
5353         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
5354         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
5355         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
5356         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
5357         record-btrace.c, record.h, regcache-dump.c, regcache.h,
5358         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
5359         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
5360         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
5361         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
5362         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
5363         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
5364         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
5365         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
5366         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
5367
5368 2019-07-10  Tom Tromey  <tromey@adacore.com>
5369
5370         * ada-lang.h (is_ada_exception_catchpoint): Declare.
5371         * breakpoint.c (init_ada_exception_breakpoint): Register as
5372         bp_catchpoint.
5373         (print_one_breakpoint_location, print_one_breakpoint): Use
5374         is_ada_exception_catchpoint.
5375         * ada-lang.c (class ada_catchpoint_location): Pass
5376         bp_loc_software_breakpoint to bp_location constructor.
5377         (is_ada_exception_catchpoint): New function.
5378
5379 2019-07-10  Tom Tromey  <tromey@adacore.com>
5380
5381         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
5382         VEC.
5383         (struct arm_exidx_entry): New method operator<.
5384         (struct arm_exidx_data) <section_maps>: Change type.
5385         (arm_exidx_data_free): Remove.
5386         (arm_exidx_data_key): Change type.  Move lower.
5387         (arm_exidx_new_objfile): Update.
5388         (arm_compare_exidx_entries): Remove.
5389         (arm_find_exidx_entry, _initialize_arm_tdep)
5390
5391 2019-07-10  Tom Tromey  <tromey@adacore.com>
5392
5393         * solib-spu.c (ocl_program_data_key): Change type.
5394         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
5395         Update.
5396
5397 2019-07-10  Tom Tromey  <tromey@adacore.com>
5398
5399         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
5400         (struct solib_aix_inferior_data) <library_list>: Change type.
5401         (solib_aix_inferior_data_handle): Change type.
5402         (get_solib_aix_inferior_data): Update.
5403         (solib_aix_free_library_list): Remove.
5404         (library_list_start_library): Update.
5405         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
5406         return type.
5407         (solib_aix_get_library_list)
5408         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
5409         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
5410
5411 2019-07-10  Tom Tromey  <tromey@adacore.com>
5412
5413         * solib-dsbt.c (struct dsbt_info): Add initializers.
5414         (solib_dsbt_pspace_data): Change type.
5415         (dsbt_pspace_data_cleanup): Remove.
5416         (get_dsbt_info, _initialize_dsbt_solib): Update.
5417
5418 2019-07-10  Tom Tromey  <tromey@adacore.com>
5419
5420         * spu-tdep.c (spu_overlay_data): Change type.
5421         (spu_get_overlay_table, spu_overlay_new_objfile)
5422         (_initialize_spu_tdep): Update.
5423
5424 2019-07-10  Tom Tromey  <tromey@adacore.com>
5425
5426         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
5427         destructor.
5428         (dbx_objfile_data_key): Change type and declare later.
5429         (DBX_SYMFILE_INFO): Rewrite.
5430         * dbxread.c (dbx_objfile_data_key): Change type.
5431         (dbx_symfile_init): Update.
5432         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
5433         (coffstab_build_psymtabs, elfstab_build_psymtabs)
5434         (stabsect_build_psymtabs, _initialize_dbxread): Update.
5435
5436 2019-07-10  Tom Tromey  <tromey@adacore.com>
5437
5438         * jit.c (jit_program_space_key): Change type.  Move lower.
5439         (get_jit_program_space_data): Update.
5440         (jit_program_space_data_cleanup): Remove.
5441         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
5442         Update.
5443         (struct jit_program_space_data): Add initializers.
5444
5445 2019-07-10  Tom Tromey  <tromey@adacore.com>
5446
5447         * solib-darwin.c (struct darwin_info): Add initializers.
5448         (solib_darwin_pspace_data): Change type.
5449         (darwin_pspace_data_cleanup): Remove.
5450         (get_darwin_info, _initialize_darwin_solib): Update.
5451
5452 2019-07-10  Tom Tromey  <tromey@adacore.com>
5453
5454         * remote-sim.c (struct sim_inferior_data): Add initializers,
5455         constructor, and destructor.
5456         (sim_inferior_data_key): Change type.  Move lower.
5457         (check_for_duplicate_sim_descriptor): Update.
5458         (get_sim_inferior_data): Use new.  Update.
5459         (~sim_inferior_data_cleanup): Rename from
5460         sim_inferior_data_cleanup.  Simplify.
5461         (gdbsim_close_inferior, simulator_command)
5462         (sim_command_completer, _initialize_remote_sim): Update.
5463         (next_pid, INITIAL_PID): Move earlier.
5464
5465 2019-07-10  Tom Tromey  <tromey@adacore.com>
5466
5467         * python/python-internal.h (create_thread_object): Return
5468         gdbpy_ref.
5469         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
5470         * python/py-inferior.c (struct threadlist_entry): Add
5471         constructor.
5472         <thread_obj>: Now a gdbpy_ref.
5473         (thread_to_thread_object): Update.
5474         (add_thread_object): Use new.
5475         (delete_thread_object): Use delete.
5476         (infpy_threads): Update.
5477         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
5478         GIL.
5479
5480 2019-07-10  Tom Tromey  <tromey@adacore.com>
5481
5482         * valops.c (value_cast): Specialize error message for Ada.
5483
5484 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
5485
5486         * breakpoint.c (breakpoint_1): Update doc and parameter names.
5487
5488 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
5489
5490         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
5491         bpstat_should_step): Return bool, adjust comments.
5492         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
5493         bpstat_should_step): Likewise.
5494
5495 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
5496
5497         * features/Makefile: Use feature target descriptions for Arm.
5498         * features/arm/arm-core.c: Generate new file.
5499         * features/arm/arm-fpa.c: Likewise.
5500         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
5501         * features/arm/arm-m-profile.c: Likewise.
5502         * features/arm/arm-vfpv2.c: Likewise.
5503         * features/arm/arm-vfpv3.c: Likewise.
5504         * features/arm/xscale-iwmmxt.c: Likewise.
5505         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
5506
5507 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
5508
5509         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
5510         ptrace earlier.
5511
5512 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
5513
5514         * features/aarch64-pauth.c: Regenerate.
5515
5516 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
5517
5518         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
5519         bool.
5520         (bpstat_what): Use false instead of 0.
5521
5522 2019-07-09  Pedro Alves  <palves@redhat.com>
5523
5524         * break-catch-throw.c (is_exception_catchpoint): New.
5525         * breakpoint.c (print_one_breakpoint_location): New parameter
5526         'raw_loc'.  Handle it.  Use
5527         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
5528         looking at the breakpoint's type.
5529         (print_one_breakpoint): If handling "maint info breakpoints", also
5530         print locations of exception catchpoints.
5531         * breakpoint.h (is_exception_catchpoint): Declare.
5532
5533 2019-07-09  Pedro Alves  <palves@redhat.com>
5534
5535         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
5536         "addr" field.
5537         (allocate_location_exception_catchpoint): New.
5538         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
5539         (initialize_throw_catchpoint_ops): Install
5540         allocate_location_exception_catchpoint as allocate_location
5541         method.
5542         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
5543         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
5544         bp_loc_other.
5545         (breakpoint_address_is_meaningful): Delete.
5546         (bl_address_is_meaningful): New.
5547         (breakpoint_locations_match): Adjust comment.
5548         (bp_location_from_bp_type): New, factored out of...
5549         (bp_location::bp_location(breakpoint *)): ... this.
5550         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
5551         factored out of...
5552         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
5553         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
5554         breakpoint_address_is_meaningful.
5555         (bp_locations_compare): Adjust comment.
5556         (update_global_location_list): Use bl_address_is_meaningful
5557         instead of breakpoint_address_is_meaningful.
5558         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
5559         explicit.
5560         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
5561         * python/py-breakpoint.c (bppy_get_location): No longer check
5562         whether location is null.
5563
5564 2019-07-09  Pedro Alves  <palves@redhat.com>
5565
5566         PR c++/15468
5567         * breakpoint.c (print_one_breakpoint_location): Remove
5568         single-location assert.
5569
5570 2019-07-09  Tom Tromey  <tom@tromey.com>
5571
5572         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
5573         * configure: Rebuild.
5574         * configure.ac: Change common to gdbsupport.
5575         * gdbsupport: Rename from common.
5576         * acinclude.m4: Change common to gdbsupport.
5577         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
5578         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
5579         gdbsupport.
5580         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
5581         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
5582         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
5583         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
5584         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
5585         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
5586         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
5587         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
5588         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
5589         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
5590         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
5591         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
5592         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
5593         coff-pe-read.c, command.h, compile/compile-c-support.c,
5594         compile/compile-c.h, compile/compile-cplus-symbols.c,
5595         compile/compile-cplus-types.c, compile/compile-cplus.h,
5596         compile/compile-loc2c.c, compile/compile.c, completer.c,
5597         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
5598         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
5599         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
5600         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
5601         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
5602         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
5603         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
5604         features/aarch64-core.c, features/aarch64-fpu.c,
5605         features/aarch64-pauth.c, features/aarch64-sve.c,
5606         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
5607         features/i386/32bit-core.c, features/i386/32bit-linux.c,
5608         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
5609         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
5610         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
5611         features/i386/64bit-core.c, features/i386/64bit-linux.c,
5612         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
5613         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
5614         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
5615         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
5616         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
5617         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
5618         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
5619         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
5620         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
5621         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
5622         go32-nat.c, guile/guile.c, guile/scm-ports.c,
5623         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
5624         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
5625         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
5626         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
5627         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
5628         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
5629         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
5630         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
5631         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
5632         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
5633         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
5634         minsyms.c, mips-linux-tdep.c, namespace.h,
5635         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
5636         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
5637         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
5638         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
5639         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
5640         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
5641         nat/linux-waitpid.c, nat/mips-linux-watch.c,
5642         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
5643         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
5644         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
5645         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
5646         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
5647         procfs.c, producer.c, progspace.h, psymtab.h,
5648         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
5649         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
5650         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
5651         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
5652         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
5653         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
5654         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
5655         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
5656         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
5657         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
5658         target-memory.c, target.c, target.h, target/waitstatus.c,
5659         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
5660         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
5661         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
5662         unittests/array-view-selftests.c,
5663         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
5664         unittests/common-utils-selftests.c,
5665         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
5666         unittests/format_pieces-selftests.c,
5667         unittests/function-view-selftests.c,
5668         unittests/lookup_name_info-selftests.c,
5669         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
5670         unittests/mkdir-recursive-selftests.c,
5671         unittests/observable-selftests.c,
5672         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
5673         unittests/parse-connection-spec-selftests.c,
5674         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
5675         unittests/scoped_fd-selftests.c,
5676         unittests/scoped_mmap-selftests.c,
5677         unittests/scoped_restore-selftests.c,
5678         unittests/string_view-selftests.c, unittests/style-selftests.c,
5679         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
5680         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
5681         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
5682         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
5683         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
5684         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
5685
5686 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
5687
5688         * linespec.c (decode_digits_list_mode): Set explicit_line to a
5689         bool value.
5690         (decode_digits_ordinary): Set explicit_line field in sal.
5691         * symtab.c (skip_prologue_sal): Don't skip prologue for a
5692         symtab_and_line that was set on an explicit line number in
5693         assembler code.  Do always update the recorded symtab and line if
5694         we do skip the prologue.
5695
5696 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
5697
5698         * breakpoint.c (set_breakpoint_location_function): Remove
5699         explicit_loc parameter.
5700         (momentary_breakpoint_from_master): Update call to
5701         set_breakpoint_location_function.
5702         (add_location_to_breakpoint): Likewise.
5703
5704 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
5705
5706         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
5707         required features based on default bfd type when no specific bfd
5708         is present.
5709
5710 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5711
5712         * NEWS: Mention that GDB printf and eval commands can now print
5713         C-style and Ada-style convenience var strings without
5714         calling the inferior.
5715         * printcmd.c (printf_c_string): Locally print GDB internal var
5716         instead of transiting via the inferior.
5717         (printf_wide_c_string): Likewise.
5718
5719 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5720
5721         PR breakpoints/25011
5722         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
5723
5724 2019-07-04  Tom Tromey  <tom@tromey.com>
5725
5726         PR tui/24724:
5727         * tui/tui-winsource.c (tui_clear_source_content): Update.
5728         (tui_source_window_base::set_is_exec_point_at): Fix comment.
5729         (tui_update_breakpoint_info): Update.
5730         (tui_set_exec_info_content): Update.
5731         * tui/tui-source.c (tui_set_source_content_nil): Update.
5732         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
5733         has_break.
5734         * tui/tui-data.h (enum tui_bp_flag): New.
5735         (tui_bp_flags): New enum flags type.
5736         (struct tui_source_element) <break_mode>: Change type.  Rename
5737         from has_break.
5738         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
5739         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
5740         constants.
5741         * tui/tui-winsource.h: Fix comment.
5742
5743 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5744
5745         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
5746         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
5747         (store_fpregs_to_thread)
5748         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
5749         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
5750         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
5751         (IWMMXT_REGS_SIZE): Add define.
5752         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
5753         (fetch_vfp_regs, store_vfp_regs)
5754         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
5755         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
5756
5757 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5758
5759         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
5760         defines.
5761         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
5762         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
5763         (ARM_INT_REGISTER_SIZE): ...to this.
5764         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
5765         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
5766         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
5767         (arm_linux_collect_gregset, supply_nwfpe_register)
5768         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
5769         defines.
5770         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
5771         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
5772         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
5773         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
5774         (arm_return_in_memory, arm_store_return_value)
5775         (arm_get_longjmp_target, arm_register_g_packet_guesses)
5776         (arm_record_ld_st_multiple): Likewise.
5777         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
5778         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
5779
5780 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5781
5782         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
5783         AARCH64_DISPLACED_MODIFIED_INSNS.
5784         * aarch64-tdep.c (struct aarch64_displaced_step_data)
5785         (aarch64_displaced_step_copy_insn): Likewise.
5786         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
5787         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
5788         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
5789         ARM_DISPLACED_MODIFIED_INSNS.
5790         * arm-tdep.c (arm_gdbarch_init): Likewise.
5791         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
5792         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
5793         (struct arm_displaced_step_closure): Use
5794         ARM_DISPLACED_MODIFIED_INSNS.
5795
5796 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5797
5798         * features/Makefile: Remove unused xml files.
5799         * features/aarch64.xml: Remove.
5800         * features/i386/amd64-avx-avx512-linux.xml: Remove.
5801         * features/i386/amd64-avx-avx512.xml: Remove.
5802         * features/i386/amd64-avx-linux.xml: Remove.
5803         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
5804         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
5805         * features/i386/amd64-avx-mpx-linux.xml: Remove.
5806         * features/i386/amd64-avx-mpx.xml: Remove.
5807         * features/i386/amd64-avx.xml: Remove.
5808         * features/i386/amd64-linux.xml: Remove.
5809         * features/i386/amd64-mpx-linux.xml: Remove.
5810         * features/i386/amd64-mpx.xml: Remove.
5811         * features/i386/amd64.xml: Remove.
5812         * features/i386/i386-avx-avx512-linux.xml: Remove.
5813         * features/i386/i386-avx-avx512.xml: Remove.
5814         * features/i386/i386-avx-linux.xml: Remove.
5815         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
5816         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
5817         * features/i386/i386-avx-mpx-linux.xml: Remove.
5818         * features/i386/i386-avx-mpx.xml: Remove.
5819         * features/i386/i386-avx.xml: Remove.
5820         * features/i386/i386-linux.xml: Remove.
5821         * features/i386/i386-mmx-linux.xml: Remove.
5822         * features/i386/i386-mmx.xml: Remove.
5823         * features/i386/i386-mpx-linux.xml: Remove.
5824         * features/i386/i386-mpx.xml: Remove.
5825         * features/i386/i386.xml: Remove.
5826         * features/i386/x32-avx-avx512-linux.xml: Remove.
5827         * features/i386/x32-avx-linux.xml: Remove.
5828         * features/i386/x32-linux.xml: Remove.
5829
5830 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5831
5832         * regformats/aarch64.dat: Remove.
5833         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
5834         * regformats/i386/amd64-avx-linux.dat: Remove.
5835         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
5836         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
5837         * regformats/i386/amd64-linux.dat: Remove.
5838         * regformats/i386/amd64-mpx-linux.dat: Remove.
5839         * regformats/i386/amd64.dat: Remove.
5840         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
5841         * regformats/i386/i386-avx-linux.dat: Remove.
5842         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
5843         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
5844         * regformats/i386/i386-linux.dat: Remove.
5845         * regformats/i386/i386-mmx-linux.dat: Remove.
5846         * regformats/i386/i386-mpx-linux.dat: Remove.
5847         * regformats/i386/i386.dat: Remove.
5848         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
5849         * regformats/i386/x32-avx-linux.dat: Remove.
5850         * regformats/i386/x32-linux.dat: Remove.
5851
5852 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5853
5854         * aarch64-tdep.c: Remove xml self tests.
5855         * amd64-linux-tdep.c: Likewise.
5856         * amd64-tdep.c: Likewise.
5857         * i386-linux-tdep.c: Likewise.
5858         * i386-tdep.c: Likewise.
5859
5860 2019-07-03  Pedro Alves  <palves@redhat.com>
5861
5862         PR cli/24732
5863         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
5864         (pipe_cmd_option_defs): New.
5865         (make_pipe_cmd_options_def_group): New.
5866         (pipe_command): Use gdb::option::process_options.
5867         (pipe_command_completer): New function.
5868         (_initialize_cli_cmds): Install completer for "pipe" command.
5869
5870 2019-07-03  Pedro Alves  <palves@redhat.com>
5871
5872         * cli/cli-option.c (union option_value) <string>: New field.
5873         (struct option_def_and_value): Add ctor, move ctor, dtor and
5874         use DISABLE_COPY_AND_ASSIGN.
5875         (option_def_and_value::clear_value): New.
5876         (parse_option, save_option_value_in_ctx, get_val_type_str)
5877         (add_setshow_cmds_for_options): Handle var_string.
5878         * cli-option.h (union option_def::var_address) <string>: New
5879         field.
5880         (struct string_option_def): New.
5881         * maint-test-options.c (struct test_options_opts): Add default
5882         ctor and use DISABLE_COPY_AND_ASSIGN.
5883         <string_opt>: New field.
5884         (test_options_opts::~test_options_opts): New.
5885         (test_options_opts::dump): Also dump "-string".
5886         (test_options_option_defs): Install "string.
5887
5888 2019-07-03  Pedro Alves  <palves@redhat.com>
5889
5890         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
5891         option_value with a null enumeration.
5892         (complete_options): Save the option values in the context.
5893         (save_option_value_in_ctx): New, factored out from ...
5894         (process_options): ... here.
5895         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
5896         of the function.
5897         * maint-test-options.c (test_options_opts::dump): New, factored
5898         out from ...
5899         (maintenance_test_options_command_mode): ... here.
5900         (maintenance_test_options_command_completion_result): Delete.
5901         (maintenance_test_options_command_completion_text): Update
5902         comment.
5903         (maintenance_show_test_options_completion_result): Change
5904         prototype.  Just print
5905         maintenance_test_options_command_completion_text.
5906         (save_completion_result): New.
5907         (maintenance_test_options_completer_mode): Pass options context to
5908         complete_options, and then save a dump.
5909         (_initialize_maint_test_options): Use add_cmd to install "maint
5910         show test-options-completion-result".
5911
5912 2019-07-03  Pedro Alves  <palves@redhat.com>
5913
5914         * NEWS (New commands): Mention "with" and "maint with".
5915         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
5916         (with_command, with_command_completer): New.
5917         (pipe_command): Adjust to new repeat_previous
5918         interface.
5919         (_initialize_cli_cmds): Install the "with" command and its "w"
5920         alias.
5921         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
5922         declarations.
5923         * cli/cli-setshow.c (parse_cli_var_uinteger)
5924         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
5925         argument strings for all var_types.
5926         (get_setshow_command_value_string): New, factored out from ...
5927         (do_show_command): ... this.
5928         * cli/cli-setshow.h: Include <string>.
5929         (get_setshow_command_value_string): Declare.
5930         * command.h (repeat_previous): Now returns const char *.  Adjust
5931         comment.
5932         * maint.c: Include "cli/cli-cmds.h".
5933         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
5934         (_initialize_maint_cmds): Register the "maintenance with" command.
5935         * top.c (repeat_previous): Move bits from pipe_command here:
5936         Return the saved command line, if any; error out if there's no
5937         command to relaunch.
5938
5939 2019-07-03  Pedro Alves  <palves@redhat.com>
5940
5941         * NEWS (New commands): Mention "maint set/show test-settings"
5942         instead of "maint test-settings".
5943         * maint-test-settings.c (maintenance_test_settings_list): Delete.
5944         (maintenance_test_settings_set_list): Rename to ...
5945         (maintenance_set_test_settings_list): ... this.
5946         (maintenance_test_settings_show_list): Rename to  ...
5947         (maintenance_show_test_settings_list): ... this.
5948         (maintenance_test_settings_cmd): Delete.
5949         (maintenance_test_settings_set_cmd): ...
5950         (maintenance_set_test_settings_cmd): ... this.
5951         (maintenance_test_settings_show_cmd): ...
5952         (maintenance_show_test_settings_cmd): ... this.
5953         (maintenance_test_settings_show_value_cmd):
5954         (maintenance_show_test_settings_value_cmd): ... this.
5955         (_initialize_maint_test_settings): No longer install the "maint
5956         test-settings" prefix command.  Rename "maint test-settings set"
5957         to "maint set test-settings", and "maint test-settings show" to
5958         "maint show test-settings".  Adjust all subcommands.
5959
5960 2019-07-03  Pedro Alves  <palves@redhat.com>
5961
5962         * maint-test-settings.c: Fix file's intro comment.  Replace all
5963         references to "test-options" with references to "test-settings",
5964         in comments.
5965
5966 2019-07-03  Pedro Alves  <palves@redhat.com>
5967
5968         * maint-test-settings.c (maintenance_test_settings_xxx)
5969         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
5970         New.
5971         (maintenance_test_settings_enums): Use them.
5972         (maintenance_test_settings_enum): Default to
5973         maintenance_test_settings_xxx.
5974         (_initialize_maint_test_settings): Initialize
5975         MAINTENANCE_TEST_SETTINGS_FILENAME.
5976
5977 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
5978
5979         * breakpoint.h (remove_breakpoints_inf): Change return type to
5980         void, move function documentation here.
5981         * breakpoint.c (remove_breakpoints_inf): Change return type to
5982         void, move function documentation to header.
5983
5984 2019-07-02  Pedro Alves  <palves@redhat.com>
5985
5986         * NEWS (Completion improvements): Mention "info threads".
5987         * thread.c (struct info_threads_opts, info_threads_option_defs)
5988         (make_info_threads_options_def_group): New.
5989         (info_threads_command): Use gdb::option::process_options.
5990         (info_threads_command_completer): New.
5991         (_initialize_thread): Use gdb::option::build_help to build the
5992         help text for "info threads".
5993
5994 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
5995
5996         * defs.h (generic_load): Move from here...
5997         * symfile.h (generic_load): ... to here.  Rename name parameter
5998         to args.
5999         * symfile.c (generic_load): Add comment.
6000
6001 2019-07-01  Tom Tromey  <tromey@adacore.com>
6002
6003         * dwarf2read.c
6004         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
6005         declaration of without_params.  Fix formatting.
6006
6007 2019-07-01  Tom Tromey  <tromey@adacore.com>
6008
6009         * ada-exp.y (find_primitive_type): Update.
6010         * ada-lang.h (ada_lookup_symbol): Update.
6011         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
6012         parameter.
6013         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
6014
6015 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
6016
6017         PR breakpoints/24541
6018         * gdbarch.c: Regenerate.
6019         * gdbarch.h: Regenerate.
6020         * gdbarch.sh: Add 'stap_adjust_register'.
6021         * i386-tdep.c: Include '<unordered_set>'.
6022         (i386_stap_adjust_register): New function.
6023         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
6024         * stap-probe.c (stap_parse_register_operand): Call
6025         'gdbarch_stap_adjust_register'.
6026
6027 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
6028
6029         PR python/24742
6030         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
6031         * python/python.c (do_start_initialization): Use 'xmalloc'
6032         instead of 'PyMem_Malloc'.
6033
6034 2019-06-28  Tom Tromey  <tromey@adacore.com>
6035
6036         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
6037         for Ada.
6038
6039 2019-06-27  Tom Tromey  <tromey@adacore.com>
6040
6041         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
6042         objfile_key.
6043         (arm_find_mapping_symbol, arm_record_special_symbol)
6044         (_initialize_arm_tdep): Update.
6045         (arm_objfile_data_free): Remove.
6046
6047 2019-06-27  Tom Tromey  <tromey@adacore.com>
6048
6049         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
6050         to cp_print_static_field.
6051
6052 2019-06-26  Tom Tromey  <tromey@adacore.com>
6053
6054         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
6055         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
6056         declare.
6057
6058 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
6059
6060         * features/aarch64-core.c (create_feature_aarch64_core):
6061         Regenerate.
6062         * features/aarch64-core.xml: Add cpsr flags.
6063
6064 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
6065
6066         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
6067         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
6068
6069 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
6070
6071         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
6072         field.
6073         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
6074         use.
6075         (arm_record_special_symbol): Don't insert new symbol in sorted
6076         position, push it at the end.
6077
6078 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
6079
6080         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
6081         (arm_mapping_symbol_s): Remove.
6082         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
6083         (arm_mapping_symbol_vec): New typedef.
6084         (struct arm_per_objfile): Add constructor.
6085         <section_maps>: Change type to
6086         std::unique_ptr<arm_mapping_symbol_vec[]>.
6087         (arm_compare_mapping_symbols): Remove.
6088         (arm_find_mapping_symbol): Adjust to section_maps type change.
6089         (arm_objfile_data_free): Call delete on arm_per_objfile.
6090         (arm_record_special_symbol): Adjust to section_maps type change.
6091         Allocate arm_per_objfile with new.
6092
6093 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6094
6095         * cli/cli-cmds.c (alias_command): Compare the alias prefix
6096         with the command prefix.
6097
6098 2019-06-25  Tom Tromey  <tom@tromey.com>
6099
6100         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
6101         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
6102
6103 2019-06-25  Tom Tromey  <tom@tromey.com>
6104
6105         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
6106         type.
6107         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
6108         protected.
6109
6110 2019-06-25  Tom Tromey  <tom@tromey.com>
6111
6112         * tui/tui-winsource.c
6113         (tui_source_window_base::set_is_exec_point_at): Add check against
6114         LOA_ADDRESS.
6115
6116 2019-06-25  Tom Tromey  <tom@tromey.com>
6117
6118         * tui/tui-source.c (tui_set_source_content): Don't check before
6119         xfree.
6120         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
6121
6122 2019-06-25  Tom Tromey  <tom@tromey.com>
6123
6124         * tui/tui-winsource.h (tui_update_source_window_as_is)
6125         (tui_alloc_source_buffer, tui_line_is_displayed)
6126         (tui_addr_is_displayed): Change type of win_info.
6127         * tui/tui-winsource.c (tui_update_source_window_as_is)
6128         (tui_clear_source_content, tui_show_source_line)
6129         (tui_show_source_content, tui_source_window_base::refill)
6130         (tui_source_window_base::set_is_exec_point_at)
6131         (tui_source_window_base::set_is_exec_point_at)
6132         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
6133         (tui_alloc_source_buffer, tui_line_is_displayed)
6134         (tui_addr_is_displayed): Change type of win_info.  Update.
6135         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
6136         (tui_source_window_base::do_make_visible_with_new_height):
6137         Update.
6138         * tui/tui-source.c (tui_set_source_content)
6139         (tui_set_source_content_nil)
6140         (tui_source_window::do_scroll_vertical): Update.
6141         * tui/tui-layout.c (show_layout): Update.
6142         * tui/tui-disasm.c (tui_set_disassem_content)
6143         (tui_disasm_window::do_scroll_vertical): Update.
6144         * tui/tui-data.h (tui_win_content): Remove.
6145         (struct tui_gen_win_info) <content, content_size>: Remove.
6146         (struct tui_source_element): Add initializers and destructor.
6147         (union tui_which_element, struct tui_win_element): Remove.
6148         (struct tui_source_window_base) <content>: New field.
6149         (struct tui_data_window): Remove destructor.
6150         (tui_alloc_content, tui_free_win_content)
6151         (tui_free_all_source_wins_content): Don't declare.
6152         * tui/tui-data.c (tui_initialize_static_data): Update.
6153         (init_content_element, tui_alloc_content): Remove.
6154         (~tui_gen_win_info): Update.
6155         (~tui_data_window, tui_free_all_source_wins_content)
6156         (tui_free_win_content, free_content, free_content_elements):
6157         Remove.
6158
6159 2019-06-25  Tom Tromey  <tom@tromey.com>
6160
6161         * tui/tui-winsource.h (tui_clear_source_content)
6162         (tui_erase_source_content, tui_show_source_content): Change type
6163         of win_info.
6164         * tui/tui-winsource.c (tui_clear_source_content)
6165         (tui_erase_source_content, tui_show_source_content): Change type
6166         of win_info.
6167         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
6168         * tui/tui-source.h (tui_set_source_content_nil): Change type of
6169         win_info.
6170         * tui/tui-source.c (tui_set_source_content_nil): Change type of
6171         win_info.
6172         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
6173
6174 2019-06-25  Tom Tromey  <tom@tromey.com>
6175
6176         * tui/tui-winsource.c (tui_clear_source_content)
6177         (tui_source_window_base::set_is_exec_point_at): Update.
6178         * tui/tui-source.c (tui_set_source_content_nil): Update.
6179         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
6180         a bool.
6181         * tui/tui-data.c (init_content_element): Update.
6182
6183 2019-06-25  Tom Tromey  <tom@tromey.com>
6184
6185         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
6186         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
6187         * tui/tui-layout.c (init_and_make_win): Update.
6188         * tui/tui.h (enum tui_win_type): Update.
6189         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
6190         tui_win_is_auxillary.
6191         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
6192         tui_win_is_auxillary.
6193
6194 2019-06-25  Tom Tromey  <tom@tromey.com>
6195
6196         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
6197         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
6198         (tui_delete_data_content_windows, tui_display_all_data)
6199         (tui_data_window::do_scroll_vertical, tui_display_data_from):
6200         Update.
6201         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
6202         * tui/tui-regs.c (tui_last_regs_line_no)
6203         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
6204         (tui_show_registers): Update.
6205         (tui_show_register_group): Return void.  Update.
6206         (tui_display_registers_from, tui_display_reg_element_at_line)
6207         (tui_display_registers_from_line, tui_check_register_values):
6208         Update.
6209         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
6210         member.
6211         (struct tui_data_window) <regs_content>: Now a std::vector.
6212         <regs_content_count>: Remove.
6213         (tui_add_content_elements, tui_free_data_content): Don't declare.
6214         * tui/tui-data.c (tui_data_window::clear_detail): Update.
6215         (init_content_element): Remove DATA_WIN case.  Add assert.
6216         (tui_add_content_elements): Remove.
6217         (tui_data_window): Update.
6218         (tui_free_data_content): Remove.
6219         (free_content_elements): Remove DATA_WIN case.
6220
6221 2019-06-25  Tom Tromey  <tom@tromey.com>
6222
6223         * tui/tui-data.c (tui_data_item_window): Update.
6224         * tui/tui-windata.h (tui_check_data_values): Don't declare.
6225         * tui/tui-windata.c (tui_display_all_data)
6226         (tui_display_data_from_line): Update.
6227         (tui_check_data_values): Remove.
6228         * tui/tui-regs.c (tui_show_register_group)
6229         (tui_display_reg_element_at_line): Update.
6230         * tui/tui-hooks.c (tui_register_changed)
6231         (tui_refresh_frame_and_register_information): Call
6232         tui_check_register_values.
6233         * tui/tui-data.h (struct tui_data_window) <data_content,
6234         data_content_count, data_type>: Remove.
6235         (enum tui_data_type): Remove.
6236
6237         * tui/tui-data.c (tui_data_window::clear_detail)
6238         (~tui_data_window): Update.
6239
6240 2019-06-25  Tom Tromey  <tom@tromey.com>
6241
6242         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
6243         declare.
6244         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
6245         Rename from tui_first_data_item_displayed.  Update.
6246         (tui_data_window::refresh_all)
6247         (tui_data_window::do_scroll_vertical): Update.
6248         * tui/tui-data.h (struct tui_data_window)
6249         <first_data_item_displayed>: Declare new method.
6250
6251 2019-06-25  Tom Tromey  <tom@tromey.com>
6252
6253         * tui/tui-data.h (tui_init_generic_part): Don't declare.
6254         * tui/tui-data.c (tui_init_generic_part): Remove, moving
6255         contents...
6256         (tui_initialize_static_data): ...here.
6257
6258 2019-06-25  Tom Tromey  <tom@tromey.com>
6259
6260         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
6261         (tui_display_registers_from, tui_check_register_values): Update.
6262         (tui_display_register): Remove win_info parameter; update.
6263         (tui_get_register): Change type of parameters.
6264         * tui/tui-data.h (struct tui_data_element): Remove.
6265         (union tui_which_element) <data>: Remove.
6266         <data_window>: Change type.
6267         (struct tui_data_item_window): New.
6268         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
6269         case.  Add assert.
6270         (~tui_data_item_window): New destructor.
6271         (free_content_elements): Remove DATA_ITEM_WIN case.
6272
6273 2019-06-25  Tom Tromey  <tom@tromey.com>
6274
6275         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
6276         Remove.
6277
6278 2019-06-25  Tom Tromey  <tom@tromey.com>
6279
6280         * tui/tui-data.h (struct tui_command_element): Remove.
6281         (union tui_which_element) <command>: Remove.
6282         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
6283         assert.
6284         (free_content_elements): Remove CMD_WIN case.
6285
6286 2019-06-25  Tom Tromey  <tom@tromey.com>
6287
6288         * tui/tui-layout.c (tui_set_layout): Update.
6289         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
6290         * tui/tui-data.c (layout_def): Update.
6291
6292 2019-06-25  Tom Tromey  <tom@tromey.com>
6293
6294         * tui/tui-wingeneral.c (tui_refresh_all): Update.
6295         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
6296         (tui_source_window_base::set_new_height): Update.
6297         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
6298         Update.
6299         (tui_set_locator_fullname, tui_set_locator_info)
6300         (tui_show_frame_info): Update.
6301         * tui/tui-source.c (tui_set_source_content)
6302         (tui_source_is_displayed): Update.
6303         * tui/tui-layout.c (show_source_disasm_command, show_data)
6304         (show_source_or_disasm_and_command): Update.
6305         * tui/tui-disasm.c (tui_set_disassem_content)
6306         (tui_get_begin_asm_address): Update.
6307         * tui/tui-data.h (struct tui_locator_element): Remove.
6308         (union tui_which_element) <locator>: Remove.
6309         (struct tui_locator_window): New.
6310         (tui_locator_win_info_ptr): Change return type.
6311         * tui/tui-data.c (_locator): Change type.
6312         (tui_locator_win_info_ptr): Change return type.
6313         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
6314         (tui_alloc_content): Add assert.
6315
6316 2019-06-25  Tom Tromey  <tom@tromey.com>
6317
6318         * tui/tui-winsource.c
6319         (tui_exec_info_window::maybe_allocate_content): New method.
6320         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
6321         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
6322         (make_source_or_disasm_window): Add cast.
6323         * tui/tui-data.h (union tui_which_element) <simple_string>:
6324         Remove.
6325         (struct tui_source_info): New.
6326         (struct tui_source_window_base) <execution_info>: Change type.
6327         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
6328         case, and add assert.
6329         (tui_alloc_content): Add assert.
6330
6331 2019-06-25  Tom Tromey  <tom@tromey.com>
6332
6333         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
6334         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
6335         * tui/tui-data.c (tui_alloc_win_info): Remove.
6336
6337 2019-06-25  Tom Tromey  <tom@tromey.com>
6338
6339         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
6340         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
6341         can_highlight.
6342
6343 2019-06-25  Tom Tromey  <tom@tromey.com>
6344
6345         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
6346         make_visible_with_new_height method.
6347         (tui_win_info::make_visible_with_new_height): New method.
6348         (tui_source_window_base::do_make_visible_with_new_height)
6349         (tui_data_window::do_make_visible_with_new_height)
6350         (tui_cmd_window::do_make_visible_with_new_height): New methods.
6351         (make_visible_with_new_height): Remove.
6352         (tui_resize_all, tui_adjust_win_heights): Use
6353         make_visible_with_new_height method.
6354         * tui/tui-data.h (struct tui_win_info)
6355         <do_make_visible_with_new_height, make_visible_with_new_height>:
6356         New methods.
6357         (struct tui_source_window_base, struct tui_data_window)
6358         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
6359         methods.
6360
6361 2019-06-25  Tom Tromey  <tom@tromey.com>
6362
6363         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
6364         method.
6365         (update_tab_width): Call update_tab_width method.
6366         * tui/tui-data.h (struct tui_win_info)
6367         (struct tui_source_window_base) <update_tab_width>: New methods.
6368
6369 2019-06-25  Tom Tromey  <tom@tromey.com>
6370
6371         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
6372         parameter.
6373         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
6374         parameter.
6375         (tui_gen_win_info::make_visible): Update.
6376         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
6377         parameter.
6378         * tui/tui-data.h (enum tui_box): New enum.
6379         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
6380
6381 2019-06-25  Tom Tromey  <tom@tromey.com>
6382
6383         * tui/tui-layout.c (make_source_or_disasm_window): Always use
6384         init_and_make_win for EXEC_INFO_WIN.
6385         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
6386         longer inline.
6387         (struct tui_win_info) <~tui_win_info>: Inline.
6388         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
6389         Don't declare.
6390         * tui/tui-data.c (source_win, disasm_win): Remove globals.
6391         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
6392         Remove.
6393         (tui_initialize_static_data): Update.
6394         (~tui_gen_win_info): Handle more cleanup here.
6395         (~tui_source_window_base): Delete "execution_info".
6396         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
6397
6398 2019-06-25  Tom Tromey  <tom@tromey.com>
6399
6400         * tui/tui-layout.c (make_command_window): Don't set
6401         can_highlight.
6402         (show_source_disasm_command): Call the reset method.
6403         (show_data): Don't set can_highlight.  Call the reset method.
6404         (tui_gen_win_info::reset): Rename from init_gen_win_info
6405         (init_and_make_win): Simplify.  Return tui_gen_win_info.
6406         (show_source_or_disasm_and_command): Call the reset method.
6407         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
6408         (struct tui_cmd_window): Set can_highlight.
6409
6410 2019-06-25  Tom Tromey  <tom@tromey.com>
6411
6412         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
6413         from make_visible.
6414         (tui_make_visible, tui_make_invisible): Rewrite.
6415         (tui_win_info::make_visible): Remove.
6416         (tui_source_window_base::make_visible): Update.
6417         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
6418         method.  Moved from...
6419         (struct tui_win_info) <make_visible>: ...here.
6420
6421 2019-06-25  Tom Tromey  <tom@tromey.com>
6422
6423         * tui/tui-winsource.c
6424         (tui_source_window_base::do_scroll_horizontal): Remove direction
6425         parameter.
6426         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
6427         direction parameter.
6428         * tui/tui-win.c (tui_win_info::forward_scroll)
6429         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
6430         (tui_win_info::right_scroll): Update.
6431         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
6432         direction parameter.
6433         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
6434         direction parameter.
6435         * tui/tui-data.h (enum tui_scroll_direction): Remove.
6436         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
6437         Remove direction parameter.
6438         (struct tui_source_window_base, struct tui_source_window)
6439         (struct tui_disasm_window, struct tui_data_window)
6440         (struct tui_cmd_window): Update.
6441
6442 2019-06-25  Tom Tromey  <tom@tromey.com>
6443
6444         * tui/tui-winsource.h (tui_set_exec_info_content)
6445         (tui_show_exec_info_content, tui_erase_exec_info_content)
6446         (tui_clear_exec_info_content, tui_update_exec_info): Change
6447         argument to tui_source_window_base.
6448         * tui/tui-winsource.c (tui_set_exec_info_content)
6449         (tui_show_exec_info_content, tui_erase_exec_info_content)
6450         (tui_clear_exec_info_content, tui_update_exec_info): Change
6451         argument to tui_source_window_base.
6452
6453 2019-06-25  Tom Tromey  <tom@tromey.com>
6454
6455         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
6456         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
6457
6458 2019-06-25  Tom Tromey  <tom@tromey.com>
6459
6460         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
6461         check.
6462
6463 2019-06-25  Tom Tromey  <tom@tromey.com>
6464
6465         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
6466         type to void.
6467         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
6468         type to void.
6469         * tui/tui-source.c (tui_set_source_content): Update.
6470         * tui/tui-disasm.c (tui_set_disassem_content): Update.
6471
6472 2019-06-25  Tom Tromey  <tom@tromey.com>
6473
6474         * tui/tui-win.c (window_name_completer, tui_set_focus)
6475         (tui_all_windows_info): Use name method.
6476         * tui/tui-data.h (struct tui_gen_win_info)
6477         (struct tui_source_window, struct tui_disasm_window)
6478         (struct tui_data_window, struct tui_cmd_window) <name>: New
6479         method.
6480         (tui_win_name): Don't declare.
6481         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
6482         (tui_win_name): Remove.
6483
6484 2019-06-25  Tom Tromey  <tom@tromey.com>
6485
6486         * tui/tui-winsource.h (tui_update_source_window)
6487         (tui_update_source_window_as_is): Change parameter type.
6488         * tui/tui-winsource.c (tui_update_source_window): Change win_info
6489         to be a tui_source_window_base.
6490         (tui_update_source_window_as_is): Likewise.
6491         * tui/tui-win.c (make_visible_with_new_height): Update.
6492
6493 2019-06-25  Tom Tromey  <tom@tromey.com>
6494
6495         * tui/tui-winsource.c (tui_erase_source_content)
6496         (tui_show_source_content, tui_show_exec_info_content)
6497         (tui_erase_exec_info_content): Use refresh_window method.
6498         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
6499         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
6500         from tui_refresh_win.
6501         (tui_data_window::refresh_window): New method.
6502         (tui_win_info::refresh, tui_source_window_base::refresh)
6503         (tui_refresh_all): Use refresh_window method.
6504         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
6505         method.
6506         * tui/tui-regs.c (tui_display_register): Call refresh_window
6507         method.
6508         * tui/tui-layout.c (show_source_disasm_command)
6509         (show_source_or_disasm_and_command): Call refresh_window method.
6510         * tui/tui-data.h (struct tui_gen_win_info)
6511         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
6512         New method.
6513
6514 2019-06-25  Tom Tromey  <tom@tromey.com>
6515
6516         * tui/tui.c (tui_rl_other_window, tui_enable)
6517         (tui_is_window_visible, tui_get_command_dimension): Update.
6518         * tui/tui-winsource.c (tui_update_source_window_as_is)
6519         (tui_clear_source_content, tui_erase_source_content)
6520         (tui_show_source_line, tui_source_window_base::refill)
6521         (tui_source_window_base::do_scroll_horizontal)
6522         (tui_source_window_base::set_is_exec_point_at)
6523         (tui_update_breakpoint_info, tui_set_exec_info_content)
6524         (tui_alloc_source_buffer, tui_line_is_displayed)
6525         (tui_addr_is_displayed): Update.
6526         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
6527         (tui_check_and_display_highlight_if_needed)
6528         (tui_win_info::make_visible, tui_win_info::refresh)
6529         (tui_refresh_all): Update.
6530         * tui/tui-windata.c (tui_first_data_item_displayed)
6531         (tui_delete_data_content_windows, tui_erase_data_content)
6532         (tui_display_all_data, tui_data_window::refresh_all)
6533         (tui_check_data_values): Update.
6534         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
6535         (tui_set_win_focus_to, tui_win_info::forward_scroll)
6536         (tui_win_info::backward_scroll, tui_refresh_all_win)
6537         (tui_resize_all, tui_set_focus, tui_all_windows_info)
6538         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
6539         (tui_source_window_base::set_new_height)
6540         (tui_data_window::set_new_height)
6541         (make_invisible_and_set_new_height)
6542         (make_visible_with_new_height, new_height_ok)
6543         (parse_scrolling_args): Update.
6544         * tui/tui-stack.c (tui_show_frame_info): Update.
6545         * tui/tui-source.c (tui_set_source_content)
6546         (tui_set_source_content_nil, tui_source_is_displayed)
6547         (tui_source_window::do_scroll_vertical): Update.
6548         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
6549         (tui_display_registers_from, tui_display_reg_element_at_line)
6550         (tui_check_register_values, tui_reg_command): Update.
6551         * tui/tui-layout.c (tui_default_win_height)
6552         (show_source_disasm_command, show_data, init_and_make_win)
6553         (show_source_or_disasm_and_command): Update.
6554         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
6555         (tui_redisplay_readline, tui_mld_flush)
6556         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
6557         (tui_getc): Update.
6558         * tui/tui-disasm.c (tui_set_disassem_content)
6559         (tui_disasm_window::do_scroll_vertical): Update.
6560         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
6561         Now virtual.
6562         (struct tui_win_info): Derive from tui_gen_win_info.
6563         <~tui_win_info>: Mark as override.
6564         <generic>: Remove member.
6565         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
6566         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
6567         (~tui_data_window, ~tui_win_info)
6568         (tui_free_all_source_wins_content): Update.
6569         * tui/tui-command.c (tui_refresh_cmd_win): Update.
6570
6571 2019-06-25  Tom Tromey  <tom@tromey.com>
6572
6573         * tui/tui-layout.c (init_and_make_win): Use new.
6574         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
6575         destructor, initializers.
6576         (tui_alloc_generic_win_info): Don't declare.
6577         * tui/tui-data.c (_locator): Add argument to constructor.
6578         (source_win, disasm_win): New globals.
6579         (exec_info): Remove.
6580         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
6581         Update.
6582         (tui_alloc_generic_win_info): Remove.
6583         (init_content_element): Use new.
6584         (tui_win_info::tui_win_info): Update.
6585         (free_content_elements) <case DATA_WIN>: Use delete.
6586
6587 2019-06-25  Tom Tromey  <tom@tromey.com>
6588
6589         * tui/tui-wingeneral.c (tui_refresh_win): Update.
6590         * tui/tui-windata.c (tui_first_data_item_displayed)
6591         (tui_delete_data_content_windows): Update.
6592         * tui/tui-win.c (tui_data_window::set_new_height): Update.
6593         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
6594         (tui_display_registers_from, tui_check_register_values): Update.
6595         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
6596         pointer.
6597         * tui/tui-data.c (init_content_element): Update.  Allocate the new
6598         window.
6599         (tui_free_data_content): Update.
6600         (free_content_elements) <case DATA_WIN>: Free the window.
6601
6602 2019-06-25  Tom Tromey  <tom@tromey.com>
6603
6604         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
6605         Update.
6606         * tui/tui-layout.c (make_command_window)
6607         (show_source_disasm_command, show_data, init_and_make_win)
6608         (show_source_or_disasm_and_command): Update.
6609         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
6610         method.
6611         <can_highight, is_highlighted>: Now bool.
6612         (tui_set_win_highlight): Don't declare.
6613         * tui/tui-data.c (tui_set_win_highlight): Remove.
6614
6615 2019-06-25  Tom Tromey  <tom@tromey.com>
6616
6617         * tui/tui-wingeneral.c (make_visible): Remove check of window
6618         type.
6619
6620 2019-06-25  Tom Tromey  <tom@tromey.com>
6621
6622         * tui/tui-win.c (tui_win_info::max_height)
6623         (tui_cmd_window::max_height): New methods.
6624         (new_height_ok): Call max_height.
6625         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
6626         <max_height>: New method.
6627
6628 2019-06-25  Tom Tromey  <tom@tromey.com>
6629
6630         * tui/tui-win.c (tui_source_window_base::set_new_height)
6631         (tui_data_window::set_new_height): New methods.
6632         (make_invisible_and_set_new_height): Call set_new_height method.
6633         * tui/tui-data.h (struct tui_win_info)
6634         (struct tui_source_window_base, struct tui_data_window)
6635         <set_new_height>: New method.
6636
6637 2019-06-25  Tom Tromey  <tom@tromey.com>
6638
6639         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
6640         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
6641         tui_refresh_data_win.
6642         * tui/tui-win.c (tui_source_window_base::refresh_all): New
6643         method.
6644         (tui_refresh_all_win): Call the refresh_all method.
6645         (tui_set_focus): Likewise.
6646         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
6647         (struct tui_source_window_base, struct tui_data_window) <refresh>:
6648         Likewise.
6649
6650 2019-06-25  Tom Tromey  <tom@tromey.com>
6651
6652         * tui/tui-winsource.h (tui_refill_source_window)
6653         (tui_set_is_exec_point_at): Don't declare.
6654         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
6655         (tui_source_window_base::refill): Rename from
6656         tui_refill_source_window.
6657         (tui_source_window_base::do_scroll_horizontal): Update.
6658         (tui_source_window_base::set_is_exec_point_at): Rename from
6659         tui_set_is_exec_point_at.
6660         (tui_update_all_breakpoint_info): Update.
6661         * tui/tui-stack.c (tui_show_frame_info): Update.
6662         * tui/tui-layout.c (show_data): Add cast.
6663         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
6664         * tui/tui-data.h (struct tui_source_window_base) <refill,
6665         set_is_exec_point_at>: New methods.
6666         (tui_source_windows, tui_add_to_source_windows): Update types.
6667         (tui_add_to_source_windows): Remove redundant declaration.
6668         * tui/tui-data.c (source_windows): Store tui_source_window_base.
6669         (tui_source_windows): Change return type.
6670         (tui_clear_source_windows_detail): Update.
6671         (tui_add_to_source_windows): Change type of parameter.
6672         (tui_free_all_source_wins_content): Update.
6673
6674 2019-06-25  Tom Tromey  <tom@tromey.com>
6675
6676         * tui/tui-wingeneral.c (tui_win_info::refresh)
6677         (tui_source_window_base::refresh): New methods.
6678         (tui_refresh_all): Call the refresh method.
6679         * tui/tui-data.h (struct tui_win_info)
6680         (struct tui_source_window_base) <refresh>: New method.
6681
6682 2019-06-25  Tom Tromey  <tom@tromey.com>
6683
6684         * tui/tui.h (tui_is_window_visible): Return bool.
6685         * tui/tui.c (tui_is_window_visible): Return bool.
6686         * tui/tui-wingeneral.c (tui_make_window, make_visible)
6687         (tui_make_visible, tui_make_invisible)
6688         (tui_win_info::make_visible)
6689         (tui_source_window_base::make_visible, make_all_visible)
6690         (tui_make_all_visible, tui_make_all_invisible): Update.
6691         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
6692         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
6693         bool.
6694         (struct tui_win_info, struct tui_source_window_base)
6695         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
6696         * tui/tui-data.c (tui_init_generic_part): Update.
6697
6698 2019-06-25  Tom Tromey  <tom@tromey.com>
6699
6700         * tui/tui-wingeneral.c (tui_win_info::make_visible)
6701         (tui_source_window_base::make_visible): New methods.
6702         (make_all_visible): Make method call.
6703         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
6704         (struct tui_source_window_base, struct tui_cmd_window): Override
6705         make_visible.
6706         (tui_win_is_source_type): Don't declare.
6707         * tui/tui-data.c (tui_win_is_source_type): Remove.
6708
6709 2019-06-25  Tom Tromey  <tom@tromey.com>
6710
6711         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
6712         NULL check.
6713
6714 2019-06-25  Tom Tromey  <tom@tromey.com>
6715
6716         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
6717         Inline constructor.  Add initializers for members.
6718         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
6719         constructors; now inline in class.
6720
6721 2019-06-25  Tom Tromey  <tom@tromey.com>
6722
6723         * tui/tui-regs.c (tui_show_registers): Update.
6724         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
6725         bool.
6726         * tui/tui-data.c (tui_data_window::clear_detail)
6727         (tui_data_window): Update.
6728
6729 2019-06-25  Tom Tromey  <tom@tromey.com>
6730
6731         * tui/tui-windata.c (tui_display_all_data)
6732         (tui_display_data_from_line, tui_display_data_from)
6733         (tui_check_data_values, tui_data_window::do_scroll_vertical):
6734         Update.
6735         * tui/tui-regs.c (tui_last_regs_line_no)
6736         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
6737         (tui_show_registers, tui_show_register_group)
6738         (tui_display_registers_from, tui_display_reg_element_at_line)
6739         (tui_display_registers_from_line, tui_check_register_values)
6740         (tui_reg_next, tui_reg_prev): Update.
6741         * tui/tui-layout.c (tui_set_layout, show_data): Update.
6742         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
6743         tui_data_window.
6744         (struct tui_win_info) <detail>: Remove.  Add new fields from
6745         tui_data_info.
6746         (TUI_DATA_WIN): Add cast.
6747         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
6748         (~tui_data_window): Simplify.
6749
6750 2019-06-25  Tom Tromey  <tom@tromey.com>
6751
6752         * tui/tui-layout.c (show_source_disasm_command)
6753         (show_source_or_disasm_and_command): Update.
6754         * tui/tui-io.c (update_cmdwin_start_line)
6755         (tui_redisplay_readline): Update.
6756         * tui/tui-data.h (struct tui_command_info): Remove.
6757         (struct tui_win_info) <detail>: Remove command_info member.
6758         (struct tui_data_window) <start_line>: New member, from
6759         tui_command_info.
6760         (TUI_CMD_WIN): Add casts.
6761
6762 2019-06-25  Tom Tromey  <tom@tromey.com>
6763
6764         * tui/tui-winsource.c (tui_update_source_window)
6765         (tui_refill_source_window)
6766         (tui_source_window_base::do_scroll_horizontal)
6767         (tui_update_breakpoint_info, tui_set_exec_info_content)
6768         (tui_show_exec_info_content, tui_erase_exec_info_content)
6769         (tui_clear_exec_info_content): Update.
6770         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
6771         Update.
6772         * tui/tui-win.c (make_invisible_and_set_new_height)
6773         (make_visible_with_new_height): Update.
6774         * tui/tui-source.c (tui_set_source_content)
6775         (tui_show_symtab_source): Update.
6776         * tui/tui-layout.c (extract_display_start_addr)
6777         (show_source_disasm_command, show_data)
6778         (make_source_or_disasm_window)
6779         (show_source_or_disasm_and_command): Update.
6780         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
6781         (tui_disasm_window::do_scroll_vertical): Remove shadowing
6782         "gdbarch".
6783         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
6784         to tui_source_window_base.
6785         (struct tui_win_info) <detail>: Remove source_info member.
6786         (struct tui_source_window_base) <has_locator>: Inline.
6787         Move contents from tui_source_info; rename has_locator member to
6788         m_has_locator.
6789         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
6790         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
6791         header file.
6792         (tui_source_window_base::clear_detail, ~tui_source_window_base):
6793         Simplify.
6794         (tui_free_all_source_wins_content): Cast to
6795         tui_source_window_base.
6796
6797 2019-06-25  Tom Tromey  <tom@tromey.com>
6798
6799         * tui/tui-win.c (make_invisible_and_set_new_height)
6800         (make_visible_with_new_height): Call has_locator method.
6801         * tui/tui-layout.c (show_source_disasm_command, show_data)
6802         (show_source_or_disasm_and_command): Update for bool change.
6803         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
6804         (tui_win_info) <has_locator>: New method.
6805         (struct tui_source_window_base) <has_locator>: New method.
6806         (tui_win_has_locator): Don't declare.
6807         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
6808         from tui_win_has_locator.
6809         (tui_source_window_base): Use false, not FALSE.
6810
6811 2019-06-25  Tom Tromey  <tom@tromey.com>
6812
6813         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
6814         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
6815         clear_detail method directly.
6816         (tui_clear_win_detail): Remove.
6817
6818 2019-06-25  Tom Tromey  <tom@tromey.com>
6819
6820         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
6821         "this", not TUI_DISASM_WIN.
6822
6823 2019-06-25  Tom Tromey  <tom@tromey.com>
6824
6825         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
6826         declare.
6827         * tui/tui-winsource.c
6828         (tui_source_window_base::do_scroll_horizontal): Rename from
6829         tui_horizontal_source_scroll.
6830         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
6831         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
6832         from tui_vertical_data_scroll.
6833         * tui/tui-win.h (tui_scroll): Don't declare.
6834         * tui/tui-win.c (tui_win_info::forward_scroll)
6835         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
6836         (tui_win_info::right_scroll): Rename and update.
6837         (tui_scroll_forward_command, tui_scroll_backward_command)
6838         (tui_scroll_left_command, tui_scroll_right_command): Update.
6839         (tui_scroll): Remove.
6840         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
6841         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
6842         from tui_vertical_source_scroll.
6843         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
6844         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
6845         from tui_vertical_disassem_scroll.
6846         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
6847         do_scroll_horizontal>: New methods.
6848         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
6849         Likewise.
6850         (struct tui_source_window_base): Add do_scroll_horizontal.
6851         (struct tui_source_window, struct tui_disasm_window): Add
6852         do_scroll_vertical.
6853         (struct tui_data_window, struct tui_cmd_window): Add
6854         do_scroll_horizontal and do_scroll_vertical.
6855         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
6856
6857 2019-06-25  Tom Tromey  <tom@tromey.com>
6858
6859         * tui/tui-data.h (struct tui_source_window_base): New struct.
6860         (struct tui_source_window): Derive from tui_source_window_base.
6861         (struct tui_disasm_window): New struct.
6862         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
6863         from tui_source_window::clear_detail.
6864         (tui_source_window_base): Rename from tui_source_window.
6865         (~tui_source_window_base): Rename from ~tui_source_window.
6866         (tui_alloc_win_info): Create a tui_disasm_window.
6867
6868 2019-06-25  Tom Tromey  <tom@tromey.com>
6869
6870         * tui/tui-data.h (struct tui_source_window)
6871         (struct tui_data_window): Declare destructors.
6872         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
6873         destructors.
6874         (tui_win_info): Simplify.
6875
6876 2019-06-25  Tom Tromey  <tom@tromey.com>
6877
6878         * tui/tui-winsource.c (tui_display_main)
6879         (tui_update_source_windows_with_addr)
6880         (tui_update_all_breakpoint_info): Update.
6881         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
6882         (new_height_ok, parse_scrolling_args): Update.
6883         * tui/tui-stack.c (tui_show_frame_info): Update.
6884         * tui/tui-data.h (struct tui_list): Remove.
6885         (tui_source_windows): Return a reference to a std::vector.
6886         * tui/tui-data.c (source_windows): Now a std::vector.
6887         (tui_source_windows): Change return type.
6888         (tui_clear_source_windows): Rewrite.
6889         (tui_clear_source_windows_detail, tui_add_to_source_windows)
6890         (tui_free_all_source_wins_content): Rewrite.
6891
6892 2019-06-25  Tom Tromey  <tom@tromey.com>
6893
6894         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
6895         (struct tui_data_window, struct tui_cmd_window): Declare
6896         clear_detail method.
6897         * tui/tui-data.c (tui_source_window::clear_detail)
6898         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
6899         methods.
6900         (tui_clear_win_detail): Simplify.
6901
6902 2019-06-25  Tom Tromey  <tom@tromey.com>
6903
6904         * tui/tui-layout.c (make_source_window, make_disasm_window)
6905         (make_source_or_disasm_window): Remove win_info_ptr parameter.
6906         Return the new window.
6907         (show_source_disasm_command, show_data)
6908         (show_source_or_disasm_and_command): Update.
6909
6910 2019-06-25  Tom Tromey  <tom@tromey.com>
6911
6912         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
6913         parameter.  Return the new window.
6914         (show_source_disasm_command): Update and remove NULL check.
6915         (show_source_or_disasm_and_command): Update.
6916
6917 2019-06-25  Tom Tromey  <tom@tromey.com>
6918
6919         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
6920
6921 2019-06-25  Tom Tromey  <tom@tromey.com>
6922
6923         * tui/tui-data.h (struct tui_win_info): Make constructor
6924         protected.  Make destructor virtual.  Add initializers.
6925         (tui_source_window, tui_data_window, tui_cmd_window): New
6926         classes.
6927         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
6928         constructor.  Add "type" parameter.
6929         (tui_source_window, tui_data_window, tui_cmd_window): New
6930         constructors.
6931         (tui_alloc_win_info): Instantiate the appropriate subclass.
6932
6933 2019-06-25  Tom Tromey  <tom@tromey.com>
6934
6935         * tui/tui-win.c (tui_resize_all): Use delete.
6936         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
6937         destructor.
6938         (tui_free_window): Don't declare.
6939         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
6940         Update.
6941
6942 2019-06-25  Tom Tromey  <tom@tromey.com>
6943
6944         * tui/tui-data.h (struct tui_win_info): Add constructor.
6945         * tui/tui-data.c (tui_alloc_win_info): Use new.
6946         (tui_free_window): Use delete.
6947
6948 2019-06-22  Tom Tromey  <tom@tromey.com>
6949
6950         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
6951         declare.
6952         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
6953
6954 2019-06-22  Tom Tromey  <tom@tromey.com>
6955
6956         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
6957         declare.
6958         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
6959
6960 2019-06-22  Tom de Vries  <tdevries@suse.de>
6961
6962         * dwarf2read.c (create_addrmap_from_aranges)
6963         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
6964         instead of '%zu'.
6965
6966 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
6967
6968         * dwarf2read.h (dwarf2_section_info_def): Remove.
6969         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
6970         * dwarf2read.c (struct dwo_sections) <types>: Change type to
6971         std::vector<dwarf2_section_info>.
6972         (struct dwo_file) <~dwo_file>: Remove.
6973         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
6974         types field.
6975         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
6976         (dwarf2_read_debug_names): Likewise.
6977         (create_debug_types_hash_table): Change parameter type to
6978         array_view, adjust code accordingly.
6979         (dwarf2_locate_dwo_sections): Adjust to std::vector.
6980         (partial_die_info::fixup): Likewise.
6981         (determine_prefix): Likewise.
6982         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
6983
6984 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
6985
6986         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
6987         gdb_bfd_ref_ptr.
6988         <~dwo_file>: Remove call to gdb_bfd_unref.
6989         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
6990         gdb_bfd_ref_ptr::get.
6991
6992 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
6993
6994         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
6995         type to htab_up.
6996         * dwarf2read.c (struct dwo_file): Initialize fields.
6997         <~dwo_file>: New.
6998         (free_dwo_file): Remove, move content to ~dwo_file.
6999         (struct dwo_file_deleter): Remove.
7000         (dwo_file_up>: Remove custom deleter.
7001         (free_dwo_files): Remove.
7002         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
7003         dwo_files.
7004         (process_skeletonless_type_units): Call unique_ptr::get.
7005         (allocate_dwo_file_hash_table): Add deleter to created hash
7006         table.  Change return type to htab_up.
7007         (lookup_dwo_file_slot): Don't memset dwo_file, call
7008         unique_ptr::get.
7009         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
7010         (create_dwo_unit_in_dwp_v2): Likewise.
7011         (open_and_init_dwo_file): Likewise.
7012         (free_dwo_file_from_slot): Remove.
7013
7014 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
7015
7016         * dwarf2read.h (struct dwarf2_section_info) <readin,
7017         is_virtual>: Change type to bool.
7018         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
7019         true instead of 1.
7020
7021 2019-06-19  Tom Tromey  <tom@tromey.com>
7022
7023         * tui/tui-data.h (tui_init_content_element): Don't declare.
7024
7025 2019-06-19  Tom Tromey  <tom@tromey.com>
7026
7027         * tui/tui-data.h (tui_init_win_info): Don't declare.
7028
7029 2019-06-19  Tom de Vries  <tdevries@suse.de>
7030
7031         * dwarf2read.h (abstract_to_concrete): Change type to
7032         std::unordered_map<sect_offset, std::vector<sect_offset>,
7033         gdb::hash_enum<sect_offset>>.
7034
7035 2019-06-19  Tom Tromey  <tromey@adacore.com>
7036
7037         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
7038         EVAL_AVOID_SIDE_EFFECTS specially.
7039
7040 2019-06-19  Tom Tromey  <tromey@adacore.com>
7041
7042         * source-cache.c (highlighter): New global.
7043         (source_cache::get_source_lines): Create a highlighter on demand.
7044
7045 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
7046
7047         * defs.h (deprecated_interactive_hook): Delete declaration.
7048         * interps.c (clear_interpreter_hooks): Remove use of
7049         deprecated_interactive_hook.
7050         * top.c (deprecated_interactive_hook): Delete definition.
7051         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
7052
7053 2019-06-18  Tom de Vries  <tdevries@suse.de>
7054
7055         PR gdb/24515
7056         * dwarf2read.h (abstract_to_concrete): Change type from
7057         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
7058         std::unordered_map<sect_offset, std::vector<sect_offset>>.
7059         * dwarf2read.c (read_variable): Update.
7060         (dwarf2_fetch_die_loc_sect_off): Update.
7061
7062 2019-06-17  Tom de Vries  <tdevries@suse.de>
7063
7064         PR gdb/24617
7065         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
7066         accessing parent[parent_len - 1].
7067
7068 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
7069
7070         PR gdb/24364
7071         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
7072         call dtrace_process_dof with NULL dof.
7073
7074 2019-06-16  Tom de Vries  <tdevries@suse.de>
7075
7076         PR gdb/24445
7077         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
7078
7079 2019-06-16  Tom Tromey  <tom@tromey.com>
7080
7081         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
7082         (make_all_visible): Use address of member.
7083
7084 2019-06-16  Tom Tromey  <tom@tromey.com>
7085
7086         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
7087         (tui_free_window, free_content, free_content_elements): Remove
7088         unnecessary cast.
7089         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
7090         cast.
7091         * tui/tui-regs.c (tui_show_register_group)
7092         (tui_display_registers_from, tui_display_reg_element_at_line):
7093         Remove unnecessary cast.
7094
7095 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
7096
7097         * linux-nat.c (normal_mask): Delete.
7098         (_initialize_linux_nat): Don't initialise normal_mask.
7099
7100 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
7101
7102         PR gdb/24445
7103         * dwarf-index-write.h (write_psymtabs_to_index): Add
7104         dwz_basename parameter.
7105         * dwarf-index-write.c (write_gdbindex): Move file writing to
7106         write_gdbindex_1.  Change return type void.
7107         (assert_file_size): Move up, remove filename parameter.
7108         (write_gdbindex_1): New function.
7109         (write_debug_names): Change return type to void, call
7110         assert_file_size.
7111         (struct index_wip_file): New struct.
7112         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
7113         file logic to index_wip_file.  Write index for dwz file if
7114         needed.
7115         (save_gdb_index_command): Pass basename of dwz file, if present.
7116         * dwarf-index-cache.c (index_cache::store): Obtain and pass
7117         build-id of dwz file, if present.
7118         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
7119         (dwarf2_get_dwz_file): Likewise.
7120         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
7121         (dwarf2_get_dwz_file): Likewise.
7122
7123 2019-06-16  Tom Tromey  <tom@tromey.com>
7124
7125         * coffread.c (process_coff_symbol): Use xstrdup.
7126         * value.c (create_internalvar): Use xstrdup.
7127
7128 2019-06-16  Tom Tromey  <tom@tromey.com>
7129
7130         * valops.c (value_cast, value_slice): Remove unnecessary cast.
7131         * breakpoint.c (stopin_command, stopat_command)
7132         (until_break_command, decode_location_default): Remove unnecessary
7133         cast.
7134         * utils.c (subset_compare): Remove unnecessary cast.
7135         * ada-lang.c (ada_update_initial_language): Remove unnecessary
7136         cast.
7137         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
7138         cast.
7139         * infcmd.c (path_command): Remove unnecessary cast.
7140         * coffread.c (decode_type): Remove unnecessary cast.
7141         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
7142         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
7143         * tui/tui-stack.c (tui_show_locator_content)
7144         (tui_show_frame_info): Remove unnecessary cast.
7145         * tui/tui-win.c (tui_scroll_forward_command)
7146         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
7147         (parse_scrolling_args): Remove unnecessary cast.
7148         * tui/tui-data.c (init_win_info, tui_del_window)
7149         (tui_free_window, tui_del_data_windows, tui_free_data_content)
7150         (free_content_elements): Remove unnecessary cast.
7151         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
7152         unnecessary cast.
7153         * tui/tui-source.c (tui_set_source_content)
7154         (tui_vertical_source_scroll): Remove unnecessary cast.
7155         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
7156         cast.
7157         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
7158         * tui/tui-regs.c (tui_display_registers_from)
7159         (tui_display_register): Remove unnecessary cast.
7160         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
7161         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
7162         (make_visible): Remove unnecessary cast.
7163         * tui/tui-winsource.c (tui_erase_source_content)
7164         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
7165         unnecessary cast.
7166         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
7167         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
7168         * stabsread.c (read_type, read_array_type, read_range_type):
7169         Remove unnecessary cast.
7170         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
7171         (parse_symbol, parse_type, upgrade_type, parse_external)
7172         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
7173         unnecessary cast.
7174         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
7175
7176 2019-06-16  Tom Tromey  <tom@tromey.com>
7177
7178         * tui/tui-data.c (tui_alloc_generic_win_info)
7179         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
7180         checks.
7181
7182 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
7183             Andrew Burgess  <andrew.burgess@embecosm.com>
7184
7185         * f-typeprint.c (f_print_type): Don't return early for not
7186         associated or not allocated types.
7187         (f_type_print_varspec_suffix): Add print_rank parameter and print
7188         ranks of array types in case they dangling.
7189         (f_type_print_base): Add print_rank parameter.
7190
7191 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
7192
7193         * NEWS: Mention new MI commands.
7194         * break-catch-throw.c (enum exception_event_kind): Move to
7195         breakpoint.h.
7196         (print_mention_exception_catchpoint): Output text as a single
7197         message.
7198         (catch_exception_command_1): Rename to...
7199         (catch_exception_event): ...this, make non-static, update header
7200         command, and change some parameter types.
7201         (catch_catch_command): Update for changes to
7202         catch_exception_command_1.
7203         (catch_throw_command): Likewise.
7204         (catch_rethrow_command): Likewise.
7205         * breakpoint.c (enum exception_event_kind): Delete.
7206         * breakpoint.h (enum exception_event_kind): Moved here from
7207         break-catch-throw.c.
7208         (catch_exception_event): Declare.
7209         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
7210         (mi_cmd_catch_throw): New function.
7211         (mi_cmd_catch_rethrow): New function.
7212         (mi_cmd_catch_catch): New function.
7213         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
7214         'catch-catch' entries.
7215         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
7216         (mi_cmd_catch_rethrow): Declare.
7217         (mi_cmd_catch_catch): Declare.
7218
7219 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
7220
7221         * annotate.c (annotate_source_line): Change return type to void,
7222         update implementation to match.
7223         * annotate.h (annotate_source_line): Change return type to void,
7224         update header comment.
7225         * stack.c (print_frame_info): Don't change what frame information
7226         is printed based on whether annotations are on or not.
7227
7228 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
7229
7230         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
7231         (annotate_source): Make static.
7232         (annotate_source_line): Moved from source.c and renamed from
7233         identify_source_line.  Update the return type.
7234         * annotate.h (annotate_source): Delete declaration.
7235         (annotate_source_line): Declaration moved from source.h, and
7236         renamed from identify_source_line.  Return type updated.
7237         * source.c (identify_source_line): Moved to annotate.c and renamed
7238         to annotate_source_line.
7239         (info_line_command): Remove check of annotation_level.
7240         * source.h (identify_source_line): Move declaration to annotate.h
7241         and rename to annotate_source_line.
7242         * stack.c: Add 'annotate.h' include.
7243         (print_frame_info): Remove check of annotation_level before
7244         calling annotate_source_line.
7245
7246 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
7247
7248         * source-cache.c (source_cache::get_plain_source_lines): Use
7249         open_source_file_with_line_charpos instead of just
7250         open_source_file, remove call to find_source_lines.
7251         (source_cache::get_source_lines): Likewise.
7252         * source.c (find_source_lines): Make static.
7253         (get_filename_and_charpos): Renamed into...
7254         (open_source_file_with_line_charpos): ..this along with changes to
7255         return a scoped_fd, and some other minor clean ups.
7256         (identify_source_line): Use open_source_file_with_line_charpos.
7257         (search_command_helper): Use open_source_file_with_line_charpos
7258         instead of just open_source_file, remove call to
7259         find_source_lines.
7260         * source.h (open_source_file_with_line_charpos): Declare new
7261         function.
7262         (find_source_lines): Delete declaration.
7263
7264 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
7265
7266         * source.c (get_filename_and_charpos): Remove fullname
7267         parameter.
7268         (identify_source_line): Update call to get_filename_and_charpos.
7269
7270 2019-06-14  Tom Tromey  <tromey@adacore.com>
7271
7272         PR gdb/24502:
7273         * ui-style.h (skip_ansi_escape): Update comment.
7274         * ui-file.h (class no_terminal_escape_file): New class.
7275         * ui-file.c (no_terminal_escape_file::write)
7276         (no_terminal_escape_file::puts): New methods.
7277         * cli/cli-logging.c (handle_redirections): Use
7278         no_terminal_escape_file.
7279
7280 2019-06-14  Tom Tromey  <tromey@adacore.com>
7281
7282         * NEWS: Move convenience variable news above Python news.
7283
7284 2019-06-14  Tom Tromey  <tom@tromey.com>
7285
7286         * gnulib: Move directory to top-level.
7287         * configure.ac: Don't configure gnulib.
7288         * configure: Rebuild.
7289         * common/common-defs.h: Use new path to gnulib.
7290         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
7291         (GNULIB_H): Remove.
7292         (INCGNU): Look in new gnulib location.
7293         (HFILES_NO_SRCDIR): Remove gnulib files.
7294         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
7295         (generated_files): Remove GNULIB_H.
7296         ($(LIBGNU), all-lib): Remove targets.
7297         (distclean): Don't mention GNULIB_BUILDDIR.
7298         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
7299
7300 2019-06-14  Tom Tromey  <tromey@adacore.com>
7301
7302         * symfile.c (add_symbol_file_command): Remove obsolete comment.
7303         Warn if symbol file does not provide any symbols.
7304
7305 2019-06-14  Tom Tromey  <tromey@adacore.com>
7306
7307         * source.c (find_and_open_source): Respect basenames_may_differ.
7308
7309 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
7310
7311         * annotate.c (annotate_breakpoints_invalid): Make use of
7312         scoped_restore_terminal_state.
7313         (annotate_frames_invalid): Likewise.
7314
7315 2019-06-14  Tom Tromey  <tromey@adacore.com>
7316
7317         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
7318         allow assignment to an internalvar.
7319
7320 2019-06-14  Tom Tromey  <tromey@adacore.com>
7321
7322         * ada-lex.l: Allow "_" in attribute names.
7323
7324 2019-06-14  Tom Tromey  <tromey@adacore.com>
7325
7326         PR gdb/24653:
7327         * regcache.c (registers_changed): Don't call alloca.
7328         * top.c (execute_command): Don't call alloca.
7329
7330 2019-06-13  Pedro Alves  <palves@redhat.com>
7331
7332         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
7333         'expression'.  When parsing an expression, error out if there's
7334         junk after "unlimited".
7335         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
7336         (do_set_command): Adjust calls to is_unlimited_literal.
7337
7338 2019-06-13  Pedro Alves  <palves@redhat.com>
7339
7340         * compile/compile.c (make_compile_options_def_group): Add braces
7341         around array_view initializer.
7342         * thread.c (make_thread_apply_all_options_def_group)
7343         (make_thread_apply_all_options_def_group): Likewise.
7344
7345 2019-06-13  Pedro Alves  <palves@redhat.com>
7346
7347         * NEWS (New commands): Mention "maint test-options
7348         require-delimiter", "maint test-options unknown-is-error", "maint
7349         test-options unknown-is-operand" and "maint show
7350         test-options-completion-result".
7351         (New command options, command completion): New section.
7352         (Completion improvements): New section.
7353         Mention that you can abbreviate "unlimited".
7354
7355 2019-06-13  Pedro Alves  <palves@redhat.com>
7356
7357         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
7358         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
7359         * unittests/cli-utils-selftests.c (test_parse_flags)
7360         (test_parse_flags_qcs): Delete.
7361         (test_cli_utils): Don't call deleted functions.
7362
7363 2019-06-13  Pedro Alves  <palves@redhat.com>
7364
7365         * thread.c: Include "cli/cli-option.h".
7366         (tp_array_compar_ascending): Global.
7367         (tp_array_compar): Delete function.
7368         (tp_array_compar_ascending, tp_array_compar_descending): New
7369         functions.
7370         (ascending_option_def, qcs_flag_option_def)
7371         (thr_qcs_flags_option_defs)
7372         (make_thread_apply_all_options_def_group)
7373         (make_thread_apply_options_def_group): New.
7374         (thread_apply_all_command): Use gdb::option::process_options.
7375         (thread_apply_command_completer)
7376         (thread_apply_all_command_completer): New.
7377         (thread_apply_command): Use gdb::option::process_options.
7378         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
7379         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
7380         to generate help text of "thread apply".  Adjust "taas"'s help.
7381         * tid-parse.c (tid_range_parser::in_thread_range): New method.
7382         * tid-parse.h (tid_range_parser::in_thread_range): New method.
7383
7384 2019-06-13  Pedro Alves  <palves@redhat.com>
7385
7386         * thread.c (thread_apply_command): Check for invalid TID with
7387         isdigit instead of !isalpha.
7388
7389 2019-06-13  Pedro Alves  <palves@redhat.com>
7390
7391         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
7392         (validate_flags_qcs): New.
7393         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
7394         (validate_flags_qcs): Declare.
7395         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
7396         (make_frame_apply_options_def_group): New.
7397         (frame_apply_command_count): Process options with
7398         gdb::option::process_options.
7399         (frame_apply_completer): New.
7400         (frame_apply_level_completer, frame_apply_all_completer)
7401         (frame_apply_completer): New.
7402         (_initialize_stack): Update help of "frame apply", "frame apply
7403         level", "frame apply all" and "faas" to mention supported options
7404         and install command completers.
7405         * stack.h (frame_apply_all_completer): Declare.
7406         * thread.c: Include "stack.h".
7407         (tfaas_command): Add "--".
7408         (_initialize_thread): Update help "tfaas" to mention supported
7409         options and install command completer.
7410
7411 2019-06-13  Pedro Alves  <palves@redhat.com>
7412
7413         * completer.c (complete_nested_command_line): New.
7414         (gdb_completion_word_break_characters_throw): Add assertion.
7415         * completer.h (complete_nested_command_line): Declare.
7416
7417 2019-06-13  Pedro Alves  <palves@redhat.com>
7418
7419         * stack.c (parse_backtrace_qualifiers): New.
7420         (backtrace_command): Use it.
7421         (backtrace_command_completer): Complete on qualifiers.
7422
7423 2019-06-13  Pedro Alves  <palves@redhat.com>
7424
7425         * frame.c: Include "cli/cli-option.h.
7426         (user_set_backtrace_options): New.
7427         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
7428         Delete.
7429         (get_prev_frame): Adjust.
7430         (boolean_option_def, uinteger_option_def)
7431         (set_backtrace_option_defs): New.
7432         (_initialize_frame): Adjust and use
7433         gdb::option::add_setshow_cmds_for_options to install "set
7434         backtrace past-main" and "set backtrace past-entry".
7435         * frame.h: Include "cli/cli-option.h".
7436         (struct frame_print_options): Forward declare.
7437         (print_frame_arguments_all, print_frame_arguments_scalars)
7438         (print_frame_arguments_none): Declare.
7439         (print_entry_values): Delete declaration.
7440         (struct frame_print_options, user_frame_print_options): New.
7441         (struct set_backtrace_options): New.
7442         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
7443         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
7444         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
7445         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
7446         (list_args_or_locals): Add frame_print_options parameter.
7447         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
7448         * python/py-framefilter.c (enumerate_args): Pass down
7449         USER_FRAME_PRINT_OPTIONS.
7450         * stack.c: Include "cli/cli-option.h".
7451         (print_frame_arguments_all, print_frame_arguments_scalars)
7452         (print_frame_arguments_none): Declare.
7453         (print_raw_frame_arguments, print_entry_values): Delete.
7454         (user_frame_print_options): New.
7455         (boolean_option_def, enum_option_def, frame_print_option_defs):
7456         New.
7457         (struct backtrace_cmd_options): New.
7458         (bt_flag_option_def): New.
7459         (backtrace_command_option_defs): New.
7460         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
7461         (print_frame_arg, read_frame_arg, print_frame_args)
7462         (print_frame_info, print_frame): Add frame_print_options parameter
7463         and use it.
7464         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
7465         (backtrace_command_1): Add frame_print_options and
7466         backtrace_cmd_options parameters and use them.
7467         (make_backtrace_options_def_group): New.
7468         (backtrace_command): Process command options with
7469         gdb::option::process_options.
7470         (backtrace_command_completer): New.
7471         (_initialize_stack): Extend "backtrace"'s help to mention
7472         supported options.  Install completer for "backtrace".
7473         Install some settings commands with add_setshow_cmds_for_options.
7474
7475 2019-06-13  Pedro Alves  <palves@redhat.com>
7476
7477         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
7478         and that "set/show print raw frame-arguments" are now deprecated.
7479
7480         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
7481         command.
7482         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
7483         * stack.c (_initialize_stack): Install "set/show print
7484         raw-frame-arguments", and deprecate "set/show print raw
7485         frame-arguments".
7486         * valprint.c (_initialize_valprint): Deprecate "set/show print
7487         raw".
7488
7489 2019-06-13  Pedro Alves  <palves@redhat.com>
7490
7491         * compile/compile.c (struct compile_options): New.
7492         (compile_flag_option_def, compile_command_option_defs)
7493         (make_compile_options_def_group): New.
7494         (compile_file_command): Handle options with
7495         gdb::option::process_options.
7496         (compile_file_command_completer): New function.
7497         (compile_code_command): Handle options with
7498         gdb::option::process_options.
7499         (compile_code_command_completer): New function.
7500         (_initialize_compiler): Install completers for "compile code" and
7501         "compile file".  Mention available options in "compile code" and
7502         "compile code"'s help.
7503         * completer.c (advance_to_completion_word): New, factored out from
7504         ...
7505         (advance_to_expression_complete_word_point): ... this.
7506         (advance_to_filename_complete_word_point): New.
7507         * completer.h (advance_to_filename_complete_word_point): New
7508         declaration.
7509
7510 2019-06-13  Pedro Alves  <palves@redhat.com>
7511
7512         * compile/compile.c: Include "cli/cli-option.h".
7513         (compile_print_value): Scope data pointer is now a
7514         value_print_options pointer; adjust.
7515         (compile_print_command): Process options.  Scope data pointer is
7516         now a value_print_options pointer; adjust.
7517         (_initialize_compile): Update "compile print"'s help to include
7518         supported options.  Install a completer for "compile print".
7519         * cp-valprint.c (show_vtblprint, show_objectprint)
7520         (show_static_field_print): Delete.
7521         (_initialize_cp_valprint): Don't install "set print
7522         static-members", "set print vtbl", "set print object" here.
7523         * printcmd.c: Include "cli/cli-option.h" and
7524         "common/gdb_optional.h".
7525         (print_command_parse_format): Rework to fill in a
7526         value_print_options instead of a format_data.
7527         (print_value): Change parameter type from format_data pointer to
7528         value_print_options reference.  Adjust.
7529         (print_command_1): Process options.  Adjust to pass down a
7530         value_print_options.
7531         (print_command_completer): New.
7532         (_initialize_printcmd): Install print_command_completer as
7533         handle_brkchars completer for the "print" command.  Update
7534         "print"'s help to include supported options.
7535         * valprint.c: Include "cli/cli-option.h".
7536         (show_vtblprint, show_objectprint, show_static_field_print): Moved
7537         here from cp-valprint.c.
7538         (boolean_option_def, uinteger_option_def)
7539         (value_print_option_defs, make_value_print_options_def_group):
7540         New.  Use gdb::option::add_setshow_cmds_for_options to install
7541         "set print elements", "set print null-stop", "set print repeats",
7542         "set print pretty", "set print union", "set print array", "set
7543         print address", "set print symbol", "set print array-indexes".
7544         * valprint.h: Include <string> and "cli/cli-option.h".
7545         (make_value_print_options_def_group): Declare.
7546         (print_value): Change parameter type from format_data pointer to
7547         value_print_options reference.
7548         (print_command_completer): Declare.
7549
7550 2019-06-13  Pedro Alves  <palves@redhat.com>
7551
7552         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
7553         (COMMON_SFILES): Add maint-test-settings.c.
7554         * cli/cli-decode.c (boolean_enums): New global, factored out from
7555         ...
7556         (add_setshow_boolean_cmd): ... here.
7557         * cli/cli-decode.h (boolean_enums): Declare.
7558         * cli/cli-option.c: New file.
7559         * cli/cli-option.h: New file.
7560         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
7561         factored out from ...
7562         (parse_cli_boolean_value(const char *)): ... this.
7563         (is_unlimited_literal): Change parameter type to pointer to
7564         pointer.  Adjust and advance ARG pointer.
7565         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
7566         (parse_cli_var_enum): New, factored out from ...
7567         (do_set_command): ... this.  Adjust.
7568         * cli/cli-setshow.h (parse_cli_boolean_value)
7569         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
7570         (parse_cli_var_enum): Declare.
7571         * cli/cli-utils.c: Include "cli/cli-option.h".
7572         (get_ulongest): New.
7573         * cli/cli-utils.h (get_ulongest): Declare.
7574         (check_for_argument): New overloads.
7575         * maint-test-options.c: New file.
7576
7577 2019-06-13  Pedro Alves  <palves@redhat.com>
7578
7579         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
7580         parse a range if "-" is at the end of the string.
7581
7582 2019-06-13  Pedro Alves  <palves@redhat.com>
7583
7584         * cli/cli-setshow.c (parse_auto_binary_operation)
7585         (parse_cli_boolean_value): Don't allow "o".
7586
7587 2019-06-13  Pedro Alves  <palves@redhat.com>
7588
7589         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
7590         * NEWS: Mention maint test-settings KIND.
7591         * maint-test-settings.c: New file.
7592
7593 2019-06-13  Pedro Alves  <palves@redhat.com>
7594
7595         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
7596         completer.
7597         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
7598         "set" completers.
7599
7600 2019-06-13  Pedro Alves  <palves@redhat.com>
7601
7602         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
7603         after item.
7604
7605 2019-06-13  Pedro Alves  <palves@redhat.com>
7606
7607         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
7608
7609 2019-06-13  Pedro Alves <palves@redhat.com>
7610
7611         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
7612         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
7613         call.
7614         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
7615         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
7616         calls.
7617         (check_for_argument): Skip spaces after argument.
7618
7619 2019-06-13  Pedro Alves  <palves@redhat.com>
7620
7621         * thread.c (thread_apply_command): Adjust TID parsing.
7622         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
7623         detected before end of string.
7624         (tid_is_in_list): Error out if LIST is invalid.
7625
7626 2019-06-13  Pedro Alves  <palves@redhat.com>
7627
7628         * completer.c (complete_line_internal_1): Rewind completion word
7629         point.
7630         (completion_tracker::advance_custom_word_point_by): Change
7631         parameter type to int.
7632         * completer.h (completion_tracker::advance_custom_word_point_by):
7633         Likewise.
7634
7635 2019-06-13  Pedro Alves  <palves@redhat.com>
7636
7637         * completer.c (advance_to_completion_word): Handle delimiters.
7638
7639 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
7640
7641         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
7642
7643 2019-06-11  Tom Tromey  <tom@tromey.com>
7644
7645         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
7646         (xmalloc_failed): Move to alloc.c.
7647         * alloc.c: New file.
7648         * Makefile.in (COMMON_SFILES): Add alloc.c.
7649
7650 2019-06-11  Tom Tromey  <tom@tromey.com>
7651
7652         * nat/linux-waitpid.c: Don't include server.h.
7653         (linux_debug): Remove.
7654         (my_waitpid): Update.
7655
7656 2019-06-11  Tom Tromey  <tromey@adacore.com>
7657
7658         * infcall.c (_initialize_infcall): Remove trailing newline from
7659         help.
7660         * user-regs.c (_initialize_user_regs): Remove trailing newline
7661         from help.
7662         * typeprint.c (_initialize_typeprint): Remove trailing newline
7663         from help.
7664         * reverse.c (_initialize_reverse): Remove trailing newlines from
7665         help.
7666         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
7667         from help.
7668         * language.c (add_set_language_command): Remove trailing newline
7669         from help.
7670         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
7671         help.
7672         * disasm.c (_initialize_disasm): Remove trailing newline from
7673         help.
7674         * top.c (init_main): Remove trailing newline from help.
7675         * interps.c (_initialize_interpreter): Remove trailing newline
7676         from help.
7677         * btrace.c (_initialize_btrace): Remove trailing newlines from
7678         help.
7679         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
7680         from help.
7681         * python/python.c (_initialize_python): Remove trailing newline
7682         from help.
7683         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
7684         help.
7685         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
7686         from help.  Reformat some text.
7687         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
7688         from help.
7689         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
7690         newline from help.
7691
7692 2019-06-11  Tom Tromey  <tromey@adacore.com>
7693
7694         * darwin-nat.c (darwin_decode_exception_message)
7695         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
7696
7697 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
7698
7699         * valops.c (value_slice): Check for not allocated or not
7700         associated values.
7701
7702 2019-06-10  Tom de Vries  <tdevries@suse.de>
7703
7704         PR gdb/24618
7705         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
7706         sure an empty slot (defined by a 32-bit zero pair) is recognized as
7707         invalid.
7708
7709 2019-06-10  Tom de Vries  <tdevries@suse.de>
7710
7711         PR gdb/24611
7712         * linespec.c (linespec_lexer_lex_string): Remove incorrect
7713         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
7714
7715 2019-06-10  Tom de Vries  <tdevries@suse.de>
7716
7717         PR symtab/24545
7718         * symtab.c (struct demangled_name_entry): Add language field.
7719         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
7720         static minimal symbol".  Set and use language field.
7721
7722 2019-06-10  Tom Tromey  <tromey@adacore.com>
7723
7724         * ada-lang.c (_initialize_ada_language): Update help text.
7725
7726 2019-06-10  Tom Tromey  <tromey@adacore.com>
7727
7728         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
7729         with a newline.
7730         * guile/guile.c (handle_boot_error): Don't end warning with a
7731         newline.
7732         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
7733         warning with a newline.
7734         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
7735         newline.
7736         (s12z_frame_cache): Likewise.
7737         * dwarf-index-cache.c (index_cache::store): Don't end warning with
7738         a newline.
7739         * solib-svr4.c (disable_probes_interface): Don't end warning with
7740         a newline.
7741         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
7742         newline.
7743         * python/python.c (do_finish_initialization): Don't end warning
7744         with a newline.
7745
7746 2019-06-10  Tom Tromey  <tom@tromey.com>
7747
7748         * python/py-breakpoint.c (gdbpy_breakpoint_created)
7749         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
7750         gdbpy_enter.
7751
7752 2019-06-10  Tom Tromey  <tromey@adacore.com>
7753
7754         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
7755         data.
7756         (elf_new_init): Don't call stabsread_new_init.
7757         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
7758         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
7759         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
7760
7761 2019-06-10  Tom de Vries  <tdevries@suse.de>
7762
7763         PR symtab/16264
7764         PR symtab/24517
7765         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
7766
7767 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
7768
7769         * source.c (find_and_open_source): Also rewrite relative file
7770         names.
7771
7772 2019-04-26  Amos Bird  <amosbird@gmail.com>
7773
7774         * annotate.c (annotate_thread_exited): Add "thread-exited"
7775         annotation.
7776
7777 2019-06-06  Tom Tromey  <tromey@adacore.com>
7778
7779         * maint.h (class scoped_command_stats): Use
7780         DISABLE_COPY_AND_ASSIGN.
7781         <print_time>: New method.
7782         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
7783         print_time.
7784         (scoped_command_stats::print_time): New method.
7785
7786 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
7787
7788         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
7789         instructions of lengths 6 or 8 bytes.
7790
7791 2019-06-04  Pedro Alves  <palves@redhat.com>
7792
7793         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
7794
7795         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
7796         * breakpoint.c (condition_completer): Likewise.
7797         * cli/cli-dump.c (scan_expression): Likewise.
7798         * common/filestuff.c (mkdir_recursive): Likewise.
7799         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
7800         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
7801         (gdb_abspath): Likewise.
7802         * compile/compile-cplus-types.c
7803         (compile_cplus_instance::decl_name): Likewise.
7804         * completer.c (complete_explicit_location):
7805         (signal_completer, reg_or_group_completer_1): Likewise.
7806         * cp-support.c (cp_remove_params_if_any): Likewise.
7807         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
7808         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
7809         * infcmd.c (strip_bg_char): Likewise.
7810         * linespec.c (copy_token_string): Likewise.
7811         * mi/mi-main.c (output_cores): Likewise.
7812         * psymtab.c (psymtab_search_name):
7813         * symfile.c (test_set_ext_lang_command): Likewise.
7814         * target.c (target_fileio_read_stralloc): Likewise.
7815         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
7816         * value.c (complete_internalvar): Likewise.
7817
7818 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
7819
7820         Add objfile property to gdb.Type.
7821         * NEWS: Mention Python API addition.
7822         * python/py-type.c (typy_get_objfile): New method.
7823
7824 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7825
7826         * NEWS: Mention the new set|show style [title|highlight].
7827         Mention changes to "show style", "help" and "apropos".
7828
7829 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7830
7831         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
7832         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
7833         instead of print_help_for_command.
7834         (print_doc_of_command): New function.
7835         (help_list): Add 'apropos -v word' suggestion.
7836         (print_help_for_command): Style the command name using title style.
7837         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
7838         (_initialize_cli_cmds): Describe -v in apropos_command help.
7839
7840 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7841
7842         * cli/cli-style.h (cli_style_option): Add name in constructor,
7843         add m_name class member, add constructor with intensity,
7844         add name class function.
7845         (cli_style_option::add_setshow_commands): Remove name argument.
7846         (highlight_style, title_style): New styles.
7847         * cli/cli-style.c (do_show): New function that shows a style
7848         characteristic styling the style name with itself.
7849         (set_style_name): New function.
7850         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
7851         Update all callers according to the changes in cli/cli-style.h.
7852         * utils.h (fputs_highlighted): New function.
7853         * utils.c (fputs_highlighted): Likewise.
7854
7855 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7856
7857         * NEWS: Mention new pipe command and new convenience variables.
7858
7859 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7860
7861         * cli/cli-cmds.c (pipe_command): New function.
7862         (_initialize_cli_cmds): Call add_com for pipe_command.
7863         Define | as an alias for pipe.
7864         (exit_status_set_internal_vars): New function.
7865         (shell_escape): Call exit_status_set_internal_vars.
7866         cli/cli-decode.c (find_command_name_length): Recognize | as
7867         a single character command.
7868
7869 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7870
7871         * gdbcmd.h (execute_command_to_ui_file): New declaration.
7872         top.c (execute_command_to_ui_file): New function, mostly a copy
7873         of execute_command_to_string.
7874         (execute_command_to_string): Implement by calling
7875         execute_command_to_ui_file.
7876
7877 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7878
7879         * top.h (saved_command_line): Remove declaration.
7880         * top.c (previous_saved_command_line, previous_repeat_arguments):
7881         New variables.
7882         (saved_command_line): Make static, define together with other
7883         'repeat variables'.
7884         (dont_repeat): Clear repeat_arguments.
7885         (repeat_previous, get_saved_command_line, save_command_line):
7886         New functions.
7887         (gdb_init): Initialize saved_command_line
7888         and previous_saved_command_line.
7889         * main.c (captured_main_1): Remove saved_command_line initialization.
7890         * event-top.c (handle_line_of_input): Update to use
7891         the new 'repeat' related functions instead of direct access to
7892         saved_command_line.
7893         * command.h (repeat_previous, get_saved_command_line,
7894         save_command_line): New declarations.
7895         (dont_repeat): Add comment.
7896
7897 2019-05-30  Tom Tromey  <tromey@adacore.com>
7898
7899         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
7900         Fix comment.
7901         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
7902
7903 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
7904
7905         PR cli/24587
7906         * completer.c (complete): Initialize variable word.
7907
7908 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
7909
7910         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
7911         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
7912         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
7913         'body' is NULL to the outter 'if', protecting the '!is_define'
7914         situation as well.
7915
7916 2019-05-29  Tom Tromey  <tromey@adacore.com>
7917
7918         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
7919         (dwarf_unknown): New function.
7920         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
7921         (dwarf_type_encoding_name): Use dwarf_unknown.
7922
7923 2019-05-29  Tom Tromey  <tromey@adacore.com>
7924
7925         PR c++/20020:
7926         * cp-valprint.c (cp_print_value_fields): Call
7927         cp_print_static_field inside "try".
7928
7929 2019-05-29  Tom Tromey  <tromey@adacore.com>
7930
7931         * inflow.c (struct terminal_info): Add default operator=.
7932         * configure: Rebuild.
7933         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
7934         -Wdeprecated-copy-dtor, -Wredundant-move.
7935
7936 2019-05-29  Tom Tromey  <tromey@adacore.com>
7937
7938         * NEWS: Add entry.
7939         * infcmd.c (print_return_value_1): Handle finish_print
7940         option.
7941         (show_print_finish): New function.
7942         (_initialize_infcmd): Add "set/show print finish" commands.
7943         * valprint.c (user_print_options): Initialize new member.
7944         * valprint.h (struct value_print_options) <finish_print>: New
7945         member.
7946
7947 2019-05-28  Tom Tromey  <tromey@adacore.com>
7948
7949         * ada-lang.c (ada_remove_Xbn_suffix)
7950         (find_old_style_renaming_symbol)
7951         (parse_old_style_renaming): Remove.
7952         (ada_find_renaming_symbol): Don't call
7953         find_old_style_renaming_symbol.
7954         (ada_is_renaming_symbol): Rename from
7955         ada_find_renaming_symbol.  Remove "block" parameter.  Return
7956         bool.  Now static.
7957         (ada_read_var_value): Update and simplify.
7958         * ada-exp.y (write_var_or_type): Remove old code.
7959
7960 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
7961
7962         PR gdb/25010
7963         * event-top.c: Remove include comment.
7964         * inflow.c (class scoped_ignore_sigttou): Move from here...
7965         * inflow.h (class scoped_ignore_sigttou): ...to here.
7966         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
7967         * top.c:  Remove include comment.
7968
7969 2019-05-27  Tom Tromey  <tom@tromey.com>
7970
7971         * NEWS: Fix typo.
7972
7973 2019-05-22  Tom Tromey  <tromey@adacore.com>
7974
7975         * target.c (target_follow_exec): Constify parameter.
7976         * target-delegates.c: Rebuild.
7977         * remote.c (remote_target::follow_exec): Constify parameter.
7978         * infrun.c (follow_exec): Constify parameter.
7979         * target.h (struct target_ops) <follow_exec>: Constify parameter.
7980         (target_follow_exec): Likewise.
7981
7982 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
7983
7984         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
7985         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
7986
7987 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
7988
7989         * NEWS: Add debugredirect and testsuite sections.
7990
7991 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
7992
7993         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
7994         target descriptions using exclusively floating point register name
7995         aliases.
7996
7997 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
7998
7999         PR gdb/18644:
8000         * f-lang.c (build_fortran_types): Handle the case where
8001         gdbarch_floatformat_for_type returns a nullptr.
8002
8003 2019-05-21  Tom de Vries  <tdevries@suse.de>
8004
8005         PR cli/24587
8006         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
8007
8008 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
8009
8010         PR gdb/18644:
8011         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
8012         16-byte floats.
8013         * i386-tdep.c (i386_floatformat_for_type): Use
8014         floatformats_ia64_quad for the 16-byte floating point component
8015         within a fortran 32-byte complex number.
8016
8017 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
8018
8019         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
8020         delete default constructor.
8021         (find_partial_die): Update to return const struct.
8022         (partial_die_parent_scope): Move variable declaration into scope
8023         of its use and change its type to auto.
8024         (guess_partial_die_structure_name): Likewise.
8025         (partial_die_info::fixup): Likewise.
8026
8027 2019-05-17  Tom Tromey  <tromey@adacore.com>
8028
8029         * source.c (find_and_open_source): Remove cast.
8030
8031 2019-05-17  Tom Tromey  <tromey@adacore.com>
8032
8033         * annotate.c (annotate_source): Make "filename" const.
8034         * annotate.h (annotate_source): Use const.
8035
8036 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
8037
8038         * disasm.c (set_disassembler_options): Send errors to stderr.
8039
8040 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
8041
8042         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
8043         (cli_interp_base::set_logging): Check debug_redirect.
8044         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
8045         * cli/cli-logging.c (debug_redirect): Add static variable.
8046         (pop_output_files): Add default param.
8047         (handle_redirections): Print debug setting.
8048         (show_logging_command): Likewise.
8049         (_initialize_cli_logging): Add debugredirect command.
8050         * interps.c (current_interp_set_logging): Add debug_redirect
8051         parameter.
8052         * interps.h (set_logging): Add debug_redirect parameter.
8053         (current_interp_set_logging): Likewise.
8054         * mi/mi-common.h: Likewise.
8055         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
8056
8057 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
8058             Tom Tromey  <tromey@adacore.com>
8059
8060         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
8061         directly.
8062         * cli/cli-interp.h (make_logging_output): Remove declaration.
8063         * cli/cli-logging.c (make_logging_output): Remove function.
8064         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
8065         directly.
8066         * ui-file.c (tee_file::tee_file): Remove bools.
8067         (tee_file::~tee_file): Remove deletes.
8068         * ui-file.h (tee_file): Remove bools.
8069
8070 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
8071
8072         * mi/mi-cmds.h (mi_cmd_complete): New function.
8073         * mi/mi-main.c (mi_cmd_complete): Likewise.
8074         * mi/mi-cmds.c: Define new MI command -complete.
8075         * NEWS: Mention new -complete command.
8076
8077 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
8078
8079         * completer.h (complete): New function.
8080         * completer.c (complete): Likewise.
8081         * cli/cli-cmds.c: (complete_command): Update to use new complete()
8082         function defined in completer.h.
8083
8084 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
8085
8086         * MAINTAINERS (Write After Approval): Add myself.
8087
8088 2019-05-17  Tom de Vries  <tdevries@suse.de>
8089
8090         PR gdb/24094
8091         * dwarf2read.c (struct cu_partial_die_info): New struct.
8092         (find_partial_die): Return cu_partial_die_info.
8093         (partial_die_parent_scope, guess_partial_die_structure_name)
8094         (partial_die_info::fixup): Handle new return type of find_partial_die.
8095
8096 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
8097
8098         PR breakpoints/24541
8099         * stap-probe.c (stap_parse_register_operand): Make "regname" an
8100         "std::string", simplifying the algorithm.
8101
8102 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
8103
8104         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
8105         (stap_static_probe_ops::get_probes): Likewise.
8106
8107 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
8108
8109         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
8110         '-')" and "else if".
8111         (stap_parse_single_operand): Join checks for
8112         "gdbarch_stap_parse_special_token_p" and
8113         "gdbarch_stap_parse_special_token" in the same "if" statement.
8114         Invert check when verifying for operation on register
8115         displacement.
8116
8117 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
8118
8119         * stap-probe.c (stap_get_opcode): Update comment.
8120         (stap_get_expected_argument_type): Likewise.
8121         (handle_stap_probe): Likewise.
8122
8123 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
8124
8125         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
8126         return type to 'bool'.  Adjust comment.  Use 'bool' when
8127         appropriate.
8128         (i386_stap_parse_special_token_three_arg_disp): Likewise.
8129         * stap-probe.c (stap_parse_argument_1): Likewise.
8130         (stap_is_operator): Likewise.
8131         (stap_is_generic_prefix): Likewise.
8132         (stap_is_register_prefix): Likewise.
8133         (stap_is_register_indirection_prefix): Likewise.
8134         (stap_is_integer_prefix): Likewise.
8135         (stap_generic_check_suffix): Likewise.
8136         (stap_check_integer_suffix): Likewise.
8137         (stap_check_register_suffix): Likewise.
8138         (stap_check_register_indirection_suffix): Likewise.
8139         (stap_parse_register_operand): Likewise.
8140         (stap_parse_single_operand): Likewise.
8141         (stap_parse_argument_1): Likewise.
8142         (stap_probe::get_argument_count): Likewise.
8143         (stap_is_operator): Likewise.
8144
8145 2019-05-16  Tom Tromey  <tromey@adacore.com>
8146
8147         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
8148         keyword to foreach.
8149
8150 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
8151
8152         * linux-thread-db.c (try_thread_db_load_1): Change return type
8153         to bool.
8154         (try_thread_db_load): Likewise.
8155         (try_thread_db_load_from_pdir_1): Likewise.
8156         (try_thread_db_load_from_pdir): Likewise.
8157         (try_thread_db_load_from_sdir): Likewise.
8158         (try_thread_db_load_from_dir): Likewise.
8159         (thread_db_load_search): Likewise.
8160         (has_libpthread): Likewise.
8161         (thread_db_load): Likewise.
8162
8163 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
8164
8165         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
8166         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
8167         NULL, and complain/return if that's the case.
8168
8169 2019-05-15  John Darrington <john@darrington.wattle.id.au>
8170
8171         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
8172         (advance, posn, abstract_read_memory): New functions.
8173         [struct mem_read_abstraction]: New struct.
8174         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
8175
8176 2019-05-14  Tom Tromey  <tromey@adacore.com>
8177
8178         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
8179         value is not lval_memory.
8180
8181 2019-05-14  Tom Tromey  <tromey@adacore.com>
8182
8183         * solib.c (info_sharedlibrary_command): Style the file name.
8184
8185 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
8186
8187         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
8188         (aarch64_vnv_type): Likewise.
8189         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
8190         * common/tdesc.c: Likewise.
8191         * common/tdesc.h (enum tdesc_type_kind): Likewise.
8192         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
8193         * features/aarch64-fpu.xml: Add ieee half view.
8194         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
8195         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
8196         * gdbtypes.h (struct builtin_type): Likewise.
8197         (struct objfile_type): Likewise.
8198
8199 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
8200
8201         * language.c (language_sniff_from_mangled_name): Fix "langauge"
8202         typo.
8203         * location.h (string_to_event_location): Likewise.
8204
8205 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
8206
8207         GDB 8.3 released.
8208
8209 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
8210
8211         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
8212         New variable declaration.
8213         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
8214         New variable.
8215         (print_one_breakpoint): Use ui_out::test_flags and new global
8216         variable to compute use_fixed_output.
8217         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
8218         Remove.
8219         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
8220         (mi_multi_location_breakpoint_output_fixed): Remove.
8221         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
8222         new variable.
8223         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
8224         fix_multi_location_breakpoint_output flag if version >= 3.
8225         * ui-out.h (enum ui_out_flag)
8226         <fix_multi_location_breakpoint_output>: New enumerator.
8227
8228 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
8229
8230         * contrib/cc-with-tweaks.sh: Validate dwz's work.
8231
8232 2019-05-10  Tom Tromey  <tromey@adacore.com>
8233
8234         * ada-lang.c (catch_ada_completer): New function.
8235         (_initialize_ada_language): Use it.
8236
8237 2019-05-10  Tom Tromey  <tromey@adacore.com>
8238
8239         * thread.c (print_thread_info): Make "requested_threads" const.
8240         * gdbthread.h (print_thread_info): Make "requested_threads"
8241         const.
8242         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
8243         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
8244
8245 2019-05-08  Tom Tromey  <tom@tromey.com>
8246
8247         * gdbtypes.c (objfile_type_data): Change type.
8248         (objfile_type, _initialize_gdbtypes): Update.
8249
8250 2019-05-08  Tom Tromey  <tom@tromey.com>
8251
8252         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
8253         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
8254         (_initialize_dwarf2_frame): Update.
8255
8256 2019-05-08  Tom Tromey  <tom@tromey.com>
8257
8258         * objc-lang.c (objc_objfile_data): Change type.
8259         (find_methods): Update.
8260         (_initialize_objc_lang): Remove.
8261
8262 2019-05-08  Tom Tromey  <tom@tromey.com>
8263
8264         * stabsread.c (rs6000_builtin_type_data): Change type.
8265         (rs6000_builtin_type, _initialize_stabsread): Update.
8266
8267 2019-05-08  Tom Tromey  <tom@tromey.com>
8268
8269         * mips-tdep.c (mips_pdr_data): Remove.
8270         (_initialize_mips_tdep): Update.
8271
8272 2019-05-08  Tom Tromey  <tom@tromey.com>
8273
8274         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
8275         (hppa_init_objfile_priv_data, read_unwind_info)
8276         (find_unwind_entry, _initialize_hppa_tdep): Update.
8277
8278 2019-05-08  Tom Tromey  <tom@tromey.com>
8279
8280         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
8281         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
8282         on obstack.
8283         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
8284
8285 2019-05-08  Tom Tromey  <tom@tromey.com>
8286
8287         * mdebugread.c (basic_type_data): Change type.
8288         (basic_type, _initialize_mdebugread): Update.
8289
8290 2019-05-08  Tom Tromey  <tom@tromey.com>
8291
8292         * common/gdb_unique_ptr.h (struct noop_deleter): New.
8293
8294 2019-05-08  Tom Tromey  <tom@tromey.com>
8295
8296         * nto-tdep.c (nto_inferior_data_reg): Change type.
8297         (nto_inferior_data): Update.
8298         (nto_inferior_data_cleanup, nto_new_inferior_data)
8299         (_initialize_nto_tdep): Remove.
8300         * nto-tdep.h (struct nto_inferior_data): Add initializers.
8301
8302 2019-05-08  Tom Tromey  <tom@tromey.com>
8303
8304         * ada-lang.c (struct ada_inferior_data): Add initializers.
8305         (ada_inferior_data): Change type.
8306         (ada_inferior_data_cleanup): Remove.
8307         (get_ada_inferior_data, ada_inferior_exit)
8308         (struct ada_pspace_data): Add initializers, destructor.
8309         (ada_pspace_data_handle): Change type.
8310         (get_ada_pspace_data): Update.
8311         (ada_pspace_data_cleanup): Remove.
8312
8313 2019-05-08  Tom Tromey  <tom@tromey.com>
8314
8315         * coffread.c (struct coff_symfile_info): Add initializers.
8316         (coff_objfile_data_key): Move lower.  Change type.
8317         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
8318         Update.
8319         (coff_free_info): Remove.
8320
8321 2019-05-08  Tom Tromey  <tom@tromey.com>
8322
8323         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
8324         (fbsd_pspace_data_handle): Move lower.  Change type.
8325         (get_fbsd_pspace_data): Update.
8326         (fbsd_pspace_data_cleanup): Remove.
8327         (_initialize_fbsd_tdep): Update.
8328
8329 2019-05-08  Tom Tromey  <tom@tromey.com>
8330
8331         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
8332         (get_ada_tasks_pspace_data): Update.
8333         (ada_tasks_pspace_data_cleanup): Remove.
8334         (_initialize_tasks): Update.
8335         (ada_tasks_inferior_data_handle): Change type.
8336         (get_ada_tasks_inferior_data): Update.
8337         (ada_tasks_inferior_data_cleanup): Remove.
8338         (struct ada_tasks_pspace_data): Add initializers.
8339
8340 2019-05-08  Tom Tromey  <tom@tromey.com>
8341
8342         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
8343         * symfile-debug.c (debug_sym_get_probes): Change type.
8344         * stap-probe.c (handle_stap_probe):
8345         (stap_static_probe_ops::get_probes): Change type.
8346         * probe.h (class static_probe_ops) <get_probes>: Change type.
8347         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
8348         (parse_probes_in_pspace): Update.
8349         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
8350         Update.
8351         (any_static_probe_ops::get_probes): Change type.
8352         * elfread.c (elfread_data): New typedef.
8353         (probe_key): Change type.
8354         (elf_get_probes): Likewise.  Update.
8355         (probe_key_free): Remove.
8356         (_initialize_elfread): Update.
8357         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
8358         Change type.
8359         (dtrace_process_dof_probe, dtrace_process_dof)
8360         (dtrace_static_probe_ops::get_probe): Change type.
8361
8362 2019-05-08  Tom Tromey  <tom@tromey.com>
8363
8364         * xcoffread.c (struct xcoff_symfile_info): Rename from
8365         coff_symfile_info.  Add initializers.
8366         (xcoff_objfile_data_key): Move lower.  Change type.
8367         (XCOFF_DATA): Rewrite.
8368         (xcoff_free_info): Remove.
8369         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
8370         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
8371         (xcoff_initial_scan): Update.
8372
8373 2019-05-08  Tom Tromey  <tom@tromey.com>
8374
8375         * solib-svr4.c (struct svr4_info): Add initializers and
8376         destructor.
8377         <probes_table>: Now an htab_up.
8378         (solib_svr4_pspace_data): Change type.
8379         (free_probes_table): Simplify.
8380         (~svr4_info): Rename from svr4_pspace_data_cleanup.
8381         (get_svr4_info, probes_table_htab_remove_objfile_probes)
8382         (probes_table_remove_objfile_probes, register_solib_event_probe)
8383         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
8384         (_initialize_svr4_solib): Update.
8385
8386 2019-05-08  Tom Tromey  <tom@tromey.com>
8387
8388         * remote.c (remote_pspace_data): Change type.
8389         (remote_pspace_data_cleanup): Remove.
8390         (get_remote_exec_file, set_pspace_remote_exec_file)
8391         (_initialize_remote): Update.
8392
8393 2019-05-08  Tom Tromey  <tom@tromey.com>
8394
8395         * breakpoint.c (breakpoint_objfile_key): Change type.
8396         (get_breakpoint_objfile_data): Update.
8397         (free_breakpoint_objfile_data): Remove.
8398         (_initialize_breakpoint): Update.
8399
8400 2019-05-08  Tom Tromey  <tom@tromey.com>
8401
8402         * linux-tdep.c (struct linux_info): Add initializers.
8403         (linux_inferior_data): Move.  Change type.
8404         (invalidate_linux_cache_inf): Update.
8405         (linux_inferior_data_cleanup): Remove.
8406         (get_linux_inferior_data, _initialize_linux_tdep): Update.
8407
8408 2019-05-08  Tom Tromey  <tom@tromey.com>
8409
8410         * auxv.c (auxv_inferior_data): Move.  Change type.
8411         (auxv_inferior_data_cleanup): Remove.
8412         (invalidate_auxv_cache_inf): Rewrite.
8413         (get_auxv_inferior_data, _initialize_auxv): Update.
8414
8415 2019-05-08  Tom Tromey  <tom@tromey.com>
8416
8417         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
8418         (symfile_debug_objfile_data_key): Change type.
8419         (symfile_debug_installed, debug_qf_has_symbols)
8420         (debug_qf_find_last_source_symtab)
8421         (debug_qf_forget_cached_source_info)
8422         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
8423         (debug_qf_print_stats, debug_qf_dump)
8424         (debug_qf_expand_symtabs_for_function)
8425         (debug_qf_expand_all_symtabs)
8426         (debug_qf_expand_symtabs_with_fullname)
8427         (debug_qf_map_matching_symbols)
8428         (debug_qf_expand_symtabs_matching)
8429         (debug_qf_find_pc_sect_compunit_symtab)
8430         (debug_qf_map_symbol_filenames)
8431         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
8432         (debug_sym_new_init, debug_sym_init, debug_sym_read)
8433         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
8434         (debug_sym_read_linetable, debug_sym_relocate): Update.
8435         (symfile_debug_free_objfile): Remove.
8436         (install_symfile_debug_logging, _initialize_symfile_debug):
8437         Update.
8438
8439 2019-05-08  Tom Tromey  <tom@tromey.com>
8440
8441         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
8442         allocate_on_obstack.
8443         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
8444         (get_dwarf2_per_objfile): Update.
8445         (set_dwarf2_per_objfile): Remove.
8446         (dwarf2_has_info, dwarf2_get_section_info): Update.
8447         (dwarf2_free_objfile): Remove.
8448         (_initialize_dwarf2_read): Update.
8449
8450 2019-05-08  Tom Tromey  <tom@tromey.com>
8451
8452         * auto-load.c (struct auto_load_pspace_info): Add destructor and
8453         initializers.
8454         <unsupported_script_warning_printed,
8455         script_not_found_warning_printed>: Now bool.
8456         (auto_load_pspace_data): Change type.
8457         (~auto_load_pspace_info): Rename from
8458         auto_load_pspace_data_cleanup.
8459         (get_auto_load_pspace_data, init_loaded_scripts_info)
8460         (clear_section_scripts, maybe_print_unsupported_script_warning)
8461         (maybe_print_script_not_found_warning, _initialize_auto_load):
8462         Update.
8463
8464 2019-05-08  Tom Tromey  <tom@tromey.com>
8465
8466         * objfiles.c (objfile_pspace_info): Add destructor and
8467         initializers.
8468         (objfiles_pspace_data): Change type.
8469         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
8470         (get_objfile_pspace_data): Update.
8471         (objfiles_bfd_data): Change type.
8472         (get_objfile_bfd_data): Update.
8473         (objfile_bfd_data_free, _initialize_objfiles): Remove.
8474
8475 2019-05-08  Tom Tromey  <tom@tromey.com>
8476
8477         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
8478         Change type.
8479         (get_catch_syscall_inferior_data): Update.
8480         (catch_syscall_inferior_data_cleanup): Remove.
8481         (_initialize_break_catch_syscall): Update.
8482
8483 2019-05-08  Tom Tromey  <tom@tromey.com>
8484
8485         * inflow.c (struct terminal_info): Add destructor and
8486         initializers.
8487         (inflow_inferior_data): Change type.
8488         (~terminal_info): Rename from inflow_inferior_data_cleanup.
8489         (get_inflow_inferior_data, inflow_inferior_exit)
8490         (swap_terminal_info, _initialize_inflow): Update.
8491
8492 2019-05-08  Tom Tromey  <tom@tromey.com>
8493
8494         * target-dcache.c (target_dcache_cleanup): Remove.
8495         (target_dcache_aspace_key): Change type.
8496         (target_dcache_init_p, target_dcache_invalidate)
8497         (target_dcache_get, target_dcache_get_or_init)
8498         (_initialize_target_dcache): Update.
8499         * dcache.h (struct dcache_deleter): New.
8500
8501 2019-05-08  Tom Tromey  <tom@tromey.com>
8502
8503         * symtab.c (struct symbol_cache): Add destructor and
8504         initializers.
8505         (symbol_cache_key): Move.  Change type.
8506         (make_symbol_cache, free_symbol_cache): Remove.
8507         (get_symbol_cache): Update.
8508         (symbol_cache_cleanup): Remove.
8509         (ALL_PSPACES, symbol_cache_flush)
8510         (maintenance_print_symbol_cache)
8511         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
8512         Update.
8513
8514 2019-05-08  Tom Tromey  <tom@tromey.com>
8515
8516         * symtab.c (struct main_info): Add destructor and initializers.
8517         (main_progspace_key): Move.  Change type.
8518         (get_main_info): Update.
8519         (main_info_cleanup): Remove.
8520         (_initialize_symtab): Update.
8521
8522 2019-05-08  Tom Tromey  <tom@tromey.com>
8523
8524         * registry.h (DECLARE_REGISTRY): Define the _key class.
8525
8526 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
8527
8528         * NEWS: Merge two 'New commands' sections.
8529
8530 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
8531
8532         * ada-valprint.c (ada_val_print_gnat_array): Remove language
8533         parameter and use Ada language definition instead.
8534         (ada_val_print_ptr): Remove unused language parameter.
8535         (ada_val_print_num): Remove language parameter and use Ada language
8536         definition instead.
8537         (ada_val_print_enum, ada_val_print_flt): Remove unused language
8538         parameter.
8539         (ada_val_print_struct_union, ada_val_print_ref): Remove language
8540         parameter and use Ada language definition instead.
8541         (ada_val_print_1): Update all ada_val_print_xxx calls.
8542         Remove language parameter.
8543         (ada_val_print): Update ada_val_print_1 call.
8544
8545 2019-05-08  Tom Tromey  <tromey@adacore.com>
8546
8547         * remote.c (remote_hw_watchpoint_limit)
8548         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
8549         Now static.
8550
8551 2019-05-08  Tom Tromey  <tromey@adacore.com>
8552
8553         * maint.c (_initialize_maint_cmds): Move initialization code to
8554         remote.c.
8555         (watchdog, show_watchdog): Move to remote.c.
8556         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
8557         "watchdog" static.
8558         (_initialize_remote): Move initialization code from maint.c.
8559         * defs.h (watchdog): Don't declare.
8560
8561 2019-05-08  Tom Tromey  <tromey@adacore.com>
8562
8563         * tui/tui-interp.c: Include main.h.
8564         * interps.c: Include main.h.
8565         * main.h (interpreter_p): Declare.
8566         * defs.h (interpreter_p): Don't declare.
8567
8568 2019-05-08  Tom Tromey  <tromey@adacore.com>
8569
8570         * dwarf2loc.c: Include dwarf2read.h.
8571         * defs.h (read_unsigned_leb128): Don't declare.
8572         * dwarf2read.h (read_unsigned_leb128): Declare.
8573
8574 2019-05-08  Tom Tromey  <tromey@adacore.com>
8575
8576         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
8577         method.
8578
8579 2019-05-08  Tom Tromey  <tromey@adacore.com>
8580
8581         * utils.c (fputs_maybe_filtered): Reset style after paging, even
8582         when no wrap column is set.
8583
8584 2019-05-08  Tom Tromey  <tromey@adacore.com>
8585
8586         * c-lang.c (c_get_string): Handle non-C-style arrays.
8587
8588 2019-05-08  Tom Tromey  <tromey@adacore.com>
8589
8590         * typeprint.c (print_offset_data::update): Print the bit offset,
8591         not the number of bits remaining.
8592
8593 2019-05-08  Tom Tromey  <tromey@adacore.com>
8594
8595         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
8596         padding at end of comment.
8597
8598 2019-05-08  Tom Tromey  <tromey@adacore.com>
8599
8600         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
8601         Compare main types.
8602
8603 2019-05-06  Tom Tromey  <tom@tromey.com>
8604
8605         * common/scoped_mmap.c: Include common-defs.h.
8606         * common/scoped_mmap.h: Don't include config.h.
8607
8608 2019-05-04  Tom Tromey  <tom@tromey.com>
8609
8610         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
8611         (struct aarch64_call_info): Add initializers.
8612         <si>: Now a std::vector.
8613         (pass_on_stack, aarch64_push_dummy_call): Update.
8614
8615 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
8616             Tom Tromey  <tom@tromey.com>
8617
8618         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
8619         (ppc_threads): Now a std::vector.  Now static.
8620         (hwdebug_find_thread_points_by_tid)
8621         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
8622         Update.
8623
8624 2019-05-04  Tom Tromey  <tom@tromey.com>
8625
8626         * arc-tdep.c (arc_tdesc_init): Return bool.
8627
8628 2019-05-04  Tom Tromey  <tom@tromey.com>
8629
8630         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
8631         Use gdb_assert_not_reached.
8632
8633 2019-05-04  Tom Tromey  <tom@tromey.com>
8634
8635         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
8636         "false".
8637
8638 2019-05-04  Tom Tromey  <tom@tromey.com>
8639
8640         * arc-tdep.c (arc_tdesc_init): Use bool.
8641
8642 2019-05-04  Tom Tromey  <tom@tromey.com>
8643
8644         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
8645
8646 2019-05-04  Tom Tromey  <tom@tromey.com>
8647
8648         * cli/cli-cmds.c (valid_command_p): Return bool.
8649
8650 2019-05-04  Tom Tromey  <tom@tromey.com>
8651
8652         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
8653         * command.h (valid_user_defined_cmd_name_p): Channge return type.
8654
8655 2019-05-04  Raul Tambre  <raul@tambre.ee>
8656
8657         * python/lib/gdb/prompt.py (_ExtendedPrompt)
8658         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
8659         operator for comparison.
8660
8661 2019-05-04  Tom Tromey  <tom@tromey.com>
8662
8663         * psymtab.c (psymbol_name_matches, match_partial_symbol)
8664         (lookup_partial_symbol, print_partial_symbols)
8665         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
8666         (psymbol_compare): Update.
8667         (add_psymbol_to_bcache): Clear the entire psymbol.
8668         (maintenance_check_psymtabs): Update.
8669         * psympriv.h (struct partial_symbol): Don't derive from
8670         general_symbol_info.
8671         <obj_section, unrelocated_address, address,
8672         set_unrelocated_address>: Update.
8673         <ginfo>: New member.
8674         * dwarf-index-write.c (write_psymbols, debug_names::insert)
8675         (debug_names::write_psymbols): Update.
8676
8677 2019-05-04  Tom de Vries  <tdevries@suse.de>
8678
8679         * contrib/cc-with-tweaks.sh: Support -n arg.
8680
8681 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8682
8683         * corelow.c (core_target::detach): Ensure frame cache and
8684         register caches are cleared.
8685         inferior.c (exit_inferior_1): Likewise.
8686
8687 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
8688             Tom Tromey  <tom@tromey.com>
8689
8690         * dictionary.c (collate_pending_symbols_by_language): Remove
8691         "struct" from foreach.
8692         * symtab.c (lookup_global_symbol_from_objfile)
8693         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
8694         foreach.
8695         * ser-tcp.c (net_open): Remove "struct" from foreach.
8696         * objfiles.c (objfile_relocate, objfile_rebase)
8697         (objfile_has_symbols): Remove "struct" from foreach.
8698         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
8699         from foreach.
8700         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
8701         foreach.
8702         * darwin-nat.c (thread_info_from_private_thread_info): Remove
8703         "struct" from foreach.
8704         * ada-lang.c (create_excep_cond_exprs)
8705         (ada_exception_catchpoint_cond_string): Remove "struct" from
8706         foreach.
8707
8708 2019-05-03  Tom Tromey  <tromey@adacore.com>
8709
8710         * ada-exp.y (convert_char_literal): Check suffix of each
8711         enumerator.
8712
8713 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
8714
8715         PR ada/21406:
8716         * ada-exp.y (yywrap): Don't define.
8717         * ada-lex.l (%option): Add noyywrap
8718         (yywrap): Remove.
8719
8720 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
8721
8722         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
8723         _WIN32_WINNT to the XP level, unless already defined to a higher
8724         level.
8725
8726         * unittests/parse-connection-spec-selftests.c:
8727         * ser-tcp.c:
8728         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
8729         override.
8730
8731         * symfile.c (find_separate_debug_file): Remove colon from the
8732         drive spec of DOS/Windows file names of the target, so that the
8733         file name produced from DEBUGDIR and the target's directory will
8734         be valid on DOS/Windows systems.
8735
8736 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
8737
8738         * rust-lang.c (val_print_struct): Handle printing structures
8739         containing strings.
8740
8741 2019-05-02  Tom Tromey  <tromey@adacore.com>
8742
8743         * valarith.c (_initialize_valarith): Remove.
8744
8745 2019-05-01  Tom Tromey  <tromey@adacore.com>
8746
8747         * ada-lang.c (ada_value_primitive_field): Treat more fields as
8748         bitfields.
8749
8750 2019-05-01  Tom Tromey  <tromey@adacore.com>
8751
8752         * ada-lang.c (ada_value_assign): Correctly compute starting offset
8753         for big-endian copies.
8754
8755 2019-04-30  Ali Tamur  <tamur@google.com>
8756         * gdb/dwarf2read.c (read_3_bytes): New declaration.
8757         (read_attribute_value): Added DW_FORM_strx1-4 cases.
8758         (read_3_bytes): New function.
8759
8760 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
8761
8762         * windows-nat.c (main_thread_id): Delete.
8763         (handle_output_debug_string): Replace main_thread_id by
8764         current_event.dwThreadId.
8765         (fake_create_process): Likewise.
8766         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
8767         Do not set main_thread_id.
8768         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
8769         current_event.dwThreadId.
8770         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
8771
8772 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
8773
8774         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
8775         Use current_event.dwThreadId instead of main_thread_id.
8776
8777 2019-04-30  Tom Tromey  <tromey@adacore.com>
8778
8779         * ada-lang.c (ada_lookup_simple_minsyms): New function.
8780         (create_excep_cond_exprs): Iterate over program spaces.
8781         (ada_exception_catchpoint_cond_string): Examine all minimal
8782         symbols for exception types.
8783
8784 2019-04-30  Tom Tromey  <tromey@adacore.com>
8785
8786         PR c++/24470:
8787         * dwarf2read.c (process_structure_scope): Handle case where type
8788         has template parameters but no symbol was created.
8789
8790 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8791             Chris January  <chris.january@arm.com>
8792
8793         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
8794         qualifier.
8795         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
8796
8797 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8798
8799         * f-typeprint.c (f_print_type): Update rules for printing
8800         whitespace.
8801         (f_type_print_varspec_suffix): Likewise.
8802
8803 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8804             Chris January  <chris.january@arm.com>
8805
8806         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
8807         function arguments.
8808
8809 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8810
8811         * f-lang.c (build_fortran_types): Change name of void type to
8812         lower case.
8813         * f-typeprint.c (f_type_print_base): Print the name of the void
8814         type, rather than a fixed string.
8815         * f-valprint.c (f_decorations): Use lower case void string.
8816
8817 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8818             Chris January  <chris.january@arm.com>
8819
8820         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
8821         types for Fortran.
8822
8823 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8824             Chris January  <chris.january@arm.com>
8825             David Lecomber  <david.lecomber@arm.com>
8826
8827         * f-exp.y (BINOP_INTRINSIC): New token.
8828         (exp): New parser rule handling BINOP_INTRINSIC.
8829         (f77_keywords): Add new builtin procedures.
8830         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
8831         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
8832         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
8833         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
8834         (print_unop_subexp_f): New function.
8835         (print_binop_subexp_f): New function.
8836         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
8837         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
8838         (dump_subexp_body_f): Likewise.
8839         (operator_check_f): Likewise.
8840         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
8841         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
8842
8843 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8844
8845         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
8846         UNOP_KIND.
8847         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
8848         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
8849         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
8850         (operator_length_f): New fuction.
8851         (print_subexp_f): New function.
8852         (op_name_f): New function.
8853         (dump_subexp_body_f): New function.
8854         (operator_check_f): New function.
8855         (exp_descriptor_f): Replace standard expression handling functions
8856         with new functions.
8857         * gdb/fortran-operator.def: New file.
8858         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
8859         * gdb/std-operator.def: Remove UNOP_KIND.
8860
8861 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8862
8863         * std-operator.def: Remove unbalanced, stray double quote
8864         character.
8865
8866 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
8867             Chris January  <chris.january@arm.com>
8868             Daniel Everett  <daniel.everett@arm.com>
8869             Nick Forrington  <nick.forrington@arm.com>
8870             Richard Bunt  <richard.bunt@arm.com>
8871
8872         * cp-valprint.c (cp_print_value_fields): Allow an additional level
8873         of depth when printing anonymous structs or unions.
8874         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
8875         Don't print either the top-level value, or the children if the
8876         max-depth is exceeded.
8877         (ppscm_print_children): When printing the key of a map, allow one
8878         extra level of depth.
8879         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
8880         print either the top-level value, or the children if the max-depth
8881         is exceeded.
8882         (print_children): When printing the key of a map, allow one extra
8883         level of depth.
8884         * python/py-value.c (valpy_format_string): Add max_depth keyword.
8885         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
8886         (user_print_options): Initialise max_depth field.
8887         (val_print_scalar_or_string_type_p): New function.
8888         (val_print): Check to see if the max depth has been reached.
8889         (val_print_check_max_depth): Define new function.
8890         (show_print_max_depth): New function.
8891         (_initialize_valprint): Add 'print max-depth' option.
8892         * valprint.h (struct value_print_options) <max_depth>: New field.
8893         (val_print_check_max_depth): Declare new function.
8894         * NEWS: Document new feature.
8895
8896 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
8897
8898         * ada-lang.c (ada_language_defn): Initialise new field.
8899         * c-lang.c (c_is_string_type_p): New function.
8900         (c_language_defn): Initialise new field.
8901         (cplus_language_defn): Initialise new field.
8902         (asm_language_defn): Initialise new field.
8903         (minimal_language_defn): Initialise new field.
8904         * c-lang.h (c_is_string_type_p): Declare new function.
8905         * d-lang.c (d_language_defn): Initialise new field.
8906         * f-lang.c (f_is_string_type_p): New function.
8907         (f_language_defn): Initialise new field.
8908         * go-lang.c (go_is_string_type_p): New function.
8909         (go_language_defn): Initialise new field.
8910         * language.c (default_is_string_type_p): New function.
8911         (unknown_language_defn): Initialise new field.
8912         (auto_language_defn): Initialise new field.
8913         * language.h (struct language_defn) <la_is_string_type_p>: New
8914         member variable.
8915         (default_is_string_type_p): Declare new function.
8916         * m2-lang.c (m2_language_defn): Initialise new field.
8917         * objc-lang.c (objc_language_defn): Initialise new field.
8918         * opencl-lang.c (opencl_language_defn): Initialise new field.
8919         * p-lang.c (pascal_is_string_type_p): New function.
8920         (pascal_language_defn): Initialise new field.
8921         * rust-lang.c (rust_is_string_type_p): New function.
8922         (rust_language_defn): Initialise new field.
8923
8924 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
8925
8926         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
8927         New field.
8928         * ada-lang.c (ada_language_defn): Initialise new field.
8929         * c-lang.c (c_language_defn): Likewise.
8930         (cplus_language_defn): Likewise.
8931         (asm_language_defn): Likewise.
8932         (minimal_language_defn): Likewise.
8933         * d-lang.c (d_language_defn): Likewise.
8934         * f-lang.c (f_language_defn): Likewise.
8935         * go-lang.c (go_language_defn): Likewise.
8936         * language.c (unknown_language_defn): Likewise.
8937         (auto_language_defn): Likewise.
8938         * m2-lang.c (m2_language_defn): Likewise.
8939         * objc-lang.c (objc_language_defn): Likewise.
8940         * opencl-lang.c (opencl_language_defn): Likewise.
8941         * p-lang.c (pascal_language_defn): Likewise.
8942         * rust-lang.c (rust_language_defn): Likewise.
8943
8944 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
8945
8946         * ada-lang.c (ada_is_character_type): Change return type to bool.
8947         (ada_is_string_type): Likewise.
8948         * ada-lang.h (ada_is_character_type): Update declaration
8949         (ada_is_string_type): Likewise.
8950
8951 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8952
8953         Support style in 'frame|thread apply'
8954
8955         * gdbcmd.h (execute_command_to_string): New term_out parameter.
8956         * record.c (record_start, record_stop): Update callers of
8957         execute_command_to_string with false.
8958         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
8959         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
8960         methods.
8961         (class string_file): New constructor with term_out parameter.
8962         Override methods term_out and can_emit_style_escape.  New member
8963         term_out.
8964         (class stdio_file): Override can_emit_style_escape.
8965         (class tee_file): Override term_out and can_emit_style_escape.
8966         * utils.h (can_emit_style_escape): Remove.
8967         * utils.c (can_emit_style_escape): Likewise.
8968         Update all callers of can_emit_style_escape (SOMESTREAM) to
8969         SOMESTREAM->can_emit_style_escape.
8970         * source-cache.c (source_cache::get_source_lines): Likewise.
8971         * stack.c (frame_apply_command_count): Call execute_command_to_string
8972         passing the term_out characteristic of the current gdb_stdout.
8973         * thread.c (thr_try_catch_cmd): Likewise.
8974         * top.c (execute_command_to_string): pass term_out parameter
8975         to construct the string_file for the command output.
8976         * ui-file.c (term_cli_styling): New function (most code moved
8977         from utils.c can_emit_style_escape).
8978         (string_file::string_file, string_file::can_emit_style_escape,
8979         stdio_file::can_emit_style_escape, tee_file::term_out,
8980         tee_file::can_emit_style_escape): New functions.
8981
8982 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8983
8984         * NEWS: Mention the new set|show may-call-functions.
8985         * infcall.c (may_call_functions_p): New variable.
8986         (show_may_call_functions_p): New function.
8987         (call_function_by_hand_dummy): Throws an error if not
8988         may-call-functions.
8989         (_initialize_infcall): Call add_setshow_boolean_cmd for
8990         may-call-functions.
8991
8992 2019-04-25  Keith Seitz  <keiths@redhat.com>
8993
8994         PR c++/24367
8995         * cp-support.c (inspect_type): Don't attempt substitutions
8996         of symbol with the same name.
8997
8998 2019-04-25  Tom Tromey  <tromey@adacore.com>
8999
9000         PR gdb/24475:
9001         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
9002         static.
9003
9004 2019-04-25  Tom Tromey  <tromey@adacore.com>
9005
9006         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
9007         rvalue reference.
9008         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
9009         (gdb_xml_parser::parse): Use std::move.
9010         * python/python-internal.h (gdbpy_convert_exception): Take a const
9011         reference.
9012         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
9013         std::move.
9014         * python/py-utils.c (gdbpy_convert_exception): Take a const
9015         reference.
9016         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
9017         Use std::move.
9018         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
9019         Use std::move.
9020         * mi/mi-main.c (mi_print_exception): Take a const reference.
9021         * main.c (handle_command_errors): Take a const reference.
9022         * linespec.c (parse_linespec): Use std::move.
9023         * infcall.c (run_inferior_call): Use std::move.
9024         (call_function_by_hand_dummy): Use std::move.
9025         * exec.c (try_open_exec_file): Use std::move.
9026         * exceptions.h (exception_print, exception_fprintf)
9027         (exception_print_same): Update.
9028         * exceptions.c (print_exception, exception_print)
9029         (exception_fprintf, exception_print_same): Change parameters to
9030         const reference.
9031         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
9032         * common/new-op.c: Use std::move.
9033         * common/common-exceptions.h (struct gdb_exception): Add move
9034         constructor.
9035         (struct gdb_exception_error, struct gdb_exception_quit, struct
9036         gdb_quit_bad_alloc): Change constructor to move constructor.
9037         (throw_exception): Change parameter to rvalue reference.
9038         * common/common-exceptions.c (throw_exception): Take rvalue
9039         reference.
9040         * cli/cli-interp.c (safe_execute_command): Use std::move.
9041         * breakpoint.c (insert_bp_location, location_to_sals): Use
9042         std::move.
9043
9044 2019-04-25  Tom Tromey  <tromey@adacore.com>
9045
9046         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
9047         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
9048         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
9049         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
9050         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
9051         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
9052         guile/scm-value.c: Use unpack.
9053         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
9054         gdbscm_gdb_exception.
9055         (gdbscm_throw_gdb_exception): Likewise.
9056         (struct gdbscm_gdb_exception): New.
9057         (unpack): New function.
9058         (gdbscm_wrap): Use unpack.
9059
9060 2019-04-25  Tom Tromey  <tromey@adacore.com>
9061
9062         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
9063         (gdb_rl_callback_handler): Use std::move.
9064         * common/common-exceptions.h (struct gdb_exception): Add move
9065         assignment operator.
9066         (throw_exception_sjlj): Change "exception" to const reference.
9067         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
9068         (throw_exception_sjlj): Change "exception" to const reference.
9069
9070 2019-04-25  Tom Tromey  <tromey@adacore.com>
9071
9072         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
9073         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
9074         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
9075         Update.
9076         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
9077         Update.
9078         * mi/mi-interp.c (mi_interp::exec): Update.
9079         * linespec.c (parse_linespec): Update.
9080         * infcall.c (run_inferior_call): Update.
9081         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
9082         * guile/scm-symbol.c (gdbscm_lookup_symbol)
9083         (gdbscm_lookup_global_symbol): Update.
9084         * guile/scm-param.c (gdbscm_parameter_value): Update.
9085         * guile/scm-frame.c (gdbscm_frame_read_register)
9086         (gdbscm_frame_read_var): Update.
9087         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
9088         * exec.c (try_open_exec_file): Update.
9089         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
9090         (gdb_rl_callback_handler): Update.
9091         * common/common-exceptions.h (exception_none): Don't declare.
9092         * common/common-exceptions.c (exception_none): Don't define.
9093         (struct catcher) <exception>: Update.
9094         * cli/cli-interp.c (safe_execute_command): Update.
9095         * breakpoint.c (insert_bp_location, location_to_sals): Update.
9096
9097 2019-04-25  Ali Tamur  <tamur@google.com>
9098
9099         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
9100         (read_attribute_value): Likewise.
9101         (dwarf2_read_addr_index): Update comment.
9102         (read_str_index): Add DW_FORM_strx.
9103         (dwarf2_string_attr): Likewise.
9104         (dwarf2_const_value_attr): Likewise.
9105         (dump_die_shallow): Likewise.
9106         (dwarf2_fetch_constant_bytes): Likewise.
9107         (skip_form_bytes): Likewise.
9108         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
9109
9110 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
9111
9112         PR corefiles/11608
9113         PR corefiles/18187
9114         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
9115         OFFSET.  Verify if current mapping contains an ELF header.
9116         (linux_find_memory_regions_full): Adjust call to
9117         dump_mapping_p.
9118
9119 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
9120             Kang Li <kanglictf@gmail.com>
9121
9122         PR gdb/21600
9123
9124         * dwarf2-frame.c (read_initial_length): Be consistent about using
9125         unsigned representation of length.
9126         (decode_frame_entry_1): Likewise.  Check for wraparound of
9127         end pointer as well as buffer overflow.
9128
9129 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
9130
9131         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
9132         "vq".
9133
9134 2019-04-24  Tom Tromey  <tromey@adacore.com>
9135
9136         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
9137
9138 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9139
9140         * s12z-tdep.c (s12z_unwind_pc): Delete.
9141         (s12z_unwind_sp): Delete.
9142         (s12z_gdbarch_init): Don't register deleted functions with
9143         gdbarch.
9144
9145 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9146
9147         * rl78-tdep.c (rl78_unwind_sp): Delete.
9148         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
9149
9150 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9151
9152         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
9153         (xstormy16_unwind_pc): Delete.
9154         (xstormy16_dummy_id): Delete.
9155         (xstormy16_gdbarch_init): Don't register deleted functions with
9156         gdbarch.
9157
9158 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9159
9160         * vax-tdep.c (vax_unwind_pc): Delete.
9161         (vax_gdbarch_init): Don't register deleted function with gdbarch.
9162
9163 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9164
9165         * v850-tdep.c (v850_unwind_sp): Delete.
9166         (v850_unwind_pc): Delete.
9167         (v850_dummy_id): Delete.
9168         (v850_gdbarch_init): Don't register deleted functions with
9169         gdbarch.
9170
9171 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9172
9173         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
9174         (tilegx_unwind_pc): Delete.
9175         (tilegx_unwind_dummy_id): Delete.
9176         (tilegx_gdbarch_init): Don't register deleted functions with
9177         gdbarch.
9178
9179 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9180
9181         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
9182         (tic6x_dummy_id): Delete.
9183         (tic6x_gdbarch_init): Don't register deleted functions with
9184         gdbarch.
9185
9186 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9187
9188         * sparc-tdep.c (sparc_unwind_pc): Delete.
9189         (sparc32_gdbarch_init): Don't register deleted function with
9190         gdbarch.
9191
9192 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9193
9194         * sh-tdep.c (sh_unwind_sp): Delete.
9195         (sh_unwind_pc): Delete.
9196         (sh_dummy_id): Delete.
9197         (sh_gdbarch_init): Don't register deleted functions with
9198         gdbarch.
9199
9200 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9201
9202         * score-tdep.c (score_unwind_sp): Delete.
9203         (score_unwind_pc): Delete.
9204         (score_dummy_id): Delete.
9205         (score_gdbarch_init): Don't register deleted functions with
9206         gdbarch.
9207
9208 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9209
9210         * rx-tdep.c (rx_unwind_pc): Delete.
9211         (rx_unwind_sp): Delete.
9212         (rx_dummy_id): Delete.
9213         (rx_gdbarch_init): Don't register deleted functions with
9214         gdbarch.  Update comment.
9215
9216 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9217
9218         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
9219         (rs6000_dummy_id): Delete.
9220         (rs6000_gdbarch_init): Don't register deleted functions with
9221         gdbarch.
9222
9223 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9224
9225         * or1k-tdep.c (or1k_dummy_id): Delete.
9226         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
9227
9228 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9229
9230         * nios2-tdep.c (nios2_dummy_id): Delete.
9231         (nios2_unwind_sp): Delete.
9232         (nios2_gdbarch_init): Don't register deleted functions with
9233         gdbarch.
9234
9235 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9236
9237         * nds32-tdep.c (nds32_dummy_id): Delete.
9238         (nds32_unwind_pc): Delete.
9239         (nds32_unwind_sp): Delete.
9240         (nds32_gdbarch_init): Don't register deleted functions with
9241         gdbarch.
9242
9243 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9244
9245         * msp430-tdep.c (msp430_unwind_pc): Delete.
9246         (msp430_unwind_sp): Delete.
9247         (msp430_dummy_id): Delete.
9248         (msp430_gdbarch_init): Don't register deleted functions with
9249         gdbarch.
9250
9251 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9252
9253         * moxie-tdep.c (moxie_unwind_sp): Delete.
9254         (moxie_unwind_pc): Delete.
9255         (moxie_dummy_id): Delete.
9256         (moxie_gdbarch_init): Don't register deleted functions with
9257         gdbarch.
9258
9259 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9260
9261         * mn10300-tdep.c (mn10300_dummy_id): Delete.
9262         (mn10300_unwind_pc): Delete.
9263         (mn10300_unwind_sp): Delete.
9264         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
9265         mn10300_unwind_sp.
9266         (mn10300_frame_unwind_init): Don't register deleted functions with
9267         gdbarch.
9268
9269 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9270
9271         * mep-tdep.c (mep_unwind_pc): Delete.
9272         (mep_unwind_sp): Delete.
9273         (mep_dummy_id): Delete.
9274         (mep_gdbarch_init): Don't register deleted functions with
9275         gdbarch.
9276
9277 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9278
9279         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
9280         (m68hc11_unwind_sp): Delete.
9281         (m68hc11_gdbarch_init): Don't register deleted functions with
9282         gdbarch.
9283
9284 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9285
9286         * m32r-tdep.c (m32r_unwind_sp): Delete.
9287         (m32r_unwind_pc): Delete.
9288         (m32r_dummy_id): Delete.
9289         (m32r_gdbarch_init): Don't register deleted functions with
9290         gdbarch.
9291
9292 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9293
9294         * m32c-tdep.c (m32c_unwind_pc): Delete.
9295         (m32c_unwind_sp): Delete.
9296         (m32c_dummy_id): Delete.
9297         (m32c_gdbarch_init): Don't register deleted functions with
9298         gdbarch.
9299
9300 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9301
9302         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
9303         (lm32_unwind_pc): Delete.
9304         (lm32_dummy_id): Delete.
9305         (lm32_gdbarch_init): Don't register deleted functions with
9306         gdbarch.
9307
9308 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9309
9310         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
9311         (iq2000_unwind_pc): Delete.
9312         (iq2000_dummy_id): Delete.
9313         (iq2000_gdbarch_init): Don't register deleted functions with
9314         gdbarch.
9315
9316 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9317
9318         * nds32-tdep.c (nds32_type_align): Delete.
9319         (nds32_push_dummy_call): Use type_align instead.
9320
9321 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9322
9323         * arm-tdep.c (arm_type_align): Only handle vector override case.
9324         (arm_push_dummy_call): Use type_align.
9325         (arm_gdbarch_init): Register arm_type_align gdbarch function.
9326
9327 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9328
9329         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
9330         case.
9331         (pass_on_stack): Use type_align.
9332         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
9333         function.
9334
9335 2019-04-23  Tom Tromey  <tromey@adacore.com>
9336
9337         * dwarf2read.c (line_header::file_name_at): Remove unused
9338         overload.
9339
9340 2019-04-23  Tom de Vries  <tdevries@suse.de>
9341
9342         PR gdb/24438
9343         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
9344         invocation.
9345
9346
9347 2019-03-27  Ali Tamur  <tamur@google.com>
9348
9349         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
9350         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
9351         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
9352         (dwarf_expr_context::get_addr_index): Likewise
9353         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
9354         (symbol_needs_eval_context::get_addr_index): Likewise
9355         (disassemble_dwarf_expression): Add DW_OP_addrx
9356         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
9357         (read_cutu_die_from_dwo): Update comment
9358         (skip_one_die): Add DW_FORM_addrx
9359         (read_attribute_value): Likewise
9360         (var_decode_location): Add DW_OP_addrx
9361         (dwarf2_const_value_attr): Add DW_FORM_addrx
9362         (dump_die_shallow): Likewise
9363         (dwarf2_fetch_constant_bytes): Likewise
9364         (decode_locdesc): Add DW_OP_addrx
9365         (skip_form_bytes): Add DW_FORM_addrx
9366
9367 2019-04-22  Ali Tamur  <tamur@google.com>
9368
9369         * MAINTAINERS (Write After Approval): Add self.
9370
9371 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
9372
9373         * solib-svr4.c (get_svr4_info): Add pspace parameter.
9374         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
9375         (open_symbol_file_object): Likewise.
9376         (svr4_default_sos): Add info parameter.
9377         (svr4_read_so_list): Likewise.
9378         (svr4_current_sos_direct): Adjust functions calls to pass down
9379         info.
9380         (svr4_current_sos_1): Add info parameter.
9381         (svr4_current_sos): Call get_svr4_info, pass info down to
9382         svr4_current_sos_1.
9383         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
9384         get_svr4_info.
9385         (svr4_in_dynsym_resolve_code): Pass current_program_space to
9386         get_svr4_info.
9387         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
9388         to get_svr4_info.
9389         (probes_table_remove_objfile_probes): Likewise.
9390         (register_solib_event_probe): Add info parameter.
9391         (solist_update_incremental): Pass info parameter down to
9392         svr4_read_so_list.
9393         (disable_probes_interface): Add info parameter.
9394         (svr4_handle_solib_event): Pass current_program_space to
9395         get_svr4_info.  Adjust disable_probes_interface cleanup.
9396         (svr4_create_probe_breakpoints): Add info parameter, pass it
9397         down to register_solib_event_probe.
9398         (svr4_create_solib_event_breakpoints): Add info parameter,
9399         pass it down to svr4_create_probe_breakpoints.
9400         (enable_break): Pass info down to
9401         svr4_create_solib_event_breakpoints.
9402         (svr4_solib_create_inferior_hook): Pass current_program_space to
9403         get_svr4_info.
9404         (svr4_clear_solib): Likewise.
9405
9406 2019-04-22  Pedro Alves  <palves@redhat.com>
9407
9408         * solib-svr4.c (svr4_free_objfile_observer): New.
9409         (probe_and_action::objfile): New field.
9410         (probes_table_htab_remove_objfile_probes)
9411         (probes_table_remove_objfile_probes): New functions.
9412         (register_solib_event_probe): Add 'objfile' parameter.  Store it
9413         in the new probe_and_action.  Don't store the probe in 'lookup'.
9414         (svr4_create_probe_breakpoints): Pass objfile to
9415         register_solib_event_probe.
9416         (_initialize_svr4_solib): Register a free_objfile observer.
9417
9418 2019-04-19  Tom Tromey  <tom@tromey.com>
9419
9420         * common/queue.h: Remove.
9421
9422 2019-04-19  Tom Tromey  <tom@tromey.com>
9423
9424         * event-loop.c: Don't include "common/queue.h".
9425
9426 2019-04-19  Tom Tromey  <tom@tromey.com>
9427
9428         * remote.c (remote_target): Use delete.
9429         * remote-notif.h: Include <list>, not "common/queue.h".
9430         (notif_client_p): Remove typedef.
9431         (remote_notif_state): Add constructor, destructor, initializer.
9432         <notif_queue>: Now a std::list.
9433         (remote_notif_state_xfree): Don't declare.
9434         * remote-notif.c (remote_notif_process, handle_notification)
9435         (remote_notif_state_allocate): Update.
9436         (~remote_notif_state): Rename from remote_notif_state_xfree.
9437
9438 2019-04-19  Tom Tromey  <tom@tromey.com>
9439
9440         * symfile.c (reread_symbols): Update.
9441         * objfiles.c (objfile_register_static_link)
9442         (objfile_lookup_static_link): Update
9443         (~objfile) Don't delete static_links.
9444         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
9445
9446 2019-04-19  Tom Tromey  <tom@tromey.com>
9447
9448         * type-stack.h (struct type_stack) <insert>: Constify string.
9449         * type-stack.c (type_stack::insert): Constify string.
9450         * gdbtypes.h (lookup_template_type): Update.
9451         (address_space_name_to_int): Update.
9452         * gdbtypes.c (address_space_name_to_int): Make space_identifier
9453         const.
9454         (lookup_template_type): Make name const.
9455         * c-exp.y: Update rules.
9456         (lex_one_token, classify_name, classify_inner_name)
9457         (c_print_token): Update.
9458         * p-exp.y: Update rules.
9459         (yylex): Update.
9460         * f-exp.y: Update rules.
9461         (yylex): Update.
9462         * d-exp.y: Update rules.
9463         (lex_one_token, classify_name, classify_inner_name): Update.
9464         * parse.c (write_dollar_variable, copy_name): Return std::string.
9465         * parser-defs.h (copy_name): Change return type.
9466         * m2-exp.y: Update rules.
9467         (yylex): Update.
9468         * go-exp.y (lex_one_token): Update.
9469         Update rules.
9470         (classify_unsafe_function, classify_packaged_name)
9471         (classify_name, yylex): Update.
9472
9473 2019-04-19  Sergei Trofimovich <siarheit@google.com>
9474
9475         * configure.ac: add --enable-source-highlight switch.
9476         * configure: Regenerate.
9477         * top.c (print_gdb_version): plumb --enable-source-highlight
9478         status to "show configuration".
9479
9480 2019-04-19  Tom Tromey  <tromey@adacore.com>
9481
9482         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
9483         Check ADA_TYPE_P.
9484         (empty_record, ada_template_to_fixed_record_type_1)
9485         (template_to_static_fixed_type)
9486         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
9487         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
9488         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
9489         macros.
9490
9491 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
9492
9493         PR symtab/24423:
9494         * source.c (print_source_lines_base): Advance "iter" when a
9495         control character is seen.
9496
9497 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9498
9499         * inferior.h (struct infcall_suspend_state_deleter):
9500         Catch exception in destructor to avoid crash.
9501
9502 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9503
9504         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
9505         close to the add_com "shell".
9506
9507 2019-04-18  Tom Tromey  <tromey@adacore.com>
9508
9509         * process-stratum-target.h (class process_stratum_target)
9510         <stratum>: Add "final".
9511
9512 2019-04-17  Tom Tromey  <tromey@adacore.com>
9513
9514         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
9515         against nullptr before use.
9516
9517 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
9518
9519         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
9520
9521 2019-04-17  Jim Wilson  <jimw@sifive.com>
9522             Andrew Burgess  <andrew.burgess@embecosm.com>
9523
9524         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
9525         code read might fail, assume 4-byte breakpoint in that case.
9526
9527 2019-04-15  Leszek Swirski  <leszeks@google.com>
9528
9529         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
9530         rather than a hand-rolled POD check when checking for forced MEMORY
9531         classification.
9532
9533 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
9534
9535         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
9536         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
9537         function.
9538         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
9539         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
9540         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
9541         declaration.
9542
9543 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
9544
9545         * aarch64-linux-nat.c
9546         (aarch64_linux_nat_target::thread_architecture): Add override.
9547         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
9548         each VQ.
9549
9550 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
9551
9552         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
9553
9554 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
9555
9556         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
9557         target types of size 96-bits, add some additional comments, and
9558         check that the builtin type we found was the correct size.
9559
9560 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
9561
9562         * utils.c (prompt_for_continue): Don't restore the styling at the
9563         end, as applied_style has the wrong value.  This fixes styling in
9564         long lists of file names that are interrupted by the "Continue?"
9565         prompt.
9566
9567 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
9568
9569         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
9570         * c-lang.c (c_language_defn): Likewise.
9571         (cplus_language_defn): Likewise.
9572         (asm_language_defn): Likewise.
9573         (minimal_language_defn): Likewise.
9574         * d-lang.c (d_language_defn): Likewise.
9575         * f-lang.c (f_language_defn): Likewise.
9576         * go-lang.c (go_language_defn): Likewise.
9577         * language.c (unknown_language_defn): Likewise.
9578         (auto_language_defn): Likewise.
9579         * language.h (struct language_defn): Remove la_magic field.
9580         (LANG_MAGIC): Delete.
9581         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
9582         * objc-lang.c (objc_language_defn): Likewise.
9583         * opencl-lang.c (opencl_language_defn): Likewise.
9584         * p-lang.c (pascal_language_defn): Likewise.
9585         * rust-lang.c (rust_language_defn): Likewise.
9586
9587 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
9588
9589         * riscv-tdep.c (riscv_type_align): New function.
9590         (riscv_type_alignment): Delete.
9591         (riscv_arg_location): Use 'type_align'.
9592         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
9593
9594 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
9595
9596         * gdbtypes.c (type_align): A struct with no non-static fields also
9597         has alignment of 1.
9598
9599 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
9600
9601         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
9602         component to 0.
9603         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
9604         member.
9605         (riscv_struct_info::analyse): New implementation using new
9606         analyse_inner member function.
9607         (riscv_struct_info::field_offset): New member function.
9608         (riscv_struct_info::m_offsets): New member variable.
9609         (riscv_struct_info::analyse_inner): New private member function,
9610         takes the old implementation of riscv_struct_info::analyse but
9611         extended to track field offsets.
9612         (riscv_call_arg_struct): Update the struct folding special cases
9613         to handle cases where empty C++ structs, which are non-zero
9614         length, are found.
9615         (riscv_arg_location): Initialise the length of each location, a
9616         non-zero length now indicates the location is in use.
9617         (riscv_push_dummy_call): Allow for the first location having a
9618         non-zero offset when setting up arguments.
9619         (riscv_return_value): Likewise, but for return values.
9620
9621 2019-04-11  Tom Tromey  <tromey@adacore.com>
9622
9623         * utils.c (internal_vproblem): Make "msg" const.
9624
9625 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
9626
9627         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
9628         * trad-frame.c (trad_frame_reset_saved_regs): New function.
9629         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
9630         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
9631
9632 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
9633
9634         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
9635         function.
9636         (fill_gregset): Call amd64_linux_collect_native_gregset instead
9637         of amd64_collect_native_gregset.
9638         (amd64_linux_nat_target::store_registers): Likewise.
9639
9640 2019-04-10  Tom Tromey  <tom@tromey.com>
9641
9642         * symtab.c (lookup_global_symbol_from_objfile)
9643         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
9644         * objfiles.h (class separate_debug_iterator): New.
9645         (class separate_debug_range): New.
9646         (struct objfile) <separate_debug_objfiles>: New method.
9647         (objfile_separate_debug_iterate): Don't declare.
9648         * objfiles.c (separate_debug_iterator::operator++): Rename from
9649         objfile_separate_debug_iterate.
9650         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
9651         iterator.
9652         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
9653         iterator.
9654
9655 2019-04-10  Tom Tromey  <tom@tromey.com>
9656
9657         * symfile.c (reread_symbols): Remove old comment.
9658         * objfiles.c (free_all_objfiles): Fix a typo.
9659
9660 2019-04-10  Tom Tromey  <tom@tromey.com>
9661
9662         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
9663         * minsyms.c (lookup_minimal_symbol): Use foreach.
9664         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
9665         (lookup_minimal_symbol_solib_trampoline): Likewise.
9666         * symfile.c (reread_symbols): Use foreach.
9667
9668 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
9669             Tom Tromey  <tromey@adacore.com>
9670
9671         PR rust/24414:
9672         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
9673         (rust_lex_int_test): Change "value" to be LONGEST.
9674         (rust_lex_tests): Add test for long integer literal.
9675
9676 2019-04-09  Tom Tromey  <tromey@adacore.com>
9677
9678         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
9679         to bool.
9680         (extended_remote_target::attach): Update.
9681         (remote_target::remote_notice_new_inferior): Update.
9682         (remote_target::add_current_inferior_and_thread): Update.
9683         * inferior.c (exit_inferior_1): Use "false".
9684         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
9685
9686 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
9687
9688         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
9689         the "start" command.
9690
9691 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
9692
9693         * python/py-inferior.c (infpy_thread_from_thread_handle):
9694         Adjust comments to reflect renaming of thread_from_thread_handle
9695         to thread_from_handle.  Adjust keywords.  Fix type error message.
9696         (inferior_object_methods): Add thread_from_handle.  Retain
9697         thread_from_thread_handle, but mark it as deprecated.
9698
9699 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
9700
9701         * gdbthread.h (find_thread_by_handle): Revise declaration.
9702         * thread.c (find_thread_by_handle): Likewise.  Adjust
9703         implementation too.
9704         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
9705         support for buffer objects as handles.
9706
9707 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
9708
9709         * python/py-infthread.c (thpy_thread_handle): New function.
9710         (thread_object_methods): Register thpy_thread_handle.
9711
9712 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
9713
9714         * gdbthread.h (thread_to_thread_handle): Declare.
9715         * thread.c (gdbtypes.h): Include.
9716         (thread_to_thread_handle): New function.
9717
9718         * target.h (struct target_ops): Add thread_info_to_thread_handle.
9719         (target_thread_info_to_thread_handle): Declare.
9720         * target.c (target_thread_info_to_thread_handle): New function.
9721         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
9722         * target-delegates.c: Regenerate.
9723
9724         * linux-thread-db.c (class thread_db_target): Add method
9725         thread_info_to_thread_handle.
9726         (thread_db_target::thread_info_to_thread_handle): Define.
9727         * remote.c (class remote_target): Add new method
9728         thread_info_to_thread_handle.
9729         (remote_target::thread_info_to_thread_handle): Define.
9730
9731 2019-04-08  Pedro Alves  <palves@redhat.com>
9732
9733         * common/common-exceptions.c (throw_exception): Don't create
9734         named object to throw; throw directly.
9735         (throw_it): Likewise.  Don't initialize gdb_exception::message
9736         here, with new; pass FMT and AP to the ctor instead.
9737         * common/common-exceptions.h: Include <string>.
9738         (gdb_exception::gdb_exception(enum return_reason, enum errors,
9739         const char *, va_list)): New ctor.  Use std::make_shared.
9740         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
9741         errors)): Delete.
9742         (gdb_exception_error::gdb_exception_error(enum errors, const char
9743         *, va_list)): New.
9744         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
9745         Add assertion.
9746         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
9747         errors)): Delete.
9748         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
9749         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
9750         Add assertion.
9751
9752 2019-04-08  Tom Tromey  <tom@tromey.com>
9753
9754         * valops.c (value_rtti_indirect_type): Replace throw_exception
9755         with throw.
9756         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
9757         with throw.
9758         * thread.c (thr_try_catch_cmd): Replace throw_exception with
9759         throw.
9760         * target.c (target_translate_tls_address): Replace throw_exception
9761         with throw.
9762         * stack.c (frame_apply_command_count): Replace throw_exception
9763         with throw.
9764         * solib-spu.c (append_ocl_sos): Replace throw_exception with
9765         throw.
9766         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
9767         with throw.
9768         * rs6000-tdep.c (rs6000_frame_cache)
9769         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
9770         * remote.c: Replace throw_exception with throw.
9771         * record-full.c (record_full_message, record_full_wait_1)
9772         (record_full_restore): Replace throw_exception with throw.
9773         * record-btrace.c:
9774         (get_thread_current_frame_id, record_btrace_start_replaying)
9775         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
9776         (cmd_record_btrace_start): Replace throw_exception with throw.
9777         * parse.c (parse_exp_in_context_1): Replace throw_exception with
9778         throw.
9779         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
9780         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
9781         * linespec.c:
9782         (find_linespec_symbols): Replace throw_exception with throw.
9783         * infrun.c (displaced_step_prepare, resume): Replace
9784         throw_exception with throw.
9785         * infcmd.c (post_create_inferior): Replace throw_exception with
9786         throw.
9787         * inf-loop.c (inferior_event_handler): Replace throw_exception
9788         with throw.
9789         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
9790         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
9791         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
9792         (get_prev_frame_always, get_frame_pc_if_available)
9793         (get_frame_address_in_block_if_available, get_frame_language):
9794         Replace throw_exception with throw.
9795         * frame-unwind.c (frame_unwind_try_unwinder): Replace
9796         throw_exception with throw.
9797         * eval.c (fetch_subexp_value, evaluate_var_value)
9798         (evaluate_funcall, evaluate_subexp_standard): Replace
9799         throw_exception with throw.
9800         * dwarf2loc.c (call_site_find_chain)
9801         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
9802         Replace throw_exception with throw.
9803         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
9804         with throw.
9805         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
9806         throw.
9807         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
9808         * completer.c (complete_line_internal): Replace throw_exception
9809         with throw.
9810         * compile/compile-object-run.c (compile_object_run): Replace
9811         throw_exception with throw.
9812         * cli/cli-script.c (process_next_line): Replace throw_exception
9813         with throw.
9814         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
9815         (btrace_enable, btrace_maint_update_pt_packets): Replace
9816         throw_exception with throw.
9817         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
9818         throw_exception with throw.
9819         * break-catch-throw.c (re_set_exception_catchpoint): Replace
9820         throw_exception with throw.
9821         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
9822         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
9823         * aarch64-tdep.c (aarch64_make_prologue_cache)
9824         (aarch64_make_stub_cache): Replace throw_exception with throw.
9825
9826 2019-04-08  Tom Tromey  <tom@tromey.com>
9827
9828         * common/common-exceptions.c (throw_exception): Rename from
9829         throw_exception_cxx.  Remove old copy.  Make argument const.
9830         (throw_it): Create and throw exception objects directly.
9831         * common/common-exceptions.h (throw_exception): Make argument
9832         const.
9833         (struct gdb_exception_error): Add constructor.
9834         (struct gdb_exception_quit): Add constructor.
9835
9836 2019-04-08  Tom Tromey  <tom@tromey.com>
9837
9838         * common/common-exceptions.h (exception_rethrow): Don't declare.
9839         (TRY_SJLJ): Update comment.
9840         (TRY, CATCH, END_CATCH): Remove.
9841         * common/common-exceptions.c (exception_rethrow): Remove.
9842
9843 2019-04-08  Tom Tromey  <tom@tromey.com>
9844
9845         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
9846         Remove.
9847         (gdb_exception_error): Rename from
9848         gdb_exception_RETURN_MASK_ERROR.
9849         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
9850         (gdb_quit_bad_alloc): Update.
9851         * aarch64-tdep.c: Update.
9852         * ada-lang.c: Update.
9853         * ada-typeprint.c: Update.
9854         * ada-valprint.c: Update.
9855         * amd64-tdep.c: Update.
9856         * arch-utils.c: Update.
9857         * break-catch-throw.c: Update.
9858         * breakpoint.c: Update.
9859         * btrace.c: Update.
9860         * c-varobj.c: Update.
9861         * cli/cli-cmds.c: Update.
9862         * cli/cli-interp.c: Update.
9863         * cli/cli-script.c: Update.
9864         * common/common-exceptions.c: Update.
9865         * common/new-op.c: Update.
9866         * common/selftest.c: Update.
9867         * compile/compile-c-symbols.c: Update.
9868         * compile/compile-cplus-symbols.c: Update.
9869         * compile/compile-object-load.c: Update.
9870         * compile/compile-object-run.c: Update.
9871         * completer.c: Update.
9872         * corelow.c: Update.
9873         * cp-abi.c: Update.
9874         * cp-support.c: Update.
9875         * cp-valprint.c: Update.
9876         * darwin-nat.c: Update.
9877         * disasm-selftests.c: Update.
9878         * dtrace-probe.c: Update.
9879         * dwarf-index-cache.c: Update.
9880         * dwarf-index-write.c: Update.
9881         * dwarf2-frame-tailcall.c: Update.
9882         * dwarf2-frame.c: Update.
9883         * dwarf2loc.c: Update.
9884         * dwarf2read.c: Update.
9885         * eval.c: Update.
9886         * event-loop.c: Update.
9887         * event-top.c: Update.
9888         * exec.c: Update.
9889         * f-valprint.c: Update.
9890         * fbsd-tdep.c: Update.
9891         * frame-unwind.c: Update.
9892         * frame.c: Update.
9893         * gdbtypes.c: Update.
9894         * gnu-v3-abi.c: Update.
9895         * guile/guile-internal.h: Update.
9896         * guile/scm-block.c: Update.
9897         * guile/scm-breakpoint.c: Update.
9898         * guile/scm-cmd.c: Update.
9899         * guile/scm-disasm.c: Update.
9900         * guile/scm-frame.c: Update.
9901         * guile/scm-lazy-string.c: Update.
9902         * guile/scm-math.c: Update.
9903         * guile/scm-param.c: Update.
9904         * guile/scm-ports.c: Update.
9905         * guile/scm-pretty-print.c: Update.
9906         * guile/scm-symbol.c: Update.
9907         * guile/scm-symtab.c: Update.
9908         * guile/scm-type.c: Update.
9909         * guile/scm-value.c: Update.
9910         * i386-linux-tdep.c: Update.
9911         * i386-tdep.c: Update.
9912         * inf-loop.c: Update.
9913         * infcall.c: Update.
9914         * infcmd.c: Update.
9915         * infrun.c: Update.
9916         * jit.c: Update.
9917         * language.c: Update.
9918         * linespec.c: Update.
9919         * linux-fork.c: Update.
9920         * linux-nat.c: Update.
9921         * linux-tdep.c: Update.
9922         * linux-thread-db.c: Update.
9923         * main.c: Update.
9924         * mi/mi-cmd-break.c: Update.
9925         * mi/mi-cmd-stack.c: Update.
9926         * mi/mi-interp.c: Update.
9927         * mi/mi-main.c: Update.
9928         * objc-lang.c: Update.
9929         * p-valprint.c: Update.
9930         * parse.c: Update.
9931         * ppc-linux-tdep.c: Update.
9932         * printcmd.c: Update.
9933         * python/py-arch.c: Update.
9934         * python/py-breakpoint.c: Update.
9935         * python/py-cmd.c: Update.
9936         * python/py-finishbreakpoint.c: Update.
9937         * python/py-frame.c: Update.
9938         * python/py-framefilter.c: Update.
9939         * python/py-gdb-readline.c: Update.
9940         * python/py-inferior.c: Update.
9941         * python/py-infthread.c: Update.
9942         * python/py-lazy-string.c: Update.
9943         * python/py-linetable.c: Update.
9944         * python/py-objfile.c: Update.
9945         * python/py-param.c: Update.
9946         * python/py-prettyprint.c: Update.
9947         * python/py-progspace.c: Update.
9948         * python/py-record-btrace.c: Update.
9949         * python/py-record.c: Update.
9950         * python/py-symbol.c: Update.
9951         * python/py-type.c: Update.
9952         * python/py-unwind.c: Update.
9953         * python/py-utils.c: Update.
9954         * python/py-value.c: Update.
9955         * python/python.c: Update.
9956         * record-btrace.c: Update.
9957         * record-full.c: Update.
9958         * remote-fileio.c: Update.
9959         * remote.c: Update.
9960         * riscv-tdep.c: Update.
9961         * rs6000-aix-tdep.c: Update.
9962         * rs6000-tdep.c: Update.
9963         * rust-exp.y: Update.
9964         * rust-lang.c: Update.
9965         * s390-tdep.c: Update.
9966         * selftest-arch.c: Update.
9967         * solib-dsbt.c: Update.
9968         * solib-frv.c: Update.
9969         * solib-spu.c: Update.
9970         * solib-svr4.c: Update.
9971         * solib.c: Update.
9972         * sparc64-linux-tdep.c: Update.
9973         * stack.c: Update.
9974         * symfile-mem.c: Update.
9975         * symmisc.c: Update.
9976         * target.c: Update.
9977         * thread.c: Update.
9978         * top.c: Update.
9979         * tracefile-tfile.c: Update.
9980         * tui/tui.c: Update.
9981         * typeprint.c: Update.
9982         * unittests/cli-utils-selftests.c: Update.
9983         * unittests/parse-connection-spec-selftests.c: Update.
9984         * valops.c: Update.
9985         * valprint.c: Update.
9986         * value.c: Update.
9987         * varobj.c: Update.
9988         * windows-nat.c: Update.
9989         * x86-linux-nat.c: Update.
9990         * xml-support.c: Update.
9991
9992 2019-04-08  Tom Tromey  <tom@tromey.com>
9993
9994         * xml-support.c: Use C++ exception handling.
9995         * x86-linux-nat.c: Use C++ exception handling.
9996         * windows-nat.c: Use C++ exception handling.
9997         * varobj.c: Use C++ exception handling.
9998         * value.c: Use C++ exception handling.
9999         * valprint.c: Use C++ exception handling.
10000         * valops.c: Use C++ exception handling.
10001         * unittests/parse-connection-spec-selftests.c: Use C++ exception
10002         handling.
10003         * unittests/cli-utils-selftests.c: Use C++ exception handling.
10004         * typeprint.c: Use C++ exception handling.
10005         * tui/tui.c: Use C++ exception handling.
10006         * tracefile-tfile.c: Use C++ exception handling.
10007         * top.c: Use C++ exception handling.
10008         * thread.c: Use C++ exception handling.
10009         * target.c: Use C++ exception handling.
10010         * symmisc.c: Use C++ exception handling.
10011         * symfile-mem.c: Use C++ exception handling.
10012         * stack.c: Use C++ exception handling.
10013         * sparc64-linux-tdep.c: Use C++ exception handling.
10014         * solib.c: Use C++ exception handling.
10015         * solib-svr4.c: Use C++ exception handling.
10016         * solib-spu.c: Use C++ exception handling.
10017         * solib-frv.c: Use C++ exception handling.
10018         * solib-dsbt.c: Use C++ exception handling.
10019         * selftest-arch.c: Use C++ exception handling.
10020         * s390-tdep.c: Use C++ exception handling.
10021         * rust-lang.c: Use C++ exception handling.
10022         * rust-exp.y: Use C++ exception handling.
10023         * rs6000-tdep.c: Use C++ exception handling.
10024         * rs6000-aix-tdep.c: Use C++ exception handling.
10025         * riscv-tdep.c: Use C++ exception handling.
10026         * remote.c: Use C++ exception handling.
10027         * remote-fileio.c: Use C++ exception handling.
10028         * record-full.c: Use C++ exception handling.
10029         * record-btrace.c: Use C++ exception handling.
10030         * python/python.c: Use C++ exception handling.
10031         * python/py-value.c: Use C++ exception handling.
10032         * python/py-utils.c: Use C++ exception handling.
10033         * python/py-unwind.c: Use C++ exception handling.
10034         * python/py-type.c: Use C++ exception handling.
10035         * python/py-symbol.c: Use C++ exception handling.
10036         * python/py-record.c: Use C++ exception handling.
10037         * python/py-record-btrace.c: Use C++ exception handling.
10038         * python/py-progspace.c: Use C++ exception handling.
10039         * python/py-prettyprint.c: Use C++ exception handling.
10040         * python/py-param.c: Use C++ exception handling.
10041         * python/py-objfile.c: Use C++ exception handling.
10042         * python/py-linetable.c: Use C++ exception handling.
10043         * python/py-lazy-string.c: Use C++ exception handling.
10044         * python/py-infthread.c: Use C++ exception handling.
10045         * python/py-inferior.c: Use C++ exception handling.
10046         * python/py-gdb-readline.c: Use C++ exception handling.
10047         * python/py-framefilter.c: Use C++ exception handling.
10048         * python/py-frame.c: Use C++ exception handling.
10049         * python/py-finishbreakpoint.c: Use C++ exception handling.
10050         * python/py-cmd.c: Use C++ exception handling.
10051         * python/py-breakpoint.c: Use C++ exception handling.
10052         * python/py-arch.c: Use C++ exception handling.
10053         * printcmd.c: Use C++ exception handling.
10054         * ppc-linux-tdep.c: Use C++ exception handling.
10055         * parse.c: Use C++ exception handling.
10056         * p-valprint.c: Use C++ exception handling.
10057         * objc-lang.c: Use C++ exception handling.
10058         * mi/mi-main.c: Use C++ exception handling.
10059         * mi/mi-interp.c: Use C++ exception handling.
10060         * mi/mi-cmd-stack.c: Use C++ exception handling.
10061         * mi/mi-cmd-break.c: Use C++ exception handling.
10062         * main.c: Use C++ exception handling.
10063         * linux-thread-db.c: Use C++ exception handling.
10064         * linux-tdep.c: Use C++ exception handling.
10065         * linux-nat.c: Use C++ exception handling.
10066         * linux-fork.c: Use C++ exception handling.
10067         * linespec.c: Use C++ exception handling.
10068         * language.c: Use C++ exception handling.
10069         * jit.c: Use C++ exception handling.
10070         * infrun.c: Use C++ exception handling.
10071         * infcmd.c: Use C++ exception handling.
10072         * infcall.c: Use C++ exception handling.
10073         * inf-loop.c: Use C++ exception handling.
10074         * i386-tdep.c: Use C++ exception handling.
10075         * i386-linux-tdep.c: Use C++ exception handling.
10076         * guile/scm-value.c: Use C++ exception handling.
10077         * guile/scm-type.c: Use C++ exception handling.
10078         * guile/scm-symtab.c: Use C++ exception handling.
10079         * guile/scm-symbol.c: Use C++ exception handling.
10080         * guile/scm-pretty-print.c: Use C++ exception handling.
10081         * guile/scm-ports.c: Use C++ exception handling.
10082         * guile/scm-param.c: Use C++ exception handling.
10083         * guile/scm-math.c: Use C++ exception handling.
10084         * guile/scm-lazy-string.c: Use C++ exception handling.
10085         * guile/scm-frame.c: Use C++ exception handling.
10086         * guile/scm-disasm.c: Use C++ exception handling.
10087         * guile/scm-cmd.c: Use C++ exception handling.
10088         * guile/scm-breakpoint.c: Use C++ exception handling.
10089         * guile/scm-block.c: Use C++ exception handling.
10090         * guile/guile-internal.h: Use C++ exception handling.
10091         * gnu-v3-abi.c: Use C++ exception handling.
10092         * gdbtypes.c: Use C++ exception handling.
10093         * frame.c: Use C++ exception handling.
10094         * frame-unwind.c: Use C++ exception handling.
10095         * fbsd-tdep.c: Use C++ exception handling.
10096         * f-valprint.c: Use C++ exception handling.
10097         * exec.c: Use C++ exception handling.
10098         * event-top.c: Use C++ exception handling.
10099         * event-loop.c: Use C++ exception handling.
10100         * eval.c: Use C++ exception handling.
10101         * dwarf2read.c: Use C++ exception handling.
10102         * dwarf2loc.c: Use C++ exception handling.
10103         * dwarf2-frame.c: Use C++ exception handling.
10104         * dwarf2-frame-tailcall.c: Use C++ exception handling.
10105         * dwarf-index-write.c: Use C++ exception handling.
10106         * dwarf-index-cache.c: Use C++ exception handling.
10107         * dtrace-probe.c: Use C++ exception handling.
10108         * disasm-selftests.c: Use C++ exception handling.
10109         * darwin-nat.c: Use C++ exception handling.
10110         * cp-valprint.c: Use C++ exception handling.
10111         * cp-support.c: Use C++ exception handling.
10112         * cp-abi.c: Use C++ exception handling.
10113         * corelow.c: Use C++ exception handling.
10114         * completer.c: Use C++ exception handling.
10115         * compile/compile-object-run.c: Use C++ exception handling.
10116         * compile/compile-object-load.c: Use C++ exception handling.
10117         * compile/compile-cplus-symbols.c: Use C++ exception handling.
10118         * compile/compile-c-symbols.c: Use C++ exception handling.
10119         * common/selftest.c: Use C++ exception handling.
10120         * common/new-op.c: Use C++ exception handling.
10121         * cli/cli-script.c: Use C++ exception handling.
10122         * cli/cli-interp.c: Use C++ exception handling.
10123         * cli/cli-cmds.c: Use C++ exception handling.
10124         * c-varobj.c: Use C++ exception handling.
10125         * btrace.c: Use C++ exception handling.
10126         * breakpoint.c: Use C++ exception handling.
10127         * break-catch-throw.c: Use C++ exception handling.
10128         * arch-utils.c: Use C++ exception handling.
10129         * amd64-tdep.c: Use C++ exception handling.
10130         * ada-valprint.c: Use C++ exception handling.
10131         * ada-typeprint.c: Use C++ exception handling.
10132         * ada-lang.c: Use C++ exception handling.
10133         * aarch64-tdep.c: Use C++ exception handling.
10134
10135 2019-04-08  Tom Tromey  <tom@tromey.com>
10136
10137         * xml-support.c (gdb_xml_parser::parse): Update.
10138         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
10139         * value.c (show_convenience): Update.
10140         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
10141         (test_parse_flags_qcs): Update.
10142         * thread.c (thr_try_catch_cmd): Update.
10143         * target.c (target_translate_tls_address): Update.
10144         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
10145         (info_frame_command_core, frame_apply_command_count): Update.
10146         * rust-exp.y (rust_lex_exception_test): Update.
10147         * riscv-tdep.c (riscv_print_one_register_info): Update.
10148         * remote.c (remote_target::enable_btrace): Update.
10149         * record-btrace.c (record_btrace_enable_warn): Update.
10150         * python/py-utils.c (gdbpy_convert_exception): Update.
10151         * printcmd.c (do_one_display, print_variable_and_value): Update.
10152         * mi/mi-main.c (mi_print_exception): Update.
10153         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
10154         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
10155         * linux-nat.c (linux_nat_target::attach): Update.
10156         * linux-fork.c (class scoped_switch_fork_info): Update.
10157         * infrun.c (displaced_step_prepare): Update.
10158         * infcall.c (call_function_by_hand_dummy): Update.
10159         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
10160         * gnu-v3-abi.c (print_one_vtable): Update.
10161         * frame.c (get_prev_frame_always): Update.
10162         * f-valprint.c (info_common_command_for_block): Update.
10163         * exec.c (try_open_exec_file): Update.
10164         * exceptions.c (print_exception, exception_print)
10165         (exception_fprintf, exception_print_same): Update.
10166         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
10167         * dwarf-index-cache.c (index_cache::store)
10168         (index_cache::lookup_gdb_index): Update.
10169         * darwin-nat.c (maybe_cache_shell): Update.
10170         * cp-valprint.c (cp_print_value_fields): Update.
10171         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
10172         (gcc_cplus_symbol_address): Update.
10173         * compile/compile-c-symbols.c (gcc_convert_symbol)
10174         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
10175         * common/selftest.c: Update.
10176         * common/common-exceptions.h (struct gdb_exception) <message>: Now
10177         a std::string.
10178         (exception_try_scope_entry, exception_try_scope_exit): Don't
10179         declare.
10180         (struct exception_try_scope): Remove.
10181         (TRY): Don't use exception_try_scope.
10182         (struct gdb_exception): Add constructor, operator=.
10183         <what>: New method.
10184         (struct gdb_exception_RETURN_MASK_ALL)
10185         (struct gdb_exception_RETURN_MASK_ERROR)
10186         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
10187         (struct gdb_quit_bad_alloc): Update.
10188         * common/common-exceptions.c (exception_none): Change
10189         initializer.
10190         (struct catcher) <state, exception>: Initialize inline.
10191         <prev>: Remove member.
10192         (current_catcher): Remove.
10193         (catchers): New global.
10194         (exceptions_state_mc_init): Simplify.
10195         (catcher_pop): Remove.
10196         (exceptions_state_mc, exceptions_state_mc_catch): Update.
10197         (try_scope_depth, exception_try_scope_entry)
10198         (exception_try_scope_exit): Remove.
10199         (throw_exception_sjlj): Update.
10200         (exception_messages, exception_messages_size): Remove.
10201         (throw_it): Simplify.
10202         (gdb_exception_sliced_copy): Remove.
10203         (throw_exception_cxx): Update.
10204         * cli/cli-script.c (script_from_file): Update.
10205         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
10206         Update.
10207         * ada-valprint.c (ada_val_print): Update.
10208         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
10209         (create_excep_cond_exprs): Update.
10210
10211 2019-04-08  Tom Tromey  <tom@tromey.com>
10212
10213         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
10214         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
10215         (TRY, CATCH, END_CATCH): Remove some definitions.
10216         * common/common-exceptions.c: Don't use GDB_XCPT.
10217         (catcher_list_size): Remove.
10218         (throw_exception, throw_it): Simplify.
10219
10220 2019-04-05  Tom Tromey  <tom@tromey.com>
10221
10222         Revert the header-sorting patch.
10223         * ft32-tdep.c: Revert.
10224         * frv-tdep.c: Revert.
10225         * frv-linux-tdep.c: Revert.
10226         * frame.c: Revert.
10227         * frame-unwind.c: Revert.
10228         * frame-base.c: Revert.
10229         * fork-child.c: Revert.
10230         * findvar.c: Revert.
10231         * findcmd.c: Revert.
10232         * filesystem.c: Revert.
10233         * filename-seen-cache.h: Revert.
10234         * filename-seen-cache.c: Revert.
10235         * fbsd-tdep.c: Revert.
10236         * fbsd-nat.h: Revert.
10237         * fbsd-nat.c: Revert.
10238         * f-valprint.c: Revert.
10239         * f-typeprint.c: Revert.
10240         * f-lang.c: Revert.
10241         * extension.h: Revert.
10242         * extension.c: Revert.
10243         * extension-priv.h: Revert.
10244         * expprint.c: Revert.
10245         * exec.h: Revert.
10246         * exec.c: Revert.
10247         * exceptions.c: Revert.
10248         * event-top.c: Revert.
10249         * event-loop.c: Revert.
10250         * eval.c: Revert.
10251         * elfread.c: Revert.
10252         * dwarf2read.h: Revert.
10253         * dwarf2read.c: Revert.
10254         * dwarf2loc.c: Revert.
10255         * dwarf2expr.h: Revert.
10256         * dwarf2expr.c: Revert.
10257         * dwarf2-frame.c: Revert.
10258         * dwarf2-frame-tailcall.c: Revert.
10259         * dwarf-index-write.h: Revert.
10260         * dwarf-index-write.c: Revert.
10261         * dwarf-index-common.c: Revert.
10262         * dwarf-index-cache.h: Revert.
10263         * dwarf-index-cache.c: Revert.
10264         * dummy-frame.c: Revert.
10265         * dtrace-probe.c: Revert.
10266         * disasm.h: Revert.
10267         * disasm.c: Revert.
10268         * disasm-selftests.c: Revert.
10269         * dictionary.c: Revert.
10270         * dicos-tdep.c: Revert.
10271         * demangle.c: Revert.
10272         * dcache.h: Revert.
10273         * dcache.c: Revert.
10274         * darwin-nat.h: Revert.
10275         * darwin-nat.c: Revert.
10276         * darwin-nat-info.c: Revert.
10277         * d-valprint.c: Revert.
10278         * d-namespace.c: Revert.
10279         * d-lang.c: Revert.
10280         * ctf.c: Revert.
10281         * csky-tdep.c: Revert.
10282         * csky-linux-tdep.c: Revert.
10283         * cris-tdep.c: Revert.
10284         * cris-linux-tdep.c: Revert.
10285         * cp-valprint.c: Revert.
10286         * cp-support.c: Revert.
10287         * cp-namespace.c: Revert.
10288         * cp-abi.c: Revert.
10289         * corelow.c: Revert.
10290         * corefile.c: Revert.
10291         * continuations.c: Revert.
10292         * completer.h: Revert.
10293         * completer.c: Revert.
10294         * complaints.c: Revert.
10295         * coffread.c: Revert.
10296         * coff-pe-read.c: Revert.
10297         * cli-out.h: Revert.
10298         * cli-out.c: Revert.
10299         * charset.c: Revert.
10300         * c-varobj.c: Revert.
10301         * c-valprint.c: Revert.
10302         * c-typeprint.c: Revert.
10303         * c-lang.c: Revert.
10304         * buildsym.c: Revert.
10305         * buildsym-legacy.c: Revert.
10306         * build-id.h: Revert.
10307         * build-id.c: Revert.
10308         * btrace.c: Revert.
10309         * bsd-uthread.c: Revert.
10310         * breakpoint.h: Revert.
10311         * breakpoint.c: Revert.
10312         * break-catch-throw.c: Revert.
10313         * break-catch-syscall.c: Revert.
10314         * break-catch-sig.c: Revert.
10315         * blockframe.c: Revert.
10316         * block.c: Revert.
10317         * bfin-tdep.c: Revert.
10318         * bfin-linux-tdep.c: Revert.
10319         * bfd-target.c: Revert.
10320         * bcache.c: Revert.
10321         * ax-general.c: Revert.
10322         * ax-gdb.h: Revert.
10323         * ax-gdb.c: Revert.
10324         * avr-tdep.c: Revert.
10325         * auxv.c: Revert.
10326         * auto-load.c: Revert.
10327         * arm-wince-tdep.c: Revert.
10328         * arm-tdep.c: Revert.
10329         * arm-symbian-tdep.c: Revert.
10330         * arm-pikeos-tdep.c: Revert.
10331         * arm-obsd-tdep.c: Revert.
10332         * arm-nbsd-tdep.c: Revert.
10333         * arm-nbsd-nat.c: Revert.
10334         * arm-linux-tdep.c: Revert.
10335         * arm-linux-nat.c: Revert.
10336         * arm-fbsd-tdep.c: Revert.
10337         * arm-fbsd-nat.c: Revert.
10338         * arm-bsd-tdep.c: Revert.
10339         * arch-utils.c: Revert.
10340         * arc-tdep.c: Revert.
10341         * arc-newlib-tdep.c: Revert.
10342         * annotate.h: Revert.
10343         * annotate.c: Revert.
10344         * amd64-windows-tdep.c: Revert.
10345         * amd64-windows-nat.c: Revert.
10346         * amd64-tdep.c: Revert.
10347         * amd64-sol2-tdep.c: Revert.
10348         * amd64-obsd-tdep.c: Revert.
10349         * amd64-obsd-nat.c: Revert.
10350         * amd64-nbsd-tdep.c: Revert.
10351         * amd64-nbsd-nat.c: Revert.
10352         * amd64-nat.c: Revert.
10353         * amd64-linux-tdep.c: Revert.
10354         * amd64-linux-nat.c: Revert.
10355         * amd64-fbsd-tdep.c: Revert.
10356         * amd64-fbsd-nat.c: Revert.
10357         * amd64-dicos-tdep.c: Revert.
10358         * amd64-darwin-tdep.c: Revert.
10359         * amd64-bsd-nat.c: Revert.
10360         * alpha-tdep.c: Revert.
10361         * alpha-obsd-tdep.c: Revert.
10362         * alpha-nbsd-tdep.c: Revert.
10363         * alpha-mdebug-tdep.c: Revert.
10364         * alpha-linux-tdep.c: Revert.
10365         * alpha-linux-nat.c: Revert.
10366         * alpha-bsd-tdep.c: Revert.
10367         * alpha-bsd-nat.c: Revert.
10368         * aix-thread.c: Revert.
10369         * agent.c: Revert.
10370         * addrmap.c: Revert.
10371         * ada-varobj.c: Revert.
10372         * ada-valprint.c: Revert.
10373         * ada-typeprint.c: Revert.
10374         * ada-tasks.c: Revert.
10375         * ada-lang.c: Revert.
10376         * aarch64-tdep.c: Revert.
10377         * aarch64-ravenscar-thread.c: Revert.
10378         * aarch64-newlib-tdep.c: Revert.
10379         * aarch64-linux-tdep.c: Revert.
10380         * aarch64-linux-nat.c: Revert.
10381         * aarch64-fbsd-tdep.c: Revert.
10382         * aarch64-fbsd-nat.c: Revert.
10383         * aarch32-linux-nat.c: Revert.
10384
10385 2019-04-05  Tom Tromey  <tom@tromey.com>
10386
10387         * ft32-tdep.c: Sort headers.
10388         * frv-tdep.c: Sort headers.
10389         * frv-linux-tdep.c: Sort headers.
10390         * frame.c: Sort headers.
10391         * frame-unwind.c: Sort headers.
10392         * frame-base.c: Sort headers.
10393         * fork-child.c: Sort headers.
10394         * findvar.c: Sort headers.
10395         * findcmd.c: Sort headers.
10396         * filesystem.c: Sort headers.
10397         * filename-seen-cache.h: Sort headers.
10398         * filename-seen-cache.c: Sort headers.
10399         * fbsd-tdep.c: Sort headers.
10400         * fbsd-nat.h: Sort headers.
10401         * fbsd-nat.c: Sort headers.
10402         * f-valprint.c: Sort headers.
10403         * f-typeprint.c: Sort headers.
10404         * f-lang.c: Sort headers.
10405         * extension.h: Sort headers.
10406         * extension.c: Sort headers.
10407         * extension-priv.h: Sort headers.
10408         * expprint.c: Sort headers.
10409         * exec.h: Sort headers.
10410         * exec.c: Sort headers.
10411         * exceptions.c: Sort headers.
10412         * event-top.c: Sort headers.
10413         * event-loop.c: Sort headers.
10414         * eval.c: Sort headers.
10415         * elfread.c: Sort headers.
10416         * dwarf2read.h: Sort headers.
10417         * dwarf2read.c: Sort headers.
10418         * dwarf2loc.c: Sort headers.
10419         * dwarf2expr.h: Sort headers.
10420         * dwarf2expr.c: Sort headers.
10421         * dwarf2-frame.c: Sort headers.
10422         * dwarf2-frame-tailcall.c: Sort headers.
10423         * dwarf-index-write.h: Sort headers.
10424         * dwarf-index-write.c: Sort headers.
10425         * dwarf-index-common.c: Sort headers.
10426         * dwarf-index-cache.h: Sort headers.
10427         * dwarf-index-cache.c: Sort headers.
10428         * dummy-frame.c: Sort headers.
10429         * dtrace-probe.c: Sort headers.
10430         * disasm.h: Sort headers.
10431         * disasm.c: Sort headers.
10432         * disasm-selftests.c: Sort headers.
10433         * dictionary.c: Sort headers.
10434         * dicos-tdep.c: Sort headers.
10435         * demangle.c: Sort headers.
10436         * dcache.h: Sort headers.
10437         * dcache.c: Sort headers.
10438         * darwin-nat.h: Sort headers.
10439         * darwin-nat.c: Sort headers.
10440         * darwin-nat-info.c: Sort headers.
10441         * d-valprint.c: Sort headers.
10442         * d-namespace.c: Sort headers.
10443         * d-lang.c: Sort headers.
10444         * ctf.c: Sort headers.
10445         * csky-tdep.c: Sort headers.
10446         * csky-linux-tdep.c: Sort headers.
10447         * cris-tdep.c: Sort headers.
10448         * cris-linux-tdep.c: Sort headers.
10449         * cp-valprint.c: Sort headers.
10450         * cp-support.c: Sort headers.
10451         * cp-namespace.c: Sort headers.
10452         * cp-abi.c: Sort headers.
10453         * corelow.c: Sort headers.
10454         * corefile.c: Sort headers.
10455         * continuations.c: Sort headers.
10456         * completer.h: Sort headers.
10457         * completer.c: Sort headers.
10458         * complaints.c: Sort headers.
10459         * coffread.c: Sort headers.
10460         * coff-pe-read.c: Sort headers.
10461         * cli-out.h: Sort headers.
10462         * cli-out.c: Sort headers.
10463         * charset.c: Sort headers.
10464         * c-varobj.c: Sort headers.
10465         * c-valprint.c: Sort headers.
10466         * c-typeprint.c: Sort headers.
10467         * c-lang.c: Sort headers.
10468         * buildsym.c: Sort headers.
10469         * buildsym-legacy.c: Sort headers.
10470         * build-id.h: Sort headers.
10471         * build-id.c: Sort headers.
10472         * btrace.c: Sort headers.
10473         * bsd-uthread.c: Sort headers.
10474         * breakpoint.h: Sort headers.
10475         * breakpoint.c: Sort headers.
10476         * break-catch-throw.c: Sort headers.
10477         * break-catch-syscall.c: Sort headers.
10478         * break-catch-sig.c: Sort headers.
10479         * blockframe.c: Sort headers.
10480         * block.c: Sort headers.
10481         * bfin-tdep.c: Sort headers.
10482         * bfin-linux-tdep.c: Sort headers.
10483         * bfd-target.c: Sort headers.
10484         * bcache.c: Sort headers.
10485         * ax-general.c: Sort headers.
10486         * ax-gdb.h: Sort headers.
10487         * ax-gdb.c: Sort headers.
10488         * avr-tdep.c: Sort headers.
10489         * auxv.c: Sort headers.
10490         * auto-load.c: Sort headers.
10491         * arm-wince-tdep.c: Sort headers.
10492         * arm-tdep.c: Sort headers.
10493         * arm-symbian-tdep.c: Sort headers.
10494         * arm-pikeos-tdep.c: Sort headers.
10495         * arm-obsd-tdep.c: Sort headers.
10496         * arm-nbsd-tdep.c: Sort headers.
10497         * arm-nbsd-nat.c: Sort headers.
10498         * arm-linux-tdep.c: Sort headers.
10499         * arm-linux-nat.c: Sort headers.
10500         * arm-fbsd-tdep.c: Sort headers.
10501         * arm-fbsd-nat.c: Sort headers.
10502         * arm-bsd-tdep.c: Sort headers.
10503         * arch-utils.c: Sort headers.
10504         * arc-tdep.c: Sort headers.
10505         * arc-newlib-tdep.c: Sort headers.
10506         * annotate.h: Sort headers.
10507         * annotate.c: Sort headers.
10508         * amd64-windows-tdep.c: Sort headers.
10509         * amd64-windows-nat.c: Sort headers.
10510         * amd64-tdep.c: Sort headers.
10511         * amd64-sol2-tdep.c: Sort headers.
10512         * amd64-obsd-tdep.c: Sort headers.
10513         * amd64-obsd-nat.c: Sort headers.
10514         * amd64-nbsd-tdep.c: Sort headers.
10515         * amd64-nbsd-nat.c: Sort headers.
10516         * amd64-nat.c: Sort headers.
10517         * amd64-linux-tdep.c: Sort headers.
10518         * amd64-linux-nat.c: Sort headers.
10519         * amd64-fbsd-tdep.c: Sort headers.
10520         * amd64-fbsd-nat.c: Sort headers.
10521         * amd64-dicos-tdep.c: Sort headers.
10522         * amd64-darwin-tdep.c: Sort headers.
10523         * amd64-bsd-nat.c: Sort headers.
10524         * alpha-tdep.c: Sort headers.
10525         * alpha-obsd-tdep.c: Sort headers.
10526         * alpha-nbsd-tdep.c: Sort headers.
10527         * alpha-mdebug-tdep.c: Sort headers.
10528         * alpha-linux-tdep.c: Sort headers.
10529         * alpha-linux-nat.c: Sort headers.
10530         * alpha-bsd-tdep.c: Sort headers.
10531         * alpha-bsd-nat.c: Sort headers.
10532         * aix-thread.c: Sort headers.
10533         * agent.c: Sort headers.
10534         * addrmap.c: Sort headers.
10535         * ada-varobj.c: Sort headers.
10536         * ada-valprint.c: Sort headers.
10537         * ada-typeprint.c: Sort headers.
10538         * ada-tasks.c: Sort headers.
10539         * ada-lang.c: Sort headers.
10540         * aarch64-tdep.c: Sort headers.
10541         * aarch64-ravenscar-thread.c: Sort headers.
10542         * aarch64-newlib-tdep.c: Sort headers.
10543         * aarch64-linux-tdep.c: Sort headers.
10544         * aarch64-linux-nat.c: Sort headers.
10545         * aarch64-fbsd-tdep.c: Sort headers.
10546         * aarch64-fbsd-nat.c: Sort headers.
10547         * aarch32-linux-nat.c: Sort headers.
10548
10549 2019-04-04  Tom Tromey  <tom@tromey.com>
10550
10551         * varobj.c (varobj_create): Update.
10552         * rust-exp.y (struct rust_parser) <update_innermost_block,
10553         lookup_symbol>: New methods.
10554         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
10555         Rename.
10556         (rust_parser::rust_lookup_type)
10557         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
10558         * printcmd.c (display_command, do_one_display): Update.
10559         * parser-defs.h (struct parser_state) <parser_state>: Add
10560         "tracker" parameter.
10561         (block_tracker): New member.
10562         (class innermost_block_tracker) <innermost_block_tracker>: Add
10563         "types" parameter.
10564         <reset>: Remove method.
10565         (innermost_block): Don't declare.
10566         (null_post_parser): Update.
10567         * parse.c (innermost_block): Remove global.
10568         (write_dollar_variable): Update.
10569         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
10570         Remove "tracker_types" parameter.
10571         (parse_expression): Add "tracker" parameter.
10572         (parse_expression_for_completion): Update.
10573         (null_post_parser): Add "tracker" parameter.
10574         * p-exp.y: Update rules.
10575         * m2-exp.y: Update rules.
10576         * language.h (struct language_defn) <la_post_parser>: Add
10577         "tracker" parameter.
10578         * go-exp.y: Update rules.
10579         * f-exp.y: Update rules.
10580         * expression.h (parse_expression, parse_exp_1): Add "tracker"
10581         parameter.
10582         * d-exp.y: Update rules.
10583         * c-exp.y: Update rules.
10584         * breakpoint.c (set_breakpoint_condition): Create an
10585         innermost_block_tracker.
10586         (watch_command_1): Likewise.
10587         * ada-lang.c (resolve): Add "tracker" parameter.
10588         (resolve_subexp): Likewise.
10589         * ada-exp.y (write_var_from_sym): Update.
10590
10591 2019-04-04  Tom Tromey  <tom@tromey.com>
10592
10593         * type-stack.h: New file.
10594         * type-stack.c: New file.
10595         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
10596         type-stack.h.
10597         (insert_into_type_stack, insert_type, push_type, push_type_int)
10598         (insert_type_address_space, pop_type, pop_type_int)
10599         (pop_typelist, pop_type_stack, append_type_stack)
10600         (push_type_stack, get_type_stack, push_typelist)
10601         (follow_type_instance_flags, follow_types): Don't declare.
10602         * parse.c (type_stack): Remove global.
10603         (parse_exp_in_context): Update.
10604         (insert_into_type_stack, insert_type, push_type, push_type_int)
10605         (insert_type_address_space, pop_type, pop_type_int)
10606         (pop_typelist, pop_type_stack, append_type_stack)
10607         (push_type_stack, get_type_stack, push_typelist)
10608         (follow_type_instance_flags, follow_types): Remove (moved to
10609         type-stack.c).
10610         * f-exp.y (type_stack): New global.
10611         Update rules.
10612         (push_kind_type, f_parse): Update.
10613         * d-exp.y (type_stack): New global.
10614         Update rules.
10615         (d_parse): Update.
10616         * c-exp.y (struct c_parse_state) <type_stack>: New member.
10617         Update rules.
10618         * Makefile.in (COMMON_SFILES): Add type-stack.c.
10619         (HFILES_NO_SRCDIR): Add type-stack.h.
10620
10621 2019-04-04  Tom Tromey  <tom@tromey.com>
10622
10623         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
10624         (rust_parser::convert_ast_to_expression, rust_parse)
10625         (rust_lex_test_completion, rust_lex_tests): Update.
10626         * parser-defs.h (struct expr_completion_state): New.
10627         (struct parser_state) <parser_state>: Add completion parameter.
10628         <mark_struct_expression, mark_completion_tag>: New methods.
10629         <parse_completion, m_completion_state>: New members.
10630         (prefixify_expression, null_post_parser): Update.
10631         (mark_struct_expression, mark_completion_tag): Don't declare.
10632         * parse.c (parse_completion, expout_last_struct)
10633         (expout_tag_completion_type, expout_completion_name): Remove
10634         globals.
10635         (parser_state::mark_struct_expression)
10636         (parser_state::mark_completion_tag): Now methods.
10637         (prefixify_expression): Add last_struct parameter.
10638         (prefixify_subexp): Likewise.
10639         (parse_exp_1): Update.
10640         (parse_exp_in_context): Add cstate parameter.  Update.
10641         (parse_expression_for_completion): Create an
10642         expr_completion_state.
10643         (null_post_parser): Add "completion" parameter.
10644         * p-exp.y: Update rules.
10645         (yylex): Update.
10646         * language.h (struct language_defn) <la_post_parser>: Add
10647         "completing" parameter.
10648         * go-exp.y: Update rules.
10649         (lex_one_token): Update.
10650         * expression.h (parse_completion): Don't declare.
10651         * d-exp.y: Update rules.
10652         (lex_one_token): Update rules.
10653         * c-exp.y: Update rules.
10654         (lex_one_token): Update.
10655         * ada-lang.c (resolve): Add "parse_completion" parameter.
10656         (resolve_subexp): Likewise.
10657         (ada_resolve_function): Likewise.
10658
10659 2019-04-04  Tom Tromey  <tom@tromey.com>
10660
10661         * parser-defs.h (struct parser_state) <start_arglist,
10662         end_arglist>: New methods.
10663         <arglist_len, m_funcall_chain>: New members.
10664         (arglist_len, start_arglist, end_arglist): Don't declare.
10665         * parse.c (arglist_len, funcall_chain): Remove global.
10666         (start_arglist, end_arglist): Remove functions.
10667         (parse_exp_in_context): Update.
10668         * p-exp.y: Update rules.
10669         * m2-exp.y: Update rules.
10670         * go-exp.y: Update rules.
10671         * f-exp.y: Update rules.
10672         * d-exp.y: Update rules.
10673         * c-exp.y: Update rules.
10674
10675 2019-04-04  Tom Tromey  <tom@tromey.com>
10676
10677         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
10678         lex_operator, push_back>: New methods.
10679         Update all rules.
10680         (rust_parser::lex_hex, lex_escape): Rename and update.
10681         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
10682         (rust_parser::lex_operator): Rename and update.
10683         (rust_parser::lex_number, rustyylex, rustyyerror)
10684         (rust_lex_test_init, rust_lex_test_sequence)
10685         (rust_lex_test_push_back, rust_lex_tests): Update.
10686         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
10687         parameter.
10688         <lexptr, prev_lexptr>: New members.
10689         (lexptr, prev_lexptr): Don't declare.
10690         * parse.c (lexptr, prev_lexptr): Remove globals.
10691         (parse_exp_in_context): Update.
10692         * p-exp.y (yylex, yyerror): Update.
10693         * m2-exp.y (parse_number, yylex, yyerror): Update.
10694         * go-exp.y (lex_one_token, yyerror): Update.
10695         * f-exp.y (match_string_literal, yylex, yyerror): Update.
10696         * d-exp.y (lex_one_token, yyerror): Update.
10697         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
10698         (lex_one_token, yyerror): Update.
10699         * ada-lex.l (YY_INPUT): Update.
10700         (rewind_to_char): Update.
10701         * ada-exp.y (yyerror): Update.
10702
10703 2019-04-04  Tom Tromey  <tom@tromey.com>
10704
10705         * rust-exp.y (rustyylex, rust_lex_tests): Update.
10706         * parser-defs.h (struct parser_state) <parser_state>: Add new
10707         parameter.
10708         <comma_terminates>: New member.
10709         (comma_terminates): Don't declare global.
10710         * parse.c (comma_terminates): Remove global.
10711         (parse_exp_in_context): Update.
10712         * p-exp.y (yylex): Update.
10713         * m2-exp.y (yylex): Update.
10714         * go-exp.y (lex_one_token): Update.
10715         * f-exp.y (yylex): Update.
10716         * d-exp.y (lex_one_token): Update.
10717         * c-exp.y (lex_one_token): Update.
10718         * ada-lex.l: Update.
10719
10720 2019-04-04  Tom Tromey  <tom@tromey.com>
10721
10722         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
10723         (rustyylex, rust_lex_test_init, rust_lex_test_one)
10724         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
10725         * parser-defs.h (paren_depth): Don't declare.
10726         * parse.c (paren_depth): Remove global.
10727         (parse_exp_in_context): Update.
10728         * p-exp.y (paren_depth): New global.
10729         (pascal_parse): Initialize it.
10730         * m2-exp.y (paren_depth): New global.
10731         (m2_parse): Initialize it.
10732         * go-exp.y (paren_depth): New global.
10733         (go_parse): Initialize it.
10734         * f-exp.y (paren_depth): New global.
10735         (f_parse): Initialize it.
10736         * d-exp.y (paren_depth): New global.
10737         (d_parse): Initialize it.
10738         * c-exp.y (paren_depth): New global.
10739         (c_parse): Initialize it.
10740         * ada-lex.l (paren_depth): New global.
10741         (lexer_init): Initialize it.
10742
10743 2019-04-04  Tom Tromey  <tom@tromey.com>
10744
10745         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
10746         (rust_parser::convert_ast_to_type)
10747         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
10748         * parser-defs.h (struct parser_state) <parser_state>: Add
10749         parameters.  Initialize new members.
10750         <expression_context_block, expression_context_pc>: New members.
10751         * parse.c (expression_context_block, expression_context_pc):
10752         Remove globals.
10753         (parse_exp_in_context): Update.
10754         * p-exp.y: Update all rules.
10755         (yylex): Update.
10756         * m2-exp.y: Update all rules.
10757         (yylex): Update.
10758         * go-exp.y (yylex): Update.
10759         * f-exp.y (yylex): Update.
10760         * d-exp.y: Update all rules.
10761         (yylex): Update.
10762         * c-exp.y: Update all rules.
10763         (lex_one_token, classify_name, yylex, c_parse): Update.
10764         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
10765
10766 2019-04-04  Tom Tromey  <tom@tromey.com>
10767
10768         * gdbarch.h, gdbarch.c: Rebuild.
10769         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
10770         * stap-probe.h:
10771         (struct stap_parse_info): Replace "parser_state" with
10772         "expr_builder".
10773         * parser-defs.h (struct expr_builder): Rename from "parser_state".
10774         (parser_state): New class.
10775         * parse.c (expr_builder): Rename.
10776         (expr_builder::release): Rename.
10777         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
10778         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
10779         (write_exp_elt_longcst, write_exp_elt_floatcst)
10780         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
10781         (write_exp_string_vector, write_exp_bitstring)
10782         (write_exp_msymbol, mark_struct_expression)
10783         (write_dollar_variable)
10784         (insert_type_address_space, increase_expout_size): Replace
10785         "parser_state" with "expr_builder".
10786         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
10787         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
10788         "parser_state" with "expr_builder".
10789
10790 2019-04-04  Tom Tromey  <tom@tromey.com>
10791
10792         * rust-exp.y: Replace "parse_language" with method call.
10793         * p-exp.y:
10794         (yylex): Replace "parse_language" with method call.
10795         * m2-exp.y:
10796         (yylex): Replace "parse_language" with method call.
10797         * go-exp.y (classify_name): Replace "parse_language" with method
10798         call.
10799         * f-exp.y (yylex): Replace "parse_language" with method call.
10800         * d-exp.y (lex_one_token): Replace "parse_language" with method
10801         call.
10802         * c-exp.y:
10803         (lex_one_token, classify_name, yylex): Replace "parse_language"
10804         with method call.
10805         * ada-exp.y (find_primitive_type, type_char)
10806         (type_system_address): Replace "parse_language" with method call.
10807
10808 2019-04-04  Tom Tromey  <tom@tromey.com>
10809
10810         * rust-exp.y: Replace "parse_gdbarch" with method call.
10811         * parse.c (write_dollar_variable, insert_type_address_space):
10812         Replace "parse_gdbarch" with method call.
10813         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
10814         call.
10815         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
10816         call.
10817         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
10818         "parse_gdbarch" with method call.
10819         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
10820         with method call.
10821         * f-exp.y (parse_type, parse_f_type, yylex): Replace
10822         "parse_gdbarch" with method call.
10823         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
10824         "parse_gdbarch" with method call.
10825         * c-exp.y (parse_type, parse_number, classify_name): Replace
10826         "parse_gdbarch" with method call.
10827         * ada-lex.l: Replace "parse_gdbarch" with method call.
10828         * ada-exp.y (parse_type, find_primitive_type, type_char)
10829         (type_system_address): Replace "parse_gdbarch" with method call.
10830
10831 2019-04-04  Tom Tromey  <tom@tromey.com>
10832
10833         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
10834         * stap-probe.c (stap_parse_argument): Update.
10835         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
10836         initial_size parameter.
10837         * rust-exp.y (rust_lex_tests): Update.
10838         * parse.c (parser_state): Update.
10839         (parse_exp_in_context): Update.
10840         * parser-defs.h (struct parser_state) <parser_state>: Remove
10841         "initial_size" parameter.
10842
10843 2019-04-04  Tom Tromey  <tom@tromey.com>
10844
10845         * parser-defs.h (increase_expout_size): Don't declare.
10846         * parse.c (increase_expout_size): Now static.
10847
10848 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
10849
10850         * gnu-nat.c (gnu_nat_target::wait): Fix
10851         target_waitstatus_to_string call.
10852
10853 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
10854
10855         * eval.c (evaluate_subexp_standard): Handle internal functions
10856         during Fortran function call handling.
10857
10858 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
10859
10860         * NEWS: Mention new internal functions.
10861         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
10862         (read_base_type): Use dwarf2_init_complex_target_type.
10863         * value.c (creal_internal_fn): New function.
10864         (cimag_internal_fn): New function.
10865         (_initialize_values): Register new internal functions.
10866
10867 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10868
10869         * infrun.c (stop_all_threads): If debug_infrun, always
10870         trace the wait status after wait_one, using
10871         target_waitstatus_to_string and target_pid_to_str.
10872         (handle_inferior_event): Replace various trace of
10873         wait status kind by a single trace.
10874         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
10875         wait status kind image by target_waitstatus_to_string.
10876         * target/waitstatus.c (target_waitstatus_to_string): Fix
10877         obsolete comment.
10878
10879 2019-04-01  Tom Tromey  <tromey@adacore.com>
10880
10881         PR symtab/23331:
10882         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
10883
10884 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
10885             Pedro Alves  <palves@redhat.com>
10886
10887         * top.c (quit_force): Call 'finalize_values'.
10888         * value.c (finalize_values): New function.
10889         * value.h (finalize_values): Declare.
10890
10891 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
10892
10893         * NEWS: Announce $_gdb_major and $_gdb_minor.
10894
10895         * top.c (init_gdb_version_vars): New function.
10896         (gdb_init): Call init_gdb_version_vars.
10897
10898 2019-03-29  Tom Tromey  <tromey@adacore.com>
10899
10900         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
10901         help text.  Remove dead code.
10902
10903 2019-03-29  Keith Seitz  <keiths@redhat.com>
10904
10905         From Siddhesh Poyarekar:
10906         * f-lang.h (f77_get_upperbound): Return LONGEST.
10907         (f77_get_lowerbound): Likewise.
10908         * f-typeprint.c (f_type_print_varspec_suffix): Expand
10909         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
10910         print them.
10911         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
10912         plongest to format print it.
10913         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
10914         (f77_get_upperbound): Likewise.
10915         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
10916         LOWER_BOUND to LONGEST.
10917         (f77_create_arrayprint_offset_tbl): Likewise.
10918
10919 2019-03-29  Keith Seitz  <keiths@redhat.com>
10920
10921         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
10922         %s/pulongest for TYPE_LENGTH instead of %d in format
10923         strings.
10924         * ada-typerint.c (ada_print_type): Likewise.
10925         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
10926         * compile/compile-c-support.c (generate_register_struct): Likewise.
10927         * gdbtypes.c (recursive_dump_type): Likewise.
10928         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
10929         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
10930         instead of %d in format strings.
10931         * riscv-tdep.c (riscv_type_alignment): Cast second argument
10932         to std::min to ULONGEST.
10933         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
10934         instead of %d in format strings.
10935         * tracepoint.c (info_scope_command): Likewise.
10936         * typeprint.c (print_offset_data::update)
10937         (print_offset_data::finish): Likewise.
10938         * xtensa-tdep.c (xtensa_store_return_value)
10939         (xtensa_push_dummy_call): Likewise.
10940
10941 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
10942
10943         * windows-nat.c (display_selector): Fixed format specifications
10944         for 64-bit Cygwin.
10945
10946 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10947
10948         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
10949
10950 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
10951
10952         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
10953         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
10954         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
10955         (nios2_linux_init_abi): Install it.
10956
10957 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
10958
10959         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
10960
10961 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
10962
10963         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
10964
10965 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10966             Tom Tromey  <tromey@adacore.com>
10967
10968         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
10969
10970 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
10971
10972         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
10973         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
10974         method to compute the bounds of range types. Also print "[evaluated]"
10975         if the bounds' values come from a dynamic evaluation.
10976
10977 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
10978
10979         * cp-valprint.c (cp_print_value_fields): Don't print trailing
10980         whitespace when pretty printing is on.
10981
10982 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
10983
10984         * ppc-linux-nat.c: Add include.
10985
10986 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
10987
10988         * NEWS: Mention AArch64 Pointer Authentication.
10989
10990 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
10991
10992         * arm-linux-nat.c: Add include.
10993
10994 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
10995
10996         * source-cache.c (source_cache::get_source_lines): Re-read
10997         fullname after calling open_source_file.
10998
10999 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
11000
11001         * NEWS: Mention TLS support for FreeBSD.
11002
11003 2019-03-25  Tom Tromey  <tromey@adacore.com>
11004
11005         * minsyms.c (BUNCH_SIZE): Update comment.
11006         (~minimal_symbol_reader): Remove old comment.
11007         (compact_minimal_symbols): Update comment.
11008         (minimal_symbol_reader::install): Remove old comment.  Update
11009         other comments.
11010
11011 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
11012
11013         * s390-linux-nat.c: Add include.
11014
11015 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
11016
11017         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
11018         Call linux_get_hwcap.
11019         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
11020         Likewise.
11021         (aarch64_linux_get_hwcap): Remove function.
11022         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
11023         declaration.
11024         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
11025         linux_get_hwcap.
11026         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
11027         * linux-tdep.c (linux_get_hwcap): Add function.
11028         (linux_get_hwcap2): Likewise.
11029         * linux-tdep.h (linux_get_hwcap): Add declaration.
11030         (linux_get_hwcap2): Likewise.
11031         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
11032         (ppc_linux_get_hwcap2): Likewise.
11033         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
11034         linux_get_hwcap.
11035         (ppc_linux_nat_target::insert_watchpoint): Likewise.
11036         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
11037         (ppc_linux_nat_target::read_description): Likewise.
11038         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
11039         * s390-linux-nat.c: Likewise.
11040         * s390-linux-tdep.c (s390_core_read_description): Likewise.
11041
11042 2019-03-24  Tom Tromey  <tom@tromey.com>
11043
11044         * ada-lang.c (standard_lookup): Simplify initialization.
11045         (ada_lookup_symbol_nonlocal): Simplify return.
11046         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
11047         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
11048         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
11049         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
11050         initialization.
11051         * solib.c (solib_global_lookup): Simplify.
11052         * symtab.c (null_block_symbol): Remove.
11053         (symbol_cache_lookup): Simplify returns.
11054         (lookup_language_this): Simplify returns.
11055         (lookup_symbol_aux): Simplify return.
11056         (lookup_local_symbol): Simplify returns.
11057         (lookup_global_symbol_from_objfile): Simplify return.
11058         (lookup_symbol_in_objfile_symtabs)
11059         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
11060         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
11061         (lookup_static_symbol, lookup_global_symbol): Simplify return.
11062         * cp-namespace.c (cp_lookup_bare_symbol)
11063         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
11064         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
11065         (cp_lookup_nested_symbol): Don't use null_block_symbol.
11066         (cp_lookup_symbol_via_imports): Simplify initialization.
11067         (find_symbol_in_baseclass): Likewise.
11068         * symtab.h (null_block_symbol): Remove.
11069         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
11070         (d_lookup_nested_symbol, d_lookup_symbol_imports)
11071         (d_lookup_symbol_module): Likewise.
11072         (find_symbol_in_baseclass): Simplify initialization.
11073
11074 2019-03-24  Tom Tromey  <tom@tromey.com>
11075
11076         * expression.h: Don't include symtab.h.
11077         (struct block): Forward declare.
11078
11079 2019-03-24  Tom Tromey  <tom@tromey.com>
11080
11081         * c-exp.y (typebase): Remove casts.
11082         * gdbtypes.c (lookup_unsigned_typename, )
11083         (lookup_signed_typename): Remove cast.
11084         * eval.c (parse_to_comma_and_eval): Remove cast.
11085         * parse.c (write_dollar_variable): Remove cast.
11086         * block.h (struct block) <superblock>: Now const.
11087         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
11088         * psymtab.c (psym_map_matching_symbols): Make "block" const.
11089         (map_block): Make "block" const.
11090         * symfile.h (struct quick_symbol_functions)
11091         <map_matching_symbols>: Constify block argument to "callback".
11092         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
11093         const.
11094         (find_pc_sect_compunit_symtab): Make "b" const.
11095         (find_symbol_at_address): Likewise.
11096         (search_symbols): Likewise.
11097         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
11098         (dw2_debug_names_lookup_symbol): Likewise.
11099         (dw2_map_matching_symbols): Update.
11100         * p-valprint.c (pascal_val_print): Remove "block".
11101         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
11102         (aux_add_nonlocal_symbols): Make "block" const.
11103         (resolve_subexp): Remove cast.
11104         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
11105         const.
11106         (iterate_over_file_blocks): Likewise.
11107         * f-exp.y (%union) <bval>: Remove.
11108         * coffread.c (patch_opaque_types): Make "b" const.
11109         * spu-tdep.c (spu_catch_start): Make "block" const.
11110         * c-valprint.c (print_unpacked_pointer): Remove "block".
11111         * symmisc.c (dump_symtab_1): Make "b" const.
11112         (block_depth): Make "block" const.
11113         * d-exp.y (%union) <bval>: Remove.
11114         * cp-support.h (cp_lookup_rtti_type): Update.
11115         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
11116         * psymtab.c (psym_lookup_symbol): Make "block" const.
11117         (maintenance_check_psymtabs): Make "b" const.
11118         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
11119         (enumerate_locals, enumerate_args): Update.
11120         * python/py-symtab.c (stpy_global_block): Make "block" const.
11121         (stpy_static_block): Likewise.
11122         * inline-frame.c (block_starting_point_at): Make "new_block"
11123         const.
11124         * block.c (find_block_in_blockvector): Make return type const.
11125         (blockvector_for_pc_sect): Make "b" const.
11126         (find_block_in_blockvector): Make "b" const.
11127
11128 2019-03-23  Tom Tromey  <tom@tromey.com>
11129
11130         * varobj.c (varobj_create): Update.
11131         * symfile.c (clear_symtab_users): Don't reset innermost_block.
11132         * printcmd.c (display_command, do_one_display): Don't reset
11133         innermost_block.
11134         * parser-defs.h (enum innermost_block_tracker_type): Move to
11135         expression.h.
11136         (innermost_block): Update comment.
11137         * parse.c (parse_exp_1): Add tracker_types parameter.
11138         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
11139         tracker_types parameter.  Reset innermost_block.
11140         (parse_exp_in_context): Remove.
11141         (parse_expression_for_completion): Update.
11142         * objfiles.c (~objfile): Don't reset expression_context_block or
11143         innermost_block.
11144         * expression.h (enum innermost_block_tracker_type): Move from
11145         parser-defs.h.
11146         (parse_exp_1): Add tracker_types parameter.
11147         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
11148         reset innermost_block.
11149
11150 2019-03-23  Tom Tromey  <tom@tromey.com>
11151
11152         * objfiles.h: Include bcache.h.
11153
11154 2019-03-23  Tom Tromey  <tom@tromey.com>
11155
11156         * linespec.c (get_current_search_block): Use
11157         scoped_restore_current_language.
11158         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
11159
11160 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
11161             Jiong Wang  <jiong.wang@arm.com>
11162
11163         * aarch64-linux-tdep.c
11164         (aarch64_linux_iterate_over_regset_sections): Check for pauth
11165         section.
11166         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
11167
11168 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
11169             Jiong Wang  <jiong.wang@arm.com>
11170
11171         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
11172         instructions.
11173         (aarch64_analyze_prologue_test): Add PACIASP test.
11174         (aarch64_prologue_prev_register): Unmask PC value.
11175
11176 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
11177             Jiong Wang  <jiong.wang@arm.com>
11178
11179         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
11180         (aarch64_dwarf2_prev_register): Unmask PC value.
11181         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
11182         (aarch64_execute_dwarf_cfa_vendor_op): Check for
11183         DW_CFA_AARCH64_negate_ra_state.
11184         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
11185
11186 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
11187             Jiong Wang  <jiong.wang@arm.com>
11188
11189         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
11190         registers.
11191         (aarch64_pseudo_register_name): Likewise.
11192         (aarch64_pseudo_register_type): Likewise.
11193         (aarch64_pseudo_register_reggroup_p): Likewise.
11194         (aarch64_gdbarch_init): Add pauth registers.
11195         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
11196         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
11197         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
11198         (struct gdbarch_tdep): Add regnum for ra_state.
11199
11200 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
11201             Jiong Wang  <jiong.wang@arm.com>
11202
11203         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
11204
11205 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
11206             Jiong Wang  <jiong.wang@arm.com>
11207
11208         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
11209         function.
11210         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
11211         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
11212         (aarch64_gdbarch_init): Add puth registers.
11213         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
11214         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
11215         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
11216
11217 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
11218             Jiong Wang  <jiong.wang@arm.com>
11219
11220         * aarch64-linux-nat.c
11221         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
11222         * aarch64-linux-tdep.c
11223         (aarch64_linux_core_read_description): Likewise.
11224         (aarch64_linux_get_hwcap): New function.
11225         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
11226         (aarch64_linux_get_hwcap): New declaration.
11227
11228 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
11229             Jiong Wang  <jiong.wang@arm.com>
11230
11231         * aarch64-linux-nat.c
11232         (aarch64_linux_nat_target::read_description): Add pauth param.
11233         * aarch64-linux-tdep.c
11234         (aarch64_linux_core_read_description): Likewise.
11235         * aarch64-tdep.c (struct target_desc): Add in pauth.
11236         (aarch64_read_description): Add pauth param.
11237         (aarch64_gdbarch_init): Likewise.
11238         * aarch64-tdep.h (aarch64_read_description): Likewise.
11239         * arch/aarch64.c (aarch64_create_target_description): Likewise.
11240         * arch/aarch64.h (aarch64_create_target_description): Likewise.
11241         * features/Makefile: Add new files.
11242         * features/aarch64-pauth.c: New file.
11243         * features/aarch64-pauth.xml: New file.
11244
11245 2019-03-20  Tom Tromey  <tromey@adacore.com>
11246
11247         * infrun.c (handle_inferior_event): Rename from
11248         handle_inferior_event_1.  Create a scoped_value_mark.
11249         (handle_inferior_event): Remove.
11250
11251 2019-03-19  Tom Tromey  <tromey@adacore.com>
11252
11253         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
11254         * infrun.h (print_stop_event): Add "displays" parameter.
11255         * infrun.c (print_stop_event): Add "displays" parameter.
11256
11257 2019-03-19  Pedro Alves  <palves@redhat.com>
11258
11259         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
11260         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
11261         to -1.  Fix TABs vs spaces.
11262         (tui_ui_out::tui_ui_out): Don't initialize fields here.
11263         * tui/tui-out.h (tui_ui_out) Add intro comments.
11264         <m_line, m_start_of_line>: In-class initialize, and add describing
11265         comment.
11266
11267 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
11268
11269         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
11270         variable names.
11271         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
11272
11273 2019-03-18  Pedro Alves  <palves@redhat.com>
11274             Eli Zaretskii <eliz@gnu.org>
11275
11276         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
11277         m_line and m_start_of_line.
11278
11279 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
11280
11281         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
11282         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
11283         it returns a newline.  This fixes a regression in TU mode, whereby
11284         the next line is output on the same screen line as the user input.
11285
11286 2019-03-18  Tom Tromey  <tromey@adacore.com>
11287
11288         * minsyms.c (minimal_symbol_reader::install): Remove call to
11289         obstack_blank.
11290
11291 2019-03-18  Pedro Alves  <palves@redhat.com>
11292
11293         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
11294         New globals.
11295         (apply_style): New, factored out from ...
11296         (apply_ansi_escape): ... this.  Handle reverse video mode.
11297         (tui_set_reverse_mode): New function.
11298         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
11299         * tui/tui-winsource.c (tui_show_source_line): Use
11300         tui_set_reverse_mode instead of setting A_STANDOUT.
11301         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
11302         New setter methods.
11303
11304 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
11305
11306         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
11307         Handle tabs.
11308
11309 2019-03-18  Tom Tromey  <tromey@adacore.com>
11310
11311         * ada-lang.c (empty_array): Add "high" parameter.
11312         (ada_evaluate_subexp): Update.
11313
11314 2019-03-17  Sergei Trofimovich <siarheit@google.com>
11315
11316         * unittests/string_view-selftests.c: Define
11317         _initialize_string_view_selftests unconditionally.
11318
11319 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
11320
11321         PR gdb/24350
11322         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
11323
11324 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
11325
11326         PR gdb/24351
11327         * windows-nat.c (display_selector): Fix format specifiers.
11328
11329 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
11330
11331         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
11332         tui_refill_source_window instead of tui_refresh_win, to update the
11333         current execution line.  This fixes redisplay of the current line
11334         when stepping through the code with "next" or "step".
11335
11336 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
11337
11338         * source-cache.c (source_cache::get_source_lines): Call
11339         find_source_lines to initialize s->nlines.  This fixes vertical
11340         scrolling of TUI source window when the DOWN arrow is pressed.
11341
11342 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11343
11344         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
11345         linux-thread-db.c (_initialize_thread_db): Likewise.
11346
11347 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
11348
11349         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
11350         wclrtoeol in tui_show_source_line".  This reverts changes made in
11351         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
11352
11353 2019-03-15  Tom Tromey  <tom@tromey.com>
11354
11355         * symtab.h (struct minimal_symbol): Derive from
11356         general_symbol_info.
11357         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
11358         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
11359         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
11360         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
11361         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
11362         (MSYMBOL_SEARCH_NAME): Update.
11363         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
11364         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
11365         * minsyms.c (minimal_symbol_reader::record_full): Update.
11366
11367 2019-03-15  Tom Tromey  <tom@tromey.com>
11368
11369         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
11370
11371 2019-03-15  Tom Tromey  <tom@tromey.com>
11372
11373         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
11374         unique_xmalloc_ptr.
11375         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
11376         Update.
11377         * minsyms.c (lookup_minimal_symbol_by_pc_section)
11378         (build_minimal_symbol_hash_tables)
11379         (minimal_symbol_reader::install): Update.
11380
11381 2019-03-15  Tom Tromey  <tom@tromey.com>
11382
11383         * symtab.c (create_demangled_names_hash): Update.
11384         (symbol_set_names): Update.
11385         * objfiles.h (struct objfile_per_bfd_storage)
11386         <demangled_names_hash>: Now an htab_up.
11387         * objfiles.c (objfile_per_bfd_storage): Simplify.
11388
11389 2019-03-15  Tom Tromey  <tom@tromey.com>
11390
11391         * objfiles.h (struct objfile_per_bfd_storage): Declare
11392         destructor.
11393         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
11394         New.
11395         (get_objfile_bfd_data): Use new.  Don't initialize
11396         language_of_main.
11397         (free_objfile_per_bfd_storage): Remove.
11398         (objfile_bfd_data_free, objfile::~objfile): Use delete.
11399
11400 2019-03-15  Tom Tromey  <tom@tromey.com>
11401
11402         * symfile.c (reread_symbols): Update.
11403         * objfiles.c (objfile::objfile): Update.
11404         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
11405         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
11406         comment.
11407         (minimal_symbol_reader::install): Update.
11408         (terminate_minimal_symbol_table): Remove.
11409         * jit.c (jit_object_close_impl): Update.
11410
11411 2019-03-15  Tom Tromey  <tom@tromey.com>
11412
11413         * minsyms.c (minimal_symbol_reader::record_full): Remove some
11414         initializations.
11415
11416 2019-03-15  Tom Tromey  <tom@tromey.com>
11417
11418         * objfiles.h (struct objfile_per_bfd_storage)
11419         <demangled_hash_languages>: Now a bitset.
11420         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
11421         (lookup_minimal_symbol): Update.
11422
11423 2019-03-15  Tom Tromey  <tom@tromey.com>
11424
11425         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
11426         Don't return the symbol.
11427         * coffread.c (record_minimal_symbol): Use record_full.
11428
11429 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
11430
11431         The MS-Windows port of ncurses fails to switch to a color pair if
11432         one or both of the colors are the implicit default colors.  This
11433         change records the default colors when TUI is initialized, and
11434         then specifies them explicitly when a color pair uses the default
11435         colors.  This allows color styling in TUI mode on MS-Windows.
11436
11437         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
11438         ncurses_norm_attr.
11439         (tui_initialize_io) [__MINGW32__]: Record the default terminal
11440         colors in ncurses_norm_attr.
11441         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
11442         "none", replace it with the default color recorded in
11443         ncurses_norm_attr.
11444
11445 2019-03-14  Tom Tromey  <tromey@adacore.com>
11446
11447         * source-cache.h (class source_cache) <get_source_lines>: Return
11448         std::string.
11449         * source-cache.c (source_cache::extract_lines): Handle case where
11450         first_pos==npos.  Return std::string.
11451         (source_cache::get_source_lines): Update.
11452
11453 2019-03-14  Tom Tromey  <tromey@adacore.com>
11454
11455         * NEWS: Add item for "style sources" commands.
11456         * source-cache.c (source_cache::get_source_lines): Check
11457         source_styling.
11458         * cli/cli-style.c (source_styling): New global.
11459         (_initialize_cli_style): Add "style sources" commands.
11460         (show_style_sources): New function.
11461         * cli/cli-style.h (source_styling): Declare.
11462
11463 2019-03-14  Pedro Alves  <palves@redhat.com>
11464             Tom Tromey  <tromey@adacore.com>
11465
11466         * tui/tui-winsource.h (tui_refill_source_window): Declare.
11467         * tui/tui-winsource.c (tui_refill_source_window): New function,
11468         from...
11469         (tui_horizontal_source_scroll): ... here.  Move some logic.
11470         * cli/cli-style.c (set_style_enabled): Notify new observable.
11471         * tui/tui-hooks.c (tui_redisplay_source): New function.
11472         (tui_attach_detach_observers): Attach or detach
11473         tui_redisplay_source.
11474         * observable.h (source_styling_changed): New observable.
11475         * observable.c: Define source_styling_changed observable.
11476
11477 2019-03-13  Tom Tromey  <tromey@adacore.com>
11478
11479         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
11480         (i386_gnu_nat_target::store_registers): Update.
11481         * target-debug.h (target_debug_print_std_string): New macro.
11482         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
11483         * windows-tdep.c (display_one_tib): Update.
11484         * tui/tui-stack.c (tui_make_status_line): Update.
11485         * top.c (print_inferior_quit_action): Update.
11486         * thread.c (thr_try_catch_cmd): Update.
11487         (add_thread_with_info): Update.
11488         (thread_target_id_str): Update.
11489         (thr_try_catch_cmd): Update.
11490         (thread_command): Update.
11491         (thread_find_command): Update.
11492         * record-btrace.c (record_btrace_target::info_record)
11493         (record_btrace_resume_thread, record_btrace_target::resume)
11494         (record_btrace_cancel_resume, record_btrace_step_thread)
11495         (record_btrace_target::wait, record_btrace_target::wait)
11496         (record_btrace_target::wait, record_btrace_target::stop): Update.
11497         * progspace.c (print_program_space): Update.
11498         * process-stratum-target.c
11499         (process_stratum_target::thread_address_space): Update.
11500         * linux-fork.c (linux_fork_mourn_inferior)
11501         (detach_checkpoint_command, info_checkpoints_command)
11502         (linux_fork_context): Update.
11503         (linux_fork_detach): Update.
11504         (class scoped_switch_fork_info): Update.
11505         (delete_checkpoint_command): Update.
11506         * infrun.c (follow_fork_inferior): Update.
11507         (follow_fork_inferior): Update.
11508         (proceed_after_vfork_done): Update.
11509         (handle_vfork_child_exec_or_exit): Update.
11510         (follow_exec): Update.
11511         (displaced_step_prepare_throw): Update.
11512         (displaced_step_restore): Update.
11513         (start_step_over): Update.
11514         (resume_1): Update.
11515         (clear_proceed_status_thread): Update.
11516         (proceed): Update.
11517         (print_target_wait_results): Update.
11518         (do_target_wait): Update.
11519         (context_switch): Update.
11520         (stop_all_threads): Update.
11521         (restart_threads): Update.
11522         (finish_step_over): Update.
11523         (handle_signal_stop): Update.
11524         (switch_back_to_stepped_thread): Update.
11525         (keep_going_pass_signal): Update.
11526         (print_exited_reason): Update.
11527         (normal_stop): Update.
11528         * inferior.c (inferior_pid_to_str): Change return type.
11529         (print_selected_inferior): Update.
11530         (add_inferior): Update.
11531         (detach_inferior): Update.
11532         * dummy-frame.c (fprint_dummy_frames): Update.
11533         * dcache.c (dcache_info_1): Update.
11534         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
11535         (btrace_fetch, btrace_clear): Update.
11536         * linux-tdep.c (linux_core_pid_to_str): Change return type.
11537         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
11538         type.
11539         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
11540         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
11541         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
11542         * gdbarch.c, gdbarch.h: Rebuild.
11543         * gdbarch.sh (core_pid_to_str): Change return type.
11544         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
11545         return type.
11546         (windows_nat_target::pid_to_str): Change return type.
11547         (windows_delete_thread): Update.
11548         (windows_nat_target::attach): Update.
11549         (windows_nat_target::files_info): Update.
11550         * target-delegates.c: Rebuild.
11551         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
11552         return type.
11553         (sol_thread_target::pid_to_str): Change return type.
11554         * remote.c (class remote_target) <pid_to_str>: Change return
11555         type.
11556         (remote_target::pid_to_str): Change return type.
11557         (extended_remote_target::attach, remote_target::remote_stop_ns)
11558         (remote_target::remote_notif_remove_queued_reply)
11559         (remote_target::push_stop_reply, remote_target::disable_btrace):
11560         Update.
11561         (extended_remote_target::attach): Update.
11562         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
11563         type.
11564         (gdbsim_target::pid_to_str): Change return type.
11565         * ravenscar-thread.c (struct ravenscar_thread_target)
11566         <pid_to_str>: Change return type.
11567         (ravenscar_thread_target::pid_to_str): Change return type.
11568         * procfs.c (class procfs_target) <pid_to_str>: Change return
11569         type.
11570         (procfs_target::pid_to_str): Change return type.
11571         (procfs_target::attach): Update.
11572         (procfs_target::detach): Update.
11573         (procfs_target::fetch_registers): Update.
11574         (procfs_target::store_registers): Update.
11575         (procfs_target::wait): Update.
11576         (procfs_target::files_info): Update.
11577         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
11578         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
11579         return type.
11580         (nto_procfs_target::pid_to_str): Change return type.
11581         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
11582         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
11583         return type.
11584         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
11585         (exit_lwp): Update.
11586         (attach_proc_task_lwp_callback, get_detach_signal)
11587         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
11588         (linux_nat_target::resume, wait_lwp, stop_callback)
11589         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
11590         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
11591         (linux_nat_wait_1, resume_stopped_resumed_lwps)
11592         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
11593         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
11594         type.
11595         (inf_ptrace_target::attach): Update.
11596         (inf_ptrace_target::files_info): Update.
11597         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
11598         type.
11599         (go32_nat_target::pid_to_str): Change return type.
11600         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
11601         (gnu_nat_target::wait): Update.
11602         (gnu_nat_target::wait): Update.
11603         (gnu_nat_target::resume): Update.
11604         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
11605         (fbsd_nat_target::wait): Update.
11606         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
11607         type.
11608         (darwin_nat_target::attach): Update.
11609         * corelow.c (class core_target) <pid_to_str>: Change return type.
11610         (core_target::pid_to_str): Change return type.
11611         * target.c (normal_pid_to_str): Change return type.
11612         (default_pid_to_str): Likewise.
11613         (target_pid_to_str): Change return type.
11614         (target_translate_tls_address): Update.
11615         (target_announce_detach): Update.
11616         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
11617         return type.
11618         (bsd_uthread_target::pid_to_str): Change return type.
11619         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
11620         type.
11621         (bsd_kvm_target::pid_to_str): Change return type.
11622         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
11623         return type.
11624         (aix_thread_target::pid_to_str): Change return type.
11625         * target.h (struct target_ops) <pid_to_str>: Change return type.
11626         (target_pid_to_str, normal_pid_to_str): Likewise.
11627         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
11628         type.
11629         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
11630         type.
11631         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
11632         return type.
11633         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
11634         type.
11635         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
11636         type.
11637         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
11638         return type.
11639
11640 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
11641
11642         * NEWS: Mention that the new default MI version is 3.  Mention
11643         changes to the output of commands and events that deal with
11644         multi-location breakpoints.
11645         * breakpoint.c: Include "mi/mi-out.h".
11646         (print_one_breakpoint): Change output syntax if using MI version
11647         >= 3.
11648         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
11649         New.
11650         (mi_multi_location_breakpoint_output_fixed): New.
11651         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
11652         (mi_cmd_fix_multi_location_breakpoint_output): New.
11653         (mi_multi_location_breakpoint_output_fixed): New.
11654         * mi/mi-cmds.c (mi_cmds): Register command
11655         -fix-multi-location-breakpoint-output.
11656         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
11657         interpreter "mi".
11658
11659 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
11660
11661         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
11662         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
11663         instantiate mi_ui_out based on interpreter name.
11664         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
11665         * mi/mi-main.c (mi_load_progress): Likewise.
11666
11667 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11668
11669         * NEWS: Combine separate "New targets" sections for 8.3.
11670
11671 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11672
11673         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
11674         (ppcfbsd_init_abi): Install gdbarch
11675         "fetch_tls_load_module_address" and "get_thread_local_address"
11676         methods.
11677
11678 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11679
11680         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
11681         (riscv_fbsd_init_abi): Install gdbarch
11682         "fetch_tls_load_module_address" and "get_thread_local_address"
11683         methods.
11684
11685 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11686
11687         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
11688         (i386fbsd_init_abi): Install gdbarch
11689         "fetch_tls_load_module_address" and "get_thread_local_address"
11690         methods.
11691
11692 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11693
11694         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
11695         (amd64fbsd_init_abi): Install gdbarch
11696         "fetch_tls_load_module_address" and "get_thread_local_address"
11697         methods.
11698
11699 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11700
11701         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
11702         (struct fbsd_pspace_data): New type.
11703         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
11704         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
11705         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
11706         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
11707         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
11708
11709 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11710
11711         * gdbtypes.c (lookup_struct_elt): New function.
11712         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
11713         * gdbtypes.h (struct struct_elt): New type.
11714         (lookup_struct_elt): New prototype.
11715
11716 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11717
11718         * gdbtypes.c (lookup_struct_elt_type): Update comment and
11719         remove disabled code block.
11720
11721 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11722
11723         * gdbarch.sh (get_thread_local_address): New method.
11724         * gdbarch.h, gdbarch.c: Regenerate.
11725         * target.c (target_translate_tls_address): Use
11726         gdbarch_get_thread_local_address if present instead of
11727         target::get_thread_local_address.
11728
11729 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11730
11731         * target.h (target::get_thread_local_address): Update comment.
11732
11733 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11734
11735         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
11736         objfile->separate_debug_objfile_backlink if not NULL.
11737
11738 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11739
11740         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
11741         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
11742         (amd64bsd_store_inferior_registers): Likewise.
11743         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
11744         Enable segment base registers.
11745         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
11746         PT_GETFSBASE and PT_GETGSBASE.
11747         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
11748         PT_SETGSBASE.
11749         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
11750         segment base registers.
11751         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
11752
11753 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11754
11755         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
11756         Update calls to i386_target_description to add 'segments'
11757         parameter.
11758         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
11759         add segment base registers.
11760         * arch/i386.c (i386_create_target_description): Add 'segments'
11761         parameter to enable segment base registers.
11762         * arch/i386.h (i386_create_target_description): Likewise.
11763         * features/i386/32bit-segments.xml: New file.
11764         * features/i386/32bit-segments.c: Generate.
11765         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
11766         call to i386_target_description to add 'segments' parameter.
11767         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
11768         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
11769         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
11770         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
11771         if feature is present.
11772         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
11773         Add 'segments' parameter to call to i386_target_description.
11774         (i386_target_description): Add 'segments' parameter to enable
11775         segment base registers.
11776         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
11777         to call to i386_target_description.
11778         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
11779         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
11780         Define I386_NUM_REGS.
11781         (i386_target_description): Add 'segments' parameter to enable
11782         segment base registers.
11783
11784 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
11785
11786         PR/24325
11787         * source-cache.c: #undef open and close, to avoid unresolved
11788         externals during linking.
11789
11790 2019-03-12  Tom Tromey  <tromey@adacore.com>
11791
11792         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
11793         const.  Add initializers.
11794         (_initialize_remote): Don't initialize ptid globals.
11795
11796 2019-03-12  Pedro Alves  <palves@redhat.com>
11797
11798         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
11799
11800 2019-03-12  Pedro Alves  <palves@redhat.com>
11801
11802         * cp-name-parser.y (main): Remove unused 'len' variable.
11803
11804 2019-03-12  Tom Tromey  <tromey@adacore.com>
11805
11806         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
11807         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
11808
11809 2019-03-12  Tom Tromey  <tromey@adacore.com>
11810
11811         * linux-nat.c (iterate_over_lwps): Update.
11812         (stop_callback): Remove parameter.
11813         (stop_wait_callback, detach_callback, resume_set_callback)
11814         (select_singlestep_lwp_callback, set_ignore_sigint)
11815         (status_callback, resumed_callback, resume_clear_callback)
11816         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
11817         data parameter.
11818         (linux_nat_target::detach, linux_nat_target::resume)
11819         (linux_stop_and_wait_all_lwps, select_event_lwp)
11820         (linux_nat_filter_event, linux_nat_wait_1)
11821         (linux_nat_target::kill, linux_nat_target::stop)
11822         (linux_nat_target::stop): Update.
11823         (linux_nat_resume_callback): Change type.
11824         (resume_stopped_resumed_lwps, count_events_callback)
11825         (select_event_lwp_callback): Likewise.
11826         (linux_stop_lwp, linux_nat_stop_lwp): Update.
11827         * arm-linux-nat.c (struct update_registers_data): Remove.
11828         (update_registers_callback): Change type.
11829         (arm_linux_insert_hw_breakpoint1): Update.
11830         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
11831         parameter.
11832         (x86_linux_dr_set_addr): Update.
11833         (x86_linux_dr_set_control): Update.
11834         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
11835         (iterate_over_lwps): Use gdb::function_view.
11836         * nat/aarch64-linux-hw-point.c (struct
11837         aarch64_dr_update_callback_param): Remove.
11838         (debug_reg_change_callback): Change type.
11839         (aarch64_notify_debug_reg_change): Update.
11840         * s390-linux-nat.c (s390_refresh_per_info): Update.
11841
11842 2019-03-11  Tom Tromey  <tromey@adacore.com>
11843
11844         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
11845         redundant assignment to "this_cu".
11846
11847 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11848
11849         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
11850
11851 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11852
11853         * gdbtypes.c (rank_one_type_parm_set): New function extracted
11854         from...
11855         (rank_one_type): ... this.
11856
11857 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11858
11859         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
11860         from...
11861         (rank_one_type): ... this.
11862
11863 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11864
11865         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
11866         from...
11867         (rank_one_type): ... this.
11868
11869 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11870
11871         * gdbtypes.c (rank_one_type_parm_float): New function extracted
11872         from...
11873         (rank_one_type): ... this.
11874
11875 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11876
11877         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
11878         from...
11879         (rank_one_type): ... this.
11880
11881 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11882
11883         * gdbtypes.c (rank_one_type_parm_range): New function extracted
11884         from...
11885         (rank_one_type): ... this.
11886
11887 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11888
11889         * gdbtypes.c (rank_one_type_parm_char): New function extracted
11890         from...
11891         (rank_one_type): ... this.
11892
11893 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11894
11895         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
11896         from...
11897         (rank_one_type): ... this.
11898
11899 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11900
11901         * gdbtypes.c (rank_one_type_parm_int): New function extracted
11902         from...
11903         (rank_one_type): ... this.
11904
11905 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11906
11907         * gdbtypes.c (rank_one_type_parm_func): New function extracted
11908         from...
11909         (rank_one_type): ... this.
11910
11911 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11912
11913         * gdbtypes.c (rank_one_type_parm_array): New function extracted
11914         from...
11915         (rank_one_type): ... this.
11916
11917 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11918
11919         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
11920         from...
11921         (rank_one_type): ... this.
11922
11923 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11924
11925         * inferior.c (initialize_inferiors): Ensure 'help set/show print
11926         inferior-events' shows the example events.
11927
11928 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
11929
11930         Support styling on native MS-Windows console
11931
11932         PR/24315
11933         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
11934         on MS-Windows if $TERM is not defined.
11935
11936         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
11937
11938         * posix-hdep.c (gdb_console_fputs):
11939         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
11940         functions.
11941         * ui-file.h (gdb_console_fputs): Add prototype.
11942
11943         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
11944         back to fputs only if the former returns zero.
11945
11946 2019-03-07  Tom Tromey  <tom@tromey.com>
11947
11948         * symmisc.c (print_symbol_bcache_statistics): Update.
11949         (print_objfile_statistics): Update.
11950         * symfile.c (allocate_symtab): Update.
11951         * stabsread.c: Don't include bcache.h.
11952         * psymtab.h (struct psymbol_bcache): Don't declare.
11953         (class psymtab_storage) <psymbol_cache>: Now a bcache.
11954         (psymbol_bcache_init, psymbol_bcache_free)
11955         (psymbol_bcache_get_bcache): Don't declare.
11956         * psymtab.c (struct psymbol_bcache): Remove.
11957         (psymtab_storage::psymtab_storage): Update.
11958         (psymtab_storage::~psymtab_storage): Update.
11959         (psymbol_bcache_init, psymbol_bcache_free)
11960         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
11961         (add_psymbol_to_bcache): Update.
11962         (allocate_psymtab): Update.
11963         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
11964         macro_cache>: No longer pointers.
11965         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
11966         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
11967         * macrotab.c (macro_bcache): Update.
11968         * macroexp.c: Don't include bcache.h.
11969         * gdbtypes.c (check_types_worklist): Update.
11970         (types_deeply_equal): Remove TRY/CATCH.  Update.
11971         * elfread.c (elf_symtab_read): Update.
11972         * dwarf2read.c: Don't include bcache.h.
11973         * buildsym.c (buildsym_compunit::get_macro_table): Update.
11974         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
11975         (print_bcache_statistics, bcache_memory_used): Don't declare.
11976         (struct bcache): Move from bcache.c.  Add constructor, destructor,
11977         methods.  Rename all data members.
11978         * bcache.c (struct bcache): Move to bcache.h.
11979         (bcache::expand_hash_table): Rename from expand_hash_table.
11980         (bcache): Remove.
11981         (bcache::insert): Rename from bcache_full.
11982         (bcache::compare): Rename from bcache_compare.
11983         (bcache_xmalloc): Remove.
11984         (bcache::~bcache): Rename from bcache_xfree.
11985         (bcache::print_statistics): Rename from print_bcache_statistics.
11986         (bcache::memory_used): Rename from bcache_memory_used.
11987
11988 2019-03-07  Pedro Alves  <palves@redhat.com>
11989
11990         * infrun.c (normal_stop): Also check for
11991         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
11992
11993 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
11994
11995         * f-lang.c (value_from_host_double): Moved to...
11996         * value.c (value_from_host_double): ...here.
11997         * value.h (value_from_host_double): Declare.
11998         * guile/scm-math.c (vlscm_convert_typed_number): Use
11999         value_from_host_double.
12000         (vlscm_convert_number): Likewise.
12001         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
12002         * python/py-value.c (convert_value_from_python): Likewise.
12003
12004 2019-03-06  Tom Tromey  <tom@tromey.com>
12005
12006         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
12007
12008 2019-03-06  Tom Tromey  <tom@tromey.com>
12009
12010         * utils.h (free_current_contents): Don't declare.
12011         * utils.c (free_current_contents): Remove.
12012
12013 2019-03-06  Tom Tromey  <tom@tromey.com>
12014
12015         * top.c (quit_force): Update.
12016         * main.c (captured_command_loop): Update.
12017         * common/new-op.c (operator new): Update.
12018         * common/common-exceptions.c (struct catcher)
12019         <save_cleanup_chain>: Remove member.
12020         (exceptions_state_mc_init): Update.
12021         (exception_try_scope_entry): Return nullptr.
12022         (exception_try_scope_exit, exception_rethrow)
12023         (throw_exception_sjlj, throw_exception_cxx): Update.
12024         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
12025         (all_cleanups, do_cleanups, discard_cleanups)
12026         (discard_final_cleanups, save_cleanups, save_final_cleanups)
12027         (restore_cleanups, restore_final_cleanups): Don't declare.
12028         (do_final_cleanups): Remove parameter.
12029         * common/cleanups.c (cleanup_chain, make_cleanup)
12030         (make_cleanup_dtor, all_cleanups, do_cleanups)
12031         (discard_my_cleanups, discard_cleanups)
12032         (discard_final_cleanups, save_my_cleanups, save_cleanups)
12033         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
12034         (null_cleanup): Remove.
12035         (do_final_cleanups): Remove parameter.
12036
12037 2019-03-06  Tom Tromey  <tom@tromey.com>
12038
12039         * remote.c (remote_target::remote_parse_stop_reply): Use
12040         unique_xmalloc_ptr.
12041
12042 2019-03-06  Tom Tromey  <tom@tromey.com>
12043
12044         * stabsread.c (struct stabs_field_info): Rename from field_info.
12045         <list, fnlist>: Add initializers.
12046         <obstack>: New member.
12047         (read_member_functions, read_struct_fields, read_baseclasses):
12048         Allocate on obstack.  Don't use cleanups.
12049         (read_one_struct_field, read_member_functions, read_struct_fields)
12050         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
12051         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
12052         (read_struct_type): Update.
12053
12054 2019-03-06  Tom Tromey  <tom@tromey.com>
12055
12056         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
12057         * common/filestuff.h (make_cleanup_close): Don't declare.
12058         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
12059         Remove.
12060
12061 2019-03-06  Tom Tromey  <tom@tromey.com>
12062
12063         * solib-aix.c: Use make_scope_exit.
12064
12065 2019-03-06  Tom Tromey  <tom@tromey.com>
12066
12067         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
12068         Use make_scope_exit.
12069
12070 2019-03-06  Tom Tromey  <tom@tromey.com>
12071
12072         * solib-svr4.c (disable_probes_interface): Remove parameter.
12073         (svr4_handle_solib_event): Use make_scope_exit.
12074
12075 2019-03-06  Tom Tromey  <tom@tromey.com>
12076
12077         * remote.c (struct stop_reply_deleter): Remove.
12078         (stop_reply_up): Update.
12079         (struct stop_reply): Derive from notif_event.  Don't typedef.
12080         <regcache>: Now a std::vector.
12081         (stop_reply_xfree): Remove.
12082         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
12083         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
12084         (remote_target::discard_pending_stop_replies): Use delete.
12085         (remote_target::remote_parse_stop_reply): Update.
12086         (remote_target::process_stop_reply): Update.
12087         * remote-notif.h (struct notif_event): Add virtual destructor.
12088         Remove "dtr" member.
12089         (struct notif_client) <alloc_event>: Return a unique_ptr.
12090         (notif_event_xfree): Don't declare.
12091         (notif_event_up): New typedef.
12092         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
12093         (notif_event_xfree, do_notif_event_xfree): Remove.
12094         (remote_notif_state_xfree): Update.
12095
12096 2019-03-06  Tom Tromey  <tom@tromey.com>
12097
12098         * infrun.c (displaced_step_clear_cleanup): Now a
12099         forward_scope_exit type.
12100         (displaced_step_prepare_throw): Update.
12101         (displaced_step_fixup): Update.
12102
12103 2019-03-06  Tom Tromey  <tom@tromey.com>
12104
12105         * inferior.h (class inferior): Update comment.
12106         * gdbthread.h (class thread_info): Update comment.
12107
12108 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
12109             Tom Tromey  <tom@tromey.com>
12110
12111         * stabsread.h (struct stab_section_list): Remove.
12112         (coffstab_build_psymtabs): Update.
12113         * dbxread.c (symbuf_sections): Now a std::vector.
12114         (sect_idx): New global.
12115         (fill_symbuf): Update.
12116         (coffstab_build_psymtabs): Change type of stabsects parameter.
12117         Update.
12118         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
12119         std::vector.
12120         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
12121         (coff_locate_sections): Update.
12122         (coff_symfile_read): Remove cleanups.  Update.
12123         (init_stringtab): Add storage parameter.
12124         (free_stringtab, free_stringtab_cleanup): Remove.
12125         (init_lineno): Add storage parameter.
12126         (free_linetab, free_linetab_cleanup): Remove.
12127
12128 2019-03-06  Pedro Alves  <palves@redhat.com>
12129
12130         * linux-fork.c (fork_info::clobber_regs): Delete.
12131         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
12132         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
12133         comment.  Adjust.
12134         (scoped_switch_fork_info::scoped_switch_fork_info)
12135         (checkpoint_command, linux_fork_context): Adjust
12136         fork_save_infrun_state calls.
12137
12138 2019-03-06  Pedro Alves  <palves@redhat.com>
12139
12140         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
12141         (inf_has_multiple_threads): Return 'bool' and rewrite using
12142         inferior_info::threads().
12143
12144 2019-03-06  Pedro Alves  <palves@redhat.com>
12145
12146         * linux-fork.c: Include <list>.
12147         (fork_list): Now a std::list instance.
12148         (fork_info): Add ctor, dtor, and in-class initialize all fields.
12149         (forks_exist_p, find_last_fork): Adjust.
12150         (new_fork): Delete.
12151         (one_fork_p): New.
12152         (add_fork): Adjust.
12153         (free_fork): Delete, folded into fork_info::~fork_info().
12154         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
12155         Adjust.
12156         (init_fork_list): Delete.
12157         (linux_fork_killall, linux_fork_mourn_inferior)
12158         (linux_fork_detach, info_checkpoints_command): Adjust.
12159         (_initialize_linux_fork): No longer call init_fork_list.
12160
12161 2019-03-06  Pedro Alves  <palves@redhat.com>
12162
12163         * linux-fork.c (new_fork): New, split out of ...
12164         (add_fork): ... this.  Return void.  Move "first fork" special
12165         case from here, to ...
12166         (checkpoint_command): ... here.
12167         * linux-linux.h (add_fork): Return void.
12168
12169 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
12170
12171         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
12172
12173 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
12174             Chris January  <chris.january@arm.com>
12175             David Lecomber  <david.lecomber@arm.com>
12176
12177         * f-exp.y: New token, UNOP_INTRINSIC.
12178         (exp): New pattern using UNOP_INTRINSIC token.
12179         (f77_keywords): Add 'abs' keyword.
12180         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
12181         (value_from_host_double): New function.
12182         (evaluate_subexp_f): Support UNOP_ABS.
12183
12184 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
12185
12186         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
12187         types.
12188
12189 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
12190
12191         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
12192         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
12193         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
12194
12195 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
12196
12197         * f-exp.y (convert_to_kind_type): Handle more type kinds.
12198
12199 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
12200             Chris January  <chris.january@arm.com>
12201
12202         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
12203         * f-exp.y: Define 'KIND' token.
12204         (exp): New pattern for KIND expressions.
12205         (ptype): Handle types with a kind extension.
12206         (direct_abs_decl): Extend to spot kind extensions.
12207         (f77_keywords): Add 'kind' to the list.
12208         (push_kind_type): New function.
12209         (convert_to_kind_type): New function.
12210         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
12211         * parse.c (operator_length_standard): Likewise.
12212         * parser-defs.h (enum type_pieces): Add tp_kind.
12213         * std-operator.def: Add UNOP_KIND.
12214
12215 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
12216
12217         * f-exp.y (f_parse): Set yydebug.
12218
12219 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
12220
12221         * f-lang.c (evaluate_subexp_f): New function.
12222         (exp_descriptor_f): New global.
12223         (f_language_defn): Use exp_descriptor_f instead of
12224         exp_descriptor_standard.
12225
12226 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
12227
12228         * f-exp.y (struct token): Add comments.
12229         (dot_ops): Remove uppercase versions and the end marker.
12230         (f77_keywords): Likewise.
12231         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
12232         entries in the dot_ops array are case insensitive, and use
12233         strncasecmp to compare strings.  Also some whitespace cleanup in
12234         this area.  Similar for the f77_keywords array, except entries in
12235         this list might be case sensitive.
12236
12237 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
12238
12239         * f-exp.y (struct f77_boolean_val): Add comments.
12240         (boolean_values): Remove uppercase versions, and end marker.
12241         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
12242         and use strncasecmp to achieve case insensitivity.  Additionally,
12243         perform whitespace cleanup around this code.
12244
12245 2019-03-06  Tom Tromey  <tromey@adacore.com>
12246
12247         * remote-sim.c (gdbsim_target_open): Use result of
12248         gdb_argv::release.
12249
12250 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
12251         Dirk Schubert  <dirk.schubert@arm.com>
12252         Chris January  <chris.january@arm.com>
12253
12254         * eval.c (evaluate_subexp_standard): Call Fortran argument
12255         wrapping logic.
12256         * f-lang.c (struct value): A value which can be passed into a
12257         Fortran function call.
12258         (fortran_argument_convert): Wrap Fortran arguments in a pointer
12259         where appropriate.
12260         (struct type): Value ready for a Fortran function call.
12261         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
12262         is needed.
12263         * f-lang.h (fortran_argument_convert): Declaration.
12264         (fortran_preserve_arg_pointer): Declaration.
12265         * infcall.c (value_arg_coerce): Call Fortran argument logic.
12266
12267 2019-03-05  Tom Tromey  <tromey@adacore.com>
12268
12269         * python/py-prettyprint.c (print_string_repr): Remove #if.
12270         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
12271
12272 2019-03-05  Tom Tromey  <tromey@adacore.com>
12273
12274         * target.c (the_dummy_target): Move later.  Change type to
12275         "dummy_target".
12276         (initialize_targets): Don't initialize the_dummy_target.
12277
12278 2019-03-05  Tom Tromey  <tromey@adacore.com>
12279
12280         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
12281         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
12282
12283 2019-03-05  Tom Tromey  <tromey@adacore.com>
12284
12285         * windows-nat.c (windows_nat_target::attach)
12286         (windows_nat_target::detach): Don't call gdb_flush.
12287         * valprint.c (generic_val_print, val_print, val_print_string):
12288         Don't call gdb_flush.
12289         * utils.c (defaulted_query): Don't call gdb_flush.
12290         * typeprint.c (print_type_scalar): Don't call gdb_flush.
12291         * target.c (target_announce_detach): Don't call gdb_flush.
12292         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
12293         * remote.c (extended_remote_target::attach): Don't call
12294         gdb_flush.
12295         * procfs.c (procfs_target::detach): Don't call gdb_flush.
12296         * printcmd.c (do_examine): Don't call gdb_flush.
12297         (info_display_command): Don't call gdb_flush.
12298         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
12299         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
12300         * memattr.c (info_mem_command): Don't call gdb_flush.
12301         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
12302         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
12303         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
12304         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
12305         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
12306         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
12307         (gnu_nat_target::detach): Don't call gdb_flush.
12308         * f-valprint.c (f_val_print): Don't call gdb_flush.
12309         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
12310         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
12311         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
12312         gdb_flush.
12313         * c-valprint.c (c_val_print): Don't call gdb_flush.
12314         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
12315
12316 2019-03-05  Tom Tromey  <tromey@adacore.com>
12317
12318         * varobj.c (update_dynamic_varobj_children): Update.
12319         (install_default_visualizer): Use reset, not release.
12320         * value.c (set_internalvar): Update.
12321         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
12322         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
12323         ATTRIBUTE_UNUSED_RESULT.
12324
12325 2019-03-05  Tom Tromey  <tromey@adacore.com>
12326
12327         * remote.c (class scoped_remote_fd) <release>: Add
12328         ATTRIBUTE_UNUSED_RESULT.
12329
12330 2019-03-05  Tom Tromey  <tromey@adacore.com>
12331
12332         * macroexp.c (struct macro_buffer) <release>: Add
12333         ATTRIBUTE_UNUSED_RESULT.
12334
12335 2019-03-05  Tom Tromey  <tromey@adacore.com>
12336
12337         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
12338         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
12339         ATTRIBUTE_UNUSED_RESULT.
12340
12341 2019-03-05  Tom Tromey  <tromey@adacore.com>
12342
12343         * common/scoped_fd.h (class scoped_fd) <release>: Add
12344         ATTRIBUTE_UNUSED_RESULT.
12345
12346 2019-03-05  Tom Tromey  <tromey@adacore.com>
12347
12348         * parser-defs.h (struct parser_state) <release>: Add
12349         ATTRIBUTE_UNUSED_RESULT.
12350
12351 2019-03-05  Tom Tromey  <tromey@adacore.com>
12352
12353         * utils.h (class gdb_argv) <release>: Add
12354         ATTRIBUTE_UNUSED_RESULT.
12355         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
12356
12357 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
12358
12359         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
12360         for-loop range, to avoid compiler warnings.
12361
12362         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
12363         avoid compiler warnings about unused variables.
12364
12365         * NEWS: Mention end of support for native debugging on MS-Windows
12366         before XP.
12367
12368         PR gdb/24292
12369         * common/netstuff.c:
12370         * gdbserver/gdbreplay.c
12371         * gdbserver/remote-utils.c:
12372         * ser-tcp.c:
12373         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
12374         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
12375         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
12376         'getaddrinfo' and 'freeaddrinfo' were not available before
12377         Windows XP, and mingw.org's MinGW headers by default define
12378         _WIN32_WINNT to 0x500.
12379
12380 2019-03-01  Gary Benson <gbenson@redhat.com>
12381
12382         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
12383
12384 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
12385             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
12386
12387         PR gdb/8527
12388         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
12389         set_sigint_trap, clear_sigint_trap.
12390
12391 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12392
12393         * target.c (target_detach): Clear the regcache and the
12394         frame cache.
12395
12396 2019-02-27  Pedro Alves  <palves@redhat.com>
12397
12398         * utils.c (set_screen_size): When we cap the height/width sizes,
12399         tweak the corresponding command variable to show "unlimited":
12400
12401 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
12402             Pedro Alves  <palves@redhat.com>
12403
12404         * utils.c (set_screen_size): Reduce "infinite" rows and columns
12405         before calling rl_set_screen_size.
12406
12407 2019-02-27  Tom Tromey  <tromey@adacore.com>
12408
12409         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
12410         define.
12411         * python/py-value.c: Remove Python 2.4 workaround.
12412         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
12413         workaround.
12414         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
12415         Python 2.4 workaround.
12416         * python/python-internal.h: Remove Python 2.4 comment.
12417         (Py_ssize_t): Don't define.
12418         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
12419         (gdb_Py_DECREF): Remove Python 2.4 workaround.
12420         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
12421         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
12422         * python/python.c (do_start_initialization): Remove Python 2.4
12423         workaround.
12424         * python/py-prettyprint.c (class dummy_python_frame): Remove.
12425         (print_children): Remove Python 2.4 workaround.
12426         * python/py-inferior.c (buffer_procs): Remove Python 2.4
12427         workaround.
12428         (CHARBUFFERPROC_NAME): Remove.
12429         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
12430         Python 2.4 workaround.
12431
12432 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
12433
12434         * NEWS: Note minimum Python version.
12435
12436 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
12437
12438         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
12439         code from these functions.  Remove corresponding ifdefs.  Use
12440         Py_buffer_up instead of explicit calls to PyBuffer_Release.
12441         Remove gotos and target of gotos.
12442         (infpy_search_memory): Likewise.
12443
12444 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12445
12446         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
12447         (hppa_gdbarch_init): Don't register deleted functions with
12448         gdbarch.
12449
12450 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12451
12452         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
12453         (h8300_unwind_sp): Delete.
12454         (h8300_dummy_id): Delete.
12455         (h8300_gdbarch_init): Don't register deleted functions with
12456         gdbarch.
12457
12458 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12459
12460         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
12461         (ft32_unwind_pc): Delete.
12462         (ft32_unwind_sp): Delete.
12463         (ft32_gdbarch_init): Don't register deleted functions with
12464         gdbarch.
12465
12466 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12467
12468         * gdb/frv-tdep.c (frv_dummy_id): Delete.
12469         (frv_unwind_pc): Delete.
12470         (frv_unwind_sp): Delete.
12471         (frv_gdbarch_init): Don't register deleted functions with
12472         gdbarch.
12473
12474 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12475
12476         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
12477         (riscv_unwind_pc): Delete.
12478         (riscv_unwind_sp): Delete.
12479         (riscv_gdbarch_init): Don't register deleted functions with
12480         gdbarch.
12481
12482 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12483
12484         * gdb/csky-tdep.c (csky_dummy_id): Delete.
12485         (csky_unwind_pc): Delete.
12486         (csky_unwind_sp): Delete.
12487         (csky_gdbarch_init): Don't register deleted functions with
12488         gdbarch.
12489
12490 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12491
12492         * gdb/cris-tdep.c (cris_dummy_id): Delete.
12493         (cris_unwind_pc): Delete.
12494         (cris_unwind_sp): Delete.
12495         (cris_gdbarch_init): Don't register deleted functions with
12496         gdbarch.
12497
12498 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12499
12500         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
12501         (bfin_unwind_pc): Delete.
12502         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
12503
12504 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12505
12506         * gdb/arm-tdep.c (arm_dummy_id): Delete.
12507         (arm_unwind_pc): Delete.
12508         (arm_unwind_sp): Delete.
12509         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
12510
12511 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12512
12513         * gdb/arc-tdep.c (arc_dummy_id): Delete.
12514         (arc_unwind_pc): Delete.
12515         (arc_unwind_sp): Delete.
12516         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
12517
12518 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12519
12520         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
12521         (alpha_unwind_pc): Delete.
12522         (alpha_gdbarch_init): Don't register deleted functions with
12523         gdbarch.
12524
12525 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12526
12527         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
12528         (aarch64_unwind_pc): Delete.
12529         (aarch64_unwind_sp): Delete.
12530         (aarch64_gdbarch_init): Don't register deleted functions with
12531         gdbarch.
12532
12533 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12534
12535         * gdbtypes.c (type_align): Don't consider static members when
12536         computing structure alignment.
12537
12538 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12539
12540         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
12541         return 0 for other types.
12542         * arch-utils.c (default_type_align): Always return 0.
12543         * gdbarch.h: Regenerate.
12544         * gdbarch.sh (type_align): Extend comment.
12545         * gdbtypes.c (type_align): Add additional comments, always call
12546         gdbarch_type_align before applying the default rules.
12547         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
12548         generic code will then apply a suitable default.
12549         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
12550         types, return 0 for other types.
12551
12552 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
12553
12554         * NEWS: Create a new section for the next release branch.
12555         Rename the section of the current branch, now that it has
12556         been cut.
12557
12558 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
12559
12560         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
12561         * version.in: Bump version to 8.3.50.DATE-git.
12562
12563 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
12564
12565         * aix-thread.c (ptid_cmp): Remove unused variable.
12566         (get_signaled_thread): Likewise.
12567         (store_regs_user_thread): Likewise.
12568         (store_regs_kernel_thread): Likewise.
12569         (fetch_regs_kernel_thread): Remove shadowed variable.
12570
12571 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
12572
12573         * features/riscv/32bit-cpu.xml: Add register numbers.
12574         * features/riscv/32bit-fpu.c: Regenerate.
12575         * features/riscv/32bit-fpu.xml: Add register numbers.
12576         * features/riscv/64bit-cpu.xml: Add register numbers.
12577         * features/riscv/64bit-fpu.c: Regenerate.
12578         * features/riscv/64bit-fpu.xml: Add register numbers.
12579
12580 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
12581
12582         * NEWS: Mention two argument form of gdb.Value constructor.
12583         * python/py-value.c (convert_buffer_and_type_to_value): New
12584         function.
12585         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
12586         Add support for handling an optional second argument.  Call
12587         convert_buffer_and_type_to_value as appropriate.
12588         * python/python-internal.h (Py_buffer_deleter): New struct.
12589         (Py_buffer_up): New typedef.
12590
12591 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
12592
12593         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
12594         instead of releasing ownership.
12595
12596 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
12597
12598         * dwarf2read.c (open_and_init_dwp_file): Call
12599         elf_numsections instead of bfd_count_sections to initialize
12600         dwp_file->num_sections.
12601
12602 2019-02-25  Tom Tromey  <tromey@adacore.com>
12603
12604         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
12605
12606 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
12607
12608         * gcore.in: Add '--readnever' option when invoking GDB.
12609
12610 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
12611
12612         * MAINTAINERS: Update my email address.
12613
12614 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
12615
12616         * build-id.c (build_id_to_debug_bfd_1): New function.
12617         (build_id_to_debug_bfd): Look for separate debug file in
12618         sysroot.
12619
12620 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
12621
12622         * gdbarch.sh: Update the copyright year range that is placed into
12623         generated files.
12624
12625 2019-02-22  Keith Seitz  <keiths@redhat.com>
12626
12627         PR symtab/23853
12628         * linespec.c (create_sals_line_offset): Search for the default
12629         symtab's filename instead of its fullname.
12630
12631 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
12632
12633         * NEWS: Update style defaults.
12634
12635 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
12636
12637         * main.c (captured_main_1): Disable styling in batch mode.
12638
12639 2019-02-20  Tom Tromey  <tom@tromey.com>
12640
12641         * symtab.c (symtab_symbol_info): Fix typos.
12642
12643 2019-02-20  Tom Tromey  <tromey@adacore.com>
12644
12645         * findcmd.c (_initialize_mem_search): Use upper case for
12646         metasyntactic variables.
12647
12648 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
12649
12650         * aarch64-tdep.c (aarch64_add_reggroups): New function.
12651         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
12652
12653 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
12654
12655         * top.h (source_file_name): Change to std::string.
12656         * top.c (source_file_name): Likewise.
12657         (command_line_input): Adjust.
12658         * cli/cli-script.c (script_from_file): Adjust.
12659
12660 2019-02-19  Tom Tromey  <tromey@adacore.com>
12661
12662         * ravenscar-thread.c
12663         (ravenscar_thread_target::update_thread_list): Don't call
12664         ada_build_task_list.
12665         * ada-lang.h (ada_build_task_list): Don't declare.
12666         * ada-tasks.c (struct ada_tasks_inferior_data)
12667         <task_list_valid_p>: Now bool.
12668         (read_known_tasks, ada_task_list_changed)
12669         (ada_tasks_invalidate_inferior_data): Update.
12670         (read_known_tasks_array): Return bool.
12671         (read_known_tasks_list): Likewise.
12672         (read_known_tasks): Return void.
12673         (ada_build_task_list): Now static.
12674
12675 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
12676
12677         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
12678         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
12679
12680 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12681
12682         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
12683         variant for ada_tasks_pspace_data_handle and
12684         ada_tasks_inferior_data_handle.
12685         (ada_tasks_pspace_data_cleanup): New function.
12686         (ada_tasks_inferior_data_cleanup): New function.
12687
12688 2019-02-17  Tom Tromey  <tom@tromey.com>
12689
12690         * macrotab.h (macro_source_fullname): Return a std::string.
12691         * macrotab.c (macro_include, check_for_redefinition)
12692         (macro_undef, macro_lookup_definition, foreach_macro)
12693         (foreach_macro_in_scope): Update.
12694         (macro_source_fullname): Return a std::string.
12695         * macrocmd.c (show_pp_source_pos): Update.
12696
12697 2019-02-17  Tom Tromey  <tom@tromey.com>
12698
12699         * macrocmd.c (show_pp_source_pos): Style the file names.
12700
12701 2019-02-17  Tom Tromey  <tom@tromey.com>
12702
12703         PR tui/24197:
12704         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
12705
12706 2019-02-17  Tom Tromey  <tom@tromey.com>
12707
12708         * ada-lang.c (user_select_syms): Use filtered printing.
12709         * utils.c (wrap_style): New global.
12710         (desired_style): Remove.
12711         (emit_style_escape): Add stream parameter.
12712         (set_output_style, reset_terminal_style, prompt_for_continue):
12713         Update.
12714         (flush_wrap_buffer): Only flush gdb_stdout.
12715         (wrap_here): Set wrap_style.
12716         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
12717         treat escape sequences as a character.  Change when wrap buffer is
12718         flushed.
12719         (fputs_styled): Do not set the output style when the default is
12720         requested.
12721         * ui-style.h (struct ui_file_style) <is_default>: New method.
12722         * source.c (print_source_lines_base): Emit escape sequences in one
12723         piece.
12724
12725 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
12726
12727         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
12728         integers and enumeration types.
12729
12730 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
12731
12732         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
12733         instead of lookup_symbol_in_language
12734         (do_exact_match): New function.
12735         (ada_get_symbol_name_matcher): Return do_exact_match when
12736         doing a verbatim match.
12737
12738 2019-02-15  Tom Tromey  <tromey@adacore.com>
12739
12740         * ravenscar-thread.c (ravenscar_thread_target::resume)
12741         (ravenscar_thread_target::wait): Special case wildcard requests.
12742
12743 2019-02-15  Tom Tromey  <tromey@adacore.com>
12744
12745         * ravenscar-thread.c (base_ptid): Remove.
12746         (struct ravenscar_thread_target) <close>: New method.
12747         <m_base_ptid>: New member.
12748         <update_inferior_ptid, active_task, task_is_currently_active,
12749         runtime_initialized>: Declare methods.
12750         <ravenscar_thread_target>: Add constructor.
12751         (ravenscar_thread_target::task_is_currently_active)
12752         (ravenscar_thread_target::update_inferior_ptid)
12753         (ravenscar_runtime_initialized): Rename.  Now methods.
12754         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
12755         (ravenscar_thread_target::update_thread_list): Update.
12756         (ravenscar_thread_target::active_task): Now method.
12757         (ravenscar_thread_target::store_registers)
12758         (ravenscar_thread_target::prepare_to_store)
12759         (ravenscar_thread_target::prepare_to_store)
12760         (ravenscar_thread_target::mourn_inferior): Update.
12761         (ravenscar_inferior_created): Use "new" to create target.
12762         (ravenscar_thread_target::get_ada_task_ptid): Update.
12763         (_initialize_ravenscar): Don't initialize base_ptid.
12764         (ravenscar_ops): Remove global.
12765
12766 2019-02-15  Tom Tromey  <tromey@adacore.com>
12767
12768         * target.h (push_target): Declare new overload.
12769         * target.c (push_target): New overload, taking an rvalue reference.
12770         * remote.c (remote_target::open_1): Use push_target overload.
12771         * corelow.c (core_target_open): Use push_target overload.
12772
12773 2019-02-15  Tom Tromey  <tromey@adacore.com>
12774
12775         * ravenscar-thread.c (is_ravenscar_task)
12776         (ravenscar_task_is_currently_active): Return bool.
12777         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
12778         (_initialize_ravenscar): Remove "(void)".
12779         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
12780         Return bool.
12781
12782 2019-02-15  Tom Tromey  <tromey@adacore.com>
12783
12784         * ravenscar-thread.c (ravenscar_runtime_initializer)
12785         (has_ravenscar_runtime, get_running_thread_id)
12786         (ravenscar_thread_target::resume): Fix indentation.
12787
12788 2019-02-15  Tom Tromey  <tromey@adacore.com>
12789
12790         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
12791         from ravenscar_arch_ops.
12792         (sparc_ravenscar_ops::fetch_registers)
12793         (sparc_ravenscar_ops::store_registers): Now methods.
12794         (sparc_ravenscar_prepare_to_store): Remove.
12795         (sparc_ravenscar_ops): Redefine.
12796         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
12797         methods and destructor.  Remove members.
12798         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
12799         (ravenscar_thread_target::store_registers)
12800         (ravenscar_thread_target::prepare_to_store): Update.
12801         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
12802         Remove.
12803         (struct ppc_ravenscar_powerpc_ops): Derive from
12804         ravenscar_arch_ops.
12805         (ppc_ravenscar_powerpc_ops::fetch_registers)
12806         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
12807         (ppc_ravenscar_powerpc_ops): Redefine.
12808         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
12809         (ppc_ravenscar_e500_ops::fetch_registers)
12810         (ppc_ravenscar_e500_ops::store_registers): Now methods.
12811         (ppc_ravenscar_e500_ops): Redefine.
12812         * aarch64-ravenscar-thread.c
12813         (aarch64_ravenscar_generic_prepare_to_store): Remove.
12814         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
12815         (aarch64_ravenscar_fetch_registers)
12816         (aarch64_ravenscar_store_registers): Now methods.
12817         (aarch64_ravenscar_ops): Redefine.
12818
12819 2019-02-15  Tom Tromey  <tromey@adacore.com>
12820
12821         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
12822         (ravenscar_thread_target::stopped_by_hw_breakpoint)
12823         (ravenscar_thread_target::stopped_by_watchpoint)
12824         (ravenscar_thread_target::stopped_data_address)
12825         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
12826
12827 2019-02-15  Tom Tromey  <tromey@adacore.com>
12828
12829         * ravenscar-thread.c: Fix some typos.
12830
12831 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12832             Tom Tromey  <tromey@adacore.com>
12833
12834         * ada-lang.c (ada_exception_sal): Change addr_string to a
12835         std::string.
12836         (create_ada_exception_catchpoint): Update.
12837
12838 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12839             Tom Tromey  <tromey@adacore.com>
12840
12841         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
12842         (bp_location_ops): Remove.
12843         (base_breakpoint_allocate_location): Update.
12844         (free_bp_location): Update.
12845         * ada-lang.c (class ada_catchpoint_location)
12846         <ada_catchpoint_location>: Remove ops parameter.
12847         (ada_catchpoint_location_dtor): Remove.
12848         (ada_catchpoint_location_ops): Remove.
12849         (allocate_location_exception): Update.
12850         * breakpoint.h (struct bp_location_ops): Remove.
12851         (class bp_location) <bp_location>: Remove bp_location_ops
12852         parameter.
12853         <~bp_location>: Add destructor.
12854         <ops>: Remove.
12855
12856 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
12857             Pedro Alves  <palves@redhat.com>
12858
12859         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
12860         'PATH_MAX'.
12861
12862 2019-02-14  David Michael  <fedora.dm0@gmail.com>
12863             Samuel Thibault  <samuel.thibault@gnu.org>
12864             Thomas Schwinge  <thomas@codesourcery.com>
12865
12866         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
12867         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
12868
12869 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
12870
12871         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
12872         (check_empty): Use "const char *".
12873
12874         * gnu-nat.c (gnu_nat_target::detach): Instead of
12875         'detach_inferior (pid)' call
12876         'detach_inferior (find_inferior_pid (pid))'.
12877
12878         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
12879         'nat/fork-inferior.o'.
12880         * gnu-nat.c: #include "nat/fork-inferior.h".
12881
12882         * gnu-nat.c (gnu_nat_target::detach): Instead of
12883         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
12884         * gnu-nat.h: #include "inf-child.h".
12885         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
12886         'i386_gnu_nat_target::fetch_registers'.
12887         (gnu_store_registers): Rename/move to
12888         'i386_gnu_nat_target::store_registers'.
12889
12890         * config/i386/nm-i386gnu.h: Don't "#include" any files.
12891         * gnu-nat.h (mach_thread_info): New function.
12892         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
12893
12894         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
12895
12896 2019-02-14  Frederic Konrad  <konrad@adacore.com>
12897
12898         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
12899
12900 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
12901
12902         * windows-nat.c (windows_add_thread): Add new parameter
12903         "main_thread_p" with default value set to false.  Update
12904         function documentation as well as all callers.
12905         (windows_delete_thread): Likewise.
12906         (fake_create_process): Update call to windows_add_thread.
12907         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
12908         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
12909         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
12910         call to windows_delete_thread.
12911
12912 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
12913
12914         * MAINTAINERS: Add Andrew Burgess as global maintainer.
12915
12916 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
12917
12918         * symfile.c (find_separate_debug_file): Use canonical path of
12919         sysroot with child_path instead of gdb_sysroot if it is valid.
12920
12921 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
12922
12923         * symfile.c (find_separate_debug_file): Use child_path to
12924         determine if an object file is under a sysroot.
12925
12926 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
12927
12928         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
12929         unittests/child-path-selftests.c.
12930         * common/pathstuff.c (child_path): New function.
12931         * common/pathstuff.h (child_path): New prototype.
12932         * unittests/child-path-selftests.c: New file.
12933
12934 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
12935
12936         * symfile.c (find_separate_debug_file): Look for separate debug
12937         files in debug directories under the sysroot.
12938
12939 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12940
12941         * symtab.h (struct minimal_symbol data_p): New const method.
12942         (struct minimal_symbol text_p): Likewise.
12943         * symtab.c (output_source_filename): Use file name style
12944         to print file name.
12945         (print_symbol_info): Likewise.
12946         (print_msymbol_info): Use address style to print addresses.
12947         Use function name style to print executable text symbols.
12948         (expand_symtab_containing_pc): Use data_p.
12949         (find_pc_sect_compunit_symtab): Likewise.
12950
12951 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12952
12953         * breakpoint.c (describe_other_breakpoints): Use address style
12954         to print addresses.
12955         (say_where): Likewise.
12956
12957 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12958
12959         * ada-typeprint.c (print_func_type): Print function name
12960         style to print function name.
12961         * c-typeprint.c (c_print_type_1): Likewise.
12962
12963 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
12964
12965         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
12966         for execve.
12967
12968 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12969
12970         * c-exp.y (direct_abs_decl): Use emplace_back to record the
12971         type_stack.
12972
12973 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
12974
12975         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
12976         TYPE_CODE_REF types.
12977
12978 2019-02-08  Jim Wilson  <jimw@sifive.com>
12979
12980         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
12981         (riscv_linux_fregset): New.
12982         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
12983
12984 2019-02-07  Tom Tromey  <tom@tromey.com>
12985
12986         * thread.c (thread_cancel_execution_command): Update.
12987         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
12988         methods.
12989         (struct thread_fsm_ops): Remove.
12990         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
12991         (thread_fsm_should_stop, thread_fsm_return_value)
12992         (thread_fsm_set_finished, thread_fsm_finished_p)
12993         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
12994         Don't declare.
12995         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
12996         * infrun.c (clear_proceed_status_thread)
12997         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
12998         (print_stop_event): Update.
12999         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
13000         Add constructor.
13001         (step_command_fsm_ops): Remove.
13002         (new_step_command_fsm): Remove.
13003         (step_1): Update.
13004         (step_command_fsm::should_stop): Rename from
13005         step_command_fsm_should_stop.
13006         (step_command_fsm::clean_up): Rename from
13007         step_command_fsm_clean_up.
13008         (step_command_fsm::do_async_reply_reason): Rename from
13009         step_command_fsm_async_reply_reason.
13010         (struct until_next_fsm): Inherit from thread_fsm.  Add
13011         constructor.
13012         (until_next_fsm_ops): Remove.
13013         (new_until_next_fsm): Remove.
13014         (until_next_fsm::should_stop): Rename from
13015         until_next_fsm_should_stop.
13016         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
13017         (until_next_fsm::do_async_reply_reason): Rename from
13018         until_next_fsm_async_reply_reason.
13019         (struct finish_command_fsm): Inherit from thread_fsm.  Add
13020         constructor.  Change type of breakpoint.
13021         (finish_command_fsm_ops): Remove.
13022         (new_finish_command_fsm): Remove.
13023         (finish_command_fsm::should_stop): Rename from
13024         finish_command_fsm_should_stop.
13025         (finish_command_fsm::clean_up): Rename from
13026         finish_command_fsm_clean_up.
13027         (finish_command_fsm::return_value): Rename from
13028         finish_command_fsm_return_value.
13029         (finish_command_fsm::do_async_reply_reason): Rename from
13030         finish_command_fsm_async_reply_reason.
13031         (finish_command): Update.
13032         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
13033         Add constructor.
13034         (call_thread_fsm_ops): Remove.
13035         (call_thread_fsm::call_thread_fsm): Rename from
13036         new_call_thread_fsm.
13037         (call_thread_fsm::should_stop): Rename from
13038         call_thread_fsm_should_stop.
13039         (call_thread_fsm::should_notify_stop): Rename from
13040         call_thread_fsm_should_notify_stop.
13041         (run_inferior_call, call_function_by_hand_dummy): Update.
13042         * cli/cli-interp.c (should_print_stop_to_console): Update.
13043         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
13044         Add constructor.  Change type of location_breakpoint,
13045         caller_breakpoint.
13046         (until_break_fsm_ops): Remove.
13047         (new_until_break_fsm): Remove.
13048         (until_break_fsm::should_stop): Rename from
13049         until_break_fsm_should_stop.
13050         (until_break_fsm::clean_up): Rename from
13051         until_break_fsm_clean_up.
13052         (until_break_fsm::do_async_reply_reason): Rename from
13053         until_break_fsm_async_reply_reason.
13054         (until_break_command): Update.
13055         * thread-fsm.c: Remove.
13056         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
13057
13058 2019-02-07  Tom Tromey  <tom@tromey.com>
13059
13060         * yy-remap.h: Add include guard.
13061         * xtensa-tdep.h: Add include guard.
13062         * xcoffread.h: Rename include guard.
13063         * varobj-iter.h: Add include guard.
13064         * tui/tui.h: Rename include guard.
13065         * tui/tui-winsource.h: Rename include guard.
13066         * tui/tui-wingeneral.h: Rename include guard.
13067         * tui/tui-windata.h: Rename include guard.
13068         * tui/tui-win.h: Rename include guard.
13069         * tui/tui-stack.h: Rename include guard.
13070         * tui/tui-source.h: Rename include guard.
13071         * tui/tui-regs.h: Rename include guard.
13072         * tui/tui-out.h: Rename include guard.
13073         * tui/tui-layout.h: Rename include guard.
13074         * tui/tui-io.h: Rename include guard.
13075         * tui/tui-hooks.h: Rename include guard.
13076         * tui/tui-file.h: Rename include guard.
13077         * tui/tui-disasm.h: Rename include guard.
13078         * tui/tui-data.h: Rename include guard.
13079         * tui/tui-command.h: Rename include guard.
13080         * tic6x-tdep.h: Add include guard.
13081         * target/waitstatus.h: Rename include guard.
13082         * target/wait.h: Rename include guard.
13083         * target/target.h: Rename include guard.
13084         * target/resume.h: Rename include guard.
13085         * target-float.h: Rename include guard.
13086         * stabsread.h: Add include guard.
13087         * rs6000-tdep.h: Add include guard.
13088         * riscv-fbsd-tdep.h: Add include guard.
13089         * regformats/regdef.h: Rename include guard.
13090         * record.h: Rename include guard.
13091         * python/python.h: Rename include guard.
13092         * python/python-internal.h: Rename include guard.
13093         * python/py-stopevent.h: Rename include guard.
13094         * python/py-ref.h: Rename include guard.
13095         * python/py-record.h: Rename include guard.
13096         * python/py-record-full.h: Rename include guard.
13097         * python/py-record-btrace.h: Rename include guard.
13098         * python/py-instruction.h: Rename include guard.
13099         * python/py-events.h: Rename include guard.
13100         * python/py-event.h: Rename include guard.
13101         * procfs.h: Add include guard.
13102         * proc-utils.h: Add include guard.
13103         * p-lang.h: Add include guard.
13104         * or1k-tdep.h: Rename include guard.
13105         * observable.h: Rename include guard.
13106         * nto-tdep.h: Rename include guard.
13107         * nat/x86-linux.h: Rename include guard.
13108         * nat/x86-linux-dregs.h: Rename include guard.
13109         * nat/x86-gcc-cpuid.h: Add include guard.
13110         * nat/x86-dregs.h: Rename include guard.
13111         * nat/x86-cpuid.h: Rename include guard.
13112         * nat/ppc-linux.h: Rename include guard.
13113         * nat/mips-linux-watch.h: Rename include guard.
13114         * nat/linux-waitpid.h: Rename include guard.
13115         * nat/linux-ptrace.h: Rename include guard.
13116         * nat/linux-procfs.h: Rename include guard.
13117         * nat/linux-osdata.h: Rename include guard.
13118         * nat/linux-nat.h: Rename include guard.
13119         * nat/linux-namespaces.h: Rename include guard.
13120         * nat/linux-btrace.h: Rename include guard.
13121         * nat/glibc_thread_db.h: Rename include guard.
13122         * nat/gdb_thread_db.h: Rename include guard.
13123         * nat/gdb_ptrace.h: Rename include guard.
13124         * nat/fork-inferior.h: Rename include guard.
13125         * nat/amd64-linux-siginfo.h: Rename include guard.
13126         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
13127         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
13128         * nat/aarch64-linux.h: Rename include guard.
13129         * nat/aarch64-linux-hw-point.h: Rename include guard.
13130         * mn10300-tdep.h: Add include guard.
13131         * mips-linux-tdep.h: Add include guard.
13132         * mi/mi-parse.h: Rename include guard.
13133         * mi/mi-out.h: Rename include guard.
13134         * mi/mi-main.h: Rename include guard.
13135         * mi/mi-interp.h: Rename include guard.
13136         * mi/mi-getopt.h: Rename include guard.
13137         * mi/mi-console.h: Rename include guard.
13138         * mi/mi-common.h: Rename include guard.
13139         * mi/mi-cmds.h: Rename include guard.
13140         * mi/mi-cmd-break.h: Rename include guard.
13141         * m2-lang.h: Add include guard.
13142         * location.h: Rename include guard.
13143         * linux-record.h: Rename include guard.
13144         * linux-nat.h: Add include guard.
13145         * linux-fork.h: Add include guard.
13146         * i386-darwin-tdep.h: Rename include guard.
13147         * hppa-linux-offsets.h: Add include guard.
13148         * guile/guile.h: Rename include guard.
13149         * guile/guile-internal.h: Rename include guard.
13150         * gnu-nat.h: Rename include guard.
13151         * gdb-stabs.h: Rename include guard.
13152         * frv-tdep.h: Add include guard.
13153         * f-lang.h: Add include guard.
13154         * event-loop.h: Add include guard.
13155         * darwin-nat.h: Rename include guard.
13156         * cp-abi.h: Rename include guard.
13157         * config/sparc/nm-sol2.h: Rename include guard.
13158         * config/nm-nto.h: Rename include guard.
13159         * config/nm-linux.h: Add include guard.
13160         * config/i386/nm-i386gnu.h: Rename include guard.
13161         * config/djgpp/nl_types.h: Rename include guard.
13162         * config/djgpp/langinfo.h: Rename include guard.
13163         * compile/gcc-cp-plugin.h: Add include guard.
13164         * compile/gcc-c-plugin.h: Add include guard.
13165         * compile/compile.h: Rename include guard.
13166         * compile/compile-object-run.h: Rename include guard.
13167         * compile/compile-object-load.h: Rename include guard.
13168         * compile/compile-internal.h: Rename include guard.
13169         * compile/compile-cplus.h: Rename include guard.
13170         * compile/compile-c.h: Rename include guard.
13171         * common/xml-utils.h: Rename include guard.
13172         * common/x86-xstate.h: Rename include guard.
13173         * common/version.h: Rename include guard.
13174         * common/vec.h: Rename include guard.
13175         * common/tdesc.h: Rename include guard.
13176         * common/selftest.h: Rename include guard.
13177         * common/scoped_restore.h: Rename include guard.
13178         * common/scoped_mmap.h: Rename include guard.
13179         * common/scoped_fd.h: Rename include guard.
13180         * common/safe-iterator.h: Rename include guard.
13181         * common/run-time-clock.h: Rename include guard.
13182         * common/refcounted-object.h: Rename include guard.
13183         * common/queue.h: Rename include guard.
13184         * common/ptid.h: Rename include guard.
13185         * common/print-utils.h: Rename include guard.
13186         * common/preprocessor.h: Rename include guard.
13187         * common/pathstuff.h: Rename include guard.
13188         * common/observable.h: Rename include guard.
13189         * common/netstuff.h: Rename include guard.
13190         * common/job-control.h: Rename include guard.
13191         * common/host-defs.h: Rename include guard.
13192         * common/gdb_wait.h: Rename include guard.
13193         * common/gdb_vecs.h: Rename include guard.
13194         * common/gdb_unlinker.h: Rename include guard.
13195         * common/gdb_unique_ptr.h: Rename include guard.
13196         * common/gdb_tilde_expand.h: Rename include guard.
13197         * common/gdb_sys_time.h: Rename include guard.
13198         * common/gdb_string_view.h: Rename include guard.
13199         * common/gdb_splay_tree.h: Rename include guard.
13200         * common/gdb_setjmp.h: Rename include guard.
13201         * common/gdb_ref_ptr.h: Rename include guard.
13202         * common/gdb_optional.h: Rename include guard.
13203         * common/gdb_locale.h: Rename include guard.
13204         * common/gdb_assert.h: Rename include guard.
13205         * common/filtered-iterator.h: Rename include guard.
13206         * common/filestuff.h: Rename include guard.
13207         * common/fileio.h: Rename include guard.
13208         * common/environ.h: Rename include guard.
13209         * common/common-utils.h: Rename include guard.
13210         * common/common-types.h: Rename include guard.
13211         * common/common-regcache.h: Rename include guard.
13212         * common/common-inferior.h: Rename include guard.
13213         * common/common-gdbthread.h: Rename include guard.
13214         * common/common-exceptions.h: Rename include guard.
13215         * common/common-defs.h: Rename include guard.
13216         * common/common-debug.h: Rename include guard.
13217         * common/cleanups.h: Rename include guard.
13218         * common/buffer.h: Rename include guard.
13219         * common/btrace-common.h: Rename include guard.
13220         * common/break-common.h: Rename include guard.
13221         * cli/cli-utils.h: Rename include guard.
13222         * cli/cli-style.h: Rename include guard.
13223         * cli/cli-setshow.h: Rename include guard.
13224         * cli/cli-script.h: Rename include guard.
13225         * cli/cli-interp.h: Rename include guard.
13226         * cli/cli-decode.h: Rename include guard.
13227         * cli/cli-cmds.h: Rename include guard.
13228         * charset-list.h: Add include guard.
13229         * buildsym-legacy.h: Rename include guard.
13230         * bfin-tdep.h: Add include guard.
13231         * ax.h: Rename include guard.
13232         * arm-linux-tdep.h: Add include guard.
13233         * arm-fbsd-tdep.h: Add include guard.
13234         * arch/xtensa.h: Rename include guard.
13235         * arch/tic6x.h: Add include guard.
13236         * arch/i386.h: Add include guard.
13237         * arch/arm.h: Rename include guard.
13238         * arch/arm-linux.h: Rename include guard.
13239         * arch/arm-get-next-pcs.h: Rename include guard.
13240         * arch/amd64.h: Add include guard.
13241         * arch/aarch64-insn.h: Rename include guard.
13242         * arch-utils.h: Rename include guard.
13243         * annotate.h: Add include guard.
13244         * amd64-darwin-tdep.h: Rename include guard.
13245         * aarch64-linux-tdep.h: Add include guard.
13246         * aarch64-fbsd-tdep.h: Add include guard.
13247         * aarch32-linux-nat.h: Add include guard.
13248
13249 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13250
13251         * macrotab.c (macro_define_internal): New function that
13252         factorizes macro_define_object_internal and macro_define_function
13253         code.
13254         (macro_define_object_internal): Use macro_define_internal.
13255         (macro_define_function): Likewise.
13256
13257 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13258
13259         * macrocmd.c (extract_identifier): Return
13260         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
13261         callers.
13262
13263 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
13264
13265         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
13266
13267 2019-02-05  Tom Tromey  <tom@tromey.com>
13268
13269         * target.c (target_stack::unpush): Move assertion earlier.
13270
13271 2019-01-30  Tom Tromey  <tom@tromey.com>
13272
13273         PR python/23615:
13274         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
13275         (gdbpy_parse_and_eval): Likewise.
13276         * python/python-internal.h (gdbpy_allow_threads): New class.
13277
13278 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
13279
13280         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
13281         (aarch64_fbsd_fpregmap): Move earlier.
13282         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
13283         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
13284         instead of individual calls to trad_frame_set_reg_addr.
13285         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
13286         earlier.
13287         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
13288         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
13289         instead of individual calls to trad_frame_set_reg_addr.
13290
13291 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
13292
13293         * CONTRIBUTE: Replace contribution list with wiki link.
13294
13295 2019-01-25  Tom Tromey  <tom@tromey.com>
13296
13297         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
13298
13299 2019-01-25  Tom Tromey  <tom@tromey.com>
13300
13301         * xtensa-linux-nat.c: Fix common/ includes.
13302         * xml-support.h: Fix common/ includes.
13303         * xml-support.c: Fix common/ includes.
13304         * x86-linux-nat.c: Fix common/ includes.
13305         * windows-nat.c: Fix common/ includes.
13306         * varobj.h: Fix common/ includes.
13307         * varobj.c: Fix common/ includes.
13308         * value.c: Fix common/ includes.
13309         * valops.c: Fix common/ includes.
13310         * utils.c: Fix common/ includes.
13311         * unittests/xml-utils-selftests.c: Fix common/ includes.
13312         * unittests/utils-selftests.c: Fix common/ includes.
13313         * unittests/unpack-selftests.c: Fix common/ includes.
13314         * unittests/tracepoint-selftests.c: Fix common/ includes.
13315         * unittests/style-selftests.c: Fix common/ includes.
13316         * unittests/string_view-selftests.c: Fix common/ includes.
13317         * unittests/scoped_restore-selftests.c: Fix common/ includes.
13318         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
13319         * unittests/scoped_fd-selftests.c: Fix common/ includes.
13320         * unittests/rsp-low-selftests.c: Fix common/ includes.
13321         * unittests/parse-connection-spec-selftests.c: Fix common/
13322         includes.
13323         * unittests/optional-selftests.c: Fix common/ includes.
13324         * unittests/offset-type-selftests.c: Fix common/ includes.
13325         * unittests/observable-selftests.c: Fix common/ includes.
13326         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
13327         * unittests/memrange-selftests.c: Fix common/ includes.
13328         * unittests/memory-map-selftests.c: Fix common/ includes.
13329         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
13330         * unittests/function-view-selftests.c: Fix common/ includes.
13331         * unittests/environ-selftests.c: Fix common/ includes.
13332         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
13333         * unittests/common-utils-selftests.c: Fix common/ includes.
13334         * unittests/cli-utils-selftests.c: Fix common/ includes.
13335         * unittests/array-view-selftests.c: Fix common/ includes.
13336         * ui-file.c: Fix common/ includes.
13337         * tui/tui-io.c: Fix common/ includes.
13338         * tracepoint.h: Fix common/ includes.
13339         * tracepoint.c: Fix common/ includes.
13340         * tracefile-tfile.c: Fix common/ includes.
13341         * top.h: Fix common/ includes.
13342         * top.c: Fix common/ includes.
13343         * thread.c: Fix common/ includes.
13344         * target/waitstatus.h: Fix common/ includes.
13345         * target/waitstatus.c: Fix common/ includes.
13346         * target.h: Fix common/ includes.
13347         * target.c: Fix common/ includes.
13348         * target-memory.c: Fix common/ includes.
13349         * target-descriptions.c: Fix common/ includes.
13350         * symtab.h: Fix common/ includes.
13351         * symfile.c: Fix common/ includes.
13352         * stap-probe.c: Fix common/ includes.
13353         * spu-linux-nat.c: Fix common/ includes.
13354         * sparc-nat.c: Fix common/ includes.
13355         * source.c: Fix common/ includes.
13356         * solib.c: Fix common/ includes.
13357         * solib-target.c: Fix common/ includes.
13358         * ser-unix.c: Fix common/ includes.
13359         * ser-tcp.c: Fix common/ includes.
13360         * ser-pipe.c: Fix common/ includes.
13361         * ser-base.c: Fix common/ includes.
13362         * selftest-arch.c: Fix common/ includes.
13363         * s12z-tdep.c: Fix common/ includes.
13364         * rust-exp.y: Fix common/ includes.
13365         * rs6000-aix-tdep.c: Fix common/ includes.
13366         * riscv-tdep.c: Fix common/ includes.
13367         * remote.c: Fix common/ includes.
13368         * remote-notif.h: Fix common/ includes.
13369         * remote-fileio.h: Fix common/ includes.
13370         * remote-fileio.c: Fix common/ includes.
13371         * regcache.h: Fix common/ includes.
13372         * regcache.c: Fix common/ includes.
13373         * record-btrace.c: Fix common/ includes.
13374         * python/python.c: Fix common/ includes.
13375         * python/py-type.c: Fix common/ includes.
13376         * python/py-inferior.c: Fix common/ includes.
13377         * progspace.h: Fix common/ includes.
13378         * producer.c: Fix common/ includes.
13379         * procfs.c: Fix common/ includes.
13380         * proc-api.c: Fix common/ includes.
13381         * printcmd.c: Fix common/ includes.
13382         * ppc-linux-nat.c: Fix common/ includes.
13383         * parser-defs.h: Fix common/ includes.
13384         * osdata.c: Fix common/ includes.
13385         * obsd-nat.c: Fix common/ includes.
13386         * nat/x86-linux.c: Fix common/ includes.
13387         * nat/x86-linux-dregs.c: Fix common/ includes.
13388         * nat/x86-dregs.h: Fix common/ includes.
13389         * nat/x86-dregs.c: Fix common/ includes.
13390         * nat/ppc-linux.c: Fix common/ includes.
13391         * nat/mips-linux-watch.h: Fix common/ includes.
13392         * nat/mips-linux-watch.c: Fix common/ includes.
13393         * nat/linux-waitpid.c: Fix common/ includes.
13394         * nat/linux-ptrace.h: Fix common/ includes.
13395         * nat/linux-ptrace.c: Fix common/ includes.
13396         * nat/linux-procfs.c: Fix common/ includes.
13397         * nat/linux-personality.c: Fix common/ includes.
13398         * nat/linux-osdata.c: Fix common/ includes.
13399         * nat/linux-namespaces.c: Fix common/ includes.
13400         * nat/linux-btrace.h: Fix common/ includes.
13401         * nat/linux-btrace.c: Fix common/ includes.
13402         * nat/fork-inferior.c: Fix common/ includes.
13403         * nat/amd64-linux-siginfo.c: Fix common/ includes.
13404         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
13405         * nat/aarch64-linux.c: Fix common/ includes.
13406         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
13407         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
13408         * namespace.h: Fix common/ includes.
13409         * mips-linux-tdep.c: Fix common/ includes.
13410         * minsyms.c: Fix common/ includes.
13411         * mi/mi-parse.h: Fix common/ includes.
13412         * mi/mi-main.c: Fix common/ includes.
13413         * mi/mi-cmd-env.c: Fix common/ includes.
13414         * memrange.h: Fix common/ includes.
13415         * memattr.c: Fix common/ includes.
13416         * maint.h: Fix common/ includes.
13417         * maint.c: Fix common/ includes.
13418         * main.c: Fix common/ includes.
13419         * machoread.c: Fix common/ includes.
13420         * location.c: Fix common/ includes.
13421         * linux-thread-db.c: Fix common/ includes.
13422         * linux-nat.c: Fix common/ includes.
13423         * linux-fork.c: Fix common/ includes.
13424         * inline-frame.c: Fix common/ includes.
13425         * infrun.c: Fix common/ includes.
13426         * inflow.c: Fix common/ includes.
13427         * inferior.h: Fix common/ includes.
13428         * inferior.c: Fix common/ includes.
13429         * infcmd.c: Fix common/ includes.
13430         * inf-ptrace.c: Fix common/ includes.
13431         * inf-child.c: Fix common/ includes.
13432         * ia64-linux-nat.c: Fix common/ includes.
13433         * i387-tdep.c: Fix common/ includes.
13434         * i386-tdep.c: Fix common/ includes.
13435         * i386-linux-tdep.c: Fix common/ includes.
13436         * i386-linux-nat.c: Fix common/ includes.
13437         * i386-go32-tdep.c: Fix common/ includes.
13438         * i386-fbsd-tdep.c: Fix common/ includes.
13439         * i386-fbsd-nat.c: Fix common/ includes.
13440         * guile/scm-type.c: Fix common/ includes.
13441         * guile/guile.c: Fix common/ includes.
13442         * go32-nat.c: Fix common/ includes.
13443         * gnu-nat.c: Fix common/ includes.
13444         * gdbthread.h: Fix common/ includes.
13445         * gdbarch-selftests.c: Fix common/ includes.
13446         * gdb_usleep.c: Fix common/ includes.
13447         * gdb_select.h: Fix common/ includes.
13448         * gdb_bfd.c: Fix common/ includes.
13449         * gcore.c: Fix common/ includes.
13450         * fork-child.c: Fix common/ includes.
13451         * findvar.c: Fix common/ includes.
13452         * fbsd-nat.c: Fix common/ includes.
13453         * event-top.c: Fix common/ includes.
13454         * event-loop.c: Fix common/ includes.
13455         * dwarf2read.c: Fix common/ includes.
13456         * dwarf2loc.c: Fix common/ includes.
13457         * dwarf2-frame.c: Fix common/ includes.
13458         * dwarf-index-cache.c: Fix common/ includes.
13459         * dtrace-probe.c: Fix common/ includes.
13460         * disasm-selftests.c: Fix common/ includes.
13461         * defs.h: Fix common/ includes.
13462         * csky-tdep.c: Fix common/ includes.
13463         * cp-valprint.c: Fix common/ includes.
13464         * cp-support.h: Fix common/ includes.
13465         * cp-support.c: Fix common/ includes.
13466         * corelow.c: Fix common/ includes.
13467         * completer.h: Fix common/ includes.
13468         * completer.c: Fix common/ includes.
13469         * compile/compile.c: Fix common/ includes.
13470         * compile/compile-loc2c.c: Fix common/ includes.
13471         * compile/compile-cplus-types.c: Fix common/ includes.
13472         * compile/compile-cplus-symbols.c: Fix common/ includes.
13473         * command.h: Fix common/ includes.
13474         * cli/cli-dump.c: Fix common/ includes.
13475         * cli/cli-cmds.c: Fix common/ includes.
13476         * charset.c: Fix common/ includes.
13477         * build-id.c: Fix common/ includes.
13478         * btrace.h: Fix common/ includes.
13479         * btrace.c: Fix common/ includes.
13480         * breakpoint.h: Fix common/ includes.
13481         * breakpoint.c: Fix common/ includes.
13482         * ax.h:
13483         (enum agent_op): Fix common/ includes.
13484         * ax-general.c (struct aop_map): Fix common/ includes.
13485         * ax-gdb.c: Fix common/ includes.
13486         * auxv.c: Fix common/ includes.
13487         * auto-load.c: Fix common/ includes.
13488         * arm-tdep.c: Fix common/ includes.
13489         * arch/riscv.c: Fix common/ includes.
13490         * arch/ppc-linux-common.c: Fix common/ includes.
13491         * arch/i386.c: Fix common/ includes.
13492         * arch/arm.c: Fix common/ includes.
13493         * arch/arm-linux.c: Fix common/ includes.
13494         * arch/arm-get-next-pcs.c: Fix common/ includes.
13495         * arch/amd64.c: Fix common/ includes.
13496         * arch/aarch64.c: Fix common/ includes.
13497         * arch/aarch64-insn.c: Fix common/ includes.
13498         * arch-utils.c: Fix common/ includes.
13499         * amd64-windows-tdep.c: Fix common/ includes.
13500         * amd64-tdep.c: Fix common/ includes.
13501         * amd64-sol2-tdep.c: Fix common/ includes.
13502         * amd64-obsd-tdep.c: Fix common/ includes.
13503         * amd64-nbsd-tdep.c: Fix common/ includes.
13504         * amd64-linux-tdep.c: Fix common/ includes.
13505         * amd64-linux-nat.c: Fix common/ includes.
13506         * amd64-fbsd-tdep.c: Fix common/ includes.
13507         * amd64-fbsd-nat.c: Fix common/ includes.
13508         * amd64-dicos-tdep.c: Fix common/ includes.
13509         * amd64-darwin-tdep.c: Fix common/ includes.
13510         * agent.c: Fix common/ includes.
13511         * ada-lang.h: Fix common/ includes.
13512         * ada-lang.c: Fix common/ includes.
13513         * aarch64-tdep.c: Fix common/ includes.
13514
13515 2019-01-25  Tom Tromey  <tom@tromey.com>
13516
13517         * common/create-version.sh: Use common/version.h.
13518
13519 2019-01-24  Pedro Alves  <palves@redhat.com>
13520
13521         * infrun.c (signal_stop, signal_print, signal_program)
13522         (signal_catch, signal_pass): Now arrays instead of pointers.
13523         (update_signals_program_target, do_target_resume)
13524         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
13525         * linux-nat.c (linux_nat_target::pass_signals)
13526         (linux_nat_target::create_inferior, linux_nat_target::attach):
13527         Adjust.
13528         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
13529         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
13530         * procfs.c (procfs_target::pass_signals): Adjust.
13531         * record-full.c (record_full_target::resume): Adjust.
13532         * remote.c (remote_target::pass_signals)
13533         (remote_target::program_signals): Adjust.
13534         * target-debug.h (target_debug_print_signals): Now takes a
13535         gdb::array_view as parameter.  Adjust.
13536         * target.h (target_ops) <pass_signals, program_signals>: Replace
13537         pointer and length parameters with gdb::array_view.
13538         (target_pass_signals, target_program_signals): Likewise.
13539         * target-delegates.c: Regenerate.
13540
13541 2019-01-24  Pedro Alves  <palves@redhat.com>
13542
13543         * common/forward-scope-exit.h
13544         (forward_scope_exit::forward_scope_exit): Pass arguments to
13545         m_bind_function directly, instead of creating a std::bind and
13546         copying that.
13547
13548 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
13549
13550         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
13551         for static members.
13552         (pass_in_v_vfp_candidate): Likewise.
13553
13554 2019-01-23  Tom Tromey  <tom@tromey.com>
13555             Pedro Alves  <palves@redhat.com>
13556
13557         * regcache.c (class regcache_invalidator): Remove.
13558         (regcache::raw_write): Use make_scope_exit.
13559
13560 2019-01-23  Tom Tromey  <tom@tromey.com>
13561
13562         * ui-out.h (class ui_out_emit_type): Update comment.
13563
13564 2019-01-23  Tom Tromey  <tom@tromey.com>
13565
13566         * infrun.c (fetch_inferior_event): Update comment.
13567
13568 2019-01-23  Tom Tromey  <tom@tromey.com>
13569             Pedro Alves  <palves@redhat.com>
13570
13571         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
13572         parameter.
13573         (fetch_inferior_event): Use SCOPE_EXIT.
13574
13575
13576 2019-01-23  Tom Tromey  <tom@tromey.com>
13577             Pedro Alves  <palves@redhat.com>
13578
13579         * infrun.c (disable_thread_events): Delete.
13580         (stop_all_threads): Use SCOPE_EXIT.
13581
13582 2019-01-23  Tom Tromey  <tom@tromey.com>
13583             Pedro Alves  <palves@redhat.com>
13584
13585         * symfile.c: Include forward-scope-exit.h.
13586         (clear_symtab_users_cleanup): Replace forward declaration with
13587         a FORWARD_SCOPE_EXIT.
13588         (syms_from_objfile_1): Use the forward_scope_exit and
13589         gdb::optional instead of cleanup_function.
13590         (reread_symbols): Use the forward_scope_exit instead of
13591         cleanup_function.
13592         (clear_symtab_users_cleanup): Remove function.
13593
13594 2019-01-23  Tom Tromey  <tom@tromey.com>
13595             Pedro Alves  <palves@redhat.com>
13596
13597         * linux-nat.c: Include scope-exit.h.
13598         (cleanup_target_stop): Remove.
13599         (linux_nat_target::static_tracepoint_markers_by_strid): Use
13600         SCOPE_EXIT.
13601
13602 2019-01-23  Tom Tromey  <tom@tromey.com>
13603             Pedro Alves  <palves@redhat.com>
13604
13605         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
13606         (call_function_by_hand_dummy): Use SCOPE_EXIT.
13607
13608 2019-01-23  Tom Tromey  <tom@tromey.com>
13609             Andrew Burgess  <andrew.burgess@embecosm.com>
13610             Pedro Alves  <palves@redhat.com>
13611
13612         * infrun.c (fetch_inferior_event): Use scope_exit.
13613         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
13614         * top.c (execute_command): Use scope_exit.
13615         * breakpoint.c (bpstat_do_actions): Use scope_exit.
13616         * utils.c (do_bpstat_clear_actions_cleanup)
13617         (make_bpstat_clear_actions_cleanup): Remove.
13618
13619 2019-01-23  Tom Tromey  <tom@tromey.com>
13620             Pedro Alves  <palves@redhat.com>
13621
13622         * infrun.c: Include "common/scope-exit.h"
13623         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
13624         (wait_for_inferior): Use SCOPE_EXIT.
13625         (fetch_inferior_event): Use scope_exit.
13626
13627 2019-01-23  Tom Tromey  <tom@tromey.com>
13628             Pedro Alves  <palves@redhat.com>
13629
13630         * breakpoint.c (create_breakpoint): Remove cleanup.
13631
13632 2019-01-23  Tom Tromey  <tom@tromey.com>
13633             Andrew Burgess  <andrew.burgess@embecosm.com>
13634             Pedro Alves  <palves@redhat.com>
13635
13636 2019-01-23  Pedro Alves  <palves@redhat.com>
13637
13638         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
13639
13640 2019-01-23  Pedro Alves  <palves@redhat.com>
13641             Andrew Burgess  <andrew.burgess@embecosm.com>
13642
13643         * gdbthread.h: Include "common/forward-scope-exit.h".
13644         (scoped_finish_thread_state): Redefine custom class in terms of
13645         forward_scope_exit.
13646
13647 2019-01-23  Pedro Alves  <palves@redhat.com>
13648             Andrew Burgess  <andrew.burgess@embecosm.com>
13649
13650         * common/forward-scope-exit.h: New file.
13651
13652 2019-01-23  Pedro Alves  <palves@redhat.com>
13653             Andrew Burgess  <andrew.burgess@embecosm.com>
13654             Tom Tromey  <tom@tromey.com>
13655
13656         * common/scope-exit.h: New file.
13657
13658 2019-01-23  Pedro Alves  <palves@redhat.com>
13659
13660         * common/preprocessor.h (ESC): Rename to ...
13661         (ESC_PARENS): ... this.
13662         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
13663         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
13664
13665 2019-01-23  Tom Tromey  <tom@tromey.com>
13666
13667         * language.h (class scoped_switch_to_sym_language_if_auto):
13668         Initialize m_lang in both cases.
13669
13670 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
13671
13672         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
13673         with XCNEW.
13674
13675 2019-01-22  Tom Tromey  <tom@tromey.com>
13676
13677         * corelow.c: Do not include sys/file.h.
13678
13679 2019-01-22  Tom Tromey  <tom@tromey.com>
13680
13681         * tui/tui-wingeneral.h: Include gdb_curses.h.
13682
13683 2019-01-22  Tom Tromey  <tom@tromey.com>
13684
13685         * source-cache.h (class source_cache) <get_source_lines,
13686         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
13687
13688 2019-01-22  Tom Tromey  <tom@tromey.com>
13689
13690         * remote-fileio.h (struct remote_target): Declare.
13691
13692 2019-01-22  Tom Tromey  <tom@tromey.com>
13693
13694         * python/py-arch.c: Do not include py-ref.h.
13695         * python/py-bpevent.c: Do not include py-ref.h.
13696         * python/py-cmd.c: Do not include py-ref.h.
13697         * python/py-continueevent.c: Do not include py-ref.h.
13698         * python/py-event.h: Do not include py-ref.h.
13699         * python/py-evtregistry.c: Do not include py-ref.h.
13700         * python/py-finishbreakpoint.c: Do not include py-ref.h.
13701         * python/py-frame.c: Do not include py-ref.h.
13702         * python/py-framefilter.c: Do not include py-ref.h.
13703         * python/py-function.c: Do not include py-ref.h.
13704         * python/py-infevents.c: Do not include py-ref.h.
13705         * python/py-linetable.c: Do not include py-ref.h.
13706         * python/py-objfile.c: Do not include py-ref.h.
13707         * python/py-param.c: Do not include py-ref.h.
13708         * python/py-prettyprint.c: Do not include py-ref.h.
13709         * python/py-progspace.c: Do not include py-ref.h.
13710         * python/py-symbol.c: Do not include py-ref.h.
13711         * python/py-symtab.c: Do not include py-ref.h.
13712         * python/py-type.c: Do not include py-ref.h.
13713         * python/py-unwind.c: Do not include py-ref.h.
13714         * python/py-utils.c: Do not include py-ref.h.
13715         * python/py-value.c: Do not include py-ref.h.
13716         * python/py-varobj.c: Do not include py-ref.h.
13717         * python/py-xmethods.c: Do not include py-ref.h.
13718         * python/python.c: Do not include py-ref.h.
13719         * varobj.c: Do not include py-ref.h.
13720
13721 2019-01-22  Tom Tromey  <tom@tromey.com>
13722
13723         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
13724         keyword for bcache.
13725
13726 2019-01-22  Tom Tromey  <tom@tromey.com>
13727
13728         * compile/compile-cplus-types.c: Remove a comment by #include.
13729
13730 2019-01-22  Tom Tromey  <tom@tromey.com>
13731
13732         * compile/gcc-c-plugin.h: Include compile-internal.h.
13733
13734 2019-01-22  Tom Tromey  <tom@tromey.com>
13735
13736         * stabsread.c (EXTERN): Do not define.
13737         (symnum, next_symbol_text_func, processing_gcc_compilation)
13738         (within_function, global_sym_chain, global_stabs)
13739         (previous_stab_code, this_object_header_files)
13740         (n_this_object_header_files)
13741         (n_allocated_this_object_header_files): Define.
13742         * stabsread.h (EXTERN): Never define.  Use "extern".
13743
13744 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13745
13746         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
13747         history_value.
13748
13749 2019-01-21  Tom Tromey  <tom@tromey.com>
13750
13751         * ui-out.c: Fix includes.
13752         * tui/tui-source.c: Fix includes.
13753         * target.c: Fix includes.
13754         * remote.c: Fix includes.
13755         * regcache.c: Fix includes.
13756         * python/py-block.c: Fix includes.
13757         * printcmd.c: Fix includes.
13758         * or1k-tdep.c: Fix includes.
13759         * mi/mi-main.c: Fix includes.
13760         * m32r-tdep.c: Fix includes.
13761         * csky-tdep.c: Fix includes.
13762         * compile/compile-cplus-types.c: Fix includes.
13763         * cli/cli-interp.c: Fix includes.
13764
13765 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
13766
13767         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
13768         for padding.
13769
13770 2019-01-16  Tom Tromey  <tom@tromey.com>
13771
13772         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
13773         earlier.
13774         (struct objfile) <msymbols_range>: Move from top level.
13775         <msymbols>: New method.
13776         (class objfile_msymbols): Remove.
13777         * symtab.c (default_collect_symbol_completion_matches_break_on):
13778         Update.
13779         * symmisc.c (dump_msymbols): Update.
13780         * stabsread.c (scan_file_globals): Update.
13781         * objc-lang.c (info_selectors_command, info_classes_command)
13782         (find_methods): Update.
13783         * minsyms.c (find_solib_trampoline_target): Update.
13784         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
13785         * coffread.c (coff_symfile_read): Update.
13786         * ada-lang.c (ada_lookup_simple_minsym)
13787         (ada_collect_symbol_completion_matches): Update.
13788
13789 2019-01-16  Tom Tromey  <tom@tromey.com>
13790
13791         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
13792         type.  Remove no-argument constructor.
13793         <iterator::operator++>: Simplify.
13794         <begin>: Update.
13795         <end>: Use minimal_symbol_count.
13796
13797 2019-01-16  Tom Tromey  <tom@tromey.com>
13798
13799         * objfiles.h (struct objfile) <psymtabs>: New method.
13800         (class objfile_psymtabs): Remove.
13801         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
13802         typedef.
13803         <range>: New method.
13804         (require_partial_symbols): Change return type.
13805         * psymtab.c (require_partial_symbols)
13806         (psym_expand_symtabs_matching): Update.
13807         * mdebugread.c (parse_partial_symbols): Update.
13808         * dbxread.c (dbx_end_psymtab): Update.
13809
13810 2019-01-15  Tom Tromey  <tom@tromey.com>
13811
13812         * symtab.c (lookup_objfile_from_block)
13813         (lookup_symbol_in_objfile_symtabs)
13814         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
13815         (find_line_symtab, info_sources_command)
13816         (default_collect_symbol_completion_matches_break_on)
13817         (make_source_files_completion_list): Update.
13818         * symmisc.c (print_objfile_statistics, dump_objfile)
13819         (maintenance_print_symbols, maintenance_info_symtabs)
13820         (maintenance_check_symtabs, maintenance_info_line_tables):
13821         Update.
13822         * source.c (select_source_symtab)
13823         (forget_cached_source_info_for_objfile): Update.
13824         * objfiles.h (class objfile_compunits): Remove.
13825         (struct objfile) <compunits_range>: New typedef.
13826         (compunits): New method.
13827         * objfiles.c (objfile_relocate1): Update.
13828         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
13829         * maint.c (count_symtabs_and_blocks): Update.
13830         * linespec.c (iterate_over_all_matching_symtabs): Update.
13831         * cp-support.c (add_symbol_overload_list_qualified): Update.
13832         * coffread.c (coff_symtab_read): Update.
13833         * ada-lang.c (add_nonlocal_symbols)
13834         (ada_collect_symbol_completion_matches)
13835         (ada_add_global_exceptions): Update.
13836
13837 2019-01-15  Tom Tromey  <tom@tromey.com>
13838
13839         * progspace.h (program_space) <objfiles_safe_range>: New
13840         typedef.
13841         <objfiles_safe>: New method.
13842         * objfiles.h (class all_objfiles_safe): Remove.
13843         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
13844         * jit.c (jit_inferior_exit_hook): Update.
13845
13846 2019-01-17  Tom Tromey  <tom@tromey.com>
13847
13848         * progspace.h (program_space) <objfiles_range>: New typedef.
13849         <objfiles>: New method.
13850         <objfiles_head>: Rename from objfiles.
13851         (object_files): Update.
13852         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
13853         * guile/scm-pretty-print.c
13854         (ppscm_find_pretty_printer_from_objfiles): Update.
13855         * guile/scm-objfile.c (gdbscm_objfiles): Update.
13856         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
13857         Update.
13858         * python/py-progspace.c (pspy_get_objfiles): Update.
13859         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
13860         Update.
13861         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
13862         (objfpy_lookup_objfile_by_build_id): Update.
13863         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
13864         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
13865         Update.
13866         * symtab.c (iterate_over_symtabs, matching_obj_sections)
13867         (expand_symtab_containing_pc, lookup_objfile_from_block)
13868         (lookup_static_symbol, basic_lookup_transparent_type)
13869         (find_pc_sect_compunit_symtab, find_symbol_at_address)
13870         (find_line_symtab, info_sources_command)
13871         (default_collect_symbol_completion_matches_break_on)
13872         (make_source_files_completion_list, find_main_name): Update.
13873         * symmisc.c (print_symbol_bcache_statistics)
13874         (print_objfile_statistics, maintenance_print_symbols)
13875         (maintenance_print_msymbols, maintenance_print_objfiles)
13876         (maintenance_info_symtabs, maintenance_check_symtabs)
13877         (maintenance_expand_symtabs, maintenance_info_line_tables):
13878         Update.
13879         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
13880         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
13881         (map_overlay_command, unmap_overlay_command)
13882         (simple_overlay_update, expand_symtabs_matching)
13883         (map_symbol_filenames): Update.
13884         * symfile-debug.c (set_debug_symfile): Update.
13885         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
13886         Update.
13887         * source.c (select_source_symtab, forget_cached_source_info):
13888         Update.
13889         * solib.c (solib_read_symbols): Update.
13890         * solib-spu.c (append_ocl_sos): Update.
13891         * psymtab.c (maintenance_print_psymbols)
13892         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
13893         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
13894         * printcmd.c (info_symbol_command): Update.
13895         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
13896         Update.
13897         * objfiles.h (class all_objfiles): Remove.
13898         * objfiles.c (have_partial_symbols, have_full_symbols)
13899         (have_minimal_symbols, qsort_cmp, update_section_map)
13900         (shared_objfile_contains_address_p)
13901         (default_iterate_over_objfiles_in_search_order): Update.
13902         * objc-lang.c (info_selectors_command, info_classes_command)
13903         (find_methods): Update.
13904         * minsyms.c (find_solib_trampoline_target): Update.
13905         * maint.c (maintenance_info_sections)
13906         (maintenance_translate_address, count_symtabs_and_blocks):
13907         Update.
13908         * main.c (captured_main_1): Update.
13909         * linux-thread-db.c (try_thread_db_load_from_pdir)
13910         (has_libpthread): Update.
13911         * linespec.c (iterate_over_all_matching_symtabs)
13912         (search_minsyms_for_name): Update.
13913         * jit.c (jit_find_objf_with_entry_addr): Update.
13914         * hppa-tdep.c (find_unwind_entry)
13915         (hppa_lookup_stub_minimal_symbol): Update.
13916         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
13917         Update.
13918         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
13919         (elf_gnu_ifunc_resolve_by_got): Update.
13920         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
13921         * dwarf-index-write.c (save_gdb_index_command): Update.
13922         * cp-support.c (add_symbol_overload_list_qualified): Update.
13923         * breakpoint.c (create_overlay_event_breakpoint)
13924         (create_longjmp_master_breakpoint)
13925         (create_std_terminate_master_breakpoint)
13926         (create_exception_master_breakpoint): Update.
13927         * blockframe.c (find_pc_partial_function): Update.
13928         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
13929         (ada_collect_symbol_completion_matches)
13930         (ada_add_global_exceptions): Update.
13931
13932 2019-01-17  Tom Tromey  <tom@tromey.com>
13933
13934         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
13935         declare VEC.
13936         (solib_target_parse_libraries): Change return type.
13937         (library_list_start_segment, library_list_start_section)
13938         (library_list_end_library, library_list_start_library); Update.
13939         (solib_target_free_library_list): Remove.
13940         (solib_target_parse_libraries): Remove cleanup.  Change return
13941         type.
13942         (solib_target_current_sos): Update.
13943
13944 2019-01-17  Tom Tromey  <tromey@bapiya>
13945
13946         * valprint.c: Replace "the the" with "the".
13947         * symtab.c: Replace "the the" with "the".
13948         * solib.c: Replace "the the" with "the".
13949         * solib-dsbt.c: Replace "the the" with "the".
13950         * linespec.c: Replace "the the" with "the".
13951         * dwarf2loc.h: Replace "the the" with "the".
13952         * amd64-windows-tdep.c: Replace "the the" with "the".
13953         * aarch64-tdep.c: Replace "the the" with "the".
13954
13955 2019-01-16  Keith Seitz  <keiths@redhat.com>
13956
13957         PR gdb/23773
13958         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
13959         <builder>: Rename to ..
13960         <m_builder>: ... this and make private.
13961         (dwarf2_cu::get_builder): New method.  Change all users of
13962         `builder' to use this method.
13963         (dwarf2_start_symtab): Move to ...
13964         (dwarf2_cu::start_symtab): ... here.  Update all callers
13965         (setup_type_unit_groups): Move to ...
13966         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
13967         callers.
13968         (dwarf2_cu::reset_builder): New method.
13969         (process_full_compunit, process_full_type_unit): Use
13970         dwarf2_cu::reset_builder.
13971         (follow_die_offset): Record the ancestor CU if it is different
13972         from the followed DIE's CU.
13973         (follow_die_sig_1): Likewise.
13974
13975 2019-01-15  Tom Tromey  <tom@tromey.com>
13976
13977         * remote.c (class remote_state) <buf>: Now a char_vector.
13978         <buf_size>: Remove.
13979         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
13980         parameter.
13981         (remote_target::getpkt_or_notif_sane_1)
13982         (remote_target::getpkt_sane)
13983         (remote_target::getpkt_or_notif_sane): Likewise.
13984         (class remote_target) <putpkt>: New overload.
13985         (remote_target::read_frame): Change type of "buf_p".  Remove
13986         sizeof_p parameter.
13987         (packet_ok): New overload.
13988         (packet_check_result): New overload.
13989         Update all uses.
13990
13991 2019-01-14  Tom Tromey  <tom@tromey.com>
13992
13993         * remote-notif.c (handle_notification, remote_notif_ack)
13994         (remote_notif_parse): Make "buf" const.
13995         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
13996         const.
13997         (remote_notif_parse, remote_notif_ack, handle_notification):
13998         Likewise.
13999         * remote.c (remote_notif_stop_parse): Make "buf" const.
14000         (remote_target::remote_parse_stop_reply): Make "buf" const.
14001         (remote_notif_stop_ack): Make "buf" const.
14002
14003 2019-01-14  Tom Tromey  <tom@tromey.com>
14004
14005         * remote.c (remote_console_output): Make parameter const.
14006
14007 2019-01-14  Tom Tromey  <tom@tromey.com>
14008
14009         * target-debug.h (target_debug_print_signals): Constify.
14010         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
14011         * procfs.c (procfs_target::pass_signals): Update.
14012         * linux-nat.c (linux_nat_target::pass_signals): Update.
14013         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
14014         * target-delegates.c: Rebuild.
14015         * remote.c (remote_target::program_signals): Update.
14016         (remote_target::pass_signals): Update.
14017         * target.c (target_pass_signals): Constify argument.
14018         (target_program_signals): Likewise.
14019         * target.h (struct target_ops) <pass_signals, program_signals>:
14020         Constify argument.
14021         (target_pass_signals, target_program_signals): Constify argument.
14022
14023 2019-01-14  Tom Tromey  <tom@tromey.com>
14024
14025         PR tui/28819:
14026         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
14027
14028 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
14029
14030         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
14031         field.
14032         * rs6000-tdep.c: Include reggroups.h.
14033         (IS_V_ALIAS_PSEUDOREG): Define.
14034         (rs6000_register_name): Return names for the "vX" aliases.
14035         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
14036         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
14037         aliases.  Call default_register_reggroup_p for all other
14038         pseudo-registers.
14039         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
14040         New functions.
14041         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
14042         Handle "vX" aliases.
14043         (v_alias_pseudo_register_collect): New function.
14044         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
14045         (rs6000_gdbarch_init): Initialize "vX" aliases as
14046         pseudo-registers.  Restore registration of
14047         rs6000_pseudo_register_reggroup_p with
14048         set_tdesc_pseudo_register_reggroup_p.
14049
14050 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
14051
14052         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
14053         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
14054         set_gdbarch_num_pseudo_regs.
14055
14056 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14057
14058         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
14059         Remove arg prefixname, add do_set and do_show.
14060         Add member functions set_list and show_list.
14061         * cli/cli-style.c (class cli_style_option): Update accordingly.
14062         (style_set_list): Move to file scope.
14063         (style_show_list): Likewise.
14064         (set_style): Call help_list.
14065         (show_style): Call cmd_show_list.
14066         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
14067         Update to use the new macro.
14068
14069 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
14070
14071         * ada-lang.c (_initialize_ada_language): Expand the help text
14072         for the "catch exception" command.
14073
14074 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14075
14076         * symtab.c (matching_obj_sections): Initialize obj,
14077         declare it closer to its usage.
14078
14079 2019-01-10  Tom Tromey  <tom@tromey.com>
14080
14081         * thread-iter.h (inf_threads_iterator): Use next_iterator.
14082         (basic_inf_threads_range): Remove.
14083         (inf_threads_range, inf_non_exited_threads_range)
14084         (safe_inf_threads_range): Use next_adapter.
14085
14086 2019-01-10  Keith Seitz  <keiths@redhat.com>
14087
14088         PR gdb/23712
14089         PR symtab/23010
14090         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
14091         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
14092
14093 2019-01-10  Keith Seitz  <keiths@redhat.com>
14094
14095         PR gdb/23712
14096         PR symtab/23010
14097         * dictionary.c (pending_to_vector): Remove.
14098         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
14099         Remove _1 suffix, replacing functions of the same name.  Update
14100         all callers.
14101         (dict_create_hashed, dict_create_hashed_expandable)
14102         (dict_create_linear, dict_create_linear_expandable, dict_free)
14103         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
14104         Make functions static.
14105
14106 2019-01-10  Keith Seitz  <keiths@redhat.com>
14107
14108         PR gdb/23712
14109         PR symtab/23010
14110         * dictionary.h (struct dictionary): Replace declaration with
14111         multidictionary.
14112         (dict_create_hashed, dict_create_hashed_expandable)
14113         (dict_create_linear, dict_create_linear_expandable)
14114         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
14115         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
14116         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
14117         taking multidictionary argument.
14118         [ALL_DICT_SYMBOLS]: Update for multidictionary.
14119         * block.h (struct block) <dict>: Change to multidictionary
14120         and rename `multidict'.
14121         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
14122         symmisc.c: Update all dictionary references to multidictionary.
14123
14124 2019-01-10  Keith Seitz  <keiths@redhat.com>
14125
14126         PR gdb/23712
14127         PR symtab/23010
14128         * dictionary.c: Include unordered_map.
14129         (pending_to_vector): New function.
14130         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
14131         Rewrite the non-"_1" functions to take vector instead
14132         of linked list.
14133         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
14134         "new" _1 versions of the same name.
14135         (multidictionary): Define.
14136         (std::hash<enum language): New definition.
14137         (collate_pending_symbols_by_language, mdict_create_hashed)
14138         (mdict_create_hashed_expandable, mdict_create_linear)
14139         (mdict_create_linear_expandable, mdict_free)
14140         (find_language_dictionary, create_new_language_dictionary)
14141         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
14142         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
14143         (mdict_size, mdict_empty): New functions.
14144         * dictionary.h (mdict_iterator): Define.
14145
14146 2019-01-10  Pedro Alves  <palves@redhat.com>
14147
14148         * breakpoint.c (read_uploaded_action)
14149         (create_tracepoint_from_upload): Adjust to use
14150         gdb::unique_xmalloc_ptr.
14151         * ctf.c (ctf_write_uploaded_tp):
14152         (SET_ARRAY_FIELD): Use emplace_back.
14153         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
14154         * tracefile-tfile.c (tfile_write_uploaded_tp):
14155         * tracepoint.c (parse_tracepoint_definition): Adjust to use
14156         gdb::unique_xmalloc_ptr.
14157         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
14158         at_string, cond_string, cmd_strings>: Replace char pointers
14159         with gdb::unique_xmalloc_ptr.
14160
14161 2019-01-10  Pedro Alves  <palves@redhat.com>
14162
14163         * solib-target.c (library_list_start_library): Don't xstrdup name.
14164
14165 2019-01-10  Pedro Alves  <palves@redhat.com>
14166
14167         * mdebugread.c (parse_partial_symbols): Use
14168         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
14169
14170 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
14171
14172         * linux-fork.c (scoped_switch_fork_info)
14173         <~scoped_switch_fork_info>: Fix incorrect variable name.
14174
14175 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
14176
14177         * linux-fork.c (scoped_switch_fork_info)
14178         <scoped_switch_fork_info>: Make explicit.
14179         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
14180
14181 2019-01-10  Tom Tromey  <tom@tromey.com>
14182
14183         * objfiles.h (objfile::reset_psymtabs): Update.
14184         * objfiles.c (objfile::objfile): Update.
14185         * psymtab.h (psymtab_storage::obstack): Update.
14186         (psymtab_storage::m_obstack): Use gdb::optional.
14187         (class psymtab_storage): Update comment.  Remove objfile
14188         parameter.
14189         * psymtab.c (psymtab_storage::psymtab_storage): Update.
14190
14191 2019-01-10  Tom Tromey  <tom@tromey.com>
14192
14193         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
14194         <free_psymtabs>: Now private.
14195         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
14196         (allocate_psymtab): Use new method.
14197
14198 2019-01-10  Tom Tromey  <tom@tromey.com>
14199
14200         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
14201         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
14202         * mdebugread.c (parse_partial_symbols): Use
14203         allocate_dependencies.
14204         * dwarf2read.c (dwarf2_create_include_psymtab): Use
14205         allocate_dependencies.
14206         (process_psymtab_comp_unit_reader)
14207         (build_type_psymtab_dependencies): Likewise.
14208         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
14209
14210 2019-01-10  Tom Tromey  <tom@tromey.com>
14211
14212         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
14213         PSYMBOL_SET_LANGUAGE.
14214         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
14215
14216 2019-01-10  Tom Tromey  <tom@tromey.com>
14217
14218         * psymtab.h (psymtab_storage::obstack): New method.
14219         <m_obstack>: Rename from obstack; now private.
14220         * psymtab.c (psymtab_storage): Update.
14221         * dwarf2read.c (create_addrmap_from_index)
14222         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
14223         Update.
14224
14225 2019-01-10  Tom Tromey  <tom@tromey.com>
14226
14227         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
14228         * objfiles.h (objfile::reset_psymtabs): New method.
14229
14230 2019-01-10  Tom Tromey  <tom@tromey.com>
14231
14232         * symmisc.c (print_symbol_bcache_statistics): Update.
14233         (print_objfile_statistics): Update.
14234         * symfile.c (reread_symbols): Update.
14235         * psymtab.h (class psymtab_storage): New.
14236         * psymtab.c (psymtab_storage): New constructor.
14237         (~psymtab_storage): New destructor.
14238         (require_partial_symbols): Update.
14239         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
14240         (find_pc_sect_psymtab, find_pc_sect_psymbol)
14241         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
14242         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
14243         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
14244         (start_psymtab_common, end_psymtab_common)
14245         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
14246         (allocate_psymtab): Update.
14247         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
14248         Update.
14249         (dump_psymtab_addrmap, maintenance_print_psymbols)
14250         (maintenance_check_psymtabs): Update.
14251         (class objfile_psymtabs): Move to objfiles.h.
14252         * psympriv.h (discard_psymtab): Now inline.
14253         (psymtab_discarder::psymtab_discarder): Update.
14254         (psymtab_discarder::~psymtab_discarder): Update.
14255         (ALL_OBJFILE_PSYMTABS): Rewrite.
14256         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
14257         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
14258         Remove fields.
14259         <partial_symtabs>: New field.
14260         (class objfile_psymtabs): Move from psymtab.h.  Update.
14261         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
14262         psymbol_cache.
14263         (objfile::~objfile): Don't destroy psymbol_cache.
14264         * mdebugread.c (parse_partial_symbols): Update.
14265         * dwarf2read.c (create_addrmap_from_index)
14266         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
14267         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
14268         (add_partial_subprogram, dwarf2_ranges_read): Update.
14269         * dwarf-index-write.c (write_address_map)
14270         (write_one_signatured_type, recursively_write_psymbols)
14271         (class debug_names, class debug_names, write_psymtabs_to_index):
14272         Update.
14273
14274 2019-01-10  Tom Tromey  <tom@tromey.com>
14275
14276         * symtab.h (SYMBOL_SET_NAMES): Update.
14277         (symbol_set_names): Update.
14278         (MSYMBOL_SET_NAMES): Update.
14279         * symtab.c (symbol_set_names): Change argument to be an
14280         objfile_per_bfd_storage.
14281         * psymtab.c (add_psymbol_to_bcache): Update.
14282         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
14283
14284 2019-01-10  Tom Tromey  <tom@tromey.com>
14285
14286         * symtab.c (create_demangled_names_hash): Change argument to be an
14287         objfile_per_bfd_storage.
14288         (symbol_set_names): Update.
14289
14290 2019-01-10  Tom Tromey  <tom@tromey.com>
14291
14292         * xcoffread.c (xcoff_initial_scan): Unconditionally call
14293         init_psymbol_list.
14294         * psymtab.c (init_psymbol_list): Do nothing if already called.
14295         * psympriv.h (init_psymbol_list): Add comment.
14296         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
14297         init_psymbol_list.
14298         * dbxread.c (dbx_symfile_read): Unconditionally call
14299         init_psymbol_list.
14300
14301 2019-01-10  Tom Tromey  <tom@tromey.com>
14302
14303         * xcoffread.c (scan_xcoff_symtab): Update.
14304         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
14305         "where".
14306         * mdebugread.c (parse_partial_symbols)
14307         (handle_psymbol_enumerators): Update.
14308         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
14309         * dbxread.c (read_dbx_symtab): Update.
14310         * psympriv.h (psymbol_placement): New enum.
14311         (add_psymbol_to_list): Update.
14312
14313 2019-01-10  Tom Tromey  <tom@tromey.com>
14314
14315         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
14316         static_psymbols parameters.
14317         (scan_xcoff_symtab): Update.
14318         * psymtab.c (start_psymtab_common): Remove global_psymbols and
14319         static_psymbols parameters.
14320         * psympriv.h (start_psymtab_common): Update.
14321         * mdebugread.c (parse_partial_symbols): Update.
14322         * dwarf2read.c (create_partial_symtab): Update.
14323         * dbxread.c (read_dbx_symtab): Update.
14324         (start_psymtab): Remove global_psymbols and static_psymbols
14325         parameters.
14326
14327 2019-01-10  Tom Tromey  <tom@tromey.com>
14328
14329         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
14330         * psymtab.c (allocate_psymtab): Add comment.
14331         * psympriv.h (allocate_psymtab): Add comment.
14332         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
14333         initializations.
14334         * dbxread.c (dbx_end_psymtab): Remove some initializations.
14335
14336 2019-01-10  Tom Tromey  <tom@tromey.com>
14337
14338         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
14339         Don't declare.
14340         * mipsread.c: Include mdebugread.h.
14341         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
14342         Declare.
14343         * elfread.c: Include mdebugread.h.
14344
14345 2019-01-09  Tom Tromey  <tom@tromey.com>
14346
14347         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
14348         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
14349         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
14350         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
14351         (psym_lookup_symbol, psym_find_last_source_symtab)
14352         (psym_forget_cached_source_info, psym_print_stats)
14353         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
14354         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
14355         (psym_map_matching_symbols, psym_expand_symtabs_matching)
14356         (psym_find_compunit_symtab_by_address)
14357         (maintenance_print_psymbols, maintenance_info_psymtabs)
14358         (maintenance_check_psymtabs): Use ranged for.
14359         * psymtab.h (class objfile_psymtabs): New.
14360         (require_partial_symbols): Return objfile_psymtabs.
14361         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
14362
14363 2019-01-09  Tom Tromey  <tom@tromey.com>
14364
14365         * symfile.c (overlay_invalidate_all, find_pc_overlay)
14366         (find_pc_mapped_section, list_overlays_command)
14367         (map_overlay_command, unmap_overlay_command)
14368         (simple_overlay_update): Use all_objfiles.
14369         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
14370         * printcmd.c (info_symbol_command): Use all_objfiles.
14371         * objfiles.h (ALL_OBJSECTIONS): Remove.
14372         * maint.c (maintenance_translate_address): Use all_objfiles.
14373         * gcore.c (gcore_create_callback): Use all_objfiles.
14374         (objfile_find_memory_regions): Likewise.
14375
14376 2019-01-09  Tom Tromey  <tom@tromey.com>
14377
14378         * symtab.c (find_line_symtab, info_sources_command)
14379         (make_source_files_completion_list): Use objfile_compunits.
14380         * source.c (select_source_symtab): Use objfile_compunits.
14381         * objfiles.h (struct objfile): Update comment.
14382         (ALL_OBJFILES): Remove.
14383         (ALL_FILETABS): Remove.
14384         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
14385         objfile_compunits.
14386
14387 2019-01-09  Tom Tromey  <tom@tromey.com>
14388
14389         * symmisc.c (print_objfile_statistics, dump_objfile)
14390         (maintenance_print_symbols): Use compunit_filetabs.
14391         * source.c (forget_cached_source_info_for_objfile): Use
14392         compunit_filetabs.
14393         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
14394         (ALL_FILETABS): Use compunit_filetabs.
14395         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
14396         * coffread.c (coff_symtab_read): Use compunit_filetabs.
14397
14398 2019-01-09  Tom Tromey  <tom@tromey.com>
14399
14400         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
14401         (compunit_filetabs): New.
14402         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
14403         compunit_filetabs.
14404         (info_sources_command, make_source_files_completion_list): Remove
14405         declaration.
14406         * symmisc.c (print_objfile_statistics, dump_objfile)
14407         (maintenance_print_symbols): Remove declaration.
14408         (maintenance_info_symtabs): Use compunit_filetabs.
14409         (maintenance_info_line_tables): Likewise.
14410         * source.c (select_source_symtab): Change local variable name.
14411         (forget_cached_source_info_for_objfile): Remove declaration.
14412         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
14413         * objfiles.c (objfile_relocate1): Remove declaration.
14414         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
14415         declaration.
14416         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
14417         * coffread.c (coff_symtab_read): Remove declaration.
14418         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
14419         compunit_filetabs.
14420
14421 2019-01-09  Tom Tromey  <tom@tromey.com>
14422
14423         * symtab.c (lookup_objfile_from_block)
14424         (find_pc_sect_compunit_symtab, search_symbols)
14425         (default_collect_symbol_completion_matches_break_on): Use
14426         objfile_compunits.
14427         * objfiles.h (ALL_COMPUNITS): Remove.
14428         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
14429         * cp-support.c (add_symbol_overload_list_qualified): Use
14430         objfile_compunits.
14431         * ada-lang.c (ada_collect_symbol_completion_matches)
14432         (ada_add_global_exceptions): Use objfile_compunits.
14433
14434 2019-01-09  Tom Tromey  <tom@tromey.com>
14435
14436         * source.c (select_source_symtab)
14437         (forget_cached_source_info_for_objfile): Remove declaration.
14438         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
14439         declaration.
14440         * maint.c (count_symtabs_and_blocks): Remove declaration.
14441         * cp-support.c (add_symbol_overload_list_qualified): Remove
14442         declaration.
14443         * coffread.c (coff_symtab_read): Remove declaration.
14444         * symtab.c (lookup_symbol_in_objfile_symtabs)
14445         (basic_lookup_transparent_type_1): Use objfile_compunits.
14446         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
14447         (info_sources_command, search_symbols)
14448         (default_collect_symbol_completion_matches_break_on)
14449         (make_source_files_completion_list): Remove declaration.
14450         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
14451         (ada_collect_symbol_completion_matches)
14452         (ada_add_global_exceptions): Remove declaration.
14453         * linespec.c (iterate_over_all_matching_symtabs): Use
14454         objfile_compunits.
14455         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
14456         (class objfile_compunits): New.
14457         (ALL_COMPUNITS): Use objfile_compunits.
14458         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
14459         (maintenance_check_symtabs, maintenance_info_line_tables): Use
14460         objfile_compunits.
14461         * objfiles.c (objfile_relocate1): Use objfile_compunits.
14462
14463 2019-01-09  Tom Tromey  <tom@tromey.com>
14464
14465         * symtab.c (search_symbols)
14466         (default_collect_symbol_completion_matches_break_on): Use
14467         objfile_msymbols.
14468         * ada-lang.c (ada_lookup_simple_minsym)
14469         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
14470         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
14471         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
14472         objfile_msymbols.
14473         * coffread.c (coff_symfile_read): Use objfile_msymbols.
14474         * symmisc.c (dump_msymbols): Use objfile_msymbols.
14475         * objc-lang.c (find_methods): Use objfile_msymbols.
14476         (info_selectors_command, info_classes_command): Likewise.
14477         * stabsread.c (scan_file_globals): Use objfile_msymbols.
14478         * objfiles.h (class objfile_msymbols): New.
14479         (ALL_OBJFILE_MSYMBOLS): Remove.
14480         (ALL_MSYMBOLS): Remove.
14481
14482 2019-01-09  Tom Tromey  <tom@tromey.com>
14483
14484         * common/next-iterator.h (next_adapter): Add Iterator template
14485         parameter.
14486         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
14487         (class all_objfiles_safe): New.
14488         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
14489         * objfiles.c (put_objfile_before): Update comment.
14490         (add_separate_debug_objfile): Likewise.
14491         (free_all_objfiles): Use all_objfiles_safe.
14492         (objfile_purge_solibs): Likewise.
14493
14494 2019-01-09  Tom Tromey  <tom@tromey.com>
14495
14496         * symtab.c (iterate_over_symtabs, matching_obj_sections)
14497         (expand_symtab_containing_pc, lookup_static_symbol)
14498         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
14499         (find_symbol_at_address, find_line_symtab, find_main_name): Use
14500         all_objfiles.
14501         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
14502         * breakpoint.c (create_overlay_event_breakpoint)
14503         (create_longjmp_master_breakpoint)
14504         (create_std_terminate_master_breakpoint)
14505         (create_exception_master_breakpoint): Use all_objfiles.
14506         * linux-thread-db.c (try_thread_db_load_from_pdir)
14507         (has_libpthread): Use all_objfiles.
14508         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
14509         * linespec.c (iterate_over_all_matching_symtabs)
14510         (search_minsyms_for_name): Use all_objfiles.
14511         * maint.c (maintenance_info_sections): Use all_objfiles.
14512         * main.c (captured_main_1): Use all_objfiles.
14513         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
14514         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
14515         * guile/scm-pretty-print.c
14516         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
14517         * solib-spu.c (append_ocl_sos): Use all_objfiles.
14518         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
14519         (maintenance_print_msymbols): Use all_objfiles.
14520         * source.c (select_source_symtab): Use all_objfiles.
14521         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
14522         * symfile.c (remove_symbol_file_command)
14523         (expand_symtabs_matching, map_symbol_filenames): Use
14524         all_objfiles.
14525         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
14526         all_objfiles.
14527         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
14528         * objc-lang.c (find_methods): Use all_objfiles.
14529         * objfiles.c (have_partial_symbols, have_full_symbols)
14530         (have_minimal_symbols, qsort_cmp)
14531         (default_iterate_over_objfiles_in_search_order): Use
14532         all_objfiles.
14533         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
14534         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
14535         (maintenance_check_psymtabs): Use all_objfiles.
14536         (ALL_PSYMTABS): Remove.
14537         * compile/compile-object-run.c (do_module_cleanup): Use
14538         all_objfiles.
14539         * blockframe.c (find_pc_partial_function): Use all_objfiles.
14540         * cp-support.c (add_symbol_overload_list_qualified): Use
14541         all_objfiles.
14542         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
14543         Use all_objfiles.
14544         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
14545         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
14546         all_objfiles.
14547         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
14548         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
14549         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
14550         Uses all_objfiles.
14551         * solib.c (solib_read_symbols): Use all_objfiles
14552
14553 2019-01-09  Tom Tromey  <tom@tromey.com>
14554
14555         * probe.c (parse_probes_in_pspace): Use all_objfiles.
14556         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
14557         all_objfiles.
14558         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
14559         * symmisc.c (print_symbol_bcache_statistics)
14560         (print_objfile_statistics, maintenance_print_objfiles)
14561         (maintenance_info_symtabs, maintenance_check_symtabs)
14562         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
14563         all_objfiles.
14564         * source.c (forget_cached_source_info): Use all_objfiles.
14565         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
14566         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
14567         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
14568         * objfiles.c (update_section_map): Use all_objfiles.
14569         (shared_objfile_contains_address_p): Likewise.
14570         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
14571         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
14572
14573 2019-01-09  Tom Tromey  <tom@tromey.com>
14574
14575         * common/next-iterator.h: New file.
14576         * objfiles.h (class all_objfiles): New.
14577         (struct objfile_iterator): New.
14578
14579 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14580
14581         * NEWS: Move the description of the changed "frame", "select-frame",
14582          and "info frame" commands to the Changed commands section.
14583
14584 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
14585
14586         * gdbtypes.c (check_stub_method_group): Remove handling of old
14587         mangling schemes.
14588         * linespec.c (find_methods): Likewise.
14589         * stabsread.c (read_member_functions): Likewise.
14590         * valops.c (search_struct_method): Likewise.
14591         (value_struct_elt_for_reference): Likewise.
14592         * NEWS: Mention this change.
14593
14594 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
14595
14596         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
14597         print_source_lines.
14598         * source.c (print_source_lines_base): Update line number check.
14599         (print_source_lines): New function.
14600         (source_lines_range::source_lines_range): New function.
14601         * source.h (class source_lines_range): New class.
14602         (print_source_lines): New declaration.
14603
14604 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14605
14606         * linespec.c (linespec_state_destructor): Free self->canonical_names.
14607
14608 2019-01-08  Tom Tromey  <tom@tromey.com>
14609             Simon Marchi  <simon.marchi@ericsson.com>
14610
14611         PR gdb/24060
14612         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
14613         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
14614         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
14615         * f-exp.y (DOLLAR_VARIABLE): Likewise.
14616         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
14617         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
14618
14619 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
14620
14621         * source.c (select_source_symtab): Move header comment to
14622         declaration in source.h.
14623         (forget_cached_source_info_for_objfile): Likewise.
14624         (forget_cached_source_info): Likewise.
14625         (identify_source_line): Likewise.
14626         * source.h (identify_source_line): Move declaration from symtab.h
14627         and add comment from source.c
14628         (print_source_lines): Likewise.
14629         (forget_cached_source_info_for_objfile): Likewise.
14630         (forget_cached_source_info): Likewise.
14631         (select_source_symtab): Likewise.
14632         (enum print_source_lines_flag): Move definition from symtab.h.
14633         * symtab.h (identify_source_line): Move declaration to source.h.
14634         (print_source_lines): Likewise.
14635         (forget_cached_source_info_for_objfile): Likewise.
14636         (forget_cached_source_info): Likewise.
14637         (select_source_symtab): Likewise.
14638         (enum print_source_lines_flag): Move definition to source.h.
14639         * tui/tui-hooks.c: Add 'source.h' include.
14640
14641 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
14642
14643         * source.c (print_source_lines_base): Handle requests to print
14644         reverse line number sequences, and guard against empty lines
14645         string.
14646
14647 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
14648
14649         * source.c (print_source_lines_base): Fix skip of '\r' if next
14650         character is '\n'.
14651
14652 2019-01-06  Tom Tromey  <tom@tromey.com>
14653
14654         * c-exp.y (struct c_parse_state) <macro_original_text,
14655         expansion_obstack>: New member.
14656         (macro_original_text, expansion_obstack): Remove globals.
14657         (scan_macro_expansion, scanning_macro_expansion)
14658         (finished_macro_expansion): Update.
14659         (scan_macro_cleanup): Remove.
14660         (yylex, c_parse): Update.
14661
14662 2019-01-06  Tom Tromey  <tom@tromey.com>
14663
14664         * c-exp.y (struct c_parse_state) <strings>: New member.
14665         (operator_stoken): Update.
14666
14667 2019-01-06  Tom Tromey  <tom@tromey.com>
14668
14669         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
14670         (union type_stack_elt) <typelist_val>: Now a pointer to
14671         std::vector.
14672         (type_stack_cleanup): Don't declare.
14673         (push_typelist): Update.
14674         * parse.c (pop_typelist): Return a std::vector.
14675         (push_typelist): Take a std::vector.
14676         (follow_types): Update.  Do not free args.
14677         (type_stack_cleanup): Remove.
14678         * c-exp.y (struct c_parse_state): New.
14679         (cpstate): New global.
14680         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
14681         (nonempty_typelist): Update.
14682         (func_mod): Create a new vector.
14683         (c_parse): Create a c_parse_state.
14684         (check_parameter_typelist): Do not delete params.
14685         (function_method): Update.  Do not delete type_list.
14686
14687 2019-01-06  Tom Tromey  <tom@tromey.com>
14688
14689         PR gdb/28155:
14690         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
14691         check_typedef.
14692         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
14693         (print_return_value): Likewise.
14694
14695 2019-01-05  Tom Tromey  <tom@tromey.com>
14696
14697         * contrib/cleanup_check.py: Remove.
14698         * contrib/gcc-with-excheck: Remove.
14699         * contrib/exsummary.py: Remove.
14700         * contrib/excheck.py: Remove.
14701
14702 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
14703
14704         * thread.c (delete_thread_1): Add gdb_assert that THR is not
14705         NULL. Initialize tpprev to NULL instead of assigning it
14706         to NULL on the next statement.
14707         * windows-nat.c (windows_delete_thread): Remove check for
14708         main_thread_id before printing thread exit notifications.
14709         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
14710         Remove thread ID check against main_thread_id.
14711         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
14712         windows_delete_thread.
14713         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
14714
14715 2019-01-04  Tom Tromey  <tom@tromey.com>
14716
14717         * compile/compile.c (_initialize_compile): Use upper case for
14718         metasyntactic variables.
14719         * symmisc.c (_initialize_symmisc): Use upper case for
14720         metasyntactic variables.
14721         * psymtab.c (_initialize_psymtab): Use upper case for
14722         metasyntactic variables.
14723         * demangle.c (demangle_command): Use upper case for metasyntactic
14724         variables.
14725         (_initialize_demangler): Likewise.
14726         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
14727         variables.
14728
14729 2019-01-03  Tom Tromey  <tom@tromey.com>
14730
14731         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
14732
14733 2019-01-03  Tom Tromey  <tom@tromey.com>
14734
14735         * python/py-symtab.c (salpy_str): Update.
14736         (struct salpy_sal_object) <symtab>: Now a PyObject.
14737         (salpy_dealloc): Update.
14738         (del_objfile_sal): Use gdbpy_ref.
14739
14740 2019-01-03  Tom Tromey  <tom@tromey.com>
14741
14742         * python/py-type.c (convert_field): Use new_reference.  Return
14743         gdbpy_ref.
14744         (make_fielditem): Return gdbpy_ref.
14745         (typy_fields): Update.
14746         (typy_getitem): Update.
14747         (field_name): Return gdbpy_ref.  Use new_reference.
14748         (typy_iterator_iternext): Update.
14749
14750 2019-01-03  Tom Tromey  <tom@tromey.com>
14751
14752         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
14753
14754 2019-01-03  Tom Tromey  <tom@tromey.com>
14755
14756         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
14757         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
14758         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
14759         (pspy_set_frame_filters, pspy_set_frame_unwinders)
14760         (pspy_set_type_printers): Likewise.
14761         * python/py-function.c (fnpy_init): Use gdbpy_ref.
14762         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
14763         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
14764         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
14765         (objfpy_set_type_printers): Likewise.
14766
14767 2019-01-03  Tom Tromey  <tom@tromey.com>
14768
14769         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
14770         (gdbpy_print_stack): Use gdbpy_err_fetch.
14771         * python/python-internal.h (class gdbpy_err_fetch): New class.
14772         (class gdbpy_enter) <m_error_type, m_error_value,
14773         m_error_traceback>: Remove.
14774         <m_error>: New member.
14775         (gdbpy_exception_to_string): Don't declare.
14776         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
14777         * python/py-value.c (convert_value_from_python): Use
14778         gdbpy_err_fetch.
14779         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
14780         gdbpy_exception_to_string.
14781         (gdbpy_handle_exception): Use gdbpy_err_fetch.
14782         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
14783         gdbpy_err_fetch.
14784
14785 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
14786
14787         * linux-nat.c (delete_lwp_cleanup): Delete.
14788         (struct lwp_deleter): New struct.
14789         (lwp_info_up): New typedef.
14790         (linux_nat_target::follow_fork): Delete cleanup, and make use of
14791         lwp_info_up.
14792
14793 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
14794
14795         * linux-fork.c (class scoped_switch_fork_info): New class.
14796         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
14797
14798 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
14799
14800         * valops.c (find_overload_match): Remove use of null_cleanup, and
14801         calls to do_cleanups.
14802
14803 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
14804
14805         * compile/compile-cplus-types.c
14806         (compile_cplus_instance::decl_name): Handle changes to
14807         cp_func_name.
14808         * cp-support.c (cp_func_name): Update header comment, update
14809         return type.
14810         * cp-support.h (cp_func_name): Update return type in declaration.
14811         * valops.c (find_overload_match): Move temp_func local to top
14812         level of function and change its type.  Use temp_func to hold and
14813         delete temporary string obtained from cp_func_name.
14814
14815 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
14816
14817         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
14818         gdb::char_vector, remove cleanup, and update uses of `msg`.
14819
14820 2019-01-03  Jim Wilson  <jimw@sifive.com>
14821
14822         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
14823
14824 2019-01-02  Tom Tromey  <tom@tromey.com>
14825
14826         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
14827         (tdesc_parse_xml): Remove cleanups.
14828         * target-descriptions.h (make_cleanup_free_target_description):
14829         Don't declare.
14830         (target_desc_deleter): New struct.
14831         (target_desc_up): New typedef.
14832         * target-descriptions.c (target_desc_deleter::operator()): Rename
14833         from free_target_description.
14834         (make_cleanup_free_target_description): Remove.
14835
14836 2019-01-02  Tom Tromey  <tom@tromey.com>
14837
14838         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
14839         constructor, destructor.
14840         (linespec_parser): Remove typedef.
14841         (~linespec_parser): Rename from linespec_parser_delete.
14842         (linespec_lex_to_end, linespec_complete_label)
14843         (linespec_complete): Update.
14844         (decode_line_full): Remove cleanups.
14845         (decode_line_1): Update.
14846
14847 2019-01-02  Tom Tromey  <tom@tromey.com>
14848
14849         * python/python-internal.h (inferior_to_inferior_object): Change
14850         return type.
14851         * python/py-exitedevent.c (create_exited_event_object): Update.
14852         * python/py-inferior.c (inferior_to_inferior_object): Return
14853         gdbpy_ref.
14854         (python_new_inferior, python_inferior_deleted)
14855         (thread_to_thread_object, delete_thread_object)
14856         (build_inferior_list, gdbpy_selected_inferior): Update.
14857         * python/py-infthread.c (create_thread_object): Update.  Also fail
14858         if inferior_to_inferior_object fails.
14859
14860 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
14861
14862         * inferior.h (class inferior) <displaced_step_state>: New field.
14863         * infrun.h (struct displaced_step_state): Move here from
14864         infrun.c.  Initialize fields, add constructor.
14865         <inf>: Remove field.
14866         <reset>: New method.
14867         * infrun.c (struct displaced_step_inferior_state): Move to
14868         infrun.h.
14869         (displaced_step_inferior_states): Remove.
14870         (get_displaced_stepping_state): Adust.
14871         (displaced_step_in_progress_any_inferior): Adjust.
14872         (displaced_step_in_progress_thread): Adjust.
14873         (displaced_step_in_progress): Adjust.
14874         (add_displaced_stepping_state): Remove.
14875         (get_displaced_step_closure_by_addr): Adjust.
14876         (remove_displaced_stepping_state): Remove.
14877         (infrun_inferior_exit): Call displaced_step_state.reset.
14878         (use_displaced_stepping): Don't check for NULL.
14879         (displaced_step_prepare_throw): Call
14880         get_displaced_stepping_state.
14881         (displaced_step_fixup): Don't check for NULL.
14882         (prepare_for_detach): Don't check for NULL.
14883
14884 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14885
14886         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
14887          in case of call that did not complete.
14888
14889 2019-01-02  Andrey Utkin  <autkin@undo.io>
14890
14891         * symfile.c (find_separate_debug_file): Fix search of debug files for
14892         remote debuggee.
14893
14894 2019-01-02  Tom Tromey  <tom@tromey.com>
14895
14896         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
14897         indentation.
14898         * python/py-frame.c (frapy_older): Remove cast.
14899         (frapy_newer): Likewise.
14900         * python/py-breakpoint.c (local_setattro): Remove cast.
14901         * python/py-arch.c (archpy_name): Remove local variable.
14902         * python/py-type.c (gdbpy_lookup_type): Remove cast.
14903
14904 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
14905
14906         * unittests/basic_string_view/element_access/char/empty.cc:
14907         Fix year range in copyright header.
14908
14909 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
14910
14911         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
14912         Delete.
14913         <operator==>: Update with for removed field.
14914         <hash>: Likewise.
14915         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
14916         <isa_features>: ...this.
14917         <abi_features>: New field.
14918         (riscv_isa_flen): Update comment.
14919         (riscv_abi_xlen): New declaration.
14920         (riscv_abi_flen): New declaration.
14921         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
14922         isa_features.
14923         (riscv_abi_xlen): New function.
14924         (riscv_isa_flen): Update to get answer from isa_features.
14925         (riscv_abi_flen): New function.
14926         (riscv_has_fp_abi): Update to get answer from abi_features.
14927         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
14928         xlen and flen.
14929         (riscv_call_info) <xlen, flen>: Update comment.
14930         (riscv_call_arg_struct): Remove invalid assertions
14931         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
14932         is removed.
14933         (riscv_gdbarch_init): Gather isa features and abi features
14934         separately, ensure both match on the gdbarch when reusing an old
14935         gdbarch.  Relax an error check to allow 32-bit abi float to run on
14936         a target with 64-bit float hardware.
14937
14938 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14939
14940         * source.c (search_command_helper): Stop reverse search
14941         when line 1 has been searched.
14942
14943 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14944
14945         * record-full.c (record_full_base_target::close): Rewrite
14946         record_full_core_buf_list free logic.
14947
14948 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14949
14950         * break-catch-syscall.c (print_one_catch_syscall): xfree
14951         the last text.
14952
14953 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
14954
14955         * top.c (print_gdb_version): Update Copyright year in version
14956         message.
14957
14958 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
14959
14960         Update copyright year range in all GDB files.
14961
14962 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
14963
14964         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
14965
14966 For older changes see ChangeLog-2018.
14967 \f
14968 Local Variables:
14969 mode: change-log
14970 left-margin: 8
14971 fill-column: 74
14972 version-control: never
14973 coding: utf-8
14974 End:
14975